blob: 3cc312dbd91f23db9c2d55a18a7109ac24e8a0d0 [file] [log] [blame]
Jiyong Park25fc6a92018-11-18 18:02:45 +09001// Copyright 2018 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package apex
16
17import (
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +090018 "fmt"
Jiyong Park25fc6a92018-11-18 18:02:45 +090019 "os"
Jooyung Han39edb6c2019-11-06 16:53:07 +090020 "path"
Paul Duffin37856732021-02-26 14:24:15 +000021 "path/filepath"
Jaewoong Jung22f7d182019-07-16 18:25:41 -070022 "reflect"
Paul Duffin9b879592020-05-26 13:21:35 +010023 "regexp"
Jooyung Han31c470b2019-10-18 16:26:59 +090024 "sort"
Jiyong Parkd4a3a132021-03-17 20:21:35 +090025 "strconv"
Jiyong Park25fc6a92018-11-18 18:02:45 +090026 "strings"
27 "testing"
Jiyong Parkda6eb592018-12-19 17:12:36 +090028
29 "github.com/google/blueprint/proptools"
30
31 "android/soong/android"
markchien2f59ec92020-09-02 16:23:38 +080032 "android/soong/bpf"
Jiyong Parkda6eb592018-12-19 17:12:36 +090033 "android/soong/cc"
Ulya Trafimovichb28cc372020-01-13 15:18:16 +000034 "android/soong/dexpreopt"
Jaewoong Jung4b79e982020-06-01 10:45:49 -070035 prebuilt_etc "android/soong/etc"
Jiyong Parkb2742fd2019-02-11 11:38:15 +090036 "android/soong/java"
Jiyong Park99644e92020-11-17 22:21:02 +090037 "android/soong/rust"
Jaewoong Jung4b79e982020-06-01 10:45:49 -070038 "android/soong/sh"
Jiyong Park25fc6a92018-11-18 18:02:45 +090039)
40
Jooyung Hand3639552019-08-09 12:57:43 +090041// names returns name list from white space separated string
42func names(s string) (ns []string) {
43 for _, n := range strings.Split(s, " ") {
44 if len(n) > 0 {
45 ns = append(ns, n)
46 }
47 }
48 return
49}
50
Paul Duffin40b62572021-03-20 11:39:01 +000051func testApexError(t *testing.T, pattern, bp string, preparers ...android.FixturePreparer) {
Jooyung Han344d5432019-08-23 11:17:39 +090052 t.Helper()
Paul Duffin284165a2021-03-29 01:50:31 +010053 android.GroupFixturePreparers(
54 prepareForApexTest,
55 android.GroupFixturePreparers(preparers...),
56 ).
Paul Duffine05480a2021-03-08 15:07:14 +000057 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)).
Paul Duffin40b62572021-03-20 11:39:01 +000058 RunTestWithBp(t, bp)
Jooyung Han5c998b92019-06-27 11:30:33 +090059}
60
Paul Duffin40b62572021-03-20 11:39:01 +000061func testApex(t *testing.T, bp string, preparers ...android.FixturePreparer) *android.TestContext {
Jooyung Han344d5432019-08-23 11:17:39 +090062 t.Helper()
Paul Duffin284165a2021-03-29 01:50:31 +010063
64 optionalBpPreparer := android.NullFixturePreparer
Paul Duffin40b62572021-03-20 11:39:01 +000065 if bp != "" {
Paul Duffin284165a2021-03-29 01:50:31 +010066 optionalBpPreparer = android.FixtureWithRootAndroidBp(bp)
Paul Duffin40b62572021-03-20 11:39:01 +000067 }
Paul Duffin284165a2021-03-29 01:50:31 +010068
69 result := android.GroupFixturePreparers(
70 prepareForApexTest,
71 android.GroupFixturePreparers(preparers...),
72 optionalBpPreparer,
73 ).RunTest(t)
74
Paul Duffine05480a2021-03-08 15:07:14 +000075 return result.TestContext
Jooyung Han5c998b92019-06-27 11:30:33 +090076}
77
Paul Duffin810f33d2021-03-09 14:12:32 +000078func withFiles(files android.MockFS) android.FixturePreparer {
79 return files.AddToFixture()
Jooyung Han344d5432019-08-23 11:17:39 +090080}
81
Paul Duffin810f33d2021-03-09 14:12:32 +000082func withTargets(targets map[android.OsType][]android.Target) android.FixturePreparer {
83 return android.FixtureModifyConfig(func(config android.Config) {
Jooyung Han344d5432019-08-23 11:17:39 +090084 for k, v := range targets {
85 config.Targets[k] = v
86 }
Paul Duffin810f33d2021-03-09 14:12:32 +000087 })
Jooyung Han344d5432019-08-23 11:17:39 +090088}
89
Jooyung Han35155c42020-02-06 17:33:20 +090090// withNativeBridgeTargets sets configuration with targets including:
91// - X86_64 (primary)
92// - X86 (secondary)
93// - Arm64 on X86_64 (native bridge)
94// - Arm on X86 (native bridge)
Paul Duffin810f33d2021-03-09 14:12:32 +000095var withNativeBridgeEnabled = android.FixtureModifyConfig(
96 func(config android.Config) {
97 config.Targets[android.Android] = []android.Target{
98 {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "silvermont", Abi: []string{"arm64-v8a"}},
99 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
100 {Os: android.Android, Arch: android.Arch{ArchType: android.X86, ArchVariant: "silvermont", Abi: []string{"armeabi-v7a"}},
101 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
102 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}},
103 NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86_64", NativeBridgeRelativePath: "arm64"},
104 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
105 NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86", NativeBridgeRelativePath: "arm"},
106 }
107 },
108)
109
110func withManifestPackageNameOverrides(specs []string) android.FixturePreparer {
111 return android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
112 variables.ManifestPackageNameOverrides = specs
113 })
Jooyung Han35155c42020-02-06 17:33:20 +0900114}
115
Paul Duffin810f33d2021-03-09 14:12:32 +0000116var withBinder32bit = android.FixtureModifyProductVariables(
117 func(variables android.FixtureProductVariables) {
118 variables.Binder32bit = proptools.BoolPtr(true)
119 },
120)
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900121
Paul Duffin810f33d2021-03-09 14:12:32 +0000122var withUnbundledBuild = android.FixtureModifyProductVariables(
123 func(variables android.FixtureProductVariables) {
124 variables.Unbundled_build = proptools.BoolPtr(true)
125 },
126)
Jiyong Park7cd10e32020-01-14 09:22:18 +0900127
Paul Duffin284165a2021-03-29 01:50:31 +0100128// Legacy preparer used for running tests within the apex package.
129//
130// This includes everything that was needed to run any test in the apex package prior to the
131// introduction of the test fixtures. Tests that are being converted to use fixtures directly
132// rather than through the testApex...() methods should avoid using this and instead use the
133// various preparers directly, using android.GroupFixturePreparers(...) to group them when
134// necessary.
135//
136// deprecated
137var prepareForApexTest = android.GroupFixturePreparers(
Paul Duffin37aad602021-03-08 09:47:16 +0000138 // General preparers in alphabetical order as test infrastructure will enforce correct
139 // registration order.
140 android.PrepareForTestWithAndroidBuildComponents,
141 bpf.PrepareForTestWithBpf,
142 cc.PrepareForTestWithCcBuildComponents,
143 java.PrepareForTestWithJavaDefaultModules,
144 prebuilt_etc.PrepareForTestWithPrebuiltEtc,
145 rust.PrepareForTestWithRustDefaultModules,
146 sh.PrepareForTestWithShBuildComponents,
147
148 PrepareForTestWithApexBuildComponents,
149
150 // Additional apex test specific preparers.
151 android.FixtureAddTextFile("system/sepolicy/Android.bp", `
152 filegroup {
153 name: "myapex-file_contexts",
154 srcs: [
155 "apex/myapex-file_contexts",
156 ],
157 }
158 `),
Paul Duffin52bfaa42021-03-23 23:40:12 +0000159 prepareForTestWithMyapex,
Paul Duffin37aad602021-03-08 09:47:16 +0000160 android.FixtureMergeMockFs(android.MockFS{
Paul Duffin52bfaa42021-03-23 23:40:12 +0000161 "a.java": nil,
162 "PrebuiltAppFoo.apk": nil,
163 "PrebuiltAppFooPriv.apk": nil,
164 "apex_manifest.json": nil,
165 "AndroidManifest.xml": nil,
Paul Duffin37aad602021-03-08 09:47:16 +0000166 "system/sepolicy/apex/myapex.updatable-file_contexts": nil,
167 "system/sepolicy/apex/myapex2-file_contexts": nil,
168 "system/sepolicy/apex/otherapex-file_contexts": nil,
169 "system/sepolicy/apex/com.android.vndk-file_contexts": nil,
170 "system/sepolicy/apex/com.android.vndk.current-file_contexts": nil,
171 "mylib.cpp": nil,
172 "mytest.cpp": nil,
173 "mytest1.cpp": nil,
174 "mytest2.cpp": nil,
175 "mytest3.cpp": nil,
176 "myprebuilt": nil,
177 "my_include": nil,
178 "foo/bar/MyClass.java": nil,
179 "prebuilt.jar": nil,
180 "prebuilt.so": nil,
181 "vendor/foo/devkeys/test.x509.pem": nil,
182 "vendor/foo/devkeys/test.pk8": nil,
183 "testkey.x509.pem": nil,
184 "testkey.pk8": nil,
185 "testkey.override.x509.pem": nil,
186 "testkey.override.pk8": nil,
187 "vendor/foo/devkeys/testkey.avbpubkey": nil,
188 "vendor/foo/devkeys/testkey.pem": nil,
189 "NOTICE": nil,
190 "custom_notice": nil,
191 "custom_notice_for_static_lib": nil,
192 "testkey2.avbpubkey": nil,
193 "testkey2.pem": nil,
194 "myapex-arm64.apex": nil,
195 "myapex-arm.apex": nil,
196 "myapex.apks": nil,
197 "frameworks/base/api/current.txt": nil,
198 "framework/aidl/a.aidl": nil,
199 "build/make/core/proguard.flags": nil,
200 "build/make/core/proguard_basic_keeps.flags": nil,
201 "dummy.txt": nil,
202 "baz": nil,
203 "bar/baz": nil,
204 "testdata/baz": nil,
205 "AppSet.apks": nil,
206 "foo.rs": nil,
207 "libfoo.jar": nil,
208 "libbar.jar": nil,
209 },
210 ),
211
212 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
213 variables.DeviceVndkVersion = proptools.StringPtr("current")
214 variables.DefaultAppCertificate = proptools.StringPtr("vendor/foo/devkeys/test")
215 variables.CertificateOverrides = []string{"myapex_keytest:myapex.certificate.override"}
216 variables.Platform_sdk_codename = proptools.StringPtr("Q")
217 variables.Platform_sdk_final = proptools.BoolPtr(false)
Pedro Loureiroc3621422021-09-28 15:40:23 +0000218 // "Tiramisu" needs to be in the next line for compatibility with soong code,
219 // not because of these tests specifically (it's not used by the tests)
220 variables.Platform_version_active_codenames = []string{"Q", "Tiramisu"}
Jiyong Parkf58c46e2021-04-01 21:35:20 +0900221 variables.Platform_vndk_version = proptools.StringPtr("29")
Paul Duffin37aad602021-03-08 09:47:16 +0000222 }),
223)
224
Paul Duffin52bfaa42021-03-23 23:40:12 +0000225var prepareForTestWithMyapex = android.FixtureMergeMockFs(android.MockFS{
226 "system/sepolicy/apex/myapex-file_contexts": nil,
227})
228
Jooyung Han643adc42020-02-27 13:50:06 +0900229// ensure that 'result' equals 'expected'
230func ensureEquals(t *testing.T, result string, expected string) {
231 t.Helper()
232 if result != expected {
233 t.Errorf("%q != %q", expected, result)
234 }
235}
236
Jiyong Park25fc6a92018-11-18 18:02:45 +0900237// ensure that 'result' contains 'expected'
238func ensureContains(t *testing.T, result string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900239 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900240 if !strings.Contains(result, expected) {
241 t.Errorf("%q is not found in %q", expected, result)
242 }
243}
244
Liz Kammer5bd365f2020-05-27 15:15:11 -0700245// ensure that 'result' contains 'expected' exactly one time
246func ensureContainsOnce(t *testing.T, result string, expected string) {
247 t.Helper()
248 count := strings.Count(result, expected)
249 if count != 1 {
250 t.Errorf("%q is found %d times (expected 1 time) in %q", expected, count, result)
251 }
252}
253
Jiyong Park25fc6a92018-11-18 18:02:45 +0900254// ensures that 'result' does not contain 'notExpected'
255func ensureNotContains(t *testing.T, result string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900256 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900257 if strings.Contains(result, notExpected) {
258 t.Errorf("%q is found in %q", notExpected, result)
259 }
260}
261
Sasha Smundak18d98bc2020-05-27 16:36:07 -0700262func ensureMatches(t *testing.T, result string, expectedRex string) {
263 ok, err := regexp.MatchString(expectedRex, result)
264 if err != nil {
265 t.Fatalf("regexp failure trying to match %s against `%s` expression: %s", result, expectedRex, err)
266 return
267 }
268 if !ok {
269 t.Errorf("%s does not match regular expession %s", result, expectedRex)
270 }
271}
272
Jiyong Park25fc6a92018-11-18 18:02:45 +0900273func ensureListContains(t *testing.T, result []string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900274 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900275 if !android.InList(expected, result) {
276 t.Errorf("%q is not found in %v", expected, result)
277 }
278}
279
280func ensureListNotContains(t *testing.T, result []string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900281 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900282 if android.InList(notExpected, result) {
283 t.Errorf("%q is found in %v", notExpected, result)
284 }
285}
286
Jooyung Hane1633032019-08-01 17:41:43 +0900287func ensureListEmpty(t *testing.T, result []string) {
288 t.Helper()
289 if len(result) > 0 {
290 t.Errorf("%q is expected to be empty", result)
291 }
292}
293
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +0000294func ensureListNotEmpty(t *testing.T, result []string) {
295 t.Helper()
296 if len(result) == 0 {
297 t.Errorf("%q is expected to be not empty", result)
298 }
299}
300
Jiyong Park25fc6a92018-11-18 18:02:45 +0900301// Minimal test
302func TestBasicApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800303 ctx := testApex(t, `
Jiyong Park30ca9372019-02-07 16:27:23 +0900304 apex_defaults {
305 name: "myapex-defaults",
Jiyong Park809bb722019-02-13 21:33:49 +0900306 manifest: ":myapex.manifest",
307 androidManifest: ":myapex.androidmanifest",
Jiyong Park25fc6a92018-11-18 18:02:45 +0900308 key: "myapex.key",
Jiyong Park99644e92020-11-17 22:21:02 +0900309 binaries: ["foo.rust"],
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900310 native_shared_libs: [
311 "mylib",
312 "libfoo.ffi",
313 ],
Jiyong Park99644e92020-11-17 22:21:02 +0900314 rust_dyn_libs: ["libfoo.dylib.rust"],
Alex Light3d673592019-01-18 14:37:31 -0800315 multilib: {
316 both: {
Jiyong Park99644e92020-11-17 22:21:02 +0900317 binaries: ["foo"],
Alex Light3d673592019-01-18 14:37:31 -0800318 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900319 },
Jiyong Park77acec62020-06-01 21:39:15 +0900320 java_libs: [
321 "myjar",
322 "myjar_dex",
323 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000324 updatable: false,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900325 }
326
Jiyong Park30ca9372019-02-07 16:27:23 +0900327 apex {
328 name: "myapex",
329 defaults: ["myapex-defaults"],
330 }
331
Jiyong Park25fc6a92018-11-18 18:02:45 +0900332 apex_key {
333 name: "myapex.key",
334 public_key: "testkey.avbpubkey",
335 private_key: "testkey.pem",
336 }
337
Jiyong Park809bb722019-02-13 21:33:49 +0900338 filegroup {
339 name: "myapex.manifest",
340 srcs: ["apex_manifest.json"],
341 }
342
343 filegroup {
344 name: "myapex.androidmanifest",
345 srcs: ["AndroidManifest.xml"],
346 }
347
Jiyong Park25fc6a92018-11-18 18:02:45 +0900348 cc_library {
349 name: "mylib",
350 srcs: ["mylib.cpp"],
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900351 shared_libs: [
352 "mylib2",
353 "libbar.ffi",
354 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900355 system_shared_libs: [],
356 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000357 // TODO: remove //apex_available:platform
358 apex_available: [
359 "//apex_available:platform",
360 "myapex",
361 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900362 }
363
Alex Light3d673592019-01-18 14:37:31 -0800364 cc_binary {
365 name: "foo",
366 srcs: ["mylib.cpp"],
367 compile_multilib: "both",
368 multilib: {
369 lib32: {
370 suffix: "32",
371 },
372 lib64: {
373 suffix: "64",
374 },
375 },
376 symlinks: ["foo_link_"],
377 symlink_preferred_arch: true,
378 system_shared_libs: [],
Alex Light3d673592019-01-18 14:37:31 -0800379 stl: "none",
Yifan Hongd22a84a2020-07-28 17:37:46 -0700380 apex_available: [ "myapex", "com.android.gki.*" ],
381 }
382
Jiyong Park99644e92020-11-17 22:21:02 +0900383 rust_binary {
Artur Satayev533b98c2021-03-11 18:03:42 +0000384 name: "foo.rust",
Jiyong Park99644e92020-11-17 22:21:02 +0900385 srcs: ["foo.rs"],
386 rlibs: ["libfoo.rlib.rust"],
387 dylibs: ["libfoo.dylib.rust"],
388 apex_available: ["myapex"],
389 }
390
391 rust_library_rlib {
Artur Satayev533b98c2021-03-11 18:03:42 +0000392 name: "libfoo.rlib.rust",
Jiyong Park99644e92020-11-17 22:21:02 +0900393 srcs: ["foo.rs"],
394 crate_name: "foo",
395 apex_available: ["myapex"],
Jiyong Park94e22fd2021-04-08 18:19:15 +0900396 shared_libs: ["libfoo.shared_from_rust"],
397 }
398
399 cc_library_shared {
400 name: "libfoo.shared_from_rust",
401 srcs: ["mylib.cpp"],
402 system_shared_libs: [],
403 stl: "none",
404 apex_available: ["myapex"],
Jiyong Park99644e92020-11-17 22:21:02 +0900405 }
406
407 rust_library_dylib {
Artur Satayev533b98c2021-03-11 18:03:42 +0000408 name: "libfoo.dylib.rust",
Jiyong Park99644e92020-11-17 22:21:02 +0900409 srcs: ["foo.rs"],
410 crate_name: "foo",
411 apex_available: ["myapex"],
412 }
413
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900414 rust_ffi_shared {
415 name: "libfoo.ffi",
416 srcs: ["foo.rs"],
417 crate_name: "foo",
418 apex_available: ["myapex"],
419 }
420
421 rust_ffi_shared {
422 name: "libbar.ffi",
423 srcs: ["foo.rs"],
424 crate_name: "bar",
425 apex_available: ["myapex"],
426 }
427
Yifan Hongd22a84a2020-07-28 17:37:46 -0700428 apex {
429 name: "com.android.gki.fake",
430 binaries: ["foo"],
431 key: "myapex.key",
432 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000433 updatable: false,
Alex Light3d673592019-01-18 14:37:31 -0800434 }
435
Paul Duffindddd5462020-04-07 15:25:44 +0100436 cc_library_shared {
Jiyong Park25fc6a92018-11-18 18:02:45 +0900437 name: "mylib2",
438 srcs: ["mylib.cpp"],
439 system_shared_libs: [],
440 stl: "none",
Jiyong Park52818fc2019-03-18 12:01:38 +0900441 notice: "custom_notice",
Jiyong Park9918e1a2020-03-17 19:16:40 +0900442 static_libs: ["libstatic"],
443 // TODO: remove //apex_available:platform
444 apex_available: [
445 "//apex_available:platform",
446 "myapex",
447 ],
448 }
449
Paul Duffindddd5462020-04-07 15:25:44 +0100450 cc_prebuilt_library_shared {
451 name: "mylib2",
452 srcs: ["prebuilt.so"],
453 // TODO: remove //apex_available:platform
454 apex_available: [
455 "//apex_available:platform",
456 "myapex",
457 ],
458 }
459
Jiyong Park9918e1a2020-03-17 19:16:40 +0900460 cc_library_static {
461 name: "libstatic",
462 srcs: ["mylib.cpp"],
463 system_shared_libs: [],
464 stl: "none",
465 notice: "custom_notice_for_static_lib",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000466 // TODO: remove //apex_available:platform
467 apex_available: [
468 "//apex_available:platform",
469 "myapex",
470 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900471 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900472
473 java_library {
474 name: "myjar",
475 srcs: ["foo/bar/MyClass.java"],
Jiyong Parka62aa232020-05-28 23:46:55 +0900476 stem: "myjar_stem",
Jiyong Park7f7766d2019-07-25 22:02:35 +0900477 sdk_version: "none",
478 system_modules: "none",
Jiyong Park7f7766d2019-07-25 22:02:35 +0900479 static_libs: ["myotherjar"],
Jiyong Park3ff16992019-12-27 14:11:47 +0900480 libs: ["mysharedjar"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000481 // TODO: remove //apex_available:platform
482 apex_available: [
483 "//apex_available:platform",
484 "myapex",
485 ],
Jiyong Park7f7766d2019-07-25 22:02:35 +0900486 }
487
Jiyong Park77acec62020-06-01 21:39:15 +0900488 dex_import {
489 name: "myjar_dex",
490 jars: ["prebuilt.jar"],
491 apex_available: [
492 "//apex_available:platform",
493 "myapex",
494 ],
495 }
496
Jiyong Park7f7766d2019-07-25 22:02:35 +0900497 java_library {
498 name: "myotherjar",
499 srcs: ["foo/bar/MyClass.java"],
500 sdk_version: "none",
501 system_modules: "none",
Jiyong Park0f80c182020-01-31 02:49:53 +0900502 // TODO: remove //apex_available:platform
503 apex_available: [
504 "//apex_available:platform",
505 "myapex",
506 ],
Jiyong Park7f7766d2019-07-25 22:02:35 +0900507 }
Jiyong Park3ff16992019-12-27 14:11:47 +0900508
509 java_library {
510 name: "mysharedjar",
511 srcs: ["foo/bar/MyClass.java"],
512 sdk_version: "none",
513 system_modules: "none",
Jiyong Park3ff16992019-12-27 14:11:47 +0900514 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900515 `)
516
Paul Duffina71a67a2021-03-29 00:42:57 +0100517 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900518
Jiyong Park9e83f0b2020-06-11 00:35:03 +0900519 // Make sure that Android.mk is created
520 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -0700521 data := android.AndroidMkDataForTest(t, ctx, ab)
Jiyong Park9e83f0b2020-06-11 00:35:03 +0900522 var builder strings.Builder
523 data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
524
525 androidMk := builder.String()
526 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
527 ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
528
Jiyong Park42cca6c2019-04-01 11:15:50 +0900529 optFlags := apexRule.Args["opt_flags"]
530 ensureContains(t, optFlags, "--pubkey vendor/foo/devkeys/testkey.avbpubkey")
Jaewoong Jung14f5ff62019-06-18 13:09:13 -0700531 // Ensure that the NOTICE output is being packaged as an asset.
Paul Duffin37ba3442021-03-29 00:21:08 +0100532 ensureContains(t, optFlags, "--assets_dir out/soong/.intermediates/myapex/android_common_myapex_image/NOTICE")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900533
Jiyong Park25fc6a92018-11-18 18:02:45 +0900534 copyCmds := apexRule.Args["copy_commands"]
535
536 // Ensure that main rule creates an output
537 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
538
539 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -0700540 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
541 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common_apex10000")
542 ensureListContains(t, ctx.ModuleVariantsForTests("myjar_dex"), "android_common_apex10000")
Jiyong Park99644e92020-11-17 22:21:02 +0900543 ensureListContains(t, ctx.ModuleVariantsForTests("foo.rust"), "android_arm64_armv8-a_apex10000")
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900544 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.ffi"), "android_arm64_armv8-a_shared_apex10000")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900545
546 // Ensure that apex variant is created for the indirect dep
Colin Crossaede88c2020-08-11 12:17:01 -0700547 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
548 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common_apex10000")
Jiyong Park99644e92020-11-17 22:21:02 +0900549 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.rlib.rust"), "android_arm64_armv8-a_rlib_dylib-std_apex10000")
550 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.dylib.rust"), "android_arm64_armv8-a_dylib_apex10000")
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900551 ensureListContains(t, ctx.ModuleVariantsForTests("libbar.ffi"), "android_arm64_armv8-a_shared_apex10000")
Jiyong Park94e22fd2021-04-08 18:19:15 +0900552 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.shared_from_rust"), "android_arm64_armv8-a_shared_apex10000")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900553
554 // Ensure that both direct and indirect deps are copied into apex
Alex Light5098a612018-11-29 17:12:15 -0800555 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
556 ensureContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Parka62aa232020-05-28 23:46:55 +0900557 ensureContains(t, copyCmds, "image.apex/javalib/myjar_stem.jar")
Jiyong Park77acec62020-06-01 21:39:15 +0900558 ensureContains(t, copyCmds, "image.apex/javalib/myjar_dex.jar")
Jiyong Park99644e92020-11-17 22:21:02 +0900559 ensureContains(t, copyCmds, "image.apex/lib64/libfoo.dylib.rust.dylib.so")
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900560 ensureContains(t, copyCmds, "image.apex/lib64/libfoo.ffi.so")
561 ensureContains(t, copyCmds, "image.apex/lib64/libbar.ffi.so")
Jiyong Park94e22fd2021-04-08 18:19:15 +0900562 ensureContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900563 // .. but not for java libs
564 ensureNotContains(t, copyCmds, "image.apex/javalib/myotherjar.jar")
Jiyong Park3ff16992019-12-27 14:11:47 +0900565 ensureNotContains(t, copyCmds, "image.apex/javalib/msharedjar.jar")
Logan Chien3aeedc92018-12-26 15:32:21 +0800566
Colin Cross7113d202019-11-20 16:39:12 -0800567 // Ensure that the platform variant ends with _shared or _common
568 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
569 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900570 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common")
571 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common")
Jiyong Park3ff16992019-12-27 14:11:47 +0900572 ensureListContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common")
573
574 // Ensure that dynamic dependency to java libs are not included
575 ensureListNotContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common_myapex")
Alex Light3d673592019-01-18 14:37:31 -0800576
577 // Ensure that all symlinks are present.
578 found_foo_link_64 := false
579 found_foo := false
580 for _, cmd := range strings.Split(copyCmds, " && ") {
Jiyong Park7cd10e32020-01-14 09:22:18 +0900581 if strings.HasPrefix(cmd, "ln -sfn foo64") {
Alex Light3d673592019-01-18 14:37:31 -0800582 if strings.HasSuffix(cmd, "bin/foo") {
583 found_foo = true
584 } else if strings.HasSuffix(cmd, "bin/foo_link_64") {
585 found_foo_link_64 = true
586 }
587 }
588 }
589 good := found_foo && found_foo_link_64
590 if !good {
591 t.Errorf("Could not find all expected symlinks! foo: %t, foo_link_64: %t. Command was %s", found_foo, found_foo_link_64, copyCmds)
592 }
Jiyong Park52818fc2019-03-18 12:01:38 +0900593
Sundong Ahnabb64432019-10-22 13:58:29 +0900594 mergeNoticesRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("mergeNoticesRule")
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700595 noticeInputs := mergeNoticesRule.Inputs.Strings()
Jiyong Park9918e1a2020-03-17 19:16:40 +0900596 if len(noticeInputs) != 3 {
597 t.Errorf("number of input notice files: expected = 3, actual = %q", len(noticeInputs))
Jiyong Park52818fc2019-03-18 12:01:38 +0900598 }
599 ensureListContains(t, noticeInputs, "NOTICE")
600 ensureListContains(t, noticeInputs, "custom_notice")
Jiyong Park9918e1a2020-03-17 19:16:40 +0900601 ensureListContains(t, noticeInputs, "custom_notice_for_static_lib")
Jiyong Park83dc74b2020-01-14 18:38:44 +0900602
Artur Satayeva8bd1132020-04-27 18:07:06 +0100603 fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100604 ensureListContains(t, fullDepsInfo, " myjar(minSdkVersion:(no version)) <- myapex")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100605 ensureListContains(t, fullDepsInfo, " mylib2(minSdkVersion:(no version)) <- mylib")
606 ensureListContains(t, fullDepsInfo, " myotherjar(minSdkVersion:(no version)) <- myjar")
607 ensureListContains(t, fullDepsInfo, " mysharedjar(minSdkVersion:(no version)) (external) <- myjar")
Artur Satayeva8bd1132020-04-27 18:07:06 +0100608
609 flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100610 ensureListContains(t, flatDepsInfo, "myjar(minSdkVersion:(no version))")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100611 ensureListContains(t, flatDepsInfo, "mylib2(minSdkVersion:(no version))")
612 ensureListContains(t, flatDepsInfo, "myotherjar(minSdkVersion:(no version))")
613 ensureListContains(t, flatDepsInfo, "mysharedjar(minSdkVersion:(no version)) (external)")
Alex Light5098a612018-11-29 17:12:15 -0800614}
615
Jooyung Hanf21c7972019-12-16 22:32:06 +0900616func TestDefaults(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800617 ctx := testApex(t, `
Jooyung Hanf21c7972019-12-16 22:32:06 +0900618 apex_defaults {
619 name: "myapex-defaults",
620 key: "myapex.key",
621 prebuilts: ["myetc"],
622 native_shared_libs: ["mylib"],
623 java_libs: ["myjar"],
624 apps: ["AppFoo"],
Jiyong Park69aeba92020-04-24 21:16:36 +0900625 rros: ["rro"],
markchien2f59ec92020-09-02 16:23:38 +0800626 bpfs: ["bpf"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000627 updatable: false,
Jooyung Hanf21c7972019-12-16 22:32:06 +0900628 }
629
630 prebuilt_etc {
631 name: "myetc",
632 src: "myprebuilt",
633 }
634
635 apex {
636 name: "myapex",
637 defaults: ["myapex-defaults"],
638 }
639
640 apex_key {
641 name: "myapex.key",
642 public_key: "testkey.avbpubkey",
643 private_key: "testkey.pem",
644 }
645
646 cc_library {
647 name: "mylib",
648 system_shared_libs: [],
649 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000650 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900651 }
652
653 java_library {
654 name: "myjar",
655 srcs: ["foo/bar/MyClass.java"],
656 sdk_version: "none",
657 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000658 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900659 }
660
661 android_app {
662 name: "AppFoo",
663 srcs: ["foo/bar/MyClass.java"],
664 sdk_version: "none",
665 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000666 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900667 }
Jiyong Park69aeba92020-04-24 21:16:36 +0900668
669 runtime_resource_overlay {
670 name: "rro",
671 theme: "blue",
672 }
673
markchien2f59ec92020-09-02 16:23:38 +0800674 bpf {
675 name: "bpf",
676 srcs: ["bpf.c", "bpf2.c"],
677 }
678
Jooyung Hanf21c7972019-12-16 22:32:06 +0900679 `)
Jooyung Hana57af4a2020-01-23 05:36:59 +0000680 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Hanf21c7972019-12-16 22:32:06 +0900681 "etc/myetc",
682 "javalib/myjar.jar",
683 "lib64/mylib.so",
684 "app/AppFoo/AppFoo.apk",
Jiyong Park69aeba92020-04-24 21:16:36 +0900685 "overlay/blue/rro.apk",
markchien2f59ec92020-09-02 16:23:38 +0800686 "etc/bpf/bpf.o",
687 "etc/bpf/bpf2.o",
Jooyung Hanf21c7972019-12-16 22:32:06 +0900688 })
689}
690
Jooyung Han01a3ee22019-11-02 02:52:25 +0900691func TestApexManifest(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800692 ctx := testApex(t, `
Jooyung Han01a3ee22019-11-02 02:52:25 +0900693 apex {
694 name: "myapex",
695 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000696 updatable: false,
Jooyung Han01a3ee22019-11-02 02:52:25 +0900697 }
698
699 apex_key {
700 name: "myapex.key",
701 public_key: "testkey.avbpubkey",
702 private_key: "testkey.pem",
703 }
704 `)
705
706 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Han214bf372019-11-12 13:03:50 +0900707 args := module.Rule("apexRule").Args
708 if manifest := args["manifest"]; manifest != module.Output("apex_manifest.pb").Output.String() {
709 t.Error("manifest should be apex_manifest.pb, but " + manifest)
710 }
Jooyung Han01a3ee22019-11-02 02:52:25 +0900711}
712
Liz Kammer4854a7d2021-05-27 14:28:27 -0400713func TestApexManifestMinSdkVersion(t *testing.T) {
714 ctx := testApex(t, `
715 apex_defaults {
716 name: "my_defaults",
717 key: "myapex.key",
718 product_specific: true,
719 file_contexts: ":my-file-contexts",
720 updatable: false,
721 }
722 apex {
723 name: "myapex_30",
724 min_sdk_version: "30",
725 defaults: ["my_defaults"],
726 }
727
728 apex {
729 name: "myapex_current",
730 min_sdk_version: "current",
731 defaults: ["my_defaults"],
732 }
733
734 apex {
735 name: "myapex_none",
736 defaults: ["my_defaults"],
737 }
738
739 apex_key {
740 name: "myapex.key",
741 public_key: "testkey.avbpubkey",
742 private_key: "testkey.pem",
743 }
744
745 filegroup {
746 name: "my-file-contexts",
747 srcs: ["product_specific_file_contexts"],
748 }
749 `, withFiles(map[string][]byte{
750 "product_specific_file_contexts": nil,
751 }), android.FixtureModifyProductVariables(
752 func(variables android.FixtureProductVariables) {
753 variables.Unbundled_build = proptools.BoolPtr(true)
754 variables.Always_use_prebuilt_sdks = proptools.BoolPtr(false)
755 }), android.FixtureMergeEnv(map[string]string{
756 "UNBUNDLED_BUILD_TARGET_SDK_WITH_API_FINGERPRINT": "true",
757 }))
758
759 testCases := []struct {
760 module string
761 minSdkVersion string
762 }{
763 {
764 module: "myapex_30",
765 minSdkVersion: "30",
766 },
767 {
768 module: "myapex_current",
769 minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
770 },
771 {
772 module: "myapex_none",
773 minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
774 },
775 }
776 for _, tc := range testCases {
777 module := ctx.ModuleForTests(tc.module, "android_common_"+tc.module+"_image")
778 args := module.Rule("apexRule").Args
779 optFlags := args["opt_flags"]
780 if !strings.Contains(optFlags, "--min_sdk_version "+tc.minSdkVersion) {
781 t.Errorf("%s: Expected min_sdk_version=%s, got: %s", tc.module, tc.minSdkVersion, optFlags)
782 }
783 }
784}
785
Alex Light5098a612018-11-29 17:12:15 -0800786func TestBasicZipApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800787 ctx := testApex(t, `
Alex Light5098a612018-11-29 17:12:15 -0800788 apex {
789 name: "myapex",
790 key: "myapex.key",
791 payload_type: "zip",
792 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000793 updatable: false,
Alex Light5098a612018-11-29 17:12:15 -0800794 }
795
796 apex_key {
797 name: "myapex.key",
798 public_key: "testkey.avbpubkey",
799 private_key: "testkey.pem",
800 }
801
802 cc_library {
803 name: "mylib",
804 srcs: ["mylib.cpp"],
805 shared_libs: ["mylib2"],
806 system_shared_libs: [],
807 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000808 apex_available: [ "myapex" ],
Alex Light5098a612018-11-29 17:12:15 -0800809 }
810
811 cc_library {
812 name: "mylib2",
813 srcs: ["mylib.cpp"],
814 system_shared_libs: [],
815 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000816 apex_available: [ "myapex" ],
Alex Light5098a612018-11-29 17:12:15 -0800817 }
818 `)
819
Sundong Ahnabb64432019-10-22 13:58:29 +0900820 zipApexRule := ctx.ModuleForTests("myapex", "android_common_myapex_zip").Rule("zipApexRule")
Alex Light5098a612018-11-29 17:12:15 -0800821 copyCmds := zipApexRule.Args["copy_commands"]
822
823 // Ensure that main rule creates an output
824 ensureContains(t, zipApexRule.Output.String(), "myapex.zipapex.unsigned")
825
826 // Ensure that APEX variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -0700827 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
Alex Light5098a612018-11-29 17:12:15 -0800828
829 // Ensure that APEX variant is created for the indirect dep
Colin Crossaede88c2020-08-11 12:17:01 -0700830 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
Alex Light5098a612018-11-29 17:12:15 -0800831
832 // Ensure that both direct and indirect deps are copied into apex
833 ensureContains(t, copyCmds, "image.zipapex/lib64/mylib.so")
834 ensureContains(t, copyCmds, "image.zipapex/lib64/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900835}
836
837func TestApexWithStubs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800838 ctx := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +0900839 apex {
840 name: "myapex",
841 key: "myapex.key",
842 native_shared_libs: ["mylib", "mylib3"],
Jiyong Park105dc322021-06-11 17:22:09 +0900843 binaries: ["foo.rust"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000844 updatable: false,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900845 }
846
847 apex_key {
848 name: "myapex.key",
849 public_key: "testkey.avbpubkey",
850 private_key: "testkey.pem",
851 }
852
853 cc_library {
854 name: "mylib",
855 srcs: ["mylib.cpp"],
856 shared_libs: ["mylib2", "mylib3"],
857 system_shared_libs: [],
858 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000859 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900860 }
861
862 cc_library {
863 name: "mylib2",
864 srcs: ["mylib.cpp"],
Jiyong Park64379952018-12-13 18:37:29 +0900865 cflags: ["-include mylib.h"],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900866 system_shared_libs: [],
867 stl: "none",
868 stubs: {
869 versions: ["1", "2", "3"],
870 },
871 }
872
873 cc_library {
874 name: "mylib3",
Jiyong Park28d395a2018-12-07 22:42:47 +0900875 srcs: ["mylib.cpp"],
876 shared_libs: ["mylib4"],
877 system_shared_libs: [],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900878 stl: "none",
879 stubs: {
880 versions: ["10", "11", "12"],
881 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000882 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900883 }
Jiyong Park28d395a2018-12-07 22:42:47 +0900884
885 cc_library {
886 name: "mylib4",
887 srcs: ["mylib.cpp"],
888 system_shared_libs: [],
889 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000890 apex_available: [ "myapex" ],
Jiyong Park28d395a2018-12-07 22:42:47 +0900891 }
Jiyong Park105dc322021-06-11 17:22:09 +0900892
893 rust_binary {
894 name: "foo.rust",
895 srcs: ["foo.rs"],
896 shared_libs: ["libfoo.shared_from_rust"],
897 prefer_rlib: true,
898 apex_available: ["myapex"],
899 }
900
901 cc_library_shared {
902 name: "libfoo.shared_from_rust",
903 srcs: ["mylib.cpp"],
904 system_shared_libs: [],
905 stl: "none",
906 stubs: {
907 versions: ["10", "11", "12"],
908 },
909 }
910
Jiyong Park25fc6a92018-11-18 18:02:45 +0900911 `)
912
Sundong Ahnabb64432019-10-22 13:58:29 +0900913 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900914 copyCmds := apexRule.Args["copy_commands"]
915
916 // Ensure that direct non-stubs dep is always included
Alex Light5098a612018-11-29 17:12:15 -0800917 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900918
919 // Ensure that indirect stubs dep is not included
Alex Light5098a612018-11-29 17:12:15 -0800920 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900921
922 // Ensure that direct stubs dep is included
Alex Light5098a612018-11-29 17:12:15 -0800923 ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900924
Colin Crossaede88c2020-08-11 12:17:01 -0700925 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +0900926
927 // Ensure that mylib is linking with the latest version of stubs for mylib2
Jiyong Parkd4a3a132021-03-17 20:21:35 +0900928 ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900929 // ... and not linking to the non-stub (impl) variant of mylib2
Jiyong Park3ff16992019-12-27 14:11:47 +0900930 ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900931
932 // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
Colin Crossaede88c2020-08-11 12:17:01 -0700933 ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex10000/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900934 // .. and not linking to the stubs variant of mylib3
Colin Crossaede88c2020-08-11 12:17:01 -0700935 ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_12/mylib3.so")
Jiyong Park64379952018-12-13 18:37:29 +0900936
Chih-Hung Hsiehb8082292021-09-09 23:20:39 -0700937 // Comment out this test. Now it fails after the optimization of sharing "cflags" in cc/cc.go
938 // is replaced by sharing of "cFlags" in cc/builder.go.
939 // The "cflags" contains "-include mylib.h", but cFlags contained only a reference to the
940 // module variable representing "cflags". So it was not detected by ensureNotContains.
941 // Now "cFlags" is a reference to a module variable like $flags1, which includes all previous
942 // content of "cflags". ModuleForTests...Args["cFlags"] returns the full string of $flags1,
943 // including the original cflags's "-include mylib.h".
944 //
Jiyong Park64379952018-12-13 18:37:29 +0900945 // Ensure that stubs libs are built without -include flags
Chih-Hung Hsiehb8082292021-09-09 23:20:39 -0700946 // mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
947 // ensureNotContains(t, mylib2Cflags, "-include ")
Jiyong Park3fd0baf2018-12-07 16:25:39 +0900948
949 // Ensure that genstub is invoked with --apex
Colin Crossa717db72020-10-23 14:53:06 -0700950 ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_3").Rule("genStubSrc").Args["flags"])
Jooyung Han671f1ce2019-12-17 12:47:13 +0900951
Jooyung Hana57af4a2020-01-23 05:36:59 +0000952 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Han671f1ce2019-12-17 12:47:13 +0900953 "lib64/mylib.so",
954 "lib64/mylib3.so",
955 "lib64/mylib4.so",
Jiyong Park105dc322021-06-11 17:22:09 +0900956 "bin/foo.rust",
957 "lib64/libc++.so", // by the implicit dependency from foo.rust
958 "lib64/liblog.so", // by the implicit dependency from foo.rust
Jooyung Han671f1ce2019-12-17 12:47:13 +0900959 })
Jiyong Park105dc322021-06-11 17:22:09 +0900960
961 // Ensure that stub dependency from a rust module is not included
962 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
963 // The rust module is linked to the stub cc library
964 rustDeps := ctx.ModuleForTests("foo.rust", "android_arm64_armv8-a_apex10000").Rule("rustc").Args["linkFlags"]
965 ensureContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared_current/libfoo.shared_from_rust.so")
966 ensureNotContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared/libfoo.shared_from_rust.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900967}
968
Jiyong Park1bc84122021-06-22 20:23:05 +0900969func TestApexCanUsePrivateApis(t *testing.T) {
970 ctx := testApex(t, `
971 apex {
972 name: "myapex",
973 key: "myapex.key",
974 native_shared_libs: ["mylib"],
975 binaries: ["foo.rust"],
976 updatable: false,
977 platform_apis: true,
978 }
979
980 apex_key {
981 name: "myapex.key",
982 public_key: "testkey.avbpubkey",
983 private_key: "testkey.pem",
984 }
985
986 cc_library {
987 name: "mylib",
988 srcs: ["mylib.cpp"],
989 shared_libs: ["mylib2"],
990 system_shared_libs: [],
991 stl: "none",
992 apex_available: [ "myapex" ],
993 }
994
995 cc_library {
996 name: "mylib2",
997 srcs: ["mylib.cpp"],
998 cflags: ["-include mylib.h"],
999 system_shared_libs: [],
1000 stl: "none",
1001 stubs: {
1002 versions: ["1", "2", "3"],
1003 },
1004 }
1005
1006 rust_binary {
1007 name: "foo.rust",
1008 srcs: ["foo.rs"],
1009 shared_libs: ["libfoo.shared_from_rust"],
1010 prefer_rlib: true,
1011 apex_available: ["myapex"],
1012 }
1013
1014 cc_library_shared {
1015 name: "libfoo.shared_from_rust",
1016 srcs: ["mylib.cpp"],
1017 system_shared_libs: [],
1018 stl: "none",
1019 stubs: {
1020 versions: ["10", "11", "12"],
1021 },
1022 }
1023 `)
1024
1025 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
1026 copyCmds := apexRule.Args["copy_commands"]
1027
1028 // Ensure that indirect stubs dep is not included
1029 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
1030 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
1031
1032 // Ensure that we are using non-stub variants of mylib2 and libfoo.shared_from_rust (because
1033 // of the platform_apis: true)
1034 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000_private").Rule("ld").Args["libFlags"]
1035 ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
1036 ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
1037 rustDeps := ctx.ModuleForTests("foo.rust", "android_arm64_armv8-a_apex10000_private").Rule("rustc").Args["linkFlags"]
1038 ensureNotContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared_current/libfoo.shared_from_rust.so")
1039 ensureContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared/libfoo.shared_from_rust.so")
1040}
1041
Colin Cross7812fd32020-09-25 12:35:10 -07001042func TestApexWithStubsWithMinSdkVersion(t *testing.T) {
1043 t.Parallel()
Colin Cross1c460562021-02-16 17:55:47 -08001044 ctx := testApex(t, `
Colin Cross7812fd32020-09-25 12:35:10 -07001045 apex {
1046 name: "myapex",
1047 key: "myapex.key",
1048 native_shared_libs: ["mylib", "mylib3"],
1049 min_sdk_version: "29",
1050 }
1051
1052 apex_key {
1053 name: "myapex.key",
1054 public_key: "testkey.avbpubkey",
1055 private_key: "testkey.pem",
1056 }
1057
1058 cc_library {
1059 name: "mylib",
1060 srcs: ["mylib.cpp"],
1061 shared_libs: ["mylib2", "mylib3"],
1062 system_shared_libs: [],
1063 stl: "none",
1064 apex_available: [ "myapex" ],
1065 min_sdk_version: "28",
1066 }
1067
1068 cc_library {
1069 name: "mylib2",
1070 srcs: ["mylib.cpp"],
1071 cflags: ["-include mylib.h"],
1072 system_shared_libs: [],
1073 stl: "none",
1074 stubs: {
1075 versions: ["28", "29", "30", "current"],
1076 },
1077 min_sdk_version: "28",
1078 }
1079
1080 cc_library {
1081 name: "mylib3",
1082 srcs: ["mylib.cpp"],
1083 shared_libs: ["mylib4"],
1084 system_shared_libs: [],
1085 stl: "none",
1086 stubs: {
1087 versions: ["28", "29", "30", "current"],
1088 },
1089 apex_available: [ "myapex" ],
1090 min_sdk_version: "28",
1091 }
1092
1093 cc_library {
1094 name: "mylib4",
1095 srcs: ["mylib.cpp"],
1096 system_shared_libs: [],
1097 stl: "none",
1098 apex_available: [ "myapex" ],
1099 min_sdk_version: "28",
1100 }
1101 `)
1102
1103 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
1104 copyCmds := apexRule.Args["copy_commands"]
1105
1106 // Ensure that direct non-stubs dep is always included
1107 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
1108
1109 // Ensure that indirect stubs dep is not included
1110 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
1111
1112 // Ensure that direct stubs dep is included
1113 ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
1114
1115 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex29").Rule("ld").Args["libFlags"]
1116
Jiyong Park55549df2021-02-26 23:57:23 +09001117 // Ensure that mylib is linking with the latest version of stub for mylib2
1118 ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
Colin Cross7812fd32020-09-25 12:35:10 -07001119 // ... and not linking to the non-stub (impl) variant of mylib2
1120 ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
1121
1122 // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
1123 ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex29/mylib3.so")
1124 // .. and not linking to the stubs variant of mylib3
1125 ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_29/mylib3.so")
1126
1127 // Ensure that stubs libs are built without -include flags
Colin Crossa717db72020-10-23 14:53:06 -07001128 mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("cc").Args["cFlags"]
Colin Cross7812fd32020-09-25 12:35:10 -07001129 ensureNotContains(t, mylib2Cflags, "-include ")
1130
1131 // Ensure that genstub is invoked with --apex
Colin Crossa717db72020-10-23 14:53:06 -07001132 ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("genStubSrc").Args["flags"])
Colin Cross7812fd32020-09-25 12:35:10 -07001133
1134 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
1135 "lib64/mylib.so",
1136 "lib64/mylib3.so",
1137 "lib64/mylib4.so",
1138 })
1139}
1140
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001141func TestApex_PlatformUsesLatestStubFromApex(t *testing.T) {
1142 t.Parallel()
1143 // myapex (Z)
1144 // mylib -----------------.
1145 // |
1146 // otherapex (29) |
1147 // libstub's versions: 29 Z current
1148 // |
1149 // <platform> |
1150 // libplatform ----------------'
Colin Cross1c460562021-02-16 17:55:47 -08001151 ctx := testApex(t, `
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001152 apex {
1153 name: "myapex",
1154 key: "myapex.key",
1155 native_shared_libs: ["mylib"],
1156 min_sdk_version: "Z", // non-final
1157 }
1158
1159 cc_library {
1160 name: "mylib",
1161 srcs: ["mylib.cpp"],
1162 shared_libs: ["libstub"],
1163 apex_available: ["myapex"],
1164 min_sdk_version: "Z",
1165 }
1166
1167 apex_key {
1168 name: "myapex.key",
1169 public_key: "testkey.avbpubkey",
1170 private_key: "testkey.pem",
1171 }
1172
1173 apex {
1174 name: "otherapex",
1175 key: "myapex.key",
1176 native_shared_libs: ["libstub"],
1177 min_sdk_version: "29",
1178 }
1179
1180 cc_library {
1181 name: "libstub",
1182 srcs: ["mylib.cpp"],
1183 stubs: {
1184 versions: ["29", "Z", "current"],
1185 },
1186 apex_available: ["otherapex"],
1187 min_sdk_version: "29",
1188 }
1189
1190 // platform module depending on libstub from otherapex should use the latest stub("current")
1191 cc_library {
1192 name: "libplatform",
1193 srcs: ["mylib.cpp"],
1194 shared_libs: ["libstub"],
1195 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001196 `,
1197 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1198 variables.Platform_sdk_codename = proptools.StringPtr("Z")
1199 variables.Platform_sdk_final = proptools.BoolPtr(false)
1200 variables.Platform_version_active_codenames = []string{"Z"}
1201 }),
1202 )
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001203
Jiyong Park55549df2021-02-26 23:57:23 +09001204 // Ensure that mylib from myapex is built against the latest stub (current)
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001205 mylibCflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
Jiyong Park55549df2021-02-26 23:57:23 +09001206 ensureContains(t, mylibCflags, "-D__LIBSTUB_API__=10000 ")
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001207 mylibLdflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
Jiyong Park55549df2021-02-26 23:57:23 +09001208 ensureContains(t, mylibLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001209
1210 // Ensure that libplatform is built against latest stub ("current") of mylib3 from the apex
1211 libplatformCflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
1212 ensureContains(t, libplatformCflags, "-D__LIBSTUB_API__=10000 ") // "current" maps to 10000
1213 libplatformLdflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
1214 ensureContains(t, libplatformLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
1215}
1216
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001217func TestApexWithExplicitStubsDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001218 ctx := testApex(t, `
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001219 apex {
Jiyong Park83dc74b2020-01-14 18:38:44 +09001220 name: "myapex2",
1221 key: "myapex2.key",
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001222 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001223 updatable: false,
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001224 }
1225
1226 apex_key {
Jiyong Park83dc74b2020-01-14 18:38:44 +09001227 name: "myapex2.key",
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001228 public_key: "testkey.avbpubkey",
1229 private_key: "testkey.pem",
1230 }
1231
1232 cc_library {
1233 name: "mylib",
1234 srcs: ["mylib.cpp"],
1235 shared_libs: ["libfoo#10"],
Jiyong Park678c8812020-02-07 17:25:49 +09001236 static_libs: ["libbaz"],
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001237 system_shared_libs: [],
1238 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001239 apex_available: [ "myapex2" ],
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001240 }
1241
1242 cc_library {
1243 name: "libfoo",
1244 srcs: ["mylib.cpp"],
1245 shared_libs: ["libbar"],
1246 system_shared_libs: [],
1247 stl: "none",
1248 stubs: {
1249 versions: ["10", "20", "30"],
1250 },
1251 }
1252
1253 cc_library {
1254 name: "libbar",
1255 srcs: ["mylib.cpp"],
1256 system_shared_libs: [],
1257 stl: "none",
1258 }
1259
Jiyong Park678c8812020-02-07 17:25:49 +09001260 cc_library_static {
1261 name: "libbaz",
1262 srcs: ["mylib.cpp"],
1263 system_shared_libs: [],
1264 stl: "none",
1265 apex_available: [ "myapex2" ],
1266 }
1267
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001268 `)
1269
Jiyong Park83dc74b2020-01-14 18:38:44 +09001270 apexRule := ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Rule("apexRule")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001271 copyCmds := apexRule.Args["copy_commands"]
1272
1273 // Ensure that direct non-stubs dep is always included
1274 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
1275
1276 // Ensure that indirect stubs dep is not included
1277 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
1278
1279 // Ensure that dependency of stubs is not included
1280 ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so")
1281
Colin Crossaede88c2020-08-11 12:17:01 -07001282 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001283
1284 // Ensure that mylib is linking with version 10 of libfoo
Jiyong Park3ff16992019-12-27 14:11:47 +09001285 ensureContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared_10/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001286 // ... and not linking to the non-stub (impl) variant of libfoo
Jiyong Park3ff16992019-12-27 14:11:47 +09001287 ensureNotContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001288
Jiyong Park3ff16992019-12-27 14:11:47 +09001289 libFooStubsLdFlags := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_10").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001290
1291 // Ensure that libfoo stubs is not linking to libbar (since it is a stubs)
1292 ensureNotContains(t, libFooStubsLdFlags, "libbar.so")
Jiyong Park83dc74b2020-01-14 18:38:44 +09001293
Artur Satayeva8bd1132020-04-27 18:07:06 +01001294 fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +01001295 ensureListContains(t, fullDepsInfo, " libfoo(minSdkVersion:(no version)) (external) <- mylib")
Jiyong Park678c8812020-02-07 17:25:49 +09001296
Artur Satayeva8bd1132020-04-27 18:07:06 +01001297 flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +01001298 ensureListContains(t, flatDepsInfo, "libfoo(minSdkVersion:(no version)) (external)")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001299}
1300
Jooyung Hand3639552019-08-09 12:57:43 +09001301func TestApexWithRuntimeLibsDependency(t *testing.T) {
1302 /*
1303 myapex
1304 |
1305 v (runtime_libs)
1306 mylib ------+------> libfoo [provides stub]
1307 |
1308 `------> libbar
1309 */
Colin Cross1c460562021-02-16 17:55:47 -08001310 ctx := testApex(t, `
Jooyung Hand3639552019-08-09 12:57:43 +09001311 apex {
1312 name: "myapex",
1313 key: "myapex.key",
1314 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001315 updatable: false,
Jooyung Hand3639552019-08-09 12:57:43 +09001316 }
1317
1318 apex_key {
1319 name: "myapex.key",
1320 public_key: "testkey.avbpubkey",
1321 private_key: "testkey.pem",
1322 }
1323
1324 cc_library {
1325 name: "mylib",
1326 srcs: ["mylib.cpp"],
1327 runtime_libs: ["libfoo", "libbar"],
1328 system_shared_libs: [],
1329 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001330 apex_available: [ "myapex" ],
Jooyung Hand3639552019-08-09 12:57:43 +09001331 }
1332
1333 cc_library {
1334 name: "libfoo",
1335 srcs: ["mylib.cpp"],
1336 system_shared_libs: [],
1337 stl: "none",
1338 stubs: {
1339 versions: ["10", "20", "30"],
1340 },
1341 }
1342
1343 cc_library {
1344 name: "libbar",
1345 srcs: ["mylib.cpp"],
1346 system_shared_libs: [],
1347 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001348 apex_available: [ "myapex" ],
Jooyung Hand3639552019-08-09 12:57:43 +09001349 }
1350
1351 `)
1352
Sundong Ahnabb64432019-10-22 13:58:29 +09001353 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jooyung Hand3639552019-08-09 12:57:43 +09001354 copyCmds := apexRule.Args["copy_commands"]
1355
1356 // Ensure that direct non-stubs dep is always included
1357 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
1358
1359 // Ensure that indirect stubs dep is not included
1360 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
1361
1362 // Ensure that runtime_libs dep in included
1363 ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
1364
Sundong Ahnabb64432019-10-22 13:58:29 +09001365 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001366 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
1367 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.so")
Jooyung Hand3639552019-08-09 12:57:43 +09001368
1369}
1370
Paul Duffina02cae32021-03-09 01:44:06 +00001371var prepareForTestOfRuntimeApexWithHwasan = android.GroupFixturePreparers(
1372 cc.PrepareForTestWithCcBuildComponents,
1373 PrepareForTestWithApexBuildComponents,
1374 android.FixtureAddTextFile("bionic/apex/Android.bp", `
Jooyung Han8ce8db92020-05-15 19:05:05 +09001375 apex {
1376 name: "com.android.runtime",
1377 key: "com.android.runtime.key",
1378 native_shared_libs: ["libc"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001379 updatable: false,
Jooyung Han8ce8db92020-05-15 19:05:05 +09001380 }
1381
1382 apex_key {
1383 name: "com.android.runtime.key",
1384 public_key: "testkey.avbpubkey",
1385 private_key: "testkey.pem",
1386 }
Paul Duffina02cae32021-03-09 01:44:06 +00001387 `),
1388 android.FixtureAddFile("system/sepolicy/apex/com.android.runtime-file_contexts", nil),
1389)
Jooyung Han8ce8db92020-05-15 19:05:05 +09001390
Paul Duffina02cae32021-03-09 01:44:06 +00001391func TestRuntimeApexShouldInstallHwasanIfLibcDependsOnIt(t *testing.T) {
Paul Duffin70d3bee2021-03-21 11:26:05 +00001392 result := android.GroupFixturePreparers(prepareForTestOfRuntimeApexWithHwasan).RunTestWithBp(t, `
Jooyung Han8ce8db92020-05-15 19:05:05 +09001393 cc_library {
1394 name: "libc",
1395 no_libcrt: true,
1396 nocrt: true,
1397 stl: "none",
1398 system_shared_libs: [],
1399 stubs: { versions: ["1"] },
1400 apex_available: ["com.android.runtime"],
1401
1402 sanitize: {
1403 hwaddress: true,
1404 }
1405 }
1406
1407 cc_prebuilt_library_shared {
1408 name: "libclang_rt.hwasan-aarch64-android",
1409 no_libcrt: true,
1410 nocrt: true,
1411 stl: "none",
1412 system_shared_libs: [],
1413 srcs: [""],
1414 stubs: { versions: ["1"] },
1415
1416 sanitize: {
1417 never: true,
1418 },
Paul Duffina02cae32021-03-09 01:44:06 +00001419 } `)
1420 ctx := result.TestContext
Jooyung Han8ce8db92020-05-15 19:05:05 +09001421
1422 ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
1423 "lib64/bionic/libc.so",
1424 "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
1425 })
1426
1427 hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared")
1428
1429 installed := hwasan.Description("install libclang_rt.hwasan")
1430 ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
1431
1432 symlink := hwasan.Description("install symlink libclang_rt.hwasan")
1433 ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
1434 ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
1435}
1436
1437func TestRuntimeApexShouldInstallHwasanIfHwaddressSanitized(t *testing.T) {
Paul Duffin70d3bee2021-03-21 11:26:05 +00001438 result := android.GroupFixturePreparers(
Paul Duffina02cae32021-03-09 01:44:06 +00001439 prepareForTestOfRuntimeApexWithHwasan,
1440 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1441 variables.SanitizeDevice = []string{"hwaddress"}
1442 }),
1443 ).RunTestWithBp(t, `
Jooyung Han8ce8db92020-05-15 19:05:05 +09001444 cc_library {
1445 name: "libc",
1446 no_libcrt: true,
1447 nocrt: true,
1448 stl: "none",
1449 system_shared_libs: [],
1450 stubs: { versions: ["1"] },
1451 apex_available: ["com.android.runtime"],
1452 }
1453
1454 cc_prebuilt_library_shared {
1455 name: "libclang_rt.hwasan-aarch64-android",
1456 no_libcrt: true,
1457 nocrt: true,
1458 stl: "none",
1459 system_shared_libs: [],
1460 srcs: [""],
1461 stubs: { versions: ["1"] },
1462
1463 sanitize: {
1464 never: true,
1465 },
1466 }
Paul Duffina02cae32021-03-09 01:44:06 +00001467 `)
1468 ctx := result.TestContext
Jooyung Han8ce8db92020-05-15 19:05:05 +09001469
1470 ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
1471 "lib64/bionic/libc.so",
1472 "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
1473 })
1474
1475 hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared")
1476
1477 installed := hwasan.Description("install libclang_rt.hwasan")
1478 ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
1479
1480 symlink := hwasan.Description("install symlink libclang_rt.hwasan")
1481 ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
1482 ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
1483}
1484
Jooyung Han61b66e92020-03-21 14:21:46 +00001485func TestApexDependsOnLLNDKTransitively(t *testing.T) {
1486 testcases := []struct {
1487 name string
1488 minSdkVersion string
Colin Crossaede88c2020-08-11 12:17:01 -07001489 apexVariant string
Jooyung Han61b66e92020-03-21 14:21:46 +00001490 shouldLink string
1491 shouldNotLink []string
1492 }{
1493 {
Jiyong Park55549df2021-02-26 23:57:23 +09001494 name: "unspecified version links to the latest",
Jooyung Han749dc692020-04-15 11:03:39 +09001495 minSdkVersion: "",
Colin Crossaede88c2020-08-11 12:17:01 -07001496 apexVariant: "apex10000",
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001497 shouldLink: "current",
1498 shouldNotLink: []string{"29", "30"},
Jooyung Han61b66e92020-03-21 14:21:46 +00001499 },
1500 {
Jiyong Park55549df2021-02-26 23:57:23 +09001501 name: "always use the latest",
Jooyung Han749dc692020-04-15 11:03:39 +09001502 minSdkVersion: "min_sdk_version: \"29\",",
Colin Crossaede88c2020-08-11 12:17:01 -07001503 apexVariant: "apex29",
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001504 shouldLink: "current",
1505 shouldNotLink: []string{"29", "30"},
Jooyung Han61b66e92020-03-21 14:21:46 +00001506 },
1507 }
1508 for _, tc := range testcases {
1509 t.Run(tc.name, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001510 ctx := testApex(t, `
Jooyung Han61b66e92020-03-21 14:21:46 +00001511 apex {
1512 name: "myapex",
1513 key: "myapex.key",
Jooyung Han61b66e92020-03-21 14:21:46 +00001514 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001515 updatable: false,
Jooyung Han749dc692020-04-15 11:03:39 +09001516 `+tc.minSdkVersion+`
Jooyung Han61b66e92020-03-21 14:21:46 +00001517 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001518
Jooyung Han61b66e92020-03-21 14:21:46 +00001519 apex_key {
1520 name: "myapex.key",
1521 public_key: "testkey.avbpubkey",
1522 private_key: "testkey.pem",
1523 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001524
Jooyung Han61b66e92020-03-21 14:21:46 +00001525 cc_library {
1526 name: "mylib",
1527 srcs: ["mylib.cpp"],
1528 vendor_available: true,
1529 shared_libs: ["libbar"],
1530 system_shared_libs: [],
1531 stl: "none",
1532 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001533 min_sdk_version: "29",
Jooyung Han61b66e92020-03-21 14:21:46 +00001534 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001535
Jooyung Han61b66e92020-03-21 14:21:46 +00001536 cc_library {
1537 name: "libbar",
1538 srcs: ["mylib.cpp"],
1539 system_shared_libs: [],
1540 stl: "none",
1541 stubs: { versions: ["29","30"] },
Colin Cross203b4212021-04-26 17:19:41 -07001542 llndk: {
1543 symbol_file: "libbar.map.txt",
1544 }
Jooyung Han61b66e92020-03-21 14:21:46 +00001545 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001546 `,
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001547 withUnbundledBuild,
1548 )
Jooyung Han9c80bae2019-08-20 17:30:57 +09001549
Jooyung Han61b66e92020-03-21 14:21:46 +00001550 // Ensure that LLNDK dep is not included
1551 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
1552 "lib64/mylib.so",
1553 })
Jooyung Han9c80bae2019-08-20 17:30:57 +09001554
Jooyung Han61b66e92020-03-21 14:21:46 +00001555 // Ensure that LLNDK dep is required
1556 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
1557 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
1558 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libbar.so")
Jooyung Han9c80bae2019-08-20 17:30:57 +09001559
Steven Moreland2c4000c2021-04-27 02:08:49 +00001560 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_"+tc.apexVariant).Rule("ld").Args["libFlags"]
1561 ensureContains(t, mylibLdFlags, "libbar/android_arm64_armv8-a_shared_"+tc.shouldLink+"/libbar.so")
Jooyung Han61b66e92020-03-21 14:21:46 +00001562 for _, ver := range tc.shouldNotLink {
Steven Moreland2c4000c2021-04-27 02:08:49 +00001563 ensureNotContains(t, mylibLdFlags, "libbar/android_arm64_armv8-a_shared_"+ver+"/libbar.so")
Jooyung Han61b66e92020-03-21 14:21:46 +00001564 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001565
Steven Moreland2c4000c2021-04-27 02:08:49 +00001566 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_"+tc.apexVariant).Rule("cc").Args["cFlags"]
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001567 ver := tc.shouldLink
1568 if tc.shouldLink == "current" {
1569 ver = strconv.Itoa(android.FutureApiLevelInt)
1570 }
1571 ensureContains(t, mylibCFlags, "__LIBBAR_API__="+ver)
Jooyung Han61b66e92020-03-21 14:21:46 +00001572 })
1573 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001574}
1575
Jiyong Park25fc6a92018-11-18 18:02:45 +09001576func TestApexWithSystemLibsStubs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001577 ctx := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +09001578 apex {
1579 name: "myapex",
1580 key: "myapex.key",
1581 native_shared_libs: ["mylib", "mylib_shared", "libdl", "libm"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001582 updatable: false,
Jiyong Park25fc6a92018-11-18 18:02:45 +09001583 }
1584
1585 apex_key {
1586 name: "myapex.key",
1587 public_key: "testkey.avbpubkey",
1588 private_key: "testkey.pem",
1589 }
1590
1591 cc_library {
1592 name: "mylib",
1593 srcs: ["mylib.cpp"],
Colin Cross0de8a1e2020-09-18 14:15:30 -07001594 system_shared_libs: ["libc", "libm"],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001595 shared_libs: ["libdl#27"],
1596 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001597 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001598 }
1599
1600 cc_library_shared {
1601 name: "mylib_shared",
1602 srcs: ["mylib.cpp"],
1603 shared_libs: ["libdl#27"],
1604 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001605 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001606 }
1607
1608 cc_library {
Jiyong Parkb0788572018-12-20 22:10:17 +09001609 name: "libBootstrap",
1610 srcs: ["mylib.cpp"],
1611 stl: "none",
1612 bootstrap: true,
1613 }
Jiyong Park25fc6a92018-11-18 18:02:45 +09001614 `)
1615
Sundong Ahnabb64432019-10-22 13:58:29 +09001616 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001617 copyCmds := apexRule.Args["copy_commands"]
1618
1619 // Ensure that mylib, libm, libdl are included.
Alex Light5098a612018-11-29 17:12:15 -08001620 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Parkb0788572018-12-20 22:10:17 +09001621 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libm.so")
1622 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001623
1624 // Ensure that libc is not included (since it has stubs and not listed in native_shared_libs)
Jiyong Parkb0788572018-12-20 22:10:17 +09001625 ensureNotContains(t, copyCmds, "image.apex/lib64/bionic/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001626
Colin Crossaede88c2020-08-11 12:17:01 -07001627 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
1628 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
1629 mylibSharedCFlags := ctx.ModuleForTests("mylib_shared", "android_arm64_armv8-a_shared_apex10000").Rule("cc").Args["cFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +09001630
1631 // For dependency to libc
1632 // Ensure that mylib is linking with the latest version of stubs
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001633 ensureContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared_current/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001634 // ... and not linking to the non-stub (impl) variant
Jiyong Park3ff16992019-12-27 14:11:47 +09001635 ensureNotContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001636 // ... Cflags from stub is correctly exported to mylib
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001637 ensureContains(t, mylibCFlags, "__LIBC_API__=10000")
1638 ensureContains(t, mylibSharedCFlags, "__LIBC_API__=10000")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001639
1640 // For dependency to libm
1641 // Ensure that mylib is linking with the non-stub (impl) variant
Colin Crossaede88c2020-08-11 12:17:01 -07001642 ensureContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_apex10000/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001643 // ... and not linking to the stub variant
Jiyong Park3ff16992019-12-27 14:11:47 +09001644 ensureNotContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_29/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001645 // ... and is not compiling with the stub
1646 ensureNotContains(t, mylibCFlags, "__LIBM_API__=29")
1647 ensureNotContains(t, mylibSharedCFlags, "__LIBM_API__=29")
1648
1649 // For dependency to libdl
1650 // Ensure that mylib is linking with the specified version of stubs
Jiyong Park3ff16992019-12-27 14:11:47 +09001651 ensureContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_27/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001652 // ... and not linking to the other versions of stubs
Jiyong Park3ff16992019-12-27 14:11:47 +09001653 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_28/libdl.so")
1654 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_29/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001655 // ... and not linking to the non-stub (impl) variant
Colin Crossaede88c2020-08-11 12:17:01 -07001656 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_apex10000/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001657 // ... Cflags from stub is correctly exported to mylib
1658 ensureContains(t, mylibCFlags, "__LIBDL_API__=27")
1659 ensureContains(t, mylibSharedCFlags, "__LIBDL_API__=27")
Jiyong Parkb0788572018-12-20 22:10:17 +09001660
1661 // Ensure that libBootstrap is depending on the platform variant of bionic libs
Colin Cross7113d202019-11-20 16:39:12 -08001662 libFlags := ctx.ModuleForTests("libBootstrap", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
1663 ensureContains(t, libFlags, "libc/android_arm64_armv8-a_shared/libc.so")
1664 ensureContains(t, libFlags, "libm/android_arm64_armv8-a_shared/libm.so")
1665 ensureContains(t, libFlags, "libdl/android_arm64_armv8-a_shared/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001666}
Jiyong Park7c2ee712018-12-07 00:42:25 +09001667
Jooyung Han749dc692020-04-15 11:03:39 +09001668func TestApexMinSdkVersion_NativeModulesShouldBeBuiltAgainstStubs(t *testing.T) {
Jiyong Park55549df2021-02-26 23:57:23 +09001669 // there are three links between liba --> libz.
1670 // 1) myapex -> libx -> liba -> libz : this should be #30 link
Jooyung Han749dc692020-04-15 11:03:39 +09001671 // 2) otherapex -> liby -> liba -> libz : this should be #30 link
Jooyung Han03b51852020-02-26 22:45:42 +09001672 // 3) (platform) -> liba -> libz : this should be non-stub link
Colin Cross1c460562021-02-16 17:55:47 -08001673 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001674 apex {
1675 name: "myapex",
1676 key: "myapex.key",
1677 native_shared_libs: ["libx"],
Jooyung Han749dc692020-04-15 11:03:39 +09001678 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001679 }
1680
1681 apex {
1682 name: "otherapex",
1683 key: "myapex.key",
1684 native_shared_libs: ["liby"],
Jooyung Han749dc692020-04-15 11:03:39 +09001685 min_sdk_version: "30",
Jooyung Han03b51852020-02-26 22:45:42 +09001686 }
1687
1688 apex_key {
1689 name: "myapex.key",
1690 public_key: "testkey.avbpubkey",
1691 private_key: "testkey.pem",
1692 }
1693
1694 cc_library {
1695 name: "libx",
1696 shared_libs: ["liba"],
1697 system_shared_libs: [],
1698 stl: "none",
1699 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001700 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001701 }
1702
1703 cc_library {
1704 name: "liby",
1705 shared_libs: ["liba"],
1706 system_shared_libs: [],
1707 stl: "none",
1708 apex_available: [ "otherapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001709 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001710 }
1711
1712 cc_library {
1713 name: "liba",
1714 shared_libs: ["libz"],
1715 system_shared_libs: [],
1716 stl: "none",
1717 apex_available: [
1718 "//apex_available:anyapex",
1719 "//apex_available:platform",
1720 ],
Jooyung Han749dc692020-04-15 11:03:39 +09001721 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001722 }
1723
1724 cc_library {
1725 name: "libz",
1726 system_shared_libs: [],
1727 stl: "none",
1728 stubs: {
Jooyung Han749dc692020-04-15 11:03:39 +09001729 versions: ["28", "30"],
Jooyung Han03b51852020-02-26 22:45:42 +09001730 },
1731 }
Jooyung Han749dc692020-04-15 11:03:39 +09001732 `)
Jooyung Han03b51852020-02-26 22:45:42 +09001733
1734 expectLink := func(from, from_variant, to, to_variant string) {
1735 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1736 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1737 }
1738 expectNoLink := func(from, from_variant, to, to_variant string) {
1739 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1740 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1741 }
1742 // platform liba is linked to non-stub version
1743 expectLink("liba", "shared", "libz", "shared")
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001744 // liba in myapex is linked to current
1745 expectLink("liba", "shared_apex29", "libz", "shared_current")
1746 expectNoLink("liba", "shared_apex29", "libz", "shared_30")
Jiyong Park55549df2021-02-26 23:57:23 +09001747 expectNoLink("liba", "shared_apex29", "libz", "shared_28")
Colin Crossaede88c2020-08-11 12:17:01 -07001748 expectNoLink("liba", "shared_apex29", "libz", "shared")
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001749 // liba in otherapex is linked to current
1750 expectLink("liba", "shared_apex30", "libz", "shared_current")
1751 expectNoLink("liba", "shared_apex30", "libz", "shared_30")
Colin Crossaede88c2020-08-11 12:17:01 -07001752 expectNoLink("liba", "shared_apex30", "libz", "shared_28")
1753 expectNoLink("liba", "shared_apex30", "libz", "shared")
Jooyung Han03b51852020-02-26 22:45:42 +09001754}
1755
Jooyung Hanaed150d2020-04-02 01:41:41 +09001756func TestApexMinSdkVersion_SupportsCodeNames(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001757 ctx := testApex(t, `
Jooyung Hanaed150d2020-04-02 01:41:41 +09001758 apex {
1759 name: "myapex",
1760 key: "myapex.key",
1761 native_shared_libs: ["libx"],
1762 min_sdk_version: "R",
1763 }
1764
1765 apex_key {
1766 name: "myapex.key",
1767 public_key: "testkey.avbpubkey",
1768 private_key: "testkey.pem",
1769 }
1770
1771 cc_library {
1772 name: "libx",
1773 shared_libs: ["libz"],
1774 system_shared_libs: [],
1775 stl: "none",
1776 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001777 min_sdk_version: "R",
Jooyung Hanaed150d2020-04-02 01:41:41 +09001778 }
1779
1780 cc_library {
1781 name: "libz",
1782 system_shared_libs: [],
1783 stl: "none",
1784 stubs: {
1785 versions: ["29", "R"],
1786 },
1787 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001788 `,
1789 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1790 variables.Platform_version_active_codenames = []string{"R"}
1791 }),
1792 )
Jooyung Hanaed150d2020-04-02 01:41:41 +09001793
1794 expectLink := func(from, from_variant, to, to_variant string) {
1795 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1796 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1797 }
1798 expectNoLink := func(from, from_variant, to, to_variant string) {
1799 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1800 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1801 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001802 expectLink("libx", "shared_apex10000", "libz", "shared_current")
1803 expectNoLink("libx", "shared_apex10000", "libz", "shared_R")
Colin Crossaede88c2020-08-11 12:17:01 -07001804 expectNoLink("libx", "shared_apex10000", "libz", "shared_29")
1805 expectNoLink("libx", "shared_apex10000", "libz", "shared")
Jooyung Hanaed150d2020-04-02 01:41:41 +09001806}
1807
Jooyung Han4c4da062021-06-23 10:23:16 +09001808func TestApexMinSdkVersion_SupportsCodeNames_JavaLibs(t *testing.T) {
1809 testApex(t, `
1810 apex {
1811 name: "myapex",
1812 key: "myapex.key",
1813 java_libs: ["libx"],
1814 min_sdk_version: "S",
1815 }
1816
1817 apex_key {
1818 name: "myapex.key",
1819 public_key: "testkey.avbpubkey",
1820 private_key: "testkey.pem",
1821 }
1822
1823 java_library {
1824 name: "libx",
1825 srcs: ["a.java"],
1826 apex_available: [ "myapex" ],
1827 sdk_version: "current",
1828 min_sdk_version: "S", // should be okay
1829 }
1830 `,
1831 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1832 variables.Platform_version_active_codenames = []string{"S"}
1833 variables.Platform_sdk_codename = proptools.StringPtr("S")
1834 }),
1835 )
1836}
1837
Jooyung Han749dc692020-04-15 11:03:39 +09001838func TestApexMinSdkVersion_DefaultsToLatest(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001839 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001840 apex {
1841 name: "myapex",
1842 key: "myapex.key",
1843 native_shared_libs: ["libx"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001844 updatable: false,
Jooyung Han03b51852020-02-26 22:45:42 +09001845 }
1846
1847 apex_key {
1848 name: "myapex.key",
1849 public_key: "testkey.avbpubkey",
1850 private_key: "testkey.pem",
1851 }
1852
1853 cc_library {
1854 name: "libx",
1855 shared_libs: ["libz"],
1856 system_shared_libs: [],
1857 stl: "none",
1858 apex_available: [ "myapex" ],
1859 }
1860
1861 cc_library {
1862 name: "libz",
1863 system_shared_libs: [],
1864 stl: "none",
1865 stubs: {
1866 versions: ["1", "2"],
1867 },
1868 }
1869 `)
1870
1871 expectLink := func(from, from_variant, to, to_variant string) {
1872 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1873 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1874 }
1875 expectNoLink := func(from, from_variant, to, to_variant string) {
1876 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1877 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1878 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001879 expectLink("libx", "shared_apex10000", "libz", "shared_current")
Colin Crossaede88c2020-08-11 12:17:01 -07001880 expectNoLink("libx", "shared_apex10000", "libz", "shared_1")
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001881 expectNoLink("libx", "shared_apex10000", "libz", "shared_2")
Colin Crossaede88c2020-08-11 12:17:01 -07001882 expectNoLink("libx", "shared_apex10000", "libz", "shared")
Jooyung Han03b51852020-02-26 22:45:42 +09001883}
1884
Jiyong Park5df7bd32021-08-25 16:18:46 +09001885func TestApexMinSdkVersion_crtobjectInVendorApex(t *testing.T) {
1886 ctx := testApex(t, `
1887 apex {
1888 name: "myapex",
1889 key: "myapex.key",
1890 native_shared_libs: ["mylib"],
1891 updatable: false,
1892 vendor: true,
1893 min_sdk_version: "29",
1894 }
1895
1896 apex_key {
1897 name: "myapex.key",
1898 public_key: "testkey.avbpubkey",
1899 private_key: "testkey.pem",
1900 }
1901
1902 cc_library {
1903 name: "mylib",
1904 vendor_available: true,
1905 system_shared_libs: [],
1906 stl: "none",
1907 apex_available: [ "myapex" ],
1908 min_sdk_version: "29",
1909 }
1910 `)
1911
1912 vendorVariant := "android_vendor.29_arm64_armv8-a"
1913
1914 // First check that the correct variant of crtbegin_so is used.
1915 ldRule := ctx.ModuleForTests("mylib", vendorVariant+"_shared_apex29").Rule("ld")
1916 crtBegin := names(ldRule.Args["crtBegin"])
1917 ensureListContains(t, crtBegin, "out/soong/.intermediates/"+cc.DefaultCcCommonTestModulesDir+"crtbegin_so/"+vendorVariant+"_apex29/crtbegin_so.o")
1918
1919 // Ensure that the crtbegin_so used by the APEX is targeting 29
1920 cflags := ctx.ModuleForTests("crtbegin_so", vendorVariant+"_apex29").Rule("cc").Args["cFlags"]
1921 android.AssertStringDoesContain(t, "cflags", cflags, "-target aarch64-linux-android29")
1922}
1923
Jooyung Han03b51852020-02-26 22:45:42 +09001924func TestPlatformUsesLatestStubsFromApexes(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001925 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001926 apex {
1927 name: "myapex",
1928 key: "myapex.key",
1929 native_shared_libs: ["libx"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001930 updatable: false,
Jooyung Han03b51852020-02-26 22:45:42 +09001931 }
1932
1933 apex_key {
1934 name: "myapex.key",
1935 public_key: "testkey.avbpubkey",
1936 private_key: "testkey.pem",
1937 }
1938
1939 cc_library {
1940 name: "libx",
1941 system_shared_libs: [],
1942 stl: "none",
1943 apex_available: [ "myapex" ],
1944 stubs: {
1945 versions: ["1", "2"],
1946 },
1947 }
1948
1949 cc_library {
1950 name: "libz",
1951 shared_libs: ["libx"],
1952 system_shared_libs: [],
1953 stl: "none",
1954 }
1955 `)
1956
1957 expectLink := func(from, from_variant, to, to_variant string) {
Colin Cross56a83212020-09-15 18:30:11 -07001958 t.Helper()
Jooyung Han03b51852020-02-26 22:45:42 +09001959 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1960 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1961 }
1962 expectNoLink := func(from, from_variant, to, to_variant string) {
Colin Cross56a83212020-09-15 18:30:11 -07001963 t.Helper()
Jooyung Han03b51852020-02-26 22:45:42 +09001964 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1965 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1966 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001967 expectLink("libz", "shared", "libx", "shared_current")
1968 expectNoLink("libz", "shared", "libx", "shared_2")
Jooyung Han03b51852020-02-26 22:45:42 +09001969 expectNoLink("libz", "shared", "libz", "shared_1")
1970 expectNoLink("libz", "shared", "libz", "shared")
1971}
1972
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001973var prepareForTestWithSantitizeHwaddress = android.FixtureModifyProductVariables(
1974 func(variables android.FixtureProductVariables) {
1975 variables.SanitizeDevice = []string{"hwaddress"}
1976 },
1977)
1978
Jooyung Han75568392020-03-20 04:29:24 +09001979func TestQApexesUseLatestStubsInBundledBuildsAndHWASAN(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001980 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001981 apex {
1982 name: "myapex",
1983 key: "myapex.key",
1984 native_shared_libs: ["libx"],
1985 min_sdk_version: "29",
1986 }
1987
1988 apex_key {
1989 name: "myapex.key",
1990 public_key: "testkey.avbpubkey",
1991 private_key: "testkey.pem",
1992 }
1993
1994 cc_library {
1995 name: "libx",
1996 shared_libs: ["libbar"],
1997 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001998 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001999 }
2000
2001 cc_library {
2002 name: "libbar",
2003 stubs: {
2004 versions: ["29", "30"],
2005 },
2006 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002007 `,
2008 prepareForTestWithSantitizeHwaddress,
2009 )
Jooyung Han03b51852020-02-26 22:45:42 +09002010 expectLink := func(from, from_variant, to, to_variant string) {
2011 ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
2012 libFlags := ld.Args["libFlags"]
2013 ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
2014 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002015 expectLink("libx", "shared_hwasan_apex29", "libbar", "shared_current")
Jooyung Han03b51852020-02-26 22:45:42 +09002016}
2017
Jooyung Han75568392020-03-20 04:29:24 +09002018func TestQTargetApexUsesStaticUnwinder(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002019 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09002020 apex {
2021 name: "myapex",
2022 key: "myapex.key",
2023 native_shared_libs: ["libx"],
2024 min_sdk_version: "29",
2025 }
2026
2027 apex_key {
2028 name: "myapex.key",
2029 public_key: "testkey.avbpubkey",
2030 private_key: "testkey.pem",
2031 }
2032
2033 cc_library {
2034 name: "libx",
2035 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09002036 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09002037 }
Jooyung Han75568392020-03-20 04:29:24 +09002038 `)
Jooyung Han03b51852020-02-26 22:45:42 +09002039
2040 // ensure apex variant of c++ is linked with static unwinder
Colin Crossaede88c2020-08-11 12:17:01 -07002041 cm := ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared_apex29").Module().(*cc.Module)
Ryan Prichardb35a85e2021-01-13 19:18:53 -08002042 ensureListContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
Jooyung Han03b51852020-02-26 22:45:42 +09002043 // note that platform variant is not.
2044 cm = ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared").Module().(*cc.Module)
Ryan Prichardb35a85e2021-01-13 19:18:53 -08002045 ensureListNotContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
Jooyung Han03b51852020-02-26 22:45:42 +09002046}
2047
Jooyung Han749dc692020-04-15 11:03:39 +09002048func TestApexMinSdkVersion_ErrorIfIncompatibleVersion(t *testing.T) {
2049 testApexError(t, `module "mylib".*: should support min_sdk_version\(29\)`, `
Jooyung Han03b51852020-02-26 22:45:42 +09002050 apex {
2051 name: "myapex",
2052 key: "myapex.key",
Jooyung Han749dc692020-04-15 11:03:39 +09002053 native_shared_libs: ["mylib"],
2054 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09002055 }
2056
2057 apex_key {
2058 name: "myapex.key",
2059 public_key: "testkey.avbpubkey",
2060 private_key: "testkey.pem",
2061 }
Jooyung Han749dc692020-04-15 11:03:39 +09002062
2063 cc_library {
2064 name: "mylib",
2065 srcs: ["mylib.cpp"],
2066 system_shared_libs: [],
2067 stl: "none",
2068 apex_available: [
2069 "myapex",
2070 ],
2071 min_sdk_version: "30",
2072 }
2073 `)
Ivan Lozano3e9f9e42020-12-04 15:05:43 -05002074
2075 testApexError(t, `module "libfoo.ffi".*: should support min_sdk_version\(29\)`, `
2076 apex {
2077 name: "myapex",
2078 key: "myapex.key",
2079 native_shared_libs: ["libfoo.ffi"],
2080 min_sdk_version: "29",
2081 }
2082
2083 apex_key {
2084 name: "myapex.key",
2085 public_key: "testkey.avbpubkey",
2086 private_key: "testkey.pem",
2087 }
2088
2089 rust_ffi_shared {
2090 name: "libfoo.ffi",
2091 srcs: ["foo.rs"],
2092 crate_name: "foo",
2093 apex_available: [
2094 "myapex",
2095 ],
2096 min_sdk_version: "30",
2097 }
2098 `)
Jaewoong Jung56e12db2021-04-02 00:38:25 +00002099
2100 testApexError(t, `module "libfoo".*: should support min_sdk_version\(29\)`, `
2101 apex {
2102 name: "myapex",
2103 key: "myapex.key",
2104 java_libs: ["libfoo"],
2105 min_sdk_version: "29",
2106 }
2107
2108 apex_key {
2109 name: "myapex.key",
2110 public_key: "testkey.avbpubkey",
2111 private_key: "testkey.pem",
2112 }
2113
2114 java_import {
2115 name: "libfoo",
2116 jars: ["libfoo.jar"],
2117 apex_available: [
2118 "myapex",
2119 ],
2120 min_sdk_version: "30",
2121 }
2122 `)
Jooyung Han749dc692020-04-15 11:03:39 +09002123}
2124
2125func TestApexMinSdkVersion_Okay(t *testing.T) {
2126 testApex(t, `
2127 apex {
2128 name: "myapex",
2129 key: "myapex.key",
2130 native_shared_libs: ["libfoo"],
2131 java_libs: ["libbar"],
2132 min_sdk_version: "29",
2133 }
2134
2135 apex_key {
2136 name: "myapex.key",
2137 public_key: "testkey.avbpubkey",
2138 private_key: "testkey.pem",
2139 }
2140
2141 cc_library {
2142 name: "libfoo",
2143 srcs: ["mylib.cpp"],
2144 shared_libs: ["libfoo_dep"],
2145 apex_available: ["myapex"],
2146 min_sdk_version: "29",
2147 }
2148
2149 cc_library {
2150 name: "libfoo_dep",
2151 srcs: ["mylib.cpp"],
2152 apex_available: ["myapex"],
2153 min_sdk_version: "29",
2154 }
2155
2156 java_library {
2157 name: "libbar",
2158 sdk_version: "current",
2159 srcs: ["a.java"],
Jaewoong Jung56e12db2021-04-02 00:38:25 +00002160 static_libs: [
2161 "libbar_dep",
2162 "libbar_import_dep",
2163 ],
Jooyung Han749dc692020-04-15 11:03:39 +09002164 apex_available: ["myapex"],
2165 min_sdk_version: "29",
2166 }
2167
2168 java_library {
2169 name: "libbar_dep",
2170 sdk_version: "current",
2171 srcs: ["a.java"],
2172 apex_available: ["myapex"],
2173 min_sdk_version: "29",
2174 }
Jaewoong Jung56e12db2021-04-02 00:38:25 +00002175
2176 java_import {
2177 name: "libbar_import_dep",
2178 jars: ["libbar.jar"],
2179 apex_available: ["myapex"],
2180 min_sdk_version: "29",
2181 }
Jooyung Han03b51852020-02-26 22:45:42 +09002182 `)
2183}
2184
Artur Satayev8cf899a2020-04-15 17:29:42 +01002185func TestJavaStableSdkVersion(t *testing.T) {
2186 testCases := []struct {
2187 name string
2188 expectedError string
2189 bp string
Paul Duffin1ea7c9f2021-03-15 09:39:13 +00002190 preparer android.FixturePreparer
Artur Satayev8cf899a2020-04-15 17:29:42 +01002191 }{
2192 {
2193 name: "Non-updatable apex with non-stable dep",
2194 bp: `
2195 apex {
2196 name: "myapex",
2197 java_libs: ["myjar"],
2198 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002199 updatable: false,
Artur Satayev8cf899a2020-04-15 17:29:42 +01002200 }
2201 apex_key {
2202 name: "myapex.key",
2203 public_key: "testkey.avbpubkey",
2204 private_key: "testkey.pem",
2205 }
2206 java_library {
2207 name: "myjar",
2208 srcs: ["foo/bar/MyClass.java"],
Paul Duffin043f5e72021-03-05 00:00:01 +00002209 sdk_version: "test_current",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002210 apex_available: ["myapex"],
2211 }
2212 `,
2213 },
2214 {
2215 name: "Updatable apex with stable dep",
2216 bp: `
2217 apex {
2218 name: "myapex",
2219 java_libs: ["myjar"],
2220 key: "myapex.key",
2221 updatable: true,
2222 min_sdk_version: "29",
2223 }
2224 apex_key {
2225 name: "myapex.key",
2226 public_key: "testkey.avbpubkey",
2227 private_key: "testkey.pem",
2228 }
2229 java_library {
2230 name: "myjar",
2231 srcs: ["foo/bar/MyClass.java"],
2232 sdk_version: "current",
2233 apex_available: ["myapex"],
Jooyung Han749dc692020-04-15 11:03:39 +09002234 min_sdk_version: "29",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002235 }
2236 `,
2237 },
2238 {
2239 name: "Updatable apex with non-stable dep",
2240 expectedError: "cannot depend on \"myjar\"",
2241 bp: `
2242 apex {
2243 name: "myapex",
2244 java_libs: ["myjar"],
2245 key: "myapex.key",
2246 updatable: true,
2247 }
2248 apex_key {
2249 name: "myapex.key",
2250 public_key: "testkey.avbpubkey",
2251 private_key: "testkey.pem",
2252 }
2253 java_library {
2254 name: "myjar",
2255 srcs: ["foo/bar/MyClass.java"],
Paul Duffin043f5e72021-03-05 00:00:01 +00002256 sdk_version: "test_current",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002257 apex_available: ["myapex"],
2258 }
2259 `,
2260 },
2261 {
Paul Duffin1ea7c9f2021-03-15 09:39:13 +00002262 name: "Updatable apex with non-stable legacy core platform dep",
2263 expectedError: `\Qcannot depend on "myjar-uses-legacy": non stable SDK core_platform_current - uses legacy core platform\E`,
2264 bp: `
2265 apex {
2266 name: "myapex",
2267 java_libs: ["myjar-uses-legacy"],
2268 key: "myapex.key",
2269 updatable: true,
2270 }
2271 apex_key {
2272 name: "myapex.key",
2273 public_key: "testkey.avbpubkey",
2274 private_key: "testkey.pem",
2275 }
2276 java_library {
2277 name: "myjar-uses-legacy",
2278 srcs: ["foo/bar/MyClass.java"],
2279 sdk_version: "core_platform",
2280 apex_available: ["myapex"],
2281 }
2282 `,
2283 preparer: java.FixtureUseLegacyCorePlatformApi("myjar-uses-legacy"),
2284 },
2285 {
Paul Duffin043f5e72021-03-05 00:00:01 +00002286 name: "Updatable apex with non-stable transitive dep",
2287 // This is not actually detecting that the transitive dependency is unstable, rather it is
2288 // detecting that the transitive dependency is building against a wider API surface than the
2289 // module that depends on it is using.
Jiyong Park670e0f62021-02-18 13:10:18 +09002290 expectedError: "compiles against Android API, but dependency \"transitive-jar\" is compiling against private API.",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002291 bp: `
2292 apex {
2293 name: "myapex",
2294 java_libs: ["myjar"],
2295 key: "myapex.key",
2296 updatable: true,
2297 }
2298 apex_key {
2299 name: "myapex.key",
2300 public_key: "testkey.avbpubkey",
2301 private_key: "testkey.pem",
2302 }
2303 java_library {
2304 name: "myjar",
2305 srcs: ["foo/bar/MyClass.java"],
2306 sdk_version: "current",
2307 apex_available: ["myapex"],
2308 static_libs: ["transitive-jar"],
2309 }
2310 java_library {
2311 name: "transitive-jar",
2312 srcs: ["foo/bar/MyClass.java"],
2313 sdk_version: "core_platform",
2314 apex_available: ["myapex"],
2315 }
2316 `,
2317 },
2318 }
2319
2320 for _, test := range testCases {
Paul Duffin1ea7c9f2021-03-15 09:39:13 +00002321 if test.name != "Updatable apex with non-stable legacy core platform dep" {
2322 continue
2323 }
Artur Satayev8cf899a2020-04-15 17:29:42 +01002324 t.Run(test.name, func(t *testing.T) {
Paul Duffin1ea7c9f2021-03-15 09:39:13 +00002325 errorHandler := android.FixtureExpectsNoErrors
2326 if test.expectedError != "" {
2327 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(test.expectedError)
Artur Satayev8cf899a2020-04-15 17:29:42 +01002328 }
Paul Duffin1ea7c9f2021-03-15 09:39:13 +00002329 android.GroupFixturePreparers(
2330 java.PrepareForTestWithJavaDefaultModules,
2331 PrepareForTestWithApexBuildComponents,
2332 prepareForTestWithMyapex,
2333 android.OptionalFixturePreparer(test.preparer),
2334 ).
2335 ExtendWithErrorHandler(errorHandler).
2336 RunTestWithBp(t, test.bp)
Artur Satayev8cf899a2020-04-15 17:29:42 +01002337 })
2338 }
2339}
2340
Jooyung Han749dc692020-04-15 11:03:39 +09002341func TestApexMinSdkVersion_ErrorIfDepIsNewer(t *testing.T) {
2342 testApexError(t, `module "mylib2".*: should support min_sdk_version\(29\) for "myapex"`, `
2343 apex {
2344 name: "myapex",
2345 key: "myapex.key",
2346 native_shared_libs: ["mylib"],
2347 min_sdk_version: "29",
2348 }
2349
2350 apex_key {
2351 name: "myapex.key",
2352 public_key: "testkey.avbpubkey",
2353 private_key: "testkey.pem",
2354 }
2355
2356 cc_library {
2357 name: "mylib",
2358 srcs: ["mylib.cpp"],
2359 shared_libs: ["mylib2"],
2360 system_shared_libs: [],
2361 stl: "none",
2362 apex_available: [
2363 "myapex",
2364 ],
2365 min_sdk_version: "29",
2366 }
2367
2368 // indirect part of the apex
2369 cc_library {
2370 name: "mylib2",
2371 srcs: ["mylib.cpp"],
2372 system_shared_libs: [],
2373 stl: "none",
2374 apex_available: [
2375 "myapex",
2376 ],
2377 min_sdk_version: "30",
2378 }
2379 `)
2380}
2381
2382func TestApexMinSdkVersion_ErrorIfDepIsNewer_Java(t *testing.T) {
2383 testApexError(t, `module "bar".*: should support min_sdk_version\(29\) for "myapex"`, `
2384 apex {
2385 name: "myapex",
2386 key: "myapex.key",
2387 apps: ["AppFoo"],
2388 min_sdk_version: "29",
2389 }
2390
2391 apex_key {
2392 name: "myapex.key",
2393 public_key: "testkey.avbpubkey",
2394 private_key: "testkey.pem",
2395 }
2396
2397 android_app {
2398 name: "AppFoo",
2399 srcs: ["foo/bar/MyClass.java"],
2400 sdk_version: "current",
2401 min_sdk_version: "29",
2402 system_modules: "none",
2403 stl: "none",
2404 static_libs: ["bar"],
2405 apex_available: [ "myapex" ],
2406 }
2407
2408 java_library {
2409 name: "bar",
2410 sdk_version: "current",
2411 srcs: ["a.java"],
2412 apex_available: [ "myapex" ],
2413 }
2414 `)
2415}
2416
2417func TestApexMinSdkVersion_OkayEvenWhenDepIsNewer_IfItSatisfiesApexMinSdkVersion(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002418 ctx := testApex(t, `
Jooyung Han749dc692020-04-15 11:03:39 +09002419 apex {
2420 name: "myapex",
2421 key: "myapex.key",
2422 native_shared_libs: ["mylib"],
2423 min_sdk_version: "29",
2424 }
2425
2426 apex_key {
2427 name: "myapex.key",
2428 public_key: "testkey.avbpubkey",
2429 private_key: "testkey.pem",
2430 }
2431
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002432 // mylib in myapex will link to mylib2#current
Jooyung Han749dc692020-04-15 11:03:39 +09002433 // mylib in otherapex will link to mylib2(non-stub) in otherapex as well
2434 cc_library {
2435 name: "mylib",
2436 srcs: ["mylib.cpp"],
2437 shared_libs: ["mylib2"],
2438 system_shared_libs: [],
2439 stl: "none",
2440 apex_available: ["myapex", "otherapex"],
2441 min_sdk_version: "29",
2442 }
2443
2444 cc_library {
2445 name: "mylib2",
2446 srcs: ["mylib.cpp"],
2447 system_shared_libs: [],
2448 stl: "none",
2449 apex_available: ["otherapex"],
2450 stubs: { versions: ["29", "30"] },
2451 min_sdk_version: "30",
2452 }
2453
2454 apex {
2455 name: "otherapex",
2456 key: "myapex.key",
2457 native_shared_libs: ["mylib", "mylib2"],
2458 min_sdk_version: "30",
2459 }
2460 `)
2461 expectLink := func(from, from_variant, to, to_variant string) {
2462 ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
2463 libFlags := ld.Args["libFlags"]
2464 ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
2465 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002466 expectLink("mylib", "shared_apex29", "mylib2", "shared_current")
Colin Crossaede88c2020-08-11 12:17:01 -07002467 expectLink("mylib", "shared_apex30", "mylib2", "shared_apex30")
Jooyung Han749dc692020-04-15 11:03:39 +09002468}
2469
Jooyung Haned124c32021-01-26 11:43:46 +09002470func TestApexMinSdkVersion_WorksWithSdkCodename(t *testing.T) {
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002471 withSAsActiveCodeNames := android.FixtureModifyProductVariables(
2472 func(variables android.FixtureProductVariables) {
2473 variables.Platform_sdk_codename = proptools.StringPtr("S")
2474 variables.Platform_version_active_codenames = []string{"S"}
2475 },
2476 )
Jooyung Haned124c32021-01-26 11:43:46 +09002477 testApexError(t, `libbar.*: should support min_sdk_version\(S\)`, `
2478 apex {
2479 name: "myapex",
2480 key: "myapex.key",
2481 native_shared_libs: ["libfoo"],
2482 min_sdk_version: "S",
2483 }
2484 apex_key {
2485 name: "myapex.key",
2486 public_key: "testkey.avbpubkey",
2487 private_key: "testkey.pem",
2488 }
2489 cc_library {
2490 name: "libfoo",
2491 shared_libs: ["libbar"],
2492 apex_available: ["myapex"],
2493 min_sdk_version: "29",
2494 }
2495 cc_library {
2496 name: "libbar",
2497 apex_available: ["myapex"],
2498 }
2499 `, withSAsActiveCodeNames)
2500}
2501
2502func TestApexMinSdkVersion_WorksWithActiveCodenames(t *testing.T) {
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002503 withSAsActiveCodeNames := android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
2504 variables.Platform_sdk_codename = proptools.StringPtr("S")
2505 variables.Platform_version_active_codenames = []string{"S", "T"}
2506 })
Colin Cross1c460562021-02-16 17:55:47 -08002507 ctx := testApex(t, `
Jooyung Haned124c32021-01-26 11:43:46 +09002508 apex {
2509 name: "myapex",
2510 key: "myapex.key",
2511 native_shared_libs: ["libfoo"],
2512 min_sdk_version: "S",
2513 }
2514 apex_key {
2515 name: "myapex.key",
2516 public_key: "testkey.avbpubkey",
2517 private_key: "testkey.pem",
2518 }
2519 cc_library {
2520 name: "libfoo",
2521 shared_libs: ["libbar"],
2522 apex_available: ["myapex"],
2523 min_sdk_version: "S",
2524 }
2525 cc_library {
2526 name: "libbar",
2527 stubs: {
2528 symbol_file: "libbar.map.txt",
2529 versions: ["30", "S", "T"],
2530 },
2531 }
2532 `, withSAsActiveCodeNames)
2533
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002534 // ensure libfoo is linked with current version of libbar stub
Jooyung Haned124c32021-01-26 11:43:46 +09002535 libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_apex10000")
2536 libFlags := libfoo.Rule("ld").Args["libFlags"]
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002537 ensureContains(t, libFlags, "android_arm64_armv8-a_shared_current/libbar.so")
Jooyung Haned124c32021-01-26 11:43:46 +09002538}
2539
Jiyong Park7c2ee712018-12-07 00:42:25 +09002540func TestFilesInSubDir(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002541 ctx := testApex(t, `
Jiyong Park7c2ee712018-12-07 00:42:25 +09002542 apex {
2543 name: "myapex",
2544 key: "myapex.key",
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002545 native_shared_libs: ["mylib"],
2546 binaries: ["mybin"],
Jiyong Park7c2ee712018-12-07 00:42:25 +09002547 prebuilts: ["myetc"],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002548 compile_multilib: "both",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002549 updatable: false,
Jiyong Park7c2ee712018-12-07 00:42:25 +09002550 }
2551
2552 apex_key {
2553 name: "myapex.key",
2554 public_key: "testkey.avbpubkey",
2555 private_key: "testkey.pem",
2556 }
2557
2558 prebuilt_etc {
2559 name: "myetc",
2560 src: "myprebuilt",
2561 sub_dir: "foo/bar",
2562 }
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002563
2564 cc_library {
2565 name: "mylib",
2566 srcs: ["mylib.cpp"],
2567 relative_install_path: "foo/bar",
2568 system_shared_libs: [],
2569 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002570 apex_available: [ "myapex" ],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002571 }
2572
2573 cc_binary {
2574 name: "mybin",
2575 srcs: ["mylib.cpp"],
2576 relative_install_path: "foo/bar",
2577 system_shared_libs: [],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002578 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002579 apex_available: [ "myapex" ],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002580 }
Jiyong Park7c2ee712018-12-07 00:42:25 +09002581 `)
2582
Sundong Ahnabb64432019-10-22 13:58:29 +09002583 generateFsRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("generateFsConfig")
Jiyong Park7c2ee712018-12-07 00:42:25 +09002584 dirs := strings.Split(generateFsRule.Args["exec_paths"], " ")
2585
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002586 // Ensure that the subdirectories are all listed
Jiyong Park7c2ee712018-12-07 00:42:25 +09002587 ensureListContains(t, dirs, "etc")
2588 ensureListContains(t, dirs, "etc/foo")
2589 ensureListContains(t, dirs, "etc/foo/bar")
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002590 ensureListContains(t, dirs, "lib64")
2591 ensureListContains(t, dirs, "lib64/foo")
2592 ensureListContains(t, dirs, "lib64/foo/bar")
2593 ensureListContains(t, dirs, "lib")
2594 ensureListContains(t, dirs, "lib/foo")
2595 ensureListContains(t, dirs, "lib/foo/bar")
2596
Jiyong Parkbd13e442019-03-15 18:10:35 +09002597 ensureListContains(t, dirs, "bin")
2598 ensureListContains(t, dirs, "bin/foo")
2599 ensureListContains(t, dirs, "bin/foo/bar")
Jiyong Park7c2ee712018-12-07 00:42:25 +09002600}
Jiyong Parkda6eb592018-12-19 17:12:36 +09002601
Jooyung Han35155c42020-02-06 17:33:20 +09002602func TestFilesInSubDirWhenNativeBridgeEnabled(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002603 ctx := testApex(t, `
Jooyung Han35155c42020-02-06 17:33:20 +09002604 apex {
2605 name: "myapex",
2606 key: "myapex.key",
2607 multilib: {
2608 both: {
2609 native_shared_libs: ["mylib"],
2610 binaries: ["mybin"],
2611 },
2612 },
2613 compile_multilib: "both",
2614 native_bridge_supported: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002615 updatable: false,
Jooyung Han35155c42020-02-06 17:33:20 +09002616 }
2617
2618 apex_key {
2619 name: "myapex.key",
2620 public_key: "testkey.avbpubkey",
2621 private_key: "testkey.pem",
2622 }
2623
2624 cc_library {
2625 name: "mylib",
2626 relative_install_path: "foo/bar",
2627 system_shared_libs: [],
2628 stl: "none",
2629 apex_available: [ "myapex" ],
2630 native_bridge_supported: true,
2631 }
2632
2633 cc_binary {
2634 name: "mybin",
2635 relative_install_path: "foo/bar",
2636 system_shared_libs: [],
Jooyung Han35155c42020-02-06 17:33:20 +09002637 stl: "none",
2638 apex_available: [ "myapex" ],
2639 native_bridge_supported: true,
2640 compile_multilib: "both", // default is "first" for binary
2641 multilib: {
2642 lib64: {
2643 suffix: "64",
2644 },
2645 },
2646 }
2647 `, withNativeBridgeEnabled)
2648 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2649 "bin/foo/bar/mybin",
2650 "bin/foo/bar/mybin64",
2651 "bin/arm/foo/bar/mybin",
2652 "bin/arm64/foo/bar/mybin64",
2653 "lib/foo/bar/mylib.so",
2654 "lib/arm/foo/bar/mylib.so",
2655 "lib64/foo/bar/mylib.so",
2656 "lib64/arm64/foo/bar/mylib.so",
2657 })
2658}
2659
Jooyung Han85d61762020-06-24 23:50:26 +09002660func TestVendorApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002661 ctx := testApex(t, `
Jooyung Han85d61762020-06-24 23:50:26 +09002662 apex {
2663 name: "myapex",
2664 key: "myapex.key",
2665 binaries: ["mybin"],
2666 vendor: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002667 updatable: false,
Jooyung Han85d61762020-06-24 23:50:26 +09002668 }
2669 apex_key {
2670 name: "myapex.key",
2671 public_key: "testkey.avbpubkey",
2672 private_key: "testkey.pem",
2673 }
2674 cc_binary {
2675 name: "mybin",
2676 vendor: true,
2677 shared_libs: ["libfoo"],
2678 }
2679 cc_library {
2680 name: "libfoo",
2681 proprietary: true,
2682 }
2683 `)
2684
2685 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2686 "bin/mybin",
2687 "lib64/libfoo.so",
2688 // TODO(b/159195575): Add an option to use VNDK libs from VNDK APEX
2689 "lib64/libc++.so",
2690 })
2691
2692 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07002693 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Han85d61762020-06-24 23:50:26 +09002694 name := apexBundle.BaseModuleName()
2695 prefix := "TARGET_"
2696 var builder strings.Builder
2697 data.Custom(&builder, name, prefix, "", data)
Paul Duffin37ba3442021-03-29 00:21:08 +01002698 androidMk := android.StringRelativeToTop(ctx.Config(), builder.String())
2699 installPath := "out/target/product/test_device/vendor/apex"
Lukacs T. Berki7690c092021-02-26 14:27:36 +01002700 ensureContains(t, androidMk, "LOCAL_MODULE_PATH := "+installPath)
Jooyung Han6c4cc9c2020-07-29 16:00:54 +09002701
2702 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
2703 requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
2704 ensureListNotContains(t, requireNativeLibs, ":vndk")
Jooyung Han85d61762020-06-24 23:50:26 +09002705}
2706
Jooyung Handf78e212020-07-22 15:54:47 +09002707func TestVendorApex_use_vndk_as_stable(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002708 ctx := testApex(t, `
Jooyung Handf78e212020-07-22 15:54:47 +09002709 apex {
2710 name: "myapex",
2711 key: "myapex.key",
2712 binaries: ["mybin"],
2713 vendor: true,
2714 use_vndk_as_stable: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002715 updatable: false,
Jooyung Handf78e212020-07-22 15:54:47 +09002716 }
2717 apex_key {
2718 name: "myapex.key",
2719 public_key: "testkey.avbpubkey",
2720 private_key: "testkey.pem",
2721 }
2722 cc_binary {
2723 name: "mybin",
2724 vendor: true,
2725 shared_libs: ["libvndk", "libvendor"],
2726 }
2727 cc_library {
2728 name: "libvndk",
2729 vndk: {
2730 enabled: true,
2731 },
2732 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09002733 product_available: true,
Jooyung Handf78e212020-07-22 15:54:47 +09002734 }
2735 cc_library {
2736 name: "libvendor",
2737 vendor: true,
2738 }
2739 `)
2740
Jiyong Parkf58c46e2021-04-01 21:35:20 +09002741 vendorVariant := "android_vendor.29_arm64_armv8-a"
Jooyung Handf78e212020-07-22 15:54:47 +09002742
Paul Duffina71a67a2021-03-29 00:42:57 +01002743 ldRule := ctx.ModuleForTests("mybin", vendorVariant+"_apex10000").Rule("ld")
Jooyung Handf78e212020-07-22 15:54:47 +09002744 libs := names(ldRule.Args["libFlags"])
2745 // VNDK libs(libvndk/libc++) as they are
Paul Duffin37ba3442021-03-29 00:21:08 +01002746 ensureListContains(t, libs, "out/soong/.intermediates/libvndk/"+vendorVariant+"_shared/libvndk.so")
2747 ensureListContains(t, libs, "out/soong/.intermediates/"+cc.DefaultCcCommonTestModulesDir+"libc++/"+vendorVariant+"_shared/libc++.so")
Jooyung Handf78e212020-07-22 15:54:47 +09002748 // non-stable Vendor libs as APEX variants
Paul Duffin37ba3442021-03-29 00:21:08 +01002749 ensureListContains(t, libs, "out/soong/.intermediates/libvendor/"+vendorVariant+"_shared_apex10000/libvendor.so")
Jooyung Handf78e212020-07-22 15:54:47 +09002750
2751 // VNDK libs are not included when use_vndk_as_stable: true
2752 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2753 "bin/mybin",
2754 "lib64/libvendor.so",
2755 })
Jooyung Han6c4cc9c2020-07-29 16:00:54 +09002756
2757 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
2758 requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
2759 ensureListContains(t, requireNativeLibs, ":vndk")
Jooyung Handf78e212020-07-22 15:54:47 +09002760}
2761
Justin Yun13decfb2021-03-08 19:25:55 +09002762func TestProductVariant(t *testing.T) {
2763 ctx := testApex(t, `
2764 apex {
2765 name: "myapex",
2766 key: "myapex.key",
2767 updatable: false,
2768 product_specific: true,
2769 binaries: ["foo"],
2770 }
2771
2772 apex_key {
2773 name: "myapex.key",
2774 public_key: "testkey.avbpubkey",
2775 private_key: "testkey.pem",
2776 }
2777
2778 cc_binary {
2779 name: "foo",
2780 product_available: true,
2781 apex_available: ["myapex"],
2782 srcs: ["foo.cpp"],
2783 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002784 `, android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
2785 variables.ProductVndkVersion = proptools.StringPtr("current")
2786 }),
2787 )
Justin Yun13decfb2021-03-08 19:25:55 +09002788
2789 cflags := strings.Fields(
Jiyong Parkf58c46e2021-04-01 21:35:20 +09002790 ctx.ModuleForTests("foo", "android_product.29_arm64_armv8-a_apex10000").Rule("cc").Args["cFlags"])
Justin Yun13decfb2021-03-08 19:25:55 +09002791 ensureListContains(t, cflags, "-D__ANDROID_VNDK__")
2792 ensureListContains(t, cflags, "-D__ANDROID_APEX__")
2793 ensureListContains(t, cflags, "-D__ANDROID_PRODUCT__")
2794 ensureListNotContains(t, cflags, "-D__ANDROID_VENDOR__")
2795}
2796
Jooyung Han8e5685d2020-09-21 11:02:57 +09002797func TestApex_withPrebuiltFirmware(t *testing.T) {
2798 testCases := []struct {
2799 name string
2800 additionalProp string
2801 }{
2802 {"system apex with prebuilt_firmware", ""},
2803 {"vendor apex with prebuilt_firmware", "vendor: true,"},
2804 }
2805 for _, tc := range testCases {
2806 t.Run(tc.name, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002807 ctx := testApex(t, `
Jooyung Han8e5685d2020-09-21 11:02:57 +09002808 apex {
2809 name: "myapex",
2810 key: "myapex.key",
2811 prebuilts: ["myfirmware"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002812 updatable: false,
Jooyung Han8e5685d2020-09-21 11:02:57 +09002813 `+tc.additionalProp+`
2814 }
2815 apex_key {
2816 name: "myapex.key",
2817 public_key: "testkey.avbpubkey",
2818 private_key: "testkey.pem",
2819 }
2820 prebuilt_firmware {
2821 name: "myfirmware",
2822 src: "myfirmware.bin",
2823 filename_from_src: true,
2824 `+tc.additionalProp+`
2825 }
2826 `)
2827 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2828 "etc/firmware/myfirmware.bin",
2829 })
2830 })
2831 }
Jooyung Han0703fd82020-08-26 22:11:53 +09002832}
2833
Jooyung Hanefb184e2020-06-25 17:14:25 +09002834func TestAndroidMk_VendorApexRequired(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002835 ctx := testApex(t, `
Jooyung Hanefb184e2020-06-25 17:14:25 +09002836 apex {
2837 name: "myapex",
2838 key: "myapex.key",
2839 vendor: true,
2840 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002841 updatable: false,
Jooyung Hanefb184e2020-06-25 17:14:25 +09002842 }
2843
2844 apex_key {
2845 name: "myapex.key",
2846 public_key: "testkey.avbpubkey",
2847 private_key: "testkey.pem",
2848 }
2849
2850 cc_library {
2851 name: "mylib",
2852 vendor_available: true,
2853 }
2854 `)
2855
2856 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07002857 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Hanefb184e2020-06-25 17:14:25 +09002858 name := apexBundle.BaseModuleName()
2859 prefix := "TARGET_"
2860 var builder strings.Builder
2861 data.Custom(&builder, name, prefix, "", data)
2862 androidMk := builder.String()
2863 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += libc.vendor libm.vendor libdl.vendor\n")
2864}
2865
Jooyung Han2ed99d02020-06-24 23:26:26 +09002866func TestAndroidMkWritesCommonProperties(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002867 ctx := testApex(t, `
Jooyung Han2ed99d02020-06-24 23:26:26 +09002868 apex {
2869 name: "myapex",
2870 key: "myapex.key",
2871 vintf_fragments: ["fragment.xml"],
2872 init_rc: ["init.rc"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002873 updatable: false,
Jooyung Han2ed99d02020-06-24 23:26:26 +09002874 }
2875 apex_key {
2876 name: "myapex.key",
2877 public_key: "testkey.avbpubkey",
2878 private_key: "testkey.pem",
2879 }
2880 cc_binary {
2881 name: "mybin",
2882 }
2883 `)
2884
2885 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07002886 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Han2ed99d02020-06-24 23:26:26 +09002887 name := apexBundle.BaseModuleName()
2888 prefix := "TARGET_"
2889 var builder strings.Builder
2890 data.Custom(&builder, name, prefix, "", data)
2891 androidMk := builder.String()
Liz Kammer7b3dc8a2021-04-16 16:41:59 -04002892 ensureContains(t, androidMk, "LOCAL_FULL_VINTF_FRAGMENTS := fragment.xml\n")
Liz Kammer0c4f71c2021-04-06 10:35:10 -04002893 ensureContains(t, androidMk, "LOCAL_FULL_INIT_RC := init.rc\n")
Jooyung Han2ed99d02020-06-24 23:26:26 +09002894}
2895
Jiyong Park16e91a02018-12-20 18:18:08 +09002896func TestStaticLinking(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002897 ctx := testApex(t, `
Jiyong Park16e91a02018-12-20 18:18:08 +09002898 apex {
2899 name: "myapex",
2900 key: "myapex.key",
2901 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002902 updatable: false,
Jiyong Park16e91a02018-12-20 18:18:08 +09002903 }
2904
2905 apex_key {
2906 name: "myapex.key",
2907 public_key: "testkey.avbpubkey",
2908 private_key: "testkey.pem",
2909 }
2910
2911 cc_library {
2912 name: "mylib",
2913 srcs: ["mylib.cpp"],
2914 system_shared_libs: [],
2915 stl: "none",
2916 stubs: {
2917 versions: ["1", "2", "3"],
2918 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002919 apex_available: [
2920 "//apex_available:platform",
2921 "myapex",
2922 ],
Jiyong Park16e91a02018-12-20 18:18:08 +09002923 }
2924
2925 cc_binary {
2926 name: "not_in_apex",
2927 srcs: ["mylib.cpp"],
2928 static_libs: ["mylib"],
2929 static_executable: true,
2930 system_shared_libs: [],
2931 stl: "none",
2932 }
Jiyong Park16e91a02018-12-20 18:18:08 +09002933 `)
2934
Colin Cross7113d202019-11-20 16:39:12 -08002935 ldFlags := ctx.ModuleForTests("not_in_apex", "android_arm64_armv8-a").Rule("ld").Args["libFlags"]
Jiyong Park16e91a02018-12-20 18:18:08 +09002936
2937 // Ensure that not_in_apex is linking with the static variant of mylib
Colin Cross7113d202019-11-20 16:39:12 -08002938 ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_static/mylib.a")
Jiyong Park16e91a02018-12-20 18:18:08 +09002939}
Jiyong Park9335a262018-12-24 11:31:58 +09002940
2941func TestKeys(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002942 ctx := testApex(t, `
Jiyong Park9335a262018-12-24 11:31:58 +09002943 apex {
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002944 name: "myapex_keytest",
Jiyong Park9335a262018-12-24 11:31:58 +09002945 key: "myapex.key",
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002946 certificate: ":myapex.certificate",
Jiyong Park9335a262018-12-24 11:31:58 +09002947 native_shared_libs: ["mylib"],
Jooyung Han54aca7b2019-11-20 02:26:02 +09002948 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002949 updatable: false,
Jiyong Park9335a262018-12-24 11:31:58 +09002950 }
2951
2952 cc_library {
2953 name: "mylib",
2954 srcs: ["mylib.cpp"],
2955 system_shared_libs: [],
2956 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002957 apex_available: [ "myapex_keytest" ],
Jiyong Park9335a262018-12-24 11:31:58 +09002958 }
2959
2960 apex_key {
2961 name: "myapex.key",
2962 public_key: "testkey.avbpubkey",
2963 private_key: "testkey.pem",
2964 }
2965
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002966 android_app_certificate {
2967 name: "myapex.certificate",
2968 certificate: "testkey",
2969 }
2970
2971 android_app_certificate {
2972 name: "myapex.certificate.override",
2973 certificate: "testkey.override",
2974 }
2975
Jiyong Park9335a262018-12-24 11:31:58 +09002976 `)
2977
2978 // check the APEX keys
Jiyong Parkd1e293d2019-03-15 02:13:21 +09002979 keys := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
Jiyong Park9335a262018-12-24 11:31:58 +09002980
Jaewoong Jung18aefc12020-12-21 09:11:10 -08002981 if keys.publicKeyFile.String() != "vendor/foo/devkeys/testkey.avbpubkey" {
2982 t.Errorf("public key %q is not %q", keys.publicKeyFile.String(),
Jiyong Park9335a262018-12-24 11:31:58 +09002983 "vendor/foo/devkeys/testkey.avbpubkey")
2984 }
Jaewoong Jung18aefc12020-12-21 09:11:10 -08002985 if keys.privateKeyFile.String() != "vendor/foo/devkeys/testkey.pem" {
2986 t.Errorf("private key %q is not %q", keys.privateKeyFile.String(),
Jiyong Park9335a262018-12-24 11:31:58 +09002987 "vendor/foo/devkeys/testkey.pem")
2988 }
2989
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002990 // check the APK certs. It should be overridden to myapex.certificate.override
Sundong Ahnabb64432019-10-22 13:58:29 +09002991 certs := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk").Args["certificates"]
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002992 if certs != "testkey.override.x509.pem testkey.override.pk8" {
Jiyong Park9335a262018-12-24 11:31:58 +09002993 t.Errorf("cert and private key %q are not %q", certs,
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002994 "testkey.override.509.pem testkey.override.pk8")
Jiyong Park9335a262018-12-24 11:31:58 +09002995 }
2996}
Jiyong Park58e364a2019-01-19 19:24:06 +09002997
Jooyung Hanf121a652019-12-17 14:30:11 +09002998func TestCertificate(t *testing.T) {
2999 t.Run("if unspecified, it defaults to DefaultAppCertificate", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003000 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003001 apex {
3002 name: "myapex",
3003 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003004 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003005 }
3006 apex_key {
3007 name: "myapex.key",
3008 public_key: "testkey.avbpubkey",
3009 private_key: "testkey.pem",
3010 }`)
3011 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
3012 expected := "vendor/foo/devkeys/test.x509.pem vendor/foo/devkeys/test.pk8"
3013 if actual := rule.Args["certificates"]; actual != expected {
3014 t.Errorf("certificates should be %q, not %q", expected, actual)
3015 }
3016 })
3017 t.Run("override when unspecified", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003018 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003019 apex {
3020 name: "myapex_keytest",
3021 key: "myapex.key",
3022 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003023 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003024 }
3025 apex_key {
3026 name: "myapex.key",
3027 public_key: "testkey.avbpubkey",
3028 private_key: "testkey.pem",
3029 }
3030 android_app_certificate {
3031 name: "myapex.certificate.override",
3032 certificate: "testkey.override",
3033 }`)
3034 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
3035 expected := "testkey.override.x509.pem testkey.override.pk8"
3036 if actual := rule.Args["certificates"]; actual != expected {
3037 t.Errorf("certificates should be %q, not %q", expected, actual)
3038 }
3039 })
3040 t.Run("if specified as :module, it respects the prop", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003041 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003042 apex {
3043 name: "myapex",
3044 key: "myapex.key",
3045 certificate: ":myapex.certificate",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003046 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003047 }
3048 apex_key {
3049 name: "myapex.key",
3050 public_key: "testkey.avbpubkey",
3051 private_key: "testkey.pem",
3052 }
3053 android_app_certificate {
3054 name: "myapex.certificate",
3055 certificate: "testkey",
3056 }`)
3057 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
3058 expected := "testkey.x509.pem testkey.pk8"
3059 if actual := rule.Args["certificates"]; actual != expected {
3060 t.Errorf("certificates should be %q, not %q", expected, actual)
3061 }
3062 })
3063 t.Run("override when specifiec as <:module>", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003064 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003065 apex {
3066 name: "myapex_keytest",
3067 key: "myapex.key",
3068 file_contexts: ":myapex-file_contexts",
3069 certificate: ":myapex.certificate",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003070 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003071 }
3072 apex_key {
3073 name: "myapex.key",
3074 public_key: "testkey.avbpubkey",
3075 private_key: "testkey.pem",
3076 }
3077 android_app_certificate {
3078 name: "myapex.certificate.override",
3079 certificate: "testkey.override",
3080 }`)
3081 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
3082 expected := "testkey.override.x509.pem testkey.override.pk8"
3083 if actual := rule.Args["certificates"]; actual != expected {
3084 t.Errorf("certificates should be %q, not %q", expected, actual)
3085 }
3086 })
3087 t.Run("if specified as name, finds it from DefaultDevKeyDir", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003088 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003089 apex {
3090 name: "myapex",
3091 key: "myapex.key",
3092 certificate: "testkey",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003093 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003094 }
3095 apex_key {
3096 name: "myapex.key",
3097 public_key: "testkey.avbpubkey",
3098 private_key: "testkey.pem",
3099 }`)
3100 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
3101 expected := "vendor/foo/devkeys/testkey.x509.pem vendor/foo/devkeys/testkey.pk8"
3102 if actual := rule.Args["certificates"]; actual != expected {
3103 t.Errorf("certificates should be %q, not %q", expected, actual)
3104 }
3105 })
3106 t.Run("override when specified as <name>", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003107 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003108 apex {
3109 name: "myapex_keytest",
3110 key: "myapex.key",
3111 file_contexts: ":myapex-file_contexts",
3112 certificate: "testkey",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003113 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003114 }
3115 apex_key {
3116 name: "myapex.key",
3117 public_key: "testkey.avbpubkey",
3118 private_key: "testkey.pem",
3119 }
3120 android_app_certificate {
3121 name: "myapex.certificate.override",
3122 certificate: "testkey.override",
3123 }`)
3124 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
3125 expected := "testkey.override.x509.pem testkey.override.pk8"
3126 if actual := rule.Args["certificates"]; actual != expected {
3127 t.Errorf("certificates should be %q, not %q", expected, actual)
3128 }
3129 })
3130}
3131
Jiyong Park58e364a2019-01-19 19:24:06 +09003132func TestMacro(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003133 ctx := testApex(t, `
Jiyong Park58e364a2019-01-19 19:24:06 +09003134 apex {
3135 name: "myapex",
3136 key: "myapex.key",
Jooyung Hanc87a0592020-03-02 17:44:33 +09003137 native_shared_libs: ["mylib", "mylib2"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003138 updatable: false,
Jiyong Park58e364a2019-01-19 19:24:06 +09003139 }
3140
3141 apex {
3142 name: "otherapex",
3143 key: "myapex.key",
Jooyung Hanc87a0592020-03-02 17:44:33 +09003144 native_shared_libs: ["mylib", "mylib2"],
Jooyung Hanccce2f22020-03-07 03:45:53 +09003145 min_sdk_version: "29",
Jiyong Park58e364a2019-01-19 19:24:06 +09003146 }
3147
3148 apex_key {
3149 name: "myapex.key",
3150 public_key: "testkey.avbpubkey",
3151 private_key: "testkey.pem",
3152 }
3153
3154 cc_library {
3155 name: "mylib",
3156 srcs: ["mylib.cpp"],
3157 system_shared_libs: [],
3158 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003159 apex_available: [
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003160 "myapex",
3161 "otherapex",
3162 ],
Jooyung Han24282772020-03-21 23:20:55 +09003163 recovery_available: true,
Jooyung Han749dc692020-04-15 11:03:39 +09003164 min_sdk_version: "29",
Jiyong Park58e364a2019-01-19 19:24:06 +09003165 }
Jooyung Hanc87a0592020-03-02 17:44:33 +09003166 cc_library {
3167 name: "mylib2",
3168 srcs: ["mylib.cpp"],
3169 system_shared_libs: [],
3170 stl: "none",
3171 apex_available: [
3172 "myapex",
3173 "otherapex",
3174 ],
Colin Crossaede88c2020-08-11 12:17:01 -07003175 static_libs: ["mylib3"],
3176 recovery_available: true,
3177 min_sdk_version: "29",
3178 }
3179 cc_library {
3180 name: "mylib3",
3181 srcs: ["mylib.cpp"],
3182 system_shared_libs: [],
3183 stl: "none",
3184 apex_available: [
3185 "myapex",
3186 "otherapex",
3187 ],
Colin Crossaede88c2020-08-11 12:17:01 -07003188 recovery_available: true,
Jooyung Han749dc692020-04-15 11:03:39 +09003189 min_sdk_version: "29",
Jooyung Hanc87a0592020-03-02 17:44:33 +09003190 }
Jiyong Park58e364a2019-01-19 19:24:06 +09003191 `)
3192
Jooyung Hanc87a0592020-03-02 17:44:33 +09003193 // non-APEX variant does not have __ANDROID_APEX__ defined
Colin Cross7113d202019-11-20 16:39:12 -08003194 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09003195 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003196 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
Jooyung Hanc87a0592020-03-02 17:44:33 +09003197
Jooyung Hanccce2f22020-03-07 03:45:53 +09003198 // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
Colin Crossaede88c2020-08-11 12:17:01 -07003199 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
Jooyung Hanc87a0592020-03-02 17:44:33 +09003200 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003201 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=10000")
Jooyung Hanc87a0592020-03-02 17:44:33 +09003202
Jooyung Hanccce2f22020-03-07 03:45:53 +09003203 // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
Colin Crossaede88c2020-08-11 12:17:01 -07003204 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex29").Rule("cc").Args["cFlags"]
Jooyung Hanc87a0592020-03-02 17:44:33 +09003205 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003206 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=29")
Jiyong Park58e364a2019-01-19 19:24:06 +09003207
Colin Crossaede88c2020-08-11 12:17:01 -07003208 // When a cc_library sets use_apex_name_macro: true each apex gets a unique variant and
3209 // each variant defines additional macros to distinguish which apex variant it is built for
3210
3211 // non-APEX variant does not have __ANDROID_APEX__ defined
3212 mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
3213 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3214
Dan Albertb19953d2020-11-17 15:29:36 -08003215 // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__
Colin Crossaede88c2020-08-11 12:17:01 -07003216 mylibCFlags = ctx.ModuleForTests("mylib3", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
3217 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003218 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
Colin Crossaede88c2020-08-11 12:17:01 -07003219
Jooyung Hanc87a0592020-03-02 17:44:33 +09003220 // non-APEX variant does not have __ANDROID_APEX__ defined
3221 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
3222 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3223
Dan Albertb19953d2020-11-17 15:29:36 -08003224 // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__
Colin Crossaede88c2020-08-11 12:17:01 -07003225 mylibCFlags = ctx.ModuleForTests("mylib2", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jooyung Han24282772020-03-21 23:20:55 +09003226 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003227 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
Jiyong Park58e364a2019-01-19 19:24:06 +09003228}
Jiyong Park7e636d02019-01-28 16:16:54 +09003229
3230func TestHeaderLibsDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003231 ctx := testApex(t, `
Jiyong Park7e636d02019-01-28 16:16:54 +09003232 apex {
3233 name: "myapex",
3234 key: "myapex.key",
3235 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003236 updatable: false,
Jiyong Park7e636d02019-01-28 16:16:54 +09003237 }
3238
3239 apex_key {
3240 name: "myapex.key",
3241 public_key: "testkey.avbpubkey",
3242 private_key: "testkey.pem",
3243 }
3244
3245 cc_library_headers {
3246 name: "mylib_headers",
3247 export_include_dirs: ["my_include"],
3248 system_shared_libs: [],
3249 stl: "none",
Jiyong Park0f80c182020-01-31 02:49:53 +09003250 apex_available: [ "myapex" ],
Jiyong Park7e636d02019-01-28 16:16:54 +09003251 }
3252
3253 cc_library {
3254 name: "mylib",
3255 srcs: ["mylib.cpp"],
3256 system_shared_libs: [],
3257 stl: "none",
3258 header_libs: ["mylib_headers"],
3259 export_header_lib_headers: ["mylib_headers"],
3260 stubs: {
3261 versions: ["1", "2", "3"],
3262 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003263 apex_available: [ "myapex" ],
Jiyong Park7e636d02019-01-28 16:16:54 +09003264 }
3265
3266 cc_library {
3267 name: "otherlib",
3268 srcs: ["mylib.cpp"],
3269 system_shared_libs: [],
3270 stl: "none",
3271 shared_libs: ["mylib"],
3272 }
3273 `)
3274
Colin Cross7113d202019-11-20 16:39:12 -08003275 cFlags := ctx.ModuleForTests("otherlib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jiyong Park7e636d02019-01-28 16:16:54 +09003276
3277 // Ensure that the include path of the header lib is exported to 'otherlib'
3278 ensureContains(t, cFlags, "-Imy_include")
3279}
Alex Light9670d332019-01-29 18:07:33 -08003280
Jiyong Park7cd10e32020-01-14 09:22:18 +09003281type fileInApex struct {
3282 path string // path in apex
Jooyung Hana57af4a2020-01-23 05:36:59 +00003283 src string // src path
Jiyong Park7cd10e32020-01-14 09:22:18 +09003284 isLink bool
3285}
3286
Jooyung Hana57af4a2020-01-23 05:36:59 +00003287func getFiles(t *testing.T, ctx *android.TestContext, moduleName, variant string) []fileInApex {
Jooyung Han31c470b2019-10-18 16:26:59 +09003288 t.Helper()
Jooyung Hana57af4a2020-01-23 05:36:59 +00003289 apexRule := ctx.ModuleForTests(moduleName, variant).Rule("apexRule")
Jooyung Han31c470b2019-10-18 16:26:59 +09003290 copyCmds := apexRule.Args["copy_commands"]
3291 imageApexDir := "/image.apex/"
Jiyong Park7cd10e32020-01-14 09:22:18 +09003292 var ret []fileInApex
Jooyung Han31c470b2019-10-18 16:26:59 +09003293 for _, cmd := range strings.Split(copyCmds, "&&") {
3294 cmd = strings.TrimSpace(cmd)
3295 if cmd == "" {
3296 continue
3297 }
3298 terms := strings.Split(cmd, " ")
Jooyung Hana57af4a2020-01-23 05:36:59 +00003299 var dst, src string
Jiyong Park7cd10e32020-01-14 09:22:18 +09003300 var isLink bool
Jooyung Han31c470b2019-10-18 16:26:59 +09003301 switch terms[0] {
3302 case "mkdir":
3303 case "cp":
Jiyong Park7cd10e32020-01-14 09:22:18 +09003304 if len(terms) != 3 && len(terms) != 4 {
Jooyung Han31c470b2019-10-18 16:26:59 +09003305 t.Fatal("copyCmds contains invalid cp command", cmd)
3306 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09003307 dst = terms[len(terms)-1]
Jooyung Hana57af4a2020-01-23 05:36:59 +00003308 src = terms[len(terms)-2]
Jiyong Park7cd10e32020-01-14 09:22:18 +09003309 isLink = false
3310 case "ln":
3311 if len(terms) != 3 && len(terms) != 4 {
3312 // ln LINK TARGET or ln -s LINK TARGET
3313 t.Fatal("copyCmds contains invalid ln command", cmd)
3314 }
3315 dst = terms[len(terms)-1]
Jooyung Hana57af4a2020-01-23 05:36:59 +00003316 src = terms[len(terms)-2]
Jiyong Park7cd10e32020-01-14 09:22:18 +09003317 isLink = true
3318 default:
3319 t.Fatalf("copyCmds should contain mkdir/cp commands only: %q", cmd)
3320 }
3321 if dst != "" {
Jooyung Han31c470b2019-10-18 16:26:59 +09003322 index := strings.Index(dst, imageApexDir)
3323 if index == -1 {
3324 t.Fatal("copyCmds should copy a file to image.apex/", cmd)
3325 }
3326 dstFile := dst[index+len(imageApexDir):]
Jooyung Hana57af4a2020-01-23 05:36:59 +00003327 ret = append(ret, fileInApex{path: dstFile, src: src, isLink: isLink})
Jooyung Han31c470b2019-10-18 16:26:59 +09003328 }
3329 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09003330 return ret
3331}
3332
Jooyung Hana57af4a2020-01-23 05:36:59 +00003333func ensureExactContents(t *testing.T, ctx *android.TestContext, moduleName, variant string, files []string) {
3334 t.Helper()
Jiyong Park7cd10e32020-01-14 09:22:18 +09003335 var failed bool
3336 var surplus []string
3337 filesMatched := make(map[string]bool)
Jooyung Hana57af4a2020-01-23 05:36:59 +00003338 for _, file := range getFiles(t, ctx, moduleName, variant) {
Jooyung Hane6436d72020-02-27 13:31:56 +09003339 mactchFound := false
Jiyong Park7cd10e32020-01-14 09:22:18 +09003340 for _, expected := range files {
3341 if matched, _ := path.Match(expected, file.path); matched {
3342 filesMatched[expected] = true
Jooyung Hane6436d72020-02-27 13:31:56 +09003343 mactchFound = true
3344 break
Jiyong Park7cd10e32020-01-14 09:22:18 +09003345 }
3346 }
Jooyung Hane6436d72020-02-27 13:31:56 +09003347 if !mactchFound {
3348 surplus = append(surplus, file.path)
3349 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09003350 }
Jooyung Han31c470b2019-10-18 16:26:59 +09003351
Jooyung Han31c470b2019-10-18 16:26:59 +09003352 if len(surplus) > 0 {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003353 sort.Strings(surplus)
Jooyung Han31c470b2019-10-18 16:26:59 +09003354 t.Log("surplus files", surplus)
3355 failed = true
3356 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003357
3358 if len(files) > len(filesMatched) {
3359 var missing []string
3360 for _, expected := range files {
3361 if !filesMatched[expected] {
3362 missing = append(missing, expected)
3363 }
3364 }
3365 sort.Strings(missing)
Jooyung Han31c470b2019-10-18 16:26:59 +09003366 t.Log("missing files", missing)
3367 failed = true
3368 }
3369 if failed {
3370 t.Fail()
3371 }
3372}
3373
Jooyung Han344d5432019-08-23 11:17:39 +09003374func TestVndkApexCurrent(t *testing.T) {
Jooyung Han7d6e79b2021-06-24 01:53:43 +09003375 commonFiles := []string{
Jooyung Hane6436d72020-02-27 13:31:56 +09003376 "lib/libc++.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09003377 "lib64/libc++.so",
Jiyong Parkf58c46e2021-04-01 21:35:20 +09003378 "etc/llndk.libraries.29.txt",
3379 "etc/vndkcore.libraries.29.txt",
3380 "etc/vndksp.libraries.29.txt",
3381 "etc/vndkprivate.libraries.29.txt",
3382 "etc/vndkproduct.libraries.29.txt",
Jooyung Han7d6e79b2021-06-24 01:53:43 +09003383 }
3384 testCases := []struct {
3385 vndkVersion string
3386 expectedFiles []string
3387 }{
3388 {
3389 vndkVersion: "current",
3390 expectedFiles: append(commonFiles,
3391 "lib/libvndk.so",
3392 "lib/libvndksp.so",
3393 "lib64/libvndk.so",
3394 "lib64/libvndksp.so"),
3395 },
3396 {
3397 vndkVersion: "",
3398 expectedFiles: append(commonFiles,
3399 // Legacy VNDK APEX contains only VNDK-SP files (of core variant)
3400 "lib/libvndksp.so",
3401 "lib64/libvndksp.so"),
3402 },
3403 }
3404 for _, tc := range testCases {
3405 t.Run("VNDK.current with DeviceVndkVersion="+tc.vndkVersion, func(t *testing.T) {
3406 ctx := testApex(t, `
3407 apex_vndk {
3408 name: "com.android.vndk.current",
3409 key: "com.android.vndk.current.key",
3410 updatable: false,
3411 }
3412
3413 apex_key {
3414 name: "com.android.vndk.current.key",
3415 public_key: "testkey.avbpubkey",
3416 private_key: "testkey.pem",
3417 }
3418
3419 cc_library {
3420 name: "libvndk",
3421 srcs: ["mylib.cpp"],
3422 vendor_available: true,
3423 product_available: true,
3424 vndk: {
3425 enabled: true,
3426 },
3427 system_shared_libs: [],
3428 stl: "none",
3429 apex_available: [ "com.android.vndk.current" ],
3430 }
3431
3432 cc_library {
3433 name: "libvndksp",
3434 srcs: ["mylib.cpp"],
3435 vendor_available: true,
3436 product_available: true,
3437 vndk: {
3438 enabled: true,
3439 support_system_process: true,
3440 },
3441 system_shared_libs: [],
3442 stl: "none",
3443 apex_available: [ "com.android.vndk.current" ],
3444 }
3445
3446 // VNDK-Ext should not cause any problems
3447
3448 cc_library {
3449 name: "libvndk.ext",
3450 srcs: ["mylib2.cpp"],
3451 vendor: true,
3452 vndk: {
3453 enabled: true,
3454 extends: "libvndk",
3455 },
3456 system_shared_libs: [],
3457 stl: "none",
3458 }
3459
3460 cc_library {
3461 name: "libvndksp.ext",
3462 srcs: ["mylib2.cpp"],
3463 vendor: true,
3464 vndk: {
3465 enabled: true,
3466 support_system_process: true,
3467 extends: "libvndksp",
3468 },
3469 system_shared_libs: [],
3470 stl: "none",
3471 }
3472 `+vndkLibrariesTxtFiles("current"), android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
3473 variables.DeviceVndkVersion = proptools.StringPtr(tc.vndkVersion)
3474 }))
3475 ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", tc.expectedFiles)
3476 })
3477 }
Jooyung Han344d5432019-08-23 11:17:39 +09003478}
3479
3480func TestVndkApexWithPrebuilt(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003481 ctx := testApex(t, `
Jooyung Han344d5432019-08-23 11:17:39 +09003482 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003483 name: "com.android.vndk.current",
3484 key: "com.android.vndk.current.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003485 updatable: false,
Jooyung Han344d5432019-08-23 11:17:39 +09003486 }
3487
3488 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003489 name: "com.android.vndk.current.key",
Jooyung Han344d5432019-08-23 11:17:39 +09003490 public_key: "testkey.avbpubkey",
3491 private_key: "testkey.pem",
3492 }
3493
3494 cc_prebuilt_library_shared {
Jooyung Han31c470b2019-10-18 16:26:59 +09003495 name: "libvndk",
3496 srcs: ["libvndk.so"],
Jooyung Han344d5432019-08-23 11:17:39 +09003497 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003498 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003499 vndk: {
3500 enabled: true,
3501 },
3502 system_shared_libs: [],
3503 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003504 apex_available: [ "com.android.vndk.current" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003505 }
Jooyung Han31c470b2019-10-18 16:26:59 +09003506
3507 cc_prebuilt_library_shared {
3508 name: "libvndk.arm",
3509 srcs: ["libvndk.arm.so"],
3510 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003511 product_available: true,
Jooyung Han31c470b2019-10-18 16:26:59 +09003512 vndk: {
3513 enabled: true,
3514 },
3515 enabled: false,
3516 arch: {
3517 arm: {
3518 enabled: true,
3519 },
3520 },
3521 system_shared_libs: [],
3522 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003523 apex_available: [ "com.android.vndk.current" ],
Jooyung Han31c470b2019-10-18 16:26:59 +09003524 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003525 `+vndkLibrariesTxtFiles("current"),
3526 withFiles(map[string][]byte{
3527 "libvndk.so": nil,
3528 "libvndk.arm.so": nil,
3529 }))
Colin Cross2807f002021-03-02 10:15:29 -08003530 ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003531 "lib/libvndk.so",
3532 "lib/libvndk.arm.so",
3533 "lib64/libvndk.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09003534 "lib/libc++.so",
3535 "lib64/libc++.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003536 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003537 })
Jooyung Han344d5432019-08-23 11:17:39 +09003538}
3539
Jooyung Han39edb6c2019-11-06 16:53:07 +09003540func vndkLibrariesTxtFiles(vers ...string) (result string) {
3541 for _, v := range vers {
3542 if v == "current" {
Justin Yun8a2600c2020-12-07 12:44:03 +09003543 for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003544 result += `
Colin Crosse4e44bc2020-12-28 13:50:21 -08003545 ` + txt + `_libraries_txt {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003546 name: "` + txt + `.libraries.txt",
3547 }
3548 `
3549 }
3550 } else {
Justin Yun8a2600c2020-12-07 12:44:03 +09003551 for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003552 result += `
3553 prebuilt_etc {
3554 name: "` + txt + `.libraries.` + v + `.txt",
3555 src: "dummy.txt",
3556 }
3557 `
3558 }
3559 }
3560 }
3561 return
3562}
3563
Jooyung Han344d5432019-08-23 11:17:39 +09003564func TestVndkApexVersion(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003565 ctx := testApex(t, `
Jooyung Han344d5432019-08-23 11:17:39 +09003566 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003567 name: "com.android.vndk.v27",
Jooyung Han344d5432019-08-23 11:17:39 +09003568 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003569 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09003570 vndk_version: "27",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003571 updatable: false,
Jooyung Han344d5432019-08-23 11:17:39 +09003572 }
3573
3574 apex_key {
3575 name: "myapex.key",
3576 public_key: "testkey.avbpubkey",
3577 private_key: "testkey.pem",
3578 }
3579
Jooyung Han31c470b2019-10-18 16:26:59 +09003580 vndk_prebuilt_shared {
3581 name: "libvndk27",
3582 version: "27",
Jooyung Han344d5432019-08-23 11:17:39 +09003583 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003584 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003585 vndk: {
3586 enabled: true,
3587 },
Jooyung Han31c470b2019-10-18 16:26:59 +09003588 target_arch: "arm64",
3589 arch: {
3590 arm: {
3591 srcs: ["libvndk27_arm.so"],
3592 },
3593 arm64: {
3594 srcs: ["libvndk27_arm64.so"],
3595 },
3596 },
Colin Cross2807f002021-03-02 10:15:29 -08003597 apex_available: [ "com.android.vndk.v27" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003598 }
3599
3600 vndk_prebuilt_shared {
3601 name: "libvndk27",
3602 version: "27",
3603 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003604 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003605 vndk: {
3606 enabled: true,
3607 },
Jooyung Han31c470b2019-10-18 16:26:59 +09003608 target_arch: "x86_64",
3609 arch: {
3610 x86: {
3611 srcs: ["libvndk27_x86.so"],
3612 },
3613 x86_64: {
3614 srcs: ["libvndk27_x86_64.so"],
3615 },
3616 },
Jooyung Han39edb6c2019-11-06 16:53:07 +09003617 }
3618 `+vndkLibrariesTxtFiles("27"),
3619 withFiles(map[string][]byte{
3620 "libvndk27_arm.so": nil,
3621 "libvndk27_arm64.so": nil,
3622 "libvndk27_x86.so": nil,
3623 "libvndk27_x86_64.so": nil,
3624 }))
Jooyung Han344d5432019-08-23 11:17:39 +09003625
Colin Cross2807f002021-03-02 10:15:29 -08003626 ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003627 "lib/libvndk27_arm.so",
3628 "lib64/libvndk27_arm64.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003629 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003630 })
Jooyung Han344d5432019-08-23 11:17:39 +09003631}
3632
Jooyung Han90eee022019-10-01 20:02:42 +09003633func TestVndkApexNameRule(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003634 ctx := testApex(t, `
Jooyung Han90eee022019-10-01 20:02:42 +09003635 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003636 name: "com.android.vndk.current",
Jooyung Han90eee022019-10-01 20:02:42 +09003637 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003638 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003639 updatable: false,
Jooyung Han90eee022019-10-01 20:02:42 +09003640 }
3641 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003642 name: "com.android.vndk.v28",
Jooyung Han90eee022019-10-01 20:02:42 +09003643 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003644 file_contexts: ":myapex-file_contexts",
Jooyung Han90eee022019-10-01 20:02:42 +09003645 vndk_version: "28",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003646 updatable: false,
Jooyung Han90eee022019-10-01 20:02:42 +09003647 }
3648 apex_key {
3649 name: "myapex.key",
3650 public_key: "testkey.avbpubkey",
3651 private_key: "testkey.pem",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003652 }`+vndkLibrariesTxtFiles("28", "current"))
Jooyung Han90eee022019-10-01 20:02:42 +09003653
3654 assertApexName := func(expected, moduleName string) {
Jooyung Hana57af4a2020-01-23 05:36:59 +00003655 bundle := ctx.ModuleForTests(moduleName, "android_common_image").Module().(*apexBundle)
Jooyung Han90eee022019-10-01 20:02:42 +09003656 actual := proptools.String(bundle.properties.Apex_name)
3657 if !reflect.DeepEqual(actual, expected) {
3658 t.Errorf("Got '%v', expected '%v'", actual, expected)
3659 }
3660 }
3661
Jiyong Parkf58c46e2021-04-01 21:35:20 +09003662 assertApexName("com.android.vndk.v29", "com.android.vndk.current")
Colin Cross2807f002021-03-02 10:15:29 -08003663 assertApexName("com.android.vndk.v28", "com.android.vndk.v28")
Jooyung Han90eee022019-10-01 20:02:42 +09003664}
3665
Jooyung Han344d5432019-08-23 11:17:39 +09003666func TestVndkApexSkipsNativeBridgeSupportedModules(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003667 ctx := testApex(t, `
Jooyung Han344d5432019-08-23 11:17:39 +09003668 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003669 name: "com.android.vndk.current",
3670 key: "com.android.vndk.current.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003671 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003672 updatable: false,
Jooyung Han344d5432019-08-23 11:17:39 +09003673 }
3674
3675 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003676 name: "com.android.vndk.current.key",
Jooyung Han344d5432019-08-23 11:17:39 +09003677 public_key: "testkey.avbpubkey",
3678 private_key: "testkey.pem",
3679 }
3680
3681 cc_library {
3682 name: "libvndk",
3683 srcs: ["mylib.cpp"],
3684 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003685 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003686 native_bridge_supported: true,
3687 host_supported: true,
3688 vndk: {
3689 enabled: true,
3690 },
3691 system_shared_libs: [],
3692 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003693 apex_available: [ "com.android.vndk.current" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003694 }
Colin Cross2807f002021-03-02 10:15:29 -08003695 `+vndkLibrariesTxtFiles("current"),
3696 withNativeBridgeEnabled)
Jooyung Han344d5432019-08-23 11:17:39 +09003697
Colin Cross2807f002021-03-02 10:15:29 -08003698 ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003699 "lib/libvndk.so",
3700 "lib64/libvndk.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09003701 "lib/libc++.so",
3702 "lib64/libc++.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003703 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003704 })
Jooyung Han344d5432019-08-23 11:17:39 +09003705}
3706
3707func TestVndkApexDoesntSupportNativeBridgeSupported(t *testing.T) {
Colin Cross2807f002021-03-02 10:15:29 -08003708 testApexError(t, `module "com.android.vndk.current" .*: native_bridge_supported: .* doesn't support native bridge binary`, `
Jooyung Han344d5432019-08-23 11:17:39 +09003709 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003710 name: "com.android.vndk.current",
3711 key: "com.android.vndk.current.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003712 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09003713 native_bridge_supported: true,
3714 }
3715
3716 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003717 name: "com.android.vndk.current.key",
Jooyung Han344d5432019-08-23 11:17:39 +09003718 public_key: "testkey.avbpubkey",
3719 private_key: "testkey.pem",
3720 }
3721
3722 cc_library {
3723 name: "libvndk",
3724 srcs: ["mylib.cpp"],
3725 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003726 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003727 native_bridge_supported: true,
3728 host_supported: true,
3729 vndk: {
3730 enabled: true,
3731 },
3732 system_shared_libs: [],
3733 stl: "none",
3734 }
3735 `)
3736}
3737
Jooyung Han31c470b2019-10-18 16:26:59 +09003738func TestVndkApexWithBinder32(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003739 ctx := testApex(t, `
Jooyung Han31c470b2019-10-18 16:26:59 +09003740 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003741 name: "com.android.vndk.v27",
Jooyung Han31c470b2019-10-18 16:26:59 +09003742 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003743 file_contexts: ":myapex-file_contexts",
Jooyung Han31c470b2019-10-18 16:26:59 +09003744 vndk_version: "27",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003745 updatable: false,
Jooyung Han31c470b2019-10-18 16:26:59 +09003746 }
3747
3748 apex_key {
3749 name: "myapex.key",
3750 public_key: "testkey.avbpubkey",
3751 private_key: "testkey.pem",
3752 }
3753
3754 vndk_prebuilt_shared {
3755 name: "libvndk27",
3756 version: "27",
3757 target_arch: "arm",
3758 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003759 product_available: true,
Jooyung Han31c470b2019-10-18 16:26:59 +09003760 vndk: {
3761 enabled: true,
3762 },
3763 arch: {
3764 arm: {
3765 srcs: ["libvndk27.so"],
3766 }
3767 },
3768 }
3769
3770 vndk_prebuilt_shared {
3771 name: "libvndk27",
3772 version: "27",
3773 target_arch: "arm",
3774 binder32bit: true,
3775 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003776 product_available: true,
Jooyung Han31c470b2019-10-18 16:26:59 +09003777 vndk: {
3778 enabled: true,
3779 },
3780 arch: {
3781 arm: {
3782 srcs: ["libvndk27binder32.so"],
3783 }
3784 },
Colin Cross2807f002021-03-02 10:15:29 -08003785 apex_available: [ "com.android.vndk.v27" ],
Jooyung Han31c470b2019-10-18 16:26:59 +09003786 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003787 `+vndkLibrariesTxtFiles("27"),
Jooyung Han31c470b2019-10-18 16:26:59 +09003788 withFiles(map[string][]byte{
3789 "libvndk27.so": nil,
3790 "libvndk27binder32.so": nil,
3791 }),
3792 withBinder32bit,
3793 withTargets(map[android.OsType][]android.Target{
3794 android.Android: []android.Target{
Jooyung Han35155c42020-02-06 17:33:20 +09003795 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
3796 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
Jooyung Han31c470b2019-10-18 16:26:59 +09003797 },
3798 }),
3799 )
3800
Colin Cross2807f002021-03-02 10:15:29 -08003801 ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003802 "lib/libvndk27binder32.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003803 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003804 })
3805}
3806
Jooyung Han45a96772020-06-15 14:59:42 +09003807func TestVndkApexShouldNotProvideNativeLibs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003808 ctx := testApex(t, `
Jooyung Han45a96772020-06-15 14:59:42 +09003809 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003810 name: "com.android.vndk.current",
3811 key: "com.android.vndk.current.key",
Jooyung Han45a96772020-06-15 14:59:42 +09003812 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003813 updatable: false,
Jooyung Han45a96772020-06-15 14:59:42 +09003814 }
3815
3816 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003817 name: "com.android.vndk.current.key",
Jooyung Han45a96772020-06-15 14:59:42 +09003818 public_key: "testkey.avbpubkey",
3819 private_key: "testkey.pem",
3820 }
3821
3822 cc_library {
3823 name: "libz",
3824 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003825 product_available: true,
Jooyung Han45a96772020-06-15 14:59:42 +09003826 vndk: {
3827 enabled: true,
3828 },
3829 stubs: {
3830 symbol_file: "libz.map.txt",
3831 versions: ["30"],
3832 }
3833 }
3834 `+vndkLibrariesTxtFiles("current"), withFiles(map[string][]byte{
3835 "libz.map.txt": nil,
3836 }))
3837
Colin Cross2807f002021-03-02 10:15:29 -08003838 apexManifestRule := ctx.ModuleForTests("com.android.vndk.current", "android_common_image").Rule("apexManifestRule")
Jooyung Han45a96772020-06-15 14:59:42 +09003839 provideNativeLibs := names(apexManifestRule.Args["provideNativeLibs"])
3840 ensureListEmpty(t, provideNativeLibs)
3841}
3842
Jooyung Hane1633032019-08-01 17:41:43 +09003843func TestDependenciesInApexManifest(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003844 ctx := testApex(t, `
Jooyung Hane1633032019-08-01 17:41:43 +09003845 apex {
3846 name: "myapex_nodep",
3847 key: "myapex.key",
3848 native_shared_libs: ["lib_nodep"],
3849 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003850 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003851 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003852 }
3853
3854 apex {
3855 name: "myapex_dep",
3856 key: "myapex.key",
3857 native_shared_libs: ["lib_dep"],
3858 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003859 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003860 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003861 }
3862
3863 apex {
3864 name: "myapex_provider",
3865 key: "myapex.key",
3866 native_shared_libs: ["libfoo"],
3867 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003868 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003869 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003870 }
3871
3872 apex {
3873 name: "myapex_selfcontained",
3874 key: "myapex.key",
3875 native_shared_libs: ["lib_dep", "libfoo"],
3876 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003877 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003878 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003879 }
3880
3881 apex_key {
3882 name: "myapex.key",
3883 public_key: "testkey.avbpubkey",
3884 private_key: "testkey.pem",
3885 }
3886
3887 cc_library {
3888 name: "lib_nodep",
3889 srcs: ["mylib.cpp"],
3890 system_shared_libs: [],
3891 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003892 apex_available: [ "myapex_nodep" ],
Jooyung Hane1633032019-08-01 17:41:43 +09003893 }
3894
3895 cc_library {
3896 name: "lib_dep",
3897 srcs: ["mylib.cpp"],
3898 shared_libs: ["libfoo"],
3899 system_shared_libs: [],
3900 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003901 apex_available: [
3902 "myapex_dep",
3903 "myapex_provider",
3904 "myapex_selfcontained",
3905 ],
Jooyung Hane1633032019-08-01 17:41:43 +09003906 }
3907
3908 cc_library {
3909 name: "libfoo",
3910 srcs: ["mytest.cpp"],
3911 stubs: {
3912 versions: ["1"],
3913 },
3914 system_shared_libs: [],
3915 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003916 apex_available: [
3917 "myapex_provider",
3918 "myapex_selfcontained",
3919 ],
Jooyung Hane1633032019-08-01 17:41:43 +09003920 }
3921 `)
3922
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003923 var apexManifestRule android.TestingBuildParams
Jooyung Hane1633032019-08-01 17:41:43 +09003924 var provideNativeLibs, requireNativeLibs []string
3925
Sundong Ahnabb64432019-10-22 13:58:29 +09003926 apexManifestRule = ctx.ModuleForTests("myapex_nodep", "android_common_myapex_nodep_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003927 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3928 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003929 ensureListEmpty(t, provideNativeLibs)
3930 ensureListEmpty(t, requireNativeLibs)
3931
Sundong Ahnabb64432019-10-22 13:58:29 +09003932 apexManifestRule = ctx.ModuleForTests("myapex_dep", "android_common_myapex_dep_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003933 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3934 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003935 ensureListEmpty(t, provideNativeLibs)
3936 ensureListContains(t, requireNativeLibs, "libfoo.so")
3937
Sundong Ahnabb64432019-10-22 13:58:29 +09003938 apexManifestRule = ctx.ModuleForTests("myapex_provider", "android_common_myapex_provider_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003939 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3940 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003941 ensureListContains(t, provideNativeLibs, "libfoo.so")
3942 ensureListEmpty(t, requireNativeLibs)
3943
Sundong Ahnabb64432019-10-22 13:58:29 +09003944 apexManifestRule = ctx.ModuleForTests("myapex_selfcontained", "android_common_myapex_selfcontained_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003945 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3946 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003947 ensureListContains(t, provideNativeLibs, "libfoo.so")
3948 ensureListEmpty(t, requireNativeLibs)
3949}
3950
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003951func TestApexName(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003952 ctx := testApex(t, `
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003953 apex {
3954 name: "myapex",
3955 key: "myapex.key",
3956 apex_name: "com.android.myapex",
Jiyong Parkdb334862020-02-05 17:19:28 +09003957 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003958 updatable: false,
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003959 }
3960
3961 apex_key {
3962 name: "myapex.key",
3963 public_key: "testkey.avbpubkey",
3964 private_key: "testkey.pem",
3965 }
Jiyong Parkdb334862020-02-05 17:19:28 +09003966
3967 cc_library {
3968 name: "mylib",
3969 srcs: ["mylib.cpp"],
3970 system_shared_libs: [],
3971 stl: "none",
3972 apex_available: [
3973 "//apex_available:platform",
3974 "myapex",
3975 ],
3976 }
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003977 `)
3978
Martin Stjernholmbfffae72021-06-24 14:37:13 +01003979 module := ctx.ModuleForTests("myapex", "android_common_com.android.myapex_image")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003980 apexManifestRule := module.Rule("apexManifestRule")
3981 ensureContains(t, apexManifestRule.Args["opt"], "-v name com.android.myapex")
3982 apexRule := module.Rule("apexRule")
3983 ensureContains(t, apexRule.Args["opt_flags"], "--do_not_check_keyname")
Jiyong Parkdb334862020-02-05 17:19:28 +09003984
Martin Stjernholmbfffae72021-06-24 14:37:13 +01003985 apexBundle := module.Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07003986 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jiyong Parkdb334862020-02-05 17:19:28 +09003987 name := apexBundle.BaseModuleName()
3988 prefix := "TARGET_"
3989 var builder strings.Builder
3990 data.Custom(&builder, name, prefix, "", data)
3991 androidMk := builder.String()
3992 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
3993 ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003994}
3995
Alex Light0851b882019-02-07 13:20:53 -08003996func TestNonTestApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003997 ctx := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08003998 apex {
3999 name: "myapex",
4000 key: "myapex.key",
4001 native_shared_libs: ["mylib_common"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004002 updatable: false,
Alex Light0851b882019-02-07 13:20:53 -08004003 }
4004
4005 apex_key {
4006 name: "myapex.key",
4007 public_key: "testkey.avbpubkey",
4008 private_key: "testkey.pem",
4009 }
4010
4011 cc_library {
4012 name: "mylib_common",
4013 srcs: ["mylib.cpp"],
4014 system_shared_libs: [],
4015 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004016 apex_available: [
4017 "//apex_available:platform",
4018 "myapex",
4019 ],
Alex Light0851b882019-02-07 13:20:53 -08004020 }
4021 `)
4022
Sundong Ahnabb64432019-10-22 13:58:29 +09004023 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Alex Light0851b882019-02-07 13:20:53 -08004024 apexRule := module.Rule("apexRule")
4025 copyCmds := apexRule.Args["copy_commands"]
4026
4027 if apex, ok := module.Module().(*apexBundle); !ok || apex.testApex {
4028 t.Log("Apex was a test apex!")
4029 t.Fail()
4030 }
4031 // Ensure that main rule creates an output
4032 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
4033
4034 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -07004035 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
Alex Light0851b882019-02-07 13:20:53 -08004036
4037 // Ensure that both direct and indirect deps are copied into apex
4038 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
4039
Colin Cross7113d202019-11-20 16:39:12 -08004040 // Ensure that the platform variant ends with _shared
4041 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
Alex Light0851b882019-02-07 13:20:53 -08004042
Colin Cross56a83212020-09-15 18:30:11 -07004043 if !ctx.ModuleForTests("mylib_common", "android_arm64_armv8-a_shared_apex10000").Module().(*cc.Module).InAnyApex() {
Alex Light0851b882019-02-07 13:20:53 -08004044 t.Log("Found mylib_common not in any apex!")
4045 t.Fail()
4046 }
4047}
4048
4049func TestTestApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004050 ctx := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08004051 apex_test {
4052 name: "myapex",
4053 key: "myapex.key",
4054 native_shared_libs: ["mylib_common_test"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004055 updatable: false,
Alex Light0851b882019-02-07 13:20:53 -08004056 }
4057
4058 apex_key {
4059 name: "myapex.key",
4060 public_key: "testkey.avbpubkey",
4061 private_key: "testkey.pem",
4062 }
4063
4064 cc_library {
4065 name: "mylib_common_test",
4066 srcs: ["mylib.cpp"],
4067 system_shared_libs: [],
4068 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004069 // TODO: remove //apex_available:platform
4070 apex_available: [
4071 "//apex_available:platform",
4072 "myapex",
4073 ],
Alex Light0851b882019-02-07 13:20:53 -08004074 }
4075 `)
4076
Sundong Ahnabb64432019-10-22 13:58:29 +09004077 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Alex Light0851b882019-02-07 13:20:53 -08004078 apexRule := module.Rule("apexRule")
4079 copyCmds := apexRule.Args["copy_commands"]
4080
4081 if apex, ok := module.Module().(*apexBundle); !ok || !apex.testApex {
4082 t.Log("Apex was not a test apex!")
4083 t.Fail()
4084 }
4085 // Ensure that main rule creates an output
4086 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
4087
4088 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -07004089 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared_apex10000")
Alex Light0851b882019-02-07 13:20:53 -08004090
4091 // Ensure that both direct and indirect deps are copied into apex
4092 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common_test.so")
4093
Colin Cross7113d202019-11-20 16:39:12 -08004094 // Ensure that the platform variant ends with _shared
4095 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared")
Alex Light0851b882019-02-07 13:20:53 -08004096}
4097
Alex Light9670d332019-01-29 18:07:33 -08004098func TestApexWithTarget(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004099 ctx := testApex(t, `
Alex Light9670d332019-01-29 18:07:33 -08004100 apex {
4101 name: "myapex",
4102 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004103 updatable: false,
Alex Light9670d332019-01-29 18:07:33 -08004104 multilib: {
4105 first: {
4106 native_shared_libs: ["mylib_common"],
4107 }
4108 },
4109 target: {
4110 android: {
4111 multilib: {
4112 first: {
4113 native_shared_libs: ["mylib"],
4114 }
4115 }
4116 },
4117 host: {
4118 multilib: {
4119 first: {
4120 native_shared_libs: ["mylib2"],
4121 }
4122 }
4123 }
4124 }
4125 }
4126
4127 apex_key {
4128 name: "myapex.key",
4129 public_key: "testkey.avbpubkey",
4130 private_key: "testkey.pem",
4131 }
4132
4133 cc_library {
4134 name: "mylib",
4135 srcs: ["mylib.cpp"],
4136 system_shared_libs: [],
4137 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004138 // TODO: remove //apex_available:platform
4139 apex_available: [
4140 "//apex_available:platform",
4141 "myapex",
4142 ],
Alex Light9670d332019-01-29 18:07:33 -08004143 }
4144
4145 cc_library {
4146 name: "mylib_common",
4147 srcs: ["mylib.cpp"],
4148 system_shared_libs: [],
4149 stl: "none",
4150 compile_multilib: "first",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004151 // TODO: remove //apex_available:platform
4152 apex_available: [
4153 "//apex_available:platform",
4154 "myapex",
4155 ],
Alex Light9670d332019-01-29 18:07:33 -08004156 }
4157
4158 cc_library {
4159 name: "mylib2",
4160 srcs: ["mylib.cpp"],
4161 system_shared_libs: [],
4162 stl: "none",
4163 compile_multilib: "first",
4164 }
4165 `)
4166
Sundong Ahnabb64432019-10-22 13:58:29 +09004167 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Alex Light9670d332019-01-29 18:07:33 -08004168 copyCmds := apexRule.Args["copy_commands"]
4169
4170 // Ensure that main rule creates an output
4171 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
4172
4173 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -07004174 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
4175 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
4176 ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
Alex Light9670d332019-01-29 18:07:33 -08004177
4178 // Ensure that both direct and indirect deps are copied into apex
4179 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
4180 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
4181 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
4182
Colin Cross7113d202019-11-20 16:39:12 -08004183 // Ensure that the platform variant ends with _shared
4184 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
4185 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
4186 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
Alex Light9670d332019-01-29 18:07:33 -08004187}
Jiyong Park04480cf2019-02-06 00:16:29 +09004188
Jiyong Park59140302020-12-14 18:44:04 +09004189func TestApexWithArch(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004190 ctx := testApex(t, `
Jiyong Park59140302020-12-14 18:44:04 +09004191 apex {
4192 name: "myapex",
4193 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004194 updatable: false,
Jiyong Park59140302020-12-14 18:44:04 +09004195 arch: {
4196 arm64: {
4197 native_shared_libs: ["mylib.arm64"],
4198 },
4199 x86_64: {
4200 native_shared_libs: ["mylib.x64"],
4201 },
4202 }
4203 }
4204
4205 apex_key {
4206 name: "myapex.key",
4207 public_key: "testkey.avbpubkey",
4208 private_key: "testkey.pem",
4209 }
4210
4211 cc_library {
4212 name: "mylib.arm64",
4213 srcs: ["mylib.cpp"],
4214 system_shared_libs: [],
4215 stl: "none",
4216 // TODO: remove //apex_available:platform
4217 apex_available: [
4218 "//apex_available:platform",
4219 "myapex",
4220 ],
4221 }
4222
4223 cc_library {
4224 name: "mylib.x64",
4225 srcs: ["mylib.cpp"],
4226 system_shared_libs: [],
4227 stl: "none",
4228 // TODO: remove //apex_available:platform
4229 apex_available: [
4230 "//apex_available:platform",
4231 "myapex",
4232 ],
4233 }
4234 `)
4235
4236 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
4237 copyCmds := apexRule.Args["copy_commands"]
4238
4239 // Ensure that apex variant is created for the direct dep
4240 ensureListContains(t, ctx.ModuleVariantsForTests("mylib.arm64"), "android_arm64_armv8-a_shared_apex10000")
4241 ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib.x64"), "android_arm64_armv8-a_shared_apex10000")
4242
4243 // Ensure that both direct and indirect deps are copied into apex
4244 ensureContains(t, copyCmds, "image.apex/lib64/mylib.arm64.so")
4245 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib.x64.so")
4246}
4247
Jiyong Park04480cf2019-02-06 00:16:29 +09004248func TestApexWithShBinary(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004249 ctx := testApex(t, `
Jiyong Park04480cf2019-02-06 00:16:29 +09004250 apex {
4251 name: "myapex",
4252 key: "myapex.key",
Sundong Ahn80c04892021-11-23 00:57:19 +00004253 sh_binaries: ["myscript"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004254 updatable: false,
Jiyong Park04480cf2019-02-06 00:16:29 +09004255 }
4256
4257 apex_key {
4258 name: "myapex.key",
4259 public_key: "testkey.avbpubkey",
4260 private_key: "testkey.pem",
4261 }
4262
4263 sh_binary {
4264 name: "myscript",
4265 src: "mylib.cpp",
4266 filename: "myscript.sh",
4267 sub_dir: "script",
4268 }
4269 `)
4270
Sundong Ahnabb64432019-10-22 13:58:29 +09004271 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park04480cf2019-02-06 00:16:29 +09004272 copyCmds := apexRule.Args["copy_commands"]
4273
4274 ensureContains(t, copyCmds, "image.apex/bin/script/myscript.sh")
4275}
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004276
Jooyung Han91df2082019-11-20 01:49:42 +09004277func TestApexInVariousPartition(t *testing.T) {
4278 testcases := []struct {
4279 propName, parition, flattenedPartition string
4280 }{
4281 {"", "system", "system_ext"},
4282 {"product_specific: true", "product", "product"},
4283 {"soc_specific: true", "vendor", "vendor"},
4284 {"proprietary: true", "vendor", "vendor"},
4285 {"vendor: true", "vendor", "vendor"},
4286 {"system_ext_specific: true", "system_ext", "system_ext"},
4287 }
4288 for _, tc := range testcases {
4289 t.Run(tc.propName+":"+tc.parition, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004290 ctx := testApex(t, `
Jooyung Han91df2082019-11-20 01:49:42 +09004291 apex {
4292 name: "myapex",
4293 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004294 updatable: false,
Jooyung Han91df2082019-11-20 01:49:42 +09004295 `+tc.propName+`
4296 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004297
Jooyung Han91df2082019-11-20 01:49:42 +09004298 apex_key {
4299 name: "myapex.key",
4300 public_key: "testkey.avbpubkey",
4301 private_key: "testkey.pem",
4302 }
4303 `)
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004304
Jooyung Han91df2082019-11-20 01:49:42 +09004305 apex := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Paul Duffin37ba3442021-03-29 00:21:08 +01004306 expected := "out/soong/target/product/test_device/" + tc.parition + "/apex"
4307 actual := apex.installDir.RelativeToTop().String()
Jooyung Han91df2082019-11-20 01:49:42 +09004308 if actual != expected {
4309 t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
4310 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004311
Jooyung Han91df2082019-11-20 01:49:42 +09004312 flattened := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
Paul Duffin37ba3442021-03-29 00:21:08 +01004313 expected = "out/soong/target/product/test_device/" + tc.flattenedPartition + "/apex"
4314 actual = flattened.installDir.RelativeToTop().String()
Jooyung Han91df2082019-11-20 01:49:42 +09004315 if actual != expected {
4316 t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
4317 }
4318 })
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004319 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004320}
Jiyong Park67882562019-03-21 01:11:21 +09004321
Jooyung Han580eb4f2020-06-24 19:33:06 +09004322func TestFileContexts_FindInDefaultLocationIfNotSet(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004323 ctx := testApex(t, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004324 apex {
4325 name: "myapex",
4326 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004327 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004328 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004329
Jooyung Han580eb4f2020-06-24 19:33:06 +09004330 apex_key {
4331 name: "myapex.key",
4332 public_key: "testkey.avbpubkey",
4333 private_key: "testkey.pem",
4334 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004335 `)
4336 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Han580eb4f2020-06-24 19:33:06 +09004337 rule := module.Output("file_contexts")
4338 ensureContains(t, rule.RuleParams.Command, "cat system/sepolicy/apex/myapex-file_contexts")
4339}
Jooyung Han54aca7b2019-11-20 02:26:02 +09004340
Jooyung Han580eb4f2020-06-24 19:33:06 +09004341func TestFileContexts_ShouldBeUnderSystemSepolicyForSystemApexes(t *testing.T) {
Jooyung Han54aca7b2019-11-20 02:26:02 +09004342 testApexError(t, `"myapex" .*: file_contexts: should be under system/sepolicy`, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004343 apex {
4344 name: "myapex",
4345 key: "myapex.key",
4346 file_contexts: "my_own_file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004347 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004348 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004349
Jooyung Han580eb4f2020-06-24 19:33:06 +09004350 apex_key {
4351 name: "myapex.key",
4352 public_key: "testkey.avbpubkey",
4353 private_key: "testkey.pem",
4354 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004355 `, withFiles(map[string][]byte{
4356 "my_own_file_contexts": nil,
4357 }))
Jooyung Han580eb4f2020-06-24 19:33:06 +09004358}
Jooyung Han54aca7b2019-11-20 02:26:02 +09004359
Jooyung Han580eb4f2020-06-24 19:33:06 +09004360func TestFileContexts_ProductSpecificApexes(t *testing.T) {
Jooyung Han54aca7b2019-11-20 02:26:02 +09004361 testApexError(t, `"myapex" .*: file_contexts: cannot find`, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004362 apex {
4363 name: "myapex",
4364 key: "myapex.key",
4365 product_specific: true,
4366 file_contexts: "product_specific_file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004367 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004368 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004369
Jooyung Han580eb4f2020-06-24 19:33:06 +09004370 apex_key {
4371 name: "myapex.key",
4372 public_key: "testkey.avbpubkey",
4373 private_key: "testkey.pem",
4374 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004375 `)
4376
Colin Cross1c460562021-02-16 17:55:47 -08004377 ctx := testApex(t, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004378 apex {
4379 name: "myapex",
4380 key: "myapex.key",
4381 product_specific: true,
4382 file_contexts: "product_specific_file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004383 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004384 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004385
Jooyung Han580eb4f2020-06-24 19:33:06 +09004386 apex_key {
4387 name: "myapex.key",
4388 public_key: "testkey.avbpubkey",
4389 private_key: "testkey.pem",
4390 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004391 `, withFiles(map[string][]byte{
4392 "product_specific_file_contexts": nil,
4393 }))
Jooyung Han580eb4f2020-06-24 19:33:06 +09004394 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
4395 rule := module.Output("file_contexts")
4396 ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
4397}
Jooyung Han54aca7b2019-11-20 02:26:02 +09004398
Jooyung Han580eb4f2020-06-24 19:33:06 +09004399func TestFileContexts_SetViaFileGroup(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004400 ctx := testApex(t, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004401 apex {
4402 name: "myapex",
4403 key: "myapex.key",
4404 product_specific: true,
4405 file_contexts: ":my-file-contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004406 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004407 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004408
Jooyung Han580eb4f2020-06-24 19:33:06 +09004409 apex_key {
4410 name: "myapex.key",
4411 public_key: "testkey.avbpubkey",
4412 private_key: "testkey.pem",
4413 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004414
Jooyung Han580eb4f2020-06-24 19:33:06 +09004415 filegroup {
4416 name: "my-file-contexts",
4417 srcs: ["product_specific_file_contexts"],
4418 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004419 `, withFiles(map[string][]byte{
4420 "product_specific_file_contexts": nil,
4421 }))
Jooyung Han580eb4f2020-06-24 19:33:06 +09004422 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
4423 rule := module.Output("file_contexts")
4424 ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
Jooyung Han54aca7b2019-11-20 02:26:02 +09004425}
4426
Jiyong Park67882562019-03-21 01:11:21 +09004427func TestApexKeyFromOtherModule(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004428 ctx := testApex(t, `
Jiyong Park67882562019-03-21 01:11:21 +09004429 apex_key {
4430 name: "myapex.key",
4431 public_key: ":my.avbpubkey",
4432 private_key: ":my.pem",
4433 product_specific: true,
4434 }
4435
4436 filegroup {
4437 name: "my.avbpubkey",
4438 srcs: ["testkey2.avbpubkey"],
4439 }
4440
4441 filegroup {
4442 name: "my.pem",
4443 srcs: ["testkey2.pem"],
4444 }
4445 `)
4446
4447 apex_key := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
4448 expected_pubkey := "testkey2.avbpubkey"
Jaewoong Jung18aefc12020-12-21 09:11:10 -08004449 actual_pubkey := apex_key.publicKeyFile.String()
Jiyong Park67882562019-03-21 01:11:21 +09004450 if actual_pubkey != expected_pubkey {
4451 t.Errorf("wrong public key path. expected %q. actual %q", expected_pubkey, actual_pubkey)
4452 }
4453 expected_privkey := "testkey2.pem"
Jaewoong Jung18aefc12020-12-21 09:11:10 -08004454 actual_privkey := apex_key.privateKeyFile.String()
Jiyong Park67882562019-03-21 01:11:21 +09004455 if actual_privkey != expected_privkey {
4456 t.Errorf("wrong private key path. expected %q. actual %q", expected_privkey, actual_privkey)
4457 }
4458}
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004459
4460func TestPrebuilt(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004461 ctx := testApex(t, `
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004462 prebuilt_apex {
4463 name: "myapex",
Jiyong Parkc95714e2019-03-29 14:23:10 +09004464 arch: {
4465 arm64: {
4466 src: "myapex-arm64.apex",
4467 },
4468 arm: {
4469 src: "myapex-arm.apex",
4470 },
4471 },
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004472 }
4473 `)
4474
Paul Duffin6717d882021-06-15 19:09:41 +01004475 prebuilt := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt)
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004476
Jiyong Parkc95714e2019-03-29 14:23:10 +09004477 expectedInput := "myapex-arm64.apex"
4478 if prebuilt.inputApex.String() != expectedInput {
4479 t.Errorf("inputApex invalid. expected: %q, actual: %q", expectedInput, prebuilt.inputApex.String())
4480 }
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004481}
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004482
Paul Duffinc0609c62021-03-01 17:27:16 +00004483func TestPrebuiltMissingSrc(t *testing.T) {
Paul Duffin6717d882021-06-15 19:09:41 +01004484 testApexError(t, `module "myapex" variant "android_common_myapex".*: prebuilt_apex does not support "arm64_armv8-a"`, `
Paul Duffinc0609c62021-03-01 17:27:16 +00004485 prebuilt_apex {
4486 name: "myapex",
4487 }
4488 `)
4489}
4490
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004491func TestPrebuiltFilenameOverride(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004492 ctx := testApex(t, `
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004493 prebuilt_apex {
4494 name: "myapex",
4495 src: "myapex-arm.apex",
4496 filename: "notmyapex.apex",
4497 }
4498 `)
4499
Paul Duffin6717d882021-06-15 19:09:41 +01004500 p := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt)
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004501
4502 expected := "notmyapex.apex"
4503 if p.installFilename != expected {
4504 t.Errorf("installFilename invalid. expected: %q, actual: %q", expected, p.installFilename)
4505 }
4506}
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07004507
Samiul Islam7c02e262021-09-08 17:48:28 +01004508func TestApexSetFilenameOverride(t *testing.T) {
4509 testApex(t, `
4510 apex_set {
4511 name: "com.company.android.myapex",
4512 apex_name: "com.android.myapex",
4513 set: "company-myapex.apks",
4514 filename: "com.company.android.myapex.apex"
4515 }
4516 `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
4517
4518 testApex(t, `
4519 apex_set {
4520 name: "com.company.android.myapex",
4521 apex_name: "com.android.myapex",
4522 set: "company-myapex.apks",
4523 filename: "com.company.android.myapex.capex"
4524 }
4525 `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
4526
4527 testApexError(t, `filename should end in .apex or .capex for apex_set`, `
4528 apex_set {
4529 name: "com.company.android.myapex",
4530 apex_name: "com.android.myapex",
4531 set: "company-myapex.apks",
4532 filename: "some-random-suffix"
4533 }
4534 `)
4535}
4536
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004537func TestPrebuiltOverrides(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004538 ctx := testApex(t, `
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004539 prebuilt_apex {
4540 name: "myapex.prebuilt",
4541 src: "myapex-arm.apex",
4542 overrides: [
4543 "myapex",
4544 ],
4545 }
4546 `)
4547
Paul Duffin6717d882021-06-15 19:09:41 +01004548 p := ctx.ModuleForTests("myapex.prebuilt", "android_common_myapex.prebuilt").Module().(*Prebuilt)
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004549
4550 expected := []string{"myapex"}
Colin Crossaa255532020-07-03 13:18:24 -07004551 actual := android.AndroidMkEntriesForTest(t, ctx, p)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004552 if !reflect.DeepEqual(actual, expected) {
Jiyong Parkb0a012c2019-11-14 17:17:03 +09004553 t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES value '%s', expected '%s'", actual, expected)
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004554 }
4555}
4556
Martin Stjernholmbfffae72021-06-24 14:37:13 +01004557func TestPrebuiltApexName(t *testing.T) {
4558 testApex(t, `
4559 prebuilt_apex {
4560 name: "com.company.android.myapex",
4561 apex_name: "com.android.myapex",
4562 src: "company-myapex-arm.apex",
4563 }
4564 `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
4565
4566 testApex(t, `
4567 apex_set {
4568 name: "com.company.android.myapex",
4569 apex_name: "com.android.myapex",
4570 set: "company-myapex.apks",
4571 }
4572 `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
4573}
4574
4575func TestPrebuiltApexNameWithPlatformBootclasspath(t *testing.T) {
4576 _ = android.GroupFixturePreparers(
4577 java.PrepareForTestWithJavaDefaultModules,
4578 PrepareForTestWithApexBuildComponents,
4579 android.FixtureWithRootAndroidBp(`
4580 platform_bootclasspath {
4581 name: "platform-bootclasspath",
4582 fragments: [
4583 {
4584 apex: "com.android.art",
4585 module: "art-bootclasspath-fragment",
4586 },
4587 ],
4588 }
4589
4590 prebuilt_apex {
4591 name: "com.company.android.art",
4592 apex_name: "com.android.art",
4593 src: "com.company.android.art-arm.apex",
4594 exported_bootclasspath_fragments: ["art-bootclasspath-fragment"],
4595 }
4596
4597 prebuilt_bootclasspath_fragment {
4598 name: "art-bootclasspath-fragment",
satayevabcd5972021-08-06 17:49:46 +01004599 image_name: "art",
Martin Stjernholmbfffae72021-06-24 14:37:13 +01004600 contents: ["core-oj"],
Paul Duffin54e41972021-07-19 13:23:40 +01004601 hidden_api: {
4602 annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
4603 metadata: "my-bootclasspath-fragment/metadata.csv",
4604 index: "my-bootclasspath-fragment/index.csv",
4605 stub_flags: "my-bootclasspath-fragment/stub-flags.csv",
4606 all_flags: "my-bootclasspath-fragment/all-flags.csv",
4607 },
Martin Stjernholmbfffae72021-06-24 14:37:13 +01004608 }
4609
4610 java_import {
4611 name: "core-oj",
4612 jars: ["prebuilt.jar"],
4613 }
4614 `),
4615 ).RunTest(t)
4616}
4617
Paul Duffin092153d2021-01-26 11:42:39 +00004618// These tests verify that the prebuilt_apex/deapexer to java_import wiring allows for the
4619// propagation of paths to dex implementation jars from the former to the latter.
Paul Duffin064b70c2020-11-02 17:32:38 +00004620func TestPrebuiltExportDexImplementationJars(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01004621 transform := android.NullFixturePreparer
Paul Duffin064b70c2020-11-02 17:32:38 +00004622
Paul Duffin89886cb2021-02-05 16:44:03 +00004623 checkDexJarBuildPath := func(t *testing.T, ctx *android.TestContext, name string) {
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01004624 t.Helper()
Paul Duffin064b70c2020-11-02 17:32:38 +00004625 // Make sure the import has been given the correct path to the dex jar.
Colin Crossdcf71b22021-02-01 13:59:03 -08004626 p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency)
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01004627 dexJarBuildPath := p.DexJarBuildPath().PathOrNil()
Paul Duffin39853512021-02-26 11:09:39 +00004628 stem := android.RemoveOptionalPrebuiltPrefix(name)
Jeongik Chad5fe8782021-07-08 01:13:11 +09004629 android.AssertStringEquals(t, "DexJarBuildPath should be apex-related path.",
4630 ".intermediates/myapex.deapexer/android_common/deapexer/javalib/"+stem+".jar",
4631 android.NormalizePathForTesting(dexJarBuildPath))
4632 }
4633
4634 checkDexJarInstallPath := func(t *testing.T, ctx *android.TestContext, name string) {
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01004635 t.Helper()
Jeongik Chad5fe8782021-07-08 01:13:11 +09004636 // Make sure the import has been given the correct path to the dex jar.
4637 p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency)
4638 dexJarBuildPath := p.DexJarInstallPath()
4639 stem := android.RemoveOptionalPrebuiltPrefix(name)
4640 android.AssertStringEquals(t, "DexJarInstallPath should be apex-related path.",
4641 "target/product/test_device/apex/myapex/javalib/"+stem+".jar",
4642 android.NormalizePathForTesting(dexJarBuildPath))
Paul Duffin064b70c2020-11-02 17:32:38 +00004643 }
4644
Paul Duffin39853512021-02-26 11:09:39 +00004645 ensureNoSourceVariant := func(t *testing.T, ctx *android.TestContext, name string) {
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01004646 t.Helper()
Paul Duffin064b70c2020-11-02 17:32:38 +00004647 // Make sure that an apex variant is not created for the source module.
Jeongik Chad5fe8782021-07-08 01:13:11 +09004648 android.AssertArrayString(t, "Check if there is no source variant",
4649 []string{"android_common"},
4650 ctx.ModuleVariantsForTests(name))
Paul Duffin064b70c2020-11-02 17:32:38 +00004651 }
4652
4653 t.Run("prebuilt only", func(t *testing.T) {
4654 bp := `
4655 prebuilt_apex {
4656 name: "myapex",
4657 arch: {
4658 arm64: {
4659 src: "myapex-arm64.apex",
4660 },
4661 arm: {
4662 src: "myapex-arm.apex",
4663 },
4664 },
Paul Duffin39853512021-02-26 11:09:39 +00004665 exported_java_libs: ["libfoo", "libbar"],
Paul Duffin064b70c2020-11-02 17:32:38 +00004666 }
4667
4668 java_import {
4669 name: "libfoo",
4670 jars: ["libfoo.jar"],
4671 }
Paul Duffin39853512021-02-26 11:09:39 +00004672
4673 java_sdk_library_import {
4674 name: "libbar",
4675 public: {
4676 jars: ["libbar.jar"],
4677 },
4678 }
Paul Duffin064b70c2020-11-02 17:32:38 +00004679 `
4680
4681 // Make sure that dexpreopt can access dex implementation files from the prebuilt.
4682 ctx := testDexpreoptWithApexes(t, bp, "", transform)
4683
Martin Stjernholm44825602021-09-17 01:44:12 +01004684 deapexerName := deapexerModuleName("myapex")
4685 android.AssertStringEquals(t, "APEX module name from deapexer name", "myapex", apexModuleName(deapexerName))
4686
Paul Duffinf6932af2021-02-26 18:21:56 +00004687 // Make sure that the deapexer has the correct input APEX.
Martin Stjernholm44825602021-09-17 01:44:12 +01004688 deapexer := ctx.ModuleForTests(deapexerName, "android_common")
Paul Duffinf6932af2021-02-26 18:21:56 +00004689 rule := deapexer.Rule("deapexer")
4690 if expected, actual := []string{"myapex-arm64.apex"}, android.NormalizePathsForTesting(rule.Implicits); !reflect.DeepEqual(expected, actual) {
4691 t.Errorf("expected: %q, found: %q", expected, actual)
4692 }
4693
Paul Duffin0d10c3c2021-03-01 17:09:32 +00004694 // Make sure that the prebuilt_apex has the correct input APEX.
Paul Duffin6717d882021-06-15 19:09:41 +01004695 prebuiltApex := ctx.ModuleForTests("myapex", "android_common_myapex")
Paul Duffin0d10c3c2021-03-01 17:09:32 +00004696 rule = prebuiltApex.Rule("android/soong/android.Cp")
4697 if expected, actual := "myapex-arm64.apex", android.NormalizePathForTesting(rule.Input); !reflect.DeepEqual(expected, actual) {
4698 t.Errorf("expected: %q, found: %q", expected, actual)
4699 }
4700
Paul Duffin89886cb2021-02-05 16:44:03 +00004701 checkDexJarBuildPath(t, ctx, "libfoo")
Jeongik Chad5fe8782021-07-08 01:13:11 +09004702 checkDexJarInstallPath(t, ctx, "libfoo")
Paul Duffin39853512021-02-26 11:09:39 +00004703
4704 checkDexJarBuildPath(t, ctx, "libbar")
Jeongik Chad5fe8782021-07-08 01:13:11 +09004705 checkDexJarInstallPath(t, ctx, "libbar")
Paul Duffin064b70c2020-11-02 17:32:38 +00004706 })
4707
4708 t.Run("prebuilt with source preferred", func(t *testing.T) {
4709
4710 bp := `
4711 prebuilt_apex {
4712 name: "myapex",
4713 arch: {
4714 arm64: {
4715 src: "myapex-arm64.apex",
4716 },
4717 arm: {
4718 src: "myapex-arm.apex",
4719 },
4720 },
Paul Duffin39853512021-02-26 11:09:39 +00004721 exported_java_libs: ["libfoo", "libbar"],
Paul Duffin064b70c2020-11-02 17:32:38 +00004722 }
4723
4724 java_import {
4725 name: "libfoo",
4726 jars: ["libfoo.jar"],
4727 }
4728
4729 java_library {
4730 name: "libfoo",
4731 }
Paul Duffin39853512021-02-26 11:09:39 +00004732
4733 java_sdk_library_import {
4734 name: "libbar",
4735 public: {
4736 jars: ["libbar.jar"],
4737 },
4738 }
4739
4740 java_sdk_library {
4741 name: "libbar",
4742 srcs: ["foo/bar/MyClass.java"],
4743 unsafe_ignore_missing_latest_api: true,
4744 }
Paul Duffin064b70c2020-11-02 17:32:38 +00004745 `
4746
4747 // Make sure that dexpreopt can access dex implementation files from the prebuilt.
4748 ctx := testDexpreoptWithApexes(t, bp, "", transform)
4749
Paul Duffin89886cb2021-02-05 16:44:03 +00004750 checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
Jeongik Chad5fe8782021-07-08 01:13:11 +09004751 checkDexJarInstallPath(t, ctx, "prebuilt_libfoo")
Paul Duffin39853512021-02-26 11:09:39 +00004752 ensureNoSourceVariant(t, ctx, "libfoo")
4753
4754 checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
Jeongik Chad5fe8782021-07-08 01:13:11 +09004755 checkDexJarInstallPath(t, ctx, "prebuilt_libbar")
Paul Duffin39853512021-02-26 11:09:39 +00004756 ensureNoSourceVariant(t, ctx, "libbar")
Paul Duffin064b70c2020-11-02 17:32:38 +00004757 })
4758
4759 t.Run("prebuilt preferred with source", func(t *testing.T) {
4760 bp := `
4761 prebuilt_apex {
4762 name: "myapex",
Paul Duffin064b70c2020-11-02 17:32:38 +00004763 arch: {
4764 arm64: {
4765 src: "myapex-arm64.apex",
4766 },
4767 arm: {
4768 src: "myapex-arm.apex",
4769 },
4770 },
Paul Duffin39853512021-02-26 11:09:39 +00004771 exported_java_libs: ["libfoo", "libbar"],
Paul Duffin064b70c2020-11-02 17:32:38 +00004772 }
4773
4774 java_import {
4775 name: "libfoo",
Paul Duffin092153d2021-01-26 11:42:39 +00004776 prefer: true,
Paul Duffin064b70c2020-11-02 17:32:38 +00004777 jars: ["libfoo.jar"],
4778 }
4779
4780 java_library {
4781 name: "libfoo",
4782 }
Paul Duffin39853512021-02-26 11:09:39 +00004783
4784 java_sdk_library_import {
4785 name: "libbar",
4786 prefer: true,
4787 public: {
4788 jars: ["libbar.jar"],
4789 },
4790 }
4791
4792 java_sdk_library {
4793 name: "libbar",
4794 srcs: ["foo/bar/MyClass.java"],
4795 unsafe_ignore_missing_latest_api: true,
4796 }
Paul Duffin064b70c2020-11-02 17:32:38 +00004797 `
4798
4799 // Make sure that dexpreopt can access dex implementation files from the prebuilt.
4800 ctx := testDexpreoptWithApexes(t, bp, "", transform)
4801
Paul Duffin89886cb2021-02-05 16:44:03 +00004802 checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
Jeongik Chad5fe8782021-07-08 01:13:11 +09004803 checkDexJarInstallPath(t, ctx, "prebuilt_libfoo")
Paul Duffin39853512021-02-26 11:09:39 +00004804 ensureNoSourceVariant(t, ctx, "libfoo")
4805
4806 checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
Jeongik Chad5fe8782021-07-08 01:13:11 +09004807 checkDexJarInstallPath(t, ctx, "prebuilt_libbar")
Paul Duffin39853512021-02-26 11:09:39 +00004808 ensureNoSourceVariant(t, ctx, "libbar")
Paul Duffin064b70c2020-11-02 17:32:38 +00004809 })
4810}
4811
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004812func TestBootDexJarsFromSourcesAndPrebuilts(t *testing.T) {
Paul Duffinb6f53c02021-05-14 07:52:42 +01004813 preparer := android.GroupFixturePreparers(
satayevabcd5972021-08-06 17:49:46 +01004814 java.FixtureConfigureApexBootJars("myapex:libfoo", "myapex:libbar"),
Paul Duffinb6f53c02021-05-14 07:52:42 +01004815 // Make sure that the frameworks/base/Android.bp file exists as otherwise hidden API encoding
4816 // is disabled.
4817 android.FixtureAddTextFile("frameworks/base/Android.bp", ""),
4818 )
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004819
Paul Duffin37856732021-02-26 14:24:15 +00004820 checkBootDexJarPath := func(t *testing.T, ctx *android.TestContext, stem string, bootDexJarPath string) {
4821 t.Helper()
Paul Duffin7ebebfd2021-04-27 19:36:57 +01004822 s := ctx.ModuleForTests("platform-bootclasspath", "android_common")
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004823 foundLibfooJar := false
Paul Duffin37856732021-02-26 14:24:15 +00004824 base := stem + ".jar"
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004825 for _, output := range s.AllOutputs() {
Paul Duffin37856732021-02-26 14:24:15 +00004826 if filepath.Base(output) == base {
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004827 foundLibfooJar = true
4828 buildRule := s.Output(output)
Paul Duffin55607122021-03-30 23:32:51 +01004829 android.AssertStringEquals(t, "boot dex jar path", bootDexJarPath, buildRule.Input.String())
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004830 }
4831 }
4832 if !foundLibfooJar {
Lukacs T. Berki9f6c24a2021-08-26 15:07:24 +02004833 t.Errorf("Rule for libfoo.jar missing in dex_bootjars singleton outputs %q", android.StringPathsRelativeToTop(ctx.Config().SoongOutDir(), s.AllOutputs()))
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004834 }
4835 }
4836
Paul Duffin40a3f652021-07-19 13:11:24 +01004837 checkHiddenAPIIndexFromClassesInputs := func(t *testing.T, ctx *android.TestContext, expectedIntermediateInputs string) {
Paul Duffin37856732021-02-26 14:24:15 +00004838 t.Helper()
Paul Duffin00b2bfd2021-04-12 17:24:36 +01004839 platformBootclasspath := ctx.ModuleForTests("platform-bootclasspath", "android_common")
Paul Duffind061d402021-06-07 21:36:01 +01004840 var rule android.TestingBuildParams
4841
4842 rule = platformBootclasspath.Output("hiddenapi-monolithic/index-from-classes.csv")
4843 java.CheckHiddenAPIRuleInputs(t, "intermediate index", expectedIntermediateInputs, rule)
Paul Duffin4fd997b2021-02-03 20:06:33 +00004844 }
4845
Paul Duffin40a3f652021-07-19 13:11:24 +01004846 checkHiddenAPIIndexFromFlagsInputs := func(t *testing.T, ctx *android.TestContext, expectedIntermediateInputs string) {
4847 t.Helper()
4848 platformBootclasspath := ctx.ModuleForTests("platform-bootclasspath", "android_common")
4849 var rule android.TestingBuildParams
4850
4851 rule = platformBootclasspath.Output("hiddenapi-index.csv")
4852 java.CheckHiddenAPIRuleInputs(t, "monolithic index", expectedIntermediateInputs, rule)
4853 }
4854
Paul Duffin89f570a2021-06-16 01:42:33 +01004855 fragment := java.ApexVariantReference{
4856 Apex: proptools.StringPtr("myapex"),
4857 Module: proptools.StringPtr("my-bootclasspath-fragment"),
4858 }
4859
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004860 t.Run("prebuilt only", func(t *testing.T) {
4861 bp := `
4862 prebuilt_apex {
4863 name: "myapex",
4864 arch: {
4865 arm64: {
4866 src: "myapex-arm64.apex",
4867 },
4868 arm: {
4869 src: "myapex-arm.apex",
4870 },
4871 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004872 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4873 }
4874
4875 prebuilt_bootclasspath_fragment {
4876 name: "my-bootclasspath-fragment",
4877 contents: ["libfoo", "libbar"],
4878 apex_available: ["myapex"],
Paul Duffin54e41972021-07-19 13:23:40 +01004879 hidden_api: {
4880 annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
4881 metadata: "my-bootclasspath-fragment/metadata.csv",
4882 index: "my-bootclasspath-fragment/index.csv",
Paul Duffin191be3a2021-08-10 16:14:16 +01004883 signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
4884 filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
4885 filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
Paul Duffin54e41972021-07-19 13:23:40 +01004886 },
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004887 }
4888
4889 java_import {
4890 name: "libfoo",
4891 jars: ["libfoo.jar"],
4892 apex_available: ["myapex"],
satayevabcd5972021-08-06 17:49:46 +01004893 permitted_packages: ["foo"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004894 }
Paul Duffin37856732021-02-26 14:24:15 +00004895
4896 java_sdk_library_import {
4897 name: "libbar",
4898 public: {
4899 jars: ["libbar.jar"],
4900 },
4901 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004902 shared_library: false,
satayevabcd5972021-08-06 17:49:46 +01004903 permitted_packages: ["bar"],
Paul Duffin37856732021-02-26 14:24:15 +00004904 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004905 `
4906
Paul Duffin89f570a2021-06-16 01:42:33 +01004907 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01004908 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
4909 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00004910
Paul Duffin537ea3d2021-05-14 10:38:00 +01004911 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin54e41972021-07-19 13:23:40 +01004912 checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
Paul Duffin40a3f652021-07-19 13:11:24 +01004913 checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
Paul Duffin54e41972021-07-19 13:23:40 +01004914 my-bootclasspath-fragment/index.csv
Paul Duffin40a3f652021-07-19 13:11:24 +01004915 out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
4916 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004917 })
4918
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004919 t.Run("apex_set only", func(t *testing.T) {
4920 bp := `
4921 apex_set {
4922 name: "myapex",
4923 set: "myapex.apks",
Paul Duffin89f570a2021-06-16 01:42:33 +01004924 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4925 }
4926
4927 prebuilt_bootclasspath_fragment {
4928 name: "my-bootclasspath-fragment",
4929 contents: ["libfoo", "libbar"],
4930 apex_available: ["myapex"],
Paul Duffin54e41972021-07-19 13:23:40 +01004931 hidden_api: {
4932 annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
4933 metadata: "my-bootclasspath-fragment/metadata.csv",
4934 index: "my-bootclasspath-fragment/index.csv",
Paul Duffin191be3a2021-08-10 16:14:16 +01004935 signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
4936 filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
4937 filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
Paul Duffin54e41972021-07-19 13:23:40 +01004938 },
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004939 }
4940
4941 java_import {
4942 name: "libfoo",
4943 jars: ["libfoo.jar"],
4944 apex_available: ["myapex"],
satayevabcd5972021-08-06 17:49:46 +01004945 permitted_packages: ["foo"],
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004946 }
4947
4948 java_sdk_library_import {
4949 name: "libbar",
4950 public: {
4951 jars: ["libbar.jar"],
4952 },
4953 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004954 shared_library: false,
satayevabcd5972021-08-06 17:49:46 +01004955 permitted_packages: ["bar"],
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004956 }
4957 `
4958
Paul Duffin89f570a2021-06-16 01:42:33 +01004959 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004960 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
4961 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
4962
Paul Duffin537ea3d2021-05-14 10:38:00 +01004963 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin54e41972021-07-19 13:23:40 +01004964 checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
Paul Duffin40a3f652021-07-19 13:11:24 +01004965 checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
Paul Duffin54e41972021-07-19 13:23:40 +01004966 my-bootclasspath-fragment/index.csv
Paul Duffin40a3f652021-07-19 13:11:24 +01004967 out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
4968 `)
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004969 })
4970
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004971 t.Run("prebuilt with source library preferred", func(t *testing.T) {
4972 bp := `
4973 prebuilt_apex {
4974 name: "myapex",
4975 arch: {
4976 arm64: {
4977 src: "myapex-arm64.apex",
4978 },
4979 arm: {
4980 src: "myapex-arm.apex",
4981 },
4982 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004983 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4984 }
4985
4986 prebuilt_bootclasspath_fragment {
4987 name: "my-bootclasspath-fragment",
4988 contents: ["libfoo", "libbar"],
4989 apex_available: ["myapex"],
Paul Duffin54e41972021-07-19 13:23:40 +01004990 hidden_api: {
4991 annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
4992 metadata: "my-bootclasspath-fragment/metadata.csv",
4993 index: "my-bootclasspath-fragment/index.csv",
4994 stub_flags: "my-bootclasspath-fragment/stub-flags.csv",
4995 all_flags: "my-bootclasspath-fragment/all-flags.csv",
4996 },
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004997 }
4998
4999 java_import {
5000 name: "libfoo",
5001 jars: ["libfoo.jar"],
5002 apex_available: ["myapex"],
5003 }
5004
5005 java_library {
5006 name: "libfoo",
5007 srcs: ["foo/bar/MyClass.java"],
5008 apex_available: ["myapex"],
5009 }
Paul Duffin37856732021-02-26 14:24:15 +00005010
5011 java_sdk_library_import {
5012 name: "libbar",
5013 public: {
5014 jars: ["libbar.jar"],
5015 },
5016 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01005017 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00005018 }
5019
5020 java_sdk_library {
5021 name: "libbar",
5022 srcs: ["foo/bar/MyClass.java"],
5023 unsafe_ignore_missing_latest_api: true,
5024 apex_available: ["myapex"],
5025 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005026 `
5027
5028 // In this test the source (java_library) libfoo is active since the
5029 // prebuilt (java_import) defaults to prefer:false. However the
5030 // prebuilt_apex module always depends on the prebuilt, and so it doesn't
5031 // find the dex boot jar in it. We either need to disable the source libfoo
5032 // or make the prebuilt libfoo preferred.
Paul Duffin89f570a2021-06-16 01:42:33 +01005033 testDexpreoptWithApexes(t, bp, "module libfoo does not provide a dex boot jar", preparer, fragment)
Spandan Das10ea4bf2021-08-20 19:18:16 +00005034 // dexbootjar check is skipped if AllowMissingDependencies is true
5035 preparerAllowMissingDeps := android.GroupFixturePreparers(
5036 preparer,
5037 android.PrepareForTestWithAllowMissingDependencies,
5038 )
5039 testDexpreoptWithApexes(t, bp, "", preparerAllowMissingDeps, fragment)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005040 })
5041
5042 t.Run("prebuilt library preferred with source", func(t *testing.T) {
5043 bp := `
5044 prebuilt_apex {
5045 name: "myapex",
5046 arch: {
5047 arm64: {
5048 src: "myapex-arm64.apex",
5049 },
5050 arm: {
5051 src: "myapex-arm.apex",
5052 },
5053 },
Paul Duffin89f570a2021-06-16 01:42:33 +01005054 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
5055 }
5056
5057 prebuilt_bootclasspath_fragment {
5058 name: "my-bootclasspath-fragment",
5059 contents: ["libfoo", "libbar"],
5060 apex_available: ["myapex"],
Paul Duffin54e41972021-07-19 13:23:40 +01005061 hidden_api: {
5062 annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
5063 metadata: "my-bootclasspath-fragment/metadata.csv",
5064 index: "my-bootclasspath-fragment/index.csv",
Paul Duffin191be3a2021-08-10 16:14:16 +01005065 signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
5066 filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
5067 filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
Paul Duffin54e41972021-07-19 13:23:40 +01005068 },
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005069 }
5070
5071 java_import {
5072 name: "libfoo",
5073 prefer: true,
5074 jars: ["libfoo.jar"],
5075 apex_available: ["myapex"],
satayevabcd5972021-08-06 17:49:46 +01005076 permitted_packages: ["foo"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005077 }
5078
5079 java_library {
5080 name: "libfoo",
5081 srcs: ["foo/bar/MyClass.java"],
5082 apex_available: ["myapex"],
5083 }
Paul Duffin37856732021-02-26 14:24:15 +00005084
5085 java_sdk_library_import {
5086 name: "libbar",
5087 prefer: true,
5088 public: {
5089 jars: ["libbar.jar"],
5090 },
5091 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01005092 shared_library: false,
satayevabcd5972021-08-06 17:49:46 +01005093 permitted_packages: ["bar"],
Paul Duffin37856732021-02-26 14:24:15 +00005094 }
5095
5096 java_sdk_library {
5097 name: "libbar",
5098 srcs: ["foo/bar/MyClass.java"],
5099 unsafe_ignore_missing_latest_api: true,
5100 apex_available: ["myapex"],
5101 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005102 `
5103
Paul Duffin89f570a2021-06-16 01:42:33 +01005104 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01005105 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
5106 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00005107
Paul Duffin537ea3d2021-05-14 10:38:00 +01005108 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin54e41972021-07-19 13:23:40 +01005109 checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
Paul Duffin40a3f652021-07-19 13:11:24 +01005110 checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
Paul Duffin54e41972021-07-19 13:23:40 +01005111 my-bootclasspath-fragment/index.csv
Paul Duffin40a3f652021-07-19 13:11:24 +01005112 out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
5113 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005114 })
5115
5116 t.Run("prebuilt with source apex preferred", func(t *testing.T) {
5117 bp := `
5118 apex {
5119 name: "myapex",
5120 key: "myapex.key",
Paul Duffin37856732021-02-26 14:24:15 +00005121 java_libs: ["libfoo", "libbar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005122 updatable: false,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005123 }
5124
5125 apex_key {
5126 name: "myapex.key",
5127 public_key: "testkey.avbpubkey",
5128 private_key: "testkey.pem",
5129 }
5130
5131 prebuilt_apex {
5132 name: "myapex",
5133 arch: {
5134 arm64: {
5135 src: "myapex-arm64.apex",
5136 },
5137 arm: {
5138 src: "myapex-arm.apex",
5139 },
5140 },
Paul Duffin89f570a2021-06-16 01:42:33 +01005141 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
5142 }
5143
5144 prebuilt_bootclasspath_fragment {
5145 name: "my-bootclasspath-fragment",
5146 contents: ["libfoo", "libbar"],
5147 apex_available: ["myapex"],
Paul Duffin54e41972021-07-19 13:23:40 +01005148 hidden_api: {
5149 annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
5150 metadata: "my-bootclasspath-fragment/metadata.csv",
5151 index: "my-bootclasspath-fragment/index.csv",
Paul Duffin191be3a2021-08-10 16:14:16 +01005152 signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
5153 filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
5154 filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
Paul Duffin54e41972021-07-19 13:23:40 +01005155 },
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005156 }
5157
5158 java_import {
5159 name: "libfoo",
5160 jars: ["libfoo.jar"],
5161 apex_available: ["myapex"],
5162 }
5163
5164 java_library {
5165 name: "libfoo",
5166 srcs: ["foo/bar/MyClass.java"],
5167 apex_available: ["myapex"],
satayevabcd5972021-08-06 17:49:46 +01005168 permitted_packages: ["foo"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005169 }
Paul Duffin37856732021-02-26 14:24:15 +00005170
5171 java_sdk_library_import {
5172 name: "libbar",
5173 public: {
5174 jars: ["libbar.jar"],
5175 },
5176 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01005177 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00005178 }
5179
5180 java_sdk_library {
5181 name: "libbar",
5182 srcs: ["foo/bar/MyClass.java"],
5183 unsafe_ignore_missing_latest_api: true,
5184 apex_available: ["myapex"],
satayevabcd5972021-08-06 17:49:46 +01005185 permitted_packages: ["bar"],
Paul Duffin37856732021-02-26 14:24:15 +00005186 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005187 `
5188
Paul Duffin89f570a2021-06-16 01:42:33 +01005189 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01005190 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/libfoo/android_common_apex10000/hiddenapi/libfoo.jar")
5191 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/libbar/android_common_myapex/hiddenapi/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00005192
Paul Duffin537ea3d2021-05-14 10:38:00 +01005193 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin54e41972021-07-19 13:23:40 +01005194 checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
Paul Duffin40a3f652021-07-19 13:11:24 +01005195 checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
Paul Duffin54e41972021-07-19 13:23:40 +01005196 my-bootclasspath-fragment/index.csv
Paul Duffin40a3f652021-07-19 13:11:24 +01005197 out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
5198 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005199 })
5200
5201 t.Run("prebuilt preferred with source apex disabled", func(t *testing.T) {
5202 bp := `
5203 apex {
5204 name: "myapex",
5205 enabled: false,
5206 key: "myapex.key",
Paul Duffin8f146b92021-04-12 17:24:18 +01005207 java_libs: ["libfoo", "libbar"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005208 }
5209
5210 apex_key {
5211 name: "myapex.key",
5212 public_key: "testkey.avbpubkey",
5213 private_key: "testkey.pem",
5214 }
5215
5216 prebuilt_apex {
5217 name: "myapex",
5218 arch: {
5219 arm64: {
5220 src: "myapex-arm64.apex",
5221 },
5222 arm: {
5223 src: "myapex-arm.apex",
5224 },
5225 },
Paul Duffin89f570a2021-06-16 01:42:33 +01005226 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
5227 }
5228
5229 prebuilt_bootclasspath_fragment {
5230 name: "my-bootclasspath-fragment",
5231 contents: ["libfoo", "libbar"],
5232 apex_available: ["myapex"],
Paul Duffin54e41972021-07-19 13:23:40 +01005233 hidden_api: {
5234 annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
5235 metadata: "my-bootclasspath-fragment/metadata.csv",
5236 index: "my-bootclasspath-fragment/index.csv",
Paul Duffin191be3a2021-08-10 16:14:16 +01005237 signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
5238 filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
5239 filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
Paul Duffin54e41972021-07-19 13:23:40 +01005240 },
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005241 }
5242
5243 java_import {
5244 name: "libfoo",
5245 prefer: true,
5246 jars: ["libfoo.jar"],
5247 apex_available: ["myapex"],
satayevabcd5972021-08-06 17:49:46 +01005248 permitted_packages: ["foo"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005249 }
5250
5251 java_library {
5252 name: "libfoo",
5253 srcs: ["foo/bar/MyClass.java"],
5254 apex_available: ["myapex"],
5255 }
Paul Duffin37856732021-02-26 14:24:15 +00005256
5257 java_sdk_library_import {
5258 name: "libbar",
5259 prefer: true,
5260 public: {
5261 jars: ["libbar.jar"],
5262 },
5263 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01005264 shared_library: false,
satayevabcd5972021-08-06 17:49:46 +01005265 permitted_packages: ["bar"],
Paul Duffin37856732021-02-26 14:24:15 +00005266 }
5267
5268 java_sdk_library {
5269 name: "libbar",
5270 srcs: ["foo/bar/MyClass.java"],
5271 unsafe_ignore_missing_latest_api: true,
5272 apex_available: ["myapex"],
5273 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005274 `
5275
Paul Duffin89f570a2021-06-16 01:42:33 +01005276 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01005277 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
5278 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00005279
Paul Duffin537ea3d2021-05-14 10:38:00 +01005280 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin54e41972021-07-19 13:23:40 +01005281 checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
Paul Duffin40a3f652021-07-19 13:11:24 +01005282 checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
Paul Duffin54e41972021-07-19 13:23:40 +01005283 my-bootclasspath-fragment/index.csv
Paul Duffin40a3f652021-07-19 13:11:24 +01005284 out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
5285 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005286 })
5287}
5288
Roland Levillain630846d2019-06-26 12:48:34 +01005289func TestApexWithTests(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005290 ctx := testApex(t, `
Roland Levillain630846d2019-06-26 12:48:34 +01005291 apex_test {
5292 name: "myapex",
5293 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005294 updatable: false,
Roland Levillain630846d2019-06-26 12:48:34 +01005295 tests: [
5296 "mytest",
Roland Levillain9b5fde92019-06-28 15:41:19 +01005297 "mytests",
Roland Levillain630846d2019-06-26 12:48:34 +01005298 ],
5299 }
5300
5301 apex_key {
5302 name: "myapex.key",
5303 public_key: "testkey.avbpubkey",
5304 private_key: "testkey.pem",
5305 }
5306
Liz Kammer1c14a212020-05-12 15:26:55 -07005307 filegroup {
5308 name: "fg",
5309 srcs: [
5310 "baz",
5311 "bar/baz"
5312 ],
5313 }
5314
Roland Levillain630846d2019-06-26 12:48:34 +01005315 cc_test {
5316 name: "mytest",
5317 gtest: false,
5318 srcs: ["mytest.cpp"],
5319 relative_install_path: "test",
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005320 shared_libs: ["mylib"],
Roland Levillain630846d2019-06-26 12:48:34 +01005321 system_shared_libs: [],
5322 static_executable: true,
5323 stl: "none",
Liz Kammer1c14a212020-05-12 15:26:55 -07005324 data: [":fg"],
Roland Levillain630846d2019-06-26 12:48:34 +01005325 }
Roland Levillain9b5fde92019-06-28 15:41:19 +01005326
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005327 cc_library {
5328 name: "mylib",
5329 srcs: ["mylib.cpp"],
5330 system_shared_libs: [],
5331 stl: "none",
5332 }
5333
Liz Kammer5bd365f2020-05-27 15:15:11 -07005334 filegroup {
5335 name: "fg2",
5336 srcs: [
5337 "testdata/baz"
5338 ],
5339 }
5340
Roland Levillain9b5fde92019-06-28 15:41:19 +01005341 cc_test {
5342 name: "mytests",
5343 gtest: false,
5344 srcs: [
5345 "mytest1.cpp",
5346 "mytest2.cpp",
5347 "mytest3.cpp",
5348 ],
5349 test_per_src: true,
5350 relative_install_path: "test",
5351 system_shared_libs: [],
5352 static_executable: true,
5353 stl: "none",
Liz Kammer5bd365f2020-05-27 15:15:11 -07005354 data: [
5355 ":fg",
5356 ":fg2",
5357 ],
Roland Levillain9b5fde92019-06-28 15:41:19 +01005358 }
Roland Levillain630846d2019-06-26 12:48:34 +01005359 `)
5360
Sundong Ahnabb64432019-10-22 13:58:29 +09005361 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Roland Levillain630846d2019-06-26 12:48:34 +01005362 copyCmds := apexRule.Args["copy_commands"]
5363
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005364 // Ensure that test dep (and their transitive dependencies) are copied into apex.
Roland Levillain630846d2019-06-26 12:48:34 +01005365 ensureContains(t, copyCmds, "image.apex/bin/test/mytest")
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005366 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Roland Levillain9b5fde92019-06-28 15:41:19 +01005367
Liz Kammer1c14a212020-05-12 15:26:55 -07005368 //Ensure that test data are copied into apex.
5369 ensureContains(t, copyCmds, "image.apex/bin/test/baz")
5370 ensureContains(t, copyCmds, "image.apex/bin/test/bar/baz")
5371
Roland Levillain9b5fde92019-06-28 15:41:19 +01005372 // Ensure that test deps built with `test_per_src` are copied into apex.
5373 ensureContains(t, copyCmds, "image.apex/bin/test/mytest1")
5374 ensureContains(t, copyCmds, "image.apex/bin/test/mytest2")
5375 ensureContains(t, copyCmds, "image.apex/bin/test/mytest3")
Roland Levillainf89cd092019-07-29 16:22:59 +01005376
5377 // Ensure the module is correctly translated.
Liz Kammer81faaaf2020-05-20 09:57:08 -07005378 bundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07005379 data := android.AndroidMkDataForTest(t, ctx, bundle)
Liz Kammer81faaaf2020-05-20 09:57:08 -07005380 name := bundle.BaseModuleName()
Roland Levillainf89cd092019-07-29 16:22:59 +01005381 prefix := "TARGET_"
5382 var builder strings.Builder
5383 data.Custom(&builder, name, prefix, "", data)
5384 androidMk := builder.String()
Jooyung Han31c470b2019-10-18 16:26:59 +09005385 ensureContains(t, androidMk, "LOCAL_MODULE := mytest.myapex\n")
5386 ensureContains(t, androidMk, "LOCAL_MODULE := mytest1.myapex\n")
5387 ensureContains(t, androidMk, "LOCAL_MODULE := mytest2.myapex\n")
5388 ensureContains(t, androidMk, "LOCAL_MODULE := mytest3.myapex\n")
Jooyung Han214bf372019-11-12 13:03:50 +09005389 ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex\n")
Jooyung Han31c470b2019-10-18 16:26:59 +09005390 ensureContains(t, androidMk, "LOCAL_MODULE := apex_pubkey.myapex\n")
Roland Levillainf89cd092019-07-29 16:22:59 +01005391 ensureContains(t, androidMk, "LOCAL_MODULE := myapex\n")
Liz Kammer81faaaf2020-05-20 09:57:08 -07005392
5393 flatBundle := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07005394 data = android.AndroidMkDataForTest(t, ctx, flatBundle)
Liz Kammer81faaaf2020-05-20 09:57:08 -07005395 data.Custom(&builder, name, prefix, "", data)
5396 flatAndroidMk := builder.String()
Liz Kammer5bd365f2020-05-27 15:15:11 -07005397 ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :baz :bar/baz\n")
5398 ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :testdata/baz\n")
Roland Levillain630846d2019-06-26 12:48:34 +01005399}
5400
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005401func TestInstallExtraFlattenedApexes(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005402 ctx := testApex(t, `
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005403 apex {
5404 name: "myapex",
5405 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005406 updatable: false,
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005407 }
5408 apex_key {
5409 name: "myapex.key",
5410 public_key: "testkey.avbpubkey",
5411 private_key: "testkey.pem",
5412 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00005413 `,
5414 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
5415 variables.InstallExtraFlattenedApexes = proptools.BoolPtr(true)
5416 }),
5417 )
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005418 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Jiyong Park83dc74b2020-01-14 18:38:44 +09005419 ensureListContains(t, ab.requiredDeps, "myapex.flattened")
Colin Crossaa255532020-07-03 13:18:24 -07005420 mk := android.AndroidMkDataForTest(t, ctx, ab)
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005421 var builder strings.Builder
5422 mk.Custom(&builder, ab.Name(), "TARGET_", "", mk)
5423 androidMk := builder.String()
5424 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += myapex.flattened")
5425}
5426
Jooyung Hand48f3c32019-08-23 11:18:57 +09005427func TestErrorsIfDepsAreNotEnabled(t *testing.T) {
5428 testApexError(t, `module "myapex" .* depends on disabled module "libfoo"`, `
5429 apex {
5430 name: "myapex",
5431 key: "myapex.key",
5432 native_shared_libs: ["libfoo"],
5433 }
5434
5435 apex_key {
5436 name: "myapex.key",
5437 public_key: "testkey.avbpubkey",
5438 private_key: "testkey.pem",
5439 }
5440
5441 cc_library {
5442 name: "libfoo",
5443 stl: "none",
5444 system_shared_libs: [],
5445 enabled: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09005446 apex_available: ["myapex"],
Jooyung Hand48f3c32019-08-23 11:18:57 +09005447 }
5448 `)
5449 testApexError(t, `module "myapex" .* depends on disabled module "myjar"`, `
5450 apex {
5451 name: "myapex",
5452 key: "myapex.key",
5453 java_libs: ["myjar"],
5454 }
5455
5456 apex_key {
5457 name: "myapex.key",
5458 public_key: "testkey.avbpubkey",
5459 private_key: "testkey.pem",
5460 }
5461
5462 java_library {
5463 name: "myjar",
5464 srcs: ["foo/bar/MyClass.java"],
5465 sdk_version: "none",
5466 system_modules: "none",
Jooyung Hand48f3c32019-08-23 11:18:57 +09005467 enabled: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09005468 apex_available: ["myapex"],
Jooyung Hand48f3c32019-08-23 11:18:57 +09005469 }
5470 `)
5471}
5472
Bill Peckhama41a6962021-01-11 10:58:54 -08005473func TestApexWithJavaImport(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005474 ctx := testApex(t, `
Bill Peckhama41a6962021-01-11 10:58:54 -08005475 apex {
5476 name: "myapex",
5477 key: "myapex.key",
5478 java_libs: ["myjavaimport"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005479 updatable: false,
Bill Peckhama41a6962021-01-11 10:58:54 -08005480 }
5481
5482 apex_key {
5483 name: "myapex.key",
5484 public_key: "testkey.avbpubkey",
5485 private_key: "testkey.pem",
5486 }
5487
5488 java_import {
5489 name: "myjavaimport",
5490 apex_available: ["myapex"],
5491 jars: ["my.jar"],
5492 compile_dex: true,
5493 }
5494 `)
5495
5496 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
5497 apexRule := module.Rule("apexRule")
5498 copyCmds := apexRule.Args["copy_commands"]
5499 ensureContains(t, copyCmds, "image.apex/javalib/myjavaimport.jar")
5500}
5501
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005502func TestApexWithApps(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005503 ctx := testApex(t, `
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005504 apex {
5505 name: "myapex",
5506 key: "myapex.key",
5507 apps: [
5508 "AppFoo",
Jiyong Parkf7487312019-10-17 12:54:30 +09005509 "AppFooPriv",
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005510 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005511 updatable: false,
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005512 }
5513
5514 apex_key {
5515 name: "myapex.key",
5516 public_key: "testkey.avbpubkey",
5517 private_key: "testkey.pem",
5518 }
5519
5520 android_app {
5521 name: "AppFoo",
5522 srcs: ["foo/bar/MyClass.java"],
Colin Cross094cde42020-02-15 10:38:00 -08005523 sdk_version: "current",
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005524 system_modules: "none",
Jiyong Park8be103b2019-11-08 15:53:48 +09005525 jni_libs: ["libjni"],
Colin Cross094cde42020-02-15 10:38:00 -08005526 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005527 apex_available: [ "myapex" ],
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005528 }
Jiyong Parkf7487312019-10-17 12:54:30 +09005529
5530 android_app {
5531 name: "AppFooPriv",
5532 srcs: ["foo/bar/MyClass.java"],
Colin Cross094cde42020-02-15 10:38:00 -08005533 sdk_version: "current",
Jiyong Parkf7487312019-10-17 12:54:30 +09005534 system_modules: "none",
5535 privileged: true,
Colin Cross094cde42020-02-15 10:38:00 -08005536 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005537 apex_available: [ "myapex" ],
Jiyong Parkf7487312019-10-17 12:54:30 +09005538 }
Jiyong Park8be103b2019-11-08 15:53:48 +09005539
5540 cc_library_shared {
5541 name: "libjni",
5542 srcs: ["mylib.cpp"],
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005543 shared_libs: ["libfoo"],
5544 stl: "none",
5545 system_shared_libs: [],
5546 apex_available: [ "myapex" ],
5547 sdk_version: "current",
5548 }
5549
5550 cc_library_shared {
5551 name: "libfoo",
Jiyong Park8be103b2019-11-08 15:53:48 +09005552 stl: "none",
5553 system_shared_libs: [],
Jiyong Park0f80c182020-01-31 02:49:53 +09005554 apex_available: [ "myapex" ],
Colin Cross094cde42020-02-15 10:38:00 -08005555 sdk_version: "current",
Jiyong Park8be103b2019-11-08 15:53:48 +09005556 }
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005557 `)
5558
Sundong Ahnabb64432019-10-22 13:58:29 +09005559 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005560 apexRule := module.Rule("apexRule")
5561 copyCmds := apexRule.Args["copy_commands"]
5562
5563 ensureContains(t, copyCmds, "image.apex/app/AppFoo/AppFoo.apk")
Jiyong Parkf7487312019-10-17 12:54:30 +09005564 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPriv/AppFooPriv.apk")
Jiyong Park52cd06f2019-11-11 10:14:32 +09005565
Colin Crossaede88c2020-08-11 12:17:01 -07005566 appZipRule := ctx.ModuleForTests("AppFoo", "android_common_apex10000").Description("zip jni libs")
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005567 // JNI libraries are uncompressed
Jiyong Park52cd06f2019-11-11 10:14:32 +09005568 if args := appZipRule.Args["jarArgs"]; !strings.Contains(args, "-L 0") {
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005569 t.Errorf("jni libs are not uncompressed for AppFoo")
Jiyong Park52cd06f2019-11-11 10:14:32 +09005570 }
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005571 // JNI libraries including transitive deps are
5572 for _, jni := range []string{"libjni", "libfoo"} {
Paul Duffinafdd4062021-03-30 19:44:07 +01005573 jniOutput := ctx.ModuleForTests(jni, "android_arm64_armv8-a_sdk_shared_apex10000").Module().(*cc.Module).OutputFile().RelativeToTop()
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005574 // ... embedded inside APK (jnilibs.zip)
5575 ensureListContains(t, appZipRule.Implicits.Strings(), jniOutput.String())
5576 // ... and not directly inside the APEX
5577 ensureNotContains(t, copyCmds, "image.apex/lib64/"+jni+".so")
5578 }
Dario Frenicde2a032019-10-27 00:29:22 +01005579}
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005580
Dario Frenicde2a032019-10-27 00:29:22 +01005581func TestApexWithAppImports(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005582 ctx := testApex(t, `
Dario Frenicde2a032019-10-27 00:29:22 +01005583 apex {
5584 name: "myapex",
5585 key: "myapex.key",
5586 apps: [
5587 "AppFooPrebuilt",
5588 "AppFooPrivPrebuilt",
5589 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005590 updatable: false,
Dario Frenicde2a032019-10-27 00:29:22 +01005591 }
5592
5593 apex_key {
5594 name: "myapex.key",
5595 public_key: "testkey.avbpubkey",
5596 private_key: "testkey.pem",
5597 }
5598
5599 android_app_import {
5600 name: "AppFooPrebuilt",
5601 apk: "PrebuiltAppFoo.apk",
5602 presigned: true,
5603 dex_preopt: {
5604 enabled: false,
5605 },
Jiyong Park592a6a42020-04-21 22:34:28 +09005606 apex_available: ["myapex"],
Dario Frenicde2a032019-10-27 00:29:22 +01005607 }
5608
5609 android_app_import {
5610 name: "AppFooPrivPrebuilt",
5611 apk: "PrebuiltAppFooPriv.apk",
5612 privileged: true,
5613 presigned: true,
5614 dex_preopt: {
5615 enabled: false,
5616 },
Jooyung Han39ee1192020-03-23 20:21:11 +09005617 filename: "AwesomePrebuiltAppFooPriv.apk",
Jiyong Park592a6a42020-04-21 22:34:28 +09005618 apex_available: ["myapex"],
Dario Frenicde2a032019-10-27 00:29:22 +01005619 }
5620 `)
5621
Sundong Ahnabb64432019-10-22 13:58:29 +09005622 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Dario Frenicde2a032019-10-27 00:29:22 +01005623 apexRule := module.Rule("apexRule")
5624 copyCmds := apexRule.Args["copy_commands"]
5625
5626 ensureContains(t, copyCmds, "image.apex/app/AppFooPrebuilt/AppFooPrebuilt.apk")
Jooyung Han39ee1192020-03-23 20:21:11 +09005627 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPrivPrebuilt/AwesomePrebuiltAppFooPriv.apk")
5628}
5629
5630func TestApexWithAppImportsPrefer(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005631 ctx := testApex(t, `
Jooyung Han39ee1192020-03-23 20:21:11 +09005632 apex {
5633 name: "myapex",
5634 key: "myapex.key",
5635 apps: [
5636 "AppFoo",
5637 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005638 updatable: false,
Jooyung Han39ee1192020-03-23 20:21:11 +09005639 }
5640
5641 apex_key {
5642 name: "myapex.key",
5643 public_key: "testkey.avbpubkey",
5644 private_key: "testkey.pem",
5645 }
5646
5647 android_app {
5648 name: "AppFoo",
5649 srcs: ["foo/bar/MyClass.java"],
5650 sdk_version: "none",
5651 system_modules: "none",
5652 apex_available: [ "myapex" ],
5653 }
5654
5655 android_app_import {
5656 name: "AppFoo",
5657 apk: "AppFooPrebuilt.apk",
5658 filename: "AppFooPrebuilt.apk",
5659 presigned: true,
5660 prefer: true,
Jiyong Park592a6a42020-04-21 22:34:28 +09005661 apex_available: ["myapex"],
Jooyung Han39ee1192020-03-23 20:21:11 +09005662 }
5663 `, withFiles(map[string][]byte{
5664 "AppFooPrebuilt.apk": nil,
5665 }))
5666
5667 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Han86feead2021-03-08 13:11:48 +09005668 "app/AppFoo/AppFooPrebuilt.apk",
Jooyung Han39ee1192020-03-23 20:21:11 +09005669 })
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005670}
5671
Dario Freni6f3937c2019-12-20 22:58:03 +00005672func TestApexWithTestHelperApp(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005673 ctx := testApex(t, `
Dario Freni6f3937c2019-12-20 22:58:03 +00005674 apex {
5675 name: "myapex",
5676 key: "myapex.key",
5677 apps: [
5678 "TesterHelpAppFoo",
5679 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005680 updatable: false,
Dario Freni6f3937c2019-12-20 22:58:03 +00005681 }
5682
5683 apex_key {
5684 name: "myapex.key",
5685 public_key: "testkey.avbpubkey",
5686 private_key: "testkey.pem",
5687 }
5688
5689 android_test_helper_app {
5690 name: "TesterHelpAppFoo",
5691 srcs: ["foo/bar/MyClass.java"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005692 apex_available: [ "myapex" ],
Dario Freni6f3937c2019-12-20 22:58:03 +00005693 }
5694
5695 `)
5696
5697 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
5698 apexRule := module.Rule("apexRule")
5699 copyCmds := apexRule.Args["copy_commands"]
5700
5701 ensureContains(t, copyCmds, "image.apex/app/TesterHelpAppFoo/TesterHelpAppFoo.apk")
5702}
5703
Jooyung Han18020ea2019-11-13 10:50:48 +09005704func TestApexPropertiesShouldBeDefaultable(t *testing.T) {
5705 // libfoo's apex_available comes from cc_defaults
Steven Moreland6e36cd62020-10-22 01:08:35 +00005706 testApexError(t, `requires "libfoo" that doesn't list the APEX under 'apex_available'.`, `
Jooyung Han18020ea2019-11-13 10:50:48 +09005707 apex {
5708 name: "myapex",
5709 key: "myapex.key",
5710 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005711 updatable: false,
Jooyung Han18020ea2019-11-13 10:50:48 +09005712 }
5713
5714 apex_key {
5715 name: "myapex.key",
5716 public_key: "testkey.avbpubkey",
5717 private_key: "testkey.pem",
5718 }
5719
5720 apex {
5721 name: "otherapex",
5722 key: "myapex.key",
5723 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005724 updatable: false,
Jooyung Han18020ea2019-11-13 10:50:48 +09005725 }
5726
5727 cc_defaults {
5728 name: "libfoo-defaults",
5729 apex_available: ["otherapex"],
5730 }
5731
5732 cc_library {
5733 name: "libfoo",
5734 defaults: ["libfoo-defaults"],
5735 stl: "none",
5736 system_shared_libs: [],
5737 }`)
5738}
5739
Paul Duffine52e66f2020-03-30 17:54:29 +01005740func TestApexAvailable_DirectDep(t *testing.T) {
Jiyong Park127b40b2019-09-30 16:04:35 +09005741 // libfoo is not available to myapex, but only to otherapex
Steven Moreland6e36cd62020-10-22 01:08:35 +00005742 testApexError(t, "requires \"libfoo\" that doesn't list the APEX under 'apex_available'.", `
Jiyong Park127b40b2019-09-30 16:04:35 +09005743 apex {
5744 name: "myapex",
5745 key: "myapex.key",
5746 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005747 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005748 }
5749
5750 apex_key {
5751 name: "myapex.key",
5752 public_key: "testkey.avbpubkey",
5753 private_key: "testkey.pem",
5754 }
5755
5756 apex {
5757 name: "otherapex",
5758 key: "otherapex.key",
5759 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005760 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005761 }
5762
5763 apex_key {
5764 name: "otherapex.key",
5765 public_key: "testkey.avbpubkey",
5766 private_key: "testkey.pem",
5767 }
5768
5769 cc_library {
5770 name: "libfoo",
5771 stl: "none",
5772 system_shared_libs: [],
5773 apex_available: ["otherapex"],
5774 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01005775}
Jiyong Park127b40b2019-09-30 16:04:35 +09005776
Paul Duffine52e66f2020-03-30 17:54:29 +01005777func TestApexAvailable_IndirectDep(t *testing.T) {
Jooyung Han5e9013b2020-03-10 06:23:13 +09005778 // libbbaz is an indirect dep
Jiyong Park767dbd92021-03-04 13:03:10 +09005779 testApexError(t, `requires "libbaz" that doesn't list the APEX under 'apex_available'.\n\nDependency path:
Colin Cross6e511a92020-07-27 21:26:48 -07005780.*via tag apex\.dependencyTag.*name:sharedLib.*
Paul Duffindf915ff2020-03-30 17:58:21 +01005781.*-> libfoo.*link:shared.*
Colin Cross6e511a92020-07-27 21:26:48 -07005782.*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
Paul Duffindf915ff2020-03-30 17:58:21 +01005783.*-> libbar.*link:shared.*
Colin Cross6e511a92020-07-27 21:26:48 -07005784.*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
Paul Duffin65347702020-03-31 15:23:40 +01005785.*-> libbaz.*link:shared.*`, `
Jiyong Park127b40b2019-09-30 16:04:35 +09005786 apex {
5787 name: "myapex",
5788 key: "myapex.key",
5789 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005790 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005791 }
5792
5793 apex_key {
5794 name: "myapex.key",
5795 public_key: "testkey.avbpubkey",
5796 private_key: "testkey.pem",
5797 }
5798
Jiyong Park127b40b2019-09-30 16:04:35 +09005799 cc_library {
5800 name: "libfoo",
5801 stl: "none",
5802 shared_libs: ["libbar"],
5803 system_shared_libs: [],
Jooyung Han5e9013b2020-03-10 06:23:13 +09005804 apex_available: ["myapex"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005805 }
5806
5807 cc_library {
5808 name: "libbar",
5809 stl: "none",
Jooyung Han5e9013b2020-03-10 06:23:13 +09005810 shared_libs: ["libbaz"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005811 system_shared_libs: [],
Jooyung Han5e9013b2020-03-10 06:23:13 +09005812 apex_available: ["myapex"],
5813 }
5814
5815 cc_library {
5816 name: "libbaz",
5817 stl: "none",
5818 system_shared_libs: [],
Jiyong Park127b40b2019-09-30 16:04:35 +09005819 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01005820}
Jiyong Park127b40b2019-09-30 16:04:35 +09005821
Paul Duffine52e66f2020-03-30 17:54:29 +01005822func TestApexAvailable_InvalidApexName(t *testing.T) {
Jiyong Park127b40b2019-09-30 16:04:35 +09005823 testApexError(t, "\"otherapex\" is not a valid module name", `
5824 apex {
5825 name: "myapex",
5826 key: "myapex.key",
5827 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005828 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005829 }
5830
5831 apex_key {
5832 name: "myapex.key",
5833 public_key: "testkey.avbpubkey",
5834 private_key: "testkey.pem",
5835 }
5836
5837 cc_library {
5838 name: "libfoo",
5839 stl: "none",
5840 system_shared_libs: [],
5841 apex_available: ["otherapex"],
5842 }`)
5843
Paul Duffine52e66f2020-03-30 17:54:29 +01005844 testApex(t, `
Jiyong Park127b40b2019-09-30 16:04:35 +09005845 apex {
5846 name: "myapex",
5847 key: "myapex.key",
5848 native_shared_libs: ["libfoo", "libbar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005849 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005850 }
5851
5852 apex_key {
5853 name: "myapex.key",
5854 public_key: "testkey.avbpubkey",
5855 private_key: "testkey.pem",
5856 }
5857
5858 cc_library {
5859 name: "libfoo",
5860 stl: "none",
5861 system_shared_libs: [],
Jiyong Park323a4c32020-03-01 17:29:06 +09005862 runtime_libs: ["libbaz"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005863 apex_available: ["myapex"],
5864 }
5865
5866 cc_library {
5867 name: "libbar",
5868 stl: "none",
5869 system_shared_libs: [],
5870 apex_available: ["//apex_available:anyapex"],
Jiyong Park323a4c32020-03-01 17:29:06 +09005871 }
5872
5873 cc_library {
5874 name: "libbaz",
5875 stl: "none",
5876 system_shared_libs: [],
5877 stubs: {
5878 versions: ["10", "20", "30"],
5879 },
Jiyong Park127b40b2019-09-30 16:04:35 +09005880 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01005881}
Jiyong Park127b40b2019-09-30 16:04:35 +09005882
Jiyong Park89e850a2020-04-07 16:37:39 +09005883func TestApexAvailable_CheckForPlatform(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005884 ctx := testApex(t, `
Jiyong Park127b40b2019-09-30 16:04:35 +09005885 apex {
5886 name: "myapex",
5887 key: "myapex.key",
Jiyong Park89e850a2020-04-07 16:37:39 +09005888 native_shared_libs: ["libbar", "libbaz"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005889 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005890 }
5891
5892 apex_key {
5893 name: "myapex.key",
5894 public_key: "testkey.avbpubkey",
5895 private_key: "testkey.pem",
5896 }
5897
5898 cc_library {
5899 name: "libfoo",
5900 stl: "none",
5901 system_shared_libs: [],
Jiyong Park89e850a2020-04-07 16:37:39 +09005902 shared_libs: ["libbar"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005903 apex_available: ["//apex_available:platform"],
Jiyong Park89e850a2020-04-07 16:37:39 +09005904 }
5905
5906 cc_library {
5907 name: "libfoo2",
5908 stl: "none",
5909 system_shared_libs: [],
5910 shared_libs: ["libbaz"],
5911 apex_available: ["//apex_available:platform"],
5912 }
5913
5914 cc_library {
5915 name: "libbar",
5916 stl: "none",
5917 system_shared_libs: [],
5918 apex_available: ["myapex"],
5919 }
5920
5921 cc_library {
5922 name: "libbaz",
5923 stl: "none",
5924 system_shared_libs: [],
5925 apex_available: ["myapex"],
5926 stubs: {
5927 versions: ["1"],
5928 },
Jiyong Park127b40b2019-09-30 16:04:35 +09005929 }`)
5930
Jiyong Park89e850a2020-04-07 16:37:39 +09005931 // libfoo shouldn't be available to platform even though it has "//apex_available:platform",
5932 // because it depends on libbar which isn't available to platform
5933 libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
5934 if libfoo.NotAvailableForPlatform() != true {
5935 t.Errorf("%q shouldn't be available to platform", libfoo.String())
5936 }
5937
5938 // libfoo2 however can be available to platform because it depends on libbaz which provides
5939 // stubs
5940 libfoo2 := ctx.ModuleForTests("libfoo2", "android_arm64_armv8-a_shared").Module().(*cc.Module)
5941 if libfoo2.NotAvailableForPlatform() == true {
5942 t.Errorf("%q should be available to platform", libfoo2.String())
5943 }
Paul Duffine52e66f2020-03-30 17:54:29 +01005944}
Jiyong Parka90ca002019-10-07 15:47:24 +09005945
Paul Duffine52e66f2020-03-30 17:54:29 +01005946func TestApexAvailable_CreatedForApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005947 ctx := testApex(t, `
Jiyong Parka90ca002019-10-07 15:47:24 +09005948 apex {
5949 name: "myapex",
5950 key: "myapex.key",
5951 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005952 updatable: false,
Jiyong Parka90ca002019-10-07 15:47:24 +09005953 }
5954
5955 apex_key {
5956 name: "myapex.key",
5957 public_key: "testkey.avbpubkey",
5958 private_key: "testkey.pem",
5959 }
5960
5961 cc_library {
5962 name: "libfoo",
5963 stl: "none",
5964 system_shared_libs: [],
5965 apex_available: ["myapex"],
5966 static: {
5967 apex_available: ["//apex_available:platform"],
5968 },
5969 }`)
5970
Jiyong Park89e850a2020-04-07 16:37:39 +09005971 libfooShared := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
5972 if libfooShared.NotAvailableForPlatform() != true {
5973 t.Errorf("%q shouldn't be available to platform", libfooShared.String())
5974 }
5975 libfooStatic := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_static").Module().(*cc.Module)
5976 if libfooStatic.NotAvailableForPlatform() != false {
5977 t.Errorf("%q should be available to platform", libfooStatic.String())
5978 }
Jiyong Park127b40b2019-09-30 16:04:35 +09005979}
5980
Jiyong Park5d790c32019-11-15 18:40:32 +09005981func TestOverrideApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005982 ctx := testApex(t, `
Jiyong Park5d790c32019-11-15 18:40:32 +09005983 apex {
5984 name: "myapex",
5985 key: "myapex.key",
5986 apps: ["app"],
markchien7c803b82021-08-26 22:10:06 +08005987 bpfs: ["bpf"],
Daniel Norman5a3ce132021-08-26 15:44:43 -07005988 prebuilts: ["myetc"],
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08005989 overrides: ["oldapex"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005990 updatable: false,
Jiyong Park5d790c32019-11-15 18:40:32 +09005991 }
5992
5993 override_apex {
5994 name: "override_myapex",
5995 base: "myapex",
5996 apps: ["override_app"],
markchien7c803b82021-08-26 22:10:06 +08005997 bpfs: ["override_bpf"],
Daniel Norman5a3ce132021-08-26 15:44:43 -07005998 prebuilts: ["override_myetc"],
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08005999 overrides: ["unknownapex"],
Baligh Uddin004d7172020-02-19 21:29:28 -08006000 logging_parent: "com.foo.bar",
Baligh Uddin5b57dba2020-03-15 13:01:05 -07006001 package_name: "test.overridden.package",
Jaewoong Jung4cfdf7d2021-04-20 16:21:24 -07006002 key: "mynewapex.key",
6003 certificate: ":myapex.certificate",
Jiyong Park5d790c32019-11-15 18:40:32 +09006004 }
6005
6006 apex_key {
6007 name: "myapex.key",
6008 public_key: "testkey.avbpubkey",
6009 private_key: "testkey.pem",
6010 }
6011
Jaewoong Jung4cfdf7d2021-04-20 16:21:24 -07006012 apex_key {
6013 name: "mynewapex.key",
6014 public_key: "testkey2.avbpubkey",
6015 private_key: "testkey2.pem",
6016 }
6017
6018 android_app_certificate {
6019 name: "myapex.certificate",
6020 certificate: "testkey",
6021 }
6022
Jiyong Park5d790c32019-11-15 18:40:32 +09006023 android_app {
6024 name: "app",
6025 srcs: ["foo/bar/MyClass.java"],
6026 package_name: "foo",
6027 sdk_version: "none",
6028 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00006029 apex_available: [ "myapex" ],
Jiyong Park5d790c32019-11-15 18:40:32 +09006030 }
6031
6032 override_android_app {
6033 name: "override_app",
6034 base: "app",
6035 package_name: "bar",
6036 }
markchien7c803b82021-08-26 22:10:06 +08006037
6038 bpf {
6039 name: "bpf",
6040 srcs: ["bpf.c"],
6041 }
6042
6043 bpf {
6044 name: "override_bpf",
6045 srcs: ["override_bpf.c"],
6046 }
Daniel Norman5a3ce132021-08-26 15:44:43 -07006047
6048 prebuilt_etc {
6049 name: "myetc",
6050 src: "myprebuilt",
6051 }
6052
6053 prebuilt_etc {
6054 name: "override_myetc",
6055 src: "override_myprebuilt",
6056 }
Jiyong Park20bacab2020-03-03 11:45:41 +09006057 `, withManifestPackageNameOverrides([]string{"myapex:com.android.myapex"}))
Jiyong Park5d790c32019-11-15 18:40:32 +09006058
Jiyong Park317645e2019-12-05 13:20:58 +09006059 originalVariant := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(android.OverridableModule)
6060 overriddenVariant := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Module().(android.OverridableModule)
6061 if originalVariant.GetOverriddenBy() != "" {
6062 t.Errorf("GetOverriddenBy should be empty, but was %q", originalVariant.GetOverriddenBy())
6063 }
6064 if overriddenVariant.GetOverriddenBy() != "override_myapex" {
6065 t.Errorf("GetOverriddenBy should be \"override_myapex\", but was %q", overriddenVariant.GetOverriddenBy())
6066 }
6067
Jiyong Park5d790c32019-11-15 18:40:32 +09006068 module := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image")
6069 apexRule := module.Rule("apexRule")
6070 copyCmds := apexRule.Args["copy_commands"]
6071
6072 ensureNotContains(t, copyCmds, "image.apex/app/app/app.apk")
Jooyung Han39ee1192020-03-23 20:21:11 +09006073 ensureContains(t, copyCmds, "image.apex/app/override_app/override_app.apk")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08006074
markchien7c803b82021-08-26 22:10:06 +08006075 ensureNotContains(t, copyCmds, "image.apex/etc/bpf/bpf.o")
6076 ensureContains(t, copyCmds, "image.apex/etc/bpf/override_bpf.o")
6077
Daniel Norman5a3ce132021-08-26 15:44:43 -07006078 ensureNotContains(t, copyCmds, "image.apex/etc/myetc")
6079 ensureContains(t, copyCmds, "image.apex/etc/override_myetc")
6080
Jaewoong Jung1670ca02019-11-22 14:50:42 -08006081 apexBundle := module.Module().(*apexBundle)
6082 name := apexBundle.Name()
6083 if name != "override_myapex" {
6084 t.Errorf("name should be \"override_myapex\", but was %q", name)
6085 }
6086
Baligh Uddin004d7172020-02-19 21:29:28 -08006087 if apexBundle.overridableProperties.Logging_parent != "com.foo.bar" {
6088 t.Errorf("override_myapex should have logging parent (com.foo.bar), but was %q.", apexBundle.overridableProperties.Logging_parent)
6089 }
6090
Jiyong Park20bacab2020-03-03 11:45:41 +09006091 optFlags := apexRule.Args["opt_flags"]
Baligh Uddin5b57dba2020-03-15 13:01:05 -07006092 ensureContains(t, optFlags, "--override_apk_package_name test.overridden.package")
Jaewoong Jung4cfdf7d2021-04-20 16:21:24 -07006093 ensureContains(t, optFlags, "--pubkey testkey2.avbpubkey")
6094
6095 signApkRule := module.Rule("signapk")
6096 ensureEquals(t, signApkRule.Args["certificates"], "testkey.x509.pem testkey.pk8")
Jiyong Park20bacab2020-03-03 11:45:41 +09006097
Colin Crossaa255532020-07-03 13:18:24 -07006098 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jaewoong Jung1670ca02019-11-22 14:50:42 -08006099 var builder strings.Builder
6100 data.Custom(&builder, name, "TARGET_", "", data)
6101 androidMk := builder.String()
Jiyong Parkf653b052019-11-18 15:39:01 +09006102 ensureContains(t, androidMk, "LOCAL_MODULE := override_app.override_myapex")
markchien7c803b82021-08-26 22:10:06 +08006103 ensureContains(t, androidMk, "LOCAL_MODULE := override_bpf.o.override_myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08006104 ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.override_myapex")
6105 ensureContains(t, androidMk, "LOCAL_MODULE_STEM := override_myapex.apex")
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08006106 ensureContains(t, androidMk, "LOCAL_OVERRIDES_MODULES := unknownapex myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08006107 ensureNotContains(t, androidMk, "LOCAL_MODULE := app.myapex")
markchien7c803b82021-08-26 22:10:06 +08006108 ensureNotContains(t, androidMk, "LOCAL_MODULE := bpf.myapex")
Jiyong Parkf653b052019-11-18 15:39:01 +09006109 ensureNotContains(t, androidMk, "LOCAL_MODULE := override_app.myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08006110 ensureNotContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex")
6111 ensureNotContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.apex")
Jiyong Park5d790c32019-11-15 18:40:32 +09006112}
6113
Jooyung Han214bf372019-11-12 13:03:50 +09006114func TestLegacyAndroid10Support(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006115 ctx := testApex(t, `
Jooyung Han214bf372019-11-12 13:03:50 +09006116 apex {
6117 name: "myapex",
6118 key: "myapex.key",
Peter Collingbournedc4f9862020-02-12 17:13:25 -08006119 native_shared_libs: ["mylib"],
Jooyung Han5417f772020-03-12 18:37:20 +09006120 min_sdk_version: "29",
Jooyung Han214bf372019-11-12 13:03:50 +09006121 }
6122
6123 apex_key {
6124 name: "myapex.key",
6125 public_key: "testkey.avbpubkey",
6126 private_key: "testkey.pem",
6127 }
Peter Collingbournedc4f9862020-02-12 17:13:25 -08006128
6129 cc_library {
6130 name: "mylib",
6131 srcs: ["mylib.cpp"],
6132 stl: "libc++",
6133 system_shared_libs: [],
6134 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09006135 min_sdk_version: "29",
Peter Collingbournedc4f9862020-02-12 17:13:25 -08006136 }
Peter Collingbournedc4f9862020-02-12 17:13:25 -08006137 `, withUnbundledBuild)
Jooyung Han214bf372019-11-12 13:03:50 +09006138
6139 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
6140 args := module.Rule("apexRule").Args
6141 ensureContains(t, args["opt_flags"], "--manifest_json "+module.Output("apex_manifest.json").Output.String())
Dario Frenie3546902020-01-14 23:50:25 +00006142 ensureNotContains(t, args["opt_flags"], "--no_hashtree")
Peter Collingbournedc4f9862020-02-12 17:13:25 -08006143
6144 // The copies of the libraries in the apex should have one more dependency than
6145 // the ones outside the apex, namely the unwinder. Ideally we should check
6146 // the dependency names directly here but for some reason the names are blank in
6147 // this test.
6148 for _, lib := range []string{"libc++", "mylib"} {
Colin Crossaede88c2020-08-11 12:17:01 -07006149 apexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared_apex29").Rule("ld").Implicits
Peter Collingbournedc4f9862020-02-12 17:13:25 -08006150 nonApexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared").Rule("ld").Implicits
6151 if len(apexImplicits) != len(nonApexImplicits)+1 {
6152 t.Errorf("%q missing unwinder dep", lib)
6153 }
6154 }
Jooyung Han214bf372019-11-12 13:03:50 +09006155}
6156
Paul Duffine05480a2021-03-08 15:07:14 +00006157var filesForSdkLibrary = android.MockFS{
Paul Duffin9b879592020-05-26 13:21:35 +01006158 "api/current.txt": nil,
6159 "api/removed.txt": nil,
6160 "api/system-current.txt": nil,
6161 "api/system-removed.txt": nil,
6162 "api/test-current.txt": nil,
6163 "api/test-removed.txt": nil,
Paul Duffineedc5d52020-06-12 17:46:39 +01006164
Anton Hanssondff2c782020-12-21 17:10:01 +00006165 "100/public/api/foo.txt": nil,
6166 "100/public/api/foo-removed.txt": nil,
6167 "100/system/api/foo.txt": nil,
6168 "100/system/api/foo-removed.txt": nil,
6169
Paul Duffineedc5d52020-06-12 17:46:39 +01006170 // For java_sdk_library_import
6171 "a.jar": nil,
Paul Duffin9b879592020-05-26 13:21:35 +01006172}
6173
Jooyung Han58f26ab2019-12-18 15:34:32 +09006174func TestJavaSDKLibrary(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006175 ctx := testApex(t, `
Jooyung Han58f26ab2019-12-18 15:34:32 +09006176 apex {
6177 name: "myapex",
6178 key: "myapex.key",
6179 java_libs: ["foo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006180 updatable: false,
Jooyung Han58f26ab2019-12-18 15:34:32 +09006181 }
6182
6183 apex_key {
6184 name: "myapex.key",
6185 public_key: "testkey.avbpubkey",
6186 private_key: "testkey.pem",
6187 }
6188
6189 java_sdk_library {
6190 name: "foo",
6191 srcs: ["a.java"],
6192 api_packages: ["foo"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00006193 apex_available: [ "myapex" ],
Jooyung Han58f26ab2019-12-18 15:34:32 +09006194 }
Anton Hanssondff2c782020-12-21 17:10:01 +00006195
6196 prebuilt_apis {
6197 name: "sdk",
6198 api_dirs: ["100"],
6199 }
Paul Duffin9b879592020-05-26 13:21:35 +01006200 `, withFiles(filesForSdkLibrary))
Jooyung Han58f26ab2019-12-18 15:34:32 +09006201
6202 // java_sdk_library installs both impl jar and permission XML
Jooyung Hana57af4a2020-01-23 05:36:59 +00006203 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Han58f26ab2019-12-18 15:34:32 +09006204 "javalib/foo.jar",
6205 "etc/permissions/foo.xml",
6206 })
6207 // Permission XML should point to the activated path of impl jar of java_sdk_library
Jiyong Parke3833882020-02-17 17:28:10 +09006208 sdkLibrary := ctx.ModuleForTests("foo.xml", "android_common_myapex").Rule("java_sdk_xml")
Pedro Loureiro9956e5e2021-09-07 17:21:59 +00006209 ensureMatches(t, sdkLibrary.RuleParams.Command, `<library\\n\s+name=\\\"foo\\\"\\n\s+file=\\\"/apex/myapex/javalib/foo.jar\\\"`)
Jooyung Han58f26ab2019-12-18 15:34:32 +09006210}
6211
Paul Duffin9b879592020-05-26 13:21:35 +01006212func TestJavaSDKLibrary_WithinApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006213 ctx := testApex(t, `
Paul Duffin9b879592020-05-26 13:21:35 +01006214 apex {
6215 name: "myapex",
6216 key: "myapex.key",
6217 java_libs: ["foo", "bar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006218 updatable: false,
Paul Duffin9b879592020-05-26 13:21:35 +01006219 }
6220
6221 apex_key {
6222 name: "myapex.key",
6223 public_key: "testkey.avbpubkey",
6224 private_key: "testkey.pem",
6225 }
6226
6227 java_sdk_library {
6228 name: "foo",
6229 srcs: ["a.java"],
6230 api_packages: ["foo"],
6231 apex_available: ["myapex"],
6232 sdk_version: "none",
6233 system_modules: "none",
6234 }
6235
6236 java_library {
6237 name: "bar",
6238 srcs: ["a.java"],
6239 libs: ["foo"],
6240 apex_available: ["myapex"],
6241 sdk_version: "none",
6242 system_modules: "none",
6243 }
Anton Hanssondff2c782020-12-21 17:10:01 +00006244
6245 prebuilt_apis {
6246 name: "sdk",
6247 api_dirs: ["100"],
6248 }
Paul Duffin9b879592020-05-26 13:21:35 +01006249 `, withFiles(filesForSdkLibrary))
6250
6251 // java_sdk_library installs both impl jar and permission XML
6252 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
6253 "javalib/bar.jar",
6254 "javalib/foo.jar",
6255 "etc/permissions/foo.xml",
6256 })
6257
6258 // The bar library should depend on the implementation jar.
6259 barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
Paul Duffincf8d7db2021-03-29 00:29:53 +01006260 if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Paul Duffin9b879592020-05-26 13:21:35 +01006261 t.Errorf("expected %q, found %#q", expected, actual)
6262 }
6263}
6264
6265func TestJavaSDKLibrary_CrossBoundary(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006266 ctx := testApex(t, `
Paul Duffin9b879592020-05-26 13:21:35 +01006267 apex {
6268 name: "myapex",
6269 key: "myapex.key",
6270 java_libs: ["foo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006271 updatable: false,
Paul Duffin9b879592020-05-26 13:21:35 +01006272 }
6273
6274 apex_key {
6275 name: "myapex.key",
6276 public_key: "testkey.avbpubkey",
6277 private_key: "testkey.pem",
6278 }
6279
6280 java_sdk_library {
6281 name: "foo",
6282 srcs: ["a.java"],
6283 api_packages: ["foo"],
6284 apex_available: ["myapex"],
6285 sdk_version: "none",
6286 system_modules: "none",
6287 }
6288
6289 java_library {
6290 name: "bar",
6291 srcs: ["a.java"],
6292 libs: ["foo"],
6293 sdk_version: "none",
6294 system_modules: "none",
6295 }
Anton Hanssondff2c782020-12-21 17:10:01 +00006296
6297 prebuilt_apis {
6298 name: "sdk",
6299 api_dirs: ["100"],
6300 }
Paul Duffin9b879592020-05-26 13:21:35 +01006301 `, withFiles(filesForSdkLibrary))
6302
6303 // java_sdk_library installs both impl jar and permission XML
6304 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
6305 "javalib/foo.jar",
6306 "etc/permissions/foo.xml",
6307 })
6308
6309 // The bar library should depend on the stubs jar.
6310 barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
Paul Duffincf8d7db2021-03-29 00:29:53 +01006311 if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Paul Duffin9b879592020-05-26 13:21:35 +01006312 t.Errorf("expected %q, found %#q", expected, actual)
6313 }
6314}
6315
Paul Duffineedc5d52020-06-12 17:46:39 +01006316func TestJavaSDKLibrary_ImportPreferred(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006317 ctx := testApex(t, `
Anton Hanssondff2c782020-12-21 17:10:01 +00006318 prebuilt_apis {
6319 name: "sdk",
6320 api_dirs: ["100"],
6321 }`,
Paul Duffineedc5d52020-06-12 17:46:39 +01006322 withFiles(map[string][]byte{
6323 "apex/a.java": nil,
6324 "apex/apex_manifest.json": nil,
6325 "apex/Android.bp": []byte(`
6326 package {
6327 default_visibility: ["//visibility:private"],
6328 }
6329
6330 apex {
6331 name: "myapex",
6332 key: "myapex.key",
6333 java_libs: ["foo", "bar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006334 updatable: false,
Paul Duffineedc5d52020-06-12 17:46:39 +01006335 }
6336
6337 apex_key {
6338 name: "myapex.key",
6339 public_key: "testkey.avbpubkey",
6340 private_key: "testkey.pem",
6341 }
6342
6343 java_library {
6344 name: "bar",
6345 srcs: ["a.java"],
6346 libs: ["foo"],
6347 apex_available: ["myapex"],
6348 sdk_version: "none",
6349 system_modules: "none",
6350 }
6351`),
6352 "source/a.java": nil,
6353 "source/api/current.txt": nil,
6354 "source/api/removed.txt": nil,
6355 "source/Android.bp": []byte(`
6356 package {
6357 default_visibility: ["//visibility:private"],
6358 }
6359
6360 java_sdk_library {
6361 name: "foo",
6362 visibility: ["//apex"],
6363 srcs: ["a.java"],
6364 api_packages: ["foo"],
6365 apex_available: ["myapex"],
6366 sdk_version: "none",
6367 system_modules: "none",
6368 public: {
6369 enabled: true,
6370 },
6371 }
6372`),
6373 "prebuilt/a.jar": nil,
6374 "prebuilt/Android.bp": []byte(`
6375 package {
6376 default_visibility: ["//visibility:private"],
6377 }
6378
6379 java_sdk_library_import {
6380 name: "foo",
6381 visibility: ["//apex", "//source"],
6382 apex_available: ["myapex"],
6383 prefer: true,
6384 public: {
6385 jars: ["a.jar"],
6386 },
6387 }
6388`),
Anton Hanssondff2c782020-12-21 17:10:01 +00006389 }), withFiles(filesForSdkLibrary),
Paul Duffineedc5d52020-06-12 17:46:39 +01006390 )
6391
6392 // java_sdk_library installs both impl jar and permission XML
6393 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
6394 "javalib/bar.jar",
6395 "javalib/foo.jar",
6396 "etc/permissions/foo.xml",
6397 })
6398
6399 // The bar library should depend on the implementation jar.
6400 barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
Paul Duffincf8d7db2021-03-29 00:29:53 +01006401 if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.impl\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Paul Duffineedc5d52020-06-12 17:46:39 +01006402 t.Errorf("expected %q, found %#q", expected, actual)
6403 }
6404}
6405
6406func TestJavaSDKLibrary_ImportOnly(t *testing.T) {
6407 testApexError(t, `java_libs: "foo" is not configured to be compiled into dex`, `
6408 apex {
6409 name: "myapex",
6410 key: "myapex.key",
6411 java_libs: ["foo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006412 updatable: false,
Paul Duffineedc5d52020-06-12 17:46:39 +01006413 }
6414
6415 apex_key {
6416 name: "myapex.key",
6417 public_key: "testkey.avbpubkey",
6418 private_key: "testkey.pem",
6419 }
6420
6421 java_sdk_library_import {
6422 name: "foo",
6423 apex_available: ["myapex"],
6424 prefer: true,
6425 public: {
6426 jars: ["a.jar"],
6427 },
6428 }
6429
6430 `, withFiles(filesForSdkLibrary))
6431}
6432
atrost6e126252020-01-27 17:01:16 +00006433func TestCompatConfig(t *testing.T) {
Paul Duffin284165a2021-03-29 01:50:31 +01006434 result := android.GroupFixturePreparers(
6435 prepareForApexTest,
6436 java.PrepareForTestWithPlatformCompatConfig,
6437 ).RunTestWithBp(t, `
atrost6e126252020-01-27 17:01:16 +00006438 apex {
6439 name: "myapex",
6440 key: "myapex.key",
Paul Duffin3abc1742021-03-15 19:32:23 +00006441 compat_configs: ["myjar-platform-compat-config"],
atrost6e126252020-01-27 17:01:16 +00006442 java_libs: ["myjar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006443 updatable: false,
atrost6e126252020-01-27 17:01:16 +00006444 }
6445
6446 apex_key {
6447 name: "myapex.key",
6448 public_key: "testkey.avbpubkey",
6449 private_key: "testkey.pem",
6450 }
6451
6452 platform_compat_config {
6453 name: "myjar-platform-compat-config",
6454 src: ":myjar",
6455 }
6456
6457 java_library {
6458 name: "myjar",
6459 srcs: ["foo/bar/MyClass.java"],
6460 sdk_version: "none",
6461 system_modules: "none",
atrost6e126252020-01-27 17:01:16 +00006462 apex_available: [ "myapex" ],
6463 }
Paul Duffin1b29e002021-03-16 15:06:54 +00006464
6465 // Make sure that a preferred prebuilt does not affect the apex contents.
6466 prebuilt_platform_compat_config {
6467 name: "myjar-platform-compat-config",
6468 metadata: "compat-config/metadata.xml",
6469 prefer: true,
6470 }
atrost6e126252020-01-27 17:01:16 +00006471 `)
Paul Duffina369c7b2021-03-09 03:08:05 +00006472 ctx := result.TestContext
atrost6e126252020-01-27 17:01:16 +00006473 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
6474 "etc/compatconfig/myjar-platform-compat-config.xml",
6475 "javalib/myjar.jar",
6476 })
6477}
6478
Jiyong Park479321d2019-12-16 11:47:12 +09006479func TestRejectNonInstallableJavaLibrary(t *testing.T) {
6480 testApexError(t, `"myjar" is not configured to be compiled into dex`, `
6481 apex {
6482 name: "myapex",
6483 key: "myapex.key",
6484 java_libs: ["myjar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006485 updatable: false,
Jiyong Park479321d2019-12-16 11:47:12 +09006486 }
6487
6488 apex_key {
6489 name: "myapex.key",
6490 public_key: "testkey.avbpubkey",
6491 private_key: "testkey.pem",
6492 }
6493
6494 java_library {
6495 name: "myjar",
6496 srcs: ["foo/bar/MyClass.java"],
6497 sdk_version: "none",
6498 system_modules: "none",
Jiyong Park6b21c7d2020-02-11 09:16:01 +09006499 compile_dex: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09006500 apex_available: ["myapex"],
Jiyong Park479321d2019-12-16 11:47:12 +09006501 }
6502 `)
6503}
6504
Jiyong Park7afd1072019-12-30 16:56:33 +09006505func TestCarryRequiredModuleNames(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006506 ctx := testApex(t, `
Jiyong Park7afd1072019-12-30 16:56:33 +09006507 apex {
6508 name: "myapex",
6509 key: "myapex.key",
6510 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006511 updatable: false,
Jiyong Park7afd1072019-12-30 16:56:33 +09006512 }
6513
6514 apex_key {
6515 name: "myapex.key",
6516 public_key: "testkey.avbpubkey",
6517 private_key: "testkey.pem",
6518 }
6519
6520 cc_library {
6521 name: "mylib",
6522 srcs: ["mylib.cpp"],
6523 system_shared_libs: [],
6524 stl: "none",
6525 required: ["a", "b"],
6526 host_required: ["c", "d"],
6527 target_required: ["e", "f"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00006528 apex_available: [ "myapex" ],
Jiyong Park7afd1072019-12-30 16:56:33 +09006529 }
6530 `)
6531
6532 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07006533 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jiyong Park7afd1072019-12-30 16:56:33 +09006534 name := apexBundle.BaseModuleName()
6535 prefix := "TARGET_"
6536 var builder strings.Builder
6537 data.Custom(&builder, name, prefix, "", data)
6538 androidMk := builder.String()
6539 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += a b\n")
6540 ensureContains(t, androidMk, "LOCAL_HOST_REQUIRED_MODULES += c d\n")
6541 ensureContains(t, androidMk, "LOCAL_TARGET_REQUIRED_MODULES += e f\n")
6542}
6543
Jiyong Park7cd10e32020-01-14 09:22:18 +09006544func TestSymlinksFromApexToSystem(t *testing.T) {
6545 bp := `
6546 apex {
6547 name: "myapex",
6548 key: "myapex.key",
6549 native_shared_libs: ["mylib"],
6550 java_libs: ["myjar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006551 updatable: false,
Jiyong Park7cd10e32020-01-14 09:22:18 +09006552 }
6553
Jiyong Park9d677202020-02-19 16:29:35 +09006554 apex {
6555 name: "myapex.updatable",
6556 key: "myapex.key",
6557 native_shared_libs: ["mylib"],
6558 java_libs: ["myjar"],
6559 updatable: true,
Jooyung Han548640b2020-04-27 12:10:30 +09006560 min_sdk_version: "current",
Jiyong Park9d677202020-02-19 16:29:35 +09006561 }
6562
Jiyong Park7cd10e32020-01-14 09:22:18 +09006563 apex_key {
6564 name: "myapex.key",
6565 public_key: "testkey.avbpubkey",
6566 private_key: "testkey.pem",
6567 }
6568
6569 cc_library {
6570 name: "mylib",
6571 srcs: ["mylib.cpp"],
6572 shared_libs: ["myotherlib"],
6573 system_shared_libs: [],
6574 stl: "none",
6575 apex_available: [
6576 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006577 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006578 "//apex_available:platform",
6579 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006580 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006581 }
6582
6583 cc_library {
6584 name: "myotherlib",
6585 srcs: ["mylib.cpp"],
6586 system_shared_libs: [],
6587 stl: "none",
6588 apex_available: [
6589 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006590 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006591 "//apex_available:platform",
6592 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006593 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006594 }
6595
6596 java_library {
6597 name: "myjar",
6598 srcs: ["foo/bar/MyClass.java"],
6599 sdk_version: "none",
6600 system_modules: "none",
6601 libs: ["myotherjar"],
Jiyong Park7cd10e32020-01-14 09:22:18 +09006602 apex_available: [
6603 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006604 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006605 "//apex_available:platform",
6606 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006607 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006608 }
6609
6610 java_library {
6611 name: "myotherjar",
6612 srcs: ["foo/bar/MyClass.java"],
6613 sdk_version: "none",
6614 system_modules: "none",
6615 apex_available: [
6616 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006617 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006618 "//apex_available:platform",
6619 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006620 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006621 }
6622 `
6623
6624 ensureRealfileExists := func(t *testing.T, files []fileInApex, file string) {
6625 for _, f := range files {
6626 if f.path == file {
6627 if f.isLink {
6628 t.Errorf("%q is not a real file", file)
6629 }
6630 return
6631 }
6632 }
6633 t.Errorf("%q is not found", file)
6634 }
6635
6636 ensureSymlinkExists := func(t *testing.T, files []fileInApex, file string) {
6637 for _, f := range files {
6638 if f.path == file {
6639 if !f.isLink {
6640 t.Errorf("%q is not a symlink", file)
6641 }
6642 return
6643 }
6644 }
6645 t.Errorf("%q is not found", file)
6646 }
6647
Jiyong Park9d677202020-02-19 16:29:35 +09006648 // For unbundled build, symlink shouldn't exist regardless of whether an APEX
6649 // is updatable or not
Colin Cross1c460562021-02-16 17:55:47 -08006650 ctx := testApex(t, bp, withUnbundledBuild)
Jooyung Hana57af4a2020-01-23 05:36:59 +00006651 files := getFiles(t, ctx, "myapex", "android_common_myapex_image")
Jiyong Park7cd10e32020-01-14 09:22:18 +09006652 ensureRealfileExists(t, files, "javalib/myjar.jar")
6653 ensureRealfileExists(t, files, "lib64/mylib.so")
6654 ensureRealfileExists(t, files, "lib64/myotherlib.so")
6655
Jiyong Park9d677202020-02-19 16:29:35 +09006656 files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
6657 ensureRealfileExists(t, files, "javalib/myjar.jar")
6658 ensureRealfileExists(t, files, "lib64/mylib.so")
6659 ensureRealfileExists(t, files, "lib64/myotherlib.so")
6660
6661 // For bundled build, symlink to the system for the non-updatable APEXes only
Colin Cross1c460562021-02-16 17:55:47 -08006662 ctx = testApex(t, bp)
Jooyung Hana57af4a2020-01-23 05:36:59 +00006663 files = getFiles(t, ctx, "myapex", "android_common_myapex_image")
Jiyong Park7cd10e32020-01-14 09:22:18 +09006664 ensureRealfileExists(t, files, "javalib/myjar.jar")
6665 ensureRealfileExists(t, files, "lib64/mylib.so")
6666 ensureSymlinkExists(t, files, "lib64/myotherlib.so") // this is symlink
Jiyong Park9d677202020-02-19 16:29:35 +09006667
6668 files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
6669 ensureRealfileExists(t, files, "javalib/myjar.jar")
6670 ensureRealfileExists(t, files, "lib64/mylib.so")
6671 ensureRealfileExists(t, files, "lib64/myotherlib.so") // this is a real file
Jiyong Park7cd10e32020-01-14 09:22:18 +09006672}
6673
Yo Chiange8128052020-07-23 20:09:18 +08006674func TestSymlinksFromApexToSystemRequiredModuleNames(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006675 ctx := testApex(t, `
Yo Chiange8128052020-07-23 20:09:18 +08006676 apex {
6677 name: "myapex",
6678 key: "myapex.key",
6679 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006680 updatable: false,
Yo Chiange8128052020-07-23 20:09:18 +08006681 }
6682
6683 apex_key {
6684 name: "myapex.key",
6685 public_key: "testkey.avbpubkey",
6686 private_key: "testkey.pem",
6687 }
6688
6689 cc_library_shared {
6690 name: "mylib",
6691 srcs: ["mylib.cpp"],
6692 shared_libs: ["myotherlib"],
6693 system_shared_libs: [],
6694 stl: "none",
6695 apex_available: [
6696 "myapex",
6697 "//apex_available:platform",
6698 ],
6699 }
6700
6701 cc_prebuilt_library_shared {
6702 name: "myotherlib",
6703 srcs: ["prebuilt.so"],
6704 system_shared_libs: [],
6705 stl: "none",
6706 apex_available: [
6707 "myapex",
6708 "//apex_available:platform",
6709 ],
6710 }
6711 `)
6712
6713 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07006714 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Yo Chiange8128052020-07-23 20:09:18 +08006715 var builder strings.Builder
6716 data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
6717 androidMk := builder.String()
6718 // `myotherlib` is added to `myapex` as symlink
6719 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
6720 ensureNotContains(t, androidMk, "LOCAL_MODULE := prebuilt_myotherlib.myapex\n")
6721 ensureNotContains(t, androidMk, "LOCAL_MODULE := myotherlib.myapex\n")
6722 // `myapex` should have `myotherlib` in its required line, not `prebuilt_myotherlib`
Jiyong Park57621b22021-01-20 20:33:11 +09006723 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += mylib.myapex:64 myotherlib:64 apex_manifest.pb.myapex apex_pubkey.myapex\n")
Yo Chiange8128052020-07-23 20:09:18 +08006724}
6725
Jooyung Han643adc42020-02-27 13:50:06 +09006726func TestApexWithJniLibs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006727 ctx := testApex(t, `
Jooyung Han643adc42020-02-27 13:50:06 +09006728 apex {
6729 name: "myapex",
6730 key: "myapex.key",
6731 jni_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006732 updatable: false,
Jooyung Han643adc42020-02-27 13:50:06 +09006733 }
6734
6735 apex_key {
6736 name: "myapex.key",
6737 public_key: "testkey.avbpubkey",
6738 private_key: "testkey.pem",
6739 }
6740
6741 cc_library {
6742 name: "mylib",
6743 srcs: ["mylib.cpp"],
6744 shared_libs: ["mylib2"],
6745 system_shared_libs: [],
6746 stl: "none",
6747 apex_available: [ "myapex" ],
6748 }
6749
6750 cc_library {
6751 name: "mylib2",
6752 srcs: ["mylib.cpp"],
6753 system_shared_libs: [],
6754 stl: "none",
6755 apex_available: [ "myapex" ],
6756 }
6757 `)
6758
6759 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
6760 // Notice mylib2.so (transitive dep) is not added as a jni_lib
6761 ensureEquals(t, rule.Args["opt"], "-a jniLibs mylib.so")
6762 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
6763 "lib64/mylib.so",
6764 "lib64/mylib2.so",
6765 })
6766}
6767
Jooyung Han49f67012020-04-17 13:43:10 +09006768func TestApexMutatorsDontRunIfDisabled(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006769 ctx := testApex(t, `
Jooyung Han49f67012020-04-17 13:43:10 +09006770 apex {
6771 name: "myapex",
6772 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006773 updatable: false,
Jooyung Han49f67012020-04-17 13:43:10 +09006774 }
6775 apex_key {
6776 name: "myapex.key",
6777 public_key: "testkey.avbpubkey",
6778 private_key: "testkey.pem",
6779 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00006780 `,
6781 android.FixtureModifyConfig(func(config android.Config) {
6782 delete(config.Targets, android.Android)
6783 config.AndroidCommonTarget = android.Target{}
6784 }),
6785 )
Jooyung Han49f67012020-04-17 13:43:10 +09006786
6787 if expected, got := []string{""}, ctx.ModuleVariantsForTests("myapex"); !reflect.DeepEqual(expected, got) {
6788 t.Errorf("Expected variants: %v, but got: %v", expected, got)
6789 }
6790}
6791
Jiyong Parkbd159612020-02-28 15:22:21 +09006792func TestAppBundle(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006793 ctx := testApex(t, `
Jiyong Parkbd159612020-02-28 15:22:21 +09006794 apex {
6795 name: "myapex",
6796 key: "myapex.key",
6797 apps: ["AppFoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006798 updatable: false,
Jiyong Parkbd159612020-02-28 15:22:21 +09006799 }
6800
6801 apex_key {
6802 name: "myapex.key",
6803 public_key: "testkey.avbpubkey",
6804 private_key: "testkey.pem",
6805 }
6806
6807 android_app {
6808 name: "AppFoo",
6809 srcs: ["foo/bar/MyClass.java"],
6810 sdk_version: "none",
6811 system_modules: "none",
6812 apex_available: [ "myapex" ],
6813 }
Jiyong Parkcfaa1642020-02-28 16:51:07 +09006814 `, withManifestPackageNameOverrides([]string{"AppFoo:com.android.foo"}))
Jiyong Parkbd159612020-02-28 15:22:21 +09006815
Colin Crosscf371cc2020-11-13 11:48:42 -08006816 bundleConfigRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("bundle_config.json")
Jiyong Parkbd159612020-02-28 15:22:21 +09006817 content := bundleConfigRule.Args["content"]
6818
6819 ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
Jiyong Parkcfaa1642020-02-28 16:51:07 +09006820 ensureContains(t, content, `"apex_config":{"apex_embedded_apk_config":[{"package_name":"com.android.foo","path":"app/AppFoo/AppFoo.apk"}]}`)
Jiyong Parkbd159612020-02-28 15:22:21 +09006821}
6822
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006823func TestAppSetBundle(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006824 ctx := testApex(t, `
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006825 apex {
6826 name: "myapex",
6827 key: "myapex.key",
6828 apps: ["AppSet"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006829 updatable: false,
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006830 }
6831
6832 apex_key {
6833 name: "myapex.key",
6834 public_key: "testkey.avbpubkey",
6835 private_key: "testkey.pem",
6836 }
6837
6838 android_app_set {
6839 name: "AppSet",
6840 set: "AppSet.apks",
6841 }`)
6842 mod := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Colin Crosscf371cc2020-11-13 11:48:42 -08006843 bundleConfigRule := mod.Output("bundle_config.json")
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006844 content := bundleConfigRule.Args["content"]
6845 ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
6846 s := mod.Rule("apexRule").Args["copy_commands"]
6847 copyCmds := regexp.MustCompile(" *&& *").Split(s, -1)
6848 if len(copyCmds) != 3 {
6849 t.Fatalf("Expected 3 commands, got %d in:\n%s", len(copyCmds), s)
6850 }
6851 ensureMatches(t, copyCmds[0], "^rm -rf .*/app/AppSet$")
6852 ensureMatches(t, copyCmds[1], "^mkdir -p .*/app/AppSet$")
6853 ensureMatches(t, copyCmds[2], "^unzip .*-d .*/app/AppSet .*/AppSet.zip$")
6854}
6855
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006856func TestAppSetBundlePrebuilt(t *testing.T) {
Paul Duffin24704672021-04-06 16:09:30 +01006857 bp := `
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006858 apex_set {
6859 name: "myapex",
6860 filename: "foo_v2.apex",
6861 sanitized: {
6862 none: { set: "myapex.apks", },
6863 hwaddress: { set: "myapex.hwasan.apks", },
6864 },
Paul Duffin24704672021-04-06 16:09:30 +01006865 }
6866 `
6867 ctx := testApex(t, bp, prepareForTestWithSantitizeHwaddress)
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006868
Paul Duffin24704672021-04-06 16:09:30 +01006869 // Check that the extractor produces the correct output file from the correct input file.
6870 extractorOutput := "out/soong/.intermediates/myapex.apex.extractor/android_common/extracted/myapex.hwasan.apks"
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006871
Paul Duffin24704672021-04-06 16:09:30 +01006872 m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
6873 extractedApex := m.Output(extractorOutput)
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006874
Paul Duffin24704672021-04-06 16:09:30 +01006875 android.AssertArrayString(t, "extractor input", []string{"myapex.hwasan.apks"}, extractedApex.Inputs.Strings())
6876
6877 // Ditto for the apex.
Paul Duffin6717d882021-06-15 19:09:41 +01006878 m = ctx.ModuleForTests("myapex", "android_common_myapex")
6879 copiedApex := m.Output("out/soong/.intermediates/myapex/android_common_myapex/foo_v2.apex")
Paul Duffin24704672021-04-06 16:09:30 +01006880
6881 android.AssertStringEquals(t, "myapex input", extractorOutput, copiedApex.Input.String())
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006882}
6883
Paul Duffin89f570a2021-06-16 01:42:33 +01006884func testNoUpdatableJarsInBootImage(t *testing.T, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) {
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006885 t.Helper()
6886
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006887 bp := `
6888 java_library {
6889 name: "some-updatable-apex-lib",
6890 srcs: ["a.java"],
6891 sdk_version: "current",
6892 apex_available: [
6893 "some-updatable-apex",
6894 ],
satayevabcd5972021-08-06 17:49:46 +01006895 permitted_packages: ["some.updatable.apex.lib"],
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006896 }
6897
6898 java_library {
6899 name: "some-non-updatable-apex-lib",
6900 srcs: ["a.java"],
6901 apex_available: [
6902 "some-non-updatable-apex",
6903 ],
Paul Duffin89f570a2021-06-16 01:42:33 +01006904 compile_dex: true,
satayevabcd5972021-08-06 17:49:46 +01006905 permitted_packages: ["some.non.updatable.apex.lib"],
Paul Duffin89f570a2021-06-16 01:42:33 +01006906 }
6907
6908 bootclasspath_fragment {
6909 name: "some-non-updatable-fragment",
6910 contents: ["some-non-updatable-apex-lib"],
6911 apex_available: [
6912 "some-non-updatable-apex",
6913 ],
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006914 }
6915
6916 java_library {
6917 name: "some-platform-lib",
6918 srcs: ["a.java"],
6919 sdk_version: "current",
6920 installable: true,
6921 }
6922
6923 java_library {
6924 name: "some-art-lib",
6925 srcs: ["a.java"],
6926 sdk_version: "current",
6927 apex_available: [
Paul Duffind376f792021-01-26 11:59:35 +00006928 "com.android.art.debug",
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006929 ],
6930 hostdex: true,
Paul Duffine5218812021-06-07 13:28:19 +01006931 compile_dex: true,
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006932 }
6933
6934 apex {
6935 name: "some-updatable-apex",
6936 key: "some-updatable-apex.key",
6937 java_libs: ["some-updatable-apex-lib"],
6938 updatable: true,
6939 min_sdk_version: "current",
6940 }
6941
6942 apex {
6943 name: "some-non-updatable-apex",
6944 key: "some-non-updatable-apex.key",
Paul Duffin89f570a2021-06-16 01:42:33 +01006945 bootclasspath_fragments: ["some-non-updatable-fragment"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006946 updatable: false,
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006947 }
6948
6949 apex_key {
6950 name: "some-updatable-apex.key",
6951 }
6952
6953 apex_key {
6954 name: "some-non-updatable-apex.key",
6955 }
6956
6957 apex {
Paul Duffind376f792021-01-26 11:59:35 +00006958 name: "com.android.art.debug",
6959 key: "com.android.art.debug.key",
Paul Duffin89f570a2021-06-16 01:42:33 +01006960 bootclasspath_fragments: ["art-bootclasspath-fragment"],
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006961 updatable: true,
6962 min_sdk_version: "current",
6963 }
6964
Paul Duffinf23bc472021-04-27 12:42:20 +01006965 bootclasspath_fragment {
6966 name: "art-bootclasspath-fragment",
6967 image_name: "art",
6968 contents: ["some-art-lib"],
6969 apex_available: [
6970 "com.android.art.debug",
6971 ],
6972 }
6973
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006974 apex_key {
Paul Duffind376f792021-01-26 11:59:35 +00006975 name: "com.android.art.debug.key",
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006976 }
6977
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006978 filegroup {
6979 name: "some-updatable-apex-file_contexts",
6980 srcs: [
6981 "system/sepolicy/apex/some-updatable-apex-file_contexts",
6982 ],
6983 }
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01006984
6985 filegroup {
6986 name: "some-non-updatable-apex-file_contexts",
6987 srcs: [
6988 "system/sepolicy/apex/some-non-updatable-apex-file_contexts",
6989 ],
6990 }
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006991 `
Paul Duffinc3bbb962020-12-10 19:15:49 +00006992
Paul Duffin89f570a2021-06-16 01:42:33 +01006993 testDexpreoptWithApexes(t, bp, errmsg, preparer, fragments...)
Paul Duffinc3bbb962020-12-10 19:15:49 +00006994}
6995
Paul Duffin89f570a2021-06-16 01:42:33 +01006996func testDexpreoptWithApexes(t *testing.T, bp, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) *android.TestContext {
Paul Duffinc3bbb962020-12-10 19:15:49 +00006997 t.Helper()
6998
Paul Duffin55607122021-03-30 23:32:51 +01006999 fs := android.MockFS{
7000 "a.java": nil,
7001 "a.jar": nil,
7002 "apex_manifest.json": nil,
7003 "AndroidManifest.xml": nil,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00007004 "system/sepolicy/apex/myapex-file_contexts": nil,
Paul Duffind376f792021-01-26 11:59:35 +00007005 "system/sepolicy/apex/some-updatable-apex-file_contexts": nil,
7006 "system/sepolicy/apex/some-non-updatable-apex-file_contexts": nil,
7007 "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00007008 "framework/aidl/a.aidl": nil,
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00007009 }
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00007010
Paul Duffin55607122021-03-30 23:32:51 +01007011 errorHandler := android.FixtureExpectsNoErrors
7012 if errmsg != "" {
7013 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00007014 }
Paul Duffin064b70c2020-11-02 17:32:38 +00007015
Paul Duffin55607122021-03-30 23:32:51 +01007016 result := android.GroupFixturePreparers(
7017 cc.PrepareForTestWithCcDefaultModules,
7018 java.PrepareForTestWithHiddenApiBuildComponents,
7019 java.PrepareForTestWithJavaDefaultModules,
7020 java.PrepareForTestWithJavaSdkLibraryFiles,
7021 PrepareForTestWithApexBuildComponents,
Paul Duffin60264a02021-04-12 20:02:36 +01007022 preparer,
Paul Duffin55607122021-03-30 23:32:51 +01007023 fs.AddToFixture(),
Paul Duffin89f570a2021-06-16 01:42:33 +01007024 android.FixtureModifyMockFS(func(fs android.MockFS) {
7025 if _, ok := fs["frameworks/base/boot/Android.bp"]; !ok {
7026 insert := ""
7027 for _, fragment := range fragments {
7028 insert += fmt.Sprintf("{apex: %q, module: %q},\n", *fragment.Apex, *fragment.Module)
7029 }
7030 fs["frameworks/base/boot/Android.bp"] = []byte(fmt.Sprintf(`
7031 platform_bootclasspath {
7032 name: "platform-bootclasspath",
7033 fragments: [
7034 %s
7035 ],
7036 }
7037 `, insert))
Paul Duffin8f146b92021-04-12 17:24:18 +01007038 }
Paul Duffin89f570a2021-06-16 01:42:33 +01007039 }),
Jiakai Zhang49b1eb62021-11-26 18:09:27 +00007040 dexpreopt.FixtureSetBootImageProfiles("art/build/boot/boot-image-profile.txt"),
Paul Duffin55607122021-03-30 23:32:51 +01007041 ).
7042 ExtendWithErrorHandler(errorHandler).
7043 RunTestWithBp(t, bp)
7044
7045 return result.TestContext
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00007046}
7047
Jooyung Han548640b2020-04-27 12:10:30 +09007048func TestUpdatable_should_set_min_sdk_version(t *testing.T) {
7049 testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
7050 apex {
7051 name: "myapex",
7052 key: "myapex.key",
7053 updatable: true,
7054 }
7055
7056 apex_key {
7057 name: "myapex.key",
7058 public_key: "testkey.avbpubkey",
7059 private_key: "testkey.pem",
7060 }
7061 `)
7062}
7063
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007064func TestUpdatableDefault_should_set_min_sdk_version(t *testing.T) {
7065 testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
7066 apex {
7067 name: "myapex",
7068 key: "myapex.key",
7069 }
7070
7071 apex_key {
7072 name: "myapex.key",
7073 public_key: "testkey.avbpubkey",
7074 private_key: "testkey.pem",
7075 }
7076 `)
7077}
7078
Daniel Norman69109112021-12-02 12:52:42 -08007079func TestUpdatable_cannot_be_vendor_apex(t *testing.T) {
7080 testApexError(t, `"myapex" .*: updatable: vendor APEXes are not updatable`, `
7081 apex {
7082 name: "myapex",
7083 key: "myapex.key",
7084 updatable: true,
7085 soc_specific: true,
7086 }
7087
7088 apex_key {
7089 name: "myapex.key",
7090 public_key: "testkey.avbpubkey",
7091 private_key: "testkey.pem",
7092 }
7093 `)
7094}
7095
satayevb98371c2021-06-15 16:49:50 +01007096func TestUpdatable_should_not_set_generate_classpaths_proto(t *testing.T) {
7097 testApexError(t, `"mysystemserverclasspathfragment" .* it must not set generate_classpaths_proto to false`, `
7098 apex {
7099 name: "myapex",
7100 key: "myapex.key",
7101 systemserverclasspath_fragments: [
7102 "mysystemserverclasspathfragment",
7103 ],
7104 min_sdk_version: "29",
7105 updatable: true,
7106 }
7107
7108 apex_key {
7109 name: "myapex.key",
7110 public_key: "testkey.avbpubkey",
7111 private_key: "testkey.pem",
7112 }
7113
7114 java_library {
7115 name: "foo",
7116 srcs: ["b.java"],
7117 min_sdk_version: "29",
7118 installable: true,
7119 apex_available: [
7120 "myapex",
7121 ],
7122 }
7123
7124 systemserverclasspath_fragment {
7125 name: "mysystemserverclasspathfragment",
7126 generate_classpaths_proto: false,
7127 contents: [
7128 "foo",
7129 ],
7130 apex_available: [
7131 "myapex",
7132 ],
7133 }
satayevabcd5972021-08-06 17:49:46 +01007134 `,
7135 dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"),
7136 )
satayevb98371c2021-06-15 16:49:50 +01007137}
7138
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00007139func TestNoUpdatableJarsInBootImage(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01007140 // Set the BootJars in dexpreopt.GlobalConfig and productVariables to the same value. This can
7141 // result in an invalid configuration as it does not set the ArtApexJars and allows art apex
7142 // modules to be included in the BootJars.
7143 prepareSetBootJars := func(bootJars ...string) android.FixturePreparer {
7144 return android.GroupFixturePreparers(
7145 dexpreopt.FixtureSetBootJars(bootJars...),
7146 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
7147 variables.BootJars = android.CreateTestConfiguredJarList(bootJars)
7148 }),
7149 )
7150 }
7151
7152 // Set the ArtApexJars and BootJars in dexpreopt.GlobalConfig and productVariables all to the
7153 // same value. This can result in an invalid configuration as it allows non art apex jars to be
7154 // specified in the ArtApexJars configuration.
7155 prepareSetArtJars := func(bootJars ...string) android.FixturePreparer {
7156 return android.GroupFixturePreparers(
7157 dexpreopt.FixtureSetArtBootJars(bootJars...),
7158 dexpreopt.FixtureSetBootJars(bootJars...),
7159 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
7160 variables.BootJars = android.CreateTestConfiguredJarList(bootJars)
7161 }),
7162 )
7163 }
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00007164
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007165 t.Run("updatable jar from ART apex in the ART boot image => ok", func(t *testing.T) {
satayevabcd5972021-08-06 17:49:46 +01007166 preparer := android.GroupFixturePreparers(
7167 java.FixtureConfigureBootJars("com.android.art.debug:some-art-lib"),
7168 java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
7169 )
7170 fragments := []java.ApexVariantReference{
7171 {
7172 Apex: proptools.StringPtr("com.android.art.debug"),
7173 Module: proptools.StringPtr("art-bootclasspath-fragment"),
7174 },
7175 {
7176 Apex: proptools.StringPtr("some-non-updatable-apex"),
7177 Module: proptools.StringPtr("some-non-updatable-fragment"),
7178 },
Paul Duffin89f570a2021-06-16 01:42:33 +01007179 }
satayevabcd5972021-08-06 17:49:46 +01007180 testNoUpdatableJarsInBootImage(t, "", preparer, fragments...)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007181 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00007182
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007183 t.Run("updatable jar from ART apex in the framework boot image => error", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01007184 err := `module "some-art-lib" from updatable apexes \["com.android.art.debug"\] is not allowed in the framework boot image`
7185 // Update the dexpreopt BootJars directly.
satayevabcd5972021-08-06 17:49:46 +01007186 preparer := android.GroupFixturePreparers(
7187 prepareSetBootJars("com.android.art.debug:some-art-lib"),
7188 java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
7189 )
Paul Duffin60264a02021-04-12 20:02:36 +01007190 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007191 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00007192
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007193 t.Run("updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
Paul Duffinf23bc472021-04-27 12:42:20 +01007194 err := `ArtApexJars expects this to be in apex "some-updatable-apex" but this is only in apexes.*"com.android.art.debug"`
Paul Duffin60264a02021-04-12 20:02:36 +01007195 // Update the dexpreopt ArtApexJars directly.
7196 preparer := prepareSetArtJars("some-updatable-apex:some-updatable-apex-lib")
7197 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007198 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00007199
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007200 t.Run("non-updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
Paul Duffinf23bc472021-04-27 12:42:20 +01007201 err := `ArtApexJars expects this to be in apex "some-non-updatable-apex" but this is only in apexes.*"com.android.art.debug"`
Paul Duffin60264a02021-04-12 20:02:36 +01007202 // Update the dexpreopt ArtApexJars directly.
7203 preparer := prepareSetArtJars("some-non-updatable-apex:some-non-updatable-apex-lib")
7204 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007205 })
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01007206
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007207 t.Run("updatable jar from some other apex in the framework boot image => error", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01007208 err := `module "some-updatable-apex-lib" from updatable apexes \["some-updatable-apex"\] is not allowed in the framework boot image`
satayevabcd5972021-08-06 17:49:46 +01007209 preparer := android.GroupFixturePreparers(
7210 java.FixtureConfigureBootJars("some-updatable-apex:some-updatable-apex-lib"),
7211 java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
7212 )
Paul Duffin60264a02021-04-12 20:02:36 +01007213 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007214 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00007215
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007216 t.Run("non-updatable jar from some other apex in the framework boot image => ok", func(t *testing.T) {
satayevabcd5972021-08-06 17:49:46 +01007217 preparer := java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib")
Paul Duffin89f570a2021-06-16 01:42:33 +01007218 fragment := java.ApexVariantReference{
7219 Apex: proptools.StringPtr("some-non-updatable-apex"),
7220 Module: proptools.StringPtr("some-non-updatable-fragment"),
7221 }
7222 testNoUpdatableJarsInBootImage(t, "", preparer, fragment)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007223 })
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01007224
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007225 t.Run("nonexistent jar in the ART boot image => error", func(t *testing.T) {
Paul Duffin8f146b92021-04-12 17:24:18 +01007226 err := `"platform-bootclasspath" depends on undefined module "nonexistent"`
Paul Duffin60264a02021-04-12 20:02:36 +01007227 preparer := java.FixtureConfigureBootJars("platform:nonexistent")
7228 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007229 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00007230
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007231 t.Run("nonexistent jar in the framework boot image => error", func(t *testing.T) {
Paul Duffin8f146b92021-04-12 17:24:18 +01007232 err := `"platform-bootclasspath" depends on undefined module "nonexistent"`
Paul Duffin60264a02021-04-12 20:02:36 +01007233 preparer := java.FixtureConfigureBootJars("platform:nonexistent")
7234 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007235 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00007236
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007237 t.Run("platform jar in the ART boot image => error", func(t *testing.T) {
Paul Duffinf23bc472021-04-27 12:42:20 +01007238 err := `ArtApexJars is invalid as it requests a platform variant of "some-platform-lib"`
Paul Duffin60264a02021-04-12 20:02:36 +01007239 // Update the dexpreopt ArtApexJars directly.
7240 preparer := prepareSetArtJars("platform:some-platform-lib")
7241 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007242 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00007243
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007244 t.Run("platform jar in the framework boot image => ok", func(t *testing.T) {
satayevabcd5972021-08-06 17:49:46 +01007245 preparer := android.GroupFixturePreparers(
7246 java.FixtureConfigureBootJars("platform:some-platform-lib"),
7247 java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
7248 )
7249 fragments := []java.ApexVariantReference{
7250 {
7251 Apex: proptools.StringPtr("some-non-updatable-apex"),
7252 Module: proptools.StringPtr("some-non-updatable-fragment"),
7253 },
7254 }
7255 testNoUpdatableJarsInBootImage(t, "", preparer, fragments...)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01007256 })
Paul Duffin064b70c2020-11-02 17:32:38 +00007257}
7258
7259func TestDexpreoptAccessDexFilesFromPrebuiltApex(t *testing.T) {
satayevabcd5972021-08-06 17:49:46 +01007260 preparer := java.FixtureConfigureApexBootJars("myapex:libfoo")
Paul Duffin064b70c2020-11-02 17:32:38 +00007261 t.Run("prebuilt no source", func(t *testing.T) {
Paul Duffin89f570a2021-06-16 01:42:33 +01007262 fragment := java.ApexVariantReference{
7263 Apex: proptools.StringPtr("myapex"),
7264 Module: proptools.StringPtr("my-bootclasspath-fragment"),
7265 }
7266
Paul Duffin064b70c2020-11-02 17:32:38 +00007267 testDexpreoptWithApexes(t, `
7268 prebuilt_apex {
7269 name: "myapex" ,
7270 arch: {
7271 arm64: {
7272 src: "myapex-arm64.apex",
7273 },
7274 arm: {
7275 src: "myapex-arm.apex",
7276 },
7277 },
Paul Duffin89f570a2021-06-16 01:42:33 +01007278 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
7279 }
Paul Duffin064b70c2020-11-02 17:32:38 +00007280
Paul Duffin89f570a2021-06-16 01:42:33 +01007281 prebuilt_bootclasspath_fragment {
7282 name: "my-bootclasspath-fragment",
7283 contents: ["libfoo"],
7284 apex_available: ["myapex"],
Paul Duffin54e41972021-07-19 13:23:40 +01007285 hidden_api: {
7286 annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
7287 metadata: "my-bootclasspath-fragment/metadata.csv",
7288 index: "my-bootclasspath-fragment/index.csv",
Paul Duffin191be3a2021-08-10 16:14:16 +01007289 signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
7290 filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
7291 filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
Paul Duffin54e41972021-07-19 13:23:40 +01007292 },
Paul Duffin89f570a2021-06-16 01:42:33 +01007293 }
Paul Duffin064b70c2020-11-02 17:32:38 +00007294
Paul Duffin89f570a2021-06-16 01:42:33 +01007295 java_import {
7296 name: "libfoo",
7297 jars: ["libfoo.jar"],
7298 apex_available: ["myapex"],
satayevabcd5972021-08-06 17:49:46 +01007299 permitted_packages: ["libfoo"],
Paul Duffin89f570a2021-06-16 01:42:33 +01007300 }
7301 `, "", preparer, fragment)
Paul Duffin064b70c2020-11-02 17:32:38 +00007302 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00007303}
7304
satayevd604b212021-07-21 14:23:52 +01007305func testApexPermittedPackagesRules(t *testing.T, errmsg, bp string, bootJars []string, rules []android.Rule) {
Andrei Onea115e7e72020-06-05 21:14:03 +01007306 t.Helper()
Andrei Onea115e7e72020-06-05 21:14:03 +01007307 bp += `
7308 apex_key {
7309 name: "myapex.key",
7310 public_key: "testkey.avbpubkey",
7311 private_key: "testkey.pem",
7312 }`
Paul Duffin45338f02021-03-30 23:07:52 +01007313 fs := android.MockFS{
Andrei Onea115e7e72020-06-05 21:14:03 +01007314 "lib1/src/A.java": nil,
7315 "lib2/src/B.java": nil,
7316 "system/sepolicy/apex/myapex-file_contexts": nil,
7317 }
7318
Paul Duffin45338f02021-03-30 23:07:52 +01007319 errorHandler := android.FixtureExpectsNoErrors
7320 if errmsg != "" {
7321 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
Colin Crossae8600b2020-10-29 17:09:13 -07007322 }
Colin Crossae8600b2020-10-29 17:09:13 -07007323
Paul Duffin45338f02021-03-30 23:07:52 +01007324 android.GroupFixturePreparers(
7325 android.PrepareForTestWithAndroidBuildComponents,
7326 java.PrepareForTestWithJavaBuildComponents,
7327 PrepareForTestWithApexBuildComponents,
7328 android.PrepareForTestWithNeverallowRules(rules),
7329 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
satayevd604b212021-07-21 14:23:52 +01007330 apexBootJars := make([]string, 0, len(bootJars))
7331 for _, apexBootJar := range bootJars {
7332 apexBootJars = append(apexBootJars, "myapex:"+apexBootJar)
Paul Duffin45338f02021-03-30 23:07:52 +01007333 }
satayevd604b212021-07-21 14:23:52 +01007334 variables.ApexBootJars = android.CreateTestConfiguredJarList(apexBootJars)
Paul Duffin45338f02021-03-30 23:07:52 +01007335 }),
7336 fs.AddToFixture(),
7337 ).
7338 ExtendWithErrorHandler(errorHandler).
7339 RunTestWithBp(t, bp)
Andrei Onea115e7e72020-06-05 21:14:03 +01007340}
7341
7342func TestApexPermittedPackagesRules(t *testing.T) {
7343 testcases := []struct {
7344 name string
7345 expectedError string
7346 bp string
7347 bootJars []string
7348 modulesPackages map[string][]string
7349 }{
7350
7351 {
7352 name: "Non-Bootclasspath apex jar not satisfying allowed module packages.",
7353 expectedError: "",
7354 bp: `
7355 java_library {
7356 name: "bcp_lib1",
7357 srcs: ["lib1/src/*.java"],
7358 permitted_packages: ["foo.bar"],
7359 apex_available: ["myapex"],
7360 sdk_version: "none",
7361 system_modules: "none",
Remi NGUYEN VAN1fdd6ca2021-12-02 19:39:35 +09007362 min_sdk_version: "30",
Andrei Onea115e7e72020-06-05 21:14:03 +01007363 }
7364 java_library {
7365 name: "nonbcp_lib2",
7366 srcs: ["lib2/src/*.java"],
7367 apex_available: ["myapex"],
7368 permitted_packages: ["a.b"],
7369 sdk_version: "none",
7370 system_modules: "none",
Remi NGUYEN VAN1fdd6ca2021-12-02 19:39:35 +09007371 min_sdk_version: "30",
Andrei Onea115e7e72020-06-05 21:14:03 +01007372 }
7373 apex {
7374 name: "myapex",
Remi NGUYEN VAN1fdd6ca2021-12-02 19:39:35 +09007375 min_sdk_version: "30",
Andrei Onea115e7e72020-06-05 21:14:03 +01007376 key: "myapex.key",
7377 java_libs: ["bcp_lib1", "nonbcp_lib2"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007378 updatable: false,
Andrei Onea115e7e72020-06-05 21:14:03 +01007379 }`,
7380 bootJars: []string{"bcp_lib1"},
7381 modulesPackages: map[string][]string{
7382 "myapex": []string{
7383 "foo.bar",
7384 },
7385 },
7386 },
7387 {
Remi NGUYEN VAN1fdd6ca2021-12-02 19:39:35 +09007388 name: "Bootclasspath apex jar not satisfying allowed module packages on Q.",
7389 expectedError: `module "bcp_lib2" .* which is restricted because jars that are part of the myapex module may only allow these packages: foo.bar with min_sdk < T. Please jarjar or move code around.`,
Andrei Onea115e7e72020-06-05 21:14:03 +01007390 bp: `
7391 java_library {
7392 name: "bcp_lib1",
7393 srcs: ["lib1/src/*.java"],
7394 apex_available: ["myapex"],
7395 permitted_packages: ["foo.bar"],
7396 sdk_version: "none",
7397 system_modules: "none",
Remi NGUYEN VAN1fdd6ca2021-12-02 19:39:35 +09007398 min_sdk_version: "29",
Andrei Onea115e7e72020-06-05 21:14:03 +01007399 }
7400 java_library {
7401 name: "bcp_lib2",
7402 srcs: ["lib2/src/*.java"],
7403 apex_available: ["myapex"],
7404 permitted_packages: ["foo.bar", "bar.baz"],
7405 sdk_version: "none",
7406 system_modules: "none",
Remi NGUYEN VAN1fdd6ca2021-12-02 19:39:35 +09007407 min_sdk_version: "29",
Andrei Onea115e7e72020-06-05 21:14:03 +01007408 }
7409 apex {
7410 name: "myapex",
Remi NGUYEN VAN1fdd6ca2021-12-02 19:39:35 +09007411 min_sdk_version: "29",
7412 key: "myapex.key",
7413 java_libs: ["bcp_lib1", "bcp_lib2"],
7414 updatable: false,
7415 }
7416 `,
7417 bootJars: []string{"bcp_lib1", "bcp_lib2"},
7418 modulesPackages: map[string][]string{
7419 "myapex": []string{
7420 "foo.bar",
7421 },
7422 },
7423 },
7424 {
7425 name: "Bootclasspath apex jar not satisfying allowed module packages on R.",
7426 expectedError: `module "bcp_lib2" .* which is restricted because jars that are part of the myapex module may only allow these packages: foo.bar with min_sdk < T. Please jarjar or move code around.`,
7427 bp: `
7428 java_library {
7429 name: "bcp_lib1",
7430 srcs: ["lib1/src/*.java"],
7431 apex_available: ["myapex"],
7432 permitted_packages: ["foo.bar"],
7433 sdk_version: "none",
7434 system_modules: "none",
7435 min_sdk_version: "30",
7436 }
7437 java_library {
7438 name: "bcp_lib2",
7439 srcs: ["lib2/src/*.java"],
7440 apex_available: ["myapex"],
7441 permitted_packages: ["foo.bar", "bar.baz"],
7442 sdk_version: "none",
7443 system_modules: "none",
7444 min_sdk_version: "30",
7445 }
7446 apex {
7447 name: "myapex",
7448 min_sdk_version: "30",
7449 key: "myapex.key",
7450 java_libs: ["bcp_lib1", "bcp_lib2"],
7451 updatable: false,
7452 }
7453 `,
7454 bootJars: []string{"bcp_lib1", "bcp_lib2"},
7455 modulesPackages: map[string][]string{
7456 "myapex": []string{
7457 "foo.bar",
7458 },
7459 },
7460 },
7461 {
7462 name: "Bootclasspath apex jar >= T not satisfying Q/R/S allowed module packages.",
7463 expectedError: "",
7464 bp: `
7465 java_library {
7466 name: "bcp_lib1",
7467 srcs: ["lib1/src/*.java"],
7468 apex_available: ["myapex"],
7469 permitted_packages: ["foo.bar"],
7470 sdk_version: "none",
7471 system_modules: "none",
7472 min_sdk_version: "current",
7473 }
7474 java_library {
7475 name: "bcp_lib2",
7476 srcs: ["lib2/src/*.java"],
7477 apex_available: ["myapex"],
7478 permitted_packages: ["foo.bar", "bar.baz"],
7479 sdk_version: "none",
7480 system_modules: "none",
7481 min_sdk_version: "current",
7482 }
7483 apex {
7484 name: "myapex",
7485 min_sdk_version: "current",
Andrei Onea115e7e72020-06-05 21:14:03 +01007486 key: "myapex.key",
7487 java_libs: ["bcp_lib1", "bcp_lib2"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007488 updatable: false,
Andrei Onea115e7e72020-06-05 21:14:03 +01007489 }
7490 `,
7491 bootJars: []string{"bcp_lib1", "bcp_lib2"},
7492 modulesPackages: map[string][]string{
7493 "myapex": []string{
7494 "foo.bar",
7495 },
7496 },
7497 },
7498 }
7499 for _, tc := range testcases {
7500 t.Run(tc.name, func(t *testing.T) {
7501 rules := createApexPermittedPackagesRules(tc.modulesPackages)
7502 testApexPermittedPackagesRules(t, tc.expectedError, tc.bp, tc.bootJars, rules)
7503 })
7504 }
7505}
7506
Jiyong Park62304bb2020-04-13 16:19:48 +09007507func TestTestFor(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007508 ctx := testApex(t, `
Jiyong Park62304bb2020-04-13 16:19:48 +09007509 apex {
7510 name: "myapex",
7511 key: "myapex.key",
7512 native_shared_libs: ["mylib", "myprivlib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007513 updatable: false,
Jiyong Park62304bb2020-04-13 16:19:48 +09007514 }
7515
7516 apex_key {
7517 name: "myapex.key",
7518 public_key: "testkey.avbpubkey",
7519 private_key: "testkey.pem",
7520 }
7521
7522 cc_library {
7523 name: "mylib",
7524 srcs: ["mylib.cpp"],
7525 system_shared_libs: [],
7526 stl: "none",
7527 stubs: {
7528 versions: ["1"],
7529 },
7530 apex_available: ["myapex"],
7531 }
7532
7533 cc_library {
7534 name: "myprivlib",
7535 srcs: ["mylib.cpp"],
7536 system_shared_libs: [],
7537 stl: "none",
7538 apex_available: ["myapex"],
7539 }
7540
7541
7542 cc_test {
7543 name: "mytest",
7544 gtest: false,
7545 srcs: ["mylib.cpp"],
7546 system_shared_libs: [],
7547 stl: "none",
Jiyong Park46a512f2020-12-04 18:02:13 +09007548 shared_libs: ["mylib", "myprivlib", "mytestlib"],
Jiyong Park62304bb2020-04-13 16:19:48 +09007549 test_for: ["myapex"]
7550 }
Jiyong Park46a512f2020-12-04 18:02:13 +09007551
7552 cc_library {
7553 name: "mytestlib",
7554 srcs: ["mylib.cpp"],
7555 system_shared_libs: [],
7556 shared_libs: ["mylib", "myprivlib"],
7557 stl: "none",
7558 test_for: ["myapex"],
7559 }
7560
7561 cc_benchmark {
7562 name: "mybench",
7563 srcs: ["mylib.cpp"],
7564 system_shared_libs: [],
7565 shared_libs: ["mylib", "myprivlib"],
7566 stl: "none",
7567 test_for: ["myapex"],
7568 }
Jiyong Park62304bb2020-04-13 16:19:48 +09007569 `)
7570
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007571 ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
Paul Duffina71a67a2021-03-29 00:42:57 +01007572 ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007573 mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
7574 android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
7575 }
7576
7577 // These modules are tests for the apex, therefore are linked to the
Jiyong Park62304bb2020-04-13 16:19:48 +09007578 // actual implementation of mylib instead of its stub.
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007579 ensureLinkedLibIs("mytest", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
7580 ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
7581 ensureLinkedLibIs("mybench", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
7582}
Jiyong Park46a512f2020-12-04 18:02:13 +09007583
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007584func TestIndirectTestFor(t *testing.T) {
7585 ctx := testApex(t, `
7586 apex {
7587 name: "myapex",
7588 key: "myapex.key",
7589 native_shared_libs: ["mylib", "myprivlib"],
7590 updatable: false,
7591 }
Jiyong Park46a512f2020-12-04 18:02:13 +09007592
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007593 apex_key {
7594 name: "myapex.key",
7595 public_key: "testkey.avbpubkey",
7596 private_key: "testkey.pem",
7597 }
7598
7599 cc_library {
7600 name: "mylib",
7601 srcs: ["mylib.cpp"],
7602 system_shared_libs: [],
7603 stl: "none",
7604 stubs: {
7605 versions: ["1"],
7606 },
7607 apex_available: ["myapex"],
7608 }
7609
7610 cc_library {
7611 name: "myprivlib",
7612 srcs: ["mylib.cpp"],
7613 system_shared_libs: [],
7614 stl: "none",
7615 shared_libs: ["mylib"],
7616 apex_available: ["myapex"],
7617 }
7618
7619 cc_library {
7620 name: "mytestlib",
7621 srcs: ["mylib.cpp"],
7622 system_shared_libs: [],
7623 shared_libs: ["myprivlib"],
7624 stl: "none",
7625 test_for: ["myapex"],
7626 }
7627 `)
7628
7629 ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
Paul Duffina71a67a2021-03-29 00:42:57 +01007630 ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007631 mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
7632 android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
7633 }
7634
7635 // The platform variant of mytestlib links to the platform variant of the
7636 // internal myprivlib.
7637 ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/myprivlib/", "android_arm64_armv8-a_shared/myprivlib.so")
7638
7639 // The platform variant of myprivlib links to the platform variant of mylib
7640 // and bypasses its stubs.
7641 ensureLinkedLibIs("myprivlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
Jiyong Park62304bb2020-04-13 16:19:48 +09007642}
7643
Martin Stjernholmec009002021-03-27 15:18:31 +00007644func TestTestForForLibInOtherApex(t *testing.T) {
7645 // This case is only allowed for known overlapping APEXes, i.e. the ART APEXes.
7646 _ = testApex(t, `
7647 apex {
7648 name: "com.android.art",
7649 key: "myapex.key",
7650 native_shared_libs: ["mylib"],
7651 updatable: false,
7652 }
7653
7654 apex {
7655 name: "com.android.art.debug",
7656 key: "myapex.key",
7657 native_shared_libs: ["mylib", "mytestlib"],
7658 updatable: false,
7659 }
7660
7661 apex_key {
7662 name: "myapex.key",
7663 public_key: "testkey.avbpubkey",
7664 private_key: "testkey.pem",
7665 }
7666
7667 cc_library {
7668 name: "mylib",
7669 srcs: ["mylib.cpp"],
7670 system_shared_libs: [],
7671 stl: "none",
7672 stubs: {
7673 versions: ["1"],
7674 },
7675 apex_available: ["com.android.art", "com.android.art.debug"],
7676 }
7677
7678 cc_library {
7679 name: "mytestlib",
7680 srcs: ["mylib.cpp"],
7681 system_shared_libs: [],
7682 shared_libs: ["mylib"],
7683 stl: "none",
7684 apex_available: ["com.android.art.debug"],
7685 test_for: ["com.android.art"],
7686 }
7687 `,
7688 android.MockFS{
7689 "system/sepolicy/apex/com.android.art-file_contexts": nil,
7690 "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
7691 }.AddToFixture())
7692}
7693
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007694// TODO(jungjw): Move this to proptools
7695func intPtr(i int) *int {
7696 return &i
7697}
7698
7699func TestApexSet(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007700 ctx := testApex(t, `
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007701 apex_set {
7702 name: "myapex",
7703 set: "myapex.apks",
7704 filename: "foo_v2.apex",
7705 overrides: ["foo"],
7706 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00007707 `,
7708 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
7709 variables.Platform_sdk_version = intPtr(30)
7710 }),
7711 android.FixtureModifyConfig(func(config android.Config) {
7712 config.Targets[android.Android] = []android.Target{
7713 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}},
7714 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}},
7715 }
7716 }),
7717 )
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007718
Paul Duffin24704672021-04-06 16:09:30 +01007719 m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007720
7721 // Check extract_apks tool parameters.
Paul Duffin24704672021-04-06 16:09:30 +01007722 extractedApex := m.Output("extracted/myapex.apks")
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007723 actual := extractedApex.Args["abis"]
7724 expected := "ARMEABI_V7A,ARM64_V8A"
7725 if actual != expected {
7726 t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
7727 }
7728 actual = extractedApex.Args["sdk-version"]
7729 expected = "30"
7730 if actual != expected {
7731 t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
7732 }
7733
Paul Duffin6717d882021-06-15 19:09:41 +01007734 m = ctx.ModuleForTests("myapex", "android_common_myapex")
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007735 a := m.Module().(*ApexSet)
7736 expectedOverrides := []string{"foo"}
Colin Crossaa255532020-07-03 13:18:24 -07007737 actualOverrides := android.AndroidMkEntriesForTest(t, ctx, a)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007738 if !reflect.DeepEqual(actualOverrides, expectedOverrides) {
7739 t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES - expected %q vs actual %q", expectedOverrides, actualOverrides)
7740 }
7741}
7742
Jiyong Park7d95a512020-05-10 15:16:24 +09007743func TestNoStaticLinkingToStubsLib(t *testing.T) {
7744 testApexError(t, `.*required by "mylib" is a native library providing stub.*`, `
7745 apex {
7746 name: "myapex",
7747 key: "myapex.key",
7748 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007749 updatable: false,
Jiyong Park7d95a512020-05-10 15:16:24 +09007750 }
7751
7752 apex_key {
7753 name: "myapex.key",
7754 public_key: "testkey.avbpubkey",
7755 private_key: "testkey.pem",
7756 }
7757
7758 cc_library {
7759 name: "mylib",
7760 srcs: ["mylib.cpp"],
7761 static_libs: ["otherlib"],
7762 system_shared_libs: [],
7763 stl: "none",
7764 apex_available: [ "myapex" ],
7765 }
7766
7767 cc_library {
7768 name: "otherlib",
7769 srcs: ["mylib.cpp"],
7770 system_shared_libs: [],
7771 stl: "none",
7772 stubs: {
7773 versions: ["1", "2", "3"],
7774 },
7775 apex_available: [ "myapex" ],
7776 }
7777 `)
7778}
7779
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007780func TestApexKeysTxt(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007781 ctx := testApex(t, `
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007782 apex {
7783 name: "myapex",
7784 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007785 updatable: false,
Jooyung Han09c11ad2021-10-27 03:45:31 +09007786 custom_sign_tool: "sign_myapex",
7787 }
7788
7789 apex_key {
7790 name: "myapex.key",
7791 public_key: "testkey.avbpubkey",
7792 private_key: "testkey.pem",
7793 }
7794 `)
7795
7796 apexKeysText := ctx.SingletonForTests("apex_keys_text")
7797 content := apexKeysText.MaybeDescription("apexkeys.txt").BuildParams.Args["content"]
7798 ensureContains(t, content, `name="myapex.apex" public_key="vendor/foo/devkeys/testkey.avbpubkey" private_key="vendor/foo/devkeys/testkey.pem" container_certificate="vendor/foo/devkeys/test.x509.pem" container_private_key="vendor/foo/devkeys/test.pk8" partition="system_ext" sign_tool="sign_myapex"`)
7799}
7800
7801func TestApexKeysTxtOverrides(t *testing.T) {
7802 ctx := testApex(t, `
7803 apex {
7804 name: "myapex",
7805 key: "myapex.key",
7806 updatable: false,
7807 custom_sign_tool: "sign_myapex",
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007808 }
7809
7810 apex_key {
7811 name: "myapex.key",
7812 public_key: "testkey.avbpubkey",
7813 private_key: "testkey.pem",
7814 }
7815
7816 prebuilt_apex {
7817 name: "myapex",
7818 prefer: true,
7819 arch: {
7820 arm64: {
7821 src: "myapex-arm64.apex",
7822 },
7823 arm: {
7824 src: "myapex-arm.apex",
7825 },
7826 },
7827 }
7828
7829 apex_set {
7830 name: "myapex_set",
7831 set: "myapex.apks",
7832 filename: "myapex_set.apex",
7833 overrides: ["myapex"],
7834 }
7835 `)
7836
7837 apexKeysText := ctx.SingletonForTests("apex_keys_text")
7838 content := apexKeysText.MaybeDescription("apexkeys.txt").BuildParams.Args["content"]
7839 ensureContains(t, content, `name="myapex_set.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
Jiyong Park03a7f3e2020-06-18 19:34:42 +09007840 ensureContains(t, content, `name="myapex.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007841}
7842
Jooyung Han938b5932020-06-20 12:47:47 +09007843func TestAllowedFiles(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007844 ctx := testApex(t, `
Jooyung Han938b5932020-06-20 12:47:47 +09007845 apex {
7846 name: "myapex",
7847 key: "myapex.key",
7848 apps: ["app"],
7849 allowed_files: "allowed.txt",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007850 updatable: false,
Jooyung Han938b5932020-06-20 12:47:47 +09007851 }
7852
7853 apex_key {
7854 name: "myapex.key",
7855 public_key: "testkey.avbpubkey",
7856 private_key: "testkey.pem",
7857 }
7858
7859 android_app {
7860 name: "app",
7861 srcs: ["foo/bar/MyClass.java"],
7862 package_name: "foo",
7863 sdk_version: "none",
7864 system_modules: "none",
7865 apex_available: [ "myapex" ],
7866 }
7867 `, withFiles(map[string][]byte{
7868 "sub/Android.bp": []byte(`
7869 override_apex {
7870 name: "override_myapex",
7871 base: "myapex",
7872 apps: ["override_app"],
7873 allowed_files: ":allowed",
7874 }
7875 // Overridable "path" property should be referenced indirectly
7876 filegroup {
7877 name: "allowed",
7878 srcs: ["allowed.txt"],
7879 }
7880 override_android_app {
7881 name: "override_app",
7882 base: "app",
7883 package_name: "bar",
7884 }
7885 `),
7886 }))
7887
7888 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("diffApexContentRule")
7889 if expected, actual := "allowed.txt", rule.Args["allowed_files_file"]; expected != actual {
7890 t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
7891 }
7892
7893 rule2 := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Rule("diffApexContentRule")
7894 if expected, actual := "sub/allowed.txt", rule2.Args["allowed_files_file"]; expected != actual {
7895 t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
7896 }
7897}
7898
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007899func TestNonPreferredPrebuiltDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007900 testApex(t, `
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007901 apex {
7902 name: "myapex",
7903 key: "myapex.key",
7904 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007905 updatable: false,
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007906 }
7907
7908 apex_key {
7909 name: "myapex.key",
7910 public_key: "testkey.avbpubkey",
7911 private_key: "testkey.pem",
7912 }
7913
7914 cc_library {
7915 name: "mylib",
7916 srcs: ["mylib.cpp"],
7917 stubs: {
Dan Albertc8060532020-07-22 22:32:17 -07007918 versions: ["current"],
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007919 },
7920 apex_available: ["myapex"],
7921 }
7922
7923 cc_prebuilt_library_shared {
7924 name: "mylib",
7925 prefer: false,
7926 srcs: ["prebuilt.so"],
7927 stubs: {
Dan Albertc8060532020-07-22 22:32:17 -07007928 versions: ["current"],
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007929 },
7930 apex_available: ["myapex"],
7931 }
7932 `)
7933}
7934
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007935func TestCompressedApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007936 ctx := testApex(t, `
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007937 apex {
7938 name: "myapex",
7939 key: "myapex.key",
7940 compressible: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007941 updatable: false,
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007942 }
7943 apex_key {
7944 name: "myapex.key",
7945 public_key: "testkey.avbpubkey",
7946 private_key: "testkey.pem",
7947 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00007948 `,
7949 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
7950 variables.CompressedApex = proptools.BoolPtr(true)
7951 }),
7952 )
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007953
7954 compressRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("compressRule")
7955 ensureContains(t, compressRule.Output.String(), "myapex.capex.unsigned")
7956
7957 signApkRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Description("sign compressedApex")
7958 ensureEquals(t, signApkRule.Input.String(), compressRule.Output.String())
7959
7960 // Make sure output of bundle is .capex
7961 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
7962 ensureContains(t, ab.outputFile.String(), "myapex.capex")
7963
7964 // Verify android.mk rules
Colin Crossaa255532020-07-03 13:18:24 -07007965 data := android.AndroidMkDataForTest(t, ctx, ab)
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007966 var builder strings.Builder
7967 data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
7968 androidMk := builder.String()
7969 ensureContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.capex\n")
7970}
7971
Martin Stjernholm2856c662020-12-02 15:03:42 +00007972func TestPreferredPrebuiltSharedLibDep(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007973 ctx := testApex(t, `
Martin Stjernholm2856c662020-12-02 15:03:42 +00007974 apex {
7975 name: "myapex",
7976 key: "myapex.key",
7977 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007978 updatable: false,
Martin Stjernholm2856c662020-12-02 15:03:42 +00007979 }
7980
7981 apex_key {
7982 name: "myapex.key",
7983 public_key: "testkey.avbpubkey",
7984 private_key: "testkey.pem",
7985 }
7986
7987 cc_library {
7988 name: "mylib",
7989 srcs: ["mylib.cpp"],
7990 apex_available: ["myapex"],
7991 shared_libs: ["otherlib"],
7992 system_shared_libs: [],
7993 }
7994
7995 cc_library {
7996 name: "otherlib",
7997 srcs: ["mylib.cpp"],
7998 stubs: {
7999 versions: ["current"],
8000 },
8001 }
8002
8003 cc_prebuilt_library_shared {
8004 name: "otherlib",
8005 prefer: true,
8006 srcs: ["prebuilt.so"],
8007 stubs: {
8008 versions: ["current"],
8009 },
8010 }
8011 `)
8012
8013 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07008014 data := android.AndroidMkDataForTest(t, ctx, ab)
Martin Stjernholm2856c662020-12-02 15:03:42 +00008015 var builder strings.Builder
8016 data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
8017 androidMk := builder.String()
8018
8019 // The make level dependency needs to be on otherlib - prebuilt_otherlib isn't
8020 // a thing there.
8021 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += otherlib\n")
8022}
8023
Jiyong Parke3867542020-12-03 17:28:25 +09008024func TestExcludeDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08008025 ctx := testApex(t, `
Jiyong Parke3867542020-12-03 17:28:25 +09008026 apex {
8027 name: "myapex",
8028 key: "myapex.key",
8029 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00008030 updatable: false,
Jiyong Parke3867542020-12-03 17:28:25 +09008031 }
8032
8033 apex_key {
8034 name: "myapex.key",
8035 public_key: "testkey.avbpubkey",
8036 private_key: "testkey.pem",
8037 }
8038
8039 cc_library {
8040 name: "mylib",
8041 srcs: ["mylib.cpp"],
8042 system_shared_libs: [],
8043 stl: "none",
8044 apex_available: ["myapex"],
8045 shared_libs: ["mylib2"],
8046 target: {
8047 apex: {
8048 exclude_shared_libs: ["mylib2"],
8049 },
8050 },
8051 }
8052
8053 cc_library {
8054 name: "mylib2",
8055 srcs: ["mylib.cpp"],
8056 system_shared_libs: [],
8057 stl: "none",
8058 }
8059 `)
8060
8061 // Check if mylib is linked to mylib2 for the non-apex target
8062 ldFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
8063 ensureContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
8064
8065 // Make sure that the link doesn't occur for the apex target
8066 ldFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
8067 ensureNotContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared_apex10000/mylib2.so")
8068
8069 // It shouldn't appear in the copy cmd as well.
8070 copyCmds := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule").Args["copy_commands"]
8071 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
8072}
8073
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09008074func TestPrebuiltStubLibDep(t *testing.T) {
8075 bpBase := `
8076 apex {
8077 name: "myapex",
8078 key: "myapex.key",
8079 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00008080 updatable: false,
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09008081 }
8082 apex_key {
8083 name: "myapex.key",
8084 public_key: "testkey.avbpubkey",
8085 private_key: "testkey.pem",
8086 }
8087 cc_library {
8088 name: "mylib",
8089 srcs: ["mylib.cpp"],
8090 apex_available: ["myapex"],
8091 shared_libs: ["stublib"],
8092 system_shared_libs: [],
8093 }
8094 apex {
8095 name: "otherapex",
8096 enabled: %s,
8097 key: "myapex.key",
8098 native_shared_libs: ["stublib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00008099 updatable: false,
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09008100 }
8101 `
8102
8103 stublibSourceBp := `
8104 cc_library {
8105 name: "stublib",
8106 srcs: ["mylib.cpp"],
8107 apex_available: ["otherapex"],
8108 system_shared_libs: [],
8109 stl: "none",
8110 stubs: {
8111 versions: ["1"],
8112 },
8113 }
8114 `
8115
8116 stublibPrebuiltBp := `
8117 cc_prebuilt_library_shared {
8118 name: "stublib",
8119 srcs: ["prebuilt.so"],
8120 apex_available: ["otherapex"],
8121 stubs: {
8122 versions: ["1"],
8123 },
8124 %s
8125 }
8126 `
8127
8128 tests := []struct {
8129 name string
8130 stublibBp string
8131 usePrebuilt bool
8132 modNames []string // Modules to collect AndroidMkEntries for
8133 otherApexEnabled []string
8134 }{
8135 {
8136 name: "only_source",
8137 stublibBp: stublibSourceBp,
8138 usePrebuilt: false,
8139 modNames: []string{"stublib"},
8140 otherApexEnabled: []string{"true", "false"},
8141 },
8142 {
8143 name: "source_preferred",
8144 stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, ""),
8145 usePrebuilt: false,
8146 modNames: []string{"stublib", "prebuilt_stublib"},
8147 otherApexEnabled: []string{"true", "false"},
8148 },
8149 {
8150 name: "prebuilt_preferred",
8151 stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, "prefer: true,"),
8152 usePrebuilt: true,
8153 modNames: []string{"stublib", "prebuilt_stublib"},
8154 otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
8155 },
8156 {
8157 name: "only_prebuilt",
8158 stublibBp: fmt.Sprintf(stublibPrebuiltBp, ""),
8159 usePrebuilt: true,
8160 modNames: []string{"stublib"},
8161 otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
8162 },
8163 }
8164
8165 for _, test := range tests {
8166 t.Run(test.name, func(t *testing.T) {
8167 for _, otherApexEnabled := range test.otherApexEnabled {
8168 t.Run("otherapex_enabled_"+otherApexEnabled, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08008169 ctx := testApex(t, fmt.Sprintf(bpBase, otherApexEnabled)+test.stublibBp)
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09008170
8171 type modAndMkEntries struct {
8172 mod *cc.Module
8173 mkEntries android.AndroidMkEntries
8174 }
8175 entries := []*modAndMkEntries{}
8176
8177 // Gather shared lib modules that are installable
8178 for _, modName := range test.modNames {
8179 for _, variant := range ctx.ModuleVariantsForTests(modName) {
8180 if !strings.HasPrefix(variant, "android_arm64_armv8-a_shared") {
8181 continue
8182 }
8183 mod := ctx.ModuleForTests(modName, variant).Module().(*cc.Module)
Colin Crossa9c8c9f2020-12-16 10:20:23 -08008184 if !mod.Enabled() || mod.IsHideFromMake() {
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09008185 continue
8186 }
Colin Crossaa255532020-07-03 13:18:24 -07008187 for _, ent := range android.AndroidMkEntriesForTest(t, ctx, mod) {
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09008188 if ent.Disabled {
8189 continue
8190 }
8191 entries = append(entries, &modAndMkEntries{
8192 mod: mod,
8193 mkEntries: ent,
8194 })
8195 }
8196 }
8197 }
8198
8199 var entry *modAndMkEntries = nil
8200 for _, ent := range entries {
8201 if strings.Join(ent.mkEntries.EntryMap["LOCAL_MODULE"], ",") == "stublib" {
8202 if entry != nil {
8203 t.Errorf("More than one AndroidMk entry for \"stublib\": %s and %s", entry.mod, ent.mod)
8204 } else {
8205 entry = ent
8206 }
8207 }
8208 }
8209
8210 if entry == nil {
8211 t.Errorf("AndroidMk entry for \"stublib\" missing")
8212 } else {
8213 isPrebuilt := entry.mod.Prebuilt() != nil
8214 if isPrebuilt != test.usePrebuilt {
8215 t.Errorf("Wrong module for \"stublib\" AndroidMk entry: got prebuilt %t, want prebuilt %t", isPrebuilt, test.usePrebuilt)
8216 }
8217 if !entry.mod.IsStubs() {
8218 t.Errorf("Module for \"stublib\" AndroidMk entry isn't a stub: %s", entry.mod)
8219 }
8220 if entry.mkEntries.EntryMap["LOCAL_NOT_AVAILABLE_FOR_PLATFORM"] != nil {
8221 t.Errorf("AndroidMk entry for \"stublib\" has LOCAL_NOT_AVAILABLE_FOR_PLATFORM set: %+v", entry.mkEntries)
8222 }
Jiyong Park892a98f2020-12-14 09:20:00 +09008223 cflags := entry.mkEntries.EntryMap["LOCAL_EXPORT_CFLAGS"]
Jiyong Parkd4a3a132021-03-17 20:21:35 +09008224 expected := "-D__STUBLIB_API__=10000"
Jiyong Park892a98f2020-12-14 09:20:00 +09008225 if !android.InList(expected, cflags) {
8226 t.Errorf("LOCAL_EXPORT_CFLAGS expected to have %q, but got %q", expected, cflags)
8227 }
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09008228 }
8229 })
8230 }
8231 })
8232 }
8233}
8234
Martin Stjernholmdf298b32021-05-21 20:57:29 +01008235func TestHostApexInHostOnlyBuild(t *testing.T) {
8236 testApex(t, `
8237 apex {
8238 name: "myapex",
8239 host_supported: true,
8240 key: "myapex.key",
8241 updatable: false,
8242 payload_type: "zip",
8243 }
8244 apex_key {
8245 name: "myapex.key",
8246 public_key: "testkey.avbpubkey",
8247 private_key: "testkey.pem",
8248 }
8249 `,
8250 android.FixtureModifyConfig(func(config android.Config) {
8251 // We may not have device targets in all builds, e.g. in
8252 // prebuilts/build-tools/build-prebuilts.sh
8253 config.Targets[android.Android] = []android.Target{}
8254 }))
8255}
8256
Colin Crossc33e5212021-05-25 18:16:02 -07008257func TestApexJavaCoverage(t *testing.T) {
8258 bp := `
8259 apex {
8260 name: "myapex",
8261 key: "myapex.key",
8262 java_libs: ["mylib"],
8263 bootclasspath_fragments: ["mybootclasspathfragment"],
8264 systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
8265 updatable: false,
8266 }
8267
8268 apex_key {
8269 name: "myapex.key",
8270 public_key: "testkey.avbpubkey",
8271 private_key: "testkey.pem",
8272 }
8273
8274 java_library {
8275 name: "mylib",
8276 srcs: ["mylib.java"],
8277 apex_available: ["myapex"],
8278 compile_dex: true,
8279 }
8280
8281 bootclasspath_fragment {
8282 name: "mybootclasspathfragment",
8283 contents: ["mybootclasspathlib"],
8284 apex_available: ["myapex"],
8285 }
8286
8287 java_library {
8288 name: "mybootclasspathlib",
8289 srcs: ["mybootclasspathlib.java"],
8290 apex_available: ["myapex"],
8291 compile_dex: true,
8292 }
8293
8294 systemserverclasspath_fragment {
8295 name: "mysystemserverclasspathfragment",
8296 contents: ["mysystemserverclasspathlib"],
8297 apex_available: ["myapex"],
8298 }
8299
8300 java_library {
8301 name: "mysystemserverclasspathlib",
8302 srcs: ["mysystemserverclasspathlib.java"],
8303 apex_available: ["myapex"],
8304 compile_dex: true,
8305 }
8306 `
8307
8308 result := android.GroupFixturePreparers(
8309 PrepareForTestWithApexBuildComponents,
8310 prepareForTestWithMyapex,
8311 java.PrepareForTestWithJavaDefaultModules,
8312 android.PrepareForTestWithAndroidBuildComponents,
8313 android.FixtureWithRootAndroidBp(bp),
satayevabcd5972021-08-06 17:49:46 +01008314 dexpreopt.FixtureSetApexBootJars("myapex:mybootclasspathlib"),
8315 dexpreopt.FixtureSetApexSystemServerJars("myapex:mysystemserverclasspathlib"),
Colin Crossc33e5212021-05-25 18:16:02 -07008316 android.FixtureMergeEnv(map[string]string{
8317 "EMMA_INSTRUMENT": "true",
8318 }),
8319 ).RunTest(t)
8320
8321 // Make sure jacoco ran on both mylib and mybootclasspathlib
8322 if result.ModuleForTests("mylib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
8323 t.Errorf("Failed to find jacoco rule for mylib")
8324 }
8325 if result.ModuleForTests("mybootclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
8326 t.Errorf("Failed to find jacoco rule for mybootclasspathlib")
8327 }
8328 if result.ModuleForTests("mysystemserverclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
8329 t.Errorf("Failed to find jacoco rule for mysystemserverclasspathlib")
8330 }
8331}
8332
Jiyong Park192600a2021-08-03 07:52:17 +00008333func TestProhibitStaticExecutable(t *testing.T) {
8334 testApexError(t, `executable mybin is static`, `
8335 apex {
8336 name: "myapex",
8337 key: "myapex.key",
8338 binaries: ["mybin"],
8339 min_sdk_version: "29",
8340 }
8341
8342 apex_key {
8343 name: "myapex.key",
8344 public_key: "testkey.avbpubkey",
8345 private_key: "testkey.pem",
8346 }
8347
8348 cc_binary {
8349 name: "mybin",
8350 srcs: ["mylib.cpp"],
8351 relative_install_path: "foo/bar",
8352 static_executable: true,
8353 system_shared_libs: [],
8354 stl: "none",
8355 apex_available: [ "myapex" ],
Jiyong Parkd12979d2021-08-03 13:36:09 +09008356 min_sdk_version: "29",
8357 }
8358 `)
8359
8360 testApexError(t, `executable mybin.rust is static`, `
8361 apex {
8362 name: "myapex",
8363 key: "myapex.key",
8364 binaries: ["mybin.rust"],
8365 min_sdk_version: "29",
8366 }
8367
8368 apex_key {
8369 name: "myapex.key",
8370 public_key: "testkey.avbpubkey",
8371 private_key: "testkey.pem",
8372 }
8373
8374 rust_binary {
8375 name: "mybin.rust",
8376 srcs: ["foo.rs"],
8377 static_executable: true,
8378 apex_available: ["myapex"],
8379 min_sdk_version: "29",
Jiyong Park192600a2021-08-03 07:52:17 +00008380 }
8381 `)
8382}
8383
Jiakai Zhang470b7e22021-09-30 09:34:26 +00008384func TestAndroidMk_DexpreoptBuiltInstalledForApex(t *testing.T) {
8385 ctx := testApex(t, `
8386 apex {
8387 name: "myapex",
8388 key: "myapex.key",
8389 updatable: false,
8390 java_libs: ["foo"],
8391 }
8392
8393 apex_key {
8394 name: "myapex.key",
8395 public_key: "testkey.avbpubkey",
8396 private_key: "testkey.pem",
8397 }
8398
8399 java_library {
8400 name: "foo",
8401 srcs: ["foo.java"],
8402 apex_available: ["myapex"],
8403 installable: true,
8404 }
8405 `,
8406 dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"),
8407 )
8408
8409 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
8410 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
8411 var builder strings.Builder
8412 data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
8413 androidMk := builder.String()
8414 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.odex foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.vdex")
8415}
8416
8417func TestAndroidMk_DexpreoptBuiltInstalledForApex_Prebuilt(t *testing.T) {
8418 ctx := testApex(t, `
8419 prebuilt_apex {
8420 name: "myapex",
8421 arch: {
8422 arm64: {
8423 src: "myapex-arm64.apex",
8424 },
8425 arm: {
8426 src: "myapex-arm.apex",
8427 },
8428 },
8429 exported_java_libs: ["foo"],
8430 }
8431
8432 java_import {
8433 name: "foo",
8434 jars: ["foo.jar"],
8435 installable: true,
8436 }
8437 `,
8438 dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"),
8439 )
8440
8441 prebuilt := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt)
8442 entriesList := android.AndroidMkEntriesForTest(t, ctx, prebuilt)
8443 mainModuleEntries := entriesList[0]
8444 android.AssertArrayString(t,
8445 "LOCAL_REQUIRED_MODULES",
8446 mainModuleEntries.EntryMap["LOCAL_REQUIRED_MODULES"],
8447 []string{
8448 "foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.odex",
8449 "foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.vdex",
8450 })
8451}
8452
Jiyong Parkcacc4f32021-10-28 14:26:03 +09008453func TestAndroidMk_RequiredModules(t *testing.T) {
8454 ctx := testApex(t, `
8455 apex {
8456 name: "myapex",
8457 key: "myapex.key",
8458 updatable: false,
8459 java_libs: ["foo"],
8460 required: ["otherapex"],
8461 }
8462
8463 apex {
8464 name: "otherapex",
8465 key: "myapex.key",
8466 updatable: false,
8467 java_libs: ["foo"],
8468 required: ["otherapex"],
8469 }
8470
8471 apex_key {
8472 name: "myapex.key",
8473 public_key: "testkey.avbpubkey",
8474 private_key: "testkey.pem",
8475 }
8476
8477 java_library {
8478 name: "foo",
8479 srcs: ["foo.java"],
8480 apex_available: ["myapex", "otherapex"],
8481 installable: true,
8482 }
8483 `)
8484
8485 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
8486 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
8487 var builder strings.Builder
8488 data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
8489 androidMk := builder.String()
8490 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += otherapex")
8491}
8492
satayev758968a2021-12-06 11:42:40 +00008493func TestSdkLibraryCanHaveHigherMinSdkVersion(t *testing.T) {
8494 preparer := android.GroupFixturePreparers(
8495 PrepareForTestWithApexBuildComponents,
8496 prepareForTestWithMyapex,
8497 java.PrepareForTestWithJavaSdkLibraryFiles,
8498 java.PrepareForTestWithJavaDefaultModules,
8499 android.PrepareForTestWithAndroidBuildComponents,
8500 dexpreopt.FixtureSetApexBootJars("myapex:mybootclasspathlib"),
8501 dexpreopt.FixtureSetApexSystemServerJars("myapex:mysystemserverclasspathlib"),
8502 )
8503
8504 // Test java_sdk_library in bootclasspath_fragment may define higher min_sdk_version than the apex
8505 t.Run("bootclasspath_fragment jar has higher min_sdk_version than apex", func(t *testing.T) {
8506 preparer.RunTestWithBp(t, `
8507 apex {
8508 name: "myapex",
8509 key: "myapex.key",
8510 bootclasspath_fragments: ["mybootclasspathfragment"],
8511 min_sdk_version: "30",
8512 updatable: false,
8513 }
8514
8515 apex_key {
8516 name: "myapex.key",
8517 public_key: "testkey.avbpubkey",
8518 private_key: "testkey.pem",
8519 }
8520
8521 bootclasspath_fragment {
8522 name: "mybootclasspathfragment",
8523 contents: ["mybootclasspathlib"],
8524 apex_available: ["myapex"],
8525 }
8526
8527 java_sdk_library {
8528 name: "mybootclasspathlib",
8529 srcs: ["mybootclasspathlib.java"],
8530 apex_available: ["myapex"],
8531 compile_dex: true,
8532 unsafe_ignore_missing_latest_api: true,
8533 min_sdk_version: "31",
8534 static_libs: ["util"],
8535 }
8536
8537 java_library {
8538 name: "util",
8539 srcs: ["a.java"],
8540 apex_available: ["myapex"],
8541 min_sdk_version: "31",
8542 static_libs: ["another_util"],
8543 }
8544
8545 java_library {
8546 name: "another_util",
8547 srcs: ["a.java"],
8548 min_sdk_version: "31",
8549 apex_available: ["myapex"],
8550 }
8551 `)
8552 })
8553
8554 // Test java_sdk_library in systemserverclasspath_fragment may define higher min_sdk_version than the apex
8555 t.Run("systemserverclasspath_fragment jar has higher min_sdk_version than apex", func(t *testing.T) {
8556 preparer.RunTestWithBp(t, `
8557 apex {
8558 name: "myapex",
8559 key: "myapex.key",
8560 systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
8561 min_sdk_version: "30",
8562 updatable: false,
8563 }
8564
8565 apex_key {
8566 name: "myapex.key",
8567 public_key: "testkey.avbpubkey",
8568 private_key: "testkey.pem",
8569 }
8570
8571 systemserverclasspath_fragment {
8572 name: "mysystemserverclasspathfragment",
8573 contents: ["mysystemserverclasspathlib"],
8574 apex_available: ["myapex"],
8575 }
8576
8577 java_sdk_library {
8578 name: "mysystemserverclasspathlib",
8579 srcs: ["mysystemserverclasspathlib.java"],
8580 apex_available: ["myapex"],
8581 compile_dex: true,
8582 min_sdk_version: "32",
8583 unsafe_ignore_missing_latest_api: true,
8584 static_libs: ["util"],
8585 }
8586
8587 java_library {
8588 name: "util",
8589 srcs: ["a.java"],
8590 apex_available: ["myapex"],
8591 min_sdk_version: "31",
8592 static_libs: ["another_util"],
8593 }
8594
8595 java_library {
8596 name: "another_util",
8597 srcs: ["a.java"],
8598 min_sdk_version: "31",
8599 apex_available: ["myapex"],
8600 }
8601 `)
8602 })
8603
8604 t.Run("bootclasspath_fragment jar must set min_sdk_version", func(t *testing.T) {
8605 preparer.ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`module "mybootclasspathlib".*must set min_sdk_version`)).
8606 RunTestWithBp(t, `
8607 apex {
8608 name: "myapex",
8609 key: "myapex.key",
8610 bootclasspath_fragments: ["mybootclasspathfragment"],
8611 min_sdk_version: "30",
8612 updatable: false,
8613 }
8614
8615 apex_key {
8616 name: "myapex.key",
8617 public_key: "testkey.avbpubkey",
8618 private_key: "testkey.pem",
8619 }
8620
8621 bootclasspath_fragment {
8622 name: "mybootclasspathfragment",
8623 contents: ["mybootclasspathlib"],
8624 apex_available: ["myapex"],
8625 }
8626
8627 java_sdk_library {
8628 name: "mybootclasspathlib",
8629 srcs: ["mybootclasspathlib.java"],
8630 apex_available: ["myapex"],
8631 compile_dex: true,
8632 unsafe_ignore_missing_latest_api: true,
8633 }
8634 `)
8635 })
8636
8637 t.Run("systemserverclasspath_fragment jar must set min_sdk_version", func(t *testing.T) {
8638 preparer.ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`module "mysystemserverclasspathlib".*must set min_sdk_version`)).
8639 RunTestWithBp(t, `
8640 apex {
8641 name: "myapex",
8642 key: "myapex.key",
8643 systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
8644 min_sdk_version: "30",
8645 updatable: false,
8646 }
8647
8648 apex_key {
8649 name: "myapex.key",
8650 public_key: "testkey.avbpubkey",
8651 private_key: "testkey.pem",
8652 }
8653
8654 systemserverclasspath_fragment {
8655 name: "mysystemserverclasspathfragment",
8656 contents: ["mysystemserverclasspathlib"],
8657 apex_available: ["myapex"],
8658 }
8659
8660 java_sdk_library {
8661 name: "mysystemserverclasspathlib",
8662 srcs: ["mysystemserverclasspathlib.java"],
8663 apex_available: ["myapex"],
8664 compile_dex: true,
8665 unsafe_ignore_missing_latest_api: true,
8666 }
8667 `)
8668 })
8669}
8670
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07008671func TestMain(m *testing.M) {
Paul Duffin37ba3442021-03-29 00:21:08 +01008672 os.Exit(m.Run())
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07008673}