blob: 88da21bdc51b4628bdc798427a1ac3958c7cd963 [file] [log] [blame]
Jiyong Park25fc6a92018-11-18 18:02:45 +09001// Copyright 2018 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package apex
16
17import (
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +090018 "fmt"
Jiyong Park25fc6a92018-11-18 18:02:45 +090019 "os"
Jooyung Han39edb6c2019-11-06 16:53:07 +090020 "path"
Paul Duffin37856732021-02-26 14:24:15 +000021 "path/filepath"
Jaewoong Jung22f7d182019-07-16 18:25:41 -070022 "reflect"
Paul Duffin9b879592020-05-26 13:21:35 +010023 "regexp"
Jooyung Han31c470b2019-10-18 16:26:59 +090024 "sort"
Jiyong Parkd4a3a132021-03-17 20:21:35 +090025 "strconv"
Jiyong Park25fc6a92018-11-18 18:02:45 +090026 "strings"
27 "testing"
Jiyong Parkda6eb592018-12-19 17:12:36 +090028
29 "github.com/google/blueprint/proptools"
30
31 "android/soong/android"
markchien2f59ec92020-09-02 16:23:38 +080032 "android/soong/bpf"
Jiyong Parkda6eb592018-12-19 17:12:36 +090033 "android/soong/cc"
Ulya Trafimovichb28cc372020-01-13 15:18:16 +000034 "android/soong/dexpreopt"
Jaewoong Jung4b79e982020-06-01 10:45:49 -070035 prebuilt_etc "android/soong/etc"
Jiyong Parkb2742fd2019-02-11 11:38:15 +090036 "android/soong/java"
Jiyong Park99644e92020-11-17 22:21:02 +090037 "android/soong/rust"
Jaewoong Jung4b79e982020-06-01 10:45:49 -070038 "android/soong/sh"
Jiyong Park25fc6a92018-11-18 18:02:45 +090039)
40
Jooyung Hand3639552019-08-09 12:57:43 +090041// names returns name list from white space separated string
42func names(s string) (ns []string) {
43 for _, n := range strings.Split(s, " ") {
44 if len(n) > 0 {
45 ns = append(ns, n)
46 }
47 }
48 return
49}
50
Paul Duffin40b62572021-03-20 11:39:01 +000051func testApexError(t *testing.T, pattern, bp string, preparers ...android.FixturePreparer) {
Jooyung Han344d5432019-08-23 11:17:39 +090052 t.Helper()
Paul Duffin284165a2021-03-29 01:50:31 +010053 android.GroupFixturePreparers(
54 prepareForApexTest,
55 android.GroupFixturePreparers(preparers...),
56 ).
Paul Duffine05480a2021-03-08 15:07:14 +000057 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)).
Paul Duffin40b62572021-03-20 11:39:01 +000058 RunTestWithBp(t, bp)
Jooyung Han5c998b92019-06-27 11:30:33 +090059}
60
Paul Duffin40b62572021-03-20 11:39:01 +000061func testApex(t *testing.T, bp string, preparers ...android.FixturePreparer) *android.TestContext {
Jooyung Han344d5432019-08-23 11:17:39 +090062 t.Helper()
Paul Duffin284165a2021-03-29 01:50:31 +010063
64 optionalBpPreparer := android.NullFixturePreparer
Paul Duffin40b62572021-03-20 11:39:01 +000065 if bp != "" {
Paul Duffin284165a2021-03-29 01:50:31 +010066 optionalBpPreparer = android.FixtureWithRootAndroidBp(bp)
Paul Duffin40b62572021-03-20 11:39:01 +000067 }
Paul Duffin284165a2021-03-29 01:50:31 +010068
69 result := android.GroupFixturePreparers(
70 prepareForApexTest,
71 android.GroupFixturePreparers(preparers...),
72 optionalBpPreparer,
73 ).RunTest(t)
74
Paul Duffine05480a2021-03-08 15:07:14 +000075 return result.TestContext
Jooyung Han5c998b92019-06-27 11:30:33 +090076}
77
Paul Duffin810f33d2021-03-09 14:12:32 +000078func withFiles(files android.MockFS) android.FixturePreparer {
79 return files.AddToFixture()
Jooyung Han344d5432019-08-23 11:17:39 +090080}
81
Paul Duffin810f33d2021-03-09 14:12:32 +000082func withTargets(targets map[android.OsType][]android.Target) android.FixturePreparer {
83 return android.FixtureModifyConfig(func(config android.Config) {
Jooyung Han344d5432019-08-23 11:17:39 +090084 for k, v := range targets {
85 config.Targets[k] = v
86 }
Paul Duffin810f33d2021-03-09 14:12:32 +000087 })
Jooyung Han344d5432019-08-23 11:17:39 +090088}
89
Jooyung Han35155c42020-02-06 17:33:20 +090090// withNativeBridgeTargets sets configuration with targets including:
91// - X86_64 (primary)
92// - X86 (secondary)
93// - Arm64 on X86_64 (native bridge)
94// - Arm on X86 (native bridge)
Paul Duffin810f33d2021-03-09 14:12:32 +000095var withNativeBridgeEnabled = android.FixtureModifyConfig(
96 func(config android.Config) {
97 config.Targets[android.Android] = []android.Target{
98 {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "silvermont", Abi: []string{"arm64-v8a"}},
99 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
100 {Os: android.Android, Arch: android.Arch{ArchType: android.X86, ArchVariant: "silvermont", Abi: []string{"armeabi-v7a"}},
101 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
102 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}},
103 NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86_64", NativeBridgeRelativePath: "arm64"},
104 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
105 NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86", NativeBridgeRelativePath: "arm"},
106 }
107 },
108)
109
110func withManifestPackageNameOverrides(specs []string) android.FixturePreparer {
111 return android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
112 variables.ManifestPackageNameOverrides = specs
113 })
Jooyung Han35155c42020-02-06 17:33:20 +0900114}
115
Paul Duffin810f33d2021-03-09 14:12:32 +0000116var withBinder32bit = android.FixtureModifyProductVariables(
117 func(variables android.FixtureProductVariables) {
118 variables.Binder32bit = proptools.BoolPtr(true)
119 },
120)
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900121
Paul Duffin810f33d2021-03-09 14:12:32 +0000122var withUnbundledBuild = android.FixtureModifyProductVariables(
123 func(variables android.FixtureProductVariables) {
124 variables.Unbundled_build = proptools.BoolPtr(true)
125 },
126)
Jiyong Park7cd10e32020-01-14 09:22:18 +0900127
Paul Duffin284165a2021-03-29 01:50:31 +0100128// Legacy preparer used for running tests within the apex package.
129//
130// This includes everything that was needed to run any test in the apex package prior to the
131// introduction of the test fixtures. Tests that are being converted to use fixtures directly
132// rather than through the testApex...() methods should avoid using this and instead use the
133// various preparers directly, using android.GroupFixturePreparers(...) to group them when
134// necessary.
135//
136// deprecated
137var prepareForApexTest = android.GroupFixturePreparers(
Paul Duffin37aad602021-03-08 09:47:16 +0000138 // General preparers in alphabetical order as test infrastructure will enforce correct
139 // registration order.
140 android.PrepareForTestWithAndroidBuildComponents,
141 bpf.PrepareForTestWithBpf,
142 cc.PrepareForTestWithCcBuildComponents,
143 java.PrepareForTestWithJavaDefaultModules,
144 prebuilt_etc.PrepareForTestWithPrebuiltEtc,
145 rust.PrepareForTestWithRustDefaultModules,
146 sh.PrepareForTestWithShBuildComponents,
147
148 PrepareForTestWithApexBuildComponents,
149
150 // Additional apex test specific preparers.
151 android.FixtureAddTextFile("system/sepolicy/Android.bp", `
152 filegroup {
153 name: "myapex-file_contexts",
154 srcs: [
155 "apex/myapex-file_contexts",
156 ],
157 }
158 `),
Paul Duffin52bfaa42021-03-23 23:40:12 +0000159 prepareForTestWithMyapex,
Paul Duffin37aad602021-03-08 09:47:16 +0000160 android.FixtureMergeMockFs(android.MockFS{
Paul Duffin52bfaa42021-03-23 23:40:12 +0000161 "a.java": nil,
162 "PrebuiltAppFoo.apk": nil,
163 "PrebuiltAppFooPriv.apk": nil,
164 "apex_manifest.json": nil,
165 "AndroidManifest.xml": nil,
Paul Duffin37aad602021-03-08 09:47:16 +0000166 "system/sepolicy/apex/myapex.updatable-file_contexts": nil,
167 "system/sepolicy/apex/myapex2-file_contexts": nil,
168 "system/sepolicy/apex/otherapex-file_contexts": nil,
169 "system/sepolicy/apex/com.android.vndk-file_contexts": nil,
170 "system/sepolicy/apex/com.android.vndk.current-file_contexts": nil,
171 "mylib.cpp": nil,
172 "mytest.cpp": nil,
173 "mytest1.cpp": nil,
174 "mytest2.cpp": nil,
175 "mytest3.cpp": nil,
176 "myprebuilt": nil,
177 "my_include": nil,
178 "foo/bar/MyClass.java": nil,
179 "prebuilt.jar": nil,
180 "prebuilt.so": nil,
181 "vendor/foo/devkeys/test.x509.pem": nil,
182 "vendor/foo/devkeys/test.pk8": nil,
183 "testkey.x509.pem": nil,
184 "testkey.pk8": nil,
185 "testkey.override.x509.pem": nil,
186 "testkey.override.pk8": nil,
187 "vendor/foo/devkeys/testkey.avbpubkey": nil,
188 "vendor/foo/devkeys/testkey.pem": nil,
189 "NOTICE": nil,
190 "custom_notice": nil,
191 "custom_notice_for_static_lib": nil,
192 "testkey2.avbpubkey": nil,
193 "testkey2.pem": nil,
194 "myapex-arm64.apex": nil,
195 "myapex-arm.apex": nil,
196 "myapex.apks": nil,
197 "frameworks/base/api/current.txt": nil,
198 "framework/aidl/a.aidl": nil,
199 "build/make/core/proguard.flags": nil,
200 "build/make/core/proguard_basic_keeps.flags": nil,
201 "dummy.txt": nil,
202 "baz": nil,
203 "bar/baz": nil,
204 "testdata/baz": nil,
205 "AppSet.apks": nil,
206 "foo.rs": nil,
207 "libfoo.jar": nil,
208 "libbar.jar": nil,
209 },
210 ),
211
212 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
213 variables.DeviceVndkVersion = proptools.StringPtr("current")
214 variables.DefaultAppCertificate = proptools.StringPtr("vendor/foo/devkeys/test")
215 variables.CertificateOverrides = []string{"myapex_keytest:myapex.certificate.override"}
216 variables.Platform_sdk_codename = proptools.StringPtr("Q")
217 variables.Platform_sdk_final = proptools.BoolPtr(false)
218 variables.Platform_version_active_codenames = []string{"Q"}
Jiyong Parkf58c46e2021-04-01 21:35:20 +0900219 variables.Platform_vndk_version = proptools.StringPtr("29")
Paul Duffin37aad602021-03-08 09:47:16 +0000220 }),
221)
222
Paul Duffin52bfaa42021-03-23 23:40:12 +0000223var prepareForTestWithMyapex = android.FixtureMergeMockFs(android.MockFS{
224 "system/sepolicy/apex/myapex-file_contexts": nil,
225})
226
Jooyung Han643adc42020-02-27 13:50:06 +0900227// ensure that 'result' equals 'expected'
228func ensureEquals(t *testing.T, result string, expected string) {
229 t.Helper()
230 if result != expected {
231 t.Errorf("%q != %q", expected, result)
232 }
233}
234
Jiyong Park25fc6a92018-11-18 18:02:45 +0900235// ensure that 'result' contains 'expected'
236func ensureContains(t *testing.T, result string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900237 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900238 if !strings.Contains(result, expected) {
239 t.Errorf("%q is not found in %q", expected, result)
240 }
241}
242
Liz Kammer5bd365f2020-05-27 15:15:11 -0700243// ensure that 'result' contains 'expected' exactly one time
244func ensureContainsOnce(t *testing.T, result string, expected string) {
245 t.Helper()
246 count := strings.Count(result, expected)
247 if count != 1 {
248 t.Errorf("%q is found %d times (expected 1 time) in %q", expected, count, result)
249 }
250}
251
Jiyong Park25fc6a92018-11-18 18:02:45 +0900252// ensures that 'result' does not contain 'notExpected'
253func ensureNotContains(t *testing.T, result string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900254 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900255 if strings.Contains(result, notExpected) {
256 t.Errorf("%q is found in %q", notExpected, result)
257 }
258}
259
Sasha Smundak18d98bc2020-05-27 16:36:07 -0700260func ensureMatches(t *testing.T, result string, expectedRex string) {
261 ok, err := regexp.MatchString(expectedRex, result)
262 if err != nil {
263 t.Fatalf("regexp failure trying to match %s against `%s` expression: %s", result, expectedRex, err)
264 return
265 }
266 if !ok {
267 t.Errorf("%s does not match regular expession %s", result, expectedRex)
268 }
269}
270
Jiyong Park25fc6a92018-11-18 18:02:45 +0900271func ensureListContains(t *testing.T, result []string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900272 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900273 if !android.InList(expected, result) {
274 t.Errorf("%q is not found in %v", expected, result)
275 }
276}
277
278func ensureListNotContains(t *testing.T, result []string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900279 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900280 if android.InList(notExpected, result) {
281 t.Errorf("%q is found in %v", notExpected, result)
282 }
283}
284
Jooyung Hane1633032019-08-01 17:41:43 +0900285func ensureListEmpty(t *testing.T, result []string) {
286 t.Helper()
287 if len(result) > 0 {
288 t.Errorf("%q is expected to be empty", result)
289 }
290}
291
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +0000292func ensureListNotEmpty(t *testing.T, result []string) {
293 t.Helper()
294 if len(result) == 0 {
295 t.Errorf("%q is expected to be not empty", result)
296 }
297}
298
Jiyong Park25fc6a92018-11-18 18:02:45 +0900299// Minimal test
300func TestBasicApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800301 ctx := testApex(t, `
Jiyong Park30ca9372019-02-07 16:27:23 +0900302 apex_defaults {
303 name: "myapex-defaults",
Jiyong Park809bb722019-02-13 21:33:49 +0900304 manifest: ":myapex.manifest",
305 androidManifest: ":myapex.androidmanifest",
Jiyong Park25fc6a92018-11-18 18:02:45 +0900306 key: "myapex.key",
Jiyong Park99644e92020-11-17 22:21:02 +0900307 binaries: ["foo.rust"],
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900308 native_shared_libs: [
309 "mylib",
310 "libfoo.ffi",
311 ],
Jiyong Park99644e92020-11-17 22:21:02 +0900312 rust_dyn_libs: ["libfoo.dylib.rust"],
Alex Light3d673592019-01-18 14:37:31 -0800313 multilib: {
314 both: {
Jiyong Park99644e92020-11-17 22:21:02 +0900315 binaries: ["foo"],
Alex Light3d673592019-01-18 14:37:31 -0800316 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900317 },
Jiyong Park77acec62020-06-01 21:39:15 +0900318 java_libs: [
319 "myjar",
320 "myjar_dex",
321 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000322 updatable: false,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900323 }
324
Jiyong Park30ca9372019-02-07 16:27:23 +0900325 apex {
326 name: "myapex",
327 defaults: ["myapex-defaults"],
328 }
329
Jiyong Park25fc6a92018-11-18 18:02:45 +0900330 apex_key {
331 name: "myapex.key",
332 public_key: "testkey.avbpubkey",
333 private_key: "testkey.pem",
334 }
335
Jiyong Park809bb722019-02-13 21:33:49 +0900336 filegroup {
337 name: "myapex.manifest",
338 srcs: ["apex_manifest.json"],
339 }
340
341 filegroup {
342 name: "myapex.androidmanifest",
343 srcs: ["AndroidManifest.xml"],
344 }
345
Jiyong Park25fc6a92018-11-18 18:02:45 +0900346 cc_library {
347 name: "mylib",
348 srcs: ["mylib.cpp"],
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900349 shared_libs: [
350 "mylib2",
351 "libbar.ffi",
352 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900353 system_shared_libs: [],
354 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000355 // TODO: remove //apex_available:platform
356 apex_available: [
357 "//apex_available:platform",
358 "myapex",
359 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900360 }
361
Alex Light3d673592019-01-18 14:37:31 -0800362 cc_binary {
363 name: "foo",
364 srcs: ["mylib.cpp"],
365 compile_multilib: "both",
366 multilib: {
367 lib32: {
368 suffix: "32",
369 },
370 lib64: {
371 suffix: "64",
372 },
373 },
374 symlinks: ["foo_link_"],
375 symlink_preferred_arch: true,
376 system_shared_libs: [],
377 static_executable: true,
378 stl: "none",
Yifan Hongd22a84a2020-07-28 17:37:46 -0700379 apex_available: [ "myapex", "com.android.gki.*" ],
380 }
381
Jiyong Park99644e92020-11-17 22:21:02 +0900382 rust_binary {
Artur Satayev533b98c2021-03-11 18:03:42 +0000383 name: "foo.rust",
Jiyong Park99644e92020-11-17 22:21:02 +0900384 srcs: ["foo.rs"],
385 rlibs: ["libfoo.rlib.rust"],
386 dylibs: ["libfoo.dylib.rust"],
387 apex_available: ["myapex"],
388 }
389
390 rust_library_rlib {
Artur Satayev533b98c2021-03-11 18:03:42 +0000391 name: "libfoo.rlib.rust",
Jiyong Park99644e92020-11-17 22:21:02 +0900392 srcs: ["foo.rs"],
393 crate_name: "foo",
394 apex_available: ["myapex"],
Jiyong Park94e22fd2021-04-08 18:19:15 +0900395 shared_libs: ["libfoo.shared_from_rust"],
396 }
397
398 cc_library_shared {
399 name: "libfoo.shared_from_rust",
400 srcs: ["mylib.cpp"],
401 system_shared_libs: [],
402 stl: "none",
403 apex_available: ["myapex"],
Jiyong Park99644e92020-11-17 22:21:02 +0900404 }
405
406 rust_library_dylib {
Artur Satayev533b98c2021-03-11 18:03:42 +0000407 name: "libfoo.dylib.rust",
Jiyong Park99644e92020-11-17 22:21:02 +0900408 srcs: ["foo.rs"],
409 crate_name: "foo",
410 apex_available: ["myapex"],
411 }
412
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900413 rust_ffi_shared {
414 name: "libfoo.ffi",
415 srcs: ["foo.rs"],
416 crate_name: "foo",
417 apex_available: ["myapex"],
418 }
419
420 rust_ffi_shared {
421 name: "libbar.ffi",
422 srcs: ["foo.rs"],
423 crate_name: "bar",
424 apex_available: ["myapex"],
425 }
426
Yifan Hongd22a84a2020-07-28 17:37:46 -0700427 apex {
428 name: "com.android.gki.fake",
429 binaries: ["foo"],
430 key: "myapex.key",
431 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000432 updatable: false,
Alex Light3d673592019-01-18 14:37:31 -0800433 }
434
Paul Duffindddd5462020-04-07 15:25:44 +0100435 cc_library_shared {
Jiyong Park25fc6a92018-11-18 18:02:45 +0900436 name: "mylib2",
437 srcs: ["mylib.cpp"],
438 system_shared_libs: [],
439 stl: "none",
Jiyong Park52818fc2019-03-18 12:01:38 +0900440 notice: "custom_notice",
Jiyong Park9918e1a2020-03-17 19:16:40 +0900441 static_libs: ["libstatic"],
442 // TODO: remove //apex_available:platform
443 apex_available: [
444 "//apex_available:platform",
445 "myapex",
446 ],
447 }
448
Paul Duffindddd5462020-04-07 15:25:44 +0100449 cc_prebuilt_library_shared {
450 name: "mylib2",
451 srcs: ["prebuilt.so"],
452 // TODO: remove //apex_available:platform
453 apex_available: [
454 "//apex_available:platform",
455 "myapex",
456 ],
457 }
458
Jiyong Park9918e1a2020-03-17 19:16:40 +0900459 cc_library_static {
460 name: "libstatic",
461 srcs: ["mylib.cpp"],
462 system_shared_libs: [],
463 stl: "none",
464 notice: "custom_notice_for_static_lib",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000465 // TODO: remove //apex_available:platform
466 apex_available: [
467 "//apex_available:platform",
468 "myapex",
469 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900470 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900471
472 java_library {
473 name: "myjar",
474 srcs: ["foo/bar/MyClass.java"],
Jiyong Parka62aa232020-05-28 23:46:55 +0900475 stem: "myjar_stem",
Jiyong Park7f7766d2019-07-25 22:02:35 +0900476 sdk_version: "none",
477 system_modules: "none",
Jiyong Park7f7766d2019-07-25 22:02:35 +0900478 static_libs: ["myotherjar"],
Jiyong Park3ff16992019-12-27 14:11:47 +0900479 libs: ["mysharedjar"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000480 // TODO: remove //apex_available:platform
481 apex_available: [
482 "//apex_available:platform",
483 "myapex",
484 ],
Jiyong Park7f7766d2019-07-25 22:02:35 +0900485 }
486
Jiyong Park77acec62020-06-01 21:39:15 +0900487 dex_import {
488 name: "myjar_dex",
489 jars: ["prebuilt.jar"],
490 apex_available: [
491 "//apex_available:platform",
492 "myapex",
493 ],
494 }
495
Jiyong Park7f7766d2019-07-25 22:02:35 +0900496 java_library {
497 name: "myotherjar",
498 srcs: ["foo/bar/MyClass.java"],
499 sdk_version: "none",
500 system_modules: "none",
Jiyong Park0f80c182020-01-31 02:49:53 +0900501 // TODO: remove //apex_available:platform
502 apex_available: [
503 "//apex_available:platform",
504 "myapex",
505 ],
Jiyong Park7f7766d2019-07-25 22:02:35 +0900506 }
Jiyong Park3ff16992019-12-27 14:11:47 +0900507
508 java_library {
509 name: "mysharedjar",
510 srcs: ["foo/bar/MyClass.java"],
511 sdk_version: "none",
512 system_modules: "none",
Jiyong Park3ff16992019-12-27 14:11:47 +0900513 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900514 `)
515
Paul Duffina71a67a2021-03-29 00:42:57 +0100516 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900517
Jiyong Park9e83f0b2020-06-11 00:35:03 +0900518 // Make sure that Android.mk is created
519 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -0700520 data := android.AndroidMkDataForTest(t, ctx, ab)
Jiyong Park9e83f0b2020-06-11 00:35:03 +0900521 var builder strings.Builder
522 data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
523
524 androidMk := builder.String()
525 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
526 ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
527
Jiyong Park42cca6c2019-04-01 11:15:50 +0900528 optFlags := apexRule.Args["opt_flags"]
529 ensureContains(t, optFlags, "--pubkey vendor/foo/devkeys/testkey.avbpubkey")
Jaewoong Jung14f5ff62019-06-18 13:09:13 -0700530 // Ensure that the NOTICE output is being packaged as an asset.
Paul Duffin37ba3442021-03-29 00:21:08 +0100531 ensureContains(t, optFlags, "--assets_dir out/soong/.intermediates/myapex/android_common_myapex_image/NOTICE")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900532
Jiyong Park25fc6a92018-11-18 18:02:45 +0900533 copyCmds := apexRule.Args["copy_commands"]
534
535 // Ensure that main rule creates an output
536 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
537
538 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -0700539 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
540 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common_apex10000")
541 ensureListContains(t, ctx.ModuleVariantsForTests("myjar_dex"), "android_common_apex10000")
Jiyong Park99644e92020-11-17 22:21:02 +0900542 ensureListContains(t, ctx.ModuleVariantsForTests("foo.rust"), "android_arm64_armv8-a_apex10000")
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900543 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.ffi"), "android_arm64_armv8-a_shared_apex10000")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900544
545 // Ensure that apex variant is created for the indirect dep
Colin Crossaede88c2020-08-11 12:17:01 -0700546 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
547 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common_apex10000")
Jiyong Park99644e92020-11-17 22:21:02 +0900548 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.rlib.rust"), "android_arm64_armv8-a_rlib_dylib-std_apex10000")
549 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.dylib.rust"), "android_arm64_armv8-a_dylib_apex10000")
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900550 ensureListContains(t, ctx.ModuleVariantsForTests("libbar.ffi"), "android_arm64_armv8-a_shared_apex10000")
Jiyong Park94e22fd2021-04-08 18:19:15 +0900551 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.shared_from_rust"), "android_arm64_armv8-a_shared_apex10000")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900552
553 // Ensure that both direct and indirect deps are copied into apex
Alex Light5098a612018-11-29 17:12:15 -0800554 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
555 ensureContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Parka62aa232020-05-28 23:46:55 +0900556 ensureContains(t, copyCmds, "image.apex/javalib/myjar_stem.jar")
Jiyong Park77acec62020-06-01 21:39:15 +0900557 ensureContains(t, copyCmds, "image.apex/javalib/myjar_dex.jar")
Jiyong Park99644e92020-11-17 22:21:02 +0900558 ensureContains(t, copyCmds, "image.apex/lib64/libfoo.dylib.rust.dylib.so")
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900559 ensureContains(t, copyCmds, "image.apex/lib64/libfoo.ffi.so")
560 ensureContains(t, copyCmds, "image.apex/lib64/libbar.ffi.so")
Jiyong Park94e22fd2021-04-08 18:19:15 +0900561 ensureContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900562 // .. but not for java libs
563 ensureNotContains(t, copyCmds, "image.apex/javalib/myotherjar.jar")
Jiyong Park3ff16992019-12-27 14:11:47 +0900564 ensureNotContains(t, copyCmds, "image.apex/javalib/msharedjar.jar")
Logan Chien3aeedc92018-12-26 15:32:21 +0800565
Colin Cross7113d202019-11-20 16:39:12 -0800566 // Ensure that the platform variant ends with _shared or _common
567 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
568 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900569 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common")
570 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common")
Jiyong Park3ff16992019-12-27 14:11:47 +0900571 ensureListContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common")
572
573 // Ensure that dynamic dependency to java libs are not included
574 ensureListNotContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common_myapex")
Alex Light3d673592019-01-18 14:37:31 -0800575
576 // Ensure that all symlinks are present.
577 found_foo_link_64 := false
578 found_foo := false
579 for _, cmd := range strings.Split(copyCmds, " && ") {
Jiyong Park7cd10e32020-01-14 09:22:18 +0900580 if strings.HasPrefix(cmd, "ln -sfn foo64") {
Alex Light3d673592019-01-18 14:37:31 -0800581 if strings.HasSuffix(cmd, "bin/foo") {
582 found_foo = true
583 } else if strings.HasSuffix(cmd, "bin/foo_link_64") {
584 found_foo_link_64 = true
585 }
586 }
587 }
588 good := found_foo && found_foo_link_64
589 if !good {
590 t.Errorf("Could not find all expected symlinks! foo: %t, foo_link_64: %t. Command was %s", found_foo, found_foo_link_64, copyCmds)
591 }
Jiyong Park52818fc2019-03-18 12:01:38 +0900592
Sundong Ahnabb64432019-10-22 13:58:29 +0900593 mergeNoticesRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("mergeNoticesRule")
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700594 noticeInputs := mergeNoticesRule.Inputs.Strings()
Jiyong Park9918e1a2020-03-17 19:16:40 +0900595 if len(noticeInputs) != 3 {
596 t.Errorf("number of input notice files: expected = 3, actual = %q", len(noticeInputs))
Jiyong Park52818fc2019-03-18 12:01:38 +0900597 }
598 ensureListContains(t, noticeInputs, "NOTICE")
599 ensureListContains(t, noticeInputs, "custom_notice")
Jiyong Park9918e1a2020-03-17 19:16:40 +0900600 ensureListContains(t, noticeInputs, "custom_notice_for_static_lib")
Jiyong Park83dc74b2020-01-14 18:38:44 +0900601
Artur Satayeva8bd1132020-04-27 18:07:06 +0100602 fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100603 ensureListContains(t, fullDepsInfo, " myjar(minSdkVersion:(no version)) <- myapex")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100604 ensureListContains(t, fullDepsInfo, " mylib2(minSdkVersion:(no version)) <- mylib")
605 ensureListContains(t, fullDepsInfo, " myotherjar(minSdkVersion:(no version)) <- myjar")
606 ensureListContains(t, fullDepsInfo, " mysharedjar(minSdkVersion:(no version)) (external) <- myjar")
Artur Satayeva8bd1132020-04-27 18:07:06 +0100607
608 flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100609 ensureListContains(t, flatDepsInfo, "myjar(minSdkVersion:(no version))")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100610 ensureListContains(t, flatDepsInfo, "mylib2(minSdkVersion:(no version))")
611 ensureListContains(t, flatDepsInfo, "myotherjar(minSdkVersion:(no version))")
612 ensureListContains(t, flatDepsInfo, "mysharedjar(minSdkVersion:(no version)) (external)")
Alex Light5098a612018-11-29 17:12:15 -0800613}
614
Jooyung Hanf21c7972019-12-16 22:32:06 +0900615func TestDefaults(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800616 ctx := testApex(t, `
Jooyung Hanf21c7972019-12-16 22:32:06 +0900617 apex_defaults {
618 name: "myapex-defaults",
619 key: "myapex.key",
620 prebuilts: ["myetc"],
621 native_shared_libs: ["mylib"],
622 java_libs: ["myjar"],
623 apps: ["AppFoo"],
Jiyong Park69aeba92020-04-24 21:16:36 +0900624 rros: ["rro"],
markchien2f59ec92020-09-02 16:23:38 +0800625 bpfs: ["bpf"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000626 updatable: false,
Jooyung Hanf21c7972019-12-16 22:32:06 +0900627 }
628
629 prebuilt_etc {
630 name: "myetc",
631 src: "myprebuilt",
632 }
633
634 apex {
635 name: "myapex",
636 defaults: ["myapex-defaults"],
637 }
638
639 apex_key {
640 name: "myapex.key",
641 public_key: "testkey.avbpubkey",
642 private_key: "testkey.pem",
643 }
644
645 cc_library {
646 name: "mylib",
647 system_shared_libs: [],
648 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000649 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900650 }
651
652 java_library {
653 name: "myjar",
654 srcs: ["foo/bar/MyClass.java"],
655 sdk_version: "none",
656 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000657 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900658 }
659
660 android_app {
661 name: "AppFoo",
662 srcs: ["foo/bar/MyClass.java"],
663 sdk_version: "none",
664 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000665 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900666 }
Jiyong Park69aeba92020-04-24 21:16:36 +0900667
668 runtime_resource_overlay {
669 name: "rro",
670 theme: "blue",
671 }
672
markchien2f59ec92020-09-02 16:23:38 +0800673 bpf {
674 name: "bpf",
675 srcs: ["bpf.c", "bpf2.c"],
676 }
677
Jooyung Hanf21c7972019-12-16 22:32:06 +0900678 `)
Jooyung Hana57af4a2020-01-23 05:36:59 +0000679 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Hanf21c7972019-12-16 22:32:06 +0900680 "etc/myetc",
681 "javalib/myjar.jar",
682 "lib64/mylib.so",
683 "app/AppFoo/AppFoo.apk",
Jiyong Park69aeba92020-04-24 21:16:36 +0900684 "overlay/blue/rro.apk",
markchien2f59ec92020-09-02 16:23:38 +0800685 "etc/bpf/bpf.o",
686 "etc/bpf/bpf2.o",
Jooyung Hanf21c7972019-12-16 22:32:06 +0900687 })
688}
689
Jooyung Han01a3ee22019-11-02 02:52:25 +0900690func TestApexManifest(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800691 ctx := testApex(t, `
Jooyung Han01a3ee22019-11-02 02:52:25 +0900692 apex {
693 name: "myapex",
694 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000695 updatable: false,
Jooyung Han01a3ee22019-11-02 02:52:25 +0900696 }
697
698 apex_key {
699 name: "myapex.key",
700 public_key: "testkey.avbpubkey",
701 private_key: "testkey.pem",
702 }
703 `)
704
705 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Han214bf372019-11-12 13:03:50 +0900706 args := module.Rule("apexRule").Args
707 if manifest := args["manifest"]; manifest != module.Output("apex_manifest.pb").Output.String() {
708 t.Error("manifest should be apex_manifest.pb, but " + manifest)
709 }
Jooyung Han01a3ee22019-11-02 02:52:25 +0900710}
711
Liz Kammer4854a7d2021-05-27 14:28:27 -0400712func TestApexManifestMinSdkVersion(t *testing.T) {
713 ctx := testApex(t, `
714 apex_defaults {
715 name: "my_defaults",
716 key: "myapex.key",
717 product_specific: true,
718 file_contexts: ":my-file-contexts",
719 updatable: false,
720 }
721 apex {
722 name: "myapex_30",
723 min_sdk_version: "30",
724 defaults: ["my_defaults"],
725 }
726
727 apex {
728 name: "myapex_current",
729 min_sdk_version: "current",
730 defaults: ["my_defaults"],
731 }
732
733 apex {
734 name: "myapex_none",
735 defaults: ["my_defaults"],
736 }
737
738 apex_key {
739 name: "myapex.key",
740 public_key: "testkey.avbpubkey",
741 private_key: "testkey.pem",
742 }
743
744 filegroup {
745 name: "my-file-contexts",
746 srcs: ["product_specific_file_contexts"],
747 }
748 `, withFiles(map[string][]byte{
749 "product_specific_file_contexts": nil,
750 }), android.FixtureModifyProductVariables(
751 func(variables android.FixtureProductVariables) {
752 variables.Unbundled_build = proptools.BoolPtr(true)
753 variables.Always_use_prebuilt_sdks = proptools.BoolPtr(false)
754 }), android.FixtureMergeEnv(map[string]string{
755 "UNBUNDLED_BUILD_TARGET_SDK_WITH_API_FINGERPRINT": "true",
756 }))
757
758 testCases := []struct {
759 module string
760 minSdkVersion string
761 }{
762 {
763 module: "myapex_30",
764 minSdkVersion: "30",
765 },
766 {
767 module: "myapex_current",
768 minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
769 },
770 {
771 module: "myapex_none",
772 minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
773 },
774 }
775 for _, tc := range testCases {
776 module := ctx.ModuleForTests(tc.module, "android_common_"+tc.module+"_image")
777 args := module.Rule("apexRule").Args
778 optFlags := args["opt_flags"]
779 if !strings.Contains(optFlags, "--min_sdk_version "+tc.minSdkVersion) {
780 t.Errorf("%s: Expected min_sdk_version=%s, got: %s", tc.module, tc.minSdkVersion, optFlags)
781 }
782 }
783}
784
Alex Light5098a612018-11-29 17:12:15 -0800785func TestBasicZipApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800786 ctx := testApex(t, `
Alex Light5098a612018-11-29 17:12:15 -0800787 apex {
788 name: "myapex",
789 key: "myapex.key",
790 payload_type: "zip",
791 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000792 updatable: false,
Alex Light5098a612018-11-29 17:12:15 -0800793 }
794
795 apex_key {
796 name: "myapex.key",
797 public_key: "testkey.avbpubkey",
798 private_key: "testkey.pem",
799 }
800
801 cc_library {
802 name: "mylib",
803 srcs: ["mylib.cpp"],
804 shared_libs: ["mylib2"],
805 system_shared_libs: [],
806 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000807 apex_available: [ "myapex" ],
Alex Light5098a612018-11-29 17:12:15 -0800808 }
809
810 cc_library {
811 name: "mylib2",
812 srcs: ["mylib.cpp"],
813 system_shared_libs: [],
814 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000815 apex_available: [ "myapex" ],
Alex Light5098a612018-11-29 17:12:15 -0800816 }
817 `)
818
Sundong Ahnabb64432019-10-22 13:58:29 +0900819 zipApexRule := ctx.ModuleForTests("myapex", "android_common_myapex_zip").Rule("zipApexRule")
Alex Light5098a612018-11-29 17:12:15 -0800820 copyCmds := zipApexRule.Args["copy_commands"]
821
822 // Ensure that main rule creates an output
823 ensureContains(t, zipApexRule.Output.String(), "myapex.zipapex.unsigned")
824
825 // Ensure that APEX variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -0700826 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
Alex Light5098a612018-11-29 17:12:15 -0800827
828 // Ensure that APEX variant is created for the indirect dep
Colin Crossaede88c2020-08-11 12:17:01 -0700829 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
Alex Light5098a612018-11-29 17:12:15 -0800830
831 // Ensure that both direct and indirect deps are copied into apex
832 ensureContains(t, copyCmds, "image.zipapex/lib64/mylib.so")
833 ensureContains(t, copyCmds, "image.zipapex/lib64/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900834}
835
836func TestApexWithStubs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800837 ctx := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +0900838 apex {
839 name: "myapex",
840 key: "myapex.key",
841 native_shared_libs: ["mylib", "mylib3"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000842 updatable: false,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900843 }
844
845 apex_key {
846 name: "myapex.key",
847 public_key: "testkey.avbpubkey",
848 private_key: "testkey.pem",
849 }
850
851 cc_library {
852 name: "mylib",
853 srcs: ["mylib.cpp"],
854 shared_libs: ["mylib2", "mylib3"],
855 system_shared_libs: [],
856 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000857 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900858 }
859
860 cc_library {
861 name: "mylib2",
862 srcs: ["mylib.cpp"],
Jiyong Park64379952018-12-13 18:37:29 +0900863 cflags: ["-include mylib.h"],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900864 system_shared_libs: [],
865 stl: "none",
866 stubs: {
867 versions: ["1", "2", "3"],
868 },
869 }
870
871 cc_library {
872 name: "mylib3",
Jiyong Park28d395a2018-12-07 22:42:47 +0900873 srcs: ["mylib.cpp"],
874 shared_libs: ["mylib4"],
875 system_shared_libs: [],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900876 stl: "none",
877 stubs: {
878 versions: ["10", "11", "12"],
879 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000880 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900881 }
Jiyong Park28d395a2018-12-07 22:42:47 +0900882
883 cc_library {
884 name: "mylib4",
885 srcs: ["mylib.cpp"],
886 system_shared_libs: [],
887 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000888 apex_available: [ "myapex" ],
Jiyong Park28d395a2018-12-07 22:42:47 +0900889 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900890 `)
891
Sundong Ahnabb64432019-10-22 13:58:29 +0900892 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900893 copyCmds := apexRule.Args["copy_commands"]
894
895 // Ensure that direct non-stubs dep is always included
Alex Light5098a612018-11-29 17:12:15 -0800896 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900897
898 // Ensure that indirect stubs dep is not included
Alex Light5098a612018-11-29 17:12:15 -0800899 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900900
901 // Ensure that direct stubs dep is included
Alex Light5098a612018-11-29 17:12:15 -0800902 ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900903
Colin Crossaede88c2020-08-11 12:17:01 -0700904 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +0900905
906 // Ensure that mylib is linking with the latest version of stubs for mylib2
Jiyong Parkd4a3a132021-03-17 20:21:35 +0900907 ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900908 // ... and not linking to the non-stub (impl) variant of mylib2
Jiyong Park3ff16992019-12-27 14:11:47 +0900909 ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900910
911 // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
Colin Crossaede88c2020-08-11 12:17:01 -0700912 ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex10000/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900913 // .. and not linking to the stubs variant of mylib3
Colin Crossaede88c2020-08-11 12:17:01 -0700914 ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_12/mylib3.so")
Jiyong Park64379952018-12-13 18:37:29 +0900915
916 // Ensure that stubs libs are built without -include flags
Jiyong Park0f80c182020-01-31 02:49:53 +0900917 mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jiyong Park64379952018-12-13 18:37:29 +0900918 ensureNotContains(t, mylib2Cflags, "-include ")
Jiyong Park3fd0baf2018-12-07 16:25:39 +0900919
920 // Ensure that genstub is invoked with --apex
Colin Crossa717db72020-10-23 14:53:06 -0700921 ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_3").Rule("genStubSrc").Args["flags"])
Jooyung Han671f1ce2019-12-17 12:47:13 +0900922
Jooyung Hana57af4a2020-01-23 05:36:59 +0000923 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Han671f1ce2019-12-17 12:47:13 +0900924 "lib64/mylib.so",
925 "lib64/mylib3.so",
926 "lib64/mylib4.so",
927 })
Jiyong Park25fc6a92018-11-18 18:02:45 +0900928}
929
Colin Cross7812fd32020-09-25 12:35:10 -0700930func TestApexWithStubsWithMinSdkVersion(t *testing.T) {
931 t.Parallel()
Colin Cross1c460562021-02-16 17:55:47 -0800932 ctx := testApex(t, `
Colin Cross7812fd32020-09-25 12:35:10 -0700933 apex {
934 name: "myapex",
935 key: "myapex.key",
936 native_shared_libs: ["mylib", "mylib3"],
937 min_sdk_version: "29",
938 }
939
940 apex_key {
941 name: "myapex.key",
942 public_key: "testkey.avbpubkey",
943 private_key: "testkey.pem",
944 }
945
946 cc_library {
947 name: "mylib",
948 srcs: ["mylib.cpp"],
949 shared_libs: ["mylib2", "mylib3"],
950 system_shared_libs: [],
951 stl: "none",
952 apex_available: [ "myapex" ],
953 min_sdk_version: "28",
954 }
955
956 cc_library {
957 name: "mylib2",
958 srcs: ["mylib.cpp"],
959 cflags: ["-include mylib.h"],
960 system_shared_libs: [],
961 stl: "none",
962 stubs: {
963 versions: ["28", "29", "30", "current"],
964 },
965 min_sdk_version: "28",
966 }
967
968 cc_library {
969 name: "mylib3",
970 srcs: ["mylib.cpp"],
971 shared_libs: ["mylib4"],
972 system_shared_libs: [],
973 stl: "none",
974 stubs: {
975 versions: ["28", "29", "30", "current"],
976 },
977 apex_available: [ "myapex" ],
978 min_sdk_version: "28",
979 }
980
981 cc_library {
982 name: "mylib4",
983 srcs: ["mylib.cpp"],
984 system_shared_libs: [],
985 stl: "none",
986 apex_available: [ "myapex" ],
987 min_sdk_version: "28",
988 }
989 `)
990
991 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
992 copyCmds := apexRule.Args["copy_commands"]
993
994 // Ensure that direct non-stubs dep is always included
995 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
996
997 // Ensure that indirect stubs dep is not included
998 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
999
1000 // Ensure that direct stubs dep is included
1001 ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
1002
1003 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex29").Rule("ld").Args["libFlags"]
1004
Jiyong Park55549df2021-02-26 23:57:23 +09001005 // Ensure that mylib is linking with the latest version of stub for mylib2
1006 ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
Colin Cross7812fd32020-09-25 12:35:10 -07001007 // ... and not linking to the non-stub (impl) variant of mylib2
1008 ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
1009
1010 // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
1011 ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex29/mylib3.so")
1012 // .. and not linking to the stubs variant of mylib3
1013 ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_29/mylib3.so")
1014
1015 // Ensure that stubs libs are built without -include flags
Colin Crossa717db72020-10-23 14:53:06 -07001016 mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("cc").Args["cFlags"]
Colin Cross7812fd32020-09-25 12:35:10 -07001017 ensureNotContains(t, mylib2Cflags, "-include ")
1018
1019 // Ensure that genstub is invoked with --apex
Colin Crossa717db72020-10-23 14:53:06 -07001020 ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("genStubSrc").Args["flags"])
Colin Cross7812fd32020-09-25 12:35:10 -07001021
1022 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
1023 "lib64/mylib.so",
1024 "lib64/mylib3.so",
1025 "lib64/mylib4.so",
1026 })
1027}
1028
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001029func TestApex_PlatformUsesLatestStubFromApex(t *testing.T) {
1030 t.Parallel()
1031 // myapex (Z)
1032 // mylib -----------------.
1033 // |
1034 // otherapex (29) |
1035 // libstub's versions: 29 Z current
1036 // |
1037 // <platform> |
1038 // libplatform ----------------'
Colin Cross1c460562021-02-16 17:55:47 -08001039 ctx := testApex(t, `
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001040 apex {
1041 name: "myapex",
1042 key: "myapex.key",
1043 native_shared_libs: ["mylib"],
1044 min_sdk_version: "Z", // non-final
1045 }
1046
1047 cc_library {
1048 name: "mylib",
1049 srcs: ["mylib.cpp"],
1050 shared_libs: ["libstub"],
1051 apex_available: ["myapex"],
1052 min_sdk_version: "Z",
1053 }
1054
1055 apex_key {
1056 name: "myapex.key",
1057 public_key: "testkey.avbpubkey",
1058 private_key: "testkey.pem",
1059 }
1060
1061 apex {
1062 name: "otherapex",
1063 key: "myapex.key",
1064 native_shared_libs: ["libstub"],
1065 min_sdk_version: "29",
1066 }
1067
1068 cc_library {
1069 name: "libstub",
1070 srcs: ["mylib.cpp"],
1071 stubs: {
1072 versions: ["29", "Z", "current"],
1073 },
1074 apex_available: ["otherapex"],
1075 min_sdk_version: "29",
1076 }
1077
1078 // platform module depending on libstub from otherapex should use the latest stub("current")
1079 cc_library {
1080 name: "libplatform",
1081 srcs: ["mylib.cpp"],
1082 shared_libs: ["libstub"],
1083 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001084 `,
1085 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1086 variables.Platform_sdk_codename = proptools.StringPtr("Z")
1087 variables.Platform_sdk_final = proptools.BoolPtr(false)
1088 variables.Platform_version_active_codenames = []string{"Z"}
1089 }),
1090 )
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001091
Jiyong Park55549df2021-02-26 23:57:23 +09001092 // Ensure that mylib from myapex is built against the latest stub (current)
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001093 mylibCflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
Jiyong Park55549df2021-02-26 23:57:23 +09001094 ensureContains(t, mylibCflags, "-D__LIBSTUB_API__=10000 ")
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001095 mylibLdflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
Jiyong Park55549df2021-02-26 23:57:23 +09001096 ensureContains(t, mylibLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001097
1098 // Ensure that libplatform is built against latest stub ("current") of mylib3 from the apex
1099 libplatformCflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
1100 ensureContains(t, libplatformCflags, "-D__LIBSTUB_API__=10000 ") // "current" maps to 10000
1101 libplatformLdflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
1102 ensureContains(t, libplatformLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
1103}
1104
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001105func TestApexWithExplicitStubsDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001106 ctx := testApex(t, `
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001107 apex {
Jiyong Park83dc74b2020-01-14 18:38:44 +09001108 name: "myapex2",
1109 key: "myapex2.key",
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001110 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001111 updatable: false,
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001112 }
1113
1114 apex_key {
Jiyong Park83dc74b2020-01-14 18:38:44 +09001115 name: "myapex2.key",
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001116 public_key: "testkey.avbpubkey",
1117 private_key: "testkey.pem",
1118 }
1119
1120 cc_library {
1121 name: "mylib",
1122 srcs: ["mylib.cpp"],
1123 shared_libs: ["libfoo#10"],
Jiyong Park678c8812020-02-07 17:25:49 +09001124 static_libs: ["libbaz"],
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001125 system_shared_libs: [],
1126 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001127 apex_available: [ "myapex2" ],
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001128 }
1129
1130 cc_library {
1131 name: "libfoo",
1132 srcs: ["mylib.cpp"],
1133 shared_libs: ["libbar"],
1134 system_shared_libs: [],
1135 stl: "none",
1136 stubs: {
1137 versions: ["10", "20", "30"],
1138 },
1139 }
1140
1141 cc_library {
1142 name: "libbar",
1143 srcs: ["mylib.cpp"],
1144 system_shared_libs: [],
1145 stl: "none",
1146 }
1147
Jiyong Park678c8812020-02-07 17:25:49 +09001148 cc_library_static {
1149 name: "libbaz",
1150 srcs: ["mylib.cpp"],
1151 system_shared_libs: [],
1152 stl: "none",
1153 apex_available: [ "myapex2" ],
1154 }
1155
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001156 `)
1157
Jiyong Park83dc74b2020-01-14 18:38:44 +09001158 apexRule := ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Rule("apexRule")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001159 copyCmds := apexRule.Args["copy_commands"]
1160
1161 // Ensure that direct non-stubs dep is always included
1162 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
1163
1164 // Ensure that indirect stubs dep is not included
1165 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
1166
1167 // Ensure that dependency of stubs is not included
1168 ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so")
1169
Colin Crossaede88c2020-08-11 12:17:01 -07001170 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001171
1172 // Ensure that mylib is linking with version 10 of libfoo
Jiyong Park3ff16992019-12-27 14:11:47 +09001173 ensureContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared_10/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001174 // ... and not linking to the non-stub (impl) variant of libfoo
Jiyong Park3ff16992019-12-27 14:11:47 +09001175 ensureNotContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001176
Jiyong Park3ff16992019-12-27 14:11:47 +09001177 libFooStubsLdFlags := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_10").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001178
1179 // Ensure that libfoo stubs is not linking to libbar (since it is a stubs)
1180 ensureNotContains(t, libFooStubsLdFlags, "libbar.so")
Jiyong Park83dc74b2020-01-14 18:38:44 +09001181
Artur Satayeva8bd1132020-04-27 18:07:06 +01001182 fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +01001183 ensureListContains(t, fullDepsInfo, " libfoo(minSdkVersion:(no version)) (external) <- mylib")
Jiyong Park678c8812020-02-07 17:25:49 +09001184
Artur Satayeva8bd1132020-04-27 18:07:06 +01001185 flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +01001186 ensureListContains(t, flatDepsInfo, "libfoo(minSdkVersion:(no version)) (external)")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001187}
1188
Jooyung Hand3639552019-08-09 12:57:43 +09001189func TestApexWithRuntimeLibsDependency(t *testing.T) {
1190 /*
1191 myapex
1192 |
1193 v (runtime_libs)
1194 mylib ------+------> libfoo [provides stub]
1195 |
1196 `------> libbar
1197 */
Colin Cross1c460562021-02-16 17:55:47 -08001198 ctx := testApex(t, `
Jooyung Hand3639552019-08-09 12:57:43 +09001199 apex {
1200 name: "myapex",
1201 key: "myapex.key",
1202 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001203 updatable: false,
Jooyung Hand3639552019-08-09 12:57:43 +09001204 }
1205
1206 apex_key {
1207 name: "myapex.key",
1208 public_key: "testkey.avbpubkey",
1209 private_key: "testkey.pem",
1210 }
1211
1212 cc_library {
1213 name: "mylib",
1214 srcs: ["mylib.cpp"],
1215 runtime_libs: ["libfoo", "libbar"],
1216 system_shared_libs: [],
1217 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001218 apex_available: [ "myapex" ],
Jooyung Hand3639552019-08-09 12:57:43 +09001219 }
1220
1221 cc_library {
1222 name: "libfoo",
1223 srcs: ["mylib.cpp"],
1224 system_shared_libs: [],
1225 stl: "none",
1226 stubs: {
1227 versions: ["10", "20", "30"],
1228 },
1229 }
1230
1231 cc_library {
1232 name: "libbar",
1233 srcs: ["mylib.cpp"],
1234 system_shared_libs: [],
1235 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001236 apex_available: [ "myapex" ],
Jooyung Hand3639552019-08-09 12:57:43 +09001237 }
1238
1239 `)
1240
Sundong Ahnabb64432019-10-22 13:58:29 +09001241 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jooyung Hand3639552019-08-09 12:57:43 +09001242 copyCmds := apexRule.Args["copy_commands"]
1243
1244 // Ensure that direct non-stubs dep is always included
1245 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
1246
1247 // Ensure that indirect stubs dep is not included
1248 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
1249
1250 // Ensure that runtime_libs dep in included
1251 ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
1252
Sundong Ahnabb64432019-10-22 13:58:29 +09001253 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001254 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
1255 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.so")
Jooyung Hand3639552019-08-09 12:57:43 +09001256
1257}
1258
Paul Duffina02cae32021-03-09 01:44:06 +00001259var prepareForTestOfRuntimeApexWithHwasan = android.GroupFixturePreparers(
1260 cc.PrepareForTestWithCcBuildComponents,
1261 PrepareForTestWithApexBuildComponents,
1262 android.FixtureAddTextFile("bionic/apex/Android.bp", `
Jooyung Han8ce8db92020-05-15 19:05:05 +09001263 apex {
1264 name: "com.android.runtime",
1265 key: "com.android.runtime.key",
1266 native_shared_libs: ["libc"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001267 updatable: false,
Jooyung Han8ce8db92020-05-15 19:05:05 +09001268 }
1269
1270 apex_key {
1271 name: "com.android.runtime.key",
1272 public_key: "testkey.avbpubkey",
1273 private_key: "testkey.pem",
1274 }
Paul Duffina02cae32021-03-09 01:44:06 +00001275 `),
1276 android.FixtureAddFile("system/sepolicy/apex/com.android.runtime-file_contexts", nil),
1277)
Jooyung Han8ce8db92020-05-15 19:05:05 +09001278
Paul Duffina02cae32021-03-09 01:44:06 +00001279func TestRuntimeApexShouldInstallHwasanIfLibcDependsOnIt(t *testing.T) {
Paul Duffin70d3bee2021-03-21 11:26:05 +00001280 result := android.GroupFixturePreparers(prepareForTestOfRuntimeApexWithHwasan).RunTestWithBp(t, `
Jooyung Han8ce8db92020-05-15 19:05:05 +09001281 cc_library {
1282 name: "libc",
1283 no_libcrt: true,
1284 nocrt: true,
1285 stl: "none",
1286 system_shared_libs: [],
1287 stubs: { versions: ["1"] },
1288 apex_available: ["com.android.runtime"],
1289
1290 sanitize: {
1291 hwaddress: true,
1292 }
1293 }
1294
1295 cc_prebuilt_library_shared {
1296 name: "libclang_rt.hwasan-aarch64-android",
1297 no_libcrt: true,
1298 nocrt: true,
1299 stl: "none",
1300 system_shared_libs: [],
1301 srcs: [""],
1302 stubs: { versions: ["1"] },
1303
1304 sanitize: {
1305 never: true,
1306 },
Paul Duffina02cae32021-03-09 01:44:06 +00001307 } `)
1308 ctx := result.TestContext
Jooyung Han8ce8db92020-05-15 19:05:05 +09001309
1310 ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
1311 "lib64/bionic/libc.so",
1312 "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
1313 })
1314
1315 hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared")
1316
1317 installed := hwasan.Description("install libclang_rt.hwasan")
1318 ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
1319
1320 symlink := hwasan.Description("install symlink libclang_rt.hwasan")
1321 ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
1322 ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
1323}
1324
1325func TestRuntimeApexShouldInstallHwasanIfHwaddressSanitized(t *testing.T) {
Paul Duffin70d3bee2021-03-21 11:26:05 +00001326 result := android.GroupFixturePreparers(
Paul Duffina02cae32021-03-09 01:44:06 +00001327 prepareForTestOfRuntimeApexWithHwasan,
1328 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1329 variables.SanitizeDevice = []string{"hwaddress"}
1330 }),
1331 ).RunTestWithBp(t, `
Jooyung Han8ce8db92020-05-15 19:05:05 +09001332 cc_library {
1333 name: "libc",
1334 no_libcrt: true,
1335 nocrt: true,
1336 stl: "none",
1337 system_shared_libs: [],
1338 stubs: { versions: ["1"] },
1339 apex_available: ["com.android.runtime"],
1340 }
1341
1342 cc_prebuilt_library_shared {
1343 name: "libclang_rt.hwasan-aarch64-android",
1344 no_libcrt: true,
1345 nocrt: true,
1346 stl: "none",
1347 system_shared_libs: [],
1348 srcs: [""],
1349 stubs: { versions: ["1"] },
1350
1351 sanitize: {
1352 never: true,
1353 },
1354 }
Paul Duffina02cae32021-03-09 01:44:06 +00001355 `)
1356 ctx := result.TestContext
Jooyung Han8ce8db92020-05-15 19:05:05 +09001357
1358 ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
1359 "lib64/bionic/libc.so",
1360 "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
1361 })
1362
1363 hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared")
1364
1365 installed := hwasan.Description("install libclang_rt.hwasan")
1366 ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
1367
1368 symlink := hwasan.Description("install symlink libclang_rt.hwasan")
1369 ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
1370 ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
1371}
1372
Jooyung Han61b66e92020-03-21 14:21:46 +00001373func TestApexDependsOnLLNDKTransitively(t *testing.T) {
1374 testcases := []struct {
1375 name string
1376 minSdkVersion string
Colin Crossaede88c2020-08-11 12:17:01 -07001377 apexVariant string
Jooyung Han61b66e92020-03-21 14:21:46 +00001378 shouldLink string
1379 shouldNotLink []string
1380 }{
1381 {
Jiyong Park55549df2021-02-26 23:57:23 +09001382 name: "unspecified version links to the latest",
Jooyung Han749dc692020-04-15 11:03:39 +09001383 minSdkVersion: "",
Colin Crossaede88c2020-08-11 12:17:01 -07001384 apexVariant: "apex10000",
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001385 shouldLink: "current",
1386 shouldNotLink: []string{"29", "30"},
Jooyung Han61b66e92020-03-21 14:21:46 +00001387 },
1388 {
Jiyong Park55549df2021-02-26 23:57:23 +09001389 name: "always use the latest",
Jooyung Han749dc692020-04-15 11:03:39 +09001390 minSdkVersion: "min_sdk_version: \"29\",",
Colin Crossaede88c2020-08-11 12:17:01 -07001391 apexVariant: "apex29",
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001392 shouldLink: "current",
1393 shouldNotLink: []string{"29", "30"},
Jooyung Han61b66e92020-03-21 14:21:46 +00001394 },
1395 }
1396 for _, tc := range testcases {
1397 t.Run(tc.name, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001398 ctx := testApex(t, `
Jooyung Han61b66e92020-03-21 14:21:46 +00001399 apex {
1400 name: "myapex",
1401 key: "myapex.key",
1402 use_vendor: true,
1403 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001404 updatable: false,
Jooyung Han749dc692020-04-15 11:03:39 +09001405 `+tc.minSdkVersion+`
Jooyung Han61b66e92020-03-21 14:21:46 +00001406 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001407
Jooyung Han61b66e92020-03-21 14:21:46 +00001408 apex_key {
1409 name: "myapex.key",
1410 public_key: "testkey.avbpubkey",
1411 private_key: "testkey.pem",
1412 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001413
Jooyung Han61b66e92020-03-21 14:21:46 +00001414 cc_library {
1415 name: "mylib",
1416 srcs: ["mylib.cpp"],
1417 vendor_available: true,
1418 shared_libs: ["libbar"],
1419 system_shared_libs: [],
1420 stl: "none",
1421 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001422 min_sdk_version: "29",
Jooyung Han61b66e92020-03-21 14:21:46 +00001423 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001424
Jooyung Han61b66e92020-03-21 14:21:46 +00001425 cc_library {
1426 name: "libbar",
1427 srcs: ["mylib.cpp"],
1428 system_shared_libs: [],
1429 stl: "none",
1430 stubs: { versions: ["29","30"] },
Colin Cross203b4212021-04-26 17:19:41 -07001431 llndk: {
1432 symbol_file: "libbar.map.txt",
1433 }
Jooyung Han61b66e92020-03-21 14:21:46 +00001434 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001435 `,
1436 setUseVendorAllowListForTest([]string{"myapex"}),
1437 withUnbundledBuild,
1438 )
Jooyung Han9c80bae2019-08-20 17:30:57 +09001439
Jooyung Han61b66e92020-03-21 14:21:46 +00001440 // Ensure that LLNDK dep is not included
1441 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
1442 "lib64/mylib.so",
1443 })
Jooyung Han9c80bae2019-08-20 17:30:57 +09001444
Jooyung Han61b66e92020-03-21 14:21:46 +00001445 // Ensure that LLNDK dep is required
1446 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
1447 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
1448 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libbar.so")
Jooyung Han9c80bae2019-08-20 17:30:57 +09001449
Jiyong Parkf58c46e2021-04-01 21:35:20 +09001450 mylibLdFlags := ctx.ModuleForTests("mylib", "android_vendor.29_arm64_armv8-a_shared_"+tc.apexVariant).Rule("ld").Args["libFlags"]
1451 ensureContains(t, mylibLdFlags, "libbar/android_vendor.29_arm64_armv8-a_shared_"+tc.shouldLink+"/libbar.so")
Jooyung Han61b66e92020-03-21 14:21:46 +00001452 for _, ver := range tc.shouldNotLink {
Jiyong Parkf58c46e2021-04-01 21:35:20 +09001453 ensureNotContains(t, mylibLdFlags, "libbar/android_vendor.29_arm64_armv8-a_shared_"+ver+"/libbar.so")
Jooyung Han61b66e92020-03-21 14:21:46 +00001454 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001455
Jiyong Parkf58c46e2021-04-01 21:35:20 +09001456 mylibCFlags := ctx.ModuleForTests("mylib", "android_vendor.29_arm64_armv8-a_static_"+tc.apexVariant).Rule("cc").Args["cFlags"]
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001457 ver := tc.shouldLink
1458 if tc.shouldLink == "current" {
1459 ver = strconv.Itoa(android.FutureApiLevelInt)
1460 }
1461 ensureContains(t, mylibCFlags, "__LIBBAR_API__="+ver)
Jooyung Han61b66e92020-03-21 14:21:46 +00001462 })
1463 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001464}
1465
Jiyong Park25fc6a92018-11-18 18:02:45 +09001466func TestApexWithSystemLibsStubs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001467 ctx := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +09001468 apex {
1469 name: "myapex",
1470 key: "myapex.key",
1471 native_shared_libs: ["mylib", "mylib_shared", "libdl", "libm"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001472 updatable: false,
Jiyong Park25fc6a92018-11-18 18:02:45 +09001473 }
1474
1475 apex_key {
1476 name: "myapex.key",
1477 public_key: "testkey.avbpubkey",
1478 private_key: "testkey.pem",
1479 }
1480
1481 cc_library {
1482 name: "mylib",
1483 srcs: ["mylib.cpp"],
Colin Cross0de8a1e2020-09-18 14:15:30 -07001484 system_shared_libs: ["libc", "libm"],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001485 shared_libs: ["libdl#27"],
1486 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001487 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001488 }
1489
1490 cc_library_shared {
1491 name: "mylib_shared",
1492 srcs: ["mylib.cpp"],
1493 shared_libs: ["libdl#27"],
1494 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001495 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001496 }
1497
1498 cc_library {
Jiyong Parkb0788572018-12-20 22:10:17 +09001499 name: "libBootstrap",
1500 srcs: ["mylib.cpp"],
1501 stl: "none",
1502 bootstrap: true,
1503 }
Jiyong Park25fc6a92018-11-18 18:02:45 +09001504 `)
1505
Sundong Ahnabb64432019-10-22 13:58:29 +09001506 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001507 copyCmds := apexRule.Args["copy_commands"]
1508
1509 // Ensure that mylib, libm, libdl are included.
Alex Light5098a612018-11-29 17:12:15 -08001510 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Parkb0788572018-12-20 22:10:17 +09001511 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libm.so")
1512 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001513
1514 // Ensure that libc is not included (since it has stubs and not listed in native_shared_libs)
Jiyong Parkb0788572018-12-20 22:10:17 +09001515 ensureNotContains(t, copyCmds, "image.apex/lib64/bionic/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001516
Colin Crossaede88c2020-08-11 12:17:01 -07001517 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
1518 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
1519 mylibSharedCFlags := ctx.ModuleForTests("mylib_shared", "android_arm64_armv8-a_shared_apex10000").Rule("cc").Args["cFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +09001520
1521 // For dependency to libc
1522 // Ensure that mylib is linking with the latest version of stubs
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001523 ensureContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared_current/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001524 // ... and not linking to the non-stub (impl) variant
Jiyong Park3ff16992019-12-27 14:11:47 +09001525 ensureNotContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001526 // ... Cflags from stub is correctly exported to mylib
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001527 ensureContains(t, mylibCFlags, "__LIBC_API__=10000")
1528 ensureContains(t, mylibSharedCFlags, "__LIBC_API__=10000")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001529
1530 // For dependency to libm
1531 // Ensure that mylib is linking with the non-stub (impl) variant
Colin Crossaede88c2020-08-11 12:17:01 -07001532 ensureContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_apex10000/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001533 // ... and not linking to the stub variant
Jiyong Park3ff16992019-12-27 14:11:47 +09001534 ensureNotContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_29/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001535 // ... and is not compiling with the stub
1536 ensureNotContains(t, mylibCFlags, "__LIBM_API__=29")
1537 ensureNotContains(t, mylibSharedCFlags, "__LIBM_API__=29")
1538
1539 // For dependency to libdl
1540 // Ensure that mylib is linking with the specified version of stubs
Jiyong Park3ff16992019-12-27 14:11:47 +09001541 ensureContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_27/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001542 // ... and not linking to the other versions of stubs
Jiyong Park3ff16992019-12-27 14:11:47 +09001543 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_28/libdl.so")
1544 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_29/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001545 // ... and not linking to the non-stub (impl) variant
Colin Crossaede88c2020-08-11 12:17:01 -07001546 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_apex10000/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001547 // ... Cflags from stub is correctly exported to mylib
1548 ensureContains(t, mylibCFlags, "__LIBDL_API__=27")
1549 ensureContains(t, mylibSharedCFlags, "__LIBDL_API__=27")
Jiyong Parkb0788572018-12-20 22:10:17 +09001550
1551 // Ensure that libBootstrap is depending on the platform variant of bionic libs
Colin Cross7113d202019-11-20 16:39:12 -08001552 libFlags := ctx.ModuleForTests("libBootstrap", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
1553 ensureContains(t, libFlags, "libc/android_arm64_armv8-a_shared/libc.so")
1554 ensureContains(t, libFlags, "libm/android_arm64_armv8-a_shared/libm.so")
1555 ensureContains(t, libFlags, "libdl/android_arm64_armv8-a_shared/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001556}
Jiyong Park7c2ee712018-12-07 00:42:25 +09001557
Jooyung Han749dc692020-04-15 11:03:39 +09001558func TestApexMinSdkVersion_NativeModulesShouldBeBuiltAgainstStubs(t *testing.T) {
Jiyong Park55549df2021-02-26 23:57:23 +09001559 // there are three links between liba --> libz.
1560 // 1) myapex -> libx -> liba -> libz : this should be #30 link
Jooyung Han749dc692020-04-15 11:03:39 +09001561 // 2) otherapex -> liby -> liba -> libz : this should be #30 link
Jooyung Han03b51852020-02-26 22:45:42 +09001562 // 3) (platform) -> liba -> libz : this should be non-stub link
Colin Cross1c460562021-02-16 17:55:47 -08001563 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001564 apex {
1565 name: "myapex",
1566 key: "myapex.key",
1567 native_shared_libs: ["libx"],
Jooyung Han749dc692020-04-15 11:03:39 +09001568 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001569 }
1570
1571 apex {
1572 name: "otherapex",
1573 key: "myapex.key",
1574 native_shared_libs: ["liby"],
Jooyung Han749dc692020-04-15 11:03:39 +09001575 min_sdk_version: "30",
Jooyung Han03b51852020-02-26 22:45:42 +09001576 }
1577
1578 apex_key {
1579 name: "myapex.key",
1580 public_key: "testkey.avbpubkey",
1581 private_key: "testkey.pem",
1582 }
1583
1584 cc_library {
1585 name: "libx",
1586 shared_libs: ["liba"],
1587 system_shared_libs: [],
1588 stl: "none",
1589 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001590 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001591 }
1592
1593 cc_library {
1594 name: "liby",
1595 shared_libs: ["liba"],
1596 system_shared_libs: [],
1597 stl: "none",
1598 apex_available: [ "otherapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001599 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001600 }
1601
1602 cc_library {
1603 name: "liba",
1604 shared_libs: ["libz"],
1605 system_shared_libs: [],
1606 stl: "none",
1607 apex_available: [
1608 "//apex_available:anyapex",
1609 "//apex_available:platform",
1610 ],
Jooyung Han749dc692020-04-15 11:03:39 +09001611 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001612 }
1613
1614 cc_library {
1615 name: "libz",
1616 system_shared_libs: [],
1617 stl: "none",
1618 stubs: {
Jooyung Han749dc692020-04-15 11:03:39 +09001619 versions: ["28", "30"],
Jooyung Han03b51852020-02-26 22:45:42 +09001620 },
1621 }
Jooyung Han749dc692020-04-15 11:03:39 +09001622 `)
Jooyung Han03b51852020-02-26 22:45:42 +09001623
1624 expectLink := func(from, from_variant, to, to_variant string) {
1625 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1626 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1627 }
1628 expectNoLink := func(from, from_variant, to, to_variant string) {
1629 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1630 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1631 }
1632 // platform liba is linked to non-stub version
1633 expectLink("liba", "shared", "libz", "shared")
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001634 // liba in myapex is linked to current
1635 expectLink("liba", "shared_apex29", "libz", "shared_current")
1636 expectNoLink("liba", "shared_apex29", "libz", "shared_30")
Jiyong Park55549df2021-02-26 23:57:23 +09001637 expectNoLink("liba", "shared_apex29", "libz", "shared_28")
Colin Crossaede88c2020-08-11 12:17:01 -07001638 expectNoLink("liba", "shared_apex29", "libz", "shared")
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001639 // liba in otherapex is linked to current
1640 expectLink("liba", "shared_apex30", "libz", "shared_current")
1641 expectNoLink("liba", "shared_apex30", "libz", "shared_30")
Colin Crossaede88c2020-08-11 12:17:01 -07001642 expectNoLink("liba", "shared_apex30", "libz", "shared_28")
1643 expectNoLink("liba", "shared_apex30", "libz", "shared")
Jooyung Han03b51852020-02-26 22:45:42 +09001644}
1645
Jooyung Hanaed150d2020-04-02 01:41:41 +09001646func TestApexMinSdkVersion_SupportsCodeNames(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001647 ctx := testApex(t, `
Jooyung Hanaed150d2020-04-02 01:41:41 +09001648 apex {
1649 name: "myapex",
1650 key: "myapex.key",
1651 native_shared_libs: ["libx"],
1652 min_sdk_version: "R",
1653 }
1654
1655 apex_key {
1656 name: "myapex.key",
1657 public_key: "testkey.avbpubkey",
1658 private_key: "testkey.pem",
1659 }
1660
1661 cc_library {
1662 name: "libx",
1663 shared_libs: ["libz"],
1664 system_shared_libs: [],
1665 stl: "none",
1666 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001667 min_sdk_version: "R",
Jooyung Hanaed150d2020-04-02 01:41:41 +09001668 }
1669
1670 cc_library {
1671 name: "libz",
1672 system_shared_libs: [],
1673 stl: "none",
1674 stubs: {
1675 versions: ["29", "R"],
1676 },
1677 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001678 `,
1679 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1680 variables.Platform_version_active_codenames = []string{"R"}
1681 }),
1682 )
Jooyung Hanaed150d2020-04-02 01:41:41 +09001683
1684 expectLink := func(from, from_variant, to, to_variant string) {
1685 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1686 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1687 }
1688 expectNoLink := func(from, from_variant, to, to_variant string) {
1689 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1690 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1691 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001692 expectLink("libx", "shared_apex10000", "libz", "shared_current")
1693 expectNoLink("libx", "shared_apex10000", "libz", "shared_R")
Colin Crossaede88c2020-08-11 12:17:01 -07001694 expectNoLink("libx", "shared_apex10000", "libz", "shared_29")
1695 expectNoLink("libx", "shared_apex10000", "libz", "shared")
Jooyung Hanaed150d2020-04-02 01:41:41 +09001696}
1697
Jooyung Han749dc692020-04-15 11:03:39 +09001698func TestApexMinSdkVersion_DefaultsToLatest(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001699 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001700 apex {
1701 name: "myapex",
1702 key: "myapex.key",
1703 native_shared_libs: ["libx"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001704 updatable: false,
Jooyung Han03b51852020-02-26 22:45:42 +09001705 }
1706
1707 apex_key {
1708 name: "myapex.key",
1709 public_key: "testkey.avbpubkey",
1710 private_key: "testkey.pem",
1711 }
1712
1713 cc_library {
1714 name: "libx",
1715 shared_libs: ["libz"],
1716 system_shared_libs: [],
1717 stl: "none",
1718 apex_available: [ "myapex" ],
1719 }
1720
1721 cc_library {
1722 name: "libz",
1723 system_shared_libs: [],
1724 stl: "none",
1725 stubs: {
1726 versions: ["1", "2"],
1727 },
1728 }
1729 `)
1730
1731 expectLink := func(from, from_variant, to, to_variant string) {
1732 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1733 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1734 }
1735 expectNoLink := func(from, from_variant, to, to_variant string) {
1736 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1737 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1738 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001739 expectLink("libx", "shared_apex10000", "libz", "shared_current")
Colin Crossaede88c2020-08-11 12:17:01 -07001740 expectNoLink("libx", "shared_apex10000", "libz", "shared_1")
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001741 expectNoLink("libx", "shared_apex10000", "libz", "shared_2")
Colin Crossaede88c2020-08-11 12:17:01 -07001742 expectNoLink("libx", "shared_apex10000", "libz", "shared")
Jooyung Han03b51852020-02-26 22:45:42 +09001743}
1744
1745func TestPlatformUsesLatestStubsFromApexes(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001746 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001747 apex {
1748 name: "myapex",
1749 key: "myapex.key",
1750 native_shared_libs: ["libx"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001751 updatable: false,
Jooyung Han03b51852020-02-26 22:45:42 +09001752 }
1753
1754 apex_key {
1755 name: "myapex.key",
1756 public_key: "testkey.avbpubkey",
1757 private_key: "testkey.pem",
1758 }
1759
1760 cc_library {
1761 name: "libx",
1762 system_shared_libs: [],
1763 stl: "none",
1764 apex_available: [ "myapex" ],
1765 stubs: {
1766 versions: ["1", "2"],
1767 },
1768 }
1769
1770 cc_library {
1771 name: "libz",
1772 shared_libs: ["libx"],
1773 system_shared_libs: [],
1774 stl: "none",
1775 }
1776 `)
1777
1778 expectLink := func(from, from_variant, to, to_variant string) {
Colin Cross56a83212020-09-15 18:30:11 -07001779 t.Helper()
Jooyung Han03b51852020-02-26 22:45:42 +09001780 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1781 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1782 }
1783 expectNoLink := func(from, from_variant, to, to_variant string) {
Colin Cross56a83212020-09-15 18:30:11 -07001784 t.Helper()
Jooyung Han03b51852020-02-26 22:45:42 +09001785 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1786 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1787 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001788 expectLink("libz", "shared", "libx", "shared_current")
1789 expectNoLink("libz", "shared", "libx", "shared_2")
Jooyung Han03b51852020-02-26 22:45:42 +09001790 expectNoLink("libz", "shared", "libz", "shared_1")
1791 expectNoLink("libz", "shared", "libz", "shared")
1792}
1793
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001794var prepareForTestWithSantitizeHwaddress = android.FixtureModifyProductVariables(
1795 func(variables android.FixtureProductVariables) {
1796 variables.SanitizeDevice = []string{"hwaddress"}
1797 },
1798)
1799
Jooyung Han75568392020-03-20 04:29:24 +09001800func TestQApexesUseLatestStubsInBundledBuildsAndHWASAN(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001801 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001802 apex {
1803 name: "myapex",
1804 key: "myapex.key",
1805 native_shared_libs: ["libx"],
1806 min_sdk_version: "29",
1807 }
1808
1809 apex_key {
1810 name: "myapex.key",
1811 public_key: "testkey.avbpubkey",
1812 private_key: "testkey.pem",
1813 }
1814
1815 cc_library {
1816 name: "libx",
1817 shared_libs: ["libbar"],
1818 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001819 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001820 }
1821
1822 cc_library {
1823 name: "libbar",
1824 stubs: {
1825 versions: ["29", "30"],
1826 },
1827 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001828 `,
1829 prepareForTestWithSantitizeHwaddress,
1830 )
Jooyung Han03b51852020-02-26 22:45:42 +09001831 expectLink := func(from, from_variant, to, to_variant string) {
1832 ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
1833 libFlags := ld.Args["libFlags"]
1834 ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1835 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001836 expectLink("libx", "shared_hwasan_apex29", "libbar", "shared_current")
Jooyung Han03b51852020-02-26 22:45:42 +09001837}
1838
Jooyung Han75568392020-03-20 04:29:24 +09001839func TestQTargetApexUsesStaticUnwinder(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001840 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001841 apex {
1842 name: "myapex",
1843 key: "myapex.key",
1844 native_shared_libs: ["libx"],
1845 min_sdk_version: "29",
1846 }
1847
1848 apex_key {
1849 name: "myapex.key",
1850 public_key: "testkey.avbpubkey",
1851 private_key: "testkey.pem",
1852 }
1853
1854 cc_library {
1855 name: "libx",
1856 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001857 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001858 }
Jooyung Han75568392020-03-20 04:29:24 +09001859 `)
Jooyung Han03b51852020-02-26 22:45:42 +09001860
1861 // ensure apex variant of c++ is linked with static unwinder
Colin Crossaede88c2020-08-11 12:17:01 -07001862 cm := ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared_apex29").Module().(*cc.Module)
Ryan Prichardb35a85e2021-01-13 19:18:53 -08001863 ensureListContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
Jooyung Han03b51852020-02-26 22:45:42 +09001864 // note that platform variant is not.
1865 cm = ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared").Module().(*cc.Module)
Ryan Prichardb35a85e2021-01-13 19:18:53 -08001866 ensureListNotContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
Jooyung Han03b51852020-02-26 22:45:42 +09001867}
1868
Jooyung Han749dc692020-04-15 11:03:39 +09001869func TestApexMinSdkVersion_ErrorIfIncompatibleVersion(t *testing.T) {
1870 testApexError(t, `module "mylib".*: should support min_sdk_version\(29\)`, `
Jooyung Han03b51852020-02-26 22:45:42 +09001871 apex {
1872 name: "myapex",
1873 key: "myapex.key",
Jooyung Han749dc692020-04-15 11:03:39 +09001874 native_shared_libs: ["mylib"],
1875 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001876 }
1877
1878 apex_key {
1879 name: "myapex.key",
1880 public_key: "testkey.avbpubkey",
1881 private_key: "testkey.pem",
1882 }
Jooyung Han749dc692020-04-15 11:03:39 +09001883
1884 cc_library {
1885 name: "mylib",
1886 srcs: ["mylib.cpp"],
1887 system_shared_libs: [],
1888 stl: "none",
1889 apex_available: [
1890 "myapex",
1891 ],
1892 min_sdk_version: "30",
1893 }
1894 `)
Ivan Lozano3e9f9e42020-12-04 15:05:43 -05001895
1896 testApexError(t, `module "libfoo.ffi".*: should support min_sdk_version\(29\)`, `
1897 apex {
1898 name: "myapex",
1899 key: "myapex.key",
1900 native_shared_libs: ["libfoo.ffi"],
1901 min_sdk_version: "29",
1902 }
1903
1904 apex_key {
1905 name: "myapex.key",
1906 public_key: "testkey.avbpubkey",
1907 private_key: "testkey.pem",
1908 }
1909
1910 rust_ffi_shared {
1911 name: "libfoo.ffi",
1912 srcs: ["foo.rs"],
1913 crate_name: "foo",
1914 apex_available: [
1915 "myapex",
1916 ],
1917 min_sdk_version: "30",
1918 }
1919 `)
Jaewoong Jung56e12db2021-04-02 00:38:25 +00001920
1921 testApexError(t, `module "libfoo".*: should support min_sdk_version\(29\)`, `
1922 apex {
1923 name: "myapex",
1924 key: "myapex.key",
1925 java_libs: ["libfoo"],
1926 min_sdk_version: "29",
1927 }
1928
1929 apex_key {
1930 name: "myapex.key",
1931 public_key: "testkey.avbpubkey",
1932 private_key: "testkey.pem",
1933 }
1934
1935 java_import {
1936 name: "libfoo",
1937 jars: ["libfoo.jar"],
1938 apex_available: [
1939 "myapex",
1940 ],
1941 min_sdk_version: "30",
1942 }
1943 `)
Jooyung Han749dc692020-04-15 11:03:39 +09001944}
1945
1946func TestApexMinSdkVersion_Okay(t *testing.T) {
1947 testApex(t, `
1948 apex {
1949 name: "myapex",
1950 key: "myapex.key",
1951 native_shared_libs: ["libfoo"],
1952 java_libs: ["libbar"],
1953 min_sdk_version: "29",
1954 }
1955
1956 apex_key {
1957 name: "myapex.key",
1958 public_key: "testkey.avbpubkey",
1959 private_key: "testkey.pem",
1960 }
1961
1962 cc_library {
1963 name: "libfoo",
1964 srcs: ["mylib.cpp"],
1965 shared_libs: ["libfoo_dep"],
1966 apex_available: ["myapex"],
1967 min_sdk_version: "29",
1968 }
1969
1970 cc_library {
1971 name: "libfoo_dep",
1972 srcs: ["mylib.cpp"],
1973 apex_available: ["myapex"],
1974 min_sdk_version: "29",
1975 }
1976
1977 java_library {
1978 name: "libbar",
1979 sdk_version: "current",
1980 srcs: ["a.java"],
Jaewoong Jung56e12db2021-04-02 00:38:25 +00001981 static_libs: [
1982 "libbar_dep",
1983 "libbar_import_dep",
1984 ],
Jooyung Han749dc692020-04-15 11:03:39 +09001985 apex_available: ["myapex"],
1986 min_sdk_version: "29",
1987 }
1988
1989 java_library {
1990 name: "libbar_dep",
1991 sdk_version: "current",
1992 srcs: ["a.java"],
1993 apex_available: ["myapex"],
1994 min_sdk_version: "29",
1995 }
Jaewoong Jung56e12db2021-04-02 00:38:25 +00001996
1997 java_import {
1998 name: "libbar_import_dep",
1999 jars: ["libbar.jar"],
2000 apex_available: ["myapex"],
2001 min_sdk_version: "29",
2002 }
Jooyung Han03b51852020-02-26 22:45:42 +09002003 `)
2004}
2005
Artur Satayev8cf899a2020-04-15 17:29:42 +01002006func TestJavaStableSdkVersion(t *testing.T) {
2007 testCases := []struct {
2008 name string
2009 expectedError string
2010 bp string
2011 }{
2012 {
2013 name: "Non-updatable apex with non-stable dep",
2014 bp: `
2015 apex {
2016 name: "myapex",
2017 java_libs: ["myjar"],
2018 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002019 updatable: false,
Artur Satayev8cf899a2020-04-15 17:29:42 +01002020 }
2021 apex_key {
2022 name: "myapex.key",
2023 public_key: "testkey.avbpubkey",
2024 private_key: "testkey.pem",
2025 }
2026 java_library {
2027 name: "myjar",
2028 srcs: ["foo/bar/MyClass.java"],
Paul Duffin043f5e72021-03-05 00:00:01 +00002029 sdk_version: "test_current",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002030 apex_available: ["myapex"],
2031 }
2032 `,
2033 },
2034 {
2035 name: "Updatable apex with stable dep",
2036 bp: `
2037 apex {
2038 name: "myapex",
2039 java_libs: ["myjar"],
2040 key: "myapex.key",
2041 updatable: true,
2042 min_sdk_version: "29",
2043 }
2044 apex_key {
2045 name: "myapex.key",
2046 public_key: "testkey.avbpubkey",
2047 private_key: "testkey.pem",
2048 }
2049 java_library {
2050 name: "myjar",
2051 srcs: ["foo/bar/MyClass.java"],
2052 sdk_version: "current",
2053 apex_available: ["myapex"],
Jooyung Han749dc692020-04-15 11:03:39 +09002054 min_sdk_version: "29",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002055 }
2056 `,
2057 },
2058 {
2059 name: "Updatable apex with non-stable dep",
2060 expectedError: "cannot depend on \"myjar\"",
2061 bp: `
2062 apex {
2063 name: "myapex",
2064 java_libs: ["myjar"],
2065 key: "myapex.key",
2066 updatable: true,
2067 }
2068 apex_key {
2069 name: "myapex.key",
2070 public_key: "testkey.avbpubkey",
2071 private_key: "testkey.pem",
2072 }
2073 java_library {
2074 name: "myjar",
2075 srcs: ["foo/bar/MyClass.java"],
Paul Duffin043f5e72021-03-05 00:00:01 +00002076 sdk_version: "test_current",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002077 apex_available: ["myapex"],
2078 }
2079 `,
2080 },
2081 {
Paul Duffin043f5e72021-03-05 00:00:01 +00002082 name: "Updatable apex with non-stable transitive dep",
2083 // This is not actually detecting that the transitive dependency is unstable, rather it is
2084 // detecting that the transitive dependency is building against a wider API surface than the
2085 // module that depends on it is using.
Jiyong Park670e0f62021-02-18 13:10:18 +09002086 expectedError: "compiles against Android API, but dependency \"transitive-jar\" is compiling against private API.",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002087 bp: `
2088 apex {
2089 name: "myapex",
2090 java_libs: ["myjar"],
2091 key: "myapex.key",
2092 updatable: true,
2093 }
2094 apex_key {
2095 name: "myapex.key",
2096 public_key: "testkey.avbpubkey",
2097 private_key: "testkey.pem",
2098 }
2099 java_library {
2100 name: "myjar",
2101 srcs: ["foo/bar/MyClass.java"],
2102 sdk_version: "current",
2103 apex_available: ["myapex"],
2104 static_libs: ["transitive-jar"],
2105 }
2106 java_library {
2107 name: "transitive-jar",
2108 srcs: ["foo/bar/MyClass.java"],
2109 sdk_version: "core_platform",
2110 apex_available: ["myapex"],
2111 }
2112 `,
2113 },
2114 }
2115
2116 for _, test := range testCases {
2117 t.Run(test.name, func(t *testing.T) {
2118 if test.expectedError == "" {
2119 testApex(t, test.bp)
2120 } else {
2121 testApexError(t, test.expectedError, test.bp)
2122 }
2123 })
2124 }
2125}
2126
Jooyung Han749dc692020-04-15 11:03:39 +09002127func TestApexMinSdkVersion_ErrorIfDepIsNewer(t *testing.T) {
2128 testApexError(t, `module "mylib2".*: should support min_sdk_version\(29\) for "myapex"`, `
2129 apex {
2130 name: "myapex",
2131 key: "myapex.key",
2132 native_shared_libs: ["mylib"],
2133 min_sdk_version: "29",
2134 }
2135
2136 apex_key {
2137 name: "myapex.key",
2138 public_key: "testkey.avbpubkey",
2139 private_key: "testkey.pem",
2140 }
2141
2142 cc_library {
2143 name: "mylib",
2144 srcs: ["mylib.cpp"],
2145 shared_libs: ["mylib2"],
2146 system_shared_libs: [],
2147 stl: "none",
2148 apex_available: [
2149 "myapex",
2150 ],
2151 min_sdk_version: "29",
2152 }
2153
2154 // indirect part of the apex
2155 cc_library {
2156 name: "mylib2",
2157 srcs: ["mylib.cpp"],
2158 system_shared_libs: [],
2159 stl: "none",
2160 apex_available: [
2161 "myapex",
2162 ],
2163 min_sdk_version: "30",
2164 }
2165 `)
2166}
2167
2168func TestApexMinSdkVersion_ErrorIfDepIsNewer_Java(t *testing.T) {
2169 testApexError(t, `module "bar".*: should support min_sdk_version\(29\) for "myapex"`, `
2170 apex {
2171 name: "myapex",
2172 key: "myapex.key",
2173 apps: ["AppFoo"],
2174 min_sdk_version: "29",
2175 }
2176
2177 apex_key {
2178 name: "myapex.key",
2179 public_key: "testkey.avbpubkey",
2180 private_key: "testkey.pem",
2181 }
2182
2183 android_app {
2184 name: "AppFoo",
2185 srcs: ["foo/bar/MyClass.java"],
2186 sdk_version: "current",
2187 min_sdk_version: "29",
2188 system_modules: "none",
2189 stl: "none",
2190 static_libs: ["bar"],
2191 apex_available: [ "myapex" ],
2192 }
2193
2194 java_library {
2195 name: "bar",
2196 sdk_version: "current",
2197 srcs: ["a.java"],
2198 apex_available: [ "myapex" ],
2199 }
2200 `)
2201}
2202
2203func TestApexMinSdkVersion_OkayEvenWhenDepIsNewer_IfItSatisfiesApexMinSdkVersion(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002204 ctx := testApex(t, `
Jooyung Han749dc692020-04-15 11:03:39 +09002205 apex {
2206 name: "myapex",
2207 key: "myapex.key",
2208 native_shared_libs: ["mylib"],
2209 min_sdk_version: "29",
2210 }
2211
2212 apex_key {
2213 name: "myapex.key",
2214 public_key: "testkey.avbpubkey",
2215 private_key: "testkey.pem",
2216 }
2217
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002218 // mylib in myapex will link to mylib2#current
Jooyung Han749dc692020-04-15 11:03:39 +09002219 // mylib in otherapex will link to mylib2(non-stub) in otherapex as well
2220 cc_library {
2221 name: "mylib",
2222 srcs: ["mylib.cpp"],
2223 shared_libs: ["mylib2"],
2224 system_shared_libs: [],
2225 stl: "none",
2226 apex_available: ["myapex", "otherapex"],
2227 min_sdk_version: "29",
2228 }
2229
2230 cc_library {
2231 name: "mylib2",
2232 srcs: ["mylib.cpp"],
2233 system_shared_libs: [],
2234 stl: "none",
2235 apex_available: ["otherapex"],
2236 stubs: { versions: ["29", "30"] },
2237 min_sdk_version: "30",
2238 }
2239
2240 apex {
2241 name: "otherapex",
2242 key: "myapex.key",
2243 native_shared_libs: ["mylib", "mylib2"],
2244 min_sdk_version: "30",
2245 }
2246 `)
2247 expectLink := func(from, from_variant, to, to_variant string) {
2248 ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
2249 libFlags := ld.Args["libFlags"]
2250 ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
2251 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002252 expectLink("mylib", "shared_apex29", "mylib2", "shared_current")
Colin Crossaede88c2020-08-11 12:17:01 -07002253 expectLink("mylib", "shared_apex30", "mylib2", "shared_apex30")
Jooyung Han749dc692020-04-15 11:03:39 +09002254}
2255
Jooyung Haned124c32021-01-26 11:43:46 +09002256func TestApexMinSdkVersion_WorksWithSdkCodename(t *testing.T) {
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002257 withSAsActiveCodeNames := android.FixtureModifyProductVariables(
2258 func(variables android.FixtureProductVariables) {
2259 variables.Platform_sdk_codename = proptools.StringPtr("S")
2260 variables.Platform_version_active_codenames = []string{"S"}
2261 },
2262 )
Jooyung Haned124c32021-01-26 11:43:46 +09002263 testApexError(t, `libbar.*: should support min_sdk_version\(S\)`, `
2264 apex {
2265 name: "myapex",
2266 key: "myapex.key",
2267 native_shared_libs: ["libfoo"],
2268 min_sdk_version: "S",
2269 }
2270 apex_key {
2271 name: "myapex.key",
2272 public_key: "testkey.avbpubkey",
2273 private_key: "testkey.pem",
2274 }
2275 cc_library {
2276 name: "libfoo",
2277 shared_libs: ["libbar"],
2278 apex_available: ["myapex"],
2279 min_sdk_version: "29",
2280 }
2281 cc_library {
2282 name: "libbar",
2283 apex_available: ["myapex"],
2284 }
2285 `, withSAsActiveCodeNames)
2286}
2287
2288func TestApexMinSdkVersion_WorksWithActiveCodenames(t *testing.T) {
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002289 withSAsActiveCodeNames := android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
2290 variables.Platform_sdk_codename = proptools.StringPtr("S")
2291 variables.Platform_version_active_codenames = []string{"S", "T"}
2292 })
Colin Cross1c460562021-02-16 17:55:47 -08002293 ctx := testApex(t, `
Jooyung Haned124c32021-01-26 11:43:46 +09002294 apex {
2295 name: "myapex",
2296 key: "myapex.key",
2297 native_shared_libs: ["libfoo"],
2298 min_sdk_version: "S",
2299 }
2300 apex_key {
2301 name: "myapex.key",
2302 public_key: "testkey.avbpubkey",
2303 private_key: "testkey.pem",
2304 }
2305 cc_library {
2306 name: "libfoo",
2307 shared_libs: ["libbar"],
2308 apex_available: ["myapex"],
2309 min_sdk_version: "S",
2310 }
2311 cc_library {
2312 name: "libbar",
2313 stubs: {
2314 symbol_file: "libbar.map.txt",
2315 versions: ["30", "S", "T"],
2316 },
2317 }
2318 `, withSAsActiveCodeNames)
2319
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002320 // ensure libfoo is linked with current version of libbar stub
Jooyung Haned124c32021-01-26 11:43:46 +09002321 libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_apex10000")
2322 libFlags := libfoo.Rule("ld").Args["libFlags"]
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002323 ensureContains(t, libFlags, "android_arm64_armv8-a_shared_current/libbar.so")
Jooyung Haned124c32021-01-26 11:43:46 +09002324}
2325
Jiyong Park7c2ee712018-12-07 00:42:25 +09002326func TestFilesInSubDir(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002327 ctx := testApex(t, `
Jiyong Park7c2ee712018-12-07 00:42:25 +09002328 apex {
2329 name: "myapex",
2330 key: "myapex.key",
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002331 native_shared_libs: ["mylib"],
2332 binaries: ["mybin"],
Jiyong Park7c2ee712018-12-07 00:42:25 +09002333 prebuilts: ["myetc"],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002334 compile_multilib: "both",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002335 updatable: false,
Jiyong Park7c2ee712018-12-07 00:42:25 +09002336 }
2337
2338 apex_key {
2339 name: "myapex.key",
2340 public_key: "testkey.avbpubkey",
2341 private_key: "testkey.pem",
2342 }
2343
2344 prebuilt_etc {
2345 name: "myetc",
2346 src: "myprebuilt",
2347 sub_dir: "foo/bar",
2348 }
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002349
2350 cc_library {
2351 name: "mylib",
2352 srcs: ["mylib.cpp"],
2353 relative_install_path: "foo/bar",
2354 system_shared_libs: [],
2355 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002356 apex_available: [ "myapex" ],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002357 }
2358
2359 cc_binary {
2360 name: "mybin",
2361 srcs: ["mylib.cpp"],
2362 relative_install_path: "foo/bar",
2363 system_shared_libs: [],
2364 static_executable: true,
2365 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002366 apex_available: [ "myapex" ],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002367 }
Jiyong Park7c2ee712018-12-07 00:42:25 +09002368 `)
2369
Sundong Ahnabb64432019-10-22 13:58:29 +09002370 generateFsRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("generateFsConfig")
Jiyong Park7c2ee712018-12-07 00:42:25 +09002371 dirs := strings.Split(generateFsRule.Args["exec_paths"], " ")
2372
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002373 // Ensure that the subdirectories are all listed
Jiyong Park7c2ee712018-12-07 00:42:25 +09002374 ensureListContains(t, dirs, "etc")
2375 ensureListContains(t, dirs, "etc/foo")
2376 ensureListContains(t, dirs, "etc/foo/bar")
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002377 ensureListContains(t, dirs, "lib64")
2378 ensureListContains(t, dirs, "lib64/foo")
2379 ensureListContains(t, dirs, "lib64/foo/bar")
2380 ensureListContains(t, dirs, "lib")
2381 ensureListContains(t, dirs, "lib/foo")
2382 ensureListContains(t, dirs, "lib/foo/bar")
2383
Jiyong Parkbd13e442019-03-15 18:10:35 +09002384 ensureListContains(t, dirs, "bin")
2385 ensureListContains(t, dirs, "bin/foo")
2386 ensureListContains(t, dirs, "bin/foo/bar")
Jiyong Park7c2ee712018-12-07 00:42:25 +09002387}
Jiyong Parkda6eb592018-12-19 17:12:36 +09002388
Jooyung Han35155c42020-02-06 17:33:20 +09002389func TestFilesInSubDirWhenNativeBridgeEnabled(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002390 ctx := testApex(t, `
Jooyung Han35155c42020-02-06 17:33:20 +09002391 apex {
2392 name: "myapex",
2393 key: "myapex.key",
2394 multilib: {
2395 both: {
2396 native_shared_libs: ["mylib"],
2397 binaries: ["mybin"],
2398 },
2399 },
2400 compile_multilib: "both",
2401 native_bridge_supported: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002402 updatable: false,
Jooyung Han35155c42020-02-06 17:33:20 +09002403 }
2404
2405 apex_key {
2406 name: "myapex.key",
2407 public_key: "testkey.avbpubkey",
2408 private_key: "testkey.pem",
2409 }
2410
2411 cc_library {
2412 name: "mylib",
2413 relative_install_path: "foo/bar",
2414 system_shared_libs: [],
2415 stl: "none",
2416 apex_available: [ "myapex" ],
2417 native_bridge_supported: true,
2418 }
2419
2420 cc_binary {
2421 name: "mybin",
2422 relative_install_path: "foo/bar",
2423 system_shared_libs: [],
2424 static_executable: true,
2425 stl: "none",
2426 apex_available: [ "myapex" ],
2427 native_bridge_supported: true,
2428 compile_multilib: "both", // default is "first" for binary
2429 multilib: {
2430 lib64: {
2431 suffix: "64",
2432 },
2433 },
2434 }
2435 `, withNativeBridgeEnabled)
2436 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2437 "bin/foo/bar/mybin",
2438 "bin/foo/bar/mybin64",
2439 "bin/arm/foo/bar/mybin",
2440 "bin/arm64/foo/bar/mybin64",
2441 "lib/foo/bar/mylib.so",
2442 "lib/arm/foo/bar/mylib.so",
2443 "lib64/foo/bar/mylib.so",
2444 "lib64/arm64/foo/bar/mylib.so",
2445 })
2446}
2447
Jiyong Parkda6eb592018-12-19 17:12:36 +09002448func TestUseVendor(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002449 ctx := testApex(t, `
Jiyong Parkda6eb592018-12-19 17:12:36 +09002450 apex {
2451 name: "myapex",
2452 key: "myapex.key",
2453 native_shared_libs: ["mylib"],
2454 use_vendor: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002455 updatable: false,
Jiyong Parkda6eb592018-12-19 17:12:36 +09002456 }
2457
2458 apex_key {
2459 name: "myapex.key",
2460 public_key: "testkey.avbpubkey",
2461 private_key: "testkey.pem",
2462 }
2463
2464 cc_library {
2465 name: "mylib",
2466 srcs: ["mylib.cpp"],
2467 shared_libs: ["mylib2"],
2468 system_shared_libs: [],
2469 vendor_available: true,
2470 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002471 apex_available: [ "myapex" ],
Jiyong Parkda6eb592018-12-19 17:12:36 +09002472 }
2473
2474 cc_library {
2475 name: "mylib2",
2476 srcs: ["mylib.cpp"],
2477 system_shared_libs: [],
2478 vendor_available: true,
2479 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002480 apex_available: [ "myapex" ],
Jiyong Parkda6eb592018-12-19 17:12:36 +09002481 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002482 `,
2483 setUseVendorAllowListForTest([]string{"myapex"}),
2484 )
Jiyong Parkda6eb592018-12-19 17:12:36 +09002485
2486 inputsList := []string{}
Sundong Ahnabb64432019-10-22 13:58:29 +09002487 for _, i := range ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().BuildParamsForTests() {
Jiyong Parkda6eb592018-12-19 17:12:36 +09002488 for _, implicit := range i.Implicits {
2489 inputsList = append(inputsList, implicit.String())
2490 }
2491 }
2492 inputsString := strings.Join(inputsList, " ")
2493
2494 // ensure that the apex includes vendor variants of the direct and indirect deps
Jiyong Parkf58c46e2021-04-01 21:35:20 +09002495 ensureContains(t, inputsString, "android_vendor.29_arm64_armv8-a_shared_apex10000/mylib.so")
2496 ensureContains(t, inputsString, "android_vendor.29_arm64_armv8-a_shared_apex10000/mylib2.so")
Jiyong Parkda6eb592018-12-19 17:12:36 +09002497
2498 // ensure that the apex does not include core variants
Colin Crossaede88c2020-08-11 12:17:01 -07002499 ensureNotContains(t, inputsString, "android_arm64_armv8-a_shared_apex10000/mylib.so")
2500 ensureNotContains(t, inputsString, "android_arm64_armv8-a_shared_apex10000/mylib2.so")
Jiyong Parkda6eb592018-12-19 17:12:36 +09002501}
Jiyong Park16e91a02018-12-20 18:18:08 +09002502
Jooyung Han85d61762020-06-24 23:50:26 +09002503func TestUseVendorNotAllowedForSystemApexes(t *testing.T) {
Jooyung Handc782442019-11-01 03:14:38 +09002504 testApexError(t, `module "myapex" .*: use_vendor: not allowed`, `
2505 apex {
2506 name: "myapex",
2507 key: "myapex.key",
2508 use_vendor: true,
2509 }
2510 apex_key {
2511 name: "myapex.key",
2512 public_key: "testkey.avbpubkey",
2513 private_key: "testkey.pem",
2514 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002515 `,
2516 setUseVendorAllowListForTest([]string{""}),
2517 )
Colin Cross440e0d02020-06-11 11:32:11 -07002518 // no error with allow list
Jooyung Handc782442019-11-01 03:14:38 +09002519 testApex(t, `
2520 apex {
2521 name: "myapex",
2522 key: "myapex.key",
2523 use_vendor: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002524 updatable: false,
Jooyung Handc782442019-11-01 03:14:38 +09002525 }
2526 apex_key {
2527 name: "myapex.key",
2528 public_key: "testkey.avbpubkey",
2529 private_key: "testkey.pem",
2530 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002531 `,
2532 setUseVendorAllowListForTest([]string{"myapex"}),
2533 )
Jooyung Handc782442019-11-01 03:14:38 +09002534}
2535
Jooyung Han5c998b92019-06-27 11:30:33 +09002536func TestUseVendorFailsIfNotVendorAvailable(t *testing.T) {
2537 testApexError(t, `dependency "mylib" of "myapex" missing variant:\n.*image:vendor`, `
2538 apex {
2539 name: "myapex",
2540 key: "myapex.key",
2541 native_shared_libs: ["mylib"],
2542 use_vendor: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002543 updatable: false,
Jooyung Han5c998b92019-06-27 11:30:33 +09002544 }
2545
2546 apex_key {
2547 name: "myapex.key",
2548 public_key: "testkey.avbpubkey",
2549 private_key: "testkey.pem",
2550 }
2551
2552 cc_library {
2553 name: "mylib",
2554 srcs: ["mylib.cpp"],
2555 system_shared_libs: [],
2556 stl: "none",
2557 }
2558 `)
2559}
2560
Jooyung Han85d61762020-06-24 23:50:26 +09002561func TestVendorApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002562 ctx := testApex(t, `
Jooyung Han85d61762020-06-24 23:50:26 +09002563 apex {
2564 name: "myapex",
2565 key: "myapex.key",
2566 binaries: ["mybin"],
2567 vendor: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002568 updatable: false,
Jooyung Han85d61762020-06-24 23:50:26 +09002569 }
2570 apex_key {
2571 name: "myapex.key",
2572 public_key: "testkey.avbpubkey",
2573 private_key: "testkey.pem",
2574 }
2575 cc_binary {
2576 name: "mybin",
2577 vendor: true,
2578 shared_libs: ["libfoo"],
2579 }
2580 cc_library {
2581 name: "libfoo",
2582 proprietary: true,
2583 }
2584 `)
2585
2586 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2587 "bin/mybin",
2588 "lib64/libfoo.so",
2589 // TODO(b/159195575): Add an option to use VNDK libs from VNDK APEX
2590 "lib64/libc++.so",
2591 })
2592
2593 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07002594 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Han85d61762020-06-24 23:50:26 +09002595 name := apexBundle.BaseModuleName()
2596 prefix := "TARGET_"
2597 var builder strings.Builder
2598 data.Custom(&builder, name, prefix, "", data)
Paul Duffin37ba3442021-03-29 00:21:08 +01002599 androidMk := android.StringRelativeToTop(ctx.Config(), builder.String())
2600 installPath := "out/target/product/test_device/vendor/apex"
Lukacs T. Berki7690c092021-02-26 14:27:36 +01002601 ensureContains(t, androidMk, "LOCAL_MODULE_PATH := "+installPath)
Jooyung Han6c4cc9c2020-07-29 16:00:54 +09002602
2603 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
2604 requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
2605 ensureListNotContains(t, requireNativeLibs, ":vndk")
Jooyung Han85d61762020-06-24 23:50:26 +09002606}
2607
Jooyung Handf78e212020-07-22 15:54:47 +09002608func TestVendorApex_use_vndk_as_stable(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002609 ctx := testApex(t, `
Jooyung Handf78e212020-07-22 15:54:47 +09002610 apex {
2611 name: "myapex",
2612 key: "myapex.key",
2613 binaries: ["mybin"],
2614 vendor: true,
2615 use_vndk_as_stable: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002616 updatable: false,
Jooyung Handf78e212020-07-22 15:54:47 +09002617 }
2618 apex_key {
2619 name: "myapex.key",
2620 public_key: "testkey.avbpubkey",
2621 private_key: "testkey.pem",
2622 }
2623 cc_binary {
2624 name: "mybin",
2625 vendor: true,
2626 shared_libs: ["libvndk", "libvendor"],
2627 }
2628 cc_library {
2629 name: "libvndk",
2630 vndk: {
2631 enabled: true,
2632 },
2633 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09002634 product_available: true,
Jooyung Handf78e212020-07-22 15:54:47 +09002635 }
2636 cc_library {
2637 name: "libvendor",
2638 vendor: true,
2639 }
2640 `)
2641
Jiyong Parkf58c46e2021-04-01 21:35:20 +09002642 vendorVariant := "android_vendor.29_arm64_armv8-a"
Jooyung Handf78e212020-07-22 15:54:47 +09002643
Paul Duffina71a67a2021-03-29 00:42:57 +01002644 ldRule := ctx.ModuleForTests("mybin", vendorVariant+"_apex10000").Rule("ld")
Jooyung Handf78e212020-07-22 15:54:47 +09002645 libs := names(ldRule.Args["libFlags"])
2646 // VNDK libs(libvndk/libc++) as they are
Paul Duffin37ba3442021-03-29 00:21:08 +01002647 ensureListContains(t, libs, "out/soong/.intermediates/libvndk/"+vendorVariant+"_shared/libvndk.so")
2648 ensureListContains(t, libs, "out/soong/.intermediates/"+cc.DefaultCcCommonTestModulesDir+"libc++/"+vendorVariant+"_shared/libc++.so")
Jooyung Handf78e212020-07-22 15:54:47 +09002649 // non-stable Vendor libs as APEX variants
Paul Duffin37ba3442021-03-29 00:21:08 +01002650 ensureListContains(t, libs, "out/soong/.intermediates/libvendor/"+vendorVariant+"_shared_apex10000/libvendor.so")
Jooyung Handf78e212020-07-22 15:54:47 +09002651
2652 // VNDK libs are not included when use_vndk_as_stable: true
2653 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2654 "bin/mybin",
2655 "lib64/libvendor.so",
2656 })
Jooyung Han6c4cc9c2020-07-29 16:00:54 +09002657
2658 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
2659 requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
2660 ensureListContains(t, requireNativeLibs, ":vndk")
Jooyung Handf78e212020-07-22 15:54:47 +09002661}
2662
Justin Yun13decfb2021-03-08 19:25:55 +09002663func TestProductVariant(t *testing.T) {
2664 ctx := testApex(t, `
2665 apex {
2666 name: "myapex",
2667 key: "myapex.key",
2668 updatable: false,
2669 product_specific: true,
2670 binaries: ["foo"],
2671 }
2672
2673 apex_key {
2674 name: "myapex.key",
2675 public_key: "testkey.avbpubkey",
2676 private_key: "testkey.pem",
2677 }
2678
2679 cc_binary {
2680 name: "foo",
2681 product_available: true,
2682 apex_available: ["myapex"],
2683 srcs: ["foo.cpp"],
2684 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002685 `, android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
2686 variables.ProductVndkVersion = proptools.StringPtr("current")
2687 }),
2688 )
Justin Yun13decfb2021-03-08 19:25:55 +09002689
2690 cflags := strings.Fields(
Jiyong Parkf58c46e2021-04-01 21:35:20 +09002691 ctx.ModuleForTests("foo", "android_product.29_arm64_armv8-a_apex10000").Rule("cc").Args["cFlags"])
Justin Yun13decfb2021-03-08 19:25:55 +09002692 ensureListContains(t, cflags, "-D__ANDROID_VNDK__")
2693 ensureListContains(t, cflags, "-D__ANDROID_APEX__")
2694 ensureListContains(t, cflags, "-D__ANDROID_PRODUCT__")
2695 ensureListNotContains(t, cflags, "-D__ANDROID_VENDOR__")
2696}
2697
Jooyung Han8e5685d2020-09-21 11:02:57 +09002698func TestApex_withPrebuiltFirmware(t *testing.T) {
2699 testCases := []struct {
2700 name string
2701 additionalProp string
2702 }{
2703 {"system apex with prebuilt_firmware", ""},
2704 {"vendor apex with prebuilt_firmware", "vendor: true,"},
2705 }
2706 for _, tc := range testCases {
2707 t.Run(tc.name, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002708 ctx := testApex(t, `
Jooyung Han8e5685d2020-09-21 11:02:57 +09002709 apex {
2710 name: "myapex",
2711 key: "myapex.key",
2712 prebuilts: ["myfirmware"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002713 updatable: false,
Jooyung Han8e5685d2020-09-21 11:02:57 +09002714 `+tc.additionalProp+`
2715 }
2716 apex_key {
2717 name: "myapex.key",
2718 public_key: "testkey.avbpubkey",
2719 private_key: "testkey.pem",
2720 }
2721 prebuilt_firmware {
2722 name: "myfirmware",
2723 src: "myfirmware.bin",
2724 filename_from_src: true,
2725 `+tc.additionalProp+`
2726 }
2727 `)
2728 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2729 "etc/firmware/myfirmware.bin",
2730 })
2731 })
2732 }
Jooyung Han0703fd82020-08-26 22:11:53 +09002733}
2734
Jooyung Hanefb184e2020-06-25 17:14:25 +09002735func TestAndroidMk_UseVendorRequired(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002736 ctx := testApex(t, `
Jooyung Hanefb184e2020-06-25 17:14:25 +09002737 apex {
2738 name: "myapex",
2739 key: "myapex.key",
2740 use_vendor: true,
2741 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002742 updatable: false,
Jooyung Hanefb184e2020-06-25 17:14:25 +09002743 }
2744
2745 apex_key {
2746 name: "myapex.key",
2747 public_key: "testkey.avbpubkey",
2748 private_key: "testkey.pem",
2749 }
2750
2751 cc_library {
2752 name: "mylib",
2753 vendor_available: true,
2754 apex_available: ["myapex"],
2755 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002756 `,
2757 setUseVendorAllowListForTest([]string{"myapex"}),
2758 )
Jooyung Hanefb184e2020-06-25 17:14:25 +09002759
2760 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07002761 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Hanefb184e2020-06-25 17:14:25 +09002762 name := apexBundle.BaseModuleName()
2763 prefix := "TARGET_"
2764 var builder strings.Builder
2765 data.Custom(&builder, name, prefix, "", data)
2766 androidMk := builder.String()
2767 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += libc libm libdl\n")
2768}
2769
2770func TestAndroidMk_VendorApexRequired(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002771 ctx := testApex(t, `
Jooyung Hanefb184e2020-06-25 17:14:25 +09002772 apex {
2773 name: "myapex",
2774 key: "myapex.key",
2775 vendor: true,
2776 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002777 updatable: false,
Jooyung Hanefb184e2020-06-25 17:14:25 +09002778 }
2779
2780 apex_key {
2781 name: "myapex.key",
2782 public_key: "testkey.avbpubkey",
2783 private_key: "testkey.pem",
2784 }
2785
2786 cc_library {
2787 name: "mylib",
2788 vendor_available: true,
2789 }
2790 `)
2791
2792 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07002793 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Hanefb184e2020-06-25 17:14:25 +09002794 name := apexBundle.BaseModuleName()
2795 prefix := "TARGET_"
2796 var builder strings.Builder
2797 data.Custom(&builder, name, prefix, "", data)
2798 androidMk := builder.String()
2799 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += libc.vendor libm.vendor libdl.vendor\n")
2800}
2801
Jooyung Han2ed99d02020-06-24 23:26:26 +09002802func TestAndroidMkWritesCommonProperties(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002803 ctx := testApex(t, `
Jooyung Han2ed99d02020-06-24 23:26:26 +09002804 apex {
2805 name: "myapex",
2806 key: "myapex.key",
2807 vintf_fragments: ["fragment.xml"],
2808 init_rc: ["init.rc"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002809 updatable: false,
Jooyung Han2ed99d02020-06-24 23:26:26 +09002810 }
2811 apex_key {
2812 name: "myapex.key",
2813 public_key: "testkey.avbpubkey",
2814 private_key: "testkey.pem",
2815 }
2816 cc_binary {
2817 name: "mybin",
2818 }
2819 `)
2820
2821 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07002822 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Han2ed99d02020-06-24 23:26:26 +09002823 name := apexBundle.BaseModuleName()
2824 prefix := "TARGET_"
2825 var builder strings.Builder
2826 data.Custom(&builder, name, prefix, "", data)
2827 androidMk := builder.String()
Liz Kammer7b3dc8a2021-04-16 16:41:59 -04002828 ensureContains(t, androidMk, "LOCAL_FULL_VINTF_FRAGMENTS := fragment.xml\n")
Liz Kammer0c4f71c2021-04-06 10:35:10 -04002829 ensureContains(t, androidMk, "LOCAL_FULL_INIT_RC := init.rc\n")
Jooyung Han2ed99d02020-06-24 23:26:26 +09002830}
2831
Jiyong Park16e91a02018-12-20 18:18:08 +09002832func TestStaticLinking(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002833 ctx := testApex(t, `
Jiyong Park16e91a02018-12-20 18:18:08 +09002834 apex {
2835 name: "myapex",
2836 key: "myapex.key",
2837 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002838 updatable: false,
Jiyong Park16e91a02018-12-20 18:18:08 +09002839 }
2840
2841 apex_key {
2842 name: "myapex.key",
2843 public_key: "testkey.avbpubkey",
2844 private_key: "testkey.pem",
2845 }
2846
2847 cc_library {
2848 name: "mylib",
2849 srcs: ["mylib.cpp"],
2850 system_shared_libs: [],
2851 stl: "none",
2852 stubs: {
2853 versions: ["1", "2", "3"],
2854 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002855 apex_available: [
2856 "//apex_available:platform",
2857 "myapex",
2858 ],
Jiyong Park16e91a02018-12-20 18:18:08 +09002859 }
2860
2861 cc_binary {
2862 name: "not_in_apex",
2863 srcs: ["mylib.cpp"],
2864 static_libs: ["mylib"],
2865 static_executable: true,
2866 system_shared_libs: [],
2867 stl: "none",
2868 }
Jiyong Park16e91a02018-12-20 18:18:08 +09002869 `)
2870
Colin Cross7113d202019-11-20 16:39:12 -08002871 ldFlags := ctx.ModuleForTests("not_in_apex", "android_arm64_armv8-a").Rule("ld").Args["libFlags"]
Jiyong Park16e91a02018-12-20 18:18:08 +09002872
2873 // Ensure that not_in_apex is linking with the static variant of mylib
Colin Cross7113d202019-11-20 16:39:12 -08002874 ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_static/mylib.a")
Jiyong Park16e91a02018-12-20 18:18:08 +09002875}
Jiyong Park9335a262018-12-24 11:31:58 +09002876
2877func TestKeys(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002878 ctx := testApex(t, `
Jiyong Park9335a262018-12-24 11:31:58 +09002879 apex {
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002880 name: "myapex_keytest",
Jiyong Park9335a262018-12-24 11:31:58 +09002881 key: "myapex.key",
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002882 certificate: ":myapex.certificate",
Jiyong Park9335a262018-12-24 11:31:58 +09002883 native_shared_libs: ["mylib"],
Jooyung Han54aca7b2019-11-20 02:26:02 +09002884 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002885 updatable: false,
Jiyong Park9335a262018-12-24 11:31:58 +09002886 }
2887
2888 cc_library {
2889 name: "mylib",
2890 srcs: ["mylib.cpp"],
2891 system_shared_libs: [],
2892 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002893 apex_available: [ "myapex_keytest" ],
Jiyong Park9335a262018-12-24 11:31:58 +09002894 }
2895
2896 apex_key {
2897 name: "myapex.key",
2898 public_key: "testkey.avbpubkey",
2899 private_key: "testkey.pem",
2900 }
2901
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002902 android_app_certificate {
2903 name: "myapex.certificate",
2904 certificate: "testkey",
2905 }
2906
2907 android_app_certificate {
2908 name: "myapex.certificate.override",
2909 certificate: "testkey.override",
2910 }
2911
Jiyong Park9335a262018-12-24 11:31:58 +09002912 `)
2913
2914 // check the APEX keys
Jiyong Parkd1e293d2019-03-15 02:13:21 +09002915 keys := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
Jiyong Park9335a262018-12-24 11:31:58 +09002916
Jaewoong Jung18aefc12020-12-21 09:11:10 -08002917 if keys.publicKeyFile.String() != "vendor/foo/devkeys/testkey.avbpubkey" {
2918 t.Errorf("public key %q is not %q", keys.publicKeyFile.String(),
Jiyong Park9335a262018-12-24 11:31:58 +09002919 "vendor/foo/devkeys/testkey.avbpubkey")
2920 }
Jaewoong Jung18aefc12020-12-21 09:11:10 -08002921 if keys.privateKeyFile.String() != "vendor/foo/devkeys/testkey.pem" {
2922 t.Errorf("private key %q is not %q", keys.privateKeyFile.String(),
Jiyong Park9335a262018-12-24 11:31:58 +09002923 "vendor/foo/devkeys/testkey.pem")
2924 }
2925
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002926 // check the APK certs. It should be overridden to myapex.certificate.override
Sundong Ahnabb64432019-10-22 13:58:29 +09002927 certs := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk").Args["certificates"]
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002928 if certs != "testkey.override.x509.pem testkey.override.pk8" {
Jiyong Park9335a262018-12-24 11:31:58 +09002929 t.Errorf("cert and private key %q are not %q", certs,
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002930 "testkey.override.509.pem testkey.override.pk8")
Jiyong Park9335a262018-12-24 11:31:58 +09002931 }
2932}
Jiyong Park58e364a2019-01-19 19:24:06 +09002933
Jooyung Hanf121a652019-12-17 14:30:11 +09002934func TestCertificate(t *testing.T) {
2935 t.Run("if unspecified, it defaults to DefaultAppCertificate", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002936 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09002937 apex {
2938 name: "myapex",
2939 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002940 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09002941 }
2942 apex_key {
2943 name: "myapex.key",
2944 public_key: "testkey.avbpubkey",
2945 private_key: "testkey.pem",
2946 }`)
2947 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
2948 expected := "vendor/foo/devkeys/test.x509.pem vendor/foo/devkeys/test.pk8"
2949 if actual := rule.Args["certificates"]; actual != expected {
2950 t.Errorf("certificates should be %q, not %q", expected, actual)
2951 }
2952 })
2953 t.Run("override when unspecified", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002954 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09002955 apex {
2956 name: "myapex_keytest",
2957 key: "myapex.key",
2958 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002959 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09002960 }
2961 apex_key {
2962 name: "myapex.key",
2963 public_key: "testkey.avbpubkey",
2964 private_key: "testkey.pem",
2965 }
2966 android_app_certificate {
2967 name: "myapex.certificate.override",
2968 certificate: "testkey.override",
2969 }`)
2970 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
2971 expected := "testkey.override.x509.pem testkey.override.pk8"
2972 if actual := rule.Args["certificates"]; actual != expected {
2973 t.Errorf("certificates should be %q, not %q", expected, actual)
2974 }
2975 })
2976 t.Run("if specified as :module, it respects the prop", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002977 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09002978 apex {
2979 name: "myapex",
2980 key: "myapex.key",
2981 certificate: ":myapex.certificate",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002982 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09002983 }
2984 apex_key {
2985 name: "myapex.key",
2986 public_key: "testkey.avbpubkey",
2987 private_key: "testkey.pem",
2988 }
2989 android_app_certificate {
2990 name: "myapex.certificate",
2991 certificate: "testkey",
2992 }`)
2993 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
2994 expected := "testkey.x509.pem testkey.pk8"
2995 if actual := rule.Args["certificates"]; actual != expected {
2996 t.Errorf("certificates should be %q, not %q", expected, actual)
2997 }
2998 })
2999 t.Run("override when specifiec as <:module>", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003000 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003001 apex {
3002 name: "myapex_keytest",
3003 key: "myapex.key",
3004 file_contexts: ":myapex-file_contexts",
3005 certificate: ":myapex.certificate",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003006 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003007 }
3008 apex_key {
3009 name: "myapex.key",
3010 public_key: "testkey.avbpubkey",
3011 private_key: "testkey.pem",
3012 }
3013 android_app_certificate {
3014 name: "myapex.certificate.override",
3015 certificate: "testkey.override",
3016 }`)
3017 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
3018 expected := "testkey.override.x509.pem testkey.override.pk8"
3019 if actual := rule.Args["certificates"]; actual != expected {
3020 t.Errorf("certificates should be %q, not %q", expected, actual)
3021 }
3022 })
3023 t.Run("if specified as name, finds it from DefaultDevKeyDir", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003024 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003025 apex {
3026 name: "myapex",
3027 key: "myapex.key",
3028 certificate: "testkey",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003029 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003030 }
3031 apex_key {
3032 name: "myapex.key",
3033 public_key: "testkey.avbpubkey",
3034 private_key: "testkey.pem",
3035 }`)
3036 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
3037 expected := "vendor/foo/devkeys/testkey.x509.pem vendor/foo/devkeys/testkey.pk8"
3038 if actual := rule.Args["certificates"]; actual != expected {
3039 t.Errorf("certificates should be %q, not %q", expected, actual)
3040 }
3041 })
3042 t.Run("override when specified as <name>", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003043 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003044 apex {
3045 name: "myapex_keytest",
3046 key: "myapex.key",
3047 file_contexts: ":myapex-file_contexts",
3048 certificate: "testkey",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003049 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003050 }
3051 apex_key {
3052 name: "myapex.key",
3053 public_key: "testkey.avbpubkey",
3054 private_key: "testkey.pem",
3055 }
3056 android_app_certificate {
3057 name: "myapex.certificate.override",
3058 certificate: "testkey.override",
3059 }`)
3060 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
3061 expected := "testkey.override.x509.pem testkey.override.pk8"
3062 if actual := rule.Args["certificates"]; actual != expected {
3063 t.Errorf("certificates should be %q, not %q", expected, actual)
3064 }
3065 })
3066}
3067
Jiyong Park58e364a2019-01-19 19:24:06 +09003068func TestMacro(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003069 ctx := testApex(t, `
Jiyong Park58e364a2019-01-19 19:24:06 +09003070 apex {
3071 name: "myapex",
3072 key: "myapex.key",
Jooyung Hanc87a0592020-03-02 17:44:33 +09003073 native_shared_libs: ["mylib", "mylib2"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003074 updatable: false,
Jiyong Park58e364a2019-01-19 19:24:06 +09003075 }
3076
3077 apex {
3078 name: "otherapex",
3079 key: "myapex.key",
Jooyung Hanc87a0592020-03-02 17:44:33 +09003080 native_shared_libs: ["mylib", "mylib2"],
Jooyung Hanccce2f22020-03-07 03:45:53 +09003081 min_sdk_version: "29",
Jiyong Park58e364a2019-01-19 19:24:06 +09003082 }
3083
3084 apex_key {
3085 name: "myapex.key",
3086 public_key: "testkey.avbpubkey",
3087 private_key: "testkey.pem",
3088 }
3089
3090 cc_library {
3091 name: "mylib",
3092 srcs: ["mylib.cpp"],
3093 system_shared_libs: [],
3094 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003095 apex_available: [
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003096 "myapex",
3097 "otherapex",
3098 ],
Jooyung Han24282772020-03-21 23:20:55 +09003099 recovery_available: true,
Jooyung Han749dc692020-04-15 11:03:39 +09003100 min_sdk_version: "29",
Jiyong Park58e364a2019-01-19 19:24:06 +09003101 }
Jooyung Hanc87a0592020-03-02 17:44:33 +09003102 cc_library {
3103 name: "mylib2",
3104 srcs: ["mylib.cpp"],
3105 system_shared_libs: [],
3106 stl: "none",
3107 apex_available: [
3108 "myapex",
3109 "otherapex",
3110 ],
Colin Crossaede88c2020-08-11 12:17:01 -07003111 static_libs: ["mylib3"],
3112 recovery_available: true,
3113 min_sdk_version: "29",
3114 }
3115 cc_library {
3116 name: "mylib3",
3117 srcs: ["mylib.cpp"],
3118 system_shared_libs: [],
3119 stl: "none",
3120 apex_available: [
3121 "myapex",
3122 "otherapex",
3123 ],
Jooyung Hanc87a0592020-03-02 17:44:33 +09003124 use_apex_name_macro: true,
Colin Crossaede88c2020-08-11 12:17:01 -07003125 recovery_available: true,
Jooyung Han749dc692020-04-15 11:03:39 +09003126 min_sdk_version: "29",
Jooyung Hanc87a0592020-03-02 17:44:33 +09003127 }
Jiyong Park58e364a2019-01-19 19:24:06 +09003128 `)
3129
Jooyung Hanc87a0592020-03-02 17:44:33 +09003130 // non-APEX variant does not have __ANDROID_APEX__ defined
Colin Cross7113d202019-11-20 16:39:12 -08003131 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09003132 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003133 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
Jooyung Hanc87a0592020-03-02 17:44:33 +09003134
Jooyung Hanccce2f22020-03-07 03:45:53 +09003135 // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
Colin Crossaede88c2020-08-11 12:17:01 -07003136 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
Jooyung Hanc87a0592020-03-02 17:44:33 +09003137 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003138 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=10000")
Jooyung Han77988572019-10-18 16:26:16 +09003139 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
Jooyung Hanc87a0592020-03-02 17:44:33 +09003140
Jooyung Hanccce2f22020-03-07 03:45:53 +09003141 // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
Colin Crossaede88c2020-08-11 12:17:01 -07003142 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex29").Rule("cc").Args["cFlags"]
Jooyung Hanc87a0592020-03-02 17:44:33 +09003143 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003144 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=29")
Jooyung Han77988572019-10-18 16:26:16 +09003145 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09003146
Colin Crossaede88c2020-08-11 12:17:01 -07003147 // When a cc_library sets use_apex_name_macro: true each apex gets a unique variant and
3148 // each variant defines additional macros to distinguish which apex variant it is built for
3149
3150 // non-APEX variant does not have __ANDROID_APEX__ defined
3151 mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
3152 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3153
3154 // APEX variant has __ANDROID_APEX__ defined
3155 mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"]
3156 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3157 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
3158 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
3159
3160 // APEX variant has __ANDROID_APEX__ defined
3161 mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static_otherapex").Rule("cc").Args["cFlags"]
3162 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3163 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
3164 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
3165
Dan Albertb19953d2020-11-17 15:29:36 -08003166 // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__
Colin Crossaede88c2020-08-11 12:17:01 -07003167 mylibCFlags = ctx.ModuleForTests("mylib3", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
3168 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003169 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
Colin Crossaede88c2020-08-11 12:17:01 -07003170
3171 // When a dependency of a cc_library sets use_apex_name_macro: true each apex gets a unique
3172 // variant.
Jooyung Hanc87a0592020-03-02 17:44:33 +09003173
3174 // non-APEX variant does not have __ANDROID_APEX__ defined
3175 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
3176 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3177
3178 // APEX variant has __ANDROID_APEX__ defined
3179 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09003180 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Colin Crossaede88c2020-08-11 12:17:01 -07003181 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
Jooyung Han77988572019-10-18 16:26:16 +09003182 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09003183
Jooyung Hanc87a0592020-03-02 17:44:33 +09003184 // APEX variant has __ANDROID_APEX__ defined
3185 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_otherapex").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09003186 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Han77988572019-10-18 16:26:16 +09003187 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
Colin Crossaede88c2020-08-11 12:17:01 -07003188 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jooyung Han24282772020-03-21 23:20:55 +09003189
Dan Albertb19953d2020-11-17 15:29:36 -08003190 // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__
Colin Crossaede88c2020-08-11 12:17:01 -07003191 mylibCFlags = ctx.ModuleForTests("mylib2", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jooyung Han24282772020-03-21 23:20:55 +09003192 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003193 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
Jiyong Park58e364a2019-01-19 19:24:06 +09003194}
Jiyong Park7e636d02019-01-28 16:16:54 +09003195
3196func TestHeaderLibsDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003197 ctx := testApex(t, `
Jiyong Park7e636d02019-01-28 16:16:54 +09003198 apex {
3199 name: "myapex",
3200 key: "myapex.key",
3201 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003202 updatable: false,
Jiyong Park7e636d02019-01-28 16:16:54 +09003203 }
3204
3205 apex_key {
3206 name: "myapex.key",
3207 public_key: "testkey.avbpubkey",
3208 private_key: "testkey.pem",
3209 }
3210
3211 cc_library_headers {
3212 name: "mylib_headers",
3213 export_include_dirs: ["my_include"],
3214 system_shared_libs: [],
3215 stl: "none",
Jiyong Park0f80c182020-01-31 02:49:53 +09003216 apex_available: [ "myapex" ],
Jiyong Park7e636d02019-01-28 16:16:54 +09003217 }
3218
3219 cc_library {
3220 name: "mylib",
3221 srcs: ["mylib.cpp"],
3222 system_shared_libs: [],
3223 stl: "none",
3224 header_libs: ["mylib_headers"],
3225 export_header_lib_headers: ["mylib_headers"],
3226 stubs: {
3227 versions: ["1", "2", "3"],
3228 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003229 apex_available: [ "myapex" ],
Jiyong Park7e636d02019-01-28 16:16:54 +09003230 }
3231
3232 cc_library {
3233 name: "otherlib",
3234 srcs: ["mylib.cpp"],
3235 system_shared_libs: [],
3236 stl: "none",
3237 shared_libs: ["mylib"],
3238 }
3239 `)
3240
Colin Cross7113d202019-11-20 16:39:12 -08003241 cFlags := ctx.ModuleForTests("otherlib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jiyong Park7e636d02019-01-28 16:16:54 +09003242
3243 // Ensure that the include path of the header lib is exported to 'otherlib'
3244 ensureContains(t, cFlags, "-Imy_include")
3245}
Alex Light9670d332019-01-29 18:07:33 -08003246
Jiyong Park7cd10e32020-01-14 09:22:18 +09003247type fileInApex struct {
3248 path string // path in apex
Jooyung Hana57af4a2020-01-23 05:36:59 +00003249 src string // src path
Jiyong Park7cd10e32020-01-14 09:22:18 +09003250 isLink bool
3251}
3252
Jooyung Hana57af4a2020-01-23 05:36:59 +00003253func getFiles(t *testing.T, ctx *android.TestContext, moduleName, variant string) []fileInApex {
Jooyung Han31c470b2019-10-18 16:26:59 +09003254 t.Helper()
Jooyung Hana57af4a2020-01-23 05:36:59 +00003255 apexRule := ctx.ModuleForTests(moduleName, variant).Rule("apexRule")
Jooyung Han31c470b2019-10-18 16:26:59 +09003256 copyCmds := apexRule.Args["copy_commands"]
3257 imageApexDir := "/image.apex/"
Jiyong Park7cd10e32020-01-14 09:22:18 +09003258 var ret []fileInApex
Jooyung Han31c470b2019-10-18 16:26:59 +09003259 for _, cmd := range strings.Split(copyCmds, "&&") {
3260 cmd = strings.TrimSpace(cmd)
3261 if cmd == "" {
3262 continue
3263 }
3264 terms := strings.Split(cmd, " ")
Jooyung Hana57af4a2020-01-23 05:36:59 +00003265 var dst, src string
Jiyong Park7cd10e32020-01-14 09:22:18 +09003266 var isLink bool
Jooyung Han31c470b2019-10-18 16:26:59 +09003267 switch terms[0] {
3268 case "mkdir":
3269 case "cp":
Jiyong Park7cd10e32020-01-14 09:22:18 +09003270 if len(terms) != 3 && len(terms) != 4 {
Jooyung Han31c470b2019-10-18 16:26:59 +09003271 t.Fatal("copyCmds contains invalid cp command", cmd)
3272 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09003273 dst = terms[len(terms)-1]
Jooyung Hana57af4a2020-01-23 05:36:59 +00003274 src = terms[len(terms)-2]
Jiyong Park7cd10e32020-01-14 09:22:18 +09003275 isLink = false
3276 case "ln":
3277 if len(terms) != 3 && len(terms) != 4 {
3278 // ln LINK TARGET or ln -s LINK TARGET
3279 t.Fatal("copyCmds contains invalid ln command", cmd)
3280 }
3281 dst = terms[len(terms)-1]
Jooyung Hana57af4a2020-01-23 05:36:59 +00003282 src = terms[len(terms)-2]
Jiyong Park7cd10e32020-01-14 09:22:18 +09003283 isLink = true
3284 default:
3285 t.Fatalf("copyCmds should contain mkdir/cp commands only: %q", cmd)
3286 }
3287 if dst != "" {
Jooyung Han31c470b2019-10-18 16:26:59 +09003288 index := strings.Index(dst, imageApexDir)
3289 if index == -1 {
3290 t.Fatal("copyCmds should copy a file to image.apex/", cmd)
3291 }
3292 dstFile := dst[index+len(imageApexDir):]
Jooyung Hana57af4a2020-01-23 05:36:59 +00003293 ret = append(ret, fileInApex{path: dstFile, src: src, isLink: isLink})
Jooyung Han31c470b2019-10-18 16:26:59 +09003294 }
3295 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09003296 return ret
3297}
3298
Jooyung Hana57af4a2020-01-23 05:36:59 +00003299func ensureExactContents(t *testing.T, ctx *android.TestContext, moduleName, variant string, files []string) {
3300 t.Helper()
Jiyong Park7cd10e32020-01-14 09:22:18 +09003301 var failed bool
3302 var surplus []string
3303 filesMatched := make(map[string]bool)
Jooyung Hana57af4a2020-01-23 05:36:59 +00003304 for _, file := range getFiles(t, ctx, moduleName, variant) {
Jooyung Hane6436d72020-02-27 13:31:56 +09003305 mactchFound := false
Jiyong Park7cd10e32020-01-14 09:22:18 +09003306 for _, expected := range files {
3307 if matched, _ := path.Match(expected, file.path); matched {
3308 filesMatched[expected] = true
Jooyung Hane6436d72020-02-27 13:31:56 +09003309 mactchFound = true
3310 break
Jiyong Park7cd10e32020-01-14 09:22:18 +09003311 }
3312 }
Jooyung Hane6436d72020-02-27 13:31:56 +09003313 if !mactchFound {
3314 surplus = append(surplus, file.path)
3315 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09003316 }
Jooyung Han31c470b2019-10-18 16:26:59 +09003317
Jooyung Han31c470b2019-10-18 16:26:59 +09003318 if len(surplus) > 0 {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003319 sort.Strings(surplus)
Jooyung Han31c470b2019-10-18 16:26:59 +09003320 t.Log("surplus files", surplus)
3321 failed = true
3322 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003323
3324 if len(files) > len(filesMatched) {
3325 var missing []string
3326 for _, expected := range files {
3327 if !filesMatched[expected] {
3328 missing = append(missing, expected)
3329 }
3330 }
3331 sort.Strings(missing)
Jooyung Han31c470b2019-10-18 16:26:59 +09003332 t.Log("missing files", missing)
3333 failed = true
3334 }
3335 if failed {
3336 t.Fail()
3337 }
3338}
3339
Jooyung Han344d5432019-08-23 11:17:39 +09003340func TestVndkApexCurrent(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003341 ctx := testApex(t, `
Jooyung Han344d5432019-08-23 11:17:39 +09003342 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003343 name: "com.android.vndk.current",
3344 key: "com.android.vndk.current.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003345 updatable: false,
Jooyung Han344d5432019-08-23 11:17:39 +09003346 }
3347
3348 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003349 name: "com.android.vndk.current.key",
Jooyung Han344d5432019-08-23 11:17:39 +09003350 public_key: "testkey.avbpubkey",
3351 private_key: "testkey.pem",
3352 }
3353
3354 cc_library {
3355 name: "libvndk",
3356 srcs: ["mylib.cpp"],
3357 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003358 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003359 vndk: {
3360 enabled: true,
3361 },
3362 system_shared_libs: [],
3363 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003364 apex_available: [ "com.android.vndk.current" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003365 }
3366
3367 cc_library {
3368 name: "libvndksp",
3369 srcs: ["mylib.cpp"],
3370 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003371 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003372 vndk: {
3373 enabled: true,
3374 support_system_process: true,
3375 },
3376 system_shared_libs: [],
3377 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003378 apex_available: [ "com.android.vndk.current" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003379 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003380 `+vndkLibrariesTxtFiles("current"))
Jooyung Han344d5432019-08-23 11:17:39 +09003381
Colin Cross2807f002021-03-02 10:15:29 -08003382 ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003383 "lib/libvndk.so",
3384 "lib/libvndksp.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09003385 "lib/libc++.so",
Jooyung Han31c470b2019-10-18 16:26:59 +09003386 "lib64/libvndk.so",
3387 "lib64/libvndksp.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09003388 "lib64/libc++.so",
Jiyong Parkf58c46e2021-04-01 21:35:20 +09003389 "etc/llndk.libraries.29.txt",
3390 "etc/vndkcore.libraries.29.txt",
3391 "etc/vndksp.libraries.29.txt",
3392 "etc/vndkprivate.libraries.29.txt",
3393 "etc/vndkproduct.libraries.29.txt",
Jooyung Han31c470b2019-10-18 16:26:59 +09003394 })
Jooyung Han344d5432019-08-23 11:17:39 +09003395}
3396
3397func TestVndkApexWithPrebuilt(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003398 ctx := testApex(t, `
Jooyung Han344d5432019-08-23 11:17:39 +09003399 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003400 name: "com.android.vndk.current",
3401 key: "com.android.vndk.current.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003402 updatable: false,
Jooyung Han344d5432019-08-23 11:17:39 +09003403 }
3404
3405 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003406 name: "com.android.vndk.current.key",
Jooyung Han344d5432019-08-23 11:17:39 +09003407 public_key: "testkey.avbpubkey",
3408 private_key: "testkey.pem",
3409 }
3410
3411 cc_prebuilt_library_shared {
Jooyung Han31c470b2019-10-18 16:26:59 +09003412 name: "libvndk",
3413 srcs: ["libvndk.so"],
Jooyung Han344d5432019-08-23 11:17:39 +09003414 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003415 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003416 vndk: {
3417 enabled: true,
3418 },
3419 system_shared_libs: [],
3420 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003421 apex_available: [ "com.android.vndk.current" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003422 }
Jooyung Han31c470b2019-10-18 16:26:59 +09003423
3424 cc_prebuilt_library_shared {
3425 name: "libvndk.arm",
3426 srcs: ["libvndk.arm.so"],
3427 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003428 product_available: true,
Jooyung Han31c470b2019-10-18 16:26:59 +09003429 vndk: {
3430 enabled: true,
3431 },
3432 enabled: false,
3433 arch: {
3434 arm: {
3435 enabled: true,
3436 },
3437 },
3438 system_shared_libs: [],
3439 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003440 apex_available: [ "com.android.vndk.current" ],
Jooyung Han31c470b2019-10-18 16:26:59 +09003441 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003442 `+vndkLibrariesTxtFiles("current"),
3443 withFiles(map[string][]byte{
3444 "libvndk.so": nil,
3445 "libvndk.arm.so": nil,
3446 }))
Colin Cross2807f002021-03-02 10:15:29 -08003447 ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003448 "lib/libvndk.so",
3449 "lib/libvndk.arm.so",
3450 "lib64/libvndk.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09003451 "lib/libc++.so",
3452 "lib64/libc++.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003453 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003454 })
Jooyung Han344d5432019-08-23 11:17:39 +09003455}
3456
Jooyung Han39edb6c2019-11-06 16:53:07 +09003457func vndkLibrariesTxtFiles(vers ...string) (result string) {
3458 for _, v := range vers {
3459 if v == "current" {
Justin Yun8a2600c2020-12-07 12:44:03 +09003460 for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003461 result += `
Colin Crosse4e44bc2020-12-28 13:50:21 -08003462 ` + txt + `_libraries_txt {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003463 name: "` + txt + `.libraries.txt",
3464 }
3465 `
3466 }
3467 } else {
Justin Yun8a2600c2020-12-07 12:44:03 +09003468 for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003469 result += `
3470 prebuilt_etc {
3471 name: "` + txt + `.libraries.` + v + `.txt",
3472 src: "dummy.txt",
3473 }
3474 `
3475 }
3476 }
3477 }
3478 return
3479}
3480
Jooyung Han344d5432019-08-23 11:17:39 +09003481func TestVndkApexVersion(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003482 ctx := testApex(t, `
Jooyung Han344d5432019-08-23 11:17:39 +09003483 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003484 name: "com.android.vndk.v27",
Jooyung Han344d5432019-08-23 11:17:39 +09003485 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003486 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09003487 vndk_version: "27",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003488 updatable: false,
Jooyung Han344d5432019-08-23 11:17:39 +09003489 }
3490
3491 apex_key {
3492 name: "myapex.key",
3493 public_key: "testkey.avbpubkey",
3494 private_key: "testkey.pem",
3495 }
3496
Jooyung Han31c470b2019-10-18 16:26:59 +09003497 vndk_prebuilt_shared {
3498 name: "libvndk27",
3499 version: "27",
Jooyung Han344d5432019-08-23 11:17:39 +09003500 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003501 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003502 vndk: {
3503 enabled: true,
3504 },
Jooyung Han31c470b2019-10-18 16:26:59 +09003505 target_arch: "arm64",
3506 arch: {
3507 arm: {
3508 srcs: ["libvndk27_arm.so"],
3509 },
3510 arm64: {
3511 srcs: ["libvndk27_arm64.so"],
3512 },
3513 },
Colin Cross2807f002021-03-02 10:15:29 -08003514 apex_available: [ "com.android.vndk.v27" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003515 }
3516
3517 vndk_prebuilt_shared {
3518 name: "libvndk27",
3519 version: "27",
3520 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003521 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003522 vndk: {
3523 enabled: true,
3524 },
Jooyung Han31c470b2019-10-18 16:26:59 +09003525 target_arch: "x86_64",
3526 arch: {
3527 x86: {
3528 srcs: ["libvndk27_x86.so"],
3529 },
3530 x86_64: {
3531 srcs: ["libvndk27_x86_64.so"],
3532 },
3533 },
Jooyung Han39edb6c2019-11-06 16:53:07 +09003534 }
3535 `+vndkLibrariesTxtFiles("27"),
3536 withFiles(map[string][]byte{
3537 "libvndk27_arm.so": nil,
3538 "libvndk27_arm64.so": nil,
3539 "libvndk27_x86.so": nil,
3540 "libvndk27_x86_64.so": nil,
3541 }))
Jooyung Han344d5432019-08-23 11:17:39 +09003542
Colin Cross2807f002021-03-02 10:15:29 -08003543 ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003544 "lib/libvndk27_arm.so",
3545 "lib64/libvndk27_arm64.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003546 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003547 })
Jooyung Han344d5432019-08-23 11:17:39 +09003548}
3549
Jooyung Han90eee022019-10-01 20:02:42 +09003550func TestVndkApexNameRule(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003551 ctx := testApex(t, `
Jooyung Han90eee022019-10-01 20:02:42 +09003552 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003553 name: "com.android.vndk.current",
Jooyung Han90eee022019-10-01 20:02:42 +09003554 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003555 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003556 updatable: false,
Jooyung Han90eee022019-10-01 20:02:42 +09003557 }
3558 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003559 name: "com.android.vndk.v28",
Jooyung Han90eee022019-10-01 20:02:42 +09003560 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003561 file_contexts: ":myapex-file_contexts",
Jooyung Han90eee022019-10-01 20:02:42 +09003562 vndk_version: "28",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003563 updatable: false,
Jooyung Han90eee022019-10-01 20:02:42 +09003564 }
3565 apex_key {
3566 name: "myapex.key",
3567 public_key: "testkey.avbpubkey",
3568 private_key: "testkey.pem",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003569 }`+vndkLibrariesTxtFiles("28", "current"))
Jooyung Han90eee022019-10-01 20:02:42 +09003570
3571 assertApexName := func(expected, moduleName string) {
Jooyung Hana57af4a2020-01-23 05:36:59 +00003572 bundle := ctx.ModuleForTests(moduleName, "android_common_image").Module().(*apexBundle)
Jooyung Han90eee022019-10-01 20:02:42 +09003573 actual := proptools.String(bundle.properties.Apex_name)
3574 if !reflect.DeepEqual(actual, expected) {
3575 t.Errorf("Got '%v', expected '%v'", actual, expected)
3576 }
3577 }
3578
Jiyong Parkf58c46e2021-04-01 21:35:20 +09003579 assertApexName("com.android.vndk.v29", "com.android.vndk.current")
Colin Cross2807f002021-03-02 10:15:29 -08003580 assertApexName("com.android.vndk.v28", "com.android.vndk.v28")
Jooyung Han90eee022019-10-01 20:02:42 +09003581}
3582
Jooyung Han344d5432019-08-23 11:17:39 +09003583func TestVndkApexSkipsNativeBridgeSupportedModules(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003584 ctx := testApex(t, `
Jooyung Han344d5432019-08-23 11:17:39 +09003585 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003586 name: "com.android.vndk.current",
3587 key: "com.android.vndk.current.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003588 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003589 updatable: false,
Jooyung Han344d5432019-08-23 11:17:39 +09003590 }
3591
3592 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003593 name: "com.android.vndk.current.key",
Jooyung Han344d5432019-08-23 11:17:39 +09003594 public_key: "testkey.avbpubkey",
3595 private_key: "testkey.pem",
3596 }
3597
3598 cc_library {
3599 name: "libvndk",
3600 srcs: ["mylib.cpp"],
3601 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003602 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003603 native_bridge_supported: true,
3604 host_supported: true,
3605 vndk: {
3606 enabled: true,
3607 },
3608 system_shared_libs: [],
3609 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003610 apex_available: [ "com.android.vndk.current" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003611 }
Colin Cross2807f002021-03-02 10:15:29 -08003612 `+vndkLibrariesTxtFiles("current"),
3613 withNativeBridgeEnabled)
Jooyung Han344d5432019-08-23 11:17:39 +09003614
Colin Cross2807f002021-03-02 10:15:29 -08003615 ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003616 "lib/libvndk.so",
3617 "lib64/libvndk.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09003618 "lib/libc++.so",
3619 "lib64/libc++.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003620 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003621 })
Jooyung Han344d5432019-08-23 11:17:39 +09003622}
3623
3624func TestVndkApexDoesntSupportNativeBridgeSupported(t *testing.T) {
Colin Cross2807f002021-03-02 10:15:29 -08003625 testApexError(t, `module "com.android.vndk.current" .*: native_bridge_supported: .* doesn't support native bridge binary`, `
Jooyung Han344d5432019-08-23 11:17:39 +09003626 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003627 name: "com.android.vndk.current",
3628 key: "com.android.vndk.current.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003629 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09003630 native_bridge_supported: true,
3631 }
3632
3633 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003634 name: "com.android.vndk.current.key",
Jooyung Han344d5432019-08-23 11:17:39 +09003635 public_key: "testkey.avbpubkey",
3636 private_key: "testkey.pem",
3637 }
3638
3639 cc_library {
3640 name: "libvndk",
3641 srcs: ["mylib.cpp"],
3642 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003643 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003644 native_bridge_supported: true,
3645 host_supported: true,
3646 vndk: {
3647 enabled: true,
3648 },
3649 system_shared_libs: [],
3650 stl: "none",
3651 }
3652 `)
3653}
3654
Jooyung Han31c470b2019-10-18 16:26:59 +09003655func TestVndkApexWithBinder32(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003656 ctx := testApex(t, `
Jooyung Han31c470b2019-10-18 16:26:59 +09003657 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003658 name: "com.android.vndk.v27",
Jooyung Han31c470b2019-10-18 16:26:59 +09003659 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003660 file_contexts: ":myapex-file_contexts",
Jooyung Han31c470b2019-10-18 16:26:59 +09003661 vndk_version: "27",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003662 updatable: false,
Jooyung Han31c470b2019-10-18 16:26:59 +09003663 }
3664
3665 apex_key {
3666 name: "myapex.key",
3667 public_key: "testkey.avbpubkey",
3668 private_key: "testkey.pem",
3669 }
3670
3671 vndk_prebuilt_shared {
3672 name: "libvndk27",
3673 version: "27",
3674 target_arch: "arm",
3675 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003676 product_available: true,
Jooyung Han31c470b2019-10-18 16:26:59 +09003677 vndk: {
3678 enabled: true,
3679 },
3680 arch: {
3681 arm: {
3682 srcs: ["libvndk27.so"],
3683 }
3684 },
3685 }
3686
3687 vndk_prebuilt_shared {
3688 name: "libvndk27",
3689 version: "27",
3690 target_arch: "arm",
3691 binder32bit: true,
3692 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003693 product_available: true,
Jooyung Han31c470b2019-10-18 16:26:59 +09003694 vndk: {
3695 enabled: true,
3696 },
3697 arch: {
3698 arm: {
3699 srcs: ["libvndk27binder32.so"],
3700 }
3701 },
Colin Cross2807f002021-03-02 10:15:29 -08003702 apex_available: [ "com.android.vndk.v27" ],
Jooyung Han31c470b2019-10-18 16:26:59 +09003703 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003704 `+vndkLibrariesTxtFiles("27"),
Jooyung Han31c470b2019-10-18 16:26:59 +09003705 withFiles(map[string][]byte{
3706 "libvndk27.so": nil,
3707 "libvndk27binder32.so": nil,
3708 }),
3709 withBinder32bit,
3710 withTargets(map[android.OsType][]android.Target{
3711 android.Android: []android.Target{
Jooyung Han35155c42020-02-06 17:33:20 +09003712 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
3713 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
Jooyung Han31c470b2019-10-18 16:26:59 +09003714 },
3715 }),
3716 )
3717
Colin Cross2807f002021-03-02 10:15:29 -08003718 ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003719 "lib/libvndk27binder32.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003720 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003721 })
3722}
3723
Jooyung Han45a96772020-06-15 14:59:42 +09003724func TestVndkApexShouldNotProvideNativeLibs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003725 ctx := testApex(t, `
Jooyung Han45a96772020-06-15 14:59:42 +09003726 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003727 name: "com.android.vndk.current",
3728 key: "com.android.vndk.current.key",
Jooyung Han45a96772020-06-15 14:59:42 +09003729 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003730 updatable: false,
Jooyung Han45a96772020-06-15 14:59:42 +09003731 }
3732
3733 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003734 name: "com.android.vndk.current.key",
Jooyung Han45a96772020-06-15 14:59:42 +09003735 public_key: "testkey.avbpubkey",
3736 private_key: "testkey.pem",
3737 }
3738
3739 cc_library {
3740 name: "libz",
3741 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003742 product_available: true,
Jooyung Han45a96772020-06-15 14:59:42 +09003743 vndk: {
3744 enabled: true,
3745 },
3746 stubs: {
3747 symbol_file: "libz.map.txt",
3748 versions: ["30"],
3749 }
3750 }
3751 `+vndkLibrariesTxtFiles("current"), withFiles(map[string][]byte{
3752 "libz.map.txt": nil,
3753 }))
3754
Colin Cross2807f002021-03-02 10:15:29 -08003755 apexManifestRule := ctx.ModuleForTests("com.android.vndk.current", "android_common_image").Rule("apexManifestRule")
Jooyung Han45a96772020-06-15 14:59:42 +09003756 provideNativeLibs := names(apexManifestRule.Args["provideNativeLibs"])
3757 ensureListEmpty(t, provideNativeLibs)
3758}
3759
Jooyung Hane1633032019-08-01 17:41:43 +09003760func TestDependenciesInApexManifest(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003761 ctx := testApex(t, `
Jooyung Hane1633032019-08-01 17:41:43 +09003762 apex {
3763 name: "myapex_nodep",
3764 key: "myapex.key",
3765 native_shared_libs: ["lib_nodep"],
3766 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003767 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003768 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003769 }
3770
3771 apex {
3772 name: "myapex_dep",
3773 key: "myapex.key",
3774 native_shared_libs: ["lib_dep"],
3775 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003776 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003777 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003778 }
3779
3780 apex {
3781 name: "myapex_provider",
3782 key: "myapex.key",
3783 native_shared_libs: ["libfoo"],
3784 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003785 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003786 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003787 }
3788
3789 apex {
3790 name: "myapex_selfcontained",
3791 key: "myapex.key",
3792 native_shared_libs: ["lib_dep", "libfoo"],
3793 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003794 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003795 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003796 }
3797
3798 apex_key {
3799 name: "myapex.key",
3800 public_key: "testkey.avbpubkey",
3801 private_key: "testkey.pem",
3802 }
3803
3804 cc_library {
3805 name: "lib_nodep",
3806 srcs: ["mylib.cpp"],
3807 system_shared_libs: [],
3808 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003809 apex_available: [ "myapex_nodep" ],
Jooyung Hane1633032019-08-01 17:41:43 +09003810 }
3811
3812 cc_library {
3813 name: "lib_dep",
3814 srcs: ["mylib.cpp"],
3815 shared_libs: ["libfoo"],
3816 system_shared_libs: [],
3817 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003818 apex_available: [
3819 "myapex_dep",
3820 "myapex_provider",
3821 "myapex_selfcontained",
3822 ],
Jooyung Hane1633032019-08-01 17:41:43 +09003823 }
3824
3825 cc_library {
3826 name: "libfoo",
3827 srcs: ["mytest.cpp"],
3828 stubs: {
3829 versions: ["1"],
3830 },
3831 system_shared_libs: [],
3832 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003833 apex_available: [
3834 "myapex_provider",
3835 "myapex_selfcontained",
3836 ],
Jooyung Hane1633032019-08-01 17:41:43 +09003837 }
3838 `)
3839
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003840 var apexManifestRule android.TestingBuildParams
Jooyung Hane1633032019-08-01 17:41:43 +09003841 var provideNativeLibs, requireNativeLibs []string
3842
Sundong Ahnabb64432019-10-22 13:58:29 +09003843 apexManifestRule = ctx.ModuleForTests("myapex_nodep", "android_common_myapex_nodep_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003844 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3845 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003846 ensureListEmpty(t, provideNativeLibs)
3847 ensureListEmpty(t, requireNativeLibs)
3848
Sundong Ahnabb64432019-10-22 13:58:29 +09003849 apexManifestRule = ctx.ModuleForTests("myapex_dep", "android_common_myapex_dep_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003850 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3851 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003852 ensureListEmpty(t, provideNativeLibs)
3853 ensureListContains(t, requireNativeLibs, "libfoo.so")
3854
Sundong Ahnabb64432019-10-22 13:58:29 +09003855 apexManifestRule = ctx.ModuleForTests("myapex_provider", "android_common_myapex_provider_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003856 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3857 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003858 ensureListContains(t, provideNativeLibs, "libfoo.so")
3859 ensureListEmpty(t, requireNativeLibs)
3860
Sundong Ahnabb64432019-10-22 13:58:29 +09003861 apexManifestRule = ctx.ModuleForTests("myapex_selfcontained", "android_common_myapex_selfcontained_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003862 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3863 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003864 ensureListContains(t, provideNativeLibs, "libfoo.so")
3865 ensureListEmpty(t, requireNativeLibs)
3866}
3867
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003868func TestApexName(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003869 ctx := testApex(t, `
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003870 apex {
3871 name: "myapex",
3872 key: "myapex.key",
3873 apex_name: "com.android.myapex",
Jiyong Parkdb334862020-02-05 17:19:28 +09003874 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003875 updatable: false,
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003876 }
3877
3878 apex_key {
3879 name: "myapex.key",
3880 public_key: "testkey.avbpubkey",
3881 private_key: "testkey.pem",
3882 }
Jiyong Parkdb334862020-02-05 17:19:28 +09003883
3884 cc_library {
3885 name: "mylib",
3886 srcs: ["mylib.cpp"],
3887 system_shared_libs: [],
3888 stl: "none",
3889 apex_available: [
3890 "//apex_available:platform",
3891 "myapex",
3892 ],
3893 }
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003894 `)
3895
Sundong Ahnabb64432019-10-22 13:58:29 +09003896 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003897 apexManifestRule := module.Rule("apexManifestRule")
3898 ensureContains(t, apexManifestRule.Args["opt"], "-v name com.android.myapex")
3899 apexRule := module.Rule("apexRule")
3900 ensureContains(t, apexRule.Args["opt_flags"], "--do_not_check_keyname")
Jiyong Parkdb334862020-02-05 17:19:28 +09003901
3902 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07003903 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jiyong Parkdb334862020-02-05 17:19:28 +09003904 name := apexBundle.BaseModuleName()
3905 prefix := "TARGET_"
3906 var builder strings.Builder
3907 data.Custom(&builder, name, prefix, "", data)
3908 androidMk := builder.String()
3909 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
3910 ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003911}
3912
Alex Light0851b882019-02-07 13:20:53 -08003913func TestNonTestApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003914 ctx := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08003915 apex {
3916 name: "myapex",
3917 key: "myapex.key",
3918 native_shared_libs: ["mylib_common"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003919 updatable: false,
Alex Light0851b882019-02-07 13:20:53 -08003920 }
3921
3922 apex_key {
3923 name: "myapex.key",
3924 public_key: "testkey.avbpubkey",
3925 private_key: "testkey.pem",
3926 }
3927
3928 cc_library {
3929 name: "mylib_common",
3930 srcs: ["mylib.cpp"],
3931 system_shared_libs: [],
3932 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003933 apex_available: [
3934 "//apex_available:platform",
3935 "myapex",
3936 ],
Alex Light0851b882019-02-07 13:20:53 -08003937 }
3938 `)
3939
Sundong Ahnabb64432019-10-22 13:58:29 +09003940 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Alex Light0851b882019-02-07 13:20:53 -08003941 apexRule := module.Rule("apexRule")
3942 copyCmds := apexRule.Args["copy_commands"]
3943
3944 if apex, ok := module.Module().(*apexBundle); !ok || apex.testApex {
3945 t.Log("Apex was a test apex!")
3946 t.Fail()
3947 }
3948 // Ensure that main rule creates an output
3949 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
3950
3951 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -07003952 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
Alex Light0851b882019-02-07 13:20:53 -08003953
3954 // Ensure that both direct and indirect deps are copied into apex
3955 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
3956
Colin Cross7113d202019-11-20 16:39:12 -08003957 // Ensure that the platform variant ends with _shared
3958 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
Alex Light0851b882019-02-07 13:20:53 -08003959
Colin Cross56a83212020-09-15 18:30:11 -07003960 if !ctx.ModuleForTests("mylib_common", "android_arm64_armv8-a_shared_apex10000").Module().(*cc.Module).InAnyApex() {
Alex Light0851b882019-02-07 13:20:53 -08003961 t.Log("Found mylib_common not in any apex!")
3962 t.Fail()
3963 }
3964}
3965
3966func TestTestApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003967 ctx := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08003968 apex_test {
3969 name: "myapex",
3970 key: "myapex.key",
3971 native_shared_libs: ["mylib_common_test"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003972 updatable: false,
Alex Light0851b882019-02-07 13:20:53 -08003973 }
3974
3975 apex_key {
3976 name: "myapex.key",
3977 public_key: "testkey.avbpubkey",
3978 private_key: "testkey.pem",
3979 }
3980
3981 cc_library {
3982 name: "mylib_common_test",
3983 srcs: ["mylib.cpp"],
3984 system_shared_libs: [],
3985 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003986 // TODO: remove //apex_available:platform
3987 apex_available: [
3988 "//apex_available:platform",
3989 "myapex",
3990 ],
Alex Light0851b882019-02-07 13:20:53 -08003991 }
3992 `)
3993
Sundong Ahnabb64432019-10-22 13:58:29 +09003994 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Alex Light0851b882019-02-07 13:20:53 -08003995 apexRule := module.Rule("apexRule")
3996 copyCmds := apexRule.Args["copy_commands"]
3997
3998 if apex, ok := module.Module().(*apexBundle); !ok || !apex.testApex {
3999 t.Log("Apex was not a test apex!")
4000 t.Fail()
4001 }
4002 // Ensure that main rule creates an output
4003 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
4004
4005 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -07004006 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared_apex10000")
Alex Light0851b882019-02-07 13:20:53 -08004007
4008 // Ensure that both direct and indirect deps are copied into apex
4009 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common_test.so")
4010
Colin Cross7113d202019-11-20 16:39:12 -08004011 // Ensure that the platform variant ends with _shared
4012 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared")
Alex Light0851b882019-02-07 13:20:53 -08004013}
4014
Alex Light9670d332019-01-29 18:07:33 -08004015func TestApexWithTarget(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004016 ctx := testApex(t, `
Alex Light9670d332019-01-29 18:07:33 -08004017 apex {
4018 name: "myapex",
4019 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004020 updatable: false,
Alex Light9670d332019-01-29 18:07:33 -08004021 multilib: {
4022 first: {
4023 native_shared_libs: ["mylib_common"],
4024 }
4025 },
4026 target: {
4027 android: {
4028 multilib: {
4029 first: {
4030 native_shared_libs: ["mylib"],
4031 }
4032 }
4033 },
4034 host: {
4035 multilib: {
4036 first: {
4037 native_shared_libs: ["mylib2"],
4038 }
4039 }
4040 }
4041 }
4042 }
4043
4044 apex_key {
4045 name: "myapex.key",
4046 public_key: "testkey.avbpubkey",
4047 private_key: "testkey.pem",
4048 }
4049
4050 cc_library {
4051 name: "mylib",
4052 srcs: ["mylib.cpp"],
4053 system_shared_libs: [],
4054 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004055 // TODO: remove //apex_available:platform
4056 apex_available: [
4057 "//apex_available:platform",
4058 "myapex",
4059 ],
Alex Light9670d332019-01-29 18:07:33 -08004060 }
4061
4062 cc_library {
4063 name: "mylib_common",
4064 srcs: ["mylib.cpp"],
4065 system_shared_libs: [],
4066 stl: "none",
4067 compile_multilib: "first",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004068 // TODO: remove //apex_available:platform
4069 apex_available: [
4070 "//apex_available:platform",
4071 "myapex",
4072 ],
Alex Light9670d332019-01-29 18:07:33 -08004073 }
4074
4075 cc_library {
4076 name: "mylib2",
4077 srcs: ["mylib.cpp"],
4078 system_shared_libs: [],
4079 stl: "none",
4080 compile_multilib: "first",
4081 }
4082 `)
4083
Sundong Ahnabb64432019-10-22 13:58:29 +09004084 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Alex Light9670d332019-01-29 18:07:33 -08004085 copyCmds := apexRule.Args["copy_commands"]
4086
4087 // Ensure that main rule creates an output
4088 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
4089
4090 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -07004091 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
4092 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
4093 ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
Alex Light9670d332019-01-29 18:07:33 -08004094
4095 // Ensure that both direct and indirect deps are copied into apex
4096 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
4097 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
4098 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
4099
Colin Cross7113d202019-11-20 16:39:12 -08004100 // Ensure that the platform variant ends with _shared
4101 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
4102 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
4103 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
Alex Light9670d332019-01-29 18:07:33 -08004104}
Jiyong Park04480cf2019-02-06 00:16:29 +09004105
Jiyong Park59140302020-12-14 18:44:04 +09004106func TestApexWithArch(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004107 ctx := testApex(t, `
Jiyong Park59140302020-12-14 18:44:04 +09004108 apex {
4109 name: "myapex",
4110 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004111 updatable: false,
Jiyong Park59140302020-12-14 18:44:04 +09004112 arch: {
4113 arm64: {
4114 native_shared_libs: ["mylib.arm64"],
4115 },
4116 x86_64: {
4117 native_shared_libs: ["mylib.x64"],
4118 },
4119 }
4120 }
4121
4122 apex_key {
4123 name: "myapex.key",
4124 public_key: "testkey.avbpubkey",
4125 private_key: "testkey.pem",
4126 }
4127
4128 cc_library {
4129 name: "mylib.arm64",
4130 srcs: ["mylib.cpp"],
4131 system_shared_libs: [],
4132 stl: "none",
4133 // TODO: remove //apex_available:platform
4134 apex_available: [
4135 "//apex_available:platform",
4136 "myapex",
4137 ],
4138 }
4139
4140 cc_library {
4141 name: "mylib.x64",
4142 srcs: ["mylib.cpp"],
4143 system_shared_libs: [],
4144 stl: "none",
4145 // TODO: remove //apex_available:platform
4146 apex_available: [
4147 "//apex_available:platform",
4148 "myapex",
4149 ],
4150 }
4151 `)
4152
4153 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
4154 copyCmds := apexRule.Args["copy_commands"]
4155
4156 // Ensure that apex variant is created for the direct dep
4157 ensureListContains(t, ctx.ModuleVariantsForTests("mylib.arm64"), "android_arm64_armv8-a_shared_apex10000")
4158 ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib.x64"), "android_arm64_armv8-a_shared_apex10000")
4159
4160 // Ensure that both direct and indirect deps are copied into apex
4161 ensureContains(t, copyCmds, "image.apex/lib64/mylib.arm64.so")
4162 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib.x64.so")
4163}
4164
Jiyong Park04480cf2019-02-06 00:16:29 +09004165func TestApexWithShBinary(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004166 ctx := testApex(t, `
Jiyong Park04480cf2019-02-06 00:16:29 +09004167 apex {
4168 name: "myapex",
4169 key: "myapex.key",
4170 binaries: ["myscript"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004171 updatable: false,
Jiyong Park04480cf2019-02-06 00:16:29 +09004172 }
4173
4174 apex_key {
4175 name: "myapex.key",
4176 public_key: "testkey.avbpubkey",
4177 private_key: "testkey.pem",
4178 }
4179
4180 sh_binary {
4181 name: "myscript",
4182 src: "mylib.cpp",
4183 filename: "myscript.sh",
4184 sub_dir: "script",
4185 }
4186 `)
4187
Sundong Ahnabb64432019-10-22 13:58:29 +09004188 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park04480cf2019-02-06 00:16:29 +09004189 copyCmds := apexRule.Args["copy_commands"]
4190
4191 ensureContains(t, copyCmds, "image.apex/bin/script/myscript.sh")
4192}
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004193
Jooyung Han91df2082019-11-20 01:49:42 +09004194func TestApexInVariousPartition(t *testing.T) {
4195 testcases := []struct {
4196 propName, parition, flattenedPartition string
4197 }{
4198 {"", "system", "system_ext"},
4199 {"product_specific: true", "product", "product"},
4200 {"soc_specific: true", "vendor", "vendor"},
4201 {"proprietary: true", "vendor", "vendor"},
4202 {"vendor: true", "vendor", "vendor"},
4203 {"system_ext_specific: true", "system_ext", "system_ext"},
4204 }
4205 for _, tc := range testcases {
4206 t.Run(tc.propName+":"+tc.parition, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004207 ctx := testApex(t, `
Jooyung Han91df2082019-11-20 01:49:42 +09004208 apex {
4209 name: "myapex",
4210 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004211 updatable: false,
Jooyung Han91df2082019-11-20 01:49:42 +09004212 `+tc.propName+`
4213 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004214
Jooyung Han91df2082019-11-20 01:49:42 +09004215 apex_key {
4216 name: "myapex.key",
4217 public_key: "testkey.avbpubkey",
4218 private_key: "testkey.pem",
4219 }
4220 `)
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004221
Jooyung Han91df2082019-11-20 01:49:42 +09004222 apex := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Paul Duffin37ba3442021-03-29 00:21:08 +01004223 expected := "out/soong/target/product/test_device/" + tc.parition + "/apex"
4224 actual := apex.installDir.RelativeToTop().String()
Jooyung Han91df2082019-11-20 01:49:42 +09004225 if actual != expected {
4226 t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
4227 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004228
Jooyung Han91df2082019-11-20 01:49:42 +09004229 flattened := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
Paul Duffin37ba3442021-03-29 00:21:08 +01004230 expected = "out/soong/target/product/test_device/" + tc.flattenedPartition + "/apex"
4231 actual = flattened.installDir.RelativeToTop().String()
Jooyung Han91df2082019-11-20 01:49:42 +09004232 if actual != expected {
4233 t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
4234 }
4235 })
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004236 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004237}
Jiyong Park67882562019-03-21 01:11:21 +09004238
Jooyung Han580eb4f2020-06-24 19:33:06 +09004239func TestFileContexts_FindInDefaultLocationIfNotSet(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004240 ctx := testApex(t, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004241 apex {
4242 name: "myapex",
4243 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004244 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004245 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004246
Jooyung Han580eb4f2020-06-24 19:33:06 +09004247 apex_key {
4248 name: "myapex.key",
4249 public_key: "testkey.avbpubkey",
4250 private_key: "testkey.pem",
4251 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004252 `)
4253 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Han580eb4f2020-06-24 19:33:06 +09004254 rule := module.Output("file_contexts")
4255 ensureContains(t, rule.RuleParams.Command, "cat system/sepolicy/apex/myapex-file_contexts")
4256}
Jooyung Han54aca7b2019-11-20 02:26:02 +09004257
Jooyung Han580eb4f2020-06-24 19:33:06 +09004258func TestFileContexts_ShouldBeUnderSystemSepolicyForSystemApexes(t *testing.T) {
Jooyung Han54aca7b2019-11-20 02:26:02 +09004259 testApexError(t, `"myapex" .*: file_contexts: should be under system/sepolicy`, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004260 apex {
4261 name: "myapex",
4262 key: "myapex.key",
4263 file_contexts: "my_own_file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004264 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004265 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004266
Jooyung Han580eb4f2020-06-24 19:33:06 +09004267 apex_key {
4268 name: "myapex.key",
4269 public_key: "testkey.avbpubkey",
4270 private_key: "testkey.pem",
4271 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004272 `, withFiles(map[string][]byte{
4273 "my_own_file_contexts": nil,
4274 }))
Jooyung Han580eb4f2020-06-24 19:33:06 +09004275}
Jooyung Han54aca7b2019-11-20 02:26:02 +09004276
Jooyung Han580eb4f2020-06-24 19:33:06 +09004277func TestFileContexts_ProductSpecificApexes(t *testing.T) {
Jooyung Han54aca7b2019-11-20 02:26:02 +09004278 testApexError(t, `"myapex" .*: file_contexts: cannot find`, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004279 apex {
4280 name: "myapex",
4281 key: "myapex.key",
4282 product_specific: true,
4283 file_contexts: "product_specific_file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004284 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004285 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004286
Jooyung Han580eb4f2020-06-24 19:33:06 +09004287 apex_key {
4288 name: "myapex.key",
4289 public_key: "testkey.avbpubkey",
4290 private_key: "testkey.pem",
4291 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004292 `)
4293
Colin Cross1c460562021-02-16 17:55:47 -08004294 ctx := testApex(t, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004295 apex {
4296 name: "myapex",
4297 key: "myapex.key",
4298 product_specific: true,
4299 file_contexts: "product_specific_file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004300 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004301 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004302
Jooyung Han580eb4f2020-06-24 19:33:06 +09004303 apex_key {
4304 name: "myapex.key",
4305 public_key: "testkey.avbpubkey",
4306 private_key: "testkey.pem",
4307 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004308 `, withFiles(map[string][]byte{
4309 "product_specific_file_contexts": nil,
4310 }))
Jooyung Han580eb4f2020-06-24 19:33:06 +09004311 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
4312 rule := module.Output("file_contexts")
4313 ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
4314}
Jooyung Han54aca7b2019-11-20 02:26:02 +09004315
Jooyung Han580eb4f2020-06-24 19:33:06 +09004316func TestFileContexts_SetViaFileGroup(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004317 ctx := testApex(t, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004318 apex {
4319 name: "myapex",
4320 key: "myapex.key",
4321 product_specific: true,
4322 file_contexts: ":my-file-contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004323 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004324 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004325
Jooyung Han580eb4f2020-06-24 19:33:06 +09004326 apex_key {
4327 name: "myapex.key",
4328 public_key: "testkey.avbpubkey",
4329 private_key: "testkey.pem",
4330 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004331
Jooyung Han580eb4f2020-06-24 19:33:06 +09004332 filegroup {
4333 name: "my-file-contexts",
4334 srcs: ["product_specific_file_contexts"],
4335 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004336 `, withFiles(map[string][]byte{
4337 "product_specific_file_contexts": nil,
4338 }))
Jooyung Han580eb4f2020-06-24 19:33:06 +09004339 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
4340 rule := module.Output("file_contexts")
4341 ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
Jooyung Han54aca7b2019-11-20 02:26:02 +09004342}
4343
Jiyong Park67882562019-03-21 01:11:21 +09004344func TestApexKeyFromOtherModule(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004345 ctx := testApex(t, `
Jiyong Park67882562019-03-21 01:11:21 +09004346 apex_key {
4347 name: "myapex.key",
4348 public_key: ":my.avbpubkey",
4349 private_key: ":my.pem",
4350 product_specific: true,
4351 }
4352
4353 filegroup {
4354 name: "my.avbpubkey",
4355 srcs: ["testkey2.avbpubkey"],
4356 }
4357
4358 filegroup {
4359 name: "my.pem",
4360 srcs: ["testkey2.pem"],
4361 }
4362 `)
4363
4364 apex_key := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
4365 expected_pubkey := "testkey2.avbpubkey"
Jaewoong Jung18aefc12020-12-21 09:11:10 -08004366 actual_pubkey := apex_key.publicKeyFile.String()
Jiyong Park67882562019-03-21 01:11:21 +09004367 if actual_pubkey != expected_pubkey {
4368 t.Errorf("wrong public key path. expected %q. actual %q", expected_pubkey, actual_pubkey)
4369 }
4370 expected_privkey := "testkey2.pem"
Jaewoong Jung18aefc12020-12-21 09:11:10 -08004371 actual_privkey := apex_key.privateKeyFile.String()
Jiyong Park67882562019-03-21 01:11:21 +09004372 if actual_privkey != expected_privkey {
4373 t.Errorf("wrong private key path. expected %q. actual %q", expected_privkey, actual_privkey)
4374 }
4375}
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004376
4377func TestPrebuilt(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004378 ctx := testApex(t, `
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004379 prebuilt_apex {
4380 name: "myapex",
Jiyong Parkc95714e2019-03-29 14:23:10 +09004381 arch: {
4382 arm64: {
4383 src: "myapex-arm64.apex",
4384 },
4385 arm: {
4386 src: "myapex-arm.apex",
4387 },
4388 },
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004389 }
4390 `)
4391
Paul Duffin6717d882021-06-15 19:09:41 +01004392 prebuilt := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt)
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004393
Jiyong Parkc95714e2019-03-29 14:23:10 +09004394 expectedInput := "myapex-arm64.apex"
4395 if prebuilt.inputApex.String() != expectedInput {
4396 t.Errorf("inputApex invalid. expected: %q, actual: %q", expectedInput, prebuilt.inputApex.String())
4397 }
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004398}
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004399
Paul Duffinc0609c62021-03-01 17:27:16 +00004400func TestPrebuiltMissingSrc(t *testing.T) {
Paul Duffin6717d882021-06-15 19:09:41 +01004401 testApexError(t, `module "myapex" variant "android_common_myapex".*: prebuilt_apex does not support "arm64_armv8-a"`, `
Paul Duffinc0609c62021-03-01 17:27:16 +00004402 prebuilt_apex {
4403 name: "myapex",
4404 }
4405 `)
4406}
4407
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004408func TestPrebuiltFilenameOverride(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004409 ctx := testApex(t, `
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004410 prebuilt_apex {
4411 name: "myapex",
4412 src: "myapex-arm.apex",
4413 filename: "notmyapex.apex",
4414 }
4415 `)
4416
Paul Duffin6717d882021-06-15 19:09:41 +01004417 p := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt)
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004418
4419 expected := "notmyapex.apex"
4420 if p.installFilename != expected {
4421 t.Errorf("installFilename invalid. expected: %q, actual: %q", expected, p.installFilename)
4422 }
4423}
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07004424
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004425func TestPrebuiltOverrides(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004426 ctx := testApex(t, `
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004427 prebuilt_apex {
4428 name: "myapex.prebuilt",
4429 src: "myapex-arm.apex",
4430 overrides: [
4431 "myapex",
4432 ],
4433 }
4434 `)
4435
Paul Duffin6717d882021-06-15 19:09:41 +01004436 p := ctx.ModuleForTests("myapex.prebuilt", "android_common_myapex.prebuilt").Module().(*Prebuilt)
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004437
4438 expected := []string{"myapex"}
Colin Crossaa255532020-07-03 13:18:24 -07004439 actual := android.AndroidMkEntriesForTest(t, ctx, p)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004440 if !reflect.DeepEqual(actual, expected) {
Jiyong Parkb0a012c2019-11-14 17:17:03 +09004441 t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES value '%s', expected '%s'", actual, expected)
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004442 }
4443}
4444
Paul Duffin092153d2021-01-26 11:42:39 +00004445// These tests verify that the prebuilt_apex/deapexer to java_import wiring allows for the
4446// propagation of paths to dex implementation jars from the former to the latter.
Paul Duffin064b70c2020-11-02 17:32:38 +00004447func TestPrebuiltExportDexImplementationJars(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01004448 transform := android.NullFixturePreparer
Paul Duffin064b70c2020-11-02 17:32:38 +00004449
Paul Duffin89886cb2021-02-05 16:44:03 +00004450 checkDexJarBuildPath := func(t *testing.T, ctx *android.TestContext, name string) {
Paul Duffin064b70c2020-11-02 17:32:38 +00004451 // Make sure the import has been given the correct path to the dex jar.
Colin Crossdcf71b22021-02-01 13:59:03 -08004452 p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency)
Paul Duffin064b70c2020-11-02 17:32:38 +00004453 dexJarBuildPath := p.DexJarBuildPath()
Paul Duffin39853512021-02-26 11:09:39 +00004454 stem := android.RemoveOptionalPrebuiltPrefix(name)
4455 if expected, actual := ".intermediates/myapex.deapexer/android_common/deapexer/javalib/"+stem+".jar", android.NormalizePathForTesting(dexJarBuildPath); actual != expected {
Paul Duffin064b70c2020-11-02 17:32:38 +00004456 t.Errorf("Incorrect DexJarBuildPath value '%s', expected '%s'", actual, expected)
4457 }
4458 }
4459
Paul Duffin39853512021-02-26 11:09:39 +00004460 ensureNoSourceVariant := func(t *testing.T, ctx *android.TestContext, name string) {
Paul Duffin064b70c2020-11-02 17:32:38 +00004461 // Make sure that an apex variant is not created for the source module.
Paul Duffin39853512021-02-26 11:09:39 +00004462 if expected, actual := []string{"android_common"}, ctx.ModuleVariantsForTests(name); !reflect.DeepEqual(expected, actual) {
Paul Duffin064b70c2020-11-02 17:32:38 +00004463 t.Errorf("invalid set of variants for %q: expected %q, found %q", "libfoo", expected, actual)
4464 }
4465 }
4466
4467 t.Run("prebuilt only", func(t *testing.T) {
4468 bp := `
4469 prebuilt_apex {
4470 name: "myapex",
4471 arch: {
4472 arm64: {
4473 src: "myapex-arm64.apex",
4474 },
4475 arm: {
4476 src: "myapex-arm.apex",
4477 },
4478 },
Paul Duffin39853512021-02-26 11:09:39 +00004479 exported_java_libs: ["libfoo", "libbar"],
Paul Duffin064b70c2020-11-02 17:32:38 +00004480 }
4481
4482 java_import {
4483 name: "libfoo",
4484 jars: ["libfoo.jar"],
4485 }
Paul Duffin39853512021-02-26 11:09:39 +00004486
4487 java_sdk_library_import {
4488 name: "libbar",
4489 public: {
4490 jars: ["libbar.jar"],
4491 },
4492 }
Paul Duffin064b70c2020-11-02 17:32:38 +00004493 `
4494
4495 // Make sure that dexpreopt can access dex implementation files from the prebuilt.
4496 ctx := testDexpreoptWithApexes(t, bp, "", transform)
4497
Paul Duffinf6932af2021-02-26 18:21:56 +00004498 // Make sure that the deapexer has the correct input APEX.
4499 deapexer := ctx.ModuleForTests("myapex.deapexer", "android_common")
4500 rule := deapexer.Rule("deapexer")
4501 if expected, actual := []string{"myapex-arm64.apex"}, android.NormalizePathsForTesting(rule.Implicits); !reflect.DeepEqual(expected, actual) {
4502 t.Errorf("expected: %q, found: %q", expected, actual)
4503 }
4504
Paul Duffin0d10c3c2021-03-01 17:09:32 +00004505 // Make sure that the prebuilt_apex has the correct input APEX.
Paul Duffin6717d882021-06-15 19:09:41 +01004506 prebuiltApex := ctx.ModuleForTests("myapex", "android_common_myapex")
Paul Duffin0d10c3c2021-03-01 17:09:32 +00004507 rule = prebuiltApex.Rule("android/soong/android.Cp")
4508 if expected, actual := "myapex-arm64.apex", android.NormalizePathForTesting(rule.Input); !reflect.DeepEqual(expected, actual) {
4509 t.Errorf("expected: %q, found: %q", expected, actual)
4510 }
4511
Paul Duffin89886cb2021-02-05 16:44:03 +00004512 checkDexJarBuildPath(t, ctx, "libfoo")
Paul Duffin39853512021-02-26 11:09:39 +00004513
4514 checkDexJarBuildPath(t, ctx, "libbar")
Paul Duffin064b70c2020-11-02 17:32:38 +00004515 })
4516
4517 t.Run("prebuilt with source preferred", func(t *testing.T) {
4518
4519 bp := `
4520 prebuilt_apex {
4521 name: "myapex",
4522 arch: {
4523 arm64: {
4524 src: "myapex-arm64.apex",
4525 },
4526 arm: {
4527 src: "myapex-arm.apex",
4528 },
4529 },
Paul Duffin39853512021-02-26 11:09:39 +00004530 exported_java_libs: ["libfoo", "libbar"],
Paul Duffin064b70c2020-11-02 17:32:38 +00004531 }
4532
4533 java_import {
4534 name: "libfoo",
4535 jars: ["libfoo.jar"],
4536 }
4537
4538 java_library {
4539 name: "libfoo",
4540 }
Paul Duffin39853512021-02-26 11:09:39 +00004541
4542 java_sdk_library_import {
4543 name: "libbar",
4544 public: {
4545 jars: ["libbar.jar"],
4546 },
4547 }
4548
4549 java_sdk_library {
4550 name: "libbar",
4551 srcs: ["foo/bar/MyClass.java"],
4552 unsafe_ignore_missing_latest_api: true,
4553 }
Paul Duffin064b70c2020-11-02 17:32:38 +00004554 `
4555
4556 // Make sure that dexpreopt can access dex implementation files from the prebuilt.
4557 ctx := testDexpreoptWithApexes(t, bp, "", transform)
4558
Paul Duffin89886cb2021-02-05 16:44:03 +00004559 checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
Paul Duffin39853512021-02-26 11:09:39 +00004560 ensureNoSourceVariant(t, ctx, "libfoo")
4561
4562 checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
4563 ensureNoSourceVariant(t, ctx, "libbar")
Paul Duffin064b70c2020-11-02 17:32:38 +00004564 })
4565
4566 t.Run("prebuilt preferred with source", func(t *testing.T) {
4567 bp := `
4568 prebuilt_apex {
4569 name: "myapex",
Paul Duffin064b70c2020-11-02 17:32:38 +00004570 arch: {
4571 arm64: {
4572 src: "myapex-arm64.apex",
4573 },
4574 arm: {
4575 src: "myapex-arm.apex",
4576 },
4577 },
Paul Duffin39853512021-02-26 11:09:39 +00004578 exported_java_libs: ["libfoo", "libbar"],
Paul Duffin064b70c2020-11-02 17:32:38 +00004579 }
4580
4581 java_import {
4582 name: "libfoo",
Paul Duffin092153d2021-01-26 11:42:39 +00004583 prefer: true,
Paul Duffin064b70c2020-11-02 17:32:38 +00004584 jars: ["libfoo.jar"],
4585 }
4586
4587 java_library {
4588 name: "libfoo",
4589 }
Paul Duffin39853512021-02-26 11:09:39 +00004590
4591 java_sdk_library_import {
4592 name: "libbar",
4593 prefer: true,
4594 public: {
4595 jars: ["libbar.jar"],
4596 },
4597 }
4598
4599 java_sdk_library {
4600 name: "libbar",
4601 srcs: ["foo/bar/MyClass.java"],
4602 unsafe_ignore_missing_latest_api: true,
4603 }
Paul Duffin064b70c2020-11-02 17:32:38 +00004604 `
4605
4606 // Make sure that dexpreopt can access dex implementation files from the prebuilt.
4607 ctx := testDexpreoptWithApexes(t, bp, "", transform)
4608
Paul Duffin89886cb2021-02-05 16:44:03 +00004609 checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
Paul Duffin39853512021-02-26 11:09:39 +00004610 ensureNoSourceVariant(t, ctx, "libfoo")
4611
4612 checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
4613 ensureNoSourceVariant(t, ctx, "libbar")
Paul Duffin064b70c2020-11-02 17:32:38 +00004614 })
4615}
4616
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004617func TestBootDexJarsFromSourcesAndPrebuilts(t *testing.T) {
Paul Duffinb6f53c02021-05-14 07:52:42 +01004618 preparer := android.GroupFixturePreparers(
4619 java.FixtureConfigureBootJars("myapex:libfoo", "myapex:libbar"),
4620 // Make sure that the frameworks/base/Android.bp file exists as otherwise hidden API encoding
4621 // is disabled.
4622 android.FixtureAddTextFile("frameworks/base/Android.bp", ""),
4623 )
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004624
Paul Duffin37856732021-02-26 14:24:15 +00004625 checkBootDexJarPath := func(t *testing.T, ctx *android.TestContext, stem string, bootDexJarPath string) {
4626 t.Helper()
Paul Duffin7ebebfd2021-04-27 19:36:57 +01004627 s := ctx.ModuleForTests("platform-bootclasspath", "android_common")
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004628 foundLibfooJar := false
Paul Duffin37856732021-02-26 14:24:15 +00004629 base := stem + ".jar"
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004630 for _, output := range s.AllOutputs() {
Paul Duffin37856732021-02-26 14:24:15 +00004631 if filepath.Base(output) == base {
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004632 foundLibfooJar = true
4633 buildRule := s.Output(output)
Paul Duffin55607122021-03-30 23:32:51 +01004634 android.AssertStringEquals(t, "boot dex jar path", bootDexJarPath, buildRule.Input.String())
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004635 }
4636 }
4637 if !foundLibfooJar {
Paul Duffin55607122021-03-30 23:32:51 +01004638 t.Errorf("Rule for libfoo.jar missing in dex_bootjars singleton outputs %q", android.StringPathsRelativeToTop(ctx.Config().BuildDir(), s.AllOutputs()))
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004639 }
4640 }
4641
Paul Duffind061d402021-06-07 21:36:01 +01004642 checkHiddenAPIIndexInputs := func(t *testing.T, ctx *android.TestContext, expectedIntermediateInputs string) {
Paul Duffin37856732021-02-26 14:24:15 +00004643 t.Helper()
Paul Duffin00b2bfd2021-04-12 17:24:36 +01004644 platformBootclasspath := ctx.ModuleForTests("platform-bootclasspath", "android_common")
Paul Duffind061d402021-06-07 21:36:01 +01004645 var rule android.TestingBuildParams
4646
4647 rule = platformBootclasspath.Output("hiddenapi-monolithic/index-from-classes.csv")
4648 java.CheckHiddenAPIRuleInputs(t, "intermediate index", expectedIntermediateInputs, rule)
Paul Duffin4fd997b2021-02-03 20:06:33 +00004649 }
4650
Paul Duffin89f570a2021-06-16 01:42:33 +01004651 fragment := java.ApexVariantReference{
4652 Apex: proptools.StringPtr("myapex"),
4653 Module: proptools.StringPtr("my-bootclasspath-fragment"),
4654 }
4655
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004656 t.Run("prebuilt only", func(t *testing.T) {
4657 bp := `
4658 prebuilt_apex {
4659 name: "myapex",
4660 arch: {
4661 arm64: {
4662 src: "myapex-arm64.apex",
4663 },
4664 arm: {
4665 src: "myapex-arm.apex",
4666 },
4667 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004668 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4669 }
4670
4671 prebuilt_bootclasspath_fragment {
4672 name: "my-bootclasspath-fragment",
4673 contents: ["libfoo", "libbar"],
4674 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004675 }
4676
4677 java_import {
4678 name: "libfoo",
4679 jars: ["libfoo.jar"],
4680 apex_available: ["myapex"],
4681 }
Paul Duffin37856732021-02-26 14:24:15 +00004682
4683 java_sdk_library_import {
4684 name: "libbar",
4685 public: {
4686 jars: ["libbar.jar"],
4687 },
4688 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004689 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00004690 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004691 `
4692
Paul Duffin89f570a2021-06-16 01:42:33 +01004693 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01004694 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
4695 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00004696
Paul Duffin537ea3d2021-05-14 10:38:00 +01004697 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin9d67ca62021-02-03 20:06:33 +00004698 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin51d7da22021-06-16 02:04:13 +01004699 out/soong/.intermediates/libbar.stubs/android_common/combined/libbar.stubs.jar
4700 out/soong/.intermediates/libfoo/android_common_myapex/combined/libfoo.jar
4701 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004702 })
4703
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004704 t.Run("apex_set only", func(t *testing.T) {
4705 bp := `
4706 apex_set {
4707 name: "myapex",
4708 set: "myapex.apks",
Paul Duffin89f570a2021-06-16 01:42:33 +01004709 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4710 }
4711
4712 prebuilt_bootclasspath_fragment {
4713 name: "my-bootclasspath-fragment",
4714 contents: ["libfoo", "libbar"],
4715 apex_available: ["myapex"],
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004716 }
4717
4718 java_import {
4719 name: "libfoo",
4720 jars: ["libfoo.jar"],
4721 apex_available: ["myapex"],
4722 }
4723
4724 java_sdk_library_import {
4725 name: "libbar",
4726 public: {
4727 jars: ["libbar.jar"],
4728 },
4729 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004730 shared_library: false,
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004731 }
4732 `
4733
Paul Duffin89f570a2021-06-16 01:42:33 +01004734 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004735 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
4736 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
4737
Paul Duffin537ea3d2021-05-14 10:38:00 +01004738 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004739 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin51d7da22021-06-16 02:04:13 +01004740 out/soong/.intermediates/libbar.stubs/android_common/combined/libbar.stubs.jar
4741 out/soong/.intermediates/libfoo/android_common_myapex/combined/libfoo.jar
4742 `)
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004743 })
4744
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004745 t.Run("prebuilt with source library preferred", func(t *testing.T) {
4746 bp := `
4747 prebuilt_apex {
4748 name: "myapex",
4749 arch: {
4750 arm64: {
4751 src: "myapex-arm64.apex",
4752 },
4753 arm: {
4754 src: "myapex-arm.apex",
4755 },
4756 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004757 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4758 }
4759
4760 prebuilt_bootclasspath_fragment {
4761 name: "my-bootclasspath-fragment",
4762 contents: ["libfoo", "libbar"],
4763 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004764 }
4765
4766 java_import {
4767 name: "libfoo",
4768 jars: ["libfoo.jar"],
4769 apex_available: ["myapex"],
4770 }
4771
4772 java_library {
4773 name: "libfoo",
4774 srcs: ["foo/bar/MyClass.java"],
4775 apex_available: ["myapex"],
4776 }
Paul Duffin37856732021-02-26 14:24:15 +00004777
4778 java_sdk_library_import {
4779 name: "libbar",
4780 public: {
4781 jars: ["libbar.jar"],
4782 },
4783 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004784 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00004785 }
4786
4787 java_sdk_library {
4788 name: "libbar",
4789 srcs: ["foo/bar/MyClass.java"],
4790 unsafe_ignore_missing_latest_api: true,
4791 apex_available: ["myapex"],
4792 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004793 `
4794
4795 // In this test the source (java_library) libfoo is active since the
4796 // prebuilt (java_import) defaults to prefer:false. However the
4797 // prebuilt_apex module always depends on the prebuilt, and so it doesn't
4798 // find the dex boot jar in it. We either need to disable the source libfoo
4799 // or make the prebuilt libfoo preferred.
Paul Duffin89f570a2021-06-16 01:42:33 +01004800 testDexpreoptWithApexes(t, bp, "module libfoo does not provide a dex boot jar", preparer, fragment)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004801 })
4802
4803 t.Run("prebuilt library preferred with source", func(t *testing.T) {
4804 bp := `
4805 prebuilt_apex {
4806 name: "myapex",
4807 arch: {
4808 arm64: {
4809 src: "myapex-arm64.apex",
4810 },
4811 arm: {
4812 src: "myapex-arm.apex",
4813 },
4814 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004815 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4816 }
4817
4818 prebuilt_bootclasspath_fragment {
4819 name: "my-bootclasspath-fragment",
4820 contents: ["libfoo", "libbar"],
4821 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004822 }
4823
4824 java_import {
4825 name: "libfoo",
4826 prefer: true,
4827 jars: ["libfoo.jar"],
4828 apex_available: ["myapex"],
4829 }
4830
4831 java_library {
4832 name: "libfoo",
4833 srcs: ["foo/bar/MyClass.java"],
4834 apex_available: ["myapex"],
4835 }
Paul Duffin37856732021-02-26 14:24:15 +00004836
4837 java_sdk_library_import {
4838 name: "libbar",
4839 prefer: true,
4840 public: {
4841 jars: ["libbar.jar"],
4842 },
4843 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004844 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00004845 }
4846
4847 java_sdk_library {
4848 name: "libbar",
4849 srcs: ["foo/bar/MyClass.java"],
4850 unsafe_ignore_missing_latest_api: true,
4851 apex_available: ["myapex"],
4852 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004853 `
4854
Paul Duffin89f570a2021-06-16 01:42:33 +01004855 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01004856 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
4857 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00004858
Paul Duffin537ea3d2021-05-14 10:38:00 +01004859 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin9d67ca62021-02-03 20:06:33 +00004860 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin51d7da22021-06-16 02:04:13 +01004861 out/soong/.intermediates/prebuilt_libbar.stubs/android_common/combined/libbar.stubs.jar
4862 out/soong/.intermediates/prebuilt_libfoo/android_common_myapex/combined/libfoo.jar
4863 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004864 })
4865
4866 t.Run("prebuilt with source apex preferred", func(t *testing.T) {
4867 bp := `
4868 apex {
4869 name: "myapex",
4870 key: "myapex.key",
Paul Duffin37856732021-02-26 14:24:15 +00004871 java_libs: ["libfoo", "libbar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004872 updatable: false,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004873 }
4874
4875 apex_key {
4876 name: "myapex.key",
4877 public_key: "testkey.avbpubkey",
4878 private_key: "testkey.pem",
4879 }
4880
4881 prebuilt_apex {
4882 name: "myapex",
4883 arch: {
4884 arm64: {
4885 src: "myapex-arm64.apex",
4886 },
4887 arm: {
4888 src: "myapex-arm.apex",
4889 },
4890 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004891 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4892 }
4893
4894 prebuilt_bootclasspath_fragment {
4895 name: "my-bootclasspath-fragment",
4896 contents: ["libfoo", "libbar"],
4897 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004898 }
4899
4900 java_import {
4901 name: "libfoo",
4902 jars: ["libfoo.jar"],
4903 apex_available: ["myapex"],
4904 }
4905
4906 java_library {
4907 name: "libfoo",
4908 srcs: ["foo/bar/MyClass.java"],
4909 apex_available: ["myapex"],
4910 }
Paul Duffin37856732021-02-26 14:24:15 +00004911
4912 java_sdk_library_import {
4913 name: "libbar",
4914 public: {
4915 jars: ["libbar.jar"],
4916 },
4917 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004918 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00004919 }
4920
4921 java_sdk_library {
4922 name: "libbar",
4923 srcs: ["foo/bar/MyClass.java"],
4924 unsafe_ignore_missing_latest_api: true,
4925 apex_available: ["myapex"],
4926 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004927 `
4928
Paul Duffin89f570a2021-06-16 01:42:33 +01004929 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01004930 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/libfoo/android_common_apex10000/hiddenapi/libfoo.jar")
4931 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/libbar/android_common_myapex/hiddenapi/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00004932
Paul Duffin537ea3d2021-05-14 10:38:00 +01004933 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin4fd997b2021-02-03 20:06:33 +00004934 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin51d7da22021-06-16 02:04:13 +01004935 out/soong/.intermediates/libbar/android_common_myapex/javac/libbar.jar
4936 out/soong/.intermediates/libfoo/android_common_apex10000/javac/libfoo.jar
4937 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004938 })
4939
4940 t.Run("prebuilt preferred with source apex disabled", func(t *testing.T) {
4941 bp := `
4942 apex {
4943 name: "myapex",
4944 enabled: false,
4945 key: "myapex.key",
Paul Duffin8f146b92021-04-12 17:24:18 +01004946 java_libs: ["libfoo", "libbar"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004947 }
4948
4949 apex_key {
4950 name: "myapex.key",
4951 public_key: "testkey.avbpubkey",
4952 private_key: "testkey.pem",
4953 }
4954
4955 prebuilt_apex {
4956 name: "myapex",
4957 arch: {
4958 arm64: {
4959 src: "myapex-arm64.apex",
4960 },
4961 arm: {
4962 src: "myapex-arm.apex",
4963 },
4964 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004965 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4966 }
4967
4968 prebuilt_bootclasspath_fragment {
4969 name: "my-bootclasspath-fragment",
4970 contents: ["libfoo", "libbar"],
4971 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004972 }
4973
4974 java_import {
4975 name: "libfoo",
4976 prefer: true,
4977 jars: ["libfoo.jar"],
4978 apex_available: ["myapex"],
4979 }
4980
4981 java_library {
4982 name: "libfoo",
4983 srcs: ["foo/bar/MyClass.java"],
4984 apex_available: ["myapex"],
4985 }
Paul Duffin37856732021-02-26 14:24:15 +00004986
4987 java_sdk_library_import {
4988 name: "libbar",
4989 prefer: true,
4990 public: {
4991 jars: ["libbar.jar"],
4992 },
4993 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004994 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00004995 }
4996
4997 java_sdk_library {
4998 name: "libbar",
4999 srcs: ["foo/bar/MyClass.java"],
5000 unsafe_ignore_missing_latest_api: true,
5001 apex_available: ["myapex"],
5002 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005003 `
5004
Paul Duffin89f570a2021-06-16 01:42:33 +01005005 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01005006 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
5007 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00005008
Paul Duffin537ea3d2021-05-14 10:38:00 +01005009 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin9d67ca62021-02-03 20:06:33 +00005010 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin51d7da22021-06-16 02:04:13 +01005011 out/soong/.intermediates/prebuilt_libbar.stubs/android_common/combined/libbar.stubs.jar
5012 out/soong/.intermediates/prebuilt_libfoo/android_common_myapex/combined/libfoo.jar
5013 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005014 })
5015}
5016
Roland Levillain630846d2019-06-26 12:48:34 +01005017func TestApexWithTests(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005018 ctx := testApex(t, `
Roland Levillain630846d2019-06-26 12:48:34 +01005019 apex_test {
5020 name: "myapex",
5021 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005022 updatable: false,
Roland Levillain630846d2019-06-26 12:48:34 +01005023 tests: [
5024 "mytest",
Roland Levillain9b5fde92019-06-28 15:41:19 +01005025 "mytests",
Roland Levillain630846d2019-06-26 12:48:34 +01005026 ],
5027 }
5028
5029 apex_key {
5030 name: "myapex.key",
5031 public_key: "testkey.avbpubkey",
5032 private_key: "testkey.pem",
5033 }
5034
Liz Kammer1c14a212020-05-12 15:26:55 -07005035 filegroup {
5036 name: "fg",
5037 srcs: [
5038 "baz",
5039 "bar/baz"
5040 ],
5041 }
5042
Roland Levillain630846d2019-06-26 12:48:34 +01005043 cc_test {
5044 name: "mytest",
5045 gtest: false,
5046 srcs: ["mytest.cpp"],
5047 relative_install_path: "test",
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005048 shared_libs: ["mylib"],
Roland Levillain630846d2019-06-26 12:48:34 +01005049 system_shared_libs: [],
5050 static_executable: true,
5051 stl: "none",
Liz Kammer1c14a212020-05-12 15:26:55 -07005052 data: [":fg"],
Roland Levillain630846d2019-06-26 12:48:34 +01005053 }
Roland Levillain9b5fde92019-06-28 15:41:19 +01005054
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005055 cc_library {
5056 name: "mylib",
5057 srcs: ["mylib.cpp"],
5058 system_shared_libs: [],
5059 stl: "none",
5060 }
5061
Liz Kammer5bd365f2020-05-27 15:15:11 -07005062 filegroup {
5063 name: "fg2",
5064 srcs: [
5065 "testdata/baz"
5066 ],
5067 }
5068
Roland Levillain9b5fde92019-06-28 15:41:19 +01005069 cc_test {
5070 name: "mytests",
5071 gtest: false,
5072 srcs: [
5073 "mytest1.cpp",
5074 "mytest2.cpp",
5075 "mytest3.cpp",
5076 ],
5077 test_per_src: true,
5078 relative_install_path: "test",
5079 system_shared_libs: [],
5080 static_executable: true,
5081 stl: "none",
Liz Kammer5bd365f2020-05-27 15:15:11 -07005082 data: [
5083 ":fg",
5084 ":fg2",
5085 ],
Roland Levillain9b5fde92019-06-28 15:41:19 +01005086 }
Roland Levillain630846d2019-06-26 12:48:34 +01005087 `)
5088
Sundong Ahnabb64432019-10-22 13:58:29 +09005089 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Roland Levillain630846d2019-06-26 12:48:34 +01005090 copyCmds := apexRule.Args["copy_commands"]
5091
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005092 // Ensure that test dep (and their transitive dependencies) are copied into apex.
Roland Levillain630846d2019-06-26 12:48:34 +01005093 ensureContains(t, copyCmds, "image.apex/bin/test/mytest")
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005094 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Roland Levillain9b5fde92019-06-28 15:41:19 +01005095
Liz Kammer1c14a212020-05-12 15:26:55 -07005096 //Ensure that test data are copied into apex.
5097 ensureContains(t, copyCmds, "image.apex/bin/test/baz")
5098 ensureContains(t, copyCmds, "image.apex/bin/test/bar/baz")
5099
Roland Levillain9b5fde92019-06-28 15:41:19 +01005100 // Ensure that test deps built with `test_per_src` are copied into apex.
5101 ensureContains(t, copyCmds, "image.apex/bin/test/mytest1")
5102 ensureContains(t, copyCmds, "image.apex/bin/test/mytest2")
5103 ensureContains(t, copyCmds, "image.apex/bin/test/mytest3")
Roland Levillainf89cd092019-07-29 16:22:59 +01005104
5105 // Ensure the module is correctly translated.
Liz Kammer81faaaf2020-05-20 09:57:08 -07005106 bundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07005107 data := android.AndroidMkDataForTest(t, ctx, bundle)
Liz Kammer81faaaf2020-05-20 09:57:08 -07005108 name := bundle.BaseModuleName()
Roland Levillainf89cd092019-07-29 16:22:59 +01005109 prefix := "TARGET_"
5110 var builder strings.Builder
5111 data.Custom(&builder, name, prefix, "", data)
5112 androidMk := builder.String()
Jooyung Han31c470b2019-10-18 16:26:59 +09005113 ensureContains(t, androidMk, "LOCAL_MODULE := mytest.myapex\n")
5114 ensureContains(t, androidMk, "LOCAL_MODULE := mytest1.myapex\n")
5115 ensureContains(t, androidMk, "LOCAL_MODULE := mytest2.myapex\n")
5116 ensureContains(t, androidMk, "LOCAL_MODULE := mytest3.myapex\n")
Jooyung Han214bf372019-11-12 13:03:50 +09005117 ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex\n")
Jooyung Han31c470b2019-10-18 16:26:59 +09005118 ensureContains(t, androidMk, "LOCAL_MODULE := apex_pubkey.myapex\n")
Roland Levillainf89cd092019-07-29 16:22:59 +01005119 ensureContains(t, androidMk, "LOCAL_MODULE := myapex\n")
Liz Kammer81faaaf2020-05-20 09:57:08 -07005120
5121 flatBundle := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07005122 data = android.AndroidMkDataForTest(t, ctx, flatBundle)
Liz Kammer81faaaf2020-05-20 09:57:08 -07005123 data.Custom(&builder, name, prefix, "", data)
5124 flatAndroidMk := builder.String()
Liz Kammer5bd365f2020-05-27 15:15:11 -07005125 ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :baz :bar/baz\n")
5126 ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :testdata/baz\n")
Roland Levillain630846d2019-06-26 12:48:34 +01005127}
5128
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005129func TestInstallExtraFlattenedApexes(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005130 ctx := testApex(t, `
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005131 apex {
5132 name: "myapex",
5133 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005134 updatable: false,
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005135 }
5136 apex_key {
5137 name: "myapex.key",
5138 public_key: "testkey.avbpubkey",
5139 private_key: "testkey.pem",
5140 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00005141 `,
5142 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
5143 variables.InstallExtraFlattenedApexes = proptools.BoolPtr(true)
5144 }),
5145 )
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005146 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Jiyong Park83dc74b2020-01-14 18:38:44 +09005147 ensureListContains(t, ab.requiredDeps, "myapex.flattened")
Colin Crossaa255532020-07-03 13:18:24 -07005148 mk := android.AndroidMkDataForTest(t, ctx, ab)
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005149 var builder strings.Builder
5150 mk.Custom(&builder, ab.Name(), "TARGET_", "", mk)
5151 androidMk := builder.String()
5152 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += myapex.flattened")
5153}
5154
Jooyung Hand48f3c32019-08-23 11:18:57 +09005155func TestErrorsIfDepsAreNotEnabled(t *testing.T) {
5156 testApexError(t, `module "myapex" .* depends on disabled module "libfoo"`, `
5157 apex {
5158 name: "myapex",
5159 key: "myapex.key",
5160 native_shared_libs: ["libfoo"],
5161 }
5162
5163 apex_key {
5164 name: "myapex.key",
5165 public_key: "testkey.avbpubkey",
5166 private_key: "testkey.pem",
5167 }
5168
5169 cc_library {
5170 name: "libfoo",
5171 stl: "none",
5172 system_shared_libs: [],
5173 enabled: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09005174 apex_available: ["myapex"],
Jooyung Hand48f3c32019-08-23 11:18:57 +09005175 }
5176 `)
5177 testApexError(t, `module "myapex" .* depends on disabled module "myjar"`, `
5178 apex {
5179 name: "myapex",
5180 key: "myapex.key",
5181 java_libs: ["myjar"],
5182 }
5183
5184 apex_key {
5185 name: "myapex.key",
5186 public_key: "testkey.avbpubkey",
5187 private_key: "testkey.pem",
5188 }
5189
5190 java_library {
5191 name: "myjar",
5192 srcs: ["foo/bar/MyClass.java"],
5193 sdk_version: "none",
5194 system_modules: "none",
Jooyung Hand48f3c32019-08-23 11:18:57 +09005195 enabled: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09005196 apex_available: ["myapex"],
Jooyung Hand48f3c32019-08-23 11:18:57 +09005197 }
5198 `)
5199}
5200
Bill Peckhama41a6962021-01-11 10:58:54 -08005201func TestApexWithJavaImport(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005202 ctx := testApex(t, `
Bill Peckhama41a6962021-01-11 10:58:54 -08005203 apex {
5204 name: "myapex",
5205 key: "myapex.key",
5206 java_libs: ["myjavaimport"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005207 updatable: false,
Bill Peckhama41a6962021-01-11 10:58:54 -08005208 }
5209
5210 apex_key {
5211 name: "myapex.key",
5212 public_key: "testkey.avbpubkey",
5213 private_key: "testkey.pem",
5214 }
5215
5216 java_import {
5217 name: "myjavaimport",
5218 apex_available: ["myapex"],
5219 jars: ["my.jar"],
5220 compile_dex: true,
5221 }
5222 `)
5223
5224 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
5225 apexRule := module.Rule("apexRule")
5226 copyCmds := apexRule.Args["copy_commands"]
5227 ensureContains(t, copyCmds, "image.apex/javalib/myjavaimport.jar")
5228}
5229
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005230func TestApexWithApps(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005231 ctx := testApex(t, `
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005232 apex {
5233 name: "myapex",
5234 key: "myapex.key",
5235 apps: [
5236 "AppFoo",
Jiyong Parkf7487312019-10-17 12:54:30 +09005237 "AppFooPriv",
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005238 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005239 updatable: false,
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005240 }
5241
5242 apex_key {
5243 name: "myapex.key",
5244 public_key: "testkey.avbpubkey",
5245 private_key: "testkey.pem",
5246 }
5247
5248 android_app {
5249 name: "AppFoo",
5250 srcs: ["foo/bar/MyClass.java"],
Colin Cross094cde42020-02-15 10:38:00 -08005251 sdk_version: "current",
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005252 system_modules: "none",
Jiyong Park8be103b2019-11-08 15:53:48 +09005253 jni_libs: ["libjni"],
Colin Cross094cde42020-02-15 10:38:00 -08005254 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005255 apex_available: [ "myapex" ],
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005256 }
Jiyong Parkf7487312019-10-17 12:54:30 +09005257
5258 android_app {
5259 name: "AppFooPriv",
5260 srcs: ["foo/bar/MyClass.java"],
Colin Cross094cde42020-02-15 10:38:00 -08005261 sdk_version: "current",
Jiyong Parkf7487312019-10-17 12:54:30 +09005262 system_modules: "none",
5263 privileged: true,
Colin Cross094cde42020-02-15 10:38:00 -08005264 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005265 apex_available: [ "myapex" ],
Jiyong Parkf7487312019-10-17 12:54:30 +09005266 }
Jiyong Park8be103b2019-11-08 15:53:48 +09005267
5268 cc_library_shared {
5269 name: "libjni",
5270 srcs: ["mylib.cpp"],
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005271 shared_libs: ["libfoo"],
5272 stl: "none",
5273 system_shared_libs: [],
5274 apex_available: [ "myapex" ],
5275 sdk_version: "current",
5276 }
5277
5278 cc_library_shared {
5279 name: "libfoo",
Jiyong Park8be103b2019-11-08 15:53:48 +09005280 stl: "none",
5281 system_shared_libs: [],
Jiyong Park0f80c182020-01-31 02:49:53 +09005282 apex_available: [ "myapex" ],
Colin Cross094cde42020-02-15 10:38:00 -08005283 sdk_version: "current",
Jiyong Park8be103b2019-11-08 15:53:48 +09005284 }
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005285 `)
5286
Sundong Ahnabb64432019-10-22 13:58:29 +09005287 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005288 apexRule := module.Rule("apexRule")
5289 copyCmds := apexRule.Args["copy_commands"]
5290
5291 ensureContains(t, copyCmds, "image.apex/app/AppFoo/AppFoo.apk")
Jiyong Parkf7487312019-10-17 12:54:30 +09005292 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPriv/AppFooPriv.apk")
Jiyong Park52cd06f2019-11-11 10:14:32 +09005293
Colin Crossaede88c2020-08-11 12:17:01 -07005294 appZipRule := ctx.ModuleForTests("AppFoo", "android_common_apex10000").Description("zip jni libs")
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005295 // JNI libraries are uncompressed
Jiyong Park52cd06f2019-11-11 10:14:32 +09005296 if args := appZipRule.Args["jarArgs"]; !strings.Contains(args, "-L 0") {
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005297 t.Errorf("jni libs are not uncompressed for AppFoo")
Jiyong Park52cd06f2019-11-11 10:14:32 +09005298 }
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005299 // JNI libraries including transitive deps are
5300 for _, jni := range []string{"libjni", "libfoo"} {
Paul Duffinafdd4062021-03-30 19:44:07 +01005301 jniOutput := ctx.ModuleForTests(jni, "android_arm64_armv8-a_sdk_shared_apex10000").Module().(*cc.Module).OutputFile().RelativeToTop()
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005302 // ... embedded inside APK (jnilibs.zip)
5303 ensureListContains(t, appZipRule.Implicits.Strings(), jniOutput.String())
5304 // ... and not directly inside the APEX
5305 ensureNotContains(t, copyCmds, "image.apex/lib64/"+jni+".so")
5306 }
Dario Frenicde2a032019-10-27 00:29:22 +01005307}
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005308
Dario Frenicde2a032019-10-27 00:29:22 +01005309func TestApexWithAppImports(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005310 ctx := testApex(t, `
Dario Frenicde2a032019-10-27 00:29:22 +01005311 apex {
5312 name: "myapex",
5313 key: "myapex.key",
5314 apps: [
5315 "AppFooPrebuilt",
5316 "AppFooPrivPrebuilt",
5317 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005318 updatable: false,
Dario Frenicde2a032019-10-27 00:29:22 +01005319 }
5320
5321 apex_key {
5322 name: "myapex.key",
5323 public_key: "testkey.avbpubkey",
5324 private_key: "testkey.pem",
5325 }
5326
5327 android_app_import {
5328 name: "AppFooPrebuilt",
5329 apk: "PrebuiltAppFoo.apk",
5330 presigned: true,
5331 dex_preopt: {
5332 enabled: false,
5333 },
Jiyong Park592a6a42020-04-21 22:34:28 +09005334 apex_available: ["myapex"],
Dario Frenicde2a032019-10-27 00:29:22 +01005335 }
5336
5337 android_app_import {
5338 name: "AppFooPrivPrebuilt",
5339 apk: "PrebuiltAppFooPriv.apk",
5340 privileged: true,
5341 presigned: true,
5342 dex_preopt: {
5343 enabled: false,
5344 },
Jooyung Han39ee1192020-03-23 20:21:11 +09005345 filename: "AwesomePrebuiltAppFooPriv.apk",
Jiyong Park592a6a42020-04-21 22:34:28 +09005346 apex_available: ["myapex"],
Dario Frenicde2a032019-10-27 00:29:22 +01005347 }
5348 `)
5349
Sundong Ahnabb64432019-10-22 13:58:29 +09005350 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Dario Frenicde2a032019-10-27 00:29:22 +01005351 apexRule := module.Rule("apexRule")
5352 copyCmds := apexRule.Args["copy_commands"]
5353
5354 ensureContains(t, copyCmds, "image.apex/app/AppFooPrebuilt/AppFooPrebuilt.apk")
Jooyung Han39ee1192020-03-23 20:21:11 +09005355 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPrivPrebuilt/AwesomePrebuiltAppFooPriv.apk")
5356}
5357
5358func TestApexWithAppImportsPrefer(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005359 ctx := testApex(t, `
Jooyung Han39ee1192020-03-23 20:21:11 +09005360 apex {
5361 name: "myapex",
5362 key: "myapex.key",
5363 apps: [
5364 "AppFoo",
5365 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005366 updatable: false,
Jooyung Han39ee1192020-03-23 20:21:11 +09005367 }
5368
5369 apex_key {
5370 name: "myapex.key",
5371 public_key: "testkey.avbpubkey",
5372 private_key: "testkey.pem",
5373 }
5374
5375 android_app {
5376 name: "AppFoo",
5377 srcs: ["foo/bar/MyClass.java"],
5378 sdk_version: "none",
5379 system_modules: "none",
5380 apex_available: [ "myapex" ],
5381 }
5382
5383 android_app_import {
5384 name: "AppFoo",
5385 apk: "AppFooPrebuilt.apk",
5386 filename: "AppFooPrebuilt.apk",
5387 presigned: true,
5388 prefer: true,
Jiyong Park592a6a42020-04-21 22:34:28 +09005389 apex_available: ["myapex"],
Jooyung Han39ee1192020-03-23 20:21:11 +09005390 }
5391 `, withFiles(map[string][]byte{
5392 "AppFooPrebuilt.apk": nil,
5393 }))
5394
5395 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Han86feead2021-03-08 13:11:48 +09005396 "app/AppFoo/AppFooPrebuilt.apk",
Jooyung Han39ee1192020-03-23 20:21:11 +09005397 })
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005398}
5399
Dario Freni6f3937c2019-12-20 22:58:03 +00005400func TestApexWithTestHelperApp(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005401 ctx := testApex(t, `
Dario Freni6f3937c2019-12-20 22:58:03 +00005402 apex {
5403 name: "myapex",
5404 key: "myapex.key",
5405 apps: [
5406 "TesterHelpAppFoo",
5407 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005408 updatable: false,
Dario Freni6f3937c2019-12-20 22:58:03 +00005409 }
5410
5411 apex_key {
5412 name: "myapex.key",
5413 public_key: "testkey.avbpubkey",
5414 private_key: "testkey.pem",
5415 }
5416
5417 android_test_helper_app {
5418 name: "TesterHelpAppFoo",
5419 srcs: ["foo/bar/MyClass.java"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005420 apex_available: [ "myapex" ],
Dario Freni6f3937c2019-12-20 22:58:03 +00005421 }
5422
5423 `)
5424
5425 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
5426 apexRule := module.Rule("apexRule")
5427 copyCmds := apexRule.Args["copy_commands"]
5428
5429 ensureContains(t, copyCmds, "image.apex/app/TesterHelpAppFoo/TesterHelpAppFoo.apk")
5430}
5431
Jooyung Han18020ea2019-11-13 10:50:48 +09005432func TestApexPropertiesShouldBeDefaultable(t *testing.T) {
5433 // libfoo's apex_available comes from cc_defaults
Steven Moreland6e36cd62020-10-22 01:08:35 +00005434 testApexError(t, `requires "libfoo" that doesn't list the APEX under 'apex_available'.`, `
Jooyung Han18020ea2019-11-13 10:50:48 +09005435 apex {
5436 name: "myapex",
5437 key: "myapex.key",
5438 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005439 updatable: false,
Jooyung Han18020ea2019-11-13 10:50:48 +09005440 }
5441
5442 apex_key {
5443 name: "myapex.key",
5444 public_key: "testkey.avbpubkey",
5445 private_key: "testkey.pem",
5446 }
5447
5448 apex {
5449 name: "otherapex",
5450 key: "myapex.key",
5451 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005452 updatable: false,
Jooyung Han18020ea2019-11-13 10:50:48 +09005453 }
5454
5455 cc_defaults {
5456 name: "libfoo-defaults",
5457 apex_available: ["otherapex"],
5458 }
5459
5460 cc_library {
5461 name: "libfoo",
5462 defaults: ["libfoo-defaults"],
5463 stl: "none",
5464 system_shared_libs: [],
5465 }`)
5466}
5467
Paul Duffine52e66f2020-03-30 17:54:29 +01005468func TestApexAvailable_DirectDep(t *testing.T) {
Jiyong Park127b40b2019-09-30 16:04:35 +09005469 // libfoo is not available to myapex, but only to otherapex
Steven Moreland6e36cd62020-10-22 01:08:35 +00005470 testApexError(t, "requires \"libfoo\" that doesn't list the APEX under 'apex_available'.", `
Jiyong Park127b40b2019-09-30 16:04:35 +09005471 apex {
5472 name: "myapex",
5473 key: "myapex.key",
5474 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005475 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005476 }
5477
5478 apex_key {
5479 name: "myapex.key",
5480 public_key: "testkey.avbpubkey",
5481 private_key: "testkey.pem",
5482 }
5483
5484 apex {
5485 name: "otherapex",
5486 key: "otherapex.key",
5487 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005488 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005489 }
5490
5491 apex_key {
5492 name: "otherapex.key",
5493 public_key: "testkey.avbpubkey",
5494 private_key: "testkey.pem",
5495 }
5496
5497 cc_library {
5498 name: "libfoo",
5499 stl: "none",
5500 system_shared_libs: [],
5501 apex_available: ["otherapex"],
5502 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01005503}
Jiyong Park127b40b2019-09-30 16:04:35 +09005504
Paul Duffine52e66f2020-03-30 17:54:29 +01005505func TestApexAvailable_IndirectDep(t *testing.T) {
Jooyung Han5e9013b2020-03-10 06:23:13 +09005506 // libbbaz is an indirect dep
Jiyong Park767dbd92021-03-04 13:03:10 +09005507 testApexError(t, `requires "libbaz" that doesn't list the APEX under 'apex_available'.\n\nDependency path:
Colin Cross6e511a92020-07-27 21:26:48 -07005508.*via tag apex\.dependencyTag.*name:sharedLib.*
Paul Duffindf915ff2020-03-30 17:58:21 +01005509.*-> libfoo.*link:shared.*
Colin Cross6e511a92020-07-27 21:26:48 -07005510.*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
Paul Duffindf915ff2020-03-30 17:58:21 +01005511.*-> libbar.*link:shared.*
Colin Cross6e511a92020-07-27 21:26:48 -07005512.*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
Paul Duffin65347702020-03-31 15:23:40 +01005513.*-> libbaz.*link:shared.*`, `
Jiyong Park127b40b2019-09-30 16:04:35 +09005514 apex {
5515 name: "myapex",
5516 key: "myapex.key",
5517 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005518 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005519 }
5520
5521 apex_key {
5522 name: "myapex.key",
5523 public_key: "testkey.avbpubkey",
5524 private_key: "testkey.pem",
5525 }
5526
Jiyong Park127b40b2019-09-30 16:04:35 +09005527 cc_library {
5528 name: "libfoo",
5529 stl: "none",
5530 shared_libs: ["libbar"],
5531 system_shared_libs: [],
Jooyung Han5e9013b2020-03-10 06:23:13 +09005532 apex_available: ["myapex"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005533 }
5534
5535 cc_library {
5536 name: "libbar",
5537 stl: "none",
Jooyung Han5e9013b2020-03-10 06:23:13 +09005538 shared_libs: ["libbaz"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005539 system_shared_libs: [],
Jooyung Han5e9013b2020-03-10 06:23:13 +09005540 apex_available: ["myapex"],
5541 }
5542
5543 cc_library {
5544 name: "libbaz",
5545 stl: "none",
5546 system_shared_libs: [],
Jiyong Park127b40b2019-09-30 16:04:35 +09005547 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01005548}
Jiyong Park127b40b2019-09-30 16:04:35 +09005549
Paul Duffine52e66f2020-03-30 17:54:29 +01005550func TestApexAvailable_InvalidApexName(t *testing.T) {
Jiyong Park127b40b2019-09-30 16:04:35 +09005551 testApexError(t, "\"otherapex\" is not a valid module name", `
5552 apex {
5553 name: "myapex",
5554 key: "myapex.key",
5555 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005556 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005557 }
5558
5559 apex_key {
5560 name: "myapex.key",
5561 public_key: "testkey.avbpubkey",
5562 private_key: "testkey.pem",
5563 }
5564
5565 cc_library {
5566 name: "libfoo",
5567 stl: "none",
5568 system_shared_libs: [],
5569 apex_available: ["otherapex"],
5570 }`)
5571
Paul Duffine52e66f2020-03-30 17:54:29 +01005572 testApex(t, `
Jiyong Park127b40b2019-09-30 16:04:35 +09005573 apex {
5574 name: "myapex",
5575 key: "myapex.key",
5576 native_shared_libs: ["libfoo", "libbar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005577 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005578 }
5579
5580 apex_key {
5581 name: "myapex.key",
5582 public_key: "testkey.avbpubkey",
5583 private_key: "testkey.pem",
5584 }
5585
5586 cc_library {
5587 name: "libfoo",
5588 stl: "none",
5589 system_shared_libs: [],
Jiyong Park323a4c32020-03-01 17:29:06 +09005590 runtime_libs: ["libbaz"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005591 apex_available: ["myapex"],
5592 }
5593
5594 cc_library {
5595 name: "libbar",
5596 stl: "none",
5597 system_shared_libs: [],
5598 apex_available: ["//apex_available:anyapex"],
Jiyong Park323a4c32020-03-01 17:29:06 +09005599 }
5600
5601 cc_library {
5602 name: "libbaz",
5603 stl: "none",
5604 system_shared_libs: [],
5605 stubs: {
5606 versions: ["10", "20", "30"],
5607 },
Jiyong Park127b40b2019-09-30 16:04:35 +09005608 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01005609}
Jiyong Park127b40b2019-09-30 16:04:35 +09005610
Jiyong Park89e850a2020-04-07 16:37:39 +09005611func TestApexAvailable_CheckForPlatform(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005612 ctx := testApex(t, `
Jiyong Park127b40b2019-09-30 16:04:35 +09005613 apex {
5614 name: "myapex",
5615 key: "myapex.key",
Jiyong Park89e850a2020-04-07 16:37:39 +09005616 native_shared_libs: ["libbar", "libbaz"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005617 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005618 }
5619
5620 apex_key {
5621 name: "myapex.key",
5622 public_key: "testkey.avbpubkey",
5623 private_key: "testkey.pem",
5624 }
5625
5626 cc_library {
5627 name: "libfoo",
5628 stl: "none",
5629 system_shared_libs: [],
Jiyong Park89e850a2020-04-07 16:37:39 +09005630 shared_libs: ["libbar"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005631 apex_available: ["//apex_available:platform"],
Jiyong Park89e850a2020-04-07 16:37:39 +09005632 }
5633
5634 cc_library {
5635 name: "libfoo2",
5636 stl: "none",
5637 system_shared_libs: [],
5638 shared_libs: ["libbaz"],
5639 apex_available: ["//apex_available:platform"],
5640 }
5641
5642 cc_library {
5643 name: "libbar",
5644 stl: "none",
5645 system_shared_libs: [],
5646 apex_available: ["myapex"],
5647 }
5648
5649 cc_library {
5650 name: "libbaz",
5651 stl: "none",
5652 system_shared_libs: [],
5653 apex_available: ["myapex"],
5654 stubs: {
5655 versions: ["1"],
5656 },
Jiyong Park127b40b2019-09-30 16:04:35 +09005657 }`)
5658
Jiyong Park89e850a2020-04-07 16:37:39 +09005659 // libfoo shouldn't be available to platform even though it has "//apex_available:platform",
5660 // because it depends on libbar which isn't available to platform
5661 libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
5662 if libfoo.NotAvailableForPlatform() != true {
5663 t.Errorf("%q shouldn't be available to platform", libfoo.String())
5664 }
5665
5666 // libfoo2 however can be available to platform because it depends on libbaz which provides
5667 // stubs
5668 libfoo2 := ctx.ModuleForTests("libfoo2", "android_arm64_armv8-a_shared").Module().(*cc.Module)
5669 if libfoo2.NotAvailableForPlatform() == true {
5670 t.Errorf("%q should be available to platform", libfoo2.String())
5671 }
Paul Duffine52e66f2020-03-30 17:54:29 +01005672}
Jiyong Parka90ca002019-10-07 15:47:24 +09005673
Paul Duffine52e66f2020-03-30 17:54:29 +01005674func TestApexAvailable_CreatedForApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005675 ctx := testApex(t, `
Jiyong Parka90ca002019-10-07 15:47:24 +09005676 apex {
5677 name: "myapex",
5678 key: "myapex.key",
5679 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005680 updatable: false,
Jiyong Parka90ca002019-10-07 15:47:24 +09005681 }
5682
5683 apex_key {
5684 name: "myapex.key",
5685 public_key: "testkey.avbpubkey",
5686 private_key: "testkey.pem",
5687 }
5688
5689 cc_library {
5690 name: "libfoo",
5691 stl: "none",
5692 system_shared_libs: [],
5693 apex_available: ["myapex"],
5694 static: {
5695 apex_available: ["//apex_available:platform"],
5696 },
5697 }`)
5698
Jiyong Park89e850a2020-04-07 16:37:39 +09005699 libfooShared := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
5700 if libfooShared.NotAvailableForPlatform() != true {
5701 t.Errorf("%q shouldn't be available to platform", libfooShared.String())
5702 }
5703 libfooStatic := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_static").Module().(*cc.Module)
5704 if libfooStatic.NotAvailableForPlatform() != false {
5705 t.Errorf("%q should be available to platform", libfooStatic.String())
5706 }
Jiyong Park127b40b2019-09-30 16:04:35 +09005707}
5708
Jiyong Park5d790c32019-11-15 18:40:32 +09005709func TestOverrideApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005710 ctx := testApex(t, `
Jiyong Park5d790c32019-11-15 18:40:32 +09005711 apex {
5712 name: "myapex",
5713 key: "myapex.key",
5714 apps: ["app"],
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08005715 overrides: ["oldapex"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005716 updatable: false,
Jiyong Park5d790c32019-11-15 18:40:32 +09005717 }
5718
5719 override_apex {
5720 name: "override_myapex",
5721 base: "myapex",
5722 apps: ["override_app"],
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08005723 overrides: ["unknownapex"],
Baligh Uddin004d7172020-02-19 21:29:28 -08005724 logging_parent: "com.foo.bar",
Baligh Uddin5b57dba2020-03-15 13:01:05 -07005725 package_name: "test.overridden.package",
Jaewoong Jung4cfdf7d2021-04-20 16:21:24 -07005726 key: "mynewapex.key",
5727 certificate: ":myapex.certificate",
Jiyong Park5d790c32019-11-15 18:40:32 +09005728 }
5729
5730 apex_key {
5731 name: "myapex.key",
5732 public_key: "testkey.avbpubkey",
5733 private_key: "testkey.pem",
5734 }
5735
Jaewoong Jung4cfdf7d2021-04-20 16:21:24 -07005736 apex_key {
5737 name: "mynewapex.key",
5738 public_key: "testkey2.avbpubkey",
5739 private_key: "testkey2.pem",
5740 }
5741
5742 android_app_certificate {
5743 name: "myapex.certificate",
5744 certificate: "testkey",
5745 }
5746
Jiyong Park5d790c32019-11-15 18:40:32 +09005747 android_app {
5748 name: "app",
5749 srcs: ["foo/bar/MyClass.java"],
5750 package_name: "foo",
5751 sdk_version: "none",
5752 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005753 apex_available: [ "myapex" ],
Jiyong Park5d790c32019-11-15 18:40:32 +09005754 }
5755
5756 override_android_app {
5757 name: "override_app",
5758 base: "app",
5759 package_name: "bar",
5760 }
Jiyong Park20bacab2020-03-03 11:45:41 +09005761 `, withManifestPackageNameOverrides([]string{"myapex:com.android.myapex"}))
Jiyong Park5d790c32019-11-15 18:40:32 +09005762
Jiyong Park317645e2019-12-05 13:20:58 +09005763 originalVariant := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(android.OverridableModule)
5764 overriddenVariant := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Module().(android.OverridableModule)
5765 if originalVariant.GetOverriddenBy() != "" {
5766 t.Errorf("GetOverriddenBy should be empty, but was %q", originalVariant.GetOverriddenBy())
5767 }
5768 if overriddenVariant.GetOverriddenBy() != "override_myapex" {
5769 t.Errorf("GetOverriddenBy should be \"override_myapex\", but was %q", overriddenVariant.GetOverriddenBy())
5770 }
5771
Jiyong Park5d790c32019-11-15 18:40:32 +09005772 module := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image")
5773 apexRule := module.Rule("apexRule")
5774 copyCmds := apexRule.Args["copy_commands"]
5775
5776 ensureNotContains(t, copyCmds, "image.apex/app/app/app.apk")
Jooyung Han39ee1192020-03-23 20:21:11 +09005777 ensureContains(t, copyCmds, "image.apex/app/override_app/override_app.apk")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005778
5779 apexBundle := module.Module().(*apexBundle)
5780 name := apexBundle.Name()
5781 if name != "override_myapex" {
5782 t.Errorf("name should be \"override_myapex\", but was %q", name)
5783 }
5784
Baligh Uddin004d7172020-02-19 21:29:28 -08005785 if apexBundle.overridableProperties.Logging_parent != "com.foo.bar" {
5786 t.Errorf("override_myapex should have logging parent (com.foo.bar), but was %q.", apexBundle.overridableProperties.Logging_parent)
5787 }
5788
Jiyong Park20bacab2020-03-03 11:45:41 +09005789 optFlags := apexRule.Args["opt_flags"]
Baligh Uddin5b57dba2020-03-15 13:01:05 -07005790 ensureContains(t, optFlags, "--override_apk_package_name test.overridden.package")
Jaewoong Jung4cfdf7d2021-04-20 16:21:24 -07005791 ensureContains(t, optFlags, "--pubkey testkey2.avbpubkey")
5792
5793 signApkRule := module.Rule("signapk")
5794 ensureEquals(t, signApkRule.Args["certificates"], "testkey.x509.pem testkey.pk8")
Jiyong Park20bacab2020-03-03 11:45:41 +09005795
Colin Crossaa255532020-07-03 13:18:24 -07005796 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005797 var builder strings.Builder
5798 data.Custom(&builder, name, "TARGET_", "", data)
5799 androidMk := builder.String()
Jiyong Parkf653b052019-11-18 15:39:01 +09005800 ensureContains(t, androidMk, "LOCAL_MODULE := override_app.override_myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005801 ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.override_myapex")
5802 ensureContains(t, androidMk, "LOCAL_MODULE_STEM := override_myapex.apex")
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08005803 ensureContains(t, androidMk, "LOCAL_OVERRIDES_MODULES := unknownapex myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005804 ensureNotContains(t, androidMk, "LOCAL_MODULE := app.myapex")
Jiyong Parkf653b052019-11-18 15:39:01 +09005805 ensureNotContains(t, androidMk, "LOCAL_MODULE := override_app.myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005806 ensureNotContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex")
5807 ensureNotContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.apex")
Jiyong Park5d790c32019-11-15 18:40:32 +09005808}
5809
Jooyung Han214bf372019-11-12 13:03:50 +09005810func TestLegacyAndroid10Support(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005811 ctx := testApex(t, `
Jooyung Han214bf372019-11-12 13:03:50 +09005812 apex {
5813 name: "myapex",
5814 key: "myapex.key",
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005815 native_shared_libs: ["mylib"],
Jooyung Han5417f772020-03-12 18:37:20 +09005816 min_sdk_version: "29",
Jooyung Han214bf372019-11-12 13:03:50 +09005817 }
5818
5819 apex_key {
5820 name: "myapex.key",
5821 public_key: "testkey.avbpubkey",
5822 private_key: "testkey.pem",
5823 }
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005824
5825 cc_library {
5826 name: "mylib",
5827 srcs: ["mylib.cpp"],
5828 stl: "libc++",
5829 system_shared_libs: [],
5830 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09005831 min_sdk_version: "29",
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005832 }
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005833 `, withUnbundledBuild)
Jooyung Han214bf372019-11-12 13:03:50 +09005834
5835 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
5836 args := module.Rule("apexRule").Args
5837 ensureContains(t, args["opt_flags"], "--manifest_json "+module.Output("apex_manifest.json").Output.String())
Dario Frenie3546902020-01-14 23:50:25 +00005838 ensureNotContains(t, args["opt_flags"], "--no_hashtree")
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005839
5840 // The copies of the libraries in the apex should have one more dependency than
5841 // the ones outside the apex, namely the unwinder. Ideally we should check
5842 // the dependency names directly here but for some reason the names are blank in
5843 // this test.
5844 for _, lib := range []string{"libc++", "mylib"} {
Colin Crossaede88c2020-08-11 12:17:01 -07005845 apexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared_apex29").Rule("ld").Implicits
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005846 nonApexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared").Rule("ld").Implicits
5847 if len(apexImplicits) != len(nonApexImplicits)+1 {
5848 t.Errorf("%q missing unwinder dep", lib)
5849 }
5850 }
Jooyung Han214bf372019-11-12 13:03:50 +09005851}
5852
Paul Duffine05480a2021-03-08 15:07:14 +00005853var filesForSdkLibrary = android.MockFS{
Paul Duffin9b879592020-05-26 13:21:35 +01005854 "api/current.txt": nil,
5855 "api/removed.txt": nil,
5856 "api/system-current.txt": nil,
5857 "api/system-removed.txt": nil,
5858 "api/test-current.txt": nil,
5859 "api/test-removed.txt": nil,
Paul Duffineedc5d52020-06-12 17:46:39 +01005860
Anton Hanssondff2c782020-12-21 17:10:01 +00005861 "100/public/api/foo.txt": nil,
5862 "100/public/api/foo-removed.txt": nil,
5863 "100/system/api/foo.txt": nil,
5864 "100/system/api/foo-removed.txt": nil,
5865
Paul Duffineedc5d52020-06-12 17:46:39 +01005866 // For java_sdk_library_import
5867 "a.jar": nil,
Paul Duffin9b879592020-05-26 13:21:35 +01005868}
5869
Jooyung Han58f26ab2019-12-18 15:34:32 +09005870func TestJavaSDKLibrary(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005871 ctx := testApex(t, `
Jooyung Han58f26ab2019-12-18 15:34:32 +09005872 apex {
5873 name: "myapex",
5874 key: "myapex.key",
5875 java_libs: ["foo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005876 updatable: false,
Jooyung Han58f26ab2019-12-18 15:34:32 +09005877 }
5878
5879 apex_key {
5880 name: "myapex.key",
5881 public_key: "testkey.avbpubkey",
5882 private_key: "testkey.pem",
5883 }
5884
5885 java_sdk_library {
5886 name: "foo",
5887 srcs: ["a.java"],
5888 api_packages: ["foo"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005889 apex_available: [ "myapex" ],
Jooyung Han58f26ab2019-12-18 15:34:32 +09005890 }
Anton Hanssondff2c782020-12-21 17:10:01 +00005891
5892 prebuilt_apis {
5893 name: "sdk",
5894 api_dirs: ["100"],
5895 }
Paul Duffin9b879592020-05-26 13:21:35 +01005896 `, withFiles(filesForSdkLibrary))
Jooyung Han58f26ab2019-12-18 15:34:32 +09005897
5898 // java_sdk_library installs both impl jar and permission XML
Jooyung Hana57af4a2020-01-23 05:36:59 +00005899 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Han58f26ab2019-12-18 15:34:32 +09005900 "javalib/foo.jar",
5901 "etc/permissions/foo.xml",
5902 })
5903 // Permission XML should point to the activated path of impl jar of java_sdk_library
Jiyong Parke3833882020-02-17 17:28:10 +09005904 sdkLibrary := ctx.ModuleForTests("foo.xml", "android_common_myapex").Rule("java_sdk_xml")
5905 ensureContains(t, sdkLibrary.RuleParams.Command, `<library name=\"foo\" file=\"/apex/myapex/javalib/foo.jar\"`)
Jooyung Han58f26ab2019-12-18 15:34:32 +09005906}
5907
Paul Duffin9b879592020-05-26 13:21:35 +01005908func TestJavaSDKLibrary_WithinApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005909 ctx := testApex(t, `
Paul Duffin9b879592020-05-26 13:21:35 +01005910 apex {
5911 name: "myapex",
5912 key: "myapex.key",
5913 java_libs: ["foo", "bar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005914 updatable: false,
Paul Duffin9b879592020-05-26 13:21:35 +01005915 }
5916
5917 apex_key {
5918 name: "myapex.key",
5919 public_key: "testkey.avbpubkey",
5920 private_key: "testkey.pem",
5921 }
5922
5923 java_sdk_library {
5924 name: "foo",
5925 srcs: ["a.java"],
5926 api_packages: ["foo"],
5927 apex_available: ["myapex"],
5928 sdk_version: "none",
5929 system_modules: "none",
5930 }
5931
5932 java_library {
5933 name: "bar",
5934 srcs: ["a.java"],
5935 libs: ["foo"],
5936 apex_available: ["myapex"],
5937 sdk_version: "none",
5938 system_modules: "none",
5939 }
Anton Hanssondff2c782020-12-21 17:10:01 +00005940
5941 prebuilt_apis {
5942 name: "sdk",
5943 api_dirs: ["100"],
5944 }
Paul Duffin9b879592020-05-26 13:21:35 +01005945 `, withFiles(filesForSdkLibrary))
5946
5947 // java_sdk_library installs both impl jar and permission XML
5948 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
5949 "javalib/bar.jar",
5950 "javalib/foo.jar",
5951 "etc/permissions/foo.xml",
5952 })
5953
5954 // The bar library should depend on the implementation jar.
5955 barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
Paul Duffincf8d7db2021-03-29 00:29:53 +01005956 if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Paul Duffin9b879592020-05-26 13:21:35 +01005957 t.Errorf("expected %q, found %#q", expected, actual)
5958 }
5959}
5960
5961func TestJavaSDKLibrary_CrossBoundary(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005962 ctx := testApex(t, `
Paul Duffin9b879592020-05-26 13:21:35 +01005963 apex {
5964 name: "myapex",
5965 key: "myapex.key",
5966 java_libs: ["foo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005967 updatable: false,
Paul Duffin9b879592020-05-26 13:21:35 +01005968 }
5969
5970 apex_key {
5971 name: "myapex.key",
5972 public_key: "testkey.avbpubkey",
5973 private_key: "testkey.pem",
5974 }
5975
5976 java_sdk_library {
5977 name: "foo",
5978 srcs: ["a.java"],
5979 api_packages: ["foo"],
5980 apex_available: ["myapex"],
5981 sdk_version: "none",
5982 system_modules: "none",
5983 }
5984
5985 java_library {
5986 name: "bar",
5987 srcs: ["a.java"],
5988 libs: ["foo"],
5989 sdk_version: "none",
5990 system_modules: "none",
5991 }
Anton Hanssondff2c782020-12-21 17:10:01 +00005992
5993 prebuilt_apis {
5994 name: "sdk",
5995 api_dirs: ["100"],
5996 }
Paul Duffin9b879592020-05-26 13:21:35 +01005997 `, withFiles(filesForSdkLibrary))
5998
5999 // java_sdk_library installs both impl jar and permission XML
6000 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
6001 "javalib/foo.jar",
6002 "etc/permissions/foo.xml",
6003 })
6004
6005 // The bar library should depend on the stubs jar.
6006 barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
Paul Duffincf8d7db2021-03-29 00:29:53 +01006007 if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Paul Duffin9b879592020-05-26 13:21:35 +01006008 t.Errorf("expected %q, found %#q", expected, actual)
6009 }
6010}
6011
Paul Duffineedc5d52020-06-12 17:46:39 +01006012func TestJavaSDKLibrary_ImportPreferred(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006013 ctx := testApex(t, `
Anton Hanssondff2c782020-12-21 17:10:01 +00006014 prebuilt_apis {
6015 name: "sdk",
6016 api_dirs: ["100"],
6017 }`,
Paul Duffineedc5d52020-06-12 17:46:39 +01006018 withFiles(map[string][]byte{
6019 "apex/a.java": nil,
6020 "apex/apex_manifest.json": nil,
6021 "apex/Android.bp": []byte(`
6022 package {
6023 default_visibility: ["//visibility:private"],
6024 }
6025
6026 apex {
6027 name: "myapex",
6028 key: "myapex.key",
6029 java_libs: ["foo", "bar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006030 updatable: false,
Paul Duffineedc5d52020-06-12 17:46:39 +01006031 }
6032
6033 apex_key {
6034 name: "myapex.key",
6035 public_key: "testkey.avbpubkey",
6036 private_key: "testkey.pem",
6037 }
6038
6039 java_library {
6040 name: "bar",
6041 srcs: ["a.java"],
6042 libs: ["foo"],
6043 apex_available: ["myapex"],
6044 sdk_version: "none",
6045 system_modules: "none",
6046 }
6047`),
6048 "source/a.java": nil,
6049 "source/api/current.txt": nil,
6050 "source/api/removed.txt": nil,
6051 "source/Android.bp": []byte(`
6052 package {
6053 default_visibility: ["//visibility:private"],
6054 }
6055
6056 java_sdk_library {
6057 name: "foo",
6058 visibility: ["//apex"],
6059 srcs: ["a.java"],
6060 api_packages: ["foo"],
6061 apex_available: ["myapex"],
6062 sdk_version: "none",
6063 system_modules: "none",
6064 public: {
6065 enabled: true,
6066 },
6067 }
6068`),
6069 "prebuilt/a.jar": nil,
6070 "prebuilt/Android.bp": []byte(`
6071 package {
6072 default_visibility: ["//visibility:private"],
6073 }
6074
6075 java_sdk_library_import {
6076 name: "foo",
6077 visibility: ["//apex", "//source"],
6078 apex_available: ["myapex"],
6079 prefer: true,
6080 public: {
6081 jars: ["a.jar"],
6082 },
6083 }
6084`),
Anton Hanssondff2c782020-12-21 17:10:01 +00006085 }), withFiles(filesForSdkLibrary),
Paul Duffineedc5d52020-06-12 17:46:39 +01006086 )
6087
6088 // java_sdk_library installs both impl jar and permission XML
6089 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
6090 "javalib/bar.jar",
6091 "javalib/foo.jar",
6092 "etc/permissions/foo.xml",
6093 })
6094
6095 // The bar library should depend on the implementation jar.
6096 barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
Paul Duffincf8d7db2021-03-29 00:29:53 +01006097 if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.impl\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Paul Duffineedc5d52020-06-12 17:46:39 +01006098 t.Errorf("expected %q, found %#q", expected, actual)
6099 }
6100}
6101
6102func TestJavaSDKLibrary_ImportOnly(t *testing.T) {
6103 testApexError(t, `java_libs: "foo" is not configured to be compiled into dex`, `
6104 apex {
6105 name: "myapex",
6106 key: "myapex.key",
6107 java_libs: ["foo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006108 updatable: false,
Paul Duffineedc5d52020-06-12 17:46:39 +01006109 }
6110
6111 apex_key {
6112 name: "myapex.key",
6113 public_key: "testkey.avbpubkey",
6114 private_key: "testkey.pem",
6115 }
6116
6117 java_sdk_library_import {
6118 name: "foo",
6119 apex_available: ["myapex"],
6120 prefer: true,
6121 public: {
6122 jars: ["a.jar"],
6123 },
6124 }
6125
6126 `, withFiles(filesForSdkLibrary))
6127}
6128
atrost6e126252020-01-27 17:01:16 +00006129func TestCompatConfig(t *testing.T) {
Paul Duffin284165a2021-03-29 01:50:31 +01006130 result := android.GroupFixturePreparers(
6131 prepareForApexTest,
6132 java.PrepareForTestWithPlatformCompatConfig,
6133 ).RunTestWithBp(t, `
atrost6e126252020-01-27 17:01:16 +00006134 apex {
6135 name: "myapex",
6136 key: "myapex.key",
Paul Duffin3abc1742021-03-15 19:32:23 +00006137 compat_configs: ["myjar-platform-compat-config"],
atrost6e126252020-01-27 17:01:16 +00006138 java_libs: ["myjar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006139 updatable: false,
atrost6e126252020-01-27 17:01:16 +00006140 }
6141
6142 apex_key {
6143 name: "myapex.key",
6144 public_key: "testkey.avbpubkey",
6145 private_key: "testkey.pem",
6146 }
6147
6148 platform_compat_config {
6149 name: "myjar-platform-compat-config",
6150 src: ":myjar",
6151 }
6152
6153 java_library {
6154 name: "myjar",
6155 srcs: ["foo/bar/MyClass.java"],
6156 sdk_version: "none",
6157 system_modules: "none",
atrost6e126252020-01-27 17:01:16 +00006158 apex_available: [ "myapex" ],
6159 }
Paul Duffin1b29e002021-03-16 15:06:54 +00006160
6161 // Make sure that a preferred prebuilt does not affect the apex contents.
6162 prebuilt_platform_compat_config {
6163 name: "myjar-platform-compat-config",
6164 metadata: "compat-config/metadata.xml",
6165 prefer: true,
6166 }
atrost6e126252020-01-27 17:01:16 +00006167 `)
Paul Duffina369c7b2021-03-09 03:08:05 +00006168 ctx := result.TestContext
atrost6e126252020-01-27 17:01:16 +00006169 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
6170 "etc/compatconfig/myjar-platform-compat-config.xml",
6171 "javalib/myjar.jar",
6172 })
6173}
6174
Jiyong Park479321d2019-12-16 11:47:12 +09006175func TestRejectNonInstallableJavaLibrary(t *testing.T) {
6176 testApexError(t, `"myjar" is not configured to be compiled into dex`, `
6177 apex {
6178 name: "myapex",
6179 key: "myapex.key",
6180 java_libs: ["myjar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006181 updatable: false,
Jiyong Park479321d2019-12-16 11:47:12 +09006182 }
6183
6184 apex_key {
6185 name: "myapex.key",
6186 public_key: "testkey.avbpubkey",
6187 private_key: "testkey.pem",
6188 }
6189
6190 java_library {
6191 name: "myjar",
6192 srcs: ["foo/bar/MyClass.java"],
6193 sdk_version: "none",
6194 system_modules: "none",
Jiyong Park6b21c7d2020-02-11 09:16:01 +09006195 compile_dex: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09006196 apex_available: ["myapex"],
Jiyong Park479321d2019-12-16 11:47:12 +09006197 }
6198 `)
6199}
6200
Jiyong Park7afd1072019-12-30 16:56:33 +09006201func TestCarryRequiredModuleNames(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006202 ctx := testApex(t, `
Jiyong Park7afd1072019-12-30 16:56:33 +09006203 apex {
6204 name: "myapex",
6205 key: "myapex.key",
6206 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006207 updatable: false,
Jiyong Park7afd1072019-12-30 16:56:33 +09006208 }
6209
6210 apex_key {
6211 name: "myapex.key",
6212 public_key: "testkey.avbpubkey",
6213 private_key: "testkey.pem",
6214 }
6215
6216 cc_library {
6217 name: "mylib",
6218 srcs: ["mylib.cpp"],
6219 system_shared_libs: [],
6220 stl: "none",
6221 required: ["a", "b"],
6222 host_required: ["c", "d"],
6223 target_required: ["e", "f"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00006224 apex_available: [ "myapex" ],
Jiyong Park7afd1072019-12-30 16:56:33 +09006225 }
6226 `)
6227
6228 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07006229 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jiyong Park7afd1072019-12-30 16:56:33 +09006230 name := apexBundle.BaseModuleName()
6231 prefix := "TARGET_"
6232 var builder strings.Builder
6233 data.Custom(&builder, name, prefix, "", data)
6234 androidMk := builder.String()
6235 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += a b\n")
6236 ensureContains(t, androidMk, "LOCAL_HOST_REQUIRED_MODULES += c d\n")
6237 ensureContains(t, androidMk, "LOCAL_TARGET_REQUIRED_MODULES += e f\n")
6238}
6239
Jiyong Park7cd10e32020-01-14 09:22:18 +09006240func TestSymlinksFromApexToSystem(t *testing.T) {
6241 bp := `
6242 apex {
6243 name: "myapex",
6244 key: "myapex.key",
6245 native_shared_libs: ["mylib"],
6246 java_libs: ["myjar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006247 updatable: false,
Jiyong Park7cd10e32020-01-14 09:22:18 +09006248 }
6249
Jiyong Park9d677202020-02-19 16:29:35 +09006250 apex {
6251 name: "myapex.updatable",
6252 key: "myapex.key",
6253 native_shared_libs: ["mylib"],
6254 java_libs: ["myjar"],
6255 updatable: true,
Jooyung Han548640b2020-04-27 12:10:30 +09006256 min_sdk_version: "current",
Jiyong Park9d677202020-02-19 16:29:35 +09006257 }
6258
Jiyong Park7cd10e32020-01-14 09:22:18 +09006259 apex_key {
6260 name: "myapex.key",
6261 public_key: "testkey.avbpubkey",
6262 private_key: "testkey.pem",
6263 }
6264
6265 cc_library {
6266 name: "mylib",
6267 srcs: ["mylib.cpp"],
6268 shared_libs: ["myotherlib"],
6269 system_shared_libs: [],
6270 stl: "none",
6271 apex_available: [
6272 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006273 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006274 "//apex_available:platform",
6275 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006276 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006277 }
6278
6279 cc_library {
6280 name: "myotherlib",
6281 srcs: ["mylib.cpp"],
6282 system_shared_libs: [],
6283 stl: "none",
6284 apex_available: [
6285 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006286 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006287 "//apex_available:platform",
6288 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006289 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006290 }
6291
6292 java_library {
6293 name: "myjar",
6294 srcs: ["foo/bar/MyClass.java"],
6295 sdk_version: "none",
6296 system_modules: "none",
6297 libs: ["myotherjar"],
Jiyong Park7cd10e32020-01-14 09:22:18 +09006298 apex_available: [
6299 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006300 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006301 "//apex_available:platform",
6302 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006303 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006304 }
6305
6306 java_library {
6307 name: "myotherjar",
6308 srcs: ["foo/bar/MyClass.java"],
6309 sdk_version: "none",
6310 system_modules: "none",
6311 apex_available: [
6312 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006313 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006314 "//apex_available:platform",
6315 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006316 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006317 }
6318 `
6319
6320 ensureRealfileExists := func(t *testing.T, files []fileInApex, file string) {
6321 for _, f := range files {
6322 if f.path == file {
6323 if f.isLink {
6324 t.Errorf("%q is not a real file", file)
6325 }
6326 return
6327 }
6328 }
6329 t.Errorf("%q is not found", file)
6330 }
6331
6332 ensureSymlinkExists := func(t *testing.T, files []fileInApex, file string) {
6333 for _, f := range files {
6334 if f.path == file {
6335 if !f.isLink {
6336 t.Errorf("%q is not a symlink", file)
6337 }
6338 return
6339 }
6340 }
6341 t.Errorf("%q is not found", file)
6342 }
6343
Jiyong Park9d677202020-02-19 16:29:35 +09006344 // For unbundled build, symlink shouldn't exist regardless of whether an APEX
6345 // is updatable or not
Colin Cross1c460562021-02-16 17:55:47 -08006346 ctx := testApex(t, bp, withUnbundledBuild)
Jooyung Hana57af4a2020-01-23 05:36:59 +00006347 files := getFiles(t, ctx, "myapex", "android_common_myapex_image")
Jiyong Park7cd10e32020-01-14 09:22:18 +09006348 ensureRealfileExists(t, files, "javalib/myjar.jar")
6349 ensureRealfileExists(t, files, "lib64/mylib.so")
6350 ensureRealfileExists(t, files, "lib64/myotherlib.so")
6351
Jiyong Park9d677202020-02-19 16:29:35 +09006352 files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
6353 ensureRealfileExists(t, files, "javalib/myjar.jar")
6354 ensureRealfileExists(t, files, "lib64/mylib.so")
6355 ensureRealfileExists(t, files, "lib64/myotherlib.so")
6356
6357 // For bundled build, symlink to the system for the non-updatable APEXes only
Colin Cross1c460562021-02-16 17:55:47 -08006358 ctx = testApex(t, bp)
Jooyung Hana57af4a2020-01-23 05:36:59 +00006359 files = getFiles(t, ctx, "myapex", "android_common_myapex_image")
Jiyong Park7cd10e32020-01-14 09:22:18 +09006360 ensureRealfileExists(t, files, "javalib/myjar.jar")
6361 ensureRealfileExists(t, files, "lib64/mylib.so")
6362 ensureSymlinkExists(t, files, "lib64/myotherlib.so") // this is symlink
Jiyong Park9d677202020-02-19 16:29:35 +09006363
6364 files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
6365 ensureRealfileExists(t, files, "javalib/myjar.jar")
6366 ensureRealfileExists(t, files, "lib64/mylib.so")
6367 ensureRealfileExists(t, files, "lib64/myotherlib.so") // this is a real file
Jiyong Park7cd10e32020-01-14 09:22:18 +09006368}
6369
Yo Chiange8128052020-07-23 20:09:18 +08006370func TestSymlinksFromApexToSystemRequiredModuleNames(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006371 ctx := testApex(t, `
Yo Chiange8128052020-07-23 20:09:18 +08006372 apex {
6373 name: "myapex",
6374 key: "myapex.key",
6375 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006376 updatable: false,
Yo Chiange8128052020-07-23 20:09:18 +08006377 }
6378
6379 apex_key {
6380 name: "myapex.key",
6381 public_key: "testkey.avbpubkey",
6382 private_key: "testkey.pem",
6383 }
6384
6385 cc_library_shared {
6386 name: "mylib",
6387 srcs: ["mylib.cpp"],
6388 shared_libs: ["myotherlib"],
6389 system_shared_libs: [],
6390 stl: "none",
6391 apex_available: [
6392 "myapex",
6393 "//apex_available:platform",
6394 ],
6395 }
6396
6397 cc_prebuilt_library_shared {
6398 name: "myotherlib",
6399 srcs: ["prebuilt.so"],
6400 system_shared_libs: [],
6401 stl: "none",
6402 apex_available: [
6403 "myapex",
6404 "//apex_available:platform",
6405 ],
6406 }
6407 `)
6408
6409 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07006410 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Yo Chiange8128052020-07-23 20:09:18 +08006411 var builder strings.Builder
6412 data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
6413 androidMk := builder.String()
6414 // `myotherlib` is added to `myapex` as symlink
6415 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
6416 ensureNotContains(t, androidMk, "LOCAL_MODULE := prebuilt_myotherlib.myapex\n")
6417 ensureNotContains(t, androidMk, "LOCAL_MODULE := myotherlib.myapex\n")
6418 // `myapex` should have `myotherlib` in its required line, not `prebuilt_myotherlib`
Jiyong Park57621b22021-01-20 20:33:11 +09006419 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += mylib.myapex:64 myotherlib:64 apex_manifest.pb.myapex apex_pubkey.myapex\n")
Yo Chiange8128052020-07-23 20:09:18 +08006420}
6421
Jooyung Han643adc42020-02-27 13:50:06 +09006422func TestApexWithJniLibs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006423 ctx := testApex(t, `
Jooyung Han643adc42020-02-27 13:50:06 +09006424 apex {
6425 name: "myapex",
6426 key: "myapex.key",
6427 jni_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006428 updatable: false,
Jooyung Han643adc42020-02-27 13:50:06 +09006429 }
6430
6431 apex_key {
6432 name: "myapex.key",
6433 public_key: "testkey.avbpubkey",
6434 private_key: "testkey.pem",
6435 }
6436
6437 cc_library {
6438 name: "mylib",
6439 srcs: ["mylib.cpp"],
6440 shared_libs: ["mylib2"],
6441 system_shared_libs: [],
6442 stl: "none",
6443 apex_available: [ "myapex" ],
6444 }
6445
6446 cc_library {
6447 name: "mylib2",
6448 srcs: ["mylib.cpp"],
6449 system_shared_libs: [],
6450 stl: "none",
6451 apex_available: [ "myapex" ],
6452 }
6453 `)
6454
6455 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
6456 // Notice mylib2.so (transitive dep) is not added as a jni_lib
6457 ensureEquals(t, rule.Args["opt"], "-a jniLibs mylib.so")
6458 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
6459 "lib64/mylib.so",
6460 "lib64/mylib2.so",
6461 })
6462}
6463
Jooyung Han49f67012020-04-17 13:43:10 +09006464func TestApexMutatorsDontRunIfDisabled(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006465 ctx := testApex(t, `
Jooyung Han49f67012020-04-17 13:43:10 +09006466 apex {
6467 name: "myapex",
6468 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006469 updatable: false,
Jooyung Han49f67012020-04-17 13:43:10 +09006470 }
6471 apex_key {
6472 name: "myapex.key",
6473 public_key: "testkey.avbpubkey",
6474 private_key: "testkey.pem",
6475 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00006476 `,
6477 android.FixtureModifyConfig(func(config android.Config) {
6478 delete(config.Targets, android.Android)
6479 config.AndroidCommonTarget = android.Target{}
6480 }),
6481 )
Jooyung Han49f67012020-04-17 13:43:10 +09006482
6483 if expected, got := []string{""}, ctx.ModuleVariantsForTests("myapex"); !reflect.DeepEqual(expected, got) {
6484 t.Errorf("Expected variants: %v, but got: %v", expected, got)
6485 }
6486}
6487
Jiyong Parkbd159612020-02-28 15:22:21 +09006488func TestAppBundle(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006489 ctx := testApex(t, `
Jiyong Parkbd159612020-02-28 15:22:21 +09006490 apex {
6491 name: "myapex",
6492 key: "myapex.key",
6493 apps: ["AppFoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006494 updatable: false,
Jiyong Parkbd159612020-02-28 15:22:21 +09006495 }
6496
6497 apex_key {
6498 name: "myapex.key",
6499 public_key: "testkey.avbpubkey",
6500 private_key: "testkey.pem",
6501 }
6502
6503 android_app {
6504 name: "AppFoo",
6505 srcs: ["foo/bar/MyClass.java"],
6506 sdk_version: "none",
6507 system_modules: "none",
6508 apex_available: [ "myapex" ],
6509 }
Jiyong Parkcfaa1642020-02-28 16:51:07 +09006510 `, withManifestPackageNameOverrides([]string{"AppFoo:com.android.foo"}))
Jiyong Parkbd159612020-02-28 15:22:21 +09006511
Colin Crosscf371cc2020-11-13 11:48:42 -08006512 bundleConfigRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("bundle_config.json")
Jiyong Parkbd159612020-02-28 15:22:21 +09006513 content := bundleConfigRule.Args["content"]
6514
6515 ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
Jiyong Parkcfaa1642020-02-28 16:51:07 +09006516 ensureContains(t, content, `"apex_config":{"apex_embedded_apk_config":[{"package_name":"com.android.foo","path":"app/AppFoo/AppFoo.apk"}]}`)
Jiyong Parkbd159612020-02-28 15:22:21 +09006517}
6518
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006519func TestAppSetBundle(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006520 ctx := testApex(t, `
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006521 apex {
6522 name: "myapex",
6523 key: "myapex.key",
6524 apps: ["AppSet"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006525 updatable: false,
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006526 }
6527
6528 apex_key {
6529 name: "myapex.key",
6530 public_key: "testkey.avbpubkey",
6531 private_key: "testkey.pem",
6532 }
6533
6534 android_app_set {
6535 name: "AppSet",
6536 set: "AppSet.apks",
6537 }`)
6538 mod := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Colin Crosscf371cc2020-11-13 11:48:42 -08006539 bundleConfigRule := mod.Output("bundle_config.json")
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006540 content := bundleConfigRule.Args["content"]
6541 ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
6542 s := mod.Rule("apexRule").Args["copy_commands"]
6543 copyCmds := regexp.MustCompile(" *&& *").Split(s, -1)
6544 if len(copyCmds) != 3 {
6545 t.Fatalf("Expected 3 commands, got %d in:\n%s", len(copyCmds), s)
6546 }
6547 ensureMatches(t, copyCmds[0], "^rm -rf .*/app/AppSet$")
6548 ensureMatches(t, copyCmds[1], "^mkdir -p .*/app/AppSet$")
6549 ensureMatches(t, copyCmds[2], "^unzip .*-d .*/app/AppSet .*/AppSet.zip$")
6550}
6551
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006552func TestAppSetBundlePrebuilt(t *testing.T) {
Paul Duffin24704672021-04-06 16:09:30 +01006553 bp := `
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006554 apex_set {
6555 name: "myapex",
6556 filename: "foo_v2.apex",
6557 sanitized: {
6558 none: { set: "myapex.apks", },
6559 hwaddress: { set: "myapex.hwasan.apks", },
6560 },
Paul Duffin24704672021-04-06 16:09:30 +01006561 }
6562 `
6563 ctx := testApex(t, bp, prepareForTestWithSantitizeHwaddress)
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006564
Paul Duffin24704672021-04-06 16:09:30 +01006565 // Check that the extractor produces the correct output file from the correct input file.
6566 extractorOutput := "out/soong/.intermediates/myapex.apex.extractor/android_common/extracted/myapex.hwasan.apks"
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006567
Paul Duffin24704672021-04-06 16:09:30 +01006568 m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
6569 extractedApex := m.Output(extractorOutput)
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006570
Paul Duffin24704672021-04-06 16:09:30 +01006571 android.AssertArrayString(t, "extractor input", []string{"myapex.hwasan.apks"}, extractedApex.Inputs.Strings())
6572
6573 // Ditto for the apex.
Paul Duffin6717d882021-06-15 19:09:41 +01006574 m = ctx.ModuleForTests("myapex", "android_common_myapex")
6575 copiedApex := m.Output("out/soong/.intermediates/myapex/android_common_myapex/foo_v2.apex")
Paul Duffin24704672021-04-06 16:09:30 +01006576
6577 android.AssertStringEquals(t, "myapex input", extractorOutput, copiedApex.Input.String())
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006578}
6579
Paul Duffin89f570a2021-06-16 01:42:33 +01006580func testNoUpdatableJarsInBootImage(t *testing.T, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) {
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006581 t.Helper()
6582
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006583 bp := `
6584 java_library {
6585 name: "some-updatable-apex-lib",
6586 srcs: ["a.java"],
6587 sdk_version: "current",
6588 apex_available: [
6589 "some-updatable-apex",
6590 ],
6591 }
6592
6593 java_library {
6594 name: "some-non-updatable-apex-lib",
6595 srcs: ["a.java"],
6596 apex_available: [
6597 "some-non-updatable-apex",
6598 ],
Paul Duffin89f570a2021-06-16 01:42:33 +01006599 compile_dex: true,
6600 }
6601
6602 bootclasspath_fragment {
6603 name: "some-non-updatable-fragment",
6604 contents: ["some-non-updatable-apex-lib"],
6605 apex_available: [
6606 "some-non-updatable-apex",
6607 ],
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006608 }
6609
6610 java_library {
6611 name: "some-platform-lib",
6612 srcs: ["a.java"],
6613 sdk_version: "current",
6614 installable: true,
6615 }
6616
6617 java_library {
6618 name: "some-art-lib",
6619 srcs: ["a.java"],
6620 sdk_version: "current",
6621 apex_available: [
Paul Duffind376f792021-01-26 11:59:35 +00006622 "com.android.art.debug",
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006623 ],
6624 hostdex: true,
Paul Duffine5218812021-06-07 13:28:19 +01006625 compile_dex: true,
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006626 }
6627
6628 apex {
6629 name: "some-updatable-apex",
6630 key: "some-updatable-apex.key",
6631 java_libs: ["some-updatable-apex-lib"],
6632 updatable: true,
6633 min_sdk_version: "current",
6634 }
6635
6636 apex {
6637 name: "some-non-updatable-apex",
6638 key: "some-non-updatable-apex.key",
Paul Duffin89f570a2021-06-16 01:42:33 +01006639 bootclasspath_fragments: ["some-non-updatable-fragment"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006640 updatable: false,
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006641 }
6642
6643 apex_key {
6644 name: "some-updatable-apex.key",
6645 }
6646
6647 apex_key {
6648 name: "some-non-updatable-apex.key",
6649 }
6650
6651 apex {
Paul Duffind376f792021-01-26 11:59:35 +00006652 name: "com.android.art.debug",
6653 key: "com.android.art.debug.key",
Paul Duffin89f570a2021-06-16 01:42:33 +01006654 bootclasspath_fragments: ["art-bootclasspath-fragment"],
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006655 updatable: true,
6656 min_sdk_version: "current",
6657 }
6658
Paul Duffinf23bc472021-04-27 12:42:20 +01006659 bootclasspath_fragment {
6660 name: "art-bootclasspath-fragment",
6661 image_name: "art",
6662 contents: ["some-art-lib"],
6663 apex_available: [
6664 "com.android.art.debug",
6665 ],
6666 }
6667
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006668 apex_key {
Paul Duffind376f792021-01-26 11:59:35 +00006669 name: "com.android.art.debug.key",
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006670 }
6671
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006672 filegroup {
6673 name: "some-updatable-apex-file_contexts",
6674 srcs: [
6675 "system/sepolicy/apex/some-updatable-apex-file_contexts",
6676 ],
6677 }
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01006678
6679 filegroup {
6680 name: "some-non-updatable-apex-file_contexts",
6681 srcs: [
6682 "system/sepolicy/apex/some-non-updatable-apex-file_contexts",
6683 ],
6684 }
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006685 `
Paul Duffinc3bbb962020-12-10 19:15:49 +00006686
Paul Duffin89f570a2021-06-16 01:42:33 +01006687 testDexpreoptWithApexes(t, bp, errmsg, preparer, fragments...)
Paul Duffinc3bbb962020-12-10 19:15:49 +00006688}
6689
Paul Duffin89f570a2021-06-16 01:42:33 +01006690func testDexpreoptWithApexes(t *testing.T, bp, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) *android.TestContext {
Paul Duffinc3bbb962020-12-10 19:15:49 +00006691 t.Helper()
6692
Paul Duffin55607122021-03-30 23:32:51 +01006693 fs := android.MockFS{
6694 "a.java": nil,
6695 "a.jar": nil,
6696 "apex_manifest.json": nil,
6697 "AndroidManifest.xml": nil,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00006698 "system/sepolicy/apex/myapex-file_contexts": nil,
Paul Duffind376f792021-01-26 11:59:35 +00006699 "system/sepolicy/apex/some-updatable-apex-file_contexts": nil,
6700 "system/sepolicy/apex/some-non-updatable-apex-file_contexts": nil,
6701 "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00006702 "framework/aidl/a.aidl": nil,
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006703 }
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006704
Paul Duffin55607122021-03-30 23:32:51 +01006705 errorHandler := android.FixtureExpectsNoErrors
6706 if errmsg != "" {
6707 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006708 }
Paul Duffin064b70c2020-11-02 17:32:38 +00006709
Paul Duffin55607122021-03-30 23:32:51 +01006710 result := android.GroupFixturePreparers(
6711 cc.PrepareForTestWithCcDefaultModules,
6712 java.PrepareForTestWithHiddenApiBuildComponents,
6713 java.PrepareForTestWithJavaDefaultModules,
6714 java.PrepareForTestWithJavaSdkLibraryFiles,
6715 PrepareForTestWithApexBuildComponents,
Paul Duffin60264a02021-04-12 20:02:36 +01006716 preparer,
Paul Duffin55607122021-03-30 23:32:51 +01006717 fs.AddToFixture(),
Paul Duffin89f570a2021-06-16 01:42:33 +01006718 android.FixtureModifyMockFS(func(fs android.MockFS) {
6719 if _, ok := fs["frameworks/base/boot/Android.bp"]; !ok {
6720 insert := ""
6721 for _, fragment := range fragments {
6722 insert += fmt.Sprintf("{apex: %q, module: %q},\n", *fragment.Apex, *fragment.Module)
6723 }
6724 fs["frameworks/base/boot/Android.bp"] = []byte(fmt.Sprintf(`
6725 platform_bootclasspath {
6726 name: "platform-bootclasspath",
6727 fragments: [
6728 %s
6729 ],
6730 }
6731 `, insert))
Paul Duffin8f146b92021-04-12 17:24:18 +01006732 }
Paul Duffin89f570a2021-06-16 01:42:33 +01006733 }),
Paul Duffin55607122021-03-30 23:32:51 +01006734 ).
6735 ExtendWithErrorHandler(errorHandler).
6736 RunTestWithBp(t, bp)
6737
6738 return result.TestContext
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006739}
6740
Jooyung Han548640b2020-04-27 12:10:30 +09006741func TestUpdatable_should_set_min_sdk_version(t *testing.T) {
6742 testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
6743 apex {
6744 name: "myapex",
6745 key: "myapex.key",
6746 updatable: true,
6747 }
6748
6749 apex_key {
6750 name: "myapex.key",
6751 public_key: "testkey.avbpubkey",
6752 private_key: "testkey.pem",
6753 }
6754 `)
6755}
6756
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006757func TestUpdatableDefault_should_set_min_sdk_version(t *testing.T) {
6758 testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
6759 apex {
6760 name: "myapex",
6761 key: "myapex.key",
6762 }
6763
6764 apex_key {
6765 name: "myapex.key",
6766 public_key: "testkey.avbpubkey",
6767 private_key: "testkey.pem",
6768 }
6769 `)
6770}
6771
satayevb98371c2021-06-15 16:49:50 +01006772func TestUpdatable_should_not_set_generate_classpaths_proto(t *testing.T) {
6773 testApexError(t, `"mysystemserverclasspathfragment" .* it must not set generate_classpaths_proto to false`, `
6774 apex {
6775 name: "myapex",
6776 key: "myapex.key",
6777 systemserverclasspath_fragments: [
6778 "mysystemserverclasspathfragment",
6779 ],
6780 min_sdk_version: "29",
6781 updatable: true,
6782 }
6783
6784 apex_key {
6785 name: "myapex.key",
6786 public_key: "testkey.avbpubkey",
6787 private_key: "testkey.pem",
6788 }
6789
6790 java_library {
6791 name: "foo",
6792 srcs: ["b.java"],
6793 min_sdk_version: "29",
6794 installable: true,
6795 apex_available: [
6796 "myapex",
6797 ],
6798 }
6799
6800 systemserverclasspath_fragment {
6801 name: "mysystemserverclasspathfragment",
6802 generate_classpaths_proto: false,
6803 contents: [
6804 "foo",
6805 ],
6806 apex_available: [
6807 "myapex",
6808 ],
6809 }
6810 `)
6811}
6812
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006813func TestNoUpdatableJarsInBootImage(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006814 // Set the BootJars in dexpreopt.GlobalConfig and productVariables to the same value. This can
6815 // result in an invalid configuration as it does not set the ArtApexJars and allows art apex
6816 // modules to be included in the BootJars.
6817 prepareSetBootJars := func(bootJars ...string) android.FixturePreparer {
6818 return android.GroupFixturePreparers(
6819 dexpreopt.FixtureSetBootJars(bootJars...),
6820 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
6821 variables.BootJars = android.CreateTestConfiguredJarList(bootJars)
6822 }),
6823 )
6824 }
6825
6826 // Set the ArtApexJars and BootJars in dexpreopt.GlobalConfig and productVariables all to the
6827 // same value. This can result in an invalid configuration as it allows non art apex jars to be
6828 // specified in the ArtApexJars configuration.
6829 prepareSetArtJars := func(bootJars ...string) android.FixturePreparer {
6830 return android.GroupFixturePreparers(
6831 dexpreopt.FixtureSetArtBootJars(bootJars...),
6832 dexpreopt.FixtureSetBootJars(bootJars...),
6833 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
6834 variables.BootJars = android.CreateTestConfiguredJarList(bootJars)
6835 }),
6836 )
6837 }
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006838
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006839 t.Run("updatable jar from ART apex in the ART boot image => ok", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006840 preparer := java.FixtureConfigureBootJars("com.android.art.debug:some-art-lib")
Paul Duffin89f570a2021-06-16 01:42:33 +01006841 fragment := java.ApexVariantReference{
6842 Apex: proptools.StringPtr("com.android.art.debug"),
6843 Module: proptools.StringPtr("art-bootclasspath-fragment"),
6844 }
6845 testNoUpdatableJarsInBootImage(t, "", preparer, fragment)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006846 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006847
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006848 t.Run("updatable jar from ART apex in the framework boot image => error", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006849 err := `module "some-art-lib" from updatable apexes \["com.android.art.debug"\] is not allowed in the framework boot image`
6850 // Update the dexpreopt BootJars directly.
6851 preparer := prepareSetBootJars("com.android.art.debug:some-art-lib")
6852 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006853 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006854
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006855 t.Run("updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
Paul Duffinf23bc472021-04-27 12:42:20 +01006856 err := `ArtApexJars expects this to be in apex "some-updatable-apex" but this is only in apexes.*"com.android.art.debug"`
Paul Duffin60264a02021-04-12 20:02:36 +01006857 // Update the dexpreopt ArtApexJars directly.
6858 preparer := prepareSetArtJars("some-updatable-apex:some-updatable-apex-lib")
6859 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006860 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006861
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006862 t.Run("non-updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
Paul Duffinf23bc472021-04-27 12:42:20 +01006863 err := `ArtApexJars expects this to be in apex "some-non-updatable-apex" but this is only in apexes.*"com.android.art.debug"`
Paul Duffin60264a02021-04-12 20:02:36 +01006864 // Update the dexpreopt ArtApexJars directly.
6865 preparer := prepareSetArtJars("some-non-updatable-apex:some-non-updatable-apex-lib")
6866 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006867 })
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01006868
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006869 t.Run("updatable jar from some other apex in the framework boot image => error", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006870 err := `module "some-updatable-apex-lib" from updatable apexes \["some-updatable-apex"\] is not allowed in the framework boot image`
6871 preparer := java.FixtureConfigureBootJars("some-updatable-apex:some-updatable-apex-lib")
6872 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006873 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006874
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006875 t.Run("non-updatable jar from some other apex in the framework boot image => ok", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006876 preparer := java.FixtureConfigureBootJars("some-non-updatable-apex:some-non-updatable-apex-lib")
Paul Duffin89f570a2021-06-16 01:42:33 +01006877 fragment := java.ApexVariantReference{
6878 Apex: proptools.StringPtr("some-non-updatable-apex"),
6879 Module: proptools.StringPtr("some-non-updatable-fragment"),
6880 }
6881 testNoUpdatableJarsInBootImage(t, "", preparer, fragment)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006882 })
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01006883
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006884 t.Run("nonexistent jar in the ART boot image => error", func(t *testing.T) {
Paul Duffin8f146b92021-04-12 17:24:18 +01006885 err := `"platform-bootclasspath" depends on undefined module "nonexistent"`
Paul Duffin60264a02021-04-12 20:02:36 +01006886 preparer := java.FixtureConfigureBootJars("platform:nonexistent")
6887 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006888 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006889
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006890 t.Run("nonexistent jar in the framework boot image => error", func(t *testing.T) {
Paul Duffin8f146b92021-04-12 17:24:18 +01006891 err := `"platform-bootclasspath" depends on undefined module "nonexistent"`
Paul Duffin60264a02021-04-12 20:02:36 +01006892 preparer := java.FixtureConfigureBootJars("platform:nonexistent")
6893 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006894 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006895
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006896 t.Run("platform jar in the ART boot image => error", func(t *testing.T) {
Paul Duffinf23bc472021-04-27 12:42:20 +01006897 err := `ArtApexJars is invalid as it requests a platform variant of "some-platform-lib"`
Paul Duffin60264a02021-04-12 20:02:36 +01006898 // Update the dexpreopt ArtApexJars directly.
6899 preparer := prepareSetArtJars("platform:some-platform-lib")
6900 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006901 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006902
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006903 t.Run("platform jar in the framework boot image => ok", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006904 preparer := java.FixtureConfigureBootJars("platform:some-platform-lib")
6905 testNoUpdatableJarsInBootImage(t, "", preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006906 })
Paul Duffin064b70c2020-11-02 17:32:38 +00006907}
6908
6909func TestDexpreoptAccessDexFilesFromPrebuiltApex(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006910 preparer := java.FixtureConfigureBootJars("myapex:libfoo")
Paul Duffin064b70c2020-11-02 17:32:38 +00006911 t.Run("prebuilt no source", func(t *testing.T) {
Paul Duffin89f570a2021-06-16 01:42:33 +01006912 fragment := java.ApexVariantReference{
6913 Apex: proptools.StringPtr("myapex"),
6914 Module: proptools.StringPtr("my-bootclasspath-fragment"),
6915 }
6916
Paul Duffin064b70c2020-11-02 17:32:38 +00006917 testDexpreoptWithApexes(t, `
6918 prebuilt_apex {
6919 name: "myapex" ,
6920 arch: {
6921 arm64: {
6922 src: "myapex-arm64.apex",
6923 },
6924 arm: {
6925 src: "myapex-arm.apex",
6926 },
6927 },
Paul Duffin89f570a2021-06-16 01:42:33 +01006928 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
6929 }
Paul Duffin064b70c2020-11-02 17:32:38 +00006930
Paul Duffin89f570a2021-06-16 01:42:33 +01006931 prebuilt_bootclasspath_fragment {
6932 name: "my-bootclasspath-fragment",
6933 contents: ["libfoo"],
6934 apex_available: ["myapex"],
6935 }
Paul Duffin064b70c2020-11-02 17:32:38 +00006936
Paul Duffin89f570a2021-06-16 01:42:33 +01006937 java_import {
6938 name: "libfoo",
6939 jars: ["libfoo.jar"],
6940 apex_available: ["myapex"],
6941 }
6942 `, "", preparer, fragment)
Paul Duffin064b70c2020-11-02 17:32:38 +00006943 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006944}
6945
Andrei Onea115e7e72020-06-05 21:14:03 +01006946func testApexPermittedPackagesRules(t *testing.T, errmsg, bp string, apexBootJars []string, rules []android.Rule) {
6947 t.Helper()
Andrei Onea115e7e72020-06-05 21:14:03 +01006948 bp += `
6949 apex_key {
6950 name: "myapex.key",
6951 public_key: "testkey.avbpubkey",
6952 private_key: "testkey.pem",
6953 }`
Paul Duffin45338f02021-03-30 23:07:52 +01006954 fs := android.MockFS{
Andrei Onea115e7e72020-06-05 21:14:03 +01006955 "lib1/src/A.java": nil,
6956 "lib2/src/B.java": nil,
6957 "system/sepolicy/apex/myapex-file_contexts": nil,
6958 }
6959
Paul Duffin45338f02021-03-30 23:07:52 +01006960 errorHandler := android.FixtureExpectsNoErrors
6961 if errmsg != "" {
6962 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
Colin Crossae8600b2020-10-29 17:09:13 -07006963 }
Colin Crossae8600b2020-10-29 17:09:13 -07006964
Paul Duffin45338f02021-03-30 23:07:52 +01006965 android.GroupFixturePreparers(
6966 android.PrepareForTestWithAndroidBuildComponents,
6967 java.PrepareForTestWithJavaBuildComponents,
6968 PrepareForTestWithApexBuildComponents,
6969 android.PrepareForTestWithNeverallowRules(rules),
6970 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
6971 updatableBootJars := make([]string, 0, len(apexBootJars))
6972 for _, apexBootJar := range apexBootJars {
6973 updatableBootJars = append(updatableBootJars, "myapex:"+apexBootJar)
6974 }
6975 variables.UpdatableBootJars = android.CreateTestConfiguredJarList(updatableBootJars)
6976 }),
6977 fs.AddToFixture(),
6978 ).
6979 ExtendWithErrorHandler(errorHandler).
6980 RunTestWithBp(t, bp)
Andrei Onea115e7e72020-06-05 21:14:03 +01006981}
6982
6983func TestApexPermittedPackagesRules(t *testing.T) {
6984 testcases := []struct {
6985 name string
6986 expectedError string
6987 bp string
6988 bootJars []string
6989 modulesPackages map[string][]string
6990 }{
6991
6992 {
6993 name: "Non-Bootclasspath apex jar not satisfying allowed module packages.",
6994 expectedError: "",
6995 bp: `
6996 java_library {
6997 name: "bcp_lib1",
6998 srcs: ["lib1/src/*.java"],
6999 permitted_packages: ["foo.bar"],
7000 apex_available: ["myapex"],
7001 sdk_version: "none",
7002 system_modules: "none",
7003 }
7004 java_library {
7005 name: "nonbcp_lib2",
7006 srcs: ["lib2/src/*.java"],
7007 apex_available: ["myapex"],
7008 permitted_packages: ["a.b"],
7009 sdk_version: "none",
7010 system_modules: "none",
7011 }
7012 apex {
7013 name: "myapex",
7014 key: "myapex.key",
7015 java_libs: ["bcp_lib1", "nonbcp_lib2"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007016 updatable: false,
Andrei Onea115e7e72020-06-05 21:14:03 +01007017 }`,
7018 bootJars: []string{"bcp_lib1"},
7019 modulesPackages: map[string][]string{
7020 "myapex": []string{
7021 "foo.bar",
7022 },
7023 },
7024 },
7025 {
7026 name: "Bootclasspath apex jar not satisfying allowed module packages.",
7027 expectedError: `module "bcp_lib2" .* which is restricted because jars that are part of the myapex module may only allow these packages: foo.bar. Please jarjar or move code around.`,
7028 bp: `
7029 java_library {
7030 name: "bcp_lib1",
7031 srcs: ["lib1/src/*.java"],
7032 apex_available: ["myapex"],
7033 permitted_packages: ["foo.bar"],
7034 sdk_version: "none",
7035 system_modules: "none",
7036 }
7037 java_library {
7038 name: "bcp_lib2",
7039 srcs: ["lib2/src/*.java"],
7040 apex_available: ["myapex"],
7041 permitted_packages: ["foo.bar", "bar.baz"],
7042 sdk_version: "none",
7043 system_modules: "none",
7044 }
7045 apex {
7046 name: "myapex",
7047 key: "myapex.key",
7048 java_libs: ["bcp_lib1", "bcp_lib2"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007049 updatable: false,
Andrei Onea115e7e72020-06-05 21:14:03 +01007050 }
7051 `,
7052 bootJars: []string{"bcp_lib1", "bcp_lib2"},
7053 modulesPackages: map[string][]string{
7054 "myapex": []string{
7055 "foo.bar",
7056 },
7057 },
7058 },
7059 }
7060 for _, tc := range testcases {
7061 t.Run(tc.name, func(t *testing.T) {
7062 rules := createApexPermittedPackagesRules(tc.modulesPackages)
7063 testApexPermittedPackagesRules(t, tc.expectedError, tc.bp, tc.bootJars, rules)
7064 })
7065 }
7066}
7067
Jiyong Park62304bb2020-04-13 16:19:48 +09007068func TestTestFor(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007069 ctx := testApex(t, `
Jiyong Park62304bb2020-04-13 16:19:48 +09007070 apex {
7071 name: "myapex",
7072 key: "myapex.key",
7073 native_shared_libs: ["mylib", "myprivlib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007074 updatable: false,
Jiyong Park62304bb2020-04-13 16:19:48 +09007075 }
7076
7077 apex_key {
7078 name: "myapex.key",
7079 public_key: "testkey.avbpubkey",
7080 private_key: "testkey.pem",
7081 }
7082
7083 cc_library {
7084 name: "mylib",
7085 srcs: ["mylib.cpp"],
7086 system_shared_libs: [],
7087 stl: "none",
7088 stubs: {
7089 versions: ["1"],
7090 },
7091 apex_available: ["myapex"],
7092 }
7093
7094 cc_library {
7095 name: "myprivlib",
7096 srcs: ["mylib.cpp"],
7097 system_shared_libs: [],
7098 stl: "none",
7099 apex_available: ["myapex"],
7100 }
7101
7102
7103 cc_test {
7104 name: "mytest",
7105 gtest: false,
7106 srcs: ["mylib.cpp"],
7107 system_shared_libs: [],
7108 stl: "none",
Jiyong Park46a512f2020-12-04 18:02:13 +09007109 shared_libs: ["mylib", "myprivlib", "mytestlib"],
Jiyong Park62304bb2020-04-13 16:19:48 +09007110 test_for: ["myapex"]
7111 }
Jiyong Park46a512f2020-12-04 18:02:13 +09007112
7113 cc_library {
7114 name: "mytestlib",
7115 srcs: ["mylib.cpp"],
7116 system_shared_libs: [],
7117 shared_libs: ["mylib", "myprivlib"],
7118 stl: "none",
7119 test_for: ["myapex"],
7120 }
7121
7122 cc_benchmark {
7123 name: "mybench",
7124 srcs: ["mylib.cpp"],
7125 system_shared_libs: [],
7126 shared_libs: ["mylib", "myprivlib"],
7127 stl: "none",
7128 test_for: ["myapex"],
7129 }
Jiyong Park62304bb2020-04-13 16:19:48 +09007130 `)
7131
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007132 ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
Paul Duffina71a67a2021-03-29 00:42:57 +01007133 ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007134 mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
7135 android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
7136 }
7137
7138 // These modules are tests for the apex, therefore are linked to the
Jiyong Park62304bb2020-04-13 16:19:48 +09007139 // actual implementation of mylib instead of its stub.
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007140 ensureLinkedLibIs("mytest", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
7141 ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
7142 ensureLinkedLibIs("mybench", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
7143}
Jiyong Park46a512f2020-12-04 18:02:13 +09007144
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007145func TestIndirectTestFor(t *testing.T) {
7146 ctx := testApex(t, `
7147 apex {
7148 name: "myapex",
7149 key: "myapex.key",
7150 native_shared_libs: ["mylib", "myprivlib"],
7151 updatable: false,
7152 }
Jiyong Park46a512f2020-12-04 18:02:13 +09007153
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007154 apex_key {
7155 name: "myapex.key",
7156 public_key: "testkey.avbpubkey",
7157 private_key: "testkey.pem",
7158 }
7159
7160 cc_library {
7161 name: "mylib",
7162 srcs: ["mylib.cpp"],
7163 system_shared_libs: [],
7164 stl: "none",
7165 stubs: {
7166 versions: ["1"],
7167 },
7168 apex_available: ["myapex"],
7169 }
7170
7171 cc_library {
7172 name: "myprivlib",
7173 srcs: ["mylib.cpp"],
7174 system_shared_libs: [],
7175 stl: "none",
7176 shared_libs: ["mylib"],
7177 apex_available: ["myapex"],
7178 }
7179
7180 cc_library {
7181 name: "mytestlib",
7182 srcs: ["mylib.cpp"],
7183 system_shared_libs: [],
7184 shared_libs: ["myprivlib"],
7185 stl: "none",
7186 test_for: ["myapex"],
7187 }
7188 `)
7189
7190 ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
Paul Duffina71a67a2021-03-29 00:42:57 +01007191 ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007192 mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
7193 android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
7194 }
7195
7196 // The platform variant of mytestlib links to the platform variant of the
7197 // internal myprivlib.
7198 ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/myprivlib/", "android_arm64_armv8-a_shared/myprivlib.so")
7199
7200 // The platform variant of myprivlib links to the platform variant of mylib
7201 // and bypasses its stubs.
7202 ensureLinkedLibIs("myprivlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
Jiyong Park62304bb2020-04-13 16:19:48 +09007203}
7204
Martin Stjernholmec009002021-03-27 15:18:31 +00007205func TestTestForForLibInOtherApex(t *testing.T) {
7206 // This case is only allowed for known overlapping APEXes, i.e. the ART APEXes.
7207 _ = testApex(t, `
7208 apex {
7209 name: "com.android.art",
7210 key: "myapex.key",
7211 native_shared_libs: ["mylib"],
7212 updatable: false,
7213 }
7214
7215 apex {
7216 name: "com.android.art.debug",
7217 key: "myapex.key",
7218 native_shared_libs: ["mylib", "mytestlib"],
7219 updatable: false,
7220 }
7221
7222 apex_key {
7223 name: "myapex.key",
7224 public_key: "testkey.avbpubkey",
7225 private_key: "testkey.pem",
7226 }
7227
7228 cc_library {
7229 name: "mylib",
7230 srcs: ["mylib.cpp"],
7231 system_shared_libs: [],
7232 stl: "none",
7233 stubs: {
7234 versions: ["1"],
7235 },
7236 apex_available: ["com.android.art", "com.android.art.debug"],
7237 }
7238
7239 cc_library {
7240 name: "mytestlib",
7241 srcs: ["mylib.cpp"],
7242 system_shared_libs: [],
7243 shared_libs: ["mylib"],
7244 stl: "none",
7245 apex_available: ["com.android.art.debug"],
7246 test_for: ["com.android.art"],
7247 }
7248 `,
7249 android.MockFS{
7250 "system/sepolicy/apex/com.android.art-file_contexts": nil,
7251 "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
7252 }.AddToFixture())
7253}
7254
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007255// TODO(jungjw): Move this to proptools
7256func intPtr(i int) *int {
7257 return &i
7258}
7259
7260func TestApexSet(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007261 ctx := testApex(t, `
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007262 apex_set {
7263 name: "myapex",
7264 set: "myapex.apks",
7265 filename: "foo_v2.apex",
7266 overrides: ["foo"],
7267 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00007268 `,
7269 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
7270 variables.Platform_sdk_version = intPtr(30)
7271 }),
7272 android.FixtureModifyConfig(func(config android.Config) {
7273 config.Targets[android.Android] = []android.Target{
7274 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}},
7275 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}},
7276 }
7277 }),
7278 )
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007279
Paul Duffin24704672021-04-06 16:09:30 +01007280 m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007281
7282 // Check extract_apks tool parameters.
Paul Duffin24704672021-04-06 16:09:30 +01007283 extractedApex := m.Output("extracted/myapex.apks")
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007284 actual := extractedApex.Args["abis"]
7285 expected := "ARMEABI_V7A,ARM64_V8A"
7286 if actual != expected {
7287 t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
7288 }
7289 actual = extractedApex.Args["sdk-version"]
7290 expected = "30"
7291 if actual != expected {
7292 t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
7293 }
7294
Paul Duffin6717d882021-06-15 19:09:41 +01007295 m = ctx.ModuleForTests("myapex", "android_common_myapex")
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007296 a := m.Module().(*ApexSet)
7297 expectedOverrides := []string{"foo"}
Colin Crossaa255532020-07-03 13:18:24 -07007298 actualOverrides := android.AndroidMkEntriesForTest(t, ctx, a)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007299 if !reflect.DeepEqual(actualOverrides, expectedOverrides) {
7300 t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES - expected %q vs actual %q", expectedOverrides, actualOverrides)
7301 }
7302}
7303
Jiyong Park7d95a512020-05-10 15:16:24 +09007304func TestNoStaticLinkingToStubsLib(t *testing.T) {
7305 testApexError(t, `.*required by "mylib" is a native library providing stub.*`, `
7306 apex {
7307 name: "myapex",
7308 key: "myapex.key",
7309 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007310 updatable: false,
Jiyong Park7d95a512020-05-10 15:16:24 +09007311 }
7312
7313 apex_key {
7314 name: "myapex.key",
7315 public_key: "testkey.avbpubkey",
7316 private_key: "testkey.pem",
7317 }
7318
7319 cc_library {
7320 name: "mylib",
7321 srcs: ["mylib.cpp"],
7322 static_libs: ["otherlib"],
7323 system_shared_libs: [],
7324 stl: "none",
7325 apex_available: [ "myapex" ],
7326 }
7327
7328 cc_library {
7329 name: "otherlib",
7330 srcs: ["mylib.cpp"],
7331 system_shared_libs: [],
7332 stl: "none",
7333 stubs: {
7334 versions: ["1", "2", "3"],
7335 },
7336 apex_available: [ "myapex" ],
7337 }
7338 `)
7339}
7340
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007341func TestApexKeysTxt(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007342 ctx := testApex(t, `
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007343 apex {
7344 name: "myapex",
7345 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007346 updatable: false,
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007347 }
7348
7349 apex_key {
7350 name: "myapex.key",
7351 public_key: "testkey.avbpubkey",
7352 private_key: "testkey.pem",
7353 }
7354
7355 prebuilt_apex {
7356 name: "myapex",
7357 prefer: true,
7358 arch: {
7359 arm64: {
7360 src: "myapex-arm64.apex",
7361 },
7362 arm: {
7363 src: "myapex-arm.apex",
7364 },
7365 },
7366 }
7367
7368 apex_set {
7369 name: "myapex_set",
7370 set: "myapex.apks",
7371 filename: "myapex_set.apex",
7372 overrides: ["myapex"],
7373 }
7374 `)
7375
7376 apexKeysText := ctx.SingletonForTests("apex_keys_text")
7377 content := apexKeysText.MaybeDescription("apexkeys.txt").BuildParams.Args["content"]
7378 ensureContains(t, content, `name="myapex_set.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
Jiyong Park03a7f3e2020-06-18 19:34:42 +09007379 ensureContains(t, content, `name="myapex.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007380}
7381
Jooyung Han938b5932020-06-20 12:47:47 +09007382func TestAllowedFiles(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007383 ctx := testApex(t, `
Jooyung Han938b5932020-06-20 12:47:47 +09007384 apex {
7385 name: "myapex",
7386 key: "myapex.key",
7387 apps: ["app"],
7388 allowed_files: "allowed.txt",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007389 updatable: false,
Jooyung Han938b5932020-06-20 12:47:47 +09007390 }
7391
7392 apex_key {
7393 name: "myapex.key",
7394 public_key: "testkey.avbpubkey",
7395 private_key: "testkey.pem",
7396 }
7397
7398 android_app {
7399 name: "app",
7400 srcs: ["foo/bar/MyClass.java"],
7401 package_name: "foo",
7402 sdk_version: "none",
7403 system_modules: "none",
7404 apex_available: [ "myapex" ],
7405 }
7406 `, withFiles(map[string][]byte{
7407 "sub/Android.bp": []byte(`
7408 override_apex {
7409 name: "override_myapex",
7410 base: "myapex",
7411 apps: ["override_app"],
7412 allowed_files: ":allowed",
7413 }
7414 // Overridable "path" property should be referenced indirectly
7415 filegroup {
7416 name: "allowed",
7417 srcs: ["allowed.txt"],
7418 }
7419 override_android_app {
7420 name: "override_app",
7421 base: "app",
7422 package_name: "bar",
7423 }
7424 `),
7425 }))
7426
7427 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("diffApexContentRule")
7428 if expected, actual := "allowed.txt", rule.Args["allowed_files_file"]; expected != actual {
7429 t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
7430 }
7431
7432 rule2 := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Rule("diffApexContentRule")
7433 if expected, actual := "sub/allowed.txt", rule2.Args["allowed_files_file"]; expected != actual {
7434 t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
7435 }
7436}
7437
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007438func TestNonPreferredPrebuiltDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007439 testApex(t, `
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007440 apex {
7441 name: "myapex",
7442 key: "myapex.key",
7443 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007444 updatable: false,
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007445 }
7446
7447 apex_key {
7448 name: "myapex.key",
7449 public_key: "testkey.avbpubkey",
7450 private_key: "testkey.pem",
7451 }
7452
7453 cc_library {
7454 name: "mylib",
7455 srcs: ["mylib.cpp"],
7456 stubs: {
Dan Albertc8060532020-07-22 22:32:17 -07007457 versions: ["current"],
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007458 },
7459 apex_available: ["myapex"],
7460 }
7461
7462 cc_prebuilt_library_shared {
7463 name: "mylib",
7464 prefer: false,
7465 srcs: ["prebuilt.so"],
7466 stubs: {
Dan Albertc8060532020-07-22 22:32:17 -07007467 versions: ["current"],
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007468 },
7469 apex_available: ["myapex"],
7470 }
7471 `)
7472}
7473
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007474func TestCompressedApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007475 ctx := testApex(t, `
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007476 apex {
7477 name: "myapex",
7478 key: "myapex.key",
7479 compressible: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007480 updatable: false,
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007481 }
7482 apex_key {
7483 name: "myapex.key",
7484 public_key: "testkey.avbpubkey",
7485 private_key: "testkey.pem",
7486 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00007487 `,
7488 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
7489 variables.CompressedApex = proptools.BoolPtr(true)
7490 }),
7491 )
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007492
7493 compressRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("compressRule")
7494 ensureContains(t, compressRule.Output.String(), "myapex.capex.unsigned")
7495
7496 signApkRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Description("sign compressedApex")
7497 ensureEquals(t, signApkRule.Input.String(), compressRule.Output.String())
7498
7499 // Make sure output of bundle is .capex
7500 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
7501 ensureContains(t, ab.outputFile.String(), "myapex.capex")
7502
7503 // Verify android.mk rules
Colin Crossaa255532020-07-03 13:18:24 -07007504 data := android.AndroidMkDataForTest(t, ctx, ab)
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007505 var builder strings.Builder
7506 data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
7507 androidMk := builder.String()
7508 ensureContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.capex\n")
7509}
7510
Martin Stjernholm2856c662020-12-02 15:03:42 +00007511func TestPreferredPrebuiltSharedLibDep(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007512 ctx := testApex(t, `
Martin Stjernholm2856c662020-12-02 15:03:42 +00007513 apex {
7514 name: "myapex",
7515 key: "myapex.key",
7516 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007517 updatable: false,
Martin Stjernholm2856c662020-12-02 15:03:42 +00007518 }
7519
7520 apex_key {
7521 name: "myapex.key",
7522 public_key: "testkey.avbpubkey",
7523 private_key: "testkey.pem",
7524 }
7525
7526 cc_library {
7527 name: "mylib",
7528 srcs: ["mylib.cpp"],
7529 apex_available: ["myapex"],
7530 shared_libs: ["otherlib"],
7531 system_shared_libs: [],
7532 }
7533
7534 cc_library {
7535 name: "otherlib",
7536 srcs: ["mylib.cpp"],
7537 stubs: {
7538 versions: ["current"],
7539 },
7540 }
7541
7542 cc_prebuilt_library_shared {
7543 name: "otherlib",
7544 prefer: true,
7545 srcs: ["prebuilt.so"],
7546 stubs: {
7547 versions: ["current"],
7548 },
7549 }
7550 `)
7551
7552 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07007553 data := android.AndroidMkDataForTest(t, ctx, ab)
Martin Stjernholm2856c662020-12-02 15:03:42 +00007554 var builder strings.Builder
7555 data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
7556 androidMk := builder.String()
7557
7558 // The make level dependency needs to be on otherlib - prebuilt_otherlib isn't
7559 // a thing there.
7560 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += otherlib\n")
7561}
7562
Jiyong Parke3867542020-12-03 17:28:25 +09007563func TestExcludeDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007564 ctx := testApex(t, `
Jiyong Parke3867542020-12-03 17:28:25 +09007565 apex {
7566 name: "myapex",
7567 key: "myapex.key",
7568 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007569 updatable: false,
Jiyong Parke3867542020-12-03 17:28:25 +09007570 }
7571
7572 apex_key {
7573 name: "myapex.key",
7574 public_key: "testkey.avbpubkey",
7575 private_key: "testkey.pem",
7576 }
7577
7578 cc_library {
7579 name: "mylib",
7580 srcs: ["mylib.cpp"],
7581 system_shared_libs: [],
7582 stl: "none",
7583 apex_available: ["myapex"],
7584 shared_libs: ["mylib2"],
7585 target: {
7586 apex: {
7587 exclude_shared_libs: ["mylib2"],
7588 },
7589 },
7590 }
7591
7592 cc_library {
7593 name: "mylib2",
7594 srcs: ["mylib.cpp"],
7595 system_shared_libs: [],
7596 stl: "none",
7597 }
7598 `)
7599
7600 // Check if mylib is linked to mylib2 for the non-apex target
7601 ldFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
7602 ensureContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
7603
7604 // Make sure that the link doesn't occur for the apex target
7605 ldFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
7606 ensureNotContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared_apex10000/mylib2.so")
7607
7608 // It shouldn't appear in the copy cmd as well.
7609 copyCmds := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule").Args["copy_commands"]
7610 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
7611}
7612
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007613func TestPrebuiltStubLibDep(t *testing.T) {
7614 bpBase := `
7615 apex {
7616 name: "myapex",
7617 key: "myapex.key",
7618 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007619 updatable: false,
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007620 }
7621 apex_key {
7622 name: "myapex.key",
7623 public_key: "testkey.avbpubkey",
7624 private_key: "testkey.pem",
7625 }
7626 cc_library {
7627 name: "mylib",
7628 srcs: ["mylib.cpp"],
7629 apex_available: ["myapex"],
7630 shared_libs: ["stublib"],
7631 system_shared_libs: [],
7632 }
7633 apex {
7634 name: "otherapex",
7635 enabled: %s,
7636 key: "myapex.key",
7637 native_shared_libs: ["stublib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007638 updatable: false,
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007639 }
7640 `
7641
7642 stublibSourceBp := `
7643 cc_library {
7644 name: "stublib",
7645 srcs: ["mylib.cpp"],
7646 apex_available: ["otherapex"],
7647 system_shared_libs: [],
7648 stl: "none",
7649 stubs: {
7650 versions: ["1"],
7651 },
7652 }
7653 `
7654
7655 stublibPrebuiltBp := `
7656 cc_prebuilt_library_shared {
7657 name: "stublib",
7658 srcs: ["prebuilt.so"],
7659 apex_available: ["otherapex"],
7660 stubs: {
7661 versions: ["1"],
7662 },
7663 %s
7664 }
7665 `
7666
7667 tests := []struct {
7668 name string
7669 stublibBp string
7670 usePrebuilt bool
7671 modNames []string // Modules to collect AndroidMkEntries for
7672 otherApexEnabled []string
7673 }{
7674 {
7675 name: "only_source",
7676 stublibBp: stublibSourceBp,
7677 usePrebuilt: false,
7678 modNames: []string{"stublib"},
7679 otherApexEnabled: []string{"true", "false"},
7680 },
7681 {
7682 name: "source_preferred",
7683 stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, ""),
7684 usePrebuilt: false,
7685 modNames: []string{"stublib", "prebuilt_stublib"},
7686 otherApexEnabled: []string{"true", "false"},
7687 },
7688 {
7689 name: "prebuilt_preferred",
7690 stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, "prefer: true,"),
7691 usePrebuilt: true,
7692 modNames: []string{"stublib", "prebuilt_stublib"},
7693 otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
7694 },
7695 {
7696 name: "only_prebuilt",
7697 stublibBp: fmt.Sprintf(stublibPrebuiltBp, ""),
7698 usePrebuilt: true,
7699 modNames: []string{"stublib"},
7700 otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
7701 },
7702 }
7703
7704 for _, test := range tests {
7705 t.Run(test.name, func(t *testing.T) {
7706 for _, otherApexEnabled := range test.otherApexEnabled {
7707 t.Run("otherapex_enabled_"+otherApexEnabled, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007708 ctx := testApex(t, fmt.Sprintf(bpBase, otherApexEnabled)+test.stublibBp)
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007709
7710 type modAndMkEntries struct {
7711 mod *cc.Module
7712 mkEntries android.AndroidMkEntries
7713 }
7714 entries := []*modAndMkEntries{}
7715
7716 // Gather shared lib modules that are installable
7717 for _, modName := range test.modNames {
7718 for _, variant := range ctx.ModuleVariantsForTests(modName) {
7719 if !strings.HasPrefix(variant, "android_arm64_armv8-a_shared") {
7720 continue
7721 }
7722 mod := ctx.ModuleForTests(modName, variant).Module().(*cc.Module)
Colin Crossa9c8c9f2020-12-16 10:20:23 -08007723 if !mod.Enabled() || mod.IsHideFromMake() {
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007724 continue
7725 }
Colin Crossaa255532020-07-03 13:18:24 -07007726 for _, ent := range android.AndroidMkEntriesForTest(t, ctx, mod) {
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007727 if ent.Disabled {
7728 continue
7729 }
7730 entries = append(entries, &modAndMkEntries{
7731 mod: mod,
7732 mkEntries: ent,
7733 })
7734 }
7735 }
7736 }
7737
7738 var entry *modAndMkEntries = nil
7739 for _, ent := range entries {
7740 if strings.Join(ent.mkEntries.EntryMap["LOCAL_MODULE"], ",") == "stublib" {
7741 if entry != nil {
7742 t.Errorf("More than one AndroidMk entry for \"stublib\": %s and %s", entry.mod, ent.mod)
7743 } else {
7744 entry = ent
7745 }
7746 }
7747 }
7748
7749 if entry == nil {
7750 t.Errorf("AndroidMk entry for \"stublib\" missing")
7751 } else {
7752 isPrebuilt := entry.mod.Prebuilt() != nil
7753 if isPrebuilt != test.usePrebuilt {
7754 t.Errorf("Wrong module for \"stublib\" AndroidMk entry: got prebuilt %t, want prebuilt %t", isPrebuilt, test.usePrebuilt)
7755 }
7756 if !entry.mod.IsStubs() {
7757 t.Errorf("Module for \"stublib\" AndroidMk entry isn't a stub: %s", entry.mod)
7758 }
7759 if entry.mkEntries.EntryMap["LOCAL_NOT_AVAILABLE_FOR_PLATFORM"] != nil {
7760 t.Errorf("AndroidMk entry for \"stublib\" has LOCAL_NOT_AVAILABLE_FOR_PLATFORM set: %+v", entry.mkEntries)
7761 }
Jiyong Park892a98f2020-12-14 09:20:00 +09007762 cflags := entry.mkEntries.EntryMap["LOCAL_EXPORT_CFLAGS"]
Jiyong Parkd4a3a132021-03-17 20:21:35 +09007763 expected := "-D__STUBLIB_API__=10000"
Jiyong Park892a98f2020-12-14 09:20:00 +09007764 if !android.InList(expected, cflags) {
7765 t.Errorf("LOCAL_EXPORT_CFLAGS expected to have %q, but got %q", expected, cflags)
7766 }
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007767 }
7768 })
7769 }
7770 })
7771 }
7772}
7773
Martin Stjernholmdf298b32021-05-21 20:57:29 +01007774func TestHostApexInHostOnlyBuild(t *testing.T) {
7775 testApex(t, `
7776 apex {
7777 name: "myapex",
7778 host_supported: true,
7779 key: "myapex.key",
7780 updatable: false,
7781 payload_type: "zip",
7782 }
7783 apex_key {
7784 name: "myapex.key",
7785 public_key: "testkey.avbpubkey",
7786 private_key: "testkey.pem",
7787 }
7788 `,
7789 android.FixtureModifyConfig(func(config android.Config) {
7790 // We may not have device targets in all builds, e.g. in
7791 // prebuilts/build-tools/build-prebuilts.sh
7792 config.Targets[android.Android] = []android.Target{}
7793 }))
7794}
7795
Colin Crossc33e5212021-05-25 18:16:02 -07007796func TestApexJavaCoverage(t *testing.T) {
7797 bp := `
7798 apex {
7799 name: "myapex",
7800 key: "myapex.key",
7801 java_libs: ["mylib"],
7802 bootclasspath_fragments: ["mybootclasspathfragment"],
7803 systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
7804 updatable: false,
7805 }
7806
7807 apex_key {
7808 name: "myapex.key",
7809 public_key: "testkey.avbpubkey",
7810 private_key: "testkey.pem",
7811 }
7812
7813 java_library {
7814 name: "mylib",
7815 srcs: ["mylib.java"],
7816 apex_available: ["myapex"],
7817 compile_dex: true,
7818 }
7819
7820 bootclasspath_fragment {
7821 name: "mybootclasspathfragment",
7822 contents: ["mybootclasspathlib"],
7823 apex_available: ["myapex"],
7824 }
7825
7826 java_library {
7827 name: "mybootclasspathlib",
7828 srcs: ["mybootclasspathlib.java"],
7829 apex_available: ["myapex"],
7830 compile_dex: true,
7831 }
7832
7833 systemserverclasspath_fragment {
7834 name: "mysystemserverclasspathfragment",
7835 contents: ["mysystemserverclasspathlib"],
7836 apex_available: ["myapex"],
7837 }
7838
7839 java_library {
7840 name: "mysystemserverclasspathlib",
7841 srcs: ["mysystemserverclasspathlib.java"],
7842 apex_available: ["myapex"],
7843 compile_dex: true,
7844 }
7845 `
7846
7847 result := android.GroupFixturePreparers(
7848 PrepareForTestWithApexBuildComponents,
7849 prepareForTestWithMyapex,
7850 java.PrepareForTestWithJavaDefaultModules,
7851 android.PrepareForTestWithAndroidBuildComponents,
7852 android.FixtureWithRootAndroidBp(bp),
7853 android.FixtureMergeEnv(map[string]string{
7854 "EMMA_INSTRUMENT": "true",
7855 }),
7856 ).RunTest(t)
7857
7858 // Make sure jacoco ran on both mylib and mybootclasspathlib
7859 if result.ModuleForTests("mylib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
7860 t.Errorf("Failed to find jacoco rule for mylib")
7861 }
7862 if result.ModuleForTests("mybootclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
7863 t.Errorf("Failed to find jacoco rule for mybootclasspathlib")
7864 }
7865 if result.ModuleForTests("mysystemserverclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
7866 t.Errorf("Failed to find jacoco rule for mysystemserverclasspathlib")
7867 }
7868}
7869
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07007870func TestMain(m *testing.M) {
Paul Duffin37ba3442021-03-29 00:21:08 +01007871 os.Exit(m.Run())
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07007872}