Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1 | // Copyright 2018 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package apex |
| 16 | |
| 17 | import ( |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 18 | "io/ioutil" |
| 19 | "os" |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 20 | "path" |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 21 | "reflect" |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 22 | "sort" |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 23 | "strings" |
| 24 | "testing" |
Jiyong Park | da6eb59 | 2018-12-19 17:12:36 +0900 | [diff] [blame] | 25 | |
| 26 | "github.com/google/blueprint/proptools" |
| 27 | |
| 28 | "android/soong/android" |
| 29 | "android/soong/cc" |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 30 | "android/soong/dexpreopt" |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 31 | "android/soong/java" |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 32 | ) |
| 33 | |
Jaewoong Jung | 14f5ff6 | 2019-06-18 13:09:13 -0700 | [diff] [blame] | 34 | var buildDir string |
| 35 | |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 36 | // names returns name list from white space separated string |
| 37 | func names(s string) (ns []string) { |
| 38 | for _, n := range strings.Split(s, " ") { |
| 39 | if len(n) > 0 { |
| 40 | ns = append(ns, n) |
| 41 | } |
| 42 | } |
| 43 | return |
| 44 | } |
| 45 | |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 46 | func testApexError(t *testing.T, pattern, bp string, handlers ...testCustomizer) { |
| 47 | t.Helper() |
| 48 | ctx, config := testApexContext(t, bp, handlers...) |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 49 | _, errs := ctx.ParseFileList(".", []string{"Android.bp"}) |
| 50 | if len(errs) > 0 { |
| 51 | android.FailIfNoMatchingErrors(t, pattern, errs) |
| 52 | return |
| 53 | } |
| 54 | _, errs = ctx.PrepareBuildActions(config) |
| 55 | if len(errs) > 0 { |
| 56 | android.FailIfNoMatchingErrors(t, pattern, errs) |
| 57 | return |
| 58 | } |
| 59 | |
| 60 | t.Fatalf("missing expected error %q (0 errors are returned)", pattern) |
| 61 | } |
| 62 | |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 63 | func testApex(t *testing.T, bp string, handlers ...testCustomizer) (*android.TestContext, android.Config) { |
| 64 | t.Helper() |
| 65 | ctx, config := testApexContext(t, bp, handlers...) |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 66 | _, errs := ctx.ParseFileList(".", []string{"Android.bp"}) |
| 67 | android.FailIfErrored(t, errs) |
| 68 | _, errs = ctx.PrepareBuildActions(config) |
| 69 | android.FailIfErrored(t, errs) |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 70 | return ctx, config |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 71 | } |
| 72 | |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 73 | type testCustomizer func(fs map[string][]byte, config android.Config) |
| 74 | |
| 75 | func withFiles(files map[string][]byte) testCustomizer { |
| 76 | return func(fs map[string][]byte, config android.Config) { |
| 77 | for k, v := range files { |
| 78 | fs[k] = v |
| 79 | } |
| 80 | } |
| 81 | } |
| 82 | |
| 83 | func withTargets(targets map[android.OsType][]android.Target) testCustomizer { |
| 84 | return func(fs map[string][]byte, config android.Config) { |
| 85 | for k, v := range targets { |
| 86 | config.Targets[k] = v |
| 87 | } |
| 88 | } |
| 89 | } |
| 90 | |
Jooyung Han | 35155c4 | 2020-02-06 17:33:20 +0900 | [diff] [blame] | 91 | // withNativeBridgeTargets sets configuration with targets including: |
| 92 | // - X86_64 (primary) |
| 93 | // - X86 (secondary) |
| 94 | // - Arm64 on X86_64 (native bridge) |
| 95 | // - Arm on X86 (native bridge) |
| 96 | func withNativeBridgeEnabled(fs map[string][]byte, config android.Config) { |
| 97 | config.Targets[android.Android] = []android.Target{ |
| 98 | {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "silvermont", Abi: []string{"arm64-v8a"}}, |
| 99 | NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""}, |
| 100 | {Os: android.Android, Arch: android.Arch{ArchType: android.X86, ArchVariant: "silvermont", Abi: []string{"armeabi-v7a"}}, |
| 101 | NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""}, |
| 102 | {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}, |
| 103 | NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86_64", NativeBridgeRelativePath: "arm64"}, |
| 104 | {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}, |
| 105 | NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86", NativeBridgeRelativePath: "arm"}, |
| 106 | } |
| 107 | } |
| 108 | |
Jiyong Park | cfaa164 | 2020-02-28 16:51:07 +0900 | [diff] [blame] | 109 | func withManifestPackageNameOverrides(specs []string) testCustomizer { |
| 110 | return func(fs map[string][]byte, config android.Config) { |
| 111 | config.TestProductVariables.ManifestPackageNameOverrides = specs |
| 112 | } |
| 113 | } |
| 114 | |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 115 | func withBinder32bit(fs map[string][]byte, config android.Config) { |
| 116 | config.TestProductVariables.Binder32bit = proptools.BoolPtr(true) |
| 117 | } |
| 118 | |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 119 | func withUnbundledBuild(fs map[string][]byte, config android.Config) { |
| 120 | config.TestProductVariables.Unbundled_build = proptools.BoolPtr(true) |
| 121 | } |
| 122 | |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 123 | func testApexContext(t *testing.T, bp string, handlers ...testCustomizer) (*android.TestContext, android.Config) { |
Jooyung Han | 671f1ce | 2019-12-17 12:47:13 +0900 | [diff] [blame] | 124 | android.ClearApexDependency() |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 125 | |
| 126 | bp = bp + ` |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 127 | filegroup { |
| 128 | name: "myapex-file_contexts", |
| 129 | srcs: [ |
| 130 | "system/sepolicy/apex/myapex-file_contexts", |
| 131 | ], |
| 132 | } |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 133 | ` |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 134 | |
Colin Cross | f9aabd7 | 2020-02-15 11:29:50 -0800 | [diff] [blame] | 135 | bp = bp + cc.GatherRequiredDepsForTest(android.Android) |
| 136 | |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 137 | bp = bp + java.GatherRequiredDepsForTest() |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 138 | |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 139 | fs := map[string][]byte{ |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 140 | "a.java": nil, |
| 141 | "PrebuiltAppFoo.apk": nil, |
| 142 | "PrebuiltAppFooPriv.apk": nil, |
| 143 | "build/make/target/product/security": nil, |
| 144 | "apex_manifest.json": nil, |
| 145 | "AndroidManifest.xml": nil, |
| 146 | "system/sepolicy/apex/myapex-file_contexts": nil, |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 147 | "system/sepolicy/apex/myapex.updatable-file_contexts": nil, |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 148 | "system/sepolicy/apex/myapex2-file_contexts": nil, |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 149 | "system/sepolicy/apex/otherapex-file_contexts": nil, |
| 150 | "system/sepolicy/apex/commonapex-file_contexts": nil, |
| 151 | "system/sepolicy/apex/com.android.vndk-file_contexts": nil, |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 152 | "mylib.cpp": nil, |
| 153 | "mylib_common.cpp": nil, |
| 154 | "mytest.cpp": nil, |
| 155 | "mytest1.cpp": nil, |
| 156 | "mytest2.cpp": nil, |
| 157 | "mytest3.cpp": nil, |
| 158 | "myprebuilt": nil, |
| 159 | "my_include": nil, |
| 160 | "foo/bar/MyClass.java": nil, |
| 161 | "prebuilt.jar": nil, |
Paul Duffin | dddd546 | 2020-04-07 15:25:44 +0100 | [diff] [blame] | 162 | "prebuilt.so": nil, |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 163 | "vendor/foo/devkeys/test.x509.pem": nil, |
| 164 | "vendor/foo/devkeys/test.pk8": nil, |
| 165 | "testkey.x509.pem": nil, |
| 166 | "testkey.pk8": nil, |
| 167 | "testkey.override.x509.pem": nil, |
| 168 | "testkey.override.pk8": nil, |
| 169 | "vendor/foo/devkeys/testkey.avbpubkey": nil, |
| 170 | "vendor/foo/devkeys/testkey.pem": nil, |
| 171 | "NOTICE": nil, |
| 172 | "custom_notice": nil, |
Jiyong Park | 9918e1a | 2020-03-17 19:16:40 +0900 | [diff] [blame] | 173 | "custom_notice_for_static_lib": nil, |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 174 | "testkey2.avbpubkey": nil, |
| 175 | "testkey2.pem": nil, |
| 176 | "myapex-arm64.apex": nil, |
| 177 | "myapex-arm.apex": nil, |
| 178 | "frameworks/base/api/current.txt": nil, |
| 179 | "framework/aidl/a.aidl": nil, |
| 180 | "build/make/core/proguard.flags": nil, |
| 181 | "build/make/core/proguard_basic_keeps.flags": nil, |
| 182 | "dummy.txt": nil, |
Liz Kammer | 1c14a21 | 2020-05-12 15:26:55 -0700 | [diff] [blame] | 183 | "baz": nil, |
| 184 | "bar/baz": nil, |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 185 | } |
| 186 | |
Colin Cross | f9aabd7 | 2020-02-15 11:29:50 -0800 | [diff] [blame] | 187 | cc.GatherRequiredFilesForTest(fs) |
| 188 | |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 189 | for _, handler := range handlers { |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 190 | // The fs now needs to be populated before creating the config, call handlers twice |
| 191 | // for now, once to get any fs changes, and later after the config was created to |
| 192 | // set product variables or targets. |
| 193 | tempConfig := android.TestArchConfig(buildDir, nil, bp, fs) |
| 194 | handler(fs, tempConfig) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 195 | } |
| 196 | |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 197 | config := android.TestArchConfig(buildDir, nil, bp, fs) |
| 198 | config.TestProductVariables.DeviceVndkVersion = proptools.StringPtr("current") |
| 199 | config.TestProductVariables.DefaultAppCertificate = proptools.StringPtr("vendor/foo/devkeys/test") |
| 200 | config.TestProductVariables.CertificateOverrides = []string{"myapex_keytest:myapex.certificate.override"} |
| 201 | config.TestProductVariables.Platform_sdk_codename = proptools.StringPtr("Q") |
| 202 | config.TestProductVariables.Platform_sdk_final = proptools.BoolPtr(false) |
| 203 | config.TestProductVariables.Platform_vndk_version = proptools.StringPtr("VER") |
| 204 | |
| 205 | for _, handler := range handlers { |
| 206 | // The fs now needs to be populated before creating the config, call handlers twice |
| 207 | // for now, earlier to get any fs changes, and now after the config was created to |
| 208 | // set product variables or targets. |
| 209 | tempFS := map[string][]byte{} |
| 210 | handler(tempFS, config) |
| 211 | } |
| 212 | |
| 213 | ctx := android.NewTestArchContext() |
| 214 | ctx.RegisterModuleType("apex", BundleFactory) |
| 215 | ctx.RegisterModuleType("apex_test", testApexBundleFactory) |
| 216 | ctx.RegisterModuleType("apex_vndk", vndkApexBundleFactory) |
| 217 | ctx.RegisterModuleType("apex_key", ApexKeyFactory) |
| 218 | ctx.RegisterModuleType("apex_defaults", defaultsFactory) |
| 219 | ctx.RegisterModuleType("prebuilt_apex", PrebuiltFactory) |
| 220 | ctx.RegisterModuleType("override_apex", overrideApexFactory) |
| 221 | |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 222 | ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators) |
| 223 | ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators) |
| 224 | |
Paul Duffin | 77980a8 | 2019-12-19 16:01:36 +0000 | [diff] [blame] | 225 | cc.RegisterRequiredBuildComponentsForTest(ctx) |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 226 | ctx.RegisterModuleType("cc_test", cc.TestFactory) |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 227 | ctx.RegisterModuleType("vndk_prebuilt_shared", cc.VndkPrebuiltSharedFactory) |
| 228 | ctx.RegisterModuleType("vndk_libraries_txt", cc.VndkLibrariesTxtFactory) |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 229 | ctx.RegisterModuleType("prebuilt_etc", android.PrebuiltEtcFactory) |
atrost | 6e12625 | 2020-01-27 17:01:16 +0000 | [diff] [blame] | 230 | ctx.RegisterModuleType("platform_compat_config", java.PlatformCompatConfigFactory) |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 231 | ctx.RegisterModuleType("sh_binary", android.ShBinaryFactory) |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 232 | ctx.RegisterModuleType("filegroup", android.FileGroupFactory) |
Paul Duffin | f9b1da0 | 2019-12-18 19:51:55 +0000 | [diff] [blame] | 233 | java.RegisterJavaBuildComponents(ctx) |
Paul Duffin | 43dc1cc | 2019-12-19 11:18:54 +0000 | [diff] [blame] | 234 | java.RegisterSystemModulesBuildComponents(ctx) |
Paul Duffin | f9b1da0 | 2019-12-18 19:51:55 +0000 | [diff] [blame] | 235 | java.RegisterAppBuildComponents(ctx) |
Jooyung Han | 58f26ab | 2019-12-18 15:34:32 +0900 | [diff] [blame] | 236 | ctx.RegisterModuleType("java_sdk_library", java.SdkLibraryFactory) |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 237 | |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 238 | ctx.PreDepsMutators(RegisterPreDepsMutators) |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 239 | ctx.PostDepsMutators(RegisterPostDepsMutators) |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 240 | |
| 241 | ctx.Register(config) |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 242 | |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 243 | return ctx, config |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 244 | } |
| 245 | |
Jaewoong Jung | c1001ec | 2019-06-25 11:20:53 -0700 | [diff] [blame] | 246 | func setUp() { |
| 247 | var err error |
| 248 | buildDir, err = ioutil.TempDir("", "soong_apex_test") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 249 | if err != nil { |
Jaewoong Jung | c1001ec | 2019-06-25 11:20:53 -0700 | [diff] [blame] | 250 | panic(err) |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 251 | } |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 252 | } |
| 253 | |
Jaewoong Jung | c1001ec | 2019-06-25 11:20:53 -0700 | [diff] [blame] | 254 | func tearDown() { |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 255 | os.RemoveAll(buildDir) |
| 256 | } |
| 257 | |
Jooyung Han | 643adc4 | 2020-02-27 13:50:06 +0900 | [diff] [blame] | 258 | // ensure that 'result' equals 'expected' |
| 259 | func ensureEquals(t *testing.T, result string, expected string) { |
| 260 | t.Helper() |
| 261 | if result != expected { |
| 262 | t.Errorf("%q != %q", expected, result) |
| 263 | } |
| 264 | } |
| 265 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 266 | // ensure that 'result' contains 'expected' |
| 267 | func ensureContains(t *testing.T, result string, expected string) { |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 268 | t.Helper() |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 269 | if !strings.Contains(result, expected) { |
| 270 | t.Errorf("%q is not found in %q", expected, result) |
| 271 | } |
| 272 | } |
| 273 | |
| 274 | // ensures that 'result' does not contain 'notExpected' |
| 275 | func ensureNotContains(t *testing.T, result string, notExpected string) { |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 276 | t.Helper() |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 277 | if strings.Contains(result, notExpected) { |
| 278 | t.Errorf("%q is found in %q", notExpected, result) |
| 279 | } |
| 280 | } |
| 281 | |
| 282 | func ensureListContains(t *testing.T, result []string, expected string) { |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 283 | t.Helper() |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 284 | if !android.InList(expected, result) { |
| 285 | t.Errorf("%q is not found in %v", expected, result) |
| 286 | } |
| 287 | } |
| 288 | |
| 289 | func ensureListNotContains(t *testing.T, result []string, notExpected string) { |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 290 | t.Helper() |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 291 | if android.InList(notExpected, result) { |
| 292 | t.Errorf("%q is found in %v", notExpected, result) |
| 293 | } |
| 294 | } |
| 295 | |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 296 | func ensureListEmpty(t *testing.T, result []string) { |
| 297 | t.Helper() |
| 298 | if len(result) > 0 { |
| 299 | t.Errorf("%q is expected to be empty", result) |
| 300 | } |
| 301 | } |
| 302 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 303 | // Minimal test |
| 304 | func TestBasicApex(t *testing.T) { |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 305 | ctx, _ := testApex(t, ` |
Jiyong Park | 30ca937 | 2019-02-07 16:27:23 +0900 | [diff] [blame] | 306 | apex_defaults { |
| 307 | name: "myapex-defaults", |
Jiyong Park | 809bb72 | 2019-02-13 21:33:49 +0900 | [diff] [blame] | 308 | manifest: ":myapex.manifest", |
| 309 | androidManifest: ":myapex.androidmanifest", |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 310 | key: "myapex.key", |
| 311 | native_shared_libs: ["mylib"], |
Alex Light | 3d67359 | 2019-01-18 14:37:31 -0800 | [diff] [blame] | 312 | multilib: { |
| 313 | both: { |
| 314 | binaries: ["foo",], |
| 315 | } |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 316 | }, |
Jooyung Han | 5a80d9f | 2019-12-23 15:38:34 +0900 | [diff] [blame] | 317 | java_libs: ["myjar"], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 318 | } |
| 319 | |
Jiyong Park | 30ca937 | 2019-02-07 16:27:23 +0900 | [diff] [blame] | 320 | apex { |
| 321 | name: "myapex", |
| 322 | defaults: ["myapex-defaults"], |
| 323 | } |
| 324 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 325 | apex_key { |
| 326 | name: "myapex.key", |
| 327 | public_key: "testkey.avbpubkey", |
| 328 | private_key: "testkey.pem", |
| 329 | } |
| 330 | |
Jiyong Park | 809bb72 | 2019-02-13 21:33:49 +0900 | [diff] [blame] | 331 | filegroup { |
| 332 | name: "myapex.manifest", |
| 333 | srcs: ["apex_manifest.json"], |
| 334 | } |
| 335 | |
| 336 | filegroup { |
| 337 | name: "myapex.androidmanifest", |
| 338 | srcs: ["AndroidManifest.xml"], |
| 339 | } |
| 340 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 341 | cc_library { |
| 342 | name: "mylib", |
| 343 | srcs: ["mylib.cpp"], |
| 344 | shared_libs: ["mylib2"], |
| 345 | system_shared_libs: [], |
| 346 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 347 | // TODO: remove //apex_available:platform |
| 348 | apex_available: [ |
| 349 | "//apex_available:platform", |
| 350 | "myapex", |
| 351 | ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 352 | } |
| 353 | |
Alex Light | 3d67359 | 2019-01-18 14:37:31 -0800 | [diff] [blame] | 354 | cc_binary { |
| 355 | name: "foo", |
| 356 | srcs: ["mylib.cpp"], |
| 357 | compile_multilib: "both", |
| 358 | multilib: { |
| 359 | lib32: { |
| 360 | suffix: "32", |
| 361 | }, |
| 362 | lib64: { |
| 363 | suffix: "64", |
| 364 | }, |
| 365 | }, |
| 366 | symlinks: ["foo_link_"], |
| 367 | symlink_preferred_arch: true, |
| 368 | system_shared_libs: [], |
| 369 | static_executable: true, |
| 370 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 371 | apex_available: [ "myapex" ], |
Alex Light | 3d67359 | 2019-01-18 14:37:31 -0800 | [diff] [blame] | 372 | } |
| 373 | |
Paul Duffin | dddd546 | 2020-04-07 15:25:44 +0100 | [diff] [blame] | 374 | cc_library_shared { |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 375 | name: "mylib2", |
| 376 | srcs: ["mylib.cpp"], |
| 377 | system_shared_libs: [], |
| 378 | stl: "none", |
Jiyong Park | 52818fc | 2019-03-18 12:01:38 +0900 | [diff] [blame] | 379 | notice: "custom_notice", |
Jiyong Park | 9918e1a | 2020-03-17 19:16:40 +0900 | [diff] [blame] | 380 | static_libs: ["libstatic"], |
| 381 | // TODO: remove //apex_available:platform |
| 382 | apex_available: [ |
| 383 | "//apex_available:platform", |
| 384 | "myapex", |
| 385 | ], |
| 386 | } |
| 387 | |
Paul Duffin | dddd546 | 2020-04-07 15:25:44 +0100 | [diff] [blame] | 388 | cc_prebuilt_library_shared { |
| 389 | name: "mylib2", |
| 390 | srcs: ["prebuilt.so"], |
| 391 | // TODO: remove //apex_available:platform |
| 392 | apex_available: [ |
| 393 | "//apex_available:platform", |
| 394 | "myapex", |
| 395 | ], |
| 396 | } |
| 397 | |
Jiyong Park | 9918e1a | 2020-03-17 19:16:40 +0900 | [diff] [blame] | 398 | cc_library_static { |
| 399 | name: "libstatic", |
| 400 | srcs: ["mylib.cpp"], |
| 401 | system_shared_libs: [], |
| 402 | stl: "none", |
| 403 | notice: "custom_notice_for_static_lib", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 404 | // TODO: remove //apex_available:platform |
| 405 | apex_available: [ |
| 406 | "//apex_available:platform", |
| 407 | "myapex", |
| 408 | ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 409 | } |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 410 | |
| 411 | java_library { |
| 412 | name: "myjar", |
| 413 | srcs: ["foo/bar/MyClass.java"], |
| 414 | sdk_version: "none", |
| 415 | system_modules: "none", |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 416 | static_libs: ["myotherjar"], |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 417 | libs: ["mysharedjar"], |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 418 | // TODO: remove //apex_available:platform |
| 419 | apex_available: [ |
| 420 | "//apex_available:platform", |
| 421 | "myapex", |
| 422 | ], |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 423 | } |
| 424 | |
| 425 | java_library { |
| 426 | name: "myotherjar", |
| 427 | srcs: ["foo/bar/MyClass.java"], |
| 428 | sdk_version: "none", |
| 429 | system_modules: "none", |
Jiyong Park | 0f80c18 | 2020-01-31 02:49:53 +0900 | [diff] [blame] | 430 | // TODO: remove //apex_available:platform |
| 431 | apex_available: [ |
| 432 | "//apex_available:platform", |
| 433 | "myapex", |
| 434 | ], |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 435 | } |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 436 | |
| 437 | java_library { |
| 438 | name: "mysharedjar", |
| 439 | srcs: ["foo/bar/MyClass.java"], |
| 440 | sdk_version: "none", |
| 441 | system_modules: "none", |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 442 | } |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 443 | `) |
| 444 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 445 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Jiyong Park | 42cca6c | 2019-04-01 11:15:50 +0900 | [diff] [blame] | 446 | |
| 447 | optFlags := apexRule.Args["opt_flags"] |
| 448 | ensureContains(t, optFlags, "--pubkey vendor/foo/devkeys/testkey.avbpubkey") |
Jaewoong Jung | 14f5ff6 | 2019-06-18 13:09:13 -0700 | [diff] [blame] | 449 | // Ensure that the NOTICE output is being packaged as an asset. |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 450 | ensureContains(t, optFlags, "--assets_dir "+buildDir+"/.intermediates/myapex/android_common_myapex_image/NOTICE") |
Jiyong Park | 42cca6c | 2019-04-01 11:15:50 +0900 | [diff] [blame] | 451 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 452 | copyCmds := apexRule.Args["copy_commands"] |
| 453 | |
| 454 | // Ensure that main rule creates an output |
| 455 | ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned") |
| 456 | |
| 457 | // Ensure that apex variant is created for the direct dep |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 458 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_myapex") |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 459 | ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common_myapex") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 460 | |
| 461 | // Ensure that apex variant is created for the indirect dep |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 462 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_myapex") |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 463 | ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common_myapex") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 464 | |
| 465 | // Ensure that both direct and indirect deps are copied into apex |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 466 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
| 467 | ensureContains(t, copyCmds, "image.apex/lib64/mylib2.so") |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 468 | ensureContains(t, copyCmds, "image.apex/javalib/myjar.jar") |
| 469 | // .. but not for java libs |
| 470 | ensureNotContains(t, copyCmds, "image.apex/javalib/myotherjar.jar") |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 471 | ensureNotContains(t, copyCmds, "image.apex/javalib/msharedjar.jar") |
Logan Chien | 3aeedc9 | 2018-12-26 15:32:21 +0800 | [diff] [blame] | 472 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 473 | // Ensure that the platform variant ends with _shared or _common |
| 474 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared") |
| 475 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared") |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 476 | ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common") |
| 477 | ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common") |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 478 | ensureListContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common") |
| 479 | |
| 480 | // Ensure that dynamic dependency to java libs are not included |
| 481 | ensureListNotContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common_myapex") |
Alex Light | 3d67359 | 2019-01-18 14:37:31 -0800 | [diff] [blame] | 482 | |
| 483 | // Ensure that all symlinks are present. |
| 484 | found_foo_link_64 := false |
| 485 | found_foo := false |
| 486 | for _, cmd := range strings.Split(copyCmds, " && ") { |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 487 | if strings.HasPrefix(cmd, "ln -sfn foo64") { |
Alex Light | 3d67359 | 2019-01-18 14:37:31 -0800 | [diff] [blame] | 488 | if strings.HasSuffix(cmd, "bin/foo") { |
| 489 | found_foo = true |
| 490 | } else if strings.HasSuffix(cmd, "bin/foo_link_64") { |
| 491 | found_foo_link_64 = true |
| 492 | } |
| 493 | } |
| 494 | } |
| 495 | good := found_foo && found_foo_link_64 |
| 496 | if !good { |
| 497 | t.Errorf("Could not find all expected symlinks! foo: %t, foo_link_64: %t. Command was %s", found_foo, found_foo_link_64, copyCmds) |
| 498 | } |
Jiyong Park | 52818fc | 2019-03-18 12:01:38 +0900 | [diff] [blame] | 499 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 500 | mergeNoticesRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("mergeNoticesRule") |
Jaewoong Jung | 5b425e2 | 2019-06-17 17:40:56 -0700 | [diff] [blame] | 501 | noticeInputs := mergeNoticesRule.Inputs.Strings() |
Jiyong Park | 9918e1a | 2020-03-17 19:16:40 +0900 | [diff] [blame] | 502 | if len(noticeInputs) != 3 { |
| 503 | t.Errorf("number of input notice files: expected = 3, actual = %q", len(noticeInputs)) |
Jiyong Park | 52818fc | 2019-03-18 12:01:38 +0900 | [diff] [blame] | 504 | } |
| 505 | ensureListContains(t, noticeInputs, "NOTICE") |
| 506 | ensureListContains(t, noticeInputs, "custom_notice") |
Jiyong Park | 9918e1a | 2020-03-17 19:16:40 +0900 | [diff] [blame] | 507 | ensureListContains(t, noticeInputs, "custom_notice_for_static_lib") |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 508 | |
Artur Satayev | a8bd113 | 2020-04-27 18:07:06 +0100 | [diff] [blame] | 509 | fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n") |
Artur Satayev | 480e25b | 2020-04-27 18:53:18 +0100 | [diff] [blame] | 510 | ensureListContains(t, fullDepsInfo, "myjar(minSdkVersion:(no version)) <- myapex") |
| 511 | ensureListContains(t, fullDepsInfo, "mylib(minSdkVersion:(no version)) <- myapex") |
| 512 | ensureListContains(t, fullDepsInfo, "mylib2(minSdkVersion:(no version)) <- mylib") |
| 513 | ensureListContains(t, fullDepsInfo, "myotherjar(minSdkVersion:(no version)) <- myjar") |
| 514 | ensureListContains(t, fullDepsInfo, "mysharedjar(minSdkVersion:(no version)) (external) <- myjar") |
Artur Satayev | a8bd113 | 2020-04-27 18:07:06 +0100 | [diff] [blame] | 515 | |
| 516 | flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n") |
Artur Satayev | 480e25b | 2020-04-27 18:53:18 +0100 | [diff] [blame] | 517 | ensureListContains(t, flatDepsInfo, " myjar(minSdkVersion:(no version))") |
| 518 | ensureListContains(t, flatDepsInfo, " mylib(minSdkVersion:(no version))") |
| 519 | ensureListContains(t, flatDepsInfo, " mylib2(minSdkVersion:(no version))") |
| 520 | ensureListContains(t, flatDepsInfo, " myotherjar(minSdkVersion:(no version))") |
| 521 | ensureListContains(t, flatDepsInfo, " mysharedjar(minSdkVersion:(no version)) (external)") |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 522 | } |
| 523 | |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 524 | func TestDefaults(t *testing.T) { |
| 525 | ctx, _ := testApex(t, ` |
| 526 | apex_defaults { |
| 527 | name: "myapex-defaults", |
| 528 | key: "myapex.key", |
| 529 | prebuilts: ["myetc"], |
| 530 | native_shared_libs: ["mylib"], |
| 531 | java_libs: ["myjar"], |
| 532 | apps: ["AppFoo"], |
Jiyong Park | 69aeba9 | 2020-04-24 21:16:36 +0900 | [diff] [blame] | 533 | rros: ["rro"], |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 534 | } |
| 535 | |
| 536 | prebuilt_etc { |
| 537 | name: "myetc", |
| 538 | src: "myprebuilt", |
| 539 | } |
| 540 | |
| 541 | apex { |
| 542 | name: "myapex", |
| 543 | defaults: ["myapex-defaults"], |
| 544 | } |
| 545 | |
| 546 | apex_key { |
| 547 | name: "myapex.key", |
| 548 | public_key: "testkey.avbpubkey", |
| 549 | private_key: "testkey.pem", |
| 550 | } |
| 551 | |
| 552 | cc_library { |
| 553 | name: "mylib", |
| 554 | system_shared_libs: [], |
| 555 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 556 | apex_available: [ "myapex" ], |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 557 | } |
| 558 | |
| 559 | java_library { |
| 560 | name: "myjar", |
| 561 | srcs: ["foo/bar/MyClass.java"], |
| 562 | sdk_version: "none", |
| 563 | system_modules: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 564 | apex_available: [ "myapex" ], |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 565 | } |
| 566 | |
| 567 | android_app { |
| 568 | name: "AppFoo", |
| 569 | srcs: ["foo/bar/MyClass.java"], |
| 570 | sdk_version: "none", |
| 571 | system_modules: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 572 | apex_available: [ "myapex" ], |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 573 | } |
Jiyong Park | 69aeba9 | 2020-04-24 21:16:36 +0900 | [diff] [blame] | 574 | |
| 575 | runtime_resource_overlay { |
| 576 | name: "rro", |
| 577 | theme: "blue", |
| 578 | } |
| 579 | |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 580 | `) |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 581 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 582 | "etc/myetc", |
| 583 | "javalib/myjar.jar", |
| 584 | "lib64/mylib.so", |
| 585 | "app/AppFoo/AppFoo.apk", |
Jiyong Park | 69aeba9 | 2020-04-24 21:16:36 +0900 | [diff] [blame] | 586 | "overlay/blue/rro.apk", |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 587 | }) |
| 588 | } |
| 589 | |
Jooyung Han | 01a3ee2 | 2019-11-02 02:52:25 +0900 | [diff] [blame] | 590 | func TestApexManifest(t *testing.T) { |
| 591 | ctx, _ := testApex(t, ` |
| 592 | apex { |
| 593 | name: "myapex", |
| 594 | key: "myapex.key", |
| 595 | } |
| 596 | |
| 597 | apex_key { |
| 598 | name: "myapex.key", |
| 599 | public_key: "testkey.avbpubkey", |
| 600 | private_key: "testkey.pem", |
| 601 | } |
| 602 | `) |
| 603 | |
| 604 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 605 | args := module.Rule("apexRule").Args |
| 606 | if manifest := args["manifest"]; manifest != module.Output("apex_manifest.pb").Output.String() { |
| 607 | t.Error("manifest should be apex_manifest.pb, but " + manifest) |
| 608 | } |
Jooyung Han | 01a3ee2 | 2019-11-02 02:52:25 +0900 | [diff] [blame] | 609 | } |
| 610 | |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 611 | func TestBasicZipApex(t *testing.T) { |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 612 | ctx, _ := testApex(t, ` |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 613 | apex { |
| 614 | name: "myapex", |
| 615 | key: "myapex.key", |
| 616 | payload_type: "zip", |
| 617 | native_shared_libs: ["mylib"], |
| 618 | } |
| 619 | |
| 620 | apex_key { |
| 621 | name: "myapex.key", |
| 622 | public_key: "testkey.avbpubkey", |
| 623 | private_key: "testkey.pem", |
| 624 | } |
| 625 | |
| 626 | cc_library { |
| 627 | name: "mylib", |
| 628 | srcs: ["mylib.cpp"], |
| 629 | shared_libs: ["mylib2"], |
| 630 | system_shared_libs: [], |
| 631 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 632 | apex_available: [ "myapex" ], |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 633 | } |
| 634 | |
| 635 | cc_library { |
| 636 | name: "mylib2", |
| 637 | srcs: ["mylib.cpp"], |
| 638 | system_shared_libs: [], |
| 639 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 640 | apex_available: [ "myapex" ], |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 641 | } |
| 642 | `) |
| 643 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 644 | zipApexRule := ctx.ModuleForTests("myapex", "android_common_myapex_zip").Rule("zipApexRule") |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 645 | copyCmds := zipApexRule.Args["copy_commands"] |
| 646 | |
| 647 | // Ensure that main rule creates an output |
| 648 | ensureContains(t, zipApexRule.Output.String(), "myapex.zipapex.unsigned") |
| 649 | |
| 650 | // Ensure that APEX variant is created for the direct dep |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 651 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_myapex") |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 652 | |
| 653 | // Ensure that APEX variant is created for the indirect dep |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 654 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_myapex") |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 655 | |
| 656 | // Ensure that both direct and indirect deps are copied into apex |
| 657 | ensureContains(t, copyCmds, "image.zipapex/lib64/mylib.so") |
| 658 | ensureContains(t, copyCmds, "image.zipapex/lib64/mylib2.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 659 | } |
| 660 | |
| 661 | func TestApexWithStubs(t *testing.T) { |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 662 | ctx, _ := testApex(t, ` |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 663 | apex { |
| 664 | name: "myapex", |
| 665 | key: "myapex.key", |
| 666 | native_shared_libs: ["mylib", "mylib3"], |
| 667 | } |
| 668 | |
| 669 | apex_key { |
| 670 | name: "myapex.key", |
| 671 | public_key: "testkey.avbpubkey", |
| 672 | private_key: "testkey.pem", |
| 673 | } |
| 674 | |
| 675 | cc_library { |
| 676 | name: "mylib", |
| 677 | srcs: ["mylib.cpp"], |
| 678 | shared_libs: ["mylib2", "mylib3"], |
| 679 | system_shared_libs: [], |
| 680 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 681 | apex_available: [ "myapex" ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 682 | } |
| 683 | |
| 684 | cc_library { |
| 685 | name: "mylib2", |
| 686 | srcs: ["mylib.cpp"], |
Jiyong Park | 6437995 | 2018-12-13 18:37:29 +0900 | [diff] [blame] | 687 | cflags: ["-include mylib.h"], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 688 | system_shared_libs: [], |
| 689 | stl: "none", |
| 690 | stubs: { |
| 691 | versions: ["1", "2", "3"], |
| 692 | }, |
| 693 | } |
| 694 | |
| 695 | cc_library { |
| 696 | name: "mylib3", |
Jiyong Park | 28d395a | 2018-12-07 22:42:47 +0900 | [diff] [blame] | 697 | srcs: ["mylib.cpp"], |
| 698 | shared_libs: ["mylib4"], |
| 699 | system_shared_libs: [], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 700 | stl: "none", |
| 701 | stubs: { |
| 702 | versions: ["10", "11", "12"], |
| 703 | }, |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 704 | apex_available: [ "myapex" ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 705 | } |
Jiyong Park | 28d395a | 2018-12-07 22:42:47 +0900 | [diff] [blame] | 706 | |
| 707 | cc_library { |
| 708 | name: "mylib4", |
| 709 | srcs: ["mylib.cpp"], |
| 710 | system_shared_libs: [], |
| 711 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 712 | apex_available: [ "myapex" ], |
Jiyong Park | 28d395a | 2018-12-07 22:42:47 +0900 | [diff] [blame] | 713 | } |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 714 | `) |
| 715 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 716 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 717 | copyCmds := apexRule.Args["copy_commands"] |
| 718 | |
| 719 | // Ensure that direct non-stubs dep is always included |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 720 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 721 | |
| 722 | // Ensure that indirect stubs dep is not included |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 723 | ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 724 | |
| 725 | // Ensure that direct stubs dep is included |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 726 | ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 727 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 728 | mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_myapex").Rule("ld").Args["libFlags"] |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 729 | |
| 730 | // Ensure that mylib is linking with the latest version of stubs for mylib2 |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 731 | ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_3/mylib2.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 732 | // ... and not linking to the non-stub (impl) variant of mylib2 |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 733 | ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 734 | |
| 735 | // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex) |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 736 | ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_myapex/mylib3.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 737 | // .. and not linking to the stubs variant of mylib3 |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 738 | ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_12_myapex/mylib3.so") |
Jiyong Park | 6437995 | 2018-12-13 18:37:29 +0900 | [diff] [blame] | 739 | |
| 740 | // Ensure that stubs libs are built without -include flags |
Jiyong Park | 0f80c18 | 2020-01-31 02:49:53 +0900 | [diff] [blame] | 741 | mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
Jiyong Park | 6437995 | 2018-12-13 18:37:29 +0900 | [diff] [blame] | 742 | ensureNotContains(t, mylib2Cflags, "-include ") |
Jiyong Park | 3fd0baf | 2018-12-07 16:25:39 +0900 | [diff] [blame] | 743 | |
| 744 | // Ensure that genstub is invoked with --apex |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 745 | ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_3").Rule("genStubSrc").Args["flags"]) |
Jooyung Han | 671f1ce | 2019-12-17 12:47:13 +0900 | [diff] [blame] | 746 | |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 747 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
Jooyung Han | 671f1ce | 2019-12-17 12:47:13 +0900 | [diff] [blame] | 748 | "lib64/mylib.so", |
| 749 | "lib64/mylib3.so", |
| 750 | "lib64/mylib4.so", |
| 751 | }) |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 752 | } |
| 753 | |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 754 | func TestApexWithExplicitStubsDependency(t *testing.T) { |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 755 | ctx, _ := testApex(t, ` |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 756 | apex { |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 757 | name: "myapex2", |
| 758 | key: "myapex2.key", |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 759 | native_shared_libs: ["mylib"], |
| 760 | } |
| 761 | |
| 762 | apex_key { |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 763 | name: "myapex2.key", |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 764 | public_key: "testkey.avbpubkey", |
| 765 | private_key: "testkey.pem", |
| 766 | } |
| 767 | |
| 768 | cc_library { |
| 769 | name: "mylib", |
| 770 | srcs: ["mylib.cpp"], |
| 771 | shared_libs: ["libfoo#10"], |
Jiyong Park | 678c881 | 2020-02-07 17:25:49 +0900 | [diff] [blame] | 772 | static_libs: ["libbaz"], |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 773 | system_shared_libs: [], |
| 774 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 775 | apex_available: [ "myapex2" ], |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 776 | } |
| 777 | |
| 778 | cc_library { |
| 779 | name: "libfoo", |
| 780 | srcs: ["mylib.cpp"], |
| 781 | shared_libs: ["libbar"], |
| 782 | system_shared_libs: [], |
| 783 | stl: "none", |
| 784 | stubs: { |
| 785 | versions: ["10", "20", "30"], |
| 786 | }, |
| 787 | } |
| 788 | |
| 789 | cc_library { |
| 790 | name: "libbar", |
| 791 | srcs: ["mylib.cpp"], |
| 792 | system_shared_libs: [], |
| 793 | stl: "none", |
| 794 | } |
| 795 | |
Jiyong Park | 678c881 | 2020-02-07 17:25:49 +0900 | [diff] [blame] | 796 | cc_library_static { |
| 797 | name: "libbaz", |
| 798 | srcs: ["mylib.cpp"], |
| 799 | system_shared_libs: [], |
| 800 | stl: "none", |
| 801 | apex_available: [ "myapex2" ], |
| 802 | } |
| 803 | |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 804 | `) |
| 805 | |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 806 | apexRule := ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Rule("apexRule") |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 807 | copyCmds := apexRule.Args["copy_commands"] |
| 808 | |
| 809 | // Ensure that direct non-stubs dep is always included |
| 810 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
| 811 | |
| 812 | // Ensure that indirect stubs dep is not included |
| 813 | ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so") |
| 814 | |
| 815 | // Ensure that dependency of stubs is not included |
| 816 | ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so") |
| 817 | |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 818 | mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_myapex2").Rule("ld").Args["libFlags"] |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 819 | |
| 820 | // Ensure that mylib is linking with version 10 of libfoo |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 821 | ensureContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared_10/libfoo.so") |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 822 | // ... and not linking to the non-stub (impl) variant of libfoo |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 823 | ensureNotContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared/libfoo.so") |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 824 | |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 825 | libFooStubsLdFlags := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_10").Rule("ld").Args["libFlags"] |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 826 | |
| 827 | // Ensure that libfoo stubs is not linking to libbar (since it is a stubs) |
| 828 | ensureNotContains(t, libFooStubsLdFlags, "libbar.so") |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 829 | |
Artur Satayev | a8bd113 | 2020-04-27 18:07:06 +0100 | [diff] [blame] | 830 | fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n") |
Artur Satayev | 480e25b | 2020-04-27 18:53:18 +0100 | [diff] [blame] | 831 | ensureListContains(t, fullDepsInfo, "mylib(minSdkVersion:(no version)) <- myapex2") |
| 832 | ensureListContains(t, fullDepsInfo, "libbaz(minSdkVersion:(no version)) <- mylib") |
| 833 | ensureListContains(t, fullDepsInfo, "libfoo(minSdkVersion:(no version)) (external) <- mylib") |
Jiyong Park | 678c881 | 2020-02-07 17:25:49 +0900 | [diff] [blame] | 834 | |
Artur Satayev | a8bd113 | 2020-04-27 18:07:06 +0100 | [diff] [blame] | 835 | flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n") |
Artur Satayev | 480e25b | 2020-04-27 18:53:18 +0100 | [diff] [blame] | 836 | ensureListContains(t, flatDepsInfo, " mylib(minSdkVersion:(no version))") |
| 837 | ensureListContains(t, flatDepsInfo, " libbaz(minSdkVersion:(no version))") |
| 838 | ensureListContains(t, flatDepsInfo, " libfoo(minSdkVersion:(no version)) (external)") |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 839 | } |
| 840 | |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 841 | func TestApexWithRuntimeLibsDependency(t *testing.T) { |
| 842 | /* |
| 843 | myapex |
| 844 | | |
| 845 | v (runtime_libs) |
| 846 | mylib ------+------> libfoo [provides stub] |
| 847 | | |
| 848 | `------> libbar |
| 849 | */ |
| 850 | ctx, _ := testApex(t, ` |
| 851 | apex { |
| 852 | name: "myapex", |
| 853 | key: "myapex.key", |
| 854 | native_shared_libs: ["mylib"], |
| 855 | } |
| 856 | |
| 857 | apex_key { |
| 858 | name: "myapex.key", |
| 859 | public_key: "testkey.avbpubkey", |
| 860 | private_key: "testkey.pem", |
| 861 | } |
| 862 | |
| 863 | cc_library { |
| 864 | name: "mylib", |
| 865 | srcs: ["mylib.cpp"], |
| 866 | runtime_libs: ["libfoo", "libbar"], |
| 867 | system_shared_libs: [], |
| 868 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 869 | apex_available: [ "myapex" ], |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 870 | } |
| 871 | |
| 872 | cc_library { |
| 873 | name: "libfoo", |
| 874 | srcs: ["mylib.cpp"], |
| 875 | system_shared_libs: [], |
| 876 | stl: "none", |
| 877 | stubs: { |
| 878 | versions: ["10", "20", "30"], |
| 879 | }, |
| 880 | } |
| 881 | |
| 882 | cc_library { |
| 883 | name: "libbar", |
| 884 | srcs: ["mylib.cpp"], |
| 885 | system_shared_libs: [], |
| 886 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 887 | apex_available: [ "myapex" ], |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 888 | } |
| 889 | |
| 890 | `) |
| 891 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 892 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 893 | copyCmds := apexRule.Args["copy_commands"] |
| 894 | |
| 895 | // Ensure that direct non-stubs dep is always included |
| 896 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
| 897 | |
| 898 | // Ensure that indirect stubs dep is not included |
| 899 | ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so") |
| 900 | |
| 901 | // Ensure that runtime_libs dep in included |
| 902 | ensureContains(t, copyCmds, "image.apex/lib64/libbar.so") |
| 903 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 904 | apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 905 | ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"])) |
| 906 | ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.so") |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 907 | |
| 908 | } |
| 909 | |
Jooyung Han | 8ce8db9 | 2020-05-15 19:05:05 +0900 | [diff] [blame^] | 910 | func TestRuntimeApexShouldInstallHwasanIfLibcDependsOnIt(t *testing.T) { |
| 911 | ctx, _ := testApex(t, "", func(fs map[string][]byte, config android.Config) { |
| 912 | bp := ` |
| 913 | apex { |
| 914 | name: "com.android.runtime", |
| 915 | key: "com.android.runtime.key", |
| 916 | native_shared_libs: ["libc"], |
| 917 | } |
| 918 | |
| 919 | apex_key { |
| 920 | name: "com.android.runtime.key", |
| 921 | public_key: "testkey.avbpubkey", |
| 922 | private_key: "testkey.pem", |
| 923 | } |
| 924 | |
| 925 | cc_library { |
| 926 | name: "libc", |
| 927 | no_libcrt: true, |
| 928 | nocrt: true, |
| 929 | stl: "none", |
| 930 | system_shared_libs: [], |
| 931 | stubs: { versions: ["1"] }, |
| 932 | apex_available: ["com.android.runtime"], |
| 933 | |
| 934 | sanitize: { |
| 935 | hwaddress: true, |
| 936 | } |
| 937 | } |
| 938 | |
| 939 | cc_prebuilt_library_shared { |
| 940 | name: "libclang_rt.hwasan-aarch64-android", |
| 941 | no_libcrt: true, |
| 942 | nocrt: true, |
| 943 | stl: "none", |
| 944 | system_shared_libs: [], |
| 945 | srcs: [""], |
| 946 | stubs: { versions: ["1"] }, |
| 947 | |
| 948 | sanitize: { |
| 949 | never: true, |
| 950 | }, |
| 951 | } |
| 952 | ` |
| 953 | // override bp to use hard-coded names: com.android.runtime and libc |
| 954 | fs["Android.bp"] = []byte(bp) |
| 955 | fs["system/sepolicy/apex/com.android.runtime-file_contexts"] = nil |
| 956 | }) |
| 957 | |
| 958 | ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{ |
| 959 | "lib64/bionic/libc.so", |
| 960 | "lib64/bionic/libclang_rt.hwasan-aarch64-android.so", |
| 961 | }) |
| 962 | |
| 963 | hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared") |
| 964 | |
| 965 | installed := hwasan.Description("install libclang_rt.hwasan") |
| 966 | ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so") |
| 967 | |
| 968 | symlink := hwasan.Description("install symlink libclang_rt.hwasan") |
| 969 | ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so") |
| 970 | ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so") |
| 971 | } |
| 972 | |
| 973 | func TestRuntimeApexShouldInstallHwasanIfHwaddressSanitized(t *testing.T) { |
| 974 | ctx, _ := testApex(t, "", func(fs map[string][]byte, config android.Config) { |
| 975 | bp := ` |
| 976 | apex { |
| 977 | name: "com.android.runtime", |
| 978 | key: "com.android.runtime.key", |
| 979 | native_shared_libs: ["libc"], |
| 980 | } |
| 981 | |
| 982 | apex_key { |
| 983 | name: "com.android.runtime.key", |
| 984 | public_key: "testkey.avbpubkey", |
| 985 | private_key: "testkey.pem", |
| 986 | } |
| 987 | |
| 988 | cc_library { |
| 989 | name: "libc", |
| 990 | no_libcrt: true, |
| 991 | nocrt: true, |
| 992 | stl: "none", |
| 993 | system_shared_libs: [], |
| 994 | stubs: { versions: ["1"] }, |
| 995 | apex_available: ["com.android.runtime"], |
| 996 | } |
| 997 | |
| 998 | cc_prebuilt_library_shared { |
| 999 | name: "libclang_rt.hwasan-aarch64-android", |
| 1000 | no_libcrt: true, |
| 1001 | nocrt: true, |
| 1002 | stl: "none", |
| 1003 | system_shared_libs: [], |
| 1004 | srcs: [""], |
| 1005 | stubs: { versions: ["1"] }, |
| 1006 | |
| 1007 | sanitize: { |
| 1008 | never: true, |
| 1009 | }, |
| 1010 | } |
| 1011 | ` |
| 1012 | // override bp to use hard-coded names: com.android.runtime and libc |
| 1013 | fs["Android.bp"] = []byte(bp) |
| 1014 | fs["system/sepolicy/apex/com.android.runtime-file_contexts"] = nil |
| 1015 | |
| 1016 | config.TestProductVariables.SanitizeDevice = []string{"hwaddress"} |
| 1017 | }) |
| 1018 | |
| 1019 | ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{ |
| 1020 | "lib64/bionic/libc.so", |
| 1021 | "lib64/bionic/libclang_rt.hwasan-aarch64-android.so", |
| 1022 | }) |
| 1023 | |
| 1024 | hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared") |
| 1025 | |
| 1026 | installed := hwasan.Description("install libclang_rt.hwasan") |
| 1027 | ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so") |
| 1028 | |
| 1029 | symlink := hwasan.Description("install symlink libclang_rt.hwasan") |
| 1030 | ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so") |
| 1031 | ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so") |
| 1032 | } |
| 1033 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1034 | func TestApexDependsOnLLNDKTransitively(t *testing.T) { |
| 1035 | testcases := []struct { |
| 1036 | name string |
| 1037 | minSdkVersion string |
| 1038 | shouldLink string |
| 1039 | shouldNotLink []string |
| 1040 | }{ |
| 1041 | { |
Jooyung Han | 7556839 | 2020-03-20 04:29:24 +0900 | [diff] [blame] | 1042 | name: "should link to the latest", |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1043 | minSdkVersion: "current", |
| 1044 | shouldLink: "30", |
| 1045 | shouldNotLink: []string{"29"}, |
| 1046 | }, |
| 1047 | { |
| 1048 | name: "should link to llndk#29", |
| 1049 | minSdkVersion: "29", |
| 1050 | shouldLink: "29", |
| 1051 | shouldNotLink: []string{"30"}, |
| 1052 | }, |
| 1053 | } |
| 1054 | for _, tc := range testcases { |
| 1055 | t.Run(tc.name, func(t *testing.T) { |
| 1056 | ctx, _ := testApex(t, ` |
| 1057 | apex { |
| 1058 | name: "myapex", |
| 1059 | key: "myapex.key", |
| 1060 | use_vendor: true, |
| 1061 | native_shared_libs: ["mylib"], |
| 1062 | min_sdk_version: "`+tc.minSdkVersion+`", |
| 1063 | } |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1064 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1065 | apex_key { |
| 1066 | name: "myapex.key", |
| 1067 | public_key: "testkey.avbpubkey", |
| 1068 | private_key: "testkey.pem", |
| 1069 | } |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1070 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1071 | cc_library { |
| 1072 | name: "mylib", |
| 1073 | srcs: ["mylib.cpp"], |
| 1074 | vendor_available: true, |
| 1075 | shared_libs: ["libbar"], |
| 1076 | system_shared_libs: [], |
| 1077 | stl: "none", |
| 1078 | apex_available: [ "myapex" ], |
| 1079 | } |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1080 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1081 | cc_library { |
| 1082 | name: "libbar", |
| 1083 | srcs: ["mylib.cpp"], |
| 1084 | system_shared_libs: [], |
| 1085 | stl: "none", |
| 1086 | stubs: { versions: ["29","30"] }, |
| 1087 | } |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1088 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1089 | llndk_library { |
| 1090 | name: "libbar", |
| 1091 | symbol_file: "", |
| 1092 | } |
| 1093 | `, func(fs map[string][]byte, config android.Config) { |
| 1094 | setUseVendorWhitelistForTest(config, []string{"myapex"}) |
| 1095 | }, withUnbundledBuild) |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1096 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1097 | // Ensure that LLNDK dep is not included |
| 1098 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 1099 | "lib64/mylib.so", |
| 1100 | }) |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1101 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1102 | // Ensure that LLNDK dep is required |
| 1103 | apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule") |
| 1104 | ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"])) |
| 1105 | ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libbar.so") |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1106 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1107 | mylibLdFlags := ctx.ModuleForTests("mylib", "android_vendor.VER_arm64_armv8-a_shared_myapex").Rule("ld").Args["libFlags"] |
| 1108 | ensureContains(t, mylibLdFlags, "libbar.llndk/android_vendor.VER_arm64_armv8-a_shared_"+tc.shouldLink+"/libbar.so") |
| 1109 | for _, ver := range tc.shouldNotLink { |
| 1110 | ensureNotContains(t, mylibLdFlags, "libbar.llndk/android_vendor.VER_arm64_armv8-a_shared_"+ver+"/libbar.so") |
| 1111 | } |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1112 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1113 | mylibCFlags := ctx.ModuleForTests("mylib", "android_vendor.VER_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"] |
| 1114 | ensureContains(t, mylibCFlags, "__LIBBAR_API__="+tc.shouldLink) |
| 1115 | }) |
| 1116 | } |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1117 | } |
| 1118 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1119 | func TestApexWithSystemLibsStubs(t *testing.T) { |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 1120 | ctx, _ := testApex(t, ` |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1121 | apex { |
| 1122 | name: "myapex", |
| 1123 | key: "myapex.key", |
| 1124 | native_shared_libs: ["mylib", "mylib_shared", "libdl", "libm"], |
| 1125 | } |
| 1126 | |
| 1127 | apex_key { |
| 1128 | name: "myapex.key", |
| 1129 | public_key: "testkey.avbpubkey", |
| 1130 | private_key: "testkey.pem", |
| 1131 | } |
| 1132 | |
| 1133 | cc_library { |
| 1134 | name: "mylib", |
| 1135 | srcs: ["mylib.cpp"], |
| 1136 | shared_libs: ["libdl#27"], |
| 1137 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 1138 | apex_available: [ "myapex" ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1139 | } |
| 1140 | |
| 1141 | cc_library_shared { |
| 1142 | name: "mylib_shared", |
| 1143 | srcs: ["mylib.cpp"], |
| 1144 | shared_libs: ["libdl#27"], |
| 1145 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 1146 | apex_available: [ "myapex" ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1147 | } |
| 1148 | |
| 1149 | cc_library { |
Jiyong Park | b078857 | 2018-12-20 22:10:17 +0900 | [diff] [blame] | 1150 | name: "libBootstrap", |
| 1151 | srcs: ["mylib.cpp"], |
| 1152 | stl: "none", |
| 1153 | bootstrap: true, |
| 1154 | } |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1155 | `) |
| 1156 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 1157 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1158 | copyCmds := apexRule.Args["copy_commands"] |
| 1159 | |
| 1160 | // Ensure that mylib, libm, libdl are included. |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 1161 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
Jiyong Park | b078857 | 2018-12-20 22:10:17 +0900 | [diff] [blame] | 1162 | ensureContains(t, copyCmds, "image.apex/lib64/bionic/libm.so") |
| 1163 | ensureContains(t, copyCmds, "image.apex/lib64/bionic/libdl.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1164 | |
| 1165 | // Ensure that libc is not included (since it has stubs and not listed in native_shared_libs) |
Jiyong Park | b078857 | 2018-12-20 22:10:17 +0900 | [diff] [blame] | 1166 | ensureNotContains(t, copyCmds, "image.apex/lib64/bionic/libc.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1167 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 1168 | mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_myapex").Rule("ld").Args["libFlags"] |
| 1169 | mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"] |
| 1170 | mylibSharedCFlags := ctx.ModuleForTests("mylib_shared", "android_arm64_armv8-a_shared_myapex").Rule("cc").Args["cFlags"] |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1171 | |
| 1172 | // For dependency to libc |
| 1173 | // Ensure that mylib is linking with the latest version of stubs |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 1174 | ensureContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared_29/libc.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1175 | // ... and not linking to the non-stub (impl) variant |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 1176 | ensureNotContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared/libc.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1177 | // ... Cflags from stub is correctly exported to mylib |
| 1178 | ensureContains(t, mylibCFlags, "__LIBC_API__=29") |
| 1179 | ensureContains(t, mylibSharedCFlags, "__LIBC_API__=29") |
| 1180 | |
| 1181 | // For dependency to libm |
| 1182 | // Ensure that mylib is linking with the non-stub (impl) variant |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 1183 | ensureContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_myapex/libm.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1184 | // ... and not linking to the stub variant |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 1185 | ensureNotContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_29/libm.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1186 | // ... and is not compiling with the stub |
| 1187 | ensureNotContains(t, mylibCFlags, "__LIBM_API__=29") |
| 1188 | ensureNotContains(t, mylibSharedCFlags, "__LIBM_API__=29") |
| 1189 | |
| 1190 | // For dependency to libdl |
| 1191 | // Ensure that mylib is linking with the specified version of stubs |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 1192 | ensureContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_27/libdl.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1193 | // ... and not linking to the other versions of stubs |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 1194 | ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_28/libdl.so") |
| 1195 | ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_29/libdl.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1196 | // ... and not linking to the non-stub (impl) variant |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 1197 | ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_myapex/libdl.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1198 | // ... Cflags from stub is correctly exported to mylib |
| 1199 | ensureContains(t, mylibCFlags, "__LIBDL_API__=27") |
| 1200 | ensureContains(t, mylibSharedCFlags, "__LIBDL_API__=27") |
Jiyong Park | b078857 | 2018-12-20 22:10:17 +0900 | [diff] [blame] | 1201 | |
| 1202 | // Ensure that libBootstrap is depending on the platform variant of bionic libs |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 1203 | libFlags := ctx.ModuleForTests("libBootstrap", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"] |
| 1204 | ensureContains(t, libFlags, "libc/android_arm64_armv8-a_shared/libc.so") |
| 1205 | ensureContains(t, libFlags, "libm/android_arm64_armv8-a_shared/libm.so") |
| 1206 | ensureContains(t, libFlags, "libdl/android_arm64_armv8-a_shared/libdl.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1207 | } |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 1208 | |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1209 | func TestApexUseStubsAccordingToMinSdkVersionInUnbundledBuild(t *testing.T) { |
| 1210 | // there are three links between liba --> libz |
| 1211 | // 1) myapex -> libx -> liba -> libz : this should be #2 link, but fallback to #1 |
| 1212 | // 2) otherapex -> liby -> liba -> libz : this should be #3 link |
| 1213 | // 3) (platform) -> liba -> libz : this should be non-stub link |
| 1214 | ctx, _ := testApex(t, ` |
| 1215 | apex { |
| 1216 | name: "myapex", |
| 1217 | key: "myapex.key", |
| 1218 | native_shared_libs: ["libx"], |
| 1219 | min_sdk_version: "2", |
| 1220 | } |
| 1221 | |
| 1222 | apex { |
| 1223 | name: "otherapex", |
| 1224 | key: "myapex.key", |
| 1225 | native_shared_libs: ["liby"], |
| 1226 | min_sdk_version: "3", |
| 1227 | } |
| 1228 | |
| 1229 | apex_key { |
| 1230 | name: "myapex.key", |
| 1231 | public_key: "testkey.avbpubkey", |
| 1232 | private_key: "testkey.pem", |
| 1233 | } |
| 1234 | |
| 1235 | cc_library { |
| 1236 | name: "libx", |
| 1237 | shared_libs: ["liba"], |
| 1238 | system_shared_libs: [], |
| 1239 | stl: "none", |
| 1240 | apex_available: [ "myapex" ], |
| 1241 | } |
| 1242 | |
| 1243 | cc_library { |
| 1244 | name: "liby", |
| 1245 | shared_libs: ["liba"], |
| 1246 | system_shared_libs: [], |
| 1247 | stl: "none", |
| 1248 | apex_available: [ "otherapex" ], |
| 1249 | } |
| 1250 | |
| 1251 | cc_library { |
| 1252 | name: "liba", |
| 1253 | shared_libs: ["libz"], |
| 1254 | system_shared_libs: [], |
| 1255 | stl: "none", |
| 1256 | apex_available: [ |
| 1257 | "//apex_available:anyapex", |
| 1258 | "//apex_available:platform", |
| 1259 | ], |
| 1260 | } |
| 1261 | |
| 1262 | cc_library { |
| 1263 | name: "libz", |
| 1264 | system_shared_libs: [], |
| 1265 | stl: "none", |
| 1266 | stubs: { |
| 1267 | versions: ["1", "3"], |
| 1268 | }, |
| 1269 | } |
| 1270 | `, withUnbundledBuild) |
| 1271 | |
| 1272 | expectLink := func(from, from_variant, to, to_variant string) { |
| 1273 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1274 | ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1275 | } |
| 1276 | expectNoLink := func(from, from_variant, to, to_variant string) { |
| 1277 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1278 | ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1279 | } |
| 1280 | // platform liba is linked to non-stub version |
| 1281 | expectLink("liba", "shared", "libz", "shared") |
| 1282 | // liba in myapex is linked to #1 |
| 1283 | expectLink("liba", "shared_myapex", "libz", "shared_1") |
| 1284 | expectNoLink("liba", "shared_myapex", "libz", "shared_3") |
| 1285 | expectNoLink("liba", "shared_myapex", "libz", "shared") |
| 1286 | // liba in otherapex is linked to #3 |
| 1287 | expectLink("liba", "shared_otherapex", "libz", "shared_3") |
| 1288 | expectNoLink("liba", "shared_otherapex", "libz", "shared_1") |
| 1289 | expectNoLink("liba", "shared_otherapex", "libz", "shared") |
| 1290 | } |
| 1291 | |
Jooyung Han | aed150d | 2020-04-02 01:41:41 +0900 | [diff] [blame] | 1292 | func TestApexMinSdkVersion_SupportsCodeNames(t *testing.T) { |
| 1293 | ctx, _ := testApex(t, ` |
| 1294 | apex { |
| 1295 | name: "myapex", |
| 1296 | key: "myapex.key", |
| 1297 | native_shared_libs: ["libx"], |
| 1298 | min_sdk_version: "R", |
| 1299 | } |
| 1300 | |
| 1301 | apex_key { |
| 1302 | name: "myapex.key", |
| 1303 | public_key: "testkey.avbpubkey", |
| 1304 | private_key: "testkey.pem", |
| 1305 | } |
| 1306 | |
| 1307 | cc_library { |
| 1308 | name: "libx", |
| 1309 | shared_libs: ["libz"], |
| 1310 | system_shared_libs: [], |
| 1311 | stl: "none", |
| 1312 | apex_available: [ "myapex" ], |
| 1313 | } |
| 1314 | |
| 1315 | cc_library { |
| 1316 | name: "libz", |
| 1317 | system_shared_libs: [], |
| 1318 | stl: "none", |
| 1319 | stubs: { |
| 1320 | versions: ["29", "R"], |
| 1321 | }, |
| 1322 | } |
| 1323 | `, func(fs map[string][]byte, config android.Config) { |
| 1324 | config.TestProductVariables.Platform_version_active_codenames = []string{"R"} |
| 1325 | }) |
| 1326 | |
| 1327 | expectLink := func(from, from_variant, to, to_variant string) { |
| 1328 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1329 | ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1330 | } |
| 1331 | expectNoLink := func(from, from_variant, to, to_variant string) { |
| 1332 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1333 | ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1334 | } |
| 1335 | // 9000 is quite a magic number. |
| 1336 | // Finalized SDK codenames are mapped as P(28), Q(29), ... |
| 1337 | // And, codenames which are not finalized yet(active_codenames + future_codenames) are numbered from 9000, 9001, ... |
| 1338 | // to distinguish them from finalized and future_api(10000) |
| 1339 | // In this test, "R" is assumed not finalized yet( listed in Platform_version_active_codenames) and translated into 9000 |
| 1340 | // (refer android/api_levels.go) |
| 1341 | expectLink("libx", "shared_myapex", "libz", "shared_9000") |
| 1342 | expectNoLink("libx", "shared_myapex", "libz", "shared_29") |
| 1343 | expectNoLink("libx", "shared_myapex", "libz", "shared") |
| 1344 | } |
| 1345 | |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1346 | func TestApexMinSdkVersionDefaultsToLatest(t *testing.T) { |
| 1347 | ctx, _ := testApex(t, ` |
| 1348 | apex { |
| 1349 | name: "myapex", |
| 1350 | key: "myapex.key", |
| 1351 | native_shared_libs: ["libx"], |
| 1352 | } |
| 1353 | |
| 1354 | apex_key { |
| 1355 | name: "myapex.key", |
| 1356 | public_key: "testkey.avbpubkey", |
| 1357 | private_key: "testkey.pem", |
| 1358 | } |
| 1359 | |
| 1360 | cc_library { |
| 1361 | name: "libx", |
| 1362 | shared_libs: ["libz"], |
| 1363 | system_shared_libs: [], |
| 1364 | stl: "none", |
| 1365 | apex_available: [ "myapex" ], |
| 1366 | } |
| 1367 | |
| 1368 | cc_library { |
| 1369 | name: "libz", |
| 1370 | system_shared_libs: [], |
| 1371 | stl: "none", |
| 1372 | stubs: { |
| 1373 | versions: ["1", "2"], |
| 1374 | }, |
| 1375 | } |
| 1376 | `) |
| 1377 | |
| 1378 | expectLink := func(from, from_variant, to, to_variant string) { |
| 1379 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1380 | ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1381 | } |
| 1382 | expectNoLink := func(from, from_variant, to, to_variant string) { |
| 1383 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1384 | ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1385 | } |
| 1386 | expectLink("libx", "shared_myapex", "libz", "shared_2") |
| 1387 | expectNoLink("libx", "shared_myapex", "libz", "shared_1") |
| 1388 | expectNoLink("libx", "shared_myapex", "libz", "shared") |
| 1389 | } |
| 1390 | |
| 1391 | func TestPlatformUsesLatestStubsFromApexes(t *testing.T) { |
| 1392 | ctx, _ := testApex(t, ` |
| 1393 | apex { |
| 1394 | name: "myapex", |
| 1395 | key: "myapex.key", |
| 1396 | native_shared_libs: ["libx"], |
| 1397 | } |
| 1398 | |
| 1399 | apex_key { |
| 1400 | name: "myapex.key", |
| 1401 | public_key: "testkey.avbpubkey", |
| 1402 | private_key: "testkey.pem", |
| 1403 | } |
| 1404 | |
| 1405 | cc_library { |
| 1406 | name: "libx", |
| 1407 | system_shared_libs: [], |
| 1408 | stl: "none", |
| 1409 | apex_available: [ "myapex" ], |
| 1410 | stubs: { |
| 1411 | versions: ["1", "2"], |
| 1412 | }, |
| 1413 | } |
| 1414 | |
| 1415 | cc_library { |
| 1416 | name: "libz", |
| 1417 | shared_libs: ["libx"], |
| 1418 | system_shared_libs: [], |
| 1419 | stl: "none", |
| 1420 | } |
| 1421 | `) |
| 1422 | |
| 1423 | expectLink := func(from, from_variant, to, to_variant string) { |
| 1424 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1425 | ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1426 | } |
| 1427 | expectNoLink := func(from, from_variant, to, to_variant string) { |
| 1428 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1429 | ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1430 | } |
| 1431 | expectLink("libz", "shared", "libx", "shared_2") |
| 1432 | expectNoLink("libz", "shared", "libz", "shared_1") |
| 1433 | expectNoLink("libz", "shared", "libz", "shared") |
| 1434 | } |
| 1435 | |
Jooyung Han | 7556839 | 2020-03-20 04:29:24 +0900 | [diff] [blame] | 1436 | func TestQApexesUseLatestStubsInBundledBuildsAndHWASAN(t *testing.T) { |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1437 | ctx, _ := testApex(t, ` |
| 1438 | apex { |
| 1439 | name: "myapex", |
| 1440 | key: "myapex.key", |
| 1441 | native_shared_libs: ["libx"], |
| 1442 | min_sdk_version: "29", |
| 1443 | } |
| 1444 | |
| 1445 | apex_key { |
| 1446 | name: "myapex.key", |
| 1447 | public_key: "testkey.avbpubkey", |
| 1448 | private_key: "testkey.pem", |
| 1449 | } |
| 1450 | |
| 1451 | cc_library { |
| 1452 | name: "libx", |
| 1453 | shared_libs: ["libbar"], |
| 1454 | apex_available: [ "myapex" ], |
| 1455 | } |
| 1456 | |
| 1457 | cc_library { |
| 1458 | name: "libbar", |
| 1459 | stubs: { |
| 1460 | versions: ["29", "30"], |
| 1461 | }, |
| 1462 | } |
Jooyung Han | 7556839 | 2020-03-20 04:29:24 +0900 | [diff] [blame] | 1463 | `, func(fs map[string][]byte, config android.Config) { |
| 1464 | config.TestProductVariables.SanitizeDevice = []string{"hwaddress"} |
| 1465 | }) |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1466 | expectLink := func(from, from_variant, to, to_variant string) { |
| 1467 | ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld") |
| 1468 | libFlags := ld.Args["libFlags"] |
| 1469 | ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1470 | } |
Jooyung Han | 7556839 | 2020-03-20 04:29:24 +0900 | [diff] [blame] | 1471 | expectLink("libx", "shared_hwasan_myapex", "libbar", "shared_30") |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1472 | } |
| 1473 | |
Jooyung Han | 7556839 | 2020-03-20 04:29:24 +0900 | [diff] [blame] | 1474 | func TestQTargetApexUsesStaticUnwinder(t *testing.T) { |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1475 | ctx, _ := testApex(t, ` |
| 1476 | apex { |
| 1477 | name: "myapex", |
| 1478 | key: "myapex.key", |
| 1479 | native_shared_libs: ["libx"], |
| 1480 | min_sdk_version: "29", |
| 1481 | } |
| 1482 | |
| 1483 | apex_key { |
| 1484 | name: "myapex.key", |
| 1485 | public_key: "testkey.avbpubkey", |
| 1486 | private_key: "testkey.pem", |
| 1487 | } |
| 1488 | |
| 1489 | cc_library { |
| 1490 | name: "libx", |
| 1491 | apex_available: [ "myapex" ], |
| 1492 | } |
Jooyung Han | 7556839 | 2020-03-20 04:29:24 +0900 | [diff] [blame] | 1493 | `) |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1494 | |
| 1495 | // ensure apex variant of c++ is linked with static unwinder |
| 1496 | cm := ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared_myapex").Module().(*cc.Module) |
| 1497 | ensureListContains(t, cm.Properties.AndroidMkStaticLibs, "libgcc_stripped") |
| 1498 | // note that platform variant is not. |
| 1499 | cm = ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared").Module().(*cc.Module) |
| 1500 | ensureListNotContains(t, cm.Properties.AndroidMkStaticLibs, "libgcc_stripped") |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1501 | } |
| 1502 | |
| 1503 | func TestInvalidMinSdkVersion(t *testing.T) { |
Jooyung Han | 7556839 | 2020-03-20 04:29:24 +0900 | [diff] [blame] | 1504 | testApexError(t, `"libz" .*: not found a version\(<=29\)`, ` |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1505 | apex { |
| 1506 | name: "myapex", |
| 1507 | key: "myapex.key", |
| 1508 | native_shared_libs: ["libx"], |
| 1509 | min_sdk_version: "29", |
| 1510 | } |
| 1511 | |
| 1512 | apex_key { |
| 1513 | name: "myapex.key", |
| 1514 | public_key: "testkey.avbpubkey", |
| 1515 | private_key: "testkey.pem", |
| 1516 | } |
| 1517 | |
| 1518 | cc_library { |
| 1519 | name: "libx", |
| 1520 | shared_libs: ["libz"], |
| 1521 | system_shared_libs: [], |
| 1522 | stl: "none", |
| 1523 | apex_available: [ "myapex" ], |
| 1524 | } |
| 1525 | |
| 1526 | cc_library { |
| 1527 | name: "libz", |
| 1528 | system_shared_libs: [], |
| 1529 | stl: "none", |
| 1530 | stubs: { |
| 1531 | versions: ["30"], |
| 1532 | }, |
| 1533 | } |
Jooyung Han | 7556839 | 2020-03-20 04:29:24 +0900 | [diff] [blame] | 1534 | `) |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1535 | |
Jooyung Han | aed150d | 2020-04-02 01:41:41 +0900 | [diff] [blame] | 1536 | testApexError(t, `"myapex" .*: min_sdk_version: SDK version should be .*`, ` |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1537 | apex { |
| 1538 | name: "myapex", |
| 1539 | key: "myapex.key", |
Jooyung Han | aed150d | 2020-04-02 01:41:41 +0900 | [diff] [blame] | 1540 | min_sdk_version: "abc", |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1541 | } |
| 1542 | |
| 1543 | apex_key { |
| 1544 | name: "myapex.key", |
| 1545 | public_key: "testkey.avbpubkey", |
| 1546 | private_key: "testkey.pem", |
| 1547 | } |
| 1548 | `) |
| 1549 | } |
| 1550 | |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 1551 | func TestJavaStableSdkVersion(t *testing.T) { |
| 1552 | testCases := []struct { |
| 1553 | name string |
| 1554 | expectedError string |
| 1555 | bp string |
| 1556 | }{ |
| 1557 | { |
| 1558 | name: "Non-updatable apex with non-stable dep", |
| 1559 | bp: ` |
| 1560 | apex { |
| 1561 | name: "myapex", |
| 1562 | java_libs: ["myjar"], |
| 1563 | key: "myapex.key", |
| 1564 | } |
| 1565 | apex_key { |
| 1566 | name: "myapex.key", |
| 1567 | public_key: "testkey.avbpubkey", |
| 1568 | private_key: "testkey.pem", |
| 1569 | } |
| 1570 | java_library { |
| 1571 | name: "myjar", |
| 1572 | srcs: ["foo/bar/MyClass.java"], |
| 1573 | sdk_version: "core_platform", |
| 1574 | apex_available: ["myapex"], |
| 1575 | } |
| 1576 | `, |
| 1577 | }, |
| 1578 | { |
| 1579 | name: "Updatable apex with stable dep", |
| 1580 | bp: ` |
| 1581 | apex { |
| 1582 | name: "myapex", |
| 1583 | java_libs: ["myjar"], |
| 1584 | key: "myapex.key", |
| 1585 | updatable: true, |
| 1586 | min_sdk_version: "29", |
| 1587 | } |
| 1588 | apex_key { |
| 1589 | name: "myapex.key", |
| 1590 | public_key: "testkey.avbpubkey", |
| 1591 | private_key: "testkey.pem", |
| 1592 | } |
| 1593 | java_library { |
| 1594 | name: "myjar", |
| 1595 | srcs: ["foo/bar/MyClass.java"], |
| 1596 | sdk_version: "current", |
| 1597 | apex_available: ["myapex"], |
| 1598 | } |
| 1599 | `, |
| 1600 | }, |
| 1601 | { |
| 1602 | name: "Updatable apex with non-stable dep", |
| 1603 | expectedError: "cannot depend on \"myjar\"", |
| 1604 | bp: ` |
| 1605 | apex { |
| 1606 | name: "myapex", |
| 1607 | java_libs: ["myjar"], |
| 1608 | key: "myapex.key", |
| 1609 | updatable: true, |
| 1610 | } |
| 1611 | apex_key { |
| 1612 | name: "myapex.key", |
| 1613 | public_key: "testkey.avbpubkey", |
| 1614 | private_key: "testkey.pem", |
| 1615 | } |
| 1616 | java_library { |
| 1617 | name: "myjar", |
| 1618 | srcs: ["foo/bar/MyClass.java"], |
| 1619 | sdk_version: "core_platform", |
| 1620 | apex_available: ["myapex"], |
| 1621 | } |
| 1622 | `, |
| 1623 | }, |
| 1624 | { |
| 1625 | name: "Updatable apex with non-stable transitive dep", |
| 1626 | expectedError: "compiles against Android API, but dependency \"transitive-jar\" is compiling against non-public Android API.", |
| 1627 | bp: ` |
| 1628 | apex { |
| 1629 | name: "myapex", |
| 1630 | java_libs: ["myjar"], |
| 1631 | key: "myapex.key", |
| 1632 | updatable: true, |
| 1633 | } |
| 1634 | apex_key { |
| 1635 | name: "myapex.key", |
| 1636 | public_key: "testkey.avbpubkey", |
| 1637 | private_key: "testkey.pem", |
| 1638 | } |
| 1639 | java_library { |
| 1640 | name: "myjar", |
| 1641 | srcs: ["foo/bar/MyClass.java"], |
| 1642 | sdk_version: "current", |
| 1643 | apex_available: ["myapex"], |
| 1644 | static_libs: ["transitive-jar"], |
| 1645 | } |
| 1646 | java_library { |
| 1647 | name: "transitive-jar", |
| 1648 | srcs: ["foo/bar/MyClass.java"], |
| 1649 | sdk_version: "core_platform", |
| 1650 | apex_available: ["myapex"], |
| 1651 | } |
| 1652 | `, |
| 1653 | }, |
| 1654 | } |
| 1655 | |
| 1656 | for _, test := range testCases { |
| 1657 | t.Run(test.name, func(t *testing.T) { |
| 1658 | if test.expectedError == "" { |
| 1659 | testApex(t, test.bp) |
| 1660 | } else { |
| 1661 | testApexError(t, test.expectedError, test.bp) |
| 1662 | } |
| 1663 | }) |
| 1664 | } |
| 1665 | } |
| 1666 | |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 1667 | func TestFilesInSubDir(t *testing.T) { |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 1668 | ctx, _ := testApex(t, ` |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 1669 | apex { |
| 1670 | name: "myapex", |
| 1671 | key: "myapex.key", |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 1672 | native_shared_libs: ["mylib"], |
| 1673 | binaries: ["mybin"], |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 1674 | prebuilts: ["myetc"], |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 1675 | compile_multilib: "both", |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 1676 | } |
| 1677 | |
| 1678 | apex_key { |
| 1679 | name: "myapex.key", |
| 1680 | public_key: "testkey.avbpubkey", |
| 1681 | private_key: "testkey.pem", |
| 1682 | } |
| 1683 | |
| 1684 | prebuilt_etc { |
| 1685 | name: "myetc", |
| 1686 | src: "myprebuilt", |
| 1687 | sub_dir: "foo/bar", |
| 1688 | } |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 1689 | |
| 1690 | cc_library { |
| 1691 | name: "mylib", |
| 1692 | srcs: ["mylib.cpp"], |
| 1693 | relative_install_path: "foo/bar", |
| 1694 | system_shared_libs: [], |
| 1695 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 1696 | apex_available: [ "myapex" ], |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 1697 | } |
| 1698 | |
| 1699 | cc_binary { |
| 1700 | name: "mybin", |
| 1701 | srcs: ["mylib.cpp"], |
| 1702 | relative_install_path: "foo/bar", |
| 1703 | system_shared_libs: [], |
| 1704 | static_executable: true, |
| 1705 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 1706 | apex_available: [ "myapex" ], |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 1707 | } |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 1708 | `) |
| 1709 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 1710 | generateFsRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("generateFsConfig") |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 1711 | dirs := strings.Split(generateFsRule.Args["exec_paths"], " ") |
| 1712 | |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 1713 | // Ensure that the subdirectories are all listed |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 1714 | ensureListContains(t, dirs, "etc") |
| 1715 | ensureListContains(t, dirs, "etc/foo") |
| 1716 | ensureListContains(t, dirs, "etc/foo/bar") |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 1717 | ensureListContains(t, dirs, "lib64") |
| 1718 | ensureListContains(t, dirs, "lib64/foo") |
| 1719 | ensureListContains(t, dirs, "lib64/foo/bar") |
| 1720 | ensureListContains(t, dirs, "lib") |
| 1721 | ensureListContains(t, dirs, "lib/foo") |
| 1722 | ensureListContains(t, dirs, "lib/foo/bar") |
| 1723 | |
Jiyong Park | bd13e44 | 2019-03-15 18:10:35 +0900 | [diff] [blame] | 1724 | ensureListContains(t, dirs, "bin") |
| 1725 | ensureListContains(t, dirs, "bin/foo") |
| 1726 | ensureListContains(t, dirs, "bin/foo/bar") |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 1727 | } |
Jiyong Park | da6eb59 | 2018-12-19 17:12:36 +0900 | [diff] [blame] | 1728 | |
Jooyung Han | 35155c4 | 2020-02-06 17:33:20 +0900 | [diff] [blame] | 1729 | func TestFilesInSubDirWhenNativeBridgeEnabled(t *testing.T) { |
| 1730 | ctx, _ := testApex(t, ` |
| 1731 | apex { |
| 1732 | name: "myapex", |
| 1733 | key: "myapex.key", |
| 1734 | multilib: { |
| 1735 | both: { |
| 1736 | native_shared_libs: ["mylib"], |
| 1737 | binaries: ["mybin"], |
| 1738 | }, |
| 1739 | }, |
| 1740 | compile_multilib: "both", |
| 1741 | native_bridge_supported: true, |
| 1742 | } |
| 1743 | |
| 1744 | apex_key { |
| 1745 | name: "myapex.key", |
| 1746 | public_key: "testkey.avbpubkey", |
| 1747 | private_key: "testkey.pem", |
| 1748 | } |
| 1749 | |
| 1750 | cc_library { |
| 1751 | name: "mylib", |
| 1752 | relative_install_path: "foo/bar", |
| 1753 | system_shared_libs: [], |
| 1754 | stl: "none", |
| 1755 | apex_available: [ "myapex" ], |
| 1756 | native_bridge_supported: true, |
| 1757 | } |
| 1758 | |
| 1759 | cc_binary { |
| 1760 | name: "mybin", |
| 1761 | relative_install_path: "foo/bar", |
| 1762 | system_shared_libs: [], |
| 1763 | static_executable: true, |
| 1764 | stl: "none", |
| 1765 | apex_available: [ "myapex" ], |
| 1766 | native_bridge_supported: true, |
| 1767 | compile_multilib: "both", // default is "first" for binary |
| 1768 | multilib: { |
| 1769 | lib64: { |
| 1770 | suffix: "64", |
| 1771 | }, |
| 1772 | }, |
| 1773 | } |
| 1774 | `, withNativeBridgeEnabled) |
| 1775 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 1776 | "bin/foo/bar/mybin", |
| 1777 | "bin/foo/bar/mybin64", |
| 1778 | "bin/arm/foo/bar/mybin", |
| 1779 | "bin/arm64/foo/bar/mybin64", |
| 1780 | "lib/foo/bar/mylib.so", |
| 1781 | "lib/arm/foo/bar/mylib.so", |
| 1782 | "lib64/foo/bar/mylib.so", |
| 1783 | "lib64/arm64/foo/bar/mylib.so", |
| 1784 | }) |
| 1785 | } |
| 1786 | |
Jiyong Park | da6eb59 | 2018-12-19 17:12:36 +0900 | [diff] [blame] | 1787 | func TestUseVendor(t *testing.T) { |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 1788 | ctx, _ := testApex(t, ` |
Jiyong Park | da6eb59 | 2018-12-19 17:12:36 +0900 | [diff] [blame] | 1789 | apex { |
| 1790 | name: "myapex", |
| 1791 | key: "myapex.key", |
| 1792 | native_shared_libs: ["mylib"], |
| 1793 | use_vendor: true, |
| 1794 | } |
| 1795 | |
| 1796 | apex_key { |
| 1797 | name: "myapex.key", |
| 1798 | public_key: "testkey.avbpubkey", |
| 1799 | private_key: "testkey.pem", |
| 1800 | } |
| 1801 | |
| 1802 | cc_library { |
| 1803 | name: "mylib", |
| 1804 | srcs: ["mylib.cpp"], |
| 1805 | shared_libs: ["mylib2"], |
| 1806 | system_shared_libs: [], |
| 1807 | vendor_available: true, |
| 1808 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 1809 | apex_available: [ "myapex" ], |
Jiyong Park | da6eb59 | 2018-12-19 17:12:36 +0900 | [diff] [blame] | 1810 | } |
| 1811 | |
| 1812 | cc_library { |
| 1813 | name: "mylib2", |
| 1814 | srcs: ["mylib.cpp"], |
| 1815 | system_shared_libs: [], |
| 1816 | vendor_available: true, |
| 1817 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 1818 | apex_available: [ "myapex" ], |
Jiyong Park | da6eb59 | 2018-12-19 17:12:36 +0900 | [diff] [blame] | 1819 | } |
Jooyung Han | dc78244 | 2019-11-01 03:14:38 +0900 | [diff] [blame] | 1820 | `, func(fs map[string][]byte, config android.Config) { |
| 1821 | setUseVendorWhitelistForTest(config, []string{"myapex"}) |
| 1822 | }) |
Jiyong Park | da6eb59 | 2018-12-19 17:12:36 +0900 | [diff] [blame] | 1823 | |
| 1824 | inputsList := []string{} |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 1825 | for _, i := range ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().BuildParamsForTests() { |
Jiyong Park | da6eb59 | 2018-12-19 17:12:36 +0900 | [diff] [blame] | 1826 | for _, implicit := range i.Implicits { |
| 1827 | inputsList = append(inputsList, implicit.String()) |
| 1828 | } |
| 1829 | } |
| 1830 | inputsString := strings.Join(inputsList, " ") |
| 1831 | |
| 1832 | // ensure that the apex includes vendor variants of the direct and indirect deps |
Colin Cross | fb0c16e | 2019-11-20 17:12:35 -0800 | [diff] [blame] | 1833 | ensureContains(t, inputsString, "android_vendor.VER_arm64_armv8-a_shared_myapex/mylib.so") |
| 1834 | ensureContains(t, inputsString, "android_vendor.VER_arm64_armv8-a_shared_myapex/mylib2.so") |
Jiyong Park | da6eb59 | 2018-12-19 17:12:36 +0900 | [diff] [blame] | 1835 | |
| 1836 | // ensure that the apex does not include core variants |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 1837 | ensureNotContains(t, inputsString, "android_arm64_armv8-a_shared_myapex/mylib.so") |
| 1838 | ensureNotContains(t, inputsString, "android_arm64_armv8-a_shared_myapex/mylib2.so") |
Jiyong Park | da6eb59 | 2018-12-19 17:12:36 +0900 | [diff] [blame] | 1839 | } |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 1840 | |
Jooyung Han | dc78244 | 2019-11-01 03:14:38 +0900 | [diff] [blame] | 1841 | func TestUseVendorRestriction(t *testing.T) { |
| 1842 | testApexError(t, `module "myapex" .*: use_vendor: not allowed`, ` |
| 1843 | apex { |
| 1844 | name: "myapex", |
| 1845 | key: "myapex.key", |
| 1846 | use_vendor: true, |
| 1847 | } |
| 1848 | apex_key { |
| 1849 | name: "myapex.key", |
| 1850 | public_key: "testkey.avbpubkey", |
| 1851 | private_key: "testkey.pem", |
| 1852 | } |
| 1853 | `, func(fs map[string][]byte, config android.Config) { |
| 1854 | setUseVendorWhitelistForTest(config, []string{""}) |
| 1855 | }) |
| 1856 | // no error with whitelist |
| 1857 | testApex(t, ` |
| 1858 | apex { |
| 1859 | name: "myapex", |
| 1860 | key: "myapex.key", |
| 1861 | use_vendor: true, |
| 1862 | } |
| 1863 | apex_key { |
| 1864 | name: "myapex.key", |
| 1865 | public_key: "testkey.avbpubkey", |
| 1866 | private_key: "testkey.pem", |
| 1867 | } |
| 1868 | `, func(fs map[string][]byte, config android.Config) { |
| 1869 | setUseVendorWhitelistForTest(config, []string{"myapex"}) |
| 1870 | }) |
| 1871 | } |
| 1872 | |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 1873 | func TestUseVendorFailsIfNotVendorAvailable(t *testing.T) { |
| 1874 | testApexError(t, `dependency "mylib" of "myapex" missing variant:\n.*image:vendor`, ` |
| 1875 | apex { |
| 1876 | name: "myapex", |
| 1877 | key: "myapex.key", |
| 1878 | native_shared_libs: ["mylib"], |
| 1879 | use_vendor: true, |
| 1880 | } |
| 1881 | |
| 1882 | apex_key { |
| 1883 | name: "myapex.key", |
| 1884 | public_key: "testkey.avbpubkey", |
| 1885 | private_key: "testkey.pem", |
| 1886 | } |
| 1887 | |
| 1888 | cc_library { |
| 1889 | name: "mylib", |
| 1890 | srcs: ["mylib.cpp"], |
| 1891 | system_shared_libs: [], |
| 1892 | stl: "none", |
| 1893 | } |
| 1894 | `) |
| 1895 | } |
| 1896 | |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 1897 | func TestStaticLinking(t *testing.T) { |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 1898 | ctx, _ := testApex(t, ` |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 1899 | apex { |
| 1900 | name: "myapex", |
| 1901 | key: "myapex.key", |
| 1902 | native_shared_libs: ["mylib"], |
| 1903 | } |
| 1904 | |
| 1905 | apex_key { |
| 1906 | name: "myapex.key", |
| 1907 | public_key: "testkey.avbpubkey", |
| 1908 | private_key: "testkey.pem", |
| 1909 | } |
| 1910 | |
| 1911 | cc_library { |
| 1912 | name: "mylib", |
| 1913 | srcs: ["mylib.cpp"], |
| 1914 | system_shared_libs: [], |
| 1915 | stl: "none", |
| 1916 | stubs: { |
| 1917 | versions: ["1", "2", "3"], |
| 1918 | }, |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 1919 | apex_available: [ |
| 1920 | "//apex_available:platform", |
| 1921 | "myapex", |
| 1922 | ], |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 1923 | } |
| 1924 | |
| 1925 | cc_binary { |
| 1926 | name: "not_in_apex", |
| 1927 | srcs: ["mylib.cpp"], |
| 1928 | static_libs: ["mylib"], |
| 1929 | static_executable: true, |
| 1930 | system_shared_libs: [], |
| 1931 | stl: "none", |
| 1932 | } |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 1933 | `) |
| 1934 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 1935 | ldFlags := ctx.ModuleForTests("not_in_apex", "android_arm64_armv8-a").Rule("ld").Args["libFlags"] |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 1936 | |
| 1937 | // Ensure that not_in_apex is linking with the static variant of mylib |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 1938 | ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_static/mylib.a") |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 1939 | } |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 1940 | |
| 1941 | func TestKeys(t *testing.T) { |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 1942 | ctx, _ := testApex(t, ` |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 1943 | apex { |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 1944 | name: "myapex_keytest", |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 1945 | key: "myapex.key", |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 1946 | certificate: ":myapex.certificate", |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 1947 | native_shared_libs: ["mylib"], |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 1948 | file_contexts: ":myapex-file_contexts", |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 1949 | } |
| 1950 | |
| 1951 | cc_library { |
| 1952 | name: "mylib", |
| 1953 | srcs: ["mylib.cpp"], |
| 1954 | system_shared_libs: [], |
| 1955 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 1956 | apex_available: [ "myapex_keytest" ], |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 1957 | } |
| 1958 | |
| 1959 | apex_key { |
| 1960 | name: "myapex.key", |
| 1961 | public_key: "testkey.avbpubkey", |
| 1962 | private_key: "testkey.pem", |
| 1963 | } |
| 1964 | |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 1965 | android_app_certificate { |
| 1966 | name: "myapex.certificate", |
| 1967 | certificate: "testkey", |
| 1968 | } |
| 1969 | |
| 1970 | android_app_certificate { |
| 1971 | name: "myapex.certificate.override", |
| 1972 | certificate: "testkey.override", |
| 1973 | } |
| 1974 | |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 1975 | `) |
| 1976 | |
| 1977 | // check the APEX keys |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 1978 | keys := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey) |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 1979 | |
| 1980 | if keys.public_key_file.String() != "vendor/foo/devkeys/testkey.avbpubkey" { |
| 1981 | t.Errorf("public key %q is not %q", keys.public_key_file.String(), |
| 1982 | "vendor/foo/devkeys/testkey.avbpubkey") |
| 1983 | } |
| 1984 | if keys.private_key_file.String() != "vendor/foo/devkeys/testkey.pem" { |
| 1985 | t.Errorf("private key %q is not %q", keys.private_key_file.String(), |
| 1986 | "vendor/foo/devkeys/testkey.pem") |
| 1987 | } |
| 1988 | |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 1989 | // check the APK certs. It should be overridden to myapex.certificate.override |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 1990 | certs := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk").Args["certificates"] |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 1991 | if certs != "testkey.override.x509.pem testkey.override.pk8" { |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 1992 | t.Errorf("cert and private key %q are not %q", certs, |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 1993 | "testkey.override.509.pem testkey.override.pk8") |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 1994 | } |
| 1995 | } |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 1996 | |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 1997 | func TestCertificate(t *testing.T) { |
| 1998 | t.Run("if unspecified, it defaults to DefaultAppCertificate", func(t *testing.T) { |
| 1999 | ctx, _ := testApex(t, ` |
| 2000 | apex { |
| 2001 | name: "myapex", |
| 2002 | key: "myapex.key", |
| 2003 | } |
| 2004 | apex_key { |
| 2005 | name: "myapex.key", |
| 2006 | public_key: "testkey.avbpubkey", |
| 2007 | private_key: "testkey.pem", |
| 2008 | }`) |
| 2009 | rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk") |
| 2010 | expected := "vendor/foo/devkeys/test.x509.pem vendor/foo/devkeys/test.pk8" |
| 2011 | if actual := rule.Args["certificates"]; actual != expected { |
| 2012 | t.Errorf("certificates should be %q, not %q", expected, actual) |
| 2013 | } |
| 2014 | }) |
| 2015 | t.Run("override when unspecified", func(t *testing.T) { |
| 2016 | ctx, _ := testApex(t, ` |
| 2017 | apex { |
| 2018 | name: "myapex_keytest", |
| 2019 | key: "myapex.key", |
| 2020 | file_contexts: ":myapex-file_contexts", |
| 2021 | } |
| 2022 | apex_key { |
| 2023 | name: "myapex.key", |
| 2024 | public_key: "testkey.avbpubkey", |
| 2025 | private_key: "testkey.pem", |
| 2026 | } |
| 2027 | android_app_certificate { |
| 2028 | name: "myapex.certificate.override", |
| 2029 | certificate: "testkey.override", |
| 2030 | }`) |
| 2031 | rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk") |
| 2032 | expected := "testkey.override.x509.pem testkey.override.pk8" |
| 2033 | if actual := rule.Args["certificates"]; actual != expected { |
| 2034 | t.Errorf("certificates should be %q, not %q", expected, actual) |
| 2035 | } |
| 2036 | }) |
| 2037 | t.Run("if specified as :module, it respects the prop", func(t *testing.T) { |
| 2038 | ctx, _ := testApex(t, ` |
| 2039 | apex { |
| 2040 | name: "myapex", |
| 2041 | key: "myapex.key", |
| 2042 | certificate: ":myapex.certificate", |
| 2043 | } |
| 2044 | apex_key { |
| 2045 | name: "myapex.key", |
| 2046 | public_key: "testkey.avbpubkey", |
| 2047 | private_key: "testkey.pem", |
| 2048 | } |
| 2049 | android_app_certificate { |
| 2050 | name: "myapex.certificate", |
| 2051 | certificate: "testkey", |
| 2052 | }`) |
| 2053 | rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk") |
| 2054 | expected := "testkey.x509.pem testkey.pk8" |
| 2055 | if actual := rule.Args["certificates"]; actual != expected { |
| 2056 | t.Errorf("certificates should be %q, not %q", expected, actual) |
| 2057 | } |
| 2058 | }) |
| 2059 | t.Run("override when specifiec as <:module>", func(t *testing.T) { |
| 2060 | ctx, _ := testApex(t, ` |
| 2061 | apex { |
| 2062 | name: "myapex_keytest", |
| 2063 | key: "myapex.key", |
| 2064 | file_contexts: ":myapex-file_contexts", |
| 2065 | certificate: ":myapex.certificate", |
| 2066 | } |
| 2067 | apex_key { |
| 2068 | name: "myapex.key", |
| 2069 | public_key: "testkey.avbpubkey", |
| 2070 | private_key: "testkey.pem", |
| 2071 | } |
| 2072 | android_app_certificate { |
| 2073 | name: "myapex.certificate.override", |
| 2074 | certificate: "testkey.override", |
| 2075 | }`) |
| 2076 | rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk") |
| 2077 | expected := "testkey.override.x509.pem testkey.override.pk8" |
| 2078 | if actual := rule.Args["certificates"]; actual != expected { |
| 2079 | t.Errorf("certificates should be %q, not %q", expected, actual) |
| 2080 | } |
| 2081 | }) |
| 2082 | t.Run("if specified as name, finds it from DefaultDevKeyDir", func(t *testing.T) { |
| 2083 | ctx, _ := testApex(t, ` |
| 2084 | apex { |
| 2085 | name: "myapex", |
| 2086 | key: "myapex.key", |
| 2087 | certificate: "testkey", |
| 2088 | } |
| 2089 | apex_key { |
| 2090 | name: "myapex.key", |
| 2091 | public_key: "testkey.avbpubkey", |
| 2092 | private_key: "testkey.pem", |
| 2093 | }`) |
| 2094 | rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk") |
| 2095 | expected := "vendor/foo/devkeys/testkey.x509.pem vendor/foo/devkeys/testkey.pk8" |
| 2096 | if actual := rule.Args["certificates"]; actual != expected { |
| 2097 | t.Errorf("certificates should be %q, not %q", expected, actual) |
| 2098 | } |
| 2099 | }) |
| 2100 | t.Run("override when specified as <name>", func(t *testing.T) { |
| 2101 | ctx, _ := testApex(t, ` |
| 2102 | apex { |
| 2103 | name: "myapex_keytest", |
| 2104 | key: "myapex.key", |
| 2105 | file_contexts: ":myapex-file_contexts", |
| 2106 | certificate: "testkey", |
| 2107 | } |
| 2108 | apex_key { |
| 2109 | name: "myapex.key", |
| 2110 | public_key: "testkey.avbpubkey", |
| 2111 | private_key: "testkey.pem", |
| 2112 | } |
| 2113 | android_app_certificate { |
| 2114 | name: "myapex.certificate.override", |
| 2115 | certificate: "testkey.override", |
| 2116 | }`) |
| 2117 | rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk") |
| 2118 | expected := "testkey.override.x509.pem testkey.override.pk8" |
| 2119 | if actual := rule.Args["certificates"]; actual != expected { |
| 2120 | t.Errorf("certificates should be %q, not %q", expected, actual) |
| 2121 | } |
| 2122 | }) |
| 2123 | } |
| 2124 | |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 2125 | func TestMacro(t *testing.T) { |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 2126 | ctx, _ := testApex(t, ` |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 2127 | apex { |
| 2128 | name: "myapex", |
| 2129 | key: "myapex.key", |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 2130 | native_shared_libs: ["mylib", "mylib2"], |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 2131 | } |
| 2132 | |
| 2133 | apex { |
| 2134 | name: "otherapex", |
| 2135 | key: "myapex.key", |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 2136 | native_shared_libs: ["mylib", "mylib2"], |
Jooyung Han | ccce2f2 | 2020-03-07 03:45:53 +0900 | [diff] [blame] | 2137 | min_sdk_version: "29", |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 2138 | } |
| 2139 | |
| 2140 | apex_key { |
| 2141 | name: "myapex.key", |
| 2142 | public_key: "testkey.avbpubkey", |
| 2143 | private_key: "testkey.pem", |
| 2144 | } |
| 2145 | |
| 2146 | cc_library { |
| 2147 | name: "mylib", |
| 2148 | srcs: ["mylib.cpp"], |
| 2149 | system_shared_libs: [], |
| 2150 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2151 | apex_available: [ |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2152 | "myapex", |
| 2153 | "otherapex", |
| 2154 | ], |
Jooyung Han | 2428277 | 2020-03-21 23:20:55 +0900 | [diff] [blame] | 2155 | recovery_available: true, |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 2156 | } |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 2157 | cc_library { |
| 2158 | name: "mylib2", |
| 2159 | srcs: ["mylib.cpp"], |
| 2160 | system_shared_libs: [], |
| 2161 | stl: "none", |
| 2162 | apex_available: [ |
| 2163 | "myapex", |
| 2164 | "otherapex", |
| 2165 | ], |
| 2166 | use_apex_name_macro: true, |
| 2167 | } |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 2168 | `) |
| 2169 | |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 2170 | // non-APEX variant does not have __ANDROID_APEX__ defined |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 2171 | mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
Jooyung Han | 6b8459b | 2019-10-30 08:29:25 +0900 | [diff] [blame] | 2172 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
Jooyung Han | 7556839 | 2020-03-20 04:29:24 +0900 | [diff] [blame] | 2173 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_SDK_VERSION__") |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 2174 | |
Jooyung Han | ccce2f2 | 2020-03-07 03:45:53 +0900 | [diff] [blame] | 2175 | // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 2176 | mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"] |
| 2177 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
Jooyung Han | ccce2f2 | 2020-03-07 03:45:53 +0900 | [diff] [blame] | 2178 | ensureContains(t, mylibCFlags, "-D__ANDROID_SDK_VERSION__=10000") |
Jooyung Han | 7798857 | 2019-10-18 16:26:16 +0900 | [diff] [blame] | 2179 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__") |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 2180 | |
Jooyung Han | ccce2f2 | 2020-03-07 03:45:53 +0900 | [diff] [blame] | 2181 | // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 2182 | mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_otherapex").Rule("cc").Args["cFlags"] |
| 2183 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
Jooyung Han | ccce2f2 | 2020-03-07 03:45:53 +0900 | [diff] [blame] | 2184 | ensureContains(t, mylibCFlags, "-D__ANDROID_SDK_VERSION__=29") |
Jooyung Han | 7798857 | 2019-10-18 16:26:16 +0900 | [diff] [blame] | 2185 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__") |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 2186 | |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 2187 | // When cc_library sets use_apex_name_macro: true |
| 2188 | // apex variants define additional macro to distinguish which apex variant it is built for |
| 2189 | |
| 2190 | // non-APEX variant does not have __ANDROID_APEX__ defined |
| 2191 | mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
| 2192 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
| 2193 | |
| 2194 | // APEX variant has __ANDROID_APEX__ defined |
| 2195 | mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"] |
Jooyung Han | 6b8459b | 2019-10-30 08:29:25 +0900 | [diff] [blame] | 2196 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
Jooyung Han | 7798857 | 2019-10-18 16:26:16 +0900 | [diff] [blame] | 2197 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__") |
| 2198 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__") |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 2199 | |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 2200 | // APEX variant has __ANDROID_APEX__ defined |
| 2201 | mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_otherapex").Rule("cc").Args["cFlags"] |
Jooyung Han | 6b8459b | 2019-10-30 08:29:25 +0900 | [diff] [blame] | 2202 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
Jooyung Han | 7798857 | 2019-10-18 16:26:16 +0900 | [diff] [blame] | 2203 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__") |
| 2204 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__") |
Jooyung Han | 2428277 | 2020-03-21 23:20:55 +0900 | [diff] [blame] | 2205 | |
| 2206 | // recovery variant does not set __ANDROID_SDK_VERSION__ |
| 2207 | mylibCFlags = ctx.ModuleForTests("mylib", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
| 2208 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
| 2209 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_SDK_VERSION__") |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 2210 | } |
Jiyong Park | 7e636d0 | 2019-01-28 16:16:54 +0900 | [diff] [blame] | 2211 | |
| 2212 | func TestHeaderLibsDependency(t *testing.T) { |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 2213 | ctx, _ := testApex(t, ` |
Jiyong Park | 7e636d0 | 2019-01-28 16:16:54 +0900 | [diff] [blame] | 2214 | apex { |
| 2215 | name: "myapex", |
| 2216 | key: "myapex.key", |
| 2217 | native_shared_libs: ["mylib"], |
| 2218 | } |
| 2219 | |
| 2220 | apex_key { |
| 2221 | name: "myapex.key", |
| 2222 | public_key: "testkey.avbpubkey", |
| 2223 | private_key: "testkey.pem", |
| 2224 | } |
| 2225 | |
| 2226 | cc_library_headers { |
| 2227 | name: "mylib_headers", |
| 2228 | export_include_dirs: ["my_include"], |
| 2229 | system_shared_libs: [], |
| 2230 | stl: "none", |
Jiyong Park | 0f80c18 | 2020-01-31 02:49:53 +0900 | [diff] [blame] | 2231 | apex_available: [ "myapex" ], |
Jiyong Park | 7e636d0 | 2019-01-28 16:16:54 +0900 | [diff] [blame] | 2232 | } |
| 2233 | |
| 2234 | cc_library { |
| 2235 | name: "mylib", |
| 2236 | srcs: ["mylib.cpp"], |
| 2237 | system_shared_libs: [], |
| 2238 | stl: "none", |
| 2239 | header_libs: ["mylib_headers"], |
| 2240 | export_header_lib_headers: ["mylib_headers"], |
| 2241 | stubs: { |
| 2242 | versions: ["1", "2", "3"], |
| 2243 | }, |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2244 | apex_available: [ "myapex" ], |
Jiyong Park | 7e636d0 | 2019-01-28 16:16:54 +0900 | [diff] [blame] | 2245 | } |
| 2246 | |
| 2247 | cc_library { |
| 2248 | name: "otherlib", |
| 2249 | srcs: ["mylib.cpp"], |
| 2250 | system_shared_libs: [], |
| 2251 | stl: "none", |
| 2252 | shared_libs: ["mylib"], |
| 2253 | } |
| 2254 | `) |
| 2255 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 2256 | cFlags := ctx.ModuleForTests("otherlib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
Jiyong Park | 7e636d0 | 2019-01-28 16:16:54 +0900 | [diff] [blame] | 2257 | |
| 2258 | // Ensure that the include path of the header lib is exported to 'otherlib' |
| 2259 | ensureContains(t, cFlags, "-Imy_include") |
| 2260 | } |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 2261 | |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 2262 | type fileInApex struct { |
| 2263 | path string // path in apex |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 2264 | src string // src path |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 2265 | isLink bool |
| 2266 | } |
| 2267 | |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 2268 | func getFiles(t *testing.T, ctx *android.TestContext, moduleName, variant string) []fileInApex { |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2269 | t.Helper() |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 2270 | apexRule := ctx.ModuleForTests(moduleName, variant).Rule("apexRule") |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2271 | copyCmds := apexRule.Args["copy_commands"] |
| 2272 | imageApexDir := "/image.apex/" |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 2273 | var ret []fileInApex |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2274 | for _, cmd := range strings.Split(copyCmds, "&&") { |
| 2275 | cmd = strings.TrimSpace(cmd) |
| 2276 | if cmd == "" { |
| 2277 | continue |
| 2278 | } |
| 2279 | terms := strings.Split(cmd, " ") |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 2280 | var dst, src string |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 2281 | var isLink bool |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2282 | switch terms[0] { |
| 2283 | case "mkdir": |
| 2284 | case "cp": |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 2285 | if len(terms) != 3 && len(terms) != 4 { |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2286 | t.Fatal("copyCmds contains invalid cp command", cmd) |
| 2287 | } |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 2288 | dst = terms[len(terms)-1] |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 2289 | src = terms[len(terms)-2] |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 2290 | isLink = false |
| 2291 | case "ln": |
| 2292 | if len(terms) != 3 && len(terms) != 4 { |
| 2293 | // ln LINK TARGET or ln -s LINK TARGET |
| 2294 | t.Fatal("copyCmds contains invalid ln command", cmd) |
| 2295 | } |
| 2296 | dst = terms[len(terms)-1] |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 2297 | src = terms[len(terms)-2] |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 2298 | isLink = true |
| 2299 | default: |
| 2300 | t.Fatalf("copyCmds should contain mkdir/cp commands only: %q", cmd) |
| 2301 | } |
| 2302 | if dst != "" { |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2303 | index := strings.Index(dst, imageApexDir) |
| 2304 | if index == -1 { |
| 2305 | t.Fatal("copyCmds should copy a file to image.apex/", cmd) |
| 2306 | } |
| 2307 | dstFile := dst[index+len(imageApexDir):] |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 2308 | ret = append(ret, fileInApex{path: dstFile, src: src, isLink: isLink}) |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2309 | } |
| 2310 | } |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 2311 | return ret |
| 2312 | } |
| 2313 | |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 2314 | func ensureExactContents(t *testing.T, ctx *android.TestContext, moduleName, variant string, files []string) { |
| 2315 | t.Helper() |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 2316 | var failed bool |
| 2317 | var surplus []string |
| 2318 | filesMatched := make(map[string]bool) |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 2319 | for _, file := range getFiles(t, ctx, moduleName, variant) { |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 2320 | mactchFound := false |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 2321 | for _, expected := range files { |
| 2322 | if matched, _ := path.Match(expected, file.path); matched { |
| 2323 | filesMatched[expected] = true |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 2324 | mactchFound = true |
| 2325 | break |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 2326 | } |
| 2327 | } |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 2328 | if !mactchFound { |
| 2329 | surplus = append(surplus, file.path) |
| 2330 | } |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 2331 | } |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2332 | |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2333 | if len(surplus) > 0 { |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 2334 | sort.Strings(surplus) |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2335 | t.Log("surplus files", surplus) |
| 2336 | failed = true |
| 2337 | } |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 2338 | |
| 2339 | if len(files) > len(filesMatched) { |
| 2340 | var missing []string |
| 2341 | for _, expected := range files { |
| 2342 | if !filesMatched[expected] { |
| 2343 | missing = append(missing, expected) |
| 2344 | } |
| 2345 | } |
| 2346 | sort.Strings(missing) |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2347 | t.Log("missing files", missing) |
| 2348 | failed = true |
| 2349 | } |
| 2350 | if failed { |
| 2351 | t.Fail() |
| 2352 | } |
| 2353 | } |
| 2354 | |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2355 | func TestVndkApexCurrent(t *testing.T) { |
| 2356 | ctx, _ := testApex(t, ` |
| 2357 | apex_vndk { |
| 2358 | name: "myapex", |
| 2359 | key: "myapex.key", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2360 | } |
| 2361 | |
| 2362 | apex_key { |
| 2363 | name: "myapex.key", |
| 2364 | public_key: "testkey.avbpubkey", |
| 2365 | private_key: "testkey.pem", |
| 2366 | } |
| 2367 | |
| 2368 | cc_library { |
| 2369 | name: "libvndk", |
| 2370 | srcs: ["mylib.cpp"], |
| 2371 | vendor_available: true, |
| 2372 | vndk: { |
| 2373 | enabled: true, |
| 2374 | }, |
| 2375 | system_shared_libs: [], |
| 2376 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2377 | apex_available: [ "myapex" ], |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2378 | } |
| 2379 | |
| 2380 | cc_library { |
| 2381 | name: "libvndksp", |
| 2382 | srcs: ["mylib.cpp"], |
| 2383 | vendor_available: true, |
| 2384 | vndk: { |
| 2385 | enabled: true, |
| 2386 | support_system_process: true, |
| 2387 | }, |
| 2388 | system_shared_libs: [], |
| 2389 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2390 | apex_available: [ "myapex" ], |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2391 | } |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 2392 | `+vndkLibrariesTxtFiles("current")) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2393 | |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 2394 | ensureExactContents(t, ctx, "myapex", "android_common_image", []string{ |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2395 | "lib/libvndk.so", |
| 2396 | "lib/libvndksp.so", |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 2397 | "lib/libc++.so", |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2398 | "lib64/libvndk.so", |
| 2399 | "lib64/libvndksp.so", |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 2400 | "lib64/libc++.so", |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 2401 | "etc/llndk.libraries.VER.txt", |
| 2402 | "etc/vndkcore.libraries.VER.txt", |
| 2403 | "etc/vndksp.libraries.VER.txt", |
| 2404 | "etc/vndkprivate.libraries.VER.txt", |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2405 | }) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2406 | } |
| 2407 | |
| 2408 | func TestVndkApexWithPrebuilt(t *testing.T) { |
| 2409 | ctx, _ := testApex(t, ` |
| 2410 | apex_vndk { |
| 2411 | name: "myapex", |
| 2412 | key: "myapex.key", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2413 | } |
| 2414 | |
| 2415 | apex_key { |
| 2416 | name: "myapex.key", |
| 2417 | public_key: "testkey.avbpubkey", |
| 2418 | private_key: "testkey.pem", |
| 2419 | } |
| 2420 | |
| 2421 | cc_prebuilt_library_shared { |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2422 | name: "libvndk", |
| 2423 | srcs: ["libvndk.so"], |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2424 | vendor_available: true, |
| 2425 | vndk: { |
| 2426 | enabled: true, |
| 2427 | }, |
| 2428 | system_shared_libs: [], |
| 2429 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2430 | apex_available: [ "myapex" ], |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2431 | } |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2432 | |
| 2433 | cc_prebuilt_library_shared { |
| 2434 | name: "libvndk.arm", |
| 2435 | srcs: ["libvndk.arm.so"], |
| 2436 | vendor_available: true, |
| 2437 | vndk: { |
| 2438 | enabled: true, |
| 2439 | }, |
| 2440 | enabled: false, |
| 2441 | arch: { |
| 2442 | arm: { |
| 2443 | enabled: true, |
| 2444 | }, |
| 2445 | }, |
| 2446 | system_shared_libs: [], |
| 2447 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2448 | apex_available: [ "myapex" ], |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2449 | } |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 2450 | `+vndkLibrariesTxtFiles("current"), |
| 2451 | withFiles(map[string][]byte{ |
| 2452 | "libvndk.so": nil, |
| 2453 | "libvndk.arm.so": nil, |
| 2454 | })) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2455 | |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 2456 | ensureExactContents(t, ctx, "myapex", "android_common_image", []string{ |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2457 | "lib/libvndk.so", |
| 2458 | "lib/libvndk.arm.so", |
| 2459 | "lib64/libvndk.so", |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 2460 | "lib/libc++.so", |
| 2461 | "lib64/libc++.so", |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 2462 | "etc/*", |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2463 | }) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2464 | } |
| 2465 | |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 2466 | func vndkLibrariesTxtFiles(vers ...string) (result string) { |
| 2467 | for _, v := range vers { |
| 2468 | if v == "current" { |
Kiyoung Kim | e1aa8ea | 2019-12-30 11:12:55 +0900 | [diff] [blame] | 2469 | for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate"} { |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 2470 | result += ` |
| 2471 | vndk_libraries_txt { |
| 2472 | name: "` + txt + `.libraries.txt", |
| 2473 | } |
| 2474 | ` |
| 2475 | } |
| 2476 | } else { |
| 2477 | for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate"} { |
| 2478 | result += ` |
| 2479 | prebuilt_etc { |
| 2480 | name: "` + txt + `.libraries.` + v + `.txt", |
| 2481 | src: "dummy.txt", |
| 2482 | } |
| 2483 | ` |
| 2484 | } |
| 2485 | } |
| 2486 | } |
| 2487 | return |
| 2488 | } |
| 2489 | |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2490 | func TestVndkApexVersion(t *testing.T) { |
| 2491 | ctx, _ := testApex(t, ` |
| 2492 | apex_vndk { |
| 2493 | name: "myapex_v27", |
| 2494 | key: "myapex.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 2495 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2496 | vndk_version: "27", |
| 2497 | } |
| 2498 | |
| 2499 | apex_key { |
| 2500 | name: "myapex.key", |
| 2501 | public_key: "testkey.avbpubkey", |
| 2502 | private_key: "testkey.pem", |
| 2503 | } |
| 2504 | |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2505 | vndk_prebuilt_shared { |
| 2506 | name: "libvndk27", |
| 2507 | version: "27", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2508 | vendor_available: true, |
| 2509 | vndk: { |
| 2510 | enabled: true, |
| 2511 | }, |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2512 | target_arch: "arm64", |
| 2513 | arch: { |
| 2514 | arm: { |
| 2515 | srcs: ["libvndk27_arm.so"], |
| 2516 | }, |
| 2517 | arm64: { |
| 2518 | srcs: ["libvndk27_arm64.so"], |
| 2519 | }, |
| 2520 | }, |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2521 | apex_available: [ "myapex_v27" ], |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2522 | } |
| 2523 | |
| 2524 | vndk_prebuilt_shared { |
| 2525 | name: "libvndk27", |
| 2526 | version: "27", |
| 2527 | vendor_available: true, |
| 2528 | vndk: { |
| 2529 | enabled: true, |
| 2530 | }, |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2531 | target_arch: "x86_64", |
| 2532 | arch: { |
| 2533 | x86: { |
| 2534 | srcs: ["libvndk27_x86.so"], |
| 2535 | }, |
| 2536 | x86_64: { |
| 2537 | srcs: ["libvndk27_x86_64.so"], |
| 2538 | }, |
| 2539 | }, |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 2540 | } |
| 2541 | `+vndkLibrariesTxtFiles("27"), |
| 2542 | withFiles(map[string][]byte{ |
| 2543 | "libvndk27_arm.so": nil, |
| 2544 | "libvndk27_arm64.so": nil, |
| 2545 | "libvndk27_x86.so": nil, |
| 2546 | "libvndk27_x86_64.so": nil, |
| 2547 | })) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2548 | |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 2549 | ensureExactContents(t, ctx, "myapex_v27", "android_common_image", []string{ |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2550 | "lib/libvndk27_arm.so", |
| 2551 | "lib64/libvndk27_arm64.so", |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 2552 | "etc/*", |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2553 | }) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2554 | } |
| 2555 | |
| 2556 | func TestVndkApexErrorWithDuplicateVersion(t *testing.T) { |
| 2557 | testApexError(t, `module "myapex_v27.*" .*: vndk_version: 27 is already defined in "myapex_v27.*"`, ` |
| 2558 | apex_vndk { |
| 2559 | name: "myapex_v27", |
| 2560 | key: "myapex.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 2561 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2562 | vndk_version: "27", |
| 2563 | } |
| 2564 | apex_vndk { |
| 2565 | name: "myapex_v27_other", |
| 2566 | key: "myapex.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 2567 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2568 | vndk_version: "27", |
| 2569 | } |
| 2570 | |
| 2571 | apex_key { |
| 2572 | name: "myapex.key", |
| 2573 | public_key: "testkey.avbpubkey", |
| 2574 | private_key: "testkey.pem", |
| 2575 | } |
| 2576 | |
| 2577 | cc_library { |
| 2578 | name: "libvndk", |
| 2579 | srcs: ["mylib.cpp"], |
| 2580 | vendor_available: true, |
| 2581 | vndk: { |
| 2582 | enabled: true, |
| 2583 | }, |
| 2584 | system_shared_libs: [], |
| 2585 | stl: "none", |
| 2586 | } |
| 2587 | |
| 2588 | vndk_prebuilt_shared { |
| 2589 | name: "libvndk", |
| 2590 | version: "27", |
| 2591 | vendor_available: true, |
| 2592 | vndk: { |
| 2593 | enabled: true, |
| 2594 | }, |
| 2595 | srcs: ["libvndk.so"], |
| 2596 | } |
| 2597 | `, withFiles(map[string][]byte{ |
| 2598 | "libvndk.so": nil, |
| 2599 | })) |
| 2600 | } |
| 2601 | |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 2602 | func TestVndkApexNameRule(t *testing.T) { |
| 2603 | ctx, _ := testApex(t, ` |
| 2604 | apex_vndk { |
| 2605 | name: "myapex", |
| 2606 | key: "myapex.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 2607 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 2608 | } |
| 2609 | apex_vndk { |
| 2610 | name: "myapex_v28", |
| 2611 | key: "myapex.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 2612 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 2613 | vndk_version: "28", |
| 2614 | } |
| 2615 | apex_key { |
| 2616 | name: "myapex.key", |
| 2617 | public_key: "testkey.avbpubkey", |
| 2618 | private_key: "testkey.pem", |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 2619 | }`+vndkLibrariesTxtFiles("28", "current")) |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 2620 | |
| 2621 | assertApexName := func(expected, moduleName string) { |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 2622 | bundle := ctx.ModuleForTests(moduleName, "android_common_image").Module().(*apexBundle) |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 2623 | actual := proptools.String(bundle.properties.Apex_name) |
| 2624 | if !reflect.DeepEqual(actual, expected) { |
| 2625 | t.Errorf("Got '%v', expected '%v'", actual, expected) |
| 2626 | } |
| 2627 | } |
| 2628 | |
| 2629 | assertApexName("com.android.vndk.vVER", "myapex") |
| 2630 | assertApexName("com.android.vndk.v28", "myapex_v28") |
| 2631 | } |
| 2632 | |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2633 | func TestVndkApexSkipsNativeBridgeSupportedModules(t *testing.T) { |
| 2634 | ctx, _ := testApex(t, ` |
| 2635 | apex_vndk { |
| 2636 | name: "myapex", |
| 2637 | key: "myapex.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 2638 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2639 | } |
| 2640 | |
| 2641 | apex_key { |
| 2642 | name: "myapex.key", |
| 2643 | public_key: "testkey.avbpubkey", |
| 2644 | private_key: "testkey.pem", |
| 2645 | } |
| 2646 | |
| 2647 | cc_library { |
| 2648 | name: "libvndk", |
| 2649 | srcs: ["mylib.cpp"], |
| 2650 | vendor_available: true, |
| 2651 | native_bridge_supported: true, |
| 2652 | host_supported: true, |
| 2653 | vndk: { |
| 2654 | enabled: true, |
| 2655 | }, |
| 2656 | system_shared_libs: [], |
| 2657 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2658 | apex_available: [ "myapex" ], |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2659 | } |
Jooyung Han | 35155c4 | 2020-02-06 17:33:20 +0900 | [diff] [blame] | 2660 | `+vndkLibrariesTxtFiles("current"), withNativeBridgeEnabled) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2661 | |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 2662 | ensureExactContents(t, ctx, "myapex", "android_common_image", []string{ |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2663 | "lib/libvndk.so", |
| 2664 | "lib64/libvndk.so", |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 2665 | "lib/libc++.so", |
| 2666 | "lib64/libc++.so", |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 2667 | "etc/*", |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2668 | }) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2669 | } |
| 2670 | |
| 2671 | func TestVndkApexDoesntSupportNativeBridgeSupported(t *testing.T) { |
| 2672 | testApexError(t, `module "myapex" .*: native_bridge_supported: .* doesn't support native bridge binary`, ` |
| 2673 | apex_vndk { |
| 2674 | name: "myapex", |
| 2675 | key: "myapex.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 2676 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 2677 | native_bridge_supported: true, |
| 2678 | } |
| 2679 | |
| 2680 | apex_key { |
| 2681 | name: "myapex.key", |
| 2682 | public_key: "testkey.avbpubkey", |
| 2683 | private_key: "testkey.pem", |
| 2684 | } |
| 2685 | |
| 2686 | cc_library { |
| 2687 | name: "libvndk", |
| 2688 | srcs: ["mylib.cpp"], |
| 2689 | vendor_available: true, |
| 2690 | native_bridge_supported: true, |
| 2691 | host_supported: true, |
| 2692 | vndk: { |
| 2693 | enabled: true, |
| 2694 | }, |
| 2695 | system_shared_libs: [], |
| 2696 | stl: "none", |
| 2697 | } |
| 2698 | `) |
| 2699 | } |
| 2700 | |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2701 | func TestVndkApexWithBinder32(t *testing.T) { |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 2702 | ctx, _ := testApex(t, ` |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2703 | apex_vndk { |
| 2704 | name: "myapex_v27", |
| 2705 | key: "myapex.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 2706 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2707 | vndk_version: "27", |
| 2708 | } |
| 2709 | |
| 2710 | apex_key { |
| 2711 | name: "myapex.key", |
| 2712 | public_key: "testkey.avbpubkey", |
| 2713 | private_key: "testkey.pem", |
| 2714 | } |
| 2715 | |
| 2716 | vndk_prebuilt_shared { |
| 2717 | name: "libvndk27", |
| 2718 | version: "27", |
| 2719 | target_arch: "arm", |
| 2720 | vendor_available: true, |
| 2721 | vndk: { |
| 2722 | enabled: true, |
| 2723 | }, |
| 2724 | arch: { |
| 2725 | arm: { |
| 2726 | srcs: ["libvndk27.so"], |
| 2727 | } |
| 2728 | }, |
| 2729 | } |
| 2730 | |
| 2731 | vndk_prebuilt_shared { |
| 2732 | name: "libvndk27", |
| 2733 | version: "27", |
| 2734 | target_arch: "arm", |
| 2735 | binder32bit: true, |
| 2736 | vendor_available: true, |
| 2737 | vndk: { |
| 2738 | enabled: true, |
| 2739 | }, |
| 2740 | arch: { |
| 2741 | arm: { |
| 2742 | srcs: ["libvndk27binder32.so"], |
| 2743 | } |
| 2744 | }, |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2745 | apex_available: [ "myapex_v27" ], |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2746 | } |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 2747 | `+vndkLibrariesTxtFiles("27"), |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2748 | withFiles(map[string][]byte{ |
| 2749 | "libvndk27.so": nil, |
| 2750 | "libvndk27binder32.so": nil, |
| 2751 | }), |
| 2752 | withBinder32bit, |
| 2753 | withTargets(map[android.OsType][]android.Target{ |
| 2754 | android.Android: []android.Target{ |
Jooyung Han | 35155c4 | 2020-02-06 17:33:20 +0900 | [diff] [blame] | 2755 | {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}, |
| 2756 | NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""}, |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2757 | }, |
| 2758 | }), |
| 2759 | ) |
| 2760 | |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 2761 | ensureExactContents(t, ctx, "myapex_v27", "android_common_image", []string{ |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2762 | "lib/libvndk27binder32.so", |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 2763 | "etc/*", |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 2764 | }) |
| 2765 | } |
| 2766 | |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 2767 | func TestDependenciesInApexManifest(t *testing.T) { |
| 2768 | ctx, _ := testApex(t, ` |
| 2769 | apex { |
| 2770 | name: "myapex_nodep", |
| 2771 | key: "myapex.key", |
| 2772 | native_shared_libs: ["lib_nodep"], |
| 2773 | compile_multilib: "both", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 2774 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 2775 | } |
| 2776 | |
| 2777 | apex { |
| 2778 | name: "myapex_dep", |
| 2779 | key: "myapex.key", |
| 2780 | native_shared_libs: ["lib_dep"], |
| 2781 | compile_multilib: "both", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 2782 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 2783 | } |
| 2784 | |
| 2785 | apex { |
| 2786 | name: "myapex_provider", |
| 2787 | key: "myapex.key", |
| 2788 | native_shared_libs: ["libfoo"], |
| 2789 | compile_multilib: "both", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 2790 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 2791 | } |
| 2792 | |
| 2793 | apex { |
| 2794 | name: "myapex_selfcontained", |
| 2795 | key: "myapex.key", |
| 2796 | native_shared_libs: ["lib_dep", "libfoo"], |
| 2797 | compile_multilib: "both", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 2798 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 2799 | } |
| 2800 | |
| 2801 | apex_key { |
| 2802 | name: "myapex.key", |
| 2803 | public_key: "testkey.avbpubkey", |
| 2804 | private_key: "testkey.pem", |
| 2805 | } |
| 2806 | |
| 2807 | cc_library { |
| 2808 | name: "lib_nodep", |
| 2809 | srcs: ["mylib.cpp"], |
| 2810 | system_shared_libs: [], |
| 2811 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2812 | apex_available: [ "myapex_nodep" ], |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 2813 | } |
| 2814 | |
| 2815 | cc_library { |
| 2816 | name: "lib_dep", |
| 2817 | srcs: ["mylib.cpp"], |
| 2818 | shared_libs: ["libfoo"], |
| 2819 | system_shared_libs: [], |
| 2820 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2821 | apex_available: [ |
| 2822 | "myapex_dep", |
| 2823 | "myapex_provider", |
| 2824 | "myapex_selfcontained", |
| 2825 | ], |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 2826 | } |
| 2827 | |
| 2828 | cc_library { |
| 2829 | name: "libfoo", |
| 2830 | srcs: ["mytest.cpp"], |
| 2831 | stubs: { |
| 2832 | versions: ["1"], |
| 2833 | }, |
| 2834 | system_shared_libs: [], |
| 2835 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2836 | apex_available: [ |
| 2837 | "myapex_provider", |
| 2838 | "myapex_selfcontained", |
| 2839 | ], |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 2840 | } |
| 2841 | `) |
| 2842 | |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 2843 | var apexManifestRule android.TestingBuildParams |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 2844 | var provideNativeLibs, requireNativeLibs []string |
| 2845 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 2846 | apexManifestRule = ctx.ModuleForTests("myapex_nodep", "android_common_myapex_nodep_image").Rule("apexManifestRule") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 2847 | provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"]) |
| 2848 | requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"]) |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 2849 | ensureListEmpty(t, provideNativeLibs) |
| 2850 | ensureListEmpty(t, requireNativeLibs) |
| 2851 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 2852 | apexManifestRule = ctx.ModuleForTests("myapex_dep", "android_common_myapex_dep_image").Rule("apexManifestRule") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 2853 | provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"]) |
| 2854 | requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"]) |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 2855 | ensureListEmpty(t, provideNativeLibs) |
| 2856 | ensureListContains(t, requireNativeLibs, "libfoo.so") |
| 2857 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 2858 | apexManifestRule = ctx.ModuleForTests("myapex_provider", "android_common_myapex_provider_image").Rule("apexManifestRule") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 2859 | provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"]) |
| 2860 | requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"]) |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 2861 | ensureListContains(t, provideNativeLibs, "libfoo.so") |
| 2862 | ensureListEmpty(t, requireNativeLibs) |
| 2863 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 2864 | apexManifestRule = ctx.ModuleForTests("myapex_selfcontained", "android_common_myapex_selfcontained_image").Rule("apexManifestRule") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 2865 | provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"]) |
| 2866 | requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"]) |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 2867 | ensureListContains(t, provideNativeLibs, "libfoo.so") |
| 2868 | ensureListEmpty(t, requireNativeLibs) |
| 2869 | } |
| 2870 | |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 2871 | func TestApexName(t *testing.T) { |
Jiyong Park | db33486 | 2020-02-05 17:19:28 +0900 | [diff] [blame] | 2872 | ctx, config := testApex(t, ` |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 2873 | apex { |
| 2874 | name: "myapex", |
| 2875 | key: "myapex.key", |
| 2876 | apex_name: "com.android.myapex", |
Jiyong Park | db33486 | 2020-02-05 17:19:28 +0900 | [diff] [blame] | 2877 | native_shared_libs: ["mylib"], |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 2878 | } |
| 2879 | |
| 2880 | apex_key { |
| 2881 | name: "myapex.key", |
| 2882 | public_key: "testkey.avbpubkey", |
| 2883 | private_key: "testkey.pem", |
| 2884 | } |
Jiyong Park | db33486 | 2020-02-05 17:19:28 +0900 | [diff] [blame] | 2885 | |
| 2886 | cc_library { |
| 2887 | name: "mylib", |
| 2888 | srcs: ["mylib.cpp"], |
| 2889 | system_shared_libs: [], |
| 2890 | stl: "none", |
| 2891 | apex_available: [ |
| 2892 | "//apex_available:platform", |
| 2893 | "myapex", |
| 2894 | ], |
| 2895 | } |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 2896 | `) |
| 2897 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 2898 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 2899 | apexManifestRule := module.Rule("apexManifestRule") |
| 2900 | ensureContains(t, apexManifestRule.Args["opt"], "-v name com.android.myapex") |
| 2901 | apexRule := module.Rule("apexRule") |
| 2902 | ensureContains(t, apexRule.Args["opt_flags"], "--do_not_check_keyname") |
Jiyong Park | db33486 | 2020-02-05 17:19:28 +0900 | [diff] [blame] | 2903 | |
| 2904 | apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
| 2905 | data := android.AndroidMkDataForTest(t, config, "", apexBundle) |
| 2906 | name := apexBundle.BaseModuleName() |
| 2907 | prefix := "TARGET_" |
| 2908 | var builder strings.Builder |
| 2909 | data.Custom(&builder, name, prefix, "", data) |
| 2910 | androidMk := builder.String() |
| 2911 | ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n") |
| 2912 | ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 2913 | } |
| 2914 | |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 2915 | func TestNonTestApex(t *testing.T) { |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 2916 | ctx, _ := testApex(t, ` |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 2917 | apex { |
| 2918 | name: "myapex", |
| 2919 | key: "myapex.key", |
| 2920 | native_shared_libs: ["mylib_common"], |
| 2921 | } |
| 2922 | |
| 2923 | apex_key { |
| 2924 | name: "myapex.key", |
| 2925 | public_key: "testkey.avbpubkey", |
| 2926 | private_key: "testkey.pem", |
| 2927 | } |
| 2928 | |
| 2929 | cc_library { |
| 2930 | name: "mylib_common", |
| 2931 | srcs: ["mylib.cpp"], |
| 2932 | system_shared_libs: [], |
| 2933 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2934 | apex_available: [ |
| 2935 | "//apex_available:platform", |
| 2936 | "myapex", |
| 2937 | ], |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 2938 | } |
| 2939 | `) |
| 2940 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 2941 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 2942 | apexRule := module.Rule("apexRule") |
| 2943 | copyCmds := apexRule.Args["copy_commands"] |
| 2944 | |
| 2945 | if apex, ok := module.Module().(*apexBundle); !ok || apex.testApex { |
| 2946 | t.Log("Apex was a test apex!") |
| 2947 | t.Fail() |
| 2948 | } |
| 2949 | // Ensure that main rule creates an output |
| 2950 | ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned") |
| 2951 | |
| 2952 | // Ensure that apex variant is created for the direct dep |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 2953 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_myapex") |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 2954 | |
| 2955 | // Ensure that both direct and indirect deps are copied into apex |
| 2956 | ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so") |
| 2957 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 2958 | // Ensure that the platform variant ends with _shared |
| 2959 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared") |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 2960 | |
| 2961 | if !android.InAnyApex("mylib_common") { |
| 2962 | t.Log("Found mylib_common not in any apex!") |
| 2963 | t.Fail() |
| 2964 | } |
| 2965 | } |
| 2966 | |
| 2967 | func TestTestApex(t *testing.T) { |
| 2968 | if android.InAnyApex("mylib_common_test") { |
| 2969 | t.Fatal("mylib_common_test must not be used in any other tests since this checks that global state is not updated in an illegal way!") |
| 2970 | } |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 2971 | ctx, _ := testApex(t, ` |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 2972 | apex_test { |
| 2973 | name: "myapex", |
| 2974 | key: "myapex.key", |
| 2975 | native_shared_libs: ["mylib_common_test"], |
| 2976 | } |
| 2977 | |
| 2978 | apex_key { |
| 2979 | name: "myapex.key", |
| 2980 | public_key: "testkey.avbpubkey", |
| 2981 | private_key: "testkey.pem", |
| 2982 | } |
| 2983 | |
| 2984 | cc_library { |
| 2985 | name: "mylib_common_test", |
| 2986 | srcs: ["mylib.cpp"], |
| 2987 | system_shared_libs: [], |
| 2988 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2989 | // TODO: remove //apex_available:platform |
| 2990 | apex_available: [ |
| 2991 | "//apex_available:platform", |
| 2992 | "myapex", |
| 2993 | ], |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 2994 | } |
| 2995 | `) |
| 2996 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 2997 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 2998 | apexRule := module.Rule("apexRule") |
| 2999 | copyCmds := apexRule.Args["copy_commands"] |
| 3000 | |
| 3001 | if apex, ok := module.Module().(*apexBundle); !ok || !apex.testApex { |
| 3002 | t.Log("Apex was not a test apex!") |
| 3003 | t.Fail() |
| 3004 | } |
| 3005 | // Ensure that main rule creates an output |
| 3006 | ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned") |
| 3007 | |
| 3008 | // Ensure that apex variant is created for the direct dep |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 3009 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared_myapex") |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 3010 | |
| 3011 | // Ensure that both direct and indirect deps are copied into apex |
| 3012 | ensureContains(t, copyCmds, "image.apex/lib64/mylib_common_test.so") |
| 3013 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 3014 | // Ensure that the platform variant ends with _shared |
| 3015 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared") |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 3016 | } |
| 3017 | |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 3018 | func TestApexWithTarget(t *testing.T) { |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 3019 | ctx, _ := testApex(t, ` |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 3020 | apex { |
| 3021 | name: "myapex", |
| 3022 | key: "myapex.key", |
| 3023 | multilib: { |
| 3024 | first: { |
| 3025 | native_shared_libs: ["mylib_common"], |
| 3026 | } |
| 3027 | }, |
| 3028 | target: { |
| 3029 | android: { |
| 3030 | multilib: { |
| 3031 | first: { |
| 3032 | native_shared_libs: ["mylib"], |
| 3033 | } |
| 3034 | } |
| 3035 | }, |
| 3036 | host: { |
| 3037 | multilib: { |
| 3038 | first: { |
| 3039 | native_shared_libs: ["mylib2"], |
| 3040 | } |
| 3041 | } |
| 3042 | } |
| 3043 | } |
| 3044 | } |
| 3045 | |
| 3046 | apex_key { |
| 3047 | name: "myapex.key", |
| 3048 | public_key: "testkey.avbpubkey", |
| 3049 | private_key: "testkey.pem", |
| 3050 | } |
| 3051 | |
| 3052 | cc_library { |
| 3053 | name: "mylib", |
| 3054 | srcs: ["mylib.cpp"], |
| 3055 | system_shared_libs: [], |
| 3056 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3057 | // TODO: remove //apex_available:platform |
| 3058 | apex_available: [ |
| 3059 | "//apex_available:platform", |
| 3060 | "myapex", |
| 3061 | ], |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 3062 | } |
| 3063 | |
| 3064 | cc_library { |
| 3065 | name: "mylib_common", |
| 3066 | srcs: ["mylib.cpp"], |
| 3067 | system_shared_libs: [], |
| 3068 | stl: "none", |
| 3069 | compile_multilib: "first", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3070 | // TODO: remove //apex_available:platform |
| 3071 | apex_available: [ |
| 3072 | "//apex_available:platform", |
| 3073 | "myapex", |
| 3074 | ], |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 3075 | } |
| 3076 | |
| 3077 | cc_library { |
| 3078 | name: "mylib2", |
| 3079 | srcs: ["mylib.cpp"], |
| 3080 | system_shared_libs: [], |
| 3081 | stl: "none", |
| 3082 | compile_multilib: "first", |
| 3083 | } |
| 3084 | `) |
| 3085 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 3086 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 3087 | copyCmds := apexRule.Args["copy_commands"] |
| 3088 | |
| 3089 | // Ensure that main rule creates an output |
| 3090 | ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned") |
| 3091 | |
| 3092 | // Ensure that apex variant is created for the direct dep |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 3093 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_myapex") |
| 3094 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_myapex") |
| 3095 | ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_myapex") |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 3096 | |
| 3097 | // Ensure that both direct and indirect deps are copied into apex |
| 3098 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
| 3099 | ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so") |
| 3100 | ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so") |
| 3101 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 3102 | // Ensure that the platform variant ends with _shared |
| 3103 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared") |
| 3104 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared") |
| 3105 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared") |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 3106 | } |
Jiyong Park | 04480cf | 2019-02-06 00:16:29 +0900 | [diff] [blame] | 3107 | |
| 3108 | func TestApexWithShBinary(t *testing.T) { |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 3109 | ctx, _ := testApex(t, ` |
Jiyong Park | 04480cf | 2019-02-06 00:16:29 +0900 | [diff] [blame] | 3110 | apex { |
| 3111 | name: "myapex", |
| 3112 | key: "myapex.key", |
| 3113 | binaries: ["myscript"], |
| 3114 | } |
| 3115 | |
| 3116 | apex_key { |
| 3117 | name: "myapex.key", |
| 3118 | public_key: "testkey.avbpubkey", |
| 3119 | private_key: "testkey.pem", |
| 3120 | } |
| 3121 | |
| 3122 | sh_binary { |
| 3123 | name: "myscript", |
| 3124 | src: "mylib.cpp", |
| 3125 | filename: "myscript.sh", |
| 3126 | sub_dir: "script", |
| 3127 | } |
| 3128 | `) |
| 3129 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 3130 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Jiyong Park | 04480cf | 2019-02-06 00:16:29 +0900 | [diff] [blame] | 3131 | copyCmds := apexRule.Args["copy_commands"] |
| 3132 | |
| 3133 | ensureContains(t, copyCmds, "image.apex/bin/script/myscript.sh") |
| 3134 | } |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 3135 | |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 3136 | func TestApexInVariousPartition(t *testing.T) { |
| 3137 | testcases := []struct { |
| 3138 | propName, parition, flattenedPartition string |
| 3139 | }{ |
| 3140 | {"", "system", "system_ext"}, |
| 3141 | {"product_specific: true", "product", "product"}, |
| 3142 | {"soc_specific: true", "vendor", "vendor"}, |
| 3143 | {"proprietary: true", "vendor", "vendor"}, |
| 3144 | {"vendor: true", "vendor", "vendor"}, |
| 3145 | {"system_ext_specific: true", "system_ext", "system_ext"}, |
| 3146 | } |
| 3147 | for _, tc := range testcases { |
| 3148 | t.Run(tc.propName+":"+tc.parition, func(t *testing.T) { |
| 3149 | ctx, _ := testApex(t, ` |
| 3150 | apex { |
| 3151 | name: "myapex", |
| 3152 | key: "myapex.key", |
| 3153 | `+tc.propName+` |
| 3154 | } |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 3155 | |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 3156 | apex_key { |
| 3157 | name: "myapex.key", |
| 3158 | public_key: "testkey.avbpubkey", |
| 3159 | private_key: "testkey.pem", |
| 3160 | } |
| 3161 | `) |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 3162 | |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 3163 | apex := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
| 3164 | expected := buildDir + "/target/product/test_device/" + tc.parition + "/apex" |
| 3165 | actual := apex.installDir.String() |
| 3166 | if actual != expected { |
| 3167 | t.Errorf("wrong install path. expected %q. actual %q", expected, actual) |
| 3168 | } |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 3169 | |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 3170 | flattened := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle) |
| 3171 | expected = buildDir + "/target/product/test_device/" + tc.flattenedPartition + "/apex" |
| 3172 | actual = flattened.installDir.String() |
| 3173 | if actual != expected { |
| 3174 | t.Errorf("wrong install path. expected %q. actual %q", expected, actual) |
| 3175 | } |
| 3176 | }) |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 3177 | } |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 3178 | } |
Jiyong Park | 6788256 | 2019-03-21 01:11:21 +0900 | [diff] [blame] | 3179 | |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3180 | func TestFileContexts(t *testing.T) { |
| 3181 | ctx, _ := testApex(t, ` |
| 3182 | apex { |
| 3183 | name: "myapex", |
| 3184 | key: "myapex.key", |
| 3185 | } |
| 3186 | |
| 3187 | apex_key { |
| 3188 | name: "myapex.key", |
| 3189 | public_key: "testkey.avbpubkey", |
| 3190 | private_key: "testkey.pem", |
| 3191 | } |
| 3192 | `) |
| 3193 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
| 3194 | apexRule := module.Rule("apexRule") |
| 3195 | actual := apexRule.Args["file_contexts"] |
| 3196 | expected := "system/sepolicy/apex/myapex-file_contexts" |
| 3197 | if actual != expected { |
| 3198 | t.Errorf("wrong file_contexts. expected %q. actual %q", expected, actual) |
| 3199 | } |
| 3200 | |
| 3201 | testApexError(t, `"myapex" .*: file_contexts: should be under system/sepolicy`, ` |
| 3202 | apex { |
| 3203 | name: "myapex", |
| 3204 | key: "myapex.key", |
| 3205 | file_contexts: "my_own_file_contexts", |
| 3206 | } |
| 3207 | |
| 3208 | apex_key { |
| 3209 | name: "myapex.key", |
| 3210 | public_key: "testkey.avbpubkey", |
| 3211 | private_key: "testkey.pem", |
| 3212 | } |
| 3213 | `, withFiles(map[string][]byte{ |
| 3214 | "my_own_file_contexts": nil, |
| 3215 | })) |
| 3216 | |
| 3217 | testApexError(t, `"myapex" .*: file_contexts: cannot find`, ` |
| 3218 | apex { |
| 3219 | name: "myapex", |
| 3220 | key: "myapex.key", |
| 3221 | product_specific: true, |
| 3222 | file_contexts: "product_specific_file_contexts", |
| 3223 | } |
| 3224 | |
| 3225 | apex_key { |
| 3226 | name: "myapex.key", |
| 3227 | public_key: "testkey.avbpubkey", |
| 3228 | private_key: "testkey.pem", |
| 3229 | } |
| 3230 | `) |
| 3231 | |
| 3232 | ctx, _ = testApex(t, ` |
| 3233 | apex { |
| 3234 | name: "myapex", |
| 3235 | key: "myapex.key", |
| 3236 | product_specific: true, |
| 3237 | file_contexts: "product_specific_file_contexts", |
| 3238 | } |
| 3239 | |
| 3240 | apex_key { |
| 3241 | name: "myapex.key", |
| 3242 | public_key: "testkey.avbpubkey", |
| 3243 | private_key: "testkey.pem", |
| 3244 | } |
| 3245 | `, withFiles(map[string][]byte{ |
| 3246 | "product_specific_file_contexts": nil, |
| 3247 | })) |
| 3248 | module = ctx.ModuleForTests("myapex", "android_common_myapex_image") |
| 3249 | apexRule = module.Rule("apexRule") |
| 3250 | actual = apexRule.Args["file_contexts"] |
| 3251 | expected = "product_specific_file_contexts" |
| 3252 | if actual != expected { |
| 3253 | t.Errorf("wrong file_contexts. expected %q. actual %q", expected, actual) |
| 3254 | } |
| 3255 | |
| 3256 | ctx, _ = testApex(t, ` |
| 3257 | apex { |
| 3258 | name: "myapex", |
| 3259 | key: "myapex.key", |
| 3260 | product_specific: true, |
| 3261 | file_contexts: ":my-file-contexts", |
| 3262 | } |
| 3263 | |
| 3264 | apex_key { |
| 3265 | name: "myapex.key", |
| 3266 | public_key: "testkey.avbpubkey", |
| 3267 | private_key: "testkey.pem", |
| 3268 | } |
| 3269 | |
| 3270 | filegroup { |
| 3271 | name: "my-file-contexts", |
| 3272 | srcs: ["product_specific_file_contexts"], |
| 3273 | } |
| 3274 | `, withFiles(map[string][]byte{ |
| 3275 | "product_specific_file_contexts": nil, |
| 3276 | })) |
| 3277 | module = ctx.ModuleForTests("myapex", "android_common_myapex_image") |
| 3278 | apexRule = module.Rule("apexRule") |
| 3279 | actual = apexRule.Args["file_contexts"] |
| 3280 | expected = "product_specific_file_contexts" |
| 3281 | if actual != expected { |
| 3282 | t.Errorf("wrong file_contexts. expected %q. actual %q", expected, actual) |
| 3283 | } |
| 3284 | } |
| 3285 | |
Jiyong Park | 6788256 | 2019-03-21 01:11:21 +0900 | [diff] [blame] | 3286 | func TestApexKeyFromOtherModule(t *testing.T) { |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 3287 | ctx, _ := testApex(t, ` |
Jiyong Park | 6788256 | 2019-03-21 01:11:21 +0900 | [diff] [blame] | 3288 | apex_key { |
| 3289 | name: "myapex.key", |
| 3290 | public_key: ":my.avbpubkey", |
| 3291 | private_key: ":my.pem", |
| 3292 | product_specific: true, |
| 3293 | } |
| 3294 | |
| 3295 | filegroup { |
| 3296 | name: "my.avbpubkey", |
| 3297 | srcs: ["testkey2.avbpubkey"], |
| 3298 | } |
| 3299 | |
| 3300 | filegroup { |
| 3301 | name: "my.pem", |
| 3302 | srcs: ["testkey2.pem"], |
| 3303 | } |
| 3304 | `) |
| 3305 | |
| 3306 | apex_key := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey) |
| 3307 | expected_pubkey := "testkey2.avbpubkey" |
| 3308 | actual_pubkey := apex_key.public_key_file.String() |
| 3309 | if actual_pubkey != expected_pubkey { |
| 3310 | t.Errorf("wrong public key path. expected %q. actual %q", expected_pubkey, actual_pubkey) |
| 3311 | } |
| 3312 | expected_privkey := "testkey2.pem" |
| 3313 | actual_privkey := apex_key.private_key_file.String() |
| 3314 | if actual_privkey != expected_privkey { |
| 3315 | t.Errorf("wrong private key path. expected %q. actual %q", expected_privkey, actual_privkey) |
| 3316 | } |
| 3317 | } |
Jaewoong Jung | 939ebd5 | 2019-03-26 15:07:36 -0700 | [diff] [blame] | 3318 | |
| 3319 | func TestPrebuilt(t *testing.T) { |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 3320 | ctx, _ := testApex(t, ` |
Jaewoong Jung | 939ebd5 | 2019-03-26 15:07:36 -0700 | [diff] [blame] | 3321 | prebuilt_apex { |
| 3322 | name: "myapex", |
Jiyong Park | c95714e | 2019-03-29 14:23:10 +0900 | [diff] [blame] | 3323 | arch: { |
| 3324 | arm64: { |
| 3325 | src: "myapex-arm64.apex", |
| 3326 | }, |
| 3327 | arm: { |
| 3328 | src: "myapex-arm.apex", |
| 3329 | }, |
| 3330 | }, |
Jaewoong Jung | 939ebd5 | 2019-03-26 15:07:36 -0700 | [diff] [blame] | 3331 | } |
| 3332 | `) |
| 3333 | |
| 3334 | prebuilt := ctx.ModuleForTests("myapex", "android_common").Module().(*Prebuilt) |
| 3335 | |
Jiyong Park | c95714e | 2019-03-29 14:23:10 +0900 | [diff] [blame] | 3336 | expectedInput := "myapex-arm64.apex" |
| 3337 | if prebuilt.inputApex.String() != expectedInput { |
| 3338 | t.Errorf("inputApex invalid. expected: %q, actual: %q", expectedInput, prebuilt.inputApex.String()) |
| 3339 | } |
Jaewoong Jung | 939ebd5 | 2019-03-26 15:07:36 -0700 | [diff] [blame] | 3340 | } |
Nikita Ioffe | 7a41ebd | 2019-04-04 18:09:48 +0100 | [diff] [blame] | 3341 | |
| 3342 | func TestPrebuiltFilenameOverride(t *testing.T) { |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 3343 | ctx, _ := testApex(t, ` |
Nikita Ioffe | 7a41ebd | 2019-04-04 18:09:48 +0100 | [diff] [blame] | 3344 | prebuilt_apex { |
| 3345 | name: "myapex", |
| 3346 | src: "myapex-arm.apex", |
| 3347 | filename: "notmyapex.apex", |
| 3348 | } |
| 3349 | `) |
| 3350 | |
| 3351 | p := ctx.ModuleForTests("myapex", "android_common").Module().(*Prebuilt) |
| 3352 | |
| 3353 | expected := "notmyapex.apex" |
| 3354 | if p.installFilename != expected { |
| 3355 | t.Errorf("installFilename invalid. expected: %q, actual: %q", expected, p.installFilename) |
| 3356 | } |
| 3357 | } |
Jaewoong Jung | c1001ec | 2019-06-25 11:20:53 -0700 | [diff] [blame] | 3358 | |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 3359 | func TestPrebuiltOverrides(t *testing.T) { |
| 3360 | ctx, config := testApex(t, ` |
| 3361 | prebuilt_apex { |
| 3362 | name: "myapex.prebuilt", |
| 3363 | src: "myapex-arm.apex", |
| 3364 | overrides: [ |
| 3365 | "myapex", |
| 3366 | ], |
| 3367 | } |
| 3368 | `) |
| 3369 | |
| 3370 | p := ctx.ModuleForTests("myapex.prebuilt", "android_common").Module().(*Prebuilt) |
| 3371 | |
| 3372 | expected := []string{"myapex"} |
Jiyong Park | 0b0e1b9 | 2019-12-03 13:24:29 +0900 | [diff] [blame] | 3373 | actual := android.AndroidMkEntriesForTest(t, config, "", p)[0].EntryMap["LOCAL_OVERRIDES_MODULES"] |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 3374 | if !reflect.DeepEqual(actual, expected) { |
Jiyong Park | b0a012c | 2019-11-14 17:17:03 +0900 | [diff] [blame] | 3375 | t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES value '%s', expected '%s'", actual, expected) |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 3376 | } |
| 3377 | } |
| 3378 | |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 3379 | func TestApexWithTests(t *testing.T) { |
Roland Levillain | f89cd09 | 2019-07-29 16:22:59 +0100 | [diff] [blame] | 3380 | ctx, config := testApex(t, ` |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 3381 | apex_test { |
| 3382 | name: "myapex", |
| 3383 | key: "myapex.key", |
| 3384 | tests: [ |
| 3385 | "mytest", |
Roland Levillain | 9b5fde9 | 2019-06-28 15:41:19 +0100 | [diff] [blame] | 3386 | "mytests", |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 3387 | ], |
| 3388 | } |
| 3389 | |
| 3390 | apex_key { |
| 3391 | name: "myapex.key", |
| 3392 | public_key: "testkey.avbpubkey", |
| 3393 | private_key: "testkey.pem", |
| 3394 | } |
| 3395 | |
Liz Kammer | 1c14a21 | 2020-05-12 15:26:55 -0700 | [diff] [blame] | 3396 | filegroup { |
| 3397 | name: "fg", |
| 3398 | srcs: [ |
| 3399 | "baz", |
| 3400 | "bar/baz" |
| 3401 | ], |
| 3402 | } |
| 3403 | |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 3404 | cc_test { |
| 3405 | name: "mytest", |
| 3406 | gtest: false, |
| 3407 | srcs: ["mytest.cpp"], |
| 3408 | relative_install_path: "test", |
Jiyong Park | af9539f | 2020-05-04 10:31:32 +0900 | [diff] [blame] | 3409 | shared_libs: ["mylib"], |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 3410 | system_shared_libs: [], |
| 3411 | static_executable: true, |
| 3412 | stl: "none", |
Liz Kammer | 1c14a21 | 2020-05-12 15:26:55 -0700 | [diff] [blame] | 3413 | data: [":fg"], |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 3414 | } |
Roland Levillain | 9b5fde9 | 2019-06-28 15:41:19 +0100 | [diff] [blame] | 3415 | |
Jiyong Park | af9539f | 2020-05-04 10:31:32 +0900 | [diff] [blame] | 3416 | cc_library { |
| 3417 | name: "mylib", |
| 3418 | srcs: ["mylib.cpp"], |
| 3419 | system_shared_libs: [], |
| 3420 | stl: "none", |
| 3421 | } |
| 3422 | |
Roland Levillain | 9b5fde9 | 2019-06-28 15:41:19 +0100 | [diff] [blame] | 3423 | cc_test { |
| 3424 | name: "mytests", |
| 3425 | gtest: false, |
| 3426 | srcs: [ |
| 3427 | "mytest1.cpp", |
| 3428 | "mytest2.cpp", |
| 3429 | "mytest3.cpp", |
| 3430 | ], |
| 3431 | test_per_src: true, |
| 3432 | relative_install_path: "test", |
| 3433 | system_shared_libs: [], |
| 3434 | static_executable: true, |
| 3435 | stl: "none", |
| 3436 | } |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 3437 | `) |
| 3438 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 3439 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 3440 | copyCmds := apexRule.Args["copy_commands"] |
| 3441 | |
Jiyong Park | af9539f | 2020-05-04 10:31:32 +0900 | [diff] [blame] | 3442 | // Ensure that test dep (and their transitive dependencies) are copied into apex. |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 3443 | ensureContains(t, copyCmds, "image.apex/bin/test/mytest") |
Jiyong Park | af9539f | 2020-05-04 10:31:32 +0900 | [diff] [blame] | 3444 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
Roland Levillain | 9b5fde9 | 2019-06-28 15:41:19 +0100 | [diff] [blame] | 3445 | |
Liz Kammer | 1c14a21 | 2020-05-12 15:26:55 -0700 | [diff] [blame] | 3446 | //Ensure that test data are copied into apex. |
| 3447 | ensureContains(t, copyCmds, "image.apex/bin/test/baz") |
| 3448 | ensureContains(t, copyCmds, "image.apex/bin/test/bar/baz") |
| 3449 | |
Roland Levillain | 9b5fde9 | 2019-06-28 15:41:19 +0100 | [diff] [blame] | 3450 | // Ensure that test deps built with `test_per_src` are copied into apex. |
| 3451 | ensureContains(t, copyCmds, "image.apex/bin/test/mytest1") |
| 3452 | ensureContains(t, copyCmds, "image.apex/bin/test/mytest2") |
| 3453 | ensureContains(t, copyCmds, "image.apex/bin/test/mytest3") |
Roland Levillain | f89cd09 | 2019-07-29 16:22:59 +0100 | [diff] [blame] | 3454 | |
| 3455 | // Ensure the module is correctly translated. |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 3456 | apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Roland Levillain | f89cd09 | 2019-07-29 16:22:59 +0100 | [diff] [blame] | 3457 | data := android.AndroidMkDataForTest(t, config, "", apexBundle) |
| 3458 | name := apexBundle.BaseModuleName() |
| 3459 | prefix := "TARGET_" |
| 3460 | var builder strings.Builder |
| 3461 | data.Custom(&builder, name, prefix, "", data) |
| 3462 | androidMk := builder.String() |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3463 | ensureContains(t, androidMk, "LOCAL_MODULE := mytest.myapex\n") |
| 3464 | ensureContains(t, androidMk, "LOCAL_MODULE := mytest1.myapex\n") |
| 3465 | ensureContains(t, androidMk, "LOCAL_MODULE := mytest2.myapex\n") |
| 3466 | ensureContains(t, androidMk, "LOCAL_MODULE := mytest3.myapex\n") |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 3467 | ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex\n") |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3468 | ensureContains(t, androidMk, "LOCAL_MODULE := apex_pubkey.myapex\n") |
Roland Levillain | f89cd09 | 2019-07-29 16:22:59 +0100 | [diff] [blame] | 3469 | ensureContains(t, androidMk, "LOCAL_MODULE := myapex\n") |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 3470 | } |
| 3471 | |
Jooyung Han | 3ab2c3e | 2019-12-05 16:27:44 +0900 | [diff] [blame] | 3472 | func TestInstallExtraFlattenedApexes(t *testing.T) { |
| 3473 | ctx, config := testApex(t, ` |
| 3474 | apex { |
| 3475 | name: "myapex", |
| 3476 | key: "myapex.key", |
| 3477 | } |
| 3478 | apex_key { |
| 3479 | name: "myapex.key", |
| 3480 | public_key: "testkey.avbpubkey", |
| 3481 | private_key: "testkey.pem", |
| 3482 | } |
| 3483 | `, func(fs map[string][]byte, config android.Config) { |
| 3484 | config.TestProductVariables.InstallExtraFlattenedApexes = proptools.BoolPtr(true) |
| 3485 | }) |
| 3486 | ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 3487 | ensureListContains(t, ab.requiredDeps, "myapex.flattened") |
Jooyung Han | 3ab2c3e | 2019-12-05 16:27:44 +0900 | [diff] [blame] | 3488 | mk := android.AndroidMkDataForTest(t, config, "", ab) |
| 3489 | var builder strings.Builder |
| 3490 | mk.Custom(&builder, ab.Name(), "TARGET_", "", mk) |
| 3491 | androidMk := builder.String() |
| 3492 | ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += myapex.flattened") |
| 3493 | } |
| 3494 | |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 3495 | func TestApexUsesOtherApex(t *testing.T) { |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 3496 | ctx, _ := testApex(t, ` |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 3497 | apex { |
| 3498 | name: "myapex", |
| 3499 | key: "myapex.key", |
| 3500 | native_shared_libs: ["mylib"], |
| 3501 | uses: ["commonapex"], |
| 3502 | } |
| 3503 | |
| 3504 | apex { |
| 3505 | name: "commonapex", |
| 3506 | key: "myapex.key", |
| 3507 | native_shared_libs: ["libcommon"], |
| 3508 | provide_cpp_shared_libs: true, |
| 3509 | } |
| 3510 | |
| 3511 | apex_key { |
| 3512 | name: "myapex.key", |
| 3513 | public_key: "testkey.avbpubkey", |
| 3514 | private_key: "testkey.pem", |
| 3515 | } |
| 3516 | |
| 3517 | cc_library { |
| 3518 | name: "mylib", |
| 3519 | srcs: ["mylib.cpp"], |
| 3520 | shared_libs: ["libcommon"], |
| 3521 | system_shared_libs: [], |
| 3522 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3523 | apex_available: [ "myapex" ], |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 3524 | } |
| 3525 | |
| 3526 | cc_library { |
| 3527 | name: "libcommon", |
| 3528 | srcs: ["mylib_common.cpp"], |
| 3529 | system_shared_libs: [], |
| 3530 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3531 | // TODO: remove //apex_available:platform |
| 3532 | apex_available: [ |
| 3533 | "//apex_available:platform", |
| 3534 | "commonapex", |
| 3535 | "myapex", |
| 3536 | ], |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 3537 | } |
| 3538 | `) |
| 3539 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 3540 | module1 := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 3541 | apexRule1 := module1.Rule("apexRule") |
| 3542 | copyCmds1 := apexRule1.Args["copy_commands"] |
| 3543 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 3544 | module2 := ctx.ModuleForTests("commonapex", "android_common_commonapex_image") |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 3545 | apexRule2 := module2.Rule("apexRule") |
| 3546 | copyCmds2 := apexRule2.Args["copy_commands"] |
| 3547 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 3548 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_myapex") |
| 3549 | ensureListContains(t, ctx.ModuleVariantsForTests("libcommon"), "android_arm64_armv8-a_shared_commonapex") |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 3550 | ensureContains(t, copyCmds1, "image.apex/lib64/mylib.so") |
| 3551 | ensureContains(t, copyCmds2, "image.apex/lib64/libcommon.so") |
| 3552 | ensureNotContains(t, copyCmds1, "image.apex/lib64/libcommon.so") |
| 3553 | } |
| 3554 | |
| 3555 | func TestApexUsesFailsIfNotProvided(t *testing.T) { |
| 3556 | testApexError(t, `uses: "commonapex" does not provide native_shared_libs`, ` |
| 3557 | apex { |
| 3558 | name: "myapex", |
| 3559 | key: "myapex.key", |
| 3560 | uses: ["commonapex"], |
| 3561 | } |
| 3562 | |
| 3563 | apex { |
| 3564 | name: "commonapex", |
| 3565 | key: "myapex.key", |
| 3566 | } |
| 3567 | |
| 3568 | apex_key { |
| 3569 | name: "myapex.key", |
| 3570 | public_key: "testkey.avbpubkey", |
| 3571 | private_key: "testkey.pem", |
| 3572 | } |
| 3573 | `) |
| 3574 | testApexError(t, `uses: "commonapex" is not a provider`, ` |
| 3575 | apex { |
| 3576 | name: "myapex", |
| 3577 | key: "myapex.key", |
| 3578 | uses: ["commonapex"], |
| 3579 | } |
| 3580 | |
| 3581 | cc_library { |
| 3582 | name: "commonapex", |
| 3583 | system_shared_libs: [], |
| 3584 | stl: "none", |
| 3585 | } |
| 3586 | |
| 3587 | apex_key { |
| 3588 | name: "myapex.key", |
| 3589 | public_key: "testkey.avbpubkey", |
| 3590 | private_key: "testkey.pem", |
| 3591 | } |
| 3592 | `) |
| 3593 | } |
| 3594 | |
| 3595 | func TestApexUsesFailsIfUseVenderMismatch(t *testing.T) { |
| 3596 | testApexError(t, `use_vendor: "commonapex" has different value of use_vendor`, ` |
| 3597 | apex { |
| 3598 | name: "myapex", |
| 3599 | key: "myapex.key", |
| 3600 | use_vendor: true, |
| 3601 | uses: ["commonapex"], |
| 3602 | } |
| 3603 | |
| 3604 | apex { |
| 3605 | name: "commonapex", |
| 3606 | key: "myapex.key", |
| 3607 | provide_cpp_shared_libs: true, |
| 3608 | } |
| 3609 | |
| 3610 | apex_key { |
| 3611 | name: "myapex.key", |
| 3612 | public_key: "testkey.avbpubkey", |
| 3613 | private_key: "testkey.pem", |
| 3614 | } |
Jooyung Han | dc78244 | 2019-11-01 03:14:38 +0900 | [diff] [blame] | 3615 | `, func(fs map[string][]byte, config android.Config) { |
| 3616 | setUseVendorWhitelistForTest(config, []string{"myapex"}) |
| 3617 | }) |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 3618 | } |
| 3619 | |
Jooyung Han | d48f3c3 | 2019-08-23 11:18:57 +0900 | [diff] [blame] | 3620 | func TestErrorsIfDepsAreNotEnabled(t *testing.T) { |
| 3621 | testApexError(t, `module "myapex" .* depends on disabled module "libfoo"`, ` |
| 3622 | apex { |
| 3623 | name: "myapex", |
| 3624 | key: "myapex.key", |
| 3625 | native_shared_libs: ["libfoo"], |
| 3626 | } |
| 3627 | |
| 3628 | apex_key { |
| 3629 | name: "myapex.key", |
| 3630 | public_key: "testkey.avbpubkey", |
| 3631 | private_key: "testkey.pem", |
| 3632 | } |
| 3633 | |
| 3634 | cc_library { |
| 3635 | name: "libfoo", |
| 3636 | stl: "none", |
| 3637 | system_shared_libs: [], |
| 3638 | enabled: false, |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 3639 | apex_available: ["myapex"], |
Jooyung Han | d48f3c3 | 2019-08-23 11:18:57 +0900 | [diff] [blame] | 3640 | } |
| 3641 | `) |
| 3642 | testApexError(t, `module "myapex" .* depends on disabled module "myjar"`, ` |
| 3643 | apex { |
| 3644 | name: "myapex", |
| 3645 | key: "myapex.key", |
| 3646 | java_libs: ["myjar"], |
| 3647 | } |
| 3648 | |
| 3649 | apex_key { |
| 3650 | name: "myapex.key", |
| 3651 | public_key: "testkey.avbpubkey", |
| 3652 | private_key: "testkey.pem", |
| 3653 | } |
| 3654 | |
| 3655 | java_library { |
| 3656 | name: "myjar", |
| 3657 | srcs: ["foo/bar/MyClass.java"], |
| 3658 | sdk_version: "none", |
| 3659 | system_modules: "none", |
Jooyung Han | d48f3c3 | 2019-08-23 11:18:57 +0900 | [diff] [blame] | 3660 | enabled: false, |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 3661 | apex_available: ["myapex"], |
Jooyung Han | d48f3c3 | 2019-08-23 11:18:57 +0900 | [diff] [blame] | 3662 | } |
| 3663 | `) |
| 3664 | } |
| 3665 | |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 3666 | func TestApexWithApps(t *testing.T) { |
| 3667 | ctx, _ := testApex(t, ` |
| 3668 | apex { |
| 3669 | name: "myapex", |
| 3670 | key: "myapex.key", |
| 3671 | apps: [ |
| 3672 | "AppFoo", |
Jiyong Park | f748731 | 2019-10-17 12:54:30 +0900 | [diff] [blame] | 3673 | "AppFooPriv", |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 3674 | ], |
| 3675 | } |
| 3676 | |
| 3677 | apex_key { |
| 3678 | name: "myapex.key", |
| 3679 | public_key: "testkey.avbpubkey", |
| 3680 | private_key: "testkey.pem", |
| 3681 | } |
| 3682 | |
| 3683 | android_app { |
| 3684 | name: "AppFoo", |
| 3685 | srcs: ["foo/bar/MyClass.java"], |
Colin Cross | 094cde4 | 2020-02-15 10:38:00 -0800 | [diff] [blame] | 3686 | sdk_version: "current", |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 3687 | system_modules: "none", |
Jiyong Park | 8be103b | 2019-11-08 15:53:48 +0900 | [diff] [blame] | 3688 | jni_libs: ["libjni"], |
Colin Cross | 094cde4 | 2020-02-15 10:38:00 -0800 | [diff] [blame] | 3689 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3690 | apex_available: [ "myapex" ], |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 3691 | } |
Jiyong Park | f748731 | 2019-10-17 12:54:30 +0900 | [diff] [blame] | 3692 | |
| 3693 | android_app { |
| 3694 | name: "AppFooPriv", |
| 3695 | srcs: ["foo/bar/MyClass.java"], |
Colin Cross | 094cde4 | 2020-02-15 10:38:00 -0800 | [diff] [blame] | 3696 | sdk_version: "current", |
Jiyong Park | f748731 | 2019-10-17 12:54:30 +0900 | [diff] [blame] | 3697 | system_modules: "none", |
| 3698 | privileged: true, |
Colin Cross | 094cde4 | 2020-02-15 10:38:00 -0800 | [diff] [blame] | 3699 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3700 | apex_available: [ "myapex" ], |
Jiyong Park | f748731 | 2019-10-17 12:54:30 +0900 | [diff] [blame] | 3701 | } |
Jiyong Park | 8be103b | 2019-11-08 15:53:48 +0900 | [diff] [blame] | 3702 | |
| 3703 | cc_library_shared { |
| 3704 | name: "libjni", |
| 3705 | srcs: ["mylib.cpp"], |
Jooyung Han | b7bebe2 | 2020-02-25 16:59:29 +0900 | [diff] [blame] | 3706 | shared_libs: ["libfoo"], |
| 3707 | stl: "none", |
| 3708 | system_shared_libs: [], |
| 3709 | apex_available: [ "myapex" ], |
| 3710 | sdk_version: "current", |
| 3711 | } |
| 3712 | |
| 3713 | cc_library_shared { |
| 3714 | name: "libfoo", |
Jiyong Park | 8be103b | 2019-11-08 15:53:48 +0900 | [diff] [blame] | 3715 | stl: "none", |
| 3716 | system_shared_libs: [], |
Jiyong Park | 0f80c18 | 2020-01-31 02:49:53 +0900 | [diff] [blame] | 3717 | apex_available: [ "myapex" ], |
Colin Cross | 094cde4 | 2020-02-15 10:38:00 -0800 | [diff] [blame] | 3718 | sdk_version: "current", |
Jiyong Park | 8be103b | 2019-11-08 15:53:48 +0900 | [diff] [blame] | 3719 | } |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 3720 | `) |
| 3721 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 3722 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 3723 | apexRule := module.Rule("apexRule") |
| 3724 | copyCmds := apexRule.Args["copy_commands"] |
| 3725 | |
| 3726 | ensureContains(t, copyCmds, "image.apex/app/AppFoo/AppFoo.apk") |
Jiyong Park | f748731 | 2019-10-17 12:54:30 +0900 | [diff] [blame] | 3727 | ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPriv/AppFooPriv.apk") |
Jiyong Park | 52cd06f | 2019-11-11 10:14:32 +0900 | [diff] [blame] | 3728 | |
Jooyung Han | b7bebe2 | 2020-02-25 16:59:29 +0900 | [diff] [blame] | 3729 | appZipRule := ctx.ModuleForTests("AppFoo", "android_common_myapex").Description("zip jni libs") |
| 3730 | // JNI libraries are uncompressed |
Jiyong Park | 52cd06f | 2019-11-11 10:14:32 +0900 | [diff] [blame] | 3731 | if args := appZipRule.Args["jarArgs"]; !strings.Contains(args, "-L 0") { |
Jooyung Han | b7bebe2 | 2020-02-25 16:59:29 +0900 | [diff] [blame] | 3732 | t.Errorf("jni libs are not uncompressed for AppFoo") |
Jiyong Park | 52cd06f | 2019-11-11 10:14:32 +0900 | [diff] [blame] | 3733 | } |
Jooyung Han | b7bebe2 | 2020-02-25 16:59:29 +0900 | [diff] [blame] | 3734 | // JNI libraries including transitive deps are |
| 3735 | for _, jni := range []string{"libjni", "libfoo"} { |
Colin Cross | c511bc5 | 2020-04-07 16:50:32 +0000 | [diff] [blame] | 3736 | jniOutput := ctx.ModuleForTests(jni, "android_arm64_armv8-a_sdk_shared_myapex").Module().(*cc.Module).OutputFile() |
Jooyung Han | b7bebe2 | 2020-02-25 16:59:29 +0900 | [diff] [blame] | 3737 | // ... embedded inside APK (jnilibs.zip) |
| 3738 | ensureListContains(t, appZipRule.Implicits.Strings(), jniOutput.String()) |
| 3739 | // ... and not directly inside the APEX |
| 3740 | ensureNotContains(t, copyCmds, "image.apex/lib64/"+jni+".so") |
| 3741 | } |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 3742 | } |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 3743 | |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 3744 | func TestApexWithAppImports(t *testing.T) { |
| 3745 | ctx, _ := testApex(t, ` |
| 3746 | apex { |
| 3747 | name: "myapex", |
| 3748 | key: "myapex.key", |
| 3749 | apps: [ |
| 3750 | "AppFooPrebuilt", |
| 3751 | "AppFooPrivPrebuilt", |
| 3752 | ], |
| 3753 | } |
| 3754 | |
| 3755 | apex_key { |
| 3756 | name: "myapex.key", |
| 3757 | public_key: "testkey.avbpubkey", |
| 3758 | private_key: "testkey.pem", |
| 3759 | } |
| 3760 | |
| 3761 | android_app_import { |
| 3762 | name: "AppFooPrebuilt", |
| 3763 | apk: "PrebuiltAppFoo.apk", |
| 3764 | presigned: true, |
| 3765 | dex_preopt: { |
| 3766 | enabled: false, |
| 3767 | }, |
Jiyong Park | 592a6a4 | 2020-04-21 22:34:28 +0900 | [diff] [blame] | 3768 | apex_available: ["myapex"], |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 3769 | } |
| 3770 | |
| 3771 | android_app_import { |
| 3772 | name: "AppFooPrivPrebuilt", |
| 3773 | apk: "PrebuiltAppFooPriv.apk", |
| 3774 | privileged: true, |
| 3775 | presigned: true, |
| 3776 | dex_preopt: { |
| 3777 | enabled: false, |
| 3778 | }, |
Jooyung Han | 39ee119 | 2020-03-23 20:21:11 +0900 | [diff] [blame] | 3779 | filename: "AwesomePrebuiltAppFooPriv.apk", |
Jiyong Park | 592a6a4 | 2020-04-21 22:34:28 +0900 | [diff] [blame] | 3780 | apex_available: ["myapex"], |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 3781 | } |
| 3782 | `) |
| 3783 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 3784 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 3785 | apexRule := module.Rule("apexRule") |
| 3786 | copyCmds := apexRule.Args["copy_commands"] |
| 3787 | |
| 3788 | ensureContains(t, copyCmds, "image.apex/app/AppFooPrebuilt/AppFooPrebuilt.apk") |
Jooyung Han | 39ee119 | 2020-03-23 20:21:11 +0900 | [diff] [blame] | 3789 | ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPrivPrebuilt/AwesomePrebuiltAppFooPriv.apk") |
| 3790 | } |
| 3791 | |
| 3792 | func TestApexWithAppImportsPrefer(t *testing.T) { |
| 3793 | ctx, _ := testApex(t, ` |
| 3794 | apex { |
| 3795 | name: "myapex", |
| 3796 | key: "myapex.key", |
| 3797 | apps: [ |
| 3798 | "AppFoo", |
| 3799 | ], |
| 3800 | } |
| 3801 | |
| 3802 | apex_key { |
| 3803 | name: "myapex.key", |
| 3804 | public_key: "testkey.avbpubkey", |
| 3805 | private_key: "testkey.pem", |
| 3806 | } |
| 3807 | |
| 3808 | android_app { |
| 3809 | name: "AppFoo", |
| 3810 | srcs: ["foo/bar/MyClass.java"], |
| 3811 | sdk_version: "none", |
| 3812 | system_modules: "none", |
| 3813 | apex_available: [ "myapex" ], |
| 3814 | } |
| 3815 | |
| 3816 | android_app_import { |
| 3817 | name: "AppFoo", |
| 3818 | apk: "AppFooPrebuilt.apk", |
| 3819 | filename: "AppFooPrebuilt.apk", |
| 3820 | presigned: true, |
| 3821 | prefer: true, |
Jiyong Park | 592a6a4 | 2020-04-21 22:34:28 +0900 | [diff] [blame] | 3822 | apex_available: ["myapex"], |
Jooyung Han | 39ee119 | 2020-03-23 20:21:11 +0900 | [diff] [blame] | 3823 | } |
| 3824 | `, withFiles(map[string][]byte{ |
| 3825 | "AppFooPrebuilt.apk": nil, |
| 3826 | })) |
| 3827 | |
| 3828 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 3829 | "app/AppFoo/AppFooPrebuilt.apk", |
| 3830 | }) |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 3831 | } |
| 3832 | |
Dario Freni | 6f3937c | 2019-12-20 22:58:03 +0000 | [diff] [blame] | 3833 | func TestApexWithTestHelperApp(t *testing.T) { |
| 3834 | ctx, _ := testApex(t, ` |
| 3835 | apex { |
| 3836 | name: "myapex", |
| 3837 | key: "myapex.key", |
| 3838 | apps: [ |
| 3839 | "TesterHelpAppFoo", |
| 3840 | ], |
| 3841 | } |
| 3842 | |
| 3843 | apex_key { |
| 3844 | name: "myapex.key", |
| 3845 | public_key: "testkey.avbpubkey", |
| 3846 | private_key: "testkey.pem", |
| 3847 | } |
| 3848 | |
| 3849 | android_test_helper_app { |
| 3850 | name: "TesterHelpAppFoo", |
| 3851 | srcs: ["foo/bar/MyClass.java"], |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3852 | apex_available: [ "myapex" ], |
Dario Freni | 6f3937c | 2019-12-20 22:58:03 +0000 | [diff] [blame] | 3853 | } |
| 3854 | |
| 3855 | `) |
| 3856 | |
| 3857 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
| 3858 | apexRule := module.Rule("apexRule") |
| 3859 | copyCmds := apexRule.Args["copy_commands"] |
| 3860 | |
| 3861 | ensureContains(t, copyCmds, "image.apex/app/TesterHelpAppFoo/TesterHelpAppFoo.apk") |
| 3862 | } |
| 3863 | |
Jooyung Han | 18020ea | 2019-11-13 10:50:48 +0900 | [diff] [blame] | 3864 | func TestApexPropertiesShouldBeDefaultable(t *testing.T) { |
| 3865 | // libfoo's apex_available comes from cc_defaults |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 3866 | testApexError(t, `requires "libfoo" that is not available for the APEX`, ` |
Jooyung Han | 18020ea | 2019-11-13 10:50:48 +0900 | [diff] [blame] | 3867 | apex { |
| 3868 | name: "myapex", |
| 3869 | key: "myapex.key", |
| 3870 | native_shared_libs: ["libfoo"], |
| 3871 | } |
| 3872 | |
| 3873 | apex_key { |
| 3874 | name: "myapex.key", |
| 3875 | public_key: "testkey.avbpubkey", |
| 3876 | private_key: "testkey.pem", |
| 3877 | } |
| 3878 | |
| 3879 | apex { |
| 3880 | name: "otherapex", |
| 3881 | key: "myapex.key", |
| 3882 | native_shared_libs: ["libfoo"], |
| 3883 | } |
| 3884 | |
| 3885 | cc_defaults { |
| 3886 | name: "libfoo-defaults", |
| 3887 | apex_available: ["otherapex"], |
| 3888 | } |
| 3889 | |
| 3890 | cc_library { |
| 3891 | name: "libfoo", |
| 3892 | defaults: ["libfoo-defaults"], |
| 3893 | stl: "none", |
| 3894 | system_shared_libs: [], |
| 3895 | }`) |
| 3896 | } |
| 3897 | |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 3898 | func TestApexAvailable_DirectDep(t *testing.T) { |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 3899 | // libfoo is not available to myapex, but only to otherapex |
| 3900 | testApexError(t, "requires \"libfoo\" that is not available for the APEX", ` |
| 3901 | apex { |
| 3902 | name: "myapex", |
| 3903 | key: "myapex.key", |
| 3904 | native_shared_libs: ["libfoo"], |
| 3905 | } |
| 3906 | |
| 3907 | apex_key { |
| 3908 | name: "myapex.key", |
| 3909 | public_key: "testkey.avbpubkey", |
| 3910 | private_key: "testkey.pem", |
| 3911 | } |
| 3912 | |
| 3913 | apex { |
| 3914 | name: "otherapex", |
| 3915 | key: "otherapex.key", |
| 3916 | native_shared_libs: ["libfoo"], |
| 3917 | } |
| 3918 | |
| 3919 | apex_key { |
| 3920 | name: "otherapex.key", |
| 3921 | public_key: "testkey.avbpubkey", |
| 3922 | private_key: "testkey.pem", |
| 3923 | } |
| 3924 | |
| 3925 | cc_library { |
| 3926 | name: "libfoo", |
| 3927 | stl: "none", |
| 3928 | system_shared_libs: [], |
| 3929 | apex_available: ["otherapex"], |
| 3930 | }`) |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 3931 | } |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 3932 | |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 3933 | func TestApexAvailable_IndirectDep(t *testing.T) { |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 3934 | // libbbaz is an indirect dep |
Paul Duffin | df915ff | 2020-03-30 17:58:21 +0100 | [diff] [blame] | 3935 | testApexError(t, `requires "libbaz" that is not available for the APEX. Dependency path: |
Paul Duffin | c519244 | 2020-03-31 11:31:36 +0100 | [diff] [blame] | 3936 | .*via tag apex\.dependencyTag.*"sharedLib".* |
Paul Duffin | df915ff | 2020-03-30 17:58:21 +0100 | [diff] [blame] | 3937 | .*-> libfoo.*link:shared.* |
Paul Duffin | 6534770 | 2020-03-31 15:23:40 +0100 | [diff] [blame] | 3938 | .*via tag cc\.DependencyTag.*"shared".* |
Paul Duffin | df915ff | 2020-03-30 17:58:21 +0100 | [diff] [blame] | 3939 | .*-> libbar.*link:shared.* |
Paul Duffin | 6534770 | 2020-03-31 15:23:40 +0100 | [diff] [blame] | 3940 | .*via tag cc\.DependencyTag.*"shared".* |
| 3941 | .*-> libbaz.*link:shared.*`, ` |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 3942 | apex { |
| 3943 | name: "myapex", |
| 3944 | key: "myapex.key", |
| 3945 | native_shared_libs: ["libfoo"], |
| 3946 | } |
| 3947 | |
| 3948 | apex_key { |
| 3949 | name: "myapex.key", |
| 3950 | public_key: "testkey.avbpubkey", |
| 3951 | private_key: "testkey.pem", |
| 3952 | } |
| 3953 | |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 3954 | cc_library { |
| 3955 | name: "libfoo", |
| 3956 | stl: "none", |
| 3957 | shared_libs: ["libbar"], |
| 3958 | system_shared_libs: [], |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 3959 | apex_available: ["myapex"], |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 3960 | } |
| 3961 | |
| 3962 | cc_library { |
| 3963 | name: "libbar", |
| 3964 | stl: "none", |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 3965 | shared_libs: ["libbaz"], |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 3966 | system_shared_libs: [], |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 3967 | apex_available: ["myapex"], |
| 3968 | } |
| 3969 | |
| 3970 | cc_library { |
| 3971 | name: "libbaz", |
| 3972 | stl: "none", |
| 3973 | system_shared_libs: [], |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 3974 | }`) |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 3975 | } |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 3976 | |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 3977 | func TestApexAvailable_InvalidApexName(t *testing.T) { |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 3978 | testApexError(t, "\"otherapex\" is not a valid module name", ` |
| 3979 | apex { |
| 3980 | name: "myapex", |
| 3981 | key: "myapex.key", |
| 3982 | native_shared_libs: ["libfoo"], |
| 3983 | } |
| 3984 | |
| 3985 | apex_key { |
| 3986 | name: "myapex.key", |
| 3987 | public_key: "testkey.avbpubkey", |
| 3988 | private_key: "testkey.pem", |
| 3989 | } |
| 3990 | |
| 3991 | cc_library { |
| 3992 | name: "libfoo", |
| 3993 | stl: "none", |
| 3994 | system_shared_libs: [], |
| 3995 | apex_available: ["otherapex"], |
| 3996 | }`) |
| 3997 | |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 3998 | testApex(t, ` |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 3999 | apex { |
| 4000 | name: "myapex", |
| 4001 | key: "myapex.key", |
| 4002 | native_shared_libs: ["libfoo", "libbar"], |
| 4003 | } |
| 4004 | |
| 4005 | apex_key { |
| 4006 | name: "myapex.key", |
| 4007 | public_key: "testkey.avbpubkey", |
| 4008 | private_key: "testkey.pem", |
| 4009 | } |
| 4010 | |
| 4011 | cc_library { |
| 4012 | name: "libfoo", |
| 4013 | stl: "none", |
| 4014 | system_shared_libs: [], |
Jiyong Park | 323a4c3 | 2020-03-01 17:29:06 +0900 | [diff] [blame] | 4015 | runtime_libs: ["libbaz"], |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 4016 | apex_available: ["myapex"], |
| 4017 | } |
| 4018 | |
| 4019 | cc_library { |
| 4020 | name: "libbar", |
| 4021 | stl: "none", |
| 4022 | system_shared_libs: [], |
| 4023 | apex_available: ["//apex_available:anyapex"], |
Jiyong Park | 323a4c3 | 2020-03-01 17:29:06 +0900 | [diff] [blame] | 4024 | } |
| 4025 | |
| 4026 | cc_library { |
| 4027 | name: "libbaz", |
| 4028 | stl: "none", |
| 4029 | system_shared_libs: [], |
| 4030 | stubs: { |
| 4031 | versions: ["10", "20", "30"], |
| 4032 | }, |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 4033 | }`) |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 4034 | } |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 4035 | |
Jiyong Park | 89e850a | 2020-04-07 16:37:39 +0900 | [diff] [blame] | 4036 | func TestApexAvailable_CheckForPlatform(t *testing.T) { |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 4037 | ctx, _ := testApex(t, ` |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 4038 | apex { |
| 4039 | name: "myapex", |
| 4040 | key: "myapex.key", |
Jiyong Park | 89e850a | 2020-04-07 16:37:39 +0900 | [diff] [blame] | 4041 | native_shared_libs: ["libbar", "libbaz"], |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 4042 | } |
| 4043 | |
| 4044 | apex_key { |
| 4045 | name: "myapex.key", |
| 4046 | public_key: "testkey.avbpubkey", |
| 4047 | private_key: "testkey.pem", |
| 4048 | } |
| 4049 | |
| 4050 | cc_library { |
| 4051 | name: "libfoo", |
| 4052 | stl: "none", |
| 4053 | system_shared_libs: [], |
Jiyong Park | 89e850a | 2020-04-07 16:37:39 +0900 | [diff] [blame] | 4054 | shared_libs: ["libbar"], |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 4055 | apex_available: ["//apex_available:platform"], |
Jiyong Park | 89e850a | 2020-04-07 16:37:39 +0900 | [diff] [blame] | 4056 | } |
| 4057 | |
| 4058 | cc_library { |
| 4059 | name: "libfoo2", |
| 4060 | stl: "none", |
| 4061 | system_shared_libs: [], |
| 4062 | shared_libs: ["libbaz"], |
| 4063 | apex_available: ["//apex_available:platform"], |
| 4064 | } |
| 4065 | |
| 4066 | cc_library { |
| 4067 | name: "libbar", |
| 4068 | stl: "none", |
| 4069 | system_shared_libs: [], |
| 4070 | apex_available: ["myapex"], |
| 4071 | } |
| 4072 | |
| 4073 | cc_library { |
| 4074 | name: "libbaz", |
| 4075 | stl: "none", |
| 4076 | system_shared_libs: [], |
| 4077 | apex_available: ["myapex"], |
| 4078 | stubs: { |
| 4079 | versions: ["1"], |
| 4080 | }, |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 4081 | }`) |
| 4082 | |
Jiyong Park | 89e850a | 2020-04-07 16:37:39 +0900 | [diff] [blame] | 4083 | // libfoo shouldn't be available to platform even though it has "//apex_available:platform", |
| 4084 | // because it depends on libbar which isn't available to platform |
| 4085 | libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module) |
| 4086 | if libfoo.NotAvailableForPlatform() != true { |
| 4087 | t.Errorf("%q shouldn't be available to platform", libfoo.String()) |
| 4088 | } |
| 4089 | |
| 4090 | // libfoo2 however can be available to platform because it depends on libbaz which provides |
| 4091 | // stubs |
| 4092 | libfoo2 := ctx.ModuleForTests("libfoo2", "android_arm64_armv8-a_shared").Module().(*cc.Module) |
| 4093 | if libfoo2.NotAvailableForPlatform() == true { |
| 4094 | t.Errorf("%q should be available to platform", libfoo2.String()) |
| 4095 | } |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 4096 | } |
Jiyong Park | a90ca00 | 2019-10-07 15:47:24 +0900 | [diff] [blame] | 4097 | |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 4098 | func TestApexAvailable_CreatedForApex(t *testing.T) { |
Jiyong Park | 89e850a | 2020-04-07 16:37:39 +0900 | [diff] [blame] | 4099 | ctx, _ := testApex(t, ` |
Jiyong Park | a90ca00 | 2019-10-07 15:47:24 +0900 | [diff] [blame] | 4100 | apex { |
| 4101 | name: "myapex", |
| 4102 | key: "myapex.key", |
| 4103 | native_shared_libs: ["libfoo"], |
| 4104 | } |
| 4105 | |
| 4106 | apex_key { |
| 4107 | name: "myapex.key", |
| 4108 | public_key: "testkey.avbpubkey", |
| 4109 | private_key: "testkey.pem", |
| 4110 | } |
| 4111 | |
| 4112 | cc_library { |
| 4113 | name: "libfoo", |
| 4114 | stl: "none", |
| 4115 | system_shared_libs: [], |
| 4116 | apex_available: ["myapex"], |
| 4117 | static: { |
| 4118 | apex_available: ["//apex_available:platform"], |
| 4119 | }, |
| 4120 | }`) |
| 4121 | |
Jiyong Park | 89e850a | 2020-04-07 16:37:39 +0900 | [diff] [blame] | 4122 | libfooShared := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module) |
| 4123 | if libfooShared.NotAvailableForPlatform() != true { |
| 4124 | t.Errorf("%q shouldn't be available to platform", libfooShared.String()) |
| 4125 | } |
| 4126 | libfooStatic := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_static").Module().(*cc.Module) |
| 4127 | if libfooStatic.NotAvailableForPlatform() != false { |
| 4128 | t.Errorf("%q should be available to platform", libfooStatic.String()) |
| 4129 | } |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 4130 | } |
| 4131 | |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 4132 | func TestOverrideApex(t *testing.T) { |
Jaewoong Jung | 1670ca0 | 2019-11-22 14:50:42 -0800 | [diff] [blame] | 4133 | ctx, config := testApex(t, ` |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 4134 | apex { |
| 4135 | name: "myapex", |
| 4136 | key: "myapex.key", |
| 4137 | apps: ["app"], |
Jaewoong Jung | 7abcf8e | 2019-12-19 17:32:06 -0800 | [diff] [blame] | 4138 | overrides: ["oldapex"], |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 4139 | } |
| 4140 | |
| 4141 | override_apex { |
| 4142 | name: "override_myapex", |
| 4143 | base: "myapex", |
| 4144 | apps: ["override_app"], |
Jaewoong Jung | 7abcf8e | 2019-12-19 17:32:06 -0800 | [diff] [blame] | 4145 | overrides: ["unknownapex"], |
Baligh Uddin | 004d717 | 2020-02-19 21:29:28 -0800 | [diff] [blame] | 4146 | logging_parent: "com.foo.bar", |
Baligh Uddin | 5b57dba | 2020-03-15 13:01:05 -0700 | [diff] [blame] | 4147 | package_name: "test.overridden.package", |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 4148 | } |
| 4149 | |
| 4150 | apex_key { |
| 4151 | name: "myapex.key", |
| 4152 | public_key: "testkey.avbpubkey", |
| 4153 | private_key: "testkey.pem", |
| 4154 | } |
| 4155 | |
| 4156 | android_app { |
| 4157 | name: "app", |
| 4158 | srcs: ["foo/bar/MyClass.java"], |
| 4159 | package_name: "foo", |
| 4160 | sdk_version: "none", |
| 4161 | system_modules: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 4162 | apex_available: [ "myapex" ], |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 4163 | } |
| 4164 | |
| 4165 | override_android_app { |
| 4166 | name: "override_app", |
| 4167 | base: "app", |
| 4168 | package_name: "bar", |
| 4169 | } |
Jiyong Park | 20bacab | 2020-03-03 11:45:41 +0900 | [diff] [blame] | 4170 | `, withManifestPackageNameOverrides([]string{"myapex:com.android.myapex"})) |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 4171 | |
Jiyong Park | 317645e | 2019-12-05 13:20:58 +0900 | [diff] [blame] | 4172 | originalVariant := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(android.OverridableModule) |
| 4173 | overriddenVariant := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Module().(android.OverridableModule) |
| 4174 | if originalVariant.GetOverriddenBy() != "" { |
| 4175 | t.Errorf("GetOverriddenBy should be empty, but was %q", originalVariant.GetOverriddenBy()) |
| 4176 | } |
| 4177 | if overriddenVariant.GetOverriddenBy() != "override_myapex" { |
| 4178 | t.Errorf("GetOverriddenBy should be \"override_myapex\", but was %q", overriddenVariant.GetOverriddenBy()) |
| 4179 | } |
| 4180 | |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 4181 | module := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image") |
| 4182 | apexRule := module.Rule("apexRule") |
| 4183 | copyCmds := apexRule.Args["copy_commands"] |
| 4184 | |
| 4185 | ensureNotContains(t, copyCmds, "image.apex/app/app/app.apk") |
Jooyung Han | 39ee119 | 2020-03-23 20:21:11 +0900 | [diff] [blame] | 4186 | ensureContains(t, copyCmds, "image.apex/app/override_app/override_app.apk") |
Jaewoong Jung | 1670ca0 | 2019-11-22 14:50:42 -0800 | [diff] [blame] | 4187 | |
| 4188 | apexBundle := module.Module().(*apexBundle) |
| 4189 | name := apexBundle.Name() |
| 4190 | if name != "override_myapex" { |
| 4191 | t.Errorf("name should be \"override_myapex\", but was %q", name) |
| 4192 | } |
| 4193 | |
Baligh Uddin | 004d717 | 2020-02-19 21:29:28 -0800 | [diff] [blame] | 4194 | if apexBundle.overridableProperties.Logging_parent != "com.foo.bar" { |
| 4195 | t.Errorf("override_myapex should have logging parent (com.foo.bar), but was %q.", apexBundle.overridableProperties.Logging_parent) |
| 4196 | } |
| 4197 | |
Jiyong Park | 20bacab | 2020-03-03 11:45:41 +0900 | [diff] [blame] | 4198 | optFlags := apexRule.Args["opt_flags"] |
Baligh Uddin | 5b57dba | 2020-03-15 13:01:05 -0700 | [diff] [blame] | 4199 | ensureContains(t, optFlags, "--override_apk_package_name test.overridden.package") |
Jiyong Park | 20bacab | 2020-03-03 11:45:41 +0900 | [diff] [blame] | 4200 | |
Jaewoong Jung | 1670ca0 | 2019-11-22 14:50:42 -0800 | [diff] [blame] | 4201 | data := android.AndroidMkDataForTest(t, config, "", apexBundle) |
| 4202 | var builder strings.Builder |
| 4203 | data.Custom(&builder, name, "TARGET_", "", data) |
| 4204 | androidMk := builder.String() |
Jiyong Park | f653b05 | 2019-11-18 15:39:01 +0900 | [diff] [blame] | 4205 | ensureContains(t, androidMk, "LOCAL_MODULE := override_app.override_myapex") |
Jaewoong Jung | 1670ca0 | 2019-11-22 14:50:42 -0800 | [diff] [blame] | 4206 | ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.override_myapex") |
| 4207 | ensureContains(t, androidMk, "LOCAL_MODULE_STEM := override_myapex.apex") |
Jaewoong Jung | 7abcf8e | 2019-12-19 17:32:06 -0800 | [diff] [blame] | 4208 | ensureContains(t, androidMk, "LOCAL_OVERRIDES_MODULES := unknownapex myapex") |
Jaewoong Jung | 1670ca0 | 2019-11-22 14:50:42 -0800 | [diff] [blame] | 4209 | ensureNotContains(t, androidMk, "LOCAL_MODULE := app.myapex") |
Jiyong Park | f653b05 | 2019-11-18 15:39:01 +0900 | [diff] [blame] | 4210 | ensureNotContains(t, androidMk, "LOCAL_MODULE := override_app.myapex") |
Jaewoong Jung | 1670ca0 | 2019-11-22 14:50:42 -0800 | [diff] [blame] | 4211 | ensureNotContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex") |
| 4212 | ensureNotContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.apex") |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 4213 | } |
| 4214 | |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 4215 | func TestLegacyAndroid10Support(t *testing.T) { |
| 4216 | ctx, _ := testApex(t, ` |
| 4217 | apex { |
| 4218 | name: "myapex", |
| 4219 | key: "myapex.key", |
Peter Collingbourne | dc4f986 | 2020-02-12 17:13:25 -0800 | [diff] [blame] | 4220 | native_shared_libs: ["mylib"], |
Jooyung Han | 5417f77 | 2020-03-12 18:37:20 +0900 | [diff] [blame] | 4221 | min_sdk_version: "29", |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 4222 | } |
| 4223 | |
| 4224 | apex_key { |
| 4225 | name: "myapex.key", |
| 4226 | public_key: "testkey.avbpubkey", |
| 4227 | private_key: "testkey.pem", |
| 4228 | } |
Peter Collingbourne | dc4f986 | 2020-02-12 17:13:25 -0800 | [diff] [blame] | 4229 | |
| 4230 | cc_library { |
| 4231 | name: "mylib", |
| 4232 | srcs: ["mylib.cpp"], |
| 4233 | stl: "libc++", |
| 4234 | system_shared_libs: [], |
| 4235 | apex_available: [ "myapex" ], |
| 4236 | } |
Peter Collingbourne | dc4f986 | 2020-02-12 17:13:25 -0800 | [diff] [blame] | 4237 | `, withUnbundledBuild) |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 4238 | |
| 4239 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
| 4240 | args := module.Rule("apexRule").Args |
| 4241 | ensureContains(t, args["opt_flags"], "--manifest_json "+module.Output("apex_manifest.json").Output.String()) |
Dario Freni | e354690 | 2020-01-14 23:50:25 +0000 | [diff] [blame] | 4242 | ensureNotContains(t, args["opt_flags"], "--no_hashtree") |
Peter Collingbourne | dc4f986 | 2020-02-12 17:13:25 -0800 | [diff] [blame] | 4243 | |
| 4244 | // The copies of the libraries in the apex should have one more dependency than |
| 4245 | // the ones outside the apex, namely the unwinder. Ideally we should check |
| 4246 | // the dependency names directly here but for some reason the names are blank in |
| 4247 | // this test. |
| 4248 | for _, lib := range []string{"libc++", "mylib"} { |
| 4249 | apexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared_myapex").Rule("ld").Implicits |
| 4250 | nonApexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared").Rule("ld").Implicits |
| 4251 | if len(apexImplicits) != len(nonApexImplicits)+1 { |
| 4252 | t.Errorf("%q missing unwinder dep", lib) |
| 4253 | } |
| 4254 | } |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 4255 | } |
| 4256 | |
Jooyung Han | 58f26ab | 2019-12-18 15:34:32 +0900 | [diff] [blame] | 4257 | func TestJavaSDKLibrary(t *testing.T) { |
| 4258 | ctx, _ := testApex(t, ` |
| 4259 | apex { |
| 4260 | name: "myapex", |
| 4261 | key: "myapex.key", |
| 4262 | java_libs: ["foo"], |
| 4263 | } |
| 4264 | |
| 4265 | apex_key { |
| 4266 | name: "myapex.key", |
| 4267 | public_key: "testkey.avbpubkey", |
| 4268 | private_key: "testkey.pem", |
| 4269 | } |
| 4270 | |
| 4271 | java_sdk_library { |
| 4272 | name: "foo", |
| 4273 | srcs: ["a.java"], |
| 4274 | api_packages: ["foo"], |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 4275 | apex_available: [ "myapex" ], |
Jooyung Han | 58f26ab | 2019-12-18 15:34:32 +0900 | [diff] [blame] | 4276 | } |
| 4277 | `, withFiles(map[string][]byte{ |
| 4278 | "api/current.txt": nil, |
| 4279 | "api/removed.txt": nil, |
| 4280 | "api/system-current.txt": nil, |
| 4281 | "api/system-removed.txt": nil, |
| 4282 | "api/test-current.txt": nil, |
| 4283 | "api/test-removed.txt": nil, |
| 4284 | })) |
| 4285 | |
| 4286 | // java_sdk_library installs both impl jar and permission XML |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 4287 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
Jooyung Han | 58f26ab | 2019-12-18 15:34:32 +0900 | [diff] [blame] | 4288 | "javalib/foo.jar", |
| 4289 | "etc/permissions/foo.xml", |
| 4290 | }) |
| 4291 | // Permission XML should point to the activated path of impl jar of java_sdk_library |
Jiyong Park | e383388 | 2020-02-17 17:28:10 +0900 | [diff] [blame] | 4292 | sdkLibrary := ctx.ModuleForTests("foo.xml", "android_common_myapex").Rule("java_sdk_xml") |
| 4293 | ensureContains(t, sdkLibrary.RuleParams.Command, `<library name=\"foo\" file=\"/apex/myapex/javalib/foo.jar\"`) |
Jooyung Han | 58f26ab | 2019-12-18 15:34:32 +0900 | [diff] [blame] | 4294 | } |
| 4295 | |
atrost | 6e12625 | 2020-01-27 17:01:16 +0000 | [diff] [blame] | 4296 | func TestCompatConfig(t *testing.T) { |
| 4297 | ctx, _ := testApex(t, ` |
| 4298 | apex { |
| 4299 | name: "myapex", |
| 4300 | key: "myapex.key", |
| 4301 | prebuilts: ["myjar-platform-compat-config"], |
| 4302 | java_libs: ["myjar"], |
| 4303 | } |
| 4304 | |
| 4305 | apex_key { |
| 4306 | name: "myapex.key", |
| 4307 | public_key: "testkey.avbpubkey", |
| 4308 | private_key: "testkey.pem", |
| 4309 | } |
| 4310 | |
| 4311 | platform_compat_config { |
| 4312 | name: "myjar-platform-compat-config", |
| 4313 | src: ":myjar", |
| 4314 | } |
| 4315 | |
| 4316 | java_library { |
| 4317 | name: "myjar", |
| 4318 | srcs: ["foo/bar/MyClass.java"], |
| 4319 | sdk_version: "none", |
| 4320 | system_modules: "none", |
atrost | 6e12625 | 2020-01-27 17:01:16 +0000 | [diff] [blame] | 4321 | apex_available: [ "myapex" ], |
| 4322 | } |
| 4323 | `) |
| 4324 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 4325 | "etc/compatconfig/myjar-platform-compat-config.xml", |
| 4326 | "javalib/myjar.jar", |
| 4327 | }) |
| 4328 | } |
| 4329 | |
Jiyong Park | 479321d | 2019-12-16 11:47:12 +0900 | [diff] [blame] | 4330 | func TestRejectNonInstallableJavaLibrary(t *testing.T) { |
| 4331 | testApexError(t, `"myjar" is not configured to be compiled into dex`, ` |
| 4332 | apex { |
| 4333 | name: "myapex", |
| 4334 | key: "myapex.key", |
| 4335 | java_libs: ["myjar"], |
| 4336 | } |
| 4337 | |
| 4338 | apex_key { |
| 4339 | name: "myapex.key", |
| 4340 | public_key: "testkey.avbpubkey", |
| 4341 | private_key: "testkey.pem", |
| 4342 | } |
| 4343 | |
| 4344 | java_library { |
| 4345 | name: "myjar", |
| 4346 | srcs: ["foo/bar/MyClass.java"], |
| 4347 | sdk_version: "none", |
| 4348 | system_modules: "none", |
Jiyong Park | 6b21c7d | 2020-02-11 09:16:01 +0900 | [diff] [blame] | 4349 | compile_dex: false, |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 4350 | apex_available: ["myapex"], |
Jiyong Park | 479321d | 2019-12-16 11:47:12 +0900 | [diff] [blame] | 4351 | } |
| 4352 | `) |
| 4353 | } |
| 4354 | |
Jiyong Park | 7afd107 | 2019-12-30 16:56:33 +0900 | [diff] [blame] | 4355 | func TestCarryRequiredModuleNames(t *testing.T) { |
| 4356 | ctx, config := testApex(t, ` |
| 4357 | apex { |
| 4358 | name: "myapex", |
| 4359 | key: "myapex.key", |
| 4360 | native_shared_libs: ["mylib"], |
| 4361 | } |
| 4362 | |
| 4363 | apex_key { |
| 4364 | name: "myapex.key", |
| 4365 | public_key: "testkey.avbpubkey", |
| 4366 | private_key: "testkey.pem", |
| 4367 | } |
| 4368 | |
| 4369 | cc_library { |
| 4370 | name: "mylib", |
| 4371 | srcs: ["mylib.cpp"], |
| 4372 | system_shared_libs: [], |
| 4373 | stl: "none", |
| 4374 | required: ["a", "b"], |
| 4375 | host_required: ["c", "d"], |
| 4376 | target_required: ["e", "f"], |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 4377 | apex_available: [ "myapex" ], |
Jiyong Park | 7afd107 | 2019-12-30 16:56:33 +0900 | [diff] [blame] | 4378 | } |
| 4379 | `) |
| 4380 | |
| 4381 | apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
| 4382 | data := android.AndroidMkDataForTest(t, config, "", apexBundle) |
| 4383 | name := apexBundle.BaseModuleName() |
| 4384 | prefix := "TARGET_" |
| 4385 | var builder strings.Builder |
| 4386 | data.Custom(&builder, name, prefix, "", data) |
| 4387 | androidMk := builder.String() |
| 4388 | ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += a b\n") |
| 4389 | ensureContains(t, androidMk, "LOCAL_HOST_REQUIRED_MODULES += c d\n") |
| 4390 | ensureContains(t, androidMk, "LOCAL_TARGET_REQUIRED_MODULES += e f\n") |
| 4391 | } |
| 4392 | |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 4393 | func TestSymlinksFromApexToSystem(t *testing.T) { |
| 4394 | bp := ` |
| 4395 | apex { |
| 4396 | name: "myapex", |
| 4397 | key: "myapex.key", |
| 4398 | native_shared_libs: ["mylib"], |
| 4399 | java_libs: ["myjar"], |
| 4400 | } |
| 4401 | |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 4402 | apex { |
| 4403 | name: "myapex.updatable", |
| 4404 | key: "myapex.key", |
| 4405 | native_shared_libs: ["mylib"], |
| 4406 | java_libs: ["myjar"], |
| 4407 | updatable: true, |
Jooyung Han | 548640b | 2020-04-27 12:10:30 +0900 | [diff] [blame] | 4408 | min_sdk_version: "current", |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 4409 | } |
| 4410 | |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 4411 | apex_key { |
| 4412 | name: "myapex.key", |
| 4413 | public_key: "testkey.avbpubkey", |
| 4414 | private_key: "testkey.pem", |
| 4415 | } |
| 4416 | |
| 4417 | cc_library { |
| 4418 | name: "mylib", |
| 4419 | srcs: ["mylib.cpp"], |
| 4420 | shared_libs: ["myotherlib"], |
| 4421 | system_shared_libs: [], |
| 4422 | stl: "none", |
| 4423 | apex_available: [ |
| 4424 | "myapex", |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 4425 | "myapex.updatable", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 4426 | "//apex_available:platform", |
| 4427 | ], |
| 4428 | } |
| 4429 | |
| 4430 | cc_library { |
| 4431 | name: "myotherlib", |
| 4432 | srcs: ["mylib.cpp"], |
| 4433 | system_shared_libs: [], |
| 4434 | stl: "none", |
| 4435 | apex_available: [ |
| 4436 | "myapex", |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 4437 | "myapex.updatable", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 4438 | "//apex_available:platform", |
| 4439 | ], |
| 4440 | } |
| 4441 | |
| 4442 | java_library { |
| 4443 | name: "myjar", |
| 4444 | srcs: ["foo/bar/MyClass.java"], |
| 4445 | sdk_version: "none", |
| 4446 | system_modules: "none", |
| 4447 | libs: ["myotherjar"], |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 4448 | apex_available: [ |
| 4449 | "myapex", |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 4450 | "myapex.updatable", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 4451 | "//apex_available:platform", |
| 4452 | ], |
| 4453 | } |
| 4454 | |
| 4455 | java_library { |
| 4456 | name: "myotherjar", |
| 4457 | srcs: ["foo/bar/MyClass.java"], |
| 4458 | sdk_version: "none", |
| 4459 | system_modules: "none", |
| 4460 | apex_available: [ |
| 4461 | "myapex", |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 4462 | "myapex.updatable", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 4463 | "//apex_available:platform", |
| 4464 | ], |
| 4465 | } |
| 4466 | ` |
| 4467 | |
| 4468 | ensureRealfileExists := func(t *testing.T, files []fileInApex, file string) { |
| 4469 | for _, f := range files { |
| 4470 | if f.path == file { |
| 4471 | if f.isLink { |
| 4472 | t.Errorf("%q is not a real file", file) |
| 4473 | } |
| 4474 | return |
| 4475 | } |
| 4476 | } |
| 4477 | t.Errorf("%q is not found", file) |
| 4478 | } |
| 4479 | |
| 4480 | ensureSymlinkExists := func(t *testing.T, files []fileInApex, file string) { |
| 4481 | for _, f := range files { |
| 4482 | if f.path == file { |
| 4483 | if !f.isLink { |
| 4484 | t.Errorf("%q is not a symlink", file) |
| 4485 | } |
| 4486 | return |
| 4487 | } |
| 4488 | } |
| 4489 | t.Errorf("%q is not found", file) |
| 4490 | } |
| 4491 | |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 4492 | // For unbundled build, symlink shouldn't exist regardless of whether an APEX |
| 4493 | // is updatable or not |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 4494 | ctx, _ := testApex(t, bp, withUnbundledBuild) |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 4495 | files := getFiles(t, ctx, "myapex", "android_common_myapex_image") |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 4496 | ensureRealfileExists(t, files, "javalib/myjar.jar") |
| 4497 | ensureRealfileExists(t, files, "lib64/mylib.so") |
| 4498 | ensureRealfileExists(t, files, "lib64/myotherlib.so") |
| 4499 | |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 4500 | files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image") |
| 4501 | ensureRealfileExists(t, files, "javalib/myjar.jar") |
| 4502 | ensureRealfileExists(t, files, "lib64/mylib.so") |
| 4503 | ensureRealfileExists(t, files, "lib64/myotherlib.so") |
| 4504 | |
| 4505 | // For bundled build, symlink to the system for the non-updatable APEXes only |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 4506 | ctx, _ = testApex(t, bp) |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 4507 | files = getFiles(t, ctx, "myapex", "android_common_myapex_image") |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 4508 | ensureRealfileExists(t, files, "javalib/myjar.jar") |
| 4509 | ensureRealfileExists(t, files, "lib64/mylib.so") |
| 4510 | ensureSymlinkExists(t, files, "lib64/myotherlib.so") // this is symlink |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 4511 | |
| 4512 | files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image") |
| 4513 | ensureRealfileExists(t, files, "javalib/myjar.jar") |
| 4514 | ensureRealfileExists(t, files, "lib64/mylib.so") |
| 4515 | ensureRealfileExists(t, files, "lib64/myotherlib.so") // this is a real file |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 4516 | } |
| 4517 | |
Jooyung Han | 643adc4 | 2020-02-27 13:50:06 +0900 | [diff] [blame] | 4518 | func TestApexWithJniLibs(t *testing.T) { |
| 4519 | ctx, _ := testApex(t, ` |
| 4520 | apex { |
| 4521 | name: "myapex", |
| 4522 | key: "myapex.key", |
| 4523 | jni_libs: ["mylib"], |
| 4524 | } |
| 4525 | |
| 4526 | apex_key { |
| 4527 | name: "myapex.key", |
| 4528 | public_key: "testkey.avbpubkey", |
| 4529 | private_key: "testkey.pem", |
| 4530 | } |
| 4531 | |
| 4532 | cc_library { |
| 4533 | name: "mylib", |
| 4534 | srcs: ["mylib.cpp"], |
| 4535 | shared_libs: ["mylib2"], |
| 4536 | system_shared_libs: [], |
| 4537 | stl: "none", |
| 4538 | apex_available: [ "myapex" ], |
| 4539 | } |
| 4540 | |
| 4541 | cc_library { |
| 4542 | name: "mylib2", |
| 4543 | srcs: ["mylib.cpp"], |
| 4544 | system_shared_libs: [], |
| 4545 | stl: "none", |
| 4546 | apex_available: [ "myapex" ], |
| 4547 | } |
| 4548 | `) |
| 4549 | |
| 4550 | rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule") |
| 4551 | // Notice mylib2.so (transitive dep) is not added as a jni_lib |
| 4552 | ensureEquals(t, rule.Args["opt"], "-a jniLibs mylib.so") |
| 4553 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 4554 | "lib64/mylib.so", |
| 4555 | "lib64/mylib2.so", |
| 4556 | }) |
| 4557 | } |
| 4558 | |
Jooyung Han | 49f6701 | 2020-04-17 13:43:10 +0900 | [diff] [blame] | 4559 | func TestApexMutatorsDontRunIfDisabled(t *testing.T) { |
| 4560 | ctx, _ := testApex(t, ` |
| 4561 | apex { |
| 4562 | name: "myapex", |
| 4563 | key: "myapex.key", |
| 4564 | } |
| 4565 | apex_key { |
| 4566 | name: "myapex.key", |
| 4567 | public_key: "testkey.avbpubkey", |
| 4568 | private_key: "testkey.pem", |
| 4569 | } |
| 4570 | `, func(fs map[string][]byte, config android.Config) { |
| 4571 | delete(config.Targets, android.Android) |
| 4572 | config.AndroidCommonTarget = android.Target{} |
| 4573 | }) |
| 4574 | |
| 4575 | if expected, got := []string{""}, ctx.ModuleVariantsForTests("myapex"); !reflect.DeepEqual(expected, got) { |
| 4576 | t.Errorf("Expected variants: %v, but got: %v", expected, got) |
| 4577 | } |
| 4578 | } |
| 4579 | |
Jooyung Han | 643adc4 | 2020-02-27 13:50:06 +0900 | [diff] [blame] | 4580 | func TestApexWithJniLibs_Errors(t *testing.T) { |
| 4581 | testApexError(t, `jni_libs: "xxx" is not a cc_library`, ` |
| 4582 | apex { |
| 4583 | name: "myapex", |
| 4584 | key: "myapex.key", |
| 4585 | jni_libs: ["xxx"], |
| 4586 | } |
| 4587 | |
| 4588 | apex_key { |
| 4589 | name: "myapex.key", |
| 4590 | public_key: "testkey.avbpubkey", |
| 4591 | private_key: "testkey.pem", |
| 4592 | } |
| 4593 | |
| 4594 | prebuilt_etc { |
| 4595 | name: "xxx", |
| 4596 | src: "xxx", |
| 4597 | } |
| 4598 | `, withFiles(map[string][]byte{ |
| 4599 | "xxx": nil, |
| 4600 | })) |
| 4601 | } |
| 4602 | |
Jiyong Park | bd15961 | 2020-02-28 15:22:21 +0900 | [diff] [blame] | 4603 | func TestAppBundle(t *testing.T) { |
| 4604 | ctx, _ := testApex(t, ` |
| 4605 | apex { |
| 4606 | name: "myapex", |
| 4607 | key: "myapex.key", |
| 4608 | apps: ["AppFoo"], |
| 4609 | } |
| 4610 | |
| 4611 | apex_key { |
| 4612 | name: "myapex.key", |
| 4613 | public_key: "testkey.avbpubkey", |
| 4614 | private_key: "testkey.pem", |
| 4615 | } |
| 4616 | |
| 4617 | android_app { |
| 4618 | name: "AppFoo", |
| 4619 | srcs: ["foo/bar/MyClass.java"], |
| 4620 | sdk_version: "none", |
| 4621 | system_modules: "none", |
| 4622 | apex_available: [ "myapex" ], |
| 4623 | } |
Jiyong Park | cfaa164 | 2020-02-28 16:51:07 +0900 | [diff] [blame] | 4624 | `, withManifestPackageNameOverrides([]string{"AppFoo:com.android.foo"})) |
Jiyong Park | bd15961 | 2020-02-28 15:22:21 +0900 | [diff] [blame] | 4625 | |
| 4626 | bundleConfigRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Description("Bundle Config") |
| 4627 | content := bundleConfigRule.Args["content"] |
| 4628 | |
| 4629 | ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`) |
Jiyong Park | cfaa164 | 2020-02-28 16:51:07 +0900 | [diff] [blame] | 4630 | ensureContains(t, content, `"apex_config":{"apex_embedded_apk_config":[{"package_name":"com.android.foo","path":"app/AppFoo/AppFoo.apk"}]}`) |
Jiyong Park | bd15961 | 2020-02-28 15:22:21 +0900 | [diff] [blame] | 4631 | } |
| 4632 | |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4633 | func testNoUpdatableJarsInBootImage(t *testing.T, errmsg, bp string, transformDexpreoptConfig func(*dexpreopt.GlobalConfig)) { |
| 4634 | t.Helper() |
| 4635 | |
| 4636 | bp = bp + ` |
| 4637 | filegroup { |
| 4638 | name: "some-updatable-apex-file_contexts", |
| 4639 | srcs: [ |
| 4640 | "system/sepolicy/apex/some-updatable-apex-file_contexts", |
| 4641 | ], |
| 4642 | } |
Ulya Trafimovich | 7c140d8 | 2020-04-22 18:05:58 +0100 | [diff] [blame] | 4643 | |
| 4644 | filegroup { |
| 4645 | name: "some-non-updatable-apex-file_contexts", |
| 4646 | srcs: [ |
| 4647 | "system/sepolicy/apex/some-non-updatable-apex-file_contexts", |
| 4648 | ], |
| 4649 | } |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4650 | ` |
| 4651 | bp += cc.GatherRequiredDepsForTest(android.Android) |
| 4652 | bp += java.GatherRequiredDepsForTest() |
| 4653 | bp += dexpreopt.BpToolModulesForTest() |
| 4654 | |
| 4655 | fs := map[string][]byte{ |
| 4656 | "a.java": nil, |
| 4657 | "a.jar": nil, |
| 4658 | "build/make/target/product/security": nil, |
| 4659 | "apex_manifest.json": nil, |
| 4660 | "AndroidManifest.xml": nil, |
| 4661 | "system/sepolicy/apex/some-updatable-apex-file_contexts": nil, |
Ulya Trafimovich | 7c140d8 | 2020-04-22 18:05:58 +0100 | [diff] [blame] | 4662 | "system/sepolicy/apex/some-non-updatable-apex-file_contexts": nil, |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4663 | "system/sepolicy/apex/com.android.art.something-file_contexts": nil, |
| 4664 | "framework/aidl/a.aidl": nil, |
| 4665 | } |
| 4666 | cc.GatherRequiredFilesForTest(fs) |
| 4667 | |
| 4668 | ctx := android.NewTestArchContext() |
| 4669 | ctx.RegisterModuleType("apex", BundleFactory) |
| 4670 | ctx.RegisterModuleType("apex_key", ApexKeyFactory) |
| 4671 | ctx.RegisterModuleType("filegroup", android.FileGroupFactory) |
Paul Duffin | c988c8e | 2020-04-29 18:27:14 +0100 | [diff] [blame] | 4672 | ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4673 | cc.RegisterRequiredBuildComponentsForTest(ctx) |
| 4674 | java.RegisterJavaBuildComponents(ctx) |
| 4675 | java.RegisterSystemModulesBuildComponents(ctx) |
| 4676 | java.RegisterAppBuildComponents(ctx) |
| 4677 | java.RegisterDexpreoptBootJarsComponents(ctx) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4678 | ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators) |
| 4679 | ctx.PreDepsMutators(RegisterPreDepsMutators) |
| 4680 | ctx.PostDepsMutators(RegisterPostDepsMutators) |
| 4681 | |
| 4682 | config := android.TestArchConfig(buildDir, nil, bp, fs) |
| 4683 | ctx.Register(config) |
| 4684 | |
| 4685 | _ = dexpreopt.GlobalSoongConfigForTests(config) |
| 4686 | dexpreopt.RegisterToolModulesForTest(ctx) |
| 4687 | pathCtx := android.PathContextForTesting(config) |
| 4688 | dexpreoptConfig := dexpreopt.GlobalConfigForTests(pathCtx) |
| 4689 | transformDexpreoptConfig(dexpreoptConfig) |
| 4690 | dexpreopt.SetTestGlobalConfig(config, dexpreoptConfig) |
| 4691 | |
| 4692 | _, errs := ctx.ParseBlueprintsFiles("Android.bp") |
| 4693 | android.FailIfErrored(t, errs) |
| 4694 | |
| 4695 | _, errs = ctx.PrepareBuildActions(config) |
| 4696 | if errmsg == "" { |
| 4697 | android.FailIfErrored(t, errs) |
| 4698 | } else if len(errs) > 0 { |
| 4699 | android.FailIfNoMatchingErrors(t, errmsg, errs) |
| 4700 | return |
| 4701 | } else { |
| 4702 | t.Fatalf("missing expected error %q (0 errors are returned)", errmsg) |
| 4703 | } |
| 4704 | } |
| 4705 | |
Jooyung Han | 548640b | 2020-04-27 12:10:30 +0900 | [diff] [blame] | 4706 | func TestUpdatable_should_set_min_sdk_version(t *testing.T) { |
| 4707 | testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, ` |
| 4708 | apex { |
| 4709 | name: "myapex", |
| 4710 | key: "myapex.key", |
| 4711 | updatable: true, |
| 4712 | } |
| 4713 | |
| 4714 | apex_key { |
| 4715 | name: "myapex.key", |
| 4716 | public_key: "testkey.avbpubkey", |
| 4717 | private_key: "testkey.pem", |
| 4718 | } |
| 4719 | `) |
| 4720 | } |
| 4721 | |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4722 | func TestNoUpdatableJarsInBootImage(t *testing.T) { |
| 4723 | bp := ` |
| 4724 | java_library { |
| 4725 | name: "some-updatable-apex-lib", |
| 4726 | srcs: ["a.java"], |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 4727 | sdk_version: "current", |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4728 | apex_available: [ |
| 4729 | "some-updatable-apex", |
| 4730 | ], |
| 4731 | } |
| 4732 | |
| 4733 | java_library { |
Ulya Trafimovich | 7c140d8 | 2020-04-22 18:05:58 +0100 | [diff] [blame] | 4734 | name: "some-non-updatable-apex-lib", |
| 4735 | srcs: ["a.java"], |
| 4736 | apex_available: [ |
| 4737 | "some-non-updatable-apex", |
| 4738 | ], |
| 4739 | } |
| 4740 | |
| 4741 | java_library { |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4742 | name: "some-platform-lib", |
| 4743 | srcs: ["a.java"], |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 4744 | sdk_version: "current", |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4745 | installable: true, |
| 4746 | } |
| 4747 | |
| 4748 | java_library { |
| 4749 | name: "some-art-lib", |
| 4750 | srcs: ["a.java"], |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 4751 | sdk_version: "current", |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4752 | apex_available: [ |
| 4753 | "com.android.art.something", |
| 4754 | ], |
| 4755 | hostdex: true, |
| 4756 | } |
| 4757 | |
| 4758 | apex { |
| 4759 | name: "some-updatable-apex", |
| 4760 | key: "some-updatable-apex.key", |
| 4761 | java_libs: ["some-updatable-apex-lib"], |
Ulya Trafimovich | 7c140d8 | 2020-04-22 18:05:58 +0100 | [diff] [blame] | 4762 | updatable: true, |
Jooyung Han | 548640b | 2020-04-27 12:10:30 +0900 | [diff] [blame] | 4763 | min_sdk_version: "current", |
Ulya Trafimovich | 7c140d8 | 2020-04-22 18:05:58 +0100 | [diff] [blame] | 4764 | } |
| 4765 | |
| 4766 | apex { |
| 4767 | name: "some-non-updatable-apex", |
| 4768 | key: "some-non-updatable-apex.key", |
| 4769 | java_libs: ["some-non-updatable-apex-lib"], |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4770 | } |
| 4771 | |
| 4772 | apex_key { |
| 4773 | name: "some-updatable-apex.key", |
| 4774 | } |
| 4775 | |
Ulya Trafimovich | 7c140d8 | 2020-04-22 18:05:58 +0100 | [diff] [blame] | 4776 | apex_key { |
| 4777 | name: "some-non-updatable-apex.key", |
| 4778 | } |
| 4779 | |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4780 | apex { |
| 4781 | name: "com.android.art.something", |
| 4782 | key: "com.android.art.something.key", |
| 4783 | java_libs: ["some-art-lib"], |
Ulya Trafimovich | 7c140d8 | 2020-04-22 18:05:58 +0100 | [diff] [blame] | 4784 | updatable: true, |
Jooyung Han | 548640b | 2020-04-27 12:10:30 +0900 | [diff] [blame] | 4785 | min_sdk_version: "current", |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4786 | } |
| 4787 | |
| 4788 | apex_key { |
| 4789 | name: "com.android.art.something.key", |
| 4790 | } |
| 4791 | ` |
| 4792 | |
| 4793 | var error string |
| 4794 | var transform func(*dexpreopt.GlobalConfig) |
| 4795 | |
| 4796 | // updatable jar from ART apex in the ART boot image => ok |
| 4797 | transform = func(config *dexpreopt.GlobalConfig) { |
Ulya Trafimovich | 50c4a4b | 2020-04-21 15:36:33 +0100 | [diff] [blame] | 4798 | config.ArtApexJars = []string{"com.android.art.something:some-art-lib"} |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4799 | } |
| 4800 | testNoUpdatableJarsInBootImage(t, "", bp, transform) |
| 4801 | |
| 4802 | // updatable jar from ART apex in the framework boot image => error |
| 4803 | error = "module 'some-art-lib' from updatable apex 'com.android.art.something' is not allowed in the framework boot image" |
| 4804 | transform = func(config *dexpreopt.GlobalConfig) { |
Ulya Trafimovich | 50c4a4b | 2020-04-21 15:36:33 +0100 | [diff] [blame] | 4805 | config.BootJars = []string{"com.android.art.something:some-art-lib"} |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4806 | } |
| 4807 | testNoUpdatableJarsInBootImage(t, error, bp, transform) |
| 4808 | |
| 4809 | // updatable jar from some other apex in the ART boot image => error |
| 4810 | error = "module 'some-updatable-apex-lib' from updatable apex 'some-updatable-apex' is not allowed in the ART boot image" |
| 4811 | transform = func(config *dexpreopt.GlobalConfig) { |
Ulya Trafimovich | 50c4a4b | 2020-04-21 15:36:33 +0100 | [diff] [blame] | 4812 | config.ArtApexJars = []string{"some-updatable-apex:some-updatable-apex-lib"} |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4813 | } |
| 4814 | testNoUpdatableJarsInBootImage(t, error, bp, transform) |
| 4815 | |
Ulya Trafimovich | 7c140d8 | 2020-04-22 18:05:58 +0100 | [diff] [blame] | 4816 | // non-updatable jar from some other apex in the ART boot image => error |
| 4817 | error = "module 'some-non-updatable-apex-lib' is not allowed in the ART boot image" |
| 4818 | transform = func(config *dexpreopt.GlobalConfig) { |
Ulya Trafimovich | 50c4a4b | 2020-04-21 15:36:33 +0100 | [diff] [blame] | 4819 | config.ArtApexJars = []string{"some-non-updatable-apex:some-non-updatable-apex-lib"} |
Ulya Trafimovich | 7c140d8 | 2020-04-22 18:05:58 +0100 | [diff] [blame] | 4820 | } |
| 4821 | testNoUpdatableJarsInBootImage(t, error, bp, transform) |
| 4822 | |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4823 | // updatable jar from some other apex in the framework boot image => error |
| 4824 | error = "module 'some-updatable-apex-lib' from updatable apex 'some-updatable-apex' is not allowed in the framework boot image" |
| 4825 | transform = func(config *dexpreopt.GlobalConfig) { |
Ulya Trafimovich | 50c4a4b | 2020-04-21 15:36:33 +0100 | [diff] [blame] | 4826 | config.BootJars = []string{"some-updatable-apex:some-updatable-apex-lib"} |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4827 | } |
| 4828 | testNoUpdatableJarsInBootImage(t, error, bp, transform) |
| 4829 | |
Ulya Trafimovich | 7c140d8 | 2020-04-22 18:05:58 +0100 | [diff] [blame] | 4830 | // non-updatable jar from some other apex in the framework boot image => ok |
| 4831 | transform = func(config *dexpreopt.GlobalConfig) { |
Ulya Trafimovich | 50c4a4b | 2020-04-21 15:36:33 +0100 | [diff] [blame] | 4832 | config.BootJars = []string{"some-non-updatable-apex:some-non-updatable-apex-lib"} |
Ulya Trafimovich | 7c140d8 | 2020-04-22 18:05:58 +0100 | [diff] [blame] | 4833 | } |
| 4834 | testNoUpdatableJarsInBootImage(t, "", bp, transform) |
| 4835 | |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4836 | // nonexistent jar in the ART boot image => error |
| 4837 | error = "failed to find a dex jar path for module 'nonexistent'" |
| 4838 | transform = func(config *dexpreopt.GlobalConfig) { |
Ulya Trafimovich | 50c4a4b | 2020-04-21 15:36:33 +0100 | [diff] [blame] | 4839 | config.ArtApexJars = []string{"platform:nonexistent"} |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4840 | } |
| 4841 | testNoUpdatableJarsInBootImage(t, error, bp, transform) |
| 4842 | |
| 4843 | // nonexistent jar in the framework boot image => error |
| 4844 | error = "failed to find a dex jar path for module 'nonexistent'" |
| 4845 | transform = func(config *dexpreopt.GlobalConfig) { |
Ulya Trafimovich | 50c4a4b | 2020-04-21 15:36:33 +0100 | [diff] [blame] | 4846 | config.BootJars = []string{"platform:nonexistent"} |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4847 | } |
| 4848 | testNoUpdatableJarsInBootImage(t, error, bp, transform) |
| 4849 | |
| 4850 | // platform jar in the ART boot image => error |
Ulya Trafimovich | 7c140d8 | 2020-04-22 18:05:58 +0100 | [diff] [blame] | 4851 | error = "module 'some-platform-lib' is not allowed in the ART boot image" |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4852 | transform = func(config *dexpreopt.GlobalConfig) { |
Ulya Trafimovich | 50c4a4b | 2020-04-21 15:36:33 +0100 | [diff] [blame] | 4853 | config.ArtApexJars = []string{"platform:some-platform-lib"} |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4854 | } |
| 4855 | testNoUpdatableJarsInBootImage(t, error, bp, transform) |
| 4856 | |
| 4857 | // platform jar in the framework boot image => ok |
| 4858 | transform = func(config *dexpreopt.GlobalConfig) { |
Ulya Trafimovich | 50c4a4b | 2020-04-21 15:36:33 +0100 | [diff] [blame] | 4859 | config.BootJars = []string{"platform:some-platform-lib"} |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 4860 | } |
| 4861 | testNoUpdatableJarsInBootImage(t, "", bp, transform) |
| 4862 | } |
| 4863 | |
Jiyong Park | 62304bb | 2020-04-13 16:19:48 +0900 | [diff] [blame] | 4864 | func TestTestFor(t *testing.T) { |
| 4865 | ctx, _ := testApex(t, ` |
| 4866 | apex { |
| 4867 | name: "myapex", |
| 4868 | key: "myapex.key", |
| 4869 | native_shared_libs: ["mylib", "myprivlib"], |
| 4870 | } |
| 4871 | |
| 4872 | apex_key { |
| 4873 | name: "myapex.key", |
| 4874 | public_key: "testkey.avbpubkey", |
| 4875 | private_key: "testkey.pem", |
| 4876 | } |
| 4877 | |
| 4878 | cc_library { |
| 4879 | name: "mylib", |
| 4880 | srcs: ["mylib.cpp"], |
| 4881 | system_shared_libs: [], |
| 4882 | stl: "none", |
| 4883 | stubs: { |
| 4884 | versions: ["1"], |
| 4885 | }, |
| 4886 | apex_available: ["myapex"], |
| 4887 | } |
| 4888 | |
| 4889 | cc_library { |
| 4890 | name: "myprivlib", |
| 4891 | srcs: ["mylib.cpp"], |
| 4892 | system_shared_libs: [], |
| 4893 | stl: "none", |
| 4894 | apex_available: ["myapex"], |
| 4895 | } |
| 4896 | |
| 4897 | |
| 4898 | cc_test { |
| 4899 | name: "mytest", |
| 4900 | gtest: false, |
| 4901 | srcs: ["mylib.cpp"], |
| 4902 | system_shared_libs: [], |
| 4903 | stl: "none", |
| 4904 | shared_libs: ["mylib", "myprivlib"], |
| 4905 | test_for: ["myapex"] |
| 4906 | } |
| 4907 | `) |
| 4908 | |
| 4909 | // the test 'mytest' is a test for the apex, therefore is linked to the |
| 4910 | // actual implementation of mylib instead of its stub. |
| 4911 | ldFlags := ctx.ModuleForTests("mytest", "android_arm64_armv8-a").Rule("ld").Args["libFlags"] |
| 4912 | ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_shared/mylib.so") |
| 4913 | ensureNotContains(t, ldFlags, "mylib/android_arm64_armv8-a_shared_1/mylib.so") |
| 4914 | } |
| 4915 | |
Jaewoong Jung | c1001ec | 2019-06-25 11:20:53 -0700 | [diff] [blame] | 4916 | func TestMain(m *testing.M) { |
| 4917 | run := func() int { |
| 4918 | setUp() |
| 4919 | defer tearDown() |
| 4920 | |
| 4921 | return m.Run() |
| 4922 | } |
| 4923 | |
| 4924 | os.Exit(run()) |
| 4925 | } |