blob: 4e2c1beab60b354ae7df98b93f01ebd243e015fa [file] [log] [blame]
Jiyong Park25fc6a92018-11-18 18:02:45 +09001// Copyright 2018 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package apex
16
17import (
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +090018 "fmt"
Jiyong Park25fc6a92018-11-18 18:02:45 +090019 "os"
Jooyung Han39edb6c2019-11-06 16:53:07 +090020 "path"
Paul Duffin37856732021-02-26 14:24:15 +000021 "path/filepath"
Jaewoong Jung22f7d182019-07-16 18:25:41 -070022 "reflect"
Paul Duffin9b879592020-05-26 13:21:35 +010023 "regexp"
Jooyung Han31c470b2019-10-18 16:26:59 +090024 "sort"
Jiyong Parkd4a3a132021-03-17 20:21:35 +090025 "strconv"
Jiyong Park25fc6a92018-11-18 18:02:45 +090026 "strings"
27 "testing"
Jiyong Parkda6eb592018-12-19 17:12:36 +090028
29 "github.com/google/blueprint/proptools"
30
31 "android/soong/android"
markchien2f59ec92020-09-02 16:23:38 +080032 "android/soong/bpf"
Jiyong Parkda6eb592018-12-19 17:12:36 +090033 "android/soong/cc"
Ulya Trafimovichb28cc372020-01-13 15:18:16 +000034 "android/soong/dexpreopt"
Jaewoong Jung4b79e982020-06-01 10:45:49 -070035 prebuilt_etc "android/soong/etc"
Jiyong Parkb2742fd2019-02-11 11:38:15 +090036 "android/soong/java"
Jiyong Park99644e92020-11-17 22:21:02 +090037 "android/soong/rust"
Jaewoong Jung4b79e982020-06-01 10:45:49 -070038 "android/soong/sh"
Jiyong Park25fc6a92018-11-18 18:02:45 +090039)
40
Jooyung Hand3639552019-08-09 12:57:43 +090041// names returns name list from white space separated string
42func names(s string) (ns []string) {
43 for _, n := range strings.Split(s, " ") {
44 if len(n) > 0 {
45 ns = append(ns, n)
46 }
47 }
48 return
49}
50
Paul Duffin40b62572021-03-20 11:39:01 +000051func testApexError(t *testing.T, pattern, bp string, preparers ...android.FixturePreparer) {
Jooyung Han344d5432019-08-23 11:17:39 +090052 t.Helper()
Paul Duffin284165a2021-03-29 01:50:31 +010053 android.GroupFixturePreparers(
54 prepareForApexTest,
55 android.GroupFixturePreparers(preparers...),
56 ).
Paul Duffine05480a2021-03-08 15:07:14 +000057 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)).
Paul Duffin40b62572021-03-20 11:39:01 +000058 RunTestWithBp(t, bp)
Jooyung Han5c998b92019-06-27 11:30:33 +090059}
60
Paul Duffin40b62572021-03-20 11:39:01 +000061func testApex(t *testing.T, bp string, preparers ...android.FixturePreparer) *android.TestContext {
Jooyung Han344d5432019-08-23 11:17:39 +090062 t.Helper()
Paul Duffin284165a2021-03-29 01:50:31 +010063
64 optionalBpPreparer := android.NullFixturePreparer
Paul Duffin40b62572021-03-20 11:39:01 +000065 if bp != "" {
Paul Duffin284165a2021-03-29 01:50:31 +010066 optionalBpPreparer = android.FixtureWithRootAndroidBp(bp)
Paul Duffin40b62572021-03-20 11:39:01 +000067 }
Paul Duffin284165a2021-03-29 01:50:31 +010068
69 result := android.GroupFixturePreparers(
70 prepareForApexTest,
71 android.GroupFixturePreparers(preparers...),
72 optionalBpPreparer,
73 ).RunTest(t)
74
Paul Duffine05480a2021-03-08 15:07:14 +000075 return result.TestContext
Jooyung Han5c998b92019-06-27 11:30:33 +090076}
77
Paul Duffin810f33d2021-03-09 14:12:32 +000078func withFiles(files android.MockFS) android.FixturePreparer {
79 return files.AddToFixture()
Jooyung Han344d5432019-08-23 11:17:39 +090080}
81
Paul Duffin810f33d2021-03-09 14:12:32 +000082func withTargets(targets map[android.OsType][]android.Target) android.FixturePreparer {
83 return android.FixtureModifyConfig(func(config android.Config) {
Jooyung Han344d5432019-08-23 11:17:39 +090084 for k, v := range targets {
85 config.Targets[k] = v
86 }
Paul Duffin810f33d2021-03-09 14:12:32 +000087 })
Jooyung Han344d5432019-08-23 11:17:39 +090088}
89
Jooyung Han35155c42020-02-06 17:33:20 +090090// withNativeBridgeTargets sets configuration with targets including:
91// - X86_64 (primary)
92// - X86 (secondary)
93// - Arm64 on X86_64 (native bridge)
94// - Arm on X86 (native bridge)
Paul Duffin810f33d2021-03-09 14:12:32 +000095var withNativeBridgeEnabled = android.FixtureModifyConfig(
96 func(config android.Config) {
97 config.Targets[android.Android] = []android.Target{
98 {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "silvermont", Abi: []string{"arm64-v8a"}},
99 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
100 {Os: android.Android, Arch: android.Arch{ArchType: android.X86, ArchVariant: "silvermont", Abi: []string{"armeabi-v7a"}},
101 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
102 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}},
103 NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86_64", NativeBridgeRelativePath: "arm64"},
104 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
105 NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86", NativeBridgeRelativePath: "arm"},
106 }
107 },
108)
109
110func withManifestPackageNameOverrides(specs []string) android.FixturePreparer {
111 return android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
112 variables.ManifestPackageNameOverrides = specs
113 })
Jooyung Han35155c42020-02-06 17:33:20 +0900114}
115
Paul Duffin810f33d2021-03-09 14:12:32 +0000116var withBinder32bit = android.FixtureModifyProductVariables(
117 func(variables android.FixtureProductVariables) {
118 variables.Binder32bit = proptools.BoolPtr(true)
119 },
120)
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900121
Paul Duffin810f33d2021-03-09 14:12:32 +0000122var withUnbundledBuild = android.FixtureModifyProductVariables(
123 func(variables android.FixtureProductVariables) {
124 variables.Unbundled_build = proptools.BoolPtr(true)
125 },
126)
Jiyong Park7cd10e32020-01-14 09:22:18 +0900127
Paul Duffin284165a2021-03-29 01:50:31 +0100128// Legacy preparer used for running tests within the apex package.
129//
130// This includes everything that was needed to run any test in the apex package prior to the
131// introduction of the test fixtures. Tests that are being converted to use fixtures directly
132// rather than through the testApex...() methods should avoid using this and instead use the
133// various preparers directly, using android.GroupFixturePreparers(...) to group them when
134// necessary.
135//
136// deprecated
137var prepareForApexTest = android.GroupFixturePreparers(
Paul Duffin37aad602021-03-08 09:47:16 +0000138 // General preparers in alphabetical order as test infrastructure will enforce correct
139 // registration order.
140 android.PrepareForTestWithAndroidBuildComponents,
141 bpf.PrepareForTestWithBpf,
142 cc.PrepareForTestWithCcBuildComponents,
143 java.PrepareForTestWithJavaDefaultModules,
144 prebuilt_etc.PrepareForTestWithPrebuiltEtc,
145 rust.PrepareForTestWithRustDefaultModules,
146 sh.PrepareForTestWithShBuildComponents,
147
148 PrepareForTestWithApexBuildComponents,
149
150 // Additional apex test specific preparers.
151 android.FixtureAddTextFile("system/sepolicy/Android.bp", `
152 filegroup {
153 name: "myapex-file_contexts",
154 srcs: [
155 "apex/myapex-file_contexts",
156 ],
157 }
158 `),
Paul Duffin52bfaa42021-03-23 23:40:12 +0000159 prepareForTestWithMyapex,
Paul Duffin37aad602021-03-08 09:47:16 +0000160 android.FixtureMergeMockFs(android.MockFS{
Paul Duffin52bfaa42021-03-23 23:40:12 +0000161 "a.java": nil,
162 "PrebuiltAppFoo.apk": nil,
163 "PrebuiltAppFooPriv.apk": nil,
164 "apex_manifest.json": nil,
165 "AndroidManifest.xml": nil,
Paul Duffin37aad602021-03-08 09:47:16 +0000166 "system/sepolicy/apex/myapex.updatable-file_contexts": nil,
167 "system/sepolicy/apex/myapex2-file_contexts": nil,
168 "system/sepolicy/apex/otherapex-file_contexts": nil,
169 "system/sepolicy/apex/com.android.vndk-file_contexts": nil,
170 "system/sepolicy/apex/com.android.vndk.current-file_contexts": nil,
171 "mylib.cpp": nil,
172 "mytest.cpp": nil,
173 "mytest1.cpp": nil,
174 "mytest2.cpp": nil,
175 "mytest3.cpp": nil,
176 "myprebuilt": nil,
177 "my_include": nil,
178 "foo/bar/MyClass.java": nil,
179 "prebuilt.jar": nil,
180 "prebuilt.so": nil,
181 "vendor/foo/devkeys/test.x509.pem": nil,
182 "vendor/foo/devkeys/test.pk8": nil,
183 "testkey.x509.pem": nil,
184 "testkey.pk8": nil,
185 "testkey.override.x509.pem": nil,
186 "testkey.override.pk8": nil,
187 "vendor/foo/devkeys/testkey.avbpubkey": nil,
188 "vendor/foo/devkeys/testkey.pem": nil,
189 "NOTICE": nil,
190 "custom_notice": nil,
191 "custom_notice_for_static_lib": nil,
192 "testkey2.avbpubkey": nil,
193 "testkey2.pem": nil,
194 "myapex-arm64.apex": nil,
195 "myapex-arm.apex": nil,
196 "myapex.apks": nil,
197 "frameworks/base/api/current.txt": nil,
198 "framework/aidl/a.aidl": nil,
199 "build/make/core/proguard.flags": nil,
200 "build/make/core/proguard_basic_keeps.flags": nil,
201 "dummy.txt": nil,
202 "baz": nil,
203 "bar/baz": nil,
204 "testdata/baz": nil,
205 "AppSet.apks": nil,
206 "foo.rs": nil,
207 "libfoo.jar": nil,
208 "libbar.jar": nil,
209 },
210 ),
211
212 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
213 variables.DeviceVndkVersion = proptools.StringPtr("current")
214 variables.DefaultAppCertificate = proptools.StringPtr("vendor/foo/devkeys/test")
215 variables.CertificateOverrides = []string{"myapex_keytest:myapex.certificate.override"}
216 variables.Platform_sdk_codename = proptools.StringPtr("Q")
217 variables.Platform_sdk_final = proptools.BoolPtr(false)
218 variables.Platform_version_active_codenames = []string{"Q"}
Jiyong Parkf58c46e2021-04-01 21:35:20 +0900219 variables.Platform_vndk_version = proptools.StringPtr("29")
Paul Duffin37aad602021-03-08 09:47:16 +0000220 }),
221)
222
Paul Duffin52bfaa42021-03-23 23:40:12 +0000223var prepareForTestWithMyapex = android.FixtureMergeMockFs(android.MockFS{
224 "system/sepolicy/apex/myapex-file_contexts": nil,
225})
226
Jooyung Han643adc42020-02-27 13:50:06 +0900227// ensure that 'result' equals 'expected'
228func ensureEquals(t *testing.T, result string, expected string) {
229 t.Helper()
230 if result != expected {
231 t.Errorf("%q != %q", expected, result)
232 }
233}
234
Jiyong Park25fc6a92018-11-18 18:02:45 +0900235// ensure that 'result' contains 'expected'
236func ensureContains(t *testing.T, result string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900237 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900238 if !strings.Contains(result, expected) {
239 t.Errorf("%q is not found in %q", expected, result)
240 }
241}
242
Liz Kammer5bd365f2020-05-27 15:15:11 -0700243// ensure that 'result' contains 'expected' exactly one time
244func ensureContainsOnce(t *testing.T, result string, expected string) {
245 t.Helper()
246 count := strings.Count(result, expected)
247 if count != 1 {
248 t.Errorf("%q is found %d times (expected 1 time) in %q", expected, count, result)
249 }
250}
251
Jiyong Park25fc6a92018-11-18 18:02:45 +0900252// ensures that 'result' does not contain 'notExpected'
253func ensureNotContains(t *testing.T, result string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900254 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900255 if strings.Contains(result, notExpected) {
256 t.Errorf("%q is found in %q", notExpected, result)
257 }
258}
259
Sasha Smundak18d98bc2020-05-27 16:36:07 -0700260func ensureMatches(t *testing.T, result string, expectedRex string) {
261 ok, err := regexp.MatchString(expectedRex, result)
262 if err != nil {
263 t.Fatalf("regexp failure trying to match %s against `%s` expression: %s", result, expectedRex, err)
264 return
265 }
266 if !ok {
267 t.Errorf("%s does not match regular expession %s", result, expectedRex)
268 }
269}
270
Jiyong Park25fc6a92018-11-18 18:02:45 +0900271func ensureListContains(t *testing.T, result []string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900272 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900273 if !android.InList(expected, result) {
274 t.Errorf("%q is not found in %v", expected, result)
275 }
276}
277
278func ensureListNotContains(t *testing.T, result []string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900279 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900280 if android.InList(notExpected, result) {
281 t.Errorf("%q is found in %v", notExpected, result)
282 }
283}
284
Jooyung Hane1633032019-08-01 17:41:43 +0900285func ensureListEmpty(t *testing.T, result []string) {
286 t.Helper()
287 if len(result) > 0 {
288 t.Errorf("%q is expected to be empty", result)
289 }
290}
291
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +0000292func ensureListNotEmpty(t *testing.T, result []string) {
293 t.Helper()
294 if len(result) == 0 {
295 t.Errorf("%q is expected to be not empty", result)
296 }
297}
298
Jiyong Park25fc6a92018-11-18 18:02:45 +0900299// Minimal test
300func TestBasicApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800301 ctx := testApex(t, `
Jiyong Park30ca9372019-02-07 16:27:23 +0900302 apex_defaults {
303 name: "myapex-defaults",
Jiyong Park809bb722019-02-13 21:33:49 +0900304 manifest: ":myapex.manifest",
305 androidManifest: ":myapex.androidmanifest",
Jiyong Park25fc6a92018-11-18 18:02:45 +0900306 key: "myapex.key",
Jiyong Park99644e92020-11-17 22:21:02 +0900307 binaries: ["foo.rust"],
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900308 native_shared_libs: [
309 "mylib",
310 "libfoo.ffi",
311 ],
Jiyong Park99644e92020-11-17 22:21:02 +0900312 rust_dyn_libs: ["libfoo.dylib.rust"],
Alex Light3d673592019-01-18 14:37:31 -0800313 multilib: {
314 both: {
Jiyong Park99644e92020-11-17 22:21:02 +0900315 binaries: ["foo"],
Alex Light3d673592019-01-18 14:37:31 -0800316 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900317 },
Jiyong Park77acec62020-06-01 21:39:15 +0900318 java_libs: [
319 "myjar",
320 "myjar_dex",
321 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000322 updatable: false,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900323 }
324
Jiyong Park30ca9372019-02-07 16:27:23 +0900325 apex {
326 name: "myapex",
327 defaults: ["myapex-defaults"],
328 }
329
Jiyong Park25fc6a92018-11-18 18:02:45 +0900330 apex_key {
331 name: "myapex.key",
332 public_key: "testkey.avbpubkey",
333 private_key: "testkey.pem",
334 }
335
Jiyong Park809bb722019-02-13 21:33:49 +0900336 filegroup {
337 name: "myapex.manifest",
338 srcs: ["apex_manifest.json"],
339 }
340
341 filegroup {
342 name: "myapex.androidmanifest",
343 srcs: ["AndroidManifest.xml"],
344 }
345
Jiyong Park25fc6a92018-11-18 18:02:45 +0900346 cc_library {
347 name: "mylib",
348 srcs: ["mylib.cpp"],
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900349 shared_libs: [
350 "mylib2",
351 "libbar.ffi",
352 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900353 system_shared_libs: [],
354 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000355 // TODO: remove //apex_available:platform
356 apex_available: [
357 "//apex_available:platform",
358 "myapex",
359 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900360 }
361
Alex Light3d673592019-01-18 14:37:31 -0800362 cc_binary {
363 name: "foo",
364 srcs: ["mylib.cpp"],
365 compile_multilib: "both",
366 multilib: {
367 lib32: {
368 suffix: "32",
369 },
370 lib64: {
371 suffix: "64",
372 },
373 },
374 symlinks: ["foo_link_"],
375 symlink_preferred_arch: true,
376 system_shared_libs: [],
377 static_executable: true,
378 stl: "none",
Yifan Hongd22a84a2020-07-28 17:37:46 -0700379 apex_available: [ "myapex", "com.android.gki.*" ],
380 }
381
Jiyong Park99644e92020-11-17 22:21:02 +0900382 rust_binary {
Artur Satayev533b98c2021-03-11 18:03:42 +0000383 name: "foo.rust",
Jiyong Park99644e92020-11-17 22:21:02 +0900384 srcs: ["foo.rs"],
385 rlibs: ["libfoo.rlib.rust"],
386 dylibs: ["libfoo.dylib.rust"],
387 apex_available: ["myapex"],
388 }
389
390 rust_library_rlib {
Artur Satayev533b98c2021-03-11 18:03:42 +0000391 name: "libfoo.rlib.rust",
Jiyong Park99644e92020-11-17 22:21:02 +0900392 srcs: ["foo.rs"],
393 crate_name: "foo",
394 apex_available: ["myapex"],
Jiyong Park94e22fd2021-04-08 18:19:15 +0900395 shared_libs: ["libfoo.shared_from_rust"],
396 }
397
398 cc_library_shared {
399 name: "libfoo.shared_from_rust",
400 srcs: ["mylib.cpp"],
401 system_shared_libs: [],
402 stl: "none",
403 apex_available: ["myapex"],
Jiyong Park99644e92020-11-17 22:21:02 +0900404 }
405
406 rust_library_dylib {
Artur Satayev533b98c2021-03-11 18:03:42 +0000407 name: "libfoo.dylib.rust",
Jiyong Park99644e92020-11-17 22:21:02 +0900408 srcs: ["foo.rs"],
409 crate_name: "foo",
410 apex_available: ["myapex"],
411 }
412
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900413 rust_ffi_shared {
414 name: "libfoo.ffi",
415 srcs: ["foo.rs"],
416 crate_name: "foo",
417 apex_available: ["myapex"],
418 }
419
420 rust_ffi_shared {
421 name: "libbar.ffi",
422 srcs: ["foo.rs"],
423 crate_name: "bar",
424 apex_available: ["myapex"],
425 }
426
Yifan Hongd22a84a2020-07-28 17:37:46 -0700427 apex {
428 name: "com.android.gki.fake",
429 binaries: ["foo"],
430 key: "myapex.key",
431 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000432 updatable: false,
Alex Light3d673592019-01-18 14:37:31 -0800433 }
434
Paul Duffindddd5462020-04-07 15:25:44 +0100435 cc_library_shared {
Jiyong Park25fc6a92018-11-18 18:02:45 +0900436 name: "mylib2",
437 srcs: ["mylib.cpp"],
438 system_shared_libs: [],
439 stl: "none",
Jiyong Park52818fc2019-03-18 12:01:38 +0900440 notice: "custom_notice",
Jiyong Park9918e1a2020-03-17 19:16:40 +0900441 static_libs: ["libstatic"],
442 // TODO: remove //apex_available:platform
443 apex_available: [
444 "//apex_available:platform",
445 "myapex",
446 ],
447 }
448
Paul Duffindddd5462020-04-07 15:25:44 +0100449 cc_prebuilt_library_shared {
450 name: "mylib2",
451 srcs: ["prebuilt.so"],
452 // TODO: remove //apex_available:platform
453 apex_available: [
454 "//apex_available:platform",
455 "myapex",
456 ],
457 }
458
Jiyong Park9918e1a2020-03-17 19:16:40 +0900459 cc_library_static {
460 name: "libstatic",
461 srcs: ["mylib.cpp"],
462 system_shared_libs: [],
463 stl: "none",
464 notice: "custom_notice_for_static_lib",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000465 // TODO: remove //apex_available:platform
466 apex_available: [
467 "//apex_available:platform",
468 "myapex",
469 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900470 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900471
472 java_library {
473 name: "myjar",
474 srcs: ["foo/bar/MyClass.java"],
Jiyong Parka62aa232020-05-28 23:46:55 +0900475 stem: "myjar_stem",
Jiyong Park7f7766d2019-07-25 22:02:35 +0900476 sdk_version: "none",
477 system_modules: "none",
Jiyong Park7f7766d2019-07-25 22:02:35 +0900478 static_libs: ["myotherjar"],
Jiyong Park3ff16992019-12-27 14:11:47 +0900479 libs: ["mysharedjar"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000480 // TODO: remove //apex_available:platform
481 apex_available: [
482 "//apex_available:platform",
483 "myapex",
484 ],
Jiyong Park7f7766d2019-07-25 22:02:35 +0900485 }
486
Jiyong Park77acec62020-06-01 21:39:15 +0900487 dex_import {
488 name: "myjar_dex",
489 jars: ["prebuilt.jar"],
490 apex_available: [
491 "//apex_available:platform",
492 "myapex",
493 ],
494 }
495
Jiyong Park7f7766d2019-07-25 22:02:35 +0900496 java_library {
497 name: "myotherjar",
498 srcs: ["foo/bar/MyClass.java"],
499 sdk_version: "none",
500 system_modules: "none",
Jiyong Park0f80c182020-01-31 02:49:53 +0900501 // TODO: remove //apex_available:platform
502 apex_available: [
503 "//apex_available:platform",
504 "myapex",
505 ],
Jiyong Park7f7766d2019-07-25 22:02:35 +0900506 }
Jiyong Park3ff16992019-12-27 14:11:47 +0900507
508 java_library {
509 name: "mysharedjar",
510 srcs: ["foo/bar/MyClass.java"],
511 sdk_version: "none",
512 system_modules: "none",
Jiyong Park3ff16992019-12-27 14:11:47 +0900513 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900514 `)
515
Paul Duffina71a67a2021-03-29 00:42:57 +0100516 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900517
Jiyong Park9e83f0b2020-06-11 00:35:03 +0900518 // Make sure that Android.mk is created
519 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -0700520 data := android.AndroidMkDataForTest(t, ctx, ab)
Jiyong Park9e83f0b2020-06-11 00:35:03 +0900521 var builder strings.Builder
522 data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
523
524 androidMk := builder.String()
525 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
526 ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
527
Jiyong Park42cca6c2019-04-01 11:15:50 +0900528 optFlags := apexRule.Args["opt_flags"]
529 ensureContains(t, optFlags, "--pubkey vendor/foo/devkeys/testkey.avbpubkey")
Jaewoong Jung14f5ff62019-06-18 13:09:13 -0700530 // Ensure that the NOTICE output is being packaged as an asset.
Paul Duffin37ba3442021-03-29 00:21:08 +0100531 ensureContains(t, optFlags, "--assets_dir out/soong/.intermediates/myapex/android_common_myapex_image/NOTICE")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900532
Jiyong Park25fc6a92018-11-18 18:02:45 +0900533 copyCmds := apexRule.Args["copy_commands"]
534
535 // Ensure that main rule creates an output
536 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
537
538 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -0700539 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
540 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common_apex10000")
541 ensureListContains(t, ctx.ModuleVariantsForTests("myjar_dex"), "android_common_apex10000")
Jiyong Park99644e92020-11-17 22:21:02 +0900542 ensureListContains(t, ctx.ModuleVariantsForTests("foo.rust"), "android_arm64_armv8-a_apex10000")
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900543 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.ffi"), "android_arm64_armv8-a_shared_apex10000")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900544
545 // Ensure that apex variant is created for the indirect dep
Colin Crossaede88c2020-08-11 12:17:01 -0700546 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
547 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common_apex10000")
Jiyong Park99644e92020-11-17 22:21:02 +0900548 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.rlib.rust"), "android_arm64_armv8-a_rlib_dylib-std_apex10000")
549 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.dylib.rust"), "android_arm64_armv8-a_dylib_apex10000")
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900550 ensureListContains(t, ctx.ModuleVariantsForTests("libbar.ffi"), "android_arm64_armv8-a_shared_apex10000")
Jiyong Park94e22fd2021-04-08 18:19:15 +0900551 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.shared_from_rust"), "android_arm64_armv8-a_shared_apex10000")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900552
553 // Ensure that both direct and indirect deps are copied into apex
Alex Light5098a612018-11-29 17:12:15 -0800554 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
555 ensureContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Parka62aa232020-05-28 23:46:55 +0900556 ensureContains(t, copyCmds, "image.apex/javalib/myjar_stem.jar")
Jiyong Park77acec62020-06-01 21:39:15 +0900557 ensureContains(t, copyCmds, "image.apex/javalib/myjar_dex.jar")
Jiyong Park99644e92020-11-17 22:21:02 +0900558 ensureContains(t, copyCmds, "image.apex/lib64/libfoo.dylib.rust.dylib.so")
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900559 ensureContains(t, copyCmds, "image.apex/lib64/libfoo.ffi.so")
560 ensureContains(t, copyCmds, "image.apex/lib64/libbar.ffi.so")
Jiyong Park94e22fd2021-04-08 18:19:15 +0900561 ensureContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900562 // .. but not for java libs
563 ensureNotContains(t, copyCmds, "image.apex/javalib/myotherjar.jar")
Jiyong Park3ff16992019-12-27 14:11:47 +0900564 ensureNotContains(t, copyCmds, "image.apex/javalib/msharedjar.jar")
Logan Chien3aeedc92018-12-26 15:32:21 +0800565
Colin Cross7113d202019-11-20 16:39:12 -0800566 // Ensure that the platform variant ends with _shared or _common
567 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
568 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900569 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common")
570 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common")
Jiyong Park3ff16992019-12-27 14:11:47 +0900571 ensureListContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common")
572
573 // Ensure that dynamic dependency to java libs are not included
574 ensureListNotContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common_myapex")
Alex Light3d673592019-01-18 14:37:31 -0800575
576 // Ensure that all symlinks are present.
577 found_foo_link_64 := false
578 found_foo := false
579 for _, cmd := range strings.Split(copyCmds, " && ") {
Jiyong Park7cd10e32020-01-14 09:22:18 +0900580 if strings.HasPrefix(cmd, "ln -sfn foo64") {
Alex Light3d673592019-01-18 14:37:31 -0800581 if strings.HasSuffix(cmd, "bin/foo") {
582 found_foo = true
583 } else if strings.HasSuffix(cmd, "bin/foo_link_64") {
584 found_foo_link_64 = true
585 }
586 }
587 }
588 good := found_foo && found_foo_link_64
589 if !good {
590 t.Errorf("Could not find all expected symlinks! foo: %t, foo_link_64: %t. Command was %s", found_foo, found_foo_link_64, copyCmds)
591 }
Jiyong Park52818fc2019-03-18 12:01:38 +0900592
Sundong Ahnabb64432019-10-22 13:58:29 +0900593 mergeNoticesRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("mergeNoticesRule")
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700594 noticeInputs := mergeNoticesRule.Inputs.Strings()
Jiyong Park9918e1a2020-03-17 19:16:40 +0900595 if len(noticeInputs) != 3 {
596 t.Errorf("number of input notice files: expected = 3, actual = %q", len(noticeInputs))
Jiyong Park52818fc2019-03-18 12:01:38 +0900597 }
598 ensureListContains(t, noticeInputs, "NOTICE")
599 ensureListContains(t, noticeInputs, "custom_notice")
Jiyong Park9918e1a2020-03-17 19:16:40 +0900600 ensureListContains(t, noticeInputs, "custom_notice_for_static_lib")
Jiyong Park83dc74b2020-01-14 18:38:44 +0900601
Artur Satayeva8bd1132020-04-27 18:07:06 +0100602 fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100603 ensureListContains(t, fullDepsInfo, " myjar(minSdkVersion:(no version)) <- myapex")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100604 ensureListContains(t, fullDepsInfo, " mylib2(minSdkVersion:(no version)) <- mylib")
605 ensureListContains(t, fullDepsInfo, " myotherjar(minSdkVersion:(no version)) <- myjar")
606 ensureListContains(t, fullDepsInfo, " mysharedjar(minSdkVersion:(no version)) (external) <- myjar")
Artur Satayeva8bd1132020-04-27 18:07:06 +0100607
608 flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100609 ensureListContains(t, flatDepsInfo, "myjar(minSdkVersion:(no version))")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100610 ensureListContains(t, flatDepsInfo, "mylib2(minSdkVersion:(no version))")
611 ensureListContains(t, flatDepsInfo, "myotherjar(minSdkVersion:(no version))")
612 ensureListContains(t, flatDepsInfo, "mysharedjar(minSdkVersion:(no version)) (external)")
Alex Light5098a612018-11-29 17:12:15 -0800613}
614
Jooyung Hanf21c7972019-12-16 22:32:06 +0900615func TestDefaults(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800616 ctx := testApex(t, `
Jooyung Hanf21c7972019-12-16 22:32:06 +0900617 apex_defaults {
618 name: "myapex-defaults",
619 key: "myapex.key",
620 prebuilts: ["myetc"],
621 native_shared_libs: ["mylib"],
622 java_libs: ["myjar"],
623 apps: ["AppFoo"],
Jiyong Park69aeba92020-04-24 21:16:36 +0900624 rros: ["rro"],
markchien2f59ec92020-09-02 16:23:38 +0800625 bpfs: ["bpf"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000626 updatable: false,
Jooyung Hanf21c7972019-12-16 22:32:06 +0900627 }
628
629 prebuilt_etc {
630 name: "myetc",
631 src: "myprebuilt",
632 }
633
634 apex {
635 name: "myapex",
636 defaults: ["myapex-defaults"],
637 }
638
639 apex_key {
640 name: "myapex.key",
641 public_key: "testkey.avbpubkey",
642 private_key: "testkey.pem",
643 }
644
645 cc_library {
646 name: "mylib",
647 system_shared_libs: [],
648 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000649 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900650 }
651
652 java_library {
653 name: "myjar",
654 srcs: ["foo/bar/MyClass.java"],
655 sdk_version: "none",
656 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000657 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900658 }
659
660 android_app {
661 name: "AppFoo",
662 srcs: ["foo/bar/MyClass.java"],
663 sdk_version: "none",
664 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000665 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900666 }
Jiyong Park69aeba92020-04-24 21:16:36 +0900667
668 runtime_resource_overlay {
669 name: "rro",
670 theme: "blue",
671 }
672
markchien2f59ec92020-09-02 16:23:38 +0800673 bpf {
674 name: "bpf",
675 srcs: ["bpf.c", "bpf2.c"],
676 }
677
Jooyung Hanf21c7972019-12-16 22:32:06 +0900678 `)
Jooyung Hana57af4a2020-01-23 05:36:59 +0000679 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Hanf21c7972019-12-16 22:32:06 +0900680 "etc/myetc",
681 "javalib/myjar.jar",
682 "lib64/mylib.so",
683 "app/AppFoo/AppFoo.apk",
Jiyong Park69aeba92020-04-24 21:16:36 +0900684 "overlay/blue/rro.apk",
markchien2f59ec92020-09-02 16:23:38 +0800685 "etc/bpf/bpf.o",
686 "etc/bpf/bpf2.o",
Jooyung Hanf21c7972019-12-16 22:32:06 +0900687 })
688}
689
Jooyung Han01a3ee22019-11-02 02:52:25 +0900690func TestApexManifest(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800691 ctx := testApex(t, `
Jooyung Han01a3ee22019-11-02 02:52:25 +0900692 apex {
693 name: "myapex",
694 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000695 updatable: false,
Jooyung Han01a3ee22019-11-02 02:52:25 +0900696 }
697
698 apex_key {
699 name: "myapex.key",
700 public_key: "testkey.avbpubkey",
701 private_key: "testkey.pem",
702 }
703 `)
704
705 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Han214bf372019-11-12 13:03:50 +0900706 args := module.Rule("apexRule").Args
707 if manifest := args["manifest"]; manifest != module.Output("apex_manifest.pb").Output.String() {
708 t.Error("manifest should be apex_manifest.pb, but " + manifest)
709 }
Jooyung Han01a3ee22019-11-02 02:52:25 +0900710}
711
Liz Kammer4854a7d2021-05-27 14:28:27 -0400712func TestApexManifestMinSdkVersion(t *testing.T) {
713 ctx := testApex(t, `
714 apex_defaults {
715 name: "my_defaults",
716 key: "myapex.key",
717 product_specific: true,
718 file_contexts: ":my-file-contexts",
719 updatable: false,
720 }
721 apex {
722 name: "myapex_30",
723 min_sdk_version: "30",
724 defaults: ["my_defaults"],
725 }
726
727 apex {
728 name: "myapex_current",
729 min_sdk_version: "current",
730 defaults: ["my_defaults"],
731 }
732
733 apex {
734 name: "myapex_none",
735 defaults: ["my_defaults"],
736 }
737
738 apex_key {
739 name: "myapex.key",
740 public_key: "testkey.avbpubkey",
741 private_key: "testkey.pem",
742 }
743
744 filegroup {
745 name: "my-file-contexts",
746 srcs: ["product_specific_file_contexts"],
747 }
748 `, withFiles(map[string][]byte{
749 "product_specific_file_contexts": nil,
750 }), android.FixtureModifyProductVariables(
751 func(variables android.FixtureProductVariables) {
752 variables.Unbundled_build = proptools.BoolPtr(true)
753 variables.Always_use_prebuilt_sdks = proptools.BoolPtr(false)
754 }), android.FixtureMergeEnv(map[string]string{
755 "UNBUNDLED_BUILD_TARGET_SDK_WITH_API_FINGERPRINT": "true",
756 }))
757
758 testCases := []struct {
759 module string
760 minSdkVersion string
761 }{
762 {
763 module: "myapex_30",
764 minSdkVersion: "30",
765 },
766 {
767 module: "myapex_current",
768 minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
769 },
770 {
771 module: "myapex_none",
772 minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
773 },
774 }
775 for _, tc := range testCases {
776 module := ctx.ModuleForTests(tc.module, "android_common_"+tc.module+"_image")
777 args := module.Rule("apexRule").Args
778 optFlags := args["opt_flags"]
779 if !strings.Contains(optFlags, "--min_sdk_version "+tc.minSdkVersion) {
780 t.Errorf("%s: Expected min_sdk_version=%s, got: %s", tc.module, tc.minSdkVersion, optFlags)
781 }
782 }
783}
784
Alex Light5098a612018-11-29 17:12:15 -0800785func TestBasicZipApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800786 ctx := testApex(t, `
Alex Light5098a612018-11-29 17:12:15 -0800787 apex {
788 name: "myapex",
789 key: "myapex.key",
790 payload_type: "zip",
791 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000792 updatable: false,
Alex Light5098a612018-11-29 17:12:15 -0800793 }
794
795 apex_key {
796 name: "myapex.key",
797 public_key: "testkey.avbpubkey",
798 private_key: "testkey.pem",
799 }
800
801 cc_library {
802 name: "mylib",
803 srcs: ["mylib.cpp"],
804 shared_libs: ["mylib2"],
805 system_shared_libs: [],
806 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000807 apex_available: [ "myapex" ],
Alex Light5098a612018-11-29 17:12:15 -0800808 }
809
810 cc_library {
811 name: "mylib2",
812 srcs: ["mylib.cpp"],
813 system_shared_libs: [],
814 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000815 apex_available: [ "myapex" ],
Alex Light5098a612018-11-29 17:12:15 -0800816 }
817 `)
818
Sundong Ahnabb64432019-10-22 13:58:29 +0900819 zipApexRule := ctx.ModuleForTests("myapex", "android_common_myapex_zip").Rule("zipApexRule")
Alex Light5098a612018-11-29 17:12:15 -0800820 copyCmds := zipApexRule.Args["copy_commands"]
821
822 // Ensure that main rule creates an output
823 ensureContains(t, zipApexRule.Output.String(), "myapex.zipapex.unsigned")
824
825 // Ensure that APEX variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -0700826 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
Alex Light5098a612018-11-29 17:12:15 -0800827
828 // Ensure that APEX variant is created for the indirect dep
Colin Crossaede88c2020-08-11 12:17:01 -0700829 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
Alex Light5098a612018-11-29 17:12:15 -0800830
831 // Ensure that both direct and indirect deps are copied into apex
832 ensureContains(t, copyCmds, "image.zipapex/lib64/mylib.so")
833 ensureContains(t, copyCmds, "image.zipapex/lib64/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900834}
835
836func TestApexWithStubs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800837 ctx := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +0900838 apex {
839 name: "myapex",
840 key: "myapex.key",
841 native_shared_libs: ["mylib", "mylib3"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000842 updatable: false,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900843 }
844
845 apex_key {
846 name: "myapex.key",
847 public_key: "testkey.avbpubkey",
848 private_key: "testkey.pem",
849 }
850
851 cc_library {
852 name: "mylib",
853 srcs: ["mylib.cpp"],
854 shared_libs: ["mylib2", "mylib3"],
855 system_shared_libs: [],
856 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000857 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900858 }
859
860 cc_library {
861 name: "mylib2",
862 srcs: ["mylib.cpp"],
Jiyong Park64379952018-12-13 18:37:29 +0900863 cflags: ["-include mylib.h"],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900864 system_shared_libs: [],
865 stl: "none",
866 stubs: {
867 versions: ["1", "2", "3"],
868 },
869 }
870
871 cc_library {
872 name: "mylib3",
Jiyong Park28d395a2018-12-07 22:42:47 +0900873 srcs: ["mylib.cpp"],
874 shared_libs: ["mylib4"],
875 system_shared_libs: [],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900876 stl: "none",
877 stubs: {
878 versions: ["10", "11", "12"],
879 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000880 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900881 }
Jiyong Park28d395a2018-12-07 22:42:47 +0900882
883 cc_library {
884 name: "mylib4",
885 srcs: ["mylib.cpp"],
886 system_shared_libs: [],
887 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000888 apex_available: [ "myapex" ],
Jiyong Park28d395a2018-12-07 22:42:47 +0900889 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900890 `)
891
Sundong Ahnabb64432019-10-22 13:58:29 +0900892 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900893 copyCmds := apexRule.Args["copy_commands"]
894
895 // Ensure that direct non-stubs dep is always included
Alex Light5098a612018-11-29 17:12:15 -0800896 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900897
898 // Ensure that indirect stubs dep is not included
Alex Light5098a612018-11-29 17:12:15 -0800899 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900900
901 // Ensure that direct stubs dep is included
Alex Light5098a612018-11-29 17:12:15 -0800902 ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900903
Colin Crossaede88c2020-08-11 12:17:01 -0700904 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +0900905
906 // Ensure that mylib is linking with the latest version of stubs for mylib2
Jiyong Parkd4a3a132021-03-17 20:21:35 +0900907 ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900908 // ... and not linking to the non-stub (impl) variant of mylib2
Jiyong Park3ff16992019-12-27 14:11:47 +0900909 ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900910
911 // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
Colin Crossaede88c2020-08-11 12:17:01 -0700912 ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex10000/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900913 // .. and not linking to the stubs variant of mylib3
Colin Crossaede88c2020-08-11 12:17:01 -0700914 ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_12/mylib3.so")
Jiyong Park64379952018-12-13 18:37:29 +0900915
916 // Ensure that stubs libs are built without -include flags
Jiyong Park0f80c182020-01-31 02:49:53 +0900917 mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jiyong Park64379952018-12-13 18:37:29 +0900918 ensureNotContains(t, mylib2Cflags, "-include ")
Jiyong Park3fd0baf2018-12-07 16:25:39 +0900919
920 // Ensure that genstub is invoked with --apex
Colin Crossa717db72020-10-23 14:53:06 -0700921 ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_3").Rule("genStubSrc").Args["flags"])
Jooyung Han671f1ce2019-12-17 12:47:13 +0900922
Jooyung Hana57af4a2020-01-23 05:36:59 +0000923 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Han671f1ce2019-12-17 12:47:13 +0900924 "lib64/mylib.so",
925 "lib64/mylib3.so",
926 "lib64/mylib4.so",
927 })
Jiyong Park25fc6a92018-11-18 18:02:45 +0900928}
929
Colin Cross7812fd32020-09-25 12:35:10 -0700930func TestApexWithStubsWithMinSdkVersion(t *testing.T) {
931 t.Parallel()
Colin Cross1c460562021-02-16 17:55:47 -0800932 ctx := testApex(t, `
Colin Cross7812fd32020-09-25 12:35:10 -0700933 apex {
934 name: "myapex",
935 key: "myapex.key",
936 native_shared_libs: ["mylib", "mylib3"],
937 min_sdk_version: "29",
938 }
939
940 apex_key {
941 name: "myapex.key",
942 public_key: "testkey.avbpubkey",
943 private_key: "testkey.pem",
944 }
945
946 cc_library {
947 name: "mylib",
948 srcs: ["mylib.cpp"],
949 shared_libs: ["mylib2", "mylib3"],
950 system_shared_libs: [],
951 stl: "none",
952 apex_available: [ "myapex" ],
953 min_sdk_version: "28",
954 }
955
956 cc_library {
957 name: "mylib2",
958 srcs: ["mylib.cpp"],
959 cflags: ["-include mylib.h"],
960 system_shared_libs: [],
961 stl: "none",
962 stubs: {
963 versions: ["28", "29", "30", "current"],
964 },
965 min_sdk_version: "28",
966 }
967
968 cc_library {
969 name: "mylib3",
970 srcs: ["mylib.cpp"],
971 shared_libs: ["mylib4"],
972 system_shared_libs: [],
973 stl: "none",
974 stubs: {
975 versions: ["28", "29", "30", "current"],
976 },
977 apex_available: [ "myapex" ],
978 min_sdk_version: "28",
979 }
980
981 cc_library {
982 name: "mylib4",
983 srcs: ["mylib.cpp"],
984 system_shared_libs: [],
985 stl: "none",
986 apex_available: [ "myapex" ],
987 min_sdk_version: "28",
988 }
989 `)
990
991 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
992 copyCmds := apexRule.Args["copy_commands"]
993
994 // Ensure that direct non-stubs dep is always included
995 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
996
997 // Ensure that indirect stubs dep is not included
998 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
999
1000 // Ensure that direct stubs dep is included
1001 ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
1002
1003 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex29").Rule("ld").Args["libFlags"]
1004
Jiyong Park55549df2021-02-26 23:57:23 +09001005 // Ensure that mylib is linking with the latest version of stub for mylib2
1006 ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
Colin Cross7812fd32020-09-25 12:35:10 -07001007 // ... and not linking to the non-stub (impl) variant of mylib2
1008 ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
1009
1010 // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
1011 ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex29/mylib3.so")
1012 // .. and not linking to the stubs variant of mylib3
1013 ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_29/mylib3.so")
1014
1015 // Ensure that stubs libs are built without -include flags
Colin Crossa717db72020-10-23 14:53:06 -07001016 mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("cc").Args["cFlags"]
Colin Cross7812fd32020-09-25 12:35:10 -07001017 ensureNotContains(t, mylib2Cflags, "-include ")
1018
1019 // Ensure that genstub is invoked with --apex
Colin Crossa717db72020-10-23 14:53:06 -07001020 ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("genStubSrc").Args["flags"])
Colin Cross7812fd32020-09-25 12:35:10 -07001021
1022 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
1023 "lib64/mylib.so",
1024 "lib64/mylib3.so",
1025 "lib64/mylib4.so",
1026 })
1027}
1028
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001029func TestApex_PlatformUsesLatestStubFromApex(t *testing.T) {
1030 t.Parallel()
1031 // myapex (Z)
1032 // mylib -----------------.
1033 // |
1034 // otherapex (29) |
1035 // libstub's versions: 29 Z current
1036 // |
1037 // <platform> |
1038 // libplatform ----------------'
Colin Cross1c460562021-02-16 17:55:47 -08001039 ctx := testApex(t, `
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001040 apex {
1041 name: "myapex",
1042 key: "myapex.key",
1043 native_shared_libs: ["mylib"],
1044 min_sdk_version: "Z", // non-final
1045 }
1046
1047 cc_library {
1048 name: "mylib",
1049 srcs: ["mylib.cpp"],
1050 shared_libs: ["libstub"],
1051 apex_available: ["myapex"],
1052 min_sdk_version: "Z",
1053 }
1054
1055 apex_key {
1056 name: "myapex.key",
1057 public_key: "testkey.avbpubkey",
1058 private_key: "testkey.pem",
1059 }
1060
1061 apex {
1062 name: "otherapex",
1063 key: "myapex.key",
1064 native_shared_libs: ["libstub"],
1065 min_sdk_version: "29",
1066 }
1067
1068 cc_library {
1069 name: "libstub",
1070 srcs: ["mylib.cpp"],
1071 stubs: {
1072 versions: ["29", "Z", "current"],
1073 },
1074 apex_available: ["otherapex"],
1075 min_sdk_version: "29",
1076 }
1077
1078 // platform module depending on libstub from otherapex should use the latest stub("current")
1079 cc_library {
1080 name: "libplatform",
1081 srcs: ["mylib.cpp"],
1082 shared_libs: ["libstub"],
1083 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001084 `,
1085 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1086 variables.Platform_sdk_codename = proptools.StringPtr("Z")
1087 variables.Platform_sdk_final = proptools.BoolPtr(false)
1088 variables.Platform_version_active_codenames = []string{"Z"}
1089 }),
1090 )
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001091
Jiyong Park55549df2021-02-26 23:57:23 +09001092 // Ensure that mylib from myapex is built against the latest stub (current)
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001093 mylibCflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
Jiyong Park55549df2021-02-26 23:57:23 +09001094 ensureContains(t, mylibCflags, "-D__LIBSTUB_API__=10000 ")
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001095 mylibLdflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
Jiyong Park55549df2021-02-26 23:57:23 +09001096 ensureContains(t, mylibLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001097
1098 // Ensure that libplatform is built against latest stub ("current") of mylib3 from the apex
1099 libplatformCflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
1100 ensureContains(t, libplatformCflags, "-D__LIBSTUB_API__=10000 ") // "current" maps to 10000
1101 libplatformLdflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
1102 ensureContains(t, libplatformLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
1103}
1104
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001105func TestApexWithExplicitStubsDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001106 ctx := testApex(t, `
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001107 apex {
Jiyong Park83dc74b2020-01-14 18:38:44 +09001108 name: "myapex2",
1109 key: "myapex2.key",
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001110 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001111 updatable: false,
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001112 }
1113
1114 apex_key {
Jiyong Park83dc74b2020-01-14 18:38:44 +09001115 name: "myapex2.key",
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001116 public_key: "testkey.avbpubkey",
1117 private_key: "testkey.pem",
1118 }
1119
1120 cc_library {
1121 name: "mylib",
1122 srcs: ["mylib.cpp"],
1123 shared_libs: ["libfoo#10"],
Jiyong Park678c8812020-02-07 17:25:49 +09001124 static_libs: ["libbaz"],
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001125 system_shared_libs: [],
1126 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001127 apex_available: [ "myapex2" ],
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001128 }
1129
1130 cc_library {
1131 name: "libfoo",
1132 srcs: ["mylib.cpp"],
1133 shared_libs: ["libbar"],
1134 system_shared_libs: [],
1135 stl: "none",
1136 stubs: {
1137 versions: ["10", "20", "30"],
1138 },
1139 }
1140
1141 cc_library {
1142 name: "libbar",
1143 srcs: ["mylib.cpp"],
1144 system_shared_libs: [],
1145 stl: "none",
1146 }
1147
Jiyong Park678c8812020-02-07 17:25:49 +09001148 cc_library_static {
1149 name: "libbaz",
1150 srcs: ["mylib.cpp"],
1151 system_shared_libs: [],
1152 stl: "none",
1153 apex_available: [ "myapex2" ],
1154 }
1155
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001156 `)
1157
Jiyong Park83dc74b2020-01-14 18:38:44 +09001158 apexRule := ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Rule("apexRule")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001159 copyCmds := apexRule.Args["copy_commands"]
1160
1161 // Ensure that direct non-stubs dep is always included
1162 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
1163
1164 // Ensure that indirect stubs dep is not included
1165 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
1166
1167 // Ensure that dependency of stubs is not included
1168 ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so")
1169
Colin Crossaede88c2020-08-11 12:17:01 -07001170 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001171
1172 // Ensure that mylib is linking with version 10 of libfoo
Jiyong Park3ff16992019-12-27 14:11:47 +09001173 ensureContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared_10/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001174 // ... and not linking to the non-stub (impl) variant of libfoo
Jiyong Park3ff16992019-12-27 14:11:47 +09001175 ensureNotContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001176
Jiyong Park3ff16992019-12-27 14:11:47 +09001177 libFooStubsLdFlags := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_10").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001178
1179 // Ensure that libfoo stubs is not linking to libbar (since it is a stubs)
1180 ensureNotContains(t, libFooStubsLdFlags, "libbar.so")
Jiyong Park83dc74b2020-01-14 18:38:44 +09001181
Artur Satayeva8bd1132020-04-27 18:07:06 +01001182 fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +01001183 ensureListContains(t, fullDepsInfo, " libfoo(minSdkVersion:(no version)) (external) <- mylib")
Jiyong Park678c8812020-02-07 17:25:49 +09001184
Artur Satayeva8bd1132020-04-27 18:07:06 +01001185 flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +01001186 ensureListContains(t, flatDepsInfo, "libfoo(minSdkVersion:(no version)) (external)")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001187}
1188
Jooyung Hand3639552019-08-09 12:57:43 +09001189func TestApexWithRuntimeLibsDependency(t *testing.T) {
1190 /*
1191 myapex
1192 |
1193 v (runtime_libs)
1194 mylib ------+------> libfoo [provides stub]
1195 |
1196 `------> libbar
1197 */
Colin Cross1c460562021-02-16 17:55:47 -08001198 ctx := testApex(t, `
Jooyung Hand3639552019-08-09 12:57:43 +09001199 apex {
1200 name: "myapex",
1201 key: "myapex.key",
1202 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001203 updatable: false,
Jooyung Hand3639552019-08-09 12:57:43 +09001204 }
1205
1206 apex_key {
1207 name: "myapex.key",
1208 public_key: "testkey.avbpubkey",
1209 private_key: "testkey.pem",
1210 }
1211
1212 cc_library {
1213 name: "mylib",
1214 srcs: ["mylib.cpp"],
1215 runtime_libs: ["libfoo", "libbar"],
1216 system_shared_libs: [],
1217 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001218 apex_available: [ "myapex" ],
Jooyung Hand3639552019-08-09 12:57:43 +09001219 }
1220
1221 cc_library {
1222 name: "libfoo",
1223 srcs: ["mylib.cpp"],
1224 system_shared_libs: [],
1225 stl: "none",
1226 stubs: {
1227 versions: ["10", "20", "30"],
1228 },
1229 }
1230
1231 cc_library {
1232 name: "libbar",
1233 srcs: ["mylib.cpp"],
1234 system_shared_libs: [],
1235 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001236 apex_available: [ "myapex" ],
Jooyung Hand3639552019-08-09 12:57:43 +09001237 }
1238
1239 `)
1240
Sundong Ahnabb64432019-10-22 13:58:29 +09001241 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jooyung Hand3639552019-08-09 12:57:43 +09001242 copyCmds := apexRule.Args["copy_commands"]
1243
1244 // Ensure that direct non-stubs dep is always included
1245 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
1246
1247 // Ensure that indirect stubs dep is not included
1248 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
1249
1250 // Ensure that runtime_libs dep in included
1251 ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
1252
Sundong Ahnabb64432019-10-22 13:58:29 +09001253 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001254 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
1255 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.so")
Jooyung Hand3639552019-08-09 12:57:43 +09001256
1257}
1258
Paul Duffina02cae32021-03-09 01:44:06 +00001259var prepareForTestOfRuntimeApexWithHwasan = android.GroupFixturePreparers(
1260 cc.PrepareForTestWithCcBuildComponents,
1261 PrepareForTestWithApexBuildComponents,
1262 android.FixtureAddTextFile("bionic/apex/Android.bp", `
Jooyung Han8ce8db92020-05-15 19:05:05 +09001263 apex {
1264 name: "com.android.runtime",
1265 key: "com.android.runtime.key",
1266 native_shared_libs: ["libc"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001267 updatable: false,
Jooyung Han8ce8db92020-05-15 19:05:05 +09001268 }
1269
1270 apex_key {
1271 name: "com.android.runtime.key",
1272 public_key: "testkey.avbpubkey",
1273 private_key: "testkey.pem",
1274 }
Paul Duffina02cae32021-03-09 01:44:06 +00001275 `),
1276 android.FixtureAddFile("system/sepolicy/apex/com.android.runtime-file_contexts", nil),
1277)
Jooyung Han8ce8db92020-05-15 19:05:05 +09001278
Paul Duffina02cae32021-03-09 01:44:06 +00001279func TestRuntimeApexShouldInstallHwasanIfLibcDependsOnIt(t *testing.T) {
Paul Duffin70d3bee2021-03-21 11:26:05 +00001280 result := android.GroupFixturePreparers(prepareForTestOfRuntimeApexWithHwasan).RunTestWithBp(t, `
Jooyung Han8ce8db92020-05-15 19:05:05 +09001281 cc_library {
1282 name: "libc",
1283 no_libcrt: true,
1284 nocrt: true,
1285 stl: "none",
1286 system_shared_libs: [],
1287 stubs: { versions: ["1"] },
1288 apex_available: ["com.android.runtime"],
1289
1290 sanitize: {
1291 hwaddress: true,
1292 }
1293 }
1294
1295 cc_prebuilt_library_shared {
1296 name: "libclang_rt.hwasan-aarch64-android",
1297 no_libcrt: true,
1298 nocrt: true,
1299 stl: "none",
1300 system_shared_libs: [],
1301 srcs: [""],
1302 stubs: { versions: ["1"] },
1303
1304 sanitize: {
1305 never: true,
1306 },
Paul Duffina02cae32021-03-09 01:44:06 +00001307 } `)
1308 ctx := result.TestContext
Jooyung Han8ce8db92020-05-15 19:05:05 +09001309
1310 ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
1311 "lib64/bionic/libc.so",
1312 "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
1313 })
1314
1315 hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared")
1316
1317 installed := hwasan.Description("install libclang_rt.hwasan")
1318 ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
1319
1320 symlink := hwasan.Description("install symlink libclang_rt.hwasan")
1321 ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
1322 ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
1323}
1324
1325func TestRuntimeApexShouldInstallHwasanIfHwaddressSanitized(t *testing.T) {
Paul Duffin70d3bee2021-03-21 11:26:05 +00001326 result := android.GroupFixturePreparers(
Paul Duffina02cae32021-03-09 01:44:06 +00001327 prepareForTestOfRuntimeApexWithHwasan,
1328 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1329 variables.SanitizeDevice = []string{"hwaddress"}
1330 }),
1331 ).RunTestWithBp(t, `
Jooyung Han8ce8db92020-05-15 19:05:05 +09001332 cc_library {
1333 name: "libc",
1334 no_libcrt: true,
1335 nocrt: true,
1336 stl: "none",
1337 system_shared_libs: [],
1338 stubs: { versions: ["1"] },
1339 apex_available: ["com.android.runtime"],
1340 }
1341
1342 cc_prebuilt_library_shared {
1343 name: "libclang_rt.hwasan-aarch64-android",
1344 no_libcrt: true,
1345 nocrt: true,
1346 stl: "none",
1347 system_shared_libs: [],
1348 srcs: [""],
1349 stubs: { versions: ["1"] },
1350
1351 sanitize: {
1352 never: true,
1353 },
1354 }
Paul Duffina02cae32021-03-09 01:44:06 +00001355 `)
1356 ctx := result.TestContext
Jooyung Han8ce8db92020-05-15 19:05:05 +09001357
1358 ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
1359 "lib64/bionic/libc.so",
1360 "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
1361 })
1362
1363 hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared")
1364
1365 installed := hwasan.Description("install libclang_rt.hwasan")
1366 ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
1367
1368 symlink := hwasan.Description("install symlink libclang_rt.hwasan")
1369 ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
1370 ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
1371}
1372
Jooyung Han61b66e92020-03-21 14:21:46 +00001373func TestApexDependsOnLLNDKTransitively(t *testing.T) {
1374 testcases := []struct {
1375 name string
1376 minSdkVersion string
Colin Crossaede88c2020-08-11 12:17:01 -07001377 apexVariant string
Jooyung Han61b66e92020-03-21 14:21:46 +00001378 shouldLink string
1379 shouldNotLink []string
1380 }{
1381 {
Jiyong Park55549df2021-02-26 23:57:23 +09001382 name: "unspecified version links to the latest",
Jooyung Han749dc692020-04-15 11:03:39 +09001383 minSdkVersion: "",
Colin Crossaede88c2020-08-11 12:17:01 -07001384 apexVariant: "apex10000",
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001385 shouldLink: "current",
1386 shouldNotLink: []string{"29", "30"},
Jooyung Han61b66e92020-03-21 14:21:46 +00001387 },
1388 {
Jiyong Park55549df2021-02-26 23:57:23 +09001389 name: "always use the latest",
Jooyung Han749dc692020-04-15 11:03:39 +09001390 minSdkVersion: "min_sdk_version: \"29\",",
Colin Crossaede88c2020-08-11 12:17:01 -07001391 apexVariant: "apex29",
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001392 shouldLink: "current",
1393 shouldNotLink: []string{"29", "30"},
Jooyung Han61b66e92020-03-21 14:21:46 +00001394 },
1395 }
1396 for _, tc := range testcases {
1397 t.Run(tc.name, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001398 ctx := testApex(t, `
Jooyung Han61b66e92020-03-21 14:21:46 +00001399 apex {
1400 name: "myapex",
1401 key: "myapex.key",
1402 use_vendor: true,
1403 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001404 updatable: false,
Jooyung Han749dc692020-04-15 11:03:39 +09001405 `+tc.minSdkVersion+`
Jooyung Han61b66e92020-03-21 14:21:46 +00001406 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001407
Jooyung Han61b66e92020-03-21 14:21:46 +00001408 apex_key {
1409 name: "myapex.key",
1410 public_key: "testkey.avbpubkey",
1411 private_key: "testkey.pem",
1412 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001413
Jooyung Han61b66e92020-03-21 14:21:46 +00001414 cc_library {
1415 name: "mylib",
1416 srcs: ["mylib.cpp"],
1417 vendor_available: true,
1418 shared_libs: ["libbar"],
1419 system_shared_libs: [],
1420 stl: "none",
1421 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001422 min_sdk_version: "29",
Jooyung Han61b66e92020-03-21 14:21:46 +00001423 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001424
Jooyung Han61b66e92020-03-21 14:21:46 +00001425 cc_library {
1426 name: "libbar",
1427 srcs: ["mylib.cpp"],
1428 system_shared_libs: [],
1429 stl: "none",
1430 stubs: { versions: ["29","30"] },
Colin Cross203b4212021-04-26 17:19:41 -07001431 llndk: {
1432 symbol_file: "libbar.map.txt",
1433 }
Jooyung Han61b66e92020-03-21 14:21:46 +00001434 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001435 `,
1436 setUseVendorAllowListForTest([]string{"myapex"}),
1437 withUnbundledBuild,
1438 )
Jooyung Han9c80bae2019-08-20 17:30:57 +09001439
Jooyung Han61b66e92020-03-21 14:21:46 +00001440 // Ensure that LLNDK dep is not included
1441 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
1442 "lib64/mylib.so",
1443 })
Jooyung Han9c80bae2019-08-20 17:30:57 +09001444
Jooyung Han61b66e92020-03-21 14:21:46 +00001445 // Ensure that LLNDK dep is required
1446 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
1447 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
1448 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libbar.so")
Jooyung Han9c80bae2019-08-20 17:30:57 +09001449
Jiyong Parkf58c46e2021-04-01 21:35:20 +09001450 mylibLdFlags := ctx.ModuleForTests("mylib", "android_vendor.29_arm64_armv8-a_shared_"+tc.apexVariant).Rule("ld").Args["libFlags"]
1451 ensureContains(t, mylibLdFlags, "libbar/android_vendor.29_arm64_armv8-a_shared_"+tc.shouldLink+"/libbar.so")
Jooyung Han61b66e92020-03-21 14:21:46 +00001452 for _, ver := range tc.shouldNotLink {
Jiyong Parkf58c46e2021-04-01 21:35:20 +09001453 ensureNotContains(t, mylibLdFlags, "libbar/android_vendor.29_arm64_armv8-a_shared_"+ver+"/libbar.so")
Jooyung Han61b66e92020-03-21 14:21:46 +00001454 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001455
Jiyong Parkf58c46e2021-04-01 21:35:20 +09001456 mylibCFlags := ctx.ModuleForTests("mylib", "android_vendor.29_arm64_armv8-a_static_"+tc.apexVariant).Rule("cc").Args["cFlags"]
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001457 ver := tc.shouldLink
1458 if tc.shouldLink == "current" {
1459 ver = strconv.Itoa(android.FutureApiLevelInt)
1460 }
1461 ensureContains(t, mylibCFlags, "__LIBBAR_API__="+ver)
Jooyung Han61b66e92020-03-21 14:21:46 +00001462 })
1463 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001464}
1465
Jiyong Park25fc6a92018-11-18 18:02:45 +09001466func TestApexWithSystemLibsStubs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001467 ctx := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +09001468 apex {
1469 name: "myapex",
1470 key: "myapex.key",
1471 native_shared_libs: ["mylib", "mylib_shared", "libdl", "libm"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001472 updatable: false,
Jiyong Park25fc6a92018-11-18 18:02:45 +09001473 }
1474
1475 apex_key {
1476 name: "myapex.key",
1477 public_key: "testkey.avbpubkey",
1478 private_key: "testkey.pem",
1479 }
1480
1481 cc_library {
1482 name: "mylib",
1483 srcs: ["mylib.cpp"],
Colin Cross0de8a1e2020-09-18 14:15:30 -07001484 system_shared_libs: ["libc", "libm"],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001485 shared_libs: ["libdl#27"],
1486 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001487 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001488 }
1489
1490 cc_library_shared {
1491 name: "mylib_shared",
1492 srcs: ["mylib.cpp"],
1493 shared_libs: ["libdl#27"],
1494 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001495 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001496 }
1497
1498 cc_library {
Jiyong Parkb0788572018-12-20 22:10:17 +09001499 name: "libBootstrap",
1500 srcs: ["mylib.cpp"],
1501 stl: "none",
1502 bootstrap: true,
1503 }
Jiyong Park25fc6a92018-11-18 18:02:45 +09001504 `)
1505
Sundong Ahnabb64432019-10-22 13:58:29 +09001506 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001507 copyCmds := apexRule.Args["copy_commands"]
1508
1509 // Ensure that mylib, libm, libdl are included.
Alex Light5098a612018-11-29 17:12:15 -08001510 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Parkb0788572018-12-20 22:10:17 +09001511 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libm.so")
1512 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001513
1514 // Ensure that libc is not included (since it has stubs and not listed in native_shared_libs)
Jiyong Parkb0788572018-12-20 22:10:17 +09001515 ensureNotContains(t, copyCmds, "image.apex/lib64/bionic/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001516
Colin Crossaede88c2020-08-11 12:17:01 -07001517 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
1518 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
1519 mylibSharedCFlags := ctx.ModuleForTests("mylib_shared", "android_arm64_armv8-a_shared_apex10000").Rule("cc").Args["cFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +09001520
1521 // For dependency to libc
1522 // Ensure that mylib is linking with the latest version of stubs
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001523 ensureContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared_current/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001524 // ... and not linking to the non-stub (impl) variant
Jiyong Park3ff16992019-12-27 14:11:47 +09001525 ensureNotContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001526 // ... Cflags from stub is correctly exported to mylib
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001527 ensureContains(t, mylibCFlags, "__LIBC_API__=10000")
1528 ensureContains(t, mylibSharedCFlags, "__LIBC_API__=10000")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001529
1530 // For dependency to libm
1531 // Ensure that mylib is linking with the non-stub (impl) variant
Colin Crossaede88c2020-08-11 12:17:01 -07001532 ensureContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_apex10000/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001533 // ... and not linking to the stub variant
Jiyong Park3ff16992019-12-27 14:11:47 +09001534 ensureNotContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_29/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001535 // ... and is not compiling with the stub
1536 ensureNotContains(t, mylibCFlags, "__LIBM_API__=29")
1537 ensureNotContains(t, mylibSharedCFlags, "__LIBM_API__=29")
1538
1539 // For dependency to libdl
1540 // Ensure that mylib is linking with the specified version of stubs
Jiyong Park3ff16992019-12-27 14:11:47 +09001541 ensureContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_27/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001542 // ... and not linking to the other versions of stubs
Jiyong Park3ff16992019-12-27 14:11:47 +09001543 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_28/libdl.so")
1544 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_29/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001545 // ... and not linking to the non-stub (impl) variant
Colin Crossaede88c2020-08-11 12:17:01 -07001546 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_apex10000/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001547 // ... Cflags from stub is correctly exported to mylib
1548 ensureContains(t, mylibCFlags, "__LIBDL_API__=27")
1549 ensureContains(t, mylibSharedCFlags, "__LIBDL_API__=27")
Jiyong Parkb0788572018-12-20 22:10:17 +09001550
1551 // Ensure that libBootstrap is depending on the platform variant of bionic libs
Colin Cross7113d202019-11-20 16:39:12 -08001552 libFlags := ctx.ModuleForTests("libBootstrap", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
1553 ensureContains(t, libFlags, "libc/android_arm64_armv8-a_shared/libc.so")
1554 ensureContains(t, libFlags, "libm/android_arm64_armv8-a_shared/libm.so")
1555 ensureContains(t, libFlags, "libdl/android_arm64_armv8-a_shared/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001556}
Jiyong Park7c2ee712018-12-07 00:42:25 +09001557
Jooyung Han749dc692020-04-15 11:03:39 +09001558func TestApexMinSdkVersion_NativeModulesShouldBeBuiltAgainstStubs(t *testing.T) {
Jiyong Park55549df2021-02-26 23:57:23 +09001559 // there are three links between liba --> libz.
1560 // 1) myapex -> libx -> liba -> libz : this should be #30 link
Jooyung Han749dc692020-04-15 11:03:39 +09001561 // 2) otherapex -> liby -> liba -> libz : this should be #30 link
Jooyung Han03b51852020-02-26 22:45:42 +09001562 // 3) (platform) -> liba -> libz : this should be non-stub link
Colin Cross1c460562021-02-16 17:55:47 -08001563 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001564 apex {
1565 name: "myapex",
1566 key: "myapex.key",
1567 native_shared_libs: ["libx"],
Jooyung Han749dc692020-04-15 11:03:39 +09001568 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001569 }
1570
1571 apex {
1572 name: "otherapex",
1573 key: "myapex.key",
1574 native_shared_libs: ["liby"],
Jooyung Han749dc692020-04-15 11:03:39 +09001575 min_sdk_version: "30",
Jooyung Han03b51852020-02-26 22:45:42 +09001576 }
1577
1578 apex_key {
1579 name: "myapex.key",
1580 public_key: "testkey.avbpubkey",
1581 private_key: "testkey.pem",
1582 }
1583
1584 cc_library {
1585 name: "libx",
1586 shared_libs: ["liba"],
1587 system_shared_libs: [],
1588 stl: "none",
1589 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001590 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001591 }
1592
1593 cc_library {
1594 name: "liby",
1595 shared_libs: ["liba"],
1596 system_shared_libs: [],
1597 stl: "none",
1598 apex_available: [ "otherapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001599 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001600 }
1601
1602 cc_library {
1603 name: "liba",
1604 shared_libs: ["libz"],
1605 system_shared_libs: [],
1606 stl: "none",
1607 apex_available: [
1608 "//apex_available:anyapex",
1609 "//apex_available:platform",
1610 ],
Jooyung Han749dc692020-04-15 11:03:39 +09001611 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001612 }
1613
1614 cc_library {
1615 name: "libz",
1616 system_shared_libs: [],
1617 stl: "none",
1618 stubs: {
Jooyung Han749dc692020-04-15 11:03:39 +09001619 versions: ["28", "30"],
Jooyung Han03b51852020-02-26 22:45:42 +09001620 },
1621 }
Jooyung Han749dc692020-04-15 11:03:39 +09001622 `)
Jooyung Han03b51852020-02-26 22:45:42 +09001623
1624 expectLink := func(from, from_variant, to, to_variant string) {
1625 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1626 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1627 }
1628 expectNoLink := func(from, from_variant, to, to_variant string) {
1629 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1630 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1631 }
1632 // platform liba is linked to non-stub version
1633 expectLink("liba", "shared", "libz", "shared")
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001634 // liba in myapex is linked to current
1635 expectLink("liba", "shared_apex29", "libz", "shared_current")
1636 expectNoLink("liba", "shared_apex29", "libz", "shared_30")
Jiyong Park55549df2021-02-26 23:57:23 +09001637 expectNoLink("liba", "shared_apex29", "libz", "shared_28")
Colin Crossaede88c2020-08-11 12:17:01 -07001638 expectNoLink("liba", "shared_apex29", "libz", "shared")
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001639 // liba in otherapex is linked to current
1640 expectLink("liba", "shared_apex30", "libz", "shared_current")
1641 expectNoLink("liba", "shared_apex30", "libz", "shared_30")
Colin Crossaede88c2020-08-11 12:17:01 -07001642 expectNoLink("liba", "shared_apex30", "libz", "shared_28")
1643 expectNoLink("liba", "shared_apex30", "libz", "shared")
Jooyung Han03b51852020-02-26 22:45:42 +09001644}
1645
Jooyung Hanaed150d2020-04-02 01:41:41 +09001646func TestApexMinSdkVersion_SupportsCodeNames(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001647 ctx := testApex(t, `
Jooyung Hanaed150d2020-04-02 01:41:41 +09001648 apex {
1649 name: "myapex",
1650 key: "myapex.key",
1651 native_shared_libs: ["libx"],
1652 min_sdk_version: "R",
1653 }
1654
1655 apex_key {
1656 name: "myapex.key",
1657 public_key: "testkey.avbpubkey",
1658 private_key: "testkey.pem",
1659 }
1660
1661 cc_library {
1662 name: "libx",
1663 shared_libs: ["libz"],
1664 system_shared_libs: [],
1665 stl: "none",
1666 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001667 min_sdk_version: "R",
Jooyung Hanaed150d2020-04-02 01:41:41 +09001668 }
1669
1670 cc_library {
1671 name: "libz",
1672 system_shared_libs: [],
1673 stl: "none",
1674 stubs: {
1675 versions: ["29", "R"],
1676 },
1677 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001678 `,
1679 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1680 variables.Platform_version_active_codenames = []string{"R"}
1681 }),
1682 )
Jooyung Hanaed150d2020-04-02 01:41:41 +09001683
1684 expectLink := func(from, from_variant, to, to_variant string) {
1685 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1686 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1687 }
1688 expectNoLink := func(from, from_variant, to, to_variant string) {
1689 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1690 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1691 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001692 expectLink("libx", "shared_apex10000", "libz", "shared_current")
1693 expectNoLink("libx", "shared_apex10000", "libz", "shared_R")
Colin Crossaede88c2020-08-11 12:17:01 -07001694 expectNoLink("libx", "shared_apex10000", "libz", "shared_29")
1695 expectNoLink("libx", "shared_apex10000", "libz", "shared")
Jooyung Hanaed150d2020-04-02 01:41:41 +09001696}
1697
Jooyung Han749dc692020-04-15 11:03:39 +09001698func TestApexMinSdkVersion_DefaultsToLatest(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001699 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001700 apex {
1701 name: "myapex",
1702 key: "myapex.key",
1703 native_shared_libs: ["libx"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001704 updatable: false,
Jooyung Han03b51852020-02-26 22:45:42 +09001705 }
1706
1707 apex_key {
1708 name: "myapex.key",
1709 public_key: "testkey.avbpubkey",
1710 private_key: "testkey.pem",
1711 }
1712
1713 cc_library {
1714 name: "libx",
1715 shared_libs: ["libz"],
1716 system_shared_libs: [],
1717 stl: "none",
1718 apex_available: [ "myapex" ],
1719 }
1720
1721 cc_library {
1722 name: "libz",
1723 system_shared_libs: [],
1724 stl: "none",
1725 stubs: {
1726 versions: ["1", "2"],
1727 },
1728 }
1729 `)
1730
1731 expectLink := func(from, from_variant, to, to_variant string) {
1732 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1733 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1734 }
1735 expectNoLink := func(from, from_variant, to, to_variant string) {
1736 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1737 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1738 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001739 expectLink("libx", "shared_apex10000", "libz", "shared_current")
Colin Crossaede88c2020-08-11 12:17:01 -07001740 expectNoLink("libx", "shared_apex10000", "libz", "shared_1")
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001741 expectNoLink("libx", "shared_apex10000", "libz", "shared_2")
Colin Crossaede88c2020-08-11 12:17:01 -07001742 expectNoLink("libx", "shared_apex10000", "libz", "shared")
Jooyung Han03b51852020-02-26 22:45:42 +09001743}
1744
1745func TestPlatformUsesLatestStubsFromApexes(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001746 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001747 apex {
1748 name: "myapex",
1749 key: "myapex.key",
1750 native_shared_libs: ["libx"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001751 updatable: false,
Jooyung Han03b51852020-02-26 22:45:42 +09001752 }
1753
1754 apex_key {
1755 name: "myapex.key",
1756 public_key: "testkey.avbpubkey",
1757 private_key: "testkey.pem",
1758 }
1759
1760 cc_library {
1761 name: "libx",
1762 system_shared_libs: [],
1763 stl: "none",
1764 apex_available: [ "myapex" ],
1765 stubs: {
1766 versions: ["1", "2"],
1767 },
1768 }
1769
1770 cc_library {
1771 name: "libz",
1772 shared_libs: ["libx"],
1773 system_shared_libs: [],
1774 stl: "none",
1775 }
1776 `)
1777
1778 expectLink := func(from, from_variant, to, to_variant string) {
Colin Cross56a83212020-09-15 18:30:11 -07001779 t.Helper()
Jooyung Han03b51852020-02-26 22:45:42 +09001780 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1781 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1782 }
1783 expectNoLink := func(from, from_variant, to, to_variant string) {
Colin Cross56a83212020-09-15 18:30:11 -07001784 t.Helper()
Jooyung Han03b51852020-02-26 22:45:42 +09001785 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1786 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1787 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001788 expectLink("libz", "shared", "libx", "shared_current")
1789 expectNoLink("libz", "shared", "libx", "shared_2")
Jooyung Han03b51852020-02-26 22:45:42 +09001790 expectNoLink("libz", "shared", "libz", "shared_1")
1791 expectNoLink("libz", "shared", "libz", "shared")
1792}
1793
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001794var prepareForTestWithSantitizeHwaddress = android.FixtureModifyProductVariables(
1795 func(variables android.FixtureProductVariables) {
1796 variables.SanitizeDevice = []string{"hwaddress"}
1797 },
1798)
1799
Jooyung Han75568392020-03-20 04:29:24 +09001800func TestQApexesUseLatestStubsInBundledBuildsAndHWASAN(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001801 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001802 apex {
1803 name: "myapex",
1804 key: "myapex.key",
1805 native_shared_libs: ["libx"],
1806 min_sdk_version: "29",
1807 }
1808
1809 apex_key {
1810 name: "myapex.key",
1811 public_key: "testkey.avbpubkey",
1812 private_key: "testkey.pem",
1813 }
1814
1815 cc_library {
1816 name: "libx",
1817 shared_libs: ["libbar"],
1818 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001819 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001820 }
1821
1822 cc_library {
1823 name: "libbar",
1824 stubs: {
1825 versions: ["29", "30"],
1826 },
1827 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001828 `,
1829 prepareForTestWithSantitizeHwaddress,
1830 )
Jooyung Han03b51852020-02-26 22:45:42 +09001831 expectLink := func(from, from_variant, to, to_variant string) {
1832 ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
1833 libFlags := ld.Args["libFlags"]
1834 ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1835 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001836 expectLink("libx", "shared_hwasan_apex29", "libbar", "shared_current")
Jooyung Han03b51852020-02-26 22:45:42 +09001837}
1838
Jooyung Han75568392020-03-20 04:29:24 +09001839func TestQTargetApexUsesStaticUnwinder(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001840 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001841 apex {
1842 name: "myapex",
1843 key: "myapex.key",
1844 native_shared_libs: ["libx"],
1845 min_sdk_version: "29",
1846 }
1847
1848 apex_key {
1849 name: "myapex.key",
1850 public_key: "testkey.avbpubkey",
1851 private_key: "testkey.pem",
1852 }
1853
1854 cc_library {
1855 name: "libx",
1856 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001857 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001858 }
Jooyung Han75568392020-03-20 04:29:24 +09001859 `)
Jooyung Han03b51852020-02-26 22:45:42 +09001860
1861 // ensure apex variant of c++ is linked with static unwinder
Colin Crossaede88c2020-08-11 12:17:01 -07001862 cm := ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared_apex29").Module().(*cc.Module)
Ryan Prichardb35a85e2021-01-13 19:18:53 -08001863 ensureListContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
Jooyung Han03b51852020-02-26 22:45:42 +09001864 // note that platform variant is not.
1865 cm = ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared").Module().(*cc.Module)
Ryan Prichardb35a85e2021-01-13 19:18:53 -08001866 ensureListNotContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
Jooyung Han03b51852020-02-26 22:45:42 +09001867}
1868
Jooyung Han749dc692020-04-15 11:03:39 +09001869func TestApexMinSdkVersion_ErrorIfIncompatibleVersion(t *testing.T) {
1870 testApexError(t, `module "mylib".*: should support min_sdk_version\(29\)`, `
Jooyung Han03b51852020-02-26 22:45:42 +09001871 apex {
1872 name: "myapex",
1873 key: "myapex.key",
Jooyung Han749dc692020-04-15 11:03:39 +09001874 native_shared_libs: ["mylib"],
1875 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001876 }
1877
1878 apex_key {
1879 name: "myapex.key",
1880 public_key: "testkey.avbpubkey",
1881 private_key: "testkey.pem",
1882 }
Jooyung Han749dc692020-04-15 11:03:39 +09001883
1884 cc_library {
1885 name: "mylib",
1886 srcs: ["mylib.cpp"],
1887 system_shared_libs: [],
1888 stl: "none",
1889 apex_available: [
1890 "myapex",
1891 ],
1892 min_sdk_version: "30",
1893 }
1894 `)
Ivan Lozano3e9f9e42020-12-04 15:05:43 -05001895
1896 testApexError(t, `module "libfoo.ffi".*: should support min_sdk_version\(29\)`, `
1897 apex {
1898 name: "myapex",
1899 key: "myapex.key",
1900 native_shared_libs: ["libfoo.ffi"],
1901 min_sdk_version: "29",
1902 }
1903
1904 apex_key {
1905 name: "myapex.key",
1906 public_key: "testkey.avbpubkey",
1907 private_key: "testkey.pem",
1908 }
1909
1910 rust_ffi_shared {
1911 name: "libfoo.ffi",
1912 srcs: ["foo.rs"],
1913 crate_name: "foo",
1914 apex_available: [
1915 "myapex",
1916 ],
1917 min_sdk_version: "30",
1918 }
1919 `)
Jaewoong Jung56e12db2021-04-02 00:38:25 +00001920
1921 testApexError(t, `module "libfoo".*: should support min_sdk_version\(29\)`, `
1922 apex {
1923 name: "myapex",
1924 key: "myapex.key",
1925 java_libs: ["libfoo"],
1926 min_sdk_version: "29",
1927 }
1928
1929 apex_key {
1930 name: "myapex.key",
1931 public_key: "testkey.avbpubkey",
1932 private_key: "testkey.pem",
1933 }
1934
1935 java_import {
1936 name: "libfoo",
1937 jars: ["libfoo.jar"],
1938 apex_available: [
1939 "myapex",
1940 ],
1941 min_sdk_version: "30",
1942 }
1943 `)
Jooyung Han749dc692020-04-15 11:03:39 +09001944}
1945
1946func TestApexMinSdkVersion_Okay(t *testing.T) {
1947 testApex(t, `
1948 apex {
1949 name: "myapex",
1950 key: "myapex.key",
1951 native_shared_libs: ["libfoo"],
1952 java_libs: ["libbar"],
1953 min_sdk_version: "29",
1954 }
1955
1956 apex_key {
1957 name: "myapex.key",
1958 public_key: "testkey.avbpubkey",
1959 private_key: "testkey.pem",
1960 }
1961
1962 cc_library {
1963 name: "libfoo",
1964 srcs: ["mylib.cpp"],
1965 shared_libs: ["libfoo_dep"],
1966 apex_available: ["myapex"],
1967 min_sdk_version: "29",
1968 }
1969
1970 cc_library {
1971 name: "libfoo_dep",
1972 srcs: ["mylib.cpp"],
1973 apex_available: ["myapex"],
1974 min_sdk_version: "29",
1975 }
1976
1977 java_library {
1978 name: "libbar",
1979 sdk_version: "current",
1980 srcs: ["a.java"],
Jaewoong Jung56e12db2021-04-02 00:38:25 +00001981 static_libs: [
1982 "libbar_dep",
1983 "libbar_import_dep",
1984 ],
Jooyung Han749dc692020-04-15 11:03:39 +09001985 apex_available: ["myapex"],
1986 min_sdk_version: "29",
1987 }
1988
1989 java_library {
1990 name: "libbar_dep",
1991 sdk_version: "current",
1992 srcs: ["a.java"],
1993 apex_available: ["myapex"],
1994 min_sdk_version: "29",
1995 }
Jaewoong Jung56e12db2021-04-02 00:38:25 +00001996
1997 java_import {
1998 name: "libbar_import_dep",
1999 jars: ["libbar.jar"],
2000 apex_available: ["myapex"],
2001 min_sdk_version: "29",
2002 }
Jooyung Han03b51852020-02-26 22:45:42 +09002003 `)
2004}
2005
Artur Satayev8cf899a2020-04-15 17:29:42 +01002006func TestJavaStableSdkVersion(t *testing.T) {
2007 testCases := []struct {
2008 name string
2009 expectedError string
2010 bp string
2011 }{
2012 {
2013 name: "Non-updatable apex with non-stable dep",
2014 bp: `
2015 apex {
2016 name: "myapex",
2017 java_libs: ["myjar"],
2018 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002019 updatable: false,
Artur Satayev8cf899a2020-04-15 17:29:42 +01002020 }
2021 apex_key {
2022 name: "myapex.key",
2023 public_key: "testkey.avbpubkey",
2024 private_key: "testkey.pem",
2025 }
2026 java_library {
2027 name: "myjar",
2028 srcs: ["foo/bar/MyClass.java"],
Paul Duffin043f5e72021-03-05 00:00:01 +00002029 sdk_version: "test_current",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002030 apex_available: ["myapex"],
2031 }
2032 `,
2033 },
2034 {
2035 name: "Updatable apex with stable dep",
2036 bp: `
2037 apex {
2038 name: "myapex",
2039 java_libs: ["myjar"],
2040 key: "myapex.key",
2041 updatable: true,
2042 min_sdk_version: "29",
2043 }
2044 apex_key {
2045 name: "myapex.key",
2046 public_key: "testkey.avbpubkey",
2047 private_key: "testkey.pem",
2048 }
2049 java_library {
2050 name: "myjar",
2051 srcs: ["foo/bar/MyClass.java"],
2052 sdk_version: "current",
2053 apex_available: ["myapex"],
Jooyung Han749dc692020-04-15 11:03:39 +09002054 min_sdk_version: "29",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002055 }
2056 `,
2057 },
2058 {
2059 name: "Updatable apex with non-stable dep",
2060 expectedError: "cannot depend on \"myjar\"",
2061 bp: `
2062 apex {
2063 name: "myapex",
2064 java_libs: ["myjar"],
2065 key: "myapex.key",
2066 updatable: true,
2067 }
2068 apex_key {
2069 name: "myapex.key",
2070 public_key: "testkey.avbpubkey",
2071 private_key: "testkey.pem",
2072 }
2073 java_library {
2074 name: "myjar",
2075 srcs: ["foo/bar/MyClass.java"],
Paul Duffin043f5e72021-03-05 00:00:01 +00002076 sdk_version: "test_current",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002077 apex_available: ["myapex"],
2078 }
2079 `,
2080 },
2081 {
Paul Duffin043f5e72021-03-05 00:00:01 +00002082 name: "Updatable apex with non-stable transitive dep",
2083 // This is not actually detecting that the transitive dependency is unstable, rather it is
2084 // detecting that the transitive dependency is building against a wider API surface than the
2085 // module that depends on it is using.
Jiyong Park670e0f62021-02-18 13:10:18 +09002086 expectedError: "compiles against Android API, but dependency \"transitive-jar\" is compiling against private API.",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002087 bp: `
2088 apex {
2089 name: "myapex",
2090 java_libs: ["myjar"],
2091 key: "myapex.key",
2092 updatable: true,
2093 }
2094 apex_key {
2095 name: "myapex.key",
2096 public_key: "testkey.avbpubkey",
2097 private_key: "testkey.pem",
2098 }
2099 java_library {
2100 name: "myjar",
2101 srcs: ["foo/bar/MyClass.java"],
2102 sdk_version: "current",
2103 apex_available: ["myapex"],
2104 static_libs: ["transitive-jar"],
2105 }
2106 java_library {
2107 name: "transitive-jar",
2108 srcs: ["foo/bar/MyClass.java"],
2109 sdk_version: "core_platform",
2110 apex_available: ["myapex"],
2111 }
2112 `,
2113 },
2114 }
2115
2116 for _, test := range testCases {
2117 t.Run(test.name, func(t *testing.T) {
2118 if test.expectedError == "" {
2119 testApex(t, test.bp)
2120 } else {
2121 testApexError(t, test.expectedError, test.bp)
2122 }
2123 })
2124 }
2125}
2126
Jooyung Han749dc692020-04-15 11:03:39 +09002127func TestApexMinSdkVersion_ErrorIfDepIsNewer(t *testing.T) {
2128 testApexError(t, `module "mylib2".*: should support min_sdk_version\(29\) for "myapex"`, `
2129 apex {
2130 name: "myapex",
2131 key: "myapex.key",
2132 native_shared_libs: ["mylib"],
2133 min_sdk_version: "29",
2134 }
2135
2136 apex_key {
2137 name: "myapex.key",
2138 public_key: "testkey.avbpubkey",
2139 private_key: "testkey.pem",
2140 }
2141
2142 cc_library {
2143 name: "mylib",
2144 srcs: ["mylib.cpp"],
2145 shared_libs: ["mylib2"],
2146 system_shared_libs: [],
2147 stl: "none",
2148 apex_available: [
2149 "myapex",
2150 ],
2151 min_sdk_version: "29",
2152 }
2153
2154 // indirect part of the apex
2155 cc_library {
2156 name: "mylib2",
2157 srcs: ["mylib.cpp"],
2158 system_shared_libs: [],
2159 stl: "none",
2160 apex_available: [
2161 "myapex",
2162 ],
2163 min_sdk_version: "30",
2164 }
2165 `)
2166}
2167
2168func TestApexMinSdkVersion_ErrorIfDepIsNewer_Java(t *testing.T) {
2169 testApexError(t, `module "bar".*: should support min_sdk_version\(29\) for "myapex"`, `
2170 apex {
2171 name: "myapex",
2172 key: "myapex.key",
2173 apps: ["AppFoo"],
2174 min_sdk_version: "29",
2175 }
2176
2177 apex_key {
2178 name: "myapex.key",
2179 public_key: "testkey.avbpubkey",
2180 private_key: "testkey.pem",
2181 }
2182
2183 android_app {
2184 name: "AppFoo",
2185 srcs: ["foo/bar/MyClass.java"],
2186 sdk_version: "current",
2187 min_sdk_version: "29",
2188 system_modules: "none",
2189 stl: "none",
2190 static_libs: ["bar"],
2191 apex_available: [ "myapex" ],
2192 }
2193
2194 java_library {
2195 name: "bar",
2196 sdk_version: "current",
2197 srcs: ["a.java"],
2198 apex_available: [ "myapex" ],
2199 }
2200 `)
2201}
2202
2203func TestApexMinSdkVersion_OkayEvenWhenDepIsNewer_IfItSatisfiesApexMinSdkVersion(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002204 ctx := testApex(t, `
Jooyung Han749dc692020-04-15 11:03:39 +09002205 apex {
2206 name: "myapex",
2207 key: "myapex.key",
2208 native_shared_libs: ["mylib"],
2209 min_sdk_version: "29",
2210 }
2211
2212 apex_key {
2213 name: "myapex.key",
2214 public_key: "testkey.avbpubkey",
2215 private_key: "testkey.pem",
2216 }
2217
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002218 // mylib in myapex will link to mylib2#current
Jooyung Han749dc692020-04-15 11:03:39 +09002219 // mylib in otherapex will link to mylib2(non-stub) in otherapex as well
2220 cc_library {
2221 name: "mylib",
2222 srcs: ["mylib.cpp"],
2223 shared_libs: ["mylib2"],
2224 system_shared_libs: [],
2225 stl: "none",
2226 apex_available: ["myapex", "otherapex"],
2227 min_sdk_version: "29",
2228 }
2229
2230 cc_library {
2231 name: "mylib2",
2232 srcs: ["mylib.cpp"],
2233 system_shared_libs: [],
2234 stl: "none",
2235 apex_available: ["otherapex"],
2236 stubs: { versions: ["29", "30"] },
2237 min_sdk_version: "30",
2238 }
2239
2240 apex {
2241 name: "otherapex",
2242 key: "myapex.key",
2243 native_shared_libs: ["mylib", "mylib2"],
2244 min_sdk_version: "30",
2245 }
2246 `)
2247 expectLink := func(from, from_variant, to, to_variant string) {
2248 ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
2249 libFlags := ld.Args["libFlags"]
2250 ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
2251 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002252 expectLink("mylib", "shared_apex29", "mylib2", "shared_current")
Colin Crossaede88c2020-08-11 12:17:01 -07002253 expectLink("mylib", "shared_apex30", "mylib2", "shared_apex30")
Jooyung Han749dc692020-04-15 11:03:39 +09002254}
2255
Jooyung Haned124c32021-01-26 11:43:46 +09002256func TestApexMinSdkVersion_WorksWithSdkCodename(t *testing.T) {
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002257 withSAsActiveCodeNames := android.FixtureModifyProductVariables(
2258 func(variables android.FixtureProductVariables) {
2259 variables.Platform_sdk_codename = proptools.StringPtr("S")
2260 variables.Platform_version_active_codenames = []string{"S"}
2261 },
2262 )
Jooyung Haned124c32021-01-26 11:43:46 +09002263 testApexError(t, `libbar.*: should support min_sdk_version\(S\)`, `
2264 apex {
2265 name: "myapex",
2266 key: "myapex.key",
2267 native_shared_libs: ["libfoo"],
2268 min_sdk_version: "S",
2269 }
2270 apex_key {
2271 name: "myapex.key",
2272 public_key: "testkey.avbpubkey",
2273 private_key: "testkey.pem",
2274 }
2275 cc_library {
2276 name: "libfoo",
2277 shared_libs: ["libbar"],
2278 apex_available: ["myapex"],
2279 min_sdk_version: "29",
2280 }
2281 cc_library {
2282 name: "libbar",
2283 apex_available: ["myapex"],
2284 }
2285 `, withSAsActiveCodeNames)
2286}
2287
2288func TestApexMinSdkVersion_WorksWithActiveCodenames(t *testing.T) {
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002289 withSAsActiveCodeNames := android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
2290 variables.Platform_sdk_codename = proptools.StringPtr("S")
2291 variables.Platform_version_active_codenames = []string{"S", "T"}
2292 })
Colin Cross1c460562021-02-16 17:55:47 -08002293 ctx := testApex(t, `
Jooyung Haned124c32021-01-26 11:43:46 +09002294 apex {
2295 name: "myapex",
2296 key: "myapex.key",
2297 native_shared_libs: ["libfoo"],
2298 min_sdk_version: "S",
2299 }
2300 apex_key {
2301 name: "myapex.key",
2302 public_key: "testkey.avbpubkey",
2303 private_key: "testkey.pem",
2304 }
2305 cc_library {
2306 name: "libfoo",
2307 shared_libs: ["libbar"],
2308 apex_available: ["myapex"],
2309 min_sdk_version: "S",
2310 }
2311 cc_library {
2312 name: "libbar",
2313 stubs: {
2314 symbol_file: "libbar.map.txt",
2315 versions: ["30", "S", "T"],
2316 },
2317 }
2318 `, withSAsActiveCodeNames)
2319
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002320 // ensure libfoo is linked with current version of libbar stub
Jooyung Haned124c32021-01-26 11:43:46 +09002321 libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_apex10000")
2322 libFlags := libfoo.Rule("ld").Args["libFlags"]
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002323 ensureContains(t, libFlags, "android_arm64_armv8-a_shared_current/libbar.so")
Jooyung Haned124c32021-01-26 11:43:46 +09002324}
2325
Jiyong Park7c2ee712018-12-07 00:42:25 +09002326func TestFilesInSubDir(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002327 ctx := testApex(t, `
Jiyong Park7c2ee712018-12-07 00:42:25 +09002328 apex {
2329 name: "myapex",
2330 key: "myapex.key",
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002331 native_shared_libs: ["mylib"],
2332 binaries: ["mybin"],
Jiyong Park7c2ee712018-12-07 00:42:25 +09002333 prebuilts: ["myetc"],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002334 compile_multilib: "both",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002335 updatable: false,
Jiyong Park7c2ee712018-12-07 00:42:25 +09002336 }
2337
2338 apex_key {
2339 name: "myapex.key",
2340 public_key: "testkey.avbpubkey",
2341 private_key: "testkey.pem",
2342 }
2343
2344 prebuilt_etc {
2345 name: "myetc",
2346 src: "myprebuilt",
2347 sub_dir: "foo/bar",
2348 }
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002349
2350 cc_library {
2351 name: "mylib",
2352 srcs: ["mylib.cpp"],
2353 relative_install_path: "foo/bar",
2354 system_shared_libs: [],
2355 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002356 apex_available: [ "myapex" ],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002357 }
2358
2359 cc_binary {
2360 name: "mybin",
2361 srcs: ["mylib.cpp"],
2362 relative_install_path: "foo/bar",
2363 system_shared_libs: [],
2364 static_executable: true,
2365 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002366 apex_available: [ "myapex" ],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002367 }
Jiyong Park7c2ee712018-12-07 00:42:25 +09002368 `)
2369
Sundong Ahnabb64432019-10-22 13:58:29 +09002370 generateFsRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("generateFsConfig")
Jiyong Park7c2ee712018-12-07 00:42:25 +09002371 dirs := strings.Split(generateFsRule.Args["exec_paths"], " ")
2372
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002373 // Ensure that the subdirectories are all listed
Jiyong Park7c2ee712018-12-07 00:42:25 +09002374 ensureListContains(t, dirs, "etc")
2375 ensureListContains(t, dirs, "etc/foo")
2376 ensureListContains(t, dirs, "etc/foo/bar")
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002377 ensureListContains(t, dirs, "lib64")
2378 ensureListContains(t, dirs, "lib64/foo")
2379 ensureListContains(t, dirs, "lib64/foo/bar")
2380 ensureListContains(t, dirs, "lib")
2381 ensureListContains(t, dirs, "lib/foo")
2382 ensureListContains(t, dirs, "lib/foo/bar")
2383
Jiyong Parkbd13e442019-03-15 18:10:35 +09002384 ensureListContains(t, dirs, "bin")
2385 ensureListContains(t, dirs, "bin/foo")
2386 ensureListContains(t, dirs, "bin/foo/bar")
Jiyong Park7c2ee712018-12-07 00:42:25 +09002387}
Jiyong Parkda6eb592018-12-19 17:12:36 +09002388
Jooyung Han35155c42020-02-06 17:33:20 +09002389func TestFilesInSubDirWhenNativeBridgeEnabled(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002390 ctx := testApex(t, `
Jooyung Han35155c42020-02-06 17:33:20 +09002391 apex {
2392 name: "myapex",
2393 key: "myapex.key",
2394 multilib: {
2395 both: {
2396 native_shared_libs: ["mylib"],
2397 binaries: ["mybin"],
2398 },
2399 },
2400 compile_multilib: "both",
2401 native_bridge_supported: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002402 updatable: false,
Jooyung Han35155c42020-02-06 17:33:20 +09002403 }
2404
2405 apex_key {
2406 name: "myapex.key",
2407 public_key: "testkey.avbpubkey",
2408 private_key: "testkey.pem",
2409 }
2410
2411 cc_library {
2412 name: "mylib",
2413 relative_install_path: "foo/bar",
2414 system_shared_libs: [],
2415 stl: "none",
2416 apex_available: [ "myapex" ],
2417 native_bridge_supported: true,
2418 }
2419
2420 cc_binary {
2421 name: "mybin",
2422 relative_install_path: "foo/bar",
2423 system_shared_libs: [],
2424 static_executable: true,
2425 stl: "none",
2426 apex_available: [ "myapex" ],
2427 native_bridge_supported: true,
2428 compile_multilib: "both", // default is "first" for binary
2429 multilib: {
2430 lib64: {
2431 suffix: "64",
2432 },
2433 },
2434 }
2435 `, withNativeBridgeEnabled)
2436 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2437 "bin/foo/bar/mybin",
2438 "bin/foo/bar/mybin64",
2439 "bin/arm/foo/bar/mybin",
2440 "bin/arm64/foo/bar/mybin64",
2441 "lib/foo/bar/mylib.so",
2442 "lib/arm/foo/bar/mylib.so",
2443 "lib64/foo/bar/mylib.so",
2444 "lib64/arm64/foo/bar/mylib.so",
2445 })
2446}
2447
Jiyong Parkda6eb592018-12-19 17:12:36 +09002448func TestUseVendor(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002449 ctx := testApex(t, `
Jiyong Parkda6eb592018-12-19 17:12:36 +09002450 apex {
2451 name: "myapex",
2452 key: "myapex.key",
2453 native_shared_libs: ["mylib"],
2454 use_vendor: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002455 updatable: false,
Jiyong Parkda6eb592018-12-19 17:12:36 +09002456 }
2457
2458 apex_key {
2459 name: "myapex.key",
2460 public_key: "testkey.avbpubkey",
2461 private_key: "testkey.pem",
2462 }
2463
2464 cc_library {
2465 name: "mylib",
2466 srcs: ["mylib.cpp"],
2467 shared_libs: ["mylib2"],
2468 system_shared_libs: [],
2469 vendor_available: true,
2470 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002471 apex_available: [ "myapex" ],
Jiyong Parkda6eb592018-12-19 17:12:36 +09002472 }
2473
2474 cc_library {
2475 name: "mylib2",
2476 srcs: ["mylib.cpp"],
2477 system_shared_libs: [],
2478 vendor_available: true,
2479 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002480 apex_available: [ "myapex" ],
Jiyong Parkda6eb592018-12-19 17:12:36 +09002481 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002482 `,
2483 setUseVendorAllowListForTest([]string{"myapex"}),
2484 )
Jiyong Parkda6eb592018-12-19 17:12:36 +09002485
2486 inputsList := []string{}
Sundong Ahnabb64432019-10-22 13:58:29 +09002487 for _, i := range ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().BuildParamsForTests() {
Jiyong Parkda6eb592018-12-19 17:12:36 +09002488 for _, implicit := range i.Implicits {
2489 inputsList = append(inputsList, implicit.String())
2490 }
2491 }
2492 inputsString := strings.Join(inputsList, " ")
2493
2494 // ensure that the apex includes vendor variants of the direct and indirect deps
Jiyong Parkf58c46e2021-04-01 21:35:20 +09002495 ensureContains(t, inputsString, "android_vendor.29_arm64_armv8-a_shared_apex10000/mylib.so")
2496 ensureContains(t, inputsString, "android_vendor.29_arm64_armv8-a_shared_apex10000/mylib2.so")
Jiyong Parkda6eb592018-12-19 17:12:36 +09002497
2498 // ensure that the apex does not include core variants
Colin Crossaede88c2020-08-11 12:17:01 -07002499 ensureNotContains(t, inputsString, "android_arm64_armv8-a_shared_apex10000/mylib.so")
2500 ensureNotContains(t, inputsString, "android_arm64_armv8-a_shared_apex10000/mylib2.so")
Jiyong Parkda6eb592018-12-19 17:12:36 +09002501}
Jiyong Park16e91a02018-12-20 18:18:08 +09002502
Jooyung Han85d61762020-06-24 23:50:26 +09002503func TestUseVendorNotAllowedForSystemApexes(t *testing.T) {
Jooyung Handc782442019-11-01 03:14:38 +09002504 testApexError(t, `module "myapex" .*: use_vendor: not allowed`, `
2505 apex {
2506 name: "myapex",
2507 key: "myapex.key",
2508 use_vendor: true,
2509 }
2510 apex_key {
2511 name: "myapex.key",
2512 public_key: "testkey.avbpubkey",
2513 private_key: "testkey.pem",
2514 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002515 `,
2516 setUseVendorAllowListForTest([]string{""}),
2517 )
Colin Cross440e0d02020-06-11 11:32:11 -07002518 // no error with allow list
Jooyung Handc782442019-11-01 03:14:38 +09002519 testApex(t, `
2520 apex {
2521 name: "myapex",
2522 key: "myapex.key",
2523 use_vendor: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002524 updatable: false,
Jooyung Handc782442019-11-01 03:14:38 +09002525 }
2526 apex_key {
2527 name: "myapex.key",
2528 public_key: "testkey.avbpubkey",
2529 private_key: "testkey.pem",
2530 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002531 `,
2532 setUseVendorAllowListForTest([]string{"myapex"}),
2533 )
Jooyung Handc782442019-11-01 03:14:38 +09002534}
2535
Jooyung Han5c998b92019-06-27 11:30:33 +09002536func TestUseVendorFailsIfNotVendorAvailable(t *testing.T) {
2537 testApexError(t, `dependency "mylib" of "myapex" missing variant:\n.*image:vendor`, `
2538 apex {
2539 name: "myapex",
2540 key: "myapex.key",
2541 native_shared_libs: ["mylib"],
2542 use_vendor: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002543 updatable: false,
Jooyung Han5c998b92019-06-27 11:30:33 +09002544 }
2545
2546 apex_key {
2547 name: "myapex.key",
2548 public_key: "testkey.avbpubkey",
2549 private_key: "testkey.pem",
2550 }
2551
2552 cc_library {
2553 name: "mylib",
2554 srcs: ["mylib.cpp"],
2555 system_shared_libs: [],
2556 stl: "none",
2557 }
2558 `)
2559}
2560
Jooyung Han85d61762020-06-24 23:50:26 +09002561func TestVendorApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002562 ctx := testApex(t, `
Jooyung Han85d61762020-06-24 23:50:26 +09002563 apex {
2564 name: "myapex",
2565 key: "myapex.key",
2566 binaries: ["mybin"],
2567 vendor: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002568 updatable: false,
Jooyung Han85d61762020-06-24 23:50:26 +09002569 }
2570 apex_key {
2571 name: "myapex.key",
2572 public_key: "testkey.avbpubkey",
2573 private_key: "testkey.pem",
2574 }
2575 cc_binary {
2576 name: "mybin",
2577 vendor: true,
2578 shared_libs: ["libfoo"],
2579 }
2580 cc_library {
2581 name: "libfoo",
2582 proprietary: true,
2583 }
2584 `)
2585
2586 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2587 "bin/mybin",
2588 "lib64/libfoo.so",
2589 // TODO(b/159195575): Add an option to use VNDK libs from VNDK APEX
2590 "lib64/libc++.so",
2591 })
2592
2593 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07002594 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Han85d61762020-06-24 23:50:26 +09002595 name := apexBundle.BaseModuleName()
2596 prefix := "TARGET_"
2597 var builder strings.Builder
2598 data.Custom(&builder, name, prefix, "", data)
Paul Duffin37ba3442021-03-29 00:21:08 +01002599 androidMk := android.StringRelativeToTop(ctx.Config(), builder.String())
2600 installPath := "out/target/product/test_device/vendor/apex"
Lukacs T. Berki7690c092021-02-26 14:27:36 +01002601 ensureContains(t, androidMk, "LOCAL_MODULE_PATH := "+installPath)
Jooyung Han6c4cc9c2020-07-29 16:00:54 +09002602
2603 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
2604 requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
2605 ensureListNotContains(t, requireNativeLibs, ":vndk")
Jooyung Han85d61762020-06-24 23:50:26 +09002606}
2607
Jooyung Handf78e212020-07-22 15:54:47 +09002608func TestVendorApex_use_vndk_as_stable(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002609 ctx := testApex(t, `
Jooyung Handf78e212020-07-22 15:54:47 +09002610 apex {
2611 name: "myapex",
2612 key: "myapex.key",
2613 binaries: ["mybin"],
2614 vendor: true,
2615 use_vndk_as_stable: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002616 updatable: false,
Jooyung Handf78e212020-07-22 15:54:47 +09002617 }
2618 apex_key {
2619 name: "myapex.key",
2620 public_key: "testkey.avbpubkey",
2621 private_key: "testkey.pem",
2622 }
2623 cc_binary {
2624 name: "mybin",
2625 vendor: true,
2626 shared_libs: ["libvndk", "libvendor"],
2627 }
2628 cc_library {
2629 name: "libvndk",
2630 vndk: {
2631 enabled: true,
2632 },
2633 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09002634 product_available: true,
Jooyung Handf78e212020-07-22 15:54:47 +09002635 }
2636 cc_library {
2637 name: "libvendor",
2638 vendor: true,
2639 }
2640 `)
2641
Jiyong Parkf58c46e2021-04-01 21:35:20 +09002642 vendorVariant := "android_vendor.29_arm64_armv8-a"
Jooyung Handf78e212020-07-22 15:54:47 +09002643
Paul Duffina71a67a2021-03-29 00:42:57 +01002644 ldRule := ctx.ModuleForTests("mybin", vendorVariant+"_apex10000").Rule("ld")
Jooyung Handf78e212020-07-22 15:54:47 +09002645 libs := names(ldRule.Args["libFlags"])
2646 // VNDK libs(libvndk/libc++) as they are
Paul Duffin37ba3442021-03-29 00:21:08 +01002647 ensureListContains(t, libs, "out/soong/.intermediates/libvndk/"+vendorVariant+"_shared/libvndk.so")
2648 ensureListContains(t, libs, "out/soong/.intermediates/"+cc.DefaultCcCommonTestModulesDir+"libc++/"+vendorVariant+"_shared/libc++.so")
Jooyung Handf78e212020-07-22 15:54:47 +09002649 // non-stable Vendor libs as APEX variants
Paul Duffin37ba3442021-03-29 00:21:08 +01002650 ensureListContains(t, libs, "out/soong/.intermediates/libvendor/"+vendorVariant+"_shared_apex10000/libvendor.so")
Jooyung Handf78e212020-07-22 15:54:47 +09002651
2652 // VNDK libs are not included when use_vndk_as_stable: true
2653 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2654 "bin/mybin",
2655 "lib64/libvendor.so",
2656 })
Jooyung Han6c4cc9c2020-07-29 16:00:54 +09002657
2658 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
2659 requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
2660 ensureListContains(t, requireNativeLibs, ":vndk")
Jooyung Handf78e212020-07-22 15:54:47 +09002661}
2662
Justin Yun13decfb2021-03-08 19:25:55 +09002663func TestProductVariant(t *testing.T) {
2664 ctx := testApex(t, `
2665 apex {
2666 name: "myapex",
2667 key: "myapex.key",
2668 updatable: false,
2669 product_specific: true,
2670 binaries: ["foo"],
2671 }
2672
2673 apex_key {
2674 name: "myapex.key",
2675 public_key: "testkey.avbpubkey",
2676 private_key: "testkey.pem",
2677 }
2678
2679 cc_binary {
2680 name: "foo",
2681 product_available: true,
2682 apex_available: ["myapex"],
2683 srcs: ["foo.cpp"],
2684 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002685 `, android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
2686 variables.ProductVndkVersion = proptools.StringPtr("current")
2687 }),
2688 )
Justin Yun13decfb2021-03-08 19:25:55 +09002689
2690 cflags := strings.Fields(
Jiyong Parkf58c46e2021-04-01 21:35:20 +09002691 ctx.ModuleForTests("foo", "android_product.29_arm64_armv8-a_apex10000").Rule("cc").Args["cFlags"])
Justin Yun13decfb2021-03-08 19:25:55 +09002692 ensureListContains(t, cflags, "-D__ANDROID_VNDK__")
2693 ensureListContains(t, cflags, "-D__ANDROID_APEX__")
2694 ensureListContains(t, cflags, "-D__ANDROID_PRODUCT__")
2695 ensureListNotContains(t, cflags, "-D__ANDROID_VENDOR__")
2696}
2697
Jooyung Han8e5685d2020-09-21 11:02:57 +09002698func TestApex_withPrebuiltFirmware(t *testing.T) {
2699 testCases := []struct {
2700 name string
2701 additionalProp string
2702 }{
2703 {"system apex with prebuilt_firmware", ""},
2704 {"vendor apex with prebuilt_firmware", "vendor: true,"},
2705 }
2706 for _, tc := range testCases {
2707 t.Run(tc.name, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002708 ctx := testApex(t, `
Jooyung Han8e5685d2020-09-21 11:02:57 +09002709 apex {
2710 name: "myapex",
2711 key: "myapex.key",
2712 prebuilts: ["myfirmware"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002713 updatable: false,
Jooyung Han8e5685d2020-09-21 11:02:57 +09002714 `+tc.additionalProp+`
2715 }
2716 apex_key {
2717 name: "myapex.key",
2718 public_key: "testkey.avbpubkey",
2719 private_key: "testkey.pem",
2720 }
2721 prebuilt_firmware {
2722 name: "myfirmware",
2723 src: "myfirmware.bin",
2724 filename_from_src: true,
2725 `+tc.additionalProp+`
2726 }
2727 `)
2728 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2729 "etc/firmware/myfirmware.bin",
2730 })
2731 })
2732 }
Jooyung Han0703fd82020-08-26 22:11:53 +09002733}
2734
Jooyung Hanefb184e2020-06-25 17:14:25 +09002735func TestAndroidMk_UseVendorRequired(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002736 ctx := testApex(t, `
Jooyung Hanefb184e2020-06-25 17:14:25 +09002737 apex {
2738 name: "myapex",
2739 key: "myapex.key",
2740 use_vendor: true,
2741 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002742 updatable: false,
Jooyung Hanefb184e2020-06-25 17:14:25 +09002743 }
2744
2745 apex_key {
2746 name: "myapex.key",
2747 public_key: "testkey.avbpubkey",
2748 private_key: "testkey.pem",
2749 }
2750
2751 cc_library {
2752 name: "mylib",
2753 vendor_available: true,
2754 apex_available: ["myapex"],
2755 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002756 `,
2757 setUseVendorAllowListForTest([]string{"myapex"}),
2758 )
Jooyung Hanefb184e2020-06-25 17:14:25 +09002759
2760 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07002761 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Hanefb184e2020-06-25 17:14:25 +09002762 name := apexBundle.BaseModuleName()
2763 prefix := "TARGET_"
2764 var builder strings.Builder
2765 data.Custom(&builder, name, prefix, "", data)
2766 androidMk := builder.String()
2767 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += libc libm libdl\n")
2768}
2769
2770func TestAndroidMk_VendorApexRequired(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002771 ctx := testApex(t, `
Jooyung Hanefb184e2020-06-25 17:14:25 +09002772 apex {
2773 name: "myapex",
2774 key: "myapex.key",
2775 vendor: true,
2776 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002777 updatable: false,
Jooyung Hanefb184e2020-06-25 17:14:25 +09002778 }
2779
2780 apex_key {
2781 name: "myapex.key",
2782 public_key: "testkey.avbpubkey",
2783 private_key: "testkey.pem",
2784 }
2785
2786 cc_library {
2787 name: "mylib",
2788 vendor_available: true,
2789 }
2790 `)
2791
2792 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07002793 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Hanefb184e2020-06-25 17:14:25 +09002794 name := apexBundle.BaseModuleName()
2795 prefix := "TARGET_"
2796 var builder strings.Builder
2797 data.Custom(&builder, name, prefix, "", data)
2798 androidMk := builder.String()
2799 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += libc.vendor libm.vendor libdl.vendor\n")
2800}
2801
Jooyung Han2ed99d02020-06-24 23:26:26 +09002802func TestAndroidMkWritesCommonProperties(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002803 ctx := testApex(t, `
Jooyung Han2ed99d02020-06-24 23:26:26 +09002804 apex {
2805 name: "myapex",
2806 key: "myapex.key",
2807 vintf_fragments: ["fragment.xml"],
2808 init_rc: ["init.rc"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002809 updatable: false,
Jooyung Han2ed99d02020-06-24 23:26:26 +09002810 }
2811 apex_key {
2812 name: "myapex.key",
2813 public_key: "testkey.avbpubkey",
2814 private_key: "testkey.pem",
2815 }
2816 cc_binary {
2817 name: "mybin",
2818 }
2819 `)
2820
2821 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07002822 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Han2ed99d02020-06-24 23:26:26 +09002823 name := apexBundle.BaseModuleName()
2824 prefix := "TARGET_"
2825 var builder strings.Builder
2826 data.Custom(&builder, name, prefix, "", data)
2827 androidMk := builder.String()
Liz Kammer7b3dc8a2021-04-16 16:41:59 -04002828 ensureContains(t, androidMk, "LOCAL_FULL_VINTF_FRAGMENTS := fragment.xml\n")
Liz Kammer0c4f71c2021-04-06 10:35:10 -04002829 ensureContains(t, androidMk, "LOCAL_FULL_INIT_RC := init.rc\n")
Jooyung Han2ed99d02020-06-24 23:26:26 +09002830}
2831
Jiyong Park16e91a02018-12-20 18:18:08 +09002832func TestStaticLinking(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002833 ctx := testApex(t, `
Jiyong Park16e91a02018-12-20 18:18:08 +09002834 apex {
2835 name: "myapex",
2836 key: "myapex.key",
2837 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002838 updatable: false,
Jiyong Park16e91a02018-12-20 18:18:08 +09002839 }
2840
2841 apex_key {
2842 name: "myapex.key",
2843 public_key: "testkey.avbpubkey",
2844 private_key: "testkey.pem",
2845 }
2846
2847 cc_library {
2848 name: "mylib",
2849 srcs: ["mylib.cpp"],
2850 system_shared_libs: [],
2851 stl: "none",
2852 stubs: {
2853 versions: ["1", "2", "3"],
2854 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002855 apex_available: [
2856 "//apex_available:platform",
2857 "myapex",
2858 ],
Jiyong Park16e91a02018-12-20 18:18:08 +09002859 }
2860
2861 cc_binary {
2862 name: "not_in_apex",
2863 srcs: ["mylib.cpp"],
2864 static_libs: ["mylib"],
2865 static_executable: true,
2866 system_shared_libs: [],
2867 stl: "none",
2868 }
Jiyong Park16e91a02018-12-20 18:18:08 +09002869 `)
2870
Colin Cross7113d202019-11-20 16:39:12 -08002871 ldFlags := ctx.ModuleForTests("not_in_apex", "android_arm64_armv8-a").Rule("ld").Args["libFlags"]
Jiyong Park16e91a02018-12-20 18:18:08 +09002872
2873 // Ensure that not_in_apex is linking with the static variant of mylib
Colin Cross7113d202019-11-20 16:39:12 -08002874 ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_static/mylib.a")
Jiyong Park16e91a02018-12-20 18:18:08 +09002875}
Jiyong Park9335a262018-12-24 11:31:58 +09002876
2877func TestKeys(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002878 ctx := testApex(t, `
Jiyong Park9335a262018-12-24 11:31:58 +09002879 apex {
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002880 name: "myapex_keytest",
Jiyong Park9335a262018-12-24 11:31:58 +09002881 key: "myapex.key",
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002882 certificate: ":myapex.certificate",
Jiyong Park9335a262018-12-24 11:31:58 +09002883 native_shared_libs: ["mylib"],
Jooyung Han54aca7b2019-11-20 02:26:02 +09002884 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002885 updatable: false,
Jiyong Park9335a262018-12-24 11:31:58 +09002886 }
2887
2888 cc_library {
2889 name: "mylib",
2890 srcs: ["mylib.cpp"],
2891 system_shared_libs: [],
2892 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002893 apex_available: [ "myapex_keytest" ],
Jiyong Park9335a262018-12-24 11:31:58 +09002894 }
2895
2896 apex_key {
2897 name: "myapex.key",
2898 public_key: "testkey.avbpubkey",
2899 private_key: "testkey.pem",
2900 }
2901
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002902 android_app_certificate {
2903 name: "myapex.certificate",
2904 certificate: "testkey",
2905 }
2906
2907 android_app_certificate {
2908 name: "myapex.certificate.override",
2909 certificate: "testkey.override",
2910 }
2911
Jiyong Park9335a262018-12-24 11:31:58 +09002912 `)
2913
2914 // check the APEX keys
Jiyong Parkd1e293d2019-03-15 02:13:21 +09002915 keys := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
Jiyong Park9335a262018-12-24 11:31:58 +09002916
Jaewoong Jung18aefc12020-12-21 09:11:10 -08002917 if keys.publicKeyFile.String() != "vendor/foo/devkeys/testkey.avbpubkey" {
2918 t.Errorf("public key %q is not %q", keys.publicKeyFile.String(),
Jiyong Park9335a262018-12-24 11:31:58 +09002919 "vendor/foo/devkeys/testkey.avbpubkey")
2920 }
Jaewoong Jung18aefc12020-12-21 09:11:10 -08002921 if keys.privateKeyFile.String() != "vendor/foo/devkeys/testkey.pem" {
2922 t.Errorf("private key %q is not %q", keys.privateKeyFile.String(),
Jiyong Park9335a262018-12-24 11:31:58 +09002923 "vendor/foo/devkeys/testkey.pem")
2924 }
2925
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002926 // check the APK certs. It should be overridden to myapex.certificate.override
Sundong Ahnabb64432019-10-22 13:58:29 +09002927 certs := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk").Args["certificates"]
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002928 if certs != "testkey.override.x509.pem testkey.override.pk8" {
Jiyong Park9335a262018-12-24 11:31:58 +09002929 t.Errorf("cert and private key %q are not %q", certs,
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002930 "testkey.override.509.pem testkey.override.pk8")
Jiyong Park9335a262018-12-24 11:31:58 +09002931 }
2932}
Jiyong Park58e364a2019-01-19 19:24:06 +09002933
Jooyung Hanf121a652019-12-17 14:30:11 +09002934func TestCertificate(t *testing.T) {
2935 t.Run("if unspecified, it defaults to DefaultAppCertificate", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002936 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09002937 apex {
2938 name: "myapex",
2939 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002940 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09002941 }
2942 apex_key {
2943 name: "myapex.key",
2944 public_key: "testkey.avbpubkey",
2945 private_key: "testkey.pem",
2946 }`)
2947 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
2948 expected := "vendor/foo/devkeys/test.x509.pem vendor/foo/devkeys/test.pk8"
2949 if actual := rule.Args["certificates"]; actual != expected {
2950 t.Errorf("certificates should be %q, not %q", expected, actual)
2951 }
2952 })
2953 t.Run("override when unspecified", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002954 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09002955 apex {
2956 name: "myapex_keytest",
2957 key: "myapex.key",
2958 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002959 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09002960 }
2961 apex_key {
2962 name: "myapex.key",
2963 public_key: "testkey.avbpubkey",
2964 private_key: "testkey.pem",
2965 }
2966 android_app_certificate {
2967 name: "myapex.certificate.override",
2968 certificate: "testkey.override",
2969 }`)
2970 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
2971 expected := "testkey.override.x509.pem testkey.override.pk8"
2972 if actual := rule.Args["certificates"]; actual != expected {
2973 t.Errorf("certificates should be %q, not %q", expected, actual)
2974 }
2975 })
2976 t.Run("if specified as :module, it respects the prop", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002977 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09002978 apex {
2979 name: "myapex",
2980 key: "myapex.key",
2981 certificate: ":myapex.certificate",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002982 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09002983 }
2984 apex_key {
2985 name: "myapex.key",
2986 public_key: "testkey.avbpubkey",
2987 private_key: "testkey.pem",
2988 }
2989 android_app_certificate {
2990 name: "myapex.certificate",
2991 certificate: "testkey",
2992 }`)
2993 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
2994 expected := "testkey.x509.pem testkey.pk8"
2995 if actual := rule.Args["certificates"]; actual != expected {
2996 t.Errorf("certificates should be %q, not %q", expected, actual)
2997 }
2998 })
2999 t.Run("override when specifiec as <:module>", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003000 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003001 apex {
3002 name: "myapex_keytest",
3003 key: "myapex.key",
3004 file_contexts: ":myapex-file_contexts",
3005 certificate: ":myapex.certificate",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003006 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003007 }
3008 apex_key {
3009 name: "myapex.key",
3010 public_key: "testkey.avbpubkey",
3011 private_key: "testkey.pem",
3012 }
3013 android_app_certificate {
3014 name: "myapex.certificate.override",
3015 certificate: "testkey.override",
3016 }`)
3017 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
3018 expected := "testkey.override.x509.pem testkey.override.pk8"
3019 if actual := rule.Args["certificates"]; actual != expected {
3020 t.Errorf("certificates should be %q, not %q", expected, actual)
3021 }
3022 })
3023 t.Run("if specified as name, finds it from DefaultDevKeyDir", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003024 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003025 apex {
3026 name: "myapex",
3027 key: "myapex.key",
3028 certificate: "testkey",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003029 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003030 }
3031 apex_key {
3032 name: "myapex.key",
3033 public_key: "testkey.avbpubkey",
3034 private_key: "testkey.pem",
3035 }`)
3036 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
3037 expected := "vendor/foo/devkeys/testkey.x509.pem vendor/foo/devkeys/testkey.pk8"
3038 if actual := rule.Args["certificates"]; actual != expected {
3039 t.Errorf("certificates should be %q, not %q", expected, actual)
3040 }
3041 })
3042 t.Run("override when specified as <name>", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003043 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003044 apex {
3045 name: "myapex_keytest",
3046 key: "myapex.key",
3047 file_contexts: ":myapex-file_contexts",
3048 certificate: "testkey",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003049 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003050 }
3051 apex_key {
3052 name: "myapex.key",
3053 public_key: "testkey.avbpubkey",
3054 private_key: "testkey.pem",
3055 }
3056 android_app_certificate {
3057 name: "myapex.certificate.override",
3058 certificate: "testkey.override",
3059 }`)
3060 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
3061 expected := "testkey.override.x509.pem testkey.override.pk8"
3062 if actual := rule.Args["certificates"]; actual != expected {
3063 t.Errorf("certificates should be %q, not %q", expected, actual)
3064 }
3065 })
3066}
3067
Jiyong Park58e364a2019-01-19 19:24:06 +09003068func TestMacro(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003069 ctx := testApex(t, `
Jiyong Park58e364a2019-01-19 19:24:06 +09003070 apex {
3071 name: "myapex",
3072 key: "myapex.key",
Jooyung Hanc87a0592020-03-02 17:44:33 +09003073 native_shared_libs: ["mylib", "mylib2"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003074 updatable: false,
Jiyong Park58e364a2019-01-19 19:24:06 +09003075 }
3076
3077 apex {
3078 name: "otherapex",
3079 key: "myapex.key",
Jooyung Hanc87a0592020-03-02 17:44:33 +09003080 native_shared_libs: ["mylib", "mylib2"],
Jooyung Hanccce2f22020-03-07 03:45:53 +09003081 min_sdk_version: "29",
Jiyong Park58e364a2019-01-19 19:24:06 +09003082 }
3083
3084 apex_key {
3085 name: "myapex.key",
3086 public_key: "testkey.avbpubkey",
3087 private_key: "testkey.pem",
3088 }
3089
3090 cc_library {
3091 name: "mylib",
3092 srcs: ["mylib.cpp"],
3093 system_shared_libs: [],
3094 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003095 apex_available: [
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003096 "myapex",
3097 "otherapex",
3098 ],
Jooyung Han24282772020-03-21 23:20:55 +09003099 recovery_available: true,
Jooyung Han749dc692020-04-15 11:03:39 +09003100 min_sdk_version: "29",
Jiyong Park58e364a2019-01-19 19:24:06 +09003101 }
Jooyung Hanc87a0592020-03-02 17:44:33 +09003102 cc_library {
3103 name: "mylib2",
3104 srcs: ["mylib.cpp"],
3105 system_shared_libs: [],
3106 stl: "none",
3107 apex_available: [
3108 "myapex",
3109 "otherapex",
3110 ],
Colin Crossaede88c2020-08-11 12:17:01 -07003111 static_libs: ["mylib3"],
3112 recovery_available: true,
3113 min_sdk_version: "29",
3114 }
3115 cc_library {
3116 name: "mylib3",
3117 srcs: ["mylib.cpp"],
3118 system_shared_libs: [],
3119 stl: "none",
3120 apex_available: [
3121 "myapex",
3122 "otherapex",
3123 ],
Jooyung Hanc87a0592020-03-02 17:44:33 +09003124 use_apex_name_macro: true,
Colin Crossaede88c2020-08-11 12:17:01 -07003125 recovery_available: true,
Jooyung Han749dc692020-04-15 11:03:39 +09003126 min_sdk_version: "29",
Jooyung Hanc87a0592020-03-02 17:44:33 +09003127 }
Jiyong Park58e364a2019-01-19 19:24:06 +09003128 `)
3129
Jooyung Hanc87a0592020-03-02 17:44:33 +09003130 // non-APEX variant does not have __ANDROID_APEX__ defined
Colin Cross7113d202019-11-20 16:39:12 -08003131 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09003132 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003133 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
Jooyung Hanc87a0592020-03-02 17:44:33 +09003134
Jooyung Hanccce2f22020-03-07 03:45:53 +09003135 // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
Colin Crossaede88c2020-08-11 12:17:01 -07003136 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
Jooyung Hanc87a0592020-03-02 17:44:33 +09003137 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003138 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=10000")
Jooyung Han77988572019-10-18 16:26:16 +09003139 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
Jooyung Hanc87a0592020-03-02 17:44:33 +09003140
Jooyung Hanccce2f22020-03-07 03:45:53 +09003141 // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
Colin Crossaede88c2020-08-11 12:17:01 -07003142 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex29").Rule("cc").Args["cFlags"]
Jooyung Hanc87a0592020-03-02 17:44:33 +09003143 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003144 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=29")
Jooyung Han77988572019-10-18 16:26:16 +09003145 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09003146
Colin Crossaede88c2020-08-11 12:17:01 -07003147 // When a cc_library sets use_apex_name_macro: true each apex gets a unique variant and
3148 // each variant defines additional macros to distinguish which apex variant it is built for
3149
3150 // non-APEX variant does not have __ANDROID_APEX__ defined
3151 mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
3152 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3153
3154 // APEX variant has __ANDROID_APEX__ defined
3155 mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"]
3156 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3157 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
3158 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
3159
3160 // APEX variant has __ANDROID_APEX__ defined
3161 mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static_otherapex").Rule("cc").Args["cFlags"]
3162 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3163 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
3164 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
3165
Dan Albertb19953d2020-11-17 15:29:36 -08003166 // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__
Colin Crossaede88c2020-08-11 12:17:01 -07003167 mylibCFlags = ctx.ModuleForTests("mylib3", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
3168 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003169 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
Colin Crossaede88c2020-08-11 12:17:01 -07003170
3171 // When a dependency of a cc_library sets use_apex_name_macro: true each apex gets a unique
3172 // variant.
Jooyung Hanc87a0592020-03-02 17:44:33 +09003173
3174 // non-APEX variant does not have __ANDROID_APEX__ defined
3175 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
3176 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3177
3178 // APEX variant has __ANDROID_APEX__ defined
3179 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09003180 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Colin Crossaede88c2020-08-11 12:17:01 -07003181 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
Jooyung Han77988572019-10-18 16:26:16 +09003182 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09003183
Jooyung Hanc87a0592020-03-02 17:44:33 +09003184 // APEX variant has __ANDROID_APEX__ defined
3185 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_otherapex").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09003186 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Han77988572019-10-18 16:26:16 +09003187 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
Colin Crossaede88c2020-08-11 12:17:01 -07003188 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jooyung Han24282772020-03-21 23:20:55 +09003189
Dan Albertb19953d2020-11-17 15:29:36 -08003190 // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__
Colin Crossaede88c2020-08-11 12:17:01 -07003191 mylibCFlags = ctx.ModuleForTests("mylib2", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jooyung Han24282772020-03-21 23:20:55 +09003192 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003193 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
Jiyong Park58e364a2019-01-19 19:24:06 +09003194}
Jiyong Park7e636d02019-01-28 16:16:54 +09003195
3196func TestHeaderLibsDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003197 ctx := testApex(t, `
Jiyong Park7e636d02019-01-28 16:16:54 +09003198 apex {
3199 name: "myapex",
3200 key: "myapex.key",
3201 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003202 updatable: false,
Jiyong Park7e636d02019-01-28 16:16:54 +09003203 }
3204
3205 apex_key {
3206 name: "myapex.key",
3207 public_key: "testkey.avbpubkey",
3208 private_key: "testkey.pem",
3209 }
3210
3211 cc_library_headers {
3212 name: "mylib_headers",
3213 export_include_dirs: ["my_include"],
3214 system_shared_libs: [],
3215 stl: "none",
Jiyong Park0f80c182020-01-31 02:49:53 +09003216 apex_available: [ "myapex" ],
Jiyong Park7e636d02019-01-28 16:16:54 +09003217 }
3218
3219 cc_library {
3220 name: "mylib",
3221 srcs: ["mylib.cpp"],
3222 system_shared_libs: [],
3223 stl: "none",
3224 header_libs: ["mylib_headers"],
3225 export_header_lib_headers: ["mylib_headers"],
3226 stubs: {
3227 versions: ["1", "2", "3"],
3228 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003229 apex_available: [ "myapex" ],
Jiyong Park7e636d02019-01-28 16:16:54 +09003230 }
3231
3232 cc_library {
3233 name: "otherlib",
3234 srcs: ["mylib.cpp"],
3235 system_shared_libs: [],
3236 stl: "none",
3237 shared_libs: ["mylib"],
3238 }
3239 `)
3240
Colin Cross7113d202019-11-20 16:39:12 -08003241 cFlags := ctx.ModuleForTests("otherlib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jiyong Park7e636d02019-01-28 16:16:54 +09003242
3243 // Ensure that the include path of the header lib is exported to 'otherlib'
3244 ensureContains(t, cFlags, "-Imy_include")
3245}
Alex Light9670d332019-01-29 18:07:33 -08003246
Jiyong Park7cd10e32020-01-14 09:22:18 +09003247type fileInApex struct {
3248 path string // path in apex
Jooyung Hana57af4a2020-01-23 05:36:59 +00003249 src string // src path
Jiyong Park7cd10e32020-01-14 09:22:18 +09003250 isLink bool
3251}
3252
Jooyung Hana57af4a2020-01-23 05:36:59 +00003253func getFiles(t *testing.T, ctx *android.TestContext, moduleName, variant string) []fileInApex {
Jooyung Han31c470b2019-10-18 16:26:59 +09003254 t.Helper()
Jooyung Hana57af4a2020-01-23 05:36:59 +00003255 apexRule := ctx.ModuleForTests(moduleName, variant).Rule("apexRule")
Jooyung Han31c470b2019-10-18 16:26:59 +09003256 copyCmds := apexRule.Args["copy_commands"]
3257 imageApexDir := "/image.apex/"
Jiyong Park7cd10e32020-01-14 09:22:18 +09003258 var ret []fileInApex
Jooyung Han31c470b2019-10-18 16:26:59 +09003259 for _, cmd := range strings.Split(copyCmds, "&&") {
3260 cmd = strings.TrimSpace(cmd)
3261 if cmd == "" {
3262 continue
3263 }
3264 terms := strings.Split(cmd, " ")
Jooyung Hana57af4a2020-01-23 05:36:59 +00003265 var dst, src string
Jiyong Park7cd10e32020-01-14 09:22:18 +09003266 var isLink bool
Jooyung Han31c470b2019-10-18 16:26:59 +09003267 switch terms[0] {
3268 case "mkdir":
3269 case "cp":
Jiyong Park7cd10e32020-01-14 09:22:18 +09003270 if len(terms) != 3 && len(terms) != 4 {
Jooyung Han31c470b2019-10-18 16:26:59 +09003271 t.Fatal("copyCmds contains invalid cp command", cmd)
3272 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09003273 dst = terms[len(terms)-1]
Jooyung Hana57af4a2020-01-23 05:36:59 +00003274 src = terms[len(terms)-2]
Jiyong Park7cd10e32020-01-14 09:22:18 +09003275 isLink = false
3276 case "ln":
3277 if len(terms) != 3 && len(terms) != 4 {
3278 // ln LINK TARGET or ln -s LINK TARGET
3279 t.Fatal("copyCmds contains invalid ln command", cmd)
3280 }
3281 dst = terms[len(terms)-1]
Jooyung Hana57af4a2020-01-23 05:36:59 +00003282 src = terms[len(terms)-2]
Jiyong Park7cd10e32020-01-14 09:22:18 +09003283 isLink = true
3284 default:
3285 t.Fatalf("copyCmds should contain mkdir/cp commands only: %q", cmd)
3286 }
3287 if dst != "" {
Jooyung Han31c470b2019-10-18 16:26:59 +09003288 index := strings.Index(dst, imageApexDir)
3289 if index == -1 {
3290 t.Fatal("copyCmds should copy a file to image.apex/", cmd)
3291 }
3292 dstFile := dst[index+len(imageApexDir):]
Jooyung Hana57af4a2020-01-23 05:36:59 +00003293 ret = append(ret, fileInApex{path: dstFile, src: src, isLink: isLink})
Jooyung Han31c470b2019-10-18 16:26:59 +09003294 }
3295 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09003296 return ret
3297}
3298
Jooyung Hana57af4a2020-01-23 05:36:59 +00003299func ensureExactContents(t *testing.T, ctx *android.TestContext, moduleName, variant string, files []string) {
3300 t.Helper()
Jiyong Park7cd10e32020-01-14 09:22:18 +09003301 var failed bool
3302 var surplus []string
3303 filesMatched := make(map[string]bool)
Jooyung Hana57af4a2020-01-23 05:36:59 +00003304 for _, file := range getFiles(t, ctx, moduleName, variant) {
Jooyung Hane6436d72020-02-27 13:31:56 +09003305 mactchFound := false
Jiyong Park7cd10e32020-01-14 09:22:18 +09003306 for _, expected := range files {
3307 if matched, _ := path.Match(expected, file.path); matched {
3308 filesMatched[expected] = true
Jooyung Hane6436d72020-02-27 13:31:56 +09003309 mactchFound = true
3310 break
Jiyong Park7cd10e32020-01-14 09:22:18 +09003311 }
3312 }
Jooyung Hane6436d72020-02-27 13:31:56 +09003313 if !mactchFound {
3314 surplus = append(surplus, file.path)
3315 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09003316 }
Jooyung Han31c470b2019-10-18 16:26:59 +09003317
Jooyung Han31c470b2019-10-18 16:26:59 +09003318 if len(surplus) > 0 {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003319 sort.Strings(surplus)
Jooyung Han31c470b2019-10-18 16:26:59 +09003320 t.Log("surplus files", surplus)
3321 failed = true
3322 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003323
3324 if len(files) > len(filesMatched) {
3325 var missing []string
3326 for _, expected := range files {
3327 if !filesMatched[expected] {
3328 missing = append(missing, expected)
3329 }
3330 }
3331 sort.Strings(missing)
Jooyung Han31c470b2019-10-18 16:26:59 +09003332 t.Log("missing files", missing)
3333 failed = true
3334 }
3335 if failed {
3336 t.Fail()
3337 }
3338}
3339
Jooyung Han344d5432019-08-23 11:17:39 +09003340func TestVndkApexCurrent(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003341 ctx := testApex(t, `
Jooyung Han344d5432019-08-23 11:17:39 +09003342 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003343 name: "com.android.vndk.current",
3344 key: "com.android.vndk.current.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003345 updatable: false,
Jooyung Han344d5432019-08-23 11:17:39 +09003346 }
3347
3348 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003349 name: "com.android.vndk.current.key",
Jooyung Han344d5432019-08-23 11:17:39 +09003350 public_key: "testkey.avbpubkey",
3351 private_key: "testkey.pem",
3352 }
3353
3354 cc_library {
3355 name: "libvndk",
3356 srcs: ["mylib.cpp"],
3357 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003358 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003359 vndk: {
3360 enabled: true,
3361 },
3362 system_shared_libs: [],
3363 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003364 apex_available: [ "com.android.vndk.current" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003365 }
3366
3367 cc_library {
3368 name: "libvndksp",
3369 srcs: ["mylib.cpp"],
3370 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003371 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003372 vndk: {
3373 enabled: true,
3374 support_system_process: true,
3375 },
3376 system_shared_libs: [],
3377 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003378 apex_available: [ "com.android.vndk.current" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003379 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003380 `+vndkLibrariesTxtFiles("current"))
Jooyung Han344d5432019-08-23 11:17:39 +09003381
Colin Cross2807f002021-03-02 10:15:29 -08003382 ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003383 "lib/libvndk.so",
3384 "lib/libvndksp.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09003385 "lib/libc++.so",
Jooyung Han31c470b2019-10-18 16:26:59 +09003386 "lib64/libvndk.so",
3387 "lib64/libvndksp.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09003388 "lib64/libc++.so",
Jiyong Parkf58c46e2021-04-01 21:35:20 +09003389 "etc/llndk.libraries.29.txt",
3390 "etc/vndkcore.libraries.29.txt",
3391 "etc/vndksp.libraries.29.txt",
3392 "etc/vndkprivate.libraries.29.txt",
3393 "etc/vndkproduct.libraries.29.txt",
Jooyung Han31c470b2019-10-18 16:26:59 +09003394 })
Jooyung Han344d5432019-08-23 11:17:39 +09003395}
3396
3397func TestVndkApexWithPrebuilt(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003398 ctx := testApex(t, `
Jooyung Han344d5432019-08-23 11:17:39 +09003399 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003400 name: "com.android.vndk.current",
3401 key: "com.android.vndk.current.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003402 updatable: false,
Jooyung Han344d5432019-08-23 11:17:39 +09003403 }
3404
3405 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003406 name: "com.android.vndk.current.key",
Jooyung Han344d5432019-08-23 11:17:39 +09003407 public_key: "testkey.avbpubkey",
3408 private_key: "testkey.pem",
3409 }
3410
3411 cc_prebuilt_library_shared {
Jooyung Han31c470b2019-10-18 16:26:59 +09003412 name: "libvndk",
3413 srcs: ["libvndk.so"],
Jooyung Han344d5432019-08-23 11:17:39 +09003414 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003415 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003416 vndk: {
3417 enabled: true,
3418 },
3419 system_shared_libs: [],
3420 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003421 apex_available: [ "com.android.vndk.current" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003422 }
Jooyung Han31c470b2019-10-18 16:26:59 +09003423
3424 cc_prebuilt_library_shared {
3425 name: "libvndk.arm",
3426 srcs: ["libvndk.arm.so"],
3427 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003428 product_available: true,
Jooyung Han31c470b2019-10-18 16:26:59 +09003429 vndk: {
3430 enabled: true,
3431 },
3432 enabled: false,
3433 arch: {
3434 arm: {
3435 enabled: true,
3436 },
3437 },
3438 system_shared_libs: [],
3439 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003440 apex_available: [ "com.android.vndk.current" ],
Jooyung Han31c470b2019-10-18 16:26:59 +09003441 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003442 `+vndkLibrariesTxtFiles("current"),
3443 withFiles(map[string][]byte{
3444 "libvndk.so": nil,
3445 "libvndk.arm.so": nil,
3446 }))
Colin Cross2807f002021-03-02 10:15:29 -08003447 ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003448 "lib/libvndk.so",
3449 "lib/libvndk.arm.so",
3450 "lib64/libvndk.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09003451 "lib/libc++.so",
3452 "lib64/libc++.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003453 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003454 })
Jooyung Han344d5432019-08-23 11:17:39 +09003455}
3456
Jooyung Han39edb6c2019-11-06 16:53:07 +09003457func vndkLibrariesTxtFiles(vers ...string) (result string) {
3458 for _, v := range vers {
3459 if v == "current" {
Justin Yun8a2600c2020-12-07 12:44:03 +09003460 for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003461 result += `
Colin Crosse4e44bc2020-12-28 13:50:21 -08003462 ` + txt + `_libraries_txt {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003463 name: "` + txt + `.libraries.txt",
3464 }
3465 `
3466 }
3467 } else {
Justin Yun8a2600c2020-12-07 12:44:03 +09003468 for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003469 result += `
3470 prebuilt_etc {
3471 name: "` + txt + `.libraries.` + v + `.txt",
3472 src: "dummy.txt",
3473 }
3474 `
3475 }
3476 }
3477 }
3478 return
3479}
3480
Jooyung Han344d5432019-08-23 11:17:39 +09003481func TestVndkApexVersion(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003482 ctx := testApex(t, `
Jooyung Han344d5432019-08-23 11:17:39 +09003483 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003484 name: "com.android.vndk.v27",
Jooyung Han344d5432019-08-23 11:17:39 +09003485 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003486 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09003487 vndk_version: "27",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003488 updatable: false,
Jooyung Han344d5432019-08-23 11:17:39 +09003489 }
3490
3491 apex_key {
3492 name: "myapex.key",
3493 public_key: "testkey.avbpubkey",
3494 private_key: "testkey.pem",
3495 }
3496
Jooyung Han31c470b2019-10-18 16:26:59 +09003497 vndk_prebuilt_shared {
3498 name: "libvndk27",
3499 version: "27",
Jooyung Han344d5432019-08-23 11:17:39 +09003500 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003501 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003502 vndk: {
3503 enabled: true,
3504 },
Jooyung Han31c470b2019-10-18 16:26:59 +09003505 target_arch: "arm64",
3506 arch: {
3507 arm: {
3508 srcs: ["libvndk27_arm.so"],
3509 },
3510 arm64: {
3511 srcs: ["libvndk27_arm64.so"],
3512 },
3513 },
Colin Cross2807f002021-03-02 10:15:29 -08003514 apex_available: [ "com.android.vndk.v27" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003515 }
3516
3517 vndk_prebuilt_shared {
3518 name: "libvndk27",
3519 version: "27",
3520 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003521 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003522 vndk: {
3523 enabled: true,
3524 },
Jooyung Han31c470b2019-10-18 16:26:59 +09003525 target_arch: "x86_64",
3526 arch: {
3527 x86: {
3528 srcs: ["libvndk27_x86.so"],
3529 },
3530 x86_64: {
3531 srcs: ["libvndk27_x86_64.so"],
3532 },
3533 },
Jooyung Han39edb6c2019-11-06 16:53:07 +09003534 }
3535 `+vndkLibrariesTxtFiles("27"),
3536 withFiles(map[string][]byte{
3537 "libvndk27_arm.so": nil,
3538 "libvndk27_arm64.so": nil,
3539 "libvndk27_x86.so": nil,
3540 "libvndk27_x86_64.so": nil,
3541 }))
Jooyung Han344d5432019-08-23 11:17:39 +09003542
Colin Cross2807f002021-03-02 10:15:29 -08003543 ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003544 "lib/libvndk27_arm.so",
3545 "lib64/libvndk27_arm64.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003546 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003547 })
Jooyung Han344d5432019-08-23 11:17:39 +09003548}
3549
Jooyung Han90eee022019-10-01 20:02:42 +09003550func TestVndkApexNameRule(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003551 ctx := testApex(t, `
Jooyung Han90eee022019-10-01 20:02:42 +09003552 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003553 name: "com.android.vndk.current",
Jooyung Han90eee022019-10-01 20:02:42 +09003554 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003555 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003556 updatable: false,
Jooyung Han90eee022019-10-01 20:02:42 +09003557 }
3558 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003559 name: "com.android.vndk.v28",
Jooyung Han90eee022019-10-01 20:02:42 +09003560 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003561 file_contexts: ":myapex-file_contexts",
Jooyung Han90eee022019-10-01 20:02:42 +09003562 vndk_version: "28",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003563 updatable: false,
Jooyung Han90eee022019-10-01 20:02:42 +09003564 }
3565 apex_key {
3566 name: "myapex.key",
3567 public_key: "testkey.avbpubkey",
3568 private_key: "testkey.pem",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003569 }`+vndkLibrariesTxtFiles("28", "current"))
Jooyung Han90eee022019-10-01 20:02:42 +09003570
3571 assertApexName := func(expected, moduleName string) {
Jooyung Hana57af4a2020-01-23 05:36:59 +00003572 bundle := ctx.ModuleForTests(moduleName, "android_common_image").Module().(*apexBundle)
Jooyung Han90eee022019-10-01 20:02:42 +09003573 actual := proptools.String(bundle.properties.Apex_name)
3574 if !reflect.DeepEqual(actual, expected) {
3575 t.Errorf("Got '%v', expected '%v'", actual, expected)
3576 }
3577 }
3578
Jiyong Parkf58c46e2021-04-01 21:35:20 +09003579 assertApexName("com.android.vndk.v29", "com.android.vndk.current")
Colin Cross2807f002021-03-02 10:15:29 -08003580 assertApexName("com.android.vndk.v28", "com.android.vndk.v28")
Jooyung Han90eee022019-10-01 20:02:42 +09003581}
3582
Jooyung Han344d5432019-08-23 11:17:39 +09003583func TestVndkApexSkipsNativeBridgeSupportedModules(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003584 ctx := testApex(t, `
Jooyung Han344d5432019-08-23 11:17:39 +09003585 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003586 name: "com.android.vndk.current",
3587 key: "com.android.vndk.current.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003588 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003589 updatable: false,
Jooyung Han344d5432019-08-23 11:17:39 +09003590 }
3591
3592 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003593 name: "com.android.vndk.current.key",
Jooyung Han344d5432019-08-23 11:17:39 +09003594 public_key: "testkey.avbpubkey",
3595 private_key: "testkey.pem",
3596 }
3597
3598 cc_library {
3599 name: "libvndk",
3600 srcs: ["mylib.cpp"],
3601 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003602 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003603 native_bridge_supported: true,
3604 host_supported: true,
3605 vndk: {
3606 enabled: true,
3607 },
3608 system_shared_libs: [],
3609 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003610 apex_available: [ "com.android.vndk.current" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003611 }
Colin Cross2807f002021-03-02 10:15:29 -08003612 `+vndkLibrariesTxtFiles("current"),
3613 withNativeBridgeEnabled)
Jooyung Han344d5432019-08-23 11:17:39 +09003614
Colin Cross2807f002021-03-02 10:15:29 -08003615 ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003616 "lib/libvndk.so",
3617 "lib64/libvndk.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09003618 "lib/libc++.so",
3619 "lib64/libc++.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003620 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003621 })
Jooyung Han344d5432019-08-23 11:17:39 +09003622}
3623
3624func TestVndkApexDoesntSupportNativeBridgeSupported(t *testing.T) {
Colin Cross2807f002021-03-02 10:15:29 -08003625 testApexError(t, `module "com.android.vndk.current" .*: native_bridge_supported: .* doesn't support native bridge binary`, `
Jooyung Han344d5432019-08-23 11:17:39 +09003626 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003627 name: "com.android.vndk.current",
3628 key: "com.android.vndk.current.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003629 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09003630 native_bridge_supported: true,
3631 }
3632
3633 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003634 name: "com.android.vndk.current.key",
Jooyung Han344d5432019-08-23 11:17:39 +09003635 public_key: "testkey.avbpubkey",
3636 private_key: "testkey.pem",
3637 }
3638
3639 cc_library {
3640 name: "libvndk",
3641 srcs: ["mylib.cpp"],
3642 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003643 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003644 native_bridge_supported: true,
3645 host_supported: true,
3646 vndk: {
3647 enabled: true,
3648 },
3649 system_shared_libs: [],
3650 stl: "none",
3651 }
3652 `)
3653}
3654
Jooyung Han31c470b2019-10-18 16:26:59 +09003655func TestVndkApexWithBinder32(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003656 ctx := testApex(t, `
Jooyung Han31c470b2019-10-18 16:26:59 +09003657 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003658 name: "com.android.vndk.v27",
Jooyung Han31c470b2019-10-18 16:26:59 +09003659 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003660 file_contexts: ":myapex-file_contexts",
Jooyung Han31c470b2019-10-18 16:26:59 +09003661 vndk_version: "27",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003662 updatable: false,
Jooyung Han31c470b2019-10-18 16:26:59 +09003663 }
3664
3665 apex_key {
3666 name: "myapex.key",
3667 public_key: "testkey.avbpubkey",
3668 private_key: "testkey.pem",
3669 }
3670
3671 vndk_prebuilt_shared {
3672 name: "libvndk27",
3673 version: "27",
3674 target_arch: "arm",
3675 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003676 product_available: true,
Jooyung Han31c470b2019-10-18 16:26:59 +09003677 vndk: {
3678 enabled: true,
3679 },
3680 arch: {
3681 arm: {
3682 srcs: ["libvndk27.so"],
3683 }
3684 },
3685 }
3686
3687 vndk_prebuilt_shared {
3688 name: "libvndk27",
3689 version: "27",
3690 target_arch: "arm",
3691 binder32bit: true,
3692 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003693 product_available: true,
Jooyung Han31c470b2019-10-18 16:26:59 +09003694 vndk: {
3695 enabled: true,
3696 },
3697 arch: {
3698 arm: {
3699 srcs: ["libvndk27binder32.so"],
3700 }
3701 },
Colin Cross2807f002021-03-02 10:15:29 -08003702 apex_available: [ "com.android.vndk.v27" ],
Jooyung Han31c470b2019-10-18 16:26:59 +09003703 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003704 `+vndkLibrariesTxtFiles("27"),
Jooyung Han31c470b2019-10-18 16:26:59 +09003705 withFiles(map[string][]byte{
3706 "libvndk27.so": nil,
3707 "libvndk27binder32.so": nil,
3708 }),
3709 withBinder32bit,
3710 withTargets(map[android.OsType][]android.Target{
3711 android.Android: []android.Target{
Jooyung Han35155c42020-02-06 17:33:20 +09003712 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
3713 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
Jooyung Han31c470b2019-10-18 16:26:59 +09003714 },
3715 }),
3716 )
3717
Colin Cross2807f002021-03-02 10:15:29 -08003718 ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003719 "lib/libvndk27binder32.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003720 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003721 })
3722}
3723
Jooyung Han45a96772020-06-15 14:59:42 +09003724func TestVndkApexShouldNotProvideNativeLibs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003725 ctx := testApex(t, `
Jooyung Han45a96772020-06-15 14:59:42 +09003726 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003727 name: "com.android.vndk.current",
3728 key: "com.android.vndk.current.key",
Jooyung Han45a96772020-06-15 14:59:42 +09003729 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003730 updatable: false,
Jooyung Han45a96772020-06-15 14:59:42 +09003731 }
3732
3733 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003734 name: "com.android.vndk.current.key",
Jooyung Han45a96772020-06-15 14:59:42 +09003735 public_key: "testkey.avbpubkey",
3736 private_key: "testkey.pem",
3737 }
3738
3739 cc_library {
3740 name: "libz",
3741 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003742 product_available: true,
Jooyung Han45a96772020-06-15 14:59:42 +09003743 vndk: {
3744 enabled: true,
3745 },
3746 stubs: {
3747 symbol_file: "libz.map.txt",
3748 versions: ["30"],
3749 }
3750 }
3751 `+vndkLibrariesTxtFiles("current"), withFiles(map[string][]byte{
3752 "libz.map.txt": nil,
3753 }))
3754
Colin Cross2807f002021-03-02 10:15:29 -08003755 apexManifestRule := ctx.ModuleForTests("com.android.vndk.current", "android_common_image").Rule("apexManifestRule")
Jooyung Han45a96772020-06-15 14:59:42 +09003756 provideNativeLibs := names(apexManifestRule.Args["provideNativeLibs"])
3757 ensureListEmpty(t, provideNativeLibs)
3758}
3759
Jooyung Hane1633032019-08-01 17:41:43 +09003760func TestDependenciesInApexManifest(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003761 ctx := testApex(t, `
Jooyung Hane1633032019-08-01 17:41:43 +09003762 apex {
3763 name: "myapex_nodep",
3764 key: "myapex.key",
3765 native_shared_libs: ["lib_nodep"],
3766 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003767 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003768 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003769 }
3770
3771 apex {
3772 name: "myapex_dep",
3773 key: "myapex.key",
3774 native_shared_libs: ["lib_dep"],
3775 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003776 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003777 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003778 }
3779
3780 apex {
3781 name: "myapex_provider",
3782 key: "myapex.key",
3783 native_shared_libs: ["libfoo"],
3784 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003785 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003786 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003787 }
3788
3789 apex {
3790 name: "myapex_selfcontained",
3791 key: "myapex.key",
3792 native_shared_libs: ["lib_dep", "libfoo"],
3793 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003794 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003795 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003796 }
3797
3798 apex_key {
3799 name: "myapex.key",
3800 public_key: "testkey.avbpubkey",
3801 private_key: "testkey.pem",
3802 }
3803
3804 cc_library {
3805 name: "lib_nodep",
3806 srcs: ["mylib.cpp"],
3807 system_shared_libs: [],
3808 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003809 apex_available: [ "myapex_nodep" ],
Jooyung Hane1633032019-08-01 17:41:43 +09003810 }
3811
3812 cc_library {
3813 name: "lib_dep",
3814 srcs: ["mylib.cpp"],
3815 shared_libs: ["libfoo"],
3816 system_shared_libs: [],
3817 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003818 apex_available: [
3819 "myapex_dep",
3820 "myapex_provider",
3821 "myapex_selfcontained",
3822 ],
Jooyung Hane1633032019-08-01 17:41:43 +09003823 }
3824
3825 cc_library {
3826 name: "libfoo",
3827 srcs: ["mytest.cpp"],
3828 stubs: {
3829 versions: ["1"],
3830 },
3831 system_shared_libs: [],
3832 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003833 apex_available: [
3834 "myapex_provider",
3835 "myapex_selfcontained",
3836 ],
Jooyung Hane1633032019-08-01 17:41:43 +09003837 }
3838 `)
3839
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003840 var apexManifestRule android.TestingBuildParams
Jooyung Hane1633032019-08-01 17:41:43 +09003841 var provideNativeLibs, requireNativeLibs []string
3842
Sundong Ahnabb64432019-10-22 13:58:29 +09003843 apexManifestRule = ctx.ModuleForTests("myapex_nodep", "android_common_myapex_nodep_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003844 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3845 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003846 ensureListEmpty(t, provideNativeLibs)
3847 ensureListEmpty(t, requireNativeLibs)
3848
Sundong Ahnabb64432019-10-22 13:58:29 +09003849 apexManifestRule = ctx.ModuleForTests("myapex_dep", "android_common_myapex_dep_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003850 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3851 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003852 ensureListEmpty(t, provideNativeLibs)
3853 ensureListContains(t, requireNativeLibs, "libfoo.so")
3854
Sundong Ahnabb64432019-10-22 13:58:29 +09003855 apexManifestRule = ctx.ModuleForTests("myapex_provider", "android_common_myapex_provider_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003856 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3857 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003858 ensureListContains(t, provideNativeLibs, "libfoo.so")
3859 ensureListEmpty(t, requireNativeLibs)
3860
Sundong Ahnabb64432019-10-22 13:58:29 +09003861 apexManifestRule = ctx.ModuleForTests("myapex_selfcontained", "android_common_myapex_selfcontained_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003862 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3863 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003864 ensureListContains(t, provideNativeLibs, "libfoo.so")
3865 ensureListEmpty(t, requireNativeLibs)
3866}
3867
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003868func TestApexName(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003869 ctx := testApex(t, `
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003870 apex {
3871 name: "myapex",
3872 key: "myapex.key",
3873 apex_name: "com.android.myapex",
Jiyong Parkdb334862020-02-05 17:19:28 +09003874 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003875 updatable: false,
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003876 }
3877
3878 apex_key {
3879 name: "myapex.key",
3880 public_key: "testkey.avbpubkey",
3881 private_key: "testkey.pem",
3882 }
Jiyong Parkdb334862020-02-05 17:19:28 +09003883
3884 cc_library {
3885 name: "mylib",
3886 srcs: ["mylib.cpp"],
3887 system_shared_libs: [],
3888 stl: "none",
3889 apex_available: [
3890 "//apex_available:platform",
3891 "myapex",
3892 ],
3893 }
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003894 `)
3895
Sundong Ahnabb64432019-10-22 13:58:29 +09003896 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003897 apexManifestRule := module.Rule("apexManifestRule")
3898 ensureContains(t, apexManifestRule.Args["opt"], "-v name com.android.myapex")
3899 apexRule := module.Rule("apexRule")
3900 ensureContains(t, apexRule.Args["opt_flags"], "--do_not_check_keyname")
Jiyong Parkdb334862020-02-05 17:19:28 +09003901
3902 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07003903 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jiyong Parkdb334862020-02-05 17:19:28 +09003904 name := apexBundle.BaseModuleName()
3905 prefix := "TARGET_"
3906 var builder strings.Builder
3907 data.Custom(&builder, name, prefix, "", data)
3908 androidMk := builder.String()
3909 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
3910 ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003911}
3912
Alex Light0851b882019-02-07 13:20:53 -08003913func TestNonTestApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003914 ctx := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08003915 apex {
3916 name: "myapex",
3917 key: "myapex.key",
3918 native_shared_libs: ["mylib_common"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003919 updatable: false,
Alex Light0851b882019-02-07 13:20:53 -08003920 }
3921
3922 apex_key {
3923 name: "myapex.key",
3924 public_key: "testkey.avbpubkey",
3925 private_key: "testkey.pem",
3926 }
3927
3928 cc_library {
3929 name: "mylib_common",
3930 srcs: ["mylib.cpp"],
3931 system_shared_libs: [],
3932 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003933 apex_available: [
3934 "//apex_available:platform",
3935 "myapex",
3936 ],
Alex Light0851b882019-02-07 13:20:53 -08003937 }
3938 `)
3939
Sundong Ahnabb64432019-10-22 13:58:29 +09003940 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Alex Light0851b882019-02-07 13:20:53 -08003941 apexRule := module.Rule("apexRule")
3942 copyCmds := apexRule.Args["copy_commands"]
3943
3944 if apex, ok := module.Module().(*apexBundle); !ok || apex.testApex {
3945 t.Log("Apex was a test apex!")
3946 t.Fail()
3947 }
3948 // Ensure that main rule creates an output
3949 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
3950
3951 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -07003952 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
Alex Light0851b882019-02-07 13:20:53 -08003953
3954 // Ensure that both direct and indirect deps are copied into apex
3955 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
3956
Colin Cross7113d202019-11-20 16:39:12 -08003957 // Ensure that the platform variant ends with _shared
3958 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
Alex Light0851b882019-02-07 13:20:53 -08003959
Colin Cross56a83212020-09-15 18:30:11 -07003960 if !ctx.ModuleForTests("mylib_common", "android_arm64_armv8-a_shared_apex10000").Module().(*cc.Module).InAnyApex() {
Alex Light0851b882019-02-07 13:20:53 -08003961 t.Log("Found mylib_common not in any apex!")
3962 t.Fail()
3963 }
3964}
3965
3966func TestTestApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003967 ctx := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08003968 apex_test {
3969 name: "myapex",
3970 key: "myapex.key",
3971 native_shared_libs: ["mylib_common_test"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003972 updatable: false,
Alex Light0851b882019-02-07 13:20:53 -08003973 }
3974
3975 apex_key {
3976 name: "myapex.key",
3977 public_key: "testkey.avbpubkey",
3978 private_key: "testkey.pem",
3979 }
3980
3981 cc_library {
3982 name: "mylib_common_test",
3983 srcs: ["mylib.cpp"],
3984 system_shared_libs: [],
3985 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003986 // TODO: remove //apex_available:platform
3987 apex_available: [
3988 "//apex_available:platform",
3989 "myapex",
3990 ],
Alex Light0851b882019-02-07 13:20:53 -08003991 }
3992 `)
3993
Sundong Ahnabb64432019-10-22 13:58:29 +09003994 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Alex Light0851b882019-02-07 13:20:53 -08003995 apexRule := module.Rule("apexRule")
3996 copyCmds := apexRule.Args["copy_commands"]
3997
3998 if apex, ok := module.Module().(*apexBundle); !ok || !apex.testApex {
3999 t.Log("Apex was not a test apex!")
4000 t.Fail()
4001 }
4002 // Ensure that main rule creates an output
4003 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
4004
4005 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -07004006 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared_apex10000")
Alex Light0851b882019-02-07 13:20:53 -08004007
4008 // Ensure that both direct and indirect deps are copied into apex
4009 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common_test.so")
4010
Colin Cross7113d202019-11-20 16:39:12 -08004011 // Ensure that the platform variant ends with _shared
4012 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared")
Alex Light0851b882019-02-07 13:20:53 -08004013}
4014
Alex Light9670d332019-01-29 18:07:33 -08004015func TestApexWithTarget(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004016 ctx := testApex(t, `
Alex Light9670d332019-01-29 18:07:33 -08004017 apex {
4018 name: "myapex",
4019 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004020 updatable: false,
Alex Light9670d332019-01-29 18:07:33 -08004021 multilib: {
4022 first: {
4023 native_shared_libs: ["mylib_common"],
4024 }
4025 },
4026 target: {
4027 android: {
4028 multilib: {
4029 first: {
4030 native_shared_libs: ["mylib"],
4031 }
4032 }
4033 },
4034 host: {
4035 multilib: {
4036 first: {
4037 native_shared_libs: ["mylib2"],
4038 }
4039 }
4040 }
4041 }
4042 }
4043
4044 apex_key {
4045 name: "myapex.key",
4046 public_key: "testkey.avbpubkey",
4047 private_key: "testkey.pem",
4048 }
4049
4050 cc_library {
4051 name: "mylib",
4052 srcs: ["mylib.cpp"],
4053 system_shared_libs: [],
4054 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004055 // TODO: remove //apex_available:platform
4056 apex_available: [
4057 "//apex_available:platform",
4058 "myapex",
4059 ],
Alex Light9670d332019-01-29 18:07:33 -08004060 }
4061
4062 cc_library {
4063 name: "mylib_common",
4064 srcs: ["mylib.cpp"],
4065 system_shared_libs: [],
4066 stl: "none",
4067 compile_multilib: "first",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004068 // TODO: remove //apex_available:platform
4069 apex_available: [
4070 "//apex_available:platform",
4071 "myapex",
4072 ],
Alex Light9670d332019-01-29 18:07:33 -08004073 }
4074
4075 cc_library {
4076 name: "mylib2",
4077 srcs: ["mylib.cpp"],
4078 system_shared_libs: [],
4079 stl: "none",
4080 compile_multilib: "first",
4081 }
4082 `)
4083
Sundong Ahnabb64432019-10-22 13:58:29 +09004084 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Alex Light9670d332019-01-29 18:07:33 -08004085 copyCmds := apexRule.Args["copy_commands"]
4086
4087 // Ensure that main rule creates an output
4088 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
4089
4090 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -07004091 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
4092 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
4093 ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
Alex Light9670d332019-01-29 18:07:33 -08004094
4095 // Ensure that both direct and indirect deps are copied into apex
4096 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
4097 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
4098 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
4099
Colin Cross7113d202019-11-20 16:39:12 -08004100 // Ensure that the platform variant ends with _shared
4101 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
4102 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
4103 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
Alex Light9670d332019-01-29 18:07:33 -08004104}
Jiyong Park04480cf2019-02-06 00:16:29 +09004105
Jiyong Park59140302020-12-14 18:44:04 +09004106func TestApexWithArch(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004107 ctx := testApex(t, `
Jiyong Park59140302020-12-14 18:44:04 +09004108 apex {
4109 name: "myapex",
4110 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004111 updatable: false,
Jiyong Park59140302020-12-14 18:44:04 +09004112 arch: {
4113 arm64: {
4114 native_shared_libs: ["mylib.arm64"],
4115 },
4116 x86_64: {
4117 native_shared_libs: ["mylib.x64"],
4118 },
4119 }
4120 }
4121
4122 apex_key {
4123 name: "myapex.key",
4124 public_key: "testkey.avbpubkey",
4125 private_key: "testkey.pem",
4126 }
4127
4128 cc_library {
4129 name: "mylib.arm64",
4130 srcs: ["mylib.cpp"],
4131 system_shared_libs: [],
4132 stl: "none",
4133 // TODO: remove //apex_available:platform
4134 apex_available: [
4135 "//apex_available:platform",
4136 "myapex",
4137 ],
4138 }
4139
4140 cc_library {
4141 name: "mylib.x64",
4142 srcs: ["mylib.cpp"],
4143 system_shared_libs: [],
4144 stl: "none",
4145 // TODO: remove //apex_available:platform
4146 apex_available: [
4147 "//apex_available:platform",
4148 "myapex",
4149 ],
4150 }
4151 `)
4152
4153 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
4154 copyCmds := apexRule.Args["copy_commands"]
4155
4156 // Ensure that apex variant is created for the direct dep
4157 ensureListContains(t, ctx.ModuleVariantsForTests("mylib.arm64"), "android_arm64_armv8-a_shared_apex10000")
4158 ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib.x64"), "android_arm64_armv8-a_shared_apex10000")
4159
4160 // Ensure that both direct and indirect deps are copied into apex
4161 ensureContains(t, copyCmds, "image.apex/lib64/mylib.arm64.so")
4162 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib.x64.so")
4163}
4164
Jiyong Park04480cf2019-02-06 00:16:29 +09004165func TestApexWithShBinary(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004166 ctx := testApex(t, `
Jiyong Park04480cf2019-02-06 00:16:29 +09004167 apex {
4168 name: "myapex",
4169 key: "myapex.key",
4170 binaries: ["myscript"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004171 updatable: false,
Jiyong Park04480cf2019-02-06 00:16:29 +09004172 }
4173
4174 apex_key {
4175 name: "myapex.key",
4176 public_key: "testkey.avbpubkey",
4177 private_key: "testkey.pem",
4178 }
4179
4180 sh_binary {
4181 name: "myscript",
4182 src: "mylib.cpp",
4183 filename: "myscript.sh",
4184 sub_dir: "script",
4185 }
4186 `)
4187
Sundong Ahnabb64432019-10-22 13:58:29 +09004188 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park04480cf2019-02-06 00:16:29 +09004189 copyCmds := apexRule.Args["copy_commands"]
4190
4191 ensureContains(t, copyCmds, "image.apex/bin/script/myscript.sh")
4192}
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004193
Jooyung Han91df2082019-11-20 01:49:42 +09004194func TestApexInVariousPartition(t *testing.T) {
4195 testcases := []struct {
4196 propName, parition, flattenedPartition string
4197 }{
4198 {"", "system", "system_ext"},
4199 {"product_specific: true", "product", "product"},
4200 {"soc_specific: true", "vendor", "vendor"},
4201 {"proprietary: true", "vendor", "vendor"},
4202 {"vendor: true", "vendor", "vendor"},
4203 {"system_ext_specific: true", "system_ext", "system_ext"},
4204 }
4205 for _, tc := range testcases {
4206 t.Run(tc.propName+":"+tc.parition, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004207 ctx := testApex(t, `
Jooyung Han91df2082019-11-20 01:49:42 +09004208 apex {
4209 name: "myapex",
4210 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004211 updatable: false,
Jooyung Han91df2082019-11-20 01:49:42 +09004212 `+tc.propName+`
4213 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004214
Jooyung Han91df2082019-11-20 01:49:42 +09004215 apex_key {
4216 name: "myapex.key",
4217 public_key: "testkey.avbpubkey",
4218 private_key: "testkey.pem",
4219 }
4220 `)
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004221
Jooyung Han91df2082019-11-20 01:49:42 +09004222 apex := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Paul Duffin37ba3442021-03-29 00:21:08 +01004223 expected := "out/soong/target/product/test_device/" + tc.parition + "/apex"
4224 actual := apex.installDir.RelativeToTop().String()
Jooyung Han91df2082019-11-20 01:49:42 +09004225 if actual != expected {
4226 t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
4227 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004228
Jooyung Han91df2082019-11-20 01:49:42 +09004229 flattened := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
Paul Duffin37ba3442021-03-29 00:21:08 +01004230 expected = "out/soong/target/product/test_device/" + tc.flattenedPartition + "/apex"
4231 actual = flattened.installDir.RelativeToTop().String()
Jooyung Han91df2082019-11-20 01:49:42 +09004232 if actual != expected {
4233 t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
4234 }
4235 })
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004236 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004237}
Jiyong Park67882562019-03-21 01:11:21 +09004238
Jooyung Han580eb4f2020-06-24 19:33:06 +09004239func TestFileContexts_FindInDefaultLocationIfNotSet(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004240 ctx := testApex(t, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004241 apex {
4242 name: "myapex",
4243 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004244 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004245 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004246
Jooyung Han580eb4f2020-06-24 19:33:06 +09004247 apex_key {
4248 name: "myapex.key",
4249 public_key: "testkey.avbpubkey",
4250 private_key: "testkey.pem",
4251 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004252 `)
4253 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Han580eb4f2020-06-24 19:33:06 +09004254 rule := module.Output("file_contexts")
4255 ensureContains(t, rule.RuleParams.Command, "cat system/sepolicy/apex/myapex-file_contexts")
4256}
Jooyung Han54aca7b2019-11-20 02:26:02 +09004257
Jooyung Han580eb4f2020-06-24 19:33:06 +09004258func TestFileContexts_ShouldBeUnderSystemSepolicyForSystemApexes(t *testing.T) {
Jooyung Han54aca7b2019-11-20 02:26:02 +09004259 testApexError(t, `"myapex" .*: file_contexts: should be under system/sepolicy`, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004260 apex {
4261 name: "myapex",
4262 key: "myapex.key",
4263 file_contexts: "my_own_file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004264 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004265 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004266
Jooyung Han580eb4f2020-06-24 19:33:06 +09004267 apex_key {
4268 name: "myapex.key",
4269 public_key: "testkey.avbpubkey",
4270 private_key: "testkey.pem",
4271 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004272 `, withFiles(map[string][]byte{
4273 "my_own_file_contexts": nil,
4274 }))
Jooyung Han580eb4f2020-06-24 19:33:06 +09004275}
Jooyung Han54aca7b2019-11-20 02:26:02 +09004276
Jooyung Han580eb4f2020-06-24 19:33:06 +09004277func TestFileContexts_ProductSpecificApexes(t *testing.T) {
Jooyung Han54aca7b2019-11-20 02:26:02 +09004278 testApexError(t, `"myapex" .*: file_contexts: cannot find`, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004279 apex {
4280 name: "myapex",
4281 key: "myapex.key",
4282 product_specific: true,
4283 file_contexts: "product_specific_file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004284 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004285 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004286
Jooyung Han580eb4f2020-06-24 19:33:06 +09004287 apex_key {
4288 name: "myapex.key",
4289 public_key: "testkey.avbpubkey",
4290 private_key: "testkey.pem",
4291 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004292 `)
4293
Colin Cross1c460562021-02-16 17:55:47 -08004294 ctx := testApex(t, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004295 apex {
4296 name: "myapex",
4297 key: "myapex.key",
4298 product_specific: true,
4299 file_contexts: "product_specific_file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004300 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004301 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004302
Jooyung Han580eb4f2020-06-24 19:33:06 +09004303 apex_key {
4304 name: "myapex.key",
4305 public_key: "testkey.avbpubkey",
4306 private_key: "testkey.pem",
4307 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004308 `, withFiles(map[string][]byte{
4309 "product_specific_file_contexts": nil,
4310 }))
Jooyung Han580eb4f2020-06-24 19:33:06 +09004311 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
4312 rule := module.Output("file_contexts")
4313 ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
4314}
Jooyung Han54aca7b2019-11-20 02:26:02 +09004315
Jooyung Han580eb4f2020-06-24 19:33:06 +09004316func TestFileContexts_SetViaFileGroup(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004317 ctx := testApex(t, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004318 apex {
4319 name: "myapex",
4320 key: "myapex.key",
4321 product_specific: true,
4322 file_contexts: ":my-file-contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004323 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004324 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004325
Jooyung Han580eb4f2020-06-24 19:33:06 +09004326 apex_key {
4327 name: "myapex.key",
4328 public_key: "testkey.avbpubkey",
4329 private_key: "testkey.pem",
4330 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004331
Jooyung Han580eb4f2020-06-24 19:33:06 +09004332 filegroup {
4333 name: "my-file-contexts",
4334 srcs: ["product_specific_file_contexts"],
4335 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004336 `, withFiles(map[string][]byte{
4337 "product_specific_file_contexts": nil,
4338 }))
Jooyung Han580eb4f2020-06-24 19:33:06 +09004339 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
4340 rule := module.Output("file_contexts")
4341 ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
Jooyung Han54aca7b2019-11-20 02:26:02 +09004342}
4343
Jiyong Park67882562019-03-21 01:11:21 +09004344func TestApexKeyFromOtherModule(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004345 ctx := testApex(t, `
Jiyong Park67882562019-03-21 01:11:21 +09004346 apex_key {
4347 name: "myapex.key",
4348 public_key: ":my.avbpubkey",
4349 private_key: ":my.pem",
4350 product_specific: true,
4351 }
4352
4353 filegroup {
4354 name: "my.avbpubkey",
4355 srcs: ["testkey2.avbpubkey"],
4356 }
4357
4358 filegroup {
4359 name: "my.pem",
4360 srcs: ["testkey2.pem"],
4361 }
4362 `)
4363
4364 apex_key := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
4365 expected_pubkey := "testkey2.avbpubkey"
Jaewoong Jung18aefc12020-12-21 09:11:10 -08004366 actual_pubkey := apex_key.publicKeyFile.String()
Jiyong Park67882562019-03-21 01:11:21 +09004367 if actual_pubkey != expected_pubkey {
4368 t.Errorf("wrong public key path. expected %q. actual %q", expected_pubkey, actual_pubkey)
4369 }
4370 expected_privkey := "testkey2.pem"
Jaewoong Jung18aefc12020-12-21 09:11:10 -08004371 actual_privkey := apex_key.privateKeyFile.String()
Jiyong Park67882562019-03-21 01:11:21 +09004372 if actual_privkey != expected_privkey {
4373 t.Errorf("wrong private key path. expected %q. actual %q", expected_privkey, actual_privkey)
4374 }
4375}
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004376
4377func TestPrebuilt(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004378 ctx := testApex(t, `
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004379 prebuilt_apex {
4380 name: "myapex",
Jiyong Parkc95714e2019-03-29 14:23:10 +09004381 arch: {
4382 arm64: {
4383 src: "myapex-arm64.apex",
4384 },
4385 arm: {
4386 src: "myapex-arm.apex",
4387 },
4388 },
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004389 }
4390 `)
4391
Paul Duffin6717d882021-06-15 19:09:41 +01004392 prebuilt := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt)
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004393
Jiyong Parkc95714e2019-03-29 14:23:10 +09004394 expectedInput := "myapex-arm64.apex"
4395 if prebuilt.inputApex.String() != expectedInput {
4396 t.Errorf("inputApex invalid. expected: %q, actual: %q", expectedInput, prebuilt.inputApex.String())
4397 }
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004398}
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004399
Paul Duffinc0609c62021-03-01 17:27:16 +00004400func TestPrebuiltMissingSrc(t *testing.T) {
Paul Duffin6717d882021-06-15 19:09:41 +01004401 testApexError(t, `module "myapex" variant "android_common_myapex".*: prebuilt_apex does not support "arm64_armv8-a"`, `
Paul Duffinc0609c62021-03-01 17:27:16 +00004402 prebuilt_apex {
4403 name: "myapex",
4404 }
4405 `)
4406}
4407
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004408func TestPrebuiltFilenameOverride(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004409 ctx := testApex(t, `
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004410 prebuilt_apex {
4411 name: "myapex",
4412 src: "myapex-arm.apex",
4413 filename: "notmyapex.apex",
4414 }
4415 `)
4416
Paul Duffin6717d882021-06-15 19:09:41 +01004417 p := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt)
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004418
4419 expected := "notmyapex.apex"
4420 if p.installFilename != expected {
4421 t.Errorf("installFilename invalid. expected: %q, actual: %q", expected, p.installFilename)
4422 }
4423}
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07004424
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004425func TestPrebuiltOverrides(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004426 ctx := testApex(t, `
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004427 prebuilt_apex {
4428 name: "myapex.prebuilt",
4429 src: "myapex-arm.apex",
4430 overrides: [
4431 "myapex",
4432 ],
4433 }
4434 `)
4435
Paul Duffin6717d882021-06-15 19:09:41 +01004436 p := ctx.ModuleForTests("myapex.prebuilt", "android_common_myapex.prebuilt").Module().(*Prebuilt)
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004437
4438 expected := []string{"myapex"}
Colin Crossaa255532020-07-03 13:18:24 -07004439 actual := android.AndroidMkEntriesForTest(t, ctx, p)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004440 if !reflect.DeepEqual(actual, expected) {
Jiyong Parkb0a012c2019-11-14 17:17:03 +09004441 t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES value '%s', expected '%s'", actual, expected)
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004442 }
4443}
4444
Paul Duffin092153d2021-01-26 11:42:39 +00004445// These tests verify that the prebuilt_apex/deapexer to java_import wiring allows for the
4446// propagation of paths to dex implementation jars from the former to the latter.
Paul Duffin064b70c2020-11-02 17:32:38 +00004447func TestPrebuiltExportDexImplementationJars(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01004448 transform := android.NullFixturePreparer
Paul Duffin064b70c2020-11-02 17:32:38 +00004449
Paul Duffin89886cb2021-02-05 16:44:03 +00004450 checkDexJarBuildPath := func(t *testing.T, ctx *android.TestContext, name string) {
Paul Duffin064b70c2020-11-02 17:32:38 +00004451 // Make sure the import has been given the correct path to the dex jar.
Colin Crossdcf71b22021-02-01 13:59:03 -08004452 p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency)
Paul Duffin064b70c2020-11-02 17:32:38 +00004453 dexJarBuildPath := p.DexJarBuildPath()
Paul Duffin39853512021-02-26 11:09:39 +00004454 stem := android.RemoveOptionalPrebuiltPrefix(name)
4455 if expected, actual := ".intermediates/myapex.deapexer/android_common/deapexer/javalib/"+stem+".jar", android.NormalizePathForTesting(dexJarBuildPath); actual != expected {
Paul Duffin064b70c2020-11-02 17:32:38 +00004456 t.Errorf("Incorrect DexJarBuildPath value '%s', expected '%s'", actual, expected)
4457 }
4458 }
4459
Paul Duffin39853512021-02-26 11:09:39 +00004460 ensureNoSourceVariant := func(t *testing.T, ctx *android.TestContext, name string) {
Paul Duffin064b70c2020-11-02 17:32:38 +00004461 // Make sure that an apex variant is not created for the source module.
Paul Duffin39853512021-02-26 11:09:39 +00004462 if expected, actual := []string{"android_common"}, ctx.ModuleVariantsForTests(name); !reflect.DeepEqual(expected, actual) {
Paul Duffin064b70c2020-11-02 17:32:38 +00004463 t.Errorf("invalid set of variants for %q: expected %q, found %q", "libfoo", expected, actual)
4464 }
4465 }
4466
4467 t.Run("prebuilt only", func(t *testing.T) {
4468 bp := `
4469 prebuilt_apex {
4470 name: "myapex",
4471 arch: {
4472 arm64: {
4473 src: "myapex-arm64.apex",
4474 },
4475 arm: {
4476 src: "myapex-arm.apex",
4477 },
4478 },
Paul Duffin39853512021-02-26 11:09:39 +00004479 exported_java_libs: ["libfoo", "libbar"],
Paul Duffin064b70c2020-11-02 17:32:38 +00004480 }
4481
4482 java_import {
4483 name: "libfoo",
4484 jars: ["libfoo.jar"],
4485 }
Paul Duffin39853512021-02-26 11:09:39 +00004486
4487 java_sdk_library_import {
4488 name: "libbar",
4489 public: {
4490 jars: ["libbar.jar"],
4491 },
4492 }
Paul Duffin064b70c2020-11-02 17:32:38 +00004493 `
4494
4495 // Make sure that dexpreopt can access dex implementation files from the prebuilt.
4496 ctx := testDexpreoptWithApexes(t, bp, "", transform)
4497
Paul Duffinf6932af2021-02-26 18:21:56 +00004498 // Make sure that the deapexer has the correct input APEX.
4499 deapexer := ctx.ModuleForTests("myapex.deapexer", "android_common")
4500 rule := deapexer.Rule("deapexer")
4501 if expected, actual := []string{"myapex-arm64.apex"}, android.NormalizePathsForTesting(rule.Implicits); !reflect.DeepEqual(expected, actual) {
4502 t.Errorf("expected: %q, found: %q", expected, actual)
4503 }
4504
Paul Duffin0d10c3c2021-03-01 17:09:32 +00004505 // Make sure that the prebuilt_apex has the correct input APEX.
Paul Duffin6717d882021-06-15 19:09:41 +01004506 prebuiltApex := ctx.ModuleForTests("myapex", "android_common_myapex")
Paul Duffin0d10c3c2021-03-01 17:09:32 +00004507 rule = prebuiltApex.Rule("android/soong/android.Cp")
4508 if expected, actual := "myapex-arm64.apex", android.NormalizePathForTesting(rule.Input); !reflect.DeepEqual(expected, actual) {
4509 t.Errorf("expected: %q, found: %q", expected, actual)
4510 }
4511
Paul Duffin89886cb2021-02-05 16:44:03 +00004512 checkDexJarBuildPath(t, ctx, "libfoo")
Paul Duffin39853512021-02-26 11:09:39 +00004513
4514 checkDexJarBuildPath(t, ctx, "libbar")
Paul Duffin064b70c2020-11-02 17:32:38 +00004515 })
4516
4517 t.Run("prebuilt with source preferred", func(t *testing.T) {
4518
4519 bp := `
4520 prebuilt_apex {
4521 name: "myapex",
4522 arch: {
4523 arm64: {
4524 src: "myapex-arm64.apex",
4525 },
4526 arm: {
4527 src: "myapex-arm.apex",
4528 },
4529 },
Paul Duffin39853512021-02-26 11:09:39 +00004530 exported_java_libs: ["libfoo", "libbar"],
Paul Duffin064b70c2020-11-02 17:32:38 +00004531 }
4532
4533 java_import {
4534 name: "libfoo",
4535 jars: ["libfoo.jar"],
4536 }
4537
4538 java_library {
4539 name: "libfoo",
4540 }
Paul Duffin39853512021-02-26 11:09:39 +00004541
4542 java_sdk_library_import {
4543 name: "libbar",
4544 public: {
4545 jars: ["libbar.jar"],
4546 },
4547 }
4548
4549 java_sdk_library {
4550 name: "libbar",
4551 srcs: ["foo/bar/MyClass.java"],
4552 unsafe_ignore_missing_latest_api: true,
4553 }
Paul Duffin064b70c2020-11-02 17:32:38 +00004554 `
4555
4556 // Make sure that dexpreopt can access dex implementation files from the prebuilt.
4557 ctx := testDexpreoptWithApexes(t, bp, "", transform)
4558
Paul Duffin89886cb2021-02-05 16:44:03 +00004559 checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
Paul Duffin39853512021-02-26 11:09:39 +00004560 ensureNoSourceVariant(t, ctx, "libfoo")
4561
4562 checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
4563 ensureNoSourceVariant(t, ctx, "libbar")
Paul Duffin064b70c2020-11-02 17:32:38 +00004564 })
4565
4566 t.Run("prebuilt preferred with source", func(t *testing.T) {
4567 bp := `
4568 prebuilt_apex {
4569 name: "myapex",
Paul Duffin064b70c2020-11-02 17:32:38 +00004570 arch: {
4571 arm64: {
4572 src: "myapex-arm64.apex",
4573 },
4574 arm: {
4575 src: "myapex-arm.apex",
4576 },
4577 },
Paul Duffin39853512021-02-26 11:09:39 +00004578 exported_java_libs: ["libfoo", "libbar"],
Paul Duffin064b70c2020-11-02 17:32:38 +00004579 }
4580
4581 java_import {
4582 name: "libfoo",
Paul Duffin092153d2021-01-26 11:42:39 +00004583 prefer: true,
Paul Duffin064b70c2020-11-02 17:32:38 +00004584 jars: ["libfoo.jar"],
4585 }
4586
4587 java_library {
4588 name: "libfoo",
4589 }
Paul Duffin39853512021-02-26 11:09:39 +00004590
4591 java_sdk_library_import {
4592 name: "libbar",
4593 prefer: true,
4594 public: {
4595 jars: ["libbar.jar"],
4596 },
4597 }
4598
4599 java_sdk_library {
4600 name: "libbar",
4601 srcs: ["foo/bar/MyClass.java"],
4602 unsafe_ignore_missing_latest_api: true,
4603 }
Paul Duffin064b70c2020-11-02 17:32:38 +00004604 `
4605
4606 // Make sure that dexpreopt can access dex implementation files from the prebuilt.
4607 ctx := testDexpreoptWithApexes(t, bp, "", transform)
4608
Paul Duffin89886cb2021-02-05 16:44:03 +00004609 checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
Paul Duffin39853512021-02-26 11:09:39 +00004610 ensureNoSourceVariant(t, ctx, "libfoo")
4611
4612 checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
4613 ensureNoSourceVariant(t, ctx, "libbar")
Paul Duffin064b70c2020-11-02 17:32:38 +00004614 })
4615}
4616
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004617func TestBootDexJarsFromSourcesAndPrebuilts(t *testing.T) {
Paul Duffinb6f53c02021-05-14 07:52:42 +01004618 preparer := android.GroupFixturePreparers(
4619 java.FixtureConfigureBootJars("myapex:libfoo", "myapex:libbar"),
4620 // Make sure that the frameworks/base/Android.bp file exists as otherwise hidden API encoding
4621 // is disabled.
4622 android.FixtureAddTextFile("frameworks/base/Android.bp", ""),
4623 )
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004624
Paul Duffin37856732021-02-26 14:24:15 +00004625 checkBootDexJarPath := func(t *testing.T, ctx *android.TestContext, stem string, bootDexJarPath string) {
4626 t.Helper()
Paul Duffin7ebebfd2021-04-27 19:36:57 +01004627 s := ctx.ModuleForTests("platform-bootclasspath", "android_common")
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004628 foundLibfooJar := false
Paul Duffin37856732021-02-26 14:24:15 +00004629 base := stem + ".jar"
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004630 for _, output := range s.AllOutputs() {
Paul Duffin37856732021-02-26 14:24:15 +00004631 if filepath.Base(output) == base {
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004632 foundLibfooJar = true
4633 buildRule := s.Output(output)
Paul Duffin55607122021-03-30 23:32:51 +01004634 android.AssertStringEquals(t, "boot dex jar path", bootDexJarPath, buildRule.Input.String())
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004635 }
4636 }
4637 if !foundLibfooJar {
Paul Duffin55607122021-03-30 23:32:51 +01004638 t.Errorf("Rule for libfoo.jar missing in dex_bootjars singleton outputs %q", android.StringPathsRelativeToTop(ctx.Config().BuildDir(), s.AllOutputs()))
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004639 }
4640 }
4641
Paul Duffin4fd997b2021-02-03 20:06:33 +00004642 checkHiddenAPIIndexInputs := func(t *testing.T, ctx *android.TestContext, expectedInputs string) {
Paul Duffin37856732021-02-26 14:24:15 +00004643 t.Helper()
Paul Duffin00b2bfd2021-04-12 17:24:36 +01004644 platformBootclasspath := ctx.ModuleForTests("platform-bootclasspath", "android_common")
Paul Duffin537ea3d2021-05-14 10:38:00 +01004645 indexRule := platformBootclasspath.Rule("monolithic_hidden_API_index")
Paul Duffin4fd997b2021-02-03 20:06:33 +00004646 java.CheckHiddenAPIRuleInputs(t, expectedInputs, indexRule)
4647 }
4648
Paul Duffin89f570a2021-06-16 01:42:33 +01004649 fragment := java.ApexVariantReference{
4650 Apex: proptools.StringPtr("myapex"),
4651 Module: proptools.StringPtr("my-bootclasspath-fragment"),
4652 }
4653
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004654 t.Run("prebuilt only", func(t *testing.T) {
4655 bp := `
4656 prebuilt_apex {
4657 name: "myapex",
4658 arch: {
4659 arm64: {
4660 src: "myapex-arm64.apex",
4661 },
4662 arm: {
4663 src: "myapex-arm.apex",
4664 },
4665 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004666 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4667 }
4668
4669 prebuilt_bootclasspath_fragment {
4670 name: "my-bootclasspath-fragment",
4671 contents: ["libfoo", "libbar"],
4672 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004673 }
4674
4675 java_import {
4676 name: "libfoo",
4677 jars: ["libfoo.jar"],
4678 apex_available: ["myapex"],
4679 }
Paul Duffin37856732021-02-26 14:24:15 +00004680
4681 java_sdk_library_import {
4682 name: "libbar",
4683 public: {
4684 jars: ["libbar.jar"],
4685 },
4686 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004687 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00004688 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004689 `
4690
Paul Duffin89f570a2021-06-16 01:42:33 +01004691 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01004692 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
4693 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00004694
Paul Duffin537ea3d2021-05-14 10:38:00 +01004695 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin9d67ca62021-02-03 20:06:33 +00004696 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin537ea3d2021-05-14 10:38:00 +01004697.intermediates/libbar.stubs/android_common/combined/libbar.stubs.jar
4698.intermediates/libfoo/android_common_myapex/combined/libfoo.jar
Paul Duffin9d67ca62021-02-03 20:06:33 +00004699`)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004700 })
4701
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004702 t.Run("apex_set only", func(t *testing.T) {
4703 bp := `
4704 apex_set {
4705 name: "myapex",
4706 set: "myapex.apks",
Paul Duffin89f570a2021-06-16 01:42:33 +01004707 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4708 }
4709
4710 prebuilt_bootclasspath_fragment {
4711 name: "my-bootclasspath-fragment",
4712 contents: ["libfoo", "libbar"],
4713 apex_available: ["myapex"],
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004714 }
4715
4716 java_import {
4717 name: "libfoo",
4718 jars: ["libfoo.jar"],
4719 apex_available: ["myapex"],
4720 }
4721
4722 java_sdk_library_import {
4723 name: "libbar",
4724 public: {
4725 jars: ["libbar.jar"],
4726 },
4727 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004728 shared_library: false,
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004729 }
4730 `
4731
Paul Duffin89f570a2021-06-16 01:42:33 +01004732 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004733 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
4734 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
4735
Paul Duffin537ea3d2021-05-14 10:38:00 +01004736 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004737 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin537ea3d2021-05-14 10:38:00 +01004738.intermediates/libbar.stubs/android_common/combined/libbar.stubs.jar
4739.intermediates/libfoo/android_common_myapex/combined/libfoo.jar
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004740`)
4741 })
4742
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004743 t.Run("prebuilt with source library preferred", func(t *testing.T) {
4744 bp := `
4745 prebuilt_apex {
4746 name: "myapex",
4747 arch: {
4748 arm64: {
4749 src: "myapex-arm64.apex",
4750 },
4751 arm: {
4752 src: "myapex-arm.apex",
4753 },
4754 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004755 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4756 }
4757
4758 prebuilt_bootclasspath_fragment {
4759 name: "my-bootclasspath-fragment",
4760 contents: ["libfoo", "libbar"],
4761 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004762 }
4763
4764 java_import {
4765 name: "libfoo",
4766 jars: ["libfoo.jar"],
4767 apex_available: ["myapex"],
4768 }
4769
4770 java_library {
4771 name: "libfoo",
4772 srcs: ["foo/bar/MyClass.java"],
4773 apex_available: ["myapex"],
4774 }
Paul Duffin37856732021-02-26 14:24:15 +00004775
4776 java_sdk_library_import {
4777 name: "libbar",
4778 public: {
4779 jars: ["libbar.jar"],
4780 },
4781 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004782 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00004783 }
4784
4785 java_sdk_library {
4786 name: "libbar",
4787 srcs: ["foo/bar/MyClass.java"],
4788 unsafe_ignore_missing_latest_api: true,
4789 apex_available: ["myapex"],
4790 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004791 `
4792
4793 // In this test the source (java_library) libfoo is active since the
4794 // prebuilt (java_import) defaults to prefer:false. However the
4795 // prebuilt_apex module always depends on the prebuilt, and so it doesn't
4796 // find the dex boot jar in it. We either need to disable the source libfoo
4797 // or make the prebuilt libfoo preferred.
Paul Duffin89f570a2021-06-16 01:42:33 +01004798 testDexpreoptWithApexes(t, bp, "module libfoo does not provide a dex boot jar", preparer, fragment)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004799 })
4800
4801 t.Run("prebuilt library preferred with source", func(t *testing.T) {
4802 bp := `
4803 prebuilt_apex {
4804 name: "myapex",
4805 arch: {
4806 arm64: {
4807 src: "myapex-arm64.apex",
4808 },
4809 arm: {
4810 src: "myapex-arm.apex",
4811 },
4812 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004813 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4814 }
4815
4816 prebuilt_bootclasspath_fragment {
4817 name: "my-bootclasspath-fragment",
4818 contents: ["libfoo", "libbar"],
4819 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004820 }
4821
4822 java_import {
4823 name: "libfoo",
4824 prefer: true,
4825 jars: ["libfoo.jar"],
4826 apex_available: ["myapex"],
4827 }
4828
4829 java_library {
4830 name: "libfoo",
4831 srcs: ["foo/bar/MyClass.java"],
4832 apex_available: ["myapex"],
4833 }
Paul Duffin37856732021-02-26 14:24:15 +00004834
4835 java_sdk_library_import {
4836 name: "libbar",
4837 prefer: true,
4838 public: {
4839 jars: ["libbar.jar"],
4840 },
4841 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004842 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00004843 }
4844
4845 java_sdk_library {
4846 name: "libbar",
4847 srcs: ["foo/bar/MyClass.java"],
4848 unsafe_ignore_missing_latest_api: true,
4849 apex_available: ["myapex"],
4850 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004851 `
4852
Paul Duffin89f570a2021-06-16 01:42:33 +01004853 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01004854 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
4855 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00004856
Paul Duffin537ea3d2021-05-14 10:38:00 +01004857 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin9d67ca62021-02-03 20:06:33 +00004858 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin537ea3d2021-05-14 10:38:00 +01004859.intermediates/prebuilt_libbar.stubs/android_common/combined/libbar.stubs.jar
4860.intermediates/prebuilt_libfoo/android_common_myapex/combined/libfoo.jar
Paul Duffin9d67ca62021-02-03 20:06:33 +00004861`)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004862 })
4863
4864 t.Run("prebuilt with source apex preferred", func(t *testing.T) {
4865 bp := `
4866 apex {
4867 name: "myapex",
4868 key: "myapex.key",
Paul Duffin37856732021-02-26 14:24:15 +00004869 java_libs: ["libfoo", "libbar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004870 updatable: false,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004871 }
4872
4873 apex_key {
4874 name: "myapex.key",
4875 public_key: "testkey.avbpubkey",
4876 private_key: "testkey.pem",
4877 }
4878
4879 prebuilt_apex {
4880 name: "myapex",
4881 arch: {
4882 arm64: {
4883 src: "myapex-arm64.apex",
4884 },
4885 arm: {
4886 src: "myapex-arm.apex",
4887 },
4888 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004889 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4890 }
4891
4892 prebuilt_bootclasspath_fragment {
4893 name: "my-bootclasspath-fragment",
4894 contents: ["libfoo", "libbar"],
4895 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004896 }
4897
4898 java_import {
4899 name: "libfoo",
4900 jars: ["libfoo.jar"],
4901 apex_available: ["myapex"],
4902 }
4903
4904 java_library {
4905 name: "libfoo",
4906 srcs: ["foo/bar/MyClass.java"],
4907 apex_available: ["myapex"],
4908 }
Paul Duffin37856732021-02-26 14:24:15 +00004909
4910 java_sdk_library_import {
4911 name: "libbar",
4912 public: {
4913 jars: ["libbar.jar"],
4914 },
4915 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004916 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00004917 }
4918
4919 java_sdk_library {
4920 name: "libbar",
4921 srcs: ["foo/bar/MyClass.java"],
4922 unsafe_ignore_missing_latest_api: true,
4923 apex_available: ["myapex"],
4924 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004925 `
4926
Paul Duffin89f570a2021-06-16 01:42:33 +01004927 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01004928 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/libfoo/android_common_apex10000/hiddenapi/libfoo.jar")
4929 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/libbar/android_common_myapex/hiddenapi/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00004930
Paul Duffin537ea3d2021-05-14 10:38:00 +01004931 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin4fd997b2021-02-03 20:06:33 +00004932 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin537ea3d2021-05-14 10:38:00 +01004933.intermediates/libbar/android_common_myapex/javac/libbar.jar
4934.intermediates/libfoo/android_common_apex10000/javac/libfoo.jar
Paul Duffin4fd997b2021-02-03 20:06:33 +00004935`)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004936 })
4937
4938 t.Run("prebuilt preferred with source apex disabled", func(t *testing.T) {
4939 bp := `
4940 apex {
4941 name: "myapex",
4942 enabled: false,
4943 key: "myapex.key",
Paul Duffin8f146b92021-04-12 17:24:18 +01004944 java_libs: ["libfoo", "libbar"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004945 }
4946
4947 apex_key {
4948 name: "myapex.key",
4949 public_key: "testkey.avbpubkey",
4950 private_key: "testkey.pem",
4951 }
4952
4953 prebuilt_apex {
4954 name: "myapex",
4955 arch: {
4956 arm64: {
4957 src: "myapex-arm64.apex",
4958 },
4959 arm: {
4960 src: "myapex-arm.apex",
4961 },
4962 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004963 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4964 }
4965
4966 prebuilt_bootclasspath_fragment {
4967 name: "my-bootclasspath-fragment",
4968 contents: ["libfoo", "libbar"],
4969 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004970 }
4971
4972 java_import {
4973 name: "libfoo",
4974 prefer: true,
4975 jars: ["libfoo.jar"],
4976 apex_available: ["myapex"],
4977 }
4978
4979 java_library {
4980 name: "libfoo",
4981 srcs: ["foo/bar/MyClass.java"],
4982 apex_available: ["myapex"],
4983 }
Paul Duffin37856732021-02-26 14:24:15 +00004984
4985 java_sdk_library_import {
4986 name: "libbar",
4987 prefer: true,
4988 public: {
4989 jars: ["libbar.jar"],
4990 },
4991 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004992 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00004993 }
4994
4995 java_sdk_library {
4996 name: "libbar",
4997 srcs: ["foo/bar/MyClass.java"],
4998 unsafe_ignore_missing_latest_api: true,
4999 apex_available: ["myapex"],
5000 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005001 `
5002
Paul Duffin89f570a2021-06-16 01:42:33 +01005003 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01005004 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
5005 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00005006
Paul Duffin537ea3d2021-05-14 10:38:00 +01005007 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin9d67ca62021-02-03 20:06:33 +00005008 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin537ea3d2021-05-14 10:38:00 +01005009.intermediates/prebuilt_libbar.stubs/android_common/combined/libbar.stubs.jar
5010.intermediates/prebuilt_libfoo/android_common_myapex/combined/libfoo.jar
Paul Duffin9d67ca62021-02-03 20:06:33 +00005011`)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005012 })
5013}
5014
Roland Levillain630846d2019-06-26 12:48:34 +01005015func TestApexWithTests(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005016 ctx := testApex(t, `
Roland Levillain630846d2019-06-26 12:48:34 +01005017 apex_test {
5018 name: "myapex",
5019 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005020 updatable: false,
Roland Levillain630846d2019-06-26 12:48:34 +01005021 tests: [
5022 "mytest",
Roland Levillain9b5fde92019-06-28 15:41:19 +01005023 "mytests",
Roland Levillain630846d2019-06-26 12:48:34 +01005024 ],
5025 }
5026
5027 apex_key {
5028 name: "myapex.key",
5029 public_key: "testkey.avbpubkey",
5030 private_key: "testkey.pem",
5031 }
5032
Liz Kammer1c14a212020-05-12 15:26:55 -07005033 filegroup {
5034 name: "fg",
5035 srcs: [
5036 "baz",
5037 "bar/baz"
5038 ],
5039 }
5040
Roland Levillain630846d2019-06-26 12:48:34 +01005041 cc_test {
5042 name: "mytest",
5043 gtest: false,
5044 srcs: ["mytest.cpp"],
5045 relative_install_path: "test",
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005046 shared_libs: ["mylib"],
Roland Levillain630846d2019-06-26 12:48:34 +01005047 system_shared_libs: [],
5048 static_executable: true,
5049 stl: "none",
Liz Kammer1c14a212020-05-12 15:26:55 -07005050 data: [":fg"],
Roland Levillain630846d2019-06-26 12:48:34 +01005051 }
Roland Levillain9b5fde92019-06-28 15:41:19 +01005052
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005053 cc_library {
5054 name: "mylib",
5055 srcs: ["mylib.cpp"],
5056 system_shared_libs: [],
5057 stl: "none",
5058 }
5059
Liz Kammer5bd365f2020-05-27 15:15:11 -07005060 filegroup {
5061 name: "fg2",
5062 srcs: [
5063 "testdata/baz"
5064 ],
5065 }
5066
Roland Levillain9b5fde92019-06-28 15:41:19 +01005067 cc_test {
5068 name: "mytests",
5069 gtest: false,
5070 srcs: [
5071 "mytest1.cpp",
5072 "mytest2.cpp",
5073 "mytest3.cpp",
5074 ],
5075 test_per_src: true,
5076 relative_install_path: "test",
5077 system_shared_libs: [],
5078 static_executable: true,
5079 stl: "none",
Liz Kammer5bd365f2020-05-27 15:15:11 -07005080 data: [
5081 ":fg",
5082 ":fg2",
5083 ],
Roland Levillain9b5fde92019-06-28 15:41:19 +01005084 }
Roland Levillain630846d2019-06-26 12:48:34 +01005085 `)
5086
Sundong Ahnabb64432019-10-22 13:58:29 +09005087 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Roland Levillain630846d2019-06-26 12:48:34 +01005088 copyCmds := apexRule.Args["copy_commands"]
5089
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005090 // Ensure that test dep (and their transitive dependencies) are copied into apex.
Roland Levillain630846d2019-06-26 12:48:34 +01005091 ensureContains(t, copyCmds, "image.apex/bin/test/mytest")
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005092 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Roland Levillain9b5fde92019-06-28 15:41:19 +01005093
Liz Kammer1c14a212020-05-12 15:26:55 -07005094 //Ensure that test data are copied into apex.
5095 ensureContains(t, copyCmds, "image.apex/bin/test/baz")
5096 ensureContains(t, copyCmds, "image.apex/bin/test/bar/baz")
5097
Roland Levillain9b5fde92019-06-28 15:41:19 +01005098 // Ensure that test deps built with `test_per_src` are copied into apex.
5099 ensureContains(t, copyCmds, "image.apex/bin/test/mytest1")
5100 ensureContains(t, copyCmds, "image.apex/bin/test/mytest2")
5101 ensureContains(t, copyCmds, "image.apex/bin/test/mytest3")
Roland Levillainf89cd092019-07-29 16:22:59 +01005102
5103 // Ensure the module is correctly translated.
Liz Kammer81faaaf2020-05-20 09:57:08 -07005104 bundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07005105 data := android.AndroidMkDataForTest(t, ctx, bundle)
Liz Kammer81faaaf2020-05-20 09:57:08 -07005106 name := bundle.BaseModuleName()
Roland Levillainf89cd092019-07-29 16:22:59 +01005107 prefix := "TARGET_"
5108 var builder strings.Builder
5109 data.Custom(&builder, name, prefix, "", data)
5110 androidMk := builder.String()
Jooyung Han31c470b2019-10-18 16:26:59 +09005111 ensureContains(t, androidMk, "LOCAL_MODULE := mytest.myapex\n")
5112 ensureContains(t, androidMk, "LOCAL_MODULE := mytest1.myapex\n")
5113 ensureContains(t, androidMk, "LOCAL_MODULE := mytest2.myapex\n")
5114 ensureContains(t, androidMk, "LOCAL_MODULE := mytest3.myapex\n")
Jooyung Han214bf372019-11-12 13:03:50 +09005115 ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex\n")
Jooyung Han31c470b2019-10-18 16:26:59 +09005116 ensureContains(t, androidMk, "LOCAL_MODULE := apex_pubkey.myapex\n")
Roland Levillainf89cd092019-07-29 16:22:59 +01005117 ensureContains(t, androidMk, "LOCAL_MODULE := myapex\n")
Liz Kammer81faaaf2020-05-20 09:57:08 -07005118
5119 flatBundle := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07005120 data = android.AndroidMkDataForTest(t, ctx, flatBundle)
Liz Kammer81faaaf2020-05-20 09:57:08 -07005121 data.Custom(&builder, name, prefix, "", data)
5122 flatAndroidMk := builder.String()
Liz Kammer5bd365f2020-05-27 15:15:11 -07005123 ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :baz :bar/baz\n")
5124 ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :testdata/baz\n")
Roland Levillain630846d2019-06-26 12:48:34 +01005125}
5126
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005127func TestInstallExtraFlattenedApexes(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005128 ctx := testApex(t, `
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005129 apex {
5130 name: "myapex",
5131 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005132 updatable: false,
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005133 }
5134 apex_key {
5135 name: "myapex.key",
5136 public_key: "testkey.avbpubkey",
5137 private_key: "testkey.pem",
5138 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00005139 `,
5140 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
5141 variables.InstallExtraFlattenedApexes = proptools.BoolPtr(true)
5142 }),
5143 )
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005144 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Jiyong Park83dc74b2020-01-14 18:38:44 +09005145 ensureListContains(t, ab.requiredDeps, "myapex.flattened")
Colin Crossaa255532020-07-03 13:18:24 -07005146 mk := android.AndroidMkDataForTest(t, ctx, ab)
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005147 var builder strings.Builder
5148 mk.Custom(&builder, ab.Name(), "TARGET_", "", mk)
5149 androidMk := builder.String()
5150 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += myapex.flattened")
5151}
5152
Jooyung Hand48f3c32019-08-23 11:18:57 +09005153func TestErrorsIfDepsAreNotEnabled(t *testing.T) {
5154 testApexError(t, `module "myapex" .* depends on disabled module "libfoo"`, `
5155 apex {
5156 name: "myapex",
5157 key: "myapex.key",
5158 native_shared_libs: ["libfoo"],
5159 }
5160
5161 apex_key {
5162 name: "myapex.key",
5163 public_key: "testkey.avbpubkey",
5164 private_key: "testkey.pem",
5165 }
5166
5167 cc_library {
5168 name: "libfoo",
5169 stl: "none",
5170 system_shared_libs: [],
5171 enabled: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09005172 apex_available: ["myapex"],
Jooyung Hand48f3c32019-08-23 11:18:57 +09005173 }
5174 `)
5175 testApexError(t, `module "myapex" .* depends on disabled module "myjar"`, `
5176 apex {
5177 name: "myapex",
5178 key: "myapex.key",
5179 java_libs: ["myjar"],
5180 }
5181
5182 apex_key {
5183 name: "myapex.key",
5184 public_key: "testkey.avbpubkey",
5185 private_key: "testkey.pem",
5186 }
5187
5188 java_library {
5189 name: "myjar",
5190 srcs: ["foo/bar/MyClass.java"],
5191 sdk_version: "none",
5192 system_modules: "none",
Jooyung Hand48f3c32019-08-23 11:18:57 +09005193 enabled: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09005194 apex_available: ["myapex"],
Jooyung Hand48f3c32019-08-23 11:18:57 +09005195 }
5196 `)
5197}
5198
Bill Peckhama41a6962021-01-11 10:58:54 -08005199func TestApexWithJavaImport(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005200 ctx := testApex(t, `
Bill Peckhama41a6962021-01-11 10:58:54 -08005201 apex {
5202 name: "myapex",
5203 key: "myapex.key",
5204 java_libs: ["myjavaimport"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005205 updatable: false,
Bill Peckhama41a6962021-01-11 10:58:54 -08005206 }
5207
5208 apex_key {
5209 name: "myapex.key",
5210 public_key: "testkey.avbpubkey",
5211 private_key: "testkey.pem",
5212 }
5213
5214 java_import {
5215 name: "myjavaimport",
5216 apex_available: ["myapex"],
5217 jars: ["my.jar"],
5218 compile_dex: true,
5219 }
5220 `)
5221
5222 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
5223 apexRule := module.Rule("apexRule")
5224 copyCmds := apexRule.Args["copy_commands"]
5225 ensureContains(t, copyCmds, "image.apex/javalib/myjavaimport.jar")
5226}
5227
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005228func TestApexWithApps(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005229 ctx := testApex(t, `
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005230 apex {
5231 name: "myapex",
5232 key: "myapex.key",
5233 apps: [
5234 "AppFoo",
Jiyong Parkf7487312019-10-17 12:54:30 +09005235 "AppFooPriv",
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005236 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005237 updatable: false,
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005238 }
5239
5240 apex_key {
5241 name: "myapex.key",
5242 public_key: "testkey.avbpubkey",
5243 private_key: "testkey.pem",
5244 }
5245
5246 android_app {
5247 name: "AppFoo",
5248 srcs: ["foo/bar/MyClass.java"],
Colin Cross094cde42020-02-15 10:38:00 -08005249 sdk_version: "current",
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005250 system_modules: "none",
Jiyong Park8be103b2019-11-08 15:53:48 +09005251 jni_libs: ["libjni"],
Colin Cross094cde42020-02-15 10:38:00 -08005252 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005253 apex_available: [ "myapex" ],
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005254 }
Jiyong Parkf7487312019-10-17 12:54:30 +09005255
5256 android_app {
5257 name: "AppFooPriv",
5258 srcs: ["foo/bar/MyClass.java"],
Colin Cross094cde42020-02-15 10:38:00 -08005259 sdk_version: "current",
Jiyong Parkf7487312019-10-17 12:54:30 +09005260 system_modules: "none",
5261 privileged: true,
Colin Cross094cde42020-02-15 10:38:00 -08005262 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005263 apex_available: [ "myapex" ],
Jiyong Parkf7487312019-10-17 12:54:30 +09005264 }
Jiyong Park8be103b2019-11-08 15:53:48 +09005265
5266 cc_library_shared {
5267 name: "libjni",
5268 srcs: ["mylib.cpp"],
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005269 shared_libs: ["libfoo"],
5270 stl: "none",
5271 system_shared_libs: [],
5272 apex_available: [ "myapex" ],
5273 sdk_version: "current",
5274 }
5275
5276 cc_library_shared {
5277 name: "libfoo",
Jiyong Park8be103b2019-11-08 15:53:48 +09005278 stl: "none",
5279 system_shared_libs: [],
Jiyong Park0f80c182020-01-31 02:49:53 +09005280 apex_available: [ "myapex" ],
Colin Cross094cde42020-02-15 10:38:00 -08005281 sdk_version: "current",
Jiyong Park8be103b2019-11-08 15:53:48 +09005282 }
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005283 `)
5284
Sundong Ahnabb64432019-10-22 13:58:29 +09005285 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005286 apexRule := module.Rule("apexRule")
5287 copyCmds := apexRule.Args["copy_commands"]
5288
5289 ensureContains(t, copyCmds, "image.apex/app/AppFoo/AppFoo.apk")
Jiyong Parkf7487312019-10-17 12:54:30 +09005290 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPriv/AppFooPriv.apk")
Jiyong Park52cd06f2019-11-11 10:14:32 +09005291
Colin Crossaede88c2020-08-11 12:17:01 -07005292 appZipRule := ctx.ModuleForTests("AppFoo", "android_common_apex10000").Description("zip jni libs")
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005293 // JNI libraries are uncompressed
Jiyong Park52cd06f2019-11-11 10:14:32 +09005294 if args := appZipRule.Args["jarArgs"]; !strings.Contains(args, "-L 0") {
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005295 t.Errorf("jni libs are not uncompressed for AppFoo")
Jiyong Park52cd06f2019-11-11 10:14:32 +09005296 }
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005297 // JNI libraries including transitive deps are
5298 for _, jni := range []string{"libjni", "libfoo"} {
Paul Duffinafdd4062021-03-30 19:44:07 +01005299 jniOutput := ctx.ModuleForTests(jni, "android_arm64_armv8-a_sdk_shared_apex10000").Module().(*cc.Module).OutputFile().RelativeToTop()
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005300 // ... embedded inside APK (jnilibs.zip)
5301 ensureListContains(t, appZipRule.Implicits.Strings(), jniOutput.String())
5302 // ... and not directly inside the APEX
5303 ensureNotContains(t, copyCmds, "image.apex/lib64/"+jni+".so")
5304 }
Dario Frenicde2a032019-10-27 00:29:22 +01005305}
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005306
Dario Frenicde2a032019-10-27 00:29:22 +01005307func TestApexWithAppImports(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005308 ctx := testApex(t, `
Dario Frenicde2a032019-10-27 00:29:22 +01005309 apex {
5310 name: "myapex",
5311 key: "myapex.key",
5312 apps: [
5313 "AppFooPrebuilt",
5314 "AppFooPrivPrebuilt",
5315 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005316 updatable: false,
Dario Frenicde2a032019-10-27 00:29:22 +01005317 }
5318
5319 apex_key {
5320 name: "myapex.key",
5321 public_key: "testkey.avbpubkey",
5322 private_key: "testkey.pem",
5323 }
5324
5325 android_app_import {
5326 name: "AppFooPrebuilt",
5327 apk: "PrebuiltAppFoo.apk",
5328 presigned: true,
5329 dex_preopt: {
5330 enabled: false,
5331 },
Jiyong Park592a6a42020-04-21 22:34:28 +09005332 apex_available: ["myapex"],
Dario Frenicde2a032019-10-27 00:29:22 +01005333 }
5334
5335 android_app_import {
5336 name: "AppFooPrivPrebuilt",
5337 apk: "PrebuiltAppFooPriv.apk",
5338 privileged: true,
5339 presigned: true,
5340 dex_preopt: {
5341 enabled: false,
5342 },
Jooyung Han39ee1192020-03-23 20:21:11 +09005343 filename: "AwesomePrebuiltAppFooPriv.apk",
Jiyong Park592a6a42020-04-21 22:34:28 +09005344 apex_available: ["myapex"],
Dario Frenicde2a032019-10-27 00:29:22 +01005345 }
5346 `)
5347
Sundong Ahnabb64432019-10-22 13:58:29 +09005348 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Dario Frenicde2a032019-10-27 00:29:22 +01005349 apexRule := module.Rule("apexRule")
5350 copyCmds := apexRule.Args["copy_commands"]
5351
5352 ensureContains(t, copyCmds, "image.apex/app/AppFooPrebuilt/AppFooPrebuilt.apk")
Jooyung Han39ee1192020-03-23 20:21:11 +09005353 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPrivPrebuilt/AwesomePrebuiltAppFooPriv.apk")
5354}
5355
5356func TestApexWithAppImportsPrefer(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005357 ctx := testApex(t, `
Jooyung Han39ee1192020-03-23 20:21:11 +09005358 apex {
5359 name: "myapex",
5360 key: "myapex.key",
5361 apps: [
5362 "AppFoo",
5363 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005364 updatable: false,
Jooyung Han39ee1192020-03-23 20:21:11 +09005365 }
5366
5367 apex_key {
5368 name: "myapex.key",
5369 public_key: "testkey.avbpubkey",
5370 private_key: "testkey.pem",
5371 }
5372
5373 android_app {
5374 name: "AppFoo",
5375 srcs: ["foo/bar/MyClass.java"],
5376 sdk_version: "none",
5377 system_modules: "none",
5378 apex_available: [ "myapex" ],
5379 }
5380
5381 android_app_import {
5382 name: "AppFoo",
5383 apk: "AppFooPrebuilt.apk",
5384 filename: "AppFooPrebuilt.apk",
5385 presigned: true,
5386 prefer: true,
Jiyong Park592a6a42020-04-21 22:34:28 +09005387 apex_available: ["myapex"],
Jooyung Han39ee1192020-03-23 20:21:11 +09005388 }
5389 `, withFiles(map[string][]byte{
5390 "AppFooPrebuilt.apk": nil,
5391 }))
5392
5393 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Han86feead2021-03-08 13:11:48 +09005394 "app/AppFoo/AppFooPrebuilt.apk",
Jooyung Han39ee1192020-03-23 20:21:11 +09005395 })
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005396}
5397
Dario Freni6f3937c2019-12-20 22:58:03 +00005398func TestApexWithTestHelperApp(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005399 ctx := testApex(t, `
Dario Freni6f3937c2019-12-20 22:58:03 +00005400 apex {
5401 name: "myapex",
5402 key: "myapex.key",
5403 apps: [
5404 "TesterHelpAppFoo",
5405 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005406 updatable: false,
Dario Freni6f3937c2019-12-20 22:58:03 +00005407 }
5408
5409 apex_key {
5410 name: "myapex.key",
5411 public_key: "testkey.avbpubkey",
5412 private_key: "testkey.pem",
5413 }
5414
5415 android_test_helper_app {
5416 name: "TesterHelpAppFoo",
5417 srcs: ["foo/bar/MyClass.java"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005418 apex_available: [ "myapex" ],
Dario Freni6f3937c2019-12-20 22:58:03 +00005419 }
5420
5421 `)
5422
5423 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
5424 apexRule := module.Rule("apexRule")
5425 copyCmds := apexRule.Args["copy_commands"]
5426
5427 ensureContains(t, copyCmds, "image.apex/app/TesterHelpAppFoo/TesterHelpAppFoo.apk")
5428}
5429
Jooyung Han18020ea2019-11-13 10:50:48 +09005430func TestApexPropertiesShouldBeDefaultable(t *testing.T) {
5431 // libfoo's apex_available comes from cc_defaults
Steven Moreland6e36cd62020-10-22 01:08:35 +00005432 testApexError(t, `requires "libfoo" that doesn't list the APEX under 'apex_available'.`, `
Jooyung Han18020ea2019-11-13 10:50:48 +09005433 apex {
5434 name: "myapex",
5435 key: "myapex.key",
5436 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005437 updatable: false,
Jooyung Han18020ea2019-11-13 10:50:48 +09005438 }
5439
5440 apex_key {
5441 name: "myapex.key",
5442 public_key: "testkey.avbpubkey",
5443 private_key: "testkey.pem",
5444 }
5445
5446 apex {
5447 name: "otherapex",
5448 key: "myapex.key",
5449 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005450 updatable: false,
Jooyung Han18020ea2019-11-13 10:50:48 +09005451 }
5452
5453 cc_defaults {
5454 name: "libfoo-defaults",
5455 apex_available: ["otherapex"],
5456 }
5457
5458 cc_library {
5459 name: "libfoo",
5460 defaults: ["libfoo-defaults"],
5461 stl: "none",
5462 system_shared_libs: [],
5463 }`)
5464}
5465
Paul Duffine52e66f2020-03-30 17:54:29 +01005466func TestApexAvailable_DirectDep(t *testing.T) {
Jiyong Park127b40b2019-09-30 16:04:35 +09005467 // libfoo is not available to myapex, but only to otherapex
Steven Moreland6e36cd62020-10-22 01:08:35 +00005468 testApexError(t, "requires \"libfoo\" that doesn't list the APEX under 'apex_available'.", `
Jiyong Park127b40b2019-09-30 16:04:35 +09005469 apex {
5470 name: "myapex",
5471 key: "myapex.key",
5472 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005473 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005474 }
5475
5476 apex_key {
5477 name: "myapex.key",
5478 public_key: "testkey.avbpubkey",
5479 private_key: "testkey.pem",
5480 }
5481
5482 apex {
5483 name: "otherapex",
5484 key: "otherapex.key",
5485 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005486 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005487 }
5488
5489 apex_key {
5490 name: "otherapex.key",
5491 public_key: "testkey.avbpubkey",
5492 private_key: "testkey.pem",
5493 }
5494
5495 cc_library {
5496 name: "libfoo",
5497 stl: "none",
5498 system_shared_libs: [],
5499 apex_available: ["otherapex"],
5500 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01005501}
Jiyong Park127b40b2019-09-30 16:04:35 +09005502
Paul Duffine52e66f2020-03-30 17:54:29 +01005503func TestApexAvailable_IndirectDep(t *testing.T) {
Jooyung Han5e9013b2020-03-10 06:23:13 +09005504 // libbbaz is an indirect dep
Jiyong Park767dbd92021-03-04 13:03:10 +09005505 testApexError(t, `requires "libbaz" that doesn't list the APEX under 'apex_available'.\n\nDependency path:
Colin Cross6e511a92020-07-27 21:26:48 -07005506.*via tag apex\.dependencyTag.*name:sharedLib.*
Paul Duffindf915ff2020-03-30 17:58:21 +01005507.*-> libfoo.*link:shared.*
Colin Cross6e511a92020-07-27 21:26:48 -07005508.*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
Paul Duffindf915ff2020-03-30 17:58:21 +01005509.*-> libbar.*link:shared.*
Colin Cross6e511a92020-07-27 21:26:48 -07005510.*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
Paul Duffin65347702020-03-31 15:23:40 +01005511.*-> libbaz.*link:shared.*`, `
Jiyong Park127b40b2019-09-30 16:04:35 +09005512 apex {
5513 name: "myapex",
5514 key: "myapex.key",
5515 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005516 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005517 }
5518
5519 apex_key {
5520 name: "myapex.key",
5521 public_key: "testkey.avbpubkey",
5522 private_key: "testkey.pem",
5523 }
5524
Jiyong Park127b40b2019-09-30 16:04:35 +09005525 cc_library {
5526 name: "libfoo",
5527 stl: "none",
5528 shared_libs: ["libbar"],
5529 system_shared_libs: [],
Jooyung Han5e9013b2020-03-10 06:23:13 +09005530 apex_available: ["myapex"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005531 }
5532
5533 cc_library {
5534 name: "libbar",
5535 stl: "none",
Jooyung Han5e9013b2020-03-10 06:23:13 +09005536 shared_libs: ["libbaz"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005537 system_shared_libs: [],
Jooyung Han5e9013b2020-03-10 06:23:13 +09005538 apex_available: ["myapex"],
5539 }
5540
5541 cc_library {
5542 name: "libbaz",
5543 stl: "none",
5544 system_shared_libs: [],
Jiyong Park127b40b2019-09-30 16:04:35 +09005545 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01005546}
Jiyong Park127b40b2019-09-30 16:04:35 +09005547
Paul Duffine52e66f2020-03-30 17:54:29 +01005548func TestApexAvailable_InvalidApexName(t *testing.T) {
Jiyong Park127b40b2019-09-30 16:04:35 +09005549 testApexError(t, "\"otherapex\" is not a valid module name", `
5550 apex {
5551 name: "myapex",
5552 key: "myapex.key",
5553 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005554 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005555 }
5556
5557 apex_key {
5558 name: "myapex.key",
5559 public_key: "testkey.avbpubkey",
5560 private_key: "testkey.pem",
5561 }
5562
5563 cc_library {
5564 name: "libfoo",
5565 stl: "none",
5566 system_shared_libs: [],
5567 apex_available: ["otherapex"],
5568 }`)
5569
Paul Duffine52e66f2020-03-30 17:54:29 +01005570 testApex(t, `
Jiyong Park127b40b2019-09-30 16:04:35 +09005571 apex {
5572 name: "myapex",
5573 key: "myapex.key",
5574 native_shared_libs: ["libfoo", "libbar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005575 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005576 }
5577
5578 apex_key {
5579 name: "myapex.key",
5580 public_key: "testkey.avbpubkey",
5581 private_key: "testkey.pem",
5582 }
5583
5584 cc_library {
5585 name: "libfoo",
5586 stl: "none",
5587 system_shared_libs: [],
Jiyong Park323a4c32020-03-01 17:29:06 +09005588 runtime_libs: ["libbaz"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005589 apex_available: ["myapex"],
5590 }
5591
5592 cc_library {
5593 name: "libbar",
5594 stl: "none",
5595 system_shared_libs: [],
5596 apex_available: ["//apex_available:anyapex"],
Jiyong Park323a4c32020-03-01 17:29:06 +09005597 }
5598
5599 cc_library {
5600 name: "libbaz",
5601 stl: "none",
5602 system_shared_libs: [],
5603 stubs: {
5604 versions: ["10", "20", "30"],
5605 },
Jiyong Park127b40b2019-09-30 16:04:35 +09005606 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01005607}
Jiyong Park127b40b2019-09-30 16:04:35 +09005608
Jiyong Park89e850a2020-04-07 16:37:39 +09005609func TestApexAvailable_CheckForPlatform(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005610 ctx := testApex(t, `
Jiyong Park127b40b2019-09-30 16:04:35 +09005611 apex {
5612 name: "myapex",
5613 key: "myapex.key",
Jiyong Park89e850a2020-04-07 16:37:39 +09005614 native_shared_libs: ["libbar", "libbaz"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005615 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005616 }
5617
5618 apex_key {
5619 name: "myapex.key",
5620 public_key: "testkey.avbpubkey",
5621 private_key: "testkey.pem",
5622 }
5623
5624 cc_library {
5625 name: "libfoo",
5626 stl: "none",
5627 system_shared_libs: [],
Jiyong Park89e850a2020-04-07 16:37:39 +09005628 shared_libs: ["libbar"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005629 apex_available: ["//apex_available:platform"],
Jiyong Park89e850a2020-04-07 16:37:39 +09005630 }
5631
5632 cc_library {
5633 name: "libfoo2",
5634 stl: "none",
5635 system_shared_libs: [],
5636 shared_libs: ["libbaz"],
5637 apex_available: ["//apex_available:platform"],
5638 }
5639
5640 cc_library {
5641 name: "libbar",
5642 stl: "none",
5643 system_shared_libs: [],
5644 apex_available: ["myapex"],
5645 }
5646
5647 cc_library {
5648 name: "libbaz",
5649 stl: "none",
5650 system_shared_libs: [],
5651 apex_available: ["myapex"],
5652 stubs: {
5653 versions: ["1"],
5654 },
Jiyong Park127b40b2019-09-30 16:04:35 +09005655 }`)
5656
Jiyong Park89e850a2020-04-07 16:37:39 +09005657 // libfoo shouldn't be available to platform even though it has "//apex_available:platform",
5658 // because it depends on libbar which isn't available to platform
5659 libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
5660 if libfoo.NotAvailableForPlatform() != true {
5661 t.Errorf("%q shouldn't be available to platform", libfoo.String())
5662 }
5663
5664 // libfoo2 however can be available to platform because it depends on libbaz which provides
5665 // stubs
5666 libfoo2 := ctx.ModuleForTests("libfoo2", "android_arm64_armv8-a_shared").Module().(*cc.Module)
5667 if libfoo2.NotAvailableForPlatform() == true {
5668 t.Errorf("%q should be available to platform", libfoo2.String())
5669 }
Paul Duffine52e66f2020-03-30 17:54:29 +01005670}
Jiyong Parka90ca002019-10-07 15:47:24 +09005671
Paul Duffine52e66f2020-03-30 17:54:29 +01005672func TestApexAvailable_CreatedForApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005673 ctx := testApex(t, `
Jiyong Parka90ca002019-10-07 15:47:24 +09005674 apex {
5675 name: "myapex",
5676 key: "myapex.key",
5677 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005678 updatable: false,
Jiyong Parka90ca002019-10-07 15:47:24 +09005679 }
5680
5681 apex_key {
5682 name: "myapex.key",
5683 public_key: "testkey.avbpubkey",
5684 private_key: "testkey.pem",
5685 }
5686
5687 cc_library {
5688 name: "libfoo",
5689 stl: "none",
5690 system_shared_libs: [],
5691 apex_available: ["myapex"],
5692 static: {
5693 apex_available: ["//apex_available:platform"],
5694 },
5695 }`)
5696
Jiyong Park89e850a2020-04-07 16:37:39 +09005697 libfooShared := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
5698 if libfooShared.NotAvailableForPlatform() != true {
5699 t.Errorf("%q shouldn't be available to platform", libfooShared.String())
5700 }
5701 libfooStatic := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_static").Module().(*cc.Module)
5702 if libfooStatic.NotAvailableForPlatform() != false {
5703 t.Errorf("%q should be available to platform", libfooStatic.String())
5704 }
Jiyong Park127b40b2019-09-30 16:04:35 +09005705}
5706
Jiyong Park5d790c32019-11-15 18:40:32 +09005707func TestOverrideApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005708 ctx := testApex(t, `
Jiyong Park5d790c32019-11-15 18:40:32 +09005709 apex {
5710 name: "myapex",
5711 key: "myapex.key",
5712 apps: ["app"],
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08005713 overrides: ["oldapex"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005714 updatable: false,
Jiyong Park5d790c32019-11-15 18:40:32 +09005715 }
5716
5717 override_apex {
5718 name: "override_myapex",
5719 base: "myapex",
5720 apps: ["override_app"],
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08005721 overrides: ["unknownapex"],
Baligh Uddin004d7172020-02-19 21:29:28 -08005722 logging_parent: "com.foo.bar",
Baligh Uddin5b57dba2020-03-15 13:01:05 -07005723 package_name: "test.overridden.package",
Jaewoong Jung4cfdf7d2021-04-20 16:21:24 -07005724 key: "mynewapex.key",
5725 certificate: ":myapex.certificate",
Jiyong Park5d790c32019-11-15 18:40:32 +09005726 }
5727
5728 apex_key {
5729 name: "myapex.key",
5730 public_key: "testkey.avbpubkey",
5731 private_key: "testkey.pem",
5732 }
5733
Jaewoong Jung4cfdf7d2021-04-20 16:21:24 -07005734 apex_key {
5735 name: "mynewapex.key",
5736 public_key: "testkey2.avbpubkey",
5737 private_key: "testkey2.pem",
5738 }
5739
5740 android_app_certificate {
5741 name: "myapex.certificate",
5742 certificate: "testkey",
5743 }
5744
Jiyong Park5d790c32019-11-15 18:40:32 +09005745 android_app {
5746 name: "app",
5747 srcs: ["foo/bar/MyClass.java"],
5748 package_name: "foo",
5749 sdk_version: "none",
5750 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005751 apex_available: [ "myapex" ],
Jiyong Park5d790c32019-11-15 18:40:32 +09005752 }
5753
5754 override_android_app {
5755 name: "override_app",
5756 base: "app",
5757 package_name: "bar",
5758 }
Jiyong Park20bacab2020-03-03 11:45:41 +09005759 `, withManifestPackageNameOverrides([]string{"myapex:com.android.myapex"}))
Jiyong Park5d790c32019-11-15 18:40:32 +09005760
Jiyong Park317645e2019-12-05 13:20:58 +09005761 originalVariant := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(android.OverridableModule)
5762 overriddenVariant := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Module().(android.OverridableModule)
5763 if originalVariant.GetOverriddenBy() != "" {
5764 t.Errorf("GetOverriddenBy should be empty, but was %q", originalVariant.GetOverriddenBy())
5765 }
5766 if overriddenVariant.GetOverriddenBy() != "override_myapex" {
5767 t.Errorf("GetOverriddenBy should be \"override_myapex\", but was %q", overriddenVariant.GetOverriddenBy())
5768 }
5769
Jiyong Park5d790c32019-11-15 18:40:32 +09005770 module := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image")
5771 apexRule := module.Rule("apexRule")
5772 copyCmds := apexRule.Args["copy_commands"]
5773
5774 ensureNotContains(t, copyCmds, "image.apex/app/app/app.apk")
Jooyung Han39ee1192020-03-23 20:21:11 +09005775 ensureContains(t, copyCmds, "image.apex/app/override_app/override_app.apk")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005776
5777 apexBundle := module.Module().(*apexBundle)
5778 name := apexBundle.Name()
5779 if name != "override_myapex" {
5780 t.Errorf("name should be \"override_myapex\", but was %q", name)
5781 }
5782
Baligh Uddin004d7172020-02-19 21:29:28 -08005783 if apexBundle.overridableProperties.Logging_parent != "com.foo.bar" {
5784 t.Errorf("override_myapex should have logging parent (com.foo.bar), but was %q.", apexBundle.overridableProperties.Logging_parent)
5785 }
5786
Jiyong Park20bacab2020-03-03 11:45:41 +09005787 optFlags := apexRule.Args["opt_flags"]
Baligh Uddin5b57dba2020-03-15 13:01:05 -07005788 ensureContains(t, optFlags, "--override_apk_package_name test.overridden.package")
Jaewoong Jung4cfdf7d2021-04-20 16:21:24 -07005789 ensureContains(t, optFlags, "--pubkey testkey2.avbpubkey")
5790
5791 signApkRule := module.Rule("signapk")
5792 ensureEquals(t, signApkRule.Args["certificates"], "testkey.x509.pem testkey.pk8")
Jiyong Park20bacab2020-03-03 11:45:41 +09005793
Colin Crossaa255532020-07-03 13:18:24 -07005794 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005795 var builder strings.Builder
5796 data.Custom(&builder, name, "TARGET_", "", data)
5797 androidMk := builder.String()
Jiyong Parkf653b052019-11-18 15:39:01 +09005798 ensureContains(t, androidMk, "LOCAL_MODULE := override_app.override_myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005799 ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.override_myapex")
5800 ensureContains(t, androidMk, "LOCAL_MODULE_STEM := override_myapex.apex")
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08005801 ensureContains(t, androidMk, "LOCAL_OVERRIDES_MODULES := unknownapex myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005802 ensureNotContains(t, androidMk, "LOCAL_MODULE := app.myapex")
Jiyong Parkf653b052019-11-18 15:39:01 +09005803 ensureNotContains(t, androidMk, "LOCAL_MODULE := override_app.myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005804 ensureNotContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex")
5805 ensureNotContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.apex")
Jiyong Park5d790c32019-11-15 18:40:32 +09005806}
5807
Jooyung Han214bf372019-11-12 13:03:50 +09005808func TestLegacyAndroid10Support(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005809 ctx := testApex(t, `
Jooyung Han214bf372019-11-12 13:03:50 +09005810 apex {
5811 name: "myapex",
5812 key: "myapex.key",
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005813 native_shared_libs: ["mylib"],
Jooyung Han5417f772020-03-12 18:37:20 +09005814 min_sdk_version: "29",
Jooyung Han214bf372019-11-12 13:03:50 +09005815 }
5816
5817 apex_key {
5818 name: "myapex.key",
5819 public_key: "testkey.avbpubkey",
5820 private_key: "testkey.pem",
5821 }
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005822
5823 cc_library {
5824 name: "mylib",
5825 srcs: ["mylib.cpp"],
5826 stl: "libc++",
5827 system_shared_libs: [],
5828 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09005829 min_sdk_version: "29",
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005830 }
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005831 `, withUnbundledBuild)
Jooyung Han214bf372019-11-12 13:03:50 +09005832
5833 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
5834 args := module.Rule("apexRule").Args
5835 ensureContains(t, args["opt_flags"], "--manifest_json "+module.Output("apex_manifest.json").Output.String())
Dario Frenie3546902020-01-14 23:50:25 +00005836 ensureNotContains(t, args["opt_flags"], "--no_hashtree")
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005837
5838 // The copies of the libraries in the apex should have one more dependency than
5839 // the ones outside the apex, namely the unwinder. Ideally we should check
5840 // the dependency names directly here but for some reason the names are blank in
5841 // this test.
5842 for _, lib := range []string{"libc++", "mylib"} {
Colin Crossaede88c2020-08-11 12:17:01 -07005843 apexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared_apex29").Rule("ld").Implicits
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005844 nonApexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared").Rule("ld").Implicits
5845 if len(apexImplicits) != len(nonApexImplicits)+1 {
5846 t.Errorf("%q missing unwinder dep", lib)
5847 }
5848 }
Jooyung Han214bf372019-11-12 13:03:50 +09005849}
5850
Paul Duffine05480a2021-03-08 15:07:14 +00005851var filesForSdkLibrary = android.MockFS{
Paul Duffin9b879592020-05-26 13:21:35 +01005852 "api/current.txt": nil,
5853 "api/removed.txt": nil,
5854 "api/system-current.txt": nil,
5855 "api/system-removed.txt": nil,
5856 "api/test-current.txt": nil,
5857 "api/test-removed.txt": nil,
Paul Duffineedc5d52020-06-12 17:46:39 +01005858
Anton Hanssondff2c782020-12-21 17:10:01 +00005859 "100/public/api/foo.txt": nil,
5860 "100/public/api/foo-removed.txt": nil,
5861 "100/system/api/foo.txt": nil,
5862 "100/system/api/foo-removed.txt": nil,
5863
Paul Duffineedc5d52020-06-12 17:46:39 +01005864 // For java_sdk_library_import
5865 "a.jar": nil,
Paul Duffin9b879592020-05-26 13:21:35 +01005866}
5867
Jooyung Han58f26ab2019-12-18 15:34:32 +09005868func TestJavaSDKLibrary(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005869 ctx := testApex(t, `
Jooyung Han58f26ab2019-12-18 15:34:32 +09005870 apex {
5871 name: "myapex",
5872 key: "myapex.key",
5873 java_libs: ["foo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005874 updatable: false,
Jooyung Han58f26ab2019-12-18 15:34:32 +09005875 }
5876
5877 apex_key {
5878 name: "myapex.key",
5879 public_key: "testkey.avbpubkey",
5880 private_key: "testkey.pem",
5881 }
5882
5883 java_sdk_library {
5884 name: "foo",
5885 srcs: ["a.java"],
5886 api_packages: ["foo"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005887 apex_available: [ "myapex" ],
Jooyung Han58f26ab2019-12-18 15:34:32 +09005888 }
Anton Hanssondff2c782020-12-21 17:10:01 +00005889
5890 prebuilt_apis {
5891 name: "sdk",
5892 api_dirs: ["100"],
5893 }
Paul Duffin9b879592020-05-26 13:21:35 +01005894 `, withFiles(filesForSdkLibrary))
Jooyung Han58f26ab2019-12-18 15:34:32 +09005895
5896 // java_sdk_library installs both impl jar and permission XML
Jooyung Hana57af4a2020-01-23 05:36:59 +00005897 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Han58f26ab2019-12-18 15:34:32 +09005898 "javalib/foo.jar",
5899 "etc/permissions/foo.xml",
5900 })
5901 // Permission XML should point to the activated path of impl jar of java_sdk_library
Jiyong Parke3833882020-02-17 17:28:10 +09005902 sdkLibrary := ctx.ModuleForTests("foo.xml", "android_common_myapex").Rule("java_sdk_xml")
5903 ensureContains(t, sdkLibrary.RuleParams.Command, `<library name=\"foo\" file=\"/apex/myapex/javalib/foo.jar\"`)
Jooyung Han58f26ab2019-12-18 15:34:32 +09005904}
5905
Paul Duffin9b879592020-05-26 13:21:35 +01005906func TestJavaSDKLibrary_WithinApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005907 ctx := testApex(t, `
Paul Duffin9b879592020-05-26 13:21:35 +01005908 apex {
5909 name: "myapex",
5910 key: "myapex.key",
5911 java_libs: ["foo", "bar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005912 updatable: false,
Paul Duffin9b879592020-05-26 13:21:35 +01005913 }
5914
5915 apex_key {
5916 name: "myapex.key",
5917 public_key: "testkey.avbpubkey",
5918 private_key: "testkey.pem",
5919 }
5920
5921 java_sdk_library {
5922 name: "foo",
5923 srcs: ["a.java"],
5924 api_packages: ["foo"],
5925 apex_available: ["myapex"],
5926 sdk_version: "none",
5927 system_modules: "none",
5928 }
5929
5930 java_library {
5931 name: "bar",
5932 srcs: ["a.java"],
5933 libs: ["foo"],
5934 apex_available: ["myapex"],
5935 sdk_version: "none",
5936 system_modules: "none",
5937 }
Anton Hanssondff2c782020-12-21 17:10:01 +00005938
5939 prebuilt_apis {
5940 name: "sdk",
5941 api_dirs: ["100"],
5942 }
Paul Duffin9b879592020-05-26 13:21:35 +01005943 `, withFiles(filesForSdkLibrary))
5944
5945 // java_sdk_library installs both impl jar and permission XML
5946 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
5947 "javalib/bar.jar",
5948 "javalib/foo.jar",
5949 "etc/permissions/foo.xml",
5950 })
5951
5952 // The bar library should depend on the implementation jar.
5953 barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
Paul Duffincf8d7db2021-03-29 00:29:53 +01005954 if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Paul Duffin9b879592020-05-26 13:21:35 +01005955 t.Errorf("expected %q, found %#q", expected, actual)
5956 }
5957}
5958
5959func TestJavaSDKLibrary_CrossBoundary(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005960 ctx := testApex(t, `
Paul Duffin9b879592020-05-26 13:21:35 +01005961 apex {
5962 name: "myapex",
5963 key: "myapex.key",
5964 java_libs: ["foo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005965 updatable: false,
Paul Duffin9b879592020-05-26 13:21:35 +01005966 }
5967
5968 apex_key {
5969 name: "myapex.key",
5970 public_key: "testkey.avbpubkey",
5971 private_key: "testkey.pem",
5972 }
5973
5974 java_sdk_library {
5975 name: "foo",
5976 srcs: ["a.java"],
5977 api_packages: ["foo"],
5978 apex_available: ["myapex"],
5979 sdk_version: "none",
5980 system_modules: "none",
5981 }
5982
5983 java_library {
5984 name: "bar",
5985 srcs: ["a.java"],
5986 libs: ["foo"],
5987 sdk_version: "none",
5988 system_modules: "none",
5989 }
Anton Hanssondff2c782020-12-21 17:10:01 +00005990
5991 prebuilt_apis {
5992 name: "sdk",
5993 api_dirs: ["100"],
5994 }
Paul Duffin9b879592020-05-26 13:21:35 +01005995 `, withFiles(filesForSdkLibrary))
5996
5997 // java_sdk_library installs both impl jar and permission XML
5998 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
5999 "javalib/foo.jar",
6000 "etc/permissions/foo.xml",
6001 })
6002
6003 // The bar library should depend on the stubs jar.
6004 barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
Paul Duffincf8d7db2021-03-29 00:29:53 +01006005 if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Paul Duffin9b879592020-05-26 13:21:35 +01006006 t.Errorf("expected %q, found %#q", expected, actual)
6007 }
6008}
6009
Paul Duffineedc5d52020-06-12 17:46:39 +01006010func TestJavaSDKLibrary_ImportPreferred(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006011 ctx := testApex(t, `
Anton Hanssondff2c782020-12-21 17:10:01 +00006012 prebuilt_apis {
6013 name: "sdk",
6014 api_dirs: ["100"],
6015 }`,
Paul Duffineedc5d52020-06-12 17:46:39 +01006016 withFiles(map[string][]byte{
6017 "apex/a.java": nil,
6018 "apex/apex_manifest.json": nil,
6019 "apex/Android.bp": []byte(`
6020 package {
6021 default_visibility: ["//visibility:private"],
6022 }
6023
6024 apex {
6025 name: "myapex",
6026 key: "myapex.key",
6027 java_libs: ["foo", "bar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006028 updatable: false,
Paul Duffineedc5d52020-06-12 17:46:39 +01006029 }
6030
6031 apex_key {
6032 name: "myapex.key",
6033 public_key: "testkey.avbpubkey",
6034 private_key: "testkey.pem",
6035 }
6036
6037 java_library {
6038 name: "bar",
6039 srcs: ["a.java"],
6040 libs: ["foo"],
6041 apex_available: ["myapex"],
6042 sdk_version: "none",
6043 system_modules: "none",
6044 }
6045`),
6046 "source/a.java": nil,
6047 "source/api/current.txt": nil,
6048 "source/api/removed.txt": nil,
6049 "source/Android.bp": []byte(`
6050 package {
6051 default_visibility: ["//visibility:private"],
6052 }
6053
6054 java_sdk_library {
6055 name: "foo",
6056 visibility: ["//apex"],
6057 srcs: ["a.java"],
6058 api_packages: ["foo"],
6059 apex_available: ["myapex"],
6060 sdk_version: "none",
6061 system_modules: "none",
6062 public: {
6063 enabled: true,
6064 },
6065 }
6066`),
6067 "prebuilt/a.jar": nil,
6068 "prebuilt/Android.bp": []byte(`
6069 package {
6070 default_visibility: ["//visibility:private"],
6071 }
6072
6073 java_sdk_library_import {
6074 name: "foo",
6075 visibility: ["//apex", "//source"],
6076 apex_available: ["myapex"],
6077 prefer: true,
6078 public: {
6079 jars: ["a.jar"],
6080 },
6081 }
6082`),
Anton Hanssondff2c782020-12-21 17:10:01 +00006083 }), withFiles(filesForSdkLibrary),
Paul Duffineedc5d52020-06-12 17:46:39 +01006084 )
6085
6086 // java_sdk_library installs both impl jar and permission XML
6087 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
6088 "javalib/bar.jar",
6089 "javalib/foo.jar",
6090 "etc/permissions/foo.xml",
6091 })
6092
6093 // The bar library should depend on the implementation jar.
6094 barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
Paul Duffincf8d7db2021-03-29 00:29:53 +01006095 if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.impl\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Paul Duffineedc5d52020-06-12 17:46:39 +01006096 t.Errorf("expected %q, found %#q", expected, actual)
6097 }
6098}
6099
6100func TestJavaSDKLibrary_ImportOnly(t *testing.T) {
6101 testApexError(t, `java_libs: "foo" is not configured to be compiled into dex`, `
6102 apex {
6103 name: "myapex",
6104 key: "myapex.key",
6105 java_libs: ["foo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006106 updatable: false,
Paul Duffineedc5d52020-06-12 17:46:39 +01006107 }
6108
6109 apex_key {
6110 name: "myapex.key",
6111 public_key: "testkey.avbpubkey",
6112 private_key: "testkey.pem",
6113 }
6114
6115 java_sdk_library_import {
6116 name: "foo",
6117 apex_available: ["myapex"],
6118 prefer: true,
6119 public: {
6120 jars: ["a.jar"],
6121 },
6122 }
6123
6124 `, withFiles(filesForSdkLibrary))
6125}
6126
atrost6e126252020-01-27 17:01:16 +00006127func TestCompatConfig(t *testing.T) {
Paul Duffin284165a2021-03-29 01:50:31 +01006128 result := android.GroupFixturePreparers(
6129 prepareForApexTest,
6130 java.PrepareForTestWithPlatformCompatConfig,
6131 ).RunTestWithBp(t, `
atrost6e126252020-01-27 17:01:16 +00006132 apex {
6133 name: "myapex",
6134 key: "myapex.key",
Paul Duffin3abc1742021-03-15 19:32:23 +00006135 compat_configs: ["myjar-platform-compat-config"],
atrost6e126252020-01-27 17:01:16 +00006136 java_libs: ["myjar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006137 updatable: false,
atrost6e126252020-01-27 17:01:16 +00006138 }
6139
6140 apex_key {
6141 name: "myapex.key",
6142 public_key: "testkey.avbpubkey",
6143 private_key: "testkey.pem",
6144 }
6145
6146 platform_compat_config {
6147 name: "myjar-platform-compat-config",
6148 src: ":myjar",
6149 }
6150
6151 java_library {
6152 name: "myjar",
6153 srcs: ["foo/bar/MyClass.java"],
6154 sdk_version: "none",
6155 system_modules: "none",
atrost6e126252020-01-27 17:01:16 +00006156 apex_available: [ "myapex" ],
6157 }
Paul Duffin1b29e002021-03-16 15:06:54 +00006158
6159 // Make sure that a preferred prebuilt does not affect the apex contents.
6160 prebuilt_platform_compat_config {
6161 name: "myjar-platform-compat-config",
6162 metadata: "compat-config/metadata.xml",
6163 prefer: true,
6164 }
atrost6e126252020-01-27 17:01:16 +00006165 `)
Paul Duffina369c7b2021-03-09 03:08:05 +00006166 ctx := result.TestContext
atrost6e126252020-01-27 17:01:16 +00006167 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
6168 "etc/compatconfig/myjar-platform-compat-config.xml",
6169 "javalib/myjar.jar",
6170 })
6171}
6172
Jiyong Park479321d2019-12-16 11:47:12 +09006173func TestRejectNonInstallableJavaLibrary(t *testing.T) {
6174 testApexError(t, `"myjar" is not configured to be compiled into dex`, `
6175 apex {
6176 name: "myapex",
6177 key: "myapex.key",
6178 java_libs: ["myjar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006179 updatable: false,
Jiyong Park479321d2019-12-16 11:47:12 +09006180 }
6181
6182 apex_key {
6183 name: "myapex.key",
6184 public_key: "testkey.avbpubkey",
6185 private_key: "testkey.pem",
6186 }
6187
6188 java_library {
6189 name: "myjar",
6190 srcs: ["foo/bar/MyClass.java"],
6191 sdk_version: "none",
6192 system_modules: "none",
Jiyong Park6b21c7d2020-02-11 09:16:01 +09006193 compile_dex: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09006194 apex_available: ["myapex"],
Jiyong Park479321d2019-12-16 11:47:12 +09006195 }
6196 `)
6197}
6198
Jiyong Park7afd1072019-12-30 16:56:33 +09006199func TestCarryRequiredModuleNames(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006200 ctx := testApex(t, `
Jiyong Park7afd1072019-12-30 16:56:33 +09006201 apex {
6202 name: "myapex",
6203 key: "myapex.key",
6204 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006205 updatable: false,
Jiyong Park7afd1072019-12-30 16:56:33 +09006206 }
6207
6208 apex_key {
6209 name: "myapex.key",
6210 public_key: "testkey.avbpubkey",
6211 private_key: "testkey.pem",
6212 }
6213
6214 cc_library {
6215 name: "mylib",
6216 srcs: ["mylib.cpp"],
6217 system_shared_libs: [],
6218 stl: "none",
6219 required: ["a", "b"],
6220 host_required: ["c", "d"],
6221 target_required: ["e", "f"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00006222 apex_available: [ "myapex" ],
Jiyong Park7afd1072019-12-30 16:56:33 +09006223 }
6224 `)
6225
6226 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07006227 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jiyong Park7afd1072019-12-30 16:56:33 +09006228 name := apexBundle.BaseModuleName()
6229 prefix := "TARGET_"
6230 var builder strings.Builder
6231 data.Custom(&builder, name, prefix, "", data)
6232 androidMk := builder.String()
6233 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += a b\n")
6234 ensureContains(t, androidMk, "LOCAL_HOST_REQUIRED_MODULES += c d\n")
6235 ensureContains(t, androidMk, "LOCAL_TARGET_REQUIRED_MODULES += e f\n")
6236}
6237
Jiyong Park7cd10e32020-01-14 09:22:18 +09006238func TestSymlinksFromApexToSystem(t *testing.T) {
6239 bp := `
6240 apex {
6241 name: "myapex",
6242 key: "myapex.key",
6243 native_shared_libs: ["mylib"],
6244 java_libs: ["myjar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006245 updatable: false,
Jiyong Park7cd10e32020-01-14 09:22:18 +09006246 }
6247
Jiyong Park9d677202020-02-19 16:29:35 +09006248 apex {
6249 name: "myapex.updatable",
6250 key: "myapex.key",
6251 native_shared_libs: ["mylib"],
6252 java_libs: ["myjar"],
6253 updatable: true,
Jooyung Han548640b2020-04-27 12:10:30 +09006254 min_sdk_version: "current",
Jiyong Park9d677202020-02-19 16:29:35 +09006255 }
6256
Jiyong Park7cd10e32020-01-14 09:22:18 +09006257 apex_key {
6258 name: "myapex.key",
6259 public_key: "testkey.avbpubkey",
6260 private_key: "testkey.pem",
6261 }
6262
6263 cc_library {
6264 name: "mylib",
6265 srcs: ["mylib.cpp"],
6266 shared_libs: ["myotherlib"],
6267 system_shared_libs: [],
6268 stl: "none",
6269 apex_available: [
6270 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006271 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006272 "//apex_available:platform",
6273 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006274 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006275 }
6276
6277 cc_library {
6278 name: "myotherlib",
6279 srcs: ["mylib.cpp"],
6280 system_shared_libs: [],
6281 stl: "none",
6282 apex_available: [
6283 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006284 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006285 "//apex_available:platform",
6286 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006287 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006288 }
6289
6290 java_library {
6291 name: "myjar",
6292 srcs: ["foo/bar/MyClass.java"],
6293 sdk_version: "none",
6294 system_modules: "none",
6295 libs: ["myotherjar"],
Jiyong Park7cd10e32020-01-14 09:22:18 +09006296 apex_available: [
6297 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006298 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006299 "//apex_available:platform",
6300 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006301 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006302 }
6303
6304 java_library {
6305 name: "myotherjar",
6306 srcs: ["foo/bar/MyClass.java"],
6307 sdk_version: "none",
6308 system_modules: "none",
6309 apex_available: [
6310 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006311 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006312 "//apex_available:platform",
6313 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006314 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006315 }
6316 `
6317
6318 ensureRealfileExists := func(t *testing.T, files []fileInApex, file string) {
6319 for _, f := range files {
6320 if f.path == file {
6321 if f.isLink {
6322 t.Errorf("%q is not a real file", file)
6323 }
6324 return
6325 }
6326 }
6327 t.Errorf("%q is not found", file)
6328 }
6329
6330 ensureSymlinkExists := func(t *testing.T, files []fileInApex, file string) {
6331 for _, f := range files {
6332 if f.path == file {
6333 if !f.isLink {
6334 t.Errorf("%q is not a symlink", file)
6335 }
6336 return
6337 }
6338 }
6339 t.Errorf("%q is not found", file)
6340 }
6341
Jiyong Park9d677202020-02-19 16:29:35 +09006342 // For unbundled build, symlink shouldn't exist regardless of whether an APEX
6343 // is updatable or not
Colin Cross1c460562021-02-16 17:55:47 -08006344 ctx := testApex(t, bp, withUnbundledBuild)
Jooyung Hana57af4a2020-01-23 05:36:59 +00006345 files := getFiles(t, ctx, "myapex", "android_common_myapex_image")
Jiyong Park7cd10e32020-01-14 09:22:18 +09006346 ensureRealfileExists(t, files, "javalib/myjar.jar")
6347 ensureRealfileExists(t, files, "lib64/mylib.so")
6348 ensureRealfileExists(t, files, "lib64/myotherlib.so")
6349
Jiyong Park9d677202020-02-19 16:29:35 +09006350 files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
6351 ensureRealfileExists(t, files, "javalib/myjar.jar")
6352 ensureRealfileExists(t, files, "lib64/mylib.so")
6353 ensureRealfileExists(t, files, "lib64/myotherlib.so")
6354
6355 // For bundled build, symlink to the system for the non-updatable APEXes only
Colin Cross1c460562021-02-16 17:55:47 -08006356 ctx = testApex(t, bp)
Jooyung Hana57af4a2020-01-23 05:36:59 +00006357 files = getFiles(t, ctx, "myapex", "android_common_myapex_image")
Jiyong Park7cd10e32020-01-14 09:22:18 +09006358 ensureRealfileExists(t, files, "javalib/myjar.jar")
6359 ensureRealfileExists(t, files, "lib64/mylib.so")
6360 ensureSymlinkExists(t, files, "lib64/myotherlib.so") // this is symlink
Jiyong Park9d677202020-02-19 16:29:35 +09006361
6362 files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
6363 ensureRealfileExists(t, files, "javalib/myjar.jar")
6364 ensureRealfileExists(t, files, "lib64/mylib.so")
6365 ensureRealfileExists(t, files, "lib64/myotherlib.so") // this is a real file
Jiyong Park7cd10e32020-01-14 09:22:18 +09006366}
6367
Yo Chiange8128052020-07-23 20:09:18 +08006368func TestSymlinksFromApexToSystemRequiredModuleNames(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006369 ctx := testApex(t, `
Yo Chiange8128052020-07-23 20:09:18 +08006370 apex {
6371 name: "myapex",
6372 key: "myapex.key",
6373 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006374 updatable: false,
Yo Chiange8128052020-07-23 20:09:18 +08006375 }
6376
6377 apex_key {
6378 name: "myapex.key",
6379 public_key: "testkey.avbpubkey",
6380 private_key: "testkey.pem",
6381 }
6382
6383 cc_library_shared {
6384 name: "mylib",
6385 srcs: ["mylib.cpp"],
6386 shared_libs: ["myotherlib"],
6387 system_shared_libs: [],
6388 stl: "none",
6389 apex_available: [
6390 "myapex",
6391 "//apex_available:platform",
6392 ],
6393 }
6394
6395 cc_prebuilt_library_shared {
6396 name: "myotherlib",
6397 srcs: ["prebuilt.so"],
6398 system_shared_libs: [],
6399 stl: "none",
6400 apex_available: [
6401 "myapex",
6402 "//apex_available:platform",
6403 ],
6404 }
6405 `)
6406
6407 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07006408 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Yo Chiange8128052020-07-23 20:09:18 +08006409 var builder strings.Builder
6410 data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
6411 androidMk := builder.String()
6412 // `myotherlib` is added to `myapex` as symlink
6413 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
6414 ensureNotContains(t, androidMk, "LOCAL_MODULE := prebuilt_myotherlib.myapex\n")
6415 ensureNotContains(t, androidMk, "LOCAL_MODULE := myotherlib.myapex\n")
6416 // `myapex` should have `myotherlib` in its required line, not `prebuilt_myotherlib`
Jiyong Park57621b22021-01-20 20:33:11 +09006417 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += mylib.myapex:64 myotherlib:64 apex_manifest.pb.myapex apex_pubkey.myapex\n")
Yo Chiange8128052020-07-23 20:09:18 +08006418}
6419
Jooyung Han643adc42020-02-27 13:50:06 +09006420func TestApexWithJniLibs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006421 ctx := testApex(t, `
Jooyung Han643adc42020-02-27 13:50:06 +09006422 apex {
6423 name: "myapex",
6424 key: "myapex.key",
6425 jni_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006426 updatable: false,
Jooyung Han643adc42020-02-27 13:50:06 +09006427 }
6428
6429 apex_key {
6430 name: "myapex.key",
6431 public_key: "testkey.avbpubkey",
6432 private_key: "testkey.pem",
6433 }
6434
6435 cc_library {
6436 name: "mylib",
6437 srcs: ["mylib.cpp"],
6438 shared_libs: ["mylib2"],
6439 system_shared_libs: [],
6440 stl: "none",
6441 apex_available: [ "myapex" ],
6442 }
6443
6444 cc_library {
6445 name: "mylib2",
6446 srcs: ["mylib.cpp"],
6447 system_shared_libs: [],
6448 stl: "none",
6449 apex_available: [ "myapex" ],
6450 }
6451 `)
6452
6453 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
6454 // Notice mylib2.so (transitive dep) is not added as a jni_lib
6455 ensureEquals(t, rule.Args["opt"], "-a jniLibs mylib.so")
6456 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
6457 "lib64/mylib.so",
6458 "lib64/mylib2.so",
6459 })
6460}
6461
Jooyung Han49f67012020-04-17 13:43:10 +09006462func TestApexMutatorsDontRunIfDisabled(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006463 ctx := testApex(t, `
Jooyung Han49f67012020-04-17 13:43:10 +09006464 apex {
6465 name: "myapex",
6466 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006467 updatable: false,
Jooyung Han49f67012020-04-17 13:43:10 +09006468 }
6469 apex_key {
6470 name: "myapex.key",
6471 public_key: "testkey.avbpubkey",
6472 private_key: "testkey.pem",
6473 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00006474 `,
6475 android.FixtureModifyConfig(func(config android.Config) {
6476 delete(config.Targets, android.Android)
6477 config.AndroidCommonTarget = android.Target{}
6478 }),
6479 )
Jooyung Han49f67012020-04-17 13:43:10 +09006480
6481 if expected, got := []string{""}, ctx.ModuleVariantsForTests("myapex"); !reflect.DeepEqual(expected, got) {
6482 t.Errorf("Expected variants: %v, but got: %v", expected, got)
6483 }
6484}
6485
Jiyong Parkbd159612020-02-28 15:22:21 +09006486func TestAppBundle(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006487 ctx := testApex(t, `
Jiyong Parkbd159612020-02-28 15:22:21 +09006488 apex {
6489 name: "myapex",
6490 key: "myapex.key",
6491 apps: ["AppFoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006492 updatable: false,
Jiyong Parkbd159612020-02-28 15:22:21 +09006493 }
6494
6495 apex_key {
6496 name: "myapex.key",
6497 public_key: "testkey.avbpubkey",
6498 private_key: "testkey.pem",
6499 }
6500
6501 android_app {
6502 name: "AppFoo",
6503 srcs: ["foo/bar/MyClass.java"],
6504 sdk_version: "none",
6505 system_modules: "none",
6506 apex_available: [ "myapex" ],
6507 }
Jiyong Parkcfaa1642020-02-28 16:51:07 +09006508 `, withManifestPackageNameOverrides([]string{"AppFoo:com.android.foo"}))
Jiyong Parkbd159612020-02-28 15:22:21 +09006509
Colin Crosscf371cc2020-11-13 11:48:42 -08006510 bundleConfigRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("bundle_config.json")
Jiyong Parkbd159612020-02-28 15:22:21 +09006511 content := bundleConfigRule.Args["content"]
6512
6513 ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
Jiyong Parkcfaa1642020-02-28 16:51:07 +09006514 ensureContains(t, content, `"apex_config":{"apex_embedded_apk_config":[{"package_name":"com.android.foo","path":"app/AppFoo/AppFoo.apk"}]}`)
Jiyong Parkbd159612020-02-28 15:22:21 +09006515}
6516
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006517func TestAppSetBundle(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006518 ctx := testApex(t, `
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006519 apex {
6520 name: "myapex",
6521 key: "myapex.key",
6522 apps: ["AppSet"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006523 updatable: false,
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006524 }
6525
6526 apex_key {
6527 name: "myapex.key",
6528 public_key: "testkey.avbpubkey",
6529 private_key: "testkey.pem",
6530 }
6531
6532 android_app_set {
6533 name: "AppSet",
6534 set: "AppSet.apks",
6535 }`)
6536 mod := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Colin Crosscf371cc2020-11-13 11:48:42 -08006537 bundleConfigRule := mod.Output("bundle_config.json")
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006538 content := bundleConfigRule.Args["content"]
6539 ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
6540 s := mod.Rule("apexRule").Args["copy_commands"]
6541 copyCmds := regexp.MustCompile(" *&& *").Split(s, -1)
6542 if len(copyCmds) != 3 {
6543 t.Fatalf("Expected 3 commands, got %d in:\n%s", len(copyCmds), s)
6544 }
6545 ensureMatches(t, copyCmds[0], "^rm -rf .*/app/AppSet$")
6546 ensureMatches(t, copyCmds[1], "^mkdir -p .*/app/AppSet$")
6547 ensureMatches(t, copyCmds[2], "^unzip .*-d .*/app/AppSet .*/AppSet.zip$")
6548}
6549
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006550func TestAppSetBundlePrebuilt(t *testing.T) {
Paul Duffin24704672021-04-06 16:09:30 +01006551 bp := `
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006552 apex_set {
6553 name: "myapex",
6554 filename: "foo_v2.apex",
6555 sanitized: {
6556 none: { set: "myapex.apks", },
6557 hwaddress: { set: "myapex.hwasan.apks", },
6558 },
Paul Duffin24704672021-04-06 16:09:30 +01006559 }
6560 `
6561 ctx := testApex(t, bp, prepareForTestWithSantitizeHwaddress)
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006562
Paul Duffin24704672021-04-06 16:09:30 +01006563 // Check that the extractor produces the correct output file from the correct input file.
6564 extractorOutput := "out/soong/.intermediates/myapex.apex.extractor/android_common/extracted/myapex.hwasan.apks"
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006565
Paul Duffin24704672021-04-06 16:09:30 +01006566 m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
6567 extractedApex := m.Output(extractorOutput)
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006568
Paul Duffin24704672021-04-06 16:09:30 +01006569 android.AssertArrayString(t, "extractor input", []string{"myapex.hwasan.apks"}, extractedApex.Inputs.Strings())
6570
6571 // Ditto for the apex.
Paul Duffin6717d882021-06-15 19:09:41 +01006572 m = ctx.ModuleForTests("myapex", "android_common_myapex")
6573 copiedApex := m.Output("out/soong/.intermediates/myapex/android_common_myapex/foo_v2.apex")
Paul Duffin24704672021-04-06 16:09:30 +01006574
6575 android.AssertStringEquals(t, "myapex input", extractorOutput, copiedApex.Input.String())
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006576}
6577
Paul Duffin89f570a2021-06-16 01:42:33 +01006578func testNoUpdatableJarsInBootImage(t *testing.T, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) {
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006579 t.Helper()
6580
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006581 bp := `
6582 java_library {
6583 name: "some-updatable-apex-lib",
6584 srcs: ["a.java"],
6585 sdk_version: "current",
6586 apex_available: [
6587 "some-updatable-apex",
6588 ],
6589 }
6590
6591 java_library {
6592 name: "some-non-updatable-apex-lib",
6593 srcs: ["a.java"],
6594 apex_available: [
6595 "some-non-updatable-apex",
6596 ],
Paul Duffin89f570a2021-06-16 01:42:33 +01006597 compile_dex: true,
6598 }
6599
6600 bootclasspath_fragment {
6601 name: "some-non-updatable-fragment",
6602 contents: ["some-non-updatable-apex-lib"],
6603 apex_available: [
6604 "some-non-updatable-apex",
6605 ],
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006606 }
6607
6608 java_library {
6609 name: "some-platform-lib",
6610 srcs: ["a.java"],
6611 sdk_version: "current",
6612 installable: true,
6613 }
6614
6615 java_library {
6616 name: "some-art-lib",
6617 srcs: ["a.java"],
6618 sdk_version: "current",
6619 apex_available: [
Paul Duffind376f792021-01-26 11:59:35 +00006620 "com.android.art.debug",
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006621 ],
6622 hostdex: true,
Paul Duffine5218812021-06-07 13:28:19 +01006623 compile_dex: true,
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006624 }
6625
6626 apex {
6627 name: "some-updatable-apex",
6628 key: "some-updatable-apex.key",
6629 java_libs: ["some-updatable-apex-lib"],
6630 updatable: true,
6631 min_sdk_version: "current",
6632 }
6633
6634 apex {
6635 name: "some-non-updatable-apex",
6636 key: "some-non-updatable-apex.key",
Paul Duffin89f570a2021-06-16 01:42:33 +01006637 bootclasspath_fragments: ["some-non-updatable-fragment"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006638 updatable: false,
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006639 }
6640
6641 apex_key {
6642 name: "some-updatable-apex.key",
6643 }
6644
6645 apex_key {
6646 name: "some-non-updatable-apex.key",
6647 }
6648
6649 apex {
Paul Duffind376f792021-01-26 11:59:35 +00006650 name: "com.android.art.debug",
6651 key: "com.android.art.debug.key",
Paul Duffin89f570a2021-06-16 01:42:33 +01006652 bootclasspath_fragments: ["art-bootclasspath-fragment"],
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006653 updatable: true,
6654 min_sdk_version: "current",
6655 }
6656
Paul Duffinf23bc472021-04-27 12:42:20 +01006657 bootclasspath_fragment {
6658 name: "art-bootclasspath-fragment",
6659 image_name: "art",
6660 contents: ["some-art-lib"],
6661 apex_available: [
6662 "com.android.art.debug",
6663 ],
6664 }
6665
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006666 apex_key {
Paul Duffind376f792021-01-26 11:59:35 +00006667 name: "com.android.art.debug.key",
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006668 }
6669
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006670 filegroup {
6671 name: "some-updatable-apex-file_contexts",
6672 srcs: [
6673 "system/sepolicy/apex/some-updatable-apex-file_contexts",
6674 ],
6675 }
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01006676
6677 filegroup {
6678 name: "some-non-updatable-apex-file_contexts",
6679 srcs: [
6680 "system/sepolicy/apex/some-non-updatable-apex-file_contexts",
6681 ],
6682 }
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006683 `
Paul Duffinc3bbb962020-12-10 19:15:49 +00006684
Paul Duffin89f570a2021-06-16 01:42:33 +01006685 testDexpreoptWithApexes(t, bp, errmsg, preparer, fragments...)
Paul Duffinc3bbb962020-12-10 19:15:49 +00006686}
6687
Paul Duffin89f570a2021-06-16 01:42:33 +01006688func testDexpreoptWithApexes(t *testing.T, bp, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) *android.TestContext {
Paul Duffinc3bbb962020-12-10 19:15:49 +00006689 t.Helper()
6690
Paul Duffin55607122021-03-30 23:32:51 +01006691 fs := android.MockFS{
6692 "a.java": nil,
6693 "a.jar": nil,
6694 "apex_manifest.json": nil,
6695 "AndroidManifest.xml": nil,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00006696 "system/sepolicy/apex/myapex-file_contexts": nil,
Paul Duffind376f792021-01-26 11:59:35 +00006697 "system/sepolicy/apex/some-updatable-apex-file_contexts": nil,
6698 "system/sepolicy/apex/some-non-updatable-apex-file_contexts": nil,
6699 "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00006700 "framework/aidl/a.aidl": nil,
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006701 }
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006702
Paul Duffin55607122021-03-30 23:32:51 +01006703 errorHandler := android.FixtureExpectsNoErrors
6704 if errmsg != "" {
6705 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006706 }
Paul Duffin064b70c2020-11-02 17:32:38 +00006707
Paul Duffin55607122021-03-30 23:32:51 +01006708 result := android.GroupFixturePreparers(
6709 cc.PrepareForTestWithCcDefaultModules,
6710 java.PrepareForTestWithHiddenApiBuildComponents,
6711 java.PrepareForTestWithJavaDefaultModules,
6712 java.PrepareForTestWithJavaSdkLibraryFiles,
6713 PrepareForTestWithApexBuildComponents,
Paul Duffin60264a02021-04-12 20:02:36 +01006714 preparer,
Paul Duffin55607122021-03-30 23:32:51 +01006715 fs.AddToFixture(),
Paul Duffin89f570a2021-06-16 01:42:33 +01006716 android.FixtureModifyMockFS(func(fs android.MockFS) {
6717 if _, ok := fs["frameworks/base/boot/Android.bp"]; !ok {
6718 insert := ""
6719 for _, fragment := range fragments {
6720 insert += fmt.Sprintf("{apex: %q, module: %q},\n", *fragment.Apex, *fragment.Module)
6721 }
6722 fs["frameworks/base/boot/Android.bp"] = []byte(fmt.Sprintf(`
6723 platform_bootclasspath {
6724 name: "platform-bootclasspath",
6725 fragments: [
6726 %s
6727 ],
6728 }
6729 `, insert))
Paul Duffin8f146b92021-04-12 17:24:18 +01006730 }
Paul Duffin89f570a2021-06-16 01:42:33 +01006731 }),
Paul Duffin55607122021-03-30 23:32:51 +01006732 ).
6733 ExtendWithErrorHandler(errorHandler).
6734 RunTestWithBp(t, bp)
6735
6736 return result.TestContext
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006737}
6738
Jooyung Han548640b2020-04-27 12:10:30 +09006739func TestUpdatable_should_set_min_sdk_version(t *testing.T) {
6740 testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
6741 apex {
6742 name: "myapex",
6743 key: "myapex.key",
6744 updatable: true,
6745 }
6746
6747 apex_key {
6748 name: "myapex.key",
6749 public_key: "testkey.avbpubkey",
6750 private_key: "testkey.pem",
6751 }
6752 `)
6753}
6754
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006755func TestUpdatableDefault_should_set_min_sdk_version(t *testing.T) {
6756 testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
6757 apex {
6758 name: "myapex",
6759 key: "myapex.key",
6760 }
6761
6762 apex_key {
6763 name: "myapex.key",
6764 public_key: "testkey.avbpubkey",
6765 private_key: "testkey.pem",
6766 }
6767 `)
6768}
6769
satayevb98371c2021-06-15 16:49:50 +01006770func TestUpdatable_should_not_set_generate_classpaths_proto(t *testing.T) {
6771 testApexError(t, `"mysystemserverclasspathfragment" .* it must not set generate_classpaths_proto to false`, `
6772 apex {
6773 name: "myapex",
6774 key: "myapex.key",
6775 systemserverclasspath_fragments: [
6776 "mysystemserverclasspathfragment",
6777 ],
6778 min_sdk_version: "29",
6779 updatable: true,
6780 }
6781
6782 apex_key {
6783 name: "myapex.key",
6784 public_key: "testkey.avbpubkey",
6785 private_key: "testkey.pem",
6786 }
6787
6788 java_library {
6789 name: "foo",
6790 srcs: ["b.java"],
6791 min_sdk_version: "29",
6792 installable: true,
6793 apex_available: [
6794 "myapex",
6795 ],
6796 }
6797
6798 systemserverclasspath_fragment {
6799 name: "mysystemserverclasspathfragment",
6800 generate_classpaths_proto: false,
6801 contents: [
6802 "foo",
6803 ],
6804 apex_available: [
6805 "myapex",
6806 ],
6807 }
6808 `)
6809}
6810
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006811func TestNoUpdatableJarsInBootImage(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006812 // Set the BootJars in dexpreopt.GlobalConfig and productVariables to the same value. This can
6813 // result in an invalid configuration as it does not set the ArtApexJars and allows art apex
6814 // modules to be included in the BootJars.
6815 prepareSetBootJars := func(bootJars ...string) android.FixturePreparer {
6816 return android.GroupFixturePreparers(
6817 dexpreopt.FixtureSetBootJars(bootJars...),
6818 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
6819 variables.BootJars = android.CreateTestConfiguredJarList(bootJars)
6820 }),
6821 )
6822 }
6823
6824 // Set the ArtApexJars and BootJars in dexpreopt.GlobalConfig and productVariables all to the
6825 // same value. This can result in an invalid configuration as it allows non art apex jars to be
6826 // specified in the ArtApexJars configuration.
6827 prepareSetArtJars := func(bootJars ...string) android.FixturePreparer {
6828 return android.GroupFixturePreparers(
6829 dexpreopt.FixtureSetArtBootJars(bootJars...),
6830 dexpreopt.FixtureSetBootJars(bootJars...),
6831 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
6832 variables.BootJars = android.CreateTestConfiguredJarList(bootJars)
6833 }),
6834 )
6835 }
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006836
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006837 t.Run("updatable jar from ART apex in the ART boot image => ok", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006838 preparer := java.FixtureConfigureBootJars("com.android.art.debug:some-art-lib")
Paul Duffin89f570a2021-06-16 01:42:33 +01006839 fragment := java.ApexVariantReference{
6840 Apex: proptools.StringPtr("com.android.art.debug"),
6841 Module: proptools.StringPtr("art-bootclasspath-fragment"),
6842 }
6843 testNoUpdatableJarsInBootImage(t, "", preparer, fragment)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006844 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006845
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006846 t.Run("updatable jar from ART apex in the framework boot image => error", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006847 err := `module "some-art-lib" from updatable apexes \["com.android.art.debug"\] is not allowed in the framework boot image`
6848 // Update the dexpreopt BootJars directly.
6849 preparer := prepareSetBootJars("com.android.art.debug:some-art-lib")
6850 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006851 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006852
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006853 t.Run("updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
Paul Duffinf23bc472021-04-27 12:42:20 +01006854 err := `ArtApexJars expects this to be in apex "some-updatable-apex" but this is only in apexes.*"com.android.art.debug"`
Paul Duffin60264a02021-04-12 20:02:36 +01006855 // Update the dexpreopt ArtApexJars directly.
6856 preparer := prepareSetArtJars("some-updatable-apex:some-updatable-apex-lib")
6857 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006858 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006859
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006860 t.Run("non-updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
Paul Duffinf23bc472021-04-27 12:42:20 +01006861 err := `ArtApexJars expects this to be in apex "some-non-updatable-apex" but this is only in apexes.*"com.android.art.debug"`
Paul Duffin60264a02021-04-12 20:02:36 +01006862 // Update the dexpreopt ArtApexJars directly.
6863 preparer := prepareSetArtJars("some-non-updatable-apex:some-non-updatable-apex-lib")
6864 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006865 })
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01006866
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006867 t.Run("updatable jar from some other apex in the framework boot image => error", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006868 err := `module "some-updatable-apex-lib" from updatable apexes \["some-updatable-apex"\] is not allowed in the framework boot image`
6869 preparer := java.FixtureConfigureBootJars("some-updatable-apex:some-updatable-apex-lib")
6870 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006871 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006872
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006873 t.Run("non-updatable jar from some other apex in the framework boot image => ok", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006874 preparer := java.FixtureConfigureBootJars("some-non-updatable-apex:some-non-updatable-apex-lib")
Paul Duffin89f570a2021-06-16 01:42:33 +01006875 fragment := java.ApexVariantReference{
6876 Apex: proptools.StringPtr("some-non-updatable-apex"),
6877 Module: proptools.StringPtr("some-non-updatable-fragment"),
6878 }
6879 testNoUpdatableJarsInBootImage(t, "", preparer, fragment)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006880 })
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01006881
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006882 t.Run("nonexistent jar in the ART boot image => error", func(t *testing.T) {
Paul Duffin8f146b92021-04-12 17:24:18 +01006883 err := `"platform-bootclasspath" depends on undefined module "nonexistent"`
Paul Duffin60264a02021-04-12 20:02:36 +01006884 preparer := java.FixtureConfigureBootJars("platform:nonexistent")
6885 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006886 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006887
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006888 t.Run("nonexistent jar in the framework boot image => error", func(t *testing.T) {
Paul Duffin8f146b92021-04-12 17:24:18 +01006889 err := `"platform-bootclasspath" depends on undefined module "nonexistent"`
Paul Duffin60264a02021-04-12 20:02:36 +01006890 preparer := java.FixtureConfigureBootJars("platform:nonexistent")
6891 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006892 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006893
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006894 t.Run("platform jar in the ART boot image => error", func(t *testing.T) {
Paul Duffinf23bc472021-04-27 12:42:20 +01006895 err := `ArtApexJars is invalid as it requests a platform variant of "some-platform-lib"`
Paul Duffin60264a02021-04-12 20:02:36 +01006896 // Update the dexpreopt ArtApexJars directly.
6897 preparer := prepareSetArtJars("platform:some-platform-lib")
6898 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006899 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006900
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006901 t.Run("platform jar in the framework boot image => ok", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006902 preparer := java.FixtureConfigureBootJars("platform:some-platform-lib")
6903 testNoUpdatableJarsInBootImage(t, "", preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006904 })
Paul Duffin064b70c2020-11-02 17:32:38 +00006905}
6906
6907func TestDexpreoptAccessDexFilesFromPrebuiltApex(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006908 preparer := java.FixtureConfigureBootJars("myapex:libfoo")
Paul Duffin064b70c2020-11-02 17:32:38 +00006909 t.Run("prebuilt no source", func(t *testing.T) {
Paul Duffin89f570a2021-06-16 01:42:33 +01006910 fragment := java.ApexVariantReference{
6911 Apex: proptools.StringPtr("myapex"),
6912 Module: proptools.StringPtr("my-bootclasspath-fragment"),
6913 }
6914
Paul Duffin064b70c2020-11-02 17:32:38 +00006915 testDexpreoptWithApexes(t, `
6916 prebuilt_apex {
6917 name: "myapex" ,
6918 arch: {
6919 arm64: {
6920 src: "myapex-arm64.apex",
6921 },
6922 arm: {
6923 src: "myapex-arm.apex",
6924 },
6925 },
Paul Duffin89f570a2021-06-16 01:42:33 +01006926 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
6927 }
Paul Duffin064b70c2020-11-02 17:32:38 +00006928
Paul Duffin89f570a2021-06-16 01:42:33 +01006929 prebuilt_bootclasspath_fragment {
6930 name: "my-bootclasspath-fragment",
6931 contents: ["libfoo"],
6932 apex_available: ["myapex"],
6933 }
Paul Duffin064b70c2020-11-02 17:32:38 +00006934
Paul Duffin89f570a2021-06-16 01:42:33 +01006935 java_import {
6936 name: "libfoo",
6937 jars: ["libfoo.jar"],
6938 apex_available: ["myapex"],
6939 }
6940 `, "", preparer, fragment)
Paul Duffin064b70c2020-11-02 17:32:38 +00006941 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006942}
6943
Andrei Onea115e7e72020-06-05 21:14:03 +01006944func testApexPermittedPackagesRules(t *testing.T, errmsg, bp string, apexBootJars []string, rules []android.Rule) {
6945 t.Helper()
Andrei Onea115e7e72020-06-05 21:14:03 +01006946 bp += `
6947 apex_key {
6948 name: "myapex.key",
6949 public_key: "testkey.avbpubkey",
6950 private_key: "testkey.pem",
6951 }`
Paul Duffin45338f02021-03-30 23:07:52 +01006952 fs := android.MockFS{
Andrei Onea115e7e72020-06-05 21:14:03 +01006953 "lib1/src/A.java": nil,
6954 "lib2/src/B.java": nil,
6955 "system/sepolicy/apex/myapex-file_contexts": nil,
6956 }
6957
Paul Duffin45338f02021-03-30 23:07:52 +01006958 errorHandler := android.FixtureExpectsNoErrors
6959 if errmsg != "" {
6960 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
Colin Crossae8600b2020-10-29 17:09:13 -07006961 }
Colin Crossae8600b2020-10-29 17:09:13 -07006962
Paul Duffin45338f02021-03-30 23:07:52 +01006963 android.GroupFixturePreparers(
6964 android.PrepareForTestWithAndroidBuildComponents,
6965 java.PrepareForTestWithJavaBuildComponents,
6966 PrepareForTestWithApexBuildComponents,
6967 android.PrepareForTestWithNeverallowRules(rules),
6968 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
6969 updatableBootJars := make([]string, 0, len(apexBootJars))
6970 for _, apexBootJar := range apexBootJars {
6971 updatableBootJars = append(updatableBootJars, "myapex:"+apexBootJar)
6972 }
6973 variables.UpdatableBootJars = android.CreateTestConfiguredJarList(updatableBootJars)
6974 }),
6975 fs.AddToFixture(),
6976 ).
6977 ExtendWithErrorHandler(errorHandler).
6978 RunTestWithBp(t, bp)
Andrei Onea115e7e72020-06-05 21:14:03 +01006979}
6980
6981func TestApexPermittedPackagesRules(t *testing.T) {
6982 testcases := []struct {
6983 name string
6984 expectedError string
6985 bp string
6986 bootJars []string
6987 modulesPackages map[string][]string
6988 }{
6989
6990 {
6991 name: "Non-Bootclasspath apex jar not satisfying allowed module packages.",
6992 expectedError: "",
6993 bp: `
6994 java_library {
6995 name: "bcp_lib1",
6996 srcs: ["lib1/src/*.java"],
6997 permitted_packages: ["foo.bar"],
6998 apex_available: ["myapex"],
6999 sdk_version: "none",
7000 system_modules: "none",
7001 }
7002 java_library {
7003 name: "nonbcp_lib2",
7004 srcs: ["lib2/src/*.java"],
7005 apex_available: ["myapex"],
7006 permitted_packages: ["a.b"],
7007 sdk_version: "none",
7008 system_modules: "none",
7009 }
7010 apex {
7011 name: "myapex",
7012 key: "myapex.key",
7013 java_libs: ["bcp_lib1", "nonbcp_lib2"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007014 updatable: false,
Andrei Onea115e7e72020-06-05 21:14:03 +01007015 }`,
7016 bootJars: []string{"bcp_lib1"},
7017 modulesPackages: map[string][]string{
7018 "myapex": []string{
7019 "foo.bar",
7020 },
7021 },
7022 },
7023 {
7024 name: "Bootclasspath apex jar not satisfying allowed module packages.",
7025 expectedError: `module "bcp_lib2" .* which is restricted because jars that are part of the myapex module may only allow these packages: foo.bar. Please jarjar or move code around.`,
7026 bp: `
7027 java_library {
7028 name: "bcp_lib1",
7029 srcs: ["lib1/src/*.java"],
7030 apex_available: ["myapex"],
7031 permitted_packages: ["foo.bar"],
7032 sdk_version: "none",
7033 system_modules: "none",
7034 }
7035 java_library {
7036 name: "bcp_lib2",
7037 srcs: ["lib2/src/*.java"],
7038 apex_available: ["myapex"],
7039 permitted_packages: ["foo.bar", "bar.baz"],
7040 sdk_version: "none",
7041 system_modules: "none",
7042 }
7043 apex {
7044 name: "myapex",
7045 key: "myapex.key",
7046 java_libs: ["bcp_lib1", "bcp_lib2"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007047 updatable: false,
Andrei Onea115e7e72020-06-05 21:14:03 +01007048 }
7049 `,
7050 bootJars: []string{"bcp_lib1", "bcp_lib2"},
7051 modulesPackages: map[string][]string{
7052 "myapex": []string{
7053 "foo.bar",
7054 },
7055 },
7056 },
7057 }
7058 for _, tc := range testcases {
7059 t.Run(tc.name, func(t *testing.T) {
7060 rules := createApexPermittedPackagesRules(tc.modulesPackages)
7061 testApexPermittedPackagesRules(t, tc.expectedError, tc.bp, tc.bootJars, rules)
7062 })
7063 }
7064}
7065
Jiyong Park62304bb2020-04-13 16:19:48 +09007066func TestTestFor(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007067 ctx := testApex(t, `
Jiyong Park62304bb2020-04-13 16:19:48 +09007068 apex {
7069 name: "myapex",
7070 key: "myapex.key",
7071 native_shared_libs: ["mylib", "myprivlib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007072 updatable: false,
Jiyong Park62304bb2020-04-13 16:19:48 +09007073 }
7074
7075 apex_key {
7076 name: "myapex.key",
7077 public_key: "testkey.avbpubkey",
7078 private_key: "testkey.pem",
7079 }
7080
7081 cc_library {
7082 name: "mylib",
7083 srcs: ["mylib.cpp"],
7084 system_shared_libs: [],
7085 stl: "none",
7086 stubs: {
7087 versions: ["1"],
7088 },
7089 apex_available: ["myapex"],
7090 }
7091
7092 cc_library {
7093 name: "myprivlib",
7094 srcs: ["mylib.cpp"],
7095 system_shared_libs: [],
7096 stl: "none",
7097 apex_available: ["myapex"],
7098 }
7099
7100
7101 cc_test {
7102 name: "mytest",
7103 gtest: false,
7104 srcs: ["mylib.cpp"],
7105 system_shared_libs: [],
7106 stl: "none",
Jiyong Park46a512f2020-12-04 18:02:13 +09007107 shared_libs: ["mylib", "myprivlib", "mytestlib"],
Jiyong Park62304bb2020-04-13 16:19:48 +09007108 test_for: ["myapex"]
7109 }
Jiyong Park46a512f2020-12-04 18:02:13 +09007110
7111 cc_library {
7112 name: "mytestlib",
7113 srcs: ["mylib.cpp"],
7114 system_shared_libs: [],
7115 shared_libs: ["mylib", "myprivlib"],
7116 stl: "none",
7117 test_for: ["myapex"],
7118 }
7119
7120 cc_benchmark {
7121 name: "mybench",
7122 srcs: ["mylib.cpp"],
7123 system_shared_libs: [],
7124 shared_libs: ["mylib", "myprivlib"],
7125 stl: "none",
7126 test_for: ["myapex"],
7127 }
Jiyong Park62304bb2020-04-13 16:19:48 +09007128 `)
7129
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007130 ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
Paul Duffina71a67a2021-03-29 00:42:57 +01007131 ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007132 mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
7133 android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
7134 }
7135
7136 // These modules are tests for the apex, therefore are linked to the
Jiyong Park62304bb2020-04-13 16:19:48 +09007137 // actual implementation of mylib instead of its stub.
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007138 ensureLinkedLibIs("mytest", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
7139 ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
7140 ensureLinkedLibIs("mybench", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
7141}
Jiyong Park46a512f2020-12-04 18:02:13 +09007142
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007143func TestIndirectTestFor(t *testing.T) {
7144 ctx := testApex(t, `
7145 apex {
7146 name: "myapex",
7147 key: "myapex.key",
7148 native_shared_libs: ["mylib", "myprivlib"],
7149 updatable: false,
7150 }
Jiyong Park46a512f2020-12-04 18:02:13 +09007151
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007152 apex_key {
7153 name: "myapex.key",
7154 public_key: "testkey.avbpubkey",
7155 private_key: "testkey.pem",
7156 }
7157
7158 cc_library {
7159 name: "mylib",
7160 srcs: ["mylib.cpp"],
7161 system_shared_libs: [],
7162 stl: "none",
7163 stubs: {
7164 versions: ["1"],
7165 },
7166 apex_available: ["myapex"],
7167 }
7168
7169 cc_library {
7170 name: "myprivlib",
7171 srcs: ["mylib.cpp"],
7172 system_shared_libs: [],
7173 stl: "none",
7174 shared_libs: ["mylib"],
7175 apex_available: ["myapex"],
7176 }
7177
7178 cc_library {
7179 name: "mytestlib",
7180 srcs: ["mylib.cpp"],
7181 system_shared_libs: [],
7182 shared_libs: ["myprivlib"],
7183 stl: "none",
7184 test_for: ["myapex"],
7185 }
7186 `)
7187
7188 ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
Paul Duffina71a67a2021-03-29 00:42:57 +01007189 ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007190 mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
7191 android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
7192 }
7193
7194 // The platform variant of mytestlib links to the platform variant of the
7195 // internal myprivlib.
7196 ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/myprivlib/", "android_arm64_armv8-a_shared/myprivlib.so")
7197
7198 // The platform variant of myprivlib links to the platform variant of mylib
7199 // and bypasses its stubs.
7200 ensureLinkedLibIs("myprivlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
Jiyong Park62304bb2020-04-13 16:19:48 +09007201}
7202
Martin Stjernholmec009002021-03-27 15:18:31 +00007203func TestTestForForLibInOtherApex(t *testing.T) {
7204 // This case is only allowed for known overlapping APEXes, i.e. the ART APEXes.
7205 _ = testApex(t, `
7206 apex {
7207 name: "com.android.art",
7208 key: "myapex.key",
7209 native_shared_libs: ["mylib"],
7210 updatable: false,
7211 }
7212
7213 apex {
7214 name: "com.android.art.debug",
7215 key: "myapex.key",
7216 native_shared_libs: ["mylib", "mytestlib"],
7217 updatable: false,
7218 }
7219
7220 apex_key {
7221 name: "myapex.key",
7222 public_key: "testkey.avbpubkey",
7223 private_key: "testkey.pem",
7224 }
7225
7226 cc_library {
7227 name: "mylib",
7228 srcs: ["mylib.cpp"],
7229 system_shared_libs: [],
7230 stl: "none",
7231 stubs: {
7232 versions: ["1"],
7233 },
7234 apex_available: ["com.android.art", "com.android.art.debug"],
7235 }
7236
7237 cc_library {
7238 name: "mytestlib",
7239 srcs: ["mylib.cpp"],
7240 system_shared_libs: [],
7241 shared_libs: ["mylib"],
7242 stl: "none",
7243 apex_available: ["com.android.art.debug"],
7244 test_for: ["com.android.art"],
7245 }
7246 `,
7247 android.MockFS{
7248 "system/sepolicy/apex/com.android.art-file_contexts": nil,
7249 "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
7250 }.AddToFixture())
7251}
7252
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007253// TODO(jungjw): Move this to proptools
7254func intPtr(i int) *int {
7255 return &i
7256}
7257
7258func TestApexSet(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007259 ctx := testApex(t, `
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007260 apex_set {
7261 name: "myapex",
7262 set: "myapex.apks",
7263 filename: "foo_v2.apex",
7264 overrides: ["foo"],
7265 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00007266 `,
7267 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
7268 variables.Platform_sdk_version = intPtr(30)
7269 }),
7270 android.FixtureModifyConfig(func(config android.Config) {
7271 config.Targets[android.Android] = []android.Target{
7272 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}},
7273 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}},
7274 }
7275 }),
7276 )
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007277
Paul Duffin24704672021-04-06 16:09:30 +01007278 m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007279
7280 // Check extract_apks tool parameters.
Paul Duffin24704672021-04-06 16:09:30 +01007281 extractedApex := m.Output("extracted/myapex.apks")
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007282 actual := extractedApex.Args["abis"]
7283 expected := "ARMEABI_V7A,ARM64_V8A"
7284 if actual != expected {
7285 t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
7286 }
7287 actual = extractedApex.Args["sdk-version"]
7288 expected = "30"
7289 if actual != expected {
7290 t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
7291 }
7292
Paul Duffin6717d882021-06-15 19:09:41 +01007293 m = ctx.ModuleForTests("myapex", "android_common_myapex")
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007294 a := m.Module().(*ApexSet)
7295 expectedOverrides := []string{"foo"}
Colin Crossaa255532020-07-03 13:18:24 -07007296 actualOverrides := android.AndroidMkEntriesForTest(t, ctx, a)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007297 if !reflect.DeepEqual(actualOverrides, expectedOverrides) {
7298 t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES - expected %q vs actual %q", expectedOverrides, actualOverrides)
7299 }
7300}
7301
Jiyong Park7d95a512020-05-10 15:16:24 +09007302func TestNoStaticLinkingToStubsLib(t *testing.T) {
7303 testApexError(t, `.*required by "mylib" is a native library providing stub.*`, `
7304 apex {
7305 name: "myapex",
7306 key: "myapex.key",
7307 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007308 updatable: false,
Jiyong Park7d95a512020-05-10 15:16:24 +09007309 }
7310
7311 apex_key {
7312 name: "myapex.key",
7313 public_key: "testkey.avbpubkey",
7314 private_key: "testkey.pem",
7315 }
7316
7317 cc_library {
7318 name: "mylib",
7319 srcs: ["mylib.cpp"],
7320 static_libs: ["otherlib"],
7321 system_shared_libs: [],
7322 stl: "none",
7323 apex_available: [ "myapex" ],
7324 }
7325
7326 cc_library {
7327 name: "otherlib",
7328 srcs: ["mylib.cpp"],
7329 system_shared_libs: [],
7330 stl: "none",
7331 stubs: {
7332 versions: ["1", "2", "3"],
7333 },
7334 apex_available: [ "myapex" ],
7335 }
7336 `)
7337}
7338
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007339func TestApexKeysTxt(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007340 ctx := testApex(t, `
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007341 apex {
7342 name: "myapex",
7343 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007344 updatable: false,
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007345 }
7346
7347 apex_key {
7348 name: "myapex.key",
7349 public_key: "testkey.avbpubkey",
7350 private_key: "testkey.pem",
7351 }
7352
7353 prebuilt_apex {
7354 name: "myapex",
7355 prefer: true,
7356 arch: {
7357 arm64: {
7358 src: "myapex-arm64.apex",
7359 },
7360 arm: {
7361 src: "myapex-arm.apex",
7362 },
7363 },
7364 }
7365
7366 apex_set {
7367 name: "myapex_set",
7368 set: "myapex.apks",
7369 filename: "myapex_set.apex",
7370 overrides: ["myapex"],
7371 }
7372 `)
7373
7374 apexKeysText := ctx.SingletonForTests("apex_keys_text")
7375 content := apexKeysText.MaybeDescription("apexkeys.txt").BuildParams.Args["content"]
7376 ensureContains(t, content, `name="myapex_set.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
Jiyong Park03a7f3e2020-06-18 19:34:42 +09007377 ensureContains(t, content, `name="myapex.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007378}
7379
Jooyung Han938b5932020-06-20 12:47:47 +09007380func TestAllowedFiles(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007381 ctx := testApex(t, `
Jooyung Han938b5932020-06-20 12:47:47 +09007382 apex {
7383 name: "myapex",
7384 key: "myapex.key",
7385 apps: ["app"],
7386 allowed_files: "allowed.txt",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007387 updatable: false,
Jooyung Han938b5932020-06-20 12:47:47 +09007388 }
7389
7390 apex_key {
7391 name: "myapex.key",
7392 public_key: "testkey.avbpubkey",
7393 private_key: "testkey.pem",
7394 }
7395
7396 android_app {
7397 name: "app",
7398 srcs: ["foo/bar/MyClass.java"],
7399 package_name: "foo",
7400 sdk_version: "none",
7401 system_modules: "none",
7402 apex_available: [ "myapex" ],
7403 }
7404 `, withFiles(map[string][]byte{
7405 "sub/Android.bp": []byte(`
7406 override_apex {
7407 name: "override_myapex",
7408 base: "myapex",
7409 apps: ["override_app"],
7410 allowed_files: ":allowed",
7411 }
7412 // Overridable "path" property should be referenced indirectly
7413 filegroup {
7414 name: "allowed",
7415 srcs: ["allowed.txt"],
7416 }
7417 override_android_app {
7418 name: "override_app",
7419 base: "app",
7420 package_name: "bar",
7421 }
7422 `),
7423 }))
7424
7425 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("diffApexContentRule")
7426 if expected, actual := "allowed.txt", rule.Args["allowed_files_file"]; expected != actual {
7427 t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
7428 }
7429
7430 rule2 := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Rule("diffApexContentRule")
7431 if expected, actual := "sub/allowed.txt", rule2.Args["allowed_files_file"]; expected != actual {
7432 t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
7433 }
7434}
7435
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007436func TestNonPreferredPrebuiltDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007437 testApex(t, `
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007438 apex {
7439 name: "myapex",
7440 key: "myapex.key",
7441 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007442 updatable: false,
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007443 }
7444
7445 apex_key {
7446 name: "myapex.key",
7447 public_key: "testkey.avbpubkey",
7448 private_key: "testkey.pem",
7449 }
7450
7451 cc_library {
7452 name: "mylib",
7453 srcs: ["mylib.cpp"],
7454 stubs: {
Dan Albertc8060532020-07-22 22:32:17 -07007455 versions: ["current"],
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007456 },
7457 apex_available: ["myapex"],
7458 }
7459
7460 cc_prebuilt_library_shared {
7461 name: "mylib",
7462 prefer: false,
7463 srcs: ["prebuilt.so"],
7464 stubs: {
Dan Albertc8060532020-07-22 22:32:17 -07007465 versions: ["current"],
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007466 },
7467 apex_available: ["myapex"],
7468 }
7469 `)
7470}
7471
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007472func TestCompressedApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007473 ctx := testApex(t, `
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007474 apex {
7475 name: "myapex",
7476 key: "myapex.key",
7477 compressible: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007478 updatable: false,
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007479 }
7480 apex_key {
7481 name: "myapex.key",
7482 public_key: "testkey.avbpubkey",
7483 private_key: "testkey.pem",
7484 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00007485 `,
7486 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
7487 variables.CompressedApex = proptools.BoolPtr(true)
7488 }),
7489 )
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007490
7491 compressRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("compressRule")
7492 ensureContains(t, compressRule.Output.String(), "myapex.capex.unsigned")
7493
7494 signApkRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Description("sign compressedApex")
7495 ensureEquals(t, signApkRule.Input.String(), compressRule.Output.String())
7496
7497 // Make sure output of bundle is .capex
7498 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
7499 ensureContains(t, ab.outputFile.String(), "myapex.capex")
7500
7501 // Verify android.mk rules
Colin Crossaa255532020-07-03 13:18:24 -07007502 data := android.AndroidMkDataForTest(t, ctx, ab)
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007503 var builder strings.Builder
7504 data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
7505 androidMk := builder.String()
7506 ensureContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.capex\n")
7507}
7508
Martin Stjernholm2856c662020-12-02 15:03:42 +00007509func TestPreferredPrebuiltSharedLibDep(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007510 ctx := testApex(t, `
Martin Stjernholm2856c662020-12-02 15:03:42 +00007511 apex {
7512 name: "myapex",
7513 key: "myapex.key",
7514 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007515 updatable: false,
Martin Stjernholm2856c662020-12-02 15:03:42 +00007516 }
7517
7518 apex_key {
7519 name: "myapex.key",
7520 public_key: "testkey.avbpubkey",
7521 private_key: "testkey.pem",
7522 }
7523
7524 cc_library {
7525 name: "mylib",
7526 srcs: ["mylib.cpp"],
7527 apex_available: ["myapex"],
7528 shared_libs: ["otherlib"],
7529 system_shared_libs: [],
7530 }
7531
7532 cc_library {
7533 name: "otherlib",
7534 srcs: ["mylib.cpp"],
7535 stubs: {
7536 versions: ["current"],
7537 },
7538 }
7539
7540 cc_prebuilt_library_shared {
7541 name: "otherlib",
7542 prefer: true,
7543 srcs: ["prebuilt.so"],
7544 stubs: {
7545 versions: ["current"],
7546 },
7547 }
7548 `)
7549
7550 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07007551 data := android.AndroidMkDataForTest(t, ctx, ab)
Martin Stjernholm2856c662020-12-02 15:03:42 +00007552 var builder strings.Builder
7553 data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
7554 androidMk := builder.String()
7555
7556 // The make level dependency needs to be on otherlib - prebuilt_otherlib isn't
7557 // a thing there.
7558 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += otherlib\n")
7559}
7560
Jiyong Parke3867542020-12-03 17:28:25 +09007561func TestExcludeDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007562 ctx := testApex(t, `
Jiyong Parke3867542020-12-03 17:28:25 +09007563 apex {
7564 name: "myapex",
7565 key: "myapex.key",
7566 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007567 updatable: false,
Jiyong Parke3867542020-12-03 17:28:25 +09007568 }
7569
7570 apex_key {
7571 name: "myapex.key",
7572 public_key: "testkey.avbpubkey",
7573 private_key: "testkey.pem",
7574 }
7575
7576 cc_library {
7577 name: "mylib",
7578 srcs: ["mylib.cpp"],
7579 system_shared_libs: [],
7580 stl: "none",
7581 apex_available: ["myapex"],
7582 shared_libs: ["mylib2"],
7583 target: {
7584 apex: {
7585 exclude_shared_libs: ["mylib2"],
7586 },
7587 },
7588 }
7589
7590 cc_library {
7591 name: "mylib2",
7592 srcs: ["mylib.cpp"],
7593 system_shared_libs: [],
7594 stl: "none",
7595 }
7596 `)
7597
7598 // Check if mylib is linked to mylib2 for the non-apex target
7599 ldFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
7600 ensureContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
7601
7602 // Make sure that the link doesn't occur for the apex target
7603 ldFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
7604 ensureNotContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared_apex10000/mylib2.so")
7605
7606 // It shouldn't appear in the copy cmd as well.
7607 copyCmds := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule").Args["copy_commands"]
7608 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
7609}
7610
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007611func TestPrebuiltStubLibDep(t *testing.T) {
7612 bpBase := `
7613 apex {
7614 name: "myapex",
7615 key: "myapex.key",
7616 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007617 updatable: false,
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007618 }
7619 apex_key {
7620 name: "myapex.key",
7621 public_key: "testkey.avbpubkey",
7622 private_key: "testkey.pem",
7623 }
7624 cc_library {
7625 name: "mylib",
7626 srcs: ["mylib.cpp"],
7627 apex_available: ["myapex"],
7628 shared_libs: ["stublib"],
7629 system_shared_libs: [],
7630 }
7631 apex {
7632 name: "otherapex",
7633 enabled: %s,
7634 key: "myapex.key",
7635 native_shared_libs: ["stublib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007636 updatable: false,
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007637 }
7638 `
7639
7640 stublibSourceBp := `
7641 cc_library {
7642 name: "stublib",
7643 srcs: ["mylib.cpp"],
7644 apex_available: ["otherapex"],
7645 system_shared_libs: [],
7646 stl: "none",
7647 stubs: {
7648 versions: ["1"],
7649 },
7650 }
7651 `
7652
7653 stublibPrebuiltBp := `
7654 cc_prebuilt_library_shared {
7655 name: "stublib",
7656 srcs: ["prebuilt.so"],
7657 apex_available: ["otherapex"],
7658 stubs: {
7659 versions: ["1"],
7660 },
7661 %s
7662 }
7663 `
7664
7665 tests := []struct {
7666 name string
7667 stublibBp string
7668 usePrebuilt bool
7669 modNames []string // Modules to collect AndroidMkEntries for
7670 otherApexEnabled []string
7671 }{
7672 {
7673 name: "only_source",
7674 stublibBp: stublibSourceBp,
7675 usePrebuilt: false,
7676 modNames: []string{"stublib"},
7677 otherApexEnabled: []string{"true", "false"},
7678 },
7679 {
7680 name: "source_preferred",
7681 stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, ""),
7682 usePrebuilt: false,
7683 modNames: []string{"stublib", "prebuilt_stublib"},
7684 otherApexEnabled: []string{"true", "false"},
7685 },
7686 {
7687 name: "prebuilt_preferred",
7688 stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, "prefer: true,"),
7689 usePrebuilt: true,
7690 modNames: []string{"stublib", "prebuilt_stublib"},
7691 otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
7692 },
7693 {
7694 name: "only_prebuilt",
7695 stublibBp: fmt.Sprintf(stublibPrebuiltBp, ""),
7696 usePrebuilt: true,
7697 modNames: []string{"stublib"},
7698 otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
7699 },
7700 }
7701
7702 for _, test := range tests {
7703 t.Run(test.name, func(t *testing.T) {
7704 for _, otherApexEnabled := range test.otherApexEnabled {
7705 t.Run("otherapex_enabled_"+otherApexEnabled, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007706 ctx := testApex(t, fmt.Sprintf(bpBase, otherApexEnabled)+test.stublibBp)
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007707
7708 type modAndMkEntries struct {
7709 mod *cc.Module
7710 mkEntries android.AndroidMkEntries
7711 }
7712 entries := []*modAndMkEntries{}
7713
7714 // Gather shared lib modules that are installable
7715 for _, modName := range test.modNames {
7716 for _, variant := range ctx.ModuleVariantsForTests(modName) {
7717 if !strings.HasPrefix(variant, "android_arm64_armv8-a_shared") {
7718 continue
7719 }
7720 mod := ctx.ModuleForTests(modName, variant).Module().(*cc.Module)
Colin Crossa9c8c9f2020-12-16 10:20:23 -08007721 if !mod.Enabled() || mod.IsHideFromMake() {
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007722 continue
7723 }
Colin Crossaa255532020-07-03 13:18:24 -07007724 for _, ent := range android.AndroidMkEntriesForTest(t, ctx, mod) {
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007725 if ent.Disabled {
7726 continue
7727 }
7728 entries = append(entries, &modAndMkEntries{
7729 mod: mod,
7730 mkEntries: ent,
7731 })
7732 }
7733 }
7734 }
7735
7736 var entry *modAndMkEntries = nil
7737 for _, ent := range entries {
7738 if strings.Join(ent.mkEntries.EntryMap["LOCAL_MODULE"], ",") == "stublib" {
7739 if entry != nil {
7740 t.Errorf("More than one AndroidMk entry for \"stublib\": %s and %s", entry.mod, ent.mod)
7741 } else {
7742 entry = ent
7743 }
7744 }
7745 }
7746
7747 if entry == nil {
7748 t.Errorf("AndroidMk entry for \"stublib\" missing")
7749 } else {
7750 isPrebuilt := entry.mod.Prebuilt() != nil
7751 if isPrebuilt != test.usePrebuilt {
7752 t.Errorf("Wrong module for \"stublib\" AndroidMk entry: got prebuilt %t, want prebuilt %t", isPrebuilt, test.usePrebuilt)
7753 }
7754 if !entry.mod.IsStubs() {
7755 t.Errorf("Module for \"stublib\" AndroidMk entry isn't a stub: %s", entry.mod)
7756 }
7757 if entry.mkEntries.EntryMap["LOCAL_NOT_AVAILABLE_FOR_PLATFORM"] != nil {
7758 t.Errorf("AndroidMk entry for \"stublib\" has LOCAL_NOT_AVAILABLE_FOR_PLATFORM set: %+v", entry.mkEntries)
7759 }
Jiyong Park892a98f2020-12-14 09:20:00 +09007760 cflags := entry.mkEntries.EntryMap["LOCAL_EXPORT_CFLAGS"]
Jiyong Parkd4a3a132021-03-17 20:21:35 +09007761 expected := "-D__STUBLIB_API__=10000"
Jiyong Park892a98f2020-12-14 09:20:00 +09007762 if !android.InList(expected, cflags) {
7763 t.Errorf("LOCAL_EXPORT_CFLAGS expected to have %q, but got %q", expected, cflags)
7764 }
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007765 }
7766 })
7767 }
7768 })
7769 }
7770}
7771
Martin Stjernholmdf298b32021-05-21 20:57:29 +01007772func TestHostApexInHostOnlyBuild(t *testing.T) {
7773 testApex(t, `
7774 apex {
7775 name: "myapex",
7776 host_supported: true,
7777 key: "myapex.key",
7778 updatable: false,
7779 payload_type: "zip",
7780 }
7781 apex_key {
7782 name: "myapex.key",
7783 public_key: "testkey.avbpubkey",
7784 private_key: "testkey.pem",
7785 }
7786 `,
7787 android.FixtureModifyConfig(func(config android.Config) {
7788 // We may not have device targets in all builds, e.g. in
7789 // prebuilts/build-tools/build-prebuilts.sh
7790 config.Targets[android.Android] = []android.Target{}
7791 }))
7792}
7793
Colin Crossc33e5212021-05-25 18:16:02 -07007794func TestApexJavaCoverage(t *testing.T) {
7795 bp := `
7796 apex {
7797 name: "myapex",
7798 key: "myapex.key",
7799 java_libs: ["mylib"],
7800 bootclasspath_fragments: ["mybootclasspathfragment"],
7801 systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
7802 updatable: false,
7803 }
7804
7805 apex_key {
7806 name: "myapex.key",
7807 public_key: "testkey.avbpubkey",
7808 private_key: "testkey.pem",
7809 }
7810
7811 java_library {
7812 name: "mylib",
7813 srcs: ["mylib.java"],
7814 apex_available: ["myapex"],
7815 compile_dex: true,
7816 }
7817
7818 bootclasspath_fragment {
7819 name: "mybootclasspathfragment",
7820 contents: ["mybootclasspathlib"],
7821 apex_available: ["myapex"],
7822 }
7823
7824 java_library {
7825 name: "mybootclasspathlib",
7826 srcs: ["mybootclasspathlib.java"],
7827 apex_available: ["myapex"],
7828 compile_dex: true,
7829 }
7830
7831 systemserverclasspath_fragment {
7832 name: "mysystemserverclasspathfragment",
7833 contents: ["mysystemserverclasspathlib"],
7834 apex_available: ["myapex"],
7835 }
7836
7837 java_library {
7838 name: "mysystemserverclasspathlib",
7839 srcs: ["mysystemserverclasspathlib.java"],
7840 apex_available: ["myapex"],
7841 compile_dex: true,
7842 }
7843 `
7844
7845 result := android.GroupFixturePreparers(
7846 PrepareForTestWithApexBuildComponents,
7847 prepareForTestWithMyapex,
7848 java.PrepareForTestWithJavaDefaultModules,
7849 android.PrepareForTestWithAndroidBuildComponents,
7850 android.FixtureWithRootAndroidBp(bp),
7851 android.FixtureMergeEnv(map[string]string{
7852 "EMMA_INSTRUMENT": "true",
7853 }),
7854 ).RunTest(t)
7855
7856 // Make sure jacoco ran on both mylib and mybootclasspathlib
7857 if result.ModuleForTests("mylib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
7858 t.Errorf("Failed to find jacoco rule for mylib")
7859 }
7860 if result.ModuleForTests("mybootclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
7861 t.Errorf("Failed to find jacoco rule for mybootclasspathlib")
7862 }
7863 if result.ModuleForTests("mysystemserverclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
7864 t.Errorf("Failed to find jacoco rule for mysystemserverclasspathlib")
7865 }
7866}
7867
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07007868func TestMain(m *testing.M) {
Paul Duffin37ba3442021-03-29 00:21:08 +01007869 os.Exit(m.Run())
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07007870}