blob: 7107ea387fdb87b330fe8e88d91770d94a836baa [file] [log] [blame]
Jiyong Park25fc6a92018-11-18 18:02:45 +09001// Copyright 2018 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package apex
16
17import (
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +090018 "fmt"
Jiyong Park25fc6a92018-11-18 18:02:45 +090019 "os"
Jooyung Han39edb6c2019-11-06 16:53:07 +090020 "path"
Paul Duffin37856732021-02-26 14:24:15 +000021 "path/filepath"
Jaewoong Jung22f7d182019-07-16 18:25:41 -070022 "reflect"
Paul Duffin9b879592020-05-26 13:21:35 +010023 "regexp"
Jooyung Han31c470b2019-10-18 16:26:59 +090024 "sort"
Jiyong Parkd4a3a132021-03-17 20:21:35 +090025 "strconv"
Jiyong Park25fc6a92018-11-18 18:02:45 +090026 "strings"
27 "testing"
Jiyong Parkda6eb592018-12-19 17:12:36 +090028
29 "github.com/google/blueprint/proptools"
30
31 "android/soong/android"
markchien2f59ec92020-09-02 16:23:38 +080032 "android/soong/bpf"
Jiyong Parkda6eb592018-12-19 17:12:36 +090033 "android/soong/cc"
Ulya Trafimovichb28cc372020-01-13 15:18:16 +000034 "android/soong/dexpreopt"
Jaewoong Jung4b79e982020-06-01 10:45:49 -070035 prebuilt_etc "android/soong/etc"
Jiyong Parkb2742fd2019-02-11 11:38:15 +090036 "android/soong/java"
Jiyong Park99644e92020-11-17 22:21:02 +090037 "android/soong/rust"
Jaewoong Jung4b79e982020-06-01 10:45:49 -070038 "android/soong/sh"
Jiyong Park25fc6a92018-11-18 18:02:45 +090039)
40
Jooyung Hand3639552019-08-09 12:57:43 +090041// names returns name list from white space separated string
42func names(s string) (ns []string) {
43 for _, n := range strings.Split(s, " ") {
44 if len(n) > 0 {
45 ns = append(ns, n)
46 }
47 }
48 return
49}
50
Paul Duffin40b62572021-03-20 11:39:01 +000051func testApexError(t *testing.T, pattern, bp string, preparers ...android.FixturePreparer) {
Jooyung Han344d5432019-08-23 11:17:39 +090052 t.Helper()
Paul Duffin284165a2021-03-29 01:50:31 +010053 android.GroupFixturePreparers(
54 prepareForApexTest,
55 android.GroupFixturePreparers(preparers...),
56 ).
Paul Duffine05480a2021-03-08 15:07:14 +000057 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)).
Paul Duffin40b62572021-03-20 11:39:01 +000058 RunTestWithBp(t, bp)
Jooyung Han5c998b92019-06-27 11:30:33 +090059}
60
Paul Duffin40b62572021-03-20 11:39:01 +000061func testApex(t *testing.T, bp string, preparers ...android.FixturePreparer) *android.TestContext {
Jooyung Han344d5432019-08-23 11:17:39 +090062 t.Helper()
Paul Duffin284165a2021-03-29 01:50:31 +010063
64 optionalBpPreparer := android.NullFixturePreparer
Paul Duffin40b62572021-03-20 11:39:01 +000065 if bp != "" {
Paul Duffin284165a2021-03-29 01:50:31 +010066 optionalBpPreparer = android.FixtureWithRootAndroidBp(bp)
Paul Duffin40b62572021-03-20 11:39:01 +000067 }
Paul Duffin284165a2021-03-29 01:50:31 +010068
69 result := android.GroupFixturePreparers(
70 prepareForApexTest,
71 android.GroupFixturePreparers(preparers...),
72 optionalBpPreparer,
73 ).RunTest(t)
74
Paul Duffine05480a2021-03-08 15:07:14 +000075 return result.TestContext
Jooyung Han5c998b92019-06-27 11:30:33 +090076}
77
Paul Duffin810f33d2021-03-09 14:12:32 +000078func withFiles(files android.MockFS) android.FixturePreparer {
79 return files.AddToFixture()
Jooyung Han344d5432019-08-23 11:17:39 +090080}
81
Paul Duffin810f33d2021-03-09 14:12:32 +000082func withTargets(targets map[android.OsType][]android.Target) android.FixturePreparer {
83 return android.FixtureModifyConfig(func(config android.Config) {
Jooyung Han344d5432019-08-23 11:17:39 +090084 for k, v := range targets {
85 config.Targets[k] = v
86 }
Paul Duffin810f33d2021-03-09 14:12:32 +000087 })
Jooyung Han344d5432019-08-23 11:17:39 +090088}
89
Jooyung Han35155c42020-02-06 17:33:20 +090090// withNativeBridgeTargets sets configuration with targets including:
91// - X86_64 (primary)
92// - X86 (secondary)
93// - Arm64 on X86_64 (native bridge)
94// - Arm on X86 (native bridge)
Paul Duffin810f33d2021-03-09 14:12:32 +000095var withNativeBridgeEnabled = android.FixtureModifyConfig(
96 func(config android.Config) {
97 config.Targets[android.Android] = []android.Target{
98 {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "silvermont", Abi: []string{"arm64-v8a"}},
99 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
100 {Os: android.Android, Arch: android.Arch{ArchType: android.X86, ArchVariant: "silvermont", Abi: []string{"armeabi-v7a"}},
101 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
102 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}},
103 NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86_64", NativeBridgeRelativePath: "arm64"},
104 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
105 NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86", NativeBridgeRelativePath: "arm"},
106 }
107 },
108)
109
110func withManifestPackageNameOverrides(specs []string) android.FixturePreparer {
111 return android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
112 variables.ManifestPackageNameOverrides = specs
113 })
Jooyung Han35155c42020-02-06 17:33:20 +0900114}
115
Paul Duffin810f33d2021-03-09 14:12:32 +0000116var withBinder32bit = android.FixtureModifyProductVariables(
117 func(variables android.FixtureProductVariables) {
118 variables.Binder32bit = proptools.BoolPtr(true)
119 },
120)
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900121
Paul Duffin810f33d2021-03-09 14:12:32 +0000122var withUnbundledBuild = android.FixtureModifyProductVariables(
123 func(variables android.FixtureProductVariables) {
124 variables.Unbundled_build = proptools.BoolPtr(true)
125 },
126)
Jiyong Park7cd10e32020-01-14 09:22:18 +0900127
Paul Duffin284165a2021-03-29 01:50:31 +0100128// Legacy preparer used for running tests within the apex package.
129//
130// This includes everything that was needed to run any test in the apex package prior to the
131// introduction of the test fixtures. Tests that are being converted to use fixtures directly
132// rather than through the testApex...() methods should avoid using this and instead use the
133// various preparers directly, using android.GroupFixturePreparers(...) to group them when
134// necessary.
135//
136// deprecated
137var prepareForApexTest = android.GroupFixturePreparers(
Paul Duffin37aad602021-03-08 09:47:16 +0000138 // General preparers in alphabetical order as test infrastructure will enforce correct
139 // registration order.
140 android.PrepareForTestWithAndroidBuildComponents,
141 bpf.PrepareForTestWithBpf,
142 cc.PrepareForTestWithCcBuildComponents,
143 java.PrepareForTestWithJavaDefaultModules,
144 prebuilt_etc.PrepareForTestWithPrebuiltEtc,
145 rust.PrepareForTestWithRustDefaultModules,
146 sh.PrepareForTestWithShBuildComponents,
147
148 PrepareForTestWithApexBuildComponents,
149
150 // Additional apex test specific preparers.
151 android.FixtureAddTextFile("system/sepolicy/Android.bp", `
152 filegroup {
153 name: "myapex-file_contexts",
154 srcs: [
155 "apex/myapex-file_contexts",
156 ],
157 }
158 `),
Paul Duffin52bfaa42021-03-23 23:40:12 +0000159 prepareForTestWithMyapex,
Paul Duffin37aad602021-03-08 09:47:16 +0000160 android.FixtureMergeMockFs(android.MockFS{
Paul Duffin52bfaa42021-03-23 23:40:12 +0000161 "a.java": nil,
162 "PrebuiltAppFoo.apk": nil,
163 "PrebuiltAppFooPriv.apk": nil,
164 "apex_manifest.json": nil,
165 "AndroidManifest.xml": nil,
Paul Duffin37aad602021-03-08 09:47:16 +0000166 "system/sepolicy/apex/myapex.updatable-file_contexts": nil,
167 "system/sepolicy/apex/myapex2-file_contexts": nil,
168 "system/sepolicy/apex/otherapex-file_contexts": nil,
169 "system/sepolicy/apex/com.android.vndk-file_contexts": nil,
170 "system/sepolicy/apex/com.android.vndk.current-file_contexts": nil,
171 "mylib.cpp": nil,
172 "mytest.cpp": nil,
173 "mytest1.cpp": nil,
174 "mytest2.cpp": nil,
175 "mytest3.cpp": nil,
176 "myprebuilt": nil,
177 "my_include": nil,
178 "foo/bar/MyClass.java": nil,
179 "prebuilt.jar": nil,
180 "prebuilt.so": nil,
181 "vendor/foo/devkeys/test.x509.pem": nil,
182 "vendor/foo/devkeys/test.pk8": nil,
183 "testkey.x509.pem": nil,
184 "testkey.pk8": nil,
185 "testkey.override.x509.pem": nil,
186 "testkey.override.pk8": nil,
187 "vendor/foo/devkeys/testkey.avbpubkey": nil,
188 "vendor/foo/devkeys/testkey.pem": nil,
189 "NOTICE": nil,
190 "custom_notice": nil,
191 "custom_notice_for_static_lib": nil,
192 "testkey2.avbpubkey": nil,
193 "testkey2.pem": nil,
194 "myapex-arm64.apex": nil,
195 "myapex-arm.apex": nil,
196 "myapex.apks": nil,
197 "frameworks/base/api/current.txt": nil,
198 "framework/aidl/a.aidl": nil,
199 "build/make/core/proguard.flags": nil,
200 "build/make/core/proguard_basic_keeps.flags": nil,
201 "dummy.txt": nil,
202 "baz": nil,
203 "bar/baz": nil,
204 "testdata/baz": nil,
205 "AppSet.apks": nil,
206 "foo.rs": nil,
207 "libfoo.jar": nil,
208 "libbar.jar": nil,
209 },
210 ),
211
212 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
213 variables.DeviceVndkVersion = proptools.StringPtr("current")
214 variables.DefaultAppCertificate = proptools.StringPtr("vendor/foo/devkeys/test")
215 variables.CertificateOverrides = []string{"myapex_keytest:myapex.certificate.override"}
216 variables.Platform_sdk_codename = proptools.StringPtr("Q")
217 variables.Platform_sdk_final = proptools.BoolPtr(false)
218 variables.Platform_version_active_codenames = []string{"Q"}
Jiyong Parkf58c46e2021-04-01 21:35:20 +0900219 variables.Platform_vndk_version = proptools.StringPtr("29")
Paul Duffin37aad602021-03-08 09:47:16 +0000220 }),
221)
222
Paul Duffin52bfaa42021-03-23 23:40:12 +0000223var prepareForTestWithMyapex = android.FixtureMergeMockFs(android.MockFS{
224 "system/sepolicy/apex/myapex-file_contexts": nil,
225})
226
Jooyung Han643adc42020-02-27 13:50:06 +0900227// ensure that 'result' equals 'expected'
228func ensureEquals(t *testing.T, result string, expected string) {
229 t.Helper()
230 if result != expected {
231 t.Errorf("%q != %q", expected, result)
232 }
233}
234
Jiyong Park25fc6a92018-11-18 18:02:45 +0900235// ensure that 'result' contains 'expected'
236func ensureContains(t *testing.T, result string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900237 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900238 if !strings.Contains(result, expected) {
239 t.Errorf("%q is not found in %q", expected, result)
240 }
241}
242
Liz Kammer5bd365f2020-05-27 15:15:11 -0700243// ensure that 'result' contains 'expected' exactly one time
244func ensureContainsOnce(t *testing.T, result string, expected string) {
245 t.Helper()
246 count := strings.Count(result, expected)
247 if count != 1 {
248 t.Errorf("%q is found %d times (expected 1 time) in %q", expected, count, result)
249 }
250}
251
Jiyong Park25fc6a92018-11-18 18:02:45 +0900252// ensures that 'result' does not contain 'notExpected'
253func ensureNotContains(t *testing.T, result string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900254 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900255 if strings.Contains(result, notExpected) {
256 t.Errorf("%q is found in %q", notExpected, result)
257 }
258}
259
Sasha Smundak18d98bc2020-05-27 16:36:07 -0700260func ensureMatches(t *testing.T, result string, expectedRex string) {
261 ok, err := regexp.MatchString(expectedRex, result)
262 if err != nil {
263 t.Fatalf("regexp failure trying to match %s against `%s` expression: %s", result, expectedRex, err)
264 return
265 }
266 if !ok {
267 t.Errorf("%s does not match regular expession %s", result, expectedRex)
268 }
269}
270
Jiyong Park25fc6a92018-11-18 18:02:45 +0900271func ensureListContains(t *testing.T, result []string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900272 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900273 if !android.InList(expected, result) {
274 t.Errorf("%q is not found in %v", expected, result)
275 }
276}
277
278func ensureListNotContains(t *testing.T, result []string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900279 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900280 if android.InList(notExpected, result) {
281 t.Errorf("%q is found in %v", notExpected, result)
282 }
283}
284
Jooyung Hane1633032019-08-01 17:41:43 +0900285func ensureListEmpty(t *testing.T, result []string) {
286 t.Helper()
287 if len(result) > 0 {
288 t.Errorf("%q is expected to be empty", result)
289 }
290}
291
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +0000292func ensureListNotEmpty(t *testing.T, result []string) {
293 t.Helper()
294 if len(result) == 0 {
295 t.Errorf("%q is expected to be not empty", result)
296 }
297}
298
Jiyong Park25fc6a92018-11-18 18:02:45 +0900299// Minimal test
300func TestBasicApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800301 ctx := testApex(t, `
Jiyong Park30ca9372019-02-07 16:27:23 +0900302 apex_defaults {
303 name: "myapex-defaults",
Jiyong Park809bb722019-02-13 21:33:49 +0900304 manifest: ":myapex.manifest",
305 androidManifest: ":myapex.androidmanifest",
Jiyong Park25fc6a92018-11-18 18:02:45 +0900306 key: "myapex.key",
Jiyong Park99644e92020-11-17 22:21:02 +0900307 binaries: ["foo.rust"],
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900308 native_shared_libs: [
309 "mylib",
310 "libfoo.ffi",
311 ],
Jiyong Park99644e92020-11-17 22:21:02 +0900312 rust_dyn_libs: ["libfoo.dylib.rust"],
Alex Light3d673592019-01-18 14:37:31 -0800313 multilib: {
314 both: {
Jiyong Park99644e92020-11-17 22:21:02 +0900315 binaries: ["foo"],
Alex Light3d673592019-01-18 14:37:31 -0800316 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900317 },
Jiyong Park77acec62020-06-01 21:39:15 +0900318 java_libs: [
319 "myjar",
320 "myjar_dex",
321 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000322 updatable: false,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900323 }
324
Jiyong Park30ca9372019-02-07 16:27:23 +0900325 apex {
326 name: "myapex",
327 defaults: ["myapex-defaults"],
328 }
329
Jiyong Park25fc6a92018-11-18 18:02:45 +0900330 apex_key {
331 name: "myapex.key",
332 public_key: "testkey.avbpubkey",
333 private_key: "testkey.pem",
334 }
335
Jiyong Park809bb722019-02-13 21:33:49 +0900336 filegroup {
337 name: "myapex.manifest",
338 srcs: ["apex_manifest.json"],
339 }
340
341 filegroup {
342 name: "myapex.androidmanifest",
343 srcs: ["AndroidManifest.xml"],
344 }
345
Jiyong Park25fc6a92018-11-18 18:02:45 +0900346 cc_library {
347 name: "mylib",
348 srcs: ["mylib.cpp"],
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900349 shared_libs: [
350 "mylib2",
351 "libbar.ffi",
352 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900353 system_shared_libs: [],
354 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000355 // TODO: remove //apex_available:platform
356 apex_available: [
357 "//apex_available:platform",
358 "myapex",
359 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900360 }
361
Alex Light3d673592019-01-18 14:37:31 -0800362 cc_binary {
363 name: "foo",
364 srcs: ["mylib.cpp"],
365 compile_multilib: "both",
366 multilib: {
367 lib32: {
368 suffix: "32",
369 },
370 lib64: {
371 suffix: "64",
372 },
373 },
374 symlinks: ["foo_link_"],
375 symlink_preferred_arch: true,
376 system_shared_libs: [],
377 static_executable: true,
378 stl: "none",
Yifan Hongd22a84a2020-07-28 17:37:46 -0700379 apex_available: [ "myapex", "com.android.gki.*" ],
380 }
381
Jiyong Park99644e92020-11-17 22:21:02 +0900382 rust_binary {
Artur Satayev533b98c2021-03-11 18:03:42 +0000383 name: "foo.rust",
Jiyong Park99644e92020-11-17 22:21:02 +0900384 srcs: ["foo.rs"],
385 rlibs: ["libfoo.rlib.rust"],
386 dylibs: ["libfoo.dylib.rust"],
387 apex_available: ["myapex"],
388 }
389
390 rust_library_rlib {
Artur Satayev533b98c2021-03-11 18:03:42 +0000391 name: "libfoo.rlib.rust",
Jiyong Park99644e92020-11-17 22:21:02 +0900392 srcs: ["foo.rs"],
393 crate_name: "foo",
394 apex_available: ["myapex"],
Jiyong Park94e22fd2021-04-08 18:19:15 +0900395 shared_libs: ["libfoo.shared_from_rust"],
396 }
397
398 cc_library_shared {
399 name: "libfoo.shared_from_rust",
400 srcs: ["mylib.cpp"],
401 system_shared_libs: [],
402 stl: "none",
403 apex_available: ["myapex"],
Jiyong Park99644e92020-11-17 22:21:02 +0900404 }
405
406 rust_library_dylib {
Artur Satayev533b98c2021-03-11 18:03:42 +0000407 name: "libfoo.dylib.rust",
Jiyong Park99644e92020-11-17 22:21:02 +0900408 srcs: ["foo.rs"],
409 crate_name: "foo",
410 apex_available: ["myapex"],
411 }
412
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900413 rust_ffi_shared {
414 name: "libfoo.ffi",
415 srcs: ["foo.rs"],
416 crate_name: "foo",
417 apex_available: ["myapex"],
418 }
419
420 rust_ffi_shared {
421 name: "libbar.ffi",
422 srcs: ["foo.rs"],
423 crate_name: "bar",
424 apex_available: ["myapex"],
425 }
426
Yifan Hongd22a84a2020-07-28 17:37:46 -0700427 apex {
428 name: "com.android.gki.fake",
429 binaries: ["foo"],
430 key: "myapex.key",
431 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000432 updatable: false,
Alex Light3d673592019-01-18 14:37:31 -0800433 }
434
Paul Duffindddd5462020-04-07 15:25:44 +0100435 cc_library_shared {
Jiyong Park25fc6a92018-11-18 18:02:45 +0900436 name: "mylib2",
437 srcs: ["mylib.cpp"],
438 system_shared_libs: [],
439 stl: "none",
Jiyong Park52818fc2019-03-18 12:01:38 +0900440 notice: "custom_notice",
Jiyong Park9918e1a2020-03-17 19:16:40 +0900441 static_libs: ["libstatic"],
442 // TODO: remove //apex_available:platform
443 apex_available: [
444 "//apex_available:platform",
445 "myapex",
446 ],
447 }
448
Paul Duffindddd5462020-04-07 15:25:44 +0100449 cc_prebuilt_library_shared {
450 name: "mylib2",
451 srcs: ["prebuilt.so"],
452 // TODO: remove //apex_available:platform
453 apex_available: [
454 "//apex_available:platform",
455 "myapex",
456 ],
457 }
458
Jiyong Park9918e1a2020-03-17 19:16:40 +0900459 cc_library_static {
460 name: "libstatic",
461 srcs: ["mylib.cpp"],
462 system_shared_libs: [],
463 stl: "none",
464 notice: "custom_notice_for_static_lib",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000465 // TODO: remove //apex_available:platform
466 apex_available: [
467 "//apex_available:platform",
468 "myapex",
469 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900470 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900471
472 java_library {
473 name: "myjar",
474 srcs: ["foo/bar/MyClass.java"],
Jiyong Parka62aa232020-05-28 23:46:55 +0900475 stem: "myjar_stem",
Jiyong Park7f7766d2019-07-25 22:02:35 +0900476 sdk_version: "none",
477 system_modules: "none",
Jiyong Park7f7766d2019-07-25 22:02:35 +0900478 static_libs: ["myotherjar"],
Jiyong Park3ff16992019-12-27 14:11:47 +0900479 libs: ["mysharedjar"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000480 // TODO: remove //apex_available:platform
481 apex_available: [
482 "//apex_available:platform",
483 "myapex",
484 ],
Jiyong Park7f7766d2019-07-25 22:02:35 +0900485 }
486
Jiyong Park77acec62020-06-01 21:39:15 +0900487 dex_import {
488 name: "myjar_dex",
489 jars: ["prebuilt.jar"],
490 apex_available: [
491 "//apex_available:platform",
492 "myapex",
493 ],
494 }
495
Jiyong Park7f7766d2019-07-25 22:02:35 +0900496 java_library {
497 name: "myotherjar",
498 srcs: ["foo/bar/MyClass.java"],
499 sdk_version: "none",
500 system_modules: "none",
Jiyong Park0f80c182020-01-31 02:49:53 +0900501 // TODO: remove //apex_available:platform
502 apex_available: [
503 "//apex_available:platform",
504 "myapex",
505 ],
Jiyong Park7f7766d2019-07-25 22:02:35 +0900506 }
Jiyong Park3ff16992019-12-27 14:11:47 +0900507
508 java_library {
509 name: "mysharedjar",
510 srcs: ["foo/bar/MyClass.java"],
511 sdk_version: "none",
512 system_modules: "none",
Jiyong Park3ff16992019-12-27 14:11:47 +0900513 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900514 `)
515
Paul Duffina71a67a2021-03-29 00:42:57 +0100516 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900517
Jiyong Park9e83f0b2020-06-11 00:35:03 +0900518 // Make sure that Android.mk is created
519 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -0700520 data := android.AndroidMkDataForTest(t, ctx, ab)
Jiyong Park9e83f0b2020-06-11 00:35:03 +0900521 var builder strings.Builder
522 data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
523
524 androidMk := builder.String()
525 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
526 ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
527
Jiyong Park42cca6c2019-04-01 11:15:50 +0900528 optFlags := apexRule.Args["opt_flags"]
529 ensureContains(t, optFlags, "--pubkey vendor/foo/devkeys/testkey.avbpubkey")
Jaewoong Jung14f5ff62019-06-18 13:09:13 -0700530 // Ensure that the NOTICE output is being packaged as an asset.
Paul Duffin37ba3442021-03-29 00:21:08 +0100531 ensureContains(t, optFlags, "--assets_dir out/soong/.intermediates/myapex/android_common_myapex_image/NOTICE")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900532
Jiyong Park25fc6a92018-11-18 18:02:45 +0900533 copyCmds := apexRule.Args["copy_commands"]
534
535 // Ensure that main rule creates an output
536 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
537
538 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -0700539 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
540 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common_apex10000")
541 ensureListContains(t, ctx.ModuleVariantsForTests("myjar_dex"), "android_common_apex10000")
Jiyong Park99644e92020-11-17 22:21:02 +0900542 ensureListContains(t, ctx.ModuleVariantsForTests("foo.rust"), "android_arm64_armv8-a_apex10000")
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900543 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.ffi"), "android_arm64_armv8-a_shared_apex10000")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900544
545 // Ensure that apex variant is created for the indirect dep
Colin Crossaede88c2020-08-11 12:17:01 -0700546 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
547 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common_apex10000")
Jiyong Park99644e92020-11-17 22:21:02 +0900548 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.rlib.rust"), "android_arm64_armv8-a_rlib_dylib-std_apex10000")
549 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.dylib.rust"), "android_arm64_armv8-a_dylib_apex10000")
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900550 ensureListContains(t, ctx.ModuleVariantsForTests("libbar.ffi"), "android_arm64_armv8-a_shared_apex10000")
Jiyong Park94e22fd2021-04-08 18:19:15 +0900551 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.shared_from_rust"), "android_arm64_armv8-a_shared_apex10000")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900552
553 // Ensure that both direct and indirect deps are copied into apex
Alex Light5098a612018-11-29 17:12:15 -0800554 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
555 ensureContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Parka62aa232020-05-28 23:46:55 +0900556 ensureContains(t, copyCmds, "image.apex/javalib/myjar_stem.jar")
Jiyong Park77acec62020-06-01 21:39:15 +0900557 ensureContains(t, copyCmds, "image.apex/javalib/myjar_dex.jar")
Jiyong Park99644e92020-11-17 22:21:02 +0900558 ensureContains(t, copyCmds, "image.apex/lib64/libfoo.dylib.rust.dylib.so")
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900559 ensureContains(t, copyCmds, "image.apex/lib64/libfoo.ffi.so")
560 ensureContains(t, copyCmds, "image.apex/lib64/libbar.ffi.so")
Jiyong Park94e22fd2021-04-08 18:19:15 +0900561 ensureContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900562 // .. but not for java libs
563 ensureNotContains(t, copyCmds, "image.apex/javalib/myotherjar.jar")
Jiyong Park3ff16992019-12-27 14:11:47 +0900564 ensureNotContains(t, copyCmds, "image.apex/javalib/msharedjar.jar")
Logan Chien3aeedc92018-12-26 15:32:21 +0800565
Colin Cross7113d202019-11-20 16:39:12 -0800566 // Ensure that the platform variant ends with _shared or _common
567 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
568 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900569 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common")
570 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common")
Jiyong Park3ff16992019-12-27 14:11:47 +0900571 ensureListContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common")
572
573 // Ensure that dynamic dependency to java libs are not included
574 ensureListNotContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common_myapex")
Alex Light3d673592019-01-18 14:37:31 -0800575
576 // Ensure that all symlinks are present.
577 found_foo_link_64 := false
578 found_foo := false
579 for _, cmd := range strings.Split(copyCmds, " && ") {
Jiyong Park7cd10e32020-01-14 09:22:18 +0900580 if strings.HasPrefix(cmd, "ln -sfn foo64") {
Alex Light3d673592019-01-18 14:37:31 -0800581 if strings.HasSuffix(cmd, "bin/foo") {
582 found_foo = true
583 } else if strings.HasSuffix(cmd, "bin/foo_link_64") {
584 found_foo_link_64 = true
585 }
586 }
587 }
588 good := found_foo && found_foo_link_64
589 if !good {
590 t.Errorf("Could not find all expected symlinks! foo: %t, foo_link_64: %t. Command was %s", found_foo, found_foo_link_64, copyCmds)
591 }
Jiyong Park52818fc2019-03-18 12:01:38 +0900592
Sundong Ahnabb64432019-10-22 13:58:29 +0900593 mergeNoticesRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("mergeNoticesRule")
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700594 noticeInputs := mergeNoticesRule.Inputs.Strings()
Jiyong Park9918e1a2020-03-17 19:16:40 +0900595 if len(noticeInputs) != 3 {
596 t.Errorf("number of input notice files: expected = 3, actual = %q", len(noticeInputs))
Jiyong Park52818fc2019-03-18 12:01:38 +0900597 }
598 ensureListContains(t, noticeInputs, "NOTICE")
599 ensureListContains(t, noticeInputs, "custom_notice")
Jiyong Park9918e1a2020-03-17 19:16:40 +0900600 ensureListContains(t, noticeInputs, "custom_notice_for_static_lib")
Jiyong Park83dc74b2020-01-14 18:38:44 +0900601
Artur Satayeva8bd1132020-04-27 18:07:06 +0100602 fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100603 ensureListContains(t, fullDepsInfo, " myjar(minSdkVersion:(no version)) <- myapex")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100604 ensureListContains(t, fullDepsInfo, " mylib2(minSdkVersion:(no version)) <- mylib")
605 ensureListContains(t, fullDepsInfo, " myotherjar(minSdkVersion:(no version)) <- myjar")
606 ensureListContains(t, fullDepsInfo, " mysharedjar(minSdkVersion:(no version)) (external) <- myjar")
Artur Satayeva8bd1132020-04-27 18:07:06 +0100607
608 flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100609 ensureListContains(t, flatDepsInfo, "myjar(minSdkVersion:(no version))")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100610 ensureListContains(t, flatDepsInfo, "mylib2(minSdkVersion:(no version))")
611 ensureListContains(t, flatDepsInfo, "myotherjar(minSdkVersion:(no version))")
612 ensureListContains(t, flatDepsInfo, "mysharedjar(minSdkVersion:(no version)) (external)")
Alex Light5098a612018-11-29 17:12:15 -0800613}
614
Jooyung Hanf21c7972019-12-16 22:32:06 +0900615func TestDefaults(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800616 ctx := testApex(t, `
Jooyung Hanf21c7972019-12-16 22:32:06 +0900617 apex_defaults {
618 name: "myapex-defaults",
619 key: "myapex.key",
620 prebuilts: ["myetc"],
621 native_shared_libs: ["mylib"],
622 java_libs: ["myjar"],
623 apps: ["AppFoo"],
Jiyong Park69aeba92020-04-24 21:16:36 +0900624 rros: ["rro"],
markchien2f59ec92020-09-02 16:23:38 +0800625 bpfs: ["bpf"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000626 updatable: false,
Jooyung Hanf21c7972019-12-16 22:32:06 +0900627 }
628
629 prebuilt_etc {
630 name: "myetc",
631 src: "myprebuilt",
632 }
633
634 apex {
635 name: "myapex",
636 defaults: ["myapex-defaults"],
637 }
638
639 apex_key {
640 name: "myapex.key",
641 public_key: "testkey.avbpubkey",
642 private_key: "testkey.pem",
643 }
644
645 cc_library {
646 name: "mylib",
647 system_shared_libs: [],
648 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000649 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900650 }
651
652 java_library {
653 name: "myjar",
654 srcs: ["foo/bar/MyClass.java"],
655 sdk_version: "none",
656 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000657 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900658 }
659
660 android_app {
661 name: "AppFoo",
662 srcs: ["foo/bar/MyClass.java"],
663 sdk_version: "none",
664 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000665 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900666 }
Jiyong Park69aeba92020-04-24 21:16:36 +0900667
668 runtime_resource_overlay {
669 name: "rro",
670 theme: "blue",
671 }
672
markchien2f59ec92020-09-02 16:23:38 +0800673 bpf {
674 name: "bpf",
675 srcs: ["bpf.c", "bpf2.c"],
676 }
677
Jooyung Hanf21c7972019-12-16 22:32:06 +0900678 `)
Jooyung Hana57af4a2020-01-23 05:36:59 +0000679 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Hanf21c7972019-12-16 22:32:06 +0900680 "etc/myetc",
681 "javalib/myjar.jar",
682 "lib64/mylib.so",
683 "app/AppFoo/AppFoo.apk",
Jiyong Park69aeba92020-04-24 21:16:36 +0900684 "overlay/blue/rro.apk",
markchien2f59ec92020-09-02 16:23:38 +0800685 "etc/bpf/bpf.o",
686 "etc/bpf/bpf2.o",
Jooyung Hanf21c7972019-12-16 22:32:06 +0900687 })
688}
689
Jooyung Han01a3ee22019-11-02 02:52:25 +0900690func TestApexManifest(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800691 ctx := testApex(t, `
Jooyung Han01a3ee22019-11-02 02:52:25 +0900692 apex {
693 name: "myapex",
694 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000695 updatable: false,
Jooyung Han01a3ee22019-11-02 02:52:25 +0900696 }
697
698 apex_key {
699 name: "myapex.key",
700 public_key: "testkey.avbpubkey",
701 private_key: "testkey.pem",
702 }
703 `)
704
705 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Han214bf372019-11-12 13:03:50 +0900706 args := module.Rule("apexRule").Args
707 if manifest := args["manifest"]; manifest != module.Output("apex_manifest.pb").Output.String() {
708 t.Error("manifest should be apex_manifest.pb, but " + manifest)
709 }
Jooyung Han01a3ee22019-11-02 02:52:25 +0900710}
711
Liz Kammer4854a7d2021-05-27 14:28:27 -0400712func TestApexManifestMinSdkVersion(t *testing.T) {
713 ctx := testApex(t, `
714 apex_defaults {
715 name: "my_defaults",
716 key: "myapex.key",
717 product_specific: true,
718 file_contexts: ":my-file-contexts",
719 updatable: false,
720 }
721 apex {
722 name: "myapex_30",
723 min_sdk_version: "30",
724 defaults: ["my_defaults"],
725 }
726
727 apex {
728 name: "myapex_current",
729 min_sdk_version: "current",
730 defaults: ["my_defaults"],
731 }
732
733 apex {
734 name: "myapex_none",
735 defaults: ["my_defaults"],
736 }
737
738 apex_key {
739 name: "myapex.key",
740 public_key: "testkey.avbpubkey",
741 private_key: "testkey.pem",
742 }
743
744 filegroup {
745 name: "my-file-contexts",
746 srcs: ["product_specific_file_contexts"],
747 }
748 `, withFiles(map[string][]byte{
749 "product_specific_file_contexts": nil,
750 }), android.FixtureModifyProductVariables(
751 func(variables android.FixtureProductVariables) {
752 variables.Unbundled_build = proptools.BoolPtr(true)
753 variables.Always_use_prebuilt_sdks = proptools.BoolPtr(false)
754 }), android.FixtureMergeEnv(map[string]string{
755 "UNBUNDLED_BUILD_TARGET_SDK_WITH_API_FINGERPRINT": "true",
756 }))
757
758 testCases := []struct {
759 module string
760 minSdkVersion string
761 }{
762 {
763 module: "myapex_30",
764 minSdkVersion: "30",
765 },
766 {
767 module: "myapex_current",
768 minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
769 },
770 {
771 module: "myapex_none",
772 minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
773 },
774 }
775 for _, tc := range testCases {
776 module := ctx.ModuleForTests(tc.module, "android_common_"+tc.module+"_image")
777 args := module.Rule("apexRule").Args
778 optFlags := args["opt_flags"]
779 if !strings.Contains(optFlags, "--min_sdk_version "+tc.minSdkVersion) {
780 t.Errorf("%s: Expected min_sdk_version=%s, got: %s", tc.module, tc.minSdkVersion, optFlags)
781 }
782 }
783}
784
Alex Light5098a612018-11-29 17:12:15 -0800785func TestBasicZipApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800786 ctx := testApex(t, `
Alex Light5098a612018-11-29 17:12:15 -0800787 apex {
788 name: "myapex",
789 key: "myapex.key",
790 payload_type: "zip",
791 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000792 updatable: false,
Alex Light5098a612018-11-29 17:12:15 -0800793 }
794
795 apex_key {
796 name: "myapex.key",
797 public_key: "testkey.avbpubkey",
798 private_key: "testkey.pem",
799 }
800
801 cc_library {
802 name: "mylib",
803 srcs: ["mylib.cpp"],
804 shared_libs: ["mylib2"],
805 system_shared_libs: [],
806 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000807 apex_available: [ "myapex" ],
Alex Light5098a612018-11-29 17:12:15 -0800808 }
809
810 cc_library {
811 name: "mylib2",
812 srcs: ["mylib.cpp"],
813 system_shared_libs: [],
814 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000815 apex_available: [ "myapex" ],
Alex Light5098a612018-11-29 17:12:15 -0800816 }
817 `)
818
Sundong Ahnabb64432019-10-22 13:58:29 +0900819 zipApexRule := ctx.ModuleForTests("myapex", "android_common_myapex_zip").Rule("zipApexRule")
Alex Light5098a612018-11-29 17:12:15 -0800820 copyCmds := zipApexRule.Args["copy_commands"]
821
822 // Ensure that main rule creates an output
823 ensureContains(t, zipApexRule.Output.String(), "myapex.zipapex.unsigned")
824
825 // Ensure that APEX variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -0700826 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
Alex Light5098a612018-11-29 17:12:15 -0800827
828 // Ensure that APEX variant is created for the indirect dep
Colin Crossaede88c2020-08-11 12:17:01 -0700829 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
Alex Light5098a612018-11-29 17:12:15 -0800830
831 // Ensure that both direct and indirect deps are copied into apex
832 ensureContains(t, copyCmds, "image.zipapex/lib64/mylib.so")
833 ensureContains(t, copyCmds, "image.zipapex/lib64/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900834}
835
836func TestApexWithStubs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800837 ctx := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +0900838 apex {
839 name: "myapex",
840 key: "myapex.key",
841 native_shared_libs: ["mylib", "mylib3"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000842 updatable: false,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900843 }
844
845 apex_key {
846 name: "myapex.key",
847 public_key: "testkey.avbpubkey",
848 private_key: "testkey.pem",
849 }
850
851 cc_library {
852 name: "mylib",
853 srcs: ["mylib.cpp"],
854 shared_libs: ["mylib2", "mylib3"],
855 system_shared_libs: [],
856 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000857 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900858 }
859
860 cc_library {
861 name: "mylib2",
862 srcs: ["mylib.cpp"],
Jiyong Park64379952018-12-13 18:37:29 +0900863 cflags: ["-include mylib.h"],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900864 system_shared_libs: [],
865 stl: "none",
866 stubs: {
867 versions: ["1", "2", "3"],
868 },
869 }
870
871 cc_library {
872 name: "mylib3",
Jiyong Park28d395a2018-12-07 22:42:47 +0900873 srcs: ["mylib.cpp"],
874 shared_libs: ["mylib4"],
875 system_shared_libs: [],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900876 stl: "none",
877 stubs: {
878 versions: ["10", "11", "12"],
879 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000880 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900881 }
Jiyong Park28d395a2018-12-07 22:42:47 +0900882
883 cc_library {
884 name: "mylib4",
885 srcs: ["mylib.cpp"],
886 system_shared_libs: [],
887 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000888 apex_available: [ "myapex" ],
Jiyong Park28d395a2018-12-07 22:42:47 +0900889 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900890 `)
891
Sundong Ahnabb64432019-10-22 13:58:29 +0900892 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900893 copyCmds := apexRule.Args["copy_commands"]
894
895 // Ensure that direct non-stubs dep is always included
Alex Light5098a612018-11-29 17:12:15 -0800896 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900897
898 // Ensure that indirect stubs dep is not included
Alex Light5098a612018-11-29 17:12:15 -0800899 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900900
901 // Ensure that direct stubs dep is included
Alex Light5098a612018-11-29 17:12:15 -0800902 ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900903
Colin Crossaede88c2020-08-11 12:17:01 -0700904 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +0900905
906 // Ensure that mylib is linking with the latest version of stubs for mylib2
Jiyong Parkd4a3a132021-03-17 20:21:35 +0900907 ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900908 // ... and not linking to the non-stub (impl) variant of mylib2
Jiyong Park3ff16992019-12-27 14:11:47 +0900909 ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900910
911 // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
Colin Crossaede88c2020-08-11 12:17:01 -0700912 ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex10000/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900913 // .. and not linking to the stubs variant of mylib3
Colin Crossaede88c2020-08-11 12:17:01 -0700914 ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_12/mylib3.so")
Jiyong Park64379952018-12-13 18:37:29 +0900915
916 // Ensure that stubs libs are built without -include flags
Jiyong Park0f80c182020-01-31 02:49:53 +0900917 mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jiyong Park64379952018-12-13 18:37:29 +0900918 ensureNotContains(t, mylib2Cflags, "-include ")
Jiyong Park3fd0baf2018-12-07 16:25:39 +0900919
920 // Ensure that genstub is invoked with --apex
Colin Crossa717db72020-10-23 14:53:06 -0700921 ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_3").Rule("genStubSrc").Args["flags"])
Jooyung Han671f1ce2019-12-17 12:47:13 +0900922
Jooyung Hana57af4a2020-01-23 05:36:59 +0000923 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Han671f1ce2019-12-17 12:47:13 +0900924 "lib64/mylib.so",
925 "lib64/mylib3.so",
926 "lib64/mylib4.so",
927 })
Jiyong Park25fc6a92018-11-18 18:02:45 +0900928}
929
Colin Cross7812fd32020-09-25 12:35:10 -0700930func TestApexWithStubsWithMinSdkVersion(t *testing.T) {
931 t.Parallel()
Colin Cross1c460562021-02-16 17:55:47 -0800932 ctx := testApex(t, `
Colin Cross7812fd32020-09-25 12:35:10 -0700933 apex {
934 name: "myapex",
935 key: "myapex.key",
936 native_shared_libs: ["mylib", "mylib3"],
937 min_sdk_version: "29",
938 }
939
940 apex_key {
941 name: "myapex.key",
942 public_key: "testkey.avbpubkey",
943 private_key: "testkey.pem",
944 }
945
946 cc_library {
947 name: "mylib",
948 srcs: ["mylib.cpp"],
949 shared_libs: ["mylib2", "mylib3"],
950 system_shared_libs: [],
951 stl: "none",
952 apex_available: [ "myapex" ],
953 min_sdk_version: "28",
954 }
955
956 cc_library {
957 name: "mylib2",
958 srcs: ["mylib.cpp"],
959 cflags: ["-include mylib.h"],
960 system_shared_libs: [],
961 stl: "none",
962 stubs: {
963 versions: ["28", "29", "30", "current"],
964 },
965 min_sdk_version: "28",
966 }
967
968 cc_library {
969 name: "mylib3",
970 srcs: ["mylib.cpp"],
971 shared_libs: ["mylib4"],
972 system_shared_libs: [],
973 stl: "none",
974 stubs: {
975 versions: ["28", "29", "30", "current"],
976 },
977 apex_available: [ "myapex" ],
978 min_sdk_version: "28",
979 }
980
981 cc_library {
982 name: "mylib4",
983 srcs: ["mylib.cpp"],
984 system_shared_libs: [],
985 stl: "none",
986 apex_available: [ "myapex" ],
987 min_sdk_version: "28",
988 }
989 `)
990
991 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
992 copyCmds := apexRule.Args["copy_commands"]
993
994 // Ensure that direct non-stubs dep is always included
995 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
996
997 // Ensure that indirect stubs dep is not included
998 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
999
1000 // Ensure that direct stubs dep is included
1001 ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
1002
1003 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex29").Rule("ld").Args["libFlags"]
1004
Jiyong Park55549df2021-02-26 23:57:23 +09001005 // Ensure that mylib is linking with the latest version of stub for mylib2
1006 ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
Colin Cross7812fd32020-09-25 12:35:10 -07001007 // ... and not linking to the non-stub (impl) variant of mylib2
1008 ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
1009
1010 // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
1011 ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex29/mylib3.so")
1012 // .. and not linking to the stubs variant of mylib3
1013 ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_29/mylib3.so")
1014
1015 // Ensure that stubs libs are built without -include flags
Colin Crossa717db72020-10-23 14:53:06 -07001016 mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("cc").Args["cFlags"]
Colin Cross7812fd32020-09-25 12:35:10 -07001017 ensureNotContains(t, mylib2Cflags, "-include ")
1018
1019 // Ensure that genstub is invoked with --apex
Colin Crossa717db72020-10-23 14:53:06 -07001020 ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("genStubSrc").Args["flags"])
Colin Cross7812fd32020-09-25 12:35:10 -07001021
1022 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
1023 "lib64/mylib.so",
1024 "lib64/mylib3.so",
1025 "lib64/mylib4.so",
1026 })
1027}
1028
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001029func TestApex_PlatformUsesLatestStubFromApex(t *testing.T) {
1030 t.Parallel()
1031 // myapex (Z)
1032 // mylib -----------------.
1033 // |
1034 // otherapex (29) |
1035 // libstub's versions: 29 Z current
1036 // |
1037 // <platform> |
1038 // libplatform ----------------'
Colin Cross1c460562021-02-16 17:55:47 -08001039 ctx := testApex(t, `
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001040 apex {
1041 name: "myapex",
1042 key: "myapex.key",
1043 native_shared_libs: ["mylib"],
1044 min_sdk_version: "Z", // non-final
1045 }
1046
1047 cc_library {
1048 name: "mylib",
1049 srcs: ["mylib.cpp"],
1050 shared_libs: ["libstub"],
1051 apex_available: ["myapex"],
1052 min_sdk_version: "Z",
1053 }
1054
1055 apex_key {
1056 name: "myapex.key",
1057 public_key: "testkey.avbpubkey",
1058 private_key: "testkey.pem",
1059 }
1060
1061 apex {
1062 name: "otherapex",
1063 key: "myapex.key",
1064 native_shared_libs: ["libstub"],
1065 min_sdk_version: "29",
1066 }
1067
1068 cc_library {
1069 name: "libstub",
1070 srcs: ["mylib.cpp"],
1071 stubs: {
1072 versions: ["29", "Z", "current"],
1073 },
1074 apex_available: ["otherapex"],
1075 min_sdk_version: "29",
1076 }
1077
1078 // platform module depending on libstub from otherapex should use the latest stub("current")
1079 cc_library {
1080 name: "libplatform",
1081 srcs: ["mylib.cpp"],
1082 shared_libs: ["libstub"],
1083 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001084 `,
1085 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1086 variables.Platform_sdk_codename = proptools.StringPtr("Z")
1087 variables.Platform_sdk_final = proptools.BoolPtr(false)
1088 variables.Platform_version_active_codenames = []string{"Z"}
1089 }),
1090 )
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001091
Jiyong Park55549df2021-02-26 23:57:23 +09001092 // Ensure that mylib from myapex is built against the latest stub (current)
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001093 mylibCflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
Jiyong Park55549df2021-02-26 23:57:23 +09001094 ensureContains(t, mylibCflags, "-D__LIBSTUB_API__=10000 ")
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001095 mylibLdflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
Jiyong Park55549df2021-02-26 23:57:23 +09001096 ensureContains(t, mylibLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001097
1098 // Ensure that libplatform is built against latest stub ("current") of mylib3 from the apex
1099 libplatformCflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
1100 ensureContains(t, libplatformCflags, "-D__LIBSTUB_API__=10000 ") // "current" maps to 10000
1101 libplatformLdflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
1102 ensureContains(t, libplatformLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
1103}
1104
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001105func TestApexWithExplicitStubsDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001106 ctx := testApex(t, `
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001107 apex {
Jiyong Park83dc74b2020-01-14 18:38:44 +09001108 name: "myapex2",
1109 key: "myapex2.key",
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001110 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001111 updatable: false,
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001112 }
1113
1114 apex_key {
Jiyong Park83dc74b2020-01-14 18:38:44 +09001115 name: "myapex2.key",
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001116 public_key: "testkey.avbpubkey",
1117 private_key: "testkey.pem",
1118 }
1119
1120 cc_library {
1121 name: "mylib",
1122 srcs: ["mylib.cpp"],
1123 shared_libs: ["libfoo#10"],
Jiyong Park678c8812020-02-07 17:25:49 +09001124 static_libs: ["libbaz"],
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001125 system_shared_libs: [],
1126 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001127 apex_available: [ "myapex2" ],
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001128 }
1129
1130 cc_library {
1131 name: "libfoo",
1132 srcs: ["mylib.cpp"],
1133 shared_libs: ["libbar"],
1134 system_shared_libs: [],
1135 stl: "none",
1136 stubs: {
1137 versions: ["10", "20", "30"],
1138 },
1139 }
1140
1141 cc_library {
1142 name: "libbar",
1143 srcs: ["mylib.cpp"],
1144 system_shared_libs: [],
1145 stl: "none",
1146 }
1147
Jiyong Park678c8812020-02-07 17:25:49 +09001148 cc_library_static {
1149 name: "libbaz",
1150 srcs: ["mylib.cpp"],
1151 system_shared_libs: [],
1152 stl: "none",
1153 apex_available: [ "myapex2" ],
1154 }
1155
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001156 `)
1157
Jiyong Park83dc74b2020-01-14 18:38:44 +09001158 apexRule := ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Rule("apexRule")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001159 copyCmds := apexRule.Args["copy_commands"]
1160
1161 // Ensure that direct non-stubs dep is always included
1162 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
1163
1164 // Ensure that indirect stubs dep is not included
1165 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
1166
1167 // Ensure that dependency of stubs is not included
1168 ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so")
1169
Colin Crossaede88c2020-08-11 12:17:01 -07001170 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001171
1172 // Ensure that mylib is linking with version 10 of libfoo
Jiyong Park3ff16992019-12-27 14:11:47 +09001173 ensureContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared_10/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001174 // ... and not linking to the non-stub (impl) variant of libfoo
Jiyong Park3ff16992019-12-27 14:11:47 +09001175 ensureNotContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001176
Jiyong Park3ff16992019-12-27 14:11:47 +09001177 libFooStubsLdFlags := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_10").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001178
1179 // Ensure that libfoo stubs is not linking to libbar (since it is a stubs)
1180 ensureNotContains(t, libFooStubsLdFlags, "libbar.so")
Jiyong Park83dc74b2020-01-14 18:38:44 +09001181
Artur Satayeva8bd1132020-04-27 18:07:06 +01001182 fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +01001183 ensureListContains(t, fullDepsInfo, " libfoo(minSdkVersion:(no version)) (external) <- mylib")
Jiyong Park678c8812020-02-07 17:25:49 +09001184
Artur Satayeva8bd1132020-04-27 18:07:06 +01001185 flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +01001186 ensureListContains(t, flatDepsInfo, "libfoo(minSdkVersion:(no version)) (external)")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001187}
1188
Jooyung Hand3639552019-08-09 12:57:43 +09001189func TestApexWithRuntimeLibsDependency(t *testing.T) {
1190 /*
1191 myapex
1192 |
1193 v (runtime_libs)
1194 mylib ------+------> libfoo [provides stub]
1195 |
1196 `------> libbar
1197 */
Colin Cross1c460562021-02-16 17:55:47 -08001198 ctx := testApex(t, `
Jooyung Hand3639552019-08-09 12:57:43 +09001199 apex {
1200 name: "myapex",
1201 key: "myapex.key",
1202 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001203 updatable: false,
Jooyung Hand3639552019-08-09 12:57:43 +09001204 }
1205
1206 apex_key {
1207 name: "myapex.key",
1208 public_key: "testkey.avbpubkey",
1209 private_key: "testkey.pem",
1210 }
1211
1212 cc_library {
1213 name: "mylib",
1214 srcs: ["mylib.cpp"],
1215 runtime_libs: ["libfoo", "libbar"],
1216 system_shared_libs: [],
1217 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001218 apex_available: [ "myapex" ],
Jooyung Hand3639552019-08-09 12:57:43 +09001219 }
1220
1221 cc_library {
1222 name: "libfoo",
1223 srcs: ["mylib.cpp"],
1224 system_shared_libs: [],
1225 stl: "none",
1226 stubs: {
1227 versions: ["10", "20", "30"],
1228 },
1229 }
1230
1231 cc_library {
1232 name: "libbar",
1233 srcs: ["mylib.cpp"],
1234 system_shared_libs: [],
1235 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001236 apex_available: [ "myapex" ],
Jooyung Hand3639552019-08-09 12:57:43 +09001237 }
1238
1239 `)
1240
Sundong Ahnabb64432019-10-22 13:58:29 +09001241 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jooyung Hand3639552019-08-09 12:57:43 +09001242 copyCmds := apexRule.Args["copy_commands"]
1243
1244 // Ensure that direct non-stubs dep is always included
1245 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
1246
1247 // Ensure that indirect stubs dep is not included
1248 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
1249
1250 // Ensure that runtime_libs dep in included
1251 ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
1252
Sundong Ahnabb64432019-10-22 13:58:29 +09001253 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001254 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
1255 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.so")
Jooyung Hand3639552019-08-09 12:57:43 +09001256
1257}
1258
Paul Duffina02cae32021-03-09 01:44:06 +00001259var prepareForTestOfRuntimeApexWithHwasan = android.GroupFixturePreparers(
1260 cc.PrepareForTestWithCcBuildComponents,
1261 PrepareForTestWithApexBuildComponents,
1262 android.FixtureAddTextFile("bionic/apex/Android.bp", `
Jooyung Han8ce8db92020-05-15 19:05:05 +09001263 apex {
1264 name: "com.android.runtime",
1265 key: "com.android.runtime.key",
1266 native_shared_libs: ["libc"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001267 updatable: false,
Jooyung Han8ce8db92020-05-15 19:05:05 +09001268 }
1269
1270 apex_key {
1271 name: "com.android.runtime.key",
1272 public_key: "testkey.avbpubkey",
1273 private_key: "testkey.pem",
1274 }
Paul Duffina02cae32021-03-09 01:44:06 +00001275 `),
1276 android.FixtureAddFile("system/sepolicy/apex/com.android.runtime-file_contexts", nil),
1277)
Jooyung Han8ce8db92020-05-15 19:05:05 +09001278
Paul Duffina02cae32021-03-09 01:44:06 +00001279func TestRuntimeApexShouldInstallHwasanIfLibcDependsOnIt(t *testing.T) {
Paul Duffin70d3bee2021-03-21 11:26:05 +00001280 result := android.GroupFixturePreparers(prepareForTestOfRuntimeApexWithHwasan).RunTestWithBp(t, `
Jooyung Han8ce8db92020-05-15 19:05:05 +09001281 cc_library {
1282 name: "libc",
1283 no_libcrt: true,
1284 nocrt: true,
1285 stl: "none",
1286 system_shared_libs: [],
1287 stubs: { versions: ["1"] },
1288 apex_available: ["com.android.runtime"],
1289
1290 sanitize: {
1291 hwaddress: true,
1292 }
1293 }
1294
1295 cc_prebuilt_library_shared {
1296 name: "libclang_rt.hwasan-aarch64-android",
1297 no_libcrt: true,
1298 nocrt: true,
1299 stl: "none",
1300 system_shared_libs: [],
1301 srcs: [""],
1302 stubs: { versions: ["1"] },
1303
1304 sanitize: {
1305 never: true,
1306 },
Paul Duffina02cae32021-03-09 01:44:06 +00001307 } `)
1308 ctx := result.TestContext
Jooyung Han8ce8db92020-05-15 19:05:05 +09001309
1310 ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
1311 "lib64/bionic/libc.so",
1312 "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
1313 })
1314
1315 hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared")
1316
1317 installed := hwasan.Description("install libclang_rt.hwasan")
1318 ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
1319
1320 symlink := hwasan.Description("install symlink libclang_rt.hwasan")
1321 ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
1322 ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
1323}
1324
1325func TestRuntimeApexShouldInstallHwasanIfHwaddressSanitized(t *testing.T) {
Paul Duffin70d3bee2021-03-21 11:26:05 +00001326 result := android.GroupFixturePreparers(
Paul Duffina02cae32021-03-09 01:44:06 +00001327 prepareForTestOfRuntimeApexWithHwasan,
1328 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1329 variables.SanitizeDevice = []string{"hwaddress"}
1330 }),
1331 ).RunTestWithBp(t, `
Jooyung Han8ce8db92020-05-15 19:05:05 +09001332 cc_library {
1333 name: "libc",
1334 no_libcrt: true,
1335 nocrt: true,
1336 stl: "none",
1337 system_shared_libs: [],
1338 stubs: { versions: ["1"] },
1339 apex_available: ["com.android.runtime"],
1340 }
1341
1342 cc_prebuilt_library_shared {
1343 name: "libclang_rt.hwasan-aarch64-android",
1344 no_libcrt: true,
1345 nocrt: true,
1346 stl: "none",
1347 system_shared_libs: [],
1348 srcs: [""],
1349 stubs: { versions: ["1"] },
1350
1351 sanitize: {
1352 never: true,
1353 },
1354 }
Paul Duffina02cae32021-03-09 01:44:06 +00001355 `)
1356 ctx := result.TestContext
Jooyung Han8ce8db92020-05-15 19:05:05 +09001357
1358 ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
1359 "lib64/bionic/libc.so",
1360 "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
1361 })
1362
1363 hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared")
1364
1365 installed := hwasan.Description("install libclang_rt.hwasan")
1366 ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
1367
1368 symlink := hwasan.Description("install symlink libclang_rt.hwasan")
1369 ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
1370 ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
1371}
1372
Jooyung Han61b66e92020-03-21 14:21:46 +00001373func TestApexDependsOnLLNDKTransitively(t *testing.T) {
1374 testcases := []struct {
1375 name string
1376 minSdkVersion string
Colin Crossaede88c2020-08-11 12:17:01 -07001377 apexVariant string
Jooyung Han61b66e92020-03-21 14:21:46 +00001378 shouldLink string
1379 shouldNotLink []string
1380 }{
1381 {
Jiyong Park55549df2021-02-26 23:57:23 +09001382 name: "unspecified version links to the latest",
Jooyung Han749dc692020-04-15 11:03:39 +09001383 minSdkVersion: "",
Colin Crossaede88c2020-08-11 12:17:01 -07001384 apexVariant: "apex10000",
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001385 shouldLink: "current",
1386 shouldNotLink: []string{"29", "30"},
Jooyung Han61b66e92020-03-21 14:21:46 +00001387 },
1388 {
Jiyong Park55549df2021-02-26 23:57:23 +09001389 name: "always use the latest",
Jooyung Han749dc692020-04-15 11:03:39 +09001390 minSdkVersion: "min_sdk_version: \"29\",",
Colin Crossaede88c2020-08-11 12:17:01 -07001391 apexVariant: "apex29",
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001392 shouldLink: "current",
1393 shouldNotLink: []string{"29", "30"},
Jooyung Han61b66e92020-03-21 14:21:46 +00001394 },
1395 }
1396 for _, tc := range testcases {
1397 t.Run(tc.name, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001398 ctx := testApex(t, `
Jooyung Han61b66e92020-03-21 14:21:46 +00001399 apex {
1400 name: "myapex",
1401 key: "myapex.key",
1402 use_vendor: true,
1403 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001404 updatable: false,
Jooyung Han749dc692020-04-15 11:03:39 +09001405 `+tc.minSdkVersion+`
Jooyung Han61b66e92020-03-21 14:21:46 +00001406 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001407
Jooyung Han61b66e92020-03-21 14:21:46 +00001408 apex_key {
1409 name: "myapex.key",
1410 public_key: "testkey.avbpubkey",
1411 private_key: "testkey.pem",
1412 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001413
Jooyung Han61b66e92020-03-21 14:21:46 +00001414 cc_library {
1415 name: "mylib",
1416 srcs: ["mylib.cpp"],
1417 vendor_available: true,
1418 shared_libs: ["libbar"],
1419 system_shared_libs: [],
1420 stl: "none",
1421 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001422 min_sdk_version: "29",
Jooyung Han61b66e92020-03-21 14:21:46 +00001423 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001424
Jooyung Han61b66e92020-03-21 14:21:46 +00001425 cc_library {
1426 name: "libbar",
1427 srcs: ["mylib.cpp"],
1428 system_shared_libs: [],
1429 stl: "none",
1430 stubs: { versions: ["29","30"] },
Colin Cross203b4212021-04-26 17:19:41 -07001431 llndk: {
1432 symbol_file: "libbar.map.txt",
1433 }
Jooyung Han61b66e92020-03-21 14:21:46 +00001434 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001435 `,
1436 setUseVendorAllowListForTest([]string{"myapex"}),
1437 withUnbundledBuild,
1438 )
Jooyung Han9c80bae2019-08-20 17:30:57 +09001439
Jooyung Han61b66e92020-03-21 14:21:46 +00001440 // Ensure that LLNDK dep is not included
1441 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
1442 "lib64/mylib.so",
1443 })
Jooyung Han9c80bae2019-08-20 17:30:57 +09001444
Jooyung Han61b66e92020-03-21 14:21:46 +00001445 // Ensure that LLNDK dep is required
1446 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
1447 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
1448 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libbar.so")
Jooyung Han9c80bae2019-08-20 17:30:57 +09001449
Jiyong Parkf58c46e2021-04-01 21:35:20 +09001450 mylibLdFlags := ctx.ModuleForTests("mylib", "android_vendor.29_arm64_armv8-a_shared_"+tc.apexVariant).Rule("ld").Args["libFlags"]
1451 ensureContains(t, mylibLdFlags, "libbar/android_vendor.29_arm64_armv8-a_shared_"+tc.shouldLink+"/libbar.so")
Jooyung Han61b66e92020-03-21 14:21:46 +00001452 for _, ver := range tc.shouldNotLink {
Jiyong Parkf58c46e2021-04-01 21:35:20 +09001453 ensureNotContains(t, mylibLdFlags, "libbar/android_vendor.29_arm64_armv8-a_shared_"+ver+"/libbar.so")
Jooyung Han61b66e92020-03-21 14:21:46 +00001454 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001455
Jiyong Parkf58c46e2021-04-01 21:35:20 +09001456 mylibCFlags := ctx.ModuleForTests("mylib", "android_vendor.29_arm64_armv8-a_static_"+tc.apexVariant).Rule("cc").Args["cFlags"]
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001457 ver := tc.shouldLink
1458 if tc.shouldLink == "current" {
1459 ver = strconv.Itoa(android.FutureApiLevelInt)
1460 }
1461 ensureContains(t, mylibCFlags, "__LIBBAR_API__="+ver)
Jooyung Han61b66e92020-03-21 14:21:46 +00001462 })
1463 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001464}
1465
Jiyong Park25fc6a92018-11-18 18:02:45 +09001466func TestApexWithSystemLibsStubs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001467 ctx := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +09001468 apex {
1469 name: "myapex",
1470 key: "myapex.key",
1471 native_shared_libs: ["mylib", "mylib_shared", "libdl", "libm"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001472 updatable: false,
Jiyong Park25fc6a92018-11-18 18:02:45 +09001473 }
1474
1475 apex_key {
1476 name: "myapex.key",
1477 public_key: "testkey.avbpubkey",
1478 private_key: "testkey.pem",
1479 }
1480
1481 cc_library {
1482 name: "mylib",
1483 srcs: ["mylib.cpp"],
Colin Cross0de8a1e2020-09-18 14:15:30 -07001484 system_shared_libs: ["libc", "libm"],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001485 shared_libs: ["libdl#27"],
1486 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001487 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001488 }
1489
1490 cc_library_shared {
1491 name: "mylib_shared",
1492 srcs: ["mylib.cpp"],
1493 shared_libs: ["libdl#27"],
1494 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001495 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001496 }
1497
1498 cc_library {
Jiyong Parkb0788572018-12-20 22:10:17 +09001499 name: "libBootstrap",
1500 srcs: ["mylib.cpp"],
1501 stl: "none",
1502 bootstrap: true,
1503 }
Jiyong Park25fc6a92018-11-18 18:02:45 +09001504 `)
1505
Sundong Ahnabb64432019-10-22 13:58:29 +09001506 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001507 copyCmds := apexRule.Args["copy_commands"]
1508
1509 // Ensure that mylib, libm, libdl are included.
Alex Light5098a612018-11-29 17:12:15 -08001510 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Parkb0788572018-12-20 22:10:17 +09001511 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libm.so")
1512 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001513
1514 // Ensure that libc is not included (since it has stubs and not listed in native_shared_libs)
Jiyong Parkb0788572018-12-20 22:10:17 +09001515 ensureNotContains(t, copyCmds, "image.apex/lib64/bionic/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001516
Colin Crossaede88c2020-08-11 12:17:01 -07001517 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
1518 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
1519 mylibSharedCFlags := ctx.ModuleForTests("mylib_shared", "android_arm64_armv8-a_shared_apex10000").Rule("cc").Args["cFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +09001520
1521 // For dependency to libc
1522 // Ensure that mylib is linking with the latest version of stubs
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001523 ensureContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared_current/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001524 // ... and not linking to the non-stub (impl) variant
Jiyong Park3ff16992019-12-27 14:11:47 +09001525 ensureNotContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001526 // ... Cflags from stub is correctly exported to mylib
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001527 ensureContains(t, mylibCFlags, "__LIBC_API__=10000")
1528 ensureContains(t, mylibSharedCFlags, "__LIBC_API__=10000")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001529
1530 // For dependency to libm
1531 // Ensure that mylib is linking with the non-stub (impl) variant
Colin Crossaede88c2020-08-11 12:17:01 -07001532 ensureContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_apex10000/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001533 // ... and not linking to the stub variant
Jiyong Park3ff16992019-12-27 14:11:47 +09001534 ensureNotContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_29/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001535 // ... and is not compiling with the stub
1536 ensureNotContains(t, mylibCFlags, "__LIBM_API__=29")
1537 ensureNotContains(t, mylibSharedCFlags, "__LIBM_API__=29")
1538
1539 // For dependency to libdl
1540 // Ensure that mylib is linking with the specified version of stubs
Jiyong Park3ff16992019-12-27 14:11:47 +09001541 ensureContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_27/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001542 // ... and not linking to the other versions of stubs
Jiyong Park3ff16992019-12-27 14:11:47 +09001543 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_28/libdl.so")
1544 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_29/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001545 // ... and not linking to the non-stub (impl) variant
Colin Crossaede88c2020-08-11 12:17:01 -07001546 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_apex10000/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001547 // ... Cflags from stub is correctly exported to mylib
1548 ensureContains(t, mylibCFlags, "__LIBDL_API__=27")
1549 ensureContains(t, mylibSharedCFlags, "__LIBDL_API__=27")
Jiyong Parkb0788572018-12-20 22:10:17 +09001550
1551 // Ensure that libBootstrap is depending on the platform variant of bionic libs
Colin Cross7113d202019-11-20 16:39:12 -08001552 libFlags := ctx.ModuleForTests("libBootstrap", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
1553 ensureContains(t, libFlags, "libc/android_arm64_armv8-a_shared/libc.so")
1554 ensureContains(t, libFlags, "libm/android_arm64_armv8-a_shared/libm.so")
1555 ensureContains(t, libFlags, "libdl/android_arm64_armv8-a_shared/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001556}
Jiyong Park7c2ee712018-12-07 00:42:25 +09001557
Jooyung Han749dc692020-04-15 11:03:39 +09001558func TestApexMinSdkVersion_NativeModulesShouldBeBuiltAgainstStubs(t *testing.T) {
Jiyong Park55549df2021-02-26 23:57:23 +09001559 // there are three links between liba --> libz.
1560 // 1) myapex -> libx -> liba -> libz : this should be #30 link
Jooyung Han749dc692020-04-15 11:03:39 +09001561 // 2) otherapex -> liby -> liba -> libz : this should be #30 link
Jooyung Han03b51852020-02-26 22:45:42 +09001562 // 3) (platform) -> liba -> libz : this should be non-stub link
Colin Cross1c460562021-02-16 17:55:47 -08001563 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001564 apex {
1565 name: "myapex",
1566 key: "myapex.key",
1567 native_shared_libs: ["libx"],
Jooyung Han749dc692020-04-15 11:03:39 +09001568 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001569 }
1570
1571 apex {
1572 name: "otherapex",
1573 key: "myapex.key",
1574 native_shared_libs: ["liby"],
Jooyung Han749dc692020-04-15 11:03:39 +09001575 min_sdk_version: "30",
Jooyung Han03b51852020-02-26 22:45:42 +09001576 }
1577
1578 apex_key {
1579 name: "myapex.key",
1580 public_key: "testkey.avbpubkey",
1581 private_key: "testkey.pem",
1582 }
1583
1584 cc_library {
1585 name: "libx",
1586 shared_libs: ["liba"],
1587 system_shared_libs: [],
1588 stl: "none",
1589 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001590 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001591 }
1592
1593 cc_library {
1594 name: "liby",
1595 shared_libs: ["liba"],
1596 system_shared_libs: [],
1597 stl: "none",
1598 apex_available: [ "otherapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001599 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001600 }
1601
1602 cc_library {
1603 name: "liba",
1604 shared_libs: ["libz"],
1605 system_shared_libs: [],
1606 stl: "none",
1607 apex_available: [
1608 "//apex_available:anyapex",
1609 "//apex_available:platform",
1610 ],
Jooyung Han749dc692020-04-15 11:03:39 +09001611 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001612 }
1613
1614 cc_library {
1615 name: "libz",
1616 system_shared_libs: [],
1617 stl: "none",
1618 stubs: {
Jooyung Han749dc692020-04-15 11:03:39 +09001619 versions: ["28", "30"],
Jooyung Han03b51852020-02-26 22:45:42 +09001620 },
1621 }
Jooyung Han749dc692020-04-15 11:03:39 +09001622 `)
Jooyung Han03b51852020-02-26 22:45:42 +09001623
1624 expectLink := func(from, from_variant, to, to_variant string) {
1625 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1626 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1627 }
1628 expectNoLink := func(from, from_variant, to, to_variant string) {
1629 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1630 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1631 }
1632 // platform liba is linked to non-stub version
1633 expectLink("liba", "shared", "libz", "shared")
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001634 // liba in myapex is linked to current
1635 expectLink("liba", "shared_apex29", "libz", "shared_current")
1636 expectNoLink("liba", "shared_apex29", "libz", "shared_30")
Jiyong Park55549df2021-02-26 23:57:23 +09001637 expectNoLink("liba", "shared_apex29", "libz", "shared_28")
Colin Crossaede88c2020-08-11 12:17:01 -07001638 expectNoLink("liba", "shared_apex29", "libz", "shared")
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001639 // liba in otherapex is linked to current
1640 expectLink("liba", "shared_apex30", "libz", "shared_current")
1641 expectNoLink("liba", "shared_apex30", "libz", "shared_30")
Colin Crossaede88c2020-08-11 12:17:01 -07001642 expectNoLink("liba", "shared_apex30", "libz", "shared_28")
1643 expectNoLink("liba", "shared_apex30", "libz", "shared")
Jooyung Han03b51852020-02-26 22:45:42 +09001644}
1645
Jooyung Hanaed150d2020-04-02 01:41:41 +09001646func TestApexMinSdkVersion_SupportsCodeNames(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001647 ctx := testApex(t, `
Jooyung Hanaed150d2020-04-02 01:41:41 +09001648 apex {
1649 name: "myapex",
1650 key: "myapex.key",
1651 native_shared_libs: ["libx"],
1652 min_sdk_version: "R",
1653 }
1654
1655 apex_key {
1656 name: "myapex.key",
1657 public_key: "testkey.avbpubkey",
1658 private_key: "testkey.pem",
1659 }
1660
1661 cc_library {
1662 name: "libx",
1663 shared_libs: ["libz"],
1664 system_shared_libs: [],
1665 stl: "none",
1666 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001667 min_sdk_version: "R",
Jooyung Hanaed150d2020-04-02 01:41:41 +09001668 }
1669
1670 cc_library {
1671 name: "libz",
1672 system_shared_libs: [],
1673 stl: "none",
1674 stubs: {
1675 versions: ["29", "R"],
1676 },
1677 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001678 `,
1679 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1680 variables.Platform_version_active_codenames = []string{"R"}
1681 }),
1682 )
Jooyung Hanaed150d2020-04-02 01:41:41 +09001683
1684 expectLink := func(from, from_variant, to, to_variant string) {
1685 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1686 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1687 }
1688 expectNoLink := func(from, from_variant, to, to_variant string) {
1689 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1690 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1691 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001692 expectLink("libx", "shared_apex10000", "libz", "shared_current")
1693 expectNoLink("libx", "shared_apex10000", "libz", "shared_R")
Colin Crossaede88c2020-08-11 12:17:01 -07001694 expectNoLink("libx", "shared_apex10000", "libz", "shared_29")
1695 expectNoLink("libx", "shared_apex10000", "libz", "shared")
Jooyung Hanaed150d2020-04-02 01:41:41 +09001696}
1697
Jooyung Han4c4da062021-06-23 10:23:16 +09001698func TestApexMinSdkVersion_SupportsCodeNames_JavaLibs(t *testing.T) {
1699 testApex(t, `
1700 apex {
1701 name: "myapex",
1702 key: "myapex.key",
1703 java_libs: ["libx"],
1704 min_sdk_version: "S",
1705 }
1706
1707 apex_key {
1708 name: "myapex.key",
1709 public_key: "testkey.avbpubkey",
1710 private_key: "testkey.pem",
1711 }
1712
1713 java_library {
1714 name: "libx",
1715 srcs: ["a.java"],
1716 apex_available: [ "myapex" ],
1717 sdk_version: "current",
1718 min_sdk_version: "S", // should be okay
1719 }
1720 `,
1721 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1722 variables.Platform_version_active_codenames = []string{"S"}
1723 variables.Platform_sdk_codename = proptools.StringPtr("S")
1724 }),
1725 )
1726}
1727
Jooyung Han749dc692020-04-15 11:03:39 +09001728func TestApexMinSdkVersion_DefaultsToLatest(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001729 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001730 apex {
1731 name: "myapex",
1732 key: "myapex.key",
1733 native_shared_libs: ["libx"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001734 updatable: false,
Jooyung Han03b51852020-02-26 22:45:42 +09001735 }
1736
1737 apex_key {
1738 name: "myapex.key",
1739 public_key: "testkey.avbpubkey",
1740 private_key: "testkey.pem",
1741 }
1742
1743 cc_library {
1744 name: "libx",
1745 shared_libs: ["libz"],
1746 system_shared_libs: [],
1747 stl: "none",
1748 apex_available: [ "myapex" ],
1749 }
1750
1751 cc_library {
1752 name: "libz",
1753 system_shared_libs: [],
1754 stl: "none",
1755 stubs: {
1756 versions: ["1", "2"],
1757 },
1758 }
1759 `)
1760
1761 expectLink := func(from, from_variant, to, to_variant string) {
1762 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1763 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1764 }
1765 expectNoLink := func(from, from_variant, to, to_variant string) {
1766 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1767 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1768 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001769 expectLink("libx", "shared_apex10000", "libz", "shared_current")
Colin Crossaede88c2020-08-11 12:17:01 -07001770 expectNoLink("libx", "shared_apex10000", "libz", "shared_1")
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001771 expectNoLink("libx", "shared_apex10000", "libz", "shared_2")
Colin Crossaede88c2020-08-11 12:17:01 -07001772 expectNoLink("libx", "shared_apex10000", "libz", "shared")
Jooyung Han03b51852020-02-26 22:45:42 +09001773}
1774
1775func TestPlatformUsesLatestStubsFromApexes(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001776 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001777 apex {
1778 name: "myapex",
1779 key: "myapex.key",
1780 native_shared_libs: ["libx"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001781 updatable: false,
Jooyung Han03b51852020-02-26 22:45:42 +09001782 }
1783
1784 apex_key {
1785 name: "myapex.key",
1786 public_key: "testkey.avbpubkey",
1787 private_key: "testkey.pem",
1788 }
1789
1790 cc_library {
1791 name: "libx",
1792 system_shared_libs: [],
1793 stl: "none",
1794 apex_available: [ "myapex" ],
1795 stubs: {
1796 versions: ["1", "2"],
1797 },
1798 }
1799
1800 cc_library {
1801 name: "libz",
1802 shared_libs: ["libx"],
1803 system_shared_libs: [],
1804 stl: "none",
1805 }
1806 `)
1807
1808 expectLink := func(from, from_variant, to, to_variant string) {
Colin Cross56a83212020-09-15 18:30:11 -07001809 t.Helper()
Jooyung Han03b51852020-02-26 22:45:42 +09001810 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1811 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1812 }
1813 expectNoLink := func(from, from_variant, to, to_variant string) {
Colin Cross56a83212020-09-15 18:30:11 -07001814 t.Helper()
Jooyung Han03b51852020-02-26 22:45:42 +09001815 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1816 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1817 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001818 expectLink("libz", "shared", "libx", "shared_current")
1819 expectNoLink("libz", "shared", "libx", "shared_2")
Jooyung Han03b51852020-02-26 22:45:42 +09001820 expectNoLink("libz", "shared", "libz", "shared_1")
1821 expectNoLink("libz", "shared", "libz", "shared")
1822}
1823
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001824var prepareForTestWithSantitizeHwaddress = android.FixtureModifyProductVariables(
1825 func(variables android.FixtureProductVariables) {
1826 variables.SanitizeDevice = []string{"hwaddress"}
1827 },
1828)
1829
Jooyung Han75568392020-03-20 04:29:24 +09001830func TestQApexesUseLatestStubsInBundledBuildsAndHWASAN(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001831 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001832 apex {
1833 name: "myapex",
1834 key: "myapex.key",
1835 native_shared_libs: ["libx"],
1836 min_sdk_version: "29",
1837 }
1838
1839 apex_key {
1840 name: "myapex.key",
1841 public_key: "testkey.avbpubkey",
1842 private_key: "testkey.pem",
1843 }
1844
1845 cc_library {
1846 name: "libx",
1847 shared_libs: ["libbar"],
1848 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001849 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001850 }
1851
1852 cc_library {
1853 name: "libbar",
1854 stubs: {
1855 versions: ["29", "30"],
1856 },
1857 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001858 `,
1859 prepareForTestWithSantitizeHwaddress,
1860 )
Jooyung Han03b51852020-02-26 22:45:42 +09001861 expectLink := func(from, from_variant, to, to_variant string) {
1862 ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
1863 libFlags := ld.Args["libFlags"]
1864 ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1865 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001866 expectLink("libx", "shared_hwasan_apex29", "libbar", "shared_current")
Jooyung Han03b51852020-02-26 22:45:42 +09001867}
1868
Jooyung Han75568392020-03-20 04:29:24 +09001869func TestQTargetApexUsesStaticUnwinder(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001870 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001871 apex {
1872 name: "myapex",
1873 key: "myapex.key",
1874 native_shared_libs: ["libx"],
1875 min_sdk_version: "29",
1876 }
1877
1878 apex_key {
1879 name: "myapex.key",
1880 public_key: "testkey.avbpubkey",
1881 private_key: "testkey.pem",
1882 }
1883
1884 cc_library {
1885 name: "libx",
1886 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001887 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001888 }
Jooyung Han75568392020-03-20 04:29:24 +09001889 `)
Jooyung Han03b51852020-02-26 22:45:42 +09001890
1891 // ensure apex variant of c++ is linked with static unwinder
Colin Crossaede88c2020-08-11 12:17:01 -07001892 cm := ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared_apex29").Module().(*cc.Module)
Ryan Prichardb35a85e2021-01-13 19:18:53 -08001893 ensureListContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
Jooyung Han03b51852020-02-26 22:45:42 +09001894 // note that platform variant is not.
1895 cm = ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared").Module().(*cc.Module)
Ryan Prichardb35a85e2021-01-13 19:18:53 -08001896 ensureListNotContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
Jooyung Han03b51852020-02-26 22:45:42 +09001897}
1898
Jooyung Han749dc692020-04-15 11:03:39 +09001899func TestApexMinSdkVersion_ErrorIfIncompatibleVersion(t *testing.T) {
1900 testApexError(t, `module "mylib".*: should support min_sdk_version\(29\)`, `
Jooyung Han03b51852020-02-26 22:45:42 +09001901 apex {
1902 name: "myapex",
1903 key: "myapex.key",
Jooyung Han749dc692020-04-15 11:03:39 +09001904 native_shared_libs: ["mylib"],
1905 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001906 }
1907
1908 apex_key {
1909 name: "myapex.key",
1910 public_key: "testkey.avbpubkey",
1911 private_key: "testkey.pem",
1912 }
Jooyung Han749dc692020-04-15 11:03:39 +09001913
1914 cc_library {
1915 name: "mylib",
1916 srcs: ["mylib.cpp"],
1917 system_shared_libs: [],
1918 stl: "none",
1919 apex_available: [
1920 "myapex",
1921 ],
1922 min_sdk_version: "30",
1923 }
1924 `)
Ivan Lozano3e9f9e42020-12-04 15:05:43 -05001925
1926 testApexError(t, `module "libfoo.ffi".*: should support min_sdk_version\(29\)`, `
1927 apex {
1928 name: "myapex",
1929 key: "myapex.key",
1930 native_shared_libs: ["libfoo.ffi"],
1931 min_sdk_version: "29",
1932 }
1933
1934 apex_key {
1935 name: "myapex.key",
1936 public_key: "testkey.avbpubkey",
1937 private_key: "testkey.pem",
1938 }
1939
1940 rust_ffi_shared {
1941 name: "libfoo.ffi",
1942 srcs: ["foo.rs"],
1943 crate_name: "foo",
1944 apex_available: [
1945 "myapex",
1946 ],
1947 min_sdk_version: "30",
1948 }
1949 `)
Jaewoong Jung56e12db2021-04-02 00:38:25 +00001950
1951 testApexError(t, `module "libfoo".*: should support min_sdk_version\(29\)`, `
1952 apex {
1953 name: "myapex",
1954 key: "myapex.key",
1955 java_libs: ["libfoo"],
1956 min_sdk_version: "29",
1957 }
1958
1959 apex_key {
1960 name: "myapex.key",
1961 public_key: "testkey.avbpubkey",
1962 private_key: "testkey.pem",
1963 }
1964
1965 java_import {
1966 name: "libfoo",
1967 jars: ["libfoo.jar"],
1968 apex_available: [
1969 "myapex",
1970 ],
1971 min_sdk_version: "30",
1972 }
1973 `)
Jooyung Han749dc692020-04-15 11:03:39 +09001974}
1975
1976func TestApexMinSdkVersion_Okay(t *testing.T) {
1977 testApex(t, `
1978 apex {
1979 name: "myapex",
1980 key: "myapex.key",
1981 native_shared_libs: ["libfoo"],
1982 java_libs: ["libbar"],
1983 min_sdk_version: "29",
1984 }
1985
1986 apex_key {
1987 name: "myapex.key",
1988 public_key: "testkey.avbpubkey",
1989 private_key: "testkey.pem",
1990 }
1991
1992 cc_library {
1993 name: "libfoo",
1994 srcs: ["mylib.cpp"],
1995 shared_libs: ["libfoo_dep"],
1996 apex_available: ["myapex"],
1997 min_sdk_version: "29",
1998 }
1999
2000 cc_library {
2001 name: "libfoo_dep",
2002 srcs: ["mylib.cpp"],
2003 apex_available: ["myapex"],
2004 min_sdk_version: "29",
2005 }
2006
2007 java_library {
2008 name: "libbar",
2009 sdk_version: "current",
2010 srcs: ["a.java"],
Jaewoong Jung56e12db2021-04-02 00:38:25 +00002011 static_libs: [
2012 "libbar_dep",
2013 "libbar_import_dep",
2014 ],
Jooyung Han749dc692020-04-15 11:03:39 +09002015 apex_available: ["myapex"],
2016 min_sdk_version: "29",
2017 }
2018
2019 java_library {
2020 name: "libbar_dep",
2021 sdk_version: "current",
2022 srcs: ["a.java"],
2023 apex_available: ["myapex"],
2024 min_sdk_version: "29",
2025 }
Jaewoong Jung56e12db2021-04-02 00:38:25 +00002026
2027 java_import {
2028 name: "libbar_import_dep",
2029 jars: ["libbar.jar"],
2030 apex_available: ["myapex"],
2031 min_sdk_version: "29",
2032 }
Jooyung Han03b51852020-02-26 22:45:42 +09002033 `)
2034}
2035
Artur Satayev8cf899a2020-04-15 17:29:42 +01002036func TestJavaStableSdkVersion(t *testing.T) {
2037 testCases := []struct {
2038 name string
2039 expectedError string
2040 bp string
2041 }{
2042 {
2043 name: "Non-updatable apex with non-stable dep",
2044 bp: `
2045 apex {
2046 name: "myapex",
2047 java_libs: ["myjar"],
2048 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002049 updatable: false,
Artur Satayev8cf899a2020-04-15 17:29:42 +01002050 }
2051 apex_key {
2052 name: "myapex.key",
2053 public_key: "testkey.avbpubkey",
2054 private_key: "testkey.pem",
2055 }
2056 java_library {
2057 name: "myjar",
2058 srcs: ["foo/bar/MyClass.java"],
Paul Duffin043f5e72021-03-05 00:00:01 +00002059 sdk_version: "test_current",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002060 apex_available: ["myapex"],
2061 }
2062 `,
2063 },
2064 {
2065 name: "Updatable apex with stable dep",
2066 bp: `
2067 apex {
2068 name: "myapex",
2069 java_libs: ["myjar"],
2070 key: "myapex.key",
2071 updatable: true,
2072 min_sdk_version: "29",
2073 }
2074 apex_key {
2075 name: "myapex.key",
2076 public_key: "testkey.avbpubkey",
2077 private_key: "testkey.pem",
2078 }
2079 java_library {
2080 name: "myjar",
2081 srcs: ["foo/bar/MyClass.java"],
2082 sdk_version: "current",
2083 apex_available: ["myapex"],
Jooyung Han749dc692020-04-15 11:03:39 +09002084 min_sdk_version: "29",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002085 }
2086 `,
2087 },
2088 {
2089 name: "Updatable apex with non-stable dep",
2090 expectedError: "cannot depend on \"myjar\"",
2091 bp: `
2092 apex {
2093 name: "myapex",
2094 java_libs: ["myjar"],
2095 key: "myapex.key",
2096 updatable: true,
2097 }
2098 apex_key {
2099 name: "myapex.key",
2100 public_key: "testkey.avbpubkey",
2101 private_key: "testkey.pem",
2102 }
2103 java_library {
2104 name: "myjar",
2105 srcs: ["foo/bar/MyClass.java"],
Paul Duffin043f5e72021-03-05 00:00:01 +00002106 sdk_version: "test_current",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002107 apex_available: ["myapex"],
2108 }
2109 `,
2110 },
2111 {
Paul Duffin043f5e72021-03-05 00:00:01 +00002112 name: "Updatable apex with non-stable transitive dep",
2113 // This is not actually detecting that the transitive dependency is unstable, rather it is
2114 // detecting that the transitive dependency is building against a wider API surface than the
2115 // module that depends on it is using.
Jiyong Park670e0f62021-02-18 13:10:18 +09002116 expectedError: "compiles against Android API, but dependency \"transitive-jar\" is compiling against private API.",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002117 bp: `
2118 apex {
2119 name: "myapex",
2120 java_libs: ["myjar"],
2121 key: "myapex.key",
2122 updatable: true,
2123 }
2124 apex_key {
2125 name: "myapex.key",
2126 public_key: "testkey.avbpubkey",
2127 private_key: "testkey.pem",
2128 }
2129 java_library {
2130 name: "myjar",
2131 srcs: ["foo/bar/MyClass.java"],
2132 sdk_version: "current",
2133 apex_available: ["myapex"],
2134 static_libs: ["transitive-jar"],
2135 }
2136 java_library {
2137 name: "transitive-jar",
2138 srcs: ["foo/bar/MyClass.java"],
2139 sdk_version: "core_platform",
2140 apex_available: ["myapex"],
2141 }
2142 `,
2143 },
2144 }
2145
2146 for _, test := range testCases {
2147 t.Run(test.name, func(t *testing.T) {
2148 if test.expectedError == "" {
2149 testApex(t, test.bp)
2150 } else {
2151 testApexError(t, test.expectedError, test.bp)
2152 }
2153 })
2154 }
2155}
2156
Jooyung Han749dc692020-04-15 11:03:39 +09002157func TestApexMinSdkVersion_ErrorIfDepIsNewer(t *testing.T) {
2158 testApexError(t, `module "mylib2".*: should support min_sdk_version\(29\) for "myapex"`, `
2159 apex {
2160 name: "myapex",
2161 key: "myapex.key",
2162 native_shared_libs: ["mylib"],
2163 min_sdk_version: "29",
2164 }
2165
2166 apex_key {
2167 name: "myapex.key",
2168 public_key: "testkey.avbpubkey",
2169 private_key: "testkey.pem",
2170 }
2171
2172 cc_library {
2173 name: "mylib",
2174 srcs: ["mylib.cpp"],
2175 shared_libs: ["mylib2"],
2176 system_shared_libs: [],
2177 stl: "none",
2178 apex_available: [
2179 "myapex",
2180 ],
2181 min_sdk_version: "29",
2182 }
2183
2184 // indirect part of the apex
2185 cc_library {
2186 name: "mylib2",
2187 srcs: ["mylib.cpp"],
2188 system_shared_libs: [],
2189 stl: "none",
2190 apex_available: [
2191 "myapex",
2192 ],
2193 min_sdk_version: "30",
2194 }
2195 `)
2196}
2197
2198func TestApexMinSdkVersion_ErrorIfDepIsNewer_Java(t *testing.T) {
2199 testApexError(t, `module "bar".*: should support min_sdk_version\(29\) for "myapex"`, `
2200 apex {
2201 name: "myapex",
2202 key: "myapex.key",
2203 apps: ["AppFoo"],
2204 min_sdk_version: "29",
2205 }
2206
2207 apex_key {
2208 name: "myapex.key",
2209 public_key: "testkey.avbpubkey",
2210 private_key: "testkey.pem",
2211 }
2212
2213 android_app {
2214 name: "AppFoo",
2215 srcs: ["foo/bar/MyClass.java"],
2216 sdk_version: "current",
2217 min_sdk_version: "29",
2218 system_modules: "none",
2219 stl: "none",
2220 static_libs: ["bar"],
2221 apex_available: [ "myapex" ],
2222 }
2223
2224 java_library {
2225 name: "bar",
2226 sdk_version: "current",
2227 srcs: ["a.java"],
2228 apex_available: [ "myapex" ],
2229 }
2230 `)
2231}
2232
2233func TestApexMinSdkVersion_OkayEvenWhenDepIsNewer_IfItSatisfiesApexMinSdkVersion(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002234 ctx := testApex(t, `
Jooyung Han749dc692020-04-15 11:03:39 +09002235 apex {
2236 name: "myapex",
2237 key: "myapex.key",
2238 native_shared_libs: ["mylib"],
2239 min_sdk_version: "29",
2240 }
2241
2242 apex_key {
2243 name: "myapex.key",
2244 public_key: "testkey.avbpubkey",
2245 private_key: "testkey.pem",
2246 }
2247
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002248 // mylib in myapex will link to mylib2#current
Jooyung Han749dc692020-04-15 11:03:39 +09002249 // mylib in otherapex will link to mylib2(non-stub) in otherapex as well
2250 cc_library {
2251 name: "mylib",
2252 srcs: ["mylib.cpp"],
2253 shared_libs: ["mylib2"],
2254 system_shared_libs: [],
2255 stl: "none",
2256 apex_available: ["myapex", "otherapex"],
2257 min_sdk_version: "29",
2258 }
2259
2260 cc_library {
2261 name: "mylib2",
2262 srcs: ["mylib.cpp"],
2263 system_shared_libs: [],
2264 stl: "none",
2265 apex_available: ["otherapex"],
2266 stubs: { versions: ["29", "30"] },
2267 min_sdk_version: "30",
2268 }
2269
2270 apex {
2271 name: "otherapex",
2272 key: "myapex.key",
2273 native_shared_libs: ["mylib", "mylib2"],
2274 min_sdk_version: "30",
2275 }
2276 `)
2277 expectLink := func(from, from_variant, to, to_variant string) {
2278 ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
2279 libFlags := ld.Args["libFlags"]
2280 ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
2281 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002282 expectLink("mylib", "shared_apex29", "mylib2", "shared_current")
Colin Crossaede88c2020-08-11 12:17:01 -07002283 expectLink("mylib", "shared_apex30", "mylib2", "shared_apex30")
Jooyung Han749dc692020-04-15 11:03:39 +09002284}
2285
Jooyung Haned124c32021-01-26 11:43:46 +09002286func TestApexMinSdkVersion_WorksWithSdkCodename(t *testing.T) {
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002287 withSAsActiveCodeNames := android.FixtureModifyProductVariables(
2288 func(variables android.FixtureProductVariables) {
2289 variables.Platform_sdk_codename = proptools.StringPtr("S")
2290 variables.Platform_version_active_codenames = []string{"S"}
2291 },
2292 )
Jooyung Haned124c32021-01-26 11:43:46 +09002293 testApexError(t, `libbar.*: should support min_sdk_version\(S\)`, `
2294 apex {
2295 name: "myapex",
2296 key: "myapex.key",
2297 native_shared_libs: ["libfoo"],
2298 min_sdk_version: "S",
2299 }
2300 apex_key {
2301 name: "myapex.key",
2302 public_key: "testkey.avbpubkey",
2303 private_key: "testkey.pem",
2304 }
2305 cc_library {
2306 name: "libfoo",
2307 shared_libs: ["libbar"],
2308 apex_available: ["myapex"],
2309 min_sdk_version: "29",
2310 }
2311 cc_library {
2312 name: "libbar",
2313 apex_available: ["myapex"],
2314 }
2315 `, withSAsActiveCodeNames)
2316}
2317
2318func TestApexMinSdkVersion_WorksWithActiveCodenames(t *testing.T) {
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002319 withSAsActiveCodeNames := android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
2320 variables.Platform_sdk_codename = proptools.StringPtr("S")
2321 variables.Platform_version_active_codenames = []string{"S", "T"}
2322 })
Colin Cross1c460562021-02-16 17:55:47 -08002323 ctx := testApex(t, `
Jooyung Haned124c32021-01-26 11:43:46 +09002324 apex {
2325 name: "myapex",
2326 key: "myapex.key",
2327 native_shared_libs: ["libfoo"],
2328 min_sdk_version: "S",
2329 }
2330 apex_key {
2331 name: "myapex.key",
2332 public_key: "testkey.avbpubkey",
2333 private_key: "testkey.pem",
2334 }
2335 cc_library {
2336 name: "libfoo",
2337 shared_libs: ["libbar"],
2338 apex_available: ["myapex"],
2339 min_sdk_version: "S",
2340 }
2341 cc_library {
2342 name: "libbar",
2343 stubs: {
2344 symbol_file: "libbar.map.txt",
2345 versions: ["30", "S", "T"],
2346 },
2347 }
2348 `, withSAsActiveCodeNames)
2349
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002350 // ensure libfoo is linked with current version of libbar stub
Jooyung Haned124c32021-01-26 11:43:46 +09002351 libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_apex10000")
2352 libFlags := libfoo.Rule("ld").Args["libFlags"]
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002353 ensureContains(t, libFlags, "android_arm64_armv8-a_shared_current/libbar.so")
Jooyung Haned124c32021-01-26 11:43:46 +09002354}
2355
Jiyong Park7c2ee712018-12-07 00:42:25 +09002356func TestFilesInSubDir(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002357 ctx := testApex(t, `
Jiyong Park7c2ee712018-12-07 00:42:25 +09002358 apex {
2359 name: "myapex",
2360 key: "myapex.key",
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002361 native_shared_libs: ["mylib"],
2362 binaries: ["mybin"],
Jiyong Park7c2ee712018-12-07 00:42:25 +09002363 prebuilts: ["myetc"],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002364 compile_multilib: "both",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002365 updatable: false,
Jiyong Park7c2ee712018-12-07 00:42:25 +09002366 }
2367
2368 apex_key {
2369 name: "myapex.key",
2370 public_key: "testkey.avbpubkey",
2371 private_key: "testkey.pem",
2372 }
2373
2374 prebuilt_etc {
2375 name: "myetc",
2376 src: "myprebuilt",
2377 sub_dir: "foo/bar",
2378 }
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002379
2380 cc_library {
2381 name: "mylib",
2382 srcs: ["mylib.cpp"],
2383 relative_install_path: "foo/bar",
2384 system_shared_libs: [],
2385 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002386 apex_available: [ "myapex" ],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002387 }
2388
2389 cc_binary {
2390 name: "mybin",
2391 srcs: ["mylib.cpp"],
2392 relative_install_path: "foo/bar",
2393 system_shared_libs: [],
2394 static_executable: true,
2395 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002396 apex_available: [ "myapex" ],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002397 }
Jiyong Park7c2ee712018-12-07 00:42:25 +09002398 `)
2399
Sundong Ahnabb64432019-10-22 13:58:29 +09002400 generateFsRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("generateFsConfig")
Jiyong Park7c2ee712018-12-07 00:42:25 +09002401 dirs := strings.Split(generateFsRule.Args["exec_paths"], " ")
2402
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002403 // Ensure that the subdirectories are all listed
Jiyong Park7c2ee712018-12-07 00:42:25 +09002404 ensureListContains(t, dirs, "etc")
2405 ensureListContains(t, dirs, "etc/foo")
2406 ensureListContains(t, dirs, "etc/foo/bar")
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002407 ensureListContains(t, dirs, "lib64")
2408 ensureListContains(t, dirs, "lib64/foo")
2409 ensureListContains(t, dirs, "lib64/foo/bar")
2410 ensureListContains(t, dirs, "lib")
2411 ensureListContains(t, dirs, "lib/foo")
2412 ensureListContains(t, dirs, "lib/foo/bar")
2413
Jiyong Parkbd13e442019-03-15 18:10:35 +09002414 ensureListContains(t, dirs, "bin")
2415 ensureListContains(t, dirs, "bin/foo")
2416 ensureListContains(t, dirs, "bin/foo/bar")
Jiyong Park7c2ee712018-12-07 00:42:25 +09002417}
Jiyong Parkda6eb592018-12-19 17:12:36 +09002418
Jooyung Han35155c42020-02-06 17:33:20 +09002419func TestFilesInSubDirWhenNativeBridgeEnabled(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002420 ctx := testApex(t, `
Jooyung Han35155c42020-02-06 17:33:20 +09002421 apex {
2422 name: "myapex",
2423 key: "myapex.key",
2424 multilib: {
2425 both: {
2426 native_shared_libs: ["mylib"],
2427 binaries: ["mybin"],
2428 },
2429 },
2430 compile_multilib: "both",
2431 native_bridge_supported: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002432 updatable: false,
Jooyung Han35155c42020-02-06 17:33:20 +09002433 }
2434
2435 apex_key {
2436 name: "myapex.key",
2437 public_key: "testkey.avbpubkey",
2438 private_key: "testkey.pem",
2439 }
2440
2441 cc_library {
2442 name: "mylib",
2443 relative_install_path: "foo/bar",
2444 system_shared_libs: [],
2445 stl: "none",
2446 apex_available: [ "myapex" ],
2447 native_bridge_supported: true,
2448 }
2449
2450 cc_binary {
2451 name: "mybin",
2452 relative_install_path: "foo/bar",
2453 system_shared_libs: [],
2454 static_executable: true,
2455 stl: "none",
2456 apex_available: [ "myapex" ],
2457 native_bridge_supported: true,
2458 compile_multilib: "both", // default is "first" for binary
2459 multilib: {
2460 lib64: {
2461 suffix: "64",
2462 },
2463 },
2464 }
2465 `, withNativeBridgeEnabled)
2466 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2467 "bin/foo/bar/mybin",
2468 "bin/foo/bar/mybin64",
2469 "bin/arm/foo/bar/mybin",
2470 "bin/arm64/foo/bar/mybin64",
2471 "lib/foo/bar/mylib.so",
2472 "lib/arm/foo/bar/mylib.so",
2473 "lib64/foo/bar/mylib.so",
2474 "lib64/arm64/foo/bar/mylib.so",
2475 })
2476}
2477
Jiyong Parkda6eb592018-12-19 17:12:36 +09002478func TestUseVendor(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002479 ctx := testApex(t, `
Jiyong Parkda6eb592018-12-19 17:12:36 +09002480 apex {
2481 name: "myapex",
2482 key: "myapex.key",
2483 native_shared_libs: ["mylib"],
2484 use_vendor: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002485 updatable: false,
Jiyong Parkda6eb592018-12-19 17:12:36 +09002486 }
2487
2488 apex_key {
2489 name: "myapex.key",
2490 public_key: "testkey.avbpubkey",
2491 private_key: "testkey.pem",
2492 }
2493
2494 cc_library {
2495 name: "mylib",
2496 srcs: ["mylib.cpp"],
2497 shared_libs: ["mylib2"],
2498 system_shared_libs: [],
2499 vendor_available: true,
2500 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002501 apex_available: [ "myapex" ],
Jiyong Parkda6eb592018-12-19 17:12:36 +09002502 }
2503
2504 cc_library {
2505 name: "mylib2",
2506 srcs: ["mylib.cpp"],
2507 system_shared_libs: [],
2508 vendor_available: true,
2509 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002510 apex_available: [ "myapex" ],
Jiyong Parkda6eb592018-12-19 17:12:36 +09002511 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002512 `,
2513 setUseVendorAllowListForTest([]string{"myapex"}),
2514 )
Jiyong Parkda6eb592018-12-19 17:12:36 +09002515
2516 inputsList := []string{}
Sundong Ahnabb64432019-10-22 13:58:29 +09002517 for _, i := range ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().BuildParamsForTests() {
Jiyong Parkda6eb592018-12-19 17:12:36 +09002518 for _, implicit := range i.Implicits {
2519 inputsList = append(inputsList, implicit.String())
2520 }
2521 }
2522 inputsString := strings.Join(inputsList, " ")
2523
2524 // ensure that the apex includes vendor variants of the direct and indirect deps
Jiyong Parkf58c46e2021-04-01 21:35:20 +09002525 ensureContains(t, inputsString, "android_vendor.29_arm64_armv8-a_shared_apex10000/mylib.so")
2526 ensureContains(t, inputsString, "android_vendor.29_arm64_armv8-a_shared_apex10000/mylib2.so")
Jiyong Parkda6eb592018-12-19 17:12:36 +09002527
2528 // ensure that the apex does not include core variants
Colin Crossaede88c2020-08-11 12:17:01 -07002529 ensureNotContains(t, inputsString, "android_arm64_armv8-a_shared_apex10000/mylib.so")
2530 ensureNotContains(t, inputsString, "android_arm64_armv8-a_shared_apex10000/mylib2.so")
Jiyong Parkda6eb592018-12-19 17:12:36 +09002531}
Jiyong Park16e91a02018-12-20 18:18:08 +09002532
Jooyung Han85d61762020-06-24 23:50:26 +09002533func TestUseVendorNotAllowedForSystemApexes(t *testing.T) {
Jooyung Handc782442019-11-01 03:14:38 +09002534 testApexError(t, `module "myapex" .*: use_vendor: not allowed`, `
2535 apex {
2536 name: "myapex",
2537 key: "myapex.key",
2538 use_vendor: true,
2539 }
2540 apex_key {
2541 name: "myapex.key",
2542 public_key: "testkey.avbpubkey",
2543 private_key: "testkey.pem",
2544 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002545 `,
2546 setUseVendorAllowListForTest([]string{""}),
2547 )
Colin Cross440e0d02020-06-11 11:32:11 -07002548 // no error with allow list
Jooyung Handc782442019-11-01 03:14:38 +09002549 testApex(t, `
2550 apex {
2551 name: "myapex",
2552 key: "myapex.key",
2553 use_vendor: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002554 updatable: false,
Jooyung Handc782442019-11-01 03:14:38 +09002555 }
2556 apex_key {
2557 name: "myapex.key",
2558 public_key: "testkey.avbpubkey",
2559 private_key: "testkey.pem",
2560 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002561 `,
2562 setUseVendorAllowListForTest([]string{"myapex"}),
2563 )
Jooyung Handc782442019-11-01 03:14:38 +09002564}
2565
Jooyung Han5c998b92019-06-27 11:30:33 +09002566func TestUseVendorFailsIfNotVendorAvailable(t *testing.T) {
2567 testApexError(t, `dependency "mylib" of "myapex" missing variant:\n.*image:vendor`, `
2568 apex {
2569 name: "myapex",
2570 key: "myapex.key",
2571 native_shared_libs: ["mylib"],
2572 use_vendor: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002573 updatable: false,
Jooyung Han5c998b92019-06-27 11:30:33 +09002574 }
2575
2576 apex_key {
2577 name: "myapex.key",
2578 public_key: "testkey.avbpubkey",
2579 private_key: "testkey.pem",
2580 }
2581
2582 cc_library {
2583 name: "mylib",
2584 srcs: ["mylib.cpp"],
2585 system_shared_libs: [],
2586 stl: "none",
2587 }
2588 `)
2589}
2590
Jooyung Han85d61762020-06-24 23:50:26 +09002591func TestVendorApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002592 ctx := testApex(t, `
Jooyung Han85d61762020-06-24 23:50:26 +09002593 apex {
2594 name: "myapex",
2595 key: "myapex.key",
2596 binaries: ["mybin"],
2597 vendor: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002598 updatable: false,
Jooyung Han85d61762020-06-24 23:50:26 +09002599 }
2600 apex_key {
2601 name: "myapex.key",
2602 public_key: "testkey.avbpubkey",
2603 private_key: "testkey.pem",
2604 }
2605 cc_binary {
2606 name: "mybin",
2607 vendor: true,
2608 shared_libs: ["libfoo"],
2609 }
2610 cc_library {
2611 name: "libfoo",
2612 proprietary: true,
2613 }
2614 `)
2615
2616 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2617 "bin/mybin",
2618 "lib64/libfoo.so",
2619 // TODO(b/159195575): Add an option to use VNDK libs from VNDK APEX
2620 "lib64/libc++.so",
2621 })
2622
2623 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07002624 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Han85d61762020-06-24 23:50:26 +09002625 name := apexBundle.BaseModuleName()
2626 prefix := "TARGET_"
2627 var builder strings.Builder
2628 data.Custom(&builder, name, prefix, "", data)
Paul Duffin37ba3442021-03-29 00:21:08 +01002629 androidMk := android.StringRelativeToTop(ctx.Config(), builder.String())
2630 installPath := "out/target/product/test_device/vendor/apex"
Lukacs T. Berki7690c092021-02-26 14:27:36 +01002631 ensureContains(t, androidMk, "LOCAL_MODULE_PATH := "+installPath)
Jooyung Han6c4cc9c2020-07-29 16:00:54 +09002632
2633 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
2634 requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
2635 ensureListNotContains(t, requireNativeLibs, ":vndk")
Jooyung Han85d61762020-06-24 23:50:26 +09002636}
2637
Jooyung Handf78e212020-07-22 15:54:47 +09002638func TestVendorApex_use_vndk_as_stable(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002639 ctx := testApex(t, `
Jooyung Handf78e212020-07-22 15:54:47 +09002640 apex {
2641 name: "myapex",
2642 key: "myapex.key",
2643 binaries: ["mybin"],
2644 vendor: true,
2645 use_vndk_as_stable: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002646 updatable: false,
Jooyung Handf78e212020-07-22 15:54:47 +09002647 }
2648 apex_key {
2649 name: "myapex.key",
2650 public_key: "testkey.avbpubkey",
2651 private_key: "testkey.pem",
2652 }
2653 cc_binary {
2654 name: "mybin",
2655 vendor: true,
2656 shared_libs: ["libvndk", "libvendor"],
2657 }
2658 cc_library {
2659 name: "libvndk",
2660 vndk: {
2661 enabled: true,
2662 },
2663 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09002664 product_available: true,
Jooyung Handf78e212020-07-22 15:54:47 +09002665 }
2666 cc_library {
2667 name: "libvendor",
2668 vendor: true,
2669 }
2670 `)
2671
Jiyong Parkf58c46e2021-04-01 21:35:20 +09002672 vendorVariant := "android_vendor.29_arm64_armv8-a"
Jooyung Handf78e212020-07-22 15:54:47 +09002673
Paul Duffina71a67a2021-03-29 00:42:57 +01002674 ldRule := ctx.ModuleForTests("mybin", vendorVariant+"_apex10000").Rule("ld")
Jooyung Handf78e212020-07-22 15:54:47 +09002675 libs := names(ldRule.Args["libFlags"])
2676 // VNDK libs(libvndk/libc++) as they are
Paul Duffin37ba3442021-03-29 00:21:08 +01002677 ensureListContains(t, libs, "out/soong/.intermediates/libvndk/"+vendorVariant+"_shared/libvndk.so")
2678 ensureListContains(t, libs, "out/soong/.intermediates/"+cc.DefaultCcCommonTestModulesDir+"libc++/"+vendorVariant+"_shared/libc++.so")
Jooyung Handf78e212020-07-22 15:54:47 +09002679 // non-stable Vendor libs as APEX variants
Paul Duffin37ba3442021-03-29 00:21:08 +01002680 ensureListContains(t, libs, "out/soong/.intermediates/libvendor/"+vendorVariant+"_shared_apex10000/libvendor.so")
Jooyung Handf78e212020-07-22 15:54:47 +09002681
2682 // VNDK libs are not included when use_vndk_as_stable: true
2683 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2684 "bin/mybin",
2685 "lib64/libvendor.so",
2686 })
Jooyung Han6c4cc9c2020-07-29 16:00:54 +09002687
2688 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
2689 requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
2690 ensureListContains(t, requireNativeLibs, ":vndk")
Jooyung Handf78e212020-07-22 15:54:47 +09002691}
2692
Justin Yun13decfb2021-03-08 19:25:55 +09002693func TestProductVariant(t *testing.T) {
2694 ctx := testApex(t, `
2695 apex {
2696 name: "myapex",
2697 key: "myapex.key",
2698 updatable: false,
2699 product_specific: true,
2700 binaries: ["foo"],
2701 }
2702
2703 apex_key {
2704 name: "myapex.key",
2705 public_key: "testkey.avbpubkey",
2706 private_key: "testkey.pem",
2707 }
2708
2709 cc_binary {
2710 name: "foo",
2711 product_available: true,
2712 apex_available: ["myapex"],
2713 srcs: ["foo.cpp"],
2714 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002715 `, android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
2716 variables.ProductVndkVersion = proptools.StringPtr("current")
2717 }),
2718 )
Justin Yun13decfb2021-03-08 19:25:55 +09002719
2720 cflags := strings.Fields(
Jiyong Parkf58c46e2021-04-01 21:35:20 +09002721 ctx.ModuleForTests("foo", "android_product.29_arm64_armv8-a_apex10000").Rule("cc").Args["cFlags"])
Justin Yun13decfb2021-03-08 19:25:55 +09002722 ensureListContains(t, cflags, "-D__ANDROID_VNDK__")
2723 ensureListContains(t, cflags, "-D__ANDROID_APEX__")
2724 ensureListContains(t, cflags, "-D__ANDROID_PRODUCT__")
2725 ensureListNotContains(t, cflags, "-D__ANDROID_VENDOR__")
2726}
2727
Jooyung Han8e5685d2020-09-21 11:02:57 +09002728func TestApex_withPrebuiltFirmware(t *testing.T) {
2729 testCases := []struct {
2730 name string
2731 additionalProp string
2732 }{
2733 {"system apex with prebuilt_firmware", ""},
2734 {"vendor apex with prebuilt_firmware", "vendor: true,"},
2735 }
2736 for _, tc := range testCases {
2737 t.Run(tc.name, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002738 ctx := testApex(t, `
Jooyung Han8e5685d2020-09-21 11:02:57 +09002739 apex {
2740 name: "myapex",
2741 key: "myapex.key",
2742 prebuilts: ["myfirmware"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002743 updatable: false,
Jooyung Han8e5685d2020-09-21 11:02:57 +09002744 `+tc.additionalProp+`
2745 }
2746 apex_key {
2747 name: "myapex.key",
2748 public_key: "testkey.avbpubkey",
2749 private_key: "testkey.pem",
2750 }
2751 prebuilt_firmware {
2752 name: "myfirmware",
2753 src: "myfirmware.bin",
2754 filename_from_src: true,
2755 `+tc.additionalProp+`
2756 }
2757 `)
2758 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2759 "etc/firmware/myfirmware.bin",
2760 })
2761 })
2762 }
Jooyung Han0703fd82020-08-26 22:11:53 +09002763}
2764
Jooyung Hanefb184e2020-06-25 17:14:25 +09002765func TestAndroidMk_UseVendorRequired(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002766 ctx := testApex(t, `
Jooyung Hanefb184e2020-06-25 17:14:25 +09002767 apex {
2768 name: "myapex",
2769 key: "myapex.key",
2770 use_vendor: true,
2771 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002772 updatable: false,
Jooyung Hanefb184e2020-06-25 17:14:25 +09002773 }
2774
2775 apex_key {
2776 name: "myapex.key",
2777 public_key: "testkey.avbpubkey",
2778 private_key: "testkey.pem",
2779 }
2780
2781 cc_library {
2782 name: "mylib",
2783 vendor_available: true,
2784 apex_available: ["myapex"],
2785 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002786 `,
2787 setUseVendorAllowListForTest([]string{"myapex"}),
2788 )
Jooyung Hanefb184e2020-06-25 17:14:25 +09002789
2790 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07002791 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Hanefb184e2020-06-25 17:14:25 +09002792 name := apexBundle.BaseModuleName()
2793 prefix := "TARGET_"
2794 var builder strings.Builder
2795 data.Custom(&builder, name, prefix, "", data)
2796 androidMk := builder.String()
2797 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += libc libm libdl\n")
2798}
2799
2800func TestAndroidMk_VendorApexRequired(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002801 ctx := testApex(t, `
Jooyung Hanefb184e2020-06-25 17:14:25 +09002802 apex {
2803 name: "myapex",
2804 key: "myapex.key",
2805 vendor: true,
2806 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002807 updatable: false,
Jooyung Hanefb184e2020-06-25 17:14:25 +09002808 }
2809
2810 apex_key {
2811 name: "myapex.key",
2812 public_key: "testkey.avbpubkey",
2813 private_key: "testkey.pem",
2814 }
2815
2816 cc_library {
2817 name: "mylib",
2818 vendor_available: true,
2819 }
2820 `)
2821
2822 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07002823 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Hanefb184e2020-06-25 17:14:25 +09002824 name := apexBundle.BaseModuleName()
2825 prefix := "TARGET_"
2826 var builder strings.Builder
2827 data.Custom(&builder, name, prefix, "", data)
2828 androidMk := builder.String()
2829 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += libc.vendor libm.vendor libdl.vendor\n")
2830}
2831
Jooyung Han2ed99d02020-06-24 23:26:26 +09002832func TestAndroidMkWritesCommonProperties(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002833 ctx := testApex(t, `
Jooyung Han2ed99d02020-06-24 23:26:26 +09002834 apex {
2835 name: "myapex",
2836 key: "myapex.key",
2837 vintf_fragments: ["fragment.xml"],
2838 init_rc: ["init.rc"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002839 updatable: false,
Jooyung Han2ed99d02020-06-24 23:26:26 +09002840 }
2841 apex_key {
2842 name: "myapex.key",
2843 public_key: "testkey.avbpubkey",
2844 private_key: "testkey.pem",
2845 }
2846 cc_binary {
2847 name: "mybin",
2848 }
2849 `)
2850
2851 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07002852 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Han2ed99d02020-06-24 23:26:26 +09002853 name := apexBundle.BaseModuleName()
2854 prefix := "TARGET_"
2855 var builder strings.Builder
2856 data.Custom(&builder, name, prefix, "", data)
2857 androidMk := builder.String()
Liz Kammer7b3dc8a2021-04-16 16:41:59 -04002858 ensureContains(t, androidMk, "LOCAL_FULL_VINTF_FRAGMENTS := fragment.xml\n")
Liz Kammer0c4f71c2021-04-06 10:35:10 -04002859 ensureContains(t, androidMk, "LOCAL_FULL_INIT_RC := init.rc\n")
Jooyung Han2ed99d02020-06-24 23:26:26 +09002860}
2861
Jiyong Park16e91a02018-12-20 18:18:08 +09002862func TestStaticLinking(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002863 ctx := testApex(t, `
Jiyong Park16e91a02018-12-20 18:18:08 +09002864 apex {
2865 name: "myapex",
2866 key: "myapex.key",
2867 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002868 updatable: false,
Jiyong Park16e91a02018-12-20 18:18:08 +09002869 }
2870
2871 apex_key {
2872 name: "myapex.key",
2873 public_key: "testkey.avbpubkey",
2874 private_key: "testkey.pem",
2875 }
2876
2877 cc_library {
2878 name: "mylib",
2879 srcs: ["mylib.cpp"],
2880 system_shared_libs: [],
2881 stl: "none",
2882 stubs: {
2883 versions: ["1", "2", "3"],
2884 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002885 apex_available: [
2886 "//apex_available:platform",
2887 "myapex",
2888 ],
Jiyong Park16e91a02018-12-20 18:18:08 +09002889 }
2890
2891 cc_binary {
2892 name: "not_in_apex",
2893 srcs: ["mylib.cpp"],
2894 static_libs: ["mylib"],
2895 static_executable: true,
2896 system_shared_libs: [],
2897 stl: "none",
2898 }
Jiyong Park16e91a02018-12-20 18:18:08 +09002899 `)
2900
Colin Cross7113d202019-11-20 16:39:12 -08002901 ldFlags := ctx.ModuleForTests("not_in_apex", "android_arm64_armv8-a").Rule("ld").Args["libFlags"]
Jiyong Park16e91a02018-12-20 18:18:08 +09002902
2903 // Ensure that not_in_apex is linking with the static variant of mylib
Colin Cross7113d202019-11-20 16:39:12 -08002904 ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_static/mylib.a")
Jiyong Park16e91a02018-12-20 18:18:08 +09002905}
Jiyong Park9335a262018-12-24 11:31:58 +09002906
2907func TestKeys(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002908 ctx := testApex(t, `
Jiyong Park9335a262018-12-24 11:31:58 +09002909 apex {
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002910 name: "myapex_keytest",
Jiyong Park9335a262018-12-24 11:31:58 +09002911 key: "myapex.key",
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002912 certificate: ":myapex.certificate",
Jiyong Park9335a262018-12-24 11:31:58 +09002913 native_shared_libs: ["mylib"],
Jooyung Han54aca7b2019-11-20 02:26:02 +09002914 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002915 updatable: false,
Jiyong Park9335a262018-12-24 11:31:58 +09002916 }
2917
2918 cc_library {
2919 name: "mylib",
2920 srcs: ["mylib.cpp"],
2921 system_shared_libs: [],
2922 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002923 apex_available: [ "myapex_keytest" ],
Jiyong Park9335a262018-12-24 11:31:58 +09002924 }
2925
2926 apex_key {
2927 name: "myapex.key",
2928 public_key: "testkey.avbpubkey",
2929 private_key: "testkey.pem",
2930 }
2931
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002932 android_app_certificate {
2933 name: "myapex.certificate",
2934 certificate: "testkey",
2935 }
2936
2937 android_app_certificate {
2938 name: "myapex.certificate.override",
2939 certificate: "testkey.override",
2940 }
2941
Jiyong Park9335a262018-12-24 11:31:58 +09002942 `)
2943
2944 // check the APEX keys
Jiyong Parkd1e293d2019-03-15 02:13:21 +09002945 keys := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
Jiyong Park9335a262018-12-24 11:31:58 +09002946
Jaewoong Jung18aefc12020-12-21 09:11:10 -08002947 if keys.publicKeyFile.String() != "vendor/foo/devkeys/testkey.avbpubkey" {
2948 t.Errorf("public key %q is not %q", keys.publicKeyFile.String(),
Jiyong Park9335a262018-12-24 11:31:58 +09002949 "vendor/foo/devkeys/testkey.avbpubkey")
2950 }
Jaewoong Jung18aefc12020-12-21 09:11:10 -08002951 if keys.privateKeyFile.String() != "vendor/foo/devkeys/testkey.pem" {
2952 t.Errorf("private key %q is not %q", keys.privateKeyFile.String(),
Jiyong Park9335a262018-12-24 11:31:58 +09002953 "vendor/foo/devkeys/testkey.pem")
2954 }
2955
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002956 // check the APK certs. It should be overridden to myapex.certificate.override
Sundong Ahnabb64432019-10-22 13:58:29 +09002957 certs := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk").Args["certificates"]
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002958 if certs != "testkey.override.x509.pem testkey.override.pk8" {
Jiyong Park9335a262018-12-24 11:31:58 +09002959 t.Errorf("cert and private key %q are not %q", certs,
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002960 "testkey.override.509.pem testkey.override.pk8")
Jiyong Park9335a262018-12-24 11:31:58 +09002961 }
2962}
Jiyong Park58e364a2019-01-19 19:24:06 +09002963
Jooyung Hanf121a652019-12-17 14:30:11 +09002964func TestCertificate(t *testing.T) {
2965 t.Run("if unspecified, it defaults to DefaultAppCertificate", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002966 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09002967 apex {
2968 name: "myapex",
2969 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002970 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09002971 }
2972 apex_key {
2973 name: "myapex.key",
2974 public_key: "testkey.avbpubkey",
2975 private_key: "testkey.pem",
2976 }`)
2977 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
2978 expected := "vendor/foo/devkeys/test.x509.pem vendor/foo/devkeys/test.pk8"
2979 if actual := rule.Args["certificates"]; actual != expected {
2980 t.Errorf("certificates should be %q, not %q", expected, actual)
2981 }
2982 })
2983 t.Run("override when unspecified", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002984 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09002985 apex {
2986 name: "myapex_keytest",
2987 key: "myapex.key",
2988 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002989 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09002990 }
2991 apex_key {
2992 name: "myapex.key",
2993 public_key: "testkey.avbpubkey",
2994 private_key: "testkey.pem",
2995 }
2996 android_app_certificate {
2997 name: "myapex.certificate.override",
2998 certificate: "testkey.override",
2999 }`)
3000 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
3001 expected := "testkey.override.x509.pem testkey.override.pk8"
3002 if actual := rule.Args["certificates"]; actual != expected {
3003 t.Errorf("certificates should be %q, not %q", expected, actual)
3004 }
3005 })
3006 t.Run("if specified as :module, it respects the prop", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003007 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003008 apex {
3009 name: "myapex",
3010 key: "myapex.key",
3011 certificate: ":myapex.certificate",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003012 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003013 }
3014 apex_key {
3015 name: "myapex.key",
3016 public_key: "testkey.avbpubkey",
3017 private_key: "testkey.pem",
3018 }
3019 android_app_certificate {
3020 name: "myapex.certificate",
3021 certificate: "testkey",
3022 }`)
3023 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
3024 expected := "testkey.x509.pem testkey.pk8"
3025 if actual := rule.Args["certificates"]; actual != expected {
3026 t.Errorf("certificates should be %q, not %q", expected, actual)
3027 }
3028 })
3029 t.Run("override when specifiec as <:module>", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003030 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003031 apex {
3032 name: "myapex_keytest",
3033 key: "myapex.key",
3034 file_contexts: ":myapex-file_contexts",
3035 certificate: ":myapex.certificate",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003036 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003037 }
3038 apex_key {
3039 name: "myapex.key",
3040 public_key: "testkey.avbpubkey",
3041 private_key: "testkey.pem",
3042 }
3043 android_app_certificate {
3044 name: "myapex.certificate.override",
3045 certificate: "testkey.override",
3046 }`)
3047 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
3048 expected := "testkey.override.x509.pem testkey.override.pk8"
3049 if actual := rule.Args["certificates"]; actual != expected {
3050 t.Errorf("certificates should be %q, not %q", expected, actual)
3051 }
3052 })
3053 t.Run("if specified as name, finds it from DefaultDevKeyDir", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003054 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003055 apex {
3056 name: "myapex",
3057 key: "myapex.key",
3058 certificate: "testkey",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003059 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003060 }
3061 apex_key {
3062 name: "myapex.key",
3063 public_key: "testkey.avbpubkey",
3064 private_key: "testkey.pem",
3065 }`)
3066 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
3067 expected := "vendor/foo/devkeys/testkey.x509.pem vendor/foo/devkeys/testkey.pk8"
3068 if actual := rule.Args["certificates"]; actual != expected {
3069 t.Errorf("certificates should be %q, not %q", expected, actual)
3070 }
3071 })
3072 t.Run("override when specified as <name>", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003073 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003074 apex {
3075 name: "myapex_keytest",
3076 key: "myapex.key",
3077 file_contexts: ":myapex-file_contexts",
3078 certificate: "testkey",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003079 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003080 }
3081 apex_key {
3082 name: "myapex.key",
3083 public_key: "testkey.avbpubkey",
3084 private_key: "testkey.pem",
3085 }
3086 android_app_certificate {
3087 name: "myapex.certificate.override",
3088 certificate: "testkey.override",
3089 }`)
3090 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
3091 expected := "testkey.override.x509.pem testkey.override.pk8"
3092 if actual := rule.Args["certificates"]; actual != expected {
3093 t.Errorf("certificates should be %q, not %q", expected, actual)
3094 }
3095 })
3096}
3097
Jiyong Park58e364a2019-01-19 19:24:06 +09003098func TestMacro(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003099 ctx := testApex(t, `
Jiyong Park58e364a2019-01-19 19:24:06 +09003100 apex {
3101 name: "myapex",
3102 key: "myapex.key",
Jooyung Hanc87a0592020-03-02 17:44:33 +09003103 native_shared_libs: ["mylib", "mylib2"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003104 updatable: false,
Jiyong Park58e364a2019-01-19 19:24:06 +09003105 }
3106
3107 apex {
3108 name: "otherapex",
3109 key: "myapex.key",
Jooyung Hanc87a0592020-03-02 17:44:33 +09003110 native_shared_libs: ["mylib", "mylib2"],
Jooyung Hanccce2f22020-03-07 03:45:53 +09003111 min_sdk_version: "29",
Jiyong Park58e364a2019-01-19 19:24:06 +09003112 }
3113
3114 apex_key {
3115 name: "myapex.key",
3116 public_key: "testkey.avbpubkey",
3117 private_key: "testkey.pem",
3118 }
3119
3120 cc_library {
3121 name: "mylib",
3122 srcs: ["mylib.cpp"],
3123 system_shared_libs: [],
3124 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003125 apex_available: [
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003126 "myapex",
3127 "otherapex",
3128 ],
Jooyung Han24282772020-03-21 23:20:55 +09003129 recovery_available: true,
Jooyung Han749dc692020-04-15 11:03:39 +09003130 min_sdk_version: "29",
Jiyong Park58e364a2019-01-19 19:24:06 +09003131 }
Jooyung Hanc87a0592020-03-02 17:44:33 +09003132 cc_library {
3133 name: "mylib2",
3134 srcs: ["mylib.cpp"],
3135 system_shared_libs: [],
3136 stl: "none",
3137 apex_available: [
3138 "myapex",
3139 "otherapex",
3140 ],
Colin Crossaede88c2020-08-11 12:17:01 -07003141 static_libs: ["mylib3"],
3142 recovery_available: true,
3143 min_sdk_version: "29",
3144 }
3145 cc_library {
3146 name: "mylib3",
3147 srcs: ["mylib.cpp"],
3148 system_shared_libs: [],
3149 stl: "none",
3150 apex_available: [
3151 "myapex",
3152 "otherapex",
3153 ],
Jooyung Hanc87a0592020-03-02 17:44:33 +09003154 use_apex_name_macro: true,
Colin Crossaede88c2020-08-11 12:17:01 -07003155 recovery_available: true,
Jooyung Han749dc692020-04-15 11:03:39 +09003156 min_sdk_version: "29",
Jooyung Hanc87a0592020-03-02 17:44:33 +09003157 }
Jiyong Park58e364a2019-01-19 19:24:06 +09003158 `)
3159
Jooyung Hanc87a0592020-03-02 17:44:33 +09003160 // non-APEX variant does not have __ANDROID_APEX__ defined
Colin Cross7113d202019-11-20 16:39:12 -08003161 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09003162 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003163 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
Jooyung Hanc87a0592020-03-02 17:44:33 +09003164
Jooyung Hanccce2f22020-03-07 03:45:53 +09003165 // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
Colin Crossaede88c2020-08-11 12:17:01 -07003166 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
Jooyung Hanc87a0592020-03-02 17:44:33 +09003167 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003168 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=10000")
Jooyung Han77988572019-10-18 16:26:16 +09003169 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
Jooyung Hanc87a0592020-03-02 17:44:33 +09003170
Jooyung Hanccce2f22020-03-07 03:45:53 +09003171 // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
Colin Crossaede88c2020-08-11 12:17:01 -07003172 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex29").Rule("cc").Args["cFlags"]
Jooyung Hanc87a0592020-03-02 17:44:33 +09003173 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003174 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=29")
Jooyung Han77988572019-10-18 16:26:16 +09003175 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09003176
Colin Crossaede88c2020-08-11 12:17:01 -07003177 // When a cc_library sets use_apex_name_macro: true each apex gets a unique variant and
3178 // each variant defines additional macros to distinguish which apex variant it is built for
3179
3180 // non-APEX variant does not have __ANDROID_APEX__ defined
3181 mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
3182 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3183
3184 // APEX variant has __ANDROID_APEX__ defined
3185 mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"]
3186 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3187 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
3188 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
3189
3190 // APEX variant has __ANDROID_APEX__ defined
3191 mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static_otherapex").Rule("cc").Args["cFlags"]
3192 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3193 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
3194 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
3195
Dan Albertb19953d2020-11-17 15:29:36 -08003196 // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__
Colin Crossaede88c2020-08-11 12:17:01 -07003197 mylibCFlags = ctx.ModuleForTests("mylib3", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
3198 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003199 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
Colin Crossaede88c2020-08-11 12:17:01 -07003200
3201 // When a dependency of a cc_library sets use_apex_name_macro: true each apex gets a unique
3202 // variant.
Jooyung Hanc87a0592020-03-02 17:44:33 +09003203
3204 // non-APEX variant does not have __ANDROID_APEX__ defined
3205 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
3206 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3207
3208 // APEX variant has __ANDROID_APEX__ defined
3209 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09003210 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Colin Crossaede88c2020-08-11 12:17:01 -07003211 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
Jooyung Han77988572019-10-18 16:26:16 +09003212 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09003213
Jooyung Hanc87a0592020-03-02 17:44:33 +09003214 // APEX variant has __ANDROID_APEX__ defined
3215 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_otherapex").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09003216 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Han77988572019-10-18 16:26:16 +09003217 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
Colin Crossaede88c2020-08-11 12:17:01 -07003218 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jooyung Han24282772020-03-21 23:20:55 +09003219
Dan Albertb19953d2020-11-17 15:29:36 -08003220 // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__
Colin Crossaede88c2020-08-11 12:17:01 -07003221 mylibCFlags = ctx.ModuleForTests("mylib2", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jooyung Han24282772020-03-21 23:20:55 +09003222 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003223 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
Jiyong Park58e364a2019-01-19 19:24:06 +09003224}
Jiyong Park7e636d02019-01-28 16:16:54 +09003225
3226func TestHeaderLibsDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003227 ctx := testApex(t, `
Jiyong Park7e636d02019-01-28 16:16:54 +09003228 apex {
3229 name: "myapex",
3230 key: "myapex.key",
3231 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003232 updatable: false,
Jiyong Park7e636d02019-01-28 16:16:54 +09003233 }
3234
3235 apex_key {
3236 name: "myapex.key",
3237 public_key: "testkey.avbpubkey",
3238 private_key: "testkey.pem",
3239 }
3240
3241 cc_library_headers {
3242 name: "mylib_headers",
3243 export_include_dirs: ["my_include"],
3244 system_shared_libs: [],
3245 stl: "none",
Jiyong Park0f80c182020-01-31 02:49:53 +09003246 apex_available: [ "myapex" ],
Jiyong Park7e636d02019-01-28 16:16:54 +09003247 }
3248
3249 cc_library {
3250 name: "mylib",
3251 srcs: ["mylib.cpp"],
3252 system_shared_libs: [],
3253 stl: "none",
3254 header_libs: ["mylib_headers"],
3255 export_header_lib_headers: ["mylib_headers"],
3256 stubs: {
3257 versions: ["1", "2", "3"],
3258 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003259 apex_available: [ "myapex" ],
Jiyong Park7e636d02019-01-28 16:16:54 +09003260 }
3261
3262 cc_library {
3263 name: "otherlib",
3264 srcs: ["mylib.cpp"],
3265 system_shared_libs: [],
3266 stl: "none",
3267 shared_libs: ["mylib"],
3268 }
3269 `)
3270
Colin Cross7113d202019-11-20 16:39:12 -08003271 cFlags := ctx.ModuleForTests("otherlib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jiyong Park7e636d02019-01-28 16:16:54 +09003272
3273 // Ensure that the include path of the header lib is exported to 'otherlib'
3274 ensureContains(t, cFlags, "-Imy_include")
3275}
Alex Light9670d332019-01-29 18:07:33 -08003276
Jiyong Park7cd10e32020-01-14 09:22:18 +09003277type fileInApex struct {
3278 path string // path in apex
Jooyung Hana57af4a2020-01-23 05:36:59 +00003279 src string // src path
Jiyong Park7cd10e32020-01-14 09:22:18 +09003280 isLink bool
3281}
3282
Jooyung Hana57af4a2020-01-23 05:36:59 +00003283func getFiles(t *testing.T, ctx *android.TestContext, moduleName, variant string) []fileInApex {
Jooyung Han31c470b2019-10-18 16:26:59 +09003284 t.Helper()
Jooyung Hana57af4a2020-01-23 05:36:59 +00003285 apexRule := ctx.ModuleForTests(moduleName, variant).Rule("apexRule")
Jooyung Han31c470b2019-10-18 16:26:59 +09003286 copyCmds := apexRule.Args["copy_commands"]
3287 imageApexDir := "/image.apex/"
Jiyong Park7cd10e32020-01-14 09:22:18 +09003288 var ret []fileInApex
Jooyung Han31c470b2019-10-18 16:26:59 +09003289 for _, cmd := range strings.Split(copyCmds, "&&") {
3290 cmd = strings.TrimSpace(cmd)
3291 if cmd == "" {
3292 continue
3293 }
3294 terms := strings.Split(cmd, " ")
Jooyung Hana57af4a2020-01-23 05:36:59 +00003295 var dst, src string
Jiyong Park7cd10e32020-01-14 09:22:18 +09003296 var isLink bool
Jooyung Han31c470b2019-10-18 16:26:59 +09003297 switch terms[0] {
3298 case "mkdir":
3299 case "cp":
Jiyong Park7cd10e32020-01-14 09:22:18 +09003300 if len(terms) != 3 && len(terms) != 4 {
Jooyung Han31c470b2019-10-18 16:26:59 +09003301 t.Fatal("copyCmds contains invalid cp command", cmd)
3302 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09003303 dst = terms[len(terms)-1]
Jooyung Hana57af4a2020-01-23 05:36:59 +00003304 src = terms[len(terms)-2]
Jiyong Park7cd10e32020-01-14 09:22:18 +09003305 isLink = false
3306 case "ln":
3307 if len(terms) != 3 && len(terms) != 4 {
3308 // ln LINK TARGET or ln -s LINK TARGET
3309 t.Fatal("copyCmds contains invalid ln command", cmd)
3310 }
3311 dst = terms[len(terms)-1]
Jooyung Hana57af4a2020-01-23 05:36:59 +00003312 src = terms[len(terms)-2]
Jiyong Park7cd10e32020-01-14 09:22:18 +09003313 isLink = true
3314 default:
3315 t.Fatalf("copyCmds should contain mkdir/cp commands only: %q", cmd)
3316 }
3317 if dst != "" {
Jooyung Han31c470b2019-10-18 16:26:59 +09003318 index := strings.Index(dst, imageApexDir)
3319 if index == -1 {
3320 t.Fatal("copyCmds should copy a file to image.apex/", cmd)
3321 }
3322 dstFile := dst[index+len(imageApexDir):]
Jooyung Hana57af4a2020-01-23 05:36:59 +00003323 ret = append(ret, fileInApex{path: dstFile, src: src, isLink: isLink})
Jooyung Han31c470b2019-10-18 16:26:59 +09003324 }
3325 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09003326 return ret
3327}
3328
Jooyung Hana57af4a2020-01-23 05:36:59 +00003329func ensureExactContents(t *testing.T, ctx *android.TestContext, moduleName, variant string, files []string) {
3330 t.Helper()
Jiyong Park7cd10e32020-01-14 09:22:18 +09003331 var failed bool
3332 var surplus []string
3333 filesMatched := make(map[string]bool)
Jooyung Hana57af4a2020-01-23 05:36:59 +00003334 for _, file := range getFiles(t, ctx, moduleName, variant) {
Jooyung Hane6436d72020-02-27 13:31:56 +09003335 mactchFound := false
Jiyong Park7cd10e32020-01-14 09:22:18 +09003336 for _, expected := range files {
3337 if matched, _ := path.Match(expected, file.path); matched {
3338 filesMatched[expected] = true
Jooyung Hane6436d72020-02-27 13:31:56 +09003339 mactchFound = true
3340 break
Jiyong Park7cd10e32020-01-14 09:22:18 +09003341 }
3342 }
Jooyung Hane6436d72020-02-27 13:31:56 +09003343 if !mactchFound {
3344 surplus = append(surplus, file.path)
3345 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09003346 }
Jooyung Han31c470b2019-10-18 16:26:59 +09003347
Jooyung Han31c470b2019-10-18 16:26:59 +09003348 if len(surplus) > 0 {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003349 sort.Strings(surplus)
Jooyung Han31c470b2019-10-18 16:26:59 +09003350 t.Log("surplus files", surplus)
3351 failed = true
3352 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003353
3354 if len(files) > len(filesMatched) {
3355 var missing []string
3356 for _, expected := range files {
3357 if !filesMatched[expected] {
3358 missing = append(missing, expected)
3359 }
3360 }
3361 sort.Strings(missing)
Jooyung Han31c470b2019-10-18 16:26:59 +09003362 t.Log("missing files", missing)
3363 failed = true
3364 }
3365 if failed {
3366 t.Fail()
3367 }
3368}
3369
Jooyung Han344d5432019-08-23 11:17:39 +09003370func TestVndkApexCurrent(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003371 ctx := testApex(t, `
Jooyung Han344d5432019-08-23 11:17:39 +09003372 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003373 name: "com.android.vndk.current",
3374 key: "com.android.vndk.current.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003375 updatable: false,
Jooyung Han344d5432019-08-23 11:17:39 +09003376 }
3377
3378 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003379 name: "com.android.vndk.current.key",
Jooyung Han344d5432019-08-23 11:17:39 +09003380 public_key: "testkey.avbpubkey",
3381 private_key: "testkey.pem",
3382 }
3383
3384 cc_library {
3385 name: "libvndk",
3386 srcs: ["mylib.cpp"],
3387 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003388 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003389 vndk: {
3390 enabled: true,
3391 },
3392 system_shared_libs: [],
3393 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003394 apex_available: [ "com.android.vndk.current" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003395 }
3396
3397 cc_library {
3398 name: "libvndksp",
3399 srcs: ["mylib.cpp"],
3400 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003401 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003402 vndk: {
3403 enabled: true,
3404 support_system_process: true,
3405 },
3406 system_shared_libs: [],
3407 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003408 apex_available: [ "com.android.vndk.current" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003409 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003410 `+vndkLibrariesTxtFiles("current"))
Jooyung Han344d5432019-08-23 11:17:39 +09003411
Colin Cross2807f002021-03-02 10:15:29 -08003412 ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003413 "lib/libvndk.so",
3414 "lib/libvndksp.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09003415 "lib/libc++.so",
Jooyung Han31c470b2019-10-18 16:26:59 +09003416 "lib64/libvndk.so",
3417 "lib64/libvndksp.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09003418 "lib64/libc++.so",
Jiyong Parkf58c46e2021-04-01 21:35:20 +09003419 "etc/llndk.libraries.29.txt",
3420 "etc/vndkcore.libraries.29.txt",
3421 "etc/vndksp.libraries.29.txt",
3422 "etc/vndkprivate.libraries.29.txt",
3423 "etc/vndkproduct.libraries.29.txt",
Jooyung Han31c470b2019-10-18 16:26:59 +09003424 })
Jooyung Han344d5432019-08-23 11:17:39 +09003425}
3426
3427func TestVndkApexWithPrebuilt(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003428 ctx := testApex(t, `
Jooyung Han344d5432019-08-23 11:17:39 +09003429 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003430 name: "com.android.vndk.current",
3431 key: "com.android.vndk.current.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003432 updatable: false,
Jooyung Han344d5432019-08-23 11:17:39 +09003433 }
3434
3435 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003436 name: "com.android.vndk.current.key",
Jooyung Han344d5432019-08-23 11:17:39 +09003437 public_key: "testkey.avbpubkey",
3438 private_key: "testkey.pem",
3439 }
3440
3441 cc_prebuilt_library_shared {
Jooyung Han31c470b2019-10-18 16:26:59 +09003442 name: "libvndk",
3443 srcs: ["libvndk.so"],
Jooyung Han344d5432019-08-23 11:17:39 +09003444 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003445 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003446 vndk: {
3447 enabled: true,
3448 },
3449 system_shared_libs: [],
3450 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003451 apex_available: [ "com.android.vndk.current" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003452 }
Jooyung Han31c470b2019-10-18 16:26:59 +09003453
3454 cc_prebuilt_library_shared {
3455 name: "libvndk.arm",
3456 srcs: ["libvndk.arm.so"],
3457 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003458 product_available: true,
Jooyung Han31c470b2019-10-18 16:26:59 +09003459 vndk: {
3460 enabled: true,
3461 },
3462 enabled: false,
3463 arch: {
3464 arm: {
3465 enabled: true,
3466 },
3467 },
3468 system_shared_libs: [],
3469 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003470 apex_available: [ "com.android.vndk.current" ],
Jooyung Han31c470b2019-10-18 16:26:59 +09003471 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003472 `+vndkLibrariesTxtFiles("current"),
3473 withFiles(map[string][]byte{
3474 "libvndk.so": nil,
3475 "libvndk.arm.so": nil,
3476 }))
Colin Cross2807f002021-03-02 10:15:29 -08003477 ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003478 "lib/libvndk.so",
3479 "lib/libvndk.arm.so",
3480 "lib64/libvndk.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09003481 "lib/libc++.so",
3482 "lib64/libc++.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003483 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003484 })
Jooyung Han344d5432019-08-23 11:17:39 +09003485}
3486
Jooyung Han39edb6c2019-11-06 16:53:07 +09003487func vndkLibrariesTxtFiles(vers ...string) (result string) {
3488 for _, v := range vers {
3489 if v == "current" {
Justin Yun8a2600c2020-12-07 12:44:03 +09003490 for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003491 result += `
Colin Crosse4e44bc2020-12-28 13:50:21 -08003492 ` + txt + `_libraries_txt {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003493 name: "` + txt + `.libraries.txt",
3494 }
3495 `
3496 }
3497 } else {
Justin Yun8a2600c2020-12-07 12:44:03 +09003498 for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003499 result += `
3500 prebuilt_etc {
3501 name: "` + txt + `.libraries.` + v + `.txt",
3502 src: "dummy.txt",
3503 }
3504 `
3505 }
3506 }
3507 }
3508 return
3509}
3510
Jooyung Han344d5432019-08-23 11:17:39 +09003511func TestVndkApexVersion(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003512 ctx := testApex(t, `
Jooyung Han344d5432019-08-23 11:17:39 +09003513 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003514 name: "com.android.vndk.v27",
Jooyung Han344d5432019-08-23 11:17:39 +09003515 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003516 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09003517 vndk_version: "27",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003518 updatable: false,
Jooyung Han344d5432019-08-23 11:17:39 +09003519 }
3520
3521 apex_key {
3522 name: "myapex.key",
3523 public_key: "testkey.avbpubkey",
3524 private_key: "testkey.pem",
3525 }
3526
Jooyung Han31c470b2019-10-18 16:26:59 +09003527 vndk_prebuilt_shared {
3528 name: "libvndk27",
3529 version: "27",
Jooyung Han344d5432019-08-23 11:17:39 +09003530 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003531 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003532 vndk: {
3533 enabled: true,
3534 },
Jooyung Han31c470b2019-10-18 16:26:59 +09003535 target_arch: "arm64",
3536 arch: {
3537 arm: {
3538 srcs: ["libvndk27_arm.so"],
3539 },
3540 arm64: {
3541 srcs: ["libvndk27_arm64.so"],
3542 },
3543 },
Colin Cross2807f002021-03-02 10:15:29 -08003544 apex_available: [ "com.android.vndk.v27" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003545 }
3546
3547 vndk_prebuilt_shared {
3548 name: "libvndk27",
3549 version: "27",
3550 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003551 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003552 vndk: {
3553 enabled: true,
3554 },
Jooyung Han31c470b2019-10-18 16:26:59 +09003555 target_arch: "x86_64",
3556 arch: {
3557 x86: {
3558 srcs: ["libvndk27_x86.so"],
3559 },
3560 x86_64: {
3561 srcs: ["libvndk27_x86_64.so"],
3562 },
3563 },
Jooyung Han39edb6c2019-11-06 16:53:07 +09003564 }
3565 `+vndkLibrariesTxtFiles("27"),
3566 withFiles(map[string][]byte{
3567 "libvndk27_arm.so": nil,
3568 "libvndk27_arm64.so": nil,
3569 "libvndk27_x86.so": nil,
3570 "libvndk27_x86_64.so": nil,
3571 }))
Jooyung Han344d5432019-08-23 11:17:39 +09003572
Colin Cross2807f002021-03-02 10:15:29 -08003573 ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003574 "lib/libvndk27_arm.so",
3575 "lib64/libvndk27_arm64.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003576 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003577 })
Jooyung Han344d5432019-08-23 11:17:39 +09003578}
3579
Jooyung Han90eee022019-10-01 20:02:42 +09003580func TestVndkApexNameRule(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003581 ctx := testApex(t, `
Jooyung Han90eee022019-10-01 20:02:42 +09003582 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003583 name: "com.android.vndk.current",
Jooyung Han90eee022019-10-01 20:02:42 +09003584 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003585 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003586 updatable: false,
Jooyung Han90eee022019-10-01 20:02:42 +09003587 }
3588 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003589 name: "com.android.vndk.v28",
Jooyung Han90eee022019-10-01 20:02:42 +09003590 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003591 file_contexts: ":myapex-file_contexts",
Jooyung Han90eee022019-10-01 20:02:42 +09003592 vndk_version: "28",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003593 updatable: false,
Jooyung Han90eee022019-10-01 20:02:42 +09003594 }
3595 apex_key {
3596 name: "myapex.key",
3597 public_key: "testkey.avbpubkey",
3598 private_key: "testkey.pem",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003599 }`+vndkLibrariesTxtFiles("28", "current"))
Jooyung Han90eee022019-10-01 20:02:42 +09003600
3601 assertApexName := func(expected, moduleName string) {
Jooyung Hana57af4a2020-01-23 05:36:59 +00003602 bundle := ctx.ModuleForTests(moduleName, "android_common_image").Module().(*apexBundle)
Jooyung Han90eee022019-10-01 20:02:42 +09003603 actual := proptools.String(bundle.properties.Apex_name)
3604 if !reflect.DeepEqual(actual, expected) {
3605 t.Errorf("Got '%v', expected '%v'", actual, expected)
3606 }
3607 }
3608
Jiyong Parkf58c46e2021-04-01 21:35:20 +09003609 assertApexName("com.android.vndk.v29", "com.android.vndk.current")
Colin Cross2807f002021-03-02 10:15:29 -08003610 assertApexName("com.android.vndk.v28", "com.android.vndk.v28")
Jooyung Han90eee022019-10-01 20:02:42 +09003611}
3612
Jooyung Han344d5432019-08-23 11:17:39 +09003613func TestVndkApexSkipsNativeBridgeSupportedModules(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003614 ctx := testApex(t, `
Jooyung Han344d5432019-08-23 11:17:39 +09003615 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003616 name: "com.android.vndk.current",
3617 key: "com.android.vndk.current.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003618 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003619 updatable: false,
Jooyung Han344d5432019-08-23 11:17:39 +09003620 }
3621
3622 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003623 name: "com.android.vndk.current.key",
Jooyung Han344d5432019-08-23 11:17:39 +09003624 public_key: "testkey.avbpubkey",
3625 private_key: "testkey.pem",
3626 }
3627
3628 cc_library {
3629 name: "libvndk",
3630 srcs: ["mylib.cpp"],
3631 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003632 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003633 native_bridge_supported: true,
3634 host_supported: true,
3635 vndk: {
3636 enabled: true,
3637 },
3638 system_shared_libs: [],
3639 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003640 apex_available: [ "com.android.vndk.current" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003641 }
Colin Cross2807f002021-03-02 10:15:29 -08003642 `+vndkLibrariesTxtFiles("current"),
3643 withNativeBridgeEnabled)
Jooyung Han344d5432019-08-23 11:17:39 +09003644
Colin Cross2807f002021-03-02 10:15:29 -08003645 ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003646 "lib/libvndk.so",
3647 "lib64/libvndk.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09003648 "lib/libc++.so",
3649 "lib64/libc++.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003650 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003651 })
Jooyung Han344d5432019-08-23 11:17:39 +09003652}
3653
3654func TestVndkApexDoesntSupportNativeBridgeSupported(t *testing.T) {
Colin Cross2807f002021-03-02 10:15:29 -08003655 testApexError(t, `module "com.android.vndk.current" .*: native_bridge_supported: .* doesn't support native bridge binary`, `
Jooyung Han344d5432019-08-23 11:17:39 +09003656 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003657 name: "com.android.vndk.current",
3658 key: "com.android.vndk.current.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003659 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09003660 native_bridge_supported: true,
3661 }
3662
3663 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003664 name: "com.android.vndk.current.key",
Jooyung Han344d5432019-08-23 11:17:39 +09003665 public_key: "testkey.avbpubkey",
3666 private_key: "testkey.pem",
3667 }
3668
3669 cc_library {
3670 name: "libvndk",
3671 srcs: ["mylib.cpp"],
3672 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003673 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003674 native_bridge_supported: true,
3675 host_supported: true,
3676 vndk: {
3677 enabled: true,
3678 },
3679 system_shared_libs: [],
3680 stl: "none",
3681 }
3682 `)
3683}
3684
Jooyung Han31c470b2019-10-18 16:26:59 +09003685func TestVndkApexWithBinder32(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003686 ctx := testApex(t, `
Jooyung Han31c470b2019-10-18 16:26:59 +09003687 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003688 name: "com.android.vndk.v27",
Jooyung Han31c470b2019-10-18 16:26:59 +09003689 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003690 file_contexts: ":myapex-file_contexts",
Jooyung Han31c470b2019-10-18 16:26:59 +09003691 vndk_version: "27",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003692 updatable: false,
Jooyung Han31c470b2019-10-18 16:26:59 +09003693 }
3694
3695 apex_key {
3696 name: "myapex.key",
3697 public_key: "testkey.avbpubkey",
3698 private_key: "testkey.pem",
3699 }
3700
3701 vndk_prebuilt_shared {
3702 name: "libvndk27",
3703 version: "27",
3704 target_arch: "arm",
3705 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003706 product_available: true,
Jooyung Han31c470b2019-10-18 16:26:59 +09003707 vndk: {
3708 enabled: true,
3709 },
3710 arch: {
3711 arm: {
3712 srcs: ["libvndk27.so"],
3713 }
3714 },
3715 }
3716
3717 vndk_prebuilt_shared {
3718 name: "libvndk27",
3719 version: "27",
3720 target_arch: "arm",
3721 binder32bit: true,
3722 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003723 product_available: true,
Jooyung Han31c470b2019-10-18 16:26:59 +09003724 vndk: {
3725 enabled: true,
3726 },
3727 arch: {
3728 arm: {
3729 srcs: ["libvndk27binder32.so"],
3730 }
3731 },
Colin Cross2807f002021-03-02 10:15:29 -08003732 apex_available: [ "com.android.vndk.v27" ],
Jooyung Han31c470b2019-10-18 16:26:59 +09003733 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003734 `+vndkLibrariesTxtFiles("27"),
Jooyung Han31c470b2019-10-18 16:26:59 +09003735 withFiles(map[string][]byte{
3736 "libvndk27.so": nil,
3737 "libvndk27binder32.so": nil,
3738 }),
3739 withBinder32bit,
3740 withTargets(map[android.OsType][]android.Target{
3741 android.Android: []android.Target{
Jooyung Han35155c42020-02-06 17:33:20 +09003742 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
3743 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
Jooyung Han31c470b2019-10-18 16:26:59 +09003744 },
3745 }),
3746 )
3747
Colin Cross2807f002021-03-02 10:15:29 -08003748 ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003749 "lib/libvndk27binder32.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003750 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003751 })
3752}
3753
Jooyung Han45a96772020-06-15 14:59:42 +09003754func TestVndkApexShouldNotProvideNativeLibs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003755 ctx := testApex(t, `
Jooyung Han45a96772020-06-15 14:59:42 +09003756 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003757 name: "com.android.vndk.current",
3758 key: "com.android.vndk.current.key",
Jooyung Han45a96772020-06-15 14:59:42 +09003759 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003760 updatable: false,
Jooyung Han45a96772020-06-15 14:59:42 +09003761 }
3762
3763 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003764 name: "com.android.vndk.current.key",
Jooyung Han45a96772020-06-15 14:59:42 +09003765 public_key: "testkey.avbpubkey",
3766 private_key: "testkey.pem",
3767 }
3768
3769 cc_library {
3770 name: "libz",
3771 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003772 product_available: true,
Jooyung Han45a96772020-06-15 14:59:42 +09003773 vndk: {
3774 enabled: true,
3775 },
3776 stubs: {
3777 symbol_file: "libz.map.txt",
3778 versions: ["30"],
3779 }
3780 }
3781 `+vndkLibrariesTxtFiles("current"), withFiles(map[string][]byte{
3782 "libz.map.txt": nil,
3783 }))
3784
Colin Cross2807f002021-03-02 10:15:29 -08003785 apexManifestRule := ctx.ModuleForTests("com.android.vndk.current", "android_common_image").Rule("apexManifestRule")
Jooyung Han45a96772020-06-15 14:59:42 +09003786 provideNativeLibs := names(apexManifestRule.Args["provideNativeLibs"])
3787 ensureListEmpty(t, provideNativeLibs)
3788}
3789
Jooyung Hane1633032019-08-01 17:41:43 +09003790func TestDependenciesInApexManifest(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003791 ctx := testApex(t, `
Jooyung Hane1633032019-08-01 17:41:43 +09003792 apex {
3793 name: "myapex_nodep",
3794 key: "myapex.key",
3795 native_shared_libs: ["lib_nodep"],
3796 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003797 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003798 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003799 }
3800
3801 apex {
3802 name: "myapex_dep",
3803 key: "myapex.key",
3804 native_shared_libs: ["lib_dep"],
3805 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003806 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003807 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003808 }
3809
3810 apex {
3811 name: "myapex_provider",
3812 key: "myapex.key",
3813 native_shared_libs: ["libfoo"],
3814 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003815 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003816 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003817 }
3818
3819 apex {
3820 name: "myapex_selfcontained",
3821 key: "myapex.key",
3822 native_shared_libs: ["lib_dep", "libfoo"],
3823 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003824 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003825 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003826 }
3827
3828 apex_key {
3829 name: "myapex.key",
3830 public_key: "testkey.avbpubkey",
3831 private_key: "testkey.pem",
3832 }
3833
3834 cc_library {
3835 name: "lib_nodep",
3836 srcs: ["mylib.cpp"],
3837 system_shared_libs: [],
3838 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003839 apex_available: [ "myapex_nodep" ],
Jooyung Hane1633032019-08-01 17:41:43 +09003840 }
3841
3842 cc_library {
3843 name: "lib_dep",
3844 srcs: ["mylib.cpp"],
3845 shared_libs: ["libfoo"],
3846 system_shared_libs: [],
3847 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003848 apex_available: [
3849 "myapex_dep",
3850 "myapex_provider",
3851 "myapex_selfcontained",
3852 ],
Jooyung Hane1633032019-08-01 17:41:43 +09003853 }
3854
3855 cc_library {
3856 name: "libfoo",
3857 srcs: ["mytest.cpp"],
3858 stubs: {
3859 versions: ["1"],
3860 },
3861 system_shared_libs: [],
3862 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003863 apex_available: [
3864 "myapex_provider",
3865 "myapex_selfcontained",
3866 ],
Jooyung Hane1633032019-08-01 17:41:43 +09003867 }
3868 `)
3869
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003870 var apexManifestRule android.TestingBuildParams
Jooyung Hane1633032019-08-01 17:41:43 +09003871 var provideNativeLibs, requireNativeLibs []string
3872
Sundong Ahnabb64432019-10-22 13:58:29 +09003873 apexManifestRule = ctx.ModuleForTests("myapex_nodep", "android_common_myapex_nodep_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003874 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3875 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003876 ensureListEmpty(t, provideNativeLibs)
3877 ensureListEmpty(t, requireNativeLibs)
3878
Sundong Ahnabb64432019-10-22 13:58:29 +09003879 apexManifestRule = ctx.ModuleForTests("myapex_dep", "android_common_myapex_dep_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003880 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3881 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003882 ensureListEmpty(t, provideNativeLibs)
3883 ensureListContains(t, requireNativeLibs, "libfoo.so")
3884
Sundong Ahnabb64432019-10-22 13:58:29 +09003885 apexManifestRule = ctx.ModuleForTests("myapex_provider", "android_common_myapex_provider_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003886 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3887 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003888 ensureListContains(t, provideNativeLibs, "libfoo.so")
3889 ensureListEmpty(t, requireNativeLibs)
3890
Sundong Ahnabb64432019-10-22 13:58:29 +09003891 apexManifestRule = ctx.ModuleForTests("myapex_selfcontained", "android_common_myapex_selfcontained_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003892 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3893 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003894 ensureListContains(t, provideNativeLibs, "libfoo.so")
3895 ensureListEmpty(t, requireNativeLibs)
3896}
3897
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003898func TestApexName(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003899 ctx := testApex(t, `
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003900 apex {
3901 name: "myapex",
3902 key: "myapex.key",
3903 apex_name: "com.android.myapex",
Jiyong Parkdb334862020-02-05 17:19:28 +09003904 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003905 updatable: false,
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003906 }
3907
3908 apex_key {
3909 name: "myapex.key",
3910 public_key: "testkey.avbpubkey",
3911 private_key: "testkey.pem",
3912 }
Jiyong Parkdb334862020-02-05 17:19:28 +09003913
3914 cc_library {
3915 name: "mylib",
3916 srcs: ["mylib.cpp"],
3917 system_shared_libs: [],
3918 stl: "none",
3919 apex_available: [
3920 "//apex_available:platform",
3921 "myapex",
3922 ],
3923 }
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003924 `)
3925
Sundong Ahnabb64432019-10-22 13:58:29 +09003926 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003927 apexManifestRule := module.Rule("apexManifestRule")
3928 ensureContains(t, apexManifestRule.Args["opt"], "-v name com.android.myapex")
3929 apexRule := module.Rule("apexRule")
3930 ensureContains(t, apexRule.Args["opt_flags"], "--do_not_check_keyname")
Jiyong Parkdb334862020-02-05 17:19:28 +09003931
3932 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07003933 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jiyong Parkdb334862020-02-05 17:19:28 +09003934 name := apexBundle.BaseModuleName()
3935 prefix := "TARGET_"
3936 var builder strings.Builder
3937 data.Custom(&builder, name, prefix, "", data)
3938 androidMk := builder.String()
3939 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
3940 ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003941}
3942
Alex Light0851b882019-02-07 13:20:53 -08003943func TestNonTestApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003944 ctx := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08003945 apex {
3946 name: "myapex",
3947 key: "myapex.key",
3948 native_shared_libs: ["mylib_common"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003949 updatable: false,
Alex Light0851b882019-02-07 13:20:53 -08003950 }
3951
3952 apex_key {
3953 name: "myapex.key",
3954 public_key: "testkey.avbpubkey",
3955 private_key: "testkey.pem",
3956 }
3957
3958 cc_library {
3959 name: "mylib_common",
3960 srcs: ["mylib.cpp"],
3961 system_shared_libs: [],
3962 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003963 apex_available: [
3964 "//apex_available:platform",
3965 "myapex",
3966 ],
Alex Light0851b882019-02-07 13:20:53 -08003967 }
3968 `)
3969
Sundong Ahnabb64432019-10-22 13:58:29 +09003970 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Alex Light0851b882019-02-07 13:20:53 -08003971 apexRule := module.Rule("apexRule")
3972 copyCmds := apexRule.Args["copy_commands"]
3973
3974 if apex, ok := module.Module().(*apexBundle); !ok || apex.testApex {
3975 t.Log("Apex was a test apex!")
3976 t.Fail()
3977 }
3978 // Ensure that main rule creates an output
3979 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
3980
3981 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -07003982 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
Alex Light0851b882019-02-07 13:20:53 -08003983
3984 // Ensure that both direct and indirect deps are copied into apex
3985 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
3986
Colin Cross7113d202019-11-20 16:39:12 -08003987 // Ensure that the platform variant ends with _shared
3988 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
Alex Light0851b882019-02-07 13:20:53 -08003989
Colin Cross56a83212020-09-15 18:30:11 -07003990 if !ctx.ModuleForTests("mylib_common", "android_arm64_armv8-a_shared_apex10000").Module().(*cc.Module).InAnyApex() {
Alex Light0851b882019-02-07 13:20:53 -08003991 t.Log("Found mylib_common not in any apex!")
3992 t.Fail()
3993 }
3994}
3995
3996func TestTestApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003997 ctx := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08003998 apex_test {
3999 name: "myapex",
4000 key: "myapex.key",
4001 native_shared_libs: ["mylib_common_test"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004002 updatable: false,
Alex Light0851b882019-02-07 13:20:53 -08004003 }
4004
4005 apex_key {
4006 name: "myapex.key",
4007 public_key: "testkey.avbpubkey",
4008 private_key: "testkey.pem",
4009 }
4010
4011 cc_library {
4012 name: "mylib_common_test",
4013 srcs: ["mylib.cpp"],
4014 system_shared_libs: [],
4015 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004016 // TODO: remove //apex_available:platform
4017 apex_available: [
4018 "//apex_available:platform",
4019 "myapex",
4020 ],
Alex Light0851b882019-02-07 13:20:53 -08004021 }
4022 `)
4023
Sundong Ahnabb64432019-10-22 13:58:29 +09004024 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Alex Light0851b882019-02-07 13:20:53 -08004025 apexRule := module.Rule("apexRule")
4026 copyCmds := apexRule.Args["copy_commands"]
4027
4028 if apex, ok := module.Module().(*apexBundle); !ok || !apex.testApex {
4029 t.Log("Apex was not a test apex!")
4030 t.Fail()
4031 }
4032 // Ensure that main rule creates an output
4033 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
4034
4035 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -07004036 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared_apex10000")
Alex Light0851b882019-02-07 13:20:53 -08004037
4038 // Ensure that both direct and indirect deps are copied into apex
4039 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common_test.so")
4040
Colin Cross7113d202019-11-20 16:39:12 -08004041 // Ensure that the platform variant ends with _shared
4042 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared")
Alex Light0851b882019-02-07 13:20:53 -08004043}
4044
Alex Light9670d332019-01-29 18:07:33 -08004045func TestApexWithTarget(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004046 ctx := testApex(t, `
Alex Light9670d332019-01-29 18:07:33 -08004047 apex {
4048 name: "myapex",
4049 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004050 updatable: false,
Alex Light9670d332019-01-29 18:07:33 -08004051 multilib: {
4052 first: {
4053 native_shared_libs: ["mylib_common"],
4054 }
4055 },
4056 target: {
4057 android: {
4058 multilib: {
4059 first: {
4060 native_shared_libs: ["mylib"],
4061 }
4062 }
4063 },
4064 host: {
4065 multilib: {
4066 first: {
4067 native_shared_libs: ["mylib2"],
4068 }
4069 }
4070 }
4071 }
4072 }
4073
4074 apex_key {
4075 name: "myapex.key",
4076 public_key: "testkey.avbpubkey",
4077 private_key: "testkey.pem",
4078 }
4079
4080 cc_library {
4081 name: "mylib",
4082 srcs: ["mylib.cpp"],
4083 system_shared_libs: [],
4084 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004085 // TODO: remove //apex_available:platform
4086 apex_available: [
4087 "//apex_available:platform",
4088 "myapex",
4089 ],
Alex Light9670d332019-01-29 18:07:33 -08004090 }
4091
4092 cc_library {
4093 name: "mylib_common",
4094 srcs: ["mylib.cpp"],
4095 system_shared_libs: [],
4096 stl: "none",
4097 compile_multilib: "first",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004098 // TODO: remove //apex_available:platform
4099 apex_available: [
4100 "//apex_available:platform",
4101 "myapex",
4102 ],
Alex Light9670d332019-01-29 18:07:33 -08004103 }
4104
4105 cc_library {
4106 name: "mylib2",
4107 srcs: ["mylib.cpp"],
4108 system_shared_libs: [],
4109 stl: "none",
4110 compile_multilib: "first",
4111 }
4112 `)
4113
Sundong Ahnabb64432019-10-22 13:58:29 +09004114 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Alex Light9670d332019-01-29 18:07:33 -08004115 copyCmds := apexRule.Args["copy_commands"]
4116
4117 // Ensure that main rule creates an output
4118 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
4119
4120 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -07004121 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
4122 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
4123 ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
Alex Light9670d332019-01-29 18:07:33 -08004124
4125 // Ensure that both direct and indirect deps are copied into apex
4126 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
4127 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
4128 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
4129
Colin Cross7113d202019-11-20 16:39:12 -08004130 // Ensure that the platform variant ends with _shared
4131 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
4132 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
4133 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
Alex Light9670d332019-01-29 18:07:33 -08004134}
Jiyong Park04480cf2019-02-06 00:16:29 +09004135
Jiyong Park59140302020-12-14 18:44:04 +09004136func TestApexWithArch(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004137 ctx := testApex(t, `
Jiyong Park59140302020-12-14 18:44:04 +09004138 apex {
4139 name: "myapex",
4140 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004141 updatable: false,
Jiyong Park59140302020-12-14 18:44:04 +09004142 arch: {
4143 arm64: {
4144 native_shared_libs: ["mylib.arm64"],
4145 },
4146 x86_64: {
4147 native_shared_libs: ["mylib.x64"],
4148 },
4149 }
4150 }
4151
4152 apex_key {
4153 name: "myapex.key",
4154 public_key: "testkey.avbpubkey",
4155 private_key: "testkey.pem",
4156 }
4157
4158 cc_library {
4159 name: "mylib.arm64",
4160 srcs: ["mylib.cpp"],
4161 system_shared_libs: [],
4162 stl: "none",
4163 // TODO: remove //apex_available:platform
4164 apex_available: [
4165 "//apex_available:platform",
4166 "myapex",
4167 ],
4168 }
4169
4170 cc_library {
4171 name: "mylib.x64",
4172 srcs: ["mylib.cpp"],
4173 system_shared_libs: [],
4174 stl: "none",
4175 // TODO: remove //apex_available:platform
4176 apex_available: [
4177 "//apex_available:platform",
4178 "myapex",
4179 ],
4180 }
4181 `)
4182
4183 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
4184 copyCmds := apexRule.Args["copy_commands"]
4185
4186 // Ensure that apex variant is created for the direct dep
4187 ensureListContains(t, ctx.ModuleVariantsForTests("mylib.arm64"), "android_arm64_armv8-a_shared_apex10000")
4188 ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib.x64"), "android_arm64_armv8-a_shared_apex10000")
4189
4190 // Ensure that both direct and indirect deps are copied into apex
4191 ensureContains(t, copyCmds, "image.apex/lib64/mylib.arm64.so")
4192 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib.x64.so")
4193}
4194
Jiyong Park04480cf2019-02-06 00:16:29 +09004195func TestApexWithShBinary(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004196 ctx := testApex(t, `
Jiyong Park04480cf2019-02-06 00:16:29 +09004197 apex {
4198 name: "myapex",
4199 key: "myapex.key",
4200 binaries: ["myscript"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004201 updatable: false,
Jiyong Park04480cf2019-02-06 00:16:29 +09004202 }
4203
4204 apex_key {
4205 name: "myapex.key",
4206 public_key: "testkey.avbpubkey",
4207 private_key: "testkey.pem",
4208 }
4209
4210 sh_binary {
4211 name: "myscript",
4212 src: "mylib.cpp",
4213 filename: "myscript.sh",
4214 sub_dir: "script",
4215 }
4216 `)
4217
Sundong Ahnabb64432019-10-22 13:58:29 +09004218 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park04480cf2019-02-06 00:16:29 +09004219 copyCmds := apexRule.Args["copy_commands"]
4220
4221 ensureContains(t, copyCmds, "image.apex/bin/script/myscript.sh")
4222}
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004223
Jooyung Han91df2082019-11-20 01:49:42 +09004224func TestApexInVariousPartition(t *testing.T) {
4225 testcases := []struct {
4226 propName, parition, flattenedPartition string
4227 }{
4228 {"", "system", "system_ext"},
4229 {"product_specific: true", "product", "product"},
4230 {"soc_specific: true", "vendor", "vendor"},
4231 {"proprietary: true", "vendor", "vendor"},
4232 {"vendor: true", "vendor", "vendor"},
4233 {"system_ext_specific: true", "system_ext", "system_ext"},
4234 }
4235 for _, tc := range testcases {
4236 t.Run(tc.propName+":"+tc.parition, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004237 ctx := testApex(t, `
Jooyung Han91df2082019-11-20 01:49:42 +09004238 apex {
4239 name: "myapex",
4240 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004241 updatable: false,
Jooyung Han91df2082019-11-20 01:49:42 +09004242 `+tc.propName+`
4243 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004244
Jooyung Han91df2082019-11-20 01:49:42 +09004245 apex_key {
4246 name: "myapex.key",
4247 public_key: "testkey.avbpubkey",
4248 private_key: "testkey.pem",
4249 }
4250 `)
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004251
Jooyung Han91df2082019-11-20 01:49:42 +09004252 apex := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Paul Duffin37ba3442021-03-29 00:21:08 +01004253 expected := "out/soong/target/product/test_device/" + tc.parition + "/apex"
4254 actual := apex.installDir.RelativeToTop().String()
Jooyung Han91df2082019-11-20 01:49:42 +09004255 if actual != expected {
4256 t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
4257 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004258
Jooyung Han91df2082019-11-20 01:49:42 +09004259 flattened := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
Paul Duffin37ba3442021-03-29 00:21:08 +01004260 expected = "out/soong/target/product/test_device/" + tc.flattenedPartition + "/apex"
4261 actual = flattened.installDir.RelativeToTop().String()
Jooyung Han91df2082019-11-20 01:49:42 +09004262 if actual != expected {
4263 t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
4264 }
4265 })
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004266 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004267}
Jiyong Park67882562019-03-21 01:11:21 +09004268
Jooyung Han580eb4f2020-06-24 19:33:06 +09004269func TestFileContexts_FindInDefaultLocationIfNotSet(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004270 ctx := testApex(t, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004271 apex {
4272 name: "myapex",
4273 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004274 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004275 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004276
Jooyung Han580eb4f2020-06-24 19:33:06 +09004277 apex_key {
4278 name: "myapex.key",
4279 public_key: "testkey.avbpubkey",
4280 private_key: "testkey.pem",
4281 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004282 `)
4283 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Han580eb4f2020-06-24 19:33:06 +09004284 rule := module.Output("file_contexts")
4285 ensureContains(t, rule.RuleParams.Command, "cat system/sepolicy/apex/myapex-file_contexts")
4286}
Jooyung Han54aca7b2019-11-20 02:26:02 +09004287
Jooyung Han580eb4f2020-06-24 19:33:06 +09004288func TestFileContexts_ShouldBeUnderSystemSepolicyForSystemApexes(t *testing.T) {
Jooyung Han54aca7b2019-11-20 02:26:02 +09004289 testApexError(t, `"myapex" .*: file_contexts: should be under system/sepolicy`, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004290 apex {
4291 name: "myapex",
4292 key: "myapex.key",
4293 file_contexts: "my_own_file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004294 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004295 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004296
Jooyung Han580eb4f2020-06-24 19:33:06 +09004297 apex_key {
4298 name: "myapex.key",
4299 public_key: "testkey.avbpubkey",
4300 private_key: "testkey.pem",
4301 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004302 `, withFiles(map[string][]byte{
4303 "my_own_file_contexts": nil,
4304 }))
Jooyung Han580eb4f2020-06-24 19:33:06 +09004305}
Jooyung Han54aca7b2019-11-20 02:26:02 +09004306
Jooyung Han580eb4f2020-06-24 19:33:06 +09004307func TestFileContexts_ProductSpecificApexes(t *testing.T) {
Jooyung Han54aca7b2019-11-20 02:26:02 +09004308 testApexError(t, `"myapex" .*: file_contexts: cannot find`, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004309 apex {
4310 name: "myapex",
4311 key: "myapex.key",
4312 product_specific: true,
4313 file_contexts: "product_specific_file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004314 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004315 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004316
Jooyung Han580eb4f2020-06-24 19:33:06 +09004317 apex_key {
4318 name: "myapex.key",
4319 public_key: "testkey.avbpubkey",
4320 private_key: "testkey.pem",
4321 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004322 `)
4323
Colin Cross1c460562021-02-16 17:55:47 -08004324 ctx := testApex(t, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004325 apex {
4326 name: "myapex",
4327 key: "myapex.key",
4328 product_specific: true,
4329 file_contexts: "product_specific_file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004330 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004331 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004332
Jooyung Han580eb4f2020-06-24 19:33:06 +09004333 apex_key {
4334 name: "myapex.key",
4335 public_key: "testkey.avbpubkey",
4336 private_key: "testkey.pem",
4337 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004338 `, withFiles(map[string][]byte{
4339 "product_specific_file_contexts": nil,
4340 }))
Jooyung Han580eb4f2020-06-24 19:33:06 +09004341 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
4342 rule := module.Output("file_contexts")
4343 ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
4344}
Jooyung Han54aca7b2019-11-20 02:26:02 +09004345
Jooyung Han580eb4f2020-06-24 19:33:06 +09004346func TestFileContexts_SetViaFileGroup(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004347 ctx := testApex(t, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004348 apex {
4349 name: "myapex",
4350 key: "myapex.key",
4351 product_specific: true,
4352 file_contexts: ":my-file-contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004353 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004354 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004355
Jooyung Han580eb4f2020-06-24 19:33:06 +09004356 apex_key {
4357 name: "myapex.key",
4358 public_key: "testkey.avbpubkey",
4359 private_key: "testkey.pem",
4360 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004361
Jooyung Han580eb4f2020-06-24 19:33:06 +09004362 filegroup {
4363 name: "my-file-contexts",
4364 srcs: ["product_specific_file_contexts"],
4365 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004366 `, withFiles(map[string][]byte{
4367 "product_specific_file_contexts": nil,
4368 }))
Jooyung Han580eb4f2020-06-24 19:33:06 +09004369 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
4370 rule := module.Output("file_contexts")
4371 ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
Jooyung Han54aca7b2019-11-20 02:26:02 +09004372}
4373
Jiyong Park67882562019-03-21 01:11:21 +09004374func TestApexKeyFromOtherModule(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004375 ctx := testApex(t, `
Jiyong Park67882562019-03-21 01:11:21 +09004376 apex_key {
4377 name: "myapex.key",
4378 public_key: ":my.avbpubkey",
4379 private_key: ":my.pem",
4380 product_specific: true,
4381 }
4382
4383 filegroup {
4384 name: "my.avbpubkey",
4385 srcs: ["testkey2.avbpubkey"],
4386 }
4387
4388 filegroup {
4389 name: "my.pem",
4390 srcs: ["testkey2.pem"],
4391 }
4392 `)
4393
4394 apex_key := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
4395 expected_pubkey := "testkey2.avbpubkey"
Jaewoong Jung18aefc12020-12-21 09:11:10 -08004396 actual_pubkey := apex_key.publicKeyFile.String()
Jiyong Park67882562019-03-21 01:11:21 +09004397 if actual_pubkey != expected_pubkey {
4398 t.Errorf("wrong public key path. expected %q. actual %q", expected_pubkey, actual_pubkey)
4399 }
4400 expected_privkey := "testkey2.pem"
Jaewoong Jung18aefc12020-12-21 09:11:10 -08004401 actual_privkey := apex_key.privateKeyFile.String()
Jiyong Park67882562019-03-21 01:11:21 +09004402 if actual_privkey != expected_privkey {
4403 t.Errorf("wrong private key path. expected %q. actual %q", expected_privkey, actual_privkey)
4404 }
4405}
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004406
4407func TestPrebuilt(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004408 ctx := testApex(t, `
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004409 prebuilt_apex {
4410 name: "myapex",
Jiyong Parkc95714e2019-03-29 14:23:10 +09004411 arch: {
4412 arm64: {
4413 src: "myapex-arm64.apex",
4414 },
4415 arm: {
4416 src: "myapex-arm.apex",
4417 },
4418 },
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004419 }
4420 `)
4421
Paul Duffin6717d882021-06-15 19:09:41 +01004422 prebuilt := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt)
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004423
Jiyong Parkc95714e2019-03-29 14:23:10 +09004424 expectedInput := "myapex-arm64.apex"
4425 if prebuilt.inputApex.String() != expectedInput {
4426 t.Errorf("inputApex invalid. expected: %q, actual: %q", expectedInput, prebuilt.inputApex.String())
4427 }
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004428}
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004429
Paul Duffinc0609c62021-03-01 17:27:16 +00004430func TestPrebuiltMissingSrc(t *testing.T) {
Paul Duffin6717d882021-06-15 19:09:41 +01004431 testApexError(t, `module "myapex" variant "android_common_myapex".*: prebuilt_apex does not support "arm64_armv8-a"`, `
Paul Duffinc0609c62021-03-01 17:27:16 +00004432 prebuilt_apex {
4433 name: "myapex",
4434 }
4435 `)
4436}
4437
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004438func TestPrebuiltFilenameOverride(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004439 ctx := testApex(t, `
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004440 prebuilt_apex {
4441 name: "myapex",
4442 src: "myapex-arm.apex",
4443 filename: "notmyapex.apex",
4444 }
4445 `)
4446
Paul Duffin6717d882021-06-15 19:09:41 +01004447 p := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt)
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004448
4449 expected := "notmyapex.apex"
4450 if p.installFilename != expected {
4451 t.Errorf("installFilename invalid. expected: %q, actual: %q", expected, p.installFilename)
4452 }
4453}
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07004454
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004455func TestPrebuiltOverrides(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004456 ctx := testApex(t, `
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004457 prebuilt_apex {
4458 name: "myapex.prebuilt",
4459 src: "myapex-arm.apex",
4460 overrides: [
4461 "myapex",
4462 ],
4463 }
4464 `)
4465
Paul Duffin6717d882021-06-15 19:09:41 +01004466 p := ctx.ModuleForTests("myapex.prebuilt", "android_common_myapex.prebuilt").Module().(*Prebuilt)
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004467
4468 expected := []string{"myapex"}
Colin Crossaa255532020-07-03 13:18:24 -07004469 actual := android.AndroidMkEntriesForTest(t, ctx, p)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004470 if !reflect.DeepEqual(actual, expected) {
Jiyong Parkb0a012c2019-11-14 17:17:03 +09004471 t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES value '%s', expected '%s'", actual, expected)
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004472 }
4473}
4474
Paul Duffin092153d2021-01-26 11:42:39 +00004475// These tests verify that the prebuilt_apex/deapexer to java_import wiring allows for the
4476// propagation of paths to dex implementation jars from the former to the latter.
Paul Duffin064b70c2020-11-02 17:32:38 +00004477func TestPrebuiltExportDexImplementationJars(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01004478 transform := android.NullFixturePreparer
Paul Duffin064b70c2020-11-02 17:32:38 +00004479
Paul Duffin89886cb2021-02-05 16:44:03 +00004480 checkDexJarBuildPath := func(t *testing.T, ctx *android.TestContext, name string) {
Paul Duffin064b70c2020-11-02 17:32:38 +00004481 // Make sure the import has been given the correct path to the dex jar.
Colin Crossdcf71b22021-02-01 13:59:03 -08004482 p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency)
Paul Duffin064b70c2020-11-02 17:32:38 +00004483 dexJarBuildPath := p.DexJarBuildPath()
Paul Duffin39853512021-02-26 11:09:39 +00004484 stem := android.RemoveOptionalPrebuiltPrefix(name)
4485 if expected, actual := ".intermediates/myapex.deapexer/android_common/deapexer/javalib/"+stem+".jar", android.NormalizePathForTesting(dexJarBuildPath); actual != expected {
Paul Duffin064b70c2020-11-02 17:32:38 +00004486 t.Errorf("Incorrect DexJarBuildPath value '%s', expected '%s'", actual, expected)
4487 }
4488 }
4489
Paul Duffin39853512021-02-26 11:09:39 +00004490 ensureNoSourceVariant := func(t *testing.T, ctx *android.TestContext, name string) {
Paul Duffin064b70c2020-11-02 17:32:38 +00004491 // Make sure that an apex variant is not created for the source module.
Paul Duffin39853512021-02-26 11:09:39 +00004492 if expected, actual := []string{"android_common"}, ctx.ModuleVariantsForTests(name); !reflect.DeepEqual(expected, actual) {
Paul Duffin064b70c2020-11-02 17:32:38 +00004493 t.Errorf("invalid set of variants for %q: expected %q, found %q", "libfoo", expected, actual)
4494 }
4495 }
4496
4497 t.Run("prebuilt only", func(t *testing.T) {
4498 bp := `
4499 prebuilt_apex {
4500 name: "myapex",
4501 arch: {
4502 arm64: {
4503 src: "myapex-arm64.apex",
4504 },
4505 arm: {
4506 src: "myapex-arm.apex",
4507 },
4508 },
Paul Duffin39853512021-02-26 11:09:39 +00004509 exported_java_libs: ["libfoo", "libbar"],
Paul Duffin064b70c2020-11-02 17:32:38 +00004510 }
4511
4512 java_import {
4513 name: "libfoo",
4514 jars: ["libfoo.jar"],
4515 }
Paul Duffin39853512021-02-26 11:09:39 +00004516
4517 java_sdk_library_import {
4518 name: "libbar",
4519 public: {
4520 jars: ["libbar.jar"],
4521 },
4522 }
Paul Duffin064b70c2020-11-02 17:32:38 +00004523 `
4524
4525 // Make sure that dexpreopt can access dex implementation files from the prebuilt.
4526 ctx := testDexpreoptWithApexes(t, bp, "", transform)
4527
Paul Duffinf6932af2021-02-26 18:21:56 +00004528 // Make sure that the deapexer has the correct input APEX.
4529 deapexer := ctx.ModuleForTests("myapex.deapexer", "android_common")
4530 rule := deapexer.Rule("deapexer")
4531 if expected, actual := []string{"myapex-arm64.apex"}, android.NormalizePathsForTesting(rule.Implicits); !reflect.DeepEqual(expected, actual) {
4532 t.Errorf("expected: %q, found: %q", expected, actual)
4533 }
4534
Paul Duffin0d10c3c2021-03-01 17:09:32 +00004535 // Make sure that the prebuilt_apex has the correct input APEX.
Paul Duffin6717d882021-06-15 19:09:41 +01004536 prebuiltApex := ctx.ModuleForTests("myapex", "android_common_myapex")
Paul Duffin0d10c3c2021-03-01 17:09:32 +00004537 rule = prebuiltApex.Rule("android/soong/android.Cp")
4538 if expected, actual := "myapex-arm64.apex", android.NormalizePathForTesting(rule.Input); !reflect.DeepEqual(expected, actual) {
4539 t.Errorf("expected: %q, found: %q", expected, actual)
4540 }
4541
Paul Duffin89886cb2021-02-05 16:44:03 +00004542 checkDexJarBuildPath(t, ctx, "libfoo")
Paul Duffin39853512021-02-26 11:09:39 +00004543
4544 checkDexJarBuildPath(t, ctx, "libbar")
Paul Duffin064b70c2020-11-02 17:32:38 +00004545 })
4546
4547 t.Run("prebuilt with source preferred", func(t *testing.T) {
4548
4549 bp := `
4550 prebuilt_apex {
4551 name: "myapex",
4552 arch: {
4553 arm64: {
4554 src: "myapex-arm64.apex",
4555 },
4556 arm: {
4557 src: "myapex-arm.apex",
4558 },
4559 },
Paul Duffin39853512021-02-26 11:09:39 +00004560 exported_java_libs: ["libfoo", "libbar"],
Paul Duffin064b70c2020-11-02 17:32:38 +00004561 }
4562
4563 java_import {
4564 name: "libfoo",
4565 jars: ["libfoo.jar"],
4566 }
4567
4568 java_library {
4569 name: "libfoo",
4570 }
Paul Duffin39853512021-02-26 11:09:39 +00004571
4572 java_sdk_library_import {
4573 name: "libbar",
4574 public: {
4575 jars: ["libbar.jar"],
4576 },
4577 }
4578
4579 java_sdk_library {
4580 name: "libbar",
4581 srcs: ["foo/bar/MyClass.java"],
4582 unsafe_ignore_missing_latest_api: true,
4583 }
Paul Duffin064b70c2020-11-02 17:32:38 +00004584 `
4585
4586 // Make sure that dexpreopt can access dex implementation files from the prebuilt.
4587 ctx := testDexpreoptWithApexes(t, bp, "", transform)
4588
Paul Duffin89886cb2021-02-05 16:44:03 +00004589 checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
Paul Duffin39853512021-02-26 11:09:39 +00004590 ensureNoSourceVariant(t, ctx, "libfoo")
4591
4592 checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
4593 ensureNoSourceVariant(t, ctx, "libbar")
Paul Duffin064b70c2020-11-02 17:32:38 +00004594 })
4595
4596 t.Run("prebuilt preferred with source", func(t *testing.T) {
4597 bp := `
4598 prebuilt_apex {
4599 name: "myapex",
Paul Duffin064b70c2020-11-02 17:32:38 +00004600 arch: {
4601 arm64: {
4602 src: "myapex-arm64.apex",
4603 },
4604 arm: {
4605 src: "myapex-arm.apex",
4606 },
4607 },
Paul Duffin39853512021-02-26 11:09:39 +00004608 exported_java_libs: ["libfoo", "libbar"],
Paul Duffin064b70c2020-11-02 17:32:38 +00004609 }
4610
4611 java_import {
4612 name: "libfoo",
Paul Duffin092153d2021-01-26 11:42:39 +00004613 prefer: true,
Paul Duffin064b70c2020-11-02 17:32:38 +00004614 jars: ["libfoo.jar"],
4615 }
4616
4617 java_library {
4618 name: "libfoo",
4619 }
Paul Duffin39853512021-02-26 11:09:39 +00004620
4621 java_sdk_library_import {
4622 name: "libbar",
4623 prefer: true,
4624 public: {
4625 jars: ["libbar.jar"],
4626 },
4627 }
4628
4629 java_sdk_library {
4630 name: "libbar",
4631 srcs: ["foo/bar/MyClass.java"],
4632 unsafe_ignore_missing_latest_api: true,
4633 }
Paul Duffin064b70c2020-11-02 17:32:38 +00004634 `
4635
4636 // Make sure that dexpreopt can access dex implementation files from the prebuilt.
4637 ctx := testDexpreoptWithApexes(t, bp, "", transform)
4638
Paul Duffin89886cb2021-02-05 16:44:03 +00004639 checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
Paul Duffin39853512021-02-26 11:09:39 +00004640 ensureNoSourceVariant(t, ctx, "libfoo")
4641
4642 checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
4643 ensureNoSourceVariant(t, ctx, "libbar")
Paul Duffin064b70c2020-11-02 17:32:38 +00004644 })
4645}
4646
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004647func TestBootDexJarsFromSourcesAndPrebuilts(t *testing.T) {
Paul Duffinb6f53c02021-05-14 07:52:42 +01004648 preparer := android.GroupFixturePreparers(
4649 java.FixtureConfigureBootJars("myapex:libfoo", "myapex:libbar"),
4650 // Make sure that the frameworks/base/Android.bp file exists as otherwise hidden API encoding
4651 // is disabled.
4652 android.FixtureAddTextFile("frameworks/base/Android.bp", ""),
4653 )
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004654
Paul Duffin37856732021-02-26 14:24:15 +00004655 checkBootDexJarPath := func(t *testing.T, ctx *android.TestContext, stem string, bootDexJarPath string) {
4656 t.Helper()
Paul Duffin7ebebfd2021-04-27 19:36:57 +01004657 s := ctx.ModuleForTests("platform-bootclasspath", "android_common")
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004658 foundLibfooJar := false
Paul Duffin37856732021-02-26 14:24:15 +00004659 base := stem + ".jar"
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004660 for _, output := range s.AllOutputs() {
Paul Duffin37856732021-02-26 14:24:15 +00004661 if filepath.Base(output) == base {
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004662 foundLibfooJar = true
4663 buildRule := s.Output(output)
Paul Duffin55607122021-03-30 23:32:51 +01004664 android.AssertStringEquals(t, "boot dex jar path", bootDexJarPath, buildRule.Input.String())
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004665 }
4666 }
4667 if !foundLibfooJar {
Paul Duffin55607122021-03-30 23:32:51 +01004668 t.Errorf("Rule for libfoo.jar missing in dex_bootjars singleton outputs %q", android.StringPathsRelativeToTop(ctx.Config().BuildDir(), s.AllOutputs()))
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004669 }
4670 }
4671
Paul Duffin4fd997b2021-02-03 20:06:33 +00004672 checkHiddenAPIIndexInputs := func(t *testing.T, ctx *android.TestContext, expectedInputs string) {
Paul Duffin37856732021-02-26 14:24:15 +00004673 t.Helper()
Paul Duffin00b2bfd2021-04-12 17:24:36 +01004674 platformBootclasspath := ctx.ModuleForTests("platform-bootclasspath", "android_common")
Paul Duffin537ea3d2021-05-14 10:38:00 +01004675 indexRule := platformBootclasspath.Rule("monolithic_hidden_API_index")
Paul Duffin51d7da22021-06-16 02:04:13 +01004676 java.CheckHiddenAPIRuleInputs(t, "index", expectedInputs, indexRule)
Paul Duffin4fd997b2021-02-03 20:06:33 +00004677 }
4678
Paul Duffin89f570a2021-06-16 01:42:33 +01004679 fragment := java.ApexVariantReference{
4680 Apex: proptools.StringPtr("myapex"),
4681 Module: proptools.StringPtr("my-bootclasspath-fragment"),
4682 }
4683
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004684 t.Run("prebuilt only", func(t *testing.T) {
4685 bp := `
4686 prebuilt_apex {
4687 name: "myapex",
4688 arch: {
4689 arm64: {
4690 src: "myapex-arm64.apex",
4691 },
4692 arm: {
4693 src: "myapex-arm.apex",
4694 },
4695 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004696 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4697 }
4698
4699 prebuilt_bootclasspath_fragment {
4700 name: "my-bootclasspath-fragment",
4701 contents: ["libfoo", "libbar"],
4702 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004703 }
4704
4705 java_import {
4706 name: "libfoo",
4707 jars: ["libfoo.jar"],
4708 apex_available: ["myapex"],
4709 }
Paul Duffin37856732021-02-26 14:24:15 +00004710
4711 java_sdk_library_import {
4712 name: "libbar",
4713 public: {
4714 jars: ["libbar.jar"],
4715 },
4716 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004717 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00004718 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004719 `
4720
Paul Duffin89f570a2021-06-16 01:42:33 +01004721 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01004722 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
4723 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00004724
Paul Duffin537ea3d2021-05-14 10:38:00 +01004725 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin9d67ca62021-02-03 20:06:33 +00004726 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin51d7da22021-06-16 02:04:13 +01004727 out/soong/.intermediates/libbar.stubs/android_common/combined/libbar.stubs.jar
4728 out/soong/.intermediates/libfoo/android_common_myapex/combined/libfoo.jar
4729 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004730 })
4731
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004732 t.Run("apex_set only", func(t *testing.T) {
4733 bp := `
4734 apex_set {
4735 name: "myapex",
4736 set: "myapex.apks",
Paul Duffin89f570a2021-06-16 01:42:33 +01004737 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4738 }
4739
4740 prebuilt_bootclasspath_fragment {
4741 name: "my-bootclasspath-fragment",
4742 contents: ["libfoo", "libbar"],
4743 apex_available: ["myapex"],
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004744 }
4745
4746 java_import {
4747 name: "libfoo",
4748 jars: ["libfoo.jar"],
4749 apex_available: ["myapex"],
4750 }
4751
4752 java_sdk_library_import {
4753 name: "libbar",
4754 public: {
4755 jars: ["libbar.jar"],
4756 },
4757 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004758 shared_library: false,
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004759 }
4760 `
4761
Paul Duffin89f570a2021-06-16 01:42:33 +01004762 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004763 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
4764 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
4765
Paul Duffin537ea3d2021-05-14 10:38:00 +01004766 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004767 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin51d7da22021-06-16 02:04:13 +01004768 out/soong/.intermediates/libbar.stubs/android_common/combined/libbar.stubs.jar
4769 out/soong/.intermediates/libfoo/android_common_myapex/combined/libfoo.jar
4770 `)
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004771 })
4772
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004773 t.Run("prebuilt with source library preferred", func(t *testing.T) {
4774 bp := `
4775 prebuilt_apex {
4776 name: "myapex",
4777 arch: {
4778 arm64: {
4779 src: "myapex-arm64.apex",
4780 },
4781 arm: {
4782 src: "myapex-arm.apex",
4783 },
4784 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004785 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4786 }
4787
4788 prebuilt_bootclasspath_fragment {
4789 name: "my-bootclasspath-fragment",
4790 contents: ["libfoo", "libbar"],
4791 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004792 }
4793
4794 java_import {
4795 name: "libfoo",
4796 jars: ["libfoo.jar"],
4797 apex_available: ["myapex"],
4798 }
4799
4800 java_library {
4801 name: "libfoo",
4802 srcs: ["foo/bar/MyClass.java"],
4803 apex_available: ["myapex"],
4804 }
Paul Duffin37856732021-02-26 14:24:15 +00004805
4806 java_sdk_library_import {
4807 name: "libbar",
4808 public: {
4809 jars: ["libbar.jar"],
4810 },
4811 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004812 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00004813 }
4814
4815 java_sdk_library {
4816 name: "libbar",
4817 srcs: ["foo/bar/MyClass.java"],
4818 unsafe_ignore_missing_latest_api: true,
4819 apex_available: ["myapex"],
4820 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004821 `
4822
4823 // In this test the source (java_library) libfoo is active since the
4824 // prebuilt (java_import) defaults to prefer:false. However the
4825 // prebuilt_apex module always depends on the prebuilt, and so it doesn't
4826 // find the dex boot jar in it. We either need to disable the source libfoo
4827 // or make the prebuilt libfoo preferred.
Paul Duffin89f570a2021-06-16 01:42:33 +01004828 testDexpreoptWithApexes(t, bp, "module libfoo does not provide a dex boot jar", preparer, fragment)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004829 })
4830
4831 t.Run("prebuilt library preferred with source", func(t *testing.T) {
4832 bp := `
4833 prebuilt_apex {
4834 name: "myapex",
4835 arch: {
4836 arm64: {
4837 src: "myapex-arm64.apex",
4838 },
4839 arm: {
4840 src: "myapex-arm.apex",
4841 },
4842 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004843 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4844 }
4845
4846 prebuilt_bootclasspath_fragment {
4847 name: "my-bootclasspath-fragment",
4848 contents: ["libfoo", "libbar"],
4849 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004850 }
4851
4852 java_import {
4853 name: "libfoo",
4854 prefer: true,
4855 jars: ["libfoo.jar"],
4856 apex_available: ["myapex"],
4857 }
4858
4859 java_library {
4860 name: "libfoo",
4861 srcs: ["foo/bar/MyClass.java"],
4862 apex_available: ["myapex"],
4863 }
Paul Duffin37856732021-02-26 14:24:15 +00004864
4865 java_sdk_library_import {
4866 name: "libbar",
4867 prefer: true,
4868 public: {
4869 jars: ["libbar.jar"],
4870 },
4871 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004872 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00004873 }
4874
4875 java_sdk_library {
4876 name: "libbar",
4877 srcs: ["foo/bar/MyClass.java"],
4878 unsafe_ignore_missing_latest_api: true,
4879 apex_available: ["myapex"],
4880 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004881 `
4882
Paul Duffin89f570a2021-06-16 01:42:33 +01004883 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01004884 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
4885 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00004886
Paul Duffin537ea3d2021-05-14 10:38:00 +01004887 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin9d67ca62021-02-03 20:06:33 +00004888 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin51d7da22021-06-16 02:04:13 +01004889 out/soong/.intermediates/prebuilt_libbar.stubs/android_common/combined/libbar.stubs.jar
4890 out/soong/.intermediates/prebuilt_libfoo/android_common_myapex/combined/libfoo.jar
4891 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004892 })
4893
4894 t.Run("prebuilt with source apex preferred", func(t *testing.T) {
4895 bp := `
4896 apex {
4897 name: "myapex",
4898 key: "myapex.key",
Paul Duffin37856732021-02-26 14:24:15 +00004899 java_libs: ["libfoo", "libbar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004900 updatable: false,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004901 }
4902
4903 apex_key {
4904 name: "myapex.key",
4905 public_key: "testkey.avbpubkey",
4906 private_key: "testkey.pem",
4907 }
4908
4909 prebuilt_apex {
4910 name: "myapex",
4911 arch: {
4912 arm64: {
4913 src: "myapex-arm64.apex",
4914 },
4915 arm: {
4916 src: "myapex-arm.apex",
4917 },
4918 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004919 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4920 }
4921
4922 prebuilt_bootclasspath_fragment {
4923 name: "my-bootclasspath-fragment",
4924 contents: ["libfoo", "libbar"],
4925 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004926 }
4927
4928 java_import {
4929 name: "libfoo",
4930 jars: ["libfoo.jar"],
4931 apex_available: ["myapex"],
4932 }
4933
4934 java_library {
4935 name: "libfoo",
4936 srcs: ["foo/bar/MyClass.java"],
4937 apex_available: ["myapex"],
4938 }
Paul Duffin37856732021-02-26 14:24:15 +00004939
4940 java_sdk_library_import {
4941 name: "libbar",
4942 public: {
4943 jars: ["libbar.jar"],
4944 },
4945 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004946 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00004947 }
4948
4949 java_sdk_library {
4950 name: "libbar",
4951 srcs: ["foo/bar/MyClass.java"],
4952 unsafe_ignore_missing_latest_api: true,
4953 apex_available: ["myapex"],
4954 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004955 `
4956
Paul Duffin89f570a2021-06-16 01:42:33 +01004957 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01004958 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/libfoo/android_common_apex10000/hiddenapi/libfoo.jar")
4959 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/libbar/android_common_myapex/hiddenapi/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00004960
Paul Duffin537ea3d2021-05-14 10:38:00 +01004961 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin4fd997b2021-02-03 20:06:33 +00004962 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin51d7da22021-06-16 02:04:13 +01004963 out/soong/.intermediates/libbar/android_common_myapex/javac/libbar.jar
4964 out/soong/.intermediates/libfoo/android_common_apex10000/javac/libfoo.jar
4965 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004966 })
4967
4968 t.Run("prebuilt preferred with source apex disabled", func(t *testing.T) {
4969 bp := `
4970 apex {
4971 name: "myapex",
4972 enabled: false,
4973 key: "myapex.key",
Paul Duffin8f146b92021-04-12 17:24:18 +01004974 java_libs: ["libfoo", "libbar"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004975 }
4976
4977 apex_key {
4978 name: "myapex.key",
4979 public_key: "testkey.avbpubkey",
4980 private_key: "testkey.pem",
4981 }
4982
4983 prebuilt_apex {
4984 name: "myapex",
4985 arch: {
4986 arm64: {
4987 src: "myapex-arm64.apex",
4988 },
4989 arm: {
4990 src: "myapex-arm.apex",
4991 },
4992 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004993 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4994 }
4995
4996 prebuilt_bootclasspath_fragment {
4997 name: "my-bootclasspath-fragment",
4998 contents: ["libfoo", "libbar"],
4999 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005000 }
5001
5002 java_import {
5003 name: "libfoo",
5004 prefer: true,
5005 jars: ["libfoo.jar"],
5006 apex_available: ["myapex"],
5007 }
5008
5009 java_library {
5010 name: "libfoo",
5011 srcs: ["foo/bar/MyClass.java"],
5012 apex_available: ["myapex"],
5013 }
Paul Duffin37856732021-02-26 14:24:15 +00005014
5015 java_sdk_library_import {
5016 name: "libbar",
5017 prefer: true,
5018 public: {
5019 jars: ["libbar.jar"],
5020 },
5021 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01005022 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00005023 }
5024
5025 java_sdk_library {
5026 name: "libbar",
5027 srcs: ["foo/bar/MyClass.java"],
5028 unsafe_ignore_missing_latest_api: true,
5029 apex_available: ["myapex"],
5030 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005031 `
5032
Paul Duffin89f570a2021-06-16 01:42:33 +01005033 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01005034 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
5035 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00005036
Paul Duffin537ea3d2021-05-14 10:38:00 +01005037 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin9d67ca62021-02-03 20:06:33 +00005038 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin51d7da22021-06-16 02:04:13 +01005039 out/soong/.intermediates/prebuilt_libbar.stubs/android_common/combined/libbar.stubs.jar
5040 out/soong/.intermediates/prebuilt_libfoo/android_common_myapex/combined/libfoo.jar
5041 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005042 })
5043}
5044
Roland Levillain630846d2019-06-26 12:48:34 +01005045func TestApexWithTests(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005046 ctx := testApex(t, `
Roland Levillain630846d2019-06-26 12:48:34 +01005047 apex_test {
5048 name: "myapex",
5049 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005050 updatable: false,
Roland Levillain630846d2019-06-26 12:48:34 +01005051 tests: [
5052 "mytest",
Roland Levillain9b5fde92019-06-28 15:41:19 +01005053 "mytests",
Roland Levillain630846d2019-06-26 12:48:34 +01005054 ],
5055 }
5056
5057 apex_key {
5058 name: "myapex.key",
5059 public_key: "testkey.avbpubkey",
5060 private_key: "testkey.pem",
5061 }
5062
Liz Kammer1c14a212020-05-12 15:26:55 -07005063 filegroup {
5064 name: "fg",
5065 srcs: [
5066 "baz",
5067 "bar/baz"
5068 ],
5069 }
5070
Roland Levillain630846d2019-06-26 12:48:34 +01005071 cc_test {
5072 name: "mytest",
5073 gtest: false,
5074 srcs: ["mytest.cpp"],
5075 relative_install_path: "test",
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005076 shared_libs: ["mylib"],
Roland Levillain630846d2019-06-26 12:48:34 +01005077 system_shared_libs: [],
5078 static_executable: true,
5079 stl: "none",
Liz Kammer1c14a212020-05-12 15:26:55 -07005080 data: [":fg"],
Roland Levillain630846d2019-06-26 12:48:34 +01005081 }
Roland Levillain9b5fde92019-06-28 15:41:19 +01005082
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005083 cc_library {
5084 name: "mylib",
5085 srcs: ["mylib.cpp"],
5086 system_shared_libs: [],
5087 stl: "none",
5088 }
5089
Liz Kammer5bd365f2020-05-27 15:15:11 -07005090 filegroup {
5091 name: "fg2",
5092 srcs: [
5093 "testdata/baz"
5094 ],
5095 }
5096
Roland Levillain9b5fde92019-06-28 15:41:19 +01005097 cc_test {
5098 name: "mytests",
5099 gtest: false,
5100 srcs: [
5101 "mytest1.cpp",
5102 "mytest2.cpp",
5103 "mytest3.cpp",
5104 ],
5105 test_per_src: true,
5106 relative_install_path: "test",
5107 system_shared_libs: [],
5108 static_executable: true,
5109 stl: "none",
Liz Kammer5bd365f2020-05-27 15:15:11 -07005110 data: [
5111 ":fg",
5112 ":fg2",
5113 ],
Roland Levillain9b5fde92019-06-28 15:41:19 +01005114 }
Roland Levillain630846d2019-06-26 12:48:34 +01005115 `)
5116
Sundong Ahnabb64432019-10-22 13:58:29 +09005117 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Roland Levillain630846d2019-06-26 12:48:34 +01005118 copyCmds := apexRule.Args["copy_commands"]
5119
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005120 // Ensure that test dep (and their transitive dependencies) are copied into apex.
Roland Levillain630846d2019-06-26 12:48:34 +01005121 ensureContains(t, copyCmds, "image.apex/bin/test/mytest")
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005122 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Roland Levillain9b5fde92019-06-28 15:41:19 +01005123
Liz Kammer1c14a212020-05-12 15:26:55 -07005124 //Ensure that test data are copied into apex.
5125 ensureContains(t, copyCmds, "image.apex/bin/test/baz")
5126 ensureContains(t, copyCmds, "image.apex/bin/test/bar/baz")
5127
Roland Levillain9b5fde92019-06-28 15:41:19 +01005128 // Ensure that test deps built with `test_per_src` are copied into apex.
5129 ensureContains(t, copyCmds, "image.apex/bin/test/mytest1")
5130 ensureContains(t, copyCmds, "image.apex/bin/test/mytest2")
5131 ensureContains(t, copyCmds, "image.apex/bin/test/mytest3")
Roland Levillainf89cd092019-07-29 16:22:59 +01005132
5133 // Ensure the module is correctly translated.
Liz Kammer81faaaf2020-05-20 09:57:08 -07005134 bundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07005135 data := android.AndroidMkDataForTest(t, ctx, bundle)
Liz Kammer81faaaf2020-05-20 09:57:08 -07005136 name := bundle.BaseModuleName()
Roland Levillainf89cd092019-07-29 16:22:59 +01005137 prefix := "TARGET_"
5138 var builder strings.Builder
5139 data.Custom(&builder, name, prefix, "", data)
5140 androidMk := builder.String()
Jooyung Han31c470b2019-10-18 16:26:59 +09005141 ensureContains(t, androidMk, "LOCAL_MODULE := mytest.myapex\n")
5142 ensureContains(t, androidMk, "LOCAL_MODULE := mytest1.myapex\n")
5143 ensureContains(t, androidMk, "LOCAL_MODULE := mytest2.myapex\n")
5144 ensureContains(t, androidMk, "LOCAL_MODULE := mytest3.myapex\n")
Jooyung Han214bf372019-11-12 13:03:50 +09005145 ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex\n")
Jooyung Han31c470b2019-10-18 16:26:59 +09005146 ensureContains(t, androidMk, "LOCAL_MODULE := apex_pubkey.myapex\n")
Roland Levillainf89cd092019-07-29 16:22:59 +01005147 ensureContains(t, androidMk, "LOCAL_MODULE := myapex\n")
Liz Kammer81faaaf2020-05-20 09:57:08 -07005148
5149 flatBundle := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07005150 data = android.AndroidMkDataForTest(t, ctx, flatBundle)
Liz Kammer81faaaf2020-05-20 09:57:08 -07005151 data.Custom(&builder, name, prefix, "", data)
5152 flatAndroidMk := builder.String()
Liz Kammer5bd365f2020-05-27 15:15:11 -07005153 ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :baz :bar/baz\n")
5154 ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :testdata/baz\n")
Roland Levillain630846d2019-06-26 12:48:34 +01005155}
5156
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005157func TestInstallExtraFlattenedApexes(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005158 ctx := testApex(t, `
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005159 apex {
5160 name: "myapex",
5161 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005162 updatable: false,
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005163 }
5164 apex_key {
5165 name: "myapex.key",
5166 public_key: "testkey.avbpubkey",
5167 private_key: "testkey.pem",
5168 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00005169 `,
5170 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
5171 variables.InstallExtraFlattenedApexes = proptools.BoolPtr(true)
5172 }),
5173 )
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005174 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Jiyong Park83dc74b2020-01-14 18:38:44 +09005175 ensureListContains(t, ab.requiredDeps, "myapex.flattened")
Colin Crossaa255532020-07-03 13:18:24 -07005176 mk := android.AndroidMkDataForTest(t, ctx, ab)
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005177 var builder strings.Builder
5178 mk.Custom(&builder, ab.Name(), "TARGET_", "", mk)
5179 androidMk := builder.String()
5180 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += myapex.flattened")
5181}
5182
Jooyung Hand48f3c32019-08-23 11:18:57 +09005183func TestErrorsIfDepsAreNotEnabled(t *testing.T) {
5184 testApexError(t, `module "myapex" .* depends on disabled module "libfoo"`, `
5185 apex {
5186 name: "myapex",
5187 key: "myapex.key",
5188 native_shared_libs: ["libfoo"],
5189 }
5190
5191 apex_key {
5192 name: "myapex.key",
5193 public_key: "testkey.avbpubkey",
5194 private_key: "testkey.pem",
5195 }
5196
5197 cc_library {
5198 name: "libfoo",
5199 stl: "none",
5200 system_shared_libs: [],
5201 enabled: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09005202 apex_available: ["myapex"],
Jooyung Hand48f3c32019-08-23 11:18:57 +09005203 }
5204 `)
5205 testApexError(t, `module "myapex" .* depends on disabled module "myjar"`, `
5206 apex {
5207 name: "myapex",
5208 key: "myapex.key",
5209 java_libs: ["myjar"],
5210 }
5211
5212 apex_key {
5213 name: "myapex.key",
5214 public_key: "testkey.avbpubkey",
5215 private_key: "testkey.pem",
5216 }
5217
5218 java_library {
5219 name: "myjar",
5220 srcs: ["foo/bar/MyClass.java"],
5221 sdk_version: "none",
5222 system_modules: "none",
Jooyung Hand48f3c32019-08-23 11:18:57 +09005223 enabled: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09005224 apex_available: ["myapex"],
Jooyung Hand48f3c32019-08-23 11:18:57 +09005225 }
5226 `)
5227}
5228
Bill Peckhama41a6962021-01-11 10:58:54 -08005229func TestApexWithJavaImport(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005230 ctx := testApex(t, `
Bill Peckhama41a6962021-01-11 10:58:54 -08005231 apex {
5232 name: "myapex",
5233 key: "myapex.key",
5234 java_libs: ["myjavaimport"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005235 updatable: false,
Bill Peckhama41a6962021-01-11 10:58:54 -08005236 }
5237
5238 apex_key {
5239 name: "myapex.key",
5240 public_key: "testkey.avbpubkey",
5241 private_key: "testkey.pem",
5242 }
5243
5244 java_import {
5245 name: "myjavaimport",
5246 apex_available: ["myapex"],
5247 jars: ["my.jar"],
5248 compile_dex: true,
5249 }
5250 `)
5251
5252 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
5253 apexRule := module.Rule("apexRule")
5254 copyCmds := apexRule.Args["copy_commands"]
5255 ensureContains(t, copyCmds, "image.apex/javalib/myjavaimport.jar")
5256}
5257
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005258func TestApexWithApps(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005259 ctx := testApex(t, `
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005260 apex {
5261 name: "myapex",
5262 key: "myapex.key",
5263 apps: [
5264 "AppFoo",
Jiyong Parkf7487312019-10-17 12:54:30 +09005265 "AppFooPriv",
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005266 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005267 updatable: false,
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005268 }
5269
5270 apex_key {
5271 name: "myapex.key",
5272 public_key: "testkey.avbpubkey",
5273 private_key: "testkey.pem",
5274 }
5275
5276 android_app {
5277 name: "AppFoo",
5278 srcs: ["foo/bar/MyClass.java"],
Colin Cross094cde42020-02-15 10:38:00 -08005279 sdk_version: "current",
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005280 system_modules: "none",
Jiyong Park8be103b2019-11-08 15:53:48 +09005281 jni_libs: ["libjni"],
Colin Cross094cde42020-02-15 10:38:00 -08005282 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005283 apex_available: [ "myapex" ],
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005284 }
Jiyong Parkf7487312019-10-17 12:54:30 +09005285
5286 android_app {
5287 name: "AppFooPriv",
5288 srcs: ["foo/bar/MyClass.java"],
Colin Cross094cde42020-02-15 10:38:00 -08005289 sdk_version: "current",
Jiyong Parkf7487312019-10-17 12:54:30 +09005290 system_modules: "none",
5291 privileged: true,
Colin Cross094cde42020-02-15 10:38:00 -08005292 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005293 apex_available: [ "myapex" ],
Jiyong Parkf7487312019-10-17 12:54:30 +09005294 }
Jiyong Park8be103b2019-11-08 15:53:48 +09005295
5296 cc_library_shared {
5297 name: "libjni",
5298 srcs: ["mylib.cpp"],
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005299 shared_libs: ["libfoo"],
5300 stl: "none",
5301 system_shared_libs: [],
5302 apex_available: [ "myapex" ],
5303 sdk_version: "current",
5304 }
5305
5306 cc_library_shared {
5307 name: "libfoo",
Jiyong Park8be103b2019-11-08 15:53:48 +09005308 stl: "none",
5309 system_shared_libs: [],
Jiyong Park0f80c182020-01-31 02:49:53 +09005310 apex_available: [ "myapex" ],
Colin Cross094cde42020-02-15 10:38:00 -08005311 sdk_version: "current",
Jiyong Park8be103b2019-11-08 15:53:48 +09005312 }
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005313 `)
5314
Sundong Ahnabb64432019-10-22 13:58:29 +09005315 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005316 apexRule := module.Rule("apexRule")
5317 copyCmds := apexRule.Args["copy_commands"]
5318
5319 ensureContains(t, copyCmds, "image.apex/app/AppFoo/AppFoo.apk")
Jiyong Parkf7487312019-10-17 12:54:30 +09005320 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPriv/AppFooPriv.apk")
Jiyong Park52cd06f2019-11-11 10:14:32 +09005321
Colin Crossaede88c2020-08-11 12:17:01 -07005322 appZipRule := ctx.ModuleForTests("AppFoo", "android_common_apex10000").Description("zip jni libs")
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005323 // JNI libraries are uncompressed
Jiyong Park52cd06f2019-11-11 10:14:32 +09005324 if args := appZipRule.Args["jarArgs"]; !strings.Contains(args, "-L 0") {
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005325 t.Errorf("jni libs are not uncompressed for AppFoo")
Jiyong Park52cd06f2019-11-11 10:14:32 +09005326 }
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005327 // JNI libraries including transitive deps are
5328 for _, jni := range []string{"libjni", "libfoo"} {
Paul Duffinafdd4062021-03-30 19:44:07 +01005329 jniOutput := ctx.ModuleForTests(jni, "android_arm64_armv8-a_sdk_shared_apex10000").Module().(*cc.Module).OutputFile().RelativeToTop()
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005330 // ... embedded inside APK (jnilibs.zip)
5331 ensureListContains(t, appZipRule.Implicits.Strings(), jniOutput.String())
5332 // ... and not directly inside the APEX
5333 ensureNotContains(t, copyCmds, "image.apex/lib64/"+jni+".so")
5334 }
Dario Frenicde2a032019-10-27 00:29:22 +01005335}
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005336
Dario Frenicde2a032019-10-27 00:29:22 +01005337func TestApexWithAppImports(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005338 ctx := testApex(t, `
Dario Frenicde2a032019-10-27 00:29:22 +01005339 apex {
5340 name: "myapex",
5341 key: "myapex.key",
5342 apps: [
5343 "AppFooPrebuilt",
5344 "AppFooPrivPrebuilt",
5345 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005346 updatable: false,
Dario Frenicde2a032019-10-27 00:29:22 +01005347 }
5348
5349 apex_key {
5350 name: "myapex.key",
5351 public_key: "testkey.avbpubkey",
5352 private_key: "testkey.pem",
5353 }
5354
5355 android_app_import {
5356 name: "AppFooPrebuilt",
5357 apk: "PrebuiltAppFoo.apk",
5358 presigned: true,
5359 dex_preopt: {
5360 enabled: false,
5361 },
Jiyong Park592a6a42020-04-21 22:34:28 +09005362 apex_available: ["myapex"],
Dario Frenicde2a032019-10-27 00:29:22 +01005363 }
5364
5365 android_app_import {
5366 name: "AppFooPrivPrebuilt",
5367 apk: "PrebuiltAppFooPriv.apk",
5368 privileged: true,
5369 presigned: true,
5370 dex_preopt: {
5371 enabled: false,
5372 },
Jooyung Han39ee1192020-03-23 20:21:11 +09005373 filename: "AwesomePrebuiltAppFooPriv.apk",
Jiyong Park592a6a42020-04-21 22:34:28 +09005374 apex_available: ["myapex"],
Dario Frenicde2a032019-10-27 00:29:22 +01005375 }
5376 `)
5377
Sundong Ahnabb64432019-10-22 13:58:29 +09005378 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Dario Frenicde2a032019-10-27 00:29:22 +01005379 apexRule := module.Rule("apexRule")
5380 copyCmds := apexRule.Args["copy_commands"]
5381
5382 ensureContains(t, copyCmds, "image.apex/app/AppFooPrebuilt/AppFooPrebuilt.apk")
Jooyung Han39ee1192020-03-23 20:21:11 +09005383 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPrivPrebuilt/AwesomePrebuiltAppFooPriv.apk")
5384}
5385
5386func TestApexWithAppImportsPrefer(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005387 ctx := testApex(t, `
Jooyung Han39ee1192020-03-23 20:21:11 +09005388 apex {
5389 name: "myapex",
5390 key: "myapex.key",
5391 apps: [
5392 "AppFoo",
5393 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005394 updatable: false,
Jooyung Han39ee1192020-03-23 20:21:11 +09005395 }
5396
5397 apex_key {
5398 name: "myapex.key",
5399 public_key: "testkey.avbpubkey",
5400 private_key: "testkey.pem",
5401 }
5402
5403 android_app {
5404 name: "AppFoo",
5405 srcs: ["foo/bar/MyClass.java"],
5406 sdk_version: "none",
5407 system_modules: "none",
5408 apex_available: [ "myapex" ],
5409 }
5410
5411 android_app_import {
5412 name: "AppFoo",
5413 apk: "AppFooPrebuilt.apk",
5414 filename: "AppFooPrebuilt.apk",
5415 presigned: true,
5416 prefer: true,
Jiyong Park592a6a42020-04-21 22:34:28 +09005417 apex_available: ["myapex"],
Jooyung Han39ee1192020-03-23 20:21:11 +09005418 }
5419 `, withFiles(map[string][]byte{
5420 "AppFooPrebuilt.apk": nil,
5421 }))
5422
5423 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Han86feead2021-03-08 13:11:48 +09005424 "app/AppFoo/AppFooPrebuilt.apk",
Jooyung Han39ee1192020-03-23 20:21:11 +09005425 })
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005426}
5427
Dario Freni6f3937c2019-12-20 22:58:03 +00005428func TestApexWithTestHelperApp(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005429 ctx := testApex(t, `
Dario Freni6f3937c2019-12-20 22:58:03 +00005430 apex {
5431 name: "myapex",
5432 key: "myapex.key",
5433 apps: [
5434 "TesterHelpAppFoo",
5435 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005436 updatable: false,
Dario Freni6f3937c2019-12-20 22:58:03 +00005437 }
5438
5439 apex_key {
5440 name: "myapex.key",
5441 public_key: "testkey.avbpubkey",
5442 private_key: "testkey.pem",
5443 }
5444
5445 android_test_helper_app {
5446 name: "TesterHelpAppFoo",
5447 srcs: ["foo/bar/MyClass.java"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005448 apex_available: [ "myapex" ],
Dario Freni6f3937c2019-12-20 22:58:03 +00005449 }
5450
5451 `)
5452
5453 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
5454 apexRule := module.Rule("apexRule")
5455 copyCmds := apexRule.Args["copy_commands"]
5456
5457 ensureContains(t, copyCmds, "image.apex/app/TesterHelpAppFoo/TesterHelpAppFoo.apk")
5458}
5459
Jooyung Han18020ea2019-11-13 10:50:48 +09005460func TestApexPropertiesShouldBeDefaultable(t *testing.T) {
5461 // libfoo's apex_available comes from cc_defaults
Steven Moreland6e36cd62020-10-22 01:08:35 +00005462 testApexError(t, `requires "libfoo" that doesn't list the APEX under 'apex_available'.`, `
Jooyung Han18020ea2019-11-13 10:50:48 +09005463 apex {
5464 name: "myapex",
5465 key: "myapex.key",
5466 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005467 updatable: false,
Jooyung Han18020ea2019-11-13 10:50:48 +09005468 }
5469
5470 apex_key {
5471 name: "myapex.key",
5472 public_key: "testkey.avbpubkey",
5473 private_key: "testkey.pem",
5474 }
5475
5476 apex {
5477 name: "otherapex",
5478 key: "myapex.key",
5479 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005480 updatable: false,
Jooyung Han18020ea2019-11-13 10:50:48 +09005481 }
5482
5483 cc_defaults {
5484 name: "libfoo-defaults",
5485 apex_available: ["otherapex"],
5486 }
5487
5488 cc_library {
5489 name: "libfoo",
5490 defaults: ["libfoo-defaults"],
5491 stl: "none",
5492 system_shared_libs: [],
5493 }`)
5494}
5495
Paul Duffine52e66f2020-03-30 17:54:29 +01005496func TestApexAvailable_DirectDep(t *testing.T) {
Jiyong Park127b40b2019-09-30 16:04:35 +09005497 // libfoo is not available to myapex, but only to otherapex
Steven Moreland6e36cd62020-10-22 01:08:35 +00005498 testApexError(t, "requires \"libfoo\" that doesn't list the APEX under 'apex_available'.", `
Jiyong Park127b40b2019-09-30 16:04:35 +09005499 apex {
5500 name: "myapex",
5501 key: "myapex.key",
5502 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005503 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005504 }
5505
5506 apex_key {
5507 name: "myapex.key",
5508 public_key: "testkey.avbpubkey",
5509 private_key: "testkey.pem",
5510 }
5511
5512 apex {
5513 name: "otherapex",
5514 key: "otherapex.key",
5515 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005516 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005517 }
5518
5519 apex_key {
5520 name: "otherapex.key",
5521 public_key: "testkey.avbpubkey",
5522 private_key: "testkey.pem",
5523 }
5524
5525 cc_library {
5526 name: "libfoo",
5527 stl: "none",
5528 system_shared_libs: [],
5529 apex_available: ["otherapex"],
5530 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01005531}
Jiyong Park127b40b2019-09-30 16:04:35 +09005532
Paul Duffine52e66f2020-03-30 17:54:29 +01005533func TestApexAvailable_IndirectDep(t *testing.T) {
Jooyung Han5e9013b2020-03-10 06:23:13 +09005534 // libbbaz is an indirect dep
Jiyong Park767dbd92021-03-04 13:03:10 +09005535 testApexError(t, `requires "libbaz" that doesn't list the APEX under 'apex_available'.\n\nDependency path:
Colin Cross6e511a92020-07-27 21:26:48 -07005536.*via tag apex\.dependencyTag.*name:sharedLib.*
Paul Duffindf915ff2020-03-30 17:58:21 +01005537.*-> libfoo.*link:shared.*
Colin Cross6e511a92020-07-27 21:26:48 -07005538.*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
Paul Duffindf915ff2020-03-30 17:58:21 +01005539.*-> libbar.*link:shared.*
Colin Cross6e511a92020-07-27 21:26:48 -07005540.*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
Paul Duffin65347702020-03-31 15:23:40 +01005541.*-> libbaz.*link:shared.*`, `
Jiyong Park127b40b2019-09-30 16:04:35 +09005542 apex {
5543 name: "myapex",
5544 key: "myapex.key",
5545 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005546 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005547 }
5548
5549 apex_key {
5550 name: "myapex.key",
5551 public_key: "testkey.avbpubkey",
5552 private_key: "testkey.pem",
5553 }
5554
Jiyong Park127b40b2019-09-30 16:04:35 +09005555 cc_library {
5556 name: "libfoo",
5557 stl: "none",
5558 shared_libs: ["libbar"],
5559 system_shared_libs: [],
Jooyung Han5e9013b2020-03-10 06:23:13 +09005560 apex_available: ["myapex"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005561 }
5562
5563 cc_library {
5564 name: "libbar",
5565 stl: "none",
Jooyung Han5e9013b2020-03-10 06:23:13 +09005566 shared_libs: ["libbaz"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005567 system_shared_libs: [],
Jooyung Han5e9013b2020-03-10 06:23:13 +09005568 apex_available: ["myapex"],
5569 }
5570
5571 cc_library {
5572 name: "libbaz",
5573 stl: "none",
5574 system_shared_libs: [],
Jiyong Park127b40b2019-09-30 16:04:35 +09005575 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01005576}
Jiyong Park127b40b2019-09-30 16:04:35 +09005577
Paul Duffine52e66f2020-03-30 17:54:29 +01005578func TestApexAvailable_InvalidApexName(t *testing.T) {
Jiyong Park127b40b2019-09-30 16:04:35 +09005579 testApexError(t, "\"otherapex\" is not a valid module name", `
5580 apex {
5581 name: "myapex",
5582 key: "myapex.key",
5583 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005584 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005585 }
5586
5587 apex_key {
5588 name: "myapex.key",
5589 public_key: "testkey.avbpubkey",
5590 private_key: "testkey.pem",
5591 }
5592
5593 cc_library {
5594 name: "libfoo",
5595 stl: "none",
5596 system_shared_libs: [],
5597 apex_available: ["otherapex"],
5598 }`)
5599
Paul Duffine52e66f2020-03-30 17:54:29 +01005600 testApex(t, `
Jiyong Park127b40b2019-09-30 16:04:35 +09005601 apex {
5602 name: "myapex",
5603 key: "myapex.key",
5604 native_shared_libs: ["libfoo", "libbar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005605 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005606 }
5607
5608 apex_key {
5609 name: "myapex.key",
5610 public_key: "testkey.avbpubkey",
5611 private_key: "testkey.pem",
5612 }
5613
5614 cc_library {
5615 name: "libfoo",
5616 stl: "none",
5617 system_shared_libs: [],
Jiyong Park323a4c32020-03-01 17:29:06 +09005618 runtime_libs: ["libbaz"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005619 apex_available: ["myapex"],
5620 }
5621
5622 cc_library {
5623 name: "libbar",
5624 stl: "none",
5625 system_shared_libs: [],
5626 apex_available: ["//apex_available:anyapex"],
Jiyong Park323a4c32020-03-01 17:29:06 +09005627 }
5628
5629 cc_library {
5630 name: "libbaz",
5631 stl: "none",
5632 system_shared_libs: [],
5633 stubs: {
5634 versions: ["10", "20", "30"],
5635 },
Jiyong Park127b40b2019-09-30 16:04:35 +09005636 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01005637}
Jiyong Park127b40b2019-09-30 16:04:35 +09005638
Jiyong Park89e850a2020-04-07 16:37:39 +09005639func TestApexAvailable_CheckForPlatform(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005640 ctx := testApex(t, `
Jiyong Park127b40b2019-09-30 16:04:35 +09005641 apex {
5642 name: "myapex",
5643 key: "myapex.key",
Jiyong Park89e850a2020-04-07 16:37:39 +09005644 native_shared_libs: ["libbar", "libbaz"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005645 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005646 }
5647
5648 apex_key {
5649 name: "myapex.key",
5650 public_key: "testkey.avbpubkey",
5651 private_key: "testkey.pem",
5652 }
5653
5654 cc_library {
5655 name: "libfoo",
5656 stl: "none",
5657 system_shared_libs: [],
Jiyong Park89e850a2020-04-07 16:37:39 +09005658 shared_libs: ["libbar"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005659 apex_available: ["//apex_available:platform"],
Jiyong Park89e850a2020-04-07 16:37:39 +09005660 }
5661
5662 cc_library {
5663 name: "libfoo2",
5664 stl: "none",
5665 system_shared_libs: [],
5666 shared_libs: ["libbaz"],
5667 apex_available: ["//apex_available:platform"],
5668 }
5669
5670 cc_library {
5671 name: "libbar",
5672 stl: "none",
5673 system_shared_libs: [],
5674 apex_available: ["myapex"],
5675 }
5676
5677 cc_library {
5678 name: "libbaz",
5679 stl: "none",
5680 system_shared_libs: [],
5681 apex_available: ["myapex"],
5682 stubs: {
5683 versions: ["1"],
5684 },
Jiyong Park127b40b2019-09-30 16:04:35 +09005685 }`)
5686
Jiyong Park89e850a2020-04-07 16:37:39 +09005687 // libfoo shouldn't be available to platform even though it has "//apex_available:platform",
5688 // because it depends on libbar which isn't available to platform
5689 libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
5690 if libfoo.NotAvailableForPlatform() != true {
5691 t.Errorf("%q shouldn't be available to platform", libfoo.String())
5692 }
5693
5694 // libfoo2 however can be available to platform because it depends on libbaz which provides
5695 // stubs
5696 libfoo2 := ctx.ModuleForTests("libfoo2", "android_arm64_armv8-a_shared").Module().(*cc.Module)
5697 if libfoo2.NotAvailableForPlatform() == true {
5698 t.Errorf("%q should be available to platform", libfoo2.String())
5699 }
Paul Duffine52e66f2020-03-30 17:54:29 +01005700}
Jiyong Parka90ca002019-10-07 15:47:24 +09005701
Paul Duffine52e66f2020-03-30 17:54:29 +01005702func TestApexAvailable_CreatedForApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005703 ctx := testApex(t, `
Jiyong Parka90ca002019-10-07 15:47:24 +09005704 apex {
5705 name: "myapex",
5706 key: "myapex.key",
5707 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005708 updatable: false,
Jiyong Parka90ca002019-10-07 15:47:24 +09005709 }
5710
5711 apex_key {
5712 name: "myapex.key",
5713 public_key: "testkey.avbpubkey",
5714 private_key: "testkey.pem",
5715 }
5716
5717 cc_library {
5718 name: "libfoo",
5719 stl: "none",
5720 system_shared_libs: [],
5721 apex_available: ["myapex"],
5722 static: {
5723 apex_available: ["//apex_available:platform"],
5724 },
5725 }`)
5726
Jiyong Park89e850a2020-04-07 16:37:39 +09005727 libfooShared := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
5728 if libfooShared.NotAvailableForPlatform() != true {
5729 t.Errorf("%q shouldn't be available to platform", libfooShared.String())
5730 }
5731 libfooStatic := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_static").Module().(*cc.Module)
5732 if libfooStatic.NotAvailableForPlatform() != false {
5733 t.Errorf("%q should be available to platform", libfooStatic.String())
5734 }
Jiyong Park127b40b2019-09-30 16:04:35 +09005735}
5736
Jiyong Park5d790c32019-11-15 18:40:32 +09005737func TestOverrideApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005738 ctx := testApex(t, `
Jiyong Park5d790c32019-11-15 18:40:32 +09005739 apex {
5740 name: "myapex",
5741 key: "myapex.key",
5742 apps: ["app"],
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08005743 overrides: ["oldapex"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005744 updatable: false,
Jiyong Park5d790c32019-11-15 18:40:32 +09005745 }
5746
5747 override_apex {
5748 name: "override_myapex",
5749 base: "myapex",
5750 apps: ["override_app"],
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08005751 overrides: ["unknownapex"],
Baligh Uddin004d7172020-02-19 21:29:28 -08005752 logging_parent: "com.foo.bar",
Baligh Uddin5b57dba2020-03-15 13:01:05 -07005753 package_name: "test.overridden.package",
Jaewoong Jung4cfdf7d2021-04-20 16:21:24 -07005754 key: "mynewapex.key",
5755 certificate: ":myapex.certificate",
Jiyong Park5d790c32019-11-15 18:40:32 +09005756 }
5757
5758 apex_key {
5759 name: "myapex.key",
5760 public_key: "testkey.avbpubkey",
5761 private_key: "testkey.pem",
5762 }
5763
Jaewoong Jung4cfdf7d2021-04-20 16:21:24 -07005764 apex_key {
5765 name: "mynewapex.key",
5766 public_key: "testkey2.avbpubkey",
5767 private_key: "testkey2.pem",
5768 }
5769
5770 android_app_certificate {
5771 name: "myapex.certificate",
5772 certificate: "testkey",
5773 }
5774
Jiyong Park5d790c32019-11-15 18:40:32 +09005775 android_app {
5776 name: "app",
5777 srcs: ["foo/bar/MyClass.java"],
5778 package_name: "foo",
5779 sdk_version: "none",
5780 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005781 apex_available: [ "myapex" ],
Jiyong Park5d790c32019-11-15 18:40:32 +09005782 }
5783
5784 override_android_app {
5785 name: "override_app",
5786 base: "app",
5787 package_name: "bar",
5788 }
Jiyong Park20bacab2020-03-03 11:45:41 +09005789 `, withManifestPackageNameOverrides([]string{"myapex:com.android.myapex"}))
Jiyong Park5d790c32019-11-15 18:40:32 +09005790
Jiyong Park317645e2019-12-05 13:20:58 +09005791 originalVariant := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(android.OverridableModule)
5792 overriddenVariant := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Module().(android.OverridableModule)
5793 if originalVariant.GetOverriddenBy() != "" {
5794 t.Errorf("GetOverriddenBy should be empty, but was %q", originalVariant.GetOverriddenBy())
5795 }
5796 if overriddenVariant.GetOverriddenBy() != "override_myapex" {
5797 t.Errorf("GetOverriddenBy should be \"override_myapex\", but was %q", overriddenVariant.GetOverriddenBy())
5798 }
5799
Jiyong Park5d790c32019-11-15 18:40:32 +09005800 module := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image")
5801 apexRule := module.Rule("apexRule")
5802 copyCmds := apexRule.Args["copy_commands"]
5803
5804 ensureNotContains(t, copyCmds, "image.apex/app/app/app.apk")
Jooyung Han39ee1192020-03-23 20:21:11 +09005805 ensureContains(t, copyCmds, "image.apex/app/override_app/override_app.apk")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005806
5807 apexBundle := module.Module().(*apexBundle)
5808 name := apexBundle.Name()
5809 if name != "override_myapex" {
5810 t.Errorf("name should be \"override_myapex\", but was %q", name)
5811 }
5812
Baligh Uddin004d7172020-02-19 21:29:28 -08005813 if apexBundle.overridableProperties.Logging_parent != "com.foo.bar" {
5814 t.Errorf("override_myapex should have logging parent (com.foo.bar), but was %q.", apexBundle.overridableProperties.Logging_parent)
5815 }
5816
Jiyong Park20bacab2020-03-03 11:45:41 +09005817 optFlags := apexRule.Args["opt_flags"]
Baligh Uddin5b57dba2020-03-15 13:01:05 -07005818 ensureContains(t, optFlags, "--override_apk_package_name test.overridden.package")
Jaewoong Jung4cfdf7d2021-04-20 16:21:24 -07005819 ensureContains(t, optFlags, "--pubkey testkey2.avbpubkey")
5820
5821 signApkRule := module.Rule("signapk")
5822 ensureEquals(t, signApkRule.Args["certificates"], "testkey.x509.pem testkey.pk8")
Jiyong Park20bacab2020-03-03 11:45:41 +09005823
Colin Crossaa255532020-07-03 13:18:24 -07005824 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005825 var builder strings.Builder
5826 data.Custom(&builder, name, "TARGET_", "", data)
5827 androidMk := builder.String()
Jiyong Parkf653b052019-11-18 15:39:01 +09005828 ensureContains(t, androidMk, "LOCAL_MODULE := override_app.override_myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005829 ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.override_myapex")
5830 ensureContains(t, androidMk, "LOCAL_MODULE_STEM := override_myapex.apex")
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08005831 ensureContains(t, androidMk, "LOCAL_OVERRIDES_MODULES := unknownapex myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005832 ensureNotContains(t, androidMk, "LOCAL_MODULE := app.myapex")
Jiyong Parkf653b052019-11-18 15:39:01 +09005833 ensureNotContains(t, androidMk, "LOCAL_MODULE := override_app.myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005834 ensureNotContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex")
5835 ensureNotContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.apex")
Jiyong Park5d790c32019-11-15 18:40:32 +09005836}
5837
Jooyung Han214bf372019-11-12 13:03:50 +09005838func TestLegacyAndroid10Support(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005839 ctx := testApex(t, `
Jooyung Han214bf372019-11-12 13:03:50 +09005840 apex {
5841 name: "myapex",
5842 key: "myapex.key",
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005843 native_shared_libs: ["mylib"],
Jooyung Han5417f772020-03-12 18:37:20 +09005844 min_sdk_version: "29",
Jooyung Han214bf372019-11-12 13:03:50 +09005845 }
5846
5847 apex_key {
5848 name: "myapex.key",
5849 public_key: "testkey.avbpubkey",
5850 private_key: "testkey.pem",
5851 }
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005852
5853 cc_library {
5854 name: "mylib",
5855 srcs: ["mylib.cpp"],
5856 stl: "libc++",
5857 system_shared_libs: [],
5858 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09005859 min_sdk_version: "29",
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005860 }
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005861 `, withUnbundledBuild)
Jooyung Han214bf372019-11-12 13:03:50 +09005862
5863 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
5864 args := module.Rule("apexRule").Args
5865 ensureContains(t, args["opt_flags"], "--manifest_json "+module.Output("apex_manifest.json").Output.String())
Dario Frenie3546902020-01-14 23:50:25 +00005866 ensureNotContains(t, args["opt_flags"], "--no_hashtree")
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005867
5868 // The copies of the libraries in the apex should have one more dependency than
5869 // the ones outside the apex, namely the unwinder. Ideally we should check
5870 // the dependency names directly here but for some reason the names are blank in
5871 // this test.
5872 for _, lib := range []string{"libc++", "mylib"} {
Colin Crossaede88c2020-08-11 12:17:01 -07005873 apexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared_apex29").Rule("ld").Implicits
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005874 nonApexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared").Rule("ld").Implicits
5875 if len(apexImplicits) != len(nonApexImplicits)+1 {
5876 t.Errorf("%q missing unwinder dep", lib)
5877 }
5878 }
Jooyung Han214bf372019-11-12 13:03:50 +09005879}
5880
Paul Duffine05480a2021-03-08 15:07:14 +00005881var filesForSdkLibrary = android.MockFS{
Paul Duffin9b879592020-05-26 13:21:35 +01005882 "api/current.txt": nil,
5883 "api/removed.txt": nil,
5884 "api/system-current.txt": nil,
5885 "api/system-removed.txt": nil,
5886 "api/test-current.txt": nil,
5887 "api/test-removed.txt": nil,
Paul Duffineedc5d52020-06-12 17:46:39 +01005888
Anton Hanssondff2c782020-12-21 17:10:01 +00005889 "100/public/api/foo.txt": nil,
5890 "100/public/api/foo-removed.txt": nil,
5891 "100/system/api/foo.txt": nil,
5892 "100/system/api/foo-removed.txt": nil,
5893
Paul Duffineedc5d52020-06-12 17:46:39 +01005894 // For java_sdk_library_import
5895 "a.jar": nil,
Paul Duffin9b879592020-05-26 13:21:35 +01005896}
5897
Jooyung Han58f26ab2019-12-18 15:34:32 +09005898func TestJavaSDKLibrary(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005899 ctx := testApex(t, `
Jooyung Han58f26ab2019-12-18 15:34:32 +09005900 apex {
5901 name: "myapex",
5902 key: "myapex.key",
5903 java_libs: ["foo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005904 updatable: false,
Jooyung Han58f26ab2019-12-18 15:34:32 +09005905 }
5906
5907 apex_key {
5908 name: "myapex.key",
5909 public_key: "testkey.avbpubkey",
5910 private_key: "testkey.pem",
5911 }
5912
5913 java_sdk_library {
5914 name: "foo",
5915 srcs: ["a.java"],
5916 api_packages: ["foo"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005917 apex_available: [ "myapex" ],
Jooyung Han58f26ab2019-12-18 15:34:32 +09005918 }
Anton Hanssondff2c782020-12-21 17:10:01 +00005919
5920 prebuilt_apis {
5921 name: "sdk",
5922 api_dirs: ["100"],
5923 }
Paul Duffin9b879592020-05-26 13:21:35 +01005924 `, withFiles(filesForSdkLibrary))
Jooyung Han58f26ab2019-12-18 15:34:32 +09005925
5926 // java_sdk_library installs both impl jar and permission XML
Jooyung Hana57af4a2020-01-23 05:36:59 +00005927 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Han58f26ab2019-12-18 15:34:32 +09005928 "javalib/foo.jar",
5929 "etc/permissions/foo.xml",
5930 })
5931 // Permission XML should point to the activated path of impl jar of java_sdk_library
Jiyong Parke3833882020-02-17 17:28:10 +09005932 sdkLibrary := ctx.ModuleForTests("foo.xml", "android_common_myapex").Rule("java_sdk_xml")
5933 ensureContains(t, sdkLibrary.RuleParams.Command, `<library name=\"foo\" file=\"/apex/myapex/javalib/foo.jar\"`)
Jooyung Han58f26ab2019-12-18 15:34:32 +09005934}
5935
Paul Duffin9b879592020-05-26 13:21:35 +01005936func TestJavaSDKLibrary_WithinApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005937 ctx := testApex(t, `
Paul Duffin9b879592020-05-26 13:21:35 +01005938 apex {
5939 name: "myapex",
5940 key: "myapex.key",
5941 java_libs: ["foo", "bar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005942 updatable: false,
Paul Duffin9b879592020-05-26 13:21:35 +01005943 }
5944
5945 apex_key {
5946 name: "myapex.key",
5947 public_key: "testkey.avbpubkey",
5948 private_key: "testkey.pem",
5949 }
5950
5951 java_sdk_library {
5952 name: "foo",
5953 srcs: ["a.java"],
5954 api_packages: ["foo"],
5955 apex_available: ["myapex"],
5956 sdk_version: "none",
5957 system_modules: "none",
5958 }
5959
5960 java_library {
5961 name: "bar",
5962 srcs: ["a.java"],
5963 libs: ["foo"],
5964 apex_available: ["myapex"],
5965 sdk_version: "none",
5966 system_modules: "none",
5967 }
Anton Hanssondff2c782020-12-21 17:10:01 +00005968
5969 prebuilt_apis {
5970 name: "sdk",
5971 api_dirs: ["100"],
5972 }
Paul Duffin9b879592020-05-26 13:21:35 +01005973 `, withFiles(filesForSdkLibrary))
5974
5975 // java_sdk_library installs both impl jar and permission XML
5976 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
5977 "javalib/bar.jar",
5978 "javalib/foo.jar",
5979 "etc/permissions/foo.xml",
5980 })
5981
5982 // The bar library should depend on the implementation jar.
5983 barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
Paul Duffincf8d7db2021-03-29 00:29:53 +01005984 if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Paul Duffin9b879592020-05-26 13:21:35 +01005985 t.Errorf("expected %q, found %#q", expected, actual)
5986 }
5987}
5988
5989func TestJavaSDKLibrary_CrossBoundary(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005990 ctx := testApex(t, `
Paul Duffin9b879592020-05-26 13:21:35 +01005991 apex {
5992 name: "myapex",
5993 key: "myapex.key",
5994 java_libs: ["foo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005995 updatable: false,
Paul Duffin9b879592020-05-26 13:21:35 +01005996 }
5997
5998 apex_key {
5999 name: "myapex.key",
6000 public_key: "testkey.avbpubkey",
6001 private_key: "testkey.pem",
6002 }
6003
6004 java_sdk_library {
6005 name: "foo",
6006 srcs: ["a.java"],
6007 api_packages: ["foo"],
6008 apex_available: ["myapex"],
6009 sdk_version: "none",
6010 system_modules: "none",
6011 }
6012
6013 java_library {
6014 name: "bar",
6015 srcs: ["a.java"],
6016 libs: ["foo"],
6017 sdk_version: "none",
6018 system_modules: "none",
6019 }
Anton Hanssondff2c782020-12-21 17:10:01 +00006020
6021 prebuilt_apis {
6022 name: "sdk",
6023 api_dirs: ["100"],
6024 }
Paul Duffin9b879592020-05-26 13:21:35 +01006025 `, withFiles(filesForSdkLibrary))
6026
6027 // java_sdk_library installs both impl jar and permission XML
6028 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
6029 "javalib/foo.jar",
6030 "etc/permissions/foo.xml",
6031 })
6032
6033 // The bar library should depend on the stubs jar.
6034 barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
Paul Duffincf8d7db2021-03-29 00:29:53 +01006035 if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Paul Duffin9b879592020-05-26 13:21:35 +01006036 t.Errorf("expected %q, found %#q", expected, actual)
6037 }
6038}
6039
Paul Duffineedc5d52020-06-12 17:46:39 +01006040func TestJavaSDKLibrary_ImportPreferred(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006041 ctx := testApex(t, `
Anton Hanssondff2c782020-12-21 17:10:01 +00006042 prebuilt_apis {
6043 name: "sdk",
6044 api_dirs: ["100"],
6045 }`,
Paul Duffineedc5d52020-06-12 17:46:39 +01006046 withFiles(map[string][]byte{
6047 "apex/a.java": nil,
6048 "apex/apex_manifest.json": nil,
6049 "apex/Android.bp": []byte(`
6050 package {
6051 default_visibility: ["//visibility:private"],
6052 }
6053
6054 apex {
6055 name: "myapex",
6056 key: "myapex.key",
6057 java_libs: ["foo", "bar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006058 updatable: false,
Paul Duffineedc5d52020-06-12 17:46:39 +01006059 }
6060
6061 apex_key {
6062 name: "myapex.key",
6063 public_key: "testkey.avbpubkey",
6064 private_key: "testkey.pem",
6065 }
6066
6067 java_library {
6068 name: "bar",
6069 srcs: ["a.java"],
6070 libs: ["foo"],
6071 apex_available: ["myapex"],
6072 sdk_version: "none",
6073 system_modules: "none",
6074 }
6075`),
6076 "source/a.java": nil,
6077 "source/api/current.txt": nil,
6078 "source/api/removed.txt": nil,
6079 "source/Android.bp": []byte(`
6080 package {
6081 default_visibility: ["//visibility:private"],
6082 }
6083
6084 java_sdk_library {
6085 name: "foo",
6086 visibility: ["//apex"],
6087 srcs: ["a.java"],
6088 api_packages: ["foo"],
6089 apex_available: ["myapex"],
6090 sdk_version: "none",
6091 system_modules: "none",
6092 public: {
6093 enabled: true,
6094 },
6095 }
6096`),
6097 "prebuilt/a.jar": nil,
6098 "prebuilt/Android.bp": []byte(`
6099 package {
6100 default_visibility: ["//visibility:private"],
6101 }
6102
6103 java_sdk_library_import {
6104 name: "foo",
6105 visibility: ["//apex", "//source"],
6106 apex_available: ["myapex"],
6107 prefer: true,
6108 public: {
6109 jars: ["a.jar"],
6110 },
6111 }
6112`),
Anton Hanssondff2c782020-12-21 17:10:01 +00006113 }), withFiles(filesForSdkLibrary),
Paul Duffineedc5d52020-06-12 17:46:39 +01006114 )
6115
6116 // java_sdk_library installs both impl jar and permission XML
6117 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
6118 "javalib/bar.jar",
6119 "javalib/foo.jar",
6120 "etc/permissions/foo.xml",
6121 })
6122
6123 // The bar library should depend on the implementation jar.
6124 barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
Paul Duffincf8d7db2021-03-29 00:29:53 +01006125 if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.impl\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Paul Duffineedc5d52020-06-12 17:46:39 +01006126 t.Errorf("expected %q, found %#q", expected, actual)
6127 }
6128}
6129
6130func TestJavaSDKLibrary_ImportOnly(t *testing.T) {
6131 testApexError(t, `java_libs: "foo" is not configured to be compiled into dex`, `
6132 apex {
6133 name: "myapex",
6134 key: "myapex.key",
6135 java_libs: ["foo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006136 updatable: false,
Paul Duffineedc5d52020-06-12 17:46:39 +01006137 }
6138
6139 apex_key {
6140 name: "myapex.key",
6141 public_key: "testkey.avbpubkey",
6142 private_key: "testkey.pem",
6143 }
6144
6145 java_sdk_library_import {
6146 name: "foo",
6147 apex_available: ["myapex"],
6148 prefer: true,
6149 public: {
6150 jars: ["a.jar"],
6151 },
6152 }
6153
6154 `, withFiles(filesForSdkLibrary))
6155}
6156
atrost6e126252020-01-27 17:01:16 +00006157func TestCompatConfig(t *testing.T) {
Paul Duffin284165a2021-03-29 01:50:31 +01006158 result := android.GroupFixturePreparers(
6159 prepareForApexTest,
6160 java.PrepareForTestWithPlatformCompatConfig,
6161 ).RunTestWithBp(t, `
atrost6e126252020-01-27 17:01:16 +00006162 apex {
6163 name: "myapex",
6164 key: "myapex.key",
Paul Duffin3abc1742021-03-15 19:32:23 +00006165 compat_configs: ["myjar-platform-compat-config"],
atrost6e126252020-01-27 17:01:16 +00006166 java_libs: ["myjar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006167 updatable: false,
atrost6e126252020-01-27 17:01:16 +00006168 }
6169
6170 apex_key {
6171 name: "myapex.key",
6172 public_key: "testkey.avbpubkey",
6173 private_key: "testkey.pem",
6174 }
6175
6176 platform_compat_config {
6177 name: "myjar-platform-compat-config",
6178 src: ":myjar",
6179 }
6180
6181 java_library {
6182 name: "myjar",
6183 srcs: ["foo/bar/MyClass.java"],
6184 sdk_version: "none",
6185 system_modules: "none",
atrost6e126252020-01-27 17:01:16 +00006186 apex_available: [ "myapex" ],
6187 }
Paul Duffin1b29e002021-03-16 15:06:54 +00006188
6189 // Make sure that a preferred prebuilt does not affect the apex contents.
6190 prebuilt_platform_compat_config {
6191 name: "myjar-platform-compat-config",
6192 metadata: "compat-config/metadata.xml",
6193 prefer: true,
6194 }
atrost6e126252020-01-27 17:01:16 +00006195 `)
Paul Duffina369c7b2021-03-09 03:08:05 +00006196 ctx := result.TestContext
atrost6e126252020-01-27 17:01:16 +00006197 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
6198 "etc/compatconfig/myjar-platform-compat-config.xml",
6199 "javalib/myjar.jar",
6200 })
6201}
6202
Jiyong Park479321d2019-12-16 11:47:12 +09006203func TestRejectNonInstallableJavaLibrary(t *testing.T) {
6204 testApexError(t, `"myjar" is not configured to be compiled into dex`, `
6205 apex {
6206 name: "myapex",
6207 key: "myapex.key",
6208 java_libs: ["myjar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006209 updatable: false,
Jiyong Park479321d2019-12-16 11:47:12 +09006210 }
6211
6212 apex_key {
6213 name: "myapex.key",
6214 public_key: "testkey.avbpubkey",
6215 private_key: "testkey.pem",
6216 }
6217
6218 java_library {
6219 name: "myjar",
6220 srcs: ["foo/bar/MyClass.java"],
6221 sdk_version: "none",
6222 system_modules: "none",
Jiyong Park6b21c7d2020-02-11 09:16:01 +09006223 compile_dex: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09006224 apex_available: ["myapex"],
Jiyong Park479321d2019-12-16 11:47:12 +09006225 }
6226 `)
6227}
6228
Jiyong Park7afd1072019-12-30 16:56:33 +09006229func TestCarryRequiredModuleNames(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006230 ctx := testApex(t, `
Jiyong Park7afd1072019-12-30 16:56:33 +09006231 apex {
6232 name: "myapex",
6233 key: "myapex.key",
6234 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006235 updatable: false,
Jiyong Park7afd1072019-12-30 16:56:33 +09006236 }
6237
6238 apex_key {
6239 name: "myapex.key",
6240 public_key: "testkey.avbpubkey",
6241 private_key: "testkey.pem",
6242 }
6243
6244 cc_library {
6245 name: "mylib",
6246 srcs: ["mylib.cpp"],
6247 system_shared_libs: [],
6248 stl: "none",
6249 required: ["a", "b"],
6250 host_required: ["c", "d"],
6251 target_required: ["e", "f"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00006252 apex_available: [ "myapex" ],
Jiyong Park7afd1072019-12-30 16:56:33 +09006253 }
6254 `)
6255
6256 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07006257 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jiyong Park7afd1072019-12-30 16:56:33 +09006258 name := apexBundle.BaseModuleName()
6259 prefix := "TARGET_"
6260 var builder strings.Builder
6261 data.Custom(&builder, name, prefix, "", data)
6262 androidMk := builder.String()
6263 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += a b\n")
6264 ensureContains(t, androidMk, "LOCAL_HOST_REQUIRED_MODULES += c d\n")
6265 ensureContains(t, androidMk, "LOCAL_TARGET_REQUIRED_MODULES += e f\n")
6266}
6267
Jiyong Park7cd10e32020-01-14 09:22:18 +09006268func TestSymlinksFromApexToSystem(t *testing.T) {
6269 bp := `
6270 apex {
6271 name: "myapex",
6272 key: "myapex.key",
6273 native_shared_libs: ["mylib"],
6274 java_libs: ["myjar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006275 updatable: false,
Jiyong Park7cd10e32020-01-14 09:22:18 +09006276 }
6277
Jiyong Park9d677202020-02-19 16:29:35 +09006278 apex {
6279 name: "myapex.updatable",
6280 key: "myapex.key",
6281 native_shared_libs: ["mylib"],
6282 java_libs: ["myjar"],
6283 updatable: true,
Jooyung Han548640b2020-04-27 12:10:30 +09006284 min_sdk_version: "current",
Jiyong Park9d677202020-02-19 16:29:35 +09006285 }
6286
Jiyong Park7cd10e32020-01-14 09:22:18 +09006287 apex_key {
6288 name: "myapex.key",
6289 public_key: "testkey.avbpubkey",
6290 private_key: "testkey.pem",
6291 }
6292
6293 cc_library {
6294 name: "mylib",
6295 srcs: ["mylib.cpp"],
6296 shared_libs: ["myotherlib"],
6297 system_shared_libs: [],
6298 stl: "none",
6299 apex_available: [
6300 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006301 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006302 "//apex_available:platform",
6303 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006304 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006305 }
6306
6307 cc_library {
6308 name: "myotherlib",
6309 srcs: ["mylib.cpp"],
6310 system_shared_libs: [],
6311 stl: "none",
6312 apex_available: [
6313 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006314 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006315 "//apex_available:platform",
6316 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006317 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006318 }
6319
6320 java_library {
6321 name: "myjar",
6322 srcs: ["foo/bar/MyClass.java"],
6323 sdk_version: "none",
6324 system_modules: "none",
6325 libs: ["myotherjar"],
Jiyong Park7cd10e32020-01-14 09:22:18 +09006326 apex_available: [
6327 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006328 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006329 "//apex_available:platform",
6330 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006331 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006332 }
6333
6334 java_library {
6335 name: "myotherjar",
6336 srcs: ["foo/bar/MyClass.java"],
6337 sdk_version: "none",
6338 system_modules: "none",
6339 apex_available: [
6340 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006341 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006342 "//apex_available:platform",
6343 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006344 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006345 }
6346 `
6347
6348 ensureRealfileExists := func(t *testing.T, files []fileInApex, file string) {
6349 for _, f := range files {
6350 if f.path == file {
6351 if f.isLink {
6352 t.Errorf("%q is not a real file", file)
6353 }
6354 return
6355 }
6356 }
6357 t.Errorf("%q is not found", file)
6358 }
6359
6360 ensureSymlinkExists := func(t *testing.T, files []fileInApex, file string) {
6361 for _, f := range files {
6362 if f.path == file {
6363 if !f.isLink {
6364 t.Errorf("%q is not a symlink", file)
6365 }
6366 return
6367 }
6368 }
6369 t.Errorf("%q is not found", file)
6370 }
6371
Jiyong Park9d677202020-02-19 16:29:35 +09006372 // For unbundled build, symlink shouldn't exist regardless of whether an APEX
6373 // is updatable or not
Colin Cross1c460562021-02-16 17:55:47 -08006374 ctx := testApex(t, bp, withUnbundledBuild)
Jooyung Hana57af4a2020-01-23 05:36:59 +00006375 files := getFiles(t, ctx, "myapex", "android_common_myapex_image")
Jiyong Park7cd10e32020-01-14 09:22:18 +09006376 ensureRealfileExists(t, files, "javalib/myjar.jar")
6377 ensureRealfileExists(t, files, "lib64/mylib.so")
6378 ensureRealfileExists(t, files, "lib64/myotherlib.so")
6379
Jiyong Park9d677202020-02-19 16:29:35 +09006380 files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
6381 ensureRealfileExists(t, files, "javalib/myjar.jar")
6382 ensureRealfileExists(t, files, "lib64/mylib.so")
6383 ensureRealfileExists(t, files, "lib64/myotherlib.so")
6384
6385 // For bundled build, symlink to the system for the non-updatable APEXes only
Colin Cross1c460562021-02-16 17:55:47 -08006386 ctx = testApex(t, bp)
Jooyung Hana57af4a2020-01-23 05:36:59 +00006387 files = getFiles(t, ctx, "myapex", "android_common_myapex_image")
Jiyong Park7cd10e32020-01-14 09:22:18 +09006388 ensureRealfileExists(t, files, "javalib/myjar.jar")
6389 ensureRealfileExists(t, files, "lib64/mylib.so")
6390 ensureSymlinkExists(t, files, "lib64/myotherlib.so") // this is symlink
Jiyong Park9d677202020-02-19 16:29:35 +09006391
6392 files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
6393 ensureRealfileExists(t, files, "javalib/myjar.jar")
6394 ensureRealfileExists(t, files, "lib64/mylib.so")
6395 ensureRealfileExists(t, files, "lib64/myotherlib.so") // this is a real file
Jiyong Park7cd10e32020-01-14 09:22:18 +09006396}
6397
Yo Chiange8128052020-07-23 20:09:18 +08006398func TestSymlinksFromApexToSystemRequiredModuleNames(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006399 ctx := testApex(t, `
Yo Chiange8128052020-07-23 20:09:18 +08006400 apex {
6401 name: "myapex",
6402 key: "myapex.key",
6403 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006404 updatable: false,
Yo Chiange8128052020-07-23 20:09:18 +08006405 }
6406
6407 apex_key {
6408 name: "myapex.key",
6409 public_key: "testkey.avbpubkey",
6410 private_key: "testkey.pem",
6411 }
6412
6413 cc_library_shared {
6414 name: "mylib",
6415 srcs: ["mylib.cpp"],
6416 shared_libs: ["myotherlib"],
6417 system_shared_libs: [],
6418 stl: "none",
6419 apex_available: [
6420 "myapex",
6421 "//apex_available:platform",
6422 ],
6423 }
6424
6425 cc_prebuilt_library_shared {
6426 name: "myotherlib",
6427 srcs: ["prebuilt.so"],
6428 system_shared_libs: [],
6429 stl: "none",
6430 apex_available: [
6431 "myapex",
6432 "//apex_available:platform",
6433 ],
6434 }
6435 `)
6436
6437 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07006438 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Yo Chiange8128052020-07-23 20:09:18 +08006439 var builder strings.Builder
6440 data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
6441 androidMk := builder.String()
6442 // `myotherlib` is added to `myapex` as symlink
6443 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
6444 ensureNotContains(t, androidMk, "LOCAL_MODULE := prebuilt_myotherlib.myapex\n")
6445 ensureNotContains(t, androidMk, "LOCAL_MODULE := myotherlib.myapex\n")
6446 // `myapex` should have `myotherlib` in its required line, not `prebuilt_myotherlib`
Jiyong Park57621b22021-01-20 20:33:11 +09006447 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += mylib.myapex:64 myotherlib:64 apex_manifest.pb.myapex apex_pubkey.myapex\n")
Yo Chiange8128052020-07-23 20:09:18 +08006448}
6449
Jooyung Han643adc42020-02-27 13:50:06 +09006450func TestApexWithJniLibs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006451 ctx := testApex(t, `
Jooyung Han643adc42020-02-27 13:50:06 +09006452 apex {
6453 name: "myapex",
6454 key: "myapex.key",
6455 jni_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006456 updatable: false,
Jooyung Han643adc42020-02-27 13:50:06 +09006457 }
6458
6459 apex_key {
6460 name: "myapex.key",
6461 public_key: "testkey.avbpubkey",
6462 private_key: "testkey.pem",
6463 }
6464
6465 cc_library {
6466 name: "mylib",
6467 srcs: ["mylib.cpp"],
6468 shared_libs: ["mylib2"],
6469 system_shared_libs: [],
6470 stl: "none",
6471 apex_available: [ "myapex" ],
6472 }
6473
6474 cc_library {
6475 name: "mylib2",
6476 srcs: ["mylib.cpp"],
6477 system_shared_libs: [],
6478 stl: "none",
6479 apex_available: [ "myapex" ],
6480 }
6481 `)
6482
6483 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
6484 // Notice mylib2.so (transitive dep) is not added as a jni_lib
6485 ensureEquals(t, rule.Args["opt"], "-a jniLibs mylib.so")
6486 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
6487 "lib64/mylib.so",
6488 "lib64/mylib2.so",
6489 })
6490}
6491
Jooyung Han49f67012020-04-17 13:43:10 +09006492func TestApexMutatorsDontRunIfDisabled(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006493 ctx := testApex(t, `
Jooyung Han49f67012020-04-17 13:43:10 +09006494 apex {
6495 name: "myapex",
6496 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006497 updatable: false,
Jooyung Han49f67012020-04-17 13:43:10 +09006498 }
6499 apex_key {
6500 name: "myapex.key",
6501 public_key: "testkey.avbpubkey",
6502 private_key: "testkey.pem",
6503 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00006504 `,
6505 android.FixtureModifyConfig(func(config android.Config) {
6506 delete(config.Targets, android.Android)
6507 config.AndroidCommonTarget = android.Target{}
6508 }),
6509 )
Jooyung Han49f67012020-04-17 13:43:10 +09006510
6511 if expected, got := []string{""}, ctx.ModuleVariantsForTests("myapex"); !reflect.DeepEqual(expected, got) {
6512 t.Errorf("Expected variants: %v, but got: %v", expected, got)
6513 }
6514}
6515
Jiyong Parkbd159612020-02-28 15:22:21 +09006516func TestAppBundle(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006517 ctx := testApex(t, `
Jiyong Parkbd159612020-02-28 15:22:21 +09006518 apex {
6519 name: "myapex",
6520 key: "myapex.key",
6521 apps: ["AppFoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006522 updatable: false,
Jiyong Parkbd159612020-02-28 15:22:21 +09006523 }
6524
6525 apex_key {
6526 name: "myapex.key",
6527 public_key: "testkey.avbpubkey",
6528 private_key: "testkey.pem",
6529 }
6530
6531 android_app {
6532 name: "AppFoo",
6533 srcs: ["foo/bar/MyClass.java"],
6534 sdk_version: "none",
6535 system_modules: "none",
6536 apex_available: [ "myapex" ],
6537 }
Jiyong Parkcfaa1642020-02-28 16:51:07 +09006538 `, withManifestPackageNameOverrides([]string{"AppFoo:com.android.foo"}))
Jiyong Parkbd159612020-02-28 15:22:21 +09006539
Colin Crosscf371cc2020-11-13 11:48:42 -08006540 bundleConfigRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("bundle_config.json")
Jiyong Parkbd159612020-02-28 15:22:21 +09006541 content := bundleConfigRule.Args["content"]
6542
6543 ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
Jiyong Parkcfaa1642020-02-28 16:51:07 +09006544 ensureContains(t, content, `"apex_config":{"apex_embedded_apk_config":[{"package_name":"com.android.foo","path":"app/AppFoo/AppFoo.apk"}]}`)
Jiyong Parkbd159612020-02-28 15:22:21 +09006545}
6546
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006547func TestAppSetBundle(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006548 ctx := testApex(t, `
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006549 apex {
6550 name: "myapex",
6551 key: "myapex.key",
6552 apps: ["AppSet"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006553 updatable: false,
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006554 }
6555
6556 apex_key {
6557 name: "myapex.key",
6558 public_key: "testkey.avbpubkey",
6559 private_key: "testkey.pem",
6560 }
6561
6562 android_app_set {
6563 name: "AppSet",
6564 set: "AppSet.apks",
6565 }`)
6566 mod := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Colin Crosscf371cc2020-11-13 11:48:42 -08006567 bundleConfigRule := mod.Output("bundle_config.json")
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006568 content := bundleConfigRule.Args["content"]
6569 ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
6570 s := mod.Rule("apexRule").Args["copy_commands"]
6571 copyCmds := regexp.MustCompile(" *&& *").Split(s, -1)
6572 if len(copyCmds) != 3 {
6573 t.Fatalf("Expected 3 commands, got %d in:\n%s", len(copyCmds), s)
6574 }
6575 ensureMatches(t, copyCmds[0], "^rm -rf .*/app/AppSet$")
6576 ensureMatches(t, copyCmds[1], "^mkdir -p .*/app/AppSet$")
6577 ensureMatches(t, copyCmds[2], "^unzip .*-d .*/app/AppSet .*/AppSet.zip$")
6578}
6579
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006580func TestAppSetBundlePrebuilt(t *testing.T) {
Paul Duffin24704672021-04-06 16:09:30 +01006581 bp := `
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006582 apex_set {
6583 name: "myapex",
6584 filename: "foo_v2.apex",
6585 sanitized: {
6586 none: { set: "myapex.apks", },
6587 hwaddress: { set: "myapex.hwasan.apks", },
6588 },
Paul Duffin24704672021-04-06 16:09:30 +01006589 }
6590 `
6591 ctx := testApex(t, bp, prepareForTestWithSantitizeHwaddress)
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006592
Paul Duffin24704672021-04-06 16:09:30 +01006593 // Check that the extractor produces the correct output file from the correct input file.
6594 extractorOutput := "out/soong/.intermediates/myapex.apex.extractor/android_common/extracted/myapex.hwasan.apks"
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006595
Paul Duffin24704672021-04-06 16:09:30 +01006596 m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
6597 extractedApex := m.Output(extractorOutput)
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006598
Paul Duffin24704672021-04-06 16:09:30 +01006599 android.AssertArrayString(t, "extractor input", []string{"myapex.hwasan.apks"}, extractedApex.Inputs.Strings())
6600
6601 // Ditto for the apex.
Paul Duffin6717d882021-06-15 19:09:41 +01006602 m = ctx.ModuleForTests("myapex", "android_common_myapex")
6603 copiedApex := m.Output("out/soong/.intermediates/myapex/android_common_myapex/foo_v2.apex")
Paul Duffin24704672021-04-06 16:09:30 +01006604
6605 android.AssertStringEquals(t, "myapex input", extractorOutput, copiedApex.Input.String())
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006606}
6607
Paul Duffin89f570a2021-06-16 01:42:33 +01006608func testNoUpdatableJarsInBootImage(t *testing.T, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) {
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006609 t.Helper()
6610
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006611 bp := `
6612 java_library {
6613 name: "some-updatable-apex-lib",
6614 srcs: ["a.java"],
6615 sdk_version: "current",
6616 apex_available: [
6617 "some-updatable-apex",
6618 ],
6619 }
6620
6621 java_library {
6622 name: "some-non-updatable-apex-lib",
6623 srcs: ["a.java"],
6624 apex_available: [
6625 "some-non-updatable-apex",
6626 ],
Paul Duffin89f570a2021-06-16 01:42:33 +01006627 compile_dex: true,
6628 }
6629
6630 bootclasspath_fragment {
6631 name: "some-non-updatable-fragment",
6632 contents: ["some-non-updatable-apex-lib"],
6633 apex_available: [
6634 "some-non-updatable-apex",
6635 ],
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006636 }
6637
6638 java_library {
6639 name: "some-platform-lib",
6640 srcs: ["a.java"],
6641 sdk_version: "current",
6642 installable: true,
6643 }
6644
6645 java_library {
6646 name: "some-art-lib",
6647 srcs: ["a.java"],
6648 sdk_version: "current",
6649 apex_available: [
Paul Duffind376f792021-01-26 11:59:35 +00006650 "com.android.art.debug",
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006651 ],
6652 hostdex: true,
Paul Duffine5218812021-06-07 13:28:19 +01006653 compile_dex: true,
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006654 }
6655
6656 apex {
6657 name: "some-updatable-apex",
6658 key: "some-updatable-apex.key",
6659 java_libs: ["some-updatable-apex-lib"],
6660 updatable: true,
6661 min_sdk_version: "current",
6662 }
6663
6664 apex {
6665 name: "some-non-updatable-apex",
6666 key: "some-non-updatable-apex.key",
Paul Duffin89f570a2021-06-16 01:42:33 +01006667 bootclasspath_fragments: ["some-non-updatable-fragment"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006668 updatable: false,
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006669 }
6670
6671 apex_key {
6672 name: "some-updatable-apex.key",
6673 }
6674
6675 apex_key {
6676 name: "some-non-updatable-apex.key",
6677 }
6678
6679 apex {
Paul Duffind376f792021-01-26 11:59:35 +00006680 name: "com.android.art.debug",
6681 key: "com.android.art.debug.key",
Paul Duffin89f570a2021-06-16 01:42:33 +01006682 bootclasspath_fragments: ["art-bootclasspath-fragment"],
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006683 updatable: true,
6684 min_sdk_version: "current",
6685 }
6686
Paul Duffinf23bc472021-04-27 12:42:20 +01006687 bootclasspath_fragment {
6688 name: "art-bootclasspath-fragment",
6689 image_name: "art",
6690 contents: ["some-art-lib"],
6691 apex_available: [
6692 "com.android.art.debug",
6693 ],
6694 }
6695
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006696 apex_key {
Paul Duffind376f792021-01-26 11:59:35 +00006697 name: "com.android.art.debug.key",
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006698 }
6699
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006700 filegroup {
6701 name: "some-updatable-apex-file_contexts",
6702 srcs: [
6703 "system/sepolicy/apex/some-updatable-apex-file_contexts",
6704 ],
6705 }
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01006706
6707 filegroup {
6708 name: "some-non-updatable-apex-file_contexts",
6709 srcs: [
6710 "system/sepolicy/apex/some-non-updatable-apex-file_contexts",
6711 ],
6712 }
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006713 `
Paul Duffinc3bbb962020-12-10 19:15:49 +00006714
Paul Duffin89f570a2021-06-16 01:42:33 +01006715 testDexpreoptWithApexes(t, bp, errmsg, preparer, fragments...)
Paul Duffinc3bbb962020-12-10 19:15:49 +00006716}
6717
Paul Duffin89f570a2021-06-16 01:42:33 +01006718func testDexpreoptWithApexes(t *testing.T, bp, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) *android.TestContext {
Paul Duffinc3bbb962020-12-10 19:15:49 +00006719 t.Helper()
6720
Paul Duffin55607122021-03-30 23:32:51 +01006721 fs := android.MockFS{
6722 "a.java": nil,
6723 "a.jar": nil,
6724 "apex_manifest.json": nil,
6725 "AndroidManifest.xml": nil,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00006726 "system/sepolicy/apex/myapex-file_contexts": nil,
Paul Duffind376f792021-01-26 11:59:35 +00006727 "system/sepolicy/apex/some-updatable-apex-file_contexts": nil,
6728 "system/sepolicy/apex/some-non-updatable-apex-file_contexts": nil,
6729 "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00006730 "framework/aidl/a.aidl": nil,
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006731 }
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006732
Paul Duffin55607122021-03-30 23:32:51 +01006733 errorHandler := android.FixtureExpectsNoErrors
6734 if errmsg != "" {
6735 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006736 }
Paul Duffin064b70c2020-11-02 17:32:38 +00006737
Paul Duffin55607122021-03-30 23:32:51 +01006738 result := android.GroupFixturePreparers(
6739 cc.PrepareForTestWithCcDefaultModules,
6740 java.PrepareForTestWithHiddenApiBuildComponents,
6741 java.PrepareForTestWithJavaDefaultModules,
6742 java.PrepareForTestWithJavaSdkLibraryFiles,
6743 PrepareForTestWithApexBuildComponents,
Paul Duffin60264a02021-04-12 20:02:36 +01006744 preparer,
Paul Duffin55607122021-03-30 23:32:51 +01006745 fs.AddToFixture(),
Paul Duffin89f570a2021-06-16 01:42:33 +01006746 android.FixtureModifyMockFS(func(fs android.MockFS) {
6747 if _, ok := fs["frameworks/base/boot/Android.bp"]; !ok {
6748 insert := ""
6749 for _, fragment := range fragments {
6750 insert += fmt.Sprintf("{apex: %q, module: %q},\n", *fragment.Apex, *fragment.Module)
6751 }
6752 fs["frameworks/base/boot/Android.bp"] = []byte(fmt.Sprintf(`
6753 platform_bootclasspath {
6754 name: "platform-bootclasspath",
6755 fragments: [
6756 %s
6757 ],
6758 }
6759 `, insert))
Paul Duffin8f146b92021-04-12 17:24:18 +01006760 }
Paul Duffin89f570a2021-06-16 01:42:33 +01006761 }),
Paul Duffin55607122021-03-30 23:32:51 +01006762 ).
6763 ExtendWithErrorHandler(errorHandler).
6764 RunTestWithBp(t, bp)
6765
6766 return result.TestContext
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006767}
6768
Jooyung Han548640b2020-04-27 12:10:30 +09006769func TestUpdatable_should_set_min_sdk_version(t *testing.T) {
6770 testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
6771 apex {
6772 name: "myapex",
6773 key: "myapex.key",
6774 updatable: true,
6775 }
6776
6777 apex_key {
6778 name: "myapex.key",
6779 public_key: "testkey.avbpubkey",
6780 private_key: "testkey.pem",
6781 }
6782 `)
6783}
6784
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006785func TestUpdatableDefault_should_set_min_sdk_version(t *testing.T) {
6786 testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
6787 apex {
6788 name: "myapex",
6789 key: "myapex.key",
6790 }
6791
6792 apex_key {
6793 name: "myapex.key",
6794 public_key: "testkey.avbpubkey",
6795 private_key: "testkey.pem",
6796 }
6797 `)
6798}
6799
satayevb98371c2021-06-15 16:49:50 +01006800func TestUpdatable_should_not_set_generate_classpaths_proto(t *testing.T) {
6801 testApexError(t, `"mysystemserverclasspathfragment" .* it must not set generate_classpaths_proto to false`, `
6802 apex {
6803 name: "myapex",
6804 key: "myapex.key",
6805 systemserverclasspath_fragments: [
6806 "mysystemserverclasspathfragment",
6807 ],
6808 min_sdk_version: "29",
6809 updatable: true,
6810 }
6811
6812 apex_key {
6813 name: "myapex.key",
6814 public_key: "testkey.avbpubkey",
6815 private_key: "testkey.pem",
6816 }
6817
6818 java_library {
6819 name: "foo",
6820 srcs: ["b.java"],
6821 min_sdk_version: "29",
6822 installable: true,
6823 apex_available: [
6824 "myapex",
6825 ],
6826 }
6827
6828 systemserverclasspath_fragment {
6829 name: "mysystemserverclasspathfragment",
6830 generate_classpaths_proto: false,
6831 contents: [
6832 "foo",
6833 ],
6834 apex_available: [
6835 "myapex",
6836 ],
6837 }
6838 `)
6839}
6840
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006841func TestNoUpdatableJarsInBootImage(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006842 // Set the BootJars in dexpreopt.GlobalConfig and productVariables to the same value. This can
6843 // result in an invalid configuration as it does not set the ArtApexJars and allows art apex
6844 // modules to be included in the BootJars.
6845 prepareSetBootJars := func(bootJars ...string) android.FixturePreparer {
6846 return android.GroupFixturePreparers(
6847 dexpreopt.FixtureSetBootJars(bootJars...),
6848 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
6849 variables.BootJars = android.CreateTestConfiguredJarList(bootJars)
6850 }),
6851 )
6852 }
6853
6854 // Set the ArtApexJars and BootJars in dexpreopt.GlobalConfig and productVariables all to the
6855 // same value. This can result in an invalid configuration as it allows non art apex jars to be
6856 // specified in the ArtApexJars configuration.
6857 prepareSetArtJars := func(bootJars ...string) android.FixturePreparer {
6858 return android.GroupFixturePreparers(
6859 dexpreopt.FixtureSetArtBootJars(bootJars...),
6860 dexpreopt.FixtureSetBootJars(bootJars...),
6861 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
6862 variables.BootJars = android.CreateTestConfiguredJarList(bootJars)
6863 }),
6864 )
6865 }
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006866
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006867 t.Run("updatable jar from ART apex in the ART boot image => ok", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006868 preparer := java.FixtureConfigureBootJars("com.android.art.debug:some-art-lib")
Paul Duffin89f570a2021-06-16 01:42:33 +01006869 fragment := java.ApexVariantReference{
6870 Apex: proptools.StringPtr("com.android.art.debug"),
6871 Module: proptools.StringPtr("art-bootclasspath-fragment"),
6872 }
6873 testNoUpdatableJarsInBootImage(t, "", preparer, fragment)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006874 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006875
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006876 t.Run("updatable jar from ART apex in the framework boot image => error", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006877 err := `module "some-art-lib" from updatable apexes \["com.android.art.debug"\] is not allowed in the framework boot image`
6878 // Update the dexpreopt BootJars directly.
6879 preparer := prepareSetBootJars("com.android.art.debug:some-art-lib")
6880 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006881 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006882
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006883 t.Run("updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
Paul Duffinf23bc472021-04-27 12:42:20 +01006884 err := `ArtApexJars expects this to be in apex "some-updatable-apex" but this is only in apexes.*"com.android.art.debug"`
Paul Duffin60264a02021-04-12 20:02:36 +01006885 // Update the dexpreopt ArtApexJars directly.
6886 preparer := prepareSetArtJars("some-updatable-apex:some-updatable-apex-lib")
6887 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006888 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006889
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006890 t.Run("non-updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
Paul Duffinf23bc472021-04-27 12:42:20 +01006891 err := `ArtApexJars expects this to be in apex "some-non-updatable-apex" but this is only in apexes.*"com.android.art.debug"`
Paul Duffin60264a02021-04-12 20:02:36 +01006892 // Update the dexpreopt ArtApexJars directly.
6893 preparer := prepareSetArtJars("some-non-updatable-apex:some-non-updatable-apex-lib")
6894 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006895 })
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01006896
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006897 t.Run("updatable jar from some other apex in the framework boot image => error", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006898 err := `module "some-updatable-apex-lib" from updatable apexes \["some-updatable-apex"\] is not allowed in the framework boot image`
6899 preparer := java.FixtureConfigureBootJars("some-updatable-apex:some-updatable-apex-lib")
6900 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006901 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006902
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006903 t.Run("non-updatable jar from some other apex in the framework boot image => ok", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006904 preparer := java.FixtureConfigureBootJars("some-non-updatable-apex:some-non-updatable-apex-lib")
Paul Duffin89f570a2021-06-16 01:42:33 +01006905 fragment := java.ApexVariantReference{
6906 Apex: proptools.StringPtr("some-non-updatable-apex"),
6907 Module: proptools.StringPtr("some-non-updatable-fragment"),
6908 }
6909 testNoUpdatableJarsInBootImage(t, "", preparer, fragment)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006910 })
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01006911
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006912 t.Run("nonexistent jar in the ART boot image => error", func(t *testing.T) {
Paul Duffin8f146b92021-04-12 17:24:18 +01006913 err := `"platform-bootclasspath" depends on undefined module "nonexistent"`
Paul Duffin60264a02021-04-12 20:02:36 +01006914 preparer := java.FixtureConfigureBootJars("platform:nonexistent")
6915 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006916 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006917
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006918 t.Run("nonexistent jar in the framework boot image => error", func(t *testing.T) {
Paul Duffin8f146b92021-04-12 17:24:18 +01006919 err := `"platform-bootclasspath" depends on undefined module "nonexistent"`
Paul Duffin60264a02021-04-12 20:02:36 +01006920 preparer := java.FixtureConfigureBootJars("platform:nonexistent")
6921 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006922 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006923
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006924 t.Run("platform jar in the ART boot image => error", func(t *testing.T) {
Paul Duffinf23bc472021-04-27 12:42:20 +01006925 err := `ArtApexJars is invalid as it requests a platform variant of "some-platform-lib"`
Paul Duffin60264a02021-04-12 20:02:36 +01006926 // Update the dexpreopt ArtApexJars directly.
6927 preparer := prepareSetArtJars("platform:some-platform-lib")
6928 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006929 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006930
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006931 t.Run("platform jar in the framework boot image => ok", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006932 preparer := java.FixtureConfigureBootJars("platform:some-platform-lib")
6933 testNoUpdatableJarsInBootImage(t, "", preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006934 })
Paul Duffin064b70c2020-11-02 17:32:38 +00006935}
6936
6937func TestDexpreoptAccessDexFilesFromPrebuiltApex(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006938 preparer := java.FixtureConfigureBootJars("myapex:libfoo")
Paul Duffin064b70c2020-11-02 17:32:38 +00006939 t.Run("prebuilt no source", func(t *testing.T) {
Paul Duffin89f570a2021-06-16 01:42:33 +01006940 fragment := java.ApexVariantReference{
6941 Apex: proptools.StringPtr("myapex"),
6942 Module: proptools.StringPtr("my-bootclasspath-fragment"),
6943 }
6944
Paul Duffin064b70c2020-11-02 17:32:38 +00006945 testDexpreoptWithApexes(t, `
6946 prebuilt_apex {
6947 name: "myapex" ,
6948 arch: {
6949 arm64: {
6950 src: "myapex-arm64.apex",
6951 },
6952 arm: {
6953 src: "myapex-arm.apex",
6954 },
6955 },
Paul Duffin89f570a2021-06-16 01:42:33 +01006956 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
6957 }
Paul Duffin064b70c2020-11-02 17:32:38 +00006958
Paul Duffin89f570a2021-06-16 01:42:33 +01006959 prebuilt_bootclasspath_fragment {
6960 name: "my-bootclasspath-fragment",
6961 contents: ["libfoo"],
6962 apex_available: ["myapex"],
6963 }
Paul Duffin064b70c2020-11-02 17:32:38 +00006964
Paul Duffin89f570a2021-06-16 01:42:33 +01006965 java_import {
6966 name: "libfoo",
6967 jars: ["libfoo.jar"],
6968 apex_available: ["myapex"],
6969 }
6970 `, "", preparer, fragment)
Paul Duffin064b70c2020-11-02 17:32:38 +00006971 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006972}
6973
Andrei Onea115e7e72020-06-05 21:14:03 +01006974func testApexPermittedPackagesRules(t *testing.T, errmsg, bp string, apexBootJars []string, rules []android.Rule) {
6975 t.Helper()
Andrei Onea115e7e72020-06-05 21:14:03 +01006976 bp += `
6977 apex_key {
6978 name: "myapex.key",
6979 public_key: "testkey.avbpubkey",
6980 private_key: "testkey.pem",
6981 }`
Paul Duffin45338f02021-03-30 23:07:52 +01006982 fs := android.MockFS{
Andrei Onea115e7e72020-06-05 21:14:03 +01006983 "lib1/src/A.java": nil,
6984 "lib2/src/B.java": nil,
6985 "system/sepolicy/apex/myapex-file_contexts": nil,
6986 }
6987
Paul Duffin45338f02021-03-30 23:07:52 +01006988 errorHandler := android.FixtureExpectsNoErrors
6989 if errmsg != "" {
6990 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
Colin Crossae8600b2020-10-29 17:09:13 -07006991 }
Colin Crossae8600b2020-10-29 17:09:13 -07006992
Paul Duffin45338f02021-03-30 23:07:52 +01006993 android.GroupFixturePreparers(
6994 android.PrepareForTestWithAndroidBuildComponents,
6995 java.PrepareForTestWithJavaBuildComponents,
6996 PrepareForTestWithApexBuildComponents,
6997 android.PrepareForTestWithNeverallowRules(rules),
6998 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
6999 updatableBootJars := make([]string, 0, len(apexBootJars))
7000 for _, apexBootJar := range apexBootJars {
7001 updatableBootJars = append(updatableBootJars, "myapex:"+apexBootJar)
7002 }
7003 variables.UpdatableBootJars = android.CreateTestConfiguredJarList(updatableBootJars)
7004 }),
7005 fs.AddToFixture(),
7006 ).
7007 ExtendWithErrorHandler(errorHandler).
7008 RunTestWithBp(t, bp)
Andrei Onea115e7e72020-06-05 21:14:03 +01007009}
7010
7011func TestApexPermittedPackagesRules(t *testing.T) {
7012 testcases := []struct {
7013 name string
7014 expectedError string
7015 bp string
7016 bootJars []string
7017 modulesPackages map[string][]string
7018 }{
7019
7020 {
7021 name: "Non-Bootclasspath apex jar not satisfying allowed module packages.",
7022 expectedError: "",
7023 bp: `
7024 java_library {
7025 name: "bcp_lib1",
7026 srcs: ["lib1/src/*.java"],
7027 permitted_packages: ["foo.bar"],
7028 apex_available: ["myapex"],
7029 sdk_version: "none",
7030 system_modules: "none",
7031 }
7032 java_library {
7033 name: "nonbcp_lib2",
7034 srcs: ["lib2/src/*.java"],
7035 apex_available: ["myapex"],
7036 permitted_packages: ["a.b"],
7037 sdk_version: "none",
7038 system_modules: "none",
7039 }
7040 apex {
7041 name: "myapex",
7042 key: "myapex.key",
7043 java_libs: ["bcp_lib1", "nonbcp_lib2"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007044 updatable: false,
Andrei Onea115e7e72020-06-05 21:14:03 +01007045 }`,
7046 bootJars: []string{"bcp_lib1"},
7047 modulesPackages: map[string][]string{
7048 "myapex": []string{
7049 "foo.bar",
7050 },
7051 },
7052 },
7053 {
7054 name: "Bootclasspath apex jar not satisfying allowed module packages.",
7055 expectedError: `module "bcp_lib2" .* which is restricted because jars that are part of the myapex module may only allow these packages: foo.bar. Please jarjar or move code around.`,
7056 bp: `
7057 java_library {
7058 name: "bcp_lib1",
7059 srcs: ["lib1/src/*.java"],
7060 apex_available: ["myapex"],
7061 permitted_packages: ["foo.bar"],
7062 sdk_version: "none",
7063 system_modules: "none",
7064 }
7065 java_library {
7066 name: "bcp_lib2",
7067 srcs: ["lib2/src/*.java"],
7068 apex_available: ["myapex"],
7069 permitted_packages: ["foo.bar", "bar.baz"],
7070 sdk_version: "none",
7071 system_modules: "none",
7072 }
7073 apex {
7074 name: "myapex",
7075 key: "myapex.key",
7076 java_libs: ["bcp_lib1", "bcp_lib2"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007077 updatable: false,
Andrei Onea115e7e72020-06-05 21:14:03 +01007078 }
7079 `,
7080 bootJars: []string{"bcp_lib1", "bcp_lib2"},
7081 modulesPackages: map[string][]string{
7082 "myapex": []string{
7083 "foo.bar",
7084 },
7085 },
7086 },
7087 }
7088 for _, tc := range testcases {
7089 t.Run(tc.name, func(t *testing.T) {
7090 rules := createApexPermittedPackagesRules(tc.modulesPackages)
7091 testApexPermittedPackagesRules(t, tc.expectedError, tc.bp, tc.bootJars, rules)
7092 })
7093 }
7094}
7095
Jiyong Park62304bb2020-04-13 16:19:48 +09007096func TestTestFor(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007097 ctx := testApex(t, `
Jiyong Park62304bb2020-04-13 16:19:48 +09007098 apex {
7099 name: "myapex",
7100 key: "myapex.key",
7101 native_shared_libs: ["mylib", "myprivlib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007102 updatable: false,
Jiyong Park62304bb2020-04-13 16:19:48 +09007103 }
7104
7105 apex_key {
7106 name: "myapex.key",
7107 public_key: "testkey.avbpubkey",
7108 private_key: "testkey.pem",
7109 }
7110
7111 cc_library {
7112 name: "mylib",
7113 srcs: ["mylib.cpp"],
7114 system_shared_libs: [],
7115 stl: "none",
7116 stubs: {
7117 versions: ["1"],
7118 },
7119 apex_available: ["myapex"],
7120 }
7121
7122 cc_library {
7123 name: "myprivlib",
7124 srcs: ["mylib.cpp"],
7125 system_shared_libs: [],
7126 stl: "none",
7127 apex_available: ["myapex"],
7128 }
7129
7130
7131 cc_test {
7132 name: "mytest",
7133 gtest: false,
7134 srcs: ["mylib.cpp"],
7135 system_shared_libs: [],
7136 stl: "none",
Jiyong Park46a512f2020-12-04 18:02:13 +09007137 shared_libs: ["mylib", "myprivlib", "mytestlib"],
Jiyong Park62304bb2020-04-13 16:19:48 +09007138 test_for: ["myapex"]
7139 }
Jiyong Park46a512f2020-12-04 18:02:13 +09007140
7141 cc_library {
7142 name: "mytestlib",
7143 srcs: ["mylib.cpp"],
7144 system_shared_libs: [],
7145 shared_libs: ["mylib", "myprivlib"],
7146 stl: "none",
7147 test_for: ["myapex"],
7148 }
7149
7150 cc_benchmark {
7151 name: "mybench",
7152 srcs: ["mylib.cpp"],
7153 system_shared_libs: [],
7154 shared_libs: ["mylib", "myprivlib"],
7155 stl: "none",
7156 test_for: ["myapex"],
7157 }
Jiyong Park62304bb2020-04-13 16:19:48 +09007158 `)
7159
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007160 ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
Paul Duffina71a67a2021-03-29 00:42:57 +01007161 ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007162 mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
7163 android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
7164 }
7165
7166 // These modules are tests for the apex, therefore are linked to the
Jiyong Park62304bb2020-04-13 16:19:48 +09007167 // actual implementation of mylib instead of its stub.
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007168 ensureLinkedLibIs("mytest", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
7169 ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
7170 ensureLinkedLibIs("mybench", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
7171}
Jiyong Park46a512f2020-12-04 18:02:13 +09007172
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007173func TestIndirectTestFor(t *testing.T) {
7174 ctx := testApex(t, `
7175 apex {
7176 name: "myapex",
7177 key: "myapex.key",
7178 native_shared_libs: ["mylib", "myprivlib"],
7179 updatable: false,
7180 }
Jiyong Park46a512f2020-12-04 18:02:13 +09007181
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007182 apex_key {
7183 name: "myapex.key",
7184 public_key: "testkey.avbpubkey",
7185 private_key: "testkey.pem",
7186 }
7187
7188 cc_library {
7189 name: "mylib",
7190 srcs: ["mylib.cpp"],
7191 system_shared_libs: [],
7192 stl: "none",
7193 stubs: {
7194 versions: ["1"],
7195 },
7196 apex_available: ["myapex"],
7197 }
7198
7199 cc_library {
7200 name: "myprivlib",
7201 srcs: ["mylib.cpp"],
7202 system_shared_libs: [],
7203 stl: "none",
7204 shared_libs: ["mylib"],
7205 apex_available: ["myapex"],
7206 }
7207
7208 cc_library {
7209 name: "mytestlib",
7210 srcs: ["mylib.cpp"],
7211 system_shared_libs: [],
7212 shared_libs: ["myprivlib"],
7213 stl: "none",
7214 test_for: ["myapex"],
7215 }
7216 `)
7217
7218 ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
Paul Duffina71a67a2021-03-29 00:42:57 +01007219 ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007220 mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
7221 android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
7222 }
7223
7224 // The platform variant of mytestlib links to the platform variant of the
7225 // internal myprivlib.
7226 ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/myprivlib/", "android_arm64_armv8-a_shared/myprivlib.so")
7227
7228 // The platform variant of myprivlib links to the platform variant of mylib
7229 // and bypasses its stubs.
7230 ensureLinkedLibIs("myprivlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
Jiyong Park62304bb2020-04-13 16:19:48 +09007231}
7232
Martin Stjernholmec009002021-03-27 15:18:31 +00007233func TestTestForForLibInOtherApex(t *testing.T) {
7234 // This case is only allowed for known overlapping APEXes, i.e. the ART APEXes.
7235 _ = testApex(t, `
7236 apex {
7237 name: "com.android.art",
7238 key: "myapex.key",
7239 native_shared_libs: ["mylib"],
7240 updatable: false,
7241 }
7242
7243 apex {
7244 name: "com.android.art.debug",
7245 key: "myapex.key",
7246 native_shared_libs: ["mylib", "mytestlib"],
7247 updatable: false,
7248 }
7249
7250 apex_key {
7251 name: "myapex.key",
7252 public_key: "testkey.avbpubkey",
7253 private_key: "testkey.pem",
7254 }
7255
7256 cc_library {
7257 name: "mylib",
7258 srcs: ["mylib.cpp"],
7259 system_shared_libs: [],
7260 stl: "none",
7261 stubs: {
7262 versions: ["1"],
7263 },
7264 apex_available: ["com.android.art", "com.android.art.debug"],
7265 }
7266
7267 cc_library {
7268 name: "mytestlib",
7269 srcs: ["mylib.cpp"],
7270 system_shared_libs: [],
7271 shared_libs: ["mylib"],
7272 stl: "none",
7273 apex_available: ["com.android.art.debug"],
7274 test_for: ["com.android.art"],
7275 }
7276 `,
7277 android.MockFS{
7278 "system/sepolicy/apex/com.android.art-file_contexts": nil,
7279 "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
7280 }.AddToFixture())
7281}
7282
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007283// TODO(jungjw): Move this to proptools
7284func intPtr(i int) *int {
7285 return &i
7286}
7287
7288func TestApexSet(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007289 ctx := testApex(t, `
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007290 apex_set {
7291 name: "myapex",
7292 set: "myapex.apks",
7293 filename: "foo_v2.apex",
7294 overrides: ["foo"],
7295 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00007296 `,
7297 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
7298 variables.Platform_sdk_version = intPtr(30)
7299 }),
7300 android.FixtureModifyConfig(func(config android.Config) {
7301 config.Targets[android.Android] = []android.Target{
7302 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}},
7303 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}},
7304 }
7305 }),
7306 )
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007307
Paul Duffin24704672021-04-06 16:09:30 +01007308 m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007309
7310 // Check extract_apks tool parameters.
Paul Duffin24704672021-04-06 16:09:30 +01007311 extractedApex := m.Output("extracted/myapex.apks")
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007312 actual := extractedApex.Args["abis"]
7313 expected := "ARMEABI_V7A,ARM64_V8A"
7314 if actual != expected {
7315 t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
7316 }
7317 actual = extractedApex.Args["sdk-version"]
7318 expected = "30"
7319 if actual != expected {
7320 t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
7321 }
7322
Paul Duffin6717d882021-06-15 19:09:41 +01007323 m = ctx.ModuleForTests("myapex", "android_common_myapex")
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007324 a := m.Module().(*ApexSet)
7325 expectedOverrides := []string{"foo"}
Colin Crossaa255532020-07-03 13:18:24 -07007326 actualOverrides := android.AndroidMkEntriesForTest(t, ctx, a)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007327 if !reflect.DeepEqual(actualOverrides, expectedOverrides) {
7328 t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES - expected %q vs actual %q", expectedOverrides, actualOverrides)
7329 }
7330}
7331
Jiyong Park7d95a512020-05-10 15:16:24 +09007332func TestNoStaticLinkingToStubsLib(t *testing.T) {
7333 testApexError(t, `.*required by "mylib" is a native library providing stub.*`, `
7334 apex {
7335 name: "myapex",
7336 key: "myapex.key",
7337 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007338 updatable: false,
Jiyong Park7d95a512020-05-10 15:16:24 +09007339 }
7340
7341 apex_key {
7342 name: "myapex.key",
7343 public_key: "testkey.avbpubkey",
7344 private_key: "testkey.pem",
7345 }
7346
7347 cc_library {
7348 name: "mylib",
7349 srcs: ["mylib.cpp"],
7350 static_libs: ["otherlib"],
7351 system_shared_libs: [],
7352 stl: "none",
7353 apex_available: [ "myapex" ],
7354 }
7355
7356 cc_library {
7357 name: "otherlib",
7358 srcs: ["mylib.cpp"],
7359 system_shared_libs: [],
7360 stl: "none",
7361 stubs: {
7362 versions: ["1", "2", "3"],
7363 },
7364 apex_available: [ "myapex" ],
7365 }
7366 `)
7367}
7368
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007369func TestApexKeysTxt(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007370 ctx := testApex(t, `
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007371 apex {
7372 name: "myapex",
7373 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007374 updatable: false,
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007375 }
7376
7377 apex_key {
7378 name: "myapex.key",
7379 public_key: "testkey.avbpubkey",
7380 private_key: "testkey.pem",
7381 }
7382
7383 prebuilt_apex {
7384 name: "myapex",
7385 prefer: true,
7386 arch: {
7387 arm64: {
7388 src: "myapex-arm64.apex",
7389 },
7390 arm: {
7391 src: "myapex-arm.apex",
7392 },
7393 },
7394 }
7395
7396 apex_set {
7397 name: "myapex_set",
7398 set: "myapex.apks",
7399 filename: "myapex_set.apex",
7400 overrides: ["myapex"],
7401 }
7402 `)
7403
7404 apexKeysText := ctx.SingletonForTests("apex_keys_text")
7405 content := apexKeysText.MaybeDescription("apexkeys.txt").BuildParams.Args["content"]
7406 ensureContains(t, content, `name="myapex_set.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
Jiyong Park03a7f3e2020-06-18 19:34:42 +09007407 ensureContains(t, content, `name="myapex.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007408}
7409
Jooyung Han938b5932020-06-20 12:47:47 +09007410func TestAllowedFiles(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007411 ctx := testApex(t, `
Jooyung Han938b5932020-06-20 12:47:47 +09007412 apex {
7413 name: "myapex",
7414 key: "myapex.key",
7415 apps: ["app"],
7416 allowed_files: "allowed.txt",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007417 updatable: false,
Jooyung Han938b5932020-06-20 12:47:47 +09007418 }
7419
7420 apex_key {
7421 name: "myapex.key",
7422 public_key: "testkey.avbpubkey",
7423 private_key: "testkey.pem",
7424 }
7425
7426 android_app {
7427 name: "app",
7428 srcs: ["foo/bar/MyClass.java"],
7429 package_name: "foo",
7430 sdk_version: "none",
7431 system_modules: "none",
7432 apex_available: [ "myapex" ],
7433 }
7434 `, withFiles(map[string][]byte{
7435 "sub/Android.bp": []byte(`
7436 override_apex {
7437 name: "override_myapex",
7438 base: "myapex",
7439 apps: ["override_app"],
7440 allowed_files: ":allowed",
7441 }
7442 // Overridable "path" property should be referenced indirectly
7443 filegroup {
7444 name: "allowed",
7445 srcs: ["allowed.txt"],
7446 }
7447 override_android_app {
7448 name: "override_app",
7449 base: "app",
7450 package_name: "bar",
7451 }
7452 `),
7453 }))
7454
7455 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("diffApexContentRule")
7456 if expected, actual := "allowed.txt", rule.Args["allowed_files_file"]; expected != actual {
7457 t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
7458 }
7459
7460 rule2 := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Rule("diffApexContentRule")
7461 if expected, actual := "sub/allowed.txt", rule2.Args["allowed_files_file"]; expected != actual {
7462 t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
7463 }
7464}
7465
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007466func TestNonPreferredPrebuiltDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007467 testApex(t, `
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007468 apex {
7469 name: "myapex",
7470 key: "myapex.key",
7471 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007472 updatable: false,
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007473 }
7474
7475 apex_key {
7476 name: "myapex.key",
7477 public_key: "testkey.avbpubkey",
7478 private_key: "testkey.pem",
7479 }
7480
7481 cc_library {
7482 name: "mylib",
7483 srcs: ["mylib.cpp"],
7484 stubs: {
Dan Albertc8060532020-07-22 22:32:17 -07007485 versions: ["current"],
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007486 },
7487 apex_available: ["myapex"],
7488 }
7489
7490 cc_prebuilt_library_shared {
7491 name: "mylib",
7492 prefer: false,
7493 srcs: ["prebuilt.so"],
7494 stubs: {
Dan Albertc8060532020-07-22 22:32:17 -07007495 versions: ["current"],
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007496 },
7497 apex_available: ["myapex"],
7498 }
7499 `)
7500}
7501
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007502func TestCompressedApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007503 ctx := testApex(t, `
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007504 apex {
7505 name: "myapex",
7506 key: "myapex.key",
7507 compressible: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007508 updatable: false,
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007509 }
7510 apex_key {
7511 name: "myapex.key",
7512 public_key: "testkey.avbpubkey",
7513 private_key: "testkey.pem",
7514 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00007515 `,
7516 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
7517 variables.CompressedApex = proptools.BoolPtr(true)
7518 }),
7519 )
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007520
7521 compressRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("compressRule")
7522 ensureContains(t, compressRule.Output.String(), "myapex.capex.unsigned")
7523
7524 signApkRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Description("sign compressedApex")
7525 ensureEquals(t, signApkRule.Input.String(), compressRule.Output.String())
7526
7527 // Make sure output of bundle is .capex
7528 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
7529 ensureContains(t, ab.outputFile.String(), "myapex.capex")
7530
7531 // Verify android.mk rules
Colin Crossaa255532020-07-03 13:18:24 -07007532 data := android.AndroidMkDataForTest(t, ctx, ab)
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007533 var builder strings.Builder
7534 data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
7535 androidMk := builder.String()
7536 ensureContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.capex\n")
7537}
7538
Martin Stjernholm2856c662020-12-02 15:03:42 +00007539func TestPreferredPrebuiltSharedLibDep(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007540 ctx := testApex(t, `
Martin Stjernholm2856c662020-12-02 15:03:42 +00007541 apex {
7542 name: "myapex",
7543 key: "myapex.key",
7544 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007545 updatable: false,
Martin Stjernholm2856c662020-12-02 15:03:42 +00007546 }
7547
7548 apex_key {
7549 name: "myapex.key",
7550 public_key: "testkey.avbpubkey",
7551 private_key: "testkey.pem",
7552 }
7553
7554 cc_library {
7555 name: "mylib",
7556 srcs: ["mylib.cpp"],
7557 apex_available: ["myapex"],
7558 shared_libs: ["otherlib"],
7559 system_shared_libs: [],
7560 }
7561
7562 cc_library {
7563 name: "otherlib",
7564 srcs: ["mylib.cpp"],
7565 stubs: {
7566 versions: ["current"],
7567 },
7568 }
7569
7570 cc_prebuilt_library_shared {
7571 name: "otherlib",
7572 prefer: true,
7573 srcs: ["prebuilt.so"],
7574 stubs: {
7575 versions: ["current"],
7576 },
7577 }
7578 `)
7579
7580 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07007581 data := android.AndroidMkDataForTest(t, ctx, ab)
Martin Stjernholm2856c662020-12-02 15:03:42 +00007582 var builder strings.Builder
7583 data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
7584 androidMk := builder.String()
7585
7586 // The make level dependency needs to be on otherlib - prebuilt_otherlib isn't
7587 // a thing there.
7588 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += otherlib\n")
7589}
7590
Jiyong Parke3867542020-12-03 17:28:25 +09007591func TestExcludeDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007592 ctx := testApex(t, `
Jiyong Parke3867542020-12-03 17:28:25 +09007593 apex {
7594 name: "myapex",
7595 key: "myapex.key",
7596 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007597 updatable: false,
Jiyong Parke3867542020-12-03 17:28:25 +09007598 }
7599
7600 apex_key {
7601 name: "myapex.key",
7602 public_key: "testkey.avbpubkey",
7603 private_key: "testkey.pem",
7604 }
7605
7606 cc_library {
7607 name: "mylib",
7608 srcs: ["mylib.cpp"],
7609 system_shared_libs: [],
7610 stl: "none",
7611 apex_available: ["myapex"],
7612 shared_libs: ["mylib2"],
7613 target: {
7614 apex: {
7615 exclude_shared_libs: ["mylib2"],
7616 },
7617 },
7618 }
7619
7620 cc_library {
7621 name: "mylib2",
7622 srcs: ["mylib.cpp"],
7623 system_shared_libs: [],
7624 stl: "none",
7625 }
7626 `)
7627
7628 // Check if mylib is linked to mylib2 for the non-apex target
7629 ldFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
7630 ensureContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
7631
7632 // Make sure that the link doesn't occur for the apex target
7633 ldFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
7634 ensureNotContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared_apex10000/mylib2.so")
7635
7636 // It shouldn't appear in the copy cmd as well.
7637 copyCmds := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule").Args["copy_commands"]
7638 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
7639}
7640
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007641func TestPrebuiltStubLibDep(t *testing.T) {
7642 bpBase := `
7643 apex {
7644 name: "myapex",
7645 key: "myapex.key",
7646 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007647 updatable: false,
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007648 }
7649 apex_key {
7650 name: "myapex.key",
7651 public_key: "testkey.avbpubkey",
7652 private_key: "testkey.pem",
7653 }
7654 cc_library {
7655 name: "mylib",
7656 srcs: ["mylib.cpp"],
7657 apex_available: ["myapex"],
7658 shared_libs: ["stublib"],
7659 system_shared_libs: [],
7660 }
7661 apex {
7662 name: "otherapex",
7663 enabled: %s,
7664 key: "myapex.key",
7665 native_shared_libs: ["stublib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007666 updatable: false,
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007667 }
7668 `
7669
7670 stublibSourceBp := `
7671 cc_library {
7672 name: "stublib",
7673 srcs: ["mylib.cpp"],
7674 apex_available: ["otherapex"],
7675 system_shared_libs: [],
7676 stl: "none",
7677 stubs: {
7678 versions: ["1"],
7679 },
7680 }
7681 `
7682
7683 stublibPrebuiltBp := `
7684 cc_prebuilt_library_shared {
7685 name: "stublib",
7686 srcs: ["prebuilt.so"],
7687 apex_available: ["otherapex"],
7688 stubs: {
7689 versions: ["1"],
7690 },
7691 %s
7692 }
7693 `
7694
7695 tests := []struct {
7696 name string
7697 stublibBp string
7698 usePrebuilt bool
7699 modNames []string // Modules to collect AndroidMkEntries for
7700 otherApexEnabled []string
7701 }{
7702 {
7703 name: "only_source",
7704 stublibBp: stublibSourceBp,
7705 usePrebuilt: false,
7706 modNames: []string{"stublib"},
7707 otherApexEnabled: []string{"true", "false"},
7708 },
7709 {
7710 name: "source_preferred",
7711 stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, ""),
7712 usePrebuilt: false,
7713 modNames: []string{"stublib", "prebuilt_stublib"},
7714 otherApexEnabled: []string{"true", "false"},
7715 },
7716 {
7717 name: "prebuilt_preferred",
7718 stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, "prefer: true,"),
7719 usePrebuilt: true,
7720 modNames: []string{"stublib", "prebuilt_stublib"},
7721 otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
7722 },
7723 {
7724 name: "only_prebuilt",
7725 stublibBp: fmt.Sprintf(stublibPrebuiltBp, ""),
7726 usePrebuilt: true,
7727 modNames: []string{"stublib"},
7728 otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
7729 },
7730 }
7731
7732 for _, test := range tests {
7733 t.Run(test.name, func(t *testing.T) {
7734 for _, otherApexEnabled := range test.otherApexEnabled {
7735 t.Run("otherapex_enabled_"+otherApexEnabled, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007736 ctx := testApex(t, fmt.Sprintf(bpBase, otherApexEnabled)+test.stublibBp)
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007737
7738 type modAndMkEntries struct {
7739 mod *cc.Module
7740 mkEntries android.AndroidMkEntries
7741 }
7742 entries := []*modAndMkEntries{}
7743
7744 // Gather shared lib modules that are installable
7745 for _, modName := range test.modNames {
7746 for _, variant := range ctx.ModuleVariantsForTests(modName) {
7747 if !strings.HasPrefix(variant, "android_arm64_armv8-a_shared") {
7748 continue
7749 }
7750 mod := ctx.ModuleForTests(modName, variant).Module().(*cc.Module)
Colin Crossa9c8c9f2020-12-16 10:20:23 -08007751 if !mod.Enabled() || mod.IsHideFromMake() {
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007752 continue
7753 }
Colin Crossaa255532020-07-03 13:18:24 -07007754 for _, ent := range android.AndroidMkEntriesForTest(t, ctx, mod) {
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007755 if ent.Disabled {
7756 continue
7757 }
7758 entries = append(entries, &modAndMkEntries{
7759 mod: mod,
7760 mkEntries: ent,
7761 })
7762 }
7763 }
7764 }
7765
7766 var entry *modAndMkEntries = nil
7767 for _, ent := range entries {
7768 if strings.Join(ent.mkEntries.EntryMap["LOCAL_MODULE"], ",") == "stublib" {
7769 if entry != nil {
7770 t.Errorf("More than one AndroidMk entry for \"stublib\": %s and %s", entry.mod, ent.mod)
7771 } else {
7772 entry = ent
7773 }
7774 }
7775 }
7776
7777 if entry == nil {
7778 t.Errorf("AndroidMk entry for \"stublib\" missing")
7779 } else {
7780 isPrebuilt := entry.mod.Prebuilt() != nil
7781 if isPrebuilt != test.usePrebuilt {
7782 t.Errorf("Wrong module for \"stublib\" AndroidMk entry: got prebuilt %t, want prebuilt %t", isPrebuilt, test.usePrebuilt)
7783 }
7784 if !entry.mod.IsStubs() {
7785 t.Errorf("Module for \"stublib\" AndroidMk entry isn't a stub: %s", entry.mod)
7786 }
7787 if entry.mkEntries.EntryMap["LOCAL_NOT_AVAILABLE_FOR_PLATFORM"] != nil {
7788 t.Errorf("AndroidMk entry for \"stublib\" has LOCAL_NOT_AVAILABLE_FOR_PLATFORM set: %+v", entry.mkEntries)
7789 }
Jiyong Park892a98f2020-12-14 09:20:00 +09007790 cflags := entry.mkEntries.EntryMap["LOCAL_EXPORT_CFLAGS"]
Jiyong Parkd4a3a132021-03-17 20:21:35 +09007791 expected := "-D__STUBLIB_API__=10000"
Jiyong Park892a98f2020-12-14 09:20:00 +09007792 if !android.InList(expected, cflags) {
7793 t.Errorf("LOCAL_EXPORT_CFLAGS expected to have %q, but got %q", expected, cflags)
7794 }
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007795 }
7796 })
7797 }
7798 })
7799 }
7800}
7801
Martin Stjernholmdf298b32021-05-21 20:57:29 +01007802func TestHostApexInHostOnlyBuild(t *testing.T) {
7803 testApex(t, `
7804 apex {
7805 name: "myapex",
7806 host_supported: true,
7807 key: "myapex.key",
7808 updatable: false,
7809 payload_type: "zip",
7810 }
7811 apex_key {
7812 name: "myapex.key",
7813 public_key: "testkey.avbpubkey",
7814 private_key: "testkey.pem",
7815 }
7816 `,
7817 android.FixtureModifyConfig(func(config android.Config) {
7818 // We may not have device targets in all builds, e.g. in
7819 // prebuilts/build-tools/build-prebuilts.sh
7820 config.Targets[android.Android] = []android.Target{}
7821 }))
7822}
7823
Colin Crossc33e5212021-05-25 18:16:02 -07007824func TestApexJavaCoverage(t *testing.T) {
7825 bp := `
7826 apex {
7827 name: "myapex",
7828 key: "myapex.key",
7829 java_libs: ["mylib"],
7830 bootclasspath_fragments: ["mybootclasspathfragment"],
7831 systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
7832 updatable: false,
7833 }
7834
7835 apex_key {
7836 name: "myapex.key",
7837 public_key: "testkey.avbpubkey",
7838 private_key: "testkey.pem",
7839 }
7840
7841 java_library {
7842 name: "mylib",
7843 srcs: ["mylib.java"],
7844 apex_available: ["myapex"],
7845 compile_dex: true,
7846 }
7847
7848 bootclasspath_fragment {
7849 name: "mybootclasspathfragment",
7850 contents: ["mybootclasspathlib"],
7851 apex_available: ["myapex"],
7852 }
7853
7854 java_library {
7855 name: "mybootclasspathlib",
7856 srcs: ["mybootclasspathlib.java"],
7857 apex_available: ["myapex"],
7858 compile_dex: true,
7859 }
7860
7861 systemserverclasspath_fragment {
7862 name: "mysystemserverclasspathfragment",
7863 contents: ["mysystemserverclasspathlib"],
7864 apex_available: ["myapex"],
7865 }
7866
7867 java_library {
7868 name: "mysystemserverclasspathlib",
7869 srcs: ["mysystemserverclasspathlib.java"],
7870 apex_available: ["myapex"],
7871 compile_dex: true,
7872 }
7873 `
7874
7875 result := android.GroupFixturePreparers(
7876 PrepareForTestWithApexBuildComponents,
7877 prepareForTestWithMyapex,
7878 java.PrepareForTestWithJavaDefaultModules,
7879 android.PrepareForTestWithAndroidBuildComponents,
7880 android.FixtureWithRootAndroidBp(bp),
7881 android.FixtureMergeEnv(map[string]string{
7882 "EMMA_INSTRUMENT": "true",
7883 }),
7884 ).RunTest(t)
7885
7886 // Make sure jacoco ran on both mylib and mybootclasspathlib
7887 if result.ModuleForTests("mylib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
7888 t.Errorf("Failed to find jacoco rule for mylib")
7889 }
7890 if result.ModuleForTests("mybootclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
7891 t.Errorf("Failed to find jacoco rule for mybootclasspathlib")
7892 }
7893 if result.ModuleForTests("mysystemserverclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
7894 t.Errorf("Failed to find jacoco rule for mysystemserverclasspathlib")
7895 }
7896}
7897
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07007898func TestMain(m *testing.M) {
Paul Duffin37ba3442021-03-29 00:21:08 +01007899 os.Exit(m.Run())
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07007900}