blob: ef1fe7490a05c628d9d25fb64bc7d760a77b477c [file] [log] [blame]
Jiyong Park25fc6a92018-11-18 18:02:45 +09001// Copyright 2018 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package apex
16
17import (
Jiyong Park25fc6a92018-11-18 18:02:45 +090018 "io/ioutil"
19 "os"
Jooyung Han39edb6c2019-11-06 16:53:07 +090020 "path"
Jaewoong Jung22f7d182019-07-16 18:25:41 -070021 "reflect"
Jooyung Han31c470b2019-10-18 16:26:59 +090022 "sort"
Jiyong Park25fc6a92018-11-18 18:02:45 +090023 "strings"
24 "testing"
Jiyong Parkda6eb592018-12-19 17:12:36 +090025
26 "github.com/google/blueprint/proptools"
27
28 "android/soong/android"
29 "android/soong/cc"
Ulya Trafimovichb28cc372020-01-13 15:18:16 +000030 "android/soong/dexpreopt"
Jiyong Parkb2742fd2019-02-11 11:38:15 +090031 "android/soong/java"
Jiyong Park25fc6a92018-11-18 18:02:45 +090032)
33
Jaewoong Jung14f5ff62019-06-18 13:09:13 -070034var buildDir string
35
Jooyung Hand3639552019-08-09 12:57:43 +090036// names returns name list from white space separated string
37func names(s string) (ns []string) {
38 for _, n := range strings.Split(s, " ") {
39 if len(n) > 0 {
40 ns = append(ns, n)
41 }
42 }
43 return
44}
45
Jooyung Han344d5432019-08-23 11:17:39 +090046func testApexError(t *testing.T, pattern, bp string, handlers ...testCustomizer) {
47 t.Helper()
48 ctx, config := testApexContext(t, bp, handlers...)
Jooyung Han5c998b92019-06-27 11:30:33 +090049 _, errs := ctx.ParseFileList(".", []string{"Android.bp"})
50 if len(errs) > 0 {
51 android.FailIfNoMatchingErrors(t, pattern, errs)
52 return
53 }
54 _, errs = ctx.PrepareBuildActions(config)
55 if len(errs) > 0 {
56 android.FailIfNoMatchingErrors(t, pattern, errs)
57 return
58 }
59
60 t.Fatalf("missing expected error %q (0 errors are returned)", pattern)
61}
62
Jooyung Han344d5432019-08-23 11:17:39 +090063func testApex(t *testing.T, bp string, handlers ...testCustomizer) (*android.TestContext, android.Config) {
64 t.Helper()
65 ctx, config := testApexContext(t, bp, handlers...)
Jooyung Han5c998b92019-06-27 11:30:33 +090066 _, errs := ctx.ParseFileList(".", []string{"Android.bp"})
67 android.FailIfErrored(t, errs)
68 _, errs = ctx.PrepareBuildActions(config)
69 android.FailIfErrored(t, errs)
Jaewoong Jung22f7d182019-07-16 18:25:41 -070070 return ctx, config
Jooyung Han5c998b92019-06-27 11:30:33 +090071}
72
Jooyung Han344d5432019-08-23 11:17:39 +090073type testCustomizer func(fs map[string][]byte, config android.Config)
74
75func withFiles(files map[string][]byte) testCustomizer {
76 return func(fs map[string][]byte, config android.Config) {
77 for k, v := range files {
78 fs[k] = v
79 }
80 }
81}
82
83func withTargets(targets map[android.OsType][]android.Target) testCustomizer {
84 return func(fs map[string][]byte, config android.Config) {
85 for k, v := range targets {
86 config.Targets[k] = v
87 }
88 }
89}
90
Jooyung Han35155c42020-02-06 17:33:20 +090091// withNativeBridgeTargets sets configuration with targets including:
92// - X86_64 (primary)
93// - X86 (secondary)
94// - Arm64 on X86_64 (native bridge)
95// - Arm on X86 (native bridge)
96func withNativeBridgeEnabled(fs map[string][]byte, config android.Config) {
97 config.Targets[android.Android] = []android.Target{
98 {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "silvermont", Abi: []string{"arm64-v8a"}},
99 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
100 {Os: android.Android, Arch: android.Arch{ArchType: android.X86, ArchVariant: "silvermont", Abi: []string{"armeabi-v7a"}},
101 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
102 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}},
103 NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86_64", NativeBridgeRelativePath: "arm64"},
104 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
105 NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86", NativeBridgeRelativePath: "arm"},
106 }
107}
108
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900109func withManifestPackageNameOverrides(specs []string) testCustomizer {
110 return func(fs map[string][]byte, config android.Config) {
111 config.TestProductVariables.ManifestPackageNameOverrides = specs
112 }
113}
114
Jooyung Han31c470b2019-10-18 16:26:59 +0900115func withBinder32bit(fs map[string][]byte, config android.Config) {
116 config.TestProductVariables.Binder32bit = proptools.BoolPtr(true)
117}
118
Jiyong Park7cd10e32020-01-14 09:22:18 +0900119func withUnbundledBuild(fs map[string][]byte, config android.Config) {
120 config.TestProductVariables.Unbundled_build = proptools.BoolPtr(true)
121}
122
Jooyung Han344d5432019-08-23 11:17:39 +0900123func testApexContext(t *testing.T, bp string, handlers ...testCustomizer) (*android.TestContext, android.Config) {
Jooyung Han671f1ce2019-12-17 12:47:13 +0900124 android.ClearApexDependency()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900125
126 bp = bp + `
Jooyung Han54aca7b2019-11-20 02:26:02 +0900127 filegroup {
128 name: "myapex-file_contexts",
129 srcs: [
130 "system/sepolicy/apex/myapex-file_contexts",
131 ],
132 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900133 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800134
Colin Crossf9aabd72020-02-15 11:29:50 -0800135 bp = bp + cc.GatherRequiredDepsForTest(android.Android)
136
Dario Frenicde2a032019-10-27 00:29:22 +0100137 bp = bp + java.GatherRequiredDepsForTest()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900138
Jooyung Han344d5432019-08-23 11:17:39 +0900139 fs := map[string][]byte{
Jooyung Han54aca7b2019-11-20 02:26:02 +0900140 "a.java": nil,
141 "PrebuiltAppFoo.apk": nil,
142 "PrebuiltAppFooPriv.apk": nil,
143 "build/make/target/product/security": nil,
144 "apex_manifest.json": nil,
145 "AndroidManifest.xml": nil,
146 "system/sepolicy/apex/myapex-file_contexts": nil,
Jiyong Park9d677202020-02-19 16:29:35 +0900147 "system/sepolicy/apex/myapex.updatable-file_contexts": nil,
Jiyong Park83dc74b2020-01-14 18:38:44 +0900148 "system/sepolicy/apex/myapex2-file_contexts": nil,
Jooyung Han54aca7b2019-11-20 02:26:02 +0900149 "system/sepolicy/apex/otherapex-file_contexts": nil,
150 "system/sepolicy/apex/commonapex-file_contexts": nil,
151 "system/sepolicy/apex/com.android.vndk-file_contexts": nil,
Colin Cross98be1bb2019-12-13 20:41:13 -0800152 "mylib.cpp": nil,
153 "mylib_common.cpp": nil,
154 "mytest.cpp": nil,
155 "mytest1.cpp": nil,
156 "mytest2.cpp": nil,
157 "mytest3.cpp": nil,
158 "myprebuilt": nil,
159 "my_include": nil,
160 "foo/bar/MyClass.java": nil,
161 "prebuilt.jar": nil,
Paul Duffindddd5462020-04-07 15:25:44 +0100162 "prebuilt.so": nil,
Colin Cross98be1bb2019-12-13 20:41:13 -0800163 "vendor/foo/devkeys/test.x509.pem": nil,
164 "vendor/foo/devkeys/test.pk8": nil,
165 "testkey.x509.pem": nil,
166 "testkey.pk8": nil,
167 "testkey.override.x509.pem": nil,
168 "testkey.override.pk8": nil,
169 "vendor/foo/devkeys/testkey.avbpubkey": nil,
170 "vendor/foo/devkeys/testkey.pem": nil,
171 "NOTICE": nil,
172 "custom_notice": nil,
Jiyong Park9918e1a2020-03-17 19:16:40 +0900173 "custom_notice_for_static_lib": nil,
Colin Cross98be1bb2019-12-13 20:41:13 -0800174 "testkey2.avbpubkey": nil,
175 "testkey2.pem": nil,
176 "myapex-arm64.apex": nil,
177 "myapex-arm.apex": nil,
178 "frameworks/base/api/current.txt": nil,
179 "framework/aidl/a.aidl": nil,
180 "build/make/core/proguard.flags": nil,
181 "build/make/core/proguard_basic_keeps.flags": nil,
182 "dummy.txt": nil,
Jooyung Han344d5432019-08-23 11:17:39 +0900183 }
184
Colin Crossf9aabd72020-02-15 11:29:50 -0800185 cc.GatherRequiredFilesForTest(fs)
186
Jooyung Han344d5432019-08-23 11:17:39 +0900187 for _, handler := range handlers {
Colin Cross98be1bb2019-12-13 20:41:13 -0800188 // The fs now needs to be populated before creating the config, call handlers twice
189 // for now, once to get any fs changes, and later after the config was created to
190 // set product variables or targets.
191 tempConfig := android.TestArchConfig(buildDir, nil, bp, fs)
192 handler(fs, tempConfig)
Jooyung Han344d5432019-08-23 11:17:39 +0900193 }
194
Colin Cross98be1bb2019-12-13 20:41:13 -0800195 config := android.TestArchConfig(buildDir, nil, bp, fs)
196 config.TestProductVariables.DeviceVndkVersion = proptools.StringPtr("current")
197 config.TestProductVariables.DefaultAppCertificate = proptools.StringPtr("vendor/foo/devkeys/test")
198 config.TestProductVariables.CertificateOverrides = []string{"myapex_keytest:myapex.certificate.override"}
199 config.TestProductVariables.Platform_sdk_codename = proptools.StringPtr("Q")
200 config.TestProductVariables.Platform_sdk_final = proptools.BoolPtr(false)
201 config.TestProductVariables.Platform_vndk_version = proptools.StringPtr("VER")
202
203 for _, handler := range handlers {
204 // The fs now needs to be populated before creating the config, call handlers twice
205 // for now, earlier to get any fs changes, and now after the config was created to
206 // set product variables or targets.
207 tempFS := map[string][]byte{}
208 handler(tempFS, config)
209 }
210
211 ctx := android.NewTestArchContext()
212 ctx.RegisterModuleType("apex", BundleFactory)
213 ctx.RegisterModuleType("apex_test", testApexBundleFactory)
214 ctx.RegisterModuleType("apex_vndk", vndkApexBundleFactory)
215 ctx.RegisterModuleType("apex_key", ApexKeyFactory)
216 ctx.RegisterModuleType("apex_defaults", defaultsFactory)
217 ctx.RegisterModuleType("prebuilt_apex", PrebuiltFactory)
218 ctx.RegisterModuleType("override_apex", overrideApexFactory)
219
Jooyung Hana57af4a2020-01-23 05:36:59 +0000220 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
221 ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
222
Paul Duffin77980a82019-12-19 16:01:36 +0000223 cc.RegisterRequiredBuildComponentsForTest(ctx)
Colin Cross98be1bb2019-12-13 20:41:13 -0800224 ctx.RegisterModuleType("cc_test", cc.TestFactory)
Colin Cross98be1bb2019-12-13 20:41:13 -0800225 ctx.RegisterModuleType("vndk_prebuilt_shared", cc.VndkPrebuiltSharedFactory)
226 ctx.RegisterModuleType("vndk_libraries_txt", cc.VndkLibrariesTxtFactory)
Colin Cross98be1bb2019-12-13 20:41:13 -0800227 ctx.RegisterModuleType("prebuilt_etc", android.PrebuiltEtcFactory)
atrost6e126252020-01-27 17:01:16 +0000228 ctx.RegisterModuleType("platform_compat_config", java.PlatformCompatConfigFactory)
Colin Cross98be1bb2019-12-13 20:41:13 -0800229 ctx.RegisterModuleType("sh_binary", android.ShBinaryFactory)
Colin Cross98be1bb2019-12-13 20:41:13 -0800230 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
Paul Duffinf9b1da02019-12-18 19:51:55 +0000231 java.RegisterJavaBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +0000232 java.RegisterSystemModulesBuildComponents(ctx)
Paul Duffinf9b1da02019-12-18 19:51:55 +0000233 java.RegisterAppBuildComponents(ctx)
Jooyung Han58f26ab2019-12-18 15:34:32 +0900234 ctx.RegisterModuleType("java_sdk_library", java.SdkLibraryFactory)
Colin Cross98be1bb2019-12-13 20:41:13 -0800235
Colin Cross98be1bb2019-12-13 20:41:13 -0800236 ctx.PreDepsMutators(RegisterPreDepsMutators)
Colin Cross98be1bb2019-12-13 20:41:13 -0800237 ctx.PostDepsMutators(RegisterPostDepsMutators)
Colin Cross98be1bb2019-12-13 20:41:13 -0800238
239 ctx.Register(config)
Jiyong Park25fc6a92018-11-18 18:02:45 +0900240
Jooyung Han5c998b92019-06-27 11:30:33 +0900241 return ctx, config
Jiyong Park25fc6a92018-11-18 18:02:45 +0900242}
243
Jaewoong Jungc1001ec2019-06-25 11:20:53 -0700244func setUp() {
245 var err error
246 buildDir, err = ioutil.TempDir("", "soong_apex_test")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900247 if err != nil {
Jaewoong Jungc1001ec2019-06-25 11:20:53 -0700248 panic(err)
Jiyong Park25fc6a92018-11-18 18:02:45 +0900249 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900250}
251
Jaewoong Jungc1001ec2019-06-25 11:20:53 -0700252func tearDown() {
Jiyong Park25fc6a92018-11-18 18:02:45 +0900253 os.RemoveAll(buildDir)
254}
255
Jooyung Han643adc42020-02-27 13:50:06 +0900256// ensure that 'result' equals 'expected'
257func ensureEquals(t *testing.T, result string, expected string) {
258 t.Helper()
259 if result != expected {
260 t.Errorf("%q != %q", expected, result)
261 }
262}
263
Jiyong Park25fc6a92018-11-18 18:02:45 +0900264// ensure that 'result' contains 'expected'
265func ensureContains(t *testing.T, result string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900266 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900267 if !strings.Contains(result, expected) {
268 t.Errorf("%q is not found in %q", expected, result)
269 }
270}
271
272// ensures that 'result' does not contain 'notExpected'
273func ensureNotContains(t *testing.T, result string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900274 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900275 if strings.Contains(result, notExpected) {
276 t.Errorf("%q is found in %q", notExpected, result)
277 }
278}
279
280func ensureListContains(t *testing.T, result []string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900281 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900282 if !android.InList(expected, result) {
283 t.Errorf("%q is not found in %v", expected, result)
284 }
285}
286
287func ensureListNotContains(t *testing.T, result []string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900288 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900289 if android.InList(notExpected, result) {
290 t.Errorf("%q is found in %v", notExpected, result)
291 }
292}
293
Jooyung Hane1633032019-08-01 17:41:43 +0900294func ensureListEmpty(t *testing.T, result []string) {
295 t.Helper()
296 if len(result) > 0 {
297 t.Errorf("%q is expected to be empty", result)
298 }
299}
300
Jiyong Park25fc6a92018-11-18 18:02:45 +0900301// Minimal test
302func TestBasicApex(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700303 ctx, _ := testApex(t, `
Jiyong Park30ca9372019-02-07 16:27:23 +0900304 apex_defaults {
305 name: "myapex-defaults",
Jiyong Park809bb722019-02-13 21:33:49 +0900306 manifest: ":myapex.manifest",
307 androidManifest: ":myapex.androidmanifest",
Jiyong Park25fc6a92018-11-18 18:02:45 +0900308 key: "myapex.key",
309 native_shared_libs: ["mylib"],
Alex Light3d673592019-01-18 14:37:31 -0800310 multilib: {
311 both: {
312 binaries: ["foo",],
313 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900314 },
Jooyung Han5a80d9f2019-12-23 15:38:34 +0900315 java_libs: ["myjar"],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900316 }
317
Jiyong Park30ca9372019-02-07 16:27:23 +0900318 apex {
319 name: "myapex",
320 defaults: ["myapex-defaults"],
321 }
322
Jiyong Park25fc6a92018-11-18 18:02:45 +0900323 apex_key {
324 name: "myapex.key",
325 public_key: "testkey.avbpubkey",
326 private_key: "testkey.pem",
327 }
328
Jiyong Park809bb722019-02-13 21:33:49 +0900329 filegroup {
330 name: "myapex.manifest",
331 srcs: ["apex_manifest.json"],
332 }
333
334 filegroup {
335 name: "myapex.androidmanifest",
336 srcs: ["AndroidManifest.xml"],
337 }
338
Jiyong Park25fc6a92018-11-18 18:02:45 +0900339 cc_library {
340 name: "mylib",
341 srcs: ["mylib.cpp"],
342 shared_libs: ["mylib2"],
343 system_shared_libs: [],
344 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000345 // TODO: remove //apex_available:platform
346 apex_available: [
347 "//apex_available:platform",
348 "myapex",
349 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900350 }
351
Alex Light3d673592019-01-18 14:37:31 -0800352 cc_binary {
353 name: "foo",
354 srcs: ["mylib.cpp"],
355 compile_multilib: "both",
356 multilib: {
357 lib32: {
358 suffix: "32",
359 },
360 lib64: {
361 suffix: "64",
362 },
363 },
364 symlinks: ["foo_link_"],
365 symlink_preferred_arch: true,
366 system_shared_libs: [],
367 static_executable: true,
368 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000369 apex_available: [ "myapex" ],
Alex Light3d673592019-01-18 14:37:31 -0800370 }
371
Paul Duffindddd5462020-04-07 15:25:44 +0100372 cc_library_shared {
Jiyong Park25fc6a92018-11-18 18:02:45 +0900373 name: "mylib2",
374 srcs: ["mylib.cpp"],
375 system_shared_libs: [],
376 stl: "none",
Jiyong Park52818fc2019-03-18 12:01:38 +0900377 notice: "custom_notice",
Jiyong Park9918e1a2020-03-17 19:16:40 +0900378 static_libs: ["libstatic"],
379 // TODO: remove //apex_available:platform
380 apex_available: [
381 "//apex_available:platform",
382 "myapex",
383 ],
384 }
385
Paul Duffindddd5462020-04-07 15:25:44 +0100386 cc_prebuilt_library_shared {
387 name: "mylib2",
388 srcs: ["prebuilt.so"],
389 // TODO: remove //apex_available:platform
390 apex_available: [
391 "//apex_available:platform",
392 "myapex",
393 ],
394 }
395
Jiyong Park9918e1a2020-03-17 19:16:40 +0900396 cc_library_static {
397 name: "libstatic",
398 srcs: ["mylib.cpp"],
399 system_shared_libs: [],
400 stl: "none",
401 notice: "custom_notice_for_static_lib",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000402 // TODO: remove //apex_available:platform
403 apex_available: [
404 "//apex_available:platform",
405 "myapex",
406 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900407 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900408
409 java_library {
410 name: "myjar",
411 srcs: ["foo/bar/MyClass.java"],
412 sdk_version: "none",
413 system_modules: "none",
Jiyong Park7f7766d2019-07-25 22:02:35 +0900414 static_libs: ["myotherjar"],
Jiyong Park3ff16992019-12-27 14:11:47 +0900415 libs: ["mysharedjar"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000416 // TODO: remove //apex_available:platform
417 apex_available: [
418 "//apex_available:platform",
419 "myapex",
420 ],
Jiyong Park7f7766d2019-07-25 22:02:35 +0900421 }
422
423 java_library {
424 name: "myotherjar",
425 srcs: ["foo/bar/MyClass.java"],
426 sdk_version: "none",
427 system_modules: "none",
Jiyong Park0f80c182020-01-31 02:49:53 +0900428 // TODO: remove //apex_available:platform
429 apex_available: [
430 "//apex_available:platform",
431 "myapex",
432 ],
Jiyong Park7f7766d2019-07-25 22:02:35 +0900433 }
Jiyong Park3ff16992019-12-27 14:11:47 +0900434
435 java_library {
436 name: "mysharedjar",
437 srcs: ["foo/bar/MyClass.java"],
438 sdk_version: "none",
439 system_modules: "none",
Jiyong Park3ff16992019-12-27 14:11:47 +0900440 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900441 `)
442
Sundong Ahnabb64432019-10-22 13:58:29 +0900443 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900444
445 optFlags := apexRule.Args["opt_flags"]
446 ensureContains(t, optFlags, "--pubkey vendor/foo/devkeys/testkey.avbpubkey")
Jaewoong Jung14f5ff62019-06-18 13:09:13 -0700447 // Ensure that the NOTICE output is being packaged as an asset.
Sundong Ahnabb64432019-10-22 13:58:29 +0900448 ensureContains(t, optFlags, "--assets_dir "+buildDir+"/.intermediates/myapex/android_common_myapex_image/NOTICE")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900449
Jiyong Park25fc6a92018-11-18 18:02:45 +0900450 copyCmds := apexRule.Args["copy_commands"]
451
452 // Ensure that main rule creates an output
453 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
454
455 // Ensure that apex variant is created for the direct dep
Colin Cross7113d202019-11-20 16:39:12 -0800456 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_myapex")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900457 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common_myapex")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900458
459 // Ensure that apex variant is created for the indirect dep
Colin Cross7113d202019-11-20 16:39:12 -0800460 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_myapex")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900461 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common_myapex")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900462
463 // Ensure that both direct and indirect deps are copied into apex
Alex Light5098a612018-11-29 17:12:15 -0800464 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
465 ensureContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900466 ensureContains(t, copyCmds, "image.apex/javalib/myjar.jar")
467 // .. but not for java libs
468 ensureNotContains(t, copyCmds, "image.apex/javalib/myotherjar.jar")
Jiyong Park3ff16992019-12-27 14:11:47 +0900469 ensureNotContains(t, copyCmds, "image.apex/javalib/msharedjar.jar")
Logan Chien3aeedc92018-12-26 15:32:21 +0800470
Colin Cross7113d202019-11-20 16:39:12 -0800471 // Ensure that the platform variant ends with _shared or _common
472 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
473 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900474 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common")
475 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common")
Jiyong Park3ff16992019-12-27 14:11:47 +0900476 ensureListContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common")
477
478 // Ensure that dynamic dependency to java libs are not included
479 ensureListNotContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common_myapex")
Alex Light3d673592019-01-18 14:37:31 -0800480
481 // Ensure that all symlinks are present.
482 found_foo_link_64 := false
483 found_foo := false
484 for _, cmd := range strings.Split(copyCmds, " && ") {
Jiyong Park7cd10e32020-01-14 09:22:18 +0900485 if strings.HasPrefix(cmd, "ln -sfn foo64") {
Alex Light3d673592019-01-18 14:37:31 -0800486 if strings.HasSuffix(cmd, "bin/foo") {
487 found_foo = true
488 } else if strings.HasSuffix(cmd, "bin/foo_link_64") {
489 found_foo_link_64 = true
490 }
491 }
492 }
493 good := found_foo && found_foo_link_64
494 if !good {
495 t.Errorf("Could not find all expected symlinks! foo: %t, foo_link_64: %t. Command was %s", found_foo, found_foo_link_64, copyCmds)
496 }
Jiyong Park52818fc2019-03-18 12:01:38 +0900497
Sundong Ahnabb64432019-10-22 13:58:29 +0900498 mergeNoticesRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("mergeNoticesRule")
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700499 noticeInputs := mergeNoticesRule.Inputs.Strings()
Jiyong Park9918e1a2020-03-17 19:16:40 +0900500 if len(noticeInputs) != 3 {
501 t.Errorf("number of input notice files: expected = 3, actual = %q", len(noticeInputs))
Jiyong Park52818fc2019-03-18 12:01:38 +0900502 }
503 ensureListContains(t, noticeInputs, "NOTICE")
504 ensureListContains(t, noticeInputs, "custom_notice")
Jiyong Park9918e1a2020-03-17 19:16:40 +0900505 ensureListContains(t, noticeInputs, "custom_notice_for_static_lib")
Jiyong Park83dc74b2020-01-14 18:38:44 +0900506
507 depsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("myapex-deps-info.txt").Args["content"], "\\n")
Jiyong Park678c8812020-02-07 17:25:49 +0900508 ensureListContains(t, depsInfo, "myjar <- myapex")
509 ensureListContains(t, depsInfo, "mylib <- myapex")
510 ensureListContains(t, depsInfo, "mylib2 <- mylib")
511 ensureListContains(t, depsInfo, "myotherjar <- myjar")
512 ensureListContains(t, depsInfo, "mysharedjar (external) <- myjar")
Alex Light5098a612018-11-29 17:12:15 -0800513}
514
Jooyung Hanf21c7972019-12-16 22:32:06 +0900515func TestDefaults(t *testing.T) {
516 ctx, _ := testApex(t, `
517 apex_defaults {
518 name: "myapex-defaults",
519 key: "myapex.key",
520 prebuilts: ["myetc"],
521 native_shared_libs: ["mylib"],
522 java_libs: ["myjar"],
523 apps: ["AppFoo"],
524 }
525
526 prebuilt_etc {
527 name: "myetc",
528 src: "myprebuilt",
529 }
530
531 apex {
532 name: "myapex",
533 defaults: ["myapex-defaults"],
534 }
535
536 apex_key {
537 name: "myapex.key",
538 public_key: "testkey.avbpubkey",
539 private_key: "testkey.pem",
540 }
541
542 cc_library {
543 name: "mylib",
544 system_shared_libs: [],
545 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000546 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900547 }
548
549 java_library {
550 name: "myjar",
551 srcs: ["foo/bar/MyClass.java"],
552 sdk_version: "none",
553 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000554 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900555 }
556
557 android_app {
558 name: "AppFoo",
559 srcs: ["foo/bar/MyClass.java"],
560 sdk_version: "none",
561 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000562 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900563 }
564 `)
Jooyung Hana57af4a2020-01-23 05:36:59 +0000565 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Hanf21c7972019-12-16 22:32:06 +0900566 "etc/myetc",
567 "javalib/myjar.jar",
568 "lib64/mylib.so",
569 "app/AppFoo/AppFoo.apk",
570 })
571}
572
Jooyung Han01a3ee22019-11-02 02:52:25 +0900573func TestApexManifest(t *testing.T) {
574 ctx, _ := testApex(t, `
575 apex {
576 name: "myapex",
577 key: "myapex.key",
578 }
579
580 apex_key {
581 name: "myapex.key",
582 public_key: "testkey.avbpubkey",
583 private_key: "testkey.pem",
584 }
585 `)
586
587 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Han214bf372019-11-12 13:03:50 +0900588 args := module.Rule("apexRule").Args
589 if manifest := args["manifest"]; manifest != module.Output("apex_manifest.pb").Output.String() {
590 t.Error("manifest should be apex_manifest.pb, but " + manifest)
591 }
Jooyung Han01a3ee22019-11-02 02:52:25 +0900592}
593
Alex Light5098a612018-11-29 17:12:15 -0800594func TestBasicZipApex(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700595 ctx, _ := testApex(t, `
Alex Light5098a612018-11-29 17:12:15 -0800596 apex {
597 name: "myapex",
598 key: "myapex.key",
599 payload_type: "zip",
600 native_shared_libs: ["mylib"],
601 }
602
603 apex_key {
604 name: "myapex.key",
605 public_key: "testkey.avbpubkey",
606 private_key: "testkey.pem",
607 }
608
609 cc_library {
610 name: "mylib",
611 srcs: ["mylib.cpp"],
612 shared_libs: ["mylib2"],
613 system_shared_libs: [],
614 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000615 apex_available: [ "myapex" ],
Alex Light5098a612018-11-29 17:12:15 -0800616 }
617
618 cc_library {
619 name: "mylib2",
620 srcs: ["mylib.cpp"],
621 system_shared_libs: [],
622 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000623 apex_available: [ "myapex" ],
Alex Light5098a612018-11-29 17:12:15 -0800624 }
625 `)
626
Sundong Ahnabb64432019-10-22 13:58:29 +0900627 zipApexRule := ctx.ModuleForTests("myapex", "android_common_myapex_zip").Rule("zipApexRule")
Alex Light5098a612018-11-29 17:12:15 -0800628 copyCmds := zipApexRule.Args["copy_commands"]
629
630 // Ensure that main rule creates an output
631 ensureContains(t, zipApexRule.Output.String(), "myapex.zipapex.unsigned")
632
633 // Ensure that APEX variant is created for the direct dep
Colin Cross7113d202019-11-20 16:39:12 -0800634 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_myapex")
Alex Light5098a612018-11-29 17:12:15 -0800635
636 // Ensure that APEX variant is created for the indirect dep
Colin Cross7113d202019-11-20 16:39:12 -0800637 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_myapex")
Alex Light5098a612018-11-29 17:12:15 -0800638
639 // Ensure that both direct and indirect deps are copied into apex
640 ensureContains(t, copyCmds, "image.zipapex/lib64/mylib.so")
641 ensureContains(t, copyCmds, "image.zipapex/lib64/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900642}
643
644func TestApexWithStubs(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700645 ctx, _ := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +0900646 apex {
647 name: "myapex",
648 key: "myapex.key",
649 native_shared_libs: ["mylib", "mylib3"],
650 }
651
652 apex_key {
653 name: "myapex.key",
654 public_key: "testkey.avbpubkey",
655 private_key: "testkey.pem",
656 }
657
658 cc_library {
659 name: "mylib",
660 srcs: ["mylib.cpp"],
661 shared_libs: ["mylib2", "mylib3"],
662 system_shared_libs: [],
663 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000664 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900665 }
666
667 cc_library {
668 name: "mylib2",
669 srcs: ["mylib.cpp"],
Jiyong Park64379952018-12-13 18:37:29 +0900670 cflags: ["-include mylib.h"],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900671 system_shared_libs: [],
672 stl: "none",
673 stubs: {
674 versions: ["1", "2", "3"],
675 },
676 }
677
678 cc_library {
679 name: "mylib3",
Jiyong Park28d395a2018-12-07 22:42:47 +0900680 srcs: ["mylib.cpp"],
681 shared_libs: ["mylib4"],
682 system_shared_libs: [],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900683 stl: "none",
684 stubs: {
685 versions: ["10", "11", "12"],
686 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000687 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900688 }
Jiyong Park28d395a2018-12-07 22:42:47 +0900689
690 cc_library {
691 name: "mylib4",
692 srcs: ["mylib.cpp"],
693 system_shared_libs: [],
694 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000695 apex_available: [ "myapex" ],
Jiyong Park28d395a2018-12-07 22:42:47 +0900696 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900697 `)
698
Sundong Ahnabb64432019-10-22 13:58:29 +0900699 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900700 copyCmds := apexRule.Args["copy_commands"]
701
702 // Ensure that direct non-stubs dep is always included
Alex Light5098a612018-11-29 17:12:15 -0800703 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900704
705 // Ensure that indirect stubs dep is not included
Alex Light5098a612018-11-29 17:12:15 -0800706 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900707
708 // Ensure that direct stubs dep is included
Alex Light5098a612018-11-29 17:12:15 -0800709 ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900710
Colin Cross7113d202019-11-20 16:39:12 -0800711 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_myapex").Rule("ld").Args["libFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +0900712
713 // Ensure that mylib is linking with the latest version of stubs for mylib2
Jiyong Park3ff16992019-12-27 14:11:47 +0900714 ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_3/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900715 // ... and not linking to the non-stub (impl) variant of mylib2
Jiyong Park3ff16992019-12-27 14:11:47 +0900716 ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900717
718 // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
Colin Cross7113d202019-11-20 16:39:12 -0800719 ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_myapex/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900720 // .. and not linking to the stubs variant of mylib3
Colin Cross7113d202019-11-20 16:39:12 -0800721 ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_12_myapex/mylib3.so")
Jiyong Park64379952018-12-13 18:37:29 +0900722
723 // Ensure that stubs libs are built without -include flags
Jiyong Park0f80c182020-01-31 02:49:53 +0900724 mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jiyong Park64379952018-12-13 18:37:29 +0900725 ensureNotContains(t, mylib2Cflags, "-include ")
Jiyong Park3fd0baf2018-12-07 16:25:39 +0900726
727 // Ensure that genstub is invoked with --apex
Jiyong Park3ff16992019-12-27 14:11:47 +0900728 ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_3").Rule("genStubSrc").Args["flags"])
Jooyung Han671f1ce2019-12-17 12:47:13 +0900729
Jooyung Hana57af4a2020-01-23 05:36:59 +0000730 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Han671f1ce2019-12-17 12:47:13 +0900731 "lib64/mylib.so",
732 "lib64/mylib3.so",
733 "lib64/mylib4.so",
734 })
Jiyong Park25fc6a92018-11-18 18:02:45 +0900735}
736
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900737func TestApexWithExplicitStubsDependency(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700738 ctx, _ := testApex(t, `
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900739 apex {
Jiyong Park83dc74b2020-01-14 18:38:44 +0900740 name: "myapex2",
741 key: "myapex2.key",
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900742 native_shared_libs: ["mylib"],
743 }
744
745 apex_key {
Jiyong Park83dc74b2020-01-14 18:38:44 +0900746 name: "myapex2.key",
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900747 public_key: "testkey.avbpubkey",
748 private_key: "testkey.pem",
749 }
750
751 cc_library {
752 name: "mylib",
753 srcs: ["mylib.cpp"],
754 shared_libs: ["libfoo#10"],
Jiyong Park678c8812020-02-07 17:25:49 +0900755 static_libs: ["libbaz"],
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900756 system_shared_libs: [],
757 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000758 apex_available: [ "myapex2" ],
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900759 }
760
761 cc_library {
762 name: "libfoo",
763 srcs: ["mylib.cpp"],
764 shared_libs: ["libbar"],
765 system_shared_libs: [],
766 stl: "none",
767 stubs: {
768 versions: ["10", "20", "30"],
769 },
770 }
771
772 cc_library {
773 name: "libbar",
774 srcs: ["mylib.cpp"],
775 system_shared_libs: [],
776 stl: "none",
777 }
778
Jiyong Park678c8812020-02-07 17:25:49 +0900779 cc_library_static {
780 name: "libbaz",
781 srcs: ["mylib.cpp"],
782 system_shared_libs: [],
783 stl: "none",
784 apex_available: [ "myapex2" ],
785 }
786
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900787 `)
788
Jiyong Park83dc74b2020-01-14 18:38:44 +0900789 apexRule := ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Rule("apexRule")
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900790 copyCmds := apexRule.Args["copy_commands"]
791
792 // Ensure that direct non-stubs dep is always included
793 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
794
795 // Ensure that indirect stubs dep is not included
796 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
797
798 // Ensure that dependency of stubs is not included
799 ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so")
800
Jiyong Park83dc74b2020-01-14 18:38:44 +0900801 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_myapex2").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900802
803 // Ensure that mylib is linking with version 10 of libfoo
Jiyong Park3ff16992019-12-27 14:11:47 +0900804 ensureContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared_10/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900805 // ... and not linking to the non-stub (impl) variant of libfoo
Jiyong Park3ff16992019-12-27 14:11:47 +0900806 ensureNotContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900807
Jiyong Park3ff16992019-12-27 14:11:47 +0900808 libFooStubsLdFlags := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_10").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900809
810 // Ensure that libfoo stubs is not linking to libbar (since it is a stubs)
811 ensureNotContains(t, libFooStubsLdFlags, "libbar.so")
Jiyong Park83dc74b2020-01-14 18:38:44 +0900812
813 depsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("myapex2-deps-info.txt").Args["content"], "\\n")
Jiyong Park678c8812020-02-07 17:25:49 +0900814
815 ensureListContains(t, depsInfo, "mylib <- myapex2")
816 ensureListContains(t, depsInfo, "libbaz <- mylib")
817 ensureListContains(t, depsInfo, "libfoo (external) <- mylib")
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900818}
819
Jooyung Hand3639552019-08-09 12:57:43 +0900820func TestApexWithRuntimeLibsDependency(t *testing.T) {
821 /*
822 myapex
823 |
824 v (runtime_libs)
825 mylib ------+------> libfoo [provides stub]
826 |
827 `------> libbar
828 */
829 ctx, _ := testApex(t, `
830 apex {
831 name: "myapex",
832 key: "myapex.key",
833 native_shared_libs: ["mylib"],
834 }
835
836 apex_key {
837 name: "myapex.key",
838 public_key: "testkey.avbpubkey",
839 private_key: "testkey.pem",
840 }
841
842 cc_library {
843 name: "mylib",
844 srcs: ["mylib.cpp"],
845 runtime_libs: ["libfoo", "libbar"],
846 system_shared_libs: [],
847 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000848 apex_available: [ "myapex" ],
Jooyung Hand3639552019-08-09 12:57:43 +0900849 }
850
851 cc_library {
852 name: "libfoo",
853 srcs: ["mylib.cpp"],
854 system_shared_libs: [],
855 stl: "none",
856 stubs: {
857 versions: ["10", "20", "30"],
858 },
859 }
860
861 cc_library {
862 name: "libbar",
863 srcs: ["mylib.cpp"],
864 system_shared_libs: [],
865 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000866 apex_available: [ "myapex" ],
Jooyung Hand3639552019-08-09 12:57:43 +0900867 }
868
869 `)
870
Sundong Ahnabb64432019-10-22 13:58:29 +0900871 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jooyung Hand3639552019-08-09 12:57:43 +0900872 copyCmds := apexRule.Args["copy_commands"]
873
874 // Ensure that direct non-stubs dep is always included
875 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
876
877 // Ensure that indirect stubs dep is not included
878 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
879
880 // Ensure that runtime_libs dep in included
881 ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
882
Sundong Ahnabb64432019-10-22 13:58:29 +0900883 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +0900884 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
885 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.so")
Jooyung Hand3639552019-08-09 12:57:43 +0900886
887}
888
Jooyung Han61b66e92020-03-21 14:21:46 +0000889func TestApexDependsOnLLNDKTransitively(t *testing.T) {
890 testcases := []struct {
891 name string
892 minSdkVersion string
893 shouldLink string
894 shouldNotLink []string
895 }{
896 {
Jooyung Han75568392020-03-20 04:29:24 +0900897 name: "should link to the latest",
Jooyung Han61b66e92020-03-21 14:21:46 +0000898 minSdkVersion: "current",
899 shouldLink: "30",
900 shouldNotLink: []string{"29"},
901 },
902 {
903 name: "should link to llndk#29",
904 minSdkVersion: "29",
905 shouldLink: "29",
906 shouldNotLink: []string{"30"},
907 },
908 }
909 for _, tc := range testcases {
910 t.Run(tc.name, func(t *testing.T) {
911 ctx, _ := testApex(t, `
912 apex {
913 name: "myapex",
914 key: "myapex.key",
915 use_vendor: true,
916 native_shared_libs: ["mylib"],
917 min_sdk_version: "`+tc.minSdkVersion+`",
918 }
Jooyung Han9c80bae2019-08-20 17:30:57 +0900919
Jooyung Han61b66e92020-03-21 14:21:46 +0000920 apex_key {
921 name: "myapex.key",
922 public_key: "testkey.avbpubkey",
923 private_key: "testkey.pem",
924 }
Jooyung Han9c80bae2019-08-20 17:30:57 +0900925
Jooyung Han61b66e92020-03-21 14:21:46 +0000926 cc_library {
927 name: "mylib",
928 srcs: ["mylib.cpp"],
929 vendor_available: true,
930 shared_libs: ["libbar"],
931 system_shared_libs: [],
932 stl: "none",
933 apex_available: [ "myapex" ],
934 }
Jooyung Han9c80bae2019-08-20 17:30:57 +0900935
Jooyung Han61b66e92020-03-21 14:21:46 +0000936 cc_library {
937 name: "libbar",
938 srcs: ["mylib.cpp"],
939 system_shared_libs: [],
940 stl: "none",
941 stubs: { versions: ["29","30"] },
942 }
Jooyung Han9c80bae2019-08-20 17:30:57 +0900943
Jooyung Han61b66e92020-03-21 14:21:46 +0000944 llndk_library {
945 name: "libbar",
946 symbol_file: "",
947 }
948 `, func(fs map[string][]byte, config android.Config) {
949 setUseVendorWhitelistForTest(config, []string{"myapex"})
950 }, withUnbundledBuild)
Jooyung Han9c80bae2019-08-20 17:30:57 +0900951
Jooyung Han61b66e92020-03-21 14:21:46 +0000952 // Ensure that LLNDK dep is not included
953 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
954 "lib64/mylib.so",
955 })
Jooyung Han9c80bae2019-08-20 17:30:57 +0900956
Jooyung Han61b66e92020-03-21 14:21:46 +0000957 // Ensure that LLNDK dep is required
958 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
959 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
960 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libbar.so")
Jooyung Han9c80bae2019-08-20 17:30:57 +0900961
Jooyung Han61b66e92020-03-21 14:21:46 +0000962 mylibLdFlags := ctx.ModuleForTests("mylib", "android_vendor.VER_arm64_armv8-a_shared_myapex").Rule("ld").Args["libFlags"]
963 ensureContains(t, mylibLdFlags, "libbar.llndk/android_vendor.VER_arm64_armv8-a_shared_"+tc.shouldLink+"/libbar.so")
964 for _, ver := range tc.shouldNotLink {
965 ensureNotContains(t, mylibLdFlags, "libbar.llndk/android_vendor.VER_arm64_armv8-a_shared_"+ver+"/libbar.so")
966 }
Jooyung Han9c80bae2019-08-20 17:30:57 +0900967
Jooyung Han61b66e92020-03-21 14:21:46 +0000968 mylibCFlags := ctx.ModuleForTests("mylib", "android_vendor.VER_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"]
969 ensureContains(t, mylibCFlags, "__LIBBAR_API__="+tc.shouldLink)
970 })
971 }
Jooyung Han9c80bae2019-08-20 17:30:57 +0900972}
973
Jiyong Park25fc6a92018-11-18 18:02:45 +0900974func TestApexWithSystemLibsStubs(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700975 ctx, _ := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +0900976 apex {
977 name: "myapex",
978 key: "myapex.key",
979 native_shared_libs: ["mylib", "mylib_shared", "libdl", "libm"],
980 }
981
982 apex_key {
983 name: "myapex.key",
984 public_key: "testkey.avbpubkey",
985 private_key: "testkey.pem",
986 }
987
988 cc_library {
989 name: "mylib",
990 srcs: ["mylib.cpp"],
991 shared_libs: ["libdl#27"],
992 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000993 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900994 }
995
996 cc_library_shared {
997 name: "mylib_shared",
998 srcs: ["mylib.cpp"],
999 shared_libs: ["libdl#27"],
1000 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001001 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001002 }
1003
1004 cc_library {
Jiyong Parkb0788572018-12-20 22:10:17 +09001005 name: "libBootstrap",
1006 srcs: ["mylib.cpp"],
1007 stl: "none",
1008 bootstrap: true,
1009 }
Jiyong Park25fc6a92018-11-18 18:02:45 +09001010 `)
1011
Sundong Ahnabb64432019-10-22 13:58:29 +09001012 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001013 copyCmds := apexRule.Args["copy_commands"]
1014
1015 // Ensure that mylib, libm, libdl are included.
Alex Light5098a612018-11-29 17:12:15 -08001016 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Parkb0788572018-12-20 22:10:17 +09001017 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libm.so")
1018 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001019
1020 // Ensure that libc is not included (since it has stubs and not listed in native_shared_libs)
Jiyong Parkb0788572018-12-20 22:10:17 +09001021 ensureNotContains(t, copyCmds, "image.apex/lib64/bionic/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001022
Colin Cross7113d202019-11-20 16:39:12 -08001023 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_myapex").Rule("ld").Args["libFlags"]
1024 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"]
1025 mylibSharedCFlags := ctx.ModuleForTests("mylib_shared", "android_arm64_armv8-a_shared_myapex").Rule("cc").Args["cFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +09001026
1027 // For dependency to libc
1028 // Ensure that mylib is linking with the latest version of stubs
Jiyong Park3ff16992019-12-27 14:11:47 +09001029 ensureContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared_29/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001030 // ... and not linking to the non-stub (impl) variant
Jiyong Park3ff16992019-12-27 14:11:47 +09001031 ensureNotContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001032 // ... Cflags from stub is correctly exported to mylib
1033 ensureContains(t, mylibCFlags, "__LIBC_API__=29")
1034 ensureContains(t, mylibSharedCFlags, "__LIBC_API__=29")
1035
1036 // For dependency to libm
1037 // Ensure that mylib is linking with the non-stub (impl) variant
Colin Cross7113d202019-11-20 16:39:12 -08001038 ensureContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_myapex/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001039 // ... and not linking to the stub variant
Jiyong Park3ff16992019-12-27 14:11:47 +09001040 ensureNotContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_29/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001041 // ... and is not compiling with the stub
1042 ensureNotContains(t, mylibCFlags, "__LIBM_API__=29")
1043 ensureNotContains(t, mylibSharedCFlags, "__LIBM_API__=29")
1044
1045 // For dependency to libdl
1046 // Ensure that mylib is linking with the specified version of stubs
Jiyong Park3ff16992019-12-27 14:11:47 +09001047 ensureContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_27/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001048 // ... and not linking to the other versions of stubs
Jiyong Park3ff16992019-12-27 14:11:47 +09001049 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_28/libdl.so")
1050 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_29/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001051 // ... and not linking to the non-stub (impl) variant
Colin Cross7113d202019-11-20 16:39:12 -08001052 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_myapex/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001053 // ... Cflags from stub is correctly exported to mylib
1054 ensureContains(t, mylibCFlags, "__LIBDL_API__=27")
1055 ensureContains(t, mylibSharedCFlags, "__LIBDL_API__=27")
Jiyong Parkb0788572018-12-20 22:10:17 +09001056
1057 // Ensure that libBootstrap is depending on the platform variant of bionic libs
Colin Cross7113d202019-11-20 16:39:12 -08001058 libFlags := ctx.ModuleForTests("libBootstrap", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
1059 ensureContains(t, libFlags, "libc/android_arm64_armv8-a_shared/libc.so")
1060 ensureContains(t, libFlags, "libm/android_arm64_armv8-a_shared/libm.so")
1061 ensureContains(t, libFlags, "libdl/android_arm64_armv8-a_shared/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001062}
Jiyong Park7c2ee712018-12-07 00:42:25 +09001063
Jooyung Han03b51852020-02-26 22:45:42 +09001064func TestApexUseStubsAccordingToMinSdkVersionInUnbundledBuild(t *testing.T) {
1065 // there are three links between liba --> libz
1066 // 1) myapex -> libx -> liba -> libz : this should be #2 link, but fallback to #1
1067 // 2) otherapex -> liby -> liba -> libz : this should be #3 link
1068 // 3) (platform) -> liba -> libz : this should be non-stub link
1069 ctx, _ := testApex(t, `
1070 apex {
1071 name: "myapex",
1072 key: "myapex.key",
1073 native_shared_libs: ["libx"],
1074 min_sdk_version: "2",
1075 }
1076
1077 apex {
1078 name: "otherapex",
1079 key: "myapex.key",
1080 native_shared_libs: ["liby"],
1081 min_sdk_version: "3",
1082 }
1083
1084 apex_key {
1085 name: "myapex.key",
1086 public_key: "testkey.avbpubkey",
1087 private_key: "testkey.pem",
1088 }
1089
1090 cc_library {
1091 name: "libx",
1092 shared_libs: ["liba"],
1093 system_shared_libs: [],
1094 stl: "none",
1095 apex_available: [ "myapex" ],
1096 }
1097
1098 cc_library {
1099 name: "liby",
1100 shared_libs: ["liba"],
1101 system_shared_libs: [],
1102 stl: "none",
1103 apex_available: [ "otherapex" ],
1104 }
1105
1106 cc_library {
1107 name: "liba",
1108 shared_libs: ["libz"],
1109 system_shared_libs: [],
1110 stl: "none",
1111 apex_available: [
1112 "//apex_available:anyapex",
1113 "//apex_available:platform",
1114 ],
1115 }
1116
1117 cc_library {
1118 name: "libz",
1119 system_shared_libs: [],
1120 stl: "none",
1121 stubs: {
1122 versions: ["1", "3"],
1123 },
1124 }
1125 `, withUnbundledBuild)
1126
1127 expectLink := func(from, from_variant, to, to_variant string) {
1128 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1129 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1130 }
1131 expectNoLink := func(from, from_variant, to, to_variant string) {
1132 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1133 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1134 }
1135 // platform liba is linked to non-stub version
1136 expectLink("liba", "shared", "libz", "shared")
1137 // liba in myapex is linked to #1
1138 expectLink("liba", "shared_myapex", "libz", "shared_1")
1139 expectNoLink("liba", "shared_myapex", "libz", "shared_3")
1140 expectNoLink("liba", "shared_myapex", "libz", "shared")
1141 // liba in otherapex is linked to #3
1142 expectLink("liba", "shared_otherapex", "libz", "shared_3")
1143 expectNoLink("liba", "shared_otherapex", "libz", "shared_1")
1144 expectNoLink("liba", "shared_otherapex", "libz", "shared")
1145}
1146
Jooyung Hanaed150d2020-04-02 01:41:41 +09001147func TestApexMinSdkVersion_SupportsCodeNames(t *testing.T) {
1148 ctx, _ := testApex(t, `
1149 apex {
1150 name: "myapex",
1151 key: "myapex.key",
1152 native_shared_libs: ["libx"],
1153 min_sdk_version: "R",
1154 }
1155
1156 apex_key {
1157 name: "myapex.key",
1158 public_key: "testkey.avbpubkey",
1159 private_key: "testkey.pem",
1160 }
1161
1162 cc_library {
1163 name: "libx",
1164 shared_libs: ["libz"],
1165 system_shared_libs: [],
1166 stl: "none",
1167 apex_available: [ "myapex" ],
1168 }
1169
1170 cc_library {
1171 name: "libz",
1172 system_shared_libs: [],
1173 stl: "none",
1174 stubs: {
1175 versions: ["29", "R"],
1176 },
1177 }
1178 `, func(fs map[string][]byte, config android.Config) {
1179 config.TestProductVariables.Platform_version_active_codenames = []string{"R"}
1180 })
1181
1182 expectLink := func(from, from_variant, to, to_variant string) {
1183 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1184 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1185 }
1186 expectNoLink := func(from, from_variant, to, to_variant string) {
1187 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1188 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1189 }
1190 // 9000 is quite a magic number.
1191 // Finalized SDK codenames are mapped as P(28), Q(29), ...
1192 // And, codenames which are not finalized yet(active_codenames + future_codenames) are numbered from 9000, 9001, ...
1193 // to distinguish them from finalized and future_api(10000)
1194 // In this test, "R" is assumed not finalized yet( listed in Platform_version_active_codenames) and translated into 9000
1195 // (refer android/api_levels.go)
1196 expectLink("libx", "shared_myapex", "libz", "shared_9000")
1197 expectNoLink("libx", "shared_myapex", "libz", "shared_29")
1198 expectNoLink("libx", "shared_myapex", "libz", "shared")
1199}
1200
Jooyung Han03b51852020-02-26 22:45:42 +09001201func TestApexMinSdkVersionDefaultsToLatest(t *testing.T) {
1202 ctx, _ := testApex(t, `
1203 apex {
1204 name: "myapex",
1205 key: "myapex.key",
1206 native_shared_libs: ["libx"],
1207 }
1208
1209 apex_key {
1210 name: "myapex.key",
1211 public_key: "testkey.avbpubkey",
1212 private_key: "testkey.pem",
1213 }
1214
1215 cc_library {
1216 name: "libx",
1217 shared_libs: ["libz"],
1218 system_shared_libs: [],
1219 stl: "none",
1220 apex_available: [ "myapex" ],
1221 }
1222
1223 cc_library {
1224 name: "libz",
1225 system_shared_libs: [],
1226 stl: "none",
1227 stubs: {
1228 versions: ["1", "2"],
1229 },
1230 }
1231 `)
1232
1233 expectLink := func(from, from_variant, to, to_variant string) {
1234 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1235 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1236 }
1237 expectNoLink := func(from, from_variant, to, to_variant string) {
1238 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1239 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1240 }
1241 expectLink("libx", "shared_myapex", "libz", "shared_2")
1242 expectNoLink("libx", "shared_myapex", "libz", "shared_1")
1243 expectNoLink("libx", "shared_myapex", "libz", "shared")
1244}
1245
1246func TestPlatformUsesLatestStubsFromApexes(t *testing.T) {
1247 ctx, _ := testApex(t, `
1248 apex {
1249 name: "myapex",
1250 key: "myapex.key",
1251 native_shared_libs: ["libx"],
1252 }
1253
1254 apex_key {
1255 name: "myapex.key",
1256 public_key: "testkey.avbpubkey",
1257 private_key: "testkey.pem",
1258 }
1259
1260 cc_library {
1261 name: "libx",
1262 system_shared_libs: [],
1263 stl: "none",
1264 apex_available: [ "myapex" ],
1265 stubs: {
1266 versions: ["1", "2"],
1267 },
1268 }
1269
1270 cc_library {
1271 name: "libz",
1272 shared_libs: ["libx"],
1273 system_shared_libs: [],
1274 stl: "none",
1275 }
1276 `)
1277
1278 expectLink := func(from, from_variant, to, to_variant string) {
1279 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1280 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1281 }
1282 expectNoLink := func(from, from_variant, to, to_variant string) {
1283 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1284 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1285 }
1286 expectLink("libz", "shared", "libx", "shared_2")
1287 expectNoLink("libz", "shared", "libz", "shared_1")
1288 expectNoLink("libz", "shared", "libz", "shared")
1289}
1290
Jooyung Han75568392020-03-20 04:29:24 +09001291func TestQApexesUseLatestStubsInBundledBuildsAndHWASAN(t *testing.T) {
Jooyung Han03b51852020-02-26 22:45:42 +09001292 ctx, _ := testApex(t, `
1293 apex {
1294 name: "myapex",
1295 key: "myapex.key",
1296 native_shared_libs: ["libx"],
1297 min_sdk_version: "29",
1298 }
1299
1300 apex_key {
1301 name: "myapex.key",
1302 public_key: "testkey.avbpubkey",
1303 private_key: "testkey.pem",
1304 }
1305
1306 cc_library {
1307 name: "libx",
1308 shared_libs: ["libbar"],
1309 apex_available: [ "myapex" ],
1310 }
1311
1312 cc_library {
1313 name: "libbar",
1314 stubs: {
1315 versions: ["29", "30"],
1316 },
1317 }
Jooyung Han75568392020-03-20 04:29:24 +09001318 `, func(fs map[string][]byte, config android.Config) {
1319 config.TestProductVariables.SanitizeDevice = []string{"hwaddress"}
1320 })
Jooyung Han03b51852020-02-26 22:45:42 +09001321 expectLink := func(from, from_variant, to, to_variant string) {
1322 ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
1323 libFlags := ld.Args["libFlags"]
1324 ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1325 }
Jooyung Han75568392020-03-20 04:29:24 +09001326 expectLink("libx", "shared_hwasan_myapex", "libbar", "shared_30")
Jooyung Han03b51852020-02-26 22:45:42 +09001327}
1328
Jooyung Han75568392020-03-20 04:29:24 +09001329func TestQTargetApexUsesStaticUnwinder(t *testing.T) {
Jooyung Han03b51852020-02-26 22:45:42 +09001330 ctx, _ := testApex(t, `
1331 apex {
1332 name: "myapex",
1333 key: "myapex.key",
1334 native_shared_libs: ["libx"],
1335 min_sdk_version: "29",
1336 }
1337
1338 apex_key {
1339 name: "myapex.key",
1340 public_key: "testkey.avbpubkey",
1341 private_key: "testkey.pem",
1342 }
1343
1344 cc_library {
1345 name: "libx",
1346 apex_available: [ "myapex" ],
1347 }
Jooyung Han75568392020-03-20 04:29:24 +09001348 `)
Jooyung Han03b51852020-02-26 22:45:42 +09001349
1350 // ensure apex variant of c++ is linked with static unwinder
1351 cm := ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared_myapex").Module().(*cc.Module)
1352 ensureListContains(t, cm.Properties.AndroidMkStaticLibs, "libgcc_stripped")
1353 // note that platform variant is not.
1354 cm = ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared").Module().(*cc.Module)
1355 ensureListNotContains(t, cm.Properties.AndroidMkStaticLibs, "libgcc_stripped")
Jooyung Han03b51852020-02-26 22:45:42 +09001356}
1357
1358func TestInvalidMinSdkVersion(t *testing.T) {
Jooyung Han75568392020-03-20 04:29:24 +09001359 testApexError(t, `"libz" .*: not found a version\(<=29\)`, `
Jooyung Han03b51852020-02-26 22:45:42 +09001360 apex {
1361 name: "myapex",
1362 key: "myapex.key",
1363 native_shared_libs: ["libx"],
1364 min_sdk_version: "29",
1365 }
1366
1367 apex_key {
1368 name: "myapex.key",
1369 public_key: "testkey.avbpubkey",
1370 private_key: "testkey.pem",
1371 }
1372
1373 cc_library {
1374 name: "libx",
1375 shared_libs: ["libz"],
1376 system_shared_libs: [],
1377 stl: "none",
1378 apex_available: [ "myapex" ],
1379 }
1380
1381 cc_library {
1382 name: "libz",
1383 system_shared_libs: [],
1384 stl: "none",
1385 stubs: {
1386 versions: ["30"],
1387 },
1388 }
Jooyung Han75568392020-03-20 04:29:24 +09001389 `)
Jooyung Han03b51852020-02-26 22:45:42 +09001390
Jooyung Hanaed150d2020-04-02 01:41:41 +09001391 testApexError(t, `"myapex" .*: min_sdk_version: SDK version should be .*`, `
Jooyung Han03b51852020-02-26 22:45:42 +09001392 apex {
1393 name: "myapex",
1394 key: "myapex.key",
Jooyung Hanaed150d2020-04-02 01:41:41 +09001395 min_sdk_version: "abc",
Jooyung Han03b51852020-02-26 22:45:42 +09001396 }
1397
1398 apex_key {
1399 name: "myapex.key",
1400 public_key: "testkey.avbpubkey",
1401 private_key: "testkey.pem",
1402 }
1403 `)
1404}
1405
Artur Satayev8cf899a2020-04-15 17:29:42 +01001406func TestJavaStableSdkVersion(t *testing.T) {
1407 testCases := []struct {
1408 name string
1409 expectedError string
1410 bp string
1411 }{
1412 {
1413 name: "Non-updatable apex with non-stable dep",
1414 bp: `
1415 apex {
1416 name: "myapex",
1417 java_libs: ["myjar"],
1418 key: "myapex.key",
1419 }
1420 apex_key {
1421 name: "myapex.key",
1422 public_key: "testkey.avbpubkey",
1423 private_key: "testkey.pem",
1424 }
1425 java_library {
1426 name: "myjar",
1427 srcs: ["foo/bar/MyClass.java"],
1428 sdk_version: "core_platform",
1429 apex_available: ["myapex"],
1430 }
1431 `,
1432 },
1433 {
1434 name: "Updatable apex with stable dep",
1435 bp: `
1436 apex {
1437 name: "myapex",
1438 java_libs: ["myjar"],
1439 key: "myapex.key",
1440 updatable: true,
1441 min_sdk_version: "29",
1442 }
1443 apex_key {
1444 name: "myapex.key",
1445 public_key: "testkey.avbpubkey",
1446 private_key: "testkey.pem",
1447 }
1448 java_library {
1449 name: "myjar",
1450 srcs: ["foo/bar/MyClass.java"],
1451 sdk_version: "current",
1452 apex_available: ["myapex"],
1453 }
1454 `,
1455 },
1456 {
1457 name: "Updatable apex with non-stable dep",
1458 expectedError: "cannot depend on \"myjar\"",
1459 bp: `
1460 apex {
1461 name: "myapex",
1462 java_libs: ["myjar"],
1463 key: "myapex.key",
1464 updatable: true,
1465 }
1466 apex_key {
1467 name: "myapex.key",
1468 public_key: "testkey.avbpubkey",
1469 private_key: "testkey.pem",
1470 }
1471 java_library {
1472 name: "myjar",
1473 srcs: ["foo/bar/MyClass.java"],
1474 sdk_version: "core_platform",
1475 apex_available: ["myapex"],
1476 }
1477 `,
1478 },
1479 {
1480 name: "Updatable apex with non-stable transitive dep",
1481 expectedError: "compiles against Android API, but dependency \"transitive-jar\" is compiling against non-public Android API.",
1482 bp: `
1483 apex {
1484 name: "myapex",
1485 java_libs: ["myjar"],
1486 key: "myapex.key",
1487 updatable: true,
1488 }
1489 apex_key {
1490 name: "myapex.key",
1491 public_key: "testkey.avbpubkey",
1492 private_key: "testkey.pem",
1493 }
1494 java_library {
1495 name: "myjar",
1496 srcs: ["foo/bar/MyClass.java"],
1497 sdk_version: "current",
1498 apex_available: ["myapex"],
1499 static_libs: ["transitive-jar"],
1500 }
1501 java_library {
1502 name: "transitive-jar",
1503 srcs: ["foo/bar/MyClass.java"],
1504 sdk_version: "core_platform",
1505 apex_available: ["myapex"],
1506 }
1507 `,
1508 },
1509 }
1510
1511 for _, test := range testCases {
1512 t.Run(test.name, func(t *testing.T) {
1513 if test.expectedError == "" {
1514 testApex(t, test.bp)
1515 } else {
1516 testApexError(t, test.expectedError, test.bp)
1517 }
1518 })
1519 }
1520}
1521
Jiyong Park7c2ee712018-12-07 00:42:25 +09001522func TestFilesInSubDir(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001523 ctx, _ := testApex(t, `
Jiyong Park7c2ee712018-12-07 00:42:25 +09001524 apex {
1525 name: "myapex",
1526 key: "myapex.key",
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001527 native_shared_libs: ["mylib"],
1528 binaries: ["mybin"],
Jiyong Park7c2ee712018-12-07 00:42:25 +09001529 prebuilts: ["myetc"],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001530 compile_multilib: "both",
Jiyong Park7c2ee712018-12-07 00:42:25 +09001531 }
1532
1533 apex_key {
1534 name: "myapex.key",
1535 public_key: "testkey.avbpubkey",
1536 private_key: "testkey.pem",
1537 }
1538
1539 prebuilt_etc {
1540 name: "myetc",
1541 src: "myprebuilt",
1542 sub_dir: "foo/bar",
1543 }
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001544
1545 cc_library {
1546 name: "mylib",
1547 srcs: ["mylib.cpp"],
1548 relative_install_path: "foo/bar",
1549 system_shared_libs: [],
1550 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001551 apex_available: [ "myapex" ],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001552 }
1553
1554 cc_binary {
1555 name: "mybin",
1556 srcs: ["mylib.cpp"],
1557 relative_install_path: "foo/bar",
1558 system_shared_libs: [],
1559 static_executable: true,
1560 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001561 apex_available: [ "myapex" ],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001562 }
Jiyong Park7c2ee712018-12-07 00:42:25 +09001563 `)
1564
Sundong Ahnabb64432019-10-22 13:58:29 +09001565 generateFsRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("generateFsConfig")
Jiyong Park7c2ee712018-12-07 00:42:25 +09001566 dirs := strings.Split(generateFsRule.Args["exec_paths"], " ")
1567
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001568 // Ensure that the subdirectories are all listed
Jiyong Park7c2ee712018-12-07 00:42:25 +09001569 ensureListContains(t, dirs, "etc")
1570 ensureListContains(t, dirs, "etc/foo")
1571 ensureListContains(t, dirs, "etc/foo/bar")
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001572 ensureListContains(t, dirs, "lib64")
1573 ensureListContains(t, dirs, "lib64/foo")
1574 ensureListContains(t, dirs, "lib64/foo/bar")
1575 ensureListContains(t, dirs, "lib")
1576 ensureListContains(t, dirs, "lib/foo")
1577 ensureListContains(t, dirs, "lib/foo/bar")
1578
Jiyong Parkbd13e442019-03-15 18:10:35 +09001579 ensureListContains(t, dirs, "bin")
1580 ensureListContains(t, dirs, "bin/foo")
1581 ensureListContains(t, dirs, "bin/foo/bar")
Jiyong Park7c2ee712018-12-07 00:42:25 +09001582}
Jiyong Parkda6eb592018-12-19 17:12:36 +09001583
Jooyung Han35155c42020-02-06 17:33:20 +09001584func TestFilesInSubDirWhenNativeBridgeEnabled(t *testing.T) {
1585 ctx, _ := testApex(t, `
1586 apex {
1587 name: "myapex",
1588 key: "myapex.key",
1589 multilib: {
1590 both: {
1591 native_shared_libs: ["mylib"],
1592 binaries: ["mybin"],
1593 },
1594 },
1595 compile_multilib: "both",
1596 native_bridge_supported: true,
1597 }
1598
1599 apex_key {
1600 name: "myapex.key",
1601 public_key: "testkey.avbpubkey",
1602 private_key: "testkey.pem",
1603 }
1604
1605 cc_library {
1606 name: "mylib",
1607 relative_install_path: "foo/bar",
1608 system_shared_libs: [],
1609 stl: "none",
1610 apex_available: [ "myapex" ],
1611 native_bridge_supported: true,
1612 }
1613
1614 cc_binary {
1615 name: "mybin",
1616 relative_install_path: "foo/bar",
1617 system_shared_libs: [],
1618 static_executable: true,
1619 stl: "none",
1620 apex_available: [ "myapex" ],
1621 native_bridge_supported: true,
1622 compile_multilib: "both", // default is "first" for binary
1623 multilib: {
1624 lib64: {
1625 suffix: "64",
1626 },
1627 },
1628 }
1629 `, withNativeBridgeEnabled)
1630 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
1631 "bin/foo/bar/mybin",
1632 "bin/foo/bar/mybin64",
1633 "bin/arm/foo/bar/mybin",
1634 "bin/arm64/foo/bar/mybin64",
1635 "lib/foo/bar/mylib.so",
1636 "lib/arm/foo/bar/mylib.so",
1637 "lib64/foo/bar/mylib.so",
1638 "lib64/arm64/foo/bar/mylib.so",
1639 })
1640}
1641
Jiyong Parkda6eb592018-12-19 17:12:36 +09001642func TestUseVendor(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001643 ctx, _ := testApex(t, `
Jiyong Parkda6eb592018-12-19 17:12:36 +09001644 apex {
1645 name: "myapex",
1646 key: "myapex.key",
1647 native_shared_libs: ["mylib"],
1648 use_vendor: true,
1649 }
1650
1651 apex_key {
1652 name: "myapex.key",
1653 public_key: "testkey.avbpubkey",
1654 private_key: "testkey.pem",
1655 }
1656
1657 cc_library {
1658 name: "mylib",
1659 srcs: ["mylib.cpp"],
1660 shared_libs: ["mylib2"],
1661 system_shared_libs: [],
1662 vendor_available: true,
1663 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001664 apex_available: [ "myapex" ],
Jiyong Parkda6eb592018-12-19 17:12:36 +09001665 }
1666
1667 cc_library {
1668 name: "mylib2",
1669 srcs: ["mylib.cpp"],
1670 system_shared_libs: [],
1671 vendor_available: true,
1672 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001673 apex_available: [ "myapex" ],
Jiyong Parkda6eb592018-12-19 17:12:36 +09001674 }
Jooyung Handc782442019-11-01 03:14:38 +09001675 `, func(fs map[string][]byte, config android.Config) {
1676 setUseVendorWhitelistForTest(config, []string{"myapex"})
1677 })
Jiyong Parkda6eb592018-12-19 17:12:36 +09001678
1679 inputsList := []string{}
Sundong Ahnabb64432019-10-22 13:58:29 +09001680 for _, i := range ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().BuildParamsForTests() {
Jiyong Parkda6eb592018-12-19 17:12:36 +09001681 for _, implicit := range i.Implicits {
1682 inputsList = append(inputsList, implicit.String())
1683 }
1684 }
1685 inputsString := strings.Join(inputsList, " ")
1686
1687 // ensure that the apex includes vendor variants of the direct and indirect deps
Colin Crossfb0c16e2019-11-20 17:12:35 -08001688 ensureContains(t, inputsString, "android_vendor.VER_arm64_armv8-a_shared_myapex/mylib.so")
1689 ensureContains(t, inputsString, "android_vendor.VER_arm64_armv8-a_shared_myapex/mylib2.so")
Jiyong Parkda6eb592018-12-19 17:12:36 +09001690
1691 // ensure that the apex does not include core variants
Colin Cross7113d202019-11-20 16:39:12 -08001692 ensureNotContains(t, inputsString, "android_arm64_armv8-a_shared_myapex/mylib.so")
1693 ensureNotContains(t, inputsString, "android_arm64_armv8-a_shared_myapex/mylib2.so")
Jiyong Parkda6eb592018-12-19 17:12:36 +09001694}
Jiyong Park16e91a02018-12-20 18:18:08 +09001695
Jooyung Handc782442019-11-01 03:14:38 +09001696func TestUseVendorRestriction(t *testing.T) {
1697 testApexError(t, `module "myapex" .*: use_vendor: not allowed`, `
1698 apex {
1699 name: "myapex",
1700 key: "myapex.key",
1701 use_vendor: true,
1702 }
1703 apex_key {
1704 name: "myapex.key",
1705 public_key: "testkey.avbpubkey",
1706 private_key: "testkey.pem",
1707 }
1708 `, func(fs map[string][]byte, config android.Config) {
1709 setUseVendorWhitelistForTest(config, []string{""})
1710 })
1711 // no error with whitelist
1712 testApex(t, `
1713 apex {
1714 name: "myapex",
1715 key: "myapex.key",
1716 use_vendor: true,
1717 }
1718 apex_key {
1719 name: "myapex.key",
1720 public_key: "testkey.avbpubkey",
1721 private_key: "testkey.pem",
1722 }
1723 `, func(fs map[string][]byte, config android.Config) {
1724 setUseVendorWhitelistForTest(config, []string{"myapex"})
1725 })
1726}
1727
Jooyung Han5c998b92019-06-27 11:30:33 +09001728func TestUseVendorFailsIfNotVendorAvailable(t *testing.T) {
1729 testApexError(t, `dependency "mylib" of "myapex" missing variant:\n.*image:vendor`, `
1730 apex {
1731 name: "myapex",
1732 key: "myapex.key",
1733 native_shared_libs: ["mylib"],
1734 use_vendor: true,
1735 }
1736
1737 apex_key {
1738 name: "myapex.key",
1739 public_key: "testkey.avbpubkey",
1740 private_key: "testkey.pem",
1741 }
1742
1743 cc_library {
1744 name: "mylib",
1745 srcs: ["mylib.cpp"],
1746 system_shared_libs: [],
1747 stl: "none",
1748 }
1749 `)
1750}
1751
Jiyong Park16e91a02018-12-20 18:18:08 +09001752func TestStaticLinking(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001753 ctx, _ := testApex(t, `
Jiyong Park16e91a02018-12-20 18:18:08 +09001754 apex {
1755 name: "myapex",
1756 key: "myapex.key",
1757 native_shared_libs: ["mylib"],
1758 }
1759
1760 apex_key {
1761 name: "myapex.key",
1762 public_key: "testkey.avbpubkey",
1763 private_key: "testkey.pem",
1764 }
1765
1766 cc_library {
1767 name: "mylib",
1768 srcs: ["mylib.cpp"],
1769 system_shared_libs: [],
1770 stl: "none",
1771 stubs: {
1772 versions: ["1", "2", "3"],
1773 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001774 apex_available: [
1775 "//apex_available:platform",
1776 "myapex",
1777 ],
Jiyong Park16e91a02018-12-20 18:18:08 +09001778 }
1779
1780 cc_binary {
1781 name: "not_in_apex",
1782 srcs: ["mylib.cpp"],
1783 static_libs: ["mylib"],
1784 static_executable: true,
1785 system_shared_libs: [],
1786 stl: "none",
1787 }
Jiyong Park16e91a02018-12-20 18:18:08 +09001788 `)
1789
Colin Cross7113d202019-11-20 16:39:12 -08001790 ldFlags := ctx.ModuleForTests("not_in_apex", "android_arm64_armv8-a").Rule("ld").Args["libFlags"]
Jiyong Park16e91a02018-12-20 18:18:08 +09001791
1792 // Ensure that not_in_apex is linking with the static variant of mylib
Colin Cross7113d202019-11-20 16:39:12 -08001793 ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_static/mylib.a")
Jiyong Park16e91a02018-12-20 18:18:08 +09001794}
Jiyong Park9335a262018-12-24 11:31:58 +09001795
1796func TestKeys(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001797 ctx, _ := testApex(t, `
Jiyong Park9335a262018-12-24 11:31:58 +09001798 apex {
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001799 name: "myapex_keytest",
Jiyong Park9335a262018-12-24 11:31:58 +09001800 key: "myapex.key",
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001801 certificate: ":myapex.certificate",
Jiyong Park9335a262018-12-24 11:31:58 +09001802 native_shared_libs: ["mylib"],
Jooyung Han54aca7b2019-11-20 02:26:02 +09001803 file_contexts: ":myapex-file_contexts",
Jiyong Park9335a262018-12-24 11:31:58 +09001804 }
1805
1806 cc_library {
1807 name: "mylib",
1808 srcs: ["mylib.cpp"],
1809 system_shared_libs: [],
1810 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001811 apex_available: [ "myapex_keytest" ],
Jiyong Park9335a262018-12-24 11:31:58 +09001812 }
1813
1814 apex_key {
1815 name: "myapex.key",
1816 public_key: "testkey.avbpubkey",
1817 private_key: "testkey.pem",
1818 }
1819
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001820 android_app_certificate {
1821 name: "myapex.certificate",
1822 certificate: "testkey",
1823 }
1824
1825 android_app_certificate {
1826 name: "myapex.certificate.override",
1827 certificate: "testkey.override",
1828 }
1829
Jiyong Park9335a262018-12-24 11:31:58 +09001830 `)
1831
1832 // check the APEX keys
Jiyong Parkd1e293d2019-03-15 02:13:21 +09001833 keys := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
Jiyong Park9335a262018-12-24 11:31:58 +09001834
1835 if keys.public_key_file.String() != "vendor/foo/devkeys/testkey.avbpubkey" {
1836 t.Errorf("public key %q is not %q", keys.public_key_file.String(),
1837 "vendor/foo/devkeys/testkey.avbpubkey")
1838 }
1839 if keys.private_key_file.String() != "vendor/foo/devkeys/testkey.pem" {
1840 t.Errorf("private key %q is not %q", keys.private_key_file.String(),
1841 "vendor/foo/devkeys/testkey.pem")
1842 }
1843
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001844 // check the APK certs. It should be overridden to myapex.certificate.override
Sundong Ahnabb64432019-10-22 13:58:29 +09001845 certs := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk").Args["certificates"]
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001846 if certs != "testkey.override.x509.pem testkey.override.pk8" {
Jiyong Park9335a262018-12-24 11:31:58 +09001847 t.Errorf("cert and private key %q are not %q", certs,
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001848 "testkey.override.509.pem testkey.override.pk8")
Jiyong Park9335a262018-12-24 11:31:58 +09001849 }
1850}
Jiyong Park58e364a2019-01-19 19:24:06 +09001851
Jooyung Hanf121a652019-12-17 14:30:11 +09001852func TestCertificate(t *testing.T) {
1853 t.Run("if unspecified, it defaults to DefaultAppCertificate", func(t *testing.T) {
1854 ctx, _ := testApex(t, `
1855 apex {
1856 name: "myapex",
1857 key: "myapex.key",
1858 }
1859 apex_key {
1860 name: "myapex.key",
1861 public_key: "testkey.avbpubkey",
1862 private_key: "testkey.pem",
1863 }`)
1864 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
1865 expected := "vendor/foo/devkeys/test.x509.pem vendor/foo/devkeys/test.pk8"
1866 if actual := rule.Args["certificates"]; actual != expected {
1867 t.Errorf("certificates should be %q, not %q", expected, actual)
1868 }
1869 })
1870 t.Run("override when unspecified", func(t *testing.T) {
1871 ctx, _ := testApex(t, `
1872 apex {
1873 name: "myapex_keytest",
1874 key: "myapex.key",
1875 file_contexts: ":myapex-file_contexts",
1876 }
1877 apex_key {
1878 name: "myapex.key",
1879 public_key: "testkey.avbpubkey",
1880 private_key: "testkey.pem",
1881 }
1882 android_app_certificate {
1883 name: "myapex.certificate.override",
1884 certificate: "testkey.override",
1885 }`)
1886 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
1887 expected := "testkey.override.x509.pem testkey.override.pk8"
1888 if actual := rule.Args["certificates"]; actual != expected {
1889 t.Errorf("certificates should be %q, not %q", expected, actual)
1890 }
1891 })
1892 t.Run("if specified as :module, it respects the prop", func(t *testing.T) {
1893 ctx, _ := testApex(t, `
1894 apex {
1895 name: "myapex",
1896 key: "myapex.key",
1897 certificate: ":myapex.certificate",
1898 }
1899 apex_key {
1900 name: "myapex.key",
1901 public_key: "testkey.avbpubkey",
1902 private_key: "testkey.pem",
1903 }
1904 android_app_certificate {
1905 name: "myapex.certificate",
1906 certificate: "testkey",
1907 }`)
1908 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
1909 expected := "testkey.x509.pem testkey.pk8"
1910 if actual := rule.Args["certificates"]; actual != expected {
1911 t.Errorf("certificates should be %q, not %q", expected, actual)
1912 }
1913 })
1914 t.Run("override when specifiec as <:module>", func(t *testing.T) {
1915 ctx, _ := testApex(t, `
1916 apex {
1917 name: "myapex_keytest",
1918 key: "myapex.key",
1919 file_contexts: ":myapex-file_contexts",
1920 certificate: ":myapex.certificate",
1921 }
1922 apex_key {
1923 name: "myapex.key",
1924 public_key: "testkey.avbpubkey",
1925 private_key: "testkey.pem",
1926 }
1927 android_app_certificate {
1928 name: "myapex.certificate.override",
1929 certificate: "testkey.override",
1930 }`)
1931 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
1932 expected := "testkey.override.x509.pem testkey.override.pk8"
1933 if actual := rule.Args["certificates"]; actual != expected {
1934 t.Errorf("certificates should be %q, not %q", expected, actual)
1935 }
1936 })
1937 t.Run("if specified as name, finds it from DefaultDevKeyDir", func(t *testing.T) {
1938 ctx, _ := testApex(t, `
1939 apex {
1940 name: "myapex",
1941 key: "myapex.key",
1942 certificate: "testkey",
1943 }
1944 apex_key {
1945 name: "myapex.key",
1946 public_key: "testkey.avbpubkey",
1947 private_key: "testkey.pem",
1948 }`)
1949 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
1950 expected := "vendor/foo/devkeys/testkey.x509.pem vendor/foo/devkeys/testkey.pk8"
1951 if actual := rule.Args["certificates"]; actual != expected {
1952 t.Errorf("certificates should be %q, not %q", expected, actual)
1953 }
1954 })
1955 t.Run("override when specified as <name>", func(t *testing.T) {
1956 ctx, _ := testApex(t, `
1957 apex {
1958 name: "myapex_keytest",
1959 key: "myapex.key",
1960 file_contexts: ":myapex-file_contexts",
1961 certificate: "testkey",
1962 }
1963 apex_key {
1964 name: "myapex.key",
1965 public_key: "testkey.avbpubkey",
1966 private_key: "testkey.pem",
1967 }
1968 android_app_certificate {
1969 name: "myapex.certificate.override",
1970 certificate: "testkey.override",
1971 }`)
1972 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
1973 expected := "testkey.override.x509.pem testkey.override.pk8"
1974 if actual := rule.Args["certificates"]; actual != expected {
1975 t.Errorf("certificates should be %q, not %q", expected, actual)
1976 }
1977 })
1978}
1979
Jiyong Park58e364a2019-01-19 19:24:06 +09001980func TestMacro(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001981 ctx, _ := testApex(t, `
Jiyong Park58e364a2019-01-19 19:24:06 +09001982 apex {
1983 name: "myapex",
1984 key: "myapex.key",
Jooyung Hanc87a0592020-03-02 17:44:33 +09001985 native_shared_libs: ["mylib", "mylib2"],
Jiyong Park58e364a2019-01-19 19:24:06 +09001986 }
1987
1988 apex {
1989 name: "otherapex",
1990 key: "myapex.key",
Jooyung Hanc87a0592020-03-02 17:44:33 +09001991 native_shared_libs: ["mylib", "mylib2"],
Jooyung Hanccce2f22020-03-07 03:45:53 +09001992 min_sdk_version: "29",
Jiyong Park58e364a2019-01-19 19:24:06 +09001993 }
1994
1995 apex_key {
1996 name: "myapex.key",
1997 public_key: "testkey.avbpubkey",
1998 private_key: "testkey.pem",
1999 }
2000
2001 cc_library {
2002 name: "mylib",
2003 srcs: ["mylib.cpp"],
2004 system_shared_libs: [],
2005 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002006 apex_available: [
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002007 "myapex",
2008 "otherapex",
2009 ],
Jooyung Han24282772020-03-21 23:20:55 +09002010 recovery_available: true,
Jiyong Park58e364a2019-01-19 19:24:06 +09002011 }
Jooyung Hanc87a0592020-03-02 17:44:33 +09002012 cc_library {
2013 name: "mylib2",
2014 srcs: ["mylib.cpp"],
2015 system_shared_libs: [],
2016 stl: "none",
2017 apex_available: [
2018 "myapex",
2019 "otherapex",
2020 ],
2021 use_apex_name_macro: true,
2022 }
Jiyong Park58e364a2019-01-19 19:24:06 +09002023 `)
2024
Jooyung Hanc87a0592020-03-02 17:44:33 +09002025 // non-APEX variant does not have __ANDROID_APEX__ defined
Colin Cross7113d202019-11-20 16:39:12 -08002026 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09002027 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Han75568392020-03-20 04:29:24 +09002028 ensureNotContains(t, mylibCFlags, "-D__ANDROID_SDK_VERSION__")
Jooyung Hanc87a0592020-03-02 17:44:33 +09002029
Jooyung Hanccce2f22020-03-07 03:45:53 +09002030 // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
Jooyung Hanc87a0592020-03-02 17:44:33 +09002031 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"]
2032 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Hanccce2f22020-03-07 03:45:53 +09002033 ensureContains(t, mylibCFlags, "-D__ANDROID_SDK_VERSION__=10000")
Jooyung Han77988572019-10-18 16:26:16 +09002034 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
Jooyung Hanc87a0592020-03-02 17:44:33 +09002035
Jooyung Hanccce2f22020-03-07 03:45:53 +09002036 // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
Jooyung Hanc87a0592020-03-02 17:44:33 +09002037 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_otherapex").Rule("cc").Args["cFlags"]
2038 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Hanccce2f22020-03-07 03:45:53 +09002039 ensureContains(t, mylibCFlags, "-D__ANDROID_SDK_VERSION__=29")
Jooyung Han77988572019-10-18 16:26:16 +09002040 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09002041
Jooyung Hanc87a0592020-03-02 17:44:33 +09002042 // When cc_library sets use_apex_name_macro: true
2043 // apex variants define additional macro to distinguish which apex variant it is built for
2044
2045 // non-APEX variant does not have __ANDROID_APEX__ defined
2046 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
2047 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
2048
2049 // APEX variant has __ANDROID_APEX__ defined
2050 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09002051 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Han77988572019-10-18 16:26:16 +09002052 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
2053 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09002054
Jooyung Hanc87a0592020-03-02 17:44:33 +09002055 // APEX variant has __ANDROID_APEX__ defined
2056 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_otherapex").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09002057 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Han77988572019-10-18 16:26:16 +09002058 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
2059 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jooyung Han24282772020-03-21 23:20:55 +09002060
2061 // recovery variant does not set __ANDROID_SDK_VERSION__
2062 mylibCFlags = ctx.ModuleForTests("mylib", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
2063 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
2064 ensureNotContains(t, mylibCFlags, "-D__ANDROID_SDK_VERSION__")
Jiyong Park58e364a2019-01-19 19:24:06 +09002065}
Jiyong Park7e636d02019-01-28 16:16:54 +09002066
2067func TestHeaderLibsDependency(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002068 ctx, _ := testApex(t, `
Jiyong Park7e636d02019-01-28 16:16:54 +09002069 apex {
2070 name: "myapex",
2071 key: "myapex.key",
2072 native_shared_libs: ["mylib"],
2073 }
2074
2075 apex_key {
2076 name: "myapex.key",
2077 public_key: "testkey.avbpubkey",
2078 private_key: "testkey.pem",
2079 }
2080
2081 cc_library_headers {
2082 name: "mylib_headers",
2083 export_include_dirs: ["my_include"],
2084 system_shared_libs: [],
2085 stl: "none",
Jiyong Park0f80c182020-01-31 02:49:53 +09002086 apex_available: [ "myapex" ],
Jiyong Park7e636d02019-01-28 16:16:54 +09002087 }
2088
2089 cc_library {
2090 name: "mylib",
2091 srcs: ["mylib.cpp"],
2092 system_shared_libs: [],
2093 stl: "none",
2094 header_libs: ["mylib_headers"],
2095 export_header_lib_headers: ["mylib_headers"],
2096 stubs: {
2097 versions: ["1", "2", "3"],
2098 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002099 apex_available: [ "myapex" ],
Jiyong Park7e636d02019-01-28 16:16:54 +09002100 }
2101
2102 cc_library {
2103 name: "otherlib",
2104 srcs: ["mylib.cpp"],
2105 system_shared_libs: [],
2106 stl: "none",
2107 shared_libs: ["mylib"],
2108 }
2109 `)
2110
Colin Cross7113d202019-11-20 16:39:12 -08002111 cFlags := ctx.ModuleForTests("otherlib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jiyong Park7e636d02019-01-28 16:16:54 +09002112
2113 // Ensure that the include path of the header lib is exported to 'otherlib'
2114 ensureContains(t, cFlags, "-Imy_include")
2115}
Alex Light9670d332019-01-29 18:07:33 -08002116
Jiyong Park7cd10e32020-01-14 09:22:18 +09002117type fileInApex struct {
2118 path string // path in apex
Jooyung Hana57af4a2020-01-23 05:36:59 +00002119 src string // src path
Jiyong Park7cd10e32020-01-14 09:22:18 +09002120 isLink bool
2121}
2122
Jooyung Hana57af4a2020-01-23 05:36:59 +00002123func getFiles(t *testing.T, ctx *android.TestContext, moduleName, variant string) []fileInApex {
Jooyung Han31c470b2019-10-18 16:26:59 +09002124 t.Helper()
Jooyung Hana57af4a2020-01-23 05:36:59 +00002125 apexRule := ctx.ModuleForTests(moduleName, variant).Rule("apexRule")
Jooyung Han31c470b2019-10-18 16:26:59 +09002126 copyCmds := apexRule.Args["copy_commands"]
2127 imageApexDir := "/image.apex/"
Jiyong Park7cd10e32020-01-14 09:22:18 +09002128 var ret []fileInApex
Jooyung Han31c470b2019-10-18 16:26:59 +09002129 for _, cmd := range strings.Split(copyCmds, "&&") {
2130 cmd = strings.TrimSpace(cmd)
2131 if cmd == "" {
2132 continue
2133 }
2134 terms := strings.Split(cmd, " ")
Jooyung Hana57af4a2020-01-23 05:36:59 +00002135 var dst, src string
Jiyong Park7cd10e32020-01-14 09:22:18 +09002136 var isLink bool
Jooyung Han31c470b2019-10-18 16:26:59 +09002137 switch terms[0] {
2138 case "mkdir":
2139 case "cp":
Jiyong Park7cd10e32020-01-14 09:22:18 +09002140 if len(terms) != 3 && len(terms) != 4 {
Jooyung Han31c470b2019-10-18 16:26:59 +09002141 t.Fatal("copyCmds contains invalid cp command", cmd)
2142 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09002143 dst = terms[len(terms)-1]
Jooyung Hana57af4a2020-01-23 05:36:59 +00002144 src = terms[len(terms)-2]
Jiyong Park7cd10e32020-01-14 09:22:18 +09002145 isLink = false
2146 case "ln":
2147 if len(terms) != 3 && len(terms) != 4 {
2148 // ln LINK TARGET or ln -s LINK TARGET
2149 t.Fatal("copyCmds contains invalid ln command", cmd)
2150 }
2151 dst = terms[len(terms)-1]
Jooyung Hana57af4a2020-01-23 05:36:59 +00002152 src = terms[len(terms)-2]
Jiyong Park7cd10e32020-01-14 09:22:18 +09002153 isLink = true
2154 default:
2155 t.Fatalf("copyCmds should contain mkdir/cp commands only: %q", cmd)
2156 }
2157 if dst != "" {
Jooyung Han31c470b2019-10-18 16:26:59 +09002158 index := strings.Index(dst, imageApexDir)
2159 if index == -1 {
2160 t.Fatal("copyCmds should copy a file to image.apex/", cmd)
2161 }
2162 dstFile := dst[index+len(imageApexDir):]
Jooyung Hana57af4a2020-01-23 05:36:59 +00002163 ret = append(ret, fileInApex{path: dstFile, src: src, isLink: isLink})
Jooyung Han31c470b2019-10-18 16:26:59 +09002164 }
2165 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09002166 return ret
2167}
2168
Jooyung Hana57af4a2020-01-23 05:36:59 +00002169func ensureExactContents(t *testing.T, ctx *android.TestContext, moduleName, variant string, files []string) {
2170 t.Helper()
Jiyong Park7cd10e32020-01-14 09:22:18 +09002171 var failed bool
2172 var surplus []string
2173 filesMatched := make(map[string]bool)
Jooyung Hana57af4a2020-01-23 05:36:59 +00002174 for _, file := range getFiles(t, ctx, moduleName, variant) {
Jooyung Hane6436d72020-02-27 13:31:56 +09002175 mactchFound := false
Jiyong Park7cd10e32020-01-14 09:22:18 +09002176 for _, expected := range files {
2177 if matched, _ := path.Match(expected, file.path); matched {
2178 filesMatched[expected] = true
Jooyung Hane6436d72020-02-27 13:31:56 +09002179 mactchFound = true
2180 break
Jiyong Park7cd10e32020-01-14 09:22:18 +09002181 }
2182 }
Jooyung Hane6436d72020-02-27 13:31:56 +09002183 if !mactchFound {
2184 surplus = append(surplus, file.path)
2185 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09002186 }
Jooyung Han31c470b2019-10-18 16:26:59 +09002187
Jooyung Han31c470b2019-10-18 16:26:59 +09002188 if len(surplus) > 0 {
Jooyung Han39edb6c2019-11-06 16:53:07 +09002189 sort.Strings(surplus)
Jooyung Han31c470b2019-10-18 16:26:59 +09002190 t.Log("surplus files", surplus)
2191 failed = true
2192 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09002193
2194 if len(files) > len(filesMatched) {
2195 var missing []string
2196 for _, expected := range files {
2197 if !filesMatched[expected] {
2198 missing = append(missing, expected)
2199 }
2200 }
2201 sort.Strings(missing)
Jooyung Han31c470b2019-10-18 16:26:59 +09002202 t.Log("missing files", missing)
2203 failed = true
2204 }
2205 if failed {
2206 t.Fail()
2207 }
2208}
2209
Jooyung Han344d5432019-08-23 11:17:39 +09002210func TestVndkApexCurrent(t *testing.T) {
2211 ctx, _ := testApex(t, `
2212 apex_vndk {
2213 name: "myapex",
2214 key: "myapex.key",
Jooyung Han344d5432019-08-23 11:17:39 +09002215 }
2216
2217 apex_key {
2218 name: "myapex.key",
2219 public_key: "testkey.avbpubkey",
2220 private_key: "testkey.pem",
2221 }
2222
2223 cc_library {
2224 name: "libvndk",
2225 srcs: ["mylib.cpp"],
2226 vendor_available: true,
2227 vndk: {
2228 enabled: true,
2229 },
2230 system_shared_libs: [],
2231 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002232 apex_available: [ "myapex" ],
Jooyung Han344d5432019-08-23 11:17:39 +09002233 }
2234
2235 cc_library {
2236 name: "libvndksp",
2237 srcs: ["mylib.cpp"],
2238 vendor_available: true,
2239 vndk: {
2240 enabled: true,
2241 support_system_process: true,
2242 },
2243 system_shared_libs: [],
2244 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002245 apex_available: [ "myapex" ],
Jooyung Han344d5432019-08-23 11:17:39 +09002246 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09002247 `+vndkLibrariesTxtFiles("current"))
Jooyung Han344d5432019-08-23 11:17:39 +09002248
Jooyung Hana57af4a2020-01-23 05:36:59 +00002249 ensureExactContents(t, ctx, "myapex", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09002250 "lib/libvndk.so",
2251 "lib/libvndksp.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09002252 "lib/libc++.so",
Jooyung Han31c470b2019-10-18 16:26:59 +09002253 "lib64/libvndk.so",
2254 "lib64/libvndksp.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09002255 "lib64/libc++.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09002256 "etc/llndk.libraries.VER.txt",
2257 "etc/vndkcore.libraries.VER.txt",
2258 "etc/vndksp.libraries.VER.txt",
2259 "etc/vndkprivate.libraries.VER.txt",
Jooyung Han31c470b2019-10-18 16:26:59 +09002260 })
Jooyung Han344d5432019-08-23 11:17:39 +09002261}
2262
2263func TestVndkApexWithPrebuilt(t *testing.T) {
2264 ctx, _ := testApex(t, `
2265 apex_vndk {
2266 name: "myapex",
2267 key: "myapex.key",
Jooyung Han344d5432019-08-23 11:17:39 +09002268 }
2269
2270 apex_key {
2271 name: "myapex.key",
2272 public_key: "testkey.avbpubkey",
2273 private_key: "testkey.pem",
2274 }
2275
2276 cc_prebuilt_library_shared {
Jooyung Han31c470b2019-10-18 16:26:59 +09002277 name: "libvndk",
2278 srcs: ["libvndk.so"],
Jooyung Han344d5432019-08-23 11:17:39 +09002279 vendor_available: true,
2280 vndk: {
2281 enabled: true,
2282 },
2283 system_shared_libs: [],
2284 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002285 apex_available: [ "myapex" ],
Jooyung Han344d5432019-08-23 11:17:39 +09002286 }
Jooyung Han31c470b2019-10-18 16:26:59 +09002287
2288 cc_prebuilt_library_shared {
2289 name: "libvndk.arm",
2290 srcs: ["libvndk.arm.so"],
2291 vendor_available: true,
2292 vndk: {
2293 enabled: true,
2294 },
2295 enabled: false,
2296 arch: {
2297 arm: {
2298 enabled: true,
2299 },
2300 },
2301 system_shared_libs: [],
2302 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002303 apex_available: [ "myapex" ],
Jooyung Han31c470b2019-10-18 16:26:59 +09002304 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09002305 `+vndkLibrariesTxtFiles("current"),
2306 withFiles(map[string][]byte{
2307 "libvndk.so": nil,
2308 "libvndk.arm.so": nil,
2309 }))
Jooyung Han344d5432019-08-23 11:17:39 +09002310
Jooyung Hana57af4a2020-01-23 05:36:59 +00002311 ensureExactContents(t, ctx, "myapex", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09002312 "lib/libvndk.so",
2313 "lib/libvndk.arm.so",
2314 "lib64/libvndk.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09002315 "lib/libc++.so",
2316 "lib64/libc++.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09002317 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09002318 })
Jooyung Han344d5432019-08-23 11:17:39 +09002319}
2320
Jooyung Han39edb6c2019-11-06 16:53:07 +09002321func vndkLibrariesTxtFiles(vers ...string) (result string) {
2322 for _, v := range vers {
2323 if v == "current" {
Kiyoung Kime1aa8ea2019-12-30 11:12:55 +09002324 for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate"} {
Jooyung Han39edb6c2019-11-06 16:53:07 +09002325 result += `
2326 vndk_libraries_txt {
2327 name: "` + txt + `.libraries.txt",
2328 }
2329 `
2330 }
2331 } else {
2332 for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate"} {
2333 result += `
2334 prebuilt_etc {
2335 name: "` + txt + `.libraries.` + v + `.txt",
2336 src: "dummy.txt",
2337 }
2338 `
2339 }
2340 }
2341 }
2342 return
2343}
2344
Jooyung Han344d5432019-08-23 11:17:39 +09002345func TestVndkApexVersion(t *testing.T) {
2346 ctx, _ := testApex(t, `
2347 apex_vndk {
2348 name: "myapex_v27",
2349 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002350 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09002351 vndk_version: "27",
2352 }
2353
2354 apex_key {
2355 name: "myapex.key",
2356 public_key: "testkey.avbpubkey",
2357 private_key: "testkey.pem",
2358 }
2359
Jooyung Han31c470b2019-10-18 16:26:59 +09002360 vndk_prebuilt_shared {
2361 name: "libvndk27",
2362 version: "27",
Jooyung Han344d5432019-08-23 11:17:39 +09002363 vendor_available: true,
2364 vndk: {
2365 enabled: true,
2366 },
Jooyung Han31c470b2019-10-18 16:26:59 +09002367 target_arch: "arm64",
2368 arch: {
2369 arm: {
2370 srcs: ["libvndk27_arm.so"],
2371 },
2372 arm64: {
2373 srcs: ["libvndk27_arm64.so"],
2374 },
2375 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002376 apex_available: [ "myapex_v27" ],
Jooyung Han344d5432019-08-23 11:17:39 +09002377 }
2378
2379 vndk_prebuilt_shared {
2380 name: "libvndk27",
2381 version: "27",
2382 vendor_available: true,
2383 vndk: {
2384 enabled: true,
2385 },
Jooyung Han31c470b2019-10-18 16:26:59 +09002386 target_arch: "x86_64",
2387 arch: {
2388 x86: {
2389 srcs: ["libvndk27_x86.so"],
2390 },
2391 x86_64: {
2392 srcs: ["libvndk27_x86_64.so"],
2393 },
2394 },
Jooyung Han39edb6c2019-11-06 16:53:07 +09002395 }
2396 `+vndkLibrariesTxtFiles("27"),
2397 withFiles(map[string][]byte{
2398 "libvndk27_arm.so": nil,
2399 "libvndk27_arm64.so": nil,
2400 "libvndk27_x86.so": nil,
2401 "libvndk27_x86_64.so": nil,
2402 }))
Jooyung Han344d5432019-08-23 11:17:39 +09002403
Jooyung Hana57af4a2020-01-23 05:36:59 +00002404 ensureExactContents(t, ctx, "myapex_v27", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09002405 "lib/libvndk27_arm.so",
2406 "lib64/libvndk27_arm64.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09002407 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09002408 })
Jooyung Han344d5432019-08-23 11:17:39 +09002409}
2410
2411func TestVndkApexErrorWithDuplicateVersion(t *testing.T) {
2412 testApexError(t, `module "myapex_v27.*" .*: vndk_version: 27 is already defined in "myapex_v27.*"`, `
2413 apex_vndk {
2414 name: "myapex_v27",
2415 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002416 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09002417 vndk_version: "27",
2418 }
2419 apex_vndk {
2420 name: "myapex_v27_other",
2421 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002422 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09002423 vndk_version: "27",
2424 }
2425
2426 apex_key {
2427 name: "myapex.key",
2428 public_key: "testkey.avbpubkey",
2429 private_key: "testkey.pem",
2430 }
2431
2432 cc_library {
2433 name: "libvndk",
2434 srcs: ["mylib.cpp"],
2435 vendor_available: true,
2436 vndk: {
2437 enabled: true,
2438 },
2439 system_shared_libs: [],
2440 stl: "none",
2441 }
2442
2443 vndk_prebuilt_shared {
2444 name: "libvndk",
2445 version: "27",
2446 vendor_available: true,
2447 vndk: {
2448 enabled: true,
2449 },
2450 srcs: ["libvndk.so"],
2451 }
2452 `, withFiles(map[string][]byte{
2453 "libvndk.so": nil,
2454 }))
2455}
2456
Jooyung Han90eee022019-10-01 20:02:42 +09002457func TestVndkApexNameRule(t *testing.T) {
2458 ctx, _ := testApex(t, `
2459 apex_vndk {
2460 name: "myapex",
2461 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002462 file_contexts: ":myapex-file_contexts",
Jooyung Han90eee022019-10-01 20:02:42 +09002463 }
2464 apex_vndk {
2465 name: "myapex_v28",
2466 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002467 file_contexts: ":myapex-file_contexts",
Jooyung Han90eee022019-10-01 20:02:42 +09002468 vndk_version: "28",
2469 }
2470 apex_key {
2471 name: "myapex.key",
2472 public_key: "testkey.avbpubkey",
2473 private_key: "testkey.pem",
Jooyung Han39edb6c2019-11-06 16:53:07 +09002474 }`+vndkLibrariesTxtFiles("28", "current"))
Jooyung Han90eee022019-10-01 20:02:42 +09002475
2476 assertApexName := func(expected, moduleName string) {
Jooyung Hana57af4a2020-01-23 05:36:59 +00002477 bundle := ctx.ModuleForTests(moduleName, "android_common_image").Module().(*apexBundle)
Jooyung Han90eee022019-10-01 20:02:42 +09002478 actual := proptools.String(bundle.properties.Apex_name)
2479 if !reflect.DeepEqual(actual, expected) {
2480 t.Errorf("Got '%v', expected '%v'", actual, expected)
2481 }
2482 }
2483
2484 assertApexName("com.android.vndk.vVER", "myapex")
2485 assertApexName("com.android.vndk.v28", "myapex_v28")
2486}
2487
Jooyung Han344d5432019-08-23 11:17:39 +09002488func TestVndkApexSkipsNativeBridgeSupportedModules(t *testing.T) {
2489 ctx, _ := testApex(t, `
2490 apex_vndk {
2491 name: "myapex",
2492 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002493 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09002494 }
2495
2496 apex_key {
2497 name: "myapex.key",
2498 public_key: "testkey.avbpubkey",
2499 private_key: "testkey.pem",
2500 }
2501
2502 cc_library {
2503 name: "libvndk",
2504 srcs: ["mylib.cpp"],
2505 vendor_available: true,
2506 native_bridge_supported: true,
2507 host_supported: true,
2508 vndk: {
2509 enabled: true,
2510 },
2511 system_shared_libs: [],
2512 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002513 apex_available: [ "myapex" ],
Jooyung Han344d5432019-08-23 11:17:39 +09002514 }
Jooyung Han35155c42020-02-06 17:33:20 +09002515 `+vndkLibrariesTxtFiles("current"), withNativeBridgeEnabled)
Jooyung Han344d5432019-08-23 11:17:39 +09002516
Jooyung Hana57af4a2020-01-23 05:36:59 +00002517 ensureExactContents(t, ctx, "myapex", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09002518 "lib/libvndk.so",
2519 "lib64/libvndk.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09002520 "lib/libc++.so",
2521 "lib64/libc++.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09002522 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09002523 })
Jooyung Han344d5432019-08-23 11:17:39 +09002524}
2525
2526func TestVndkApexDoesntSupportNativeBridgeSupported(t *testing.T) {
2527 testApexError(t, `module "myapex" .*: native_bridge_supported: .* doesn't support native bridge binary`, `
2528 apex_vndk {
2529 name: "myapex",
2530 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002531 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09002532 native_bridge_supported: true,
2533 }
2534
2535 apex_key {
2536 name: "myapex.key",
2537 public_key: "testkey.avbpubkey",
2538 private_key: "testkey.pem",
2539 }
2540
2541 cc_library {
2542 name: "libvndk",
2543 srcs: ["mylib.cpp"],
2544 vendor_available: true,
2545 native_bridge_supported: true,
2546 host_supported: true,
2547 vndk: {
2548 enabled: true,
2549 },
2550 system_shared_libs: [],
2551 stl: "none",
2552 }
2553 `)
2554}
2555
Jooyung Han31c470b2019-10-18 16:26:59 +09002556func TestVndkApexWithBinder32(t *testing.T) {
Jooyung Han39edb6c2019-11-06 16:53:07 +09002557 ctx, _ := testApex(t, `
Jooyung Han31c470b2019-10-18 16:26:59 +09002558 apex_vndk {
2559 name: "myapex_v27",
2560 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002561 file_contexts: ":myapex-file_contexts",
Jooyung Han31c470b2019-10-18 16:26:59 +09002562 vndk_version: "27",
2563 }
2564
2565 apex_key {
2566 name: "myapex.key",
2567 public_key: "testkey.avbpubkey",
2568 private_key: "testkey.pem",
2569 }
2570
2571 vndk_prebuilt_shared {
2572 name: "libvndk27",
2573 version: "27",
2574 target_arch: "arm",
2575 vendor_available: true,
2576 vndk: {
2577 enabled: true,
2578 },
2579 arch: {
2580 arm: {
2581 srcs: ["libvndk27.so"],
2582 }
2583 },
2584 }
2585
2586 vndk_prebuilt_shared {
2587 name: "libvndk27",
2588 version: "27",
2589 target_arch: "arm",
2590 binder32bit: true,
2591 vendor_available: true,
2592 vndk: {
2593 enabled: true,
2594 },
2595 arch: {
2596 arm: {
2597 srcs: ["libvndk27binder32.so"],
2598 }
2599 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002600 apex_available: [ "myapex_v27" ],
Jooyung Han31c470b2019-10-18 16:26:59 +09002601 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09002602 `+vndkLibrariesTxtFiles("27"),
Jooyung Han31c470b2019-10-18 16:26:59 +09002603 withFiles(map[string][]byte{
2604 "libvndk27.so": nil,
2605 "libvndk27binder32.so": nil,
2606 }),
2607 withBinder32bit,
2608 withTargets(map[android.OsType][]android.Target{
2609 android.Android: []android.Target{
Jooyung Han35155c42020-02-06 17:33:20 +09002610 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
2611 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
Jooyung Han31c470b2019-10-18 16:26:59 +09002612 },
2613 }),
2614 )
2615
Jooyung Hana57af4a2020-01-23 05:36:59 +00002616 ensureExactContents(t, ctx, "myapex_v27", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09002617 "lib/libvndk27binder32.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09002618 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09002619 })
2620}
2621
Jooyung Hane1633032019-08-01 17:41:43 +09002622func TestDependenciesInApexManifest(t *testing.T) {
2623 ctx, _ := testApex(t, `
2624 apex {
2625 name: "myapex_nodep",
2626 key: "myapex.key",
2627 native_shared_libs: ["lib_nodep"],
2628 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002629 file_contexts: ":myapex-file_contexts",
Jooyung Hane1633032019-08-01 17:41:43 +09002630 }
2631
2632 apex {
2633 name: "myapex_dep",
2634 key: "myapex.key",
2635 native_shared_libs: ["lib_dep"],
2636 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002637 file_contexts: ":myapex-file_contexts",
Jooyung Hane1633032019-08-01 17:41:43 +09002638 }
2639
2640 apex {
2641 name: "myapex_provider",
2642 key: "myapex.key",
2643 native_shared_libs: ["libfoo"],
2644 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002645 file_contexts: ":myapex-file_contexts",
Jooyung Hane1633032019-08-01 17:41:43 +09002646 }
2647
2648 apex {
2649 name: "myapex_selfcontained",
2650 key: "myapex.key",
2651 native_shared_libs: ["lib_dep", "libfoo"],
2652 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002653 file_contexts: ":myapex-file_contexts",
Jooyung Hane1633032019-08-01 17:41:43 +09002654 }
2655
2656 apex_key {
2657 name: "myapex.key",
2658 public_key: "testkey.avbpubkey",
2659 private_key: "testkey.pem",
2660 }
2661
2662 cc_library {
2663 name: "lib_nodep",
2664 srcs: ["mylib.cpp"],
2665 system_shared_libs: [],
2666 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002667 apex_available: [ "myapex_nodep" ],
Jooyung Hane1633032019-08-01 17:41:43 +09002668 }
2669
2670 cc_library {
2671 name: "lib_dep",
2672 srcs: ["mylib.cpp"],
2673 shared_libs: ["libfoo"],
2674 system_shared_libs: [],
2675 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002676 apex_available: [
2677 "myapex_dep",
2678 "myapex_provider",
2679 "myapex_selfcontained",
2680 ],
Jooyung Hane1633032019-08-01 17:41:43 +09002681 }
2682
2683 cc_library {
2684 name: "libfoo",
2685 srcs: ["mytest.cpp"],
2686 stubs: {
2687 versions: ["1"],
2688 },
2689 system_shared_libs: [],
2690 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002691 apex_available: [
2692 "myapex_provider",
2693 "myapex_selfcontained",
2694 ],
Jooyung Hane1633032019-08-01 17:41:43 +09002695 }
2696 `)
2697
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002698 var apexManifestRule android.TestingBuildParams
Jooyung Hane1633032019-08-01 17:41:43 +09002699 var provideNativeLibs, requireNativeLibs []string
2700
Sundong Ahnabb64432019-10-22 13:58:29 +09002701 apexManifestRule = ctx.ModuleForTests("myapex_nodep", "android_common_myapex_nodep_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002702 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
2703 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09002704 ensureListEmpty(t, provideNativeLibs)
2705 ensureListEmpty(t, requireNativeLibs)
2706
Sundong Ahnabb64432019-10-22 13:58:29 +09002707 apexManifestRule = ctx.ModuleForTests("myapex_dep", "android_common_myapex_dep_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002708 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
2709 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09002710 ensureListEmpty(t, provideNativeLibs)
2711 ensureListContains(t, requireNativeLibs, "libfoo.so")
2712
Sundong Ahnabb64432019-10-22 13:58:29 +09002713 apexManifestRule = ctx.ModuleForTests("myapex_provider", "android_common_myapex_provider_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002714 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
2715 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09002716 ensureListContains(t, provideNativeLibs, "libfoo.so")
2717 ensureListEmpty(t, requireNativeLibs)
2718
Sundong Ahnabb64432019-10-22 13:58:29 +09002719 apexManifestRule = ctx.ModuleForTests("myapex_selfcontained", "android_common_myapex_selfcontained_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002720 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
2721 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09002722 ensureListContains(t, provideNativeLibs, "libfoo.so")
2723 ensureListEmpty(t, requireNativeLibs)
2724}
2725
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002726func TestApexName(t *testing.T) {
Jiyong Parkdb334862020-02-05 17:19:28 +09002727 ctx, config := testApex(t, `
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002728 apex {
2729 name: "myapex",
2730 key: "myapex.key",
2731 apex_name: "com.android.myapex",
Jiyong Parkdb334862020-02-05 17:19:28 +09002732 native_shared_libs: ["mylib"],
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002733 }
2734
2735 apex_key {
2736 name: "myapex.key",
2737 public_key: "testkey.avbpubkey",
2738 private_key: "testkey.pem",
2739 }
Jiyong Parkdb334862020-02-05 17:19:28 +09002740
2741 cc_library {
2742 name: "mylib",
2743 srcs: ["mylib.cpp"],
2744 system_shared_libs: [],
2745 stl: "none",
2746 apex_available: [
2747 "//apex_available:platform",
2748 "myapex",
2749 ],
2750 }
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002751 `)
2752
Sundong Ahnabb64432019-10-22 13:58:29 +09002753 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002754 apexManifestRule := module.Rule("apexManifestRule")
2755 ensureContains(t, apexManifestRule.Args["opt"], "-v name com.android.myapex")
2756 apexRule := module.Rule("apexRule")
2757 ensureContains(t, apexRule.Args["opt_flags"], "--do_not_check_keyname")
Jiyong Parkdb334862020-02-05 17:19:28 +09002758
2759 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
2760 data := android.AndroidMkDataForTest(t, config, "", apexBundle)
2761 name := apexBundle.BaseModuleName()
2762 prefix := "TARGET_"
2763 var builder strings.Builder
2764 data.Custom(&builder, name, prefix, "", data)
2765 androidMk := builder.String()
2766 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
2767 ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002768}
2769
Alex Light0851b882019-02-07 13:20:53 -08002770func TestNonTestApex(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002771 ctx, _ := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08002772 apex {
2773 name: "myapex",
2774 key: "myapex.key",
2775 native_shared_libs: ["mylib_common"],
2776 }
2777
2778 apex_key {
2779 name: "myapex.key",
2780 public_key: "testkey.avbpubkey",
2781 private_key: "testkey.pem",
2782 }
2783
2784 cc_library {
2785 name: "mylib_common",
2786 srcs: ["mylib.cpp"],
2787 system_shared_libs: [],
2788 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002789 apex_available: [
2790 "//apex_available:platform",
2791 "myapex",
2792 ],
Alex Light0851b882019-02-07 13:20:53 -08002793 }
2794 `)
2795
Sundong Ahnabb64432019-10-22 13:58:29 +09002796 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Alex Light0851b882019-02-07 13:20:53 -08002797 apexRule := module.Rule("apexRule")
2798 copyCmds := apexRule.Args["copy_commands"]
2799
2800 if apex, ok := module.Module().(*apexBundle); !ok || apex.testApex {
2801 t.Log("Apex was a test apex!")
2802 t.Fail()
2803 }
2804 // Ensure that main rule creates an output
2805 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
2806
2807 // Ensure that apex variant is created for the direct dep
Colin Cross7113d202019-11-20 16:39:12 -08002808 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_myapex")
Alex Light0851b882019-02-07 13:20:53 -08002809
2810 // Ensure that both direct and indirect deps are copied into apex
2811 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
2812
Colin Cross7113d202019-11-20 16:39:12 -08002813 // Ensure that the platform variant ends with _shared
2814 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
Alex Light0851b882019-02-07 13:20:53 -08002815
2816 if !android.InAnyApex("mylib_common") {
2817 t.Log("Found mylib_common not in any apex!")
2818 t.Fail()
2819 }
2820}
2821
2822func TestTestApex(t *testing.T) {
2823 if android.InAnyApex("mylib_common_test") {
2824 t.Fatal("mylib_common_test must not be used in any other tests since this checks that global state is not updated in an illegal way!")
2825 }
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002826 ctx, _ := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08002827 apex_test {
2828 name: "myapex",
2829 key: "myapex.key",
2830 native_shared_libs: ["mylib_common_test"],
2831 }
2832
2833 apex_key {
2834 name: "myapex.key",
2835 public_key: "testkey.avbpubkey",
2836 private_key: "testkey.pem",
2837 }
2838
2839 cc_library {
2840 name: "mylib_common_test",
2841 srcs: ["mylib.cpp"],
2842 system_shared_libs: [],
2843 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002844 // TODO: remove //apex_available:platform
2845 apex_available: [
2846 "//apex_available:platform",
2847 "myapex",
2848 ],
Alex Light0851b882019-02-07 13:20:53 -08002849 }
2850 `)
2851
Sundong Ahnabb64432019-10-22 13:58:29 +09002852 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Alex Light0851b882019-02-07 13:20:53 -08002853 apexRule := module.Rule("apexRule")
2854 copyCmds := apexRule.Args["copy_commands"]
2855
2856 if apex, ok := module.Module().(*apexBundle); !ok || !apex.testApex {
2857 t.Log("Apex was not a test apex!")
2858 t.Fail()
2859 }
2860 // Ensure that main rule creates an output
2861 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
2862
2863 // Ensure that apex variant is created for the direct dep
Colin Cross7113d202019-11-20 16:39:12 -08002864 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared_myapex")
Alex Light0851b882019-02-07 13:20:53 -08002865
2866 // Ensure that both direct and indirect deps are copied into apex
2867 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common_test.so")
2868
Colin Cross7113d202019-11-20 16:39:12 -08002869 // Ensure that the platform variant ends with _shared
2870 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared")
Alex Light0851b882019-02-07 13:20:53 -08002871}
2872
Alex Light9670d332019-01-29 18:07:33 -08002873func TestApexWithTarget(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002874 ctx, _ := testApex(t, `
Alex Light9670d332019-01-29 18:07:33 -08002875 apex {
2876 name: "myapex",
2877 key: "myapex.key",
2878 multilib: {
2879 first: {
2880 native_shared_libs: ["mylib_common"],
2881 }
2882 },
2883 target: {
2884 android: {
2885 multilib: {
2886 first: {
2887 native_shared_libs: ["mylib"],
2888 }
2889 }
2890 },
2891 host: {
2892 multilib: {
2893 first: {
2894 native_shared_libs: ["mylib2"],
2895 }
2896 }
2897 }
2898 }
2899 }
2900
2901 apex_key {
2902 name: "myapex.key",
2903 public_key: "testkey.avbpubkey",
2904 private_key: "testkey.pem",
2905 }
2906
2907 cc_library {
2908 name: "mylib",
2909 srcs: ["mylib.cpp"],
2910 system_shared_libs: [],
2911 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002912 // TODO: remove //apex_available:platform
2913 apex_available: [
2914 "//apex_available:platform",
2915 "myapex",
2916 ],
Alex Light9670d332019-01-29 18:07:33 -08002917 }
2918
2919 cc_library {
2920 name: "mylib_common",
2921 srcs: ["mylib.cpp"],
2922 system_shared_libs: [],
2923 stl: "none",
2924 compile_multilib: "first",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002925 // TODO: remove //apex_available:platform
2926 apex_available: [
2927 "//apex_available:platform",
2928 "myapex",
2929 ],
Alex Light9670d332019-01-29 18:07:33 -08002930 }
2931
2932 cc_library {
2933 name: "mylib2",
2934 srcs: ["mylib.cpp"],
2935 system_shared_libs: [],
2936 stl: "none",
2937 compile_multilib: "first",
2938 }
2939 `)
2940
Sundong Ahnabb64432019-10-22 13:58:29 +09002941 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Alex Light9670d332019-01-29 18:07:33 -08002942 copyCmds := apexRule.Args["copy_commands"]
2943
2944 // Ensure that main rule creates an output
2945 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
2946
2947 // Ensure that apex variant is created for the direct dep
Colin Cross7113d202019-11-20 16:39:12 -08002948 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_myapex")
2949 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_myapex")
2950 ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_myapex")
Alex Light9670d332019-01-29 18:07:33 -08002951
2952 // Ensure that both direct and indirect deps are copied into apex
2953 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
2954 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
2955 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
2956
Colin Cross7113d202019-11-20 16:39:12 -08002957 // Ensure that the platform variant ends with _shared
2958 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
2959 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
2960 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
Alex Light9670d332019-01-29 18:07:33 -08002961}
Jiyong Park04480cf2019-02-06 00:16:29 +09002962
2963func TestApexWithShBinary(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002964 ctx, _ := testApex(t, `
Jiyong Park04480cf2019-02-06 00:16:29 +09002965 apex {
2966 name: "myapex",
2967 key: "myapex.key",
2968 binaries: ["myscript"],
2969 }
2970
2971 apex_key {
2972 name: "myapex.key",
2973 public_key: "testkey.avbpubkey",
2974 private_key: "testkey.pem",
2975 }
2976
2977 sh_binary {
2978 name: "myscript",
2979 src: "mylib.cpp",
2980 filename: "myscript.sh",
2981 sub_dir: "script",
2982 }
2983 `)
2984
Sundong Ahnabb64432019-10-22 13:58:29 +09002985 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park04480cf2019-02-06 00:16:29 +09002986 copyCmds := apexRule.Args["copy_commands"]
2987
2988 ensureContains(t, copyCmds, "image.apex/bin/script/myscript.sh")
2989}
Jiyong Parkd1e293d2019-03-15 02:13:21 +09002990
Jooyung Han91df2082019-11-20 01:49:42 +09002991func TestApexInVariousPartition(t *testing.T) {
2992 testcases := []struct {
2993 propName, parition, flattenedPartition string
2994 }{
2995 {"", "system", "system_ext"},
2996 {"product_specific: true", "product", "product"},
2997 {"soc_specific: true", "vendor", "vendor"},
2998 {"proprietary: true", "vendor", "vendor"},
2999 {"vendor: true", "vendor", "vendor"},
3000 {"system_ext_specific: true", "system_ext", "system_ext"},
3001 }
3002 for _, tc := range testcases {
3003 t.Run(tc.propName+":"+tc.parition, func(t *testing.T) {
3004 ctx, _ := testApex(t, `
3005 apex {
3006 name: "myapex",
3007 key: "myapex.key",
3008 `+tc.propName+`
3009 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09003010
Jooyung Han91df2082019-11-20 01:49:42 +09003011 apex_key {
3012 name: "myapex.key",
3013 public_key: "testkey.avbpubkey",
3014 private_key: "testkey.pem",
3015 }
3016 `)
Jiyong Parkd1e293d2019-03-15 02:13:21 +09003017
Jooyung Han91df2082019-11-20 01:49:42 +09003018 apex := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
3019 expected := buildDir + "/target/product/test_device/" + tc.parition + "/apex"
3020 actual := apex.installDir.String()
3021 if actual != expected {
3022 t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
3023 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09003024
Jooyung Han91df2082019-11-20 01:49:42 +09003025 flattened := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
3026 expected = buildDir + "/target/product/test_device/" + tc.flattenedPartition + "/apex"
3027 actual = flattened.installDir.String()
3028 if actual != expected {
3029 t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
3030 }
3031 })
Jiyong Parkd1e293d2019-03-15 02:13:21 +09003032 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09003033}
Jiyong Park67882562019-03-21 01:11:21 +09003034
Jooyung Han54aca7b2019-11-20 02:26:02 +09003035func TestFileContexts(t *testing.T) {
3036 ctx, _ := testApex(t, `
3037 apex {
3038 name: "myapex",
3039 key: "myapex.key",
3040 }
3041
3042 apex_key {
3043 name: "myapex.key",
3044 public_key: "testkey.avbpubkey",
3045 private_key: "testkey.pem",
3046 }
3047 `)
3048 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
3049 apexRule := module.Rule("apexRule")
3050 actual := apexRule.Args["file_contexts"]
3051 expected := "system/sepolicy/apex/myapex-file_contexts"
3052 if actual != expected {
3053 t.Errorf("wrong file_contexts. expected %q. actual %q", expected, actual)
3054 }
3055
3056 testApexError(t, `"myapex" .*: file_contexts: should be under system/sepolicy`, `
3057 apex {
3058 name: "myapex",
3059 key: "myapex.key",
3060 file_contexts: "my_own_file_contexts",
3061 }
3062
3063 apex_key {
3064 name: "myapex.key",
3065 public_key: "testkey.avbpubkey",
3066 private_key: "testkey.pem",
3067 }
3068 `, withFiles(map[string][]byte{
3069 "my_own_file_contexts": nil,
3070 }))
3071
3072 testApexError(t, `"myapex" .*: file_contexts: cannot find`, `
3073 apex {
3074 name: "myapex",
3075 key: "myapex.key",
3076 product_specific: true,
3077 file_contexts: "product_specific_file_contexts",
3078 }
3079
3080 apex_key {
3081 name: "myapex.key",
3082 public_key: "testkey.avbpubkey",
3083 private_key: "testkey.pem",
3084 }
3085 `)
3086
3087 ctx, _ = testApex(t, `
3088 apex {
3089 name: "myapex",
3090 key: "myapex.key",
3091 product_specific: true,
3092 file_contexts: "product_specific_file_contexts",
3093 }
3094
3095 apex_key {
3096 name: "myapex.key",
3097 public_key: "testkey.avbpubkey",
3098 private_key: "testkey.pem",
3099 }
3100 `, withFiles(map[string][]byte{
3101 "product_specific_file_contexts": nil,
3102 }))
3103 module = ctx.ModuleForTests("myapex", "android_common_myapex_image")
3104 apexRule = module.Rule("apexRule")
3105 actual = apexRule.Args["file_contexts"]
3106 expected = "product_specific_file_contexts"
3107 if actual != expected {
3108 t.Errorf("wrong file_contexts. expected %q. actual %q", expected, actual)
3109 }
3110
3111 ctx, _ = testApex(t, `
3112 apex {
3113 name: "myapex",
3114 key: "myapex.key",
3115 product_specific: true,
3116 file_contexts: ":my-file-contexts",
3117 }
3118
3119 apex_key {
3120 name: "myapex.key",
3121 public_key: "testkey.avbpubkey",
3122 private_key: "testkey.pem",
3123 }
3124
3125 filegroup {
3126 name: "my-file-contexts",
3127 srcs: ["product_specific_file_contexts"],
3128 }
3129 `, withFiles(map[string][]byte{
3130 "product_specific_file_contexts": nil,
3131 }))
3132 module = ctx.ModuleForTests("myapex", "android_common_myapex_image")
3133 apexRule = module.Rule("apexRule")
3134 actual = apexRule.Args["file_contexts"]
3135 expected = "product_specific_file_contexts"
3136 if actual != expected {
3137 t.Errorf("wrong file_contexts. expected %q. actual %q", expected, actual)
3138 }
3139}
3140
Jiyong Park67882562019-03-21 01:11:21 +09003141func TestApexKeyFromOtherModule(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07003142 ctx, _ := testApex(t, `
Jiyong Park67882562019-03-21 01:11:21 +09003143 apex_key {
3144 name: "myapex.key",
3145 public_key: ":my.avbpubkey",
3146 private_key: ":my.pem",
3147 product_specific: true,
3148 }
3149
3150 filegroup {
3151 name: "my.avbpubkey",
3152 srcs: ["testkey2.avbpubkey"],
3153 }
3154
3155 filegroup {
3156 name: "my.pem",
3157 srcs: ["testkey2.pem"],
3158 }
3159 `)
3160
3161 apex_key := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
3162 expected_pubkey := "testkey2.avbpubkey"
3163 actual_pubkey := apex_key.public_key_file.String()
3164 if actual_pubkey != expected_pubkey {
3165 t.Errorf("wrong public key path. expected %q. actual %q", expected_pubkey, actual_pubkey)
3166 }
3167 expected_privkey := "testkey2.pem"
3168 actual_privkey := apex_key.private_key_file.String()
3169 if actual_privkey != expected_privkey {
3170 t.Errorf("wrong private key path. expected %q. actual %q", expected_privkey, actual_privkey)
3171 }
3172}
Jaewoong Jung939ebd52019-03-26 15:07:36 -07003173
3174func TestPrebuilt(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07003175 ctx, _ := testApex(t, `
Jaewoong Jung939ebd52019-03-26 15:07:36 -07003176 prebuilt_apex {
3177 name: "myapex",
Jiyong Parkc95714e2019-03-29 14:23:10 +09003178 arch: {
3179 arm64: {
3180 src: "myapex-arm64.apex",
3181 },
3182 arm: {
3183 src: "myapex-arm.apex",
3184 },
3185 },
Jaewoong Jung939ebd52019-03-26 15:07:36 -07003186 }
3187 `)
3188
3189 prebuilt := ctx.ModuleForTests("myapex", "android_common").Module().(*Prebuilt)
3190
Jiyong Parkc95714e2019-03-29 14:23:10 +09003191 expectedInput := "myapex-arm64.apex"
3192 if prebuilt.inputApex.String() != expectedInput {
3193 t.Errorf("inputApex invalid. expected: %q, actual: %q", expectedInput, prebuilt.inputApex.String())
3194 }
Jaewoong Jung939ebd52019-03-26 15:07:36 -07003195}
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01003196
3197func TestPrebuiltFilenameOverride(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07003198 ctx, _ := testApex(t, `
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01003199 prebuilt_apex {
3200 name: "myapex",
3201 src: "myapex-arm.apex",
3202 filename: "notmyapex.apex",
3203 }
3204 `)
3205
3206 p := ctx.ModuleForTests("myapex", "android_common").Module().(*Prebuilt)
3207
3208 expected := "notmyapex.apex"
3209 if p.installFilename != expected {
3210 t.Errorf("installFilename invalid. expected: %q, actual: %q", expected, p.installFilename)
3211 }
3212}
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07003213
Jaewoong Jung22f7d182019-07-16 18:25:41 -07003214func TestPrebuiltOverrides(t *testing.T) {
3215 ctx, config := testApex(t, `
3216 prebuilt_apex {
3217 name: "myapex.prebuilt",
3218 src: "myapex-arm.apex",
3219 overrides: [
3220 "myapex",
3221 ],
3222 }
3223 `)
3224
3225 p := ctx.ModuleForTests("myapex.prebuilt", "android_common").Module().(*Prebuilt)
3226
3227 expected := []string{"myapex"}
Jiyong Park0b0e1b92019-12-03 13:24:29 +09003228 actual := android.AndroidMkEntriesForTest(t, config, "", p)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
Jaewoong Jung22f7d182019-07-16 18:25:41 -07003229 if !reflect.DeepEqual(actual, expected) {
Jiyong Parkb0a012c2019-11-14 17:17:03 +09003230 t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES value '%s', expected '%s'", actual, expected)
Jaewoong Jung22f7d182019-07-16 18:25:41 -07003231 }
3232}
3233
Roland Levillain630846d2019-06-26 12:48:34 +01003234func TestApexWithTests(t *testing.T) {
Roland Levillainf89cd092019-07-29 16:22:59 +01003235 ctx, config := testApex(t, `
Roland Levillain630846d2019-06-26 12:48:34 +01003236 apex_test {
3237 name: "myapex",
3238 key: "myapex.key",
3239 tests: [
3240 "mytest",
Roland Levillain9b5fde92019-06-28 15:41:19 +01003241 "mytests",
Roland Levillain630846d2019-06-26 12:48:34 +01003242 ],
3243 }
3244
3245 apex_key {
3246 name: "myapex.key",
3247 public_key: "testkey.avbpubkey",
3248 private_key: "testkey.pem",
3249 }
3250
3251 cc_test {
3252 name: "mytest",
3253 gtest: false,
3254 srcs: ["mytest.cpp"],
3255 relative_install_path: "test",
3256 system_shared_libs: [],
3257 static_executable: true,
3258 stl: "none",
3259 }
Roland Levillain9b5fde92019-06-28 15:41:19 +01003260
3261 cc_test {
3262 name: "mytests",
3263 gtest: false,
3264 srcs: [
3265 "mytest1.cpp",
3266 "mytest2.cpp",
3267 "mytest3.cpp",
3268 ],
3269 test_per_src: true,
3270 relative_install_path: "test",
3271 system_shared_libs: [],
3272 static_executable: true,
3273 stl: "none",
3274 }
Roland Levillain630846d2019-06-26 12:48:34 +01003275 `)
3276
Sundong Ahnabb64432019-10-22 13:58:29 +09003277 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Roland Levillain630846d2019-06-26 12:48:34 +01003278 copyCmds := apexRule.Args["copy_commands"]
3279
3280 // Ensure that test dep is copied into apex.
3281 ensureContains(t, copyCmds, "image.apex/bin/test/mytest")
Roland Levillain9b5fde92019-06-28 15:41:19 +01003282
3283 // Ensure that test deps built with `test_per_src` are copied into apex.
3284 ensureContains(t, copyCmds, "image.apex/bin/test/mytest1")
3285 ensureContains(t, copyCmds, "image.apex/bin/test/mytest2")
3286 ensureContains(t, copyCmds, "image.apex/bin/test/mytest3")
Roland Levillainf89cd092019-07-29 16:22:59 +01003287
3288 // Ensure the module is correctly translated.
Sundong Ahnabb64432019-10-22 13:58:29 +09003289 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Roland Levillainf89cd092019-07-29 16:22:59 +01003290 data := android.AndroidMkDataForTest(t, config, "", apexBundle)
3291 name := apexBundle.BaseModuleName()
3292 prefix := "TARGET_"
3293 var builder strings.Builder
3294 data.Custom(&builder, name, prefix, "", data)
3295 androidMk := builder.String()
Jooyung Han31c470b2019-10-18 16:26:59 +09003296 ensureContains(t, androidMk, "LOCAL_MODULE := mytest.myapex\n")
3297 ensureContains(t, androidMk, "LOCAL_MODULE := mytest1.myapex\n")
3298 ensureContains(t, androidMk, "LOCAL_MODULE := mytest2.myapex\n")
3299 ensureContains(t, androidMk, "LOCAL_MODULE := mytest3.myapex\n")
Jooyung Han214bf372019-11-12 13:03:50 +09003300 ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex\n")
Jooyung Han31c470b2019-10-18 16:26:59 +09003301 ensureContains(t, androidMk, "LOCAL_MODULE := apex_pubkey.myapex\n")
Roland Levillainf89cd092019-07-29 16:22:59 +01003302 ensureContains(t, androidMk, "LOCAL_MODULE := myapex\n")
Roland Levillain630846d2019-06-26 12:48:34 +01003303}
3304
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09003305func TestInstallExtraFlattenedApexes(t *testing.T) {
3306 ctx, config := testApex(t, `
3307 apex {
3308 name: "myapex",
3309 key: "myapex.key",
3310 }
3311 apex_key {
3312 name: "myapex.key",
3313 public_key: "testkey.avbpubkey",
3314 private_key: "testkey.pem",
3315 }
3316 `, func(fs map[string][]byte, config android.Config) {
3317 config.TestProductVariables.InstallExtraFlattenedApexes = proptools.BoolPtr(true)
3318 })
3319 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Jiyong Park83dc74b2020-01-14 18:38:44 +09003320 ensureListContains(t, ab.requiredDeps, "myapex.flattened")
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09003321 mk := android.AndroidMkDataForTest(t, config, "", ab)
3322 var builder strings.Builder
3323 mk.Custom(&builder, ab.Name(), "TARGET_", "", mk)
3324 androidMk := builder.String()
3325 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += myapex.flattened")
3326}
3327
Jooyung Han5c998b92019-06-27 11:30:33 +09003328func TestApexUsesOtherApex(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07003329 ctx, _ := testApex(t, `
Jooyung Han5c998b92019-06-27 11:30:33 +09003330 apex {
3331 name: "myapex",
3332 key: "myapex.key",
3333 native_shared_libs: ["mylib"],
3334 uses: ["commonapex"],
3335 }
3336
3337 apex {
3338 name: "commonapex",
3339 key: "myapex.key",
3340 native_shared_libs: ["libcommon"],
3341 provide_cpp_shared_libs: true,
3342 }
3343
3344 apex_key {
3345 name: "myapex.key",
3346 public_key: "testkey.avbpubkey",
3347 private_key: "testkey.pem",
3348 }
3349
3350 cc_library {
3351 name: "mylib",
3352 srcs: ["mylib.cpp"],
3353 shared_libs: ["libcommon"],
3354 system_shared_libs: [],
3355 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003356 apex_available: [ "myapex" ],
Jooyung Han5c998b92019-06-27 11:30:33 +09003357 }
3358
3359 cc_library {
3360 name: "libcommon",
3361 srcs: ["mylib_common.cpp"],
3362 system_shared_libs: [],
3363 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003364 // TODO: remove //apex_available:platform
3365 apex_available: [
3366 "//apex_available:platform",
3367 "commonapex",
3368 "myapex",
3369 ],
Jooyung Han5c998b92019-06-27 11:30:33 +09003370 }
3371 `)
3372
Sundong Ahnabb64432019-10-22 13:58:29 +09003373 module1 := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Han5c998b92019-06-27 11:30:33 +09003374 apexRule1 := module1.Rule("apexRule")
3375 copyCmds1 := apexRule1.Args["copy_commands"]
3376
Sundong Ahnabb64432019-10-22 13:58:29 +09003377 module2 := ctx.ModuleForTests("commonapex", "android_common_commonapex_image")
Jooyung Han5c998b92019-06-27 11:30:33 +09003378 apexRule2 := module2.Rule("apexRule")
3379 copyCmds2 := apexRule2.Args["copy_commands"]
3380
Colin Cross7113d202019-11-20 16:39:12 -08003381 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_myapex")
3382 ensureListContains(t, ctx.ModuleVariantsForTests("libcommon"), "android_arm64_armv8-a_shared_commonapex")
Jooyung Han5c998b92019-06-27 11:30:33 +09003383 ensureContains(t, copyCmds1, "image.apex/lib64/mylib.so")
3384 ensureContains(t, copyCmds2, "image.apex/lib64/libcommon.so")
3385 ensureNotContains(t, copyCmds1, "image.apex/lib64/libcommon.so")
3386}
3387
3388func TestApexUsesFailsIfNotProvided(t *testing.T) {
3389 testApexError(t, `uses: "commonapex" does not provide native_shared_libs`, `
3390 apex {
3391 name: "myapex",
3392 key: "myapex.key",
3393 uses: ["commonapex"],
3394 }
3395
3396 apex {
3397 name: "commonapex",
3398 key: "myapex.key",
3399 }
3400
3401 apex_key {
3402 name: "myapex.key",
3403 public_key: "testkey.avbpubkey",
3404 private_key: "testkey.pem",
3405 }
3406 `)
3407 testApexError(t, `uses: "commonapex" is not a provider`, `
3408 apex {
3409 name: "myapex",
3410 key: "myapex.key",
3411 uses: ["commonapex"],
3412 }
3413
3414 cc_library {
3415 name: "commonapex",
3416 system_shared_libs: [],
3417 stl: "none",
3418 }
3419
3420 apex_key {
3421 name: "myapex.key",
3422 public_key: "testkey.avbpubkey",
3423 private_key: "testkey.pem",
3424 }
3425 `)
3426}
3427
3428func TestApexUsesFailsIfUseVenderMismatch(t *testing.T) {
3429 testApexError(t, `use_vendor: "commonapex" has different value of use_vendor`, `
3430 apex {
3431 name: "myapex",
3432 key: "myapex.key",
3433 use_vendor: true,
3434 uses: ["commonapex"],
3435 }
3436
3437 apex {
3438 name: "commonapex",
3439 key: "myapex.key",
3440 provide_cpp_shared_libs: true,
3441 }
3442
3443 apex_key {
3444 name: "myapex.key",
3445 public_key: "testkey.avbpubkey",
3446 private_key: "testkey.pem",
3447 }
Jooyung Handc782442019-11-01 03:14:38 +09003448 `, func(fs map[string][]byte, config android.Config) {
3449 setUseVendorWhitelistForTest(config, []string{"myapex"})
3450 })
Jooyung Han5c998b92019-06-27 11:30:33 +09003451}
3452
Jooyung Hand48f3c32019-08-23 11:18:57 +09003453func TestErrorsIfDepsAreNotEnabled(t *testing.T) {
3454 testApexError(t, `module "myapex" .* depends on disabled module "libfoo"`, `
3455 apex {
3456 name: "myapex",
3457 key: "myapex.key",
3458 native_shared_libs: ["libfoo"],
3459 }
3460
3461 apex_key {
3462 name: "myapex.key",
3463 public_key: "testkey.avbpubkey",
3464 private_key: "testkey.pem",
3465 }
3466
3467 cc_library {
3468 name: "libfoo",
3469 stl: "none",
3470 system_shared_libs: [],
3471 enabled: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09003472 apex_available: ["myapex"],
Jooyung Hand48f3c32019-08-23 11:18:57 +09003473 }
3474 `)
3475 testApexError(t, `module "myapex" .* depends on disabled module "myjar"`, `
3476 apex {
3477 name: "myapex",
3478 key: "myapex.key",
3479 java_libs: ["myjar"],
3480 }
3481
3482 apex_key {
3483 name: "myapex.key",
3484 public_key: "testkey.avbpubkey",
3485 private_key: "testkey.pem",
3486 }
3487
3488 java_library {
3489 name: "myjar",
3490 srcs: ["foo/bar/MyClass.java"],
3491 sdk_version: "none",
3492 system_modules: "none",
Jooyung Hand48f3c32019-08-23 11:18:57 +09003493 enabled: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09003494 apex_available: ["myapex"],
Jooyung Hand48f3c32019-08-23 11:18:57 +09003495 }
3496 `)
3497}
3498
Sundong Ahne1f05aa2019-08-27 13:55:42 +09003499func TestApexWithApps(t *testing.T) {
3500 ctx, _ := testApex(t, `
3501 apex {
3502 name: "myapex",
3503 key: "myapex.key",
3504 apps: [
3505 "AppFoo",
Jiyong Parkf7487312019-10-17 12:54:30 +09003506 "AppFooPriv",
Sundong Ahne1f05aa2019-08-27 13:55:42 +09003507 ],
3508 }
3509
3510 apex_key {
3511 name: "myapex.key",
3512 public_key: "testkey.avbpubkey",
3513 private_key: "testkey.pem",
3514 }
3515
3516 android_app {
3517 name: "AppFoo",
3518 srcs: ["foo/bar/MyClass.java"],
Colin Cross094cde42020-02-15 10:38:00 -08003519 sdk_version: "current",
Sundong Ahne1f05aa2019-08-27 13:55:42 +09003520 system_modules: "none",
Jiyong Park8be103b2019-11-08 15:53:48 +09003521 jni_libs: ["libjni"],
Colin Cross094cde42020-02-15 10:38:00 -08003522 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003523 apex_available: [ "myapex" ],
Sundong Ahne1f05aa2019-08-27 13:55:42 +09003524 }
Jiyong Parkf7487312019-10-17 12:54:30 +09003525
3526 android_app {
3527 name: "AppFooPriv",
3528 srcs: ["foo/bar/MyClass.java"],
Colin Cross094cde42020-02-15 10:38:00 -08003529 sdk_version: "current",
Jiyong Parkf7487312019-10-17 12:54:30 +09003530 system_modules: "none",
3531 privileged: true,
Colin Cross094cde42020-02-15 10:38:00 -08003532 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003533 apex_available: [ "myapex" ],
Jiyong Parkf7487312019-10-17 12:54:30 +09003534 }
Jiyong Park8be103b2019-11-08 15:53:48 +09003535
3536 cc_library_shared {
3537 name: "libjni",
3538 srcs: ["mylib.cpp"],
Jooyung Hanb7bebe22020-02-25 16:59:29 +09003539 shared_libs: ["libfoo"],
3540 stl: "none",
3541 system_shared_libs: [],
3542 apex_available: [ "myapex" ],
3543 sdk_version: "current",
3544 }
3545
3546 cc_library_shared {
3547 name: "libfoo",
Jiyong Park8be103b2019-11-08 15:53:48 +09003548 stl: "none",
3549 system_shared_libs: [],
Jiyong Park0f80c182020-01-31 02:49:53 +09003550 apex_available: [ "myapex" ],
Colin Cross094cde42020-02-15 10:38:00 -08003551 sdk_version: "current",
Jiyong Park8be103b2019-11-08 15:53:48 +09003552 }
Sundong Ahne1f05aa2019-08-27 13:55:42 +09003553 `)
3554
Sundong Ahnabb64432019-10-22 13:58:29 +09003555 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Sundong Ahne1f05aa2019-08-27 13:55:42 +09003556 apexRule := module.Rule("apexRule")
3557 copyCmds := apexRule.Args["copy_commands"]
3558
3559 ensureContains(t, copyCmds, "image.apex/app/AppFoo/AppFoo.apk")
Jiyong Parkf7487312019-10-17 12:54:30 +09003560 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPriv/AppFooPriv.apk")
Jiyong Park52cd06f2019-11-11 10:14:32 +09003561
Jooyung Hanb7bebe22020-02-25 16:59:29 +09003562 appZipRule := ctx.ModuleForTests("AppFoo", "android_common_myapex").Description("zip jni libs")
3563 // JNI libraries are uncompressed
Jiyong Park52cd06f2019-11-11 10:14:32 +09003564 if args := appZipRule.Args["jarArgs"]; !strings.Contains(args, "-L 0") {
Jooyung Hanb7bebe22020-02-25 16:59:29 +09003565 t.Errorf("jni libs are not uncompressed for AppFoo")
Jiyong Park52cd06f2019-11-11 10:14:32 +09003566 }
Jooyung Hanb7bebe22020-02-25 16:59:29 +09003567 // JNI libraries including transitive deps are
3568 for _, jni := range []string{"libjni", "libfoo"} {
Colin Crossc511bc52020-04-07 16:50:32 +00003569 jniOutput := ctx.ModuleForTests(jni, "android_arm64_armv8-a_sdk_shared_myapex").Module().(*cc.Module).OutputFile()
Jooyung Hanb7bebe22020-02-25 16:59:29 +09003570 // ... embedded inside APK (jnilibs.zip)
3571 ensureListContains(t, appZipRule.Implicits.Strings(), jniOutput.String())
3572 // ... and not directly inside the APEX
3573 ensureNotContains(t, copyCmds, "image.apex/lib64/"+jni+".so")
3574 }
Dario Frenicde2a032019-10-27 00:29:22 +01003575}
Sundong Ahne1f05aa2019-08-27 13:55:42 +09003576
Dario Frenicde2a032019-10-27 00:29:22 +01003577func TestApexWithAppImports(t *testing.T) {
3578 ctx, _ := testApex(t, `
3579 apex {
3580 name: "myapex",
3581 key: "myapex.key",
3582 apps: [
3583 "AppFooPrebuilt",
3584 "AppFooPrivPrebuilt",
3585 ],
3586 }
3587
3588 apex_key {
3589 name: "myapex.key",
3590 public_key: "testkey.avbpubkey",
3591 private_key: "testkey.pem",
3592 }
3593
3594 android_app_import {
3595 name: "AppFooPrebuilt",
3596 apk: "PrebuiltAppFoo.apk",
3597 presigned: true,
3598 dex_preopt: {
3599 enabled: false,
3600 },
Jiyong Park592a6a42020-04-21 22:34:28 +09003601 apex_available: ["myapex"],
Dario Frenicde2a032019-10-27 00:29:22 +01003602 }
3603
3604 android_app_import {
3605 name: "AppFooPrivPrebuilt",
3606 apk: "PrebuiltAppFooPriv.apk",
3607 privileged: true,
3608 presigned: true,
3609 dex_preopt: {
3610 enabled: false,
3611 },
Jooyung Han39ee1192020-03-23 20:21:11 +09003612 filename: "AwesomePrebuiltAppFooPriv.apk",
Jiyong Park592a6a42020-04-21 22:34:28 +09003613 apex_available: ["myapex"],
Dario Frenicde2a032019-10-27 00:29:22 +01003614 }
3615 `)
3616
Sundong Ahnabb64432019-10-22 13:58:29 +09003617 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Dario Frenicde2a032019-10-27 00:29:22 +01003618 apexRule := module.Rule("apexRule")
3619 copyCmds := apexRule.Args["copy_commands"]
3620
3621 ensureContains(t, copyCmds, "image.apex/app/AppFooPrebuilt/AppFooPrebuilt.apk")
Jooyung Han39ee1192020-03-23 20:21:11 +09003622 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPrivPrebuilt/AwesomePrebuiltAppFooPriv.apk")
3623}
3624
3625func TestApexWithAppImportsPrefer(t *testing.T) {
3626 ctx, _ := testApex(t, `
3627 apex {
3628 name: "myapex",
3629 key: "myapex.key",
3630 apps: [
3631 "AppFoo",
3632 ],
3633 }
3634
3635 apex_key {
3636 name: "myapex.key",
3637 public_key: "testkey.avbpubkey",
3638 private_key: "testkey.pem",
3639 }
3640
3641 android_app {
3642 name: "AppFoo",
3643 srcs: ["foo/bar/MyClass.java"],
3644 sdk_version: "none",
3645 system_modules: "none",
3646 apex_available: [ "myapex" ],
3647 }
3648
3649 android_app_import {
3650 name: "AppFoo",
3651 apk: "AppFooPrebuilt.apk",
3652 filename: "AppFooPrebuilt.apk",
3653 presigned: true,
3654 prefer: true,
Jiyong Park592a6a42020-04-21 22:34:28 +09003655 apex_available: ["myapex"],
Jooyung Han39ee1192020-03-23 20:21:11 +09003656 }
3657 `, withFiles(map[string][]byte{
3658 "AppFooPrebuilt.apk": nil,
3659 }))
3660
3661 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
3662 "app/AppFoo/AppFooPrebuilt.apk",
3663 })
Sundong Ahne1f05aa2019-08-27 13:55:42 +09003664}
3665
Dario Freni6f3937c2019-12-20 22:58:03 +00003666func TestApexWithTestHelperApp(t *testing.T) {
3667 ctx, _ := testApex(t, `
3668 apex {
3669 name: "myapex",
3670 key: "myapex.key",
3671 apps: [
3672 "TesterHelpAppFoo",
3673 ],
3674 }
3675
3676 apex_key {
3677 name: "myapex.key",
3678 public_key: "testkey.avbpubkey",
3679 private_key: "testkey.pem",
3680 }
3681
3682 android_test_helper_app {
3683 name: "TesterHelpAppFoo",
3684 srcs: ["foo/bar/MyClass.java"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003685 apex_available: [ "myapex" ],
Dario Freni6f3937c2019-12-20 22:58:03 +00003686 }
3687
3688 `)
3689
3690 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
3691 apexRule := module.Rule("apexRule")
3692 copyCmds := apexRule.Args["copy_commands"]
3693
3694 ensureContains(t, copyCmds, "image.apex/app/TesterHelpAppFoo/TesterHelpAppFoo.apk")
3695}
3696
Jooyung Han18020ea2019-11-13 10:50:48 +09003697func TestApexPropertiesShouldBeDefaultable(t *testing.T) {
3698 // libfoo's apex_available comes from cc_defaults
Jooyung Han5e9013b2020-03-10 06:23:13 +09003699 testApexError(t, `requires "libfoo" that is not available for the APEX`, `
Jooyung Han18020ea2019-11-13 10:50:48 +09003700 apex {
3701 name: "myapex",
3702 key: "myapex.key",
3703 native_shared_libs: ["libfoo"],
3704 }
3705
3706 apex_key {
3707 name: "myapex.key",
3708 public_key: "testkey.avbpubkey",
3709 private_key: "testkey.pem",
3710 }
3711
3712 apex {
3713 name: "otherapex",
3714 key: "myapex.key",
3715 native_shared_libs: ["libfoo"],
3716 }
3717
3718 cc_defaults {
3719 name: "libfoo-defaults",
3720 apex_available: ["otherapex"],
3721 }
3722
3723 cc_library {
3724 name: "libfoo",
3725 defaults: ["libfoo-defaults"],
3726 stl: "none",
3727 system_shared_libs: [],
3728 }`)
3729}
3730
Paul Duffine52e66f2020-03-30 17:54:29 +01003731func TestApexAvailable_DirectDep(t *testing.T) {
Jiyong Park127b40b2019-09-30 16:04:35 +09003732 // libfoo is not available to myapex, but only to otherapex
3733 testApexError(t, "requires \"libfoo\" that is not available for the APEX", `
3734 apex {
3735 name: "myapex",
3736 key: "myapex.key",
3737 native_shared_libs: ["libfoo"],
3738 }
3739
3740 apex_key {
3741 name: "myapex.key",
3742 public_key: "testkey.avbpubkey",
3743 private_key: "testkey.pem",
3744 }
3745
3746 apex {
3747 name: "otherapex",
3748 key: "otherapex.key",
3749 native_shared_libs: ["libfoo"],
3750 }
3751
3752 apex_key {
3753 name: "otherapex.key",
3754 public_key: "testkey.avbpubkey",
3755 private_key: "testkey.pem",
3756 }
3757
3758 cc_library {
3759 name: "libfoo",
3760 stl: "none",
3761 system_shared_libs: [],
3762 apex_available: ["otherapex"],
3763 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01003764}
Jiyong Park127b40b2019-09-30 16:04:35 +09003765
Paul Duffine52e66f2020-03-30 17:54:29 +01003766func TestApexAvailable_IndirectDep(t *testing.T) {
Jooyung Han5e9013b2020-03-10 06:23:13 +09003767 // libbbaz is an indirect dep
Paul Duffindf915ff2020-03-30 17:58:21 +01003768 testApexError(t, `requires "libbaz" that is not available for the APEX. Dependency path:
Paul Duffinc5192442020-03-31 11:31:36 +01003769.*via tag apex\.dependencyTag.*"sharedLib".*
Paul Duffindf915ff2020-03-30 17:58:21 +01003770.*-> libfoo.*link:shared.*
Paul Duffin65347702020-03-31 15:23:40 +01003771.*via tag cc\.DependencyTag.*"shared".*
Paul Duffindf915ff2020-03-30 17:58:21 +01003772.*-> libbar.*link:shared.*
Paul Duffin65347702020-03-31 15:23:40 +01003773.*via tag cc\.DependencyTag.*"shared".*
3774.*-> libbaz.*link:shared.*`, `
Jiyong Park127b40b2019-09-30 16:04:35 +09003775 apex {
3776 name: "myapex",
3777 key: "myapex.key",
3778 native_shared_libs: ["libfoo"],
3779 }
3780
3781 apex_key {
3782 name: "myapex.key",
3783 public_key: "testkey.avbpubkey",
3784 private_key: "testkey.pem",
3785 }
3786
Jiyong Park127b40b2019-09-30 16:04:35 +09003787 cc_library {
3788 name: "libfoo",
3789 stl: "none",
3790 shared_libs: ["libbar"],
3791 system_shared_libs: [],
Jooyung Han5e9013b2020-03-10 06:23:13 +09003792 apex_available: ["myapex"],
Jiyong Park127b40b2019-09-30 16:04:35 +09003793 }
3794
3795 cc_library {
3796 name: "libbar",
3797 stl: "none",
Jooyung Han5e9013b2020-03-10 06:23:13 +09003798 shared_libs: ["libbaz"],
Jiyong Park127b40b2019-09-30 16:04:35 +09003799 system_shared_libs: [],
Jooyung Han5e9013b2020-03-10 06:23:13 +09003800 apex_available: ["myapex"],
3801 }
3802
3803 cc_library {
3804 name: "libbaz",
3805 stl: "none",
3806 system_shared_libs: [],
Jiyong Park127b40b2019-09-30 16:04:35 +09003807 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01003808}
Jiyong Park127b40b2019-09-30 16:04:35 +09003809
Paul Duffine52e66f2020-03-30 17:54:29 +01003810func TestApexAvailable_InvalidApexName(t *testing.T) {
Jiyong Park127b40b2019-09-30 16:04:35 +09003811 testApexError(t, "\"otherapex\" is not a valid module name", `
3812 apex {
3813 name: "myapex",
3814 key: "myapex.key",
3815 native_shared_libs: ["libfoo"],
3816 }
3817
3818 apex_key {
3819 name: "myapex.key",
3820 public_key: "testkey.avbpubkey",
3821 private_key: "testkey.pem",
3822 }
3823
3824 cc_library {
3825 name: "libfoo",
3826 stl: "none",
3827 system_shared_libs: [],
3828 apex_available: ["otherapex"],
3829 }`)
3830
Paul Duffine52e66f2020-03-30 17:54:29 +01003831 testApex(t, `
Jiyong Park127b40b2019-09-30 16:04:35 +09003832 apex {
3833 name: "myapex",
3834 key: "myapex.key",
3835 native_shared_libs: ["libfoo", "libbar"],
3836 }
3837
3838 apex_key {
3839 name: "myapex.key",
3840 public_key: "testkey.avbpubkey",
3841 private_key: "testkey.pem",
3842 }
3843
3844 cc_library {
3845 name: "libfoo",
3846 stl: "none",
3847 system_shared_libs: [],
Jiyong Park323a4c32020-03-01 17:29:06 +09003848 runtime_libs: ["libbaz"],
Jiyong Park127b40b2019-09-30 16:04:35 +09003849 apex_available: ["myapex"],
3850 }
3851
3852 cc_library {
3853 name: "libbar",
3854 stl: "none",
3855 system_shared_libs: [],
3856 apex_available: ["//apex_available:anyapex"],
Jiyong Park323a4c32020-03-01 17:29:06 +09003857 }
3858
3859 cc_library {
3860 name: "libbaz",
3861 stl: "none",
3862 system_shared_libs: [],
3863 stubs: {
3864 versions: ["10", "20", "30"],
3865 },
Jiyong Park127b40b2019-09-30 16:04:35 +09003866 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01003867}
Jiyong Park127b40b2019-09-30 16:04:35 +09003868
Jiyong Park89e850a2020-04-07 16:37:39 +09003869func TestApexAvailable_CheckForPlatform(t *testing.T) {
Paul Duffine52e66f2020-03-30 17:54:29 +01003870 ctx, _ := testApex(t, `
Jiyong Park127b40b2019-09-30 16:04:35 +09003871 apex {
3872 name: "myapex",
3873 key: "myapex.key",
Jiyong Park89e850a2020-04-07 16:37:39 +09003874 native_shared_libs: ["libbar", "libbaz"],
Jiyong Park127b40b2019-09-30 16:04:35 +09003875 }
3876
3877 apex_key {
3878 name: "myapex.key",
3879 public_key: "testkey.avbpubkey",
3880 private_key: "testkey.pem",
3881 }
3882
3883 cc_library {
3884 name: "libfoo",
3885 stl: "none",
3886 system_shared_libs: [],
Jiyong Park89e850a2020-04-07 16:37:39 +09003887 shared_libs: ["libbar"],
Jiyong Park127b40b2019-09-30 16:04:35 +09003888 apex_available: ["//apex_available:platform"],
Jiyong Park89e850a2020-04-07 16:37:39 +09003889 }
3890
3891 cc_library {
3892 name: "libfoo2",
3893 stl: "none",
3894 system_shared_libs: [],
3895 shared_libs: ["libbaz"],
3896 apex_available: ["//apex_available:platform"],
3897 }
3898
3899 cc_library {
3900 name: "libbar",
3901 stl: "none",
3902 system_shared_libs: [],
3903 apex_available: ["myapex"],
3904 }
3905
3906 cc_library {
3907 name: "libbaz",
3908 stl: "none",
3909 system_shared_libs: [],
3910 apex_available: ["myapex"],
3911 stubs: {
3912 versions: ["1"],
3913 },
Jiyong Park127b40b2019-09-30 16:04:35 +09003914 }`)
3915
Jiyong Park89e850a2020-04-07 16:37:39 +09003916 // libfoo shouldn't be available to platform even though it has "//apex_available:platform",
3917 // because it depends on libbar which isn't available to platform
3918 libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
3919 if libfoo.NotAvailableForPlatform() != true {
3920 t.Errorf("%q shouldn't be available to platform", libfoo.String())
3921 }
3922
3923 // libfoo2 however can be available to platform because it depends on libbaz which provides
3924 // stubs
3925 libfoo2 := ctx.ModuleForTests("libfoo2", "android_arm64_armv8-a_shared").Module().(*cc.Module)
3926 if libfoo2.NotAvailableForPlatform() == true {
3927 t.Errorf("%q should be available to platform", libfoo2.String())
3928 }
Paul Duffine52e66f2020-03-30 17:54:29 +01003929}
Jiyong Parka90ca002019-10-07 15:47:24 +09003930
Paul Duffine52e66f2020-03-30 17:54:29 +01003931func TestApexAvailable_CreatedForApex(t *testing.T) {
Jiyong Park89e850a2020-04-07 16:37:39 +09003932 ctx, _ := testApex(t, `
Jiyong Parka90ca002019-10-07 15:47:24 +09003933 apex {
3934 name: "myapex",
3935 key: "myapex.key",
3936 native_shared_libs: ["libfoo"],
3937 }
3938
3939 apex_key {
3940 name: "myapex.key",
3941 public_key: "testkey.avbpubkey",
3942 private_key: "testkey.pem",
3943 }
3944
3945 cc_library {
3946 name: "libfoo",
3947 stl: "none",
3948 system_shared_libs: [],
3949 apex_available: ["myapex"],
3950 static: {
3951 apex_available: ["//apex_available:platform"],
3952 },
3953 }`)
3954
Jiyong Park89e850a2020-04-07 16:37:39 +09003955 libfooShared := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
3956 if libfooShared.NotAvailableForPlatform() != true {
3957 t.Errorf("%q shouldn't be available to platform", libfooShared.String())
3958 }
3959 libfooStatic := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_static").Module().(*cc.Module)
3960 if libfooStatic.NotAvailableForPlatform() != false {
3961 t.Errorf("%q should be available to platform", libfooStatic.String())
3962 }
Jiyong Park127b40b2019-09-30 16:04:35 +09003963}
3964
Jiyong Park5d790c32019-11-15 18:40:32 +09003965func TestOverrideApex(t *testing.T) {
Jaewoong Jung1670ca02019-11-22 14:50:42 -08003966 ctx, config := testApex(t, `
Jiyong Park5d790c32019-11-15 18:40:32 +09003967 apex {
3968 name: "myapex",
3969 key: "myapex.key",
3970 apps: ["app"],
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08003971 overrides: ["oldapex"],
Jiyong Park5d790c32019-11-15 18:40:32 +09003972 }
3973
3974 override_apex {
3975 name: "override_myapex",
3976 base: "myapex",
3977 apps: ["override_app"],
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08003978 overrides: ["unknownapex"],
Baligh Uddin004d7172020-02-19 21:29:28 -08003979 logging_parent: "com.foo.bar",
Baligh Uddin5b57dba2020-03-15 13:01:05 -07003980 package_name: "test.overridden.package",
Jiyong Park5d790c32019-11-15 18:40:32 +09003981 }
3982
3983 apex_key {
3984 name: "myapex.key",
3985 public_key: "testkey.avbpubkey",
3986 private_key: "testkey.pem",
3987 }
3988
3989 android_app {
3990 name: "app",
3991 srcs: ["foo/bar/MyClass.java"],
3992 package_name: "foo",
3993 sdk_version: "none",
3994 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003995 apex_available: [ "myapex" ],
Jiyong Park5d790c32019-11-15 18:40:32 +09003996 }
3997
3998 override_android_app {
3999 name: "override_app",
4000 base: "app",
4001 package_name: "bar",
4002 }
Jiyong Park20bacab2020-03-03 11:45:41 +09004003 `, withManifestPackageNameOverrides([]string{"myapex:com.android.myapex"}))
Jiyong Park5d790c32019-11-15 18:40:32 +09004004
Jiyong Park317645e2019-12-05 13:20:58 +09004005 originalVariant := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(android.OverridableModule)
4006 overriddenVariant := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Module().(android.OverridableModule)
4007 if originalVariant.GetOverriddenBy() != "" {
4008 t.Errorf("GetOverriddenBy should be empty, but was %q", originalVariant.GetOverriddenBy())
4009 }
4010 if overriddenVariant.GetOverriddenBy() != "override_myapex" {
4011 t.Errorf("GetOverriddenBy should be \"override_myapex\", but was %q", overriddenVariant.GetOverriddenBy())
4012 }
4013
Jiyong Park5d790c32019-11-15 18:40:32 +09004014 module := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image")
4015 apexRule := module.Rule("apexRule")
4016 copyCmds := apexRule.Args["copy_commands"]
4017
4018 ensureNotContains(t, copyCmds, "image.apex/app/app/app.apk")
Jooyung Han39ee1192020-03-23 20:21:11 +09004019 ensureContains(t, copyCmds, "image.apex/app/override_app/override_app.apk")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08004020
4021 apexBundle := module.Module().(*apexBundle)
4022 name := apexBundle.Name()
4023 if name != "override_myapex" {
4024 t.Errorf("name should be \"override_myapex\", but was %q", name)
4025 }
4026
Baligh Uddin004d7172020-02-19 21:29:28 -08004027 if apexBundle.overridableProperties.Logging_parent != "com.foo.bar" {
4028 t.Errorf("override_myapex should have logging parent (com.foo.bar), but was %q.", apexBundle.overridableProperties.Logging_parent)
4029 }
4030
Jiyong Park20bacab2020-03-03 11:45:41 +09004031 optFlags := apexRule.Args["opt_flags"]
Baligh Uddin5b57dba2020-03-15 13:01:05 -07004032 ensureContains(t, optFlags, "--override_apk_package_name test.overridden.package")
Jiyong Park20bacab2020-03-03 11:45:41 +09004033
Jaewoong Jung1670ca02019-11-22 14:50:42 -08004034 data := android.AndroidMkDataForTest(t, config, "", apexBundle)
4035 var builder strings.Builder
4036 data.Custom(&builder, name, "TARGET_", "", data)
4037 androidMk := builder.String()
Jiyong Parkf653b052019-11-18 15:39:01 +09004038 ensureContains(t, androidMk, "LOCAL_MODULE := override_app.override_myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08004039 ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.override_myapex")
4040 ensureContains(t, androidMk, "LOCAL_MODULE_STEM := override_myapex.apex")
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08004041 ensureContains(t, androidMk, "LOCAL_OVERRIDES_MODULES := unknownapex myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08004042 ensureNotContains(t, androidMk, "LOCAL_MODULE := app.myapex")
Jiyong Parkf653b052019-11-18 15:39:01 +09004043 ensureNotContains(t, androidMk, "LOCAL_MODULE := override_app.myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08004044 ensureNotContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex")
4045 ensureNotContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.apex")
Jiyong Park5d790c32019-11-15 18:40:32 +09004046}
4047
Jooyung Han214bf372019-11-12 13:03:50 +09004048func TestLegacyAndroid10Support(t *testing.T) {
4049 ctx, _ := testApex(t, `
4050 apex {
4051 name: "myapex",
4052 key: "myapex.key",
Peter Collingbournedc4f9862020-02-12 17:13:25 -08004053 native_shared_libs: ["mylib"],
Jooyung Han5417f772020-03-12 18:37:20 +09004054 min_sdk_version: "29",
Jooyung Han214bf372019-11-12 13:03:50 +09004055 }
4056
4057 apex_key {
4058 name: "myapex.key",
4059 public_key: "testkey.avbpubkey",
4060 private_key: "testkey.pem",
4061 }
Peter Collingbournedc4f9862020-02-12 17:13:25 -08004062
4063 cc_library {
4064 name: "mylib",
4065 srcs: ["mylib.cpp"],
4066 stl: "libc++",
4067 system_shared_libs: [],
4068 apex_available: [ "myapex" ],
4069 }
Peter Collingbournedc4f9862020-02-12 17:13:25 -08004070 `, withUnbundledBuild)
Jooyung Han214bf372019-11-12 13:03:50 +09004071
4072 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
4073 args := module.Rule("apexRule").Args
4074 ensureContains(t, args["opt_flags"], "--manifest_json "+module.Output("apex_manifest.json").Output.String())
Dario Frenie3546902020-01-14 23:50:25 +00004075 ensureNotContains(t, args["opt_flags"], "--no_hashtree")
Peter Collingbournedc4f9862020-02-12 17:13:25 -08004076
4077 // The copies of the libraries in the apex should have one more dependency than
4078 // the ones outside the apex, namely the unwinder. Ideally we should check
4079 // the dependency names directly here but for some reason the names are blank in
4080 // this test.
4081 for _, lib := range []string{"libc++", "mylib"} {
4082 apexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared_myapex").Rule("ld").Implicits
4083 nonApexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared").Rule("ld").Implicits
4084 if len(apexImplicits) != len(nonApexImplicits)+1 {
4085 t.Errorf("%q missing unwinder dep", lib)
4086 }
4087 }
Jooyung Han214bf372019-11-12 13:03:50 +09004088}
4089
Jooyung Han58f26ab2019-12-18 15:34:32 +09004090func TestJavaSDKLibrary(t *testing.T) {
4091 ctx, _ := testApex(t, `
4092 apex {
4093 name: "myapex",
4094 key: "myapex.key",
4095 java_libs: ["foo"],
4096 }
4097
4098 apex_key {
4099 name: "myapex.key",
4100 public_key: "testkey.avbpubkey",
4101 private_key: "testkey.pem",
4102 }
4103
4104 java_sdk_library {
4105 name: "foo",
4106 srcs: ["a.java"],
4107 api_packages: ["foo"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004108 apex_available: [ "myapex" ],
Jooyung Han58f26ab2019-12-18 15:34:32 +09004109 }
4110 `, withFiles(map[string][]byte{
4111 "api/current.txt": nil,
4112 "api/removed.txt": nil,
4113 "api/system-current.txt": nil,
4114 "api/system-removed.txt": nil,
4115 "api/test-current.txt": nil,
4116 "api/test-removed.txt": nil,
4117 }))
4118
4119 // java_sdk_library installs both impl jar and permission XML
Jooyung Hana57af4a2020-01-23 05:36:59 +00004120 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Han58f26ab2019-12-18 15:34:32 +09004121 "javalib/foo.jar",
4122 "etc/permissions/foo.xml",
4123 })
4124 // Permission XML should point to the activated path of impl jar of java_sdk_library
Jiyong Parke3833882020-02-17 17:28:10 +09004125 sdkLibrary := ctx.ModuleForTests("foo.xml", "android_common_myapex").Rule("java_sdk_xml")
4126 ensureContains(t, sdkLibrary.RuleParams.Command, `<library name=\"foo\" file=\"/apex/myapex/javalib/foo.jar\"`)
Jooyung Han58f26ab2019-12-18 15:34:32 +09004127}
4128
atrost6e126252020-01-27 17:01:16 +00004129func TestCompatConfig(t *testing.T) {
4130 ctx, _ := testApex(t, `
4131 apex {
4132 name: "myapex",
4133 key: "myapex.key",
4134 prebuilts: ["myjar-platform-compat-config"],
4135 java_libs: ["myjar"],
4136 }
4137
4138 apex_key {
4139 name: "myapex.key",
4140 public_key: "testkey.avbpubkey",
4141 private_key: "testkey.pem",
4142 }
4143
4144 platform_compat_config {
4145 name: "myjar-platform-compat-config",
4146 src: ":myjar",
4147 }
4148
4149 java_library {
4150 name: "myjar",
4151 srcs: ["foo/bar/MyClass.java"],
4152 sdk_version: "none",
4153 system_modules: "none",
atrost6e126252020-01-27 17:01:16 +00004154 apex_available: [ "myapex" ],
4155 }
4156 `)
4157 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
4158 "etc/compatconfig/myjar-platform-compat-config.xml",
4159 "javalib/myjar.jar",
4160 })
4161}
4162
Jiyong Park479321d2019-12-16 11:47:12 +09004163func TestRejectNonInstallableJavaLibrary(t *testing.T) {
4164 testApexError(t, `"myjar" is not configured to be compiled into dex`, `
4165 apex {
4166 name: "myapex",
4167 key: "myapex.key",
4168 java_libs: ["myjar"],
4169 }
4170
4171 apex_key {
4172 name: "myapex.key",
4173 public_key: "testkey.avbpubkey",
4174 private_key: "testkey.pem",
4175 }
4176
4177 java_library {
4178 name: "myjar",
4179 srcs: ["foo/bar/MyClass.java"],
4180 sdk_version: "none",
4181 system_modules: "none",
Jiyong Park6b21c7d2020-02-11 09:16:01 +09004182 compile_dex: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09004183 apex_available: ["myapex"],
Jiyong Park479321d2019-12-16 11:47:12 +09004184 }
4185 `)
4186}
4187
Jiyong Park7afd1072019-12-30 16:56:33 +09004188func TestCarryRequiredModuleNames(t *testing.T) {
4189 ctx, config := testApex(t, `
4190 apex {
4191 name: "myapex",
4192 key: "myapex.key",
4193 native_shared_libs: ["mylib"],
4194 }
4195
4196 apex_key {
4197 name: "myapex.key",
4198 public_key: "testkey.avbpubkey",
4199 private_key: "testkey.pem",
4200 }
4201
4202 cc_library {
4203 name: "mylib",
4204 srcs: ["mylib.cpp"],
4205 system_shared_libs: [],
4206 stl: "none",
4207 required: ["a", "b"],
4208 host_required: ["c", "d"],
4209 target_required: ["e", "f"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004210 apex_available: [ "myapex" ],
Jiyong Park7afd1072019-12-30 16:56:33 +09004211 }
4212 `)
4213
4214 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
4215 data := android.AndroidMkDataForTest(t, config, "", apexBundle)
4216 name := apexBundle.BaseModuleName()
4217 prefix := "TARGET_"
4218 var builder strings.Builder
4219 data.Custom(&builder, name, prefix, "", data)
4220 androidMk := builder.String()
4221 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += a b\n")
4222 ensureContains(t, androidMk, "LOCAL_HOST_REQUIRED_MODULES += c d\n")
4223 ensureContains(t, androidMk, "LOCAL_TARGET_REQUIRED_MODULES += e f\n")
4224}
4225
Jiyong Park7cd10e32020-01-14 09:22:18 +09004226func TestSymlinksFromApexToSystem(t *testing.T) {
4227 bp := `
4228 apex {
4229 name: "myapex",
4230 key: "myapex.key",
4231 native_shared_libs: ["mylib"],
4232 java_libs: ["myjar"],
4233 }
4234
Jiyong Park9d677202020-02-19 16:29:35 +09004235 apex {
4236 name: "myapex.updatable",
4237 key: "myapex.key",
4238 native_shared_libs: ["mylib"],
4239 java_libs: ["myjar"],
4240 updatable: true,
Jooyung Han548640b2020-04-27 12:10:30 +09004241 min_sdk_version: "current",
Jiyong Park9d677202020-02-19 16:29:35 +09004242 }
4243
Jiyong Park7cd10e32020-01-14 09:22:18 +09004244 apex_key {
4245 name: "myapex.key",
4246 public_key: "testkey.avbpubkey",
4247 private_key: "testkey.pem",
4248 }
4249
4250 cc_library {
4251 name: "mylib",
4252 srcs: ["mylib.cpp"],
4253 shared_libs: ["myotherlib"],
4254 system_shared_libs: [],
4255 stl: "none",
4256 apex_available: [
4257 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09004258 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09004259 "//apex_available:platform",
4260 ],
4261 }
4262
4263 cc_library {
4264 name: "myotherlib",
4265 srcs: ["mylib.cpp"],
4266 system_shared_libs: [],
4267 stl: "none",
4268 apex_available: [
4269 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09004270 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09004271 "//apex_available:platform",
4272 ],
4273 }
4274
4275 java_library {
4276 name: "myjar",
4277 srcs: ["foo/bar/MyClass.java"],
4278 sdk_version: "none",
4279 system_modules: "none",
4280 libs: ["myotherjar"],
Jiyong Park7cd10e32020-01-14 09:22:18 +09004281 apex_available: [
4282 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09004283 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09004284 "//apex_available:platform",
4285 ],
4286 }
4287
4288 java_library {
4289 name: "myotherjar",
4290 srcs: ["foo/bar/MyClass.java"],
4291 sdk_version: "none",
4292 system_modules: "none",
4293 apex_available: [
4294 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09004295 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09004296 "//apex_available:platform",
4297 ],
4298 }
4299 `
4300
4301 ensureRealfileExists := func(t *testing.T, files []fileInApex, file string) {
4302 for _, f := range files {
4303 if f.path == file {
4304 if f.isLink {
4305 t.Errorf("%q is not a real file", file)
4306 }
4307 return
4308 }
4309 }
4310 t.Errorf("%q is not found", file)
4311 }
4312
4313 ensureSymlinkExists := func(t *testing.T, files []fileInApex, file string) {
4314 for _, f := range files {
4315 if f.path == file {
4316 if !f.isLink {
4317 t.Errorf("%q is not a symlink", file)
4318 }
4319 return
4320 }
4321 }
4322 t.Errorf("%q is not found", file)
4323 }
4324
Jiyong Park9d677202020-02-19 16:29:35 +09004325 // For unbundled build, symlink shouldn't exist regardless of whether an APEX
4326 // is updatable or not
Jiyong Park7cd10e32020-01-14 09:22:18 +09004327 ctx, _ := testApex(t, bp, withUnbundledBuild)
Jooyung Hana57af4a2020-01-23 05:36:59 +00004328 files := getFiles(t, ctx, "myapex", "android_common_myapex_image")
Jiyong Park7cd10e32020-01-14 09:22:18 +09004329 ensureRealfileExists(t, files, "javalib/myjar.jar")
4330 ensureRealfileExists(t, files, "lib64/mylib.so")
4331 ensureRealfileExists(t, files, "lib64/myotherlib.so")
4332
Jiyong Park9d677202020-02-19 16:29:35 +09004333 files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
4334 ensureRealfileExists(t, files, "javalib/myjar.jar")
4335 ensureRealfileExists(t, files, "lib64/mylib.so")
4336 ensureRealfileExists(t, files, "lib64/myotherlib.so")
4337
4338 // For bundled build, symlink to the system for the non-updatable APEXes only
Jiyong Park7cd10e32020-01-14 09:22:18 +09004339 ctx, _ = testApex(t, bp)
Jooyung Hana57af4a2020-01-23 05:36:59 +00004340 files = getFiles(t, ctx, "myapex", "android_common_myapex_image")
Jiyong Park7cd10e32020-01-14 09:22:18 +09004341 ensureRealfileExists(t, files, "javalib/myjar.jar")
4342 ensureRealfileExists(t, files, "lib64/mylib.so")
4343 ensureSymlinkExists(t, files, "lib64/myotherlib.so") // this is symlink
Jiyong Park9d677202020-02-19 16:29:35 +09004344
4345 files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
4346 ensureRealfileExists(t, files, "javalib/myjar.jar")
4347 ensureRealfileExists(t, files, "lib64/mylib.so")
4348 ensureRealfileExists(t, files, "lib64/myotherlib.so") // this is a real file
Jiyong Park7cd10e32020-01-14 09:22:18 +09004349}
4350
Jooyung Han643adc42020-02-27 13:50:06 +09004351func TestApexWithJniLibs(t *testing.T) {
4352 ctx, _ := testApex(t, `
4353 apex {
4354 name: "myapex",
4355 key: "myapex.key",
4356 jni_libs: ["mylib"],
4357 }
4358
4359 apex_key {
4360 name: "myapex.key",
4361 public_key: "testkey.avbpubkey",
4362 private_key: "testkey.pem",
4363 }
4364
4365 cc_library {
4366 name: "mylib",
4367 srcs: ["mylib.cpp"],
4368 shared_libs: ["mylib2"],
4369 system_shared_libs: [],
4370 stl: "none",
4371 apex_available: [ "myapex" ],
4372 }
4373
4374 cc_library {
4375 name: "mylib2",
4376 srcs: ["mylib.cpp"],
4377 system_shared_libs: [],
4378 stl: "none",
4379 apex_available: [ "myapex" ],
4380 }
4381 `)
4382
4383 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
4384 // Notice mylib2.so (transitive dep) is not added as a jni_lib
4385 ensureEquals(t, rule.Args["opt"], "-a jniLibs mylib.so")
4386 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
4387 "lib64/mylib.so",
4388 "lib64/mylib2.so",
4389 })
4390}
4391
Jooyung Han49f67012020-04-17 13:43:10 +09004392func TestApexMutatorsDontRunIfDisabled(t *testing.T) {
4393 ctx, _ := testApex(t, `
4394 apex {
4395 name: "myapex",
4396 key: "myapex.key",
4397 }
4398 apex_key {
4399 name: "myapex.key",
4400 public_key: "testkey.avbpubkey",
4401 private_key: "testkey.pem",
4402 }
4403 `, func(fs map[string][]byte, config android.Config) {
4404 delete(config.Targets, android.Android)
4405 config.AndroidCommonTarget = android.Target{}
4406 })
4407
4408 if expected, got := []string{""}, ctx.ModuleVariantsForTests("myapex"); !reflect.DeepEqual(expected, got) {
4409 t.Errorf("Expected variants: %v, but got: %v", expected, got)
4410 }
4411}
4412
Jooyung Han643adc42020-02-27 13:50:06 +09004413func TestApexWithJniLibs_Errors(t *testing.T) {
4414 testApexError(t, `jni_libs: "xxx" is not a cc_library`, `
4415 apex {
4416 name: "myapex",
4417 key: "myapex.key",
4418 jni_libs: ["xxx"],
4419 }
4420
4421 apex_key {
4422 name: "myapex.key",
4423 public_key: "testkey.avbpubkey",
4424 private_key: "testkey.pem",
4425 }
4426
4427 prebuilt_etc {
4428 name: "xxx",
4429 src: "xxx",
4430 }
4431 `, withFiles(map[string][]byte{
4432 "xxx": nil,
4433 }))
4434}
4435
Jiyong Parkbd159612020-02-28 15:22:21 +09004436func TestAppBundle(t *testing.T) {
4437 ctx, _ := testApex(t, `
4438 apex {
4439 name: "myapex",
4440 key: "myapex.key",
4441 apps: ["AppFoo"],
4442 }
4443
4444 apex_key {
4445 name: "myapex.key",
4446 public_key: "testkey.avbpubkey",
4447 private_key: "testkey.pem",
4448 }
4449
4450 android_app {
4451 name: "AppFoo",
4452 srcs: ["foo/bar/MyClass.java"],
4453 sdk_version: "none",
4454 system_modules: "none",
4455 apex_available: [ "myapex" ],
4456 }
Jiyong Parkcfaa1642020-02-28 16:51:07 +09004457 `, withManifestPackageNameOverrides([]string{"AppFoo:com.android.foo"}))
Jiyong Parkbd159612020-02-28 15:22:21 +09004458
4459 bundleConfigRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Description("Bundle Config")
4460 content := bundleConfigRule.Args["content"]
4461
4462 ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
Jiyong Parkcfaa1642020-02-28 16:51:07 +09004463 ensureContains(t, content, `"apex_config":{"apex_embedded_apk_config":[{"package_name":"com.android.foo","path":"app/AppFoo/AppFoo.apk"}]}`)
Jiyong Parkbd159612020-02-28 15:22:21 +09004464}
4465
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00004466func testNoUpdatableJarsInBootImage(t *testing.T, errmsg, bp string, transformDexpreoptConfig func(*dexpreopt.GlobalConfig)) {
4467 t.Helper()
4468
4469 bp = bp + `
4470 filegroup {
4471 name: "some-updatable-apex-file_contexts",
4472 srcs: [
4473 "system/sepolicy/apex/some-updatable-apex-file_contexts",
4474 ],
4475 }
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01004476
4477 filegroup {
4478 name: "some-non-updatable-apex-file_contexts",
4479 srcs: [
4480 "system/sepolicy/apex/some-non-updatable-apex-file_contexts",
4481 ],
4482 }
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00004483 `
4484 bp += cc.GatherRequiredDepsForTest(android.Android)
4485 bp += java.GatherRequiredDepsForTest()
4486 bp += dexpreopt.BpToolModulesForTest()
4487
4488 fs := map[string][]byte{
4489 "a.java": nil,
4490 "a.jar": nil,
4491 "build/make/target/product/security": nil,
4492 "apex_manifest.json": nil,
4493 "AndroidManifest.xml": nil,
4494 "system/sepolicy/apex/some-updatable-apex-file_contexts": nil,
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01004495 "system/sepolicy/apex/some-non-updatable-apex-file_contexts": nil,
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00004496 "system/sepolicy/apex/com.android.art.something-file_contexts": nil,
4497 "framework/aidl/a.aidl": nil,
4498 }
4499 cc.GatherRequiredFilesForTest(fs)
4500
4501 ctx := android.NewTestArchContext()
4502 ctx.RegisterModuleType("apex", BundleFactory)
4503 ctx.RegisterModuleType("apex_key", ApexKeyFactory)
4504 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
4505 cc.RegisterRequiredBuildComponentsForTest(ctx)
4506 java.RegisterJavaBuildComponents(ctx)
4507 java.RegisterSystemModulesBuildComponents(ctx)
4508 java.RegisterAppBuildComponents(ctx)
4509 java.RegisterDexpreoptBootJarsComponents(ctx)
4510 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
4511 ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
4512 ctx.PreDepsMutators(RegisterPreDepsMutators)
4513 ctx.PostDepsMutators(RegisterPostDepsMutators)
4514
4515 config := android.TestArchConfig(buildDir, nil, bp, fs)
4516 ctx.Register(config)
4517
4518 _ = dexpreopt.GlobalSoongConfigForTests(config)
4519 dexpreopt.RegisterToolModulesForTest(ctx)
4520 pathCtx := android.PathContextForTesting(config)
4521 dexpreoptConfig := dexpreopt.GlobalConfigForTests(pathCtx)
4522 transformDexpreoptConfig(dexpreoptConfig)
4523 dexpreopt.SetTestGlobalConfig(config, dexpreoptConfig)
4524
4525 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
4526 android.FailIfErrored(t, errs)
4527
4528 _, errs = ctx.PrepareBuildActions(config)
4529 if errmsg == "" {
4530 android.FailIfErrored(t, errs)
4531 } else if len(errs) > 0 {
4532 android.FailIfNoMatchingErrors(t, errmsg, errs)
4533 return
4534 } else {
4535 t.Fatalf("missing expected error %q (0 errors are returned)", errmsg)
4536 }
4537}
4538
Jooyung Han548640b2020-04-27 12:10:30 +09004539func TestUpdatable_should_set_min_sdk_version(t *testing.T) {
4540 testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
4541 apex {
4542 name: "myapex",
4543 key: "myapex.key",
4544 updatable: true,
4545 }
4546
4547 apex_key {
4548 name: "myapex.key",
4549 public_key: "testkey.avbpubkey",
4550 private_key: "testkey.pem",
4551 }
4552 `)
4553}
4554
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00004555func TestNoUpdatableJarsInBootImage(t *testing.T) {
4556 bp := `
4557 java_library {
4558 name: "some-updatable-apex-lib",
4559 srcs: ["a.java"],
Artur Satayev8cf899a2020-04-15 17:29:42 +01004560 sdk_version: "current",
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00004561 apex_available: [
4562 "some-updatable-apex",
4563 ],
4564 }
4565
4566 java_library {
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01004567 name: "some-non-updatable-apex-lib",
4568 srcs: ["a.java"],
4569 apex_available: [
4570 "some-non-updatable-apex",
4571 ],
4572 }
4573
4574 java_library {
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00004575 name: "some-platform-lib",
4576 srcs: ["a.java"],
Artur Satayev8cf899a2020-04-15 17:29:42 +01004577 sdk_version: "current",
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00004578 installable: true,
4579 }
4580
4581 java_library {
4582 name: "some-art-lib",
4583 srcs: ["a.java"],
Artur Satayev8cf899a2020-04-15 17:29:42 +01004584 sdk_version: "current",
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00004585 apex_available: [
4586 "com.android.art.something",
4587 ],
4588 hostdex: true,
4589 }
4590
4591 apex {
4592 name: "some-updatable-apex",
4593 key: "some-updatable-apex.key",
4594 java_libs: ["some-updatable-apex-lib"],
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01004595 updatable: true,
Jooyung Han548640b2020-04-27 12:10:30 +09004596 min_sdk_version: "current",
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01004597 }
4598
4599 apex {
4600 name: "some-non-updatable-apex",
4601 key: "some-non-updatable-apex.key",
4602 java_libs: ["some-non-updatable-apex-lib"],
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00004603 }
4604
4605 apex_key {
4606 name: "some-updatable-apex.key",
4607 }
4608
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01004609 apex_key {
4610 name: "some-non-updatable-apex.key",
4611 }
4612
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00004613 apex {
4614 name: "com.android.art.something",
4615 key: "com.android.art.something.key",
4616 java_libs: ["some-art-lib"],
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01004617 updatable: true,
Jooyung Han548640b2020-04-27 12:10:30 +09004618 min_sdk_version: "current",
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00004619 }
4620
4621 apex_key {
4622 name: "com.android.art.something.key",
4623 }
4624 `
4625
4626 var error string
4627 var transform func(*dexpreopt.GlobalConfig)
4628
4629 // updatable jar from ART apex in the ART boot image => ok
4630 transform = func(config *dexpreopt.GlobalConfig) {
4631 config.ArtApexJars = []string{"some-art-lib"}
4632 }
4633 testNoUpdatableJarsInBootImage(t, "", bp, transform)
4634
4635 // updatable jar from ART apex in the framework boot image => error
4636 error = "module 'some-art-lib' from updatable apex 'com.android.art.something' is not allowed in the framework boot image"
4637 transform = func(config *dexpreopt.GlobalConfig) {
4638 config.BootJars = []string{"some-art-lib"}
4639 }
4640 testNoUpdatableJarsInBootImage(t, error, bp, transform)
4641
4642 // updatable jar from some other apex in the ART boot image => error
4643 error = "module 'some-updatable-apex-lib' from updatable apex 'some-updatable-apex' is not allowed in the ART boot image"
4644 transform = func(config *dexpreopt.GlobalConfig) {
4645 config.ArtApexJars = []string{"some-updatable-apex-lib"}
4646 }
4647 testNoUpdatableJarsInBootImage(t, error, bp, transform)
4648
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01004649 // non-updatable jar from some other apex in the ART boot image => error
4650 error = "module 'some-non-updatable-apex-lib' is not allowed in the ART boot image"
4651 transform = func(config *dexpreopt.GlobalConfig) {
4652 config.ArtApexJars = []string{"some-non-updatable-apex-lib"}
4653 }
4654 testNoUpdatableJarsInBootImage(t, error, bp, transform)
4655
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00004656 // updatable jar from some other apex in the framework boot image => error
4657 error = "module 'some-updatable-apex-lib' from updatable apex 'some-updatable-apex' is not allowed in the framework boot image"
4658 transform = func(config *dexpreopt.GlobalConfig) {
4659 config.BootJars = []string{"some-updatable-apex-lib"}
4660 }
4661 testNoUpdatableJarsInBootImage(t, error, bp, transform)
4662
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01004663 // non-updatable jar from some other apex in the framework boot image => ok
4664 transform = func(config *dexpreopt.GlobalConfig) {
4665 config.BootJars = []string{"some-non-updatable-apex-lib"}
4666 }
4667 testNoUpdatableJarsInBootImage(t, "", bp, transform)
4668
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00004669 // nonexistent jar in the ART boot image => error
4670 error = "failed to find a dex jar path for module 'nonexistent'"
4671 transform = func(config *dexpreopt.GlobalConfig) {
4672 config.ArtApexJars = []string{"nonexistent"}
4673 }
4674 testNoUpdatableJarsInBootImage(t, error, bp, transform)
4675
4676 // nonexistent jar in the framework boot image => error
4677 error = "failed to find a dex jar path for module 'nonexistent'"
4678 transform = func(config *dexpreopt.GlobalConfig) {
4679 config.BootJars = []string{"nonexistent"}
4680 }
4681 testNoUpdatableJarsInBootImage(t, error, bp, transform)
4682
4683 // platform jar in the ART boot image => error
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01004684 error = "module 'some-platform-lib' is not allowed in the ART boot image"
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00004685 transform = func(config *dexpreopt.GlobalConfig) {
4686 config.ArtApexJars = []string{"some-platform-lib"}
4687 }
4688 testNoUpdatableJarsInBootImage(t, error, bp, transform)
4689
4690 // platform jar in the framework boot image => ok
4691 transform = func(config *dexpreopt.GlobalConfig) {
4692 config.BootJars = []string{"some-platform-lib"}
4693 }
4694 testNoUpdatableJarsInBootImage(t, "", bp, transform)
4695}
4696
Jiyong Park62304bb2020-04-13 16:19:48 +09004697func TestTestFor(t *testing.T) {
4698 ctx, _ := testApex(t, `
4699 apex {
4700 name: "myapex",
4701 key: "myapex.key",
4702 native_shared_libs: ["mylib", "myprivlib"],
4703 }
4704
4705 apex_key {
4706 name: "myapex.key",
4707 public_key: "testkey.avbpubkey",
4708 private_key: "testkey.pem",
4709 }
4710
4711 cc_library {
4712 name: "mylib",
4713 srcs: ["mylib.cpp"],
4714 system_shared_libs: [],
4715 stl: "none",
4716 stubs: {
4717 versions: ["1"],
4718 },
4719 apex_available: ["myapex"],
4720 }
4721
4722 cc_library {
4723 name: "myprivlib",
4724 srcs: ["mylib.cpp"],
4725 system_shared_libs: [],
4726 stl: "none",
4727 apex_available: ["myapex"],
4728 }
4729
4730
4731 cc_test {
4732 name: "mytest",
4733 gtest: false,
4734 srcs: ["mylib.cpp"],
4735 system_shared_libs: [],
4736 stl: "none",
4737 shared_libs: ["mylib", "myprivlib"],
4738 test_for: ["myapex"]
4739 }
4740 `)
4741
4742 // the test 'mytest' is a test for the apex, therefore is linked to the
4743 // actual implementation of mylib instead of its stub.
4744 ldFlags := ctx.ModuleForTests("mytest", "android_arm64_armv8-a").Rule("ld").Args["libFlags"]
4745 ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_shared/mylib.so")
4746 ensureNotContains(t, ldFlags, "mylib/android_arm64_armv8-a_shared_1/mylib.so")
4747}
4748
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07004749func TestMain(m *testing.M) {
4750 run := func() int {
4751 setUp()
4752 defer tearDown()
4753
4754 return m.Run()
4755 }
4756
4757 os.Exit(run())
4758}