blob: 6280d118c020bc0be21dbae8f128328adf69346f [file] [log] [blame]
Jiyong Park25fc6a92018-11-18 18:02:45 +09001// Copyright 2018 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package apex
16
17import (
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +090018 "fmt"
Jiyong Park25fc6a92018-11-18 18:02:45 +090019 "os"
Jooyung Han39edb6c2019-11-06 16:53:07 +090020 "path"
Paul Duffin37856732021-02-26 14:24:15 +000021 "path/filepath"
Jaewoong Jung22f7d182019-07-16 18:25:41 -070022 "reflect"
Paul Duffin9b879592020-05-26 13:21:35 +010023 "regexp"
Jooyung Han31c470b2019-10-18 16:26:59 +090024 "sort"
Jiyong Parkd4a3a132021-03-17 20:21:35 +090025 "strconv"
Jiyong Park25fc6a92018-11-18 18:02:45 +090026 "strings"
27 "testing"
Jiyong Parkda6eb592018-12-19 17:12:36 +090028
29 "github.com/google/blueprint/proptools"
30
31 "android/soong/android"
markchien2f59ec92020-09-02 16:23:38 +080032 "android/soong/bpf"
Jiyong Parkda6eb592018-12-19 17:12:36 +090033 "android/soong/cc"
Ulya Trafimovichb28cc372020-01-13 15:18:16 +000034 "android/soong/dexpreopt"
Jaewoong Jung4b79e982020-06-01 10:45:49 -070035 prebuilt_etc "android/soong/etc"
Jiyong Parkb2742fd2019-02-11 11:38:15 +090036 "android/soong/java"
Jiyong Park99644e92020-11-17 22:21:02 +090037 "android/soong/rust"
Jaewoong Jung4b79e982020-06-01 10:45:49 -070038 "android/soong/sh"
Jiyong Park25fc6a92018-11-18 18:02:45 +090039)
40
Jooyung Hand3639552019-08-09 12:57:43 +090041// names returns name list from white space separated string
42func names(s string) (ns []string) {
43 for _, n := range strings.Split(s, " ") {
44 if len(n) > 0 {
45 ns = append(ns, n)
46 }
47 }
48 return
49}
50
Paul Duffin40b62572021-03-20 11:39:01 +000051func testApexError(t *testing.T, pattern, bp string, preparers ...android.FixturePreparer) {
Jooyung Han344d5432019-08-23 11:17:39 +090052 t.Helper()
Paul Duffin284165a2021-03-29 01:50:31 +010053 android.GroupFixturePreparers(
54 prepareForApexTest,
55 android.GroupFixturePreparers(preparers...),
56 ).
Paul Duffine05480a2021-03-08 15:07:14 +000057 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)).
Paul Duffin40b62572021-03-20 11:39:01 +000058 RunTestWithBp(t, bp)
Jooyung Han5c998b92019-06-27 11:30:33 +090059}
60
Paul Duffin40b62572021-03-20 11:39:01 +000061func testApex(t *testing.T, bp string, preparers ...android.FixturePreparer) *android.TestContext {
Jooyung Han344d5432019-08-23 11:17:39 +090062 t.Helper()
Paul Duffin284165a2021-03-29 01:50:31 +010063
64 optionalBpPreparer := android.NullFixturePreparer
Paul Duffin40b62572021-03-20 11:39:01 +000065 if bp != "" {
Paul Duffin284165a2021-03-29 01:50:31 +010066 optionalBpPreparer = android.FixtureWithRootAndroidBp(bp)
Paul Duffin40b62572021-03-20 11:39:01 +000067 }
Paul Duffin284165a2021-03-29 01:50:31 +010068
69 result := android.GroupFixturePreparers(
70 prepareForApexTest,
71 android.GroupFixturePreparers(preparers...),
72 optionalBpPreparer,
73 ).RunTest(t)
74
Paul Duffine05480a2021-03-08 15:07:14 +000075 return result.TestContext
Jooyung Han5c998b92019-06-27 11:30:33 +090076}
77
Paul Duffin810f33d2021-03-09 14:12:32 +000078func withFiles(files android.MockFS) android.FixturePreparer {
79 return files.AddToFixture()
Jooyung Han344d5432019-08-23 11:17:39 +090080}
81
Paul Duffin810f33d2021-03-09 14:12:32 +000082func withTargets(targets map[android.OsType][]android.Target) android.FixturePreparer {
83 return android.FixtureModifyConfig(func(config android.Config) {
Jooyung Han344d5432019-08-23 11:17:39 +090084 for k, v := range targets {
85 config.Targets[k] = v
86 }
Paul Duffin810f33d2021-03-09 14:12:32 +000087 })
Jooyung Han344d5432019-08-23 11:17:39 +090088}
89
Jooyung Han35155c42020-02-06 17:33:20 +090090// withNativeBridgeTargets sets configuration with targets including:
91// - X86_64 (primary)
92// - X86 (secondary)
93// - Arm64 on X86_64 (native bridge)
94// - Arm on X86 (native bridge)
Paul Duffin810f33d2021-03-09 14:12:32 +000095var withNativeBridgeEnabled = android.FixtureModifyConfig(
96 func(config android.Config) {
97 config.Targets[android.Android] = []android.Target{
98 {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "silvermont", Abi: []string{"arm64-v8a"}},
99 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
100 {Os: android.Android, Arch: android.Arch{ArchType: android.X86, ArchVariant: "silvermont", Abi: []string{"armeabi-v7a"}},
101 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
102 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}},
103 NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86_64", NativeBridgeRelativePath: "arm64"},
104 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
105 NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86", NativeBridgeRelativePath: "arm"},
106 }
107 },
108)
109
110func withManifestPackageNameOverrides(specs []string) android.FixturePreparer {
111 return android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
112 variables.ManifestPackageNameOverrides = specs
113 })
Jooyung Han35155c42020-02-06 17:33:20 +0900114}
115
Paul Duffin810f33d2021-03-09 14:12:32 +0000116var withBinder32bit = android.FixtureModifyProductVariables(
117 func(variables android.FixtureProductVariables) {
118 variables.Binder32bit = proptools.BoolPtr(true)
119 },
120)
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900121
Paul Duffin810f33d2021-03-09 14:12:32 +0000122var withUnbundledBuild = android.FixtureModifyProductVariables(
123 func(variables android.FixtureProductVariables) {
124 variables.Unbundled_build = proptools.BoolPtr(true)
125 },
126)
Jiyong Park7cd10e32020-01-14 09:22:18 +0900127
Paul Duffin284165a2021-03-29 01:50:31 +0100128// Legacy preparer used for running tests within the apex package.
129//
130// This includes everything that was needed to run any test in the apex package prior to the
131// introduction of the test fixtures. Tests that are being converted to use fixtures directly
132// rather than through the testApex...() methods should avoid using this and instead use the
133// various preparers directly, using android.GroupFixturePreparers(...) to group them when
134// necessary.
135//
136// deprecated
137var prepareForApexTest = android.GroupFixturePreparers(
Paul Duffin37aad602021-03-08 09:47:16 +0000138 // General preparers in alphabetical order as test infrastructure will enforce correct
139 // registration order.
140 android.PrepareForTestWithAndroidBuildComponents,
141 bpf.PrepareForTestWithBpf,
142 cc.PrepareForTestWithCcBuildComponents,
143 java.PrepareForTestWithJavaDefaultModules,
144 prebuilt_etc.PrepareForTestWithPrebuiltEtc,
145 rust.PrepareForTestWithRustDefaultModules,
146 sh.PrepareForTestWithShBuildComponents,
147
148 PrepareForTestWithApexBuildComponents,
149
150 // Additional apex test specific preparers.
151 android.FixtureAddTextFile("system/sepolicy/Android.bp", `
152 filegroup {
153 name: "myapex-file_contexts",
154 srcs: [
155 "apex/myapex-file_contexts",
156 ],
157 }
158 `),
Paul Duffin52bfaa42021-03-23 23:40:12 +0000159 prepareForTestWithMyapex,
Paul Duffin37aad602021-03-08 09:47:16 +0000160 android.FixtureMergeMockFs(android.MockFS{
Paul Duffin52bfaa42021-03-23 23:40:12 +0000161 "a.java": nil,
162 "PrebuiltAppFoo.apk": nil,
163 "PrebuiltAppFooPriv.apk": nil,
164 "apex_manifest.json": nil,
165 "AndroidManifest.xml": nil,
Paul Duffin37aad602021-03-08 09:47:16 +0000166 "system/sepolicy/apex/myapex.updatable-file_contexts": nil,
167 "system/sepolicy/apex/myapex2-file_contexts": nil,
168 "system/sepolicy/apex/otherapex-file_contexts": nil,
169 "system/sepolicy/apex/com.android.vndk-file_contexts": nil,
170 "system/sepolicy/apex/com.android.vndk.current-file_contexts": nil,
171 "mylib.cpp": nil,
172 "mytest.cpp": nil,
173 "mytest1.cpp": nil,
174 "mytest2.cpp": nil,
175 "mytest3.cpp": nil,
176 "myprebuilt": nil,
177 "my_include": nil,
178 "foo/bar/MyClass.java": nil,
179 "prebuilt.jar": nil,
180 "prebuilt.so": nil,
181 "vendor/foo/devkeys/test.x509.pem": nil,
182 "vendor/foo/devkeys/test.pk8": nil,
183 "testkey.x509.pem": nil,
184 "testkey.pk8": nil,
185 "testkey.override.x509.pem": nil,
186 "testkey.override.pk8": nil,
187 "vendor/foo/devkeys/testkey.avbpubkey": nil,
188 "vendor/foo/devkeys/testkey.pem": nil,
189 "NOTICE": nil,
190 "custom_notice": nil,
191 "custom_notice_for_static_lib": nil,
192 "testkey2.avbpubkey": nil,
193 "testkey2.pem": nil,
194 "myapex-arm64.apex": nil,
195 "myapex-arm.apex": nil,
196 "myapex.apks": nil,
197 "frameworks/base/api/current.txt": nil,
198 "framework/aidl/a.aidl": nil,
199 "build/make/core/proguard.flags": nil,
200 "build/make/core/proguard_basic_keeps.flags": nil,
201 "dummy.txt": nil,
202 "baz": nil,
203 "bar/baz": nil,
204 "testdata/baz": nil,
205 "AppSet.apks": nil,
206 "foo.rs": nil,
207 "libfoo.jar": nil,
208 "libbar.jar": nil,
209 },
210 ),
211
212 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
213 variables.DeviceVndkVersion = proptools.StringPtr("current")
214 variables.DefaultAppCertificate = proptools.StringPtr("vendor/foo/devkeys/test")
215 variables.CertificateOverrides = []string{"myapex_keytest:myapex.certificate.override"}
216 variables.Platform_sdk_codename = proptools.StringPtr("Q")
217 variables.Platform_sdk_final = proptools.BoolPtr(false)
218 variables.Platform_version_active_codenames = []string{"Q"}
Jiyong Parkf58c46e2021-04-01 21:35:20 +0900219 variables.Platform_vndk_version = proptools.StringPtr("29")
Paul Duffin37aad602021-03-08 09:47:16 +0000220 }),
221)
222
Paul Duffin52bfaa42021-03-23 23:40:12 +0000223var prepareForTestWithMyapex = android.FixtureMergeMockFs(android.MockFS{
224 "system/sepolicy/apex/myapex-file_contexts": nil,
225})
226
Jooyung Han643adc42020-02-27 13:50:06 +0900227// ensure that 'result' equals 'expected'
228func ensureEquals(t *testing.T, result string, expected string) {
229 t.Helper()
230 if result != expected {
231 t.Errorf("%q != %q", expected, result)
232 }
233}
234
Jiyong Park25fc6a92018-11-18 18:02:45 +0900235// ensure that 'result' contains 'expected'
236func ensureContains(t *testing.T, result string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900237 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900238 if !strings.Contains(result, expected) {
239 t.Errorf("%q is not found in %q", expected, result)
240 }
241}
242
Liz Kammer5bd365f2020-05-27 15:15:11 -0700243// ensure that 'result' contains 'expected' exactly one time
244func ensureContainsOnce(t *testing.T, result string, expected string) {
245 t.Helper()
246 count := strings.Count(result, expected)
247 if count != 1 {
248 t.Errorf("%q is found %d times (expected 1 time) in %q", expected, count, result)
249 }
250}
251
Jiyong Park25fc6a92018-11-18 18:02:45 +0900252// ensures that 'result' does not contain 'notExpected'
253func ensureNotContains(t *testing.T, result string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900254 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900255 if strings.Contains(result, notExpected) {
256 t.Errorf("%q is found in %q", notExpected, result)
257 }
258}
259
Sasha Smundak18d98bc2020-05-27 16:36:07 -0700260func ensureMatches(t *testing.T, result string, expectedRex string) {
261 ok, err := regexp.MatchString(expectedRex, result)
262 if err != nil {
263 t.Fatalf("regexp failure trying to match %s against `%s` expression: %s", result, expectedRex, err)
264 return
265 }
266 if !ok {
267 t.Errorf("%s does not match regular expession %s", result, expectedRex)
268 }
269}
270
Jiyong Park25fc6a92018-11-18 18:02:45 +0900271func ensureListContains(t *testing.T, result []string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900272 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900273 if !android.InList(expected, result) {
274 t.Errorf("%q is not found in %v", expected, result)
275 }
276}
277
278func ensureListNotContains(t *testing.T, result []string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900279 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900280 if android.InList(notExpected, result) {
281 t.Errorf("%q is found in %v", notExpected, result)
282 }
283}
284
Jooyung Hane1633032019-08-01 17:41:43 +0900285func ensureListEmpty(t *testing.T, result []string) {
286 t.Helper()
287 if len(result) > 0 {
288 t.Errorf("%q is expected to be empty", result)
289 }
290}
291
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +0000292func ensureListNotEmpty(t *testing.T, result []string) {
293 t.Helper()
294 if len(result) == 0 {
295 t.Errorf("%q is expected to be not empty", result)
296 }
297}
298
Jiyong Park25fc6a92018-11-18 18:02:45 +0900299// Minimal test
300func TestBasicApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800301 ctx := testApex(t, `
Jiyong Park30ca9372019-02-07 16:27:23 +0900302 apex_defaults {
303 name: "myapex-defaults",
Jiyong Park809bb722019-02-13 21:33:49 +0900304 manifest: ":myapex.manifest",
305 androidManifest: ":myapex.androidmanifest",
Jiyong Park25fc6a92018-11-18 18:02:45 +0900306 key: "myapex.key",
Jiyong Park99644e92020-11-17 22:21:02 +0900307 binaries: ["foo.rust"],
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900308 native_shared_libs: [
309 "mylib",
310 "libfoo.ffi",
311 ],
Jiyong Park99644e92020-11-17 22:21:02 +0900312 rust_dyn_libs: ["libfoo.dylib.rust"],
Alex Light3d673592019-01-18 14:37:31 -0800313 multilib: {
314 both: {
Jiyong Park99644e92020-11-17 22:21:02 +0900315 binaries: ["foo"],
Alex Light3d673592019-01-18 14:37:31 -0800316 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900317 },
Jiyong Park77acec62020-06-01 21:39:15 +0900318 java_libs: [
319 "myjar",
320 "myjar_dex",
321 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000322 updatable: false,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900323 }
324
Jiyong Park30ca9372019-02-07 16:27:23 +0900325 apex {
326 name: "myapex",
327 defaults: ["myapex-defaults"],
328 }
329
Jiyong Park25fc6a92018-11-18 18:02:45 +0900330 apex_key {
331 name: "myapex.key",
332 public_key: "testkey.avbpubkey",
333 private_key: "testkey.pem",
334 }
335
Jiyong Park809bb722019-02-13 21:33:49 +0900336 filegroup {
337 name: "myapex.manifest",
338 srcs: ["apex_manifest.json"],
339 }
340
341 filegroup {
342 name: "myapex.androidmanifest",
343 srcs: ["AndroidManifest.xml"],
344 }
345
Jiyong Park25fc6a92018-11-18 18:02:45 +0900346 cc_library {
347 name: "mylib",
348 srcs: ["mylib.cpp"],
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900349 shared_libs: [
350 "mylib2",
351 "libbar.ffi",
352 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900353 system_shared_libs: [],
354 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000355 // TODO: remove //apex_available:platform
356 apex_available: [
357 "//apex_available:platform",
358 "myapex",
359 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900360 }
361
Alex Light3d673592019-01-18 14:37:31 -0800362 cc_binary {
363 name: "foo",
364 srcs: ["mylib.cpp"],
365 compile_multilib: "both",
366 multilib: {
367 lib32: {
368 suffix: "32",
369 },
370 lib64: {
371 suffix: "64",
372 },
373 },
374 symlinks: ["foo_link_"],
375 symlink_preferred_arch: true,
376 system_shared_libs: [],
377 static_executable: true,
378 stl: "none",
Yifan Hongd22a84a2020-07-28 17:37:46 -0700379 apex_available: [ "myapex", "com.android.gki.*" ],
380 }
381
Jiyong Park99644e92020-11-17 22:21:02 +0900382 rust_binary {
Artur Satayev533b98c2021-03-11 18:03:42 +0000383 name: "foo.rust",
Jiyong Park99644e92020-11-17 22:21:02 +0900384 srcs: ["foo.rs"],
385 rlibs: ["libfoo.rlib.rust"],
386 dylibs: ["libfoo.dylib.rust"],
387 apex_available: ["myapex"],
388 }
389
390 rust_library_rlib {
Artur Satayev533b98c2021-03-11 18:03:42 +0000391 name: "libfoo.rlib.rust",
Jiyong Park99644e92020-11-17 22:21:02 +0900392 srcs: ["foo.rs"],
393 crate_name: "foo",
394 apex_available: ["myapex"],
Jiyong Park94e22fd2021-04-08 18:19:15 +0900395 shared_libs: ["libfoo.shared_from_rust"],
396 }
397
398 cc_library_shared {
399 name: "libfoo.shared_from_rust",
400 srcs: ["mylib.cpp"],
401 system_shared_libs: [],
402 stl: "none",
403 apex_available: ["myapex"],
Jiyong Park99644e92020-11-17 22:21:02 +0900404 }
405
406 rust_library_dylib {
Artur Satayev533b98c2021-03-11 18:03:42 +0000407 name: "libfoo.dylib.rust",
Jiyong Park99644e92020-11-17 22:21:02 +0900408 srcs: ["foo.rs"],
409 crate_name: "foo",
410 apex_available: ["myapex"],
411 }
412
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900413 rust_ffi_shared {
414 name: "libfoo.ffi",
415 srcs: ["foo.rs"],
416 crate_name: "foo",
417 apex_available: ["myapex"],
418 }
419
420 rust_ffi_shared {
421 name: "libbar.ffi",
422 srcs: ["foo.rs"],
423 crate_name: "bar",
424 apex_available: ["myapex"],
425 }
426
Yifan Hongd22a84a2020-07-28 17:37:46 -0700427 apex {
428 name: "com.android.gki.fake",
429 binaries: ["foo"],
430 key: "myapex.key",
431 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000432 updatable: false,
Alex Light3d673592019-01-18 14:37:31 -0800433 }
434
Paul Duffindddd5462020-04-07 15:25:44 +0100435 cc_library_shared {
Jiyong Park25fc6a92018-11-18 18:02:45 +0900436 name: "mylib2",
437 srcs: ["mylib.cpp"],
438 system_shared_libs: [],
439 stl: "none",
Jiyong Park52818fc2019-03-18 12:01:38 +0900440 notice: "custom_notice",
Jiyong Park9918e1a2020-03-17 19:16:40 +0900441 static_libs: ["libstatic"],
442 // TODO: remove //apex_available:platform
443 apex_available: [
444 "//apex_available:platform",
445 "myapex",
446 ],
447 }
448
Paul Duffindddd5462020-04-07 15:25:44 +0100449 cc_prebuilt_library_shared {
450 name: "mylib2",
451 srcs: ["prebuilt.so"],
452 // TODO: remove //apex_available:platform
453 apex_available: [
454 "//apex_available:platform",
455 "myapex",
456 ],
457 }
458
Jiyong Park9918e1a2020-03-17 19:16:40 +0900459 cc_library_static {
460 name: "libstatic",
461 srcs: ["mylib.cpp"],
462 system_shared_libs: [],
463 stl: "none",
464 notice: "custom_notice_for_static_lib",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000465 // TODO: remove //apex_available:platform
466 apex_available: [
467 "//apex_available:platform",
468 "myapex",
469 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900470 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900471
472 java_library {
473 name: "myjar",
474 srcs: ["foo/bar/MyClass.java"],
Jiyong Parka62aa232020-05-28 23:46:55 +0900475 stem: "myjar_stem",
Jiyong Park7f7766d2019-07-25 22:02:35 +0900476 sdk_version: "none",
477 system_modules: "none",
Jiyong Park7f7766d2019-07-25 22:02:35 +0900478 static_libs: ["myotherjar"],
Jiyong Park3ff16992019-12-27 14:11:47 +0900479 libs: ["mysharedjar"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000480 // TODO: remove //apex_available:platform
481 apex_available: [
482 "//apex_available:platform",
483 "myapex",
484 ],
Jiyong Park7f7766d2019-07-25 22:02:35 +0900485 }
486
Jiyong Park77acec62020-06-01 21:39:15 +0900487 dex_import {
488 name: "myjar_dex",
489 jars: ["prebuilt.jar"],
490 apex_available: [
491 "//apex_available:platform",
492 "myapex",
493 ],
494 }
495
Jiyong Park7f7766d2019-07-25 22:02:35 +0900496 java_library {
497 name: "myotherjar",
498 srcs: ["foo/bar/MyClass.java"],
499 sdk_version: "none",
500 system_modules: "none",
Jiyong Park0f80c182020-01-31 02:49:53 +0900501 // TODO: remove //apex_available:platform
502 apex_available: [
503 "//apex_available:platform",
504 "myapex",
505 ],
Jiyong Park7f7766d2019-07-25 22:02:35 +0900506 }
Jiyong Park3ff16992019-12-27 14:11:47 +0900507
508 java_library {
509 name: "mysharedjar",
510 srcs: ["foo/bar/MyClass.java"],
511 sdk_version: "none",
512 system_modules: "none",
Jiyong Park3ff16992019-12-27 14:11:47 +0900513 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900514 `)
515
Paul Duffina71a67a2021-03-29 00:42:57 +0100516 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900517
Jiyong Park9e83f0b2020-06-11 00:35:03 +0900518 // Make sure that Android.mk is created
519 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -0700520 data := android.AndroidMkDataForTest(t, ctx, ab)
Jiyong Park9e83f0b2020-06-11 00:35:03 +0900521 var builder strings.Builder
522 data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
523
524 androidMk := builder.String()
525 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
526 ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
527
Jiyong Park42cca6c2019-04-01 11:15:50 +0900528 optFlags := apexRule.Args["opt_flags"]
529 ensureContains(t, optFlags, "--pubkey vendor/foo/devkeys/testkey.avbpubkey")
Jaewoong Jung14f5ff62019-06-18 13:09:13 -0700530 // Ensure that the NOTICE output is being packaged as an asset.
Paul Duffin37ba3442021-03-29 00:21:08 +0100531 ensureContains(t, optFlags, "--assets_dir out/soong/.intermediates/myapex/android_common_myapex_image/NOTICE")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900532
Jiyong Park25fc6a92018-11-18 18:02:45 +0900533 copyCmds := apexRule.Args["copy_commands"]
534
535 // Ensure that main rule creates an output
536 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
537
538 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -0700539 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
540 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common_apex10000")
541 ensureListContains(t, ctx.ModuleVariantsForTests("myjar_dex"), "android_common_apex10000")
Jiyong Park99644e92020-11-17 22:21:02 +0900542 ensureListContains(t, ctx.ModuleVariantsForTests("foo.rust"), "android_arm64_armv8-a_apex10000")
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900543 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.ffi"), "android_arm64_armv8-a_shared_apex10000")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900544
545 // Ensure that apex variant is created for the indirect dep
Colin Crossaede88c2020-08-11 12:17:01 -0700546 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
547 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common_apex10000")
Jiyong Park99644e92020-11-17 22:21:02 +0900548 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.rlib.rust"), "android_arm64_armv8-a_rlib_dylib-std_apex10000")
549 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.dylib.rust"), "android_arm64_armv8-a_dylib_apex10000")
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900550 ensureListContains(t, ctx.ModuleVariantsForTests("libbar.ffi"), "android_arm64_armv8-a_shared_apex10000")
Jiyong Park94e22fd2021-04-08 18:19:15 +0900551 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.shared_from_rust"), "android_arm64_armv8-a_shared_apex10000")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900552
553 // Ensure that both direct and indirect deps are copied into apex
Alex Light5098a612018-11-29 17:12:15 -0800554 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
555 ensureContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Parka62aa232020-05-28 23:46:55 +0900556 ensureContains(t, copyCmds, "image.apex/javalib/myjar_stem.jar")
Jiyong Park77acec62020-06-01 21:39:15 +0900557 ensureContains(t, copyCmds, "image.apex/javalib/myjar_dex.jar")
Jiyong Park99644e92020-11-17 22:21:02 +0900558 ensureContains(t, copyCmds, "image.apex/lib64/libfoo.dylib.rust.dylib.so")
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900559 ensureContains(t, copyCmds, "image.apex/lib64/libfoo.ffi.so")
560 ensureContains(t, copyCmds, "image.apex/lib64/libbar.ffi.so")
Jiyong Park94e22fd2021-04-08 18:19:15 +0900561 ensureContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900562 // .. but not for java libs
563 ensureNotContains(t, copyCmds, "image.apex/javalib/myotherjar.jar")
Jiyong Park3ff16992019-12-27 14:11:47 +0900564 ensureNotContains(t, copyCmds, "image.apex/javalib/msharedjar.jar")
Logan Chien3aeedc92018-12-26 15:32:21 +0800565
Colin Cross7113d202019-11-20 16:39:12 -0800566 // Ensure that the platform variant ends with _shared or _common
567 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
568 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900569 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common")
570 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common")
Jiyong Park3ff16992019-12-27 14:11:47 +0900571 ensureListContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common")
572
573 // Ensure that dynamic dependency to java libs are not included
574 ensureListNotContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common_myapex")
Alex Light3d673592019-01-18 14:37:31 -0800575
576 // Ensure that all symlinks are present.
577 found_foo_link_64 := false
578 found_foo := false
579 for _, cmd := range strings.Split(copyCmds, " && ") {
Jiyong Park7cd10e32020-01-14 09:22:18 +0900580 if strings.HasPrefix(cmd, "ln -sfn foo64") {
Alex Light3d673592019-01-18 14:37:31 -0800581 if strings.HasSuffix(cmd, "bin/foo") {
582 found_foo = true
583 } else if strings.HasSuffix(cmd, "bin/foo_link_64") {
584 found_foo_link_64 = true
585 }
586 }
587 }
588 good := found_foo && found_foo_link_64
589 if !good {
590 t.Errorf("Could not find all expected symlinks! foo: %t, foo_link_64: %t. Command was %s", found_foo, found_foo_link_64, copyCmds)
591 }
Jiyong Park52818fc2019-03-18 12:01:38 +0900592
Sundong Ahnabb64432019-10-22 13:58:29 +0900593 mergeNoticesRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("mergeNoticesRule")
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700594 noticeInputs := mergeNoticesRule.Inputs.Strings()
Jiyong Park9918e1a2020-03-17 19:16:40 +0900595 if len(noticeInputs) != 3 {
596 t.Errorf("number of input notice files: expected = 3, actual = %q", len(noticeInputs))
Jiyong Park52818fc2019-03-18 12:01:38 +0900597 }
598 ensureListContains(t, noticeInputs, "NOTICE")
599 ensureListContains(t, noticeInputs, "custom_notice")
Jiyong Park9918e1a2020-03-17 19:16:40 +0900600 ensureListContains(t, noticeInputs, "custom_notice_for_static_lib")
Jiyong Park83dc74b2020-01-14 18:38:44 +0900601
Artur Satayeva8bd1132020-04-27 18:07:06 +0100602 fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100603 ensureListContains(t, fullDepsInfo, " myjar(minSdkVersion:(no version)) <- myapex")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100604 ensureListContains(t, fullDepsInfo, " mylib2(minSdkVersion:(no version)) <- mylib")
605 ensureListContains(t, fullDepsInfo, " myotherjar(minSdkVersion:(no version)) <- myjar")
606 ensureListContains(t, fullDepsInfo, " mysharedjar(minSdkVersion:(no version)) (external) <- myjar")
Artur Satayeva8bd1132020-04-27 18:07:06 +0100607
608 flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100609 ensureListContains(t, flatDepsInfo, "myjar(minSdkVersion:(no version))")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100610 ensureListContains(t, flatDepsInfo, "mylib2(minSdkVersion:(no version))")
611 ensureListContains(t, flatDepsInfo, "myotherjar(minSdkVersion:(no version))")
612 ensureListContains(t, flatDepsInfo, "mysharedjar(minSdkVersion:(no version)) (external)")
Alex Light5098a612018-11-29 17:12:15 -0800613}
614
Jooyung Hanf21c7972019-12-16 22:32:06 +0900615func TestDefaults(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800616 ctx := testApex(t, `
Jooyung Hanf21c7972019-12-16 22:32:06 +0900617 apex_defaults {
618 name: "myapex-defaults",
619 key: "myapex.key",
620 prebuilts: ["myetc"],
621 native_shared_libs: ["mylib"],
622 java_libs: ["myjar"],
623 apps: ["AppFoo"],
Jiyong Park69aeba92020-04-24 21:16:36 +0900624 rros: ["rro"],
markchien2f59ec92020-09-02 16:23:38 +0800625 bpfs: ["bpf"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000626 updatable: false,
Jooyung Hanf21c7972019-12-16 22:32:06 +0900627 }
628
629 prebuilt_etc {
630 name: "myetc",
631 src: "myprebuilt",
632 }
633
634 apex {
635 name: "myapex",
636 defaults: ["myapex-defaults"],
637 }
638
639 apex_key {
640 name: "myapex.key",
641 public_key: "testkey.avbpubkey",
642 private_key: "testkey.pem",
643 }
644
645 cc_library {
646 name: "mylib",
647 system_shared_libs: [],
648 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000649 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900650 }
651
652 java_library {
653 name: "myjar",
654 srcs: ["foo/bar/MyClass.java"],
655 sdk_version: "none",
656 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000657 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900658 }
659
660 android_app {
661 name: "AppFoo",
662 srcs: ["foo/bar/MyClass.java"],
663 sdk_version: "none",
664 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000665 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900666 }
Jiyong Park69aeba92020-04-24 21:16:36 +0900667
668 runtime_resource_overlay {
669 name: "rro",
670 theme: "blue",
671 }
672
markchien2f59ec92020-09-02 16:23:38 +0800673 bpf {
674 name: "bpf",
675 srcs: ["bpf.c", "bpf2.c"],
676 }
677
Jooyung Hanf21c7972019-12-16 22:32:06 +0900678 `)
Jooyung Hana57af4a2020-01-23 05:36:59 +0000679 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Hanf21c7972019-12-16 22:32:06 +0900680 "etc/myetc",
681 "javalib/myjar.jar",
682 "lib64/mylib.so",
683 "app/AppFoo/AppFoo.apk",
Jiyong Park69aeba92020-04-24 21:16:36 +0900684 "overlay/blue/rro.apk",
markchien2f59ec92020-09-02 16:23:38 +0800685 "etc/bpf/bpf.o",
686 "etc/bpf/bpf2.o",
Jooyung Hanf21c7972019-12-16 22:32:06 +0900687 })
688}
689
Jooyung Han01a3ee22019-11-02 02:52:25 +0900690func TestApexManifest(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800691 ctx := testApex(t, `
Jooyung Han01a3ee22019-11-02 02:52:25 +0900692 apex {
693 name: "myapex",
694 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000695 updatable: false,
Jooyung Han01a3ee22019-11-02 02:52:25 +0900696 }
697
698 apex_key {
699 name: "myapex.key",
700 public_key: "testkey.avbpubkey",
701 private_key: "testkey.pem",
702 }
703 `)
704
705 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Han214bf372019-11-12 13:03:50 +0900706 args := module.Rule("apexRule").Args
707 if manifest := args["manifest"]; manifest != module.Output("apex_manifest.pb").Output.String() {
708 t.Error("manifest should be apex_manifest.pb, but " + manifest)
709 }
Jooyung Han01a3ee22019-11-02 02:52:25 +0900710}
711
Liz Kammer4854a7d2021-05-27 14:28:27 -0400712func TestApexManifestMinSdkVersion(t *testing.T) {
713 ctx := testApex(t, `
714 apex_defaults {
715 name: "my_defaults",
716 key: "myapex.key",
717 product_specific: true,
718 file_contexts: ":my-file-contexts",
719 updatable: false,
720 }
721 apex {
722 name: "myapex_30",
723 min_sdk_version: "30",
724 defaults: ["my_defaults"],
725 }
726
727 apex {
728 name: "myapex_current",
729 min_sdk_version: "current",
730 defaults: ["my_defaults"],
731 }
732
733 apex {
734 name: "myapex_none",
735 defaults: ["my_defaults"],
736 }
737
738 apex_key {
739 name: "myapex.key",
740 public_key: "testkey.avbpubkey",
741 private_key: "testkey.pem",
742 }
743
744 filegroup {
745 name: "my-file-contexts",
746 srcs: ["product_specific_file_contexts"],
747 }
748 `, withFiles(map[string][]byte{
749 "product_specific_file_contexts": nil,
750 }), android.FixtureModifyProductVariables(
751 func(variables android.FixtureProductVariables) {
752 variables.Unbundled_build = proptools.BoolPtr(true)
753 variables.Always_use_prebuilt_sdks = proptools.BoolPtr(false)
754 }), android.FixtureMergeEnv(map[string]string{
755 "UNBUNDLED_BUILD_TARGET_SDK_WITH_API_FINGERPRINT": "true",
756 }))
757
758 testCases := []struct {
759 module string
760 minSdkVersion string
761 }{
762 {
763 module: "myapex_30",
764 minSdkVersion: "30",
765 },
766 {
767 module: "myapex_current",
768 minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
769 },
770 {
771 module: "myapex_none",
772 minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
773 },
774 }
775 for _, tc := range testCases {
776 module := ctx.ModuleForTests(tc.module, "android_common_"+tc.module+"_image")
777 args := module.Rule("apexRule").Args
778 optFlags := args["opt_flags"]
779 if !strings.Contains(optFlags, "--min_sdk_version "+tc.minSdkVersion) {
780 t.Errorf("%s: Expected min_sdk_version=%s, got: %s", tc.module, tc.minSdkVersion, optFlags)
781 }
782 }
783}
784
Alex Light5098a612018-11-29 17:12:15 -0800785func TestBasicZipApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800786 ctx := testApex(t, `
Alex Light5098a612018-11-29 17:12:15 -0800787 apex {
788 name: "myapex",
789 key: "myapex.key",
790 payload_type: "zip",
791 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000792 updatable: false,
Alex Light5098a612018-11-29 17:12:15 -0800793 }
794
795 apex_key {
796 name: "myapex.key",
797 public_key: "testkey.avbpubkey",
798 private_key: "testkey.pem",
799 }
800
801 cc_library {
802 name: "mylib",
803 srcs: ["mylib.cpp"],
804 shared_libs: ["mylib2"],
805 system_shared_libs: [],
806 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000807 apex_available: [ "myapex" ],
Alex Light5098a612018-11-29 17:12:15 -0800808 }
809
810 cc_library {
811 name: "mylib2",
812 srcs: ["mylib.cpp"],
813 system_shared_libs: [],
814 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000815 apex_available: [ "myapex" ],
Alex Light5098a612018-11-29 17:12:15 -0800816 }
817 `)
818
Sundong Ahnabb64432019-10-22 13:58:29 +0900819 zipApexRule := ctx.ModuleForTests("myapex", "android_common_myapex_zip").Rule("zipApexRule")
Alex Light5098a612018-11-29 17:12:15 -0800820 copyCmds := zipApexRule.Args["copy_commands"]
821
822 // Ensure that main rule creates an output
823 ensureContains(t, zipApexRule.Output.String(), "myapex.zipapex.unsigned")
824
825 // Ensure that APEX variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -0700826 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
Alex Light5098a612018-11-29 17:12:15 -0800827
828 // Ensure that APEX variant is created for the indirect dep
Colin Crossaede88c2020-08-11 12:17:01 -0700829 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
Alex Light5098a612018-11-29 17:12:15 -0800830
831 // Ensure that both direct and indirect deps are copied into apex
832 ensureContains(t, copyCmds, "image.zipapex/lib64/mylib.so")
833 ensureContains(t, copyCmds, "image.zipapex/lib64/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900834}
835
836func TestApexWithStubs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800837 ctx := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +0900838 apex {
839 name: "myapex",
840 key: "myapex.key",
841 native_shared_libs: ["mylib", "mylib3"],
Jiyong Park105dc322021-06-11 17:22:09 +0900842 binaries: ["foo.rust"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000843 updatable: false,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900844 }
845
846 apex_key {
847 name: "myapex.key",
848 public_key: "testkey.avbpubkey",
849 private_key: "testkey.pem",
850 }
851
852 cc_library {
853 name: "mylib",
854 srcs: ["mylib.cpp"],
855 shared_libs: ["mylib2", "mylib3"],
856 system_shared_libs: [],
857 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000858 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900859 }
860
861 cc_library {
862 name: "mylib2",
863 srcs: ["mylib.cpp"],
Jiyong Park64379952018-12-13 18:37:29 +0900864 cflags: ["-include mylib.h"],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900865 system_shared_libs: [],
866 stl: "none",
867 stubs: {
868 versions: ["1", "2", "3"],
869 },
870 }
871
872 cc_library {
873 name: "mylib3",
Jiyong Park28d395a2018-12-07 22:42:47 +0900874 srcs: ["mylib.cpp"],
875 shared_libs: ["mylib4"],
876 system_shared_libs: [],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900877 stl: "none",
878 stubs: {
879 versions: ["10", "11", "12"],
880 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000881 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900882 }
Jiyong Park28d395a2018-12-07 22:42:47 +0900883
884 cc_library {
885 name: "mylib4",
886 srcs: ["mylib.cpp"],
887 system_shared_libs: [],
888 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000889 apex_available: [ "myapex" ],
Jiyong Park28d395a2018-12-07 22:42:47 +0900890 }
Jiyong Park105dc322021-06-11 17:22:09 +0900891
892 rust_binary {
893 name: "foo.rust",
894 srcs: ["foo.rs"],
895 shared_libs: ["libfoo.shared_from_rust"],
896 prefer_rlib: true,
897 apex_available: ["myapex"],
898 }
899
900 cc_library_shared {
901 name: "libfoo.shared_from_rust",
902 srcs: ["mylib.cpp"],
903 system_shared_libs: [],
904 stl: "none",
905 stubs: {
906 versions: ["10", "11", "12"],
907 },
908 }
909
Jiyong Park25fc6a92018-11-18 18:02:45 +0900910 `)
911
Sundong Ahnabb64432019-10-22 13:58:29 +0900912 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900913 copyCmds := apexRule.Args["copy_commands"]
914
915 // Ensure that direct non-stubs dep is always included
Alex Light5098a612018-11-29 17:12:15 -0800916 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900917
918 // Ensure that indirect stubs dep is not included
Alex Light5098a612018-11-29 17:12:15 -0800919 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900920
921 // Ensure that direct stubs dep is included
Alex Light5098a612018-11-29 17:12:15 -0800922 ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900923
Colin Crossaede88c2020-08-11 12:17:01 -0700924 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +0900925
926 // Ensure that mylib is linking with the latest version of stubs for mylib2
Jiyong Parkd4a3a132021-03-17 20:21:35 +0900927 ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900928 // ... and not linking to the non-stub (impl) variant of mylib2
Jiyong Park3ff16992019-12-27 14:11:47 +0900929 ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900930
931 // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
Colin Crossaede88c2020-08-11 12:17:01 -0700932 ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex10000/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900933 // .. and not linking to the stubs variant of mylib3
Colin Crossaede88c2020-08-11 12:17:01 -0700934 ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_12/mylib3.so")
Jiyong Park64379952018-12-13 18:37:29 +0900935
936 // Ensure that stubs libs are built without -include flags
Jiyong Park0f80c182020-01-31 02:49:53 +0900937 mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jiyong Park64379952018-12-13 18:37:29 +0900938 ensureNotContains(t, mylib2Cflags, "-include ")
Jiyong Park3fd0baf2018-12-07 16:25:39 +0900939
940 // Ensure that genstub is invoked with --apex
Colin Crossa717db72020-10-23 14:53:06 -0700941 ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_3").Rule("genStubSrc").Args["flags"])
Jooyung Han671f1ce2019-12-17 12:47:13 +0900942
Jooyung Hana57af4a2020-01-23 05:36:59 +0000943 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Han671f1ce2019-12-17 12:47:13 +0900944 "lib64/mylib.so",
945 "lib64/mylib3.so",
946 "lib64/mylib4.so",
Jiyong Park105dc322021-06-11 17:22:09 +0900947 "bin/foo.rust",
948 "lib64/libc++.so", // by the implicit dependency from foo.rust
949 "lib64/liblog.so", // by the implicit dependency from foo.rust
Jooyung Han671f1ce2019-12-17 12:47:13 +0900950 })
Jiyong Park105dc322021-06-11 17:22:09 +0900951
952 // Ensure that stub dependency from a rust module is not included
953 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
954 // The rust module is linked to the stub cc library
955 rustDeps := ctx.ModuleForTests("foo.rust", "android_arm64_armv8-a_apex10000").Rule("rustc").Args["linkFlags"]
956 ensureContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared_current/libfoo.shared_from_rust.so")
957 ensureNotContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared/libfoo.shared_from_rust.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900958}
959
Colin Cross7812fd32020-09-25 12:35:10 -0700960func TestApexWithStubsWithMinSdkVersion(t *testing.T) {
961 t.Parallel()
Colin Cross1c460562021-02-16 17:55:47 -0800962 ctx := testApex(t, `
Colin Cross7812fd32020-09-25 12:35:10 -0700963 apex {
964 name: "myapex",
965 key: "myapex.key",
966 native_shared_libs: ["mylib", "mylib3"],
967 min_sdk_version: "29",
968 }
969
970 apex_key {
971 name: "myapex.key",
972 public_key: "testkey.avbpubkey",
973 private_key: "testkey.pem",
974 }
975
976 cc_library {
977 name: "mylib",
978 srcs: ["mylib.cpp"],
979 shared_libs: ["mylib2", "mylib3"],
980 system_shared_libs: [],
981 stl: "none",
982 apex_available: [ "myapex" ],
983 min_sdk_version: "28",
984 }
985
986 cc_library {
987 name: "mylib2",
988 srcs: ["mylib.cpp"],
989 cflags: ["-include mylib.h"],
990 system_shared_libs: [],
991 stl: "none",
992 stubs: {
993 versions: ["28", "29", "30", "current"],
994 },
995 min_sdk_version: "28",
996 }
997
998 cc_library {
999 name: "mylib3",
1000 srcs: ["mylib.cpp"],
1001 shared_libs: ["mylib4"],
1002 system_shared_libs: [],
1003 stl: "none",
1004 stubs: {
1005 versions: ["28", "29", "30", "current"],
1006 },
1007 apex_available: [ "myapex" ],
1008 min_sdk_version: "28",
1009 }
1010
1011 cc_library {
1012 name: "mylib4",
1013 srcs: ["mylib.cpp"],
1014 system_shared_libs: [],
1015 stl: "none",
1016 apex_available: [ "myapex" ],
1017 min_sdk_version: "28",
1018 }
1019 `)
1020
1021 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
1022 copyCmds := apexRule.Args["copy_commands"]
1023
1024 // Ensure that direct non-stubs dep is always included
1025 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
1026
1027 // Ensure that indirect stubs dep is not included
1028 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
1029
1030 // Ensure that direct stubs dep is included
1031 ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
1032
1033 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex29").Rule("ld").Args["libFlags"]
1034
Jiyong Park55549df2021-02-26 23:57:23 +09001035 // Ensure that mylib is linking with the latest version of stub for mylib2
1036 ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
Colin Cross7812fd32020-09-25 12:35:10 -07001037 // ... and not linking to the non-stub (impl) variant of mylib2
1038 ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
1039
1040 // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
1041 ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex29/mylib3.so")
1042 // .. and not linking to the stubs variant of mylib3
1043 ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_29/mylib3.so")
1044
1045 // Ensure that stubs libs are built without -include flags
Colin Crossa717db72020-10-23 14:53:06 -07001046 mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("cc").Args["cFlags"]
Colin Cross7812fd32020-09-25 12:35:10 -07001047 ensureNotContains(t, mylib2Cflags, "-include ")
1048
1049 // Ensure that genstub is invoked with --apex
Colin Crossa717db72020-10-23 14:53:06 -07001050 ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("genStubSrc").Args["flags"])
Colin Cross7812fd32020-09-25 12:35:10 -07001051
1052 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
1053 "lib64/mylib.so",
1054 "lib64/mylib3.so",
1055 "lib64/mylib4.so",
1056 })
1057}
1058
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001059func TestApex_PlatformUsesLatestStubFromApex(t *testing.T) {
1060 t.Parallel()
1061 // myapex (Z)
1062 // mylib -----------------.
1063 // |
1064 // otherapex (29) |
1065 // libstub's versions: 29 Z current
1066 // |
1067 // <platform> |
1068 // libplatform ----------------'
Colin Cross1c460562021-02-16 17:55:47 -08001069 ctx := testApex(t, `
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001070 apex {
1071 name: "myapex",
1072 key: "myapex.key",
1073 native_shared_libs: ["mylib"],
1074 min_sdk_version: "Z", // non-final
1075 }
1076
1077 cc_library {
1078 name: "mylib",
1079 srcs: ["mylib.cpp"],
1080 shared_libs: ["libstub"],
1081 apex_available: ["myapex"],
1082 min_sdk_version: "Z",
1083 }
1084
1085 apex_key {
1086 name: "myapex.key",
1087 public_key: "testkey.avbpubkey",
1088 private_key: "testkey.pem",
1089 }
1090
1091 apex {
1092 name: "otherapex",
1093 key: "myapex.key",
1094 native_shared_libs: ["libstub"],
1095 min_sdk_version: "29",
1096 }
1097
1098 cc_library {
1099 name: "libstub",
1100 srcs: ["mylib.cpp"],
1101 stubs: {
1102 versions: ["29", "Z", "current"],
1103 },
1104 apex_available: ["otherapex"],
1105 min_sdk_version: "29",
1106 }
1107
1108 // platform module depending on libstub from otherapex should use the latest stub("current")
1109 cc_library {
1110 name: "libplatform",
1111 srcs: ["mylib.cpp"],
1112 shared_libs: ["libstub"],
1113 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001114 `,
1115 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1116 variables.Platform_sdk_codename = proptools.StringPtr("Z")
1117 variables.Platform_sdk_final = proptools.BoolPtr(false)
1118 variables.Platform_version_active_codenames = []string{"Z"}
1119 }),
1120 )
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001121
Jiyong Park55549df2021-02-26 23:57:23 +09001122 // Ensure that mylib from myapex is built against the latest stub (current)
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001123 mylibCflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
Jiyong Park55549df2021-02-26 23:57:23 +09001124 ensureContains(t, mylibCflags, "-D__LIBSTUB_API__=10000 ")
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001125 mylibLdflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
Jiyong Park55549df2021-02-26 23:57:23 +09001126 ensureContains(t, mylibLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001127
1128 // Ensure that libplatform is built against latest stub ("current") of mylib3 from the apex
1129 libplatformCflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
1130 ensureContains(t, libplatformCflags, "-D__LIBSTUB_API__=10000 ") // "current" maps to 10000
1131 libplatformLdflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
1132 ensureContains(t, libplatformLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
1133}
1134
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001135func TestApexWithExplicitStubsDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001136 ctx := testApex(t, `
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001137 apex {
Jiyong Park83dc74b2020-01-14 18:38:44 +09001138 name: "myapex2",
1139 key: "myapex2.key",
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001140 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001141 updatable: false,
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001142 }
1143
1144 apex_key {
Jiyong Park83dc74b2020-01-14 18:38:44 +09001145 name: "myapex2.key",
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001146 public_key: "testkey.avbpubkey",
1147 private_key: "testkey.pem",
1148 }
1149
1150 cc_library {
1151 name: "mylib",
1152 srcs: ["mylib.cpp"],
1153 shared_libs: ["libfoo#10"],
Jiyong Park678c8812020-02-07 17:25:49 +09001154 static_libs: ["libbaz"],
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001155 system_shared_libs: [],
1156 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001157 apex_available: [ "myapex2" ],
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001158 }
1159
1160 cc_library {
1161 name: "libfoo",
1162 srcs: ["mylib.cpp"],
1163 shared_libs: ["libbar"],
1164 system_shared_libs: [],
1165 stl: "none",
1166 stubs: {
1167 versions: ["10", "20", "30"],
1168 },
1169 }
1170
1171 cc_library {
1172 name: "libbar",
1173 srcs: ["mylib.cpp"],
1174 system_shared_libs: [],
1175 stl: "none",
1176 }
1177
Jiyong Park678c8812020-02-07 17:25:49 +09001178 cc_library_static {
1179 name: "libbaz",
1180 srcs: ["mylib.cpp"],
1181 system_shared_libs: [],
1182 stl: "none",
1183 apex_available: [ "myapex2" ],
1184 }
1185
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001186 `)
1187
Jiyong Park83dc74b2020-01-14 18:38:44 +09001188 apexRule := ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Rule("apexRule")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001189 copyCmds := apexRule.Args["copy_commands"]
1190
1191 // Ensure that direct non-stubs dep is always included
1192 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
1193
1194 // Ensure that indirect stubs dep is not included
1195 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
1196
1197 // Ensure that dependency of stubs is not included
1198 ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so")
1199
Colin Crossaede88c2020-08-11 12:17:01 -07001200 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001201
1202 // Ensure that mylib is linking with version 10 of libfoo
Jiyong Park3ff16992019-12-27 14:11:47 +09001203 ensureContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared_10/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001204 // ... and not linking to the non-stub (impl) variant of libfoo
Jiyong Park3ff16992019-12-27 14:11:47 +09001205 ensureNotContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001206
Jiyong Park3ff16992019-12-27 14:11:47 +09001207 libFooStubsLdFlags := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_10").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001208
1209 // Ensure that libfoo stubs is not linking to libbar (since it is a stubs)
1210 ensureNotContains(t, libFooStubsLdFlags, "libbar.so")
Jiyong Park83dc74b2020-01-14 18:38:44 +09001211
Artur Satayeva8bd1132020-04-27 18:07:06 +01001212 fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +01001213 ensureListContains(t, fullDepsInfo, " libfoo(minSdkVersion:(no version)) (external) <- mylib")
Jiyong Park678c8812020-02-07 17:25:49 +09001214
Artur Satayeva8bd1132020-04-27 18:07:06 +01001215 flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +01001216 ensureListContains(t, flatDepsInfo, "libfoo(minSdkVersion:(no version)) (external)")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001217}
1218
Jooyung Hand3639552019-08-09 12:57:43 +09001219func TestApexWithRuntimeLibsDependency(t *testing.T) {
1220 /*
1221 myapex
1222 |
1223 v (runtime_libs)
1224 mylib ------+------> libfoo [provides stub]
1225 |
1226 `------> libbar
1227 */
Colin Cross1c460562021-02-16 17:55:47 -08001228 ctx := testApex(t, `
Jooyung Hand3639552019-08-09 12:57:43 +09001229 apex {
1230 name: "myapex",
1231 key: "myapex.key",
1232 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001233 updatable: false,
Jooyung Hand3639552019-08-09 12:57:43 +09001234 }
1235
1236 apex_key {
1237 name: "myapex.key",
1238 public_key: "testkey.avbpubkey",
1239 private_key: "testkey.pem",
1240 }
1241
1242 cc_library {
1243 name: "mylib",
1244 srcs: ["mylib.cpp"],
1245 runtime_libs: ["libfoo", "libbar"],
1246 system_shared_libs: [],
1247 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001248 apex_available: [ "myapex" ],
Jooyung Hand3639552019-08-09 12:57:43 +09001249 }
1250
1251 cc_library {
1252 name: "libfoo",
1253 srcs: ["mylib.cpp"],
1254 system_shared_libs: [],
1255 stl: "none",
1256 stubs: {
1257 versions: ["10", "20", "30"],
1258 },
1259 }
1260
1261 cc_library {
1262 name: "libbar",
1263 srcs: ["mylib.cpp"],
1264 system_shared_libs: [],
1265 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001266 apex_available: [ "myapex" ],
Jooyung Hand3639552019-08-09 12:57:43 +09001267 }
1268
1269 `)
1270
Sundong Ahnabb64432019-10-22 13:58:29 +09001271 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jooyung Hand3639552019-08-09 12:57:43 +09001272 copyCmds := apexRule.Args["copy_commands"]
1273
1274 // Ensure that direct non-stubs dep is always included
1275 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
1276
1277 // Ensure that indirect stubs dep is not included
1278 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
1279
1280 // Ensure that runtime_libs dep in included
1281 ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
1282
Sundong Ahnabb64432019-10-22 13:58:29 +09001283 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001284 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
1285 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.so")
Jooyung Hand3639552019-08-09 12:57:43 +09001286
1287}
1288
Paul Duffina02cae32021-03-09 01:44:06 +00001289var prepareForTestOfRuntimeApexWithHwasan = android.GroupFixturePreparers(
1290 cc.PrepareForTestWithCcBuildComponents,
1291 PrepareForTestWithApexBuildComponents,
1292 android.FixtureAddTextFile("bionic/apex/Android.bp", `
Jooyung Han8ce8db92020-05-15 19:05:05 +09001293 apex {
1294 name: "com.android.runtime",
1295 key: "com.android.runtime.key",
1296 native_shared_libs: ["libc"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001297 updatable: false,
Jooyung Han8ce8db92020-05-15 19:05:05 +09001298 }
1299
1300 apex_key {
1301 name: "com.android.runtime.key",
1302 public_key: "testkey.avbpubkey",
1303 private_key: "testkey.pem",
1304 }
Paul Duffina02cae32021-03-09 01:44:06 +00001305 `),
1306 android.FixtureAddFile("system/sepolicy/apex/com.android.runtime-file_contexts", nil),
1307)
Jooyung Han8ce8db92020-05-15 19:05:05 +09001308
Paul Duffina02cae32021-03-09 01:44:06 +00001309func TestRuntimeApexShouldInstallHwasanIfLibcDependsOnIt(t *testing.T) {
Paul Duffin70d3bee2021-03-21 11:26:05 +00001310 result := android.GroupFixturePreparers(prepareForTestOfRuntimeApexWithHwasan).RunTestWithBp(t, `
Jooyung Han8ce8db92020-05-15 19:05:05 +09001311 cc_library {
1312 name: "libc",
1313 no_libcrt: true,
1314 nocrt: true,
1315 stl: "none",
1316 system_shared_libs: [],
1317 stubs: { versions: ["1"] },
1318 apex_available: ["com.android.runtime"],
1319
1320 sanitize: {
1321 hwaddress: true,
1322 }
1323 }
1324
1325 cc_prebuilt_library_shared {
1326 name: "libclang_rt.hwasan-aarch64-android",
1327 no_libcrt: true,
1328 nocrt: true,
1329 stl: "none",
1330 system_shared_libs: [],
1331 srcs: [""],
1332 stubs: { versions: ["1"] },
1333
1334 sanitize: {
1335 never: true,
1336 },
Paul Duffina02cae32021-03-09 01:44:06 +00001337 } `)
1338 ctx := result.TestContext
Jooyung Han8ce8db92020-05-15 19:05:05 +09001339
1340 ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
1341 "lib64/bionic/libc.so",
1342 "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
1343 })
1344
1345 hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared")
1346
1347 installed := hwasan.Description("install libclang_rt.hwasan")
1348 ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
1349
1350 symlink := hwasan.Description("install symlink libclang_rt.hwasan")
1351 ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
1352 ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
1353}
1354
1355func TestRuntimeApexShouldInstallHwasanIfHwaddressSanitized(t *testing.T) {
Paul Duffin70d3bee2021-03-21 11:26:05 +00001356 result := android.GroupFixturePreparers(
Paul Duffina02cae32021-03-09 01:44:06 +00001357 prepareForTestOfRuntimeApexWithHwasan,
1358 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1359 variables.SanitizeDevice = []string{"hwaddress"}
1360 }),
1361 ).RunTestWithBp(t, `
Jooyung Han8ce8db92020-05-15 19:05:05 +09001362 cc_library {
1363 name: "libc",
1364 no_libcrt: true,
1365 nocrt: true,
1366 stl: "none",
1367 system_shared_libs: [],
1368 stubs: { versions: ["1"] },
1369 apex_available: ["com.android.runtime"],
1370 }
1371
1372 cc_prebuilt_library_shared {
1373 name: "libclang_rt.hwasan-aarch64-android",
1374 no_libcrt: true,
1375 nocrt: true,
1376 stl: "none",
1377 system_shared_libs: [],
1378 srcs: [""],
1379 stubs: { versions: ["1"] },
1380
1381 sanitize: {
1382 never: true,
1383 },
1384 }
Paul Duffina02cae32021-03-09 01:44:06 +00001385 `)
1386 ctx := result.TestContext
Jooyung Han8ce8db92020-05-15 19:05:05 +09001387
1388 ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
1389 "lib64/bionic/libc.so",
1390 "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
1391 })
1392
1393 hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared")
1394
1395 installed := hwasan.Description("install libclang_rt.hwasan")
1396 ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
1397
1398 symlink := hwasan.Description("install symlink libclang_rt.hwasan")
1399 ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
1400 ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
1401}
1402
Jooyung Han61b66e92020-03-21 14:21:46 +00001403func TestApexDependsOnLLNDKTransitively(t *testing.T) {
1404 testcases := []struct {
1405 name string
1406 minSdkVersion string
Colin Crossaede88c2020-08-11 12:17:01 -07001407 apexVariant string
Jooyung Han61b66e92020-03-21 14:21:46 +00001408 shouldLink string
1409 shouldNotLink []string
1410 }{
1411 {
Jiyong Park55549df2021-02-26 23:57:23 +09001412 name: "unspecified version links to the latest",
Jooyung Han749dc692020-04-15 11:03:39 +09001413 minSdkVersion: "",
Colin Crossaede88c2020-08-11 12:17:01 -07001414 apexVariant: "apex10000",
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001415 shouldLink: "current",
1416 shouldNotLink: []string{"29", "30"},
Jooyung Han61b66e92020-03-21 14:21:46 +00001417 },
1418 {
Jiyong Park55549df2021-02-26 23:57:23 +09001419 name: "always use the latest",
Jooyung Han749dc692020-04-15 11:03:39 +09001420 minSdkVersion: "min_sdk_version: \"29\",",
Colin Crossaede88c2020-08-11 12:17:01 -07001421 apexVariant: "apex29",
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001422 shouldLink: "current",
1423 shouldNotLink: []string{"29", "30"},
Jooyung Han61b66e92020-03-21 14:21:46 +00001424 },
1425 }
1426 for _, tc := range testcases {
1427 t.Run(tc.name, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001428 ctx := testApex(t, `
Jooyung Han61b66e92020-03-21 14:21:46 +00001429 apex {
1430 name: "myapex",
1431 key: "myapex.key",
Jooyung Han61b66e92020-03-21 14:21:46 +00001432 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001433 updatable: false,
Jooyung Han749dc692020-04-15 11:03:39 +09001434 `+tc.minSdkVersion+`
Jooyung Han61b66e92020-03-21 14:21:46 +00001435 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001436
Jooyung Han61b66e92020-03-21 14:21:46 +00001437 apex_key {
1438 name: "myapex.key",
1439 public_key: "testkey.avbpubkey",
1440 private_key: "testkey.pem",
1441 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001442
Jooyung Han61b66e92020-03-21 14:21:46 +00001443 cc_library {
1444 name: "mylib",
1445 srcs: ["mylib.cpp"],
1446 vendor_available: true,
1447 shared_libs: ["libbar"],
1448 system_shared_libs: [],
1449 stl: "none",
1450 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001451 min_sdk_version: "29",
Jooyung Han61b66e92020-03-21 14:21:46 +00001452 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001453
Jooyung Han61b66e92020-03-21 14:21:46 +00001454 cc_library {
1455 name: "libbar",
1456 srcs: ["mylib.cpp"],
1457 system_shared_libs: [],
1458 stl: "none",
1459 stubs: { versions: ["29","30"] },
Colin Cross203b4212021-04-26 17:19:41 -07001460 llndk: {
1461 symbol_file: "libbar.map.txt",
1462 }
Jooyung Han61b66e92020-03-21 14:21:46 +00001463 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001464 `,
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001465 withUnbundledBuild,
1466 )
Jooyung Han9c80bae2019-08-20 17:30:57 +09001467
Jooyung Han61b66e92020-03-21 14:21:46 +00001468 // Ensure that LLNDK dep is not included
1469 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
1470 "lib64/mylib.so",
1471 })
Jooyung Han9c80bae2019-08-20 17:30:57 +09001472
Jooyung Han61b66e92020-03-21 14:21:46 +00001473 // Ensure that LLNDK dep is required
1474 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
1475 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
1476 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libbar.so")
Jooyung Han9c80bae2019-08-20 17:30:57 +09001477
Steven Moreland2c4000c2021-04-27 02:08:49 +00001478 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_"+tc.apexVariant).Rule("ld").Args["libFlags"]
1479 ensureContains(t, mylibLdFlags, "libbar/android_arm64_armv8-a_shared_"+tc.shouldLink+"/libbar.so")
Jooyung Han61b66e92020-03-21 14:21:46 +00001480 for _, ver := range tc.shouldNotLink {
Steven Moreland2c4000c2021-04-27 02:08:49 +00001481 ensureNotContains(t, mylibLdFlags, "libbar/android_arm64_armv8-a_shared_"+ver+"/libbar.so")
Jooyung Han61b66e92020-03-21 14:21:46 +00001482 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001483
Steven Moreland2c4000c2021-04-27 02:08:49 +00001484 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_"+tc.apexVariant).Rule("cc").Args["cFlags"]
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001485 ver := tc.shouldLink
1486 if tc.shouldLink == "current" {
1487 ver = strconv.Itoa(android.FutureApiLevelInt)
1488 }
1489 ensureContains(t, mylibCFlags, "__LIBBAR_API__="+ver)
Jooyung Han61b66e92020-03-21 14:21:46 +00001490 })
1491 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001492}
1493
Jiyong Park25fc6a92018-11-18 18:02:45 +09001494func TestApexWithSystemLibsStubs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001495 ctx := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +09001496 apex {
1497 name: "myapex",
1498 key: "myapex.key",
1499 native_shared_libs: ["mylib", "mylib_shared", "libdl", "libm"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001500 updatable: false,
Jiyong Park25fc6a92018-11-18 18:02:45 +09001501 }
1502
1503 apex_key {
1504 name: "myapex.key",
1505 public_key: "testkey.avbpubkey",
1506 private_key: "testkey.pem",
1507 }
1508
1509 cc_library {
1510 name: "mylib",
1511 srcs: ["mylib.cpp"],
Colin Cross0de8a1e2020-09-18 14:15:30 -07001512 system_shared_libs: ["libc", "libm"],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001513 shared_libs: ["libdl#27"],
1514 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001515 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001516 }
1517
1518 cc_library_shared {
1519 name: "mylib_shared",
1520 srcs: ["mylib.cpp"],
1521 shared_libs: ["libdl#27"],
1522 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001523 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001524 }
1525
1526 cc_library {
Jiyong Parkb0788572018-12-20 22:10:17 +09001527 name: "libBootstrap",
1528 srcs: ["mylib.cpp"],
1529 stl: "none",
1530 bootstrap: true,
1531 }
Jiyong Park25fc6a92018-11-18 18:02:45 +09001532 `)
1533
Sundong Ahnabb64432019-10-22 13:58:29 +09001534 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001535 copyCmds := apexRule.Args["copy_commands"]
1536
1537 // Ensure that mylib, libm, libdl are included.
Alex Light5098a612018-11-29 17:12:15 -08001538 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Parkb0788572018-12-20 22:10:17 +09001539 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libm.so")
1540 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001541
1542 // Ensure that libc is not included (since it has stubs and not listed in native_shared_libs)
Jiyong Parkb0788572018-12-20 22:10:17 +09001543 ensureNotContains(t, copyCmds, "image.apex/lib64/bionic/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001544
Colin Crossaede88c2020-08-11 12:17:01 -07001545 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
1546 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
1547 mylibSharedCFlags := ctx.ModuleForTests("mylib_shared", "android_arm64_armv8-a_shared_apex10000").Rule("cc").Args["cFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +09001548
1549 // For dependency to libc
1550 // Ensure that mylib is linking with the latest version of stubs
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001551 ensureContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared_current/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001552 // ... and not linking to the non-stub (impl) variant
Jiyong Park3ff16992019-12-27 14:11:47 +09001553 ensureNotContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001554 // ... Cflags from stub is correctly exported to mylib
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001555 ensureContains(t, mylibCFlags, "__LIBC_API__=10000")
1556 ensureContains(t, mylibSharedCFlags, "__LIBC_API__=10000")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001557
1558 // For dependency to libm
1559 // Ensure that mylib is linking with the non-stub (impl) variant
Colin Crossaede88c2020-08-11 12:17:01 -07001560 ensureContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_apex10000/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001561 // ... and not linking to the stub variant
Jiyong Park3ff16992019-12-27 14:11:47 +09001562 ensureNotContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_29/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001563 // ... and is not compiling with the stub
1564 ensureNotContains(t, mylibCFlags, "__LIBM_API__=29")
1565 ensureNotContains(t, mylibSharedCFlags, "__LIBM_API__=29")
1566
1567 // For dependency to libdl
1568 // Ensure that mylib is linking with the specified version of stubs
Jiyong Park3ff16992019-12-27 14:11:47 +09001569 ensureContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_27/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001570 // ... and not linking to the other versions of stubs
Jiyong Park3ff16992019-12-27 14:11:47 +09001571 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_28/libdl.so")
1572 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_29/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001573 // ... and not linking to the non-stub (impl) variant
Colin Crossaede88c2020-08-11 12:17:01 -07001574 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_apex10000/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001575 // ... Cflags from stub is correctly exported to mylib
1576 ensureContains(t, mylibCFlags, "__LIBDL_API__=27")
1577 ensureContains(t, mylibSharedCFlags, "__LIBDL_API__=27")
Jiyong Parkb0788572018-12-20 22:10:17 +09001578
1579 // Ensure that libBootstrap is depending on the platform variant of bionic libs
Colin Cross7113d202019-11-20 16:39:12 -08001580 libFlags := ctx.ModuleForTests("libBootstrap", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
1581 ensureContains(t, libFlags, "libc/android_arm64_armv8-a_shared/libc.so")
1582 ensureContains(t, libFlags, "libm/android_arm64_armv8-a_shared/libm.so")
1583 ensureContains(t, libFlags, "libdl/android_arm64_armv8-a_shared/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001584}
Jiyong Park7c2ee712018-12-07 00:42:25 +09001585
Jooyung Han749dc692020-04-15 11:03:39 +09001586func TestApexMinSdkVersion_NativeModulesShouldBeBuiltAgainstStubs(t *testing.T) {
Jiyong Park55549df2021-02-26 23:57:23 +09001587 // there are three links between liba --> libz.
1588 // 1) myapex -> libx -> liba -> libz : this should be #30 link
Jooyung Han749dc692020-04-15 11:03:39 +09001589 // 2) otherapex -> liby -> liba -> libz : this should be #30 link
Jooyung Han03b51852020-02-26 22:45:42 +09001590 // 3) (platform) -> liba -> libz : this should be non-stub link
Colin Cross1c460562021-02-16 17:55:47 -08001591 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001592 apex {
1593 name: "myapex",
1594 key: "myapex.key",
1595 native_shared_libs: ["libx"],
Jooyung Han749dc692020-04-15 11:03:39 +09001596 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001597 }
1598
1599 apex {
1600 name: "otherapex",
1601 key: "myapex.key",
1602 native_shared_libs: ["liby"],
Jooyung Han749dc692020-04-15 11:03:39 +09001603 min_sdk_version: "30",
Jooyung Han03b51852020-02-26 22:45:42 +09001604 }
1605
1606 apex_key {
1607 name: "myapex.key",
1608 public_key: "testkey.avbpubkey",
1609 private_key: "testkey.pem",
1610 }
1611
1612 cc_library {
1613 name: "libx",
1614 shared_libs: ["liba"],
1615 system_shared_libs: [],
1616 stl: "none",
1617 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001618 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001619 }
1620
1621 cc_library {
1622 name: "liby",
1623 shared_libs: ["liba"],
1624 system_shared_libs: [],
1625 stl: "none",
1626 apex_available: [ "otherapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001627 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001628 }
1629
1630 cc_library {
1631 name: "liba",
1632 shared_libs: ["libz"],
1633 system_shared_libs: [],
1634 stl: "none",
1635 apex_available: [
1636 "//apex_available:anyapex",
1637 "//apex_available:platform",
1638 ],
Jooyung Han749dc692020-04-15 11:03:39 +09001639 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001640 }
1641
1642 cc_library {
1643 name: "libz",
1644 system_shared_libs: [],
1645 stl: "none",
1646 stubs: {
Jooyung Han749dc692020-04-15 11:03:39 +09001647 versions: ["28", "30"],
Jooyung Han03b51852020-02-26 22:45:42 +09001648 },
1649 }
Jooyung Han749dc692020-04-15 11:03:39 +09001650 `)
Jooyung Han03b51852020-02-26 22:45:42 +09001651
1652 expectLink := func(from, from_variant, to, to_variant string) {
1653 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1654 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1655 }
1656 expectNoLink := func(from, from_variant, to, to_variant string) {
1657 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1658 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1659 }
1660 // platform liba is linked to non-stub version
1661 expectLink("liba", "shared", "libz", "shared")
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001662 // liba in myapex is linked to current
1663 expectLink("liba", "shared_apex29", "libz", "shared_current")
1664 expectNoLink("liba", "shared_apex29", "libz", "shared_30")
Jiyong Park55549df2021-02-26 23:57:23 +09001665 expectNoLink("liba", "shared_apex29", "libz", "shared_28")
Colin Crossaede88c2020-08-11 12:17:01 -07001666 expectNoLink("liba", "shared_apex29", "libz", "shared")
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001667 // liba in otherapex is linked to current
1668 expectLink("liba", "shared_apex30", "libz", "shared_current")
1669 expectNoLink("liba", "shared_apex30", "libz", "shared_30")
Colin Crossaede88c2020-08-11 12:17:01 -07001670 expectNoLink("liba", "shared_apex30", "libz", "shared_28")
1671 expectNoLink("liba", "shared_apex30", "libz", "shared")
Jooyung Han03b51852020-02-26 22:45:42 +09001672}
1673
Jooyung Hanaed150d2020-04-02 01:41:41 +09001674func TestApexMinSdkVersion_SupportsCodeNames(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001675 ctx := testApex(t, `
Jooyung Hanaed150d2020-04-02 01:41:41 +09001676 apex {
1677 name: "myapex",
1678 key: "myapex.key",
1679 native_shared_libs: ["libx"],
1680 min_sdk_version: "R",
1681 }
1682
1683 apex_key {
1684 name: "myapex.key",
1685 public_key: "testkey.avbpubkey",
1686 private_key: "testkey.pem",
1687 }
1688
1689 cc_library {
1690 name: "libx",
1691 shared_libs: ["libz"],
1692 system_shared_libs: [],
1693 stl: "none",
1694 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001695 min_sdk_version: "R",
Jooyung Hanaed150d2020-04-02 01:41:41 +09001696 }
1697
1698 cc_library {
1699 name: "libz",
1700 system_shared_libs: [],
1701 stl: "none",
1702 stubs: {
1703 versions: ["29", "R"],
1704 },
1705 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001706 `,
1707 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1708 variables.Platform_version_active_codenames = []string{"R"}
1709 }),
1710 )
Jooyung Hanaed150d2020-04-02 01:41:41 +09001711
1712 expectLink := func(from, from_variant, to, to_variant string) {
1713 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1714 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1715 }
1716 expectNoLink := func(from, from_variant, to, to_variant string) {
1717 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1718 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1719 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001720 expectLink("libx", "shared_apex10000", "libz", "shared_current")
1721 expectNoLink("libx", "shared_apex10000", "libz", "shared_R")
Colin Crossaede88c2020-08-11 12:17:01 -07001722 expectNoLink("libx", "shared_apex10000", "libz", "shared_29")
1723 expectNoLink("libx", "shared_apex10000", "libz", "shared")
Jooyung Hanaed150d2020-04-02 01:41:41 +09001724}
1725
Jooyung Han4c4da062021-06-23 10:23:16 +09001726func TestApexMinSdkVersion_SupportsCodeNames_JavaLibs(t *testing.T) {
1727 testApex(t, `
1728 apex {
1729 name: "myapex",
1730 key: "myapex.key",
1731 java_libs: ["libx"],
1732 min_sdk_version: "S",
1733 }
1734
1735 apex_key {
1736 name: "myapex.key",
1737 public_key: "testkey.avbpubkey",
1738 private_key: "testkey.pem",
1739 }
1740
1741 java_library {
1742 name: "libx",
1743 srcs: ["a.java"],
1744 apex_available: [ "myapex" ],
1745 sdk_version: "current",
1746 min_sdk_version: "S", // should be okay
1747 }
1748 `,
1749 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1750 variables.Platform_version_active_codenames = []string{"S"}
1751 variables.Platform_sdk_codename = proptools.StringPtr("S")
1752 }),
1753 )
1754}
1755
Jooyung Han749dc692020-04-15 11:03:39 +09001756func TestApexMinSdkVersion_DefaultsToLatest(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001757 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001758 apex {
1759 name: "myapex",
1760 key: "myapex.key",
1761 native_shared_libs: ["libx"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001762 updatable: false,
Jooyung Han03b51852020-02-26 22:45:42 +09001763 }
1764
1765 apex_key {
1766 name: "myapex.key",
1767 public_key: "testkey.avbpubkey",
1768 private_key: "testkey.pem",
1769 }
1770
1771 cc_library {
1772 name: "libx",
1773 shared_libs: ["libz"],
1774 system_shared_libs: [],
1775 stl: "none",
1776 apex_available: [ "myapex" ],
1777 }
1778
1779 cc_library {
1780 name: "libz",
1781 system_shared_libs: [],
1782 stl: "none",
1783 stubs: {
1784 versions: ["1", "2"],
1785 },
1786 }
1787 `)
1788
1789 expectLink := func(from, from_variant, to, to_variant string) {
1790 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1791 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1792 }
1793 expectNoLink := func(from, from_variant, to, to_variant string) {
1794 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1795 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1796 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001797 expectLink("libx", "shared_apex10000", "libz", "shared_current")
Colin Crossaede88c2020-08-11 12:17:01 -07001798 expectNoLink("libx", "shared_apex10000", "libz", "shared_1")
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001799 expectNoLink("libx", "shared_apex10000", "libz", "shared_2")
Colin Crossaede88c2020-08-11 12:17:01 -07001800 expectNoLink("libx", "shared_apex10000", "libz", "shared")
Jooyung Han03b51852020-02-26 22:45:42 +09001801}
1802
1803func TestPlatformUsesLatestStubsFromApexes(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001804 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001805 apex {
1806 name: "myapex",
1807 key: "myapex.key",
1808 native_shared_libs: ["libx"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001809 updatable: false,
Jooyung Han03b51852020-02-26 22:45:42 +09001810 }
1811
1812 apex_key {
1813 name: "myapex.key",
1814 public_key: "testkey.avbpubkey",
1815 private_key: "testkey.pem",
1816 }
1817
1818 cc_library {
1819 name: "libx",
1820 system_shared_libs: [],
1821 stl: "none",
1822 apex_available: [ "myapex" ],
1823 stubs: {
1824 versions: ["1", "2"],
1825 },
1826 }
1827
1828 cc_library {
1829 name: "libz",
1830 shared_libs: ["libx"],
1831 system_shared_libs: [],
1832 stl: "none",
1833 }
1834 `)
1835
1836 expectLink := func(from, from_variant, to, to_variant string) {
Colin Cross56a83212020-09-15 18:30:11 -07001837 t.Helper()
Jooyung Han03b51852020-02-26 22:45:42 +09001838 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1839 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1840 }
1841 expectNoLink := func(from, from_variant, to, to_variant string) {
Colin Cross56a83212020-09-15 18:30:11 -07001842 t.Helper()
Jooyung Han03b51852020-02-26 22:45:42 +09001843 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1844 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1845 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001846 expectLink("libz", "shared", "libx", "shared_current")
1847 expectNoLink("libz", "shared", "libx", "shared_2")
Jooyung Han03b51852020-02-26 22:45:42 +09001848 expectNoLink("libz", "shared", "libz", "shared_1")
1849 expectNoLink("libz", "shared", "libz", "shared")
1850}
1851
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001852var prepareForTestWithSantitizeHwaddress = android.FixtureModifyProductVariables(
1853 func(variables android.FixtureProductVariables) {
1854 variables.SanitizeDevice = []string{"hwaddress"}
1855 },
1856)
1857
Jooyung Han75568392020-03-20 04:29:24 +09001858func TestQApexesUseLatestStubsInBundledBuildsAndHWASAN(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001859 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001860 apex {
1861 name: "myapex",
1862 key: "myapex.key",
1863 native_shared_libs: ["libx"],
1864 min_sdk_version: "29",
1865 }
1866
1867 apex_key {
1868 name: "myapex.key",
1869 public_key: "testkey.avbpubkey",
1870 private_key: "testkey.pem",
1871 }
1872
1873 cc_library {
1874 name: "libx",
1875 shared_libs: ["libbar"],
1876 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001877 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001878 }
1879
1880 cc_library {
1881 name: "libbar",
1882 stubs: {
1883 versions: ["29", "30"],
1884 },
1885 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001886 `,
1887 prepareForTestWithSantitizeHwaddress,
1888 )
Jooyung Han03b51852020-02-26 22:45:42 +09001889 expectLink := func(from, from_variant, to, to_variant string) {
1890 ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
1891 libFlags := ld.Args["libFlags"]
1892 ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1893 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001894 expectLink("libx", "shared_hwasan_apex29", "libbar", "shared_current")
Jooyung Han03b51852020-02-26 22:45:42 +09001895}
1896
Jooyung Han75568392020-03-20 04:29:24 +09001897func TestQTargetApexUsesStaticUnwinder(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001898 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001899 apex {
1900 name: "myapex",
1901 key: "myapex.key",
1902 native_shared_libs: ["libx"],
1903 min_sdk_version: "29",
1904 }
1905
1906 apex_key {
1907 name: "myapex.key",
1908 public_key: "testkey.avbpubkey",
1909 private_key: "testkey.pem",
1910 }
1911
1912 cc_library {
1913 name: "libx",
1914 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001915 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001916 }
Jooyung Han75568392020-03-20 04:29:24 +09001917 `)
Jooyung Han03b51852020-02-26 22:45:42 +09001918
1919 // ensure apex variant of c++ is linked with static unwinder
Colin Crossaede88c2020-08-11 12:17:01 -07001920 cm := ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared_apex29").Module().(*cc.Module)
Ryan Prichardb35a85e2021-01-13 19:18:53 -08001921 ensureListContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
Jooyung Han03b51852020-02-26 22:45:42 +09001922 // note that platform variant is not.
1923 cm = ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared").Module().(*cc.Module)
Ryan Prichardb35a85e2021-01-13 19:18:53 -08001924 ensureListNotContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
Jooyung Han03b51852020-02-26 22:45:42 +09001925}
1926
Jooyung Han749dc692020-04-15 11:03:39 +09001927func TestApexMinSdkVersion_ErrorIfIncompatibleVersion(t *testing.T) {
1928 testApexError(t, `module "mylib".*: should support min_sdk_version\(29\)`, `
Jooyung Han03b51852020-02-26 22:45:42 +09001929 apex {
1930 name: "myapex",
1931 key: "myapex.key",
Jooyung Han749dc692020-04-15 11:03:39 +09001932 native_shared_libs: ["mylib"],
1933 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001934 }
1935
1936 apex_key {
1937 name: "myapex.key",
1938 public_key: "testkey.avbpubkey",
1939 private_key: "testkey.pem",
1940 }
Jooyung Han749dc692020-04-15 11:03:39 +09001941
1942 cc_library {
1943 name: "mylib",
1944 srcs: ["mylib.cpp"],
1945 system_shared_libs: [],
1946 stl: "none",
1947 apex_available: [
1948 "myapex",
1949 ],
1950 min_sdk_version: "30",
1951 }
1952 `)
Ivan Lozano3e9f9e42020-12-04 15:05:43 -05001953
1954 testApexError(t, `module "libfoo.ffi".*: should support min_sdk_version\(29\)`, `
1955 apex {
1956 name: "myapex",
1957 key: "myapex.key",
1958 native_shared_libs: ["libfoo.ffi"],
1959 min_sdk_version: "29",
1960 }
1961
1962 apex_key {
1963 name: "myapex.key",
1964 public_key: "testkey.avbpubkey",
1965 private_key: "testkey.pem",
1966 }
1967
1968 rust_ffi_shared {
1969 name: "libfoo.ffi",
1970 srcs: ["foo.rs"],
1971 crate_name: "foo",
1972 apex_available: [
1973 "myapex",
1974 ],
1975 min_sdk_version: "30",
1976 }
1977 `)
Jaewoong Jung56e12db2021-04-02 00:38:25 +00001978
1979 testApexError(t, `module "libfoo".*: should support min_sdk_version\(29\)`, `
1980 apex {
1981 name: "myapex",
1982 key: "myapex.key",
1983 java_libs: ["libfoo"],
1984 min_sdk_version: "29",
1985 }
1986
1987 apex_key {
1988 name: "myapex.key",
1989 public_key: "testkey.avbpubkey",
1990 private_key: "testkey.pem",
1991 }
1992
1993 java_import {
1994 name: "libfoo",
1995 jars: ["libfoo.jar"],
1996 apex_available: [
1997 "myapex",
1998 ],
1999 min_sdk_version: "30",
2000 }
2001 `)
Jooyung Han749dc692020-04-15 11:03:39 +09002002}
2003
2004func TestApexMinSdkVersion_Okay(t *testing.T) {
2005 testApex(t, `
2006 apex {
2007 name: "myapex",
2008 key: "myapex.key",
2009 native_shared_libs: ["libfoo"],
2010 java_libs: ["libbar"],
2011 min_sdk_version: "29",
2012 }
2013
2014 apex_key {
2015 name: "myapex.key",
2016 public_key: "testkey.avbpubkey",
2017 private_key: "testkey.pem",
2018 }
2019
2020 cc_library {
2021 name: "libfoo",
2022 srcs: ["mylib.cpp"],
2023 shared_libs: ["libfoo_dep"],
2024 apex_available: ["myapex"],
2025 min_sdk_version: "29",
2026 }
2027
2028 cc_library {
2029 name: "libfoo_dep",
2030 srcs: ["mylib.cpp"],
2031 apex_available: ["myapex"],
2032 min_sdk_version: "29",
2033 }
2034
2035 java_library {
2036 name: "libbar",
2037 sdk_version: "current",
2038 srcs: ["a.java"],
Jaewoong Jung56e12db2021-04-02 00:38:25 +00002039 static_libs: [
2040 "libbar_dep",
2041 "libbar_import_dep",
2042 ],
Jooyung Han749dc692020-04-15 11:03:39 +09002043 apex_available: ["myapex"],
2044 min_sdk_version: "29",
2045 }
2046
2047 java_library {
2048 name: "libbar_dep",
2049 sdk_version: "current",
2050 srcs: ["a.java"],
2051 apex_available: ["myapex"],
2052 min_sdk_version: "29",
2053 }
Jaewoong Jung56e12db2021-04-02 00:38:25 +00002054
2055 java_import {
2056 name: "libbar_import_dep",
2057 jars: ["libbar.jar"],
2058 apex_available: ["myapex"],
2059 min_sdk_version: "29",
2060 }
Jooyung Han03b51852020-02-26 22:45:42 +09002061 `)
2062}
2063
Artur Satayev8cf899a2020-04-15 17:29:42 +01002064func TestJavaStableSdkVersion(t *testing.T) {
2065 testCases := []struct {
2066 name string
2067 expectedError string
2068 bp string
2069 }{
2070 {
2071 name: "Non-updatable apex with non-stable dep",
2072 bp: `
2073 apex {
2074 name: "myapex",
2075 java_libs: ["myjar"],
2076 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002077 updatable: false,
Artur Satayev8cf899a2020-04-15 17:29:42 +01002078 }
2079 apex_key {
2080 name: "myapex.key",
2081 public_key: "testkey.avbpubkey",
2082 private_key: "testkey.pem",
2083 }
2084 java_library {
2085 name: "myjar",
2086 srcs: ["foo/bar/MyClass.java"],
Paul Duffin043f5e72021-03-05 00:00:01 +00002087 sdk_version: "test_current",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002088 apex_available: ["myapex"],
2089 }
2090 `,
2091 },
2092 {
2093 name: "Updatable apex with stable dep",
2094 bp: `
2095 apex {
2096 name: "myapex",
2097 java_libs: ["myjar"],
2098 key: "myapex.key",
2099 updatable: true,
2100 min_sdk_version: "29",
2101 }
2102 apex_key {
2103 name: "myapex.key",
2104 public_key: "testkey.avbpubkey",
2105 private_key: "testkey.pem",
2106 }
2107 java_library {
2108 name: "myjar",
2109 srcs: ["foo/bar/MyClass.java"],
2110 sdk_version: "current",
2111 apex_available: ["myapex"],
Jooyung Han749dc692020-04-15 11:03:39 +09002112 min_sdk_version: "29",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002113 }
2114 `,
2115 },
2116 {
2117 name: "Updatable apex with non-stable dep",
2118 expectedError: "cannot depend on \"myjar\"",
2119 bp: `
2120 apex {
2121 name: "myapex",
2122 java_libs: ["myjar"],
2123 key: "myapex.key",
2124 updatable: true,
2125 }
2126 apex_key {
2127 name: "myapex.key",
2128 public_key: "testkey.avbpubkey",
2129 private_key: "testkey.pem",
2130 }
2131 java_library {
2132 name: "myjar",
2133 srcs: ["foo/bar/MyClass.java"],
Paul Duffin043f5e72021-03-05 00:00:01 +00002134 sdk_version: "test_current",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002135 apex_available: ["myapex"],
2136 }
2137 `,
2138 },
2139 {
Paul Duffin043f5e72021-03-05 00:00:01 +00002140 name: "Updatable apex with non-stable transitive dep",
2141 // This is not actually detecting that the transitive dependency is unstable, rather it is
2142 // detecting that the transitive dependency is building against a wider API surface than the
2143 // module that depends on it is using.
Jiyong Park670e0f62021-02-18 13:10:18 +09002144 expectedError: "compiles against Android API, but dependency \"transitive-jar\" is compiling against private API.",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002145 bp: `
2146 apex {
2147 name: "myapex",
2148 java_libs: ["myjar"],
2149 key: "myapex.key",
2150 updatable: true,
2151 }
2152 apex_key {
2153 name: "myapex.key",
2154 public_key: "testkey.avbpubkey",
2155 private_key: "testkey.pem",
2156 }
2157 java_library {
2158 name: "myjar",
2159 srcs: ["foo/bar/MyClass.java"],
2160 sdk_version: "current",
2161 apex_available: ["myapex"],
2162 static_libs: ["transitive-jar"],
2163 }
2164 java_library {
2165 name: "transitive-jar",
2166 srcs: ["foo/bar/MyClass.java"],
2167 sdk_version: "core_platform",
2168 apex_available: ["myapex"],
2169 }
2170 `,
2171 },
2172 }
2173
2174 for _, test := range testCases {
2175 t.Run(test.name, func(t *testing.T) {
2176 if test.expectedError == "" {
2177 testApex(t, test.bp)
2178 } else {
2179 testApexError(t, test.expectedError, test.bp)
2180 }
2181 })
2182 }
2183}
2184
Jooyung Han749dc692020-04-15 11:03:39 +09002185func TestApexMinSdkVersion_ErrorIfDepIsNewer(t *testing.T) {
2186 testApexError(t, `module "mylib2".*: should support min_sdk_version\(29\) for "myapex"`, `
2187 apex {
2188 name: "myapex",
2189 key: "myapex.key",
2190 native_shared_libs: ["mylib"],
2191 min_sdk_version: "29",
2192 }
2193
2194 apex_key {
2195 name: "myapex.key",
2196 public_key: "testkey.avbpubkey",
2197 private_key: "testkey.pem",
2198 }
2199
2200 cc_library {
2201 name: "mylib",
2202 srcs: ["mylib.cpp"],
2203 shared_libs: ["mylib2"],
2204 system_shared_libs: [],
2205 stl: "none",
2206 apex_available: [
2207 "myapex",
2208 ],
2209 min_sdk_version: "29",
2210 }
2211
2212 // indirect part of the apex
2213 cc_library {
2214 name: "mylib2",
2215 srcs: ["mylib.cpp"],
2216 system_shared_libs: [],
2217 stl: "none",
2218 apex_available: [
2219 "myapex",
2220 ],
2221 min_sdk_version: "30",
2222 }
2223 `)
2224}
2225
2226func TestApexMinSdkVersion_ErrorIfDepIsNewer_Java(t *testing.T) {
2227 testApexError(t, `module "bar".*: should support min_sdk_version\(29\) for "myapex"`, `
2228 apex {
2229 name: "myapex",
2230 key: "myapex.key",
2231 apps: ["AppFoo"],
2232 min_sdk_version: "29",
2233 }
2234
2235 apex_key {
2236 name: "myapex.key",
2237 public_key: "testkey.avbpubkey",
2238 private_key: "testkey.pem",
2239 }
2240
2241 android_app {
2242 name: "AppFoo",
2243 srcs: ["foo/bar/MyClass.java"],
2244 sdk_version: "current",
2245 min_sdk_version: "29",
2246 system_modules: "none",
2247 stl: "none",
2248 static_libs: ["bar"],
2249 apex_available: [ "myapex" ],
2250 }
2251
2252 java_library {
2253 name: "bar",
2254 sdk_version: "current",
2255 srcs: ["a.java"],
2256 apex_available: [ "myapex" ],
2257 }
2258 `)
2259}
2260
2261func TestApexMinSdkVersion_OkayEvenWhenDepIsNewer_IfItSatisfiesApexMinSdkVersion(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002262 ctx := testApex(t, `
Jooyung Han749dc692020-04-15 11:03:39 +09002263 apex {
2264 name: "myapex",
2265 key: "myapex.key",
2266 native_shared_libs: ["mylib"],
2267 min_sdk_version: "29",
2268 }
2269
2270 apex_key {
2271 name: "myapex.key",
2272 public_key: "testkey.avbpubkey",
2273 private_key: "testkey.pem",
2274 }
2275
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002276 // mylib in myapex will link to mylib2#current
Jooyung Han749dc692020-04-15 11:03:39 +09002277 // mylib in otherapex will link to mylib2(non-stub) in otherapex as well
2278 cc_library {
2279 name: "mylib",
2280 srcs: ["mylib.cpp"],
2281 shared_libs: ["mylib2"],
2282 system_shared_libs: [],
2283 stl: "none",
2284 apex_available: ["myapex", "otherapex"],
2285 min_sdk_version: "29",
2286 }
2287
2288 cc_library {
2289 name: "mylib2",
2290 srcs: ["mylib.cpp"],
2291 system_shared_libs: [],
2292 stl: "none",
2293 apex_available: ["otherapex"],
2294 stubs: { versions: ["29", "30"] },
2295 min_sdk_version: "30",
2296 }
2297
2298 apex {
2299 name: "otherapex",
2300 key: "myapex.key",
2301 native_shared_libs: ["mylib", "mylib2"],
2302 min_sdk_version: "30",
2303 }
2304 `)
2305 expectLink := func(from, from_variant, to, to_variant string) {
2306 ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
2307 libFlags := ld.Args["libFlags"]
2308 ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
2309 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002310 expectLink("mylib", "shared_apex29", "mylib2", "shared_current")
Colin Crossaede88c2020-08-11 12:17:01 -07002311 expectLink("mylib", "shared_apex30", "mylib2", "shared_apex30")
Jooyung Han749dc692020-04-15 11:03:39 +09002312}
2313
Jooyung Haned124c32021-01-26 11:43:46 +09002314func TestApexMinSdkVersion_WorksWithSdkCodename(t *testing.T) {
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002315 withSAsActiveCodeNames := android.FixtureModifyProductVariables(
2316 func(variables android.FixtureProductVariables) {
2317 variables.Platform_sdk_codename = proptools.StringPtr("S")
2318 variables.Platform_version_active_codenames = []string{"S"}
2319 },
2320 )
Jooyung Haned124c32021-01-26 11:43:46 +09002321 testApexError(t, `libbar.*: should support min_sdk_version\(S\)`, `
2322 apex {
2323 name: "myapex",
2324 key: "myapex.key",
2325 native_shared_libs: ["libfoo"],
2326 min_sdk_version: "S",
2327 }
2328 apex_key {
2329 name: "myapex.key",
2330 public_key: "testkey.avbpubkey",
2331 private_key: "testkey.pem",
2332 }
2333 cc_library {
2334 name: "libfoo",
2335 shared_libs: ["libbar"],
2336 apex_available: ["myapex"],
2337 min_sdk_version: "29",
2338 }
2339 cc_library {
2340 name: "libbar",
2341 apex_available: ["myapex"],
2342 }
2343 `, withSAsActiveCodeNames)
2344}
2345
2346func TestApexMinSdkVersion_WorksWithActiveCodenames(t *testing.T) {
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002347 withSAsActiveCodeNames := android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
2348 variables.Platform_sdk_codename = proptools.StringPtr("S")
2349 variables.Platform_version_active_codenames = []string{"S", "T"}
2350 })
Colin Cross1c460562021-02-16 17:55:47 -08002351 ctx := testApex(t, `
Jooyung Haned124c32021-01-26 11:43:46 +09002352 apex {
2353 name: "myapex",
2354 key: "myapex.key",
2355 native_shared_libs: ["libfoo"],
2356 min_sdk_version: "S",
2357 }
2358 apex_key {
2359 name: "myapex.key",
2360 public_key: "testkey.avbpubkey",
2361 private_key: "testkey.pem",
2362 }
2363 cc_library {
2364 name: "libfoo",
2365 shared_libs: ["libbar"],
2366 apex_available: ["myapex"],
2367 min_sdk_version: "S",
2368 }
2369 cc_library {
2370 name: "libbar",
2371 stubs: {
2372 symbol_file: "libbar.map.txt",
2373 versions: ["30", "S", "T"],
2374 },
2375 }
2376 `, withSAsActiveCodeNames)
2377
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002378 // ensure libfoo is linked with current version of libbar stub
Jooyung Haned124c32021-01-26 11:43:46 +09002379 libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_apex10000")
2380 libFlags := libfoo.Rule("ld").Args["libFlags"]
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002381 ensureContains(t, libFlags, "android_arm64_armv8-a_shared_current/libbar.so")
Jooyung Haned124c32021-01-26 11:43:46 +09002382}
2383
Jiyong Park7c2ee712018-12-07 00:42:25 +09002384func TestFilesInSubDir(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002385 ctx := testApex(t, `
Jiyong Park7c2ee712018-12-07 00:42:25 +09002386 apex {
2387 name: "myapex",
2388 key: "myapex.key",
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002389 native_shared_libs: ["mylib"],
2390 binaries: ["mybin"],
Jiyong Park7c2ee712018-12-07 00:42:25 +09002391 prebuilts: ["myetc"],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002392 compile_multilib: "both",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002393 updatable: false,
Jiyong Park7c2ee712018-12-07 00:42:25 +09002394 }
2395
2396 apex_key {
2397 name: "myapex.key",
2398 public_key: "testkey.avbpubkey",
2399 private_key: "testkey.pem",
2400 }
2401
2402 prebuilt_etc {
2403 name: "myetc",
2404 src: "myprebuilt",
2405 sub_dir: "foo/bar",
2406 }
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002407
2408 cc_library {
2409 name: "mylib",
2410 srcs: ["mylib.cpp"],
2411 relative_install_path: "foo/bar",
2412 system_shared_libs: [],
2413 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002414 apex_available: [ "myapex" ],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002415 }
2416
2417 cc_binary {
2418 name: "mybin",
2419 srcs: ["mylib.cpp"],
2420 relative_install_path: "foo/bar",
2421 system_shared_libs: [],
2422 static_executable: true,
2423 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002424 apex_available: [ "myapex" ],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002425 }
Jiyong Park7c2ee712018-12-07 00:42:25 +09002426 `)
2427
Sundong Ahnabb64432019-10-22 13:58:29 +09002428 generateFsRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("generateFsConfig")
Jiyong Park7c2ee712018-12-07 00:42:25 +09002429 dirs := strings.Split(generateFsRule.Args["exec_paths"], " ")
2430
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002431 // Ensure that the subdirectories are all listed
Jiyong Park7c2ee712018-12-07 00:42:25 +09002432 ensureListContains(t, dirs, "etc")
2433 ensureListContains(t, dirs, "etc/foo")
2434 ensureListContains(t, dirs, "etc/foo/bar")
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002435 ensureListContains(t, dirs, "lib64")
2436 ensureListContains(t, dirs, "lib64/foo")
2437 ensureListContains(t, dirs, "lib64/foo/bar")
2438 ensureListContains(t, dirs, "lib")
2439 ensureListContains(t, dirs, "lib/foo")
2440 ensureListContains(t, dirs, "lib/foo/bar")
2441
Jiyong Parkbd13e442019-03-15 18:10:35 +09002442 ensureListContains(t, dirs, "bin")
2443 ensureListContains(t, dirs, "bin/foo")
2444 ensureListContains(t, dirs, "bin/foo/bar")
Jiyong Park7c2ee712018-12-07 00:42:25 +09002445}
Jiyong Parkda6eb592018-12-19 17:12:36 +09002446
Jooyung Han35155c42020-02-06 17:33:20 +09002447func TestFilesInSubDirWhenNativeBridgeEnabled(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002448 ctx := testApex(t, `
Jooyung Han35155c42020-02-06 17:33:20 +09002449 apex {
2450 name: "myapex",
2451 key: "myapex.key",
2452 multilib: {
2453 both: {
2454 native_shared_libs: ["mylib"],
2455 binaries: ["mybin"],
2456 },
2457 },
2458 compile_multilib: "both",
2459 native_bridge_supported: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002460 updatable: false,
Jooyung Han35155c42020-02-06 17:33:20 +09002461 }
2462
2463 apex_key {
2464 name: "myapex.key",
2465 public_key: "testkey.avbpubkey",
2466 private_key: "testkey.pem",
2467 }
2468
2469 cc_library {
2470 name: "mylib",
2471 relative_install_path: "foo/bar",
2472 system_shared_libs: [],
2473 stl: "none",
2474 apex_available: [ "myapex" ],
2475 native_bridge_supported: true,
2476 }
2477
2478 cc_binary {
2479 name: "mybin",
2480 relative_install_path: "foo/bar",
2481 system_shared_libs: [],
2482 static_executable: true,
2483 stl: "none",
2484 apex_available: [ "myapex" ],
2485 native_bridge_supported: true,
2486 compile_multilib: "both", // default is "first" for binary
2487 multilib: {
2488 lib64: {
2489 suffix: "64",
2490 },
2491 },
2492 }
2493 `, withNativeBridgeEnabled)
2494 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2495 "bin/foo/bar/mybin",
2496 "bin/foo/bar/mybin64",
2497 "bin/arm/foo/bar/mybin",
2498 "bin/arm64/foo/bar/mybin64",
2499 "lib/foo/bar/mylib.so",
2500 "lib/arm/foo/bar/mylib.so",
2501 "lib64/foo/bar/mylib.so",
2502 "lib64/arm64/foo/bar/mylib.so",
2503 })
2504}
2505
Jooyung Han85d61762020-06-24 23:50:26 +09002506func TestVendorApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002507 ctx := testApex(t, `
Jooyung Han85d61762020-06-24 23:50:26 +09002508 apex {
2509 name: "myapex",
2510 key: "myapex.key",
2511 binaries: ["mybin"],
2512 vendor: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002513 updatable: false,
Jooyung Han85d61762020-06-24 23:50:26 +09002514 }
2515 apex_key {
2516 name: "myapex.key",
2517 public_key: "testkey.avbpubkey",
2518 private_key: "testkey.pem",
2519 }
2520 cc_binary {
2521 name: "mybin",
2522 vendor: true,
2523 shared_libs: ["libfoo"],
2524 }
2525 cc_library {
2526 name: "libfoo",
2527 proprietary: true,
2528 }
2529 `)
2530
2531 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2532 "bin/mybin",
2533 "lib64/libfoo.so",
2534 // TODO(b/159195575): Add an option to use VNDK libs from VNDK APEX
2535 "lib64/libc++.so",
2536 })
2537
2538 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07002539 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Han85d61762020-06-24 23:50:26 +09002540 name := apexBundle.BaseModuleName()
2541 prefix := "TARGET_"
2542 var builder strings.Builder
2543 data.Custom(&builder, name, prefix, "", data)
Paul Duffin37ba3442021-03-29 00:21:08 +01002544 androidMk := android.StringRelativeToTop(ctx.Config(), builder.String())
2545 installPath := "out/target/product/test_device/vendor/apex"
Lukacs T. Berki7690c092021-02-26 14:27:36 +01002546 ensureContains(t, androidMk, "LOCAL_MODULE_PATH := "+installPath)
Jooyung Han6c4cc9c2020-07-29 16:00:54 +09002547
2548 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
2549 requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
2550 ensureListNotContains(t, requireNativeLibs, ":vndk")
Jooyung Han85d61762020-06-24 23:50:26 +09002551}
2552
Jooyung Handf78e212020-07-22 15:54:47 +09002553func TestVendorApex_use_vndk_as_stable(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002554 ctx := testApex(t, `
Jooyung Handf78e212020-07-22 15:54:47 +09002555 apex {
2556 name: "myapex",
2557 key: "myapex.key",
2558 binaries: ["mybin"],
2559 vendor: true,
2560 use_vndk_as_stable: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002561 updatable: false,
Jooyung Handf78e212020-07-22 15:54:47 +09002562 }
2563 apex_key {
2564 name: "myapex.key",
2565 public_key: "testkey.avbpubkey",
2566 private_key: "testkey.pem",
2567 }
2568 cc_binary {
2569 name: "mybin",
2570 vendor: true,
2571 shared_libs: ["libvndk", "libvendor"],
2572 }
2573 cc_library {
2574 name: "libvndk",
2575 vndk: {
2576 enabled: true,
2577 },
2578 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09002579 product_available: true,
Jooyung Handf78e212020-07-22 15:54:47 +09002580 }
2581 cc_library {
2582 name: "libvendor",
2583 vendor: true,
2584 }
2585 `)
2586
Jiyong Parkf58c46e2021-04-01 21:35:20 +09002587 vendorVariant := "android_vendor.29_arm64_armv8-a"
Jooyung Handf78e212020-07-22 15:54:47 +09002588
Paul Duffina71a67a2021-03-29 00:42:57 +01002589 ldRule := ctx.ModuleForTests("mybin", vendorVariant+"_apex10000").Rule("ld")
Jooyung Handf78e212020-07-22 15:54:47 +09002590 libs := names(ldRule.Args["libFlags"])
2591 // VNDK libs(libvndk/libc++) as they are
Paul Duffin37ba3442021-03-29 00:21:08 +01002592 ensureListContains(t, libs, "out/soong/.intermediates/libvndk/"+vendorVariant+"_shared/libvndk.so")
2593 ensureListContains(t, libs, "out/soong/.intermediates/"+cc.DefaultCcCommonTestModulesDir+"libc++/"+vendorVariant+"_shared/libc++.so")
Jooyung Handf78e212020-07-22 15:54:47 +09002594 // non-stable Vendor libs as APEX variants
Paul Duffin37ba3442021-03-29 00:21:08 +01002595 ensureListContains(t, libs, "out/soong/.intermediates/libvendor/"+vendorVariant+"_shared_apex10000/libvendor.so")
Jooyung Handf78e212020-07-22 15:54:47 +09002596
2597 // VNDK libs are not included when use_vndk_as_stable: true
2598 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2599 "bin/mybin",
2600 "lib64/libvendor.so",
2601 })
Jooyung Han6c4cc9c2020-07-29 16:00:54 +09002602
2603 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
2604 requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
2605 ensureListContains(t, requireNativeLibs, ":vndk")
Jooyung Handf78e212020-07-22 15:54:47 +09002606}
2607
Justin Yun13decfb2021-03-08 19:25:55 +09002608func TestProductVariant(t *testing.T) {
2609 ctx := testApex(t, `
2610 apex {
2611 name: "myapex",
2612 key: "myapex.key",
2613 updatable: false,
2614 product_specific: true,
2615 binaries: ["foo"],
2616 }
2617
2618 apex_key {
2619 name: "myapex.key",
2620 public_key: "testkey.avbpubkey",
2621 private_key: "testkey.pem",
2622 }
2623
2624 cc_binary {
2625 name: "foo",
2626 product_available: true,
2627 apex_available: ["myapex"],
2628 srcs: ["foo.cpp"],
2629 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002630 `, android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
2631 variables.ProductVndkVersion = proptools.StringPtr("current")
2632 }),
2633 )
Justin Yun13decfb2021-03-08 19:25:55 +09002634
2635 cflags := strings.Fields(
Jiyong Parkf58c46e2021-04-01 21:35:20 +09002636 ctx.ModuleForTests("foo", "android_product.29_arm64_armv8-a_apex10000").Rule("cc").Args["cFlags"])
Justin Yun13decfb2021-03-08 19:25:55 +09002637 ensureListContains(t, cflags, "-D__ANDROID_VNDK__")
2638 ensureListContains(t, cflags, "-D__ANDROID_APEX__")
2639 ensureListContains(t, cflags, "-D__ANDROID_PRODUCT__")
2640 ensureListNotContains(t, cflags, "-D__ANDROID_VENDOR__")
2641}
2642
Jooyung Han8e5685d2020-09-21 11:02:57 +09002643func TestApex_withPrebuiltFirmware(t *testing.T) {
2644 testCases := []struct {
2645 name string
2646 additionalProp string
2647 }{
2648 {"system apex with prebuilt_firmware", ""},
2649 {"vendor apex with prebuilt_firmware", "vendor: true,"},
2650 }
2651 for _, tc := range testCases {
2652 t.Run(tc.name, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002653 ctx := testApex(t, `
Jooyung Han8e5685d2020-09-21 11:02:57 +09002654 apex {
2655 name: "myapex",
2656 key: "myapex.key",
2657 prebuilts: ["myfirmware"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002658 updatable: false,
Jooyung Han8e5685d2020-09-21 11:02:57 +09002659 `+tc.additionalProp+`
2660 }
2661 apex_key {
2662 name: "myapex.key",
2663 public_key: "testkey.avbpubkey",
2664 private_key: "testkey.pem",
2665 }
2666 prebuilt_firmware {
2667 name: "myfirmware",
2668 src: "myfirmware.bin",
2669 filename_from_src: true,
2670 `+tc.additionalProp+`
2671 }
2672 `)
2673 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
2674 "etc/firmware/myfirmware.bin",
2675 })
2676 })
2677 }
Jooyung Han0703fd82020-08-26 22:11:53 +09002678}
2679
Jooyung Hanefb184e2020-06-25 17:14:25 +09002680func TestAndroidMk_VendorApexRequired(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002681 ctx := testApex(t, `
Jooyung Hanefb184e2020-06-25 17:14:25 +09002682 apex {
2683 name: "myapex",
2684 key: "myapex.key",
2685 vendor: true,
2686 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002687 updatable: false,
Jooyung Hanefb184e2020-06-25 17:14:25 +09002688 }
2689
2690 apex_key {
2691 name: "myapex.key",
2692 public_key: "testkey.avbpubkey",
2693 private_key: "testkey.pem",
2694 }
2695
2696 cc_library {
2697 name: "mylib",
2698 vendor_available: true,
2699 }
2700 `)
2701
2702 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07002703 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Hanefb184e2020-06-25 17:14:25 +09002704 name := apexBundle.BaseModuleName()
2705 prefix := "TARGET_"
2706 var builder strings.Builder
2707 data.Custom(&builder, name, prefix, "", data)
2708 androidMk := builder.String()
2709 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += libc.vendor libm.vendor libdl.vendor\n")
2710}
2711
Jooyung Han2ed99d02020-06-24 23:26:26 +09002712func TestAndroidMkWritesCommonProperties(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002713 ctx := testApex(t, `
Jooyung Han2ed99d02020-06-24 23:26:26 +09002714 apex {
2715 name: "myapex",
2716 key: "myapex.key",
2717 vintf_fragments: ["fragment.xml"],
2718 init_rc: ["init.rc"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002719 updatable: false,
Jooyung Han2ed99d02020-06-24 23:26:26 +09002720 }
2721 apex_key {
2722 name: "myapex.key",
2723 public_key: "testkey.avbpubkey",
2724 private_key: "testkey.pem",
2725 }
2726 cc_binary {
2727 name: "mybin",
2728 }
2729 `)
2730
2731 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07002732 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Han2ed99d02020-06-24 23:26:26 +09002733 name := apexBundle.BaseModuleName()
2734 prefix := "TARGET_"
2735 var builder strings.Builder
2736 data.Custom(&builder, name, prefix, "", data)
2737 androidMk := builder.String()
Liz Kammer7b3dc8a2021-04-16 16:41:59 -04002738 ensureContains(t, androidMk, "LOCAL_FULL_VINTF_FRAGMENTS := fragment.xml\n")
Liz Kammer0c4f71c2021-04-06 10:35:10 -04002739 ensureContains(t, androidMk, "LOCAL_FULL_INIT_RC := init.rc\n")
Jooyung Han2ed99d02020-06-24 23:26:26 +09002740}
2741
Jiyong Park16e91a02018-12-20 18:18:08 +09002742func TestStaticLinking(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002743 ctx := testApex(t, `
Jiyong Park16e91a02018-12-20 18:18:08 +09002744 apex {
2745 name: "myapex",
2746 key: "myapex.key",
2747 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002748 updatable: false,
Jiyong Park16e91a02018-12-20 18:18:08 +09002749 }
2750
2751 apex_key {
2752 name: "myapex.key",
2753 public_key: "testkey.avbpubkey",
2754 private_key: "testkey.pem",
2755 }
2756
2757 cc_library {
2758 name: "mylib",
2759 srcs: ["mylib.cpp"],
2760 system_shared_libs: [],
2761 stl: "none",
2762 stubs: {
2763 versions: ["1", "2", "3"],
2764 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002765 apex_available: [
2766 "//apex_available:platform",
2767 "myapex",
2768 ],
Jiyong Park16e91a02018-12-20 18:18:08 +09002769 }
2770
2771 cc_binary {
2772 name: "not_in_apex",
2773 srcs: ["mylib.cpp"],
2774 static_libs: ["mylib"],
2775 static_executable: true,
2776 system_shared_libs: [],
2777 stl: "none",
2778 }
Jiyong Park16e91a02018-12-20 18:18:08 +09002779 `)
2780
Colin Cross7113d202019-11-20 16:39:12 -08002781 ldFlags := ctx.ModuleForTests("not_in_apex", "android_arm64_armv8-a").Rule("ld").Args["libFlags"]
Jiyong Park16e91a02018-12-20 18:18:08 +09002782
2783 // Ensure that not_in_apex is linking with the static variant of mylib
Colin Cross7113d202019-11-20 16:39:12 -08002784 ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_static/mylib.a")
Jiyong Park16e91a02018-12-20 18:18:08 +09002785}
Jiyong Park9335a262018-12-24 11:31:58 +09002786
2787func TestKeys(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002788 ctx := testApex(t, `
Jiyong Park9335a262018-12-24 11:31:58 +09002789 apex {
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002790 name: "myapex_keytest",
Jiyong Park9335a262018-12-24 11:31:58 +09002791 key: "myapex.key",
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002792 certificate: ":myapex.certificate",
Jiyong Park9335a262018-12-24 11:31:58 +09002793 native_shared_libs: ["mylib"],
Jooyung Han54aca7b2019-11-20 02:26:02 +09002794 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002795 updatable: false,
Jiyong Park9335a262018-12-24 11:31:58 +09002796 }
2797
2798 cc_library {
2799 name: "mylib",
2800 srcs: ["mylib.cpp"],
2801 system_shared_libs: [],
2802 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002803 apex_available: [ "myapex_keytest" ],
Jiyong Park9335a262018-12-24 11:31:58 +09002804 }
2805
2806 apex_key {
2807 name: "myapex.key",
2808 public_key: "testkey.avbpubkey",
2809 private_key: "testkey.pem",
2810 }
2811
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002812 android_app_certificate {
2813 name: "myapex.certificate",
2814 certificate: "testkey",
2815 }
2816
2817 android_app_certificate {
2818 name: "myapex.certificate.override",
2819 certificate: "testkey.override",
2820 }
2821
Jiyong Park9335a262018-12-24 11:31:58 +09002822 `)
2823
2824 // check the APEX keys
Jiyong Parkd1e293d2019-03-15 02:13:21 +09002825 keys := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
Jiyong Park9335a262018-12-24 11:31:58 +09002826
Jaewoong Jung18aefc12020-12-21 09:11:10 -08002827 if keys.publicKeyFile.String() != "vendor/foo/devkeys/testkey.avbpubkey" {
2828 t.Errorf("public key %q is not %q", keys.publicKeyFile.String(),
Jiyong Park9335a262018-12-24 11:31:58 +09002829 "vendor/foo/devkeys/testkey.avbpubkey")
2830 }
Jaewoong Jung18aefc12020-12-21 09:11:10 -08002831 if keys.privateKeyFile.String() != "vendor/foo/devkeys/testkey.pem" {
2832 t.Errorf("private key %q is not %q", keys.privateKeyFile.String(),
Jiyong Park9335a262018-12-24 11:31:58 +09002833 "vendor/foo/devkeys/testkey.pem")
2834 }
2835
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002836 // check the APK certs. It should be overridden to myapex.certificate.override
Sundong Ahnabb64432019-10-22 13:58:29 +09002837 certs := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk").Args["certificates"]
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002838 if certs != "testkey.override.x509.pem testkey.override.pk8" {
Jiyong Park9335a262018-12-24 11:31:58 +09002839 t.Errorf("cert and private key %q are not %q", certs,
Jiyong Parkb2742fd2019-02-11 11:38:15 +09002840 "testkey.override.509.pem testkey.override.pk8")
Jiyong Park9335a262018-12-24 11:31:58 +09002841 }
2842}
Jiyong Park58e364a2019-01-19 19:24:06 +09002843
Jooyung Hanf121a652019-12-17 14:30:11 +09002844func TestCertificate(t *testing.T) {
2845 t.Run("if unspecified, it defaults to DefaultAppCertificate", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002846 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09002847 apex {
2848 name: "myapex",
2849 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002850 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09002851 }
2852 apex_key {
2853 name: "myapex.key",
2854 public_key: "testkey.avbpubkey",
2855 private_key: "testkey.pem",
2856 }`)
2857 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
2858 expected := "vendor/foo/devkeys/test.x509.pem vendor/foo/devkeys/test.pk8"
2859 if actual := rule.Args["certificates"]; actual != expected {
2860 t.Errorf("certificates should be %q, not %q", expected, actual)
2861 }
2862 })
2863 t.Run("override when unspecified", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002864 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09002865 apex {
2866 name: "myapex_keytest",
2867 key: "myapex.key",
2868 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002869 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09002870 }
2871 apex_key {
2872 name: "myapex.key",
2873 public_key: "testkey.avbpubkey",
2874 private_key: "testkey.pem",
2875 }
2876 android_app_certificate {
2877 name: "myapex.certificate.override",
2878 certificate: "testkey.override",
2879 }`)
2880 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
2881 expected := "testkey.override.x509.pem testkey.override.pk8"
2882 if actual := rule.Args["certificates"]; actual != expected {
2883 t.Errorf("certificates should be %q, not %q", expected, actual)
2884 }
2885 })
2886 t.Run("if specified as :module, it respects the prop", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002887 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09002888 apex {
2889 name: "myapex",
2890 key: "myapex.key",
2891 certificate: ":myapex.certificate",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002892 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09002893 }
2894 apex_key {
2895 name: "myapex.key",
2896 public_key: "testkey.avbpubkey",
2897 private_key: "testkey.pem",
2898 }
2899 android_app_certificate {
2900 name: "myapex.certificate",
2901 certificate: "testkey",
2902 }`)
2903 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
2904 expected := "testkey.x509.pem testkey.pk8"
2905 if actual := rule.Args["certificates"]; actual != expected {
2906 t.Errorf("certificates should be %q, not %q", expected, actual)
2907 }
2908 })
2909 t.Run("override when specifiec as <:module>", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002910 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09002911 apex {
2912 name: "myapex_keytest",
2913 key: "myapex.key",
2914 file_contexts: ":myapex-file_contexts",
2915 certificate: ":myapex.certificate",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002916 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09002917 }
2918 apex_key {
2919 name: "myapex.key",
2920 public_key: "testkey.avbpubkey",
2921 private_key: "testkey.pem",
2922 }
2923 android_app_certificate {
2924 name: "myapex.certificate.override",
2925 certificate: "testkey.override",
2926 }`)
2927 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
2928 expected := "testkey.override.x509.pem testkey.override.pk8"
2929 if actual := rule.Args["certificates"]; actual != expected {
2930 t.Errorf("certificates should be %q, not %q", expected, actual)
2931 }
2932 })
2933 t.Run("if specified as name, finds it from DefaultDevKeyDir", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002934 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09002935 apex {
2936 name: "myapex",
2937 key: "myapex.key",
2938 certificate: "testkey",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002939 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09002940 }
2941 apex_key {
2942 name: "myapex.key",
2943 public_key: "testkey.avbpubkey",
2944 private_key: "testkey.pem",
2945 }`)
2946 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
2947 expected := "vendor/foo/devkeys/testkey.x509.pem vendor/foo/devkeys/testkey.pk8"
2948 if actual := rule.Args["certificates"]; actual != expected {
2949 t.Errorf("certificates should be %q, not %q", expected, actual)
2950 }
2951 })
2952 t.Run("override when specified as <name>", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002953 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09002954 apex {
2955 name: "myapex_keytest",
2956 key: "myapex.key",
2957 file_contexts: ":myapex-file_contexts",
2958 certificate: "testkey",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002959 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09002960 }
2961 apex_key {
2962 name: "myapex.key",
2963 public_key: "testkey.avbpubkey",
2964 private_key: "testkey.pem",
2965 }
2966 android_app_certificate {
2967 name: "myapex.certificate.override",
2968 certificate: "testkey.override",
2969 }`)
2970 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
2971 expected := "testkey.override.x509.pem testkey.override.pk8"
2972 if actual := rule.Args["certificates"]; actual != expected {
2973 t.Errorf("certificates should be %q, not %q", expected, actual)
2974 }
2975 })
2976}
2977
Jiyong Park58e364a2019-01-19 19:24:06 +09002978func TestMacro(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002979 ctx := testApex(t, `
Jiyong Park58e364a2019-01-19 19:24:06 +09002980 apex {
2981 name: "myapex",
2982 key: "myapex.key",
Jooyung Hanc87a0592020-03-02 17:44:33 +09002983 native_shared_libs: ["mylib", "mylib2"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002984 updatable: false,
Jiyong Park58e364a2019-01-19 19:24:06 +09002985 }
2986
2987 apex {
2988 name: "otherapex",
2989 key: "myapex.key",
Jooyung Hanc87a0592020-03-02 17:44:33 +09002990 native_shared_libs: ["mylib", "mylib2"],
Jooyung Hanccce2f22020-03-07 03:45:53 +09002991 min_sdk_version: "29",
Jiyong Park58e364a2019-01-19 19:24:06 +09002992 }
2993
2994 apex_key {
2995 name: "myapex.key",
2996 public_key: "testkey.avbpubkey",
2997 private_key: "testkey.pem",
2998 }
2999
3000 cc_library {
3001 name: "mylib",
3002 srcs: ["mylib.cpp"],
3003 system_shared_libs: [],
3004 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003005 apex_available: [
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003006 "myapex",
3007 "otherapex",
3008 ],
Jooyung Han24282772020-03-21 23:20:55 +09003009 recovery_available: true,
Jooyung Han749dc692020-04-15 11:03:39 +09003010 min_sdk_version: "29",
Jiyong Park58e364a2019-01-19 19:24:06 +09003011 }
Jooyung Hanc87a0592020-03-02 17:44:33 +09003012 cc_library {
3013 name: "mylib2",
3014 srcs: ["mylib.cpp"],
3015 system_shared_libs: [],
3016 stl: "none",
3017 apex_available: [
3018 "myapex",
3019 "otherapex",
3020 ],
Colin Crossaede88c2020-08-11 12:17:01 -07003021 static_libs: ["mylib3"],
3022 recovery_available: true,
3023 min_sdk_version: "29",
3024 }
3025 cc_library {
3026 name: "mylib3",
3027 srcs: ["mylib.cpp"],
3028 system_shared_libs: [],
3029 stl: "none",
3030 apex_available: [
3031 "myapex",
3032 "otherapex",
3033 ],
Jooyung Hanc87a0592020-03-02 17:44:33 +09003034 use_apex_name_macro: true,
Colin Crossaede88c2020-08-11 12:17:01 -07003035 recovery_available: true,
Jooyung Han749dc692020-04-15 11:03:39 +09003036 min_sdk_version: "29",
Jooyung Hanc87a0592020-03-02 17:44:33 +09003037 }
Jiyong Park58e364a2019-01-19 19:24:06 +09003038 `)
3039
Jooyung Hanc87a0592020-03-02 17:44:33 +09003040 // non-APEX variant does not have __ANDROID_APEX__ defined
Colin Cross7113d202019-11-20 16:39:12 -08003041 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09003042 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003043 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
Jooyung Hanc87a0592020-03-02 17:44:33 +09003044
Jooyung Hanccce2f22020-03-07 03:45:53 +09003045 // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
Colin Crossaede88c2020-08-11 12:17:01 -07003046 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
Jooyung Hanc87a0592020-03-02 17:44:33 +09003047 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003048 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=10000")
Jooyung Han77988572019-10-18 16:26:16 +09003049 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
Jooyung Hanc87a0592020-03-02 17:44:33 +09003050
Jooyung Hanccce2f22020-03-07 03:45:53 +09003051 // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
Colin Crossaede88c2020-08-11 12:17:01 -07003052 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex29").Rule("cc").Args["cFlags"]
Jooyung Hanc87a0592020-03-02 17:44:33 +09003053 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003054 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=29")
Jooyung Han77988572019-10-18 16:26:16 +09003055 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09003056
Colin Crossaede88c2020-08-11 12:17:01 -07003057 // When a cc_library sets use_apex_name_macro: true each apex gets a unique variant and
3058 // each variant defines additional macros to distinguish which apex variant it is built for
3059
3060 // non-APEX variant does not have __ANDROID_APEX__ defined
3061 mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
3062 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3063
3064 // APEX variant has __ANDROID_APEX__ defined
3065 mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"]
3066 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3067 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
3068 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
3069
3070 // APEX variant has __ANDROID_APEX__ defined
3071 mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static_otherapex").Rule("cc").Args["cFlags"]
3072 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3073 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
3074 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
3075
Dan Albertb19953d2020-11-17 15:29:36 -08003076 // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__
Colin Crossaede88c2020-08-11 12:17:01 -07003077 mylibCFlags = ctx.ModuleForTests("mylib3", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
3078 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003079 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
Colin Crossaede88c2020-08-11 12:17:01 -07003080
3081 // When a dependency of a cc_library sets use_apex_name_macro: true each apex gets a unique
3082 // variant.
Jooyung Hanc87a0592020-03-02 17:44:33 +09003083
3084 // non-APEX variant does not have __ANDROID_APEX__ defined
3085 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
3086 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3087
3088 // APEX variant has __ANDROID_APEX__ defined
3089 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09003090 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Colin Crossaede88c2020-08-11 12:17:01 -07003091 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
Jooyung Han77988572019-10-18 16:26:16 +09003092 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09003093
Jooyung Hanc87a0592020-03-02 17:44:33 +09003094 // APEX variant has __ANDROID_APEX__ defined
3095 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_otherapex").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09003096 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Han77988572019-10-18 16:26:16 +09003097 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
Colin Crossaede88c2020-08-11 12:17:01 -07003098 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jooyung Han24282772020-03-21 23:20:55 +09003099
Dan Albertb19953d2020-11-17 15:29:36 -08003100 // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__
Colin Crossaede88c2020-08-11 12:17:01 -07003101 mylibCFlags = ctx.ModuleForTests("mylib2", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jooyung Han24282772020-03-21 23:20:55 +09003102 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Dan Albertb19953d2020-11-17 15:29:36 -08003103 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
Jiyong Park58e364a2019-01-19 19:24:06 +09003104}
Jiyong Park7e636d02019-01-28 16:16:54 +09003105
3106func TestHeaderLibsDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003107 ctx := testApex(t, `
Jiyong Park7e636d02019-01-28 16:16:54 +09003108 apex {
3109 name: "myapex",
3110 key: "myapex.key",
3111 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003112 updatable: false,
Jiyong Park7e636d02019-01-28 16:16:54 +09003113 }
3114
3115 apex_key {
3116 name: "myapex.key",
3117 public_key: "testkey.avbpubkey",
3118 private_key: "testkey.pem",
3119 }
3120
3121 cc_library_headers {
3122 name: "mylib_headers",
3123 export_include_dirs: ["my_include"],
3124 system_shared_libs: [],
3125 stl: "none",
Jiyong Park0f80c182020-01-31 02:49:53 +09003126 apex_available: [ "myapex" ],
Jiyong Park7e636d02019-01-28 16:16:54 +09003127 }
3128
3129 cc_library {
3130 name: "mylib",
3131 srcs: ["mylib.cpp"],
3132 system_shared_libs: [],
3133 stl: "none",
3134 header_libs: ["mylib_headers"],
3135 export_header_lib_headers: ["mylib_headers"],
3136 stubs: {
3137 versions: ["1", "2", "3"],
3138 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003139 apex_available: [ "myapex" ],
Jiyong Park7e636d02019-01-28 16:16:54 +09003140 }
3141
3142 cc_library {
3143 name: "otherlib",
3144 srcs: ["mylib.cpp"],
3145 system_shared_libs: [],
3146 stl: "none",
3147 shared_libs: ["mylib"],
3148 }
3149 `)
3150
Colin Cross7113d202019-11-20 16:39:12 -08003151 cFlags := ctx.ModuleForTests("otherlib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jiyong Park7e636d02019-01-28 16:16:54 +09003152
3153 // Ensure that the include path of the header lib is exported to 'otherlib'
3154 ensureContains(t, cFlags, "-Imy_include")
3155}
Alex Light9670d332019-01-29 18:07:33 -08003156
Jiyong Park7cd10e32020-01-14 09:22:18 +09003157type fileInApex struct {
3158 path string // path in apex
Jooyung Hana57af4a2020-01-23 05:36:59 +00003159 src string // src path
Jiyong Park7cd10e32020-01-14 09:22:18 +09003160 isLink bool
3161}
3162
Jooyung Hana57af4a2020-01-23 05:36:59 +00003163func getFiles(t *testing.T, ctx *android.TestContext, moduleName, variant string) []fileInApex {
Jooyung Han31c470b2019-10-18 16:26:59 +09003164 t.Helper()
Jooyung Hana57af4a2020-01-23 05:36:59 +00003165 apexRule := ctx.ModuleForTests(moduleName, variant).Rule("apexRule")
Jooyung Han31c470b2019-10-18 16:26:59 +09003166 copyCmds := apexRule.Args["copy_commands"]
3167 imageApexDir := "/image.apex/"
Jiyong Park7cd10e32020-01-14 09:22:18 +09003168 var ret []fileInApex
Jooyung Han31c470b2019-10-18 16:26:59 +09003169 for _, cmd := range strings.Split(copyCmds, "&&") {
3170 cmd = strings.TrimSpace(cmd)
3171 if cmd == "" {
3172 continue
3173 }
3174 terms := strings.Split(cmd, " ")
Jooyung Hana57af4a2020-01-23 05:36:59 +00003175 var dst, src string
Jiyong Park7cd10e32020-01-14 09:22:18 +09003176 var isLink bool
Jooyung Han31c470b2019-10-18 16:26:59 +09003177 switch terms[0] {
3178 case "mkdir":
3179 case "cp":
Jiyong Park7cd10e32020-01-14 09:22:18 +09003180 if len(terms) != 3 && len(terms) != 4 {
Jooyung Han31c470b2019-10-18 16:26:59 +09003181 t.Fatal("copyCmds contains invalid cp command", cmd)
3182 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09003183 dst = terms[len(terms)-1]
Jooyung Hana57af4a2020-01-23 05:36:59 +00003184 src = terms[len(terms)-2]
Jiyong Park7cd10e32020-01-14 09:22:18 +09003185 isLink = false
3186 case "ln":
3187 if len(terms) != 3 && len(terms) != 4 {
3188 // ln LINK TARGET or ln -s LINK TARGET
3189 t.Fatal("copyCmds contains invalid ln command", cmd)
3190 }
3191 dst = terms[len(terms)-1]
Jooyung Hana57af4a2020-01-23 05:36:59 +00003192 src = terms[len(terms)-2]
Jiyong Park7cd10e32020-01-14 09:22:18 +09003193 isLink = true
3194 default:
3195 t.Fatalf("copyCmds should contain mkdir/cp commands only: %q", cmd)
3196 }
3197 if dst != "" {
Jooyung Han31c470b2019-10-18 16:26:59 +09003198 index := strings.Index(dst, imageApexDir)
3199 if index == -1 {
3200 t.Fatal("copyCmds should copy a file to image.apex/", cmd)
3201 }
3202 dstFile := dst[index+len(imageApexDir):]
Jooyung Hana57af4a2020-01-23 05:36:59 +00003203 ret = append(ret, fileInApex{path: dstFile, src: src, isLink: isLink})
Jooyung Han31c470b2019-10-18 16:26:59 +09003204 }
3205 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09003206 return ret
3207}
3208
Jooyung Hana57af4a2020-01-23 05:36:59 +00003209func ensureExactContents(t *testing.T, ctx *android.TestContext, moduleName, variant string, files []string) {
3210 t.Helper()
Jiyong Park7cd10e32020-01-14 09:22:18 +09003211 var failed bool
3212 var surplus []string
3213 filesMatched := make(map[string]bool)
Jooyung Hana57af4a2020-01-23 05:36:59 +00003214 for _, file := range getFiles(t, ctx, moduleName, variant) {
Jooyung Hane6436d72020-02-27 13:31:56 +09003215 mactchFound := false
Jiyong Park7cd10e32020-01-14 09:22:18 +09003216 for _, expected := range files {
3217 if matched, _ := path.Match(expected, file.path); matched {
3218 filesMatched[expected] = true
Jooyung Hane6436d72020-02-27 13:31:56 +09003219 mactchFound = true
3220 break
Jiyong Park7cd10e32020-01-14 09:22:18 +09003221 }
3222 }
Jooyung Hane6436d72020-02-27 13:31:56 +09003223 if !mactchFound {
3224 surplus = append(surplus, file.path)
3225 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09003226 }
Jooyung Han31c470b2019-10-18 16:26:59 +09003227
Jooyung Han31c470b2019-10-18 16:26:59 +09003228 if len(surplus) > 0 {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003229 sort.Strings(surplus)
Jooyung Han31c470b2019-10-18 16:26:59 +09003230 t.Log("surplus files", surplus)
3231 failed = true
3232 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003233
3234 if len(files) > len(filesMatched) {
3235 var missing []string
3236 for _, expected := range files {
3237 if !filesMatched[expected] {
3238 missing = append(missing, expected)
3239 }
3240 }
3241 sort.Strings(missing)
Jooyung Han31c470b2019-10-18 16:26:59 +09003242 t.Log("missing files", missing)
3243 failed = true
3244 }
3245 if failed {
3246 t.Fail()
3247 }
3248}
3249
Jooyung Han344d5432019-08-23 11:17:39 +09003250func TestVndkApexCurrent(t *testing.T) {
Jooyung Han7d6e79b2021-06-24 01:53:43 +09003251 commonFiles := []string{
Jooyung Hane6436d72020-02-27 13:31:56 +09003252 "lib/libc++.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09003253 "lib64/libc++.so",
Jiyong Parkf58c46e2021-04-01 21:35:20 +09003254 "etc/llndk.libraries.29.txt",
3255 "etc/vndkcore.libraries.29.txt",
3256 "etc/vndksp.libraries.29.txt",
3257 "etc/vndkprivate.libraries.29.txt",
3258 "etc/vndkproduct.libraries.29.txt",
Jooyung Han7d6e79b2021-06-24 01:53:43 +09003259 }
3260 testCases := []struct {
3261 vndkVersion string
3262 expectedFiles []string
3263 }{
3264 {
3265 vndkVersion: "current",
3266 expectedFiles: append(commonFiles,
3267 "lib/libvndk.so",
3268 "lib/libvndksp.so",
3269 "lib64/libvndk.so",
3270 "lib64/libvndksp.so"),
3271 },
3272 {
3273 vndkVersion: "",
3274 expectedFiles: append(commonFiles,
3275 // Legacy VNDK APEX contains only VNDK-SP files (of core variant)
3276 "lib/libvndksp.so",
3277 "lib64/libvndksp.so"),
3278 },
3279 }
3280 for _, tc := range testCases {
3281 t.Run("VNDK.current with DeviceVndkVersion="+tc.vndkVersion, func(t *testing.T) {
3282 ctx := testApex(t, `
3283 apex_vndk {
3284 name: "com.android.vndk.current",
3285 key: "com.android.vndk.current.key",
3286 updatable: false,
3287 }
3288
3289 apex_key {
3290 name: "com.android.vndk.current.key",
3291 public_key: "testkey.avbpubkey",
3292 private_key: "testkey.pem",
3293 }
3294
3295 cc_library {
3296 name: "libvndk",
3297 srcs: ["mylib.cpp"],
3298 vendor_available: true,
3299 product_available: true,
3300 vndk: {
3301 enabled: true,
3302 },
3303 system_shared_libs: [],
3304 stl: "none",
3305 apex_available: [ "com.android.vndk.current" ],
3306 }
3307
3308 cc_library {
3309 name: "libvndksp",
3310 srcs: ["mylib.cpp"],
3311 vendor_available: true,
3312 product_available: true,
3313 vndk: {
3314 enabled: true,
3315 support_system_process: true,
3316 },
3317 system_shared_libs: [],
3318 stl: "none",
3319 apex_available: [ "com.android.vndk.current" ],
3320 }
3321
3322 // VNDK-Ext should not cause any problems
3323
3324 cc_library {
3325 name: "libvndk.ext",
3326 srcs: ["mylib2.cpp"],
3327 vendor: true,
3328 vndk: {
3329 enabled: true,
3330 extends: "libvndk",
3331 },
3332 system_shared_libs: [],
3333 stl: "none",
3334 }
3335
3336 cc_library {
3337 name: "libvndksp.ext",
3338 srcs: ["mylib2.cpp"],
3339 vendor: true,
3340 vndk: {
3341 enabled: true,
3342 support_system_process: true,
3343 extends: "libvndksp",
3344 },
3345 system_shared_libs: [],
3346 stl: "none",
3347 }
3348 `+vndkLibrariesTxtFiles("current"), android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
3349 variables.DeviceVndkVersion = proptools.StringPtr(tc.vndkVersion)
3350 }))
3351 ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", tc.expectedFiles)
3352 })
3353 }
Jooyung Han344d5432019-08-23 11:17:39 +09003354}
3355
3356func TestVndkApexWithPrebuilt(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003357 ctx := testApex(t, `
Jooyung Han344d5432019-08-23 11:17:39 +09003358 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003359 name: "com.android.vndk.current",
3360 key: "com.android.vndk.current.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003361 updatable: false,
Jooyung Han344d5432019-08-23 11:17:39 +09003362 }
3363
3364 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003365 name: "com.android.vndk.current.key",
Jooyung Han344d5432019-08-23 11:17:39 +09003366 public_key: "testkey.avbpubkey",
3367 private_key: "testkey.pem",
3368 }
3369
3370 cc_prebuilt_library_shared {
Jooyung Han31c470b2019-10-18 16:26:59 +09003371 name: "libvndk",
3372 srcs: ["libvndk.so"],
Jooyung Han344d5432019-08-23 11:17:39 +09003373 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003374 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003375 vndk: {
3376 enabled: true,
3377 },
3378 system_shared_libs: [],
3379 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003380 apex_available: [ "com.android.vndk.current" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003381 }
Jooyung Han31c470b2019-10-18 16:26:59 +09003382
3383 cc_prebuilt_library_shared {
3384 name: "libvndk.arm",
3385 srcs: ["libvndk.arm.so"],
3386 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003387 product_available: true,
Jooyung Han31c470b2019-10-18 16:26:59 +09003388 vndk: {
3389 enabled: true,
3390 },
3391 enabled: false,
3392 arch: {
3393 arm: {
3394 enabled: true,
3395 },
3396 },
3397 system_shared_libs: [],
3398 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003399 apex_available: [ "com.android.vndk.current" ],
Jooyung Han31c470b2019-10-18 16:26:59 +09003400 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003401 `+vndkLibrariesTxtFiles("current"),
3402 withFiles(map[string][]byte{
3403 "libvndk.so": nil,
3404 "libvndk.arm.so": nil,
3405 }))
Colin Cross2807f002021-03-02 10:15:29 -08003406 ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003407 "lib/libvndk.so",
3408 "lib/libvndk.arm.so",
3409 "lib64/libvndk.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09003410 "lib/libc++.so",
3411 "lib64/libc++.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003412 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003413 })
Jooyung Han344d5432019-08-23 11:17:39 +09003414}
3415
Jooyung Han39edb6c2019-11-06 16:53:07 +09003416func vndkLibrariesTxtFiles(vers ...string) (result string) {
3417 for _, v := range vers {
3418 if v == "current" {
Justin Yun8a2600c2020-12-07 12:44:03 +09003419 for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003420 result += `
Colin Crosse4e44bc2020-12-28 13:50:21 -08003421 ` + txt + `_libraries_txt {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003422 name: "` + txt + `.libraries.txt",
3423 }
3424 `
3425 }
3426 } else {
Justin Yun8a2600c2020-12-07 12:44:03 +09003427 for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003428 result += `
3429 prebuilt_etc {
3430 name: "` + txt + `.libraries.` + v + `.txt",
3431 src: "dummy.txt",
3432 }
3433 `
3434 }
3435 }
3436 }
3437 return
3438}
3439
Jooyung Han344d5432019-08-23 11:17:39 +09003440func TestVndkApexVersion(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003441 ctx := testApex(t, `
Jooyung Han344d5432019-08-23 11:17:39 +09003442 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003443 name: "com.android.vndk.v27",
Jooyung Han344d5432019-08-23 11:17:39 +09003444 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003445 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09003446 vndk_version: "27",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003447 updatable: false,
Jooyung Han344d5432019-08-23 11:17:39 +09003448 }
3449
3450 apex_key {
3451 name: "myapex.key",
3452 public_key: "testkey.avbpubkey",
3453 private_key: "testkey.pem",
3454 }
3455
Jooyung Han31c470b2019-10-18 16:26:59 +09003456 vndk_prebuilt_shared {
3457 name: "libvndk27",
3458 version: "27",
Jooyung Han344d5432019-08-23 11:17:39 +09003459 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003460 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003461 vndk: {
3462 enabled: true,
3463 },
Jooyung Han31c470b2019-10-18 16:26:59 +09003464 target_arch: "arm64",
3465 arch: {
3466 arm: {
3467 srcs: ["libvndk27_arm.so"],
3468 },
3469 arm64: {
3470 srcs: ["libvndk27_arm64.so"],
3471 },
3472 },
Colin Cross2807f002021-03-02 10:15:29 -08003473 apex_available: [ "com.android.vndk.v27" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003474 }
3475
3476 vndk_prebuilt_shared {
3477 name: "libvndk27",
3478 version: "27",
3479 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003480 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003481 vndk: {
3482 enabled: true,
3483 },
Jooyung Han31c470b2019-10-18 16:26:59 +09003484 target_arch: "x86_64",
3485 arch: {
3486 x86: {
3487 srcs: ["libvndk27_x86.so"],
3488 },
3489 x86_64: {
3490 srcs: ["libvndk27_x86_64.so"],
3491 },
3492 },
Jooyung Han39edb6c2019-11-06 16:53:07 +09003493 }
3494 `+vndkLibrariesTxtFiles("27"),
3495 withFiles(map[string][]byte{
3496 "libvndk27_arm.so": nil,
3497 "libvndk27_arm64.so": nil,
3498 "libvndk27_x86.so": nil,
3499 "libvndk27_x86_64.so": nil,
3500 }))
Jooyung Han344d5432019-08-23 11:17:39 +09003501
Colin Cross2807f002021-03-02 10:15:29 -08003502 ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003503 "lib/libvndk27_arm.so",
3504 "lib64/libvndk27_arm64.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003505 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003506 })
Jooyung Han344d5432019-08-23 11:17:39 +09003507}
3508
Jooyung Han90eee022019-10-01 20:02:42 +09003509func TestVndkApexNameRule(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003510 ctx := testApex(t, `
Jooyung Han90eee022019-10-01 20:02:42 +09003511 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003512 name: "com.android.vndk.current",
Jooyung Han90eee022019-10-01 20:02:42 +09003513 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003514 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003515 updatable: false,
Jooyung Han90eee022019-10-01 20:02:42 +09003516 }
3517 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003518 name: "com.android.vndk.v28",
Jooyung Han90eee022019-10-01 20:02:42 +09003519 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003520 file_contexts: ":myapex-file_contexts",
Jooyung Han90eee022019-10-01 20:02:42 +09003521 vndk_version: "28",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003522 updatable: false,
Jooyung Han90eee022019-10-01 20:02:42 +09003523 }
3524 apex_key {
3525 name: "myapex.key",
3526 public_key: "testkey.avbpubkey",
3527 private_key: "testkey.pem",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003528 }`+vndkLibrariesTxtFiles("28", "current"))
Jooyung Han90eee022019-10-01 20:02:42 +09003529
3530 assertApexName := func(expected, moduleName string) {
Jooyung Hana57af4a2020-01-23 05:36:59 +00003531 bundle := ctx.ModuleForTests(moduleName, "android_common_image").Module().(*apexBundle)
Jooyung Han90eee022019-10-01 20:02:42 +09003532 actual := proptools.String(bundle.properties.Apex_name)
3533 if !reflect.DeepEqual(actual, expected) {
3534 t.Errorf("Got '%v', expected '%v'", actual, expected)
3535 }
3536 }
3537
Jiyong Parkf58c46e2021-04-01 21:35:20 +09003538 assertApexName("com.android.vndk.v29", "com.android.vndk.current")
Colin Cross2807f002021-03-02 10:15:29 -08003539 assertApexName("com.android.vndk.v28", "com.android.vndk.v28")
Jooyung Han90eee022019-10-01 20:02:42 +09003540}
3541
Jooyung Han344d5432019-08-23 11:17:39 +09003542func TestVndkApexSkipsNativeBridgeSupportedModules(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003543 ctx := testApex(t, `
Jooyung Han344d5432019-08-23 11:17:39 +09003544 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003545 name: "com.android.vndk.current",
3546 key: "com.android.vndk.current.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003547 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003548 updatable: false,
Jooyung Han344d5432019-08-23 11:17:39 +09003549 }
3550
3551 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003552 name: "com.android.vndk.current.key",
Jooyung Han344d5432019-08-23 11:17:39 +09003553 public_key: "testkey.avbpubkey",
3554 private_key: "testkey.pem",
3555 }
3556
3557 cc_library {
3558 name: "libvndk",
3559 srcs: ["mylib.cpp"],
3560 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003561 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003562 native_bridge_supported: true,
3563 host_supported: true,
3564 vndk: {
3565 enabled: true,
3566 },
3567 system_shared_libs: [],
3568 stl: "none",
Colin Cross2807f002021-03-02 10:15:29 -08003569 apex_available: [ "com.android.vndk.current" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003570 }
Colin Cross2807f002021-03-02 10:15:29 -08003571 `+vndkLibrariesTxtFiles("current"),
3572 withNativeBridgeEnabled)
Jooyung Han344d5432019-08-23 11:17:39 +09003573
Colin Cross2807f002021-03-02 10:15:29 -08003574 ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003575 "lib/libvndk.so",
3576 "lib64/libvndk.so",
Jooyung Hane6436d72020-02-27 13:31:56 +09003577 "lib/libc++.so",
3578 "lib64/libc++.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003579 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003580 })
Jooyung Han344d5432019-08-23 11:17:39 +09003581}
3582
3583func TestVndkApexDoesntSupportNativeBridgeSupported(t *testing.T) {
Colin Cross2807f002021-03-02 10:15:29 -08003584 testApexError(t, `module "com.android.vndk.current" .*: native_bridge_supported: .* doesn't support native bridge binary`, `
Jooyung Han344d5432019-08-23 11:17:39 +09003585 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003586 name: "com.android.vndk.current",
3587 key: "com.android.vndk.current.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003588 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09003589 native_bridge_supported: true,
3590 }
3591
3592 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003593 name: "com.android.vndk.current.key",
Jooyung Han344d5432019-08-23 11:17:39 +09003594 public_key: "testkey.avbpubkey",
3595 private_key: "testkey.pem",
3596 }
3597
3598 cc_library {
3599 name: "libvndk",
3600 srcs: ["mylib.cpp"],
3601 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003602 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003603 native_bridge_supported: true,
3604 host_supported: true,
3605 vndk: {
3606 enabled: true,
3607 },
3608 system_shared_libs: [],
3609 stl: "none",
3610 }
3611 `)
3612}
3613
Jooyung Han31c470b2019-10-18 16:26:59 +09003614func TestVndkApexWithBinder32(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003615 ctx := testApex(t, `
Jooyung Han31c470b2019-10-18 16:26:59 +09003616 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003617 name: "com.android.vndk.v27",
Jooyung Han31c470b2019-10-18 16:26:59 +09003618 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003619 file_contexts: ":myapex-file_contexts",
Jooyung Han31c470b2019-10-18 16:26:59 +09003620 vndk_version: "27",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003621 updatable: false,
Jooyung Han31c470b2019-10-18 16:26:59 +09003622 }
3623
3624 apex_key {
3625 name: "myapex.key",
3626 public_key: "testkey.avbpubkey",
3627 private_key: "testkey.pem",
3628 }
3629
3630 vndk_prebuilt_shared {
3631 name: "libvndk27",
3632 version: "27",
3633 target_arch: "arm",
3634 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003635 product_available: true,
Jooyung Han31c470b2019-10-18 16:26:59 +09003636 vndk: {
3637 enabled: true,
3638 },
3639 arch: {
3640 arm: {
3641 srcs: ["libvndk27.so"],
3642 }
3643 },
3644 }
3645
3646 vndk_prebuilt_shared {
3647 name: "libvndk27",
3648 version: "27",
3649 target_arch: "arm",
3650 binder32bit: true,
3651 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003652 product_available: true,
Jooyung Han31c470b2019-10-18 16:26:59 +09003653 vndk: {
3654 enabled: true,
3655 },
3656 arch: {
3657 arm: {
3658 srcs: ["libvndk27binder32.so"],
3659 }
3660 },
Colin Cross2807f002021-03-02 10:15:29 -08003661 apex_available: [ "com.android.vndk.v27" ],
Jooyung Han31c470b2019-10-18 16:26:59 +09003662 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003663 `+vndkLibrariesTxtFiles("27"),
Jooyung Han31c470b2019-10-18 16:26:59 +09003664 withFiles(map[string][]byte{
3665 "libvndk27.so": nil,
3666 "libvndk27binder32.so": nil,
3667 }),
3668 withBinder32bit,
3669 withTargets(map[android.OsType][]android.Target{
3670 android.Android: []android.Target{
Jooyung Han35155c42020-02-06 17:33:20 +09003671 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
3672 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
Jooyung Han31c470b2019-10-18 16:26:59 +09003673 },
3674 }),
3675 )
3676
Colin Cross2807f002021-03-02 10:15:29 -08003677 ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003678 "lib/libvndk27binder32.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003679 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003680 })
3681}
3682
Jooyung Han45a96772020-06-15 14:59:42 +09003683func TestVndkApexShouldNotProvideNativeLibs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003684 ctx := testApex(t, `
Jooyung Han45a96772020-06-15 14:59:42 +09003685 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003686 name: "com.android.vndk.current",
3687 key: "com.android.vndk.current.key",
Jooyung Han45a96772020-06-15 14:59:42 +09003688 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003689 updatable: false,
Jooyung Han45a96772020-06-15 14:59:42 +09003690 }
3691
3692 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003693 name: "com.android.vndk.current.key",
Jooyung Han45a96772020-06-15 14:59:42 +09003694 public_key: "testkey.avbpubkey",
3695 private_key: "testkey.pem",
3696 }
3697
3698 cc_library {
3699 name: "libz",
3700 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003701 product_available: true,
Jooyung Han45a96772020-06-15 14:59:42 +09003702 vndk: {
3703 enabled: true,
3704 },
3705 stubs: {
3706 symbol_file: "libz.map.txt",
3707 versions: ["30"],
3708 }
3709 }
3710 `+vndkLibrariesTxtFiles("current"), withFiles(map[string][]byte{
3711 "libz.map.txt": nil,
3712 }))
3713
Colin Cross2807f002021-03-02 10:15:29 -08003714 apexManifestRule := ctx.ModuleForTests("com.android.vndk.current", "android_common_image").Rule("apexManifestRule")
Jooyung Han45a96772020-06-15 14:59:42 +09003715 provideNativeLibs := names(apexManifestRule.Args["provideNativeLibs"])
3716 ensureListEmpty(t, provideNativeLibs)
3717}
3718
Jooyung Hane1633032019-08-01 17:41:43 +09003719func TestDependenciesInApexManifest(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003720 ctx := testApex(t, `
Jooyung Hane1633032019-08-01 17:41:43 +09003721 apex {
3722 name: "myapex_nodep",
3723 key: "myapex.key",
3724 native_shared_libs: ["lib_nodep"],
3725 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003726 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003727 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003728 }
3729
3730 apex {
3731 name: "myapex_dep",
3732 key: "myapex.key",
3733 native_shared_libs: ["lib_dep"],
3734 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003735 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003736 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003737 }
3738
3739 apex {
3740 name: "myapex_provider",
3741 key: "myapex.key",
3742 native_shared_libs: ["libfoo"],
3743 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003744 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003745 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003746 }
3747
3748 apex {
3749 name: "myapex_selfcontained",
3750 key: "myapex.key",
3751 native_shared_libs: ["lib_dep", "libfoo"],
3752 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003753 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003754 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003755 }
3756
3757 apex_key {
3758 name: "myapex.key",
3759 public_key: "testkey.avbpubkey",
3760 private_key: "testkey.pem",
3761 }
3762
3763 cc_library {
3764 name: "lib_nodep",
3765 srcs: ["mylib.cpp"],
3766 system_shared_libs: [],
3767 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003768 apex_available: [ "myapex_nodep" ],
Jooyung Hane1633032019-08-01 17:41:43 +09003769 }
3770
3771 cc_library {
3772 name: "lib_dep",
3773 srcs: ["mylib.cpp"],
3774 shared_libs: ["libfoo"],
3775 system_shared_libs: [],
3776 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003777 apex_available: [
3778 "myapex_dep",
3779 "myapex_provider",
3780 "myapex_selfcontained",
3781 ],
Jooyung Hane1633032019-08-01 17:41:43 +09003782 }
3783
3784 cc_library {
3785 name: "libfoo",
3786 srcs: ["mytest.cpp"],
3787 stubs: {
3788 versions: ["1"],
3789 },
3790 system_shared_libs: [],
3791 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003792 apex_available: [
3793 "myapex_provider",
3794 "myapex_selfcontained",
3795 ],
Jooyung Hane1633032019-08-01 17:41:43 +09003796 }
3797 `)
3798
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003799 var apexManifestRule android.TestingBuildParams
Jooyung Hane1633032019-08-01 17:41:43 +09003800 var provideNativeLibs, requireNativeLibs []string
3801
Sundong Ahnabb64432019-10-22 13:58:29 +09003802 apexManifestRule = ctx.ModuleForTests("myapex_nodep", "android_common_myapex_nodep_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003803 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3804 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003805 ensureListEmpty(t, provideNativeLibs)
3806 ensureListEmpty(t, requireNativeLibs)
3807
Sundong Ahnabb64432019-10-22 13:58:29 +09003808 apexManifestRule = ctx.ModuleForTests("myapex_dep", "android_common_myapex_dep_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003809 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3810 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003811 ensureListEmpty(t, provideNativeLibs)
3812 ensureListContains(t, requireNativeLibs, "libfoo.so")
3813
Sundong Ahnabb64432019-10-22 13:58:29 +09003814 apexManifestRule = ctx.ModuleForTests("myapex_provider", "android_common_myapex_provider_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003815 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3816 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003817 ensureListContains(t, provideNativeLibs, "libfoo.so")
3818 ensureListEmpty(t, requireNativeLibs)
3819
Sundong Ahnabb64432019-10-22 13:58:29 +09003820 apexManifestRule = ctx.ModuleForTests("myapex_selfcontained", "android_common_myapex_selfcontained_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003821 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3822 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003823 ensureListContains(t, provideNativeLibs, "libfoo.so")
3824 ensureListEmpty(t, requireNativeLibs)
3825}
3826
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003827func TestApexName(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003828 ctx := testApex(t, `
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003829 apex {
3830 name: "myapex",
3831 key: "myapex.key",
3832 apex_name: "com.android.myapex",
Jiyong Parkdb334862020-02-05 17:19:28 +09003833 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003834 updatable: false,
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003835 }
3836
3837 apex_key {
3838 name: "myapex.key",
3839 public_key: "testkey.avbpubkey",
3840 private_key: "testkey.pem",
3841 }
Jiyong Parkdb334862020-02-05 17:19:28 +09003842
3843 cc_library {
3844 name: "mylib",
3845 srcs: ["mylib.cpp"],
3846 system_shared_libs: [],
3847 stl: "none",
3848 apex_available: [
3849 "//apex_available:platform",
3850 "myapex",
3851 ],
3852 }
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003853 `)
3854
Sundong Ahnabb64432019-10-22 13:58:29 +09003855 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003856 apexManifestRule := module.Rule("apexManifestRule")
3857 ensureContains(t, apexManifestRule.Args["opt"], "-v name com.android.myapex")
3858 apexRule := module.Rule("apexRule")
3859 ensureContains(t, apexRule.Args["opt_flags"], "--do_not_check_keyname")
Jiyong Parkdb334862020-02-05 17:19:28 +09003860
3861 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07003862 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jiyong Parkdb334862020-02-05 17:19:28 +09003863 name := apexBundle.BaseModuleName()
3864 prefix := "TARGET_"
3865 var builder strings.Builder
3866 data.Custom(&builder, name, prefix, "", data)
3867 androidMk := builder.String()
3868 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
3869 ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003870}
3871
Alex Light0851b882019-02-07 13:20:53 -08003872func TestNonTestApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003873 ctx := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08003874 apex {
3875 name: "myapex",
3876 key: "myapex.key",
3877 native_shared_libs: ["mylib_common"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003878 updatable: false,
Alex Light0851b882019-02-07 13:20:53 -08003879 }
3880
3881 apex_key {
3882 name: "myapex.key",
3883 public_key: "testkey.avbpubkey",
3884 private_key: "testkey.pem",
3885 }
3886
3887 cc_library {
3888 name: "mylib_common",
3889 srcs: ["mylib.cpp"],
3890 system_shared_libs: [],
3891 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003892 apex_available: [
3893 "//apex_available:platform",
3894 "myapex",
3895 ],
Alex Light0851b882019-02-07 13:20:53 -08003896 }
3897 `)
3898
Sundong Ahnabb64432019-10-22 13:58:29 +09003899 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Alex Light0851b882019-02-07 13:20:53 -08003900 apexRule := module.Rule("apexRule")
3901 copyCmds := apexRule.Args["copy_commands"]
3902
3903 if apex, ok := module.Module().(*apexBundle); !ok || apex.testApex {
3904 t.Log("Apex was a test apex!")
3905 t.Fail()
3906 }
3907 // Ensure that main rule creates an output
3908 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
3909
3910 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -07003911 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
Alex Light0851b882019-02-07 13:20:53 -08003912
3913 // Ensure that both direct and indirect deps are copied into apex
3914 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
3915
Colin Cross7113d202019-11-20 16:39:12 -08003916 // Ensure that the platform variant ends with _shared
3917 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
Alex Light0851b882019-02-07 13:20:53 -08003918
Colin Cross56a83212020-09-15 18:30:11 -07003919 if !ctx.ModuleForTests("mylib_common", "android_arm64_armv8-a_shared_apex10000").Module().(*cc.Module).InAnyApex() {
Alex Light0851b882019-02-07 13:20:53 -08003920 t.Log("Found mylib_common not in any apex!")
3921 t.Fail()
3922 }
3923}
3924
3925func TestTestApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003926 ctx := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08003927 apex_test {
3928 name: "myapex",
3929 key: "myapex.key",
3930 native_shared_libs: ["mylib_common_test"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003931 updatable: false,
Alex Light0851b882019-02-07 13:20:53 -08003932 }
3933
3934 apex_key {
3935 name: "myapex.key",
3936 public_key: "testkey.avbpubkey",
3937 private_key: "testkey.pem",
3938 }
3939
3940 cc_library {
3941 name: "mylib_common_test",
3942 srcs: ["mylib.cpp"],
3943 system_shared_libs: [],
3944 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003945 // TODO: remove //apex_available:platform
3946 apex_available: [
3947 "//apex_available:platform",
3948 "myapex",
3949 ],
Alex Light0851b882019-02-07 13:20:53 -08003950 }
3951 `)
3952
Sundong Ahnabb64432019-10-22 13:58:29 +09003953 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Alex Light0851b882019-02-07 13:20:53 -08003954 apexRule := module.Rule("apexRule")
3955 copyCmds := apexRule.Args["copy_commands"]
3956
3957 if apex, ok := module.Module().(*apexBundle); !ok || !apex.testApex {
3958 t.Log("Apex was not a test apex!")
3959 t.Fail()
3960 }
3961 // Ensure that main rule creates an output
3962 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
3963
3964 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -07003965 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared_apex10000")
Alex Light0851b882019-02-07 13:20:53 -08003966
3967 // Ensure that both direct and indirect deps are copied into apex
3968 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common_test.so")
3969
Colin Cross7113d202019-11-20 16:39:12 -08003970 // Ensure that the platform variant ends with _shared
3971 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared")
Alex Light0851b882019-02-07 13:20:53 -08003972}
3973
Alex Light9670d332019-01-29 18:07:33 -08003974func TestApexWithTarget(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003975 ctx := testApex(t, `
Alex Light9670d332019-01-29 18:07:33 -08003976 apex {
3977 name: "myapex",
3978 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003979 updatable: false,
Alex Light9670d332019-01-29 18:07:33 -08003980 multilib: {
3981 first: {
3982 native_shared_libs: ["mylib_common"],
3983 }
3984 },
3985 target: {
3986 android: {
3987 multilib: {
3988 first: {
3989 native_shared_libs: ["mylib"],
3990 }
3991 }
3992 },
3993 host: {
3994 multilib: {
3995 first: {
3996 native_shared_libs: ["mylib2"],
3997 }
3998 }
3999 }
4000 }
4001 }
4002
4003 apex_key {
4004 name: "myapex.key",
4005 public_key: "testkey.avbpubkey",
4006 private_key: "testkey.pem",
4007 }
4008
4009 cc_library {
4010 name: "mylib",
4011 srcs: ["mylib.cpp"],
4012 system_shared_libs: [],
4013 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004014 // TODO: remove //apex_available:platform
4015 apex_available: [
4016 "//apex_available:platform",
4017 "myapex",
4018 ],
Alex Light9670d332019-01-29 18:07:33 -08004019 }
4020
4021 cc_library {
4022 name: "mylib_common",
4023 srcs: ["mylib.cpp"],
4024 system_shared_libs: [],
4025 stl: "none",
4026 compile_multilib: "first",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004027 // TODO: remove //apex_available:platform
4028 apex_available: [
4029 "//apex_available:platform",
4030 "myapex",
4031 ],
Alex Light9670d332019-01-29 18:07:33 -08004032 }
4033
4034 cc_library {
4035 name: "mylib2",
4036 srcs: ["mylib.cpp"],
4037 system_shared_libs: [],
4038 stl: "none",
4039 compile_multilib: "first",
4040 }
4041 `)
4042
Sundong Ahnabb64432019-10-22 13:58:29 +09004043 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Alex Light9670d332019-01-29 18:07:33 -08004044 copyCmds := apexRule.Args["copy_commands"]
4045
4046 // Ensure that main rule creates an output
4047 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
4048
4049 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -07004050 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
4051 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
4052 ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
Alex Light9670d332019-01-29 18:07:33 -08004053
4054 // Ensure that both direct and indirect deps are copied into apex
4055 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
4056 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
4057 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
4058
Colin Cross7113d202019-11-20 16:39:12 -08004059 // Ensure that the platform variant ends with _shared
4060 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
4061 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
4062 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
Alex Light9670d332019-01-29 18:07:33 -08004063}
Jiyong Park04480cf2019-02-06 00:16:29 +09004064
Jiyong Park59140302020-12-14 18:44:04 +09004065func TestApexWithArch(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004066 ctx := testApex(t, `
Jiyong Park59140302020-12-14 18:44:04 +09004067 apex {
4068 name: "myapex",
4069 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004070 updatable: false,
Jiyong Park59140302020-12-14 18:44:04 +09004071 arch: {
4072 arm64: {
4073 native_shared_libs: ["mylib.arm64"],
4074 },
4075 x86_64: {
4076 native_shared_libs: ["mylib.x64"],
4077 },
4078 }
4079 }
4080
4081 apex_key {
4082 name: "myapex.key",
4083 public_key: "testkey.avbpubkey",
4084 private_key: "testkey.pem",
4085 }
4086
4087 cc_library {
4088 name: "mylib.arm64",
4089 srcs: ["mylib.cpp"],
4090 system_shared_libs: [],
4091 stl: "none",
4092 // TODO: remove //apex_available:platform
4093 apex_available: [
4094 "//apex_available:platform",
4095 "myapex",
4096 ],
4097 }
4098
4099 cc_library {
4100 name: "mylib.x64",
4101 srcs: ["mylib.cpp"],
4102 system_shared_libs: [],
4103 stl: "none",
4104 // TODO: remove //apex_available:platform
4105 apex_available: [
4106 "//apex_available:platform",
4107 "myapex",
4108 ],
4109 }
4110 `)
4111
4112 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
4113 copyCmds := apexRule.Args["copy_commands"]
4114
4115 // Ensure that apex variant is created for the direct dep
4116 ensureListContains(t, ctx.ModuleVariantsForTests("mylib.arm64"), "android_arm64_armv8-a_shared_apex10000")
4117 ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib.x64"), "android_arm64_armv8-a_shared_apex10000")
4118
4119 // Ensure that both direct and indirect deps are copied into apex
4120 ensureContains(t, copyCmds, "image.apex/lib64/mylib.arm64.so")
4121 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib.x64.so")
4122}
4123
Jiyong Park04480cf2019-02-06 00:16:29 +09004124func TestApexWithShBinary(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004125 ctx := testApex(t, `
Jiyong Park04480cf2019-02-06 00:16:29 +09004126 apex {
4127 name: "myapex",
4128 key: "myapex.key",
4129 binaries: ["myscript"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004130 updatable: false,
Jiyong Park04480cf2019-02-06 00:16:29 +09004131 }
4132
4133 apex_key {
4134 name: "myapex.key",
4135 public_key: "testkey.avbpubkey",
4136 private_key: "testkey.pem",
4137 }
4138
4139 sh_binary {
4140 name: "myscript",
4141 src: "mylib.cpp",
4142 filename: "myscript.sh",
4143 sub_dir: "script",
4144 }
4145 `)
4146
Sundong Ahnabb64432019-10-22 13:58:29 +09004147 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park04480cf2019-02-06 00:16:29 +09004148 copyCmds := apexRule.Args["copy_commands"]
4149
4150 ensureContains(t, copyCmds, "image.apex/bin/script/myscript.sh")
4151}
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004152
Jooyung Han91df2082019-11-20 01:49:42 +09004153func TestApexInVariousPartition(t *testing.T) {
4154 testcases := []struct {
4155 propName, parition, flattenedPartition string
4156 }{
4157 {"", "system", "system_ext"},
4158 {"product_specific: true", "product", "product"},
4159 {"soc_specific: true", "vendor", "vendor"},
4160 {"proprietary: true", "vendor", "vendor"},
4161 {"vendor: true", "vendor", "vendor"},
4162 {"system_ext_specific: true", "system_ext", "system_ext"},
4163 }
4164 for _, tc := range testcases {
4165 t.Run(tc.propName+":"+tc.parition, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004166 ctx := testApex(t, `
Jooyung Han91df2082019-11-20 01:49:42 +09004167 apex {
4168 name: "myapex",
4169 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004170 updatable: false,
Jooyung Han91df2082019-11-20 01:49:42 +09004171 `+tc.propName+`
4172 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004173
Jooyung Han91df2082019-11-20 01:49:42 +09004174 apex_key {
4175 name: "myapex.key",
4176 public_key: "testkey.avbpubkey",
4177 private_key: "testkey.pem",
4178 }
4179 `)
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004180
Jooyung Han91df2082019-11-20 01:49:42 +09004181 apex := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Paul Duffin37ba3442021-03-29 00:21:08 +01004182 expected := "out/soong/target/product/test_device/" + tc.parition + "/apex"
4183 actual := apex.installDir.RelativeToTop().String()
Jooyung Han91df2082019-11-20 01:49:42 +09004184 if actual != expected {
4185 t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
4186 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004187
Jooyung Han91df2082019-11-20 01:49:42 +09004188 flattened := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
Paul Duffin37ba3442021-03-29 00:21:08 +01004189 expected = "out/soong/target/product/test_device/" + tc.flattenedPartition + "/apex"
4190 actual = flattened.installDir.RelativeToTop().String()
Jooyung Han91df2082019-11-20 01:49:42 +09004191 if actual != expected {
4192 t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
4193 }
4194 })
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004195 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004196}
Jiyong Park67882562019-03-21 01:11:21 +09004197
Jooyung Han580eb4f2020-06-24 19:33:06 +09004198func TestFileContexts_FindInDefaultLocationIfNotSet(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004199 ctx := testApex(t, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004200 apex {
4201 name: "myapex",
4202 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004203 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004204 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004205
Jooyung Han580eb4f2020-06-24 19:33:06 +09004206 apex_key {
4207 name: "myapex.key",
4208 public_key: "testkey.avbpubkey",
4209 private_key: "testkey.pem",
4210 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004211 `)
4212 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Han580eb4f2020-06-24 19:33:06 +09004213 rule := module.Output("file_contexts")
4214 ensureContains(t, rule.RuleParams.Command, "cat system/sepolicy/apex/myapex-file_contexts")
4215}
Jooyung Han54aca7b2019-11-20 02:26:02 +09004216
Jooyung Han580eb4f2020-06-24 19:33:06 +09004217func TestFileContexts_ShouldBeUnderSystemSepolicyForSystemApexes(t *testing.T) {
Jooyung Han54aca7b2019-11-20 02:26:02 +09004218 testApexError(t, `"myapex" .*: file_contexts: should be under system/sepolicy`, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004219 apex {
4220 name: "myapex",
4221 key: "myapex.key",
4222 file_contexts: "my_own_file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004223 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004224 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004225
Jooyung Han580eb4f2020-06-24 19:33:06 +09004226 apex_key {
4227 name: "myapex.key",
4228 public_key: "testkey.avbpubkey",
4229 private_key: "testkey.pem",
4230 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004231 `, withFiles(map[string][]byte{
4232 "my_own_file_contexts": nil,
4233 }))
Jooyung Han580eb4f2020-06-24 19:33:06 +09004234}
Jooyung Han54aca7b2019-11-20 02:26:02 +09004235
Jooyung Han580eb4f2020-06-24 19:33:06 +09004236func TestFileContexts_ProductSpecificApexes(t *testing.T) {
Jooyung Han54aca7b2019-11-20 02:26:02 +09004237 testApexError(t, `"myapex" .*: file_contexts: cannot find`, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004238 apex {
4239 name: "myapex",
4240 key: "myapex.key",
4241 product_specific: true,
4242 file_contexts: "product_specific_file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004243 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004244 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004245
Jooyung Han580eb4f2020-06-24 19:33:06 +09004246 apex_key {
4247 name: "myapex.key",
4248 public_key: "testkey.avbpubkey",
4249 private_key: "testkey.pem",
4250 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004251 `)
4252
Colin Cross1c460562021-02-16 17:55:47 -08004253 ctx := testApex(t, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004254 apex {
4255 name: "myapex",
4256 key: "myapex.key",
4257 product_specific: true,
4258 file_contexts: "product_specific_file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004259 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004260 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004261
Jooyung Han580eb4f2020-06-24 19:33:06 +09004262 apex_key {
4263 name: "myapex.key",
4264 public_key: "testkey.avbpubkey",
4265 private_key: "testkey.pem",
4266 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004267 `, withFiles(map[string][]byte{
4268 "product_specific_file_contexts": nil,
4269 }))
Jooyung Han580eb4f2020-06-24 19:33:06 +09004270 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
4271 rule := module.Output("file_contexts")
4272 ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
4273}
Jooyung Han54aca7b2019-11-20 02:26:02 +09004274
Jooyung Han580eb4f2020-06-24 19:33:06 +09004275func TestFileContexts_SetViaFileGroup(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004276 ctx := testApex(t, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004277 apex {
4278 name: "myapex",
4279 key: "myapex.key",
4280 product_specific: true,
4281 file_contexts: ":my-file-contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004282 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004283 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004284
Jooyung Han580eb4f2020-06-24 19:33:06 +09004285 apex_key {
4286 name: "myapex.key",
4287 public_key: "testkey.avbpubkey",
4288 private_key: "testkey.pem",
4289 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004290
Jooyung Han580eb4f2020-06-24 19:33:06 +09004291 filegroup {
4292 name: "my-file-contexts",
4293 srcs: ["product_specific_file_contexts"],
4294 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004295 `, withFiles(map[string][]byte{
4296 "product_specific_file_contexts": nil,
4297 }))
Jooyung Han580eb4f2020-06-24 19:33:06 +09004298 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
4299 rule := module.Output("file_contexts")
4300 ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
Jooyung Han54aca7b2019-11-20 02:26:02 +09004301}
4302
Jiyong Park67882562019-03-21 01:11:21 +09004303func TestApexKeyFromOtherModule(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004304 ctx := testApex(t, `
Jiyong Park67882562019-03-21 01:11:21 +09004305 apex_key {
4306 name: "myapex.key",
4307 public_key: ":my.avbpubkey",
4308 private_key: ":my.pem",
4309 product_specific: true,
4310 }
4311
4312 filegroup {
4313 name: "my.avbpubkey",
4314 srcs: ["testkey2.avbpubkey"],
4315 }
4316
4317 filegroup {
4318 name: "my.pem",
4319 srcs: ["testkey2.pem"],
4320 }
4321 `)
4322
4323 apex_key := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
4324 expected_pubkey := "testkey2.avbpubkey"
Jaewoong Jung18aefc12020-12-21 09:11:10 -08004325 actual_pubkey := apex_key.publicKeyFile.String()
Jiyong Park67882562019-03-21 01:11:21 +09004326 if actual_pubkey != expected_pubkey {
4327 t.Errorf("wrong public key path. expected %q. actual %q", expected_pubkey, actual_pubkey)
4328 }
4329 expected_privkey := "testkey2.pem"
Jaewoong Jung18aefc12020-12-21 09:11:10 -08004330 actual_privkey := apex_key.privateKeyFile.String()
Jiyong Park67882562019-03-21 01:11:21 +09004331 if actual_privkey != expected_privkey {
4332 t.Errorf("wrong private key path. expected %q. actual %q", expected_privkey, actual_privkey)
4333 }
4334}
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004335
4336func TestPrebuilt(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004337 ctx := testApex(t, `
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004338 prebuilt_apex {
4339 name: "myapex",
Jiyong Parkc95714e2019-03-29 14:23:10 +09004340 arch: {
4341 arm64: {
4342 src: "myapex-arm64.apex",
4343 },
4344 arm: {
4345 src: "myapex-arm.apex",
4346 },
4347 },
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004348 }
4349 `)
4350
Paul Duffin6717d882021-06-15 19:09:41 +01004351 prebuilt := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt)
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004352
Jiyong Parkc95714e2019-03-29 14:23:10 +09004353 expectedInput := "myapex-arm64.apex"
4354 if prebuilt.inputApex.String() != expectedInput {
4355 t.Errorf("inputApex invalid. expected: %q, actual: %q", expectedInput, prebuilt.inputApex.String())
4356 }
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004357}
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004358
Paul Duffinc0609c62021-03-01 17:27:16 +00004359func TestPrebuiltMissingSrc(t *testing.T) {
Paul Duffin6717d882021-06-15 19:09:41 +01004360 testApexError(t, `module "myapex" variant "android_common_myapex".*: prebuilt_apex does not support "arm64_armv8-a"`, `
Paul Duffinc0609c62021-03-01 17:27:16 +00004361 prebuilt_apex {
4362 name: "myapex",
4363 }
4364 `)
4365}
4366
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004367func TestPrebuiltFilenameOverride(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004368 ctx := testApex(t, `
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004369 prebuilt_apex {
4370 name: "myapex",
4371 src: "myapex-arm.apex",
4372 filename: "notmyapex.apex",
4373 }
4374 `)
4375
Paul Duffin6717d882021-06-15 19:09:41 +01004376 p := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt)
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004377
4378 expected := "notmyapex.apex"
4379 if p.installFilename != expected {
4380 t.Errorf("installFilename invalid. expected: %q, actual: %q", expected, p.installFilename)
4381 }
4382}
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07004383
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004384func TestPrebuiltOverrides(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004385 ctx := testApex(t, `
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004386 prebuilt_apex {
4387 name: "myapex.prebuilt",
4388 src: "myapex-arm.apex",
4389 overrides: [
4390 "myapex",
4391 ],
4392 }
4393 `)
4394
Paul Duffin6717d882021-06-15 19:09:41 +01004395 p := ctx.ModuleForTests("myapex.prebuilt", "android_common_myapex.prebuilt").Module().(*Prebuilt)
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004396
4397 expected := []string{"myapex"}
Colin Crossaa255532020-07-03 13:18:24 -07004398 actual := android.AndroidMkEntriesForTest(t, ctx, p)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004399 if !reflect.DeepEqual(actual, expected) {
Jiyong Parkb0a012c2019-11-14 17:17:03 +09004400 t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES value '%s', expected '%s'", actual, expected)
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004401 }
4402}
4403
Paul Duffin092153d2021-01-26 11:42:39 +00004404// These tests verify that the prebuilt_apex/deapexer to java_import wiring allows for the
4405// propagation of paths to dex implementation jars from the former to the latter.
Paul Duffin064b70c2020-11-02 17:32:38 +00004406func TestPrebuiltExportDexImplementationJars(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01004407 transform := android.NullFixturePreparer
Paul Duffin064b70c2020-11-02 17:32:38 +00004408
Paul Duffin89886cb2021-02-05 16:44:03 +00004409 checkDexJarBuildPath := func(t *testing.T, ctx *android.TestContext, name string) {
Paul Duffin064b70c2020-11-02 17:32:38 +00004410 // Make sure the import has been given the correct path to the dex jar.
Colin Crossdcf71b22021-02-01 13:59:03 -08004411 p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency)
Paul Duffin064b70c2020-11-02 17:32:38 +00004412 dexJarBuildPath := p.DexJarBuildPath()
Paul Duffin39853512021-02-26 11:09:39 +00004413 stem := android.RemoveOptionalPrebuiltPrefix(name)
4414 if expected, actual := ".intermediates/myapex.deapexer/android_common/deapexer/javalib/"+stem+".jar", android.NormalizePathForTesting(dexJarBuildPath); actual != expected {
Paul Duffin064b70c2020-11-02 17:32:38 +00004415 t.Errorf("Incorrect DexJarBuildPath value '%s', expected '%s'", actual, expected)
4416 }
4417 }
4418
Paul Duffin39853512021-02-26 11:09:39 +00004419 ensureNoSourceVariant := func(t *testing.T, ctx *android.TestContext, name string) {
Paul Duffin064b70c2020-11-02 17:32:38 +00004420 // Make sure that an apex variant is not created for the source module.
Paul Duffin39853512021-02-26 11:09:39 +00004421 if expected, actual := []string{"android_common"}, ctx.ModuleVariantsForTests(name); !reflect.DeepEqual(expected, actual) {
Paul Duffin064b70c2020-11-02 17:32:38 +00004422 t.Errorf("invalid set of variants for %q: expected %q, found %q", "libfoo", expected, actual)
4423 }
4424 }
4425
4426 t.Run("prebuilt only", func(t *testing.T) {
4427 bp := `
4428 prebuilt_apex {
4429 name: "myapex",
4430 arch: {
4431 arm64: {
4432 src: "myapex-arm64.apex",
4433 },
4434 arm: {
4435 src: "myapex-arm.apex",
4436 },
4437 },
Paul Duffin39853512021-02-26 11:09:39 +00004438 exported_java_libs: ["libfoo", "libbar"],
Paul Duffin064b70c2020-11-02 17:32:38 +00004439 }
4440
4441 java_import {
4442 name: "libfoo",
4443 jars: ["libfoo.jar"],
4444 }
Paul Duffin39853512021-02-26 11:09:39 +00004445
4446 java_sdk_library_import {
4447 name: "libbar",
4448 public: {
4449 jars: ["libbar.jar"],
4450 },
4451 }
Paul Duffin064b70c2020-11-02 17:32:38 +00004452 `
4453
4454 // Make sure that dexpreopt can access dex implementation files from the prebuilt.
4455 ctx := testDexpreoptWithApexes(t, bp, "", transform)
4456
Paul Duffinf6932af2021-02-26 18:21:56 +00004457 // Make sure that the deapexer has the correct input APEX.
4458 deapexer := ctx.ModuleForTests("myapex.deapexer", "android_common")
4459 rule := deapexer.Rule("deapexer")
4460 if expected, actual := []string{"myapex-arm64.apex"}, android.NormalizePathsForTesting(rule.Implicits); !reflect.DeepEqual(expected, actual) {
4461 t.Errorf("expected: %q, found: %q", expected, actual)
4462 }
4463
Paul Duffin0d10c3c2021-03-01 17:09:32 +00004464 // Make sure that the prebuilt_apex has the correct input APEX.
Paul Duffin6717d882021-06-15 19:09:41 +01004465 prebuiltApex := ctx.ModuleForTests("myapex", "android_common_myapex")
Paul Duffin0d10c3c2021-03-01 17:09:32 +00004466 rule = prebuiltApex.Rule("android/soong/android.Cp")
4467 if expected, actual := "myapex-arm64.apex", android.NormalizePathForTesting(rule.Input); !reflect.DeepEqual(expected, actual) {
4468 t.Errorf("expected: %q, found: %q", expected, actual)
4469 }
4470
Paul Duffin89886cb2021-02-05 16:44:03 +00004471 checkDexJarBuildPath(t, ctx, "libfoo")
Paul Duffin39853512021-02-26 11:09:39 +00004472
4473 checkDexJarBuildPath(t, ctx, "libbar")
Paul Duffin064b70c2020-11-02 17:32:38 +00004474 })
4475
4476 t.Run("prebuilt with source preferred", func(t *testing.T) {
4477
4478 bp := `
4479 prebuilt_apex {
4480 name: "myapex",
4481 arch: {
4482 arm64: {
4483 src: "myapex-arm64.apex",
4484 },
4485 arm: {
4486 src: "myapex-arm.apex",
4487 },
4488 },
Paul Duffin39853512021-02-26 11:09:39 +00004489 exported_java_libs: ["libfoo", "libbar"],
Paul Duffin064b70c2020-11-02 17:32:38 +00004490 }
4491
4492 java_import {
4493 name: "libfoo",
4494 jars: ["libfoo.jar"],
4495 }
4496
4497 java_library {
4498 name: "libfoo",
4499 }
Paul Duffin39853512021-02-26 11:09:39 +00004500
4501 java_sdk_library_import {
4502 name: "libbar",
4503 public: {
4504 jars: ["libbar.jar"],
4505 },
4506 }
4507
4508 java_sdk_library {
4509 name: "libbar",
4510 srcs: ["foo/bar/MyClass.java"],
4511 unsafe_ignore_missing_latest_api: true,
4512 }
Paul Duffin064b70c2020-11-02 17:32:38 +00004513 `
4514
4515 // Make sure that dexpreopt can access dex implementation files from the prebuilt.
4516 ctx := testDexpreoptWithApexes(t, bp, "", transform)
4517
Paul Duffin89886cb2021-02-05 16:44:03 +00004518 checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
Paul Duffin39853512021-02-26 11:09:39 +00004519 ensureNoSourceVariant(t, ctx, "libfoo")
4520
4521 checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
4522 ensureNoSourceVariant(t, ctx, "libbar")
Paul Duffin064b70c2020-11-02 17:32:38 +00004523 })
4524
4525 t.Run("prebuilt preferred with source", func(t *testing.T) {
4526 bp := `
4527 prebuilt_apex {
4528 name: "myapex",
Paul Duffin064b70c2020-11-02 17:32:38 +00004529 arch: {
4530 arm64: {
4531 src: "myapex-arm64.apex",
4532 },
4533 arm: {
4534 src: "myapex-arm.apex",
4535 },
4536 },
Paul Duffin39853512021-02-26 11:09:39 +00004537 exported_java_libs: ["libfoo", "libbar"],
Paul Duffin064b70c2020-11-02 17:32:38 +00004538 }
4539
4540 java_import {
4541 name: "libfoo",
Paul Duffin092153d2021-01-26 11:42:39 +00004542 prefer: true,
Paul Duffin064b70c2020-11-02 17:32:38 +00004543 jars: ["libfoo.jar"],
4544 }
4545
4546 java_library {
4547 name: "libfoo",
4548 }
Paul Duffin39853512021-02-26 11:09:39 +00004549
4550 java_sdk_library_import {
4551 name: "libbar",
4552 prefer: true,
4553 public: {
4554 jars: ["libbar.jar"],
4555 },
4556 }
4557
4558 java_sdk_library {
4559 name: "libbar",
4560 srcs: ["foo/bar/MyClass.java"],
4561 unsafe_ignore_missing_latest_api: true,
4562 }
Paul Duffin064b70c2020-11-02 17:32:38 +00004563 `
4564
4565 // Make sure that dexpreopt can access dex implementation files from the prebuilt.
4566 ctx := testDexpreoptWithApexes(t, bp, "", transform)
4567
Paul Duffin89886cb2021-02-05 16:44:03 +00004568 checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
Paul Duffin39853512021-02-26 11:09:39 +00004569 ensureNoSourceVariant(t, ctx, "libfoo")
4570
4571 checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
4572 ensureNoSourceVariant(t, ctx, "libbar")
Paul Duffin064b70c2020-11-02 17:32:38 +00004573 })
4574}
4575
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004576func TestBootDexJarsFromSourcesAndPrebuilts(t *testing.T) {
Paul Duffinb6f53c02021-05-14 07:52:42 +01004577 preparer := android.GroupFixturePreparers(
4578 java.FixtureConfigureBootJars("myapex:libfoo", "myapex:libbar"),
4579 // Make sure that the frameworks/base/Android.bp file exists as otherwise hidden API encoding
4580 // is disabled.
4581 android.FixtureAddTextFile("frameworks/base/Android.bp", ""),
4582 )
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004583
Paul Duffin37856732021-02-26 14:24:15 +00004584 checkBootDexJarPath := func(t *testing.T, ctx *android.TestContext, stem string, bootDexJarPath string) {
4585 t.Helper()
Paul Duffin7ebebfd2021-04-27 19:36:57 +01004586 s := ctx.ModuleForTests("platform-bootclasspath", "android_common")
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004587 foundLibfooJar := false
Paul Duffin37856732021-02-26 14:24:15 +00004588 base := stem + ".jar"
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004589 for _, output := range s.AllOutputs() {
Paul Duffin37856732021-02-26 14:24:15 +00004590 if filepath.Base(output) == base {
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004591 foundLibfooJar = true
4592 buildRule := s.Output(output)
Paul Duffin55607122021-03-30 23:32:51 +01004593 android.AssertStringEquals(t, "boot dex jar path", bootDexJarPath, buildRule.Input.String())
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004594 }
4595 }
4596 if !foundLibfooJar {
Paul Duffin55607122021-03-30 23:32:51 +01004597 t.Errorf("Rule for libfoo.jar missing in dex_bootjars singleton outputs %q", android.StringPathsRelativeToTop(ctx.Config().BuildDir(), s.AllOutputs()))
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004598 }
4599 }
4600
Paul Duffind061d402021-06-07 21:36:01 +01004601 checkHiddenAPIIndexInputs := func(t *testing.T, ctx *android.TestContext, expectedIntermediateInputs string) {
Paul Duffin37856732021-02-26 14:24:15 +00004602 t.Helper()
Paul Duffin00b2bfd2021-04-12 17:24:36 +01004603 platformBootclasspath := ctx.ModuleForTests("platform-bootclasspath", "android_common")
Paul Duffind061d402021-06-07 21:36:01 +01004604 var rule android.TestingBuildParams
4605
4606 rule = platformBootclasspath.Output("hiddenapi-monolithic/index-from-classes.csv")
4607 java.CheckHiddenAPIRuleInputs(t, "intermediate index", expectedIntermediateInputs, rule)
Paul Duffin4fd997b2021-02-03 20:06:33 +00004608 }
4609
Paul Duffin89f570a2021-06-16 01:42:33 +01004610 fragment := java.ApexVariantReference{
4611 Apex: proptools.StringPtr("myapex"),
4612 Module: proptools.StringPtr("my-bootclasspath-fragment"),
4613 }
4614
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004615 t.Run("prebuilt only", func(t *testing.T) {
4616 bp := `
4617 prebuilt_apex {
4618 name: "myapex",
4619 arch: {
4620 arm64: {
4621 src: "myapex-arm64.apex",
4622 },
4623 arm: {
4624 src: "myapex-arm.apex",
4625 },
4626 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004627 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4628 }
4629
4630 prebuilt_bootclasspath_fragment {
4631 name: "my-bootclasspath-fragment",
4632 contents: ["libfoo", "libbar"],
4633 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004634 }
4635
4636 java_import {
4637 name: "libfoo",
4638 jars: ["libfoo.jar"],
4639 apex_available: ["myapex"],
4640 }
Paul Duffin37856732021-02-26 14:24:15 +00004641
4642 java_sdk_library_import {
4643 name: "libbar",
4644 public: {
4645 jars: ["libbar.jar"],
4646 },
4647 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004648 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00004649 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004650 `
4651
Paul Duffin89f570a2021-06-16 01:42:33 +01004652 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01004653 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
4654 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00004655
Paul Duffin537ea3d2021-05-14 10:38:00 +01004656 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin9d67ca62021-02-03 20:06:33 +00004657 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin51d7da22021-06-16 02:04:13 +01004658 out/soong/.intermediates/libbar.stubs/android_common/combined/libbar.stubs.jar
4659 out/soong/.intermediates/libfoo/android_common_myapex/combined/libfoo.jar
4660 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004661 })
4662
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004663 t.Run("apex_set only", func(t *testing.T) {
4664 bp := `
4665 apex_set {
4666 name: "myapex",
4667 set: "myapex.apks",
Paul Duffin89f570a2021-06-16 01:42:33 +01004668 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4669 }
4670
4671 prebuilt_bootclasspath_fragment {
4672 name: "my-bootclasspath-fragment",
4673 contents: ["libfoo", "libbar"],
4674 apex_available: ["myapex"],
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004675 }
4676
4677 java_import {
4678 name: "libfoo",
4679 jars: ["libfoo.jar"],
4680 apex_available: ["myapex"],
4681 }
4682
4683 java_sdk_library_import {
4684 name: "libbar",
4685 public: {
4686 jars: ["libbar.jar"],
4687 },
4688 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004689 shared_library: false,
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004690 }
4691 `
4692
Paul Duffin89f570a2021-06-16 01:42:33 +01004693 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004694 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
4695 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
4696
Paul Duffin537ea3d2021-05-14 10:38:00 +01004697 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004698 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin51d7da22021-06-16 02:04:13 +01004699 out/soong/.intermediates/libbar.stubs/android_common/combined/libbar.stubs.jar
4700 out/soong/.intermediates/libfoo/android_common_myapex/combined/libfoo.jar
4701 `)
Paul Duffinf58fd9a2021-04-06 16:00:22 +01004702 })
4703
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004704 t.Run("prebuilt with source library preferred", func(t *testing.T) {
4705 bp := `
4706 prebuilt_apex {
4707 name: "myapex",
4708 arch: {
4709 arm64: {
4710 src: "myapex-arm64.apex",
4711 },
4712 arm: {
4713 src: "myapex-arm.apex",
4714 },
4715 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004716 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4717 }
4718
4719 prebuilt_bootclasspath_fragment {
4720 name: "my-bootclasspath-fragment",
4721 contents: ["libfoo", "libbar"],
4722 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004723 }
4724
4725 java_import {
4726 name: "libfoo",
4727 jars: ["libfoo.jar"],
4728 apex_available: ["myapex"],
4729 }
4730
4731 java_library {
4732 name: "libfoo",
4733 srcs: ["foo/bar/MyClass.java"],
4734 apex_available: ["myapex"],
4735 }
Paul Duffin37856732021-02-26 14:24:15 +00004736
4737 java_sdk_library_import {
4738 name: "libbar",
4739 public: {
4740 jars: ["libbar.jar"],
4741 },
4742 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004743 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00004744 }
4745
4746 java_sdk_library {
4747 name: "libbar",
4748 srcs: ["foo/bar/MyClass.java"],
4749 unsafe_ignore_missing_latest_api: true,
4750 apex_available: ["myapex"],
4751 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004752 `
4753
4754 // In this test the source (java_library) libfoo is active since the
4755 // prebuilt (java_import) defaults to prefer:false. However the
4756 // prebuilt_apex module always depends on the prebuilt, and so it doesn't
4757 // find the dex boot jar in it. We either need to disable the source libfoo
4758 // or make the prebuilt libfoo preferred.
Paul Duffin89f570a2021-06-16 01:42:33 +01004759 testDexpreoptWithApexes(t, bp, "module libfoo does not provide a dex boot jar", preparer, fragment)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004760 })
4761
4762 t.Run("prebuilt library preferred with source", func(t *testing.T) {
4763 bp := `
4764 prebuilt_apex {
4765 name: "myapex",
4766 arch: {
4767 arm64: {
4768 src: "myapex-arm64.apex",
4769 },
4770 arm: {
4771 src: "myapex-arm.apex",
4772 },
4773 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004774 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4775 }
4776
4777 prebuilt_bootclasspath_fragment {
4778 name: "my-bootclasspath-fragment",
4779 contents: ["libfoo", "libbar"],
4780 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004781 }
4782
4783 java_import {
4784 name: "libfoo",
4785 prefer: true,
4786 jars: ["libfoo.jar"],
4787 apex_available: ["myapex"],
4788 }
4789
4790 java_library {
4791 name: "libfoo",
4792 srcs: ["foo/bar/MyClass.java"],
4793 apex_available: ["myapex"],
4794 }
Paul Duffin37856732021-02-26 14:24:15 +00004795
4796 java_sdk_library_import {
4797 name: "libbar",
4798 prefer: true,
4799 public: {
4800 jars: ["libbar.jar"],
4801 },
4802 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004803 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00004804 }
4805
4806 java_sdk_library {
4807 name: "libbar",
4808 srcs: ["foo/bar/MyClass.java"],
4809 unsafe_ignore_missing_latest_api: true,
4810 apex_available: ["myapex"],
4811 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004812 `
4813
Paul Duffin89f570a2021-06-16 01:42:33 +01004814 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01004815 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
4816 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00004817
Paul Duffin537ea3d2021-05-14 10:38:00 +01004818 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin9d67ca62021-02-03 20:06:33 +00004819 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin51d7da22021-06-16 02:04:13 +01004820 out/soong/.intermediates/prebuilt_libbar.stubs/android_common/combined/libbar.stubs.jar
4821 out/soong/.intermediates/prebuilt_libfoo/android_common_myapex/combined/libfoo.jar
4822 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004823 })
4824
4825 t.Run("prebuilt with source apex preferred", func(t *testing.T) {
4826 bp := `
4827 apex {
4828 name: "myapex",
4829 key: "myapex.key",
Paul Duffin37856732021-02-26 14:24:15 +00004830 java_libs: ["libfoo", "libbar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004831 updatable: false,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004832 }
4833
4834 apex_key {
4835 name: "myapex.key",
4836 public_key: "testkey.avbpubkey",
4837 private_key: "testkey.pem",
4838 }
4839
4840 prebuilt_apex {
4841 name: "myapex",
4842 arch: {
4843 arm64: {
4844 src: "myapex-arm64.apex",
4845 },
4846 arm: {
4847 src: "myapex-arm.apex",
4848 },
4849 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004850 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4851 }
4852
4853 prebuilt_bootclasspath_fragment {
4854 name: "my-bootclasspath-fragment",
4855 contents: ["libfoo", "libbar"],
4856 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004857 }
4858
4859 java_import {
4860 name: "libfoo",
4861 jars: ["libfoo.jar"],
4862 apex_available: ["myapex"],
4863 }
4864
4865 java_library {
4866 name: "libfoo",
4867 srcs: ["foo/bar/MyClass.java"],
4868 apex_available: ["myapex"],
4869 }
Paul Duffin37856732021-02-26 14:24:15 +00004870
4871 java_sdk_library_import {
4872 name: "libbar",
4873 public: {
4874 jars: ["libbar.jar"],
4875 },
4876 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004877 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00004878 }
4879
4880 java_sdk_library {
4881 name: "libbar",
4882 srcs: ["foo/bar/MyClass.java"],
4883 unsafe_ignore_missing_latest_api: true,
4884 apex_available: ["myapex"],
4885 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004886 `
4887
Paul Duffin89f570a2021-06-16 01:42:33 +01004888 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01004889 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/libfoo/android_common_apex10000/hiddenapi/libfoo.jar")
4890 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/libbar/android_common_myapex/hiddenapi/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00004891
Paul Duffin537ea3d2021-05-14 10:38:00 +01004892 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin4fd997b2021-02-03 20:06:33 +00004893 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin51d7da22021-06-16 02:04:13 +01004894 out/soong/.intermediates/libbar/android_common_myapex/javac/libbar.jar
4895 out/soong/.intermediates/libfoo/android_common_apex10000/javac/libfoo.jar
4896 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004897 })
4898
4899 t.Run("prebuilt preferred with source apex disabled", func(t *testing.T) {
4900 bp := `
4901 apex {
4902 name: "myapex",
4903 enabled: false,
4904 key: "myapex.key",
Paul Duffin8f146b92021-04-12 17:24:18 +01004905 java_libs: ["libfoo", "libbar"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004906 }
4907
4908 apex_key {
4909 name: "myapex.key",
4910 public_key: "testkey.avbpubkey",
4911 private_key: "testkey.pem",
4912 }
4913
4914 prebuilt_apex {
4915 name: "myapex",
4916 arch: {
4917 arm64: {
4918 src: "myapex-arm64.apex",
4919 },
4920 arm: {
4921 src: "myapex-arm.apex",
4922 },
4923 },
Paul Duffin89f570a2021-06-16 01:42:33 +01004924 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
4925 }
4926
4927 prebuilt_bootclasspath_fragment {
4928 name: "my-bootclasspath-fragment",
4929 contents: ["libfoo", "libbar"],
4930 apex_available: ["myapex"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004931 }
4932
4933 java_import {
4934 name: "libfoo",
4935 prefer: true,
4936 jars: ["libfoo.jar"],
4937 apex_available: ["myapex"],
4938 }
4939
4940 java_library {
4941 name: "libfoo",
4942 srcs: ["foo/bar/MyClass.java"],
4943 apex_available: ["myapex"],
4944 }
Paul Duffin37856732021-02-26 14:24:15 +00004945
4946 java_sdk_library_import {
4947 name: "libbar",
4948 prefer: true,
4949 public: {
4950 jars: ["libbar.jar"],
4951 },
4952 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01004953 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00004954 }
4955
4956 java_sdk_library {
4957 name: "libbar",
4958 srcs: ["foo/bar/MyClass.java"],
4959 unsafe_ignore_missing_latest_api: true,
4960 apex_available: ["myapex"],
4961 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004962 `
4963
Paul Duffin89f570a2021-06-16 01:42:33 +01004964 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Paul Duffin55607122021-03-30 23:32:51 +01004965 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
4966 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00004967
Paul Duffin537ea3d2021-05-14 10:38:00 +01004968 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin9d67ca62021-02-03 20:06:33 +00004969 checkHiddenAPIIndexInputs(t, ctx, `
Paul Duffin51d7da22021-06-16 02:04:13 +01004970 out/soong/.intermediates/prebuilt_libbar.stubs/android_common/combined/libbar.stubs.jar
4971 out/soong/.intermediates/prebuilt_libfoo/android_common_myapex/combined/libfoo.jar
4972 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00004973 })
4974}
4975
Roland Levillain630846d2019-06-26 12:48:34 +01004976func TestApexWithTests(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004977 ctx := testApex(t, `
Roland Levillain630846d2019-06-26 12:48:34 +01004978 apex_test {
4979 name: "myapex",
4980 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004981 updatable: false,
Roland Levillain630846d2019-06-26 12:48:34 +01004982 tests: [
4983 "mytest",
Roland Levillain9b5fde92019-06-28 15:41:19 +01004984 "mytests",
Roland Levillain630846d2019-06-26 12:48:34 +01004985 ],
4986 }
4987
4988 apex_key {
4989 name: "myapex.key",
4990 public_key: "testkey.avbpubkey",
4991 private_key: "testkey.pem",
4992 }
4993
Liz Kammer1c14a212020-05-12 15:26:55 -07004994 filegroup {
4995 name: "fg",
4996 srcs: [
4997 "baz",
4998 "bar/baz"
4999 ],
5000 }
5001
Roland Levillain630846d2019-06-26 12:48:34 +01005002 cc_test {
5003 name: "mytest",
5004 gtest: false,
5005 srcs: ["mytest.cpp"],
5006 relative_install_path: "test",
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005007 shared_libs: ["mylib"],
Roland Levillain630846d2019-06-26 12:48:34 +01005008 system_shared_libs: [],
5009 static_executable: true,
5010 stl: "none",
Liz Kammer1c14a212020-05-12 15:26:55 -07005011 data: [":fg"],
Roland Levillain630846d2019-06-26 12:48:34 +01005012 }
Roland Levillain9b5fde92019-06-28 15:41:19 +01005013
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005014 cc_library {
5015 name: "mylib",
5016 srcs: ["mylib.cpp"],
5017 system_shared_libs: [],
5018 stl: "none",
5019 }
5020
Liz Kammer5bd365f2020-05-27 15:15:11 -07005021 filegroup {
5022 name: "fg2",
5023 srcs: [
5024 "testdata/baz"
5025 ],
5026 }
5027
Roland Levillain9b5fde92019-06-28 15:41:19 +01005028 cc_test {
5029 name: "mytests",
5030 gtest: false,
5031 srcs: [
5032 "mytest1.cpp",
5033 "mytest2.cpp",
5034 "mytest3.cpp",
5035 ],
5036 test_per_src: true,
5037 relative_install_path: "test",
5038 system_shared_libs: [],
5039 static_executable: true,
5040 stl: "none",
Liz Kammer5bd365f2020-05-27 15:15:11 -07005041 data: [
5042 ":fg",
5043 ":fg2",
5044 ],
Roland Levillain9b5fde92019-06-28 15:41:19 +01005045 }
Roland Levillain630846d2019-06-26 12:48:34 +01005046 `)
5047
Sundong Ahnabb64432019-10-22 13:58:29 +09005048 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Roland Levillain630846d2019-06-26 12:48:34 +01005049 copyCmds := apexRule.Args["copy_commands"]
5050
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005051 // Ensure that test dep (and their transitive dependencies) are copied into apex.
Roland Levillain630846d2019-06-26 12:48:34 +01005052 ensureContains(t, copyCmds, "image.apex/bin/test/mytest")
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005053 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Roland Levillain9b5fde92019-06-28 15:41:19 +01005054
Liz Kammer1c14a212020-05-12 15:26:55 -07005055 //Ensure that test data are copied into apex.
5056 ensureContains(t, copyCmds, "image.apex/bin/test/baz")
5057 ensureContains(t, copyCmds, "image.apex/bin/test/bar/baz")
5058
Roland Levillain9b5fde92019-06-28 15:41:19 +01005059 // Ensure that test deps built with `test_per_src` are copied into apex.
5060 ensureContains(t, copyCmds, "image.apex/bin/test/mytest1")
5061 ensureContains(t, copyCmds, "image.apex/bin/test/mytest2")
5062 ensureContains(t, copyCmds, "image.apex/bin/test/mytest3")
Roland Levillainf89cd092019-07-29 16:22:59 +01005063
5064 // Ensure the module is correctly translated.
Liz Kammer81faaaf2020-05-20 09:57:08 -07005065 bundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07005066 data := android.AndroidMkDataForTest(t, ctx, bundle)
Liz Kammer81faaaf2020-05-20 09:57:08 -07005067 name := bundle.BaseModuleName()
Roland Levillainf89cd092019-07-29 16:22:59 +01005068 prefix := "TARGET_"
5069 var builder strings.Builder
5070 data.Custom(&builder, name, prefix, "", data)
5071 androidMk := builder.String()
Jooyung Han31c470b2019-10-18 16:26:59 +09005072 ensureContains(t, androidMk, "LOCAL_MODULE := mytest.myapex\n")
5073 ensureContains(t, androidMk, "LOCAL_MODULE := mytest1.myapex\n")
5074 ensureContains(t, androidMk, "LOCAL_MODULE := mytest2.myapex\n")
5075 ensureContains(t, androidMk, "LOCAL_MODULE := mytest3.myapex\n")
Jooyung Han214bf372019-11-12 13:03:50 +09005076 ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex\n")
Jooyung Han31c470b2019-10-18 16:26:59 +09005077 ensureContains(t, androidMk, "LOCAL_MODULE := apex_pubkey.myapex\n")
Roland Levillainf89cd092019-07-29 16:22:59 +01005078 ensureContains(t, androidMk, "LOCAL_MODULE := myapex\n")
Liz Kammer81faaaf2020-05-20 09:57:08 -07005079
5080 flatBundle := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07005081 data = android.AndroidMkDataForTest(t, ctx, flatBundle)
Liz Kammer81faaaf2020-05-20 09:57:08 -07005082 data.Custom(&builder, name, prefix, "", data)
5083 flatAndroidMk := builder.String()
Liz Kammer5bd365f2020-05-27 15:15:11 -07005084 ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :baz :bar/baz\n")
5085 ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :testdata/baz\n")
Roland Levillain630846d2019-06-26 12:48:34 +01005086}
5087
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005088func TestInstallExtraFlattenedApexes(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005089 ctx := testApex(t, `
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005090 apex {
5091 name: "myapex",
5092 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005093 updatable: false,
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005094 }
5095 apex_key {
5096 name: "myapex.key",
5097 public_key: "testkey.avbpubkey",
5098 private_key: "testkey.pem",
5099 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00005100 `,
5101 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
5102 variables.InstallExtraFlattenedApexes = proptools.BoolPtr(true)
5103 }),
5104 )
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005105 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Jiyong Park83dc74b2020-01-14 18:38:44 +09005106 ensureListContains(t, ab.requiredDeps, "myapex.flattened")
Colin Crossaa255532020-07-03 13:18:24 -07005107 mk := android.AndroidMkDataForTest(t, ctx, ab)
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09005108 var builder strings.Builder
5109 mk.Custom(&builder, ab.Name(), "TARGET_", "", mk)
5110 androidMk := builder.String()
5111 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += myapex.flattened")
5112}
5113
Jooyung Hand48f3c32019-08-23 11:18:57 +09005114func TestErrorsIfDepsAreNotEnabled(t *testing.T) {
5115 testApexError(t, `module "myapex" .* depends on disabled module "libfoo"`, `
5116 apex {
5117 name: "myapex",
5118 key: "myapex.key",
5119 native_shared_libs: ["libfoo"],
5120 }
5121
5122 apex_key {
5123 name: "myapex.key",
5124 public_key: "testkey.avbpubkey",
5125 private_key: "testkey.pem",
5126 }
5127
5128 cc_library {
5129 name: "libfoo",
5130 stl: "none",
5131 system_shared_libs: [],
5132 enabled: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09005133 apex_available: ["myapex"],
Jooyung Hand48f3c32019-08-23 11:18:57 +09005134 }
5135 `)
5136 testApexError(t, `module "myapex" .* depends on disabled module "myjar"`, `
5137 apex {
5138 name: "myapex",
5139 key: "myapex.key",
5140 java_libs: ["myjar"],
5141 }
5142
5143 apex_key {
5144 name: "myapex.key",
5145 public_key: "testkey.avbpubkey",
5146 private_key: "testkey.pem",
5147 }
5148
5149 java_library {
5150 name: "myjar",
5151 srcs: ["foo/bar/MyClass.java"],
5152 sdk_version: "none",
5153 system_modules: "none",
Jooyung Hand48f3c32019-08-23 11:18:57 +09005154 enabled: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09005155 apex_available: ["myapex"],
Jooyung Hand48f3c32019-08-23 11:18:57 +09005156 }
5157 `)
5158}
5159
Bill Peckhama41a6962021-01-11 10:58:54 -08005160func TestApexWithJavaImport(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005161 ctx := testApex(t, `
Bill Peckhama41a6962021-01-11 10:58:54 -08005162 apex {
5163 name: "myapex",
5164 key: "myapex.key",
5165 java_libs: ["myjavaimport"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005166 updatable: false,
Bill Peckhama41a6962021-01-11 10:58:54 -08005167 }
5168
5169 apex_key {
5170 name: "myapex.key",
5171 public_key: "testkey.avbpubkey",
5172 private_key: "testkey.pem",
5173 }
5174
5175 java_import {
5176 name: "myjavaimport",
5177 apex_available: ["myapex"],
5178 jars: ["my.jar"],
5179 compile_dex: true,
5180 }
5181 `)
5182
5183 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
5184 apexRule := module.Rule("apexRule")
5185 copyCmds := apexRule.Args["copy_commands"]
5186 ensureContains(t, copyCmds, "image.apex/javalib/myjavaimport.jar")
5187}
5188
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005189func TestApexWithApps(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005190 ctx := testApex(t, `
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005191 apex {
5192 name: "myapex",
5193 key: "myapex.key",
5194 apps: [
5195 "AppFoo",
Jiyong Parkf7487312019-10-17 12:54:30 +09005196 "AppFooPriv",
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005197 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005198 updatable: false,
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005199 }
5200
5201 apex_key {
5202 name: "myapex.key",
5203 public_key: "testkey.avbpubkey",
5204 private_key: "testkey.pem",
5205 }
5206
5207 android_app {
5208 name: "AppFoo",
5209 srcs: ["foo/bar/MyClass.java"],
Colin Cross094cde42020-02-15 10:38:00 -08005210 sdk_version: "current",
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005211 system_modules: "none",
Jiyong Park8be103b2019-11-08 15:53:48 +09005212 jni_libs: ["libjni"],
Colin Cross094cde42020-02-15 10:38:00 -08005213 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005214 apex_available: [ "myapex" ],
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005215 }
Jiyong Parkf7487312019-10-17 12:54:30 +09005216
5217 android_app {
5218 name: "AppFooPriv",
5219 srcs: ["foo/bar/MyClass.java"],
Colin Cross094cde42020-02-15 10:38:00 -08005220 sdk_version: "current",
Jiyong Parkf7487312019-10-17 12:54:30 +09005221 system_modules: "none",
5222 privileged: true,
Colin Cross094cde42020-02-15 10:38:00 -08005223 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005224 apex_available: [ "myapex" ],
Jiyong Parkf7487312019-10-17 12:54:30 +09005225 }
Jiyong Park8be103b2019-11-08 15:53:48 +09005226
5227 cc_library_shared {
5228 name: "libjni",
5229 srcs: ["mylib.cpp"],
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005230 shared_libs: ["libfoo"],
5231 stl: "none",
5232 system_shared_libs: [],
5233 apex_available: [ "myapex" ],
5234 sdk_version: "current",
5235 }
5236
5237 cc_library_shared {
5238 name: "libfoo",
Jiyong Park8be103b2019-11-08 15:53:48 +09005239 stl: "none",
5240 system_shared_libs: [],
Jiyong Park0f80c182020-01-31 02:49:53 +09005241 apex_available: [ "myapex" ],
Colin Cross094cde42020-02-15 10:38:00 -08005242 sdk_version: "current",
Jiyong Park8be103b2019-11-08 15:53:48 +09005243 }
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005244 `)
5245
Sundong Ahnabb64432019-10-22 13:58:29 +09005246 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005247 apexRule := module.Rule("apexRule")
5248 copyCmds := apexRule.Args["copy_commands"]
5249
5250 ensureContains(t, copyCmds, "image.apex/app/AppFoo/AppFoo.apk")
Jiyong Parkf7487312019-10-17 12:54:30 +09005251 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPriv/AppFooPriv.apk")
Jiyong Park52cd06f2019-11-11 10:14:32 +09005252
Colin Crossaede88c2020-08-11 12:17:01 -07005253 appZipRule := ctx.ModuleForTests("AppFoo", "android_common_apex10000").Description("zip jni libs")
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005254 // JNI libraries are uncompressed
Jiyong Park52cd06f2019-11-11 10:14:32 +09005255 if args := appZipRule.Args["jarArgs"]; !strings.Contains(args, "-L 0") {
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005256 t.Errorf("jni libs are not uncompressed for AppFoo")
Jiyong Park52cd06f2019-11-11 10:14:32 +09005257 }
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005258 // JNI libraries including transitive deps are
5259 for _, jni := range []string{"libjni", "libfoo"} {
Paul Duffinafdd4062021-03-30 19:44:07 +01005260 jniOutput := ctx.ModuleForTests(jni, "android_arm64_armv8-a_sdk_shared_apex10000").Module().(*cc.Module).OutputFile().RelativeToTop()
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005261 // ... embedded inside APK (jnilibs.zip)
5262 ensureListContains(t, appZipRule.Implicits.Strings(), jniOutput.String())
5263 // ... and not directly inside the APEX
5264 ensureNotContains(t, copyCmds, "image.apex/lib64/"+jni+".so")
5265 }
Dario Frenicde2a032019-10-27 00:29:22 +01005266}
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005267
Dario Frenicde2a032019-10-27 00:29:22 +01005268func TestApexWithAppImports(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005269 ctx := testApex(t, `
Dario Frenicde2a032019-10-27 00:29:22 +01005270 apex {
5271 name: "myapex",
5272 key: "myapex.key",
5273 apps: [
5274 "AppFooPrebuilt",
5275 "AppFooPrivPrebuilt",
5276 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005277 updatable: false,
Dario Frenicde2a032019-10-27 00:29:22 +01005278 }
5279
5280 apex_key {
5281 name: "myapex.key",
5282 public_key: "testkey.avbpubkey",
5283 private_key: "testkey.pem",
5284 }
5285
5286 android_app_import {
5287 name: "AppFooPrebuilt",
5288 apk: "PrebuiltAppFoo.apk",
5289 presigned: true,
5290 dex_preopt: {
5291 enabled: false,
5292 },
Jiyong Park592a6a42020-04-21 22:34:28 +09005293 apex_available: ["myapex"],
Dario Frenicde2a032019-10-27 00:29:22 +01005294 }
5295
5296 android_app_import {
5297 name: "AppFooPrivPrebuilt",
5298 apk: "PrebuiltAppFooPriv.apk",
5299 privileged: true,
5300 presigned: true,
5301 dex_preopt: {
5302 enabled: false,
5303 },
Jooyung Han39ee1192020-03-23 20:21:11 +09005304 filename: "AwesomePrebuiltAppFooPriv.apk",
Jiyong Park592a6a42020-04-21 22:34:28 +09005305 apex_available: ["myapex"],
Dario Frenicde2a032019-10-27 00:29:22 +01005306 }
5307 `)
5308
Sundong Ahnabb64432019-10-22 13:58:29 +09005309 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Dario Frenicde2a032019-10-27 00:29:22 +01005310 apexRule := module.Rule("apexRule")
5311 copyCmds := apexRule.Args["copy_commands"]
5312
5313 ensureContains(t, copyCmds, "image.apex/app/AppFooPrebuilt/AppFooPrebuilt.apk")
Jooyung Han39ee1192020-03-23 20:21:11 +09005314 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPrivPrebuilt/AwesomePrebuiltAppFooPriv.apk")
5315}
5316
5317func TestApexWithAppImportsPrefer(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005318 ctx := testApex(t, `
Jooyung Han39ee1192020-03-23 20:21:11 +09005319 apex {
5320 name: "myapex",
5321 key: "myapex.key",
5322 apps: [
5323 "AppFoo",
5324 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005325 updatable: false,
Jooyung Han39ee1192020-03-23 20:21:11 +09005326 }
5327
5328 apex_key {
5329 name: "myapex.key",
5330 public_key: "testkey.avbpubkey",
5331 private_key: "testkey.pem",
5332 }
5333
5334 android_app {
5335 name: "AppFoo",
5336 srcs: ["foo/bar/MyClass.java"],
5337 sdk_version: "none",
5338 system_modules: "none",
5339 apex_available: [ "myapex" ],
5340 }
5341
5342 android_app_import {
5343 name: "AppFoo",
5344 apk: "AppFooPrebuilt.apk",
5345 filename: "AppFooPrebuilt.apk",
5346 presigned: true,
5347 prefer: true,
Jiyong Park592a6a42020-04-21 22:34:28 +09005348 apex_available: ["myapex"],
Jooyung Han39ee1192020-03-23 20:21:11 +09005349 }
5350 `, withFiles(map[string][]byte{
5351 "AppFooPrebuilt.apk": nil,
5352 }))
5353
5354 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Han86feead2021-03-08 13:11:48 +09005355 "app/AppFoo/AppFooPrebuilt.apk",
Jooyung Han39ee1192020-03-23 20:21:11 +09005356 })
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005357}
5358
Dario Freni6f3937c2019-12-20 22:58:03 +00005359func TestApexWithTestHelperApp(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005360 ctx := testApex(t, `
Dario Freni6f3937c2019-12-20 22:58:03 +00005361 apex {
5362 name: "myapex",
5363 key: "myapex.key",
5364 apps: [
5365 "TesterHelpAppFoo",
5366 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005367 updatable: false,
Dario Freni6f3937c2019-12-20 22:58:03 +00005368 }
5369
5370 apex_key {
5371 name: "myapex.key",
5372 public_key: "testkey.avbpubkey",
5373 private_key: "testkey.pem",
5374 }
5375
5376 android_test_helper_app {
5377 name: "TesterHelpAppFoo",
5378 srcs: ["foo/bar/MyClass.java"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005379 apex_available: [ "myapex" ],
Dario Freni6f3937c2019-12-20 22:58:03 +00005380 }
5381
5382 `)
5383
5384 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
5385 apexRule := module.Rule("apexRule")
5386 copyCmds := apexRule.Args["copy_commands"]
5387
5388 ensureContains(t, copyCmds, "image.apex/app/TesterHelpAppFoo/TesterHelpAppFoo.apk")
5389}
5390
Jooyung Han18020ea2019-11-13 10:50:48 +09005391func TestApexPropertiesShouldBeDefaultable(t *testing.T) {
5392 // libfoo's apex_available comes from cc_defaults
Steven Moreland6e36cd62020-10-22 01:08:35 +00005393 testApexError(t, `requires "libfoo" that doesn't list the APEX under 'apex_available'.`, `
Jooyung Han18020ea2019-11-13 10:50:48 +09005394 apex {
5395 name: "myapex",
5396 key: "myapex.key",
5397 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005398 updatable: false,
Jooyung Han18020ea2019-11-13 10:50:48 +09005399 }
5400
5401 apex_key {
5402 name: "myapex.key",
5403 public_key: "testkey.avbpubkey",
5404 private_key: "testkey.pem",
5405 }
5406
5407 apex {
5408 name: "otherapex",
5409 key: "myapex.key",
5410 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005411 updatable: false,
Jooyung Han18020ea2019-11-13 10:50:48 +09005412 }
5413
5414 cc_defaults {
5415 name: "libfoo-defaults",
5416 apex_available: ["otherapex"],
5417 }
5418
5419 cc_library {
5420 name: "libfoo",
5421 defaults: ["libfoo-defaults"],
5422 stl: "none",
5423 system_shared_libs: [],
5424 }`)
5425}
5426
Paul Duffine52e66f2020-03-30 17:54:29 +01005427func TestApexAvailable_DirectDep(t *testing.T) {
Jiyong Park127b40b2019-09-30 16:04:35 +09005428 // libfoo is not available to myapex, but only to otherapex
Steven Moreland6e36cd62020-10-22 01:08:35 +00005429 testApexError(t, "requires \"libfoo\" that doesn't list the APEX under 'apex_available'.", `
Jiyong Park127b40b2019-09-30 16:04:35 +09005430 apex {
5431 name: "myapex",
5432 key: "myapex.key",
5433 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005434 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005435 }
5436
5437 apex_key {
5438 name: "myapex.key",
5439 public_key: "testkey.avbpubkey",
5440 private_key: "testkey.pem",
5441 }
5442
5443 apex {
5444 name: "otherapex",
5445 key: "otherapex.key",
5446 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005447 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005448 }
5449
5450 apex_key {
5451 name: "otherapex.key",
5452 public_key: "testkey.avbpubkey",
5453 private_key: "testkey.pem",
5454 }
5455
5456 cc_library {
5457 name: "libfoo",
5458 stl: "none",
5459 system_shared_libs: [],
5460 apex_available: ["otherapex"],
5461 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01005462}
Jiyong Park127b40b2019-09-30 16:04:35 +09005463
Paul Duffine52e66f2020-03-30 17:54:29 +01005464func TestApexAvailable_IndirectDep(t *testing.T) {
Jooyung Han5e9013b2020-03-10 06:23:13 +09005465 // libbbaz is an indirect dep
Jiyong Park767dbd92021-03-04 13:03:10 +09005466 testApexError(t, `requires "libbaz" that doesn't list the APEX under 'apex_available'.\n\nDependency path:
Colin Cross6e511a92020-07-27 21:26:48 -07005467.*via tag apex\.dependencyTag.*name:sharedLib.*
Paul Duffindf915ff2020-03-30 17:58:21 +01005468.*-> libfoo.*link:shared.*
Colin Cross6e511a92020-07-27 21:26:48 -07005469.*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
Paul Duffindf915ff2020-03-30 17:58:21 +01005470.*-> libbar.*link:shared.*
Colin Cross6e511a92020-07-27 21:26:48 -07005471.*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
Paul Duffin65347702020-03-31 15:23:40 +01005472.*-> libbaz.*link:shared.*`, `
Jiyong Park127b40b2019-09-30 16:04:35 +09005473 apex {
5474 name: "myapex",
5475 key: "myapex.key",
5476 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005477 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005478 }
5479
5480 apex_key {
5481 name: "myapex.key",
5482 public_key: "testkey.avbpubkey",
5483 private_key: "testkey.pem",
5484 }
5485
Jiyong Park127b40b2019-09-30 16:04:35 +09005486 cc_library {
5487 name: "libfoo",
5488 stl: "none",
5489 shared_libs: ["libbar"],
5490 system_shared_libs: [],
Jooyung Han5e9013b2020-03-10 06:23:13 +09005491 apex_available: ["myapex"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005492 }
5493
5494 cc_library {
5495 name: "libbar",
5496 stl: "none",
Jooyung Han5e9013b2020-03-10 06:23:13 +09005497 shared_libs: ["libbaz"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005498 system_shared_libs: [],
Jooyung Han5e9013b2020-03-10 06:23:13 +09005499 apex_available: ["myapex"],
5500 }
5501
5502 cc_library {
5503 name: "libbaz",
5504 stl: "none",
5505 system_shared_libs: [],
Jiyong Park127b40b2019-09-30 16:04:35 +09005506 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01005507}
Jiyong Park127b40b2019-09-30 16:04:35 +09005508
Paul Duffine52e66f2020-03-30 17:54:29 +01005509func TestApexAvailable_InvalidApexName(t *testing.T) {
Jiyong Park127b40b2019-09-30 16:04:35 +09005510 testApexError(t, "\"otherapex\" is not a valid module name", `
5511 apex {
5512 name: "myapex",
5513 key: "myapex.key",
5514 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005515 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005516 }
5517
5518 apex_key {
5519 name: "myapex.key",
5520 public_key: "testkey.avbpubkey",
5521 private_key: "testkey.pem",
5522 }
5523
5524 cc_library {
5525 name: "libfoo",
5526 stl: "none",
5527 system_shared_libs: [],
5528 apex_available: ["otherapex"],
5529 }`)
5530
Paul Duffine52e66f2020-03-30 17:54:29 +01005531 testApex(t, `
Jiyong Park127b40b2019-09-30 16:04:35 +09005532 apex {
5533 name: "myapex",
5534 key: "myapex.key",
5535 native_shared_libs: ["libfoo", "libbar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005536 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005537 }
5538
5539 apex_key {
5540 name: "myapex.key",
5541 public_key: "testkey.avbpubkey",
5542 private_key: "testkey.pem",
5543 }
5544
5545 cc_library {
5546 name: "libfoo",
5547 stl: "none",
5548 system_shared_libs: [],
Jiyong Park323a4c32020-03-01 17:29:06 +09005549 runtime_libs: ["libbaz"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005550 apex_available: ["myapex"],
5551 }
5552
5553 cc_library {
5554 name: "libbar",
5555 stl: "none",
5556 system_shared_libs: [],
5557 apex_available: ["//apex_available:anyapex"],
Jiyong Park323a4c32020-03-01 17:29:06 +09005558 }
5559
5560 cc_library {
5561 name: "libbaz",
5562 stl: "none",
5563 system_shared_libs: [],
5564 stubs: {
5565 versions: ["10", "20", "30"],
5566 },
Jiyong Park127b40b2019-09-30 16:04:35 +09005567 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01005568}
Jiyong Park127b40b2019-09-30 16:04:35 +09005569
Jiyong Park89e850a2020-04-07 16:37:39 +09005570func TestApexAvailable_CheckForPlatform(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005571 ctx := testApex(t, `
Jiyong Park127b40b2019-09-30 16:04:35 +09005572 apex {
5573 name: "myapex",
5574 key: "myapex.key",
Jiyong Park89e850a2020-04-07 16:37:39 +09005575 native_shared_libs: ["libbar", "libbaz"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005576 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09005577 }
5578
5579 apex_key {
5580 name: "myapex.key",
5581 public_key: "testkey.avbpubkey",
5582 private_key: "testkey.pem",
5583 }
5584
5585 cc_library {
5586 name: "libfoo",
5587 stl: "none",
5588 system_shared_libs: [],
Jiyong Park89e850a2020-04-07 16:37:39 +09005589 shared_libs: ["libbar"],
Jiyong Park127b40b2019-09-30 16:04:35 +09005590 apex_available: ["//apex_available:platform"],
Jiyong Park89e850a2020-04-07 16:37:39 +09005591 }
5592
5593 cc_library {
5594 name: "libfoo2",
5595 stl: "none",
5596 system_shared_libs: [],
5597 shared_libs: ["libbaz"],
5598 apex_available: ["//apex_available:platform"],
5599 }
5600
5601 cc_library {
5602 name: "libbar",
5603 stl: "none",
5604 system_shared_libs: [],
5605 apex_available: ["myapex"],
5606 }
5607
5608 cc_library {
5609 name: "libbaz",
5610 stl: "none",
5611 system_shared_libs: [],
5612 apex_available: ["myapex"],
5613 stubs: {
5614 versions: ["1"],
5615 },
Jiyong Park127b40b2019-09-30 16:04:35 +09005616 }`)
5617
Jiyong Park89e850a2020-04-07 16:37:39 +09005618 // libfoo shouldn't be available to platform even though it has "//apex_available:platform",
5619 // because it depends on libbar which isn't available to platform
5620 libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
5621 if libfoo.NotAvailableForPlatform() != true {
5622 t.Errorf("%q shouldn't be available to platform", libfoo.String())
5623 }
5624
5625 // libfoo2 however can be available to platform because it depends on libbaz which provides
5626 // stubs
5627 libfoo2 := ctx.ModuleForTests("libfoo2", "android_arm64_armv8-a_shared").Module().(*cc.Module)
5628 if libfoo2.NotAvailableForPlatform() == true {
5629 t.Errorf("%q should be available to platform", libfoo2.String())
5630 }
Paul Duffine52e66f2020-03-30 17:54:29 +01005631}
Jiyong Parka90ca002019-10-07 15:47:24 +09005632
Paul Duffine52e66f2020-03-30 17:54:29 +01005633func TestApexAvailable_CreatedForApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005634 ctx := testApex(t, `
Jiyong Parka90ca002019-10-07 15:47:24 +09005635 apex {
5636 name: "myapex",
5637 key: "myapex.key",
5638 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005639 updatable: false,
Jiyong Parka90ca002019-10-07 15:47:24 +09005640 }
5641
5642 apex_key {
5643 name: "myapex.key",
5644 public_key: "testkey.avbpubkey",
5645 private_key: "testkey.pem",
5646 }
5647
5648 cc_library {
5649 name: "libfoo",
5650 stl: "none",
5651 system_shared_libs: [],
5652 apex_available: ["myapex"],
5653 static: {
5654 apex_available: ["//apex_available:platform"],
5655 },
5656 }`)
5657
Jiyong Park89e850a2020-04-07 16:37:39 +09005658 libfooShared := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
5659 if libfooShared.NotAvailableForPlatform() != true {
5660 t.Errorf("%q shouldn't be available to platform", libfooShared.String())
5661 }
5662 libfooStatic := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_static").Module().(*cc.Module)
5663 if libfooStatic.NotAvailableForPlatform() != false {
5664 t.Errorf("%q should be available to platform", libfooStatic.String())
5665 }
Jiyong Park127b40b2019-09-30 16:04:35 +09005666}
5667
Jiyong Park5d790c32019-11-15 18:40:32 +09005668func TestOverrideApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005669 ctx := testApex(t, `
Jiyong Park5d790c32019-11-15 18:40:32 +09005670 apex {
5671 name: "myapex",
5672 key: "myapex.key",
5673 apps: ["app"],
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08005674 overrides: ["oldapex"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005675 updatable: false,
Jiyong Park5d790c32019-11-15 18:40:32 +09005676 }
5677
5678 override_apex {
5679 name: "override_myapex",
5680 base: "myapex",
5681 apps: ["override_app"],
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08005682 overrides: ["unknownapex"],
Baligh Uddin004d7172020-02-19 21:29:28 -08005683 logging_parent: "com.foo.bar",
Baligh Uddin5b57dba2020-03-15 13:01:05 -07005684 package_name: "test.overridden.package",
Jaewoong Jung4cfdf7d2021-04-20 16:21:24 -07005685 key: "mynewapex.key",
5686 certificate: ":myapex.certificate",
Jiyong Park5d790c32019-11-15 18:40:32 +09005687 }
5688
5689 apex_key {
5690 name: "myapex.key",
5691 public_key: "testkey.avbpubkey",
5692 private_key: "testkey.pem",
5693 }
5694
Jaewoong Jung4cfdf7d2021-04-20 16:21:24 -07005695 apex_key {
5696 name: "mynewapex.key",
5697 public_key: "testkey2.avbpubkey",
5698 private_key: "testkey2.pem",
5699 }
5700
5701 android_app_certificate {
5702 name: "myapex.certificate",
5703 certificate: "testkey",
5704 }
5705
Jiyong Park5d790c32019-11-15 18:40:32 +09005706 android_app {
5707 name: "app",
5708 srcs: ["foo/bar/MyClass.java"],
5709 package_name: "foo",
5710 sdk_version: "none",
5711 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005712 apex_available: [ "myapex" ],
Jiyong Park5d790c32019-11-15 18:40:32 +09005713 }
5714
5715 override_android_app {
5716 name: "override_app",
5717 base: "app",
5718 package_name: "bar",
5719 }
Jiyong Park20bacab2020-03-03 11:45:41 +09005720 `, withManifestPackageNameOverrides([]string{"myapex:com.android.myapex"}))
Jiyong Park5d790c32019-11-15 18:40:32 +09005721
Jiyong Park317645e2019-12-05 13:20:58 +09005722 originalVariant := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(android.OverridableModule)
5723 overriddenVariant := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Module().(android.OverridableModule)
5724 if originalVariant.GetOverriddenBy() != "" {
5725 t.Errorf("GetOverriddenBy should be empty, but was %q", originalVariant.GetOverriddenBy())
5726 }
5727 if overriddenVariant.GetOverriddenBy() != "override_myapex" {
5728 t.Errorf("GetOverriddenBy should be \"override_myapex\", but was %q", overriddenVariant.GetOverriddenBy())
5729 }
5730
Jiyong Park5d790c32019-11-15 18:40:32 +09005731 module := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image")
5732 apexRule := module.Rule("apexRule")
5733 copyCmds := apexRule.Args["copy_commands"]
5734
5735 ensureNotContains(t, copyCmds, "image.apex/app/app/app.apk")
Jooyung Han39ee1192020-03-23 20:21:11 +09005736 ensureContains(t, copyCmds, "image.apex/app/override_app/override_app.apk")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005737
5738 apexBundle := module.Module().(*apexBundle)
5739 name := apexBundle.Name()
5740 if name != "override_myapex" {
5741 t.Errorf("name should be \"override_myapex\", but was %q", name)
5742 }
5743
Baligh Uddin004d7172020-02-19 21:29:28 -08005744 if apexBundle.overridableProperties.Logging_parent != "com.foo.bar" {
5745 t.Errorf("override_myapex should have logging parent (com.foo.bar), but was %q.", apexBundle.overridableProperties.Logging_parent)
5746 }
5747
Jiyong Park20bacab2020-03-03 11:45:41 +09005748 optFlags := apexRule.Args["opt_flags"]
Baligh Uddin5b57dba2020-03-15 13:01:05 -07005749 ensureContains(t, optFlags, "--override_apk_package_name test.overridden.package")
Jaewoong Jung4cfdf7d2021-04-20 16:21:24 -07005750 ensureContains(t, optFlags, "--pubkey testkey2.avbpubkey")
5751
5752 signApkRule := module.Rule("signapk")
5753 ensureEquals(t, signApkRule.Args["certificates"], "testkey.x509.pem testkey.pk8")
Jiyong Park20bacab2020-03-03 11:45:41 +09005754
Colin Crossaa255532020-07-03 13:18:24 -07005755 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005756 var builder strings.Builder
5757 data.Custom(&builder, name, "TARGET_", "", data)
5758 androidMk := builder.String()
Jiyong Parkf653b052019-11-18 15:39:01 +09005759 ensureContains(t, androidMk, "LOCAL_MODULE := override_app.override_myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005760 ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.override_myapex")
5761 ensureContains(t, androidMk, "LOCAL_MODULE_STEM := override_myapex.apex")
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08005762 ensureContains(t, androidMk, "LOCAL_OVERRIDES_MODULES := unknownapex myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005763 ensureNotContains(t, androidMk, "LOCAL_MODULE := app.myapex")
Jiyong Parkf653b052019-11-18 15:39:01 +09005764 ensureNotContains(t, androidMk, "LOCAL_MODULE := override_app.myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08005765 ensureNotContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex")
5766 ensureNotContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.apex")
Jiyong Park5d790c32019-11-15 18:40:32 +09005767}
5768
Jooyung Han214bf372019-11-12 13:03:50 +09005769func TestLegacyAndroid10Support(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005770 ctx := testApex(t, `
Jooyung Han214bf372019-11-12 13:03:50 +09005771 apex {
5772 name: "myapex",
5773 key: "myapex.key",
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005774 native_shared_libs: ["mylib"],
Jooyung Han5417f772020-03-12 18:37:20 +09005775 min_sdk_version: "29",
Jooyung Han214bf372019-11-12 13:03:50 +09005776 }
5777
5778 apex_key {
5779 name: "myapex.key",
5780 public_key: "testkey.avbpubkey",
5781 private_key: "testkey.pem",
5782 }
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005783
5784 cc_library {
5785 name: "mylib",
5786 srcs: ["mylib.cpp"],
5787 stl: "libc++",
5788 system_shared_libs: [],
5789 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09005790 min_sdk_version: "29",
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005791 }
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005792 `, withUnbundledBuild)
Jooyung Han214bf372019-11-12 13:03:50 +09005793
5794 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
5795 args := module.Rule("apexRule").Args
5796 ensureContains(t, args["opt_flags"], "--manifest_json "+module.Output("apex_manifest.json").Output.String())
Dario Frenie3546902020-01-14 23:50:25 +00005797 ensureNotContains(t, args["opt_flags"], "--no_hashtree")
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005798
5799 // The copies of the libraries in the apex should have one more dependency than
5800 // the ones outside the apex, namely the unwinder. Ideally we should check
5801 // the dependency names directly here but for some reason the names are blank in
5802 // this test.
5803 for _, lib := range []string{"libc++", "mylib"} {
Colin Crossaede88c2020-08-11 12:17:01 -07005804 apexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared_apex29").Rule("ld").Implicits
Peter Collingbournedc4f9862020-02-12 17:13:25 -08005805 nonApexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared").Rule("ld").Implicits
5806 if len(apexImplicits) != len(nonApexImplicits)+1 {
5807 t.Errorf("%q missing unwinder dep", lib)
5808 }
5809 }
Jooyung Han214bf372019-11-12 13:03:50 +09005810}
5811
Paul Duffine05480a2021-03-08 15:07:14 +00005812var filesForSdkLibrary = android.MockFS{
Paul Duffin9b879592020-05-26 13:21:35 +01005813 "api/current.txt": nil,
5814 "api/removed.txt": nil,
5815 "api/system-current.txt": nil,
5816 "api/system-removed.txt": nil,
5817 "api/test-current.txt": nil,
5818 "api/test-removed.txt": nil,
Paul Duffineedc5d52020-06-12 17:46:39 +01005819
Anton Hanssondff2c782020-12-21 17:10:01 +00005820 "100/public/api/foo.txt": nil,
5821 "100/public/api/foo-removed.txt": nil,
5822 "100/system/api/foo.txt": nil,
5823 "100/system/api/foo-removed.txt": nil,
5824
Paul Duffineedc5d52020-06-12 17:46:39 +01005825 // For java_sdk_library_import
5826 "a.jar": nil,
Paul Duffin9b879592020-05-26 13:21:35 +01005827}
5828
Jooyung Han58f26ab2019-12-18 15:34:32 +09005829func TestJavaSDKLibrary(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005830 ctx := testApex(t, `
Jooyung Han58f26ab2019-12-18 15:34:32 +09005831 apex {
5832 name: "myapex",
5833 key: "myapex.key",
5834 java_libs: ["foo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005835 updatable: false,
Jooyung Han58f26ab2019-12-18 15:34:32 +09005836 }
5837
5838 apex_key {
5839 name: "myapex.key",
5840 public_key: "testkey.avbpubkey",
5841 private_key: "testkey.pem",
5842 }
5843
5844 java_sdk_library {
5845 name: "foo",
5846 srcs: ["a.java"],
5847 api_packages: ["foo"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005848 apex_available: [ "myapex" ],
Jooyung Han58f26ab2019-12-18 15:34:32 +09005849 }
Anton Hanssondff2c782020-12-21 17:10:01 +00005850
5851 prebuilt_apis {
5852 name: "sdk",
5853 api_dirs: ["100"],
5854 }
Paul Duffin9b879592020-05-26 13:21:35 +01005855 `, withFiles(filesForSdkLibrary))
Jooyung Han58f26ab2019-12-18 15:34:32 +09005856
5857 // java_sdk_library installs both impl jar and permission XML
Jooyung Hana57af4a2020-01-23 05:36:59 +00005858 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Han58f26ab2019-12-18 15:34:32 +09005859 "javalib/foo.jar",
5860 "etc/permissions/foo.xml",
5861 })
5862 // Permission XML should point to the activated path of impl jar of java_sdk_library
Jiyong Parke3833882020-02-17 17:28:10 +09005863 sdkLibrary := ctx.ModuleForTests("foo.xml", "android_common_myapex").Rule("java_sdk_xml")
5864 ensureContains(t, sdkLibrary.RuleParams.Command, `<library name=\"foo\" file=\"/apex/myapex/javalib/foo.jar\"`)
Jooyung Han58f26ab2019-12-18 15:34:32 +09005865}
5866
Paul Duffin9b879592020-05-26 13:21:35 +01005867func TestJavaSDKLibrary_WithinApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005868 ctx := testApex(t, `
Paul Duffin9b879592020-05-26 13:21:35 +01005869 apex {
5870 name: "myapex",
5871 key: "myapex.key",
5872 java_libs: ["foo", "bar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005873 updatable: false,
Paul Duffin9b879592020-05-26 13:21:35 +01005874 }
5875
5876 apex_key {
5877 name: "myapex.key",
5878 public_key: "testkey.avbpubkey",
5879 private_key: "testkey.pem",
5880 }
5881
5882 java_sdk_library {
5883 name: "foo",
5884 srcs: ["a.java"],
5885 api_packages: ["foo"],
5886 apex_available: ["myapex"],
5887 sdk_version: "none",
5888 system_modules: "none",
5889 }
5890
5891 java_library {
5892 name: "bar",
5893 srcs: ["a.java"],
5894 libs: ["foo"],
5895 apex_available: ["myapex"],
5896 sdk_version: "none",
5897 system_modules: "none",
5898 }
Anton Hanssondff2c782020-12-21 17:10:01 +00005899
5900 prebuilt_apis {
5901 name: "sdk",
5902 api_dirs: ["100"],
5903 }
Paul Duffin9b879592020-05-26 13:21:35 +01005904 `, withFiles(filesForSdkLibrary))
5905
5906 // java_sdk_library installs both impl jar and permission XML
5907 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
5908 "javalib/bar.jar",
5909 "javalib/foo.jar",
5910 "etc/permissions/foo.xml",
5911 })
5912
5913 // The bar library should depend on the implementation jar.
5914 barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
Paul Duffincf8d7db2021-03-29 00:29:53 +01005915 if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Paul Duffin9b879592020-05-26 13:21:35 +01005916 t.Errorf("expected %q, found %#q", expected, actual)
5917 }
5918}
5919
5920func TestJavaSDKLibrary_CrossBoundary(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005921 ctx := testApex(t, `
Paul Duffin9b879592020-05-26 13:21:35 +01005922 apex {
5923 name: "myapex",
5924 key: "myapex.key",
5925 java_libs: ["foo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005926 updatable: false,
Paul Duffin9b879592020-05-26 13:21:35 +01005927 }
5928
5929 apex_key {
5930 name: "myapex.key",
5931 public_key: "testkey.avbpubkey",
5932 private_key: "testkey.pem",
5933 }
5934
5935 java_sdk_library {
5936 name: "foo",
5937 srcs: ["a.java"],
5938 api_packages: ["foo"],
5939 apex_available: ["myapex"],
5940 sdk_version: "none",
5941 system_modules: "none",
5942 }
5943
5944 java_library {
5945 name: "bar",
5946 srcs: ["a.java"],
5947 libs: ["foo"],
5948 sdk_version: "none",
5949 system_modules: "none",
5950 }
Anton Hanssondff2c782020-12-21 17:10:01 +00005951
5952 prebuilt_apis {
5953 name: "sdk",
5954 api_dirs: ["100"],
5955 }
Paul Duffin9b879592020-05-26 13:21:35 +01005956 `, withFiles(filesForSdkLibrary))
5957
5958 // java_sdk_library installs both impl jar and permission XML
5959 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
5960 "javalib/foo.jar",
5961 "etc/permissions/foo.xml",
5962 })
5963
5964 // The bar library should depend on the stubs jar.
5965 barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
Paul Duffincf8d7db2021-03-29 00:29:53 +01005966 if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Paul Duffin9b879592020-05-26 13:21:35 +01005967 t.Errorf("expected %q, found %#q", expected, actual)
5968 }
5969}
5970
Paul Duffineedc5d52020-06-12 17:46:39 +01005971func TestJavaSDKLibrary_ImportPreferred(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005972 ctx := testApex(t, `
Anton Hanssondff2c782020-12-21 17:10:01 +00005973 prebuilt_apis {
5974 name: "sdk",
5975 api_dirs: ["100"],
5976 }`,
Paul Duffineedc5d52020-06-12 17:46:39 +01005977 withFiles(map[string][]byte{
5978 "apex/a.java": nil,
5979 "apex/apex_manifest.json": nil,
5980 "apex/Android.bp": []byte(`
5981 package {
5982 default_visibility: ["//visibility:private"],
5983 }
5984
5985 apex {
5986 name: "myapex",
5987 key: "myapex.key",
5988 java_libs: ["foo", "bar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005989 updatable: false,
Paul Duffineedc5d52020-06-12 17:46:39 +01005990 }
5991
5992 apex_key {
5993 name: "myapex.key",
5994 public_key: "testkey.avbpubkey",
5995 private_key: "testkey.pem",
5996 }
5997
5998 java_library {
5999 name: "bar",
6000 srcs: ["a.java"],
6001 libs: ["foo"],
6002 apex_available: ["myapex"],
6003 sdk_version: "none",
6004 system_modules: "none",
6005 }
6006`),
6007 "source/a.java": nil,
6008 "source/api/current.txt": nil,
6009 "source/api/removed.txt": nil,
6010 "source/Android.bp": []byte(`
6011 package {
6012 default_visibility: ["//visibility:private"],
6013 }
6014
6015 java_sdk_library {
6016 name: "foo",
6017 visibility: ["//apex"],
6018 srcs: ["a.java"],
6019 api_packages: ["foo"],
6020 apex_available: ["myapex"],
6021 sdk_version: "none",
6022 system_modules: "none",
6023 public: {
6024 enabled: true,
6025 },
6026 }
6027`),
6028 "prebuilt/a.jar": nil,
6029 "prebuilt/Android.bp": []byte(`
6030 package {
6031 default_visibility: ["//visibility:private"],
6032 }
6033
6034 java_sdk_library_import {
6035 name: "foo",
6036 visibility: ["//apex", "//source"],
6037 apex_available: ["myapex"],
6038 prefer: true,
6039 public: {
6040 jars: ["a.jar"],
6041 },
6042 }
6043`),
Anton Hanssondff2c782020-12-21 17:10:01 +00006044 }), withFiles(filesForSdkLibrary),
Paul Duffineedc5d52020-06-12 17:46:39 +01006045 )
6046
6047 // java_sdk_library installs both impl jar and permission XML
6048 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
6049 "javalib/bar.jar",
6050 "javalib/foo.jar",
6051 "etc/permissions/foo.xml",
6052 })
6053
6054 // The bar library should depend on the implementation jar.
6055 barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
Paul Duffincf8d7db2021-03-29 00:29:53 +01006056 if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.impl\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Paul Duffineedc5d52020-06-12 17:46:39 +01006057 t.Errorf("expected %q, found %#q", expected, actual)
6058 }
6059}
6060
6061func TestJavaSDKLibrary_ImportOnly(t *testing.T) {
6062 testApexError(t, `java_libs: "foo" is not configured to be compiled into dex`, `
6063 apex {
6064 name: "myapex",
6065 key: "myapex.key",
6066 java_libs: ["foo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006067 updatable: false,
Paul Duffineedc5d52020-06-12 17:46:39 +01006068 }
6069
6070 apex_key {
6071 name: "myapex.key",
6072 public_key: "testkey.avbpubkey",
6073 private_key: "testkey.pem",
6074 }
6075
6076 java_sdk_library_import {
6077 name: "foo",
6078 apex_available: ["myapex"],
6079 prefer: true,
6080 public: {
6081 jars: ["a.jar"],
6082 },
6083 }
6084
6085 `, withFiles(filesForSdkLibrary))
6086}
6087
atrost6e126252020-01-27 17:01:16 +00006088func TestCompatConfig(t *testing.T) {
Paul Duffin284165a2021-03-29 01:50:31 +01006089 result := android.GroupFixturePreparers(
6090 prepareForApexTest,
6091 java.PrepareForTestWithPlatformCompatConfig,
6092 ).RunTestWithBp(t, `
atrost6e126252020-01-27 17:01:16 +00006093 apex {
6094 name: "myapex",
6095 key: "myapex.key",
Paul Duffin3abc1742021-03-15 19:32:23 +00006096 compat_configs: ["myjar-platform-compat-config"],
atrost6e126252020-01-27 17:01:16 +00006097 java_libs: ["myjar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006098 updatable: false,
atrost6e126252020-01-27 17:01:16 +00006099 }
6100
6101 apex_key {
6102 name: "myapex.key",
6103 public_key: "testkey.avbpubkey",
6104 private_key: "testkey.pem",
6105 }
6106
6107 platform_compat_config {
6108 name: "myjar-platform-compat-config",
6109 src: ":myjar",
6110 }
6111
6112 java_library {
6113 name: "myjar",
6114 srcs: ["foo/bar/MyClass.java"],
6115 sdk_version: "none",
6116 system_modules: "none",
atrost6e126252020-01-27 17:01:16 +00006117 apex_available: [ "myapex" ],
6118 }
Paul Duffin1b29e002021-03-16 15:06:54 +00006119
6120 // Make sure that a preferred prebuilt does not affect the apex contents.
6121 prebuilt_platform_compat_config {
6122 name: "myjar-platform-compat-config",
6123 metadata: "compat-config/metadata.xml",
6124 prefer: true,
6125 }
atrost6e126252020-01-27 17:01:16 +00006126 `)
Paul Duffina369c7b2021-03-09 03:08:05 +00006127 ctx := result.TestContext
atrost6e126252020-01-27 17:01:16 +00006128 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
6129 "etc/compatconfig/myjar-platform-compat-config.xml",
6130 "javalib/myjar.jar",
6131 })
6132}
6133
Jiyong Park479321d2019-12-16 11:47:12 +09006134func TestRejectNonInstallableJavaLibrary(t *testing.T) {
6135 testApexError(t, `"myjar" is not configured to be compiled into dex`, `
6136 apex {
6137 name: "myapex",
6138 key: "myapex.key",
6139 java_libs: ["myjar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006140 updatable: false,
Jiyong Park479321d2019-12-16 11:47:12 +09006141 }
6142
6143 apex_key {
6144 name: "myapex.key",
6145 public_key: "testkey.avbpubkey",
6146 private_key: "testkey.pem",
6147 }
6148
6149 java_library {
6150 name: "myjar",
6151 srcs: ["foo/bar/MyClass.java"],
6152 sdk_version: "none",
6153 system_modules: "none",
Jiyong Park6b21c7d2020-02-11 09:16:01 +09006154 compile_dex: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09006155 apex_available: ["myapex"],
Jiyong Park479321d2019-12-16 11:47:12 +09006156 }
6157 `)
6158}
6159
Jiyong Park7afd1072019-12-30 16:56:33 +09006160func TestCarryRequiredModuleNames(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006161 ctx := testApex(t, `
Jiyong Park7afd1072019-12-30 16:56:33 +09006162 apex {
6163 name: "myapex",
6164 key: "myapex.key",
6165 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006166 updatable: false,
Jiyong Park7afd1072019-12-30 16:56:33 +09006167 }
6168
6169 apex_key {
6170 name: "myapex.key",
6171 public_key: "testkey.avbpubkey",
6172 private_key: "testkey.pem",
6173 }
6174
6175 cc_library {
6176 name: "mylib",
6177 srcs: ["mylib.cpp"],
6178 system_shared_libs: [],
6179 stl: "none",
6180 required: ["a", "b"],
6181 host_required: ["c", "d"],
6182 target_required: ["e", "f"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00006183 apex_available: [ "myapex" ],
Jiyong Park7afd1072019-12-30 16:56:33 +09006184 }
6185 `)
6186
6187 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07006188 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jiyong Park7afd1072019-12-30 16:56:33 +09006189 name := apexBundle.BaseModuleName()
6190 prefix := "TARGET_"
6191 var builder strings.Builder
6192 data.Custom(&builder, name, prefix, "", data)
6193 androidMk := builder.String()
6194 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += a b\n")
6195 ensureContains(t, androidMk, "LOCAL_HOST_REQUIRED_MODULES += c d\n")
6196 ensureContains(t, androidMk, "LOCAL_TARGET_REQUIRED_MODULES += e f\n")
6197}
6198
Jiyong Park7cd10e32020-01-14 09:22:18 +09006199func TestSymlinksFromApexToSystem(t *testing.T) {
6200 bp := `
6201 apex {
6202 name: "myapex",
6203 key: "myapex.key",
6204 native_shared_libs: ["mylib"],
6205 java_libs: ["myjar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006206 updatable: false,
Jiyong Park7cd10e32020-01-14 09:22:18 +09006207 }
6208
Jiyong Park9d677202020-02-19 16:29:35 +09006209 apex {
6210 name: "myapex.updatable",
6211 key: "myapex.key",
6212 native_shared_libs: ["mylib"],
6213 java_libs: ["myjar"],
6214 updatable: true,
Jooyung Han548640b2020-04-27 12:10:30 +09006215 min_sdk_version: "current",
Jiyong Park9d677202020-02-19 16:29:35 +09006216 }
6217
Jiyong Park7cd10e32020-01-14 09:22:18 +09006218 apex_key {
6219 name: "myapex.key",
6220 public_key: "testkey.avbpubkey",
6221 private_key: "testkey.pem",
6222 }
6223
6224 cc_library {
6225 name: "mylib",
6226 srcs: ["mylib.cpp"],
6227 shared_libs: ["myotherlib"],
6228 system_shared_libs: [],
6229 stl: "none",
6230 apex_available: [
6231 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006232 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006233 "//apex_available:platform",
6234 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006235 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006236 }
6237
6238 cc_library {
6239 name: "myotherlib",
6240 srcs: ["mylib.cpp"],
6241 system_shared_libs: [],
6242 stl: "none",
6243 apex_available: [
6244 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006245 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006246 "//apex_available:platform",
6247 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006248 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006249 }
6250
6251 java_library {
6252 name: "myjar",
6253 srcs: ["foo/bar/MyClass.java"],
6254 sdk_version: "none",
6255 system_modules: "none",
6256 libs: ["myotherjar"],
Jiyong Park7cd10e32020-01-14 09:22:18 +09006257 apex_available: [
6258 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006259 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006260 "//apex_available:platform",
6261 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006262 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006263 }
6264
6265 java_library {
6266 name: "myotherjar",
6267 srcs: ["foo/bar/MyClass.java"],
6268 sdk_version: "none",
6269 system_modules: "none",
6270 apex_available: [
6271 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09006272 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006273 "//apex_available:platform",
6274 ],
Jooyung Han749dc692020-04-15 11:03:39 +09006275 min_sdk_version: "current",
Jiyong Park7cd10e32020-01-14 09:22:18 +09006276 }
6277 `
6278
6279 ensureRealfileExists := func(t *testing.T, files []fileInApex, file string) {
6280 for _, f := range files {
6281 if f.path == file {
6282 if f.isLink {
6283 t.Errorf("%q is not a real file", file)
6284 }
6285 return
6286 }
6287 }
6288 t.Errorf("%q is not found", file)
6289 }
6290
6291 ensureSymlinkExists := func(t *testing.T, files []fileInApex, file string) {
6292 for _, f := range files {
6293 if f.path == file {
6294 if !f.isLink {
6295 t.Errorf("%q is not a symlink", file)
6296 }
6297 return
6298 }
6299 }
6300 t.Errorf("%q is not found", file)
6301 }
6302
Jiyong Park9d677202020-02-19 16:29:35 +09006303 // For unbundled build, symlink shouldn't exist regardless of whether an APEX
6304 // is updatable or not
Colin Cross1c460562021-02-16 17:55:47 -08006305 ctx := testApex(t, bp, withUnbundledBuild)
Jooyung Hana57af4a2020-01-23 05:36:59 +00006306 files := getFiles(t, ctx, "myapex", "android_common_myapex_image")
Jiyong Park7cd10e32020-01-14 09:22:18 +09006307 ensureRealfileExists(t, files, "javalib/myjar.jar")
6308 ensureRealfileExists(t, files, "lib64/mylib.so")
6309 ensureRealfileExists(t, files, "lib64/myotherlib.so")
6310
Jiyong Park9d677202020-02-19 16:29:35 +09006311 files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
6312 ensureRealfileExists(t, files, "javalib/myjar.jar")
6313 ensureRealfileExists(t, files, "lib64/mylib.so")
6314 ensureRealfileExists(t, files, "lib64/myotherlib.so")
6315
6316 // For bundled build, symlink to the system for the non-updatable APEXes only
Colin Cross1c460562021-02-16 17:55:47 -08006317 ctx = testApex(t, bp)
Jooyung Hana57af4a2020-01-23 05:36:59 +00006318 files = getFiles(t, ctx, "myapex", "android_common_myapex_image")
Jiyong Park7cd10e32020-01-14 09:22:18 +09006319 ensureRealfileExists(t, files, "javalib/myjar.jar")
6320 ensureRealfileExists(t, files, "lib64/mylib.so")
6321 ensureSymlinkExists(t, files, "lib64/myotherlib.so") // this is symlink
Jiyong Park9d677202020-02-19 16:29:35 +09006322
6323 files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
6324 ensureRealfileExists(t, files, "javalib/myjar.jar")
6325 ensureRealfileExists(t, files, "lib64/mylib.so")
6326 ensureRealfileExists(t, files, "lib64/myotherlib.so") // this is a real file
Jiyong Park7cd10e32020-01-14 09:22:18 +09006327}
6328
Yo Chiange8128052020-07-23 20:09:18 +08006329func TestSymlinksFromApexToSystemRequiredModuleNames(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006330 ctx := testApex(t, `
Yo Chiange8128052020-07-23 20:09:18 +08006331 apex {
6332 name: "myapex",
6333 key: "myapex.key",
6334 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006335 updatable: false,
Yo Chiange8128052020-07-23 20:09:18 +08006336 }
6337
6338 apex_key {
6339 name: "myapex.key",
6340 public_key: "testkey.avbpubkey",
6341 private_key: "testkey.pem",
6342 }
6343
6344 cc_library_shared {
6345 name: "mylib",
6346 srcs: ["mylib.cpp"],
6347 shared_libs: ["myotherlib"],
6348 system_shared_libs: [],
6349 stl: "none",
6350 apex_available: [
6351 "myapex",
6352 "//apex_available:platform",
6353 ],
6354 }
6355
6356 cc_prebuilt_library_shared {
6357 name: "myotherlib",
6358 srcs: ["prebuilt.so"],
6359 system_shared_libs: [],
6360 stl: "none",
6361 apex_available: [
6362 "myapex",
6363 "//apex_available:platform",
6364 ],
6365 }
6366 `)
6367
6368 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07006369 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Yo Chiange8128052020-07-23 20:09:18 +08006370 var builder strings.Builder
6371 data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
6372 androidMk := builder.String()
6373 // `myotherlib` is added to `myapex` as symlink
6374 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
6375 ensureNotContains(t, androidMk, "LOCAL_MODULE := prebuilt_myotherlib.myapex\n")
6376 ensureNotContains(t, androidMk, "LOCAL_MODULE := myotherlib.myapex\n")
6377 // `myapex` should have `myotherlib` in its required line, not `prebuilt_myotherlib`
Jiyong Park57621b22021-01-20 20:33:11 +09006378 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += mylib.myapex:64 myotherlib:64 apex_manifest.pb.myapex apex_pubkey.myapex\n")
Yo Chiange8128052020-07-23 20:09:18 +08006379}
6380
Jooyung Han643adc42020-02-27 13:50:06 +09006381func TestApexWithJniLibs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006382 ctx := testApex(t, `
Jooyung Han643adc42020-02-27 13:50:06 +09006383 apex {
6384 name: "myapex",
6385 key: "myapex.key",
6386 jni_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006387 updatable: false,
Jooyung Han643adc42020-02-27 13:50:06 +09006388 }
6389
6390 apex_key {
6391 name: "myapex.key",
6392 public_key: "testkey.avbpubkey",
6393 private_key: "testkey.pem",
6394 }
6395
6396 cc_library {
6397 name: "mylib",
6398 srcs: ["mylib.cpp"],
6399 shared_libs: ["mylib2"],
6400 system_shared_libs: [],
6401 stl: "none",
6402 apex_available: [ "myapex" ],
6403 }
6404
6405 cc_library {
6406 name: "mylib2",
6407 srcs: ["mylib.cpp"],
6408 system_shared_libs: [],
6409 stl: "none",
6410 apex_available: [ "myapex" ],
6411 }
6412 `)
6413
6414 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
6415 // Notice mylib2.so (transitive dep) is not added as a jni_lib
6416 ensureEquals(t, rule.Args["opt"], "-a jniLibs mylib.so")
6417 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
6418 "lib64/mylib.so",
6419 "lib64/mylib2.so",
6420 })
6421}
6422
Jooyung Han49f67012020-04-17 13:43:10 +09006423func TestApexMutatorsDontRunIfDisabled(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006424 ctx := testApex(t, `
Jooyung Han49f67012020-04-17 13:43:10 +09006425 apex {
6426 name: "myapex",
6427 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006428 updatable: false,
Jooyung Han49f67012020-04-17 13:43:10 +09006429 }
6430 apex_key {
6431 name: "myapex.key",
6432 public_key: "testkey.avbpubkey",
6433 private_key: "testkey.pem",
6434 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00006435 `,
6436 android.FixtureModifyConfig(func(config android.Config) {
6437 delete(config.Targets, android.Android)
6438 config.AndroidCommonTarget = android.Target{}
6439 }),
6440 )
Jooyung Han49f67012020-04-17 13:43:10 +09006441
6442 if expected, got := []string{""}, ctx.ModuleVariantsForTests("myapex"); !reflect.DeepEqual(expected, got) {
6443 t.Errorf("Expected variants: %v, but got: %v", expected, got)
6444 }
6445}
6446
Jiyong Parkbd159612020-02-28 15:22:21 +09006447func TestAppBundle(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006448 ctx := testApex(t, `
Jiyong Parkbd159612020-02-28 15:22:21 +09006449 apex {
6450 name: "myapex",
6451 key: "myapex.key",
6452 apps: ["AppFoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006453 updatable: false,
Jiyong Parkbd159612020-02-28 15:22:21 +09006454 }
6455
6456 apex_key {
6457 name: "myapex.key",
6458 public_key: "testkey.avbpubkey",
6459 private_key: "testkey.pem",
6460 }
6461
6462 android_app {
6463 name: "AppFoo",
6464 srcs: ["foo/bar/MyClass.java"],
6465 sdk_version: "none",
6466 system_modules: "none",
6467 apex_available: [ "myapex" ],
6468 }
Jiyong Parkcfaa1642020-02-28 16:51:07 +09006469 `, withManifestPackageNameOverrides([]string{"AppFoo:com.android.foo"}))
Jiyong Parkbd159612020-02-28 15:22:21 +09006470
Colin Crosscf371cc2020-11-13 11:48:42 -08006471 bundleConfigRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("bundle_config.json")
Jiyong Parkbd159612020-02-28 15:22:21 +09006472 content := bundleConfigRule.Args["content"]
6473
6474 ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
Jiyong Parkcfaa1642020-02-28 16:51:07 +09006475 ensureContains(t, content, `"apex_config":{"apex_embedded_apk_config":[{"package_name":"com.android.foo","path":"app/AppFoo/AppFoo.apk"}]}`)
Jiyong Parkbd159612020-02-28 15:22:21 +09006476}
6477
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006478func TestAppSetBundle(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006479 ctx := testApex(t, `
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006480 apex {
6481 name: "myapex",
6482 key: "myapex.key",
6483 apps: ["AppSet"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006484 updatable: false,
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006485 }
6486
6487 apex_key {
6488 name: "myapex.key",
6489 public_key: "testkey.avbpubkey",
6490 private_key: "testkey.pem",
6491 }
6492
6493 android_app_set {
6494 name: "AppSet",
6495 set: "AppSet.apks",
6496 }`)
6497 mod := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Colin Crosscf371cc2020-11-13 11:48:42 -08006498 bundleConfigRule := mod.Output("bundle_config.json")
Sasha Smundak18d98bc2020-05-27 16:36:07 -07006499 content := bundleConfigRule.Args["content"]
6500 ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
6501 s := mod.Rule("apexRule").Args["copy_commands"]
6502 copyCmds := regexp.MustCompile(" *&& *").Split(s, -1)
6503 if len(copyCmds) != 3 {
6504 t.Fatalf("Expected 3 commands, got %d in:\n%s", len(copyCmds), s)
6505 }
6506 ensureMatches(t, copyCmds[0], "^rm -rf .*/app/AppSet$")
6507 ensureMatches(t, copyCmds[1], "^mkdir -p .*/app/AppSet$")
6508 ensureMatches(t, copyCmds[2], "^unzip .*-d .*/app/AppSet .*/AppSet.zip$")
6509}
6510
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006511func TestAppSetBundlePrebuilt(t *testing.T) {
Paul Duffin24704672021-04-06 16:09:30 +01006512 bp := `
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006513 apex_set {
6514 name: "myapex",
6515 filename: "foo_v2.apex",
6516 sanitized: {
6517 none: { set: "myapex.apks", },
6518 hwaddress: { set: "myapex.hwasan.apks", },
6519 },
Paul Duffin24704672021-04-06 16:09:30 +01006520 }
6521 `
6522 ctx := testApex(t, bp, prepareForTestWithSantitizeHwaddress)
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006523
Paul Duffin24704672021-04-06 16:09:30 +01006524 // Check that the extractor produces the correct output file from the correct input file.
6525 extractorOutput := "out/soong/.intermediates/myapex.apex.extractor/android_common/extracted/myapex.hwasan.apks"
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006526
Paul Duffin24704672021-04-06 16:09:30 +01006527 m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
6528 extractedApex := m.Output(extractorOutput)
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006529
Paul Duffin24704672021-04-06 16:09:30 +01006530 android.AssertArrayString(t, "extractor input", []string{"myapex.hwasan.apks"}, extractedApex.Inputs.Strings())
6531
6532 // Ditto for the apex.
Paul Duffin6717d882021-06-15 19:09:41 +01006533 m = ctx.ModuleForTests("myapex", "android_common_myapex")
6534 copiedApex := m.Output("out/soong/.intermediates/myapex/android_common_myapex/foo_v2.apex")
Paul Duffin24704672021-04-06 16:09:30 +01006535
6536 android.AssertStringEquals(t, "myapex input", extractorOutput, copiedApex.Input.String())
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07006537}
6538
Paul Duffin89f570a2021-06-16 01:42:33 +01006539func testNoUpdatableJarsInBootImage(t *testing.T, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) {
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006540 t.Helper()
6541
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006542 bp := `
6543 java_library {
6544 name: "some-updatable-apex-lib",
6545 srcs: ["a.java"],
6546 sdk_version: "current",
6547 apex_available: [
6548 "some-updatable-apex",
6549 ],
6550 }
6551
6552 java_library {
6553 name: "some-non-updatable-apex-lib",
6554 srcs: ["a.java"],
6555 apex_available: [
6556 "some-non-updatable-apex",
6557 ],
Paul Duffin89f570a2021-06-16 01:42:33 +01006558 compile_dex: true,
6559 }
6560
6561 bootclasspath_fragment {
6562 name: "some-non-updatable-fragment",
6563 contents: ["some-non-updatable-apex-lib"],
6564 apex_available: [
6565 "some-non-updatable-apex",
6566 ],
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006567 }
6568
6569 java_library {
6570 name: "some-platform-lib",
6571 srcs: ["a.java"],
6572 sdk_version: "current",
6573 installable: true,
6574 }
6575
6576 java_library {
6577 name: "some-art-lib",
6578 srcs: ["a.java"],
6579 sdk_version: "current",
6580 apex_available: [
Paul Duffind376f792021-01-26 11:59:35 +00006581 "com.android.art.debug",
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006582 ],
6583 hostdex: true,
Paul Duffine5218812021-06-07 13:28:19 +01006584 compile_dex: true,
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006585 }
6586
6587 apex {
6588 name: "some-updatable-apex",
6589 key: "some-updatable-apex.key",
6590 java_libs: ["some-updatable-apex-lib"],
6591 updatable: true,
6592 min_sdk_version: "current",
6593 }
6594
6595 apex {
6596 name: "some-non-updatable-apex",
6597 key: "some-non-updatable-apex.key",
Paul Duffin89f570a2021-06-16 01:42:33 +01006598 bootclasspath_fragments: ["some-non-updatable-fragment"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006599 updatable: false,
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006600 }
6601
6602 apex_key {
6603 name: "some-updatable-apex.key",
6604 }
6605
6606 apex_key {
6607 name: "some-non-updatable-apex.key",
6608 }
6609
6610 apex {
Paul Duffind376f792021-01-26 11:59:35 +00006611 name: "com.android.art.debug",
6612 key: "com.android.art.debug.key",
Paul Duffin89f570a2021-06-16 01:42:33 +01006613 bootclasspath_fragments: ["art-bootclasspath-fragment"],
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006614 updatable: true,
6615 min_sdk_version: "current",
6616 }
6617
Paul Duffinf23bc472021-04-27 12:42:20 +01006618 bootclasspath_fragment {
6619 name: "art-bootclasspath-fragment",
6620 image_name: "art",
6621 contents: ["some-art-lib"],
6622 apex_available: [
6623 "com.android.art.debug",
6624 ],
6625 }
6626
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006627 apex_key {
Paul Duffind376f792021-01-26 11:59:35 +00006628 name: "com.android.art.debug.key",
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006629 }
6630
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006631 filegroup {
6632 name: "some-updatable-apex-file_contexts",
6633 srcs: [
6634 "system/sepolicy/apex/some-updatable-apex-file_contexts",
6635 ],
6636 }
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01006637
6638 filegroup {
6639 name: "some-non-updatable-apex-file_contexts",
6640 srcs: [
6641 "system/sepolicy/apex/some-non-updatable-apex-file_contexts",
6642 ],
6643 }
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006644 `
Paul Duffinc3bbb962020-12-10 19:15:49 +00006645
Paul Duffin89f570a2021-06-16 01:42:33 +01006646 testDexpreoptWithApexes(t, bp, errmsg, preparer, fragments...)
Paul Duffinc3bbb962020-12-10 19:15:49 +00006647}
6648
Paul Duffin89f570a2021-06-16 01:42:33 +01006649func testDexpreoptWithApexes(t *testing.T, bp, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) *android.TestContext {
Paul Duffinc3bbb962020-12-10 19:15:49 +00006650 t.Helper()
6651
Paul Duffin55607122021-03-30 23:32:51 +01006652 fs := android.MockFS{
6653 "a.java": nil,
6654 "a.jar": nil,
6655 "apex_manifest.json": nil,
6656 "AndroidManifest.xml": nil,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00006657 "system/sepolicy/apex/myapex-file_contexts": nil,
Paul Duffind376f792021-01-26 11:59:35 +00006658 "system/sepolicy/apex/some-updatable-apex-file_contexts": nil,
6659 "system/sepolicy/apex/some-non-updatable-apex-file_contexts": nil,
6660 "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00006661 "framework/aidl/a.aidl": nil,
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006662 }
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006663
Paul Duffin55607122021-03-30 23:32:51 +01006664 errorHandler := android.FixtureExpectsNoErrors
6665 if errmsg != "" {
6666 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006667 }
Paul Duffin064b70c2020-11-02 17:32:38 +00006668
Paul Duffin55607122021-03-30 23:32:51 +01006669 result := android.GroupFixturePreparers(
6670 cc.PrepareForTestWithCcDefaultModules,
6671 java.PrepareForTestWithHiddenApiBuildComponents,
6672 java.PrepareForTestWithJavaDefaultModules,
6673 java.PrepareForTestWithJavaSdkLibraryFiles,
6674 PrepareForTestWithApexBuildComponents,
Paul Duffin60264a02021-04-12 20:02:36 +01006675 preparer,
Paul Duffin55607122021-03-30 23:32:51 +01006676 fs.AddToFixture(),
Paul Duffin89f570a2021-06-16 01:42:33 +01006677 android.FixtureModifyMockFS(func(fs android.MockFS) {
6678 if _, ok := fs["frameworks/base/boot/Android.bp"]; !ok {
6679 insert := ""
6680 for _, fragment := range fragments {
6681 insert += fmt.Sprintf("{apex: %q, module: %q},\n", *fragment.Apex, *fragment.Module)
6682 }
6683 fs["frameworks/base/boot/Android.bp"] = []byte(fmt.Sprintf(`
6684 platform_bootclasspath {
6685 name: "platform-bootclasspath",
6686 fragments: [
6687 %s
6688 ],
6689 }
6690 `, insert))
Paul Duffin8f146b92021-04-12 17:24:18 +01006691 }
Paul Duffin89f570a2021-06-16 01:42:33 +01006692 }),
Paul Duffin55607122021-03-30 23:32:51 +01006693 ).
6694 ExtendWithErrorHandler(errorHandler).
6695 RunTestWithBp(t, bp)
6696
6697 return result.TestContext
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006698}
6699
Jooyung Han548640b2020-04-27 12:10:30 +09006700func TestUpdatable_should_set_min_sdk_version(t *testing.T) {
6701 testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
6702 apex {
6703 name: "myapex",
6704 key: "myapex.key",
6705 updatable: true,
6706 }
6707
6708 apex_key {
6709 name: "myapex.key",
6710 public_key: "testkey.avbpubkey",
6711 private_key: "testkey.pem",
6712 }
6713 `)
6714}
6715
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006716func TestUpdatableDefault_should_set_min_sdk_version(t *testing.T) {
6717 testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
6718 apex {
6719 name: "myapex",
6720 key: "myapex.key",
6721 }
6722
6723 apex_key {
6724 name: "myapex.key",
6725 public_key: "testkey.avbpubkey",
6726 private_key: "testkey.pem",
6727 }
6728 `)
6729}
6730
satayevb98371c2021-06-15 16:49:50 +01006731func TestUpdatable_should_not_set_generate_classpaths_proto(t *testing.T) {
6732 testApexError(t, `"mysystemserverclasspathfragment" .* it must not set generate_classpaths_proto to false`, `
6733 apex {
6734 name: "myapex",
6735 key: "myapex.key",
6736 systemserverclasspath_fragments: [
6737 "mysystemserverclasspathfragment",
6738 ],
6739 min_sdk_version: "29",
6740 updatable: true,
6741 }
6742
6743 apex_key {
6744 name: "myapex.key",
6745 public_key: "testkey.avbpubkey",
6746 private_key: "testkey.pem",
6747 }
6748
6749 java_library {
6750 name: "foo",
6751 srcs: ["b.java"],
6752 min_sdk_version: "29",
6753 installable: true,
6754 apex_available: [
6755 "myapex",
6756 ],
6757 }
6758
6759 systemserverclasspath_fragment {
6760 name: "mysystemserverclasspathfragment",
6761 generate_classpaths_proto: false,
6762 contents: [
6763 "foo",
6764 ],
6765 apex_available: [
6766 "myapex",
6767 ],
6768 }
6769 `)
6770}
6771
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006772func TestNoUpdatableJarsInBootImage(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006773 // Set the BootJars in dexpreopt.GlobalConfig and productVariables to the same value. This can
6774 // result in an invalid configuration as it does not set the ArtApexJars and allows art apex
6775 // modules to be included in the BootJars.
6776 prepareSetBootJars := func(bootJars ...string) android.FixturePreparer {
6777 return android.GroupFixturePreparers(
6778 dexpreopt.FixtureSetBootJars(bootJars...),
6779 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
6780 variables.BootJars = android.CreateTestConfiguredJarList(bootJars)
6781 }),
6782 )
6783 }
6784
6785 // Set the ArtApexJars and BootJars in dexpreopt.GlobalConfig and productVariables all to the
6786 // same value. This can result in an invalid configuration as it allows non art apex jars to be
6787 // specified in the ArtApexJars configuration.
6788 prepareSetArtJars := func(bootJars ...string) android.FixturePreparer {
6789 return android.GroupFixturePreparers(
6790 dexpreopt.FixtureSetArtBootJars(bootJars...),
6791 dexpreopt.FixtureSetBootJars(bootJars...),
6792 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
6793 variables.BootJars = android.CreateTestConfiguredJarList(bootJars)
6794 }),
6795 )
6796 }
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006797
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006798 t.Run("updatable jar from ART apex in the ART boot image => ok", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006799 preparer := java.FixtureConfigureBootJars("com.android.art.debug:some-art-lib")
Paul Duffin89f570a2021-06-16 01:42:33 +01006800 fragment := java.ApexVariantReference{
6801 Apex: proptools.StringPtr("com.android.art.debug"),
6802 Module: proptools.StringPtr("art-bootclasspath-fragment"),
6803 }
6804 testNoUpdatableJarsInBootImage(t, "", preparer, fragment)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006805 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006806
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006807 t.Run("updatable jar from ART apex in the framework boot image => error", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006808 err := `module "some-art-lib" from updatable apexes \["com.android.art.debug"\] is not allowed in the framework boot image`
6809 // Update the dexpreopt BootJars directly.
6810 preparer := prepareSetBootJars("com.android.art.debug:some-art-lib")
6811 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006812 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006813
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006814 t.Run("updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
Paul Duffinf23bc472021-04-27 12:42:20 +01006815 err := `ArtApexJars expects this to be in apex "some-updatable-apex" but this is only in apexes.*"com.android.art.debug"`
Paul Duffin60264a02021-04-12 20:02:36 +01006816 // Update the dexpreopt ArtApexJars directly.
6817 preparer := prepareSetArtJars("some-updatable-apex:some-updatable-apex-lib")
6818 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006819 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006820
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006821 t.Run("non-updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
Paul Duffinf23bc472021-04-27 12:42:20 +01006822 err := `ArtApexJars expects this to be in apex "some-non-updatable-apex" but this is only in apexes.*"com.android.art.debug"`
Paul Duffin60264a02021-04-12 20:02:36 +01006823 // Update the dexpreopt ArtApexJars directly.
6824 preparer := prepareSetArtJars("some-non-updatable-apex:some-non-updatable-apex-lib")
6825 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006826 })
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01006827
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006828 t.Run("updatable jar from some other apex in the framework boot image => error", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006829 err := `module "some-updatable-apex-lib" from updatable apexes \["some-updatable-apex"\] is not allowed in the framework boot image`
6830 preparer := java.FixtureConfigureBootJars("some-updatable-apex:some-updatable-apex-lib")
6831 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006832 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006833
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006834 t.Run("non-updatable jar from some other apex in the framework boot image => ok", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006835 preparer := java.FixtureConfigureBootJars("some-non-updatable-apex:some-non-updatable-apex-lib")
Paul Duffin89f570a2021-06-16 01:42:33 +01006836 fragment := java.ApexVariantReference{
6837 Apex: proptools.StringPtr("some-non-updatable-apex"),
6838 Module: proptools.StringPtr("some-non-updatable-fragment"),
6839 }
6840 testNoUpdatableJarsInBootImage(t, "", preparer, fragment)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006841 })
Ulya Trafimovich7c140d82020-04-22 18:05:58 +01006842
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006843 t.Run("nonexistent jar in the ART boot image => error", func(t *testing.T) {
Paul Duffin8f146b92021-04-12 17:24:18 +01006844 err := `"platform-bootclasspath" depends on undefined module "nonexistent"`
Paul Duffin60264a02021-04-12 20:02:36 +01006845 preparer := java.FixtureConfigureBootJars("platform:nonexistent")
6846 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006847 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006848
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006849 t.Run("nonexistent jar in the framework boot image => error", func(t *testing.T) {
Paul Duffin8f146b92021-04-12 17:24:18 +01006850 err := `"platform-bootclasspath" depends on undefined module "nonexistent"`
Paul Duffin60264a02021-04-12 20:02:36 +01006851 preparer := java.FixtureConfigureBootJars("platform:nonexistent")
6852 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006853 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006854
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006855 t.Run("platform jar in the ART boot image => error", func(t *testing.T) {
Paul Duffinf23bc472021-04-27 12:42:20 +01006856 err := `ArtApexJars is invalid as it requests a platform variant of "some-platform-lib"`
Paul Duffin60264a02021-04-12 20:02:36 +01006857 // Update the dexpreopt ArtApexJars directly.
6858 preparer := prepareSetArtJars("platform:some-platform-lib")
6859 testNoUpdatableJarsInBootImage(t, err, preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006860 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006861
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006862 t.Run("platform jar in the framework boot image => ok", func(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006863 preparer := java.FixtureConfigureBootJars("platform:some-platform-lib")
6864 testNoUpdatableJarsInBootImage(t, "", preparer)
Ulya Trafimovich7caef202020-05-19 12:00:52 +01006865 })
Paul Duffin064b70c2020-11-02 17:32:38 +00006866}
6867
6868func TestDexpreoptAccessDexFilesFromPrebuiltApex(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01006869 preparer := java.FixtureConfigureBootJars("myapex:libfoo")
Paul Duffin064b70c2020-11-02 17:32:38 +00006870 t.Run("prebuilt no source", func(t *testing.T) {
Paul Duffin89f570a2021-06-16 01:42:33 +01006871 fragment := java.ApexVariantReference{
6872 Apex: proptools.StringPtr("myapex"),
6873 Module: proptools.StringPtr("my-bootclasspath-fragment"),
6874 }
6875
Paul Duffin064b70c2020-11-02 17:32:38 +00006876 testDexpreoptWithApexes(t, `
6877 prebuilt_apex {
6878 name: "myapex" ,
6879 arch: {
6880 arm64: {
6881 src: "myapex-arm64.apex",
6882 },
6883 arm: {
6884 src: "myapex-arm.apex",
6885 },
6886 },
Paul Duffin89f570a2021-06-16 01:42:33 +01006887 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
6888 }
Paul Duffin064b70c2020-11-02 17:32:38 +00006889
Paul Duffin89f570a2021-06-16 01:42:33 +01006890 prebuilt_bootclasspath_fragment {
6891 name: "my-bootclasspath-fragment",
6892 contents: ["libfoo"],
6893 apex_available: ["myapex"],
6894 }
Paul Duffin064b70c2020-11-02 17:32:38 +00006895
Paul Duffin89f570a2021-06-16 01:42:33 +01006896 java_import {
6897 name: "libfoo",
6898 jars: ["libfoo.jar"],
6899 apex_available: ["myapex"],
6900 }
6901 `, "", preparer, fragment)
Paul Duffin064b70c2020-11-02 17:32:38 +00006902 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00006903}
6904
Andrei Onea115e7e72020-06-05 21:14:03 +01006905func testApexPermittedPackagesRules(t *testing.T, errmsg, bp string, apexBootJars []string, rules []android.Rule) {
6906 t.Helper()
Andrei Onea115e7e72020-06-05 21:14:03 +01006907 bp += `
6908 apex_key {
6909 name: "myapex.key",
6910 public_key: "testkey.avbpubkey",
6911 private_key: "testkey.pem",
6912 }`
Paul Duffin45338f02021-03-30 23:07:52 +01006913 fs := android.MockFS{
Andrei Onea115e7e72020-06-05 21:14:03 +01006914 "lib1/src/A.java": nil,
6915 "lib2/src/B.java": nil,
6916 "system/sepolicy/apex/myapex-file_contexts": nil,
6917 }
6918
Paul Duffin45338f02021-03-30 23:07:52 +01006919 errorHandler := android.FixtureExpectsNoErrors
6920 if errmsg != "" {
6921 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
Colin Crossae8600b2020-10-29 17:09:13 -07006922 }
Colin Crossae8600b2020-10-29 17:09:13 -07006923
Paul Duffin45338f02021-03-30 23:07:52 +01006924 android.GroupFixturePreparers(
6925 android.PrepareForTestWithAndroidBuildComponents,
6926 java.PrepareForTestWithJavaBuildComponents,
6927 PrepareForTestWithApexBuildComponents,
6928 android.PrepareForTestWithNeverallowRules(rules),
6929 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
6930 updatableBootJars := make([]string, 0, len(apexBootJars))
6931 for _, apexBootJar := range apexBootJars {
6932 updatableBootJars = append(updatableBootJars, "myapex:"+apexBootJar)
6933 }
6934 variables.UpdatableBootJars = android.CreateTestConfiguredJarList(updatableBootJars)
6935 }),
6936 fs.AddToFixture(),
6937 ).
6938 ExtendWithErrorHandler(errorHandler).
6939 RunTestWithBp(t, bp)
Andrei Onea115e7e72020-06-05 21:14:03 +01006940}
6941
6942func TestApexPermittedPackagesRules(t *testing.T) {
6943 testcases := []struct {
6944 name string
6945 expectedError string
6946 bp string
6947 bootJars []string
6948 modulesPackages map[string][]string
6949 }{
6950
6951 {
6952 name: "Non-Bootclasspath apex jar not satisfying allowed module packages.",
6953 expectedError: "",
6954 bp: `
6955 java_library {
6956 name: "bcp_lib1",
6957 srcs: ["lib1/src/*.java"],
6958 permitted_packages: ["foo.bar"],
6959 apex_available: ["myapex"],
6960 sdk_version: "none",
6961 system_modules: "none",
6962 }
6963 java_library {
6964 name: "nonbcp_lib2",
6965 srcs: ["lib2/src/*.java"],
6966 apex_available: ["myapex"],
6967 permitted_packages: ["a.b"],
6968 sdk_version: "none",
6969 system_modules: "none",
6970 }
6971 apex {
6972 name: "myapex",
6973 key: "myapex.key",
6974 java_libs: ["bcp_lib1", "nonbcp_lib2"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006975 updatable: false,
Andrei Onea115e7e72020-06-05 21:14:03 +01006976 }`,
6977 bootJars: []string{"bcp_lib1"},
6978 modulesPackages: map[string][]string{
6979 "myapex": []string{
6980 "foo.bar",
6981 },
6982 },
6983 },
6984 {
6985 name: "Bootclasspath apex jar not satisfying allowed module packages.",
6986 expectedError: `module "bcp_lib2" .* which is restricted because jars that are part of the myapex module may only allow these packages: foo.bar. Please jarjar or move code around.`,
6987 bp: `
6988 java_library {
6989 name: "bcp_lib1",
6990 srcs: ["lib1/src/*.java"],
6991 apex_available: ["myapex"],
6992 permitted_packages: ["foo.bar"],
6993 sdk_version: "none",
6994 system_modules: "none",
6995 }
6996 java_library {
6997 name: "bcp_lib2",
6998 srcs: ["lib2/src/*.java"],
6999 apex_available: ["myapex"],
7000 permitted_packages: ["foo.bar", "bar.baz"],
7001 sdk_version: "none",
7002 system_modules: "none",
7003 }
7004 apex {
7005 name: "myapex",
7006 key: "myapex.key",
7007 java_libs: ["bcp_lib1", "bcp_lib2"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007008 updatable: false,
Andrei Onea115e7e72020-06-05 21:14:03 +01007009 }
7010 `,
7011 bootJars: []string{"bcp_lib1", "bcp_lib2"},
7012 modulesPackages: map[string][]string{
7013 "myapex": []string{
7014 "foo.bar",
7015 },
7016 },
7017 },
7018 }
7019 for _, tc := range testcases {
7020 t.Run(tc.name, func(t *testing.T) {
7021 rules := createApexPermittedPackagesRules(tc.modulesPackages)
7022 testApexPermittedPackagesRules(t, tc.expectedError, tc.bp, tc.bootJars, rules)
7023 })
7024 }
7025}
7026
Jiyong Park62304bb2020-04-13 16:19:48 +09007027func TestTestFor(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007028 ctx := testApex(t, `
Jiyong Park62304bb2020-04-13 16:19:48 +09007029 apex {
7030 name: "myapex",
7031 key: "myapex.key",
7032 native_shared_libs: ["mylib", "myprivlib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007033 updatable: false,
Jiyong Park62304bb2020-04-13 16:19:48 +09007034 }
7035
7036 apex_key {
7037 name: "myapex.key",
7038 public_key: "testkey.avbpubkey",
7039 private_key: "testkey.pem",
7040 }
7041
7042 cc_library {
7043 name: "mylib",
7044 srcs: ["mylib.cpp"],
7045 system_shared_libs: [],
7046 stl: "none",
7047 stubs: {
7048 versions: ["1"],
7049 },
7050 apex_available: ["myapex"],
7051 }
7052
7053 cc_library {
7054 name: "myprivlib",
7055 srcs: ["mylib.cpp"],
7056 system_shared_libs: [],
7057 stl: "none",
7058 apex_available: ["myapex"],
7059 }
7060
7061
7062 cc_test {
7063 name: "mytest",
7064 gtest: false,
7065 srcs: ["mylib.cpp"],
7066 system_shared_libs: [],
7067 stl: "none",
Jiyong Park46a512f2020-12-04 18:02:13 +09007068 shared_libs: ["mylib", "myprivlib", "mytestlib"],
Jiyong Park62304bb2020-04-13 16:19:48 +09007069 test_for: ["myapex"]
7070 }
Jiyong Park46a512f2020-12-04 18:02:13 +09007071
7072 cc_library {
7073 name: "mytestlib",
7074 srcs: ["mylib.cpp"],
7075 system_shared_libs: [],
7076 shared_libs: ["mylib", "myprivlib"],
7077 stl: "none",
7078 test_for: ["myapex"],
7079 }
7080
7081 cc_benchmark {
7082 name: "mybench",
7083 srcs: ["mylib.cpp"],
7084 system_shared_libs: [],
7085 shared_libs: ["mylib", "myprivlib"],
7086 stl: "none",
7087 test_for: ["myapex"],
7088 }
Jiyong Park62304bb2020-04-13 16:19:48 +09007089 `)
7090
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007091 ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
Paul Duffina71a67a2021-03-29 00:42:57 +01007092 ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007093 mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
7094 android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
7095 }
7096
7097 // These modules are tests for the apex, therefore are linked to the
Jiyong Park62304bb2020-04-13 16:19:48 +09007098 // actual implementation of mylib instead of its stub.
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007099 ensureLinkedLibIs("mytest", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
7100 ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
7101 ensureLinkedLibIs("mybench", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
7102}
Jiyong Park46a512f2020-12-04 18:02:13 +09007103
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007104func TestIndirectTestFor(t *testing.T) {
7105 ctx := testApex(t, `
7106 apex {
7107 name: "myapex",
7108 key: "myapex.key",
7109 native_shared_libs: ["mylib", "myprivlib"],
7110 updatable: false,
7111 }
Jiyong Park46a512f2020-12-04 18:02:13 +09007112
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007113 apex_key {
7114 name: "myapex.key",
7115 public_key: "testkey.avbpubkey",
7116 private_key: "testkey.pem",
7117 }
7118
7119 cc_library {
7120 name: "mylib",
7121 srcs: ["mylib.cpp"],
7122 system_shared_libs: [],
7123 stl: "none",
7124 stubs: {
7125 versions: ["1"],
7126 },
7127 apex_available: ["myapex"],
7128 }
7129
7130 cc_library {
7131 name: "myprivlib",
7132 srcs: ["mylib.cpp"],
7133 system_shared_libs: [],
7134 stl: "none",
7135 shared_libs: ["mylib"],
7136 apex_available: ["myapex"],
7137 }
7138
7139 cc_library {
7140 name: "mytestlib",
7141 srcs: ["mylib.cpp"],
7142 system_shared_libs: [],
7143 shared_libs: ["myprivlib"],
7144 stl: "none",
7145 test_for: ["myapex"],
7146 }
7147 `)
7148
7149 ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
Paul Duffina71a67a2021-03-29 00:42:57 +01007150 ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00007151 mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
7152 android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
7153 }
7154
7155 // The platform variant of mytestlib links to the platform variant of the
7156 // internal myprivlib.
7157 ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/myprivlib/", "android_arm64_armv8-a_shared/myprivlib.so")
7158
7159 // The platform variant of myprivlib links to the platform variant of mylib
7160 // and bypasses its stubs.
7161 ensureLinkedLibIs("myprivlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
Jiyong Park62304bb2020-04-13 16:19:48 +09007162}
7163
Martin Stjernholmec009002021-03-27 15:18:31 +00007164func TestTestForForLibInOtherApex(t *testing.T) {
7165 // This case is only allowed for known overlapping APEXes, i.e. the ART APEXes.
7166 _ = testApex(t, `
7167 apex {
7168 name: "com.android.art",
7169 key: "myapex.key",
7170 native_shared_libs: ["mylib"],
7171 updatable: false,
7172 }
7173
7174 apex {
7175 name: "com.android.art.debug",
7176 key: "myapex.key",
7177 native_shared_libs: ["mylib", "mytestlib"],
7178 updatable: false,
7179 }
7180
7181 apex_key {
7182 name: "myapex.key",
7183 public_key: "testkey.avbpubkey",
7184 private_key: "testkey.pem",
7185 }
7186
7187 cc_library {
7188 name: "mylib",
7189 srcs: ["mylib.cpp"],
7190 system_shared_libs: [],
7191 stl: "none",
7192 stubs: {
7193 versions: ["1"],
7194 },
7195 apex_available: ["com.android.art", "com.android.art.debug"],
7196 }
7197
7198 cc_library {
7199 name: "mytestlib",
7200 srcs: ["mylib.cpp"],
7201 system_shared_libs: [],
7202 shared_libs: ["mylib"],
7203 stl: "none",
7204 apex_available: ["com.android.art.debug"],
7205 test_for: ["com.android.art"],
7206 }
7207 `,
7208 android.MockFS{
7209 "system/sepolicy/apex/com.android.art-file_contexts": nil,
7210 "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
7211 }.AddToFixture())
7212}
7213
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007214// TODO(jungjw): Move this to proptools
7215func intPtr(i int) *int {
7216 return &i
7217}
7218
7219func TestApexSet(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007220 ctx := testApex(t, `
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007221 apex_set {
7222 name: "myapex",
7223 set: "myapex.apks",
7224 filename: "foo_v2.apex",
7225 overrides: ["foo"],
7226 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00007227 `,
7228 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
7229 variables.Platform_sdk_version = intPtr(30)
7230 }),
7231 android.FixtureModifyConfig(func(config android.Config) {
7232 config.Targets[android.Android] = []android.Target{
7233 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}},
7234 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}},
7235 }
7236 }),
7237 )
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007238
Paul Duffin24704672021-04-06 16:09:30 +01007239 m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007240
7241 // Check extract_apks tool parameters.
Paul Duffin24704672021-04-06 16:09:30 +01007242 extractedApex := m.Output("extracted/myapex.apks")
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007243 actual := extractedApex.Args["abis"]
7244 expected := "ARMEABI_V7A,ARM64_V8A"
7245 if actual != expected {
7246 t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
7247 }
7248 actual = extractedApex.Args["sdk-version"]
7249 expected = "30"
7250 if actual != expected {
7251 t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
7252 }
7253
Paul Duffin6717d882021-06-15 19:09:41 +01007254 m = ctx.ModuleForTests("myapex", "android_common_myapex")
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007255 a := m.Module().(*ApexSet)
7256 expectedOverrides := []string{"foo"}
Colin Crossaa255532020-07-03 13:18:24 -07007257 actualOverrides := android.AndroidMkEntriesForTest(t, ctx, a)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
Jaewoong Jungfa00c062020-05-14 14:15:24 -07007258 if !reflect.DeepEqual(actualOverrides, expectedOverrides) {
7259 t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES - expected %q vs actual %q", expectedOverrides, actualOverrides)
7260 }
7261}
7262
Jiyong Park7d95a512020-05-10 15:16:24 +09007263func TestNoStaticLinkingToStubsLib(t *testing.T) {
7264 testApexError(t, `.*required by "mylib" is a native library providing stub.*`, `
7265 apex {
7266 name: "myapex",
7267 key: "myapex.key",
7268 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007269 updatable: false,
Jiyong Park7d95a512020-05-10 15:16:24 +09007270 }
7271
7272 apex_key {
7273 name: "myapex.key",
7274 public_key: "testkey.avbpubkey",
7275 private_key: "testkey.pem",
7276 }
7277
7278 cc_library {
7279 name: "mylib",
7280 srcs: ["mylib.cpp"],
7281 static_libs: ["otherlib"],
7282 system_shared_libs: [],
7283 stl: "none",
7284 apex_available: [ "myapex" ],
7285 }
7286
7287 cc_library {
7288 name: "otherlib",
7289 srcs: ["mylib.cpp"],
7290 system_shared_libs: [],
7291 stl: "none",
7292 stubs: {
7293 versions: ["1", "2", "3"],
7294 },
7295 apex_available: [ "myapex" ],
7296 }
7297 `)
7298}
7299
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007300func TestApexKeysTxt(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007301 ctx := testApex(t, `
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007302 apex {
7303 name: "myapex",
7304 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007305 updatable: false,
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007306 }
7307
7308 apex_key {
7309 name: "myapex.key",
7310 public_key: "testkey.avbpubkey",
7311 private_key: "testkey.pem",
7312 }
7313
7314 prebuilt_apex {
7315 name: "myapex",
7316 prefer: true,
7317 arch: {
7318 arm64: {
7319 src: "myapex-arm64.apex",
7320 },
7321 arm: {
7322 src: "myapex-arm.apex",
7323 },
7324 },
7325 }
7326
7327 apex_set {
7328 name: "myapex_set",
7329 set: "myapex.apks",
7330 filename: "myapex_set.apex",
7331 overrides: ["myapex"],
7332 }
7333 `)
7334
7335 apexKeysText := ctx.SingletonForTests("apex_keys_text")
7336 content := apexKeysText.MaybeDescription("apexkeys.txt").BuildParams.Args["content"]
7337 ensureContains(t, content, `name="myapex_set.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
Jiyong Park03a7f3e2020-06-18 19:34:42 +09007338 ensureContains(t, content, `name="myapex.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
Jiyong Park8d6c51e2020-06-12 17:26:31 +09007339}
7340
Jooyung Han938b5932020-06-20 12:47:47 +09007341func TestAllowedFiles(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007342 ctx := testApex(t, `
Jooyung Han938b5932020-06-20 12:47:47 +09007343 apex {
7344 name: "myapex",
7345 key: "myapex.key",
7346 apps: ["app"],
7347 allowed_files: "allowed.txt",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007348 updatable: false,
Jooyung Han938b5932020-06-20 12:47:47 +09007349 }
7350
7351 apex_key {
7352 name: "myapex.key",
7353 public_key: "testkey.avbpubkey",
7354 private_key: "testkey.pem",
7355 }
7356
7357 android_app {
7358 name: "app",
7359 srcs: ["foo/bar/MyClass.java"],
7360 package_name: "foo",
7361 sdk_version: "none",
7362 system_modules: "none",
7363 apex_available: [ "myapex" ],
7364 }
7365 `, withFiles(map[string][]byte{
7366 "sub/Android.bp": []byte(`
7367 override_apex {
7368 name: "override_myapex",
7369 base: "myapex",
7370 apps: ["override_app"],
7371 allowed_files: ":allowed",
7372 }
7373 // Overridable "path" property should be referenced indirectly
7374 filegroup {
7375 name: "allowed",
7376 srcs: ["allowed.txt"],
7377 }
7378 override_android_app {
7379 name: "override_app",
7380 base: "app",
7381 package_name: "bar",
7382 }
7383 `),
7384 }))
7385
7386 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("diffApexContentRule")
7387 if expected, actual := "allowed.txt", rule.Args["allowed_files_file"]; expected != actual {
7388 t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
7389 }
7390
7391 rule2 := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Rule("diffApexContentRule")
7392 if expected, actual := "sub/allowed.txt", rule2.Args["allowed_files_file"]; expected != actual {
7393 t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
7394 }
7395}
7396
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007397func TestNonPreferredPrebuiltDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007398 testApex(t, `
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007399 apex {
7400 name: "myapex",
7401 key: "myapex.key",
7402 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007403 updatable: false,
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007404 }
7405
7406 apex_key {
7407 name: "myapex.key",
7408 public_key: "testkey.avbpubkey",
7409 private_key: "testkey.pem",
7410 }
7411
7412 cc_library {
7413 name: "mylib",
7414 srcs: ["mylib.cpp"],
7415 stubs: {
Dan Albertc8060532020-07-22 22:32:17 -07007416 versions: ["current"],
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007417 },
7418 apex_available: ["myapex"],
7419 }
7420
7421 cc_prebuilt_library_shared {
7422 name: "mylib",
7423 prefer: false,
7424 srcs: ["prebuilt.so"],
7425 stubs: {
Dan Albertc8060532020-07-22 22:32:17 -07007426 versions: ["current"],
Martin Stjernholm58c33f02020-07-06 22:56:01 +01007427 },
7428 apex_available: ["myapex"],
7429 }
7430 `)
7431}
7432
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007433func TestCompressedApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007434 ctx := testApex(t, `
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007435 apex {
7436 name: "myapex",
7437 key: "myapex.key",
7438 compressible: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007439 updatable: false,
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007440 }
7441 apex_key {
7442 name: "myapex.key",
7443 public_key: "testkey.avbpubkey",
7444 private_key: "testkey.pem",
7445 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00007446 `,
7447 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
7448 variables.CompressedApex = proptools.BoolPtr(true)
7449 }),
7450 )
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007451
7452 compressRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("compressRule")
7453 ensureContains(t, compressRule.Output.String(), "myapex.capex.unsigned")
7454
7455 signApkRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Description("sign compressedApex")
7456 ensureEquals(t, signApkRule.Input.String(), compressRule.Output.String())
7457
7458 // Make sure output of bundle is .capex
7459 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
7460 ensureContains(t, ab.outputFile.String(), "myapex.capex")
7461
7462 // Verify android.mk rules
Colin Crossaa255532020-07-03 13:18:24 -07007463 data := android.AndroidMkDataForTest(t, ctx, ab)
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00007464 var builder strings.Builder
7465 data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
7466 androidMk := builder.String()
7467 ensureContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.capex\n")
7468}
7469
Martin Stjernholm2856c662020-12-02 15:03:42 +00007470func TestPreferredPrebuiltSharedLibDep(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007471 ctx := testApex(t, `
Martin Stjernholm2856c662020-12-02 15:03:42 +00007472 apex {
7473 name: "myapex",
7474 key: "myapex.key",
7475 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007476 updatable: false,
Martin Stjernholm2856c662020-12-02 15:03:42 +00007477 }
7478
7479 apex_key {
7480 name: "myapex.key",
7481 public_key: "testkey.avbpubkey",
7482 private_key: "testkey.pem",
7483 }
7484
7485 cc_library {
7486 name: "mylib",
7487 srcs: ["mylib.cpp"],
7488 apex_available: ["myapex"],
7489 shared_libs: ["otherlib"],
7490 system_shared_libs: [],
7491 }
7492
7493 cc_library {
7494 name: "otherlib",
7495 srcs: ["mylib.cpp"],
7496 stubs: {
7497 versions: ["current"],
7498 },
7499 }
7500
7501 cc_prebuilt_library_shared {
7502 name: "otherlib",
7503 prefer: true,
7504 srcs: ["prebuilt.so"],
7505 stubs: {
7506 versions: ["current"],
7507 },
7508 }
7509 `)
7510
7511 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07007512 data := android.AndroidMkDataForTest(t, ctx, ab)
Martin Stjernholm2856c662020-12-02 15:03:42 +00007513 var builder strings.Builder
7514 data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
7515 androidMk := builder.String()
7516
7517 // The make level dependency needs to be on otherlib - prebuilt_otherlib isn't
7518 // a thing there.
7519 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += otherlib\n")
7520}
7521
Jiyong Parke3867542020-12-03 17:28:25 +09007522func TestExcludeDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007523 ctx := testApex(t, `
Jiyong Parke3867542020-12-03 17:28:25 +09007524 apex {
7525 name: "myapex",
7526 key: "myapex.key",
7527 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007528 updatable: false,
Jiyong Parke3867542020-12-03 17:28:25 +09007529 }
7530
7531 apex_key {
7532 name: "myapex.key",
7533 public_key: "testkey.avbpubkey",
7534 private_key: "testkey.pem",
7535 }
7536
7537 cc_library {
7538 name: "mylib",
7539 srcs: ["mylib.cpp"],
7540 system_shared_libs: [],
7541 stl: "none",
7542 apex_available: ["myapex"],
7543 shared_libs: ["mylib2"],
7544 target: {
7545 apex: {
7546 exclude_shared_libs: ["mylib2"],
7547 },
7548 },
7549 }
7550
7551 cc_library {
7552 name: "mylib2",
7553 srcs: ["mylib.cpp"],
7554 system_shared_libs: [],
7555 stl: "none",
7556 }
7557 `)
7558
7559 // Check if mylib is linked to mylib2 for the non-apex target
7560 ldFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
7561 ensureContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
7562
7563 // Make sure that the link doesn't occur for the apex target
7564 ldFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
7565 ensureNotContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared_apex10000/mylib2.so")
7566
7567 // It shouldn't appear in the copy cmd as well.
7568 copyCmds := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule").Args["copy_commands"]
7569 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
7570}
7571
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007572func TestPrebuiltStubLibDep(t *testing.T) {
7573 bpBase := `
7574 apex {
7575 name: "myapex",
7576 key: "myapex.key",
7577 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007578 updatable: false,
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007579 }
7580 apex_key {
7581 name: "myapex.key",
7582 public_key: "testkey.avbpubkey",
7583 private_key: "testkey.pem",
7584 }
7585 cc_library {
7586 name: "mylib",
7587 srcs: ["mylib.cpp"],
7588 apex_available: ["myapex"],
7589 shared_libs: ["stublib"],
7590 system_shared_libs: [],
7591 }
7592 apex {
7593 name: "otherapex",
7594 enabled: %s,
7595 key: "myapex.key",
7596 native_shared_libs: ["stublib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007597 updatable: false,
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007598 }
7599 `
7600
7601 stublibSourceBp := `
7602 cc_library {
7603 name: "stublib",
7604 srcs: ["mylib.cpp"],
7605 apex_available: ["otherapex"],
7606 system_shared_libs: [],
7607 stl: "none",
7608 stubs: {
7609 versions: ["1"],
7610 },
7611 }
7612 `
7613
7614 stublibPrebuiltBp := `
7615 cc_prebuilt_library_shared {
7616 name: "stublib",
7617 srcs: ["prebuilt.so"],
7618 apex_available: ["otherapex"],
7619 stubs: {
7620 versions: ["1"],
7621 },
7622 %s
7623 }
7624 `
7625
7626 tests := []struct {
7627 name string
7628 stublibBp string
7629 usePrebuilt bool
7630 modNames []string // Modules to collect AndroidMkEntries for
7631 otherApexEnabled []string
7632 }{
7633 {
7634 name: "only_source",
7635 stublibBp: stublibSourceBp,
7636 usePrebuilt: false,
7637 modNames: []string{"stublib"},
7638 otherApexEnabled: []string{"true", "false"},
7639 },
7640 {
7641 name: "source_preferred",
7642 stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, ""),
7643 usePrebuilt: false,
7644 modNames: []string{"stublib", "prebuilt_stublib"},
7645 otherApexEnabled: []string{"true", "false"},
7646 },
7647 {
7648 name: "prebuilt_preferred",
7649 stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, "prefer: true,"),
7650 usePrebuilt: true,
7651 modNames: []string{"stublib", "prebuilt_stublib"},
7652 otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
7653 },
7654 {
7655 name: "only_prebuilt",
7656 stublibBp: fmt.Sprintf(stublibPrebuiltBp, ""),
7657 usePrebuilt: true,
7658 modNames: []string{"stublib"},
7659 otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
7660 },
7661 }
7662
7663 for _, test := range tests {
7664 t.Run(test.name, func(t *testing.T) {
7665 for _, otherApexEnabled := range test.otherApexEnabled {
7666 t.Run("otherapex_enabled_"+otherApexEnabled, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007667 ctx := testApex(t, fmt.Sprintf(bpBase, otherApexEnabled)+test.stublibBp)
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007668
7669 type modAndMkEntries struct {
7670 mod *cc.Module
7671 mkEntries android.AndroidMkEntries
7672 }
7673 entries := []*modAndMkEntries{}
7674
7675 // Gather shared lib modules that are installable
7676 for _, modName := range test.modNames {
7677 for _, variant := range ctx.ModuleVariantsForTests(modName) {
7678 if !strings.HasPrefix(variant, "android_arm64_armv8-a_shared") {
7679 continue
7680 }
7681 mod := ctx.ModuleForTests(modName, variant).Module().(*cc.Module)
Colin Crossa9c8c9f2020-12-16 10:20:23 -08007682 if !mod.Enabled() || mod.IsHideFromMake() {
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007683 continue
7684 }
Colin Crossaa255532020-07-03 13:18:24 -07007685 for _, ent := range android.AndroidMkEntriesForTest(t, ctx, mod) {
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007686 if ent.Disabled {
7687 continue
7688 }
7689 entries = append(entries, &modAndMkEntries{
7690 mod: mod,
7691 mkEntries: ent,
7692 })
7693 }
7694 }
7695 }
7696
7697 var entry *modAndMkEntries = nil
7698 for _, ent := range entries {
7699 if strings.Join(ent.mkEntries.EntryMap["LOCAL_MODULE"], ",") == "stublib" {
7700 if entry != nil {
7701 t.Errorf("More than one AndroidMk entry for \"stublib\": %s and %s", entry.mod, ent.mod)
7702 } else {
7703 entry = ent
7704 }
7705 }
7706 }
7707
7708 if entry == nil {
7709 t.Errorf("AndroidMk entry for \"stublib\" missing")
7710 } else {
7711 isPrebuilt := entry.mod.Prebuilt() != nil
7712 if isPrebuilt != test.usePrebuilt {
7713 t.Errorf("Wrong module for \"stublib\" AndroidMk entry: got prebuilt %t, want prebuilt %t", isPrebuilt, test.usePrebuilt)
7714 }
7715 if !entry.mod.IsStubs() {
7716 t.Errorf("Module for \"stublib\" AndroidMk entry isn't a stub: %s", entry.mod)
7717 }
7718 if entry.mkEntries.EntryMap["LOCAL_NOT_AVAILABLE_FOR_PLATFORM"] != nil {
7719 t.Errorf("AndroidMk entry for \"stublib\" has LOCAL_NOT_AVAILABLE_FOR_PLATFORM set: %+v", entry.mkEntries)
7720 }
Jiyong Park892a98f2020-12-14 09:20:00 +09007721 cflags := entry.mkEntries.EntryMap["LOCAL_EXPORT_CFLAGS"]
Jiyong Parkd4a3a132021-03-17 20:21:35 +09007722 expected := "-D__STUBLIB_API__=10000"
Jiyong Park892a98f2020-12-14 09:20:00 +09007723 if !android.InList(expected, cflags) {
7724 t.Errorf("LOCAL_EXPORT_CFLAGS expected to have %q, but got %q", expected, cflags)
7725 }
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09007726 }
7727 })
7728 }
7729 })
7730 }
7731}
7732
Martin Stjernholmdf298b32021-05-21 20:57:29 +01007733func TestHostApexInHostOnlyBuild(t *testing.T) {
7734 testApex(t, `
7735 apex {
7736 name: "myapex",
7737 host_supported: true,
7738 key: "myapex.key",
7739 updatable: false,
7740 payload_type: "zip",
7741 }
7742 apex_key {
7743 name: "myapex.key",
7744 public_key: "testkey.avbpubkey",
7745 private_key: "testkey.pem",
7746 }
7747 `,
7748 android.FixtureModifyConfig(func(config android.Config) {
7749 // We may not have device targets in all builds, e.g. in
7750 // prebuilts/build-tools/build-prebuilts.sh
7751 config.Targets[android.Android] = []android.Target{}
7752 }))
7753}
7754
Colin Crossc33e5212021-05-25 18:16:02 -07007755func TestApexJavaCoverage(t *testing.T) {
7756 bp := `
7757 apex {
7758 name: "myapex",
7759 key: "myapex.key",
7760 java_libs: ["mylib"],
7761 bootclasspath_fragments: ["mybootclasspathfragment"],
7762 systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
7763 updatable: false,
7764 }
7765
7766 apex_key {
7767 name: "myapex.key",
7768 public_key: "testkey.avbpubkey",
7769 private_key: "testkey.pem",
7770 }
7771
7772 java_library {
7773 name: "mylib",
7774 srcs: ["mylib.java"],
7775 apex_available: ["myapex"],
7776 compile_dex: true,
7777 }
7778
7779 bootclasspath_fragment {
7780 name: "mybootclasspathfragment",
7781 contents: ["mybootclasspathlib"],
7782 apex_available: ["myapex"],
7783 }
7784
7785 java_library {
7786 name: "mybootclasspathlib",
7787 srcs: ["mybootclasspathlib.java"],
7788 apex_available: ["myapex"],
7789 compile_dex: true,
7790 }
7791
7792 systemserverclasspath_fragment {
7793 name: "mysystemserverclasspathfragment",
7794 contents: ["mysystemserverclasspathlib"],
7795 apex_available: ["myapex"],
7796 }
7797
7798 java_library {
7799 name: "mysystemserverclasspathlib",
7800 srcs: ["mysystemserverclasspathlib.java"],
7801 apex_available: ["myapex"],
7802 compile_dex: true,
7803 }
7804 `
7805
7806 result := android.GroupFixturePreparers(
7807 PrepareForTestWithApexBuildComponents,
7808 prepareForTestWithMyapex,
7809 java.PrepareForTestWithJavaDefaultModules,
7810 android.PrepareForTestWithAndroidBuildComponents,
7811 android.FixtureWithRootAndroidBp(bp),
7812 android.FixtureMergeEnv(map[string]string{
7813 "EMMA_INSTRUMENT": "true",
7814 }),
7815 ).RunTest(t)
7816
7817 // Make sure jacoco ran on both mylib and mybootclasspathlib
7818 if result.ModuleForTests("mylib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
7819 t.Errorf("Failed to find jacoco rule for mylib")
7820 }
7821 if result.ModuleForTests("mybootclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
7822 t.Errorf("Failed to find jacoco rule for mybootclasspathlib")
7823 }
7824 if result.ModuleForTests("mysystemserverclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
7825 t.Errorf("Failed to find jacoco rule for mysystemserverclasspathlib")
7826 }
7827}
7828
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07007829func TestMain(m *testing.M) {
Paul Duffin37ba3442021-03-29 00:21:08 +01007830 os.Exit(m.Run())
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07007831}