blob: 330dc3cdd6f06f5468bf0e843112db9a54c1f7ca [file] [log] [blame]
Jiyong Park25fc6a92018-11-18 18:02:45 +09001// Copyright 2018 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package apex
16
17import (
Jiyong Park25fc6a92018-11-18 18:02:45 +090018 "io/ioutil"
19 "os"
Jooyung Han39edb6c2019-11-06 16:53:07 +090020 "path"
Jaewoong Jung22f7d182019-07-16 18:25:41 -070021 "reflect"
Jooyung Han31c470b2019-10-18 16:26:59 +090022 "sort"
Jiyong Park25fc6a92018-11-18 18:02:45 +090023 "strings"
24 "testing"
Jiyong Parkda6eb592018-12-19 17:12:36 +090025
26 "github.com/google/blueprint/proptools"
27
28 "android/soong/android"
29 "android/soong/cc"
Jiyong Parkb2742fd2019-02-11 11:38:15 +090030 "android/soong/java"
Jiyong Park25fc6a92018-11-18 18:02:45 +090031)
32
Jaewoong Jung14f5ff62019-06-18 13:09:13 -070033var buildDir string
34
Jooyung Hand3639552019-08-09 12:57:43 +090035// names returns name list from white space separated string
36func names(s string) (ns []string) {
37 for _, n := range strings.Split(s, " ") {
38 if len(n) > 0 {
39 ns = append(ns, n)
40 }
41 }
42 return
43}
44
Jooyung Han344d5432019-08-23 11:17:39 +090045func testApexError(t *testing.T, pattern, bp string, handlers ...testCustomizer) {
46 t.Helper()
47 ctx, config := testApexContext(t, bp, handlers...)
Jooyung Han5c998b92019-06-27 11:30:33 +090048 _, errs := ctx.ParseFileList(".", []string{"Android.bp"})
49 if len(errs) > 0 {
50 android.FailIfNoMatchingErrors(t, pattern, errs)
51 return
52 }
53 _, errs = ctx.PrepareBuildActions(config)
54 if len(errs) > 0 {
55 android.FailIfNoMatchingErrors(t, pattern, errs)
56 return
57 }
58
59 t.Fatalf("missing expected error %q (0 errors are returned)", pattern)
60}
61
Jooyung Han344d5432019-08-23 11:17:39 +090062func testApex(t *testing.T, bp string, handlers ...testCustomizer) (*android.TestContext, android.Config) {
63 t.Helper()
64 ctx, config := testApexContext(t, bp, handlers...)
Jooyung Han5c998b92019-06-27 11:30:33 +090065 _, errs := ctx.ParseFileList(".", []string{"Android.bp"})
66 android.FailIfErrored(t, errs)
67 _, errs = ctx.PrepareBuildActions(config)
68 android.FailIfErrored(t, errs)
Jaewoong Jung22f7d182019-07-16 18:25:41 -070069 return ctx, config
Jooyung Han5c998b92019-06-27 11:30:33 +090070}
71
Jooyung Han344d5432019-08-23 11:17:39 +090072type testCustomizer func(fs map[string][]byte, config android.Config)
73
74func withFiles(files map[string][]byte) testCustomizer {
75 return func(fs map[string][]byte, config android.Config) {
76 for k, v := range files {
77 fs[k] = v
78 }
79 }
80}
81
82func withTargets(targets map[android.OsType][]android.Target) testCustomizer {
83 return func(fs map[string][]byte, config android.Config) {
84 for k, v := range targets {
85 config.Targets[k] = v
86 }
87 }
88}
89
Jooyung Han31c470b2019-10-18 16:26:59 +090090func withBinder32bit(fs map[string][]byte, config android.Config) {
91 config.TestProductVariables.Binder32bit = proptools.BoolPtr(true)
92}
93
Jooyung Han344d5432019-08-23 11:17:39 +090094func testApexContext(t *testing.T, bp string, handlers ...testCustomizer) (*android.TestContext, android.Config) {
Jaewoong Jungc1001ec2019-06-25 11:20:53 -070095 config := android.TestArchConfig(buildDir, nil)
96 config.TestProductVariables.DeviceVndkVersion = proptools.StringPtr("current")
97 config.TestProductVariables.DefaultAppCertificate = proptools.StringPtr("vendor/foo/devkeys/test")
98 config.TestProductVariables.CertificateOverrides = []string{"myapex_keytest:myapex.certificate.override"}
99 config.TestProductVariables.Platform_sdk_codename = proptools.StringPtr("Q")
100 config.TestProductVariables.Platform_sdk_final = proptools.BoolPtr(false)
Jooyung Han344d5432019-08-23 11:17:39 +0900101 config.TestProductVariables.Platform_vndk_version = proptools.StringPtr("VER")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900102
103 ctx := android.NewTestArchContext()
Jiyong Parkd1063c12019-07-17 20:08:41 +0900104 ctx.RegisterModuleType("apex", android.ModuleFactoryAdaptor(BundleFactory))
Alex Light0851b882019-02-07 13:20:53 -0800105 ctx.RegisterModuleType("apex_test", android.ModuleFactoryAdaptor(testApexBundleFactory))
Jooyung Han344d5432019-08-23 11:17:39 +0900106 ctx.RegisterModuleType("apex_vndk", android.ModuleFactoryAdaptor(vndkApexBundleFactory))
Jiyong Parkd1063c12019-07-17 20:08:41 +0900107 ctx.RegisterModuleType("apex_key", android.ModuleFactoryAdaptor(ApexKeyFactory))
Jiyong Park30ca9372019-02-07 16:27:23 +0900108 ctx.RegisterModuleType("apex_defaults", android.ModuleFactoryAdaptor(defaultsFactory))
Jaewoong Jung939ebd52019-03-26 15:07:36 -0700109 ctx.RegisterModuleType("prebuilt_apex", android.ModuleFactoryAdaptor(PrebuiltFactory))
Jiyong Park25fc6a92018-11-18 18:02:45 +0900110
111 ctx.RegisterModuleType("cc_library", android.ModuleFactoryAdaptor(cc.LibraryFactory))
112 ctx.RegisterModuleType("cc_library_shared", android.ModuleFactoryAdaptor(cc.LibrarySharedFactory))
Jiyong Park7e636d02019-01-28 16:16:54 +0900113 ctx.RegisterModuleType("cc_library_headers", android.ModuleFactoryAdaptor(cc.LibraryHeaderFactory))
Jooyung Han344d5432019-08-23 11:17:39 +0900114 ctx.RegisterModuleType("cc_prebuilt_library_shared", android.ModuleFactoryAdaptor(cc.PrebuiltSharedLibraryFactory))
115 ctx.RegisterModuleType("cc_prebuilt_library_static", android.ModuleFactoryAdaptor(cc.PrebuiltStaticLibraryFactory))
Jiyong Park16e91a02018-12-20 18:18:08 +0900116 ctx.RegisterModuleType("cc_binary", android.ModuleFactoryAdaptor(cc.BinaryFactory))
Jiyong Park25fc6a92018-11-18 18:02:45 +0900117 ctx.RegisterModuleType("cc_object", android.ModuleFactoryAdaptor(cc.ObjectFactory))
Roland Levillain630846d2019-06-26 12:48:34 +0100118 ctx.RegisterModuleType("cc_test", android.ModuleFactoryAdaptor(cc.TestFactory))
Jiyong Parkda6eb592018-12-19 17:12:36 +0900119 ctx.RegisterModuleType("llndk_library", android.ModuleFactoryAdaptor(cc.LlndkLibraryFactory))
Jooyung Han344d5432019-08-23 11:17:39 +0900120 ctx.RegisterModuleType("vndk_prebuilt_shared", android.ModuleFactoryAdaptor(cc.VndkPrebuiltSharedFactory))
Jooyung Han39edb6c2019-11-06 16:53:07 +0900121 ctx.RegisterModuleType("vndk_libraries_txt", android.ModuleFactoryAdaptor(cc.VndkLibrariesTxtFactory))
Jiyong Park25fc6a92018-11-18 18:02:45 +0900122 ctx.RegisterModuleType("toolchain_library", android.ModuleFactoryAdaptor(cc.ToolchainLibraryFactory))
Jiyong Park7c2ee712018-12-07 00:42:25 +0900123 ctx.RegisterModuleType("prebuilt_etc", android.ModuleFactoryAdaptor(android.PrebuiltEtcFactory))
Jiyong Park04480cf2019-02-06 00:16:29 +0900124 ctx.RegisterModuleType("sh_binary", android.ModuleFactoryAdaptor(android.ShBinaryFactory))
Jiyong Parkb2742fd2019-02-11 11:38:15 +0900125 ctx.RegisterModuleType("android_app_certificate", android.ModuleFactoryAdaptor(java.AndroidAppCertificateFactory))
Jiyong Park809bb722019-02-13 21:33:49 +0900126 ctx.RegisterModuleType("filegroup", android.ModuleFactoryAdaptor(android.FileGroupFactory))
Jiyong Park7f7766d2019-07-25 22:02:35 +0900127 ctx.RegisterModuleType("java_library", android.ModuleFactoryAdaptor(java.LibraryFactory))
Jiyong Park9e6c2422019-08-09 20:39:45 +0900128 ctx.RegisterModuleType("java_import", android.ModuleFactoryAdaptor(java.ImportFactory))
Dario Frenicde2a032019-10-27 00:29:22 +0100129 ctx.RegisterModuleType("java_system_modules", android.ModuleFactoryAdaptor(java.SystemModulesFactory))
Sundong Ahne1f05aa2019-08-27 13:55:42 +0900130 ctx.RegisterModuleType("android_app", android.ModuleFactoryAdaptor(java.AndroidAppFactory))
Dario Frenicde2a032019-10-27 00:29:22 +0100131 ctx.RegisterModuleType("android_app_import", android.ModuleFactoryAdaptor(java.AndroidAppImportFactory))
Jiyong Park7f7766d2019-07-25 22:02:35 +0900132
Jooyung Han344d5432019-08-23 11:17:39 +0900133 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Jaewoong Jung939ebd52019-03-26 15:07:36 -0700134 ctx.PreArchMutators(func(ctx android.RegisterMutatorsContext) {
135 ctx.BottomUp("prebuilts", android.PrebuiltMutator).Parallel()
136 })
Jiyong Park25fc6a92018-11-18 18:02:45 +0900137 ctx.PreDepsMutators(func(ctx android.RegisterMutatorsContext) {
Jiyong Parkda6eb592018-12-19 17:12:36 +0900138 ctx.BottomUp("image", cc.ImageMutator).Parallel()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900139 ctx.BottomUp("link", cc.LinkageMutator).Parallel()
Jiyong Parkda6eb592018-12-19 17:12:36 +0900140 ctx.BottomUp("vndk", cc.VndkMutator).Parallel()
Roland Levillain9b5fde92019-06-28 15:41:19 +0100141 ctx.BottomUp("test_per_src", cc.TestPerSrcMutator).Parallel()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900142 ctx.BottomUp("version", cc.VersionMutator).Parallel()
143 ctx.BottomUp("begin", cc.BeginMutator).Parallel()
Jooyung Han344d5432019-08-23 11:17:39 +0900144 })
Jooyung Han31c470b2019-10-18 16:26:59 +0900145 ctx.PreDepsMutators(RegisterPreDepsMutators)
146 ctx.PostDepsMutators(RegisterPostDepsMutators)
Jooyung Han344d5432019-08-23 11:17:39 +0900147 ctx.PostDepsMutators(func(ctx android.RegisterMutatorsContext) {
Jooyung Han344d5432019-08-23 11:17:39 +0900148 ctx.TopDown("prebuilt_select", android.PrebuiltSelectModuleMutator).Parallel()
149 ctx.BottomUp("prebuilt_postdeps", android.PrebuiltPostDepsMutator).Parallel()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900150 })
151
152 ctx.Register()
153
154 bp = bp + `
155 toolchain_library {
156 name: "libcompiler_rt-extras",
157 src: "",
Jiyong Parkda6eb592018-12-19 17:12:36 +0900158 vendor_available: true,
159 recovery_available: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900160 }
161
162 toolchain_library {
163 name: "libatomic",
164 src: "",
Jiyong Parkda6eb592018-12-19 17:12:36 +0900165 vendor_available: true,
166 recovery_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +0900167 native_bridge_supported: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900168 }
169
170 toolchain_library {
171 name: "libgcc",
172 src: "",
Jiyong Parkda6eb592018-12-19 17:12:36 +0900173 vendor_available: true,
174 recovery_available: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900175 }
176
177 toolchain_library {
Yi Kongacee27c2019-03-29 20:05:14 -0700178 name: "libgcc_stripped",
179 src: "",
180 vendor_available: true,
181 recovery_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +0900182 native_bridge_supported: true,
Yi Kongacee27c2019-03-29 20:05:14 -0700183 }
184
185 toolchain_library {
Jiyong Park25fc6a92018-11-18 18:02:45 +0900186 name: "libclang_rt.builtins-aarch64-android",
187 src: "",
Jiyong Parkda6eb592018-12-19 17:12:36 +0900188 vendor_available: true,
189 recovery_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +0900190 native_bridge_supported: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900191 }
192
193 toolchain_library {
194 name: "libclang_rt.builtins-arm-android",
195 src: "",
Jiyong Parkda6eb592018-12-19 17:12:36 +0900196 vendor_available: true,
197 recovery_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +0900198 native_bridge_supported: true,
199 }
200
201 toolchain_library {
202 name: "libclang_rt.builtins-x86_64-android",
203 src: "",
204 vendor_available: true,
205 recovery_available: true,
206 native_bridge_supported: true,
207 }
208
209 toolchain_library {
210 name: "libclang_rt.builtins-i686-android",
211 src: "",
212 vendor_available: true,
213 recovery_available: true,
214 native_bridge_supported: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900215 }
216
217 cc_object {
218 name: "crtbegin_so",
219 stl: "none",
Jiyong Parkda6eb592018-12-19 17:12:36 +0900220 vendor_available: true,
221 recovery_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +0900222 native_bridge_supported: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900223 }
224
225 cc_object {
226 name: "crtend_so",
227 stl: "none",
Jiyong Parkda6eb592018-12-19 17:12:36 +0900228 vendor_available: true,
229 recovery_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +0900230 native_bridge_supported: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900231 }
232
Alex Light3d673592019-01-18 14:37:31 -0800233 cc_object {
234 name: "crtbegin_static",
235 stl: "none",
236 }
237
238 cc_object {
239 name: "crtend_android",
240 stl: "none",
241 }
242
Jiyong Parkda6eb592018-12-19 17:12:36 +0900243 llndk_library {
244 name: "libc",
245 symbol_file: "",
Jooyung Han344d5432019-08-23 11:17:39 +0900246 native_bridge_supported: true,
Jiyong Parkda6eb592018-12-19 17:12:36 +0900247 }
248
249 llndk_library {
250 name: "libm",
251 symbol_file: "",
Jooyung Han344d5432019-08-23 11:17:39 +0900252 native_bridge_supported: true,
Jiyong Parkda6eb592018-12-19 17:12:36 +0900253 }
254
255 llndk_library {
256 name: "libdl",
257 symbol_file: "",
Jooyung Han344d5432019-08-23 11:17:39 +0900258 native_bridge_supported: true,
Jiyong Parkda6eb592018-12-19 17:12:36 +0900259 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900260 `
Dario Frenicde2a032019-10-27 00:29:22 +0100261 bp = bp + java.GatherRequiredDepsForTest()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900262
Jooyung Han344d5432019-08-23 11:17:39 +0900263 fs := map[string][]byte{
Dario Frenicde2a032019-10-27 00:29:22 +0100264 "Android.bp": []byte(bp),
265 "a.java": nil,
266 "PrebuiltAppFoo.apk": nil,
267 "PrebuiltAppFooPriv.apk": nil,
268 "build/make/target/product/security": nil,
269 "apex_manifest.json": nil,
270 "AndroidManifest.xml": nil,
271 "system/sepolicy/apex/myapex-file_contexts": nil,
Jiyong Parkb2742fd2019-02-11 11:38:15 +0900272 "system/sepolicy/apex/myapex_keytest-file_contexts": nil,
273 "system/sepolicy/apex/otherapex-file_contexts": nil,
Jooyung Han5c998b92019-06-27 11:30:33 +0900274 "system/sepolicy/apex/commonapex-file_contexts": nil,
Sundong Ahne1f05aa2019-08-27 13:55:42 +0900275 "mylib.cpp": nil,
276 "mylib_common.cpp": nil,
277 "mytest.cpp": nil,
278 "mytest1.cpp": nil,
279 "mytest2.cpp": nil,
280 "mytest3.cpp": nil,
281 "myprebuilt": nil,
282 "my_include": nil,
283 "foo/bar/MyClass.java": nil,
284 "prebuilt.jar": nil,
285 "vendor/foo/devkeys/test.x509.pem": nil,
286 "vendor/foo/devkeys/test.pk8": nil,
287 "testkey.x509.pem": nil,
288 "testkey.pk8": nil,
289 "testkey.override.x509.pem": nil,
290 "testkey.override.pk8": nil,
291 "vendor/foo/devkeys/testkey.avbpubkey": nil,
292 "vendor/foo/devkeys/testkey.pem": nil,
293 "NOTICE": nil,
294 "custom_notice": nil,
295 "testkey2.avbpubkey": nil,
296 "testkey2.pem": nil,
297 "myapex-arm64.apex": nil,
298 "myapex-arm.apex": nil,
299 "frameworks/base/api/current.txt": nil,
Dario Frenicde2a032019-10-27 00:29:22 +0100300 "framework/aidl/a.aidl": nil,
Sundong Ahne1f05aa2019-08-27 13:55:42 +0900301 "build/make/core/proguard.flags": nil,
302 "build/make/core/proguard_basic_keeps.flags": nil,
Jooyung Han39edb6c2019-11-06 16:53:07 +0900303 "dummy.txt": nil,
Jooyung Han344d5432019-08-23 11:17:39 +0900304 }
305
306 for _, handler := range handlers {
307 handler(fs, config)
308 }
309
310 ctx.MockFileSystem(fs)
Jiyong Park25fc6a92018-11-18 18:02:45 +0900311
Jooyung Han5c998b92019-06-27 11:30:33 +0900312 return ctx, config
Jiyong Park25fc6a92018-11-18 18:02:45 +0900313}
314
Jaewoong Jungc1001ec2019-06-25 11:20:53 -0700315func setUp() {
316 var err error
317 buildDir, err = ioutil.TempDir("", "soong_apex_test")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900318 if err != nil {
Jaewoong Jungc1001ec2019-06-25 11:20:53 -0700319 panic(err)
Jiyong Park25fc6a92018-11-18 18:02:45 +0900320 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900321}
322
Jaewoong Jungc1001ec2019-06-25 11:20:53 -0700323func tearDown() {
Jiyong Park25fc6a92018-11-18 18:02:45 +0900324 os.RemoveAll(buildDir)
325}
326
327// ensure that 'result' contains 'expected'
328func ensureContains(t *testing.T, result string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900329 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900330 if !strings.Contains(result, expected) {
331 t.Errorf("%q is not found in %q", expected, result)
332 }
333}
334
335// ensures that 'result' does not contain 'notExpected'
336func ensureNotContains(t *testing.T, result string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900337 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900338 if strings.Contains(result, notExpected) {
339 t.Errorf("%q is found in %q", notExpected, result)
340 }
341}
342
343func ensureListContains(t *testing.T, result []string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900344 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900345 if !android.InList(expected, result) {
346 t.Errorf("%q is not found in %v", expected, result)
347 }
348}
349
350func ensureListNotContains(t *testing.T, result []string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900351 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900352 if android.InList(notExpected, result) {
353 t.Errorf("%q is found in %v", notExpected, result)
354 }
355}
356
Jooyung Hane1633032019-08-01 17:41:43 +0900357func ensureListEmpty(t *testing.T, result []string) {
358 t.Helper()
359 if len(result) > 0 {
360 t.Errorf("%q is expected to be empty", result)
361 }
362}
363
Jiyong Park25fc6a92018-11-18 18:02:45 +0900364// Minimal test
365func TestBasicApex(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700366 ctx, _ := testApex(t, `
Jiyong Park30ca9372019-02-07 16:27:23 +0900367 apex_defaults {
368 name: "myapex-defaults",
Jiyong Park809bb722019-02-13 21:33:49 +0900369 manifest: ":myapex.manifest",
370 androidManifest: ":myapex.androidmanifest",
Jiyong Park25fc6a92018-11-18 18:02:45 +0900371 key: "myapex.key",
372 native_shared_libs: ["mylib"],
Alex Light3d673592019-01-18 14:37:31 -0800373 multilib: {
374 both: {
375 binaries: ["foo",],
376 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900377 },
Jiyong Park9e6c2422019-08-09 20:39:45 +0900378 java_libs: ["myjar", "myprebuiltjar"],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900379 }
380
Jiyong Park30ca9372019-02-07 16:27:23 +0900381 apex {
382 name: "myapex",
383 defaults: ["myapex-defaults"],
384 }
385
Jiyong Park25fc6a92018-11-18 18:02:45 +0900386 apex_key {
387 name: "myapex.key",
388 public_key: "testkey.avbpubkey",
389 private_key: "testkey.pem",
390 }
391
Jiyong Park809bb722019-02-13 21:33:49 +0900392 filegroup {
393 name: "myapex.manifest",
394 srcs: ["apex_manifest.json"],
395 }
396
397 filegroup {
398 name: "myapex.androidmanifest",
399 srcs: ["AndroidManifest.xml"],
400 }
401
Jiyong Park25fc6a92018-11-18 18:02:45 +0900402 cc_library {
403 name: "mylib",
404 srcs: ["mylib.cpp"],
405 shared_libs: ["mylib2"],
406 system_shared_libs: [],
407 stl: "none",
408 }
409
Alex Light3d673592019-01-18 14:37:31 -0800410 cc_binary {
411 name: "foo",
412 srcs: ["mylib.cpp"],
413 compile_multilib: "both",
414 multilib: {
415 lib32: {
416 suffix: "32",
417 },
418 lib64: {
419 suffix: "64",
420 },
421 },
422 symlinks: ["foo_link_"],
423 symlink_preferred_arch: true,
424 system_shared_libs: [],
425 static_executable: true,
426 stl: "none",
427 }
428
Jiyong Park25fc6a92018-11-18 18:02:45 +0900429 cc_library {
430 name: "mylib2",
431 srcs: ["mylib.cpp"],
432 system_shared_libs: [],
433 stl: "none",
Jiyong Park52818fc2019-03-18 12:01:38 +0900434 notice: "custom_notice",
Jiyong Park25fc6a92018-11-18 18:02:45 +0900435 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900436
437 java_library {
438 name: "myjar",
439 srcs: ["foo/bar/MyClass.java"],
440 sdk_version: "none",
441 system_modules: "none",
442 compile_dex: true,
443 static_libs: ["myotherjar"],
444 }
445
446 java_library {
447 name: "myotherjar",
448 srcs: ["foo/bar/MyClass.java"],
449 sdk_version: "none",
450 system_modules: "none",
451 compile_dex: true,
452 }
Jiyong Park9e6c2422019-08-09 20:39:45 +0900453
454 java_import {
455 name: "myprebuiltjar",
456 jars: ["prebuilt.jar"],
457 installable: true,
458 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900459 `)
460
Sundong Ahnabb64432019-10-22 13:58:29 +0900461 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900462
463 optFlags := apexRule.Args["opt_flags"]
464 ensureContains(t, optFlags, "--pubkey vendor/foo/devkeys/testkey.avbpubkey")
Jaewoong Jung14f5ff62019-06-18 13:09:13 -0700465 // Ensure that the NOTICE output is being packaged as an asset.
Sundong Ahnabb64432019-10-22 13:58:29 +0900466 ensureContains(t, optFlags, "--assets_dir "+buildDir+"/.intermediates/myapex/android_common_myapex_image/NOTICE")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900467
Jiyong Park25fc6a92018-11-18 18:02:45 +0900468 copyCmds := apexRule.Args["copy_commands"]
469
470 // Ensure that main rule creates an output
471 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
472
473 // Ensure that apex variant is created for the direct dep
Jiyong Parkda6eb592018-12-19 17:12:36 +0900474 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_core_shared_myapex")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900475 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common_myapex")
Jiyong Park9e6c2422019-08-09 20:39:45 +0900476 ensureListContains(t, ctx.ModuleVariantsForTests("myprebuiltjar"), "android_common_myapex")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900477
478 // Ensure that apex variant is created for the indirect dep
Jiyong Parkda6eb592018-12-19 17:12:36 +0900479 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_core_shared_myapex")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900480 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common_myapex")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900481
482 // Ensure that both direct and indirect deps are copied into apex
Alex Light5098a612018-11-29 17:12:15 -0800483 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
484 ensureContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900485 ensureContains(t, copyCmds, "image.apex/javalib/myjar.jar")
Jiyong Park9e6c2422019-08-09 20:39:45 +0900486 ensureContains(t, copyCmds, "image.apex/javalib/myprebuiltjar.jar")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900487 // .. but not for java libs
488 ensureNotContains(t, copyCmds, "image.apex/javalib/myotherjar.jar")
Logan Chien3aeedc92018-12-26 15:32:21 +0800489
Jiyong Park7f7766d2019-07-25 22:02:35 +0900490 // Ensure that the platform variant ends with _core_shared or _common
Logan Chien3aeedc92018-12-26 15:32:21 +0800491 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_core_shared")
492 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_core_shared")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900493 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common")
494 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common")
Jiyong Park9e6c2422019-08-09 20:39:45 +0900495 ensureListContains(t, ctx.ModuleVariantsForTests("myprebuiltjar"), "android_common")
Alex Light3d673592019-01-18 14:37:31 -0800496
497 // Ensure that all symlinks are present.
498 found_foo_link_64 := false
499 found_foo := false
500 for _, cmd := range strings.Split(copyCmds, " && ") {
501 if strings.HasPrefix(cmd, "ln -s foo64") {
502 if strings.HasSuffix(cmd, "bin/foo") {
503 found_foo = true
504 } else if strings.HasSuffix(cmd, "bin/foo_link_64") {
505 found_foo_link_64 = true
506 }
507 }
508 }
509 good := found_foo && found_foo_link_64
510 if !good {
511 t.Errorf("Could not find all expected symlinks! foo: %t, foo_link_64: %t. Command was %s", found_foo, found_foo_link_64, copyCmds)
512 }
Jiyong Park52818fc2019-03-18 12:01:38 +0900513
Sundong Ahnabb64432019-10-22 13:58:29 +0900514 mergeNoticesRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("mergeNoticesRule")
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700515 noticeInputs := mergeNoticesRule.Inputs.Strings()
Jaewoong Jung14f5ff62019-06-18 13:09:13 -0700516 if len(noticeInputs) != 2 {
517 t.Errorf("number of input notice files: expected = 2, actual = %q", len(noticeInputs))
Jiyong Park52818fc2019-03-18 12:01:38 +0900518 }
519 ensureListContains(t, noticeInputs, "NOTICE")
520 ensureListContains(t, noticeInputs, "custom_notice")
Alex Light5098a612018-11-29 17:12:15 -0800521}
522
Jooyung Han01a3ee22019-11-02 02:52:25 +0900523func TestApexManifest(t *testing.T) {
524 ctx, _ := testApex(t, `
525 apex {
526 name: "myapex",
527 key: "myapex.key",
528 }
529
530 apex_key {
531 name: "myapex.key",
532 public_key: "testkey.avbpubkey",
533 private_key: "testkey.pem",
534 }
535 `)
536
537 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
538 module.Output("apex_manifest.pb")
539 module.Output("apex_manifest.json")
540 module.Output("apex_manifest_full.json")
541}
542
Alex Light5098a612018-11-29 17:12:15 -0800543func TestBasicZipApex(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700544 ctx, _ := testApex(t, `
Alex Light5098a612018-11-29 17:12:15 -0800545 apex {
546 name: "myapex",
547 key: "myapex.key",
548 payload_type: "zip",
549 native_shared_libs: ["mylib"],
550 }
551
552 apex_key {
553 name: "myapex.key",
554 public_key: "testkey.avbpubkey",
555 private_key: "testkey.pem",
556 }
557
558 cc_library {
559 name: "mylib",
560 srcs: ["mylib.cpp"],
561 shared_libs: ["mylib2"],
562 system_shared_libs: [],
563 stl: "none",
564 }
565
566 cc_library {
567 name: "mylib2",
568 srcs: ["mylib.cpp"],
569 system_shared_libs: [],
570 stl: "none",
571 }
572 `)
573
Sundong Ahnabb64432019-10-22 13:58:29 +0900574 zipApexRule := ctx.ModuleForTests("myapex", "android_common_myapex_zip").Rule("zipApexRule")
Alex Light5098a612018-11-29 17:12:15 -0800575 copyCmds := zipApexRule.Args["copy_commands"]
576
577 // Ensure that main rule creates an output
578 ensureContains(t, zipApexRule.Output.String(), "myapex.zipapex.unsigned")
579
580 // Ensure that APEX variant is created for the direct dep
Jiyong Parkda6eb592018-12-19 17:12:36 +0900581 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_core_shared_myapex")
Alex Light5098a612018-11-29 17:12:15 -0800582
583 // Ensure that APEX variant is created for the indirect dep
Jiyong Parkda6eb592018-12-19 17:12:36 +0900584 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_core_shared_myapex")
Alex Light5098a612018-11-29 17:12:15 -0800585
586 // Ensure that both direct and indirect deps are copied into apex
587 ensureContains(t, copyCmds, "image.zipapex/lib64/mylib.so")
588 ensureContains(t, copyCmds, "image.zipapex/lib64/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900589}
590
591func TestApexWithStubs(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700592 ctx, _ := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +0900593 apex {
594 name: "myapex",
595 key: "myapex.key",
596 native_shared_libs: ["mylib", "mylib3"],
597 }
598
599 apex_key {
600 name: "myapex.key",
601 public_key: "testkey.avbpubkey",
602 private_key: "testkey.pem",
603 }
604
605 cc_library {
606 name: "mylib",
607 srcs: ["mylib.cpp"],
608 shared_libs: ["mylib2", "mylib3"],
609 system_shared_libs: [],
610 stl: "none",
611 }
612
613 cc_library {
614 name: "mylib2",
615 srcs: ["mylib.cpp"],
Jiyong Park64379952018-12-13 18:37:29 +0900616 cflags: ["-include mylib.h"],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900617 system_shared_libs: [],
618 stl: "none",
619 stubs: {
620 versions: ["1", "2", "3"],
621 },
622 }
623
624 cc_library {
625 name: "mylib3",
Jiyong Park28d395a2018-12-07 22:42:47 +0900626 srcs: ["mylib.cpp"],
627 shared_libs: ["mylib4"],
628 system_shared_libs: [],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900629 stl: "none",
630 stubs: {
631 versions: ["10", "11", "12"],
632 },
633 }
Jiyong Park28d395a2018-12-07 22:42:47 +0900634
635 cc_library {
636 name: "mylib4",
637 srcs: ["mylib.cpp"],
638 system_shared_libs: [],
639 stl: "none",
640 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900641 `)
642
Sundong Ahnabb64432019-10-22 13:58:29 +0900643 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900644 copyCmds := apexRule.Args["copy_commands"]
645
646 // Ensure that direct non-stubs dep is always included
Alex Light5098a612018-11-29 17:12:15 -0800647 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900648
649 // Ensure that indirect stubs dep is not included
Alex Light5098a612018-11-29 17:12:15 -0800650 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900651
652 // Ensure that direct stubs dep is included
Alex Light5098a612018-11-29 17:12:15 -0800653 ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900654
Jiyong Parkda6eb592018-12-19 17:12:36 +0900655 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_core_shared_myapex").Rule("ld").Args["libFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +0900656
657 // Ensure that mylib is linking with the latest version of stubs for mylib2
Jiyong Parkda6eb592018-12-19 17:12:36 +0900658 ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_core_shared_3_myapex/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900659 // ... and not linking to the non-stub (impl) variant of mylib2
Jiyong Parkda6eb592018-12-19 17:12:36 +0900660 ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_core_shared_myapex/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900661
662 // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
Jiyong Parkda6eb592018-12-19 17:12:36 +0900663 ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_core_shared_myapex/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900664 // .. and not linking to the stubs variant of mylib3
Jiyong Parkda6eb592018-12-19 17:12:36 +0900665 ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_core_shared_12_myapex/mylib3.so")
Jiyong Park64379952018-12-13 18:37:29 +0900666
667 // Ensure that stubs libs are built without -include flags
Jiyong Parkda6eb592018-12-19 17:12:36 +0900668 mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_core_static_myapex").Rule("cc").Args["cFlags"]
Jiyong Park64379952018-12-13 18:37:29 +0900669 ensureNotContains(t, mylib2Cflags, "-include ")
Jiyong Park3fd0baf2018-12-07 16:25:39 +0900670
671 // Ensure that genstub is invoked with --apex
Jiyong Parkda6eb592018-12-19 17:12:36 +0900672 ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_core_static_3_myapex").Rule("genStubSrc").Args["flags"])
Jiyong Park25fc6a92018-11-18 18:02:45 +0900673}
674
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900675func TestApexWithExplicitStubsDependency(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700676 ctx, _ := testApex(t, `
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900677 apex {
678 name: "myapex",
679 key: "myapex.key",
680 native_shared_libs: ["mylib"],
681 }
682
683 apex_key {
684 name: "myapex.key",
685 public_key: "testkey.avbpubkey",
686 private_key: "testkey.pem",
687 }
688
689 cc_library {
690 name: "mylib",
691 srcs: ["mylib.cpp"],
692 shared_libs: ["libfoo#10"],
693 system_shared_libs: [],
694 stl: "none",
695 }
696
697 cc_library {
698 name: "libfoo",
699 srcs: ["mylib.cpp"],
700 shared_libs: ["libbar"],
701 system_shared_libs: [],
702 stl: "none",
703 stubs: {
704 versions: ["10", "20", "30"],
705 },
706 }
707
708 cc_library {
709 name: "libbar",
710 srcs: ["mylib.cpp"],
711 system_shared_libs: [],
712 stl: "none",
713 }
714
715 `)
716
Sundong Ahnabb64432019-10-22 13:58:29 +0900717 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900718 copyCmds := apexRule.Args["copy_commands"]
719
720 // Ensure that direct non-stubs dep is always included
721 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
722
723 // Ensure that indirect stubs dep is not included
724 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
725
726 // Ensure that dependency of stubs is not included
727 ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so")
728
Jiyong Parkda6eb592018-12-19 17:12:36 +0900729 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_core_shared_myapex").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900730
731 // Ensure that mylib is linking with version 10 of libfoo
Jiyong Parkda6eb592018-12-19 17:12:36 +0900732 ensureContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_core_shared_10_myapex/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900733 // ... and not linking to the non-stub (impl) variant of libfoo
Jiyong Parkda6eb592018-12-19 17:12:36 +0900734 ensureNotContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_core_shared_myapex/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900735
Jiyong Parkda6eb592018-12-19 17:12:36 +0900736 libFooStubsLdFlags := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_core_shared_10_myapex").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900737
738 // Ensure that libfoo stubs is not linking to libbar (since it is a stubs)
739 ensureNotContains(t, libFooStubsLdFlags, "libbar.so")
740}
741
Jooyung Hand3639552019-08-09 12:57:43 +0900742func TestApexWithRuntimeLibsDependency(t *testing.T) {
743 /*
744 myapex
745 |
746 v (runtime_libs)
747 mylib ------+------> libfoo [provides stub]
748 |
749 `------> libbar
750 */
751 ctx, _ := testApex(t, `
752 apex {
753 name: "myapex",
754 key: "myapex.key",
755 native_shared_libs: ["mylib"],
756 }
757
758 apex_key {
759 name: "myapex.key",
760 public_key: "testkey.avbpubkey",
761 private_key: "testkey.pem",
762 }
763
764 cc_library {
765 name: "mylib",
766 srcs: ["mylib.cpp"],
767 runtime_libs: ["libfoo", "libbar"],
768 system_shared_libs: [],
769 stl: "none",
770 }
771
772 cc_library {
773 name: "libfoo",
774 srcs: ["mylib.cpp"],
775 system_shared_libs: [],
776 stl: "none",
777 stubs: {
778 versions: ["10", "20", "30"],
779 },
780 }
781
782 cc_library {
783 name: "libbar",
784 srcs: ["mylib.cpp"],
785 system_shared_libs: [],
786 stl: "none",
787 }
788
789 `)
790
Sundong Ahnabb64432019-10-22 13:58:29 +0900791 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jooyung Hand3639552019-08-09 12:57:43 +0900792 copyCmds := apexRule.Args["copy_commands"]
793
794 // Ensure that direct non-stubs dep is always included
795 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
796
797 // Ensure that indirect stubs dep is not included
798 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
799
800 // Ensure that runtime_libs dep in included
801 ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
802
Sundong Ahnabb64432019-10-22 13:58:29 +0900803 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +0900804 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
805 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.so")
Jooyung Hand3639552019-08-09 12:57:43 +0900806
807}
808
Jooyung Han9c80bae2019-08-20 17:30:57 +0900809func TestApexDependencyToLLNDK(t *testing.T) {
810 ctx, _ := testApex(t, `
811 apex {
812 name: "myapex",
813 key: "myapex.key",
814 use_vendor: true,
815 native_shared_libs: ["mylib"],
816 }
817
818 apex_key {
819 name: "myapex.key",
820 public_key: "testkey.avbpubkey",
821 private_key: "testkey.pem",
822 }
823
824 cc_library {
825 name: "mylib",
826 srcs: ["mylib.cpp"],
827 vendor_available: true,
828 shared_libs: ["libbar"],
829 system_shared_libs: [],
830 stl: "none",
831 }
832
833 cc_library {
834 name: "libbar",
835 srcs: ["mylib.cpp"],
836 system_shared_libs: [],
837 stl: "none",
838 }
839
840 llndk_library {
841 name: "libbar",
842 symbol_file: "",
843 }
Jooyung Handc782442019-11-01 03:14:38 +0900844 `, func(fs map[string][]byte, config android.Config) {
845 setUseVendorWhitelistForTest(config, []string{"myapex"})
846 })
Jooyung Han9c80bae2019-08-20 17:30:57 +0900847
Sundong Ahnabb64432019-10-22 13:58:29 +0900848 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jooyung Han9c80bae2019-08-20 17:30:57 +0900849 copyCmds := apexRule.Args["copy_commands"]
850
851 // Ensure that LLNDK dep is not included
852 ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so")
853
Sundong Ahnabb64432019-10-22 13:58:29 +0900854 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +0900855 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
Jooyung Han9c80bae2019-08-20 17:30:57 +0900856
857 // Ensure that LLNDK dep is required
Jooyung Hand15aa1f2019-09-27 00:38:03 +0900858 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libbar.so")
Jooyung Han9c80bae2019-08-20 17:30:57 +0900859
860}
861
Jiyong Park25fc6a92018-11-18 18:02:45 +0900862func TestApexWithSystemLibsStubs(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700863 ctx, _ := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +0900864 apex {
865 name: "myapex",
866 key: "myapex.key",
867 native_shared_libs: ["mylib", "mylib_shared", "libdl", "libm"],
868 }
869
870 apex_key {
871 name: "myapex.key",
872 public_key: "testkey.avbpubkey",
873 private_key: "testkey.pem",
874 }
875
876 cc_library {
877 name: "mylib",
878 srcs: ["mylib.cpp"],
879 shared_libs: ["libdl#27"],
880 stl: "none",
881 }
882
883 cc_library_shared {
884 name: "mylib_shared",
885 srcs: ["mylib.cpp"],
886 shared_libs: ["libdl#27"],
887 stl: "none",
888 }
889
890 cc_library {
891 name: "libc",
Yi Konge7fe9912019-06-02 00:53:50 -0700892 no_libcrt: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900893 nocrt: true,
894 system_shared_libs: [],
895 stl: "none",
896 stubs: {
897 versions: ["27", "28", "29"],
898 },
899 }
900
901 cc_library {
902 name: "libm",
Yi Konge7fe9912019-06-02 00:53:50 -0700903 no_libcrt: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900904 nocrt: true,
905 system_shared_libs: [],
906 stl: "none",
907 stubs: {
908 versions: ["27", "28", "29"],
909 },
910 }
911
912 cc_library {
913 name: "libdl",
Yi Konge7fe9912019-06-02 00:53:50 -0700914 no_libcrt: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900915 nocrt: true,
916 system_shared_libs: [],
917 stl: "none",
918 stubs: {
919 versions: ["27", "28", "29"],
920 },
921 }
Jiyong Parkb0788572018-12-20 22:10:17 +0900922
923 cc_library {
924 name: "libBootstrap",
925 srcs: ["mylib.cpp"],
926 stl: "none",
927 bootstrap: true,
928 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900929 `)
930
Sundong Ahnabb64432019-10-22 13:58:29 +0900931 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900932 copyCmds := apexRule.Args["copy_commands"]
933
934 // Ensure that mylib, libm, libdl are included.
Alex Light5098a612018-11-29 17:12:15 -0800935 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Parkb0788572018-12-20 22:10:17 +0900936 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libm.so")
937 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900938
939 // Ensure that libc is not included (since it has stubs and not listed in native_shared_libs)
Jiyong Parkb0788572018-12-20 22:10:17 +0900940 ensureNotContains(t, copyCmds, "image.apex/lib64/bionic/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900941
Jiyong Parkda6eb592018-12-19 17:12:36 +0900942 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_core_shared_myapex").Rule("ld").Args["libFlags"]
943 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_core_static_myapex").Rule("cc").Args["cFlags"]
944 mylibSharedCFlags := ctx.ModuleForTests("mylib_shared", "android_arm64_armv8-a_core_shared_myapex").Rule("cc").Args["cFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +0900945
946 // For dependency to libc
947 // Ensure that mylib is linking with the latest version of stubs
Jiyong Parkda6eb592018-12-19 17:12:36 +0900948 ensureContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_core_shared_29_myapex/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900949 // ... and not linking to the non-stub (impl) variant
Jiyong Parkda6eb592018-12-19 17:12:36 +0900950 ensureNotContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_core_shared_myapex/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900951 // ... Cflags from stub is correctly exported to mylib
952 ensureContains(t, mylibCFlags, "__LIBC_API__=29")
953 ensureContains(t, mylibSharedCFlags, "__LIBC_API__=29")
954
955 // For dependency to libm
956 // Ensure that mylib is linking with the non-stub (impl) variant
Jiyong Parkda6eb592018-12-19 17:12:36 +0900957 ensureContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_core_shared_myapex/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900958 // ... and not linking to the stub variant
Jiyong Parkda6eb592018-12-19 17:12:36 +0900959 ensureNotContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_core_shared_29_myapex/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900960 // ... and is not compiling with the stub
961 ensureNotContains(t, mylibCFlags, "__LIBM_API__=29")
962 ensureNotContains(t, mylibSharedCFlags, "__LIBM_API__=29")
963
964 // For dependency to libdl
965 // Ensure that mylib is linking with the specified version of stubs
Jiyong Parkda6eb592018-12-19 17:12:36 +0900966 ensureContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_core_shared_27_myapex/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900967 // ... and not linking to the other versions of stubs
Jiyong Parkda6eb592018-12-19 17:12:36 +0900968 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_core_shared_28_myapex/libdl.so")
969 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_core_shared_29_myapex/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900970 // ... and not linking to the non-stub (impl) variant
Jiyong Parkda6eb592018-12-19 17:12:36 +0900971 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_core_shared_myapex/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900972 // ... Cflags from stub is correctly exported to mylib
973 ensureContains(t, mylibCFlags, "__LIBDL_API__=27")
974 ensureContains(t, mylibSharedCFlags, "__LIBDL_API__=27")
Jiyong Parkb0788572018-12-20 22:10:17 +0900975
976 // Ensure that libBootstrap is depending on the platform variant of bionic libs
977 libFlags := ctx.ModuleForTests("libBootstrap", "android_arm64_armv8-a_core_shared").Rule("ld").Args["libFlags"]
978 ensureContains(t, libFlags, "libc/android_arm64_armv8-a_core_shared/libc.so")
979 ensureContains(t, libFlags, "libm/android_arm64_armv8-a_core_shared/libm.so")
980 ensureContains(t, libFlags, "libdl/android_arm64_armv8-a_core_shared/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900981}
Jiyong Park7c2ee712018-12-07 00:42:25 +0900982
983func TestFilesInSubDir(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700984 ctx, _ := testApex(t, `
Jiyong Park7c2ee712018-12-07 00:42:25 +0900985 apex {
986 name: "myapex",
987 key: "myapex.key",
Jiyong Parkb7c24df2019-02-01 12:03:59 +0900988 native_shared_libs: ["mylib"],
989 binaries: ["mybin"],
Jiyong Park7c2ee712018-12-07 00:42:25 +0900990 prebuilts: ["myetc"],
Jiyong Parkb7c24df2019-02-01 12:03:59 +0900991 compile_multilib: "both",
Jiyong Park7c2ee712018-12-07 00:42:25 +0900992 }
993
994 apex_key {
995 name: "myapex.key",
996 public_key: "testkey.avbpubkey",
997 private_key: "testkey.pem",
998 }
999
1000 prebuilt_etc {
1001 name: "myetc",
1002 src: "myprebuilt",
1003 sub_dir: "foo/bar",
1004 }
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001005
1006 cc_library {
1007 name: "mylib",
1008 srcs: ["mylib.cpp"],
1009 relative_install_path: "foo/bar",
1010 system_shared_libs: [],
1011 stl: "none",
1012 }
1013
1014 cc_binary {
1015 name: "mybin",
1016 srcs: ["mylib.cpp"],
1017 relative_install_path: "foo/bar",
1018 system_shared_libs: [],
1019 static_executable: true,
1020 stl: "none",
1021 }
Jiyong Park7c2ee712018-12-07 00:42:25 +09001022 `)
1023
Sundong Ahnabb64432019-10-22 13:58:29 +09001024 generateFsRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("generateFsConfig")
Jiyong Park7c2ee712018-12-07 00:42:25 +09001025 dirs := strings.Split(generateFsRule.Args["exec_paths"], " ")
1026
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001027 // Ensure that the subdirectories are all listed
Jiyong Park7c2ee712018-12-07 00:42:25 +09001028 ensureListContains(t, dirs, "etc")
1029 ensureListContains(t, dirs, "etc/foo")
1030 ensureListContains(t, dirs, "etc/foo/bar")
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001031 ensureListContains(t, dirs, "lib64")
1032 ensureListContains(t, dirs, "lib64/foo")
1033 ensureListContains(t, dirs, "lib64/foo/bar")
1034 ensureListContains(t, dirs, "lib")
1035 ensureListContains(t, dirs, "lib/foo")
1036 ensureListContains(t, dirs, "lib/foo/bar")
1037
Jiyong Parkbd13e442019-03-15 18:10:35 +09001038 ensureListContains(t, dirs, "bin")
1039 ensureListContains(t, dirs, "bin/foo")
1040 ensureListContains(t, dirs, "bin/foo/bar")
Jiyong Park7c2ee712018-12-07 00:42:25 +09001041}
Jiyong Parkda6eb592018-12-19 17:12:36 +09001042
1043func TestUseVendor(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001044 ctx, _ := testApex(t, `
Jiyong Parkda6eb592018-12-19 17:12:36 +09001045 apex {
1046 name: "myapex",
1047 key: "myapex.key",
1048 native_shared_libs: ["mylib"],
1049 use_vendor: true,
1050 }
1051
1052 apex_key {
1053 name: "myapex.key",
1054 public_key: "testkey.avbpubkey",
1055 private_key: "testkey.pem",
1056 }
1057
1058 cc_library {
1059 name: "mylib",
1060 srcs: ["mylib.cpp"],
1061 shared_libs: ["mylib2"],
1062 system_shared_libs: [],
1063 vendor_available: true,
1064 stl: "none",
1065 }
1066
1067 cc_library {
1068 name: "mylib2",
1069 srcs: ["mylib.cpp"],
1070 system_shared_libs: [],
1071 vendor_available: true,
1072 stl: "none",
1073 }
Jooyung Handc782442019-11-01 03:14:38 +09001074 `, func(fs map[string][]byte, config android.Config) {
1075 setUseVendorWhitelistForTest(config, []string{"myapex"})
1076 })
Jiyong Parkda6eb592018-12-19 17:12:36 +09001077
1078 inputsList := []string{}
Sundong Ahnabb64432019-10-22 13:58:29 +09001079 for _, i := range ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().BuildParamsForTests() {
Jiyong Parkda6eb592018-12-19 17:12:36 +09001080 for _, implicit := range i.Implicits {
1081 inputsList = append(inputsList, implicit.String())
1082 }
1083 }
1084 inputsString := strings.Join(inputsList, " ")
1085
1086 // ensure that the apex includes vendor variants of the direct and indirect deps
Inseob Kim64c43952019-08-26 16:52:35 +09001087 ensureContains(t, inputsString, "android_arm64_armv8-a_vendor.VER_shared_myapex/mylib.so")
1088 ensureContains(t, inputsString, "android_arm64_armv8-a_vendor.VER_shared_myapex/mylib2.so")
Jiyong Parkda6eb592018-12-19 17:12:36 +09001089
1090 // ensure that the apex does not include core variants
1091 ensureNotContains(t, inputsString, "android_arm64_armv8-a_core_shared_myapex/mylib.so")
1092 ensureNotContains(t, inputsString, "android_arm64_armv8-a_core_shared_myapex/mylib2.so")
1093}
Jiyong Park16e91a02018-12-20 18:18:08 +09001094
Jooyung Handc782442019-11-01 03:14:38 +09001095func TestUseVendorRestriction(t *testing.T) {
1096 testApexError(t, `module "myapex" .*: use_vendor: not allowed`, `
1097 apex {
1098 name: "myapex",
1099 key: "myapex.key",
1100 use_vendor: true,
1101 }
1102 apex_key {
1103 name: "myapex.key",
1104 public_key: "testkey.avbpubkey",
1105 private_key: "testkey.pem",
1106 }
1107 `, func(fs map[string][]byte, config android.Config) {
1108 setUseVendorWhitelistForTest(config, []string{""})
1109 })
1110 // no error with whitelist
1111 testApex(t, `
1112 apex {
1113 name: "myapex",
1114 key: "myapex.key",
1115 use_vendor: true,
1116 }
1117 apex_key {
1118 name: "myapex.key",
1119 public_key: "testkey.avbpubkey",
1120 private_key: "testkey.pem",
1121 }
1122 `, func(fs map[string][]byte, config android.Config) {
1123 setUseVendorWhitelistForTest(config, []string{"myapex"})
1124 })
1125}
1126
Jooyung Han5c998b92019-06-27 11:30:33 +09001127func TestUseVendorFailsIfNotVendorAvailable(t *testing.T) {
1128 testApexError(t, `dependency "mylib" of "myapex" missing variant:\n.*image:vendor`, `
1129 apex {
1130 name: "myapex",
1131 key: "myapex.key",
1132 native_shared_libs: ["mylib"],
1133 use_vendor: true,
1134 }
1135
1136 apex_key {
1137 name: "myapex.key",
1138 public_key: "testkey.avbpubkey",
1139 private_key: "testkey.pem",
1140 }
1141
1142 cc_library {
1143 name: "mylib",
1144 srcs: ["mylib.cpp"],
1145 system_shared_libs: [],
1146 stl: "none",
1147 }
1148 `)
1149}
1150
Jiyong Park16e91a02018-12-20 18:18:08 +09001151func TestStaticLinking(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001152 ctx, _ := testApex(t, `
Jiyong Park16e91a02018-12-20 18:18:08 +09001153 apex {
1154 name: "myapex",
1155 key: "myapex.key",
1156 native_shared_libs: ["mylib"],
1157 }
1158
1159 apex_key {
1160 name: "myapex.key",
1161 public_key: "testkey.avbpubkey",
1162 private_key: "testkey.pem",
1163 }
1164
1165 cc_library {
1166 name: "mylib",
1167 srcs: ["mylib.cpp"],
1168 system_shared_libs: [],
1169 stl: "none",
1170 stubs: {
1171 versions: ["1", "2", "3"],
1172 },
1173 }
1174
1175 cc_binary {
1176 name: "not_in_apex",
1177 srcs: ["mylib.cpp"],
1178 static_libs: ["mylib"],
1179 static_executable: true,
1180 system_shared_libs: [],
1181 stl: "none",
1182 }
Jiyong Park16e91a02018-12-20 18:18:08 +09001183 `)
1184
1185 ldFlags := ctx.ModuleForTests("not_in_apex", "android_arm64_armv8-a_core").Rule("ld").Args["libFlags"]
1186
1187 // Ensure that not_in_apex is linking with the static variant of mylib
Logan Chien3aeedc92018-12-26 15:32:21 +08001188 ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_core_static/mylib.a")
Jiyong Park16e91a02018-12-20 18:18:08 +09001189}
Jiyong Park9335a262018-12-24 11:31:58 +09001190
1191func TestKeys(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001192 ctx, _ := testApex(t, `
Jiyong Park9335a262018-12-24 11:31:58 +09001193 apex {
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001194 name: "myapex_keytest",
Jiyong Park9335a262018-12-24 11:31:58 +09001195 key: "myapex.key",
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001196 certificate: ":myapex.certificate",
Jiyong Park9335a262018-12-24 11:31:58 +09001197 native_shared_libs: ["mylib"],
1198 }
1199
1200 cc_library {
1201 name: "mylib",
1202 srcs: ["mylib.cpp"],
1203 system_shared_libs: [],
1204 stl: "none",
1205 }
1206
1207 apex_key {
1208 name: "myapex.key",
1209 public_key: "testkey.avbpubkey",
1210 private_key: "testkey.pem",
1211 }
1212
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001213 android_app_certificate {
1214 name: "myapex.certificate",
1215 certificate: "testkey",
1216 }
1217
1218 android_app_certificate {
1219 name: "myapex.certificate.override",
1220 certificate: "testkey.override",
1221 }
1222
Jiyong Park9335a262018-12-24 11:31:58 +09001223 `)
1224
1225 // check the APEX keys
Jiyong Parkd1e293d2019-03-15 02:13:21 +09001226 keys := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
Jiyong Park9335a262018-12-24 11:31:58 +09001227
1228 if keys.public_key_file.String() != "vendor/foo/devkeys/testkey.avbpubkey" {
1229 t.Errorf("public key %q is not %q", keys.public_key_file.String(),
1230 "vendor/foo/devkeys/testkey.avbpubkey")
1231 }
1232 if keys.private_key_file.String() != "vendor/foo/devkeys/testkey.pem" {
1233 t.Errorf("private key %q is not %q", keys.private_key_file.String(),
1234 "vendor/foo/devkeys/testkey.pem")
1235 }
1236
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001237 // check the APK certs. It should be overridden to myapex.certificate.override
Sundong Ahnabb64432019-10-22 13:58:29 +09001238 certs := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk").Args["certificates"]
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001239 if certs != "testkey.override.x509.pem testkey.override.pk8" {
Jiyong Park9335a262018-12-24 11:31:58 +09001240 t.Errorf("cert and private key %q are not %q", certs,
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001241 "testkey.override.509.pem testkey.override.pk8")
Jiyong Park9335a262018-12-24 11:31:58 +09001242 }
1243}
Jiyong Park58e364a2019-01-19 19:24:06 +09001244
1245func TestMacro(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001246 ctx, _ := testApex(t, `
Jiyong Park58e364a2019-01-19 19:24:06 +09001247 apex {
1248 name: "myapex",
1249 key: "myapex.key",
1250 native_shared_libs: ["mylib"],
1251 }
1252
1253 apex {
1254 name: "otherapex",
1255 key: "myapex.key",
1256 native_shared_libs: ["mylib"],
1257 }
1258
1259 apex_key {
1260 name: "myapex.key",
1261 public_key: "testkey.avbpubkey",
1262 private_key: "testkey.pem",
1263 }
1264
1265 cc_library {
1266 name: "mylib",
1267 srcs: ["mylib.cpp"],
1268 system_shared_libs: [],
1269 stl: "none",
1270 }
1271 `)
1272
Jooyung Han6b8459b2019-10-30 08:29:25 +09001273 // non-APEX variant does not have __ANDROID_APEX(_NAME)__ defined
Jiyong Park58e364a2019-01-19 19:24:06 +09001274 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_core_static").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09001275 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Han77988572019-10-18 16:26:16 +09001276 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
1277 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09001278
Jooyung Han6b8459b2019-10-30 08:29:25 +09001279 // APEX variant has __ANDROID_APEX(_NAME)__ defined
Jiyong Park58e364a2019-01-19 19:24:06 +09001280 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_core_static_myapex").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09001281 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Han77988572019-10-18 16:26:16 +09001282 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
1283 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09001284
Jooyung Han6b8459b2019-10-30 08:29:25 +09001285 // APEX variant has __ANDROID_APEX(_NAME)__ defined
Jiyong Park58e364a2019-01-19 19:24:06 +09001286 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_core_static_otherapex").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09001287 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Han77988572019-10-18 16:26:16 +09001288 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
1289 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09001290}
Jiyong Park7e636d02019-01-28 16:16:54 +09001291
1292func TestHeaderLibsDependency(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001293 ctx, _ := testApex(t, `
Jiyong Park7e636d02019-01-28 16:16:54 +09001294 apex {
1295 name: "myapex",
1296 key: "myapex.key",
1297 native_shared_libs: ["mylib"],
1298 }
1299
1300 apex_key {
1301 name: "myapex.key",
1302 public_key: "testkey.avbpubkey",
1303 private_key: "testkey.pem",
1304 }
1305
1306 cc_library_headers {
1307 name: "mylib_headers",
1308 export_include_dirs: ["my_include"],
1309 system_shared_libs: [],
1310 stl: "none",
1311 }
1312
1313 cc_library {
1314 name: "mylib",
1315 srcs: ["mylib.cpp"],
1316 system_shared_libs: [],
1317 stl: "none",
1318 header_libs: ["mylib_headers"],
1319 export_header_lib_headers: ["mylib_headers"],
1320 stubs: {
1321 versions: ["1", "2", "3"],
1322 },
1323 }
1324
1325 cc_library {
1326 name: "otherlib",
1327 srcs: ["mylib.cpp"],
1328 system_shared_libs: [],
1329 stl: "none",
1330 shared_libs: ["mylib"],
1331 }
1332 `)
1333
1334 cFlags := ctx.ModuleForTests("otherlib", "android_arm64_armv8-a_core_static").Rule("cc").Args["cFlags"]
1335
1336 // Ensure that the include path of the header lib is exported to 'otherlib'
1337 ensureContains(t, cFlags, "-Imy_include")
1338}
Alex Light9670d332019-01-29 18:07:33 -08001339
Jooyung Han31c470b2019-10-18 16:26:59 +09001340func ensureExactContents(t *testing.T, ctx *android.TestContext, moduleName string, files []string) {
1341 t.Helper()
Sundong Ahnabb64432019-10-22 13:58:29 +09001342 apexRule := ctx.ModuleForTests(moduleName, "android_common_"+moduleName+"_image").Rule("apexRule")
Jooyung Han31c470b2019-10-18 16:26:59 +09001343 copyCmds := apexRule.Args["copy_commands"]
1344 imageApexDir := "/image.apex/"
Jooyung Han39edb6c2019-11-06 16:53:07 +09001345 var failed bool
1346 var surplus []string
1347 filesMatched := make(map[string]bool)
1348 addContent := func(content string) {
1349 for _, expected := range files {
1350 if matched, _ := path.Match(expected, content); matched {
1351 filesMatched[expected] = true
1352 return
1353 }
1354 }
1355 surplus = append(surplus, content)
1356 }
Jooyung Han31c470b2019-10-18 16:26:59 +09001357 for _, cmd := range strings.Split(copyCmds, "&&") {
1358 cmd = strings.TrimSpace(cmd)
1359 if cmd == "" {
1360 continue
1361 }
1362 terms := strings.Split(cmd, " ")
1363 switch terms[0] {
1364 case "mkdir":
1365 case "cp":
1366 if len(terms) != 3 {
1367 t.Fatal("copyCmds contains invalid cp command", cmd)
1368 }
1369 dst := terms[2]
1370 index := strings.Index(dst, imageApexDir)
1371 if index == -1 {
1372 t.Fatal("copyCmds should copy a file to image.apex/", cmd)
1373 }
1374 dstFile := dst[index+len(imageApexDir):]
Jooyung Han39edb6c2019-11-06 16:53:07 +09001375 addContent(dstFile)
Jooyung Han31c470b2019-10-18 16:26:59 +09001376 default:
1377 t.Fatalf("copyCmds should contain mkdir/cp commands only: %q", cmd)
1378 }
1379 }
Jooyung Han31c470b2019-10-18 16:26:59 +09001380
Jooyung Han31c470b2019-10-18 16:26:59 +09001381 if len(surplus) > 0 {
Jooyung Han39edb6c2019-11-06 16:53:07 +09001382 sort.Strings(surplus)
Jooyung Han31c470b2019-10-18 16:26:59 +09001383 t.Log("surplus files", surplus)
1384 failed = true
1385 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09001386
1387 if len(files) > len(filesMatched) {
1388 var missing []string
1389 for _, expected := range files {
1390 if !filesMatched[expected] {
1391 missing = append(missing, expected)
1392 }
1393 }
1394 sort.Strings(missing)
Jooyung Han31c470b2019-10-18 16:26:59 +09001395 t.Log("missing files", missing)
1396 failed = true
1397 }
1398 if failed {
1399 t.Fail()
1400 }
1401}
1402
Jooyung Han344d5432019-08-23 11:17:39 +09001403func TestVndkApexCurrent(t *testing.T) {
1404 ctx, _ := testApex(t, `
1405 apex_vndk {
1406 name: "myapex",
1407 key: "myapex.key",
1408 file_contexts: "myapex",
1409 }
1410
1411 apex_key {
1412 name: "myapex.key",
1413 public_key: "testkey.avbpubkey",
1414 private_key: "testkey.pem",
1415 }
1416
1417 cc_library {
1418 name: "libvndk",
1419 srcs: ["mylib.cpp"],
1420 vendor_available: true,
1421 vndk: {
1422 enabled: true,
1423 },
1424 system_shared_libs: [],
1425 stl: "none",
1426 }
1427
1428 cc_library {
1429 name: "libvndksp",
1430 srcs: ["mylib.cpp"],
1431 vendor_available: true,
1432 vndk: {
1433 enabled: true,
1434 support_system_process: true,
1435 },
1436 system_shared_libs: [],
1437 stl: "none",
1438 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09001439 `+vndkLibrariesTxtFiles("current"))
Jooyung Han344d5432019-08-23 11:17:39 +09001440
Jooyung Han31c470b2019-10-18 16:26:59 +09001441 ensureExactContents(t, ctx, "myapex", []string{
1442 "lib/libvndk.so",
1443 "lib/libvndksp.so",
1444 "lib64/libvndk.so",
1445 "lib64/libvndksp.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09001446 "etc/llndk.libraries.VER.txt",
1447 "etc/vndkcore.libraries.VER.txt",
1448 "etc/vndksp.libraries.VER.txt",
1449 "etc/vndkprivate.libraries.VER.txt",
1450 "etc/vndkcorevariant.libraries.VER.txt",
Jooyung Han31c470b2019-10-18 16:26:59 +09001451 })
Jooyung Han344d5432019-08-23 11:17:39 +09001452}
1453
1454func TestVndkApexWithPrebuilt(t *testing.T) {
1455 ctx, _ := testApex(t, `
1456 apex_vndk {
1457 name: "myapex",
1458 key: "myapex.key",
1459 file_contexts: "myapex",
1460 }
1461
1462 apex_key {
1463 name: "myapex.key",
1464 public_key: "testkey.avbpubkey",
1465 private_key: "testkey.pem",
1466 }
1467
1468 cc_prebuilt_library_shared {
Jooyung Han31c470b2019-10-18 16:26:59 +09001469 name: "libvndk",
1470 srcs: ["libvndk.so"],
Jooyung Han344d5432019-08-23 11:17:39 +09001471 vendor_available: true,
1472 vndk: {
1473 enabled: true,
1474 },
1475 system_shared_libs: [],
1476 stl: "none",
1477 }
Jooyung Han31c470b2019-10-18 16:26:59 +09001478
1479 cc_prebuilt_library_shared {
1480 name: "libvndk.arm",
1481 srcs: ["libvndk.arm.so"],
1482 vendor_available: true,
1483 vndk: {
1484 enabled: true,
1485 },
1486 enabled: false,
1487 arch: {
1488 arm: {
1489 enabled: true,
1490 },
1491 },
1492 system_shared_libs: [],
1493 stl: "none",
1494 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09001495 `+vndkLibrariesTxtFiles("current"),
1496 withFiles(map[string][]byte{
1497 "libvndk.so": nil,
1498 "libvndk.arm.so": nil,
1499 }))
Jooyung Han344d5432019-08-23 11:17:39 +09001500
Jooyung Han31c470b2019-10-18 16:26:59 +09001501 ensureExactContents(t, ctx, "myapex", []string{
1502 "lib/libvndk.so",
1503 "lib/libvndk.arm.so",
1504 "lib64/libvndk.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09001505 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09001506 })
Jooyung Han344d5432019-08-23 11:17:39 +09001507}
1508
Jooyung Han39edb6c2019-11-06 16:53:07 +09001509func vndkLibrariesTxtFiles(vers ...string) (result string) {
1510 for _, v := range vers {
1511 if v == "current" {
1512 for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkcorevariant"} {
1513 result += `
1514 vndk_libraries_txt {
1515 name: "` + txt + `.libraries.txt",
1516 }
1517 `
1518 }
1519 } else {
1520 for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate"} {
1521 result += `
1522 prebuilt_etc {
1523 name: "` + txt + `.libraries.` + v + `.txt",
1524 src: "dummy.txt",
1525 }
1526 `
1527 }
1528 }
1529 }
1530 return
1531}
1532
Jooyung Han344d5432019-08-23 11:17:39 +09001533func TestVndkApexVersion(t *testing.T) {
1534 ctx, _ := testApex(t, `
1535 apex_vndk {
1536 name: "myapex_v27",
1537 key: "myapex.key",
1538 file_contexts: "myapex",
1539 vndk_version: "27",
1540 }
1541
1542 apex_key {
1543 name: "myapex.key",
1544 public_key: "testkey.avbpubkey",
1545 private_key: "testkey.pem",
1546 }
1547
Jooyung Han31c470b2019-10-18 16:26:59 +09001548 vndk_prebuilt_shared {
1549 name: "libvndk27",
1550 version: "27",
Jooyung Han344d5432019-08-23 11:17:39 +09001551 vendor_available: true,
1552 vndk: {
1553 enabled: true,
1554 },
Jooyung Han31c470b2019-10-18 16:26:59 +09001555 target_arch: "arm64",
1556 arch: {
1557 arm: {
1558 srcs: ["libvndk27_arm.so"],
1559 },
1560 arm64: {
1561 srcs: ["libvndk27_arm64.so"],
1562 },
1563 },
Jooyung Han344d5432019-08-23 11:17:39 +09001564 }
1565
1566 vndk_prebuilt_shared {
1567 name: "libvndk27",
1568 version: "27",
1569 vendor_available: true,
1570 vndk: {
1571 enabled: true,
1572 },
Jooyung Han31c470b2019-10-18 16:26:59 +09001573 target_arch: "x86_64",
1574 arch: {
1575 x86: {
1576 srcs: ["libvndk27_x86.so"],
1577 },
1578 x86_64: {
1579 srcs: ["libvndk27_x86_64.so"],
1580 },
1581 },
Jooyung Han39edb6c2019-11-06 16:53:07 +09001582 }
1583 `+vndkLibrariesTxtFiles("27"),
1584 withFiles(map[string][]byte{
1585 "libvndk27_arm.so": nil,
1586 "libvndk27_arm64.so": nil,
1587 "libvndk27_x86.so": nil,
1588 "libvndk27_x86_64.so": nil,
1589 }))
Jooyung Han344d5432019-08-23 11:17:39 +09001590
Jooyung Han31c470b2019-10-18 16:26:59 +09001591 ensureExactContents(t, ctx, "myapex_v27", []string{
1592 "lib/libvndk27_arm.so",
1593 "lib64/libvndk27_arm64.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09001594 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09001595 })
Jooyung Han344d5432019-08-23 11:17:39 +09001596}
1597
1598func TestVndkApexErrorWithDuplicateVersion(t *testing.T) {
1599 testApexError(t, `module "myapex_v27.*" .*: vndk_version: 27 is already defined in "myapex_v27.*"`, `
1600 apex_vndk {
1601 name: "myapex_v27",
1602 key: "myapex.key",
1603 file_contexts: "myapex",
1604 vndk_version: "27",
1605 }
1606 apex_vndk {
1607 name: "myapex_v27_other",
1608 key: "myapex.key",
1609 file_contexts: "myapex",
1610 vndk_version: "27",
1611 }
1612
1613 apex_key {
1614 name: "myapex.key",
1615 public_key: "testkey.avbpubkey",
1616 private_key: "testkey.pem",
1617 }
1618
1619 cc_library {
1620 name: "libvndk",
1621 srcs: ["mylib.cpp"],
1622 vendor_available: true,
1623 vndk: {
1624 enabled: true,
1625 },
1626 system_shared_libs: [],
1627 stl: "none",
1628 }
1629
1630 vndk_prebuilt_shared {
1631 name: "libvndk",
1632 version: "27",
1633 vendor_available: true,
1634 vndk: {
1635 enabled: true,
1636 },
1637 srcs: ["libvndk.so"],
1638 }
1639 `, withFiles(map[string][]byte{
1640 "libvndk.so": nil,
1641 }))
1642}
1643
Jooyung Han90eee022019-10-01 20:02:42 +09001644func TestVndkApexNameRule(t *testing.T) {
1645 ctx, _ := testApex(t, `
1646 apex_vndk {
1647 name: "myapex",
1648 key: "myapex.key",
1649 file_contexts: "myapex",
1650 }
1651 apex_vndk {
1652 name: "myapex_v28",
1653 key: "myapex.key",
1654 file_contexts: "myapex",
1655 vndk_version: "28",
1656 }
1657 apex_key {
1658 name: "myapex.key",
1659 public_key: "testkey.avbpubkey",
1660 private_key: "testkey.pem",
Jooyung Han39edb6c2019-11-06 16:53:07 +09001661 }`+vndkLibrariesTxtFiles("28", "current"))
Jooyung Han90eee022019-10-01 20:02:42 +09001662
1663 assertApexName := func(expected, moduleName string) {
Sundong Ahnabb64432019-10-22 13:58:29 +09001664 bundle := ctx.ModuleForTests(moduleName, "android_common_"+moduleName+"_image").Module().(*apexBundle)
Jooyung Han90eee022019-10-01 20:02:42 +09001665 actual := proptools.String(bundle.properties.Apex_name)
1666 if !reflect.DeepEqual(actual, expected) {
1667 t.Errorf("Got '%v', expected '%v'", actual, expected)
1668 }
1669 }
1670
1671 assertApexName("com.android.vndk.vVER", "myapex")
1672 assertApexName("com.android.vndk.v28", "myapex_v28")
1673}
1674
Jooyung Han344d5432019-08-23 11:17:39 +09001675func TestVndkApexSkipsNativeBridgeSupportedModules(t *testing.T) {
1676 ctx, _ := testApex(t, `
1677 apex_vndk {
1678 name: "myapex",
1679 key: "myapex.key",
1680 file_contexts: "myapex",
1681 }
1682
1683 apex_key {
1684 name: "myapex.key",
1685 public_key: "testkey.avbpubkey",
1686 private_key: "testkey.pem",
1687 }
1688
1689 cc_library {
1690 name: "libvndk",
1691 srcs: ["mylib.cpp"],
1692 vendor_available: true,
1693 native_bridge_supported: true,
1694 host_supported: true,
1695 vndk: {
1696 enabled: true,
1697 },
1698 system_shared_libs: [],
1699 stl: "none",
1700 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09001701 `+vndkLibrariesTxtFiles("current"),
1702 withTargets(map[android.OsType][]android.Target{
1703 android.Android: []android.Target{
1704 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}, NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
1705 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}, NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
1706 {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "silvermont", Abi: []string{"arm64-v8a"}}, NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "arm64", NativeBridgeRelativePath: "x86_64"},
1707 {Os: android.Android, Arch: android.Arch{ArchType: android.X86, ArchVariant: "silvermont", Abi: []string{"armeabi-v7a"}}, NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "arm", NativeBridgeRelativePath: "x86"},
1708 },
1709 }))
Jooyung Han344d5432019-08-23 11:17:39 +09001710
Jooyung Han31c470b2019-10-18 16:26:59 +09001711 ensureExactContents(t, ctx, "myapex", []string{
1712 "lib/libvndk.so",
1713 "lib64/libvndk.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09001714 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09001715 })
Jooyung Han344d5432019-08-23 11:17:39 +09001716}
1717
1718func TestVndkApexDoesntSupportNativeBridgeSupported(t *testing.T) {
1719 testApexError(t, `module "myapex" .*: native_bridge_supported: .* doesn't support native bridge binary`, `
1720 apex_vndk {
1721 name: "myapex",
1722 key: "myapex.key",
1723 file_contexts: "myapex",
1724 native_bridge_supported: true,
1725 }
1726
1727 apex_key {
1728 name: "myapex.key",
1729 public_key: "testkey.avbpubkey",
1730 private_key: "testkey.pem",
1731 }
1732
1733 cc_library {
1734 name: "libvndk",
1735 srcs: ["mylib.cpp"],
1736 vendor_available: true,
1737 native_bridge_supported: true,
1738 host_supported: true,
1739 vndk: {
1740 enabled: true,
1741 },
1742 system_shared_libs: [],
1743 stl: "none",
1744 }
1745 `)
1746}
1747
Jooyung Han31c470b2019-10-18 16:26:59 +09001748func TestVndkApexWithBinder32(t *testing.T) {
Jooyung Han39edb6c2019-11-06 16:53:07 +09001749 ctx, _ := testApex(t, `
Jooyung Han31c470b2019-10-18 16:26:59 +09001750 apex_vndk {
1751 name: "myapex_v27",
1752 key: "myapex.key",
1753 file_contexts: "myapex",
1754 vndk_version: "27",
1755 }
1756
1757 apex_key {
1758 name: "myapex.key",
1759 public_key: "testkey.avbpubkey",
1760 private_key: "testkey.pem",
1761 }
1762
1763 vndk_prebuilt_shared {
1764 name: "libvndk27",
1765 version: "27",
1766 target_arch: "arm",
1767 vendor_available: true,
1768 vndk: {
1769 enabled: true,
1770 },
1771 arch: {
1772 arm: {
1773 srcs: ["libvndk27.so"],
1774 }
1775 },
1776 }
1777
1778 vndk_prebuilt_shared {
1779 name: "libvndk27",
1780 version: "27",
1781 target_arch: "arm",
1782 binder32bit: true,
1783 vendor_available: true,
1784 vndk: {
1785 enabled: true,
1786 },
1787 arch: {
1788 arm: {
1789 srcs: ["libvndk27binder32.so"],
1790 }
1791 },
1792 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09001793 `+vndkLibrariesTxtFiles("27"),
Jooyung Han31c470b2019-10-18 16:26:59 +09001794 withFiles(map[string][]byte{
1795 "libvndk27.so": nil,
1796 "libvndk27binder32.so": nil,
1797 }),
1798 withBinder32bit,
1799 withTargets(map[android.OsType][]android.Target{
1800 android.Android: []android.Target{
1801 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}, NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
1802 },
1803 }),
1804 )
1805
1806 ensureExactContents(t, ctx, "myapex_v27", []string{
1807 "lib/libvndk27binder32.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09001808 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09001809 })
1810}
1811
Jooyung Hane1633032019-08-01 17:41:43 +09001812func TestDependenciesInApexManifest(t *testing.T) {
1813 ctx, _ := testApex(t, `
1814 apex {
1815 name: "myapex_nodep",
1816 key: "myapex.key",
1817 native_shared_libs: ["lib_nodep"],
1818 compile_multilib: "both",
1819 file_contexts: "myapex",
1820 }
1821
1822 apex {
1823 name: "myapex_dep",
1824 key: "myapex.key",
1825 native_shared_libs: ["lib_dep"],
1826 compile_multilib: "both",
1827 file_contexts: "myapex",
1828 }
1829
1830 apex {
1831 name: "myapex_provider",
1832 key: "myapex.key",
1833 native_shared_libs: ["libfoo"],
1834 compile_multilib: "both",
1835 file_contexts: "myapex",
1836 }
1837
1838 apex {
1839 name: "myapex_selfcontained",
1840 key: "myapex.key",
1841 native_shared_libs: ["lib_dep", "libfoo"],
1842 compile_multilib: "both",
1843 file_contexts: "myapex",
1844 }
1845
1846 apex_key {
1847 name: "myapex.key",
1848 public_key: "testkey.avbpubkey",
1849 private_key: "testkey.pem",
1850 }
1851
1852 cc_library {
1853 name: "lib_nodep",
1854 srcs: ["mylib.cpp"],
1855 system_shared_libs: [],
1856 stl: "none",
1857 }
1858
1859 cc_library {
1860 name: "lib_dep",
1861 srcs: ["mylib.cpp"],
1862 shared_libs: ["libfoo"],
1863 system_shared_libs: [],
1864 stl: "none",
1865 }
1866
1867 cc_library {
1868 name: "libfoo",
1869 srcs: ["mytest.cpp"],
1870 stubs: {
1871 versions: ["1"],
1872 },
1873 system_shared_libs: [],
1874 stl: "none",
1875 }
1876 `)
1877
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001878 var apexManifestRule android.TestingBuildParams
Jooyung Hane1633032019-08-01 17:41:43 +09001879 var provideNativeLibs, requireNativeLibs []string
1880
Sundong Ahnabb64432019-10-22 13:58:29 +09001881 apexManifestRule = ctx.ModuleForTests("myapex_nodep", "android_common_myapex_nodep_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001882 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
1883 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09001884 ensureListEmpty(t, provideNativeLibs)
1885 ensureListEmpty(t, requireNativeLibs)
1886
Sundong Ahnabb64432019-10-22 13:58:29 +09001887 apexManifestRule = ctx.ModuleForTests("myapex_dep", "android_common_myapex_dep_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001888 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
1889 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09001890 ensureListEmpty(t, provideNativeLibs)
1891 ensureListContains(t, requireNativeLibs, "libfoo.so")
1892
Sundong Ahnabb64432019-10-22 13:58:29 +09001893 apexManifestRule = ctx.ModuleForTests("myapex_provider", "android_common_myapex_provider_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001894 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
1895 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09001896 ensureListContains(t, provideNativeLibs, "libfoo.so")
1897 ensureListEmpty(t, requireNativeLibs)
1898
Sundong Ahnabb64432019-10-22 13:58:29 +09001899 apexManifestRule = ctx.ModuleForTests("myapex_selfcontained", "android_common_myapex_selfcontained_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001900 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
1901 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09001902 ensureListContains(t, provideNativeLibs, "libfoo.so")
1903 ensureListEmpty(t, requireNativeLibs)
1904}
1905
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001906func TestApexName(t *testing.T) {
1907 ctx, _ := testApex(t, `
1908 apex {
1909 name: "myapex",
1910 key: "myapex.key",
1911 apex_name: "com.android.myapex",
1912 }
1913
1914 apex_key {
1915 name: "myapex.key",
1916 public_key: "testkey.avbpubkey",
1917 private_key: "testkey.pem",
1918 }
1919 `)
1920
Sundong Ahnabb64432019-10-22 13:58:29 +09001921 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001922 apexManifestRule := module.Rule("apexManifestRule")
1923 ensureContains(t, apexManifestRule.Args["opt"], "-v name com.android.myapex")
1924 apexRule := module.Rule("apexRule")
1925 ensureContains(t, apexRule.Args["opt_flags"], "--do_not_check_keyname")
1926}
1927
Alex Light0851b882019-02-07 13:20:53 -08001928func TestNonTestApex(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001929 ctx, _ := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08001930 apex {
1931 name: "myapex",
1932 key: "myapex.key",
1933 native_shared_libs: ["mylib_common"],
1934 }
1935
1936 apex_key {
1937 name: "myapex.key",
1938 public_key: "testkey.avbpubkey",
1939 private_key: "testkey.pem",
1940 }
1941
1942 cc_library {
1943 name: "mylib_common",
1944 srcs: ["mylib.cpp"],
1945 system_shared_libs: [],
1946 stl: "none",
1947 }
1948 `)
1949
Sundong Ahnabb64432019-10-22 13:58:29 +09001950 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Alex Light0851b882019-02-07 13:20:53 -08001951 apexRule := module.Rule("apexRule")
1952 copyCmds := apexRule.Args["copy_commands"]
1953
1954 if apex, ok := module.Module().(*apexBundle); !ok || apex.testApex {
1955 t.Log("Apex was a test apex!")
1956 t.Fail()
1957 }
1958 // Ensure that main rule creates an output
1959 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
1960
1961 // Ensure that apex variant is created for the direct dep
1962 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_core_shared_myapex")
1963
1964 // Ensure that both direct and indirect deps are copied into apex
1965 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
1966
1967 // Ensure that the platform variant ends with _core_shared
1968 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_core_shared")
1969
1970 if !android.InAnyApex("mylib_common") {
1971 t.Log("Found mylib_common not in any apex!")
1972 t.Fail()
1973 }
1974}
1975
1976func TestTestApex(t *testing.T) {
1977 if android.InAnyApex("mylib_common_test") {
1978 t.Fatal("mylib_common_test must not be used in any other tests since this checks that global state is not updated in an illegal way!")
1979 }
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001980 ctx, _ := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08001981 apex_test {
1982 name: "myapex",
1983 key: "myapex.key",
1984 native_shared_libs: ["mylib_common_test"],
1985 }
1986
1987 apex_key {
1988 name: "myapex.key",
1989 public_key: "testkey.avbpubkey",
1990 private_key: "testkey.pem",
1991 }
1992
1993 cc_library {
1994 name: "mylib_common_test",
1995 srcs: ["mylib.cpp"],
1996 system_shared_libs: [],
1997 stl: "none",
1998 }
1999 `)
2000
Sundong Ahnabb64432019-10-22 13:58:29 +09002001 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Alex Light0851b882019-02-07 13:20:53 -08002002 apexRule := module.Rule("apexRule")
2003 copyCmds := apexRule.Args["copy_commands"]
2004
2005 if apex, ok := module.Module().(*apexBundle); !ok || !apex.testApex {
2006 t.Log("Apex was not a test apex!")
2007 t.Fail()
2008 }
2009 // Ensure that main rule creates an output
2010 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
2011
2012 // Ensure that apex variant is created for the direct dep
2013 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_core_shared_myapex")
2014
2015 // Ensure that both direct and indirect deps are copied into apex
2016 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common_test.so")
2017
2018 // Ensure that the platform variant ends with _core_shared
2019 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_core_shared")
2020
2021 if android.InAnyApex("mylib_common_test") {
2022 t.Log("Found mylib_common_test in some apex!")
2023 t.Fail()
2024 }
2025}
2026
Alex Light9670d332019-01-29 18:07:33 -08002027func TestApexWithTarget(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002028 ctx, _ := testApex(t, `
Alex Light9670d332019-01-29 18:07:33 -08002029 apex {
2030 name: "myapex",
2031 key: "myapex.key",
2032 multilib: {
2033 first: {
2034 native_shared_libs: ["mylib_common"],
2035 }
2036 },
2037 target: {
2038 android: {
2039 multilib: {
2040 first: {
2041 native_shared_libs: ["mylib"],
2042 }
2043 }
2044 },
2045 host: {
2046 multilib: {
2047 first: {
2048 native_shared_libs: ["mylib2"],
2049 }
2050 }
2051 }
2052 }
2053 }
2054
2055 apex_key {
2056 name: "myapex.key",
2057 public_key: "testkey.avbpubkey",
2058 private_key: "testkey.pem",
2059 }
2060
2061 cc_library {
2062 name: "mylib",
2063 srcs: ["mylib.cpp"],
2064 system_shared_libs: [],
2065 stl: "none",
2066 }
2067
2068 cc_library {
2069 name: "mylib_common",
2070 srcs: ["mylib.cpp"],
2071 system_shared_libs: [],
2072 stl: "none",
2073 compile_multilib: "first",
2074 }
2075
2076 cc_library {
2077 name: "mylib2",
2078 srcs: ["mylib.cpp"],
2079 system_shared_libs: [],
2080 stl: "none",
2081 compile_multilib: "first",
2082 }
2083 `)
2084
Sundong Ahnabb64432019-10-22 13:58:29 +09002085 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Alex Light9670d332019-01-29 18:07:33 -08002086 copyCmds := apexRule.Args["copy_commands"]
2087
2088 // Ensure that main rule creates an output
2089 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
2090
2091 // Ensure that apex variant is created for the direct dep
2092 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_core_shared_myapex")
2093 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_core_shared_myapex")
2094 ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_core_shared_myapex")
2095
2096 // Ensure that both direct and indirect deps are copied into apex
2097 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
2098 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
2099 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
2100
2101 // Ensure that the platform variant ends with _core_shared
2102 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_core_shared")
2103 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_core_shared")
2104 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_core_shared")
2105}
Jiyong Park04480cf2019-02-06 00:16:29 +09002106
2107func TestApexWithShBinary(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002108 ctx, _ := testApex(t, `
Jiyong Park04480cf2019-02-06 00:16:29 +09002109 apex {
2110 name: "myapex",
2111 key: "myapex.key",
2112 binaries: ["myscript"],
2113 }
2114
2115 apex_key {
2116 name: "myapex.key",
2117 public_key: "testkey.avbpubkey",
2118 private_key: "testkey.pem",
2119 }
2120
2121 sh_binary {
2122 name: "myscript",
2123 src: "mylib.cpp",
2124 filename: "myscript.sh",
2125 sub_dir: "script",
2126 }
2127 `)
2128
Sundong Ahnabb64432019-10-22 13:58:29 +09002129 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park04480cf2019-02-06 00:16:29 +09002130 copyCmds := apexRule.Args["copy_commands"]
2131
2132 ensureContains(t, copyCmds, "image.apex/bin/script/myscript.sh")
2133}
Jiyong Parkd1e293d2019-03-15 02:13:21 +09002134
2135func TestApexInProductPartition(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002136 ctx, _ := testApex(t, `
Jiyong Parkd1e293d2019-03-15 02:13:21 +09002137 apex {
2138 name: "myapex",
2139 key: "myapex.key",
2140 native_shared_libs: ["mylib"],
2141 product_specific: true,
2142 }
2143
2144 apex_key {
2145 name: "myapex.key",
2146 public_key: "testkey.avbpubkey",
2147 private_key: "testkey.pem",
2148 product_specific: true,
2149 }
2150
2151 cc_library {
2152 name: "mylib",
2153 srcs: ["mylib.cpp"],
2154 system_shared_libs: [],
2155 stl: "none",
2156 }
2157 `)
2158
Sundong Ahnabb64432019-10-22 13:58:29 +09002159 apex := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossff6c33d2019-10-02 16:01:35 -07002160 expected := buildDir + "/target/product/test_device/product/apex"
2161 actual := apex.installDir.String()
Jiyong Parkd1e293d2019-03-15 02:13:21 +09002162 if actual != expected {
2163 t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
2164 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09002165}
Jiyong Park67882562019-03-21 01:11:21 +09002166
2167func TestApexKeyFromOtherModule(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002168 ctx, _ := testApex(t, `
Jiyong Park67882562019-03-21 01:11:21 +09002169 apex_key {
2170 name: "myapex.key",
2171 public_key: ":my.avbpubkey",
2172 private_key: ":my.pem",
2173 product_specific: true,
2174 }
2175
2176 filegroup {
2177 name: "my.avbpubkey",
2178 srcs: ["testkey2.avbpubkey"],
2179 }
2180
2181 filegroup {
2182 name: "my.pem",
2183 srcs: ["testkey2.pem"],
2184 }
2185 `)
2186
2187 apex_key := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
2188 expected_pubkey := "testkey2.avbpubkey"
2189 actual_pubkey := apex_key.public_key_file.String()
2190 if actual_pubkey != expected_pubkey {
2191 t.Errorf("wrong public key path. expected %q. actual %q", expected_pubkey, actual_pubkey)
2192 }
2193 expected_privkey := "testkey2.pem"
2194 actual_privkey := apex_key.private_key_file.String()
2195 if actual_privkey != expected_privkey {
2196 t.Errorf("wrong private key path. expected %q. actual %q", expected_privkey, actual_privkey)
2197 }
2198}
Jaewoong Jung939ebd52019-03-26 15:07:36 -07002199
2200func TestPrebuilt(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002201 ctx, _ := testApex(t, `
Jaewoong Jung939ebd52019-03-26 15:07:36 -07002202 prebuilt_apex {
2203 name: "myapex",
Jiyong Parkc95714e2019-03-29 14:23:10 +09002204 arch: {
2205 arm64: {
2206 src: "myapex-arm64.apex",
2207 },
2208 arm: {
2209 src: "myapex-arm.apex",
2210 },
2211 },
Jaewoong Jung939ebd52019-03-26 15:07:36 -07002212 }
2213 `)
2214
2215 prebuilt := ctx.ModuleForTests("myapex", "android_common").Module().(*Prebuilt)
2216
Jiyong Parkc95714e2019-03-29 14:23:10 +09002217 expectedInput := "myapex-arm64.apex"
2218 if prebuilt.inputApex.String() != expectedInput {
2219 t.Errorf("inputApex invalid. expected: %q, actual: %q", expectedInput, prebuilt.inputApex.String())
2220 }
Jaewoong Jung939ebd52019-03-26 15:07:36 -07002221}
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01002222
2223func TestPrebuiltFilenameOverride(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002224 ctx, _ := testApex(t, `
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01002225 prebuilt_apex {
2226 name: "myapex",
2227 src: "myapex-arm.apex",
2228 filename: "notmyapex.apex",
2229 }
2230 `)
2231
2232 p := ctx.ModuleForTests("myapex", "android_common").Module().(*Prebuilt)
2233
2234 expected := "notmyapex.apex"
2235 if p.installFilename != expected {
2236 t.Errorf("installFilename invalid. expected: %q, actual: %q", expected, p.installFilename)
2237 }
2238}
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07002239
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002240func TestPrebuiltOverrides(t *testing.T) {
2241 ctx, config := testApex(t, `
2242 prebuilt_apex {
2243 name: "myapex.prebuilt",
2244 src: "myapex-arm.apex",
2245 overrides: [
2246 "myapex",
2247 ],
2248 }
2249 `)
2250
2251 p := ctx.ModuleForTests("myapex.prebuilt", "android_common").Module().(*Prebuilt)
2252
2253 expected := []string{"myapex"}
2254 actual := android.AndroidMkEntriesForTest(t, config, "", p).EntryMap["LOCAL_OVERRIDES_PACKAGES"]
2255 if !reflect.DeepEqual(actual, expected) {
2256 t.Errorf("Incorrect LOCAL_OVERRIDES_PACKAGES value '%s', expected '%s'", actual, expected)
2257 }
2258}
2259
Roland Levillain630846d2019-06-26 12:48:34 +01002260func TestApexWithTests(t *testing.T) {
Roland Levillainf89cd092019-07-29 16:22:59 +01002261 ctx, config := testApex(t, `
Roland Levillain630846d2019-06-26 12:48:34 +01002262 apex_test {
2263 name: "myapex",
2264 key: "myapex.key",
2265 tests: [
2266 "mytest",
Roland Levillain9b5fde92019-06-28 15:41:19 +01002267 "mytests",
Roland Levillain630846d2019-06-26 12:48:34 +01002268 ],
2269 }
2270
2271 apex_key {
2272 name: "myapex.key",
2273 public_key: "testkey.avbpubkey",
2274 private_key: "testkey.pem",
2275 }
2276
2277 cc_test {
2278 name: "mytest",
2279 gtest: false,
2280 srcs: ["mytest.cpp"],
2281 relative_install_path: "test",
2282 system_shared_libs: [],
2283 static_executable: true,
2284 stl: "none",
2285 }
Roland Levillain9b5fde92019-06-28 15:41:19 +01002286
2287 cc_test {
2288 name: "mytests",
2289 gtest: false,
2290 srcs: [
2291 "mytest1.cpp",
2292 "mytest2.cpp",
2293 "mytest3.cpp",
2294 ],
2295 test_per_src: true,
2296 relative_install_path: "test",
2297 system_shared_libs: [],
2298 static_executable: true,
2299 stl: "none",
2300 }
Roland Levillain630846d2019-06-26 12:48:34 +01002301 `)
2302
Sundong Ahnabb64432019-10-22 13:58:29 +09002303 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Roland Levillain630846d2019-06-26 12:48:34 +01002304 copyCmds := apexRule.Args["copy_commands"]
2305
2306 // Ensure that test dep is copied into apex.
2307 ensureContains(t, copyCmds, "image.apex/bin/test/mytest")
Roland Levillain9b5fde92019-06-28 15:41:19 +01002308
2309 // Ensure that test deps built with `test_per_src` are copied into apex.
2310 ensureContains(t, copyCmds, "image.apex/bin/test/mytest1")
2311 ensureContains(t, copyCmds, "image.apex/bin/test/mytest2")
2312 ensureContains(t, copyCmds, "image.apex/bin/test/mytest3")
Roland Levillainf89cd092019-07-29 16:22:59 +01002313
2314 // Ensure the module is correctly translated.
Sundong Ahnabb64432019-10-22 13:58:29 +09002315 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Roland Levillainf89cd092019-07-29 16:22:59 +01002316 data := android.AndroidMkDataForTest(t, config, "", apexBundle)
2317 name := apexBundle.BaseModuleName()
2318 prefix := "TARGET_"
2319 var builder strings.Builder
2320 data.Custom(&builder, name, prefix, "", data)
2321 androidMk := builder.String()
Jooyung Han31c470b2019-10-18 16:26:59 +09002322 ensureContains(t, androidMk, "LOCAL_MODULE := mytest.myapex\n")
2323 ensureContains(t, androidMk, "LOCAL_MODULE := mytest1.myapex\n")
2324 ensureContains(t, androidMk, "LOCAL_MODULE := mytest2.myapex\n")
2325 ensureContains(t, androidMk, "LOCAL_MODULE := mytest3.myapex\n")
2326 ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.json.myapex\n")
2327 ensureContains(t, androidMk, "LOCAL_MODULE := apex_pubkey.myapex\n")
Roland Levillainf89cd092019-07-29 16:22:59 +01002328 ensureContains(t, androidMk, "LOCAL_MODULE := myapex\n")
Roland Levillain630846d2019-06-26 12:48:34 +01002329}
2330
Jooyung Han5c998b92019-06-27 11:30:33 +09002331func TestApexUsesOtherApex(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002332 ctx, _ := testApex(t, `
Jooyung Han5c998b92019-06-27 11:30:33 +09002333 apex {
2334 name: "myapex",
2335 key: "myapex.key",
2336 native_shared_libs: ["mylib"],
2337 uses: ["commonapex"],
2338 }
2339
2340 apex {
2341 name: "commonapex",
2342 key: "myapex.key",
2343 native_shared_libs: ["libcommon"],
2344 provide_cpp_shared_libs: true,
2345 }
2346
2347 apex_key {
2348 name: "myapex.key",
2349 public_key: "testkey.avbpubkey",
2350 private_key: "testkey.pem",
2351 }
2352
2353 cc_library {
2354 name: "mylib",
2355 srcs: ["mylib.cpp"],
2356 shared_libs: ["libcommon"],
2357 system_shared_libs: [],
2358 stl: "none",
2359 }
2360
2361 cc_library {
2362 name: "libcommon",
2363 srcs: ["mylib_common.cpp"],
2364 system_shared_libs: [],
2365 stl: "none",
2366 }
2367 `)
2368
Sundong Ahnabb64432019-10-22 13:58:29 +09002369 module1 := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Han5c998b92019-06-27 11:30:33 +09002370 apexRule1 := module1.Rule("apexRule")
2371 copyCmds1 := apexRule1.Args["copy_commands"]
2372
Sundong Ahnabb64432019-10-22 13:58:29 +09002373 module2 := ctx.ModuleForTests("commonapex", "android_common_commonapex_image")
Jooyung Han5c998b92019-06-27 11:30:33 +09002374 apexRule2 := module2.Rule("apexRule")
2375 copyCmds2 := apexRule2.Args["copy_commands"]
2376
2377 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_core_shared_myapex")
2378 ensureListContains(t, ctx.ModuleVariantsForTests("libcommon"), "android_arm64_armv8-a_core_shared_commonapex")
2379 ensureContains(t, copyCmds1, "image.apex/lib64/mylib.so")
2380 ensureContains(t, copyCmds2, "image.apex/lib64/libcommon.so")
2381 ensureNotContains(t, copyCmds1, "image.apex/lib64/libcommon.so")
2382}
2383
2384func TestApexUsesFailsIfNotProvided(t *testing.T) {
2385 testApexError(t, `uses: "commonapex" does not provide native_shared_libs`, `
2386 apex {
2387 name: "myapex",
2388 key: "myapex.key",
2389 uses: ["commonapex"],
2390 }
2391
2392 apex {
2393 name: "commonapex",
2394 key: "myapex.key",
2395 }
2396
2397 apex_key {
2398 name: "myapex.key",
2399 public_key: "testkey.avbpubkey",
2400 private_key: "testkey.pem",
2401 }
2402 `)
2403 testApexError(t, `uses: "commonapex" is not a provider`, `
2404 apex {
2405 name: "myapex",
2406 key: "myapex.key",
2407 uses: ["commonapex"],
2408 }
2409
2410 cc_library {
2411 name: "commonapex",
2412 system_shared_libs: [],
2413 stl: "none",
2414 }
2415
2416 apex_key {
2417 name: "myapex.key",
2418 public_key: "testkey.avbpubkey",
2419 private_key: "testkey.pem",
2420 }
2421 `)
2422}
2423
2424func TestApexUsesFailsIfUseVenderMismatch(t *testing.T) {
2425 testApexError(t, `use_vendor: "commonapex" has different value of use_vendor`, `
2426 apex {
2427 name: "myapex",
2428 key: "myapex.key",
2429 use_vendor: true,
2430 uses: ["commonapex"],
2431 }
2432
2433 apex {
2434 name: "commonapex",
2435 key: "myapex.key",
2436 provide_cpp_shared_libs: true,
2437 }
2438
2439 apex_key {
2440 name: "myapex.key",
2441 public_key: "testkey.avbpubkey",
2442 private_key: "testkey.pem",
2443 }
Jooyung Handc782442019-11-01 03:14:38 +09002444 `, func(fs map[string][]byte, config android.Config) {
2445 setUseVendorWhitelistForTest(config, []string{"myapex"})
2446 })
Jooyung Han5c998b92019-06-27 11:30:33 +09002447}
2448
Jooyung Hand48f3c32019-08-23 11:18:57 +09002449func TestErrorsIfDepsAreNotEnabled(t *testing.T) {
2450 testApexError(t, `module "myapex" .* depends on disabled module "libfoo"`, `
2451 apex {
2452 name: "myapex",
2453 key: "myapex.key",
2454 native_shared_libs: ["libfoo"],
2455 }
2456
2457 apex_key {
2458 name: "myapex.key",
2459 public_key: "testkey.avbpubkey",
2460 private_key: "testkey.pem",
2461 }
2462
2463 cc_library {
2464 name: "libfoo",
2465 stl: "none",
2466 system_shared_libs: [],
2467 enabled: false,
2468 }
2469 `)
2470 testApexError(t, `module "myapex" .* depends on disabled module "myjar"`, `
2471 apex {
2472 name: "myapex",
2473 key: "myapex.key",
2474 java_libs: ["myjar"],
2475 }
2476
2477 apex_key {
2478 name: "myapex.key",
2479 public_key: "testkey.avbpubkey",
2480 private_key: "testkey.pem",
2481 }
2482
2483 java_library {
2484 name: "myjar",
2485 srcs: ["foo/bar/MyClass.java"],
2486 sdk_version: "none",
2487 system_modules: "none",
2488 compile_dex: true,
2489 enabled: false,
2490 }
2491 `)
2492}
2493
Sundong Ahne1f05aa2019-08-27 13:55:42 +09002494func TestApexWithApps(t *testing.T) {
2495 ctx, _ := testApex(t, `
2496 apex {
2497 name: "myapex",
2498 key: "myapex.key",
2499 apps: [
2500 "AppFoo",
Jiyong Parkf7487312019-10-17 12:54:30 +09002501 "AppFooPriv",
Sundong Ahne1f05aa2019-08-27 13:55:42 +09002502 ],
2503 }
2504
2505 apex_key {
2506 name: "myapex.key",
2507 public_key: "testkey.avbpubkey",
2508 private_key: "testkey.pem",
2509 }
2510
2511 android_app {
2512 name: "AppFoo",
2513 srcs: ["foo/bar/MyClass.java"],
2514 sdk_version: "none",
2515 system_modules: "none",
Jiyong Park8be103b2019-11-08 15:53:48 +09002516 jni_libs: ["libjni"],
Sundong Ahne1f05aa2019-08-27 13:55:42 +09002517 }
Jiyong Parkf7487312019-10-17 12:54:30 +09002518
2519 android_app {
2520 name: "AppFooPriv",
2521 srcs: ["foo/bar/MyClass.java"],
2522 sdk_version: "none",
2523 system_modules: "none",
2524 privileged: true,
2525 }
Jiyong Park8be103b2019-11-08 15:53:48 +09002526
2527 cc_library_shared {
2528 name: "libjni",
2529 srcs: ["mylib.cpp"],
2530 stl: "none",
2531 system_shared_libs: [],
2532 }
Sundong Ahne1f05aa2019-08-27 13:55:42 +09002533 `)
2534
Sundong Ahnabb64432019-10-22 13:58:29 +09002535 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Sundong Ahne1f05aa2019-08-27 13:55:42 +09002536 apexRule := module.Rule("apexRule")
2537 copyCmds := apexRule.Args["copy_commands"]
2538
2539 ensureContains(t, copyCmds, "image.apex/app/AppFoo/AppFoo.apk")
Jiyong Parkf7487312019-10-17 12:54:30 +09002540 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPriv/AppFooPriv.apk")
Jiyong Park52cd06f2019-11-11 10:14:32 +09002541
2542 // JNI libraries are embedded inside APK
2543 appZipRule := ctx.ModuleForTests("AppFoo", "android_common_myapex").Rule("zip")
2544 libjniOutput := ctx.ModuleForTests("libjni", "android_arm64_armv8-a_core_shared_myapex").Module().(*cc.Module).OutputFile()
2545 ensureListContains(t, appZipRule.Implicits.Strings(), libjniOutput.String())
2546 // ... uncompressed
2547 if args := appZipRule.Args["jarArgs"]; !strings.Contains(args, "-L 0") {
2548 t.Errorf("jni lib is not uncompressed for AppFoo")
2549 }
2550 // ... and not directly inside the APEX
2551 ensureNotContains(t, copyCmds, "image.apex/lib64/libjni.so")
Dario Frenicde2a032019-10-27 00:29:22 +01002552}
Sundong Ahne1f05aa2019-08-27 13:55:42 +09002553
Dario Frenicde2a032019-10-27 00:29:22 +01002554func TestApexWithAppImports(t *testing.T) {
2555 ctx, _ := testApex(t, `
2556 apex {
2557 name: "myapex",
2558 key: "myapex.key",
2559 apps: [
2560 "AppFooPrebuilt",
2561 "AppFooPrivPrebuilt",
2562 ],
2563 }
2564
2565 apex_key {
2566 name: "myapex.key",
2567 public_key: "testkey.avbpubkey",
2568 private_key: "testkey.pem",
2569 }
2570
2571 android_app_import {
2572 name: "AppFooPrebuilt",
2573 apk: "PrebuiltAppFoo.apk",
2574 presigned: true,
2575 dex_preopt: {
2576 enabled: false,
2577 },
2578 }
2579
2580 android_app_import {
2581 name: "AppFooPrivPrebuilt",
2582 apk: "PrebuiltAppFooPriv.apk",
2583 privileged: true,
2584 presigned: true,
2585 dex_preopt: {
2586 enabled: false,
2587 },
2588 }
2589 `)
2590
Sundong Ahnabb64432019-10-22 13:58:29 +09002591 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Dario Frenicde2a032019-10-27 00:29:22 +01002592 apexRule := module.Rule("apexRule")
2593 copyCmds := apexRule.Args["copy_commands"]
2594
2595 ensureContains(t, copyCmds, "image.apex/app/AppFooPrebuilt/AppFooPrebuilt.apk")
2596 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPrivPrebuilt/AppFooPrivPrebuilt.apk")
Sundong Ahne1f05aa2019-08-27 13:55:42 +09002597}
2598
Jiyong Park127b40b2019-09-30 16:04:35 +09002599func TestApexAvailable(t *testing.T) {
2600 // libfoo is not available to myapex, but only to otherapex
2601 testApexError(t, "requires \"libfoo\" that is not available for the APEX", `
2602 apex {
2603 name: "myapex",
2604 key: "myapex.key",
2605 native_shared_libs: ["libfoo"],
2606 }
2607
2608 apex_key {
2609 name: "myapex.key",
2610 public_key: "testkey.avbpubkey",
2611 private_key: "testkey.pem",
2612 }
2613
2614 apex {
2615 name: "otherapex",
2616 key: "otherapex.key",
2617 native_shared_libs: ["libfoo"],
2618 }
2619
2620 apex_key {
2621 name: "otherapex.key",
2622 public_key: "testkey.avbpubkey",
2623 private_key: "testkey.pem",
2624 }
2625
2626 cc_library {
2627 name: "libfoo",
2628 stl: "none",
2629 system_shared_libs: [],
2630 apex_available: ["otherapex"],
2631 }`)
2632
2633 // libbar is an indirect dep
2634 testApexError(t, "requires \"libbar\" that is not available for the APEX", `
2635 apex {
2636 name: "myapex",
2637 key: "myapex.key",
2638 native_shared_libs: ["libfoo"],
2639 }
2640
2641 apex_key {
2642 name: "myapex.key",
2643 public_key: "testkey.avbpubkey",
2644 private_key: "testkey.pem",
2645 }
2646
2647 apex {
2648 name: "otherapex",
2649 key: "otherapex.key",
2650 native_shared_libs: ["libfoo"],
2651 }
2652
2653 apex_key {
2654 name: "otherapex.key",
2655 public_key: "testkey.avbpubkey",
2656 private_key: "testkey.pem",
2657 }
2658
2659 cc_library {
2660 name: "libfoo",
2661 stl: "none",
2662 shared_libs: ["libbar"],
2663 system_shared_libs: [],
2664 apex_available: ["myapex", "otherapex"],
2665 }
2666
2667 cc_library {
2668 name: "libbar",
2669 stl: "none",
2670 system_shared_libs: [],
2671 apex_available: ["otherapex"],
2672 }`)
2673
2674 testApexError(t, "\"otherapex\" is not a valid module name", `
2675 apex {
2676 name: "myapex",
2677 key: "myapex.key",
2678 native_shared_libs: ["libfoo"],
2679 }
2680
2681 apex_key {
2682 name: "myapex.key",
2683 public_key: "testkey.avbpubkey",
2684 private_key: "testkey.pem",
2685 }
2686
2687 cc_library {
2688 name: "libfoo",
2689 stl: "none",
2690 system_shared_libs: [],
2691 apex_available: ["otherapex"],
2692 }`)
2693
2694 ctx, _ := testApex(t, `
2695 apex {
2696 name: "myapex",
2697 key: "myapex.key",
2698 native_shared_libs: ["libfoo", "libbar"],
2699 }
2700
2701 apex_key {
2702 name: "myapex.key",
2703 public_key: "testkey.avbpubkey",
2704 private_key: "testkey.pem",
2705 }
2706
2707 cc_library {
2708 name: "libfoo",
2709 stl: "none",
2710 system_shared_libs: [],
2711 apex_available: ["myapex"],
2712 }
2713
2714 cc_library {
2715 name: "libbar",
2716 stl: "none",
2717 system_shared_libs: [],
2718 apex_available: ["//apex_available:anyapex"],
2719 }`)
2720
2721 // check that libfoo and libbar are created only for myapex, but not for the platform
2722 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo"), "android_arm64_armv8-a_core_shared_myapex")
2723 ensureListNotContains(t, ctx.ModuleVariantsForTests("libfoo"), "android_arm64_armv8-a_core_shared")
2724 ensureListContains(t, ctx.ModuleVariantsForTests("libbar"), "android_arm64_armv8-a_core_shared_myapex")
2725 ensureListNotContains(t, ctx.ModuleVariantsForTests("libbar"), "android_arm64_armv8-a_core_shared")
2726
2727 ctx, _ = testApex(t, `
2728 apex {
2729 name: "myapex",
2730 key: "myapex.key",
2731 }
2732
2733 apex_key {
2734 name: "myapex.key",
2735 public_key: "testkey.avbpubkey",
2736 private_key: "testkey.pem",
2737 }
2738
2739 cc_library {
2740 name: "libfoo",
2741 stl: "none",
2742 system_shared_libs: [],
2743 apex_available: ["//apex_available:platform"],
2744 }`)
2745
2746 // check that libfoo is created only for the platform
2747 ensureListNotContains(t, ctx.ModuleVariantsForTests("libfoo"), "android_arm64_armv8-a_core_shared_myapex")
2748 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo"), "android_arm64_armv8-a_core_shared")
Jiyong Parka90ca002019-10-07 15:47:24 +09002749
2750 ctx, _ = testApex(t, `
2751 apex {
2752 name: "myapex",
2753 key: "myapex.key",
2754 native_shared_libs: ["libfoo"],
2755 }
2756
2757 apex_key {
2758 name: "myapex.key",
2759 public_key: "testkey.avbpubkey",
2760 private_key: "testkey.pem",
2761 }
2762
2763 cc_library {
2764 name: "libfoo",
2765 stl: "none",
2766 system_shared_libs: [],
2767 apex_available: ["myapex"],
2768 static: {
2769 apex_available: ["//apex_available:platform"],
2770 },
2771 }`)
2772
2773 // shared variant of libfoo is only available to myapex
2774 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo"), "android_arm64_armv8-a_core_shared_myapex")
2775 ensureListNotContains(t, ctx.ModuleVariantsForTests("libfoo"), "android_arm64_armv8-a_core_shared")
2776 // but the static variant is available to both myapex and the platform
2777 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo"), "android_arm64_armv8-a_core_static_myapex")
2778 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo"), "android_arm64_armv8-a_core_static")
Jiyong Park127b40b2019-09-30 16:04:35 +09002779}
2780
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07002781func TestMain(m *testing.M) {
2782 run := func() int {
2783 setUp()
2784 defer tearDown()
2785
2786 return m.Run()
2787 }
2788
2789 os.Exit(run())
2790}