blob: f4b8c9f65e3c737afa038c0fc52e4d379a94dd0d [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Paul Duffin1a393322020-11-18 16:36:47 +000018 "fmt"
Colin Cross72bb3632017-07-13 16:23:21 -070019 "io/ioutil"
20 "os"
21 "path/filepath"
Colin Crossc0806172019-06-14 18:51:47 -070022 "reflect"
Paul Duffindaaa3322020-05-26 18:13:57 +010023 "regexp"
Nan Zhang61eaedb2017-11-02 13:28:15 -070024 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070025 "strings"
26 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070027
Paul Duffind6ceb862021-03-04 23:02:31 +000028 "android/soong/genrule"
Jeongik Cha28df2572019-11-11 10:46:36 +090029 "github.com/google/blueprint/proptools"
30
Colin Crossa4f08812018-10-02 22:03:40 -070031 "android/soong/android"
32 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080033 "android/soong/dexpreopt"
Liz Kammerdd849a82020-06-12 16:38:45 -070034 "android/soong/python"
Colin Cross72bb3632017-07-13 16:23:21 -070035)
36
37var buildDir string
38
39func setUp() {
40 var err error
41 buildDir, err = ioutil.TempDir("", "soong_java_test")
42 if err != nil {
43 panic(err)
44 }
45}
46
47func tearDown() {
48 os.RemoveAll(buildDir)
49}
50
Paul Duffin95bdab42021-03-08 21:48:46 +000051// Factory to use to create fixtures for tests in this package.
52var javaFixtureFactory = android.NewFixtureFactory(
53 &buildDir,
54 genrule.PrepareForTestWithGenRuleBuildComponents,
55 // Get the CC build components but not default modules.
56 cc.PrepareForTestWithCcBuildComponents,
57 // Include all the default java modules.
58 PrepareForTestWithJavaDefaultModules,
59 android.FixtureRegisterWithContext(func(ctx android.RegistrationContext) {
60 ctx.RegisterModuleType("java_plugin", PluginFactory)
61 ctx.RegisterModuleType("python_binary_host", python.PythonBinaryHostFactory)
62
63 ctx.PreDepsMutators(python.RegisterPythonPreDepsMutators)
64 ctx.RegisterPreSingletonType("overlay", OverlaySingletonFactory)
65 ctx.RegisterPreSingletonType("sdk_versions", sdkPreSingletonFactory)
66 }),
Paul Duffin95bdab42021-03-08 21:48:46 +000067 dexpreopt.PrepareForTestWithDexpreopt,
68)
69
Colin Cross72bb3632017-07-13 16:23:21 -070070func TestMain(m *testing.M) {
71 run := func() int {
72 setUp()
73 defer tearDown()
74
75 return m.Run()
76 }
77
78 os.Exit(run())
79}
Colin Cross527012a2017-11-30 22:56:16 -080080
Paul Duffin95bdab42021-03-08 21:48:46 +000081// testConfig is a legacy way of creating a test Config for testing java modules.
82//
83// See testJava for an explanation as to how to stop using this deprecated method.
84//
85// deprecated
Colin Cross98be1bb2019-12-13 20:41:13 -080086func testConfig(env map[string]string, bp string, fs map[string][]byte) android.Config {
Paul Duffin9f045242021-01-21 15:05:11 +000087 return TestConfig(buildDir, env, bp, fs)
Colin Cross1369cdb2017-09-29 17:58:17 -070088}
89
Paul Duffin95bdab42021-03-08 21:48:46 +000090// testContext is a legacy way of creating a TestContext for testing java modules.
91//
92// See testJava for an explanation as to how to stop using this deprecated method.
93//
94// deprecated
Colin Crossae8600b2020-10-29 17:09:13 -070095func testContext(config android.Config) *android.TestContext {
Colin Cross72bb3632017-07-13 16:23:21 -070096
Colin Crossae8600b2020-10-29 17:09:13 -070097 ctx := android.NewTestArchContext(config)
Paul Duffinc059c8c2021-01-20 17:13:52 +000098 RegisterRequiredBuildComponentsForTest(ctx)
Colin Cross4b49b762019-11-22 15:25:03 -080099 ctx.RegisterModuleType("java_plugin", PluginFactory)
Colin Cross4b49b762019-11-22 15:25:03 -0800100 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
Liz Kammerdd849a82020-06-12 16:38:45 -0700101 ctx.RegisterModuleType("python_binary_host", python.PythonBinaryHostFactory)
Colin Cross89536d42017-07-07 14:35:50 -0700102 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Paul Duffin44f1d842020-06-26 20:17:02 +0100103 ctx.PreArchMutators(android.RegisterComponentsMutator)
Paul Duffina48f7582019-12-19 11:25:19 +0000104
Liz Kammerdd849a82020-06-12 16:38:45 -0700105 ctx.PreDepsMutators(python.RegisterPythonPreDepsMutators)
Jaewoong Jungb639a6a2019-05-10 15:16:29 -0700106 ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
Paul Duffineafc16b2021-02-24 01:43:18 +0000107 ctx.RegisterPreSingletonType("overlay", OverlaySingletonFactory)
108 ctx.RegisterPreSingletonType("sdk_versions", sdkPreSingletonFactory)
Colin Crossa4f08812018-10-02 22:03:40 -0700109
Paul Duffin021f4e52020-07-30 16:04:17 +0100110 android.RegisterPrebuiltMutators(ctx)
111
Paul Duffind6ceb862021-03-04 23:02:31 +0000112 genrule.RegisterGenruleBuildComponents(ctx)
113
Colin Crossa4f08812018-10-02 22:03:40 -0700114 // Register module types and mutators from cc needed for JNI testing
Paul Duffin77980a82019-12-19 16:01:36 +0000115 cc.RegisterRequiredBuildComponentsForTest(ctx)
Colin Crossa4f08812018-10-02 22:03:40 -0700116
Jaewoong Jungc779cd42020-10-06 18:56:10 -0700117 ctx.PostDepsMutators(func(ctx android.RegisterMutatorsContext) {
118 ctx.TopDown("propagate_rro_enforcement", propagateRROEnforcementMutator).Parallel()
119 })
120
Colin Cross527012a2017-11-30 22:56:16 -0800121 return ctx
122}
123
Paul Duffin95bdab42021-03-08 21:48:46 +0000124// run is a legacy way of running tests of java modules.
125//
126// See testJava for an explanation as to how to stop using this deprecated method.
127//
128// deprecated
Colin Cross527012a2017-11-30 22:56:16 -0800129func run(t *testing.T, ctx *android.TestContext, config android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800130 t.Helper()
Colin Crossc28bb0b2019-02-25 14:20:47 -0800131
Colin Cross98be1bb2019-12-13 20:41:13 -0800132 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000133 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Colin Crossc28bb0b2019-02-25 14:20:47 -0800134
Colin Crossae8600b2020-10-29 17:09:13 -0700135 ctx.Register()
Paul Duffinbaccf7e2019-06-11 11:58:30 +0100136 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
Logan Chien42039712018-03-12 16:29:17 +0800137 android.FailIfErrored(t, errs)
Colin Cross72bb3632017-07-13 16:23:21 -0700138 _, errs = ctx.PrepareBuildActions(config)
Logan Chien42039712018-03-12 16:29:17 +0800139 android.FailIfErrored(t, errs)
Colin Cross527012a2017-11-30 22:56:16 -0800140}
141
Paul Duffin95bdab42021-03-08 21:48:46 +0000142// testJavaError is a legacy way of running tests of java modules that expect errors.
143//
144// See testJava for an explanation as to how to stop using this deprecated method.
145//
146// deprecated
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900147func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) {
Jeongik Cha538c0d02019-07-11 15:54:27 +0900148 t.Helper()
Paul Duffin6bac49c2021-03-12 21:28:15 +0000149 result := javaFixtureFactory.
150 Extend(dexpreopt.PrepareForTestWithDexpreopt).
151 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)).
152 RunTestWithBp(t, bp)
153 return result.TestContext, result.Config
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900154}
155
Paul Duffin95bdab42021-03-08 21:48:46 +0000156// testJavaErrorWithConfig is a legacy way of running tests of java modules that expect errors.
157//
158// See testJava for an explanation as to how to stop using this deprecated method.
159//
160// deprecated
Colin Cross98be1bb2019-12-13 20:41:13 -0800161func testJavaErrorWithConfig(t *testing.T, pattern string, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900162 t.Helper()
Paul Duffin95bdab42021-03-08 21:48:46 +0000163 // This must be done on the supplied config and not as part of the fixture because any changes to
164 // the fixture's config will be ignored when RunTestWithConfig replaces it.
Colin Cross98be1bb2019-12-13 20:41:13 -0800165 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000166 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Paul Duffin95bdab42021-03-08 21:48:46 +0000167 result := javaFixtureFactory.
168 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)).
169 RunTestWithConfig(t, config)
170 return result.TestContext, result.Config
Paul Duffinec0fe172021-02-25 15:34:13 +0000171}
172
Paul Duffin95bdab42021-03-08 21:48:46 +0000173// runWithErrors is a legacy way of running tests of java modules that expect errors.
174//
175// See testJava for an explanation as to how to stop using this deprecated method.
176//
177// deprecated
Paul Duffinec0fe172021-02-25 15:34:13 +0000178func runWithErrors(t *testing.T, ctx *android.TestContext, config android.Config, pattern string) {
Colin Crossae8600b2020-10-29 17:09:13 -0700179 ctx.Register()
Jeongik Cha538c0d02019-07-11 15:54:27 +0900180 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
181 if len(errs) > 0 {
182 android.FailIfNoMatchingErrors(t, pattern, errs)
Paul Duffinec0fe172021-02-25 15:34:13 +0000183 return
Jeongik Cha538c0d02019-07-11 15:54:27 +0900184 }
185 _, errs = ctx.PrepareBuildActions(config)
186 if len(errs) > 0 {
187 android.FailIfNoMatchingErrors(t, pattern, errs)
Paul Duffinec0fe172021-02-25 15:34:13 +0000188 return
Jeongik Cha538c0d02019-07-11 15:54:27 +0900189 }
190
191 t.Fatalf("missing expected error %q (0 errors are returned)", pattern)
Paul Duffinec0fe172021-02-25 15:34:13 +0000192 return
Jeongik Cha538c0d02019-07-11 15:54:27 +0900193}
194
Paul Duffin95bdab42021-03-08 21:48:46 +0000195// testJavaWithFS runs tests using the javaFixtureFactory
196//
197// See testJava for an explanation as to how to stop using this deprecated method.
198//
199// deprecated
200func testJavaWithFS(t *testing.T, bp string, fs android.MockFS) (*android.TestContext, android.Config) {
Colin Cross238c1f32020-06-07 16:58:18 -0700201 t.Helper()
Paul Duffin95bdab42021-03-08 21:48:46 +0000202 result := javaFixtureFactory.Extend(fs.AddToFixture()).RunTestWithBp(t, bp)
203 return result.TestContext, result.Config
Colin Cross238c1f32020-06-07 16:58:18 -0700204}
205
Paul Duffin95bdab42021-03-08 21:48:46 +0000206// testJava runs tests using the javaFixtureFactory
207//
208// Do not add any new usages of this, instead use the javaFixtureFactory directly as it makes it
209// much easier to customize the test behavior.
210//
211// If it is necessary to customize the behavior of an existing test that uses this then please first
212// convert the test to using javaFixtureFactory first and then in a following change add the
213// appropriate fixture preparers. Keeping the conversion change separate makes it easy to verify
214// that it did not change the test behavior unexpectedly.
215//
216// deprecated
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700217func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800218 t.Helper()
Paul Duffin95bdab42021-03-08 21:48:46 +0000219 result := javaFixtureFactory.RunTestWithBp(t, bp)
220 return result.TestContext, result.Config
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900221}
222
Paul Duffin95bdab42021-03-08 21:48:46 +0000223// testJavaWithConfig runs tests using the javaFixtureFactory
224//
225// See testJava for an explanation as to how to stop using this deprecated method.
226//
227// deprecated
Colin Cross98be1bb2019-12-13 20:41:13 -0800228func testJavaWithConfig(t *testing.T, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900229 t.Helper()
Paul Duffin95bdab42021-03-08 21:48:46 +0000230 result := javaFixtureFactory.RunTestWithConfig(t, config)
231 return result.TestContext, result.Config
Colin Cross72bb3632017-07-13 16:23:21 -0700232}
233
Colin Cross2acdae82017-09-15 19:44:24 -0700234func moduleToPath(name string) string {
235 switch {
236 case name == `""`:
237 return name
Colin Crossfc3674a2017-09-18 17:41:52 -0700238 case strings.HasSuffix(name, ".jar"):
239 return name
Nan Zhanged19fc32017-10-19 13:06:22 -0700240 default:
241 return filepath.Join(buildDir, ".intermediates", name, "android_common", "turbine-combined", name+".jar")
Colin Cross2acdae82017-09-15 19:44:24 -0700242 }
243}
244
Paul Duffin95bdab42021-03-08 21:48:46 +0000245// defaultModuleToPath constructs a path to the turbine generate jar for a default test module that
246// is defined in PrepareForIntegrationTestWithJava
247func defaultModuleToPath(name string) string {
Paul Duffin76101fa2021-03-13 09:55:25 +0000248 switch {
249 case name == `""`:
250 return name
251 case strings.HasSuffix(name, ".jar"):
252 return name
253 default:
254 return filepath.Join(buildDir, ".intermediates", defaultJavaDir, name, "android_common", "turbine-combined", name+".jar")
255 }
Paul Duffin95bdab42021-03-08 21:48:46 +0000256}
257
Jeongik Chae403e9e2019-12-07 00:16:24 +0900258func TestJavaLinkType(t *testing.T) {
259 testJava(t, `
260 java_library {
261 name: "foo",
262 srcs: ["a.java"],
263 libs: ["bar"],
264 static_libs: ["baz"],
265 }
266
267 java_library {
268 name: "bar",
269 sdk_version: "current",
270 srcs: ["b.java"],
271 }
272
273 java_library {
274 name: "baz",
275 sdk_version: "system_current",
276 srcs: ["c.java"],
277 }
278 `)
279
Steven Moreland00298982020-11-17 21:44:36 +0000280 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900281 java_library {
282 name: "foo",
283 srcs: ["a.java"],
284 libs: ["bar"],
285 sdk_version: "current",
286 static_libs: ["baz"],
287 }
288
289 java_library {
290 name: "bar",
291 sdk_version: "current",
292 srcs: ["b.java"],
293 }
294
295 java_library {
296 name: "baz",
297 sdk_version: "system_current",
298 srcs: ["c.java"],
299 }
300 `)
301
302 testJava(t, `
303 java_library {
304 name: "foo",
305 srcs: ["a.java"],
306 libs: ["bar"],
307 sdk_version: "system_current",
308 static_libs: ["baz"],
309 }
310
311 java_library {
312 name: "bar",
313 sdk_version: "current",
314 srcs: ["b.java"],
315 }
316
317 java_library {
318 name: "baz",
319 sdk_version: "system_current",
320 srcs: ["c.java"],
321 }
322 `)
323
Steven Moreland00298982020-11-17 21:44:36 +0000324 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900325 java_library {
326 name: "foo",
327 srcs: ["a.java"],
328 libs: ["bar"],
329 sdk_version: "system_current",
330 static_libs: ["baz"],
331 }
332
333 java_library {
334 name: "bar",
335 sdk_version: "current",
336 srcs: ["b.java"],
337 }
338
339 java_library {
340 name: "baz",
341 srcs: ["c.java"],
342 }
343 `)
344}
345
Colin Cross72bb3632017-07-13 16:23:21 -0700346func TestSimple(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700347 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700348 java_library {
349 name: "foo",
350 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700351 libs: ["bar"],
352 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700353 }
354
355 java_library {
356 name: "bar",
357 srcs: ["b.java"],
358 }
359
360 java_library {
361 name: "baz",
362 srcs: ["c.java"],
363 }
Colin Crossd5934c82017-10-02 13:55:26 -0700364 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700365
Colin Cross4c428df2017-09-15 17:36:05 -0700366 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700367 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700368
369 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
370 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
371 }
372
Colin Cross1ee23172017-10-18 14:44:18 -0700373 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Nan Zhanged19fc32017-10-19 13:06:22 -0700374 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
375 bazTurbine := filepath.Join(buildDir, ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700376
Paul Duffin22b77cd2021-03-12 19:15:01 +0000377 android.AssertStringDoesContain(t, "foo classpath", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700378
Paul Duffin22b77cd2021-03-12 19:15:01 +0000379 android.AssertStringDoesContain(t, "foo classpath", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700380
381 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
382 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700383 }
384}
385
Artur Satayev9cf46692019-11-26 18:08:34 +0000386func TestExportedPlugins(t *testing.T) {
387 type Result struct {
Colin Crossc9fe10f2020-11-19 18:06:03 -0800388 library string
389 processors string
390 disableTurbine bool
Artur Satayev9cf46692019-11-26 18:08:34 +0000391 }
392 var tests = []struct {
393 name string
394 extra string
395 results []Result
396 }{
397 {
398 name: "Exported plugin is not a direct plugin",
399 extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`,
400 results: []Result{{library: "exports", processors: "-proc:none"}},
401 },
402 {
403 name: "Exports plugin to dependee",
404 extra: `
405 java_library{name: "exports", exported_plugins: ["plugin"]}
406 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
407 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
408 `,
409 results: []Result{
410 {library: "foo", processors: "-processor com.android.TestPlugin"},
411 {library: "bar", processors: "-processor com.android.TestPlugin"},
412 },
413 },
414 {
415 name: "Exports plugin to android_library",
416 extra: `
417 java_library{name: "exports", exported_plugins: ["plugin"]}
418 android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
419 android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
420 `,
421 results: []Result{
422 {library: "foo", processors: "-processor com.android.TestPlugin"},
423 {library: "bar", processors: "-processor com.android.TestPlugin"},
424 },
425 },
426 {
427 name: "Exports plugin is not propagated via transitive deps",
428 extra: `
429 java_library{name: "exports", exported_plugins: ["plugin"]}
430 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
431 java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]}
432 `,
433 results: []Result{
434 {library: "foo", processors: "-processor com.android.TestPlugin"},
435 {library: "bar", processors: "-proc:none"},
436 },
437 },
438 {
439 name: "Exports plugin appends to plugins",
440 extra: `
441 java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"}
442 java_library{name: "exports", exported_plugins: ["plugin"]}
443 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]}
444 `,
445 results: []Result{
446 {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"},
447 },
448 },
Colin Crossc9fe10f2020-11-19 18:06:03 -0800449 {
450 name: "Exports plugin to with generates_api to dependee",
451 extra: `
452 java_library{name: "exports", exported_plugins: ["plugin_generates_api"]}
453 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
454 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
455 `,
456 results: []Result{
457 {library: "foo", processors: "-processor com.android.TestPlugin", disableTurbine: true},
458 {library: "bar", processors: "-processor com.android.TestPlugin", disableTurbine: true},
459 },
460 },
Artur Satayev9cf46692019-11-26 18:08:34 +0000461 }
462
463 for _, test := range tests {
464 t.Run(test.name, func(t *testing.T) {
465 ctx, _ := testJava(t, `
466 java_plugin {
467 name: "plugin",
468 processor_class: "com.android.TestPlugin",
469 }
Colin Crossc9fe10f2020-11-19 18:06:03 -0800470 java_plugin {
471 name: "plugin_generates_api",
472 generates_api: true,
473 processor_class: "com.android.TestPlugin",
474 }
Artur Satayev9cf46692019-11-26 18:08:34 +0000475 `+test.extra)
476
477 for _, want := range test.results {
478 javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac")
479 if javac.Args["processor"] != want.processors {
480 t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"])
481 }
Colin Crossc9fe10f2020-11-19 18:06:03 -0800482 turbine := ctx.ModuleForTests(want.library, "android_common").MaybeRule("turbine")
483 disableTurbine := turbine.BuildParams.Rule == nil
484 if disableTurbine != want.disableTurbine {
485 t.Errorf("For library %v, expected disableTurbine %v, found %v", want.library, want.disableTurbine, disableTurbine)
486 }
Artur Satayev9cf46692019-11-26 18:08:34 +0000487 }
488 })
489 }
490}
491
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900492func TestSdkVersionByPartition(t *testing.T) {
493 testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900494 java_library {
495 name: "foo",
496 srcs: ["a.java"],
497 vendor: true,
498 }
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900499 `)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900500
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900501 testJava(t, `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900502 java_library {
503 name: "bar",
504 srcs: ["b.java"],
505 }
506 `)
507
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900508 for _, enforce := range []bool{true, false} {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900509 bp := `
510 java_library {
511 name: "foo",
512 srcs: ["a.java"],
513 product_specific: true,
514 }
515 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800516
517 config := testConfig(nil, bp, nil)
518 config.TestProductVariables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900519 if enforce {
Colin Cross98be1bb2019-12-13 20:41:13 -0800520 testJavaErrorWithConfig(t, "sdk_version must have a value when the module is located at vendor or product", config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900521 } else {
Colin Cross98be1bb2019-12-13 20:41:13 -0800522 testJavaWithConfig(t, config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900523 }
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900524 }
525}
526
Colin Crossd5934c82017-10-02 13:55:26 -0700527func TestArchSpecific(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700528 ctx, _ := testJava(t, `
Colin Crossd5934c82017-10-02 13:55:26 -0700529 java_library {
530 name: "foo",
531 srcs: ["a.java"],
532 target: {
533 android: {
534 srcs: ["b.java"],
535 },
536 },
537 }
538 `)
539
540 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
541 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
542 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
543 }
544}
545
Colin Cross6b4a32d2017-12-05 13:42:45 -0800546func TestBinary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700547 ctx, _ := testJava(t, `
Colin Cross6b4a32d2017-12-05 13:42:45 -0800548 java_library_host {
549 name: "foo",
550 srcs: ["a.java"],
551 }
552
553 java_binary_host {
554 name: "bar",
555 srcs: ["b.java"],
556 static_libs: ["foo"],
Colin Cross89226d92020-10-09 19:00:54 -0700557 jni_libs: ["libjni"],
558 }
559
560 cc_library_shared {
561 name: "libjni",
562 host_supported: true,
563 device_supported: false,
564 stl: "none",
Colin Cross6b4a32d2017-12-05 13:42:45 -0800565 }
566 `)
567
568 buildOS := android.BuildOs.String()
569
570 bar := ctx.ModuleForTests("bar", buildOS+"_common")
571 barJar := bar.Output("bar.jar").Output.String()
572 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
573 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
574
Colin Cross89226d92020-10-09 19:00:54 -0700575 libjni := ctx.ModuleForTests("libjni", buildOS+"_x86_64_shared")
576 libjniSO := libjni.Rule("Cp").Output.String()
577
Colin Cross6b4a32d2017-12-05 13:42:45 -0800578 // Test that the install binary wrapper depends on the installed jar file
Colin Crossc179ea62020-10-09 10:54:15 -0700579 if g, w := barWrapperDeps, barJar; !android.InList(w, g) {
580 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800581 }
Colin Cross89226d92020-10-09 19:00:54 -0700582
583 // Test that the install binary wrapper depends on the installed JNI libraries
584 if g, w := barWrapperDeps, libjniSO; !android.InList(w, g) {
585 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800586 }
Alex Humesky2070e322020-06-09 20:23:08 -0400587}
Colin Cross6b4a32d2017-12-05 13:42:45 -0800588
Alex Humesky2070e322020-06-09 20:23:08 -0400589func TestHostBinaryNoJavaDebugInfoOverride(t *testing.T) {
590 bp := `
591 java_library {
592 name: "target_library",
593 srcs: ["a.java"],
594 }
595
596 java_binary_host {
597 name: "host_binary",
598 srcs: ["b.java"],
599 }
600 `
601 config := testConfig(nil, bp, nil)
602 config.TestProductVariables.MinimizeJavaDebugInfo = proptools.BoolPtr(true)
603
604 ctx, _ := testJavaWithConfig(t, config)
605
Liz Kammer7941b302020-07-28 13:27:34 -0700606 // first, check that the -g flag is added to target modules
Alex Humesky2070e322020-06-09 20:23:08 -0400607 targetLibrary := ctx.ModuleForTests("target_library", "android_common")
608 targetJavaFlags := targetLibrary.Module().VariablesForTests()["javacFlags"]
609 if !strings.Contains(targetJavaFlags, "-g:source,lines") {
610 t.Errorf("target library javac flags %v should contain "+
611 "-g:source,lines override with MinimizeJavaDebugInfo", targetJavaFlags)
612 }
613
614 // check that -g is not overridden for host modules
615 buildOS := android.BuildOs.String()
616 hostBinary := ctx.ModuleForTests("host_binary", buildOS+"_common")
617 hostJavaFlags := hostBinary.Module().VariablesForTests()["javacFlags"]
618 if strings.Contains(hostJavaFlags, "-g:source,lines") {
619 t.Errorf("java_binary_host javac flags %v should not have "+
620 "-g:source,lines override with MinimizeJavaDebugInfo", hostJavaFlags)
621 }
Colin Cross6b4a32d2017-12-05 13:42:45 -0800622}
623
Colin Cross72bb3632017-07-13 16:23:21 -0700624func TestPrebuilts(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700625 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700626 java_library {
627 name: "foo",
Paul Duffin91547182019-11-12 19:39:36 +0000628 srcs: ["a.java", ":stubs-source"],
Paul Duffinfcfd7912020-01-31 17:54:30 +0000629 libs: ["bar", "sdklib"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700630 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700631 }
632
Colin Cross74d73e22017-08-02 11:05:49 -0700633 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700634 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700635 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700636 }
637
Colin Cross74d73e22017-08-02 11:05:49 -0700638 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700639 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700640 jars: ["b.jar"],
Liz Kammerd6c31d22020-08-05 15:40:41 -0700641 sdk_version: "current",
642 compile_dex: true,
Colin Cross72bb3632017-07-13 16:23:21 -0700643 }
Colin Cross42be7612019-02-21 18:12:14 -0800644
645 dex_import {
646 name: "qux",
647 jars: ["b.jar"],
648 }
Colin Cross79c7c262019-04-17 11:11:46 -0700649
650 java_sdk_library_import {
Paul Duffin56d44902020-01-31 13:36:25 +0000651 name: "sdklib",
652 public: {
653 jars: ["c.jar"],
654 },
655 }
656
Paul Duffin91547182019-11-12 19:39:36 +0000657 prebuilt_stubs_sources {
658 name: "stubs-source",
Paul Duffin9b478b02019-12-10 13:41:51 +0000659 srcs: ["stubs/sources"],
Paul Duffin91547182019-11-12 19:39:36 +0000660 }
Paul Duffin1b82e6a2019-12-03 18:06:47 +0000661
662 java_test_import {
663 name: "test",
664 jars: ["a.jar"],
665 test_suites: ["cts"],
666 test_config: "AndroidTest.xml",
667 }
Colin Cross72bb3632017-07-13 16:23:21 -0700668 `)
669
Paul Duffin9b478b02019-12-10 13:41:51 +0000670 fooModule := ctx.ModuleForTests("foo", "android_common")
671 javac := fooModule.Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700672 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Liz Kammerd6c31d22020-08-05 15:40:41 -0700673 barModule := ctx.ModuleForTests("bar", "android_common")
674 barJar := barModule.Rule("combineJar").Output
675 bazModule := ctx.ModuleForTests("baz", "android_common")
676 bazJar := bazModule.Rule("combineJar").Output
Colin Cross79c7c262019-04-17 11:11:46 -0700677 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700678
Paul Duffin9b478b02019-12-10 13:41:51 +0000679 fooLibrary := fooModule.Module().(*Library)
680 assertDeepEquals(t, "foo java sources incorrect",
681 []string{"a.java"}, fooLibrary.compiledJavaSrcs.Strings())
Paul Duffin91547182019-11-12 19:39:36 +0000682
Paul Duffin9b478b02019-12-10 13:41:51 +0000683 assertDeepEquals(t, "foo java source jars incorrect",
684 []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"},
685 android.NormalizePathsForTesting(fooLibrary.compiledSrcJars))
Paul Duffin91547182019-11-12 19:39:36 +0000686
Colin Cross37f6d792018-07-12 12:28:41 -0700687 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
688 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700689 }
690
Liz Kammerd6c31d22020-08-05 15:40:41 -0700691 barDexJar := barModule.Module().(*Import).DexJarBuildPath()
692 if barDexJar != nil {
693 t.Errorf("bar dex jar build path expected to be nil, got %q", barDexJar)
694 }
695
Colin Cross79c7c262019-04-17 11:11:46 -0700696 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
697 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
698 }
699
Colin Cross37f6d792018-07-12 12:28:41 -0700700 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
701 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700702 }
Colin Cross42be7612019-02-21 18:12:14 -0800703
Liz Kammerd6c31d22020-08-05 15:40:41 -0700704 bazDexJar := bazModule.Module().(*Import).DexJarBuildPath().String()
705 expectedDexJar := buildDir + "/.intermediates/baz/android_common/dex/baz.jar"
706 if bazDexJar != expectedDexJar {
707 t.Errorf("baz dex jar build path expected %q, got %q", expectedDexJar, bazDexJar)
708 }
709
Colin Cross42be7612019-02-21 18:12:14 -0800710 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Colin Cross72bb3632017-07-13 16:23:21 -0700711}
712
Paul Duffin9b478b02019-12-10 13:41:51 +0000713func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) {
714 if !reflect.DeepEqual(expected, actual) {
715 t.Errorf("%s: expected %q, found %q", message, expected, actual)
716 }
717}
718
Paul Duffin1a393322020-11-18 16:36:47 +0000719func TestPrebuiltStubsSources(t *testing.T) {
720 test := func(t *testing.T, sourcesPath string, expectedInputs []string) {
721 ctx, _ := testJavaWithFS(t, fmt.Sprintf(`
722prebuilt_stubs_sources {
723 name: "stubs-source",
724 srcs: ["%s"],
725}`, sourcesPath), map[string][]byte{
726 "stubs/sources/pkg/A.java": nil,
727 "stubs/sources/pkg/B.java": nil,
728 })
729
730 zipSrc := ctx.ModuleForTests("stubs-source", "android_common").Rule("zip_src")
731 if expected, actual := expectedInputs, zipSrc.Inputs.Strings(); !reflect.DeepEqual(expected, actual) {
732 t.Errorf("mismatch of inputs to soong_zip: expected %q, actual %q", expected, actual)
733 }
734 }
735
736 t.Run("empty/missing directory", func(t *testing.T) {
737 test(t, "empty-directory", []string{})
738 })
739
740 t.Run("non-empty set of sources", func(t *testing.T) {
741 test(t, "stubs/sources", []string{
742 "stubs/sources/pkg/A.java",
743 "stubs/sources/pkg/B.java",
744 })
745 })
746}
747
Paul Duffin56d44902020-01-31 13:36:25 +0000748func TestJavaSdkLibraryImport(t *testing.T) {
Paul Duffin22b77cd2021-03-12 19:15:01 +0000749 result := javaFixtureFactory.RunTestWithBp(t, `
Paul Duffin56d44902020-01-31 13:36:25 +0000750 java_library {
751 name: "foo",
752 srcs: ["a.java"],
753 libs: ["sdklib"],
754 sdk_version: "current",
755 }
756
757 java_library {
758 name: "foo.system",
759 srcs: ["a.java"],
760 libs: ["sdklib"],
761 sdk_version: "system_current",
762 }
763
764 java_library {
765 name: "foo.test",
766 srcs: ["a.java"],
767 libs: ["sdklib"],
768 sdk_version: "test_current",
769 }
770
771 java_sdk_library_import {
772 name: "sdklib",
773 public: {
774 jars: ["a.jar"],
775 },
776 system: {
777 jars: ["b.jar"],
778 },
779 test: {
780 jars: ["c.jar"],
Paul Duffin0f8faff2020-05-20 16:18:00 +0100781 stub_srcs: ["c.java"],
Paul Duffin56d44902020-01-31 13:36:25 +0000782 },
783 }
784 `)
785
786 for _, scope := range []string{"", ".system", ".test"} {
Paul Duffin22b77cd2021-03-12 19:15:01 +0000787 fooModule := result.ModuleForTests("foo"+scope, "android_common")
Paul Duffin56d44902020-01-31 13:36:25 +0000788 javac := fooModule.Rule("javac")
789
Paul Duffin22b77cd2021-03-12 19:15:01 +0000790 sdklibStubsJar := result.ModuleForTests("sdklib.stubs"+scope, "android_common").Rule("combineJar").Output
791 android.AssertStringDoesContain(t, "foo classpath", javac.Args["classpath"], sdklibStubsJar.String())
Paul Duffin56d44902020-01-31 13:36:25 +0000792 }
Paul Duffinca8d9a52020-06-26 22:20:25 +0100793
Paul Duffin22b77cd2021-03-12 19:15:01 +0000794 CheckModuleDependencies(t, result.TestContext, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100795 `prebuilt_sdklib.stubs`,
796 `prebuilt_sdklib.stubs.source.test`,
797 `prebuilt_sdklib.stubs.system`,
798 `prebuilt_sdklib.stubs.test`,
799 })
800}
801
802func TestJavaSdkLibraryImport_WithSource(t *testing.T) {
Paul Duffin163043d2021-03-12 19:18:49 +0000803 result := javaFixtureFactory.Extend(
804 PrepareForTestWithJavaSdkLibraryFiles,
805 FixtureWithLastReleaseApis("sdklib"),
806 ).RunTestWithBp(t, `
Paul Duffinca8d9a52020-06-26 22:20:25 +0100807 java_sdk_library {
808 name: "sdklib",
809 srcs: ["a.java"],
810 sdk_version: "none",
811 system_modules: "none",
812 public: {
813 enabled: true,
814 },
815 }
816
817 java_sdk_library_import {
818 name: "sdklib",
819 public: {
820 jars: ["a.jar"],
821 },
822 }
823 `)
824
Paul Duffin22b77cd2021-03-12 19:15:01 +0000825 CheckModuleDependencies(t, result.TestContext, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100826 `dex2oatd`,
827 `prebuilt_sdklib`,
828 `sdklib.impl`,
829 `sdklib.stubs`,
830 `sdklib.stubs.source`,
831 `sdklib.xml`,
832 })
833
Paul Duffin22b77cd2021-03-12 19:15:01 +0000834 CheckModuleDependencies(t, result.TestContext, "prebuilt_sdklib", "android_common", []string{
Paul Duffin44f1d842020-06-26 20:17:02 +0100835 `prebuilt_sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100836 `sdklib.impl`,
837 // This should be prebuilt_sdklib.stubs but is set to sdklib.stubs because the
838 // dependency is added after prebuilts may have been renamed and so has to use
839 // the renamed name.
Paul Duffinca8d9a52020-06-26 22:20:25 +0100840 `sdklib.xml`,
841 })
842}
843
844func TestJavaSdkLibraryImport_Preferred(t *testing.T) {
Paul Duffin163043d2021-03-12 19:18:49 +0000845 result := javaFixtureFactory.Extend(
846 PrepareForTestWithJavaSdkLibraryFiles,
847 FixtureWithLastReleaseApis("sdklib"),
848 ).RunTestWithBp(t, `
Paul Duffinca8d9a52020-06-26 22:20:25 +0100849 java_sdk_library {
850 name: "sdklib",
851 srcs: ["a.java"],
852 sdk_version: "none",
853 system_modules: "none",
854 public: {
855 enabled: true,
856 },
857 }
858
859 java_sdk_library_import {
860 name: "sdklib",
861 prefer: true,
862 public: {
863 jars: ["a.jar"],
864 },
865 }
866 `)
867
Paul Duffin22b77cd2021-03-12 19:15:01 +0000868 CheckModuleDependencies(t, result.TestContext, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100869 `dex2oatd`,
870 `prebuilt_sdklib`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100871 `sdklib.impl`,
Paul Duffin80342d72020-06-26 22:08:43 +0100872 `sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100873 `sdklib.stubs.source`,
874 `sdklib.xml`,
875 })
876
Paul Duffin22b77cd2021-03-12 19:15:01 +0000877 CheckModuleDependencies(t, result.TestContext, "prebuilt_sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100878 `prebuilt_sdklib.stubs`,
879 `sdklib.impl`,
880 `sdklib.xml`,
881 })
Paul Duffin56d44902020-01-31 13:36:25 +0000882}
883
JaeMan Parkff715562020-10-19 17:25:58 +0900884func TestJavaSdkLibraryEnforce(t *testing.T) {
885 partitionToBpOption := func(partition string) string {
886 switch partition {
887 case "system":
888 return ""
889 case "vendor":
890 return "soc_specific: true,"
891 case "product":
892 return "product_specific: true,"
893 default:
894 panic("Invalid partition group name: " + partition)
895 }
896 }
897
898 type testConfigInfo struct {
899 libraryType string
900 fromPartition string
901 toPartition string
902 enforceVendorInterface bool
903 enforceProductInterface bool
904 enforceJavaSdkLibraryCheck bool
905 allowList []string
906 }
907
Paul Duffin05f72de2021-03-12 21:28:51 +0000908 createPreparer := func(info testConfigInfo) android.FixturePreparer {
JaeMan Parkff715562020-10-19 17:25:58 +0900909 bpFileTemplate := `
910 java_library {
911 name: "foo",
912 srcs: ["foo.java"],
913 libs: ["bar"],
914 sdk_version: "current",
915 %s
916 }
917
918 %s {
919 name: "bar",
920 srcs: ["bar.java"],
921 sdk_version: "current",
922 %s
923 }
924 `
925
926 bpFile := fmt.Sprintf(bpFileTemplate,
927 partitionToBpOption(info.fromPartition),
928 info.libraryType,
929 partitionToBpOption(info.toPartition))
930
Paul Duffin05f72de2021-03-12 21:28:51 +0000931 return android.GroupFixturePreparers(
Paul Duffin163043d2021-03-12 19:18:49 +0000932 PrepareForTestWithJavaSdkLibraryFiles,
933 FixtureWithLastReleaseApis("bar"),
Paul Duffin05f72de2021-03-12 21:28:51 +0000934 android.FixtureWithRootAndroidBp(bpFile),
935 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
936 variables.EnforceProductPartitionInterface = proptools.BoolPtr(info.enforceProductInterface)
937 if info.enforceVendorInterface {
938 variables.DeviceVndkVersion = proptools.StringPtr("current")
939 }
940 variables.EnforceInterPartitionJavaSdkLibrary = proptools.BoolPtr(info.enforceJavaSdkLibraryCheck)
941 variables.InterPartitionJavaLibraryAllowList = info.allowList
942 }),
943 )
JaeMan Parkff715562020-10-19 17:25:58 +0900944 }
945
Paul Duffinaa6caa72021-03-13 16:50:15 +0000946 runTest := func(t *testing.T, info testConfigInfo, expectedErrorPattern string) {
947 t.Run(fmt.Sprintf("%#v", info), func(t *testing.T) {
Paul Duffin05f72de2021-03-12 21:28:51 +0000948 errorHandler := android.FixtureExpectsNoErrors
949 if expectedErrorPattern != "" {
950 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(expectedErrorPattern)
Paul Duffinaa6caa72021-03-13 16:50:15 +0000951 }
Paul Duffin05f72de2021-03-12 21:28:51 +0000952 javaFixtureFactory.ExtendWithErrorHandler(errorHandler).RunTest(t, createPreparer(info))
Paul Duffinaa6caa72021-03-13 16:50:15 +0000953 })
954 }
955
JaeMan Parkff715562020-10-19 17:25:58 +0900956 errorMessage := "is not allowed across the partitions"
957
Paul Duffinaa6caa72021-03-13 16:50:15 +0000958 runTest(t, testConfigInfo{
JaeMan Park90e75352021-01-14 11:56:56 +0900959 libraryType: "java_library",
960 fromPartition: "product",
961 toPartition: "system",
962 enforceVendorInterface: true,
963 enforceProductInterface: true,
964 enforceJavaSdkLibraryCheck: false,
Paul Duffinaa6caa72021-03-13 16:50:15 +0000965 }, "")
JaeMan Parkff715562020-10-19 17:25:58 +0900966
Paul Duffinaa6caa72021-03-13 16:50:15 +0000967 runTest(t, testConfigInfo{
JaeMan Park90e75352021-01-14 11:56:56 +0900968 libraryType: "java_library",
969 fromPartition: "product",
970 toPartition: "system",
971 enforceVendorInterface: true,
972 enforceProductInterface: false,
973 enforceJavaSdkLibraryCheck: true,
Paul Duffinaa6caa72021-03-13 16:50:15 +0000974 }, "")
JaeMan Parkff715562020-10-19 17:25:58 +0900975
Paul Duffinaa6caa72021-03-13 16:50:15 +0000976 runTest(t, testConfigInfo{
JaeMan Park90e75352021-01-14 11:56:56 +0900977 libraryType: "java_library",
978 fromPartition: "product",
979 toPartition: "system",
980 enforceVendorInterface: true,
981 enforceProductInterface: true,
982 enforceJavaSdkLibraryCheck: true,
Paul Duffinaa6caa72021-03-13 16:50:15 +0000983 }, errorMessage)
JaeMan Parkff715562020-10-19 17:25:58 +0900984
Paul Duffinaa6caa72021-03-13 16:50:15 +0000985 runTest(t, testConfigInfo{
JaeMan Park90e75352021-01-14 11:56:56 +0900986 libraryType: "java_library",
987 fromPartition: "vendor",
988 toPartition: "system",
989 enforceVendorInterface: true,
990 enforceProductInterface: true,
991 enforceJavaSdkLibraryCheck: true,
Paul Duffinaa6caa72021-03-13 16:50:15 +0000992 }, errorMessage)
JaeMan Parkff715562020-10-19 17:25:58 +0900993
Paul Duffinaa6caa72021-03-13 16:50:15 +0000994 runTest(t, testConfigInfo{
JaeMan Parkff715562020-10-19 17:25:58 +0900995 libraryType: "java_library",
996 fromPartition: "vendor",
997 toPartition: "system",
998 enforceVendorInterface: true,
999 enforceProductInterface: true,
1000 enforceJavaSdkLibraryCheck: true,
1001 allowList: []string{"bar"},
Paul Duffinaa6caa72021-03-13 16:50:15 +00001002 }, "")
JaeMan Parkff715562020-10-19 17:25:58 +09001003
Paul Duffinaa6caa72021-03-13 16:50:15 +00001004 runTest(t, testConfigInfo{
JaeMan Parkff715562020-10-19 17:25:58 +09001005 libraryType: "java_library",
1006 fromPartition: "vendor",
JaeMan Park90e75352021-01-14 11:56:56 +09001007 toPartition: "product",
1008 enforceVendorInterface: true,
1009 enforceProductInterface: true,
1010 enforceJavaSdkLibraryCheck: true,
Paul Duffinaa6caa72021-03-13 16:50:15 +00001011 }, errorMessage)
JaeMan Park90e75352021-01-14 11:56:56 +09001012
Paul Duffinaa6caa72021-03-13 16:50:15 +00001013 runTest(t, testConfigInfo{
JaeMan Park90e75352021-01-14 11:56:56 +09001014 libraryType: "java_sdk_library",
1015 fromPartition: "product",
JaeMan Parkff715562020-10-19 17:25:58 +09001016 toPartition: "system",
1017 enforceVendorInterface: true,
1018 enforceProductInterface: true,
1019 enforceJavaSdkLibraryCheck: true,
Paul Duffinaa6caa72021-03-13 16:50:15 +00001020 }, "")
JaeMan Park90e75352021-01-14 11:56:56 +09001021
Paul Duffinaa6caa72021-03-13 16:50:15 +00001022 runTest(t, testConfigInfo{
JaeMan Park90e75352021-01-14 11:56:56 +09001023 libraryType: "java_sdk_library",
1024 fromPartition: "vendor",
1025 toPartition: "system",
1026 enforceVendorInterface: true,
1027 enforceProductInterface: true,
1028 enforceJavaSdkLibraryCheck: true,
Paul Duffinaa6caa72021-03-13 16:50:15 +00001029 }, "")
JaeMan Park90e75352021-01-14 11:56:56 +09001030
Paul Duffinaa6caa72021-03-13 16:50:15 +00001031 runTest(t, testConfigInfo{
JaeMan Park90e75352021-01-14 11:56:56 +09001032 libraryType: "java_sdk_library",
1033 fromPartition: "vendor",
1034 toPartition: "product",
1035 enforceVendorInterface: true,
1036 enforceProductInterface: true,
1037 enforceJavaSdkLibraryCheck: true,
Paul Duffinaa6caa72021-03-13 16:50:15 +00001038 }, "")
JaeMan Parkff715562020-10-19 17:25:58 +09001039}
1040
Colin Cross89536d42017-07-07 14:35:50 -07001041func TestDefaults(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001042 ctx, _ := testJava(t, `
Colin Cross89536d42017-07-07 14:35:50 -07001043 java_defaults {
1044 name: "defaults",
1045 srcs: ["a.java"],
1046 libs: ["bar"],
1047 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -07001048 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -07001049 }
1050
1051 java_library {
1052 name: "foo",
1053 defaults: ["defaults"],
1054 }
1055
1056 java_library {
1057 name: "bar",
1058 srcs: ["b.java"],
1059 }
1060
1061 java_library {
1062 name: "baz",
1063 srcs: ["c.java"],
1064 }
Sasha Smundak2057f822019-04-16 17:16:58 -07001065
1066 android_test {
1067 name: "atestOptimize",
1068 defaults: ["defaults"],
1069 optimize: {enabled: true},
1070 }
1071
1072 android_test {
1073 name: "atestNoOptimize",
1074 defaults: ["defaults"],
1075 }
1076
1077 android_test {
1078 name: "atestDefault",
1079 srcs: ["a.java"],
1080 }
Colin Cross89536d42017-07-07 14:35:50 -07001081 `)
1082
Colin Cross4c428df2017-09-15 17:36:05 -07001083 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -07001084 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -07001085
1086 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
1087 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
1088 }
1089
Nan Zhanged19fc32017-10-19 13:06:22 -07001090 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
1091 if !strings.Contains(javac.Args["classpath"], barTurbine) {
1092 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -07001093 }
1094
Colin Cross1ee23172017-10-18 14:44:18 -07001095 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -07001096 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
1097 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -07001098 }
Sasha Smundak2057f822019-04-16 17:16:58 -07001099
1100 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
1101 if atestOptimize.Output == nil {
1102 t.Errorf("atestOptimize should optimize APK")
1103 }
1104
1105 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
1106 if atestNoOptimize.Output == nil {
1107 t.Errorf("atestNoOptimize should not optimize APK")
1108 }
1109
1110 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("r8")
1111 if atestDefault.Output == nil {
1112 t.Errorf("atestDefault should optimize APK")
1113 }
Colin Cross89536d42017-07-07 14:35:50 -07001114}
1115
Colin Cross0f37af02017-09-27 17:42:05 -07001116func TestResources(t *testing.T) {
1117 var table = []struct {
1118 name string
1119 prop string
1120 extra string
1121 args string
1122 }{
1123 {
Colin Crossaf9c55b2017-10-03 14:50:08 -07001124 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -07001125 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -08001126 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -07001127 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -07001128 },
1129 {
1130 // Test that a module with java_resources includes the files
1131 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -07001132 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
1133 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -07001134 },
1135 {
1136 // Test that a module with a filegroup in java_resources includes the files with the
1137 // path prefix
1138 name: "resource filegroup",
1139 prop: `java_resources: [":foo-res"]`,
1140 extra: `
1141 filegroup {
1142 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -08001143 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -07001144 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -07001145 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -07001146 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -07001147 },
1148 {
Colin Cross0ead1d72018-04-10 13:07:42 -07001149 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
1150 name: "wildcard dirs",
1151 prop: `java_resource_dirs: ["java-res/*"]`,
1152 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
1153 },
1154 {
1155 // Test that a module exclude_java_resource_dirs excludes the files
1156 name: "wildcard dirs",
1157 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
1158 args: "-C java-res/a -f java-res/a/a",
1159 },
Colin Crosscedd4762018-09-13 11:26:19 -07001160 {
1161 // Test wildcards in java_resources
1162 name: "wildcard files",
1163 prop: `java_resources: ["java-res/**/*"]`,
1164 args: "-C . -f java-res/a/a -f java-res/b/b",
1165 },
1166 {
1167 // Test exclude_java_resources with java_resources
1168 name: "wildcard files with exclude",
1169 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
1170 args: "-C . -f java-res/a/a",
1171 },
1172 {
1173 // Test exclude_java_resources with java_resource_dirs
1174 name: "resource dirs with exclude files",
1175 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
1176 args: "-C java-res -f java-res/a/a",
1177 },
1178 {
1179 // Test exclude_java_resource_dirs with java_resource_dirs
1180 name: "resource dirs with exclude files",
1181 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
1182 args: "-C java-res -f java-res/a/a -f java-res/b/b",
1183 },
Colin Cross0f37af02017-09-27 17:42:05 -07001184 }
1185
1186 for _, test := range table {
1187 t.Run(test.name, func(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001188 ctx, _ := testJavaWithFS(t, `
Colin Cross0f37af02017-09-27 17:42:05 -07001189 java_library {
1190 name: "foo",
1191 srcs: [
1192 "a.java",
1193 "b.java",
1194 "c.java",
1195 ],
1196 `+test.prop+`,
1197 }
Colin Cross238c1f32020-06-07 16:58:18 -07001198 `+test.extra,
1199 map[string][]byte{
1200 "java-res/a/a": nil,
1201 "java-res/b/b": nil,
1202 "java-res2/a": nil,
1203 },
1204 )
Colin Cross0f37af02017-09-27 17:42:05 -07001205
Colin Cross331a1212018-08-15 20:40:52 -07001206 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -07001207 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -07001208
1209 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
1210 t.Errorf("foo combined jars %v does not contain %q",
1211 foo.Inputs.Strings(), fooRes.Output.String())
1212 }
1213
Colin Crossaf9c55b2017-10-03 14:50:08 -07001214 if fooRes.Args["jarArgs"] != test.args {
1215 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -07001216 fooRes.Args["jarArgs"], test.args)
1217 }
1218 })
1219 }
1220}
1221
Colin Cross0c4ce212019-05-03 15:28:19 -07001222func TestIncludeSrcs(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001223 ctx, _ := testJavaWithFS(t, `
Colin Cross0c4ce212019-05-03 15:28:19 -07001224 java_library {
1225 name: "foo",
1226 srcs: [
1227 "a.java",
1228 "b.java",
1229 "c.java",
1230 ],
1231 include_srcs: true,
1232 }
1233
1234 java_library {
1235 name: "bar",
1236 srcs: [
1237 "a.java",
1238 "b.java",
1239 "c.java",
1240 ],
1241 java_resource_dirs: ["java-res"],
1242 include_srcs: true,
1243 }
Colin Cross238c1f32020-06-07 16:58:18 -07001244 `, map[string][]byte{
1245 "java-res/a/a": nil,
1246 "java-res/b/b": nil,
1247 "java-res2/a": nil,
1248 })
Colin Cross0c4ce212019-05-03 15:28:19 -07001249
1250 // Test a library with include_srcs: true
1251 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
1252 fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar")
1253
1254 if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) {
1255 t.Errorf("foo combined jars %v does not contain %q", w, g)
1256 }
1257
1258 if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
1259 t.Errorf("foo source jar args %q is not %q", w, g)
1260 }
1261
1262 // Test a library with include_srcs: true and resources
1263 bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar")
1264 barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar")
1265 barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar")
1266 barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar")
1267
1268 if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
1269 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
1270 }
1271
1272 if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
1273 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
1274 }
1275
1276 if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) {
1277 t.Errorf("bar combined jars %v does not contain %q", w, g)
1278 }
1279
1280 if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
1281 t.Errorf("bar source jar args %q is not %q", w, g)
1282 }
1283
1284 if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w {
1285 t.Errorf("bar resource jar args %q is not %q", w, g)
1286 }
1287}
1288
Pedro Loureiro5d190cc2021-02-15 15:41:33 +00001289func TestJavaLint(t *testing.T) {
1290 ctx, _ := testJavaWithFS(t, `
1291 java_library {
1292 name: "foo",
1293 srcs: [
1294 "a.java",
1295 "b.java",
1296 "c.java",
1297 ],
1298 min_sdk_version: "29",
1299 sdk_version: "system_current",
1300 }
1301 `, map[string][]byte{
1302 "lint-baseline.xml": nil,
1303 })
1304
1305 foo := ctx.ModuleForTests("foo", "android_common")
1306 rule := foo.Rule("lint")
1307
1308 if !strings.Contains(rule.RuleParams.Command, "--baseline lint-baseline.xml") {
1309 t.Error("did not pass --baseline flag")
1310 }
1311}
1312
1313func TestJavaLintWithoutBaseline(t *testing.T) {
1314 ctx, _ := testJavaWithFS(t, `
1315 java_library {
1316 name: "foo",
1317 srcs: [
1318 "a.java",
1319 "b.java",
1320 "c.java",
1321 ],
1322 min_sdk_version: "29",
1323 sdk_version: "system_current",
1324 }
1325 `, map[string][]byte{})
1326
1327 foo := ctx.ModuleForTests("foo", "android_common")
1328 rule := foo.Rule("lint")
1329
1330 if strings.Contains(rule.RuleParams.Command, "--baseline") {
1331 t.Error("passed --baseline flag for non existent file")
1332 }
1333}
1334
1335func TestJavaLintRequiresCustomLintFileToExist(t *testing.T) {
1336 config := testConfig(
1337 nil,
1338 `
1339 java_library {
1340 name: "foo",
1341 srcs: [
1342 ],
1343 min_sdk_version: "29",
1344 sdk_version: "system_current",
1345 lint: {
1346 baseline_filename: "mybaseline.xml",
1347 },
1348 }
1349 `, map[string][]byte{
1350 "build/soong/java/lint_defaults.txt": nil,
1351 "prebuilts/cmdline-tools/tools/bin/lint": nil,
1352 "prebuilts/cmdline-tools/tools/lib/lint-classpath.jar": nil,
1353 "framework/aidl": nil,
1354 "a.java": nil,
1355 "AndroidManifest.xml": nil,
1356 "build/make/target/product/security": nil,
1357 })
1358 config.TestAllowNonExistentPaths = false
1359 testJavaErrorWithConfig(t,
1360 "source path \"mybaseline.xml\" does not exist",
1361 config,
1362 )
1363}
1364
1365func TestJavaLintUsesCorrectBpConfig(t *testing.T) {
1366 ctx, _ := testJavaWithFS(t, `
1367 java_library {
1368 name: "foo",
1369 srcs: [
1370 "a.java",
1371 "b.java",
1372 "c.java",
1373 ],
1374 min_sdk_version: "29",
1375 sdk_version: "system_current",
1376 lint: {
1377 error_checks: ["SomeCheck"],
1378 baseline_filename: "mybaseline.xml",
1379 },
1380 }
1381 `, map[string][]byte{
1382 "mybaseline.xml": nil,
1383 })
1384
1385 foo := ctx.ModuleForTests("foo", "android_common")
1386 rule := foo.Rule("lint")
1387
1388 if !strings.Contains(rule.RuleParams.Command, "--baseline mybaseline.xml") {
1389 t.Error("did not use the correct file for baseline")
1390 }
1391}
1392
Colin Cross54190b32017-10-09 15:34:10 -07001393func TestGeneratedSources(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001394 ctx, _ := testJavaWithFS(t, `
Colin Cross54190b32017-10-09 15:34:10 -07001395 java_library {
1396 name: "foo",
1397 srcs: [
1398 "a*.java",
1399 ":gen",
1400 "b*.java",
1401 ],
1402 }
1403
1404 genrule {
1405 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -08001406 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -07001407 out: ["gen.java"],
1408 }
Colin Cross238c1f32020-06-07 16:58:18 -07001409 `, map[string][]byte{
1410 "a.java": nil,
1411 "b.java": nil,
1412 })
Colin Cross54190b32017-10-09 15:34:10 -07001413
1414 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1415 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
1416
Colin Cross15e86d92017-10-20 15:07:08 -07001417 if filepath.Base(genrule.Output.String()) != "gen.java" {
1418 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -07001419 }
1420
1421 if len(javac.Inputs) != 3 ||
1422 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -07001423 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -07001424 javac.Inputs[2].String() != "b.java" {
1425 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
1426 }
1427}
1428
Nan Zhang61eaedb2017-11-02 13:28:15 -07001429func TestTurbine(t *testing.T) {
Paul Duffin3d9f2682021-03-13 09:47:16 +00001430 result := javaFixtureFactory.
1431 Extend(FixtureWithPrebuiltApis(map[string][]string{"14": {"foo"}})).
1432 RunTestWithBp(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001433 java_library {
1434 name: "foo",
1435 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +09001436 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001437 }
1438
1439 java_library {
1440 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -08001441 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -07001442 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +09001443 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001444 }
1445
1446 java_library {
1447 name: "baz",
1448 srcs: ["c.java"],
1449 libs: ["bar"],
1450 sdk_version: "14",
1451 }
1452 `)
1453
Paul Duffin3d9f2682021-03-13 09:47:16 +00001454 fooTurbine := result.ModuleForTests("foo", "android_common").Rule("turbine")
1455 barTurbine := result.ModuleForTests("bar", "android_common").Rule("turbine")
1456 barJavac := result.ModuleForTests("bar", "android_common").Rule("javac")
1457 barTurbineCombined := result.ModuleForTests("bar", "android_common").Description("for turbine")
1458 bazJavac := result.ModuleForTests("baz", "android_common").Rule("javac")
Nan Zhang61eaedb2017-11-02 13:28:15 -07001459
Paul Duffin3d9f2682021-03-13 09:47:16 +00001460 android.AssertArrayString(t, "foo inputs", []string{"a.java"}, fooTurbine.Inputs.Strings())
Nan Zhang61eaedb2017-11-02 13:28:15 -07001461
1462 fooHeaderJar := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
Paul Duffin3d9f2682021-03-13 09:47:16 +00001463 barTurbineJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine", "bar.jar")
1464 android.AssertStringDoesContain(t, "bar turbine classpath", barTurbine.Args["classpath"], fooHeaderJar)
1465 android.AssertStringDoesContain(t, "bar javac classpath", barJavac.Args["classpath"], fooHeaderJar)
1466 android.AssertArrayString(t, "bar turbine combineJar", []string{barTurbineJar, fooHeaderJar}, barTurbineCombined.Inputs.Strings())
1467 android.AssertStringDoesContain(t, "baz javac classpath", bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -07001468}
1469
1470func TestSharding(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001471 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001472 java_library {
1473 name: "bar",
1474 srcs: ["a.java","b.java","c.java"],
1475 javac_shard_size: 1
1476 }
1477 `)
1478
1479 barHeaderJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
1480 for i := 0; i < 3; i++ {
1481 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
1482 if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) {
1483 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar)
1484 }
1485 }
1486}
1487
Nan Zhang581fd212018-01-10 16:06:12 -08001488func TestDroiddoc(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001489 ctx, _ := testJavaWithFS(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001490 droiddoc_exported_dir {
Dan Willemsencc090972018-02-26 14:33:31 -08001491 name: "droiddoc-templates-sdk",
1492 path: ".",
1493 }
Jiyong Park29074592019-07-07 16:27:47 +09001494 filegroup {
1495 name: "bar-doc-aidl-srcs",
1496 srcs: ["bar-doc/IBar.aidl"],
1497 path: "bar-doc",
1498 }
Liz Kammere1ab2502020-09-10 15:29:25 +00001499 droidstubs {
1500 name: "bar-stubs",
Liz Kammer3a55c912020-08-14 12:14:02 -07001501 srcs: [
Steve Kim3666c702020-09-01 17:58:01 +00001502 "bar-doc/a.java",
Liz Kammer3a55c912020-08-14 12:14:02 -07001503 ],
Steve Kim3666c702020-09-01 17:58:01 +00001504 exclude_srcs: [
1505 "bar-doc/b.java"
1506 ],
Liz Kammere1ab2502020-09-10 15:29:25 +00001507 api_levels_annotations_dirs: [
1508 "droiddoc-templates-sdk",
1509 ],
1510 api_levels_annotations_enabled: true,
1511 }
1512 droiddoc {
1513 name: "bar-doc",
1514 srcs: [
1515 ":bar-stubs",
1516 "bar-doc/IFoo.aidl",
1517 ":bar-doc-aidl-srcs",
1518 ],
Dan Willemsencc090972018-02-26 14:33:31 -08001519 custom_template: "droiddoc-templates-sdk",
Nan Zhang581fd212018-01-10 16:06:12 -08001520 hdf: [
1521 "android.whichdoc offline",
1522 ],
1523 knowntags: [
1524 "bar-doc/known_oj_tags.txt",
1525 ],
1526 proofread_file: "libcore-proofread.txt",
1527 todo_file: "libcore-docs-todo.html",
Liz Kammer585cac22020-07-06 09:12:57 -07001528 flags: ["-offlinemode -title \"libcore\""],
Nan Zhang581fd212018-01-10 16:06:12 -08001529 }
Colin Cross238c1f32020-06-07 16:58:18 -07001530 `,
1531 map[string][]byte{
1532 "bar-doc/a.java": nil,
1533 "bar-doc/b.java": nil,
1534 })
Liz Kammere1ab2502020-09-10 15:29:25 +00001535 barStubs := ctx.ModuleForTests("bar-stubs", "android_common")
1536 barStubsOutputs, err := barStubs.Module().(*Droidstubs).OutputFiles("")
1537 if err != nil {
1538 t.Errorf("Unexpected error %q retrieving \"bar-stubs\" output file", err)
1539 }
1540 if len(barStubsOutputs) != 1 {
1541 t.Errorf("Expected one output from \"bar-stubs\" got %s", barStubsOutputs)
Liz Kammer1e2ee122020-07-30 15:07:22 -07001542 }
Nan Zhang581fd212018-01-10 16:06:12 -08001543
Liz Kammere1ab2502020-09-10 15:29:25 +00001544 barStubsOutput := barStubsOutputs[0]
1545 barDoc := ctx.ModuleForTests("bar-doc", "android_common")
1546 javaDoc := barDoc.Rule("javadoc")
1547 if g, w := javaDoc.Implicits.Strings(), barStubsOutput.String(); !inList(w, g) {
1548 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
Jiyong Park29074592019-07-07 16:27:47 +09001549 }
1550
Liz Kammere1ab2502020-09-10 15:29:25 +00001551 expected := "-sourcepath " + buildDir + "/.intermediates/bar-doc/android_common/srcjars "
1552 if !strings.Contains(javaDoc.RuleParams.Command, expected) {
1553 t.Errorf("bar-doc command does not contain flag %q, but should\n%q", expected, javaDoc.RuleParams.Command)
1554 }
1555
1556 aidl := barDoc.Rule("aidl")
1557 if g, w := javaDoc.Implicits.Strings(), aidl.Output.String(); !inList(w, g) {
Colin Crossc0806172019-06-14 18:51:47 -07001558 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
1559 }
1560
1561 if g, w := aidl.Implicits.Strings(), []string{"bar-doc/IBar.aidl", "bar-doc/IFoo.aidl"}; !reflect.DeepEqual(w, g) {
1562 t.Errorf("aidl inputs must be %q, but was %q", w, g)
Jiyong Park1e440682018-05-23 18:42:04 +09001563 }
Nan Zhang581fd212018-01-10 16:06:12 -08001564}
1565
Liz Kammer585cac22020-07-06 09:12:57 -07001566func TestDroiddocArgsAndFlagsCausesError(t *testing.T) {
1567 testJavaError(t, "flags is set. Cannot set args", `
1568 droiddoc_exported_dir {
1569 name: "droiddoc-templates-sdk",
1570 path: ".",
1571 }
1572 filegroup {
1573 name: "bar-doc-aidl-srcs",
1574 srcs: ["bar-doc/IBar.aidl"],
1575 path: "bar-doc",
1576 }
Liz Kammere1ab2502020-09-10 15:29:25 +00001577 droidstubs {
1578 name: "bar-stubs",
Liz Kammer3a55c912020-08-14 12:14:02 -07001579 srcs: [
Steve Kim3666c702020-09-01 17:58:01 +00001580 "bar-doc/a.java",
Liz Kammer3a55c912020-08-14 12:14:02 -07001581 ],
Steve Kim3666c702020-09-01 17:58:01 +00001582 exclude_srcs: [
1583 "bar-doc/b.java"
1584 ],
Liz Kammere1ab2502020-09-10 15:29:25 +00001585 api_levels_annotations_dirs: [
1586 "droiddoc-templates-sdk",
1587 ],
1588 api_levels_annotations_enabled: true,
1589 }
1590 droiddoc {
1591 name: "bar-doc",
1592 srcs: [
1593 ":bar-stubs",
1594 "bar-doc/IFoo.aidl",
1595 ":bar-doc-aidl-srcs",
1596 ],
Liz Kammer585cac22020-07-06 09:12:57 -07001597 custom_template: "droiddoc-templates-sdk",
1598 hdf: [
1599 "android.whichdoc offline",
1600 ],
1601 knowntags: [
1602 "bar-doc/known_oj_tags.txt",
1603 ],
1604 proofread_file: "libcore-proofread.txt",
1605 todo_file: "libcore-docs-todo.html",
1606 flags: ["-offlinemode -title \"libcore\""],
1607 args: "-offlinemode -title \"libcore\"",
1608 }
1609 `)
1610}
1611
Liz Kammer3d894b72020-08-04 09:55:13 -07001612func TestDroidstubs(t *testing.T) {
1613 ctx, _ := testJavaWithFS(t, `
1614 droiddoc_exported_dir {
Anton Hansson52ac73d2020-10-26 09:57:40 +00001615 name: "droiddoc-templates-sdk",
1616 path: ".",
Liz Kammer3d894b72020-08-04 09:55:13 -07001617 }
1618
1619 droidstubs {
Anton Hansson52ac73d2020-10-26 09:57:40 +00001620 name: "bar-stubs",
1621 srcs: ["bar-doc/a.java"],
1622 api_levels_annotations_dirs: ["droiddoc-templates-sdk"],
1623 api_levels_annotations_enabled: true,
Liz Kammer3d894b72020-08-04 09:55:13 -07001624 }
1625
1626 droidstubs {
Anton Hansson52ac73d2020-10-26 09:57:40 +00001627 name: "bar-stubs-other",
1628 srcs: ["bar-doc/a.java"],
1629 high_mem: true,
1630 api_levels_annotations_dirs: ["droiddoc-templates-sdk"],
1631 api_levels_annotations_enabled: true,
1632 api_levels_jar_filename: "android.other.jar",
Liz Kammer3d894b72020-08-04 09:55:13 -07001633 }
1634 `,
1635 map[string][]byte{
1636 "bar-doc/a.java": nil,
1637 })
1638 testcases := []struct {
1639 moduleName string
1640 expectedJarFilename string
Anton Hansson52ac73d2020-10-26 09:57:40 +00001641 high_mem bool
Liz Kammer3d894b72020-08-04 09:55:13 -07001642 }{
1643 {
1644 moduleName: "bar-stubs",
1645 expectedJarFilename: "android.jar",
Anton Hansson52ac73d2020-10-26 09:57:40 +00001646 high_mem: false,
Liz Kammer3d894b72020-08-04 09:55:13 -07001647 },
1648 {
1649 moduleName: "bar-stubs-other",
1650 expectedJarFilename: "android.other.jar",
Anton Hansson52ac73d2020-10-26 09:57:40 +00001651 high_mem: true,
Liz Kammer3d894b72020-08-04 09:55:13 -07001652 },
1653 }
1654 for _, c := range testcases {
1655 m := ctx.ModuleForTests(c.moduleName, "android_common")
1656 metalava := m.Rule("metalava")
Anton Hansson52ac73d2020-10-26 09:57:40 +00001657 rp := metalava.RuleParams
Liz Kammer3d894b72020-08-04 09:55:13 -07001658 expected := "--android-jar-pattern ./%/public/" + c.expectedJarFilename
Anton Hansson52ac73d2020-10-26 09:57:40 +00001659 if actual := rp.Command; !strings.Contains(actual, expected) {
Liz Kammer3d894b72020-08-04 09:55:13 -07001660 t.Errorf("For %q, expected metalava argument %q, but was not found %q", c.moduleName, expected, actual)
1661 }
Anton Hansson52ac73d2020-10-26 09:57:40 +00001662
1663 if actual := rp.Pool != nil && strings.Contains(rp.Pool.String(), "highmem"); actual != c.high_mem {
1664 t.Errorf("Expected %q high_mem to be %v, was %v", c.moduleName, c.high_mem, actual)
1665 }
Liz Kammer3d894b72020-08-04 09:55:13 -07001666 }
1667}
1668
Paul Duffin83a2d962019-11-19 19:44:10 +00001669func TestDroidstubsWithSystemModules(t *testing.T) {
1670 ctx, _ := testJava(t, `
1671 droidstubs {
1672 name: "stubs-source-system-modules",
1673 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001674 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001675 ],
1676 sdk_version: "none",
1677 system_modules: "source-system-modules",
1678 }
1679
1680 java_library {
1681 name: "source-jar",
1682 srcs: [
1683 "a.java",
1684 ],
1685 }
1686
1687 java_system_modules {
1688 name: "source-system-modules",
1689 libs: ["source-jar"],
1690 }
1691
1692 droidstubs {
1693 name: "stubs-prebuilt-system-modules",
1694 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001695 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001696 ],
1697 sdk_version: "none",
1698 system_modules: "prebuilt-system-modules",
1699 }
1700
1701 java_import {
1702 name: "prebuilt-jar",
1703 jars: ["a.jar"],
1704 }
1705
1706 java_system_modules_import {
1707 name: "prebuilt-system-modules",
1708 libs: ["prebuilt-jar"],
1709 }
1710 `)
1711
1712 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-source-system-modules", "source-jar.jar")
1713
1714 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-prebuilt-system-modules", "prebuilt-jar.jar")
1715}
1716
1717func checkSystemModulesUseByDroidstubs(t *testing.T, ctx *android.TestContext, moduleName string, systemJar string) {
1718 metalavaRule := ctx.ModuleForTests(moduleName, "android_common").Rule("metalava")
1719 var systemJars []string
1720 for _, i := range metalavaRule.Implicits {
1721 systemJars = append(systemJars, i.Base())
1722 }
Ramy Medhatc7965cd2020-04-30 03:08:37 -04001723 if len(systemJars) < 1 || systemJars[0] != systemJar {
Paul Duffin83a2d962019-11-19 19:44:10 +00001724 t.Errorf("inputs of %q must be []string{%q}, but was %#v.", moduleName, systemJar, systemJars)
1725 }
1726}
1727
Colin Cross54250902017-12-05 09:28:08 -08001728func TestJarGenrules(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001729 ctx, _ := testJava(t, `
Colin Cross54250902017-12-05 09:28:08 -08001730 java_library {
1731 name: "foo",
1732 srcs: ["a.java"],
1733 }
1734
1735 java_genrule {
1736 name: "jargen",
1737 tool_files: ["b.java"],
1738 cmd: "$(location b.java) $(in) $(out)",
1739 out: ["jargen.jar"],
1740 srcs: [":foo"],
1741 }
1742
1743 java_library {
1744 name: "bar",
1745 static_libs: ["jargen"],
1746 srcs: ["c.java"],
1747 }
1748
1749 java_library {
1750 name: "baz",
1751 libs: ["jargen"],
1752 srcs: ["c.java"],
1753 }
1754 `)
1755
1756 foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar")
1757 jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar")
1758 bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar")
1759 baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar")
1760 barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar")
1761
Colin Cross3d680512020-11-13 16:23:53 -08001762 if g, w := jargen.Implicits.Strings(), foo.Output.String(); !android.InList(w, g) {
1763 t.Errorf("expected jargen inputs [%q], got %q", w, g)
Colin Cross54250902017-12-05 09:28:08 -08001764 }
1765
1766 if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) {
1767 t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String())
1768 }
1769
1770 if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) {
1771 t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String())
1772 }
1773
1774 if len(barCombined.Inputs) != 2 ||
1775 barCombined.Inputs[0].String() != bar.Output.String() ||
1776 barCombined.Inputs[1].String() != jargen.Output.String() {
1777 t.Errorf("bar combined jar inputs %v is not [%q, %q]",
1778 barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String())
1779 }
1780}
1781
Nan Zhang27e284d2018-02-09 21:03:53 +00001782func TestExcludeFileGroupInSrcs(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001783 ctx, _ := testJava(t, `
Nan Zhang27e284d2018-02-09 21:03:53 +00001784 java_library {
1785 name: "foo",
1786 srcs: ["a.java", ":foo-srcs"],
1787 exclude_srcs: ["a.java", ":foo-excludes"],
1788 }
1789
1790 filegroup {
1791 name: "foo-srcs",
1792 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
1793 }
1794
1795 filegroup {
1796 name: "foo-excludes",
1797 srcs: ["java-fg/a.java", "java-fg/b.java"],
1798 }
1799 `)
1800
1801 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1802
1803 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
1804 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
1805 }
1806}
Jiyong Parkc678ad32018-04-10 13:07:10 +09001807
Paul Duffin52d398a2019-06-11 12:31:14 +01001808func TestJavaLibrary(t *testing.T) {
Colin Cross98be1bb2019-12-13 20:41:13 -08001809 config := testConfig(nil, "", map[string][]byte{
Paul Duffin52d398a2019-06-11 12:31:14 +01001810 "libcore/Android.bp": []byte(`
1811 java_library {
1812 name: "core",
1813 sdk_version: "none",
1814 system_modules: "none",
Paul Duffinaa55f742020-10-06 17:20:13 +01001815 }
1816
1817 filegroup {
1818 name: "core-jar",
1819 srcs: [":core{.jar}"],
1820 }
1821`),
1822 })
Colin Crossae8600b2020-10-29 17:09:13 -07001823 ctx := testContext(config)
Paul Duffinaa55f742020-10-06 17:20:13 +01001824 run(t, ctx, config)
1825}
1826
1827func TestJavaImport(t *testing.T) {
1828 config := testConfig(nil, "", map[string][]byte{
1829 "libcore/Android.bp": []byte(`
1830 java_import {
1831 name: "core",
1832 sdk_version: "none",
1833 }
1834
1835 filegroup {
1836 name: "core-jar",
1837 srcs: [":core{.jar}"],
1838 }
1839`),
Paul Duffin52d398a2019-06-11 12:31:14 +01001840 })
Colin Crossae8600b2020-10-29 17:09:13 -07001841 ctx := testContext(config)
Paul Duffin52d398a2019-06-11 12:31:14 +01001842 run(t, ctx, config)
1843}
1844
Jiyong Parkc678ad32018-04-10 13:07:10 +09001845func TestJavaSdkLibrary(t *testing.T) {
Paul Duffin163043d2021-03-12 19:18:49 +00001846 result := javaFixtureFactory.Extend(
1847 PrepareForTestWithJavaSdkLibraryFiles,
1848 FixtureWithPrebuiltApis(map[string][]string{
1849 "28": {"foo"},
1850 "29": {"foo"},
1851 "30": {"bar", "barney", "baz", "betty", "foo", "fred", "quuz", "wilma"},
1852 }),
1853 ).RunTestWithBp(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001854 droiddoc_exported_dir {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001855 name: "droiddoc-templates-sdk",
1856 path: ".",
1857 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001858 java_sdk_library {
1859 name: "foo",
1860 srcs: ["a.java", "b.java"],
1861 api_packages: ["foo"],
1862 }
1863 java_sdk_library {
1864 name: "bar",
1865 srcs: ["a.java", "b.java"],
1866 api_packages: ["bar"],
1867 }
1868 java_library {
1869 name: "baz",
1870 srcs: ["c.java"],
Paul Duffin859fe962020-05-15 10:20:31 +01001871 libs: ["foo", "bar.stubs"],
Jiyong Parkc678ad32018-04-10 13:07:10 +09001872 sdk_version: "system_current",
1873 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001874 java_sdk_library {
1875 name: "barney",
1876 srcs: ["c.java"],
1877 api_only: true,
1878 }
1879 java_sdk_library {
1880 name: "betty",
1881 srcs: ["c.java"],
1882 shared_library: false,
1883 }
Paul Duffin859fe962020-05-15 10:20:31 +01001884 java_sdk_library_import {
1885 name: "quuz",
1886 public: {
1887 jars: ["c.jar"],
1888 },
1889 }
1890 java_sdk_library_import {
1891 name: "fred",
1892 public: {
1893 jars: ["b.jar"],
1894 },
1895 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001896 java_sdk_library_import {
1897 name: "wilma",
1898 public: {
1899 jars: ["b.jar"],
1900 },
1901 shared_library: false,
1902 }
Jiyong Park1be96912018-05-28 18:02:19 +09001903 java_library {
1904 name: "qux",
1905 srcs: ["c.java"],
Paul Duffindfa131e2020-05-15 20:37:11 +01001906 libs: ["baz", "fred", "quuz.stubs", "wilma", "barney", "betty"],
Jiyong Park1be96912018-05-28 18:02:19 +09001907 sdk_version: "system_current",
1908 }
Paul Duffin726d23c2020-01-22 16:30:37 +00001909 java_library {
1910 name: "baz-test",
1911 srcs: ["c.java"],
1912 libs: ["foo"],
1913 sdk_version: "test_current",
1914 }
Paul Duffina2db18f2020-01-22 17:11:15 +00001915 java_library {
1916 name: "baz-29",
1917 srcs: ["c.java"],
1918 libs: ["foo"],
1919 sdk_version: "system_29",
1920 }
Paul Duffinfb6ae5b2020-09-30 15:17:25 +01001921 java_library {
1922 name: "baz-module-30",
1923 srcs: ["c.java"],
1924 libs: ["foo"],
1925 sdk_version: "module_30",
1926 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001927 `)
1928
1929 // check the existence of the internal modules
Paul Duffin22b77cd2021-03-12 19:15:01 +00001930 result.ModuleForTests("foo", "android_common")
1931 result.ModuleForTests(apiScopePublic.stubsLibraryModuleName("foo"), "android_common")
1932 result.ModuleForTests(apiScopeSystem.stubsLibraryModuleName("foo"), "android_common")
1933 result.ModuleForTests(apiScopeTest.stubsLibraryModuleName("foo"), "android_common")
1934 result.ModuleForTests(apiScopePublic.stubsSourceModuleName("foo"), "android_common")
1935 result.ModuleForTests(apiScopeSystem.stubsSourceModuleName("foo"), "android_common")
1936 result.ModuleForTests(apiScopeTest.stubsSourceModuleName("foo"), "android_common")
1937 result.ModuleForTests("foo"+sdkXmlFileSuffix, "android_common")
1938 result.ModuleForTests("foo.api.public.28", "")
1939 result.ModuleForTests("foo.api.system.28", "")
1940 result.ModuleForTests("foo.api.test.28", "")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001941
Paul Duffin22b77cd2021-03-12 19:15:01 +00001942 bazJavac := result.ModuleForTests("baz", "android_common").Rule("javac")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001943 // tests if baz is actually linked to the stubs lib
Paul Duffin22b77cd2021-03-12 19:15:01 +00001944 android.AssertStringDoesContain(t, "baz javac classpath", bazJavac.Args["classpath"], "foo.stubs.system.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001945 // ... and not to the impl lib
Paul Duffin22b77cd2021-03-12 19:15:01 +00001946 android.AssertStringDoesNotContain(t, "baz javac classpath", bazJavac.Args["classpath"], "foo.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001947 // test if baz is not linked to the system variant of foo
Paul Duffin22b77cd2021-03-12 19:15:01 +00001948 android.AssertStringDoesNotContain(t, "baz javac classpath", bazJavac.Args["classpath"], "foo.stubs.jar")
Jiyong Park1be96912018-05-28 18:02:19 +09001949
Paul Duffin22b77cd2021-03-12 19:15:01 +00001950 bazTestJavac := result.ModuleForTests("baz-test", "android_common").Rule("javac")
Paul Duffin726d23c2020-01-22 16:30:37 +00001951 // tests if baz-test is actually linked to the test stubs lib
Paul Duffin22b77cd2021-03-12 19:15:01 +00001952 android.AssertStringDoesContain(t, "baz-test javac classpath", bazTestJavac.Args["classpath"], "foo.stubs.test.jar")
Paul Duffin726d23c2020-01-22 16:30:37 +00001953
Paul Duffin22b77cd2021-03-12 19:15:01 +00001954 baz29Javac := result.ModuleForTests("baz-29", "android_common").Rule("javac")
Paul Duffina2db18f2020-01-22 17:11:15 +00001955 // tests if baz-29 is actually linked to the system 29 stubs lib
Paul Duffin22b77cd2021-03-12 19:15:01 +00001956 android.AssertStringDoesContain(t, "baz-29 javac classpath", baz29Javac.Args["classpath"], "prebuilts/sdk/29/system/foo.jar")
Paul Duffina2db18f2020-01-22 17:11:15 +00001957
Paul Duffin22b77cd2021-03-12 19:15:01 +00001958 bazModule30Javac := result.ModuleForTests("baz-module-30", "android_common").Rule("javac")
Paul Duffinfb6ae5b2020-09-30 15:17:25 +01001959 // tests if "baz-module-30" is actually linked to the module 30 stubs lib
Paul Duffin22b77cd2021-03-12 19:15:01 +00001960 android.AssertStringDoesContain(t, "baz-module-30 javac classpath", bazModule30Javac.Args["classpath"], "prebuilts/sdk/30/module-lib/foo.jar")
Paul Duffinfb6ae5b2020-09-30 15:17:25 +01001961
Jiyong Park1be96912018-05-28 18:02:19 +09001962 // test if baz has exported SDK lib names foo and bar to qux
Paul Duffin22b77cd2021-03-12 19:15:01 +00001963 qux := result.ModuleForTests("qux", "android_common")
Jiyong Park1be96912018-05-28 18:02:19 +09001964 if quxLib, ok := qux.Module().(*Library); ok {
Ulya Trafimovichb23d28c2020-10-08 12:53:58 +01001965 sdkLibs := quxLib.ClassLoaderContexts().UsesLibs()
Paul Duffin22b77cd2021-03-12 19:15:01 +00001966 android.AssertDeepEquals(t, "qux exports", []string{"foo", "bar", "fred", "quuz"}, sdkLibs)
Jiyong Park1be96912018-05-28 18:02:19 +09001967 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001968}
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001969
Anton Hansson7f66efa2020-10-08 14:47:23 +01001970func TestJavaSdkLibrary_StubOrImplOnlyLibs(t *testing.T) {
Paul Duffin163043d2021-03-12 19:18:49 +00001971 result := javaFixtureFactory.Extend(
1972 PrepareForTestWithJavaSdkLibraryFiles,
1973 FixtureWithLastReleaseApis("sdklib"),
1974 ).RunTestWithBp(t, `
Anton Hansson7f66efa2020-10-08 14:47:23 +01001975 java_sdk_library {
Anton Hanssondff2c782020-12-21 17:10:01 +00001976 name: "sdklib",
Anton Hansson7f66efa2020-10-08 14:47:23 +01001977 srcs: ["a.java"],
1978 impl_only_libs: ["foo"],
1979 stub_only_libs: ["bar"],
1980 }
1981 java_library {
1982 name: "foo",
1983 srcs: ["a.java"],
1984 sdk_version: "current",
1985 }
1986 java_library {
1987 name: "bar",
1988 srcs: ["a.java"],
1989 sdk_version: "current",
1990 }
1991 `)
1992
Anton Hanssondff2c782020-12-21 17:10:01 +00001993 for _, implName := range []string{"sdklib", "sdklib.impl"} {
Paul Duffin22b77cd2021-03-12 19:15:01 +00001994 implJavacCp := result.ModuleForTests(implName, "android_common").Rule("javac").Args["classpath"]
Anton Hansson7f66efa2020-10-08 14:47:23 +01001995 if !strings.Contains(implJavacCp, "/foo.jar") || strings.Contains(implJavacCp, "/bar.jar") {
1996 t.Errorf("%v javac classpath %v does not contain foo and not bar", implName, implJavacCp)
1997 }
1998 }
Anton Hanssondff2c782020-12-21 17:10:01 +00001999 stubName := apiScopePublic.stubsLibraryModuleName("sdklib")
Paul Duffin22b77cd2021-03-12 19:15:01 +00002000 stubsJavacCp := result.ModuleForTests(stubName, "android_common").Rule("javac").Args["classpath"]
Anton Hansson7f66efa2020-10-08 14:47:23 +01002001 if strings.Contains(stubsJavacCp, "/foo.jar") || !strings.Contains(stubsJavacCp, "/bar.jar") {
2002 t.Errorf("stubs javac classpath %v does not contain bar and not foo", stubsJavacCp)
2003 }
2004}
2005
Paul Duffindaaa3322020-05-26 18:13:57 +01002006func TestJavaSdkLibrary_DoNotAccessImplWhenItIsNotBuilt(t *testing.T) {
Paul Duffin163043d2021-03-12 19:18:49 +00002007 result := javaFixtureFactory.Extend(
2008 PrepareForTestWithJavaSdkLibraryFiles,
2009 FixtureWithLastReleaseApis("foo"),
2010 ).RunTestWithBp(t, `
Paul Duffindaaa3322020-05-26 18:13:57 +01002011 java_sdk_library {
2012 name: "foo",
2013 srcs: ["a.java"],
2014 api_only: true,
2015 public: {
2016 enabled: true,
2017 },
2018 }
2019
2020 java_library {
2021 name: "bar",
2022 srcs: ["b.java"],
2023 libs: ["foo"],
2024 }
2025 `)
2026
2027 // The bar library should depend on the stubs jar.
Paul Duffin22b77cd2021-03-12 19:15:01 +00002028 barLibrary := result.ModuleForTests("bar", "android_common").Rule("javac")
Paul Duffindaaa3322020-05-26 18:13:57 +01002029 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
2030 t.Errorf("expected %q, found %#q", expected, actual)
2031 }
2032}
2033
Paul Duffin46dc45a2020-05-14 15:39:10 +01002034func TestJavaSdkLibrary_UseSourcesFromAnotherSdkLibrary(t *testing.T) {
Paul Duffin163043d2021-03-12 19:18:49 +00002035 javaFixtureFactory.Extend(
2036 PrepareForTestWithJavaSdkLibraryFiles,
2037 FixtureWithLastReleaseApis("foo"),
2038 ).RunTestWithBp(t, `
Paul Duffin46dc45a2020-05-14 15:39:10 +01002039 java_sdk_library {
2040 name: "foo",
2041 srcs: ["a.java"],
2042 api_packages: ["foo"],
2043 public: {
2044 enabled: true,
2045 },
2046 }
2047
2048 java_library {
2049 name: "bar",
2050 srcs: ["b.java", ":foo{.public.stubs.source}"],
2051 }
2052 `)
2053}
2054
2055func TestJavaSdkLibrary_AccessOutputFiles_MissingScope(t *testing.T) {
Paul Duffin22b77cd2021-03-12 19:15:01 +00002056 javaFixtureFactory.
Paul Duffin163043d2021-03-12 19:18:49 +00002057 Extend(
2058 PrepareForTestWithJavaSdkLibraryFiles,
2059 FixtureWithLastReleaseApis("foo"),
2060 ).
Paul Duffin22b77cd2021-03-12 19:15:01 +00002061 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`"foo" does not provide api scope system`)).
2062 RunTestWithBp(t, `
Paul Duffin46dc45a2020-05-14 15:39:10 +01002063 java_sdk_library {
2064 name: "foo",
2065 srcs: ["a.java"],
2066 api_packages: ["foo"],
2067 public: {
2068 enabled: true,
2069 },
2070 }
2071
2072 java_library {
2073 name: "bar",
2074 srcs: ["b.java", ":foo{.system.stubs.source}"],
2075 }
2076 `)
2077}
2078
Paul Duffinca8d9a52020-06-26 22:20:25 +01002079func TestJavaSdkLibrary_Deps(t *testing.T) {
Paul Duffin163043d2021-03-12 19:18:49 +00002080 result := javaFixtureFactory.Extend(
2081 PrepareForTestWithJavaSdkLibraryFiles,
2082 FixtureWithLastReleaseApis("sdklib"),
2083 ).RunTestWithBp(t, `
Paul Duffinca8d9a52020-06-26 22:20:25 +01002084 java_sdk_library {
2085 name: "sdklib",
2086 srcs: ["a.java"],
2087 sdk_version: "none",
2088 system_modules: "none",
2089 public: {
2090 enabled: true,
2091 },
2092 }
2093 `)
2094
Paul Duffin22b77cd2021-03-12 19:15:01 +00002095 CheckModuleDependencies(t, result.TestContext, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +01002096 `dex2oatd`,
2097 `sdklib.impl`,
2098 `sdklib.stubs`,
2099 `sdklib.stubs.source`,
2100 `sdklib.xml`,
2101 })
2102}
2103
Paul Duffin46dc45a2020-05-14 15:39:10 +01002104func TestJavaSdkLibraryImport_AccessOutputFiles(t *testing.T) {
Paul Duffin22b77cd2021-03-12 19:15:01 +00002105 javaFixtureFactory.RunTestWithBp(t, `
Paul Duffin46dc45a2020-05-14 15:39:10 +01002106 java_sdk_library_import {
2107 name: "foo",
2108 public: {
2109 jars: ["a.jar"],
2110 stub_srcs: ["a.java"],
2111 current_api: "api/current.txt",
2112 removed_api: "api/removed.txt",
2113 },
2114 }
2115
2116 java_library {
2117 name: "bar",
2118 srcs: [":foo{.public.stubs.source}"],
2119 java_resources: [
2120 ":foo{.public.api.txt}",
2121 ":foo{.public.removed-api.txt}",
2122 ],
2123 }
2124 `)
2125}
2126
2127func TestJavaSdkLibraryImport_AccessOutputFiles_Invalid(t *testing.T) {
2128 bp := `
2129 java_sdk_library_import {
2130 name: "foo",
2131 public: {
2132 jars: ["a.jar"],
2133 },
2134 }
2135 `
2136
2137 t.Run("stubs.source", func(t *testing.T) {
Paul Duffin22b77cd2021-03-12 19:15:01 +00002138 javaFixtureFactory.
2139 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`stubs.source not available for api scope public`)).
2140 RunTestWithBp(t, bp+`
2141 java_library {
2142 name: "bar",
2143 srcs: [":foo{.public.stubs.source}"],
2144 java_resources: [
2145 ":foo{.public.api.txt}",
2146 ":foo{.public.removed-api.txt}",
2147 ],
2148 }
2149 `)
Paul Duffin46dc45a2020-05-14 15:39:10 +01002150 })
2151
2152 t.Run("api.txt", func(t *testing.T) {
Paul Duffin22b77cd2021-03-12 19:15:01 +00002153 javaFixtureFactory.
2154 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`api.txt not available for api scope public`)).
2155 RunTestWithBp(t, bp+`
2156 java_library {
2157 name: "bar",
2158 srcs: ["a.java"],
2159 java_resources: [
2160 ":foo{.public.api.txt}",
2161 ],
2162 }
2163 `)
Paul Duffin46dc45a2020-05-14 15:39:10 +01002164 })
2165
2166 t.Run("removed-api.txt", func(t *testing.T) {
Paul Duffin22b77cd2021-03-12 19:15:01 +00002167 javaFixtureFactory.
2168 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`removed-api.txt not available for api scope public`)).
2169 RunTestWithBp(t, bp+`
2170 java_library {
2171 name: "bar",
2172 srcs: ["a.java"],
2173 java_resources: [
2174 ":foo{.public.removed-api.txt}",
2175 ],
2176 }
2177 `)
Paul Duffin46dc45a2020-05-14 15:39:10 +01002178 })
2179}
2180
Paul Duffin3375e352020-04-28 10:44:03 +01002181func TestJavaSdkLibrary_InvalidScopes(t *testing.T) {
Paul Duffin22b77cd2021-03-12 19:15:01 +00002182 javaFixtureFactory.
2183 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`module "foo": enabled api scope "system" depends on disabled scope "public"`)).
2184 RunTestWithBp(t, `
2185 java_sdk_library {
2186 name: "foo",
2187 srcs: ["a.java", "b.java"],
2188 api_packages: ["foo"],
2189 // Explicitly disable public to test the check that ensures the set of enabled
2190 // scopes is consistent.
2191 public: {
2192 enabled: false,
2193 },
2194 system: {
2195 enabled: true,
2196 },
2197 }
Paul Duffin3375e352020-04-28 10:44:03 +01002198 `)
2199}
2200
Paul Duffin87a05a32020-05-12 11:50:28 +01002201func TestJavaSdkLibrary_SdkVersion_ForScope(t *testing.T) {
Paul Duffin163043d2021-03-12 19:18:49 +00002202 javaFixtureFactory.Extend(
2203 PrepareForTestWithJavaSdkLibraryFiles,
2204 FixtureWithLastReleaseApis("foo"),
2205 ).RunTestWithBp(t, `
Paul Duffin87a05a32020-05-12 11:50:28 +01002206 java_sdk_library {
2207 name: "foo",
2208 srcs: ["a.java", "b.java"],
2209 api_packages: ["foo"],
2210 system: {
2211 enabled: true,
2212 sdk_version: "module_current",
2213 },
2214 }
2215 `)
2216}
2217
Paul Duffin0c5bae52020-06-02 13:00:08 +01002218func TestJavaSdkLibrary_ModuleLib(t *testing.T) {
Paul Duffin163043d2021-03-12 19:18:49 +00002219 javaFixtureFactory.Extend(
2220 PrepareForTestWithJavaSdkLibraryFiles,
2221 FixtureWithLastReleaseApis("foo"),
2222 ).RunTestWithBp(t, `
Paul Duffin0c5bae52020-06-02 13:00:08 +01002223 java_sdk_library {
2224 name: "foo",
2225 srcs: ["a.java", "b.java"],
2226 api_packages: ["foo"],
2227 system: {
2228 enabled: true,
2229 },
2230 module_lib: {
2231 enabled: true,
2232 },
2233 }
2234 `)
2235}
2236
2237func TestJavaSdkLibrary_SystemServer(t *testing.T) {
Paul Duffin163043d2021-03-12 19:18:49 +00002238 javaFixtureFactory.Extend(
2239 PrepareForTestWithJavaSdkLibraryFiles,
2240 FixtureWithLastReleaseApis("foo"),
2241 ).RunTestWithBp(t, `
Paul Duffin0c5bae52020-06-02 13:00:08 +01002242 java_sdk_library {
2243 name: "foo",
2244 srcs: ["a.java", "b.java"],
2245 api_packages: ["foo"],
2246 system: {
2247 enabled: true,
2248 },
2249 system_server: {
2250 enabled: true,
2251 },
2252 }
2253 `)
2254}
2255
Paul Duffin803a9562020-05-20 11:52:25 +01002256func TestJavaSdkLibrary_MissingScope(t *testing.T) {
Paul Duffin22b77cd2021-03-12 19:15:01 +00002257 javaFixtureFactory.
2258 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`requires api scope module-lib from foo but it only has \[\] available`)).
2259 RunTestWithBp(t, `
2260 java_sdk_library {
2261 name: "foo",
2262 srcs: ["a.java"],
2263 public: {
2264 enabled: false,
2265 },
2266 }
Paul Duffin803a9562020-05-20 11:52:25 +01002267
Paul Duffin22b77cd2021-03-12 19:15:01 +00002268 java_library {
2269 name: "baz",
2270 srcs: ["a.java"],
2271 libs: ["foo"],
2272 sdk_version: "module_current",
2273 }
Paul Duffin803a9562020-05-20 11:52:25 +01002274 `)
2275}
2276
2277func TestJavaSdkLibrary_FallbackScope(t *testing.T) {
Paul Duffin163043d2021-03-12 19:18:49 +00002278 javaFixtureFactory.Extend(
2279 PrepareForTestWithJavaSdkLibraryFiles,
2280 FixtureWithLastReleaseApis("foo"),
2281 ).RunTestWithBp(t, `
Paul Duffin803a9562020-05-20 11:52:25 +01002282 java_sdk_library {
2283 name: "foo",
2284 srcs: ["a.java"],
2285 system: {
2286 enabled: true,
2287 },
2288 }
2289
2290 java_library {
2291 name: "baz",
2292 srcs: ["a.java"],
2293 libs: ["foo"],
2294 // foo does not have module-lib scope so it should fallback to system
2295 sdk_version: "module_current",
2296 }
2297 `)
2298}
2299
Jiyong Park932cdfe2020-05-28 00:19:53 +09002300func TestJavaSdkLibrary_DefaultToStubs(t *testing.T) {
Paul Duffin163043d2021-03-12 19:18:49 +00002301 result := javaFixtureFactory.Extend(
2302 PrepareForTestWithJavaSdkLibraryFiles,
2303 FixtureWithLastReleaseApis("foo"),
2304 ).RunTestWithBp(t, `
Jiyong Park932cdfe2020-05-28 00:19:53 +09002305 java_sdk_library {
2306 name: "foo",
2307 srcs: ["a.java"],
2308 system: {
2309 enabled: true,
2310 },
2311 default_to_stubs: true,
2312 }
2313
2314 java_library {
2315 name: "baz",
2316 srcs: ["a.java"],
2317 libs: ["foo"],
2318 // does not have sdk_version set, should fallback to module,
2319 // which will then fallback to system because the module scope
2320 // is not enabled.
2321 }
2322 `)
2323 // The baz library should depend on the system stubs jar.
Paul Duffin22b77cd2021-03-12 19:15:01 +00002324 bazLibrary := result.ModuleForTests("baz", "android_common").Rule("javac")
Jiyong Park932cdfe2020-05-28 00:19:53 +09002325 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs.system\.jar$`, bazLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
2326 t.Errorf("expected %q, found %#q", expected, actual)
2327 }
2328}
2329
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02002330var compilerFlagsTestCases = []struct {
2331 in string
2332 out bool
2333}{
2334 {
2335 in: "a",
2336 out: false,
2337 },
2338 {
2339 in: "-a",
2340 out: true,
2341 },
2342 {
2343 in: "-no-jdk",
2344 out: false,
2345 },
2346 {
2347 in: "-no-stdlib",
2348 out: false,
2349 },
2350 {
2351 in: "-kotlin-home",
2352 out: false,
2353 },
2354 {
2355 in: "-kotlin-home /some/path",
2356 out: false,
2357 },
2358 {
2359 in: "-include-runtime",
2360 out: false,
2361 },
2362 {
2363 in: "-Xintellij-plugin-root",
2364 out: false,
2365 },
2366}
2367
2368type mockContext struct {
2369 android.ModuleContext
2370 result bool
2371}
2372
2373func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
2374 // CheckBadCompilerFlags calls this function when the flag should be rejected
2375 ctx.result = false
2376}
2377
2378func TestCompilerFlags(t *testing.T) {
2379 for _, testCase := range compilerFlagsTestCases {
2380 ctx := &mockContext{result: true}
2381 CheckKotlincFlags(ctx, []string{testCase.in})
2382 if ctx.result != testCase.out {
2383 t.Errorf("incorrect output:")
2384 t.Errorf(" input: %#v", testCase.in)
2385 t.Errorf(" expected: %#v", testCase.out)
2386 t.Errorf(" got: %#v", ctx.result)
2387 }
2388 }
2389}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002390
2391// TODO(jungjw): Consider making this more robust by ignoring path order.
2392func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
2393 variables := ctx.ModuleForTests(moduleName, "android_common").Module().VariablesForTests()
2394 flags := strings.Split(variables["javacFlags"], " ")
2395 got := ""
2396 for _, flag := range flags {
2397 keyEnd := strings.Index(flag, "=")
2398 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
2399 got = flag[keyEnd+1:]
2400 break
2401 }
2402 }
2403 if expected != got {
2404 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
2405 }
2406}
2407
2408func TestPatchModule(t *testing.T) {
Pete Gillin0c2143e2019-05-02 15:32:11 +01002409 t.Run("Java language level 8", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01002410 // Test with legacy javac -source 1.8 -target 1.8
Pete Gillinbdf5d712019-10-21 14:29:58 +01002411 bp := `
2412 java_library {
2413 name: "foo",
2414 srcs: ["a.java"],
2415 java_version: "1.8",
2416 }
2417
2418 java_library {
2419 name: "bar",
2420 srcs: ["b.java"],
2421 sdk_version: "none",
2422 system_modules: "none",
2423 patch_module: "java.base",
2424 java_version: "1.8",
2425 }
2426
2427 java_library {
2428 name: "baz",
2429 srcs: ["c.java"],
2430 patch_module: "java.base",
2431 java_version: "1.8",
2432 }
2433 `
2434 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002435
2436 checkPatchModuleFlag(t, ctx, "foo", "")
2437 checkPatchModuleFlag(t, ctx, "bar", "")
2438 checkPatchModuleFlag(t, ctx, "baz", "")
2439 })
2440
Pete Gillin0c2143e2019-05-02 15:32:11 +01002441 t.Run("Java language level 9", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01002442 // Test with default javac -source 9 -target 9
Pete Gillinbdf5d712019-10-21 14:29:58 +01002443 bp := `
2444 java_library {
2445 name: "foo",
2446 srcs: ["a.java"],
2447 }
2448
2449 java_library {
2450 name: "bar",
2451 srcs: ["b.java"],
2452 sdk_version: "none",
2453 system_modules: "none",
2454 patch_module: "java.base",
2455 }
2456
2457 java_library {
2458 name: "baz",
Jingwen Chen5136a6e2020-10-30 01:01:35 -04002459 srcs: [
2460 "c.java",
2461 // Tests for b/150878007
2462 "dir/d.java",
2463 "dir2/e.java",
2464 "dir2/f.java",
2465 "nested/dir/g.java"
2466 ],
Pete Gillinbdf5d712019-10-21 14:29:58 +01002467 patch_module: "java.base",
2468 }
2469 `
Pete Gillin1b3370f2019-10-01 13:57:31 +01002470 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002471
2472 checkPatchModuleFlag(t, ctx, "foo", "")
2473 expected := "java.base=.:" + buildDir
2474 checkPatchModuleFlag(t, ctx, "bar", expected)
Jingwen Chen5136a6e2020-10-30 01:01:35 -04002475 expected = "java.base=" + strings.Join([]string{
Paul Duffin95bdab42021-03-08 21:48:46 +00002476 ".", buildDir, "dir", "dir2", "nested", defaultModuleToPath("ext"), defaultModuleToPath("framework")}, ":")
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002477 checkPatchModuleFlag(t, ctx, "baz", expected)
2478 })
2479}
Paul Duffina7b9f422020-01-10 17:12:18 +00002480
Paul Duffin83a2d962019-11-19 19:44:10 +00002481func TestJavaLibraryWithSystemModules(t *testing.T) {
2482 ctx, _ := testJava(t, `
2483 java_library {
2484 name: "lib-with-source-system-modules",
2485 srcs: [
2486 "a.java",
2487 ],
2488 sdk_version: "none",
2489 system_modules: "source-system-modules",
2490 }
2491
2492 java_library {
2493 name: "source-jar",
2494 srcs: [
2495 "a.java",
2496 ],
2497 }
2498
2499 java_system_modules {
2500 name: "source-system-modules",
2501 libs: ["source-jar"],
2502 }
2503
2504 java_library {
2505 name: "lib-with-prebuilt-system-modules",
2506 srcs: [
2507 "a.java",
2508 ],
2509 sdk_version: "none",
2510 system_modules: "prebuilt-system-modules",
2511 }
2512
2513 java_import {
2514 name: "prebuilt-jar",
2515 jars: ["a.jar"],
2516 }
2517
2518 java_system_modules_import {
2519 name: "prebuilt-system-modules",
2520 libs: ["prebuilt-jar"],
2521 }
2522 `)
2523
2524 checkBootClasspathForSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar")
2525
2526 checkBootClasspathForSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar")
2527}
2528
2529func checkBootClasspathForSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) {
2530 javacRule := ctx.ModuleForTests(moduleName, "android_common").Rule("javac")
2531 bootClasspath := javacRule.Args["bootClasspath"]
2532 if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) {
2533 t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath)
2534 }
2535}
Jiyong Park19604de2020-03-24 16:44:11 +09002536
2537func TestAidlExportIncludeDirsFromImports(t *testing.T) {
2538 ctx, _ := testJava(t, `
2539 java_library {
2540 name: "foo",
2541 srcs: ["aidl/foo/IFoo.aidl"],
2542 libs: ["bar"],
2543 }
2544
2545 java_import {
2546 name: "bar",
2547 jars: ["a.jar"],
2548 aidl: {
2549 export_include_dirs: ["aidl/bar"],
2550 },
2551 }
2552 `)
2553
2554 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
2555 expectedAidlFlag := "-Iaidl/bar"
2556 if !strings.Contains(aidlCommand, expectedAidlFlag) {
2557 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
2558 }
2559}
Liz Kammerdd849a82020-06-12 16:38:45 -07002560
Jooyung Hane197d8b2021-01-05 10:33:16 +09002561func TestAidlFlagsArePassedToTheAidlCompiler(t *testing.T) {
2562 ctx, _ := testJava(t, `
2563 java_library {
2564 name: "foo",
2565 srcs: ["aidl/foo/IFoo.aidl"],
2566 aidl: { flags: ["-Werror"], },
2567 }
2568 `)
2569
2570 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
2571 expectedAidlFlag := "-Werror"
2572 if !strings.Contains(aidlCommand, expectedAidlFlag) {
2573 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
2574 }
2575}
2576
Liz Kammerdd849a82020-06-12 16:38:45 -07002577func TestDataNativeBinaries(t *testing.T) {
Colin Crossaa255532020-07-03 13:18:24 -07002578 ctx, _ := testJava(t, `
Liz Kammerdd849a82020-06-12 16:38:45 -07002579 java_test_host {
2580 name: "foo",
2581 srcs: ["a.java"],
2582 data_native_bins: ["bin"]
2583 }
2584
2585 python_binary_host {
2586 name: "bin",
2587 srcs: ["bin.py"],
2588 }
2589 `)
2590
2591 buildOS := android.BuildOs.String()
2592
2593 test := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
Colin Crossaa255532020-07-03 13:18:24 -07002594 entries := android.AndroidMkEntriesForTest(t, ctx, test)[0]
Liz Kammerdd849a82020-06-12 16:38:45 -07002595 expected := []string{buildDir + "/.intermediates/bin/" + buildOS + "_x86_64_PY3/bin:bin"}
2596 actual := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
2597 if !reflect.DeepEqual(expected, actual) {
2598 t.Errorf("Unexpected test data - expected: %q, actual: %q", expected, actual)
2599 }
2600}
Yuexi Ma627263f2021-03-04 13:47:56 -08002601
2602func TestDefaultInstallable(t *testing.T) {
2603 ctx, _ := testJava(t, `
2604 java_test_host {
2605 name: "foo"
2606 }
2607 `)
2608
2609 buildOS := android.BuildOs.String()
2610 module := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
2611 assertDeepEquals(t, "Default installable value should be true.", proptools.BoolPtr(true),
2612 module.properties.Installable)
2613}