blob: 41f57f2dfbdcbee2ed043b45aad16a64b955436e [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Colin Cross72bb3632017-07-13 16:23:21 -070018 "io/ioutil"
19 "os"
20 "path/filepath"
Colin Crossc0806172019-06-14 18:51:47 -070021 "reflect"
Paul Duffindaaa3322020-05-26 18:13:57 +010022 "regexp"
Paul Duffin859fe962020-05-15 10:20:31 +010023 "sort"
Nan Zhang61eaedb2017-11-02 13:28:15 -070024 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070025 "strings"
26 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070027
Jeongik Cha28df2572019-11-11 10:46:36 +090028 "github.com/google/blueprint/proptools"
29
Colin Crossa4f08812018-10-02 22:03:40 -070030 "android/soong/android"
31 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080032 "android/soong/dexpreopt"
Colin Crossa4f08812018-10-02 22:03:40 -070033 "android/soong/genrule"
Liz Kammerdd849a82020-06-12 16:38:45 -070034 "android/soong/python"
Colin Cross72bb3632017-07-13 16:23:21 -070035)
36
37var buildDir string
38
39func setUp() {
40 var err error
41 buildDir, err = ioutil.TempDir("", "soong_java_test")
42 if err != nil {
43 panic(err)
44 }
45}
46
47func tearDown() {
48 os.RemoveAll(buildDir)
49}
50
51func TestMain(m *testing.M) {
52 run := func() int {
53 setUp()
54 defer tearDown()
55
56 return m.Run()
57 }
58
59 os.Exit(run())
60}
Colin Cross527012a2017-11-30 22:56:16 -080061
Colin Cross98be1bb2019-12-13 20:41:13 -080062func testConfig(env map[string]string, bp string, fs map[string][]byte) android.Config {
Martin Stjernholmd90676f2020-01-11 00:37:30 +000063 bp += dexpreopt.BpToolModulesForTest()
64
Martin Stjernholm75a48d82020-01-10 20:32:59 +000065 config := TestConfig(buildDir, env, bp, fs)
66
67 // Set up the global Once cache used for dexpreopt.GlobalSoongConfig, so that
68 // it doesn't create a real one, which would fail.
69 _ = dexpreopt.GlobalSoongConfigForTests(config)
70
71 return config
Colin Cross1369cdb2017-09-29 17:58:17 -070072}
73
Colin Cross98be1bb2019-12-13 20:41:13 -080074func testContext() *android.TestContext {
Colin Cross72bb3632017-07-13 16:23:21 -070075
Colin Cross4c428df2017-09-15 17:36:05 -070076 ctx := android.NewTestArchContext()
Paul Duffinf9b1da02019-12-18 19:51:55 +000077 RegisterJavaBuildComponents(ctx)
78 RegisterAppBuildComponents(ctx)
79 RegisterAARBuildComponents(ctx)
Paul Duffinb0f85072019-12-19 10:28:56 +000080 RegisterGenRuleBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000081 RegisterSystemModulesBuildComponents(ctx)
Colin Cross4b49b762019-11-22 15:25:03 -080082 ctx.RegisterModuleType("java_plugin", PluginFactory)
Colin Cross4b49b762019-11-22 15:25:03 -080083 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
84 ctx.RegisterModuleType("genrule", genrule.GenRuleFactory)
Liz Kammerdd849a82020-06-12 16:38:45 -070085 ctx.RegisterModuleType("python_binary_host", python.PythonBinaryHostFactory)
Paul Duffin884363e2019-12-19 10:21:09 +000086 RegisterDocsBuildComponents(ctx)
87 RegisterStubsBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000088 RegisterSdkLibraryBuildComponents(ctx)
Colin Cross89536d42017-07-07 14:35:50 -070089 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Paul Duffin44f1d842020-06-26 20:17:02 +010090 ctx.PreArchMutators(android.RegisterComponentsMutator)
Paul Duffina48f7582019-12-19 11:25:19 +000091
92 RegisterPrebuiltApisBuildComponents(ctx)
93
Liz Kammerdd849a82020-06-12 16:38:45 -070094 ctx.PreDepsMutators(python.RegisterPythonPreDepsMutators)
Jaewoong Jungb639a6a2019-05-10 15:16:29 -070095 ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
Colin Cross3bc7ffa2017-11-22 16:19:37 -080096 ctx.RegisterPreSingletonType("overlay", android.SingletonFactoryAdaptor(OverlaySingletonFactory))
Colin Cross3047fa22019-04-18 10:56:44 -070097 ctx.RegisterPreSingletonType("sdk_versions", android.SingletonFactoryAdaptor(sdkPreSingletonFactory))
Colin Crossa4f08812018-10-02 22:03:40 -070098
Paul Duffin021f4e52020-07-30 16:04:17 +010099 android.RegisterPrebuiltMutators(ctx)
100
Colin Crossa4f08812018-10-02 22:03:40 -0700101 // Register module types and mutators from cc needed for JNI testing
Paul Duffin77980a82019-12-19 16:01:36 +0000102 cc.RegisterRequiredBuildComponentsForTest(ctx)
Colin Crossa4f08812018-10-02 22:03:40 -0700103
Martin Stjernholmd90676f2020-01-11 00:37:30 +0000104 dexpreopt.RegisterToolModulesForTest(ctx)
105
Colin Cross527012a2017-11-30 22:56:16 -0800106 return ctx
107}
108
109func run(t *testing.T, ctx *android.TestContext, config android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800110 t.Helper()
Colin Crossc28bb0b2019-02-25 14:20:47 -0800111
Colin Cross98be1bb2019-12-13 20:41:13 -0800112 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000113 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Colin Crossc28bb0b2019-02-25 14:20:47 -0800114
Colin Cross98be1bb2019-12-13 20:41:13 -0800115 ctx.Register(config)
Paul Duffinbaccf7e2019-06-11 11:58:30 +0100116 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
Logan Chien42039712018-03-12 16:29:17 +0800117 android.FailIfErrored(t, errs)
Colin Cross72bb3632017-07-13 16:23:21 -0700118 _, errs = ctx.PrepareBuildActions(config)
Logan Chien42039712018-03-12 16:29:17 +0800119 android.FailIfErrored(t, errs)
Colin Cross527012a2017-11-30 22:56:16 -0800120}
121
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900122func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) {
Jeongik Cha538c0d02019-07-11 15:54:27 +0900123 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800124 return testJavaErrorWithConfig(t, pattern, testConfig(nil, bp, nil))
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900125}
126
Colin Cross98be1bb2019-12-13 20:41:13 -0800127func testJavaErrorWithConfig(t *testing.T, pattern string, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900128 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800129 ctx := testContext()
Jeongik Cha538c0d02019-07-11 15:54:27 +0900130
Colin Cross98be1bb2019-12-13 20:41:13 -0800131 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000132 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Jeongik Cha538c0d02019-07-11 15:54:27 +0900133
Colin Cross98be1bb2019-12-13 20:41:13 -0800134 ctx.Register(config)
Jeongik Cha538c0d02019-07-11 15:54:27 +0900135 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
136 if len(errs) > 0 {
137 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900138 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900139 }
140 _, errs = ctx.PrepareBuildActions(config)
141 if len(errs) > 0 {
142 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900143 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900144 }
145
146 t.Fatalf("missing expected error %q (0 errors are returned)", pattern)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900147
148 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900149}
150
Colin Cross238c1f32020-06-07 16:58:18 -0700151func testJavaWithFS(t *testing.T, bp string, fs map[string][]byte) (*android.TestContext, android.Config) {
152 t.Helper()
153 return testJavaWithConfig(t, testConfig(nil, bp, fs))
154}
155
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700156func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800157 t.Helper()
Colin Cross238c1f32020-06-07 16:58:18 -0700158 return testJavaWithFS(t, bp, nil)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900159}
160
Colin Cross98be1bb2019-12-13 20:41:13 -0800161func testJavaWithConfig(t *testing.T, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900162 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800163 ctx := testContext()
Colin Cross527012a2017-11-30 22:56:16 -0800164 run(t, ctx, config)
Colin Cross72bb3632017-07-13 16:23:21 -0700165
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700166 return ctx, config
Colin Cross72bb3632017-07-13 16:23:21 -0700167}
168
Colin Cross2acdae82017-09-15 19:44:24 -0700169func moduleToPath(name string) string {
170 switch {
171 case name == `""`:
172 return name
Colin Crossfc3674a2017-09-18 17:41:52 -0700173 case strings.HasSuffix(name, ".jar"):
174 return name
Nan Zhanged19fc32017-10-19 13:06:22 -0700175 default:
176 return filepath.Join(buildDir, ".intermediates", name, "android_common", "turbine-combined", name+".jar")
Colin Cross2acdae82017-09-15 19:44:24 -0700177 }
178}
179
Jeongik Chae403e9e2019-12-07 00:16:24 +0900180func TestJavaLinkType(t *testing.T) {
181 testJava(t, `
182 java_library {
183 name: "foo",
184 srcs: ["a.java"],
185 libs: ["bar"],
186 static_libs: ["baz"],
187 }
188
189 java_library {
190 name: "bar",
191 sdk_version: "current",
192 srcs: ["b.java"],
193 }
194
195 java_library {
196 name: "baz",
197 sdk_version: "system_current",
198 srcs: ["c.java"],
199 }
200 `)
201
202 testJavaError(t, "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source.", `
203 java_library {
204 name: "foo",
205 srcs: ["a.java"],
206 libs: ["bar"],
207 sdk_version: "current",
208 static_libs: ["baz"],
209 }
210
211 java_library {
212 name: "bar",
213 sdk_version: "current",
214 srcs: ["b.java"],
215 }
216
217 java_library {
218 name: "baz",
219 sdk_version: "system_current",
220 srcs: ["c.java"],
221 }
222 `)
223
224 testJava(t, `
225 java_library {
226 name: "foo",
227 srcs: ["a.java"],
228 libs: ["bar"],
229 sdk_version: "system_current",
230 static_libs: ["baz"],
231 }
232
233 java_library {
234 name: "bar",
235 sdk_version: "current",
236 srcs: ["b.java"],
237 }
238
239 java_library {
240 name: "baz",
241 sdk_version: "system_current",
242 srcs: ["c.java"],
243 }
244 `)
245
246 testJavaError(t, "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source.", `
247 java_library {
248 name: "foo",
249 srcs: ["a.java"],
250 libs: ["bar"],
251 sdk_version: "system_current",
252 static_libs: ["baz"],
253 }
254
255 java_library {
256 name: "bar",
257 sdk_version: "current",
258 srcs: ["b.java"],
259 }
260
261 java_library {
262 name: "baz",
263 srcs: ["c.java"],
264 }
265 `)
266}
267
Colin Cross72bb3632017-07-13 16:23:21 -0700268func TestSimple(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700269 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700270 java_library {
271 name: "foo",
272 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700273 libs: ["bar"],
274 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700275 }
276
277 java_library {
278 name: "bar",
279 srcs: ["b.java"],
280 }
281
282 java_library {
283 name: "baz",
284 srcs: ["c.java"],
285 }
Colin Crossd5934c82017-10-02 13:55:26 -0700286 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700287
Colin Cross4c428df2017-09-15 17:36:05 -0700288 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700289 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700290
291 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
292 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
293 }
294
Colin Cross1ee23172017-10-18 14:44:18 -0700295 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Nan Zhanged19fc32017-10-19 13:06:22 -0700296 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
297 bazTurbine := filepath.Join(buildDir, ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700298
Nan Zhanged19fc32017-10-19 13:06:22 -0700299 if !strings.Contains(javac.Args["classpath"], barTurbine) {
300 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700301 }
302
Nan Zhanged19fc32017-10-19 13:06:22 -0700303 if !strings.Contains(javac.Args["classpath"], bazTurbine) {
304 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700305 }
306
307 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
308 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700309 }
310}
311
Artur Satayev9cf46692019-11-26 18:08:34 +0000312func TestExportedPlugins(t *testing.T) {
313 type Result struct {
314 library string
315 processors string
316 }
317 var tests = []struct {
318 name string
319 extra string
320 results []Result
321 }{
322 {
323 name: "Exported plugin is not a direct plugin",
324 extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`,
325 results: []Result{{library: "exports", processors: "-proc:none"}},
326 },
327 {
328 name: "Exports plugin to dependee",
329 extra: `
330 java_library{name: "exports", exported_plugins: ["plugin"]}
331 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
332 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
333 `,
334 results: []Result{
335 {library: "foo", processors: "-processor com.android.TestPlugin"},
336 {library: "bar", processors: "-processor com.android.TestPlugin"},
337 },
338 },
339 {
340 name: "Exports plugin to android_library",
341 extra: `
342 java_library{name: "exports", exported_plugins: ["plugin"]}
343 android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
344 android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
345 `,
346 results: []Result{
347 {library: "foo", processors: "-processor com.android.TestPlugin"},
348 {library: "bar", processors: "-processor com.android.TestPlugin"},
349 },
350 },
351 {
352 name: "Exports plugin is not propagated via transitive deps",
353 extra: `
354 java_library{name: "exports", exported_plugins: ["plugin"]}
355 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
356 java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]}
357 `,
358 results: []Result{
359 {library: "foo", processors: "-processor com.android.TestPlugin"},
360 {library: "bar", processors: "-proc:none"},
361 },
362 },
363 {
364 name: "Exports plugin appends to plugins",
365 extra: `
366 java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"}
367 java_library{name: "exports", exported_plugins: ["plugin"]}
368 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]}
369 `,
370 results: []Result{
371 {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"},
372 },
373 },
374 }
375
376 for _, test := range tests {
377 t.Run(test.name, func(t *testing.T) {
378 ctx, _ := testJava(t, `
379 java_plugin {
380 name: "plugin",
381 processor_class: "com.android.TestPlugin",
382 }
383 `+test.extra)
384
385 for _, want := range test.results {
386 javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac")
387 if javac.Args["processor"] != want.processors {
388 t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"])
389 }
390 }
391 })
392 }
393}
394
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900395func TestSdkVersionByPartition(t *testing.T) {
396 testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900397 java_library {
398 name: "foo",
399 srcs: ["a.java"],
400 vendor: true,
401 }
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900402 `)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900403
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900404 testJava(t, `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900405 java_library {
406 name: "bar",
407 srcs: ["b.java"],
408 }
409 `)
410
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900411 for _, enforce := range []bool{true, false} {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900412 bp := `
413 java_library {
414 name: "foo",
415 srcs: ["a.java"],
416 product_specific: true,
417 }
418 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800419
420 config := testConfig(nil, bp, nil)
421 config.TestProductVariables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900422 if enforce {
Colin Cross98be1bb2019-12-13 20:41:13 -0800423 testJavaErrorWithConfig(t, "sdk_version must have a value when the module is located at vendor or product", config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900424 } else {
Colin Cross98be1bb2019-12-13 20:41:13 -0800425 testJavaWithConfig(t, config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900426 }
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900427 }
428}
429
Colin Crossd5934c82017-10-02 13:55:26 -0700430func TestArchSpecific(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700431 ctx, _ := testJava(t, `
Colin Crossd5934c82017-10-02 13:55:26 -0700432 java_library {
433 name: "foo",
434 srcs: ["a.java"],
435 target: {
436 android: {
437 srcs: ["b.java"],
438 },
439 },
440 }
441 `)
442
443 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
444 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
445 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
446 }
447}
448
Colin Cross6b4a32d2017-12-05 13:42:45 -0800449func TestBinary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700450 ctx, _ := testJava(t, `
Colin Cross6b4a32d2017-12-05 13:42:45 -0800451 java_library_host {
452 name: "foo",
453 srcs: ["a.java"],
454 }
455
456 java_binary_host {
457 name: "bar",
458 srcs: ["b.java"],
459 static_libs: ["foo"],
460 }
461 `)
462
463 buildOS := android.BuildOs.String()
464
465 bar := ctx.ModuleForTests("bar", buildOS+"_common")
466 barJar := bar.Output("bar.jar").Output.String()
467 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
468 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
469
470 // Test that the install binary wrapper depends on the installed jar file
471 if len(barWrapperDeps) != 1 || barWrapperDeps[0] != barJar {
472 t.Errorf("expected binary wrapper implicits [%q], got %v",
473 barJar, barWrapperDeps)
474 }
Alex Humesky2070e322020-06-09 20:23:08 -0400475}
Colin Cross6b4a32d2017-12-05 13:42:45 -0800476
Alex Humesky2070e322020-06-09 20:23:08 -0400477func TestHostBinaryNoJavaDebugInfoOverride(t *testing.T) {
478 bp := `
479 java_library {
480 name: "target_library",
481 srcs: ["a.java"],
482 }
483
484 java_binary_host {
485 name: "host_binary",
486 srcs: ["b.java"],
487 }
488 `
489 config := testConfig(nil, bp, nil)
490 config.TestProductVariables.MinimizeJavaDebugInfo = proptools.BoolPtr(true)
491
492 ctx, _ := testJavaWithConfig(t, config)
493
Liz Kammer7941b302020-07-28 13:27:34 -0700494 // first, check that the -g flag is added to target modules
Alex Humesky2070e322020-06-09 20:23:08 -0400495 targetLibrary := ctx.ModuleForTests("target_library", "android_common")
496 targetJavaFlags := targetLibrary.Module().VariablesForTests()["javacFlags"]
497 if !strings.Contains(targetJavaFlags, "-g:source,lines") {
498 t.Errorf("target library javac flags %v should contain "+
499 "-g:source,lines override with MinimizeJavaDebugInfo", targetJavaFlags)
500 }
501
502 // check that -g is not overridden for host modules
503 buildOS := android.BuildOs.String()
504 hostBinary := ctx.ModuleForTests("host_binary", buildOS+"_common")
505 hostJavaFlags := hostBinary.Module().VariablesForTests()["javacFlags"]
506 if strings.Contains(hostJavaFlags, "-g:source,lines") {
507 t.Errorf("java_binary_host javac flags %v should not have "+
508 "-g:source,lines override with MinimizeJavaDebugInfo", hostJavaFlags)
509 }
Colin Cross6b4a32d2017-12-05 13:42:45 -0800510}
511
Colin Cross72bb3632017-07-13 16:23:21 -0700512func TestPrebuilts(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700513 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700514 java_library {
515 name: "foo",
Paul Duffin91547182019-11-12 19:39:36 +0000516 srcs: ["a.java", ":stubs-source"],
Paul Duffinfcfd7912020-01-31 17:54:30 +0000517 libs: ["bar", "sdklib"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700518 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700519 }
520
Colin Cross74d73e22017-08-02 11:05:49 -0700521 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700522 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700523 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700524 }
525
Colin Cross74d73e22017-08-02 11:05:49 -0700526 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700527 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700528 jars: ["b.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700529 }
Colin Cross42be7612019-02-21 18:12:14 -0800530
531 dex_import {
532 name: "qux",
533 jars: ["b.jar"],
534 }
Colin Cross79c7c262019-04-17 11:11:46 -0700535
536 java_sdk_library_import {
Paul Duffin56d44902020-01-31 13:36:25 +0000537 name: "sdklib",
538 public: {
539 jars: ["c.jar"],
540 },
541 }
542
Paul Duffin91547182019-11-12 19:39:36 +0000543 prebuilt_stubs_sources {
544 name: "stubs-source",
Paul Duffin9b478b02019-12-10 13:41:51 +0000545 srcs: ["stubs/sources"],
Paul Duffin91547182019-11-12 19:39:36 +0000546 }
Paul Duffin1b82e6a2019-12-03 18:06:47 +0000547
548 java_test_import {
549 name: "test",
550 jars: ["a.jar"],
551 test_suites: ["cts"],
552 test_config: "AndroidTest.xml",
553 }
Colin Cross72bb3632017-07-13 16:23:21 -0700554 `)
555
Paul Duffin9b478b02019-12-10 13:41:51 +0000556 fooModule := ctx.ModuleForTests("foo", "android_common")
557 javac := fooModule.Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700558 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross37f6d792018-07-12 12:28:41 -0700559 barJar := ctx.ModuleForTests("bar", "android_common").Rule("combineJar").Output
560 bazJar := ctx.ModuleForTests("baz", "android_common").Rule("combineJar").Output
Colin Cross79c7c262019-04-17 11:11:46 -0700561 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700562
Paul Duffin9b478b02019-12-10 13:41:51 +0000563 fooLibrary := fooModule.Module().(*Library)
564 assertDeepEquals(t, "foo java sources incorrect",
565 []string{"a.java"}, fooLibrary.compiledJavaSrcs.Strings())
Paul Duffin91547182019-11-12 19:39:36 +0000566
Paul Duffin9b478b02019-12-10 13:41:51 +0000567 assertDeepEquals(t, "foo java source jars incorrect",
568 []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"},
569 android.NormalizePathsForTesting(fooLibrary.compiledSrcJars))
Paul Duffin91547182019-11-12 19:39:36 +0000570
Colin Cross37f6d792018-07-12 12:28:41 -0700571 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
572 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700573 }
574
Colin Cross79c7c262019-04-17 11:11:46 -0700575 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
576 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
577 }
578
Colin Cross37f6d792018-07-12 12:28:41 -0700579 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
580 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700581 }
Colin Cross42be7612019-02-21 18:12:14 -0800582
583 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Colin Cross72bb3632017-07-13 16:23:21 -0700584}
585
Paul Duffin9b478b02019-12-10 13:41:51 +0000586func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) {
587 if !reflect.DeepEqual(expected, actual) {
588 t.Errorf("%s: expected %q, found %q", message, expected, actual)
589 }
590}
591
Paul Duffin56d44902020-01-31 13:36:25 +0000592func TestJavaSdkLibraryImport(t *testing.T) {
593 ctx, _ := testJava(t, `
594 java_library {
595 name: "foo",
596 srcs: ["a.java"],
597 libs: ["sdklib"],
598 sdk_version: "current",
599 }
600
601 java_library {
602 name: "foo.system",
603 srcs: ["a.java"],
604 libs: ["sdklib"],
605 sdk_version: "system_current",
606 }
607
608 java_library {
609 name: "foo.test",
610 srcs: ["a.java"],
611 libs: ["sdklib"],
612 sdk_version: "test_current",
613 }
614
615 java_sdk_library_import {
616 name: "sdklib",
617 public: {
618 jars: ["a.jar"],
619 },
620 system: {
621 jars: ["b.jar"],
622 },
623 test: {
624 jars: ["c.jar"],
Paul Duffin0f8faff2020-05-20 16:18:00 +0100625 stub_srcs: ["c.java"],
Paul Duffin56d44902020-01-31 13:36:25 +0000626 },
627 }
628 `)
629
630 for _, scope := range []string{"", ".system", ".test"} {
631 fooModule := ctx.ModuleForTests("foo"+scope, "android_common")
632 javac := fooModule.Rule("javac")
633
634 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs"+scope, "android_common").Rule("combineJar").Output
635 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
636 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
637 }
638 }
Paul Duffinca8d9a52020-06-26 22:20:25 +0100639
Paul Duffincee7e662020-07-09 17:32:57 +0100640 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100641 `prebuilt_sdklib.stubs`,
642 `prebuilt_sdklib.stubs.source.test`,
643 `prebuilt_sdklib.stubs.system`,
644 `prebuilt_sdklib.stubs.test`,
645 })
646}
647
648func TestJavaSdkLibraryImport_WithSource(t *testing.T) {
649 ctx, _ := testJava(t, `
650 java_sdk_library {
651 name: "sdklib",
652 srcs: ["a.java"],
653 sdk_version: "none",
654 system_modules: "none",
655 public: {
656 enabled: true,
657 },
658 }
659
660 java_sdk_library_import {
661 name: "sdklib",
662 public: {
663 jars: ["a.jar"],
664 },
665 }
666 `)
667
Paul Duffincee7e662020-07-09 17:32:57 +0100668 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100669 `dex2oatd`,
670 `prebuilt_sdklib`,
671 `sdklib.impl`,
672 `sdklib.stubs`,
673 `sdklib.stubs.source`,
674 `sdklib.xml`,
675 })
676
Paul Duffincee7e662020-07-09 17:32:57 +0100677 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffin44f1d842020-06-26 20:17:02 +0100678 `prebuilt_sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100679 `sdklib.impl`,
680 // This should be prebuilt_sdklib.stubs but is set to sdklib.stubs because the
681 // dependency is added after prebuilts may have been renamed and so has to use
682 // the renamed name.
Paul Duffinca8d9a52020-06-26 22:20:25 +0100683 `sdklib.xml`,
684 })
685}
686
687func TestJavaSdkLibraryImport_Preferred(t *testing.T) {
688 ctx, _ := testJava(t, `
689 java_sdk_library {
690 name: "sdklib",
691 srcs: ["a.java"],
692 sdk_version: "none",
693 system_modules: "none",
694 public: {
695 enabled: true,
696 },
697 }
698
699 java_sdk_library_import {
700 name: "sdklib",
701 prefer: true,
702 public: {
703 jars: ["a.jar"],
704 },
705 }
706 `)
707
Paul Duffincee7e662020-07-09 17:32:57 +0100708 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100709 `dex2oatd`,
710 `prebuilt_sdklib`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100711 `sdklib.impl`,
Paul Duffin80342d72020-06-26 22:08:43 +0100712 `sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100713 `sdklib.stubs.source`,
714 `sdklib.xml`,
715 })
716
Paul Duffincee7e662020-07-09 17:32:57 +0100717 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100718 `prebuilt_sdklib.stubs`,
719 `sdklib.impl`,
720 `sdklib.xml`,
721 })
Paul Duffin56d44902020-01-31 13:36:25 +0000722}
723
Colin Cross89536d42017-07-07 14:35:50 -0700724func TestDefaults(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700725 ctx, _ := testJava(t, `
Colin Cross89536d42017-07-07 14:35:50 -0700726 java_defaults {
727 name: "defaults",
728 srcs: ["a.java"],
729 libs: ["bar"],
730 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -0700731 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700732 }
733
734 java_library {
735 name: "foo",
736 defaults: ["defaults"],
737 }
738
739 java_library {
740 name: "bar",
741 srcs: ["b.java"],
742 }
743
744 java_library {
745 name: "baz",
746 srcs: ["c.java"],
747 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700748
749 android_test {
750 name: "atestOptimize",
751 defaults: ["defaults"],
752 optimize: {enabled: true},
753 }
754
755 android_test {
756 name: "atestNoOptimize",
757 defaults: ["defaults"],
758 }
759
760 android_test {
761 name: "atestDefault",
762 srcs: ["a.java"],
763 }
Colin Cross89536d42017-07-07 14:35:50 -0700764 `)
765
Colin Cross4c428df2017-09-15 17:36:05 -0700766 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700767 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -0700768
769 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
770 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
771 }
772
Nan Zhanged19fc32017-10-19 13:06:22 -0700773 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
774 if !strings.Contains(javac.Args["classpath"], barTurbine) {
775 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -0700776 }
777
Colin Cross1ee23172017-10-18 14:44:18 -0700778 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -0700779 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
780 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -0700781 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700782
783 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
784 if atestOptimize.Output == nil {
785 t.Errorf("atestOptimize should optimize APK")
786 }
787
788 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
789 if atestNoOptimize.Output == nil {
790 t.Errorf("atestNoOptimize should not optimize APK")
791 }
792
793 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("r8")
794 if atestDefault.Output == nil {
795 t.Errorf("atestDefault should optimize APK")
796 }
Colin Cross89536d42017-07-07 14:35:50 -0700797}
798
Colin Cross0f37af02017-09-27 17:42:05 -0700799func TestResources(t *testing.T) {
800 var table = []struct {
801 name string
802 prop string
803 extra string
804 args string
805 }{
806 {
Colin Crossaf9c55b2017-10-03 14:50:08 -0700807 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -0700808 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -0800809 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700810 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700811 },
812 {
813 // Test that a module with java_resources includes the files
814 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -0700815 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
816 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700817 },
818 {
819 // Test that a module with a filegroup in java_resources includes the files with the
820 // path prefix
821 name: "resource filegroup",
822 prop: `java_resources: [":foo-res"]`,
823 extra: `
824 filegroup {
825 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -0800826 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -0700827 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -0700828 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700829 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700830 },
831 {
Colin Cross0ead1d72018-04-10 13:07:42 -0700832 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
833 name: "wildcard dirs",
834 prop: `java_resource_dirs: ["java-res/*"]`,
835 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
836 },
837 {
838 // Test that a module exclude_java_resource_dirs excludes the files
839 name: "wildcard dirs",
840 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
841 args: "-C java-res/a -f java-res/a/a",
842 },
Colin Crosscedd4762018-09-13 11:26:19 -0700843 {
844 // Test wildcards in java_resources
845 name: "wildcard files",
846 prop: `java_resources: ["java-res/**/*"]`,
847 args: "-C . -f java-res/a/a -f java-res/b/b",
848 },
849 {
850 // Test exclude_java_resources with java_resources
851 name: "wildcard files with exclude",
852 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
853 args: "-C . -f java-res/a/a",
854 },
855 {
856 // Test exclude_java_resources with java_resource_dirs
857 name: "resource dirs with exclude files",
858 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
859 args: "-C java-res -f java-res/a/a",
860 },
861 {
862 // Test exclude_java_resource_dirs with java_resource_dirs
863 name: "resource dirs with exclude files",
864 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
865 args: "-C java-res -f java-res/a/a -f java-res/b/b",
866 },
Colin Cross0f37af02017-09-27 17:42:05 -0700867 }
868
869 for _, test := range table {
870 t.Run(test.name, func(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700871 ctx, _ := testJavaWithFS(t, `
Colin Cross0f37af02017-09-27 17:42:05 -0700872 java_library {
873 name: "foo",
874 srcs: [
875 "a.java",
876 "b.java",
877 "c.java",
878 ],
879 `+test.prop+`,
880 }
Colin Cross238c1f32020-06-07 16:58:18 -0700881 `+test.extra,
882 map[string][]byte{
883 "java-res/a/a": nil,
884 "java-res/b/b": nil,
885 "java-res2/a": nil,
886 },
887 )
Colin Cross0f37af02017-09-27 17:42:05 -0700888
Colin Cross331a1212018-08-15 20:40:52 -0700889 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -0700890 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -0700891
892 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
893 t.Errorf("foo combined jars %v does not contain %q",
894 foo.Inputs.Strings(), fooRes.Output.String())
895 }
896
Colin Crossaf9c55b2017-10-03 14:50:08 -0700897 if fooRes.Args["jarArgs"] != test.args {
898 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -0700899 fooRes.Args["jarArgs"], test.args)
900 }
901 })
902 }
903}
904
Colin Cross0c4ce212019-05-03 15:28:19 -0700905func TestIncludeSrcs(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700906 ctx, _ := testJavaWithFS(t, `
Colin Cross0c4ce212019-05-03 15:28:19 -0700907 java_library {
908 name: "foo",
909 srcs: [
910 "a.java",
911 "b.java",
912 "c.java",
913 ],
914 include_srcs: true,
915 }
916
917 java_library {
918 name: "bar",
919 srcs: [
920 "a.java",
921 "b.java",
922 "c.java",
923 ],
924 java_resource_dirs: ["java-res"],
925 include_srcs: true,
926 }
Colin Cross238c1f32020-06-07 16:58:18 -0700927 `, map[string][]byte{
928 "java-res/a/a": nil,
929 "java-res/b/b": nil,
930 "java-res2/a": nil,
931 })
Colin Cross0c4ce212019-05-03 15:28:19 -0700932
933 // Test a library with include_srcs: true
934 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
935 fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar")
936
937 if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) {
938 t.Errorf("foo combined jars %v does not contain %q", w, g)
939 }
940
941 if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
942 t.Errorf("foo source jar args %q is not %q", w, g)
943 }
944
945 // Test a library with include_srcs: true and resources
946 bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar")
947 barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar")
948 barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar")
949 barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar")
950
951 if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
952 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
953 }
954
955 if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
956 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
957 }
958
959 if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) {
960 t.Errorf("bar combined jars %v does not contain %q", w, g)
961 }
962
963 if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
964 t.Errorf("bar source jar args %q is not %q", w, g)
965 }
966
967 if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w {
968 t.Errorf("bar resource jar args %q is not %q", w, g)
969 }
970}
971
Colin Cross54190b32017-10-09 15:34:10 -0700972func TestGeneratedSources(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700973 ctx, _ := testJavaWithFS(t, `
Colin Cross54190b32017-10-09 15:34:10 -0700974 java_library {
975 name: "foo",
976 srcs: [
977 "a*.java",
978 ":gen",
979 "b*.java",
980 ],
981 }
982
983 genrule {
984 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -0800985 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -0700986 out: ["gen.java"],
987 }
Colin Cross238c1f32020-06-07 16:58:18 -0700988 `, map[string][]byte{
989 "a.java": nil,
990 "b.java": nil,
991 })
Colin Cross54190b32017-10-09 15:34:10 -0700992
993 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
994 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
995
Colin Cross15e86d92017-10-20 15:07:08 -0700996 if filepath.Base(genrule.Output.String()) != "gen.java" {
997 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -0700998 }
999
1000 if len(javac.Inputs) != 3 ||
1001 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -07001002 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -07001003 javac.Inputs[2].String() != "b.java" {
1004 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
1005 }
1006}
1007
Nan Zhang61eaedb2017-11-02 13:28:15 -07001008func TestTurbine(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001009 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001010 java_library {
1011 name: "foo",
1012 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +09001013 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001014 }
1015
1016 java_library {
1017 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -08001018 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -07001019 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +09001020 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001021 }
1022
1023 java_library {
1024 name: "baz",
1025 srcs: ["c.java"],
1026 libs: ["bar"],
1027 sdk_version: "14",
1028 }
1029 `)
1030
1031 fooTurbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine")
1032 barTurbine := ctx.ModuleForTests("bar", "android_common").Rule("turbine")
1033 barJavac := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1034 barTurbineCombined := ctx.ModuleForTests("bar", "android_common").Description("for turbine")
1035 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1036
1037 if len(fooTurbine.Inputs) != 1 || fooTurbine.Inputs[0].String() != "a.java" {
1038 t.Errorf(`foo inputs %v != ["a.java"]`, fooTurbine.Inputs)
1039 }
1040
1041 fooHeaderJar := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
1042 if !strings.Contains(barTurbine.Args["classpath"], fooHeaderJar) {
1043 t.Errorf("bar turbine classpath %v does not contain %q", barTurbine.Args["classpath"], fooHeaderJar)
1044 }
1045 if !strings.Contains(barJavac.Args["classpath"], fooHeaderJar) {
1046 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], fooHeaderJar)
1047 }
1048 if len(barTurbineCombined.Inputs) != 2 || barTurbineCombined.Inputs[1].String() != fooHeaderJar {
1049 t.Errorf("bar turbine combineJar inputs %v does not contain %q", barTurbineCombined.Inputs, fooHeaderJar)
1050 }
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001051 if !strings.Contains(bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") {
Nan Zhang61eaedb2017-11-02 13:28:15 -07001052 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001053 "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -07001054 }
1055}
1056
1057func TestSharding(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001058 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001059 java_library {
1060 name: "bar",
1061 srcs: ["a.java","b.java","c.java"],
1062 javac_shard_size: 1
1063 }
1064 `)
1065
1066 barHeaderJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
1067 for i := 0; i < 3; i++ {
1068 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
1069 if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) {
1070 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar)
1071 }
1072 }
1073}
1074
Nan Zhang581fd212018-01-10 16:06:12 -08001075func TestDroiddoc(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001076 ctx, _ := testJavaWithFS(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001077 droiddoc_exported_dir {
Dan Willemsencc090972018-02-26 14:33:31 -08001078 name: "droiddoc-templates-sdk",
1079 path: ".",
1080 }
Jiyong Park29074592019-07-07 16:27:47 +09001081 filegroup {
1082 name: "bar-doc-aidl-srcs",
1083 srcs: ["bar-doc/IBar.aidl"],
1084 path: "bar-doc",
1085 }
Nan Zhang581fd212018-01-10 16:06:12 -08001086 droiddoc {
1087 name: "bar-doc",
1088 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001089 "bar-doc/a.java",
Jiyong Park1e440682018-05-23 18:42:04 +09001090 "bar-doc/IFoo.aidl",
Jiyong Park29074592019-07-07 16:27:47 +09001091 ":bar-doc-aidl-srcs",
Nan Zhang581fd212018-01-10 16:06:12 -08001092 ],
1093 exclude_srcs: [
1094 "bar-doc/b.java"
1095 ],
Dan Willemsencc090972018-02-26 14:33:31 -08001096 custom_template: "droiddoc-templates-sdk",
Nan Zhang581fd212018-01-10 16:06:12 -08001097 hdf: [
1098 "android.whichdoc offline",
1099 ],
1100 knowntags: [
1101 "bar-doc/known_oj_tags.txt",
1102 ],
1103 proofread_file: "libcore-proofread.txt",
1104 todo_file: "libcore-docs-todo.html",
Liz Kammer585cac22020-07-06 09:12:57 -07001105 flags: ["-offlinemode -title \"libcore\""],
Nan Zhang581fd212018-01-10 16:06:12 -08001106 }
Colin Cross238c1f32020-06-07 16:58:18 -07001107 `,
1108 map[string][]byte{
1109 "bar-doc/a.java": nil,
1110 "bar-doc/b.java": nil,
1111 })
Nan Zhang581fd212018-01-10 16:06:12 -08001112
Colin Crossc0806172019-06-14 18:51:47 -07001113 barDoc := ctx.ModuleForTests("bar-doc", "android_common").Rule("javadoc")
Jiyong Park1e440682018-05-23 18:42:04 +09001114 var javaSrcs []string
Colin Crossc0806172019-06-14 18:51:47 -07001115 for _, i := range barDoc.Inputs {
Jiyong Park1e440682018-05-23 18:42:04 +09001116 javaSrcs = append(javaSrcs, i.Base())
1117 }
Colin Crossc0806172019-06-14 18:51:47 -07001118 if len(javaSrcs) != 1 || javaSrcs[0] != "a.java" {
1119 t.Errorf("inputs of bar-doc must be []string{\"a.java\"}, but was %#v.", javaSrcs)
Jiyong Park29074592019-07-07 16:27:47 +09001120 }
1121
Colin Crossc0806172019-06-14 18:51:47 -07001122 aidl := ctx.ModuleForTests("bar-doc", "android_common").Rule("aidl")
1123 if g, w := barDoc.Implicits.Strings(), aidl.Output.String(); !inList(w, g) {
1124 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
1125 }
1126
1127 if g, w := aidl.Implicits.Strings(), []string{"bar-doc/IBar.aidl", "bar-doc/IFoo.aidl"}; !reflect.DeepEqual(w, g) {
1128 t.Errorf("aidl inputs must be %q, but was %q", w, g)
Jiyong Park1e440682018-05-23 18:42:04 +09001129 }
Nan Zhang581fd212018-01-10 16:06:12 -08001130}
1131
Liz Kammer585cac22020-07-06 09:12:57 -07001132func TestDroiddocArgsAndFlagsCausesError(t *testing.T) {
1133 testJavaError(t, "flags is set. Cannot set args", `
1134 droiddoc_exported_dir {
1135 name: "droiddoc-templates-sdk",
1136 path: ".",
1137 }
1138 filegroup {
1139 name: "bar-doc-aidl-srcs",
1140 srcs: ["bar-doc/IBar.aidl"],
1141 path: "bar-doc",
1142 }
1143 droiddoc {
1144 name: "bar-doc",
1145 srcs: [
1146 "bar-doc/a.java",
1147 "bar-doc/IFoo.aidl",
1148 ":bar-doc-aidl-srcs",
1149 ],
1150 exclude_srcs: [
1151 "bar-doc/b.java"
1152 ],
1153 custom_template: "droiddoc-templates-sdk",
1154 hdf: [
1155 "android.whichdoc offline",
1156 ],
1157 knowntags: [
1158 "bar-doc/known_oj_tags.txt",
1159 ],
1160 proofread_file: "libcore-proofread.txt",
1161 todo_file: "libcore-docs-todo.html",
1162 flags: ["-offlinemode -title \"libcore\""],
1163 args: "-offlinemode -title \"libcore\"",
1164 }
1165 `)
1166}
1167
Paul Duffin83a2d962019-11-19 19:44:10 +00001168func TestDroidstubsWithSystemModules(t *testing.T) {
1169 ctx, _ := testJava(t, `
1170 droidstubs {
1171 name: "stubs-source-system-modules",
1172 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001173 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001174 ],
1175 sdk_version: "none",
1176 system_modules: "source-system-modules",
1177 }
1178
1179 java_library {
1180 name: "source-jar",
1181 srcs: [
1182 "a.java",
1183 ],
1184 }
1185
1186 java_system_modules {
1187 name: "source-system-modules",
1188 libs: ["source-jar"],
1189 }
1190
1191 droidstubs {
1192 name: "stubs-prebuilt-system-modules",
1193 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001194 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001195 ],
1196 sdk_version: "none",
1197 system_modules: "prebuilt-system-modules",
1198 }
1199
1200 java_import {
1201 name: "prebuilt-jar",
1202 jars: ["a.jar"],
1203 }
1204
1205 java_system_modules_import {
1206 name: "prebuilt-system-modules",
1207 libs: ["prebuilt-jar"],
1208 }
1209 `)
1210
1211 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-source-system-modules", "source-jar.jar")
1212
1213 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-prebuilt-system-modules", "prebuilt-jar.jar")
1214}
1215
1216func checkSystemModulesUseByDroidstubs(t *testing.T, ctx *android.TestContext, moduleName string, systemJar string) {
1217 metalavaRule := ctx.ModuleForTests(moduleName, "android_common").Rule("metalava")
1218 var systemJars []string
1219 for _, i := range metalavaRule.Implicits {
1220 systemJars = append(systemJars, i.Base())
1221 }
Ramy Medhatc7965cd2020-04-30 03:08:37 -04001222 if len(systemJars) < 1 || systemJars[0] != systemJar {
Paul Duffin83a2d962019-11-19 19:44:10 +00001223 t.Errorf("inputs of %q must be []string{%q}, but was %#v.", moduleName, systemJar, systemJars)
1224 }
1225}
1226
Colin Cross54250902017-12-05 09:28:08 -08001227func TestJarGenrules(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001228 ctx, _ := testJava(t, `
Colin Cross54250902017-12-05 09:28:08 -08001229 java_library {
1230 name: "foo",
1231 srcs: ["a.java"],
1232 }
1233
1234 java_genrule {
1235 name: "jargen",
1236 tool_files: ["b.java"],
1237 cmd: "$(location b.java) $(in) $(out)",
1238 out: ["jargen.jar"],
1239 srcs: [":foo"],
1240 }
1241
1242 java_library {
1243 name: "bar",
1244 static_libs: ["jargen"],
1245 srcs: ["c.java"],
1246 }
1247
1248 java_library {
1249 name: "baz",
1250 libs: ["jargen"],
1251 srcs: ["c.java"],
1252 }
1253 `)
1254
1255 foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar")
1256 jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar")
1257 bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar")
1258 baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar")
1259 barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar")
1260
1261 if len(jargen.Inputs) != 1 || jargen.Inputs[0].String() != foo.Output.String() {
1262 t.Errorf("expected jargen inputs [%q], got %q", foo.Output.String(), jargen.Inputs.Strings())
1263 }
1264
1265 if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) {
1266 t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String())
1267 }
1268
1269 if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) {
1270 t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String())
1271 }
1272
1273 if len(barCombined.Inputs) != 2 ||
1274 barCombined.Inputs[0].String() != bar.Output.String() ||
1275 barCombined.Inputs[1].String() != jargen.Output.String() {
1276 t.Errorf("bar combined jar inputs %v is not [%q, %q]",
1277 barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String())
1278 }
1279}
1280
Nan Zhang27e284d2018-02-09 21:03:53 +00001281func TestExcludeFileGroupInSrcs(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001282 ctx, _ := testJava(t, `
Nan Zhang27e284d2018-02-09 21:03:53 +00001283 java_library {
1284 name: "foo",
1285 srcs: ["a.java", ":foo-srcs"],
1286 exclude_srcs: ["a.java", ":foo-excludes"],
1287 }
1288
1289 filegroup {
1290 name: "foo-srcs",
1291 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
1292 }
1293
1294 filegroup {
1295 name: "foo-excludes",
1296 srcs: ["java-fg/a.java", "java-fg/b.java"],
1297 }
1298 `)
1299
1300 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1301
1302 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
1303 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
1304 }
1305}
Jiyong Parkc678ad32018-04-10 13:07:10 +09001306
Paul Duffin52d398a2019-06-11 12:31:14 +01001307func TestJavaLibrary(t *testing.T) {
Colin Cross98be1bb2019-12-13 20:41:13 -08001308 config := testConfig(nil, "", map[string][]byte{
Paul Duffin52d398a2019-06-11 12:31:14 +01001309 "libcore/Android.bp": []byte(`
1310 java_library {
1311 name: "core",
1312 sdk_version: "none",
1313 system_modules: "none",
1314 }`),
1315 })
Colin Cross98be1bb2019-12-13 20:41:13 -08001316 ctx := testContext()
Paul Duffin52d398a2019-06-11 12:31:14 +01001317 run(t, ctx, config)
1318}
1319
Jiyong Parkc678ad32018-04-10 13:07:10 +09001320func TestJavaSdkLibrary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001321 ctx, _ := testJava(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001322 droiddoc_exported_dir {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001323 name: "droiddoc-templates-sdk",
1324 path: ".",
1325 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001326 java_sdk_library {
1327 name: "foo",
1328 srcs: ["a.java", "b.java"],
1329 api_packages: ["foo"],
1330 }
1331 java_sdk_library {
1332 name: "bar",
1333 srcs: ["a.java", "b.java"],
1334 api_packages: ["bar"],
1335 }
1336 java_library {
1337 name: "baz",
1338 srcs: ["c.java"],
Paul Duffin859fe962020-05-15 10:20:31 +01001339 libs: ["foo", "bar.stubs"],
Jiyong Parkc678ad32018-04-10 13:07:10 +09001340 sdk_version: "system_current",
1341 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001342 java_sdk_library {
1343 name: "barney",
1344 srcs: ["c.java"],
1345 api_only: true,
1346 }
1347 java_sdk_library {
1348 name: "betty",
1349 srcs: ["c.java"],
1350 shared_library: false,
1351 }
Paul Duffin859fe962020-05-15 10:20:31 +01001352 java_sdk_library_import {
1353 name: "quuz",
1354 public: {
1355 jars: ["c.jar"],
1356 },
1357 }
1358 java_sdk_library_import {
1359 name: "fred",
1360 public: {
1361 jars: ["b.jar"],
1362 },
1363 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001364 java_sdk_library_import {
1365 name: "wilma",
1366 public: {
1367 jars: ["b.jar"],
1368 },
1369 shared_library: false,
1370 }
Jiyong Park1be96912018-05-28 18:02:19 +09001371 java_library {
1372 name: "qux",
1373 srcs: ["c.java"],
Paul Duffindfa131e2020-05-15 20:37:11 +01001374 libs: ["baz", "fred", "quuz.stubs", "wilma", "barney", "betty"],
Jiyong Park1be96912018-05-28 18:02:19 +09001375 sdk_version: "system_current",
1376 }
Paul Duffin726d23c2020-01-22 16:30:37 +00001377 java_library {
1378 name: "baz-test",
1379 srcs: ["c.java"],
1380 libs: ["foo"],
1381 sdk_version: "test_current",
1382 }
Paul Duffina2db18f2020-01-22 17:11:15 +00001383 java_library {
1384 name: "baz-29",
1385 srcs: ["c.java"],
1386 libs: ["foo"],
1387 sdk_version: "system_29",
1388 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001389 `)
1390
1391 // check the existence of the internal modules
1392 ctx.ModuleForTests("foo", "android_common")
Paul Duffindd9d0742020-05-08 15:52:37 +01001393 ctx.ModuleForTests(apiScopePublic.stubsLibraryModuleName("foo"), "android_common")
1394 ctx.ModuleForTests(apiScopeSystem.stubsLibraryModuleName("foo"), "android_common")
1395 ctx.ModuleForTests(apiScopeTest.stubsLibraryModuleName("foo"), "android_common")
1396 ctx.ModuleForTests(apiScopePublic.stubsSourceModuleName("foo"), "android_common")
1397 ctx.ModuleForTests(apiScopeSystem.stubsSourceModuleName("foo"), "android_common")
1398 ctx.ModuleForTests(apiScopeTest.stubsSourceModuleName("foo"), "android_common")
Jiyong Parke3833882020-02-17 17:28:10 +09001399 ctx.ModuleForTests("foo"+sdkXmlFileSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +09001400 ctx.ModuleForTests("foo.api.public.28", "")
1401 ctx.ModuleForTests("foo.api.system.28", "")
1402 ctx.ModuleForTests("foo.api.test.28", "")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001403
1404 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1405 // tests if baz is actually linked to the stubs lib
1406 if !strings.Contains(bazJavac.Args["classpath"], "foo.stubs.system.jar") {
1407 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
1408 "foo.stubs.system.jar")
1409 }
1410 // ... and not to the impl lib
Sundong Ahn054b19a2018-10-19 13:46:09 +09001411 if strings.Contains(bazJavac.Args["classpath"], "foo.jar") {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001412 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
Sundong Ahn054b19a2018-10-19 13:46:09 +09001413 "foo.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001414 }
1415 // test if baz is not linked to the system variant of foo
1416 if strings.Contains(bazJavac.Args["classpath"], "foo.stubs.jar") {
1417 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
1418 "foo.stubs.jar")
1419 }
Jiyong Park1be96912018-05-28 18:02:19 +09001420
Paul Duffin726d23c2020-01-22 16:30:37 +00001421 bazTestJavac := ctx.ModuleForTests("baz-test", "android_common").Rule("javac")
1422 // tests if baz-test is actually linked to the test stubs lib
1423 if !strings.Contains(bazTestJavac.Args["classpath"], "foo.stubs.test.jar") {
1424 t.Errorf("baz-test javac classpath %v does not contain %q", bazTestJavac.Args["classpath"],
1425 "foo.stubs.test.jar")
1426 }
1427
Paul Duffina2db18f2020-01-22 17:11:15 +00001428 baz29Javac := ctx.ModuleForTests("baz-29", "android_common").Rule("javac")
1429 // tests if baz-29 is actually linked to the system 29 stubs lib
1430 if !strings.Contains(baz29Javac.Args["classpath"], "prebuilts/sdk/29/system/foo.jar") {
1431 t.Errorf("baz-29 javac classpath %v does not contain %q", baz29Javac.Args["classpath"],
1432 "prebuilts/sdk/29/system/foo.jar")
1433 }
1434
Jiyong Park1be96912018-05-28 18:02:19 +09001435 // test if baz has exported SDK lib names foo and bar to qux
1436 qux := ctx.ModuleForTests("qux", "android_common")
1437 if quxLib, ok := qux.Module().(*Library); ok {
1438 sdkLibs := quxLib.ExportedSdkLibs()
Paul Duffin859fe962020-05-15 10:20:31 +01001439 sort.Strings(sdkLibs)
1440 if w := []string{"bar", "foo", "fred", "quuz"}; !reflect.DeepEqual(w, sdkLibs) {
1441 t.Errorf("qux should export %q but exports %q", w, sdkLibs)
Jiyong Park1be96912018-05-28 18:02:19 +09001442 }
1443 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001444}
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001445
Paul Duffindaaa3322020-05-26 18:13:57 +01001446func TestJavaSdkLibrary_DoNotAccessImplWhenItIsNotBuilt(t *testing.T) {
1447 ctx, _ := testJava(t, `
1448 java_sdk_library {
1449 name: "foo",
1450 srcs: ["a.java"],
1451 api_only: true,
1452 public: {
1453 enabled: true,
1454 },
1455 }
1456
1457 java_library {
1458 name: "bar",
1459 srcs: ["b.java"],
1460 libs: ["foo"],
1461 }
1462 `)
1463
1464 // The bar library should depend on the stubs jar.
1465 barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1466 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1467 t.Errorf("expected %q, found %#q", expected, actual)
1468 }
1469}
1470
Paul Duffin46dc45a2020-05-14 15:39:10 +01001471func TestJavaSdkLibrary_UseSourcesFromAnotherSdkLibrary(t *testing.T) {
1472 testJava(t, `
1473 java_sdk_library {
1474 name: "foo",
1475 srcs: ["a.java"],
1476 api_packages: ["foo"],
1477 public: {
1478 enabled: true,
1479 },
1480 }
1481
1482 java_library {
1483 name: "bar",
1484 srcs: ["b.java", ":foo{.public.stubs.source}"],
1485 }
1486 `)
1487}
1488
1489func TestJavaSdkLibrary_AccessOutputFiles_MissingScope(t *testing.T) {
1490 testJavaError(t, `"foo" does not provide api scope system`, `
1491 java_sdk_library {
1492 name: "foo",
1493 srcs: ["a.java"],
1494 api_packages: ["foo"],
1495 public: {
1496 enabled: true,
1497 },
1498 }
1499
1500 java_library {
1501 name: "bar",
1502 srcs: ["b.java", ":foo{.system.stubs.source}"],
1503 }
1504 `)
1505}
1506
Paul Duffinca8d9a52020-06-26 22:20:25 +01001507func TestJavaSdkLibrary_Deps(t *testing.T) {
1508 ctx, _ := testJava(t, `
1509 java_sdk_library {
1510 name: "sdklib",
1511 srcs: ["a.java"],
1512 sdk_version: "none",
1513 system_modules: "none",
1514 public: {
1515 enabled: true,
1516 },
1517 }
1518 `)
1519
Paul Duffincee7e662020-07-09 17:32:57 +01001520 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +01001521 `dex2oatd`,
1522 `sdklib.impl`,
1523 `sdklib.stubs`,
1524 `sdklib.stubs.source`,
1525 `sdklib.xml`,
1526 })
1527}
1528
Paul Duffin46dc45a2020-05-14 15:39:10 +01001529func TestJavaSdkLibraryImport_AccessOutputFiles(t *testing.T) {
1530 testJava(t, `
1531 java_sdk_library_import {
1532 name: "foo",
1533 public: {
1534 jars: ["a.jar"],
1535 stub_srcs: ["a.java"],
1536 current_api: "api/current.txt",
1537 removed_api: "api/removed.txt",
1538 },
1539 }
1540
1541 java_library {
1542 name: "bar",
1543 srcs: [":foo{.public.stubs.source}"],
1544 java_resources: [
1545 ":foo{.public.api.txt}",
1546 ":foo{.public.removed-api.txt}",
1547 ],
1548 }
1549 `)
1550}
1551
1552func TestJavaSdkLibraryImport_AccessOutputFiles_Invalid(t *testing.T) {
1553 bp := `
1554 java_sdk_library_import {
1555 name: "foo",
1556 public: {
1557 jars: ["a.jar"],
1558 },
1559 }
1560 `
1561
1562 t.Run("stubs.source", func(t *testing.T) {
1563 testJavaError(t, `stubs.source not available for api scope public`, bp+`
1564 java_library {
1565 name: "bar",
1566 srcs: [":foo{.public.stubs.source}"],
1567 java_resources: [
1568 ":foo{.public.api.txt}",
1569 ":foo{.public.removed-api.txt}",
1570 ],
1571 }
1572 `)
1573 })
1574
1575 t.Run("api.txt", func(t *testing.T) {
1576 testJavaError(t, `api.txt not available for api scope public`, bp+`
1577 java_library {
1578 name: "bar",
1579 srcs: ["a.java"],
1580 java_resources: [
1581 ":foo{.public.api.txt}",
1582 ],
1583 }
1584 `)
1585 })
1586
1587 t.Run("removed-api.txt", func(t *testing.T) {
1588 testJavaError(t, `removed-api.txt not available for api scope public`, bp+`
1589 java_library {
1590 name: "bar",
1591 srcs: ["a.java"],
1592 java_resources: [
1593 ":foo{.public.removed-api.txt}",
1594 ],
1595 }
1596 `)
1597 })
1598}
1599
Paul Duffin3375e352020-04-28 10:44:03 +01001600func TestJavaSdkLibrary_InvalidScopes(t *testing.T) {
1601 testJavaError(t, `module "foo": enabled api scope "system" depends on disabled scope "public"`, `
1602 java_sdk_library {
1603 name: "foo",
1604 srcs: ["a.java", "b.java"],
1605 api_packages: ["foo"],
1606 // Explicitly disable public to test the check that ensures the set of enabled
1607 // scopes is consistent.
1608 public: {
1609 enabled: false,
1610 },
1611 system: {
1612 enabled: true,
1613 },
1614 }
1615 `)
1616}
1617
Paul Duffin87a05a32020-05-12 11:50:28 +01001618func TestJavaSdkLibrary_SdkVersion_ForScope(t *testing.T) {
1619 testJava(t, `
1620 java_sdk_library {
1621 name: "foo",
1622 srcs: ["a.java", "b.java"],
1623 api_packages: ["foo"],
1624 system: {
1625 enabled: true,
1626 sdk_version: "module_current",
1627 },
1628 }
1629 `)
1630}
1631
Paul Duffin0c5bae52020-06-02 13:00:08 +01001632func TestJavaSdkLibrary_ModuleLib(t *testing.T) {
1633 testJava(t, `
1634 java_sdk_library {
1635 name: "foo",
1636 srcs: ["a.java", "b.java"],
1637 api_packages: ["foo"],
1638 system: {
1639 enabled: true,
1640 },
1641 module_lib: {
1642 enabled: true,
1643 },
1644 }
1645 `)
1646}
1647
1648func TestJavaSdkLibrary_SystemServer(t *testing.T) {
1649 testJava(t, `
1650 java_sdk_library {
1651 name: "foo",
1652 srcs: ["a.java", "b.java"],
1653 api_packages: ["foo"],
1654 system: {
1655 enabled: true,
1656 },
1657 system_server: {
1658 enabled: true,
1659 },
1660 }
1661 `)
1662}
1663
Paul Duffin803a9562020-05-20 11:52:25 +01001664func TestJavaSdkLibrary_MissingScope(t *testing.T) {
1665 testJavaError(t, `requires api scope module-lib from foo but it only has \[\] available`, `
1666 java_sdk_library {
1667 name: "foo",
1668 srcs: ["a.java"],
1669 public: {
1670 enabled: false,
1671 },
1672 }
1673
1674 java_library {
1675 name: "baz",
1676 srcs: ["a.java"],
1677 libs: ["foo"],
1678 sdk_version: "module_current",
1679 }
1680 `)
1681}
1682
1683func TestJavaSdkLibrary_FallbackScope(t *testing.T) {
1684 testJava(t, `
1685 java_sdk_library {
1686 name: "foo",
1687 srcs: ["a.java"],
1688 system: {
1689 enabled: true,
1690 },
1691 }
1692
1693 java_library {
1694 name: "baz",
1695 srcs: ["a.java"],
1696 libs: ["foo"],
1697 // foo does not have module-lib scope so it should fallback to system
1698 sdk_version: "module_current",
1699 }
1700 `)
1701}
1702
Jiyong Park932cdfe2020-05-28 00:19:53 +09001703func TestJavaSdkLibrary_DefaultToStubs(t *testing.T) {
1704 ctx, _ := testJava(t, `
1705 java_sdk_library {
1706 name: "foo",
1707 srcs: ["a.java"],
1708 system: {
1709 enabled: true,
1710 },
1711 default_to_stubs: true,
1712 }
1713
1714 java_library {
1715 name: "baz",
1716 srcs: ["a.java"],
1717 libs: ["foo"],
1718 // does not have sdk_version set, should fallback to module,
1719 // which will then fallback to system because the module scope
1720 // is not enabled.
1721 }
1722 `)
1723 // The baz library should depend on the system stubs jar.
1724 bazLibrary := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1725 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs.system\.jar$`, bazLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1726 t.Errorf("expected %q, found %#q", expected, actual)
1727 }
1728}
1729
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001730var compilerFlagsTestCases = []struct {
1731 in string
1732 out bool
1733}{
1734 {
1735 in: "a",
1736 out: false,
1737 },
1738 {
1739 in: "-a",
1740 out: true,
1741 },
1742 {
1743 in: "-no-jdk",
1744 out: false,
1745 },
1746 {
1747 in: "-no-stdlib",
1748 out: false,
1749 },
1750 {
1751 in: "-kotlin-home",
1752 out: false,
1753 },
1754 {
1755 in: "-kotlin-home /some/path",
1756 out: false,
1757 },
1758 {
1759 in: "-include-runtime",
1760 out: false,
1761 },
1762 {
1763 in: "-Xintellij-plugin-root",
1764 out: false,
1765 },
1766}
1767
1768type mockContext struct {
1769 android.ModuleContext
1770 result bool
1771}
1772
1773func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
1774 // CheckBadCompilerFlags calls this function when the flag should be rejected
1775 ctx.result = false
1776}
1777
1778func TestCompilerFlags(t *testing.T) {
1779 for _, testCase := range compilerFlagsTestCases {
1780 ctx := &mockContext{result: true}
1781 CheckKotlincFlags(ctx, []string{testCase.in})
1782 if ctx.result != testCase.out {
1783 t.Errorf("incorrect output:")
1784 t.Errorf(" input: %#v", testCase.in)
1785 t.Errorf(" expected: %#v", testCase.out)
1786 t.Errorf(" got: %#v", ctx.result)
1787 }
1788 }
1789}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001790
1791// TODO(jungjw): Consider making this more robust by ignoring path order.
1792func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
1793 variables := ctx.ModuleForTests(moduleName, "android_common").Module().VariablesForTests()
1794 flags := strings.Split(variables["javacFlags"], " ")
1795 got := ""
1796 for _, flag := range flags {
1797 keyEnd := strings.Index(flag, "=")
1798 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
1799 got = flag[keyEnd+1:]
1800 break
1801 }
1802 }
1803 if expected != got {
1804 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
1805 }
1806}
1807
1808func TestPatchModule(t *testing.T) {
Pete Gillin0c2143e2019-05-02 15:32:11 +01001809 t.Run("Java language level 8", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001810 // Test with legacy javac -source 1.8 -target 1.8
Pete Gillinbdf5d712019-10-21 14:29:58 +01001811 bp := `
1812 java_library {
1813 name: "foo",
1814 srcs: ["a.java"],
1815 java_version: "1.8",
1816 }
1817
1818 java_library {
1819 name: "bar",
1820 srcs: ["b.java"],
1821 sdk_version: "none",
1822 system_modules: "none",
1823 patch_module: "java.base",
1824 java_version: "1.8",
1825 }
1826
1827 java_library {
1828 name: "baz",
1829 srcs: ["c.java"],
1830 patch_module: "java.base",
1831 java_version: "1.8",
1832 }
1833 `
1834 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001835
1836 checkPatchModuleFlag(t, ctx, "foo", "")
1837 checkPatchModuleFlag(t, ctx, "bar", "")
1838 checkPatchModuleFlag(t, ctx, "baz", "")
1839 })
1840
Pete Gillin0c2143e2019-05-02 15:32:11 +01001841 t.Run("Java language level 9", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001842 // Test with default javac -source 9 -target 9
Pete Gillinbdf5d712019-10-21 14:29:58 +01001843 bp := `
1844 java_library {
1845 name: "foo",
1846 srcs: ["a.java"],
1847 }
1848
1849 java_library {
1850 name: "bar",
1851 srcs: ["b.java"],
1852 sdk_version: "none",
1853 system_modules: "none",
1854 patch_module: "java.base",
1855 }
1856
1857 java_library {
1858 name: "baz",
1859 srcs: ["c.java"],
1860 patch_module: "java.base",
1861 }
1862 `
Pete Gillin1b3370f2019-10-01 13:57:31 +01001863 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001864
1865 checkPatchModuleFlag(t, ctx, "foo", "")
1866 expected := "java.base=.:" + buildDir
1867 checkPatchModuleFlag(t, ctx, "bar", expected)
Jiyong Park231d0562019-12-18 17:28:17 +09001868 expected = "java.base=" + strings.Join([]string{".", buildDir, moduleToPath("ext"), moduleToPath("framework")}, ":")
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001869 checkPatchModuleFlag(t, ctx, "baz", expected)
1870 })
1871}
Paul Duffina7b9f422020-01-10 17:12:18 +00001872
1873func TestJavaSystemModules(t *testing.T) {
1874 ctx, _ := testJava(t, `
1875 java_system_modules {
1876 name: "system-modules",
1877 libs: ["system-module1", "system-module2"],
1878 }
1879 java_library {
1880 name: "system-module1",
1881 srcs: ["a.java"],
1882 sdk_version: "none",
1883 system_modules: "none",
1884 }
1885 java_library {
1886 name: "system-module2",
1887 srcs: ["b.java"],
1888 sdk_version: "none",
1889 system_modules: "none",
1890 }
1891 `)
1892
1893 // check the existence of the module
1894 systemModules := ctx.ModuleForTests("system-modules", "android_common")
1895
1896 cmd := systemModules.Rule("jarsTosystemModules")
1897
1898 // make sure the command compiles against the supplied modules.
1899 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
1900 if !strings.Contains(cmd.Args["classpath"], module) {
1901 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
1902 module)
1903 }
1904 }
1905}
Paul Duffin90169ba2020-01-10 17:16:44 +00001906
1907func TestJavaSystemModulesImport(t *testing.T) {
1908 ctx, _ := testJava(t, `
1909 java_system_modules_import {
1910 name: "system-modules",
1911 libs: ["system-module1", "system-module2"],
1912 }
1913 java_import {
1914 name: "system-module1",
1915 jars: ["a.jar"],
1916 }
1917 java_import {
1918 name: "system-module2",
1919 jars: ["b.jar"],
1920 }
1921 `)
1922
1923 // check the existence of the module
1924 systemModules := ctx.ModuleForTests("system-modules", "android_common")
1925
1926 cmd := systemModules.Rule("jarsTosystemModules")
1927
1928 // make sure the command compiles against the supplied modules.
1929 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
1930 if !strings.Contains(cmd.Args["classpath"], module) {
1931 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
1932 module)
1933 }
1934 }
1935}
Paul Duffin83a2d962019-11-19 19:44:10 +00001936
1937func TestJavaLibraryWithSystemModules(t *testing.T) {
1938 ctx, _ := testJava(t, `
1939 java_library {
1940 name: "lib-with-source-system-modules",
1941 srcs: [
1942 "a.java",
1943 ],
1944 sdk_version: "none",
1945 system_modules: "source-system-modules",
1946 }
1947
1948 java_library {
1949 name: "source-jar",
1950 srcs: [
1951 "a.java",
1952 ],
1953 }
1954
1955 java_system_modules {
1956 name: "source-system-modules",
1957 libs: ["source-jar"],
1958 }
1959
1960 java_library {
1961 name: "lib-with-prebuilt-system-modules",
1962 srcs: [
1963 "a.java",
1964 ],
1965 sdk_version: "none",
1966 system_modules: "prebuilt-system-modules",
1967 }
1968
1969 java_import {
1970 name: "prebuilt-jar",
1971 jars: ["a.jar"],
1972 }
1973
1974 java_system_modules_import {
1975 name: "prebuilt-system-modules",
1976 libs: ["prebuilt-jar"],
1977 }
1978 `)
1979
1980 checkBootClasspathForSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar")
1981
1982 checkBootClasspathForSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar")
1983}
1984
1985func checkBootClasspathForSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) {
1986 javacRule := ctx.ModuleForTests(moduleName, "android_common").Rule("javac")
1987 bootClasspath := javacRule.Args["bootClasspath"]
1988 if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) {
1989 t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath)
1990 }
1991}
Jiyong Park19604de2020-03-24 16:44:11 +09001992
1993func TestAidlExportIncludeDirsFromImports(t *testing.T) {
1994 ctx, _ := testJava(t, `
1995 java_library {
1996 name: "foo",
1997 srcs: ["aidl/foo/IFoo.aidl"],
1998 libs: ["bar"],
1999 }
2000
2001 java_import {
2002 name: "bar",
2003 jars: ["a.jar"],
2004 aidl: {
2005 export_include_dirs: ["aidl/bar"],
2006 },
2007 }
2008 `)
2009
2010 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
2011 expectedAidlFlag := "-Iaidl/bar"
2012 if !strings.Contains(aidlCommand, expectedAidlFlag) {
2013 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
2014 }
2015}
Liz Kammerdd849a82020-06-12 16:38:45 -07002016
2017func TestDataNativeBinaries(t *testing.T) {
2018 ctx, config := testJava(t, `
2019 java_test_host {
2020 name: "foo",
2021 srcs: ["a.java"],
2022 data_native_bins: ["bin"]
2023 }
2024
2025 python_binary_host {
2026 name: "bin",
2027 srcs: ["bin.py"],
2028 }
2029 `)
2030
2031 buildOS := android.BuildOs.String()
2032
2033 test := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
2034 entries := android.AndroidMkEntriesForTest(t, config, "", test)[0]
2035 expected := []string{buildDir + "/.intermediates/bin/" + buildOS + "_x86_64_PY3/bin:bin"}
2036 actual := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
2037 if !reflect.DeepEqual(expected, actual) {
2038 t.Errorf("Unexpected test data - expected: %q, actual: %q", expected, actual)
2039 }
2040}