blob: 2a23f371e3d5bd9f73ca8c5c1174985263e36f33 [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Paul Duffin1a393322020-11-18 16:36:47 +000018 "fmt"
Colin Cross72bb3632017-07-13 16:23:21 -070019 "io/ioutil"
20 "os"
21 "path/filepath"
Colin Crossc0806172019-06-14 18:51:47 -070022 "reflect"
Paul Duffindaaa3322020-05-26 18:13:57 +010023 "regexp"
Nan Zhang61eaedb2017-11-02 13:28:15 -070024 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070025 "strings"
26 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070027
Jeongik Cha28df2572019-11-11 10:46:36 +090028 "github.com/google/blueprint/proptools"
29
Colin Crossa4f08812018-10-02 22:03:40 -070030 "android/soong/android"
31 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080032 "android/soong/dexpreopt"
Liz Kammerdd849a82020-06-12 16:38:45 -070033 "android/soong/python"
Colin Cross72bb3632017-07-13 16:23:21 -070034)
35
36var buildDir string
37
38func setUp() {
39 var err error
40 buildDir, err = ioutil.TempDir("", "soong_java_test")
41 if err != nil {
42 panic(err)
43 }
44}
45
46func tearDown() {
47 os.RemoveAll(buildDir)
48}
49
50func TestMain(m *testing.M) {
51 run := func() int {
52 setUp()
53 defer tearDown()
54
55 return m.Run()
56 }
57
58 os.Exit(run())
59}
Colin Cross527012a2017-11-30 22:56:16 -080060
Colin Cross98be1bb2019-12-13 20:41:13 -080061func testConfig(env map[string]string, bp string, fs map[string][]byte) android.Config {
Martin Stjernholmd90676f2020-01-11 00:37:30 +000062 bp += dexpreopt.BpToolModulesForTest()
63
Martin Stjernholm75a48d82020-01-10 20:32:59 +000064 config := TestConfig(buildDir, env, bp, fs)
65
66 // Set up the global Once cache used for dexpreopt.GlobalSoongConfig, so that
67 // it doesn't create a real one, which would fail.
68 _ = dexpreopt.GlobalSoongConfigForTests(config)
69
70 return config
Colin Cross1369cdb2017-09-29 17:58:17 -070071}
72
Colin Crossae8600b2020-10-29 17:09:13 -070073func testContext(config android.Config) *android.TestContext {
Colin Cross72bb3632017-07-13 16:23:21 -070074
Colin Crossae8600b2020-10-29 17:09:13 -070075 ctx := android.NewTestArchContext(config)
Paul Duffinc059c8c2021-01-20 17:13:52 +000076 RegisterRequiredBuildComponentsForTest(ctx)
Colin Cross4b49b762019-11-22 15:25:03 -080077 ctx.RegisterModuleType("java_plugin", PluginFactory)
Colin Cross4b49b762019-11-22 15:25:03 -080078 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
Liz Kammerdd849a82020-06-12 16:38:45 -070079 ctx.RegisterModuleType("python_binary_host", python.PythonBinaryHostFactory)
Colin Cross89536d42017-07-07 14:35:50 -070080 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Paul Duffin44f1d842020-06-26 20:17:02 +010081 ctx.PreArchMutators(android.RegisterComponentsMutator)
Paul Duffina48f7582019-12-19 11:25:19 +000082
Liz Kammerdd849a82020-06-12 16:38:45 -070083 ctx.PreDepsMutators(python.RegisterPythonPreDepsMutators)
Jaewoong Jungb639a6a2019-05-10 15:16:29 -070084 ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
Colin Cross06fa5882020-10-29 18:21:38 -070085 ctx.RegisterPreSingletonType("overlay", android.SingletonFactoryAdaptor(ctx.Context, OverlaySingletonFactory))
86 ctx.RegisterPreSingletonType("sdk_versions", android.SingletonFactoryAdaptor(ctx.Context, sdkPreSingletonFactory))
Colin Crossa4f08812018-10-02 22:03:40 -070087
Paul Duffin021f4e52020-07-30 16:04:17 +010088 android.RegisterPrebuiltMutators(ctx)
89
Colin Crossa4f08812018-10-02 22:03:40 -070090 // Register module types and mutators from cc needed for JNI testing
Paul Duffin77980a82019-12-19 16:01:36 +000091 cc.RegisterRequiredBuildComponentsForTest(ctx)
Colin Crossa4f08812018-10-02 22:03:40 -070092
Martin Stjernholmd90676f2020-01-11 00:37:30 +000093 dexpreopt.RegisterToolModulesForTest(ctx)
94
Jaewoong Jungc779cd42020-10-06 18:56:10 -070095 ctx.PostDepsMutators(func(ctx android.RegisterMutatorsContext) {
96 ctx.TopDown("propagate_rro_enforcement", propagateRROEnforcementMutator).Parallel()
97 })
98
Colin Cross527012a2017-11-30 22:56:16 -080099 return ctx
100}
101
102func run(t *testing.T, ctx *android.TestContext, config android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800103 t.Helper()
Colin Crossc28bb0b2019-02-25 14:20:47 -0800104
Colin Cross98be1bb2019-12-13 20:41:13 -0800105 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000106 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Colin Crossc28bb0b2019-02-25 14:20:47 -0800107
Colin Crossae8600b2020-10-29 17:09:13 -0700108 ctx.Register()
Paul Duffinbaccf7e2019-06-11 11:58:30 +0100109 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
Logan Chien42039712018-03-12 16:29:17 +0800110 android.FailIfErrored(t, errs)
Colin Cross72bb3632017-07-13 16:23:21 -0700111 _, errs = ctx.PrepareBuildActions(config)
Logan Chien42039712018-03-12 16:29:17 +0800112 android.FailIfErrored(t, errs)
Colin Cross527012a2017-11-30 22:56:16 -0800113}
114
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900115func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) {
Jeongik Cha538c0d02019-07-11 15:54:27 +0900116 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800117 return testJavaErrorWithConfig(t, pattern, testConfig(nil, bp, nil))
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900118}
119
Colin Cross98be1bb2019-12-13 20:41:13 -0800120func testJavaErrorWithConfig(t *testing.T, pattern string, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900121 t.Helper()
Colin Crossae8600b2020-10-29 17:09:13 -0700122 ctx := testContext(config)
Jeongik Cha538c0d02019-07-11 15:54:27 +0900123
Colin Cross98be1bb2019-12-13 20:41:13 -0800124 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000125 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Jeongik Cha538c0d02019-07-11 15:54:27 +0900126
Colin Crossae8600b2020-10-29 17:09:13 -0700127 ctx.Register()
Jeongik Cha538c0d02019-07-11 15:54:27 +0900128 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
129 if len(errs) > 0 {
130 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900131 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900132 }
133 _, errs = ctx.PrepareBuildActions(config)
134 if len(errs) > 0 {
135 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900136 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900137 }
138
139 t.Fatalf("missing expected error %q (0 errors are returned)", pattern)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900140
141 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900142}
143
Colin Cross238c1f32020-06-07 16:58:18 -0700144func testJavaWithFS(t *testing.T, bp string, fs map[string][]byte) (*android.TestContext, android.Config) {
145 t.Helper()
146 return testJavaWithConfig(t, testConfig(nil, bp, fs))
147}
148
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700149func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800150 t.Helper()
Colin Cross238c1f32020-06-07 16:58:18 -0700151 return testJavaWithFS(t, bp, nil)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900152}
153
Colin Cross98be1bb2019-12-13 20:41:13 -0800154func testJavaWithConfig(t *testing.T, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900155 t.Helper()
Colin Crossae8600b2020-10-29 17:09:13 -0700156 ctx := testContext(config)
Colin Cross527012a2017-11-30 22:56:16 -0800157 run(t, ctx, config)
Colin Cross72bb3632017-07-13 16:23:21 -0700158
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700159 return ctx, config
Colin Cross72bb3632017-07-13 16:23:21 -0700160}
161
Colin Cross2acdae82017-09-15 19:44:24 -0700162func moduleToPath(name string) string {
163 switch {
164 case name == `""`:
165 return name
Colin Crossfc3674a2017-09-18 17:41:52 -0700166 case strings.HasSuffix(name, ".jar"):
167 return name
Nan Zhanged19fc32017-10-19 13:06:22 -0700168 default:
169 return filepath.Join(buildDir, ".intermediates", name, "android_common", "turbine-combined", name+".jar")
Colin Cross2acdae82017-09-15 19:44:24 -0700170 }
171}
172
Jeongik Chae403e9e2019-12-07 00:16:24 +0900173func TestJavaLinkType(t *testing.T) {
174 testJava(t, `
175 java_library {
176 name: "foo",
177 srcs: ["a.java"],
178 libs: ["bar"],
179 static_libs: ["baz"],
180 }
181
182 java_library {
183 name: "bar",
184 sdk_version: "current",
185 srcs: ["b.java"],
186 }
187
188 java_library {
189 name: "baz",
190 sdk_version: "system_current",
191 srcs: ["c.java"],
192 }
193 `)
194
Steven Moreland00298982020-11-17 21:44:36 +0000195 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900196 java_library {
197 name: "foo",
198 srcs: ["a.java"],
199 libs: ["bar"],
200 sdk_version: "current",
201 static_libs: ["baz"],
202 }
203
204 java_library {
205 name: "bar",
206 sdk_version: "current",
207 srcs: ["b.java"],
208 }
209
210 java_library {
211 name: "baz",
212 sdk_version: "system_current",
213 srcs: ["c.java"],
214 }
215 `)
216
217 testJava(t, `
218 java_library {
219 name: "foo",
220 srcs: ["a.java"],
221 libs: ["bar"],
222 sdk_version: "system_current",
223 static_libs: ["baz"],
224 }
225
226 java_library {
227 name: "bar",
228 sdk_version: "current",
229 srcs: ["b.java"],
230 }
231
232 java_library {
233 name: "baz",
234 sdk_version: "system_current",
235 srcs: ["c.java"],
236 }
237 `)
238
Steven Moreland00298982020-11-17 21:44:36 +0000239 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900240 java_library {
241 name: "foo",
242 srcs: ["a.java"],
243 libs: ["bar"],
244 sdk_version: "system_current",
245 static_libs: ["baz"],
246 }
247
248 java_library {
249 name: "bar",
250 sdk_version: "current",
251 srcs: ["b.java"],
252 }
253
254 java_library {
255 name: "baz",
256 srcs: ["c.java"],
257 }
258 `)
259}
260
Colin Cross72bb3632017-07-13 16:23:21 -0700261func TestSimple(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700262 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700263 java_library {
264 name: "foo",
265 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700266 libs: ["bar"],
267 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700268 }
269
270 java_library {
271 name: "bar",
272 srcs: ["b.java"],
273 }
274
275 java_library {
276 name: "baz",
277 srcs: ["c.java"],
278 }
Colin Crossd5934c82017-10-02 13:55:26 -0700279 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700280
Colin Cross4c428df2017-09-15 17:36:05 -0700281 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700282 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700283
284 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
285 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
286 }
287
Colin Cross1ee23172017-10-18 14:44:18 -0700288 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Nan Zhanged19fc32017-10-19 13:06:22 -0700289 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
290 bazTurbine := filepath.Join(buildDir, ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700291
Nan Zhanged19fc32017-10-19 13:06:22 -0700292 if !strings.Contains(javac.Args["classpath"], barTurbine) {
293 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700294 }
295
Nan Zhanged19fc32017-10-19 13:06:22 -0700296 if !strings.Contains(javac.Args["classpath"], bazTurbine) {
297 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700298 }
299
300 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
301 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700302 }
303}
304
Artur Satayev9cf46692019-11-26 18:08:34 +0000305func TestExportedPlugins(t *testing.T) {
306 type Result struct {
Colin Crossc9fe10f2020-11-19 18:06:03 -0800307 library string
308 processors string
309 disableTurbine bool
Artur Satayev9cf46692019-11-26 18:08:34 +0000310 }
311 var tests = []struct {
312 name string
313 extra string
314 results []Result
315 }{
316 {
317 name: "Exported plugin is not a direct plugin",
318 extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`,
319 results: []Result{{library: "exports", processors: "-proc:none"}},
320 },
321 {
322 name: "Exports plugin to dependee",
323 extra: `
324 java_library{name: "exports", exported_plugins: ["plugin"]}
325 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
326 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
327 `,
328 results: []Result{
329 {library: "foo", processors: "-processor com.android.TestPlugin"},
330 {library: "bar", processors: "-processor com.android.TestPlugin"},
331 },
332 },
333 {
334 name: "Exports plugin to android_library",
335 extra: `
336 java_library{name: "exports", exported_plugins: ["plugin"]}
337 android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
338 android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
339 `,
340 results: []Result{
341 {library: "foo", processors: "-processor com.android.TestPlugin"},
342 {library: "bar", processors: "-processor com.android.TestPlugin"},
343 },
344 },
345 {
346 name: "Exports plugin is not propagated via transitive deps",
347 extra: `
348 java_library{name: "exports", exported_plugins: ["plugin"]}
349 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
350 java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]}
351 `,
352 results: []Result{
353 {library: "foo", processors: "-processor com.android.TestPlugin"},
354 {library: "bar", processors: "-proc:none"},
355 },
356 },
357 {
358 name: "Exports plugin appends to plugins",
359 extra: `
360 java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"}
361 java_library{name: "exports", exported_plugins: ["plugin"]}
362 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]}
363 `,
364 results: []Result{
365 {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"},
366 },
367 },
Colin Crossc9fe10f2020-11-19 18:06:03 -0800368 {
369 name: "Exports plugin to with generates_api to dependee",
370 extra: `
371 java_library{name: "exports", exported_plugins: ["plugin_generates_api"]}
372 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
373 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
374 `,
375 results: []Result{
376 {library: "foo", processors: "-processor com.android.TestPlugin", disableTurbine: true},
377 {library: "bar", processors: "-processor com.android.TestPlugin", disableTurbine: true},
378 },
379 },
Artur Satayev9cf46692019-11-26 18:08:34 +0000380 }
381
382 for _, test := range tests {
383 t.Run(test.name, func(t *testing.T) {
384 ctx, _ := testJava(t, `
385 java_plugin {
386 name: "plugin",
387 processor_class: "com.android.TestPlugin",
388 }
Colin Crossc9fe10f2020-11-19 18:06:03 -0800389 java_plugin {
390 name: "plugin_generates_api",
391 generates_api: true,
392 processor_class: "com.android.TestPlugin",
393 }
Artur Satayev9cf46692019-11-26 18:08:34 +0000394 `+test.extra)
395
396 for _, want := range test.results {
397 javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac")
398 if javac.Args["processor"] != want.processors {
399 t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"])
400 }
Colin Crossc9fe10f2020-11-19 18:06:03 -0800401 turbine := ctx.ModuleForTests(want.library, "android_common").MaybeRule("turbine")
402 disableTurbine := turbine.BuildParams.Rule == nil
403 if disableTurbine != want.disableTurbine {
404 t.Errorf("For library %v, expected disableTurbine %v, found %v", want.library, want.disableTurbine, disableTurbine)
405 }
Artur Satayev9cf46692019-11-26 18:08:34 +0000406 }
407 })
408 }
409}
410
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900411func TestSdkVersionByPartition(t *testing.T) {
412 testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900413 java_library {
414 name: "foo",
415 srcs: ["a.java"],
416 vendor: true,
417 }
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900418 `)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900419
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900420 testJava(t, `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900421 java_library {
422 name: "bar",
423 srcs: ["b.java"],
424 }
425 `)
426
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900427 for _, enforce := range []bool{true, false} {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900428 bp := `
429 java_library {
430 name: "foo",
431 srcs: ["a.java"],
432 product_specific: true,
433 }
434 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800435
436 config := testConfig(nil, bp, nil)
437 config.TestProductVariables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900438 if enforce {
Colin Cross98be1bb2019-12-13 20:41:13 -0800439 testJavaErrorWithConfig(t, "sdk_version must have a value when the module is located at vendor or product", config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900440 } else {
Colin Cross98be1bb2019-12-13 20:41:13 -0800441 testJavaWithConfig(t, config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900442 }
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900443 }
444}
445
Colin Crossd5934c82017-10-02 13:55:26 -0700446func TestArchSpecific(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700447 ctx, _ := testJava(t, `
Colin Crossd5934c82017-10-02 13:55:26 -0700448 java_library {
449 name: "foo",
450 srcs: ["a.java"],
451 target: {
452 android: {
453 srcs: ["b.java"],
454 },
455 },
456 }
457 `)
458
459 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
460 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
461 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
462 }
463}
464
Colin Cross6b4a32d2017-12-05 13:42:45 -0800465func TestBinary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700466 ctx, _ := testJava(t, `
Colin Cross6b4a32d2017-12-05 13:42:45 -0800467 java_library_host {
468 name: "foo",
469 srcs: ["a.java"],
470 }
471
472 java_binary_host {
473 name: "bar",
474 srcs: ["b.java"],
475 static_libs: ["foo"],
Colin Cross89226d92020-10-09 19:00:54 -0700476 jni_libs: ["libjni"],
477 }
478
479 cc_library_shared {
480 name: "libjni",
481 host_supported: true,
482 device_supported: false,
483 stl: "none",
Colin Cross6b4a32d2017-12-05 13:42:45 -0800484 }
485 `)
486
487 buildOS := android.BuildOs.String()
488
489 bar := ctx.ModuleForTests("bar", buildOS+"_common")
490 barJar := bar.Output("bar.jar").Output.String()
491 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
492 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
493
Colin Cross89226d92020-10-09 19:00:54 -0700494 libjni := ctx.ModuleForTests("libjni", buildOS+"_x86_64_shared")
495 libjniSO := libjni.Rule("Cp").Output.String()
496
Colin Cross6b4a32d2017-12-05 13:42:45 -0800497 // Test that the install binary wrapper depends on the installed jar file
Colin Crossc179ea62020-10-09 10:54:15 -0700498 if g, w := barWrapperDeps, barJar; !android.InList(w, g) {
499 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800500 }
Colin Cross89226d92020-10-09 19:00:54 -0700501
502 // Test that the install binary wrapper depends on the installed JNI libraries
503 if g, w := barWrapperDeps, libjniSO; !android.InList(w, g) {
504 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800505 }
Alex Humesky2070e322020-06-09 20:23:08 -0400506}
Colin Cross6b4a32d2017-12-05 13:42:45 -0800507
Alex Humesky2070e322020-06-09 20:23:08 -0400508func TestHostBinaryNoJavaDebugInfoOverride(t *testing.T) {
509 bp := `
510 java_library {
511 name: "target_library",
512 srcs: ["a.java"],
513 }
514
515 java_binary_host {
516 name: "host_binary",
517 srcs: ["b.java"],
518 }
519 `
520 config := testConfig(nil, bp, nil)
521 config.TestProductVariables.MinimizeJavaDebugInfo = proptools.BoolPtr(true)
522
523 ctx, _ := testJavaWithConfig(t, config)
524
Liz Kammer7941b302020-07-28 13:27:34 -0700525 // first, check that the -g flag is added to target modules
Alex Humesky2070e322020-06-09 20:23:08 -0400526 targetLibrary := ctx.ModuleForTests("target_library", "android_common")
527 targetJavaFlags := targetLibrary.Module().VariablesForTests()["javacFlags"]
528 if !strings.Contains(targetJavaFlags, "-g:source,lines") {
529 t.Errorf("target library javac flags %v should contain "+
530 "-g:source,lines override with MinimizeJavaDebugInfo", targetJavaFlags)
531 }
532
533 // check that -g is not overridden for host modules
534 buildOS := android.BuildOs.String()
535 hostBinary := ctx.ModuleForTests("host_binary", buildOS+"_common")
536 hostJavaFlags := hostBinary.Module().VariablesForTests()["javacFlags"]
537 if strings.Contains(hostJavaFlags, "-g:source,lines") {
538 t.Errorf("java_binary_host javac flags %v should not have "+
539 "-g:source,lines override with MinimizeJavaDebugInfo", hostJavaFlags)
540 }
Colin Cross6b4a32d2017-12-05 13:42:45 -0800541}
542
Colin Cross72bb3632017-07-13 16:23:21 -0700543func TestPrebuilts(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700544 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700545 java_library {
546 name: "foo",
Paul Duffin91547182019-11-12 19:39:36 +0000547 srcs: ["a.java", ":stubs-source"],
Paul Duffinfcfd7912020-01-31 17:54:30 +0000548 libs: ["bar", "sdklib"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700549 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700550 }
551
Colin Cross74d73e22017-08-02 11:05:49 -0700552 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700553 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700554 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700555 }
556
Colin Cross74d73e22017-08-02 11:05:49 -0700557 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700558 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700559 jars: ["b.jar"],
Liz Kammerd6c31d22020-08-05 15:40:41 -0700560 sdk_version: "current",
561 compile_dex: true,
Colin Cross72bb3632017-07-13 16:23:21 -0700562 }
Colin Cross42be7612019-02-21 18:12:14 -0800563
564 dex_import {
565 name: "qux",
566 jars: ["b.jar"],
567 }
Colin Cross79c7c262019-04-17 11:11:46 -0700568
569 java_sdk_library_import {
Paul Duffin56d44902020-01-31 13:36:25 +0000570 name: "sdklib",
571 public: {
572 jars: ["c.jar"],
573 },
574 }
575
Paul Duffin91547182019-11-12 19:39:36 +0000576 prebuilt_stubs_sources {
577 name: "stubs-source",
Paul Duffin9b478b02019-12-10 13:41:51 +0000578 srcs: ["stubs/sources"],
Paul Duffin91547182019-11-12 19:39:36 +0000579 }
Paul Duffin1b82e6a2019-12-03 18:06:47 +0000580
581 java_test_import {
582 name: "test",
583 jars: ["a.jar"],
584 test_suites: ["cts"],
585 test_config: "AndroidTest.xml",
586 }
Colin Cross72bb3632017-07-13 16:23:21 -0700587 `)
588
Paul Duffin9b478b02019-12-10 13:41:51 +0000589 fooModule := ctx.ModuleForTests("foo", "android_common")
590 javac := fooModule.Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700591 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Liz Kammerd6c31d22020-08-05 15:40:41 -0700592 barModule := ctx.ModuleForTests("bar", "android_common")
593 barJar := barModule.Rule("combineJar").Output
594 bazModule := ctx.ModuleForTests("baz", "android_common")
595 bazJar := bazModule.Rule("combineJar").Output
Colin Cross79c7c262019-04-17 11:11:46 -0700596 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700597
Paul Duffin9b478b02019-12-10 13:41:51 +0000598 fooLibrary := fooModule.Module().(*Library)
599 assertDeepEquals(t, "foo java sources incorrect",
600 []string{"a.java"}, fooLibrary.compiledJavaSrcs.Strings())
Paul Duffin91547182019-11-12 19:39:36 +0000601
Paul Duffin9b478b02019-12-10 13:41:51 +0000602 assertDeepEquals(t, "foo java source jars incorrect",
603 []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"},
604 android.NormalizePathsForTesting(fooLibrary.compiledSrcJars))
Paul Duffin91547182019-11-12 19:39:36 +0000605
Colin Cross37f6d792018-07-12 12:28:41 -0700606 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
607 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700608 }
609
Liz Kammerd6c31d22020-08-05 15:40:41 -0700610 barDexJar := barModule.Module().(*Import).DexJarBuildPath()
611 if barDexJar != nil {
612 t.Errorf("bar dex jar build path expected to be nil, got %q", barDexJar)
613 }
614
Colin Cross79c7c262019-04-17 11:11:46 -0700615 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
616 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
617 }
618
Colin Cross37f6d792018-07-12 12:28:41 -0700619 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
620 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700621 }
Colin Cross42be7612019-02-21 18:12:14 -0800622
Liz Kammerd6c31d22020-08-05 15:40:41 -0700623 bazDexJar := bazModule.Module().(*Import).DexJarBuildPath().String()
624 expectedDexJar := buildDir + "/.intermediates/baz/android_common/dex/baz.jar"
625 if bazDexJar != expectedDexJar {
626 t.Errorf("baz dex jar build path expected %q, got %q", expectedDexJar, bazDexJar)
627 }
628
Colin Cross42be7612019-02-21 18:12:14 -0800629 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Colin Cross72bb3632017-07-13 16:23:21 -0700630}
631
Paul Duffin9b478b02019-12-10 13:41:51 +0000632func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) {
633 if !reflect.DeepEqual(expected, actual) {
634 t.Errorf("%s: expected %q, found %q", message, expected, actual)
635 }
636}
637
Paul Duffin1a393322020-11-18 16:36:47 +0000638func TestPrebuiltStubsSources(t *testing.T) {
639 test := func(t *testing.T, sourcesPath string, expectedInputs []string) {
640 ctx, _ := testJavaWithFS(t, fmt.Sprintf(`
641prebuilt_stubs_sources {
642 name: "stubs-source",
643 srcs: ["%s"],
644}`, sourcesPath), map[string][]byte{
645 "stubs/sources/pkg/A.java": nil,
646 "stubs/sources/pkg/B.java": nil,
647 })
648
649 zipSrc := ctx.ModuleForTests("stubs-source", "android_common").Rule("zip_src")
650 if expected, actual := expectedInputs, zipSrc.Inputs.Strings(); !reflect.DeepEqual(expected, actual) {
651 t.Errorf("mismatch of inputs to soong_zip: expected %q, actual %q", expected, actual)
652 }
653 }
654
655 t.Run("empty/missing directory", func(t *testing.T) {
656 test(t, "empty-directory", []string{})
657 })
658
659 t.Run("non-empty set of sources", func(t *testing.T) {
660 test(t, "stubs/sources", []string{
661 "stubs/sources/pkg/A.java",
662 "stubs/sources/pkg/B.java",
663 })
664 })
665}
666
Paul Duffin56d44902020-01-31 13:36:25 +0000667func TestJavaSdkLibraryImport(t *testing.T) {
668 ctx, _ := testJava(t, `
669 java_library {
670 name: "foo",
671 srcs: ["a.java"],
672 libs: ["sdklib"],
673 sdk_version: "current",
674 }
675
676 java_library {
677 name: "foo.system",
678 srcs: ["a.java"],
679 libs: ["sdklib"],
680 sdk_version: "system_current",
681 }
682
683 java_library {
684 name: "foo.test",
685 srcs: ["a.java"],
686 libs: ["sdklib"],
687 sdk_version: "test_current",
688 }
689
690 java_sdk_library_import {
691 name: "sdklib",
692 public: {
693 jars: ["a.jar"],
694 },
695 system: {
696 jars: ["b.jar"],
697 },
698 test: {
699 jars: ["c.jar"],
Paul Duffin0f8faff2020-05-20 16:18:00 +0100700 stub_srcs: ["c.java"],
Paul Duffin56d44902020-01-31 13:36:25 +0000701 },
702 }
703 `)
704
705 for _, scope := range []string{"", ".system", ".test"} {
706 fooModule := ctx.ModuleForTests("foo"+scope, "android_common")
707 javac := fooModule.Rule("javac")
708
709 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs"+scope, "android_common").Rule("combineJar").Output
710 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
711 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
712 }
713 }
Paul Duffinca8d9a52020-06-26 22:20:25 +0100714
Paul Duffincee7e662020-07-09 17:32:57 +0100715 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100716 `prebuilt_sdklib.stubs`,
717 `prebuilt_sdklib.stubs.source.test`,
718 `prebuilt_sdklib.stubs.system`,
719 `prebuilt_sdklib.stubs.test`,
720 })
721}
722
723func TestJavaSdkLibraryImport_WithSource(t *testing.T) {
724 ctx, _ := testJava(t, `
725 java_sdk_library {
726 name: "sdklib",
727 srcs: ["a.java"],
728 sdk_version: "none",
729 system_modules: "none",
730 public: {
731 enabled: true,
732 },
733 }
734
735 java_sdk_library_import {
736 name: "sdklib",
737 public: {
738 jars: ["a.jar"],
739 },
740 }
741 `)
742
Paul Duffincee7e662020-07-09 17:32:57 +0100743 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100744 `dex2oatd`,
745 `prebuilt_sdklib`,
746 `sdklib.impl`,
747 `sdklib.stubs`,
748 `sdklib.stubs.source`,
749 `sdklib.xml`,
750 })
751
Paul Duffincee7e662020-07-09 17:32:57 +0100752 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffin44f1d842020-06-26 20:17:02 +0100753 `prebuilt_sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100754 `sdklib.impl`,
755 // This should be prebuilt_sdklib.stubs but is set to sdklib.stubs because the
756 // dependency is added after prebuilts may have been renamed and so has to use
757 // the renamed name.
Paul Duffinca8d9a52020-06-26 22:20:25 +0100758 `sdklib.xml`,
759 })
760}
761
762func TestJavaSdkLibraryImport_Preferred(t *testing.T) {
763 ctx, _ := testJava(t, `
764 java_sdk_library {
765 name: "sdklib",
766 srcs: ["a.java"],
767 sdk_version: "none",
768 system_modules: "none",
769 public: {
770 enabled: true,
771 },
772 }
773
774 java_sdk_library_import {
775 name: "sdklib",
776 prefer: true,
777 public: {
778 jars: ["a.jar"],
779 },
780 }
781 `)
782
Paul Duffincee7e662020-07-09 17:32:57 +0100783 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100784 `dex2oatd`,
785 `prebuilt_sdklib`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100786 `sdklib.impl`,
Paul Duffin80342d72020-06-26 22:08:43 +0100787 `sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100788 `sdklib.stubs.source`,
789 `sdklib.xml`,
790 })
791
Paul Duffincee7e662020-07-09 17:32:57 +0100792 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100793 `prebuilt_sdklib.stubs`,
794 `sdklib.impl`,
795 `sdklib.xml`,
796 })
Paul Duffin56d44902020-01-31 13:36:25 +0000797}
798
JaeMan Parkff715562020-10-19 17:25:58 +0900799func TestJavaSdkLibraryEnforce(t *testing.T) {
800 partitionToBpOption := func(partition string) string {
801 switch partition {
802 case "system":
803 return ""
804 case "vendor":
805 return "soc_specific: true,"
806 case "product":
807 return "product_specific: true,"
808 default:
809 panic("Invalid partition group name: " + partition)
810 }
811 }
812
813 type testConfigInfo struct {
814 libraryType string
815 fromPartition string
816 toPartition string
817 enforceVendorInterface bool
818 enforceProductInterface bool
819 enforceJavaSdkLibraryCheck bool
820 allowList []string
821 }
822
823 createTestConfig := func(info testConfigInfo) android.Config {
824 bpFileTemplate := `
825 java_library {
826 name: "foo",
827 srcs: ["foo.java"],
828 libs: ["bar"],
829 sdk_version: "current",
830 %s
831 }
832
833 %s {
834 name: "bar",
835 srcs: ["bar.java"],
836 sdk_version: "current",
837 %s
838 }
839 `
840
841 bpFile := fmt.Sprintf(bpFileTemplate,
842 partitionToBpOption(info.fromPartition),
843 info.libraryType,
844 partitionToBpOption(info.toPartition))
845
846 config := testConfig(nil, bpFile, nil)
847 configVariables := config.TestProductVariables
848
849 configVariables.EnforceProductPartitionInterface = proptools.BoolPtr(info.enforceProductInterface)
850 if info.enforceVendorInterface {
851 configVariables.DeviceVndkVersion = proptools.StringPtr("current")
852 }
853 configVariables.EnforceInterPartitionJavaSdkLibrary = proptools.BoolPtr(info.enforceJavaSdkLibraryCheck)
854 configVariables.InterPartitionJavaLibraryAllowList = info.allowList
855
856 return config
857 }
858
JaeMan Parkff715562020-10-19 17:25:58 +0900859 errorMessage := "is not allowed across the partitions"
860
JaeMan Park90e75352021-01-14 11:56:56 +0900861 testJavaWithConfig(t, createTestConfig(testConfigInfo{
862 libraryType: "java_library",
863 fromPartition: "product",
864 toPartition: "system",
865 enforceVendorInterface: true,
866 enforceProductInterface: true,
867 enforceJavaSdkLibraryCheck: false,
868 }))
JaeMan Parkff715562020-10-19 17:25:58 +0900869
JaeMan Park90e75352021-01-14 11:56:56 +0900870 testJavaWithConfig(t, createTestConfig(testConfigInfo{
871 libraryType: "java_library",
872 fromPartition: "product",
873 toPartition: "system",
874 enforceVendorInterface: true,
875 enforceProductInterface: false,
876 enforceJavaSdkLibraryCheck: true,
877 }))
JaeMan Parkff715562020-10-19 17:25:58 +0900878
JaeMan Park90e75352021-01-14 11:56:56 +0900879 testJavaErrorWithConfig(t, errorMessage, createTestConfig(testConfigInfo{
880 libraryType: "java_library",
881 fromPartition: "product",
882 toPartition: "system",
883 enforceVendorInterface: true,
884 enforceProductInterface: true,
885 enforceJavaSdkLibraryCheck: true,
886 }))
JaeMan Parkff715562020-10-19 17:25:58 +0900887
JaeMan Park90e75352021-01-14 11:56:56 +0900888 testJavaErrorWithConfig(t, errorMessage, createTestConfig(testConfigInfo{
889 libraryType: "java_library",
890 fromPartition: "vendor",
891 toPartition: "system",
892 enforceVendorInterface: true,
893 enforceProductInterface: true,
894 enforceJavaSdkLibraryCheck: true,
895 }))
JaeMan Parkff715562020-10-19 17:25:58 +0900896
897 testJavaWithConfig(t, createTestConfig(testConfigInfo{
898 libraryType: "java_library",
899 fromPartition: "vendor",
900 toPartition: "system",
901 enforceVendorInterface: true,
902 enforceProductInterface: true,
903 enforceJavaSdkLibraryCheck: true,
904 allowList: []string{"bar"},
905 }))
906
907 testJavaErrorWithConfig(t, errorMessage, createTestConfig(testConfigInfo{
908 libraryType: "java_library",
909 fromPartition: "vendor",
JaeMan Park90e75352021-01-14 11:56:56 +0900910 toPartition: "product",
911 enforceVendorInterface: true,
912 enforceProductInterface: true,
913 enforceJavaSdkLibraryCheck: true,
914 }))
915
916 testJavaWithConfig(t, createTestConfig(testConfigInfo{
917 libraryType: "java_sdk_library",
918 fromPartition: "product",
JaeMan Parkff715562020-10-19 17:25:58 +0900919 toPartition: "system",
920 enforceVendorInterface: true,
921 enforceProductInterface: true,
922 enforceJavaSdkLibraryCheck: true,
JaeMan Park90e75352021-01-14 11:56:56 +0900923 }))
924
925 testJavaWithConfig(t, createTestConfig(testConfigInfo{
926 libraryType: "java_sdk_library",
927 fromPartition: "vendor",
928 toPartition: "system",
929 enforceVendorInterface: true,
930 enforceProductInterface: true,
931 enforceJavaSdkLibraryCheck: true,
932 }))
933
934 testJavaWithConfig(t, createTestConfig(testConfigInfo{
935 libraryType: "java_sdk_library",
936 fromPartition: "vendor",
937 toPartition: "product",
938 enforceVendorInterface: true,
939 enforceProductInterface: true,
940 enforceJavaSdkLibraryCheck: true,
JaeMan Parkff715562020-10-19 17:25:58 +0900941 }))
942}
943
Colin Cross89536d42017-07-07 14:35:50 -0700944func TestDefaults(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700945 ctx, _ := testJava(t, `
Colin Cross89536d42017-07-07 14:35:50 -0700946 java_defaults {
947 name: "defaults",
948 srcs: ["a.java"],
949 libs: ["bar"],
950 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -0700951 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700952 }
953
954 java_library {
955 name: "foo",
956 defaults: ["defaults"],
957 }
958
959 java_library {
960 name: "bar",
961 srcs: ["b.java"],
962 }
963
964 java_library {
965 name: "baz",
966 srcs: ["c.java"],
967 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700968
969 android_test {
970 name: "atestOptimize",
971 defaults: ["defaults"],
972 optimize: {enabled: true},
973 }
974
975 android_test {
976 name: "atestNoOptimize",
977 defaults: ["defaults"],
978 }
979
980 android_test {
981 name: "atestDefault",
982 srcs: ["a.java"],
983 }
Colin Cross89536d42017-07-07 14:35:50 -0700984 `)
985
Colin Cross4c428df2017-09-15 17:36:05 -0700986 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700987 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -0700988
989 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
990 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
991 }
992
Nan Zhanged19fc32017-10-19 13:06:22 -0700993 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
994 if !strings.Contains(javac.Args["classpath"], barTurbine) {
995 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -0700996 }
997
Colin Cross1ee23172017-10-18 14:44:18 -0700998 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -0700999 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
1000 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -07001001 }
Sasha Smundak2057f822019-04-16 17:16:58 -07001002
1003 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
1004 if atestOptimize.Output == nil {
1005 t.Errorf("atestOptimize should optimize APK")
1006 }
1007
1008 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
1009 if atestNoOptimize.Output == nil {
1010 t.Errorf("atestNoOptimize should not optimize APK")
1011 }
1012
1013 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("r8")
1014 if atestDefault.Output == nil {
1015 t.Errorf("atestDefault should optimize APK")
1016 }
Colin Cross89536d42017-07-07 14:35:50 -07001017}
1018
Colin Cross0f37af02017-09-27 17:42:05 -07001019func TestResources(t *testing.T) {
1020 var table = []struct {
1021 name string
1022 prop string
1023 extra string
1024 args string
1025 }{
1026 {
Colin Crossaf9c55b2017-10-03 14:50:08 -07001027 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -07001028 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -08001029 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -07001030 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -07001031 },
1032 {
1033 // Test that a module with java_resources includes the files
1034 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -07001035 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
1036 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -07001037 },
1038 {
1039 // Test that a module with a filegroup in java_resources includes the files with the
1040 // path prefix
1041 name: "resource filegroup",
1042 prop: `java_resources: [":foo-res"]`,
1043 extra: `
1044 filegroup {
1045 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -08001046 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -07001047 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -07001048 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -07001049 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -07001050 },
1051 {
Colin Cross0ead1d72018-04-10 13:07:42 -07001052 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
1053 name: "wildcard dirs",
1054 prop: `java_resource_dirs: ["java-res/*"]`,
1055 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
1056 },
1057 {
1058 // Test that a module exclude_java_resource_dirs excludes the files
1059 name: "wildcard dirs",
1060 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
1061 args: "-C java-res/a -f java-res/a/a",
1062 },
Colin Crosscedd4762018-09-13 11:26:19 -07001063 {
1064 // Test wildcards in java_resources
1065 name: "wildcard files",
1066 prop: `java_resources: ["java-res/**/*"]`,
1067 args: "-C . -f java-res/a/a -f java-res/b/b",
1068 },
1069 {
1070 // Test exclude_java_resources with java_resources
1071 name: "wildcard files with exclude",
1072 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
1073 args: "-C . -f java-res/a/a",
1074 },
1075 {
1076 // Test exclude_java_resources with java_resource_dirs
1077 name: "resource dirs with exclude files",
1078 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
1079 args: "-C java-res -f java-res/a/a",
1080 },
1081 {
1082 // Test exclude_java_resource_dirs with java_resource_dirs
1083 name: "resource dirs with exclude files",
1084 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
1085 args: "-C java-res -f java-res/a/a -f java-res/b/b",
1086 },
Colin Cross0f37af02017-09-27 17:42:05 -07001087 }
1088
1089 for _, test := range table {
1090 t.Run(test.name, func(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001091 ctx, _ := testJavaWithFS(t, `
Colin Cross0f37af02017-09-27 17:42:05 -07001092 java_library {
1093 name: "foo",
1094 srcs: [
1095 "a.java",
1096 "b.java",
1097 "c.java",
1098 ],
1099 `+test.prop+`,
1100 }
Colin Cross238c1f32020-06-07 16:58:18 -07001101 `+test.extra,
1102 map[string][]byte{
1103 "java-res/a/a": nil,
1104 "java-res/b/b": nil,
1105 "java-res2/a": nil,
1106 },
1107 )
Colin Cross0f37af02017-09-27 17:42:05 -07001108
Colin Cross331a1212018-08-15 20:40:52 -07001109 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -07001110 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -07001111
1112 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
1113 t.Errorf("foo combined jars %v does not contain %q",
1114 foo.Inputs.Strings(), fooRes.Output.String())
1115 }
1116
Colin Crossaf9c55b2017-10-03 14:50:08 -07001117 if fooRes.Args["jarArgs"] != test.args {
1118 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -07001119 fooRes.Args["jarArgs"], test.args)
1120 }
1121 })
1122 }
1123}
1124
Colin Cross0c4ce212019-05-03 15:28:19 -07001125func TestIncludeSrcs(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001126 ctx, _ := testJavaWithFS(t, `
Colin Cross0c4ce212019-05-03 15:28:19 -07001127 java_library {
1128 name: "foo",
1129 srcs: [
1130 "a.java",
1131 "b.java",
1132 "c.java",
1133 ],
1134 include_srcs: true,
1135 }
1136
1137 java_library {
1138 name: "bar",
1139 srcs: [
1140 "a.java",
1141 "b.java",
1142 "c.java",
1143 ],
1144 java_resource_dirs: ["java-res"],
1145 include_srcs: true,
1146 }
Colin Cross238c1f32020-06-07 16:58:18 -07001147 `, map[string][]byte{
1148 "java-res/a/a": nil,
1149 "java-res/b/b": nil,
1150 "java-res2/a": nil,
1151 })
Colin Cross0c4ce212019-05-03 15:28:19 -07001152
1153 // Test a library with include_srcs: true
1154 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
1155 fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar")
1156
1157 if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) {
1158 t.Errorf("foo combined jars %v does not contain %q", w, g)
1159 }
1160
1161 if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
1162 t.Errorf("foo source jar args %q is not %q", w, g)
1163 }
1164
1165 // Test a library with include_srcs: true and resources
1166 bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar")
1167 barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar")
1168 barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar")
1169 barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar")
1170
1171 if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
1172 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
1173 }
1174
1175 if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
1176 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
1177 }
1178
1179 if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) {
1180 t.Errorf("bar combined jars %v does not contain %q", w, g)
1181 }
1182
1183 if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
1184 t.Errorf("bar source jar args %q is not %q", w, g)
1185 }
1186
1187 if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w {
1188 t.Errorf("bar resource jar args %q is not %q", w, g)
1189 }
1190}
1191
Colin Cross54190b32017-10-09 15:34:10 -07001192func TestGeneratedSources(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001193 ctx, _ := testJavaWithFS(t, `
Colin Cross54190b32017-10-09 15:34:10 -07001194 java_library {
1195 name: "foo",
1196 srcs: [
1197 "a*.java",
1198 ":gen",
1199 "b*.java",
1200 ],
1201 }
1202
1203 genrule {
1204 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -08001205 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -07001206 out: ["gen.java"],
1207 }
Colin Cross238c1f32020-06-07 16:58:18 -07001208 `, map[string][]byte{
1209 "a.java": nil,
1210 "b.java": nil,
1211 })
Colin Cross54190b32017-10-09 15:34:10 -07001212
1213 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1214 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
1215
Colin Cross15e86d92017-10-20 15:07:08 -07001216 if filepath.Base(genrule.Output.String()) != "gen.java" {
1217 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -07001218 }
1219
1220 if len(javac.Inputs) != 3 ||
1221 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -07001222 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -07001223 javac.Inputs[2].String() != "b.java" {
1224 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
1225 }
1226}
1227
Nan Zhang61eaedb2017-11-02 13:28:15 -07001228func TestTurbine(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001229 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001230 java_library {
1231 name: "foo",
1232 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +09001233 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001234 }
1235
1236 java_library {
1237 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -08001238 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -07001239 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +09001240 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001241 }
1242
1243 java_library {
1244 name: "baz",
1245 srcs: ["c.java"],
1246 libs: ["bar"],
1247 sdk_version: "14",
1248 }
1249 `)
1250
1251 fooTurbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine")
1252 barTurbine := ctx.ModuleForTests("bar", "android_common").Rule("turbine")
1253 barJavac := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1254 barTurbineCombined := ctx.ModuleForTests("bar", "android_common").Description("for turbine")
1255 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1256
1257 if len(fooTurbine.Inputs) != 1 || fooTurbine.Inputs[0].String() != "a.java" {
1258 t.Errorf(`foo inputs %v != ["a.java"]`, fooTurbine.Inputs)
1259 }
1260
1261 fooHeaderJar := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
1262 if !strings.Contains(barTurbine.Args["classpath"], fooHeaderJar) {
1263 t.Errorf("bar turbine classpath %v does not contain %q", barTurbine.Args["classpath"], fooHeaderJar)
1264 }
1265 if !strings.Contains(barJavac.Args["classpath"], fooHeaderJar) {
1266 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], fooHeaderJar)
1267 }
1268 if len(barTurbineCombined.Inputs) != 2 || barTurbineCombined.Inputs[1].String() != fooHeaderJar {
1269 t.Errorf("bar turbine combineJar inputs %v does not contain %q", barTurbineCombined.Inputs, fooHeaderJar)
1270 }
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001271 if !strings.Contains(bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") {
Nan Zhang61eaedb2017-11-02 13:28:15 -07001272 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001273 "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -07001274 }
1275}
1276
1277func TestSharding(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001278 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001279 java_library {
1280 name: "bar",
1281 srcs: ["a.java","b.java","c.java"],
1282 javac_shard_size: 1
1283 }
1284 `)
1285
1286 barHeaderJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
1287 for i := 0; i < 3; i++ {
1288 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
1289 if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) {
1290 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar)
1291 }
1292 }
1293}
1294
Nan Zhang581fd212018-01-10 16:06:12 -08001295func TestDroiddoc(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001296 ctx, _ := testJavaWithFS(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001297 droiddoc_exported_dir {
Dan Willemsencc090972018-02-26 14:33:31 -08001298 name: "droiddoc-templates-sdk",
1299 path: ".",
1300 }
Jiyong Park29074592019-07-07 16:27:47 +09001301 filegroup {
1302 name: "bar-doc-aidl-srcs",
1303 srcs: ["bar-doc/IBar.aidl"],
1304 path: "bar-doc",
1305 }
Liz Kammere1ab2502020-09-10 15:29:25 +00001306 droidstubs {
1307 name: "bar-stubs",
Liz Kammer3a55c912020-08-14 12:14:02 -07001308 srcs: [
Steve Kim3666c702020-09-01 17:58:01 +00001309 "bar-doc/a.java",
Liz Kammer3a55c912020-08-14 12:14:02 -07001310 ],
Steve Kim3666c702020-09-01 17:58:01 +00001311 exclude_srcs: [
1312 "bar-doc/b.java"
1313 ],
Liz Kammere1ab2502020-09-10 15:29:25 +00001314 api_levels_annotations_dirs: [
1315 "droiddoc-templates-sdk",
1316 ],
1317 api_levels_annotations_enabled: true,
1318 }
1319 droiddoc {
1320 name: "bar-doc",
1321 srcs: [
1322 ":bar-stubs",
1323 "bar-doc/IFoo.aidl",
1324 ":bar-doc-aidl-srcs",
1325 ],
Dan Willemsencc090972018-02-26 14:33:31 -08001326 custom_template: "droiddoc-templates-sdk",
Nan Zhang581fd212018-01-10 16:06:12 -08001327 hdf: [
1328 "android.whichdoc offline",
1329 ],
1330 knowntags: [
1331 "bar-doc/known_oj_tags.txt",
1332 ],
1333 proofread_file: "libcore-proofread.txt",
1334 todo_file: "libcore-docs-todo.html",
Liz Kammer585cac22020-07-06 09:12:57 -07001335 flags: ["-offlinemode -title \"libcore\""],
Nan Zhang581fd212018-01-10 16:06:12 -08001336 }
Colin Cross238c1f32020-06-07 16:58:18 -07001337 `,
1338 map[string][]byte{
1339 "bar-doc/a.java": nil,
1340 "bar-doc/b.java": nil,
1341 })
Liz Kammere1ab2502020-09-10 15:29:25 +00001342 barStubs := ctx.ModuleForTests("bar-stubs", "android_common")
1343 barStubsOutputs, err := barStubs.Module().(*Droidstubs).OutputFiles("")
1344 if err != nil {
1345 t.Errorf("Unexpected error %q retrieving \"bar-stubs\" output file", err)
1346 }
1347 if len(barStubsOutputs) != 1 {
1348 t.Errorf("Expected one output from \"bar-stubs\" got %s", barStubsOutputs)
Liz Kammer1e2ee122020-07-30 15:07:22 -07001349 }
Nan Zhang581fd212018-01-10 16:06:12 -08001350
Liz Kammere1ab2502020-09-10 15:29:25 +00001351 barStubsOutput := barStubsOutputs[0]
1352 barDoc := ctx.ModuleForTests("bar-doc", "android_common")
1353 javaDoc := barDoc.Rule("javadoc")
1354 if g, w := javaDoc.Implicits.Strings(), barStubsOutput.String(); !inList(w, g) {
1355 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
Jiyong Park29074592019-07-07 16:27:47 +09001356 }
1357
Liz Kammere1ab2502020-09-10 15:29:25 +00001358 expected := "-sourcepath " + buildDir + "/.intermediates/bar-doc/android_common/srcjars "
1359 if !strings.Contains(javaDoc.RuleParams.Command, expected) {
1360 t.Errorf("bar-doc command does not contain flag %q, but should\n%q", expected, javaDoc.RuleParams.Command)
1361 }
1362
1363 aidl := barDoc.Rule("aidl")
1364 if g, w := javaDoc.Implicits.Strings(), aidl.Output.String(); !inList(w, g) {
Colin Crossc0806172019-06-14 18:51:47 -07001365 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
1366 }
1367
1368 if g, w := aidl.Implicits.Strings(), []string{"bar-doc/IBar.aidl", "bar-doc/IFoo.aidl"}; !reflect.DeepEqual(w, g) {
1369 t.Errorf("aidl inputs must be %q, but was %q", w, g)
Jiyong Park1e440682018-05-23 18:42:04 +09001370 }
Nan Zhang581fd212018-01-10 16:06:12 -08001371}
1372
Liz Kammer585cac22020-07-06 09:12:57 -07001373func TestDroiddocArgsAndFlagsCausesError(t *testing.T) {
1374 testJavaError(t, "flags is set. Cannot set args", `
1375 droiddoc_exported_dir {
1376 name: "droiddoc-templates-sdk",
1377 path: ".",
1378 }
1379 filegroup {
1380 name: "bar-doc-aidl-srcs",
1381 srcs: ["bar-doc/IBar.aidl"],
1382 path: "bar-doc",
1383 }
Liz Kammere1ab2502020-09-10 15:29:25 +00001384 droidstubs {
1385 name: "bar-stubs",
Liz Kammer3a55c912020-08-14 12:14:02 -07001386 srcs: [
Steve Kim3666c702020-09-01 17:58:01 +00001387 "bar-doc/a.java",
Liz Kammer3a55c912020-08-14 12:14:02 -07001388 ],
Steve Kim3666c702020-09-01 17:58:01 +00001389 exclude_srcs: [
1390 "bar-doc/b.java"
1391 ],
Liz Kammere1ab2502020-09-10 15:29:25 +00001392 api_levels_annotations_dirs: [
1393 "droiddoc-templates-sdk",
1394 ],
1395 api_levels_annotations_enabled: true,
1396 }
1397 droiddoc {
1398 name: "bar-doc",
1399 srcs: [
1400 ":bar-stubs",
1401 "bar-doc/IFoo.aidl",
1402 ":bar-doc-aidl-srcs",
1403 ],
Liz Kammer585cac22020-07-06 09:12:57 -07001404 custom_template: "droiddoc-templates-sdk",
1405 hdf: [
1406 "android.whichdoc offline",
1407 ],
1408 knowntags: [
1409 "bar-doc/known_oj_tags.txt",
1410 ],
1411 proofread_file: "libcore-proofread.txt",
1412 todo_file: "libcore-docs-todo.html",
1413 flags: ["-offlinemode -title \"libcore\""],
1414 args: "-offlinemode -title \"libcore\"",
1415 }
1416 `)
1417}
1418
Liz Kammer3d894b72020-08-04 09:55:13 -07001419func TestDroidstubs(t *testing.T) {
1420 ctx, _ := testJavaWithFS(t, `
1421 droiddoc_exported_dir {
Anton Hansson52ac73d2020-10-26 09:57:40 +00001422 name: "droiddoc-templates-sdk",
1423 path: ".",
Liz Kammer3d894b72020-08-04 09:55:13 -07001424 }
1425
1426 droidstubs {
Anton Hansson52ac73d2020-10-26 09:57:40 +00001427 name: "bar-stubs",
1428 srcs: ["bar-doc/a.java"],
1429 api_levels_annotations_dirs: ["droiddoc-templates-sdk"],
1430 api_levels_annotations_enabled: true,
Liz Kammer3d894b72020-08-04 09:55:13 -07001431 }
1432
1433 droidstubs {
Anton Hansson52ac73d2020-10-26 09:57:40 +00001434 name: "bar-stubs-other",
1435 srcs: ["bar-doc/a.java"],
1436 high_mem: true,
1437 api_levels_annotations_dirs: ["droiddoc-templates-sdk"],
1438 api_levels_annotations_enabled: true,
1439 api_levels_jar_filename: "android.other.jar",
Liz Kammer3d894b72020-08-04 09:55:13 -07001440 }
1441 `,
1442 map[string][]byte{
1443 "bar-doc/a.java": nil,
1444 })
1445 testcases := []struct {
1446 moduleName string
1447 expectedJarFilename string
Anton Hansson52ac73d2020-10-26 09:57:40 +00001448 high_mem bool
Liz Kammer3d894b72020-08-04 09:55:13 -07001449 }{
1450 {
1451 moduleName: "bar-stubs",
1452 expectedJarFilename: "android.jar",
Anton Hansson52ac73d2020-10-26 09:57:40 +00001453 high_mem: false,
Liz Kammer3d894b72020-08-04 09:55:13 -07001454 },
1455 {
1456 moduleName: "bar-stubs-other",
1457 expectedJarFilename: "android.other.jar",
Anton Hansson52ac73d2020-10-26 09:57:40 +00001458 high_mem: true,
Liz Kammer3d894b72020-08-04 09:55:13 -07001459 },
1460 }
1461 for _, c := range testcases {
1462 m := ctx.ModuleForTests(c.moduleName, "android_common")
1463 metalava := m.Rule("metalava")
Anton Hansson52ac73d2020-10-26 09:57:40 +00001464 rp := metalava.RuleParams
Liz Kammer3d894b72020-08-04 09:55:13 -07001465 expected := "--android-jar-pattern ./%/public/" + c.expectedJarFilename
Anton Hansson52ac73d2020-10-26 09:57:40 +00001466 if actual := rp.Command; !strings.Contains(actual, expected) {
Liz Kammer3d894b72020-08-04 09:55:13 -07001467 t.Errorf("For %q, expected metalava argument %q, but was not found %q", c.moduleName, expected, actual)
1468 }
Anton Hansson52ac73d2020-10-26 09:57:40 +00001469
1470 if actual := rp.Pool != nil && strings.Contains(rp.Pool.String(), "highmem"); actual != c.high_mem {
1471 t.Errorf("Expected %q high_mem to be %v, was %v", c.moduleName, c.high_mem, actual)
1472 }
Liz Kammer3d894b72020-08-04 09:55:13 -07001473 }
1474}
1475
Paul Duffin83a2d962019-11-19 19:44:10 +00001476func TestDroidstubsWithSystemModules(t *testing.T) {
1477 ctx, _ := testJava(t, `
1478 droidstubs {
1479 name: "stubs-source-system-modules",
1480 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001481 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001482 ],
1483 sdk_version: "none",
1484 system_modules: "source-system-modules",
1485 }
1486
1487 java_library {
1488 name: "source-jar",
1489 srcs: [
1490 "a.java",
1491 ],
1492 }
1493
1494 java_system_modules {
1495 name: "source-system-modules",
1496 libs: ["source-jar"],
1497 }
1498
1499 droidstubs {
1500 name: "stubs-prebuilt-system-modules",
1501 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001502 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001503 ],
1504 sdk_version: "none",
1505 system_modules: "prebuilt-system-modules",
1506 }
1507
1508 java_import {
1509 name: "prebuilt-jar",
1510 jars: ["a.jar"],
1511 }
1512
1513 java_system_modules_import {
1514 name: "prebuilt-system-modules",
1515 libs: ["prebuilt-jar"],
1516 }
1517 `)
1518
1519 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-source-system-modules", "source-jar.jar")
1520
1521 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-prebuilt-system-modules", "prebuilt-jar.jar")
1522}
1523
1524func checkSystemModulesUseByDroidstubs(t *testing.T, ctx *android.TestContext, moduleName string, systemJar string) {
1525 metalavaRule := ctx.ModuleForTests(moduleName, "android_common").Rule("metalava")
1526 var systemJars []string
1527 for _, i := range metalavaRule.Implicits {
1528 systemJars = append(systemJars, i.Base())
1529 }
Ramy Medhatc7965cd2020-04-30 03:08:37 -04001530 if len(systemJars) < 1 || systemJars[0] != systemJar {
Paul Duffin83a2d962019-11-19 19:44:10 +00001531 t.Errorf("inputs of %q must be []string{%q}, but was %#v.", moduleName, systemJar, systemJars)
1532 }
1533}
1534
Colin Cross54250902017-12-05 09:28:08 -08001535func TestJarGenrules(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001536 ctx, _ := testJava(t, `
Colin Cross54250902017-12-05 09:28:08 -08001537 java_library {
1538 name: "foo",
1539 srcs: ["a.java"],
1540 }
1541
1542 java_genrule {
1543 name: "jargen",
1544 tool_files: ["b.java"],
1545 cmd: "$(location b.java) $(in) $(out)",
1546 out: ["jargen.jar"],
1547 srcs: [":foo"],
1548 }
1549
1550 java_library {
1551 name: "bar",
1552 static_libs: ["jargen"],
1553 srcs: ["c.java"],
1554 }
1555
1556 java_library {
1557 name: "baz",
1558 libs: ["jargen"],
1559 srcs: ["c.java"],
1560 }
1561 `)
1562
1563 foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar")
1564 jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar")
1565 bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar")
1566 baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar")
1567 barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar")
1568
Colin Cross3d680512020-11-13 16:23:53 -08001569 if g, w := jargen.Implicits.Strings(), foo.Output.String(); !android.InList(w, g) {
1570 t.Errorf("expected jargen inputs [%q], got %q", w, g)
Colin Cross54250902017-12-05 09:28:08 -08001571 }
1572
1573 if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) {
1574 t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String())
1575 }
1576
1577 if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) {
1578 t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String())
1579 }
1580
1581 if len(barCombined.Inputs) != 2 ||
1582 barCombined.Inputs[0].String() != bar.Output.String() ||
1583 barCombined.Inputs[1].String() != jargen.Output.String() {
1584 t.Errorf("bar combined jar inputs %v is not [%q, %q]",
1585 barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String())
1586 }
1587}
1588
Nan Zhang27e284d2018-02-09 21:03:53 +00001589func TestExcludeFileGroupInSrcs(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001590 ctx, _ := testJava(t, `
Nan Zhang27e284d2018-02-09 21:03:53 +00001591 java_library {
1592 name: "foo",
1593 srcs: ["a.java", ":foo-srcs"],
1594 exclude_srcs: ["a.java", ":foo-excludes"],
1595 }
1596
1597 filegroup {
1598 name: "foo-srcs",
1599 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
1600 }
1601
1602 filegroup {
1603 name: "foo-excludes",
1604 srcs: ["java-fg/a.java", "java-fg/b.java"],
1605 }
1606 `)
1607
1608 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1609
1610 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
1611 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
1612 }
1613}
Jiyong Parkc678ad32018-04-10 13:07:10 +09001614
Paul Duffin52d398a2019-06-11 12:31:14 +01001615func TestJavaLibrary(t *testing.T) {
Colin Cross98be1bb2019-12-13 20:41:13 -08001616 config := testConfig(nil, "", map[string][]byte{
Paul Duffin52d398a2019-06-11 12:31:14 +01001617 "libcore/Android.bp": []byte(`
1618 java_library {
1619 name: "core",
1620 sdk_version: "none",
1621 system_modules: "none",
Paul Duffinaa55f742020-10-06 17:20:13 +01001622 }
1623
1624 filegroup {
1625 name: "core-jar",
1626 srcs: [":core{.jar}"],
1627 }
1628`),
1629 })
Colin Crossae8600b2020-10-29 17:09:13 -07001630 ctx := testContext(config)
Paul Duffinaa55f742020-10-06 17:20:13 +01001631 run(t, ctx, config)
1632}
1633
1634func TestJavaImport(t *testing.T) {
1635 config := testConfig(nil, "", map[string][]byte{
1636 "libcore/Android.bp": []byte(`
1637 java_import {
1638 name: "core",
1639 sdk_version: "none",
1640 }
1641
1642 filegroup {
1643 name: "core-jar",
1644 srcs: [":core{.jar}"],
1645 }
1646`),
Paul Duffin52d398a2019-06-11 12:31:14 +01001647 })
Colin Crossae8600b2020-10-29 17:09:13 -07001648 ctx := testContext(config)
Paul Duffin52d398a2019-06-11 12:31:14 +01001649 run(t, ctx, config)
1650}
1651
Jiyong Parkc678ad32018-04-10 13:07:10 +09001652func TestJavaSdkLibrary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001653 ctx, _ := testJava(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001654 droiddoc_exported_dir {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001655 name: "droiddoc-templates-sdk",
1656 path: ".",
1657 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001658 java_sdk_library {
1659 name: "foo",
1660 srcs: ["a.java", "b.java"],
1661 api_packages: ["foo"],
1662 }
1663 java_sdk_library {
1664 name: "bar",
1665 srcs: ["a.java", "b.java"],
1666 api_packages: ["bar"],
1667 }
1668 java_library {
1669 name: "baz",
1670 srcs: ["c.java"],
Paul Duffin859fe962020-05-15 10:20:31 +01001671 libs: ["foo", "bar.stubs"],
Jiyong Parkc678ad32018-04-10 13:07:10 +09001672 sdk_version: "system_current",
1673 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001674 java_sdk_library {
1675 name: "barney",
1676 srcs: ["c.java"],
1677 api_only: true,
1678 }
1679 java_sdk_library {
1680 name: "betty",
1681 srcs: ["c.java"],
1682 shared_library: false,
1683 }
Paul Duffin859fe962020-05-15 10:20:31 +01001684 java_sdk_library_import {
1685 name: "quuz",
1686 public: {
1687 jars: ["c.jar"],
1688 },
1689 }
1690 java_sdk_library_import {
1691 name: "fred",
1692 public: {
1693 jars: ["b.jar"],
1694 },
1695 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001696 java_sdk_library_import {
1697 name: "wilma",
1698 public: {
1699 jars: ["b.jar"],
1700 },
1701 shared_library: false,
1702 }
Jiyong Park1be96912018-05-28 18:02:19 +09001703 java_library {
1704 name: "qux",
1705 srcs: ["c.java"],
Paul Duffindfa131e2020-05-15 20:37:11 +01001706 libs: ["baz", "fred", "quuz.stubs", "wilma", "barney", "betty"],
Jiyong Park1be96912018-05-28 18:02:19 +09001707 sdk_version: "system_current",
1708 }
Paul Duffin726d23c2020-01-22 16:30:37 +00001709 java_library {
1710 name: "baz-test",
1711 srcs: ["c.java"],
1712 libs: ["foo"],
1713 sdk_version: "test_current",
1714 }
Paul Duffina2db18f2020-01-22 17:11:15 +00001715 java_library {
1716 name: "baz-29",
1717 srcs: ["c.java"],
1718 libs: ["foo"],
1719 sdk_version: "system_29",
1720 }
Paul Duffinfb6ae5b2020-09-30 15:17:25 +01001721 java_library {
1722 name: "baz-module-30",
1723 srcs: ["c.java"],
1724 libs: ["foo"],
1725 sdk_version: "module_30",
1726 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001727 `)
1728
1729 // check the existence of the internal modules
1730 ctx.ModuleForTests("foo", "android_common")
Paul Duffindd9d0742020-05-08 15:52:37 +01001731 ctx.ModuleForTests(apiScopePublic.stubsLibraryModuleName("foo"), "android_common")
1732 ctx.ModuleForTests(apiScopeSystem.stubsLibraryModuleName("foo"), "android_common")
1733 ctx.ModuleForTests(apiScopeTest.stubsLibraryModuleName("foo"), "android_common")
1734 ctx.ModuleForTests(apiScopePublic.stubsSourceModuleName("foo"), "android_common")
1735 ctx.ModuleForTests(apiScopeSystem.stubsSourceModuleName("foo"), "android_common")
1736 ctx.ModuleForTests(apiScopeTest.stubsSourceModuleName("foo"), "android_common")
Jiyong Parke3833882020-02-17 17:28:10 +09001737 ctx.ModuleForTests("foo"+sdkXmlFileSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +09001738 ctx.ModuleForTests("foo.api.public.28", "")
1739 ctx.ModuleForTests("foo.api.system.28", "")
1740 ctx.ModuleForTests("foo.api.test.28", "")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001741
1742 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1743 // tests if baz is actually linked to the stubs lib
1744 if !strings.Contains(bazJavac.Args["classpath"], "foo.stubs.system.jar") {
1745 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
1746 "foo.stubs.system.jar")
1747 }
1748 // ... and not to the impl lib
Sundong Ahn054b19a2018-10-19 13:46:09 +09001749 if strings.Contains(bazJavac.Args["classpath"], "foo.jar") {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001750 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
Sundong Ahn054b19a2018-10-19 13:46:09 +09001751 "foo.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001752 }
1753 // test if baz is not linked to the system variant of foo
1754 if strings.Contains(bazJavac.Args["classpath"], "foo.stubs.jar") {
1755 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
1756 "foo.stubs.jar")
1757 }
Jiyong Park1be96912018-05-28 18:02:19 +09001758
Paul Duffin726d23c2020-01-22 16:30:37 +00001759 bazTestJavac := ctx.ModuleForTests("baz-test", "android_common").Rule("javac")
1760 // tests if baz-test is actually linked to the test stubs lib
1761 if !strings.Contains(bazTestJavac.Args["classpath"], "foo.stubs.test.jar") {
1762 t.Errorf("baz-test javac classpath %v does not contain %q", bazTestJavac.Args["classpath"],
1763 "foo.stubs.test.jar")
1764 }
1765
Paul Duffina2db18f2020-01-22 17:11:15 +00001766 baz29Javac := ctx.ModuleForTests("baz-29", "android_common").Rule("javac")
1767 // tests if baz-29 is actually linked to the system 29 stubs lib
1768 if !strings.Contains(baz29Javac.Args["classpath"], "prebuilts/sdk/29/system/foo.jar") {
1769 t.Errorf("baz-29 javac classpath %v does not contain %q", baz29Javac.Args["classpath"],
1770 "prebuilts/sdk/29/system/foo.jar")
1771 }
1772
Paul Duffinfb6ae5b2020-09-30 15:17:25 +01001773 bazModule30Javac := ctx.ModuleForTests("baz-module-30", "android_common").Rule("javac")
1774 // tests if "baz-module-30" is actually linked to the module 30 stubs lib
1775 if !strings.Contains(bazModule30Javac.Args["classpath"], "prebuilts/sdk/30/module-lib/foo.jar") {
1776 t.Errorf("baz-module-30 javac classpath %v does not contain %q", bazModule30Javac.Args["classpath"],
1777 "prebuilts/sdk/30/module-lib/foo.jar")
1778 }
1779
Jiyong Park1be96912018-05-28 18:02:19 +09001780 // test if baz has exported SDK lib names foo and bar to qux
1781 qux := ctx.ModuleForTests("qux", "android_common")
1782 if quxLib, ok := qux.Module().(*Library); ok {
Ulya Trafimovichb23d28c2020-10-08 12:53:58 +01001783 sdkLibs := quxLib.ClassLoaderContexts().UsesLibs()
Ulya Trafimovich8cbc5d22020-11-03 15:15:46 +00001784 if w := []string{"foo", "bar", "fred", "quuz"}; !reflect.DeepEqual(w, sdkLibs) {
Paul Duffin859fe962020-05-15 10:20:31 +01001785 t.Errorf("qux should export %q but exports %q", w, sdkLibs)
Jiyong Park1be96912018-05-28 18:02:19 +09001786 }
1787 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001788}
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001789
Anton Hansson7f66efa2020-10-08 14:47:23 +01001790func TestJavaSdkLibrary_StubOrImplOnlyLibs(t *testing.T) {
1791 ctx, _ := testJava(t, `
1792 java_sdk_library {
Anton Hanssondff2c782020-12-21 17:10:01 +00001793 name: "sdklib",
Anton Hansson7f66efa2020-10-08 14:47:23 +01001794 srcs: ["a.java"],
1795 impl_only_libs: ["foo"],
1796 stub_only_libs: ["bar"],
1797 }
1798 java_library {
1799 name: "foo",
1800 srcs: ["a.java"],
1801 sdk_version: "current",
1802 }
1803 java_library {
1804 name: "bar",
1805 srcs: ["a.java"],
1806 sdk_version: "current",
1807 }
1808 `)
1809
Anton Hanssondff2c782020-12-21 17:10:01 +00001810 for _, implName := range []string{"sdklib", "sdklib.impl"} {
Anton Hansson7f66efa2020-10-08 14:47:23 +01001811 implJavacCp := ctx.ModuleForTests(implName, "android_common").Rule("javac").Args["classpath"]
1812 if !strings.Contains(implJavacCp, "/foo.jar") || strings.Contains(implJavacCp, "/bar.jar") {
1813 t.Errorf("%v javac classpath %v does not contain foo and not bar", implName, implJavacCp)
1814 }
1815 }
Anton Hanssondff2c782020-12-21 17:10:01 +00001816 stubName := apiScopePublic.stubsLibraryModuleName("sdklib")
Anton Hansson7f66efa2020-10-08 14:47:23 +01001817 stubsJavacCp := ctx.ModuleForTests(stubName, "android_common").Rule("javac").Args["classpath"]
1818 if strings.Contains(stubsJavacCp, "/foo.jar") || !strings.Contains(stubsJavacCp, "/bar.jar") {
1819 t.Errorf("stubs javac classpath %v does not contain bar and not foo", stubsJavacCp)
1820 }
1821}
1822
Paul Duffindaaa3322020-05-26 18:13:57 +01001823func TestJavaSdkLibrary_DoNotAccessImplWhenItIsNotBuilt(t *testing.T) {
1824 ctx, _ := testJava(t, `
1825 java_sdk_library {
1826 name: "foo",
1827 srcs: ["a.java"],
1828 api_only: true,
1829 public: {
1830 enabled: true,
1831 },
1832 }
1833
1834 java_library {
1835 name: "bar",
1836 srcs: ["b.java"],
1837 libs: ["foo"],
1838 }
1839 `)
1840
1841 // The bar library should depend on the stubs jar.
1842 barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1843 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1844 t.Errorf("expected %q, found %#q", expected, actual)
1845 }
1846}
1847
Paul Duffin46dc45a2020-05-14 15:39:10 +01001848func TestJavaSdkLibrary_UseSourcesFromAnotherSdkLibrary(t *testing.T) {
1849 testJava(t, `
1850 java_sdk_library {
1851 name: "foo",
1852 srcs: ["a.java"],
1853 api_packages: ["foo"],
1854 public: {
1855 enabled: true,
1856 },
1857 }
1858
1859 java_library {
1860 name: "bar",
1861 srcs: ["b.java", ":foo{.public.stubs.source}"],
1862 }
1863 `)
1864}
1865
1866func TestJavaSdkLibrary_AccessOutputFiles_MissingScope(t *testing.T) {
1867 testJavaError(t, `"foo" does not provide api scope system`, `
1868 java_sdk_library {
1869 name: "foo",
1870 srcs: ["a.java"],
1871 api_packages: ["foo"],
1872 public: {
1873 enabled: true,
1874 },
1875 }
1876
1877 java_library {
1878 name: "bar",
1879 srcs: ["b.java", ":foo{.system.stubs.source}"],
1880 }
1881 `)
1882}
1883
Paul Duffinca8d9a52020-06-26 22:20:25 +01001884func TestJavaSdkLibrary_Deps(t *testing.T) {
1885 ctx, _ := testJava(t, `
1886 java_sdk_library {
1887 name: "sdklib",
1888 srcs: ["a.java"],
1889 sdk_version: "none",
1890 system_modules: "none",
1891 public: {
1892 enabled: true,
1893 },
1894 }
1895 `)
1896
Paul Duffincee7e662020-07-09 17:32:57 +01001897 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +01001898 `dex2oatd`,
1899 `sdklib.impl`,
1900 `sdklib.stubs`,
1901 `sdklib.stubs.source`,
1902 `sdklib.xml`,
1903 })
1904}
1905
Paul Duffin46dc45a2020-05-14 15:39:10 +01001906func TestJavaSdkLibraryImport_AccessOutputFiles(t *testing.T) {
1907 testJava(t, `
1908 java_sdk_library_import {
1909 name: "foo",
1910 public: {
1911 jars: ["a.jar"],
1912 stub_srcs: ["a.java"],
1913 current_api: "api/current.txt",
1914 removed_api: "api/removed.txt",
1915 },
1916 }
1917
1918 java_library {
1919 name: "bar",
1920 srcs: [":foo{.public.stubs.source}"],
1921 java_resources: [
1922 ":foo{.public.api.txt}",
1923 ":foo{.public.removed-api.txt}",
1924 ],
1925 }
1926 `)
1927}
1928
1929func TestJavaSdkLibraryImport_AccessOutputFiles_Invalid(t *testing.T) {
1930 bp := `
1931 java_sdk_library_import {
1932 name: "foo",
1933 public: {
1934 jars: ["a.jar"],
1935 },
1936 }
1937 `
1938
1939 t.Run("stubs.source", func(t *testing.T) {
1940 testJavaError(t, `stubs.source not available for api scope public`, bp+`
1941 java_library {
1942 name: "bar",
1943 srcs: [":foo{.public.stubs.source}"],
1944 java_resources: [
1945 ":foo{.public.api.txt}",
1946 ":foo{.public.removed-api.txt}",
1947 ],
1948 }
1949 `)
1950 })
1951
1952 t.Run("api.txt", func(t *testing.T) {
1953 testJavaError(t, `api.txt not available for api scope public`, bp+`
1954 java_library {
1955 name: "bar",
1956 srcs: ["a.java"],
1957 java_resources: [
1958 ":foo{.public.api.txt}",
1959 ],
1960 }
1961 `)
1962 })
1963
1964 t.Run("removed-api.txt", func(t *testing.T) {
1965 testJavaError(t, `removed-api.txt not available for api scope public`, bp+`
1966 java_library {
1967 name: "bar",
1968 srcs: ["a.java"],
1969 java_resources: [
1970 ":foo{.public.removed-api.txt}",
1971 ],
1972 }
1973 `)
1974 })
1975}
1976
Paul Duffin3375e352020-04-28 10:44:03 +01001977func TestJavaSdkLibrary_InvalidScopes(t *testing.T) {
1978 testJavaError(t, `module "foo": enabled api scope "system" depends on disabled scope "public"`, `
1979 java_sdk_library {
1980 name: "foo",
1981 srcs: ["a.java", "b.java"],
1982 api_packages: ["foo"],
1983 // Explicitly disable public to test the check that ensures the set of enabled
1984 // scopes is consistent.
1985 public: {
1986 enabled: false,
1987 },
1988 system: {
1989 enabled: true,
1990 },
1991 }
1992 `)
1993}
1994
Paul Duffin87a05a32020-05-12 11:50:28 +01001995func TestJavaSdkLibrary_SdkVersion_ForScope(t *testing.T) {
1996 testJava(t, `
1997 java_sdk_library {
1998 name: "foo",
1999 srcs: ["a.java", "b.java"],
2000 api_packages: ["foo"],
2001 system: {
2002 enabled: true,
2003 sdk_version: "module_current",
2004 },
2005 }
2006 `)
2007}
2008
Paul Duffin0c5bae52020-06-02 13:00:08 +01002009func TestJavaSdkLibrary_ModuleLib(t *testing.T) {
2010 testJava(t, `
2011 java_sdk_library {
2012 name: "foo",
2013 srcs: ["a.java", "b.java"],
2014 api_packages: ["foo"],
2015 system: {
2016 enabled: true,
2017 },
2018 module_lib: {
2019 enabled: true,
2020 },
2021 }
2022 `)
2023}
2024
2025func TestJavaSdkLibrary_SystemServer(t *testing.T) {
2026 testJava(t, `
2027 java_sdk_library {
2028 name: "foo",
2029 srcs: ["a.java", "b.java"],
2030 api_packages: ["foo"],
2031 system: {
2032 enabled: true,
2033 },
2034 system_server: {
2035 enabled: true,
2036 },
2037 }
2038 `)
2039}
2040
Paul Duffin803a9562020-05-20 11:52:25 +01002041func TestJavaSdkLibrary_MissingScope(t *testing.T) {
2042 testJavaError(t, `requires api scope module-lib from foo but it only has \[\] available`, `
2043 java_sdk_library {
2044 name: "foo",
2045 srcs: ["a.java"],
2046 public: {
2047 enabled: false,
2048 },
2049 }
2050
2051 java_library {
2052 name: "baz",
2053 srcs: ["a.java"],
2054 libs: ["foo"],
2055 sdk_version: "module_current",
2056 }
2057 `)
2058}
2059
2060func TestJavaSdkLibrary_FallbackScope(t *testing.T) {
2061 testJava(t, `
2062 java_sdk_library {
2063 name: "foo",
2064 srcs: ["a.java"],
2065 system: {
2066 enabled: true,
2067 },
2068 }
2069
2070 java_library {
2071 name: "baz",
2072 srcs: ["a.java"],
2073 libs: ["foo"],
2074 // foo does not have module-lib scope so it should fallback to system
2075 sdk_version: "module_current",
2076 }
2077 `)
2078}
2079
Jiyong Park932cdfe2020-05-28 00:19:53 +09002080func TestJavaSdkLibrary_DefaultToStubs(t *testing.T) {
2081 ctx, _ := testJava(t, `
2082 java_sdk_library {
2083 name: "foo",
2084 srcs: ["a.java"],
2085 system: {
2086 enabled: true,
2087 },
2088 default_to_stubs: true,
2089 }
2090
2091 java_library {
2092 name: "baz",
2093 srcs: ["a.java"],
2094 libs: ["foo"],
2095 // does not have sdk_version set, should fallback to module,
2096 // which will then fallback to system because the module scope
2097 // is not enabled.
2098 }
2099 `)
2100 // The baz library should depend on the system stubs jar.
2101 bazLibrary := ctx.ModuleForTests("baz", "android_common").Rule("javac")
2102 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs.system\.jar$`, bazLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
2103 t.Errorf("expected %q, found %#q", expected, actual)
2104 }
2105}
2106
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02002107var compilerFlagsTestCases = []struct {
2108 in string
2109 out bool
2110}{
2111 {
2112 in: "a",
2113 out: false,
2114 },
2115 {
2116 in: "-a",
2117 out: true,
2118 },
2119 {
2120 in: "-no-jdk",
2121 out: false,
2122 },
2123 {
2124 in: "-no-stdlib",
2125 out: false,
2126 },
2127 {
2128 in: "-kotlin-home",
2129 out: false,
2130 },
2131 {
2132 in: "-kotlin-home /some/path",
2133 out: false,
2134 },
2135 {
2136 in: "-include-runtime",
2137 out: false,
2138 },
2139 {
2140 in: "-Xintellij-plugin-root",
2141 out: false,
2142 },
2143}
2144
2145type mockContext struct {
2146 android.ModuleContext
2147 result bool
2148}
2149
2150func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
2151 // CheckBadCompilerFlags calls this function when the flag should be rejected
2152 ctx.result = false
2153}
2154
2155func TestCompilerFlags(t *testing.T) {
2156 for _, testCase := range compilerFlagsTestCases {
2157 ctx := &mockContext{result: true}
2158 CheckKotlincFlags(ctx, []string{testCase.in})
2159 if ctx.result != testCase.out {
2160 t.Errorf("incorrect output:")
2161 t.Errorf(" input: %#v", testCase.in)
2162 t.Errorf(" expected: %#v", testCase.out)
2163 t.Errorf(" got: %#v", ctx.result)
2164 }
2165 }
2166}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002167
2168// TODO(jungjw): Consider making this more robust by ignoring path order.
2169func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
2170 variables := ctx.ModuleForTests(moduleName, "android_common").Module().VariablesForTests()
2171 flags := strings.Split(variables["javacFlags"], " ")
2172 got := ""
2173 for _, flag := range flags {
2174 keyEnd := strings.Index(flag, "=")
2175 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
2176 got = flag[keyEnd+1:]
2177 break
2178 }
2179 }
2180 if expected != got {
2181 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
2182 }
2183}
2184
2185func TestPatchModule(t *testing.T) {
Pete Gillin0c2143e2019-05-02 15:32:11 +01002186 t.Run("Java language level 8", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01002187 // Test with legacy javac -source 1.8 -target 1.8
Pete Gillinbdf5d712019-10-21 14:29:58 +01002188 bp := `
2189 java_library {
2190 name: "foo",
2191 srcs: ["a.java"],
2192 java_version: "1.8",
2193 }
2194
2195 java_library {
2196 name: "bar",
2197 srcs: ["b.java"],
2198 sdk_version: "none",
2199 system_modules: "none",
2200 patch_module: "java.base",
2201 java_version: "1.8",
2202 }
2203
2204 java_library {
2205 name: "baz",
2206 srcs: ["c.java"],
2207 patch_module: "java.base",
2208 java_version: "1.8",
2209 }
2210 `
2211 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002212
2213 checkPatchModuleFlag(t, ctx, "foo", "")
2214 checkPatchModuleFlag(t, ctx, "bar", "")
2215 checkPatchModuleFlag(t, ctx, "baz", "")
2216 })
2217
Pete Gillin0c2143e2019-05-02 15:32:11 +01002218 t.Run("Java language level 9", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01002219 // Test with default javac -source 9 -target 9
Pete Gillinbdf5d712019-10-21 14:29:58 +01002220 bp := `
2221 java_library {
2222 name: "foo",
2223 srcs: ["a.java"],
2224 }
2225
2226 java_library {
2227 name: "bar",
2228 srcs: ["b.java"],
2229 sdk_version: "none",
2230 system_modules: "none",
2231 patch_module: "java.base",
2232 }
2233
2234 java_library {
2235 name: "baz",
Jingwen Chen5136a6e2020-10-30 01:01:35 -04002236 srcs: [
2237 "c.java",
2238 // Tests for b/150878007
2239 "dir/d.java",
2240 "dir2/e.java",
2241 "dir2/f.java",
2242 "nested/dir/g.java"
2243 ],
Pete Gillinbdf5d712019-10-21 14:29:58 +01002244 patch_module: "java.base",
2245 }
2246 `
Pete Gillin1b3370f2019-10-01 13:57:31 +01002247 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002248
2249 checkPatchModuleFlag(t, ctx, "foo", "")
2250 expected := "java.base=.:" + buildDir
2251 checkPatchModuleFlag(t, ctx, "bar", expected)
Jingwen Chen5136a6e2020-10-30 01:01:35 -04002252 expected = "java.base=" + strings.Join([]string{
2253 ".", buildDir, "dir", "dir2", "nested", moduleToPath("ext"), moduleToPath("framework")}, ":")
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002254 checkPatchModuleFlag(t, ctx, "baz", expected)
2255 })
2256}
Paul Duffina7b9f422020-01-10 17:12:18 +00002257
2258func TestJavaSystemModules(t *testing.T) {
2259 ctx, _ := testJava(t, `
2260 java_system_modules {
2261 name: "system-modules",
2262 libs: ["system-module1", "system-module2"],
2263 }
2264 java_library {
2265 name: "system-module1",
2266 srcs: ["a.java"],
2267 sdk_version: "none",
2268 system_modules: "none",
2269 }
2270 java_library {
2271 name: "system-module2",
2272 srcs: ["b.java"],
2273 sdk_version: "none",
2274 system_modules: "none",
2275 }
2276 `)
2277
2278 // check the existence of the module
2279 systemModules := ctx.ModuleForTests("system-modules", "android_common")
2280
2281 cmd := systemModules.Rule("jarsTosystemModules")
2282
2283 // make sure the command compiles against the supplied modules.
2284 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
2285 if !strings.Contains(cmd.Args["classpath"], module) {
2286 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
2287 module)
2288 }
2289 }
2290}
Paul Duffin90169ba2020-01-10 17:16:44 +00002291
2292func TestJavaSystemModulesImport(t *testing.T) {
2293 ctx, _ := testJava(t, `
2294 java_system_modules_import {
2295 name: "system-modules",
2296 libs: ["system-module1", "system-module2"],
2297 }
2298 java_import {
2299 name: "system-module1",
2300 jars: ["a.jar"],
2301 }
2302 java_import {
2303 name: "system-module2",
2304 jars: ["b.jar"],
2305 }
2306 `)
2307
2308 // check the existence of the module
2309 systemModules := ctx.ModuleForTests("system-modules", "android_common")
2310
2311 cmd := systemModules.Rule("jarsTosystemModules")
2312
2313 // make sure the command compiles against the supplied modules.
2314 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
2315 if !strings.Contains(cmd.Args["classpath"], module) {
2316 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
2317 module)
2318 }
2319 }
2320}
Paul Duffin83a2d962019-11-19 19:44:10 +00002321
2322func TestJavaLibraryWithSystemModules(t *testing.T) {
2323 ctx, _ := testJava(t, `
2324 java_library {
2325 name: "lib-with-source-system-modules",
2326 srcs: [
2327 "a.java",
2328 ],
2329 sdk_version: "none",
2330 system_modules: "source-system-modules",
2331 }
2332
2333 java_library {
2334 name: "source-jar",
2335 srcs: [
2336 "a.java",
2337 ],
2338 }
2339
2340 java_system_modules {
2341 name: "source-system-modules",
2342 libs: ["source-jar"],
2343 }
2344
2345 java_library {
2346 name: "lib-with-prebuilt-system-modules",
2347 srcs: [
2348 "a.java",
2349 ],
2350 sdk_version: "none",
2351 system_modules: "prebuilt-system-modules",
2352 }
2353
2354 java_import {
2355 name: "prebuilt-jar",
2356 jars: ["a.jar"],
2357 }
2358
2359 java_system_modules_import {
2360 name: "prebuilt-system-modules",
2361 libs: ["prebuilt-jar"],
2362 }
2363 `)
2364
2365 checkBootClasspathForSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar")
2366
2367 checkBootClasspathForSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar")
2368}
2369
2370func checkBootClasspathForSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) {
2371 javacRule := ctx.ModuleForTests(moduleName, "android_common").Rule("javac")
2372 bootClasspath := javacRule.Args["bootClasspath"]
2373 if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) {
2374 t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath)
2375 }
2376}
Jiyong Park19604de2020-03-24 16:44:11 +09002377
2378func TestAidlExportIncludeDirsFromImports(t *testing.T) {
2379 ctx, _ := testJava(t, `
2380 java_library {
2381 name: "foo",
2382 srcs: ["aidl/foo/IFoo.aidl"],
2383 libs: ["bar"],
2384 }
2385
2386 java_import {
2387 name: "bar",
2388 jars: ["a.jar"],
2389 aidl: {
2390 export_include_dirs: ["aidl/bar"],
2391 },
2392 }
2393 `)
2394
2395 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
2396 expectedAidlFlag := "-Iaidl/bar"
2397 if !strings.Contains(aidlCommand, expectedAidlFlag) {
2398 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
2399 }
2400}
Liz Kammerdd849a82020-06-12 16:38:45 -07002401
Jooyung Hane197d8b2021-01-05 10:33:16 +09002402func TestAidlFlagsArePassedToTheAidlCompiler(t *testing.T) {
2403 ctx, _ := testJava(t, `
2404 java_library {
2405 name: "foo",
2406 srcs: ["aidl/foo/IFoo.aidl"],
2407 aidl: { flags: ["-Werror"], },
2408 }
2409 `)
2410
2411 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
2412 expectedAidlFlag := "-Werror"
2413 if !strings.Contains(aidlCommand, expectedAidlFlag) {
2414 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
2415 }
2416}
2417
Liz Kammerdd849a82020-06-12 16:38:45 -07002418func TestDataNativeBinaries(t *testing.T) {
2419 ctx, config := testJava(t, `
2420 java_test_host {
2421 name: "foo",
2422 srcs: ["a.java"],
2423 data_native_bins: ["bin"]
2424 }
2425
2426 python_binary_host {
2427 name: "bin",
2428 srcs: ["bin.py"],
2429 }
2430 `)
2431
2432 buildOS := android.BuildOs.String()
2433
2434 test := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
2435 entries := android.AndroidMkEntriesForTest(t, config, "", test)[0]
2436 expected := []string{buildDir + "/.intermediates/bin/" + buildOS + "_x86_64_PY3/bin:bin"}
2437 actual := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
2438 if !reflect.DeepEqual(expected, actual) {
2439 t.Errorf("Unexpected test data - expected: %q, actual: %q", expected, actual)
2440 }
2441}