blob: 594cb82cd448a49d52792ed4857befdc3f4ccd4c [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Paul Duffin1a393322020-11-18 16:36:47 +000018 "fmt"
Colin Cross72bb3632017-07-13 16:23:21 -070019 "io/ioutil"
20 "os"
21 "path/filepath"
Colin Crossc0806172019-06-14 18:51:47 -070022 "reflect"
Paul Duffindaaa3322020-05-26 18:13:57 +010023 "regexp"
Nan Zhang61eaedb2017-11-02 13:28:15 -070024 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070025 "strings"
26 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070027
Jeongik Cha28df2572019-11-11 10:46:36 +090028 "github.com/google/blueprint/proptools"
29
Colin Crossa4f08812018-10-02 22:03:40 -070030 "android/soong/android"
31 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080032 "android/soong/dexpreopt"
Colin Crossb5ae1932020-11-17 06:32:06 +000033 "android/soong/genrule"
Liz Kammerdd849a82020-06-12 16:38:45 -070034 "android/soong/python"
Colin Cross72bb3632017-07-13 16:23:21 -070035)
36
37var buildDir string
38
39func setUp() {
40 var err error
41 buildDir, err = ioutil.TempDir("", "soong_java_test")
42 if err != nil {
43 panic(err)
44 }
45}
46
47func tearDown() {
48 os.RemoveAll(buildDir)
49}
50
51func TestMain(m *testing.M) {
52 run := func() int {
53 setUp()
54 defer tearDown()
55
56 return m.Run()
57 }
58
59 os.Exit(run())
60}
Colin Cross527012a2017-11-30 22:56:16 -080061
Colin Cross98be1bb2019-12-13 20:41:13 -080062func testConfig(env map[string]string, bp string, fs map[string][]byte) android.Config {
Martin Stjernholmd90676f2020-01-11 00:37:30 +000063 bp += dexpreopt.BpToolModulesForTest()
64
Martin Stjernholm75a48d82020-01-10 20:32:59 +000065 config := TestConfig(buildDir, env, bp, fs)
66
67 // Set up the global Once cache used for dexpreopt.GlobalSoongConfig, so that
68 // it doesn't create a real one, which would fail.
69 _ = dexpreopt.GlobalSoongConfigForTests(config)
70
71 return config
Colin Cross1369cdb2017-09-29 17:58:17 -070072}
73
Colin Crossae8600b2020-10-29 17:09:13 -070074func testContext(config android.Config) *android.TestContext {
Colin Cross72bb3632017-07-13 16:23:21 -070075
Colin Crossae8600b2020-10-29 17:09:13 -070076 ctx := android.NewTestArchContext(config)
Paul Duffinf9b1da02019-12-18 19:51:55 +000077 RegisterJavaBuildComponents(ctx)
78 RegisterAppBuildComponents(ctx)
79 RegisterAARBuildComponents(ctx)
Paul Duffinb0f85072019-12-19 10:28:56 +000080 RegisterGenRuleBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000081 RegisterSystemModulesBuildComponents(ctx)
Colin Cross4b49b762019-11-22 15:25:03 -080082 ctx.RegisterModuleType("java_plugin", PluginFactory)
Colin Cross4b49b762019-11-22 15:25:03 -080083 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
Colin Crossb5ae1932020-11-17 06:32:06 +000084 ctx.RegisterModuleType("genrule", genrule.GenRuleFactory)
Liz Kammerdd849a82020-06-12 16:38:45 -070085 ctx.RegisterModuleType("python_binary_host", python.PythonBinaryHostFactory)
Paul Duffin884363e2019-12-19 10:21:09 +000086 RegisterDocsBuildComponents(ctx)
87 RegisterStubsBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000088 RegisterSdkLibraryBuildComponents(ctx)
Colin Cross89536d42017-07-07 14:35:50 -070089 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Paul Duffin44f1d842020-06-26 20:17:02 +010090 ctx.PreArchMutators(android.RegisterComponentsMutator)
Paul Duffina48f7582019-12-19 11:25:19 +000091
92 RegisterPrebuiltApisBuildComponents(ctx)
93
Liz Kammerdd849a82020-06-12 16:38:45 -070094 ctx.PreDepsMutators(python.RegisterPythonPreDepsMutators)
Jaewoong Jungb639a6a2019-05-10 15:16:29 -070095 ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
Colin Cross06fa5882020-10-29 18:21:38 -070096 ctx.RegisterPreSingletonType("overlay", android.SingletonFactoryAdaptor(ctx.Context, OverlaySingletonFactory))
97 ctx.RegisterPreSingletonType("sdk_versions", android.SingletonFactoryAdaptor(ctx.Context, sdkPreSingletonFactory))
Colin Crossa4f08812018-10-02 22:03:40 -070098
Paul Duffin021f4e52020-07-30 16:04:17 +010099 android.RegisterPrebuiltMutators(ctx)
100
Colin Crossa4f08812018-10-02 22:03:40 -0700101 // Register module types and mutators from cc needed for JNI testing
Paul Duffin77980a82019-12-19 16:01:36 +0000102 cc.RegisterRequiredBuildComponentsForTest(ctx)
Colin Crossa4f08812018-10-02 22:03:40 -0700103
Martin Stjernholmd90676f2020-01-11 00:37:30 +0000104 dexpreopt.RegisterToolModulesForTest(ctx)
105
Jaewoong Jungc779cd42020-10-06 18:56:10 -0700106 ctx.PostDepsMutators(func(ctx android.RegisterMutatorsContext) {
107 ctx.TopDown("propagate_rro_enforcement", propagateRROEnforcementMutator).Parallel()
108 })
109
Colin Cross527012a2017-11-30 22:56:16 -0800110 return ctx
111}
112
113func run(t *testing.T, ctx *android.TestContext, config android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800114 t.Helper()
Colin Crossc28bb0b2019-02-25 14:20:47 -0800115
Colin Cross98be1bb2019-12-13 20:41:13 -0800116 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000117 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Colin Crossc28bb0b2019-02-25 14:20:47 -0800118
Colin Crossae8600b2020-10-29 17:09:13 -0700119 ctx.Register()
Paul Duffinbaccf7e2019-06-11 11:58:30 +0100120 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
Logan Chien42039712018-03-12 16:29:17 +0800121 android.FailIfErrored(t, errs)
Colin Cross72bb3632017-07-13 16:23:21 -0700122 _, errs = ctx.PrepareBuildActions(config)
Logan Chien42039712018-03-12 16:29:17 +0800123 android.FailIfErrored(t, errs)
Colin Cross527012a2017-11-30 22:56:16 -0800124}
125
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900126func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) {
Jeongik Cha538c0d02019-07-11 15:54:27 +0900127 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800128 return testJavaErrorWithConfig(t, pattern, testConfig(nil, bp, nil))
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900129}
130
Colin Cross98be1bb2019-12-13 20:41:13 -0800131func testJavaErrorWithConfig(t *testing.T, pattern string, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900132 t.Helper()
Colin Crossae8600b2020-10-29 17:09:13 -0700133 ctx := testContext(config)
Jeongik Cha538c0d02019-07-11 15:54:27 +0900134
Colin Cross98be1bb2019-12-13 20:41:13 -0800135 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000136 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Jeongik Cha538c0d02019-07-11 15:54:27 +0900137
Colin Crossae8600b2020-10-29 17:09:13 -0700138 ctx.Register()
Jeongik Cha538c0d02019-07-11 15:54:27 +0900139 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
140 if len(errs) > 0 {
141 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900142 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900143 }
144 _, errs = ctx.PrepareBuildActions(config)
145 if len(errs) > 0 {
146 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900147 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900148 }
149
150 t.Fatalf("missing expected error %q (0 errors are returned)", pattern)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900151
152 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900153}
154
Colin Cross238c1f32020-06-07 16:58:18 -0700155func testJavaWithFS(t *testing.T, bp string, fs map[string][]byte) (*android.TestContext, android.Config) {
156 t.Helper()
157 return testJavaWithConfig(t, testConfig(nil, bp, fs))
158}
159
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700160func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800161 t.Helper()
Colin Cross238c1f32020-06-07 16:58:18 -0700162 return testJavaWithFS(t, bp, nil)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900163}
164
Colin Cross98be1bb2019-12-13 20:41:13 -0800165func testJavaWithConfig(t *testing.T, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900166 t.Helper()
Colin Crossae8600b2020-10-29 17:09:13 -0700167 ctx := testContext(config)
Colin Cross527012a2017-11-30 22:56:16 -0800168 run(t, ctx, config)
Colin Cross72bb3632017-07-13 16:23:21 -0700169
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700170 return ctx, config
Colin Cross72bb3632017-07-13 16:23:21 -0700171}
172
Colin Cross2acdae82017-09-15 19:44:24 -0700173func moduleToPath(name string) string {
174 switch {
175 case name == `""`:
176 return name
Colin Crossfc3674a2017-09-18 17:41:52 -0700177 case strings.HasSuffix(name, ".jar"):
178 return name
Nan Zhanged19fc32017-10-19 13:06:22 -0700179 default:
180 return filepath.Join(buildDir, ".intermediates", name, "android_common", "turbine-combined", name+".jar")
Colin Cross2acdae82017-09-15 19:44:24 -0700181 }
182}
183
Jeongik Chae403e9e2019-12-07 00:16:24 +0900184func TestJavaLinkType(t *testing.T) {
185 testJava(t, `
186 java_library {
187 name: "foo",
188 srcs: ["a.java"],
189 libs: ["bar"],
190 static_libs: ["baz"],
191 }
192
193 java_library {
194 name: "bar",
195 sdk_version: "current",
196 srcs: ["b.java"],
197 }
198
199 java_library {
200 name: "baz",
201 sdk_version: "system_current",
202 srcs: ["c.java"],
203 }
204 `)
205
Steven Moreland00298982020-11-17 21:44:36 +0000206 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900207 java_library {
208 name: "foo",
209 srcs: ["a.java"],
210 libs: ["bar"],
211 sdk_version: "current",
212 static_libs: ["baz"],
213 }
214
215 java_library {
216 name: "bar",
217 sdk_version: "current",
218 srcs: ["b.java"],
219 }
220
221 java_library {
222 name: "baz",
223 sdk_version: "system_current",
224 srcs: ["c.java"],
225 }
226 `)
227
228 testJava(t, `
229 java_library {
230 name: "foo",
231 srcs: ["a.java"],
232 libs: ["bar"],
233 sdk_version: "system_current",
234 static_libs: ["baz"],
235 }
236
237 java_library {
238 name: "bar",
239 sdk_version: "current",
240 srcs: ["b.java"],
241 }
242
243 java_library {
244 name: "baz",
245 sdk_version: "system_current",
246 srcs: ["c.java"],
247 }
248 `)
249
Steven Moreland00298982020-11-17 21:44:36 +0000250 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900251 java_library {
252 name: "foo",
253 srcs: ["a.java"],
254 libs: ["bar"],
255 sdk_version: "system_current",
256 static_libs: ["baz"],
257 }
258
259 java_library {
260 name: "bar",
261 sdk_version: "current",
262 srcs: ["b.java"],
263 }
264
265 java_library {
266 name: "baz",
267 srcs: ["c.java"],
268 }
269 `)
270}
271
Colin Cross72bb3632017-07-13 16:23:21 -0700272func TestSimple(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700273 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700274 java_library {
275 name: "foo",
276 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700277 libs: ["bar"],
278 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700279 }
280
281 java_library {
282 name: "bar",
283 srcs: ["b.java"],
284 }
285
286 java_library {
287 name: "baz",
288 srcs: ["c.java"],
289 }
Colin Crossd5934c82017-10-02 13:55:26 -0700290 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700291
Colin Cross4c428df2017-09-15 17:36:05 -0700292 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700293 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700294
295 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
296 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
297 }
298
Colin Cross1ee23172017-10-18 14:44:18 -0700299 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Nan Zhanged19fc32017-10-19 13:06:22 -0700300 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
301 bazTurbine := filepath.Join(buildDir, ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700302
Nan Zhanged19fc32017-10-19 13:06:22 -0700303 if !strings.Contains(javac.Args["classpath"], barTurbine) {
304 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700305 }
306
Nan Zhanged19fc32017-10-19 13:06:22 -0700307 if !strings.Contains(javac.Args["classpath"], bazTurbine) {
308 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700309 }
310
311 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
312 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700313 }
314}
315
Artur Satayev9cf46692019-11-26 18:08:34 +0000316func TestExportedPlugins(t *testing.T) {
317 type Result struct {
318 library string
319 processors string
320 }
321 var tests = []struct {
322 name string
323 extra string
324 results []Result
325 }{
326 {
327 name: "Exported plugin is not a direct plugin",
328 extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`,
329 results: []Result{{library: "exports", processors: "-proc:none"}},
330 },
331 {
332 name: "Exports plugin to dependee",
333 extra: `
334 java_library{name: "exports", exported_plugins: ["plugin"]}
335 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
336 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
337 `,
338 results: []Result{
339 {library: "foo", processors: "-processor com.android.TestPlugin"},
340 {library: "bar", processors: "-processor com.android.TestPlugin"},
341 },
342 },
343 {
344 name: "Exports plugin to android_library",
345 extra: `
346 java_library{name: "exports", exported_plugins: ["plugin"]}
347 android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
348 android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
349 `,
350 results: []Result{
351 {library: "foo", processors: "-processor com.android.TestPlugin"},
352 {library: "bar", processors: "-processor com.android.TestPlugin"},
353 },
354 },
355 {
356 name: "Exports plugin is not propagated via transitive deps",
357 extra: `
358 java_library{name: "exports", exported_plugins: ["plugin"]}
359 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
360 java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]}
361 `,
362 results: []Result{
363 {library: "foo", processors: "-processor com.android.TestPlugin"},
364 {library: "bar", processors: "-proc:none"},
365 },
366 },
367 {
368 name: "Exports plugin appends to plugins",
369 extra: `
370 java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"}
371 java_library{name: "exports", exported_plugins: ["plugin"]}
372 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]}
373 `,
374 results: []Result{
375 {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"},
376 },
377 },
378 }
379
380 for _, test := range tests {
381 t.Run(test.name, func(t *testing.T) {
382 ctx, _ := testJava(t, `
383 java_plugin {
384 name: "plugin",
385 processor_class: "com.android.TestPlugin",
386 }
387 `+test.extra)
388
389 for _, want := range test.results {
390 javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac")
391 if javac.Args["processor"] != want.processors {
392 t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"])
393 }
394 }
395 })
396 }
397}
398
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900399func TestSdkVersionByPartition(t *testing.T) {
400 testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900401 java_library {
402 name: "foo",
403 srcs: ["a.java"],
404 vendor: true,
405 }
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900406 `)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900407
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900408 testJava(t, `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900409 java_library {
410 name: "bar",
411 srcs: ["b.java"],
412 }
413 `)
414
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900415 for _, enforce := range []bool{true, false} {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900416 bp := `
417 java_library {
418 name: "foo",
419 srcs: ["a.java"],
420 product_specific: true,
421 }
422 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800423
424 config := testConfig(nil, bp, nil)
425 config.TestProductVariables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900426 if enforce {
Colin Cross98be1bb2019-12-13 20:41:13 -0800427 testJavaErrorWithConfig(t, "sdk_version must have a value when the module is located at vendor or product", config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900428 } else {
Colin Cross98be1bb2019-12-13 20:41:13 -0800429 testJavaWithConfig(t, config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900430 }
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900431 }
432}
433
Colin Crossd5934c82017-10-02 13:55:26 -0700434func TestArchSpecific(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700435 ctx, _ := testJava(t, `
Colin Crossd5934c82017-10-02 13:55:26 -0700436 java_library {
437 name: "foo",
438 srcs: ["a.java"],
439 target: {
440 android: {
441 srcs: ["b.java"],
442 },
443 },
444 }
445 `)
446
447 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
448 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
449 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
450 }
451}
452
Colin Cross6b4a32d2017-12-05 13:42:45 -0800453func TestBinary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700454 ctx, _ := testJava(t, `
Colin Cross6b4a32d2017-12-05 13:42:45 -0800455 java_library_host {
456 name: "foo",
457 srcs: ["a.java"],
458 }
459
460 java_binary_host {
461 name: "bar",
462 srcs: ["b.java"],
463 static_libs: ["foo"],
Colin Cross89226d92020-10-09 19:00:54 -0700464 jni_libs: ["libjni"],
465 }
466
467 cc_library_shared {
468 name: "libjni",
469 host_supported: true,
470 device_supported: false,
471 stl: "none",
Colin Cross6b4a32d2017-12-05 13:42:45 -0800472 }
473 `)
474
475 buildOS := android.BuildOs.String()
476
477 bar := ctx.ModuleForTests("bar", buildOS+"_common")
478 barJar := bar.Output("bar.jar").Output.String()
479 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
480 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
481
Colin Cross89226d92020-10-09 19:00:54 -0700482 libjni := ctx.ModuleForTests("libjni", buildOS+"_x86_64_shared")
483 libjniSO := libjni.Rule("Cp").Output.String()
484
Colin Cross6b4a32d2017-12-05 13:42:45 -0800485 // Test that the install binary wrapper depends on the installed jar file
Colin Crossc179ea62020-10-09 10:54:15 -0700486 if g, w := barWrapperDeps, barJar; !android.InList(w, g) {
487 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800488 }
Colin Cross89226d92020-10-09 19:00:54 -0700489
490 // Test that the install binary wrapper depends on the installed JNI libraries
491 if g, w := barWrapperDeps, libjniSO; !android.InList(w, g) {
492 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800493 }
Alex Humesky2070e322020-06-09 20:23:08 -0400494}
Colin Cross6b4a32d2017-12-05 13:42:45 -0800495
Alex Humesky2070e322020-06-09 20:23:08 -0400496func TestHostBinaryNoJavaDebugInfoOverride(t *testing.T) {
497 bp := `
498 java_library {
499 name: "target_library",
500 srcs: ["a.java"],
501 }
502
503 java_binary_host {
504 name: "host_binary",
505 srcs: ["b.java"],
506 }
507 `
508 config := testConfig(nil, bp, nil)
509 config.TestProductVariables.MinimizeJavaDebugInfo = proptools.BoolPtr(true)
510
511 ctx, _ := testJavaWithConfig(t, config)
512
Liz Kammer7941b302020-07-28 13:27:34 -0700513 // first, check that the -g flag is added to target modules
Alex Humesky2070e322020-06-09 20:23:08 -0400514 targetLibrary := ctx.ModuleForTests("target_library", "android_common")
515 targetJavaFlags := targetLibrary.Module().VariablesForTests()["javacFlags"]
516 if !strings.Contains(targetJavaFlags, "-g:source,lines") {
517 t.Errorf("target library javac flags %v should contain "+
518 "-g:source,lines override with MinimizeJavaDebugInfo", targetJavaFlags)
519 }
520
521 // check that -g is not overridden for host modules
522 buildOS := android.BuildOs.String()
523 hostBinary := ctx.ModuleForTests("host_binary", buildOS+"_common")
524 hostJavaFlags := hostBinary.Module().VariablesForTests()["javacFlags"]
525 if strings.Contains(hostJavaFlags, "-g:source,lines") {
526 t.Errorf("java_binary_host javac flags %v should not have "+
527 "-g:source,lines override with MinimizeJavaDebugInfo", hostJavaFlags)
528 }
Colin Cross6b4a32d2017-12-05 13:42:45 -0800529}
530
Colin Cross72bb3632017-07-13 16:23:21 -0700531func TestPrebuilts(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700532 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700533 java_library {
534 name: "foo",
Paul Duffin91547182019-11-12 19:39:36 +0000535 srcs: ["a.java", ":stubs-source"],
Paul Duffinfcfd7912020-01-31 17:54:30 +0000536 libs: ["bar", "sdklib"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700537 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700538 }
539
Colin Cross74d73e22017-08-02 11:05:49 -0700540 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700541 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700542 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700543 }
544
Colin Cross74d73e22017-08-02 11:05:49 -0700545 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700546 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700547 jars: ["b.jar"],
Liz Kammerd6c31d22020-08-05 15:40:41 -0700548 sdk_version: "current",
549 compile_dex: true,
Colin Cross72bb3632017-07-13 16:23:21 -0700550 }
Colin Cross42be7612019-02-21 18:12:14 -0800551
552 dex_import {
553 name: "qux",
554 jars: ["b.jar"],
555 }
Colin Cross79c7c262019-04-17 11:11:46 -0700556
557 java_sdk_library_import {
Paul Duffin56d44902020-01-31 13:36:25 +0000558 name: "sdklib",
559 public: {
560 jars: ["c.jar"],
561 },
562 }
563
Paul Duffin91547182019-11-12 19:39:36 +0000564 prebuilt_stubs_sources {
565 name: "stubs-source",
Paul Duffin9b478b02019-12-10 13:41:51 +0000566 srcs: ["stubs/sources"],
Paul Duffin91547182019-11-12 19:39:36 +0000567 }
Paul Duffin1b82e6a2019-12-03 18:06:47 +0000568
569 java_test_import {
570 name: "test",
571 jars: ["a.jar"],
572 test_suites: ["cts"],
573 test_config: "AndroidTest.xml",
574 }
Colin Cross72bb3632017-07-13 16:23:21 -0700575 `)
576
Paul Duffin9b478b02019-12-10 13:41:51 +0000577 fooModule := ctx.ModuleForTests("foo", "android_common")
578 javac := fooModule.Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700579 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Liz Kammerd6c31d22020-08-05 15:40:41 -0700580 barModule := ctx.ModuleForTests("bar", "android_common")
581 barJar := barModule.Rule("combineJar").Output
582 bazModule := ctx.ModuleForTests("baz", "android_common")
583 bazJar := bazModule.Rule("combineJar").Output
Colin Cross79c7c262019-04-17 11:11:46 -0700584 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700585
Paul Duffin9b478b02019-12-10 13:41:51 +0000586 fooLibrary := fooModule.Module().(*Library)
587 assertDeepEquals(t, "foo java sources incorrect",
588 []string{"a.java"}, fooLibrary.compiledJavaSrcs.Strings())
Paul Duffin91547182019-11-12 19:39:36 +0000589
Paul Duffin9b478b02019-12-10 13:41:51 +0000590 assertDeepEquals(t, "foo java source jars incorrect",
591 []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"},
592 android.NormalizePathsForTesting(fooLibrary.compiledSrcJars))
Paul Duffin91547182019-11-12 19:39:36 +0000593
Colin Cross37f6d792018-07-12 12:28:41 -0700594 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
595 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700596 }
597
Liz Kammerd6c31d22020-08-05 15:40:41 -0700598 barDexJar := barModule.Module().(*Import).DexJarBuildPath()
599 if barDexJar != nil {
600 t.Errorf("bar dex jar build path expected to be nil, got %q", barDexJar)
601 }
602
Colin Cross79c7c262019-04-17 11:11:46 -0700603 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
604 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
605 }
606
Colin Cross37f6d792018-07-12 12:28:41 -0700607 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
608 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700609 }
Colin Cross42be7612019-02-21 18:12:14 -0800610
Liz Kammerd6c31d22020-08-05 15:40:41 -0700611 bazDexJar := bazModule.Module().(*Import).DexJarBuildPath().String()
612 expectedDexJar := buildDir + "/.intermediates/baz/android_common/dex/baz.jar"
613 if bazDexJar != expectedDexJar {
614 t.Errorf("baz dex jar build path expected %q, got %q", expectedDexJar, bazDexJar)
615 }
616
Colin Cross42be7612019-02-21 18:12:14 -0800617 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Colin Cross72bb3632017-07-13 16:23:21 -0700618}
619
Paul Duffin9b478b02019-12-10 13:41:51 +0000620func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) {
621 if !reflect.DeepEqual(expected, actual) {
622 t.Errorf("%s: expected %q, found %q", message, expected, actual)
623 }
624}
625
Paul Duffin1a393322020-11-18 16:36:47 +0000626func TestPrebuiltStubsSources(t *testing.T) {
627 test := func(t *testing.T, sourcesPath string, expectedInputs []string) {
628 ctx, _ := testJavaWithFS(t, fmt.Sprintf(`
629prebuilt_stubs_sources {
630 name: "stubs-source",
631 srcs: ["%s"],
632}`, sourcesPath), map[string][]byte{
633 "stubs/sources/pkg/A.java": nil,
634 "stubs/sources/pkg/B.java": nil,
635 })
636
637 zipSrc := ctx.ModuleForTests("stubs-source", "android_common").Rule("zip_src")
638 if expected, actual := expectedInputs, zipSrc.Inputs.Strings(); !reflect.DeepEqual(expected, actual) {
639 t.Errorf("mismatch of inputs to soong_zip: expected %q, actual %q", expected, actual)
640 }
641 }
642
643 t.Run("empty/missing directory", func(t *testing.T) {
644 test(t, "empty-directory", []string{})
645 })
646
647 t.Run("non-empty set of sources", func(t *testing.T) {
648 test(t, "stubs/sources", []string{
649 "stubs/sources/pkg/A.java",
650 "stubs/sources/pkg/B.java",
651 })
652 })
653}
654
Paul Duffin56d44902020-01-31 13:36:25 +0000655func TestJavaSdkLibraryImport(t *testing.T) {
656 ctx, _ := testJava(t, `
657 java_library {
658 name: "foo",
659 srcs: ["a.java"],
660 libs: ["sdklib"],
661 sdk_version: "current",
662 }
663
664 java_library {
665 name: "foo.system",
666 srcs: ["a.java"],
667 libs: ["sdklib"],
668 sdk_version: "system_current",
669 }
670
671 java_library {
672 name: "foo.test",
673 srcs: ["a.java"],
674 libs: ["sdklib"],
675 sdk_version: "test_current",
676 }
677
678 java_sdk_library_import {
679 name: "sdklib",
680 public: {
681 jars: ["a.jar"],
682 },
683 system: {
684 jars: ["b.jar"],
685 },
686 test: {
687 jars: ["c.jar"],
Paul Duffin0f8faff2020-05-20 16:18:00 +0100688 stub_srcs: ["c.java"],
Paul Duffin56d44902020-01-31 13:36:25 +0000689 },
690 }
691 `)
692
693 for _, scope := range []string{"", ".system", ".test"} {
694 fooModule := ctx.ModuleForTests("foo"+scope, "android_common")
695 javac := fooModule.Rule("javac")
696
697 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs"+scope, "android_common").Rule("combineJar").Output
698 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
699 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
700 }
701 }
Paul Duffinca8d9a52020-06-26 22:20:25 +0100702
Paul Duffincee7e662020-07-09 17:32:57 +0100703 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100704 `prebuilt_sdklib.stubs`,
705 `prebuilt_sdklib.stubs.source.test`,
706 `prebuilt_sdklib.stubs.system`,
707 `prebuilt_sdklib.stubs.test`,
708 })
709}
710
711func TestJavaSdkLibraryImport_WithSource(t *testing.T) {
712 ctx, _ := testJava(t, `
713 java_sdk_library {
714 name: "sdklib",
715 srcs: ["a.java"],
716 sdk_version: "none",
717 system_modules: "none",
718 public: {
719 enabled: true,
720 },
721 }
722
723 java_sdk_library_import {
724 name: "sdklib",
725 public: {
726 jars: ["a.jar"],
727 },
728 }
729 `)
730
Paul Duffincee7e662020-07-09 17:32:57 +0100731 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100732 `dex2oatd`,
733 `prebuilt_sdklib`,
734 `sdklib.impl`,
735 `sdklib.stubs`,
736 `sdklib.stubs.source`,
737 `sdklib.xml`,
738 })
739
Paul Duffincee7e662020-07-09 17:32:57 +0100740 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffin44f1d842020-06-26 20:17:02 +0100741 `prebuilt_sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100742 `sdklib.impl`,
743 // This should be prebuilt_sdklib.stubs but is set to sdklib.stubs because the
744 // dependency is added after prebuilts may have been renamed and so has to use
745 // the renamed name.
Paul Duffinca8d9a52020-06-26 22:20:25 +0100746 `sdklib.xml`,
747 })
748}
749
750func TestJavaSdkLibraryImport_Preferred(t *testing.T) {
751 ctx, _ := testJava(t, `
752 java_sdk_library {
753 name: "sdklib",
754 srcs: ["a.java"],
755 sdk_version: "none",
756 system_modules: "none",
757 public: {
758 enabled: true,
759 },
760 }
761
762 java_sdk_library_import {
763 name: "sdklib",
764 prefer: true,
765 public: {
766 jars: ["a.jar"],
767 },
768 }
769 `)
770
Paul Duffincee7e662020-07-09 17:32:57 +0100771 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100772 `dex2oatd`,
773 `prebuilt_sdklib`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100774 `sdklib.impl`,
Paul Duffin80342d72020-06-26 22:08:43 +0100775 `sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100776 `sdklib.stubs.source`,
777 `sdklib.xml`,
778 })
779
Paul Duffincee7e662020-07-09 17:32:57 +0100780 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100781 `prebuilt_sdklib.stubs`,
782 `sdklib.impl`,
783 `sdklib.xml`,
784 })
Paul Duffin56d44902020-01-31 13:36:25 +0000785}
786
JaeMan Parkff715562020-10-19 17:25:58 +0900787func TestJavaSdkLibraryEnforce(t *testing.T) {
788 partitionToBpOption := func(partition string) string {
789 switch partition {
790 case "system":
791 return ""
792 case "vendor":
793 return "soc_specific: true,"
794 case "product":
795 return "product_specific: true,"
796 default:
797 panic("Invalid partition group name: " + partition)
798 }
799 }
800
801 type testConfigInfo struct {
802 libraryType string
803 fromPartition string
804 toPartition string
805 enforceVendorInterface bool
806 enforceProductInterface bool
807 enforceJavaSdkLibraryCheck bool
808 allowList []string
809 }
810
811 createTestConfig := func(info testConfigInfo) android.Config {
812 bpFileTemplate := `
813 java_library {
814 name: "foo",
815 srcs: ["foo.java"],
816 libs: ["bar"],
817 sdk_version: "current",
818 %s
819 }
820
821 %s {
822 name: "bar",
823 srcs: ["bar.java"],
824 sdk_version: "current",
825 %s
826 }
827 `
828
829 bpFile := fmt.Sprintf(bpFileTemplate,
830 partitionToBpOption(info.fromPartition),
831 info.libraryType,
832 partitionToBpOption(info.toPartition))
833
834 config := testConfig(nil, bpFile, nil)
835 configVariables := config.TestProductVariables
836
837 configVariables.EnforceProductPartitionInterface = proptools.BoolPtr(info.enforceProductInterface)
838 if info.enforceVendorInterface {
839 configVariables.DeviceVndkVersion = proptools.StringPtr("current")
840 }
841 configVariables.EnforceInterPartitionJavaSdkLibrary = proptools.BoolPtr(info.enforceJavaSdkLibraryCheck)
842 configVariables.InterPartitionJavaLibraryAllowList = info.allowList
843
844 return config
845 }
846
847 isValidDependency := func(configInfo testConfigInfo) bool {
848 if configInfo.enforceVendorInterface == false {
849 return true
850 }
851
852 if configInfo.enforceJavaSdkLibraryCheck == false {
853 return true
854 }
855
856 if inList("bar", configInfo.allowList) {
857 return true
858 }
859
860 if configInfo.libraryType == "java_library" {
861 if configInfo.fromPartition != configInfo.toPartition {
862 if !configInfo.enforceProductInterface &&
863 ((configInfo.fromPartition == "system" && configInfo.toPartition == "product") ||
864 (configInfo.fromPartition == "product" && configInfo.toPartition == "system")) {
865 return true
866 }
867 return false
868 }
869 }
870
871 return true
872 }
873
874 errorMessage := "is not allowed across the partitions"
875
876 allPartitionCombinations := func() [][2]string {
877 var result [][2]string
878 partitions := []string{"system", "vendor", "product"}
879
880 for _, fromPartition := range partitions {
881 for _, toPartition := range partitions {
882 result = append(result, [2]string{fromPartition, toPartition})
883 }
884 }
885
886 return result
887 }
888
889 allFlagCombinations := func() [][3]bool {
890 var result [][3]bool
891 flagValues := [2]bool{false, true}
892
893 for _, vendorInterface := range flagValues {
894 for _, productInterface := range flagValues {
895 for _, enableEnforce := range flagValues {
896 result = append(result, [3]bool{vendorInterface, productInterface, enableEnforce})
897 }
898 }
899 }
900
901 return result
902 }
903
904 for _, libraryType := range []string{"java_library", "java_sdk_library"} {
905 for _, partitionValues := range allPartitionCombinations() {
906 for _, flagValues := range allFlagCombinations() {
907 testInfo := testConfigInfo{
908 libraryType: libraryType,
909 fromPartition: partitionValues[0],
910 toPartition: partitionValues[1],
911 enforceVendorInterface: flagValues[0],
912 enforceProductInterface: flagValues[1],
913 enforceJavaSdkLibraryCheck: flagValues[2],
914 }
915
916 if isValidDependency(testInfo) {
917 testJavaWithConfig(t, createTestConfig(testInfo))
918 } else {
919 testJavaErrorWithConfig(t, errorMessage, createTestConfig(testInfo))
920 }
921 }
922 }
923 }
924
925 testJavaWithConfig(t, createTestConfig(testConfigInfo{
926 libraryType: "java_library",
927 fromPartition: "vendor",
928 toPartition: "system",
929 enforceVendorInterface: true,
930 enforceProductInterface: true,
931 enforceJavaSdkLibraryCheck: true,
932 allowList: []string{"bar"},
933 }))
934
935 testJavaErrorWithConfig(t, errorMessage, createTestConfig(testConfigInfo{
936 libraryType: "java_library",
937 fromPartition: "vendor",
938 toPartition: "system",
939 enforceVendorInterface: true,
940 enforceProductInterface: true,
941 enforceJavaSdkLibraryCheck: true,
942 allowList: []string{"foo"},
943 }))
944}
945
Colin Cross89536d42017-07-07 14:35:50 -0700946func TestDefaults(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700947 ctx, _ := testJava(t, `
Colin Cross89536d42017-07-07 14:35:50 -0700948 java_defaults {
949 name: "defaults",
950 srcs: ["a.java"],
951 libs: ["bar"],
952 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -0700953 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700954 }
955
956 java_library {
957 name: "foo",
958 defaults: ["defaults"],
959 }
960
961 java_library {
962 name: "bar",
963 srcs: ["b.java"],
964 }
965
966 java_library {
967 name: "baz",
968 srcs: ["c.java"],
969 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700970
971 android_test {
972 name: "atestOptimize",
973 defaults: ["defaults"],
974 optimize: {enabled: true},
975 }
976
977 android_test {
978 name: "atestNoOptimize",
979 defaults: ["defaults"],
980 }
981
982 android_test {
983 name: "atestDefault",
984 srcs: ["a.java"],
985 }
Colin Cross89536d42017-07-07 14:35:50 -0700986 `)
987
Colin Cross4c428df2017-09-15 17:36:05 -0700988 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700989 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -0700990
991 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
992 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
993 }
994
Nan Zhanged19fc32017-10-19 13:06:22 -0700995 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
996 if !strings.Contains(javac.Args["classpath"], barTurbine) {
997 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -0700998 }
999
Colin Cross1ee23172017-10-18 14:44:18 -07001000 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -07001001 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
1002 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -07001003 }
Sasha Smundak2057f822019-04-16 17:16:58 -07001004
1005 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
1006 if atestOptimize.Output == nil {
1007 t.Errorf("atestOptimize should optimize APK")
1008 }
1009
1010 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
1011 if atestNoOptimize.Output == nil {
1012 t.Errorf("atestNoOptimize should not optimize APK")
1013 }
1014
1015 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("r8")
1016 if atestDefault.Output == nil {
1017 t.Errorf("atestDefault should optimize APK")
1018 }
Colin Cross89536d42017-07-07 14:35:50 -07001019}
1020
Colin Cross0f37af02017-09-27 17:42:05 -07001021func TestResources(t *testing.T) {
1022 var table = []struct {
1023 name string
1024 prop string
1025 extra string
1026 args string
1027 }{
1028 {
Colin Crossaf9c55b2017-10-03 14:50:08 -07001029 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -07001030 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -08001031 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -07001032 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -07001033 },
1034 {
1035 // Test that a module with java_resources includes the files
1036 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -07001037 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
1038 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -07001039 },
1040 {
1041 // Test that a module with a filegroup in java_resources includes the files with the
1042 // path prefix
1043 name: "resource filegroup",
1044 prop: `java_resources: [":foo-res"]`,
1045 extra: `
1046 filegroup {
1047 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -08001048 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -07001049 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -07001050 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -07001051 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -07001052 },
1053 {
Colin Cross0ead1d72018-04-10 13:07:42 -07001054 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
1055 name: "wildcard dirs",
1056 prop: `java_resource_dirs: ["java-res/*"]`,
1057 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
1058 },
1059 {
1060 // Test that a module exclude_java_resource_dirs excludes the files
1061 name: "wildcard dirs",
1062 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
1063 args: "-C java-res/a -f java-res/a/a",
1064 },
Colin Crosscedd4762018-09-13 11:26:19 -07001065 {
1066 // Test wildcards in java_resources
1067 name: "wildcard files",
1068 prop: `java_resources: ["java-res/**/*"]`,
1069 args: "-C . -f java-res/a/a -f java-res/b/b",
1070 },
1071 {
1072 // Test exclude_java_resources with java_resources
1073 name: "wildcard files with exclude",
1074 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
1075 args: "-C . -f java-res/a/a",
1076 },
1077 {
1078 // Test exclude_java_resources with java_resource_dirs
1079 name: "resource dirs with exclude files",
1080 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
1081 args: "-C java-res -f java-res/a/a",
1082 },
1083 {
1084 // Test exclude_java_resource_dirs with java_resource_dirs
1085 name: "resource dirs with exclude files",
1086 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
1087 args: "-C java-res -f java-res/a/a -f java-res/b/b",
1088 },
Colin Cross0f37af02017-09-27 17:42:05 -07001089 }
1090
1091 for _, test := range table {
1092 t.Run(test.name, func(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001093 ctx, _ := testJavaWithFS(t, `
Colin Cross0f37af02017-09-27 17:42:05 -07001094 java_library {
1095 name: "foo",
1096 srcs: [
1097 "a.java",
1098 "b.java",
1099 "c.java",
1100 ],
1101 `+test.prop+`,
1102 }
Colin Cross238c1f32020-06-07 16:58:18 -07001103 `+test.extra,
1104 map[string][]byte{
1105 "java-res/a/a": nil,
1106 "java-res/b/b": nil,
1107 "java-res2/a": nil,
1108 },
1109 )
Colin Cross0f37af02017-09-27 17:42:05 -07001110
Colin Cross331a1212018-08-15 20:40:52 -07001111 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -07001112 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -07001113
1114 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
1115 t.Errorf("foo combined jars %v does not contain %q",
1116 foo.Inputs.Strings(), fooRes.Output.String())
1117 }
1118
Colin Crossaf9c55b2017-10-03 14:50:08 -07001119 if fooRes.Args["jarArgs"] != test.args {
1120 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -07001121 fooRes.Args["jarArgs"], test.args)
1122 }
1123 })
1124 }
1125}
1126
Colin Cross0c4ce212019-05-03 15:28:19 -07001127func TestIncludeSrcs(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001128 ctx, _ := testJavaWithFS(t, `
Colin Cross0c4ce212019-05-03 15:28:19 -07001129 java_library {
1130 name: "foo",
1131 srcs: [
1132 "a.java",
1133 "b.java",
1134 "c.java",
1135 ],
1136 include_srcs: true,
1137 }
1138
1139 java_library {
1140 name: "bar",
1141 srcs: [
1142 "a.java",
1143 "b.java",
1144 "c.java",
1145 ],
1146 java_resource_dirs: ["java-res"],
1147 include_srcs: true,
1148 }
Colin Cross238c1f32020-06-07 16:58:18 -07001149 `, map[string][]byte{
1150 "java-res/a/a": nil,
1151 "java-res/b/b": nil,
1152 "java-res2/a": nil,
1153 })
Colin Cross0c4ce212019-05-03 15:28:19 -07001154
1155 // Test a library with include_srcs: true
1156 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
1157 fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar")
1158
1159 if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) {
1160 t.Errorf("foo combined jars %v does not contain %q", w, g)
1161 }
1162
1163 if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
1164 t.Errorf("foo source jar args %q is not %q", w, g)
1165 }
1166
1167 // Test a library with include_srcs: true and resources
1168 bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar")
1169 barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar")
1170 barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar")
1171 barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar")
1172
1173 if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
1174 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
1175 }
1176
1177 if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
1178 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
1179 }
1180
1181 if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) {
1182 t.Errorf("bar combined jars %v does not contain %q", w, g)
1183 }
1184
1185 if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
1186 t.Errorf("bar source jar args %q is not %q", w, g)
1187 }
1188
1189 if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w {
1190 t.Errorf("bar resource jar args %q is not %q", w, g)
1191 }
1192}
1193
Colin Cross54190b32017-10-09 15:34:10 -07001194func TestGeneratedSources(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001195 ctx, _ := testJavaWithFS(t, `
Colin Cross54190b32017-10-09 15:34:10 -07001196 java_library {
1197 name: "foo",
1198 srcs: [
1199 "a*.java",
1200 ":gen",
1201 "b*.java",
1202 ],
1203 }
1204
1205 genrule {
1206 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -08001207 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -07001208 out: ["gen.java"],
1209 }
Colin Cross238c1f32020-06-07 16:58:18 -07001210 `, map[string][]byte{
1211 "a.java": nil,
1212 "b.java": nil,
1213 })
Colin Cross54190b32017-10-09 15:34:10 -07001214
1215 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1216 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
1217
Colin Cross15e86d92017-10-20 15:07:08 -07001218 if filepath.Base(genrule.Output.String()) != "gen.java" {
1219 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -07001220 }
1221
1222 if len(javac.Inputs) != 3 ||
1223 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -07001224 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -07001225 javac.Inputs[2].String() != "b.java" {
1226 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
1227 }
1228}
1229
Nan Zhang61eaedb2017-11-02 13:28:15 -07001230func TestTurbine(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001231 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001232 java_library {
1233 name: "foo",
1234 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +09001235 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001236 }
1237
1238 java_library {
1239 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -08001240 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -07001241 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +09001242 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001243 }
1244
1245 java_library {
1246 name: "baz",
1247 srcs: ["c.java"],
1248 libs: ["bar"],
1249 sdk_version: "14",
1250 }
1251 `)
1252
1253 fooTurbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine")
1254 barTurbine := ctx.ModuleForTests("bar", "android_common").Rule("turbine")
1255 barJavac := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1256 barTurbineCombined := ctx.ModuleForTests("bar", "android_common").Description("for turbine")
1257 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1258
1259 if len(fooTurbine.Inputs) != 1 || fooTurbine.Inputs[0].String() != "a.java" {
1260 t.Errorf(`foo inputs %v != ["a.java"]`, fooTurbine.Inputs)
1261 }
1262
1263 fooHeaderJar := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
1264 if !strings.Contains(barTurbine.Args["classpath"], fooHeaderJar) {
1265 t.Errorf("bar turbine classpath %v does not contain %q", barTurbine.Args["classpath"], fooHeaderJar)
1266 }
1267 if !strings.Contains(barJavac.Args["classpath"], fooHeaderJar) {
1268 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], fooHeaderJar)
1269 }
1270 if len(barTurbineCombined.Inputs) != 2 || barTurbineCombined.Inputs[1].String() != fooHeaderJar {
1271 t.Errorf("bar turbine combineJar inputs %v does not contain %q", barTurbineCombined.Inputs, fooHeaderJar)
1272 }
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001273 if !strings.Contains(bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") {
Nan Zhang61eaedb2017-11-02 13:28:15 -07001274 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001275 "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -07001276 }
1277}
1278
1279func TestSharding(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001280 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001281 java_library {
1282 name: "bar",
1283 srcs: ["a.java","b.java","c.java"],
1284 javac_shard_size: 1
1285 }
1286 `)
1287
1288 barHeaderJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
1289 for i := 0; i < 3; i++ {
1290 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
1291 if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) {
1292 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar)
1293 }
1294 }
1295}
1296
Nan Zhang581fd212018-01-10 16:06:12 -08001297func TestDroiddoc(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001298 ctx, _ := testJavaWithFS(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001299 droiddoc_exported_dir {
Dan Willemsencc090972018-02-26 14:33:31 -08001300 name: "droiddoc-templates-sdk",
1301 path: ".",
1302 }
Jiyong Park29074592019-07-07 16:27:47 +09001303 filegroup {
1304 name: "bar-doc-aidl-srcs",
1305 srcs: ["bar-doc/IBar.aidl"],
1306 path: "bar-doc",
1307 }
Liz Kammere1ab2502020-09-10 15:29:25 +00001308 droidstubs {
1309 name: "bar-stubs",
Liz Kammer3a55c912020-08-14 12:14:02 -07001310 srcs: [
Steve Kim3666c702020-09-01 17:58:01 +00001311 "bar-doc/a.java",
Liz Kammer3a55c912020-08-14 12:14:02 -07001312 ],
Steve Kim3666c702020-09-01 17:58:01 +00001313 exclude_srcs: [
1314 "bar-doc/b.java"
1315 ],
Liz Kammere1ab2502020-09-10 15:29:25 +00001316 api_levels_annotations_dirs: [
1317 "droiddoc-templates-sdk",
1318 ],
1319 api_levels_annotations_enabled: true,
1320 }
1321 droiddoc {
1322 name: "bar-doc",
1323 srcs: [
1324 ":bar-stubs",
1325 "bar-doc/IFoo.aidl",
1326 ":bar-doc-aidl-srcs",
1327 ],
Dan Willemsencc090972018-02-26 14:33:31 -08001328 custom_template: "droiddoc-templates-sdk",
Nan Zhang581fd212018-01-10 16:06:12 -08001329 hdf: [
1330 "android.whichdoc offline",
1331 ],
1332 knowntags: [
1333 "bar-doc/known_oj_tags.txt",
1334 ],
1335 proofread_file: "libcore-proofread.txt",
1336 todo_file: "libcore-docs-todo.html",
Liz Kammer585cac22020-07-06 09:12:57 -07001337 flags: ["-offlinemode -title \"libcore\""],
Nan Zhang581fd212018-01-10 16:06:12 -08001338 }
Colin Cross238c1f32020-06-07 16:58:18 -07001339 `,
1340 map[string][]byte{
1341 "bar-doc/a.java": nil,
1342 "bar-doc/b.java": nil,
1343 })
Liz Kammere1ab2502020-09-10 15:29:25 +00001344 barStubs := ctx.ModuleForTests("bar-stubs", "android_common")
1345 barStubsOutputs, err := barStubs.Module().(*Droidstubs).OutputFiles("")
1346 if err != nil {
1347 t.Errorf("Unexpected error %q retrieving \"bar-stubs\" output file", err)
1348 }
1349 if len(barStubsOutputs) != 1 {
1350 t.Errorf("Expected one output from \"bar-stubs\" got %s", barStubsOutputs)
Liz Kammer1e2ee122020-07-30 15:07:22 -07001351 }
Nan Zhang581fd212018-01-10 16:06:12 -08001352
Liz Kammere1ab2502020-09-10 15:29:25 +00001353 barStubsOutput := barStubsOutputs[0]
1354 barDoc := ctx.ModuleForTests("bar-doc", "android_common")
1355 javaDoc := barDoc.Rule("javadoc")
1356 if g, w := javaDoc.Implicits.Strings(), barStubsOutput.String(); !inList(w, g) {
1357 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
Jiyong Park29074592019-07-07 16:27:47 +09001358 }
1359
Liz Kammere1ab2502020-09-10 15:29:25 +00001360 expected := "-sourcepath " + buildDir + "/.intermediates/bar-doc/android_common/srcjars "
1361 if !strings.Contains(javaDoc.RuleParams.Command, expected) {
1362 t.Errorf("bar-doc command does not contain flag %q, but should\n%q", expected, javaDoc.RuleParams.Command)
1363 }
1364
1365 aidl := barDoc.Rule("aidl")
1366 if g, w := javaDoc.Implicits.Strings(), aidl.Output.String(); !inList(w, g) {
Colin Crossc0806172019-06-14 18:51:47 -07001367 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
1368 }
1369
1370 if g, w := aidl.Implicits.Strings(), []string{"bar-doc/IBar.aidl", "bar-doc/IFoo.aidl"}; !reflect.DeepEqual(w, g) {
1371 t.Errorf("aidl inputs must be %q, but was %q", w, g)
Jiyong Park1e440682018-05-23 18:42:04 +09001372 }
Nan Zhang581fd212018-01-10 16:06:12 -08001373}
1374
Liz Kammer585cac22020-07-06 09:12:57 -07001375func TestDroiddocArgsAndFlagsCausesError(t *testing.T) {
1376 testJavaError(t, "flags is set. Cannot set args", `
1377 droiddoc_exported_dir {
1378 name: "droiddoc-templates-sdk",
1379 path: ".",
1380 }
1381 filegroup {
1382 name: "bar-doc-aidl-srcs",
1383 srcs: ["bar-doc/IBar.aidl"],
1384 path: "bar-doc",
1385 }
Liz Kammere1ab2502020-09-10 15:29:25 +00001386 droidstubs {
1387 name: "bar-stubs",
Liz Kammer3a55c912020-08-14 12:14:02 -07001388 srcs: [
Steve Kim3666c702020-09-01 17:58:01 +00001389 "bar-doc/a.java",
Liz Kammer3a55c912020-08-14 12:14:02 -07001390 ],
Steve Kim3666c702020-09-01 17:58:01 +00001391 exclude_srcs: [
1392 "bar-doc/b.java"
1393 ],
Liz Kammere1ab2502020-09-10 15:29:25 +00001394 api_levels_annotations_dirs: [
1395 "droiddoc-templates-sdk",
1396 ],
1397 api_levels_annotations_enabled: true,
1398 }
1399 droiddoc {
1400 name: "bar-doc",
1401 srcs: [
1402 ":bar-stubs",
1403 "bar-doc/IFoo.aidl",
1404 ":bar-doc-aidl-srcs",
1405 ],
Liz Kammer585cac22020-07-06 09:12:57 -07001406 custom_template: "droiddoc-templates-sdk",
1407 hdf: [
1408 "android.whichdoc offline",
1409 ],
1410 knowntags: [
1411 "bar-doc/known_oj_tags.txt",
1412 ],
1413 proofread_file: "libcore-proofread.txt",
1414 todo_file: "libcore-docs-todo.html",
1415 flags: ["-offlinemode -title \"libcore\""],
1416 args: "-offlinemode -title \"libcore\"",
1417 }
1418 `)
1419}
1420
Liz Kammer3d894b72020-08-04 09:55:13 -07001421func TestDroidstubs(t *testing.T) {
1422 ctx, _ := testJavaWithFS(t, `
1423 droiddoc_exported_dir {
Anton Hansson52ac73d2020-10-26 09:57:40 +00001424 name: "droiddoc-templates-sdk",
1425 path: ".",
Liz Kammer3d894b72020-08-04 09:55:13 -07001426 }
1427
1428 droidstubs {
Anton Hansson52ac73d2020-10-26 09:57:40 +00001429 name: "bar-stubs",
1430 srcs: ["bar-doc/a.java"],
1431 api_levels_annotations_dirs: ["droiddoc-templates-sdk"],
1432 api_levels_annotations_enabled: true,
Liz Kammer3d894b72020-08-04 09:55:13 -07001433 }
1434
1435 droidstubs {
Anton Hansson52ac73d2020-10-26 09:57:40 +00001436 name: "bar-stubs-other",
1437 srcs: ["bar-doc/a.java"],
1438 high_mem: true,
1439 api_levels_annotations_dirs: ["droiddoc-templates-sdk"],
1440 api_levels_annotations_enabled: true,
1441 api_levels_jar_filename: "android.other.jar",
Liz Kammer3d894b72020-08-04 09:55:13 -07001442 }
1443 `,
1444 map[string][]byte{
1445 "bar-doc/a.java": nil,
1446 })
1447 testcases := []struct {
1448 moduleName string
1449 expectedJarFilename string
Anton Hansson52ac73d2020-10-26 09:57:40 +00001450 high_mem bool
Liz Kammer3d894b72020-08-04 09:55:13 -07001451 }{
1452 {
1453 moduleName: "bar-stubs",
1454 expectedJarFilename: "android.jar",
Anton Hansson52ac73d2020-10-26 09:57:40 +00001455 high_mem: false,
Liz Kammer3d894b72020-08-04 09:55:13 -07001456 },
1457 {
1458 moduleName: "bar-stubs-other",
1459 expectedJarFilename: "android.other.jar",
Anton Hansson52ac73d2020-10-26 09:57:40 +00001460 high_mem: true,
Liz Kammer3d894b72020-08-04 09:55:13 -07001461 },
1462 }
1463 for _, c := range testcases {
1464 m := ctx.ModuleForTests(c.moduleName, "android_common")
1465 metalava := m.Rule("metalava")
Anton Hansson52ac73d2020-10-26 09:57:40 +00001466 rp := metalava.RuleParams
Liz Kammer3d894b72020-08-04 09:55:13 -07001467 expected := "--android-jar-pattern ./%/public/" + c.expectedJarFilename
Anton Hansson52ac73d2020-10-26 09:57:40 +00001468 if actual := rp.Command; !strings.Contains(actual, expected) {
Liz Kammer3d894b72020-08-04 09:55:13 -07001469 t.Errorf("For %q, expected metalava argument %q, but was not found %q", c.moduleName, expected, actual)
1470 }
Anton Hansson52ac73d2020-10-26 09:57:40 +00001471
1472 if actual := rp.Pool != nil && strings.Contains(rp.Pool.String(), "highmem"); actual != c.high_mem {
1473 t.Errorf("Expected %q high_mem to be %v, was %v", c.moduleName, c.high_mem, actual)
1474 }
Liz Kammer3d894b72020-08-04 09:55:13 -07001475 }
1476}
1477
Paul Duffin83a2d962019-11-19 19:44:10 +00001478func TestDroidstubsWithSystemModules(t *testing.T) {
1479 ctx, _ := testJava(t, `
1480 droidstubs {
1481 name: "stubs-source-system-modules",
1482 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001483 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001484 ],
1485 sdk_version: "none",
1486 system_modules: "source-system-modules",
1487 }
1488
1489 java_library {
1490 name: "source-jar",
1491 srcs: [
1492 "a.java",
1493 ],
1494 }
1495
1496 java_system_modules {
1497 name: "source-system-modules",
1498 libs: ["source-jar"],
1499 }
1500
1501 droidstubs {
1502 name: "stubs-prebuilt-system-modules",
1503 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001504 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001505 ],
1506 sdk_version: "none",
1507 system_modules: "prebuilt-system-modules",
1508 }
1509
1510 java_import {
1511 name: "prebuilt-jar",
1512 jars: ["a.jar"],
1513 }
1514
1515 java_system_modules_import {
1516 name: "prebuilt-system-modules",
1517 libs: ["prebuilt-jar"],
1518 }
1519 `)
1520
1521 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-source-system-modules", "source-jar.jar")
1522
1523 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-prebuilt-system-modules", "prebuilt-jar.jar")
1524}
1525
1526func checkSystemModulesUseByDroidstubs(t *testing.T, ctx *android.TestContext, moduleName string, systemJar string) {
1527 metalavaRule := ctx.ModuleForTests(moduleName, "android_common").Rule("metalava")
1528 var systemJars []string
1529 for _, i := range metalavaRule.Implicits {
1530 systemJars = append(systemJars, i.Base())
1531 }
Ramy Medhatc7965cd2020-04-30 03:08:37 -04001532 if len(systemJars) < 1 || systemJars[0] != systemJar {
Paul Duffin83a2d962019-11-19 19:44:10 +00001533 t.Errorf("inputs of %q must be []string{%q}, but was %#v.", moduleName, systemJar, systemJars)
1534 }
1535}
1536
Colin Cross54250902017-12-05 09:28:08 -08001537func TestJarGenrules(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001538 ctx, _ := testJava(t, `
Colin Cross54250902017-12-05 09:28:08 -08001539 java_library {
1540 name: "foo",
1541 srcs: ["a.java"],
1542 }
1543
1544 java_genrule {
1545 name: "jargen",
1546 tool_files: ["b.java"],
1547 cmd: "$(location b.java) $(in) $(out)",
1548 out: ["jargen.jar"],
1549 srcs: [":foo"],
1550 }
1551
1552 java_library {
1553 name: "bar",
1554 static_libs: ["jargen"],
1555 srcs: ["c.java"],
1556 }
1557
1558 java_library {
1559 name: "baz",
1560 libs: ["jargen"],
1561 srcs: ["c.java"],
1562 }
1563 `)
1564
1565 foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar")
1566 jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar")
1567 bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar")
1568 baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar")
1569 barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar")
1570
Colin Cross3d680512020-11-13 16:23:53 -08001571 if g, w := jargen.Implicits.Strings(), foo.Output.String(); !android.InList(w, g) {
1572 t.Errorf("expected jargen inputs [%q], got %q", w, g)
Colin Cross54250902017-12-05 09:28:08 -08001573 }
1574
1575 if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) {
1576 t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String())
1577 }
1578
1579 if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) {
1580 t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String())
1581 }
1582
1583 if len(barCombined.Inputs) != 2 ||
1584 barCombined.Inputs[0].String() != bar.Output.String() ||
1585 barCombined.Inputs[1].String() != jargen.Output.String() {
1586 t.Errorf("bar combined jar inputs %v is not [%q, %q]",
1587 barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String())
1588 }
1589}
1590
Nan Zhang27e284d2018-02-09 21:03:53 +00001591func TestExcludeFileGroupInSrcs(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001592 ctx, _ := testJava(t, `
Nan Zhang27e284d2018-02-09 21:03:53 +00001593 java_library {
1594 name: "foo",
1595 srcs: ["a.java", ":foo-srcs"],
1596 exclude_srcs: ["a.java", ":foo-excludes"],
1597 }
1598
1599 filegroup {
1600 name: "foo-srcs",
1601 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
1602 }
1603
1604 filegroup {
1605 name: "foo-excludes",
1606 srcs: ["java-fg/a.java", "java-fg/b.java"],
1607 }
1608 `)
1609
1610 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1611
1612 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
1613 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
1614 }
1615}
Jiyong Parkc678ad32018-04-10 13:07:10 +09001616
Paul Duffin52d398a2019-06-11 12:31:14 +01001617func TestJavaLibrary(t *testing.T) {
Colin Cross98be1bb2019-12-13 20:41:13 -08001618 config := testConfig(nil, "", map[string][]byte{
Paul Duffin52d398a2019-06-11 12:31:14 +01001619 "libcore/Android.bp": []byte(`
1620 java_library {
1621 name: "core",
1622 sdk_version: "none",
1623 system_modules: "none",
Paul Duffinaa55f742020-10-06 17:20:13 +01001624 }
1625
1626 filegroup {
1627 name: "core-jar",
1628 srcs: [":core{.jar}"],
1629 }
1630`),
1631 })
Colin Crossae8600b2020-10-29 17:09:13 -07001632 ctx := testContext(config)
Paul Duffinaa55f742020-10-06 17:20:13 +01001633 run(t, ctx, config)
1634}
1635
1636func TestJavaImport(t *testing.T) {
1637 config := testConfig(nil, "", map[string][]byte{
1638 "libcore/Android.bp": []byte(`
1639 java_import {
1640 name: "core",
1641 sdk_version: "none",
1642 }
1643
1644 filegroup {
1645 name: "core-jar",
1646 srcs: [":core{.jar}"],
1647 }
1648`),
Paul Duffin52d398a2019-06-11 12:31:14 +01001649 })
Colin Crossae8600b2020-10-29 17:09:13 -07001650 ctx := testContext(config)
Paul Duffin52d398a2019-06-11 12:31:14 +01001651 run(t, ctx, config)
1652}
1653
Jiyong Parkc678ad32018-04-10 13:07:10 +09001654func TestJavaSdkLibrary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001655 ctx, _ := testJava(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001656 droiddoc_exported_dir {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001657 name: "droiddoc-templates-sdk",
1658 path: ".",
1659 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001660 java_sdk_library {
1661 name: "foo",
1662 srcs: ["a.java", "b.java"],
1663 api_packages: ["foo"],
1664 }
1665 java_sdk_library {
1666 name: "bar",
1667 srcs: ["a.java", "b.java"],
1668 api_packages: ["bar"],
1669 }
1670 java_library {
1671 name: "baz",
1672 srcs: ["c.java"],
Paul Duffin859fe962020-05-15 10:20:31 +01001673 libs: ["foo", "bar.stubs"],
Jiyong Parkc678ad32018-04-10 13:07:10 +09001674 sdk_version: "system_current",
1675 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001676 java_sdk_library {
1677 name: "barney",
1678 srcs: ["c.java"],
1679 api_only: true,
1680 }
1681 java_sdk_library {
1682 name: "betty",
1683 srcs: ["c.java"],
1684 shared_library: false,
1685 }
Paul Duffin859fe962020-05-15 10:20:31 +01001686 java_sdk_library_import {
1687 name: "quuz",
1688 public: {
1689 jars: ["c.jar"],
1690 },
1691 }
1692 java_sdk_library_import {
1693 name: "fred",
1694 public: {
1695 jars: ["b.jar"],
1696 },
1697 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001698 java_sdk_library_import {
1699 name: "wilma",
1700 public: {
1701 jars: ["b.jar"],
1702 },
1703 shared_library: false,
1704 }
Jiyong Park1be96912018-05-28 18:02:19 +09001705 java_library {
1706 name: "qux",
1707 srcs: ["c.java"],
Paul Duffindfa131e2020-05-15 20:37:11 +01001708 libs: ["baz", "fred", "quuz.stubs", "wilma", "barney", "betty"],
Jiyong Park1be96912018-05-28 18:02:19 +09001709 sdk_version: "system_current",
1710 }
Paul Duffin726d23c2020-01-22 16:30:37 +00001711 java_library {
1712 name: "baz-test",
1713 srcs: ["c.java"],
1714 libs: ["foo"],
1715 sdk_version: "test_current",
1716 }
Paul Duffina2db18f2020-01-22 17:11:15 +00001717 java_library {
1718 name: "baz-29",
1719 srcs: ["c.java"],
1720 libs: ["foo"],
1721 sdk_version: "system_29",
1722 }
Paul Duffinfb6ae5b2020-09-30 15:17:25 +01001723 java_library {
1724 name: "baz-module-30",
1725 srcs: ["c.java"],
1726 libs: ["foo"],
1727 sdk_version: "module_30",
1728 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001729 `)
1730
1731 // check the existence of the internal modules
1732 ctx.ModuleForTests("foo", "android_common")
Paul Duffindd9d0742020-05-08 15:52:37 +01001733 ctx.ModuleForTests(apiScopePublic.stubsLibraryModuleName("foo"), "android_common")
1734 ctx.ModuleForTests(apiScopeSystem.stubsLibraryModuleName("foo"), "android_common")
1735 ctx.ModuleForTests(apiScopeTest.stubsLibraryModuleName("foo"), "android_common")
1736 ctx.ModuleForTests(apiScopePublic.stubsSourceModuleName("foo"), "android_common")
1737 ctx.ModuleForTests(apiScopeSystem.stubsSourceModuleName("foo"), "android_common")
1738 ctx.ModuleForTests(apiScopeTest.stubsSourceModuleName("foo"), "android_common")
Jiyong Parke3833882020-02-17 17:28:10 +09001739 ctx.ModuleForTests("foo"+sdkXmlFileSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +09001740 ctx.ModuleForTests("foo.api.public.28", "")
1741 ctx.ModuleForTests("foo.api.system.28", "")
1742 ctx.ModuleForTests("foo.api.test.28", "")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001743
1744 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1745 // tests if baz is actually linked to the stubs lib
1746 if !strings.Contains(bazJavac.Args["classpath"], "foo.stubs.system.jar") {
1747 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
1748 "foo.stubs.system.jar")
1749 }
1750 // ... and not to the impl lib
Sundong Ahn054b19a2018-10-19 13:46:09 +09001751 if strings.Contains(bazJavac.Args["classpath"], "foo.jar") {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001752 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
Sundong Ahn054b19a2018-10-19 13:46:09 +09001753 "foo.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001754 }
1755 // test if baz is not linked to the system variant of foo
1756 if strings.Contains(bazJavac.Args["classpath"], "foo.stubs.jar") {
1757 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
1758 "foo.stubs.jar")
1759 }
Jiyong Park1be96912018-05-28 18:02:19 +09001760
Paul Duffin726d23c2020-01-22 16:30:37 +00001761 bazTestJavac := ctx.ModuleForTests("baz-test", "android_common").Rule("javac")
1762 // tests if baz-test is actually linked to the test stubs lib
1763 if !strings.Contains(bazTestJavac.Args["classpath"], "foo.stubs.test.jar") {
1764 t.Errorf("baz-test javac classpath %v does not contain %q", bazTestJavac.Args["classpath"],
1765 "foo.stubs.test.jar")
1766 }
1767
Paul Duffina2db18f2020-01-22 17:11:15 +00001768 baz29Javac := ctx.ModuleForTests("baz-29", "android_common").Rule("javac")
1769 // tests if baz-29 is actually linked to the system 29 stubs lib
1770 if !strings.Contains(baz29Javac.Args["classpath"], "prebuilts/sdk/29/system/foo.jar") {
1771 t.Errorf("baz-29 javac classpath %v does not contain %q", baz29Javac.Args["classpath"],
1772 "prebuilts/sdk/29/system/foo.jar")
1773 }
1774
Paul Duffinfb6ae5b2020-09-30 15:17:25 +01001775 bazModule30Javac := ctx.ModuleForTests("baz-module-30", "android_common").Rule("javac")
1776 // tests if "baz-module-30" is actually linked to the module 30 stubs lib
1777 if !strings.Contains(bazModule30Javac.Args["classpath"], "prebuilts/sdk/30/module-lib/foo.jar") {
1778 t.Errorf("baz-module-30 javac classpath %v does not contain %q", bazModule30Javac.Args["classpath"],
1779 "prebuilts/sdk/30/module-lib/foo.jar")
1780 }
1781
Jiyong Park1be96912018-05-28 18:02:19 +09001782 // test if baz has exported SDK lib names foo and bar to qux
1783 qux := ctx.ModuleForTests("qux", "android_common")
1784 if quxLib, ok := qux.Module().(*Library); ok {
Ulya Trafimovichb23d28c2020-10-08 12:53:58 +01001785 sdkLibs := quxLib.ClassLoaderContexts().UsesLibs()
Ulya Trafimovich8cbc5d22020-11-03 15:15:46 +00001786 if w := []string{"foo", "bar", "fred", "quuz"}; !reflect.DeepEqual(w, sdkLibs) {
Paul Duffin859fe962020-05-15 10:20:31 +01001787 t.Errorf("qux should export %q but exports %q", w, sdkLibs)
Jiyong Park1be96912018-05-28 18:02:19 +09001788 }
1789 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001790}
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001791
Anton Hansson7f66efa2020-10-08 14:47:23 +01001792func TestJavaSdkLibrary_StubOrImplOnlyLibs(t *testing.T) {
1793 ctx, _ := testJava(t, `
1794 java_sdk_library {
1795 name: "sdk_lib",
1796 srcs: ["a.java"],
1797 impl_only_libs: ["foo"],
1798 stub_only_libs: ["bar"],
1799 }
1800 java_library {
1801 name: "foo",
1802 srcs: ["a.java"],
1803 sdk_version: "current",
1804 }
1805 java_library {
1806 name: "bar",
1807 srcs: ["a.java"],
1808 sdk_version: "current",
1809 }
1810 `)
1811
1812 for _, implName := range []string{"sdk_lib", "sdk_lib.impl"} {
1813 implJavacCp := ctx.ModuleForTests(implName, "android_common").Rule("javac").Args["classpath"]
1814 if !strings.Contains(implJavacCp, "/foo.jar") || strings.Contains(implJavacCp, "/bar.jar") {
1815 t.Errorf("%v javac classpath %v does not contain foo and not bar", implName, implJavacCp)
1816 }
1817 }
1818 stubName := apiScopePublic.stubsLibraryModuleName("sdk_lib")
1819 stubsJavacCp := ctx.ModuleForTests(stubName, "android_common").Rule("javac").Args["classpath"]
1820 if strings.Contains(stubsJavacCp, "/foo.jar") || !strings.Contains(stubsJavacCp, "/bar.jar") {
1821 t.Errorf("stubs javac classpath %v does not contain bar and not foo", stubsJavacCp)
1822 }
1823}
1824
Paul Duffindaaa3322020-05-26 18:13:57 +01001825func TestJavaSdkLibrary_DoNotAccessImplWhenItIsNotBuilt(t *testing.T) {
1826 ctx, _ := testJava(t, `
1827 java_sdk_library {
1828 name: "foo",
1829 srcs: ["a.java"],
1830 api_only: true,
1831 public: {
1832 enabled: true,
1833 },
1834 }
1835
1836 java_library {
1837 name: "bar",
1838 srcs: ["b.java"],
1839 libs: ["foo"],
1840 }
1841 `)
1842
1843 // The bar library should depend on the stubs jar.
1844 barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1845 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1846 t.Errorf("expected %q, found %#q", expected, actual)
1847 }
1848}
1849
Paul Duffin46dc45a2020-05-14 15:39:10 +01001850func TestJavaSdkLibrary_UseSourcesFromAnotherSdkLibrary(t *testing.T) {
1851 testJava(t, `
1852 java_sdk_library {
1853 name: "foo",
1854 srcs: ["a.java"],
1855 api_packages: ["foo"],
1856 public: {
1857 enabled: true,
1858 },
1859 }
1860
1861 java_library {
1862 name: "bar",
1863 srcs: ["b.java", ":foo{.public.stubs.source}"],
1864 }
1865 `)
1866}
1867
1868func TestJavaSdkLibrary_AccessOutputFiles_MissingScope(t *testing.T) {
1869 testJavaError(t, `"foo" does not provide api scope system`, `
1870 java_sdk_library {
1871 name: "foo",
1872 srcs: ["a.java"],
1873 api_packages: ["foo"],
1874 public: {
1875 enabled: true,
1876 },
1877 }
1878
1879 java_library {
1880 name: "bar",
1881 srcs: ["b.java", ":foo{.system.stubs.source}"],
1882 }
1883 `)
1884}
1885
Paul Duffinca8d9a52020-06-26 22:20:25 +01001886func TestJavaSdkLibrary_Deps(t *testing.T) {
1887 ctx, _ := testJava(t, `
1888 java_sdk_library {
1889 name: "sdklib",
1890 srcs: ["a.java"],
1891 sdk_version: "none",
1892 system_modules: "none",
1893 public: {
1894 enabled: true,
1895 },
1896 }
1897 `)
1898
Paul Duffincee7e662020-07-09 17:32:57 +01001899 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +01001900 `dex2oatd`,
1901 `sdklib.impl`,
1902 `sdklib.stubs`,
1903 `sdklib.stubs.source`,
1904 `sdklib.xml`,
1905 })
1906}
1907
Paul Duffin46dc45a2020-05-14 15:39:10 +01001908func TestJavaSdkLibraryImport_AccessOutputFiles(t *testing.T) {
1909 testJava(t, `
1910 java_sdk_library_import {
1911 name: "foo",
1912 public: {
1913 jars: ["a.jar"],
1914 stub_srcs: ["a.java"],
1915 current_api: "api/current.txt",
1916 removed_api: "api/removed.txt",
1917 },
1918 }
1919
1920 java_library {
1921 name: "bar",
1922 srcs: [":foo{.public.stubs.source}"],
1923 java_resources: [
1924 ":foo{.public.api.txt}",
1925 ":foo{.public.removed-api.txt}",
1926 ],
1927 }
1928 `)
1929}
1930
1931func TestJavaSdkLibraryImport_AccessOutputFiles_Invalid(t *testing.T) {
1932 bp := `
1933 java_sdk_library_import {
1934 name: "foo",
1935 public: {
1936 jars: ["a.jar"],
1937 },
1938 }
1939 `
1940
1941 t.Run("stubs.source", func(t *testing.T) {
1942 testJavaError(t, `stubs.source not available for api scope public`, bp+`
1943 java_library {
1944 name: "bar",
1945 srcs: [":foo{.public.stubs.source}"],
1946 java_resources: [
1947 ":foo{.public.api.txt}",
1948 ":foo{.public.removed-api.txt}",
1949 ],
1950 }
1951 `)
1952 })
1953
1954 t.Run("api.txt", func(t *testing.T) {
1955 testJavaError(t, `api.txt not available for api scope public`, bp+`
1956 java_library {
1957 name: "bar",
1958 srcs: ["a.java"],
1959 java_resources: [
1960 ":foo{.public.api.txt}",
1961 ],
1962 }
1963 `)
1964 })
1965
1966 t.Run("removed-api.txt", func(t *testing.T) {
1967 testJavaError(t, `removed-api.txt not available for api scope public`, bp+`
1968 java_library {
1969 name: "bar",
1970 srcs: ["a.java"],
1971 java_resources: [
1972 ":foo{.public.removed-api.txt}",
1973 ],
1974 }
1975 `)
1976 })
1977}
1978
Paul Duffin3375e352020-04-28 10:44:03 +01001979func TestJavaSdkLibrary_InvalidScopes(t *testing.T) {
1980 testJavaError(t, `module "foo": enabled api scope "system" depends on disabled scope "public"`, `
1981 java_sdk_library {
1982 name: "foo",
1983 srcs: ["a.java", "b.java"],
1984 api_packages: ["foo"],
1985 // Explicitly disable public to test the check that ensures the set of enabled
1986 // scopes is consistent.
1987 public: {
1988 enabled: false,
1989 },
1990 system: {
1991 enabled: true,
1992 },
1993 }
1994 `)
1995}
1996
Paul Duffin87a05a32020-05-12 11:50:28 +01001997func TestJavaSdkLibrary_SdkVersion_ForScope(t *testing.T) {
1998 testJava(t, `
1999 java_sdk_library {
2000 name: "foo",
2001 srcs: ["a.java", "b.java"],
2002 api_packages: ["foo"],
2003 system: {
2004 enabled: true,
2005 sdk_version: "module_current",
2006 },
2007 }
2008 `)
2009}
2010
Paul Duffin0c5bae52020-06-02 13:00:08 +01002011func TestJavaSdkLibrary_ModuleLib(t *testing.T) {
2012 testJava(t, `
2013 java_sdk_library {
2014 name: "foo",
2015 srcs: ["a.java", "b.java"],
2016 api_packages: ["foo"],
2017 system: {
2018 enabled: true,
2019 },
2020 module_lib: {
2021 enabled: true,
2022 },
2023 }
2024 `)
2025}
2026
2027func TestJavaSdkLibrary_SystemServer(t *testing.T) {
2028 testJava(t, `
2029 java_sdk_library {
2030 name: "foo",
2031 srcs: ["a.java", "b.java"],
2032 api_packages: ["foo"],
2033 system: {
2034 enabled: true,
2035 },
2036 system_server: {
2037 enabled: true,
2038 },
2039 }
2040 `)
2041}
2042
Paul Duffin803a9562020-05-20 11:52:25 +01002043func TestJavaSdkLibrary_MissingScope(t *testing.T) {
2044 testJavaError(t, `requires api scope module-lib from foo but it only has \[\] available`, `
2045 java_sdk_library {
2046 name: "foo",
2047 srcs: ["a.java"],
2048 public: {
2049 enabled: false,
2050 },
2051 }
2052
2053 java_library {
2054 name: "baz",
2055 srcs: ["a.java"],
2056 libs: ["foo"],
2057 sdk_version: "module_current",
2058 }
2059 `)
2060}
2061
2062func TestJavaSdkLibrary_FallbackScope(t *testing.T) {
2063 testJava(t, `
2064 java_sdk_library {
2065 name: "foo",
2066 srcs: ["a.java"],
2067 system: {
2068 enabled: true,
2069 },
2070 }
2071
2072 java_library {
2073 name: "baz",
2074 srcs: ["a.java"],
2075 libs: ["foo"],
2076 // foo does not have module-lib scope so it should fallback to system
2077 sdk_version: "module_current",
2078 }
2079 `)
2080}
2081
Jiyong Park932cdfe2020-05-28 00:19:53 +09002082func TestJavaSdkLibrary_DefaultToStubs(t *testing.T) {
2083 ctx, _ := testJava(t, `
2084 java_sdk_library {
2085 name: "foo",
2086 srcs: ["a.java"],
2087 system: {
2088 enabled: true,
2089 },
2090 default_to_stubs: true,
2091 }
2092
2093 java_library {
2094 name: "baz",
2095 srcs: ["a.java"],
2096 libs: ["foo"],
2097 // does not have sdk_version set, should fallback to module,
2098 // which will then fallback to system because the module scope
2099 // is not enabled.
2100 }
2101 `)
2102 // The baz library should depend on the system stubs jar.
2103 bazLibrary := ctx.ModuleForTests("baz", "android_common").Rule("javac")
2104 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs.system\.jar$`, bazLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
2105 t.Errorf("expected %q, found %#q", expected, actual)
2106 }
2107}
2108
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02002109var compilerFlagsTestCases = []struct {
2110 in string
2111 out bool
2112}{
2113 {
2114 in: "a",
2115 out: false,
2116 },
2117 {
2118 in: "-a",
2119 out: true,
2120 },
2121 {
2122 in: "-no-jdk",
2123 out: false,
2124 },
2125 {
2126 in: "-no-stdlib",
2127 out: false,
2128 },
2129 {
2130 in: "-kotlin-home",
2131 out: false,
2132 },
2133 {
2134 in: "-kotlin-home /some/path",
2135 out: false,
2136 },
2137 {
2138 in: "-include-runtime",
2139 out: false,
2140 },
2141 {
2142 in: "-Xintellij-plugin-root",
2143 out: false,
2144 },
2145}
2146
2147type mockContext struct {
2148 android.ModuleContext
2149 result bool
2150}
2151
2152func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
2153 // CheckBadCompilerFlags calls this function when the flag should be rejected
2154 ctx.result = false
2155}
2156
2157func TestCompilerFlags(t *testing.T) {
2158 for _, testCase := range compilerFlagsTestCases {
2159 ctx := &mockContext{result: true}
2160 CheckKotlincFlags(ctx, []string{testCase.in})
2161 if ctx.result != testCase.out {
2162 t.Errorf("incorrect output:")
2163 t.Errorf(" input: %#v", testCase.in)
2164 t.Errorf(" expected: %#v", testCase.out)
2165 t.Errorf(" got: %#v", ctx.result)
2166 }
2167 }
2168}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002169
2170// TODO(jungjw): Consider making this more robust by ignoring path order.
2171func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
2172 variables := ctx.ModuleForTests(moduleName, "android_common").Module().VariablesForTests()
2173 flags := strings.Split(variables["javacFlags"], " ")
2174 got := ""
2175 for _, flag := range flags {
2176 keyEnd := strings.Index(flag, "=")
2177 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
2178 got = flag[keyEnd+1:]
2179 break
2180 }
2181 }
2182 if expected != got {
2183 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
2184 }
2185}
2186
2187func TestPatchModule(t *testing.T) {
Pete Gillin0c2143e2019-05-02 15:32:11 +01002188 t.Run("Java language level 8", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01002189 // Test with legacy javac -source 1.8 -target 1.8
Pete Gillinbdf5d712019-10-21 14:29:58 +01002190 bp := `
2191 java_library {
2192 name: "foo",
2193 srcs: ["a.java"],
2194 java_version: "1.8",
2195 }
2196
2197 java_library {
2198 name: "bar",
2199 srcs: ["b.java"],
2200 sdk_version: "none",
2201 system_modules: "none",
2202 patch_module: "java.base",
2203 java_version: "1.8",
2204 }
2205
2206 java_library {
2207 name: "baz",
2208 srcs: ["c.java"],
2209 patch_module: "java.base",
2210 java_version: "1.8",
2211 }
2212 `
2213 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002214
2215 checkPatchModuleFlag(t, ctx, "foo", "")
2216 checkPatchModuleFlag(t, ctx, "bar", "")
2217 checkPatchModuleFlag(t, ctx, "baz", "")
2218 })
2219
Pete Gillin0c2143e2019-05-02 15:32:11 +01002220 t.Run("Java language level 9", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01002221 // Test with default javac -source 9 -target 9
Pete Gillinbdf5d712019-10-21 14:29:58 +01002222 bp := `
2223 java_library {
2224 name: "foo",
2225 srcs: ["a.java"],
2226 }
2227
2228 java_library {
2229 name: "bar",
2230 srcs: ["b.java"],
2231 sdk_version: "none",
2232 system_modules: "none",
2233 patch_module: "java.base",
2234 }
2235
2236 java_library {
2237 name: "baz",
Jingwen Chen5136a6e2020-10-30 01:01:35 -04002238 srcs: [
2239 "c.java",
2240 // Tests for b/150878007
2241 "dir/d.java",
2242 "dir2/e.java",
2243 "dir2/f.java",
2244 "nested/dir/g.java"
2245 ],
Pete Gillinbdf5d712019-10-21 14:29:58 +01002246 patch_module: "java.base",
2247 }
2248 `
Pete Gillin1b3370f2019-10-01 13:57:31 +01002249 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002250
2251 checkPatchModuleFlag(t, ctx, "foo", "")
2252 expected := "java.base=.:" + buildDir
2253 checkPatchModuleFlag(t, ctx, "bar", expected)
Jingwen Chen5136a6e2020-10-30 01:01:35 -04002254 expected = "java.base=" + strings.Join([]string{
2255 ".", buildDir, "dir", "dir2", "nested", moduleToPath("ext"), moduleToPath("framework")}, ":")
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002256 checkPatchModuleFlag(t, ctx, "baz", expected)
2257 })
2258}
Paul Duffina7b9f422020-01-10 17:12:18 +00002259
2260func TestJavaSystemModules(t *testing.T) {
2261 ctx, _ := testJava(t, `
2262 java_system_modules {
2263 name: "system-modules",
2264 libs: ["system-module1", "system-module2"],
2265 }
2266 java_library {
2267 name: "system-module1",
2268 srcs: ["a.java"],
2269 sdk_version: "none",
2270 system_modules: "none",
2271 }
2272 java_library {
2273 name: "system-module2",
2274 srcs: ["b.java"],
2275 sdk_version: "none",
2276 system_modules: "none",
2277 }
2278 `)
2279
2280 // check the existence of the module
2281 systemModules := ctx.ModuleForTests("system-modules", "android_common")
2282
2283 cmd := systemModules.Rule("jarsTosystemModules")
2284
2285 // make sure the command compiles against the supplied modules.
2286 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
2287 if !strings.Contains(cmd.Args["classpath"], module) {
2288 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
2289 module)
2290 }
2291 }
2292}
Paul Duffin90169ba2020-01-10 17:16:44 +00002293
2294func TestJavaSystemModulesImport(t *testing.T) {
2295 ctx, _ := testJava(t, `
2296 java_system_modules_import {
2297 name: "system-modules",
2298 libs: ["system-module1", "system-module2"],
2299 }
2300 java_import {
2301 name: "system-module1",
2302 jars: ["a.jar"],
2303 }
2304 java_import {
2305 name: "system-module2",
2306 jars: ["b.jar"],
2307 }
2308 `)
2309
2310 // check the existence of the module
2311 systemModules := ctx.ModuleForTests("system-modules", "android_common")
2312
2313 cmd := systemModules.Rule("jarsTosystemModules")
2314
2315 // make sure the command compiles against the supplied modules.
2316 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
2317 if !strings.Contains(cmd.Args["classpath"], module) {
2318 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
2319 module)
2320 }
2321 }
2322}
Paul Duffin83a2d962019-11-19 19:44:10 +00002323
2324func TestJavaLibraryWithSystemModules(t *testing.T) {
2325 ctx, _ := testJava(t, `
2326 java_library {
2327 name: "lib-with-source-system-modules",
2328 srcs: [
2329 "a.java",
2330 ],
2331 sdk_version: "none",
2332 system_modules: "source-system-modules",
2333 }
2334
2335 java_library {
2336 name: "source-jar",
2337 srcs: [
2338 "a.java",
2339 ],
2340 }
2341
2342 java_system_modules {
2343 name: "source-system-modules",
2344 libs: ["source-jar"],
2345 }
2346
2347 java_library {
2348 name: "lib-with-prebuilt-system-modules",
2349 srcs: [
2350 "a.java",
2351 ],
2352 sdk_version: "none",
2353 system_modules: "prebuilt-system-modules",
2354 }
2355
2356 java_import {
2357 name: "prebuilt-jar",
2358 jars: ["a.jar"],
2359 }
2360
2361 java_system_modules_import {
2362 name: "prebuilt-system-modules",
2363 libs: ["prebuilt-jar"],
2364 }
2365 `)
2366
2367 checkBootClasspathForSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar")
2368
2369 checkBootClasspathForSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar")
2370}
2371
2372func checkBootClasspathForSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) {
2373 javacRule := ctx.ModuleForTests(moduleName, "android_common").Rule("javac")
2374 bootClasspath := javacRule.Args["bootClasspath"]
2375 if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) {
2376 t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath)
2377 }
2378}
Jiyong Park19604de2020-03-24 16:44:11 +09002379
2380func TestAidlExportIncludeDirsFromImports(t *testing.T) {
2381 ctx, _ := testJava(t, `
2382 java_library {
2383 name: "foo",
2384 srcs: ["aidl/foo/IFoo.aidl"],
2385 libs: ["bar"],
2386 }
2387
2388 java_import {
2389 name: "bar",
2390 jars: ["a.jar"],
2391 aidl: {
2392 export_include_dirs: ["aidl/bar"],
2393 },
2394 }
2395 `)
2396
2397 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
2398 expectedAidlFlag := "-Iaidl/bar"
2399 if !strings.Contains(aidlCommand, expectedAidlFlag) {
2400 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
2401 }
2402}
Liz Kammerdd849a82020-06-12 16:38:45 -07002403
2404func TestDataNativeBinaries(t *testing.T) {
2405 ctx, config := testJava(t, `
2406 java_test_host {
2407 name: "foo",
2408 srcs: ["a.java"],
2409 data_native_bins: ["bin"]
2410 }
2411
2412 python_binary_host {
2413 name: "bin",
2414 srcs: ["bin.py"],
2415 }
2416 `)
2417
2418 buildOS := android.BuildOs.String()
2419
2420 test := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
2421 entries := android.AndroidMkEntriesForTest(t, config, "", test)[0]
2422 expected := []string{buildDir + "/.intermediates/bin/" + buildOS + "_x86_64_PY3/bin:bin"}
2423 actual := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
2424 if !reflect.DeepEqual(expected, actual) {
2425 t.Errorf("Unexpected test data - expected: %q, actual: %q", expected, actual)
2426 }
2427}