Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 1 | // Copyright 2017 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package java |
| 16 | |
| 17 | import ( |
Paul Duffin | 1a39332 | 2020-11-18 16:36:47 +0000 | [diff] [blame] | 18 | "fmt" |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 19 | "io/ioutil" |
| 20 | "os" |
| 21 | "path/filepath" |
Colin Cross | c080617 | 2019-06-14 18:51:47 -0700 | [diff] [blame] | 22 | "reflect" |
Paul Duffin | daaa332 | 2020-05-26 18:13:57 +0100 | [diff] [blame] | 23 | "regexp" |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 24 | "strconv" |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 25 | "strings" |
| 26 | "testing" |
Colin Cross | 86a60ae | 2018-05-29 14:44:55 -0700 | [diff] [blame] | 27 | |
Jeongik Cha | 28df257 | 2019-11-11 10:46:36 +0900 | [diff] [blame] | 28 | "github.com/google/blueprint/proptools" |
| 29 | |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 30 | "android/soong/android" |
| 31 | "android/soong/cc" |
Colin Cross | c28bb0b | 2019-02-25 14:20:47 -0800 | [diff] [blame] | 32 | "android/soong/dexpreopt" |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 33 | "android/soong/python" |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 34 | ) |
| 35 | |
| 36 | var buildDir string |
| 37 | |
| 38 | func setUp() { |
| 39 | var err error |
| 40 | buildDir, err = ioutil.TempDir("", "soong_java_test") |
| 41 | if err != nil { |
| 42 | panic(err) |
| 43 | } |
| 44 | } |
| 45 | |
| 46 | func tearDown() { |
| 47 | os.RemoveAll(buildDir) |
| 48 | } |
| 49 | |
| 50 | func TestMain(m *testing.M) { |
| 51 | run := func() int { |
| 52 | setUp() |
| 53 | defer tearDown() |
| 54 | |
| 55 | return m.Run() |
| 56 | } |
| 57 | |
| 58 | os.Exit(run()) |
| 59 | } |
Colin Cross | 527012a | 2017-11-30 22:56:16 -0800 | [diff] [blame] | 60 | |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 61 | func testConfig(env map[string]string, bp string, fs map[string][]byte) android.Config { |
Martin Stjernholm | d90676f | 2020-01-11 00:37:30 +0000 | [diff] [blame] | 62 | bp += dexpreopt.BpToolModulesForTest() |
| 63 | |
Martin Stjernholm | 75a48d8 | 2020-01-10 20:32:59 +0000 | [diff] [blame] | 64 | config := TestConfig(buildDir, env, bp, fs) |
| 65 | |
| 66 | // Set up the global Once cache used for dexpreopt.GlobalSoongConfig, so that |
| 67 | // it doesn't create a real one, which would fail. |
| 68 | _ = dexpreopt.GlobalSoongConfigForTests(config) |
| 69 | |
| 70 | return config |
Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 71 | } |
| 72 | |
Colin Cross | ae8600b | 2020-10-29 17:09:13 -0700 | [diff] [blame] | 73 | func testContext(config android.Config) *android.TestContext { |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 74 | |
Colin Cross | ae8600b | 2020-10-29 17:09:13 -0700 | [diff] [blame] | 75 | ctx := android.NewTestArchContext(config) |
Paul Duffin | f9b1da0 | 2019-12-18 19:51:55 +0000 | [diff] [blame] | 76 | RegisterJavaBuildComponents(ctx) |
| 77 | RegisterAppBuildComponents(ctx) |
Jaewoong Jung | f9b4465 | 2020-12-21 12:29:12 -0800 | [diff] [blame] | 78 | RegisterAppImportBuildComponents(ctx) |
| 79 | RegisterAppSetBuildComponents(ctx) |
Paul Duffin | f9b1da0 | 2019-12-18 19:51:55 +0000 | [diff] [blame] | 80 | RegisterAARBuildComponents(ctx) |
Paul Duffin | b0f8507 | 2019-12-19 10:28:56 +0000 | [diff] [blame] | 81 | RegisterGenRuleBuildComponents(ctx) |
Jaewoong Jung | f9b4465 | 2020-12-21 12:29:12 -0800 | [diff] [blame] | 82 | RegisterRuntimeResourceOverlayBuildComponents(ctx) |
Paul Duffin | 43dc1cc | 2019-12-19 11:18:54 +0000 | [diff] [blame] | 83 | RegisterSystemModulesBuildComponents(ctx) |
Colin Cross | 4b49b76 | 2019-11-22 15:25:03 -0800 | [diff] [blame] | 84 | ctx.RegisterModuleType("java_plugin", PluginFactory) |
Colin Cross | 4b49b76 | 2019-11-22 15:25:03 -0800 | [diff] [blame] | 85 | ctx.RegisterModuleType("filegroup", android.FileGroupFactory) |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 86 | ctx.RegisterModuleType("python_binary_host", python.PythonBinaryHostFactory) |
Paul Duffin | 884363e | 2019-12-19 10:21:09 +0000 | [diff] [blame] | 87 | RegisterDocsBuildComponents(ctx) |
| 88 | RegisterStubsBuildComponents(ctx) |
Anton Hansson | dff2c78 | 2020-12-21 17:10:01 +0000 | [diff] [blame] | 89 | RegisterPrebuiltApisBuildComponents(ctx) |
Paul Duffin | 43dc1cc | 2019-12-19 11:18:54 +0000 | [diff] [blame] | 90 | RegisterSdkLibraryBuildComponents(ctx) |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 91 | ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators) |
Paul Duffin | 44f1d84 | 2020-06-26 20:17:02 +0100 | [diff] [blame] | 92 | ctx.PreArchMutators(android.RegisterComponentsMutator) |
Paul Duffin | a48f758 | 2019-12-19 11:25:19 +0000 | [diff] [blame] | 93 | |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 94 | ctx.PreDepsMutators(python.RegisterPythonPreDepsMutators) |
Jaewoong Jung | b639a6a | 2019-05-10 15:16:29 -0700 | [diff] [blame] | 95 | ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators) |
Colin Cross | 06fa588 | 2020-10-29 18:21:38 -0700 | [diff] [blame] | 96 | ctx.RegisterPreSingletonType("overlay", android.SingletonFactoryAdaptor(ctx.Context, OverlaySingletonFactory)) |
| 97 | ctx.RegisterPreSingletonType("sdk_versions", android.SingletonFactoryAdaptor(ctx.Context, sdkPreSingletonFactory)) |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 98 | |
Paul Duffin | 021f4e5 | 2020-07-30 16:04:17 +0100 | [diff] [blame] | 99 | android.RegisterPrebuiltMutators(ctx) |
| 100 | |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 101 | // Register module types and mutators from cc needed for JNI testing |
Paul Duffin | 77980a8 | 2019-12-19 16:01:36 +0000 | [diff] [blame] | 102 | cc.RegisterRequiredBuildComponentsForTest(ctx) |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 103 | |
Martin Stjernholm | d90676f | 2020-01-11 00:37:30 +0000 | [diff] [blame] | 104 | dexpreopt.RegisterToolModulesForTest(ctx) |
| 105 | |
Jaewoong Jung | c779cd4 | 2020-10-06 18:56:10 -0700 | [diff] [blame] | 106 | ctx.PostDepsMutators(func(ctx android.RegisterMutatorsContext) { |
| 107 | ctx.TopDown("propagate_rro_enforcement", propagateRROEnforcementMutator).Parallel() |
| 108 | }) |
| 109 | |
Colin Cross | 527012a | 2017-11-30 22:56:16 -0800 | [diff] [blame] | 110 | return ctx |
| 111 | } |
| 112 | |
| 113 | func run(t *testing.T, ctx *android.TestContext, config android.Config) { |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 114 | t.Helper() |
Colin Cross | c28bb0b | 2019-02-25 14:20:47 -0800 | [diff] [blame] | 115 | |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 116 | pathCtx := android.PathContextForTesting(config) |
Martin Stjernholm | 40f9f3c | 2020-01-20 18:12:23 +0000 | [diff] [blame] | 117 | dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx)) |
Colin Cross | c28bb0b | 2019-02-25 14:20:47 -0800 | [diff] [blame] | 118 | |
Colin Cross | ae8600b | 2020-10-29 17:09:13 -0700 | [diff] [blame] | 119 | ctx.Register() |
Paul Duffin | baccf7e | 2019-06-11 11:58:30 +0100 | [diff] [blame] | 120 | _, errs := ctx.ParseBlueprintsFiles("Android.bp") |
Logan Chien | 4203971 | 2018-03-12 16:29:17 +0800 | [diff] [blame] | 121 | android.FailIfErrored(t, errs) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 122 | _, errs = ctx.PrepareBuildActions(config) |
Logan Chien | 4203971 | 2018-03-12 16:29:17 +0800 | [diff] [blame] | 123 | android.FailIfErrored(t, errs) |
Colin Cross | 527012a | 2017-11-30 22:56:16 -0800 | [diff] [blame] | 124 | } |
| 125 | |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 126 | func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) { |
Jeongik Cha | 538c0d0 | 2019-07-11 15:54:27 +0900 | [diff] [blame] | 127 | t.Helper() |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 128 | return testJavaErrorWithConfig(t, pattern, testConfig(nil, bp, nil)) |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 129 | } |
| 130 | |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 131 | func testJavaErrorWithConfig(t *testing.T, pattern string, config android.Config) (*android.TestContext, android.Config) { |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 132 | t.Helper() |
Colin Cross | ae8600b | 2020-10-29 17:09:13 -0700 | [diff] [blame] | 133 | ctx := testContext(config) |
Jeongik Cha | 538c0d0 | 2019-07-11 15:54:27 +0900 | [diff] [blame] | 134 | |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 135 | pathCtx := android.PathContextForTesting(config) |
Martin Stjernholm | 40f9f3c | 2020-01-20 18:12:23 +0000 | [diff] [blame] | 136 | dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx)) |
Jeongik Cha | 538c0d0 | 2019-07-11 15:54:27 +0900 | [diff] [blame] | 137 | |
Colin Cross | ae8600b | 2020-10-29 17:09:13 -0700 | [diff] [blame] | 138 | ctx.Register() |
Jeongik Cha | 538c0d0 | 2019-07-11 15:54:27 +0900 | [diff] [blame] | 139 | _, errs := ctx.ParseBlueprintsFiles("Android.bp") |
| 140 | if len(errs) > 0 { |
| 141 | android.FailIfNoMatchingErrors(t, pattern, errs) |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 142 | return ctx, config |
Jeongik Cha | 538c0d0 | 2019-07-11 15:54:27 +0900 | [diff] [blame] | 143 | } |
| 144 | _, errs = ctx.PrepareBuildActions(config) |
| 145 | if len(errs) > 0 { |
| 146 | android.FailIfNoMatchingErrors(t, pattern, errs) |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 147 | return ctx, config |
Jeongik Cha | 538c0d0 | 2019-07-11 15:54:27 +0900 | [diff] [blame] | 148 | } |
| 149 | |
| 150 | t.Fatalf("missing expected error %q (0 errors are returned)", pattern) |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 151 | |
| 152 | return ctx, config |
Jeongik Cha | 538c0d0 | 2019-07-11 15:54:27 +0900 | [diff] [blame] | 153 | } |
| 154 | |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 155 | func testJavaWithFS(t *testing.T, bp string, fs map[string][]byte) (*android.TestContext, android.Config) { |
| 156 | t.Helper() |
| 157 | return testJavaWithConfig(t, testConfig(nil, bp, fs)) |
| 158 | } |
| 159 | |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 160 | func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) { |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 161 | t.Helper() |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 162 | return testJavaWithFS(t, bp, nil) |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 163 | } |
| 164 | |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 165 | func testJavaWithConfig(t *testing.T, config android.Config) (*android.TestContext, android.Config) { |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 166 | t.Helper() |
Colin Cross | ae8600b | 2020-10-29 17:09:13 -0700 | [diff] [blame] | 167 | ctx := testContext(config) |
Colin Cross | 527012a | 2017-11-30 22:56:16 -0800 | [diff] [blame] | 168 | run(t, ctx, config) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 169 | |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 170 | return ctx, config |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 171 | } |
| 172 | |
Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 173 | func moduleToPath(name string) string { |
| 174 | switch { |
| 175 | case name == `""`: |
| 176 | return name |
Colin Cross | fc3674a | 2017-09-18 17:41:52 -0700 | [diff] [blame] | 177 | case strings.HasSuffix(name, ".jar"): |
| 178 | return name |
Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 179 | default: |
| 180 | return filepath.Join(buildDir, ".intermediates", name, "android_common", "turbine-combined", name+".jar") |
Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 181 | } |
| 182 | } |
| 183 | |
Jeongik Cha | e403e9e | 2019-12-07 00:16:24 +0900 | [diff] [blame] | 184 | func TestJavaLinkType(t *testing.T) { |
| 185 | testJava(t, ` |
| 186 | java_library { |
| 187 | name: "foo", |
| 188 | srcs: ["a.java"], |
| 189 | libs: ["bar"], |
| 190 | static_libs: ["baz"], |
| 191 | } |
| 192 | |
| 193 | java_library { |
| 194 | name: "bar", |
| 195 | sdk_version: "current", |
| 196 | srcs: ["b.java"], |
| 197 | } |
| 198 | |
| 199 | java_library { |
| 200 | name: "baz", |
| 201 | sdk_version: "system_current", |
| 202 | srcs: ["c.java"], |
| 203 | } |
| 204 | `) |
| 205 | |
Steven Moreland | 0029898 | 2020-11-17 21:44:36 +0000 | [diff] [blame] | 206 | testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", ` |
Jeongik Cha | e403e9e | 2019-12-07 00:16:24 +0900 | [diff] [blame] | 207 | java_library { |
| 208 | name: "foo", |
| 209 | srcs: ["a.java"], |
| 210 | libs: ["bar"], |
| 211 | sdk_version: "current", |
| 212 | static_libs: ["baz"], |
| 213 | } |
| 214 | |
| 215 | java_library { |
| 216 | name: "bar", |
| 217 | sdk_version: "current", |
| 218 | srcs: ["b.java"], |
| 219 | } |
| 220 | |
| 221 | java_library { |
| 222 | name: "baz", |
| 223 | sdk_version: "system_current", |
| 224 | srcs: ["c.java"], |
| 225 | } |
| 226 | `) |
| 227 | |
| 228 | testJava(t, ` |
| 229 | java_library { |
| 230 | name: "foo", |
| 231 | srcs: ["a.java"], |
| 232 | libs: ["bar"], |
| 233 | sdk_version: "system_current", |
| 234 | static_libs: ["baz"], |
| 235 | } |
| 236 | |
| 237 | java_library { |
| 238 | name: "bar", |
| 239 | sdk_version: "current", |
| 240 | srcs: ["b.java"], |
| 241 | } |
| 242 | |
| 243 | java_library { |
| 244 | name: "baz", |
| 245 | sdk_version: "system_current", |
| 246 | srcs: ["c.java"], |
| 247 | } |
| 248 | `) |
| 249 | |
Steven Moreland | 0029898 | 2020-11-17 21:44:36 +0000 | [diff] [blame] | 250 | testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", ` |
Jeongik Cha | e403e9e | 2019-12-07 00:16:24 +0900 | [diff] [blame] | 251 | java_library { |
| 252 | name: "foo", |
| 253 | srcs: ["a.java"], |
| 254 | libs: ["bar"], |
| 255 | sdk_version: "system_current", |
| 256 | static_libs: ["baz"], |
| 257 | } |
| 258 | |
| 259 | java_library { |
| 260 | name: "bar", |
| 261 | sdk_version: "current", |
| 262 | srcs: ["b.java"], |
| 263 | } |
| 264 | |
| 265 | java_library { |
| 266 | name: "baz", |
| 267 | srcs: ["c.java"], |
| 268 | } |
| 269 | `) |
| 270 | } |
| 271 | |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 272 | func TestSimple(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 273 | ctx, _ := testJava(t, ` |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 274 | java_library { |
| 275 | name: "foo", |
| 276 | srcs: ["a.java"], |
Colin Cross | e8dc34a | 2017-07-19 11:22:16 -0700 | [diff] [blame] | 277 | libs: ["bar"], |
| 278 | static_libs: ["baz"], |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 279 | } |
| 280 | |
| 281 | java_library { |
| 282 | name: "bar", |
| 283 | srcs: ["b.java"], |
| 284 | } |
| 285 | |
| 286 | java_library { |
| 287 | name: "baz", |
| 288 | srcs: ["c.java"], |
| 289 | } |
Colin Cross | d5934c8 | 2017-10-02 13:55:26 -0700 | [diff] [blame] | 290 | `) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 291 | |
Colin Cross | 4c428df | 2017-09-15 17:36:05 -0700 | [diff] [blame] | 292 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") |
Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 293 | combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac") |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 294 | |
| 295 | if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" { |
| 296 | t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs) |
| 297 | } |
| 298 | |
Colin Cross | 1ee2317 | 2017-10-18 14:44:18 -0700 | [diff] [blame] | 299 | baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String() |
Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 300 | barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar") |
| 301 | bazTurbine := filepath.Join(buildDir, ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar") |
Colin Cross | 0a6e007 | 2017-08-30 14:24:55 -0700 | [diff] [blame] | 302 | |
Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 303 | if !strings.Contains(javac.Args["classpath"], barTurbine) { |
| 304 | t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 305 | } |
| 306 | |
Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 307 | if !strings.Contains(javac.Args["classpath"], bazTurbine) { |
| 308 | t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], bazTurbine) |
Colin Cross | 0a6e007 | 2017-08-30 14:24:55 -0700 | [diff] [blame] | 309 | } |
| 310 | |
| 311 | if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz { |
| 312 | t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 313 | } |
| 314 | } |
| 315 | |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 316 | func TestExportedPlugins(t *testing.T) { |
| 317 | type Result struct { |
Colin Cross | c9fe10f | 2020-11-19 18:06:03 -0800 | [diff] [blame] | 318 | library string |
| 319 | processors string |
| 320 | disableTurbine bool |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 321 | } |
| 322 | var tests = []struct { |
| 323 | name string |
| 324 | extra string |
| 325 | results []Result |
| 326 | }{ |
| 327 | { |
| 328 | name: "Exported plugin is not a direct plugin", |
| 329 | extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`, |
| 330 | results: []Result{{library: "exports", processors: "-proc:none"}}, |
| 331 | }, |
| 332 | { |
| 333 | name: "Exports plugin to dependee", |
| 334 | extra: ` |
| 335 | java_library{name: "exports", exported_plugins: ["plugin"]} |
| 336 | java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]} |
| 337 | java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]} |
| 338 | `, |
| 339 | results: []Result{ |
| 340 | {library: "foo", processors: "-processor com.android.TestPlugin"}, |
| 341 | {library: "bar", processors: "-processor com.android.TestPlugin"}, |
| 342 | }, |
| 343 | }, |
| 344 | { |
| 345 | name: "Exports plugin to android_library", |
| 346 | extra: ` |
| 347 | java_library{name: "exports", exported_plugins: ["plugin"]} |
| 348 | android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]} |
| 349 | android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]} |
| 350 | `, |
| 351 | results: []Result{ |
| 352 | {library: "foo", processors: "-processor com.android.TestPlugin"}, |
| 353 | {library: "bar", processors: "-processor com.android.TestPlugin"}, |
| 354 | }, |
| 355 | }, |
| 356 | { |
| 357 | name: "Exports plugin is not propagated via transitive deps", |
| 358 | extra: ` |
| 359 | java_library{name: "exports", exported_plugins: ["plugin"]} |
| 360 | java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]} |
| 361 | java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]} |
| 362 | `, |
| 363 | results: []Result{ |
| 364 | {library: "foo", processors: "-processor com.android.TestPlugin"}, |
| 365 | {library: "bar", processors: "-proc:none"}, |
| 366 | }, |
| 367 | }, |
| 368 | { |
| 369 | name: "Exports plugin appends to plugins", |
| 370 | extra: ` |
| 371 | java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"} |
| 372 | java_library{name: "exports", exported_plugins: ["plugin"]} |
| 373 | java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]} |
| 374 | `, |
| 375 | results: []Result{ |
| 376 | {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"}, |
| 377 | }, |
| 378 | }, |
Colin Cross | c9fe10f | 2020-11-19 18:06:03 -0800 | [diff] [blame] | 379 | { |
| 380 | name: "Exports plugin to with generates_api to dependee", |
| 381 | extra: ` |
| 382 | java_library{name: "exports", exported_plugins: ["plugin_generates_api"]} |
| 383 | java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]} |
| 384 | java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]} |
| 385 | `, |
| 386 | results: []Result{ |
| 387 | {library: "foo", processors: "-processor com.android.TestPlugin", disableTurbine: true}, |
| 388 | {library: "bar", processors: "-processor com.android.TestPlugin", disableTurbine: true}, |
| 389 | }, |
| 390 | }, |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 391 | } |
| 392 | |
| 393 | for _, test := range tests { |
| 394 | t.Run(test.name, func(t *testing.T) { |
| 395 | ctx, _ := testJava(t, ` |
| 396 | java_plugin { |
| 397 | name: "plugin", |
| 398 | processor_class: "com.android.TestPlugin", |
| 399 | } |
Colin Cross | c9fe10f | 2020-11-19 18:06:03 -0800 | [diff] [blame] | 400 | java_plugin { |
| 401 | name: "plugin_generates_api", |
| 402 | generates_api: true, |
| 403 | processor_class: "com.android.TestPlugin", |
| 404 | } |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 405 | `+test.extra) |
| 406 | |
| 407 | for _, want := range test.results { |
| 408 | javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac") |
| 409 | if javac.Args["processor"] != want.processors { |
| 410 | t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"]) |
| 411 | } |
Colin Cross | c9fe10f | 2020-11-19 18:06:03 -0800 | [diff] [blame] | 412 | turbine := ctx.ModuleForTests(want.library, "android_common").MaybeRule("turbine") |
| 413 | disableTurbine := turbine.BuildParams.Rule == nil |
| 414 | if disableTurbine != want.disableTurbine { |
| 415 | t.Errorf("For library %v, expected disableTurbine %v, found %v", want.library, want.disableTurbine, disableTurbine) |
| 416 | } |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 417 | } |
| 418 | }) |
| 419 | } |
| 420 | } |
| 421 | |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 422 | func TestSdkVersionByPartition(t *testing.T) { |
| 423 | testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", ` |
Jeongik Cha | 6bd33c1 | 2019-06-25 16:26:18 +0900 | [diff] [blame] | 424 | java_library { |
| 425 | name: "foo", |
| 426 | srcs: ["a.java"], |
| 427 | vendor: true, |
| 428 | } |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 429 | `) |
Jeongik Cha | 6bd33c1 | 2019-06-25 16:26:18 +0900 | [diff] [blame] | 430 | |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 431 | testJava(t, ` |
Jeongik Cha | 6bd33c1 | 2019-06-25 16:26:18 +0900 | [diff] [blame] | 432 | java_library { |
| 433 | name: "bar", |
| 434 | srcs: ["b.java"], |
| 435 | } |
| 436 | `) |
| 437 | |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 438 | for _, enforce := range []bool{true, false} { |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 439 | bp := ` |
| 440 | java_library { |
| 441 | name: "foo", |
| 442 | srcs: ["a.java"], |
| 443 | product_specific: true, |
| 444 | } |
| 445 | ` |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 446 | |
| 447 | config := testConfig(nil, bp, nil) |
| 448 | config.TestProductVariables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce) |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 449 | if enforce { |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 450 | testJavaErrorWithConfig(t, "sdk_version must have a value when the module is located at vendor or product", config) |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 451 | } else { |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 452 | testJavaWithConfig(t, config) |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 453 | } |
Jeongik Cha | 6bd33c1 | 2019-06-25 16:26:18 +0900 | [diff] [blame] | 454 | } |
| 455 | } |
| 456 | |
Colin Cross | d5934c8 | 2017-10-02 13:55:26 -0700 | [diff] [blame] | 457 | func TestArchSpecific(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 458 | ctx, _ := testJava(t, ` |
Colin Cross | d5934c8 | 2017-10-02 13:55:26 -0700 | [diff] [blame] | 459 | java_library { |
| 460 | name: "foo", |
| 461 | srcs: ["a.java"], |
| 462 | target: { |
| 463 | android: { |
| 464 | srcs: ["b.java"], |
| 465 | }, |
| 466 | }, |
| 467 | } |
| 468 | `) |
| 469 | |
| 470 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") |
| 471 | if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" { |
| 472 | t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs) |
| 473 | } |
| 474 | } |
| 475 | |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 476 | func TestBinary(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 477 | ctx, _ := testJava(t, ` |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 478 | java_library_host { |
| 479 | name: "foo", |
| 480 | srcs: ["a.java"], |
| 481 | } |
| 482 | |
| 483 | java_binary_host { |
| 484 | name: "bar", |
| 485 | srcs: ["b.java"], |
| 486 | static_libs: ["foo"], |
Colin Cross | 89226d9 | 2020-10-09 19:00:54 -0700 | [diff] [blame] | 487 | jni_libs: ["libjni"], |
| 488 | } |
| 489 | |
| 490 | cc_library_shared { |
| 491 | name: "libjni", |
| 492 | host_supported: true, |
| 493 | device_supported: false, |
| 494 | stl: "none", |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 495 | } |
| 496 | `) |
| 497 | |
| 498 | buildOS := android.BuildOs.String() |
| 499 | |
| 500 | bar := ctx.ModuleForTests("bar", buildOS+"_common") |
| 501 | barJar := bar.Output("bar.jar").Output.String() |
| 502 | barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64") |
| 503 | barWrapperDeps := barWrapper.Output("bar").Implicits.Strings() |
| 504 | |
Colin Cross | 89226d9 | 2020-10-09 19:00:54 -0700 | [diff] [blame] | 505 | libjni := ctx.ModuleForTests("libjni", buildOS+"_x86_64_shared") |
| 506 | libjniSO := libjni.Rule("Cp").Output.String() |
| 507 | |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 508 | // Test that the install binary wrapper depends on the installed jar file |
Colin Cross | c179ea6 | 2020-10-09 10:54:15 -0700 | [diff] [blame] | 509 | if g, w := barWrapperDeps, barJar; !android.InList(w, g) { |
| 510 | t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g) |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 511 | } |
Colin Cross | 89226d9 | 2020-10-09 19:00:54 -0700 | [diff] [blame] | 512 | |
| 513 | // Test that the install binary wrapper depends on the installed JNI libraries |
| 514 | if g, w := barWrapperDeps, libjniSO; !android.InList(w, g) { |
| 515 | t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g) |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 516 | } |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 517 | } |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 518 | |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 519 | func TestHostBinaryNoJavaDebugInfoOverride(t *testing.T) { |
| 520 | bp := ` |
| 521 | java_library { |
| 522 | name: "target_library", |
| 523 | srcs: ["a.java"], |
| 524 | } |
| 525 | |
| 526 | java_binary_host { |
| 527 | name: "host_binary", |
| 528 | srcs: ["b.java"], |
| 529 | } |
| 530 | ` |
| 531 | config := testConfig(nil, bp, nil) |
| 532 | config.TestProductVariables.MinimizeJavaDebugInfo = proptools.BoolPtr(true) |
| 533 | |
| 534 | ctx, _ := testJavaWithConfig(t, config) |
| 535 | |
Liz Kammer | 7941b30 | 2020-07-28 13:27:34 -0700 | [diff] [blame] | 536 | // first, check that the -g flag is added to target modules |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 537 | targetLibrary := ctx.ModuleForTests("target_library", "android_common") |
| 538 | targetJavaFlags := targetLibrary.Module().VariablesForTests()["javacFlags"] |
| 539 | if !strings.Contains(targetJavaFlags, "-g:source,lines") { |
| 540 | t.Errorf("target library javac flags %v should contain "+ |
| 541 | "-g:source,lines override with MinimizeJavaDebugInfo", targetJavaFlags) |
| 542 | } |
| 543 | |
| 544 | // check that -g is not overridden for host modules |
| 545 | buildOS := android.BuildOs.String() |
| 546 | hostBinary := ctx.ModuleForTests("host_binary", buildOS+"_common") |
| 547 | hostJavaFlags := hostBinary.Module().VariablesForTests()["javacFlags"] |
| 548 | if strings.Contains(hostJavaFlags, "-g:source,lines") { |
| 549 | t.Errorf("java_binary_host javac flags %v should not have "+ |
| 550 | "-g:source,lines override with MinimizeJavaDebugInfo", hostJavaFlags) |
| 551 | } |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 552 | } |
| 553 | |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 554 | func TestPrebuilts(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 555 | ctx, _ := testJava(t, ` |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 556 | java_library { |
| 557 | name: "foo", |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 558 | srcs: ["a.java", ":stubs-source"], |
Paul Duffin | fcfd791 | 2020-01-31 17:54:30 +0000 | [diff] [blame] | 559 | libs: ["bar", "sdklib"], |
Colin Cross | e8dc34a | 2017-07-19 11:22:16 -0700 | [diff] [blame] | 560 | static_libs: ["baz"], |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 561 | } |
| 562 | |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 563 | java_import { |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 564 | name: "bar", |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 565 | jars: ["a.jar"], |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 566 | } |
| 567 | |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 568 | java_import { |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 569 | name: "baz", |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 570 | jars: ["b.jar"], |
Liz Kammer | d6c31d2 | 2020-08-05 15:40:41 -0700 | [diff] [blame] | 571 | sdk_version: "current", |
| 572 | compile_dex: true, |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 573 | } |
Colin Cross | 42be761 | 2019-02-21 18:12:14 -0800 | [diff] [blame] | 574 | |
| 575 | dex_import { |
| 576 | name: "qux", |
| 577 | jars: ["b.jar"], |
| 578 | } |
Colin Cross | 79c7c26 | 2019-04-17 11:11:46 -0700 | [diff] [blame] | 579 | |
| 580 | java_sdk_library_import { |
Paul Duffin | 56d4490 | 2020-01-31 13:36:25 +0000 | [diff] [blame] | 581 | name: "sdklib", |
| 582 | public: { |
| 583 | jars: ["c.jar"], |
| 584 | }, |
| 585 | } |
| 586 | |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 587 | prebuilt_stubs_sources { |
| 588 | name: "stubs-source", |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 589 | srcs: ["stubs/sources"], |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 590 | } |
Paul Duffin | 1b82e6a | 2019-12-03 18:06:47 +0000 | [diff] [blame] | 591 | |
| 592 | java_test_import { |
| 593 | name: "test", |
| 594 | jars: ["a.jar"], |
| 595 | test_suites: ["cts"], |
| 596 | test_config: "AndroidTest.xml", |
| 597 | } |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 598 | `) |
| 599 | |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 600 | fooModule := ctx.ModuleForTests("foo", "android_common") |
| 601 | javac := fooModule.Rule("javac") |
Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 602 | combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac") |
Liz Kammer | d6c31d2 | 2020-08-05 15:40:41 -0700 | [diff] [blame] | 603 | barModule := ctx.ModuleForTests("bar", "android_common") |
| 604 | barJar := barModule.Rule("combineJar").Output |
| 605 | bazModule := ctx.ModuleForTests("baz", "android_common") |
| 606 | bazJar := bazModule.Rule("combineJar").Output |
Colin Cross | 79c7c26 | 2019-04-17 11:11:46 -0700 | [diff] [blame] | 607 | sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 608 | |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 609 | fooLibrary := fooModule.Module().(*Library) |
| 610 | assertDeepEquals(t, "foo java sources incorrect", |
| 611 | []string{"a.java"}, fooLibrary.compiledJavaSrcs.Strings()) |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 612 | |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 613 | assertDeepEquals(t, "foo java source jars incorrect", |
| 614 | []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"}, |
| 615 | android.NormalizePathsForTesting(fooLibrary.compiledSrcJars)) |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 616 | |
Colin Cross | 37f6d79 | 2018-07-12 12:28:41 -0700 | [diff] [blame] | 617 | if !strings.Contains(javac.Args["classpath"], barJar.String()) { |
| 618 | t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String()) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 619 | } |
| 620 | |
Liz Kammer | d6c31d2 | 2020-08-05 15:40:41 -0700 | [diff] [blame] | 621 | barDexJar := barModule.Module().(*Import).DexJarBuildPath() |
| 622 | if barDexJar != nil { |
| 623 | t.Errorf("bar dex jar build path expected to be nil, got %q", barDexJar) |
| 624 | } |
| 625 | |
Colin Cross | 79c7c26 | 2019-04-17 11:11:46 -0700 | [diff] [blame] | 626 | if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) { |
| 627 | t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String()) |
| 628 | } |
| 629 | |
Colin Cross | 37f6d79 | 2018-07-12 12:28:41 -0700 | [diff] [blame] | 630 | if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() { |
| 631 | t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String()) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 632 | } |
Colin Cross | 42be761 | 2019-02-21 18:12:14 -0800 | [diff] [blame] | 633 | |
Liz Kammer | d6c31d2 | 2020-08-05 15:40:41 -0700 | [diff] [blame] | 634 | bazDexJar := bazModule.Module().(*Import).DexJarBuildPath().String() |
| 635 | expectedDexJar := buildDir + "/.intermediates/baz/android_common/dex/baz.jar" |
| 636 | if bazDexJar != expectedDexJar { |
| 637 | t.Errorf("baz dex jar build path expected %q, got %q", expectedDexJar, bazDexJar) |
| 638 | } |
| 639 | |
Colin Cross | 42be761 | 2019-02-21 18:12:14 -0800 | [diff] [blame] | 640 | ctx.ModuleForTests("qux", "android_common").Rule("Cp") |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 641 | } |
| 642 | |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 643 | func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) { |
| 644 | if !reflect.DeepEqual(expected, actual) { |
| 645 | t.Errorf("%s: expected %q, found %q", message, expected, actual) |
| 646 | } |
| 647 | } |
| 648 | |
Paul Duffin | 1a39332 | 2020-11-18 16:36:47 +0000 | [diff] [blame] | 649 | func TestPrebuiltStubsSources(t *testing.T) { |
| 650 | test := func(t *testing.T, sourcesPath string, expectedInputs []string) { |
| 651 | ctx, _ := testJavaWithFS(t, fmt.Sprintf(` |
| 652 | prebuilt_stubs_sources { |
| 653 | name: "stubs-source", |
| 654 | srcs: ["%s"], |
| 655 | }`, sourcesPath), map[string][]byte{ |
| 656 | "stubs/sources/pkg/A.java": nil, |
| 657 | "stubs/sources/pkg/B.java": nil, |
| 658 | }) |
| 659 | |
| 660 | zipSrc := ctx.ModuleForTests("stubs-source", "android_common").Rule("zip_src") |
| 661 | if expected, actual := expectedInputs, zipSrc.Inputs.Strings(); !reflect.DeepEqual(expected, actual) { |
| 662 | t.Errorf("mismatch of inputs to soong_zip: expected %q, actual %q", expected, actual) |
| 663 | } |
| 664 | } |
| 665 | |
| 666 | t.Run("empty/missing directory", func(t *testing.T) { |
| 667 | test(t, "empty-directory", []string{}) |
| 668 | }) |
| 669 | |
| 670 | t.Run("non-empty set of sources", func(t *testing.T) { |
| 671 | test(t, "stubs/sources", []string{ |
| 672 | "stubs/sources/pkg/A.java", |
| 673 | "stubs/sources/pkg/B.java", |
| 674 | }) |
| 675 | }) |
| 676 | } |
| 677 | |
Paul Duffin | 56d4490 | 2020-01-31 13:36:25 +0000 | [diff] [blame] | 678 | func TestJavaSdkLibraryImport(t *testing.T) { |
| 679 | ctx, _ := testJava(t, ` |
| 680 | java_library { |
| 681 | name: "foo", |
| 682 | srcs: ["a.java"], |
| 683 | libs: ["sdklib"], |
| 684 | sdk_version: "current", |
| 685 | } |
| 686 | |
| 687 | java_library { |
| 688 | name: "foo.system", |
| 689 | srcs: ["a.java"], |
| 690 | libs: ["sdklib"], |
| 691 | sdk_version: "system_current", |
| 692 | } |
| 693 | |
| 694 | java_library { |
| 695 | name: "foo.test", |
| 696 | srcs: ["a.java"], |
| 697 | libs: ["sdklib"], |
| 698 | sdk_version: "test_current", |
| 699 | } |
| 700 | |
| 701 | java_sdk_library_import { |
| 702 | name: "sdklib", |
| 703 | public: { |
| 704 | jars: ["a.jar"], |
| 705 | }, |
| 706 | system: { |
| 707 | jars: ["b.jar"], |
| 708 | }, |
| 709 | test: { |
| 710 | jars: ["c.jar"], |
Paul Duffin | 0f8faff | 2020-05-20 16:18:00 +0100 | [diff] [blame] | 711 | stub_srcs: ["c.java"], |
Paul Duffin | 56d4490 | 2020-01-31 13:36:25 +0000 | [diff] [blame] | 712 | }, |
| 713 | } |
| 714 | `) |
| 715 | |
| 716 | for _, scope := range []string{"", ".system", ".test"} { |
| 717 | fooModule := ctx.ModuleForTests("foo"+scope, "android_common") |
| 718 | javac := fooModule.Rule("javac") |
| 719 | |
| 720 | sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs"+scope, "android_common").Rule("combineJar").Output |
| 721 | if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) { |
| 722 | t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String()) |
| 723 | } |
| 724 | } |
Paul Duffin | ca8d9a5 | 2020-06-26 22:20:25 +0100 | [diff] [blame] | 725 | |
Paul Duffin | cee7e66 | 2020-07-09 17:32:57 +0100 | [diff] [blame] | 726 | CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{ |
Paul Duffin | ca8d9a5 | 2020-06-26 22:20:25 +0100 | [diff] [blame] | 727 | `prebuilt_sdklib.stubs`, |
| 728 | `prebuilt_sdklib.stubs.source.test`, |
| 729 | `prebuilt_sdklib.stubs.system`, |
| 730 | `prebuilt_sdklib.stubs.test`, |
| 731 | }) |
| 732 | } |
| 733 | |
| 734 | func TestJavaSdkLibraryImport_WithSource(t *testing.T) { |
| 735 | ctx, _ := testJava(t, ` |
| 736 | java_sdk_library { |
| 737 | name: "sdklib", |
| 738 | srcs: ["a.java"], |
| 739 | sdk_version: "none", |
| 740 | system_modules: "none", |
| 741 | public: { |
| 742 | enabled: true, |
| 743 | }, |
| 744 | } |
| 745 | |
| 746 | java_sdk_library_import { |
| 747 | name: "sdklib", |
| 748 | public: { |
| 749 | jars: ["a.jar"], |
| 750 | }, |
| 751 | } |
| 752 | `) |
| 753 | |
Paul Duffin | cee7e66 | 2020-07-09 17:32:57 +0100 | [diff] [blame] | 754 | CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{ |
Paul Duffin | ca8d9a5 | 2020-06-26 22:20:25 +0100 | [diff] [blame] | 755 | `dex2oatd`, |
| 756 | `prebuilt_sdklib`, |
| 757 | `sdklib.impl`, |
| 758 | `sdklib.stubs`, |
| 759 | `sdklib.stubs.source`, |
| 760 | `sdklib.xml`, |
| 761 | }) |
| 762 | |
Paul Duffin | cee7e66 | 2020-07-09 17:32:57 +0100 | [diff] [blame] | 763 | CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{ |
Paul Duffin | 44f1d84 | 2020-06-26 20:17:02 +0100 | [diff] [blame] | 764 | `prebuilt_sdklib.stubs`, |
Paul Duffin | ca8d9a5 | 2020-06-26 22:20:25 +0100 | [diff] [blame] | 765 | `sdklib.impl`, |
| 766 | // This should be prebuilt_sdklib.stubs but is set to sdklib.stubs because the |
| 767 | // dependency is added after prebuilts may have been renamed and so has to use |
| 768 | // the renamed name. |
Paul Duffin | ca8d9a5 | 2020-06-26 22:20:25 +0100 | [diff] [blame] | 769 | `sdklib.xml`, |
| 770 | }) |
| 771 | } |
| 772 | |
| 773 | func TestJavaSdkLibraryImport_Preferred(t *testing.T) { |
| 774 | ctx, _ := testJava(t, ` |
| 775 | java_sdk_library { |
| 776 | name: "sdklib", |
| 777 | srcs: ["a.java"], |
| 778 | sdk_version: "none", |
| 779 | system_modules: "none", |
| 780 | public: { |
| 781 | enabled: true, |
| 782 | }, |
| 783 | } |
| 784 | |
| 785 | java_sdk_library_import { |
| 786 | name: "sdklib", |
| 787 | prefer: true, |
| 788 | public: { |
| 789 | jars: ["a.jar"], |
| 790 | }, |
| 791 | } |
| 792 | `) |
| 793 | |
Paul Duffin | cee7e66 | 2020-07-09 17:32:57 +0100 | [diff] [blame] | 794 | CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{ |
Paul Duffin | ca8d9a5 | 2020-06-26 22:20:25 +0100 | [diff] [blame] | 795 | `dex2oatd`, |
| 796 | `prebuilt_sdklib`, |
Paul Duffin | ca8d9a5 | 2020-06-26 22:20:25 +0100 | [diff] [blame] | 797 | `sdklib.impl`, |
Paul Duffin | 80342d7 | 2020-06-26 22:08:43 +0100 | [diff] [blame] | 798 | `sdklib.stubs`, |
Paul Duffin | ca8d9a5 | 2020-06-26 22:20:25 +0100 | [diff] [blame] | 799 | `sdklib.stubs.source`, |
| 800 | `sdklib.xml`, |
| 801 | }) |
| 802 | |
Paul Duffin | cee7e66 | 2020-07-09 17:32:57 +0100 | [diff] [blame] | 803 | CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{ |
Paul Duffin | ca8d9a5 | 2020-06-26 22:20:25 +0100 | [diff] [blame] | 804 | `prebuilt_sdklib.stubs`, |
| 805 | `sdklib.impl`, |
| 806 | `sdklib.xml`, |
| 807 | }) |
Paul Duffin | 56d4490 | 2020-01-31 13:36:25 +0000 | [diff] [blame] | 808 | } |
| 809 | |
JaeMan Park | ff71556 | 2020-10-19 17:25:58 +0900 | [diff] [blame] | 810 | func TestJavaSdkLibraryEnforce(t *testing.T) { |
| 811 | partitionToBpOption := func(partition string) string { |
| 812 | switch partition { |
| 813 | case "system": |
| 814 | return "" |
| 815 | case "vendor": |
| 816 | return "soc_specific: true," |
| 817 | case "product": |
| 818 | return "product_specific: true," |
| 819 | default: |
| 820 | panic("Invalid partition group name: " + partition) |
| 821 | } |
| 822 | } |
| 823 | |
| 824 | type testConfigInfo struct { |
| 825 | libraryType string |
| 826 | fromPartition string |
| 827 | toPartition string |
| 828 | enforceVendorInterface bool |
| 829 | enforceProductInterface bool |
| 830 | enforceJavaSdkLibraryCheck bool |
| 831 | allowList []string |
| 832 | } |
| 833 | |
| 834 | createTestConfig := func(info testConfigInfo) android.Config { |
| 835 | bpFileTemplate := ` |
| 836 | java_library { |
| 837 | name: "foo", |
| 838 | srcs: ["foo.java"], |
| 839 | libs: ["bar"], |
| 840 | sdk_version: "current", |
| 841 | %s |
| 842 | } |
| 843 | |
| 844 | %s { |
| 845 | name: "bar", |
| 846 | srcs: ["bar.java"], |
| 847 | sdk_version: "current", |
| 848 | %s |
| 849 | } |
| 850 | ` |
| 851 | |
| 852 | bpFile := fmt.Sprintf(bpFileTemplate, |
| 853 | partitionToBpOption(info.fromPartition), |
| 854 | info.libraryType, |
| 855 | partitionToBpOption(info.toPartition)) |
| 856 | |
| 857 | config := testConfig(nil, bpFile, nil) |
| 858 | configVariables := config.TestProductVariables |
| 859 | |
| 860 | configVariables.EnforceProductPartitionInterface = proptools.BoolPtr(info.enforceProductInterface) |
| 861 | if info.enforceVendorInterface { |
| 862 | configVariables.DeviceVndkVersion = proptools.StringPtr("current") |
| 863 | } |
| 864 | configVariables.EnforceInterPartitionJavaSdkLibrary = proptools.BoolPtr(info.enforceJavaSdkLibraryCheck) |
| 865 | configVariables.InterPartitionJavaLibraryAllowList = info.allowList |
| 866 | |
| 867 | return config |
| 868 | } |
| 869 | |
JaeMan Park | ff71556 | 2020-10-19 17:25:58 +0900 | [diff] [blame] | 870 | errorMessage := "is not allowed across the partitions" |
| 871 | |
JaeMan Park | 90e7535 | 2021-01-14 11:56:56 +0900 | [diff] [blame^] | 872 | testJavaWithConfig(t, createTestConfig(testConfigInfo{ |
| 873 | libraryType: "java_library", |
| 874 | fromPartition: "product", |
| 875 | toPartition: "system", |
| 876 | enforceVendorInterface: true, |
| 877 | enforceProductInterface: true, |
| 878 | enforceJavaSdkLibraryCheck: false, |
| 879 | })) |
JaeMan Park | ff71556 | 2020-10-19 17:25:58 +0900 | [diff] [blame] | 880 | |
JaeMan Park | 90e7535 | 2021-01-14 11:56:56 +0900 | [diff] [blame^] | 881 | testJavaWithConfig(t, createTestConfig(testConfigInfo{ |
| 882 | libraryType: "java_library", |
| 883 | fromPartition: "product", |
| 884 | toPartition: "system", |
| 885 | enforceVendorInterface: true, |
| 886 | enforceProductInterface: false, |
| 887 | enforceJavaSdkLibraryCheck: true, |
| 888 | })) |
JaeMan Park | ff71556 | 2020-10-19 17:25:58 +0900 | [diff] [blame] | 889 | |
JaeMan Park | 90e7535 | 2021-01-14 11:56:56 +0900 | [diff] [blame^] | 890 | testJavaErrorWithConfig(t, errorMessage, createTestConfig(testConfigInfo{ |
| 891 | libraryType: "java_library", |
| 892 | fromPartition: "product", |
| 893 | toPartition: "system", |
| 894 | enforceVendorInterface: true, |
| 895 | enforceProductInterface: true, |
| 896 | enforceJavaSdkLibraryCheck: true, |
| 897 | })) |
JaeMan Park | ff71556 | 2020-10-19 17:25:58 +0900 | [diff] [blame] | 898 | |
JaeMan Park | 90e7535 | 2021-01-14 11:56:56 +0900 | [diff] [blame^] | 899 | testJavaErrorWithConfig(t, errorMessage, createTestConfig(testConfigInfo{ |
| 900 | libraryType: "java_library", |
| 901 | fromPartition: "vendor", |
| 902 | toPartition: "system", |
| 903 | enforceVendorInterface: true, |
| 904 | enforceProductInterface: true, |
| 905 | enforceJavaSdkLibraryCheck: true, |
| 906 | })) |
JaeMan Park | ff71556 | 2020-10-19 17:25:58 +0900 | [diff] [blame] | 907 | |
| 908 | testJavaWithConfig(t, createTestConfig(testConfigInfo{ |
| 909 | libraryType: "java_library", |
| 910 | fromPartition: "vendor", |
| 911 | toPartition: "system", |
| 912 | enforceVendorInterface: true, |
| 913 | enforceProductInterface: true, |
| 914 | enforceJavaSdkLibraryCheck: true, |
| 915 | allowList: []string{"bar"}, |
| 916 | })) |
| 917 | |
| 918 | testJavaErrorWithConfig(t, errorMessage, createTestConfig(testConfigInfo{ |
| 919 | libraryType: "java_library", |
| 920 | fromPartition: "vendor", |
JaeMan Park | 90e7535 | 2021-01-14 11:56:56 +0900 | [diff] [blame^] | 921 | toPartition: "product", |
| 922 | enforceVendorInterface: true, |
| 923 | enforceProductInterface: true, |
| 924 | enforceJavaSdkLibraryCheck: true, |
| 925 | })) |
| 926 | |
| 927 | testJavaWithConfig(t, createTestConfig(testConfigInfo{ |
| 928 | libraryType: "java_sdk_library", |
| 929 | fromPartition: "product", |
JaeMan Park | ff71556 | 2020-10-19 17:25:58 +0900 | [diff] [blame] | 930 | toPartition: "system", |
| 931 | enforceVendorInterface: true, |
| 932 | enforceProductInterface: true, |
| 933 | enforceJavaSdkLibraryCheck: true, |
JaeMan Park | 90e7535 | 2021-01-14 11:56:56 +0900 | [diff] [blame^] | 934 | })) |
| 935 | |
| 936 | testJavaWithConfig(t, createTestConfig(testConfigInfo{ |
| 937 | libraryType: "java_sdk_library", |
| 938 | fromPartition: "vendor", |
| 939 | toPartition: "system", |
| 940 | enforceVendorInterface: true, |
| 941 | enforceProductInterface: true, |
| 942 | enforceJavaSdkLibraryCheck: true, |
| 943 | })) |
| 944 | |
| 945 | testJavaWithConfig(t, createTestConfig(testConfigInfo{ |
| 946 | libraryType: "java_sdk_library", |
| 947 | fromPartition: "vendor", |
| 948 | toPartition: "product", |
| 949 | enforceVendorInterface: true, |
| 950 | enforceProductInterface: true, |
| 951 | enforceJavaSdkLibraryCheck: true, |
JaeMan Park | ff71556 | 2020-10-19 17:25:58 +0900 | [diff] [blame] | 952 | })) |
| 953 | } |
| 954 | |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 955 | func TestDefaults(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 956 | ctx, _ := testJava(t, ` |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 957 | java_defaults { |
| 958 | name: "defaults", |
| 959 | srcs: ["a.java"], |
| 960 | libs: ["bar"], |
| 961 | static_libs: ["baz"], |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 962 | optimize: {enabled: false}, |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 963 | } |
| 964 | |
| 965 | java_library { |
| 966 | name: "foo", |
| 967 | defaults: ["defaults"], |
| 968 | } |
| 969 | |
| 970 | java_library { |
| 971 | name: "bar", |
| 972 | srcs: ["b.java"], |
| 973 | } |
| 974 | |
| 975 | java_library { |
| 976 | name: "baz", |
| 977 | srcs: ["c.java"], |
| 978 | } |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 979 | |
| 980 | android_test { |
| 981 | name: "atestOptimize", |
| 982 | defaults: ["defaults"], |
| 983 | optimize: {enabled: true}, |
| 984 | } |
| 985 | |
| 986 | android_test { |
| 987 | name: "atestNoOptimize", |
| 988 | defaults: ["defaults"], |
| 989 | } |
| 990 | |
| 991 | android_test { |
| 992 | name: "atestDefault", |
| 993 | srcs: ["a.java"], |
| 994 | } |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 995 | `) |
| 996 | |
Colin Cross | 4c428df | 2017-09-15 17:36:05 -0700 | [diff] [blame] | 997 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") |
Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 998 | combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac") |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 999 | |
| 1000 | if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" { |
| 1001 | t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs) |
| 1002 | } |
| 1003 | |
Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 1004 | barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar") |
| 1005 | if !strings.Contains(javac.Args["classpath"], barTurbine) { |
| 1006 | t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine) |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 1007 | } |
| 1008 | |
Colin Cross | 1ee2317 | 2017-10-18 14:44:18 -0700 | [diff] [blame] | 1009 | baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String() |
Colin Cross | 0a6e007 | 2017-08-30 14:24:55 -0700 | [diff] [blame] | 1010 | if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz { |
| 1011 | t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz) |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 1012 | } |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 1013 | |
| 1014 | atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8") |
| 1015 | if atestOptimize.Output == nil { |
| 1016 | t.Errorf("atestOptimize should optimize APK") |
| 1017 | } |
| 1018 | |
| 1019 | atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8") |
| 1020 | if atestNoOptimize.Output == nil { |
| 1021 | t.Errorf("atestNoOptimize should not optimize APK") |
| 1022 | } |
| 1023 | |
| 1024 | atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("r8") |
| 1025 | if atestDefault.Output == nil { |
| 1026 | t.Errorf("atestDefault should optimize APK") |
| 1027 | } |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 1028 | } |
| 1029 | |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 1030 | func TestResources(t *testing.T) { |
| 1031 | var table = []struct { |
| 1032 | name string |
| 1033 | prop string |
| 1034 | extra string |
| 1035 | args string |
| 1036 | }{ |
| 1037 | { |
Colin Cross | af9c55b | 2017-10-03 14:50:08 -0700 | [diff] [blame] | 1038 | // Test that a module with java_resource_dirs includes the files |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 1039 | name: "resource dirs", |
Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 1040 | prop: `java_resource_dirs: ["java-res"]`, |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 1041 | args: "-C java-res -f java-res/a/a -f java-res/b/b", |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 1042 | }, |
| 1043 | { |
| 1044 | // Test that a module with java_resources includes the files |
| 1045 | name: "resource files", |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 1046 | prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`, |
| 1047 | args: "-C . -f java-res/a/a -f java-res/b/b", |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 1048 | }, |
| 1049 | { |
| 1050 | // Test that a module with a filegroup in java_resources includes the files with the |
| 1051 | // path prefix |
| 1052 | name: "resource filegroup", |
| 1053 | prop: `java_resources: [":foo-res"]`, |
| 1054 | extra: ` |
| 1055 | filegroup { |
| 1056 | name: "foo-res", |
Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 1057 | path: "java-res", |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 1058 | srcs: ["java-res/a/a", "java-res/b/b"], |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 1059 | }`, |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 1060 | args: "-C java-res -f java-res/a/a -f java-res/b/b", |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 1061 | }, |
| 1062 | { |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 1063 | // Test that a module with wildcards in java_resource_dirs has the correct path prefixes |
| 1064 | name: "wildcard dirs", |
| 1065 | prop: `java_resource_dirs: ["java-res/*"]`, |
| 1066 | args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b", |
| 1067 | }, |
| 1068 | { |
| 1069 | // Test that a module exclude_java_resource_dirs excludes the files |
| 1070 | name: "wildcard dirs", |
| 1071 | prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`, |
| 1072 | args: "-C java-res/a -f java-res/a/a", |
| 1073 | }, |
Colin Cross | cedd476 | 2018-09-13 11:26:19 -0700 | [diff] [blame] | 1074 | { |
| 1075 | // Test wildcards in java_resources |
| 1076 | name: "wildcard files", |
| 1077 | prop: `java_resources: ["java-res/**/*"]`, |
| 1078 | args: "-C . -f java-res/a/a -f java-res/b/b", |
| 1079 | }, |
| 1080 | { |
| 1081 | // Test exclude_java_resources with java_resources |
| 1082 | name: "wildcard files with exclude", |
| 1083 | prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`, |
| 1084 | args: "-C . -f java-res/a/a", |
| 1085 | }, |
| 1086 | { |
| 1087 | // Test exclude_java_resources with java_resource_dirs |
| 1088 | name: "resource dirs with exclude files", |
| 1089 | prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`, |
| 1090 | args: "-C java-res -f java-res/a/a", |
| 1091 | }, |
| 1092 | { |
| 1093 | // Test exclude_java_resource_dirs with java_resource_dirs |
| 1094 | name: "resource dirs with exclude files", |
| 1095 | prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`, |
| 1096 | args: "-C java-res -f java-res/a/a -f java-res/b/b", |
| 1097 | }, |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 1098 | } |
| 1099 | |
| 1100 | for _, test := range table { |
| 1101 | t.Run(test.name, func(t *testing.T) { |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 1102 | ctx, _ := testJavaWithFS(t, ` |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 1103 | java_library { |
| 1104 | name: "foo", |
| 1105 | srcs: [ |
| 1106 | "a.java", |
| 1107 | "b.java", |
| 1108 | "c.java", |
| 1109 | ], |
| 1110 | `+test.prop+`, |
| 1111 | } |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 1112 | `+test.extra, |
| 1113 | map[string][]byte{ |
| 1114 | "java-res/a/a": nil, |
| 1115 | "java-res/b/b": nil, |
| 1116 | "java-res2/a": nil, |
| 1117 | }, |
| 1118 | ) |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 1119 | |
Colin Cross | 331a121 | 2018-08-15 20:40:52 -0700 | [diff] [blame] | 1120 | foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar") |
Colin Cross | 1ee2317 | 2017-10-18 14:44:18 -0700 | [diff] [blame] | 1121 | fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar") |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 1122 | |
| 1123 | if !inList(fooRes.Output.String(), foo.Inputs.Strings()) { |
| 1124 | t.Errorf("foo combined jars %v does not contain %q", |
| 1125 | foo.Inputs.Strings(), fooRes.Output.String()) |
| 1126 | } |
| 1127 | |
Colin Cross | af9c55b | 2017-10-03 14:50:08 -0700 | [diff] [blame] | 1128 | if fooRes.Args["jarArgs"] != test.args { |
| 1129 | t.Errorf("foo resource jar args %q is not %q", |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 1130 | fooRes.Args["jarArgs"], test.args) |
| 1131 | } |
| 1132 | }) |
| 1133 | } |
| 1134 | } |
| 1135 | |
Colin Cross | 0c4ce21 | 2019-05-03 15:28:19 -0700 | [diff] [blame] | 1136 | func TestIncludeSrcs(t *testing.T) { |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 1137 | ctx, _ := testJavaWithFS(t, ` |
Colin Cross | 0c4ce21 | 2019-05-03 15:28:19 -0700 | [diff] [blame] | 1138 | java_library { |
| 1139 | name: "foo", |
| 1140 | srcs: [ |
| 1141 | "a.java", |
| 1142 | "b.java", |
| 1143 | "c.java", |
| 1144 | ], |
| 1145 | include_srcs: true, |
| 1146 | } |
| 1147 | |
| 1148 | java_library { |
| 1149 | name: "bar", |
| 1150 | srcs: [ |
| 1151 | "a.java", |
| 1152 | "b.java", |
| 1153 | "c.java", |
| 1154 | ], |
| 1155 | java_resource_dirs: ["java-res"], |
| 1156 | include_srcs: true, |
| 1157 | } |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 1158 | `, map[string][]byte{ |
| 1159 | "java-res/a/a": nil, |
| 1160 | "java-res/b/b": nil, |
| 1161 | "java-res2/a": nil, |
| 1162 | }) |
Colin Cross | 0c4ce21 | 2019-05-03 15:28:19 -0700 | [diff] [blame] | 1163 | |
| 1164 | // Test a library with include_srcs: true |
| 1165 | foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar") |
| 1166 | fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar") |
| 1167 | |
| 1168 | if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) { |
| 1169 | t.Errorf("foo combined jars %v does not contain %q", w, g) |
| 1170 | } |
| 1171 | |
| 1172 | if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w { |
| 1173 | t.Errorf("foo source jar args %q is not %q", w, g) |
| 1174 | } |
| 1175 | |
| 1176 | // Test a library with include_srcs: true and resources |
| 1177 | bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar") |
| 1178 | barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar") |
| 1179 | barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar") |
| 1180 | barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar") |
| 1181 | |
| 1182 | if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) { |
| 1183 | t.Errorf("bar combined resource jars %v does not contain %q", w, g) |
| 1184 | } |
| 1185 | |
| 1186 | if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) { |
| 1187 | t.Errorf("bar combined resource jars %v does not contain %q", w, g) |
| 1188 | } |
| 1189 | |
| 1190 | if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) { |
| 1191 | t.Errorf("bar combined jars %v does not contain %q", w, g) |
| 1192 | } |
| 1193 | |
| 1194 | if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w { |
| 1195 | t.Errorf("bar source jar args %q is not %q", w, g) |
| 1196 | } |
| 1197 | |
| 1198 | if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w { |
| 1199 | t.Errorf("bar resource jar args %q is not %q", w, g) |
| 1200 | } |
| 1201 | } |
| 1202 | |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 1203 | func TestGeneratedSources(t *testing.T) { |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 1204 | ctx, _ := testJavaWithFS(t, ` |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 1205 | java_library { |
| 1206 | name: "foo", |
| 1207 | srcs: [ |
| 1208 | "a*.java", |
| 1209 | ":gen", |
| 1210 | "b*.java", |
| 1211 | ], |
| 1212 | } |
| 1213 | |
| 1214 | genrule { |
| 1215 | name: "gen", |
Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 1216 | tool_files: ["java-res/a"], |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 1217 | out: ["gen.java"], |
| 1218 | } |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 1219 | `, map[string][]byte{ |
| 1220 | "a.java": nil, |
| 1221 | "b.java": nil, |
| 1222 | }) |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 1223 | |
| 1224 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") |
| 1225 | genrule := ctx.ModuleForTests("gen", "").Rule("generator") |
| 1226 | |
Colin Cross | 15e86d9 | 2017-10-20 15:07:08 -0700 | [diff] [blame] | 1227 | if filepath.Base(genrule.Output.String()) != "gen.java" { |
| 1228 | t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String()) |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 1229 | } |
| 1230 | |
| 1231 | if len(javac.Inputs) != 3 || |
| 1232 | javac.Inputs[0].String() != "a.java" || |
Colin Cross | 15e86d9 | 2017-10-20 15:07:08 -0700 | [diff] [blame] | 1233 | javac.Inputs[1].String() != genrule.Output.String() || |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 1234 | javac.Inputs[2].String() != "b.java" { |
| 1235 | t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs) |
| 1236 | } |
| 1237 | } |
| 1238 | |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1239 | func TestTurbine(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 1240 | ctx, _ := testJava(t, ` |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1241 | java_library { |
| 1242 | name: "foo", |
| 1243 | srcs: ["a.java"], |
Jiyong Park | 2d49294 | 2018-03-05 17:44:10 +0900 | [diff] [blame] | 1244 | sdk_version: "14", |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1245 | } |
| 1246 | |
| 1247 | java_library { |
| 1248 | name: "bar", |
Colin Cross | 9bc4343 | 2017-12-15 20:20:39 -0800 | [diff] [blame] | 1249 | srcs: ["b.java"], |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1250 | static_libs: ["foo"], |
Jiyong Park | 2d49294 | 2018-03-05 17:44:10 +0900 | [diff] [blame] | 1251 | sdk_version: "14", |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1252 | } |
| 1253 | |
| 1254 | java_library { |
| 1255 | name: "baz", |
| 1256 | srcs: ["c.java"], |
| 1257 | libs: ["bar"], |
| 1258 | sdk_version: "14", |
| 1259 | } |
| 1260 | `) |
| 1261 | |
| 1262 | fooTurbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine") |
| 1263 | barTurbine := ctx.ModuleForTests("bar", "android_common").Rule("turbine") |
| 1264 | barJavac := ctx.ModuleForTests("bar", "android_common").Rule("javac") |
| 1265 | barTurbineCombined := ctx.ModuleForTests("bar", "android_common").Description("for turbine") |
| 1266 | bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac") |
| 1267 | |
| 1268 | if len(fooTurbine.Inputs) != 1 || fooTurbine.Inputs[0].String() != "a.java" { |
| 1269 | t.Errorf(`foo inputs %v != ["a.java"]`, fooTurbine.Inputs) |
| 1270 | } |
| 1271 | |
| 1272 | fooHeaderJar := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar") |
| 1273 | if !strings.Contains(barTurbine.Args["classpath"], fooHeaderJar) { |
| 1274 | t.Errorf("bar turbine classpath %v does not contain %q", barTurbine.Args["classpath"], fooHeaderJar) |
| 1275 | } |
| 1276 | if !strings.Contains(barJavac.Args["classpath"], fooHeaderJar) { |
| 1277 | t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], fooHeaderJar) |
| 1278 | } |
| 1279 | if len(barTurbineCombined.Inputs) != 2 || barTurbineCombined.Inputs[1].String() != fooHeaderJar { |
| 1280 | t.Errorf("bar turbine combineJar inputs %v does not contain %q", barTurbineCombined.Inputs, fooHeaderJar) |
| 1281 | } |
Anton Hansson | f66efeb | 2018-04-11 13:57:30 +0100 | [diff] [blame] | 1282 | if !strings.Contains(bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") { |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1283 | t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"], |
Anton Hansson | f66efeb | 2018-04-11 13:57:30 +0100 | [diff] [blame] | 1284 | "prebuilts/sdk/14/public/android.jar") |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1285 | } |
| 1286 | } |
| 1287 | |
| 1288 | func TestSharding(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 1289 | ctx, _ := testJava(t, ` |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1290 | java_library { |
| 1291 | name: "bar", |
| 1292 | srcs: ["a.java","b.java","c.java"], |
| 1293 | javac_shard_size: 1 |
| 1294 | } |
| 1295 | `) |
| 1296 | |
| 1297 | barHeaderJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar") |
| 1298 | for i := 0; i < 3; i++ { |
| 1299 | barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i)) |
| 1300 | if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) { |
| 1301 | t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar) |
| 1302 | } |
| 1303 | } |
| 1304 | } |
| 1305 | |
Nan Zhang | 581fd21 | 2018-01-10 16:06:12 -0800 | [diff] [blame] | 1306 | func TestDroiddoc(t *testing.T) { |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 1307 | ctx, _ := testJavaWithFS(t, ` |
Paul Duffin | 884363e | 2019-12-19 10:21:09 +0000 | [diff] [blame] | 1308 | droiddoc_exported_dir { |
Dan Willemsen | cc09097 | 2018-02-26 14:33:31 -0800 | [diff] [blame] | 1309 | name: "droiddoc-templates-sdk", |
| 1310 | path: ".", |
| 1311 | } |
Jiyong Park | 2907459 | 2019-07-07 16:27:47 +0900 | [diff] [blame] | 1312 | filegroup { |
| 1313 | name: "bar-doc-aidl-srcs", |
| 1314 | srcs: ["bar-doc/IBar.aidl"], |
| 1315 | path: "bar-doc", |
| 1316 | } |
Liz Kammer | e1ab250 | 2020-09-10 15:29:25 +0000 | [diff] [blame] | 1317 | droidstubs { |
| 1318 | name: "bar-stubs", |
Liz Kammer | 3a55c91 | 2020-08-14 12:14:02 -0700 | [diff] [blame] | 1319 | srcs: [ |
Steve Kim | 3666c70 | 2020-09-01 17:58:01 +0000 | [diff] [blame] | 1320 | "bar-doc/a.java", |
Liz Kammer | 3a55c91 | 2020-08-14 12:14:02 -0700 | [diff] [blame] | 1321 | ], |
Steve Kim | 3666c70 | 2020-09-01 17:58:01 +0000 | [diff] [blame] | 1322 | exclude_srcs: [ |
| 1323 | "bar-doc/b.java" |
| 1324 | ], |
Liz Kammer | e1ab250 | 2020-09-10 15:29:25 +0000 | [diff] [blame] | 1325 | api_levels_annotations_dirs: [ |
| 1326 | "droiddoc-templates-sdk", |
| 1327 | ], |
| 1328 | api_levels_annotations_enabled: true, |
| 1329 | } |
| 1330 | droiddoc { |
| 1331 | name: "bar-doc", |
| 1332 | srcs: [ |
| 1333 | ":bar-stubs", |
| 1334 | "bar-doc/IFoo.aidl", |
| 1335 | ":bar-doc-aidl-srcs", |
| 1336 | ], |
Dan Willemsen | cc09097 | 2018-02-26 14:33:31 -0800 | [diff] [blame] | 1337 | custom_template: "droiddoc-templates-sdk", |
Nan Zhang | 581fd21 | 2018-01-10 16:06:12 -0800 | [diff] [blame] | 1338 | hdf: [ |
| 1339 | "android.whichdoc offline", |
| 1340 | ], |
| 1341 | knowntags: [ |
| 1342 | "bar-doc/known_oj_tags.txt", |
| 1343 | ], |
| 1344 | proofread_file: "libcore-proofread.txt", |
| 1345 | todo_file: "libcore-docs-todo.html", |
Liz Kammer | 585cac2 | 2020-07-06 09:12:57 -0700 | [diff] [blame] | 1346 | flags: ["-offlinemode -title \"libcore\""], |
Nan Zhang | 581fd21 | 2018-01-10 16:06:12 -0800 | [diff] [blame] | 1347 | } |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 1348 | `, |
| 1349 | map[string][]byte{ |
| 1350 | "bar-doc/a.java": nil, |
| 1351 | "bar-doc/b.java": nil, |
| 1352 | }) |
Liz Kammer | e1ab250 | 2020-09-10 15:29:25 +0000 | [diff] [blame] | 1353 | barStubs := ctx.ModuleForTests("bar-stubs", "android_common") |
| 1354 | barStubsOutputs, err := barStubs.Module().(*Droidstubs).OutputFiles("") |
| 1355 | if err != nil { |
| 1356 | t.Errorf("Unexpected error %q retrieving \"bar-stubs\" output file", err) |
| 1357 | } |
| 1358 | if len(barStubsOutputs) != 1 { |
| 1359 | t.Errorf("Expected one output from \"bar-stubs\" got %s", barStubsOutputs) |
Liz Kammer | 1e2ee12 | 2020-07-30 15:07:22 -0700 | [diff] [blame] | 1360 | } |
Nan Zhang | 581fd21 | 2018-01-10 16:06:12 -0800 | [diff] [blame] | 1361 | |
Liz Kammer | e1ab250 | 2020-09-10 15:29:25 +0000 | [diff] [blame] | 1362 | barStubsOutput := barStubsOutputs[0] |
| 1363 | barDoc := ctx.ModuleForTests("bar-doc", "android_common") |
| 1364 | javaDoc := barDoc.Rule("javadoc") |
| 1365 | if g, w := javaDoc.Implicits.Strings(), barStubsOutput.String(); !inList(w, g) { |
| 1366 | t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g) |
Jiyong Park | 2907459 | 2019-07-07 16:27:47 +0900 | [diff] [blame] | 1367 | } |
| 1368 | |
Liz Kammer | e1ab250 | 2020-09-10 15:29:25 +0000 | [diff] [blame] | 1369 | expected := "-sourcepath " + buildDir + "/.intermediates/bar-doc/android_common/srcjars " |
| 1370 | if !strings.Contains(javaDoc.RuleParams.Command, expected) { |
| 1371 | t.Errorf("bar-doc command does not contain flag %q, but should\n%q", expected, javaDoc.RuleParams.Command) |
| 1372 | } |
| 1373 | |
| 1374 | aidl := barDoc.Rule("aidl") |
| 1375 | if g, w := javaDoc.Implicits.Strings(), aidl.Output.String(); !inList(w, g) { |
Colin Cross | c080617 | 2019-06-14 18:51:47 -0700 | [diff] [blame] | 1376 | t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g) |
| 1377 | } |
| 1378 | |
| 1379 | if g, w := aidl.Implicits.Strings(), []string{"bar-doc/IBar.aidl", "bar-doc/IFoo.aidl"}; !reflect.DeepEqual(w, g) { |
| 1380 | t.Errorf("aidl inputs must be %q, but was %q", w, g) |
Jiyong Park | 1e44068 | 2018-05-23 18:42:04 +0900 | [diff] [blame] | 1381 | } |
Nan Zhang | 581fd21 | 2018-01-10 16:06:12 -0800 | [diff] [blame] | 1382 | } |
| 1383 | |
Liz Kammer | 585cac2 | 2020-07-06 09:12:57 -0700 | [diff] [blame] | 1384 | func TestDroiddocArgsAndFlagsCausesError(t *testing.T) { |
| 1385 | testJavaError(t, "flags is set. Cannot set args", ` |
| 1386 | droiddoc_exported_dir { |
| 1387 | name: "droiddoc-templates-sdk", |
| 1388 | path: ".", |
| 1389 | } |
| 1390 | filegroup { |
| 1391 | name: "bar-doc-aidl-srcs", |
| 1392 | srcs: ["bar-doc/IBar.aidl"], |
| 1393 | path: "bar-doc", |
| 1394 | } |
Liz Kammer | e1ab250 | 2020-09-10 15:29:25 +0000 | [diff] [blame] | 1395 | droidstubs { |
| 1396 | name: "bar-stubs", |
Liz Kammer | 3a55c91 | 2020-08-14 12:14:02 -0700 | [diff] [blame] | 1397 | srcs: [ |
Steve Kim | 3666c70 | 2020-09-01 17:58:01 +0000 | [diff] [blame] | 1398 | "bar-doc/a.java", |
Liz Kammer | 3a55c91 | 2020-08-14 12:14:02 -0700 | [diff] [blame] | 1399 | ], |
Steve Kim | 3666c70 | 2020-09-01 17:58:01 +0000 | [diff] [blame] | 1400 | exclude_srcs: [ |
| 1401 | "bar-doc/b.java" |
| 1402 | ], |
Liz Kammer | e1ab250 | 2020-09-10 15:29:25 +0000 | [diff] [blame] | 1403 | api_levels_annotations_dirs: [ |
| 1404 | "droiddoc-templates-sdk", |
| 1405 | ], |
| 1406 | api_levels_annotations_enabled: true, |
| 1407 | } |
| 1408 | droiddoc { |
| 1409 | name: "bar-doc", |
| 1410 | srcs: [ |
| 1411 | ":bar-stubs", |
| 1412 | "bar-doc/IFoo.aidl", |
| 1413 | ":bar-doc-aidl-srcs", |
| 1414 | ], |
Liz Kammer | 585cac2 | 2020-07-06 09:12:57 -0700 | [diff] [blame] | 1415 | custom_template: "droiddoc-templates-sdk", |
| 1416 | hdf: [ |
| 1417 | "android.whichdoc offline", |
| 1418 | ], |
| 1419 | knowntags: [ |
| 1420 | "bar-doc/known_oj_tags.txt", |
| 1421 | ], |
| 1422 | proofread_file: "libcore-proofread.txt", |
| 1423 | todo_file: "libcore-docs-todo.html", |
| 1424 | flags: ["-offlinemode -title \"libcore\""], |
| 1425 | args: "-offlinemode -title \"libcore\"", |
| 1426 | } |
| 1427 | `) |
| 1428 | } |
| 1429 | |
Liz Kammer | 3d894b7 | 2020-08-04 09:55:13 -0700 | [diff] [blame] | 1430 | func TestDroidstubs(t *testing.T) { |
| 1431 | ctx, _ := testJavaWithFS(t, ` |
| 1432 | droiddoc_exported_dir { |
Anton Hansson | 52ac73d | 2020-10-26 09:57:40 +0000 | [diff] [blame] | 1433 | name: "droiddoc-templates-sdk", |
| 1434 | path: ".", |
Liz Kammer | 3d894b7 | 2020-08-04 09:55:13 -0700 | [diff] [blame] | 1435 | } |
| 1436 | |
| 1437 | droidstubs { |
Anton Hansson | 52ac73d | 2020-10-26 09:57:40 +0000 | [diff] [blame] | 1438 | name: "bar-stubs", |
| 1439 | srcs: ["bar-doc/a.java"], |
| 1440 | api_levels_annotations_dirs: ["droiddoc-templates-sdk"], |
| 1441 | api_levels_annotations_enabled: true, |
Liz Kammer | 3d894b7 | 2020-08-04 09:55:13 -0700 | [diff] [blame] | 1442 | } |
| 1443 | |
| 1444 | droidstubs { |
Anton Hansson | 52ac73d | 2020-10-26 09:57:40 +0000 | [diff] [blame] | 1445 | name: "bar-stubs-other", |
| 1446 | srcs: ["bar-doc/a.java"], |
| 1447 | high_mem: true, |
| 1448 | api_levels_annotations_dirs: ["droiddoc-templates-sdk"], |
| 1449 | api_levels_annotations_enabled: true, |
| 1450 | api_levels_jar_filename: "android.other.jar", |
Liz Kammer | 3d894b7 | 2020-08-04 09:55:13 -0700 | [diff] [blame] | 1451 | } |
| 1452 | `, |
| 1453 | map[string][]byte{ |
| 1454 | "bar-doc/a.java": nil, |
| 1455 | }) |
| 1456 | testcases := []struct { |
| 1457 | moduleName string |
| 1458 | expectedJarFilename string |
Anton Hansson | 52ac73d | 2020-10-26 09:57:40 +0000 | [diff] [blame] | 1459 | high_mem bool |
Liz Kammer | 3d894b7 | 2020-08-04 09:55:13 -0700 | [diff] [blame] | 1460 | }{ |
| 1461 | { |
| 1462 | moduleName: "bar-stubs", |
| 1463 | expectedJarFilename: "android.jar", |
Anton Hansson | 52ac73d | 2020-10-26 09:57:40 +0000 | [diff] [blame] | 1464 | high_mem: false, |
Liz Kammer | 3d894b7 | 2020-08-04 09:55:13 -0700 | [diff] [blame] | 1465 | }, |
| 1466 | { |
| 1467 | moduleName: "bar-stubs-other", |
| 1468 | expectedJarFilename: "android.other.jar", |
Anton Hansson | 52ac73d | 2020-10-26 09:57:40 +0000 | [diff] [blame] | 1469 | high_mem: true, |
Liz Kammer | 3d894b7 | 2020-08-04 09:55:13 -0700 | [diff] [blame] | 1470 | }, |
| 1471 | } |
| 1472 | for _, c := range testcases { |
| 1473 | m := ctx.ModuleForTests(c.moduleName, "android_common") |
| 1474 | metalava := m.Rule("metalava") |
Anton Hansson | 52ac73d | 2020-10-26 09:57:40 +0000 | [diff] [blame] | 1475 | rp := metalava.RuleParams |
Liz Kammer | 3d894b7 | 2020-08-04 09:55:13 -0700 | [diff] [blame] | 1476 | expected := "--android-jar-pattern ./%/public/" + c.expectedJarFilename |
Anton Hansson | 52ac73d | 2020-10-26 09:57:40 +0000 | [diff] [blame] | 1477 | if actual := rp.Command; !strings.Contains(actual, expected) { |
Liz Kammer | 3d894b7 | 2020-08-04 09:55:13 -0700 | [diff] [blame] | 1478 | t.Errorf("For %q, expected metalava argument %q, but was not found %q", c.moduleName, expected, actual) |
| 1479 | } |
Anton Hansson | 52ac73d | 2020-10-26 09:57:40 +0000 | [diff] [blame] | 1480 | |
| 1481 | if actual := rp.Pool != nil && strings.Contains(rp.Pool.String(), "highmem"); actual != c.high_mem { |
| 1482 | t.Errorf("Expected %q high_mem to be %v, was %v", c.moduleName, c.high_mem, actual) |
| 1483 | } |
Liz Kammer | 3d894b7 | 2020-08-04 09:55:13 -0700 | [diff] [blame] | 1484 | } |
| 1485 | } |
| 1486 | |
Paul Duffin | 83a2d96 | 2019-11-19 19:44:10 +0000 | [diff] [blame] | 1487 | func TestDroidstubsWithSystemModules(t *testing.T) { |
| 1488 | ctx, _ := testJava(t, ` |
| 1489 | droidstubs { |
| 1490 | name: "stubs-source-system-modules", |
| 1491 | srcs: [ |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 1492 | "bar-doc/a.java", |
Paul Duffin | 83a2d96 | 2019-11-19 19:44:10 +0000 | [diff] [blame] | 1493 | ], |
| 1494 | sdk_version: "none", |
| 1495 | system_modules: "source-system-modules", |
| 1496 | } |
| 1497 | |
| 1498 | java_library { |
| 1499 | name: "source-jar", |
| 1500 | srcs: [ |
| 1501 | "a.java", |
| 1502 | ], |
| 1503 | } |
| 1504 | |
| 1505 | java_system_modules { |
| 1506 | name: "source-system-modules", |
| 1507 | libs: ["source-jar"], |
| 1508 | } |
| 1509 | |
| 1510 | droidstubs { |
| 1511 | name: "stubs-prebuilt-system-modules", |
| 1512 | srcs: [ |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 1513 | "bar-doc/a.java", |
Paul Duffin | 83a2d96 | 2019-11-19 19:44:10 +0000 | [diff] [blame] | 1514 | ], |
| 1515 | sdk_version: "none", |
| 1516 | system_modules: "prebuilt-system-modules", |
| 1517 | } |
| 1518 | |
| 1519 | java_import { |
| 1520 | name: "prebuilt-jar", |
| 1521 | jars: ["a.jar"], |
| 1522 | } |
| 1523 | |
| 1524 | java_system_modules_import { |
| 1525 | name: "prebuilt-system-modules", |
| 1526 | libs: ["prebuilt-jar"], |
| 1527 | } |
| 1528 | `) |
| 1529 | |
| 1530 | checkSystemModulesUseByDroidstubs(t, ctx, "stubs-source-system-modules", "source-jar.jar") |
| 1531 | |
| 1532 | checkSystemModulesUseByDroidstubs(t, ctx, "stubs-prebuilt-system-modules", "prebuilt-jar.jar") |
| 1533 | } |
| 1534 | |
| 1535 | func checkSystemModulesUseByDroidstubs(t *testing.T, ctx *android.TestContext, moduleName string, systemJar string) { |
| 1536 | metalavaRule := ctx.ModuleForTests(moduleName, "android_common").Rule("metalava") |
| 1537 | var systemJars []string |
| 1538 | for _, i := range metalavaRule.Implicits { |
| 1539 | systemJars = append(systemJars, i.Base()) |
| 1540 | } |
Ramy Medhat | c7965cd | 2020-04-30 03:08:37 -0400 | [diff] [blame] | 1541 | if len(systemJars) < 1 || systemJars[0] != systemJar { |
Paul Duffin | 83a2d96 | 2019-11-19 19:44:10 +0000 | [diff] [blame] | 1542 | t.Errorf("inputs of %q must be []string{%q}, but was %#v.", moduleName, systemJar, systemJars) |
| 1543 | } |
| 1544 | } |
| 1545 | |
Colin Cross | 5425090 | 2017-12-05 09:28:08 -0800 | [diff] [blame] | 1546 | func TestJarGenrules(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 1547 | ctx, _ := testJava(t, ` |
Colin Cross | 5425090 | 2017-12-05 09:28:08 -0800 | [diff] [blame] | 1548 | java_library { |
| 1549 | name: "foo", |
| 1550 | srcs: ["a.java"], |
| 1551 | } |
| 1552 | |
| 1553 | java_genrule { |
| 1554 | name: "jargen", |
| 1555 | tool_files: ["b.java"], |
| 1556 | cmd: "$(location b.java) $(in) $(out)", |
| 1557 | out: ["jargen.jar"], |
| 1558 | srcs: [":foo"], |
| 1559 | } |
| 1560 | |
| 1561 | java_library { |
| 1562 | name: "bar", |
| 1563 | static_libs: ["jargen"], |
| 1564 | srcs: ["c.java"], |
| 1565 | } |
| 1566 | |
| 1567 | java_library { |
| 1568 | name: "baz", |
| 1569 | libs: ["jargen"], |
| 1570 | srcs: ["c.java"], |
| 1571 | } |
| 1572 | `) |
| 1573 | |
| 1574 | foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar") |
| 1575 | jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar") |
| 1576 | bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar") |
| 1577 | baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar") |
| 1578 | barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar") |
| 1579 | |
Colin Cross | 3d68051 | 2020-11-13 16:23:53 -0800 | [diff] [blame] | 1580 | if g, w := jargen.Implicits.Strings(), foo.Output.String(); !android.InList(w, g) { |
| 1581 | t.Errorf("expected jargen inputs [%q], got %q", w, g) |
Colin Cross | 5425090 | 2017-12-05 09:28:08 -0800 | [diff] [blame] | 1582 | } |
| 1583 | |
| 1584 | if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) { |
| 1585 | t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String()) |
| 1586 | } |
| 1587 | |
| 1588 | if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) { |
| 1589 | t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String()) |
| 1590 | } |
| 1591 | |
| 1592 | if len(barCombined.Inputs) != 2 || |
| 1593 | barCombined.Inputs[0].String() != bar.Output.String() || |
| 1594 | barCombined.Inputs[1].String() != jargen.Output.String() { |
| 1595 | t.Errorf("bar combined jar inputs %v is not [%q, %q]", |
| 1596 | barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String()) |
| 1597 | } |
| 1598 | } |
| 1599 | |
Nan Zhang | 27e284d | 2018-02-09 21:03:53 +0000 | [diff] [blame] | 1600 | func TestExcludeFileGroupInSrcs(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 1601 | ctx, _ := testJava(t, ` |
Nan Zhang | 27e284d | 2018-02-09 21:03:53 +0000 | [diff] [blame] | 1602 | java_library { |
| 1603 | name: "foo", |
| 1604 | srcs: ["a.java", ":foo-srcs"], |
| 1605 | exclude_srcs: ["a.java", ":foo-excludes"], |
| 1606 | } |
| 1607 | |
| 1608 | filegroup { |
| 1609 | name: "foo-srcs", |
| 1610 | srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"], |
| 1611 | } |
| 1612 | |
| 1613 | filegroup { |
| 1614 | name: "foo-excludes", |
| 1615 | srcs: ["java-fg/a.java", "java-fg/b.java"], |
| 1616 | } |
| 1617 | `) |
| 1618 | |
| 1619 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") |
| 1620 | |
| 1621 | if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" { |
| 1622 | t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs) |
| 1623 | } |
| 1624 | } |
Jiyong Park | c678ad3 | 2018-04-10 13:07:10 +0900 | [diff] [blame] | 1625 | |
Paul Duffin | 52d398a | 2019-06-11 12:31:14 +0100 | [diff] [blame] | 1626 | func TestJavaLibrary(t *testing.T) { |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 1627 | config := testConfig(nil, "", map[string][]byte{ |
Paul Duffin | 52d398a | 2019-06-11 12:31:14 +0100 | [diff] [blame] | 1628 | "libcore/Android.bp": []byte(` |
| 1629 | java_library { |
| 1630 | name: "core", |
| 1631 | sdk_version: "none", |
| 1632 | system_modules: "none", |
Paul Duffin | aa55f74 | 2020-10-06 17:20:13 +0100 | [diff] [blame] | 1633 | } |
| 1634 | |
| 1635 | filegroup { |
| 1636 | name: "core-jar", |
| 1637 | srcs: [":core{.jar}"], |
| 1638 | } |
| 1639 | `), |
| 1640 | }) |
Colin Cross | ae8600b | 2020-10-29 17:09:13 -0700 | [diff] [blame] | 1641 | ctx := testContext(config) |
Paul Duffin | aa55f74 | 2020-10-06 17:20:13 +0100 | [diff] [blame] | 1642 | run(t, ctx, config) |
| 1643 | } |
| 1644 | |
| 1645 | func TestJavaImport(t *testing.T) { |
| 1646 | config := testConfig(nil, "", map[string][]byte{ |
| 1647 | "libcore/Android.bp": []byte(` |
| 1648 | java_import { |
| 1649 | name: "core", |
| 1650 | sdk_version: "none", |
| 1651 | } |
| 1652 | |
| 1653 | filegroup { |
| 1654 | name: "core-jar", |
| 1655 | srcs: [":core{.jar}"], |
| 1656 | } |
| 1657 | `), |
Paul Duffin | 52d398a | 2019-06-11 12:31:14 +0100 | [diff] [blame] | 1658 | }) |
Colin Cross | ae8600b | 2020-10-29 17:09:13 -0700 | [diff] [blame] | 1659 | ctx := testContext(config) |
Paul Duffin | 52d398a | 2019-06-11 12:31:14 +0100 | [diff] [blame] | 1660 | run(t, ctx, config) |
| 1661 | } |
| 1662 | |
Jiyong Park | c678ad3 | 2018-04-10 13:07:10 +0900 | [diff] [blame] | 1663 | func TestJavaSdkLibrary(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 1664 | ctx, _ := testJava(t, ` |
Paul Duffin | 884363e | 2019-12-19 10:21:09 +0000 | [diff] [blame] | 1665 | droiddoc_exported_dir { |
Jiyong Park | c678ad3 | 2018-04-10 13:07:10 +0900 | [diff] [blame] | 1666 | name: "droiddoc-templates-sdk", |
| 1667 | path: ".", |
| 1668 | } |
Jiyong Park | c678ad3 | 2018-04-10 13:07:10 +0900 | [diff] [blame] | 1669 | java_sdk_library { |
| 1670 | name: "foo", |
| 1671 | srcs: ["a.java", "b.java"], |
| 1672 | api_packages: ["foo"], |
| 1673 | } |
| 1674 | java_sdk_library { |
| 1675 | name: "bar", |
| 1676 | srcs: ["a.java", "b.java"], |
| 1677 | api_packages: ["bar"], |
| 1678 | } |
| 1679 | java_library { |
| 1680 | name: "baz", |
| 1681 | srcs: ["c.java"], |
Paul Duffin | 859fe96 | 2020-05-15 10:20:31 +0100 | [diff] [blame] | 1682 | libs: ["foo", "bar.stubs"], |
Jiyong Park | c678ad3 | 2018-04-10 13:07:10 +0900 | [diff] [blame] | 1683 | sdk_version: "system_current", |
| 1684 | } |
Paul Duffin | dfa131e | 2020-05-15 20:37:11 +0100 | [diff] [blame] | 1685 | java_sdk_library { |
| 1686 | name: "barney", |
| 1687 | srcs: ["c.java"], |
| 1688 | api_only: true, |
| 1689 | } |
| 1690 | java_sdk_library { |
| 1691 | name: "betty", |
| 1692 | srcs: ["c.java"], |
| 1693 | shared_library: false, |
| 1694 | } |
Paul Duffin | 859fe96 | 2020-05-15 10:20:31 +0100 | [diff] [blame] | 1695 | java_sdk_library_import { |
| 1696 | name: "quuz", |
| 1697 | public: { |
| 1698 | jars: ["c.jar"], |
| 1699 | }, |
| 1700 | } |
| 1701 | java_sdk_library_import { |
| 1702 | name: "fred", |
| 1703 | public: { |
| 1704 | jars: ["b.jar"], |
| 1705 | }, |
| 1706 | } |
Paul Duffin | dfa131e | 2020-05-15 20:37:11 +0100 | [diff] [blame] | 1707 | java_sdk_library_import { |
| 1708 | name: "wilma", |
| 1709 | public: { |
| 1710 | jars: ["b.jar"], |
| 1711 | }, |
| 1712 | shared_library: false, |
| 1713 | } |
Jiyong Park | 1be9691 | 2018-05-28 18:02:19 +0900 | [diff] [blame] | 1714 | java_library { |
| 1715 | name: "qux", |
| 1716 | srcs: ["c.java"], |
Paul Duffin | dfa131e | 2020-05-15 20:37:11 +0100 | [diff] [blame] | 1717 | libs: ["baz", "fred", "quuz.stubs", "wilma", "barney", "betty"], |
Jiyong Park | 1be9691 | 2018-05-28 18:02:19 +0900 | [diff] [blame] | 1718 | sdk_version: "system_current", |
| 1719 | } |
Paul Duffin | 726d23c | 2020-01-22 16:30:37 +0000 | [diff] [blame] | 1720 | java_library { |
| 1721 | name: "baz-test", |
| 1722 | srcs: ["c.java"], |
| 1723 | libs: ["foo"], |
| 1724 | sdk_version: "test_current", |
| 1725 | } |
Paul Duffin | a2db18f | 2020-01-22 17:11:15 +0000 | [diff] [blame] | 1726 | java_library { |
| 1727 | name: "baz-29", |
| 1728 | srcs: ["c.java"], |
| 1729 | libs: ["foo"], |
| 1730 | sdk_version: "system_29", |
| 1731 | } |
Paul Duffin | fb6ae5b | 2020-09-30 15:17:25 +0100 | [diff] [blame] | 1732 | java_library { |
| 1733 | name: "baz-module-30", |
| 1734 | srcs: ["c.java"], |
| 1735 | libs: ["foo"], |
| 1736 | sdk_version: "module_30", |
| 1737 | } |
Jiyong Park | c678ad3 | 2018-04-10 13:07:10 +0900 | [diff] [blame] | 1738 | `) |
| 1739 | |
| 1740 | // check the existence of the internal modules |
| 1741 | ctx.ModuleForTests("foo", "android_common") |
Paul Duffin | dd9d074 | 2020-05-08 15:52:37 +0100 | [diff] [blame] | 1742 | ctx.ModuleForTests(apiScopePublic.stubsLibraryModuleName("foo"), "android_common") |
| 1743 | ctx.ModuleForTests(apiScopeSystem.stubsLibraryModuleName("foo"), "android_common") |
| 1744 | ctx.ModuleForTests(apiScopeTest.stubsLibraryModuleName("foo"), "android_common") |
| 1745 | ctx.ModuleForTests(apiScopePublic.stubsSourceModuleName("foo"), "android_common") |
| 1746 | ctx.ModuleForTests(apiScopeSystem.stubsSourceModuleName("foo"), "android_common") |
| 1747 | ctx.ModuleForTests(apiScopeTest.stubsSourceModuleName("foo"), "android_common") |
Jiyong Park | e383388 | 2020-02-17 17:28:10 +0900 | [diff] [blame] | 1748 | ctx.ModuleForTests("foo"+sdkXmlFileSuffix, "android_common") |
Jiyong Park | 58c518b | 2018-05-12 22:29:12 +0900 | [diff] [blame] | 1749 | ctx.ModuleForTests("foo.api.public.28", "") |
| 1750 | ctx.ModuleForTests("foo.api.system.28", "") |
| 1751 | ctx.ModuleForTests("foo.api.test.28", "") |
Jiyong Park | c678ad3 | 2018-04-10 13:07:10 +0900 | [diff] [blame] | 1752 | |
| 1753 | bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac") |
| 1754 | // tests if baz is actually linked to the stubs lib |
| 1755 | if !strings.Contains(bazJavac.Args["classpath"], "foo.stubs.system.jar") { |
| 1756 | t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"], |
| 1757 | "foo.stubs.system.jar") |
| 1758 | } |
| 1759 | // ... and not to the impl lib |
Sundong Ahn | 054b19a | 2018-10-19 13:46:09 +0900 | [diff] [blame] | 1760 | if strings.Contains(bazJavac.Args["classpath"], "foo.jar") { |
Jiyong Park | c678ad3 | 2018-04-10 13:07:10 +0900 | [diff] [blame] | 1761 | t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"], |
Sundong Ahn | 054b19a | 2018-10-19 13:46:09 +0900 | [diff] [blame] | 1762 | "foo.jar") |
Jiyong Park | c678ad3 | 2018-04-10 13:07:10 +0900 | [diff] [blame] | 1763 | } |
| 1764 | // test if baz is not linked to the system variant of foo |
| 1765 | if strings.Contains(bazJavac.Args["classpath"], "foo.stubs.jar") { |
| 1766 | t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"], |
| 1767 | "foo.stubs.jar") |
| 1768 | } |
Jiyong Park | 1be9691 | 2018-05-28 18:02:19 +0900 | [diff] [blame] | 1769 | |
Paul Duffin | 726d23c | 2020-01-22 16:30:37 +0000 | [diff] [blame] | 1770 | bazTestJavac := ctx.ModuleForTests("baz-test", "android_common").Rule("javac") |
| 1771 | // tests if baz-test is actually linked to the test stubs lib |
| 1772 | if !strings.Contains(bazTestJavac.Args["classpath"], "foo.stubs.test.jar") { |
| 1773 | t.Errorf("baz-test javac classpath %v does not contain %q", bazTestJavac.Args["classpath"], |
| 1774 | "foo.stubs.test.jar") |
| 1775 | } |
| 1776 | |
Paul Duffin | a2db18f | 2020-01-22 17:11:15 +0000 | [diff] [blame] | 1777 | baz29Javac := ctx.ModuleForTests("baz-29", "android_common").Rule("javac") |
| 1778 | // tests if baz-29 is actually linked to the system 29 stubs lib |
| 1779 | if !strings.Contains(baz29Javac.Args["classpath"], "prebuilts/sdk/29/system/foo.jar") { |
| 1780 | t.Errorf("baz-29 javac classpath %v does not contain %q", baz29Javac.Args["classpath"], |
| 1781 | "prebuilts/sdk/29/system/foo.jar") |
| 1782 | } |
| 1783 | |
Paul Duffin | fb6ae5b | 2020-09-30 15:17:25 +0100 | [diff] [blame] | 1784 | bazModule30Javac := ctx.ModuleForTests("baz-module-30", "android_common").Rule("javac") |
| 1785 | // tests if "baz-module-30" is actually linked to the module 30 stubs lib |
| 1786 | if !strings.Contains(bazModule30Javac.Args["classpath"], "prebuilts/sdk/30/module-lib/foo.jar") { |
| 1787 | t.Errorf("baz-module-30 javac classpath %v does not contain %q", bazModule30Javac.Args["classpath"], |
| 1788 | "prebuilts/sdk/30/module-lib/foo.jar") |
| 1789 | } |
| 1790 | |
Jiyong Park | 1be9691 | 2018-05-28 18:02:19 +0900 | [diff] [blame] | 1791 | // test if baz has exported SDK lib names foo and bar to qux |
| 1792 | qux := ctx.ModuleForTests("qux", "android_common") |
| 1793 | if quxLib, ok := qux.Module().(*Library); ok { |
Ulya Trafimovich | b23d28c | 2020-10-08 12:53:58 +0100 | [diff] [blame] | 1794 | sdkLibs := quxLib.ClassLoaderContexts().UsesLibs() |
Ulya Trafimovich | 8cbc5d2 | 2020-11-03 15:15:46 +0000 | [diff] [blame] | 1795 | if w := []string{"foo", "bar", "fred", "quuz"}; !reflect.DeepEqual(w, sdkLibs) { |
Paul Duffin | 859fe96 | 2020-05-15 10:20:31 +0100 | [diff] [blame] | 1796 | t.Errorf("qux should export %q but exports %q", w, sdkLibs) |
Jiyong Park | 1be9691 | 2018-05-28 18:02:19 +0900 | [diff] [blame] | 1797 | } |
| 1798 | } |
Jiyong Park | c678ad3 | 2018-04-10 13:07:10 +0900 | [diff] [blame] | 1799 | } |
Zoran Jovanovic | 8736ce2 | 2018-08-21 17:10:29 +0200 | [diff] [blame] | 1800 | |
Anton Hansson | 7f66efa | 2020-10-08 14:47:23 +0100 | [diff] [blame] | 1801 | func TestJavaSdkLibrary_StubOrImplOnlyLibs(t *testing.T) { |
| 1802 | ctx, _ := testJava(t, ` |
| 1803 | java_sdk_library { |
Anton Hansson | dff2c78 | 2020-12-21 17:10:01 +0000 | [diff] [blame] | 1804 | name: "sdklib", |
Anton Hansson | 7f66efa | 2020-10-08 14:47:23 +0100 | [diff] [blame] | 1805 | srcs: ["a.java"], |
| 1806 | impl_only_libs: ["foo"], |
| 1807 | stub_only_libs: ["bar"], |
| 1808 | } |
| 1809 | java_library { |
| 1810 | name: "foo", |
| 1811 | srcs: ["a.java"], |
| 1812 | sdk_version: "current", |
| 1813 | } |
| 1814 | java_library { |
| 1815 | name: "bar", |
| 1816 | srcs: ["a.java"], |
| 1817 | sdk_version: "current", |
| 1818 | } |
| 1819 | `) |
| 1820 | |
Anton Hansson | dff2c78 | 2020-12-21 17:10:01 +0000 | [diff] [blame] | 1821 | for _, implName := range []string{"sdklib", "sdklib.impl"} { |
Anton Hansson | 7f66efa | 2020-10-08 14:47:23 +0100 | [diff] [blame] | 1822 | implJavacCp := ctx.ModuleForTests(implName, "android_common").Rule("javac").Args["classpath"] |
| 1823 | if !strings.Contains(implJavacCp, "/foo.jar") || strings.Contains(implJavacCp, "/bar.jar") { |
| 1824 | t.Errorf("%v javac classpath %v does not contain foo and not bar", implName, implJavacCp) |
| 1825 | } |
| 1826 | } |
Anton Hansson | dff2c78 | 2020-12-21 17:10:01 +0000 | [diff] [blame] | 1827 | stubName := apiScopePublic.stubsLibraryModuleName("sdklib") |
Anton Hansson | 7f66efa | 2020-10-08 14:47:23 +0100 | [diff] [blame] | 1828 | stubsJavacCp := ctx.ModuleForTests(stubName, "android_common").Rule("javac").Args["classpath"] |
| 1829 | if strings.Contains(stubsJavacCp, "/foo.jar") || !strings.Contains(stubsJavacCp, "/bar.jar") { |
| 1830 | t.Errorf("stubs javac classpath %v does not contain bar and not foo", stubsJavacCp) |
| 1831 | } |
| 1832 | } |
| 1833 | |
Paul Duffin | daaa332 | 2020-05-26 18:13:57 +0100 | [diff] [blame] | 1834 | func TestJavaSdkLibrary_DoNotAccessImplWhenItIsNotBuilt(t *testing.T) { |
| 1835 | ctx, _ := testJava(t, ` |
| 1836 | java_sdk_library { |
| 1837 | name: "foo", |
| 1838 | srcs: ["a.java"], |
| 1839 | api_only: true, |
| 1840 | public: { |
| 1841 | enabled: true, |
| 1842 | }, |
| 1843 | } |
| 1844 | |
| 1845 | java_library { |
| 1846 | name: "bar", |
| 1847 | srcs: ["b.java"], |
| 1848 | libs: ["foo"], |
| 1849 | } |
| 1850 | `) |
| 1851 | |
| 1852 | // The bar library should depend on the stubs jar. |
| 1853 | barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac") |
| 1854 | if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) { |
| 1855 | t.Errorf("expected %q, found %#q", expected, actual) |
| 1856 | } |
| 1857 | } |
| 1858 | |
Paul Duffin | 46dc45a | 2020-05-14 15:39:10 +0100 | [diff] [blame] | 1859 | func TestJavaSdkLibrary_UseSourcesFromAnotherSdkLibrary(t *testing.T) { |
| 1860 | testJava(t, ` |
| 1861 | java_sdk_library { |
| 1862 | name: "foo", |
| 1863 | srcs: ["a.java"], |
| 1864 | api_packages: ["foo"], |
| 1865 | public: { |
| 1866 | enabled: true, |
| 1867 | }, |
| 1868 | } |
| 1869 | |
| 1870 | java_library { |
| 1871 | name: "bar", |
| 1872 | srcs: ["b.java", ":foo{.public.stubs.source}"], |
| 1873 | } |
| 1874 | `) |
| 1875 | } |
| 1876 | |
| 1877 | func TestJavaSdkLibrary_AccessOutputFiles_MissingScope(t *testing.T) { |
| 1878 | testJavaError(t, `"foo" does not provide api scope system`, ` |
| 1879 | java_sdk_library { |
| 1880 | name: "foo", |
| 1881 | srcs: ["a.java"], |
| 1882 | api_packages: ["foo"], |
| 1883 | public: { |
| 1884 | enabled: true, |
| 1885 | }, |
| 1886 | } |
| 1887 | |
| 1888 | java_library { |
| 1889 | name: "bar", |
| 1890 | srcs: ["b.java", ":foo{.system.stubs.source}"], |
| 1891 | } |
| 1892 | `) |
| 1893 | } |
| 1894 | |
Paul Duffin | ca8d9a5 | 2020-06-26 22:20:25 +0100 | [diff] [blame] | 1895 | func TestJavaSdkLibrary_Deps(t *testing.T) { |
| 1896 | ctx, _ := testJava(t, ` |
| 1897 | java_sdk_library { |
| 1898 | name: "sdklib", |
| 1899 | srcs: ["a.java"], |
| 1900 | sdk_version: "none", |
| 1901 | system_modules: "none", |
| 1902 | public: { |
| 1903 | enabled: true, |
| 1904 | }, |
| 1905 | } |
| 1906 | `) |
| 1907 | |
Paul Duffin | cee7e66 | 2020-07-09 17:32:57 +0100 | [diff] [blame] | 1908 | CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{ |
Paul Duffin | ca8d9a5 | 2020-06-26 22:20:25 +0100 | [diff] [blame] | 1909 | `dex2oatd`, |
| 1910 | `sdklib.impl`, |
| 1911 | `sdklib.stubs`, |
| 1912 | `sdklib.stubs.source`, |
| 1913 | `sdklib.xml`, |
| 1914 | }) |
| 1915 | } |
| 1916 | |
Paul Duffin | 46dc45a | 2020-05-14 15:39:10 +0100 | [diff] [blame] | 1917 | func TestJavaSdkLibraryImport_AccessOutputFiles(t *testing.T) { |
| 1918 | testJava(t, ` |
| 1919 | java_sdk_library_import { |
| 1920 | name: "foo", |
| 1921 | public: { |
| 1922 | jars: ["a.jar"], |
| 1923 | stub_srcs: ["a.java"], |
| 1924 | current_api: "api/current.txt", |
| 1925 | removed_api: "api/removed.txt", |
| 1926 | }, |
| 1927 | } |
| 1928 | |
| 1929 | java_library { |
| 1930 | name: "bar", |
| 1931 | srcs: [":foo{.public.stubs.source}"], |
| 1932 | java_resources: [ |
| 1933 | ":foo{.public.api.txt}", |
| 1934 | ":foo{.public.removed-api.txt}", |
| 1935 | ], |
| 1936 | } |
| 1937 | `) |
| 1938 | } |
| 1939 | |
| 1940 | func TestJavaSdkLibraryImport_AccessOutputFiles_Invalid(t *testing.T) { |
| 1941 | bp := ` |
| 1942 | java_sdk_library_import { |
| 1943 | name: "foo", |
| 1944 | public: { |
| 1945 | jars: ["a.jar"], |
| 1946 | }, |
| 1947 | } |
| 1948 | ` |
| 1949 | |
| 1950 | t.Run("stubs.source", func(t *testing.T) { |
| 1951 | testJavaError(t, `stubs.source not available for api scope public`, bp+` |
| 1952 | java_library { |
| 1953 | name: "bar", |
| 1954 | srcs: [":foo{.public.stubs.source}"], |
| 1955 | java_resources: [ |
| 1956 | ":foo{.public.api.txt}", |
| 1957 | ":foo{.public.removed-api.txt}", |
| 1958 | ], |
| 1959 | } |
| 1960 | `) |
| 1961 | }) |
| 1962 | |
| 1963 | t.Run("api.txt", func(t *testing.T) { |
| 1964 | testJavaError(t, `api.txt not available for api scope public`, bp+` |
| 1965 | java_library { |
| 1966 | name: "bar", |
| 1967 | srcs: ["a.java"], |
| 1968 | java_resources: [ |
| 1969 | ":foo{.public.api.txt}", |
| 1970 | ], |
| 1971 | } |
| 1972 | `) |
| 1973 | }) |
| 1974 | |
| 1975 | t.Run("removed-api.txt", func(t *testing.T) { |
| 1976 | testJavaError(t, `removed-api.txt not available for api scope public`, bp+` |
| 1977 | java_library { |
| 1978 | name: "bar", |
| 1979 | srcs: ["a.java"], |
| 1980 | java_resources: [ |
| 1981 | ":foo{.public.removed-api.txt}", |
| 1982 | ], |
| 1983 | } |
| 1984 | `) |
| 1985 | }) |
| 1986 | } |
| 1987 | |
Paul Duffin | 3375e35 | 2020-04-28 10:44:03 +0100 | [diff] [blame] | 1988 | func TestJavaSdkLibrary_InvalidScopes(t *testing.T) { |
| 1989 | testJavaError(t, `module "foo": enabled api scope "system" depends on disabled scope "public"`, ` |
| 1990 | java_sdk_library { |
| 1991 | name: "foo", |
| 1992 | srcs: ["a.java", "b.java"], |
| 1993 | api_packages: ["foo"], |
| 1994 | // Explicitly disable public to test the check that ensures the set of enabled |
| 1995 | // scopes is consistent. |
| 1996 | public: { |
| 1997 | enabled: false, |
| 1998 | }, |
| 1999 | system: { |
| 2000 | enabled: true, |
| 2001 | }, |
| 2002 | } |
| 2003 | `) |
| 2004 | } |
| 2005 | |
Paul Duffin | 87a05a3 | 2020-05-12 11:50:28 +0100 | [diff] [blame] | 2006 | func TestJavaSdkLibrary_SdkVersion_ForScope(t *testing.T) { |
| 2007 | testJava(t, ` |
| 2008 | java_sdk_library { |
| 2009 | name: "foo", |
| 2010 | srcs: ["a.java", "b.java"], |
| 2011 | api_packages: ["foo"], |
| 2012 | system: { |
| 2013 | enabled: true, |
| 2014 | sdk_version: "module_current", |
| 2015 | }, |
| 2016 | } |
| 2017 | `) |
| 2018 | } |
| 2019 | |
Paul Duffin | 0c5bae5 | 2020-06-02 13:00:08 +0100 | [diff] [blame] | 2020 | func TestJavaSdkLibrary_ModuleLib(t *testing.T) { |
| 2021 | testJava(t, ` |
| 2022 | java_sdk_library { |
| 2023 | name: "foo", |
| 2024 | srcs: ["a.java", "b.java"], |
| 2025 | api_packages: ["foo"], |
| 2026 | system: { |
| 2027 | enabled: true, |
| 2028 | }, |
| 2029 | module_lib: { |
| 2030 | enabled: true, |
| 2031 | }, |
| 2032 | } |
| 2033 | `) |
| 2034 | } |
| 2035 | |
| 2036 | func TestJavaSdkLibrary_SystemServer(t *testing.T) { |
| 2037 | testJava(t, ` |
| 2038 | java_sdk_library { |
| 2039 | name: "foo", |
| 2040 | srcs: ["a.java", "b.java"], |
| 2041 | api_packages: ["foo"], |
| 2042 | system: { |
| 2043 | enabled: true, |
| 2044 | }, |
| 2045 | system_server: { |
| 2046 | enabled: true, |
| 2047 | }, |
| 2048 | } |
| 2049 | `) |
| 2050 | } |
| 2051 | |
Paul Duffin | 803a956 | 2020-05-20 11:52:25 +0100 | [diff] [blame] | 2052 | func TestJavaSdkLibrary_MissingScope(t *testing.T) { |
| 2053 | testJavaError(t, `requires api scope module-lib from foo but it only has \[\] available`, ` |
| 2054 | java_sdk_library { |
| 2055 | name: "foo", |
| 2056 | srcs: ["a.java"], |
| 2057 | public: { |
| 2058 | enabled: false, |
| 2059 | }, |
| 2060 | } |
| 2061 | |
| 2062 | java_library { |
| 2063 | name: "baz", |
| 2064 | srcs: ["a.java"], |
| 2065 | libs: ["foo"], |
| 2066 | sdk_version: "module_current", |
| 2067 | } |
| 2068 | `) |
| 2069 | } |
| 2070 | |
| 2071 | func TestJavaSdkLibrary_FallbackScope(t *testing.T) { |
| 2072 | testJava(t, ` |
| 2073 | java_sdk_library { |
| 2074 | name: "foo", |
| 2075 | srcs: ["a.java"], |
| 2076 | system: { |
| 2077 | enabled: true, |
| 2078 | }, |
| 2079 | } |
| 2080 | |
| 2081 | java_library { |
| 2082 | name: "baz", |
| 2083 | srcs: ["a.java"], |
| 2084 | libs: ["foo"], |
| 2085 | // foo does not have module-lib scope so it should fallback to system |
| 2086 | sdk_version: "module_current", |
| 2087 | } |
| 2088 | `) |
| 2089 | } |
| 2090 | |
Jiyong Park | 932cdfe | 2020-05-28 00:19:53 +0900 | [diff] [blame] | 2091 | func TestJavaSdkLibrary_DefaultToStubs(t *testing.T) { |
| 2092 | ctx, _ := testJava(t, ` |
| 2093 | java_sdk_library { |
| 2094 | name: "foo", |
| 2095 | srcs: ["a.java"], |
| 2096 | system: { |
| 2097 | enabled: true, |
| 2098 | }, |
| 2099 | default_to_stubs: true, |
| 2100 | } |
| 2101 | |
| 2102 | java_library { |
| 2103 | name: "baz", |
| 2104 | srcs: ["a.java"], |
| 2105 | libs: ["foo"], |
| 2106 | // does not have sdk_version set, should fallback to module, |
| 2107 | // which will then fallback to system because the module scope |
| 2108 | // is not enabled. |
| 2109 | } |
| 2110 | `) |
| 2111 | // The baz library should depend on the system stubs jar. |
| 2112 | bazLibrary := ctx.ModuleForTests("baz", "android_common").Rule("javac") |
| 2113 | if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs.system\.jar$`, bazLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) { |
| 2114 | t.Errorf("expected %q, found %#q", expected, actual) |
| 2115 | } |
| 2116 | } |
| 2117 | |
Zoran Jovanovic | 8736ce2 | 2018-08-21 17:10:29 +0200 | [diff] [blame] | 2118 | var compilerFlagsTestCases = []struct { |
| 2119 | in string |
| 2120 | out bool |
| 2121 | }{ |
| 2122 | { |
| 2123 | in: "a", |
| 2124 | out: false, |
| 2125 | }, |
| 2126 | { |
| 2127 | in: "-a", |
| 2128 | out: true, |
| 2129 | }, |
| 2130 | { |
| 2131 | in: "-no-jdk", |
| 2132 | out: false, |
| 2133 | }, |
| 2134 | { |
| 2135 | in: "-no-stdlib", |
| 2136 | out: false, |
| 2137 | }, |
| 2138 | { |
| 2139 | in: "-kotlin-home", |
| 2140 | out: false, |
| 2141 | }, |
| 2142 | { |
| 2143 | in: "-kotlin-home /some/path", |
| 2144 | out: false, |
| 2145 | }, |
| 2146 | { |
| 2147 | in: "-include-runtime", |
| 2148 | out: false, |
| 2149 | }, |
| 2150 | { |
| 2151 | in: "-Xintellij-plugin-root", |
| 2152 | out: false, |
| 2153 | }, |
| 2154 | } |
| 2155 | |
| 2156 | type mockContext struct { |
| 2157 | android.ModuleContext |
| 2158 | result bool |
| 2159 | } |
| 2160 | |
| 2161 | func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) { |
| 2162 | // CheckBadCompilerFlags calls this function when the flag should be rejected |
| 2163 | ctx.result = false |
| 2164 | } |
| 2165 | |
| 2166 | func TestCompilerFlags(t *testing.T) { |
| 2167 | for _, testCase := range compilerFlagsTestCases { |
| 2168 | ctx := &mockContext{result: true} |
| 2169 | CheckKotlincFlags(ctx, []string{testCase.in}) |
| 2170 | if ctx.result != testCase.out { |
| 2171 | t.Errorf("incorrect output:") |
| 2172 | t.Errorf(" input: %#v", testCase.in) |
| 2173 | t.Errorf(" expected: %#v", testCase.out) |
| 2174 | t.Errorf(" got: %#v", ctx.result) |
| 2175 | } |
| 2176 | } |
| 2177 | } |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 2178 | |
| 2179 | // TODO(jungjw): Consider making this more robust by ignoring path order. |
| 2180 | func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) { |
| 2181 | variables := ctx.ModuleForTests(moduleName, "android_common").Module().VariablesForTests() |
| 2182 | flags := strings.Split(variables["javacFlags"], " ") |
| 2183 | got := "" |
| 2184 | for _, flag := range flags { |
| 2185 | keyEnd := strings.Index(flag, "=") |
| 2186 | if keyEnd > -1 && flag[:keyEnd] == "--patch-module" { |
| 2187 | got = flag[keyEnd+1:] |
| 2188 | break |
| 2189 | } |
| 2190 | } |
| 2191 | if expected != got { |
| 2192 | t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got) |
| 2193 | } |
| 2194 | } |
| 2195 | |
| 2196 | func TestPatchModule(t *testing.T) { |
Pete Gillin | 0c2143e | 2019-05-02 15:32:11 +0100 | [diff] [blame] | 2197 | t.Run("Java language level 8", func(t *testing.T) { |
Pete Gillin | 1b3370f | 2019-10-01 13:57:31 +0100 | [diff] [blame] | 2198 | // Test with legacy javac -source 1.8 -target 1.8 |
Pete Gillin | bdf5d71 | 2019-10-21 14:29:58 +0100 | [diff] [blame] | 2199 | bp := ` |
| 2200 | java_library { |
| 2201 | name: "foo", |
| 2202 | srcs: ["a.java"], |
| 2203 | java_version: "1.8", |
| 2204 | } |
| 2205 | |
| 2206 | java_library { |
| 2207 | name: "bar", |
| 2208 | srcs: ["b.java"], |
| 2209 | sdk_version: "none", |
| 2210 | system_modules: "none", |
| 2211 | patch_module: "java.base", |
| 2212 | java_version: "1.8", |
| 2213 | } |
| 2214 | |
| 2215 | java_library { |
| 2216 | name: "baz", |
| 2217 | srcs: ["c.java"], |
| 2218 | patch_module: "java.base", |
| 2219 | java_version: "1.8", |
| 2220 | } |
| 2221 | ` |
| 2222 | ctx, _ := testJava(t, bp) |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 2223 | |
| 2224 | checkPatchModuleFlag(t, ctx, "foo", "") |
| 2225 | checkPatchModuleFlag(t, ctx, "bar", "") |
| 2226 | checkPatchModuleFlag(t, ctx, "baz", "") |
| 2227 | }) |
| 2228 | |
Pete Gillin | 0c2143e | 2019-05-02 15:32:11 +0100 | [diff] [blame] | 2229 | t.Run("Java language level 9", func(t *testing.T) { |
Pete Gillin | 1b3370f | 2019-10-01 13:57:31 +0100 | [diff] [blame] | 2230 | // Test with default javac -source 9 -target 9 |
Pete Gillin | bdf5d71 | 2019-10-21 14:29:58 +0100 | [diff] [blame] | 2231 | bp := ` |
| 2232 | java_library { |
| 2233 | name: "foo", |
| 2234 | srcs: ["a.java"], |
| 2235 | } |
| 2236 | |
| 2237 | java_library { |
| 2238 | name: "bar", |
| 2239 | srcs: ["b.java"], |
| 2240 | sdk_version: "none", |
| 2241 | system_modules: "none", |
| 2242 | patch_module: "java.base", |
| 2243 | } |
| 2244 | |
| 2245 | java_library { |
| 2246 | name: "baz", |
Jingwen Chen | 5136a6e | 2020-10-30 01:01:35 -0400 | [diff] [blame] | 2247 | srcs: [ |
| 2248 | "c.java", |
| 2249 | // Tests for b/150878007 |
| 2250 | "dir/d.java", |
| 2251 | "dir2/e.java", |
| 2252 | "dir2/f.java", |
| 2253 | "nested/dir/g.java" |
| 2254 | ], |
Pete Gillin | bdf5d71 | 2019-10-21 14:29:58 +0100 | [diff] [blame] | 2255 | patch_module: "java.base", |
| 2256 | } |
| 2257 | ` |
Pete Gillin | 1b3370f | 2019-10-01 13:57:31 +0100 | [diff] [blame] | 2258 | ctx, _ := testJava(t, bp) |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 2259 | |
| 2260 | checkPatchModuleFlag(t, ctx, "foo", "") |
| 2261 | expected := "java.base=.:" + buildDir |
| 2262 | checkPatchModuleFlag(t, ctx, "bar", expected) |
Jingwen Chen | 5136a6e | 2020-10-30 01:01:35 -0400 | [diff] [blame] | 2263 | expected = "java.base=" + strings.Join([]string{ |
| 2264 | ".", buildDir, "dir", "dir2", "nested", moduleToPath("ext"), moduleToPath("framework")}, ":") |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 2265 | checkPatchModuleFlag(t, ctx, "baz", expected) |
| 2266 | }) |
| 2267 | } |
Paul Duffin | a7b9f42 | 2020-01-10 17:12:18 +0000 | [diff] [blame] | 2268 | |
| 2269 | func TestJavaSystemModules(t *testing.T) { |
| 2270 | ctx, _ := testJava(t, ` |
| 2271 | java_system_modules { |
| 2272 | name: "system-modules", |
| 2273 | libs: ["system-module1", "system-module2"], |
| 2274 | } |
| 2275 | java_library { |
| 2276 | name: "system-module1", |
| 2277 | srcs: ["a.java"], |
| 2278 | sdk_version: "none", |
| 2279 | system_modules: "none", |
| 2280 | } |
| 2281 | java_library { |
| 2282 | name: "system-module2", |
| 2283 | srcs: ["b.java"], |
| 2284 | sdk_version: "none", |
| 2285 | system_modules: "none", |
| 2286 | } |
| 2287 | `) |
| 2288 | |
| 2289 | // check the existence of the module |
| 2290 | systemModules := ctx.ModuleForTests("system-modules", "android_common") |
| 2291 | |
| 2292 | cmd := systemModules.Rule("jarsTosystemModules") |
| 2293 | |
| 2294 | // make sure the command compiles against the supplied modules. |
| 2295 | for _, module := range []string{"system-module1.jar", "system-module2.jar"} { |
| 2296 | if !strings.Contains(cmd.Args["classpath"], module) { |
| 2297 | t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"], |
| 2298 | module) |
| 2299 | } |
| 2300 | } |
| 2301 | } |
Paul Duffin | 90169ba | 2020-01-10 17:16:44 +0000 | [diff] [blame] | 2302 | |
| 2303 | func TestJavaSystemModulesImport(t *testing.T) { |
| 2304 | ctx, _ := testJava(t, ` |
| 2305 | java_system_modules_import { |
| 2306 | name: "system-modules", |
| 2307 | libs: ["system-module1", "system-module2"], |
| 2308 | } |
| 2309 | java_import { |
| 2310 | name: "system-module1", |
| 2311 | jars: ["a.jar"], |
| 2312 | } |
| 2313 | java_import { |
| 2314 | name: "system-module2", |
| 2315 | jars: ["b.jar"], |
| 2316 | } |
| 2317 | `) |
| 2318 | |
| 2319 | // check the existence of the module |
| 2320 | systemModules := ctx.ModuleForTests("system-modules", "android_common") |
| 2321 | |
| 2322 | cmd := systemModules.Rule("jarsTosystemModules") |
| 2323 | |
| 2324 | // make sure the command compiles against the supplied modules. |
| 2325 | for _, module := range []string{"system-module1.jar", "system-module2.jar"} { |
| 2326 | if !strings.Contains(cmd.Args["classpath"], module) { |
| 2327 | t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"], |
| 2328 | module) |
| 2329 | } |
| 2330 | } |
| 2331 | } |
Paul Duffin | 83a2d96 | 2019-11-19 19:44:10 +0000 | [diff] [blame] | 2332 | |
| 2333 | func TestJavaLibraryWithSystemModules(t *testing.T) { |
| 2334 | ctx, _ := testJava(t, ` |
| 2335 | java_library { |
| 2336 | name: "lib-with-source-system-modules", |
| 2337 | srcs: [ |
| 2338 | "a.java", |
| 2339 | ], |
| 2340 | sdk_version: "none", |
| 2341 | system_modules: "source-system-modules", |
| 2342 | } |
| 2343 | |
| 2344 | java_library { |
| 2345 | name: "source-jar", |
| 2346 | srcs: [ |
| 2347 | "a.java", |
| 2348 | ], |
| 2349 | } |
| 2350 | |
| 2351 | java_system_modules { |
| 2352 | name: "source-system-modules", |
| 2353 | libs: ["source-jar"], |
| 2354 | } |
| 2355 | |
| 2356 | java_library { |
| 2357 | name: "lib-with-prebuilt-system-modules", |
| 2358 | srcs: [ |
| 2359 | "a.java", |
| 2360 | ], |
| 2361 | sdk_version: "none", |
| 2362 | system_modules: "prebuilt-system-modules", |
| 2363 | } |
| 2364 | |
| 2365 | java_import { |
| 2366 | name: "prebuilt-jar", |
| 2367 | jars: ["a.jar"], |
| 2368 | } |
| 2369 | |
| 2370 | java_system_modules_import { |
| 2371 | name: "prebuilt-system-modules", |
| 2372 | libs: ["prebuilt-jar"], |
| 2373 | } |
| 2374 | `) |
| 2375 | |
| 2376 | checkBootClasspathForSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar") |
| 2377 | |
| 2378 | checkBootClasspathForSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar") |
| 2379 | } |
| 2380 | |
| 2381 | func checkBootClasspathForSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) { |
| 2382 | javacRule := ctx.ModuleForTests(moduleName, "android_common").Rule("javac") |
| 2383 | bootClasspath := javacRule.Args["bootClasspath"] |
| 2384 | if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) { |
| 2385 | t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath) |
| 2386 | } |
| 2387 | } |
Jiyong Park | 19604de | 2020-03-24 16:44:11 +0900 | [diff] [blame] | 2388 | |
| 2389 | func TestAidlExportIncludeDirsFromImports(t *testing.T) { |
| 2390 | ctx, _ := testJava(t, ` |
| 2391 | java_library { |
| 2392 | name: "foo", |
| 2393 | srcs: ["aidl/foo/IFoo.aidl"], |
| 2394 | libs: ["bar"], |
| 2395 | } |
| 2396 | |
| 2397 | java_import { |
| 2398 | name: "bar", |
| 2399 | jars: ["a.jar"], |
| 2400 | aidl: { |
| 2401 | export_include_dirs: ["aidl/bar"], |
| 2402 | }, |
| 2403 | } |
| 2404 | `) |
| 2405 | |
| 2406 | aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command |
| 2407 | expectedAidlFlag := "-Iaidl/bar" |
| 2408 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 2409 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 2410 | } |
| 2411 | } |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 2412 | |
Jooyung Han | e197d8b | 2021-01-05 10:33:16 +0900 | [diff] [blame] | 2413 | func TestAidlFlagsArePassedToTheAidlCompiler(t *testing.T) { |
| 2414 | ctx, _ := testJava(t, ` |
| 2415 | java_library { |
| 2416 | name: "foo", |
| 2417 | srcs: ["aidl/foo/IFoo.aidl"], |
| 2418 | aidl: { flags: ["-Werror"], }, |
| 2419 | } |
| 2420 | `) |
| 2421 | |
| 2422 | aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command |
| 2423 | expectedAidlFlag := "-Werror" |
| 2424 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 2425 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 2426 | } |
| 2427 | } |
| 2428 | |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 2429 | func TestDataNativeBinaries(t *testing.T) { |
| 2430 | ctx, config := testJava(t, ` |
| 2431 | java_test_host { |
| 2432 | name: "foo", |
| 2433 | srcs: ["a.java"], |
| 2434 | data_native_bins: ["bin"] |
| 2435 | } |
| 2436 | |
| 2437 | python_binary_host { |
| 2438 | name: "bin", |
| 2439 | srcs: ["bin.py"], |
| 2440 | } |
| 2441 | `) |
| 2442 | |
| 2443 | buildOS := android.BuildOs.String() |
| 2444 | |
| 2445 | test := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost) |
| 2446 | entries := android.AndroidMkEntriesForTest(t, config, "", test)[0] |
| 2447 | expected := []string{buildDir + "/.intermediates/bin/" + buildOS + "_x86_64_PY3/bin:bin"} |
| 2448 | actual := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"] |
| 2449 | if !reflect.DeepEqual(expected, actual) { |
| 2450 | t.Errorf("Unexpected test data - expected: %q, actual: %q", expected, actual) |
| 2451 | } |
| 2452 | } |