blob: 3ab228bd2b8504677464cafed43fe366e7bd22c5 [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Paul Duffin1a393322020-11-18 16:36:47 +000018 "fmt"
Colin Cross72bb3632017-07-13 16:23:21 -070019 "io/ioutil"
20 "os"
21 "path/filepath"
Colin Crossc0806172019-06-14 18:51:47 -070022 "reflect"
Paul Duffindaaa3322020-05-26 18:13:57 +010023 "regexp"
Nan Zhang61eaedb2017-11-02 13:28:15 -070024 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070025 "strings"
26 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070027
Jeongik Cha28df2572019-11-11 10:46:36 +090028 "github.com/google/blueprint/proptools"
29
Colin Crossa4f08812018-10-02 22:03:40 -070030 "android/soong/android"
31 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080032 "android/soong/dexpreopt"
Colin Crossb5ae1932020-11-17 06:32:06 +000033 "android/soong/genrule"
Liz Kammerdd849a82020-06-12 16:38:45 -070034 "android/soong/python"
Colin Cross72bb3632017-07-13 16:23:21 -070035)
36
37var buildDir string
38
39func setUp() {
40 var err error
41 buildDir, err = ioutil.TempDir("", "soong_java_test")
42 if err != nil {
43 panic(err)
44 }
45}
46
47func tearDown() {
48 os.RemoveAll(buildDir)
49}
50
51func TestMain(m *testing.M) {
52 run := func() int {
53 setUp()
54 defer tearDown()
55
56 return m.Run()
57 }
58
59 os.Exit(run())
60}
Colin Cross527012a2017-11-30 22:56:16 -080061
Colin Cross98be1bb2019-12-13 20:41:13 -080062func testConfig(env map[string]string, bp string, fs map[string][]byte) android.Config {
Martin Stjernholmd90676f2020-01-11 00:37:30 +000063 bp += dexpreopt.BpToolModulesForTest()
64
Martin Stjernholm75a48d82020-01-10 20:32:59 +000065 config := TestConfig(buildDir, env, bp, fs)
66
67 // Set up the global Once cache used for dexpreopt.GlobalSoongConfig, so that
68 // it doesn't create a real one, which would fail.
69 _ = dexpreopt.GlobalSoongConfigForTests(config)
70
71 return config
Colin Cross1369cdb2017-09-29 17:58:17 -070072}
73
Colin Crossae8600b2020-10-29 17:09:13 -070074func testContext(config android.Config) *android.TestContext {
Colin Cross72bb3632017-07-13 16:23:21 -070075
Colin Crossae8600b2020-10-29 17:09:13 -070076 ctx := android.NewTestArchContext(config)
Paul Duffinf9b1da02019-12-18 19:51:55 +000077 RegisterJavaBuildComponents(ctx)
78 RegisterAppBuildComponents(ctx)
79 RegisterAARBuildComponents(ctx)
Paul Duffinb0f85072019-12-19 10:28:56 +000080 RegisterGenRuleBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000081 RegisterSystemModulesBuildComponents(ctx)
Colin Cross4b49b762019-11-22 15:25:03 -080082 ctx.RegisterModuleType("java_plugin", PluginFactory)
Colin Cross4b49b762019-11-22 15:25:03 -080083 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
Colin Crossb5ae1932020-11-17 06:32:06 +000084 ctx.RegisterModuleType("genrule", genrule.GenRuleFactory)
Liz Kammerdd849a82020-06-12 16:38:45 -070085 ctx.RegisterModuleType("python_binary_host", python.PythonBinaryHostFactory)
Paul Duffin884363e2019-12-19 10:21:09 +000086 RegisterDocsBuildComponents(ctx)
87 RegisterStubsBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000088 RegisterSdkLibraryBuildComponents(ctx)
Colin Cross89536d42017-07-07 14:35:50 -070089 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Paul Duffin44f1d842020-06-26 20:17:02 +010090 ctx.PreArchMutators(android.RegisterComponentsMutator)
Paul Duffina48f7582019-12-19 11:25:19 +000091
92 RegisterPrebuiltApisBuildComponents(ctx)
93
Liz Kammerdd849a82020-06-12 16:38:45 -070094 ctx.PreDepsMutators(python.RegisterPythonPreDepsMutators)
Jaewoong Jungb639a6a2019-05-10 15:16:29 -070095 ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
Colin Cross06fa5882020-10-29 18:21:38 -070096 ctx.RegisterPreSingletonType("overlay", android.SingletonFactoryAdaptor(ctx.Context, OverlaySingletonFactory))
97 ctx.RegisterPreSingletonType("sdk_versions", android.SingletonFactoryAdaptor(ctx.Context, sdkPreSingletonFactory))
Colin Crossa4f08812018-10-02 22:03:40 -070098
Paul Duffin021f4e52020-07-30 16:04:17 +010099 android.RegisterPrebuiltMutators(ctx)
100
Colin Crossa4f08812018-10-02 22:03:40 -0700101 // Register module types and mutators from cc needed for JNI testing
Paul Duffin77980a82019-12-19 16:01:36 +0000102 cc.RegisterRequiredBuildComponentsForTest(ctx)
Colin Crossa4f08812018-10-02 22:03:40 -0700103
Martin Stjernholmd90676f2020-01-11 00:37:30 +0000104 dexpreopt.RegisterToolModulesForTest(ctx)
105
Jaewoong Jungc779cd42020-10-06 18:56:10 -0700106 ctx.PostDepsMutators(func(ctx android.RegisterMutatorsContext) {
107 ctx.TopDown("propagate_rro_enforcement", propagateRROEnforcementMutator).Parallel()
108 })
109
Colin Cross527012a2017-11-30 22:56:16 -0800110 return ctx
111}
112
113func run(t *testing.T, ctx *android.TestContext, config android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800114 t.Helper()
Colin Crossc28bb0b2019-02-25 14:20:47 -0800115
Colin Cross98be1bb2019-12-13 20:41:13 -0800116 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000117 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Colin Crossc28bb0b2019-02-25 14:20:47 -0800118
Colin Crossae8600b2020-10-29 17:09:13 -0700119 ctx.Register()
Paul Duffinbaccf7e2019-06-11 11:58:30 +0100120 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
Logan Chien42039712018-03-12 16:29:17 +0800121 android.FailIfErrored(t, errs)
Colin Cross72bb3632017-07-13 16:23:21 -0700122 _, errs = ctx.PrepareBuildActions(config)
Logan Chien42039712018-03-12 16:29:17 +0800123 android.FailIfErrored(t, errs)
Colin Cross527012a2017-11-30 22:56:16 -0800124}
125
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900126func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) {
Jeongik Cha538c0d02019-07-11 15:54:27 +0900127 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800128 return testJavaErrorWithConfig(t, pattern, testConfig(nil, bp, nil))
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900129}
130
Colin Cross98be1bb2019-12-13 20:41:13 -0800131func testJavaErrorWithConfig(t *testing.T, pattern string, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900132 t.Helper()
Colin Crossae8600b2020-10-29 17:09:13 -0700133 ctx := testContext(config)
Jeongik Cha538c0d02019-07-11 15:54:27 +0900134
Colin Cross98be1bb2019-12-13 20:41:13 -0800135 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000136 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Jeongik Cha538c0d02019-07-11 15:54:27 +0900137
Colin Crossae8600b2020-10-29 17:09:13 -0700138 ctx.Register()
Jeongik Cha538c0d02019-07-11 15:54:27 +0900139 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
140 if len(errs) > 0 {
141 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900142 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900143 }
144 _, errs = ctx.PrepareBuildActions(config)
145 if len(errs) > 0 {
146 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900147 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900148 }
149
150 t.Fatalf("missing expected error %q (0 errors are returned)", pattern)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900151
152 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900153}
154
Colin Cross238c1f32020-06-07 16:58:18 -0700155func testJavaWithFS(t *testing.T, bp string, fs map[string][]byte) (*android.TestContext, android.Config) {
156 t.Helper()
157 return testJavaWithConfig(t, testConfig(nil, bp, fs))
158}
159
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700160func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800161 t.Helper()
Colin Cross238c1f32020-06-07 16:58:18 -0700162 return testJavaWithFS(t, bp, nil)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900163}
164
Colin Cross98be1bb2019-12-13 20:41:13 -0800165func testJavaWithConfig(t *testing.T, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900166 t.Helper()
Colin Crossae8600b2020-10-29 17:09:13 -0700167 ctx := testContext(config)
Colin Cross527012a2017-11-30 22:56:16 -0800168 run(t, ctx, config)
Colin Cross72bb3632017-07-13 16:23:21 -0700169
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700170 return ctx, config
Colin Cross72bb3632017-07-13 16:23:21 -0700171}
172
Colin Cross2acdae82017-09-15 19:44:24 -0700173func moduleToPath(name string) string {
174 switch {
175 case name == `""`:
176 return name
Colin Crossfc3674a2017-09-18 17:41:52 -0700177 case strings.HasSuffix(name, ".jar"):
178 return name
Nan Zhanged19fc32017-10-19 13:06:22 -0700179 default:
180 return filepath.Join(buildDir, ".intermediates", name, "android_common", "turbine-combined", name+".jar")
Colin Cross2acdae82017-09-15 19:44:24 -0700181 }
182}
183
Jeongik Chae403e9e2019-12-07 00:16:24 +0900184func TestJavaLinkType(t *testing.T) {
185 testJava(t, `
186 java_library {
187 name: "foo",
188 srcs: ["a.java"],
189 libs: ["bar"],
190 static_libs: ["baz"],
191 }
192
193 java_library {
194 name: "bar",
195 sdk_version: "current",
196 srcs: ["b.java"],
197 }
198
199 java_library {
200 name: "baz",
201 sdk_version: "system_current",
202 srcs: ["c.java"],
203 }
204 `)
205
Steven Moreland00298982020-11-17 21:44:36 +0000206 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900207 java_library {
208 name: "foo",
209 srcs: ["a.java"],
210 libs: ["bar"],
211 sdk_version: "current",
212 static_libs: ["baz"],
213 }
214
215 java_library {
216 name: "bar",
217 sdk_version: "current",
218 srcs: ["b.java"],
219 }
220
221 java_library {
222 name: "baz",
223 sdk_version: "system_current",
224 srcs: ["c.java"],
225 }
226 `)
227
228 testJava(t, `
229 java_library {
230 name: "foo",
231 srcs: ["a.java"],
232 libs: ["bar"],
233 sdk_version: "system_current",
234 static_libs: ["baz"],
235 }
236
237 java_library {
238 name: "bar",
239 sdk_version: "current",
240 srcs: ["b.java"],
241 }
242
243 java_library {
244 name: "baz",
245 sdk_version: "system_current",
246 srcs: ["c.java"],
247 }
248 `)
249
Steven Moreland00298982020-11-17 21:44:36 +0000250 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900251 java_library {
252 name: "foo",
253 srcs: ["a.java"],
254 libs: ["bar"],
255 sdk_version: "system_current",
256 static_libs: ["baz"],
257 }
258
259 java_library {
260 name: "bar",
261 sdk_version: "current",
262 srcs: ["b.java"],
263 }
264
265 java_library {
266 name: "baz",
267 srcs: ["c.java"],
268 }
269 `)
270}
271
Colin Cross72bb3632017-07-13 16:23:21 -0700272func TestSimple(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700273 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700274 java_library {
275 name: "foo",
276 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700277 libs: ["bar"],
278 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700279 }
280
281 java_library {
282 name: "bar",
283 srcs: ["b.java"],
284 }
285
286 java_library {
287 name: "baz",
288 srcs: ["c.java"],
289 }
Colin Crossd5934c82017-10-02 13:55:26 -0700290 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700291
Colin Cross4c428df2017-09-15 17:36:05 -0700292 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700293 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700294
295 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
296 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
297 }
298
Colin Cross1ee23172017-10-18 14:44:18 -0700299 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Nan Zhanged19fc32017-10-19 13:06:22 -0700300 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
301 bazTurbine := filepath.Join(buildDir, ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700302
Nan Zhanged19fc32017-10-19 13:06:22 -0700303 if !strings.Contains(javac.Args["classpath"], barTurbine) {
304 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700305 }
306
Nan Zhanged19fc32017-10-19 13:06:22 -0700307 if !strings.Contains(javac.Args["classpath"], bazTurbine) {
308 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700309 }
310
311 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
312 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700313 }
314}
315
Artur Satayev9cf46692019-11-26 18:08:34 +0000316func TestExportedPlugins(t *testing.T) {
317 type Result struct {
Colin Crossc9fe10f2020-11-19 18:06:03 -0800318 library string
319 processors string
320 disableTurbine bool
Artur Satayev9cf46692019-11-26 18:08:34 +0000321 }
322 var tests = []struct {
323 name string
324 extra string
325 results []Result
326 }{
327 {
328 name: "Exported plugin is not a direct plugin",
329 extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`,
330 results: []Result{{library: "exports", processors: "-proc:none"}},
331 },
332 {
333 name: "Exports plugin to dependee",
334 extra: `
335 java_library{name: "exports", exported_plugins: ["plugin"]}
336 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
337 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
338 `,
339 results: []Result{
340 {library: "foo", processors: "-processor com.android.TestPlugin"},
341 {library: "bar", processors: "-processor com.android.TestPlugin"},
342 },
343 },
344 {
345 name: "Exports plugin to android_library",
346 extra: `
347 java_library{name: "exports", exported_plugins: ["plugin"]}
348 android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
349 android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
350 `,
351 results: []Result{
352 {library: "foo", processors: "-processor com.android.TestPlugin"},
353 {library: "bar", processors: "-processor com.android.TestPlugin"},
354 },
355 },
356 {
357 name: "Exports plugin is not propagated via transitive deps",
358 extra: `
359 java_library{name: "exports", exported_plugins: ["plugin"]}
360 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
361 java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]}
362 `,
363 results: []Result{
364 {library: "foo", processors: "-processor com.android.TestPlugin"},
365 {library: "bar", processors: "-proc:none"},
366 },
367 },
368 {
369 name: "Exports plugin appends to plugins",
370 extra: `
371 java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"}
372 java_library{name: "exports", exported_plugins: ["plugin"]}
373 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]}
374 `,
375 results: []Result{
376 {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"},
377 },
378 },
Colin Crossc9fe10f2020-11-19 18:06:03 -0800379 {
380 name: "Exports plugin to with generates_api to dependee",
381 extra: `
382 java_library{name: "exports", exported_plugins: ["plugin_generates_api"]}
383 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
384 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
385 `,
386 results: []Result{
387 {library: "foo", processors: "-processor com.android.TestPlugin", disableTurbine: true},
388 {library: "bar", processors: "-processor com.android.TestPlugin", disableTurbine: true},
389 },
390 },
Artur Satayev9cf46692019-11-26 18:08:34 +0000391 }
392
393 for _, test := range tests {
394 t.Run(test.name, func(t *testing.T) {
395 ctx, _ := testJava(t, `
396 java_plugin {
397 name: "plugin",
398 processor_class: "com.android.TestPlugin",
399 }
Colin Crossc9fe10f2020-11-19 18:06:03 -0800400 java_plugin {
401 name: "plugin_generates_api",
402 generates_api: true,
403 processor_class: "com.android.TestPlugin",
404 }
Artur Satayev9cf46692019-11-26 18:08:34 +0000405 `+test.extra)
406
407 for _, want := range test.results {
408 javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac")
409 if javac.Args["processor"] != want.processors {
410 t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"])
411 }
Colin Crossc9fe10f2020-11-19 18:06:03 -0800412 turbine := ctx.ModuleForTests(want.library, "android_common").MaybeRule("turbine")
413 disableTurbine := turbine.BuildParams.Rule == nil
414 if disableTurbine != want.disableTurbine {
415 t.Errorf("For library %v, expected disableTurbine %v, found %v", want.library, want.disableTurbine, disableTurbine)
416 }
Artur Satayev9cf46692019-11-26 18:08:34 +0000417 }
418 })
419 }
420}
421
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900422func TestSdkVersionByPartition(t *testing.T) {
423 testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900424 java_library {
425 name: "foo",
426 srcs: ["a.java"],
427 vendor: true,
428 }
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900429 `)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900430
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900431 testJava(t, `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900432 java_library {
433 name: "bar",
434 srcs: ["b.java"],
435 }
436 `)
437
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900438 for _, enforce := range []bool{true, false} {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900439 bp := `
440 java_library {
441 name: "foo",
442 srcs: ["a.java"],
443 product_specific: true,
444 }
445 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800446
447 config := testConfig(nil, bp, nil)
448 config.TestProductVariables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900449 if enforce {
Colin Cross98be1bb2019-12-13 20:41:13 -0800450 testJavaErrorWithConfig(t, "sdk_version must have a value when the module is located at vendor or product", config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900451 } else {
Colin Cross98be1bb2019-12-13 20:41:13 -0800452 testJavaWithConfig(t, config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900453 }
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900454 }
455}
456
Colin Crossd5934c82017-10-02 13:55:26 -0700457func TestArchSpecific(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700458 ctx, _ := testJava(t, `
Colin Crossd5934c82017-10-02 13:55:26 -0700459 java_library {
460 name: "foo",
461 srcs: ["a.java"],
462 target: {
463 android: {
464 srcs: ["b.java"],
465 },
466 },
467 }
468 `)
469
470 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
471 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
472 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
473 }
474}
475
Colin Cross6b4a32d2017-12-05 13:42:45 -0800476func TestBinary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700477 ctx, _ := testJava(t, `
Colin Cross6b4a32d2017-12-05 13:42:45 -0800478 java_library_host {
479 name: "foo",
480 srcs: ["a.java"],
481 }
482
483 java_binary_host {
484 name: "bar",
485 srcs: ["b.java"],
486 static_libs: ["foo"],
Colin Cross89226d92020-10-09 19:00:54 -0700487 jni_libs: ["libjni"],
488 }
489
490 cc_library_shared {
491 name: "libjni",
492 host_supported: true,
493 device_supported: false,
494 stl: "none",
Colin Cross6b4a32d2017-12-05 13:42:45 -0800495 }
496 `)
497
498 buildOS := android.BuildOs.String()
499
500 bar := ctx.ModuleForTests("bar", buildOS+"_common")
501 barJar := bar.Output("bar.jar").Output.String()
502 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
503 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
504
Colin Cross89226d92020-10-09 19:00:54 -0700505 libjni := ctx.ModuleForTests("libjni", buildOS+"_x86_64_shared")
506 libjniSO := libjni.Rule("Cp").Output.String()
507
Colin Cross6b4a32d2017-12-05 13:42:45 -0800508 // Test that the install binary wrapper depends on the installed jar file
Colin Crossc179ea62020-10-09 10:54:15 -0700509 if g, w := barWrapperDeps, barJar; !android.InList(w, g) {
510 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800511 }
Colin Cross89226d92020-10-09 19:00:54 -0700512
513 // Test that the install binary wrapper depends on the installed JNI libraries
514 if g, w := barWrapperDeps, libjniSO; !android.InList(w, g) {
515 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800516 }
Alex Humesky2070e322020-06-09 20:23:08 -0400517}
Colin Cross6b4a32d2017-12-05 13:42:45 -0800518
Alex Humesky2070e322020-06-09 20:23:08 -0400519func TestHostBinaryNoJavaDebugInfoOverride(t *testing.T) {
520 bp := `
521 java_library {
522 name: "target_library",
523 srcs: ["a.java"],
524 }
525
526 java_binary_host {
527 name: "host_binary",
528 srcs: ["b.java"],
529 }
530 `
531 config := testConfig(nil, bp, nil)
532 config.TestProductVariables.MinimizeJavaDebugInfo = proptools.BoolPtr(true)
533
534 ctx, _ := testJavaWithConfig(t, config)
535
Liz Kammer7941b302020-07-28 13:27:34 -0700536 // first, check that the -g flag is added to target modules
Alex Humesky2070e322020-06-09 20:23:08 -0400537 targetLibrary := ctx.ModuleForTests("target_library", "android_common")
538 targetJavaFlags := targetLibrary.Module().VariablesForTests()["javacFlags"]
539 if !strings.Contains(targetJavaFlags, "-g:source,lines") {
540 t.Errorf("target library javac flags %v should contain "+
541 "-g:source,lines override with MinimizeJavaDebugInfo", targetJavaFlags)
542 }
543
544 // check that -g is not overridden for host modules
545 buildOS := android.BuildOs.String()
546 hostBinary := ctx.ModuleForTests("host_binary", buildOS+"_common")
547 hostJavaFlags := hostBinary.Module().VariablesForTests()["javacFlags"]
548 if strings.Contains(hostJavaFlags, "-g:source,lines") {
549 t.Errorf("java_binary_host javac flags %v should not have "+
550 "-g:source,lines override with MinimizeJavaDebugInfo", hostJavaFlags)
551 }
Colin Cross6b4a32d2017-12-05 13:42:45 -0800552}
553
Colin Cross72bb3632017-07-13 16:23:21 -0700554func TestPrebuilts(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700555 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700556 java_library {
557 name: "foo",
Paul Duffin91547182019-11-12 19:39:36 +0000558 srcs: ["a.java", ":stubs-source"],
Paul Duffinfcfd7912020-01-31 17:54:30 +0000559 libs: ["bar", "sdklib"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700560 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700561 }
562
Colin Cross74d73e22017-08-02 11:05:49 -0700563 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700564 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700565 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700566 }
567
Colin Cross74d73e22017-08-02 11:05:49 -0700568 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700569 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700570 jars: ["b.jar"],
Liz Kammerd6c31d22020-08-05 15:40:41 -0700571 sdk_version: "current",
572 compile_dex: true,
Colin Cross72bb3632017-07-13 16:23:21 -0700573 }
Colin Cross42be7612019-02-21 18:12:14 -0800574
575 dex_import {
576 name: "qux",
577 jars: ["b.jar"],
578 }
Colin Cross79c7c262019-04-17 11:11:46 -0700579
580 java_sdk_library_import {
Paul Duffin56d44902020-01-31 13:36:25 +0000581 name: "sdklib",
582 public: {
583 jars: ["c.jar"],
584 },
585 }
586
Paul Duffin91547182019-11-12 19:39:36 +0000587 prebuilt_stubs_sources {
588 name: "stubs-source",
Paul Duffin9b478b02019-12-10 13:41:51 +0000589 srcs: ["stubs/sources"],
Paul Duffin91547182019-11-12 19:39:36 +0000590 }
Paul Duffin1b82e6a2019-12-03 18:06:47 +0000591
592 java_test_import {
593 name: "test",
594 jars: ["a.jar"],
595 test_suites: ["cts"],
596 test_config: "AndroidTest.xml",
597 }
Colin Cross72bb3632017-07-13 16:23:21 -0700598 `)
599
Paul Duffin9b478b02019-12-10 13:41:51 +0000600 fooModule := ctx.ModuleForTests("foo", "android_common")
601 javac := fooModule.Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700602 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Liz Kammerd6c31d22020-08-05 15:40:41 -0700603 barModule := ctx.ModuleForTests("bar", "android_common")
604 barJar := barModule.Rule("combineJar").Output
605 bazModule := ctx.ModuleForTests("baz", "android_common")
606 bazJar := bazModule.Rule("combineJar").Output
Colin Cross79c7c262019-04-17 11:11:46 -0700607 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700608
Paul Duffin9b478b02019-12-10 13:41:51 +0000609 fooLibrary := fooModule.Module().(*Library)
610 assertDeepEquals(t, "foo java sources incorrect",
611 []string{"a.java"}, fooLibrary.compiledJavaSrcs.Strings())
Paul Duffin91547182019-11-12 19:39:36 +0000612
Paul Duffin9b478b02019-12-10 13:41:51 +0000613 assertDeepEquals(t, "foo java source jars incorrect",
614 []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"},
615 android.NormalizePathsForTesting(fooLibrary.compiledSrcJars))
Paul Duffin91547182019-11-12 19:39:36 +0000616
Colin Cross37f6d792018-07-12 12:28:41 -0700617 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
618 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700619 }
620
Liz Kammerd6c31d22020-08-05 15:40:41 -0700621 barDexJar := barModule.Module().(*Import).DexJarBuildPath()
622 if barDexJar != nil {
623 t.Errorf("bar dex jar build path expected to be nil, got %q", barDexJar)
624 }
625
Colin Cross79c7c262019-04-17 11:11:46 -0700626 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
627 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
628 }
629
Colin Cross37f6d792018-07-12 12:28:41 -0700630 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
631 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700632 }
Colin Cross42be7612019-02-21 18:12:14 -0800633
Liz Kammerd6c31d22020-08-05 15:40:41 -0700634 bazDexJar := bazModule.Module().(*Import).DexJarBuildPath().String()
635 expectedDexJar := buildDir + "/.intermediates/baz/android_common/dex/baz.jar"
636 if bazDexJar != expectedDexJar {
637 t.Errorf("baz dex jar build path expected %q, got %q", expectedDexJar, bazDexJar)
638 }
639
Colin Cross42be7612019-02-21 18:12:14 -0800640 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Colin Cross72bb3632017-07-13 16:23:21 -0700641}
642
Paul Duffin9b478b02019-12-10 13:41:51 +0000643func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) {
644 if !reflect.DeepEqual(expected, actual) {
645 t.Errorf("%s: expected %q, found %q", message, expected, actual)
646 }
647}
648
Paul Duffin1a393322020-11-18 16:36:47 +0000649func TestPrebuiltStubsSources(t *testing.T) {
650 test := func(t *testing.T, sourcesPath string, expectedInputs []string) {
651 ctx, _ := testJavaWithFS(t, fmt.Sprintf(`
652prebuilt_stubs_sources {
653 name: "stubs-source",
654 srcs: ["%s"],
655}`, sourcesPath), map[string][]byte{
656 "stubs/sources/pkg/A.java": nil,
657 "stubs/sources/pkg/B.java": nil,
658 })
659
660 zipSrc := ctx.ModuleForTests("stubs-source", "android_common").Rule("zip_src")
661 if expected, actual := expectedInputs, zipSrc.Inputs.Strings(); !reflect.DeepEqual(expected, actual) {
662 t.Errorf("mismatch of inputs to soong_zip: expected %q, actual %q", expected, actual)
663 }
664 }
665
666 t.Run("empty/missing directory", func(t *testing.T) {
667 test(t, "empty-directory", []string{})
668 })
669
670 t.Run("non-empty set of sources", func(t *testing.T) {
671 test(t, "stubs/sources", []string{
672 "stubs/sources/pkg/A.java",
673 "stubs/sources/pkg/B.java",
674 })
675 })
676}
677
Paul Duffin56d44902020-01-31 13:36:25 +0000678func TestJavaSdkLibraryImport(t *testing.T) {
679 ctx, _ := testJava(t, `
680 java_library {
681 name: "foo",
682 srcs: ["a.java"],
683 libs: ["sdklib"],
684 sdk_version: "current",
685 }
686
687 java_library {
688 name: "foo.system",
689 srcs: ["a.java"],
690 libs: ["sdklib"],
691 sdk_version: "system_current",
692 }
693
694 java_library {
695 name: "foo.test",
696 srcs: ["a.java"],
697 libs: ["sdklib"],
698 sdk_version: "test_current",
699 }
700
701 java_sdk_library_import {
702 name: "sdklib",
703 public: {
704 jars: ["a.jar"],
705 },
706 system: {
707 jars: ["b.jar"],
708 },
709 test: {
710 jars: ["c.jar"],
Paul Duffin0f8faff2020-05-20 16:18:00 +0100711 stub_srcs: ["c.java"],
Paul Duffin56d44902020-01-31 13:36:25 +0000712 },
713 }
714 `)
715
716 for _, scope := range []string{"", ".system", ".test"} {
717 fooModule := ctx.ModuleForTests("foo"+scope, "android_common")
718 javac := fooModule.Rule("javac")
719
720 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs"+scope, "android_common").Rule("combineJar").Output
721 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
722 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
723 }
724 }
Paul Duffinca8d9a52020-06-26 22:20:25 +0100725
Paul Duffincee7e662020-07-09 17:32:57 +0100726 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100727 `prebuilt_sdklib.stubs`,
728 `prebuilt_sdklib.stubs.source.test`,
729 `prebuilt_sdklib.stubs.system`,
730 `prebuilt_sdklib.stubs.test`,
731 })
732}
733
734func TestJavaSdkLibraryImport_WithSource(t *testing.T) {
735 ctx, _ := testJava(t, `
736 java_sdk_library {
737 name: "sdklib",
738 srcs: ["a.java"],
739 sdk_version: "none",
740 system_modules: "none",
741 public: {
742 enabled: true,
743 },
744 }
745
746 java_sdk_library_import {
747 name: "sdklib",
748 public: {
749 jars: ["a.jar"],
750 },
751 }
752 `)
753
Paul Duffincee7e662020-07-09 17:32:57 +0100754 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100755 `dex2oatd`,
756 `prebuilt_sdklib`,
757 `sdklib.impl`,
758 `sdklib.stubs`,
759 `sdklib.stubs.source`,
760 `sdklib.xml`,
761 })
762
Paul Duffincee7e662020-07-09 17:32:57 +0100763 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffin44f1d842020-06-26 20:17:02 +0100764 `prebuilt_sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100765 `sdklib.impl`,
766 // This should be prebuilt_sdklib.stubs but is set to sdklib.stubs because the
767 // dependency is added after prebuilts may have been renamed and so has to use
768 // the renamed name.
Paul Duffinca8d9a52020-06-26 22:20:25 +0100769 `sdklib.xml`,
770 })
771}
772
773func TestJavaSdkLibraryImport_Preferred(t *testing.T) {
774 ctx, _ := testJava(t, `
775 java_sdk_library {
776 name: "sdklib",
777 srcs: ["a.java"],
778 sdk_version: "none",
779 system_modules: "none",
780 public: {
781 enabled: true,
782 },
783 }
784
785 java_sdk_library_import {
786 name: "sdklib",
787 prefer: true,
788 public: {
789 jars: ["a.jar"],
790 },
791 }
792 `)
793
Paul Duffincee7e662020-07-09 17:32:57 +0100794 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100795 `dex2oatd`,
796 `prebuilt_sdklib`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100797 `sdklib.impl`,
Paul Duffin80342d72020-06-26 22:08:43 +0100798 `sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100799 `sdklib.stubs.source`,
800 `sdklib.xml`,
801 })
802
Paul Duffincee7e662020-07-09 17:32:57 +0100803 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100804 `prebuilt_sdklib.stubs`,
805 `sdklib.impl`,
806 `sdklib.xml`,
807 })
Paul Duffin56d44902020-01-31 13:36:25 +0000808}
809
Colin Cross89536d42017-07-07 14:35:50 -0700810func TestDefaults(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700811 ctx, _ := testJava(t, `
Colin Cross89536d42017-07-07 14:35:50 -0700812 java_defaults {
813 name: "defaults",
814 srcs: ["a.java"],
815 libs: ["bar"],
816 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -0700817 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700818 }
819
820 java_library {
821 name: "foo",
822 defaults: ["defaults"],
823 }
824
825 java_library {
826 name: "bar",
827 srcs: ["b.java"],
828 }
829
830 java_library {
831 name: "baz",
832 srcs: ["c.java"],
833 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700834
835 android_test {
836 name: "atestOptimize",
837 defaults: ["defaults"],
838 optimize: {enabled: true},
839 }
840
841 android_test {
842 name: "atestNoOptimize",
843 defaults: ["defaults"],
844 }
845
846 android_test {
847 name: "atestDefault",
848 srcs: ["a.java"],
849 }
Colin Cross89536d42017-07-07 14:35:50 -0700850 `)
851
Colin Cross4c428df2017-09-15 17:36:05 -0700852 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700853 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -0700854
855 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
856 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
857 }
858
Nan Zhanged19fc32017-10-19 13:06:22 -0700859 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
860 if !strings.Contains(javac.Args["classpath"], barTurbine) {
861 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -0700862 }
863
Colin Cross1ee23172017-10-18 14:44:18 -0700864 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -0700865 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
866 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -0700867 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700868
869 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
870 if atestOptimize.Output == nil {
871 t.Errorf("atestOptimize should optimize APK")
872 }
873
874 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
875 if atestNoOptimize.Output == nil {
876 t.Errorf("atestNoOptimize should not optimize APK")
877 }
878
879 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("r8")
880 if atestDefault.Output == nil {
881 t.Errorf("atestDefault should optimize APK")
882 }
Colin Cross89536d42017-07-07 14:35:50 -0700883}
884
Colin Cross0f37af02017-09-27 17:42:05 -0700885func TestResources(t *testing.T) {
886 var table = []struct {
887 name string
888 prop string
889 extra string
890 args string
891 }{
892 {
Colin Crossaf9c55b2017-10-03 14:50:08 -0700893 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -0700894 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -0800895 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700896 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700897 },
898 {
899 // Test that a module with java_resources includes the files
900 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -0700901 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
902 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700903 },
904 {
905 // Test that a module with a filegroup in java_resources includes the files with the
906 // path prefix
907 name: "resource filegroup",
908 prop: `java_resources: [":foo-res"]`,
909 extra: `
910 filegroup {
911 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -0800912 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -0700913 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -0700914 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700915 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700916 },
917 {
Colin Cross0ead1d72018-04-10 13:07:42 -0700918 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
919 name: "wildcard dirs",
920 prop: `java_resource_dirs: ["java-res/*"]`,
921 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
922 },
923 {
924 // Test that a module exclude_java_resource_dirs excludes the files
925 name: "wildcard dirs",
926 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
927 args: "-C java-res/a -f java-res/a/a",
928 },
Colin Crosscedd4762018-09-13 11:26:19 -0700929 {
930 // Test wildcards in java_resources
931 name: "wildcard files",
932 prop: `java_resources: ["java-res/**/*"]`,
933 args: "-C . -f java-res/a/a -f java-res/b/b",
934 },
935 {
936 // Test exclude_java_resources with java_resources
937 name: "wildcard files with exclude",
938 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
939 args: "-C . -f java-res/a/a",
940 },
941 {
942 // Test exclude_java_resources with java_resource_dirs
943 name: "resource dirs with exclude files",
944 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
945 args: "-C java-res -f java-res/a/a",
946 },
947 {
948 // Test exclude_java_resource_dirs with java_resource_dirs
949 name: "resource dirs with exclude files",
950 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
951 args: "-C java-res -f java-res/a/a -f java-res/b/b",
952 },
Colin Cross0f37af02017-09-27 17:42:05 -0700953 }
954
955 for _, test := range table {
956 t.Run(test.name, func(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700957 ctx, _ := testJavaWithFS(t, `
Colin Cross0f37af02017-09-27 17:42:05 -0700958 java_library {
959 name: "foo",
960 srcs: [
961 "a.java",
962 "b.java",
963 "c.java",
964 ],
965 `+test.prop+`,
966 }
Colin Cross238c1f32020-06-07 16:58:18 -0700967 `+test.extra,
968 map[string][]byte{
969 "java-res/a/a": nil,
970 "java-res/b/b": nil,
971 "java-res2/a": nil,
972 },
973 )
Colin Cross0f37af02017-09-27 17:42:05 -0700974
Colin Cross331a1212018-08-15 20:40:52 -0700975 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -0700976 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -0700977
978 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
979 t.Errorf("foo combined jars %v does not contain %q",
980 foo.Inputs.Strings(), fooRes.Output.String())
981 }
982
Colin Crossaf9c55b2017-10-03 14:50:08 -0700983 if fooRes.Args["jarArgs"] != test.args {
984 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -0700985 fooRes.Args["jarArgs"], test.args)
986 }
987 })
988 }
989}
990
Colin Cross0c4ce212019-05-03 15:28:19 -0700991func TestIncludeSrcs(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700992 ctx, _ := testJavaWithFS(t, `
Colin Cross0c4ce212019-05-03 15:28:19 -0700993 java_library {
994 name: "foo",
995 srcs: [
996 "a.java",
997 "b.java",
998 "c.java",
999 ],
1000 include_srcs: true,
1001 }
1002
1003 java_library {
1004 name: "bar",
1005 srcs: [
1006 "a.java",
1007 "b.java",
1008 "c.java",
1009 ],
1010 java_resource_dirs: ["java-res"],
1011 include_srcs: true,
1012 }
Colin Cross238c1f32020-06-07 16:58:18 -07001013 `, map[string][]byte{
1014 "java-res/a/a": nil,
1015 "java-res/b/b": nil,
1016 "java-res2/a": nil,
1017 })
Colin Cross0c4ce212019-05-03 15:28:19 -07001018
1019 // Test a library with include_srcs: true
1020 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
1021 fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar")
1022
1023 if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) {
1024 t.Errorf("foo combined jars %v does not contain %q", w, g)
1025 }
1026
1027 if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
1028 t.Errorf("foo source jar args %q is not %q", w, g)
1029 }
1030
1031 // Test a library with include_srcs: true and resources
1032 bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar")
1033 barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar")
1034 barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar")
1035 barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar")
1036
1037 if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
1038 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
1039 }
1040
1041 if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
1042 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
1043 }
1044
1045 if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) {
1046 t.Errorf("bar combined jars %v does not contain %q", w, g)
1047 }
1048
1049 if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
1050 t.Errorf("bar source jar args %q is not %q", w, g)
1051 }
1052
1053 if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w {
1054 t.Errorf("bar resource jar args %q is not %q", w, g)
1055 }
1056}
1057
Colin Cross54190b32017-10-09 15:34:10 -07001058func TestGeneratedSources(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001059 ctx, _ := testJavaWithFS(t, `
Colin Cross54190b32017-10-09 15:34:10 -07001060 java_library {
1061 name: "foo",
1062 srcs: [
1063 "a*.java",
1064 ":gen",
1065 "b*.java",
1066 ],
1067 }
1068
1069 genrule {
1070 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -08001071 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -07001072 out: ["gen.java"],
1073 }
Colin Cross238c1f32020-06-07 16:58:18 -07001074 `, map[string][]byte{
1075 "a.java": nil,
1076 "b.java": nil,
1077 })
Colin Cross54190b32017-10-09 15:34:10 -07001078
1079 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1080 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
1081
Colin Cross15e86d92017-10-20 15:07:08 -07001082 if filepath.Base(genrule.Output.String()) != "gen.java" {
1083 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -07001084 }
1085
1086 if len(javac.Inputs) != 3 ||
1087 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -07001088 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -07001089 javac.Inputs[2].String() != "b.java" {
1090 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
1091 }
1092}
1093
Nan Zhang61eaedb2017-11-02 13:28:15 -07001094func TestTurbine(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001095 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001096 java_library {
1097 name: "foo",
1098 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +09001099 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001100 }
1101
1102 java_library {
1103 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -08001104 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -07001105 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +09001106 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001107 }
1108
1109 java_library {
1110 name: "baz",
1111 srcs: ["c.java"],
1112 libs: ["bar"],
1113 sdk_version: "14",
1114 }
1115 `)
1116
1117 fooTurbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine")
1118 barTurbine := ctx.ModuleForTests("bar", "android_common").Rule("turbine")
1119 barJavac := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1120 barTurbineCombined := ctx.ModuleForTests("bar", "android_common").Description("for turbine")
1121 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1122
1123 if len(fooTurbine.Inputs) != 1 || fooTurbine.Inputs[0].String() != "a.java" {
1124 t.Errorf(`foo inputs %v != ["a.java"]`, fooTurbine.Inputs)
1125 }
1126
1127 fooHeaderJar := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
1128 if !strings.Contains(barTurbine.Args["classpath"], fooHeaderJar) {
1129 t.Errorf("bar turbine classpath %v does not contain %q", barTurbine.Args["classpath"], fooHeaderJar)
1130 }
1131 if !strings.Contains(barJavac.Args["classpath"], fooHeaderJar) {
1132 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], fooHeaderJar)
1133 }
1134 if len(barTurbineCombined.Inputs) != 2 || barTurbineCombined.Inputs[1].String() != fooHeaderJar {
1135 t.Errorf("bar turbine combineJar inputs %v does not contain %q", barTurbineCombined.Inputs, fooHeaderJar)
1136 }
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001137 if !strings.Contains(bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") {
Nan Zhang61eaedb2017-11-02 13:28:15 -07001138 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001139 "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -07001140 }
1141}
1142
1143func TestSharding(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001144 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001145 java_library {
1146 name: "bar",
1147 srcs: ["a.java","b.java","c.java"],
1148 javac_shard_size: 1
1149 }
1150 `)
1151
1152 barHeaderJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
1153 for i := 0; i < 3; i++ {
1154 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
1155 if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) {
1156 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar)
1157 }
1158 }
1159}
1160
Nan Zhang581fd212018-01-10 16:06:12 -08001161func TestDroiddoc(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001162 ctx, _ := testJavaWithFS(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001163 droiddoc_exported_dir {
Dan Willemsencc090972018-02-26 14:33:31 -08001164 name: "droiddoc-templates-sdk",
1165 path: ".",
1166 }
Jiyong Park29074592019-07-07 16:27:47 +09001167 filegroup {
1168 name: "bar-doc-aidl-srcs",
1169 srcs: ["bar-doc/IBar.aidl"],
1170 path: "bar-doc",
1171 }
Liz Kammere1ab2502020-09-10 15:29:25 +00001172 droidstubs {
1173 name: "bar-stubs",
Liz Kammer3a55c912020-08-14 12:14:02 -07001174 srcs: [
Steve Kim3666c702020-09-01 17:58:01 +00001175 "bar-doc/a.java",
Liz Kammer3a55c912020-08-14 12:14:02 -07001176 ],
Steve Kim3666c702020-09-01 17:58:01 +00001177 exclude_srcs: [
1178 "bar-doc/b.java"
1179 ],
Liz Kammere1ab2502020-09-10 15:29:25 +00001180 api_levels_annotations_dirs: [
1181 "droiddoc-templates-sdk",
1182 ],
1183 api_levels_annotations_enabled: true,
1184 }
1185 droiddoc {
1186 name: "bar-doc",
1187 srcs: [
1188 ":bar-stubs",
1189 "bar-doc/IFoo.aidl",
1190 ":bar-doc-aidl-srcs",
1191 ],
Dan Willemsencc090972018-02-26 14:33:31 -08001192 custom_template: "droiddoc-templates-sdk",
Nan Zhang581fd212018-01-10 16:06:12 -08001193 hdf: [
1194 "android.whichdoc offline",
1195 ],
1196 knowntags: [
1197 "bar-doc/known_oj_tags.txt",
1198 ],
1199 proofread_file: "libcore-proofread.txt",
1200 todo_file: "libcore-docs-todo.html",
Liz Kammer585cac22020-07-06 09:12:57 -07001201 flags: ["-offlinemode -title \"libcore\""],
Nan Zhang581fd212018-01-10 16:06:12 -08001202 }
Colin Cross238c1f32020-06-07 16:58:18 -07001203 `,
1204 map[string][]byte{
1205 "bar-doc/a.java": nil,
1206 "bar-doc/b.java": nil,
1207 })
Liz Kammere1ab2502020-09-10 15:29:25 +00001208 barStubs := ctx.ModuleForTests("bar-stubs", "android_common")
1209 barStubsOutputs, err := barStubs.Module().(*Droidstubs).OutputFiles("")
1210 if err != nil {
1211 t.Errorf("Unexpected error %q retrieving \"bar-stubs\" output file", err)
1212 }
1213 if len(barStubsOutputs) != 1 {
1214 t.Errorf("Expected one output from \"bar-stubs\" got %s", barStubsOutputs)
Liz Kammer1e2ee122020-07-30 15:07:22 -07001215 }
Nan Zhang581fd212018-01-10 16:06:12 -08001216
Liz Kammere1ab2502020-09-10 15:29:25 +00001217 barStubsOutput := barStubsOutputs[0]
1218 barDoc := ctx.ModuleForTests("bar-doc", "android_common")
1219 javaDoc := barDoc.Rule("javadoc")
1220 if g, w := javaDoc.Implicits.Strings(), barStubsOutput.String(); !inList(w, g) {
1221 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
Jiyong Park29074592019-07-07 16:27:47 +09001222 }
1223
Liz Kammere1ab2502020-09-10 15:29:25 +00001224 expected := "-sourcepath " + buildDir + "/.intermediates/bar-doc/android_common/srcjars "
1225 if !strings.Contains(javaDoc.RuleParams.Command, expected) {
1226 t.Errorf("bar-doc command does not contain flag %q, but should\n%q", expected, javaDoc.RuleParams.Command)
1227 }
1228
1229 aidl := barDoc.Rule("aidl")
1230 if g, w := javaDoc.Implicits.Strings(), aidl.Output.String(); !inList(w, g) {
Colin Crossc0806172019-06-14 18:51:47 -07001231 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
1232 }
1233
1234 if g, w := aidl.Implicits.Strings(), []string{"bar-doc/IBar.aidl", "bar-doc/IFoo.aidl"}; !reflect.DeepEqual(w, g) {
1235 t.Errorf("aidl inputs must be %q, but was %q", w, g)
Jiyong Park1e440682018-05-23 18:42:04 +09001236 }
Nan Zhang581fd212018-01-10 16:06:12 -08001237}
1238
Liz Kammer585cac22020-07-06 09:12:57 -07001239func TestDroiddocArgsAndFlagsCausesError(t *testing.T) {
1240 testJavaError(t, "flags is set. Cannot set args", `
1241 droiddoc_exported_dir {
1242 name: "droiddoc-templates-sdk",
1243 path: ".",
1244 }
1245 filegroup {
1246 name: "bar-doc-aidl-srcs",
1247 srcs: ["bar-doc/IBar.aidl"],
1248 path: "bar-doc",
1249 }
Liz Kammere1ab2502020-09-10 15:29:25 +00001250 droidstubs {
1251 name: "bar-stubs",
Liz Kammer3a55c912020-08-14 12:14:02 -07001252 srcs: [
Steve Kim3666c702020-09-01 17:58:01 +00001253 "bar-doc/a.java",
Liz Kammer3a55c912020-08-14 12:14:02 -07001254 ],
Steve Kim3666c702020-09-01 17:58:01 +00001255 exclude_srcs: [
1256 "bar-doc/b.java"
1257 ],
Liz Kammere1ab2502020-09-10 15:29:25 +00001258 api_levels_annotations_dirs: [
1259 "droiddoc-templates-sdk",
1260 ],
1261 api_levels_annotations_enabled: true,
1262 }
1263 droiddoc {
1264 name: "bar-doc",
1265 srcs: [
1266 ":bar-stubs",
1267 "bar-doc/IFoo.aidl",
1268 ":bar-doc-aidl-srcs",
1269 ],
Liz Kammer585cac22020-07-06 09:12:57 -07001270 custom_template: "droiddoc-templates-sdk",
1271 hdf: [
1272 "android.whichdoc offline",
1273 ],
1274 knowntags: [
1275 "bar-doc/known_oj_tags.txt",
1276 ],
1277 proofread_file: "libcore-proofread.txt",
1278 todo_file: "libcore-docs-todo.html",
1279 flags: ["-offlinemode -title \"libcore\""],
1280 args: "-offlinemode -title \"libcore\"",
1281 }
1282 `)
1283}
1284
Liz Kammer3d894b72020-08-04 09:55:13 -07001285func TestDroidstubs(t *testing.T) {
1286 ctx, _ := testJavaWithFS(t, `
1287 droiddoc_exported_dir {
Anton Hansson52ac73d2020-10-26 09:57:40 +00001288 name: "droiddoc-templates-sdk",
1289 path: ".",
Liz Kammer3d894b72020-08-04 09:55:13 -07001290 }
1291
1292 droidstubs {
Anton Hansson52ac73d2020-10-26 09:57:40 +00001293 name: "bar-stubs",
1294 srcs: ["bar-doc/a.java"],
1295 api_levels_annotations_dirs: ["droiddoc-templates-sdk"],
1296 api_levels_annotations_enabled: true,
Liz Kammer3d894b72020-08-04 09:55:13 -07001297 }
1298
1299 droidstubs {
Anton Hansson52ac73d2020-10-26 09:57:40 +00001300 name: "bar-stubs-other",
1301 srcs: ["bar-doc/a.java"],
1302 high_mem: true,
1303 api_levels_annotations_dirs: ["droiddoc-templates-sdk"],
1304 api_levels_annotations_enabled: true,
1305 api_levels_jar_filename: "android.other.jar",
Liz Kammer3d894b72020-08-04 09:55:13 -07001306 }
1307 `,
1308 map[string][]byte{
1309 "bar-doc/a.java": nil,
1310 })
1311 testcases := []struct {
1312 moduleName string
1313 expectedJarFilename string
Anton Hansson52ac73d2020-10-26 09:57:40 +00001314 high_mem bool
Liz Kammer3d894b72020-08-04 09:55:13 -07001315 }{
1316 {
1317 moduleName: "bar-stubs",
1318 expectedJarFilename: "android.jar",
Anton Hansson52ac73d2020-10-26 09:57:40 +00001319 high_mem: false,
Liz Kammer3d894b72020-08-04 09:55:13 -07001320 },
1321 {
1322 moduleName: "bar-stubs-other",
1323 expectedJarFilename: "android.other.jar",
Anton Hansson52ac73d2020-10-26 09:57:40 +00001324 high_mem: true,
Liz Kammer3d894b72020-08-04 09:55:13 -07001325 },
1326 }
1327 for _, c := range testcases {
1328 m := ctx.ModuleForTests(c.moduleName, "android_common")
1329 metalava := m.Rule("metalava")
Anton Hansson52ac73d2020-10-26 09:57:40 +00001330 rp := metalava.RuleParams
Liz Kammer3d894b72020-08-04 09:55:13 -07001331 expected := "--android-jar-pattern ./%/public/" + c.expectedJarFilename
Anton Hansson52ac73d2020-10-26 09:57:40 +00001332 if actual := rp.Command; !strings.Contains(actual, expected) {
Liz Kammer3d894b72020-08-04 09:55:13 -07001333 t.Errorf("For %q, expected metalava argument %q, but was not found %q", c.moduleName, expected, actual)
1334 }
Anton Hansson52ac73d2020-10-26 09:57:40 +00001335
1336 if actual := rp.Pool != nil && strings.Contains(rp.Pool.String(), "highmem"); actual != c.high_mem {
1337 t.Errorf("Expected %q high_mem to be %v, was %v", c.moduleName, c.high_mem, actual)
1338 }
Liz Kammer3d894b72020-08-04 09:55:13 -07001339 }
1340}
1341
Paul Duffin83a2d962019-11-19 19:44:10 +00001342func TestDroidstubsWithSystemModules(t *testing.T) {
1343 ctx, _ := testJava(t, `
1344 droidstubs {
1345 name: "stubs-source-system-modules",
1346 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001347 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001348 ],
1349 sdk_version: "none",
1350 system_modules: "source-system-modules",
1351 }
1352
1353 java_library {
1354 name: "source-jar",
1355 srcs: [
1356 "a.java",
1357 ],
1358 }
1359
1360 java_system_modules {
1361 name: "source-system-modules",
1362 libs: ["source-jar"],
1363 }
1364
1365 droidstubs {
1366 name: "stubs-prebuilt-system-modules",
1367 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001368 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001369 ],
1370 sdk_version: "none",
1371 system_modules: "prebuilt-system-modules",
1372 }
1373
1374 java_import {
1375 name: "prebuilt-jar",
1376 jars: ["a.jar"],
1377 }
1378
1379 java_system_modules_import {
1380 name: "prebuilt-system-modules",
1381 libs: ["prebuilt-jar"],
1382 }
1383 `)
1384
1385 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-source-system-modules", "source-jar.jar")
1386
1387 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-prebuilt-system-modules", "prebuilt-jar.jar")
1388}
1389
1390func checkSystemModulesUseByDroidstubs(t *testing.T, ctx *android.TestContext, moduleName string, systemJar string) {
1391 metalavaRule := ctx.ModuleForTests(moduleName, "android_common").Rule("metalava")
1392 var systemJars []string
1393 for _, i := range metalavaRule.Implicits {
1394 systemJars = append(systemJars, i.Base())
1395 }
Ramy Medhatc7965cd2020-04-30 03:08:37 -04001396 if len(systemJars) < 1 || systemJars[0] != systemJar {
Paul Duffin83a2d962019-11-19 19:44:10 +00001397 t.Errorf("inputs of %q must be []string{%q}, but was %#v.", moduleName, systemJar, systemJars)
1398 }
1399}
1400
Colin Cross54250902017-12-05 09:28:08 -08001401func TestJarGenrules(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001402 ctx, _ := testJava(t, `
Colin Cross54250902017-12-05 09:28:08 -08001403 java_library {
1404 name: "foo",
1405 srcs: ["a.java"],
1406 }
1407
1408 java_genrule {
1409 name: "jargen",
1410 tool_files: ["b.java"],
1411 cmd: "$(location b.java) $(in) $(out)",
1412 out: ["jargen.jar"],
1413 srcs: [":foo"],
1414 }
1415
1416 java_library {
1417 name: "bar",
1418 static_libs: ["jargen"],
1419 srcs: ["c.java"],
1420 }
1421
1422 java_library {
1423 name: "baz",
1424 libs: ["jargen"],
1425 srcs: ["c.java"],
1426 }
1427 `)
1428
1429 foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar")
1430 jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar")
1431 bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar")
1432 baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar")
1433 barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar")
1434
Colin Cross3d680512020-11-13 16:23:53 -08001435 if g, w := jargen.Implicits.Strings(), foo.Output.String(); !android.InList(w, g) {
1436 t.Errorf("expected jargen inputs [%q], got %q", w, g)
Colin Cross54250902017-12-05 09:28:08 -08001437 }
1438
1439 if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) {
1440 t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String())
1441 }
1442
1443 if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) {
1444 t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String())
1445 }
1446
1447 if len(barCombined.Inputs) != 2 ||
1448 barCombined.Inputs[0].String() != bar.Output.String() ||
1449 barCombined.Inputs[1].String() != jargen.Output.String() {
1450 t.Errorf("bar combined jar inputs %v is not [%q, %q]",
1451 barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String())
1452 }
1453}
1454
Nan Zhang27e284d2018-02-09 21:03:53 +00001455func TestExcludeFileGroupInSrcs(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001456 ctx, _ := testJava(t, `
Nan Zhang27e284d2018-02-09 21:03:53 +00001457 java_library {
1458 name: "foo",
1459 srcs: ["a.java", ":foo-srcs"],
1460 exclude_srcs: ["a.java", ":foo-excludes"],
1461 }
1462
1463 filegroup {
1464 name: "foo-srcs",
1465 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
1466 }
1467
1468 filegroup {
1469 name: "foo-excludes",
1470 srcs: ["java-fg/a.java", "java-fg/b.java"],
1471 }
1472 `)
1473
1474 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1475
1476 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
1477 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
1478 }
1479}
Jiyong Parkc678ad32018-04-10 13:07:10 +09001480
Paul Duffin52d398a2019-06-11 12:31:14 +01001481func TestJavaLibrary(t *testing.T) {
Colin Cross98be1bb2019-12-13 20:41:13 -08001482 config := testConfig(nil, "", map[string][]byte{
Paul Duffin52d398a2019-06-11 12:31:14 +01001483 "libcore/Android.bp": []byte(`
1484 java_library {
1485 name: "core",
1486 sdk_version: "none",
1487 system_modules: "none",
Paul Duffinaa55f742020-10-06 17:20:13 +01001488 }
1489
1490 filegroup {
1491 name: "core-jar",
1492 srcs: [":core{.jar}"],
1493 }
1494`),
1495 })
Colin Crossae8600b2020-10-29 17:09:13 -07001496 ctx := testContext(config)
Paul Duffinaa55f742020-10-06 17:20:13 +01001497 run(t, ctx, config)
1498}
1499
1500func TestJavaImport(t *testing.T) {
1501 config := testConfig(nil, "", map[string][]byte{
1502 "libcore/Android.bp": []byte(`
1503 java_import {
1504 name: "core",
1505 sdk_version: "none",
1506 }
1507
1508 filegroup {
1509 name: "core-jar",
1510 srcs: [":core{.jar}"],
1511 }
1512`),
Paul Duffin52d398a2019-06-11 12:31:14 +01001513 })
Colin Crossae8600b2020-10-29 17:09:13 -07001514 ctx := testContext(config)
Paul Duffin52d398a2019-06-11 12:31:14 +01001515 run(t, ctx, config)
1516}
1517
Jiyong Parkc678ad32018-04-10 13:07:10 +09001518func TestJavaSdkLibrary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001519 ctx, _ := testJava(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001520 droiddoc_exported_dir {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001521 name: "droiddoc-templates-sdk",
1522 path: ".",
1523 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001524 java_sdk_library {
1525 name: "foo",
1526 srcs: ["a.java", "b.java"],
1527 api_packages: ["foo"],
1528 }
1529 java_sdk_library {
1530 name: "bar",
1531 srcs: ["a.java", "b.java"],
1532 api_packages: ["bar"],
1533 }
1534 java_library {
1535 name: "baz",
1536 srcs: ["c.java"],
Paul Duffin859fe962020-05-15 10:20:31 +01001537 libs: ["foo", "bar.stubs"],
Jiyong Parkc678ad32018-04-10 13:07:10 +09001538 sdk_version: "system_current",
1539 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001540 java_sdk_library {
1541 name: "barney",
1542 srcs: ["c.java"],
1543 api_only: true,
1544 }
1545 java_sdk_library {
1546 name: "betty",
1547 srcs: ["c.java"],
1548 shared_library: false,
1549 }
Paul Duffin859fe962020-05-15 10:20:31 +01001550 java_sdk_library_import {
1551 name: "quuz",
1552 public: {
1553 jars: ["c.jar"],
1554 },
1555 }
1556 java_sdk_library_import {
1557 name: "fred",
1558 public: {
1559 jars: ["b.jar"],
1560 },
1561 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001562 java_sdk_library_import {
1563 name: "wilma",
1564 public: {
1565 jars: ["b.jar"],
1566 },
1567 shared_library: false,
1568 }
Jiyong Park1be96912018-05-28 18:02:19 +09001569 java_library {
1570 name: "qux",
1571 srcs: ["c.java"],
Paul Duffindfa131e2020-05-15 20:37:11 +01001572 libs: ["baz", "fred", "quuz.stubs", "wilma", "barney", "betty"],
Jiyong Park1be96912018-05-28 18:02:19 +09001573 sdk_version: "system_current",
1574 }
Paul Duffin726d23c2020-01-22 16:30:37 +00001575 java_library {
1576 name: "baz-test",
1577 srcs: ["c.java"],
1578 libs: ["foo"],
1579 sdk_version: "test_current",
1580 }
Paul Duffina2db18f2020-01-22 17:11:15 +00001581 java_library {
1582 name: "baz-29",
1583 srcs: ["c.java"],
1584 libs: ["foo"],
1585 sdk_version: "system_29",
1586 }
Paul Duffinfb6ae5b2020-09-30 15:17:25 +01001587 java_library {
1588 name: "baz-module-30",
1589 srcs: ["c.java"],
1590 libs: ["foo"],
1591 sdk_version: "module_30",
1592 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001593 `)
1594
1595 // check the existence of the internal modules
1596 ctx.ModuleForTests("foo", "android_common")
Paul Duffindd9d0742020-05-08 15:52:37 +01001597 ctx.ModuleForTests(apiScopePublic.stubsLibraryModuleName("foo"), "android_common")
1598 ctx.ModuleForTests(apiScopeSystem.stubsLibraryModuleName("foo"), "android_common")
1599 ctx.ModuleForTests(apiScopeTest.stubsLibraryModuleName("foo"), "android_common")
1600 ctx.ModuleForTests(apiScopePublic.stubsSourceModuleName("foo"), "android_common")
1601 ctx.ModuleForTests(apiScopeSystem.stubsSourceModuleName("foo"), "android_common")
1602 ctx.ModuleForTests(apiScopeTest.stubsSourceModuleName("foo"), "android_common")
Jiyong Parke3833882020-02-17 17:28:10 +09001603 ctx.ModuleForTests("foo"+sdkXmlFileSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +09001604 ctx.ModuleForTests("foo.api.public.28", "")
1605 ctx.ModuleForTests("foo.api.system.28", "")
1606 ctx.ModuleForTests("foo.api.test.28", "")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001607
1608 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1609 // tests if baz is actually linked to the stubs lib
1610 if !strings.Contains(bazJavac.Args["classpath"], "foo.stubs.system.jar") {
1611 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
1612 "foo.stubs.system.jar")
1613 }
1614 // ... and not to the impl lib
Sundong Ahn054b19a2018-10-19 13:46:09 +09001615 if strings.Contains(bazJavac.Args["classpath"], "foo.jar") {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001616 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
Sundong Ahn054b19a2018-10-19 13:46:09 +09001617 "foo.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001618 }
1619 // test if baz is not linked to the system variant of foo
1620 if strings.Contains(bazJavac.Args["classpath"], "foo.stubs.jar") {
1621 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
1622 "foo.stubs.jar")
1623 }
Jiyong Park1be96912018-05-28 18:02:19 +09001624
Paul Duffin726d23c2020-01-22 16:30:37 +00001625 bazTestJavac := ctx.ModuleForTests("baz-test", "android_common").Rule("javac")
1626 // tests if baz-test is actually linked to the test stubs lib
1627 if !strings.Contains(bazTestJavac.Args["classpath"], "foo.stubs.test.jar") {
1628 t.Errorf("baz-test javac classpath %v does not contain %q", bazTestJavac.Args["classpath"],
1629 "foo.stubs.test.jar")
1630 }
1631
Paul Duffina2db18f2020-01-22 17:11:15 +00001632 baz29Javac := ctx.ModuleForTests("baz-29", "android_common").Rule("javac")
1633 // tests if baz-29 is actually linked to the system 29 stubs lib
1634 if !strings.Contains(baz29Javac.Args["classpath"], "prebuilts/sdk/29/system/foo.jar") {
1635 t.Errorf("baz-29 javac classpath %v does not contain %q", baz29Javac.Args["classpath"],
1636 "prebuilts/sdk/29/system/foo.jar")
1637 }
1638
Paul Duffinfb6ae5b2020-09-30 15:17:25 +01001639 bazModule30Javac := ctx.ModuleForTests("baz-module-30", "android_common").Rule("javac")
1640 // tests if "baz-module-30" is actually linked to the module 30 stubs lib
1641 if !strings.Contains(bazModule30Javac.Args["classpath"], "prebuilts/sdk/30/module-lib/foo.jar") {
1642 t.Errorf("baz-module-30 javac classpath %v does not contain %q", bazModule30Javac.Args["classpath"],
1643 "prebuilts/sdk/30/module-lib/foo.jar")
1644 }
1645
Jiyong Park1be96912018-05-28 18:02:19 +09001646 // test if baz has exported SDK lib names foo and bar to qux
1647 qux := ctx.ModuleForTests("qux", "android_common")
1648 if quxLib, ok := qux.Module().(*Library); ok {
Ulya Trafimovichb23d28c2020-10-08 12:53:58 +01001649 sdkLibs := quxLib.ClassLoaderContexts().UsesLibs()
Ulya Trafimovich8cbc5d22020-11-03 15:15:46 +00001650 if w := []string{"foo", "bar", "fred", "quuz"}; !reflect.DeepEqual(w, sdkLibs) {
Paul Duffin859fe962020-05-15 10:20:31 +01001651 t.Errorf("qux should export %q but exports %q", w, sdkLibs)
Jiyong Park1be96912018-05-28 18:02:19 +09001652 }
1653 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001654}
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001655
Anton Hansson7f66efa2020-10-08 14:47:23 +01001656func TestJavaSdkLibrary_StubOrImplOnlyLibs(t *testing.T) {
1657 ctx, _ := testJava(t, `
1658 java_sdk_library {
1659 name: "sdk_lib",
1660 srcs: ["a.java"],
1661 impl_only_libs: ["foo"],
1662 stub_only_libs: ["bar"],
1663 }
1664 java_library {
1665 name: "foo",
1666 srcs: ["a.java"],
1667 sdk_version: "current",
1668 }
1669 java_library {
1670 name: "bar",
1671 srcs: ["a.java"],
1672 sdk_version: "current",
1673 }
1674 `)
1675
1676 for _, implName := range []string{"sdk_lib", "sdk_lib.impl"} {
1677 implJavacCp := ctx.ModuleForTests(implName, "android_common").Rule("javac").Args["classpath"]
1678 if !strings.Contains(implJavacCp, "/foo.jar") || strings.Contains(implJavacCp, "/bar.jar") {
1679 t.Errorf("%v javac classpath %v does not contain foo and not bar", implName, implJavacCp)
1680 }
1681 }
1682 stubName := apiScopePublic.stubsLibraryModuleName("sdk_lib")
1683 stubsJavacCp := ctx.ModuleForTests(stubName, "android_common").Rule("javac").Args["classpath"]
1684 if strings.Contains(stubsJavacCp, "/foo.jar") || !strings.Contains(stubsJavacCp, "/bar.jar") {
1685 t.Errorf("stubs javac classpath %v does not contain bar and not foo", stubsJavacCp)
1686 }
1687}
1688
Paul Duffindaaa3322020-05-26 18:13:57 +01001689func TestJavaSdkLibrary_DoNotAccessImplWhenItIsNotBuilt(t *testing.T) {
1690 ctx, _ := testJava(t, `
1691 java_sdk_library {
1692 name: "foo",
1693 srcs: ["a.java"],
1694 api_only: true,
1695 public: {
1696 enabled: true,
1697 },
1698 }
1699
1700 java_library {
1701 name: "bar",
1702 srcs: ["b.java"],
1703 libs: ["foo"],
1704 }
1705 `)
1706
1707 // The bar library should depend on the stubs jar.
1708 barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1709 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1710 t.Errorf("expected %q, found %#q", expected, actual)
1711 }
1712}
1713
Paul Duffin46dc45a2020-05-14 15:39:10 +01001714func TestJavaSdkLibrary_UseSourcesFromAnotherSdkLibrary(t *testing.T) {
1715 testJava(t, `
1716 java_sdk_library {
1717 name: "foo",
1718 srcs: ["a.java"],
1719 api_packages: ["foo"],
1720 public: {
1721 enabled: true,
1722 },
1723 }
1724
1725 java_library {
1726 name: "bar",
1727 srcs: ["b.java", ":foo{.public.stubs.source}"],
1728 }
1729 `)
1730}
1731
1732func TestJavaSdkLibrary_AccessOutputFiles_MissingScope(t *testing.T) {
1733 testJavaError(t, `"foo" does not provide api scope system`, `
1734 java_sdk_library {
1735 name: "foo",
1736 srcs: ["a.java"],
1737 api_packages: ["foo"],
1738 public: {
1739 enabled: true,
1740 },
1741 }
1742
1743 java_library {
1744 name: "bar",
1745 srcs: ["b.java", ":foo{.system.stubs.source}"],
1746 }
1747 `)
1748}
1749
Paul Duffinca8d9a52020-06-26 22:20:25 +01001750func TestJavaSdkLibrary_Deps(t *testing.T) {
1751 ctx, _ := testJava(t, `
1752 java_sdk_library {
1753 name: "sdklib",
1754 srcs: ["a.java"],
1755 sdk_version: "none",
1756 system_modules: "none",
1757 public: {
1758 enabled: true,
1759 },
1760 }
1761 `)
1762
Paul Duffincee7e662020-07-09 17:32:57 +01001763 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +01001764 `dex2oatd`,
1765 `sdklib.impl`,
1766 `sdklib.stubs`,
1767 `sdklib.stubs.source`,
1768 `sdklib.xml`,
1769 })
1770}
1771
Paul Duffin46dc45a2020-05-14 15:39:10 +01001772func TestJavaSdkLibraryImport_AccessOutputFiles(t *testing.T) {
1773 testJava(t, `
1774 java_sdk_library_import {
1775 name: "foo",
1776 public: {
1777 jars: ["a.jar"],
1778 stub_srcs: ["a.java"],
1779 current_api: "api/current.txt",
1780 removed_api: "api/removed.txt",
1781 },
1782 }
1783
1784 java_library {
1785 name: "bar",
1786 srcs: [":foo{.public.stubs.source}"],
1787 java_resources: [
1788 ":foo{.public.api.txt}",
1789 ":foo{.public.removed-api.txt}",
1790 ],
1791 }
1792 `)
1793}
1794
1795func TestJavaSdkLibraryImport_AccessOutputFiles_Invalid(t *testing.T) {
1796 bp := `
1797 java_sdk_library_import {
1798 name: "foo",
1799 public: {
1800 jars: ["a.jar"],
1801 },
1802 }
1803 `
1804
1805 t.Run("stubs.source", func(t *testing.T) {
1806 testJavaError(t, `stubs.source not available for api scope public`, bp+`
1807 java_library {
1808 name: "bar",
1809 srcs: [":foo{.public.stubs.source}"],
1810 java_resources: [
1811 ":foo{.public.api.txt}",
1812 ":foo{.public.removed-api.txt}",
1813 ],
1814 }
1815 `)
1816 })
1817
1818 t.Run("api.txt", func(t *testing.T) {
1819 testJavaError(t, `api.txt not available for api scope public`, bp+`
1820 java_library {
1821 name: "bar",
1822 srcs: ["a.java"],
1823 java_resources: [
1824 ":foo{.public.api.txt}",
1825 ],
1826 }
1827 `)
1828 })
1829
1830 t.Run("removed-api.txt", func(t *testing.T) {
1831 testJavaError(t, `removed-api.txt not available for api scope public`, bp+`
1832 java_library {
1833 name: "bar",
1834 srcs: ["a.java"],
1835 java_resources: [
1836 ":foo{.public.removed-api.txt}",
1837 ],
1838 }
1839 `)
1840 })
1841}
1842
Paul Duffin3375e352020-04-28 10:44:03 +01001843func TestJavaSdkLibrary_InvalidScopes(t *testing.T) {
1844 testJavaError(t, `module "foo": enabled api scope "system" depends on disabled scope "public"`, `
1845 java_sdk_library {
1846 name: "foo",
1847 srcs: ["a.java", "b.java"],
1848 api_packages: ["foo"],
1849 // Explicitly disable public to test the check that ensures the set of enabled
1850 // scopes is consistent.
1851 public: {
1852 enabled: false,
1853 },
1854 system: {
1855 enabled: true,
1856 },
1857 }
1858 `)
1859}
1860
Paul Duffin87a05a32020-05-12 11:50:28 +01001861func TestJavaSdkLibrary_SdkVersion_ForScope(t *testing.T) {
1862 testJava(t, `
1863 java_sdk_library {
1864 name: "foo",
1865 srcs: ["a.java", "b.java"],
1866 api_packages: ["foo"],
1867 system: {
1868 enabled: true,
1869 sdk_version: "module_current",
1870 },
1871 }
1872 `)
1873}
1874
Paul Duffin0c5bae52020-06-02 13:00:08 +01001875func TestJavaSdkLibrary_ModuleLib(t *testing.T) {
1876 testJava(t, `
1877 java_sdk_library {
1878 name: "foo",
1879 srcs: ["a.java", "b.java"],
1880 api_packages: ["foo"],
1881 system: {
1882 enabled: true,
1883 },
1884 module_lib: {
1885 enabled: true,
1886 },
1887 }
1888 `)
1889}
1890
1891func TestJavaSdkLibrary_SystemServer(t *testing.T) {
1892 testJava(t, `
1893 java_sdk_library {
1894 name: "foo",
1895 srcs: ["a.java", "b.java"],
1896 api_packages: ["foo"],
1897 system: {
1898 enabled: true,
1899 },
1900 system_server: {
1901 enabled: true,
1902 },
1903 }
1904 `)
1905}
1906
Paul Duffin803a9562020-05-20 11:52:25 +01001907func TestJavaSdkLibrary_MissingScope(t *testing.T) {
1908 testJavaError(t, `requires api scope module-lib from foo but it only has \[\] available`, `
1909 java_sdk_library {
1910 name: "foo",
1911 srcs: ["a.java"],
1912 public: {
1913 enabled: false,
1914 },
1915 }
1916
1917 java_library {
1918 name: "baz",
1919 srcs: ["a.java"],
1920 libs: ["foo"],
1921 sdk_version: "module_current",
1922 }
1923 `)
1924}
1925
1926func TestJavaSdkLibrary_FallbackScope(t *testing.T) {
1927 testJava(t, `
1928 java_sdk_library {
1929 name: "foo",
1930 srcs: ["a.java"],
1931 system: {
1932 enabled: true,
1933 },
1934 }
1935
1936 java_library {
1937 name: "baz",
1938 srcs: ["a.java"],
1939 libs: ["foo"],
1940 // foo does not have module-lib scope so it should fallback to system
1941 sdk_version: "module_current",
1942 }
1943 `)
1944}
1945
Jiyong Park932cdfe2020-05-28 00:19:53 +09001946func TestJavaSdkLibrary_DefaultToStubs(t *testing.T) {
1947 ctx, _ := testJava(t, `
1948 java_sdk_library {
1949 name: "foo",
1950 srcs: ["a.java"],
1951 system: {
1952 enabled: true,
1953 },
1954 default_to_stubs: true,
1955 }
1956
1957 java_library {
1958 name: "baz",
1959 srcs: ["a.java"],
1960 libs: ["foo"],
1961 // does not have sdk_version set, should fallback to module,
1962 // which will then fallback to system because the module scope
1963 // is not enabled.
1964 }
1965 `)
1966 // The baz library should depend on the system stubs jar.
1967 bazLibrary := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1968 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs.system\.jar$`, bazLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1969 t.Errorf("expected %q, found %#q", expected, actual)
1970 }
1971}
1972
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001973var compilerFlagsTestCases = []struct {
1974 in string
1975 out bool
1976}{
1977 {
1978 in: "a",
1979 out: false,
1980 },
1981 {
1982 in: "-a",
1983 out: true,
1984 },
1985 {
1986 in: "-no-jdk",
1987 out: false,
1988 },
1989 {
1990 in: "-no-stdlib",
1991 out: false,
1992 },
1993 {
1994 in: "-kotlin-home",
1995 out: false,
1996 },
1997 {
1998 in: "-kotlin-home /some/path",
1999 out: false,
2000 },
2001 {
2002 in: "-include-runtime",
2003 out: false,
2004 },
2005 {
2006 in: "-Xintellij-plugin-root",
2007 out: false,
2008 },
2009}
2010
2011type mockContext struct {
2012 android.ModuleContext
2013 result bool
2014}
2015
2016func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
2017 // CheckBadCompilerFlags calls this function when the flag should be rejected
2018 ctx.result = false
2019}
2020
2021func TestCompilerFlags(t *testing.T) {
2022 for _, testCase := range compilerFlagsTestCases {
2023 ctx := &mockContext{result: true}
2024 CheckKotlincFlags(ctx, []string{testCase.in})
2025 if ctx.result != testCase.out {
2026 t.Errorf("incorrect output:")
2027 t.Errorf(" input: %#v", testCase.in)
2028 t.Errorf(" expected: %#v", testCase.out)
2029 t.Errorf(" got: %#v", ctx.result)
2030 }
2031 }
2032}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002033
2034// TODO(jungjw): Consider making this more robust by ignoring path order.
2035func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
2036 variables := ctx.ModuleForTests(moduleName, "android_common").Module().VariablesForTests()
2037 flags := strings.Split(variables["javacFlags"], " ")
2038 got := ""
2039 for _, flag := range flags {
2040 keyEnd := strings.Index(flag, "=")
2041 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
2042 got = flag[keyEnd+1:]
2043 break
2044 }
2045 }
2046 if expected != got {
2047 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
2048 }
2049}
2050
2051func TestPatchModule(t *testing.T) {
Pete Gillin0c2143e2019-05-02 15:32:11 +01002052 t.Run("Java language level 8", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01002053 // Test with legacy javac -source 1.8 -target 1.8
Pete Gillinbdf5d712019-10-21 14:29:58 +01002054 bp := `
2055 java_library {
2056 name: "foo",
2057 srcs: ["a.java"],
2058 java_version: "1.8",
2059 }
2060
2061 java_library {
2062 name: "bar",
2063 srcs: ["b.java"],
2064 sdk_version: "none",
2065 system_modules: "none",
2066 patch_module: "java.base",
2067 java_version: "1.8",
2068 }
2069
2070 java_library {
2071 name: "baz",
2072 srcs: ["c.java"],
2073 patch_module: "java.base",
2074 java_version: "1.8",
2075 }
2076 `
2077 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002078
2079 checkPatchModuleFlag(t, ctx, "foo", "")
2080 checkPatchModuleFlag(t, ctx, "bar", "")
2081 checkPatchModuleFlag(t, ctx, "baz", "")
2082 })
2083
Pete Gillin0c2143e2019-05-02 15:32:11 +01002084 t.Run("Java language level 9", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01002085 // Test with default javac -source 9 -target 9
Pete Gillinbdf5d712019-10-21 14:29:58 +01002086 bp := `
2087 java_library {
2088 name: "foo",
2089 srcs: ["a.java"],
2090 }
2091
2092 java_library {
2093 name: "bar",
2094 srcs: ["b.java"],
2095 sdk_version: "none",
2096 system_modules: "none",
2097 patch_module: "java.base",
2098 }
2099
2100 java_library {
2101 name: "baz",
Jingwen Chen5136a6e2020-10-30 01:01:35 -04002102 srcs: [
2103 "c.java",
2104 // Tests for b/150878007
2105 "dir/d.java",
2106 "dir2/e.java",
2107 "dir2/f.java",
2108 "nested/dir/g.java"
2109 ],
Pete Gillinbdf5d712019-10-21 14:29:58 +01002110 patch_module: "java.base",
2111 }
2112 `
Pete Gillin1b3370f2019-10-01 13:57:31 +01002113 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002114
2115 checkPatchModuleFlag(t, ctx, "foo", "")
2116 expected := "java.base=.:" + buildDir
2117 checkPatchModuleFlag(t, ctx, "bar", expected)
Jingwen Chen5136a6e2020-10-30 01:01:35 -04002118 expected = "java.base=" + strings.Join([]string{
2119 ".", buildDir, "dir", "dir2", "nested", moduleToPath("ext"), moduleToPath("framework")}, ":")
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002120 checkPatchModuleFlag(t, ctx, "baz", expected)
2121 })
2122}
Paul Duffina7b9f422020-01-10 17:12:18 +00002123
2124func TestJavaSystemModules(t *testing.T) {
2125 ctx, _ := testJava(t, `
2126 java_system_modules {
2127 name: "system-modules",
2128 libs: ["system-module1", "system-module2"],
2129 }
2130 java_library {
2131 name: "system-module1",
2132 srcs: ["a.java"],
2133 sdk_version: "none",
2134 system_modules: "none",
2135 }
2136 java_library {
2137 name: "system-module2",
2138 srcs: ["b.java"],
2139 sdk_version: "none",
2140 system_modules: "none",
2141 }
2142 `)
2143
2144 // check the existence of the module
2145 systemModules := ctx.ModuleForTests("system-modules", "android_common")
2146
2147 cmd := systemModules.Rule("jarsTosystemModules")
2148
2149 // make sure the command compiles against the supplied modules.
2150 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
2151 if !strings.Contains(cmd.Args["classpath"], module) {
2152 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
2153 module)
2154 }
2155 }
2156}
Paul Duffin90169ba2020-01-10 17:16:44 +00002157
2158func TestJavaSystemModulesImport(t *testing.T) {
2159 ctx, _ := testJava(t, `
2160 java_system_modules_import {
2161 name: "system-modules",
2162 libs: ["system-module1", "system-module2"],
2163 }
2164 java_import {
2165 name: "system-module1",
2166 jars: ["a.jar"],
2167 }
2168 java_import {
2169 name: "system-module2",
2170 jars: ["b.jar"],
2171 }
2172 `)
2173
2174 // check the existence of the module
2175 systemModules := ctx.ModuleForTests("system-modules", "android_common")
2176
2177 cmd := systemModules.Rule("jarsTosystemModules")
2178
2179 // make sure the command compiles against the supplied modules.
2180 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
2181 if !strings.Contains(cmd.Args["classpath"], module) {
2182 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
2183 module)
2184 }
2185 }
2186}
Paul Duffin83a2d962019-11-19 19:44:10 +00002187
2188func TestJavaLibraryWithSystemModules(t *testing.T) {
2189 ctx, _ := testJava(t, `
2190 java_library {
2191 name: "lib-with-source-system-modules",
2192 srcs: [
2193 "a.java",
2194 ],
2195 sdk_version: "none",
2196 system_modules: "source-system-modules",
2197 }
2198
2199 java_library {
2200 name: "source-jar",
2201 srcs: [
2202 "a.java",
2203 ],
2204 }
2205
2206 java_system_modules {
2207 name: "source-system-modules",
2208 libs: ["source-jar"],
2209 }
2210
2211 java_library {
2212 name: "lib-with-prebuilt-system-modules",
2213 srcs: [
2214 "a.java",
2215 ],
2216 sdk_version: "none",
2217 system_modules: "prebuilt-system-modules",
2218 }
2219
2220 java_import {
2221 name: "prebuilt-jar",
2222 jars: ["a.jar"],
2223 }
2224
2225 java_system_modules_import {
2226 name: "prebuilt-system-modules",
2227 libs: ["prebuilt-jar"],
2228 }
2229 `)
2230
2231 checkBootClasspathForSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar")
2232
2233 checkBootClasspathForSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar")
2234}
2235
2236func checkBootClasspathForSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) {
2237 javacRule := ctx.ModuleForTests(moduleName, "android_common").Rule("javac")
2238 bootClasspath := javacRule.Args["bootClasspath"]
2239 if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) {
2240 t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath)
2241 }
2242}
Jiyong Park19604de2020-03-24 16:44:11 +09002243
2244func TestAidlExportIncludeDirsFromImports(t *testing.T) {
2245 ctx, _ := testJava(t, `
2246 java_library {
2247 name: "foo",
2248 srcs: ["aidl/foo/IFoo.aidl"],
2249 libs: ["bar"],
2250 }
2251
2252 java_import {
2253 name: "bar",
2254 jars: ["a.jar"],
2255 aidl: {
2256 export_include_dirs: ["aidl/bar"],
2257 },
2258 }
2259 `)
2260
2261 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
2262 expectedAidlFlag := "-Iaidl/bar"
2263 if !strings.Contains(aidlCommand, expectedAidlFlag) {
2264 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
2265 }
2266}
Liz Kammerdd849a82020-06-12 16:38:45 -07002267
2268func TestDataNativeBinaries(t *testing.T) {
2269 ctx, config := testJava(t, `
2270 java_test_host {
2271 name: "foo",
2272 srcs: ["a.java"],
2273 data_native_bins: ["bin"]
2274 }
2275
2276 python_binary_host {
2277 name: "bin",
2278 srcs: ["bin.py"],
2279 }
2280 `)
2281
2282 buildOS := android.BuildOs.String()
2283
2284 test := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
2285 entries := android.AndroidMkEntriesForTest(t, config, "", test)[0]
2286 expected := []string{buildDir + "/.intermediates/bin/" + buildOS + "_x86_64_PY3/bin:bin"}
2287 actual := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
2288 if !reflect.DeepEqual(expected, actual) {
2289 t.Errorf("Unexpected test data - expected: %q, actual: %q", expected, actual)
2290 }
2291}