blob: 50c40c38cfd63317012e2c01a0b86b8ca5e1c646 [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Colin Cross72bb3632017-07-13 16:23:21 -070018 "io/ioutil"
19 "os"
20 "path/filepath"
Colin Crossc0806172019-06-14 18:51:47 -070021 "reflect"
Paul Duffindaaa3322020-05-26 18:13:57 +010022 "regexp"
Paul Duffin859fe962020-05-15 10:20:31 +010023 "sort"
Nan Zhang61eaedb2017-11-02 13:28:15 -070024 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070025 "strings"
26 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070027
Jeongik Cha28df2572019-11-11 10:46:36 +090028 "github.com/google/blueprint/proptools"
29
Colin Crossa4f08812018-10-02 22:03:40 -070030 "android/soong/android"
31 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080032 "android/soong/dexpreopt"
Colin Crossa4f08812018-10-02 22:03:40 -070033 "android/soong/genrule"
Liz Kammerdd849a82020-06-12 16:38:45 -070034 "android/soong/python"
Colin Cross72bb3632017-07-13 16:23:21 -070035)
36
37var buildDir string
38
39func setUp() {
40 var err error
41 buildDir, err = ioutil.TempDir("", "soong_java_test")
42 if err != nil {
43 panic(err)
44 }
45}
46
47func tearDown() {
48 os.RemoveAll(buildDir)
49}
50
51func TestMain(m *testing.M) {
52 run := func() int {
53 setUp()
54 defer tearDown()
55
56 return m.Run()
57 }
58
59 os.Exit(run())
60}
Colin Cross527012a2017-11-30 22:56:16 -080061
Colin Cross98be1bb2019-12-13 20:41:13 -080062func testConfig(env map[string]string, bp string, fs map[string][]byte) android.Config {
Martin Stjernholmd90676f2020-01-11 00:37:30 +000063 bp += dexpreopt.BpToolModulesForTest()
64
Martin Stjernholm75a48d82020-01-10 20:32:59 +000065 config := TestConfig(buildDir, env, bp, fs)
66
67 // Set up the global Once cache used for dexpreopt.GlobalSoongConfig, so that
68 // it doesn't create a real one, which would fail.
69 _ = dexpreopt.GlobalSoongConfigForTests(config)
70
71 return config
Colin Cross1369cdb2017-09-29 17:58:17 -070072}
73
Colin Cross98be1bb2019-12-13 20:41:13 -080074func testContext() *android.TestContext {
Colin Cross72bb3632017-07-13 16:23:21 -070075
Colin Cross4c428df2017-09-15 17:36:05 -070076 ctx := android.NewTestArchContext()
Paul Duffinf9b1da02019-12-18 19:51:55 +000077 RegisterJavaBuildComponents(ctx)
78 RegisterAppBuildComponents(ctx)
79 RegisterAARBuildComponents(ctx)
Paul Duffinb0f85072019-12-19 10:28:56 +000080 RegisterGenRuleBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000081 RegisterSystemModulesBuildComponents(ctx)
Colin Cross4b49b762019-11-22 15:25:03 -080082 ctx.RegisterModuleType("java_plugin", PluginFactory)
Colin Cross4b49b762019-11-22 15:25:03 -080083 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
84 ctx.RegisterModuleType("genrule", genrule.GenRuleFactory)
Liz Kammerdd849a82020-06-12 16:38:45 -070085 ctx.RegisterModuleType("python_binary_host", python.PythonBinaryHostFactory)
Paul Duffin884363e2019-12-19 10:21:09 +000086 RegisterDocsBuildComponents(ctx)
87 RegisterStubsBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000088 RegisterSdkLibraryBuildComponents(ctx)
Colin Cross89536d42017-07-07 14:35:50 -070089 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Paul Duffin44f1d842020-06-26 20:17:02 +010090 ctx.PreArchMutators(android.RegisterComponentsMutator)
Paul Duffina48f7582019-12-19 11:25:19 +000091
92 RegisterPrebuiltApisBuildComponents(ctx)
93
Liz Kammerdd849a82020-06-12 16:38:45 -070094 ctx.PreDepsMutators(python.RegisterPythonPreDepsMutators)
Jaewoong Jungb639a6a2019-05-10 15:16:29 -070095 ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
Colin Cross3bc7ffa2017-11-22 16:19:37 -080096 ctx.RegisterPreSingletonType("overlay", android.SingletonFactoryAdaptor(OverlaySingletonFactory))
Colin Cross3047fa22019-04-18 10:56:44 -070097 ctx.RegisterPreSingletonType("sdk_versions", android.SingletonFactoryAdaptor(sdkPreSingletonFactory))
Colin Crossa4f08812018-10-02 22:03:40 -070098
Paul Duffin021f4e52020-07-30 16:04:17 +010099 android.RegisterPrebuiltMutators(ctx)
100
Colin Crossa4f08812018-10-02 22:03:40 -0700101 // Register module types and mutators from cc needed for JNI testing
Paul Duffin77980a82019-12-19 16:01:36 +0000102 cc.RegisterRequiredBuildComponentsForTest(ctx)
Colin Crossa4f08812018-10-02 22:03:40 -0700103
Martin Stjernholmd90676f2020-01-11 00:37:30 +0000104 dexpreopt.RegisterToolModulesForTest(ctx)
105
Colin Cross527012a2017-11-30 22:56:16 -0800106 return ctx
107}
108
109func run(t *testing.T, ctx *android.TestContext, config android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800110 t.Helper()
Colin Crossc28bb0b2019-02-25 14:20:47 -0800111
Colin Cross98be1bb2019-12-13 20:41:13 -0800112 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000113 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Colin Crossc28bb0b2019-02-25 14:20:47 -0800114
Colin Cross98be1bb2019-12-13 20:41:13 -0800115 ctx.Register(config)
Paul Duffinbaccf7e2019-06-11 11:58:30 +0100116 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
Logan Chien42039712018-03-12 16:29:17 +0800117 android.FailIfErrored(t, errs)
Colin Cross72bb3632017-07-13 16:23:21 -0700118 _, errs = ctx.PrepareBuildActions(config)
Logan Chien42039712018-03-12 16:29:17 +0800119 android.FailIfErrored(t, errs)
Colin Cross527012a2017-11-30 22:56:16 -0800120}
121
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900122func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) {
Jeongik Cha538c0d02019-07-11 15:54:27 +0900123 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800124 return testJavaErrorWithConfig(t, pattern, testConfig(nil, bp, nil))
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900125}
126
Colin Cross98be1bb2019-12-13 20:41:13 -0800127func testJavaErrorWithConfig(t *testing.T, pattern string, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900128 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800129 ctx := testContext()
Jeongik Cha538c0d02019-07-11 15:54:27 +0900130
Colin Cross98be1bb2019-12-13 20:41:13 -0800131 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000132 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Jeongik Cha538c0d02019-07-11 15:54:27 +0900133
Colin Cross98be1bb2019-12-13 20:41:13 -0800134 ctx.Register(config)
Jeongik Cha538c0d02019-07-11 15:54:27 +0900135 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
136 if len(errs) > 0 {
137 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900138 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900139 }
140 _, errs = ctx.PrepareBuildActions(config)
141 if len(errs) > 0 {
142 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900143 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900144 }
145
146 t.Fatalf("missing expected error %q (0 errors are returned)", pattern)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900147
148 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900149}
150
Colin Cross238c1f32020-06-07 16:58:18 -0700151func testJavaWithFS(t *testing.T, bp string, fs map[string][]byte) (*android.TestContext, android.Config) {
152 t.Helper()
153 return testJavaWithConfig(t, testConfig(nil, bp, fs))
154}
155
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700156func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800157 t.Helper()
Colin Cross238c1f32020-06-07 16:58:18 -0700158 return testJavaWithFS(t, bp, nil)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900159}
160
Colin Cross98be1bb2019-12-13 20:41:13 -0800161func testJavaWithConfig(t *testing.T, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900162 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800163 ctx := testContext()
Colin Cross527012a2017-11-30 22:56:16 -0800164 run(t, ctx, config)
Colin Cross72bb3632017-07-13 16:23:21 -0700165
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700166 return ctx, config
Colin Cross72bb3632017-07-13 16:23:21 -0700167}
168
Colin Cross2acdae82017-09-15 19:44:24 -0700169func moduleToPath(name string) string {
170 switch {
171 case name == `""`:
172 return name
Colin Crossfc3674a2017-09-18 17:41:52 -0700173 case strings.HasSuffix(name, ".jar"):
174 return name
Nan Zhanged19fc32017-10-19 13:06:22 -0700175 default:
176 return filepath.Join(buildDir, ".intermediates", name, "android_common", "turbine-combined", name+".jar")
Colin Cross2acdae82017-09-15 19:44:24 -0700177 }
178}
179
Jeongik Chae403e9e2019-12-07 00:16:24 +0900180func TestJavaLinkType(t *testing.T) {
181 testJava(t, `
182 java_library {
183 name: "foo",
184 srcs: ["a.java"],
185 libs: ["bar"],
186 static_libs: ["baz"],
187 }
188
189 java_library {
190 name: "bar",
191 sdk_version: "current",
192 srcs: ["b.java"],
193 }
194
195 java_library {
196 name: "baz",
197 sdk_version: "system_current",
198 srcs: ["c.java"],
199 }
200 `)
201
202 testJavaError(t, "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source.", `
203 java_library {
204 name: "foo",
205 srcs: ["a.java"],
206 libs: ["bar"],
207 sdk_version: "current",
208 static_libs: ["baz"],
209 }
210
211 java_library {
212 name: "bar",
213 sdk_version: "current",
214 srcs: ["b.java"],
215 }
216
217 java_library {
218 name: "baz",
219 sdk_version: "system_current",
220 srcs: ["c.java"],
221 }
222 `)
223
224 testJava(t, `
225 java_library {
226 name: "foo",
227 srcs: ["a.java"],
228 libs: ["bar"],
229 sdk_version: "system_current",
230 static_libs: ["baz"],
231 }
232
233 java_library {
234 name: "bar",
235 sdk_version: "current",
236 srcs: ["b.java"],
237 }
238
239 java_library {
240 name: "baz",
241 sdk_version: "system_current",
242 srcs: ["c.java"],
243 }
244 `)
245
246 testJavaError(t, "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source.", `
247 java_library {
248 name: "foo",
249 srcs: ["a.java"],
250 libs: ["bar"],
251 sdk_version: "system_current",
252 static_libs: ["baz"],
253 }
254
255 java_library {
256 name: "bar",
257 sdk_version: "current",
258 srcs: ["b.java"],
259 }
260
261 java_library {
262 name: "baz",
263 srcs: ["c.java"],
264 }
265 `)
266}
267
Colin Cross72bb3632017-07-13 16:23:21 -0700268func TestSimple(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700269 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700270 java_library {
271 name: "foo",
272 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700273 libs: ["bar"],
274 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700275 }
276
277 java_library {
278 name: "bar",
279 srcs: ["b.java"],
280 }
281
282 java_library {
283 name: "baz",
284 srcs: ["c.java"],
285 }
Colin Crossd5934c82017-10-02 13:55:26 -0700286 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700287
Colin Cross4c428df2017-09-15 17:36:05 -0700288 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700289 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700290
291 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
292 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
293 }
294
Colin Cross1ee23172017-10-18 14:44:18 -0700295 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Nan Zhanged19fc32017-10-19 13:06:22 -0700296 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
297 bazTurbine := filepath.Join(buildDir, ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700298
Nan Zhanged19fc32017-10-19 13:06:22 -0700299 if !strings.Contains(javac.Args["classpath"], barTurbine) {
300 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700301 }
302
Nan Zhanged19fc32017-10-19 13:06:22 -0700303 if !strings.Contains(javac.Args["classpath"], bazTurbine) {
304 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700305 }
306
307 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
308 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700309 }
310}
311
Artur Satayev9cf46692019-11-26 18:08:34 +0000312func TestExportedPlugins(t *testing.T) {
313 type Result struct {
314 library string
315 processors string
316 }
317 var tests = []struct {
318 name string
319 extra string
320 results []Result
321 }{
322 {
323 name: "Exported plugin is not a direct plugin",
324 extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`,
325 results: []Result{{library: "exports", processors: "-proc:none"}},
326 },
327 {
328 name: "Exports plugin to dependee",
329 extra: `
330 java_library{name: "exports", exported_plugins: ["plugin"]}
331 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
332 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
333 `,
334 results: []Result{
335 {library: "foo", processors: "-processor com.android.TestPlugin"},
336 {library: "bar", processors: "-processor com.android.TestPlugin"},
337 },
338 },
339 {
340 name: "Exports plugin to android_library",
341 extra: `
342 java_library{name: "exports", exported_plugins: ["plugin"]}
343 android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
344 android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
345 `,
346 results: []Result{
347 {library: "foo", processors: "-processor com.android.TestPlugin"},
348 {library: "bar", processors: "-processor com.android.TestPlugin"},
349 },
350 },
351 {
352 name: "Exports plugin is not propagated via transitive deps",
353 extra: `
354 java_library{name: "exports", exported_plugins: ["plugin"]}
355 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
356 java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]}
357 `,
358 results: []Result{
359 {library: "foo", processors: "-processor com.android.TestPlugin"},
360 {library: "bar", processors: "-proc:none"},
361 },
362 },
363 {
364 name: "Exports plugin appends to plugins",
365 extra: `
366 java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"}
367 java_library{name: "exports", exported_plugins: ["plugin"]}
368 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]}
369 `,
370 results: []Result{
371 {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"},
372 },
373 },
374 }
375
376 for _, test := range tests {
377 t.Run(test.name, func(t *testing.T) {
378 ctx, _ := testJava(t, `
379 java_plugin {
380 name: "plugin",
381 processor_class: "com.android.TestPlugin",
382 }
383 `+test.extra)
384
385 for _, want := range test.results {
386 javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac")
387 if javac.Args["processor"] != want.processors {
388 t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"])
389 }
390 }
391 })
392 }
393}
394
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900395func TestSdkVersionByPartition(t *testing.T) {
396 testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900397 java_library {
398 name: "foo",
399 srcs: ["a.java"],
400 vendor: true,
401 }
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900402 `)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900403
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900404 testJava(t, `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900405 java_library {
406 name: "bar",
407 srcs: ["b.java"],
408 }
409 `)
410
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900411 for _, enforce := range []bool{true, false} {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900412 bp := `
413 java_library {
414 name: "foo",
415 srcs: ["a.java"],
416 product_specific: true,
417 }
418 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800419
420 config := testConfig(nil, bp, nil)
421 config.TestProductVariables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900422 if enforce {
Colin Cross98be1bb2019-12-13 20:41:13 -0800423 testJavaErrorWithConfig(t, "sdk_version must have a value when the module is located at vendor or product", config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900424 } else {
Colin Cross98be1bb2019-12-13 20:41:13 -0800425 testJavaWithConfig(t, config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900426 }
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900427 }
428}
429
Colin Crossd5934c82017-10-02 13:55:26 -0700430func TestArchSpecific(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700431 ctx, _ := testJava(t, `
Colin Crossd5934c82017-10-02 13:55:26 -0700432 java_library {
433 name: "foo",
434 srcs: ["a.java"],
435 target: {
436 android: {
437 srcs: ["b.java"],
438 },
439 },
440 }
441 `)
442
443 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
444 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
445 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
446 }
447}
448
Colin Cross6b4a32d2017-12-05 13:42:45 -0800449func TestBinary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700450 ctx, _ := testJava(t, `
Colin Cross6b4a32d2017-12-05 13:42:45 -0800451 java_library_host {
452 name: "foo",
453 srcs: ["a.java"],
454 }
455
456 java_binary_host {
457 name: "bar",
458 srcs: ["b.java"],
459 static_libs: ["foo"],
460 }
461 `)
462
463 buildOS := android.BuildOs.String()
464
465 bar := ctx.ModuleForTests("bar", buildOS+"_common")
466 barJar := bar.Output("bar.jar").Output.String()
467 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
468 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
469
470 // Test that the install binary wrapper depends on the installed jar file
471 if len(barWrapperDeps) != 1 || barWrapperDeps[0] != barJar {
472 t.Errorf("expected binary wrapper implicits [%q], got %v",
473 barJar, barWrapperDeps)
474 }
Alex Humesky2070e322020-06-09 20:23:08 -0400475}
Colin Cross6b4a32d2017-12-05 13:42:45 -0800476
Alex Humesky2070e322020-06-09 20:23:08 -0400477func TestHostBinaryNoJavaDebugInfoOverride(t *testing.T) {
478 bp := `
479 java_library {
480 name: "target_library",
481 srcs: ["a.java"],
482 }
483
484 java_binary_host {
485 name: "host_binary",
486 srcs: ["b.java"],
487 }
488 `
489 config := testConfig(nil, bp, nil)
490 config.TestProductVariables.MinimizeJavaDebugInfo = proptools.BoolPtr(true)
491
492 ctx, _ := testJavaWithConfig(t, config)
493
Liz Kammer7941b302020-07-28 13:27:34 -0700494 // first, check that the -g flag is added to target modules
Alex Humesky2070e322020-06-09 20:23:08 -0400495 targetLibrary := ctx.ModuleForTests("target_library", "android_common")
496 targetJavaFlags := targetLibrary.Module().VariablesForTests()["javacFlags"]
497 if !strings.Contains(targetJavaFlags, "-g:source,lines") {
498 t.Errorf("target library javac flags %v should contain "+
499 "-g:source,lines override with MinimizeJavaDebugInfo", targetJavaFlags)
500 }
501
502 // check that -g is not overridden for host modules
503 buildOS := android.BuildOs.String()
504 hostBinary := ctx.ModuleForTests("host_binary", buildOS+"_common")
505 hostJavaFlags := hostBinary.Module().VariablesForTests()["javacFlags"]
506 if strings.Contains(hostJavaFlags, "-g:source,lines") {
507 t.Errorf("java_binary_host javac flags %v should not have "+
508 "-g:source,lines override with MinimizeJavaDebugInfo", hostJavaFlags)
509 }
Colin Cross6b4a32d2017-12-05 13:42:45 -0800510}
511
Colin Cross72bb3632017-07-13 16:23:21 -0700512func TestPrebuilts(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700513 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700514 java_library {
515 name: "foo",
Paul Duffin91547182019-11-12 19:39:36 +0000516 srcs: ["a.java", ":stubs-source"],
Paul Duffinfcfd7912020-01-31 17:54:30 +0000517 libs: ["bar", "sdklib"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700518 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700519 }
520
Colin Cross74d73e22017-08-02 11:05:49 -0700521 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700522 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700523 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700524 }
525
Colin Cross74d73e22017-08-02 11:05:49 -0700526 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700527 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700528 jars: ["b.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700529 }
Colin Cross42be7612019-02-21 18:12:14 -0800530
531 dex_import {
532 name: "qux",
533 jars: ["b.jar"],
534 }
Colin Cross79c7c262019-04-17 11:11:46 -0700535
536 java_sdk_library_import {
Paul Duffin56d44902020-01-31 13:36:25 +0000537 name: "sdklib",
538 public: {
539 jars: ["c.jar"],
540 },
541 }
542
Paul Duffin91547182019-11-12 19:39:36 +0000543 prebuilt_stubs_sources {
544 name: "stubs-source",
Paul Duffin9b478b02019-12-10 13:41:51 +0000545 srcs: ["stubs/sources"],
Paul Duffin91547182019-11-12 19:39:36 +0000546 }
Paul Duffin1b82e6a2019-12-03 18:06:47 +0000547
548 java_test_import {
549 name: "test",
550 jars: ["a.jar"],
551 test_suites: ["cts"],
552 test_config: "AndroidTest.xml",
553 }
Colin Cross72bb3632017-07-13 16:23:21 -0700554 `)
555
Paul Duffin9b478b02019-12-10 13:41:51 +0000556 fooModule := ctx.ModuleForTests("foo", "android_common")
557 javac := fooModule.Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700558 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross37f6d792018-07-12 12:28:41 -0700559 barJar := ctx.ModuleForTests("bar", "android_common").Rule("combineJar").Output
560 bazJar := ctx.ModuleForTests("baz", "android_common").Rule("combineJar").Output
Colin Cross79c7c262019-04-17 11:11:46 -0700561 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700562
Paul Duffin9b478b02019-12-10 13:41:51 +0000563 fooLibrary := fooModule.Module().(*Library)
564 assertDeepEquals(t, "foo java sources incorrect",
565 []string{"a.java"}, fooLibrary.compiledJavaSrcs.Strings())
Paul Duffin91547182019-11-12 19:39:36 +0000566
Paul Duffin9b478b02019-12-10 13:41:51 +0000567 assertDeepEquals(t, "foo java source jars incorrect",
568 []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"},
569 android.NormalizePathsForTesting(fooLibrary.compiledSrcJars))
Paul Duffin91547182019-11-12 19:39:36 +0000570
Colin Cross37f6d792018-07-12 12:28:41 -0700571 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
572 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700573 }
574
Colin Cross79c7c262019-04-17 11:11:46 -0700575 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
576 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
577 }
578
Colin Cross37f6d792018-07-12 12:28:41 -0700579 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
580 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700581 }
Colin Cross42be7612019-02-21 18:12:14 -0800582
583 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Colin Cross72bb3632017-07-13 16:23:21 -0700584}
585
Paul Duffin9b478b02019-12-10 13:41:51 +0000586func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) {
587 if !reflect.DeepEqual(expected, actual) {
588 t.Errorf("%s: expected %q, found %q", message, expected, actual)
589 }
590}
591
Paul Duffin56d44902020-01-31 13:36:25 +0000592func TestJavaSdkLibraryImport(t *testing.T) {
593 ctx, _ := testJava(t, `
594 java_library {
595 name: "foo",
596 srcs: ["a.java"],
597 libs: ["sdklib"],
598 sdk_version: "current",
599 }
600
601 java_library {
602 name: "foo.system",
603 srcs: ["a.java"],
604 libs: ["sdklib"],
605 sdk_version: "system_current",
606 }
607
608 java_library {
609 name: "foo.test",
610 srcs: ["a.java"],
611 libs: ["sdklib"],
612 sdk_version: "test_current",
613 }
614
615 java_sdk_library_import {
616 name: "sdklib",
617 public: {
618 jars: ["a.jar"],
619 },
620 system: {
621 jars: ["b.jar"],
622 },
623 test: {
624 jars: ["c.jar"],
Paul Duffin0f8faff2020-05-20 16:18:00 +0100625 stub_srcs: ["c.java"],
Paul Duffin56d44902020-01-31 13:36:25 +0000626 },
627 }
628 `)
629
630 for _, scope := range []string{"", ".system", ".test"} {
631 fooModule := ctx.ModuleForTests("foo"+scope, "android_common")
632 javac := fooModule.Rule("javac")
633
634 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs"+scope, "android_common").Rule("combineJar").Output
635 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
636 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
637 }
638 }
Paul Duffinca8d9a52020-06-26 22:20:25 +0100639
Paul Duffincee7e662020-07-09 17:32:57 +0100640 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100641 `prebuilt_sdklib.stubs`,
642 `prebuilt_sdklib.stubs.source.test`,
643 `prebuilt_sdklib.stubs.system`,
644 `prebuilt_sdklib.stubs.test`,
645 })
646}
647
648func TestJavaSdkLibraryImport_WithSource(t *testing.T) {
649 ctx, _ := testJava(t, `
650 java_sdk_library {
651 name: "sdklib",
652 srcs: ["a.java"],
653 sdk_version: "none",
654 system_modules: "none",
655 public: {
656 enabled: true,
657 },
658 }
659
660 java_sdk_library_import {
661 name: "sdklib",
662 public: {
663 jars: ["a.jar"],
664 },
665 }
666 `)
667
Paul Duffincee7e662020-07-09 17:32:57 +0100668 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100669 `dex2oatd`,
670 `prebuilt_sdklib`,
671 `sdklib.impl`,
672 `sdklib.stubs`,
673 `sdklib.stubs.source`,
674 `sdklib.xml`,
675 })
676
Paul Duffincee7e662020-07-09 17:32:57 +0100677 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffin44f1d842020-06-26 20:17:02 +0100678 `prebuilt_sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100679 `sdklib.impl`,
680 // This should be prebuilt_sdklib.stubs but is set to sdklib.stubs because the
681 // dependency is added after prebuilts may have been renamed and so has to use
682 // the renamed name.
Paul Duffinca8d9a52020-06-26 22:20:25 +0100683 `sdklib.xml`,
684 })
685}
686
687func TestJavaSdkLibraryImport_Preferred(t *testing.T) {
688 ctx, _ := testJava(t, `
689 java_sdk_library {
690 name: "sdklib",
691 srcs: ["a.java"],
692 sdk_version: "none",
693 system_modules: "none",
694 public: {
695 enabled: true,
696 },
697 }
698
699 java_sdk_library_import {
700 name: "sdklib",
701 prefer: true,
702 public: {
703 jars: ["a.jar"],
704 },
705 }
706 `)
707
Paul Duffincee7e662020-07-09 17:32:57 +0100708 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100709 `dex2oatd`,
710 `prebuilt_sdklib`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100711 `sdklib.impl`,
Paul Duffin80342d72020-06-26 22:08:43 +0100712 `sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100713 `sdklib.stubs.source`,
714 `sdklib.xml`,
715 })
716
Paul Duffincee7e662020-07-09 17:32:57 +0100717 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100718 `prebuilt_sdklib.stubs`,
719 `sdklib.impl`,
720 `sdklib.xml`,
721 })
Paul Duffin56d44902020-01-31 13:36:25 +0000722}
723
Colin Cross89536d42017-07-07 14:35:50 -0700724func TestDefaults(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700725 ctx, _ := testJava(t, `
Colin Cross89536d42017-07-07 14:35:50 -0700726 java_defaults {
727 name: "defaults",
728 srcs: ["a.java"],
729 libs: ["bar"],
730 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -0700731 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700732 }
733
734 java_library {
735 name: "foo",
736 defaults: ["defaults"],
737 }
738
739 java_library {
740 name: "bar",
741 srcs: ["b.java"],
742 }
743
744 java_library {
745 name: "baz",
746 srcs: ["c.java"],
747 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700748
749 android_test {
750 name: "atestOptimize",
751 defaults: ["defaults"],
752 optimize: {enabled: true},
753 }
754
755 android_test {
756 name: "atestNoOptimize",
757 defaults: ["defaults"],
758 }
759
760 android_test {
761 name: "atestDefault",
762 srcs: ["a.java"],
763 }
Colin Cross89536d42017-07-07 14:35:50 -0700764 `)
765
Colin Cross4c428df2017-09-15 17:36:05 -0700766 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700767 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -0700768
769 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
770 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
771 }
772
Nan Zhanged19fc32017-10-19 13:06:22 -0700773 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
774 if !strings.Contains(javac.Args["classpath"], barTurbine) {
775 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -0700776 }
777
Colin Cross1ee23172017-10-18 14:44:18 -0700778 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -0700779 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
780 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -0700781 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700782
783 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
784 if atestOptimize.Output == nil {
785 t.Errorf("atestOptimize should optimize APK")
786 }
787
788 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
789 if atestNoOptimize.Output == nil {
790 t.Errorf("atestNoOptimize should not optimize APK")
791 }
792
793 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("r8")
794 if atestDefault.Output == nil {
795 t.Errorf("atestDefault should optimize APK")
796 }
Colin Cross89536d42017-07-07 14:35:50 -0700797}
798
Colin Cross0f37af02017-09-27 17:42:05 -0700799func TestResources(t *testing.T) {
800 var table = []struct {
801 name string
802 prop string
803 extra string
804 args string
805 }{
806 {
Colin Crossaf9c55b2017-10-03 14:50:08 -0700807 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -0700808 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -0800809 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700810 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700811 },
812 {
813 // Test that a module with java_resources includes the files
814 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -0700815 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
816 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700817 },
818 {
819 // Test that a module with a filegroup in java_resources includes the files with the
820 // path prefix
821 name: "resource filegroup",
822 prop: `java_resources: [":foo-res"]`,
823 extra: `
824 filegroup {
825 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -0800826 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -0700827 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -0700828 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700829 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700830 },
831 {
Colin Cross0ead1d72018-04-10 13:07:42 -0700832 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
833 name: "wildcard dirs",
834 prop: `java_resource_dirs: ["java-res/*"]`,
835 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
836 },
837 {
838 // Test that a module exclude_java_resource_dirs excludes the files
839 name: "wildcard dirs",
840 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
841 args: "-C java-res/a -f java-res/a/a",
842 },
Colin Crosscedd4762018-09-13 11:26:19 -0700843 {
844 // Test wildcards in java_resources
845 name: "wildcard files",
846 prop: `java_resources: ["java-res/**/*"]`,
847 args: "-C . -f java-res/a/a -f java-res/b/b",
848 },
849 {
850 // Test exclude_java_resources with java_resources
851 name: "wildcard files with exclude",
852 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
853 args: "-C . -f java-res/a/a",
854 },
855 {
856 // Test exclude_java_resources with java_resource_dirs
857 name: "resource dirs with exclude files",
858 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
859 args: "-C java-res -f java-res/a/a",
860 },
861 {
862 // Test exclude_java_resource_dirs with java_resource_dirs
863 name: "resource dirs with exclude files",
864 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
865 args: "-C java-res -f java-res/a/a -f java-res/b/b",
866 },
Colin Cross0f37af02017-09-27 17:42:05 -0700867 }
868
869 for _, test := range table {
870 t.Run(test.name, func(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700871 ctx, _ := testJavaWithFS(t, `
Colin Cross0f37af02017-09-27 17:42:05 -0700872 java_library {
873 name: "foo",
874 srcs: [
875 "a.java",
876 "b.java",
877 "c.java",
878 ],
879 `+test.prop+`,
880 }
Colin Cross238c1f32020-06-07 16:58:18 -0700881 `+test.extra,
882 map[string][]byte{
883 "java-res/a/a": nil,
884 "java-res/b/b": nil,
885 "java-res2/a": nil,
886 },
887 )
Colin Cross0f37af02017-09-27 17:42:05 -0700888
Colin Cross331a1212018-08-15 20:40:52 -0700889 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -0700890 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -0700891
892 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
893 t.Errorf("foo combined jars %v does not contain %q",
894 foo.Inputs.Strings(), fooRes.Output.String())
895 }
896
Colin Crossaf9c55b2017-10-03 14:50:08 -0700897 if fooRes.Args["jarArgs"] != test.args {
898 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -0700899 fooRes.Args["jarArgs"], test.args)
900 }
901 })
902 }
903}
904
Colin Cross0c4ce212019-05-03 15:28:19 -0700905func TestIncludeSrcs(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700906 ctx, _ := testJavaWithFS(t, `
Colin Cross0c4ce212019-05-03 15:28:19 -0700907 java_library {
908 name: "foo",
909 srcs: [
910 "a.java",
911 "b.java",
912 "c.java",
913 ],
914 include_srcs: true,
915 }
916
917 java_library {
918 name: "bar",
919 srcs: [
920 "a.java",
921 "b.java",
922 "c.java",
923 ],
924 java_resource_dirs: ["java-res"],
925 include_srcs: true,
926 }
Colin Cross238c1f32020-06-07 16:58:18 -0700927 `, map[string][]byte{
928 "java-res/a/a": nil,
929 "java-res/b/b": nil,
930 "java-res2/a": nil,
931 })
Colin Cross0c4ce212019-05-03 15:28:19 -0700932
933 // Test a library with include_srcs: true
934 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
935 fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar")
936
937 if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) {
938 t.Errorf("foo combined jars %v does not contain %q", w, g)
939 }
940
941 if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
942 t.Errorf("foo source jar args %q is not %q", w, g)
943 }
944
945 // Test a library with include_srcs: true and resources
946 bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar")
947 barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar")
948 barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar")
949 barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar")
950
951 if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
952 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
953 }
954
955 if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
956 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
957 }
958
959 if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) {
960 t.Errorf("bar combined jars %v does not contain %q", w, g)
961 }
962
963 if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
964 t.Errorf("bar source jar args %q is not %q", w, g)
965 }
966
967 if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w {
968 t.Errorf("bar resource jar args %q is not %q", w, g)
969 }
970}
971
Colin Cross54190b32017-10-09 15:34:10 -0700972func TestGeneratedSources(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700973 ctx, _ := testJavaWithFS(t, `
Colin Cross54190b32017-10-09 15:34:10 -0700974 java_library {
975 name: "foo",
976 srcs: [
977 "a*.java",
978 ":gen",
979 "b*.java",
980 ],
981 }
982
983 genrule {
984 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -0800985 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -0700986 out: ["gen.java"],
987 }
Colin Cross238c1f32020-06-07 16:58:18 -0700988 `, map[string][]byte{
989 "a.java": nil,
990 "b.java": nil,
991 })
Colin Cross54190b32017-10-09 15:34:10 -0700992
993 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
994 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
995
Colin Cross15e86d92017-10-20 15:07:08 -0700996 if filepath.Base(genrule.Output.String()) != "gen.java" {
997 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -0700998 }
999
1000 if len(javac.Inputs) != 3 ||
1001 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -07001002 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -07001003 javac.Inputs[2].String() != "b.java" {
1004 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
1005 }
1006}
1007
Nan Zhang61eaedb2017-11-02 13:28:15 -07001008func TestTurbine(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001009 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001010 java_library {
1011 name: "foo",
1012 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +09001013 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001014 }
1015
1016 java_library {
1017 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -08001018 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -07001019 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +09001020 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001021 }
1022
1023 java_library {
1024 name: "baz",
1025 srcs: ["c.java"],
1026 libs: ["bar"],
1027 sdk_version: "14",
1028 }
1029 `)
1030
1031 fooTurbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine")
1032 barTurbine := ctx.ModuleForTests("bar", "android_common").Rule("turbine")
1033 barJavac := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1034 barTurbineCombined := ctx.ModuleForTests("bar", "android_common").Description("for turbine")
1035 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1036
1037 if len(fooTurbine.Inputs) != 1 || fooTurbine.Inputs[0].String() != "a.java" {
1038 t.Errorf(`foo inputs %v != ["a.java"]`, fooTurbine.Inputs)
1039 }
1040
1041 fooHeaderJar := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
1042 if !strings.Contains(barTurbine.Args["classpath"], fooHeaderJar) {
1043 t.Errorf("bar turbine classpath %v does not contain %q", barTurbine.Args["classpath"], fooHeaderJar)
1044 }
1045 if !strings.Contains(barJavac.Args["classpath"], fooHeaderJar) {
1046 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], fooHeaderJar)
1047 }
1048 if len(barTurbineCombined.Inputs) != 2 || barTurbineCombined.Inputs[1].String() != fooHeaderJar {
1049 t.Errorf("bar turbine combineJar inputs %v does not contain %q", barTurbineCombined.Inputs, fooHeaderJar)
1050 }
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001051 if !strings.Contains(bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") {
Nan Zhang61eaedb2017-11-02 13:28:15 -07001052 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001053 "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -07001054 }
1055}
1056
1057func TestSharding(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001058 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001059 java_library {
1060 name: "bar",
1061 srcs: ["a.java","b.java","c.java"],
1062 javac_shard_size: 1
1063 }
1064 `)
1065
1066 barHeaderJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
1067 for i := 0; i < 3; i++ {
1068 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
1069 if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) {
1070 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar)
1071 }
1072 }
1073}
1074
Nan Zhang581fd212018-01-10 16:06:12 -08001075func TestDroiddoc(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001076 ctx, _ := testJavaWithFS(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001077 droiddoc_exported_dir {
Dan Willemsencc090972018-02-26 14:33:31 -08001078 name: "droiddoc-templates-sdk",
1079 path: ".",
1080 }
Jiyong Park29074592019-07-07 16:27:47 +09001081 filegroup {
1082 name: "bar-doc-aidl-srcs",
1083 srcs: ["bar-doc/IBar.aidl"],
1084 path: "bar-doc",
1085 }
Nan Zhang581fd212018-01-10 16:06:12 -08001086 droiddoc {
1087 name: "bar-doc",
1088 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001089 "bar-doc/a.java",
Jiyong Park1e440682018-05-23 18:42:04 +09001090 "bar-doc/IFoo.aidl",
Jiyong Park29074592019-07-07 16:27:47 +09001091 ":bar-doc-aidl-srcs",
Nan Zhang581fd212018-01-10 16:06:12 -08001092 ],
1093 exclude_srcs: [
1094 "bar-doc/b.java"
1095 ],
Dan Willemsencc090972018-02-26 14:33:31 -08001096 custom_template: "droiddoc-templates-sdk",
Nan Zhang581fd212018-01-10 16:06:12 -08001097 hdf: [
1098 "android.whichdoc offline",
1099 ],
1100 knowntags: [
1101 "bar-doc/known_oj_tags.txt",
1102 ],
1103 proofread_file: "libcore-proofread.txt",
1104 todo_file: "libcore-docs-todo.html",
Liz Kammer585cac22020-07-06 09:12:57 -07001105 flags: ["-offlinemode -title \"libcore\""],
Nan Zhang581fd212018-01-10 16:06:12 -08001106 }
Colin Cross238c1f32020-06-07 16:58:18 -07001107 `,
1108 map[string][]byte{
1109 "bar-doc/a.java": nil,
1110 "bar-doc/b.java": nil,
1111 })
Liz Kammer1e2ee122020-07-30 15:07:22 -07001112 barDocModule := ctx.ModuleForTests("bar-doc", "android_common")
1113 barDoc := barDocModule.Rule("javadoc")
1114 notExpected := " -stubs "
1115 if strings.Contains(barDoc.RuleParams.Command, notExpected) {
1116 t.Errorf("bar-doc command contains flag %q to create stubs, but should not", notExpected)
1117 }
Nan Zhang581fd212018-01-10 16:06:12 -08001118
Jiyong Park1e440682018-05-23 18:42:04 +09001119 var javaSrcs []string
Colin Crossc0806172019-06-14 18:51:47 -07001120 for _, i := range barDoc.Inputs {
Jiyong Park1e440682018-05-23 18:42:04 +09001121 javaSrcs = append(javaSrcs, i.Base())
1122 }
Colin Crossc0806172019-06-14 18:51:47 -07001123 if len(javaSrcs) != 1 || javaSrcs[0] != "a.java" {
1124 t.Errorf("inputs of bar-doc must be []string{\"a.java\"}, but was %#v.", javaSrcs)
Jiyong Park29074592019-07-07 16:27:47 +09001125 }
1126
Liz Kammer1e2ee122020-07-30 15:07:22 -07001127 aidl := barDocModule.Rule("aidl")
Colin Crossc0806172019-06-14 18:51:47 -07001128 if g, w := barDoc.Implicits.Strings(), aidl.Output.String(); !inList(w, g) {
1129 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
1130 }
1131
1132 if g, w := aidl.Implicits.Strings(), []string{"bar-doc/IBar.aidl", "bar-doc/IFoo.aidl"}; !reflect.DeepEqual(w, g) {
1133 t.Errorf("aidl inputs must be %q, but was %q", w, g)
Jiyong Park1e440682018-05-23 18:42:04 +09001134 }
Nan Zhang581fd212018-01-10 16:06:12 -08001135}
1136
Liz Kammer585cac22020-07-06 09:12:57 -07001137func TestDroiddocArgsAndFlagsCausesError(t *testing.T) {
1138 testJavaError(t, "flags is set. Cannot set args", `
1139 droiddoc_exported_dir {
1140 name: "droiddoc-templates-sdk",
1141 path: ".",
1142 }
1143 filegroup {
1144 name: "bar-doc-aidl-srcs",
1145 srcs: ["bar-doc/IBar.aidl"],
1146 path: "bar-doc",
1147 }
1148 droiddoc {
1149 name: "bar-doc",
1150 srcs: [
1151 "bar-doc/a.java",
1152 "bar-doc/IFoo.aidl",
1153 ":bar-doc-aidl-srcs",
1154 ],
1155 exclude_srcs: [
1156 "bar-doc/b.java"
1157 ],
1158 custom_template: "droiddoc-templates-sdk",
1159 hdf: [
1160 "android.whichdoc offline",
1161 ],
1162 knowntags: [
1163 "bar-doc/known_oj_tags.txt",
1164 ],
1165 proofread_file: "libcore-proofread.txt",
1166 todo_file: "libcore-docs-todo.html",
1167 flags: ["-offlinemode -title \"libcore\""],
1168 args: "-offlinemode -title \"libcore\"",
1169 }
1170 `)
1171}
1172
Liz Kammer3d894b72020-08-04 09:55:13 -07001173func TestDroidstubs(t *testing.T) {
1174 ctx, _ := testJavaWithFS(t, `
1175 droiddoc_exported_dir {
1176 name: "droiddoc-templates-sdk",
1177 path: ".",
1178 }
1179
1180 droidstubs {
1181 name: "bar-stubs",
1182 srcs: [
1183 "bar-doc/a.java",
1184 ],
1185 api_levels_annotations_dirs: [
1186 "droiddoc-templates-sdk",
1187 ],
1188 api_levels_annotations_enabled: true,
1189 }
1190
1191 droidstubs {
1192 name: "bar-stubs-other",
1193 srcs: [
1194 "bar-doc/a.java",
1195 ],
1196 api_levels_annotations_dirs: [
1197 "droiddoc-templates-sdk",
1198 ],
1199 api_levels_annotations_enabled: true,
1200 api_levels_jar_filename: "android.other.jar",
1201 }
1202 `,
1203 map[string][]byte{
1204 "bar-doc/a.java": nil,
1205 })
1206 testcases := []struct {
1207 moduleName string
1208 expectedJarFilename string
1209 }{
1210 {
1211 moduleName: "bar-stubs",
1212 expectedJarFilename: "android.jar",
1213 },
1214 {
1215 moduleName: "bar-stubs-other",
1216 expectedJarFilename: "android.other.jar",
1217 },
1218 }
1219 for _, c := range testcases {
1220 m := ctx.ModuleForTests(c.moduleName, "android_common")
1221 metalava := m.Rule("metalava")
1222 expected := "--android-jar-pattern ./%/public/" + c.expectedJarFilename
1223 if actual := metalava.RuleParams.Command; !strings.Contains(actual, expected) {
1224 t.Errorf("For %q, expected metalava argument %q, but was not found %q", c.moduleName, expected, actual)
1225 }
1226 }
1227}
1228
Paul Duffin83a2d962019-11-19 19:44:10 +00001229func TestDroidstubsWithSystemModules(t *testing.T) {
1230 ctx, _ := testJava(t, `
1231 droidstubs {
1232 name: "stubs-source-system-modules",
1233 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001234 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001235 ],
1236 sdk_version: "none",
1237 system_modules: "source-system-modules",
1238 }
1239
1240 java_library {
1241 name: "source-jar",
1242 srcs: [
1243 "a.java",
1244 ],
1245 }
1246
1247 java_system_modules {
1248 name: "source-system-modules",
1249 libs: ["source-jar"],
1250 }
1251
1252 droidstubs {
1253 name: "stubs-prebuilt-system-modules",
1254 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001255 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001256 ],
1257 sdk_version: "none",
1258 system_modules: "prebuilt-system-modules",
1259 }
1260
1261 java_import {
1262 name: "prebuilt-jar",
1263 jars: ["a.jar"],
1264 }
1265
1266 java_system_modules_import {
1267 name: "prebuilt-system-modules",
1268 libs: ["prebuilt-jar"],
1269 }
1270 `)
1271
1272 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-source-system-modules", "source-jar.jar")
1273
1274 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-prebuilt-system-modules", "prebuilt-jar.jar")
1275}
1276
1277func checkSystemModulesUseByDroidstubs(t *testing.T, ctx *android.TestContext, moduleName string, systemJar string) {
1278 metalavaRule := ctx.ModuleForTests(moduleName, "android_common").Rule("metalava")
1279 var systemJars []string
1280 for _, i := range metalavaRule.Implicits {
1281 systemJars = append(systemJars, i.Base())
1282 }
Ramy Medhatc7965cd2020-04-30 03:08:37 -04001283 if len(systemJars) < 1 || systemJars[0] != systemJar {
Paul Duffin83a2d962019-11-19 19:44:10 +00001284 t.Errorf("inputs of %q must be []string{%q}, but was %#v.", moduleName, systemJar, systemJars)
1285 }
1286}
1287
Colin Cross54250902017-12-05 09:28:08 -08001288func TestJarGenrules(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001289 ctx, _ := testJava(t, `
Colin Cross54250902017-12-05 09:28:08 -08001290 java_library {
1291 name: "foo",
1292 srcs: ["a.java"],
1293 }
1294
1295 java_genrule {
1296 name: "jargen",
1297 tool_files: ["b.java"],
1298 cmd: "$(location b.java) $(in) $(out)",
1299 out: ["jargen.jar"],
1300 srcs: [":foo"],
1301 }
1302
1303 java_library {
1304 name: "bar",
1305 static_libs: ["jargen"],
1306 srcs: ["c.java"],
1307 }
1308
1309 java_library {
1310 name: "baz",
1311 libs: ["jargen"],
1312 srcs: ["c.java"],
1313 }
1314 `)
1315
1316 foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar")
1317 jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar")
1318 bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar")
1319 baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar")
1320 barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar")
1321
1322 if len(jargen.Inputs) != 1 || jargen.Inputs[0].String() != foo.Output.String() {
1323 t.Errorf("expected jargen inputs [%q], got %q", foo.Output.String(), jargen.Inputs.Strings())
1324 }
1325
1326 if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) {
1327 t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String())
1328 }
1329
1330 if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) {
1331 t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String())
1332 }
1333
1334 if len(barCombined.Inputs) != 2 ||
1335 barCombined.Inputs[0].String() != bar.Output.String() ||
1336 barCombined.Inputs[1].String() != jargen.Output.String() {
1337 t.Errorf("bar combined jar inputs %v is not [%q, %q]",
1338 barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String())
1339 }
1340}
1341
Nan Zhang27e284d2018-02-09 21:03:53 +00001342func TestExcludeFileGroupInSrcs(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001343 ctx, _ := testJava(t, `
Nan Zhang27e284d2018-02-09 21:03:53 +00001344 java_library {
1345 name: "foo",
1346 srcs: ["a.java", ":foo-srcs"],
1347 exclude_srcs: ["a.java", ":foo-excludes"],
1348 }
1349
1350 filegroup {
1351 name: "foo-srcs",
1352 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
1353 }
1354
1355 filegroup {
1356 name: "foo-excludes",
1357 srcs: ["java-fg/a.java", "java-fg/b.java"],
1358 }
1359 `)
1360
1361 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1362
1363 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
1364 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
1365 }
1366}
Jiyong Parkc678ad32018-04-10 13:07:10 +09001367
Paul Duffin52d398a2019-06-11 12:31:14 +01001368func TestJavaLibrary(t *testing.T) {
Colin Cross98be1bb2019-12-13 20:41:13 -08001369 config := testConfig(nil, "", map[string][]byte{
Paul Duffin52d398a2019-06-11 12:31:14 +01001370 "libcore/Android.bp": []byte(`
1371 java_library {
1372 name: "core",
1373 sdk_version: "none",
1374 system_modules: "none",
1375 }`),
1376 })
Colin Cross98be1bb2019-12-13 20:41:13 -08001377 ctx := testContext()
Paul Duffin52d398a2019-06-11 12:31:14 +01001378 run(t, ctx, config)
1379}
1380
Jiyong Parkc678ad32018-04-10 13:07:10 +09001381func TestJavaSdkLibrary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001382 ctx, _ := testJava(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001383 droiddoc_exported_dir {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001384 name: "droiddoc-templates-sdk",
1385 path: ".",
1386 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001387 java_sdk_library {
1388 name: "foo",
1389 srcs: ["a.java", "b.java"],
1390 api_packages: ["foo"],
1391 }
1392 java_sdk_library {
1393 name: "bar",
1394 srcs: ["a.java", "b.java"],
1395 api_packages: ["bar"],
1396 }
1397 java_library {
1398 name: "baz",
1399 srcs: ["c.java"],
Paul Duffin859fe962020-05-15 10:20:31 +01001400 libs: ["foo", "bar.stubs"],
Jiyong Parkc678ad32018-04-10 13:07:10 +09001401 sdk_version: "system_current",
1402 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001403 java_sdk_library {
1404 name: "barney",
1405 srcs: ["c.java"],
1406 api_only: true,
1407 }
1408 java_sdk_library {
1409 name: "betty",
1410 srcs: ["c.java"],
1411 shared_library: false,
1412 }
Paul Duffin859fe962020-05-15 10:20:31 +01001413 java_sdk_library_import {
1414 name: "quuz",
1415 public: {
1416 jars: ["c.jar"],
1417 },
1418 }
1419 java_sdk_library_import {
1420 name: "fred",
1421 public: {
1422 jars: ["b.jar"],
1423 },
1424 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001425 java_sdk_library_import {
1426 name: "wilma",
1427 public: {
1428 jars: ["b.jar"],
1429 },
1430 shared_library: false,
1431 }
Jiyong Park1be96912018-05-28 18:02:19 +09001432 java_library {
1433 name: "qux",
1434 srcs: ["c.java"],
Paul Duffindfa131e2020-05-15 20:37:11 +01001435 libs: ["baz", "fred", "quuz.stubs", "wilma", "barney", "betty"],
Jiyong Park1be96912018-05-28 18:02:19 +09001436 sdk_version: "system_current",
1437 }
Paul Duffin726d23c2020-01-22 16:30:37 +00001438 java_library {
1439 name: "baz-test",
1440 srcs: ["c.java"],
1441 libs: ["foo"],
1442 sdk_version: "test_current",
1443 }
Paul Duffina2db18f2020-01-22 17:11:15 +00001444 java_library {
1445 name: "baz-29",
1446 srcs: ["c.java"],
1447 libs: ["foo"],
1448 sdk_version: "system_29",
1449 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001450 `)
1451
1452 // check the existence of the internal modules
1453 ctx.ModuleForTests("foo", "android_common")
Paul Duffindd9d0742020-05-08 15:52:37 +01001454 ctx.ModuleForTests(apiScopePublic.stubsLibraryModuleName("foo"), "android_common")
1455 ctx.ModuleForTests(apiScopeSystem.stubsLibraryModuleName("foo"), "android_common")
1456 ctx.ModuleForTests(apiScopeTest.stubsLibraryModuleName("foo"), "android_common")
1457 ctx.ModuleForTests(apiScopePublic.stubsSourceModuleName("foo"), "android_common")
1458 ctx.ModuleForTests(apiScopeSystem.stubsSourceModuleName("foo"), "android_common")
1459 ctx.ModuleForTests(apiScopeTest.stubsSourceModuleName("foo"), "android_common")
Jiyong Parke3833882020-02-17 17:28:10 +09001460 ctx.ModuleForTests("foo"+sdkXmlFileSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +09001461 ctx.ModuleForTests("foo.api.public.28", "")
1462 ctx.ModuleForTests("foo.api.system.28", "")
1463 ctx.ModuleForTests("foo.api.test.28", "")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001464
1465 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1466 // tests if baz is actually linked to the stubs lib
1467 if !strings.Contains(bazJavac.Args["classpath"], "foo.stubs.system.jar") {
1468 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
1469 "foo.stubs.system.jar")
1470 }
1471 // ... and not to the impl lib
Sundong Ahn054b19a2018-10-19 13:46:09 +09001472 if strings.Contains(bazJavac.Args["classpath"], "foo.jar") {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001473 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
Sundong Ahn054b19a2018-10-19 13:46:09 +09001474 "foo.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001475 }
1476 // test if baz is not linked to the system variant of foo
1477 if strings.Contains(bazJavac.Args["classpath"], "foo.stubs.jar") {
1478 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
1479 "foo.stubs.jar")
1480 }
Jiyong Park1be96912018-05-28 18:02:19 +09001481
Paul Duffin726d23c2020-01-22 16:30:37 +00001482 bazTestJavac := ctx.ModuleForTests("baz-test", "android_common").Rule("javac")
1483 // tests if baz-test is actually linked to the test stubs lib
1484 if !strings.Contains(bazTestJavac.Args["classpath"], "foo.stubs.test.jar") {
1485 t.Errorf("baz-test javac classpath %v does not contain %q", bazTestJavac.Args["classpath"],
1486 "foo.stubs.test.jar")
1487 }
1488
Paul Duffina2db18f2020-01-22 17:11:15 +00001489 baz29Javac := ctx.ModuleForTests("baz-29", "android_common").Rule("javac")
1490 // tests if baz-29 is actually linked to the system 29 stubs lib
1491 if !strings.Contains(baz29Javac.Args["classpath"], "prebuilts/sdk/29/system/foo.jar") {
1492 t.Errorf("baz-29 javac classpath %v does not contain %q", baz29Javac.Args["classpath"],
1493 "prebuilts/sdk/29/system/foo.jar")
1494 }
1495
Jiyong Park1be96912018-05-28 18:02:19 +09001496 // test if baz has exported SDK lib names foo and bar to qux
1497 qux := ctx.ModuleForTests("qux", "android_common")
1498 if quxLib, ok := qux.Module().(*Library); ok {
1499 sdkLibs := quxLib.ExportedSdkLibs()
Paul Duffin859fe962020-05-15 10:20:31 +01001500 sort.Strings(sdkLibs)
1501 if w := []string{"bar", "foo", "fred", "quuz"}; !reflect.DeepEqual(w, sdkLibs) {
1502 t.Errorf("qux should export %q but exports %q", w, sdkLibs)
Jiyong Park1be96912018-05-28 18:02:19 +09001503 }
1504 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001505}
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001506
Paul Duffindaaa3322020-05-26 18:13:57 +01001507func TestJavaSdkLibrary_DoNotAccessImplWhenItIsNotBuilt(t *testing.T) {
1508 ctx, _ := testJava(t, `
1509 java_sdk_library {
1510 name: "foo",
1511 srcs: ["a.java"],
1512 api_only: true,
1513 public: {
1514 enabled: true,
1515 },
1516 }
1517
1518 java_library {
1519 name: "bar",
1520 srcs: ["b.java"],
1521 libs: ["foo"],
1522 }
1523 `)
1524
1525 // The bar library should depend on the stubs jar.
1526 barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1527 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1528 t.Errorf("expected %q, found %#q", expected, actual)
1529 }
1530}
1531
Paul Duffin46dc45a2020-05-14 15:39:10 +01001532func TestJavaSdkLibrary_UseSourcesFromAnotherSdkLibrary(t *testing.T) {
1533 testJava(t, `
1534 java_sdk_library {
1535 name: "foo",
1536 srcs: ["a.java"],
1537 api_packages: ["foo"],
1538 public: {
1539 enabled: true,
1540 },
1541 }
1542
1543 java_library {
1544 name: "bar",
1545 srcs: ["b.java", ":foo{.public.stubs.source}"],
1546 }
1547 `)
1548}
1549
1550func TestJavaSdkLibrary_AccessOutputFiles_MissingScope(t *testing.T) {
1551 testJavaError(t, `"foo" does not provide api scope system`, `
1552 java_sdk_library {
1553 name: "foo",
1554 srcs: ["a.java"],
1555 api_packages: ["foo"],
1556 public: {
1557 enabled: true,
1558 },
1559 }
1560
1561 java_library {
1562 name: "bar",
1563 srcs: ["b.java", ":foo{.system.stubs.source}"],
1564 }
1565 `)
1566}
1567
Paul Duffinca8d9a52020-06-26 22:20:25 +01001568func TestJavaSdkLibrary_Deps(t *testing.T) {
1569 ctx, _ := testJava(t, `
1570 java_sdk_library {
1571 name: "sdklib",
1572 srcs: ["a.java"],
1573 sdk_version: "none",
1574 system_modules: "none",
1575 public: {
1576 enabled: true,
1577 },
1578 }
1579 `)
1580
Paul Duffincee7e662020-07-09 17:32:57 +01001581 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +01001582 `dex2oatd`,
1583 `sdklib.impl`,
1584 `sdklib.stubs`,
1585 `sdklib.stubs.source`,
1586 `sdklib.xml`,
1587 })
1588}
1589
Paul Duffin46dc45a2020-05-14 15:39:10 +01001590func TestJavaSdkLibraryImport_AccessOutputFiles(t *testing.T) {
1591 testJava(t, `
1592 java_sdk_library_import {
1593 name: "foo",
1594 public: {
1595 jars: ["a.jar"],
1596 stub_srcs: ["a.java"],
1597 current_api: "api/current.txt",
1598 removed_api: "api/removed.txt",
1599 },
1600 }
1601
1602 java_library {
1603 name: "bar",
1604 srcs: [":foo{.public.stubs.source}"],
1605 java_resources: [
1606 ":foo{.public.api.txt}",
1607 ":foo{.public.removed-api.txt}",
1608 ],
1609 }
1610 `)
1611}
1612
1613func TestJavaSdkLibraryImport_AccessOutputFiles_Invalid(t *testing.T) {
1614 bp := `
1615 java_sdk_library_import {
1616 name: "foo",
1617 public: {
1618 jars: ["a.jar"],
1619 },
1620 }
1621 `
1622
1623 t.Run("stubs.source", func(t *testing.T) {
1624 testJavaError(t, `stubs.source not available for api scope public`, bp+`
1625 java_library {
1626 name: "bar",
1627 srcs: [":foo{.public.stubs.source}"],
1628 java_resources: [
1629 ":foo{.public.api.txt}",
1630 ":foo{.public.removed-api.txt}",
1631 ],
1632 }
1633 `)
1634 })
1635
1636 t.Run("api.txt", func(t *testing.T) {
1637 testJavaError(t, `api.txt not available for api scope public`, bp+`
1638 java_library {
1639 name: "bar",
1640 srcs: ["a.java"],
1641 java_resources: [
1642 ":foo{.public.api.txt}",
1643 ],
1644 }
1645 `)
1646 })
1647
1648 t.Run("removed-api.txt", func(t *testing.T) {
1649 testJavaError(t, `removed-api.txt not available for api scope public`, bp+`
1650 java_library {
1651 name: "bar",
1652 srcs: ["a.java"],
1653 java_resources: [
1654 ":foo{.public.removed-api.txt}",
1655 ],
1656 }
1657 `)
1658 })
1659}
1660
Paul Duffin3375e352020-04-28 10:44:03 +01001661func TestJavaSdkLibrary_InvalidScopes(t *testing.T) {
1662 testJavaError(t, `module "foo": enabled api scope "system" depends on disabled scope "public"`, `
1663 java_sdk_library {
1664 name: "foo",
1665 srcs: ["a.java", "b.java"],
1666 api_packages: ["foo"],
1667 // Explicitly disable public to test the check that ensures the set of enabled
1668 // scopes is consistent.
1669 public: {
1670 enabled: false,
1671 },
1672 system: {
1673 enabled: true,
1674 },
1675 }
1676 `)
1677}
1678
Paul Duffin87a05a32020-05-12 11:50:28 +01001679func TestJavaSdkLibrary_SdkVersion_ForScope(t *testing.T) {
1680 testJava(t, `
1681 java_sdk_library {
1682 name: "foo",
1683 srcs: ["a.java", "b.java"],
1684 api_packages: ["foo"],
1685 system: {
1686 enabled: true,
1687 sdk_version: "module_current",
1688 },
1689 }
1690 `)
1691}
1692
Paul Duffin0c5bae52020-06-02 13:00:08 +01001693func TestJavaSdkLibrary_ModuleLib(t *testing.T) {
1694 testJava(t, `
1695 java_sdk_library {
1696 name: "foo",
1697 srcs: ["a.java", "b.java"],
1698 api_packages: ["foo"],
1699 system: {
1700 enabled: true,
1701 },
1702 module_lib: {
1703 enabled: true,
1704 },
1705 }
1706 `)
1707}
1708
1709func TestJavaSdkLibrary_SystemServer(t *testing.T) {
1710 testJava(t, `
1711 java_sdk_library {
1712 name: "foo",
1713 srcs: ["a.java", "b.java"],
1714 api_packages: ["foo"],
1715 system: {
1716 enabled: true,
1717 },
1718 system_server: {
1719 enabled: true,
1720 },
1721 }
1722 `)
1723}
1724
Paul Duffin803a9562020-05-20 11:52:25 +01001725func TestJavaSdkLibrary_MissingScope(t *testing.T) {
1726 testJavaError(t, `requires api scope module-lib from foo but it only has \[\] available`, `
1727 java_sdk_library {
1728 name: "foo",
1729 srcs: ["a.java"],
1730 public: {
1731 enabled: false,
1732 },
1733 }
1734
1735 java_library {
1736 name: "baz",
1737 srcs: ["a.java"],
1738 libs: ["foo"],
1739 sdk_version: "module_current",
1740 }
1741 `)
1742}
1743
1744func TestJavaSdkLibrary_FallbackScope(t *testing.T) {
1745 testJava(t, `
1746 java_sdk_library {
1747 name: "foo",
1748 srcs: ["a.java"],
1749 system: {
1750 enabled: true,
1751 },
1752 }
1753
1754 java_library {
1755 name: "baz",
1756 srcs: ["a.java"],
1757 libs: ["foo"],
1758 // foo does not have module-lib scope so it should fallback to system
1759 sdk_version: "module_current",
1760 }
1761 `)
1762}
1763
Jiyong Park932cdfe2020-05-28 00:19:53 +09001764func TestJavaSdkLibrary_DefaultToStubs(t *testing.T) {
1765 ctx, _ := testJava(t, `
1766 java_sdk_library {
1767 name: "foo",
1768 srcs: ["a.java"],
1769 system: {
1770 enabled: true,
1771 },
1772 default_to_stubs: true,
1773 }
1774
1775 java_library {
1776 name: "baz",
1777 srcs: ["a.java"],
1778 libs: ["foo"],
1779 // does not have sdk_version set, should fallback to module,
1780 // which will then fallback to system because the module scope
1781 // is not enabled.
1782 }
1783 `)
1784 // The baz library should depend on the system stubs jar.
1785 bazLibrary := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1786 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs.system\.jar$`, bazLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1787 t.Errorf("expected %q, found %#q", expected, actual)
1788 }
1789}
1790
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001791var compilerFlagsTestCases = []struct {
1792 in string
1793 out bool
1794}{
1795 {
1796 in: "a",
1797 out: false,
1798 },
1799 {
1800 in: "-a",
1801 out: true,
1802 },
1803 {
1804 in: "-no-jdk",
1805 out: false,
1806 },
1807 {
1808 in: "-no-stdlib",
1809 out: false,
1810 },
1811 {
1812 in: "-kotlin-home",
1813 out: false,
1814 },
1815 {
1816 in: "-kotlin-home /some/path",
1817 out: false,
1818 },
1819 {
1820 in: "-include-runtime",
1821 out: false,
1822 },
1823 {
1824 in: "-Xintellij-plugin-root",
1825 out: false,
1826 },
1827}
1828
1829type mockContext struct {
1830 android.ModuleContext
1831 result bool
1832}
1833
1834func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
1835 // CheckBadCompilerFlags calls this function when the flag should be rejected
1836 ctx.result = false
1837}
1838
1839func TestCompilerFlags(t *testing.T) {
1840 for _, testCase := range compilerFlagsTestCases {
1841 ctx := &mockContext{result: true}
1842 CheckKotlincFlags(ctx, []string{testCase.in})
1843 if ctx.result != testCase.out {
1844 t.Errorf("incorrect output:")
1845 t.Errorf(" input: %#v", testCase.in)
1846 t.Errorf(" expected: %#v", testCase.out)
1847 t.Errorf(" got: %#v", ctx.result)
1848 }
1849 }
1850}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001851
1852// TODO(jungjw): Consider making this more robust by ignoring path order.
1853func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
1854 variables := ctx.ModuleForTests(moduleName, "android_common").Module().VariablesForTests()
1855 flags := strings.Split(variables["javacFlags"], " ")
1856 got := ""
1857 for _, flag := range flags {
1858 keyEnd := strings.Index(flag, "=")
1859 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
1860 got = flag[keyEnd+1:]
1861 break
1862 }
1863 }
1864 if expected != got {
1865 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
1866 }
1867}
1868
1869func TestPatchModule(t *testing.T) {
Pete Gillin0c2143e2019-05-02 15:32:11 +01001870 t.Run("Java language level 8", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001871 // Test with legacy javac -source 1.8 -target 1.8
Pete Gillinbdf5d712019-10-21 14:29:58 +01001872 bp := `
1873 java_library {
1874 name: "foo",
1875 srcs: ["a.java"],
1876 java_version: "1.8",
1877 }
1878
1879 java_library {
1880 name: "bar",
1881 srcs: ["b.java"],
1882 sdk_version: "none",
1883 system_modules: "none",
1884 patch_module: "java.base",
1885 java_version: "1.8",
1886 }
1887
1888 java_library {
1889 name: "baz",
1890 srcs: ["c.java"],
1891 patch_module: "java.base",
1892 java_version: "1.8",
1893 }
1894 `
1895 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001896
1897 checkPatchModuleFlag(t, ctx, "foo", "")
1898 checkPatchModuleFlag(t, ctx, "bar", "")
1899 checkPatchModuleFlag(t, ctx, "baz", "")
1900 })
1901
Pete Gillin0c2143e2019-05-02 15:32:11 +01001902 t.Run("Java language level 9", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001903 // Test with default javac -source 9 -target 9
Pete Gillinbdf5d712019-10-21 14:29:58 +01001904 bp := `
1905 java_library {
1906 name: "foo",
1907 srcs: ["a.java"],
1908 }
1909
1910 java_library {
1911 name: "bar",
1912 srcs: ["b.java"],
1913 sdk_version: "none",
1914 system_modules: "none",
1915 patch_module: "java.base",
1916 }
1917
1918 java_library {
1919 name: "baz",
1920 srcs: ["c.java"],
1921 patch_module: "java.base",
1922 }
1923 `
Pete Gillin1b3370f2019-10-01 13:57:31 +01001924 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001925
1926 checkPatchModuleFlag(t, ctx, "foo", "")
1927 expected := "java.base=.:" + buildDir
1928 checkPatchModuleFlag(t, ctx, "bar", expected)
Jiyong Park231d0562019-12-18 17:28:17 +09001929 expected = "java.base=" + strings.Join([]string{".", buildDir, moduleToPath("ext"), moduleToPath("framework")}, ":")
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001930 checkPatchModuleFlag(t, ctx, "baz", expected)
1931 })
1932}
Paul Duffina7b9f422020-01-10 17:12:18 +00001933
1934func TestJavaSystemModules(t *testing.T) {
1935 ctx, _ := testJava(t, `
1936 java_system_modules {
1937 name: "system-modules",
1938 libs: ["system-module1", "system-module2"],
1939 }
1940 java_library {
1941 name: "system-module1",
1942 srcs: ["a.java"],
1943 sdk_version: "none",
1944 system_modules: "none",
1945 }
1946 java_library {
1947 name: "system-module2",
1948 srcs: ["b.java"],
1949 sdk_version: "none",
1950 system_modules: "none",
1951 }
1952 `)
1953
1954 // check the existence of the module
1955 systemModules := ctx.ModuleForTests("system-modules", "android_common")
1956
1957 cmd := systemModules.Rule("jarsTosystemModules")
1958
1959 // make sure the command compiles against the supplied modules.
1960 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
1961 if !strings.Contains(cmd.Args["classpath"], module) {
1962 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
1963 module)
1964 }
1965 }
1966}
Paul Duffin90169ba2020-01-10 17:16:44 +00001967
1968func TestJavaSystemModulesImport(t *testing.T) {
1969 ctx, _ := testJava(t, `
1970 java_system_modules_import {
1971 name: "system-modules",
1972 libs: ["system-module1", "system-module2"],
1973 }
1974 java_import {
1975 name: "system-module1",
1976 jars: ["a.jar"],
1977 }
1978 java_import {
1979 name: "system-module2",
1980 jars: ["b.jar"],
1981 }
1982 `)
1983
1984 // check the existence of the module
1985 systemModules := ctx.ModuleForTests("system-modules", "android_common")
1986
1987 cmd := systemModules.Rule("jarsTosystemModules")
1988
1989 // make sure the command compiles against the supplied modules.
1990 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
1991 if !strings.Contains(cmd.Args["classpath"], module) {
1992 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
1993 module)
1994 }
1995 }
1996}
Paul Duffin83a2d962019-11-19 19:44:10 +00001997
1998func TestJavaLibraryWithSystemModules(t *testing.T) {
1999 ctx, _ := testJava(t, `
2000 java_library {
2001 name: "lib-with-source-system-modules",
2002 srcs: [
2003 "a.java",
2004 ],
2005 sdk_version: "none",
2006 system_modules: "source-system-modules",
2007 }
2008
2009 java_library {
2010 name: "source-jar",
2011 srcs: [
2012 "a.java",
2013 ],
2014 }
2015
2016 java_system_modules {
2017 name: "source-system-modules",
2018 libs: ["source-jar"],
2019 }
2020
2021 java_library {
2022 name: "lib-with-prebuilt-system-modules",
2023 srcs: [
2024 "a.java",
2025 ],
2026 sdk_version: "none",
2027 system_modules: "prebuilt-system-modules",
2028 }
2029
2030 java_import {
2031 name: "prebuilt-jar",
2032 jars: ["a.jar"],
2033 }
2034
2035 java_system_modules_import {
2036 name: "prebuilt-system-modules",
2037 libs: ["prebuilt-jar"],
2038 }
2039 `)
2040
2041 checkBootClasspathForSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar")
2042
2043 checkBootClasspathForSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar")
2044}
2045
2046func checkBootClasspathForSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) {
2047 javacRule := ctx.ModuleForTests(moduleName, "android_common").Rule("javac")
2048 bootClasspath := javacRule.Args["bootClasspath"]
2049 if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) {
2050 t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath)
2051 }
2052}
Jiyong Park19604de2020-03-24 16:44:11 +09002053
2054func TestAidlExportIncludeDirsFromImports(t *testing.T) {
2055 ctx, _ := testJava(t, `
2056 java_library {
2057 name: "foo",
2058 srcs: ["aidl/foo/IFoo.aidl"],
2059 libs: ["bar"],
2060 }
2061
2062 java_import {
2063 name: "bar",
2064 jars: ["a.jar"],
2065 aidl: {
2066 export_include_dirs: ["aidl/bar"],
2067 },
2068 }
2069 `)
2070
2071 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
2072 expectedAidlFlag := "-Iaidl/bar"
2073 if !strings.Contains(aidlCommand, expectedAidlFlag) {
2074 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
2075 }
2076}
Liz Kammerdd849a82020-06-12 16:38:45 -07002077
2078func TestDataNativeBinaries(t *testing.T) {
2079 ctx, config := testJava(t, `
2080 java_test_host {
2081 name: "foo",
2082 srcs: ["a.java"],
2083 data_native_bins: ["bin"]
2084 }
2085
2086 python_binary_host {
2087 name: "bin",
2088 srcs: ["bin.py"],
2089 }
2090 `)
2091
2092 buildOS := android.BuildOs.String()
2093
2094 test := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
2095 entries := android.AndroidMkEntriesForTest(t, config, "", test)[0]
2096 expected := []string{buildDir + "/.intermediates/bin/" + buildOS + "_x86_64_PY3/bin:bin"}
2097 actual := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
2098 if !reflect.DeepEqual(expected, actual) {
2099 t.Errorf("Unexpected test data - expected: %q, actual: %q", expected, actual)
2100 }
2101}