blob: 0e936118c07c8299d7da8a6129bfdc1621078f35 [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Colin Cross72bb3632017-07-13 16:23:21 -070018 "io/ioutil"
19 "os"
20 "path/filepath"
Colin Crossc0806172019-06-14 18:51:47 -070021 "reflect"
Paul Duffindaaa3322020-05-26 18:13:57 +010022 "regexp"
Nan Zhang61eaedb2017-11-02 13:28:15 -070023 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070024 "strings"
25 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070026
Jeongik Cha28df2572019-11-11 10:46:36 +090027 "github.com/google/blueprint/proptools"
28
Colin Crossa4f08812018-10-02 22:03:40 -070029 "android/soong/android"
30 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080031 "android/soong/dexpreopt"
Colin Crossa4f08812018-10-02 22:03:40 -070032 "android/soong/genrule"
Liz Kammerdd849a82020-06-12 16:38:45 -070033 "android/soong/python"
Colin Cross72bb3632017-07-13 16:23:21 -070034)
35
36var buildDir string
37
38func setUp() {
39 var err error
40 buildDir, err = ioutil.TempDir("", "soong_java_test")
41 if err != nil {
42 panic(err)
43 }
44}
45
46func tearDown() {
47 os.RemoveAll(buildDir)
48}
49
50func TestMain(m *testing.M) {
51 run := func() int {
52 setUp()
53 defer tearDown()
54
55 return m.Run()
56 }
57
58 os.Exit(run())
59}
Colin Cross527012a2017-11-30 22:56:16 -080060
Colin Cross98be1bb2019-12-13 20:41:13 -080061func testConfig(env map[string]string, bp string, fs map[string][]byte) android.Config {
Martin Stjernholmd90676f2020-01-11 00:37:30 +000062 bp += dexpreopt.BpToolModulesForTest()
63
Martin Stjernholm75a48d82020-01-10 20:32:59 +000064 config := TestConfig(buildDir, env, bp, fs)
65
66 // Set up the global Once cache used for dexpreopt.GlobalSoongConfig, so that
67 // it doesn't create a real one, which would fail.
68 _ = dexpreopt.GlobalSoongConfigForTests(config)
69
70 return config
Colin Cross1369cdb2017-09-29 17:58:17 -070071}
72
Colin Cross98be1bb2019-12-13 20:41:13 -080073func testContext() *android.TestContext {
Colin Cross72bb3632017-07-13 16:23:21 -070074
Colin Cross4c428df2017-09-15 17:36:05 -070075 ctx := android.NewTestArchContext()
Paul Duffinf9b1da02019-12-18 19:51:55 +000076 RegisterJavaBuildComponents(ctx)
77 RegisterAppBuildComponents(ctx)
78 RegisterAARBuildComponents(ctx)
Paul Duffinb0f85072019-12-19 10:28:56 +000079 RegisterGenRuleBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000080 RegisterSystemModulesBuildComponents(ctx)
Colin Cross4b49b762019-11-22 15:25:03 -080081 ctx.RegisterModuleType("java_plugin", PluginFactory)
Colin Cross4b49b762019-11-22 15:25:03 -080082 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
83 ctx.RegisterModuleType("genrule", genrule.GenRuleFactory)
Liz Kammerdd849a82020-06-12 16:38:45 -070084 ctx.RegisterModuleType("python_binary_host", python.PythonBinaryHostFactory)
Paul Duffin884363e2019-12-19 10:21:09 +000085 RegisterDocsBuildComponents(ctx)
86 RegisterStubsBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000087 RegisterSdkLibraryBuildComponents(ctx)
Colin Cross89536d42017-07-07 14:35:50 -070088 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Paul Duffin44f1d842020-06-26 20:17:02 +010089 ctx.PreArchMutators(android.RegisterComponentsMutator)
Paul Duffina48f7582019-12-19 11:25:19 +000090
91 RegisterPrebuiltApisBuildComponents(ctx)
92
Liz Kammerdd849a82020-06-12 16:38:45 -070093 ctx.PreDepsMutators(python.RegisterPythonPreDepsMutators)
Jaewoong Jungb639a6a2019-05-10 15:16:29 -070094 ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
Colin Cross3bc7ffa2017-11-22 16:19:37 -080095 ctx.RegisterPreSingletonType("overlay", android.SingletonFactoryAdaptor(OverlaySingletonFactory))
Colin Cross3047fa22019-04-18 10:56:44 -070096 ctx.RegisterPreSingletonType("sdk_versions", android.SingletonFactoryAdaptor(sdkPreSingletonFactory))
Colin Crossa4f08812018-10-02 22:03:40 -070097
Paul Duffin021f4e52020-07-30 16:04:17 +010098 android.RegisterPrebuiltMutators(ctx)
99
Colin Crossa4f08812018-10-02 22:03:40 -0700100 // Register module types and mutators from cc needed for JNI testing
Paul Duffin77980a82019-12-19 16:01:36 +0000101 cc.RegisterRequiredBuildComponentsForTest(ctx)
Colin Crossa4f08812018-10-02 22:03:40 -0700102
Martin Stjernholmd90676f2020-01-11 00:37:30 +0000103 dexpreopt.RegisterToolModulesForTest(ctx)
104
Colin Cross527012a2017-11-30 22:56:16 -0800105 return ctx
106}
107
108func run(t *testing.T, ctx *android.TestContext, config android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800109 t.Helper()
Colin Crossc28bb0b2019-02-25 14:20:47 -0800110
Colin Cross98be1bb2019-12-13 20:41:13 -0800111 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000112 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Colin Crossc28bb0b2019-02-25 14:20:47 -0800113
Colin Cross98be1bb2019-12-13 20:41:13 -0800114 ctx.Register(config)
Paul Duffinbaccf7e2019-06-11 11:58:30 +0100115 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
Logan Chien42039712018-03-12 16:29:17 +0800116 android.FailIfErrored(t, errs)
Colin Cross72bb3632017-07-13 16:23:21 -0700117 _, errs = ctx.PrepareBuildActions(config)
Logan Chien42039712018-03-12 16:29:17 +0800118 android.FailIfErrored(t, errs)
Colin Cross527012a2017-11-30 22:56:16 -0800119}
120
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900121func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) {
Jeongik Cha538c0d02019-07-11 15:54:27 +0900122 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800123 return testJavaErrorWithConfig(t, pattern, testConfig(nil, bp, nil))
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900124}
125
Colin Cross98be1bb2019-12-13 20:41:13 -0800126func testJavaErrorWithConfig(t *testing.T, pattern string, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900127 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800128 ctx := testContext()
Jeongik Cha538c0d02019-07-11 15:54:27 +0900129
Colin Cross98be1bb2019-12-13 20:41:13 -0800130 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000131 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Jeongik Cha538c0d02019-07-11 15:54:27 +0900132
Colin Cross98be1bb2019-12-13 20:41:13 -0800133 ctx.Register(config)
Jeongik Cha538c0d02019-07-11 15:54:27 +0900134 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
135 if len(errs) > 0 {
136 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900137 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900138 }
139 _, errs = ctx.PrepareBuildActions(config)
140 if len(errs) > 0 {
141 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900142 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900143 }
144
145 t.Fatalf("missing expected error %q (0 errors are returned)", pattern)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900146
147 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900148}
149
Colin Cross238c1f32020-06-07 16:58:18 -0700150func testJavaWithFS(t *testing.T, bp string, fs map[string][]byte) (*android.TestContext, android.Config) {
151 t.Helper()
152 return testJavaWithConfig(t, testConfig(nil, bp, fs))
153}
154
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700155func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800156 t.Helper()
Colin Cross238c1f32020-06-07 16:58:18 -0700157 return testJavaWithFS(t, bp, nil)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900158}
159
Colin Cross98be1bb2019-12-13 20:41:13 -0800160func testJavaWithConfig(t *testing.T, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900161 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800162 ctx := testContext()
Colin Cross527012a2017-11-30 22:56:16 -0800163 run(t, ctx, config)
Colin Cross72bb3632017-07-13 16:23:21 -0700164
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700165 return ctx, config
Colin Cross72bb3632017-07-13 16:23:21 -0700166}
167
Colin Cross2acdae82017-09-15 19:44:24 -0700168func moduleToPath(name string) string {
169 switch {
170 case name == `""`:
171 return name
Colin Crossfc3674a2017-09-18 17:41:52 -0700172 case strings.HasSuffix(name, ".jar"):
173 return name
Nan Zhanged19fc32017-10-19 13:06:22 -0700174 default:
175 return filepath.Join(buildDir, ".intermediates", name, "android_common", "turbine-combined", name+".jar")
Colin Cross2acdae82017-09-15 19:44:24 -0700176 }
177}
178
Jeongik Chae403e9e2019-12-07 00:16:24 +0900179func TestJavaLinkType(t *testing.T) {
180 testJava(t, `
181 java_library {
182 name: "foo",
183 srcs: ["a.java"],
184 libs: ["bar"],
185 static_libs: ["baz"],
186 }
187
188 java_library {
189 name: "bar",
190 sdk_version: "current",
191 srcs: ["b.java"],
192 }
193
194 java_library {
195 name: "baz",
196 sdk_version: "system_current",
197 srcs: ["c.java"],
198 }
199 `)
200
201 testJavaError(t, "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source.", `
202 java_library {
203 name: "foo",
204 srcs: ["a.java"],
205 libs: ["bar"],
206 sdk_version: "current",
207 static_libs: ["baz"],
208 }
209
210 java_library {
211 name: "bar",
212 sdk_version: "current",
213 srcs: ["b.java"],
214 }
215
216 java_library {
217 name: "baz",
218 sdk_version: "system_current",
219 srcs: ["c.java"],
220 }
221 `)
222
223 testJava(t, `
224 java_library {
225 name: "foo",
226 srcs: ["a.java"],
227 libs: ["bar"],
228 sdk_version: "system_current",
229 static_libs: ["baz"],
230 }
231
232 java_library {
233 name: "bar",
234 sdk_version: "current",
235 srcs: ["b.java"],
236 }
237
238 java_library {
239 name: "baz",
240 sdk_version: "system_current",
241 srcs: ["c.java"],
242 }
243 `)
244
245 testJavaError(t, "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source.", `
246 java_library {
247 name: "foo",
248 srcs: ["a.java"],
249 libs: ["bar"],
250 sdk_version: "system_current",
251 static_libs: ["baz"],
252 }
253
254 java_library {
255 name: "bar",
256 sdk_version: "current",
257 srcs: ["b.java"],
258 }
259
260 java_library {
261 name: "baz",
262 srcs: ["c.java"],
263 }
264 `)
265}
266
Colin Cross72bb3632017-07-13 16:23:21 -0700267func TestSimple(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700268 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700269 java_library {
270 name: "foo",
271 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700272 libs: ["bar"],
273 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700274 }
275
276 java_library {
277 name: "bar",
278 srcs: ["b.java"],
279 }
280
281 java_library {
282 name: "baz",
283 srcs: ["c.java"],
284 }
Colin Crossd5934c82017-10-02 13:55:26 -0700285 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700286
Colin Cross4c428df2017-09-15 17:36:05 -0700287 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700288 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700289
290 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
291 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
292 }
293
Colin Cross1ee23172017-10-18 14:44:18 -0700294 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Nan Zhanged19fc32017-10-19 13:06:22 -0700295 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
296 bazTurbine := filepath.Join(buildDir, ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700297
Nan Zhanged19fc32017-10-19 13:06:22 -0700298 if !strings.Contains(javac.Args["classpath"], barTurbine) {
299 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700300 }
301
Nan Zhanged19fc32017-10-19 13:06:22 -0700302 if !strings.Contains(javac.Args["classpath"], bazTurbine) {
303 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700304 }
305
306 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
307 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700308 }
309}
310
Artur Satayev9cf46692019-11-26 18:08:34 +0000311func TestExportedPlugins(t *testing.T) {
312 type Result struct {
313 library string
314 processors string
315 }
316 var tests = []struct {
317 name string
318 extra string
319 results []Result
320 }{
321 {
322 name: "Exported plugin is not a direct plugin",
323 extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`,
324 results: []Result{{library: "exports", processors: "-proc:none"}},
325 },
326 {
327 name: "Exports plugin to dependee",
328 extra: `
329 java_library{name: "exports", exported_plugins: ["plugin"]}
330 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
331 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
332 `,
333 results: []Result{
334 {library: "foo", processors: "-processor com.android.TestPlugin"},
335 {library: "bar", processors: "-processor com.android.TestPlugin"},
336 },
337 },
338 {
339 name: "Exports plugin to android_library",
340 extra: `
341 java_library{name: "exports", exported_plugins: ["plugin"]}
342 android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
343 android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
344 `,
345 results: []Result{
346 {library: "foo", processors: "-processor com.android.TestPlugin"},
347 {library: "bar", processors: "-processor com.android.TestPlugin"},
348 },
349 },
350 {
351 name: "Exports plugin is not propagated via transitive deps",
352 extra: `
353 java_library{name: "exports", exported_plugins: ["plugin"]}
354 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
355 java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]}
356 `,
357 results: []Result{
358 {library: "foo", processors: "-processor com.android.TestPlugin"},
359 {library: "bar", processors: "-proc:none"},
360 },
361 },
362 {
363 name: "Exports plugin appends to plugins",
364 extra: `
365 java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"}
366 java_library{name: "exports", exported_plugins: ["plugin"]}
367 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]}
368 `,
369 results: []Result{
370 {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"},
371 },
372 },
373 }
374
375 for _, test := range tests {
376 t.Run(test.name, func(t *testing.T) {
377 ctx, _ := testJava(t, `
378 java_plugin {
379 name: "plugin",
380 processor_class: "com.android.TestPlugin",
381 }
382 `+test.extra)
383
384 for _, want := range test.results {
385 javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac")
386 if javac.Args["processor"] != want.processors {
387 t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"])
388 }
389 }
390 })
391 }
392}
393
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900394func TestSdkVersionByPartition(t *testing.T) {
395 testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900396 java_library {
397 name: "foo",
398 srcs: ["a.java"],
399 vendor: true,
400 }
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900401 `)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900402
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900403 testJava(t, `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900404 java_library {
405 name: "bar",
406 srcs: ["b.java"],
407 }
408 `)
409
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900410 for _, enforce := range []bool{true, false} {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900411 bp := `
412 java_library {
413 name: "foo",
414 srcs: ["a.java"],
415 product_specific: true,
416 }
417 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800418
419 config := testConfig(nil, bp, nil)
420 config.TestProductVariables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900421 if enforce {
Colin Cross98be1bb2019-12-13 20:41:13 -0800422 testJavaErrorWithConfig(t, "sdk_version must have a value when the module is located at vendor or product", config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900423 } else {
Colin Cross98be1bb2019-12-13 20:41:13 -0800424 testJavaWithConfig(t, config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900425 }
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900426 }
427}
428
Colin Crossd5934c82017-10-02 13:55:26 -0700429func TestArchSpecific(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700430 ctx, _ := testJava(t, `
Colin Crossd5934c82017-10-02 13:55:26 -0700431 java_library {
432 name: "foo",
433 srcs: ["a.java"],
434 target: {
435 android: {
436 srcs: ["b.java"],
437 },
438 },
439 }
440 `)
441
442 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
443 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
444 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
445 }
446}
447
Colin Cross6b4a32d2017-12-05 13:42:45 -0800448func TestBinary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700449 ctx, _ := testJava(t, `
Colin Cross6b4a32d2017-12-05 13:42:45 -0800450 java_library_host {
451 name: "foo",
452 srcs: ["a.java"],
453 }
454
455 java_binary_host {
456 name: "bar",
457 srcs: ["b.java"],
458 static_libs: ["foo"],
459 }
460 `)
461
462 buildOS := android.BuildOs.String()
463
464 bar := ctx.ModuleForTests("bar", buildOS+"_common")
465 barJar := bar.Output("bar.jar").Output.String()
466 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
467 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
468
469 // Test that the install binary wrapper depends on the installed jar file
470 if len(barWrapperDeps) != 1 || barWrapperDeps[0] != barJar {
471 t.Errorf("expected binary wrapper implicits [%q], got %v",
472 barJar, barWrapperDeps)
473 }
Alex Humesky2070e322020-06-09 20:23:08 -0400474}
Colin Cross6b4a32d2017-12-05 13:42:45 -0800475
Alex Humesky2070e322020-06-09 20:23:08 -0400476func TestHostBinaryNoJavaDebugInfoOverride(t *testing.T) {
477 bp := `
478 java_library {
479 name: "target_library",
480 srcs: ["a.java"],
481 }
482
483 java_binary_host {
484 name: "host_binary",
485 srcs: ["b.java"],
486 }
487 `
488 config := testConfig(nil, bp, nil)
489 config.TestProductVariables.MinimizeJavaDebugInfo = proptools.BoolPtr(true)
490
491 ctx, _ := testJavaWithConfig(t, config)
492
Liz Kammer7941b302020-07-28 13:27:34 -0700493 // first, check that the -g flag is added to target modules
Alex Humesky2070e322020-06-09 20:23:08 -0400494 targetLibrary := ctx.ModuleForTests("target_library", "android_common")
495 targetJavaFlags := targetLibrary.Module().VariablesForTests()["javacFlags"]
496 if !strings.Contains(targetJavaFlags, "-g:source,lines") {
497 t.Errorf("target library javac flags %v should contain "+
498 "-g:source,lines override with MinimizeJavaDebugInfo", targetJavaFlags)
499 }
500
501 // check that -g is not overridden for host modules
502 buildOS := android.BuildOs.String()
503 hostBinary := ctx.ModuleForTests("host_binary", buildOS+"_common")
504 hostJavaFlags := hostBinary.Module().VariablesForTests()["javacFlags"]
505 if strings.Contains(hostJavaFlags, "-g:source,lines") {
506 t.Errorf("java_binary_host javac flags %v should not have "+
507 "-g:source,lines override with MinimizeJavaDebugInfo", hostJavaFlags)
508 }
Colin Cross6b4a32d2017-12-05 13:42:45 -0800509}
510
Colin Cross72bb3632017-07-13 16:23:21 -0700511func TestPrebuilts(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700512 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700513 java_library {
514 name: "foo",
Paul Duffin91547182019-11-12 19:39:36 +0000515 srcs: ["a.java", ":stubs-source"],
Paul Duffinfcfd7912020-01-31 17:54:30 +0000516 libs: ["bar", "sdklib"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700517 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700518 }
519
Colin Cross74d73e22017-08-02 11:05:49 -0700520 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700521 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700522 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700523 }
524
Colin Cross74d73e22017-08-02 11:05:49 -0700525 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700526 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700527 jars: ["b.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700528 }
Colin Cross42be7612019-02-21 18:12:14 -0800529
530 dex_import {
531 name: "qux",
532 jars: ["b.jar"],
533 }
Colin Cross79c7c262019-04-17 11:11:46 -0700534
535 java_sdk_library_import {
Paul Duffin56d44902020-01-31 13:36:25 +0000536 name: "sdklib",
537 public: {
538 jars: ["c.jar"],
539 },
540 }
541
Paul Duffin91547182019-11-12 19:39:36 +0000542 prebuilt_stubs_sources {
543 name: "stubs-source",
Paul Duffin9b478b02019-12-10 13:41:51 +0000544 srcs: ["stubs/sources"],
Paul Duffin91547182019-11-12 19:39:36 +0000545 }
Paul Duffin1b82e6a2019-12-03 18:06:47 +0000546
547 java_test_import {
548 name: "test",
549 jars: ["a.jar"],
550 test_suites: ["cts"],
551 test_config: "AndroidTest.xml",
552 }
Colin Cross72bb3632017-07-13 16:23:21 -0700553 `)
554
Paul Duffin9b478b02019-12-10 13:41:51 +0000555 fooModule := ctx.ModuleForTests("foo", "android_common")
556 javac := fooModule.Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700557 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross37f6d792018-07-12 12:28:41 -0700558 barJar := ctx.ModuleForTests("bar", "android_common").Rule("combineJar").Output
559 bazJar := ctx.ModuleForTests("baz", "android_common").Rule("combineJar").Output
Colin Cross79c7c262019-04-17 11:11:46 -0700560 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700561
Paul Duffin9b478b02019-12-10 13:41:51 +0000562 fooLibrary := fooModule.Module().(*Library)
563 assertDeepEquals(t, "foo java sources incorrect",
564 []string{"a.java"}, fooLibrary.compiledJavaSrcs.Strings())
Paul Duffin91547182019-11-12 19:39:36 +0000565
Paul Duffin9b478b02019-12-10 13:41:51 +0000566 assertDeepEquals(t, "foo java source jars incorrect",
567 []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"},
568 android.NormalizePathsForTesting(fooLibrary.compiledSrcJars))
Paul Duffin91547182019-11-12 19:39:36 +0000569
Colin Cross37f6d792018-07-12 12:28:41 -0700570 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
571 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700572 }
573
Colin Cross79c7c262019-04-17 11:11:46 -0700574 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
575 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
576 }
577
Colin Cross37f6d792018-07-12 12:28:41 -0700578 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
579 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700580 }
Colin Cross42be7612019-02-21 18:12:14 -0800581
582 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Colin Cross72bb3632017-07-13 16:23:21 -0700583}
584
Paul Duffin9b478b02019-12-10 13:41:51 +0000585func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) {
586 if !reflect.DeepEqual(expected, actual) {
587 t.Errorf("%s: expected %q, found %q", message, expected, actual)
588 }
589}
590
Paul Duffin56d44902020-01-31 13:36:25 +0000591func TestJavaSdkLibraryImport(t *testing.T) {
592 ctx, _ := testJava(t, `
593 java_library {
594 name: "foo",
595 srcs: ["a.java"],
596 libs: ["sdklib"],
597 sdk_version: "current",
598 }
599
600 java_library {
601 name: "foo.system",
602 srcs: ["a.java"],
603 libs: ["sdklib"],
604 sdk_version: "system_current",
605 }
606
607 java_library {
608 name: "foo.test",
609 srcs: ["a.java"],
610 libs: ["sdklib"],
611 sdk_version: "test_current",
612 }
613
614 java_sdk_library_import {
615 name: "sdklib",
616 public: {
617 jars: ["a.jar"],
618 },
619 system: {
620 jars: ["b.jar"],
621 },
622 test: {
623 jars: ["c.jar"],
Paul Duffin0f8faff2020-05-20 16:18:00 +0100624 stub_srcs: ["c.java"],
Paul Duffin56d44902020-01-31 13:36:25 +0000625 },
626 }
627 `)
628
629 for _, scope := range []string{"", ".system", ".test"} {
630 fooModule := ctx.ModuleForTests("foo"+scope, "android_common")
631 javac := fooModule.Rule("javac")
632
633 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs"+scope, "android_common").Rule("combineJar").Output
634 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
635 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
636 }
637 }
Paul Duffinca8d9a52020-06-26 22:20:25 +0100638
Paul Duffincee7e662020-07-09 17:32:57 +0100639 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100640 `prebuilt_sdklib.stubs`,
641 `prebuilt_sdklib.stubs.source.test`,
642 `prebuilt_sdklib.stubs.system`,
643 `prebuilt_sdklib.stubs.test`,
644 })
645}
646
647func TestJavaSdkLibraryImport_WithSource(t *testing.T) {
648 ctx, _ := testJava(t, `
649 java_sdk_library {
650 name: "sdklib",
651 srcs: ["a.java"],
652 sdk_version: "none",
653 system_modules: "none",
654 public: {
655 enabled: true,
656 },
657 }
658
659 java_sdk_library_import {
660 name: "sdklib",
661 public: {
662 jars: ["a.jar"],
663 },
664 }
665 `)
666
Paul Duffincee7e662020-07-09 17:32:57 +0100667 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100668 `dex2oatd`,
669 `prebuilt_sdklib`,
670 `sdklib.impl`,
671 `sdklib.stubs`,
672 `sdklib.stubs.source`,
673 `sdklib.xml`,
674 })
675
Paul Duffincee7e662020-07-09 17:32:57 +0100676 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffin44f1d842020-06-26 20:17:02 +0100677 `prebuilt_sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100678 `sdklib.impl`,
679 // This should be prebuilt_sdklib.stubs but is set to sdklib.stubs because the
680 // dependency is added after prebuilts may have been renamed and so has to use
681 // the renamed name.
Paul Duffinca8d9a52020-06-26 22:20:25 +0100682 `sdklib.xml`,
683 })
684}
685
686func TestJavaSdkLibraryImport_Preferred(t *testing.T) {
687 ctx, _ := testJava(t, `
688 java_sdk_library {
689 name: "sdklib",
690 srcs: ["a.java"],
691 sdk_version: "none",
692 system_modules: "none",
693 public: {
694 enabled: true,
695 },
696 }
697
698 java_sdk_library_import {
699 name: "sdklib",
700 prefer: true,
701 public: {
702 jars: ["a.jar"],
703 },
704 }
705 `)
706
Paul Duffincee7e662020-07-09 17:32:57 +0100707 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100708 `dex2oatd`,
709 `prebuilt_sdklib`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100710 `sdklib.impl`,
Paul Duffin80342d72020-06-26 22:08:43 +0100711 `sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100712 `sdklib.stubs.source`,
713 `sdklib.xml`,
714 })
715
Paul Duffincee7e662020-07-09 17:32:57 +0100716 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100717 `prebuilt_sdklib.stubs`,
718 `sdklib.impl`,
719 `sdklib.xml`,
720 })
Paul Duffin56d44902020-01-31 13:36:25 +0000721}
722
Colin Cross89536d42017-07-07 14:35:50 -0700723func TestDefaults(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700724 ctx, _ := testJava(t, `
Colin Cross89536d42017-07-07 14:35:50 -0700725 java_defaults {
726 name: "defaults",
727 srcs: ["a.java"],
728 libs: ["bar"],
729 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -0700730 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700731 }
732
733 java_library {
734 name: "foo",
735 defaults: ["defaults"],
736 }
737
738 java_library {
739 name: "bar",
740 srcs: ["b.java"],
741 }
742
743 java_library {
744 name: "baz",
745 srcs: ["c.java"],
746 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700747
748 android_test {
749 name: "atestOptimize",
750 defaults: ["defaults"],
751 optimize: {enabled: true},
752 }
753
754 android_test {
755 name: "atestNoOptimize",
756 defaults: ["defaults"],
757 }
758
759 android_test {
760 name: "atestDefault",
761 srcs: ["a.java"],
762 }
Colin Cross89536d42017-07-07 14:35:50 -0700763 `)
764
Colin Cross4c428df2017-09-15 17:36:05 -0700765 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700766 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -0700767
768 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
769 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
770 }
771
Nan Zhanged19fc32017-10-19 13:06:22 -0700772 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
773 if !strings.Contains(javac.Args["classpath"], barTurbine) {
774 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -0700775 }
776
Colin Cross1ee23172017-10-18 14:44:18 -0700777 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -0700778 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
779 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -0700780 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700781
782 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
783 if atestOptimize.Output == nil {
784 t.Errorf("atestOptimize should optimize APK")
785 }
786
787 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
788 if atestNoOptimize.Output == nil {
789 t.Errorf("atestNoOptimize should not optimize APK")
790 }
791
792 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("r8")
793 if atestDefault.Output == nil {
794 t.Errorf("atestDefault should optimize APK")
795 }
Colin Cross89536d42017-07-07 14:35:50 -0700796}
797
Colin Cross0f37af02017-09-27 17:42:05 -0700798func TestResources(t *testing.T) {
799 var table = []struct {
800 name string
801 prop string
802 extra string
803 args string
804 }{
805 {
Colin Crossaf9c55b2017-10-03 14:50:08 -0700806 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -0700807 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -0800808 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700809 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700810 },
811 {
812 // Test that a module with java_resources includes the files
813 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -0700814 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
815 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700816 },
817 {
818 // Test that a module with a filegroup in java_resources includes the files with the
819 // path prefix
820 name: "resource filegroup",
821 prop: `java_resources: [":foo-res"]`,
822 extra: `
823 filegroup {
824 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -0800825 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -0700826 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -0700827 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700828 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700829 },
830 {
Colin Cross0ead1d72018-04-10 13:07:42 -0700831 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
832 name: "wildcard dirs",
833 prop: `java_resource_dirs: ["java-res/*"]`,
834 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
835 },
836 {
837 // Test that a module exclude_java_resource_dirs excludes the files
838 name: "wildcard dirs",
839 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
840 args: "-C java-res/a -f java-res/a/a",
841 },
Colin Crosscedd4762018-09-13 11:26:19 -0700842 {
843 // Test wildcards in java_resources
844 name: "wildcard files",
845 prop: `java_resources: ["java-res/**/*"]`,
846 args: "-C . -f java-res/a/a -f java-res/b/b",
847 },
848 {
849 // Test exclude_java_resources with java_resources
850 name: "wildcard files with exclude",
851 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
852 args: "-C . -f java-res/a/a",
853 },
854 {
855 // Test exclude_java_resources with java_resource_dirs
856 name: "resource dirs with exclude files",
857 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
858 args: "-C java-res -f java-res/a/a",
859 },
860 {
861 // Test exclude_java_resource_dirs with java_resource_dirs
862 name: "resource dirs with exclude files",
863 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
864 args: "-C java-res -f java-res/a/a -f java-res/b/b",
865 },
Colin Cross0f37af02017-09-27 17:42:05 -0700866 }
867
868 for _, test := range table {
869 t.Run(test.name, func(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700870 ctx, _ := testJavaWithFS(t, `
Colin Cross0f37af02017-09-27 17:42:05 -0700871 java_library {
872 name: "foo",
873 srcs: [
874 "a.java",
875 "b.java",
876 "c.java",
877 ],
878 `+test.prop+`,
879 }
Colin Cross238c1f32020-06-07 16:58:18 -0700880 `+test.extra,
881 map[string][]byte{
882 "java-res/a/a": nil,
883 "java-res/b/b": nil,
884 "java-res2/a": nil,
885 },
886 )
Colin Cross0f37af02017-09-27 17:42:05 -0700887
Colin Cross331a1212018-08-15 20:40:52 -0700888 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -0700889 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -0700890
891 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
892 t.Errorf("foo combined jars %v does not contain %q",
893 foo.Inputs.Strings(), fooRes.Output.String())
894 }
895
Colin Crossaf9c55b2017-10-03 14:50:08 -0700896 if fooRes.Args["jarArgs"] != test.args {
897 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -0700898 fooRes.Args["jarArgs"], test.args)
899 }
900 })
901 }
902}
903
Colin Cross0c4ce212019-05-03 15:28:19 -0700904func TestIncludeSrcs(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700905 ctx, _ := testJavaWithFS(t, `
Colin Cross0c4ce212019-05-03 15:28:19 -0700906 java_library {
907 name: "foo",
908 srcs: [
909 "a.java",
910 "b.java",
911 "c.java",
912 ],
913 include_srcs: true,
914 }
915
916 java_library {
917 name: "bar",
918 srcs: [
919 "a.java",
920 "b.java",
921 "c.java",
922 ],
923 java_resource_dirs: ["java-res"],
924 include_srcs: true,
925 }
Colin Cross238c1f32020-06-07 16:58:18 -0700926 `, map[string][]byte{
927 "java-res/a/a": nil,
928 "java-res/b/b": nil,
929 "java-res2/a": nil,
930 })
Colin Cross0c4ce212019-05-03 15:28:19 -0700931
932 // Test a library with include_srcs: true
933 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
934 fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar")
935
936 if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) {
937 t.Errorf("foo combined jars %v does not contain %q", w, g)
938 }
939
940 if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
941 t.Errorf("foo source jar args %q is not %q", w, g)
942 }
943
944 // Test a library with include_srcs: true and resources
945 bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar")
946 barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar")
947 barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar")
948 barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar")
949
950 if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
951 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
952 }
953
954 if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
955 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
956 }
957
958 if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) {
959 t.Errorf("bar combined jars %v does not contain %q", w, g)
960 }
961
962 if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
963 t.Errorf("bar source jar args %q is not %q", w, g)
964 }
965
966 if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w {
967 t.Errorf("bar resource jar args %q is not %q", w, g)
968 }
969}
970
Colin Cross54190b32017-10-09 15:34:10 -0700971func TestGeneratedSources(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700972 ctx, _ := testJavaWithFS(t, `
Colin Cross54190b32017-10-09 15:34:10 -0700973 java_library {
974 name: "foo",
975 srcs: [
976 "a*.java",
977 ":gen",
978 "b*.java",
979 ],
980 }
981
982 genrule {
983 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -0800984 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -0700985 out: ["gen.java"],
986 }
Colin Cross238c1f32020-06-07 16:58:18 -0700987 `, map[string][]byte{
988 "a.java": nil,
989 "b.java": nil,
990 })
Colin Cross54190b32017-10-09 15:34:10 -0700991
992 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
993 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
994
Colin Cross15e86d92017-10-20 15:07:08 -0700995 if filepath.Base(genrule.Output.String()) != "gen.java" {
996 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -0700997 }
998
999 if len(javac.Inputs) != 3 ||
1000 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -07001001 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -07001002 javac.Inputs[2].String() != "b.java" {
1003 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
1004 }
1005}
1006
Nan Zhang61eaedb2017-11-02 13:28:15 -07001007func TestTurbine(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001008 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001009 java_library {
1010 name: "foo",
1011 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +09001012 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001013 }
1014
1015 java_library {
1016 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -08001017 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -07001018 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +09001019 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001020 }
1021
1022 java_library {
1023 name: "baz",
1024 srcs: ["c.java"],
1025 libs: ["bar"],
1026 sdk_version: "14",
1027 }
1028 `)
1029
1030 fooTurbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine")
1031 barTurbine := ctx.ModuleForTests("bar", "android_common").Rule("turbine")
1032 barJavac := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1033 barTurbineCombined := ctx.ModuleForTests("bar", "android_common").Description("for turbine")
1034 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1035
1036 if len(fooTurbine.Inputs) != 1 || fooTurbine.Inputs[0].String() != "a.java" {
1037 t.Errorf(`foo inputs %v != ["a.java"]`, fooTurbine.Inputs)
1038 }
1039
1040 fooHeaderJar := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
1041 if !strings.Contains(barTurbine.Args["classpath"], fooHeaderJar) {
1042 t.Errorf("bar turbine classpath %v does not contain %q", barTurbine.Args["classpath"], fooHeaderJar)
1043 }
1044 if !strings.Contains(barJavac.Args["classpath"], fooHeaderJar) {
1045 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], fooHeaderJar)
1046 }
1047 if len(barTurbineCombined.Inputs) != 2 || barTurbineCombined.Inputs[1].String() != fooHeaderJar {
1048 t.Errorf("bar turbine combineJar inputs %v does not contain %q", barTurbineCombined.Inputs, fooHeaderJar)
1049 }
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001050 if !strings.Contains(bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") {
Nan Zhang61eaedb2017-11-02 13:28:15 -07001051 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001052 "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -07001053 }
1054}
1055
1056func TestSharding(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001057 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001058 java_library {
1059 name: "bar",
1060 srcs: ["a.java","b.java","c.java"],
1061 javac_shard_size: 1
1062 }
1063 `)
1064
1065 barHeaderJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
1066 for i := 0; i < 3; i++ {
1067 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
1068 if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) {
1069 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar)
1070 }
1071 }
1072}
1073
Nan Zhang581fd212018-01-10 16:06:12 -08001074func TestDroiddoc(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001075 ctx, _ := testJavaWithFS(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001076 droiddoc_exported_dir {
Dan Willemsencc090972018-02-26 14:33:31 -08001077 name: "droiddoc-templates-sdk",
1078 path: ".",
1079 }
Jiyong Park29074592019-07-07 16:27:47 +09001080 filegroup {
1081 name: "bar-doc-aidl-srcs",
1082 srcs: ["bar-doc/IBar.aidl"],
1083 path: "bar-doc",
1084 }
Liz Kammer3a55c912020-08-14 12:14:02 -07001085 droiddoc {
1086 name: "bar-doc",
1087 srcs: [
Steve Kim3666c702020-09-01 17:58:01 +00001088 "bar-doc/a.java",
Liz Kammer3a55c912020-08-14 12:14:02 -07001089 "bar-doc/IFoo.aidl",
1090 ":bar-doc-aidl-srcs",
1091 ],
Steve Kim3666c702020-09-01 17:58:01 +00001092 exclude_srcs: [
1093 "bar-doc/b.java"
1094 ],
Dan Willemsencc090972018-02-26 14:33:31 -08001095 custom_template: "droiddoc-templates-sdk",
Nan Zhang581fd212018-01-10 16:06:12 -08001096 hdf: [
1097 "android.whichdoc offline",
1098 ],
1099 knowntags: [
1100 "bar-doc/known_oj_tags.txt",
1101 ],
1102 proofread_file: "libcore-proofread.txt",
1103 todo_file: "libcore-docs-todo.html",
Liz Kammer585cac22020-07-06 09:12:57 -07001104 flags: ["-offlinemode -title \"libcore\""],
Nan Zhang581fd212018-01-10 16:06:12 -08001105 }
Colin Cross238c1f32020-06-07 16:58:18 -07001106 `,
1107 map[string][]byte{
1108 "bar-doc/a.java": nil,
1109 "bar-doc/b.java": nil,
1110 })
Steve Kim3666c702020-09-01 17:58:01 +00001111 barDocModule := ctx.ModuleForTests("bar-doc", "android_common")
1112 barDoc := barDocModule.Rule("javadoc")
1113 notExpected := " -stubs "
1114 if strings.Contains(barDoc.RuleParams.Command, notExpected) {
1115 t.Errorf("bar-doc command contains flag %q to create stubs, but should not", notExpected)
Liz Kammer1e2ee122020-07-30 15:07:22 -07001116 }
Nan Zhang581fd212018-01-10 16:06:12 -08001117
Steve Kim3666c702020-09-01 17:58:01 +00001118 var javaSrcs []string
1119 for _, i := range barDoc.Inputs {
1120 javaSrcs = append(javaSrcs, i.Base())
1121 }
1122 if len(javaSrcs) != 1 || javaSrcs[0] != "a.java" {
1123 t.Errorf("inputs of bar-doc must be []string{\"a.java\"}, but was %#v.", javaSrcs)
Jiyong Park29074592019-07-07 16:27:47 +09001124 }
1125
Steve Kim3666c702020-09-01 17:58:01 +00001126 aidl := barDocModule.Rule("aidl")
1127 if g, w := barDoc.Implicits.Strings(), aidl.Output.String(); !inList(w, g) {
Colin Crossc0806172019-06-14 18:51:47 -07001128 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
1129 }
1130
1131 if g, w := aidl.Implicits.Strings(), []string{"bar-doc/IBar.aidl", "bar-doc/IFoo.aidl"}; !reflect.DeepEqual(w, g) {
1132 t.Errorf("aidl inputs must be %q, but was %q", w, g)
Jiyong Park1e440682018-05-23 18:42:04 +09001133 }
Nan Zhang581fd212018-01-10 16:06:12 -08001134}
1135
Liz Kammer585cac22020-07-06 09:12:57 -07001136func TestDroiddocArgsAndFlagsCausesError(t *testing.T) {
1137 testJavaError(t, "flags is set. Cannot set args", `
1138 droiddoc_exported_dir {
1139 name: "droiddoc-templates-sdk",
1140 path: ".",
1141 }
1142 filegroup {
1143 name: "bar-doc-aidl-srcs",
1144 srcs: ["bar-doc/IBar.aidl"],
1145 path: "bar-doc",
1146 }
Liz Kammer3a55c912020-08-14 12:14:02 -07001147 droiddoc {
1148 name: "bar-doc",
1149 srcs: [
Steve Kim3666c702020-09-01 17:58:01 +00001150 "bar-doc/a.java",
Liz Kammer3a55c912020-08-14 12:14:02 -07001151 "bar-doc/IFoo.aidl",
1152 ":bar-doc-aidl-srcs",
1153 ],
Steve Kim3666c702020-09-01 17:58:01 +00001154 exclude_srcs: [
1155 "bar-doc/b.java"
1156 ],
Liz Kammer585cac22020-07-06 09:12:57 -07001157 custom_template: "droiddoc-templates-sdk",
1158 hdf: [
1159 "android.whichdoc offline",
1160 ],
1161 knowntags: [
1162 "bar-doc/known_oj_tags.txt",
1163 ],
1164 proofread_file: "libcore-proofread.txt",
1165 todo_file: "libcore-docs-todo.html",
1166 flags: ["-offlinemode -title \"libcore\""],
1167 args: "-offlinemode -title \"libcore\"",
1168 }
1169 `)
1170}
1171
Liz Kammer3d894b72020-08-04 09:55:13 -07001172func TestDroidstubs(t *testing.T) {
1173 ctx, _ := testJavaWithFS(t, `
1174 droiddoc_exported_dir {
1175 name: "droiddoc-templates-sdk",
1176 path: ".",
1177 }
1178
1179 droidstubs {
1180 name: "bar-stubs",
1181 srcs: [
1182 "bar-doc/a.java",
1183 ],
1184 api_levels_annotations_dirs: [
1185 "droiddoc-templates-sdk",
1186 ],
1187 api_levels_annotations_enabled: true,
1188 }
1189
1190 droidstubs {
1191 name: "bar-stubs-other",
1192 srcs: [
1193 "bar-doc/a.java",
1194 ],
1195 api_levels_annotations_dirs: [
1196 "droiddoc-templates-sdk",
1197 ],
1198 api_levels_annotations_enabled: true,
1199 api_levels_jar_filename: "android.other.jar",
1200 }
1201 `,
1202 map[string][]byte{
1203 "bar-doc/a.java": nil,
1204 })
1205 testcases := []struct {
1206 moduleName string
1207 expectedJarFilename string
1208 }{
1209 {
1210 moduleName: "bar-stubs",
1211 expectedJarFilename: "android.jar",
1212 },
1213 {
1214 moduleName: "bar-stubs-other",
1215 expectedJarFilename: "android.other.jar",
1216 },
1217 }
1218 for _, c := range testcases {
1219 m := ctx.ModuleForTests(c.moduleName, "android_common")
1220 metalava := m.Rule("metalava")
1221 expected := "--android-jar-pattern ./%/public/" + c.expectedJarFilename
1222 if actual := metalava.RuleParams.Command; !strings.Contains(actual, expected) {
1223 t.Errorf("For %q, expected metalava argument %q, but was not found %q", c.moduleName, expected, actual)
1224 }
1225 }
1226}
1227
Paul Duffin83a2d962019-11-19 19:44:10 +00001228func TestDroidstubsWithSystemModules(t *testing.T) {
1229 ctx, _ := testJava(t, `
1230 droidstubs {
1231 name: "stubs-source-system-modules",
1232 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001233 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001234 ],
1235 sdk_version: "none",
1236 system_modules: "source-system-modules",
1237 }
1238
1239 java_library {
1240 name: "source-jar",
1241 srcs: [
1242 "a.java",
1243 ],
1244 }
1245
1246 java_system_modules {
1247 name: "source-system-modules",
1248 libs: ["source-jar"],
1249 }
1250
1251 droidstubs {
1252 name: "stubs-prebuilt-system-modules",
1253 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001254 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001255 ],
1256 sdk_version: "none",
1257 system_modules: "prebuilt-system-modules",
1258 }
1259
1260 java_import {
1261 name: "prebuilt-jar",
1262 jars: ["a.jar"],
1263 }
1264
1265 java_system_modules_import {
1266 name: "prebuilt-system-modules",
1267 libs: ["prebuilt-jar"],
1268 }
1269 `)
1270
1271 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-source-system-modules", "source-jar.jar")
1272
1273 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-prebuilt-system-modules", "prebuilt-jar.jar")
1274}
1275
1276func checkSystemModulesUseByDroidstubs(t *testing.T, ctx *android.TestContext, moduleName string, systemJar string) {
1277 metalavaRule := ctx.ModuleForTests(moduleName, "android_common").Rule("metalava")
1278 var systemJars []string
1279 for _, i := range metalavaRule.Implicits {
1280 systemJars = append(systemJars, i.Base())
1281 }
Ramy Medhatc7965cd2020-04-30 03:08:37 -04001282 if len(systemJars) < 1 || systemJars[0] != systemJar {
Paul Duffin83a2d962019-11-19 19:44:10 +00001283 t.Errorf("inputs of %q must be []string{%q}, but was %#v.", moduleName, systemJar, systemJars)
1284 }
1285}
1286
Colin Cross54250902017-12-05 09:28:08 -08001287func TestJarGenrules(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001288 ctx, _ := testJava(t, `
Colin Cross54250902017-12-05 09:28:08 -08001289 java_library {
1290 name: "foo",
1291 srcs: ["a.java"],
1292 }
1293
1294 java_genrule {
1295 name: "jargen",
1296 tool_files: ["b.java"],
1297 cmd: "$(location b.java) $(in) $(out)",
1298 out: ["jargen.jar"],
1299 srcs: [":foo"],
1300 }
1301
1302 java_library {
1303 name: "bar",
1304 static_libs: ["jargen"],
1305 srcs: ["c.java"],
1306 }
1307
1308 java_library {
1309 name: "baz",
1310 libs: ["jargen"],
1311 srcs: ["c.java"],
1312 }
1313 `)
1314
1315 foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar")
1316 jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar")
1317 bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar")
1318 baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar")
1319 barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar")
1320
1321 if len(jargen.Inputs) != 1 || jargen.Inputs[0].String() != foo.Output.String() {
1322 t.Errorf("expected jargen inputs [%q], got %q", foo.Output.String(), jargen.Inputs.Strings())
1323 }
1324
1325 if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) {
1326 t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String())
1327 }
1328
1329 if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) {
1330 t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String())
1331 }
1332
1333 if len(barCombined.Inputs) != 2 ||
1334 barCombined.Inputs[0].String() != bar.Output.String() ||
1335 barCombined.Inputs[1].String() != jargen.Output.String() {
1336 t.Errorf("bar combined jar inputs %v is not [%q, %q]",
1337 barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String())
1338 }
1339}
1340
Nan Zhang27e284d2018-02-09 21:03:53 +00001341func TestExcludeFileGroupInSrcs(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001342 ctx, _ := testJava(t, `
Nan Zhang27e284d2018-02-09 21:03:53 +00001343 java_library {
1344 name: "foo",
1345 srcs: ["a.java", ":foo-srcs"],
1346 exclude_srcs: ["a.java", ":foo-excludes"],
1347 }
1348
1349 filegroup {
1350 name: "foo-srcs",
1351 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
1352 }
1353
1354 filegroup {
1355 name: "foo-excludes",
1356 srcs: ["java-fg/a.java", "java-fg/b.java"],
1357 }
1358 `)
1359
1360 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1361
1362 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
1363 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
1364 }
1365}
Jiyong Parkc678ad32018-04-10 13:07:10 +09001366
Paul Duffin52d398a2019-06-11 12:31:14 +01001367func TestJavaLibrary(t *testing.T) {
Colin Cross98be1bb2019-12-13 20:41:13 -08001368 config := testConfig(nil, "", map[string][]byte{
Paul Duffin52d398a2019-06-11 12:31:14 +01001369 "libcore/Android.bp": []byte(`
1370 java_library {
1371 name: "core",
1372 sdk_version: "none",
1373 system_modules: "none",
1374 }`),
1375 })
Colin Cross98be1bb2019-12-13 20:41:13 -08001376 ctx := testContext()
Paul Duffin52d398a2019-06-11 12:31:14 +01001377 run(t, ctx, config)
1378}
1379
Jiyong Parkc678ad32018-04-10 13:07:10 +09001380func TestJavaSdkLibrary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001381 ctx, _ := testJava(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001382 droiddoc_exported_dir {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001383 name: "droiddoc-templates-sdk",
1384 path: ".",
1385 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001386 java_sdk_library {
1387 name: "foo",
1388 srcs: ["a.java", "b.java"],
1389 api_packages: ["foo"],
1390 }
1391 java_sdk_library {
1392 name: "bar",
1393 srcs: ["a.java", "b.java"],
1394 api_packages: ["bar"],
1395 }
1396 java_library {
1397 name: "baz",
1398 srcs: ["c.java"],
Paul Duffin859fe962020-05-15 10:20:31 +01001399 libs: ["foo", "bar.stubs"],
Jiyong Parkc678ad32018-04-10 13:07:10 +09001400 sdk_version: "system_current",
1401 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001402 java_sdk_library {
1403 name: "barney",
1404 srcs: ["c.java"],
1405 api_only: true,
1406 }
1407 java_sdk_library {
1408 name: "betty",
1409 srcs: ["c.java"],
1410 shared_library: false,
1411 }
Paul Duffin859fe962020-05-15 10:20:31 +01001412 java_sdk_library_import {
1413 name: "quuz",
1414 public: {
1415 jars: ["c.jar"],
1416 },
1417 }
1418 java_sdk_library_import {
1419 name: "fred",
1420 public: {
1421 jars: ["b.jar"],
1422 },
1423 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001424 java_sdk_library_import {
1425 name: "wilma",
1426 public: {
1427 jars: ["b.jar"],
1428 },
1429 shared_library: false,
1430 }
Jiyong Park1be96912018-05-28 18:02:19 +09001431 java_library {
1432 name: "qux",
1433 srcs: ["c.java"],
Paul Duffindfa131e2020-05-15 20:37:11 +01001434 libs: ["baz", "fred", "quuz.stubs", "wilma", "barney", "betty"],
Jiyong Park1be96912018-05-28 18:02:19 +09001435 sdk_version: "system_current",
1436 }
Paul Duffin726d23c2020-01-22 16:30:37 +00001437 java_library {
1438 name: "baz-test",
1439 srcs: ["c.java"],
1440 libs: ["foo"],
1441 sdk_version: "test_current",
1442 }
Paul Duffina2db18f2020-01-22 17:11:15 +00001443 java_library {
1444 name: "baz-29",
1445 srcs: ["c.java"],
1446 libs: ["foo"],
1447 sdk_version: "system_29",
1448 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001449 `)
1450
1451 // check the existence of the internal modules
1452 ctx.ModuleForTests("foo", "android_common")
Paul Duffindd9d0742020-05-08 15:52:37 +01001453 ctx.ModuleForTests(apiScopePublic.stubsLibraryModuleName("foo"), "android_common")
1454 ctx.ModuleForTests(apiScopeSystem.stubsLibraryModuleName("foo"), "android_common")
1455 ctx.ModuleForTests(apiScopeTest.stubsLibraryModuleName("foo"), "android_common")
1456 ctx.ModuleForTests(apiScopePublic.stubsSourceModuleName("foo"), "android_common")
1457 ctx.ModuleForTests(apiScopeSystem.stubsSourceModuleName("foo"), "android_common")
1458 ctx.ModuleForTests(apiScopeTest.stubsSourceModuleName("foo"), "android_common")
Jiyong Parke3833882020-02-17 17:28:10 +09001459 ctx.ModuleForTests("foo"+sdkXmlFileSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +09001460 ctx.ModuleForTests("foo.api.public.28", "")
1461 ctx.ModuleForTests("foo.api.system.28", "")
1462 ctx.ModuleForTests("foo.api.test.28", "")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001463
1464 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1465 // tests if baz is actually linked to the stubs lib
1466 if !strings.Contains(bazJavac.Args["classpath"], "foo.stubs.system.jar") {
1467 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
1468 "foo.stubs.system.jar")
1469 }
1470 // ... and not to the impl lib
Sundong Ahn054b19a2018-10-19 13:46:09 +09001471 if strings.Contains(bazJavac.Args["classpath"], "foo.jar") {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001472 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
Sundong Ahn054b19a2018-10-19 13:46:09 +09001473 "foo.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001474 }
1475 // test if baz is not linked to the system variant of foo
1476 if strings.Contains(bazJavac.Args["classpath"], "foo.stubs.jar") {
1477 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
1478 "foo.stubs.jar")
1479 }
Jiyong Park1be96912018-05-28 18:02:19 +09001480
Paul Duffin726d23c2020-01-22 16:30:37 +00001481 bazTestJavac := ctx.ModuleForTests("baz-test", "android_common").Rule("javac")
1482 // tests if baz-test is actually linked to the test stubs lib
1483 if !strings.Contains(bazTestJavac.Args["classpath"], "foo.stubs.test.jar") {
1484 t.Errorf("baz-test javac classpath %v does not contain %q", bazTestJavac.Args["classpath"],
1485 "foo.stubs.test.jar")
1486 }
1487
Paul Duffina2db18f2020-01-22 17:11:15 +00001488 baz29Javac := ctx.ModuleForTests("baz-29", "android_common").Rule("javac")
1489 // tests if baz-29 is actually linked to the system 29 stubs lib
1490 if !strings.Contains(baz29Javac.Args["classpath"], "prebuilts/sdk/29/system/foo.jar") {
1491 t.Errorf("baz-29 javac classpath %v does not contain %q", baz29Javac.Args["classpath"],
1492 "prebuilts/sdk/29/system/foo.jar")
1493 }
1494
Jiyong Park1be96912018-05-28 18:02:19 +09001495 // test if baz has exported SDK lib names foo and bar to qux
1496 qux := ctx.ModuleForTests("qux", "android_common")
1497 if quxLib, ok := qux.Module().(*Library); ok {
Ulya Trafimovichb8063c62020-08-20 11:33:12 +01001498 sdkLibs := android.SortedStringKeys(quxLib.ExportedSdkLibs())
Paul Duffin859fe962020-05-15 10:20:31 +01001499 if w := []string{"bar", "foo", "fred", "quuz"}; !reflect.DeepEqual(w, sdkLibs) {
1500 t.Errorf("qux should export %q but exports %q", w, sdkLibs)
Jiyong Park1be96912018-05-28 18:02:19 +09001501 }
1502 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001503}
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001504
Paul Duffindaaa3322020-05-26 18:13:57 +01001505func TestJavaSdkLibrary_DoNotAccessImplWhenItIsNotBuilt(t *testing.T) {
1506 ctx, _ := testJava(t, `
1507 java_sdk_library {
1508 name: "foo",
1509 srcs: ["a.java"],
1510 api_only: true,
1511 public: {
1512 enabled: true,
1513 },
1514 }
1515
1516 java_library {
1517 name: "bar",
1518 srcs: ["b.java"],
1519 libs: ["foo"],
1520 }
1521 `)
1522
1523 // The bar library should depend on the stubs jar.
1524 barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1525 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1526 t.Errorf("expected %q, found %#q", expected, actual)
1527 }
1528}
1529
Paul Duffin46dc45a2020-05-14 15:39:10 +01001530func TestJavaSdkLibrary_UseSourcesFromAnotherSdkLibrary(t *testing.T) {
1531 testJava(t, `
1532 java_sdk_library {
1533 name: "foo",
1534 srcs: ["a.java"],
1535 api_packages: ["foo"],
1536 public: {
1537 enabled: true,
1538 },
1539 }
1540
1541 java_library {
1542 name: "bar",
1543 srcs: ["b.java", ":foo{.public.stubs.source}"],
1544 }
1545 `)
1546}
1547
1548func TestJavaSdkLibrary_AccessOutputFiles_MissingScope(t *testing.T) {
1549 testJavaError(t, `"foo" does not provide api scope system`, `
1550 java_sdk_library {
1551 name: "foo",
1552 srcs: ["a.java"],
1553 api_packages: ["foo"],
1554 public: {
1555 enabled: true,
1556 },
1557 }
1558
1559 java_library {
1560 name: "bar",
1561 srcs: ["b.java", ":foo{.system.stubs.source}"],
1562 }
1563 `)
1564}
1565
Paul Duffinca8d9a52020-06-26 22:20:25 +01001566func TestJavaSdkLibrary_Deps(t *testing.T) {
1567 ctx, _ := testJava(t, `
1568 java_sdk_library {
1569 name: "sdklib",
1570 srcs: ["a.java"],
1571 sdk_version: "none",
1572 system_modules: "none",
1573 public: {
1574 enabled: true,
1575 },
1576 }
1577 `)
1578
Paul Duffincee7e662020-07-09 17:32:57 +01001579 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +01001580 `dex2oatd`,
1581 `sdklib.impl`,
1582 `sdklib.stubs`,
1583 `sdklib.stubs.source`,
1584 `sdklib.xml`,
1585 })
1586}
1587
Paul Duffin46dc45a2020-05-14 15:39:10 +01001588func TestJavaSdkLibraryImport_AccessOutputFiles(t *testing.T) {
1589 testJava(t, `
1590 java_sdk_library_import {
1591 name: "foo",
1592 public: {
1593 jars: ["a.jar"],
1594 stub_srcs: ["a.java"],
1595 current_api: "api/current.txt",
1596 removed_api: "api/removed.txt",
1597 },
1598 }
1599
1600 java_library {
1601 name: "bar",
1602 srcs: [":foo{.public.stubs.source}"],
1603 java_resources: [
1604 ":foo{.public.api.txt}",
1605 ":foo{.public.removed-api.txt}",
1606 ],
1607 }
1608 `)
1609}
1610
1611func TestJavaSdkLibraryImport_AccessOutputFiles_Invalid(t *testing.T) {
1612 bp := `
1613 java_sdk_library_import {
1614 name: "foo",
1615 public: {
1616 jars: ["a.jar"],
1617 },
1618 }
1619 `
1620
1621 t.Run("stubs.source", func(t *testing.T) {
1622 testJavaError(t, `stubs.source not available for api scope public`, bp+`
1623 java_library {
1624 name: "bar",
1625 srcs: [":foo{.public.stubs.source}"],
1626 java_resources: [
1627 ":foo{.public.api.txt}",
1628 ":foo{.public.removed-api.txt}",
1629 ],
1630 }
1631 `)
1632 })
1633
1634 t.Run("api.txt", func(t *testing.T) {
1635 testJavaError(t, `api.txt not available for api scope public`, bp+`
1636 java_library {
1637 name: "bar",
1638 srcs: ["a.java"],
1639 java_resources: [
1640 ":foo{.public.api.txt}",
1641 ],
1642 }
1643 `)
1644 })
1645
1646 t.Run("removed-api.txt", func(t *testing.T) {
1647 testJavaError(t, `removed-api.txt not available for api scope public`, bp+`
1648 java_library {
1649 name: "bar",
1650 srcs: ["a.java"],
1651 java_resources: [
1652 ":foo{.public.removed-api.txt}",
1653 ],
1654 }
1655 `)
1656 })
1657}
1658
Paul Duffin3375e352020-04-28 10:44:03 +01001659func TestJavaSdkLibrary_InvalidScopes(t *testing.T) {
1660 testJavaError(t, `module "foo": enabled api scope "system" depends on disabled scope "public"`, `
1661 java_sdk_library {
1662 name: "foo",
1663 srcs: ["a.java", "b.java"],
1664 api_packages: ["foo"],
1665 // Explicitly disable public to test the check that ensures the set of enabled
1666 // scopes is consistent.
1667 public: {
1668 enabled: false,
1669 },
1670 system: {
1671 enabled: true,
1672 },
1673 }
1674 `)
1675}
1676
Paul Duffin87a05a32020-05-12 11:50:28 +01001677func TestJavaSdkLibrary_SdkVersion_ForScope(t *testing.T) {
1678 testJava(t, `
1679 java_sdk_library {
1680 name: "foo",
1681 srcs: ["a.java", "b.java"],
1682 api_packages: ["foo"],
1683 system: {
1684 enabled: true,
1685 sdk_version: "module_current",
1686 },
1687 }
1688 `)
1689}
1690
Paul Duffin0c5bae52020-06-02 13:00:08 +01001691func TestJavaSdkLibrary_ModuleLib(t *testing.T) {
1692 testJava(t, `
1693 java_sdk_library {
1694 name: "foo",
1695 srcs: ["a.java", "b.java"],
1696 api_packages: ["foo"],
1697 system: {
1698 enabled: true,
1699 },
1700 module_lib: {
1701 enabled: true,
1702 },
1703 }
1704 `)
1705}
1706
1707func TestJavaSdkLibrary_SystemServer(t *testing.T) {
1708 testJava(t, `
1709 java_sdk_library {
1710 name: "foo",
1711 srcs: ["a.java", "b.java"],
1712 api_packages: ["foo"],
1713 system: {
1714 enabled: true,
1715 },
1716 system_server: {
1717 enabled: true,
1718 },
1719 }
1720 `)
1721}
1722
Paul Duffin803a9562020-05-20 11:52:25 +01001723func TestJavaSdkLibrary_MissingScope(t *testing.T) {
1724 testJavaError(t, `requires api scope module-lib from foo but it only has \[\] available`, `
1725 java_sdk_library {
1726 name: "foo",
1727 srcs: ["a.java"],
1728 public: {
1729 enabled: false,
1730 },
1731 }
1732
1733 java_library {
1734 name: "baz",
1735 srcs: ["a.java"],
1736 libs: ["foo"],
1737 sdk_version: "module_current",
1738 }
1739 `)
1740}
1741
1742func TestJavaSdkLibrary_FallbackScope(t *testing.T) {
1743 testJava(t, `
1744 java_sdk_library {
1745 name: "foo",
1746 srcs: ["a.java"],
1747 system: {
1748 enabled: true,
1749 },
1750 }
1751
1752 java_library {
1753 name: "baz",
1754 srcs: ["a.java"],
1755 libs: ["foo"],
1756 // foo does not have module-lib scope so it should fallback to system
1757 sdk_version: "module_current",
1758 }
1759 `)
1760}
1761
Jiyong Park932cdfe2020-05-28 00:19:53 +09001762func TestJavaSdkLibrary_DefaultToStubs(t *testing.T) {
1763 ctx, _ := testJava(t, `
1764 java_sdk_library {
1765 name: "foo",
1766 srcs: ["a.java"],
1767 system: {
1768 enabled: true,
1769 },
1770 default_to_stubs: true,
1771 }
1772
1773 java_library {
1774 name: "baz",
1775 srcs: ["a.java"],
1776 libs: ["foo"],
1777 // does not have sdk_version set, should fallback to module,
1778 // which will then fallback to system because the module scope
1779 // is not enabled.
1780 }
1781 `)
1782 // The baz library should depend on the system stubs jar.
1783 bazLibrary := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1784 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs.system\.jar$`, bazLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1785 t.Errorf("expected %q, found %#q", expected, actual)
1786 }
1787}
1788
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001789var compilerFlagsTestCases = []struct {
1790 in string
1791 out bool
1792}{
1793 {
1794 in: "a",
1795 out: false,
1796 },
1797 {
1798 in: "-a",
1799 out: true,
1800 },
1801 {
1802 in: "-no-jdk",
1803 out: false,
1804 },
1805 {
1806 in: "-no-stdlib",
1807 out: false,
1808 },
1809 {
1810 in: "-kotlin-home",
1811 out: false,
1812 },
1813 {
1814 in: "-kotlin-home /some/path",
1815 out: false,
1816 },
1817 {
1818 in: "-include-runtime",
1819 out: false,
1820 },
1821 {
1822 in: "-Xintellij-plugin-root",
1823 out: false,
1824 },
1825}
1826
1827type mockContext struct {
1828 android.ModuleContext
1829 result bool
1830}
1831
1832func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
1833 // CheckBadCompilerFlags calls this function when the flag should be rejected
1834 ctx.result = false
1835}
1836
1837func TestCompilerFlags(t *testing.T) {
1838 for _, testCase := range compilerFlagsTestCases {
1839 ctx := &mockContext{result: true}
1840 CheckKotlincFlags(ctx, []string{testCase.in})
1841 if ctx.result != testCase.out {
1842 t.Errorf("incorrect output:")
1843 t.Errorf(" input: %#v", testCase.in)
1844 t.Errorf(" expected: %#v", testCase.out)
1845 t.Errorf(" got: %#v", ctx.result)
1846 }
1847 }
1848}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001849
1850// TODO(jungjw): Consider making this more robust by ignoring path order.
1851func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
1852 variables := ctx.ModuleForTests(moduleName, "android_common").Module().VariablesForTests()
1853 flags := strings.Split(variables["javacFlags"], " ")
1854 got := ""
1855 for _, flag := range flags {
1856 keyEnd := strings.Index(flag, "=")
1857 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
1858 got = flag[keyEnd+1:]
1859 break
1860 }
1861 }
1862 if expected != got {
1863 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
1864 }
1865}
1866
1867func TestPatchModule(t *testing.T) {
Pete Gillin0c2143e2019-05-02 15:32:11 +01001868 t.Run("Java language level 8", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001869 // Test with legacy javac -source 1.8 -target 1.8
Pete Gillinbdf5d712019-10-21 14:29:58 +01001870 bp := `
1871 java_library {
1872 name: "foo",
1873 srcs: ["a.java"],
1874 java_version: "1.8",
1875 }
1876
1877 java_library {
1878 name: "bar",
1879 srcs: ["b.java"],
1880 sdk_version: "none",
1881 system_modules: "none",
1882 patch_module: "java.base",
1883 java_version: "1.8",
1884 }
1885
1886 java_library {
1887 name: "baz",
1888 srcs: ["c.java"],
1889 patch_module: "java.base",
1890 java_version: "1.8",
1891 }
1892 `
1893 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001894
1895 checkPatchModuleFlag(t, ctx, "foo", "")
1896 checkPatchModuleFlag(t, ctx, "bar", "")
1897 checkPatchModuleFlag(t, ctx, "baz", "")
1898 })
1899
Pete Gillin0c2143e2019-05-02 15:32:11 +01001900 t.Run("Java language level 9", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001901 // Test with default javac -source 9 -target 9
Pete Gillinbdf5d712019-10-21 14:29:58 +01001902 bp := `
1903 java_library {
1904 name: "foo",
1905 srcs: ["a.java"],
1906 }
1907
1908 java_library {
1909 name: "bar",
1910 srcs: ["b.java"],
1911 sdk_version: "none",
1912 system_modules: "none",
1913 patch_module: "java.base",
1914 }
1915
1916 java_library {
1917 name: "baz",
1918 srcs: ["c.java"],
1919 patch_module: "java.base",
1920 }
1921 `
Pete Gillin1b3370f2019-10-01 13:57:31 +01001922 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001923
1924 checkPatchModuleFlag(t, ctx, "foo", "")
1925 expected := "java.base=.:" + buildDir
1926 checkPatchModuleFlag(t, ctx, "bar", expected)
Jiyong Park231d0562019-12-18 17:28:17 +09001927 expected = "java.base=" + strings.Join([]string{".", buildDir, moduleToPath("ext"), moduleToPath("framework")}, ":")
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001928 checkPatchModuleFlag(t, ctx, "baz", expected)
1929 })
1930}
Paul Duffina7b9f422020-01-10 17:12:18 +00001931
1932func TestJavaSystemModules(t *testing.T) {
1933 ctx, _ := testJava(t, `
1934 java_system_modules {
1935 name: "system-modules",
1936 libs: ["system-module1", "system-module2"],
1937 }
1938 java_library {
1939 name: "system-module1",
1940 srcs: ["a.java"],
1941 sdk_version: "none",
1942 system_modules: "none",
1943 }
1944 java_library {
1945 name: "system-module2",
1946 srcs: ["b.java"],
1947 sdk_version: "none",
1948 system_modules: "none",
1949 }
1950 `)
1951
1952 // check the existence of the module
1953 systemModules := ctx.ModuleForTests("system-modules", "android_common")
1954
1955 cmd := systemModules.Rule("jarsTosystemModules")
1956
1957 // make sure the command compiles against the supplied modules.
1958 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
1959 if !strings.Contains(cmd.Args["classpath"], module) {
1960 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
1961 module)
1962 }
1963 }
1964}
Paul Duffin90169ba2020-01-10 17:16:44 +00001965
1966func TestJavaSystemModulesImport(t *testing.T) {
1967 ctx, _ := testJava(t, `
1968 java_system_modules_import {
1969 name: "system-modules",
1970 libs: ["system-module1", "system-module2"],
1971 }
1972 java_import {
1973 name: "system-module1",
1974 jars: ["a.jar"],
1975 }
1976 java_import {
1977 name: "system-module2",
1978 jars: ["b.jar"],
1979 }
1980 `)
1981
1982 // check the existence of the module
1983 systemModules := ctx.ModuleForTests("system-modules", "android_common")
1984
1985 cmd := systemModules.Rule("jarsTosystemModules")
1986
1987 // make sure the command compiles against the supplied modules.
1988 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
1989 if !strings.Contains(cmd.Args["classpath"], module) {
1990 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
1991 module)
1992 }
1993 }
1994}
Paul Duffin83a2d962019-11-19 19:44:10 +00001995
1996func TestJavaLibraryWithSystemModules(t *testing.T) {
1997 ctx, _ := testJava(t, `
1998 java_library {
1999 name: "lib-with-source-system-modules",
2000 srcs: [
2001 "a.java",
2002 ],
2003 sdk_version: "none",
2004 system_modules: "source-system-modules",
2005 }
2006
2007 java_library {
2008 name: "source-jar",
2009 srcs: [
2010 "a.java",
2011 ],
2012 }
2013
2014 java_system_modules {
2015 name: "source-system-modules",
2016 libs: ["source-jar"],
2017 }
2018
2019 java_library {
2020 name: "lib-with-prebuilt-system-modules",
2021 srcs: [
2022 "a.java",
2023 ],
2024 sdk_version: "none",
2025 system_modules: "prebuilt-system-modules",
2026 }
2027
2028 java_import {
2029 name: "prebuilt-jar",
2030 jars: ["a.jar"],
2031 }
2032
2033 java_system_modules_import {
2034 name: "prebuilt-system-modules",
2035 libs: ["prebuilt-jar"],
2036 }
2037 `)
2038
2039 checkBootClasspathForSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar")
2040
2041 checkBootClasspathForSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar")
2042}
2043
2044func checkBootClasspathForSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) {
2045 javacRule := ctx.ModuleForTests(moduleName, "android_common").Rule("javac")
2046 bootClasspath := javacRule.Args["bootClasspath"]
2047 if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) {
2048 t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath)
2049 }
2050}
Jiyong Park19604de2020-03-24 16:44:11 +09002051
2052func TestAidlExportIncludeDirsFromImports(t *testing.T) {
2053 ctx, _ := testJava(t, `
2054 java_library {
2055 name: "foo",
2056 srcs: ["aidl/foo/IFoo.aidl"],
2057 libs: ["bar"],
2058 }
2059
2060 java_import {
2061 name: "bar",
2062 jars: ["a.jar"],
2063 aidl: {
2064 export_include_dirs: ["aidl/bar"],
2065 },
2066 }
2067 `)
2068
2069 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
2070 expectedAidlFlag := "-Iaidl/bar"
2071 if !strings.Contains(aidlCommand, expectedAidlFlag) {
2072 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
2073 }
2074}
Liz Kammerdd849a82020-06-12 16:38:45 -07002075
2076func TestDataNativeBinaries(t *testing.T) {
2077 ctx, config := testJava(t, `
2078 java_test_host {
2079 name: "foo",
2080 srcs: ["a.java"],
2081 data_native_bins: ["bin"]
2082 }
2083
2084 python_binary_host {
2085 name: "bin",
2086 srcs: ["bin.py"],
2087 }
2088 `)
2089
2090 buildOS := android.BuildOs.String()
2091
2092 test := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
2093 entries := android.AndroidMkEntriesForTest(t, config, "", test)[0]
2094 expected := []string{buildDir + "/.intermediates/bin/" + buildOS + "_x86_64_PY3/bin:bin"}
2095 actual := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
2096 if !reflect.DeepEqual(expected, actual) {
2097 t.Errorf("Unexpected test data - expected: %q, actual: %q", expected, actual)
2098 }
2099}