Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1 | // Copyright 2018 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package apex |
| 16 | |
| 17 | import ( |
Jiyong Park | f7c3bbe | 2020-12-09 21:18:56 +0900 | [diff] [blame] | 18 | "fmt" |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 19 | "os" |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 20 | "path" |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 21 | "path/filepath" |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 22 | "reflect" |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 23 | "regexp" |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 24 | "sort" |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 25 | "strconv" |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 26 | "strings" |
| 27 | "testing" |
Jiyong Park | da6eb59 | 2018-12-19 17:12:36 +0900 | [diff] [blame] | 28 | |
| 29 | "github.com/google/blueprint/proptools" |
| 30 | |
| 31 | "android/soong/android" |
markchien | 2f59ec9 | 2020-09-02 16:23:38 +0800 | [diff] [blame] | 32 | "android/soong/bpf" |
Jiyong Park | da6eb59 | 2018-12-19 17:12:36 +0900 | [diff] [blame] | 33 | "android/soong/cc" |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 34 | "android/soong/dexpreopt" |
Jaewoong Jung | 4b79e98 | 2020-06-01 10:45:49 -0700 | [diff] [blame] | 35 | prebuilt_etc "android/soong/etc" |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 36 | "android/soong/java" |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 37 | "android/soong/rust" |
Jaewoong Jung | 4b79e98 | 2020-06-01 10:45:49 -0700 | [diff] [blame] | 38 | "android/soong/sh" |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 39 | ) |
| 40 | |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 41 | // names returns name list from white space separated string |
| 42 | func names(s string) (ns []string) { |
| 43 | for _, n := range strings.Split(s, " ") { |
| 44 | if len(n) > 0 { |
| 45 | ns = append(ns, n) |
| 46 | } |
| 47 | } |
| 48 | return |
| 49 | } |
| 50 | |
Paul Duffin | 40b6257 | 2021-03-20 11:39:01 +0000 | [diff] [blame] | 51 | func testApexError(t *testing.T, pattern, bp string, preparers ...android.FixturePreparer) { |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 52 | t.Helper() |
Paul Duffin | 284165a | 2021-03-29 01:50:31 +0100 | [diff] [blame] | 53 | android.GroupFixturePreparers( |
| 54 | prepareForApexTest, |
| 55 | android.GroupFixturePreparers(preparers...), |
| 56 | ). |
Paul Duffin | e05480a | 2021-03-08 15:07:14 +0000 | [diff] [blame] | 57 | ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)). |
Paul Duffin | 40b6257 | 2021-03-20 11:39:01 +0000 | [diff] [blame] | 58 | RunTestWithBp(t, bp) |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 59 | } |
| 60 | |
Paul Duffin | 40b6257 | 2021-03-20 11:39:01 +0000 | [diff] [blame] | 61 | func testApex(t *testing.T, bp string, preparers ...android.FixturePreparer) *android.TestContext { |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 62 | t.Helper() |
Paul Duffin | 284165a | 2021-03-29 01:50:31 +0100 | [diff] [blame] | 63 | |
| 64 | optionalBpPreparer := android.NullFixturePreparer |
Paul Duffin | 40b6257 | 2021-03-20 11:39:01 +0000 | [diff] [blame] | 65 | if bp != "" { |
Paul Duffin | 284165a | 2021-03-29 01:50:31 +0100 | [diff] [blame] | 66 | optionalBpPreparer = android.FixtureWithRootAndroidBp(bp) |
Paul Duffin | 40b6257 | 2021-03-20 11:39:01 +0000 | [diff] [blame] | 67 | } |
Paul Duffin | 284165a | 2021-03-29 01:50:31 +0100 | [diff] [blame] | 68 | |
| 69 | result := android.GroupFixturePreparers( |
| 70 | prepareForApexTest, |
| 71 | android.GroupFixturePreparers(preparers...), |
| 72 | optionalBpPreparer, |
| 73 | ).RunTest(t) |
| 74 | |
Paul Duffin | e05480a | 2021-03-08 15:07:14 +0000 | [diff] [blame] | 75 | return result.TestContext |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 76 | } |
| 77 | |
Paul Duffin | 810f33d | 2021-03-09 14:12:32 +0000 | [diff] [blame] | 78 | func withFiles(files android.MockFS) android.FixturePreparer { |
| 79 | return files.AddToFixture() |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 80 | } |
| 81 | |
Paul Duffin | 810f33d | 2021-03-09 14:12:32 +0000 | [diff] [blame] | 82 | func withTargets(targets map[android.OsType][]android.Target) android.FixturePreparer { |
| 83 | return android.FixtureModifyConfig(func(config android.Config) { |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 84 | for k, v := range targets { |
| 85 | config.Targets[k] = v |
| 86 | } |
Paul Duffin | 810f33d | 2021-03-09 14:12:32 +0000 | [diff] [blame] | 87 | }) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 88 | } |
| 89 | |
Jooyung Han | 35155c4 | 2020-02-06 17:33:20 +0900 | [diff] [blame] | 90 | // withNativeBridgeTargets sets configuration with targets including: |
| 91 | // - X86_64 (primary) |
| 92 | // - X86 (secondary) |
| 93 | // - Arm64 on X86_64 (native bridge) |
| 94 | // - Arm on X86 (native bridge) |
Paul Duffin | 810f33d | 2021-03-09 14:12:32 +0000 | [diff] [blame] | 95 | var withNativeBridgeEnabled = android.FixtureModifyConfig( |
| 96 | func(config android.Config) { |
| 97 | config.Targets[android.Android] = []android.Target{ |
| 98 | {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "silvermont", Abi: []string{"arm64-v8a"}}, |
| 99 | NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""}, |
| 100 | {Os: android.Android, Arch: android.Arch{ArchType: android.X86, ArchVariant: "silvermont", Abi: []string{"armeabi-v7a"}}, |
| 101 | NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""}, |
| 102 | {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}, |
| 103 | NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86_64", NativeBridgeRelativePath: "arm64"}, |
| 104 | {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}, |
| 105 | NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86", NativeBridgeRelativePath: "arm"}, |
| 106 | } |
| 107 | }, |
| 108 | ) |
| 109 | |
| 110 | func withManifestPackageNameOverrides(specs []string) android.FixturePreparer { |
| 111 | return android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 112 | variables.ManifestPackageNameOverrides = specs |
| 113 | }) |
Jooyung Han | 35155c4 | 2020-02-06 17:33:20 +0900 | [diff] [blame] | 114 | } |
| 115 | |
Paul Duffin | 810f33d | 2021-03-09 14:12:32 +0000 | [diff] [blame] | 116 | var withBinder32bit = android.FixtureModifyProductVariables( |
| 117 | func(variables android.FixtureProductVariables) { |
| 118 | variables.Binder32bit = proptools.BoolPtr(true) |
| 119 | }, |
| 120 | ) |
Jiyong Park | cfaa164 | 2020-02-28 16:51:07 +0900 | [diff] [blame] | 121 | |
Paul Duffin | 810f33d | 2021-03-09 14:12:32 +0000 | [diff] [blame] | 122 | var withUnbundledBuild = android.FixtureModifyProductVariables( |
| 123 | func(variables android.FixtureProductVariables) { |
| 124 | variables.Unbundled_build = proptools.BoolPtr(true) |
| 125 | }, |
| 126 | ) |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 127 | |
Paul Duffin | 284165a | 2021-03-29 01:50:31 +0100 | [diff] [blame] | 128 | // Legacy preparer used for running tests within the apex package. |
| 129 | // |
| 130 | // This includes everything that was needed to run any test in the apex package prior to the |
| 131 | // introduction of the test fixtures. Tests that are being converted to use fixtures directly |
| 132 | // rather than through the testApex...() methods should avoid using this and instead use the |
| 133 | // various preparers directly, using android.GroupFixturePreparers(...) to group them when |
| 134 | // necessary. |
| 135 | // |
| 136 | // deprecated |
| 137 | var prepareForApexTest = android.GroupFixturePreparers( |
Paul Duffin | 37aad60 | 2021-03-08 09:47:16 +0000 | [diff] [blame] | 138 | // General preparers in alphabetical order as test infrastructure will enforce correct |
| 139 | // registration order. |
| 140 | android.PrepareForTestWithAndroidBuildComponents, |
| 141 | bpf.PrepareForTestWithBpf, |
| 142 | cc.PrepareForTestWithCcBuildComponents, |
| 143 | java.PrepareForTestWithJavaDefaultModules, |
| 144 | prebuilt_etc.PrepareForTestWithPrebuiltEtc, |
| 145 | rust.PrepareForTestWithRustDefaultModules, |
| 146 | sh.PrepareForTestWithShBuildComponents, |
| 147 | |
| 148 | PrepareForTestWithApexBuildComponents, |
| 149 | |
| 150 | // Additional apex test specific preparers. |
| 151 | android.FixtureAddTextFile("system/sepolicy/Android.bp", ` |
| 152 | filegroup { |
| 153 | name: "myapex-file_contexts", |
| 154 | srcs: [ |
| 155 | "apex/myapex-file_contexts", |
| 156 | ], |
| 157 | } |
| 158 | `), |
Paul Duffin | 52bfaa4 | 2021-03-23 23:40:12 +0000 | [diff] [blame] | 159 | prepareForTestWithMyapex, |
Paul Duffin | 37aad60 | 2021-03-08 09:47:16 +0000 | [diff] [blame] | 160 | android.FixtureMergeMockFs(android.MockFS{ |
Paul Duffin | 52bfaa4 | 2021-03-23 23:40:12 +0000 | [diff] [blame] | 161 | "a.java": nil, |
| 162 | "PrebuiltAppFoo.apk": nil, |
| 163 | "PrebuiltAppFooPriv.apk": nil, |
| 164 | "apex_manifest.json": nil, |
| 165 | "AndroidManifest.xml": nil, |
Paul Duffin | 37aad60 | 2021-03-08 09:47:16 +0000 | [diff] [blame] | 166 | "system/sepolicy/apex/myapex.updatable-file_contexts": nil, |
| 167 | "system/sepolicy/apex/myapex2-file_contexts": nil, |
| 168 | "system/sepolicy/apex/otherapex-file_contexts": nil, |
| 169 | "system/sepolicy/apex/com.android.vndk-file_contexts": nil, |
| 170 | "system/sepolicy/apex/com.android.vndk.current-file_contexts": nil, |
| 171 | "mylib.cpp": nil, |
| 172 | "mytest.cpp": nil, |
| 173 | "mytest1.cpp": nil, |
| 174 | "mytest2.cpp": nil, |
| 175 | "mytest3.cpp": nil, |
| 176 | "myprebuilt": nil, |
| 177 | "my_include": nil, |
| 178 | "foo/bar/MyClass.java": nil, |
| 179 | "prebuilt.jar": nil, |
| 180 | "prebuilt.so": nil, |
| 181 | "vendor/foo/devkeys/test.x509.pem": nil, |
| 182 | "vendor/foo/devkeys/test.pk8": nil, |
| 183 | "testkey.x509.pem": nil, |
| 184 | "testkey.pk8": nil, |
| 185 | "testkey.override.x509.pem": nil, |
| 186 | "testkey.override.pk8": nil, |
| 187 | "vendor/foo/devkeys/testkey.avbpubkey": nil, |
| 188 | "vendor/foo/devkeys/testkey.pem": nil, |
| 189 | "NOTICE": nil, |
| 190 | "custom_notice": nil, |
| 191 | "custom_notice_for_static_lib": nil, |
| 192 | "testkey2.avbpubkey": nil, |
| 193 | "testkey2.pem": nil, |
| 194 | "myapex-arm64.apex": nil, |
| 195 | "myapex-arm.apex": nil, |
| 196 | "myapex.apks": nil, |
| 197 | "frameworks/base/api/current.txt": nil, |
| 198 | "framework/aidl/a.aidl": nil, |
| 199 | "build/make/core/proguard.flags": nil, |
| 200 | "build/make/core/proguard_basic_keeps.flags": nil, |
| 201 | "dummy.txt": nil, |
| 202 | "baz": nil, |
| 203 | "bar/baz": nil, |
| 204 | "testdata/baz": nil, |
| 205 | "AppSet.apks": nil, |
| 206 | "foo.rs": nil, |
| 207 | "libfoo.jar": nil, |
| 208 | "libbar.jar": nil, |
| 209 | }, |
| 210 | ), |
| 211 | |
| 212 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 213 | variables.DeviceVndkVersion = proptools.StringPtr("current") |
| 214 | variables.DefaultAppCertificate = proptools.StringPtr("vendor/foo/devkeys/test") |
| 215 | variables.CertificateOverrides = []string{"myapex_keytest:myapex.certificate.override"} |
| 216 | variables.Platform_sdk_codename = proptools.StringPtr("Q") |
| 217 | variables.Platform_sdk_final = proptools.BoolPtr(false) |
| 218 | variables.Platform_version_active_codenames = []string{"Q"} |
Jiyong Park | f58c46e | 2021-04-01 21:35:20 +0900 | [diff] [blame] | 219 | variables.Platform_vndk_version = proptools.StringPtr("29") |
Paul Duffin | 37aad60 | 2021-03-08 09:47:16 +0000 | [diff] [blame] | 220 | }), |
| 221 | ) |
| 222 | |
Paul Duffin | 52bfaa4 | 2021-03-23 23:40:12 +0000 | [diff] [blame] | 223 | var prepareForTestWithMyapex = android.FixtureMergeMockFs(android.MockFS{ |
| 224 | "system/sepolicy/apex/myapex-file_contexts": nil, |
| 225 | }) |
| 226 | |
Jooyung Han | 643adc4 | 2020-02-27 13:50:06 +0900 | [diff] [blame] | 227 | // ensure that 'result' equals 'expected' |
| 228 | func ensureEquals(t *testing.T, result string, expected string) { |
| 229 | t.Helper() |
| 230 | if result != expected { |
| 231 | t.Errorf("%q != %q", expected, result) |
| 232 | } |
| 233 | } |
| 234 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 235 | // ensure that 'result' contains 'expected' |
| 236 | func ensureContains(t *testing.T, result string, expected string) { |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 237 | t.Helper() |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 238 | if !strings.Contains(result, expected) { |
| 239 | t.Errorf("%q is not found in %q", expected, result) |
| 240 | } |
| 241 | } |
| 242 | |
Liz Kammer | 5bd365f | 2020-05-27 15:15:11 -0700 | [diff] [blame] | 243 | // ensure that 'result' contains 'expected' exactly one time |
| 244 | func ensureContainsOnce(t *testing.T, result string, expected string) { |
| 245 | t.Helper() |
| 246 | count := strings.Count(result, expected) |
| 247 | if count != 1 { |
| 248 | t.Errorf("%q is found %d times (expected 1 time) in %q", expected, count, result) |
| 249 | } |
| 250 | } |
| 251 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 252 | // ensures that 'result' does not contain 'notExpected' |
| 253 | func ensureNotContains(t *testing.T, result string, notExpected string) { |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 254 | t.Helper() |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 255 | if strings.Contains(result, notExpected) { |
| 256 | t.Errorf("%q is found in %q", notExpected, result) |
| 257 | } |
| 258 | } |
| 259 | |
Sasha Smundak | 18d98bc | 2020-05-27 16:36:07 -0700 | [diff] [blame] | 260 | func ensureMatches(t *testing.T, result string, expectedRex string) { |
| 261 | ok, err := regexp.MatchString(expectedRex, result) |
| 262 | if err != nil { |
| 263 | t.Fatalf("regexp failure trying to match %s against `%s` expression: %s", result, expectedRex, err) |
| 264 | return |
| 265 | } |
| 266 | if !ok { |
| 267 | t.Errorf("%s does not match regular expession %s", result, expectedRex) |
| 268 | } |
| 269 | } |
| 270 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 271 | func ensureListContains(t *testing.T, result []string, expected string) { |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 272 | t.Helper() |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 273 | if !android.InList(expected, result) { |
| 274 | t.Errorf("%q is not found in %v", expected, result) |
| 275 | } |
| 276 | } |
| 277 | |
| 278 | func ensureListNotContains(t *testing.T, result []string, notExpected string) { |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 279 | t.Helper() |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 280 | if android.InList(notExpected, result) { |
| 281 | t.Errorf("%q is found in %v", notExpected, result) |
| 282 | } |
| 283 | } |
| 284 | |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 285 | func ensureListEmpty(t *testing.T, result []string) { |
| 286 | t.Helper() |
| 287 | if len(result) > 0 { |
| 288 | t.Errorf("%q is expected to be empty", result) |
| 289 | } |
| 290 | } |
| 291 | |
Mohammad Samiul Islam | 3cd005d | 2020-11-26 13:32:26 +0000 | [diff] [blame] | 292 | func ensureListNotEmpty(t *testing.T, result []string) { |
| 293 | t.Helper() |
| 294 | if len(result) == 0 { |
| 295 | t.Errorf("%q is expected to be not empty", result) |
| 296 | } |
| 297 | } |
| 298 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 299 | // Minimal test |
| 300 | func TestBasicApex(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 301 | ctx := testApex(t, ` |
Jiyong Park | 30ca937 | 2019-02-07 16:27:23 +0900 | [diff] [blame] | 302 | apex_defaults { |
| 303 | name: "myapex-defaults", |
Jiyong Park | 809bb72 | 2019-02-13 21:33:49 +0900 | [diff] [blame] | 304 | manifest: ":myapex.manifest", |
| 305 | androidManifest: ":myapex.androidmanifest", |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 306 | key: "myapex.key", |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 307 | binaries: ["foo.rust"], |
Jiyong Park | f2cc1b7 | 2020-12-09 00:20:45 +0900 | [diff] [blame] | 308 | native_shared_libs: [ |
| 309 | "mylib", |
| 310 | "libfoo.ffi", |
| 311 | ], |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 312 | rust_dyn_libs: ["libfoo.dylib.rust"], |
Alex Light | 3d67359 | 2019-01-18 14:37:31 -0800 | [diff] [blame] | 313 | multilib: { |
| 314 | both: { |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 315 | binaries: ["foo"], |
Alex Light | 3d67359 | 2019-01-18 14:37:31 -0800 | [diff] [blame] | 316 | } |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 317 | }, |
Jiyong Park | 77acec6 | 2020-06-01 21:39:15 +0900 | [diff] [blame] | 318 | java_libs: [ |
| 319 | "myjar", |
| 320 | "myjar_dex", |
| 321 | ], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 322 | updatable: false, |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 323 | } |
| 324 | |
Jiyong Park | 30ca937 | 2019-02-07 16:27:23 +0900 | [diff] [blame] | 325 | apex { |
| 326 | name: "myapex", |
| 327 | defaults: ["myapex-defaults"], |
| 328 | } |
| 329 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 330 | apex_key { |
| 331 | name: "myapex.key", |
| 332 | public_key: "testkey.avbpubkey", |
| 333 | private_key: "testkey.pem", |
| 334 | } |
| 335 | |
Jiyong Park | 809bb72 | 2019-02-13 21:33:49 +0900 | [diff] [blame] | 336 | filegroup { |
| 337 | name: "myapex.manifest", |
| 338 | srcs: ["apex_manifest.json"], |
| 339 | } |
| 340 | |
| 341 | filegroup { |
| 342 | name: "myapex.androidmanifest", |
| 343 | srcs: ["AndroidManifest.xml"], |
| 344 | } |
| 345 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 346 | cc_library { |
| 347 | name: "mylib", |
| 348 | srcs: ["mylib.cpp"], |
Jiyong Park | f2cc1b7 | 2020-12-09 00:20:45 +0900 | [diff] [blame] | 349 | shared_libs: [ |
| 350 | "mylib2", |
| 351 | "libbar.ffi", |
| 352 | ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 353 | system_shared_libs: [], |
| 354 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 355 | // TODO: remove //apex_available:platform |
| 356 | apex_available: [ |
| 357 | "//apex_available:platform", |
| 358 | "myapex", |
| 359 | ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 360 | } |
| 361 | |
Alex Light | 3d67359 | 2019-01-18 14:37:31 -0800 | [diff] [blame] | 362 | cc_binary { |
| 363 | name: "foo", |
| 364 | srcs: ["mylib.cpp"], |
| 365 | compile_multilib: "both", |
| 366 | multilib: { |
| 367 | lib32: { |
| 368 | suffix: "32", |
| 369 | }, |
| 370 | lib64: { |
| 371 | suffix: "64", |
| 372 | }, |
| 373 | }, |
| 374 | symlinks: ["foo_link_"], |
| 375 | symlink_preferred_arch: true, |
| 376 | system_shared_libs: [], |
| 377 | static_executable: true, |
| 378 | stl: "none", |
Yifan Hong | d22a84a | 2020-07-28 17:37:46 -0700 | [diff] [blame] | 379 | apex_available: [ "myapex", "com.android.gki.*" ], |
| 380 | } |
| 381 | |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 382 | rust_binary { |
Artur Satayev | 533b98c | 2021-03-11 18:03:42 +0000 | [diff] [blame] | 383 | name: "foo.rust", |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 384 | srcs: ["foo.rs"], |
| 385 | rlibs: ["libfoo.rlib.rust"], |
| 386 | dylibs: ["libfoo.dylib.rust"], |
| 387 | apex_available: ["myapex"], |
| 388 | } |
| 389 | |
| 390 | rust_library_rlib { |
Artur Satayev | 533b98c | 2021-03-11 18:03:42 +0000 | [diff] [blame] | 391 | name: "libfoo.rlib.rust", |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 392 | srcs: ["foo.rs"], |
| 393 | crate_name: "foo", |
| 394 | apex_available: ["myapex"], |
Jiyong Park | 94e22fd | 2021-04-08 18:19:15 +0900 | [diff] [blame] | 395 | shared_libs: ["libfoo.shared_from_rust"], |
| 396 | } |
| 397 | |
| 398 | cc_library_shared { |
| 399 | name: "libfoo.shared_from_rust", |
| 400 | srcs: ["mylib.cpp"], |
| 401 | system_shared_libs: [], |
| 402 | stl: "none", |
| 403 | apex_available: ["myapex"], |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 404 | } |
| 405 | |
| 406 | rust_library_dylib { |
Artur Satayev | 533b98c | 2021-03-11 18:03:42 +0000 | [diff] [blame] | 407 | name: "libfoo.dylib.rust", |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 408 | srcs: ["foo.rs"], |
| 409 | crate_name: "foo", |
| 410 | apex_available: ["myapex"], |
| 411 | } |
| 412 | |
Jiyong Park | f2cc1b7 | 2020-12-09 00:20:45 +0900 | [diff] [blame] | 413 | rust_ffi_shared { |
| 414 | name: "libfoo.ffi", |
| 415 | srcs: ["foo.rs"], |
| 416 | crate_name: "foo", |
| 417 | apex_available: ["myapex"], |
| 418 | } |
| 419 | |
| 420 | rust_ffi_shared { |
| 421 | name: "libbar.ffi", |
| 422 | srcs: ["foo.rs"], |
| 423 | crate_name: "bar", |
| 424 | apex_available: ["myapex"], |
| 425 | } |
| 426 | |
Yifan Hong | d22a84a | 2020-07-28 17:37:46 -0700 | [diff] [blame] | 427 | apex { |
| 428 | name: "com.android.gki.fake", |
| 429 | binaries: ["foo"], |
| 430 | key: "myapex.key", |
| 431 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 432 | updatable: false, |
Alex Light | 3d67359 | 2019-01-18 14:37:31 -0800 | [diff] [blame] | 433 | } |
| 434 | |
Paul Duffin | dddd546 | 2020-04-07 15:25:44 +0100 | [diff] [blame] | 435 | cc_library_shared { |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 436 | name: "mylib2", |
| 437 | srcs: ["mylib.cpp"], |
| 438 | system_shared_libs: [], |
| 439 | stl: "none", |
Jiyong Park | 52818fc | 2019-03-18 12:01:38 +0900 | [diff] [blame] | 440 | notice: "custom_notice", |
Jiyong Park | 9918e1a | 2020-03-17 19:16:40 +0900 | [diff] [blame] | 441 | static_libs: ["libstatic"], |
| 442 | // TODO: remove //apex_available:platform |
| 443 | apex_available: [ |
| 444 | "//apex_available:platform", |
| 445 | "myapex", |
| 446 | ], |
| 447 | } |
| 448 | |
Paul Duffin | dddd546 | 2020-04-07 15:25:44 +0100 | [diff] [blame] | 449 | cc_prebuilt_library_shared { |
| 450 | name: "mylib2", |
| 451 | srcs: ["prebuilt.so"], |
| 452 | // TODO: remove //apex_available:platform |
| 453 | apex_available: [ |
| 454 | "//apex_available:platform", |
| 455 | "myapex", |
| 456 | ], |
| 457 | } |
| 458 | |
Jiyong Park | 9918e1a | 2020-03-17 19:16:40 +0900 | [diff] [blame] | 459 | cc_library_static { |
| 460 | name: "libstatic", |
| 461 | srcs: ["mylib.cpp"], |
| 462 | system_shared_libs: [], |
| 463 | stl: "none", |
| 464 | notice: "custom_notice_for_static_lib", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 465 | // TODO: remove //apex_available:platform |
| 466 | apex_available: [ |
| 467 | "//apex_available:platform", |
| 468 | "myapex", |
| 469 | ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 470 | } |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 471 | |
| 472 | java_library { |
| 473 | name: "myjar", |
| 474 | srcs: ["foo/bar/MyClass.java"], |
Jiyong Park | a62aa23 | 2020-05-28 23:46:55 +0900 | [diff] [blame] | 475 | stem: "myjar_stem", |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 476 | sdk_version: "none", |
| 477 | system_modules: "none", |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 478 | static_libs: ["myotherjar"], |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 479 | libs: ["mysharedjar"], |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 480 | // TODO: remove //apex_available:platform |
| 481 | apex_available: [ |
| 482 | "//apex_available:platform", |
| 483 | "myapex", |
| 484 | ], |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 485 | } |
| 486 | |
Jiyong Park | 77acec6 | 2020-06-01 21:39:15 +0900 | [diff] [blame] | 487 | dex_import { |
| 488 | name: "myjar_dex", |
| 489 | jars: ["prebuilt.jar"], |
| 490 | apex_available: [ |
| 491 | "//apex_available:platform", |
| 492 | "myapex", |
| 493 | ], |
| 494 | } |
| 495 | |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 496 | java_library { |
| 497 | name: "myotherjar", |
| 498 | srcs: ["foo/bar/MyClass.java"], |
| 499 | sdk_version: "none", |
| 500 | system_modules: "none", |
Jiyong Park | 0f80c18 | 2020-01-31 02:49:53 +0900 | [diff] [blame] | 501 | // TODO: remove //apex_available:platform |
| 502 | apex_available: [ |
| 503 | "//apex_available:platform", |
| 504 | "myapex", |
| 505 | ], |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 506 | } |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 507 | |
| 508 | java_library { |
| 509 | name: "mysharedjar", |
| 510 | srcs: ["foo/bar/MyClass.java"], |
| 511 | sdk_version: "none", |
| 512 | system_modules: "none", |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 513 | } |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 514 | `) |
| 515 | |
Paul Duffin | a71a67a | 2021-03-29 00:42:57 +0100 | [diff] [blame] | 516 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Jiyong Park | 42cca6c | 2019-04-01 11:15:50 +0900 | [diff] [blame] | 517 | |
Jiyong Park | 9e83f0b | 2020-06-11 00:35:03 +0900 | [diff] [blame] | 518 | // Make sure that Android.mk is created |
| 519 | ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 520 | data := android.AndroidMkDataForTest(t, ctx, ab) |
Jiyong Park | 9e83f0b | 2020-06-11 00:35:03 +0900 | [diff] [blame] | 521 | var builder strings.Builder |
| 522 | data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data) |
| 523 | |
| 524 | androidMk := builder.String() |
| 525 | ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n") |
| 526 | ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n") |
| 527 | |
Jiyong Park | 42cca6c | 2019-04-01 11:15:50 +0900 | [diff] [blame] | 528 | optFlags := apexRule.Args["opt_flags"] |
| 529 | ensureContains(t, optFlags, "--pubkey vendor/foo/devkeys/testkey.avbpubkey") |
Jaewoong Jung | 14f5ff6 | 2019-06-18 13:09:13 -0700 | [diff] [blame] | 530 | // Ensure that the NOTICE output is being packaged as an asset. |
Paul Duffin | 37ba344 | 2021-03-29 00:21:08 +0100 | [diff] [blame] | 531 | ensureContains(t, optFlags, "--assets_dir out/soong/.intermediates/myapex/android_common_myapex_image/NOTICE") |
Jiyong Park | 42cca6c | 2019-04-01 11:15:50 +0900 | [diff] [blame] | 532 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 533 | copyCmds := apexRule.Args["copy_commands"] |
| 534 | |
| 535 | // Ensure that main rule creates an output |
| 536 | ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned") |
| 537 | |
| 538 | // Ensure that apex variant is created for the direct dep |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 539 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000") |
| 540 | ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common_apex10000") |
| 541 | ensureListContains(t, ctx.ModuleVariantsForTests("myjar_dex"), "android_common_apex10000") |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 542 | ensureListContains(t, ctx.ModuleVariantsForTests("foo.rust"), "android_arm64_armv8-a_apex10000") |
Jiyong Park | f2cc1b7 | 2020-12-09 00:20:45 +0900 | [diff] [blame] | 543 | ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.ffi"), "android_arm64_armv8-a_shared_apex10000") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 544 | |
| 545 | // Ensure that apex variant is created for the indirect dep |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 546 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000") |
| 547 | ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common_apex10000") |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 548 | ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.rlib.rust"), "android_arm64_armv8-a_rlib_dylib-std_apex10000") |
| 549 | ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.dylib.rust"), "android_arm64_armv8-a_dylib_apex10000") |
Jiyong Park | f2cc1b7 | 2020-12-09 00:20:45 +0900 | [diff] [blame] | 550 | ensureListContains(t, ctx.ModuleVariantsForTests("libbar.ffi"), "android_arm64_armv8-a_shared_apex10000") |
Jiyong Park | 94e22fd | 2021-04-08 18:19:15 +0900 | [diff] [blame] | 551 | ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.shared_from_rust"), "android_arm64_armv8-a_shared_apex10000") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 552 | |
| 553 | // Ensure that both direct and indirect deps are copied into apex |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 554 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
| 555 | ensureContains(t, copyCmds, "image.apex/lib64/mylib2.so") |
Jiyong Park | a62aa23 | 2020-05-28 23:46:55 +0900 | [diff] [blame] | 556 | ensureContains(t, copyCmds, "image.apex/javalib/myjar_stem.jar") |
Jiyong Park | 77acec6 | 2020-06-01 21:39:15 +0900 | [diff] [blame] | 557 | ensureContains(t, copyCmds, "image.apex/javalib/myjar_dex.jar") |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 558 | ensureContains(t, copyCmds, "image.apex/lib64/libfoo.dylib.rust.dylib.so") |
Jiyong Park | f2cc1b7 | 2020-12-09 00:20:45 +0900 | [diff] [blame] | 559 | ensureContains(t, copyCmds, "image.apex/lib64/libfoo.ffi.so") |
| 560 | ensureContains(t, copyCmds, "image.apex/lib64/libbar.ffi.so") |
Jiyong Park | 94e22fd | 2021-04-08 18:19:15 +0900 | [diff] [blame] | 561 | ensureContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so") |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 562 | // .. but not for java libs |
| 563 | ensureNotContains(t, copyCmds, "image.apex/javalib/myotherjar.jar") |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 564 | ensureNotContains(t, copyCmds, "image.apex/javalib/msharedjar.jar") |
Logan Chien | 3aeedc9 | 2018-12-26 15:32:21 +0800 | [diff] [blame] | 565 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 566 | // Ensure that the platform variant ends with _shared or _common |
| 567 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared") |
| 568 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared") |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 569 | ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common") |
| 570 | ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common") |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 571 | ensureListContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common") |
| 572 | |
| 573 | // Ensure that dynamic dependency to java libs are not included |
| 574 | ensureListNotContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common_myapex") |
Alex Light | 3d67359 | 2019-01-18 14:37:31 -0800 | [diff] [blame] | 575 | |
| 576 | // Ensure that all symlinks are present. |
| 577 | found_foo_link_64 := false |
| 578 | found_foo := false |
| 579 | for _, cmd := range strings.Split(copyCmds, " && ") { |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 580 | if strings.HasPrefix(cmd, "ln -sfn foo64") { |
Alex Light | 3d67359 | 2019-01-18 14:37:31 -0800 | [diff] [blame] | 581 | if strings.HasSuffix(cmd, "bin/foo") { |
| 582 | found_foo = true |
| 583 | } else if strings.HasSuffix(cmd, "bin/foo_link_64") { |
| 584 | found_foo_link_64 = true |
| 585 | } |
| 586 | } |
| 587 | } |
| 588 | good := found_foo && found_foo_link_64 |
| 589 | if !good { |
| 590 | t.Errorf("Could not find all expected symlinks! foo: %t, foo_link_64: %t. Command was %s", found_foo, found_foo_link_64, copyCmds) |
| 591 | } |
Jiyong Park | 52818fc | 2019-03-18 12:01:38 +0900 | [diff] [blame] | 592 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 593 | mergeNoticesRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("mergeNoticesRule") |
Jaewoong Jung | 5b425e2 | 2019-06-17 17:40:56 -0700 | [diff] [blame] | 594 | noticeInputs := mergeNoticesRule.Inputs.Strings() |
Jiyong Park | 9918e1a | 2020-03-17 19:16:40 +0900 | [diff] [blame] | 595 | if len(noticeInputs) != 3 { |
| 596 | t.Errorf("number of input notice files: expected = 3, actual = %q", len(noticeInputs)) |
Jiyong Park | 52818fc | 2019-03-18 12:01:38 +0900 | [diff] [blame] | 597 | } |
| 598 | ensureListContains(t, noticeInputs, "NOTICE") |
| 599 | ensureListContains(t, noticeInputs, "custom_notice") |
Jiyong Park | 9918e1a | 2020-03-17 19:16:40 +0900 | [diff] [blame] | 600 | ensureListContains(t, noticeInputs, "custom_notice_for_static_lib") |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 601 | |
Artur Satayev | a8bd113 | 2020-04-27 18:07:06 +0100 | [diff] [blame] | 602 | fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n") |
Artur Satayev | 4e1f2bd | 2020-05-14 15:15:01 +0100 | [diff] [blame] | 603 | ensureListContains(t, fullDepsInfo, " myjar(minSdkVersion:(no version)) <- myapex") |
Artur Satayev | 4e1f2bd | 2020-05-14 15:15:01 +0100 | [diff] [blame] | 604 | ensureListContains(t, fullDepsInfo, " mylib2(minSdkVersion:(no version)) <- mylib") |
| 605 | ensureListContains(t, fullDepsInfo, " myotherjar(minSdkVersion:(no version)) <- myjar") |
| 606 | ensureListContains(t, fullDepsInfo, " mysharedjar(minSdkVersion:(no version)) (external) <- myjar") |
Artur Satayev | a8bd113 | 2020-04-27 18:07:06 +0100 | [diff] [blame] | 607 | |
| 608 | flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n") |
Artur Satayev | 4e1f2bd | 2020-05-14 15:15:01 +0100 | [diff] [blame] | 609 | ensureListContains(t, flatDepsInfo, "myjar(minSdkVersion:(no version))") |
Artur Satayev | 4e1f2bd | 2020-05-14 15:15:01 +0100 | [diff] [blame] | 610 | ensureListContains(t, flatDepsInfo, "mylib2(minSdkVersion:(no version))") |
| 611 | ensureListContains(t, flatDepsInfo, "myotherjar(minSdkVersion:(no version))") |
| 612 | ensureListContains(t, flatDepsInfo, "mysharedjar(minSdkVersion:(no version)) (external)") |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 613 | } |
| 614 | |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 615 | func TestDefaults(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 616 | ctx := testApex(t, ` |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 617 | apex_defaults { |
| 618 | name: "myapex-defaults", |
| 619 | key: "myapex.key", |
| 620 | prebuilts: ["myetc"], |
| 621 | native_shared_libs: ["mylib"], |
| 622 | java_libs: ["myjar"], |
| 623 | apps: ["AppFoo"], |
Jiyong Park | 69aeba9 | 2020-04-24 21:16:36 +0900 | [diff] [blame] | 624 | rros: ["rro"], |
markchien | 2f59ec9 | 2020-09-02 16:23:38 +0800 | [diff] [blame] | 625 | bpfs: ["bpf"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 626 | updatable: false, |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 627 | } |
| 628 | |
| 629 | prebuilt_etc { |
| 630 | name: "myetc", |
| 631 | src: "myprebuilt", |
| 632 | } |
| 633 | |
| 634 | apex { |
| 635 | name: "myapex", |
| 636 | defaults: ["myapex-defaults"], |
| 637 | } |
| 638 | |
| 639 | apex_key { |
| 640 | name: "myapex.key", |
| 641 | public_key: "testkey.avbpubkey", |
| 642 | private_key: "testkey.pem", |
| 643 | } |
| 644 | |
| 645 | cc_library { |
| 646 | name: "mylib", |
| 647 | system_shared_libs: [], |
| 648 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 649 | apex_available: [ "myapex" ], |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 650 | } |
| 651 | |
| 652 | java_library { |
| 653 | name: "myjar", |
| 654 | srcs: ["foo/bar/MyClass.java"], |
| 655 | sdk_version: "none", |
| 656 | system_modules: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 657 | apex_available: [ "myapex" ], |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 658 | } |
| 659 | |
| 660 | android_app { |
| 661 | name: "AppFoo", |
| 662 | srcs: ["foo/bar/MyClass.java"], |
| 663 | sdk_version: "none", |
| 664 | system_modules: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 665 | apex_available: [ "myapex" ], |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 666 | } |
Jiyong Park | 69aeba9 | 2020-04-24 21:16:36 +0900 | [diff] [blame] | 667 | |
| 668 | runtime_resource_overlay { |
| 669 | name: "rro", |
| 670 | theme: "blue", |
| 671 | } |
| 672 | |
markchien | 2f59ec9 | 2020-09-02 16:23:38 +0800 | [diff] [blame] | 673 | bpf { |
| 674 | name: "bpf", |
| 675 | srcs: ["bpf.c", "bpf2.c"], |
| 676 | } |
| 677 | |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 678 | `) |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 679 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 680 | "etc/myetc", |
| 681 | "javalib/myjar.jar", |
| 682 | "lib64/mylib.so", |
| 683 | "app/AppFoo/AppFoo.apk", |
Jiyong Park | 69aeba9 | 2020-04-24 21:16:36 +0900 | [diff] [blame] | 684 | "overlay/blue/rro.apk", |
markchien | 2f59ec9 | 2020-09-02 16:23:38 +0800 | [diff] [blame] | 685 | "etc/bpf/bpf.o", |
| 686 | "etc/bpf/bpf2.o", |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 687 | }) |
| 688 | } |
| 689 | |
Jooyung Han | 01a3ee2 | 2019-11-02 02:52:25 +0900 | [diff] [blame] | 690 | func TestApexManifest(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 691 | ctx := testApex(t, ` |
Jooyung Han | 01a3ee2 | 2019-11-02 02:52:25 +0900 | [diff] [blame] | 692 | apex { |
| 693 | name: "myapex", |
| 694 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 695 | updatable: false, |
Jooyung Han | 01a3ee2 | 2019-11-02 02:52:25 +0900 | [diff] [blame] | 696 | } |
| 697 | |
| 698 | apex_key { |
| 699 | name: "myapex.key", |
| 700 | public_key: "testkey.avbpubkey", |
| 701 | private_key: "testkey.pem", |
| 702 | } |
| 703 | `) |
| 704 | |
| 705 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 706 | args := module.Rule("apexRule").Args |
| 707 | if manifest := args["manifest"]; manifest != module.Output("apex_manifest.pb").Output.String() { |
| 708 | t.Error("manifest should be apex_manifest.pb, but " + manifest) |
| 709 | } |
Jooyung Han | 01a3ee2 | 2019-11-02 02:52:25 +0900 | [diff] [blame] | 710 | } |
| 711 | |
Liz Kammer | 4854a7d | 2021-05-27 14:28:27 -0400 | [diff] [blame] | 712 | func TestApexManifestMinSdkVersion(t *testing.T) { |
| 713 | ctx := testApex(t, ` |
| 714 | apex_defaults { |
| 715 | name: "my_defaults", |
| 716 | key: "myapex.key", |
| 717 | product_specific: true, |
| 718 | file_contexts: ":my-file-contexts", |
| 719 | updatable: false, |
| 720 | } |
| 721 | apex { |
| 722 | name: "myapex_30", |
| 723 | min_sdk_version: "30", |
| 724 | defaults: ["my_defaults"], |
| 725 | } |
| 726 | |
| 727 | apex { |
| 728 | name: "myapex_current", |
| 729 | min_sdk_version: "current", |
| 730 | defaults: ["my_defaults"], |
| 731 | } |
| 732 | |
| 733 | apex { |
| 734 | name: "myapex_none", |
| 735 | defaults: ["my_defaults"], |
| 736 | } |
| 737 | |
| 738 | apex_key { |
| 739 | name: "myapex.key", |
| 740 | public_key: "testkey.avbpubkey", |
| 741 | private_key: "testkey.pem", |
| 742 | } |
| 743 | |
| 744 | filegroup { |
| 745 | name: "my-file-contexts", |
| 746 | srcs: ["product_specific_file_contexts"], |
| 747 | } |
| 748 | `, withFiles(map[string][]byte{ |
| 749 | "product_specific_file_contexts": nil, |
| 750 | }), android.FixtureModifyProductVariables( |
| 751 | func(variables android.FixtureProductVariables) { |
| 752 | variables.Unbundled_build = proptools.BoolPtr(true) |
| 753 | variables.Always_use_prebuilt_sdks = proptools.BoolPtr(false) |
| 754 | }), android.FixtureMergeEnv(map[string]string{ |
| 755 | "UNBUNDLED_BUILD_TARGET_SDK_WITH_API_FINGERPRINT": "true", |
| 756 | })) |
| 757 | |
| 758 | testCases := []struct { |
| 759 | module string |
| 760 | minSdkVersion string |
| 761 | }{ |
| 762 | { |
| 763 | module: "myapex_30", |
| 764 | minSdkVersion: "30", |
| 765 | }, |
| 766 | { |
| 767 | module: "myapex_current", |
| 768 | minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)", |
| 769 | }, |
| 770 | { |
| 771 | module: "myapex_none", |
| 772 | minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)", |
| 773 | }, |
| 774 | } |
| 775 | for _, tc := range testCases { |
| 776 | module := ctx.ModuleForTests(tc.module, "android_common_"+tc.module+"_image") |
| 777 | args := module.Rule("apexRule").Args |
| 778 | optFlags := args["opt_flags"] |
| 779 | if !strings.Contains(optFlags, "--min_sdk_version "+tc.minSdkVersion) { |
| 780 | t.Errorf("%s: Expected min_sdk_version=%s, got: %s", tc.module, tc.minSdkVersion, optFlags) |
| 781 | } |
| 782 | } |
| 783 | } |
| 784 | |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 785 | func TestBasicZipApex(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 786 | ctx := testApex(t, ` |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 787 | apex { |
| 788 | name: "myapex", |
| 789 | key: "myapex.key", |
| 790 | payload_type: "zip", |
| 791 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 792 | updatable: false, |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 793 | } |
| 794 | |
| 795 | apex_key { |
| 796 | name: "myapex.key", |
| 797 | public_key: "testkey.avbpubkey", |
| 798 | private_key: "testkey.pem", |
| 799 | } |
| 800 | |
| 801 | cc_library { |
| 802 | name: "mylib", |
| 803 | srcs: ["mylib.cpp"], |
| 804 | shared_libs: ["mylib2"], |
| 805 | system_shared_libs: [], |
| 806 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 807 | apex_available: [ "myapex" ], |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 808 | } |
| 809 | |
| 810 | cc_library { |
| 811 | name: "mylib2", |
| 812 | srcs: ["mylib.cpp"], |
| 813 | system_shared_libs: [], |
| 814 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 815 | apex_available: [ "myapex" ], |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 816 | } |
| 817 | `) |
| 818 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 819 | zipApexRule := ctx.ModuleForTests("myapex", "android_common_myapex_zip").Rule("zipApexRule") |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 820 | copyCmds := zipApexRule.Args["copy_commands"] |
| 821 | |
| 822 | // Ensure that main rule creates an output |
| 823 | ensureContains(t, zipApexRule.Output.String(), "myapex.zipapex.unsigned") |
| 824 | |
| 825 | // Ensure that APEX variant is created for the direct dep |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 826 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000") |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 827 | |
| 828 | // Ensure that APEX variant is created for the indirect dep |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 829 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000") |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 830 | |
| 831 | // Ensure that both direct and indirect deps are copied into apex |
| 832 | ensureContains(t, copyCmds, "image.zipapex/lib64/mylib.so") |
| 833 | ensureContains(t, copyCmds, "image.zipapex/lib64/mylib2.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 834 | } |
| 835 | |
| 836 | func TestApexWithStubs(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 837 | ctx := testApex(t, ` |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 838 | apex { |
| 839 | name: "myapex", |
| 840 | key: "myapex.key", |
| 841 | native_shared_libs: ["mylib", "mylib3"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 842 | updatable: false, |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 843 | } |
| 844 | |
| 845 | apex_key { |
| 846 | name: "myapex.key", |
| 847 | public_key: "testkey.avbpubkey", |
| 848 | private_key: "testkey.pem", |
| 849 | } |
| 850 | |
| 851 | cc_library { |
| 852 | name: "mylib", |
| 853 | srcs: ["mylib.cpp"], |
| 854 | shared_libs: ["mylib2", "mylib3"], |
| 855 | system_shared_libs: [], |
| 856 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 857 | apex_available: [ "myapex" ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 858 | } |
| 859 | |
| 860 | cc_library { |
| 861 | name: "mylib2", |
| 862 | srcs: ["mylib.cpp"], |
Jiyong Park | 6437995 | 2018-12-13 18:37:29 +0900 | [diff] [blame] | 863 | cflags: ["-include mylib.h"], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 864 | system_shared_libs: [], |
| 865 | stl: "none", |
| 866 | stubs: { |
| 867 | versions: ["1", "2", "3"], |
| 868 | }, |
| 869 | } |
| 870 | |
| 871 | cc_library { |
| 872 | name: "mylib3", |
Jiyong Park | 28d395a | 2018-12-07 22:42:47 +0900 | [diff] [blame] | 873 | srcs: ["mylib.cpp"], |
| 874 | shared_libs: ["mylib4"], |
| 875 | system_shared_libs: [], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 876 | stl: "none", |
| 877 | stubs: { |
| 878 | versions: ["10", "11", "12"], |
| 879 | }, |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 880 | apex_available: [ "myapex" ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 881 | } |
Jiyong Park | 28d395a | 2018-12-07 22:42:47 +0900 | [diff] [blame] | 882 | |
| 883 | cc_library { |
| 884 | name: "mylib4", |
| 885 | srcs: ["mylib.cpp"], |
| 886 | system_shared_libs: [], |
| 887 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 888 | apex_available: [ "myapex" ], |
Jiyong Park | 28d395a | 2018-12-07 22:42:47 +0900 | [diff] [blame] | 889 | } |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 890 | `) |
| 891 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 892 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 893 | copyCmds := apexRule.Args["copy_commands"] |
| 894 | |
| 895 | // Ensure that direct non-stubs dep is always included |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 896 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 897 | |
| 898 | // Ensure that indirect stubs dep is not included |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 899 | ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 900 | |
| 901 | // Ensure that direct stubs dep is included |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 902 | ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 903 | |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 904 | mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"] |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 905 | |
| 906 | // Ensure that mylib is linking with the latest version of stubs for mylib2 |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 907 | ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 908 | // ... and not linking to the non-stub (impl) variant of mylib2 |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 909 | ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 910 | |
| 911 | // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex) |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 912 | ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex10000/mylib3.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 913 | // .. and not linking to the stubs variant of mylib3 |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 914 | ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_12/mylib3.so") |
Jiyong Park | 6437995 | 2018-12-13 18:37:29 +0900 | [diff] [blame] | 915 | |
| 916 | // Ensure that stubs libs are built without -include flags |
Jiyong Park | 0f80c18 | 2020-01-31 02:49:53 +0900 | [diff] [blame] | 917 | mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
Jiyong Park | 6437995 | 2018-12-13 18:37:29 +0900 | [diff] [blame] | 918 | ensureNotContains(t, mylib2Cflags, "-include ") |
Jiyong Park | 3fd0baf | 2018-12-07 16:25:39 +0900 | [diff] [blame] | 919 | |
| 920 | // Ensure that genstub is invoked with --apex |
Colin Cross | a717db7 | 2020-10-23 14:53:06 -0700 | [diff] [blame] | 921 | ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_3").Rule("genStubSrc").Args["flags"]) |
Jooyung Han | 671f1ce | 2019-12-17 12:47:13 +0900 | [diff] [blame] | 922 | |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 923 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
Jooyung Han | 671f1ce | 2019-12-17 12:47:13 +0900 | [diff] [blame] | 924 | "lib64/mylib.so", |
| 925 | "lib64/mylib3.so", |
| 926 | "lib64/mylib4.so", |
| 927 | }) |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 928 | } |
| 929 | |
Colin Cross | 7812fd3 | 2020-09-25 12:35:10 -0700 | [diff] [blame] | 930 | func TestApexWithStubsWithMinSdkVersion(t *testing.T) { |
| 931 | t.Parallel() |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 932 | ctx := testApex(t, ` |
Colin Cross | 7812fd3 | 2020-09-25 12:35:10 -0700 | [diff] [blame] | 933 | apex { |
| 934 | name: "myapex", |
| 935 | key: "myapex.key", |
| 936 | native_shared_libs: ["mylib", "mylib3"], |
| 937 | min_sdk_version: "29", |
| 938 | } |
| 939 | |
| 940 | apex_key { |
| 941 | name: "myapex.key", |
| 942 | public_key: "testkey.avbpubkey", |
| 943 | private_key: "testkey.pem", |
| 944 | } |
| 945 | |
| 946 | cc_library { |
| 947 | name: "mylib", |
| 948 | srcs: ["mylib.cpp"], |
| 949 | shared_libs: ["mylib2", "mylib3"], |
| 950 | system_shared_libs: [], |
| 951 | stl: "none", |
| 952 | apex_available: [ "myapex" ], |
| 953 | min_sdk_version: "28", |
| 954 | } |
| 955 | |
| 956 | cc_library { |
| 957 | name: "mylib2", |
| 958 | srcs: ["mylib.cpp"], |
| 959 | cflags: ["-include mylib.h"], |
| 960 | system_shared_libs: [], |
| 961 | stl: "none", |
| 962 | stubs: { |
| 963 | versions: ["28", "29", "30", "current"], |
| 964 | }, |
| 965 | min_sdk_version: "28", |
| 966 | } |
| 967 | |
| 968 | cc_library { |
| 969 | name: "mylib3", |
| 970 | srcs: ["mylib.cpp"], |
| 971 | shared_libs: ["mylib4"], |
| 972 | system_shared_libs: [], |
| 973 | stl: "none", |
| 974 | stubs: { |
| 975 | versions: ["28", "29", "30", "current"], |
| 976 | }, |
| 977 | apex_available: [ "myapex" ], |
| 978 | min_sdk_version: "28", |
| 979 | } |
| 980 | |
| 981 | cc_library { |
| 982 | name: "mylib4", |
| 983 | srcs: ["mylib.cpp"], |
| 984 | system_shared_libs: [], |
| 985 | stl: "none", |
| 986 | apex_available: [ "myapex" ], |
| 987 | min_sdk_version: "28", |
| 988 | } |
| 989 | `) |
| 990 | |
| 991 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
| 992 | copyCmds := apexRule.Args["copy_commands"] |
| 993 | |
| 994 | // Ensure that direct non-stubs dep is always included |
| 995 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
| 996 | |
| 997 | // Ensure that indirect stubs dep is not included |
| 998 | ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so") |
| 999 | |
| 1000 | // Ensure that direct stubs dep is included |
| 1001 | ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so") |
| 1002 | |
| 1003 | mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex29").Rule("ld").Args["libFlags"] |
| 1004 | |
Jiyong Park | 55549df | 2021-02-26 23:57:23 +0900 | [diff] [blame] | 1005 | // Ensure that mylib is linking with the latest version of stub for mylib2 |
| 1006 | ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so") |
Colin Cross | 7812fd3 | 2020-09-25 12:35:10 -0700 | [diff] [blame] | 1007 | // ... and not linking to the non-stub (impl) variant of mylib2 |
| 1008 | ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so") |
| 1009 | |
| 1010 | // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex) |
| 1011 | ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex29/mylib3.so") |
| 1012 | // .. and not linking to the stubs variant of mylib3 |
| 1013 | ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_29/mylib3.so") |
| 1014 | |
| 1015 | // Ensure that stubs libs are built without -include flags |
Colin Cross | a717db7 | 2020-10-23 14:53:06 -0700 | [diff] [blame] | 1016 | mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("cc").Args["cFlags"] |
Colin Cross | 7812fd3 | 2020-09-25 12:35:10 -0700 | [diff] [blame] | 1017 | ensureNotContains(t, mylib2Cflags, "-include ") |
| 1018 | |
| 1019 | // Ensure that genstub is invoked with --apex |
Colin Cross | a717db7 | 2020-10-23 14:53:06 -0700 | [diff] [blame] | 1020 | ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("genStubSrc").Args["flags"]) |
Colin Cross | 7812fd3 | 2020-09-25 12:35:10 -0700 | [diff] [blame] | 1021 | |
| 1022 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 1023 | "lib64/mylib.so", |
| 1024 | "lib64/mylib3.so", |
| 1025 | "lib64/mylib4.so", |
| 1026 | }) |
| 1027 | } |
| 1028 | |
Jooyung Han | 11b0fbd | 2021-02-05 02:28:22 +0900 | [diff] [blame] | 1029 | func TestApex_PlatformUsesLatestStubFromApex(t *testing.T) { |
| 1030 | t.Parallel() |
| 1031 | // myapex (Z) |
| 1032 | // mylib -----------------. |
| 1033 | // | |
| 1034 | // otherapex (29) | |
| 1035 | // libstub's versions: 29 Z current |
| 1036 | // | |
| 1037 | // <platform> | |
| 1038 | // libplatform ----------------' |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1039 | ctx := testApex(t, ` |
Jooyung Han | 11b0fbd | 2021-02-05 02:28:22 +0900 | [diff] [blame] | 1040 | apex { |
| 1041 | name: "myapex", |
| 1042 | key: "myapex.key", |
| 1043 | native_shared_libs: ["mylib"], |
| 1044 | min_sdk_version: "Z", // non-final |
| 1045 | } |
| 1046 | |
| 1047 | cc_library { |
| 1048 | name: "mylib", |
| 1049 | srcs: ["mylib.cpp"], |
| 1050 | shared_libs: ["libstub"], |
| 1051 | apex_available: ["myapex"], |
| 1052 | min_sdk_version: "Z", |
| 1053 | } |
| 1054 | |
| 1055 | apex_key { |
| 1056 | name: "myapex.key", |
| 1057 | public_key: "testkey.avbpubkey", |
| 1058 | private_key: "testkey.pem", |
| 1059 | } |
| 1060 | |
| 1061 | apex { |
| 1062 | name: "otherapex", |
| 1063 | key: "myapex.key", |
| 1064 | native_shared_libs: ["libstub"], |
| 1065 | min_sdk_version: "29", |
| 1066 | } |
| 1067 | |
| 1068 | cc_library { |
| 1069 | name: "libstub", |
| 1070 | srcs: ["mylib.cpp"], |
| 1071 | stubs: { |
| 1072 | versions: ["29", "Z", "current"], |
| 1073 | }, |
| 1074 | apex_available: ["otherapex"], |
| 1075 | min_sdk_version: "29", |
| 1076 | } |
| 1077 | |
| 1078 | // platform module depending on libstub from otherapex should use the latest stub("current") |
| 1079 | cc_library { |
| 1080 | name: "libplatform", |
| 1081 | srcs: ["mylib.cpp"], |
| 1082 | shared_libs: ["libstub"], |
| 1083 | } |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 1084 | `, |
| 1085 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 1086 | variables.Platform_sdk_codename = proptools.StringPtr("Z") |
| 1087 | variables.Platform_sdk_final = proptools.BoolPtr(false) |
| 1088 | variables.Platform_version_active_codenames = []string{"Z"} |
| 1089 | }), |
| 1090 | ) |
Jooyung Han | 11b0fbd | 2021-02-05 02:28:22 +0900 | [diff] [blame] | 1091 | |
Jiyong Park | 55549df | 2021-02-26 23:57:23 +0900 | [diff] [blame] | 1092 | // Ensure that mylib from myapex is built against the latest stub (current) |
Jooyung Han | 11b0fbd | 2021-02-05 02:28:22 +0900 | [diff] [blame] | 1093 | mylibCflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"] |
Jiyong Park | 55549df | 2021-02-26 23:57:23 +0900 | [diff] [blame] | 1094 | ensureContains(t, mylibCflags, "-D__LIBSTUB_API__=10000 ") |
Jooyung Han | 11b0fbd | 2021-02-05 02:28:22 +0900 | [diff] [blame] | 1095 | mylibLdflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"] |
Jiyong Park | 55549df | 2021-02-26 23:57:23 +0900 | [diff] [blame] | 1096 | ensureContains(t, mylibLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ") |
Jooyung Han | 11b0fbd | 2021-02-05 02:28:22 +0900 | [diff] [blame] | 1097 | |
| 1098 | // Ensure that libplatform is built against latest stub ("current") of mylib3 from the apex |
| 1099 | libplatformCflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
| 1100 | ensureContains(t, libplatformCflags, "-D__LIBSTUB_API__=10000 ") // "current" maps to 10000 |
| 1101 | libplatformLdflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"] |
| 1102 | ensureContains(t, libplatformLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ") |
| 1103 | } |
| 1104 | |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1105 | func TestApexWithExplicitStubsDependency(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1106 | ctx := testApex(t, ` |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1107 | apex { |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 1108 | name: "myapex2", |
| 1109 | key: "myapex2.key", |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1110 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 1111 | updatable: false, |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1112 | } |
| 1113 | |
| 1114 | apex_key { |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 1115 | name: "myapex2.key", |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1116 | public_key: "testkey.avbpubkey", |
| 1117 | private_key: "testkey.pem", |
| 1118 | } |
| 1119 | |
| 1120 | cc_library { |
| 1121 | name: "mylib", |
| 1122 | srcs: ["mylib.cpp"], |
| 1123 | shared_libs: ["libfoo#10"], |
Jiyong Park | 678c881 | 2020-02-07 17:25:49 +0900 | [diff] [blame] | 1124 | static_libs: ["libbaz"], |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1125 | system_shared_libs: [], |
| 1126 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 1127 | apex_available: [ "myapex2" ], |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1128 | } |
| 1129 | |
| 1130 | cc_library { |
| 1131 | name: "libfoo", |
| 1132 | srcs: ["mylib.cpp"], |
| 1133 | shared_libs: ["libbar"], |
| 1134 | system_shared_libs: [], |
| 1135 | stl: "none", |
| 1136 | stubs: { |
| 1137 | versions: ["10", "20", "30"], |
| 1138 | }, |
| 1139 | } |
| 1140 | |
| 1141 | cc_library { |
| 1142 | name: "libbar", |
| 1143 | srcs: ["mylib.cpp"], |
| 1144 | system_shared_libs: [], |
| 1145 | stl: "none", |
| 1146 | } |
| 1147 | |
Jiyong Park | 678c881 | 2020-02-07 17:25:49 +0900 | [diff] [blame] | 1148 | cc_library_static { |
| 1149 | name: "libbaz", |
| 1150 | srcs: ["mylib.cpp"], |
| 1151 | system_shared_libs: [], |
| 1152 | stl: "none", |
| 1153 | apex_available: [ "myapex2" ], |
| 1154 | } |
| 1155 | |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1156 | `) |
| 1157 | |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 1158 | apexRule := ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Rule("apexRule") |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1159 | copyCmds := apexRule.Args["copy_commands"] |
| 1160 | |
| 1161 | // Ensure that direct non-stubs dep is always included |
| 1162 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
| 1163 | |
| 1164 | // Ensure that indirect stubs dep is not included |
| 1165 | ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so") |
| 1166 | |
| 1167 | // Ensure that dependency of stubs is not included |
| 1168 | ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so") |
| 1169 | |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1170 | mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"] |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1171 | |
| 1172 | // Ensure that mylib is linking with version 10 of libfoo |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 1173 | ensureContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared_10/libfoo.so") |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1174 | // ... and not linking to the non-stub (impl) variant of libfoo |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 1175 | ensureNotContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared/libfoo.so") |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1176 | |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 1177 | libFooStubsLdFlags := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_10").Rule("ld").Args["libFlags"] |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1178 | |
| 1179 | // Ensure that libfoo stubs is not linking to libbar (since it is a stubs) |
| 1180 | ensureNotContains(t, libFooStubsLdFlags, "libbar.so") |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 1181 | |
Artur Satayev | a8bd113 | 2020-04-27 18:07:06 +0100 | [diff] [blame] | 1182 | fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n") |
Artur Satayev | 4e1f2bd | 2020-05-14 15:15:01 +0100 | [diff] [blame] | 1183 | ensureListContains(t, fullDepsInfo, " libfoo(minSdkVersion:(no version)) (external) <- mylib") |
Jiyong Park | 678c881 | 2020-02-07 17:25:49 +0900 | [diff] [blame] | 1184 | |
Artur Satayev | a8bd113 | 2020-04-27 18:07:06 +0100 | [diff] [blame] | 1185 | flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n") |
Artur Satayev | 4e1f2bd | 2020-05-14 15:15:01 +0100 | [diff] [blame] | 1186 | ensureListContains(t, flatDepsInfo, "libfoo(minSdkVersion:(no version)) (external)") |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1187 | } |
| 1188 | |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 1189 | func TestApexWithRuntimeLibsDependency(t *testing.T) { |
| 1190 | /* |
| 1191 | myapex |
| 1192 | | |
| 1193 | v (runtime_libs) |
| 1194 | mylib ------+------> libfoo [provides stub] |
| 1195 | | |
| 1196 | `------> libbar |
| 1197 | */ |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1198 | ctx := testApex(t, ` |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 1199 | apex { |
| 1200 | name: "myapex", |
| 1201 | key: "myapex.key", |
| 1202 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 1203 | updatable: false, |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 1204 | } |
| 1205 | |
| 1206 | apex_key { |
| 1207 | name: "myapex.key", |
| 1208 | public_key: "testkey.avbpubkey", |
| 1209 | private_key: "testkey.pem", |
| 1210 | } |
| 1211 | |
| 1212 | cc_library { |
| 1213 | name: "mylib", |
| 1214 | srcs: ["mylib.cpp"], |
| 1215 | runtime_libs: ["libfoo", "libbar"], |
| 1216 | system_shared_libs: [], |
| 1217 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 1218 | apex_available: [ "myapex" ], |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 1219 | } |
| 1220 | |
| 1221 | cc_library { |
| 1222 | name: "libfoo", |
| 1223 | srcs: ["mylib.cpp"], |
| 1224 | system_shared_libs: [], |
| 1225 | stl: "none", |
| 1226 | stubs: { |
| 1227 | versions: ["10", "20", "30"], |
| 1228 | }, |
| 1229 | } |
| 1230 | |
| 1231 | cc_library { |
| 1232 | name: "libbar", |
| 1233 | srcs: ["mylib.cpp"], |
| 1234 | system_shared_libs: [], |
| 1235 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 1236 | apex_available: [ "myapex" ], |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 1237 | } |
| 1238 | |
| 1239 | `) |
| 1240 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 1241 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 1242 | copyCmds := apexRule.Args["copy_commands"] |
| 1243 | |
| 1244 | // Ensure that direct non-stubs dep is always included |
| 1245 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
| 1246 | |
| 1247 | // Ensure that indirect stubs dep is not included |
| 1248 | ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so") |
| 1249 | |
| 1250 | // Ensure that runtime_libs dep in included |
| 1251 | ensureContains(t, copyCmds, "image.apex/lib64/libbar.so") |
| 1252 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 1253 | apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 1254 | ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"])) |
| 1255 | ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.so") |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 1256 | |
| 1257 | } |
| 1258 | |
Paul Duffin | a02cae3 | 2021-03-09 01:44:06 +0000 | [diff] [blame] | 1259 | var prepareForTestOfRuntimeApexWithHwasan = android.GroupFixturePreparers( |
| 1260 | cc.PrepareForTestWithCcBuildComponents, |
| 1261 | PrepareForTestWithApexBuildComponents, |
| 1262 | android.FixtureAddTextFile("bionic/apex/Android.bp", ` |
Jooyung Han | 8ce8db9 | 2020-05-15 19:05:05 +0900 | [diff] [blame] | 1263 | apex { |
| 1264 | name: "com.android.runtime", |
| 1265 | key: "com.android.runtime.key", |
| 1266 | native_shared_libs: ["libc"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 1267 | updatable: false, |
Jooyung Han | 8ce8db9 | 2020-05-15 19:05:05 +0900 | [diff] [blame] | 1268 | } |
| 1269 | |
| 1270 | apex_key { |
| 1271 | name: "com.android.runtime.key", |
| 1272 | public_key: "testkey.avbpubkey", |
| 1273 | private_key: "testkey.pem", |
| 1274 | } |
Paul Duffin | a02cae3 | 2021-03-09 01:44:06 +0000 | [diff] [blame] | 1275 | `), |
| 1276 | android.FixtureAddFile("system/sepolicy/apex/com.android.runtime-file_contexts", nil), |
| 1277 | ) |
Jooyung Han | 8ce8db9 | 2020-05-15 19:05:05 +0900 | [diff] [blame] | 1278 | |
Paul Duffin | a02cae3 | 2021-03-09 01:44:06 +0000 | [diff] [blame] | 1279 | func TestRuntimeApexShouldInstallHwasanIfLibcDependsOnIt(t *testing.T) { |
Paul Duffin | 70d3bee | 2021-03-21 11:26:05 +0000 | [diff] [blame] | 1280 | result := android.GroupFixturePreparers(prepareForTestOfRuntimeApexWithHwasan).RunTestWithBp(t, ` |
Jooyung Han | 8ce8db9 | 2020-05-15 19:05:05 +0900 | [diff] [blame] | 1281 | cc_library { |
| 1282 | name: "libc", |
| 1283 | no_libcrt: true, |
| 1284 | nocrt: true, |
| 1285 | stl: "none", |
| 1286 | system_shared_libs: [], |
| 1287 | stubs: { versions: ["1"] }, |
| 1288 | apex_available: ["com.android.runtime"], |
| 1289 | |
| 1290 | sanitize: { |
| 1291 | hwaddress: true, |
| 1292 | } |
| 1293 | } |
| 1294 | |
| 1295 | cc_prebuilt_library_shared { |
| 1296 | name: "libclang_rt.hwasan-aarch64-android", |
| 1297 | no_libcrt: true, |
| 1298 | nocrt: true, |
| 1299 | stl: "none", |
| 1300 | system_shared_libs: [], |
| 1301 | srcs: [""], |
| 1302 | stubs: { versions: ["1"] }, |
| 1303 | |
| 1304 | sanitize: { |
| 1305 | never: true, |
| 1306 | }, |
Paul Duffin | a02cae3 | 2021-03-09 01:44:06 +0000 | [diff] [blame] | 1307 | } `) |
| 1308 | ctx := result.TestContext |
Jooyung Han | 8ce8db9 | 2020-05-15 19:05:05 +0900 | [diff] [blame] | 1309 | |
| 1310 | ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{ |
| 1311 | "lib64/bionic/libc.so", |
| 1312 | "lib64/bionic/libclang_rt.hwasan-aarch64-android.so", |
| 1313 | }) |
| 1314 | |
| 1315 | hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared") |
| 1316 | |
| 1317 | installed := hwasan.Description("install libclang_rt.hwasan") |
| 1318 | ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so") |
| 1319 | |
| 1320 | symlink := hwasan.Description("install symlink libclang_rt.hwasan") |
| 1321 | ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so") |
| 1322 | ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so") |
| 1323 | } |
| 1324 | |
| 1325 | func TestRuntimeApexShouldInstallHwasanIfHwaddressSanitized(t *testing.T) { |
Paul Duffin | 70d3bee | 2021-03-21 11:26:05 +0000 | [diff] [blame] | 1326 | result := android.GroupFixturePreparers( |
Paul Duffin | a02cae3 | 2021-03-09 01:44:06 +0000 | [diff] [blame] | 1327 | prepareForTestOfRuntimeApexWithHwasan, |
| 1328 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 1329 | variables.SanitizeDevice = []string{"hwaddress"} |
| 1330 | }), |
| 1331 | ).RunTestWithBp(t, ` |
Jooyung Han | 8ce8db9 | 2020-05-15 19:05:05 +0900 | [diff] [blame] | 1332 | cc_library { |
| 1333 | name: "libc", |
| 1334 | no_libcrt: true, |
| 1335 | nocrt: true, |
| 1336 | stl: "none", |
| 1337 | system_shared_libs: [], |
| 1338 | stubs: { versions: ["1"] }, |
| 1339 | apex_available: ["com.android.runtime"], |
| 1340 | } |
| 1341 | |
| 1342 | cc_prebuilt_library_shared { |
| 1343 | name: "libclang_rt.hwasan-aarch64-android", |
| 1344 | no_libcrt: true, |
| 1345 | nocrt: true, |
| 1346 | stl: "none", |
| 1347 | system_shared_libs: [], |
| 1348 | srcs: [""], |
| 1349 | stubs: { versions: ["1"] }, |
| 1350 | |
| 1351 | sanitize: { |
| 1352 | never: true, |
| 1353 | }, |
| 1354 | } |
Paul Duffin | a02cae3 | 2021-03-09 01:44:06 +0000 | [diff] [blame] | 1355 | `) |
| 1356 | ctx := result.TestContext |
Jooyung Han | 8ce8db9 | 2020-05-15 19:05:05 +0900 | [diff] [blame] | 1357 | |
| 1358 | ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{ |
| 1359 | "lib64/bionic/libc.so", |
| 1360 | "lib64/bionic/libclang_rt.hwasan-aarch64-android.so", |
| 1361 | }) |
| 1362 | |
| 1363 | hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared") |
| 1364 | |
| 1365 | installed := hwasan.Description("install libclang_rt.hwasan") |
| 1366 | ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so") |
| 1367 | |
| 1368 | symlink := hwasan.Description("install symlink libclang_rt.hwasan") |
| 1369 | ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so") |
| 1370 | ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so") |
| 1371 | } |
| 1372 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1373 | func TestApexDependsOnLLNDKTransitively(t *testing.T) { |
| 1374 | testcases := []struct { |
| 1375 | name string |
| 1376 | minSdkVersion string |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1377 | apexVariant string |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1378 | shouldLink string |
| 1379 | shouldNotLink []string |
| 1380 | }{ |
| 1381 | { |
Jiyong Park | 55549df | 2021-02-26 23:57:23 +0900 | [diff] [blame] | 1382 | name: "unspecified version links to the latest", |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1383 | minSdkVersion: "", |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1384 | apexVariant: "apex10000", |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1385 | shouldLink: "current", |
| 1386 | shouldNotLink: []string{"29", "30"}, |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1387 | }, |
| 1388 | { |
Jiyong Park | 55549df | 2021-02-26 23:57:23 +0900 | [diff] [blame] | 1389 | name: "always use the latest", |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1390 | minSdkVersion: "min_sdk_version: \"29\",", |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1391 | apexVariant: "apex29", |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1392 | shouldLink: "current", |
| 1393 | shouldNotLink: []string{"29", "30"}, |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1394 | }, |
| 1395 | } |
| 1396 | for _, tc := range testcases { |
| 1397 | t.Run(tc.name, func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1398 | ctx := testApex(t, ` |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1399 | apex { |
| 1400 | name: "myapex", |
| 1401 | key: "myapex.key", |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1402 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 1403 | updatable: false, |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1404 | `+tc.minSdkVersion+` |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1405 | } |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1406 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1407 | apex_key { |
| 1408 | name: "myapex.key", |
| 1409 | public_key: "testkey.avbpubkey", |
| 1410 | private_key: "testkey.pem", |
| 1411 | } |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1412 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1413 | cc_library { |
| 1414 | name: "mylib", |
| 1415 | srcs: ["mylib.cpp"], |
| 1416 | vendor_available: true, |
| 1417 | shared_libs: ["libbar"], |
| 1418 | system_shared_libs: [], |
| 1419 | stl: "none", |
| 1420 | apex_available: [ "myapex" ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1421 | min_sdk_version: "29", |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1422 | } |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1423 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1424 | cc_library { |
| 1425 | name: "libbar", |
| 1426 | srcs: ["mylib.cpp"], |
| 1427 | system_shared_libs: [], |
| 1428 | stl: "none", |
| 1429 | stubs: { versions: ["29","30"] }, |
Colin Cross | 203b421 | 2021-04-26 17:19:41 -0700 | [diff] [blame] | 1430 | llndk: { |
| 1431 | symbol_file: "libbar.map.txt", |
| 1432 | } |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1433 | } |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 1434 | `, |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 1435 | withUnbundledBuild, |
| 1436 | ) |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1437 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1438 | // Ensure that LLNDK dep is not included |
| 1439 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 1440 | "lib64/mylib.so", |
| 1441 | }) |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1442 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1443 | // Ensure that LLNDK dep is required |
| 1444 | apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule") |
| 1445 | ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"])) |
| 1446 | ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libbar.so") |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1447 | |
Steven Moreland | 2c4000c | 2021-04-27 02:08:49 +0000 | [diff] [blame] | 1448 | mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_"+tc.apexVariant).Rule("ld").Args["libFlags"] |
| 1449 | ensureContains(t, mylibLdFlags, "libbar/android_arm64_armv8-a_shared_"+tc.shouldLink+"/libbar.so") |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1450 | for _, ver := range tc.shouldNotLink { |
Steven Moreland | 2c4000c | 2021-04-27 02:08:49 +0000 | [diff] [blame] | 1451 | ensureNotContains(t, mylibLdFlags, "libbar/android_arm64_armv8-a_shared_"+ver+"/libbar.so") |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1452 | } |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1453 | |
Steven Moreland | 2c4000c | 2021-04-27 02:08:49 +0000 | [diff] [blame] | 1454 | mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_"+tc.apexVariant).Rule("cc").Args["cFlags"] |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1455 | ver := tc.shouldLink |
| 1456 | if tc.shouldLink == "current" { |
| 1457 | ver = strconv.Itoa(android.FutureApiLevelInt) |
| 1458 | } |
| 1459 | ensureContains(t, mylibCFlags, "__LIBBAR_API__="+ver) |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1460 | }) |
| 1461 | } |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1462 | } |
| 1463 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1464 | func TestApexWithSystemLibsStubs(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1465 | ctx := testApex(t, ` |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1466 | apex { |
| 1467 | name: "myapex", |
| 1468 | key: "myapex.key", |
| 1469 | native_shared_libs: ["mylib", "mylib_shared", "libdl", "libm"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 1470 | updatable: false, |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1471 | } |
| 1472 | |
| 1473 | apex_key { |
| 1474 | name: "myapex.key", |
| 1475 | public_key: "testkey.avbpubkey", |
| 1476 | private_key: "testkey.pem", |
| 1477 | } |
| 1478 | |
| 1479 | cc_library { |
| 1480 | name: "mylib", |
| 1481 | srcs: ["mylib.cpp"], |
Colin Cross | 0de8a1e | 2020-09-18 14:15:30 -0700 | [diff] [blame] | 1482 | system_shared_libs: ["libc", "libm"], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1483 | shared_libs: ["libdl#27"], |
| 1484 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 1485 | apex_available: [ "myapex" ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1486 | } |
| 1487 | |
| 1488 | cc_library_shared { |
| 1489 | name: "mylib_shared", |
| 1490 | srcs: ["mylib.cpp"], |
| 1491 | shared_libs: ["libdl#27"], |
| 1492 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 1493 | apex_available: [ "myapex" ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1494 | } |
| 1495 | |
| 1496 | cc_library { |
Jiyong Park | b078857 | 2018-12-20 22:10:17 +0900 | [diff] [blame] | 1497 | name: "libBootstrap", |
| 1498 | srcs: ["mylib.cpp"], |
| 1499 | stl: "none", |
| 1500 | bootstrap: true, |
| 1501 | } |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1502 | `) |
| 1503 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 1504 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1505 | copyCmds := apexRule.Args["copy_commands"] |
| 1506 | |
| 1507 | // Ensure that mylib, libm, libdl are included. |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 1508 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
Jiyong Park | b078857 | 2018-12-20 22:10:17 +0900 | [diff] [blame] | 1509 | ensureContains(t, copyCmds, "image.apex/lib64/bionic/libm.so") |
| 1510 | ensureContains(t, copyCmds, "image.apex/lib64/bionic/libdl.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1511 | |
| 1512 | // Ensure that libc is not included (since it has stubs and not listed in native_shared_libs) |
Jiyong Park | b078857 | 2018-12-20 22:10:17 +0900 | [diff] [blame] | 1513 | ensureNotContains(t, copyCmds, "image.apex/lib64/bionic/libc.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1514 | |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1515 | mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"] |
| 1516 | mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"] |
| 1517 | mylibSharedCFlags := ctx.ModuleForTests("mylib_shared", "android_arm64_armv8-a_shared_apex10000").Rule("cc").Args["cFlags"] |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1518 | |
| 1519 | // For dependency to libc |
| 1520 | // Ensure that mylib is linking with the latest version of stubs |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1521 | ensureContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared_current/libc.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1522 | // ... and not linking to the non-stub (impl) variant |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 1523 | ensureNotContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared/libc.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1524 | // ... Cflags from stub is correctly exported to mylib |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1525 | ensureContains(t, mylibCFlags, "__LIBC_API__=10000") |
| 1526 | ensureContains(t, mylibSharedCFlags, "__LIBC_API__=10000") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1527 | |
| 1528 | // For dependency to libm |
| 1529 | // Ensure that mylib is linking with the non-stub (impl) variant |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1530 | ensureContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_apex10000/libm.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1531 | // ... and not linking to the stub variant |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 1532 | ensureNotContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_29/libm.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1533 | // ... and is not compiling with the stub |
| 1534 | ensureNotContains(t, mylibCFlags, "__LIBM_API__=29") |
| 1535 | ensureNotContains(t, mylibSharedCFlags, "__LIBM_API__=29") |
| 1536 | |
| 1537 | // For dependency to libdl |
| 1538 | // Ensure that mylib is linking with the specified version of stubs |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 1539 | ensureContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_27/libdl.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1540 | // ... and not linking to the other versions of stubs |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 1541 | ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_28/libdl.so") |
| 1542 | ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_29/libdl.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1543 | // ... and not linking to the non-stub (impl) variant |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1544 | ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_apex10000/libdl.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1545 | // ... Cflags from stub is correctly exported to mylib |
| 1546 | ensureContains(t, mylibCFlags, "__LIBDL_API__=27") |
| 1547 | ensureContains(t, mylibSharedCFlags, "__LIBDL_API__=27") |
Jiyong Park | b078857 | 2018-12-20 22:10:17 +0900 | [diff] [blame] | 1548 | |
| 1549 | // Ensure that libBootstrap is depending on the platform variant of bionic libs |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 1550 | libFlags := ctx.ModuleForTests("libBootstrap", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"] |
| 1551 | ensureContains(t, libFlags, "libc/android_arm64_armv8-a_shared/libc.so") |
| 1552 | ensureContains(t, libFlags, "libm/android_arm64_armv8-a_shared/libm.so") |
| 1553 | ensureContains(t, libFlags, "libdl/android_arm64_armv8-a_shared/libdl.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1554 | } |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 1555 | |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1556 | func TestApexMinSdkVersion_NativeModulesShouldBeBuiltAgainstStubs(t *testing.T) { |
Jiyong Park | 55549df | 2021-02-26 23:57:23 +0900 | [diff] [blame] | 1557 | // there are three links between liba --> libz. |
| 1558 | // 1) myapex -> libx -> liba -> libz : this should be #30 link |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1559 | // 2) otherapex -> liby -> liba -> libz : this should be #30 link |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1560 | // 3) (platform) -> liba -> libz : this should be non-stub link |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1561 | ctx := testApex(t, ` |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1562 | apex { |
| 1563 | name: "myapex", |
| 1564 | key: "myapex.key", |
| 1565 | native_shared_libs: ["libx"], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1566 | min_sdk_version: "29", |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1567 | } |
| 1568 | |
| 1569 | apex { |
| 1570 | name: "otherapex", |
| 1571 | key: "myapex.key", |
| 1572 | native_shared_libs: ["liby"], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1573 | min_sdk_version: "30", |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1574 | } |
| 1575 | |
| 1576 | apex_key { |
| 1577 | name: "myapex.key", |
| 1578 | public_key: "testkey.avbpubkey", |
| 1579 | private_key: "testkey.pem", |
| 1580 | } |
| 1581 | |
| 1582 | cc_library { |
| 1583 | name: "libx", |
| 1584 | shared_libs: ["liba"], |
| 1585 | system_shared_libs: [], |
| 1586 | stl: "none", |
| 1587 | apex_available: [ "myapex" ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1588 | min_sdk_version: "29", |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1589 | } |
| 1590 | |
| 1591 | cc_library { |
| 1592 | name: "liby", |
| 1593 | shared_libs: ["liba"], |
| 1594 | system_shared_libs: [], |
| 1595 | stl: "none", |
| 1596 | apex_available: [ "otherapex" ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1597 | min_sdk_version: "29", |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1598 | } |
| 1599 | |
| 1600 | cc_library { |
| 1601 | name: "liba", |
| 1602 | shared_libs: ["libz"], |
| 1603 | system_shared_libs: [], |
| 1604 | stl: "none", |
| 1605 | apex_available: [ |
| 1606 | "//apex_available:anyapex", |
| 1607 | "//apex_available:platform", |
| 1608 | ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1609 | min_sdk_version: "29", |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1610 | } |
| 1611 | |
| 1612 | cc_library { |
| 1613 | name: "libz", |
| 1614 | system_shared_libs: [], |
| 1615 | stl: "none", |
| 1616 | stubs: { |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1617 | versions: ["28", "30"], |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1618 | }, |
| 1619 | } |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1620 | `) |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1621 | |
| 1622 | expectLink := func(from, from_variant, to, to_variant string) { |
| 1623 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1624 | ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1625 | } |
| 1626 | expectNoLink := func(from, from_variant, to, to_variant string) { |
| 1627 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1628 | ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1629 | } |
| 1630 | // platform liba is linked to non-stub version |
| 1631 | expectLink("liba", "shared", "libz", "shared") |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1632 | // liba in myapex is linked to current |
| 1633 | expectLink("liba", "shared_apex29", "libz", "shared_current") |
| 1634 | expectNoLink("liba", "shared_apex29", "libz", "shared_30") |
Jiyong Park | 55549df | 2021-02-26 23:57:23 +0900 | [diff] [blame] | 1635 | expectNoLink("liba", "shared_apex29", "libz", "shared_28") |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1636 | expectNoLink("liba", "shared_apex29", "libz", "shared") |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1637 | // liba in otherapex is linked to current |
| 1638 | expectLink("liba", "shared_apex30", "libz", "shared_current") |
| 1639 | expectNoLink("liba", "shared_apex30", "libz", "shared_30") |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1640 | expectNoLink("liba", "shared_apex30", "libz", "shared_28") |
| 1641 | expectNoLink("liba", "shared_apex30", "libz", "shared") |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1642 | } |
| 1643 | |
Jooyung Han | aed150d | 2020-04-02 01:41:41 +0900 | [diff] [blame] | 1644 | func TestApexMinSdkVersion_SupportsCodeNames(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1645 | ctx := testApex(t, ` |
Jooyung Han | aed150d | 2020-04-02 01:41:41 +0900 | [diff] [blame] | 1646 | apex { |
| 1647 | name: "myapex", |
| 1648 | key: "myapex.key", |
| 1649 | native_shared_libs: ["libx"], |
| 1650 | min_sdk_version: "R", |
| 1651 | } |
| 1652 | |
| 1653 | apex_key { |
| 1654 | name: "myapex.key", |
| 1655 | public_key: "testkey.avbpubkey", |
| 1656 | private_key: "testkey.pem", |
| 1657 | } |
| 1658 | |
| 1659 | cc_library { |
| 1660 | name: "libx", |
| 1661 | shared_libs: ["libz"], |
| 1662 | system_shared_libs: [], |
| 1663 | stl: "none", |
| 1664 | apex_available: [ "myapex" ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1665 | min_sdk_version: "R", |
Jooyung Han | aed150d | 2020-04-02 01:41:41 +0900 | [diff] [blame] | 1666 | } |
| 1667 | |
| 1668 | cc_library { |
| 1669 | name: "libz", |
| 1670 | system_shared_libs: [], |
| 1671 | stl: "none", |
| 1672 | stubs: { |
| 1673 | versions: ["29", "R"], |
| 1674 | }, |
| 1675 | } |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 1676 | `, |
| 1677 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 1678 | variables.Platform_version_active_codenames = []string{"R"} |
| 1679 | }), |
| 1680 | ) |
Jooyung Han | aed150d | 2020-04-02 01:41:41 +0900 | [diff] [blame] | 1681 | |
| 1682 | expectLink := func(from, from_variant, to, to_variant string) { |
| 1683 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1684 | ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1685 | } |
| 1686 | expectNoLink := func(from, from_variant, to, to_variant string) { |
| 1687 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1688 | ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1689 | } |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1690 | expectLink("libx", "shared_apex10000", "libz", "shared_current") |
| 1691 | expectNoLink("libx", "shared_apex10000", "libz", "shared_R") |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1692 | expectNoLink("libx", "shared_apex10000", "libz", "shared_29") |
| 1693 | expectNoLink("libx", "shared_apex10000", "libz", "shared") |
Jooyung Han | aed150d | 2020-04-02 01:41:41 +0900 | [diff] [blame] | 1694 | } |
| 1695 | |
Jooyung Han | 4c4da06 | 2021-06-23 10:23:16 +0900 | [diff] [blame] | 1696 | func TestApexMinSdkVersion_SupportsCodeNames_JavaLibs(t *testing.T) { |
| 1697 | testApex(t, ` |
| 1698 | apex { |
| 1699 | name: "myapex", |
| 1700 | key: "myapex.key", |
| 1701 | java_libs: ["libx"], |
| 1702 | min_sdk_version: "S", |
| 1703 | } |
| 1704 | |
| 1705 | apex_key { |
| 1706 | name: "myapex.key", |
| 1707 | public_key: "testkey.avbpubkey", |
| 1708 | private_key: "testkey.pem", |
| 1709 | } |
| 1710 | |
| 1711 | java_library { |
| 1712 | name: "libx", |
| 1713 | srcs: ["a.java"], |
| 1714 | apex_available: [ "myapex" ], |
| 1715 | sdk_version: "current", |
| 1716 | min_sdk_version: "S", // should be okay |
| 1717 | } |
| 1718 | `, |
| 1719 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 1720 | variables.Platform_version_active_codenames = []string{"S"} |
| 1721 | variables.Platform_sdk_codename = proptools.StringPtr("S") |
| 1722 | }), |
| 1723 | ) |
| 1724 | } |
| 1725 | |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1726 | func TestApexMinSdkVersion_DefaultsToLatest(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1727 | ctx := testApex(t, ` |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1728 | apex { |
| 1729 | name: "myapex", |
| 1730 | key: "myapex.key", |
| 1731 | native_shared_libs: ["libx"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 1732 | updatable: false, |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1733 | } |
| 1734 | |
| 1735 | apex_key { |
| 1736 | name: "myapex.key", |
| 1737 | public_key: "testkey.avbpubkey", |
| 1738 | private_key: "testkey.pem", |
| 1739 | } |
| 1740 | |
| 1741 | cc_library { |
| 1742 | name: "libx", |
| 1743 | shared_libs: ["libz"], |
| 1744 | system_shared_libs: [], |
| 1745 | stl: "none", |
| 1746 | apex_available: [ "myapex" ], |
| 1747 | } |
| 1748 | |
| 1749 | cc_library { |
| 1750 | name: "libz", |
| 1751 | system_shared_libs: [], |
| 1752 | stl: "none", |
| 1753 | stubs: { |
| 1754 | versions: ["1", "2"], |
| 1755 | }, |
| 1756 | } |
| 1757 | `) |
| 1758 | |
| 1759 | expectLink := func(from, from_variant, to, to_variant string) { |
| 1760 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1761 | ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1762 | } |
| 1763 | expectNoLink := func(from, from_variant, to, to_variant string) { |
| 1764 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1765 | ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1766 | } |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1767 | expectLink("libx", "shared_apex10000", "libz", "shared_current") |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1768 | expectNoLink("libx", "shared_apex10000", "libz", "shared_1") |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1769 | expectNoLink("libx", "shared_apex10000", "libz", "shared_2") |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1770 | expectNoLink("libx", "shared_apex10000", "libz", "shared") |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1771 | } |
| 1772 | |
| 1773 | func TestPlatformUsesLatestStubsFromApexes(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1774 | ctx := testApex(t, ` |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1775 | apex { |
| 1776 | name: "myapex", |
| 1777 | key: "myapex.key", |
| 1778 | native_shared_libs: ["libx"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 1779 | updatable: false, |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1780 | } |
| 1781 | |
| 1782 | apex_key { |
| 1783 | name: "myapex.key", |
| 1784 | public_key: "testkey.avbpubkey", |
| 1785 | private_key: "testkey.pem", |
| 1786 | } |
| 1787 | |
| 1788 | cc_library { |
| 1789 | name: "libx", |
| 1790 | system_shared_libs: [], |
| 1791 | stl: "none", |
| 1792 | apex_available: [ "myapex" ], |
| 1793 | stubs: { |
| 1794 | versions: ["1", "2"], |
| 1795 | }, |
| 1796 | } |
| 1797 | |
| 1798 | cc_library { |
| 1799 | name: "libz", |
| 1800 | shared_libs: ["libx"], |
| 1801 | system_shared_libs: [], |
| 1802 | stl: "none", |
| 1803 | } |
| 1804 | `) |
| 1805 | |
| 1806 | expectLink := func(from, from_variant, to, to_variant string) { |
Colin Cross | 56a8321 | 2020-09-15 18:30:11 -0700 | [diff] [blame] | 1807 | t.Helper() |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1808 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1809 | ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1810 | } |
| 1811 | expectNoLink := func(from, from_variant, to, to_variant string) { |
Colin Cross | 56a8321 | 2020-09-15 18:30:11 -0700 | [diff] [blame] | 1812 | t.Helper() |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1813 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1814 | ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1815 | } |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1816 | expectLink("libz", "shared", "libx", "shared_current") |
| 1817 | expectNoLink("libz", "shared", "libx", "shared_2") |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1818 | expectNoLink("libz", "shared", "libz", "shared_1") |
| 1819 | expectNoLink("libz", "shared", "libz", "shared") |
| 1820 | } |
| 1821 | |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 1822 | var prepareForTestWithSantitizeHwaddress = android.FixtureModifyProductVariables( |
| 1823 | func(variables android.FixtureProductVariables) { |
| 1824 | variables.SanitizeDevice = []string{"hwaddress"} |
| 1825 | }, |
| 1826 | ) |
| 1827 | |
Jooyung Han | 7556839 | 2020-03-20 04:29:24 +0900 | [diff] [blame] | 1828 | func TestQApexesUseLatestStubsInBundledBuildsAndHWASAN(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1829 | ctx := testApex(t, ` |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1830 | apex { |
| 1831 | name: "myapex", |
| 1832 | key: "myapex.key", |
| 1833 | native_shared_libs: ["libx"], |
| 1834 | min_sdk_version: "29", |
| 1835 | } |
| 1836 | |
| 1837 | apex_key { |
| 1838 | name: "myapex.key", |
| 1839 | public_key: "testkey.avbpubkey", |
| 1840 | private_key: "testkey.pem", |
| 1841 | } |
| 1842 | |
| 1843 | cc_library { |
| 1844 | name: "libx", |
| 1845 | shared_libs: ["libbar"], |
| 1846 | apex_available: [ "myapex" ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1847 | min_sdk_version: "29", |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1848 | } |
| 1849 | |
| 1850 | cc_library { |
| 1851 | name: "libbar", |
| 1852 | stubs: { |
| 1853 | versions: ["29", "30"], |
| 1854 | }, |
| 1855 | } |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 1856 | `, |
| 1857 | prepareForTestWithSantitizeHwaddress, |
| 1858 | ) |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1859 | expectLink := func(from, from_variant, to, to_variant string) { |
| 1860 | ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld") |
| 1861 | libFlags := ld.Args["libFlags"] |
| 1862 | ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1863 | } |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1864 | expectLink("libx", "shared_hwasan_apex29", "libbar", "shared_current") |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1865 | } |
| 1866 | |
Jooyung Han | 7556839 | 2020-03-20 04:29:24 +0900 | [diff] [blame] | 1867 | func TestQTargetApexUsesStaticUnwinder(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1868 | ctx := testApex(t, ` |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1869 | apex { |
| 1870 | name: "myapex", |
| 1871 | key: "myapex.key", |
| 1872 | native_shared_libs: ["libx"], |
| 1873 | min_sdk_version: "29", |
| 1874 | } |
| 1875 | |
| 1876 | apex_key { |
| 1877 | name: "myapex.key", |
| 1878 | public_key: "testkey.avbpubkey", |
| 1879 | private_key: "testkey.pem", |
| 1880 | } |
| 1881 | |
| 1882 | cc_library { |
| 1883 | name: "libx", |
| 1884 | apex_available: [ "myapex" ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1885 | min_sdk_version: "29", |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1886 | } |
Jooyung Han | 7556839 | 2020-03-20 04:29:24 +0900 | [diff] [blame] | 1887 | `) |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1888 | |
| 1889 | // ensure apex variant of c++ is linked with static unwinder |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1890 | cm := ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared_apex29").Module().(*cc.Module) |
Ryan Prichard | b35a85e | 2021-01-13 19:18:53 -0800 | [diff] [blame] | 1891 | ensureListContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind") |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1892 | // note that platform variant is not. |
| 1893 | cm = ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared").Module().(*cc.Module) |
Ryan Prichard | b35a85e | 2021-01-13 19:18:53 -0800 | [diff] [blame] | 1894 | ensureListNotContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind") |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1895 | } |
| 1896 | |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1897 | func TestApexMinSdkVersion_ErrorIfIncompatibleVersion(t *testing.T) { |
| 1898 | testApexError(t, `module "mylib".*: should support min_sdk_version\(29\)`, ` |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1899 | apex { |
| 1900 | name: "myapex", |
| 1901 | key: "myapex.key", |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1902 | native_shared_libs: ["mylib"], |
| 1903 | min_sdk_version: "29", |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1904 | } |
| 1905 | |
| 1906 | apex_key { |
| 1907 | name: "myapex.key", |
| 1908 | public_key: "testkey.avbpubkey", |
| 1909 | private_key: "testkey.pem", |
| 1910 | } |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1911 | |
| 1912 | cc_library { |
| 1913 | name: "mylib", |
| 1914 | srcs: ["mylib.cpp"], |
| 1915 | system_shared_libs: [], |
| 1916 | stl: "none", |
| 1917 | apex_available: [ |
| 1918 | "myapex", |
| 1919 | ], |
| 1920 | min_sdk_version: "30", |
| 1921 | } |
| 1922 | `) |
Ivan Lozano | 3e9f9e4 | 2020-12-04 15:05:43 -0500 | [diff] [blame] | 1923 | |
| 1924 | testApexError(t, `module "libfoo.ffi".*: should support min_sdk_version\(29\)`, ` |
| 1925 | apex { |
| 1926 | name: "myapex", |
| 1927 | key: "myapex.key", |
| 1928 | native_shared_libs: ["libfoo.ffi"], |
| 1929 | min_sdk_version: "29", |
| 1930 | } |
| 1931 | |
| 1932 | apex_key { |
| 1933 | name: "myapex.key", |
| 1934 | public_key: "testkey.avbpubkey", |
| 1935 | private_key: "testkey.pem", |
| 1936 | } |
| 1937 | |
| 1938 | rust_ffi_shared { |
| 1939 | name: "libfoo.ffi", |
| 1940 | srcs: ["foo.rs"], |
| 1941 | crate_name: "foo", |
| 1942 | apex_available: [ |
| 1943 | "myapex", |
| 1944 | ], |
| 1945 | min_sdk_version: "30", |
| 1946 | } |
| 1947 | `) |
Jaewoong Jung | 56e12db | 2021-04-02 00:38:25 +0000 | [diff] [blame] | 1948 | |
| 1949 | testApexError(t, `module "libfoo".*: should support min_sdk_version\(29\)`, ` |
| 1950 | apex { |
| 1951 | name: "myapex", |
| 1952 | key: "myapex.key", |
| 1953 | java_libs: ["libfoo"], |
| 1954 | min_sdk_version: "29", |
| 1955 | } |
| 1956 | |
| 1957 | apex_key { |
| 1958 | name: "myapex.key", |
| 1959 | public_key: "testkey.avbpubkey", |
| 1960 | private_key: "testkey.pem", |
| 1961 | } |
| 1962 | |
| 1963 | java_import { |
| 1964 | name: "libfoo", |
| 1965 | jars: ["libfoo.jar"], |
| 1966 | apex_available: [ |
| 1967 | "myapex", |
| 1968 | ], |
| 1969 | min_sdk_version: "30", |
| 1970 | } |
| 1971 | `) |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1972 | } |
| 1973 | |
| 1974 | func TestApexMinSdkVersion_Okay(t *testing.T) { |
| 1975 | testApex(t, ` |
| 1976 | apex { |
| 1977 | name: "myapex", |
| 1978 | key: "myapex.key", |
| 1979 | native_shared_libs: ["libfoo"], |
| 1980 | java_libs: ["libbar"], |
| 1981 | min_sdk_version: "29", |
| 1982 | } |
| 1983 | |
| 1984 | apex_key { |
| 1985 | name: "myapex.key", |
| 1986 | public_key: "testkey.avbpubkey", |
| 1987 | private_key: "testkey.pem", |
| 1988 | } |
| 1989 | |
| 1990 | cc_library { |
| 1991 | name: "libfoo", |
| 1992 | srcs: ["mylib.cpp"], |
| 1993 | shared_libs: ["libfoo_dep"], |
| 1994 | apex_available: ["myapex"], |
| 1995 | min_sdk_version: "29", |
| 1996 | } |
| 1997 | |
| 1998 | cc_library { |
| 1999 | name: "libfoo_dep", |
| 2000 | srcs: ["mylib.cpp"], |
| 2001 | apex_available: ["myapex"], |
| 2002 | min_sdk_version: "29", |
| 2003 | } |
| 2004 | |
| 2005 | java_library { |
| 2006 | name: "libbar", |
| 2007 | sdk_version: "current", |
| 2008 | srcs: ["a.java"], |
Jaewoong Jung | 56e12db | 2021-04-02 00:38:25 +0000 | [diff] [blame] | 2009 | static_libs: [ |
| 2010 | "libbar_dep", |
| 2011 | "libbar_import_dep", |
| 2012 | ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 2013 | apex_available: ["myapex"], |
| 2014 | min_sdk_version: "29", |
| 2015 | } |
| 2016 | |
| 2017 | java_library { |
| 2018 | name: "libbar_dep", |
| 2019 | sdk_version: "current", |
| 2020 | srcs: ["a.java"], |
| 2021 | apex_available: ["myapex"], |
| 2022 | min_sdk_version: "29", |
| 2023 | } |
Jaewoong Jung | 56e12db | 2021-04-02 00:38:25 +0000 | [diff] [blame] | 2024 | |
| 2025 | java_import { |
| 2026 | name: "libbar_import_dep", |
| 2027 | jars: ["libbar.jar"], |
| 2028 | apex_available: ["myapex"], |
| 2029 | min_sdk_version: "29", |
| 2030 | } |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 2031 | `) |
| 2032 | } |
| 2033 | |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 2034 | func TestJavaStableSdkVersion(t *testing.T) { |
| 2035 | testCases := []struct { |
| 2036 | name string |
| 2037 | expectedError string |
| 2038 | bp string |
| 2039 | }{ |
| 2040 | { |
| 2041 | name: "Non-updatable apex with non-stable dep", |
| 2042 | bp: ` |
| 2043 | apex { |
| 2044 | name: "myapex", |
| 2045 | java_libs: ["myjar"], |
| 2046 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2047 | updatable: false, |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 2048 | } |
| 2049 | apex_key { |
| 2050 | name: "myapex.key", |
| 2051 | public_key: "testkey.avbpubkey", |
| 2052 | private_key: "testkey.pem", |
| 2053 | } |
| 2054 | java_library { |
| 2055 | name: "myjar", |
| 2056 | srcs: ["foo/bar/MyClass.java"], |
Paul Duffin | 043f5e7 | 2021-03-05 00:00:01 +0000 | [diff] [blame] | 2057 | sdk_version: "test_current", |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 2058 | apex_available: ["myapex"], |
| 2059 | } |
| 2060 | `, |
| 2061 | }, |
| 2062 | { |
| 2063 | name: "Updatable apex with stable dep", |
| 2064 | bp: ` |
| 2065 | apex { |
| 2066 | name: "myapex", |
| 2067 | java_libs: ["myjar"], |
| 2068 | key: "myapex.key", |
| 2069 | updatable: true, |
| 2070 | min_sdk_version: "29", |
| 2071 | } |
| 2072 | apex_key { |
| 2073 | name: "myapex.key", |
| 2074 | public_key: "testkey.avbpubkey", |
| 2075 | private_key: "testkey.pem", |
| 2076 | } |
| 2077 | java_library { |
| 2078 | name: "myjar", |
| 2079 | srcs: ["foo/bar/MyClass.java"], |
| 2080 | sdk_version: "current", |
| 2081 | apex_available: ["myapex"], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 2082 | min_sdk_version: "29", |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 2083 | } |
| 2084 | `, |
| 2085 | }, |
| 2086 | { |
| 2087 | name: "Updatable apex with non-stable dep", |
| 2088 | expectedError: "cannot depend on \"myjar\"", |
| 2089 | bp: ` |
| 2090 | apex { |
| 2091 | name: "myapex", |
| 2092 | java_libs: ["myjar"], |
| 2093 | key: "myapex.key", |
| 2094 | updatable: true, |
| 2095 | } |
| 2096 | apex_key { |
| 2097 | name: "myapex.key", |
| 2098 | public_key: "testkey.avbpubkey", |
| 2099 | private_key: "testkey.pem", |
| 2100 | } |
| 2101 | java_library { |
| 2102 | name: "myjar", |
| 2103 | srcs: ["foo/bar/MyClass.java"], |
Paul Duffin | 043f5e7 | 2021-03-05 00:00:01 +0000 | [diff] [blame] | 2104 | sdk_version: "test_current", |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 2105 | apex_available: ["myapex"], |
| 2106 | } |
| 2107 | `, |
| 2108 | }, |
| 2109 | { |
Paul Duffin | 043f5e7 | 2021-03-05 00:00:01 +0000 | [diff] [blame] | 2110 | name: "Updatable apex with non-stable transitive dep", |
| 2111 | // This is not actually detecting that the transitive dependency is unstable, rather it is |
| 2112 | // detecting that the transitive dependency is building against a wider API surface than the |
| 2113 | // module that depends on it is using. |
Jiyong Park | 670e0f6 | 2021-02-18 13:10:18 +0900 | [diff] [blame] | 2114 | expectedError: "compiles against Android API, but dependency \"transitive-jar\" is compiling against private API.", |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 2115 | bp: ` |
| 2116 | apex { |
| 2117 | name: "myapex", |
| 2118 | java_libs: ["myjar"], |
| 2119 | key: "myapex.key", |
| 2120 | updatable: true, |
| 2121 | } |
| 2122 | apex_key { |
| 2123 | name: "myapex.key", |
| 2124 | public_key: "testkey.avbpubkey", |
| 2125 | private_key: "testkey.pem", |
| 2126 | } |
| 2127 | java_library { |
| 2128 | name: "myjar", |
| 2129 | srcs: ["foo/bar/MyClass.java"], |
| 2130 | sdk_version: "current", |
| 2131 | apex_available: ["myapex"], |
| 2132 | static_libs: ["transitive-jar"], |
| 2133 | } |
| 2134 | java_library { |
| 2135 | name: "transitive-jar", |
| 2136 | srcs: ["foo/bar/MyClass.java"], |
| 2137 | sdk_version: "core_platform", |
| 2138 | apex_available: ["myapex"], |
| 2139 | } |
| 2140 | `, |
| 2141 | }, |
| 2142 | } |
| 2143 | |
| 2144 | for _, test := range testCases { |
| 2145 | t.Run(test.name, func(t *testing.T) { |
| 2146 | if test.expectedError == "" { |
| 2147 | testApex(t, test.bp) |
| 2148 | } else { |
| 2149 | testApexError(t, test.expectedError, test.bp) |
| 2150 | } |
| 2151 | }) |
| 2152 | } |
| 2153 | } |
| 2154 | |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 2155 | func TestApexMinSdkVersion_ErrorIfDepIsNewer(t *testing.T) { |
| 2156 | testApexError(t, `module "mylib2".*: should support min_sdk_version\(29\) for "myapex"`, ` |
| 2157 | apex { |
| 2158 | name: "myapex", |
| 2159 | key: "myapex.key", |
| 2160 | native_shared_libs: ["mylib"], |
| 2161 | min_sdk_version: "29", |
| 2162 | } |
| 2163 | |
| 2164 | apex_key { |
| 2165 | name: "myapex.key", |
| 2166 | public_key: "testkey.avbpubkey", |
| 2167 | private_key: "testkey.pem", |
| 2168 | } |
| 2169 | |
| 2170 | cc_library { |
| 2171 | name: "mylib", |
| 2172 | srcs: ["mylib.cpp"], |
| 2173 | shared_libs: ["mylib2"], |
| 2174 | system_shared_libs: [], |
| 2175 | stl: "none", |
| 2176 | apex_available: [ |
| 2177 | "myapex", |
| 2178 | ], |
| 2179 | min_sdk_version: "29", |
| 2180 | } |
| 2181 | |
| 2182 | // indirect part of the apex |
| 2183 | cc_library { |
| 2184 | name: "mylib2", |
| 2185 | srcs: ["mylib.cpp"], |
| 2186 | system_shared_libs: [], |
| 2187 | stl: "none", |
| 2188 | apex_available: [ |
| 2189 | "myapex", |
| 2190 | ], |
| 2191 | min_sdk_version: "30", |
| 2192 | } |
| 2193 | `) |
| 2194 | } |
| 2195 | |
| 2196 | func TestApexMinSdkVersion_ErrorIfDepIsNewer_Java(t *testing.T) { |
| 2197 | testApexError(t, `module "bar".*: should support min_sdk_version\(29\) for "myapex"`, ` |
| 2198 | apex { |
| 2199 | name: "myapex", |
| 2200 | key: "myapex.key", |
| 2201 | apps: ["AppFoo"], |
| 2202 | min_sdk_version: "29", |
| 2203 | } |
| 2204 | |
| 2205 | apex_key { |
| 2206 | name: "myapex.key", |
| 2207 | public_key: "testkey.avbpubkey", |
| 2208 | private_key: "testkey.pem", |
| 2209 | } |
| 2210 | |
| 2211 | android_app { |
| 2212 | name: "AppFoo", |
| 2213 | srcs: ["foo/bar/MyClass.java"], |
| 2214 | sdk_version: "current", |
| 2215 | min_sdk_version: "29", |
| 2216 | system_modules: "none", |
| 2217 | stl: "none", |
| 2218 | static_libs: ["bar"], |
| 2219 | apex_available: [ "myapex" ], |
| 2220 | } |
| 2221 | |
| 2222 | java_library { |
| 2223 | name: "bar", |
| 2224 | sdk_version: "current", |
| 2225 | srcs: ["a.java"], |
| 2226 | apex_available: [ "myapex" ], |
| 2227 | } |
| 2228 | `) |
| 2229 | } |
| 2230 | |
| 2231 | func TestApexMinSdkVersion_OkayEvenWhenDepIsNewer_IfItSatisfiesApexMinSdkVersion(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2232 | ctx := testApex(t, ` |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 2233 | apex { |
| 2234 | name: "myapex", |
| 2235 | key: "myapex.key", |
| 2236 | native_shared_libs: ["mylib"], |
| 2237 | min_sdk_version: "29", |
| 2238 | } |
| 2239 | |
| 2240 | apex_key { |
| 2241 | name: "myapex.key", |
| 2242 | public_key: "testkey.avbpubkey", |
| 2243 | private_key: "testkey.pem", |
| 2244 | } |
| 2245 | |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 2246 | // mylib in myapex will link to mylib2#current |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 2247 | // mylib in otherapex will link to mylib2(non-stub) in otherapex as well |
| 2248 | cc_library { |
| 2249 | name: "mylib", |
| 2250 | srcs: ["mylib.cpp"], |
| 2251 | shared_libs: ["mylib2"], |
| 2252 | system_shared_libs: [], |
| 2253 | stl: "none", |
| 2254 | apex_available: ["myapex", "otherapex"], |
| 2255 | min_sdk_version: "29", |
| 2256 | } |
| 2257 | |
| 2258 | cc_library { |
| 2259 | name: "mylib2", |
| 2260 | srcs: ["mylib.cpp"], |
| 2261 | system_shared_libs: [], |
| 2262 | stl: "none", |
| 2263 | apex_available: ["otherapex"], |
| 2264 | stubs: { versions: ["29", "30"] }, |
| 2265 | min_sdk_version: "30", |
| 2266 | } |
| 2267 | |
| 2268 | apex { |
| 2269 | name: "otherapex", |
| 2270 | key: "myapex.key", |
| 2271 | native_shared_libs: ["mylib", "mylib2"], |
| 2272 | min_sdk_version: "30", |
| 2273 | } |
| 2274 | `) |
| 2275 | expectLink := func(from, from_variant, to, to_variant string) { |
| 2276 | ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld") |
| 2277 | libFlags := ld.Args["libFlags"] |
| 2278 | ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 2279 | } |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 2280 | expectLink("mylib", "shared_apex29", "mylib2", "shared_current") |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 2281 | expectLink("mylib", "shared_apex30", "mylib2", "shared_apex30") |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 2282 | } |
| 2283 | |
Jooyung Han | ed124c3 | 2021-01-26 11:43:46 +0900 | [diff] [blame] | 2284 | func TestApexMinSdkVersion_WorksWithSdkCodename(t *testing.T) { |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 2285 | withSAsActiveCodeNames := android.FixtureModifyProductVariables( |
| 2286 | func(variables android.FixtureProductVariables) { |
| 2287 | variables.Platform_sdk_codename = proptools.StringPtr("S") |
| 2288 | variables.Platform_version_active_codenames = []string{"S"} |
| 2289 | }, |
| 2290 | ) |
Jooyung Han | ed124c3 | 2021-01-26 11:43:46 +0900 | [diff] [blame] | 2291 | testApexError(t, `libbar.*: should support min_sdk_version\(S\)`, ` |
| 2292 | apex { |
| 2293 | name: "myapex", |
| 2294 | key: "myapex.key", |
| 2295 | native_shared_libs: ["libfoo"], |
| 2296 | min_sdk_version: "S", |
| 2297 | } |
| 2298 | apex_key { |
| 2299 | name: "myapex.key", |
| 2300 | public_key: "testkey.avbpubkey", |
| 2301 | private_key: "testkey.pem", |
| 2302 | } |
| 2303 | cc_library { |
| 2304 | name: "libfoo", |
| 2305 | shared_libs: ["libbar"], |
| 2306 | apex_available: ["myapex"], |
| 2307 | min_sdk_version: "29", |
| 2308 | } |
| 2309 | cc_library { |
| 2310 | name: "libbar", |
| 2311 | apex_available: ["myapex"], |
| 2312 | } |
| 2313 | `, withSAsActiveCodeNames) |
| 2314 | } |
| 2315 | |
| 2316 | func TestApexMinSdkVersion_WorksWithActiveCodenames(t *testing.T) { |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 2317 | withSAsActiveCodeNames := android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 2318 | variables.Platform_sdk_codename = proptools.StringPtr("S") |
| 2319 | variables.Platform_version_active_codenames = []string{"S", "T"} |
| 2320 | }) |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2321 | ctx := testApex(t, ` |
Jooyung Han | ed124c3 | 2021-01-26 11:43:46 +0900 | [diff] [blame] | 2322 | apex { |
| 2323 | name: "myapex", |
| 2324 | key: "myapex.key", |
| 2325 | native_shared_libs: ["libfoo"], |
| 2326 | min_sdk_version: "S", |
| 2327 | } |
| 2328 | apex_key { |
| 2329 | name: "myapex.key", |
| 2330 | public_key: "testkey.avbpubkey", |
| 2331 | private_key: "testkey.pem", |
| 2332 | } |
| 2333 | cc_library { |
| 2334 | name: "libfoo", |
| 2335 | shared_libs: ["libbar"], |
| 2336 | apex_available: ["myapex"], |
| 2337 | min_sdk_version: "S", |
| 2338 | } |
| 2339 | cc_library { |
| 2340 | name: "libbar", |
| 2341 | stubs: { |
| 2342 | symbol_file: "libbar.map.txt", |
| 2343 | versions: ["30", "S", "T"], |
| 2344 | }, |
| 2345 | } |
| 2346 | `, withSAsActiveCodeNames) |
| 2347 | |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 2348 | // ensure libfoo is linked with current version of libbar stub |
Jooyung Han | ed124c3 | 2021-01-26 11:43:46 +0900 | [diff] [blame] | 2349 | libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_apex10000") |
| 2350 | libFlags := libfoo.Rule("ld").Args["libFlags"] |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 2351 | ensureContains(t, libFlags, "android_arm64_armv8-a_shared_current/libbar.so") |
Jooyung Han | ed124c3 | 2021-01-26 11:43:46 +0900 | [diff] [blame] | 2352 | } |
| 2353 | |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 2354 | func TestFilesInSubDir(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2355 | ctx := testApex(t, ` |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 2356 | apex { |
| 2357 | name: "myapex", |
| 2358 | key: "myapex.key", |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 2359 | native_shared_libs: ["mylib"], |
| 2360 | binaries: ["mybin"], |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 2361 | prebuilts: ["myetc"], |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 2362 | compile_multilib: "both", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2363 | updatable: false, |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 2364 | } |
| 2365 | |
| 2366 | apex_key { |
| 2367 | name: "myapex.key", |
| 2368 | public_key: "testkey.avbpubkey", |
| 2369 | private_key: "testkey.pem", |
| 2370 | } |
| 2371 | |
| 2372 | prebuilt_etc { |
| 2373 | name: "myetc", |
| 2374 | src: "myprebuilt", |
| 2375 | sub_dir: "foo/bar", |
| 2376 | } |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 2377 | |
| 2378 | cc_library { |
| 2379 | name: "mylib", |
| 2380 | srcs: ["mylib.cpp"], |
| 2381 | relative_install_path: "foo/bar", |
| 2382 | system_shared_libs: [], |
| 2383 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2384 | apex_available: [ "myapex" ], |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 2385 | } |
| 2386 | |
| 2387 | cc_binary { |
| 2388 | name: "mybin", |
| 2389 | srcs: ["mylib.cpp"], |
| 2390 | relative_install_path: "foo/bar", |
| 2391 | system_shared_libs: [], |
| 2392 | static_executable: true, |
| 2393 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2394 | apex_available: [ "myapex" ], |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 2395 | } |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 2396 | `) |
| 2397 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 2398 | generateFsRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("generateFsConfig") |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 2399 | dirs := strings.Split(generateFsRule.Args["exec_paths"], " ") |
| 2400 | |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 2401 | // Ensure that the subdirectories are all listed |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 2402 | ensureListContains(t, dirs, "etc") |
| 2403 | ensureListContains(t, dirs, "etc/foo") |
| 2404 | ensureListContains(t, dirs, "etc/foo/bar") |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 2405 | ensureListContains(t, dirs, "lib64") |
| 2406 | ensureListContains(t, dirs, "lib64/foo") |
| 2407 | ensureListContains(t, dirs, "lib64/foo/bar") |
| 2408 | ensureListContains(t, dirs, "lib") |
| 2409 | ensureListContains(t, dirs, "lib/foo") |
| 2410 | ensureListContains(t, dirs, "lib/foo/bar") |
| 2411 | |
Jiyong Park | bd13e44 | 2019-03-15 18:10:35 +0900 | [diff] [blame] | 2412 | ensureListContains(t, dirs, "bin") |
| 2413 | ensureListContains(t, dirs, "bin/foo") |
| 2414 | ensureListContains(t, dirs, "bin/foo/bar") |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 2415 | } |
Jiyong Park | da6eb59 | 2018-12-19 17:12:36 +0900 | [diff] [blame] | 2416 | |
Jooyung Han | 35155c4 | 2020-02-06 17:33:20 +0900 | [diff] [blame] | 2417 | func TestFilesInSubDirWhenNativeBridgeEnabled(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2418 | ctx := testApex(t, ` |
Jooyung Han | 35155c4 | 2020-02-06 17:33:20 +0900 | [diff] [blame] | 2419 | apex { |
| 2420 | name: "myapex", |
| 2421 | key: "myapex.key", |
| 2422 | multilib: { |
| 2423 | both: { |
| 2424 | native_shared_libs: ["mylib"], |
| 2425 | binaries: ["mybin"], |
| 2426 | }, |
| 2427 | }, |
| 2428 | compile_multilib: "both", |
| 2429 | native_bridge_supported: true, |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2430 | updatable: false, |
Jooyung Han | 35155c4 | 2020-02-06 17:33:20 +0900 | [diff] [blame] | 2431 | } |
| 2432 | |
| 2433 | apex_key { |
| 2434 | name: "myapex.key", |
| 2435 | public_key: "testkey.avbpubkey", |
| 2436 | private_key: "testkey.pem", |
| 2437 | } |
| 2438 | |
| 2439 | cc_library { |
| 2440 | name: "mylib", |
| 2441 | relative_install_path: "foo/bar", |
| 2442 | system_shared_libs: [], |
| 2443 | stl: "none", |
| 2444 | apex_available: [ "myapex" ], |
| 2445 | native_bridge_supported: true, |
| 2446 | } |
| 2447 | |
| 2448 | cc_binary { |
| 2449 | name: "mybin", |
| 2450 | relative_install_path: "foo/bar", |
| 2451 | system_shared_libs: [], |
| 2452 | static_executable: true, |
| 2453 | stl: "none", |
| 2454 | apex_available: [ "myapex" ], |
| 2455 | native_bridge_supported: true, |
| 2456 | compile_multilib: "both", // default is "first" for binary |
| 2457 | multilib: { |
| 2458 | lib64: { |
| 2459 | suffix: "64", |
| 2460 | }, |
| 2461 | }, |
| 2462 | } |
| 2463 | `, withNativeBridgeEnabled) |
| 2464 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 2465 | "bin/foo/bar/mybin", |
| 2466 | "bin/foo/bar/mybin64", |
| 2467 | "bin/arm/foo/bar/mybin", |
| 2468 | "bin/arm64/foo/bar/mybin64", |
| 2469 | "lib/foo/bar/mylib.so", |
| 2470 | "lib/arm/foo/bar/mylib.so", |
| 2471 | "lib64/foo/bar/mylib.so", |
| 2472 | "lib64/arm64/foo/bar/mylib.so", |
| 2473 | }) |
| 2474 | } |
| 2475 | |
Jooyung Han | 85d6176 | 2020-06-24 23:50:26 +0900 | [diff] [blame] | 2476 | func TestVendorApex(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2477 | ctx := testApex(t, ` |
Jooyung Han | 85d6176 | 2020-06-24 23:50:26 +0900 | [diff] [blame] | 2478 | apex { |
| 2479 | name: "myapex", |
| 2480 | key: "myapex.key", |
| 2481 | binaries: ["mybin"], |
| 2482 | vendor: true, |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2483 | updatable: false, |
Jooyung Han | 85d6176 | 2020-06-24 23:50:26 +0900 | [diff] [blame] | 2484 | } |
| 2485 | apex_key { |
| 2486 | name: "myapex.key", |
| 2487 | public_key: "testkey.avbpubkey", |
| 2488 | private_key: "testkey.pem", |
| 2489 | } |
| 2490 | cc_binary { |
| 2491 | name: "mybin", |
| 2492 | vendor: true, |
| 2493 | shared_libs: ["libfoo"], |
| 2494 | } |
| 2495 | cc_library { |
| 2496 | name: "libfoo", |
| 2497 | proprietary: true, |
| 2498 | } |
| 2499 | `) |
| 2500 | |
| 2501 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 2502 | "bin/mybin", |
| 2503 | "lib64/libfoo.so", |
| 2504 | // TODO(b/159195575): Add an option to use VNDK libs from VNDK APEX |
| 2505 | "lib64/libc++.so", |
| 2506 | }) |
| 2507 | |
| 2508 | apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 2509 | data := android.AndroidMkDataForTest(t, ctx, apexBundle) |
Jooyung Han | 85d6176 | 2020-06-24 23:50:26 +0900 | [diff] [blame] | 2510 | name := apexBundle.BaseModuleName() |
| 2511 | prefix := "TARGET_" |
| 2512 | var builder strings.Builder |
| 2513 | data.Custom(&builder, name, prefix, "", data) |
Paul Duffin | 37ba344 | 2021-03-29 00:21:08 +0100 | [diff] [blame] | 2514 | androidMk := android.StringRelativeToTop(ctx.Config(), builder.String()) |
| 2515 | installPath := "out/target/product/test_device/vendor/apex" |
Lukacs T. Berki | 7690c09 | 2021-02-26 14:27:36 +0100 | [diff] [blame] | 2516 | ensureContains(t, androidMk, "LOCAL_MODULE_PATH := "+installPath) |
Jooyung Han | 6c4cc9c | 2020-07-29 16:00:54 +0900 | [diff] [blame] | 2517 | |
| 2518 | apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule") |
| 2519 | requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"]) |
| 2520 | ensureListNotContains(t, requireNativeLibs, ":vndk") |
Jooyung Han | 85d6176 | 2020-06-24 23:50:26 +0900 | [diff] [blame] | 2521 | } |
| 2522 | |
Jooyung Han | df78e21 | 2020-07-22 15:54:47 +0900 | [diff] [blame] | 2523 | func TestVendorApex_use_vndk_as_stable(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2524 | ctx := testApex(t, ` |
Jooyung Han | df78e21 | 2020-07-22 15:54:47 +0900 | [diff] [blame] | 2525 | apex { |
| 2526 | name: "myapex", |
| 2527 | key: "myapex.key", |
| 2528 | binaries: ["mybin"], |
| 2529 | vendor: true, |
| 2530 | use_vndk_as_stable: true, |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2531 | updatable: false, |
Jooyung Han | df78e21 | 2020-07-22 15:54:47 +0900 | [diff] [blame] | 2532 | } |
| 2533 | apex_key { |
| 2534 | name: "myapex.key", |
| 2535 | public_key: "testkey.avbpubkey", |
| 2536 | private_key: "testkey.pem", |
| 2537 | } |
| 2538 | cc_binary { |
| 2539 | name: "mybin", |
| 2540 | vendor: true, |
| 2541 | shared_libs: ["libvndk", "libvendor"], |
| 2542 | } |
| 2543 | cc_library { |
| 2544 | name: "libvndk", |
| 2545 | vndk: { |
| 2546 | enabled: true, |
| 2547 | }, |
| 2548 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 2549 | product_available: true, |
Jooyung Han | df78e21 | 2020-07-22 15:54:47 +0900 | [diff] [blame] | 2550 | } |
| 2551 | cc_library { |
| 2552 | name: "libvendor", |
| 2553 | vendor: true, |
| 2554 | } |
| 2555 | `) |
| 2556 | |
Jiyong Park | f58c46e | 2021-04-01 21:35:20 +0900 | [diff] [blame] | 2557 | vendorVariant := "android_vendor.29_arm64_armv8-a" |
Jooyung Han | df78e21 | 2020-07-22 15:54:47 +0900 | [diff] [blame] | 2558 | |
Paul Duffin | a71a67a | 2021-03-29 00:42:57 +0100 | [diff] [blame] | 2559 | ldRule := ctx.ModuleForTests("mybin", vendorVariant+"_apex10000").Rule("ld") |
Jooyung Han | df78e21 | 2020-07-22 15:54:47 +0900 | [diff] [blame] | 2560 | libs := names(ldRule.Args["libFlags"]) |
| 2561 | // VNDK libs(libvndk/libc++) as they are |
Paul Duffin | 37ba344 | 2021-03-29 00:21:08 +0100 | [diff] [blame] | 2562 | ensureListContains(t, libs, "out/soong/.intermediates/libvndk/"+vendorVariant+"_shared/libvndk.so") |
| 2563 | ensureListContains(t, libs, "out/soong/.intermediates/"+cc.DefaultCcCommonTestModulesDir+"libc++/"+vendorVariant+"_shared/libc++.so") |
Jooyung Han | df78e21 | 2020-07-22 15:54:47 +0900 | [diff] [blame] | 2564 | // non-stable Vendor libs as APEX variants |
Paul Duffin | 37ba344 | 2021-03-29 00:21:08 +0100 | [diff] [blame] | 2565 | ensureListContains(t, libs, "out/soong/.intermediates/libvendor/"+vendorVariant+"_shared_apex10000/libvendor.so") |
Jooyung Han | df78e21 | 2020-07-22 15:54:47 +0900 | [diff] [blame] | 2566 | |
| 2567 | // VNDK libs are not included when use_vndk_as_stable: true |
| 2568 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 2569 | "bin/mybin", |
| 2570 | "lib64/libvendor.so", |
| 2571 | }) |
Jooyung Han | 6c4cc9c | 2020-07-29 16:00:54 +0900 | [diff] [blame] | 2572 | |
| 2573 | apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule") |
| 2574 | requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"]) |
| 2575 | ensureListContains(t, requireNativeLibs, ":vndk") |
Jooyung Han | df78e21 | 2020-07-22 15:54:47 +0900 | [diff] [blame] | 2576 | } |
| 2577 | |
Justin Yun | 13decfb | 2021-03-08 19:25:55 +0900 | [diff] [blame] | 2578 | func TestProductVariant(t *testing.T) { |
| 2579 | ctx := testApex(t, ` |
| 2580 | apex { |
| 2581 | name: "myapex", |
| 2582 | key: "myapex.key", |
| 2583 | updatable: false, |
| 2584 | product_specific: true, |
| 2585 | binaries: ["foo"], |
| 2586 | } |
| 2587 | |
| 2588 | apex_key { |
| 2589 | name: "myapex.key", |
| 2590 | public_key: "testkey.avbpubkey", |
| 2591 | private_key: "testkey.pem", |
| 2592 | } |
| 2593 | |
| 2594 | cc_binary { |
| 2595 | name: "foo", |
| 2596 | product_available: true, |
| 2597 | apex_available: ["myapex"], |
| 2598 | srcs: ["foo.cpp"], |
| 2599 | } |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 2600 | `, android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 2601 | variables.ProductVndkVersion = proptools.StringPtr("current") |
| 2602 | }), |
| 2603 | ) |
Justin Yun | 13decfb | 2021-03-08 19:25:55 +0900 | [diff] [blame] | 2604 | |
| 2605 | cflags := strings.Fields( |
Jiyong Park | f58c46e | 2021-04-01 21:35:20 +0900 | [diff] [blame] | 2606 | ctx.ModuleForTests("foo", "android_product.29_arm64_armv8-a_apex10000").Rule("cc").Args["cFlags"]) |
Justin Yun | 13decfb | 2021-03-08 19:25:55 +0900 | [diff] [blame] | 2607 | ensureListContains(t, cflags, "-D__ANDROID_VNDK__") |
| 2608 | ensureListContains(t, cflags, "-D__ANDROID_APEX__") |
| 2609 | ensureListContains(t, cflags, "-D__ANDROID_PRODUCT__") |
| 2610 | ensureListNotContains(t, cflags, "-D__ANDROID_VENDOR__") |
| 2611 | } |
| 2612 | |
Jooyung Han | 8e5685d | 2020-09-21 11:02:57 +0900 | [diff] [blame] | 2613 | func TestApex_withPrebuiltFirmware(t *testing.T) { |
| 2614 | testCases := []struct { |
| 2615 | name string |
| 2616 | additionalProp string |
| 2617 | }{ |
| 2618 | {"system apex with prebuilt_firmware", ""}, |
| 2619 | {"vendor apex with prebuilt_firmware", "vendor: true,"}, |
| 2620 | } |
| 2621 | for _, tc := range testCases { |
| 2622 | t.Run(tc.name, func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2623 | ctx := testApex(t, ` |
Jooyung Han | 8e5685d | 2020-09-21 11:02:57 +0900 | [diff] [blame] | 2624 | apex { |
| 2625 | name: "myapex", |
| 2626 | key: "myapex.key", |
| 2627 | prebuilts: ["myfirmware"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2628 | updatable: false, |
Jooyung Han | 8e5685d | 2020-09-21 11:02:57 +0900 | [diff] [blame] | 2629 | `+tc.additionalProp+` |
| 2630 | } |
| 2631 | apex_key { |
| 2632 | name: "myapex.key", |
| 2633 | public_key: "testkey.avbpubkey", |
| 2634 | private_key: "testkey.pem", |
| 2635 | } |
| 2636 | prebuilt_firmware { |
| 2637 | name: "myfirmware", |
| 2638 | src: "myfirmware.bin", |
| 2639 | filename_from_src: true, |
| 2640 | `+tc.additionalProp+` |
| 2641 | } |
| 2642 | `) |
| 2643 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 2644 | "etc/firmware/myfirmware.bin", |
| 2645 | }) |
| 2646 | }) |
| 2647 | } |
Jooyung Han | 0703fd8 | 2020-08-26 22:11:53 +0900 | [diff] [blame] | 2648 | } |
| 2649 | |
Jooyung Han | efb184e | 2020-06-25 17:14:25 +0900 | [diff] [blame] | 2650 | func TestAndroidMk_VendorApexRequired(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2651 | ctx := testApex(t, ` |
Jooyung Han | efb184e | 2020-06-25 17:14:25 +0900 | [diff] [blame] | 2652 | apex { |
| 2653 | name: "myapex", |
| 2654 | key: "myapex.key", |
| 2655 | vendor: true, |
| 2656 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2657 | updatable: false, |
Jooyung Han | efb184e | 2020-06-25 17:14:25 +0900 | [diff] [blame] | 2658 | } |
| 2659 | |
| 2660 | apex_key { |
| 2661 | name: "myapex.key", |
| 2662 | public_key: "testkey.avbpubkey", |
| 2663 | private_key: "testkey.pem", |
| 2664 | } |
| 2665 | |
| 2666 | cc_library { |
| 2667 | name: "mylib", |
| 2668 | vendor_available: true, |
| 2669 | } |
| 2670 | `) |
| 2671 | |
| 2672 | apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 2673 | data := android.AndroidMkDataForTest(t, ctx, apexBundle) |
Jooyung Han | efb184e | 2020-06-25 17:14:25 +0900 | [diff] [blame] | 2674 | name := apexBundle.BaseModuleName() |
| 2675 | prefix := "TARGET_" |
| 2676 | var builder strings.Builder |
| 2677 | data.Custom(&builder, name, prefix, "", data) |
| 2678 | androidMk := builder.String() |
| 2679 | ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += libc.vendor libm.vendor libdl.vendor\n") |
| 2680 | } |
| 2681 | |
Jooyung Han | 2ed99d0 | 2020-06-24 23:26:26 +0900 | [diff] [blame] | 2682 | func TestAndroidMkWritesCommonProperties(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2683 | ctx := testApex(t, ` |
Jooyung Han | 2ed99d0 | 2020-06-24 23:26:26 +0900 | [diff] [blame] | 2684 | apex { |
| 2685 | name: "myapex", |
| 2686 | key: "myapex.key", |
| 2687 | vintf_fragments: ["fragment.xml"], |
| 2688 | init_rc: ["init.rc"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2689 | updatable: false, |
Jooyung Han | 2ed99d0 | 2020-06-24 23:26:26 +0900 | [diff] [blame] | 2690 | } |
| 2691 | apex_key { |
| 2692 | name: "myapex.key", |
| 2693 | public_key: "testkey.avbpubkey", |
| 2694 | private_key: "testkey.pem", |
| 2695 | } |
| 2696 | cc_binary { |
| 2697 | name: "mybin", |
| 2698 | } |
| 2699 | `) |
| 2700 | |
| 2701 | apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 2702 | data := android.AndroidMkDataForTest(t, ctx, apexBundle) |
Jooyung Han | 2ed99d0 | 2020-06-24 23:26:26 +0900 | [diff] [blame] | 2703 | name := apexBundle.BaseModuleName() |
| 2704 | prefix := "TARGET_" |
| 2705 | var builder strings.Builder |
| 2706 | data.Custom(&builder, name, prefix, "", data) |
| 2707 | androidMk := builder.String() |
Liz Kammer | 7b3dc8a | 2021-04-16 16:41:59 -0400 | [diff] [blame] | 2708 | ensureContains(t, androidMk, "LOCAL_FULL_VINTF_FRAGMENTS := fragment.xml\n") |
Liz Kammer | 0c4f71c | 2021-04-06 10:35:10 -0400 | [diff] [blame] | 2709 | ensureContains(t, androidMk, "LOCAL_FULL_INIT_RC := init.rc\n") |
Jooyung Han | 2ed99d0 | 2020-06-24 23:26:26 +0900 | [diff] [blame] | 2710 | } |
| 2711 | |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 2712 | func TestStaticLinking(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2713 | ctx := testApex(t, ` |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 2714 | apex { |
| 2715 | name: "myapex", |
| 2716 | key: "myapex.key", |
| 2717 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2718 | updatable: false, |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 2719 | } |
| 2720 | |
| 2721 | apex_key { |
| 2722 | name: "myapex.key", |
| 2723 | public_key: "testkey.avbpubkey", |
| 2724 | private_key: "testkey.pem", |
| 2725 | } |
| 2726 | |
| 2727 | cc_library { |
| 2728 | name: "mylib", |
| 2729 | srcs: ["mylib.cpp"], |
| 2730 | system_shared_libs: [], |
| 2731 | stl: "none", |
| 2732 | stubs: { |
| 2733 | versions: ["1", "2", "3"], |
| 2734 | }, |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2735 | apex_available: [ |
| 2736 | "//apex_available:platform", |
| 2737 | "myapex", |
| 2738 | ], |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 2739 | } |
| 2740 | |
| 2741 | cc_binary { |
| 2742 | name: "not_in_apex", |
| 2743 | srcs: ["mylib.cpp"], |
| 2744 | static_libs: ["mylib"], |
| 2745 | static_executable: true, |
| 2746 | system_shared_libs: [], |
| 2747 | stl: "none", |
| 2748 | } |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 2749 | `) |
| 2750 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 2751 | ldFlags := ctx.ModuleForTests("not_in_apex", "android_arm64_armv8-a").Rule("ld").Args["libFlags"] |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 2752 | |
| 2753 | // Ensure that not_in_apex is linking with the static variant of mylib |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 2754 | ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_static/mylib.a") |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 2755 | } |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2756 | |
| 2757 | func TestKeys(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2758 | ctx := testApex(t, ` |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2759 | apex { |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 2760 | name: "myapex_keytest", |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2761 | key: "myapex.key", |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 2762 | certificate: ":myapex.certificate", |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2763 | native_shared_libs: ["mylib"], |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 2764 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2765 | updatable: false, |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2766 | } |
| 2767 | |
| 2768 | cc_library { |
| 2769 | name: "mylib", |
| 2770 | srcs: ["mylib.cpp"], |
| 2771 | system_shared_libs: [], |
| 2772 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2773 | apex_available: [ "myapex_keytest" ], |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2774 | } |
| 2775 | |
| 2776 | apex_key { |
| 2777 | name: "myapex.key", |
| 2778 | public_key: "testkey.avbpubkey", |
| 2779 | private_key: "testkey.pem", |
| 2780 | } |
| 2781 | |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 2782 | android_app_certificate { |
| 2783 | name: "myapex.certificate", |
| 2784 | certificate: "testkey", |
| 2785 | } |
| 2786 | |
| 2787 | android_app_certificate { |
| 2788 | name: "myapex.certificate.override", |
| 2789 | certificate: "testkey.override", |
| 2790 | } |
| 2791 | |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2792 | `) |
| 2793 | |
| 2794 | // check the APEX keys |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 2795 | keys := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey) |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2796 | |
Jaewoong Jung | 18aefc1 | 2020-12-21 09:11:10 -0800 | [diff] [blame] | 2797 | if keys.publicKeyFile.String() != "vendor/foo/devkeys/testkey.avbpubkey" { |
| 2798 | t.Errorf("public key %q is not %q", keys.publicKeyFile.String(), |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2799 | "vendor/foo/devkeys/testkey.avbpubkey") |
| 2800 | } |
Jaewoong Jung | 18aefc1 | 2020-12-21 09:11:10 -0800 | [diff] [blame] | 2801 | if keys.privateKeyFile.String() != "vendor/foo/devkeys/testkey.pem" { |
| 2802 | t.Errorf("private key %q is not %q", keys.privateKeyFile.String(), |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2803 | "vendor/foo/devkeys/testkey.pem") |
| 2804 | } |
| 2805 | |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 2806 | // check the APK certs. It should be overridden to myapex.certificate.override |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 2807 | certs := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk").Args["certificates"] |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 2808 | if certs != "testkey.override.x509.pem testkey.override.pk8" { |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2809 | t.Errorf("cert and private key %q are not %q", certs, |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 2810 | "testkey.override.509.pem testkey.override.pk8") |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2811 | } |
| 2812 | } |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 2813 | |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 2814 | func TestCertificate(t *testing.T) { |
| 2815 | t.Run("if unspecified, it defaults to DefaultAppCertificate", func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2816 | ctx := testApex(t, ` |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 2817 | apex { |
| 2818 | name: "myapex", |
| 2819 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2820 | updatable: false, |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 2821 | } |
| 2822 | apex_key { |
| 2823 | name: "myapex.key", |
| 2824 | public_key: "testkey.avbpubkey", |
| 2825 | private_key: "testkey.pem", |
| 2826 | }`) |
| 2827 | rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk") |
| 2828 | expected := "vendor/foo/devkeys/test.x509.pem vendor/foo/devkeys/test.pk8" |
| 2829 | if actual := rule.Args["certificates"]; actual != expected { |
| 2830 | t.Errorf("certificates should be %q, not %q", expected, actual) |
| 2831 | } |
| 2832 | }) |
| 2833 | t.Run("override when unspecified", func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2834 | ctx := testApex(t, ` |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 2835 | apex { |
| 2836 | name: "myapex_keytest", |
| 2837 | key: "myapex.key", |
| 2838 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2839 | updatable: false, |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 2840 | } |
| 2841 | apex_key { |
| 2842 | name: "myapex.key", |
| 2843 | public_key: "testkey.avbpubkey", |
| 2844 | private_key: "testkey.pem", |
| 2845 | } |
| 2846 | android_app_certificate { |
| 2847 | name: "myapex.certificate.override", |
| 2848 | certificate: "testkey.override", |
| 2849 | }`) |
| 2850 | rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk") |
| 2851 | expected := "testkey.override.x509.pem testkey.override.pk8" |
| 2852 | if actual := rule.Args["certificates"]; actual != expected { |
| 2853 | t.Errorf("certificates should be %q, not %q", expected, actual) |
| 2854 | } |
| 2855 | }) |
| 2856 | t.Run("if specified as :module, it respects the prop", func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2857 | ctx := testApex(t, ` |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 2858 | apex { |
| 2859 | name: "myapex", |
| 2860 | key: "myapex.key", |
| 2861 | certificate: ":myapex.certificate", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2862 | updatable: false, |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 2863 | } |
| 2864 | apex_key { |
| 2865 | name: "myapex.key", |
| 2866 | public_key: "testkey.avbpubkey", |
| 2867 | private_key: "testkey.pem", |
| 2868 | } |
| 2869 | android_app_certificate { |
| 2870 | name: "myapex.certificate", |
| 2871 | certificate: "testkey", |
| 2872 | }`) |
| 2873 | rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk") |
| 2874 | expected := "testkey.x509.pem testkey.pk8" |
| 2875 | if actual := rule.Args["certificates"]; actual != expected { |
| 2876 | t.Errorf("certificates should be %q, not %q", expected, actual) |
| 2877 | } |
| 2878 | }) |
| 2879 | t.Run("override when specifiec as <:module>", func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2880 | ctx := testApex(t, ` |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 2881 | apex { |
| 2882 | name: "myapex_keytest", |
| 2883 | key: "myapex.key", |
| 2884 | file_contexts: ":myapex-file_contexts", |
| 2885 | certificate: ":myapex.certificate", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2886 | updatable: false, |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 2887 | } |
| 2888 | apex_key { |
| 2889 | name: "myapex.key", |
| 2890 | public_key: "testkey.avbpubkey", |
| 2891 | private_key: "testkey.pem", |
| 2892 | } |
| 2893 | android_app_certificate { |
| 2894 | name: "myapex.certificate.override", |
| 2895 | certificate: "testkey.override", |
| 2896 | }`) |
| 2897 | rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk") |
| 2898 | expected := "testkey.override.x509.pem testkey.override.pk8" |
| 2899 | if actual := rule.Args["certificates"]; actual != expected { |
| 2900 | t.Errorf("certificates should be %q, not %q", expected, actual) |
| 2901 | } |
| 2902 | }) |
| 2903 | t.Run("if specified as name, finds it from DefaultDevKeyDir", func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2904 | ctx := testApex(t, ` |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 2905 | apex { |
| 2906 | name: "myapex", |
| 2907 | key: "myapex.key", |
| 2908 | certificate: "testkey", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2909 | updatable: false, |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 2910 | } |
| 2911 | apex_key { |
| 2912 | name: "myapex.key", |
| 2913 | public_key: "testkey.avbpubkey", |
| 2914 | private_key: "testkey.pem", |
| 2915 | }`) |
| 2916 | rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk") |
| 2917 | expected := "vendor/foo/devkeys/testkey.x509.pem vendor/foo/devkeys/testkey.pk8" |
| 2918 | if actual := rule.Args["certificates"]; actual != expected { |
| 2919 | t.Errorf("certificates should be %q, not %q", expected, actual) |
| 2920 | } |
| 2921 | }) |
| 2922 | t.Run("override when specified as <name>", func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2923 | ctx := testApex(t, ` |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 2924 | apex { |
| 2925 | name: "myapex_keytest", |
| 2926 | key: "myapex.key", |
| 2927 | file_contexts: ":myapex-file_contexts", |
| 2928 | certificate: "testkey", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2929 | updatable: false, |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 2930 | } |
| 2931 | apex_key { |
| 2932 | name: "myapex.key", |
| 2933 | public_key: "testkey.avbpubkey", |
| 2934 | private_key: "testkey.pem", |
| 2935 | } |
| 2936 | android_app_certificate { |
| 2937 | name: "myapex.certificate.override", |
| 2938 | certificate: "testkey.override", |
| 2939 | }`) |
| 2940 | rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk") |
| 2941 | expected := "testkey.override.x509.pem testkey.override.pk8" |
| 2942 | if actual := rule.Args["certificates"]; actual != expected { |
| 2943 | t.Errorf("certificates should be %q, not %q", expected, actual) |
| 2944 | } |
| 2945 | }) |
| 2946 | } |
| 2947 | |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 2948 | func TestMacro(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2949 | ctx := testApex(t, ` |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 2950 | apex { |
| 2951 | name: "myapex", |
| 2952 | key: "myapex.key", |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 2953 | native_shared_libs: ["mylib", "mylib2"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2954 | updatable: false, |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 2955 | } |
| 2956 | |
| 2957 | apex { |
| 2958 | name: "otherapex", |
| 2959 | key: "myapex.key", |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 2960 | native_shared_libs: ["mylib", "mylib2"], |
Jooyung Han | ccce2f2 | 2020-03-07 03:45:53 +0900 | [diff] [blame] | 2961 | min_sdk_version: "29", |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 2962 | } |
| 2963 | |
| 2964 | apex_key { |
| 2965 | name: "myapex.key", |
| 2966 | public_key: "testkey.avbpubkey", |
| 2967 | private_key: "testkey.pem", |
| 2968 | } |
| 2969 | |
| 2970 | cc_library { |
| 2971 | name: "mylib", |
| 2972 | srcs: ["mylib.cpp"], |
| 2973 | system_shared_libs: [], |
| 2974 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2975 | apex_available: [ |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2976 | "myapex", |
| 2977 | "otherapex", |
| 2978 | ], |
Jooyung Han | 2428277 | 2020-03-21 23:20:55 +0900 | [diff] [blame] | 2979 | recovery_available: true, |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 2980 | min_sdk_version: "29", |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 2981 | } |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 2982 | cc_library { |
| 2983 | name: "mylib2", |
| 2984 | srcs: ["mylib.cpp"], |
| 2985 | system_shared_libs: [], |
| 2986 | stl: "none", |
| 2987 | apex_available: [ |
| 2988 | "myapex", |
| 2989 | "otherapex", |
| 2990 | ], |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 2991 | static_libs: ["mylib3"], |
| 2992 | recovery_available: true, |
| 2993 | min_sdk_version: "29", |
| 2994 | } |
| 2995 | cc_library { |
| 2996 | name: "mylib3", |
| 2997 | srcs: ["mylib.cpp"], |
| 2998 | system_shared_libs: [], |
| 2999 | stl: "none", |
| 3000 | apex_available: [ |
| 3001 | "myapex", |
| 3002 | "otherapex", |
| 3003 | ], |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 3004 | use_apex_name_macro: true, |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 3005 | recovery_available: true, |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 3006 | min_sdk_version: "29", |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 3007 | } |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 3008 | `) |
| 3009 | |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 3010 | // non-APEX variant does not have __ANDROID_APEX__ defined |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 3011 | mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
Jooyung Han | 6b8459b | 2019-10-30 08:29:25 +0900 | [diff] [blame] | 3012 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
Dan Albert | b19953d | 2020-11-17 15:29:36 -0800 | [diff] [blame] | 3013 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__") |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 3014 | |
Jooyung Han | ccce2f2 | 2020-03-07 03:45:53 +0900 | [diff] [blame] | 3015 | // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 3016 | mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"] |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 3017 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
Dan Albert | b19953d | 2020-11-17 15:29:36 -0800 | [diff] [blame] | 3018 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=10000") |
Jooyung Han | 7798857 | 2019-10-18 16:26:16 +0900 | [diff] [blame] | 3019 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__") |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 3020 | |
Jooyung Han | ccce2f2 | 2020-03-07 03:45:53 +0900 | [diff] [blame] | 3021 | // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 3022 | mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex29").Rule("cc").Args["cFlags"] |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 3023 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
Dan Albert | b19953d | 2020-11-17 15:29:36 -0800 | [diff] [blame] | 3024 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=29") |
Jooyung Han | 7798857 | 2019-10-18 16:26:16 +0900 | [diff] [blame] | 3025 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__") |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 3026 | |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 3027 | // When a cc_library sets use_apex_name_macro: true each apex gets a unique variant and |
| 3028 | // each variant defines additional macros to distinguish which apex variant it is built for |
| 3029 | |
| 3030 | // non-APEX variant does not have __ANDROID_APEX__ defined |
| 3031 | mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
| 3032 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
| 3033 | |
| 3034 | // APEX variant has __ANDROID_APEX__ defined |
| 3035 | mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"] |
| 3036 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
| 3037 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__") |
| 3038 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__") |
| 3039 | |
| 3040 | // APEX variant has __ANDROID_APEX__ defined |
| 3041 | mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static_otherapex").Rule("cc").Args["cFlags"] |
| 3042 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
| 3043 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__") |
| 3044 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__") |
| 3045 | |
Dan Albert | b19953d | 2020-11-17 15:29:36 -0800 | [diff] [blame] | 3046 | // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__ |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 3047 | mylibCFlags = ctx.ModuleForTests("mylib3", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
| 3048 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
Dan Albert | b19953d | 2020-11-17 15:29:36 -0800 | [diff] [blame] | 3049 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__") |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 3050 | |
| 3051 | // When a dependency of a cc_library sets use_apex_name_macro: true each apex gets a unique |
| 3052 | // variant. |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 3053 | |
| 3054 | // non-APEX variant does not have __ANDROID_APEX__ defined |
| 3055 | mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
| 3056 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
| 3057 | |
| 3058 | // APEX variant has __ANDROID_APEX__ defined |
| 3059 | mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"] |
Jooyung Han | 6b8459b | 2019-10-30 08:29:25 +0900 | [diff] [blame] | 3060 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 3061 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__") |
Jooyung Han | 7798857 | 2019-10-18 16:26:16 +0900 | [diff] [blame] | 3062 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__") |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 3063 | |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 3064 | // APEX variant has __ANDROID_APEX__ defined |
| 3065 | mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_otherapex").Rule("cc").Args["cFlags"] |
Jooyung Han | 6b8459b | 2019-10-30 08:29:25 +0900 | [diff] [blame] | 3066 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
Jooyung Han | 7798857 | 2019-10-18 16:26:16 +0900 | [diff] [blame] | 3067 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__") |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 3068 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__") |
Jooyung Han | 2428277 | 2020-03-21 23:20:55 +0900 | [diff] [blame] | 3069 | |
Dan Albert | b19953d | 2020-11-17 15:29:36 -0800 | [diff] [blame] | 3070 | // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__ |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 3071 | mylibCFlags = ctx.ModuleForTests("mylib2", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
Jooyung Han | 2428277 | 2020-03-21 23:20:55 +0900 | [diff] [blame] | 3072 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
Dan Albert | b19953d | 2020-11-17 15:29:36 -0800 | [diff] [blame] | 3073 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__") |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 3074 | } |
Jiyong Park | 7e636d0 | 2019-01-28 16:16:54 +0900 | [diff] [blame] | 3075 | |
| 3076 | func TestHeaderLibsDependency(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3077 | ctx := testApex(t, ` |
Jiyong Park | 7e636d0 | 2019-01-28 16:16:54 +0900 | [diff] [blame] | 3078 | apex { |
| 3079 | name: "myapex", |
| 3080 | key: "myapex.key", |
| 3081 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3082 | updatable: false, |
Jiyong Park | 7e636d0 | 2019-01-28 16:16:54 +0900 | [diff] [blame] | 3083 | } |
| 3084 | |
| 3085 | apex_key { |
| 3086 | name: "myapex.key", |
| 3087 | public_key: "testkey.avbpubkey", |
| 3088 | private_key: "testkey.pem", |
| 3089 | } |
| 3090 | |
| 3091 | cc_library_headers { |
| 3092 | name: "mylib_headers", |
| 3093 | export_include_dirs: ["my_include"], |
| 3094 | system_shared_libs: [], |
| 3095 | stl: "none", |
Jiyong Park | 0f80c18 | 2020-01-31 02:49:53 +0900 | [diff] [blame] | 3096 | apex_available: [ "myapex" ], |
Jiyong Park | 7e636d0 | 2019-01-28 16:16:54 +0900 | [diff] [blame] | 3097 | } |
| 3098 | |
| 3099 | cc_library { |
| 3100 | name: "mylib", |
| 3101 | srcs: ["mylib.cpp"], |
| 3102 | system_shared_libs: [], |
| 3103 | stl: "none", |
| 3104 | header_libs: ["mylib_headers"], |
| 3105 | export_header_lib_headers: ["mylib_headers"], |
| 3106 | stubs: { |
| 3107 | versions: ["1", "2", "3"], |
| 3108 | }, |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3109 | apex_available: [ "myapex" ], |
Jiyong Park | 7e636d0 | 2019-01-28 16:16:54 +0900 | [diff] [blame] | 3110 | } |
| 3111 | |
| 3112 | cc_library { |
| 3113 | name: "otherlib", |
| 3114 | srcs: ["mylib.cpp"], |
| 3115 | system_shared_libs: [], |
| 3116 | stl: "none", |
| 3117 | shared_libs: ["mylib"], |
| 3118 | } |
| 3119 | `) |
| 3120 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 3121 | cFlags := ctx.ModuleForTests("otherlib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
Jiyong Park | 7e636d0 | 2019-01-28 16:16:54 +0900 | [diff] [blame] | 3122 | |
| 3123 | // Ensure that the include path of the header lib is exported to 'otherlib' |
| 3124 | ensureContains(t, cFlags, "-Imy_include") |
| 3125 | } |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 3126 | |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3127 | type fileInApex struct { |
| 3128 | path string // path in apex |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3129 | src string // src path |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3130 | isLink bool |
| 3131 | } |
| 3132 | |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3133 | func getFiles(t *testing.T, ctx *android.TestContext, moduleName, variant string) []fileInApex { |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3134 | t.Helper() |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3135 | apexRule := ctx.ModuleForTests(moduleName, variant).Rule("apexRule") |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3136 | copyCmds := apexRule.Args["copy_commands"] |
| 3137 | imageApexDir := "/image.apex/" |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3138 | var ret []fileInApex |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3139 | for _, cmd := range strings.Split(copyCmds, "&&") { |
| 3140 | cmd = strings.TrimSpace(cmd) |
| 3141 | if cmd == "" { |
| 3142 | continue |
| 3143 | } |
| 3144 | terms := strings.Split(cmd, " ") |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3145 | var dst, src string |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3146 | var isLink bool |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3147 | switch terms[0] { |
| 3148 | case "mkdir": |
| 3149 | case "cp": |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3150 | if len(terms) != 3 && len(terms) != 4 { |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3151 | t.Fatal("copyCmds contains invalid cp command", cmd) |
| 3152 | } |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3153 | dst = terms[len(terms)-1] |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3154 | src = terms[len(terms)-2] |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3155 | isLink = false |
| 3156 | case "ln": |
| 3157 | if len(terms) != 3 && len(terms) != 4 { |
| 3158 | // ln LINK TARGET or ln -s LINK TARGET |
| 3159 | t.Fatal("copyCmds contains invalid ln command", cmd) |
| 3160 | } |
| 3161 | dst = terms[len(terms)-1] |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3162 | src = terms[len(terms)-2] |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3163 | isLink = true |
| 3164 | default: |
| 3165 | t.Fatalf("copyCmds should contain mkdir/cp commands only: %q", cmd) |
| 3166 | } |
| 3167 | if dst != "" { |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3168 | index := strings.Index(dst, imageApexDir) |
| 3169 | if index == -1 { |
| 3170 | t.Fatal("copyCmds should copy a file to image.apex/", cmd) |
| 3171 | } |
| 3172 | dstFile := dst[index+len(imageApexDir):] |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3173 | ret = append(ret, fileInApex{path: dstFile, src: src, isLink: isLink}) |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3174 | } |
| 3175 | } |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3176 | return ret |
| 3177 | } |
| 3178 | |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3179 | func ensureExactContents(t *testing.T, ctx *android.TestContext, moduleName, variant string, files []string) { |
| 3180 | t.Helper() |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3181 | var failed bool |
| 3182 | var surplus []string |
| 3183 | filesMatched := make(map[string]bool) |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3184 | for _, file := range getFiles(t, ctx, moduleName, variant) { |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 3185 | mactchFound := false |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3186 | for _, expected := range files { |
| 3187 | if matched, _ := path.Match(expected, file.path); matched { |
| 3188 | filesMatched[expected] = true |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 3189 | mactchFound = true |
| 3190 | break |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3191 | } |
| 3192 | } |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 3193 | if !mactchFound { |
| 3194 | surplus = append(surplus, file.path) |
| 3195 | } |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3196 | } |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3197 | |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3198 | if len(surplus) > 0 { |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3199 | sort.Strings(surplus) |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3200 | t.Log("surplus files", surplus) |
| 3201 | failed = true |
| 3202 | } |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3203 | |
| 3204 | if len(files) > len(filesMatched) { |
| 3205 | var missing []string |
| 3206 | for _, expected := range files { |
| 3207 | if !filesMatched[expected] { |
| 3208 | missing = append(missing, expected) |
| 3209 | } |
| 3210 | } |
| 3211 | sort.Strings(missing) |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3212 | t.Log("missing files", missing) |
| 3213 | failed = true |
| 3214 | } |
| 3215 | if failed { |
| 3216 | t.Fail() |
| 3217 | } |
| 3218 | } |
| 3219 | |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3220 | func TestVndkApexCurrent(t *testing.T) { |
Jooyung Han | 7d6e79b | 2021-06-24 01:53:43 +0900 | [diff] [blame] | 3221 | commonFiles := []string{ |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 3222 | "lib/libc++.so", |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 3223 | "lib64/libc++.so", |
Jiyong Park | f58c46e | 2021-04-01 21:35:20 +0900 | [diff] [blame] | 3224 | "etc/llndk.libraries.29.txt", |
| 3225 | "etc/vndkcore.libraries.29.txt", |
| 3226 | "etc/vndksp.libraries.29.txt", |
| 3227 | "etc/vndkprivate.libraries.29.txt", |
| 3228 | "etc/vndkproduct.libraries.29.txt", |
Jooyung Han | 7d6e79b | 2021-06-24 01:53:43 +0900 | [diff] [blame] | 3229 | } |
| 3230 | testCases := []struct { |
| 3231 | vndkVersion string |
| 3232 | expectedFiles []string |
| 3233 | }{ |
| 3234 | { |
| 3235 | vndkVersion: "current", |
| 3236 | expectedFiles: append(commonFiles, |
| 3237 | "lib/libvndk.so", |
| 3238 | "lib/libvndksp.so", |
| 3239 | "lib64/libvndk.so", |
| 3240 | "lib64/libvndksp.so"), |
| 3241 | }, |
| 3242 | { |
| 3243 | vndkVersion: "", |
| 3244 | expectedFiles: append(commonFiles, |
| 3245 | // Legacy VNDK APEX contains only VNDK-SP files (of core variant) |
| 3246 | "lib/libvndksp.so", |
| 3247 | "lib64/libvndksp.so"), |
| 3248 | }, |
| 3249 | } |
| 3250 | for _, tc := range testCases { |
| 3251 | t.Run("VNDK.current with DeviceVndkVersion="+tc.vndkVersion, func(t *testing.T) { |
| 3252 | ctx := testApex(t, ` |
| 3253 | apex_vndk { |
| 3254 | name: "com.android.vndk.current", |
| 3255 | key: "com.android.vndk.current.key", |
| 3256 | updatable: false, |
| 3257 | } |
| 3258 | |
| 3259 | apex_key { |
| 3260 | name: "com.android.vndk.current.key", |
| 3261 | public_key: "testkey.avbpubkey", |
| 3262 | private_key: "testkey.pem", |
| 3263 | } |
| 3264 | |
| 3265 | cc_library { |
| 3266 | name: "libvndk", |
| 3267 | srcs: ["mylib.cpp"], |
| 3268 | vendor_available: true, |
| 3269 | product_available: true, |
| 3270 | vndk: { |
| 3271 | enabled: true, |
| 3272 | }, |
| 3273 | system_shared_libs: [], |
| 3274 | stl: "none", |
| 3275 | apex_available: [ "com.android.vndk.current" ], |
| 3276 | } |
| 3277 | |
| 3278 | cc_library { |
| 3279 | name: "libvndksp", |
| 3280 | srcs: ["mylib.cpp"], |
| 3281 | vendor_available: true, |
| 3282 | product_available: true, |
| 3283 | vndk: { |
| 3284 | enabled: true, |
| 3285 | support_system_process: true, |
| 3286 | }, |
| 3287 | system_shared_libs: [], |
| 3288 | stl: "none", |
| 3289 | apex_available: [ "com.android.vndk.current" ], |
| 3290 | } |
| 3291 | |
| 3292 | // VNDK-Ext should not cause any problems |
| 3293 | |
| 3294 | cc_library { |
| 3295 | name: "libvndk.ext", |
| 3296 | srcs: ["mylib2.cpp"], |
| 3297 | vendor: true, |
| 3298 | vndk: { |
| 3299 | enabled: true, |
| 3300 | extends: "libvndk", |
| 3301 | }, |
| 3302 | system_shared_libs: [], |
| 3303 | stl: "none", |
| 3304 | } |
| 3305 | |
| 3306 | cc_library { |
| 3307 | name: "libvndksp.ext", |
| 3308 | srcs: ["mylib2.cpp"], |
| 3309 | vendor: true, |
| 3310 | vndk: { |
| 3311 | enabled: true, |
| 3312 | support_system_process: true, |
| 3313 | extends: "libvndksp", |
| 3314 | }, |
| 3315 | system_shared_libs: [], |
| 3316 | stl: "none", |
| 3317 | } |
| 3318 | `+vndkLibrariesTxtFiles("current"), android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 3319 | variables.DeviceVndkVersion = proptools.StringPtr(tc.vndkVersion) |
| 3320 | })) |
| 3321 | ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", tc.expectedFiles) |
| 3322 | }) |
| 3323 | } |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3324 | } |
| 3325 | |
| 3326 | func TestVndkApexWithPrebuilt(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3327 | ctx := testApex(t, ` |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3328 | apex_vndk { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3329 | name: "com.android.vndk.current", |
| 3330 | key: "com.android.vndk.current.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3331 | updatable: false, |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3332 | } |
| 3333 | |
| 3334 | apex_key { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3335 | name: "com.android.vndk.current.key", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3336 | public_key: "testkey.avbpubkey", |
| 3337 | private_key: "testkey.pem", |
| 3338 | } |
| 3339 | |
| 3340 | cc_prebuilt_library_shared { |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3341 | name: "libvndk", |
| 3342 | srcs: ["libvndk.so"], |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3343 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 3344 | product_available: true, |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3345 | vndk: { |
| 3346 | enabled: true, |
| 3347 | }, |
| 3348 | system_shared_libs: [], |
| 3349 | stl: "none", |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3350 | apex_available: [ "com.android.vndk.current" ], |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3351 | } |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3352 | |
| 3353 | cc_prebuilt_library_shared { |
| 3354 | name: "libvndk.arm", |
| 3355 | srcs: ["libvndk.arm.so"], |
| 3356 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 3357 | product_available: true, |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3358 | vndk: { |
| 3359 | enabled: true, |
| 3360 | }, |
| 3361 | enabled: false, |
| 3362 | arch: { |
| 3363 | arm: { |
| 3364 | enabled: true, |
| 3365 | }, |
| 3366 | }, |
| 3367 | system_shared_libs: [], |
| 3368 | stl: "none", |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3369 | apex_available: [ "com.android.vndk.current" ], |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3370 | } |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3371 | `+vndkLibrariesTxtFiles("current"), |
| 3372 | withFiles(map[string][]byte{ |
| 3373 | "libvndk.so": nil, |
| 3374 | "libvndk.arm.so": nil, |
| 3375 | })) |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3376 | ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{ |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3377 | "lib/libvndk.so", |
| 3378 | "lib/libvndk.arm.so", |
| 3379 | "lib64/libvndk.so", |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 3380 | "lib/libc++.so", |
| 3381 | "lib64/libc++.so", |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3382 | "etc/*", |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3383 | }) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3384 | } |
| 3385 | |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3386 | func vndkLibrariesTxtFiles(vers ...string) (result string) { |
| 3387 | for _, v := range vers { |
| 3388 | if v == "current" { |
Justin Yun | 8a2600c | 2020-12-07 12:44:03 +0900 | [diff] [blame] | 3389 | for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} { |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3390 | result += ` |
Colin Cross | e4e44bc | 2020-12-28 13:50:21 -0800 | [diff] [blame] | 3391 | ` + txt + `_libraries_txt { |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3392 | name: "` + txt + `.libraries.txt", |
| 3393 | } |
| 3394 | ` |
| 3395 | } |
| 3396 | } else { |
Justin Yun | 8a2600c | 2020-12-07 12:44:03 +0900 | [diff] [blame] | 3397 | for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} { |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3398 | result += ` |
| 3399 | prebuilt_etc { |
| 3400 | name: "` + txt + `.libraries.` + v + `.txt", |
| 3401 | src: "dummy.txt", |
| 3402 | } |
| 3403 | ` |
| 3404 | } |
| 3405 | } |
| 3406 | } |
| 3407 | return |
| 3408 | } |
| 3409 | |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3410 | func TestVndkApexVersion(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3411 | ctx := testApex(t, ` |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3412 | apex_vndk { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3413 | name: "com.android.vndk.v27", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3414 | key: "myapex.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3415 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3416 | vndk_version: "27", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3417 | updatable: false, |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3418 | } |
| 3419 | |
| 3420 | apex_key { |
| 3421 | name: "myapex.key", |
| 3422 | public_key: "testkey.avbpubkey", |
| 3423 | private_key: "testkey.pem", |
| 3424 | } |
| 3425 | |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3426 | vndk_prebuilt_shared { |
| 3427 | name: "libvndk27", |
| 3428 | version: "27", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3429 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 3430 | product_available: true, |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3431 | vndk: { |
| 3432 | enabled: true, |
| 3433 | }, |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3434 | target_arch: "arm64", |
| 3435 | arch: { |
| 3436 | arm: { |
| 3437 | srcs: ["libvndk27_arm.so"], |
| 3438 | }, |
| 3439 | arm64: { |
| 3440 | srcs: ["libvndk27_arm64.so"], |
| 3441 | }, |
| 3442 | }, |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3443 | apex_available: [ "com.android.vndk.v27" ], |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3444 | } |
| 3445 | |
| 3446 | vndk_prebuilt_shared { |
| 3447 | name: "libvndk27", |
| 3448 | version: "27", |
| 3449 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 3450 | product_available: true, |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3451 | vndk: { |
| 3452 | enabled: true, |
| 3453 | }, |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3454 | target_arch: "x86_64", |
| 3455 | arch: { |
| 3456 | x86: { |
| 3457 | srcs: ["libvndk27_x86.so"], |
| 3458 | }, |
| 3459 | x86_64: { |
| 3460 | srcs: ["libvndk27_x86_64.so"], |
| 3461 | }, |
| 3462 | }, |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3463 | } |
| 3464 | `+vndkLibrariesTxtFiles("27"), |
| 3465 | withFiles(map[string][]byte{ |
| 3466 | "libvndk27_arm.so": nil, |
| 3467 | "libvndk27_arm64.so": nil, |
| 3468 | "libvndk27_x86.so": nil, |
| 3469 | "libvndk27_x86_64.so": nil, |
| 3470 | })) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3471 | |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3472 | ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{ |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3473 | "lib/libvndk27_arm.so", |
| 3474 | "lib64/libvndk27_arm64.so", |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3475 | "etc/*", |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3476 | }) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3477 | } |
| 3478 | |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3479 | func TestVndkApexNameRule(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3480 | ctx := testApex(t, ` |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3481 | apex_vndk { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3482 | name: "com.android.vndk.current", |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3483 | key: "myapex.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3484 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3485 | updatable: false, |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3486 | } |
| 3487 | apex_vndk { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3488 | name: "com.android.vndk.v28", |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3489 | key: "myapex.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3490 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3491 | vndk_version: "28", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3492 | updatable: false, |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3493 | } |
| 3494 | apex_key { |
| 3495 | name: "myapex.key", |
| 3496 | public_key: "testkey.avbpubkey", |
| 3497 | private_key: "testkey.pem", |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3498 | }`+vndkLibrariesTxtFiles("28", "current")) |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3499 | |
| 3500 | assertApexName := func(expected, moduleName string) { |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3501 | bundle := ctx.ModuleForTests(moduleName, "android_common_image").Module().(*apexBundle) |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3502 | actual := proptools.String(bundle.properties.Apex_name) |
| 3503 | if !reflect.DeepEqual(actual, expected) { |
| 3504 | t.Errorf("Got '%v', expected '%v'", actual, expected) |
| 3505 | } |
| 3506 | } |
| 3507 | |
Jiyong Park | f58c46e | 2021-04-01 21:35:20 +0900 | [diff] [blame] | 3508 | assertApexName("com.android.vndk.v29", "com.android.vndk.current") |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3509 | assertApexName("com.android.vndk.v28", "com.android.vndk.v28") |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3510 | } |
| 3511 | |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3512 | func TestVndkApexSkipsNativeBridgeSupportedModules(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3513 | ctx := testApex(t, ` |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3514 | apex_vndk { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3515 | name: "com.android.vndk.current", |
| 3516 | key: "com.android.vndk.current.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3517 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3518 | updatable: false, |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3519 | } |
| 3520 | |
| 3521 | apex_key { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3522 | name: "com.android.vndk.current.key", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3523 | public_key: "testkey.avbpubkey", |
| 3524 | private_key: "testkey.pem", |
| 3525 | } |
| 3526 | |
| 3527 | cc_library { |
| 3528 | name: "libvndk", |
| 3529 | srcs: ["mylib.cpp"], |
| 3530 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 3531 | product_available: true, |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3532 | native_bridge_supported: true, |
| 3533 | host_supported: true, |
| 3534 | vndk: { |
| 3535 | enabled: true, |
| 3536 | }, |
| 3537 | system_shared_libs: [], |
| 3538 | stl: "none", |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3539 | apex_available: [ "com.android.vndk.current" ], |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3540 | } |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3541 | `+vndkLibrariesTxtFiles("current"), |
| 3542 | withNativeBridgeEnabled) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3543 | |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3544 | ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{ |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3545 | "lib/libvndk.so", |
| 3546 | "lib64/libvndk.so", |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 3547 | "lib/libc++.so", |
| 3548 | "lib64/libc++.so", |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3549 | "etc/*", |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3550 | }) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3551 | } |
| 3552 | |
| 3553 | func TestVndkApexDoesntSupportNativeBridgeSupported(t *testing.T) { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3554 | testApexError(t, `module "com.android.vndk.current" .*: native_bridge_supported: .* doesn't support native bridge binary`, ` |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3555 | apex_vndk { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3556 | name: "com.android.vndk.current", |
| 3557 | key: "com.android.vndk.current.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3558 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3559 | native_bridge_supported: true, |
| 3560 | } |
| 3561 | |
| 3562 | apex_key { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3563 | name: "com.android.vndk.current.key", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3564 | public_key: "testkey.avbpubkey", |
| 3565 | private_key: "testkey.pem", |
| 3566 | } |
| 3567 | |
| 3568 | cc_library { |
| 3569 | name: "libvndk", |
| 3570 | srcs: ["mylib.cpp"], |
| 3571 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 3572 | product_available: true, |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3573 | native_bridge_supported: true, |
| 3574 | host_supported: true, |
| 3575 | vndk: { |
| 3576 | enabled: true, |
| 3577 | }, |
| 3578 | system_shared_libs: [], |
| 3579 | stl: "none", |
| 3580 | } |
| 3581 | `) |
| 3582 | } |
| 3583 | |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3584 | func TestVndkApexWithBinder32(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3585 | ctx := testApex(t, ` |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3586 | apex_vndk { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3587 | name: "com.android.vndk.v27", |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3588 | key: "myapex.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3589 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3590 | vndk_version: "27", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3591 | updatable: false, |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3592 | } |
| 3593 | |
| 3594 | apex_key { |
| 3595 | name: "myapex.key", |
| 3596 | public_key: "testkey.avbpubkey", |
| 3597 | private_key: "testkey.pem", |
| 3598 | } |
| 3599 | |
| 3600 | vndk_prebuilt_shared { |
| 3601 | name: "libvndk27", |
| 3602 | version: "27", |
| 3603 | target_arch: "arm", |
| 3604 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 3605 | product_available: true, |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3606 | vndk: { |
| 3607 | enabled: true, |
| 3608 | }, |
| 3609 | arch: { |
| 3610 | arm: { |
| 3611 | srcs: ["libvndk27.so"], |
| 3612 | } |
| 3613 | }, |
| 3614 | } |
| 3615 | |
| 3616 | vndk_prebuilt_shared { |
| 3617 | name: "libvndk27", |
| 3618 | version: "27", |
| 3619 | target_arch: "arm", |
| 3620 | binder32bit: true, |
| 3621 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 3622 | product_available: true, |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3623 | vndk: { |
| 3624 | enabled: true, |
| 3625 | }, |
| 3626 | arch: { |
| 3627 | arm: { |
| 3628 | srcs: ["libvndk27binder32.so"], |
| 3629 | } |
| 3630 | }, |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3631 | apex_available: [ "com.android.vndk.v27" ], |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3632 | } |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3633 | `+vndkLibrariesTxtFiles("27"), |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3634 | withFiles(map[string][]byte{ |
| 3635 | "libvndk27.so": nil, |
| 3636 | "libvndk27binder32.so": nil, |
| 3637 | }), |
| 3638 | withBinder32bit, |
| 3639 | withTargets(map[android.OsType][]android.Target{ |
| 3640 | android.Android: []android.Target{ |
Jooyung Han | 35155c4 | 2020-02-06 17:33:20 +0900 | [diff] [blame] | 3641 | {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}, |
| 3642 | NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""}, |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3643 | }, |
| 3644 | }), |
| 3645 | ) |
| 3646 | |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3647 | ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{ |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3648 | "lib/libvndk27binder32.so", |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3649 | "etc/*", |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3650 | }) |
| 3651 | } |
| 3652 | |
Jooyung Han | 45a9677 | 2020-06-15 14:59:42 +0900 | [diff] [blame] | 3653 | func TestVndkApexShouldNotProvideNativeLibs(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3654 | ctx := testApex(t, ` |
Jooyung Han | 45a9677 | 2020-06-15 14:59:42 +0900 | [diff] [blame] | 3655 | apex_vndk { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3656 | name: "com.android.vndk.current", |
| 3657 | key: "com.android.vndk.current.key", |
Jooyung Han | 45a9677 | 2020-06-15 14:59:42 +0900 | [diff] [blame] | 3658 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3659 | updatable: false, |
Jooyung Han | 45a9677 | 2020-06-15 14:59:42 +0900 | [diff] [blame] | 3660 | } |
| 3661 | |
| 3662 | apex_key { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3663 | name: "com.android.vndk.current.key", |
Jooyung Han | 45a9677 | 2020-06-15 14:59:42 +0900 | [diff] [blame] | 3664 | public_key: "testkey.avbpubkey", |
| 3665 | private_key: "testkey.pem", |
| 3666 | } |
| 3667 | |
| 3668 | cc_library { |
| 3669 | name: "libz", |
| 3670 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 3671 | product_available: true, |
Jooyung Han | 45a9677 | 2020-06-15 14:59:42 +0900 | [diff] [blame] | 3672 | vndk: { |
| 3673 | enabled: true, |
| 3674 | }, |
| 3675 | stubs: { |
| 3676 | symbol_file: "libz.map.txt", |
| 3677 | versions: ["30"], |
| 3678 | } |
| 3679 | } |
| 3680 | `+vndkLibrariesTxtFiles("current"), withFiles(map[string][]byte{ |
| 3681 | "libz.map.txt": nil, |
| 3682 | })) |
| 3683 | |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3684 | apexManifestRule := ctx.ModuleForTests("com.android.vndk.current", "android_common_image").Rule("apexManifestRule") |
Jooyung Han | 45a9677 | 2020-06-15 14:59:42 +0900 | [diff] [blame] | 3685 | provideNativeLibs := names(apexManifestRule.Args["provideNativeLibs"]) |
| 3686 | ensureListEmpty(t, provideNativeLibs) |
| 3687 | } |
| 3688 | |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3689 | func TestDependenciesInApexManifest(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3690 | ctx := testApex(t, ` |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3691 | apex { |
| 3692 | name: "myapex_nodep", |
| 3693 | key: "myapex.key", |
| 3694 | native_shared_libs: ["lib_nodep"], |
| 3695 | compile_multilib: "both", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3696 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3697 | updatable: false, |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3698 | } |
| 3699 | |
| 3700 | apex { |
| 3701 | name: "myapex_dep", |
| 3702 | key: "myapex.key", |
| 3703 | native_shared_libs: ["lib_dep"], |
| 3704 | compile_multilib: "both", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3705 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3706 | updatable: false, |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3707 | } |
| 3708 | |
| 3709 | apex { |
| 3710 | name: "myapex_provider", |
| 3711 | key: "myapex.key", |
| 3712 | native_shared_libs: ["libfoo"], |
| 3713 | compile_multilib: "both", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3714 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3715 | updatable: false, |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3716 | } |
| 3717 | |
| 3718 | apex { |
| 3719 | name: "myapex_selfcontained", |
| 3720 | key: "myapex.key", |
| 3721 | native_shared_libs: ["lib_dep", "libfoo"], |
| 3722 | compile_multilib: "both", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3723 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3724 | updatable: false, |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3725 | } |
| 3726 | |
| 3727 | apex_key { |
| 3728 | name: "myapex.key", |
| 3729 | public_key: "testkey.avbpubkey", |
| 3730 | private_key: "testkey.pem", |
| 3731 | } |
| 3732 | |
| 3733 | cc_library { |
| 3734 | name: "lib_nodep", |
| 3735 | srcs: ["mylib.cpp"], |
| 3736 | system_shared_libs: [], |
| 3737 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3738 | apex_available: [ "myapex_nodep" ], |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3739 | } |
| 3740 | |
| 3741 | cc_library { |
| 3742 | name: "lib_dep", |
| 3743 | srcs: ["mylib.cpp"], |
| 3744 | shared_libs: ["libfoo"], |
| 3745 | system_shared_libs: [], |
| 3746 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3747 | apex_available: [ |
| 3748 | "myapex_dep", |
| 3749 | "myapex_provider", |
| 3750 | "myapex_selfcontained", |
| 3751 | ], |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3752 | } |
| 3753 | |
| 3754 | cc_library { |
| 3755 | name: "libfoo", |
| 3756 | srcs: ["mytest.cpp"], |
| 3757 | stubs: { |
| 3758 | versions: ["1"], |
| 3759 | }, |
| 3760 | system_shared_libs: [], |
| 3761 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3762 | apex_available: [ |
| 3763 | "myapex_provider", |
| 3764 | "myapex_selfcontained", |
| 3765 | ], |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3766 | } |
| 3767 | `) |
| 3768 | |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3769 | var apexManifestRule android.TestingBuildParams |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3770 | var provideNativeLibs, requireNativeLibs []string |
| 3771 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 3772 | apexManifestRule = ctx.ModuleForTests("myapex_nodep", "android_common_myapex_nodep_image").Rule("apexManifestRule") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3773 | provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"]) |
| 3774 | requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"]) |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3775 | ensureListEmpty(t, provideNativeLibs) |
| 3776 | ensureListEmpty(t, requireNativeLibs) |
| 3777 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 3778 | apexManifestRule = ctx.ModuleForTests("myapex_dep", "android_common_myapex_dep_image").Rule("apexManifestRule") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3779 | provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"]) |
| 3780 | requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"]) |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3781 | ensureListEmpty(t, provideNativeLibs) |
| 3782 | ensureListContains(t, requireNativeLibs, "libfoo.so") |
| 3783 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 3784 | apexManifestRule = ctx.ModuleForTests("myapex_provider", "android_common_myapex_provider_image").Rule("apexManifestRule") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3785 | provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"]) |
| 3786 | requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"]) |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3787 | ensureListContains(t, provideNativeLibs, "libfoo.so") |
| 3788 | ensureListEmpty(t, requireNativeLibs) |
| 3789 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 3790 | apexManifestRule = ctx.ModuleForTests("myapex_selfcontained", "android_common_myapex_selfcontained_image").Rule("apexManifestRule") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3791 | provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"]) |
| 3792 | requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"]) |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3793 | ensureListContains(t, provideNativeLibs, "libfoo.so") |
| 3794 | ensureListEmpty(t, requireNativeLibs) |
| 3795 | } |
| 3796 | |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3797 | func TestApexName(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3798 | ctx := testApex(t, ` |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3799 | apex { |
| 3800 | name: "myapex", |
| 3801 | key: "myapex.key", |
| 3802 | apex_name: "com.android.myapex", |
Jiyong Park | db33486 | 2020-02-05 17:19:28 +0900 | [diff] [blame] | 3803 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3804 | updatable: false, |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3805 | } |
| 3806 | |
| 3807 | apex_key { |
| 3808 | name: "myapex.key", |
| 3809 | public_key: "testkey.avbpubkey", |
| 3810 | private_key: "testkey.pem", |
| 3811 | } |
Jiyong Park | db33486 | 2020-02-05 17:19:28 +0900 | [diff] [blame] | 3812 | |
| 3813 | cc_library { |
| 3814 | name: "mylib", |
| 3815 | srcs: ["mylib.cpp"], |
| 3816 | system_shared_libs: [], |
| 3817 | stl: "none", |
| 3818 | apex_available: [ |
| 3819 | "//apex_available:platform", |
| 3820 | "myapex", |
| 3821 | ], |
| 3822 | } |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3823 | `) |
| 3824 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 3825 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3826 | apexManifestRule := module.Rule("apexManifestRule") |
| 3827 | ensureContains(t, apexManifestRule.Args["opt"], "-v name com.android.myapex") |
| 3828 | apexRule := module.Rule("apexRule") |
| 3829 | ensureContains(t, apexRule.Args["opt_flags"], "--do_not_check_keyname") |
Jiyong Park | db33486 | 2020-02-05 17:19:28 +0900 | [diff] [blame] | 3830 | |
| 3831 | apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 3832 | data := android.AndroidMkDataForTest(t, ctx, apexBundle) |
Jiyong Park | db33486 | 2020-02-05 17:19:28 +0900 | [diff] [blame] | 3833 | name := apexBundle.BaseModuleName() |
| 3834 | prefix := "TARGET_" |
| 3835 | var builder strings.Builder |
| 3836 | data.Custom(&builder, name, prefix, "", data) |
| 3837 | androidMk := builder.String() |
| 3838 | ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n") |
| 3839 | ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3840 | } |
| 3841 | |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 3842 | func TestNonTestApex(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3843 | ctx := testApex(t, ` |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 3844 | apex { |
| 3845 | name: "myapex", |
| 3846 | key: "myapex.key", |
| 3847 | native_shared_libs: ["mylib_common"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3848 | updatable: false, |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 3849 | } |
| 3850 | |
| 3851 | apex_key { |
| 3852 | name: "myapex.key", |
| 3853 | public_key: "testkey.avbpubkey", |
| 3854 | private_key: "testkey.pem", |
| 3855 | } |
| 3856 | |
| 3857 | cc_library { |
| 3858 | name: "mylib_common", |
| 3859 | srcs: ["mylib.cpp"], |
| 3860 | system_shared_libs: [], |
| 3861 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3862 | apex_available: [ |
| 3863 | "//apex_available:platform", |
| 3864 | "myapex", |
| 3865 | ], |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 3866 | } |
| 3867 | `) |
| 3868 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 3869 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 3870 | apexRule := module.Rule("apexRule") |
| 3871 | copyCmds := apexRule.Args["copy_commands"] |
| 3872 | |
| 3873 | if apex, ok := module.Module().(*apexBundle); !ok || apex.testApex { |
| 3874 | t.Log("Apex was a test apex!") |
| 3875 | t.Fail() |
| 3876 | } |
| 3877 | // Ensure that main rule creates an output |
| 3878 | ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned") |
| 3879 | |
| 3880 | // Ensure that apex variant is created for the direct dep |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 3881 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000") |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 3882 | |
| 3883 | // Ensure that both direct and indirect deps are copied into apex |
| 3884 | ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so") |
| 3885 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 3886 | // Ensure that the platform variant ends with _shared |
| 3887 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared") |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 3888 | |
Colin Cross | 56a8321 | 2020-09-15 18:30:11 -0700 | [diff] [blame] | 3889 | if !ctx.ModuleForTests("mylib_common", "android_arm64_armv8-a_shared_apex10000").Module().(*cc.Module).InAnyApex() { |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 3890 | t.Log("Found mylib_common not in any apex!") |
| 3891 | t.Fail() |
| 3892 | } |
| 3893 | } |
| 3894 | |
| 3895 | func TestTestApex(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3896 | ctx := testApex(t, ` |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 3897 | apex_test { |
| 3898 | name: "myapex", |
| 3899 | key: "myapex.key", |
| 3900 | native_shared_libs: ["mylib_common_test"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3901 | updatable: false, |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 3902 | } |
| 3903 | |
| 3904 | apex_key { |
| 3905 | name: "myapex.key", |
| 3906 | public_key: "testkey.avbpubkey", |
| 3907 | private_key: "testkey.pem", |
| 3908 | } |
| 3909 | |
| 3910 | cc_library { |
| 3911 | name: "mylib_common_test", |
| 3912 | srcs: ["mylib.cpp"], |
| 3913 | system_shared_libs: [], |
| 3914 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3915 | // TODO: remove //apex_available:platform |
| 3916 | apex_available: [ |
| 3917 | "//apex_available:platform", |
| 3918 | "myapex", |
| 3919 | ], |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 3920 | } |
| 3921 | `) |
| 3922 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 3923 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 3924 | apexRule := module.Rule("apexRule") |
| 3925 | copyCmds := apexRule.Args["copy_commands"] |
| 3926 | |
| 3927 | if apex, ok := module.Module().(*apexBundle); !ok || !apex.testApex { |
| 3928 | t.Log("Apex was not a test apex!") |
| 3929 | t.Fail() |
| 3930 | } |
| 3931 | // Ensure that main rule creates an output |
| 3932 | ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned") |
| 3933 | |
| 3934 | // Ensure that apex variant is created for the direct dep |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 3935 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared_apex10000") |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 3936 | |
| 3937 | // Ensure that both direct and indirect deps are copied into apex |
| 3938 | ensureContains(t, copyCmds, "image.apex/lib64/mylib_common_test.so") |
| 3939 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 3940 | // Ensure that the platform variant ends with _shared |
| 3941 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared") |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 3942 | } |
| 3943 | |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 3944 | func TestApexWithTarget(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3945 | ctx := testApex(t, ` |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 3946 | apex { |
| 3947 | name: "myapex", |
| 3948 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3949 | updatable: false, |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 3950 | multilib: { |
| 3951 | first: { |
| 3952 | native_shared_libs: ["mylib_common"], |
| 3953 | } |
| 3954 | }, |
| 3955 | target: { |
| 3956 | android: { |
| 3957 | multilib: { |
| 3958 | first: { |
| 3959 | native_shared_libs: ["mylib"], |
| 3960 | } |
| 3961 | } |
| 3962 | }, |
| 3963 | host: { |
| 3964 | multilib: { |
| 3965 | first: { |
| 3966 | native_shared_libs: ["mylib2"], |
| 3967 | } |
| 3968 | } |
| 3969 | } |
| 3970 | } |
| 3971 | } |
| 3972 | |
| 3973 | apex_key { |
| 3974 | name: "myapex.key", |
| 3975 | public_key: "testkey.avbpubkey", |
| 3976 | private_key: "testkey.pem", |
| 3977 | } |
| 3978 | |
| 3979 | cc_library { |
| 3980 | name: "mylib", |
| 3981 | srcs: ["mylib.cpp"], |
| 3982 | system_shared_libs: [], |
| 3983 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3984 | // TODO: remove //apex_available:platform |
| 3985 | apex_available: [ |
| 3986 | "//apex_available:platform", |
| 3987 | "myapex", |
| 3988 | ], |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 3989 | } |
| 3990 | |
| 3991 | cc_library { |
| 3992 | name: "mylib_common", |
| 3993 | srcs: ["mylib.cpp"], |
| 3994 | system_shared_libs: [], |
| 3995 | stl: "none", |
| 3996 | compile_multilib: "first", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3997 | // TODO: remove //apex_available:platform |
| 3998 | apex_available: [ |
| 3999 | "//apex_available:platform", |
| 4000 | "myapex", |
| 4001 | ], |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 4002 | } |
| 4003 | |
| 4004 | cc_library { |
| 4005 | name: "mylib2", |
| 4006 | srcs: ["mylib.cpp"], |
| 4007 | system_shared_libs: [], |
| 4008 | stl: "none", |
| 4009 | compile_multilib: "first", |
| 4010 | } |
| 4011 | `) |
| 4012 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 4013 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 4014 | copyCmds := apexRule.Args["copy_commands"] |
| 4015 | |
| 4016 | // Ensure that main rule creates an output |
| 4017 | ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned") |
| 4018 | |
| 4019 | // Ensure that apex variant is created for the direct dep |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 4020 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000") |
| 4021 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000") |
| 4022 | ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000") |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 4023 | |
| 4024 | // Ensure that both direct and indirect deps are copied into apex |
| 4025 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
| 4026 | ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so") |
| 4027 | ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so") |
| 4028 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 4029 | // Ensure that the platform variant ends with _shared |
| 4030 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared") |
| 4031 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared") |
| 4032 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared") |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 4033 | } |
Jiyong Park | 04480cf | 2019-02-06 00:16:29 +0900 | [diff] [blame] | 4034 | |
Jiyong Park | 5914030 | 2020-12-14 18:44:04 +0900 | [diff] [blame] | 4035 | func TestApexWithArch(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4036 | ctx := testApex(t, ` |
Jiyong Park | 5914030 | 2020-12-14 18:44:04 +0900 | [diff] [blame] | 4037 | apex { |
| 4038 | name: "myapex", |
| 4039 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4040 | updatable: false, |
Jiyong Park | 5914030 | 2020-12-14 18:44:04 +0900 | [diff] [blame] | 4041 | arch: { |
| 4042 | arm64: { |
| 4043 | native_shared_libs: ["mylib.arm64"], |
| 4044 | }, |
| 4045 | x86_64: { |
| 4046 | native_shared_libs: ["mylib.x64"], |
| 4047 | }, |
| 4048 | } |
| 4049 | } |
| 4050 | |
| 4051 | apex_key { |
| 4052 | name: "myapex.key", |
| 4053 | public_key: "testkey.avbpubkey", |
| 4054 | private_key: "testkey.pem", |
| 4055 | } |
| 4056 | |
| 4057 | cc_library { |
| 4058 | name: "mylib.arm64", |
| 4059 | srcs: ["mylib.cpp"], |
| 4060 | system_shared_libs: [], |
| 4061 | stl: "none", |
| 4062 | // TODO: remove //apex_available:platform |
| 4063 | apex_available: [ |
| 4064 | "//apex_available:platform", |
| 4065 | "myapex", |
| 4066 | ], |
| 4067 | } |
| 4068 | |
| 4069 | cc_library { |
| 4070 | name: "mylib.x64", |
| 4071 | srcs: ["mylib.cpp"], |
| 4072 | system_shared_libs: [], |
| 4073 | stl: "none", |
| 4074 | // TODO: remove //apex_available:platform |
| 4075 | apex_available: [ |
| 4076 | "//apex_available:platform", |
| 4077 | "myapex", |
| 4078 | ], |
| 4079 | } |
| 4080 | `) |
| 4081 | |
| 4082 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
| 4083 | copyCmds := apexRule.Args["copy_commands"] |
| 4084 | |
| 4085 | // Ensure that apex variant is created for the direct dep |
| 4086 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib.arm64"), "android_arm64_armv8-a_shared_apex10000") |
| 4087 | ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib.x64"), "android_arm64_armv8-a_shared_apex10000") |
| 4088 | |
| 4089 | // Ensure that both direct and indirect deps are copied into apex |
| 4090 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.arm64.so") |
| 4091 | ensureNotContains(t, copyCmds, "image.apex/lib64/mylib.x64.so") |
| 4092 | } |
| 4093 | |
Jiyong Park | 04480cf | 2019-02-06 00:16:29 +0900 | [diff] [blame] | 4094 | func TestApexWithShBinary(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4095 | ctx := testApex(t, ` |
Jiyong Park | 04480cf | 2019-02-06 00:16:29 +0900 | [diff] [blame] | 4096 | apex { |
| 4097 | name: "myapex", |
| 4098 | key: "myapex.key", |
| 4099 | binaries: ["myscript"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4100 | updatable: false, |
Jiyong Park | 04480cf | 2019-02-06 00:16:29 +0900 | [diff] [blame] | 4101 | } |
| 4102 | |
| 4103 | apex_key { |
| 4104 | name: "myapex.key", |
| 4105 | public_key: "testkey.avbpubkey", |
| 4106 | private_key: "testkey.pem", |
| 4107 | } |
| 4108 | |
| 4109 | sh_binary { |
| 4110 | name: "myscript", |
| 4111 | src: "mylib.cpp", |
| 4112 | filename: "myscript.sh", |
| 4113 | sub_dir: "script", |
| 4114 | } |
| 4115 | `) |
| 4116 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 4117 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Jiyong Park | 04480cf | 2019-02-06 00:16:29 +0900 | [diff] [blame] | 4118 | copyCmds := apexRule.Args["copy_commands"] |
| 4119 | |
| 4120 | ensureContains(t, copyCmds, "image.apex/bin/script/myscript.sh") |
| 4121 | } |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 4122 | |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 4123 | func TestApexInVariousPartition(t *testing.T) { |
| 4124 | testcases := []struct { |
| 4125 | propName, parition, flattenedPartition string |
| 4126 | }{ |
| 4127 | {"", "system", "system_ext"}, |
| 4128 | {"product_specific: true", "product", "product"}, |
| 4129 | {"soc_specific: true", "vendor", "vendor"}, |
| 4130 | {"proprietary: true", "vendor", "vendor"}, |
| 4131 | {"vendor: true", "vendor", "vendor"}, |
| 4132 | {"system_ext_specific: true", "system_ext", "system_ext"}, |
| 4133 | } |
| 4134 | for _, tc := range testcases { |
| 4135 | t.Run(tc.propName+":"+tc.parition, func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4136 | ctx := testApex(t, ` |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 4137 | apex { |
| 4138 | name: "myapex", |
| 4139 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4140 | updatable: false, |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 4141 | `+tc.propName+` |
| 4142 | } |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 4143 | |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 4144 | apex_key { |
| 4145 | name: "myapex.key", |
| 4146 | public_key: "testkey.avbpubkey", |
| 4147 | private_key: "testkey.pem", |
| 4148 | } |
| 4149 | `) |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 4150 | |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 4151 | apex := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Paul Duffin | 37ba344 | 2021-03-29 00:21:08 +0100 | [diff] [blame] | 4152 | expected := "out/soong/target/product/test_device/" + tc.parition + "/apex" |
| 4153 | actual := apex.installDir.RelativeToTop().String() |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 4154 | if actual != expected { |
| 4155 | t.Errorf("wrong install path. expected %q. actual %q", expected, actual) |
| 4156 | } |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 4157 | |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 4158 | flattened := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle) |
Paul Duffin | 37ba344 | 2021-03-29 00:21:08 +0100 | [diff] [blame] | 4159 | expected = "out/soong/target/product/test_device/" + tc.flattenedPartition + "/apex" |
| 4160 | actual = flattened.installDir.RelativeToTop().String() |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 4161 | if actual != expected { |
| 4162 | t.Errorf("wrong install path. expected %q. actual %q", expected, actual) |
| 4163 | } |
| 4164 | }) |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 4165 | } |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 4166 | } |
Jiyong Park | 6788256 | 2019-03-21 01:11:21 +0900 | [diff] [blame] | 4167 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4168 | func TestFileContexts_FindInDefaultLocationIfNotSet(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4169 | ctx := testApex(t, ` |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4170 | apex { |
| 4171 | name: "myapex", |
| 4172 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4173 | updatable: false, |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4174 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4175 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4176 | apex_key { |
| 4177 | name: "myapex.key", |
| 4178 | public_key: "testkey.avbpubkey", |
| 4179 | private_key: "testkey.pem", |
| 4180 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4181 | `) |
| 4182 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4183 | rule := module.Output("file_contexts") |
| 4184 | ensureContains(t, rule.RuleParams.Command, "cat system/sepolicy/apex/myapex-file_contexts") |
| 4185 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4186 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4187 | func TestFileContexts_ShouldBeUnderSystemSepolicyForSystemApexes(t *testing.T) { |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4188 | testApexError(t, `"myapex" .*: file_contexts: should be under system/sepolicy`, ` |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4189 | apex { |
| 4190 | name: "myapex", |
| 4191 | key: "myapex.key", |
| 4192 | file_contexts: "my_own_file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4193 | updatable: false, |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4194 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4195 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4196 | apex_key { |
| 4197 | name: "myapex.key", |
| 4198 | public_key: "testkey.avbpubkey", |
| 4199 | private_key: "testkey.pem", |
| 4200 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4201 | `, withFiles(map[string][]byte{ |
| 4202 | "my_own_file_contexts": nil, |
| 4203 | })) |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4204 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4205 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4206 | func TestFileContexts_ProductSpecificApexes(t *testing.T) { |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4207 | testApexError(t, `"myapex" .*: file_contexts: cannot find`, ` |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4208 | apex { |
| 4209 | name: "myapex", |
| 4210 | key: "myapex.key", |
| 4211 | product_specific: true, |
| 4212 | file_contexts: "product_specific_file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4213 | updatable: false, |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4214 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4215 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4216 | apex_key { |
| 4217 | name: "myapex.key", |
| 4218 | public_key: "testkey.avbpubkey", |
| 4219 | private_key: "testkey.pem", |
| 4220 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4221 | `) |
| 4222 | |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4223 | ctx := testApex(t, ` |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4224 | apex { |
| 4225 | name: "myapex", |
| 4226 | key: "myapex.key", |
| 4227 | product_specific: true, |
| 4228 | file_contexts: "product_specific_file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4229 | updatable: false, |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4230 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4231 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4232 | apex_key { |
| 4233 | name: "myapex.key", |
| 4234 | public_key: "testkey.avbpubkey", |
| 4235 | private_key: "testkey.pem", |
| 4236 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4237 | `, withFiles(map[string][]byte{ |
| 4238 | "product_specific_file_contexts": nil, |
| 4239 | })) |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4240 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
| 4241 | rule := module.Output("file_contexts") |
| 4242 | ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts") |
| 4243 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4244 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4245 | func TestFileContexts_SetViaFileGroup(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4246 | ctx := testApex(t, ` |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4247 | apex { |
| 4248 | name: "myapex", |
| 4249 | key: "myapex.key", |
| 4250 | product_specific: true, |
| 4251 | file_contexts: ":my-file-contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4252 | updatable: false, |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4253 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4254 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4255 | apex_key { |
| 4256 | name: "myapex.key", |
| 4257 | public_key: "testkey.avbpubkey", |
| 4258 | private_key: "testkey.pem", |
| 4259 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4260 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4261 | filegroup { |
| 4262 | name: "my-file-contexts", |
| 4263 | srcs: ["product_specific_file_contexts"], |
| 4264 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4265 | `, withFiles(map[string][]byte{ |
| 4266 | "product_specific_file_contexts": nil, |
| 4267 | })) |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4268 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
| 4269 | rule := module.Output("file_contexts") |
| 4270 | ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts") |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4271 | } |
| 4272 | |
Jiyong Park | 6788256 | 2019-03-21 01:11:21 +0900 | [diff] [blame] | 4273 | func TestApexKeyFromOtherModule(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4274 | ctx := testApex(t, ` |
Jiyong Park | 6788256 | 2019-03-21 01:11:21 +0900 | [diff] [blame] | 4275 | apex_key { |
| 4276 | name: "myapex.key", |
| 4277 | public_key: ":my.avbpubkey", |
| 4278 | private_key: ":my.pem", |
| 4279 | product_specific: true, |
| 4280 | } |
| 4281 | |
| 4282 | filegroup { |
| 4283 | name: "my.avbpubkey", |
| 4284 | srcs: ["testkey2.avbpubkey"], |
| 4285 | } |
| 4286 | |
| 4287 | filegroup { |
| 4288 | name: "my.pem", |
| 4289 | srcs: ["testkey2.pem"], |
| 4290 | } |
| 4291 | `) |
| 4292 | |
| 4293 | apex_key := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey) |
| 4294 | expected_pubkey := "testkey2.avbpubkey" |
Jaewoong Jung | 18aefc1 | 2020-12-21 09:11:10 -0800 | [diff] [blame] | 4295 | actual_pubkey := apex_key.publicKeyFile.String() |
Jiyong Park | 6788256 | 2019-03-21 01:11:21 +0900 | [diff] [blame] | 4296 | if actual_pubkey != expected_pubkey { |
| 4297 | t.Errorf("wrong public key path. expected %q. actual %q", expected_pubkey, actual_pubkey) |
| 4298 | } |
| 4299 | expected_privkey := "testkey2.pem" |
Jaewoong Jung | 18aefc1 | 2020-12-21 09:11:10 -0800 | [diff] [blame] | 4300 | actual_privkey := apex_key.privateKeyFile.String() |
Jiyong Park | 6788256 | 2019-03-21 01:11:21 +0900 | [diff] [blame] | 4301 | if actual_privkey != expected_privkey { |
| 4302 | t.Errorf("wrong private key path. expected %q. actual %q", expected_privkey, actual_privkey) |
| 4303 | } |
| 4304 | } |
Jaewoong Jung | 939ebd5 | 2019-03-26 15:07:36 -0700 | [diff] [blame] | 4305 | |
| 4306 | func TestPrebuilt(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4307 | ctx := testApex(t, ` |
Jaewoong Jung | 939ebd5 | 2019-03-26 15:07:36 -0700 | [diff] [blame] | 4308 | prebuilt_apex { |
| 4309 | name: "myapex", |
Jiyong Park | c95714e | 2019-03-29 14:23:10 +0900 | [diff] [blame] | 4310 | arch: { |
| 4311 | arm64: { |
| 4312 | src: "myapex-arm64.apex", |
| 4313 | }, |
| 4314 | arm: { |
| 4315 | src: "myapex-arm.apex", |
| 4316 | }, |
| 4317 | }, |
Jaewoong Jung | 939ebd5 | 2019-03-26 15:07:36 -0700 | [diff] [blame] | 4318 | } |
| 4319 | `) |
| 4320 | |
Paul Duffin | 6717d88 | 2021-06-15 19:09:41 +0100 | [diff] [blame] | 4321 | prebuilt := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt) |
Jaewoong Jung | 939ebd5 | 2019-03-26 15:07:36 -0700 | [diff] [blame] | 4322 | |
Jiyong Park | c95714e | 2019-03-29 14:23:10 +0900 | [diff] [blame] | 4323 | expectedInput := "myapex-arm64.apex" |
| 4324 | if prebuilt.inputApex.String() != expectedInput { |
| 4325 | t.Errorf("inputApex invalid. expected: %q, actual: %q", expectedInput, prebuilt.inputApex.String()) |
| 4326 | } |
Jaewoong Jung | 939ebd5 | 2019-03-26 15:07:36 -0700 | [diff] [blame] | 4327 | } |
Nikita Ioffe | 7a41ebd | 2019-04-04 18:09:48 +0100 | [diff] [blame] | 4328 | |
Paul Duffin | c0609c6 | 2021-03-01 17:27:16 +0000 | [diff] [blame] | 4329 | func TestPrebuiltMissingSrc(t *testing.T) { |
Paul Duffin | 6717d88 | 2021-06-15 19:09:41 +0100 | [diff] [blame] | 4330 | testApexError(t, `module "myapex" variant "android_common_myapex".*: prebuilt_apex does not support "arm64_armv8-a"`, ` |
Paul Duffin | c0609c6 | 2021-03-01 17:27:16 +0000 | [diff] [blame] | 4331 | prebuilt_apex { |
| 4332 | name: "myapex", |
| 4333 | } |
| 4334 | `) |
| 4335 | } |
| 4336 | |
Nikita Ioffe | 7a41ebd | 2019-04-04 18:09:48 +0100 | [diff] [blame] | 4337 | func TestPrebuiltFilenameOverride(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4338 | ctx := testApex(t, ` |
Nikita Ioffe | 7a41ebd | 2019-04-04 18:09:48 +0100 | [diff] [blame] | 4339 | prebuilt_apex { |
| 4340 | name: "myapex", |
| 4341 | src: "myapex-arm.apex", |
| 4342 | filename: "notmyapex.apex", |
| 4343 | } |
| 4344 | `) |
| 4345 | |
Paul Duffin | 6717d88 | 2021-06-15 19:09:41 +0100 | [diff] [blame] | 4346 | p := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt) |
Nikita Ioffe | 7a41ebd | 2019-04-04 18:09:48 +0100 | [diff] [blame] | 4347 | |
| 4348 | expected := "notmyapex.apex" |
| 4349 | if p.installFilename != expected { |
| 4350 | t.Errorf("installFilename invalid. expected: %q, actual: %q", expected, p.installFilename) |
| 4351 | } |
| 4352 | } |
Jaewoong Jung | c1001ec | 2019-06-25 11:20:53 -0700 | [diff] [blame] | 4353 | |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 4354 | func TestPrebuiltOverrides(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4355 | ctx := testApex(t, ` |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 4356 | prebuilt_apex { |
| 4357 | name: "myapex.prebuilt", |
| 4358 | src: "myapex-arm.apex", |
| 4359 | overrides: [ |
| 4360 | "myapex", |
| 4361 | ], |
| 4362 | } |
| 4363 | `) |
| 4364 | |
Paul Duffin | 6717d88 | 2021-06-15 19:09:41 +0100 | [diff] [blame] | 4365 | p := ctx.ModuleForTests("myapex.prebuilt", "android_common_myapex.prebuilt").Module().(*Prebuilt) |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 4366 | |
| 4367 | expected := []string{"myapex"} |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 4368 | actual := android.AndroidMkEntriesForTest(t, ctx, p)[0].EntryMap["LOCAL_OVERRIDES_MODULES"] |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 4369 | if !reflect.DeepEqual(actual, expected) { |
Jiyong Park | b0a012c | 2019-11-14 17:17:03 +0900 | [diff] [blame] | 4370 | t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES value '%s', expected '%s'", actual, expected) |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 4371 | } |
| 4372 | } |
| 4373 | |
Paul Duffin | 092153d | 2021-01-26 11:42:39 +0000 | [diff] [blame] | 4374 | // These tests verify that the prebuilt_apex/deapexer to java_import wiring allows for the |
| 4375 | // propagation of paths to dex implementation jars from the former to the latter. |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4376 | func TestPrebuiltExportDexImplementationJars(t *testing.T) { |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 4377 | transform := android.NullFixturePreparer |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4378 | |
Paul Duffin | 89886cb | 2021-02-05 16:44:03 +0000 | [diff] [blame] | 4379 | checkDexJarBuildPath := func(t *testing.T, ctx *android.TestContext, name string) { |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4380 | // Make sure the import has been given the correct path to the dex jar. |
Colin Cross | dcf71b2 | 2021-02-01 13:59:03 -0800 | [diff] [blame] | 4381 | p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency) |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4382 | dexJarBuildPath := p.DexJarBuildPath() |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4383 | stem := android.RemoveOptionalPrebuiltPrefix(name) |
| 4384 | if expected, actual := ".intermediates/myapex.deapexer/android_common/deapexer/javalib/"+stem+".jar", android.NormalizePathForTesting(dexJarBuildPath); actual != expected { |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4385 | t.Errorf("Incorrect DexJarBuildPath value '%s', expected '%s'", actual, expected) |
| 4386 | } |
| 4387 | } |
| 4388 | |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4389 | ensureNoSourceVariant := func(t *testing.T, ctx *android.TestContext, name string) { |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4390 | // Make sure that an apex variant is not created for the source module. |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4391 | if expected, actual := []string{"android_common"}, ctx.ModuleVariantsForTests(name); !reflect.DeepEqual(expected, actual) { |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4392 | t.Errorf("invalid set of variants for %q: expected %q, found %q", "libfoo", expected, actual) |
| 4393 | } |
| 4394 | } |
| 4395 | |
| 4396 | t.Run("prebuilt only", func(t *testing.T) { |
| 4397 | bp := ` |
| 4398 | prebuilt_apex { |
| 4399 | name: "myapex", |
| 4400 | arch: { |
| 4401 | arm64: { |
| 4402 | src: "myapex-arm64.apex", |
| 4403 | }, |
| 4404 | arm: { |
| 4405 | src: "myapex-arm.apex", |
| 4406 | }, |
| 4407 | }, |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4408 | exported_java_libs: ["libfoo", "libbar"], |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4409 | } |
| 4410 | |
| 4411 | java_import { |
| 4412 | name: "libfoo", |
| 4413 | jars: ["libfoo.jar"], |
| 4414 | } |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4415 | |
| 4416 | java_sdk_library_import { |
| 4417 | name: "libbar", |
| 4418 | public: { |
| 4419 | jars: ["libbar.jar"], |
| 4420 | }, |
| 4421 | } |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4422 | ` |
| 4423 | |
| 4424 | // Make sure that dexpreopt can access dex implementation files from the prebuilt. |
| 4425 | ctx := testDexpreoptWithApexes(t, bp, "", transform) |
| 4426 | |
Paul Duffin | f6932af | 2021-02-26 18:21:56 +0000 | [diff] [blame] | 4427 | // Make sure that the deapexer has the correct input APEX. |
| 4428 | deapexer := ctx.ModuleForTests("myapex.deapexer", "android_common") |
| 4429 | rule := deapexer.Rule("deapexer") |
| 4430 | if expected, actual := []string{"myapex-arm64.apex"}, android.NormalizePathsForTesting(rule.Implicits); !reflect.DeepEqual(expected, actual) { |
| 4431 | t.Errorf("expected: %q, found: %q", expected, actual) |
| 4432 | } |
| 4433 | |
Paul Duffin | 0d10c3c | 2021-03-01 17:09:32 +0000 | [diff] [blame] | 4434 | // Make sure that the prebuilt_apex has the correct input APEX. |
Paul Duffin | 6717d88 | 2021-06-15 19:09:41 +0100 | [diff] [blame] | 4435 | prebuiltApex := ctx.ModuleForTests("myapex", "android_common_myapex") |
Paul Duffin | 0d10c3c | 2021-03-01 17:09:32 +0000 | [diff] [blame] | 4436 | rule = prebuiltApex.Rule("android/soong/android.Cp") |
| 4437 | if expected, actual := "myapex-arm64.apex", android.NormalizePathForTesting(rule.Input); !reflect.DeepEqual(expected, actual) { |
| 4438 | t.Errorf("expected: %q, found: %q", expected, actual) |
| 4439 | } |
| 4440 | |
Paul Duffin | 89886cb | 2021-02-05 16:44:03 +0000 | [diff] [blame] | 4441 | checkDexJarBuildPath(t, ctx, "libfoo") |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4442 | |
| 4443 | checkDexJarBuildPath(t, ctx, "libbar") |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4444 | }) |
| 4445 | |
| 4446 | t.Run("prebuilt with source preferred", func(t *testing.T) { |
| 4447 | |
| 4448 | bp := ` |
| 4449 | prebuilt_apex { |
| 4450 | name: "myapex", |
| 4451 | arch: { |
| 4452 | arm64: { |
| 4453 | src: "myapex-arm64.apex", |
| 4454 | }, |
| 4455 | arm: { |
| 4456 | src: "myapex-arm.apex", |
| 4457 | }, |
| 4458 | }, |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4459 | exported_java_libs: ["libfoo", "libbar"], |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4460 | } |
| 4461 | |
| 4462 | java_import { |
| 4463 | name: "libfoo", |
| 4464 | jars: ["libfoo.jar"], |
| 4465 | } |
| 4466 | |
| 4467 | java_library { |
| 4468 | name: "libfoo", |
| 4469 | } |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4470 | |
| 4471 | java_sdk_library_import { |
| 4472 | name: "libbar", |
| 4473 | public: { |
| 4474 | jars: ["libbar.jar"], |
| 4475 | }, |
| 4476 | } |
| 4477 | |
| 4478 | java_sdk_library { |
| 4479 | name: "libbar", |
| 4480 | srcs: ["foo/bar/MyClass.java"], |
| 4481 | unsafe_ignore_missing_latest_api: true, |
| 4482 | } |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4483 | ` |
| 4484 | |
| 4485 | // Make sure that dexpreopt can access dex implementation files from the prebuilt. |
| 4486 | ctx := testDexpreoptWithApexes(t, bp, "", transform) |
| 4487 | |
Paul Duffin | 89886cb | 2021-02-05 16:44:03 +0000 | [diff] [blame] | 4488 | checkDexJarBuildPath(t, ctx, "prebuilt_libfoo") |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4489 | ensureNoSourceVariant(t, ctx, "libfoo") |
| 4490 | |
| 4491 | checkDexJarBuildPath(t, ctx, "prebuilt_libbar") |
| 4492 | ensureNoSourceVariant(t, ctx, "libbar") |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4493 | }) |
| 4494 | |
| 4495 | t.Run("prebuilt preferred with source", func(t *testing.T) { |
| 4496 | bp := ` |
| 4497 | prebuilt_apex { |
| 4498 | name: "myapex", |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4499 | arch: { |
| 4500 | arm64: { |
| 4501 | src: "myapex-arm64.apex", |
| 4502 | }, |
| 4503 | arm: { |
| 4504 | src: "myapex-arm.apex", |
| 4505 | }, |
| 4506 | }, |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4507 | exported_java_libs: ["libfoo", "libbar"], |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4508 | } |
| 4509 | |
| 4510 | java_import { |
| 4511 | name: "libfoo", |
Paul Duffin | 092153d | 2021-01-26 11:42:39 +0000 | [diff] [blame] | 4512 | prefer: true, |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4513 | jars: ["libfoo.jar"], |
| 4514 | } |
| 4515 | |
| 4516 | java_library { |
| 4517 | name: "libfoo", |
| 4518 | } |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4519 | |
| 4520 | java_sdk_library_import { |
| 4521 | name: "libbar", |
| 4522 | prefer: true, |
| 4523 | public: { |
| 4524 | jars: ["libbar.jar"], |
| 4525 | }, |
| 4526 | } |
| 4527 | |
| 4528 | java_sdk_library { |
| 4529 | name: "libbar", |
| 4530 | srcs: ["foo/bar/MyClass.java"], |
| 4531 | unsafe_ignore_missing_latest_api: true, |
| 4532 | } |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4533 | ` |
| 4534 | |
| 4535 | // Make sure that dexpreopt can access dex implementation files from the prebuilt. |
| 4536 | ctx := testDexpreoptWithApexes(t, bp, "", transform) |
| 4537 | |
Paul Duffin | 89886cb | 2021-02-05 16:44:03 +0000 | [diff] [blame] | 4538 | checkDexJarBuildPath(t, ctx, "prebuilt_libfoo") |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4539 | ensureNoSourceVariant(t, ctx, "libfoo") |
| 4540 | |
| 4541 | checkDexJarBuildPath(t, ctx, "prebuilt_libbar") |
| 4542 | ensureNoSourceVariant(t, ctx, "libbar") |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4543 | }) |
| 4544 | } |
| 4545 | |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4546 | func TestBootDexJarsFromSourcesAndPrebuilts(t *testing.T) { |
Paul Duffin | b6f53c0 | 2021-05-14 07:52:42 +0100 | [diff] [blame] | 4547 | preparer := android.GroupFixturePreparers( |
| 4548 | java.FixtureConfigureBootJars("myapex:libfoo", "myapex:libbar"), |
| 4549 | // Make sure that the frameworks/base/Android.bp file exists as otherwise hidden API encoding |
| 4550 | // is disabled. |
| 4551 | android.FixtureAddTextFile("frameworks/base/Android.bp", ""), |
| 4552 | ) |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4553 | |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4554 | checkBootDexJarPath := func(t *testing.T, ctx *android.TestContext, stem string, bootDexJarPath string) { |
| 4555 | t.Helper() |
Paul Duffin | 7ebebfd | 2021-04-27 19:36:57 +0100 | [diff] [blame] | 4556 | s := ctx.ModuleForTests("platform-bootclasspath", "android_common") |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4557 | foundLibfooJar := false |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4558 | base := stem + ".jar" |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4559 | for _, output := range s.AllOutputs() { |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4560 | if filepath.Base(output) == base { |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4561 | foundLibfooJar = true |
| 4562 | buildRule := s.Output(output) |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 4563 | android.AssertStringEquals(t, "boot dex jar path", bootDexJarPath, buildRule.Input.String()) |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4564 | } |
| 4565 | } |
| 4566 | if !foundLibfooJar { |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 4567 | t.Errorf("Rule for libfoo.jar missing in dex_bootjars singleton outputs %q", android.StringPathsRelativeToTop(ctx.Config().BuildDir(), s.AllOutputs())) |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4568 | } |
| 4569 | } |
| 4570 | |
Paul Duffin | d061d40 | 2021-06-07 21:36:01 +0100 | [diff] [blame] | 4571 | checkHiddenAPIIndexInputs := func(t *testing.T, ctx *android.TestContext, expectedIntermediateInputs string) { |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4572 | t.Helper() |
Paul Duffin | 00b2bfd | 2021-04-12 17:24:36 +0100 | [diff] [blame] | 4573 | platformBootclasspath := ctx.ModuleForTests("platform-bootclasspath", "android_common") |
Paul Duffin | d061d40 | 2021-06-07 21:36:01 +0100 | [diff] [blame] | 4574 | var rule android.TestingBuildParams |
| 4575 | |
| 4576 | rule = platformBootclasspath.Output("hiddenapi-monolithic/index-from-classes.csv") |
| 4577 | java.CheckHiddenAPIRuleInputs(t, "intermediate index", expectedIntermediateInputs, rule) |
Paul Duffin | 4fd997b | 2021-02-03 20:06:33 +0000 | [diff] [blame] | 4578 | } |
| 4579 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4580 | fragment := java.ApexVariantReference{ |
| 4581 | Apex: proptools.StringPtr("myapex"), |
| 4582 | Module: proptools.StringPtr("my-bootclasspath-fragment"), |
| 4583 | } |
| 4584 | |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4585 | t.Run("prebuilt only", func(t *testing.T) { |
| 4586 | bp := ` |
| 4587 | prebuilt_apex { |
| 4588 | name: "myapex", |
| 4589 | arch: { |
| 4590 | arm64: { |
| 4591 | src: "myapex-arm64.apex", |
| 4592 | }, |
| 4593 | arm: { |
| 4594 | src: "myapex-arm.apex", |
| 4595 | }, |
| 4596 | }, |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4597 | exported_bootclasspath_fragments: ["my-bootclasspath-fragment"], |
| 4598 | } |
| 4599 | |
| 4600 | prebuilt_bootclasspath_fragment { |
| 4601 | name: "my-bootclasspath-fragment", |
| 4602 | contents: ["libfoo", "libbar"], |
| 4603 | apex_available: ["myapex"], |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4604 | } |
| 4605 | |
| 4606 | java_import { |
| 4607 | name: "libfoo", |
| 4608 | jars: ["libfoo.jar"], |
| 4609 | apex_available: ["myapex"], |
| 4610 | } |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4611 | |
| 4612 | java_sdk_library_import { |
| 4613 | name: "libbar", |
| 4614 | public: { |
| 4615 | jars: ["libbar.jar"], |
| 4616 | }, |
| 4617 | apex_available: ["myapex"], |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4618 | shared_library: false, |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4619 | } |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4620 | ` |
| 4621 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4622 | ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment) |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 4623 | checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar") |
| 4624 | checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar") |
Paul Duffin | 4fd997b | 2021-02-03 20:06:33 +0000 | [diff] [blame] | 4625 | |
Paul Duffin | 537ea3d | 2021-05-14 10:38:00 +0100 | [diff] [blame] | 4626 | // Verify the correct module jars contribute to the hiddenapi index file. |
Paul Duffin | 9d67ca6 | 2021-02-03 20:06:33 +0000 | [diff] [blame] | 4627 | checkHiddenAPIIndexInputs(t, ctx, ` |
Paul Duffin | 51d7da2 | 2021-06-16 02:04:13 +0100 | [diff] [blame] | 4628 | out/soong/.intermediates/libbar.stubs/android_common/combined/libbar.stubs.jar |
| 4629 | out/soong/.intermediates/libfoo/android_common_myapex/combined/libfoo.jar |
| 4630 | `) |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4631 | }) |
| 4632 | |
Paul Duffin | f58fd9a | 2021-04-06 16:00:22 +0100 | [diff] [blame] | 4633 | t.Run("apex_set only", func(t *testing.T) { |
| 4634 | bp := ` |
| 4635 | apex_set { |
| 4636 | name: "myapex", |
| 4637 | set: "myapex.apks", |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4638 | exported_bootclasspath_fragments: ["my-bootclasspath-fragment"], |
| 4639 | } |
| 4640 | |
| 4641 | prebuilt_bootclasspath_fragment { |
| 4642 | name: "my-bootclasspath-fragment", |
| 4643 | contents: ["libfoo", "libbar"], |
| 4644 | apex_available: ["myapex"], |
Paul Duffin | f58fd9a | 2021-04-06 16:00:22 +0100 | [diff] [blame] | 4645 | } |
| 4646 | |
| 4647 | java_import { |
| 4648 | name: "libfoo", |
| 4649 | jars: ["libfoo.jar"], |
| 4650 | apex_available: ["myapex"], |
| 4651 | } |
| 4652 | |
| 4653 | java_sdk_library_import { |
| 4654 | name: "libbar", |
| 4655 | public: { |
| 4656 | jars: ["libbar.jar"], |
| 4657 | }, |
| 4658 | apex_available: ["myapex"], |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4659 | shared_library: false, |
Paul Duffin | f58fd9a | 2021-04-06 16:00:22 +0100 | [diff] [blame] | 4660 | } |
| 4661 | ` |
| 4662 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4663 | ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment) |
Paul Duffin | f58fd9a | 2021-04-06 16:00:22 +0100 | [diff] [blame] | 4664 | checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar") |
| 4665 | checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar") |
| 4666 | |
Paul Duffin | 537ea3d | 2021-05-14 10:38:00 +0100 | [diff] [blame] | 4667 | // Verify the correct module jars contribute to the hiddenapi index file. |
Paul Duffin | f58fd9a | 2021-04-06 16:00:22 +0100 | [diff] [blame] | 4668 | checkHiddenAPIIndexInputs(t, ctx, ` |
Paul Duffin | 51d7da2 | 2021-06-16 02:04:13 +0100 | [diff] [blame] | 4669 | out/soong/.intermediates/libbar.stubs/android_common/combined/libbar.stubs.jar |
| 4670 | out/soong/.intermediates/libfoo/android_common_myapex/combined/libfoo.jar |
| 4671 | `) |
Paul Duffin | f58fd9a | 2021-04-06 16:00:22 +0100 | [diff] [blame] | 4672 | }) |
| 4673 | |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4674 | t.Run("prebuilt with source library preferred", func(t *testing.T) { |
| 4675 | bp := ` |
| 4676 | prebuilt_apex { |
| 4677 | name: "myapex", |
| 4678 | arch: { |
| 4679 | arm64: { |
| 4680 | src: "myapex-arm64.apex", |
| 4681 | }, |
| 4682 | arm: { |
| 4683 | src: "myapex-arm.apex", |
| 4684 | }, |
| 4685 | }, |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4686 | exported_bootclasspath_fragments: ["my-bootclasspath-fragment"], |
| 4687 | } |
| 4688 | |
| 4689 | prebuilt_bootclasspath_fragment { |
| 4690 | name: "my-bootclasspath-fragment", |
| 4691 | contents: ["libfoo", "libbar"], |
| 4692 | apex_available: ["myapex"], |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4693 | } |
| 4694 | |
| 4695 | java_import { |
| 4696 | name: "libfoo", |
| 4697 | jars: ["libfoo.jar"], |
| 4698 | apex_available: ["myapex"], |
| 4699 | } |
| 4700 | |
| 4701 | java_library { |
| 4702 | name: "libfoo", |
| 4703 | srcs: ["foo/bar/MyClass.java"], |
| 4704 | apex_available: ["myapex"], |
| 4705 | } |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4706 | |
| 4707 | java_sdk_library_import { |
| 4708 | name: "libbar", |
| 4709 | public: { |
| 4710 | jars: ["libbar.jar"], |
| 4711 | }, |
| 4712 | apex_available: ["myapex"], |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4713 | shared_library: false, |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4714 | } |
| 4715 | |
| 4716 | java_sdk_library { |
| 4717 | name: "libbar", |
| 4718 | srcs: ["foo/bar/MyClass.java"], |
| 4719 | unsafe_ignore_missing_latest_api: true, |
| 4720 | apex_available: ["myapex"], |
| 4721 | } |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4722 | ` |
| 4723 | |
| 4724 | // In this test the source (java_library) libfoo is active since the |
| 4725 | // prebuilt (java_import) defaults to prefer:false. However the |
| 4726 | // prebuilt_apex module always depends on the prebuilt, and so it doesn't |
| 4727 | // find the dex boot jar in it. We either need to disable the source libfoo |
| 4728 | // or make the prebuilt libfoo preferred. |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4729 | testDexpreoptWithApexes(t, bp, "module libfoo does not provide a dex boot jar", preparer, fragment) |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4730 | }) |
| 4731 | |
| 4732 | t.Run("prebuilt library preferred with source", func(t *testing.T) { |
| 4733 | bp := ` |
| 4734 | prebuilt_apex { |
| 4735 | name: "myapex", |
| 4736 | arch: { |
| 4737 | arm64: { |
| 4738 | src: "myapex-arm64.apex", |
| 4739 | }, |
| 4740 | arm: { |
| 4741 | src: "myapex-arm.apex", |
| 4742 | }, |
| 4743 | }, |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4744 | exported_bootclasspath_fragments: ["my-bootclasspath-fragment"], |
| 4745 | } |
| 4746 | |
| 4747 | prebuilt_bootclasspath_fragment { |
| 4748 | name: "my-bootclasspath-fragment", |
| 4749 | contents: ["libfoo", "libbar"], |
| 4750 | apex_available: ["myapex"], |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4751 | } |
| 4752 | |
| 4753 | java_import { |
| 4754 | name: "libfoo", |
| 4755 | prefer: true, |
| 4756 | jars: ["libfoo.jar"], |
| 4757 | apex_available: ["myapex"], |
| 4758 | } |
| 4759 | |
| 4760 | java_library { |
| 4761 | name: "libfoo", |
| 4762 | srcs: ["foo/bar/MyClass.java"], |
| 4763 | apex_available: ["myapex"], |
| 4764 | } |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4765 | |
| 4766 | java_sdk_library_import { |
| 4767 | name: "libbar", |
| 4768 | prefer: true, |
| 4769 | public: { |
| 4770 | jars: ["libbar.jar"], |
| 4771 | }, |
| 4772 | apex_available: ["myapex"], |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4773 | shared_library: false, |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4774 | } |
| 4775 | |
| 4776 | java_sdk_library { |
| 4777 | name: "libbar", |
| 4778 | srcs: ["foo/bar/MyClass.java"], |
| 4779 | unsafe_ignore_missing_latest_api: true, |
| 4780 | apex_available: ["myapex"], |
| 4781 | } |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4782 | ` |
| 4783 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4784 | ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment) |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 4785 | checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar") |
| 4786 | checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar") |
Paul Duffin | 4fd997b | 2021-02-03 20:06:33 +0000 | [diff] [blame] | 4787 | |
Paul Duffin | 537ea3d | 2021-05-14 10:38:00 +0100 | [diff] [blame] | 4788 | // Verify the correct module jars contribute to the hiddenapi index file. |
Paul Duffin | 9d67ca6 | 2021-02-03 20:06:33 +0000 | [diff] [blame] | 4789 | checkHiddenAPIIndexInputs(t, ctx, ` |
Paul Duffin | 51d7da2 | 2021-06-16 02:04:13 +0100 | [diff] [blame] | 4790 | out/soong/.intermediates/prebuilt_libbar.stubs/android_common/combined/libbar.stubs.jar |
| 4791 | out/soong/.intermediates/prebuilt_libfoo/android_common_myapex/combined/libfoo.jar |
| 4792 | `) |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4793 | }) |
| 4794 | |
| 4795 | t.Run("prebuilt with source apex preferred", func(t *testing.T) { |
| 4796 | bp := ` |
| 4797 | apex { |
| 4798 | name: "myapex", |
| 4799 | key: "myapex.key", |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4800 | java_libs: ["libfoo", "libbar"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4801 | updatable: false, |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4802 | } |
| 4803 | |
| 4804 | apex_key { |
| 4805 | name: "myapex.key", |
| 4806 | public_key: "testkey.avbpubkey", |
| 4807 | private_key: "testkey.pem", |
| 4808 | } |
| 4809 | |
| 4810 | prebuilt_apex { |
| 4811 | name: "myapex", |
| 4812 | arch: { |
| 4813 | arm64: { |
| 4814 | src: "myapex-arm64.apex", |
| 4815 | }, |
| 4816 | arm: { |
| 4817 | src: "myapex-arm.apex", |
| 4818 | }, |
| 4819 | }, |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4820 | exported_bootclasspath_fragments: ["my-bootclasspath-fragment"], |
| 4821 | } |
| 4822 | |
| 4823 | prebuilt_bootclasspath_fragment { |
| 4824 | name: "my-bootclasspath-fragment", |
| 4825 | contents: ["libfoo", "libbar"], |
| 4826 | apex_available: ["myapex"], |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4827 | } |
| 4828 | |
| 4829 | java_import { |
| 4830 | name: "libfoo", |
| 4831 | jars: ["libfoo.jar"], |
| 4832 | apex_available: ["myapex"], |
| 4833 | } |
| 4834 | |
| 4835 | java_library { |
| 4836 | name: "libfoo", |
| 4837 | srcs: ["foo/bar/MyClass.java"], |
| 4838 | apex_available: ["myapex"], |
| 4839 | } |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4840 | |
| 4841 | java_sdk_library_import { |
| 4842 | name: "libbar", |
| 4843 | public: { |
| 4844 | jars: ["libbar.jar"], |
| 4845 | }, |
| 4846 | apex_available: ["myapex"], |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4847 | shared_library: false, |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4848 | } |
| 4849 | |
| 4850 | java_sdk_library { |
| 4851 | name: "libbar", |
| 4852 | srcs: ["foo/bar/MyClass.java"], |
| 4853 | unsafe_ignore_missing_latest_api: true, |
| 4854 | apex_available: ["myapex"], |
| 4855 | } |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4856 | ` |
| 4857 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4858 | ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment) |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 4859 | checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/libfoo/android_common_apex10000/hiddenapi/libfoo.jar") |
| 4860 | checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/libbar/android_common_myapex/hiddenapi/libbar.jar") |
Paul Duffin | 4fd997b | 2021-02-03 20:06:33 +0000 | [diff] [blame] | 4861 | |
Paul Duffin | 537ea3d | 2021-05-14 10:38:00 +0100 | [diff] [blame] | 4862 | // Verify the correct module jars contribute to the hiddenapi index file. |
Paul Duffin | 4fd997b | 2021-02-03 20:06:33 +0000 | [diff] [blame] | 4863 | checkHiddenAPIIndexInputs(t, ctx, ` |
Paul Duffin | 51d7da2 | 2021-06-16 02:04:13 +0100 | [diff] [blame] | 4864 | out/soong/.intermediates/libbar/android_common_myapex/javac/libbar.jar |
| 4865 | out/soong/.intermediates/libfoo/android_common_apex10000/javac/libfoo.jar |
| 4866 | `) |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4867 | }) |
| 4868 | |
| 4869 | t.Run("prebuilt preferred with source apex disabled", func(t *testing.T) { |
| 4870 | bp := ` |
| 4871 | apex { |
| 4872 | name: "myapex", |
| 4873 | enabled: false, |
| 4874 | key: "myapex.key", |
Paul Duffin | 8f146b9 | 2021-04-12 17:24:18 +0100 | [diff] [blame] | 4875 | java_libs: ["libfoo", "libbar"], |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4876 | } |
| 4877 | |
| 4878 | apex_key { |
| 4879 | name: "myapex.key", |
| 4880 | public_key: "testkey.avbpubkey", |
| 4881 | private_key: "testkey.pem", |
| 4882 | } |
| 4883 | |
| 4884 | prebuilt_apex { |
| 4885 | name: "myapex", |
| 4886 | arch: { |
| 4887 | arm64: { |
| 4888 | src: "myapex-arm64.apex", |
| 4889 | }, |
| 4890 | arm: { |
| 4891 | src: "myapex-arm.apex", |
| 4892 | }, |
| 4893 | }, |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4894 | exported_bootclasspath_fragments: ["my-bootclasspath-fragment"], |
| 4895 | } |
| 4896 | |
| 4897 | prebuilt_bootclasspath_fragment { |
| 4898 | name: "my-bootclasspath-fragment", |
| 4899 | contents: ["libfoo", "libbar"], |
| 4900 | apex_available: ["myapex"], |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4901 | } |
| 4902 | |
| 4903 | java_import { |
| 4904 | name: "libfoo", |
| 4905 | prefer: true, |
| 4906 | jars: ["libfoo.jar"], |
| 4907 | apex_available: ["myapex"], |
| 4908 | } |
| 4909 | |
| 4910 | java_library { |
| 4911 | name: "libfoo", |
| 4912 | srcs: ["foo/bar/MyClass.java"], |
| 4913 | apex_available: ["myapex"], |
| 4914 | } |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4915 | |
| 4916 | java_sdk_library_import { |
| 4917 | name: "libbar", |
| 4918 | prefer: true, |
| 4919 | public: { |
| 4920 | jars: ["libbar.jar"], |
| 4921 | }, |
| 4922 | apex_available: ["myapex"], |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4923 | shared_library: false, |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4924 | } |
| 4925 | |
| 4926 | java_sdk_library { |
| 4927 | name: "libbar", |
| 4928 | srcs: ["foo/bar/MyClass.java"], |
| 4929 | unsafe_ignore_missing_latest_api: true, |
| 4930 | apex_available: ["myapex"], |
| 4931 | } |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4932 | ` |
| 4933 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4934 | ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment) |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 4935 | checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar") |
| 4936 | checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar") |
Paul Duffin | 4fd997b | 2021-02-03 20:06:33 +0000 | [diff] [blame] | 4937 | |
Paul Duffin | 537ea3d | 2021-05-14 10:38:00 +0100 | [diff] [blame] | 4938 | // Verify the correct module jars contribute to the hiddenapi index file. |
Paul Duffin | 9d67ca6 | 2021-02-03 20:06:33 +0000 | [diff] [blame] | 4939 | checkHiddenAPIIndexInputs(t, ctx, ` |
Paul Duffin | 51d7da2 | 2021-06-16 02:04:13 +0100 | [diff] [blame] | 4940 | out/soong/.intermediates/prebuilt_libbar.stubs/android_common/combined/libbar.stubs.jar |
| 4941 | out/soong/.intermediates/prebuilt_libfoo/android_common_myapex/combined/libfoo.jar |
| 4942 | `) |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4943 | }) |
| 4944 | } |
| 4945 | |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 4946 | func TestApexWithTests(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4947 | ctx := testApex(t, ` |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 4948 | apex_test { |
| 4949 | name: "myapex", |
| 4950 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4951 | updatable: false, |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 4952 | tests: [ |
| 4953 | "mytest", |
Roland Levillain | 9b5fde9 | 2019-06-28 15:41:19 +0100 | [diff] [blame] | 4954 | "mytests", |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 4955 | ], |
| 4956 | } |
| 4957 | |
| 4958 | apex_key { |
| 4959 | name: "myapex.key", |
| 4960 | public_key: "testkey.avbpubkey", |
| 4961 | private_key: "testkey.pem", |
| 4962 | } |
| 4963 | |
Liz Kammer | 1c14a21 | 2020-05-12 15:26:55 -0700 | [diff] [blame] | 4964 | filegroup { |
| 4965 | name: "fg", |
| 4966 | srcs: [ |
| 4967 | "baz", |
| 4968 | "bar/baz" |
| 4969 | ], |
| 4970 | } |
| 4971 | |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 4972 | cc_test { |
| 4973 | name: "mytest", |
| 4974 | gtest: false, |
| 4975 | srcs: ["mytest.cpp"], |
| 4976 | relative_install_path: "test", |
Jiyong Park | af9539f | 2020-05-04 10:31:32 +0900 | [diff] [blame] | 4977 | shared_libs: ["mylib"], |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 4978 | system_shared_libs: [], |
| 4979 | static_executable: true, |
| 4980 | stl: "none", |
Liz Kammer | 1c14a21 | 2020-05-12 15:26:55 -0700 | [diff] [blame] | 4981 | data: [":fg"], |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 4982 | } |
Roland Levillain | 9b5fde9 | 2019-06-28 15:41:19 +0100 | [diff] [blame] | 4983 | |
Jiyong Park | af9539f | 2020-05-04 10:31:32 +0900 | [diff] [blame] | 4984 | cc_library { |
| 4985 | name: "mylib", |
| 4986 | srcs: ["mylib.cpp"], |
| 4987 | system_shared_libs: [], |
| 4988 | stl: "none", |
| 4989 | } |
| 4990 | |
Liz Kammer | 5bd365f | 2020-05-27 15:15:11 -0700 | [diff] [blame] | 4991 | filegroup { |
| 4992 | name: "fg2", |
| 4993 | srcs: [ |
| 4994 | "testdata/baz" |
| 4995 | ], |
| 4996 | } |
| 4997 | |
Roland Levillain | 9b5fde9 | 2019-06-28 15:41:19 +0100 | [diff] [blame] | 4998 | cc_test { |
| 4999 | name: "mytests", |
| 5000 | gtest: false, |
| 5001 | srcs: [ |
| 5002 | "mytest1.cpp", |
| 5003 | "mytest2.cpp", |
| 5004 | "mytest3.cpp", |
| 5005 | ], |
| 5006 | test_per_src: true, |
| 5007 | relative_install_path: "test", |
| 5008 | system_shared_libs: [], |
| 5009 | static_executable: true, |
| 5010 | stl: "none", |
Liz Kammer | 5bd365f | 2020-05-27 15:15:11 -0700 | [diff] [blame] | 5011 | data: [ |
| 5012 | ":fg", |
| 5013 | ":fg2", |
| 5014 | ], |
Roland Levillain | 9b5fde9 | 2019-06-28 15:41:19 +0100 | [diff] [blame] | 5015 | } |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 5016 | `) |
| 5017 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 5018 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 5019 | copyCmds := apexRule.Args["copy_commands"] |
| 5020 | |
Jiyong Park | af9539f | 2020-05-04 10:31:32 +0900 | [diff] [blame] | 5021 | // Ensure that test dep (and their transitive dependencies) are copied into apex. |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 5022 | ensureContains(t, copyCmds, "image.apex/bin/test/mytest") |
Jiyong Park | af9539f | 2020-05-04 10:31:32 +0900 | [diff] [blame] | 5023 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
Roland Levillain | 9b5fde9 | 2019-06-28 15:41:19 +0100 | [diff] [blame] | 5024 | |
Liz Kammer | 1c14a21 | 2020-05-12 15:26:55 -0700 | [diff] [blame] | 5025 | //Ensure that test data are copied into apex. |
| 5026 | ensureContains(t, copyCmds, "image.apex/bin/test/baz") |
| 5027 | ensureContains(t, copyCmds, "image.apex/bin/test/bar/baz") |
| 5028 | |
Roland Levillain | 9b5fde9 | 2019-06-28 15:41:19 +0100 | [diff] [blame] | 5029 | // Ensure that test deps built with `test_per_src` are copied into apex. |
| 5030 | ensureContains(t, copyCmds, "image.apex/bin/test/mytest1") |
| 5031 | ensureContains(t, copyCmds, "image.apex/bin/test/mytest2") |
| 5032 | ensureContains(t, copyCmds, "image.apex/bin/test/mytest3") |
Roland Levillain | f89cd09 | 2019-07-29 16:22:59 +0100 | [diff] [blame] | 5033 | |
| 5034 | // Ensure the module is correctly translated. |
Liz Kammer | 81faaaf | 2020-05-20 09:57:08 -0700 | [diff] [blame] | 5035 | bundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 5036 | data := android.AndroidMkDataForTest(t, ctx, bundle) |
Liz Kammer | 81faaaf | 2020-05-20 09:57:08 -0700 | [diff] [blame] | 5037 | name := bundle.BaseModuleName() |
Roland Levillain | f89cd09 | 2019-07-29 16:22:59 +0100 | [diff] [blame] | 5038 | prefix := "TARGET_" |
| 5039 | var builder strings.Builder |
| 5040 | data.Custom(&builder, name, prefix, "", data) |
| 5041 | androidMk := builder.String() |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 5042 | ensureContains(t, androidMk, "LOCAL_MODULE := mytest.myapex\n") |
| 5043 | ensureContains(t, androidMk, "LOCAL_MODULE := mytest1.myapex\n") |
| 5044 | ensureContains(t, androidMk, "LOCAL_MODULE := mytest2.myapex\n") |
| 5045 | ensureContains(t, androidMk, "LOCAL_MODULE := mytest3.myapex\n") |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 5046 | ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex\n") |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 5047 | ensureContains(t, androidMk, "LOCAL_MODULE := apex_pubkey.myapex\n") |
Roland Levillain | f89cd09 | 2019-07-29 16:22:59 +0100 | [diff] [blame] | 5048 | ensureContains(t, androidMk, "LOCAL_MODULE := myapex\n") |
Liz Kammer | 81faaaf | 2020-05-20 09:57:08 -0700 | [diff] [blame] | 5049 | |
| 5050 | flatBundle := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 5051 | data = android.AndroidMkDataForTest(t, ctx, flatBundle) |
Liz Kammer | 81faaaf | 2020-05-20 09:57:08 -0700 | [diff] [blame] | 5052 | data.Custom(&builder, name, prefix, "", data) |
| 5053 | flatAndroidMk := builder.String() |
Liz Kammer | 5bd365f | 2020-05-27 15:15:11 -0700 | [diff] [blame] | 5054 | ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :baz :bar/baz\n") |
| 5055 | ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :testdata/baz\n") |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 5056 | } |
| 5057 | |
Jooyung Han | 3ab2c3e | 2019-12-05 16:27:44 +0900 | [diff] [blame] | 5058 | func TestInstallExtraFlattenedApexes(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5059 | ctx := testApex(t, ` |
Jooyung Han | 3ab2c3e | 2019-12-05 16:27:44 +0900 | [diff] [blame] | 5060 | apex { |
| 5061 | name: "myapex", |
| 5062 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5063 | updatable: false, |
Jooyung Han | 3ab2c3e | 2019-12-05 16:27:44 +0900 | [diff] [blame] | 5064 | } |
| 5065 | apex_key { |
| 5066 | name: "myapex.key", |
| 5067 | public_key: "testkey.avbpubkey", |
| 5068 | private_key: "testkey.pem", |
| 5069 | } |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 5070 | `, |
| 5071 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 5072 | variables.InstallExtraFlattenedApexes = proptools.BoolPtr(true) |
| 5073 | }), |
| 5074 | ) |
Jooyung Han | 3ab2c3e | 2019-12-05 16:27:44 +0900 | [diff] [blame] | 5075 | ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 5076 | ensureListContains(t, ab.requiredDeps, "myapex.flattened") |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 5077 | mk := android.AndroidMkDataForTest(t, ctx, ab) |
Jooyung Han | 3ab2c3e | 2019-12-05 16:27:44 +0900 | [diff] [blame] | 5078 | var builder strings.Builder |
| 5079 | mk.Custom(&builder, ab.Name(), "TARGET_", "", mk) |
| 5080 | androidMk := builder.String() |
| 5081 | ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += myapex.flattened") |
| 5082 | } |
| 5083 | |
Jooyung Han | d48f3c3 | 2019-08-23 11:18:57 +0900 | [diff] [blame] | 5084 | func TestErrorsIfDepsAreNotEnabled(t *testing.T) { |
| 5085 | testApexError(t, `module "myapex" .* depends on disabled module "libfoo"`, ` |
| 5086 | apex { |
| 5087 | name: "myapex", |
| 5088 | key: "myapex.key", |
| 5089 | native_shared_libs: ["libfoo"], |
| 5090 | } |
| 5091 | |
| 5092 | apex_key { |
| 5093 | name: "myapex.key", |
| 5094 | public_key: "testkey.avbpubkey", |
| 5095 | private_key: "testkey.pem", |
| 5096 | } |
| 5097 | |
| 5098 | cc_library { |
| 5099 | name: "libfoo", |
| 5100 | stl: "none", |
| 5101 | system_shared_libs: [], |
| 5102 | enabled: false, |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 5103 | apex_available: ["myapex"], |
Jooyung Han | d48f3c3 | 2019-08-23 11:18:57 +0900 | [diff] [blame] | 5104 | } |
| 5105 | `) |
| 5106 | testApexError(t, `module "myapex" .* depends on disabled module "myjar"`, ` |
| 5107 | apex { |
| 5108 | name: "myapex", |
| 5109 | key: "myapex.key", |
| 5110 | java_libs: ["myjar"], |
| 5111 | } |
| 5112 | |
| 5113 | apex_key { |
| 5114 | name: "myapex.key", |
| 5115 | public_key: "testkey.avbpubkey", |
| 5116 | private_key: "testkey.pem", |
| 5117 | } |
| 5118 | |
| 5119 | java_library { |
| 5120 | name: "myjar", |
| 5121 | srcs: ["foo/bar/MyClass.java"], |
| 5122 | sdk_version: "none", |
| 5123 | system_modules: "none", |
Jooyung Han | d48f3c3 | 2019-08-23 11:18:57 +0900 | [diff] [blame] | 5124 | enabled: false, |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 5125 | apex_available: ["myapex"], |
Jooyung Han | d48f3c3 | 2019-08-23 11:18:57 +0900 | [diff] [blame] | 5126 | } |
| 5127 | `) |
| 5128 | } |
| 5129 | |
Bill Peckham | a41a696 | 2021-01-11 10:58:54 -0800 | [diff] [blame] | 5130 | func TestApexWithJavaImport(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5131 | ctx := testApex(t, ` |
Bill Peckham | a41a696 | 2021-01-11 10:58:54 -0800 | [diff] [blame] | 5132 | apex { |
| 5133 | name: "myapex", |
| 5134 | key: "myapex.key", |
| 5135 | java_libs: ["myjavaimport"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5136 | updatable: false, |
Bill Peckham | a41a696 | 2021-01-11 10:58:54 -0800 | [diff] [blame] | 5137 | } |
| 5138 | |
| 5139 | apex_key { |
| 5140 | name: "myapex.key", |
| 5141 | public_key: "testkey.avbpubkey", |
| 5142 | private_key: "testkey.pem", |
| 5143 | } |
| 5144 | |
| 5145 | java_import { |
| 5146 | name: "myjavaimport", |
| 5147 | apex_available: ["myapex"], |
| 5148 | jars: ["my.jar"], |
| 5149 | compile_dex: true, |
| 5150 | } |
| 5151 | `) |
| 5152 | |
| 5153 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
| 5154 | apexRule := module.Rule("apexRule") |
| 5155 | copyCmds := apexRule.Args["copy_commands"] |
| 5156 | ensureContains(t, copyCmds, "image.apex/javalib/myjavaimport.jar") |
| 5157 | } |
| 5158 | |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5159 | func TestApexWithApps(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5160 | ctx := testApex(t, ` |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5161 | apex { |
| 5162 | name: "myapex", |
| 5163 | key: "myapex.key", |
| 5164 | apps: [ |
| 5165 | "AppFoo", |
Jiyong Park | f748731 | 2019-10-17 12:54:30 +0900 | [diff] [blame] | 5166 | "AppFooPriv", |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5167 | ], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5168 | updatable: false, |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5169 | } |
| 5170 | |
| 5171 | apex_key { |
| 5172 | name: "myapex.key", |
| 5173 | public_key: "testkey.avbpubkey", |
| 5174 | private_key: "testkey.pem", |
| 5175 | } |
| 5176 | |
| 5177 | android_app { |
| 5178 | name: "AppFoo", |
| 5179 | srcs: ["foo/bar/MyClass.java"], |
Colin Cross | 094cde4 | 2020-02-15 10:38:00 -0800 | [diff] [blame] | 5180 | sdk_version: "current", |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5181 | system_modules: "none", |
Jiyong Park | 8be103b | 2019-11-08 15:53:48 +0900 | [diff] [blame] | 5182 | jni_libs: ["libjni"], |
Colin Cross | 094cde4 | 2020-02-15 10:38:00 -0800 | [diff] [blame] | 5183 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 5184 | apex_available: [ "myapex" ], |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5185 | } |
Jiyong Park | f748731 | 2019-10-17 12:54:30 +0900 | [diff] [blame] | 5186 | |
| 5187 | android_app { |
| 5188 | name: "AppFooPriv", |
| 5189 | srcs: ["foo/bar/MyClass.java"], |
Colin Cross | 094cde4 | 2020-02-15 10:38:00 -0800 | [diff] [blame] | 5190 | sdk_version: "current", |
Jiyong Park | f748731 | 2019-10-17 12:54:30 +0900 | [diff] [blame] | 5191 | system_modules: "none", |
| 5192 | privileged: true, |
Colin Cross | 094cde4 | 2020-02-15 10:38:00 -0800 | [diff] [blame] | 5193 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 5194 | apex_available: [ "myapex" ], |
Jiyong Park | f748731 | 2019-10-17 12:54:30 +0900 | [diff] [blame] | 5195 | } |
Jiyong Park | 8be103b | 2019-11-08 15:53:48 +0900 | [diff] [blame] | 5196 | |
| 5197 | cc_library_shared { |
| 5198 | name: "libjni", |
| 5199 | srcs: ["mylib.cpp"], |
Jooyung Han | b7bebe2 | 2020-02-25 16:59:29 +0900 | [diff] [blame] | 5200 | shared_libs: ["libfoo"], |
| 5201 | stl: "none", |
| 5202 | system_shared_libs: [], |
| 5203 | apex_available: [ "myapex" ], |
| 5204 | sdk_version: "current", |
| 5205 | } |
| 5206 | |
| 5207 | cc_library_shared { |
| 5208 | name: "libfoo", |
Jiyong Park | 8be103b | 2019-11-08 15:53:48 +0900 | [diff] [blame] | 5209 | stl: "none", |
| 5210 | system_shared_libs: [], |
Jiyong Park | 0f80c18 | 2020-01-31 02:49:53 +0900 | [diff] [blame] | 5211 | apex_available: [ "myapex" ], |
Colin Cross | 094cde4 | 2020-02-15 10:38:00 -0800 | [diff] [blame] | 5212 | sdk_version: "current", |
Jiyong Park | 8be103b | 2019-11-08 15:53:48 +0900 | [diff] [blame] | 5213 | } |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5214 | `) |
| 5215 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 5216 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5217 | apexRule := module.Rule("apexRule") |
| 5218 | copyCmds := apexRule.Args["copy_commands"] |
| 5219 | |
| 5220 | ensureContains(t, copyCmds, "image.apex/app/AppFoo/AppFoo.apk") |
Jiyong Park | f748731 | 2019-10-17 12:54:30 +0900 | [diff] [blame] | 5221 | ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPriv/AppFooPriv.apk") |
Jiyong Park | 52cd06f | 2019-11-11 10:14:32 +0900 | [diff] [blame] | 5222 | |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 5223 | appZipRule := ctx.ModuleForTests("AppFoo", "android_common_apex10000").Description("zip jni libs") |
Jooyung Han | b7bebe2 | 2020-02-25 16:59:29 +0900 | [diff] [blame] | 5224 | // JNI libraries are uncompressed |
Jiyong Park | 52cd06f | 2019-11-11 10:14:32 +0900 | [diff] [blame] | 5225 | if args := appZipRule.Args["jarArgs"]; !strings.Contains(args, "-L 0") { |
Jooyung Han | b7bebe2 | 2020-02-25 16:59:29 +0900 | [diff] [blame] | 5226 | t.Errorf("jni libs are not uncompressed for AppFoo") |
Jiyong Park | 52cd06f | 2019-11-11 10:14:32 +0900 | [diff] [blame] | 5227 | } |
Jooyung Han | b7bebe2 | 2020-02-25 16:59:29 +0900 | [diff] [blame] | 5228 | // JNI libraries including transitive deps are |
| 5229 | for _, jni := range []string{"libjni", "libfoo"} { |
Paul Duffin | afdd406 | 2021-03-30 19:44:07 +0100 | [diff] [blame] | 5230 | jniOutput := ctx.ModuleForTests(jni, "android_arm64_armv8-a_sdk_shared_apex10000").Module().(*cc.Module).OutputFile().RelativeToTop() |
Jooyung Han | b7bebe2 | 2020-02-25 16:59:29 +0900 | [diff] [blame] | 5231 | // ... embedded inside APK (jnilibs.zip) |
| 5232 | ensureListContains(t, appZipRule.Implicits.Strings(), jniOutput.String()) |
| 5233 | // ... and not directly inside the APEX |
| 5234 | ensureNotContains(t, copyCmds, "image.apex/lib64/"+jni+".so") |
| 5235 | } |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 5236 | } |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5237 | |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 5238 | func TestApexWithAppImports(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5239 | ctx := testApex(t, ` |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 5240 | apex { |
| 5241 | name: "myapex", |
| 5242 | key: "myapex.key", |
| 5243 | apps: [ |
| 5244 | "AppFooPrebuilt", |
| 5245 | "AppFooPrivPrebuilt", |
| 5246 | ], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5247 | updatable: false, |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 5248 | } |
| 5249 | |
| 5250 | apex_key { |
| 5251 | name: "myapex.key", |
| 5252 | public_key: "testkey.avbpubkey", |
| 5253 | private_key: "testkey.pem", |
| 5254 | } |
| 5255 | |
| 5256 | android_app_import { |
| 5257 | name: "AppFooPrebuilt", |
| 5258 | apk: "PrebuiltAppFoo.apk", |
| 5259 | presigned: true, |
| 5260 | dex_preopt: { |
| 5261 | enabled: false, |
| 5262 | }, |
Jiyong Park | 592a6a4 | 2020-04-21 22:34:28 +0900 | [diff] [blame] | 5263 | apex_available: ["myapex"], |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 5264 | } |
| 5265 | |
| 5266 | android_app_import { |
| 5267 | name: "AppFooPrivPrebuilt", |
| 5268 | apk: "PrebuiltAppFooPriv.apk", |
| 5269 | privileged: true, |
| 5270 | presigned: true, |
| 5271 | dex_preopt: { |
| 5272 | enabled: false, |
| 5273 | }, |
Jooyung Han | 39ee119 | 2020-03-23 20:21:11 +0900 | [diff] [blame] | 5274 | filename: "AwesomePrebuiltAppFooPriv.apk", |
Jiyong Park | 592a6a4 | 2020-04-21 22:34:28 +0900 | [diff] [blame] | 5275 | apex_available: ["myapex"], |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 5276 | } |
| 5277 | `) |
| 5278 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 5279 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 5280 | apexRule := module.Rule("apexRule") |
| 5281 | copyCmds := apexRule.Args["copy_commands"] |
| 5282 | |
| 5283 | ensureContains(t, copyCmds, "image.apex/app/AppFooPrebuilt/AppFooPrebuilt.apk") |
Jooyung Han | 39ee119 | 2020-03-23 20:21:11 +0900 | [diff] [blame] | 5284 | ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPrivPrebuilt/AwesomePrebuiltAppFooPriv.apk") |
| 5285 | } |
| 5286 | |
| 5287 | func TestApexWithAppImportsPrefer(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5288 | ctx := testApex(t, ` |
Jooyung Han | 39ee119 | 2020-03-23 20:21:11 +0900 | [diff] [blame] | 5289 | apex { |
| 5290 | name: "myapex", |
| 5291 | key: "myapex.key", |
| 5292 | apps: [ |
| 5293 | "AppFoo", |
| 5294 | ], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5295 | updatable: false, |
Jooyung Han | 39ee119 | 2020-03-23 20:21:11 +0900 | [diff] [blame] | 5296 | } |
| 5297 | |
| 5298 | apex_key { |
| 5299 | name: "myapex.key", |
| 5300 | public_key: "testkey.avbpubkey", |
| 5301 | private_key: "testkey.pem", |
| 5302 | } |
| 5303 | |
| 5304 | android_app { |
| 5305 | name: "AppFoo", |
| 5306 | srcs: ["foo/bar/MyClass.java"], |
| 5307 | sdk_version: "none", |
| 5308 | system_modules: "none", |
| 5309 | apex_available: [ "myapex" ], |
| 5310 | } |
| 5311 | |
| 5312 | android_app_import { |
| 5313 | name: "AppFoo", |
| 5314 | apk: "AppFooPrebuilt.apk", |
| 5315 | filename: "AppFooPrebuilt.apk", |
| 5316 | presigned: true, |
| 5317 | prefer: true, |
Jiyong Park | 592a6a4 | 2020-04-21 22:34:28 +0900 | [diff] [blame] | 5318 | apex_available: ["myapex"], |
Jooyung Han | 39ee119 | 2020-03-23 20:21:11 +0900 | [diff] [blame] | 5319 | } |
| 5320 | `, withFiles(map[string][]byte{ |
| 5321 | "AppFooPrebuilt.apk": nil, |
| 5322 | })) |
| 5323 | |
| 5324 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
Jooyung Han | 86feead | 2021-03-08 13:11:48 +0900 | [diff] [blame] | 5325 | "app/AppFoo/AppFooPrebuilt.apk", |
Jooyung Han | 39ee119 | 2020-03-23 20:21:11 +0900 | [diff] [blame] | 5326 | }) |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5327 | } |
| 5328 | |
Dario Freni | 6f3937c | 2019-12-20 22:58:03 +0000 | [diff] [blame] | 5329 | func TestApexWithTestHelperApp(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5330 | ctx := testApex(t, ` |
Dario Freni | 6f3937c | 2019-12-20 22:58:03 +0000 | [diff] [blame] | 5331 | apex { |
| 5332 | name: "myapex", |
| 5333 | key: "myapex.key", |
| 5334 | apps: [ |
| 5335 | "TesterHelpAppFoo", |
| 5336 | ], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5337 | updatable: false, |
Dario Freni | 6f3937c | 2019-12-20 22:58:03 +0000 | [diff] [blame] | 5338 | } |
| 5339 | |
| 5340 | apex_key { |
| 5341 | name: "myapex.key", |
| 5342 | public_key: "testkey.avbpubkey", |
| 5343 | private_key: "testkey.pem", |
| 5344 | } |
| 5345 | |
| 5346 | android_test_helper_app { |
| 5347 | name: "TesterHelpAppFoo", |
| 5348 | srcs: ["foo/bar/MyClass.java"], |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 5349 | apex_available: [ "myapex" ], |
Dario Freni | 6f3937c | 2019-12-20 22:58:03 +0000 | [diff] [blame] | 5350 | } |
| 5351 | |
| 5352 | `) |
| 5353 | |
| 5354 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
| 5355 | apexRule := module.Rule("apexRule") |
| 5356 | copyCmds := apexRule.Args["copy_commands"] |
| 5357 | |
| 5358 | ensureContains(t, copyCmds, "image.apex/app/TesterHelpAppFoo/TesterHelpAppFoo.apk") |
| 5359 | } |
| 5360 | |
Jooyung Han | 18020ea | 2019-11-13 10:50:48 +0900 | [diff] [blame] | 5361 | func TestApexPropertiesShouldBeDefaultable(t *testing.T) { |
| 5362 | // libfoo's apex_available comes from cc_defaults |
Steven Moreland | 6e36cd6 | 2020-10-22 01:08:35 +0000 | [diff] [blame] | 5363 | testApexError(t, `requires "libfoo" that doesn't list the APEX under 'apex_available'.`, ` |
Jooyung Han | 18020ea | 2019-11-13 10:50:48 +0900 | [diff] [blame] | 5364 | apex { |
| 5365 | name: "myapex", |
| 5366 | key: "myapex.key", |
| 5367 | native_shared_libs: ["libfoo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5368 | updatable: false, |
Jooyung Han | 18020ea | 2019-11-13 10:50:48 +0900 | [diff] [blame] | 5369 | } |
| 5370 | |
| 5371 | apex_key { |
| 5372 | name: "myapex.key", |
| 5373 | public_key: "testkey.avbpubkey", |
| 5374 | private_key: "testkey.pem", |
| 5375 | } |
| 5376 | |
| 5377 | apex { |
| 5378 | name: "otherapex", |
| 5379 | key: "myapex.key", |
| 5380 | native_shared_libs: ["libfoo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5381 | updatable: false, |
Jooyung Han | 18020ea | 2019-11-13 10:50:48 +0900 | [diff] [blame] | 5382 | } |
| 5383 | |
| 5384 | cc_defaults { |
| 5385 | name: "libfoo-defaults", |
| 5386 | apex_available: ["otherapex"], |
| 5387 | } |
| 5388 | |
| 5389 | cc_library { |
| 5390 | name: "libfoo", |
| 5391 | defaults: ["libfoo-defaults"], |
| 5392 | stl: "none", |
| 5393 | system_shared_libs: [], |
| 5394 | }`) |
| 5395 | } |
| 5396 | |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 5397 | func TestApexAvailable_DirectDep(t *testing.T) { |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5398 | // libfoo is not available to myapex, but only to otherapex |
Steven Moreland | 6e36cd6 | 2020-10-22 01:08:35 +0000 | [diff] [blame] | 5399 | testApexError(t, "requires \"libfoo\" that doesn't list the APEX under 'apex_available'.", ` |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5400 | apex { |
| 5401 | name: "myapex", |
| 5402 | key: "myapex.key", |
| 5403 | native_shared_libs: ["libfoo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5404 | updatable: false, |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5405 | } |
| 5406 | |
| 5407 | apex_key { |
| 5408 | name: "myapex.key", |
| 5409 | public_key: "testkey.avbpubkey", |
| 5410 | private_key: "testkey.pem", |
| 5411 | } |
| 5412 | |
| 5413 | apex { |
| 5414 | name: "otherapex", |
| 5415 | key: "otherapex.key", |
| 5416 | native_shared_libs: ["libfoo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5417 | updatable: false, |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5418 | } |
| 5419 | |
| 5420 | apex_key { |
| 5421 | name: "otherapex.key", |
| 5422 | public_key: "testkey.avbpubkey", |
| 5423 | private_key: "testkey.pem", |
| 5424 | } |
| 5425 | |
| 5426 | cc_library { |
| 5427 | name: "libfoo", |
| 5428 | stl: "none", |
| 5429 | system_shared_libs: [], |
| 5430 | apex_available: ["otherapex"], |
| 5431 | }`) |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 5432 | } |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5433 | |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 5434 | func TestApexAvailable_IndirectDep(t *testing.T) { |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 5435 | // libbbaz is an indirect dep |
Jiyong Park | 767dbd9 | 2021-03-04 13:03:10 +0900 | [diff] [blame] | 5436 | testApexError(t, `requires "libbaz" that doesn't list the APEX under 'apex_available'.\n\nDependency path: |
Colin Cross | 6e511a9 | 2020-07-27 21:26:48 -0700 | [diff] [blame] | 5437 | .*via tag apex\.dependencyTag.*name:sharedLib.* |
Paul Duffin | df915ff | 2020-03-30 17:58:21 +0100 | [diff] [blame] | 5438 | .*-> libfoo.*link:shared.* |
Colin Cross | 6e511a9 | 2020-07-27 21:26:48 -0700 | [diff] [blame] | 5439 | .*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.* |
Paul Duffin | df915ff | 2020-03-30 17:58:21 +0100 | [diff] [blame] | 5440 | .*-> libbar.*link:shared.* |
Colin Cross | 6e511a9 | 2020-07-27 21:26:48 -0700 | [diff] [blame] | 5441 | .*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.* |
Paul Duffin | 6534770 | 2020-03-31 15:23:40 +0100 | [diff] [blame] | 5442 | .*-> libbaz.*link:shared.*`, ` |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5443 | apex { |
| 5444 | name: "myapex", |
| 5445 | key: "myapex.key", |
| 5446 | native_shared_libs: ["libfoo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5447 | updatable: false, |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5448 | } |
| 5449 | |
| 5450 | apex_key { |
| 5451 | name: "myapex.key", |
| 5452 | public_key: "testkey.avbpubkey", |
| 5453 | private_key: "testkey.pem", |
| 5454 | } |
| 5455 | |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5456 | cc_library { |
| 5457 | name: "libfoo", |
| 5458 | stl: "none", |
| 5459 | shared_libs: ["libbar"], |
| 5460 | system_shared_libs: [], |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 5461 | apex_available: ["myapex"], |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5462 | } |
| 5463 | |
| 5464 | cc_library { |
| 5465 | name: "libbar", |
| 5466 | stl: "none", |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 5467 | shared_libs: ["libbaz"], |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5468 | system_shared_libs: [], |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 5469 | apex_available: ["myapex"], |
| 5470 | } |
| 5471 | |
| 5472 | cc_library { |
| 5473 | name: "libbaz", |
| 5474 | stl: "none", |
| 5475 | system_shared_libs: [], |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5476 | }`) |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 5477 | } |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5478 | |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 5479 | func TestApexAvailable_InvalidApexName(t *testing.T) { |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5480 | testApexError(t, "\"otherapex\" is not a valid module name", ` |
| 5481 | apex { |
| 5482 | name: "myapex", |
| 5483 | key: "myapex.key", |
| 5484 | native_shared_libs: ["libfoo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5485 | updatable: false, |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5486 | } |
| 5487 | |
| 5488 | apex_key { |
| 5489 | name: "myapex.key", |
| 5490 | public_key: "testkey.avbpubkey", |
| 5491 | private_key: "testkey.pem", |
| 5492 | } |
| 5493 | |
| 5494 | cc_library { |
| 5495 | name: "libfoo", |
| 5496 | stl: "none", |
| 5497 | system_shared_libs: [], |
| 5498 | apex_available: ["otherapex"], |
| 5499 | }`) |
| 5500 | |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 5501 | testApex(t, ` |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5502 | apex { |
| 5503 | name: "myapex", |
| 5504 | key: "myapex.key", |
| 5505 | native_shared_libs: ["libfoo", "libbar"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5506 | updatable: false, |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5507 | } |
| 5508 | |
| 5509 | apex_key { |
| 5510 | name: "myapex.key", |
| 5511 | public_key: "testkey.avbpubkey", |
| 5512 | private_key: "testkey.pem", |
| 5513 | } |
| 5514 | |
| 5515 | cc_library { |
| 5516 | name: "libfoo", |
| 5517 | stl: "none", |
| 5518 | system_shared_libs: [], |
Jiyong Park | 323a4c3 | 2020-03-01 17:29:06 +0900 | [diff] [blame] | 5519 | runtime_libs: ["libbaz"], |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5520 | apex_available: ["myapex"], |
| 5521 | } |
| 5522 | |
| 5523 | cc_library { |
| 5524 | name: "libbar", |
| 5525 | stl: "none", |
| 5526 | system_shared_libs: [], |
| 5527 | apex_available: ["//apex_available:anyapex"], |
Jiyong Park | 323a4c3 | 2020-03-01 17:29:06 +0900 | [diff] [blame] | 5528 | } |
| 5529 | |
| 5530 | cc_library { |
| 5531 | name: "libbaz", |
| 5532 | stl: "none", |
| 5533 | system_shared_libs: [], |
| 5534 | stubs: { |
| 5535 | versions: ["10", "20", "30"], |
| 5536 | }, |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5537 | }`) |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 5538 | } |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5539 | |
Jiyong Park | 89e850a | 2020-04-07 16:37:39 +0900 | [diff] [blame] | 5540 | func TestApexAvailable_CheckForPlatform(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5541 | ctx := testApex(t, ` |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5542 | apex { |
| 5543 | name: "myapex", |
| 5544 | key: "myapex.key", |
Jiyong Park | 89e850a | 2020-04-07 16:37:39 +0900 | [diff] [blame] | 5545 | native_shared_libs: ["libbar", "libbaz"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5546 | updatable: false, |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5547 | } |
| 5548 | |
| 5549 | apex_key { |
| 5550 | name: "myapex.key", |
| 5551 | public_key: "testkey.avbpubkey", |
| 5552 | private_key: "testkey.pem", |
| 5553 | } |
| 5554 | |
| 5555 | cc_library { |
| 5556 | name: "libfoo", |
| 5557 | stl: "none", |
| 5558 | system_shared_libs: [], |
Jiyong Park | 89e850a | 2020-04-07 16:37:39 +0900 | [diff] [blame] | 5559 | shared_libs: ["libbar"], |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5560 | apex_available: ["//apex_available:platform"], |
Jiyong Park | 89e850a | 2020-04-07 16:37:39 +0900 | [diff] [blame] | 5561 | } |
| 5562 | |
| 5563 | cc_library { |
| 5564 | name: "libfoo2", |
| 5565 | stl: "none", |
| 5566 | system_shared_libs: [], |
| 5567 | shared_libs: ["libbaz"], |
| 5568 | apex_available: ["//apex_available:platform"], |
| 5569 | } |
| 5570 | |
| 5571 | cc_library { |
| 5572 | name: "libbar", |
| 5573 | stl: "none", |
| 5574 | system_shared_libs: [], |
| 5575 | apex_available: ["myapex"], |
| 5576 | } |
| 5577 | |
| 5578 | cc_library { |
| 5579 | name: "libbaz", |
| 5580 | stl: "none", |
| 5581 | system_shared_libs: [], |
| 5582 | apex_available: ["myapex"], |
| 5583 | stubs: { |
| 5584 | versions: ["1"], |
| 5585 | }, |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5586 | }`) |
| 5587 | |
Jiyong Park | 89e850a | 2020-04-07 16:37:39 +0900 | [diff] [blame] | 5588 | // libfoo shouldn't be available to platform even though it has "//apex_available:platform", |
| 5589 | // because it depends on libbar which isn't available to platform |
| 5590 | libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module) |
| 5591 | if libfoo.NotAvailableForPlatform() != true { |
| 5592 | t.Errorf("%q shouldn't be available to platform", libfoo.String()) |
| 5593 | } |
| 5594 | |
| 5595 | // libfoo2 however can be available to platform because it depends on libbaz which provides |
| 5596 | // stubs |
| 5597 | libfoo2 := ctx.ModuleForTests("libfoo2", "android_arm64_armv8-a_shared").Module().(*cc.Module) |
| 5598 | if libfoo2.NotAvailableForPlatform() == true { |
| 5599 | t.Errorf("%q should be available to platform", libfoo2.String()) |
| 5600 | } |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 5601 | } |
Jiyong Park | a90ca00 | 2019-10-07 15:47:24 +0900 | [diff] [blame] | 5602 | |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 5603 | func TestApexAvailable_CreatedForApex(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5604 | ctx := testApex(t, ` |
Jiyong Park | a90ca00 | 2019-10-07 15:47:24 +0900 | [diff] [blame] | 5605 | apex { |
| 5606 | name: "myapex", |
| 5607 | key: "myapex.key", |
| 5608 | native_shared_libs: ["libfoo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5609 | updatable: false, |
Jiyong Park | a90ca00 | 2019-10-07 15:47:24 +0900 | [diff] [blame] | 5610 | } |
| 5611 | |
| 5612 | apex_key { |
| 5613 | name: "myapex.key", |
| 5614 | public_key: "testkey.avbpubkey", |
| 5615 | private_key: "testkey.pem", |
| 5616 | } |
| 5617 | |
| 5618 | cc_library { |
| 5619 | name: "libfoo", |
| 5620 | stl: "none", |
| 5621 | system_shared_libs: [], |
| 5622 | apex_available: ["myapex"], |
| 5623 | static: { |
| 5624 | apex_available: ["//apex_available:platform"], |
| 5625 | }, |
| 5626 | }`) |
| 5627 | |
Jiyong Park | 89e850a | 2020-04-07 16:37:39 +0900 | [diff] [blame] | 5628 | libfooShared := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module) |
| 5629 | if libfooShared.NotAvailableForPlatform() != true { |
| 5630 | t.Errorf("%q shouldn't be available to platform", libfooShared.String()) |
| 5631 | } |
| 5632 | libfooStatic := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_static").Module().(*cc.Module) |
| 5633 | if libfooStatic.NotAvailableForPlatform() != false { |
| 5634 | t.Errorf("%q should be available to platform", libfooStatic.String()) |
| 5635 | } |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5636 | } |
| 5637 | |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 5638 | func TestOverrideApex(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5639 | ctx := testApex(t, ` |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 5640 | apex { |
| 5641 | name: "myapex", |
| 5642 | key: "myapex.key", |
| 5643 | apps: ["app"], |
Jaewoong Jung | 7abcf8e | 2019-12-19 17:32:06 -0800 | [diff] [blame] | 5644 | overrides: ["oldapex"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5645 | updatable: false, |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 5646 | } |
| 5647 | |
| 5648 | override_apex { |
| 5649 | name: "override_myapex", |
| 5650 | base: "myapex", |
| 5651 | apps: ["override_app"], |
Jaewoong Jung | 7abcf8e | 2019-12-19 17:32:06 -0800 | [diff] [blame] | 5652 | overrides: ["unknownapex"], |
Baligh Uddin | 004d717 | 2020-02-19 21:29:28 -0800 | [diff] [blame] | 5653 | logging_parent: "com.foo.bar", |
Baligh Uddin | 5b57dba | 2020-03-15 13:01:05 -0700 | [diff] [blame] | 5654 | package_name: "test.overridden.package", |
Jaewoong Jung | 4cfdf7d | 2021-04-20 16:21:24 -0700 | [diff] [blame] | 5655 | key: "mynewapex.key", |
| 5656 | certificate: ":myapex.certificate", |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 5657 | } |
| 5658 | |
| 5659 | apex_key { |
| 5660 | name: "myapex.key", |
| 5661 | public_key: "testkey.avbpubkey", |
| 5662 | private_key: "testkey.pem", |
| 5663 | } |
| 5664 | |
Jaewoong Jung | 4cfdf7d | 2021-04-20 16:21:24 -0700 | [diff] [blame] | 5665 | apex_key { |
| 5666 | name: "mynewapex.key", |
| 5667 | public_key: "testkey2.avbpubkey", |
| 5668 | private_key: "testkey2.pem", |
| 5669 | } |
| 5670 | |
| 5671 | android_app_certificate { |
| 5672 | name: "myapex.certificate", |
| 5673 | certificate: "testkey", |
| 5674 | } |
| 5675 | |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 5676 | android_app { |
| 5677 | name: "app", |
| 5678 | srcs: ["foo/bar/MyClass.java"], |
| 5679 | package_name: "foo", |
| 5680 | sdk_version: "none", |
| 5681 | system_modules: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 5682 | apex_available: [ "myapex" ], |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 5683 | } |
| 5684 | |
| 5685 | override_android_app { |
| 5686 | name: "override_app", |
| 5687 | base: "app", |
| 5688 | package_name: "bar", |
| 5689 | } |
Jiyong Park | 20bacab | 2020-03-03 11:45:41 +0900 | [diff] [blame] | 5690 | `, withManifestPackageNameOverrides([]string{"myapex:com.android.myapex"})) |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 5691 | |
Jiyong Park | 317645e | 2019-12-05 13:20:58 +0900 | [diff] [blame] | 5692 | originalVariant := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(android.OverridableModule) |
| 5693 | overriddenVariant := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Module().(android.OverridableModule) |
| 5694 | if originalVariant.GetOverriddenBy() != "" { |
| 5695 | t.Errorf("GetOverriddenBy should be empty, but was %q", originalVariant.GetOverriddenBy()) |
| 5696 | } |
| 5697 | if overriddenVariant.GetOverriddenBy() != "override_myapex" { |
| 5698 | t.Errorf("GetOverriddenBy should be \"override_myapex\", but was %q", overriddenVariant.GetOverriddenBy()) |
| 5699 | } |
| 5700 | |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 5701 | module := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image") |
| 5702 | apexRule := module.Rule("apexRule") |
| 5703 | copyCmds := apexRule.Args["copy_commands"] |
| 5704 | |
| 5705 | ensureNotContains(t, copyCmds, "image.apex/app/app/app.apk") |
Jooyung Han | 39ee119 | 2020-03-23 20:21:11 +0900 | [diff] [blame] | 5706 | ensureContains(t, copyCmds, "image.apex/app/override_app/override_app.apk") |
Jaewoong Jung | 1670ca0 | 2019-11-22 14:50:42 -0800 | [diff] [blame] | 5707 | |
| 5708 | apexBundle := module.Module().(*apexBundle) |
| 5709 | name := apexBundle.Name() |
| 5710 | if name != "override_myapex" { |
| 5711 | t.Errorf("name should be \"override_myapex\", but was %q", name) |
| 5712 | } |
| 5713 | |
Baligh Uddin | 004d717 | 2020-02-19 21:29:28 -0800 | [diff] [blame] | 5714 | if apexBundle.overridableProperties.Logging_parent != "com.foo.bar" { |
| 5715 | t.Errorf("override_myapex should have logging parent (com.foo.bar), but was %q.", apexBundle.overridableProperties.Logging_parent) |
| 5716 | } |
| 5717 | |
Jiyong Park | 20bacab | 2020-03-03 11:45:41 +0900 | [diff] [blame] | 5718 | optFlags := apexRule.Args["opt_flags"] |
Baligh Uddin | 5b57dba | 2020-03-15 13:01:05 -0700 | [diff] [blame] | 5719 | ensureContains(t, optFlags, "--override_apk_package_name test.overridden.package") |
Jaewoong Jung | 4cfdf7d | 2021-04-20 16:21:24 -0700 | [diff] [blame] | 5720 | ensureContains(t, optFlags, "--pubkey testkey2.avbpubkey") |
| 5721 | |
| 5722 | signApkRule := module.Rule("signapk") |
| 5723 | ensureEquals(t, signApkRule.Args["certificates"], "testkey.x509.pem testkey.pk8") |
Jiyong Park | 20bacab | 2020-03-03 11:45:41 +0900 | [diff] [blame] | 5724 | |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 5725 | data := android.AndroidMkDataForTest(t, ctx, apexBundle) |
Jaewoong Jung | 1670ca0 | 2019-11-22 14:50:42 -0800 | [diff] [blame] | 5726 | var builder strings.Builder |
| 5727 | data.Custom(&builder, name, "TARGET_", "", data) |
| 5728 | androidMk := builder.String() |
Jiyong Park | f653b05 | 2019-11-18 15:39:01 +0900 | [diff] [blame] | 5729 | ensureContains(t, androidMk, "LOCAL_MODULE := override_app.override_myapex") |
Jaewoong Jung | 1670ca0 | 2019-11-22 14:50:42 -0800 | [diff] [blame] | 5730 | ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.override_myapex") |
| 5731 | ensureContains(t, androidMk, "LOCAL_MODULE_STEM := override_myapex.apex") |
Jaewoong Jung | 7abcf8e | 2019-12-19 17:32:06 -0800 | [diff] [blame] | 5732 | ensureContains(t, androidMk, "LOCAL_OVERRIDES_MODULES := unknownapex myapex") |
Jaewoong Jung | 1670ca0 | 2019-11-22 14:50:42 -0800 | [diff] [blame] | 5733 | ensureNotContains(t, androidMk, "LOCAL_MODULE := app.myapex") |
Jiyong Park | f653b05 | 2019-11-18 15:39:01 +0900 | [diff] [blame] | 5734 | ensureNotContains(t, androidMk, "LOCAL_MODULE := override_app.myapex") |
Jaewoong Jung | 1670ca0 | 2019-11-22 14:50:42 -0800 | [diff] [blame] | 5735 | ensureNotContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex") |
| 5736 | ensureNotContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.apex") |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 5737 | } |
| 5738 | |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 5739 | func TestLegacyAndroid10Support(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5740 | ctx := testApex(t, ` |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 5741 | apex { |
| 5742 | name: "myapex", |
| 5743 | key: "myapex.key", |
Peter Collingbourne | dc4f986 | 2020-02-12 17:13:25 -0800 | [diff] [blame] | 5744 | native_shared_libs: ["mylib"], |
Jooyung Han | 5417f77 | 2020-03-12 18:37:20 +0900 | [diff] [blame] | 5745 | min_sdk_version: "29", |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 5746 | } |
| 5747 | |
| 5748 | apex_key { |
| 5749 | name: "myapex.key", |
| 5750 | public_key: "testkey.avbpubkey", |
| 5751 | private_key: "testkey.pem", |
| 5752 | } |
Peter Collingbourne | dc4f986 | 2020-02-12 17:13:25 -0800 | [diff] [blame] | 5753 | |
| 5754 | cc_library { |
| 5755 | name: "mylib", |
| 5756 | srcs: ["mylib.cpp"], |
| 5757 | stl: "libc++", |
| 5758 | system_shared_libs: [], |
| 5759 | apex_available: [ "myapex" ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 5760 | min_sdk_version: "29", |
Peter Collingbourne | dc4f986 | 2020-02-12 17:13:25 -0800 | [diff] [blame] | 5761 | } |
Peter Collingbourne | dc4f986 | 2020-02-12 17:13:25 -0800 | [diff] [blame] | 5762 | `, withUnbundledBuild) |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 5763 | |
| 5764 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
| 5765 | args := module.Rule("apexRule").Args |
| 5766 | ensureContains(t, args["opt_flags"], "--manifest_json "+module.Output("apex_manifest.json").Output.String()) |
Dario Freni | e354690 | 2020-01-14 23:50:25 +0000 | [diff] [blame] | 5767 | ensureNotContains(t, args["opt_flags"], "--no_hashtree") |
Peter Collingbourne | dc4f986 | 2020-02-12 17:13:25 -0800 | [diff] [blame] | 5768 | |
| 5769 | // The copies of the libraries in the apex should have one more dependency than |
| 5770 | // the ones outside the apex, namely the unwinder. Ideally we should check |
| 5771 | // the dependency names directly here but for some reason the names are blank in |
| 5772 | // this test. |
| 5773 | for _, lib := range []string{"libc++", "mylib"} { |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 5774 | apexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared_apex29").Rule("ld").Implicits |
Peter Collingbourne | dc4f986 | 2020-02-12 17:13:25 -0800 | [diff] [blame] | 5775 | nonApexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared").Rule("ld").Implicits |
| 5776 | if len(apexImplicits) != len(nonApexImplicits)+1 { |
| 5777 | t.Errorf("%q missing unwinder dep", lib) |
| 5778 | } |
| 5779 | } |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 5780 | } |
| 5781 | |
Paul Duffin | e05480a | 2021-03-08 15:07:14 +0000 | [diff] [blame] | 5782 | var filesForSdkLibrary = android.MockFS{ |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 5783 | "api/current.txt": nil, |
| 5784 | "api/removed.txt": nil, |
| 5785 | "api/system-current.txt": nil, |
| 5786 | "api/system-removed.txt": nil, |
| 5787 | "api/test-current.txt": nil, |
| 5788 | "api/test-removed.txt": nil, |
Paul Duffin | eedc5d5 | 2020-06-12 17:46:39 +0100 | [diff] [blame] | 5789 | |
Anton Hansson | dff2c78 | 2020-12-21 17:10:01 +0000 | [diff] [blame] | 5790 | "100/public/api/foo.txt": nil, |
| 5791 | "100/public/api/foo-removed.txt": nil, |
| 5792 | "100/system/api/foo.txt": nil, |
| 5793 | "100/system/api/foo-removed.txt": nil, |
| 5794 | |
Paul Duffin | eedc5d5 | 2020-06-12 17:46:39 +0100 | [diff] [blame] | 5795 | // For java_sdk_library_import |
| 5796 | "a.jar": nil, |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 5797 | } |
| 5798 | |
Jooyung Han | 58f26ab | 2019-12-18 15:34:32 +0900 | [diff] [blame] | 5799 | func TestJavaSDKLibrary(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5800 | ctx := testApex(t, ` |
Jooyung Han | 58f26ab | 2019-12-18 15:34:32 +0900 | [diff] [blame] | 5801 | apex { |
| 5802 | name: "myapex", |
| 5803 | key: "myapex.key", |
| 5804 | java_libs: ["foo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5805 | updatable: false, |
Jooyung Han | 58f26ab | 2019-12-18 15:34:32 +0900 | [diff] [blame] | 5806 | } |
| 5807 | |
| 5808 | apex_key { |
| 5809 | name: "myapex.key", |
| 5810 | public_key: "testkey.avbpubkey", |
| 5811 | private_key: "testkey.pem", |
| 5812 | } |
| 5813 | |
| 5814 | java_sdk_library { |
| 5815 | name: "foo", |
| 5816 | srcs: ["a.java"], |
| 5817 | api_packages: ["foo"], |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 5818 | apex_available: [ "myapex" ], |
Jooyung Han | 58f26ab | 2019-12-18 15:34:32 +0900 | [diff] [blame] | 5819 | } |
Anton Hansson | dff2c78 | 2020-12-21 17:10:01 +0000 | [diff] [blame] | 5820 | |
| 5821 | prebuilt_apis { |
| 5822 | name: "sdk", |
| 5823 | api_dirs: ["100"], |
| 5824 | } |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 5825 | `, withFiles(filesForSdkLibrary)) |
Jooyung Han | 58f26ab | 2019-12-18 15:34:32 +0900 | [diff] [blame] | 5826 | |
| 5827 | // java_sdk_library installs both impl jar and permission XML |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 5828 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
Jooyung Han | 58f26ab | 2019-12-18 15:34:32 +0900 | [diff] [blame] | 5829 | "javalib/foo.jar", |
| 5830 | "etc/permissions/foo.xml", |
| 5831 | }) |
| 5832 | // Permission XML should point to the activated path of impl jar of java_sdk_library |
Jiyong Park | e383388 | 2020-02-17 17:28:10 +0900 | [diff] [blame] | 5833 | sdkLibrary := ctx.ModuleForTests("foo.xml", "android_common_myapex").Rule("java_sdk_xml") |
| 5834 | ensureContains(t, sdkLibrary.RuleParams.Command, `<library name=\"foo\" file=\"/apex/myapex/javalib/foo.jar\"`) |
Jooyung Han | 58f26ab | 2019-12-18 15:34:32 +0900 | [diff] [blame] | 5835 | } |
| 5836 | |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 5837 | func TestJavaSDKLibrary_WithinApex(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5838 | ctx := testApex(t, ` |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 5839 | apex { |
| 5840 | name: "myapex", |
| 5841 | key: "myapex.key", |
| 5842 | java_libs: ["foo", "bar"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5843 | updatable: false, |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 5844 | } |
| 5845 | |
| 5846 | apex_key { |
| 5847 | name: "myapex.key", |
| 5848 | public_key: "testkey.avbpubkey", |
| 5849 | private_key: "testkey.pem", |
| 5850 | } |
| 5851 | |
| 5852 | java_sdk_library { |
| 5853 | name: "foo", |
| 5854 | srcs: ["a.java"], |
| 5855 | api_packages: ["foo"], |
| 5856 | apex_available: ["myapex"], |
| 5857 | sdk_version: "none", |
| 5858 | system_modules: "none", |
| 5859 | } |
| 5860 | |
| 5861 | java_library { |
| 5862 | name: "bar", |
| 5863 | srcs: ["a.java"], |
| 5864 | libs: ["foo"], |
| 5865 | apex_available: ["myapex"], |
| 5866 | sdk_version: "none", |
| 5867 | system_modules: "none", |
| 5868 | } |
Anton Hansson | dff2c78 | 2020-12-21 17:10:01 +0000 | [diff] [blame] | 5869 | |
| 5870 | prebuilt_apis { |
| 5871 | name: "sdk", |
| 5872 | api_dirs: ["100"], |
| 5873 | } |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 5874 | `, withFiles(filesForSdkLibrary)) |
| 5875 | |
| 5876 | // java_sdk_library installs both impl jar and permission XML |
| 5877 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 5878 | "javalib/bar.jar", |
| 5879 | "javalib/foo.jar", |
| 5880 | "etc/permissions/foo.xml", |
| 5881 | }) |
| 5882 | |
| 5883 | // The bar library should depend on the implementation jar. |
| 5884 | barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac") |
Paul Duffin | cf8d7db | 2021-03-29 00:29:53 +0100 | [diff] [blame] | 5885 | if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) { |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 5886 | t.Errorf("expected %q, found %#q", expected, actual) |
| 5887 | } |
| 5888 | } |
| 5889 | |
| 5890 | func TestJavaSDKLibrary_CrossBoundary(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5891 | ctx := testApex(t, ` |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 5892 | apex { |
| 5893 | name: "myapex", |
| 5894 | key: "myapex.key", |
| 5895 | java_libs: ["foo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5896 | updatable: false, |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 5897 | } |
| 5898 | |
| 5899 | apex_key { |
| 5900 | name: "myapex.key", |
| 5901 | public_key: "testkey.avbpubkey", |
| 5902 | private_key: "testkey.pem", |
| 5903 | } |
| 5904 | |
| 5905 | java_sdk_library { |
| 5906 | name: "foo", |
| 5907 | srcs: ["a.java"], |
| 5908 | api_packages: ["foo"], |
| 5909 | apex_available: ["myapex"], |
| 5910 | sdk_version: "none", |
| 5911 | system_modules: "none", |
| 5912 | } |
| 5913 | |
| 5914 | java_library { |
| 5915 | name: "bar", |
| 5916 | srcs: ["a.java"], |
| 5917 | libs: ["foo"], |
| 5918 | sdk_version: "none", |
| 5919 | system_modules: "none", |
| 5920 | } |
Anton Hansson | dff2c78 | 2020-12-21 17:10:01 +0000 | [diff] [blame] | 5921 | |
| 5922 | prebuilt_apis { |
| 5923 | name: "sdk", |
| 5924 | api_dirs: ["100"], |
| 5925 | } |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 5926 | `, withFiles(filesForSdkLibrary)) |
| 5927 | |
| 5928 | // java_sdk_library installs both impl jar and permission XML |
| 5929 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 5930 | "javalib/foo.jar", |
| 5931 | "etc/permissions/foo.xml", |
| 5932 | }) |
| 5933 | |
| 5934 | // The bar library should depend on the stubs jar. |
| 5935 | barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac") |
Paul Duffin | cf8d7db | 2021-03-29 00:29:53 +0100 | [diff] [blame] | 5936 | if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) { |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 5937 | t.Errorf("expected %q, found %#q", expected, actual) |
| 5938 | } |
| 5939 | } |
| 5940 | |
Paul Duffin | eedc5d5 | 2020-06-12 17:46:39 +0100 | [diff] [blame] | 5941 | func TestJavaSDKLibrary_ImportPreferred(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5942 | ctx := testApex(t, ` |
Anton Hansson | dff2c78 | 2020-12-21 17:10:01 +0000 | [diff] [blame] | 5943 | prebuilt_apis { |
| 5944 | name: "sdk", |
| 5945 | api_dirs: ["100"], |
| 5946 | }`, |
Paul Duffin | eedc5d5 | 2020-06-12 17:46:39 +0100 | [diff] [blame] | 5947 | withFiles(map[string][]byte{ |
| 5948 | "apex/a.java": nil, |
| 5949 | "apex/apex_manifest.json": nil, |
| 5950 | "apex/Android.bp": []byte(` |
| 5951 | package { |
| 5952 | default_visibility: ["//visibility:private"], |
| 5953 | } |
| 5954 | |
| 5955 | apex { |
| 5956 | name: "myapex", |
| 5957 | key: "myapex.key", |
| 5958 | java_libs: ["foo", "bar"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5959 | updatable: false, |
Paul Duffin | eedc5d5 | 2020-06-12 17:46:39 +0100 | [diff] [blame] | 5960 | } |
| 5961 | |
| 5962 | apex_key { |
| 5963 | name: "myapex.key", |
| 5964 | public_key: "testkey.avbpubkey", |
| 5965 | private_key: "testkey.pem", |
| 5966 | } |
| 5967 | |
| 5968 | java_library { |
| 5969 | name: "bar", |
| 5970 | srcs: ["a.java"], |
| 5971 | libs: ["foo"], |
| 5972 | apex_available: ["myapex"], |
| 5973 | sdk_version: "none", |
| 5974 | system_modules: "none", |
| 5975 | } |
| 5976 | `), |
| 5977 | "source/a.java": nil, |
| 5978 | "source/api/current.txt": nil, |
| 5979 | "source/api/removed.txt": nil, |
| 5980 | "source/Android.bp": []byte(` |
| 5981 | package { |
| 5982 | default_visibility: ["//visibility:private"], |
| 5983 | } |
| 5984 | |
| 5985 | java_sdk_library { |
| 5986 | name: "foo", |
| 5987 | visibility: ["//apex"], |
| 5988 | srcs: ["a.java"], |
| 5989 | api_packages: ["foo"], |
| 5990 | apex_available: ["myapex"], |
| 5991 | sdk_version: "none", |
| 5992 | system_modules: "none", |
| 5993 | public: { |
| 5994 | enabled: true, |
| 5995 | }, |
| 5996 | } |
| 5997 | `), |
| 5998 | "prebuilt/a.jar": nil, |
| 5999 | "prebuilt/Android.bp": []byte(` |
| 6000 | package { |
| 6001 | default_visibility: ["//visibility:private"], |
| 6002 | } |
| 6003 | |
| 6004 | java_sdk_library_import { |
| 6005 | name: "foo", |
| 6006 | visibility: ["//apex", "//source"], |
| 6007 | apex_available: ["myapex"], |
| 6008 | prefer: true, |
| 6009 | public: { |
| 6010 | jars: ["a.jar"], |
| 6011 | }, |
| 6012 | } |
| 6013 | `), |
Anton Hansson | dff2c78 | 2020-12-21 17:10:01 +0000 | [diff] [blame] | 6014 | }), withFiles(filesForSdkLibrary), |
Paul Duffin | eedc5d5 | 2020-06-12 17:46:39 +0100 | [diff] [blame] | 6015 | ) |
| 6016 | |
| 6017 | // java_sdk_library installs both impl jar and permission XML |
| 6018 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 6019 | "javalib/bar.jar", |
| 6020 | "javalib/foo.jar", |
| 6021 | "etc/permissions/foo.xml", |
| 6022 | }) |
| 6023 | |
| 6024 | // The bar library should depend on the implementation jar. |
| 6025 | barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac") |
Paul Duffin | cf8d7db | 2021-03-29 00:29:53 +0100 | [diff] [blame] | 6026 | if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.impl\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) { |
Paul Duffin | eedc5d5 | 2020-06-12 17:46:39 +0100 | [diff] [blame] | 6027 | t.Errorf("expected %q, found %#q", expected, actual) |
| 6028 | } |
| 6029 | } |
| 6030 | |
| 6031 | func TestJavaSDKLibrary_ImportOnly(t *testing.T) { |
| 6032 | testApexError(t, `java_libs: "foo" is not configured to be compiled into dex`, ` |
| 6033 | apex { |
| 6034 | name: "myapex", |
| 6035 | key: "myapex.key", |
| 6036 | java_libs: ["foo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6037 | updatable: false, |
Paul Duffin | eedc5d5 | 2020-06-12 17:46:39 +0100 | [diff] [blame] | 6038 | } |
| 6039 | |
| 6040 | apex_key { |
| 6041 | name: "myapex.key", |
| 6042 | public_key: "testkey.avbpubkey", |
| 6043 | private_key: "testkey.pem", |
| 6044 | } |
| 6045 | |
| 6046 | java_sdk_library_import { |
| 6047 | name: "foo", |
| 6048 | apex_available: ["myapex"], |
| 6049 | prefer: true, |
| 6050 | public: { |
| 6051 | jars: ["a.jar"], |
| 6052 | }, |
| 6053 | } |
| 6054 | |
| 6055 | `, withFiles(filesForSdkLibrary)) |
| 6056 | } |
| 6057 | |
atrost | 6e12625 | 2020-01-27 17:01:16 +0000 | [diff] [blame] | 6058 | func TestCompatConfig(t *testing.T) { |
Paul Duffin | 284165a | 2021-03-29 01:50:31 +0100 | [diff] [blame] | 6059 | result := android.GroupFixturePreparers( |
| 6060 | prepareForApexTest, |
| 6061 | java.PrepareForTestWithPlatformCompatConfig, |
| 6062 | ).RunTestWithBp(t, ` |
atrost | 6e12625 | 2020-01-27 17:01:16 +0000 | [diff] [blame] | 6063 | apex { |
| 6064 | name: "myapex", |
| 6065 | key: "myapex.key", |
Paul Duffin | 3abc174 | 2021-03-15 19:32:23 +0000 | [diff] [blame] | 6066 | compat_configs: ["myjar-platform-compat-config"], |
atrost | 6e12625 | 2020-01-27 17:01:16 +0000 | [diff] [blame] | 6067 | java_libs: ["myjar"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6068 | updatable: false, |
atrost | 6e12625 | 2020-01-27 17:01:16 +0000 | [diff] [blame] | 6069 | } |
| 6070 | |
| 6071 | apex_key { |
| 6072 | name: "myapex.key", |
| 6073 | public_key: "testkey.avbpubkey", |
| 6074 | private_key: "testkey.pem", |
| 6075 | } |
| 6076 | |
| 6077 | platform_compat_config { |
| 6078 | name: "myjar-platform-compat-config", |
| 6079 | src: ":myjar", |
| 6080 | } |
| 6081 | |
| 6082 | java_library { |
| 6083 | name: "myjar", |
| 6084 | srcs: ["foo/bar/MyClass.java"], |
| 6085 | sdk_version: "none", |
| 6086 | system_modules: "none", |
atrost | 6e12625 | 2020-01-27 17:01:16 +0000 | [diff] [blame] | 6087 | apex_available: [ "myapex" ], |
| 6088 | } |
Paul Duffin | 1b29e00 | 2021-03-16 15:06:54 +0000 | [diff] [blame] | 6089 | |
| 6090 | // Make sure that a preferred prebuilt does not affect the apex contents. |
| 6091 | prebuilt_platform_compat_config { |
| 6092 | name: "myjar-platform-compat-config", |
| 6093 | metadata: "compat-config/metadata.xml", |
| 6094 | prefer: true, |
| 6095 | } |
atrost | 6e12625 | 2020-01-27 17:01:16 +0000 | [diff] [blame] | 6096 | `) |
Paul Duffin | a369c7b | 2021-03-09 03:08:05 +0000 | [diff] [blame] | 6097 | ctx := result.TestContext |
atrost | 6e12625 | 2020-01-27 17:01:16 +0000 | [diff] [blame] | 6098 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 6099 | "etc/compatconfig/myjar-platform-compat-config.xml", |
| 6100 | "javalib/myjar.jar", |
| 6101 | }) |
| 6102 | } |
| 6103 | |
Jiyong Park | 479321d | 2019-12-16 11:47:12 +0900 | [diff] [blame] | 6104 | func TestRejectNonInstallableJavaLibrary(t *testing.T) { |
| 6105 | testApexError(t, `"myjar" is not configured to be compiled into dex`, ` |
| 6106 | apex { |
| 6107 | name: "myapex", |
| 6108 | key: "myapex.key", |
| 6109 | java_libs: ["myjar"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6110 | updatable: false, |
Jiyong Park | 479321d | 2019-12-16 11:47:12 +0900 | [diff] [blame] | 6111 | } |
| 6112 | |
| 6113 | apex_key { |
| 6114 | name: "myapex.key", |
| 6115 | public_key: "testkey.avbpubkey", |
| 6116 | private_key: "testkey.pem", |
| 6117 | } |
| 6118 | |
| 6119 | java_library { |
| 6120 | name: "myjar", |
| 6121 | srcs: ["foo/bar/MyClass.java"], |
| 6122 | sdk_version: "none", |
| 6123 | system_modules: "none", |
Jiyong Park | 6b21c7d | 2020-02-11 09:16:01 +0900 | [diff] [blame] | 6124 | compile_dex: false, |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 6125 | apex_available: ["myapex"], |
Jiyong Park | 479321d | 2019-12-16 11:47:12 +0900 | [diff] [blame] | 6126 | } |
| 6127 | `) |
| 6128 | } |
| 6129 | |
Jiyong Park | 7afd107 | 2019-12-30 16:56:33 +0900 | [diff] [blame] | 6130 | func TestCarryRequiredModuleNames(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6131 | ctx := testApex(t, ` |
Jiyong Park | 7afd107 | 2019-12-30 16:56:33 +0900 | [diff] [blame] | 6132 | apex { |
| 6133 | name: "myapex", |
| 6134 | key: "myapex.key", |
| 6135 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6136 | updatable: false, |
Jiyong Park | 7afd107 | 2019-12-30 16:56:33 +0900 | [diff] [blame] | 6137 | } |
| 6138 | |
| 6139 | apex_key { |
| 6140 | name: "myapex.key", |
| 6141 | public_key: "testkey.avbpubkey", |
| 6142 | private_key: "testkey.pem", |
| 6143 | } |
| 6144 | |
| 6145 | cc_library { |
| 6146 | name: "mylib", |
| 6147 | srcs: ["mylib.cpp"], |
| 6148 | system_shared_libs: [], |
| 6149 | stl: "none", |
| 6150 | required: ["a", "b"], |
| 6151 | host_required: ["c", "d"], |
| 6152 | target_required: ["e", "f"], |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 6153 | apex_available: [ "myapex" ], |
Jiyong Park | 7afd107 | 2019-12-30 16:56:33 +0900 | [diff] [blame] | 6154 | } |
| 6155 | `) |
| 6156 | |
| 6157 | apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 6158 | data := android.AndroidMkDataForTest(t, ctx, apexBundle) |
Jiyong Park | 7afd107 | 2019-12-30 16:56:33 +0900 | [diff] [blame] | 6159 | name := apexBundle.BaseModuleName() |
| 6160 | prefix := "TARGET_" |
| 6161 | var builder strings.Builder |
| 6162 | data.Custom(&builder, name, prefix, "", data) |
| 6163 | androidMk := builder.String() |
| 6164 | ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += a b\n") |
| 6165 | ensureContains(t, androidMk, "LOCAL_HOST_REQUIRED_MODULES += c d\n") |
| 6166 | ensureContains(t, androidMk, "LOCAL_TARGET_REQUIRED_MODULES += e f\n") |
| 6167 | } |
| 6168 | |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6169 | func TestSymlinksFromApexToSystem(t *testing.T) { |
| 6170 | bp := ` |
| 6171 | apex { |
| 6172 | name: "myapex", |
| 6173 | key: "myapex.key", |
| 6174 | native_shared_libs: ["mylib"], |
| 6175 | java_libs: ["myjar"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6176 | updatable: false, |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6177 | } |
| 6178 | |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 6179 | apex { |
| 6180 | name: "myapex.updatable", |
| 6181 | key: "myapex.key", |
| 6182 | native_shared_libs: ["mylib"], |
| 6183 | java_libs: ["myjar"], |
| 6184 | updatable: true, |
Jooyung Han | 548640b | 2020-04-27 12:10:30 +0900 | [diff] [blame] | 6185 | min_sdk_version: "current", |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 6186 | } |
| 6187 | |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6188 | apex_key { |
| 6189 | name: "myapex.key", |
| 6190 | public_key: "testkey.avbpubkey", |
| 6191 | private_key: "testkey.pem", |
| 6192 | } |
| 6193 | |
| 6194 | cc_library { |
| 6195 | name: "mylib", |
| 6196 | srcs: ["mylib.cpp"], |
| 6197 | shared_libs: ["myotherlib"], |
| 6198 | system_shared_libs: [], |
| 6199 | stl: "none", |
| 6200 | apex_available: [ |
| 6201 | "myapex", |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 6202 | "myapex.updatable", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6203 | "//apex_available:platform", |
| 6204 | ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 6205 | min_sdk_version: "current", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6206 | } |
| 6207 | |
| 6208 | cc_library { |
| 6209 | name: "myotherlib", |
| 6210 | srcs: ["mylib.cpp"], |
| 6211 | system_shared_libs: [], |
| 6212 | stl: "none", |
| 6213 | apex_available: [ |
| 6214 | "myapex", |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 6215 | "myapex.updatable", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6216 | "//apex_available:platform", |
| 6217 | ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 6218 | min_sdk_version: "current", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6219 | } |
| 6220 | |
| 6221 | java_library { |
| 6222 | name: "myjar", |
| 6223 | srcs: ["foo/bar/MyClass.java"], |
| 6224 | sdk_version: "none", |
| 6225 | system_modules: "none", |
| 6226 | libs: ["myotherjar"], |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6227 | apex_available: [ |
| 6228 | "myapex", |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 6229 | "myapex.updatable", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6230 | "//apex_available:platform", |
| 6231 | ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 6232 | min_sdk_version: "current", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6233 | } |
| 6234 | |
| 6235 | java_library { |
| 6236 | name: "myotherjar", |
| 6237 | srcs: ["foo/bar/MyClass.java"], |
| 6238 | sdk_version: "none", |
| 6239 | system_modules: "none", |
| 6240 | apex_available: [ |
| 6241 | "myapex", |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 6242 | "myapex.updatable", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6243 | "//apex_available:platform", |
| 6244 | ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 6245 | min_sdk_version: "current", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6246 | } |
| 6247 | ` |
| 6248 | |
| 6249 | ensureRealfileExists := func(t *testing.T, files []fileInApex, file string) { |
| 6250 | for _, f := range files { |
| 6251 | if f.path == file { |
| 6252 | if f.isLink { |
| 6253 | t.Errorf("%q is not a real file", file) |
| 6254 | } |
| 6255 | return |
| 6256 | } |
| 6257 | } |
| 6258 | t.Errorf("%q is not found", file) |
| 6259 | } |
| 6260 | |
| 6261 | ensureSymlinkExists := func(t *testing.T, files []fileInApex, file string) { |
| 6262 | for _, f := range files { |
| 6263 | if f.path == file { |
| 6264 | if !f.isLink { |
| 6265 | t.Errorf("%q is not a symlink", file) |
| 6266 | } |
| 6267 | return |
| 6268 | } |
| 6269 | } |
| 6270 | t.Errorf("%q is not found", file) |
| 6271 | } |
| 6272 | |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 6273 | // For unbundled build, symlink shouldn't exist regardless of whether an APEX |
| 6274 | // is updatable or not |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6275 | ctx := testApex(t, bp, withUnbundledBuild) |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 6276 | files := getFiles(t, ctx, "myapex", "android_common_myapex_image") |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6277 | ensureRealfileExists(t, files, "javalib/myjar.jar") |
| 6278 | ensureRealfileExists(t, files, "lib64/mylib.so") |
| 6279 | ensureRealfileExists(t, files, "lib64/myotherlib.so") |
| 6280 | |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 6281 | files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image") |
| 6282 | ensureRealfileExists(t, files, "javalib/myjar.jar") |
| 6283 | ensureRealfileExists(t, files, "lib64/mylib.so") |
| 6284 | ensureRealfileExists(t, files, "lib64/myotherlib.so") |
| 6285 | |
| 6286 | // For bundled build, symlink to the system for the non-updatable APEXes only |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6287 | ctx = testApex(t, bp) |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 6288 | files = getFiles(t, ctx, "myapex", "android_common_myapex_image") |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6289 | ensureRealfileExists(t, files, "javalib/myjar.jar") |
| 6290 | ensureRealfileExists(t, files, "lib64/mylib.so") |
| 6291 | ensureSymlinkExists(t, files, "lib64/myotherlib.so") // this is symlink |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 6292 | |
| 6293 | files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image") |
| 6294 | ensureRealfileExists(t, files, "javalib/myjar.jar") |
| 6295 | ensureRealfileExists(t, files, "lib64/mylib.so") |
| 6296 | ensureRealfileExists(t, files, "lib64/myotherlib.so") // this is a real file |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6297 | } |
| 6298 | |
Yo Chiang | e812805 | 2020-07-23 20:09:18 +0800 | [diff] [blame] | 6299 | func TestSymlinksFromApexToSystemRequiredModuleNames(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6300 | ctx := testApex(t, ` |
Yo Chiang | e812805 | 2020-07-23 20:09:18 +0800 | [diff] [blame] | 6301 | apex { |
| 6302 | name: "myapex", |
| 6303 | key: "myapex.key", |
| 6304 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6305 | updatable: false, |
Yo Chiang | e812805 | 2020-07-23 20:09:18 +0800 | [diff] [blame] | 6306 | } |
| 6307 | |
| 6308 | apex_key { |
| 6309 | name: "myapex.key", |
| 6310 | public_key: "testkey.avbpubkey", |
| 6311 | private_key: "testkey.pem", |
| 6312 | } |
| 6313 | |
| 6314 | cc_library_shared { |
| 6315 | name: "mylib", |
| 6316 | srcs: ["mylib.cpp"], |
| 6317 | shared_libs: ["myotherlib"], |
| 6318 | system_shared_libs: [], |
| 6319 | stl: "none", |
| 6320 | apex_available: [ |
| 6321 | "myapex", |
| 6322 | "//apex_available:platform", |
| 6323 | ], |
| 6324 | } |
| 6325 | |
| 6326 | cc_prebuilt_library_shared { |
| 6327 | name: "myotherlib", |
| 6328 | srcs: ["prebuilt.so"], |
| 6329 | system_shared_libs: [], |
| 6330 | stl: "none", |
| 6331 | apex_available: [ |
| 6332 | "myapex", |
| 6333 | "//apex_available:platform", |
| 6334 | ], |
| 6335 | } |
| 6336 | `) |
| 6337 | |
| 6338 | apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 6339 | data := android.AndroidMkDataForTest(t, ctx, apexBundle) |
Yo Chiang | e812805 | 2020-07-23 20:09:18 +0800 | [diff] [blame] | 6340 | var builder strings.Builder |
| 6341 | data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data) |
| 6342 | androidMk := builder.String() |
| 6343 | // `myotherlib` is added to `myapex` as symlink |
| 6344 | ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n") |
| 6345 | ensureNotContains(t, androidMk, "LOCAL_MODULE := prebuilt_myotherlib.myapex\n") |
| 6346 | ensureNotContains(t, androidMk, "LOCAL_MODULE := myotherlib.myapex\n") |
| 6347 | // `myapex` should have `myotherlib` in its required line, not `prebuilt_myotherlib` |
Jiyong Park | 57621b2 | 2021-01-20 20:33:11 +0900 | [diff] [blame] | 6348 | ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += mylib.myapex:64 myotherlib:64 apex_manifest.pb.myapex apex_pubkey.myapex\n") |
Yo Chiang | e812805 | 2020-07-23 20:09:18 +0800 | [diff] [blame] | 6349 | } |
| 6350 | |
Jooyung Han | 643adc4 | 2020-02-27 13:50:06 +0900 | [diff] [blame] | 6351 | func TestApexWithJniLibs(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6352 | ctx := testApex(t, ` |
Jooyung Han | 643adc4 | 2020-02-27 13:50:06 +0900 | [diff] [blame] | 6353 | apex { |
| 6354 | name: "myapex", |
| 6355 | key: "myapex.key", |
| 6356 | jni_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6357 | updatable: false, |
Jooyung Han | 643adc4 | 2020-02-27 13:50:06 +0900 | [diff] [blame] | 6358 | } |
| 6359 | |
| 6360 | apex_key { |
| 6361 | name: "myapex.key", |
| 6362 | public_key: "testkey.avbpubkey", |
| 6363 | private_key: "testkey.pem", |
| 6364 | } |
| 6365 | |
| 6366 | cc_library { |
| 6367 | name: "mylib", |
| 6368 | srcs: ["mylib.cpp"], |
| 6369 | shared_libs: ["mylib2"], |
| 6370 | system_shared_libs: [], |
| 6371 | stl: "none", |
| 6372 | apex_available: [ "myapex" ], |
| 6373 | } |
| 6374 | |
| 6375 | cc_library { |
| 6376 | name: "mylib2", |
| 6377 | srcs: ["mylib.cpp"], |
| 6378 | system_shared_libs: [], |
| 6379 | stl: "none", |
| 6380 | apex_available: [ "myapex" ], |
| 6381 | } |
| 6382 | `) |
| 6383 | |
| 6384 | rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule") |
| 6385 | // Notice mylib2.so (transitive dep) is not added as a jni_lib |
| 6386 | ensureEquals(t, rule.Args["opt"], "-a jniLibs mylib.so") |
| 6387 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 6388 | "lib64/mylib.so", |
| 6389 | "lib64/mylib2.so", |
| 6390 | }) |
| 6391 | } |
| 6392 | |
Jooyung Han | 49f6701 | 2020-04-17 13:43:10 +0900 | [diff] [blame] | 6393 | func TestApexMutatorsDontRunIfDisabled(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6394 | ctx := testApex(t, ` |
Jooyung Han | 49f6701 | 2020-04-17 13:43:10 +0900 | [diff] [blame] | 6395 | apex { |
| 6396 | name: "myapex", |
| 6397 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6398 | updatable: false, |
Jooyung Han | 49f6701 | 2020-04-17 13:43:10 +0900 | [diff] [blame] | 6399 | } |
| 6400 | apex_key { |
| 6401 | name: "myapex.key", |
| 6402 | public_key: "testkey.avbpubkey", |
| 6403 | private_key: "testkey.pem", |
| 6404 | } |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 6405 | `, |
| 6406 | android.FixtureModifyConfig(func(config android.Config) { |
| 6407 | delete(config.Targets, android.Android) |
| 6408 | config.AndroidCommonTarget = android.Target{} |
| 6409 | }), |
| 6410 | ) |
Jooyung Han | 49f6701 | 2020-04-17 13:43:10 +0900 | [diff] [blame] | 6411 | |
| 6412 | if expected, got := []string{""}, ctx.ModuleVariantsForTests("myapex"); !reflect.DeepEqual(expected, got) { |
| 6413 | t.Errorf("Expected variants: %v, but got: %v", expected, got) |
| 6414 | } |
| 6415 | } |
| 6416 | |
Jiyong Park | bd15961 | 2020-02-28 15:22:21 +0900 | [diff] [blame] | 6417 | func TestAppBundle(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6418 | ctx := testApex(t, ` |
Jiyong Park | bd15961 | 2020-02-28 15:22:21 +0900 | [diff] [blame] | 6419 | apex { |
| 6420 | name: "myapex", |
| 6421 | key: "myapex.key", |
| 6422 | apps: ["AppFoo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6423 | updatable: false, |
Jiyong Park | bd15961 | 2020-02-28 15:22:21 +0900 | [diff] [blame] | 6424 | } |
| 6425 | |
| 6426 | apex_key { |
| 6427 | name: "myapex.key", |
| 6428 | public_key: "testkey.avbpubkey", |
| 6429 | private_key: "testkey.pem", |
| 6430 | } |
| 6431 | |
| 6432 | android_app { |
| 6433 | name: "AppFoo", |
| 6434 | srcs: ["foo/bar/MyClass.java"], |
| 6435 | sdk_version: "none", |
| 6436 | system_modules: "none", |
| 6437 | apex_available: [ "myapex" ], |
| 6438 | } |
Jiyong Park | cfaa164 | 2020-02-28 16:51:07 +0900 | [diff] [blame] | 6439 | `, withManifestPackageNameOverrides([]string{"AppFoo:com.android.foo"})) |
Jiyong Park | bd15961 | 2020-02-28 15:22:21 +0900 | [diff] [blame] | 6440 | |
Colin Cross | cf371cc | 2020-11-13 11:48:42 -0800 | [diff] [blame] | 6441 | bundleConfigRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("bundle_config.json") |
Jiyong Park | bd15961 | 2020-02-28 15:22:21 +0900 | [diff] [blame] | 6442 | content := bundleConfigRule.Args["content"] |
| 6443 | |
| 6444 | ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`) |
Jiyong Park | cfaa164 | 2020-02-28 16:51:07 +0900 | [diff] [blame] | 6445 | ensureContains(t, content, `"apex_config":{"apex_embedded_apk_config":[{"package_name":"com.android.foo","path":"app/AppFoo/AppFoo.apk"}]}`) |
Jiyong Park | bd15961 | 2020-02-28 15:22:21 +0900 | [diff] [blame] | 6446 | } |
| 6447 | |
Sasha Smundak | 18d98bc | 2020-05-27 16:36:07 -0700 | [diff] [blame] | 6448 | func TestAppSetBundle(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6449 | ctx := testApex(t, ` |
Sasha Smundak | 18d98bc | 2020-05-27 16:36:07 -0700 | [diff] [blame] | 6450 | apex { |
| 6451 | name: "myapex", |
| 6452 | key: "myapex.key", |
| 6453 | apps: ["AppSet"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6454 | updatable: false, |
Sasha Smundak | 18d98bc | 2020-05-27 16:36:07 -0700 | [diff] [blame] | 6455 | } |
| 6456 | |
| 6457 | apex_key { |
| 6458 | name: "myapex.key", |
| 6459 | public_key: "testkey.avbpubkey", |
| 6460 | private_key: "testkey.pem", |
| 6461 | } |
| 6462 | |
| 6463 | android_app_set { |
| 6464 | name: "AppSet", |
| 6465 | set: "AppSet.apks", |
| 6466 | }`) |
| 6467 | mod := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Colin Cross | cf371cc | 2020-11-13 11:48:42 -0800 | [diff] [blame] | 6468 | bundleConfigRule := mod.Output("bundle_config.json") |
Sasha Smundak | 18d98bc | 2020-05-27 16:36:07 -0700 | [diff] [blame] | 6469 | content := bundleConfigRule.Args["content"] |
| 6470 | ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`) |
| 6471 | s := mod.Rule("apexRule").Args["copy_commands"] |
| 6472 | copyCmds := regexp.MustCompile(" *&& *").Split(s, -1) |
| 6473 | if len(copyCmds) != 3 { |
| 6474 | t.Fatalf("Expected 3 commands, got %d in:\n%s", len(copyCmds), s) |
| 6475 | } |
| 6476 | ensureMatches(t, copyCmds[0], "^rm -rf .*/app/AppSet$") |
| 6477 | ensureMatches(t, copyCmds[1], "^mkdir -p .*/app/AppSet$") |
| 6478 | ensureMatches(t, copyCmds[2], "^unzip .*-d .*/app/AppSet .*/AppSet.zip$") |
| 6479 | } |
| 6480 | |
Evgenii Stepanov | 2080bfe | 2020-07-24 15:35:40 -0700 | [diff] [blame] | 6481 | func TestAppSetBundlePrebuilt(t *testing.T) { |
Paul Duffin | 2470467 | 2021-04-06 16:09:30 +0100 | [diff] [blame] | 6482 | bp := ` |
Evgenii Stepanov | 2080bfe | 2020-07-24 15:35:40 -0700 | [diff] [blame] | 6483 | apex_set { |
| 6484 | name: "myapex", |
| 6485 | filename: "foo_v2.apex", |
| 6486 | sanitized: { |
| 6487 | none: { set: "myapex.apks", }, |
| 6488 | hwaddress: { set: "myapex.hwasan.apks", }, |
| 6489 | }, |
Paul Duffin | 2470467 | 2021-04-06 16:09:30 +0100 | [diff] [blame] | 6490 | } |
| 6491 | ` |
| 6492 | ctx := testApex(t, bp, prepareForTestWithSantitizeHwaddress) |
Evgenii Stepanov | 2080bfe | 2020-07-24 15:35:40 -0700 | [diff] [blame] | 6493 | |
Paul Duffin | 2470467 | 2021-04-06 16:09:30 +0100 | [diff] [blame] | 6494 | // Check that the extractor produces the correct output file from the correct input file. |
| 6495 | extractorOutput := "out/soong/.intermediates/myapex.apex.extractor/android_common/extracted/myapex.hwasan.apks" |
Evgenii Stepanov | 2080bfe | 2020-07-24 15:35:40 -0700 | [diff] [blame] | 6496 | |
Paul Duffin | 2470467 | 2021-04-06 16:09:30 +0100 | [diff] [blame] | 6497 | m := ctx.ModuleForTests("myapex.apex.extractor", "android_common") |
| 6498 | extractedApex := m.Output(extractorOutput) |
Evgenii Stepanov | 2080bfe | 2020-07-24 15:35:40 -0700 | [diff] [blame] | 6499 | |
Paul Duffin | 2470467 | 2021-04-06 16:09:30 +0100 | [diff] [blame] | 6500 | android.AssertArrayString(t, "extractor input", []string{"myapex.hwasan.apks"}, extractedApex.Inputs.Strings()) |
| 6501 | |
| 6502 | // Ditto for the apex. |
Paul Duffin | 6717d88 | 2021-06-15 19:09:41 +0100 | [diff] [blame] | 6503 | m = ctx.ModuleForTests("myapex", "android_common_myapex") |
| 6504 | copiedApex := m.Output("out/soong/.intermediates/myapex/android_common_myapex/foo_v2.apex") |
Paul Duffin | 2470467 | 2021-04-06 16:09:30 +0100 | [diff] [blame] | 6505 | |
| 6506 | android.AssertStringEquals(t, "myapex input", extractorOutput, copiedApex.Input.String()) |
Evgenii Stepanov | 2080bfe | 2020-07-24 15:35:40 -0700 | [diff] [blame] | 6507 | } |
| 6508 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6509 | func testNoUpdatableJarsInBootImage(t *testing.T, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) { |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6510 | t.Helper() |
| 6511 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6512 | bp := ` |
| 6513 | java_library { |
| 6514 | name: "some-updatable-apex-lib", |
| 6515 | srcs: ["a.java"], |
| 6516 | sdk_version: "current", |
| 6517 | apex_available: [ |
| 6518 | "some-updatable-apex", |
| 6519 | ], |
| 6520 | } |
| 6521 | |
| 6522 | java_library { |
| 6523 | name: "some-non-updatable-apex-lib", |
| 6524 | srcs: ["a.java"], |
| 6525 | apex_available: [ |
| 6526 | "some-non-updatable-apex", |
| 6527 | ], |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6528 | compile_dex: true, |
| 6529 | } |
| 6530 | |
| 6531 | bootclasspath_fragment { |
| 6532 | name: "some-non-updatable-fragment", |
| 6533 | contents: ["some-non-updatable-apex-lib"], |
| 6534 | apex_available: [ |
| 6535 | "some-non-updatable-apex", |
| 6536 | ], |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6537 | } |
| 6538 | |
| 6539 | java_library { |
| 6540 | name: "some-platform-lib", |
| 6541 | srcs: ["a.java"], |
| 6542 | sdk_version: "current", |
| 6543 | installable: true, |
| 6544 | } |
| 6545 | |
| 6546 | java_library { |
| 6547 | name: "some-art-lib", |
| 6548 | srcs: ["a.java"], |
| 6549 | sdk_version: "current", |
| 6550 | apex_available: [ |
Paul Duffin | d376f79 | 2021-01-26 11:59:35 +0000 | [diff] [blame] | 6551 | "com.android.art.debug", |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6552 | ], |
| 6553 | hostdex: true, |
Paul Duffin | e521881 | 2021-06-07 13:28:19 +0100 | [diff] [blame] | 6554 | compile_dex: true, |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6555 | } |
| 6556 | |
| 6557 | apex { |
| 6558 | name: "some-updatable-apex", |
| 6559 | key: "some-updatable-apex.key", |
| 6560 | java_libs: ["some-updatable-apex-lib"], |
| 6561 | updatable: true, |
| 6562 | min_sdk_version: "current", |
| 6563 | } |
| 6564 | |
| 6565 | apex { |
| 6566 | name: "some-non-updatable-apex", |
| 6567 | key: "some-non-updatable-apex.key", |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6568 | bootclasspath_fragments: ["some-non-updatable-fragment"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6569 | updatable: false, |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6570 | } |
| 6571 | |
| 6572 | apex_key { |
| 6573 | name: "some-updatable-apex.key", |
| 6574 | } |
| 6575 | |
| 6576 | apex_key { |
| 6577 | name: "some-non-updatable-apex.key", |
| 6578 | } |
| 6579 | |
| 6580 | apex { |
Paul Duffin | d376f79 | 2021-01-26 11:59:35 +0000 | [diff] [blame] | 6581 | name: "com.android.art.debug", |
| 6582 | key: "com.android.art.debug.key", |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6583 | bootclasspath_fragments: ["art-bootclasspath-fragment"], |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6584 | updatable: true, |
| 6585 | min_sdk_version: "current", |
| 6586 | } |
| 6587 | |
Paul Duffin | f23bc47 | 2021-04-27 12:42:20 +0100 | [diff] [blame] | 6588 | bootclasspath_fragment { |
| 6589 | name: "art-bootclasspath-fragment", |
| 6590 | image_name: "art", |
| 6591 | contents: ["some-art-lib"], |
| 6592 | apex_available: [ |
| 6593 | "com.android.art.debug", |
| 6594 | ], |
| 6595 | } |
| 6596 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6597 | apex_key { |
Paul Duffin | d376f79 | 2021-01-26 11:59:35 +0000 | [diff] [blame] | 6598 | name: "com.android.art.debug.key", |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6599 | } |
| 6600 | |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6601 | filegroup { |
| 6602 | name: "some-updatable-apex-file_contexts", |
| 6603 | srcs: [ |
| 6604 | "system/sepolicy/apex/some-updatable-apex-file_contexts", |
| 6605 | ], |
| 6606 | } |
Ulya Trafimovich | 7c140d8 | 2020-04-22 18:05:58 +0100 | [diff] [blame] | 6607 | |
| 6608 | filegroup { |
| 6609 | name: "some-non-updatable-apex-file_contexts", |
| 6610 | srcs: [ |
| 6611 | "system/sepolicy/apex/some-non-updatable-apex-file_contexts", |
| 6612 | ], |
| 6613 | } |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6614 | ` |
Paul Duffin | c3bbb96 | 2020-12-10 19:15:49 +0000 | [diff] [blame] | 6615 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6616 | testDexpreoptWithApexes(t, bp, errmsg, preparer, fragments...) |
Paul Duffin | c3bbb96 | 2020-12-10 19:15:49 +0000 | [diff] [blame] | 6617 | } |
| 6618 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6619 | func testDexpreoptWithApexes(t *testing.T, bp, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) *android.TestContext { |
Paul Duffin | c3bbb96 | 2020-12-10 19:15:49 +0000 | [diff] [blame] | 6620 | t.Helper() |
| 6621 | |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 6622 | fs := android.MockFS{ |
| 6623 | "a.java": nil, |
| 6624 | "a.jar": nil, |
| 6625 | "apex_manifest.json": nil, |
| 6626 | "AndroidManifest.xml": nil, |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 6627 | "system/sepolicy/apex/myapex-file_contexts": nil, |
Paul Duffin | d376f79 | 2021-01-26 11:59:35 +0000 | [diff] [blame] | 6628 | "system/sepolicy/apex/some-updatable-apex-file_contexts": nil, |
| 6629 | "system/sepolicy/apex/some-non-updatable-apex-file_contexts": nil, |
| 6630 | "system/sepolicy/apex/com.android.art.debug-file_contexts": nil, |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 6631 | "framework/aidl/a.aidl": nil, |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6632 | } |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6633 | |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 6634 | errorHandler := android.FixtureExpectsNoErrors |
| 6635 | if errmsg != "" { |
| 6636 | errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6637 | } |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 6638 | |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 6639 | result := android.GroupFixturePreparers( |
| 6640 | cc.PrepareForTestWithCcDefaultModules, |
| 6641 | java.PrepareForTestWithHiddenApiBuildComponents, |
| 6642 | java.PrepareForTestWithJavaDefaultModules, |
| 6643 | java.PrepareForTestWithJavaSdkLibraryFiles, |
| 6644 | PrepareForTestWithApexBuildComponents, |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 6645 | preparer, |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 6646 | fs.AddToFixture(), |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6647 | android.FixtureModifyMockFS(func(fs android.MockFS) { |
| 6648 | if _, ok := fs["frameworks/base/boot/Android.bp"]; !ok { |
| 6649 | insert := "" |
| 6650 | for _, fragment := range fragments { |
| 6651 | insert += fmt.Sprintf("{apex: %q, module: %q},\n", *fragment.Apex, *fragment.Module) |
| 6652 | } |
| 6653 | fs["frameworks/base/boot/Android.bp"] = []byte(fmt.Sprintf(` |
| 6654 | platform_bootclasspath { |
| 6655 | name: "platform-bootclasspath", |
| 6656 | fragments: [ |
| 6657 | %s |
| 6658 | ], |
| 6659 | } |
| 6660 | `, insert)) |
Paul Duffin | 8f146b9 | 2021-04-12 17:24:18 +0100 | [diff] [blame] | 6661 | } |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6662 | }), |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 6663 | ). |
| 6664 | ExtendWithErrorHandler(errorHandler). |
| 6665 | RunTestWithBp(t, bp) |
| 6666 | |
| 6667 | return result.TestContext |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6668 | } |
| 6669 | |
Jooyung Han | 548640b | 2020-04-27 12:10:30 +0900 | [diff] [blame] | 6670 | func TestUpdatable_should_set_min_sdk_version(t *testing.T) { |
| 6671 | testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, ` |
| 6672 | apex { |
| 6673 | name: "myapex", |
| 6674 | key: "myapex.key", |
| 6675 | updatable: true, |
| 6676 | } |
| 6677 | |
| 6678 | apex_key { |
| 6679 | name: "myapex.key", |
| 6680 | public_key: "testkey.avbpubkey", |
| 6681 | private_key: "testkey.pem", |
| 6682 | } |
| 6683 | `) |
| 6684 | } |
| 6685 | |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6686 | func TestUpdatableDefault_should_set_min_sdk_version(t *testing.T) { |
| 6687 | testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, ` |
| 6688 | apex { |
| 6689 | name: "myapex", |
| 6690 | key: "myapex.key", |
| 6691 | } |
| 6692 | |
| 6693 | apex_key { |
| 6694 | name: "myapex.key", |
| 6695 | public_key: "testkey.avbpubkey", |
| 6696 | private_key: "testkey.pem", |
| 6697 | } |
| 6698 | `) |
| 6699 | } |
| 6700 | |
satayev | b98371c | 2021-06-15 16:49:50 +0100 | [diff] [blame] | 6701 | func TestUpdatable_should_not_set_generate_classpaths_proto(t *testing.T) { |
| 6702 | testApexError(t, `"mysystemserverclasspathfragment" .* it must not set generate_classpaths_proto to false`, ` |
| 6703 | apex { |
| 6704 | name: "myapex", |
| 6705 | key: "myapex.key", |
| 6706 | systemserverclasspath_fragments: [ |
| 6707 | "mysystemserverclasspathfragment", |
| 6708 | ], |
| 6709 | min_sdk_version: "29", |
| 6710 | updatable: true, |
| 6711 | } |
| 6712 | |
| 6713 | apex_key { |
| 6714 | name: "myapex.key", |
| 6715 | public_key: "testkey.avbpubkey", |
| 6716 | private_key: "testkey.pem", |
| 6717 | } |
| 6718 | |
| 6719 | java_library { |
| 6720 | name: "foo", |
| 6721 | srcs: ["b.java"], |
| 6722 | min_sdk_version: "29", |
| 6723 | installable: true, |
| 6724 | apex_available: [ |
| 6725 | "myapex", |
| 6726 | ], |
| 6727 | } |
| 6728 | |
| 6729 | systemserverclasspath_fragment { |
| 6730 | name: "mysystemserverclasspathfragment", |
| 6731 | generate_classpaths_proto: false, |
| 6732 | contents: [ |
| 6733 | "foo", |
| 6734 | ], |
| 6735 | apex_available: [ |
| 6736 | "myapex", |
| 6737 | ], |
| 6738 | } |
| 6739 | `) |
| 6740 | } |
| 6741 | |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6742 | func TestNoUpdatableJarsInBootImage(t *testing.T) { |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 6743 | // Set the BootJars in dexpreopt.GlobalConfig and productVariables to the same value. This can |
| 6744 | // result in an invalid configuration as it does not set the ArtApexJars and allows art apex |
| 6745 | // modules to be included in the BootJars. |
| 6746 | prepareSetBootJars := func(bootJars ...string) android.FixturePreparer { |
| 6747 | return android.GroupFixturePreparers( |
| 6748 | dexpreopt.FixtureSetBootJars(bootJars...), |
| 6749 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 6750 | variables.BootJars = android.CreateTestConfiguredJarList(bootJars) |
| 6751 | }), |
| 6752 | ) |
| 6753 | } |
| 6754 | |
| 6755 | // Set the ArtApexJars and BootJars in dexpreopt.GlobalConfig and productVariables all to the |
| 6756 | // same value. This can result in an invalid configuration as it allows non art apex jars to be |
| 6757 | // specified in the ArtApexJars configuration. |
| 6758 | prepareSetArtJars := func(bootJars ...string) android.FixturePreparer { |
| 6759 | return android.GroupFixturePreparers( |
| 6760 | dexpreopt.FixtureSetArtBootJars(bootJars...), |
| 6761 | dexpreopt.FixtureSetBootJars(bootJars...), |
| 6762 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 6763 | variables.BootJars = android.CreateTestConfiguredJarList(bootJars) |
| 6764 | }), |
| 6765 | ) |
| 6766 | } |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6767 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6768 | t.Run("updatable jar from ART apex in the ART boot image => ok", func(t *testing.T) { |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 6769 | preparer := java.FixtureConfigureBootJars("com.android.art.debug:some-art-lib") |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6770 | fragment := java.ApexVariantReference{ |
| 6771 | Apex: proptools.StringPtr("com.android.art.debug"), |
| 6772 | Module: proptools.StringPtr("art-bootclasspath-fragment"), |
| 6773 | } |
| 6774 | testNoUpdatableJarsInBootImage(t, "", preparer, fragment) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6775 | }) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6776 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6777 | t.Run("updatable jar from ART apex in the framework boot image => error", func(t *testing.T) { |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 6778 | err := `module "some-art-lib" from updatable apexes \["com.android.art.debug"\] is not allowed in the framework boot image` |
| 6779 | // Update the dexpreopt BootJars directly. |
| 6780 | preparer := prepareSetBootJars("com.android.art.debug:some-art-lib") |
| 6781 | testNoUpdatableJarsInBootImage(t, err, preparer) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6782 | }) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6783 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6784 | t.Run("updatable jar from some other apex in the ART boot image => error", func(t *testing.T) { |
Paul Duffin | f23bc47 | 2021-04-27 12:42:20 +0100 | [diff] [blame] | 6785 | err := `ArtApexJars expects this to be in apex "some-updatable-apex" but this is only in apexes.*"com.android.art.debug"` |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 6786 | // Update the dexpreopt ArtApexJars directly. |
| 6787 | preparer := prepareSetArtJars("some-updatable-apex:some-updatable-apex-lib") |
| 6788 | testNoUpdatableJarsInBootImage(t, err, preparer) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6789 | }) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6790 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6791 | t.Run("non-updatable jar from some other apex in the ART boot image => error", func(t *testing.T) { |
Paul Duffin | f23bc47 | 2021-04-27 12:42:20 +0100 | [diff] [blame] | 6792 | err := `ArtApexJars expects this to be in apex "some-non-updatable-apex" but this is only in apexes.*"com.android.art.debug"` |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 6793 | // Update the dexpreopt ArtApexJars directly. |
| 6794 | preparer := prepareSetArtJars("some-non-updatable-apex:some-non-updatable-apex-lib") |
| 6795 | testNoUpdatableJarsInBootImage(t, err, preparer) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6796 | }) |
Ulya Trafimovich | 7c140d8 | 2020-04-22 18:05:58 +0100 | [diff] [blame] | 6797 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6798 | t.Run("updatable jar from some other apex in the framework boot image => error", func(t *testing.T) { |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 6799 | err := `module "some-updatable-apex-lib" from updatable apexes \["some-updatable-apex"\] is not allowed in the framework boot image` |
| 6800 | preparer := java.FixtureConfigureBootJars("some-updatable-apex:some-updatable-apex-lib") |
| 6801 | testNoUpdatableJarsInBootImage(t, err, preparer) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6802 | }) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6803 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6804 | t.Run("non-updatable jar from some other apex in the framework boot image => ok", func(t *testing.T) { |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 6805 | preparer := java.FixtureConfigureBootJars("some-non-updatable-apex:some-non-updatable-apex-lib") |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6806 | fragment := java.ApexVariantReference{ |
| 6807 | Apex: proptools.StringPtr("some-non-updatable-apex"), |
| 6808 | Module: proptools.StringPtr("some-non-updatable-fragment"), |
| 6809 | } |
| 6810 | testNoUpdatableJarsInBootImage(t, "", preparer, fragment) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6811 | }) |
Ulya Trafimovich | 7c140d8 | 2020-04-22 18:05:58 +0100 | [diff] [blame] | 6812 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6813 | t.Run("nonexistent jar in the ART boot image => error", func(t *testing.T) { |
Paul Duffin | 8f146b9 | 2021-04-12 17:24:18 +0100 | [diff] [blame] | 6814 | err := `"platform-bootclasspath" depends on undefined module "nonexistent"` |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 6815 | preparer := java.FixtureConfigureBootJars("platform:nonexistent") |
| 6816 | testNoUpdatableJarsInBootImage(t, err, preparer) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6817 | }) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6818 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6819 | t.Run("nonexistent jar in the framework boot image => error", func(t *testing.T) { |
Paul Duffin | 8f146b9 | 2021-04-12 17:24:18 +0100 | [diff] [blame] | 6820 | err := `"platform-bootclasspath" depends on undefined module "nonexistent"` |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 6821 | preparer := java.FixtureConfigureBootJars("platform:nonexistent") |
| 6822 | testNoUpdatableJarsInBootImage(t, err, preparer) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6823 | }) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6824 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6825 | t.Run("platform jar in the ART boot image => error", func(t *testing.T) { |
Paul Duffin | f23bc47 | 2021-04-27 12:42:20 +0100 | [diff] [blame] | 6826 | err := `ArtApexJars is invalid as it requests a platform variant of "some-platform-lib"` |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 6827 | // Update the dexpreopt ArtApexJars directly. |
| 6828 | preparer := prepareSetArtJars("platform:some-platform-lib") |
| 6829 | testNoUpdatableJarsInBootImage(t, err, preparer) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6830 | }) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6831 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6832 | t.Run("platform jar in the framework boot image => ok", func(t *testing.T) { |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 6833 | preparer := java.FixtureConfigureBootJars("platform:some-platform-lib") |
| 6834 | testNoUpdatableJarsInBootImage(t, "", preparer) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6835 | }) |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 6836 | } |
| 6837 | |
| 6838 | func TestDexpreoptAccessDexFilesFromPrebuiltApex(t *testing.T) { |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 6839 | preparer := java.FixtureConfigureBootJars("myapex:libfoo") |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 6840 | t.Run("prebuilt no source", func(t *testing.T) { |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6841 | fragment := java.ApexVariantReference{ |
| 6842 | Apex: proptools.StringPtr("myapex"), |
| 6843 | Module: proptools.StringPtr("my-bootclasspath-fragment"), |
| 6844 | } |
| 6845 | |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 6846 | testDexpreoptWithApexes(t, ` |
| 6847 | prebuilt_apex { |
| 6848 | name: "myapex" , |
| 6849 | arch: { |
| 6850 | arm64: { |
| 6851 | src: "myapex-arm64.apex", |
| 6852 | }, |
| 6853 | arm: { |
| 6854 | src: "myapex-arm.apex", |
| 6855 | }, |
| 6856 | }, |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6857 | exported_bootclasspath_fragments: ["my-bootclasspath-fragment"], |
| 6858 | } |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 6859 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6860 | prebuilt_bootclasspath_fragment { |
| 6861 | name: "my-bootclasspath-fragment", |
| 6862 | contents: ["libfoo"], |
| 6863 | apex_available: ["myapex"], |
| 6864 | } |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 6865 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6866 | java_import { |
| 6867 | name: "libfoo", |
| 6868 | jars: ["libfoo.jar"], |
| 6869 | apex_available: ["myapex"], |
| 6870 | } |
| 6871 | `, "", preparer, fragment) |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 6872 | }) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6873 | } |
| 6874 | |
Andrei Onea | 115e7e7 | 2020-06-05 21:14:03 +0100 | [diff] [blame] | 6875 | func testApexPermittedPackagesRules(t *testing.T, errmsg, bp string, apexBootJars []string, rules []android.Rule) { |
| 6876 | t.Helper() |
Andrei Onea | 115e7e7 | 2020-06-05 21:14:03 +0100 | [diff] [blame] | 6877 | bp += ` |
| 6878 | apex_key { |
| 6879 | name: "myapex.key", |
| 6880 | public_key: "testkey.avbpubkey", |
| 6881 | private_key: "testkey.pem", |
| 6882 | }` |
Paul Duffin | 45338f0 | 2021-03-30 23:07:52 +0100 | [diff] [blame] | 6883 | fs := android.MockFS{ |
Andrei Onea | 115e7e7 | 2020-06-05 21:14:03 +0100 | [diff] [blame] | 6884 | "lib1/src/A.java": nil, |
| 6885 | "lib2/src/B.java": nil, |
| 6886 | "system/sepolicy/apex/myapex-file_contexts": nil, |
| 6887 | } |
| 6888 | |
Paul Duffin | 45338f0 | 2021-03-30 23:07:52 +0100 | [diff] [blame] | 6889 | errorHandler := android.FixtureExpectsNoErrors |
| 6890 | if errmsg != "" { |
| 6891 | errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg) |
Colin Cross | ae8600b | 2020-10-29 17:09:13 -0700 | [diff] [blame] | 6892 | } |
Colin Cross | ae8600b | 2020-10-29 17:09:13 -0700 | [diff] [blame] | 6893 | |
Paul Duffin | 45338f0 | 2021-03-30 23:07:52 +0100 | [diff] [blame] | 6894 | android.GroupFixturePreparers( |
| 6895 | android.PrepareForTestWithAndroidBuildComponents, |
| 6896 | java.PrepareForTestWithJavaBuildComponents, |
| 6897 | PrepareForTestWithApexBuildComponents, |
| 6898 | android.PrepareForTestWithNeverallowRules(rules), |
| 6899 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 6900 | updatableBootJars := make([]string, 0, len(apexBootJars)) |
| 6901 | for _, apexBootJar := range apexBootJars { |
| 6902 | updatableBootJars = append(updatableBootJars, "myapex:"+apexBootJar) |
| 6903 | } |
| 6904 | variables.UpdatableBootJars = android.CreateTestConfiguredJarList(updatableBootJars) |
| 6905 | }), |
| 6906 | fs.AddToFixture(), |
| 6907 | ). |
| 6908 | ExtendWithErrorHandler(errorHandler). |
| 6909 | RunTestWithBp(t, bp) |
Andrei Onea | 115e7e7 | 2020-06-05 21:14:03 +0100 | [diff] [blame] | 6910 | } |
| 6911 | |
| 6912 | func TestApexPermittedPackagesRules(t *testing.T) { |
| 6913 | testcases := []struct { |
| 6914 | name string |
| 6915 | expectedError string |
| 6916 | bp string |
| 6917 | bootJars []string |
| 6918 | modulesPackages map[string][]string |
| 6919 | }{ |
| 6920 | |
| 6921 | { |
| 6922 | name: "Non-Bootclasspath apex jar not satisfying allowed module packages.", |
| 6923 | expectedError: "", |
| 6924 | bp: ` |
| 6925 | java_library { |
| 6926 | name: "bcp_lib1", |
| 6927 | srcs: ["lib1/src/*.java"], |
| 6928 | permitted_packages: ["foo.bar"], |
| 6929 | apex_available: ["myapex"], |
| 6930 | sdk_version: "none", |
| 6931 | system_modules: "none", |
| 6932 | } |
| 6933 | java_library { |
| 6934 | name: "nonbcp_lib2", |
| 6935 | srcs: ["lib2/src/*.java"], |
| 6936 | apex_available: ["myapex"], |
| 6937 | permitted_packages: ["a.b"], |
| 6938 | sdk_version: "none", |
| 6939 | system_modules: "none", |
| 6940 | } |
| 6941 | apex { |
| 6942 | name: "myapex", |
| 6943 | key: "myapex.key", |
| 6944 | java_libs: ["bcp_lib1", "nonbcp_lib2"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6945 | updatable: false, |
Andrei Onea | 115e7e7 | 2020-06-05 21:14:03 +0100 | [diff] [blame] | 6946 | }`, |
| 6947 | bootJars: []string{"bcp_lib1"}, |
| 6948 | modulesPackages: map[string][]string{ |
| 6949 | "myapex": []string{ |
| 6950 | "foo.bar", |
| 6951 | }, |
| 6952 | }, |
| 6953 | }, |
| 6954 | { |
| 6955 | name: "Bootclasspath apex jar not satisfying allowed module packages.", |
| 6956 | expectedError: `module "bcp_lib2" .* which is restricted because jars that are part of the myapex module may only allow these packages: foo.bar. Please jarjar or move code around.`, |
| 6957 | bp: ` |
| 6958 | java_library { |
| 6959 | name: "bcp_lib1", |
| 6960 | srcs: ["lib1/src/*.java"], |
| 6961 | apex_available: ["myapex"], |
| 6962 | permitted_packages: ["foo.bar"], |
| 6963 | sdk_version: "none", |
| 6964 | system_modules: "none", |
| 6965 | } |
| 6966 | java_library { |
| 6967 | name: "bcp_lib2", |
| 6968 | srcs: ["lib2/src/*.java"], |
| 6969 | apex_available: ["myapex"], |
| 6970 | permitted_packages: ["foo.bar", "bar.baz"], |
| 6971 | sdk_version: "none", |
| 6972 | system_modules: "none", |
| 6973 | } |
| 6974 | apex { |
| 6975 | name: "myapex", |
| 6976 | key: "myapex.key", |
| 6977 | java_libs: ["bcp_lib1", "bcp_lib2"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6978 | updatable: false, |
Andrei Onea | 115e7e7 | 2020-06-05 21:14:03 +0100 | [diff] [blame] | 6979 | } |
| 6980 | `, |
| 6981 | bootJars: []string{"bcp_lib1", "bcp_lib2"}, |
| 6982 | modulesPackages: map[string][]string{ |
| 6983 | "myapex": []string{ |
| 6984 | "foo.bar", |
| 6985 | }, |
| 6986 | }, |
| 6987 | }, |
| 6988 | } |
| 6989 | for _, tc := range testcases { |
| 6990 | t.Run(tc.name, func(t *testing.T) { |
| 6991 | rules := createApexPermittedPackagesRules(tc.modulesPackages) |
| 6992 | testApexPermittedPackagesRules(t, tc.expectedError, tc.bp, tc.bootJars, rules) |
| 6993 | }) |
| 6994 | } |
| 6995 | } |
| 6996 | |
Jiyong Park | 62304bb | 2020-04-13 16:19:48 +0900 | [diff] [blame] | 6997 | func TestTestFor(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6998 | ctx := testApex(t, ` |
Jiyong Park | 62304bb | 2020-04-13 16:19:48 +0900 | [diff] [blame] | 6999 | apex { |
| 7000 | name: "myapex", |
| 7001 | key: "myapex.key", |
| 7002 | native_shared_libs: ["mylib", "myprivlib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7003 | updatable: false, |
Jiyong Park | 62304bb | 2020-04-13 16:19:48 +0900 | [diff] [blame] | 7004 | } |
| 7005 | |
| 7006 | apex_key { |
| 7007 | name: "myapex.key", |
| 7008 | public_key: "testkey.avbpubkey", |
| 7009 | private_key: "testkey.pem", |
| 7010 | } |
| 7011 | |
| 7012 | cc_library { |
| 7013 | name: "mylib", |
| 7014 | srcs: ["mylib.cpp"], |
| 7015 | system_shared_libs: [], |
| 7016 | stl: "none", |
| 7017 | stubs: { |
| 7018 | versions: ["1"], |
| 7019 | }, |
| 7020 | apex_available: ["myapex"], |
| 7021 | } |
| 7022 | |
| 7023 | cc_library { |
| 7024 | name: "myprivlib", |
| 7025 | srcs: ["mylib.cpp"], |
| 7026 | system_shared_libs: [], |
| 7027 | stl: "none", |
| 7028 | apex_available: ["myapex"], |
| 7029 | } |
| 7030 | |
| 7031 | |
| 7032 | cc_test { |
| 7033 | name: "mytest", |
| 7034 | gtest: false, |
| 7035 | srcs: ["mylib.cpp"], |
| 7036 | system_shared_libs: [], |
| 7037 | stl: "none", |
Jiyong Park | 46a512f | 2020-12-04 18:02:13 +0900 | [diff] [blame] | 7038 | shared_libs: ["mylib", "myprivlib", "mytestlib"], |
Jiyong Park | 62304bb | 2020-04-13 16:19:48 +0900 | [diff] [blame] | 7039 | test_for: ["myapex"] |
| 7040 | } |
Jiyong Park | 46a512f | 2020-12-04 18:02:13 +0900 | [diff] [blame] | 7041 | |
| 7042 | cc_library { |
| 7043 | name: "mytestlib", |
| 7044 | srcs: ["mylib.cpp"], |
| 7045 | system_shared_libs: [], |
| 7046 | shared_libs: ["mylib", "myprivlib"], |
| 7047 | stl: "none", |
| 7048 | test_for: ["myapex"], |
| 7049 | } |
| 7050 | |
| 7051 | cc_benchmark { |
| 7052 | name: "mybench", |
| 7053 | srcs: ["mylib.cpp"], |
| 7054 | system_shared_libs: [], |
| 7055 | shared_libs: ["mylib", "myprivlib"], |
| 7056 | stl: "none", |
| 7057 | test_for: ["myapex"], |
| 7058 | } |
Jiyong Park | 62304bb | 2020-04-13 16:19:48 +0900 | [diff] [blame] | 7059 | `) |
| 7060 | |
Martin Stjernholm | 4e6c269 | 2021-03-25 01:25:06 +0000 | [diff] [blame] | 7061 | ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) { |
Paul Duffin | a71a67a | 2021-03-29 00:42:57 +0100 | [diff] [blame] | 7062 | ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ") |
Martin Stjernholm | 4e6c269 | 2021-03-25 01:25:06 +0000 | [diff] [blame] | 7063 | mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) }) |
| 7064 | android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags) |
| 7065 | } |
| 7066 | |
| 7067 | // These modules are tests for the apex, therefore are linked to the |
Jiyong Park | 62304bb | 2020-04-13 16:19:48 +0900 | [diff] [blame] | 7068 | // actual implementation of mylib instead of its stub. |
Martin Stjernholm | 4e6c269 | 2021-03-25 01:25:06 +0000 | [diff] [blame] | 7069 | ensureLinkedLibIs("mytest", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so") |
| 7070 | ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so") |
| 7071 | ensureLinkedLibIs("mybench", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so") |
| 7072 | } |
Jiyong Park | 46a512f | 2020-12-04 18:02:13 +0900 | [diff] [blame] | 7073 | |
Martin Stjernholm | 4e6c269 | 2021-03-25 01:25:06 +0000 | [diff] [blame] | 7074 | func TestIndirectTestFor(t *testing.T) { |
| 7075 | ctx := testApex(t, ` |
| 7076 | apex { |
| 7077 | name: "myapex", |
| 7078 | key: "myapex.key", |
| 7079 | native_shared_libs: ["mylib", "myprivlib"], |
| 7080 | updatable: false, |
| 7081 | } |
Jiyong Park | 46a512f | 2020-12-04 18:02:13 +0900 | [diff] [blame] | 7082 | |
Martin Stjernholm | 4e6c269 | 2021-03-25 01:25:06 +0000 | [diff] [blame] | 7083 | apex_key { |
| 7084 | name: "myapex.key", |
| 7085 | public_key: "testkey.avbpubkey", |
| 7086 | private_key: "testkey.pem", |
| 7087 | } |
| 7088 | |
| 7089 | cc_library { |
| 7090 | name: "mylib", |
| 7091 | srcs: ["mylib.cpp"], |
| 7092 | system_shared_libs: [], |
| 7093 | stl: "none", |
| 7094 | stubs: { |
| 7095 | versions: ["1"], |
| 7096 | }, |
| 7097 | apex_available: ["myapex"], |
| 7098 | } |
| 7099 | |
| 7100 | cc_library { |
| 7101 | name: "myprivlib", |
| 7102 | srcs: ["mylib.cpp"], |
| 7103 | system_shared_libs: [], |
| 7104 | stl: "none", |
| 7105 | shared_libs: ["mylib"], |
| 7106 | apex_available: ["myapex"], |
| 7107 | } |
| 7108 | |
| 7109 | cc_library { |
| 7110 | name: "mytestlib", |
| 7111 | srcs: ["mylib.cpp"], |
| 7112 | system_shared_libs: [], |
| 7113 | shared_libs: ["myprivlib"], |
| 7114 | stl: "none", |
| 7115 | test_for: ["myapex"], |
| 7116 | } |
| 7117 | `) |
| 7118 | |
| 7119 | ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) { |
Paul Duffin | a71a67a | 2021-03-29 00:42:57 +0100 | [diff] [blame] | 7120 | ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ") |
Martin Stjernholm | 4e6c269 | 2021-03-25 01:25:06 +0000 | [diff] [blame] | 7121 | mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) }) |
| 7122 | android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags) |
| 7123 | } |
| 7124 | |
| 7125 | // The platform variant of mytestlib links to the platform variant of the |
| 7126 | // internal myprivlib. |
| 7127 | ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/myprivlib/", "android_arm64_armv8-a_shared/myprivlib.so") |
| 7128 | |
| 7129 | // The platform variant of myprivlib links to the platform variant of mylib |
| 7130 | // and bypasses its stubs. |
| 7131 | ensureLinkedLibIs("myprivlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so") |
Jiyong Park | 62304bb | 2020-04-13 16:19:48 +0900 | [diff] [blame] | 7132 | } |
| 7133 | |
Martin Stjernholm | ec00900 | 2021-03-27 15:18:31 +0000 | [diff] [blame] | 7134 | func TestTestForForLibInOtherApex(t *testing.T) { |
| 7135 | // This case is only allowed for known overlapping APEXes, i.e. the ART APEXes. |
| 7136 | _ = testApex(t, ` |
| 7137 | apex { |
| 7138 | name: "com.android.art", |
| 7139 | key: "myapex.key", |
| 7140 | native_shared_libs: ["mylib"], |
| 7141 | updatable: false, |
| 7142 | } |
| 7143 | |
| 7144 | apex { |
| 7145 | name: "com.android.art.debug", |
| 7146 | key: "myapex.key", |
| 7147 | native_shared_libs: ["mylib", "mytestlib"], |
| 7148 | updatable: false, |
| 7149 | } |
| 7150 | |
| 7151 | apex_key { |
| 7152 | name: "myapex.key", |
| 7153 | public_key: "testkey.avbpubkey", |
| 7154 | private_key: "testkey.pem", |
| 7155 | } |
| 7156 | |
| 7157 | cc_library { |
| 7158 | name: "mylib", |
| 7159 | srcs: ["mylib.cpp"], |
| 7160 | system_shared_libs: [], |
| 7161 | stl: "none", |
| 7162 | stubs: { |
| 7163 | versions: ["1"], |
| 7164 | }, |
| 7165 | apex_available: ["com.android.art", "com.android.art.debug"], |
| 7166 | } |
| 7167 | |
| 7168 | cc_library { |
| 7169 | name: "mytestlib", |
| 7170 | srcs: ["mylib.cpp"], |
| 7171 | system_shared_libs: [], |
| 7172 | shared_libs: ["mylib"], |
| 7173 | stl: "none", |
| 7174 | apex_available: ["com.android.art.debug"], |
| 7175 | test_for: ["com.android.art"], |
| 7176 | } |
| 7177 | `, |
| 7178 | android.MockFS{ |
| 7179 | "system/sepolicy/apex/com.android.art-file_contexts": nil, |
| 7180 | "system/sepolicy/apex/com.android.art.debug-file_contexts": nil, |
| 7181 | }.AddToFixture()) |
| 7182 | } |
| 7183 | |
Jaewoong Jung | fa00c06 | 2020-05-14 14:15:24 -0700 | [diff] [blame] | 7184 | // TODO(jungjw): Move this to proptools |
| 7185 | func intPtr(i int) *int { |
| 7186 | return &i |
| 7187 | } |
| 7188 | |
| 7189 | func TestApexSet(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 7190 | ctx := testApex(t, ` |
Jaewoong Jung | fa00c06 | 2020-05-14 14:15:24 -0700 | [diff] [blame] | 7191 | apex_set { |
| 7192 | name: "myapex", |
| 7193 | set: "myapex.apks", |
| 7194 | filename: "foo_v2.apex", |
| 7195 | overrides: ["foo"], |
| 7196 | } |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 7197 | `, |
| 7198 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 7199 | variables.Platform_sdk_version = intPtr(30) |
| 7200 | }), |
| 7201 | android.FixtureModifyConfig(func(config android.Config) { |
| 7202 | config.Targets[android.Android] = []android.Target{ |
| 7203 | {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}}, |
| 7204 | {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}}, |
| 7205 | } |
| 7206 | }), |
| 7207 | ) |
Jaewoong Jung | fa00c06 | 2020-05-14 14:15:24 -0700 | [diff] [blame] | 7208 | |
Paul Duffin | 2470467 | 2021-04-06 16:09:30 +0100 | [diff] [blame] | 7209 | m := ctx.ModuleForTests("myapex.apex.extractor", "android_common") |
Jaewoong Jung | fa00c06 | 2020-05-14 14:15:24 -0700 | [diff] [blame] | 7210 | |
| 7211 | // Check extract_apks tool parameters. |
Paul Duffin | 2470467 | 2021-04-06 16:09:30 +0100 | [diff] [blame] | 7212 | extractedApex := m.Output("extracted/myapex.apks") |
Jaewoong Jung | fa00c06 | 2020-05-14 14:15:24 -0700 | [diff] [blame] | 7213 | actual := extractedApex.Args["abis"] |
| 7214 | expected := "ARMEABI_V7A,ARM64_V8A" |
| 7215 | if actual != expected { |
| 7216 | t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual) |
| 7217 | } |
| 7218 | actual = extractedApex.Args["sdk-version"] |
| 7219 | expected = "30" |
| 7220 | if actual != expected { |
| 7221 | t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual) |
| 7222 | } |
| 7223 | |
Paul Duffin | 6717d88 | 2021-06-15 19:09:41 +0100 | [diff] [blame] | 7224 | m = ctx.ModuleForTests("myapex", "android_common_myapex") |
Jaewoong Jung | fa00c06 | 2020-05-14 14:15:24 -0700 | [diff] [blame] | 7225 | a := m.Module().(*ApexSet) |
| 7226 | expectedOverrides := []string{"foo"} |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 7227 | actualOverrides := android.AndroidMkEntriesForTest(t, ctx, a)[0].EntryMap["LOCAL_OVERRIDES_MODULES"] |
Jaewoong Jung | fa00c06 | 2020-05-14 14:15:24 -0700 | [diff] [blame] | 7228 | if !reflect.DeepEqual(actualOverrides, expectedOverrides) { |
| 7229 | t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES - expected %q vs actual %q", expectedOverrides, actualOverrides) |
| 7230 | } |
| 7231 | } |
| 7232 | |
Jiyong Park | 7d95a51 | 2020-05-10 15:16:24 +0900 | [diff] [blame] | 7233 | func TestNoStaticLinkingToStubsLib(t *testing.T) { |
| 7234 | testApexError(t, `.*required by "mylib" is a native library providing stub.*`, ` |
| 7235 | apex { |
| 7236 | name: "myapex", |
| 7237 | key: "myapex.key", |
| 7238 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7239 | updatable: false, |
Jiyong Park | 7d95a51 | 2020-05-10 15:16:24 +0900 | [diff] [blame] | 7240 | } |
| 7241 | |
| 7242 | apex_key { |
| 7243 | name: "myapex.key", |
| 7244 | public_key: "testkey.avbpubkey", |
| 7245 | private_key: "testkey.pem", |
| 7246 | } |
| 7247 | |
| 7248 | cc_library { |
| 7249 | name: "mylib", |
| 7250 | srcs: ["mylib.cpp"], |
| 7251 | static_libs: ["otherlib"], |
| 7252 | system_shared_libs: [], |
| 7253 | stl: "none", |
| 7254 | apex_available: [ "myapex" ], |
| 7255 | } |
| 7256 | |
| 7257 | cc_library { |
| 7258 | name: "otherlib", |
| 7259 | srcs: ["mylib.cpp"], |
| 7260 | system_shared_libs: [], |
| 7261 | stl: "none", |
| 7262 | stubs: { |
| 7263 | versions: ["1", "2", "3"], |
| 7264 | }, |
| 7265 | apex_available: [ "myapex" ], |
| 7266 | } |
| 7267 | `) |
| 7268 | } |
| 7269 | |
Jiyong Park | 8d6c51e | 2020-06-12 17:26:31 +0900 | [diff] [blame] | 7270 | func TestApexKeysTxt(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 7271 | ctx := testApex(t, ` |
Jiyong Park | 8d6c51e | 2020-06-12 17:26:31 +0900 | [diff] [blame] | 7272 | apex { |
| 7273 | name: "myapex", |
| 7274 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7275 | updatable: false, |
Jiyong Park | 8d6c51e | 2020-06-12 17:26:31 +0900 | [diff] [blame] | 7276 | } |
| 7277 | |
| 7278 | apex_key { |
| 7279 | name: "myapex.key", |
| 7280 | public_key: "testkey.avbpubkey", |
| 7281 | private_key: "testkey.pem", |
| 7282 | } |
| 7283 | |
| 7284 | prebuilt_apex { |
| 7285 | name: "myapex", |
| 7286 | prefer: true, |
| 7287 | arch: { |
| 7288 | arm64: { |
| 7289 | src: "myapex-arm64.apex", |
| 7290 | }, |
| 7291 | arm: { |
| 7292 | src: "myapex-arm.apex", |
| 7293 | }, |
| 7294 | }, |
| 7295 | } |
| 7296 | |
| 7297 | apex_set { |
| 7298 | name: "myapex_set", |
| 7299 | set: "myapex.apks", |
| 7300 | filename: "myapex_set.apex", |
| 7301 | overrides: ["myapex"], |
| 7302 | } |
| 7303 | `) |
| 7304 | |
| 7305 | apexKeysText := ctx.SingletonForTests("apex_keys_text") |
| 7306 | content := apexKeysText.MaybeDescription("apexkeys.txt").BuildParams.Args["content"] |
| 7307 | ensureContains(t, content, `name="myapex_set.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`) |
Jiyong Park | 03a7f3e | 2020-06-18 19:34:42 +0900 | [diff] [blame] | 7308 | ensureContains(t, content, `name="myapex.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`) |
Jiyong Park | 8d6c51e | 2020-06-12 17:26:31 +0900 | [diff] [blame] | 7309 | } |
| 7310 | |
Jooyung Han | 938b593 | 2020-06-20 12:47:47 +0900 | [diff] [blame] | 7311 | func TestAllowedFiles(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 7312 | ctx := testApex(t, ` |
Jooyung Han | 938b593 | 2020-06-20 12:47:47 +0900 | [diff] [blame] | 7313 | apex { |
| 7314 | name: "myapex", |
| 7315 | key: "myapex.key", |
| 7316 | apps: ["app"], |
| 7317 | allowed_files: "allowed.txt", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7318 | updatable: false, |
Jooyung Han | 938b593 | 2020-06-20 12:47:47 +0900 | [diff] [blame] | 7319 | } |
| 7320 | |
| 7321 | apex_key { |
| 7322 | name: "myapex.key", |
| 7323 | public_key: "testkey.avbpubkey", |
| 7324 | private_key: "testkey.pem", |
| 7325 | } |
| 7326 | |
| 7327 | android_app { |
| 7328 | name: "app", |
| 7329 | srcs: ["foo/bar/MyClass.java"], |
| 7330 | package_name: "foo", |
| 7331 | sdk_version: "none", |
| 7332 | system_modules: "none", |
| 7333 | apex_available: [ "myapex" ], |
| 7334 | } |
| 7335 | `, withFiles(map[string][]byte{ |
| 7336 | "sub/Android.bp": []byte(` |
| 7337 | override_apex { |
| 7338 | name: "override_myapex", |
| 7339 | base: "myapex", |
| 7340 | apps: ["override_app"], |
| 7341 | allowed_files: ":allowed", |
| 7342 | } |
| 7343 | // Overridable "path" property should be referenced indirectly |
| 7344 | filegroup { |
| 7345 | name: "allowed", |
| 7346 | srcs: ["allowed.txt"], |
| 7347 | } |
| 7348 | override_android_app { |
| 7349 | name: "override_app", |
| 7350 | base: "app", |
| 7351 | package_name: "bar", |
| 7352 | } |
| 7353 | `), |
| 7354 | })) |
| 7355 | |
| 7356 | rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("diffApexContentRule") |
| 7357 | if expected, actual := "allowed.txt", rule.Args["allowed_files_file"]; expected != actual { |
| 7358 | t.Errorf("allowed_files_file: expected %q but got %q", expected, actual) |
| 7359 | } |
| 7360 | |
| 7361 | rule2 := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Rule("diffApexContentRule") |
| 7362 | if expected, actual := "sub/allowed.txt", rule2.Args["allowed_files_file"]; expected != actual { |
| 7363 | t.Errorf("allowed_files_file: expected %q but got %q", expected, actual) |
| 7364 | } |
| 7365 | } |
| 7366 | |
Martin Stjernholm | 58c33f0 | 2020-07-06 22:56:01 +0100 | [diff] [blame] | 7367 | func TestNonPreferredPrebuiltDependency(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 7368 | testApex(t, ` |
Martin Stjernholm | 58c33f0 | 2020-07-06 22:56:01 +0100 | [diff] [blame] | 7369 | apex { |
| 7370 | name: "myapex", |
| 7371 | key: "myapex.key", |
| 7372 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7373 | updatable: false, |
Martin Stjernholm | 58c33f0 | 2020-07-06 22:56:01 +0100 | [diff] [blame] | 7374 | } |
| 7375 | |
| 7376 | apex_key { |
| 7377 | name: "myapex.key", |
| 7378 | public_key: "testkey.avbpubkey", |
| 7379 | private_key: "testkey.pem", |
| 7380 | } |
| 7381 | |
| 7382 | cc_library { |
| 7383 | name: "mylib", |
| 7384 | srcs: ["mylib.cpp"], |
| 7385 | stubs: { |
Dan Albert | c806053 | 2020-07-22 22:32:17 -0700 | [diff] [blame] | 7386 | versions: ["current"], |
Martin Stjernholm | 58c33f0 | 2020-07-06 22:56:01 +0100 | [diff] [blame] | 7387 | }, |
| 7388 | apex_available: ["myapex"], |
| 7389 | } |
| 7390 | |
| 7391 | cc_prebuilt_library_shared { |
| 7392 | name: "mylib", |
| 7393 | prefer: false, |
| 7394 | srcs: ["prebuilt.so"], |
| 7395 | stubs: { |
Dan Albert | c806053 | 2020-07-22 22:32:17 -0700 | [diff] [blame] | 7396 | versions: ["current"], |
Martin Stjernholm | 58c33f0 | 2020-07-06 22:56:01 +0100 | [diff] [blame] | 7397 | }, |
| 7398 | apex_available: ["myapex"], |
| 7399 | } |
| 7400 | `) |
| 7401 | } |
| 7402 | |
Mohammad Samiul Islam | 3cd005d | 2020-11-26 13:32:26 +0000 | [diff] [blame] | 7403 | func TestCompressedApex(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 7404 | ctx := testApex(t, ` |
Mohammad Samiul Islam | 3cd005d | 2020-11-26 13:32:26 +0000 | [diff] [blame] | 7405 | apex { |
| 7406 | name: "myapex", |
| 7407 | key: "myapex.key", |
| 7408 | compressible: true, |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7409 | updatable: false, |
Mohammad Samiul Islam | 3cd005d | 2020-11-26 13:32:26 +0000 | [diff] [blame] | 7410 | } |
| 7411 | apex_key { |
| 7412 | name: "myapex.key", |
| 7413 | public_key: "testkey.avbpubkey", |
| 7414 | private_key: "testkey.pem", |
| 7415 | } |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 7416 | `, |
| 7417 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 7418 | variables.CompressedApex = proptools.BoolPtr(true) |
| 7419 | }), |
| 7420 | ) |
Mohammad Samiul Islam | 3cd005d | 2020-11-26 13:32:26 +0000 | [diff] [blame] | 7421 | |
| 7422 | compressRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("compressRule") |
| 7423 | ensureContains(t, compressRule.Output.String(), "myapex.capex.unsigned") |
| 7424 | |
| 7425 | signApkRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Description("sign compressedApex") |
| 7426 | ensureEquals(t, signApkRule.Input.String(), compressRule.Output.String()) |
| 7427 | |
| 7428 | // Make sure output of bundle is .capex |
| 7429 | ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
| 7430 | ensureContains(t, ab.outputFile.String(), "myapex.capex") |
| 7431 | |
| 7432 | // Verify android.mk rules |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 7433 | data := android.AndroidMkDataForTest(t, ctx, ab) |
Mohammad Samiul Islam | 3cd005d | 2020-11-26 13:32:26 +0000 | [diff] [blame] | 7434 | var builder strings.Builder |
| 7435 | data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data) |
| 7436 | androidMk := builder.String() |
| 7437 | ensureContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.capex\n") |
| 7438 | } |
| 7439 | |
Martin Stjernholm | 2856c66 | 2020-12-02 15:03:42 +0000 | [diff] [blame] | 7440 | func TestPreferredPrebuiltSharedLibDep(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 7441 | ctx := testApex(t, ` |
Martin Stjernholm | 2856c66 | 2020-12-02 15:03:42 +0000 | [diff] [blame] | 7442 | apex { |
| 7443 | name: "myapex", |
| 7444 | key: "myapex.key", |
| 7445 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7446 | updatable: false, |
Martin Stjernholm | 2856c66 | 2020-12-02 15:03:42 +0000 | [diff] [blame] | 7447 | } |
| 7448 | |
| 7449 | apex_key { |
| 7450 | name: "myapex.key", |
| 7451 | public_key: "testkey.avbpubkey", |
| 7452 | private_key: "testkey.pem", |
| 7453 | } |
| 7454 | |
| 7455 | cc_library { |
| 7456 | name: "mylib", |
| 7457 | srcs: ["mylib.cpp"], |
| 7458 | apex_available: ["myapex"], |
| 7459 | shared_libs: ["otherlib"], |
| 7460 | system_shared_libs: [], |
| 7461 | } |
| 7462 | |
| 7463 | cc_library { |
| 7464 | name: "otherlib", |
| 7465 | srcs: ["mylib.cpp"], |
| 7466 | stubs: { |
| 7467 | versions: ["current"], |
| 7468 | }, |
| 7469 | } |
| 7470 | |
| 7471 | cc_prebuilt_library_shared { |
| 7472 | name: "otherlib", |
| 7473 | prefer: true, |
| 7474 | srcs: ["prebuilt.so"], |
| 7475 | stubs: { |
| 7476 | versions: ["current"], |
| 7477 | }, |
| 7478 | } |
| 7479 | `) |
| 7480 | |
| 7481 | ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 7482 | data := android.AndroidMkDataForTest(t, ctx, ab) |
Martin Stjernholm | 2856c66 | 2020-12-02 15:03:42 +0000 | [diff] [blame] | 7483 | var builder strings.Builder |
| 7484 | data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data) |
| 7485 | androidMk := builder.String() |
| 7486 | |
| 7487 | // The make level dependency needs to be on otherlib - prebuilt_otherlib isn't |
| 7488 | // a thing there. |
| 7489 | ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += otherlib\n") |
| 7490 | } |
| 7491 | |
Jiyong Park | e386754 | 2020-12-03 17:28:25 +0900 | [diff] [blame] | 7492 | func TestExcludeDependency(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 7493 | ctx := testApex(t, ` |
Jiyong Park | e386754 | 2020-12-03 17:28:25 +0900 | [diff] [blame] | 7494 | apex { |
| 7495 | name: "myapex", |
| 7496 | key: "myapex.key", |
| 7497 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7498 | updatable: false, |
Jiyong Park | e386754 | 2020-12-03 17:28:25 +0900 | [diff] [blame] | 7499 | } |
| 7500 | |
| 7501 | apex_key { |
| 7502 | name: "myapex.key", |
| 7503 | public_key: "testkey.avbpubkey", |
| 7504 | private_key: "testkey.pem", |
| 7505 | } |
| 7506 | |
| 7507 | cc_library { |
| 7508 | name: "mylib", |
| 7509 | srcs: ["mylib.cpp"], |
| 7510 | system_shared_libs: [], |
| 7511 | stl: "none", |
| 7512 | apex_available: ["myapex"], |
| 7513 | shared_libs: ["mylib2"], |
| 7514 | target: { |
| 7515 | apex: { |
| 7516 | exclude_shared_libs: ["mylib2"], |
| 7517 | }, |
| 7518 | }, |
| 7519 | } |
| 7520 | |
| 7521 | cc_library { |
| 7522 | name: "mylib2", |
| 7523 | srcs: ["mylib.cpp"], |
| 7524 | system_shared_libs: [], |
| 7525 | stl: "none", |
| 7526 | } |
| 7527 | `) |
| 7528 | |
| 7529 | // Check if mylib is linked to mylib2 for the non-apex target |
| 7530 | ldFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"] |
| 7531 | ensureContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so") |
| 7532 | |
| 7533 | // Make sure that the link doesn't occur for the apex target |
| 7534 | ldFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"] |
| 7535 | ensureNotContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared_apex10000/mylib2.so") |
| 7536 | |
| 7537 | // It shouldn't appear in the copy cmd as well. |
| 7538 | copyCmds := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule").Args["copy_commands"] |
| 7539 | ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so") |
| 7540 | } |
| 7541 | |
Jiyong Park | f7c3bbe | 2020-12-09 21:18:56 +0900 | [diff] [blame] | 7542 | func TestPrebuiltStubLibDep(t *testing.T) { |
| 7543 | bpBase := ` |
| 7544 | apex { |
| 7545 | name: "myapex", |
| 7546 | key: "myapex.key", |
| 7547 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7548 | updatable: false, |
Jiyong Park | f7c3bbe | 2020-12-09 21:18:56 +0900 | [diff] [blame] | 7549 | } |
| 7550 | apex_key { |
| 7551 | name: "myapex.key", |
| 7552 | public_key: "testkey.avbpubkey", |
| 7553 | private_key: "testkey.pem", |
| 7554 | } |
| 7555 | cc_library { |
| 7556 | name: "mylib", |
| 7557 | srcs: ["mylib.cpp"], |
| 7558 | apex_available: ["myapex"], |
| 7559 | shared_libs: ["stublib"], |
| 7560 | system_shared_libs: [], |
| 7561 | } |
| 7562 | apex { |
| 7563 | name: "otherapex", |
| 7564 | enabled: %s, |
| 7565 | key: "myapex.key", |
| 7566 | native_shared_libs: ["stublib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7567 | updatable: false, |
Jiyong Park | f7c3bbe | 2020-12-09 21:18:56 +0900 | [diff] [blame] | 7568 | } |
| 7569 | ` |
| 7570 | |
| 7571 | stublibSourceBp := ` |
| 7572 | cc_library { |
| 7573 | name: "stublib", |
| 7574 | srcs: ["mylib.cpp"], |
| 7575 | apex_available: ["otherapex"], |
| 7576 | system_shared_libs: [], |
| 7577 | stl: "none", |
| 7578 | stubs: { |
| 7579 | versions: ["1"], |
| 7580 | }, |
| 7581 | } |
| 7582 | ` |
| 7583 | |
| 7584 | stublibPrebuiltBp := ` |
| 7585 | cc_prebuilt_library_shared { |
| 7586 | name: "stublib", |
| 7587 | srcs: ["prebuilt.so"], |
| 7588 | apex_available: ["otherapex"], |
| 7589 | stubs: { |
| 7590 | versions: ["1"], |
| 7591 | }, |
| 7592 | %s |
| 7593 | } |
| 7594 | ` |
| 7595 | |
| 7596 | tests := []struct { |
| 7597 | name string |
| 7598 | stublibBp string |
| 7599 | usePrebuilt bool |
| 7600 | modNames []string // Modules to collect AndroidMkEntries for |
| 7601 | otherApexEnabled []string |
| 7602 | }{ |
| 7603 | { |
| 7604 | name: "only_source", |
| 7605 | stublibBp: stublibSourceBp, |
| 7606 | usePrebuilt: false, |
| 7607 | modNames: []string{"stublib"}, |
| 7608 | otherApexEnabled: []string{"true", "false"}, |
| 7609 | }, |
| 7610 | { |
| 7611 | name: "source_preferred", |
| 7612 | stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, ""), |
| 7613 | usePrebuilt: false, |
| 7614 | modNames: []string{"stublib", "prebuilt_stublib"}, |
| 7615 | otherApexEnabled: []string{"true", "false"}, |
| 7616 | }, |
| 7617 | { |
| 7618 | name: "prebuilt_preferred", |
| 7619 | stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, "prefer: true,"), |
| 7620 | usePrebuilt: true, |
| 7621 | modNames: []string{"stublib", "prebuilt_stublib"}, |
| 7622 | otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt. |
| 7623 | }, |
| 7624 | { |
| 7625 | name: "only_prebuilt", |
| 7626 | stublibBp: fmt.Sprintf(stublibPrebuiltBp, ""), |
| 7627 | usePrebuilt: true, |
| 7628 | modNames: []string{"stublib"}, |
| 7629 | otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt. |
| 7630 | }, |
| 7631 | } |
| 7632 | |
| 7633 | for _, test := range tests { |
| 7634 | t.Run(test.name, func(t *testing.T) { |
| 7635 | for _, otherApexEnabled := range test.otherApexEnabled { |
| 7636 | t.Run("otherapex_enabled_"+otherApexEnabled, func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 7637 | ctx := testApex(t, fmt.Sprintf(bpBase, otherApexEnabled)+test.stublibBp) |
Jiyong Park | f7c3bbe | 2020-12-09 21:18:56 +0900 | [diff] [blame] | 7638 | |
| 7639 | type modAndMkEntries struct { |
| 7640 | mod *cc.Module |
| 7641 | mkEntries android.AndroidMkEntries |
| 7642 | } |
| 7643 | entries := []*modAndMkEntries{} |
| 7644 | |
| 7645 | // Gather shared lib modules that are installable |
| 7646 | for _, modName := range test.modNames { |
| 7647 | for _, variant := range ctx.ModuleVariantsForTests(modName) { |
| 7648 | if !strings.HasPrefix(variant, "android_arm64_armv8-a_shared") { |
| 7649 | continue |
| 7650 | } |
| 7651 | mod := ctx.ModuleForTests(modName, variant).Module().(*cc.Module) |
Colin Cross | a9c8c9f | 2020-12-16 10:20:23 -0800 | [diff] [blame] | 7652 | if !mod.Enabled() || mod.IsHideFromMake() { |
Jiyong Park | f7c3bbe | 2020-12-09 21:18:56 +0900 | [diff] [blame] | 7653 | continue |
| 7654 | } |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 7655 | for _, ent := range android.AndroidMkEntriesForTest(t, ctx, mod) { |
Jiyong Park | f7c3bbe | 2020-12-09 21:18:56 +0900 | [diff] [blame] | 7656 | if ent.Disabled { |
| 7657 | continue |
| 7658 | } |
| 7659 | entries = append(entries, &modAndMkEntries{ |
| 7660 | mod: mod, |
| 7661 | mkEntries: ent, |
| 7662 | }) |
| 7663 | } |
| 7664 | } |
| 7665 | } |
| 7666 | |
| 7667 | var entry *modAndMkEntries = nil |
| 7668 | for _, ent := range entries { |
| 7669 | if strings.Join(ent.mkEntries.EntryMap["LOCAL_MODULE"], ",") == "stublib" { |
| 7670 | if entry != nil { |
| 7671 | t.Errorf("More than one AndroidMk entry for \"stublib\": %s and %s", entry.mod, ent.mod) |
| 7672 | } else { |
| 7673 | entry = ent |
| 7674 | } |
| 7675 | } |
| 7676 | } |
| 7677 | |
| 7678 | if entry == nil { |
| 7679 | t.Errorf("AndroidMk entry for \"stublib\" missing") |
| 7680 | } else { |
| 7681 | isPrebuilt := entry.mod.Prebuilt() != nil |
| 7682 | if isPrebuilt != test.usePrebuilt { |
| 7683 | t.Errorf("Wrong module for \"stublib\" AndroidMk entry: got prebuilt %t, want prebuilt %t", isPrebuilt, test.usePrebuilt) |
| 7684 | } |
| 7685 | if !entry.mod.IsStubs() { |
| 7686 | t.Errorf("Module for \"stublib\" AndroidMk entry isn't a stub: %s", entry.mod) |
| 7687 | } |
| 7688 | if entry.mkEntries.EntryMap["LOCAL_NOT_AVAILABLE_FOR_PLATFORM"] != nil { |
| 7689 | t.Errorf("AndroidMk entry for \"stublib\" has LOCAL_NOT_AVAILABLE_FOR_PLATFORM set: %+v", entry.mkEntries) |
| 7690 | } |
Jiyong Park | 892a98f | 2020-12-14 09:20:00 +0900 | [diff] [blame] | 7691 | cflags := entry.mkEntries.EntryMap["LOCAL_EXPORT_CFLAGS"] |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 7692 | expected := "-D__STUBLIB_API__=10000" |
Jiyong Park | 892a98f | 2020-12-14 09:20:00 +0900 | [diff] [blame] | 7693 | if !android.InList(expected, cflags) { |
| 7694 | t.Errorf("LOCAL_EXPORT_CFLAGS expected to have %q, but got %q", expected, cflags) |
| 7695 | } |
Jiyong Park | f7c3bbe | 2020-12-09 21:18:56 +0900 | [diff] [blame] | 7696 | } |
| 7697 | }) |
| 7698 | } |
| 7699 | }) |
| 7700 | } |
| 7701 | } |
| 7702 | |
Martin Stjernholm | df298b3 | 2021-05-21 20:57:29 +0100 | [diff] [blame] | 7703 | func TestHostApexInHostOnlyBuild(t *testing.T) { |
| 7704 | testApex(t, ` |
| 7705 | apex { |
| 7706 | name: "myapex", |
| 7707 | host_supported: true, |
| 7708 | key: "myapex.key", |
| 7709 | updatable: false, |
| 7710 | payload_type: "zip", |
| 7711 | } |
| 7712 | apex_key { |
| 7713 | name: "myapex.key", |
| 7714 | public_key: "testkey.avbpubkey", |
| 7715 | private_key: "testkey.pem", |
| 7716 | } |
| 7717 | `, |
| 7718 | android.FixtureModifyConfig(func(config android.Config) { |
| 7719 | // We may not have device targets in all builds, e.g. in |
| 7720 | // prebuilts/build-tools/build-prebuilts.sh |
| 7721 | config.Targets[android.Android] = []android.Target{} |
| 7722 | })) |
| 7723 | } |
| 7724 | |
Colin Cross | c33e521 | 2021-05-25 18:16:02 -0700 | [diff] [blame] | 7725 | func TestApexJavaCoverage(t *testing.T) { |
| 7726 | bp := ` |
| 7727 | apex { |
| 7728 | name: "myapex", |
| 7729 | key: "myapex.key", |
| 7730 | java_libs: ["mylib"], |
| 7731 | bootclasspath_fragments: ["mybootclasspathfragment"], |
| 7732 | systemserverclasspath_fragments: ["mysystemserverclasspathfragment"], |
| 7733 | updatable: false, |
| 7734 | } |
| 7735 | |
| 7736 | apex_key { |
| 7737 | name: "myapex.key", |
| 7738 | public_key: "testkey.avbpubkey", |
| 7739 | private_key: "testkey.pem", |
| 7740 | } |
| 7741 | |
| 7742 | java_library { |
| 7743 | name: "mylib", |
| 7744 | srcs: ["mylib.java"], |
| 7745 | apex_available: ["myapex"], |
| 7746 | compile_dex: true, |
| 7747 | } |
| 7748 | |
| 7749 | bootclasspath_fragment { |
| 7750 | name: "mybootclasspathfragment", |
| 7751 | contents: ["mybootclasspathlib"], |
| 7752 | apex_available: ["myapex"], |
| 7753 | } |
| 7754 | |
| 7755 | java_library { |
| 7756 | name: "mybootclasspathlib", |
| 7757 | srcs: ["mybootclasspathlib.java"], |
| 7758 | apex_available: ["myapex"], |
| 7759 | compile_dex: true, |
| 7760 | } |
| 7761 | |
| 7762 | systemserverclasspath_fragment { |
| 7763 | name: "mysystemserverclasspathfragment", |
| 7764 | contents: ["mysystemserverclasspathlib"], |
| 7765 | apex_available: ["myapex"], |
| 7766 | } |
| 7767 | |
| 7768 | java_library { |
| 7769 | name: "mysystemserverclasspathlib", |
| 7770 | srcs: ["mysystemserverclasspathlib.java"], |
| 7771 | apex_available: ["myapex"], |
| 7772 | compile_dex: true, |
| 7773 | } |
| 7774 | ` |
| 7775 | |
| 7776 | result := android.GroupFixturePreparers( |
| 7777 | PrepareForTestWithApexBuildComponents, |
| 7778 | prepareForTestWithMyapex, |
| 7779 | java.PrepareForTestWithJavaDefaultModules, |
| 7780 | android.PrepareForTestWithAndroidBuildComponents, |
| 7781 | android.FixtureWithRootAndroidBp(bp), |
| 7782 | android.FixtureMergeEnv(map[string]string{ |
| 7783 | "EMMA_INSTRUMENT": "true", |
| 7784 | }), |
| 7785 | ).RunTest(t) |
| 7786 | |
| 7787 | // Make sure jacoco ran on both mylib and mybootclasspathlib |
| 7788 | if result.ModuleForTests("mylib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil { |
| 7789 | t.Errorf("Failed to find jacoco rule for mylib") |
| 7790 | } |
| 7791 | if result.ModuleForTests("mybootclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil { |
| 7792 | t.Errorf("Failed to find jacoco rule for mybootclasspathlib") |
| 7793 | } |
| 7794 | if result.ModuleForTests("mysystemserverclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil { |
| 7795 | t.Errorf("Failed to find jacoco rule for mysystemserverclasspathlib") |
| 7796 | } |
| 7797 | } |
| 7798 | |
Jaewoong Jung | c1001ec | 2019-06-25 11:20:53 -0700 | [diff] [blame] | 7799 | func TestMain(m *testing.M) { |
Paul Duffin | 37ba344 | 2021-03-29 00:21:08 +0100 | [diff] [blame] | 7800 | os.Exit(m.Run()) |
Jaewoong Jung | c1001ec | 2019-06-25 11:20:53 -0700 | [diff] [blame] | 7801 | } |