blob: 28fa036b09921d0994e0d443c6d5aec4773fab2c [file] [log] [blame]
Ady Abrahamb4b1e0a2019-11-20 18:25:35 -08001/*
2 * Copyright 2019 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
Ady Abraham2139f732019-11-13 18:56:40 -080016
Ady Abraham8a82ba62020-01-17 12:43:17 -080017// #define LOG_NDEBUG 0
18#define ATRACE_TAG ATRACE_TAG_GRAPHICS
19
Marin Shalamanovbed7fd32020-12-21 20:02:20 +010020// TODO(b/129481165): remove the #pragma below and fix conversion issues
21#pragma clang diagnostic push
22#pragma clang diagnostic ignored "-Wextra"
23
Ady Abraham8a82ba62020-01-17 12:43:17 -080024#include <chrono>
25#include <cmath>
Dominik Laskowski530d6bd2022-10-10 16:55:54 -040026#include <deque>
Ady Abraham68636062022-11-16 17:07:25 -080027#include <map>
Dominik Laskowskif5d0ea52021-09-26 17:27:01 -070028
29#include <android-base/properties.h>
30#include <android-base/stringprintf.h>
Vishnu Nairbe0ad902024-06-27 23:38:43 +000031#include <common/trace.h>
Dominik Laskowskif5d0ea52021-09-26 17:27:01 -070032#include <ftl/enum.h>
Dominik Laskowskif8734e02022-08-26 09:06:59 -070033#include <ftl/fake_guard.h>
Dominik Laskowski36dced82022-09-02 09:24:00 -070034#include <ftl/match.h>
Ady Abraham8ca643a2022-10-18 18:26:47 -070035#include <ftl/unit.h>
Ady Abraham68636062022-11-16 17:07:25 -080036#include <scheduler/FrameRateMode.h>
Dominik Laskowskif5d0ea52021-09-26 17:27:01 -070037
Dominik Laskowskid82e0f02022-10-26 15:23:04 -040038#include "RefreshRateSelector.h"
Ady Abraham8a82ba62020-01-17 12:43:17 -080039
ramindania04b8a52023-08-07 18:49:47 -070040#include <com_android_graphics_surfaceflinger_flags.h>
41
Ady Abraham5b8afb5a2020-03-06 14:57:26 -080042#undef LOG_TAG
Dominik Laskowskid82e0f02022-10-26 15:23:04 -040043#define LOG_TAG "RefreshRateSelector"
Ady Abraham5b8afb5a2020-03-06 14:57:26 -080044
Ady Abrahamb4b1e0a2019-11-20 18:25:35 -080045namespace android::scheduler {
Marin Shalamanov53fc11d2020-11-20 14:00:13 +010046namespace {
Dominik Laskowskif5d0ea52021-09-26 17:27:01 -070047
ramindania04b8a52023-08-07 18:49:47 -070048using namespace com::android::graphics::surfaceflinger;
49
Dominik Laskowskib0054a22022-03-03 09:03:06 -080050struct RefreshRateScore {
Ady Abraham68636062022-11-16 17:07:25 -080051 FrameRateMode frameRateMode;
Ady Abrahamae2e3c72022-08-13 05:12:13 +000052 float overallScore;
53 struct {
Ady Abraham62f51d92022-08-24 22:20:22 +000054 float modeBelowThreshold;
55 float modeAboveThreshold;
56 } fixedRateBelowThresholdLayersScore;
Dominik Laskowskib0054a22022-03-03 09:03:06 -080057};
58
Dominik Laskowskid82e0f02022-10-26 15:23:04 -040059constexpr RefreshRateSelector::GlobalSignals kNoSignals;
Dominik Laskowskia8626ec2021-12-15 18:13:30 -080060
Dominik Laskowskid82e0f02022-10-26 15:23:04 -040061std::string formatLayerInfo(const RefreshRateSelector::LayerRequirement& layer, float weight) {
Dominik Laskowskib0054a22022-03-03 09:03:06 -080062 return base::StringPrintf("%s (type=%s, weight=%.2f, seamlessness=%s) %s", layer.name.c_str(),
Dominik Laskowskif5d0ea52021-09-26 17:27:01 -070063 ftl::enum_string(layer.vote).c_str(), weight,
64 ftl::enum_string(layer.seamlessness).c_str(),
Marin Shalamanove8a663d2020-11-24 17:48:00 +010065 to_string(layer.desiredRefreshRate).c_str());
Marin Shalamanov53fc11d2020-11-20 14:00:13 +010066}
Marin Shalamanoveadf2e72020-12-10 15:35:28 +010067
Marin Shalamanova7fe3042021-01-29 21:02:08 +010068std::vector<Fps> constructKnownFrameRates(const DisplayModes& modes) {
Dominik Laskowski6eab42d2021-09-13 14:34:13 -070069 std::vector<Fps> knownFrameRates = {24_Hz, 30_Hz, 45_Hz, 60_Hz, 72_Hz};
Marin Shalamanova7fe3042021-01-29 21:02:08 +010070 knownFrameRates.reserve(knownFrameRates.size() + modes.size());
Marin Shalamanoveadf2e72020-12-10 15:35:28 +010071
Dominik Laskowski6eab42d2021-09-13 14:34:13 -070072 // Add all supported refresh rates.
Dominik Laskowskib0054a22022-03-03 09:03:06 -080073 for (const auto& [id, mode] : modes) {
ramindania04b8a52023-08-07 18:49:47 -070074 knownFrameRates.push_back(mode->getPeakFps());
Marin Shalamanoveadf2e72020-12-10 15:35:28 +010075 }
76
Dominik Laskowski6eab42d2021-09-13 14:34:13 -070077 // Sort and remove duplicates.
78 std::sort(knownFrameRates.begin(), knownFrameRates.end(), isStrictlyLess);
Marin Shalamanoveadf2e72020-12-10 15:35:28 +010079 knownFrameRates.erase(std::unique(knownFrameRates.begin(), knownFrameRates.end(),
Dominik Laskowski6eab42d2021-09-13 14:34:13 -070080 isApproxEqual),
Marin Shalamanoveadf2e72020-12-10 15:35:28 +010081 knownFrameRates.end());
82 return knownFrameRates;
83}
84
Ady Abraham68636062022-11-16 17:07:25 -080085std::vector<DisplayModeIterator> sortByRefreshRate(const DisplayModes& modes) {
Dominik Laskowskib0054a22022-03-03 09:03:06 -080086 std::vector<DisplayModeIterator> sortedModes;
87 sortedModes.reserve(modes.size());
Dominik Laskowskib0054a22022-03-03 09:03:06 -080088 for (auto it = modes.begin(); it != modes.end(); ++it) {
Ady Abraham68636062022-11-16 17:07:25 -080089 sortedModes.push_back(it);
Dominik Laskowskib0054a22022-03-03 09:03:06 -080090 }
91
92 std::sort(sortedModes.begin(), sortedModes.end(), [](auto it1, auto it2) {
93 const auto& mode1 = it1->second;
94 const auto& mode2 = it2->second;
95
ramindania04b8a52023-08-07 18:49:47 -070096 if (mode1->getVsyncRate().getPeriodNsecs() == mode2->getVsyncRate().getPeriodNsecs()) {
Dominik Laskowskib0054a22022-03-03 09:03:06 -080097 return mode1->getGroup() > mode2->getGroup();
98 }
99
ramindania04b8a52023-08-07 18:49:47 -0700100 return mode1->getVsyncRate().getPeriodNsecs() > mode2->getVsyncRate().getPeriodNsecs();
Dominik Laskowskib0054a22022-03-03 09:03:06 -0800101 });
102
103 return sortedModes;
Marin Shalamanov46084422020-10-13 12:33:42 +0200104}
105
ramindania04b8a52023-08-07 18:49:47 -0700106std::pair<unsigned, unsigned> divisorRange(Fps vsyncRate, Fps peakFps, FpsRange range,
Ady Abraham68636062022-11-16 17:07:25 -0800107 RefreshRateSelector::Config::FrameRateOverride config) {
108 if (config != RefreshRateSelector::Config::FrameRateOverride::Enabled) {
109 return {1, 1};
110 }
111
112 using fps_approx_ops::operator/;
Ady Abraham08048ce2022-11-30 18:08:00 -0800113 // use signed type as `fps / range.max` might be 0
ramindania04b8a52023-08-07 18:49:47 -0700114 auto start = std::max(1, static_cast<int>(peakFps / range.max) - 1);
Ady Abrahamd6d80162023-10-23 12:57:41 -0700115 if (FlagManager::getInstance().vrr_config()) {
ramindania04b8a52023-08-07 18:49:47 -0700116 start = std::max(1,
117 static_cast<int>(vsyncRate /
118 std::min(range.max, peakFps, fps_approx_ops::operator<)) -
119 1);
120 }
121 const auto end = vsyncRate /
Ady Abraham68636062022-11-16 17:07:25 -0800122 std::max(range.min, RefreshRateSelector::kMinSupportedFrameRate,
123 fps_approx_ops::operator<);
124
125 return {start, end};
126}
127
Ady Abraham8ca643a2022-10-18 18:26:47 -0700128bool shouldEnableFrameRateOverride(const std::vector<DisplayModeIterator>& sortedModes) {
Dominik Laskowskib0054a22022-03-03 09:03:06 -0800129 for (const auto it1 : sortedModes) {
130 const auto& mode1 = it1->second;
131 for (const auto it2 : sortedModes) {
132 const auto& mode2 = it2->second;
133
ramindania04b8a52023-08-07 18:49:47 -0700134 if (RefreshRateSelector::getFrameRateDivisor(mode1->getPeakFps(),
135 mode2->getPeakFps()) >= 2) {
Dominik Laskowskib0054a22022-03-03 09:03:06 -0800136 return true;
137 }
138 }
139 }
140 return false;
141}
142
Dominik Laskowskid82e0f02022-10-26 15:23:04 -0400143std::string toString(const RefreshRateSelector::PolicyVariant& policy) {
Dominik Laskowski36dced82022-09-02 09:24:00 -0700144 using namespace std::string_literals;
145
146 return ftl::match(
147 policy,
Dominik Laskowskid82e0f02022-10-26 15:23:04 -0400148 [](const RefreshRateSelector::DisplayManagerPolicy& policy) {
Dominik Laskowski36dced82022-09-02 09:24:00 -0700149 return "DisplayManagerPolicy"s + policy.toString();
150 },
Dominik Laskowskid82e0f02022-10-26 15:23:04 -0400151 [](const RefreshRateSelector::OverridePolicy& policy) {
Dominik Laskowski36dced82022-09-02 09:24:00 -0700152 return "OverridePolicy"s + policy.toString();
153 },
Dominik Laskowskid82e0f02022-10-26 15:23:04 -0400154 [](RefreshRateSelector::NoOverridePolicy) { return "NoOverridePolicy"s; });
Dominik Laskowski36dced82022-09-02 09:24:00 -0700155}
156
Dominik Laskowskib0054a22022-03-03 09:03:06 -0800157} // namespace
158
Ady Abraham68636062022-11-16 17:07:25 -0800159auto RefreshRateSelector::createFrameRateModes(
Ady Abraham90f7fd22023-08-16 11:02:00 -0700160 const Policy& policy, std::function<bool(const DisplayMode&)>&& filterModes,
161 const FpsRange& renderRange) const -> std::vector<FrameRateMode> {
Ady Abraham68636062022-11-16 17:07:25 -0800162 struct Key {
163 Fps fps;
164 int32_t group;
165 };
166
167 struct KeyLess {
168 bool operator()(const Key& a, const Key& b) const {
169 using namespace fps_approx_ops;
170 if (a.fps != b.fps) {
171 return a.fps < b.fps;
172 }
173
174 // For the same fps the order doesn't really matter, but we still
175 // want the behaviour of a strictly less operator.
176 // We use the group id as the secondary ordering for that.
177 return a.group < b.group;
178 }
179 };
180
181 std::map<Key, DisplayModeIterator, KeyLess> ratesMap;
182 for (auto it = mDisplayModes.begin(); it != mDisplayModes.end(); ++it) {
183 const auto& [id, mode] = *it;
184
185 if (!filterModes(*mode)) {
186 continue;
187 }
ramindania04b8a52023-08-07 18:49:47 -0700188 const auto vsyncRate = mode->getVsyncRate();
189 const auto peakFps = mode->getPeakFps();
Ady Abraham68636062022-11-16 17:07:25 -0800190 const auto [start, end] =
ramindania04b8a52023-08-07 18:49:47 -0700191 divisorRange(vsyncRate, peakFps, renderRange, mConfig.enableFrameRateOverride);
Ady Abraham68636062022-11-16 17:07:25 -0800192 for (auto divisor = start; divisor <= end; divisor++) {
ramindania04b8a52023-08-07 18:49:47 -0700193 const auto fps = vsyncRate / divisor;
Ady Abraham68636062022-11-16 17:07:25 -0800194 using fps_approx_ops::operator<;
Ady Abrahamdc0b3a72023-01-04 16:58:27 -0800195 if (divisor > 1 && fps < kMinSupportedFrameRate) {
Ady Abraham68636062022-11-16 17:07:25 -0800196 break;
197 }
198
199 if (mConfig.enableFrameRateOverride == Config::FrameRateOverride::Enabled &&
200 !renderRange.includes(fps)) {
201 continue;
202 }
203
204 if (mConfig.enableFrameRateOverride ==
205 Config::FrameRateOverride::AppOverrideNativeRefreshRates &&
206 !isNativeRefreshRate(fps)) {
207 continue;
208 }
209
210 const auto [existingIter, emplaceHappened] =
211 ratesMap.try_emplace(Key{fps, mode->getGroup()}, it);
212 if (emplaceHappened) {
ramindania04b8a52023-08-07 18:49:47 -0700213 ALOGV("%s: including %s (%s(%s))", __func__, to_string(fps).c_str(),
214 to_string(peakFps).c_str(), to_string(vsyncRate).c_str());
Ady Abraham68636062022-11-16 17:07:25 -0800215 } else {
Ady Abraham90f7fd22023-08-16 11:02:00 -0700216 // If the primary physical range is a single rate, prefer to stay in that rate
217 // even if there is a lower physical refresh rate available. This would cause more
218 // cases to stay within the primary physical range
ramindania04b8a52023-08-07 18:49:47 -0700219 const Fps existingModeFps = existingIter->second->second->getPeakFps();
Ady Abraham90f7fd22023-08-16 11:02:00 -0700220 const bool existingModeIsPrimaryRange = policy.primaryRangeIsSingleRate() &&
221 policy.primaryRanges.physical.includes(existingModeFps);
222 const bool newModeIsPrimaryRange = policy.primaryRangeIsSingleRate() &&
ramindania04b8a52023-08-07 18:49:47 -0700223 policy.primaryRanges.physical.includes(mode->getPeakFps());
Ady Abraham90f7fd22023-08-16 11:02:00 -0700224 if (newModeIsPrimaryRange == existingModeIsPrimaryRange) {
225 // We might need to update the map as we found a lower refresh rate
ramindania04b8a52023-08-07 18:49:47 -0700226 if (isStrictlyLess(mode->getPeakFps(), existingModeFps)) {
Ady Abraham90f7fd22023-08-16 11:02:00 -0700227 existingIter->second = it;
ramindania04b8a52023-08-07 18:49:47 -0700228 ALOGV("%s: changing %s (%s(%s)) as we found a lower physical rate",
229 __func__, to_string(fps).c_str(), to_string(peakFps).c_str(),
230 to_string(vsyncRate).c_str());
Ady Abraham90f7fd22023-08-16 11:02:00 -0700231 }
232 } else if (newModeIsPrimaryRange) {
Ady Abraham68636062022-11-16 17:07:25 -0800233 existingIter->second = it;
ramindania04b8a52023-08-07 18:49:47 -0700234 ALOGV("%s: changing %s (%s(%s)) to stay in the primary range", __func__,
235 to_string(fps).c_str(), to_string(peakFps).c_str(),
236 to_string(vsyncRate).c_str());
Ady Abraham68636062022-11-16 17:07:25 -0800237 }
238 }
239 }
240 }
241
242 std::vector<FrameRateMode> frameRateModes;
243 frameRateModes.reserve(ratesMap.size());
244 for (const auto& [key, mode] : ratesMap) {
Ady Abrahamace3d052022-11-17 16:25:05 -0800245 frameRateModes.emplace_back(FrameRateMode{key.fps, ftl::as_non_null(mode->second)});
Ady Abraham68636062022-11-16 17:07:25 -0800246 }
247
248 // We always want that the lowest frame rate will be corresponding to the
249 // lowest mode for power saving.
250 const auto lowestRefreshRateIt =
251 std::min_element(frameRateModes.begin(), frameRateModes.end(),
252 [](const FrameRateMode& lhs, const FrameRateMode& rhs) {
ramindania04b8a52023-08-07 18:49:47 -0700253 return isStrictlyLess(lhs.modePtr->getVsyncRate(),
254 rhs.modePtr->getVsyncRate());
Ady Abraham68636062022-11-16 17:07:25 -0800255 });
256 frameRateModes.erase(frameRateModes.begin(), lowestRefreshRateIt);
257
258 return frameRateModes;
259}
260
Dominik Laskowskid82e0f02022-10-26 15:23:04 -0400261struct RefreshRateSelector::RefreshRateScoreComparator {
ramindanid72ba162022-09-09 21:33:40 +0000262 bool operator()(const RefreshRateScore& lhs, const RefreshRateScore& rhs) const {
Ady Abraham68636062022-11-16 17:07:25 -0800263 const auto& [frameRateMode, overallScore, _] = lhs;
ramindanid72ba162022-09-09 21:33:40 +0000264
Ady Abraham68636062022-11-16 17:07:25 -0800265 std::string name = to_string(frameRateMode);
266
ramindanid72ba162022-09-09 21:33:40 +0000267 ALOGV("%s sorting scores %.2f", name.c_str(), overallScore);
ramindanid72ba162022-09-09 21:33:40 +0000268
Ady Abraham68636062022-11-16 17:07:25 -0800269 if (!ScoredFrameRate::scoresEqual(overallScore, rhs.overallScore)) {
ramindanid72ba162022-09-09 21:33:40 +0000270 return overallScore > rhs.overallScore;
271 }
272
ramindanid72ba162022-09-09 21:33:40 +0000273 if (refreshRateOrder == RefreshRateOrder::Descending) {
274 using fps_approx_ops::operator>;
Ady Abraham68636062022-11-16 17:07:25 -0800275 return frameRateMode.fps > rhs.frameRateMode.fps;
ramindanid72ba162022-09-09 21:33:40 +0000276 } else {
277 using fps_approx_ops::operator<;
Ady Abraham68636062022-11-16 17:07:25 -0800278 return frameRateMode.fps < rhs.frameRateMode.fps;
ramindanid72ba162022-09-09 21:33:40 +0000279 }
280 }
281
282 const RefreshRateOrder refreshRateOrder;
283};
284
Dominik Laskowskid82e0f02022-10-26 15:23:04 -0400285std::string RefreshRateSelector::Policy::toString() const {
Dominik Laskowski0acc3842022-04-07 11:23:42 -0700286 return base::StringPrintf("{defaultModeId=%d, allowGroupSwitching=%s"
Ady Abraham67231722024-03-21 18:06:21 -0700287 ", primaryRanges=%s, appRequestRanges=%s idleScreenConfig=%s}",
Dominik Laskowski43baf902023-11-17 18:13:11 -0500288 ftl::to_underlying(defaultMode),
289 allowGroupSwitching ? "true" : "false",
Ady Abraham67231722024-03-21 18:06:21 -0700290 to_string(primaryRanges).c_str(), to_string(appRequestRanges).c_str(),
291 idleScreenConfigOpt ? idleScreenConfigOpt->toString().c_str()
292 : "nullptr");
Marin Shalamanov30b0b3c2020-10-13 19:15:06 +0200293}
294
Dominik Laskowskid82e0f02022-10-26 15:23:04 -0400295std::pair<nsecs_t, nsecs_t> RefreshRateSelector::getDisplayFrames(nsecs_t layerPeriod,
296 nsecs_t displayPeriod) const {
Ady Abraham62a0be22020-12-08 16:54:10 -0800297 auto [quotient, remainder] = std::div(layerPeriod, displayPeriod);
298 if (remainder <= MARGIN_FOR_PERIOD_CALCULATION ||
299 std::abs(remainder - displayPeriod) <= MARGIN_FOR_PERIOD_CALCULATION) {
300 quotient++;
301 remainder = 0;
Ady Abraham4ccdcb42020-02-11 17:34:34 -0800302 }
303
Ady Abraham62a0be22020-12-08 16:54:10 -0800304 return {quotient, remainder};
Ady Abraham4ccdcb42020-02-11 17:34:34 -0800305}
306
Rachel Leece6e0042023-06-27 11:22:54 -0700307float RefreshRateSelector::calculateNonExactMatchingDefaultLayerScoreLocked(
308 nsecs_t displayPeriod, nsecs_t layerPeriod) const {
309 // Find the actual rate the layer will render, assuming
310 // that layerPeriod is the minimal period to render a frame.
311 // For example if layerPeriod is 20ms and displayPeriod is 16ms,
312 // then the actualLayerPeriod will be 32ms, because it is the
313 // smallest multiple of the display period which is >= layerPeriod.
314 auto actualLayerPeriod = displayPeriod;
315 int multiplier = 1;
316 while (layerPeriod > actualLayerPeriod + MARGIN_FOR_PERIOD_CALCULATION) {
317 multiplier++;
318 actualLayerPeriod = displayPeriod * multiplier;
319 }
320
321 // Because of the threshold we used above it's possible that score is slightly
322 // above 1.
323 return std::min(1.0f, static_cast<float>(layerPeriod) / static_cast<float>(actualLayerPeriod));
324}
325
Dominik Laskowskid82e0f02022-10-26 15:23:04 -0400326float RefreshRateSelector::calculateNonExactMatchingLayerScoreLocked(const LayerRequirement& layer,
327 Fps refreshRate) const {
Marin Shalamanov15a0fc62021-08-16 18:20:21 +0200328 constexpr float kScoreForFractionalPairs = .8f;
329
Dominik Laskowskib0054a22022-03-03 09:03:06 -0800330 const auto displayPeriod = refreshRate.getPeriodNsecs();
Ady Abraham62a0be22020-12-08 16:54:10 -0800331 const auto layerPeriod = layer.desiredRefreshRate.getPeriodNsecs();
332 if (layer.vote == LayerVoteType::ExplicitDefault) {
Rachel Leece6e0042023-06-27 11:22:54 -0700333 return calculateNonExactMatchingDefaultLayerScoreLocked(displayPeriod, layerPeriod);
Ady Abraham62a0be22020-12-08 16:54:10 -0800334 }
335
Rachel Leee5514a72023-10-25 16:20:29 -0700336 if (layer.vote == LayerVoteType::ExplicitGte) {
337 using fps_approx_ops::operator>=;
338 if (refreshRate >= layer.desiredRefreshRate) {
339 return 1.0f;
340 } else {
341 return calculateDistanceScoreLocked(layer.desiredRefreshRate, refreshRate);
342 }
343 }
344
Ady Abraham62a0be22020-12-08 16:54:10 -0800345 if (layer.vote == LayerVoteType::ExplicitExactOrMultiple ||
346 layer.vote == LayerVoteType::Heuristic) {
Ady Abrahambd44e8a2023-07-24 11:30:06 -0700347 using fps_approx_ops::operator<;
348 if (refreshRate < 60_Hz) {
349 const bool favorsAtLeast60 =
350 std::find_if(mFrameRatesThatFavorsAtLeast60.begin(),
351 mFrameRatesThatFavorsAtLeast60.end(), [&](Fps fps) {
352 using fps_approx_ops::operator==;
353 return fps == layer.desiredRefreshRate;
354 }) != mFrameRatesThatFavorsAtLeast60.end();
355 if (favorsAtLeast60) {
356 return 0;
357 }
358 }
359
Ady Abraham68636062022-11-16 17:07:25 -0800360 const float multiplier = refreshRate.getValue() / layer.desiredRefreshRate.getValue();
361
362 // We only want to score this layer as a fractional pair if the content is not
363 // significantly faster than the display rate, at it would cause a significant frame drop.
364 // It is more appropriate to choose a higher display rate even if
365 // a pull-down will be required.
Rachel Lee36426fa2023-03-08 20:13:52 -0800366 constexpr float kMinMultiplier = 0.75f;
Ady Abraham68636062022-11-16 17:07:25 -0800367 if (multiplier >= kMinMultiplier &&
368 isFractionalPairOrMultiple(refreshRate, layer.desiredRefreshRate)) {
Ady Abraham05243be2021-09-16 15:58:52 -0700369 return kScoreForFractionalPairs;
Marin Shalamanov15a0fc62021-08-16 18:20:21 +0200370 }
371
Ady Abraham62a0be22020-12-08 16:54:10 -0800372 // Calculate how many display vsyncs we need to present a single frame for this
373 // layer
374 const auto [displayFramesQuotient, displayFramesRemainder] =
375 getDisplayFrames(layerPeriod, displayPeriod);
376 static constexpr size_t MAX_FRAMES_TO_FIT = 10; // Stop calculating when score < 0.1
377 if (displayFramesRemainder == 0) {
378 // Layer desired refresh rate matches the display rate.
Ady Abraham05243be2021-09-16 15:58:52 -0700379 return 1.0f;
Ady Abraham62a0be22020-12-08 16:54:10 -0800380 }
381
382 if (displayFramesQuotient == 0) {
383 // Layer desired refresh rate is higher than the display rate.
384 return (static_cast<float>(layerPeriod) / static_cast<float>(displayPeriod)) *
385 (1.0f / (MAX_FRAMES_TO_FIT + 1));
386 }
387
388 // Layer desired refresh rate is lower than the display rate. Check how well it fits
389 // the cadence.
390 auto diff = std::abs(displayFramesRemainder - (displayPeriod - displayFramesRemainder));
391 int iter = 2;
392 while (diff > MARGIN_FOR_PERIOD_CALCULATION && iter < MAX_FRAMES_TO_FIT) {
393 diff = diff - (displayPeriod - diff);
394 iter++;
395 }
396
Ady Abraham05243be2021-09-16 15:58:52 -0700397 return (1.0f / iter);
398 }
399
400 return 0;
401}
402
Rachel Leee5514a72023-10-25 16:20:29 -0700403float RefreshRateSelector::calculateDistanceScoreLocked(Fps referenceRate, Fps refreshRate) const {
404 using fps_approx_ops::operator>=;
405 const float ratio = referenceRate >= refreshRate
406 ? refreshRate.getValue() / referenceRate.getValue()
407 : referenceRate.getValue() / refreshRate.getValue();
408 // Use ratio^2 to get a lower score the more we get further from the reference rate.
ramindanid72ba162022-09-09 21:33:40 +0000409 return ratio * ratio;
410}
411
Rachel Leee5514a72023-10-25 16:20:29 -0700412float RefreshRateSelector::calculateDistanceScoreFromMaxLocked(Fps refreshRate) const {
413 const auto& maxFps = mAppRequestFrameRates.back().fps;
414 return calculateDistanceScoreLocked(maxFps, refreshRate);
415}
416
Dominik Laskowskid82e0f02022-10-26 15:23:04 -0400417float RefreshRateSelector::calculateLayerScoreLocked(const LayerRequirement& layer, Fps refreshRate,
418 bool isSeamlessSwitch) const {
Ady Abraham05243be2021-09-16 15:58:52 -0700419 // Slightly prefer seamless switches.
420 constexpr float kSeamedSwitchPenalty = 0.95f;
421 const float seamlessness = isSeamlessSwitch ? 1.0f : kSeamedSwitchPenalty;
422
Rachel Leece6e0042023-06-27 11:22:54 -0700423 if (layer.vote == LayerVoteType::ExplicitCategory) {
Rachel Lee9580ff12023-12-26 17:33:41 -0800424 // HighHint is considered later for touch boost.
425 if (layer.frameRateCategory == FrameRateCategory::HighHint) {
426 return 0.f;
427 }
428
Rachel Leece6e0042023-06-27 11:22:54 -0700429 if (getFrameRateCategoryRange(layer.frameRateCategory).includes(refreshRate)) {
430 return 1.f;
431 }
432
433 FpsRange categoryRange = getFrameRateCategoryRange(layer.frameRateCategory);
434 using fps_approx_ops::operator<;
435 if (refreshRate < categoryRange.min) {
436 return calculateNonExactMatchingDefaultLayerScoreLocked(refreshRate.getPeriodNsecs(),
437 categoryRange.min
438 .getPeriodNsecs());
439 }
440 return calculateNonExactMatchingDefaultLayerScoreLocked(refreshRate.getPeriodNsecs(),
441 categoryRange.max.getPeriodNsecs());
442 }
443
Ady Abraham05243be2021-09-16 15:58:52 -0700444 // If the layer wants Max, give higher score to the higher refresh rate
445 if (layer.vote == LayerVoteType::Max) {
Rachel Leee5514a72023-10-25 16:20:29 -0700446 return calculateDistanceScoreFromMaxLocked(refreshRate);
Ady Abraham62a0be22020-12-08 16:54:10 -0800447 }
448
Ady Abrahamdd5bfa92021-01-07 17:56:08 -0800449 if (layer.vote == LayerVoteType::ExplicitExact) {
Dominik Laskowskib0054a22022-03-03 09:03:06 -0800450 const int divisor = getFrameRateDivisor(refreshRate, layer.desiredRefreshRate);
Ady Abraham68636062022-11-16 17:07:25 -0800451 if (supportsAppFrameRateOverrideByContent()) {
Ady Abrahamdd5bfa92021-01-07 17:56:08 -0800452 // Since we support frame rate override, allow refresh rates which are
453 // multiples of the layer's request, as those apps would be throttled
454 // down to run at the desired refresh rate.
Ady Abrahamcc315492022-02-17 17:06:39 -0800455 return divisor > 0;
Ady Abrahamdd5bfa92021-01-07 17:56:08 -0800456 }
457
Ady Abrahamcc315492022-02-17 17:06:39 -0800458 return divisor == 1;
Ady Abrahamdd5bfa92021-01-07 17:56:08 -0800459 }
460
Ady Abrahamcc315492022-02-17 17:06:39 -0800461 // If the layer frame rate is a divisor of the refresh rate it should score
Ady Abraham05243be2021-09-16 15:58:52 -0700462 // the highest score.
Rachel Leece6e0042023-06-27 11:22:54 -0700463 if (layer.desiredRefreshRate.isValid() &&
464 getFrameRateDivisor(refreshRate, layer.desiredRefreshRate) > 0) {
Ady Abraham05243be2021-09-16 15:58:52 -0700465 return 1.0f * seamlessness;
466 }
467
Ady Abrahamcc315492022-02-17 17:06:39 -0800468 // The layer frame rate is not a divisor of the refresh rate,
Ady Abraham05243be2021-09-16 15:58:52 -0700469 // there is a small penalty attached to the score to favor the frame rates
470 // the exactly matches the display refresh rate or a multiple.
Ady Abraham1c595502022-01-13 21:58:32 -0800471 constexpr float kNonExactMatchingPenalty = 0.95f;
Ady Abraham05243be2021-09-16 15:58:52 -0700472 return calculateNonExactMatchingLayerScoreLocked(layer, refreshRate) * seamlessness *
473 kNonExactMatchingPenalty;
Ady Abraham62a0be22020-12-08 16:54:10 -0800474}
475
Ady Abraham68636062022-11-16 17:07:25 -0800476auto RefreshRateSelector::getRankedFrameRates(const std::vector<LayerRequirement>& layers,
Dominik Laskowski9e88d622024-03-06 17:42:39 -0500477 GlobalSignals signals, Fps pacesetterFps) const
478 -> RankedFrameRates {
479 GetRankedFrameRatesCache cache{layers, signals, pacesetterFps};
480
Marin Shalamanov4c7831e2021-06-08 20:44:06 +0200481 std::lock_guard lock(mLock);
482
Dominik Laskowski9e88d622024-03-06 17:42:39 -0500483 if (mGetRankedFrameRatesCache && mGetRankedFrameRatesCache->matches(cache)) {
Ady Abraham68636062022-11-16 17:07:25 -0800484 return mGetRankedFrameRatesCache->result;
Marin Shalamanov4c7831e2021-06-08 20:44:06 +0200485 }
486
Dominik Laskowski9e88d622024-03-06 17:42:39 -0500487 cache.result = getRankedFrameRatesLocked(layers, signals, pacesetterFps);
488 mGetRankedFrameRatesCache = std::move(cache);
489 return mGetRankedFrameRatesCache->result;
Marin Shalamanov4c7831e2021-06-08 20:44:06 +0200490}
491
Ady Abraham68636062022-11-16 17:07:25 -0800492auto RefreshRateSelector::getRankedFrameRatesLocked(const std::vector<LayerRequirement>& layers,
Dominik Laskowski9e88d622024-03-06 17:42:39 -0500493 GlobalSignals signals, Fps pacesetterFps) const
Ady Abraham68636062022-11-16 17:07:25 -0800494 -> RankedFrameRates {
Ady Abrahamae2e3c72022-08-13 05:12:13 +0000495 using namespace fps_approx_ops;
Vishnu Nairbe0ad902024-06-27 23:38:43 +0000496 SFTRACE_CALL();
Dominik Laskowskia8626ec2021-12-15 18:13:30 -0800497 ALOGV("%s: %zu layers", __func__, layers.size());
Ady Abrahamdfd62162020-06-10 16:11:56 -0700498
Ady Abrahamace3d052022-11-17 16:25:05 -0800499 const auto& activeMode = *getActiveModeLocked().modePtr;
ramindani38c84982022-08-29 18:02:57 +0000500
Dominik Laskowski9e88d622024-03-06 17:42:39 -0500501 if (pacesetterFps.isValid()) {
502 ALOGV("Follower display");
503
504 const auto ranking = rankFrameRates(activeMode.getGroup(), RefreshRateOrder::Descending,
505 std::nullopt, [&](FrameRateMode mode) {
506 return mode.modePtr->getPeakFps() == pacesetterFps;
507 });
508
509 if (!ranking.empty()) {
Vishnu Nairbe0ad902024-06-27 23:38:43 +0000510 SFTRACE_FORMAT_INSTANT("%s (Follower display)",
511 to_string(ranking.front().frameRateMode.fps).c_str());
Dominik Laskowski9e88d622024-03-06 17:42:39 -0500512
513 return {ranking, kNoSignals, pacesetterFps};
514 }
515
516 ALOGW("Follower display cannot follow the pacesetter");
517 }
518
Ady Abraham68636062022-11-16 17:07:25 -0800519 // Keep the display at max frame rate for the duration of powering on the display.
ramindani38c84982022-08-29 18:02:57 +0000520 if (signals.powerOnImminent) {
521 ALOGV("Power On Imminent");
Ady Abrahamccf63862023-01-19 11:44:01 -0800522 const auto ranking = rankFrameRates(activeMode.getGroup(), RefreshRateOrder::Descending);
Vishnu Nairbe0ad902024-06-27 23:38:43 +0000523 SFTRACE_FORMAT_INSTANT("%s (Power On Imminent)",
524 to_string(ranking.front().frameRateMode.fps).c_str());
Ady Abrahamccf63862023-01-19 11:44:01 -0800525 return {ranking, GlobalSignals{.powerOnImminent = true}};
ramindani38c84982022-08-29 18:02:57 +0000526 }
527
Ady Abraham8a82ba62020-01-17 12:43:17 -0800528 int noVoteLayers = 0;
Rachel Lee19f01d02024-03-13 20:42:24 -0700529 // Layers that prefer the same mode ("no-op").
530 int noPreferenceLayers = 0;
Ady Abraham8a82ba62020-01-17 12:43:17 -0800531 int minVoteLayers = 0;
532 int maxVoteLayers = 0;
Ady Abraham71c437d2020-01-31 15:56:57 -0800533 int explicitDefaultVoteLayers = 0;
534 int explicitExactOrMultipleVoteLayers = 0;
Ady Abrahamdd5bfa92021-01-07 17:56:08 -0800535 int explicitExact = 0;
Rachel Leee5514a72023-10-25 16:20:29 -0700536 int explicitGteLayers = 0;
Rachel Leece6e0042023-06-27 11:22:54 -0700537 int explicitCategoryVoteLayers = 0;
Rachel Lee9580ff12023-12-26 17:33:41 -0800538 int interactiveLayers = 0;
Marin Shalamanovae0b5352021-03-24 12:56:08 +0100539 int seamedFocusedLayers = 0;
Rachel Lee67afbea2023-09-28 15:35:07 -0700540 int categorySmoothSwitchOnlyLayers = 0;
Dominik Laskowskia8626ec2021-12-15 18:13:30 -0800541
Ady Abraham8a82ba62020-01-17 12:43:17 -0800542 for (const auto& layer : layers) {
Ady Abrahamdd5bfa92021-01-07 17:56:08 -0800543 switch (layer.vote) {
544 case LayerVoteType::NoVote:
545 noVoteLayers++;
546 break;
547 case LayerVoteType::Min:
548 minVoteLayers++;
549 break;
550 case LayerVoteType::Max:
551 maxVoteLayers++;
552 break;
553 case LayerVoteType::ExplicitDefault:
554 explicitDefaultVoteLayers++;
Ady Abrahamdd5bfa92021-01-07 17:56:08 -0800555 break;
556 case LayerVoteType::ExplicitExactOrMultiple:
557 explicitExactOrMultipleVoteLayers++;
Ady Abrahamdd5bfa92021-01-07 17:56:08 -0800558 break;
559 case LayerVoteType::ExplicitExact:
560 explicitExact++;
Ady Abrahamdd5bfa92021-01-07 17:56:08 -0800561 break;
Rachel Leee5514a72023-10-25 16:20:29 -0700562 case LayerVoteType::ExplicitGte:
563 explicitGteLayers++;
564 break;
Rachel Leece6e0042023-06-27 11:22:54 -0700565 case LayerVoteType::ExplicitCategory:
Rachel Lee9580ff12023-12-26 17:33:41 -0800566 if (layer.frameRateCategory == FrameRateCategory::HighHint) {
567 // HighHint does not count as an explicit signal from an app. It may be
568 // be a touch signal.
569 interactiveLayers++;
570 } else {
571 explicitCategoryVoteLayers++;
572 }
Rachel Leef377b362023-09-06 15:01:06 -0700573 if (layer.frameRateCategory == FrameRateCategory::NoPreference) {
Rachel Lee19f01d02024-03-13 20:42:24 -0700574 noPreferenceLayers++;
Rachel Leef377b362023-09-06 15:01:06 -0700575 }
Rachel Leece6e0042023-06-27 11:22:54 -0700576 break;
Ady Abrahamdd5bfa92021-01-07 17:56:08 -0800577 case LayerVoteType::Heuristic:
578 break;
Ady Abraham6fb599b2020-03-05 13:48:22 -0800579 }
Marin Shalamanov46084422020-10-13 12:33:42 +0200580
Marin Shalamanovae0b5352021-03-24 12:56:08 +0100581 if (layer.seamlessness == Seamlessness::SeamedAndSeamless && layer.focused) {
582 seamedFocusedLayers++;
Marin Shalamanov46084422020-10-13 12:33:42 +0200583 }
Rachel Lee67afbea2023-09-28 15:35:07 -0700584 if (layer.frameRateCategorySmoothSwitchOnly) {
585 categorySmoothSwitchOnlyLayers++;
586 }
Ady Abraham6fb599b2020-03-05 13:48:22 -0800587 }
588
Ady Abrahamdd5bfa92021-01-07 17:56:08 -0800589 const bool hasExplicitVoteLayers = explicitDefaultVoteLayers > 0 ||
Rachel Leee5514a72023-10-25 16:20:29 -0700590 explicitExactOrMultipleVoteLayers > 0 || explicitExact > 0 || explicitGteLayers > 0 ||
Rachel Leece6e0042023-06-27 11:22:54 -0700591 explicitCategoryVoteLayers > 0;
Alec Mouri11232a22020-05-14 18:06:25 -0700592
Marin Shalamanov8cd8a992021-09-14 23:22:49 +0200593 const Policy* policy = getCurrentPolicyLocked();
Dominik Laskowskib0054a22022-03-03 09:03:06 -0800594 const auto& defaultMode = mDisplayModes.get(policy->defaultMode)->get();
Dominik Laskowskif8734e02022-08-26 09:06:59 -0700595
Marin Shalamanov8cd8a992021-09-14 23:22:49 +0200596 // If the default mode group is different from the group of current mode,
597 // this means a layer requesting a seamed mode switch just disappeared and
598 // we should switch back to the default group.
599 // However if a seamed layer is still present we anchor around the group
600 // of the current mode, in order to prevent unnecessary seamed mode switches
601 // (e.g. when pausing a video playback).
Dominik Laskowskib0054a22022-03-03 09:03:06 -0800602 const auto anchorGroup =
Dominik Laskowskif8734e02022-08-26 09:06:59 -0700603 seamedFocusedLayers > 0 ? activeMode.getGroup() : defaultMode->getGroup();
Marin Shalamanov8cd8a992021-09-14 23:22:49 +0200604
Steven Thomasf734df42020-04-13 21:09:28 -0700605 // Consider the touch event if there are no Explicit* layers. Otherwise wait until after we've
606 // selected a refresh rate to see if we should apply touch boost.
Dominik Laskowskia8626ec2021-12-15 18:13:30 -0800607 if (signals.touch && !hasExplicitVoteLayers) {
ramindanid72ba162022-09-09 21:33:40 +0000608 ALOGV("Touch Boost");
Ady Abrahamccf63862023-01-19 11:44:01 -0800609 const auto ranking = rankFrameRates(anchorGroup, RefreshRateOrder::Descending);
Vishnu Nairbe0ad902024-06-27 23:38:43 +0000610 SFTRACE_FORMAT_INSTANT("%s (Touch Boost)",
611 to_string(ranking.front().frameRateMode.fps).c_str());
Ady Abrahamccf63862023-01-19 11:44:01 -0800612 return {ranking, GlobalSignals{.touch = true}};
Ady Abraham8a82ba62020-01-17 12:43:17 -0800613 }
614
Alec Mouri11232a22020-05-14 18:06:25 -0700615 // If the primary range consists of a single refresh rate then we can only
616 // move out the of range if layers explicitly request a different refresh
617 // rate.
Ady Abraham90f7fd22023-08-16 11:02:00 -0700618 if (!signals.touch && signals.idle &&
619 !(policy->primaryRangeIsSingleRate() && hasExplicitVoteLayers)) {
ramindanid72ba162022-09-09 21:33:40 +0000620 ALOGV("Idle");
Ady Abrahamccf63862023-01-19 11:44:01 -0800621 const auto ranking = rankFrameRates(activeMode.getGroup(), RefreshRateOrder::Ascending);
Vishnu Nairbe0ad902024-06-27 23:38:43 +0000622 SFTRACE_FORMAT_INSTANT("%s (Idle)", to_string(ranking.front().frameRateMode.fps).c_str());
Ady Abrahamccf63862023-01-19 11:44:01 -0800623 return {ranking, GlobalSignals{.idle = true}};
Steven Thomasbb374322020-04-28 22:47:16 -0700624 }
625
Steven Thomasdebafed2020-05-18 17:30:35 -0700626 if (layers.empty() || noVoteLayers == layers.size()) {
ramindanid72ba162022-09-09 21:33:40 +0000627 ALOGV("No layers with votes");
Ady Abrahamccf63862023-01-19 11:44:01 -0800628 const auto ranking = rankFrameRates(anchorGroup, RefreshRateOrder::Descending);
Vishnu Nairbe0ad902024-06-27 23:38:43 +0000629 SFTRACE_FORMAT_INSTANT("%s (No layers with votes)",
630 to_string(ranking.front().frameRateMode.fps).c_str());
Ady Abrahamccf63862023-01-19 11:44:01 -0800631 return {ranking, kNoSignals};
Steven Thomasbb374322020-04-28 22:47:16 -0700632 }
633
Rachel Lee19f01d02024-03-13 20:42:24 -0700634 // If all layers are category NoPreference, use the current config.
635 if (noPreferenceLayers + noVoteLayers == layers.size()) {
636 ALOGV("All layers NoPreference");
Ady Abraham180d8002024-07-10 17:42:28 -0700637 constexpr float kScore = std::numeric_limits<float>::max();
638 FrameRateRanking currentMode;
639 currentMode.emplace_back(ScoredFrameRate{getActiveModeLocked(), kScore});
Vishnu Nairbe0ad902024-06-27 23:38:43 +0000640 SFTRACE_FORMAT_INSTANT("%s (All layers NoPreference)",
Ady Abraham180d8002024-07-10 17:42:28 -0700641 to_string(currentMode.front().frameRateMode.fps).c_str());
642 return {currentMode, kNoSignals};
Rachel Lee19f01d02024-03-13 20:42:24 -0700643 }
644
Rachel Lee67afbea2023-09-28 15:35:07 -0700645 const bool smoothSwitchOnly = categorySmoothSwitchOnlyLayers > 0;
646 const DisplayModeId activeModeId = activeMode.getId();
647
Ady Abraham8a82ba62020-01-17 12:43:17 -0800648 // Only if all layers want Min we should return Min
649 if (noVoteLayers + minVoteLayers == layers.size()) {
ramindanid72ba162022-09-09 21:33:40 +0000650 ALOGV("All layers Min");
Rachel Lee67afbea2023-09-28 15:35:07 -0700651 const auto ranking = rankFrameRates(activeMode.getGroup(), RefreshRateOrder::Ascending,
652 std::nullopt, [&](FrameRateMode mode) {
653 return !smoothSwitchOnly ||
654 mode.modePtr->getId() == activeModeId;
655 });
Vishnu Nairbe0ad902024-06-27 23:38:43 +0000656 SFTRACE_FORMAT_INSTANT("%s (All layers Min)",
657 to_string(ranking.front().frameRateMode.fps).c_str());
Ady Abrahamccf63862023-01-19 11:44:01 -0800658 return {ranking, kNoSignals};
Ady Abraham8a82ba62020-01-17 12:43:17 -0800659 }
660
Ady Abraham8a82ba62020-01-17 12:43:17 -0800661 // Find the best refresh rate based on score
Ady Abraham62a0be22020-12-08 16:54:10 -0800662 std::vector<RefreshRateScore> scores;
Ady Abraham68636062022-11-16 17:07:25 -0800663 scores.reserve(mAppRequestFrameRates.size());
Ady Abraham8a82ba62020-01-17 12:43:17 -0800664
Ady Abraham68636062022-11-16 17:07:25 -0800665 for (const FrameRateMode& it : mAppRequestFrameRates) {
666 scores.emplace_back(RefreshRateScore{it, 0.0f});
Ady Abraham8a82ba62020-01-17 12:43:17 -0800667 }
668
669 for (const auto& layer : layers) {
Rachel Leece6e0042023-06-27 11:22:54 -0700670 ALOGV("Calculating score for %s (%s, weight %.2f, desired %.2f, category %s) ",
671 layer.name.c_str(), ftl::enum_string(layer.vote).c_str(), layer.weight,
672 layer.desiredRefreshRate.getValue(),
673 ftl::enum_string(layer.frameRateCategory).c_str());
Rachel Leed0694bc2023-09-12 14:57:58 -0700674 if (layer.isNoVote() || layer.frameRateCategory == FrameRateCategory::NoPreference ||
675 layer.vote == LayerVoteType::Min) {
Rachel Lee19f01d02024-03-13 20:42:24 -0700676 ALOGV("%s scoring skipped due to vote", formatLayerInfo(layer, layer.weight).c_str());
Ady Abraham8a82ba62020-01-17 12:43:17 -0800677 continue;
678 }
679
Dominik Laskowskib0054a22022-03-03 09:03:06 -0800680 const auto weight = layer.weight;
Ady Abraham71c437d2020-01-31 15:56:57 -0800681
Ady Abraham68636062022-11-16 17:07:25 -0800682 for (auto& [mode, overallScore, fixedRateBelowThresholdLayersScore] : scores) {
683 const auto& [fps, modePtr] = mode;
684 const bool isSeamlessSwitch = modePtr->getGroup() == activeMode.getGroup();
Marin Shalamanov46084422020-10-13 12:33:42 +0200685
Marin Shalamanov53fc11d2020-11-20 14:00:13 +0100686 if (layer.seamlessness == Seamlessness::OnlySeamless && !isSeamlessSwitch) {
Marin Shalamanova7fe3042021-01-29 21:02:08 +0100687 ALOGV("%s ignores %s to avoid non-seamless switch. Current mode = %s",
Ady Abraham68636062022-11-16 17:07:25 -0800688 formatLayerInfo(layer, weight).c_str(), to_string(*modePtr).c_str(),
Dominik Laskowskif8734e02022-08-26 09:06:59 -0700689 to_string(activeMode).c_str());
Marin Shalamanov46084422020-10-13 12:33:42 +0200690 continue;
691 }
692
Marin Shalamanov53fc11d2020-11-20 14:00:13 +0100693 if (layer.seamlessness == Seamlessness::SeamedAndSeamless && !isSeamlessSwitch &&
694 !layer.focused) {
695 ALOGV("%s ignores %s because it's not focused and the switch is going to be seamed."
Marin Shalamanova7fe3042021-01-29 21:02:08 +0100696 " Current mode = %s",
Ady Abraham68636062022-11-16 17:07:25 -0800697 formatLayerInfo(layer, weight).c_str(), to_string(*modePtr).c_str(),
Dominik Laskowskif8734e02022-08-26 09:06:59 -0700698 to_string(activeMode).c_str());
Marin Shalamanov53fc11d2020-11-20 14:00:13 +0100699 continue;
700 }
701
Rachel Lee67afbea2023-09-28 15:35:07 -0700702 if (smoothSwitchOnly && modePtr->getId() != activeModeId) {
703 ALOGV("%s ignores %s because it's non-VRR and smooth switch only."
704 " Current mode = %s",
705 formatLayerInfo(layer, weight).c_str(), to_string(*modePtr).c_str(),
706 to_string(activeMode).c_str());
707 continue;
708 }
709
Marin Shalamanova7fe3042021-01-29 21:02:08 +0100710 // Layers with default seamlessness vote for the current mode group if
Marin Shalamanov53fc11d2020-11-20 14:00:13 +0100711 // there are layers with seamlessness=SeamedAndSeamless and for the default
Marin Shalamanova7fe3042021-01-29 21:02:08 +0100712 // mode group otherwise. In second case, if the current mode group is different
Marin Shalamanov53fc11d2020-11-20 14:00:13 +0100713 // from the default, this means a layer with seamlessness=SeamedAndSeamless has just
714 // disappeared.
Ady Abraham68636062022-11-16 17:07:25 -0800715 const bool isInPolicyForDefault = modePtr->getGroup() == anchorGroup;
Marin Shalamanovae0b5352021-03-24 12:56:08 +0100716 if (layer.seamlessness == Seamlessness::Default && !isInPolicyForDefault) {
Marin Shalamanova7fe3042021-01-29 21:02:08 +0100717 ALOGV("%s ignores %s. Current mode = %s", formatLayerInfo(layer, weight).c_str(),
Ady Abraham68636062022-11-16 17:07:25 -0800718 to_string(*modePtr).c_str(), to_string(activeMode).c_str());
Marin Shalamanov46084422020-10-13 12:33:42 +0200719 continue;
720 }
721
Ady Abraham90f7fd22023-08-16 11:02:00 -0700722 const bool inPrimaryPhysicalRange =
ramindania04b8a52023-08-07 18:49:47 -0700723 policy->primaryRanges.physical.includes(modePtr->getPeakFps());
Ady Abraham90f7fd22023-08-16 11:02:00 -0700724 const bool inPrimaryRenderRange = policy->primaryRanges.render.includes(fps);
725 if (((policy->primaryRangeIsSingleRate() && !inPrimaryPhysicalRange) ||
726 !inPrimaryRenderRange) &&
Ady Abrahamdd5bfa92021-01-07 17:56:08 -0800727 !(layer.focused &&
728 (layer.vote == LayerVoteType::ExplicitDefault ||
729 layer.vote == LayerVoteType::ExplicitExact))) {
Ady Abraham20c029c2020-07-06 12:58:05 -0700730 // Only focused layers with ExplicitDefault frame rate settings are allowed to score
Ady Abrahamaae5ed52020-06-26 09:32:43 -0700731 // refresh rates outside the primary range.
Steven Thomasf734df42020-04-13 21:09:28 -0700732 continue;
733 }
734
Ady Abraham68636062022-11-16 17:07:25 -0800735 const float layerScore = calculateLayerScoreLocked(layer, fps, isSeamlessSwitch);
Ady Abrahamae2e3c72022-08-13 05:12:13 +0000736 const float weightedLayerScore = weight * layerScore;
Dominik Laskowskib0054a22022-03-03 09:03:06 -0800737
Ady Abraham13cfb362022-08-13 05:12:13 +0000738 // Layer with fixed source has a special consideration which depends on the
Ady Abrahamae2e3c72022-08-13 05:12:13 +0000739 // mConfig.frameRateMultipleThreshold. We don't want these layers to score
740 // refresh rates above the threshold, but we also don't want to favor the lower
741 // ones by having a greater number of layers scoring them. Instead, we calculate
742 // the score independently for these layers and later decide which
743 // refresh rates to add it. For example, desired 24 fps with 120 Hz threshold should not
744 // score 120 Hz, but desired 60 fps should contribute to the score.
745 const bool fixedSourceLayer = [](LayerVoteType vote) {
746 switch (vote) {
747 case LayerVoteType::ExplicitExactOrMultiple:
748 case LayerVoteType::Heuristic:
749 return true;
750 case LayerVoteType::NoVote:
751 case LayerVoteType::Min:
752 case LayerVoteType::Max:
753 case LayerVoteType::ExplicitDefault:
754 case LayerVoteType::ExplicitExact:
Rachel Leee5514a72023-10-25 16:20:29 -0700755 case LayerVoteType::ExplicitGte:
Rachel Leece6e0042023-06-27 11:22:54 -0700756 case LayerVoteType::ExplicitCategory:
Ady Abrahamae2e3c72022-08-13 05:12:13 +0000757 return false;
758 }
759 }(layer.vote);
Ady Abraham62f51d92022-08-24 22:20:22 +0000760 const bool layerBelowThreshold = mConfig.frameRateMultipleThreshold != 0 &&
Ady Abrahamae2e3c72022-08-13 05:12:13 +0000761 layer.desiredRefreshRate <
762 Fps::fromValue(mConfig.frameRateMultipleThreshold / 2);
Ady Abraham62f51d92022-08-24 22:20:22 +0000763 if (fixedSourceLayer && layerBelowThreshold) {
Ady Abraham13cfb362022-08-13 05:12:13 +0000764 const bool modeAboveThreshold =
ramindania04b8a52023-08-07 18:49:47 -0700765 modePtr->getPeakFps() >= Fps::fromValue(mConfig.frameRateMultipleThreshold);
Ady Abraham62f51d92022-08-24 22:20:22 +0000766 if (modeAboveThreshold) {
ramindania04b8a52023-08-07 18:49:47 -0700767 ALOGV("%s gives %s (%s(%s)) fixed source (above threshold) score of %.4f",
Ady Abraham68636062022-11-16 17:07:25 -0800768 formatLayerInfo(layer, weight).c_str(), to_string(fps).c_str(),
ramindania04b8a52023-08-07 18:49:47 -0700769 to_string(modePtr->getPeakFps()).c_str(),
770 to_string(modePtr->getVsyncRate()).c_str(), layerScore);
Ady Abraham62f51d92022-08-24 22:20:22 +0000771 fixedRateBelowThresholdLayersScore.modeAboveThreshold += weightedLayerScore;
Ady Abrahamae2e3c72022-08-13 05:12:13 +0000772 } else {
ramindania04b8a52023-08-07 18:49:47 -0700773 ALOGV("%s gives %s (%s(%s)) fixed source (below threshold) score of %.4f",
Ady Abraham68636062022-11-16 17:07:25 -0800774 formatLayerInfo(layer, weight).c_str(), to_string(fps).c_str(),
ramindania04b8a52023-08-07 18:49:47 -0700775 to_string(modePtr->getPeakFps()).c_str(),
776 to_string(modePtr->getVsyncRate()).c_str(), layerScore);
Ady Abraham62f51d92022-08-24 22:20:22 +0000777 fixedRateBelowThresholdLayersScore.modeBelowThreshold += weightedLayerScore;
Ady Abrahamae2e3c72022-08-13 05:12:13 +0000778 }
779 } else {
ramindania04b8a52023-08-07 18:49:47 -0700780 ALOGV("%s gives %s (%s(%s)) score of %.4f", formatLayerInfo(layer, weight).c_str(),
781 to_string(fps).c_str(), to_string(modePtr->getPeakFps()).c_str(),
782 to_string(modePtr->getVsyncRate()).c_str(), layerScore);
Ady Abrahamae2e3c72022-08-13 05:12:13 +0000783 overallScore += weightedLayerScore;
784 }
Ady Abraham8a82ba62020-01-17 12:43:17 -0800785 }
786 }
787
Ady Abrahamae2e3c72022-08-13 05:12:13 +0000788 // We want to find the best refresh rate without the fixed source layers,
Ady Abraham62f51d92022-08-24 22:20:22 +0000789 // so we could know whether we should add the modeAboveThreshold scores or not.
Ady Abrahamae2e3c72022-08-13 05:12:13 +0000790 // If the best refresh rate is already above the threshold, it means that
791 // some non-fixed source layers already scored it, so we can just add the score
792 // for all fixed source layers, even the ones that are above the threshold.
793 const bool maxScoreAboveThreshold = [&] {
794 if (mConfig.frameRateMultipleThreshold == 0 || scores.empty()) {
795 return false;
796 }
797
798 const auto maxScoreIt =
799 std::max_element(scores.begin(), scores.end(),
800 [](RefreshRateScore max, RefreshRateScore current) {
Ady Abraham68636062022-11-16 17:07:25 -0800801 return current.overallScore > max.overallScore;
Ady Abrahamae2e3c72022-08-13 05:12:13 +0000802 });
ramindania04b8a52023-08-07 18:49:47 -0700803 ALOGV("%s (%s(%s)) is the best refresh rate without fixed source layers. It is %s the "
Ady Abraham68636062022-11-16 17:07:25 -0800804 "threshold for "
Ady Abrahamae2e3c72022-08-13 05:12:13 +0000805 "refresh rate multiples",
Ady Abraham68636062022-11-16 17:07:25 -0800806 to_string(maxScoreIt->frameRateMode.fps).c_str(),
ramindania04b8a52023-08-07 18:49:47 -0700807 to_string(maxScoreIt->frameRateMode.modePtr->getPeakFps()).c_str(),
808 to_string(maxScoreIt->frameRateMode.modePtr->getVsyncRate()).c_str(),
Ady Abrahamae2e3c72022-08-13 05:12:13 +0000809 maxScoreAboveThreshold ? "above" : "below");
ramindania04b8a52023-08-07 18:49:47 -0700810 return maxScoreIt->frameRateMode.modePtr->getPeakFps() >=
Ady Abrahamae2e3c72022-08-13 05:12:13 +0000811 Fps::fromValue(mConfig.frameRateMultipleThreshold);
812 }();
813
814 // Now we can add the fixed rate layers score
Ady Abraham68636062022-11-16 17:07:25 -0800815 for (auto& [frameRateMode, overallScore, fixedRateBelowThresholdLayersScore] : scores) {
Ady Abraham62f51d92022-08-24 22:20:22 +0000816 overallScore += fixedRateBelowThresholdLayersScore.modeBelowThreshold;
Ady Abrahamae2e3c72022-08-13 05:12:13 +0000817 if (maxScoreAboveThreshold) {
Ady Abraham62f51d92022-08-24 22:20:22 +0000818 overallScore += fixedRateBelowThresholdLayersScore.modeAboveThreshold;
Ady Abrahamae2e3c72022-08-13 05:12:13 +0000819 }
ramindania04b8a52023-08-07 18:49:47 -0700820 ALOGV("%s (%s(%s)) adjusted overallScore is %.4f", to_string(frameRateMode.fps).c_str(),
821 to_string(frameRateMode.modePtr->getPeakFps()).c_str(),
822 to_string(frameRateMode.modePtr->getVsyncRate()).c_str(), overallScore);
Ady Abrahamae2e3c72022-08-13 05:12:13 +0000823 }
824
825 // Now that we scored all the refresh rates we need to pick the one that got the highest
ramindanid72ba162022-09-09 21:33:40 +0000826 // overallScore. Sort the scores based on their overallScore in descending order of priority.
827 const RefreshRateOrder refreshRateOrder =
828 maxVoteLayers > 0 ? RefreshRateOrder::Descending : RefreshRateOrder::Ascending;
829 std::sort(scores.begin(), scores.end(),
830 RefreshRateScoreComparator{.refreshRateOrder = refreshRateOrder});
ramindanid72ba162022-09-09 21:33:40 +0000831
Ady Abraham68636062022-11-16 17:07:25 -0800832 FrameRateRanking ranking;
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400833 ranking.reserve(scores.size());
834
835 std::transform(scores.begin(), scores.end(), back_inserter(ranking),
ramindanid72ba162022-09-09 21:33:40 +0000836 [](const RefreshRateScore& score) {
Ady Abraham68636062022-11-16 17:07:25 -0800837 return ScoredFrameRate{score.frameRateMode, score.overallScore};
ramindanid72ba162022-09-09 21:33:40 +0000838 });
Ady Abraham34702102020-02-10 14:12:05 -0800839
Ady Abraham37d46922022-10-05 13:08:51 -0700840 const bool noLayerScore = std::all_of(scores.begin(), scores.end(), [](RefreshRateScore score) {
841 return score.overallScore == 0;
842 });
843
Rachel Lee7bedfbf2024-09-04 19:35:44 -0700844 // TODO(b/364651864): Evaluate correctness of primaryRangeIsSingleRate.
845 if (!mIsVrrDevice.load() && policy->primaryRangeIsSingleRate()) {
Alec Mouri11232a22020-05-14 18:06:25 -0700846 // If we never scored any layers, then choose the rate from the primary
847 // range instead of picking a random score from the app range.
Ady Abraham37d46922022-10-05 13:08:51 -0700848 if (noLayerScore) {
ramindanid72ba162022-09-09 21:33:40 +0000849 ALOGV("Layers not scored");
Ady Abrahamccf63862023-01-19 11:44:01 -0800850 const auto descending = rankFrameRates(anchorGroup, RefreshRateOrder::Descending);
Vishnu Nairbe0ad902024-06-27 23:38:43 +0000851 SFTRACE_FORMAT_INSTANT("%s (Layers not scored)",
852 to_string(descending.front().frameRateMode.fps).c_str());
Ady Abrahamccf63862023-01-19 11:44:01 -0800853 return {descending, kNoSignals};
Alec Mouri11232a22020-05-14 18:06:25 -0700854 } else {
Rachel Lee67afbea2023-09-28 15:35:07 -0700855 ALOGV("primaryRangeIsSingleRate");
Vishnu Nairbe0ad902024-06-27 23:38:43 +0000856 SFTRACE_FORMAT_INSTANT("%s (primaryRangeIsSingleRate)",
857 to_string(ranking.front().frameRateMode.fps).c_str());
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400858 return {ranking, kNoSignals};
Alec Mouri11232a22020-05-14 18:06:25 -0700859 }
860 }
861
Steven Thomasf734df42020-04-13 21:09:28 -0700862 // Consider the touch event if there are no ExplicitDefault layers. ExplicitDefault are mostly
863 // interactive (as opposed to ExplicitExactOrMultiple) and therefore if those posted an explicit
864 // vote we should not change it if we get a touch event. Only apply touch boost if it will
865 // actually increase the refresh rate over the normal selection.
Dominik Laskowski788cba82024-03-15 11:29:11 -0400866 const auto isTouchBoostForExplicitExact = [&]() -> bool {
Ady Abraham68636062022-11-16 17:07:25 -0800867 if (supportsAppFrameRateOverrideByContent()) {
Ady Abraham5e4e9832021-06-14 13:40:56 -0700868 // Enable touch boost if there are other layers besides exact
Ady Abraham52ad61c2024-03-06 11:39:35 -0800869 return explicitExact + noVoteLayers + explicitGteLayers != layers.size();
Ady Abraham5e4e9832021-06-14 13:40:56 -0700870 } else {
871 // Enable touch boost if there are no exact layers
872 return explicitExact == 0;
873 }
Dominik Laskowski788cba82024-03-15 11:29:11 -0400874 };
Dominik Laskowski6eab42d2021-09-13 14:34:13 -0700875
Dominik Laskowski788cba82024-03-15 11:29:11 -0400876 const auto isTouchBoostForCategory = [&]() -> bool {
877 return explicitCategoryVoteLayers + noVoteLayers + explicitGteLayers != layers.size();
878 };
Dominik Laskowski6eab42d2021-09-13 14:34:13 -0700879
Rachel Lee9e2416c2024-01-23 15:03:57 -0800880 // A method for UI Toolkit to send the touch signal via "HighHint" category vote,
881 // which will touch boost when there are no ExplicitDefault layer votes. This is an
882 // incomplete solution but accounts for cases such as games that use `setFrameRate` with default
883 // compatibility to limit the frame rate, which should not have touch boost.
Rachel Lee9580ff12023-12-26 17:33:41 -0800884 const bool hasInteraction = signals.touch || interactiveLayers > 0;
Rachel Lee9e2416c2024-01-23 15:03:57 -0800885
Dominik Laskowski788cba82024-03-15 11:29:11 -0400886 if (hasInteraction && explicitDefaultVoteLayers == 0 && isTouchBoostForExplicitExact() &&
887 isTouchBoostForCategory()) {
888 const auto touchRefreshRates = rankFrameRates(anchorGroup, RefreshRateOrder::Descending);
889 using fps_approx_ops::operator<;
890
Rachel Lee7bedfbf2024-09-04 19:35:44 -0700891 if (scores.front().frameRateMode.fps <= touchRefreshRates.front().frameRateMode.fps) {
892 ALOGV("Touch Boost [late]");
Vishnu Nairbe0ad902024-06-27 23:38:43 +0000893 SFTRACE_FORMAT_INSTANT("%s (Touch Boost [late])",
894 to_string(touchRefreshRates.front().frameRateMode.fps).c_str());
Dominik Laskowski788cba82024-03-15 11:29:11 -0400895 return {touchRefreshRates, GlobalSignals{.touch = true}};
896 }
Steven Thomasf734df42020-04-13 21:09:28 -0700897 }
898
Ady Abraham37d46922022-10-05 13:08:51 -0700899 // If we never scored any layers, and we don't favor high refresh rates, prefer to stay with the
900 // current config
901 if (noLayerScore && refreshRateOrder == RefreshRateOrder::Ascending) {
Rachel Lee67afbea2023-09-28 15:35:07 -0700902 ALOGV("preferredDisplayMode");
Ady Abrahamccf63862023-01-19 11:44:01 -0800903 const auto ascendingWithPreferred =
904 rankFrameRates(anchorGroup, RefreshRateOrder::Ascending, activeMode.getId());
Vishnu Nairbe0ad902024-06-27 23:38:43 +0000905 SFTRACE_FORMAT_INSTANT("%s (preferredDisplayMode)",
906 to_string(ascendingWithPreferred.front().frameRateMode.fps).c_str());
Ady Abrahamccf63862023-01-19 11:44:01 -0800907 return {ascendingWithPreferred, kNoSignals};
Ady Abraham37d46922022-10-05 13:08:51 -0700908 }
909
Dominik Laskowski788cba82024-03-15 11:29:11 -0400910 ALOGV("%s (scored)", to_string(ranking.front().frameRateMode.fps).c_str());
Vishnu Nairbe0ad902024-06-27 23:38:43 +0000911 SFTRACE_FORMAT_INSTANT("%s (scored)", to_string(ranking.front().frameRateMode.fps).c_str());
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400912 return {ranking, kNoSignals};
Ady Abraham34702102020-02-10 14:12:05 -0800913}
914
Dominik Laskowskid82e0f02022-10-26 15:23:04 -0400915using LayerRequirementPtrs = std::vector<const RefreshRateSelector::LayerRequirement*>;
916using PerUidLayerRequirements = std::unordered_map<uid_t, LayerRequirementPtrs>;
917
918PerUidLayerRequirements groupLayersByUid(
919 const std::vector<RefreshRateSelector::LayerRequirement>& layers) {
920 PerUidLayerRequirements layersByUid;
Ady Abraham62a0be22020-12-08 16:54:10 -0800921 for (const auto& layer : layers) {
Dominik Laskowskid82e0f02022-10-26 15:23:04 -0400922 const auto it = layersByUid.emplace(layer.ownerUid, LayerRequirementPtrs()).first;
923 auto& layersWithSameUid = it->second;
Ady Abraham62a0be22020-12-08 16:54:10 -0800924 layersWithSameUid.push_back(&layer);
925 }
926
927 // Remove uids that can't have a frame rate override
Dominik Laskowskid82e0f02022-10-26 15:23:04 -0400928 for (auto it = layersByUid.begin(); it != layersByUid.end();) {
929 const auto& layersWithSameUid = it->second;
Ady Abraham62a0be22020-12-08 16:54:10 -0800930 bool skipUid = false;
931 for (const auto& layer : layersWithSameUid) {
Dominik Laskowskid82e0f02022-10-26 15:23:04 -0400932 using LayerVoteType = RefreshRateSelector::LayerVoteType;
933
934 if (layer->vote == LayerVoteType::Max || layer->vote == LayerVoteType::Heuristic) {
Ady Abraham62a0be22020-12-08 16:54:10 -0800935 skipUid = true;
936 break;
937 }
938 }
939 if (skipUid) {
Dominik Laskowskid82e0f02022-10-26 15:23:04 -0400940 it = layersByUid.erase(it);
Ady Abraham62a0be22020-12-08 16:54:10 -0800941 } else {
Dominik Laskowskid82e0f02022-10-26 15:23:04 -0400942 ++it;
Ady Abraham62a0be22020-12-08 16:54:10 -0800943 }
944 }
945
946 return layersByUid;
947}
948
Dominik Laskowskid82e0f02022-10-26 15:23:04 -0400949auto RefreshRateSelector::getFrameRateOverrides(const std::vector<LayerRequirement>& layers,
950 Fps displayRefreshRate,
951 GlobalSignals globalSignals) const
952 -> UidToFrameRateOverride {
Vishnu Nairbe0ad902024-06-27 23:38:43 +0000953 SFTRACE_CALL();
Ady Abraham68636062022-11-16 17:07:25 -0800954 if (mConfig.enableFrameRateOverride == Config::FrameRateOverride::Disabled) {
955 return {};
Dominik Laskowskib0054a22022-03-03 09:03:06 -0800956 }
957
Ady Abraham68636062022-11-16 17:07:25 -0800958 ALOGV("%s: %zu layers", __func__, layers.size());
959 std::lock_guard lock(mLock);
960
Ady Abraham8ca643a2022-10-18 18:26:47 -0700961 const auto* policyPtr = getCurrentPolicyLocked();
962 // We don't want to run lower than 30fps
ramindania04b8a52023-08-07 18:49:47 -0700963 // TODO(b/297600226): revise this for dVRR
Ady Abraham8ca643a2022-10-18 18:26:47 -0700964 const Fps minFrameRate = std::max(policyPtr->appRequestRanges.render.min, 30_Hz, isApproxLess);
965
966 using fps_approx_ops::operator/;
967 const unsigned numMultiples = displayRefreshRate / minFrameRate;
968
969 std::vector<std::pair<Fps, float>> scoredFrameRates;
970 scoredFrameRates.reserve(numMultiples);
971
972 for (unsigned n = numMultiples; n > 0; n--) {
973 const Fps divisor = displayRefreshRate / n;
974 if (mConfig.enableFrameRateOverride ==
Ady Abraham68636062022-11-16 17:07:25 -0800975 Config::FrameRateOverride::AppOverrideNativeRefreshRates &&
976 !isNativeRefreshRate(divisor)) {
Ady Abraham8ca643a2022-10-18 18:26:47 -0700977 continue;
978 }
979
980 if (policyPtr->appRequestRanges.render.includes(divisor)) {
981 ALOGV("%s: adding %s as a potential frame rate", __func__, to_string(divisor).c_str());
982 scoredFrameRates.emplace_back(divisor, 0);
983 }
984 }
Dominik Laskowskib0054a22022-03-03 09:03:06 -0800985
Dominik Laskowskid82e0f02022-10-26 15:23:04 -0400986 const auto layersByUid = groupLayersByUid(layers);
Ady Abraham62a0be22020-12-08 16:54:10 -0800987 UidToFrameRateOverride frameRateOverrides;
988 for (const auto& [uid, layersWithSameUid] : layersByUid) {
Rachel Lee93bec072024-02-23 17:29:34 -0800989 // Look for cases that should not have frame rate overrides.
990 bool hasExplicitExactOrMultiple = false;
991 bool hasExplicitDefault = false;
992 bool hasHighHint = false;
993 for (const auto& layer : layersWithSameUid) {
994 switch (layer->vote) {
995 case LayerVoteType::ExplicitExactOrMultiple:
996 hasExplicitExactOrMultiple = true;
997 break;
998 case LayerVoteType::ExplicitDefault:
999 hasExplicitDefault = true;
1000 break;
1001 case LayerVoteType::ExplicitCategory:
1002 if (layer->frameRateCategory == FrameRateCategory::HighHint) {
1003 hasHighHint = true;
1004 }
1005 break;
1006 default:
1007 // No action
1008 break;
1009 }
1010 if (hasExplicitExactOrMultiple && hasExplicitDefault && hasHighHint) {
1011 break;
1012 }
1013 }
Ady Abrahamdd5bfa92021-01-07 17:56:08 -08001014
Rachel Lee93bec072024-02-23 17:29:34 -08001015 // Layers with ExplicitExactOrMultiple expect touch boost
Dominik Laskowski6eab42d2021-09-13 14:34:13 -07001016 if (globalSignals.touch && hasExplicitExactOrMultiple) {
Ady Abrahamdd5bfa92021-01-07 17:56:08 -08001017 continue;
1018 }
1019
Rachel Lee93bec072024-02-23 17:29:34 -08001020 // Mirrors getRankedFrameRates. If there is no ExplicitDefault, expect touch boost and
1021 // skip frame rate override.
1022 if (hasHighHint && !hasExplicitDefault) {
1023 continue;
1024 }
1025
Ady Abraham8ca643a2022-10-18 18:26:47 -07001026 for (auto& [_, score] : scoredFrameRates) {
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001027 score = 0;
Ady Abraham62a0be22020-12-08 16:54:10 -08001028 }
1029
1030 for (const auto& layer : layersWithSameUid) {
Rachel Lee47adfcf2023-09-15 17:36:56 -07001031 if (layer->isNoVote() || layer->frameRateCategory == FrameRateCategory::NoPreference ||
1032 layer->vote == LayerVoteType::Min) {
Ady Abraham62a0be22020-12-08 16:54:10 -08001033 continue;
1034 }
1035
1036 LOG_ALWAYS_FATAL_IF(layer->vote != LayerVoteType::ExplicitDefault &&
Rachel Leece6e0042023-06-27 11:22:54 -07001037 layer->vote != LayerVoteType::ExplicitExactOrMultiple &&
1038 layer->vote != LayerVoteType::ExplicitExact &&
Rachel Leeef9fb682024-02-23 11:04:33 -08001039 layer->vote != LayerVoteType::ExplicitGte &&
Rachel Leece6e0042023-06-27 11:22:54 -07001040 layer->vote != LayerVoteType::ExplicitCategory,
1041 "Invalid layer vote type for frame rate overrides");
Ady Abraham8ca643a2022-10-18 18:26:47 -07001042 for (auto& [fps, score] : scoredFrameRates) {
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001043 constexpr bool isSeamlessSwitch = true;
Ady Abraham8ca643a2022-10-18 18:26:47 -07001044 const auto layerScore = calculateLayerScoreLocked(*layer, fps, isSeamlessSwitch);
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001045 score += layer->weight * layerScore;
Ady Abraham62a0be22020-12-08 16:54:10 -08001046 }
1047 }
1048
Ady Abraham62a0be22020-12-08 16:54:10 -08001049 // If we never scored any layers, we don't have a preferred frame rate
Ady Abraham8ca643a2022-10-18 18:26:47 -07001050 if (std::all_of(scoredFrameRates.begin(), scoredFrameRates.end(),
1051 [](const auto& scoredFrameRate) {
1052 const auto [_, score] = scoredFrameRate;
1053 return score == 0;
1054 })) {
Ady Abraham62a0be22020-12-08 16:54:10 -08001055 continue;
1056 }
1057
ramindanid72ba162022-09-09 21:33:40 +00001058 // Now that we scored all the refresh rates we need to pick the lowest refresh rate
1059 // that got the highest score.
Ady Abraham8ca643a2022-10-18 18:26:47 -07001060 const auto [overrideFps, _] =
1061 *std::max_element(scoredFrameRates.begin(), scoredFrameRates.end(),
1062 [](const auto& lhsPair, const auto& rhsPair) {
1063 const float lhs = lhsPair.second;
1064 const float rhs = rhsPair.second;
Ady Abraham68636062022-11-16 17:07:25 -08001065 return lhs < rhs && !ScoredFrameRate::scoresEqual(lhs, rhs);
Ady Abraham8ca643a2022-10-18 18:26:47 -07001066 });
1067 ALOGV("%s: overriding to %s for uid=%d", __func__, to_string(overrideFps).c_str(), uid);
Vishnu Nairbe0ad902024-06-27 23:38:43 +00001068 SFTRACE_FORMAT_INSTANT("%s: overriding to %s for uid=%d", __func__,
1069 to_string(overrideFps).c_str(), uid);
Vishnu Nair2665ca92024-07-09 22:08:15 +00001070 if (SFTRACE_ENABLED() && FlagManager::getInstance().trace_frame_rate_override()) {
Ady Abraham1d0cae92024-06-14 13:41:12 -07001071 std::stringstream ss;
1072 ss << "FrameRateOverride " << uid;
Vishnu Nairbe0ad902024-06-27 23:38:43 +00001073 SFTRACE_INT(ss.str().c_str(), overrideFps.getIntValue());
Ady Abraham1d0cae92024-06-14 13:41:12 -07001074 }
Ady Abraham8ca643a2022-10-18 18:26:47 -07001075 frameRateOverrides.emplace(uid, overrideFps);
Ady Abraham62a0be22020-12-08 16:54:10 -08001076 }
1077
1078 return frameRateOverrides;
1079}
1080
Ady Abraham0aa373a2022-11-22 13:56:50 -08001081ftl::Optional<FrameRateMode> RefreshRateSelector::onKernelTimerChanged(
Dominik Laskowski59746512023-11-19 09:30:24 -05001082 ftl::Optional<DisplayModeId> desiredModeIdOpt, bool timerExpired) const {
Ady Abraham2139f732019-11-13 18:56:40 -08001083 std::lock_guard lock(mLock);
Marin Shalamanoveadf2e72020-12-10 15:35:28 +01001084
Dominik Laskowski61651552023-11-19 10:06:19 -05001085 const auto current =
1086 desiredModeIdOpt
1087 .and_then([this](DisplayModeId modeId)
1088 REQUIRES(mLock) { return mDisplayModes.get(modeId); })
1089 .transform([](const DisplayModePtr& modePtr) {
1090 return FrameRateMode{modePtr->getPeakFps(), ftl::as_non_null(modePtr)};
1091 })
1092 .or_else([this] {
1093 ftl::FakeGuard guard(mLock);
1094 return std::make_optional(getActiveModeLocked());
1095 })
1096 .value();
Marin Shalamanoveadf2e72020-12-10 15:35:28 +01001097
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001098 const DisplayModePtr& min = mMinRefreshRateModeIt->second;
Ady Abraham0aa373a2022-11-22 13:56:50 -08001099 if (current.modePtr->getId() == min->getId()) {
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001100 return {};
Marin Shalamanoveadf2e72020-12-10 15:35:28 +01001101 }
1102
ramindania04b8a52023-08-07 18:49:47 -07001103 return timerExpired ? FrameRateMode{min->getPeakFps(), ftl::as_non_null(min)} : current;
Steven Thomasf734df42020-04-13 21:09:28 -07001104}
1105
Dominik Laskowskid82e0f02022-10-26 15:23:04 -04001106const DisplayModePtr& RefreshRateSelector::getMinRefreshRateByPolicyLocked() const {
Ady Abrahamace3d052022-11-17 16:25:05 -08001107 const auto& activeMode = *getActiveModeLocked().modePtr;
Dominik Laskowskif8734e02022-08-26 09:06:59 -07001108
Ady Abraham68636062022-11-16 17:07:25 -08001109 for (const FrameRateMode& mode : mPrimaryFrameRates) {
1110 if (activeMode.getGroup() == mode.modePtr->getGroup()) {
Ady Abrahamace3d052022-11-17 16:25:05 -08001111 return mode.modePtr.get();
Marin Shalamanov46084422020-10-13 12:33:42 +02001112 }
1113 }
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001114
Dominik Laskowskif8734e02022-08-26 09:06:59 -07001115 ALOGE("Can't find min refresh rate by policy with the same mode group as the current mode %s",
1116 to_string(activeMode).c_str());
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001117
1118 // Default to the lowest refresh rate.
Ady Abrahamace3d052022-11-17 16:25:05 -08001119 return mPrimaryFrameRates.front().modePtr.get();
Ady Abraham2139f732019-11-13 18:56:40 -08001120}
1121
Dominik Laskowskid82e0f02022-10-26 15:23:04 -04001122const DisplayModePtr& RefreshRateSelector::getMaxRefreshRateByPolicyLocked(int anchorGroup) const {
Ady Abrahamace3d052022-11-17 16:25:05 -08001123 const ftl::NonNull<DisplayModePtr>* maxByAnchor = &mPrimaryFrameRates.back().modePtr;
1124 const ftl::NonNull<DisplayModePtr>* max = &mPrimaryFrameRates.back().modePtr;
Ady Abraham68636062022-11-16 17:07:25 -08001125
1126 bool maxByAnchorFound = false;
1127 for (auto it = mPrimaryFrameRates.rbegin(); it != mPrimaryFrameRates.rend(); ++it) {
1128 using namespace fps_approx_ops;
ramindania04b8a52023-08-07 18:49:47 -07001129 if (it->modePtr->getPeakFps() > (*max)->getPeakFps()) {
Ady Abraham68636062022-11-16 17:07:25 -08001130 max = &it->modePtr;
Marin Shalamanov46084422020-10-13 12:33:42 +02001131 }
Ady Abraham68636062022-11-16 17:07:25 -08001132
1133 if (anchorGroup == it->modePtr->getGroup() &&
ramindania04b8a52023-08-07 18:49:47 -07001134 it->modePtr->getPeakFps() >= (*maxByAnchor)->getPeakFps()) {
Ady Abraham68636062022-11-16 17:07:25 -08001135 maxByAnchorFound = true;
1136 maxByAnchor = &it->modePtr;
1137 }
1138 }
1139
1140 if (maxByAnchorFound) {
Ady Abrahamace3d052022-11-17 16:25:05 -08001141 return maxByAnchor->get();
Marin Shalamanov46084422020-10-13 12:33:42 +02001142 }
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001143
ramindanid72ba162022-09-09 21:33:40 +00001144 ALOGE("Can't find max refresh rate by policy with the same group %d", anchorGroup);
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001145
1146 // Default to the highest refresh rate.
Ady Abrahamace3d052022-11-17 16:25:05 -08001147 return max->get();
Ady Abraham2139f732019-11-13 18:56:40 -08001148}
1149
Ady Abraham68636062022-11-16 17:07:25 -08001150auto RefreshRateSelector::rankFrameRates(std::optional<int> anchorGroupOpt,
1151 RefreshRateOrder refreshRateOrder,
Rachel Lee67afbea2023-09-28 15:35:07 -07001152 std::optional<DisplayModeId> preferredDisplayModeOpt,
1153 const RankFrameRatesPredicate& predicate) const
Ady Abraham68636062022-11-16 17:07:25 -08001154 -> FrameRateRanking {
Ady Abrahama5992df2023-01-27 21:10:57 -08001155 using fps_approx_ops::operator<;
Ady Abraham68636062022-11-16 17:07:25 -08001156 const char* const whence = __func__;
Ady Abrahama5992df2023-01-27 21:10:57 -08001157
1158 // find the highest frame rate for each display mode
1159 ftl::SmallMap<DisplayModeId, Fps, 8> maxRenderRateForMode;
1160 const bool ascending = (refreshRateOrder == RefreshRateOrder::Ascending);
1161 if (ascending) {
1162 // TODO(b/266481656): Once this bug is fixed, we can remove this workaround and actually
1163 // use a lower frame rate when we want Ascending frame rates.
1164 for (const auto& frameRateMode : mPrimaryFrameRates) {
1165 if (anchorGroupOpt && frameRateMode.modePtr->getGroup() != anchorGroupOpt) {
1166 continue;
1167 }
1168
1169 const auto [iter, _] = maxRenderRateForMode.try_emplace(frameRateMode.modePtr->getId(),
1170 frameRateMode.fps);
1171 if (iter->second < frameRateMode.fps) {
1172 iter->second = frameRateMode.fps;
1173 }
1174 }
1175 }
1176
Ady Abraham68636062022-11-16 17:07:25 -08001177 std::deque<ScoredFrameRate> ranking;
1178 const auto rankFrameRate = [&](const FrameRateMode& frameRateMode) REQUIRES(mLock) {
1179 const auto& modePtr = frameRateMode.modePtr;
Rachel Lee67afbea2023-09-28 15:35:07 -07001180 if ((anchorGroupOpt && modePtr->getGroup() != anchorGroupOpt) ||
1181 !predicate(frameRateMode)) {
Ady Abraham37d46922022-10-05 13:08:51 -07001182 return;
ramindanid72ba162022-09-09 21:33:40 +00001183 }
Ady Abraham37d46922022-10-05 13:08:51 -07001184
Ady Abraham3f965922023-01-23 17:18:29 -08001185 const bool ascending = (refreshRateOrder == RefreshRateOrder::Ascending);
ramindanif7075202023-03-10 00:24:34 +00001186 const auto id = modePtr->getId();
Ady Abrahama5992df2023-01-27 21:10:57 -08001187 if (ascending && frameRateMode.fps < *maxRenderRateForMode.get(id)) {
Ady Abraham3f965922023-01-23 17:18:29 -08001188 // TODO(b/266481656): Once this bug is fixed, we can remove this workaround and actually
1189 // use a lower frame rate when we want Ascending frame rates.
1190 return;
1191 }
1192
Rachel Leee5514a72023-10-25 16:20:29 -07001193 float score = calculateDistanceScoreFromMaxLocked(frameRateMode.fps);
Ady Abraham3f965922023-01-23 17:18:29 -08001194
1195 if (ascending) {
Ady Abraham37d46922022-10-05 13:08:51 -07001196 score = 1.0f / score;
1197 }
ramindanif7075202023-03-10 00:24:34 +00001198
1199 constexpr float kScore = std::numeric_limits<float>::max();
Ady Abraham37d46922022-10-05 13:08:51 -07001200 if (preferredDisplayModeOpt) {
Ady Abraham68636062022-11-16 17:07:25 -08001201 if (*preferredDisplayModeOpt == modePtr->getId()) {
Ady Abraham68636062022-11-16 17:07:25 -08001202 ranking.emplace_front(ScoredFrameRate{frameRateMode, kScore});
Ady Abraham37d46922022-10-05 13:08:51 -07001203 return;
1204 }
1205 constexpr float kNonPreferredModePenalty = 0.95f;
1206 score *= kNonPreferredModePenalty;
ramindanif7075202023-03-10 00:24:34 +00001207 } else if (ascending && id == getMinRefreshRateByPolicyLocked()->getId()) {
1208 // TODO(b/266481656): Once this bug is fixed, we can remove this workaround
1209 // and actually use a lower frame rate when we want Ascending frame rates.
1210 ranking.emplace_front(ScoredFrameRate{frameRateMode, kScore});
1211 return;
Ady Abraham37d46922022-10-05 13:08:51 -07001212 }
Ady Abraham3f965922023-01-23 17:18:29 -08001213
ramindania04b8a52023-08-07 18:49:47 -07001214 ALOGV("%s(%s) %s (%s(%s)) scored %.2f", whence, ftl::enum_string(refreshRateOrder).c_str(),
1215 to_string(frameRateMode.fps).c_str(), to_string(modePtr->getPeakFps()).c_str(),
1216 to_string(modePtr->getVsyncRate()).c_str(), score);
Ady Abraham68636062022-11-16 17:07:25 -08001217 ranking.emplace_back(ScoredFrameRate{frameRateMode, score});
ramindanid72ba162022-09-09 21:33:40 +00001218 };
1219
1220 if (refreshRateOrder == RefreshRateOrder::Ascending) {
Ady Abraham68636062022-11-16 17:07:25 -08001221 std::for_each(mPrimaryFrameRates.begin(), mPrimaryFrameRates.end(), rankFrameRate);
ramindanid72ba162022-09-09 21:33:40 +00001222 } else {
Ady Abraham68636062022-11-16 17:07:25 -08001223 std::for_each(mPrimaryFrameRates.rbegin(), mPrimaryFrameRates.rend(), rankFrameRate);
ramindanid72ba162022-09-09 21:33:40 +00001224 }
1225
Dominik Laskowski530d6bd2022-10-10 16:55:54 -04001226 if (!ranking.empty() || !anchorGroupOpt) {
1227 return {ranking.begin(), ranking.end()};
ramindanid72ba162022-09-09 21:33:40 +00001228 }
1229
1230 ALOGW("Can't find %s refresh rate by policy with the same mode group"
1231 " as the mode group %d",
1232 refreshRateOrder == RefreshRateOrder::Ascending ? "min" : "max", anchorGroupOpt.value());
1233
Dominik Laskowski530d6bd2022-10-10 16:55:54 -04001234 constexpr std::optional<int> kNoAnchorGroup = std::nullopt;
Ady Abraham68636062022-11-16 17:07:25 -08001235 return rankFrameRates(kNoAnchorGroup, refreshRateOrder, preferredDisplayModeOpt);
ramindanid72ba162022-09-09 21:33:40 +00001236}
1237
Ady Abrahamace3d052022-11-17 16:25:05 -08001238FrameRateMode RefreshRateSelector::getActiveMode() const {
Ady Abraham2139f732019-11-13 18:56:40 -08001239 std::lock_guard lock(mLock);
Ady Abrahamace3d052022-11-17 16:25:05 -08001240 return getActiveModeLocked();
Dominik Laskowskif8734e02022-08-26 09:06:59 -07001241}
1242
Ady Abrahamace3d052022-11-17 16:25:05 -08001243const FrameRateMode& RefreshRateSelector::getActiveModeLocked() const {
1244 return *mActiveModeOpt;
Dominik Laskowskif8734e02022-08-26 09:06:59 -07001245}
1246
Ady Abrahamace3d052022-11-17 16:25:05 -08001247void RefreshRateSelector::setActiveMode(DisplayModeId modeId, Fps renderFrameRate) {
Ady Abraham2139f732019-11-13 18:56:40 -08001248 std::lock_guard lock(mLock);
Marin Shalamanov4c7831e2021-06-08 20:44:06 +02001249
Ady Abraham68636062022-11-16 17:07:25 -08001250 // Invalidate the cached invocation to getRankedFrameRates. This forces
1251 // the refresh rate to be recomputed on the next call to getRankedFrameRates.
1252 mGetRankedFrameRatesCache.reset();
Marin Shalamanov4c7831e2021-06-08 20:44:06 +02001253
Ady Abrahamace3d052022-11-17 16:25:05 -08001254 const auto activeModeOpt = mDisplayModes.get(modeId);
1255 LOG_ALWAYS_FATAL_IF(!activeModeOpt);
1256
1257 mActiveModeOpt.emplace(FrameRateMode{renderFrameRate, ftl::as_non_null(activeModeOpt->get())});
Rachel Lee45681982024-03-14 18:40:15 -07001258 mIsVrrDevice = FlagManager::getInstance().vrr_config() &&
1259 activeModeOpt->get()->getVrrConfig().has_value();
Ady Abrahamb4b1e0a2019-11-20 18:25:35 -08001260}
1261
Dominik Laskowskid82e0f02022-10-26 15:23:04 -04001262RefreshRateSelector::RefreshRateSelector(DisplayModes modes, DisplayModeId activeModeId,
1263 Config config)
rnlee3bd610662021-06-23 16:27:57 -07001264 : mKnownFrameRates(constructKnownFrameRates(modes)), mConfig(config) {
Ady Abraham67231722024-03-21 18:06:21 -07001265 initializeIdleTimer(mConfig.legacyIdleTimerTimeout);
Dominik Laskowskif8734e02022-08-26 09:06:59 -07001266 FTL_FAKE_GUARD(kMainThreadContext, updateDisplayModes(std::move(modes), activeModeId));
Marin Shalamanoveadf2e72020-12-10 15:35:28 +01001267}
1268
Ady Abraham67231722024-03-21 18:06:21 -07001269void RefreshRateSelector::initializeIdleTimer(std::chrono::milliseconds timeout) {
1270 if (timeout > 0ms) {
Ady Abraham9a2ea342021-09-03 17:32:34 -07001271 mIdleTimer.emplace(
Ady Abraham67231722024-03-21 18:06:21 -07001272 "IdleTimer", timeout,
Dominik Laskowski83bd7712022-01-07 14:30:53 -08001273 [this] {
1274 std::scoped_lock lock(mIdleTimerCallbacksMutex);
1275 if (const auto callbacks = getIdleTimerCallbacks()) {
1276 callbacks->onReset();
1277 }
Ady Abraham9a2ea342021-09-03 17:32:34 -07001278 },
Dominik Laskowski83bd7712022-01-07 14:30:53 -08001279 [this] {
1280 std::scoped_lock lock(mIdleTimerCallbacksMutex);
1281 if (const auto callbacks = getIdleTimerCallbacks()) {
1282 callbacks->onExpired();
1283 }
Ady Abraham9a2ea342021-09-03 17:32:34 -07001284 });
Ady Abraham9a2ea342021-09-03 17:32:34 -07001285 }
1286}
1287
Dominik Laskowskid82e0f02022-10-26 15:23:04 -04001288void RefreshRateSelector::updateDisplayModes(DisplayModes modes, DisplayModeId activeModeId) {
Marin Shalamanoveadf2e72020-12-10 15:35:28 +01001289 std::lock_guard lock(mLock);
Marin Shalamanov4c7831e2021-06-08 20:44:06 +02001290
Ady Abraham68636062022-11-16 17:07:25 -08001291 // Invalidate the cached invocation to getRankedFrameRates. This forces
1292 // the refresh rate to be recomputed on the next call to getRankedFrameRates.
1293 mGetRankedFrameRatesCache.reset();
Marin Shalamanov4c7831e2021-06-08 20:44:06 +02001294
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001295 mDisplayModes = std::move(modes);
Ady Abrahamace3d052022-11-17 16:25:05 -08001296 const auto activeModeOpt = mDisplayModes.get(activeModeId);
1297 LOG_ALWAYS_FATAL_IF(!activeModeOpt);
ramindania04b8a52023-08-07 18:49:47 -07001298 mActiveModeOpt = FrameRateMode{activeModeOpt->get()->getPeakFps(),
1299 ftl::as_non_null(activeModeOpt->get())};
Ady Abrahamabc27602020-04-08 17:20:29 -07001300
Ady Abraham68636062022-11-16 17:07:25 -08001301 const auto sortedModes = sortByRefreshRate(mDisplayModes);
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001302 mMinRefreshRateModeIt = sortedModes.front();
1303 mMaxRefreshRateModeIt = sortedModes.back();
1304
Marin Shalamanov75f37252021-02-10 21:43:57 +01001305 // Reset the policy because the old one may no longer be valid.
1306 mDisplayManagerPolicy = {};
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001307 mDisplayManagerPolicy.defaultMode = activeModeId;
Ady Abraham64c2fc02020-12-29 12:07:50 -08001308
Ady Abraham8ca643a2022-10-18 18:26:47 -07001309 mFrameRateOverrideConfig = [&] {
1310 switch (mConfig.enableFrameRateOverride) {
1311 case Config::FrameRateOverride::Disabled:
Ady Abraham68636062022-11-16 17:07:25 -08001312 case Config::FrameRateOverride::AppOverride:
Ady Abraham8ca643a2022-10-18 18:26:47 -07001313 case Config::FrameRateOverride::Enabled:
1314 return mConfig.enableFrameRateOverride;
Ady Abraham68636062022-11-16 17:07:25 -08001315 case Config::FrameRateOverride::AppOverrideNativeRefreshRates:
Ady Abraham8ca643a2022-10-18 18:26:47 -07001316 return shouldEnableFrameRateOverride(sortedModes)
Ady Abraham68636062022-11-16 17:07:25 -08001317 ? Config::FrameRateOverride::AppOverrideNativeRefreshRates
Ady Abraham8ca643a2022-10-18 18:26:47 -07001318 : Config::FrameRateOverride::Disabled;
1319 }
1320 }();
Ady Abraham4899ff82021-01-06 13:53:29 -08001321
Ady Abraham68636062022-11-16 17:07:25 -08001322 if (mConfig.enableFrameRateOverride ==
1323 Config::FrameRateOverride::AppOverrideNativeRefreshRates) {
1324 for (const auto& [_, mode] : mDisplayModes) {
ramindania04b8a52023-08-07 18:49:47 -07001325 mAppOverrideNativeRefreshRates.try_emplace(mode->getPeakFps(), ftl::unit);
Ady Abraham68636062022-11-16 17:07:25 -08001326 }
1327 }
1328
Ady Abrahamabc27602020-04-08 17:20:29 -07001329 constructAvailableRefreshRates();
Ady Abrahamb4b1e0a2019-11-20 18:25:35 -08001330}
1331
Dominik Laskowskid82e0f02022-10-26 15:23:04 -04001332bool RefreshRateSelector::isPolicyValidLocked(const Policy& policy) const {
Marin Shalamanova7fe3042021-01-29 21:02:08 +01001333 // defaultMode must be a valid mode, and within the given refresh rate range.
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001334 if (const auto mode = mDisplayModes.get(policy.defaultMode)) {
ramindania04b8a52023-08-07 18:49:47 -07001335 if (!policy.primaryRanges.physical.includes(mode->get()->getPeakFps())) {
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001336 ALOGE("Default mode is not in the primary range.");
1337 return false;
1338 }
1339 } else {
Marin Shalamanova7fe3042021-01-29 21:02:08 +01001340 ALOGE("Default mode is not found.");
Steven Thomasd4071902020-03-24 16:02:53 -07001341 return false;
1342 }
Dominik Laskowski6eab42d2021-09-13 14:34:13 -07001343
Ady Abraham68636062022-11-16 17:07:25 -08001344 const auto& primaryRanges = policy.primaryRanges;
1345 const auto& appRequestRanges = policy.appRequestRanges;
1346 ALOGE_IF(!appRequestRanges.physical.includes(primaryRanges.physical),
Ady Abraham08048ce2022-11-30 18:08:00 -08001347 "Physical range is invalid: primary: %s appRequest: %s",
1348 to_string(primaryRanges.physical).c_str(),
1349 to_string(appRequestRanges.physical).c_str());
1350 ALOGE_IF(!appRequestRanges.render.includes(primaryRanges.render),
1351 "Render range is invalid: primary: %s appRequest: %s",
1352 to_string(primaryRanges.render).c_str(), to_string(appRequestRanges.render).c_str());
Ady Abraham68636062022-11-16 17:07:25 -08001353
1354 return primaryRanges.valid() && appRequestRanges.valid();
Steven Thomasd4071902020-03-24 16:02:53 -07001355}
1356
Dominik Laskowskid82e0f02022-10-26 15:23:04 -04001357auto RefreshRateSelector::setPolicy(const PolicyVariant& policy) -> SetPolicyResult {
Dominik Laskowski36dced82022-09-02 09:24:00 -07001358 Policy oldPolicy;
Ady Abrahamace3d052022-11-17 16:25:05 -08001359 PhysicalDisplayId displayId;
Dominik Laskowski36dced82022-09-02 09:24:00 -07001360 {
1361 std::lock_guard lock(mLock);
1362 oldPolicy = *getCurrentPolicyLocked();
Ana Kruleced3a8cc2019-11-14 00:55:07 +01001363
Dominik Laskowski36dced82022-09-02 09:24:00 -07001364 const bool valid = ftl::match(
1365 policy,
1366 [this](const auto& policy) {
1367 ftl::FakeGuard guard(mLock);
1368 if (!isPolicyValidLocked(policy)) {
1369 ALOGE("Invalid policy: %s", policy.toString().c_str());
1370 return false;
1371 }
1372
1373 using T = std::decay_t<decltype(policy)>;
1374
1375 if constexpr (std::is_same_v<T, DisplayManagerPolicy>) {
1376 mDisplayManagerPolicy = policy;
1377 } else {
1378 static_assert(std::is_same_v<T, OverridePolicy>);
1379 mOverridePolicy = policy;
1380 }
1381 return true;
1382 },
1383 [this](NoOverridePolicy) {
1384 ftl::FakeGuard guard(mLock);
1385 mOverridePolicy.reset();
1386 return true;
1387 });
1388
1389 if (!valid) {
1390 return SetPolicyResult::Invalid;
1391 }
1392
Ady Abraham68636062022-11-16 17:07:25 -08001393 mGetRankedFrameRatesCache.reset();
Dominik Laskowski36dced82022-09-02 09:24:00 -07001394
Ady Abraham67231722024-03-21 18:06:21 -07001395 const auto& idleScreenConfigOpt = getCurrentPolicyLocked()->idleScreenConfigOpt;
1396 if (idleScreenConfigOpt != oldPolicy.idleScreenConfigOpt) {
1397 if (!idleScreenConfigOpt.has_value()) {
1398 // fallback to legacy timer if existed, otherwise pause the old timer
1399 LOG_ALWAYS_FATAL_IF(!mIdleTimer);
1400 if (mConfig.legacyIdleTimerTimeout > 0ms) {
1401 mIdleTimer->setInterval(mConfig.legacyIdleTimerTimeout);
1402 mIdleTimer->resume();
1403 } else {
1404 mIdleTimer->pause();
1405 }
1406 } else if (idleScreenConfigOpt->timeoutMillis > 0) {
1407 // create a new timer or reconfigure
1408 const auto timeout = std::chrono::milliseconds{idleScreenConfigOpt->timeoutMillis};
1409 if (!mIdleTimer) {
1410 initializeIdleTimer(timeout);
1411 if (mIdleTimerStarted) {
1412 mIdleTimer->start();
1413 }
1414 } else {
1415 mIdleTimer->setInterval(timeout);
1416 mIdleTimer->resume();
1417 }
1418 } else {
1419 if (mIdleTimer) {
1420 mIdleTimer->pause();
1421 }
1422 }
1423 }
1424
1425 if (getCurrentPolicyLocked()->similarExceptIdleConfig(oldPolicy)) {
Dominik Laskowski36dced82022-09-02 09:24:00 -07001426 return SetPolicyResult::Unchanged;
1427 }
Ady Abraham67231722024-03-21 18:06:21 -07001428
Dominik Laskowski36dced82022-09-02 09:24:00 -07001429 constructAvailableRefreshRates();
Ady Abrahamace3d052022-11-17 16:25:05 -08001430
1431 displayId = getActiveModeLocked().modePtr->getPhysicalDisplayId();
Steven Thomasd4071902020-03-24 16:02:53 -07001432 }
Dominik Laskowski36dced82022-09-02 09:24:00 -07001433
Dominik Laskowski36dced82022-09-02 09:24:00 -07001434 const unsigned numModeChanges = std::exchange(mNumModeSwitchesInPolicy, 0u);
1435
1436 ALOGI("Display %s policy changed\n"
1437 "Previous: %s\n"
1438 "Current: %s\n"
1439 "%u mode changes were performed under the previous policy",
1440 to_string(displayId).c_str(), oldPolicy.toString().c_str(), toString(policy).c_str(),
1441 numModeChanges);
1442
1443 return SetPolicyResult::Changed;
Steven Thomasd4071902020-03-24 16:02:53 -07001444}
1445
Dominik Laskowskid82e0f02022-10-26 15:23:04 -04001446auto RefreshRateSelector::getCurrentPolicyLocked() const -> const Policy* {
Steven Thomasd4071902020-03-24 16:02:53 -07001447 return mOverridePolicy ? &mOverridePolicy.value() : &mDisplayManagerPolicy;
1448}
1449
Dominik Laskowskid82e0f02022-10-26 15:23:04 -04001450auto RefreshRateSelector::getCurrentPolicy() const -> Policy {
Steven Thomasd4071902020-03-24 16:02:53 -07001451 std::lock_guard lock(mLock);
1452 return *getCurrentPolicyLocked();
1453}
1454
Dominik Laskowskid82e0f02022-10-26 15:23:04 -04001455auto RefreshRateSelector::getDisplayManagerPolicy() const -> Policy {
Steven Thomasd4071902020-03-24 16:02:53 -07001456 std::lock_guard lock(mLock);
1457 return mDisplayManagerPolicy;
Ana Kruleced3a8cc2019-11-14 00:55:07 +01001458}
1459
Ady Abrahamace3d052022-11-17 16:25:05 -08001460bool RefreshRateSelector::isModeAllowed(const FrameRateMode& mode) const {
Ana Kruleced3a8cc2019-11-14 00:55:07 +01001461 std::lock_guard lock(mLock);
Ady Abrahamace3d052022-11-17 16:25:05 -08001462 return std::find(mAppRequestFrameRates.begin(), mAppRequestFrameRates.end(), mode) !=
1463 mAppRequestFrameRates.end();
Ady Abraham2139f732019-11-13 18:56:40 -08001464}
1465
Dominik Laskowskid82e0f02022-10-26 15:23:04 -04001466void RefreshRateSelector::constructAvailableRefreshRates() {
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001467 // Filter modes based on current policy and sort on refresh rate.
Steven Thomasd4071902020-03-24 16:02:53 -07001468 const Policy* policy = getCurrentPolicyLocked();
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001469 ALOGV("%s: %s ", __func__, policy->toString().c_str());
Ady Abrahamabc27602020-04-08 17:20:29 -07001470
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001471 const auto& defaultMode = mDisplayModes.get(policy->defaultMode)->get();
Ady Abraham8a82ba62020-01-17 12:43:17 -08001472
Ady Abraham68636062022-11-16 17:07:25 -08001473 const auto filterRefreshRates = [&](const FpsRanges& ranges,
1474 const char* rangeName) REQUIRES(mLock) {
1475 const auto filterModes = [&](const DisplayMode& mode) {
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001476 return mode.getResolution() == defaultMode->getResolution() &&
1477 mode.getDpi() == defaultMode->getDpi() &&
1478 (policy->allowGroupSwitching || mode.getGroup() == defaultMode->getGroup()) &&
ramindania04b8a52023-08-07 18:49:47 -07001479 ranges.physical.includes(mode.getPeakFps()) &&
1480 (supportsFrameRateOverride() || ranges.render.includes(mode.getPeakFps()));
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001481 };
Ady Abraham8a82ba62020-01-17 12:43:17 -08001482
Ady Abraham90f7fd22023-08-16 11:02:00 -07001483 auto frameRateModes = createFrameRateModes(*policy, filterModes, ranges.render);
Ady Abraham41bf7c62023-07-20 10:33:06 -07001484 if (frameRateModes.empty()) {
1485 ALOGW("No matching frame rate modes for %s range. policy: %s", rangeName,
1486 policy->toString().c_str());
1487 // TODO(b/292105422): Ideally DisplayManager should not send render ranges smaller than
1488 // the min supported. See b/292047939.
1489 // For not we just ignore the render ranges.
Ady Abraham90f7fd22023-08-16 11:02:00 -07001490 frameRateModes = createFrameRateModes(*policy, filterModes, {});
Ady Abraham41bf7c62023-07-20 10:33:06 -07001491 }
Ady Abraham68636062022-11-16 17:07:25 -08001492 LOG_ALWAYS_FATAL_IF(frameRateModes.empty(),
Ady Abraham41bf7c62023-07-20 10:33:06 -07001493 "No matching frame rate modes for %s range even after ignoring the "
1494 "render range. policy: %s",
1495 rangeName, policy->toString().c_str());
Dominik Laskowski953b7fd2022-01-08 19:34:59 -08001496
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001497 const auto stringifyModes = [&] {
1498 std::string str;
Ady Abraham68636062022-11-16 17:07:25 -08001499 for (const auto& frameRateMode : frameRateModes) {
1500 str += to_string(frameRateMode) + " ";
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001501 }
1502 return str;
1503 };
Rachel Lee45681982024-03-14 18:40:15 -07001504 ALOGV("%s render rates: %s, isVrrDevice? %d", rangeName, stringifyModes().c_str(),
Ady Abrahameba039c2024-07-10 17:45:29 -07001505 mIsVrrDevice.load());
Steven Thomasf734df42020-04-13 21:09:28 -07001506
Ady Abraham68636062022-11-16 17:07:25 -08001507 return frameRateModes;
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001508 };
1509
Ady Abraham68636062022-11-16 17:07:25 -08001510 mPrimaryFrameRates = filterRefreshRates(policy->primaryRanges, "primary");
1511 mAppRequestFrameRates = filterRefreshRates(policy->appRequestRanges, "app request");
Ady Abraham2139f732019-11-13 18:56:40 -08001512}
1513
Rachel Lee45681982024-03-14 18:40:15 -07001514bool RefreshRateSelector::isVrrDevice() const {
Rachel Lee45681982024-03-14 18:40:15 -07001515 return mIsVrrDevice;
1516}
1517
Dominik Laskowskid82e0f02022-10-26 15:23:04 -04001518Fps RefreshRateSelector::findClosestKnownFrameRate(Fps frameRate) const {
Dominik Laskowski6eab42d2021-09-13 14:34:13 -07001519 using namespace fps_approx_ops;
1520
1521 if (frameRate <= mKnownFrameRates.front()) {
1522 return mKnownFrameRates.front();
Ady Abrahamb1b9d412020-06-01 19:53:52 -07001523 }
1524
Dominik Laskowski6eab42d2021-09-13 14:34:13 -07001525 if (frameRate >= mKnownFrameRates.back()) {
1526 return mKnownFrameRates.back();
Ady Abrahamb1b9d412020-06-01 19:53:52 -07001527 }
1528
Marin Shalamanove8a663d2020-11-24 17:48:00 +01001529 auto lowerBound = std::lower_bound(mKnownFrameRates.begin(), mKnownFrameRates.end(), frameRate,
Dominik Laskowski6eab42d2021-09-13 14:34:13 -07001530 isStrictlyLess);
Ady Abrahamb1b9d412020-06-01 19:53:52 -07001531
Dominik Laskowski6eab42d2021-09-13 14:34:13 -07001532 const auto distance1 = std::abs(frameRate.getValue() - lowerBound->getValue());
1533 const auto distance2 = std::abs(frameRate.getValue() - std::prev(lowerBound)->getValue());
Ady Abrahamb1b9d412020-06-01 19:53:52 -07001534 return distance1 < distance2 ? *lowerBound : *std::prev(lowerBound);
1535}
1536
Dominik Laskowskid82e0f02022-10-26 15:23:04 -04001537auto RefreshRateSelector::getIdleTimerAction() const -> KernelIdleTimerAction {
Ana Krulecb9afd792020-06-11 13:16:15 -07001538 std::lock_guard lock(mLock);
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001539
ramindania04b8a52023-08-07 18:49:47 -07001540 const Fps deviceMinFps = mMinRefreshRateModeIt->second->getPeakFps();
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001541 const DisplayModePtr& minByPolicy = getMinRefreshRateByPolicyLocked();
Ana Krulecb9afd792020-06-11 13:16:15 -07001542
1543 // Kernel idle timer will set the refresh rate to the device min. If DisplayManager says that
1544 // the min allowed refresh rate is higher than the device min, we do not want to enable the
1545 // timer.
ramindania04b8a52023-08-07 18:49:47 -07001546 if (isStrictlyLess(deviceMinFps, minByPolicy->getPeakFps())) {
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001547 return KernelIdleTimerAction::TurnOff;
Ana Krulecb9afd792020-06-11 13:16:15 -07001548 }
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001549
ramindanid72ba162022-09-09 21:33:40 +00001550 const DisplayModePtr& maxByPolicy =
Ady Abrahamace3d052022-11-17 16:25:05 -08001551 getMaxRefreshRateByPolicyLocked(getActiveModeLocked().modePtr->getGroup());
Ana Krulecb9afd792020-06-11 13:16:15 -07001552 if (minByPolicy == maxByPolicy) {
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001553 // Turn on the timer when the min of the primary range is below the device min.
1554 if (const Policy* currentPolicy = getCurrentPolicyLocked();
Ady Abraham285f8c12022-10-11 17:12:14 -07001555 isApproxLess(currentPolicy->primaryRanges.physical.min, deviceMinFps)) {
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001556 return KernelIdleTimerAction::TurnOn;
Ana Krulecb9afd792020-06-11 13:16:15 -07001557 }
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001558 return KernelIdleTimerAction::TurnOff;
Ana Krulecb9afd792020-06-11 13:16:15 -07001559 }
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001560
Ana Krulecb9afd792020-06-11 13:16:15 -07001561 // Turn on the timer in all other cases.
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001562 return KernelIdleTimerAction::TurnOn;
Ana Krulecb9afd792020-06-11 13:16:15 -07001563}
1564
Dominik Laskowskid82e0f02022-10-26 15:23:04 -04001565int RefreshRateSelector::getFrameRateDivisor(Fps displayRefreshRate, Fps layerFrameRate) {
Ady Abraham62f216c2020-10-13 19:07:23 -07001566 // This calculation needs to be in sync with the java code
1567 // in DisplayManagerService.getDisplayInfoForFrameRateOverride
Marin Shalamanov15a0fc62021-08-16 18:20:21 +02001568
1569 // The threshold must be smaller than 0.001 in order to differentiate
1570 // between the fractional pairs (e.g. 59.94 and 60).
1571 constexpr float kThreshold = 0.0009f;
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001572 const auto numPeriods = displayRefreshRate.getValue() / layerFrameRate.getValue();
Ady Abraham0bb6a472020-10-12 10:22:13 -07001573 const auto numPeriodsRounded = std::round(numPeriods);
1574 if (std::abs(numPeriods - numPeriodsRounded) > kThreshold) {
Ady Abraham62a0be22020-12-08 16:54:10 -08001575 return 0;
Ady Abraham0bb6a472020-10-12 10:22:13 -07001576 }
1577
Ady Abraham62f216c2020-10-13 19:07:23 -07001578 return static_cast<int>(numPeriodsRounded);
1579}
1580
Dominik Laskowskid82e0f02022-10-26 15:23:04 -04001581bool RefreshRateSelector::isFractionalPairOrMultiple(Fps smaller, Fps bigger) {
Dominik Laskowski6eab42d2021-09-13 14:34:13 -07001582 if (isStrictlyLess(bigger, smaller)) {
Marin Shalamanov15a0fc62021-08-16 18:20:21 +02001583 return isFractionalPairOrMultiple(bigger, smaller);
1584 }
1585
1586 const auto multiplier = std::round(bigger.getValue() / smaller.getValue());
1587 constexpr float kCoef = 1000.f / 1001.f;
Dominik Laskowski6eab42d2021-09-13 14:34:13 -07001588 return isApproxEqual(bigger, Fps::fromValue(smaller.getValue() * multiplier / kCoef)) ||
1589 isApproxEqual(bigger, Fps::fromValue(smaller.getValue() * multiplier * kCoef));
Marin Shalamanov15a0fc62021-08-16 18:20:21 +02001590}
1591
Dominik Laskowskid82e0f02022-10-26 15:23:04 -04001592void RefreshRateSelector::dump(utils::Dumper& dumper) const {
Dominik Laskowskie70461a2022-08-30 14:42:01 -07001593 using namespace std::string_view_literals;
Dominik Laskowski0acc3842022-04-07 11:23:42 -07001594
Marin Shalamanovba421a82020-11-10 21:49:26 +01001595 std::lock_guard lock(mLock);
Marin Shalamanovba421a82020-11-10 21:49:26 +01001596
Ady Abrahamace3d052022-11-17 16:25:05 -08001597 const auto activeMode = getActiveModeLocked();
Ady Abraham93256082024-05-09 17:04:34 -07001598 dumper.dump("renderRate"sv, to_string(activeMode.fps));
1599 dumper.dump("activeMode"sv, to_string(*activeMode.modePtr));
Marin Shalamanovba421a82020-11-10 21:49:26 +01001600
Dominik Laskowskie70461a2022-08-30 14:42:01 -07001601 dumper.dump("displayModes"sv);
1602 {
1603 utils::Dumper::Indent indent(dumper);
1604 for (const auto& [id, mode] : mDisplayModes) {
1605 dumper.dump({}, to_string(*mode));
1606 }
Marin Shalamanovba421a82020-11-10 21:49:26 +01001607 }
1608
Dominik Laskowskie70461a2022-08-30 14:42:01 -07001609 dumper.dump("displayManagerPolicy"sv, mDisplayManagerPolicy.toString());
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001610
Dominik Laskowski0acc3842022-04-07 11:23:42 -07001611 if (const Policy& currentPolicy = *getCurrentPolicyLocked();
1612 mOverridePolicy && currentPolicy != mDisplayManagerPolicy) {
Dominik Laskowskie70461a2022-08-30 14:42:01 -07001613 dumper.dump("overridePolicy"sv, currentPolicy.toString());
ramindani32cf0602022-03-02 02:30:29 +00001614 }
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001615
Ady Abraham8ca643a2022-10-18 18:26:47 -07001616 dumper.dump("frameRateOverrideConfig"sv, *ftl::enum_name(mFrameRateOverrideConfig));
Dominik Laskowski0acc3842022-04-07 11:23:42 -07001617
Dominik Laskowski03cfce82022-11-02 12:13:29 -04001618 dumper.dump("idleTimer"sv);
1619 {
1620 utils::Dumper::Indent indent(dumper);
1621 dumper.dump("interval"sv, mIdleTimer.transform(&OneShotTimer::interval));
1622 dumper.dump("controller"sv,
1623 mConfig.kernelIdleTimerController
1624 .and_then(&ftl::enum_name<KernelIdleTimerController>)
1625 .value_or("Platform"sv));
Dominik Laskowskib0054a22022-03-03 09:03:06 -08001626 }
Marin Shalamanovba421a82020-11-10 21:49:26 +01001627}
1628
Dominik Laskowskid82e0f02022-10-26 15:23:04 -04001629std::chrono::milliseconds RefreshRateSelector::getIdleTimerTimeout() {
Ady Abraham67231722024-03-21 18:06:21 -07001630 if (FlagManager::getInstance().idle_screen_refresh_rate_timeout() && mIdleTimer) {
1631 return std::chrono::duration_cast<std::chrono::milliseconds>(mIdleTimer->interval());
1632 }
1633 return mConfig.legacyIdleTimerTimeout;
ramindani32cf0602022-03-02 02:30:29 +00001634}
1635
Rachel Leece6e0042023-06-27 11:22:54 -07001636// TODO(b/293651105): Extract category FpsRange mapping to OEM-configurable config.
1637FpsRange RefreshRateSelector::getFrameRateCategoryRange(FrameRateCategory category) {
1638 switch (category) {
1639 case FrameRateCategory::High:
1640 return FpsRange{90_Hz, 120_Hz};
1641 case FrameRateCategory::Normal:
ramindani9a6cfce2024-03-05 13:00:26 -08001642 return FpsRange{60_Hz, 120_Hz};
Rachel Leece6e0042023-06-27 11:22:54 -07001643 case FrameRateCategory::Low:
Rachel Lee714b1bd2024-06-24 11:22:15 -07001644 return FpsRange{48_Hz, 120_Hz};
Rachel Lee9580ff12023-12-26 17:33:41 -08001645 case FrameRateCategory::HighHint:
Rachel Leece6e0042023-06-27 11:22:54 -07001646 case FrameRateCategory::NoPreference:
1647 case FrameRateCategory::Default:
1648 LOG_ALWAYS_FATAL("Should not get fps range for frame rate category: %s",
1649 ftl::enum_string(category).c_str());
Rachel Leece6e0042023-06-27 11:22:54 -07001650 default:
1651 LOG_ALWAYS_FATAL("Invalid frame rate category for range: %s",
1652 ftl::enum_string(category).c_str());
Rachel Leece6e0042023-06-27 11:22:54 -07001653 }
1654}
1655
Ady Abraham2139f732019-11-13 18:56:40 -08001656} // namespace android::scheduler
Marin Shalamanovbed7fd32020-12-21 20:02:20 +01001657
1658// TODO(b/129481165): remove the #pragma below and fix conversion issues
Ady Abrahamdd5bfa92021-01-07 17:56:08 -08001659#pragma clang diagnostic pop // ignored "-Wextra"