Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1 | // Copyright 2018 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package apex |
| 16 | |
| 17 | import ( |
Jiyong Park | f7c3bbe | 2020-12-09 21:18:56 +0900 | [diff] [blame] | 18 | "fmt" |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 19 | "os" |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 20 | "path" |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 21 | "path/filepath" |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 22 | "reflect" |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 23 | "regexp" |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 24 | "sort" |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 25 | "strconv" |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 26 | "strings" |
| 27 | "testing" |
Jiyong Park | da6eb59 | 2018-12-19 17:12:36 +0900 | [diff] [blame] | 28 | |
| 29 | "github.com/google/blueprint/proptools" |
| 30 | |
| 31 | "android/soong/android" |
markchien | 2f59ec9 | 2020-09-02 16:23:38 +0800 | [diff] [blame] | 32 | "android/soong/bpf" |
Jiyong Park | da6eb59 | 2018-12-19 17:12:36 +0900 | [diff] [blame] | 33 | "android/soong/cc" |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 34 | "android/soong/dexpreopt" |
Jaewoong Jung | 4b79e98 | 2020-06-01 10:45:49 -0700 | [diff] [blame] | 35 | prebuilt_etc "android/soong/etc" |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 36 | "android/soong/java" |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 37 | "android/soong/rust" |
Jaewoong Jung | 4b79e98 | 2020-06-01 10:45:49 -0700 | [diff] [blame] | 38 | "android/soong/sh" |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 39 | ) |
| 40 | |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 41 | // names returns name list from white space separated string |
| 42 | func names(s string) (ns []string) { |
| 43 | for _, n := range strings.Split(s, " ") { |
| 44 | if len(n) > 0 { |
| 45 | ns = append(ns, n) |
| 46 | } |
| 47 | } |
| 48 | return |
| 49 | } |
| 50 | |
Paul Duffin | 40b6257 | 2021-03-20 11:39:01 +0000 | [diff] [blame] | 51 | func testApexError(t *testing.T, pattern, bp string, preparers ...android.FixturePreparer) { |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 52 | t.Helper() |
Paul Duffin | 284165a | 2021-03-29 01:50:31 +0100 | [diff] [blame] | 53 | android.GroupFixturePreparers( |
| 54 | prepareForApexTest, |
| 55 | android.GroupFixturePreparers(preparers...), |
| 56 | ). |
Paul Duffin | e05480a | 2021-03-08 15:07:14 +0000 | [diff] [blame] | 57 | ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)). |
Paul Duffin | 40b6257 | 2021-03-20 11:39:01 +0000 | [diff] [blame] | 58 | RunTestWithBp(t, bp) |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 59 | } |
| 60 | |
Paul Duffin | 40b6257 | 2021-03-20 11:39:01 +0000 | [diff] [blame] | 61 | func testApex(t *testing.T, bp string, preparers ...android.FixturePreparer) *android.TestContext { |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 62 | t.Helper() |
Paul Duffin | 284165a | 2021-03-29 01:50:31 +0100 | [diff] [blame] | 63 | |
| 64 | optionalBpPreparer := android.NullFixturePreparer |
Paul Duffin | 40b6257 | 2021-03-20 11:39:01 +0000 | [diff] [blame] | 65 | if bp != "" { |
Paul Duffin | 284165a | 2021-03-29 01:50:31 +0100 | [diff] [blame] | 66 | optionalBpPreparer = android.FixtureWithRootAndroidBp(bp) |
Paul Duffin | 40b6257 | 2021-03-20 11:39:01 +0000 | [diff] [blame] | 67 | } |
Paul Duffin | 284165a | 2021-03-29 01:50:31 +0100 | [diff] [blame] | 68 | |
| 69 | result := android.GroupFixturePreparers( |
| 70 | prepareForApexTest, |
| 71 | android.GroupFixturePreparers(preparers...), |
| 72 | optionalBpPreparer, |
| 73 | ).RunTest(t) |
| 74 | |
Paul Duffin | e05480a | 2021-03-08 15:07:14 +0000 | [diff] [blame] | 75 | return result.TestContext |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 76 | } |
| 77 | |
Paul Duffin | 810f33d | 2021-03-09 14:12:32 +0000 | [diff] [blame] | 78 | func withFiles(files android.MockFS) android.FixturePreparer { |
| 79 | return files.AddToFixture() |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 80 | } |
| 81 | |
Paul Duffin | 810f33d | 2021-03-09 14:12:32 +0000 | [diff] [blame] | 82 | func withTargets(targets map[android.OsType][]android.Target) android.FixturePreparer { |
| 83 | return android.FixtureModifyConfig(func(config android.Config) { |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 84 | for k, v := range targets { |
| 85 | config.Targets[k] = v |
| 86 | } |
Paul Duffin | 810f33d | 2021-03-09 14:12:32 +0000 | [diff] [blame] | 87 | }) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 88 | } |
| 89 | |
Jooyung Han | 35155c4 | 2020-02-06 17:33:20 +0900 | [diff] [blame] | 90 | // withNativeBridgeTargets sets configuration with targets including: |
| 91 | // - X86_64 (primary) |
| 92 | // - X86 (secondary) |
| 93 | // - Arm64 on X86_64 (native bridge) |
| 94 | // - Arm on X86 (native bridge) |
Paul Duffin | 810f33d | 2021-03-09 14:12:32 +0000 | [diff] [blame] | 95 | var withNativeBridgeEnabled = android.FixtureModifyConfig( |
| 96 | func(config android.Config) { |
| 97 | config.Targets[android.Android] = []android.Target{ |
| 98 | {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "silvermont", Abi: []string{"arm64-v8a"}}, |
| 99 | NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""}, |
| 100 | {Os: android.Android, Arch: android.Arch{ArchType: android.X86, ArchVariant: "silvermont", Abi: []string{"armeabi-v7a"}}, |
| 101 | NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""}, |
| 102 | {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}, |
| 103 | NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86_64", NativeBridgeRelativePath: "arm64"}, |
| 104 | {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}, |
| 105 | NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86", NativeBridgeRelativePath: "arm"}, |
| 106 | } |
| 107 | }, |
| 108 | ) |
| 109 | |
| 110 | func withManifestPackageNameOverrides(specs []string) android.FixturePreparer { |
| 111 | return android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 112 | variables.ManifestPackageNameOverrides = specs |
| 113 | }) |
Jooyung Han | 35155c4 | 2020-02-06 17:33:20 +0900 | [diff] [blame] | 114 | } |
| 115 | |
Paul Duffin | 810f33d | 2021-03-09 14:12:32 +0000 | [diff] [blame] | 116 | var withBinder32bit = android.FixtureModifyProductVariables( |
| 117 | func(variables android.FixtureProductVariables) { |
| 118 | variables.Binder32bit = proptools.BoolPtr(true) |
| 119 | }, |
| 120 | ) |
Jiyong Park | cfaa164 | 2020-02-28 16:51:07 +0900 | [diff] [blame] | 121 | |
Paul Duffin | 810f33d | 2021-03-09 14:12:32 +0000 | [diff] [blame] | 122 | var withUnbundledBuild = android.FixtureModifyProductVariables( |
| 123 | func(variables android.FixtureProductVariables) { |
| 124 | variables.Unbundled_build = proptools.BoolPtr(true) |
| 125 | }, |
| 126 | ) |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 127 | |
Paul Duffin | 284165a | 2021-03-29 01:50:31 +0100 | [diff] [blame] | 128 | // Legacy preparer used for running tests within the apex package. |
| 129 | // |
| 130 | // This includes everything that was needed to run any test in the apex package prior to the |
| 131 | // introduction of the test fixtures. Tests that are being converted to use fixtures directly |
| 132 | // rather than through the testApex...() methods should avoid using this and instead use the |
| 133 | // various preparers directly, using android.GroupFixturePreparers(...) to group them when |
| 134 | // necessary. |
| 135 | // |
| 136 | // deprecated |
| 137 | var prepareForApexTest = android.GroupFixturePreparers( |
Paul Duffin | 37aad60 | 2021-03-08 09:47:16 +0000 | [diff] [blame] | 138 | // General preparers in alphabetical order as test infrastructure will enforce correct |
| 139 | // registration order. |
| 140 | android.PrepareForTestWithAndroidBuildComponents, |
| 141 | bpf.PrepareForTestWithBpf, |
| 142 | cc.PrepareForTestWithCcBuildComponents, |
| 143 | java.PrepareForTestWithJavaDefaultModules, |
| 144 | prebuilt_etc.PrepareForTestWithPrebuiltEtc, |
| 145 | rust.PrepareForTestWithRustDefaultModules, |
| 146 | sh.PrepareForTestWithShBuildComponents, |
| 147 | |
| 148 | PrepareForTestWithApexBuildComponents, |
| 149 | |
| 150 | // Additional apex test specific preparers. |
| 151 | android.FixtureAddTextFile("system/sepolicy/Android.bp", ` |
| 152 | filegroup { |
| 153 | name: "myapex-file_contexts", |
| 154 | srcs: [ |
| 155 | "apex/myapex-file_contexts", |
| 156 | ], |
| 157 | } |
| 158 | `), |
Paul Duffin | 52bfaa4 | 2021-03-23 23:40:12 +0000 | [diff] [blame] | 159 | prepareForTestWithMyapex, |
Paul Duffin | 37aad60 | 2021-03-08 09:47:16 +0000 | [diff] [blame] | 160 | android.FixtureMergeMockFs(android.MockFS{ |
Paul Duffin | 52bfaa4 | 2021-03-23 23:40:12 +0000 | [diff] [blame] | 161 | "a.java": nil, |
| 162 | "PrebuiltAppFoo.apk": nil, |
| 163 | "PrebuiltAppFooPriv.apk": nil, |
| 164 | "apex_manifest.json": nil, |
| 165 | "AndroidManifest.xml": nil, |
Paul Duffin | 37aad60 | 2021-03-08 09:47:16 +0000 | [diff] [blame] | 166 | "system/sepolicy/apex/myapex.updatable-file_contexts": nil, |
| 167 | "system/sepolicy/apex/myapex2-file_contexts": nil, |
| 168 | "system/sepolicy/apex/otherapex-file_contexts": nil, |
| 169 | "system/sepolicy/apex/com.android.vndk-file_contexts": nil, |
| 170 | "system/sepolicy/apex/com.android.vndk.current-file_contexts": nil, |
| 171 | "mylib.cpp": nil, |
| 172 | "mytest.cpp": nil, |
| 173 | "mytest1.cpp": nil, |
| 174 | "mytest2.cpp": nil, |
| 175 | "mytest3.cpp": nil, |
| 176 | "myprebuilt": nil, |
| 177 | "my_include": nil, |
| 178 | "foo/bar/MyClass.java": nil, |
| 179 | "prebuilt.jar": nil, |
| 180 | "prebuilt.so": nil, |
| 181 | "vendor/foo/devkeys/test.x509.pem": nil, |
| 182 | "vendor/foo/devkeys/test.pk8": nil, |
| 183 | "testkey.x509.pem": nil, |
| 184 | "testkey.pk8": nil, |
| 185 | "testkey.override.x509.pem": nil, |
| 186 | "testkey.override.pk8": nil, |
| 187 | "vendor/foo/devkeys/testkey.avbpubkey": nil, |
| 188 | "vendor/foo/devkeys/testkey.pem": nil, |
| 189 | "NOTICE": nil, |
| 190 | "custom_notice": nil, |
| 191 | "custom_notice_for_static_lib": nil, |
| 192 | "testkey2.avbpubkey": nil, |
| 193 | "testkey2.pem": nil, |
| 194 | "myapex-arm64.apex": nil, |
| 195 | "myapex-arm.apex": nil, |
| 196 | "myapex.apks": nil, |
| 197 | "frameworks/base/api/current.txt": nil, |
| 198 | "framework/aidl/a.aidl": nil, |
| 199 | "build/make/core/proguard.flags": nil, |
| 200 | "build/make/core/proguard_basic_keeps.flags": nil, |
| 201 | "dummy.txt": nil, |
| 202 | "baz": nil, |
| 203 | "bar/baz": nil, |
| 204 | "testdata/baz": nil, |
| 205 | "AppSet.apks": nil, |
| 206 | "foo.rs": nil, |
| 207 | "libfoo.jar": nil, |
| 208 | "libbar.jar": nil, |
| 209 | }, |
| 210 | ), |
| 211 | |
| 212 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 213 | variables.DeviceVndkVersion = proptools.StringPtr("current") |
| 214 | variables.DefaultAppCertificate = proptools.StringPtr("vendor/foo/devkeys/test") |
| 215 | variables.CertificateOverrides = []string{"myapex_keytest:myapex.certificate.override"} |
| 216 | variables.Platform_sdk_codename = proptools.StringPtr("Q") |
| 217 | variables.Platform_sdk_final = proptools.BoolPtr(false) |
| 218 | variables.Platform_version_active_codenames = []string{"Q"} |
Jiyong Park | f58c46e | 2021-04-01 21:35:20 +0900 | [diff] [blame] | 219 | variables.Platform_vndk_version = proptools.StringPtr("29") |
Paul Duffin | 37aad60 | 2021-03-08 09:47:16 +0000 | [diff] [blame] | 220 | }), |
| 221 | ) |
| 222 | |
Paul Duffin | 52bfaa4 | 2021-03-23 23:40:12 +0000 | [diff] [blame] | 223 | var prepareForTestWithMyapex = android.FixtureMergeMockFs(android.MockFS{ |
| 224 | "system/sepolicy/apex/myapex-file_contexts": nil, |
| 225 | }) |
| 226 | |
Jooyung Han | 643adc4 | 2020-02-27 13:50:06 +0900 | [diff] [blame] | 227 | // ensure that 'result' equals 'expected' |
| 228 | func ensureEquals(t *testing.T, result string, expected string) { |
| 229 | t.Helper() |
| 230 | if result != expected { |
| 231 | t.Errorf("%q != %q", expected, result) |
| 232 | } |
| 233 | } |
| 234 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 235 | // ensure that 'result' contains 'expected' |
| 236 | func ensureContains(t *testing.T, result string, expected string) { |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 237 | t.Helper() |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 238 | if !strings.Contains(result, expected) { |
| 239 | t.Errorf("%q is not found in %q", expected, result) |
| 240 | } |
| 241 | } |
| 242 | |
Liz Kammer | 5bd365f | 2020-05-27 15:15:11 -0700 | [diff] [blame] | 243 | // ensure that 'result' contains 'expected' exactly one time |
| 244 | func ensureContainsOnce(t *testing.T, result string, expected string) { |
| 245 | t.Helper() |
| 246 | count := strings.Count(result, expected) |
| 247 | if count != 1 { |
| 248 | t.Errorf("%q is found %d times (expected 1 time) in %q", expected, count, result) |
| 249 | } |
| 250 | } |
| 251 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 252 | // ensures that 'result' does not contain 'notExpected' |
| 253 | func ensureNotContains(t *testing.T, result string, notExpected string) { |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 254 | t.Helper() |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 255 | if strings.Contains(result, notExpected) { |
| 256 | t.Errorf("%q is found in %q", notExpected, result) |
| 257 | } |
| 258 | } |
| 259 | |
Sasha Smundak | 18d98bc | 2020-05-27 16:36:07 -0700 | [diff] [blame] | 260 | func ensureMatches(t *testing.T, result string, expectedRex string) { |
| 261 | ok, err := regexp.MatchString(expectedRex, result) |
| 262 | if err != nil { |
| 263 | t.Fatalf("regexp failure trying to match %s against `%s` expression: %s", result, expectedRex, err) |
| 264 | return |
| 265 | } |
| 266 | if !ok { |
| 267 | t.Errorf("%s does not match regular expession %s", result, expectedRex) |
| 268 | } |
| 269 | } |
| 270 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 271 | func ensureListContains(t *testing.T, result []string, expected string) { |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 272 | t.Helper() |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 273 | if !android.InList(expected, result) { |
| 274 | t.Errorf("%q is not found in %v", expected, result) |
| 275 | } |
| 276 | } |
| 277 | |
| 278 | func ensureListNotContains(t *testing.T, result []string, notExpected string) { |
Jooyung Han | 5c998b9 | 2019-06-27 11:30:33 +0900 | [diff] [blame] | 279 | t.Helper() |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 280 | if android.InList(notExpected, result) { |
| 281 | t.Errorf("%q is found in %v", notExpected, result) |
| 282 | } |
| 283 | } |
| 284 | |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 285 | func ensureListEmpty(t *testing.T, result []string) { |
| 286 | t.Helper() |
| 287 | if len(result) > 0 { |
| 288 | t.Errorf("%q is expected to be empty", result) |
| 289 | } |
| 290 | } |
| 291 | |
Mohammad Samiul Islam | 3cd005d | 2020-11-26 13:32:26 +0000 | [diff] [blame] | 292 | func ensureListNotEmpty(t *testing.T, result []string) { |
| 293 | t.Helper() |
| 294 | if len(result) == 0 { |
| 295 | t.Errorf("%q is expected to be not empty", result) |
| 296 | } |
| 297 | } |
| 298 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 299 | // Minimal test |
| 300 | func TestBasicApex(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 301 | ctx := testApex(t, ` |
Jiyong Park | 30ca937 | 2019-02-07 16:27:23 +0900 | [diff] [blame] | 302 | apex_defaults { |
| 303 | name: "myapex-defaults", |
Jiyong Park | 809bb72 | 2019-02-13 21:33:49 +0900 | [diff] [blame] | 304 | manifest: ":myapex.manifest", |
| 305 | androidManifest: ":myapex.androidmanifest", |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 306 | key: "myapex.key", |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 307 | binaries: ["foo.rust"], |
Jiyong Park | f2cc1b7 | 2020-12-09 00:20:45 +0900 | [diff] [blame] | 308 | native_shared_libs: [ |
| 309 | "mylib", |
| 310 | "libfoo.ffi", |
| 311 | ], |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 312 | rust_dyn_libs: ["libfoo.dylib.rust"], |
Alex Light | 3d67359 | 2019-01-18 14:37:31 -0800 | [diff] [blame] | 313 | multilib: { |
| 314 | both: { |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 315 | binaries: ["foo"], |
Alex Light | 3d67359 | 2019-01-18 14:37:31 -0800 | [diff] [blame] | 316 | } |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 317 | }, |
Jiyong Park | 77acec6 | 2020-06-01 21:39:15 +0900 | [diff] [blame] | 318 | java_libs: [ |
| 319 | "myjar", |
| 320 | "myjar_dex", |
| 321 | ], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 322 | updatable: false, |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 323 | } |
| 324 | |
Jiyong Park | 30ca937 | 2019-02-07 16:27:23 +0900 | [diff] [blame] | 325 | apex { |
| 326 | name: "myapex", |
| 327 | defaults: ["myapex-defaults"], |
| 328 | } |
| 329 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 330 | apex_key { |
| 331 | name: "myapex.key", |
| 332 | public_key: "testkey.avbpubkey", |
| 333 | private_key: "testkey.pem", |
| 334 | } |
| 335 | |
Jiyong Park | 809bb72 | 2019-02-13 21:33:49 +0900 | [diff] [blame] | 336 | filegroup { |
| 337 | name: "myapex.manifest", |
| 338 | srcs: ["apex_manifest.json"], |
| 339 | } |
| 340 | |
| 341 | filegroup { |
| 342 | name: "myapex.androidmanifest", |
| 343 | srcs: ["AndroidManifest.xml"], |
| 344 | } |
| 345 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 346 | cc_library { |
| 347 | name: "mylib", |
| 348 | srcs: ["mylib.cpp"], |
Jiyong Park | f2cc1b7 | 2020-12-09 00:20:45 +0900 | [diff] [blame] | 349 | shared_libs: [ |
| 350 | "mylib2", |
| 351 | "libbar.ffi", |
| 352 | ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 353 | system_shared_libs: [], |
| 354 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 355 | // TODO: remove //apex_available:platform |
| 356 | apex_available: [ |
| 357 | "//apex_available:platform", |
| 358 | "myapex", |
| 359 | ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 360 | } |
| 361 | |
Alex Light | 3d67359 | 2019-01-18 14:37:31 -0800 | [diff] [blame] | 362 | cc_binary { |
| 363 | name: "foo", |
| 364 | srcs: ["mylib.cpp"], |
| 365 | compile_multilib: "both", |
| 366 | multilib: { |
| 367 | lib32: { |
| 368 | suffix: "32", |
| 369 | }, |
| 370 | lib64: { |
| 371 | suffix: "64", |
| 372 | }, |
| 373 | }, |
| 374 | symlinks: ["foo_link_"], |
| 375 | symlink_preferred_arch: true, |
| 376 | system_shared_libs: [], |
Alex Light | 3d67359 | 2019-01-18 14:37:31 -0800 | [diff] [blame] | 377 | stl: "none", |
Yifan Hong | d22a84a | 2020-07-28 17:37:46 -0700 | [diff] [blame] | 378 | apex_available: [ "myapex", "com.android.gki.*" ], |
| 379 | } |
| 380 | |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 381 | rust_binary { |
Artur Satayev | 533b98c | 2021-03-11 18:03:42 +0000 | [diff] [blame] | 382 | name: "foo.rust", |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 383 | srcs: ["foo.rs"], |
| 384 | rlibs: ["libfoo.rlib.rust"], |
| 385 | dylibs: ["libfoo.dylib.rust"], |
| 386 | apex_available: ["myapex"], |
| 387 | } |
| 388 | |
| 389 | rust_library_rlib { |
Artur Satayev | 533b98c | 2021-03-11 18:03:42 +0000 | [diff] [blame] | 390 | name: "libfoo.rlib.rust", |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 391 | srcs: ["foo.rs"], |
| 392 | crate_name: "foo", |
| 393 | apex_available: ["myapex"], |
Jiyong Park | 94e22fd | 2021-04-08 18:19:15 +0900 | [diff] [blame] | 394 | shared_libs: ["libfoo.shared_from_rust"], |
| 395 | } |
| 396 | |
| 397 | cc_library_shared { |
| 398 | name: "libfoo.shared_from_rust", |
| 399 | srcs: ["mylib.cpp"], |
| 400 | system_shared_libs: [], |
| 401 | stl: "none", |
| 402 | apex_available: ["myapex"], |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 403 | } |
| 404 | |
| 405 | rust_library_dylib { |
Artur Satayev | 533b98c | 2021-03-11 18:03:42 +0000 | [diff] [blame] | 406 | name: "libfoo.dylib.rust", |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 407 | srcs: ["foo.rs"], |
| 408 | crate_name: "foo", |
| 409 | apex_available: ["myapex"], |
| 410 | } |
| 411 | |
Jiyong Park | f2cc1b7 | 2020-12-09 00:20:45 +0900 | [diff] [blame] | 412 | rust_ffi_shared { |
| 413 | name: "libfoo.ffi", |
| 414 | srcs: ["foo.rs"], |
| 415 | crate_name: "foo", |
| 416 | apex_available: ["myapex"], |
| 417 | } |
| 418 | |
| 419 | rust_ffi_shared { |
| 420 | name: "libbar.ffi", |
| 421 | srcs: ["foo.rs"], |
| 422 | crate_name: "bar", |
| 423 | apex_available: ["myapex"], |
| 424 | } |
| 425 | |
Yifan Hong | d22a84a | 2020-07-28 17:37:46 -0700 | [diff] [blame] | 426 | apex { |
| 427 | name: "com.android.gki.fake", |
| 428 | binaries: ["foo"], |
| 429 | key: "myapex.key", |
| 430 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 431 | updatable: false, |
Alex Light | 3d67359 | 2019-01-18 14:37:31 -0800 | [diff] [blame] | 432 | } |
| 433 | |
Paul Duffin | dddd546 | 2020-04-07 15:25:44 +0100 | [diff] [blame] | 434 | cc_library_shared { |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 435 | name: "mylib2", |
| 436 | srcs: ["mylib.cpp"], |
| 437 | system_shared_libs: [], |
| 438 | stl: "none", |
Jiyong Park | 52818fc | 2019-03-18 12:01:38 +0900 | [diff] [blame] | 439 | notice: "custom_notice", |
Jiyong Park | 9918e1a | 2020-03-17 19:16:40 +0900 | [diff] [blame] | 440 | static_libs: ["libstatic"], |
| 441 | // TODO: remove //apex_available:platform |
| 442 | apex_available: [ |
| 443 | "//apex_available:platform", |
| 444 | "myapex", |
| 445 | ], |
| 446 | } |
| 447 | |
Paul Duffin | dddd546 | 2020-04-07 15:25:44 +0100 | [diff] [blame] | 448 | cc_prebuilt_library_shared { |
| 449 | name: "mylib2", |
| 450 | srcs: ["prebuilt.so"], |
| 451 | // TODO: remove //apex_available:platform |
| 452 | apex_available: [ |
| 453 | "//apex_available:platform", |
| 454 | "myapex", |
| 455 | ], |
| 456 | } |
| 457 | |
Jiyong Park | 9918e1a | 2020-03-17 19:16:40 +0900 | [diff] [blame] | 458 | cc_library_static { |
| 459 | name: "libstatic", |
| 460 | srcs: ["mylib.cpp"], |
| 461 | system_shared_libs: [], |
| 462 | stl: "none", |
| 463 | notice: "custom_notice_for_static_lib", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 464 | // TODO: remove //apex_available:platform |
| 465 | apex_available: [ |
| 466 | "//apex_available:platform", |
| 467 | "myapex", |
| 468 | ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 469 | } |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 470 | |
| 471 | java_library { |
| 472 | name: "myjar", |
| 473 | srcs: ["foo/bar/MyClass.java"], |
Jiyong Park | a62aa23 | 2020-05-28 23:46:55 +0900 | [diff] [blame] | 474 | stem: "myjar_stem", |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 475 | sdk_version: "none", |
| 476 | system_modules: "none", |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 477 | static_libs: ["myotherjar"], |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 478 | libs: ["mysharedjar"], |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 479 | // TODO: remove //apex_available:platform |
| 480 | apex_available: [ |
| 481 | "//apex_available:platform", |
| 482 | "myapex", |
| 483 | ], |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 484 | } |
| 485 | |
Jiyong Park | 77acec6 | 2020-06-01 21:39:15 +0900 | [diff] [blame] | 486 | dex_import { |
| 487 | name: "myjar_dex", |
| 488 | jars: ["prebuilt.jar"], |
| 489 | apex_available: [ |
| 490 | "//apex_available:platform", |
| 491 | "myapex", |
| 492 | ], |
| 493 | } |
| 494 | |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 495 | java_library { |
| 496 | name: "myotherjar", |
| 497 | srcs: ["foo/bar/MyClass.java"], |
| 498 | sdk_version: "none", |
| 499 | system_modules: "none", |
Jiyong Park | 0f80c18 | 2020-01-31 02:49:53 +0900 | [diff] [blame] | 500 | // TODO: remove //apex_available:platform |
| 501 | apex_available: [ |
| 502 | "//apex_available:platform", |
| 503 | "myapex", |
| 504 | ], |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 505 | } |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 506 | |
| 507 | java_library { |
| 508 | name: "mysharedjar", |
| 509 | srcs: ["foo/bar/MyClass.java"], |
| 510 | sdk_version: "none", |
| 511 | system_modules: "none", |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 512 | } |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 513 | `) |
| 514 | |
Paul Duffin | a71a67a | 2021-03-29 00:42:57 +0100 | [diff] [blame] | 515 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Jiyong Park | 42cca6c | 2019-04-01 11:15:50 +0900 | [diff] [blame] | 516 | |
Jiyong Park | 9e83f0b | 2020-06-11 00:35:03 +0900 | [diff] [blame] | 517 | // Make sure that Android.mk is created |
| 518 | ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 519 | data := android.AndroidMkDataForTest(t, ctx, ab) |
Jiyong Park | 9e83f0b | 2020-06-11 00:35:03 +0900 | [diff] [blame] | 520 | var builder strings.Builder |
| 521 | data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data) |
| 522 | |
| 523 | androidMk := builder.String() |
| 524 | ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n") |
| 525 | ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n") |
| 526 | |
Jiyong Park | 42cca6c | 2019-04-01 11:15:50 +0900 | [diff] [blame] | 527 | optFlags := apexRule.Args["opt_flags"] |
| 528 | ensureContains(t, optFlags, "--pubkey vendor/foo/devkeys/testkey.avbpubkey") |
Jaewoong Jung | 14f5ff6 | 2019-06-18 13:09:13 -0700 | [diff] [blame] | 529 | // Ensure that the NOTICE output is being packaged as an asset. |
Paul Duffin | 37ba344 | 2021-03-29 00:21:08 +0100 | [diff] [blame] | 530 | ensureContains(t, optFlags, "--assets_dir out/soong/.intermediates/myapex/android_common_myapex_image/NOTICE") |
Jiyong Park | 42cca6c | 2019-04-01 11:15:50 +0900 | [diff] [blame] | 531 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 532 | copyCmds := apexRule.Args["copy_commands"] |
| 533 | |
| 534 | // Ensure that main rule creates an output |
| 535 | ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned") |
| 536 | |
| 537 | // Ensure that apex variant is created for the direct dep |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 538 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000") |
| 539 | ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common_apex10000") |
| 540 | ensureListContains(t, ctx.ModuleVariantsForTests("myjar_dex"), "android_common_apex10000") |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 541 | ensureListContains(t, ctx.ModuleVariantsForTests("foo.rust"), "android_arm64_armv8-a_apex10000") |
Jiyong Park | f2cc1b7 | 2020-12-09 00:20:45 +0900 | [diff] [blame] | 542 | ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.ffi"), "android_arm64_armv8-a_shared_apex10000") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 543 | |
| 544 | // Ensure that apex variant is created for the indirect dep |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 545 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000") |
| 546 | ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common_apex10000") |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 547 | ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.rlib.rust"), "android_arm64_armv8-a_rlib_dylib-std_apex10000") |
| 548 | ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.dylib.rust"), "android_arm64_armv8-a_dylib_apex10000") |
Jiyong Park | f2cc1b7 | 2020-12-09 00:20:45 +0900 | [diff] [blame] | 549 | ensureListContains(t, ctx.ModuleVariantsForTests("libbar.ffi"), "android_arm64_armv8-a_shared_apex10000") |
Jiyong Park | 94e22fd | 2021-04-08 18:19:15 +0900 | [diff] [blame] | 550 | ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.shared_from_rust"), "android_arm64_armv8-a_shared_apex10000") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 551 | |
| 552 | // Ensure that both direct and indirect deps are copied into apex |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 553 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
| 554 | ensureContains(t, copyCmds, "image.apex/lib64/mylib2.so") |
Jiyong Park | a62aa23 | 2020-05-28 23:46:55 +0900 | [diff] [blame] | 555 | ensureContains(t, copyCmds, "image.apex/javalib/myjar_stem.jar") |
Jiyong Park | 77acec6 | 2020-06-01 21:39:15 +0900 | [diff] [blame] | 556 | ensureContains(t, copyCmds, "image.apex/javalib/myjar_dex.jar") |
Jiyong Park | 99644e9 | 2020-11-17 22:21:02 +0900 | [diff] [blame] | 557 | ensureContains(t, copyCmds, "image.apex/lib64/libfoo.dylib.rust.dylib.so") |
Jiyong Park | f2cc1b7 | 2020-12-09 00:20:45 +0900 | [diff] [blame] | 558 | ensureContains(t, copyCmds, "image.apex/lib64/libfoo.ffi.so") |
| 559 | ensureContains(t, copyCmds, "image.apex/lib64/libbar.ffi.so") |
Jiyong Park | 94e22fd | 2021-04-08 18:19:15 +0900 | [diff] [blame] | 560 | ensureContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so") |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 561 | // .. but not for java libs |
| 562 | ensureNotContains(t, copyCmds, "image.apex/javalib/myotherjar.jar") |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 563 | ensureNotContains(t, copyCmds, "image.apex/javalib/msharedjar.jar") |
Logan Chien | 3aeedc9 | 2018-12-26 15:32:21 +0800 | [diff] [blame] | 564 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 565 | // Ensure that the platform variant ends with _shared or _common |
| 566 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared") |
| 567 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared") |
Jiyong Park | 7f7766d | 2019-07-25 22:02:35 +0900 | [diff] [blame] | 568 | ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common") |
| 569 | ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common") |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 570 | ensureListContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common") |
| 571 | |
| 572 | // Ensure that dynamic dependency to java libs are not included |
| 573 | ensureListNotContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common_myapex") |
Alex Light | 3d67359 | 2019-01-18 14:37:31 -0800 | [diff] [blame] | 574 | |
| 575 | // Ensure that all symlinks are present. |
| 576 | found_foo_link_64 := false |
| 577 | found_foo := false |
| 578 | for _, cmd := range strings.Split(copyCmds, " && ") { |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 579 | if strings.HasPrefix(cmd, "ln -sfn foo64") { |
Alex Light | 3d67359 | 2019-01-18 14:37:31 -0800 | [diff] [blame] | 580 | if strings.HasSuffix(cmd, "bin/foo") { |
| 581 | found_foo = true |
| 582 | } else if strings.HasSuffix(cmd, "bin/foo_link_64") { |
| 583 | found_foo_link_64 = true |
| 584 | } |
| 585 | } |
| 586 | } |
| 587 | good := found_foo && found_foo_link_64 |
| 588 | if !good { |
| 589 | t.Errorf("Could not find all expected symlinks! foo: %t, foo_link_64: %t. Command was %s", found_foo, found_foo_link_64, copyCmds) |
| 590 | } |
Jiyong Park | 52818fc | 2019-03-18 12:01:38 +0900 | [diff] [blame] | 591 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 592 | mergeNoticesRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("mergeNoticesRule") |
Jaewoong Jung | 5b425e2 | 2019-06-17 17:40:56 -0700 | [diff] [blame] | 593 | noticeInputs := mergeNoticesRule.Inputs.Strings() |
Jiyong Park | 9918e1a | 2020-03-17 19:16:40 +0900 | [diff] [blame] | 594 | if len(noticeInputs) != 3 { |
| 595 | t.Errorf("number of input notice files: expected = 3, actual = %q", len(noticeInputs)) |
Jiyong Park | 52818fc | 2019-03-18 12:01:38 +0900 | [diff] [blame] | 596 | } |
| 597 | ensureListContains(t, noticeInputs, "NOTICE") |
| 598 | ensureListContains(t, noticeInputs, "custom_notice") |
Jiyong Park | 9918e1a | 2020-03-17 19:16:40 +0900 | [diff] [blame] | 599 | ensureListContains(t, noticeInputs, "custom_notice_for_static_lib") |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 600 | |
Artur Satayev | a8bd113 | 2020-04-27 18:07:06 +0100 | [diff] [blame] | 601 | fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n") |
Artur Satayev | 4e1f2bd | 2020-05-14 15:15:01 +0100 | [diff] [blame] | 602 | ensureListContains(t, fullDepsInfo, " myjar(minSdkVersion:(no version)) <- myapex") |
Artur Satayev | 4e1f2bd | 2020-05-14 15:15:01 +0100 | [diff] [blame] | 603 | ensureListContains(t, fullDepsInfo, " mylib2(minSdkVersion:(no version)) <- mylib") |
| 604 | ensureListContains(t, fullDepsInfo, " myotherjar(minSdkVersion:(no version)) <- myjar") |
| 605 | ensureListContains(t, fullDepsInfo, " mysharedjar(minSdkVersion:(no version)) (external) <- myjar") |
Artur Satayev | a8bd113 | 2020-04-27 18:07:06 +0100 | [diff] [blame] | 606 | |
| 607 | flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n") |
Artur Satayev | 4e1f2bd | 2020-05-14 15:15:01 +0100 | [diff] [blame] | 608 | ensureListContains(t, flatDepsInfo, "myjar(minSdkVersion:(no version))") |
Artur Satayev | 4e1f2bd | 2020-05-14 15:15:01 +0100 | [diff] [blame] | 609 | ensureListContains(t, flatDepsInfo, "mylib2(minSdkVersion:(no version))") |
| 610 | ensureListContains(t, flatDepsInfo, "myotherjar(minSdkVersion:(no version))") |
| 611 | ensureListContains(t, flatDepsInfo, "mysharedjar(minSdkVersion:(no version)) (external)") |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 612 | } |
| 613 | |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 614 | func TestDefaults(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 615 | ctx := testApex(t, ` |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 616 | apex_defaults { |
| 617 | name: "myapex-defaults", |
| 618 | key: "myapex.key", |
| 619 | prebuilts: ["myetc"], |
| 620 | native_shared_libs: ["mylib"], |
| 621 | java_libs: ["myjar"], |
| 622 | apps: ["AppFoo"], |
Jiyong Park | 69aeba9 | 2020-04-24 21:16:36 +0900 | [diff] [blame] | 623 | rros: ["rro"], |
markchien | 2f59ec9 | 2020-09-02 16:23:38 +0800 | [diff] [blame] | 624 | bpfs: ["bpf"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 625 | updatable: false, |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 626 | } |
| 627 | |
| 628 | prebuilt_etc { |
| 629 | name: "myetc", |
| 630 | src: "myprebuilt", |
| 631 | } |
| 632 | |
| 633 | apex { |
| 634 | name: "myapex", |
| 635 | defaults: ["myapex-defaults"], |
| 636 | } |
| 637 | |
| 638 | apex_key { |
| 639 | name: "myapex.key", |
| 640 | public_key: "testkey.avbpubkey", |
| 641 | private_key: "testkey.pem", |
| 642 | } |
| 643 | |
| 644 | cc_library { |
| 645 | name: "mylib", |
| 646 | system_shared_libs: [], |
| 647 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 648 | apex_available: [ "myapex" ], |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 649 | } |
| 650 | |
| 651 | java_library { |
| 652 | name: "myjar", |
| 653 | srcs: ["foo/bar/MyClass.java"], |
| 654 | sdk_version: "none", |
| 655 | system_modules: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 656 | apex_available: [ "myapex" ], |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 657 | } |
| 658 | |
| 659 | android_app { |
| 660 | name: "AppFoo", |
| 661 | srcs: ["foo/bar/MyClass.java"], |
| 662 | sdk_version: "none", |
| 663 | system_modules: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 664 | apex_available: [ "myapex" ], |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 665 | } |
Jiyong Park | 69aeba9 | 2020-04-24 21:16:36 +0900 | [diff] [blame] | 666 | |
| 667 | runtime_resource_overlay { |
| 668 | name: "rro", |
| 669 | theme: "blue", |
| 670 | } |
| 671 | |
markchien | 2f59ec9 | 2020-09-02 16:23:38 +0800 | [diff] [blame] | 672 | bpf { |
| 673 | name: "bpf", |
| 674 | srcs: ["bpf.c", "bpf2.c"], |
| 675 | } |
| 676 | |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 677 | `) |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 678 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 679 | "etc/myetc", |
| 680 | "javalib/myjar.jar", |
| 681 | "lib64/mylib.so", |
| 682 | "app/AppFoo/AppFoo.apk", |
Jiyong Park | 69aeba9 | 2020-04-24 21:16:36 +0900 | [diff] [blame] | 683 | "overlay/blue/rro.apk", |
markchien | 2f59ec9 | 2020-09-02 16:23:38 +0800 | [diff] [blame] | 684 | "etc/bpf/bpf.o", |
| 685 | "etc/bpf/bpf2.o", |
Jooyung Han | f21c797 | 2019-12-16 22:32:06 +0900 | [diff] [blame] | 686 | }) |
| 687 | } |
| 688 | |
Jooyung Han | 01a3ee2 | 2019-11-02 02:52:25 +0900 | [diff] [blame] | 689 | func TestApexManifest(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 690 | ctx := testApex(t, ` |
Jooyung Han | 01a3ee2 | 2019-11-02 02:52:25 +0900 | [diff] [blame] | 691 | apex { |
| 692 | name: "myapex", |
| 693 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 694 | updatable: false, |
Jooyung Han | 01a3ee2 | 2019-11-02 02:52:25 +0900 | [diff] [blame] | 695 | } |
| 696 | |
| 697 | apex_key { |
| 698 | name: "myapex.key", |
| 699 | public_key: "testkey.avbpubkey", |
| 700 | private_key: "testkey.pem", |
| 701 | } |
| 702 | `) |
| 703 | |
| 704 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 705 | args := module.Rule("apexRule").Args |
| 706 | if manifest := args["manifest"]; manifest != module.Output("apex_manifest.pb").Output.String() { |
| 707 | t.Error("manifest should be apex_manifest.pb, but " + manifest) |
| 708 | } |
Jooyung Han | 01a3ee2 | 2019-11-02 02:52:25 +0900 | [diff] [blame] | 709 | } |
| 710 | |
Liz Kammer | 4854a7d | 2021-05-27 14:28:27 -0400 | [diff] [blame] | 711 | func TestApexManifestMinSdkVersion(t *testing.T) { |
| 712 | ctx := testApex(t, ` |
| 713 | apex_defaults { |
| 714 | name: "my_defaults", |
| 715 | key: "myapex.key", |
| 716 | product_specific: true, |
| 717 | file_contexts: ":my-file-contexts", |
| 718 | updatable: false, |
| 719 | } |
| 720 | apex { |
| 721 | name: "myapex_30", |
| 722 | min_sdk_version: "30", |
| 723 | defaults: ["my_defaults"], |
| 724 | } |
| 725 | |
| 726 | apex { |
| 727 | name: "myapex_current", |
| 728 | min_sdk_version: "current", |
| 729 | defaults: ["my_defaults"], |
| 730 | } |
| 731 | |
| 732 | apex { |
| 733 | name: "myapex_none", |
| 734 | defaults: ["my_defaults"], |
| 735 | } |
| 736 | |
| 737 | apex_key { |
| 738 | name: "myapex.key", |
| 739 | public_key: "testkey.avbpubkey", |
| 740 | private_key: "testkey.pem", |
| 741 | } |
| 742 | |
| 743 | filegroup { |
| 744 | name: "my-file-contexts", |
| 745 | srcs: ["product_specific_file_contexts"], |
| 746 | } |
| 747 | `, withFiles(map[string][]byte{ |
| 748 | "product_specific_file_contexts": nil, |
| 749 | }), android.FixtureModifyProductVariables( |
| 750 | func(variables android.FixtureProductVariables) { |
| 751 | variables.Unbundled_build = proptools.BoolPtr(true) |
| 752 | variables.Always_use_prebuilt_sdks = proptools.BoolPtr(false) |
| 753 | }), android.FixtureMergeEnv(map[string]string{ |
| 754 | "UNBUNDLED_BUILD_TARGET_SDK_WITH_API_FINGERPRINT": "true", |
| 755 | })) |
| 756 | |
| 757 | testCases := []struct { |
| 758 | module string |
| 759 | minSdkVersion string |
| 760 | }{ |
| 761 | { |
| 762 | module: "myapex_30", |
| 763 | minSdkVersion: "30", |
| 764 | }, |
| 765 | { |
| 766 | module: "myapex_current", |
| 767 | minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)", |
| 768 | }, |
| 769 | { |
| 770 | module: "myapex_none", |
| 771 | minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)", |
| 772 | }, |
| 773 | } |
| 774 | for _, tc := range testCases { |
| 775 | module := ctx.ModuleForTests(tc.module, "android_common_"+tc.module+"_image") |
| 776 | args := module.Rule("apexRule").Args |
| 777 | optFlags := args["opt_flags"] |
| 778 | if !strings.Contains(optFlags, "--min_sdk_version "+tc.minSdkVersion) { |
| 779 | t.Errorf("%s: Expected min_sdk_version=%s, got: %s", tc.module, tc.minSdkVersion, optFlags) |
| 780 | } |
| 781 | } |
| 782 | } |
| 783 | |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 784 | func TestBasicZipApex(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 785 | ctx := testApex(t, ` |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 786 | apex { |
| 787 | name: "myapex", |
| 788 | key: "myapex.key", |
| 789 | payload_type: "zip", |
| 790 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 791 | updatable: false, |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 792 | } |
| 793 | |
| 794 | apex_key { |
| 795 | name: "myapex.key", |
| 796 | public_key: "testkey.avbpubkey", |
| 797 | private_key: "testkey.pem", |
| 798 | } |
| 799 | |
| 800 | cc_library { |
| 801 | name: "mylib", |
| 802 | srcs: ["mylib.cpp"], |
| 803 | shared_libs: ["mylib2"], |
| 804 | system_shared_libs: [], |
| 805 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 806 | apex_available: [ "myapex" ], |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 807 | } |
| 808 | |
| 809 | cc_library { |
| 810 | name: "mylib2", |
| 811 | srcs: ["mylib.cpp"], |
| 812 | system_shared_libs: [], |
| 813 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 814 | apex_available: [ "myapex" ], |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 815 | } |
| 816 | `) |
| 817 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 818 | zipApexRule := ctx.ModuleForTests("myapex", "android_common_myapex_zip").Rule("zipApexRule") |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 819 | copyCmds := zipApexRule.Args["copy_commands"] |
| 820 | |
| 821 | // Ensure that main rule creates an output |
| 822 | ensureContains(t, zipApexRule.Output.String(), "myapex.zipapex.unsigned") |
| 823 | |
| 824 | // Ensure that APEX variant is created for the direct dep |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 825 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000") |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 826 | |
| 827 | // Ensure that APEX variant is created for the indirect dep |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 828 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000") |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 829 | |
| 830 | // Ensure that both direct and indirect deps are copied into apex |
| 831 | ensureContains(t, copyCmds, "image.zipapex/lib64/mylib.so") |
| 832 | ensureContains(t, copyCmds, "image.zipapex/lib64/mylib2.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 833 | } |
| 834 | |
| 835 | func TestApexWithStubs(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 836 | ctx := testApex(t, ` |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 837 | apex { |
| 838 | name: "myapex", |
| 839 | key: "myapex.key", |
| 840 | native_shared_libs: ["mylib", "mylib3"], |
Jiyong Park | 105dc32 | 2021-06-11 17:22:09 +0900 | [diff] [blame] | 841 | binaries: ["foo.rust"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 842 | updatable: false, |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 843 | } |
| 844 | |
| 845 | apex_key { |
| 846 | name: "myapex.key", |
| 847 | public_key: "testkey.avbpubkey", |
| 848 | private_key: "testkey.pem", |
| 849 | } |
| 850 | |
| 851 | cc_library { |
| 852 | name: "mylib", |
| 853 | srcs: ["mylib.cpp"], |
| 854 | shared_libs: ["mylib2", "mylib3"], |
| 855 | system_shared_libs: [], |
| 856 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 857 | apex_available: [ "myapex" ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 858 | } |
| 859 | |
| 860 | cc_library { |
| 861 | name: "mylib2", |
| 862 | srcs: ["mylib.cpp"], |
Jiyong Park | 6437995 | 2018-12-13 18:37:29 +0900 | [diff] [blame] | 863 | cflags: ["-include mylib.h"], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 864 | system_shared_libs: [], |
| 865 | stl: "none", |
| 866 | stubs: { |
| 867 | versions: ["1", "2", "3"], |
| 868 | }, |
| 869 | } |
| 870 | |
| 871 | cc_library { |
| 872 | name: "mylib3", |
Jiyong Park | 28d395a | 2018-12-07 22:42:47 +0900 | [diff] [blame] | 873 | srcs: ["mylib.cpp"], |
| 874 | shared_libs: ["mylib4"], |
| 875 | system_shared_libs: [], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 876 | stl: "none", |
| 877 | stubs: { |
| 878 | versions: ["10", "11", "12"], |
| 879 | }, |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 880 | apex_available: [ "myapex" ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 881 | } |
Jiyong Park | 28d395a | 2018-12-07 22:42:47 +0900 | [diff] [blame] | 882 | |
| 883 | cc_library { |
| 884 | name: "mylib4", |
| 885 | srcs: ["mylib.cpp"], |
| 886 | system_shared_libs: [], |
| 887 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 888 | apex_available: [ "myapex" ], |
Jiyong Park | 28d395a | 2018-12-07 22:42:47 +0900 | [diff] [blame] | 889 | } |
Jiyong Park | 105dc32 | 2021-06-11 17:22:09 +0900 | [diff] [blame] | 890 | |
| 891 | rust_binary { |
| 892 | name: "foo.rust", |
| 893 | srcs: ["foo.rs"], |
| 894 | shared_libs: ["libfoo.shared_from_rust"], |
| 895 | prefer_rlib: true, |
| 896 | apex_available: ["myapex"], |
| 897 | } |
| 898 | |
| 899 | cc_library_shared { |
| 900 | name: "libfoo.shared_from_rust", |
| 901 | srcs: ["mylib.cpp"], |
| 902 | system_shared_libs: [], |
| 903 | stl: "none", |
| 904 | stubs: { |
| 905 | versions: ["10", "11", "12"], |
| 906 | }, |
| 907 | } |
| 908 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 909 | `) |
| 910 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 911 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 912 | copyCmds := apexRule.Args["copy_commands"] |
| 913 | |
| 914 | // Ensure that direct non-stubs dep is always included |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 915 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 916 | |
| 917 | // Ensure that indirect stubs dep is not included |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 918 | ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 919 | |
| 920 | // Ensure that direct stubs dep is included |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 921 | ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 922 | |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 923 | mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"] |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 924 | |
| 925 | // Ensure that mylib is linking with the latest version of stubs for mylib2 |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 926 | ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 927 | // ... and not linking to the non-stub (impl) variant of mylib2 |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 928 | ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 929 | |
| 930 | // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex) |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 931 | ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex10000/mylib3.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 932 | // .. and not linking to the stubs variant of mylib3 |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 933 | ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_12/mylib3.so") |
Jiyong Park | 6437995 | 2018-12-13 18:37:29 +0900 | [diff] [blame] | 934 | |
Chih-Hung Hsieh | b808229 | 2021-09-09 23:20:39 -0700 | [diff] [blame] | 935 | // Comment out this test. Now it fails after the optimization of sharing "cflags" in cc/cc.go |
| 936 | // is replaced by sharing of "cFlags" in cc/builder.go. |
| 937 | // The "cflags" contains "-include mylib.h", but cFlags contained only a reference to the |
| 938 | // module variable representing "cflags". So it was not detected by ensureNotContains. |
| 939 | // Now "cFlags" is a reference to a module variable like $flags1, which includes all previous |
| 940 | // content of "cflags". ModuleForTests...Args["cFlags"] returns the full string of $flags1, |
| 941 | // including the original cflags's "-include mylib.h". |
| 942 | // |
Jiyong Park | 6437995 | 2018-12-13 18:37:29 +0900 | [diff] [blame] | 943 | // Ensure that stubs libs are built without -include flags |
Chih-Hung Hsieh | b808229 | 2021-09-09 23:20:39 -0700 | [diff] [blame] | 944 | // mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
| 945 | // ensureNotContains(t, mylib2Cflags, "-include ") |
Jiyong Park | 3fd0baf | 2018-12-07 16:25:39 +0900 | [diff] [blame] | 946 | |
| 947 | // Ensure that genstub is invoked with --apex |
Colin Cross | a717db7 | 2020-10-23 14:53:06 -0700 | [diff] [blame] | 948 | ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_3").Rule("genStubSrc").Args["flags"]) |
Jooyung Han | 671f1ce | 2019-12-17 12:47:13 +0900 | [diff] [blame] | 949 | |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 950 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
Jooyung Han | 671f1ce | 2019-12-17 12:47:13 +0900 | [diff] [blame] | 951 | "lib64/mylib.so", |
| 952 | "lib64/mylib3.so", |
| 953 | "lib64/mylib4.so", |
Jiyong Park | 105dc32 | 2021-06-11 17:22:09 +0900 | [diff] [blame] | 954 | "bin/foo.rust", |
| 955 | "lib64/libc++.so", // by the implicit dependency from foo.rust |
| 956 | "lib64/liblog.so", // by the implicit dependency from foo.rust |
Jooyung Han | 671f1ce | 2019-12-17 12:47:13 +0900 | [diff] [blame] | 957 | }) |
Jiyong Park | 105dc32 | 2021-06-11 17:22:09 +0900 | [diff] [blame] | 958 | |
| 959 | // Ensure that stub dependency from a rust module is not included |
| 960 | ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so") |
| 961 | // The rust module is linked to the stub cc library |
| 962 | rustDeps := ctx.ModuleForTests("foo.rust", "android_arm64_armv8-a_apex10000").Rule("rustc").Args["linkFlags"] |
| 963 | ensureContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared_current/libfoo.shared_from_rust.so") |
| 964 | ensureNotContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared/libfoo.shared_from_rust.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 965 | } |
| 966 | |
Jiyong Park | 1bc8412 | 2021-06-22 20:23:05 +0900 | [diff] [blame] | 967 | func TestApexCanUsePrivateApis(t *testing.T) { |
| 968 | ctx := testApex(t, ` |
| 969 | apex { |
| 970 | name: "myapex", |
| 971 | key: "myapex.key", |
| 972 | native_shared_libs: ["mylib"], |
| 973 | binaries: ["foo.rust"], |
| 974 | updatable: false, |
| 975 | platform_apis: true, |
| 976 | } |
| 977 | |
| 978 | apex_key { |
| 979 | name: "myapex.key", |
| 980 | public_key: "testkey.avbpubkey", |
| 981 | private_key: "testkey.pem", |
| 982 | } |
| 983 | |
| 984 | cc_library { |
| 985 | name: "mylib", |
| 986 | srcs: ["mylib.cpp"], |
| 987 | shared_libs: ["mylib2"], |
| 988 | system_shared_libs: [], |
| 989 | stl: "none", |
| 990 | apex_available: [ "myapex" ], |
| 991 | } |
| 992 | |
| 993 | cc_library { |
| 994 | name: "mylib2", |
| 995 | srcs: ["mylib.cpp"], |
| 996 | cflags: ["-include mylib.h"], |
| 997 | system_shared_libs: [], |
| 998 | stl: "none", |
| 999 | stubs: { |
| 1000 | versions: ["1", "2", "3"], |
| 1001 | }, |
| 1002 | } |
| 1003 | |
| 1004 | rust_binary { |
| 1005 | name: "foo.rust", |
| 1006 | srcs: ["foo.rs"], |
| 1007 | shared_libs: ["libfoo.shared_from_rust"], |
| 1008 | prefer_rlib: true, |
| 1009 | apex_available: ["myapex"], |
| 1010 | } |
| 1011 | |
| 1012 | cc_library_shared { |
| 1013 | name: "libfoo.shared_from_rust", |
| 1014 | srcs: ["mylib.cpp"], |
| 1015 | system_shared_libs: [], |
| 1016 | stl: "none", |
| 1017 | stubs: { |
| 1018 | versions: ["10", "11", "12"], |
| 1019 | }, |
| 1020 | } |
| 1021 | `) |
| 1022 | |
| 1023 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
| 1024 | copyCmds := apexRule.Args["copy_commands"] |
| 1025 | |
| 1026 | // Ensure that indirect stubs dep is not included |
| 1027 | ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so") |
| 1028 | ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so") |
| 1029 | |
| 1030 | // Ensure that we are using non-stub variants of mylib2 and libfoo.shared_from_rust (because |
| 1031 | // of the platform_apis: true) |
| 1032 | mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000_private").Rule("ld").Args["libFlags"] |
| 1033 | ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so") |
| 1034 | ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so") |
| 1035 | rustDeps := ctx.ModuleForTests("foo.rust", "android_arm64_armv8-a_apex10000_private").Rule("rustc").Args["linkFlags"] |
| 1036 | ensureNotContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared_current/libfoo.shared_from_rust.so") |
| 1037 | ensureContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared/libfoo.shared_from_rust.so") |
| 1038 | } |
| 1039 | |
Colin Cross | 7812fd3 | 2020-09-25 12:35:10 -0700 | [diff] [blame] | 1040 | func TestApexWithStubsWithMinSdkVersion(t *testing.T) { |
| 1041 | t.Parallel() |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1042 | ctx := testApex(t, ` |
Colin Cross | 7812fd3 | 2020-09-25 12:35:10 -0700 | [diff] [blame] | 1043 | apex { |
| 1044 | name: "myapex", |
| 1045 | key: "myapex.key", |
| 1046 | native_shared_libs: ["mylib", "mylib3"], |
| 1047 | min_sdk_version: "29", |
| 1048 | } |
| 1049 | |
| 1050 | apex_key { |
| 1051 | name: "myapex.key", |
| 1052 | public_key: "testkey.avbpubkey", |
| 1053 | private_key: "testkey.pem", |
| 1054 | } |
| 1055 | |
| 1056 | cc_library { |
| 1057 | name: "mylib", |
| 1058 | srcs: ["mylib.cpp"], |
| 1059 | shared_libs: ["mylib2", "mylib3"], |
| 1060 | system_shared_libs: [], |
| 1061 | stl: "none", |
| 1062 | apex_available: [ "myapex" ], |
| 1063 | min_sdk_version: "28", |
| 1064 | } |
| 1065 | |
| 1066 | cc_library { |
| 1067 | name: "mylib2", |
| 1068 | srcs: ["mylib.cpp"], |
| 1069 | cflags: ["-include mylib.h"], |
| 1070 | system_shared_libs: [], |
| 1071 | stl: "none", |
| 1072 | stubs: { |
| 1073 | versions: ["28", "29", "30", "current"], |
| 1074 | }, |
| 1075 | min_sdk_version: "28", |
| 1076 | } |
| 1077 | |
| 1078 | cc_library { |
| 1079 | name: "mylib3", |
| 1080 | srcs: ["mylib.cpp"], |
| 1081 | shared_libs: ["mylib4"], |
| 1082 | system_shared_libs: [], |
| 1083 | stl: "none", |
| 1084 | stubs: { |
| 1085 | versions: ["28", "29", "30", "current"], |
| 1086 | }, |
| 1087 | apex_available: [ "myapex" ], |
| 1088 | min_sdk_version: "28", |
| 1089 | } |
| 1090 | |
| 1091 | cc_library { |
| 1092 | name: "mylib4", |
| 1093 | srcs: ["mylib.cpp"], |
| 1094 | system_shared_libs: [], |
| 1095 | stl: "none", |
| 1096 | apex_available: [ "myapex" ], |
| 1097 | min_sdk_version: "28", |
| 1098 | } |
| 1099 | `) |
| 1100 | |
| 1101 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
| 1102 | copyCmds := apexRule.Args["copy_commands"] |
| 1103 | |
| 1104 | // Ensure that direct non-stubs dep is always included |
| 1105 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
| 1106 | |
| 1107 | // Ensure that indirect stubs dep is not included |
| 1108 | ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so") |
| 1109 | |
| 1110 | // Ensure that direct stubs dep is included |
| 1111 | ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so") |
| 1112 | |
| 1113 | mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex29").Rule("ld").Args["libFlags"] |
| 1114 | |
Jiyong Park | 55549df | 2021-02-26 23:57:23 +0900 | [diff] [blame] | 1115 | // Ensure that mylib is linking with the latest version of stub for mylib2 |
| 1116 | ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so") |
Colin Cross | 7812fd3 | 2020-09-25 12:35:10 -0700 | [diff] [blame] | 1117 | // ... and not linking to the non-stub (impl) variant of mylib2 |
| 1118 | ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so") |
| 1119 | |
| 1120 | // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex) |
| 1121 | ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex29/mylib3.so") |
| 1122 | // .. and not linking to the stubs variant of mylib3 |
| 1123 | ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_29/mylib3.so") |
| 1124 | |
| 1125 | // Ensure that stubs libs are built without -include flags |
Colin Cross | a717db7 | 2020-10-23 14:53:06 -0700 | [diff] [blame] | 1126 | mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("cc").Args["cFlags"] |
Colin Cross | 7812fd3 | 2020-09-25 12:35:10 -0700 | [diff] [blame] | 1127 | ensureNotContains(t, mylib2Cflags, "-include ") |
| 1128 | |
| 1129 | // Ensure that genstub is invoked with --apex |
Colin Cross | a717db7 | 2020-10-23 14:53:06 -0700 | [diff] [blame] | 1130 | ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("genStubSrc").Args["flags"]) |
Colin Cross | 7812fd3 | 2020-09-25 12:35:10 -0700 | [diff] [blame] | 1131 | |
| 1132 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 1133 | "lib64/mylib.so", |
| 1134 | "lib64/mylib3.so", |
| 1135 | "lib64/mylib4.so", |
| 1136 | }) |
| 1137 | } |
| 1138 | |
Jooyung Han | 11b0fbd | 2021-02-05 02:28:22 +0900 | [diff] [blame] | 1139 | func TestApex_PlatformUsesLatestStubFromApex(t *testing.T) { |
| 1140 | t.Parallel() |
| 1141 | // myapex (Z) |
| 1142 | // mylib -----------------. |
| 1143 | // | |
| 1144 | // otherapex (29) | |
| 1145 | // libstub's versions: 29 Z current |
| 1146 | // | |
| 1147 | // <platform> | |
| 1148 | // libplatform ----------------' |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1149 | ctx := testApex(t, ` |
Jooyung Han | 11b0fbd | 2021-02-05 02:28:22 +0900 | [diff] [blame] | 1150 | apex { |
| 1151 | name: "myapex", |
| 1152 | key: "myapex.key", |
| 1153 | native_shared_libs: ["mylib"], |
| 1154 | min_sdk_version: "Z", // non-final |
| 1155 | } |
| 1156 | |
| 1157 | cc_library { |
| 1158 | name: "mylib", |
| 1159 | srcs: ["mylib.cpp"], |
| 1160 | shared_libs: ["libstub"], |
| 1161 | apex_available: ["myapex"], |
| 1162 | min_sdk_version: "Z", |
| 1163 | } |
| 1164 | |
| 1165 | apex_key { |
| 1166 | name: "myapex.key", |
| 1167 | public_key: "testkey.avbpubkey", |
| 1168 | private_key: "testkey.pem", |
| 1169 | } |
| 1170 | |
| 1171 | apex { |
| 1172 | name: "otherapex", |
| 1173 | key: "myapex.key", |
| 1174 | native_shared_libs: ["libstub"], |
| 1175 | min_sdk_version: "29", |
| 1176 | } |
| 1177 | |
| 1178 | cc_library { |
| 1179 | name: "libstub", |
| 1180 | srcs: ["mylib.cpp"], |
| 1181 | stubs: { |
| 1182 | versions: ["29", "Z", "current"], |
| 1183 | }, |
| 1184 | apex_available: ["otherapex"], |
| 1185 | min_sdk_version: "29", |
| 1186 | } |
| 1187 | |
| 1188 | // platform module depending on libstub from otherapex should use the latest stub("current") |
| 1189 | cc_library { |
| 1190 | name: "libplatform", |
| 1191 | srcs: ["mylib.cpp"], |
| 1192 | shared_libs: ["libstub"], |
| 1193 | } |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 1194 | `, |
| 1195 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 1196 | variables.Platform_sdk_codename = proptools.StringPtr("Z") |
| 1197 | variables.Platform_sdk_final = proptools.BoolPtr(false) |
| 1198 | variables.Platform_version_active_codenames = []string{"Z"} |
| 1199 | }), |
| 1200 | ) |
Jooyung Han | 11b0fbd | 2021-02-05 02:28:22 +0900 | [diff] [blame] | 1201 | |
Jiyong Park | 55549df | 2021-02-26 23:57:23 +0900 | [diff] [blame] | 1202 | // Ensure that mylib from myapex is built against the latest stub (current) |
Jooyung Han | 11b0fbd | 2021-02-05 02:28:22 +0900 | [diff] [blame] | 1203 | mylibCflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"] |
Jiyong Park | 55549df | 2021-02-26 23:57:23 +0900 | [diff] [blame] | 1204 | ensureContains(t, mylibCflags, "-D__LIBSTUB_API__=10000 ") |
Jooyung Han | 11b0fbd | 2021-02-05 02:28:22 +0900 | [diff] [blame] | 1205 | mylibLdflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"] |
Jiyong Park | 55549df | 2021-02-26 23:57:23 +0900 | [diff] [blame] | 1206 | ensureContains(t, mylibLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ") |
Jooyung Han | 11b0fbd | 2021-02-05 02:28:22 +0900 | [diff] [blame] | 1207 | |
| 1208 | // Ensure that libplatform is built against latest stub ("current") of mylib3 from the apex |
| 1209 | libplatformCflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
| 1210 | ensureContains(t, libplatformCflags, "-D__LIBSTUB_API__=10000 ") // "current" maps to 10000 |
| 1211 | libplatformLdflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"] |
| 1212 | ensureContains(t, libplatformLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ") |
| 1213 | } |
| 1214 | |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1215 | func TestApexWithExplicitStubsDependency(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1216 | ctx := testApex(t, ` |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1217 | apex { |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 1218 | name: "myapex2", |
| 1219 | key: "myapex2.key", |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1220 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 1221 | updatable: false, |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1222 | } |
| 1223 | |
| 1224 | apex_key { |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 1225 | name: "myapex2.key", |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1226 | public_key: "testkey.avbpubkey", |
| 1227 | private_key: "testkey.pem", |
| 1228 | } |
| 1229 | |
| 1230 | cc_library { |
| 1231 | name: "mylib", |
| 1232 | srcs: ["mylib.cpp"], |
| 1233 | shared_libs: ["libfoo#10"], |
Jiyong Park | 678c881 | 2020-02-07 17:25:49 +0900 | [diff] [blame] | 1234 | static_libs: ["libbaz"], |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1235 | system_shared_libs: [], |
| 1236 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 1237 | apex_available: [ "myapex2" ], |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1238 | } |
| 1239 | |
| 1240 | cc_library { |
| 1241 | name: "libfoo", |
| 1242 | srcs: ["mylib.cpp"], |
| 1243 | shared_libs: ["libbar"], |
| 1244 | system_shared_libs: [], |
| 1245 | stl: "none", |
| 1246 | stubs: { |
| 1247 | versions: ["10", "20", "30"], |
| 1248 | }, |
| 1249 | } |
| 1250 | |
| 1251 | cc_library { |
| 1252 | name: "libbar", |
| 1253 | srcs: ["mylib.cpp"], |
| 1254 | system_shared_libs: [], |
| 1255 | stl: "none", |
| 1256 | } |
| 1257 | |
Jiyong Park | 678c881 | 2020-02-07 17:25:49 +0900 | [diff] [blame] | 1258 | cc_library_static { |
| 1259 | name: "libbaz", |
| 1260 | srcs: ["mylib.cpp"], |
| 1261 | system_shared_libs: [], |
| 1262 | stl: "none", |
| 1263 | apex_available: [ "myapex2" ], |
| 1264 | } |
| 1265 | |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1266 | `) |
| 1267 | |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 1268 | apexRule := ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Rule("apexRule") |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1269 | copyCmds := apexRule.Args["copy_commands"] |
| 1270 | |
| 1271 | // Ensure that direct non-stubs dep is always included |
| 1272 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
| 1273 | |
| 1274 | // Ensure that indirect stubs dep is not included |
| 1275 | ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so") |
| 1276 | |
| 1277 | // Ensure that dependency of stubs is not included |
| 1278 | ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so") |
| 1279 | |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1280 | mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"] |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1281 | |
| 1282 | // Ensure that mylib is linking with version 10 of libfoo |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 1283 | ensureContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared_10/libfoo.so") |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1284 | // ... and not linking to the non-stub (impl) variant of libfoo |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 1285 | ensureNotContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared/libfoo.so") |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1286 | |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 1287 | libFooStubsLdFlags := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_10").Rule("ld").Args["libFlags"] |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1288 | |
| 1289 | // Ensure that libfoo stubs is not linking to libbar (since it is a stubs) |
| 1290 | ensureNotContains(t, libFooStubsLdFlags, "libbar.so") |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 1291 | |
Artur Satayev | a8bd113 | 2020-04-27 18:07:06 +0100 | [diff] [blame] | 1292 | fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n") |
Artur Satayev | 4e1f2bd | 2020-05-14 15:15:01 +0100 | [diff] [blame] | 1293 | ensureListContains(t, fullDepsInfo, " libfoo(minSdkVersion:(no version)) (external) <- mylib") |
Jiyong Park | 678c881 | 2020-02-07 17:25:49 +0900 | [diff] [blame] | 1294 | |
Artur Satayev | a8bd113 | 2020-04-27 18:07:06 +0100 | [diff] [blame] | 1295 | flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n") |
Artur Satayev | 4e1f2bd | 2020-05-14 15:15:01 +0100 | [diff] [blame] | 1296 | ensureListContains(t, flatDepsInfo, "libfoo(minSdkVersion:(no version)) (external)") |
Jiyong Park | 0ddfcd1 | 2018-12-11 01:35:25 +0900 | [diff] [blame] | 1297 | } |
| 1298 | |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 1299 | func TestApexWithRuntimeLibsDependency(t *testing.T) { |
| 1300 | /* |
| 1301 | myapex |
| 1302 | | |
| 1303 | v (runtime_libs) |
| 1304 | mylib ------+------> libfoo [provides stub] |
| 1305 | | |
| 1306 | `------> libbar |
| 1307 | */ |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1308 | ctx := testApex(t, ` |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 1309 | apex { |
| 1310 | name: "myapex", |
| 1311 | key: "myapex.key", |
| 1312 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 1313 | updatable: false, |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 1314 | } |
| 1315 | |
| 1316 | apex_key { |
| 1317 | name: "myapex.key", |
| 1318 | public_key: "testkey.avbpubkey", |
| 1319 | private_key: "testkey.pem", |
| 1320 | } |
| 1321 | |
| 1322 | cc_library { |
| 1323 | name: "mylib", |
| 1324 | srcs: ["mylib.cpp"], |
| 1325 | runtime_libs: ["libfoo", "libbar"], |
| 1326 | system_shared_libs: [], |
| 1327 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 1328 | apex_available: [ "myapex" ], |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 1329 | } |
| 1330 | |
| 1331 | cc_library { |
| 1332 | name: "libfoo", |
| 1333 | srcs: ["mylib.cpp"], |
| 1334 | system_shared_libs: [], |
| 1335 | stl: "none", |
| 1336 | stubs: { |
| 1337 | versions: ["10", "20", "30"], |
| 1338 | }, |
| 1339 | } |
| 1340 | |
| 1341 | cc_library { |
| 1342 | name: "libbar", |
| 1343 | srcs: ["mylib.cpp"], |
| 1344 | system_shared_libs: [], |
| 1345 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 1346 | apex_available: [ "myapex" ], |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 1347 | } |
| 1348 | |
| 1349 | `) |
| 1350 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 1351 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 1352 | copyCmds := apexRule.Args["copy_commands"] |
| 1353 | |
| 1354 | // Ensure that direct non-stubs dep is always included |
| 1355 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
| 1356 | |
| 1357 | // Ensure that indirect stubs dep is not included |
| 1358 | ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so") |
| 1359 | |
| 1360 | // Ensure that runtime_libs dep in included |
| 1361 | ensureContains(t, copyCmds, "image.apex/lib64/libbar.so") |
| 1362 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 1363 | apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 1364 | ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"])) |
| 1365 | ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.so") |
Jooyung Han | d363955 | 2019-08-09 12:57:43 +0900 | [diff] [blame] | 1366 | |
| 1367 | } |
| 1368 | |
Paul Duffin | a02cae3 | 2021-03-09 01:44:06 +0000 | [diff] [blame] | 1369 | var prepareForTestOfRuntimeApexWithHwasan = android.GroupFixturePreparers( |
| 1370 | cc.PrepareForTestWithCcBuildComponents, |
| 1371 | PrepareForTestWithApexBuildComponents, |
| 1372 | android.FixtureAddTextFile("bionic/apex/Android.bp", ` |
Jooyung Han | 8ce8db9 | 2020-05-15 19:05:05 +0900 | [diff] [blame] | 1373 | apex { |
| 1374 | name: "com.android.runtime", |
| 1375 | key: "com.android.runtime.key", |
| 1376 | native_shared_libs: ["libc"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 1377 | updatable: false, |
Jooyung Han | 8ce8db9 | 2020-05-15 19:05:05 +0900 | [diff] [blame] | 1378 | } |
| 1379 | |
| 1380 | apex_key { |
| 1381 | name: "com.android.runtime.key", |
| 1382 | public_key: "testkey.avbpubkey", |
| 1383 | private_key: "testkey.pem", |
| 1384 | } |
Paul Duffin | a02cae3 | 2021-03-09 01:44:06 +0000 | [diff] [blame] | 1385 | `), |
| 1386 | android.FixtureAddFile("system/sepolicy/apex/com.android.runtime-file_contexts", nil), |
| 1387 | ) |
Jooyung Han | 8ce8db9 | 2020-05-15 19:05:05 +0900 | [diff] [blame] | 1388 | |
Paul Duffin | a02cae3 | 2021-03-09 01:44:06 +0000 | [diff] [blame] | 1389 | func TestRuntimeApexShouldInstallHwasanIfLibcDependsOnIt(t *testing.T) { |
Paul Duffin | 70d3bee | 2021-03-21 11:26:05 +0000 | [diff] [blame] | 1390 | result := android.GroupFixturePreparers(prepareForTestOfRuntimeApexWithHwasan).RunTestWithBp(t, ` |
Jooyung Han | 8ce8db9 | 2020-05-15 19:05:05 +0900 | [diff] [blame] | 1391 | cc_library { |
| 1392 | name: "libc", |
| 1393 | no_libcrt: true, |
| 1394 | nocrt: true, |
| 1395 | stl: "none", |
| 1396 | system_shared_libs: [], |
| 1397 | stubs: { versions: ["1"] }, |
| 1398 | apex_available: ["com.android.runtime"], |
| 1399 | |
| 1400 | sanitize: { |
| 1401 | hwaddress: true, |
| 1402 | } |
| 1403 | } |
| 1404 | |
| 1405 | cc_prebuilt_library_shared { |
| 1406 | name: "libclang_rt.hwasan-aarch64-android", |
| 1407 | no_libcrt: true, |
| 1408 | nocrt: true, |
| 1409 | stl: "none", |
| 1410 | system_shared_libs: [], |
| 1411 | srcs: [""], |
| 1412 | stubs: { versions: ["1"] }, |
| 1413 | |
| 1414 | sanitize: { |
| 1415 | never: true, |
| 1416 | }, |
Paul Duffin | a02cae3 | 2021-03-09 01:44:06 +0000 | [diff] [blame] | 1417 | } `) |
| 1418 | ctx := result.TestContext |
Jooyung Han | 8ce8db9 | 2020-05-15 19:05:05 +0900 | [diff] [blame] | 1419 | |
| 1420 | ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{ |
| 1421 | "lib64/bionic/libc.so", |
| 1422 | "lib64/bionic/libclang_rt.hwasan-aarch64-android.so", |
| 1423 | }) |
| 1424 | |
| 1425 | hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared") |
| 1426 | |
| 1427 | installed := hwasan.Description("install libclang_rt.hwasan") |
| 1428 | ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so") |
| 1429 | |
| 1430 | symlink := hwasan.Description("install symlink libclang_rt.hwasan") |
| 1431 | ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so") |
| 1432 | ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so") |
| 1433 | } |
| 1434 | |
| 1435 | func TestRuntimeApexShouldInstallHwasanIfHwaddressSanitized(t *testing.T) { |
Paul Duffin | 70d3bee | 2021-03-21 11:26:05 +0000 | [diff] [blame] | 1436 | result := android.GroupFixturePreparers( |
Paul Duffin | a02cae3 | 2021-03-09 01:44:06 +0000 | [diff] [blame] | 1437 | prepareForTestOfRuntimeApexWithHwasan, |
| 1438 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 1439 | variables.SanitizeDevice = []string{"hwaddress"} |
| 1440 | }), |
| 1441 | ).RunTestWithBp(t, ` |
Jooyung Han | 8ce8db9 | 2020-05-15 19:05:05 +0900 | [diff] [blame] | 1442 | cc_library { |
| 1443 | name: "libc", |
| 1444 | no_libcrt: true, |
| 1445 | nocrt: true, |
| 1446 | stl: "none", |
| 1447 | system_shared_libs: [], |
| 1448 | stubs: { versions: ["1"] }, |
| 1449 | apex_available: ["com.android.runtime"], |
| 1450 | } |
| 1451 | |
| 1452 | cc_prebuilt_library_shared { |
| 1453 | name: "libclang_rt.hwasan-aarch64-android", |
| 1454 | no_libcrt: true, |
| 1455 | nocrt: true, |
| 1456 | stl: "none", |
| 1457 | system_shared_libs: [], |
| 1458 | srcs: [""], |
| 1459 | stubs: { versions: ["1"] }, |
| 1460 | |
| 1461 | sanitize: { |
| 1462 | never: true, |
| 1463 | }, |
| 1464 | } |
Paul Duffin | a02cae3 | 2021-03-09 01:44:06 +0000 | [diff] [blame] | 1465 | `) |
| 1466 | ctx := result.TestContext |
Jooyung Han | 8ce8db9 | 2020-05-15 19:05:05 +0900 | [diff] [blame] | 1467 | |
| 1468 | ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{ |
| 1469 | "lib64/bionic/libc.so", |
| 1470 | "lib64/bionic/libclang_rt.hwasan-aarch64-android.so", |
| 1471 | }) |
| 1472 | |
| 1473 | hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared") |
| 1474 | |
| 1475 | installed := hwasan.Description("install libclang_rt.hwasan") |
| 1476 | ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so") |
| 1477 | |
| 1478 | symlink := hwasan.Description("install symlink libclang_rt.hwasan") |
| 1479 | ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so") |
| 1480 | ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so") |
| 1481 | } |
| 1482 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1483 | func TestApexDependsOnLLNDKTransitively(t *testing.T) { |
| 1484 | testcases := []struct { |
| 1485 | name string |
| 1486 | minSdkVersion string |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1487 | apexVariant string |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1488 | shouldLink string |
| 1489 | shouldNotLink []string |
| 1490 | }{ |
| 1491 | { |
Jiyong Park | 55549df | 2021-02-26 23:57:23 +0900 | [diff] [blame] | 1492 | name: "unspecified version links to the latest", |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1493 | minSdkVersion: "", |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1494 | apexVariant: "apex10000", |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1495 | shouldLink: "current", |
| 1496 | shouldNotLink: []string{"29", "30"}, |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1497 | }, |
| 1498 | { |
Jiyong Park | 55549df | 2021-02-26 23:57:23 +0900 | [diff] [blame] | 1499 | name: "always use the latest", |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1500 | minSdkVersion: "min_sdk_version: \"29\",", |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1501 | apexVariant: "apex29", |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1502 | shouldLink: "current", |
| 1503 | shouldNotLink: []string{"29", "30"}, |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1504 | }, |
| 1505 | } |
| 1506 | for _, tc := range testcases { |
| 1507 | t.Run(tc.name, func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1508 | ctx := testApex(t, ` |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1509 | apex { |
| 1510 | name: "myapex", |
| 1511 | key: "myapex.key", |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1512 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 1513 | updatable: false, |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1514 | `+tc.minSdkVersion+` |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1515 | } |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1516 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1517 | apex_key { |
| 1518 | name: "myapex.key", |
| 1519 | public_key: "testkey.avbpubkey", |
| 1520 | private_key: "testkey.pem", |
| 1521 | } |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1522 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1523 | cc_library { |
| 1524 | name: "mylib", |
| 1525 | srcs: ["mylib.cpp"], |
| 1526 | vendor_available: true, |
| 1527 | shared_libs: ["libbar"], |
| 1528 | system_shared_libs: [], |
| 1529 | stl: "none", |
| 1530 | apex_available: [ "myapex" ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1531 | min_sdk_version: "29", |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1532 | } |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1533 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1534 | cc_library { |
| 1535 | name: "libbar", |
| 1536 | srcs: ["mylib.cpp"], |
| 1537 | system_shared_libs: [], |
| 1538 | stl: "none", |
| 1539 | stubs: { versions: ["29","30"] }, |
Colin Cross | 203b421 | 2021-04-26 17:19:41 -0700 | [diff] [blame] | 1540 | llndk: { |
| 1541 | symbol_file: "libbar.map.txt", |
| 1542 | } |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1543 | } |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 1544 | `, |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 1545 | withUnbundledBuild, |
| 1546 | ) |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1547 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1548 | // Ensure that LLNDK dep is not included |
| 1549 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 1550 | "lib64/mylib.so", |
| 1551 | }) |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1552 | |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1553 | // Ensure that LLNDK dep is required |
| 1554 | apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule") |
| 1555 | ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"])) |
| 1556 | ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libbar.so") |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1557 | |
Steven Moreland | 2c4000c | 2021-04-27 02:08:49 +0000 | [diff] [blame] | 1558 | mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_"+tc.apexVariant).Rule("ld").Args["libFlags"] |
| 1559 | ensureContains(t, mylibLdFlags, "libbar/android_arm64_armv8-a_shared_"+tc.shouldLink+"/libbar.so") |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1560 | for _, ver := range tc.shouldNotLink { |
Steven Moreland | 2c4000c | 2021-04-27 02:08:49 +0000 | [diff] [blame] | 1561 | ensureNotContains(t, mylibLdFlags, "libbar/android_arm64_armv8-a_shared_"+ver+"/libbar.so") |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1562 | } |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1563 | |
Steven Moreland | 2c4000c | 2021-04-27 02:08:49 +0000 | [diff] [blame] | 1564 | mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_"+tc.apexVariant).Rule("cc").Args["cFlags"] |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1565 | ver := tc.shouldLink |
| 1566 | if tc.shouldLink == "current" { |
| 1567 | ver = strconv.Itoa(android.FutureApiLevelInt) |
| 1568 | } |
| 1569 | ensureContains(t, mylibCFlags, "__LIBBAR_API__="+ver) |
Jooyung Han | 61b66e9 | 2020-03-21 14:21:46 +0000 | [diff] [blame] | 1570 | }) |
| 1571 | } |
Jooyung Han | 9c80bae | 2019-08-20 17:30:57 +0900 | [diff] [blame] | 1572 | } |
| 1573 | |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1574 | func TestApexWithSystemLibsStubs(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1575 | ctx := testApex(t, ` |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1576 | apex { |
| 1577 | name: "myapex", |
| 1578 | key: "myapex.key", |
| 1579 | native_shared_libs: ["mylib", "mylib_shared", "libdl", "libm"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 1580 | updatable: false, |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1581 | } |
| 1582 | |
| 1583 | apex_key { |
| 1584 | name: "myapex.key", |
| 1585 | public_key: "testkey.avbpubkey", |
| 1586 | private_key: "testkey.pem", |
| 1587 | } |
| 1588 | |
| 1589 | cc_library { |
| 1590 | name: "mylib", |
| 1591 | srcs: ["mylib.cpp"], |
Colin Cross | 0de8a1e | 2020-09-18 14:15:30 -0700 | [diff] [blame] | 1592 | system_shared_libs: ["libc", "libm"], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1593 | shared_libs: ["libdl#27"], |
| 1594 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 1595 | apex_available: [ "myapex" ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1596 | } |
| 1597 | |
| 1598 | cc_library_shared { |
| 1599 | name: "mylib_shared", |
| 1600 | srcs: ["mylib.cpp"], |
| 1601 | shared_libs: ["libdl#27"], |
| 1602 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 1603 | apex_available: [ "myapex" ], |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1604 | } |
| 1605 | |
| 1606 | cc_library { |
Jiyong Park | b078857 | 2018-12-20 22:10:17 +0900 | [diff] [blame] | 1607 | name: "libBootstrap", |
| 1608 | srcs: ["mylib.cpp"], |
| 1609 | stl: "none", |
| 1610 | bootstrap: true, |
| 1611 | } |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1612 | `) |
| 1613 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 1614 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1615 | copyCmds := apexRule.Args["copy_commands"] |
| 1616 | |
| 1617 | // Ensure that mylib, libm, libdl are included. |
Alex Light | 5098a61 | 2018-11-29 17:12:15 -0800 | [diff] [blame] | 1618 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
Jiyong Park | b078857 | 2018-12-20 22:10:17 +0900 | [diff] [blame] | 1619 | ensureContains(t, copyCmds, "image.apex/lib64/bionic/libm.so") |
| 1620 | ensureContains(t, copyCmds, "image.apex/lib64/bionic/libdl.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1621 | |
| 1622 | // Ensure that libc is not included (since it has stubs and not listed in native_shared_libs) |
Jiyong Park | b078857 | 2018-12-20 22:10:17 +0900 | [diff] [blame] | 1623 | ensureNotContains(t, copyCmds, "image.apex/lib64/bionic/libc.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1624 | |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1625 | mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"] |
| 1626 | mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"] |
| 1627 | mylibSharedCFlags := ctx.ModuleForTests("mylib_shared", "android_arm64_armv8-a_shared_apex10000").Rule("cc").Args["cFlags"] |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1628 | |
| 1629 | // For dependency to libc |
| 1630 | // Ensure that mylib is linking with the latest version of stubs |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1631 | ensureContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared_current/libc.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1632 | // ... and not linking to the non-stub (impl) variant |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 1633 | ensureNotContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared/libc.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1634 | // ... Cflags from stub is correctly exported to mylib |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1635 | ensureContains(t, mylibCFlags, "__LIBC_API__=10000") |
| 1636 | ensureContains(t, mylibSharedCFlags, "__LIBC_API__=10000") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1637 | |
| 1638 | // For dependency to libm |
| 1639 | // Ensure that mylib is linking with the non-stub (impl) variant |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1640 | ensureContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_apex10000/libm.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1641 | // ... and not linking to the stub variant |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 1642 | ensureNotContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_29/libm.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1643 | // ... and is not compiling with the stub |
| 1644 | ensureNotContains(t, mylibCFlags, "__LIBM_API__=29") |
| 1645 | ensureNotContains(t, mylibSharedCFlags, "__LIBM_API__=29") |
| 1646 | |
| 1647 | // For dependency to libdl |
| 1648 | // Ensure that mylib is linking with the specified version of stubs |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 1649 | ensureContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_27/libdl.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1650 | // ... and not linking to the other versions of stubs |
Jiyong Park | 3ff1699 | 2019-12-27 14:11:47 +0900 | [diff] [blame] | 1651 | ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_28/libdl.so") |
| 1652 | ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_29/libdl.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1653 | // ... and not linking to the non-stub (impl) variant |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1654 | ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_apex10000/libdl.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1655 | // ... Cflags from stub is correctly exported to mylib |
| 1656 | ensureContains(t, mylibCFlags, "__LIBDL_API__=27") |
| 1657 | ensureContains(t, mylibSharedCFlags, "__LIBDL_API__=27") |
Jiyong Park | b078857 | 2018-12-20 22:10:17 +0900 | [diff] [blame] | 1658 | |
| 1659 | // Ensure that libBootstrap is depending on the platform variant of bionic libs |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 1660 | libFlags := ctx.ModuleForTests("libBootstrap", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"] |
| 1661 | ensureContains(t, libFlags, "libc/android_arm64_armv8-a_shared/libc.so") |
| 1662 | ensureContains(t, libFlags, "libm/android_arm64_armv8-a_shared/libm.so") |
| 1663 | ensureContains(t, libFlags, "libdl/android_arm64_armv8-a_shared/libdl.so") |
Jiyong Park | 25fc6a9 | 2018-11-18 18:02:45 +0900 | [diff] [blame] | 1664 | } |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 1665 | |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1666 | func TestApexMinSdkVersion_NativeModulesShouldBeBuiltAgainstStubs(t *testing.T) { |
Jiyong Park | 55549df | 2021-02-26 23:57:23 +0900 | [diff] [blame] | 1667 | // there are three links between liba --> libz. |
| 1668 | // 1) myapex -> libx -> liba -> libz : this should be #30 link |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1669 | // 2) otherapex -> liby -> liba -> libz : this should be #30 link |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1670 | // 3) (platform) -> liba -> libz : this should be non-stub link |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1671 | ctx := testApex(t, ` |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1672 | apex { |
| 1673 | name: "myapex", |
| 1674 | key: "myapex.key", |
| 1675 | native_shared_libs: ["libx"], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1676 | min_sdk_version: "29", |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1677 | } |
| 1678 | |
| 1679 | apex { |
| 1680 | name: "otherapex", |
| 1681 | key: "myapex.key", |
| 1682 | native_shared_libs: ["liby"], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1683 | min_sdk_version: "30", |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1684 | } |
| 1685 | |
| 1686 | apex_key { |
| 1687 | name: "myapex.key", |
| 1688 | public_key: "testkey.avbpubkey", |
| 1689 | private_key: "testkey.pem", |
| 1690 | } |
| 1691 | |
| 1692 | cc_library { |
| 1693 | name: "libx", |
| 1694 | shared_libs: ["liba"], |
| 1695 | system_shared_libs: [], |
| 1696 | stl: "none", |
| 1697 | apex_available: [ "myapex" ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1698 | min_sdk_version: "29", |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1699 | } |
| 1700 | |
| 1701 | cc_library { |
| 1702 | name: "liby", |
| 1703 | shared_libs: ["liba"], |
| 1704 | system_shared_libs: [], |
| 1705 | stl: "none", |
| 1706 | apex_available: [ "otherapex" ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1707 | min_sdk_version: "29", |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1708 | } |
| 1709 | |
| 1710 | cc_library { |
| 1711 | name: "liba", |
| 1712 | shared_libs: ["libz"], |
| 1713 | system_shared_libs: [], |
| 1714 | stl: "none", |
| 1715 | apex_available: [ |
| 1716 | "//apex_available:anyapex", |
| 1717 | "//apex_available:platform", |
| 1718 | ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1719 | min_sdk_version: "29", |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1720 | } |
| 1721 | |
| 1722 | cc_library { |
| 1723 | name: "libz", |
| 1724 | system_shared_libs: [], |
| 1725 | stl: "none", |
| 1726 | stubs: { |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1727 | versions: ["28", "30"], |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1728 | }, |
| 1729 | } |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1730 | `) |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1731 | |
| 1732 | expectLink := func(from, from_variant, to, to_variant string) { |
| 1733 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1734 | ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1735 | } |
| 1736 | expectNoLink := func(from, from_variant, to, to_variant string) { |
| 1737 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1738 | ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1739 | } |
| 1740 | // platform liba is linked to non-stub version |
| 1741 | expectLink("liba", "shared", "libz", "shared") |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1742 | // liba in myapex is linked to current |
| 1743 | expectLink("liba", "shared_apex29", "libz", "shared_current") |
| 1744 | expectNoLink("liba", "shared_apex29", "libz", "shared_30") |
Jiyong Park | 55549df | 2021-02-26 23:57:23 +0900 | [diff] [blame] | 1745 | expectNoLink("liba", "shared_apex29", "libz", "shared_28") |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1746 | expectNoLink("liba", "shared_apex29", "libz", "shared") |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1747 | // liba in otherapex is linked to current |
| 1748 | expectLink("liba", "shared_apex30", "libz", "shared_current") |
| 1749 | expectNoLink("liba", "shared_apex30", "libz", "shared_30") |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1750 | expectNoLink("liba", "shared_apex30", "libz", "shared_28") |
| 1751 | expectNoLink("liba", "shared_apex30", "libz", "shared") |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1752 | } |
| 1753 | |
Jooyung Han | aed150d | 2020-04-02 01:41:41 +0900 | [diff] [blame] | 1754 | func TestApexMinSdkVersion_SupportsCodeNames(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1755 | ctx := testApex(t, ` |
Jooyung Han | aed150d | 2020-04-02 01:41:41 +0900 | [diff] [blame] | 1756 | apex { |
| 1757 | name: "myapex", |
| 1758 | key: "myapex.key", |
| 1759 | native_shared_libs: ["libx"], |
| 1760 | min_sdk_version: "R", |
| 1761 | } |
| 1762 | |
| 1763 | apex_key { |
| 1764 | name: "myapex.key", |
| 1765 | public_key: "testkey.avbpubkey", |
| 1766 | private_key: "testkey.pem", |
| 1767 | } |
| 1768 | |
| 1769 | cc_library { |
| 1770 | name: "libx", |
| 1771 | shared_libs: ["libz"], |
| 1772 | system_shared_libs: [], |
| 1773 | stl: "none", |
| 1774 | apex_available: [ "myapex" ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1775 | min_sdk_version: "R", |
Jooyung Han | aed150d | 2020-04-02 01:41:41 +0900 | [diff] [blame] | 1776 | } |
| 1777 | |
| 1778 | cc_library { |
| 1779 | name: "libz", |
| 1780 | system_shared_libs: [], |
| 1781 | stl: "none", |
| 1782 | stubs: { |
| 1783 | versions: ["29", "R"], |
| 1784 | }, |
| 1785 | } |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 1786 | `, |
| 1787 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 1788 | variables.Platform_version_active_codenames = []string{"R"} |
| 1789 | }), |
| 1790 | ) |
Jooyung Han | aed150d | 2020-04-02 01:41:41 +0900 | [diff] [blame] | 1791 | |
| 1792 | expectLink := func(from, from_variant, to, to_variant string) { |
| 1793 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1794 | ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1795 | } |
| 1796 | expectNoLink := func(from, from_variant, to, to_variant string) { |
| 1797 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1798 | ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1799 | } |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1800 | expectLink("libx", "shared_apex10000", "libz", "shared_current") |
| 1801 | expectNoLink("libx", "shared_apex10000", "libz", "shared_R") |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1802 | expectNoLink("libx", "shared_apex10000", "libz", "shared_29") |
| 1803 | expectNoLink("libx", "shared_apex10000", "libz", "shared") |
Jooyung Han | aed150d | 2020-04-02 01:41:41 +0900 | [diff] [blame] | 1804 | } |
| 1805 | |
Jooyung Han | 4c4da06 | 2021-06-23 10:23:16 +0900 | [diff] [blame] | 1806 | func TestApexMinSdkVersion_SupportsCodeNames_JavaLibs(t *testing.T) { |
| 1807 | testApex(t, ` |
| 1808 | apex { |
| 1809 | name: "myapex", |
| 1810 | key: "myapex.key", |
| 1811 | java_libs: ["libx"], |
| 1812 | min_sdk_version: "S", |
| 1813 | } |
| 1814 | |
| 1815 | apex_key { |
| 1816 | name: "myapex.key", |
| 1817 | public_key: "testkey.avbpubkey", |
| 1818 | private_key: "testkey.pem", |
| 1819 | } |
| 1820 | |
| 1821 | java_library { |
| 1822 | name: "libx", |
| 1823 | srcs: ["a.java"], |
| 1824 | apex_available: [ "myapex" ], |
| 1825 | sdk_version: "current", |
| 1826 | min_sdk_version: "S", // should be okay |
| 1827 | } |
| 1828 | `, |
| 1829 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 1830 | variables.Platform_version_active_codenames = []string{"S"} |
| 1831 | variables.Platform_sdk_codename = proptools.StringPtr("S") |
| 1832 | }), |
| 1833 | ) |
| 1834 | } |
| 1835 | |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1836 | func TestApexMinSdkVersion_DefaultsToLatest(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1837 | ctx := testApex(t, ` |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1838 | apex { |
| 1839 | name: "myapex", |
| 1840 | key: "myapex.key", |
| 1841 | native_shared_libs: ["libx"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 1842 | updatable: false, |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1843 | } |
| 1844 | |
| 1845 | apex_key { |
| 1846 | name: "myapex.key", |
| 1847 | public_key: "testkey.avbpubkey", |
| 1848 | private_key: "testkey.pem", |
| 1849 | } |
| 1850 | |
| 1851 | cc_library { |
| 1852 | name: "libx", |
| 1853 | shared_libs: ["libz"], |
| 1854 | system_shared_libs: [], |
| 1855 | stl: "none", |
| 1856 | apex_available: [ "myapex" ], |
| 1857 | } |
| 1858 | |
| 1859 | cc_library { |
| 1860 | name: "libz", |
| 1861 | system_shared_libs: [], |
| 1862 | stl: "none", |
| 1863 | stubs: { |
| 1864 | versions: ["1", "2"], |
| 1865 | }, |
| 1866 | } |
| 1867 | `) |
| 1868 | |
| 1869 | expectLink := func(from, from_variant, to, to_variant string) { |
| 1870 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1871 | ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1872 | } |
| 1873 | expectNoLink := func(from, from_variant, to, to_variant string) { |
| 1874 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1875 | ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1876 | } |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1877 | expectLink("libx", "shared_apex10000", "libz", "shared_current") |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1878 | expectNoLink("libx", "shared_apex10000", "libz", "shared_1") |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1879 | expectNoLink("libx", "shared_apex10000", "libz", "shared_2") |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 1880 | expectNoLink("libx", "shared_apex10000", "libz", "shared") |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1881 | } |
| 1882 | |
Jiyong Park | 5df7bd3 | 2021-08-25 16:18:46 +0900 | [diff] [blame] | 1883 | func TestApexMinSdkVersion_crtobjectInVendorApex(t *testing.T) { |
| 1884 | ctx := testApex(t, ` |
| 1885 | apex { |
| 1886 | name: "myapex", |
| 1887 | key: "myapex.key", |
| 1888 | native_shared_libs: ["mylib"], |
| 1889 | updatable: false, |
| 1890 | vendor: true, |
| 1891 | min_sdk_version: "29", |
| 1892 | } |
| 1893 | |
| 1894 | apex_key { |
| 1895 | name: "myapex.key", |
| 1896 | public_key: "testkey.avbpubkey", |
| 1897 | private_key: "testkey.pem", |
| 1898 | } |
| 1899 | |
| 1900 | cc_library { |
| 1901 | name: "mylib", |
| 1902 | vendor_available: true, |
| 1903 | system_shared_libs: [], |
| 1904 | stl: "none", |
| 1905 | apex_available: [ "myapex" ], |
| 1906 | min_sdk_version: "29", |
| 1907 | } |
| 1908 | `) |
| 1909 | |
| 1910 | vendorVariant := "android_vendor.29_arm64_armv8-a" |
| 1911 | |
| 1912 | // First check that the correct variant of crtbegin_so is used. |
| 1913 | ldRule := ctx.ModuleForTests("mylib", vendorVariant+"_shared_apex29").Rule("ld") |
| 1914 | crtBegin := names(ldRule.Args["crtBegin"]) |
| 1915 | ensureListContains(t, crtBegin, "out/soong/.intermediates/"+cc.DefaultCcCommonTestModulesDir+"crtbegin_so/"+vendorVariant+"_apex29/crtbegin_so.o") |
| 1916 | |
| 1917 | // Ensure that the crtbegin_so used by the APEX is targeting 29 |
| 1918 | cflags := ctx.ModuleForTests("crtbegin_so", vendorVariant+"_apex29").Rule("cc").Args["cFlags"] |
| 1919 | android.AssertStringDoesContain(t, "cflags", cflags, "-target aarch64-linux-android29") |
| 1920 | } |
| 1921 | |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1922 | func TestPlatformUsesLatestStubsFromApexes(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1923 | ctx := testApex(t, ` |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1924 | apex { |
| 1925 | name: "myapex", |
| 1926 | key: "myapex.key", |
| 1927 | native_shared_libs: ["libx"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 1928 | updatable: false, |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1929 | } |
| 1930 | |
| 1931 | apex_key { |
| 1932 | name: "myapex.key", |
| 1933 | public_key: "testkey.avbpubkey", |
| 1934 | private_key: "testkey.pem", |
| 1935 | } |
| 1936 | |
| 1937 | cc_library { |
| 1938 | name: "libx", |
| 1939 | system_shared_libs: [], |
| 1940 | stl: "none", |
| 1941 | apex_available: [ "myapex" ], |
| 1942 | stubs: { |
| 1943 | versions: ["1", "2"], |
| 1944 | }, |
| 1945 | } |
| 1946 | |
| 1947 | cc_library { |
| 1948 | name: "libz", |
| 1949 | shared_libs: ["libx"], |
| 1950 | system_shared_libs: [], |
| 1951 | stl: "none", |
| 1952 | } |
| 1953 | `) |
| 1954 | |
| 1955 | expectLink := func(from, from_variant, to, to_variant string) { |
Colin Cross | 56a8321 | 2020-09-15 18:30:11 -0700 | [diff] [blame] | 1956 | t.Helper() |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1957 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1958 | ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1959 | } |
| 1960 | expectNoLink := func(from, from_variant, to, to_variant string) { |
Colin Cross | 56a8321 | 2020-09-15 18:30:11 -0700 | [diff] [blame] | 1961 | t.Helper() |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1962 | ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"] |
| 1963 | ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 1964 | } |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 1965 | expectLink("libz", "shared", "libx", "shared_current") |
| 1966 | expectNoLink("libz", "shared", "libx", "shared_2") |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1967 | expectNoLink("libz", "shared", "libz", "shared_1") |
| 1968 | expectNoLink("libz", "shared", "libz", "shared") |
| 1969 | } |
| 1970 | |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 1971 | var prepareForTestWithSantitizeHwaddress = android.FixtureModifyProductVariables( |
| 1972 | func(variables android.FixtureProductVariables) { |
| 1973 | variables.SanitizeDevice = []string{"hwaddress"} |
| 1974 | }, |
| 1975 | ) |
| 1976 | |
Jooyung Han | 7556839 | 2020-03-20 04:29:24 +0900 | [diff] [blame] | 1977 | func TestQApexesUseLatestStubsInBundledBuildsAndHWASAN(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 1978 | ctx := testApex(t, ` |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1979 | apex { |
| 1980 | name: "myapex", |
| 1981 | key: "myapex.key", |
| 1982 | native_shared_libs: ["libx"], |
| 1983 | min_sdk_version: "29", |
| 1984 | } |
| 1985 | |
| 1986 | apex_key { |
| 1987 | name: "myapex.key", |
| 1988 | public_key: "testkey.avbpubkey", |
| 1989 | private_key: "testkey.pem", |
| 1990 | } |
| 1991 | |
| 1992 | cc_library { |
| 1993 | name: "libx", |
| 1994 | shared_libs: ["libbar"], |
| 1995 | apex_available: [ "myapex" ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 1996 | min_sdk_version: "29", |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 1997 | } |
| 1998 | |
| 1999 | cc_library { |
| 2000 | name: "libbar", |
| 2001 | stubs: { |
| 2002 | versions: ["29", "30"], |
| 2003 | }, |
| 2004 | } |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 2005 | `, |
| 2006 | prepareForTestWithSantitizeHwaddress, |
| 2007 | ) |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 2008 | expectLink := func(from, from_variant, to, to_variant string) { |
| 2009 | ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld") |
| 2010 | libFlags := ld.Args["libFlags"] |
| 2011 | ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 2012 | } |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 2013 | expectLink("libx", "shared_hwasan_apex29", "libbar", "shared_current") |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 2014 | } |
| 2015 | |
Jooyung Han | 7556839 | 2020-03-20 04:29:24 +0900 | [diff] [blame] | 2016 | func TestQTargetApexUsesStaticUnwinder(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2017 | ctx := testApex(t, ` |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 2018 | apex { |
| 2019 | name: "myapex", |
| 2020 | key: "myapex.key", |
| 2021 | native_shared_libs: ["libx"], |
| 2022 | min_sdk_version: "29", |
| 2023 | } |
| 2024 | |
| 2025 | apex_key { |
| 2026 | name: "myapex.key", |
| 2027 | public_key: "testkey.avbpubkey", |
| 2028 | private_key: "testkey.pem", |
| 2029 | } |
| 2030 | |
| 2031 | cc_library { |
| 2032 | name: "libx", |
| 2033 | apex_available: [ "myapex" ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 2034 | min_sdk_version: "29", |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 2035 | } |
Jooyung Han | 7556839 | 2020-03-20 04:29:24 +0900 | [diff] [blame] | 2036 | `) |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 2037 | |
| 2038 | // ensure apex variant of c++ is linked with static unwinder |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 2039 | cm := ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared_apex29").Module().(*cc.Module) |
Ryan Prichard | b35a85e | 2021-01-13 19:18:53 -0800 | [diff] [blame] | 2040 | ensureListContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind") |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 2041 | // note that platform variant is not. |
| 2042 | cm = ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared").Module().(*cc.Module) |
Ryan Prichard | b35a85e | 2021-01-13 19:18:53 -0800 | [diff] [blame] | 2043 | ensureListNotContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind") |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 2044 | } |
| 2045 | |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 2046 | func TestApexMinSdkVersion_ErrorIfIncompatibleVersion(t *testing.T) { |
| 2047 | testApexError(t, `module "mylib".*: should support min_sdk_version\(29\)`, ` |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 2048 | apex { |
| 2049 | name: "myapex", |
| 2050 | key: "myapex.key", |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 2051 | native_shared_libs: ["mylib"], |
| 2052 | min_sdk_version: "29", |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 2053 | } |
| 2054 | |
| 2055 | apex_key { |
| 2056 | name: "myapex.key", |
| 2057 | public_key: "testkey.avbpubkey", |
| 2058 | private_key: "testkey.pem", |
| 2059 | } |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 2060 | |
| 2061 | cc_library { |
| 2062 | name: "mylib", |
| 2063 | srcs: ["mylib.cpp"], |
| 2064 | system_shared_libs: [], |
| 2065 | stl: "none", |
| 2066 | apex_available: [ |
| 2067 | "myapex", |
| 2068 | ], |
| 2069 | min_sdk_version: "30", |
| 2070 | } |
| 2071 | `) |
Ivan Lozano | 3e9f9e4 | 2020-12-04 15:05:43 -0500 | [diff] [blame] | 2072 | |
| 2073 | testApexError(t, `module "libfoo.ffi".*: should support min_sdk_version\(29\)`, ` |
| 2074 | apex { |
| 2075 | name: "myapex", |
| 2076 | key: "myapex.key", |
| 2077 | native_shared_libs: ["libfoo.ffi"], |
| 2078 | min_sdk_version: "29", |
| 2079 | } |
| 2080 | |
| 2081 | apex_key { |
| 2082 | name: "myapex.key", |
| 2083 | public_key: "testkey.avbpubkey", |
| 2084 | private_key: "testkey.pem", |
| 2085 | } |
| 2086 | |
| 2087 | rust_ffi_shared { |
| 2088 | name: "libfoo.ffi", |
| 2089 | srcs: ["foo.rs"], |
| 2090 | crate_name: "foo", |
| 2091 | apex_available: [ |
| 2092 | "myapex", |
| 2093 | ], |
| 2094 | min_sdk_version: "30", |
| 2095 | } |
| 2096 | `) |
Jaewoong Jung | 56e12db | 2021-04-02 00:38:25 +0000 | [diff] [blame] | 2097 | |
| 2098 | testApexError(t, `module "libfoo".*: should support min_sdk_version\(29\)`, ` |
| 2099 | apex { |
| 2100 | name: "myapex", |
| 2101 | key: "myapex.key", |
| 2102 | java_libs: ["libfoo"], |
| 2103 | min_sdk_version: "29", |
| 2104 | } |
| 2105 | |
| 2106 | apex_key { |
| 2107 | name: "myapex.key", |
| 2108 | public_key: "testkey.avbpubkey", |
| 2109 | private_key: "testkey.pem", |
| 2110 | } |
| 2111 | |
| 2112 | java_import { |
| 2113 | name: "libfoo", |
| 2114 | jars: ["libfoo.jar"], |
| 2115 | apex_available: [ |
| 2116 | "myapex", |
| 2117 | ], |
| 2118 | min_sdk_version: "30", |
| 2119 | } |
| 2120 | `) |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 2121 | } |
| 2122 | |
| 2123 | func TestApexMinSdkVersion_Okay(t *testing.T) { |
| 2124 | testApex(t, ` |
| 2125 | apex { |
| 2126 | name: "myapex", |
| 2127 | key: "myapex.key", |
| 2128 | native_shared_libs: ["libfoo"], |
| 2129 | java_libs: ["libbar"], |
| 2130 | min_sdk_version: "29", |
| 2131 | } |
| 2132 | |
| 2133 | apex_key { |
| 2134 | name: "myapex.key", |
| 2135 | public_key: "testkey.avbpubkey", |
| 2136 | private_key: "testkey.pem", |
| 2137 | } |
| 2138 | |
| 2139 | cc_library { |
| 2140 | name: "libfoo", |
| 2141 | srcs: ["mylib.cpp"], |
| 2142 | shared_libs: ["libfoo_dep"], |
| 2143 | apex_available: ["myapex"], |
| 2144 | min_sdk_version: "29", |
| 2145 | } |
| 2146 | |
| 2147 | cc_library { |
| 2148 | name: "libfoo_dep", |
| 2149 | srcs: ["mylib.cpp"], |
| 2150 | apex_available: ["myapex"], |
| 2151 | min_sdk_version: "29", |
| 2152 | } |
| 2153 | |
| 2154 | java_library { |
| 2155 | name: "libbar", |
| 2156 | sdk_version: "current", |
| 2157 | srcs: ["a.java"], |
Jaewoong Jung | 56e12db | 2021-04-02 00:38:25 +0000 | [diff] [blame] | 2158 | static_libs: [ |
| 2159 | "libbar_dep", |
| 2160 | "libbar_import_dep", |
| 2161 | ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 2162 | apex_available: ["myapex"], |
| 2163 | min_sdk_version: "29", |
| 2164 | } |
| 2165 | |
| 2166 | java_library { |
| 2167 | name: "libbar_dep", |
| 2168 | sdk_version: "current", |
| 2169 | srcs: ["a.java"], |
| 2170 | apex_available: ["myapex"], |
| 2171 | min_sdk_version: "29", |
| 2172 | } |
Jaewoong Jung | 56e12db | 2021-04-02 00:38:25 +0000 | [diff] [blame] | 2173 | |
| 2174 | java_import { |
| 2175 | name: "libbar_import_dep", |
| 2176 | jars: ["libbar.jar"], |
| 2177 | apex_available: ["myapex"], |
| 2178 | min_sdk_version: "29", |
| 2179 | } |
Jooyung Han | 03b5185 | 2020-02-26 22:45:42 +0900 | [diff] [blame] | 2180 | `) |
| 2181 | } |
| 2182 | |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 2183 | func TestJavaStableSdkVersion(t *testing.T) { |
| 2184 | testCases := []struct { |
| 2185 | name string |
| 2186 | expectedError string |
| 2187 | bp string |
Paul Duffin | 1ea7c9f | 2021-03-15 09:39:13 +0000 | [diff] [blame] | 2188 | preparer android.FixturePreparer |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 2189 | }{ |
| 2190 | { |
| 2191 | name: "Non-updatable apex with non-stable dep", |
| 2192 | bp: ` |
| 2193 | apex { |
| 2194 | name: "myapex", |
| 2195 | java_libs: ["myjar"], |
| 2196 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2197 | updatable: false, |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 2198 | } |
| 2199 | apex_key { |
| 2200 | name: "myapex.key", |
| 2201 | public_key: "testkey.avbpubkey", |
| 2202 | private_key: "testkey.pem", |
| 2203 | } |
| 2204 | java_library { |
| 2205 | name: "myjar", |
| 2206 | srcs: ["foo/bar/MyClass.java"], |
Paul Duffin | 043f5e7 | 2021-03-05 00:00:01 +0000 | [diff] [blame] | 2207 | sdk_version: "test_current", |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 2208 | apex_available: ["myapex"], |
| 2209 | } |
| 2210 | `, |
| 2211 | }, |
| 2212 | { |
| 2213 | name: "Updatable apex with stable dep", |
| 2214 | bp: ` |
| 2215 | apex { |
| 2216 | name: "myapex", |
| 2217 | java_libs: ["myjar"], |
| 2218 | key: "myapex.key", |
| 2219 | updatable: true, |
| 2220 | min_sdk_version: "29", |
| 2221 | } |
| 2222 | apex_key { |
| 2223 | name: "myapex.key", |
| 2224 | public_key: "testkey.avbpubkey", |
| 2225 | private_key: "testkey.pem", |
| 2226 | } |
| 2227 | java_library { |
| 2228 | name: "myjar", |
| 2229 | srcs: ["foo/bar/MyClass.java"], |
| 2230 | sdk_version: "current", |
| 2231 | apex_available: ["myapex"], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 2232 | min_sdk_version: "29", |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 2233 | } |
| 2234 | `, |
| 2235 | }, |
| 2236 | { |
| 2237 | name: "Updatable apex with non-stable dep", |
| 2238 | expectedError: "cannot depend on \"myjar\"", |
| 2239 | bp: ` |
| 2240 | apex { |
| 2241 | name: "myapex", |
| 2242 | java_libs: ["myjar"], |
| 2243 | key: "myapex.key", |
| 2244 | updatable: true, |
| 2245 | } |
| 2246 | apex_key { |
| 2247 | name: "myapex.key", |
| 2248 | public_key: "testkey.avbpubkey", |
| 2249 | private_key: "testkey.pem", |
| 2250 | } |
| 2251 | java_library { |
| 2252 | name: "myjar", |
| 2253 | srcs: ["foo/bar/MyClass.java"], |
Paul Duffin | 043f5e7 | 2021-03-05 00:00:01 +0000 | [diff] [blame] | 2254 | sdk_version: "test_current", |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 2255 | apex_available: ["myapex"], |
| 2256 | } |
| 2257 | `, |
| 2258 | }, |
| 2259 | { |
Paul Duffin | 1ea7c9f | 2021-03-15 09:39:13 +0000 | [diff] [blame] | 2260 | name: "Updatable apex with non-stable legacy core platform dep", |
| 2261 | expectedError: `\Qcannot depend on "myjar-uses-legacy": non stable SDK core_platform_current - uses legacy core platform\E`, |
| 2262 | bp: ` |
| 2263 | apex { |
| 2264 | name: "myapex", |
| 2265 | java_libs: ["myjar-uses-legacy"], |
| 2266 | key: "myapex.key", |
| 2267 | updatable: true, |
| 2268 | } |
| 2269 | apex_key { |
| 2270 | name: "myapex.key", |
| 2271 | public_key: "testkey.avbpubkey", |
| 2272 | private_key: "testkey.pem", |
| 2273 | } |
| 2274 | java_library { |
| 2275 | name: "myjar-uses-legacy", |
| 2276 | srcs: ["foo/bar/MyClass.java"], |
| 2277 | sdk_version: "core_platform", |
| 2278 | apex_available: ["myapex"], |
| 2279 | } |
| 2280 | `, |
| 2281 | preparer: java.FixtureUseLegacyCorePlatformApi("myjar-uses-legacy"), |
| 2282 | }, |
| 2283 | { |
Paul Duffin | 043f5e7 | 2021-03-05 00:00:01 +0000 | [diff] [blame] | 2284 | name: "Updatable apex with non-stable transitive dep", |
| 2285 | // This is not actually detecting that the transitive dependency is unstable, rather it is |
| 2286 | // detecting that the transitive dependency is building against a wider API surface than the |
| 2287 | // module that depends on it is using. |
Jiyong Park | 670e0f6 | 2021-02-18 13:10:18 +0900 | [diff] [blame] | 2288 | expectedError: "compiles against Android API, but dependency \"transitive-jar\" is compiling against private API.", |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 2289 | bp: ` |
| 2290 | apex { |
| 2291 | name: "myapex", |
| 2292 | java_libs: ["myjar"], |
| 2293 | key: "myapex.key", |
| 2294 | updatable: true, |
| 2295 | } |
| 2296 | apex_key { |
| 2297 | name: "myapex.key", |
| 2298 | public_key: "testkey.avbpubkey", |
| 2299 | private_key: "testkey.pem", |
| 2300 | } |
| 2301 | java_library { |
| 2302 | name: "myjar", |
| 2303 | srcs: ["foo/bar/MyClass.java"], |
| 2304 | sdk_version: "current", |
| 2305 | apex_available: ["myapex"], |
| 2306 | static_libs: ["transitive-jar"], |
| 2307 | } |
| 2308 | java_library { |
| 2309 | name: "transitive-jar", |
| 2310 | srcs: ["foo/bar/MyClass.java"], |
| 2311 | sdk_version: "core_platform", |
| 2312 | apex_available: ["myapex"], |
| 2313 | } |
| 2314 | `, |
| 2315 | }, |
| 2316 | } |
| 2317 | |
| 2318 | for _, test := range testCases { |
Paul Duffin | 1ea7c9f | 2021-03-15 09:39:13 +0000 | [diff] [blame] | 2319 | if test.name != "Updatable apex with non-stable legacy core platform dep" { |
| 2320 | continue |
| 2321 | } |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 2322 | t.Run(test.name, func(t *testing.T) { |
Paul Duffin | 1ea7c9f | 2021-03-15 09:39:13 +0000 | [diff] [blame] | 2323 | errorHandler := android.FixtureExpectsNoErrors |
| 2324 | if test.expectedError != "" { |
| 2325 | errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(test.expectedError) |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 2326 | } |
Paul Duffin | 1ea7c9f | 2021-03-15 09:39:13 +0000 | [diff] [blame] | 2327 | android.GroupFixturePreparers( |
| 2328 | java.PrepareForTestWithJavaDefaultModules, |
| 2329 | PrepareForTestWithApexBuildComponents, |
| 2330 | prepareForTestWithMyapex, |
| 2331 | android.OptionalFixturePreparer(test.preparer), |
| 2332 | ). |
| 2333 | ExtendWithErrorHandler(errorHandler). |
| 2334 | RunTestWithBp(t, test.bp) |
Artur Satayev | 8cf899a | 2020-04-15 17:29:42 +0100 | [diff] [blame] | 2335 | }) |
| 2336 | } |
| 2337 | } |
| 2338 | |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 2339 | func TestApexMinSdkVersion_ErrorIfDepIsNewer(t *testing.T) { |
| 2340 | testApexError(t, `module "mylib2".*: should support min_sdk_version\(29\) for "myapex"`, ` |
| 2341 | apex { |
| 2342 | name: "myapex", |
| 2343 | key: "myapex.key", |
| 2344 | native_shared_libs: ["mylib"], |
| 2345 | min_sdk_version: "29", |
| 2346 | } |
| 2347 | |
| 2348 | apex_key { |
| 2349 | name: "myapex.key", |
| 2350 | public_key: "testkey.avbpubkey", |
| 2351 | private_key: "testkey.pem", |
| 2352 | } |
| 2353 | |
| 2354 | cc_library { |
| 2355 | name: "mylib", |
| 2356 | srcs: ["mylib.cpp"], |
| 2357 | shared_libs: ["mylib2"], |
| 2358 | system_shared_libs: [], |
| 2359 | stl: "none", |
| 2360 | apex_available: [ |
| 2361 | "myapex", |
| 2362 | ], |
| 2363 | min_sdk_version: "29", |
| 2364 | } |
| 2365 | |
| 2366 | // indirect part of the apex |
| 2367 | cc_library { |
| 2368 | name: "mylib2", |
| 2369 | srcs: ["mylib.cpp"], |
| 2370 | system_shared_libs: [], |
| 2371 | stl: "none", |
| 2372 | apex_available: [ |
| 2373 | "myapex", |
| 2374 | ], |
| 2375 | min_sdk_version: "30", |
| 2376 | } |
| 2377 | `) |
| 2378 | } |
| 2379 | |
| 2380 | func TestApexMinSdkVersion_ErrorIfDepIsNewer_Java(t *testing.T) { |
| 2381 | testApexError(t, `module "bar".*: should support min_sdk_version\(29\) for "myapex"`, ` |
| 2382 | apex { |
| 2383 | name: "myapex", |
| 2384 | key: "myapex.key", |
| 2385 | apps: ["AppFoo"], |
| 2386 | min_sdk_version: "29", |
| 2387 | } |
| 2388 | |
| 2389 | apex_key { |
| 2390 | name: "myapex.key", |
| 2391 | public_key: "testkey.avbpubkey", |
| 2392 | private_key: "testkey.pem", |
| 2393 | } |
| 2394 | |
| 2395 | android_app { |
| 2396 | name: "AppFoo", |
| 2397 | srcs: ["foo/bar/MyClass.java"], |
| 2398 | sdk_version: "current", |
| 2399 | min_sdk_version: "29", |
| 2400 | system_modules: "none", |
| 2401 | stl: "none", |
| 2402 | static_libs: ["bar"], |
| 2403 | apex_available: [ "myapex" ], |
| 2404 | } |
| 2405 | |
| 2406 | java_library { |
| 2407 | name: "bar", |
| 2408 | sdk_version: "current", |
| 2409 | srcs: ["a.java"], |
| 2410 | apex_available: [ "myapex" ], |
| 2411 | } |
| 2412 | `) |
| 2413 | } |
| 2414 | |
| 2415 | func TestApexMinSdkVersion_OkayEvenWhenDepIsNewer_IfItSatisfiesApexMinSdkVersion(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2416 | ctx := testApex(t, ` |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 2417 | apex { |
| 2418 | name: "myapex", |
| 2419 | key: "myapex.key", |
| 2420 | native_shared_libs: ["mylib"], |
| 2421 | min_sdk_version: "29", |
| 2422 | } |
| 2423 | |
| 2424 | apex_key { |
| 2425 | name: "myapex.key", |
| 2426 | public_key: "testkey.avbpubkey", |
| 2427 | private_key: "testkey.pem", |
| 2428 | } |
| 2429 | |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 2430 | // mylib in myapex will link to mylib2#current |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 2431 | // mylib in otherapex will link to mylib2(non-stub) in otherapex as well |
| 2432 | cc_library { |
| 2433 | name: "mylib", |
| 2434 | srcs: ["mylib.cpp"], |
| 2435 | shared_libs: ["mylib2"], |
| 2436 | system_shared_libs: [], |
| 2437 | stl: "none", |
| 2438 | apex_available: ["myapex", "otherapex"], |
| 2439 | min_sdk_version: "29", |
| 2440 | } |
| 2441 | |
| 2442 | cc_library { |
| 2443 | name: "mylib2", |
| 2444 | srcs: ["mylib.cpp"], |
| 2445 | system_shared_libs: [], |
| 2446 | stl: "none", |
| 2447 | apex_available: ["otherapex"], |
| 2448 | stubs: { versions: ["29", "30"] }, |
| 2449 | min_sdk_version: "30", |
| 2450 | } |
| 2451 | |
| 2452 | apex { |
| 2453 | name: "otherapex", |
| 2454 | key: "myapex.key", |
| 2455 | native_shared_libs: ["mylib", "mylib2"], |
| 2456 | min_sdk_version: "30", |
| 2457 | } |
| 2458 | `) |
| 2459 | expectLink := func(from, from_variant, to, to_variant string) { |
| 2460 | ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld") |
| 2461 | libFlags := ld.Args["libFlags"] |
| 2462 | ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so") |
| 2463 | } |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 2464 | expectLink("mylib", "shared_apex29", "mylib2", "shared_current") |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 2465 | expectLink("mylib", "shared_apex30", "mylib2", "shared_apex30") |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 2466 | } |
| 2467 | |
Jooyung Han | ed124c3 | 2021-01-26 11:43:46 +0900 | [diff] [blame] | 2468 | func TestApexMinSdkVersion_WorksWithSdkCodename(t *testing.T) { |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 2469 | withSAsActiveCodeNames := android.FixtureModifyProductVariables( |
| 2470 | func(variables android.FixtureProductVariables) { |
| 2471 | variables.Platform_sdk_codename = proptools.StringPtr("S") |
| 2472 | variables.Platform_version_active_codenames = []string{"S"} |
| 2473 | }, |
| 2474 | ) |
Jooyung Han | ed124c3 | 2021-01-26 11:43:46 +0900 | [diff] [blame] | 2475 | testApexError(t, `libbar.*: should support min_sdk_version\(S\)`, ` |
| 2476 | apex { |
| 2477 | name: "myapex", |
| 2478 | key: "myapex.key", |
| 2479 | native_shared_libs: ["libfoo"], |
| 2480 | min_sdk_version: "S", |
| 2481 | } |
| 2482 | apex_key { |
| 2483 | name: "myapex.key", |
| 2484 | public_key: "testkey.avbpubkey", |
| 2485 | private_key: "testkey.pem", |
| 2486 | } |
| 2487 | cc_library { |
| 2488 | name: "libfoo", |
| 2489 | shared_libs: ["libbar"], |
| 2490 | apex_available: ["myapex"], |
| 2491 | min_sdk_version: "29", |
| 2492 | } |
| 2493 | cc_library { |
| 2494 | name: "libbar", |
| 2495 | apex_available: ["myapex"], |
| 2496 | } |
| 2497 | `, withSAsActiveCodeNames) |
| 2498 | } |
| 2499 | |
| 2500 | func TestApexMinSdkVersion_WorksWithActiveCodenames(t *testing.T) { |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 2501 | withSAsActiveCodeNames := android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 2502 | variables.Platform_sdk_codename = proptools.StringPtr("S") |
| 2503 | variables.Platform_version_active_codenames = []string{"S", "T"} |
| 2504 | }) |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2505 | ctx := testApex(t, ` |
Jooyung Han | ed124c3 | 2021-01-26 11:43:46 +0900 | [diff] [blame] | 2506 | apex { |
| 2507 | name: "myapex", |
| 2508 | key: "myapex.key", |
| 2509 | native_shared_libs: ["libfoo"], |
| 2510 | min_sdk_version: "S", |
| 2511 | } |
| 2512 | apex_key { |
| 2513 | name: "myapex.key", |
| 2514 | public_key: "testkey.avbpubkey", |
| 2515 | private_key: "testkey.pem", |
| 2516 | } |
| 2517 | cc_library { |
| 2518 | name: "libfoo", |
| 2519 | shared_libs: ["libbar"], |
| 2520 | apex_available: ["myapex"], |
| 2521 | min_sdk_version: "S", |
| 2522 | } |
| 2523 | cc_library { |
| 2524 | name: "libbar", |
| 2525 | stubs: { |
| 2526 | symbol_file: "libbar.map.txt", |
| 2527 | versions: ["30", "S", "T"], |
| 2528 | }, |
| 2529 | } |
| 2530 | `, withSAsActiveCodeNames) |
| 2531 | |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 2532 | // ensure libfoo is linked with current version of libbar stub |
Jooyung Han | ed124c3 | 2021-01-26 11:43:46 +0900 | [diff] [blame] | 2533 | libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_apex10000") |
| 2534 | libFlags := libfoo.Rule("ld").Args["libFlags"] |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 2535 | ensureContains(t, libFlags, "android_arm64_armv8-a_shared_current/libbar.so") |
Jooyung Han | ed124c3 | 2021-01-26 11:43:46 +0900 | [diff] [blame] | 2536 | } |
| 2537 | |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 2538 | func TestFilesInSubDir(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2539 | ctx := testApex(t, ` |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 2540 | apex { |
| 2541 | name: "myapex", |
| 2542 | key: "myapex.key", |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 2543 | native_shared_libs: ["mylib"], |
| 2544 | binaries: ["mybin"], |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 2545 | prebuilts: ["myetc"], |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 2546 | compile_multilib: "both", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2547 | updatable: false, |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 2548 | } |
| 2549 | |
| 2550 | apex_key { |
| 2551 | name: "myapex.key", |
| 2552 | public_key: "testkey.avbpubkey", |
| 2553 | private_key: "testkey.pem", |
| 2554 | } |
| 2555 | |
| 2556 | prebuilt_etc { |
| 2557 | name: "myetc", |
| 2558 | src: "myprebuilt", |
| 2559 | sub_dir: "foo/bar", |
| 2560 | } |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 2561 | |
| 2562 | cc_library { |
| 2563 | name: "mylib", |
| 2564 | srcs: ["mylib.cpp"], |
| 2565 | relative_install_path: "foo/bar", |
| 2566 | system_shared_libs: [], |
| 2567 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2568 | apex_available: [ "myapex" ], |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 2569 | } |
| 2570 | |
| 2571 | cc_binary { |
| 2572 | name: "mybin", |
| 2573 | srcs: ["mylib.cpp"], |
| 2574 | relative_install_path: "foo/bar", |
| 2575 | system_shared_libs: [], |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 2576 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2577 | apex_available: [ "myapex" ], |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 2578 | } |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 2579 | `) |
| 2580 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 2581 | generateFsRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("generateFsConfig") |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 2582 | dirs := strings.Split(generateFsRule.Args["exec_paths"], " ") |
| 2583 | |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 2584 | // Ensure that the subdirectories are all listed |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 2585 | ensureListContains(t, dirs, "etc") |
| 2586 | ensureListContains(t, dirs, "etc/foo") |
| 2587 | ensureListContains(t, dirs, "etc/foo/bar") |
Jiyong Park | b7c24df | 2019-02-01 12:03:59 +0900 | [diff] [blame] | 2588 | ensureListContains(t, dirs, "lib64") |
| 2589 | ensureListContains(t, dirs, "lib64/foo") |
| 2590 | ensureListContains(t, dirs, "lib64/foo/bar") |
| 2591 | ensureListContains(t, dirs, "lib") |
| 2592 | ensureListContains(t, dirs, "lib/foo") |
| 2593 | ensureListContains(t, dirs, "lib/foo/bar") |
| 2594 | |
Jiyong Park | bd13e44 | 2019-03-15 18:10:35 +0900 | [diff] [blame] | 2595 | ensureListContains(t, dirs, "bin") |
| 2596 | ensureListContains(t, dirs, "bin/foo") |
| 2597 | ensureListContains(t, dirs, "bin/foo/bar") |
Jiyong Park | 7c2ee71 | 2018-12-07 00:42:25 +0900 | [diff] [blame] | 2598 | } |
Jiyong Park | da6eb59 | 2018-12-19 17:12:36 +0900 | [diff] [blame] | 2599 | |
Jooyung Han | 35155c4 | 2020-02-06 17:33:20 +0900 | [diff] [blame] | 2600 | func TestFilesInSubDirWhenNativeBridgeEnabled(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2601 | ctx := testApex(t, ` |
Jooyung Han | 35155c4 | 2020-02-06 17:33:20 +0900 | [diff] [blame] | 2602 | apex { |
| 2603 | name: "myapex", |
| 2604 | key: "myapex.key", |
| 2605 | multilib: { |
| 2606 | both: { |
| 2607 | native_shared_libs: ["mylib"], |
| 2608 | binaries: ["mybin"], |
| 2609 | }, |
| 2610 | }, |
| 2611 | compile_multilib: "both", |
| 2612 | native_bridge_supported: true, |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2613 | updatable: false, |
Jooyung Han | 35155c4 | 2020-02-06 17:33:20 +0900 | [diff] [blame] | 2614 | } |
| 2615 | |
| 2616 | apex_key { |
| 2617 | name: "myapex.key", |
| 2618 | public_key: "testkey.avbpubkey", |
| 2619 | private_key: "testkey.pem", |
| 2620 | } |
| 2621 | |
| 2622 | cc_library { |
| 2623 | name: "mylib", |
| 2624 | relative_install_path: "foo/bar", |
| 2625 | system_shared_libs: [], |
| 2626 | stl: "none", |
| 2627 | apex_available: [ "myapex" ], |
| 2628 | native_bridge_supported: true, |
| 2629 | } |
| 2630 | |
| 2631 | cc_binary { |
| 2632 | name: "mybin", |
| 2633 | relative_install_path: "foo/bar", |
| 2634 | system_shared_libs: [], |
Jooyung Han | 35155c4 | 2020-02-06 17:33:20 +0900 | [diff] [blame] | 2635 | stl: "none", |
| 2636 | apex_available: [ "myapex" ], |
| 2637 | native_bridge_supported: true, |
| 2638 | compile_multilib: "both", // default is "first" for binary |
| 2639 | multilib: { |
| 2640 | lib64: { |
| 2641 | suffix: "64", |
| 2642 | }, |
| 2643 | }, |
| 2644 | } |
| 2645 | `, withNativeBridgeEnabled) |
| 2646 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 2647 | "bin/foo/bar/mybin", |
| 2648 | "bin/foo/bar/mybin64", |
| 2649 | "bin/arm/foo/bar/mybin", |
| 2650 | "bin/arm64/foo/bar/mybin64", |
| 2651 | "lib/foo/bar/mylib.so", |
| 2652 | "lib/arm/foo/bar/mylib.so", |
| 2653 | "lib64/foo/bar/mylib.so", |
| 2654 | "lib64/arm64/foo/bar/mylib.so", |
| 2655 | }) |
| 2656 | } |
| 2657 | |
Jooyung Han | 85d6176 | 2020-06-24 23:50:26 +0900 | [diff] [blame] | 2658 | func TestVendorApex(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2659 | ctx := testApex(t, ` |
Jooyung Han | 85d6176 | 2020-06-24 23:50:26 +0900 | [diff] [blame] | 2660 | apex { |
| 2661 | name: "myapex", |
| 2662 | key: "myapex.key", |
| 2663 | binaries: ["mybin"], |
| 2664 | vendor: true, |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2665 | updatable: false, |
Jooyung Han | 85d6176 | 2020-06-24 23:50:26 +0900 | [diff] [blame] | 2666 | } |
| 2667 | apex_key { |
| 2668 | name: "myapex.key", |
| 2669 | public_key: "testkey.avbpubkey", |
| 2670 | private_key: "testkey.pem", |
| 2671 | } |
| 2672 | cc_binary { |
| 2673 | name: "mybin", |
| 2674 | vendor: true, |
| 2675 | shared_libs: ["libfoo"], |
| 2676 | } |
| 2677 | cc_library { |
| 2678 | name: "libfoo", |
| 2679 | proprietary: true, |
| 2680 | } |
| 2681 | `) |
| 2682 | |
| 2683 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 2684 | "bin/mybin", |
| 2685 | "lib64/libfoo.so", |
| 2686 | // TODO(b/159195575): Add an option to use VNDK libs from VNDK APEX |
| 2687 | "lib64/libc++.so", |
| 2688 | }) |
| 2689 | |
| 2690 | apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 2691 | data := android.AndroidMkDataForTest(t, ctx, apexBundle) |
Jooyung Han | 85d6176 | 2020-06-24 23:50:26 +0900 | [diff] [blame] | 2692 | name := apexBundle.BaseModuleName() |
| 2693 | prefix := "TARGET_" |
| 2694 | var builder strings.Builder |
| 2695 | data.Custom(&builder, name, prefix, "", data) |
Paul Duffin | 37ba344 | 2021-03-29 00:21:08 +0100 | [diff] [blame] | 2696 | androidMk := android.StringRelativeToTop(ctx.Config(), builder.String()) |
| 2697 | installPath := "out/target/product/test_device/vendor/apex" |
Lukacs T. Berki | 7690c09 | 2021-02-26 14:27:36 +0100 | [diff] [blame] | 2698 | ensureContains(t, androidMk, "LOCAL_MODULE_PATH := "+installPath) |
Jooyung Han | 6c4cc9c | 2020-07-29 16:00:54 +0900 | [diff] [blame] | 2699 | |
| 2700 | apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule") |
| 2701 | requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"]) |
| 2702 | ensureListNotContains(t, requireNativeLibs, ":vndk") |
Jooyung Han | 85d6176 | 2020-06-24 23:50:26 +0900 | [diff] [blame] | 2703 | } |
| 2704 | |
Jooyung Han | df78e21 | 2020-07-22 15:54:47 +0900 | [diff] [blame] | 2705 | func TestVendorApex_use_vndk_as_stable(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2706 | ctx := testApex(t, ` |
Jooyung Han | df78e21 | 2020-07-22 15:54:47 +0900 | [diff] [blame] | 2707 | apex { |
| 2708 | name: "myapex", |
| 2709 | key: "myapex.key", |
| 2710 | binaries: ["mybin"], |
| 2711 | vendor: true, |
| 2712 | use_vndk_as_stable: true, |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2713 | updatable: false, |
Jooyung Han | df78e21 | 2020-07-22 15:54:47 +0900 | [diff] [blame] | 2714 | } |
| 2715 | apex_key { |
| 2716 | name: "myapex.key", |
| 2717 | public_key: "testkey.avbpubkey", |
| 2718 | private_key: "testkey.pem", |
| 2719 | } |
| 2720 | cc_binary { |
| 2721 | name: "mybin", |
| 2722 | vendor: true, |
| 2723 | shared_libs: ["libvndk", "libvendor"], |
| 2724 | } |
| 2725 | cc_library { |
| 2726 | name: "libvndk", |
| 2727 | vndk: { |
| 2728 | enabled: true, |
| 2729 | }, |
| 2730 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 2731 | product_available: true, |
Jooyung Han | df78e21 | 2020-07-22 15:54:47 +0900 | [diff] [blame] | 2732 | } |
| 2733 | cc_library { |
| 2734 | name: "libvendor", |
| 2735 | vendor: true, |
| 2736 | } |
| 2737 | `) |
| 2738 | |
Jiyong Park | f58c46e | 2021-04-01 21:35:20 +0900 | [diff] [blame] | 2739 | vendorVariant := "android_vendor.29_arm64_armv8-a" |
Jooyung Han | df78e21 | 2020-07-22 15:54:47 +0900 | [diff] [blame] | 2740 | |
Paul Duffin | a71a67a | 2021-03-29 00:42:57 +0100 | [diff] [blame] | 2741 | ldRule := ctx.ModuleForTests("mybin", vendorVariant+"_apex10000").Rule("ld") |
Jooyung Han | df78e21 | 2020-07-22 15:54:47 +0900 | [diff] [blame] | 2742 | libs := names(ldRule.Args["libFlags"]) |
| 2743 | // VNDK libs(libvndk/libc++) as they are |
Paul Duffin | 37ba344 | 2021-03-29 00:21:08 +0100 | [diff] [blame] | 2744 | ensureListContains(t, libs, "out/soong/.intermediates/libvndk/"+vendorVariant+"_shared/libvndk.so") |
| 2745 | ensureListContains(t, libs, "out/soong/.intermediates/"+cc.DefaultCcCommonTestModulesDir+"libc++/"+vendorVariant+"_shared/libc++.so") |
Jooyung Han | df78e21 | 2020-07-22 15:54:47 +0900 | [diff] [blame] | 2746 | // non-stable Vendor libs as APEX variants |
Paul Duffin | 37ba344 | 2021-03-29 00:21:08 +0100 | [diff] [blame] | 2747 | ensureListContains(t, libs, "out/soong/.intermediates/libvendor/"+vendorVariant+"_shared_apex10000/libvendor.so") |
Jooyung Han | df78e21 | 2020-07-22 15:54:47 +0900 | [diff] [blame] | 2748 | |
| 2749 | // VNDK libs are not included when use_vndk_as_stable: true |
| 2750 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 2751 | "bin/mybin", |
| 2752 | "lib64/libvendor.so", |
| 2753 | }) |
Jooyung Han | 6c4cc9c | 2020-07-29 16:00:54 +0900 | [diff] [blame] | 2754 | |
| 2755 | apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule") |
| 2756 | requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"]) |
| 2757 | ensureListContains(t, requireNativeLibs, ":vndk") |
Jooyung Han | df78e21 | 2020-07-22 15:54:47 +0900 | [diff] [blame] | 2758 | } |
| 2759 | |
Justin Yun | 13decfb | 2021-03-08 19:25:55 +0900 | [diff] [blame] | 2760 | func TestProductVariant(t *testing.T) { |
| 2761 | ctx := testApex(t, ` |
| 2762 | apex { |
| 2763 | name: "myapex", |
| 2764 | key: "myapex.key", |
| 2765 | updatable: false, |
| 2766 | product_specific: true, |
| 2767 | binaries: ["foo"], |
| 2768 | } |
| 2769 | |
| 2770 | apex_key { |
| 2771 | name: "myapex.key", |
| 2772 | public_key: "testkey.avbpubkey", |
| 2773 | private_key: "testkey.pem", |
| 2774 | } |
| 2775 | |
| 2776 | cc_binary { |
| 2777 | name: "foo", |
| 2778 | product_available: true, |
| 2779 | apex_available: ["myapex"], |
| 2780 | srcs: ["foo.cpp"], |
| 2781 | } |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 2782 | `, android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 2783 | variables.ProductVndkVersion = proptools.StringPtr("current") |
| 2784 | }), |
| 2785 | ) |
Justin Yun | 13decfb | 2021-03-08 19:25:55 +0900 | [diff] [blame] | 2786 | |
| 2787 | cflags := strings.Fields( |
Jiyong Park | f58c46e | 2021-04-01 21:35:20 +0900 | [diff] [blame] | 2788 | ctx.ModuleForTests("foo", "android_product.29_arm64_armv8-a_apex10000").Rule("cc").Args["cFlags"]) |
Justin Yun | 13decfb | 2021-03-08 19:25:55 +0900 | [diff] [blame] | 2789 | ensureListContains(t, cflags, "-D__ANDROID_VNDK__") |
| 2790 | ensureListContains(t, cflags, "-D__ANDROID_APEX__") |
| 2791 | ensureListContains(t, cflags, "-D__ANDROID_PRODUCT__") |
| 2792 | ensureListNotContains(t, cflags, "-D__ANDROID_VENDOR__") |
| 2793 | } |
| 2794 | |
Jooyung Han | 8e5685d | 2020-09-21 11:02:57 +0900 | [diff] [blame] | 2795 | func TestApex_withPrebuiltFirmware(t *testing.T) { |
| 2796 | testCases := []struct { |
| 2797 | name string |
| 2798 | additionalProp string |
| 2799 | }{ |
| 2800 | {"system apex with prebuilt_firmware", ""}, |
| 2801 | {"vendor apex with prebuilt_firmware", "vendor: true,"}, |
| 2802 | } |
| 2803 | for _, tc := range testCases { |
| 2804 | t.Run(tc.name, func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2805 | ctx := testApex(t, ` |
Jooyung Han | 8e5685d | 2020-09-21 11:02:57 +0900 | [diff] [blame] | 2806 | apex { |
| 2807 | name: "myapex", |
| 2808 | key: "myapex.key", |
| 2809 | prebuilts: ["myfirmware"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2810 | updatable: false, |
Jooyung Han | 8e5685d | 2020-09-21 11:02:57 +0900 | [diff] [blame] | 2811 | `+tc.additionalProp+` |
| 2812 | } |
| 2813 | apex_key { |
| 2814 | name: "myapex.key", |
| 2815 | public_key: "testkey.avbpubkey", |
| 2816 | private_key: "testkey.pem", |
| 2817 | } |
| 2818 | prebuilt_firmware { |
| 2819 | name: "myfirmware", |
| 2820 | src: "myfirmware.bin", |
| 2821 | filename_from_src: true, |
| 2822 | `+tc.additionalProp+` |
| 2823 | } |
| 2824 | `) |
| 2825 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 2826 | "etc/firmware/myfirmware.bin", |
| 2827 | }) |
| 2828 | }) |
| 2829 | } |
Jooyung Han | 0703fd8 | 2020-08-26 22:11:53 +0900 | [diff] [blame] | 2830 | } |
| 2831 | |
Jooyung Han | efb184e | 2020-06-25 17:14:25 +0900 | [diff] [blame] | 2832 | func TestAndroidMk_VendorApexRequired(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2833 | ctx := testApex(t, ` |
Jooyung Han | efb184e | 2020-06-25 17:14:25 +0900 | [diff] [blame] | 2834 | apex { |
| 2835 | name: "myapex", |
| 2836 | key: "myapex.key", |
| 2837 | vendor: true, |
| 2838 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2839 | updatable: false, |
Jooyung Han | efb184e | 2020-06-25 17:14:25 +0900 | [diff] [blame] | 2840 | } |
| 2841 | |
| 2842 | apex_key { |
| 2843 | name: "myapex.key", |
| 2844 | public_key: "testkey.avbpubkey", |
| 2845 | private_key: "testkey.pem", |
| 2846 | } |
| 2847 | |
| 2848 | cc_library { |
| 2849 | name: "mylib", |
| 2850 | vendor_available: true, |
| 2851 | } |
| 2852 | `) |
| 2853 | |
| 2854 | apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 2855 | data := android.AndroidMkDataForTest(t, ctx, apexBundle) |
Jooyung Han | efb184e | 2020-06-25 17:14:25 +0900 | [diff] [blame] | 2856 | name := apexBundle.BaseModuleName() |
| 2857 | prefix := "TARGET_" |
| 2858 | var builder strings.Builder |
| 2859 | data.Custom(&builder, name, prefix, "", data) |
| 2860 | androidMk := builder.String() |
| 2861 | ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += libc.vendor libm.vendor libdl.vendor\n") |
| 2862 | } |
| 2863 | |
Jooyung Han | 2ed99d0 | 2020-06-24 23:26:26 +0900 | [diff] [blame] | 2864 | func TestAndroidMkWritesCommonProperties(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2865 | ctx := testApex(t, ` |
Jooyung Han | 2ed99d0 | 2020-06-24 23:26:26 +0900 | [diff] [blame] | 2866 | apex { |
| 2867 | name: "myapex", |
| 2868 | key: "myapex.key", |
| 2869 | vintf_fragments: ["fragment.xml"], |
| 2870 | init_rc: ["init.rc"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2871 | updatable: false, |
Jooyung Han | 2ed99d0 | 2020-06-24 23:26:26 +0900 | [diff] [blame] | 2872 | } |
| 2873 | apex_key { |
| 2874 | name: "myapex.key", |
| 2875 | public_key: "testkey.avbpubkey", |
| 2876 | private_key: "testkey.pem", |
| 2877 | } |
| 2878 | cc_binary { |
| 2879 | name: "mybin", |
| 2880 | } |
| 2881 | `) |
| 2882 | |
| 2883 | apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 2884 | data := android.AndroidMkDataForTest(t, ctx, apexBundle) |
Jooyung Han | 2ed99d0 | 2020-06-24 23:26:26 +0900 | [diff] [blame] | 2885 | name := apexBundle.BaseModuleName() |
| 2886 | prefix := "TARGET_" |
| 2887 | var builder strings.Builder |
| 2888 | data.Custom(&builder, name, prefix, "", data) |
| 2889 | androidMk := builder.String() |
Liz Kammer | 7b3dc8a | 2021-04-16 16:41:59 -0400 | [diff] [blame] | 2890 | ensureContains(t, androidMk, "LOCAL_FULL_VINTF_FRAGMENTS := fragment.xml\n") |
Liz Kammer | 0c4f71c | 2021-04-06 10:35:10 -0400 | [diff] [blame] | 2891 | ensureContains(t, androidMk, "LOCAL_FULL_INIT_RC := init.rc\n") |
Jooyung Han | 2ed99d0 | 2020-06-24 23:26:26 +0900 | [diff] [blame] | 2892 | } |
| 2893 | |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 2894 | func TestStaticLinking(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2895 | ctx := testApex(t, ` |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 2896 | apex { |
| 2897 | name: "myapex", |
| 2898 | key: "myapex.key", |
| 2899 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2900 | updatable: false, |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 2901 | } |
| 2902 | |
| 2903 | apex_key { |
| 2904 | name: "myapex.key", |
| 2905 | public_key: "testkey.avbpubkey", |
| 2906 | private_key: "testkey.pem", |
| 2907 | } |
| 2908 | |
| 2909 | cc_library { |
| 2910 | name: "mylib", |
| 2911 | srcs: ["mylib.cpp"], |
| 2912 | system_shared_libs: [], |
| 2913 | stl: "none", |
| 2914 | stubs: { |
| 2915 | versions: ["1", "2", "3"], |
| 2916 | }, |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2917 | apex_available: [ |
| 2918 | "//apex_available:platform", |
| 2919 | "myapex", |
| 2920 | ], |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 2921 | } |
| 2922 | |
| 2923 | cc_binary { |
| 2924 | name: "not_in_apex", |
| 2925 | srcs: ["mylib.cpp"], |
| 2926 | static_libs: ["mylib"], |
| 2927 | static_executable: true, |
| 2928 | system_shared_libs: [], |
| 2929 | stl: "none", |
| 2930 | } |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 2931 | `) |
| 2932 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 2933 | ldFlags := ctx.ModuleForTests("not_in_apex", "android_arm64_armv8-a").Rule("ld").Args["libFlags"] |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 2934 | |
| 2935 | // Ensure that not_in_apex is linking with the static variant of mylib |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 2936 | ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_static/mylib.a") |
Jiyong Park | 16e91a0 | 2018-12-20 18:18:08 +0900 | [diff] [blame] | 2937 | } |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2938 | |
| 2939 | func TestKeys(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2940 | ctx := testApex(t, ` |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2941 | apex { |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 2942 | name: "myapex_keytest", |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2943 | key: "myapex.key", |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 2944 | certificate: ":myapex.certificate", |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2945 | native_shared_libs: ["mylib"], |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 2946 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 2947 | updatable: false, |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2948 | } |
| 2949 | |
| 2950 | cc_library { |
| 2951 | name: "mylib", |
| 2952 | srcs: ["mylib.cpp"], |
| 2953 | system_shared_libs: [], |
| 2954 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 2955 | apex_available: [ "myapex_keytest" ], |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2956 | } |
| 2957 | |
| 2958 | apex_key { |
| 2959 | name: "myapex.key", |
| 2960 | public_key: "testkey.avbpubkey", |
| 2961 | private_key: "testkey.pem", |
| 2962 | } |
| 2963 | |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 2964 | android_app_certificate { |
| 2965 | name: "myapex.certificate", |
| 2966 | certificate: "testkey", |
| 2967 | } |
| 2968 | |
| 2969 | android_app_certificate { |
| 2970 | name: "myapex.certificate.override", |
| 2971 | certificate: "testkey.override", |
| 2972 | } |
| 2973 | |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2974 | `) |
| 2975 | |
| 2976 | // check the APEX keys |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 2977 | keys := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey) |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2978 | |
Jaewoong Jung | 18aefc1 | 2020-12-21 09:11:10 -0800 | [diff] [blame] | 2979 | if keys.publicKeyFile.String() != "vendor/foo/devkeys/testkey.avbpubkey" { |
| 2980 | t.Errorf("public key %q is not %q", keys.publicKeyFile.String(), |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2981 | "vendor/foo/devkeys/testkey.avbpubkey") |
| 2982 | } |
Jaewoong Jung | 18aefc1 | 2020-12-21 09:11:10 -0800 | [diff] [blame] | 2983 | if keys.privateKeyFile.String() != "vendor/foo/devkeys/testkey.pem" { |
| 2984 | t.Errorf("private key %q is not %q", keys.privateKeyFile.String(), |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2985 | "vendor/foo/devkeys/testkey.pem") |
| 2986 | } |
| 2987 | |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 2988 | // check the APK certs. It should be overridden to myapex.certificate.override |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 2989 | certs := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk").Args["certificates"] |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 2990 | if certs != "testkey.override.x509.pem testkey.override.pk8" { |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2991 | t.Errorf("cert and private key %q are not %q", certs, |
Jiyong Park | b2742fd | 2019-02-11 11:38:15 +0900 | [diff] [blame] | 2992 | "testkey.override.509.pem testkey.override.pk8") |
Jiyong Park | 9335a26 | 2018-12-24 11:31:58 +0900 | [diff] [blame] | 2993 | } |
| 2994 | } |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 2995 | |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 2996 | func TestCertificate(t *testing.T) { |
| 2997 | t.Run("if unspecified, it defaults to DefaultAppCertificate", func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 2998 | ctx := testApex(t, ` |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 2999 | apex { |
| 3000 | name: "myapex", |
| 3001 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3002 | updatable: false, |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 3003 | } |
| 3004 | apex_key { |
| 3005 | name: "myapex.key", |
| 3006 | public_key: "testkey.avbpubkey", |
| 3007 | private_key: "testkey.pem", |
| 3008 | }`) |
| 3009 | rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk") |
| 3010 | expected := "vendor/foo/devkeys/test.x509.pem vendor/foo/devkeys/test.pk8" |
| 3011 | if actual := rule.Args["certificates"]; actual != expected { |
| 3012 | t.Errorf("certificates should be %q, not %q", expected, actual) |
| 3013 | } |
| 3014 | }) |
| 3015 | t.Run("override when unspecified", func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3016 | ctx := testApex(t, ` |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 3017 | apex { |
| 3018 | name: "myapex_keytest", |
| 3019 | key: "myapex.key", |
| 3020 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3021 | updatable: false, |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 3022 | } |
| 3023 | apex_key { |
| 3024 | name: "myapex.key", |
| 3025 | public_key: "testkey.avbpubkey", |
| 3026 | private_key: "testkey.pem", |
| 3027 | } |
| 3028 | android_app_certificate { |
| 3029 | name: "myapex.certificate.override", |
| 3030 | certificate: "testkey.override", |
| 3031 | }`) |
| 3032 | rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk") |
| 3033 | expected := "testkey.override.x509.pem testkey.override.pk8" |
| 3034 | if actual := rule.Args["certificates"]; actual != expected { |
| 3035 | t.Errorf("certificates should be %q, not %q", expected, actual) |
| 3036 | } |
| 3037 | }) |
| 3038 | t.Run("if specified as :module, it respects the prop", func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3039 | ctx := testApex(t, ` |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 3040 | apex { |
| 3041 | name: "myapex", |
| 3042 | key: "myapex.key", |
| 3043 | certificate: ":myapex.certificate", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3044 | updatable: false, |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 3045 | } |
| 3046 | apex_key { |
| 3047 | name: "myapex.key", |
| 3048 | public_key: "testkey.avbpubkey", |
| 3049 | private_key: "testkey.pem", |
| 3050 | } |
| 3051 | android_app_certificate { |
| 3052 | name: "myapex.certificate", |
| 3053 | certificate: "testkey", |
| 3054 | }`) |
| 3055 | rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk") |
| 3056 | expected := "testkey.x509.pem testkey.pk8" |
| 3057 | if actual := rule.Args["certificates"]; actual != expected { |
| 3058 | t.Errorf("certificates should be %q, not %q", expected, actual) |
| 3059 | } |
| 3060 | }) |
| 3061 | t.Run("override when specifiec as <:module>", func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3062 | ctx := testApex(t, ` |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 3063 | apex { |
| 3064 | name: "myapex_keytest", |
| 3065 | key: "myapex.key", |
| 3066 | file_contexts: ":myapex-file_contexts", |
| 3067 | certificate: ":myapex.certificate", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3068 | updatable: false, |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 3069 | } |
| 3070 | apex_key { |
| 3071 | name: "myapex.key", |
| 3072 | public_key: "testkey.avbpubkey", |
| 3073 | private_key: "testkey.pem", |
| 3074 | } |
| 3075 | android_app_certificate { |
| 3076 | name: "myapex.certificate.override", |
| 3077 | certificate: "testkey.override", |
| 3078 | }`) |
| 3079 | rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk") |
| 3080 | expected := "testkey.override.x509.pem testkey.override.pk8" |
| 3081 | if actual := rule.Args["certificates"]; actual != expected { |
| 3082 | t.Errorf("certificates should be %q, not %q", expected, actual) |
| 3083 | } |
| 3084 | }) |
| 3085 | t.Run("if specified as name, finds it from DefaultDevKeyDir", func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3086 | ctx := testApex(t, ` |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 3087 | apex { |
| 3088 | name: "myapex", |
| 3089 | key: "myapex.key", |
| 3090 | certificate: "testkey", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3091 | updatable: false, |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 3092 | } |
| 3093 | apex_key { |
| 3094 | name: "myapex.key", |
| 3095 | public_key: "testkey.avbpubkey", |
| 3096 | private_key: "testkey.pem", |
| 3097 | }`) |
| 3098 | rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk") |
| 3099 | expected := "vendor/foo/devkeys/testkey.x509.pem vendor/foo/devkeys/testkey.pk8" |
| 3100 | if actual := rule.Args["certificates"]; actual != expected { |
| 3101 | t.Errorf("certificates should be %q, not %q", expected, actual) |
| 3102 | } |
| 3103 | }) |
| 3104 | t.Run("override when specified as <name>", func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3105 | ctx := testApex(t, ` |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 3106 | apex { |
| 3107 | name: "myapex_keytest", |
| 3108 | key: "myapex.key", |
| 3109 | file_contexts: ":myapex-file_contexts", |
| 3110 | certificate: "testkey", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3111 | updatable: false, |
Jooyung Han | f121a65 | 2019-12-17 14:30:11 +0900 | [diff] [blame] | 3112 | } |
| 3113 | apex_key { |
| 3114 | name: "myapex.key", |
| 3115 | public_key: "testkey.avbpubkey", |
| 3116 | private_key: "testkey.pem", |
| 3117 | } |
| 3118 | android_app_certificate { |
| 3119 | name: "myapex.certificate.override", |
| 3120 | certificate: "testkey.override", |
| 3121 | }`) |
| 3122 | rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk") |
| 3123 | expected := "testkey.override.x509.pem testkey.override.pk8" |
| 3124 | if actual := rule.Args["certificates"]; actual != expected { |
| 3125 | t.Errorf("certificates should be %q, not %q", expected, actual) |
| 3126 | } |
| 3127 | }) |
| 3128 | } |
| 3129 | |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 3130 | func TestMacro(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3131 | ctx := testApex(t, ` |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 3132 | apex { |
| 3133 | name: "myapex", |
| 3134 | key: "myapex.key", |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 3135 | native_shared_libs: ["mylib", "mylib2"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3136 | updatable: false, |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 3137 | } |
| 3138 | |
| 3139 | apex { |
| 3140 | name: "otherapex", |
| 3141 | key: "myapex.key", |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 3142 | native_shared_libs: ["mylib", "mylib2"], |
Jooyung Han | ccce2f2 | 2020-03-07 03:45:53 +0900 | [diff] [blame] | 3143 | min_sdk_version: "29", |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 3144 | } |
| 3145 | |
| 3146 | apex_key { |
| 3147 | name: "myapex.key", |
| 3148 | public_key: "testkey.avbpubkey", |
| 3149 | private_key: "testkey.pem", |
| 3150 | } |
| 3151 | |
| 3152 | cc_library { |
| 3153 | name: "mylib", |
| 3154 | srcs: ["mylib.cpp"], |
| 3155 | system_shared_libs: [], |
| 3156 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3157 | apex_available: [ |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3158 | "myapex", |
| 3159 | "otherapex", |
| 3160 | ], |
Jooyung Han | 2428277 | 2020-03-21 23:20:55 +0900 | [diff] [blame] | 3161 | recovery_available: true, |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 3162 | min_sdk_version: "29", |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 3163 | } |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 3164 | cc_library { |
| 3165 | name: "mylib2", |
| 3166 | srcs: ["mylib.cpp"], |
| 3167 | system_shared_libs: [], |
| 3168 | stl: "none", |
| 3169 | apex_available: [ |
| 3170 | "myapex", |
| 3171 | "otherapex", |
| 3172 | ], |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 3173 | static_libs: ["mylib3"], |
| 3174 | recovery_available: true, |
| 3175 | min_sdk_version: "29", |
| 3176 | } |
| 3177 | cc_library { |
| 3178 | name: "mylib3", |
| 3179 | srcs: ["mylib.cpp"], |
| 3180 | system_shared_libs: [], |
| 3181 | stl: "none", |
| 3182 | apex_available: [ |
| 3183 | "myapex", |
| 3184 | "otherapex", |
| 3185 | ], |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 3186 | recovery_available: true, |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 3187 | min_sdk_version: "29", |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 3188 | } |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 3189 | `) |
| 3190 | |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 3191 | // non-APEX variant does not have __ANDROID_APEX__ defined |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 3192 | mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
Jooyung Han | 6b8459b | 2019-10-30 08:29:25 +0900 | [diff] [blame] | 3193 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
Dan Albert | b19953d | 2020-11-17 15:29:36 -0800 | [diff] [blame] | 3194 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__") |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 3195 | |
Jooyung Han | ccce2f2 | 2020-03-07 03:45:53 +0900 | [diff] [blame] | 3196 | // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 3197 | mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"] |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 3198 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
Dan Albert | b19953d | 2020-11-17 15:29:36 -0800 | [diff] [blame] | 3199 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=10000") |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 3200 | |
Jooyung Han | ccce2f2 | 2020-03-07 03:45:53 +0900 | [diff] [blame] | 3201 | // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 3202 | mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex29").Rule("cc").Args["cFlags"] |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 3203 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
Dan Albert | b19953d | 2020-11-17 15:29:36 -0800 | [diff] [blame] | 3204 | ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=29") |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 3205 | |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 3206 | // When a cc_library sets use_apex_name_macro: true each apex gets a unique variant and |
| 3207 | // each variant defines additional macros to distinguish which apex variant it is built for |
| 3208 | |
| 3209 | // non-APEX variant does not have __ANDROID_APEX__ defined |
| 3210 | mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
| 3211 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
| 3212 | |
Dan Albert | b19953d | 2020-11-17 15:29:36 -0800 | [diff] [blame] | 3213 | // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__ |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 3214 | mylibCFlags = ctx.ModuleForTests("mylib3", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
| 3215 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
Dan Albert | b19953d | 2020-11-17 15:29:36 -0800 | [diff] [blame] | 3216 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__") |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 3217 | |
Jooyung Han | c87a059 | 2020-03-02 17:44:33 +0900 | [diff] [blame] | 3218 | // non-APEX variant does not have __ANDROID_APEX__ defined |
| 3219 | mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
| 3220 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
| 3221 | |
Dan Albert | b19953d | 2020-11-17 15:29:36 -0800 | [diff] [blame] | 3222 | // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__ |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 3223 | mylibCFlags = ctx.ModuleForTests("mylib2", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
Jooyung Han | 2428277 | 2020-03-21 23:20:55 +0900 | [diff] [blame] | 3224 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__") |
Dan Albert | b19953d | 2020-11-17 15:29:36 -0800 | [diff] [blame] | 3225 | ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__") |
Jiyong Park | 58e364a | 2019-01-19 19:24:06 +0900 | [diff] [blame] | 3226 | } |
Jiyong Park | 7e636d0 | 2019-01-28 16:16:54 +0900 | [diff] [blame] | 3227 | |
| 3228 | func TestHeaderLibsDependency(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3229 | ctx := testApex(t, ` |
Jiyong Park | 7e636d0 | 2019-01-28 16:16:54 +0900 | [diff] [blame] | 3230 | apex { |
| 3231 | name: "myapex", |
| 3232 | key: "myapex.key", |
| 3233 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3234 | updatable: false, |
Jiyong Park | 7e636d0 | 2019-01-28 16:16:54 +0900 | [diff] [blame] | 3235 | } |
| 3236 | |
| 3237 | apex_key { |
| 3238 | name: "myapex.key", |
| 3239 | public_key: "testkey.avbpubkey", |
| 3240 | private_key: "testkey.pem", |
| 3241 | } |
| 3242 | |
| 3243 | cc_library_headers { |
| 3244 | name: "mylib_headers", |
| 3245 | export_include_dirs: ["my_include"], |
| 3246 | system_shared_libs: [], |
| 3247 | stl: "none", |
Jiyong Park | 0f80c18 | 2020-01-31 02:49:53 +0900 | [diff] [blame] | 3248 | apex_available: [ "myapex" ], |
Jiyong Park | 7e636d0 | 2019-01-28 16:16:54 +0900 | [diff] [blame] | 3249 | } |
| 3250 | |
| 3251 | cc_library { |
| 3252 | name: "mylib", |
| 3253 | srcs: ["mylib.cpp"], |
| 3254 | system_shared_libs: [], |
| 3255 | stl: "none", |
| 3256 | header_libs: ["mylib_headers"], |
| 3257 | export_header_lib_headers: ["mylib_headers"], |
| 3258 | stubs: { |
| 3259 | versions: ["1", "2", "3"], |
| 3260 | }, |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3261 | apex_available: [ "myapex" ], |
Jiyong Park | 7e636d0 | 2019-01-28 16:16:54 +0900 | [diff] [blame] | 3262 | } |
| 3263 | |
| 3264 | cc_library { |
| 3265 | name: "otherlib", |
| 3266 | srcs: ["mylib.cpp"], |
| 3267 | system_shared_libs: [], |
| 3268 | stl: "none", |
| 3269 | shared_libs: ["mylib"], |
| 3270 | } |
| 3271 | `) |
| 3272 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 3273 | cFlags := ctx.ModuleForTests("otherlib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"] |
Jiyong Park | 7e636d0 | 2019-01-28 16:16:54 +0900 | [diff] [blame] | 3274 | |
| 3275 | // Ensure that the include path of the header lib is exported to 'otherlib' |
| 3276 | ensureContains(t, cFlags, "-Imy_include") |
| 3277 | } |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 3278 | |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3279 | type fileInApex struct { |
| 3280 | path string // path in apex |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3281 | src string // src path |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3282 | isLink bool |
| 3283 | } |
| 3284 | |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3285 | func getFiles(t *testing.T, ctx *android.TestContext, moduleName, variant string) []fileInApex { |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3286 | t.Helper() |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3287 | apexRule := ctx.ModuleForTests(moduleName, variant).Rule("apexRule") |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3288 | copyCmds := apexRule.Args["copy_commands"] |
| 3289 | imageApexDir := "/image.apex/" |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3290 | var ret []fileInApex |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3291 | for _, cmd := range strings.Split(copyCmds, "&&") { |
| 3292 | cmd = strings.TrimSpace(cmd) |
| 3293 | if cmd == "" { |
| 3294 | continue |
| 3295 | } |
| 3296 | terms := strings.Split(cmd, " ") |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3297 | var dst, src string |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3298 | var isLink bool |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3299 | switch terms[0] { |
| 3300 | case "mkdir": |
| 3301 | case "cp": |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3302 | if len(terms) != 3 && len(terms) != 4 { |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3303 | t.Fatal("copyCmds contains invalid cp command", cmd) |
| 3304 | } |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3305 | dst = terms[len(terms)-1] |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3306 | src = terms[len(terms)-2] |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3307 | isLink = false |
| 3308 | case "ln": |
| 3309 | if len(terms) != 3 && len(terms) != 4 { |
| 3310 | // ln LINK TARGET or ln -s LINK TARGET |
| 3311 | t.Fatal("copyCmds contains invalid ln command", cmd) |
| 3312 | } |
| 3313 | dst = terms[len(terms)-1] |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3314 | src = terms[len(terms)-2] |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3315 | isLink = true |
| 3316 | default: |
| 3317 | t.Fatalf("copyCmds should contain mkdir/cp commands only: %q", cmd) |
| 3318 | } |
| 3319 | if dst != "" { |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3320 | index := strings.Index(dst, imageApexDir) |
| 3321 | if index == -1 { |
| 3322 | t.Fatal("copyCmds should copy a file to image.apex/", cmd) |
| 3323 | } |
| 3324 | dstFile := dst[index+len(imageApexDir):] |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3325 | ret = append(ret, fileInApex{path: dstFile, src: src, isLink: isLink}) |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3326 | } |
| 3327 | } |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3328 | return ret |
| 3329 | } |
| 3330 | |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3331 | func ensureExactContents(t *testing.T, ctx *android.TestContext, moduleName, variant string, files []string) { |
| 3332 | t.Helper() |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3333 | var failed bool |
| 3334 | var surplus []string |
| 3335 | filesMatched := make(map[string]bool) |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3336 | for _, file := range getFiles(t, ctx, moduleName, variant) { |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 3337 | mactchFound := false |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3338 | for _, expected := range files { |
| 3339 | if matched, _ := path.Match(expected, file.path); matched { |
| 3340 | filesMatched[expected] = true |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 3341 | mactchFound = true |
| 3342 | break |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3343 | } |
| 3344 | } |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 3345 | if !mactchFound { |
| 3346 | surplus = append(surplus, file.path) |
| 3347 | } |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 3348 | } |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3349 | |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3350 | if len(surplus) > 0 { |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3351 | sort.Strings(surplus) |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3352 | t.Log("surplus files", surplus) |
| 3353 | failed = true |
| 3354 | } |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3355 | |
| 3356 | if len(files) > len(filesMatched) { |
| 3357 | var missing []string |
| 3358 | for _, expected := range files { |
| 3359 | if !filesMatched[expected] { |
| 3360 | missing = append(missing, expected) |
| 3361 | } |
| 3362 | } |
| 3363 | sort.Strings(missing) |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3364 | t.Log("missing files", missing) |
| 3365 | failed = true |
| 3366 | } |
| 3367 | if failed { |
| 3368 | t.Fail() |
| 3369 | } |
| 3370 | } |
| 3371 | |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3372 | func TestVndkApexCurrent(t *testing.T) { |
Jooyung Han | 7d6e79b | 2021-06-24 01:53:43 +0900 | [diff] [blame] | 3373 | commonFiles := []string{ |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 3374 | "lib/libc++.so", |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 3375 | "lib64/libc++.so", |
Jiyong Park | f58c46e | 2021-04-01 21:35:20 +0900 | [diff] [blame] | 3376 | "etc/llndk.libraries.29.txt", |
| 3377 | "etc/vndkcore.libraries.29.txt", |
| 3378 | "etc/vndksp.libraries.29.txt", |
| 3379 | "etc/vndkprivate.libraries.29.txt", |
| 3380 | "etc/vndkproduct.libraries.29.txt", |
Jooyung Han | 7d6e79b | 2021-06-24 01:53:43 +0900 | [diff] [blame] | 3381 | } |
| 3382 | testCases := []struct { |
| 3383 | vndkVersion string |
| 3384 | expectedFiles []string |
| 3385 | }{ |
| 3386 | { |
| 3387 | vndkVersion: "current", |
| 3388 | expectedFiles: append(commonFiles, |
| 3389 | "lib/libvndk.so", |
| 3390 | "lib/libvndksp.so", |
| 3391 | "lib64/libvndk.so", |
| 3392 | "lib64/libvndksp.so"), |
| 3393 | }, |
| 3394 | { |
| 3395 | vndkVersion: "", |
| 3396 | expectedFiles: append(commonFiles, |
| 3397 | // Legacy VNDK APEX contains only VNDK-SP files (of core variant) |
| 3398 | "lib/libvndksp.so", |
| 3399 | "lib64/libvndksp.so"), |
| 3400 | }, |
| 3401 | } |
| 3402 | for _, tc := range testCases { |
| 3403 | t.Run("VNDK.current with DeviceVndkVersion="+tc.vndkVersion, func(t *testing.T) { |
| 3404 | ctx := testApex(t, ` |
| 3405 | apex_vndk { |
| 3406 | name: "com.android.vndk.current", |
| 3407 | key: "com.android.vndk.current.key", |
| 3408 | updatable: false, |
| 3409 | } |
| 3410 | |
| 3411 | apex_key { |
| 3412 | name: "com.android.vndk.current.key", |
| 3413 | public_key: "testkey.avbpubkey", |
| 3414 | private_key: "testkey.pem", |
| 3415 | } |
| 3416 | |
| 3417 | cc_library { |
| 3418 | name: "libvndk", |
| 3419 | srcs: ["mylib.cpp"], |
| 3420 | vendor_available: true, |
| 3421 | product_available: true, |
| 3422 | vndk: { |
| 3423 | enabled: true, |
| 3424 | }, |
| 3425 | system_shared_libs: [], |
| 3426 | stl: "none", |
| 3427 | apex_available: [ "com.android.vndk.current" ], |
| 3428 | } |
| 3429 | |
| 3430 | cc_library { |
| 3431 | name: "libvndksp", |
| 3432 | srcs: ["mylib.cpp"], |
| 3433 | vendor_available: true, |
| 3434 | product_available: true, |
| 3435 | vndk: { |
| 3436 | enabled: true, |
| 3437 | support_system_process: true, |
| 3438 | }, |
| 3439 | system_shared_libs: [], |
| 3440 | stl: "none", |
| 3441 | apex_available: [ "com.android.vndk.current" ], |
| 3442 | } |
| 3443 | |
| 3444 | // VNDK-Ext should not cause any problems |
| 3445 | |
| 3446 | cc_library { |
| 3447 | name: "libvndk.ext", |
| 3448 | srcs: ["mylib2.cpp"], |
| 3449 | vendor: true, |
| 3450 | vndk: { |
| 3451 | enabled: true, |
| 3452 | extends: "libvndk", |
| 3453 | }, |
| 3454 | system_shared_libs: [], |
| 3455 | stl: "none", |
| 3456 | } |
| 3457 | |
| 3458 | cc_library { |
| 3459 | name: "libvndksp.ext", |
| 3460 | srcs: ["mylib2.cpp"], |
| 3461 | vendor: true, |
| 3462 | vndk: { |
| 3463 | enabled: true, |
| 3464 | support_system_process: true, |
| 3465 | extends: "libvndksp", |
| 3466 | }, |
| 3467 | system_shared_libs: [], |
| 3468 | stl: "none", |
| 3469 | } |
| 3470 | `+vndkLibrariesTxtFiles("current"), android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 3471 | variables.DeviceVndkVersion = proptools.StringPtr(tc.vndkVersion) |
| 3472 | })) |
| 3473 | ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", tc.expectedFiles) |
| 3474 | }) |
| 3475 | } |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3476 | } |
| 3477 | |
| 3478 | func TestVndkApexWithPrebuilt(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3479 | ctx := testApex(t, ` |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3480 | apex_vndk { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3481 | name: "com.android.vndk.current", |
| 3482 | key: "com.android.vndk.current.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3483 | updatable: false, |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3484 | } |
| 3485 | |
| 3486 | apex_key { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3487 | name: "com.android.vndk.current.key", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3488 | public_key: "testkey.avbpubkey", |
| 3489 | private_key: "testkey.pem", |
| 3490 | } |
| 3491 | |
| 3492 | cc_prebuilt_library_shared { |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3493 | name: "libvndk", |
| 3494 | srcs: ["libvndk.so"], |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3495 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 3496 | product_available: true, |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3497 | vndk: { |
| 3498 | enabled: true, |
| 3499 | }, |
| 3500 | system_shared_libs: [], |
| 3501 | stl: "none", |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3502 | apex_available: [ "com.android.vndk.current" ], |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3503 | } |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3504 | |
| 3505 | cc_prebuilt_library_shared { |
| 3506 | name: "libvndk.arm", |
| 3507 | srcs: ["libvndk.arm.so"], |
| 3508 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 3509 | product_available: true, |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3510 | vndk: { |
| 3511 | enabled: true, |
| 3512 | }, |
| 3513 | enabled: false, |
| 3514 | arch: { |
| 3515 | arm: { |
| 3516 | enabled: true, |
| 3517 | }, |
| 3518 | }, |
| 3519 | system_shared_libs: [], |
| 3520 | stl: "none", |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3521 | apex_available: [ "com.android.vndk.current" ], |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3522 | } |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3523 | `+vndkLibrariesTxtFiles("current"), |
| 3524 | withFiles(map[string][]byte{ |
| 3525 | "libvndk.so": nil, |
| 3526 | "libvndk.arm.so": nil, |
| 3527 | })) |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3528 | ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{ |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3529 | "lib/libvndk.so", |
| 3530 | "lib/libvndk.arm.so", |
| 3531 | "lib64/libvndk.so", |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 3532 | "lib/libc++.so", |
| 3533 | "lib64/libc++.so", |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3534 | "etc/*", |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3535 | }) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3536 | } |
| 3537 | |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3538 | func vndkLibrariesTxtFiles(vers ...string) (result string) { |
| 3539 | for _, v := range vers { |
| 3540 | if v == "current" { |
Justin Yun | 8a2600c | 2020-12-07 12:44:03 +0900 | [diff] [blame] | 3541 | for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} { |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3542 | result += ` |
Colin Cross | e4e44bc | 2020-12-28 13:50:21 -0800 | [diff] [blame] | 3543 | ` + txt + `_libraries_txt { |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3544 | name: "` + txt + `.libraries.txt", |
| 3545 | } |
| 3546 | ` |
| 3547 | } |
| 3548 | } else { |
Justin Yun | 8a2600c | 2020-12-07 12:44:03 +0900 | [diff] [blame] | 3549 | for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} { |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3550 | result += ` |
| 3551 | prebuilt_etc { |
| 3552 | name: "` + txt + `.libraries.` + v + `.txt", |
| 3553 | src: "dummy.txt", |
| 3554 | } |
| 3555 | ` |
| 3556 | } |
| 3557 | } |
| 3558 | } |
| 3559 | return |
| 3560 | } |
| 3561 | |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3562 | func TestVndkApexVersion(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3563 | ctx := testApex(t, ` |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3564 | apex_vndk { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3565 | name: "com.android.vndk.v27", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3566 | key: "myapex.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3567 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3568 | vndk_version: "27", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3569 | updatable: false, |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3570 | } |
| 3571 | |
| 3572 | apex_key { |
| 3573 | name: "myapex.key", |
| 3574 | public_key: "testkey.avbpubkey", |
| 3575 | private_key: "testkey.pem", |
| 3576 | } |
| 3577 | |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3578 | vndk_prebuilt_shared { |
| 3579 | name: "libvndk27", |
| 3580 | version: "27", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3581 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 3582 | product_available: true, |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3583 | vndk: { |
| 3584 | enabled: true, |
| 3585 | }, |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3586 | target_arch: "arm64", |
| 3587 | arch: { |
| 3588 | arm: { |
| 3589 | srcs: ["libvndk27_arm.so"], |
| 3590 | }, |
| 3591 | arm64: { |
| 3592 | srcs: ["libvndk27_arm64.so"], |
| 3593 | }, |
| 3594 | }, |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3595 | apex_available: [ "com.android.vndk.v27" ], |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3596 | } |
| 3597 | |
| 3598 | vndk_prebuilt_shared { |
| 3599 | name: "libvndk27", |
| 3600 | version: "27", |
| 3601 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 3602 | product_available: true, |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3603 | vndk: { |
| 3604 | enabled: true, |
| 3605 | }, |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3606 | target_arch: "x86_64", |
| 3607 | arch: { |
| 3608 | x86: { |
| 3609 | srcs: ["libvndk27_x86.so"], |
| 3610 | }, |
| 3611 | x86_64: { |
| 3612 | srcs: ["libvndk27_x86_64.so"], |
| 3613 | }, |
| 3614 | }, |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3615 | } |
| 3616 | `+vndkLibrariesTxtFiles("27"), |
| 3617 | withFiles(map[string][]byte{ |
| 3618 | "libvndk27_arm.so": nil, |
| 3619 | "libvndk27_arm64.so": nil, |
| 3620 | "libvndk27_x86.so": nil, |
| 3621 | "libvndk27_x86_64.so": nil, |
| 3622 | })) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3623 | |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3624 | ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{ |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3625 | "lib/libvndk27_arm.so", |
| 3626 | "lib64/libvndk27_arm64.so", |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3627 | "etc/*", |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3628 | }) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3629 | } |
| 3630 | |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3631 | func TestVndkApexNameRule(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3632 | ctx := testApex(t, ` |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3633 | apex_vndk { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3634 | name: "com.android.vndk.current", |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3635 | key: "myapex.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3636 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3637 | updatable: false, |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3638 | } |
| 3639 | apex_vndk { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3640 | name: "com.android.vndk.v28", |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3641 | key: "myapex.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3642 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3643 | vndk_version: "28", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3644 | updatable: false, |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3645 | } |
| 3646 | apex_key { |
| 3647 | name: "myapex.key", |
| 3648 | public_key: "testkey.avbpubkey", |
| 3649 | private_key: "testkey.pem", |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3650 | }`+vndkLibrariesTxtFiles("28", "current")) |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3651 | |
| 3652 | assertApexName := func(expected, moduleName string) { |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 3653 | bundle := ctx.ModuleForTests(moduleName, "android_common_image").Module().(*apexBundle) |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3654 | actual := proptools.String(bundle.properties.Apex_name) |
| 3655 | if !reflect.DeepEqual(actual, expected) { |
| 3656 | t.Errorf("Got '%v', expected '%v'", actual, expected) |
| 3657 | } |
| 3658 | } |
| 3659 | |
Jiyong Park | f58c46e | 2021-04-01 21:35:20 +0900 | [diff] [blame] | 3660 | assertApexName("com.android.vndk.v29", "com.android.vndk.current") |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3661 | assertApexName("com.android.vndk.v28", "com.android.vndk.v28") |
Jooyung Han | 90eee02 | 2019-10-01 20:02:42 +0900 | [diff] [blame] | 3662 | } |
| 3663 | |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3664 | func TestVndkApexSkipsNativeBridgeSupportedModules(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3665 | ctx := testApex(t, ` |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3666 | apex_vndk { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3667 | name: "com.android.vndk.current", |
| 3668 | key: "com.android.vndk.current.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3669 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3670 | updatable: false, |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3671 | } |
| 3672 | |
| 3673 | apex_key { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3674 | name: "com.android.vndk.current.key", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3675 | public_key: "testkey.avbpubkey", |
| 3676 | private_key: "testkey.pem", |
| 3677 | } |
| 3678 | |
| 3679 | cc_library { |
| 3680 | name: "libvndk", |
| 3681 | srcs: ["mylib.cpp"], |
| 3682 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 3683 | product_available: true, |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3684 | native_bridge_supported: true, |
| 3685 | host_supported: true, |
| 3686 | vndk: { |
| 3687 | enabled: true, |
| 3688 | }, |
| 3689 | system_shared_libs: [], |
| 3690 | stl: "none", |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3691 | apex_available: [ "com.android.vndk.current" ], |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3692 | } |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3693 | `+vndkLibrariesTxtFiles("current"), |
| 3694 | withNativeBridgeEnabled) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3695 | |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3696 | ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{ |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3697 | "lib/libvndk.so", |
| 3698 | "lib64/libvndk.so", |
Jooyung Han | e6436d7 | 2020-02-27 13:31:56 +0900 | [diff] [blame] | 3699 | "lib/libc++.so", |
| 3700 | "lib64/libc++.so", |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3701 | "etc/*", |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3702 | }) |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3703 | } |
| 3704 | |
| 3705 | func TestVndkApexDoesntSupportNativeBridgeSupported(t *testing.T) { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3706 | testApexError(t, `module "com.android.vndk.current" .*: native_bridge_supported: .* doesn't support native bridge binary`, ` |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3707 | apex_vndk { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3708 | name: "com.android.vndk.current", |
| 3709 | key: "com.android.vndk.current.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3710 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3711 | native_bridge_supported: true, |
| 3712 | } |
| 3713 | |
| 3714 | apex_key { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3715 | name: "com.android.vndk.current.key", |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3716 | public_key: "testkey.avbpubkey", |
| 3717 | private_key: "testkey.pem", |
| 3718 | } |
| 3719 | |
| 3720 | cc_library { |
| 3721 | name: "libvndk", |
| 3722 | srcs: ["mylib.cpp"], |
| 3723 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 3724 | product_available: true, |
Jooyung Han | 344d543 | 2019-08-23 11:17:39 +0900 | [diff] [blame] | 3725 | native_bridge_supported: true, |
| 3726 | host_supported: true, |
| 3727 | vndk: { |
| 3728 | enabled: true, |
| 3729 | }, |
| 3730 | system_shared_libs: [], |
| 3731 | stl: "none", |
| 3732 | } |
| 3733 | `) |
| 3734 | } |
| 3735 | |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3736 | func TestVndkApexWithBinder32(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3737 | ctx := testApex(t, ` |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3738 | apex_vndk { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3739 | name: "com.android.vndk.v27", |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3740 | key: "myapex.key", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3741 | file_contexts: ":myapex-file_contexts", |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3742 | vndk_version: "27", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3743 | updatable: false, |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3744 | } |
| 3745 | |
| 3746 | apex_key { |
| 3747 | name: "myapex.key", |
| 3748 | public_key: "testkey.avbpubkey", |
| 3749 | private_key: "testkey.pem", |
| 3750 | } |
| 3751 | |
| 3752 | vndk_prebuilt_shared { |
| 3753 | name: "libvndk27", |
| 3754 | version: "27", |
| 3755 | target_arch: "arm", |
| 3756 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 3757 | product_available: true, |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3758 | vndk: { |
| 3759 | enabled: true, |
| 3760 | }, |
| 3761 | arch: { |
| 3762 | arm: { |
| 3763 | srcs: ["libvndk27.so"], |
| 3764 | } |
| 3765 | }, |
| 3766 | } |
| 3767 | |
| 3768 | vndk_prebuilt_shared { |
| 3769 | name: "libvndk27", |
| 3770 | version: "27", |
| 3771 | target_arch: "arm", |
| 3772 | binder32bit: true, |
| 3773 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 3774 | product_available: true, |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3775 | vndk: { |
| 3776 | enabled: true, |
| 3777 | }, |
| 3778 | arch: { |
| 3779 | arm: { |
| 3780 | srcs: ["libvndk27binder32.so"], |
| 3781 | } |
| 3782 | }, |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3783 | apex_available: [ "com.android.vndk.v27" ], |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3784 | } |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3785 | `+vndkLibrariesTxtFiles("27"), |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3786 | withFiles(map[string][]byte{ |
| 3787 | "libvndk27.so": nil, |
| 3788 | "libvndk27binder32.so": nil, |
| 3789 | }), |
| 3790 | withBinder32bit, |
| 3791 | withTargets(map[android.OsType][]android.Target{ |
| 3792 | android.Android: []android.Target{ |
Jooyung Han | 35155c4 | 2020-02-06 17:33:20 +0900 | [diff] [blame] | 3793 | {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}, |
| 3794 | NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""}, |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3795 | }, |
| 3796 | }), |
| 3797 | ) |
| 3798 | |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3799 | ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{ |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3800 | "lib/libvndk27binder32.so", |
Jooyung Han | 39edb6c | 2019-11-06 16:53:07 +0900 | [diff] [blame] | 3801 | "etc/*", |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 3802 | }) |
| 3803 | } |
| 3804 | |
Jooyung Han | 45a9677 | 2020-06-15 14:59:42 +0900 | [diff] [blame] | 3805 | func TestVndkApexShouldNotProvideNativeLibs(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3806 | ctx := testApex(t, ` |
Jooyung Han | 45a9677 | 2020-06-15 14:59:42 +0900 | [diff] [blame] | 3807 | apex_vndk { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3808 | name: "com.android.vndk.current", |
| 3809 | key: "com.android.vndk.current.key", |
Jooyung Han | 45a9677 | 2020-06-15 14:59:42 +0900 | [diff] [blame] | 3810 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3811 | updatable: false, |
Jooyung Han | 45a9677 | 2020-06-15 14:59:42 +0900 | [diff] [blame] | 3812 | } |
| 3813 | |
| 3814 | apex_key { |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3815 | name: "com.android.vndk.current.key", |
Jooyung Han | 45a9677 | 2020-06-15 14:59:42 +0900 | [diff] [blame] | 3816 | public_key: "testkey.avbpubkey", |
| 3817 | private_key: "testkey.pem", |
| 3818 | } |
| 3819 | |
| 3820 | cc_library { |
| 3821 | name: "libz", |
| 3822 | vendor_available: true, |
Justin Yun | 63e9ec7 | 2020-10-29 16:49:43 +0900 | [diff] [blame] | 3823 | product_available: true, |
Jooyung Han | 45a9677 | 2020-06-15 14:59:42 +0900 | [diff] [blame] | 3824 | vndk: { |
| 3825 | enabled: true, |
| 3826 | }, |
| 3827 | stubs: { |
| 3828 | symbol_file: "libz.map.txt", |
| 3829 | versions: ["30"], |
| 3830 | } |
| 3831 | } |
| 3832 | `+vndkLibrariesTxtFiles("current"), withFiles(map[string][]byte{ |
| 3833 | "libz.map.txt": nil, |
| 3834 | })) |
| 3835 | |
Colin Cross | 2807f00 | 2021-03-02 10:15:29 -0800 | [diff] [blame] | 3836 | apexManifestRule := ctx.ModuleForTests("com.android.vndk.current", "android_common_image").Rule("apexManifestRule") |
Jooyung Han | 45a9677 | 2020-06-15 14:59:42 +0900 | [diff] [blame] | 3837 | provideNativeLibs := names(apexManifestRule.Args["provideNativeLibs"]) |
| 3838 | ensureListEmpty(t, provideNativeLibs) |
| 3839 | } |
| 3840 | |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3841 | func TestDependenciesInApexManifest(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3842 | ctx := testApex(t, ` |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3843 | apex { |
| 3844 | name: "myapex_nodep", |
| 3845 | key: "myapex.key", |
| 3846 | native_shared_libs: ["lib_nodep"], |
| 3847 | compile_multilib: "both", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3848 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3849 | updatable: false, |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3850 | } |
| 3851 | |
| 3852 | apex { |
| 3853 | name: "myapex_dep", |
| 3854 | key: "myapex.key", |
| 3855 | native_shared_libs: ["lib_dep"], |
| 3856 | compile_multilib: "both", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3857 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3858 | updatable: false, |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3859 | } |
| 3860 | |
| 3861 | apex { |
| 3862 | name: "myapex_provider", |
| 3863 | key: "myapex.key", |
| 3864 | native_shared_libs: ["libfoo"], |
| 3865 | compile_multilib: "both", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3866 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3867 | updatable: false, |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3868 | } |
| 3869 | |
| 3870 | apex { |
| 3871 | name: "myapex_selfcontained", |
| 3872 | key: "myapex.key", |
| 3873 | native_shared_libs: ["lib_dep", "libfoo"], |
| 3874 | compile_multilib: "both", |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 3875 | file_contexts: ":myapex-file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3876 | updatable: false, |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3877 | } |
| 3878 | |
| 3879 | apex_key { |
| 3880 | name: "myapex.key", |
| 3881 | public_key: "testkey.avbpubkey", |
| 3882 | private_key: "testkey.pem", |
| 3883 | } |
| 3884 | |
| 3885 | cc_library { |
| 3886 | name: "lib_nodep", |
| 3887 | srcs: ["mylib.cpp"], |
| 3888 | system_shared_libs: [], |
| 3889 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3890 | apex_available: [ "myapex_nodep" ], |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3891 | } |
| 3892 | |
| 3893 | cc_library { |
| 3894 | name: "lib_dep", |
| 3895 | srcs: ["mylib.cpp"], |
| 3896 | shared_libs: ["libfoo"], |
| 3897 | system_shared_libs: [], |
| 3898 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3899 | apex_available: [ |
| 3900 | "myapex_dep", |
| 3901 | "myapex_provider", |
| 3902 | "myapex_selfcontained", |
| 3903 | ], |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3904 | } |
| 3905 | |
| 3906 | cc_library { |
| 3907 | name: "libfoo", |
| 3908 | srcs: ["mytest.cpp"], |
| 3909 | stubs: { |
| 3910 | versions: ["1"], |
| 3911 | }, |
| 3912 | system_shared_libs: [], |
| 3913 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 3914 | apex_available: [ |
| 3915 | "myapex_provider", |
| 3916 | "myapex_selfcontained", |
| 3917 | ], |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3918 | } |
| 3919 | `) |
| 3920 | |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3921 | var apexManifestRule android.TestingBuildParams |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3922 | var provideNativeLibs, requireNativeLibs []string |
| 3923 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 3924 | apexManifestRule = ctx.ModuleForTests("myapex_nodep", "android_common_myapex_nodep_image").Rule("apexManifestRule") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3925 | provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"]) |
| 3926 | requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"]) |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3927 | ensureListEmpty(t, provideNativeLibs) |
| 3928 | ensureListEmpty(t, requireNativeLibs) |
| 3929 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 3930 | apexManifestRule = ctx.ModuleForTests("myapex_dep", "android_common_myapex_dep_image").Rule("apexManifestRule") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3931 | provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"]) |
| 3932 | requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"]) |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3933 | ensureListEmpty(t, provideNativeLibs) |
| 3934 | ensureListContains(t, requireNativeLibs, "libfoo.so") |
| 3935 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 3936 | apexManifestRule = ctx.ModuleForTests("myapex_provider", "android_common_myapex_provider_image").Rule("apexManifestRule") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3937 | provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"]) |
| 3938 | requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"]) |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3939 | ensureListContains(t, provideNativeLibs, "libfoo.so") |
| 3940 | ensureListEmpty(t, requireNativeLibs) |
| 3941 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 3942 | apexManifestRule = ctx.ModuleForTests("myapex_selfcontained", "android_common_myapex_selfcontained_image").Rule("apexManifestRule") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3943 | provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"]) |
| 3944 | requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"]) |
Jooyung Han | e163303 | 2019-08-01 17:41:43 +0900 | [diff] [blame] | 3945 | ensureListContains(t, provideNativeLibs, "libfoo.so") |
| 3946 | ensureListEmpty(t, requireNativeLibs) |
| 3947 | } |
| 3948 | |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3949 | func TestApexName(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3950 | ctx := testApex(t, ` |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3951 | apex { |
| 3952 | name: "myapex", |
| 3953 | key: "myapex.key", |
| 3954 | apex_name: "com.android.myapex", |
Jiyong Park | db33486 | 2020-02-05 17:19:28 +0900 | [diff] [blame] | 3955 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 3956 | updatable: false, |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3957 | } |
| 3958 | |
| 3959 | apex_key { |
| 3960 | name: "myapex.key", |
| 3961 | public_key: "testkey.avbpubkey", |
| 3962 | private_key: "testkey.pem", |
| 3963 | } |
Jiyong Park | db33486 | 2020-02-05 17:19:28 +0900 | [diff] [blame] | 3964 | |
| 3965 | cc_library { |
| 3966 | name: "mylib", |
| 3967 | srcs: ["mylib.cpp"], |
| 3968 | system_shared_libs: [], |
| 3969 | stl: "none", |
| 3970 | apex_available: [ |
| 3971 | "//apex_available:platform", |
| 3972 | "myapex", |
| 3973 | ], |
| 3974 | } |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3975 | `) |
| 3976 | |
Martin Stjernholm | bfffae7 | 2021-06-24 14:37:13 +0100 | [diff] [blame] | 3977 | module := ctx.ModuleForTests("myapex", "android_common_com.android.myapex_image") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3978 | apexManifestRule := module.Rule("apexManifestRule") |
| 3979 | ensureContains(t, apexManifestRule.Args["opt"], "-v name com.android.myapex") |
| 3980 | apexRule := module.Rule("apexRule") |
| 3981 | ensureContains(t, apexRule.Args["opt_flags"], "--do_not_check_keyname") |
Jiyong Park | db33486 | 2020-02-05 17:19:28 +0900 | [diff] [blame] | 3982 | |
Martin Stjernholm | bfffae7 | 2021-06-24 14:37:13 +0100 | [diff] [blame] | 3983 | apexBundle := module.Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 3984 | data := android.AndroidMkDataForTest(t, ctx, apexBundle) |
Jiyong Park | db33486 | 2020-02-05 17:19:28 +0900 | [diff] [blame] | 3985 | name := apexBundle.BaseModuleName() |
| 3986 | prefix := "TARGET_" |
| 3987 | var builder strings.Builder |
| 3988 | data.Custom(&builder, name, prefix, "", data) |
| 3989 | androidMk := builder.String() |
| 3990 | ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n") |
| 3991 | ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n") |
Jooyung Han | d15aa1f | 2019-09-27 00:38:03 +0900 | [diff] [blame] | 3992 | } |
| 3993 | |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 3994 | func TestNonTestApex(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 3995 | ctx := testApex(t, ` |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 3996 | apex { |
| 3997 | name: "myapex", |
| 3998 | key: "myapex.key", |
| 3999 | native_shared_libs: ["mylib_common"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4000 | updatable: false, |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 4001 | } |
| 4002 | |
| 4003 | apex_key { |
| 4004 | name: "myapex.key", |
| 4005 | public_key: "testkey.avbpubkey", |
| 4006 | private_key: "testkey.pem", |
| 4007 | } |
| 4008 | |
| 4009 | cc_library { |
| 4010 | name: "mylib_common", |
| 4011 | srcs: ["mylib.cpp"], |
| 4012 | system_shared_libs: [], |
| 4013 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 4014 | apex_available: [ |
| 4015 | "//apex_available:platform", |
| 4016 | "myapex", |
| 4017 | ], |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 4018 | } |
| 4019 | `) |
| 4020 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 4021 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 4022 | apexRule := module.Rule("apexRule") |
| 4023 | copyCmds := apexRule.Args["copy_commands"] |
| 4024 | |
| 4025 | if apex, ok := module.Module().(*apexBundle); !ok || apex.testApex { |
| 4026 | t.Log("Apex was a test apex!") |
| 4027 | t.Fail() |
| 4028 | } |
| 4029 | // Ensure that main rule creates an output |
| 4030 | ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned") |
| 4031 | |
| 4032 | // Ensure that apex variant is created for the direct dep |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 4033 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000") |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 4034 | |
| 4035 | // Ensure that both direct and indirect deps are copied into apex |
| 4036 | ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so") |
| 4037 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 4038 | // Ensure that the platform variant ends with _shared |
| 4039 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared") |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 4040 | |
Colin Cross | 56a8321 | 2020-09-15 18:30:11 -0700 | [diff] [blame] | 4041 | if !ctx.ModuleForTests("mylib_common", "android_arm64_armv8-a_shared_apex10000").Module().(*cc.Module).InAnyApex() { |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 4042 | t.Log("Found mylib_common not in any apex!") |
| 4043 | t.Fail() |
| 4044 | } |
| 4045 | } |
| 4046 | |
| 4047 | func TestTestApex(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4048 | ctx := testApex(t, ` |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 4049 | apex_test { |
| 4050 | name: "myapex", |
| 4051 | key: "myapex.key", |
| 4052 | native_shared_libs: ["mylib_common_test"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4053 | updatable: false, |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 4054 | } |
| 4055 | |
| 4056 | apex_key { |
| 4057 | name: "myapex.key", |
| 4058 | public_key: "testkey.avbpubkey", |
| 4059 | private_key: "testkey.pem", |
| 4060 | } |
| 4061 | |
| 4062 | cc_library { |
| 4063 | name: "mylib_common_test", |
| 4064 | srcs: ["mylib.cpp"], |
| 4065 | system_shared_libs: [], |
| 4066 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 4067 | // TODO: remove //apex_available:platform |
| 4068 | apex_available: [ |
| 4069 | "//apex_available:platform", |
| 4070 | "myapex", |
| 4071 | ], |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 4072 | } |
| 4073 | `) |
| 4074 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 4075 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 4076 | apexRule := module.Rule("apexRule") |
| 4077 | copyCmds := apexRule.Args["copy_commands"] |
| 4078 | |
| 4079 | if apex, ok := module.Module().(*apexBundle); !ok || !apex.testApex { |
| 4080 | t.Log("Apex was not a test apex!") |
| 4081 | t.Fail() |
| 4082 | } |
| 4083 | // Ensure that main rule creates an output |
| 4084 | ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned") |
| 4085 | |
| 4086 | // Ensure that apex variant is created for the direct dep |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 4087 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared_apex10000") |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 4088 | |
| 4089 | // Ensure that both direct and indirect deps are copied into apex |
| 4090 | ensureContains(t, copyCmds, "image.apex/lib64/mylib_common_test.so") |
| 4091 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 4092 | // Ensure that the platform variant ends with _shared |
| 4093 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared") |
Alex Light | 0851b88 | 2019-02-07 13:20:53 -0800 | [diff] [blame] | 4094 | } |
| 4095 | |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 4096 | func TestApexWithTarget(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4097 | ctx := testApex(t, ` |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 4098 | apex { |
| 4099 | name: "myapex", |
| 4100 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4101 | updatable: false, |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 4102 | multilib: { |
| 4103 | first: { |
| 4104 | native_shared_libs: ["mylib_common"], |
| 4105 | } |
| 4106 | }, |
| 4107 | target: { |
| 4108 | android: { |
| 4109 | multilib: { |
| 4110 | first: { |
| 4111 | native_shared_libs: ["mylib"], |
| 4112 | } |
| 4113 | } |
| 4114 | }, |
| 4115 | host: { |
| 4116 | multilib: { |
| 4117 | first: { |
| 4118 | native_shared_libs: ["mylib2"], |
| 4119 | } |
| 4120 | } |
| 4121 | } |
| 4122 | } |
| 4123 | } |
| 4124 | |
| 4125 | apex_key { |
| 4126 | name: "myapex.key", |
| 4127 | public_key: "testkey.avbpubkey", |
| 4128 | private_key: "testkey.pem", |
| 4129 | } |
| 4130 | |
| 4131 | cc_library { |
| 4132 | name: "mylib", |
| 4133 | srcs: ["mylib.cpp"], |
| 4134 | system_shared_libs: [], |
| 4135 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 4136 | // TODO: remove //apex_available:platform |
| 4137 | apex_available: [ |
| 4138 | "//apex_available:platform", |
| 4139 | "myapex", |
| 4140 | ], |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 4141 | } |
| 4142 | |
| 4143 | cc_library { |
| 4144 | name: "mylib_common", |
| 4145 | srcs: ["mylib.cpp"], |
| 4146 | system_shared_libs: [], |
| 4147 | stl: "none", |
| 4148 | compile_multilib: "first", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 4149 | // TODO: remove //apex_available:platform |
| 4150 | apex_available: [ |
| 4151 | "//apex_available:platform", |
| 4152 | "myapex", |
| 4153 | ], |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 4154 | } |
| 4155 | |
| 4156 | cc_library { |
| 4157 | name: "mylib2", |
| 4158 | srcs: ["mylib.cpp"], |
| 4159 | system_shared_libs: [], |
| 4160 | stl: "none", |
| 4161 | compile_multilib: "first", |
| 4162 | } |
| 4163 | `) |
| 4164 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 4165 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 4166 | copyCmds := apexRule.Args["copy_commands"] |
| 4167 | |
| 4168 | // Ensure that main rule creates an output |
| 4169 | ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned") |
| 4170 | |
| 4171 | // Ensure that apex variant is created for the direct dep |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 4172 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000") |
| 4173 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000") |
| 4174 | ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000") |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 4175 | |
| 4176 | // Ensure that both direct and indirect deps are copied into apex |
| 4177 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
| 4178 | ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so") |
| 4179 | ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so") |
| 4180 | |
Colin Cross | 7113d20 | 2019-11-20 16:39:12 -0800 | [diff] [blame] | 4181 | // Ensure that the platform variant ends with _shared |
| 4182 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared") |
| 4183 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared") |
| 4184 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared") |
Alex Light | 9670d33 | 2019-01-29 18:07:33 -0800 | [diff] [blame] | 4185 | } |
Jiyong Park | 04480cf | 2019-02-06 00:16:29 +0900 | [diff] [blame] | 4186 | |
Jiyong Park | 5914030 | 2020-12-14 18:44:04 +0900 | [diff] [blame] | 4187 | func TestApexWithArch(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4188 | ctx := testApex(t, ` |
Jiyong Park | 5914030 | 2020-12-14 18:44:04 +0900 | [diff] [blame] | 4189 | apex { |
| 4190 | name: "myapex", |
| 4191 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4192 | updatable: false, |
Jiyong Park | 5914030 | 2020-12-14 18:44:04 +0900 | [diff] [blame] | 4193 | arch: { |
| 4194 | arm64: { |
| 4195 | native_shared_libs: ["mylib.arm64"], |
| 4196 | }, |
| 4197 | x86_64: { |
| 4198 | native_shared_libs: ["mylib.x64"], |
| 4199 | }, |
| 4200 | } |
| 4201 | } |
| 4202 | |
| 4203 | apex_key { |
| 4204 | name: "myapex.key", |
| 4205 | public_key: "testkey.avbpubkey", |
| 4206 | private_key: "testkey.pem", |
| 4207 | } |
| 4208 | |
| 4209 | cc_library { |
| 4210 | name: "mylib.arm64", |
| 4211 | srcs: ["mylib.cpp"], |
| 4212 | system_shared_libs: [], |
| 4213 | stl: "none", |
| 4214 | // TODO: remove //apex_available:platform |
| 4215 | apex_available: [ |
| 4216 | "//apex_available:platform", |
| 4217 | "myapex", |
| 4218 | ], |
| 4219 | } |
| 4220 | |
| 4221 | cc_library { |
| 4222 | name: "mylib.x64", |
| 4223 | srcs: ["mylib.cpp"], |
| 4224 | system_shared_libs: [], |
| 4225 | stl: "none", |
| 4226 | // TODO: remove //apex_available:platform |
| 4227 | apex_available: [ |
| 4228 | "//apex_available:platform", |
| 4229 | "myapex", |
| 4230 | ], |
| 4231 | } |
| 4232 | `) |
| 4233 | |
| 4234 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
| 4235 | copyCmds := apexRule.Args["copy_commands"] |
| 4236 | |
| 4237 | // Ensure that apex variant is created for the direct dep |
| 4238 | ensureListContains(t, ctx.ModuleVariantsForTests("mylib.arm64"), "android_arm64_armv8-a_shared_apex10000") |
| 4239 | ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib.x64"), "android_arm64_armv8-a_shared_apex10000") |
| 4240 | |
| 4241 | // Ensure that both direct and indirect deps are copied into apex |
| 4242 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.arm64.so") |
| 4243 | ensureNotContains(t, copyCmds, "image.apex/lib64/mylib.x64.so") |
| 4244 | } |
| 4245 | |
Jiyong Park | 04480cf | 2019-02-06 00:16:29 +0900 | [diff] [blame] | 4246 | func TestApexWithShBinary(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4247 | ctx := testApex(t, ` |
Jiyong Park | 04480cf | 2019-02-06 00:16:29 +0900 | [diff] [blame] | 4248 | apex { |
| 4249 | name: "myapex", |
| 4250 | key: "myapex.key", |
| 4251 | binaries: ["myscript"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4252 | updatable: false, |
Jiyong Park | 04480cf | 2019-02-06 00:16:29 +0900 | [diff] [blame] | 4253 | } |
| 4254 | |
| 4255 | apex_key { |
| 4256 | name: "myapex.key", |
| 4257 | public_key: "testkey.avbpubkey", |
| 4258 | private_key: "testkey.pem", |
| 4259 | } |
| 4260 | |
| 4261 | sh_binary { |
| 4262 | name: "myscript", |
| 4263 | src: "mylib.cpp", |
| 4264 | filename: "myscript.sh", |
| 4265 | sub_dir: "script", |
| 4266 | } |
| 4267 | `) |
| 4268 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 4269 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Jiyong Park | 04480cf | 2019-02-06 00:16:29 +0900 | [diff] [blame] | 4270 | copyCmds := apexRule.Args["copy_commands"] |
| 4271 | |
| 4272 | ensureContains(t, copyCmds, "image.apex/bin/script/myscript.sh") |
| 4273 | } |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 4274 | |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 4275 | func TestApexInVariousPartition(t *testing.T) { |
| 4276 | testcases := []struct { |
| 4277 | propName, parition, flattenedPartition string |
| 4278 | }{ |
| 4279 | {"", "system", "system_ext"}, |
| 4280 | {"product_specific: true", "product", "product"}, |
| 4281 | {"soc_specific: true", "vendor", "vendor"}, |
| 4282 | {"proprietary: true", "vendor", "vendor"}, |
| 4283 | {"vendor: true", "vendor", "vendor"}, |
| 4284 | {"system_ext_specific: true", "system_ext", "system_ext"}, |
| 4285 | } |
| 4286 | for _, tc := range testcases { |
| 4287 | t.Run(tc.propName+":"+tc.parition, func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4288 | ctx := testApex(t, ` |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 4289 | apex { |
| 4290 | name: "myapex", |
| 4291 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4292 | updatable: false, |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 4293 | `+tc.propName+` |
| 4294 | } |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 4295 | |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 4296 | apex_key { |
| 4297 | name: "myapex.key", |
| 4298 | public_key: "testkey.avbpubkey", |
| 4299 | private_key: "testkey.pem", |
| 4300 | } |
| 4301 | `) |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 4302 | |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 4303 | apex := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Paul Duffin | 37ba344 | 2021-03-29 00:21:08 +0100 | [diff] [blame] | 4304 | expected := "out/soong/target/product/test_device/" + tc.parition + "/apex" |
| 4305 | actual := apex.installDir.RelativeToTop().String() |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 4306 | if actual != expected { |
| 4307 | t.Errorf("wrong install path. expected %q. actual %q", expected, actual) |
| 4308 | } |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 4309 | |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 4310 | flattened := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle) |
Paul Duffin | 37ba344 | 2021-03-29 00:21:08 +0100 | [diff] [blame] | 4311 | expected = "out/soong/target/product/test_device/" + tc.flattenedPartition + "/apex" |
| 4312 | actual = flattened.installDir.RelativeToTop().String() |
Jooyung Han | 91df208 | 2019-11-20 01:49:42 +0900 | [diff] [blame] | 4313 | if actual != expected { |
| 4314 | t.Errorf("wrong install path. expected %q. actual %q", expected, actual) |
| 4315 | } |
| 4316 | }) |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 4317 | } |
Jiyong Park | d1e293d | 2019-03-15 02:13:21 +0900 | [diff] [blame] | 4318 | } |
Jiyong Park | 6788256 | 2019-03-21 01:11:21 +0900 | [diff] [blame] | 4319 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4320 | func TestFileContexts_FindInDefaultLocationIfNotSet(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4321 | ctx := testApex(t, ` |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4322 | apex { |
| 4323 | name: "myapex", |
| 4324 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4325 | updatable: false, |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4326 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4327 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4328 | apex_key { |
| 4329 | name: "myapex.key", |
| 4330 | public_key: "testkey.avbpubkey", |
| 4331 | private_key: "testkey.pem", |
| 4332 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4333 | `) |
| 4334 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4335 | rule := module.Output("file_contexts") |
| 4336 | ensureContains(t, rule.RuleParams.Command, "cat system/sepolicy/apex/myapex-file_contexts") |
| 4337 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4338 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4339 | func TestFileContexts_ShouldBeUnderSystemSepolicyForSystemApexes(t *testing.T) { |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4340 | testApexError(t, `"myapex" .*: file_contexts: should be under system/sepolicy`, ` |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4341 | apex { |
| 4342 | name: "myapex", |
| 4343 | key: "myapex.key", |
| 4344 | file_contexts: "my_own_file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4345 | updatable: false, |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4346 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4347 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4348 | apex_key { |
| 4349 | name: "myapex.key", |
| 4350 | public_key: "testkey.avbpubkey", |
| 4351 | private_key: "testkey.pem", |
| 4352 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4353 | `, withFiles(map[string][]byte{ |
| 4354 | "my_own_file_contexts": nil, |
| 4355 | })) |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4356 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4357 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4358 | func TestFileContexts_ProductSpecificApexes(t *testing.T) { |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4359 | testApexError(t, `"myapex" .*: file_contexts: cannot find`, ` |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4360 | apex { |
| 4361 | name: "myapex", |
| 4362 | key: "myapex.key", |
| 4363 | product_specific: true, |
| 4364 | file_contexts: "product_specific_file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4365 | updatable: false, |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4366 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4367 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4368 | apex_key { |
| 4369 | name: "myapex.key", |
| 4370 | public_key: "testkey.avbpubkey", |
| 4371 | private_key: "testkey.pem", |
| 4372 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4373 | `) |
| 4374 | |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4375 | ctx := testApex(t, ` |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4376 | apex { |
| 4377 | name: "myapex", |
| 4378 | key: "myapex.key", |
| 4379 | product_specific: true, |
| 4380 | file_contexts: "product_specific_file_contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4381 | updatable: false, |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4382 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4383 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4384 | apex_key { |
| 4385 | name: "myapex.key", |
| 4386 | public_key: "testkey.avbpubkey", |
| 4387 | private_key: "testkey.pem", |
| 4388 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4389 | `, withFiles(map[string][]byte{ |
| 4390 | "product_specific_file_contexts": nil, |
| 4391 | })) |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4392 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
| 4393 | rule := module.Output("file_contexts") |
| 4394 | ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts") |
| 4395 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4396 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4397 | func TestFileContexts_SetViaFileGroup(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4398 | ctx := testApex(t, ` |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4399 | apex { |
| 4400 | name: "myapex", |
| 4401 | key: "myapex.key", |
| 4402 | product_specific: true, |
| 4403 | file_contexts: ":my-file-contexts", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 4404 | updatable: false, |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4405 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4406 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4407 | apex_key { |
| 4408 | name: "myapex.key", |
| 4409 | public_key: "testkey.avbpubkey", |
| 4410 | private_key: "testkey.pem", |
| 4411 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4412 | |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4413 | filegroup { |
| 4414 | name: "my-file-contexts", |
| 4415 | srcs: ["product_specific_file_contexts"], |
| 4416 | } |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4417 | `, withFiles(map[string][]byte{ |
| 4418 | "product_specific_file_contexts": nil, |
| 4419 | })) |
Jooyung Han | 580eb4f | 2020-06-24 19:33:06 +0900 | [diff] [blame] | 4420 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
| 4421 | rule := module.Output("file_contexts") |
| 4422 | ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts") |
Jooyung Han | 54aca7b | 2019-11-20 02:26:02 +0900 | [diff] [blame] | 4423 | } |
| 4424 | |
Jiyong Park | 6788256 | 2019-03-21 01:11:21 +0900 | [diff] [blame] | 4425 | func TestApexKeyFromOtherModule(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4426 | ctx := testApex(t, ` |
Jiyong Park | 6788256 | 2019-03-21 01:11:21 +0900 | [diff] [blame] | 4427 | apex_key { |
| 4428 | name: "myapex.key", |
| 4429 | public_key: ":my.avbpubkey", |
| 4430 | private_key: ":my.pem", |
| 4431 | product_specific: true, |
| 4432 | } |
| 4433 | |
| 4434 | filegroup { |
| 4435 | name: "my.avbpubkey", |
| 4436 | srcs: ["testkey2.avbpubkey"], |
| 4437 | } |
| 4438 | |
| 4439 | filegroup { |
| 4440 | name: "my.pem", |
| 4441 | srcs: ["testkey2.pem"], |
| 4442 | } |
| 4443 | `) |
| 4444 | |
| 4445 | apex_key := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey) |
| 4446 | expected_pubkey := "testkey2.avbpubkey" |
Jaewoong Jung | 18aefc1 | 2020-12-21 09:11:10 -0800 | [diff] [blame] | 4447 | actual_pubkey := apex_key.publicKeyFile.String() |
Jiyong Park | 6788256 | 2019-03-21 01:11:21 +0900 | [diff] [blame] | 4448 | if actual_pubkey != expected_pubkey { |
| 4449 | t.Errorf("wrong public key path. expected %q. actual %q", expected_pubkey, actual_pubkey) |
| 4450 | } |
| 4451 | expected_privkey := "testkey2.pem" |
Jaewoong Jung | 18aefc1 | 2020-12-21 09:11:10 -0800 | [diff] [blame] | 4452 | actual_privkey := apex_key.privateKeyFile.String() |
Jiyong Park | 6788256 | 2019-03-21 01:11:21 +0900 | [diff] [blame] | 4453 | if actual_privkey != expected_privkey { |
| 4454 | t.Errorf("wrong private key path. expected %q. actual %q", expected_privkey, actual_privkey) |
| 4455 | } |
| 4456 | } |
Jaewoong Jung | 939ebd5 | 2019-03-26 15:07:36 -0700 | [diff] [blame] | 4457 | |
| 4458 | func TestPrebuilt(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4459 | ctx := testApex(t, ` |
Jaewoong Jung | 939ebd5 | 2019-03-26 15:07:36 -0700 | [diff] [blame] | 4460 | prebuilt_apex { |
| 4461 | name: "myapex", |
Jiyong Park | c95714e | 2019-03-29 14:23:10 +0900 | [diff] [blame] | 4462 | arch: { |
| 4463 | arm64: { |
| 4464 | src: "myapex-arm64.apex", |
| 4465 | }, |
| 4466 | arm: { |
| 4467 | src: "myapex-arm.apex", |
| 4468 | }, |
| 4469 | }, |
Jaewoong Jung | 939ebd5 | 2019-03-26 15:07:36 -0700 | [diff] [blame] | 4470 | } |
| 4471 | `) |
| 4472 | |
Paul Duffin | 6717d88 | 2021-06-15 19:09:41 +0100 | [diff] [blame] | 4473 | prebuilt := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt) |
Jaewoong Jung | 939ebd5 | 2019-03-26 15:07:36 -0700 | [diff] [blame] | 4474 | |
Jiyong Park | c95714e | 2019-03-29 14:23:10 +0900 | [diff] [blame] | 4475 | expectedInput := "myapex-arm64.apex" |
| 4476 | if prebuilt.inputApex.String() != expectedInput { |
| 4477 | t.Errorf("inputApex invalid. expected: %q, actual: %q", expectedInput, prebuilt.inputApex.String()) |
| 4478 | } |
Jaewoong Jung | 939ebd5 | 2019-03-26 15:07:36 -0700 | [diff] [blame] | 4479 | } |
Nikita Ioffe | 7a41ebd | 2019-04-04 18:09:48 +0100 | [diff] [blame] | 4480 | |
Paul Duffin | c0609c6 | 2021-03-01 17:27:16 +0000 | [diff] [blame] | 4481 | func TestPrebuiltMissingSrc(t *testing.T) { |
Paul Duffin | 6717d88 | 2021-06-15 19:09:41 +0100 | [diff] [blame] | 4482 | testApexError(t, `module "myapex" variant "android_common_myapex".*: prebuilt_apex does not support "arm64_armv8-a"`, ` |
Paul Duffin | c0609c6 | 2021-03-01 17:27:16 +0000 | [diff] [blame] | 4483 | prebuilt_apex { |
| 4484 | name: "myapex", |
| 4485 | } |
| 4486 | `) |
| 4487 | } |
| 4488 | |
Nikita Ioffe | 7a41ebd | 2019-04-04 18:09:48 +0100 | [diff] [blame] | 4489 | func TestPrebuiltFilenameOverride(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4490 | ctx := testApex(t, ` |
Nikita Ioffe | 7a41ebd | 2019-04-04 18:09:48 +0100 | [diff] [blame] | 4491 | prebuilt_apex { |
| 4492 | name: "myapex", |
| 4493 | src: "myapex-arm.apex", |
| 4494 | filename: "notmyapex.apex", |
| 4495 | } |
| 4496 | `) |
| 4497 | |
Paul Duffin | 6717d88 | 2021-06-15 19:09:41 +0100 | [diff] [blame] | 4498 | p := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt) |
Nikita Ioffe | 7a41ebd | 2019-04-04 18:09:48 +0100 | [diff] [blame] | 4499 | |
| 4500 | expected := "notmyapex.apex" |
| 4501 | if p.installFilename != expected { |
| 4502 | t.Errorf("installFilename invalid. expected: %q, actual: %q", expected, p.installFilename) |
| 4503 | } |
| 4504 | } |
Jaewoong Jung | c1001ec | 2019-06-25 11:20:53 -0700 | [diff] [blame] | 4505 | |
Samiul Islam | 7c02e26 | 2021-09-08 17:48:28 +0100 | [diff] [blame] | 4506 | func TestApexSetFilenameOverride(t *testing.T) { |
| 4507 | testApex(t, ` |
| 4508 | apex_set { |
| 4509 | name: "com.company.android.myapex", |
| 4510 | apex_name: "com.android.myapex", |
| 4511 | set: "company-myapex.apks", |
| 4512 | filename: "com.company.android.myapex.apex" |
| 4513 | } |
| 4514 | `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex") |
| 4515 | |
| 4516 | testApex(t, ` |
| 4517 | apex_set { |
| 4518 | name: "com.company.android.myapex", |
| 4519 | apex_name: "com.android.myapex", |
| 4520 | set: "company-myapex.apks", |
| 4521 | filename: "com.company.android.myapex.capex" |
| 4522 | } |
| 4523 | `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex") |
| 4524 | |
| 4525 | testApexError(t, `filename should end in .apex or .capex for apex_set`, ` |
| 4526 | apex_set { |
| 4527 | name: "com.company.android.myapex", |
| 4528 | apex_name: "com.android.myapex", |
| 4529 | set: "company-myapex.apks", |
| 4530 | filename: "some-random-suffix" |
| 4531 | } |
| 4532 | `) |
| 4533 | } |
| 4534 | |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 4535 | func TestPrebuiltOverrides(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 4536 | ctx := testApex(t, ` |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 4537 | prebuilt_apex { |
| 4538 | name: "myapex.prebuilt", |
| 4539 | src: "myapex-arm.apex", |
| 4540 | overrides: [ |
| 4541 | "myapex", |
| 4542 | ], |
| 4543 | } |
| 4544 | `) |
| 4545 | |
Paul Duffin | 6717d88 | 2021-06-15 19:09:41 +0100 | [diff] [blame] | 4546 | p := ctx.ModuleForTests("myapex.prebuilt", "android_common_myapex.prebuilt").Module().(*Prebuilt) |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 4547 | |
| 4548 | expected := []string{"myapex"} |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 4549 | actual := android.AndroidMkEntriesForTest(t, ctx, p)[0].EntryMap["LOCAL_OVERRIDES_MODULES"] |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 4550 | if !reflect.DeepEqual(actual, expected) { |
Jiyong Park | b0a012c | 2019-11-14 17:17:03 +0900 | [diff] [blame] | 4551 | t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES value '%s', expected '%s'", actual, expected) |
Jaewoong Jung | 22f7d18 | 2019-07-16 18:25:41 -0700 | [diff] [blame] | 4552 | } |
| 4553 | } |
| 4554 | |
Martin Stjernholm | bfffae7 | 2021-06-24 14:37:13 +0100 | [diff] [blame] | 4555 | func TestPrebuiltApexName(t *testing.T) { |
| 4556 | testApex(t, ` |
| 4557 | prebuilt_apex { |
| 4558 | name: "com.company.android.myapex", |
| 4559 | apex_name: "com.android.myapex", |
| 4560 | src: "company-myapex-arm.apex", |
| 4561 | } |
| 4562 | `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex") |
| 4563 | |
| 4564 | testApex(t, ` |
| 4565 | apex_set { |
| 4566 | name: "com.company.android.myapex", |
| 4567 | apex_name: "com.android.myapex", |
| 4568 | set: "company-myapex.apks", |
| 4569 | } |
| 4570 | `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex") |
| 4571 | } |
| 4572 | |
| 4573 | func TestPrebuiltApexNameWithPlatformBootclasspath(t *testing.T) { |
| 4574 | _ = android.GroupFixturePreparers( |
| 4575 | java.PrepareForTestWithJavaDefaultModules, |
| 4576 | PrepareForTestWithApexBuildComponents, |
| 4577 | android.FixtureWithRootAndroidBp(` |
| 4578 | platform_bootclasspath { |
| 4579 | name: "platform-bootclasspath", |
| 4580 | fragments: [ |
| 4581 | { |
| 4582 | apex: "com.android.art", |
| 4583 | module: "art-bootclasspath-fragment", |
| 4584 | }, |
| 4585 | ], |
| 4586 | } |
| 4587 | |
| 4588 | prebuilt_apex { |
| 4589 | name: "com.company.android.art", |
| 4590 | apex_name: "com.android.art", |
| 4591 | src: "com.company.android.art-arm.apex", |
| 4592 | exported_bootclasspath_fragments: ["art-bootclasspath-fragment"], |
| 4593 | } |
| 4594 | |
| 4595 | prebuilt_bootclasspath_fragment { |
| 4596 | name: "art-bootclasspath-fragment", |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 4597 | image_name: "art", |
Martin Stjernholm | bfffae7 | 2021-06-24 14:37:13 +0100 | [diff] [blame] | 4598 | contents: ["core-oj"], |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 4599 | hidden_api: { |
| 4600 | annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv", |
| 4601 | metadata: "my-bootclasspath-fragment/metadata.csv", |
| 4602 | index: "my-bootclasspath-fragment/index.csv", |
| 4603 | stub_flags: "my-bootclasspath-fragment/stub-flags.csv", |
| 4604 | all_flags: "my-bootclasspath-fragment/all-flags.csv", |
| 4605 | }, |
Martin Stjernholm | bfffae7 | 2021-06-24 14:37:13 +0100 | [diff] [blame] | 4606 | } |
| 4607 | |
| 4608 | java_import { |
| 4609 | name: "core-oj", |
| 4610 | jars: ["prebuilt.jar"], |
| 4611 | } |
| 4612 | `), |
| 4613 | ).RunTest(t) |
| 4614 | } |
| 4615 | |
Paul Duffin | 092153d | 2021-01-26 11:42:39 +0000 | [diff] [blame] | 4616 | // These tests verify that the prebuilt_apex/deapexer to java_import wiring allows for the |
| 4617 | // propagation of paths to dex implementation jars from the former to the latter. |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4618 | func TestPrebuiltExportDexImplementationJars(t *testing.T) { |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 4619 | transform := android.NullFixturePreparer |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4620 | |
Paul Duffin | 89886cb | 2021-02-05 16:44:03 +0000 | [diff] [blame] | 4621 | checkDexJarBuildPath := func(t *testing.T, ctx *android.TestContext, name string) { |
Martin Stjernholm | 8be1e6d | 2021-09-15 03:34:04 +0100 | [diff] [blame] | 4622 | t.Helper() |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4623 | // Make sure the import has been given the correct path to the dex jar. |
Colin Cross | dcf71b2 | 2021-02-01 13:59:03 -0800 | [diff] [blame] | 4624 | p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency) |
Martin Stjernholm | 8be1e6d | 2021-09-15 03:34:04 +0100 | [diff] [blame] | 4625 | dexJarBuildPath := p.DexJarBuildPath().PathOrNil() |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4626 | stem := android.RemoveOptionalPrebuiltPrefix(name) |
Jeongik Cha | d5fe878 | 2021-07-08 01:13:11 +0900 | [diff] [blame] | 4627 | android.AssertStringEquals(t, "DexJarBuildPath should be apex-related path.", |
| 4628 | ".intermediates/myapex.deapexer/android_common/deapexer/javalib/"+stem+".jar", |
| 4629 | android.NormalizePathForTesting(dexJarBuildPath)) |
| 4630 | } |
| 4631 | |
| 4632 | checkDexJarInstallPath := func(t *testing.T, ctx *android.TestContext, name string) { |
Martin Stjernholm | 8be1e6d | 2021-09-15 03:34:04 +0100 | [diff] [blame] | 4633 | t.Helper() |
Jeongik Cha | d5fe878 | 2021-07-08 01:13:11 +0900 | [diff] [blame] | 4634 | // Make sure the import has been given the correct path to the dex jar. |
| 4635 | p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency) |
| 4636 | dexJarBuildPath := p.DexJarInstallPath() |
| 4637 | stem := android.RemoveOptionalPrebuiltPrefix(name) |
| 4638 | android.AssertStringEquals(t, "DexJarInstallPath should be apex-related path.", |
| 4639 | "target/product/test_device/apex/myapex/javalib/"+stem+".jar", |
| 4640 | android.NormalizePathForTesting(dexJarBuildPath)) |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4641 | } |
| 4642 | |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4643 | ensureNoSourceVariant := func(t *testing.T, ctx *android.TestContext, name string) { |
Martin Stjernholm | 8be1e6d | 2021-09-15 03:34:04 +0100 | [diff] [blame] | 4644 | t.Helper() |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4645 | // Make sure that an apex variant is not created for the source module. |
Jeongik Cha | d5fe878 | 2021-07-08 01:13:11 +0900 | [diff] [blame] | 4646 | android.AssertArrayString(t, "Check if there is no source variant", |
| 4647 | []string{"android_common"}, |
| 4648 | ctx.ModuleVariantsForTests(name)) |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4649 | } |
| 4650 | |
| 4651 | t.Run("prebuilt only", func(t *testing.T) { |
| 4652 | bp := ` |
| 4653 | prebuilt_apex { |
| 4654 | name: "myapex", |
| 4655 | arch: { |
| 4656 | arm64: { |
| 4657 | src: "myapex-arm64.apex", |
| 4658 | }, |
| 4659 | arm: { |
| 4660 | src: "myapex-arm.apex", |
| 4661 | }, |
| 4662 | }, |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4663 | exported_java_libs: ["libfoo", "libbar"], |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4664 | } |
| 4665 | |
| 4666 | java_import { |
| 4667 | name: "libfoo", |
| 4668 | jars: ["libfoo.jar"], |
| 4669 | } |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4670 | |
| 4671 | java_sdk_library_import { |
| 4672 | name: "libbar", |
| 4673 | public: { |
| 4674 | jars: ["libbar.jar"], |
| 4675 | }, |
| 4676 | } |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4677 | ` |
| 4678 | |
| 4679 | // Make sure that dexpreopt can access dex implementation files from the prebuilt. |
| 4680 | ctx := testDexpreoptWithApexes(t, bp, "", transform) |
| 4681 | |
Martin Stjernholm | 4482560 | 2021-09-17 01:44:12 +0100 | [diff] [blame] | 4682 | deapexerName := deapexerModuleName("myapex") |
| 4683 | android.AssertStringEquals(t, "APEX module name from deapexer name", "myapex", apexModuleName(deapexerName)) |
| 4684 | |
Paul Duffin | f6932af | 2021-02-26 18:21:56 +0000 | [diff] [blame] | 4685 | // Make sure that the deapexer has the correct input APEX. |
Martin Stjernholm | 4482560 | 2021-09-17 01:44:12 +0100 | [diff] [blame] | 4686 | deapexer := ctx.ModuleForTests(deapexerName, "android_common") |
Paul Duffin | f6932af | 2021-02-26 18:21:56 +0000 | [diff] [blame] | 4687 | rule := deapexer.Rule("deapexer") |
| 4688 | if expected, actual := []string{"myapex-arm64.apex"}, android.NormalizePathsForTesting(rule.Implicits); !reflect.DeepEqual(expected, actual) { |
| 4689 | t.Errorf("expected: %q, found: %q", expected, actual) |
| 4690 | } |
| 4691 | |
Paul Duffin | 0d10c3c | 2021-03-01 17:09:32 +0000 | [diff] [blame] | 4692 | // Make sure that the prebuilt_apex has the correct input APEX. |
Paul Duffin | 6717d88 | 2021-06-15 19:09:41 +0100 | [diff] [blame] | 4693 | prebuiltApex := ctx.ModuleForTests("myapex", "android_common_myapex") |
Paul Duffin | 0d10c3c | 2021-03-01 17:09:32 +0000 | [diff] [blame] | 4694 | rule = prebuiltApex.Rule("android/soong/android.Cp") |
| 4695 | if expected, actual := "myapex-arm64.apex", android.NormalizePathForTesting(rule.Input); !reflect.DeepEqual(expected, actual) { |
| 4696 | t.Errorf("expected: %q, found: %q", expected, actual) |
| 4697 | } |
| 4698 | |
Paul Duffin | 89886cb | 2021-02-05 16:44:03 +0000 | [diff] [blame] | 4699 | checkDexJarBuildPath(t, ctx, "libfoo") |
Jeongik Cha | d5fe878 | 2021-07-08 01:13:11 +0900 | [diff] [blame] | 4700 | checkDexJarInstallPath(t, ctx, "libfoo") |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4701 | |
| 4702 | checkDexJarBuildPath(t, ctx, "libbar") |
Jeongik Cha | d5fe878 | 2021-07-08 01:13:11 +0900 | [diff] [blame] | 4703 | checkDexJarInstallPath(t, ctx, "libbar") |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4704 | }) |
| 4705 | |
| 4706 | t.Run("prebuilt with source preferred", func(t *testing.T) { |
| 4707 | |
| 4708 | bp := ` |
| 4709 | prebuilt_apex { |
| 4710 | name: "myapex", |
| 4711 | arch: { |
| 4712 | arm64: { |
| 4713 | src: "myapex-arm64.apex", |
| 4714 | }, |
| 4715 | arm: { |
| 4716 | src: "myapex-arm.apex", |
| 4717 | }, |
| 4718 | }, |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4719 | exported_java_libs: ["libfoo", "libbar"], |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4720 | } |
| 4721 | |
| 4722 | java_import { |
| 4723 | name: "libfoo", |
| 4724 | jars: ["libfoo.jar"], |
| 4725 | } |
| 4726 | |
| 4727 | java_library { |
| 4728 | name: "libfoo", |
| 4729 | } |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4730 | |
| 4731 | java_sdk_library_import { |
| 4732 | name: "libbar", |
| 4733 | public: { |
| 4734 | jars: ["libbar.jar"], |
| 4735 | }, |
| 4736 | } |
| 4737 | |
| 4738 | java_sdk_library { |
| 4739 | name: "libbar", |
| 4740 | srcs: ["foo/bar/MyClass.java"], |
| 4741 | unsafe_ignore_missing_latest_api: true, |
| 4742 | } |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4743 | ` |
| 4744 | |
| 4745 | // Make sure that dexpreopt can access dex implementation files from the prebuilt. |
| 4746 | ctx := testDexpreoptWithApexes(t, bp, "", transform) |
| 4747 | |
Paul Duffin | 89886cb | 2021-02-05 16:44:03 +0000 | [diff] [blame] | 4748 | checkDexJarBuildPath(t, ctx, "prebuilt_libfoo") |
Jeongik Cha | d5fe878 | 2021-07-08 01:13:11 +0900 | [diff] [blame] | 4749 | checkDexJarInstallPath(t, ctx, "prebuilt_libfoo") |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4750 | ensureNoSourceVariant(t, ctx, "libfoo") |
| 4751 | |
| 4752 | checkDexJarBuildPath(t, ctx, "prebuilt_libbar") |
Jeongik Cha | d5fe878 | 2021-07-08 01:13:11 +0900 | [diff] [blame] | 4753 | checkDexJarInstallPath(t, ctx, "prebuilt_libbar") |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4754 | ensureNoSourceVariant(t, ctx, "libbar") |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4755 | }) |
| 4756 | |
| 4757 | t.Run("prebuilt preferred with source", func(t *testing.T) { |
| 4758 | bp := ` |
| 4759 | prebuilt_apex { |
| 4760 | name: "myapex", |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4761 | arch: { |
| 4762 | arm64: { |
| 4763 | src: "myapex-arm64.apex", |
| 4764 | }, |
| 4765 | arm: { |
| 4766 | src: "myapex-arm.apex", |
| 4767 | }, |
| 4768 | }, |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4769 | exported_java_libs: ["libfoo", "libbar"], |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4770 | } |
| 4771 | |
| 4772 | java_import { |
| 4773 | name: "libfoo", |
Paul Duffin | 092153d | 2021-01-26 11:42:39 +0000 | [diff] [blame] | 4774 | prefer: true, |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4775 | jars: ["libfoo.jar"], |
| 4776 | } |
| 4777 | |
| 4778 | java_library { |
| 4779 | name: "libfoo", |
| 4780 | } |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4781 | |
| 4782 | java_sdk_library_import { |
| 4783 | name: "libbar", |
| 4784 | prefer: true, |
| 4785 | public: { |
| 4786 | jars: ["libbar.jar"], |
| 4787 | }, |
| 4788 | } |
| 4789 | |
| 4790 | java_sdk_library { |
| 4791 | name: "libbar", |
| 4792 | srcs: ["foo/bar/MyClass.java"], |
| 4793 | unsafe_ignore_missing_latest_api: true, |
| 4794 | } |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4795 | ` |
| 4796 | |
| 4797 | // Make sure that dexpreopt can access dex implementation files from the prebuilt. |
| 4798 | ctx := testDexpreoptWithApexes(t, bp, "", transform) |
| 4799 | |
Paul Duffin | 89886cb | 2021-02-05 16:44:03 +0000 | [diff] [blame] | 4800 | checkDexJarBuildPath(t, ctx, "prebuilt_libfoo") |
Jeongik Cha | d5fe878 | 2021-07-08 01:13:11 +0900 | [diff] [blame] | 4801 | checkDexJarInstallPath(t, ctx, "prebuilt_libfoo") |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4802 | ensureNoSourceVariant(t, ctx, "libfoo") |
| 4803 | |
| 4804 | checkDexJarBuildPath(t, ctx, "prebuilt_libbar") |
Jeongik Cha | d5fe878 | 2021-07-08 01:13:11 +0900 | [diff] [blame] | 4805 | checkDexJarInstallPath(t, ctx, "prebuilt_libbar") |
Paul Duffin | 3985351 | 2021-02-26 11:09:39 +0000 | [diff] [blame] | 4806 | ensureNoSourceVariant(t, ctx, "libbar") |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 4807 | }) |
| 4808 | } |
| 4809 | |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4810 | func TestBootDexJarsFromSourcesAndPrebuilts(t *testing.T) { |
Paul Duffin | b6f53c0 | 2021-05-14 07:52:42 +0100 | [diff] [blame] | 4811 | preparer := android.GroupFixturePreparers( |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 4812 | java.FixtureConfigureApexBootJars("myapex:libfoo", "myapex:libbar"), |
Paul Duffin | b6f53c0 | 2021-05-14 07:52:42 +0100 | [diff] [blame] | 4813 | // Make sure that the frameworks/base/Android.bp file exists as otherwise hidden API encoding |
| 4814 | // is disabled. |
| 4815 | android.FixtureAddTextFile("frameworks/base/Android.bp", ""), |
| 4816 | ) |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4817 | |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4818 | checkBootDexJarPath := func(t *testing.T, ctx *android.TestContext, stem string, bootDexJarPath string) { |
| 4819 | t.Helper() |
Paul Duffin | 7ebebfd | 2021-04-27 19:36:57 +0100 | [diff] [blame] | 4820 | s := ctx.ModuleForTests("platform-bootclasspath", "android_common") |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4821 | foundLibfooJar := false |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4822 | base := stem + ".jar" |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4823 | for _, output := range s.AllOutputs() { |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4824 | if filepath.Base(output) == base { |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4825 | foundLibfooJar = true |
| 4826 | buildRule := s.Output(output) |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 4827 | android.AssertStringEquals(t, "boot dex jar path", bootDexJarPath, buildRule.Input.String()) |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4828 | } |
| 4829 | } |
| 4830 | if !foundLibfooJar { |
Lukacs T. Berki | 9f6c24a | 2021-08-26 15:07:24 +0200 | [diff] [blame] | 4831 | t.Errorf("Rule for libfoo.jar missing in dex_bootjars singleton outputs %q", android.StringPathsRelativeToTop(ctx.Config().SoongOutDir(), s.AllOutputs())) |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4832 | } |
| 4833 | } |
| 4834 | |
Paul Duffin | 40a3f65 | 2021-07-19 13:11:24 +0100 | [diff] [blame] | 4835 | checkHiddenAPIIndexFromClassesInputs := func(t *testing.T, ctx *android.TestContext, expectedIntermediateInputs string) { |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4836 | t.Helper() |
Paul Duffin | 00b2bfd | 2021-04-12 17:24:36 +0100 | [diff] [blame] | 4837 | platformBootclasspath := ctx.ModuleForTests("platform-bootclasspath", "android_common") |
Paul Duffin | d061d40 | 2021-06-07 21:36:01 +0100 | [diff] [blame] | 4838 | var rule android.TestingBuildParams |
| 4839 | |
| 4840 | rule = platformBootclasspath.Output("hiddenapi-monolithic/index-from-classes.csv") |
| 4841 | java.CheckHiddenAPIRuleInputs(t, "intermediate index", expectedIntermediateInputs, rule) |
Paul Duffin | 4fd997b | 2021-02-03 20:06:33 +0000 | [diff] [blame] | 4842 | } |
| 4843 | |
Paul Duffin | 40a3f65 | 2021-07-19 13:11:24 +0100 | [diff] [blame] | 4844 | checkHiddenAPIIndexFromFlagsInputs := func(t *testing.T, ctx *android.TestContext, expectedIntermediateInputs string) { |
| 4845 | t.Helper() |
| 4846 | platformBootclasspath := ctx.ModuleForTests("platform-bootclasspath", "android_common") |
| 4847 | var rule android.TestingBuildParams |
| 4848 | |
| 4849 | rule = platformBootclasspath.Output("hiddenapi-index.csv") |
| 4850 | java.CheckHiddenAPIRuleInputs(t, "monolithic index", expectedIntermediateInputs, rule) |
| 4851 | } |
| 4852 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4853 | fragment := java.ApexVariantReference{ |
| 4854 | Apex: proptools.StringPtr("myapex"), |
| 4855 | Module: proptools.StringPtr("my-bootclasspath-fragment"), |
| 4856 | } |
| 4857 | |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4858 | t.Run("prebuilt only", func(t *testing.T) { |
| 4859 | bp := ` |
| 4860 | prebuilt_apex { |
| 4861 | name: "myapex", |
| 4862 | arch: { |
| 4863 | arm64: { |
| 4864 | src: "myapex-arm64.apex", |
| 4865 | }, |
| 4866 | arm: { |
| 4867 | src: "myapex-arm.apex", |
| 4868 | }, |
| 4869 | }, |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4870 | exported_bootclasspath_fragments: ["my-bootclasspath-fragment"], |
| 4871 | } |
| 4872 | |
| 4873 | prebuilt_bootclasspath_fragment { |
| 4874 | name: "my-bootclasspath-fragment", |
| 4875 | contents: ["libfoo", "libbar"], |
| 4876 | apex_available: ["myapex"], |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 4877 | hidden_api: { |
| 4878 | annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv", |
| 4879 | metadata: "my-bootclasspath-fragment/metadata.csv", |
| 4880 | index: "my-bootclasspath-fragment/index.csv", |
Paul Duffin | 191be3a | 2021-08-10 16:14:16 +0100 | [diff] [blame] | 4881 | signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv", |
| 4882 | filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv", |
| 4883 | filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv", |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 4884 | }, |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4885 | } |
| 4886 | |
| 4887 | java_import { |
| 4888 | name: "libfoo", |
| 4889 | jars: ["libfoo.jar"], |
| 4890 | apex_available: ["myapex"], |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 4891 | permitted_packages: ["foo"], |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4892 | } |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4893 | |
| 4894 | java_sdk_library_import { |
| 4895 | name: "libbar", |
| 4896 | public: { |
| 4897 | jars: ["libbar.jar"], |
| 4898 | }, |
| 4899 | apex_available: ["myapex"], |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4900 | shared_library: false, |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 4901 | permitted_packages: ["bar"], |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 4902 | } |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4903 | ` |
| 4904 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4905 | ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment) |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 4906 | checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar") |
| 4907 | checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar") |
Paul Duffin | 4fd997b | 2021-02-03 20:06:33 +0000 | [diff] [blame] | 4908 | |
Paul Duffin | 537ea3d | 2021-05-14 10:38:00 +0100 | [diff] [blame] | 4909 | // Verify the correct module jars contribute to the hiddenapi index file. |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 4910 | checkHiddenAPIIndexFromClassesInputs(t, ctx, ``) |
Paul Duffin | 40a3f65 | 2021-07-19 13:11:24 +0100 | [diff] [blame] | 4911 | checkHiddenAPIIndexFromFlagsInputs(t, ctx, ` |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 4912 | my-bootclasspath-fragment/index.csv |
Paul Duffin | 40a3f65 | 2021-07-19 13:11:24 +0100 | [diff] [blame] | 4913 | out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv |
| 4914 | `) |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4915 | }) |
| 4916 | |
Paul Duffin | f58fd9a | 2021-04-06 16:00:22 +0100 | [diff] [blame] | 4917 | t.Run("apex_set only", func(t *testing.T) { |
| 4918 | bp := ` |
| 4919 | apex_set { |
| 4920 | name: "myapex", |
| 4921 | set: "myapex.apks", |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4922 | exported_bootclasspath_fragments: ["my-bootclasspath-fragment"], |
| 4923 | } |
| 4924 | |
| 4925 | prebuilt_bootclasspath_fragment { |
| 4926 | name: "my-bootclasspath-fragment", |
| 4927 | contents: ["libfoo", "libbar"], |
| 4928 | apex_available: ["myapex"], |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 4929 | hidden_api: { |
| 4930 | annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv", |
| 4931 | metadata: "my-bootclasspath-fragment/metadata.csv", |
| 4932 | index: "my-bootclasspath-fragment/index.csv", |
Paul Duffin | 191be3a | 2021-08-10 16:14:16 +0100 | [diff] [blame] | 4933 | signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv", |
| 4934 | filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv", |
| 4935 | filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv", |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 4936 | }, |
Paul Duffin | f58fd9a | 2021-04-06 16:00:22 +0100 | [diff] [blame] | 4937 | } |
| 4938 | |
| 4939 | java_import { |
| 4940 | name: "libfoo", |
| 4941 | jars: ["libfoo.jar"], |
| 4942 | apex_available: ["myapex"], |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 4943 | permitted_packages: ["foo"], |
Paul Duffin | f58fd9a | 2021-04-06 16:00:22 +0100 | [diff] [blame] | 4944 | } |
| 4945 | |
| 4946 | java_sdk_library_import { |
| 4947 | name: "libbar", |
| 4948 | public: { |
| 4949 | jars: ["libbar.jar"], |
| 4950 | }, |
| 4951 | apex_available: ["myapex"], |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4952 | shared_library: false, |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 4953 | permitted_packages: ["bar"], |
Paul Duffin | f58fd9a | 2021-04-06 16:00:22 +0100 | [diff] [blame] | 4954 | } |
| 4955 | ` |
| 4956 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4957 | ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment) |
Paul Duffin | f58fd9a | 2021-04-06 16:00:22 +0100 | [diff] [blame] | 4958 | checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar") |
| 4959 | checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar") |
| 4960 | |
Paul Duffin | 537ea3d | 2021-05-14 10:38:00 +0100 | [diff] [blame] | 4961 | // Verify the correct module jars contribute to the hiddenapi index file. |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 4962 | checkHiddenAPIIndexFromClassesInputs(t, ctx, ``) |
Paul Duffin | 40a3f65 | 2021-07-19 13:11:24 +0100 | [diff] [blame] | 4963 | checkHiddenAPIIndexFromFlagsInputs(t, ctx, ` |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 4964 | my-bootclasspath-fragment/index.csv |
Paul Duffin | 40a3f65 | 2021-07-19 13:11:24 +0100 | [diff] [blame] | 4965 | out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv |
| 4966 | `) |
Paul Duffin | f58fd9a | 2021-04-06 16:00:22 +0100 | [diff] [blame] | 4967 | }) |
| 4968 | |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4969 | t.Run("prebuilt with source library preferred", func(t *testing.T) { |
| 4970 | bp := ` |
| 4971 | prebuilt_apex { |
| 4972 | name: "myapex", |
| 4973 | arch: { |
| 4974 | arm64: { |
| 4975 | src: "myapex-arm64.apex", |
| 4976 | }, |
| 4977 | arm: { |
| 4978 | src: "myapex-arm.apex", |
| 4979 | }, |
| 4980 | }, |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 4981 | exported_bootclasspath_fragments: ["my-bootclasspath-fragment"], |
| 4982 | } |
| 4983 | |
| 4984 | prebuilt_bootclasspath_fragment { |
| 4985 | name: "my-bootclasspath-fragment", |
| 4986 | contents: ["libfoo", "libbar"], |
| 4987 | apex_available: ["myapex"], |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 4988 | hidden_api: { |
| 4989 | annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv", |
| 4990 | metadata: "my-bootclasspath-fragment/metadata.csv", |
| 4991 | index: "my-bootclasspath-fragment/index.csv", |
| 4992 | stub_flags: "my-bootclasspath-fragment/stub-flags.csv", |
| 4993 | all_flags: "my-bootclasspath-fragment/all-flags.csv", |
| 4994 | }, |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 4995 | } |
| 4996 | |
| 4997 | java_import { |
| 4998 | name: "libfoo", |
| 4999 | jars: ["libfoo.jar"], |
| 5000 | apex_available: ["myapex"], |
| 5001 | } |
| 5002 | |
| 5003 | java_library { |
| 5004 | name: "libfoo", |
| 5005 | srcs: ["foo/bar/MyClass.java"], |
| 5006 | apex_available: ["myapex"], |
| 5007 | } |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 5008 | |
| 5009 | java_sdk_library_import { |
| 5010 | name: "libbar", |
| 5011 | public: { |
| 5012 | jars: ["libbar.jar"], |
| 5013 | }, |
| 5014 | apex_available: ["myapex"], |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 5015 | shared_library: false, |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 5016 | } |
| 5017 | |
| 5018 | java_sdk_library { |
| 5019 | name: "libbar", |
| 5020 | srcs: ["foo/bar/MyClass.java"], |
| 5021 | unsafe_ignore_missing_latest_api: true, |
| 5022 | apex_available: ["myapex"], |
| 5023 | } |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 5024 | ` |
| 5025 | |
| 5026 | // In this test the source (java_library) libfoo is active since the |
| 5027 | // prebuilt (java_import) defaults to prefer:false. However the |
| 5028 | // prebuilt_apex module always depends on the prebuilt, and so it doesn't |
| 5029 | // find the dex boot jar in it. We either need to disable the source libfoo |
| 5030 | // or make the prebuilt libfoo preferred. |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 5031 | testDexpreoptWithApexes(t, bp, "module libfoo does not provide a dex boot jar", preparer, fragment) |
Spandan Das | 10ea4bf | 2021-08-20 19:18:16 +0000 | [diff] [blame] | 5032 | // dexbootjar check is skipped if AllowMissingDependencies is true |
| 5033 | preparerAllowMissingDeps := android.GroupFixturePreparers( |
| 5034 | preparer, |
| 5035 | android.PrepareForTestWithAllowMissingDependencies, |
| 5036 | ) |
| 5037 | testDexpreoptWithApexes(t, bp, "", preparerAllowMissingDeps, fragment) |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 5038 | }) |
| 5039 | |
| 5040 | t.Run("prebuilt library preferred with source", func(t *testing.T) { |
| 5041 | bp := ` |
| 5042 | prebuilt_apex { |
| 5043 | name: "myapex", |
| 5044 | arch: { |
| 5045 | arm64: { |
| 5046 | src: "myapex-arm64.apex", |
| 5047 | }, |
| 5048 | arm: { |
| 5049 | src: "myapex-arm.apex", |
| 5050 | }, |
| 5051 | }, |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 5052 | exported_bootclasspath_fragments: ["my-bootclasspath-fragment"], |
| 5053 | } |
| 5054 | |
| 5055 | prebuilt_bootclasspath_fragment { |
| 5056 | name: "my-bootclasspath-fragment", |
| 5057 | contents: ["libfoo", "libbar"], |
| 5058 | apex_available: ["myapex"], |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 5059 | hidden_api: { |
| 5060 | annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv", |
| 5061 | metadata: "my-bootclasspath-fragment/metadata.csv", |
| 5062 | index: "my-bootclasspath-fragment/index.csv", |
Paul Duffin | 191be3a | 2021-08-10 16:14:16 +0100 | [diff] [blame] | 5063 | signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv", |
| 5064 | filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv", |
| 5065 | filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv", |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 5066 | }, |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 5067 | } |
| 5068 | |
| 5069 | java_import { |
| 5070 | name: "libfoo", |
| 5071 | prefer: true, |
| 5072 | jars: ["libfoo.jar"], |
| 5073 | apex_available: ["myapex"], |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 5074 | permitted_packages: ["foo"], |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 5075 | } |
| 5076 | |
| 5077 | java_library { |
| 5078 | name: "libfoo", |
| 5079 | srcs: ["foo/bar/MyClass.java"], |
| 5080 | apex_available: ["myapex"], |
| 5081 | } |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 5082 | |
| 5083 | java_sdk_library_import { |
| 5084 | name: "libbar", |
| 5085 | prefer: true, |
| 5086 | public: { |
| 5087 | jars: ["libbar.jar"], |
| 5088 | }, |
| 5089 | apex_available: ["myapex"], |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 5090 | shared_library: false, |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 5091 | permitted_packages: ["bar"], |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 5092 | } |
| 5093 | |
| 5094 | java_sdk_library { |
| 5095 | name: "libbar", |
| 5096 | srcs: ["foo/bar/MyClass.java"], |
| 5097 | unsafe_ignore_missing_latest_api: true, |
| 5098 | apex_available: ["myapex"], |
| 5099 | } |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 5100 | ` |
| 5101 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 5102 | ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment) |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 5103 | checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar") |
| 5104 | checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar") |
Paul Duffin | 4fd997b | 2021-02-03 20:06:33 +0000 | [diff] [blame] | 5105 | |
Paul Duffin | 537ea3d | 2021-05-14 10:38:00 +0100 | [diff] [blame] | 5106 | // Verify the correct module jars contribute to the hiddenapi index file. |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 5107 | checkHiddenAPIIndexFromClassesInputs(t, ctx, ``) |
Paul Duffin | 40a3f65 | 2021-07-19 13:11:24 +0100 | [diff] [blame] | 5108 | checkHiddenAPIIndexFromFlagsInputs(t, ctx, ` |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 5109 | my-bootclasspath-fragment/index.csv |
Paul Duffin | 40a3f65 | 2021-07-19 13:11:24 +0100 | [diff] [blame] | 5110 | out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv |
| 5111 | `) |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 5112 | }) |
| 5113 | |
| 5114 | t.Run("prebuilt with source apex preferred", func(t *testing.T) { |
| 5115 | bp := ` |
| 5116 | apex { |
| 5117 | name: "myapex", |
| 5118 | key: "myapex.key", |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 5119 | java_libs: ["libfoo", "libbar"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5120 | updatable: false, |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 5121 | } |
| 5122 | |
| 5123 | apex_key { |
| 5124 | name: "myapex.key", |
| 5125 | public_key: "testkey.avbpubkey", |
| 5126 | private_key: "testkey.pem", |
| 5127 | } |
| 5128 | |
| 5129 | prebuilt_apex { |
| 5130 | name: "myapex", |
| 5131 | arch: { |
| 5132 | arm64: { |
| 5133 | src: "myapex-arm64.apex", |
| 5134 | }, |
| 5135 | arm: { |
| 5136 | src: "myapex-arm.apex", |
| 5137 | }, |
| 5138 | }, |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 5139 | exported_bootclasspath_fragments: ["my-bootclasspath-fragment"], |
| 5140 | } |
| 5141 | |
| 5142 | prebuilt_bootclasspath_fragment { |
| 5143 | name: "my-bootclasspath-fragment", |
| 5144 | contents: ["libfoo", "libbar"], |
| 5145 | apex_available: ["myapex"], |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 5146 | hidden_api: { |
| 5147 | annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv", |
| 5148 | metadata: "my-bootclasspath-fragment/metadata.csv", |
| 5149 | index: "my-bootclasspath-fragment/index.csv", |
Paul Duffin | 191be3a | 2021-08-10 16:14:16 +0100 | [diff] [blame] | 5150 | signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv", |
| 5151 | filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv", |
| 5152 | filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv", |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 5153 | }, |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 5154 | } |
| 5155 | |
| 5156 | java_import { |
| 5157 | name: "libfoo", |
| 5158 | jars: ["libfoo.jar"], |
| 5159 | apex_available: ["myapex"], |
| 5160 | } |
| 5161 | |
| 5162 | java_library { |
| 5163 | name: "libfoo", |
| 5164 | srcs: ["foo/bar/MyClass.java"], |
| 5165 | apex_available: ["myapex"], |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 5166 | permitted_packages: ["foo"], |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 5167 | } |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 5168 | |
| 5169 | java_sdk_library_import { |
| 5170 | name: "libbar", |
| 5171 | public: { |
| 5172 | jars: ["libbar.jar"], |
| 5173 | }, |
| 5174 | apex_available: ["myapex"], |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 5175 | shared_library: false, |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 5176 | } |
| 5177 | |
| 5178 | java_sdk_library { |
| 5179 | name: "libbar", |
| 5180 | srcs: ["foo/bar/MyClass.java"], |
| 5181 | unsafe_ignore_missing_latest_api: true, |
| 5182 | apex_available: ["myapex"], |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 5183 | permitted_packages: ["bar"], |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 5184 | } |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 5185 | ` |
| 5186 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 5187 | ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment) |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 5188 | checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/libfoo/android_common_apex10000/hiddenapi/libfoo.jar") |
| 5189 | checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/libbar/android_common_myapex/hiddenapi/libbar.jar") |
Paul Duffin | 4fd997b | 2021-02-03 20:06:33 +0000 | [diff] [blame] | 5190 | |
Paul Duffin | 537ea3d | 2021-05-14 10:38:00 +0100 | [diff] [blame] | 5191 | // Verify the correct module jars contribute to the hiddenapi index file. |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 5192 | checkHiddenAPIIndexFromClassesInputs(t, ctx, ``) |
Paul Duffin | 40a3f65 | 2021-07-19 13:11:24 +0100 | [diff] [blame] | 5193 | checkHiddenAPIIndexFromFlagsInputs(t, ctx, ` |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 5194 | my-bootclasspath-fragment/index.csv |
Paul Duffin | 40a3f65 | 2021-07-19 13:11:24 +0100 | [diff] [blame] | 5195 | out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv |
| 5196 | `) |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 5197 | }) |
| 5198 | |
| 5199 | t.Run("prebuilt preferred with source apex disabled", func(t *testing.T) { |
| 5200 | bp := ` |
| 5201 | apex { |
| 5202 | name: "myapex", |
| 5203 | enabled: false, |
| 5204 | key: "myapex.key", |
Paul Duffin | 8f146b9 | 2021-04-12 17:24:18 +0100 | [diff] [blame] | 5205 | java_libs: ["libfoo", "libbar"], |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 5206 | } |
| 5207 | |
| 5208 | apex_key { |
| 5209 | name: "myapex.key", |
| 5210 | public_key: "testkey.avbpubkey", |
| 5211 | private_key: "testkey.pem", |
| 5212 | } |
| 5213 | |
| 5214 | prebuilt_apex { |
| 5215 | name: "myapex", |
| 5216 | arch: { |
| 5217 | arm64: { |
| 5218 | src: "myapex-arm64.apex", |
| 5219 | }, |
| 5220 | arm: { |
| 5221 | src: "myapex-arm.apex", |
| 5222 | }, |
| 5223 | }, |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 5224 | exported_bootclasspath_fragments: ["my-bootclasspath-fragment"], |
| 5225 | } |
| 5226 | |
| 5227 | prebuilt_bootclasspath_fragment { |
| 5228 | name: "my-bootclasspath-fragment", |
| 5229 | contents: ["libfoo", "libbar"], |
| 5230 | apex_available: ["myapex"], |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 5231 | hidden_api: { |
| 5232 | annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv", |
| 5233 | metadata: "my-bootclasspath-fragment/metadata.csv", |
| 5234 | index: "my-bootclasspath-fragment/index.csv", |
Paul Duffin | 191be3a | 2021-08-10 16:14:16 +0100 | [diff] [blame] | 5235 | signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv", |
| 5236 | filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv", |
| 5237 | filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv", |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 5238 | }, |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 5239 | } |
| 5240 | |
| 5241 | java_import { |
| 5242 | name: "libfoo", |
| 5243 | prefer: true, |
| 5244 | jars: ["libfoo.jar"], |
| 5245 | apex_available: ["myapex"], |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 5246 | permitted_packages: ["foo"], |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 5247 | } |
| 5248 | |
| 5249 | java_library { |
| 5250 | name: "libfoo", |
| 5251 | srcs: ["foo/bar/MyClass.java"], |
| 5252 | apex_available: ["myapex"], |
| 5253 | } |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 5254 | |
| 5255 | java_sdk_library_import { |
| 5256 | name: "libbar", |
| 5257 | prefer: true, |
| 5258 | public: { |
| 5259 | jars: ["libbar.jar"], |
| 5260 | }, |
| 5261 | apex_available: ["myapex"], |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 5262 | shared_library: false, |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 5263 | permitted_packages: ["bar"], |
Paul Duffin | 3785673 | 2021-02-26 14:24:15 +0000 | [diff] [blame] | 5264 | } |
| 5265 | |
| 5266 | java_sdk_library { |
| 5267 | name: "libbar", |
| 5268 | srcs: ["foo/bar/MyClass.java"], |
| 5269 | unsafe_ignore_missing_latest_api: true, |
| 5270 | apex_available: ["myapex"], |
| 5271 | } |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 5272 | ` |
| 5273 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 5274 | ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment) |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 5275 | checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar") |
| 5276 | checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar") |
Paul Duffin | 4fd997b | 2021-02-03 20:06:33 +0000 | [diff] [blame] | 5277 | |
Paul Duffin | 537ea3d | 2021-05-14 10:38:00 +0100 | [diff] [blame] | 5278 | // Verify the correct module jars contribute to the hiddenapi index file. |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 5279 | checkHiddenAPIIndexFromClassesInputs(t, ctx, ``) |
Paul Duffin | 40a3f65 | 2021-07-19 13:11:24 +0100 | [diff] [blame] | 5280 | checkHiddenAPIIndexFromFlagsInputs(t, ctx, ` |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 5281 | my-bootclasspath-fragment/index.csv |
Paul Duffin | 40a3f65 | 2021-07-19 13:11:24 +0100 | [diff] [blame] | 5282 | out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv |
| 5283 | `) |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 5284 | }) |
| 5285 | } |
| 5286 | |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 5287 | func TestApexWithTests(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5288 | ctx := testApex(t, ` |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 5289 | apex_test { |
| 5290 | name: "myapex", |
| 5291 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5292 | updatable: false, |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 5293 | tests: [ |
| 5294 | "mytest", |
Roland Levillain | 9b5fde9 | 2019-06-28 15:41:19 +0100 | [diff] [blame] | 5295 | "mytests", |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 5296 | ], |
| 5297 | } |
| 5298 | |
| 5299 | apex_key { |
| 5300 | name: "myapex.key", |
| 5301 | public_key: "testkey.avbpubkey", |
| 5302 | private_key: "testkey.pem", |
| 5303 | } |
| 5304 | |
Liz Kammer | 1c14a21 | 2020-05-12 15:26:55 -0700 | [diff] [blame] | 5305 | filegroup { |
| 5306 | name: "fg", |
| 5307 | srcs: [ |
| 5308 | "baz", |
| 5309 | "bar/baz" |
| 5310 | ], |
| 5311 | } |
| 5312 | |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 5313 | cc_test { |
| 5314 | name: "mytest", |
| 5315 | gtest: false, |
| 5316 | srcs: ["mytest.cpp"], |
| 5317 | relative_install_path: "test", |
Jiyong Park | af9539f | 2020-05-04 10:31:32 +0900 | [diff] [blame] | 5318 | shared_libs: ["mylib"], |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 5319 | system_shared_libs: [], |
| 5320 | static_executable: true, |
| 5321 | stl: "none", |
Liz Kammer | 1c14a21 | 2020-05-12 15:26:55 -0700 | [diff] [blame] | 5322 | data: [":fg"], |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 5323 | } |
Roland Levillain | 9b5fde9 | 2019-06-28 15:41:19 +0100 | [diff] [blame] | 5324 | |
Jiyong Park | af9539f | 2020-05-04 10:31:32 +0900 | [diff] [blame] | 5325 | cc_library { |
| 5326 | name: "mylib", |
| 5327 | srcs: ["mylib.cpp"], |
| 5328 | system_shared_libs: [], |
| 5329 | stl: "none", |
| 5330 | } |
| 5331 | |
Liz Kammer | 5bd365f | 2020-05-27 15:15:11 -0700 | [diff] [blame] | 5332 | filegroup { |
| 5333 | name: "fg2", |
| 5334 | srcs: [ |
| 5335 | "testdata/baz" |
| 5336 | ], |
| 5337 | } |
| 5338 | |
Roland Levillain | 9b5fde9 | 2019-06-28 15:41:19 +0100 | [diff] [blame] | 5339 | cc_test { |
| 5340 | name: "mytests", |
| 5341 | gtest: false, |
| 5342 | srcs: [ |
| 5343 | "mytest1.cpp", |
| 5344 | "mytest2.cpp", |
| 5345 | "mytest3.cpp", |
| 5346 | ], |
| 5347 | test_per_src: true, |
| 5348 | relative_install_path: "test", |
| 5349 | system_shared_libs: [], |
| 5350 | static_executable: true, |
| 5351 | stl: "none", |
Liz Kammer | 5bd365f | 2020-05-27 15:15:11 -0700 | [diff] [blame] | 5352 | data: [ |
| 5353 | ":fg", |
| 5354 | ":fg2", |
| 5355 | ], |
Roland Levillain | 9b5fde9 | 2019-06-28 15:41:19 +0100 | [diff] [blame] | 5356 | } |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 5357 | `) |
| 5358 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 5359 | apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule") |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 5360 | copyCmds := apexRule.Args["copy_commands"] |
| 5361 | |
Jiyong Park | af9539f | 2020-05-04 10:31:32 +0900 | [diff] [blame] | 5362 | // Ensure that test dep (and their transitive dependencies) are copied into apex. |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 5363 | ensureContains(t, copyCmds, "image.apex/bin/test/mytest") |
Jiyong Park | af9539f | 2020-05-04 10:31:32 +0900 | [diff] [blame] | 5364 | ensureContains(t, copyCmds, "image.apex/lib64/mylib.so") |
Roland Levillain | 9b5fde9 | 2019-06-28 15:41:19 +0100 | [diff] [blame] | 5365 | |
Liz Kammer | 1c14a21 | 2020-05-12 15:26:55 -0700 | [diff] [blame] | 5366 | //Ensure that test data are copied into apex. |
| 5367 | ensureContains(t, copyCmds, "image.apex/bin/test/baz") |
| 5368 | ensureContains(t, copyCmds, "image.apex/bin/test/bar/baz") |
| 5369 | |
Roland Levillain | 9b5fde9 | 2019-06-28 15:41:19 +0100 | [diff] [blame] | 5370 | // Ensure that test deps built with `test_per_src` are copied into apex. |
| 5371 | ensureContains(t, copyCmds, "image.apex/bin/test/mytest1") |
| 5372 | ensureContains(t, copyCmds, "image.apex/bin/test/mytest2") |
| 5373 | ensureContains(t, copyCmds, "image.apex/bin/test/mytest3") |
Roland Levillain | f89cd09 | 2019-07-29 16:22:59 +0100 | [diff] [blame] | 5374 | |
| 5375 | // Ensure the module is correctly translated. |
Liz Kammer | 81faaaf | 2020-05-20 09:57:08 -0700 | [diff] [blame] | 5376 | bundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 5377 | data := android.AndroidMkDataForTest(t, ctx, bundle) |
Liz Kammer | 81faaaf | 2020-05-20 09:57:08 -0700 | [diff] [blame] | 5378 | name := bundle.BaseModuleName() |
Roland Levillain | f89cd09 | 2019-07-29 16:22:59 +0100 | [diff] [blame] | 5379 | prefix := "TARGET_" |
| 5380 | var builder strings.Builder |
| 5381 | data.Custom(&builder, name, prefix, "", data) |
| 5382 | androidMk := builder.String() |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 5383 | ensureContains(t, androidMk, "LOCAL_MODULE := mytest.myapex\n") |
| 5384 | ensureContains(t, androidMk, "LOCAL_MODULE := mytest1.myapex\n") |
| 5385 | ensureContains(t, androidMk, "LOCAL_MODULE := mytest2.myapex\n") |
| 5386 | ensureContains(t, androidMk, "LOCAL_MODULE := mytest3.myapex\n") |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 5387 | ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex\n") |
Jooyung Han | 31c470b | 2019-10-18 16:26:59 +0900 | [diff] [blame] | 5388 | ensureContains(t, androidMk, "LOCAL_MODULE := apex_pubkey.myapex\n") |
Roland Levillain | f89cd09 | 2019-07-29 16:22:59 +0100 | [diff] [blame] | 5389 | ensureContains(t, androidMk, "LOCAL_MODULE := myapex\n") |
Liz Kammer | 81faaaf | 2020-05-20 09:57:08 -0700 | [diff] [blame] | 5390 | |
| 5391 | flatBundle := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 5392 | data = android.AndroidMkDataForTest(t, ctx, flatBundle) |
Liz Kammer | 81faaaf | 2020-05-20 09:57:08 -0700 | [diff] [blame] | 5393 | data.Custom(&builder, name, prefix, "", data) |
| 5394 | flatAndroidMk := builder.String() |
Liz Kammer | 5bd365f | 2020-05-27 15:15:11 -0700 | [diff] [blame] | 5395 | ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :baz :bar/baz\n") |
| 5396 | ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :testdata/baz\n") |
Roland Levillain | 630846d | 2019-06-26 12:48:34 +0100 | [diff] [blame] | 5397 | } |
| 5398 | |
Jooyung Han | 3ab2c3e | 2019-12-05 16:27:44 +0900 | [diff] [blame] | 5399 | func TestInstallExtraFlattenedApexes(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5400 | ctx := testApex(t, ` |
Jooyung Han | 3ab2c3e | 2019-12-05 16:27:44 +0900 | [diff] [blame] | 5401 | apex { |
| 5402 | name: "myapex", |
| 5403 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5404 | updatable: false, |
Jooyung Han | 3ab2c3e | 2019-12-05 16:27:44 +0900 | [diff] [blame] | 5405 | } |
| 5406 | apex_key { |
| 5407 | name: "myapex.key", |
| 5408 | public_key: "testkey.avbpubkey", |
| 5409 | private_key: "testkey.pem", |
| 5410 | } |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 5411 | `, |
| 5412 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 5413 | variables.InstallExtraFlattenedApexes = proptools.BoolPtr(true) |
| 5414 | }), |
| 5415 | ) |
Jooyung Han | 3ab2c3e | 2019-12-05 16:27:44 +0900 | [diff] [blame] | 5416 | ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Jiyong Park | 83dc74b | 2020-01-14 18:38:44 +0900 | [diff] [blame] | 5417 | ensureListContains(t, ab.requiredDeps, "myapex.flattened") |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 5418 | mk := android.AndroidMkDataForTest(t, ctx, ab) |
Jooyung Han | 3ab2c3e | 2019-12-05 16:27:44 +0900 | [diff] [blame] | 5419 | var builder strings.Builder |
| 5420 | mk.Custom(&builder, ab.Name(), "TARGET_", "", mk) |
| 5421 | androidMk := builder.String() |
| 5422 | ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += myapex.flattened") |
| 5423 | } |
| 5424 | |
Jooyung Han | d48f3c3 | 2019-08-23 11:18:57 +0900 | [diff] [blame] | 5425 | func TestErrorsIfDepsAreNotEnabled(t *testing.T) { |
| 5426 | testApexError(t, `module "myapex" .* depends on disabled module "libfoo"`, ` |
| 5427 | apex { |
| 5428 | name: "myapex", |
| 5429 | key: "myapex.key", |
| 5430 | native_shared_libs: ["libfoo"], |
| 5431 | } |
| 5432 | |
| 5433 | apex_key { |
| 5434 | name: "myapex.key", |
| 5435 | public_key: "testkey.avbpubkey", |
| 5436 | private_key: "testkey.pem", |
| 5437 | } |
| 5438 | |
| 5439 | cc_library { |
| 5440 | name: "libfoo", |
| 5441 | stl: "none", |
| 5442 | system_shared_libs: [], |
| 5443 | enabled: false, |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 5444 | apex_available: ["myapex"], |
Jooyung Han | d48f3c3 | 2019-08-23 11:18:57 +0900 | [diff] [blame] | 5445 | } |
| 5446 | `) |
| 5447 | testApexError(t, `module "myapex" .* depends on disabled module "myjar"`, ` |
| 5448 | apex { |
| 5449 | name: "myapex", |
| 5450 | key: "myapex.key", |
| 5451 | java_libs: ["myjar"], |
| 5452 | } |
| 5453 | |
| 5454 | apex_key { |
| 5455 | name: "myapex.key", |
| 5456 | public_key: "testkey.avbpubkey", |
| 5457 | private_key: "testkey.pem", |
| 5458 | } |
| 5459 | |
| 5460 | java_library { |
| 5461 | name: "myjar", |
| 5462 | srcs: ["foo/bar/MyClass.java"], |
| 5463 | sdk_version: "none", |
| 5464 | system_modules: "none", |
Jooyung Han | d48f3c3 | 2019-08-23 11:18:57 +0900 | [diff] [blame] | 5465 | enabled: false, |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 5466 | apex_available: ["myapex"], |
Jooyung Han | d48f3c3 | 2019-08-23 11:18:57 +0900 | [diff] [blame] | 5467 | } |
| 5468 | `) |
| 5469 | } |
| 5470 | |
Bill Peckham | a41a696 | 2021-01-11 10:58:54 -0800 | [diff] [blame] | 5471 | func TestApexWithJavaImport(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5472 | ctx := testApex(t, ` |
Bill Peckham | a41a696 | 2021-01-11 10:58:54 -0800 | [diff] [blame] | 5473 | apex { |
| 5474 | name: "myapex", |
| 5475 | key: "myapex.key", |
| 5476 | java_libs: ["myjavaimport"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5477 | updatable: false, |
Bill Peckham | a41a696 | 2021-01-11 10:58:54 -0800 | [diff] [blame] | 5478 | } |
| 5479 | |
| 5480 | apex_key { |
| 5481 | name: "myapex.key", |
| 5482 | public_key: "testkey.avbpubkey", |
| 5483 | private_key: "testkey.pem", |
| 5484 | } |
| 5485 | |
| 5486 | java_import { |
| 5487 | name: "myjavaimport", |
| 5488 | apex_available: ["myapex"], |
| 5489 | jars: ["my.jar"], |
| 5490 | compile_dex: true, |
| 5491 | } |
| 5492 | `) |
| 5493 | |
| 5494 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
| 5495 | apexRule := module.Rule("apexRule") |
| 5496 | copyCmds := apexRule.Args["copy_commands"] |
| 5497 | ensureContains(t, copyCmds, "image.apex/javalib/myjavaimport.jar") |
| 5498 | } |
| 5499 | |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5500 | func TestApexWithApps(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5501 | ctx := testApex(t, ` |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5502 | apex { |
| 5503 | name: "myapex", |
| 5504 | key: "myapex.key", |
| 5505 | apps: [ |
| 5506 | "AppFoo", |
Jiyong Park | f748731 | 2019-10-17 12:54:30 +0900 | [diff] [blame] | 5507 | "AppFooPriv", |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5508 | ], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5509 | updatable: false, |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5510 | } |
| 5511 | |
| 5512 | apex_key { |
| 5513 | name: "myapex.key", |
| 5514 | public_key: "testkey.avbpubkey", |
| 5515 | private_key: "testkey.pem", |
| 5516 | } |
| 5517 | |
| 5518 | android_app { |
| 5519 | name: "AppFoo", |
| 5520 | srcs: ["foo/bar/MyClass.java"], |
Colin Cross | 094cde4 | 2020-02-15 10:38:00 -0800 | [diff] [blame] | 5521 | sdk_version: "current", |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5522 | system_modules: "none", |
Jiyong Park | 8be103b | 2019-11-08 15:53:48 +0900 | [diff] [blame] | 5523 | jni_libs: ["libjni"], |
Colin Cross | 094cde4 | 2020-02-15 10:38:00 -0800 | [diff] [blame] | 5524 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 5525 | apex_available: [ "myapex" ], |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5526 | } |
Jiyong Park | f748731 | 2019-10-17 12:54:30 +0900 | [diff] [blame] | 5527 | |
| 5528 | android_app { |
| 5529 | name: "AppFooPriv", |
| 5530 | srcs: ["foo/bar/MyClass.java"], |
Colin Cross | 094cde4 | 2020-02-15 10:38:00 -0800 | [diff] [blame] | 5531 | sdk_version: "current", |
Jiyong Park | f748731 | 2019-10-17 12:54:30 +0900 | [diff] [blame] | 5532 | system_modules: "none", |
| 5533 | privileged: true, |
Colin Cross | 094cde4 | 2020-02-15 10:38:00 -0800 | [diff] [blame] | 5534 | stl: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 5535 | apex_available: [ "myapex" ], |
Jiyong Park | f748731 | 2019-10-17 12:54:30 +0900 | [diff] [blame] | 5536 | } |
Jiyong Park | 8be103b | 2019-11-08 15:53:48 +0900 | [diff] [blame] | 5537 | |
| 5538 | cc_library_shared { |
| 5539 | name: "libjni", |
| 5540 | srcs: ["mylib.cpp"], |
Jooyung Han | b7bebe2 | 2020-02-25 16:59:29 +0900 | [diff] [blame] | 5541 | shared_libs: ["libfoo"], |
| 5542 | stl: "none", |
| 5543 | system_shared_libs: [], |
| 5544 | apex_available: [ "myapex" ], |
| 5545 | sdk_version: "current", |
| 5546 | } |
| 5547 | |
| 5548 | cc_library_shared { |
| 5549 | name: "libfoo", |
Jiyong Park | 8be103b | 2019-11-08 15:53:48 +0900 | [diff] [blame] | 5550 | stl: "none", |
| 5551 | system_shared_libs: [], |
Jiyong Park | 0f80c18 | 2020-01-31 02:49:53 +0900 | [diff] [blame] | 5552 | apex_available: [ "myapex" ], |
Colin Cross | 094cde4 | 2020-02-15 10:38:00 -0800 | [diff] [blame] | 5553 | sdk_version: "current", |
Jiyong Park | 8be103b | 2019-11-08 15:53:48 +0900 | [diff] [blame] | 5554 | } |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5555 | `) |
| 5556 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 5557 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5558 | apexRule := module.Rule("apexRule") |
| 5559 | copyCmds := apexRule.Args["copy_commands"] |
| 5560 | |
| 5561 | ensureContains(t, copyCmds, "image.apex/app/AppFoo/AppFoo.apk") |
Jiyong Park | f748731 | 2019-10-17 12:54:30 +0900 | [diff] [blame] | 5562 | ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPriv/AppFooPriv.apk") |
Jiyong Park | 52cd06f | 2019-11-11 10:14:32 +0900 | [diff] [blame] | 5563 | |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 5564 | appZipRule := ctx.ModuleForTests("AppFoo", "android_common_apex10000").Description("zip jni libs") |
Jooyung Han | b7bebe2 | 2020-02-25 16:59:29 +0900 | [diff] [blame] | 5565 | // JNI libraries are uncompressed |
Jiyong Park | 52cd06f | 2019-11-11 10:14:32 +0900 | [diff] [blame] | 5566 | if args := appZipRule.Args["jarArgs"]; !strings.Contains(args, "-L 0") { |
Jooyung Han | b7bebe2 | 2020-02-25 16:59:29 +0900 | [diff] [blame] | 5567 | t.Errorf("jni libs are not uncompressed for AppFoo") |
Jiyong Park | 52cd06f | 2019-11-11 10:14:32 +0900 | [diff] [blame] | 5568 | } |
Jooyung Han | b7bebe2 | 2020-02-25 16:59:29 +0900 | [diff] [blame] | 5569 | // JNI libraries including transitive deps are |
| 5570 | for _, jni := range []string{"libjni", "libfoo"} { |
Paul Duffin | afdd406 | 2021-03-30 19:44:07 +0100 | [diff] [blame] | 5571 | jniOutput := ctx.ModuleForTests(jni, "android_arm64_armv8-a_sdk_shared_apex10000").Module().(*cc.Module).OutputFile().RelativeToTop() |
Jooyung Han | b7bebe2 | 2020-02-25 16:59:29 +0900 | [diff] [blame] | 5572 | // ... embedded inside APK (jnilibs.zip) |
| 5573 | ensureListContains(t, appZipRule.Implicits.Strings(), jniOutput.String()) |
| 5574 | // ... and not directly inside the APEX |
| 5575 | ensureNotContains(t, copyCmds, "image.apex/lib64/"+jni+".so") |
| 5576 | } |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 5577 | } |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5578 | |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 5579 | func TestApexWithAppImports(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5580 | ctx := testApex(t, ` |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 5581 | apex { |
| 5582 | name: "myapex", |
| 5583 | key: "myapex.key", |
| 5584 | apps: [ |
| 5585 | "AppFooPrebuilt", |
| 5586 | "AppFooPrivPrebuilt", |
| 5587 | ], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5588 | updatable: false, |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 5589 | } |
| 5590 | |
| 5591 | apex_key { |
| 5592 | name: "myapex.key", |
| 5593 | public_key: "testkey.avbpubkey", |
| 5594 | private_key: "testkey.pem", |
| 5595 | } |
| 5596 | |
| 5597 | android_app_import { |
| 5598 | name: "AppFooPrebuilt", |
| 5599 | apk: "PrebuiltAppFoo.apk", |
| 5600 | presigned: true, |
| 5601 | dex_preopt: { |
| 5602 | enabled: false, |
| 5603 | }, |
Jiyong Park | 592a6a4 | 2020-04-21 22:34:28 +0900 | [diff] [blame] | 5604 | apex_available: ["myapex"], |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 5605 | } |
| 5606 | |
| 5607 | android_app_import { |
| 5608 | name: "AppFooPrivPrebuilt", |
| 5609 | apk: "PrebuiltAppFooPriv.apk", |
| 5610 | privileged: true, |
| 5611 | presigned: true, |
| 5612 | dex_preopt: { |
| 5613 | enabled: false, |
| 5614 | }, |
Jooyung Han | 39ee119 | 2020-03-23 20:21:11 +0900 | [diff] [blame] | 5615 | filename: "AwesomePrebuiltAppFooPriv.apk", |
Jiyong Park | 592a6a4 | 2020-04-21 22:34:28 +0900 | [diff] [blame] | 5616 | apex_available: ["myapex"], |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 5617 | } |
| 5618 | `) |
| 5619 | |
Sundong Ahn | abb6443 | 2019-10-22 13:58:29 +0900 | [diff] [blame] | 5620 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Dario Freni | cde2a03 | 2019-10-27 00:29:22 +0100 | [diff] [blame] | 5621 | apexRule := module.Rule("apexRule") |
| 5622 | copyCmds := apexRule.Args["copy_commands"] |
| 5623 | |
| 5624 | ensureContains(t, copyCmds, "image.apex/app/AppFooPrebuilt/AppFooPrebuilt.apk") |
Jooyung Han | 39ee119 | 2020-03-23 20:21:11 +0900 | [diff] [blame] | 5625 | ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPrivPrebuilt/AwesomePrebuiltAppFooPriv.apk") |
| 5626 | } |
| 5627 | |
| 5628 | func TestApexWithAppImportsPrefer(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5629 | ctx := testApex(t, ` |
Jooyung Han | 39ee119 | 2020-03-23 20:21:11 +0900 | [diff] [blame] | 5630 | apex { |
| 5631 | name: "myapex", |
| 5632 | key: "myapex.key", |
| 5633 | apps: [ |
| 5634 | "AppFoo", |
| 5635 | ], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5636 | updatable: false, |
Jooyung Han | 39ee119 | 2020-03-23 20:21:11 +0900 | [diff] [blame] | 5637 | } |
| 5638 | |
| 5639 | apex_key { |
| 5640 | name: "myapex.key", |
| 5641 | public_key: "testkey.avbpubkey", |
| 5642 | private_key: "testkey.pem", |
| 5643 | } |
| 5644 | |
| 5645 | android_app { |
| 5646 | name: "AppFoo", |
| 5647 | srcs: ["foo/bar/MyClass.java"], |
| 5648 | sdk_version: "none", |
| 5649 | system_modules: "none", |
| 5650 | apex_available: [ "myapex" ], |
| 5651 | } |
| 5652 | |
| 5653 | android_app_import { |
| 5654 | name: "AppFoo", |
| 5655 | apk: "AppFooPrebuilt.apk", |
| 5656 | filename: "AppFooPrebuilt.apk", |
| 5657 | presigned: true, |
| 5658 | prefer: true, |
Jiyong Park | 592a6a4 | 2020-04-21 22:34:28 +0900 | [diff] [blame] | 5659 | apex_available: ["myapex"], |
Jooyung Han | 39ee119 | 2020-03-23 20:21:11 +0900 | [diff] [blame] | 5660 | } |
| 5661 | `, withFiles(map[string][]byte{ |
| 5662 | "AppFooPrebuilt.apk": nil, |
| 5663 | })) |
| 5664 | |
| 5665 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
Jooyung Han | 86feead | 2021-03-08 13:11:48 +0900 | [diff] [blame] | 5666 | "app/AppFoo/AppFooPrebuilt.apk", |
Jooyung Han | 39ee119 | 2020-03-23 20:21:11 +0900 | [diff] [blame] | 5667 | }) |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 5668 | } |
| 5669 | |
Dario Freni | 6f3937c | 2019-12-20 22:58:03 +0000 | [diff] [blame] | 5670 | func TestApexWithTestHelperApp(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5671 | ctx := testApex(t, ` |
Dario Freni | 6f3937c | 2019-12-20 22:58:03 +0000 | [diff] [blame] | 5672 | apex { |
| 5673 | name: "myapex", |
| 5674 | key: "myapex.key", |
| 5675 | apps: [ |
| 5676 | "TesterHelpAppFoo", |
| 5677 | ], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5678 | updatable: false, |
Dario Freni | 6f3937c | 2019-12-20 22:58:03 +0000 | [diff] [blame] | 5679 | } |
| 5680 | |
| 5681 | apex_key { |
| 5682 | name: "myapex.key", |
| 5683 | public_key: "testkey.avbpubkey", |
| 5684 | private_key: "testkey.pem", |
| 5685 | } |
| 5686 | |
| 5687 | android_test_helper_app { |
| 5688 | name: "TesterHelpAppFoo", |
| 5689 | srcs: ["foo/bar/MyClass.java"], |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 5690 | apex_available: [ "myapex" ], |
Dario Freni | 6f3937c | 2019-12-20 22:58:03 +0000 | [diff] [blame] | 5691 | } |
| 5692 | |
| 5693 | `) |
| 5694 | |
| 5695 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
| 5696 | apexRule := module.Rule("apexRule") |
| 5697 | copyCmds := apexRule.Args["copy_commands"] |
| 5698 | |
| 5699 | ensureContains(t, copyCmds, "image.apex/app/TesterHelpAppFoo/TesterHelpAppFoo.apk") |
| 5700 | } |
| 5701 | |
Jooyung Han | 18020ea | 2019-11-13 10:50:48 +0900 | [diff] [blame] | 5702 | func TestApexPropertiesShouldBeDefaultable(t *testing.T) { |
| 5703 | // libfoo's apex_available comes from cc_defaults |
Steven Moreland | 6e36cd6 | 2020-10-22 01:08:35 +0000 | [diff] [blame] | 5704 | testApexError(t, `requires "libfoo" that doesn't list the APEX under 'apex_available'.`, ` |
Jooyung Han | 18020ea | 2019-11-13 10:50:48 +0900 | [diff] [blame] | 5705 | apex { |
| 5706 | name: "myapex", |
| 5707 | key: "myapex.key", |
| 5708 | native_shared_libs: ["libfoo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5709 | updatable: false, |
Jooyung Han | 18020ea | 2019-11-13 10:50:48 +0900 | [diff] [blame] | 5710 | } |
| 5711 | |
| 5712 | apex_key { |
| 5713 | name: "myapex.key", |
| 5714 | public_key: "testkey.avbpubkey", |
| 5715 | private_key: "testkey.pem", |
| 5716 | } |
| 5717 | |
| 5718 | apex { |
| 5719 | name: "otherapex", |
| 5720 | key: "myapex.key", |
| 5721 | native_shared_libs: ["libfoo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5722 | updatable: false, |
Jooyung Han | 18020ea | 2019-11-13 10:50:48 +0900 | [diff] [blame] | 5723 | } |
| 5724 | |
| 5725 | cc_defaults { |
| 5726 | name: "libfoo-defaults", |
| 5727 | apex_available: ["otherapex"], |
| 5728 | } |
| 5729 | |
| 5730 | cc_library { |
| 5731 | name: "libfoo", |
| 5732 | defaults: ["libfoo-defaults"], |
| 5733 | stl: "none", |
| 5734 | system_shared_libs: [], |
| 5735 | }`) |
| 5736 | } |
| 5737 | |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 5738 | func TestApexAvailable_DirectDep(t *testing.T) { |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5739 | // libfoo is not available to myapex, but only to otherapex |
Steven Moreland | 6e36cd6 | 2020-10-22 01:08:35 +0000 | [diff] [blame] | 5740 | testApexError(t, "requires \"libfoo\" that doesn't list the APEX under 'apex_available'.", ` |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5741 | apex { |
| 5742 | name: "myapex", |
| 5743 | key: "myapex.key", |
| 5744 | native_shared_libs: ["libfoo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5745 | updatable: false, |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5746 | } |
| 5747 | |
| 5748 | apex_key { |
| 5749 | name: "myapex.key", |
| 5750 | public_key: "testkey.avbpubkey", |
| 5751 | private_key: "testkey.pem", |
| 5752 | } |
| 5753 | |
| 5754 | apex { |
| 5755 | name: "otherapex", |
| 5756 | key: "otherapex.key", |
| 5757 | native_shared_libs: ["libfoo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5758 | updatable: false, |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5759 | } |
| 5760 | |
| 5761 | apex_key { |
| 5762 | name: "otherapex.key", |
| 5763 | public_key: "testkey.avbpubkey", |
| 5764 | private_key: "testkey.pem", |
| 5765 | } |
| 5766 | |
| 5767 | cc_library { |
| 5768 | name: "libfoo", |
| 5769 | stl: "none", |
| 5770 | system_shared_libs: [], |
| 5771 | apex_available: ["otherapex"], |
| 5772 | }`) |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 5773 | } |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5774 | |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 5775 | func TestApexAvailable_IndirectDep(t *testing.T) { |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 5776 | // libbbaz is an indirect dep |
Jiyong Park | 767dbd9 | 2021-03-04 13:03:10 +0900 | [diff] [blame] | 5777 | testApexError(t, `requires "libbaz" that doesn't list the APEX under 'apex_available'.\n\nDependency path: |
Colin Cross | 6e511a9 | 2020-07-27 21:26:48 -0700 | [diff] [blame] | 5778 | .*via tag apex\.dependencyTag.*name:sharedLib.* |
Paul Duffin | df915ff | 2020-03-30 17:58:21 +0100 | [diff] [blame] | 5779 | .*-> libfoo.*link:shared.* |
Colin Cross | 6e511a9 | 2020-07-27 21:26:48 -0700 | [diff] [blame] | 5780 | .*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.* |
Paul Duffin | df915ff | 2020-03-30 17:58:21 +0100 | [diff] [blame] | 5781 | .*-> libbar.*link:shared.* |
Colin Cross | 6e511a9 | 2020-07-27 21:26:48 -0700 | [diff] [blame] | 5782 | .*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.* |
Paul Duffin | 6534770 | 2020-03-31 15:23:40 +0100 | [diff] [blame] | 5783 | .*-> libbaz.*link:shared.*`, ` |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5784 | apex { |
| 5785 | name: "myapex", |
| 5786 | key: "myapex.key", |
| 5787 | native_shared_libs: ["libfoo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5788 | updatable: false, |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5789 | } |
| 5790 | |
| 5791 | apex_key { |
| 5792 | name: "myapex.key", |
| 5793 | public_key: "testkey.avbpubkey", |
| 5794 | private_key: "testkey.pem", |
| 5795 | } |
| 5796 | |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5797 | cc_library { |
| 5798 | name: "libfoo", |
| 5799 | stl: "none", |
| 5800 | shared_libs: ["libbar"], |
| 5801 | system_shared_libs: [], |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 5802 | apex_available: ["myapex"], |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5803 | } |
| 5804 | |
| 5805 | cc_library { |
| 5806 | name: "libbar", |
| 5807 | stl: "none", |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 5808 | shared_libs: ["libbaz"], |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5809 | system_shared_libs: [], |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 5810 | apex_available: ["myapex"], |
| 5811 | } |
| 5812 | |
| 5813 | cc_library { |
| 5814 | name: "libbaz", |
| 5815 | stl: "none", |
| 5816 | system_shared_libs: [], |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5817 | }`) |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 5818 | } |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5819 | |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 5820 | func TestApexAvailable_InvalidApexName(t *testing.T) { |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5821 | testApexError(t, "\"otherapex\" is not a valid module name", ` |
| 5822 | apex { |
| 5823 | name: "myapex", |
| 5824 | key: "myapex.key", |
| 5825 | native_shared_libs: ["libfoo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5826 | updatable: false, |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5827 | } |
| 5828 | |
| 5829 | apex_key { |
| 5830 | name: "myapex.key", |
| 5831 | public_key: "testkey.avbpubkey", |
| 5832 | private_key: "testkey.pem", |
| 5833 | } |
| 5834 | |
| 5835 | cc_library { |
| 5836 | name: "libfoo", |
| 5837 | stl: "none", |
| 5838 | system_shared_libs: [], |
| 5839 | apex_available: ["otherapex"], |
| 5840 | }`) |
| 5841 | |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 5842 | testApex(t, ` |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5843 | apex { |
| 5844 | name: "myapex", |
| 5845 | key: "myapex.key", |
| 5846 | native_shared_libs: ["libfoo", "libbar"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5847 | updatable: false, |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5848 | } |
| 5849 | |
| 5850 | apex_key { |
| 5851 | name: "myapex.key", |
| 5852 | public_key: "testkey.avbpubkey", |
| 5853 | private_key: "testkey.pem", |
| 5854 | } |
| 5855 | |
| 5856 | cc_library { |
| 5857 | name: "libfoo", |
| 5858 | stl: "none", |
| 5859 | system_shared_libs: [], |
Jiyong Park | 323a4c3 | 2020-03-01 17:29:06 +0900 | [diff] [blame] | 5860 | runtime_libs: ["libbaz"], |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5861 | apex_available: ["myapex"], |
| 5862 | } |
| 5863 | |
| 5864 | cc_library { |
| 5865 | name: "libbar", |
| 5866 | stl: "none", |
| 5867 | system_shared_libs: [], |
| 5868 | apex_available: ["//apex_available:anyapex"], |
Jiyong Park | 323a4c3 | 2020-03-01 17:29:06 +0900 | [diff] [blame] | 5869 | } |
| 5870 | |
| 5871 | cc_library { |
| 5872 | name: "libbaz", |
| 5873 | stl: "none", |
| 5874 | system_shared_libs: [], |
| 5875 | stubs: { |
| 5876 | versions: ["10", "20", "30"], |
| 5877 | }, |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5878 | }`) |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 5879 | } |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5880 | |
Jiyong Park | 89e850a | 2020-04-07 16:37:39 +0900 | [diff] [blame] | 5881 | func TestApexAvailable_CheckForPlatform(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5882 | ctx := testApex(t, ` |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5883 | apex { |
| 5884 | name: "myapex", |
| 5885 | key: "myapex.key", |
Jiyong Park | 89e850a | 2020-04-07 16:37:39 +0900 | [diff] [blame] | 5886 | native_shared_libs: ["libbar", "libbaz"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5887 | updatable: false, |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5888 | } |
| 5889 | |
| 5890 | apex_key { |
| 5891 | name: "myapex.key", |
| 5892 | public_key: "testkey.avbpubkey", |
| 5893 | private_key: "testkey.pem", |
| 5894 | } |
| 5895 | |
| 5896 | cc_library { |
| 5897 | name: "libfoo", |
| 5898 | stl: "none", |
| 5899 | system_shared_libs: [], |
Jiyong Park | 89e850a | 2020-04-07 16:37:39 +0900 | [diff] [blame] | 5900 | shared_libs: ["libbar"], |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5901 | apex_available: ["//apex_available:platform"], |
Jiyong Park | 89e850a | 2020-04-07 16:37:39 +0900 | [diff] [blame] | 5902 | } |
| 5903 | |
| 5904 | cc_library { |
| 5905 | name: "libfoo2", |
| 5906 | stl: "none", |
| 5907 | system_shared_libs: [], |
| 5908 | shared_libs: ["libbaz"], |
| 5909 | apex_available: ["//apex_available:platform"], |
| 5910 | } |
| 5911 | |
| 5912 | cc_library { |
| 5913 | name: "libbar", |
| 5914 | stl: "none", |
| 5915 | system_shared_libs: [], |
| 5916 | apex_available: ["myapex"], |
| 5917 | } |
| 5918 | |
| 5919 | cc_library { |
| 5920 | name: "libbaz", |
| 5921 | stl: "none", |
| 5922 | system_shared_libs: [], |
| 5923 | apex_available: ["myapex"], |
| 5924 | stubs: { |
| 5925 | versions: ["1"], |
| 5926 | }, |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5927 | }`) |
| 5928 | |
Jiyong Park | 89e850a | 2020-04-07 16:37:39 +0900 | [diff] [blame] | 5929 | // libfoo shouldn't be available to platform even though it has "//apex_available:platform", |
| 5930 | // because it depends on libbar which isn't available to platform |
| 5931 | libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module) |
| 5932 | if libfoo.NotAvailableForPlatform() != true { |
| 5933 | t.Errorf("%q shouldn't be available to platform", libfoo.String()) |
| 5934 | } |
| 5935 | |
| 5936 | // libfoo2 however can be available to platform because it depends on libbaz which provides |
| 5937 | // stubs |
| 5938 | libfoo2 := ctx.ModuleForTests("libfoo2", "android_arm64_armv8-a_shared").Module().(*cc.Module) |
| 5939 | if libfoo2.NotAvailableForPlatform() == true { |
| 5940 | t.Errorf("%q should be available to platform", libfoo2.String()) |
| 5941 | } |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 5942 | } |
Jiyong Park | a90ca00 | 2019-10-07 15:47:24 +0900 | [diff] [blame] | 5943 | |
Paul Duffin | e52e66f | 2020-03-30 17:54:29 +0100 | [diff] [blame] | 5944 | func TestApexAvailable_CreatedForApex(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5945 | ctx := testApex(t, ` |
Jiyong Park | a90ca00 | 2019-10-07 15:47:24 +0900 | [diff] [blame] | 5946 | apex { |
| 5947 | name: "myapex", |
| 5948 | key: "myapex.key", |
| 5949 | native_shared_libs: ["libfoo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5950 | updatable: false, |
Jiyong Park | a90ca00 | 2019-10-07 15:47:24 +0900 | [diff] [blame] | 5951 | } |
| 5952 | |
| 5953 | apex_key { |
| 5954 | name: "myapex.key", |
| 5955 | public_key: "testkey.avbpubkey", |
| 5956 | private_key: "testkey.pem", |
| 5957 | } |
| 5958 | |
| 5959 | cc_library { |
| 5960 | name: "libfoo", |
| 5961 | stl: "none", |
| 5962 | system_shared_libs: [], |
| 5963 | apex_available: ["myapex"], |
| 5964 | static: { |
| 5965 | apex_available: ["//apex_available:platform"], |
| 5966 | }, |
| 5967 | }`) |
| 5968 | |
Jiyong Park | 89e850a | 2020-04-07 16:37:39 +0900 | [diff] [blame] | 5969 | libfooShared := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module) |
| 5970 | if libfooShared.NotAvailableForPlatform() != true { |
| 5971 | t.Errorf("%q shouldn't be available to platform", libfooShared.String()) |
| 5972 | } |
| 5973 | libfooStatic := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_static").Module().(*cc.Module) |
| 5974 | if libfooStatic.NotAvailableForPlatform() != false { |
| 5975 | t.Errorf("%q should be available to platform", libfooStatic.String()) |
| 5976 | } |
Jiyong Park | 127b40b | 2019-09-30 16:04:35 +0900 | [diff] [blame] | 5977 | } |
| 5978 | |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 5979 | func TestOverrideApex(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 5980 | ctx := testApex(t, ` |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 5981 | apex { |
| 5982 | name: "myapex", |
| 5983 | key: "myapex.key", |
| 5984 | apps: ["app"], |
markchien | 7c803b8 | 2021-08-26 22:10:06 +0800 | [diff] [blame] | 5985 | bpfs: ["bpf"], |
Daniel Norman | 5a3ce13 | 2021-08-26 15:44:43 -0700 | [diff] [blame] | 5986 | prebuilts: ["myetc"], |
Jaewoong Jung | 7abcf8e | 2019-12-19 17:32:06 -0800 | [diff] [blame] | 5987 | overrides: ["oldapex"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 5988 | updatable: false, |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 5989 | } |
| 5990 | |
| 5991 | override_apex { |
| 5992 | name: "override_myapex", |
| 5993 | base: "myapex", |
| 5994 | apps: ["override_app"], |
markchien | 7c803b8 | 2021-08-26 22:10:06 +0800 | [diff] [blame] | 5995 | bpfs: ["override_bpf"], |
Daniel Norman | 5a3ce13 | 2021-08-26 15:44:43 -0700 | [diff] [blame] | 5996 | prebuilts: ["override_myetc"], |
Jaewoong Jung | 7abcf8e | 2019-12-19 17:32:06 -0800 | [diff] [blame] | 5997 | overrides: ["unknownapex"], |
Baligh Uddin | 004d717 | 2020-02-19 21:29:28 -0800 | [diff] [blame] | 5998 | logging_parent: "com.foo.bar", |
Baligh Uddin | 5b57dba | 2020-03-15 13:01:05 -0700 | [diff] [blame] | 5999 | package_name: "test.overridden.package", |
Jaewoong Jung | 4cfdf7d | 2021-04-20 16:21:24 -0700 | [diff] [blame] | 6000 | key: "mynewapex.key", |
| 6001 | certificate: ":myapex.certificate", |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 6002 | } |
| 6003 | |
| 6004 | apex_key { |
| 6005 | name: "myapex.key", |
| 6006 | public_key: "testkey.avbpubkey", |
| 6007 | private_key: "testkey.pem", |
| 6008 | } |
| 6009 | |
Jaewoong Jung | 4cfdf7d | 2021-04-20 16:21:24 -0700 | [diff] [blame] | 6010 | apex_key { |
| 6011 | name: "mynewapex.key", |
| 6012 | public_key: "testkey2.avbpubkey", |
| 6013 | private_key: "testkey2.pem", |
| 6014 | } |
| 6015 | |
| 6016 | android_app_certificate { |
| 6017 | name: "myapex.certificate", |
| 6018 | certificate: "testkey", |
| 6019 | } |
| 6020 | |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 6021 | android_app { |
| 6022 | name: "app", |
| 6023 | srcs: ["foo/bar/MyClass.java"], |
| 6024 | package_name: "foo", |
| 6025 | sdk_version: "none", |
| 6026 | system_modules: "none", |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 6027 | apex_available: [ "myapex" ], |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 6028 | } |
| 6029 | |
| 6030 | override_android_app { |
| 6031 | name: "override_app", |
| 6032 | base: "app", |
| 6033 | package_name: "bar", |
| 6034 | } |
markchien | 7c803b8 | 2021-08-26 22:10:06 +0800 | [diff] [blame] | 6035 | |
| 6036 | bpf { |
| 6037 | name: "bpf", |
| 6038 | srcs: ["bpf.c"], |
| 6039 | } |
| 6040 | |
| 6041 | bpf { |
| 6042 | name: "override_bpf", |
| 6043 | srcs: ["override_bpf.c"], |
| 6044 | } |
Daniel Norman | 5a3ce13 | 2021-08-26 15:44:43 -0700 | [diff] [blame] | 6045 | |
| 6046 | prebuilt_etc { |
| 6047 | name: "myetc", |
| 6048 | src: "myprebuilt", |
| 6049 | } |
| 6050 | |
| 6051 | prebuilt_etc { |
| 6052 | name: "override_myetc", |
| 6053 | src: "override_myprebuilt", |
| 6054 | } |
Jiyong Park | 20bacab | 2020-03-03 11:45:41 +0900 | [diff] [blame] | 6055 | `, withManifestPackageNameOverrides([]string{"myapex:com.android.myapex"})) |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 6056 | |
Jiyong Park | 317645e | 2019-12-05 13:20:58 +0900 | [diff] [blame] | 6057 | originalVariant := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(android.OverridableModule) |
| 6058 | overriddenVariant := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Module().(android.OverridableModule) |
| 6059 | if originalVariant.GetOverriddenBy() != "" { |
| 6060 | t.Errorf("GetOverriddenBy should be empty, but was %q", originalVariant.GetOverriddenBy()) |
| 6061 | } |
| 6062 | if overriddenVariant.GetOverriddenBy() != "override_myapex" { |
| 6063 | t.Errorf("GetOverriddenBy should be \"override_myapex\", but was %q", overriddenVariant.GetOverriddenBy()) |
| 6064 | } |
| 6065 | |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 6066 | module := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image") |
| 6067 | apexRule := module.Rule("apexRule") |
| 6068 | copyCmds := apexRule.Args["copy_commands"] |
| 6069 | |
| 6070 | ensureNotContains(t, copyCmds, "image.apex/app/app/app.apk") |
Jooyung Han | 39ee119 | 2020-03-23 20:21:11 +0900 | [diff] [blame] | 6071 | ensureContains(t, copyCmds, "image.apex/app/override_app/override_app.apk") |
Jaewoong Jung | 1670ca0 | 2019-11-22 14:50:42 -0800 | [diff] [blame] | 6072 | |
markchien | 7c803b8 | 2021-08-26 22:10:06 +0800 | [diff] [blame] | 6073 | ensureNotContains(t, copyCmds, "image.apex/etc/bpf/bpf.o") |
| 6074 | ensureContains(t, copyCmds, "image.apex/etc/bpf/override_bpf.o") |
| 6075 | |
Daniel Norman | 5a3ce13 | 2021-08-26 15:44:43 -0700 | [diff] [blame] | 6076 | ensureNotContains(t, copyCmds, "image.apex/etc/myetc") |
| 6077 | ensureContains(t, copyCmds, "image.apex/etc/override_myetc") |
| 6078 | |
Jaewoong Jung | 1670ca0 | 2019-11-22 14:50:42 -0800 | [diff] [blame] | 6079 | apexBundle := module.Module().(*apexBundle) |
| 6080 | name := apexBundle.Name() |
| 6081 | if name != "override_myapex" { |
| 6082 | t.Errorf("name should be \"override_myapex\", but was %q", name) |
| 6083 | } |
| 6084 | |
Baligh Uddin | 004d717 | 2020-02-19 21:29:28 -0800 | [diff] [blame] | 6085 | if apexBundle.overridableProperties.Logging_parent != "com.foo.bar" { |
| 6086 | t.Errorf("override_myapex should have logging parent (com.foo.bar), but was %q.", apexBundle.overridableProperties.Logging_parent) |
| 6087 | } |
| 6088 | |
Jiyong Park | 20bacab | 2020-03-03 11:45:41 +0900 | [diff] [blame] | 6089 | optFlags := apexRule.Args["opt_flags"] |
Baligh Uddin | 5b57dba | 2020-03-15 13:01:05 -0700 | [diff] [blame] | 6090 | ensureContains(t, optFlags, "--override_apk_package_name test.overridden.package") |
Jaewoong Jung | 4cfdf7d | 2021-04-20 16:21:24 -0700 | [diff] [blame] | 6091 | ensureContains(t, optFlags, "--pubkey testkey2.avbpubkey") |
| 6092 | |
| 6093 | signApkRule := module.Rule("signapk") |
| 6094 | ensureEquals(t, signApkRule.Args["certificates"], "testkey.x509.pem testkey.pk8") |
Jiyong Park | 20bacab | 2020-03-03 11:45:41 +0900 | [diff] [blame] | 6095 | |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 6096 | data := android.AndroidMkDataForTest(t, ctx, apexBundle) |
Jaewoong Jung | 1670ca0 | 2019-11-22 14:50:42 -0800 | [diff] [blame] | 6097 | var builder strings.Builder |
| 6098 | data.Custom(&builder, name, "TARGET_", "", data) |
| 6099 | androidMk := builder.String() |
Jiyong Park | f653b05 | 2019-11-18 15:39:01 +0900 | [diff] [blame] | 6100 | ensureContains(t, androidMk, "LOCAL_MODULE := override_app.override_myapex") |
markchien | 7c803b8 | 2021-08-26 22:10:06 +0800 | [diff] [blame] | 6101 | ensureContains(t, androidMk, "LOCAL_MODULE := override_bpf.o.override_myapex") |
Jaewoong Jung | 1670ca0 | 2019-11-22 14:50:42 -0800 | [diff] [blame] | 6102 | ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.override_myapex") |
| 6103 | ensureContains(t, androidMk, "LOCAL_MODULE_STEM := override_myapex.apex") |
Jaewoong Jung | 7abcf8e | 2019-12-19 17:32:06 -0800 | [diff] [blame] | 6104 | ensureContains(t, androidMk, "LOCAL_OVERRIDES_MODULES := unknownapex myapex") |
Jaewoong Jung | 1670ca0 | 2019-11-22 14:50:42 -0800 | [diff] [blame] | 6105 | ensureNotContains(t, androidMk, "LOCAL_MODULE := app.myapex") |
markchien | 7c803b8 | 2021-08-26 22:10:06 +0800 | [diff] [blame] | 6106 | ensureNotContains(t, androidMk, "LOCAL_MODULE := bpf.myapex") |
Jiyong Park | f653b05 | 2019-11-18 15:39:01 +0900 | [diff] [blame] | 6107 | ensureNotContains(t, androidMk, "LOCAL_MODULE := override_app.myapex") |
Jaewoong Jung | 1670ca0 | 2019-11-22 14:50:42 -0800 | [diff] [blame] | 6108 | ensureNotContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex") |
| 6109 | ensureNotContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.apex") |
Jiyong Park | 5d790c3 | 2019-11-15 18:40:32 +0900 | [diff] [blame] | 6110 | } |
| 6111 | |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 6112 | func TestLegacyAndroid10Support(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6113 | ctx := testApex(t, ` |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 6114 | apex { |
| 6115 | name: "myapex", |
| 6116 | key: "myapex.key", |
Peter Collingbourne | dc4f986 | 2020-02-12 17:13:25 -0800 | [diff] [blame] | 6117 | native_shared_libs: ["mylib"], |
Jooyung Han | 5417f77 | 2020-03-12 18:37:20 +0900 | [diff] [blame] | 6118 | min_sdk_version: "29", |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 6119 | } |
| 6120 | |
| 6121 | apex_key { |
| 6122 | name: "myapex.key", |
| 6123 | public_key: "testkey.avbpubkey", |
| 6124 | private_key: "testkey.pem", |
| 6125 | } |
Peter Collingbourne | dc4f986 | 2020-02-12 17:13:25 -0800 | [diff] [blame] | 6126 | |
| 6127 | cc_library { |
| 6128 | name: "mylib", |
| 6129 | srcs: ["mylib.cpp"], |
| 6130 | stl: "libc++", |
| 6131 | system_shared_libs: [], |
| 6132 | apex_available: [ "myapex" ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 6133 | min_sdk_version: "29", |
Peter Collingbourne | dc4f986 | 2020-02-12 17:13:25 -0800 | [diff] [blame] | 6134 | } |
Peter Collingbourne | dc4f986 | 2020-02-12 17:13:25 -0800 | [diff] [blame] | 6135 | `, withUnbundledBuild) |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 6136 | |
| 6137 | module := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
| 6138 | args := module.Rule("apexRule").Args |
| 6139 | ensureContains(t, args["opt_flags"], "--manifest_json "+module.Output("apex_manifest.json").Output.String()) |
Dario Freni | e354690 | 2020-01-14 23:50:25 +0000 | [diff] [blame] | 6140 | ensureNotContains(t, args["opt_flags"], "--no_hashtree") |
Peter Collingbourne | dc4f986 | 2020-02-12 17:13:25 -0800 | [diff] [blame] | 6141 | |
| 6142 | // The copies of the libraries in the apex should have one more dependency than |
| 6143 | // the ones outside the apex, namely the unwinder. Ideally we should check |
| 6144 | // the dependency names directly here but for some reason the names are blank in |
| 6145 | // this test. |
| 6146 | for _, lib := range []string{"libc++", "mylib"} { |
Colin Cross | aede88c | 2020-08-11 12:17:01 -0700 | [diff] [blame] | 6147 | apexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared_apex29").Rule("ld").Implicits |
Peter Collingbourne | dc4f986 | 2020-02-12 17:13:25 -0800 | [diff] [blame] | 6148 | nonApexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared").Rule("ld").Implicits |
| 6149 | if len(apexImplicits) != len(nonApexImplicits)+1 { |
| 6150 | t.Errorf("%q missing unwinder dep", lib) |
| 6151 | } |
| 6152 | } |
Jooyung Han | 214bf37 | 2019-11-12 13:03:50 +0900 | [diff] [blame] | 6153 | } |
| 6154 | |
Paul Duffin | e05480a | 2021-03-08 15:07:14 +0000 | [diff] [blame] | 6155 | var filesForSdkLibrary = android.MockFS{ |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 6156 | "api/current.txt": nil, |
| 6157 | "api/removed.txt": nil, |
| 6158 | "api/system-current.txt": nil, |
| 6159 | "api/system-removed.txt": nil, |
| 6160 | "api/test-current.txt": nil, |
| 6161 | "api/test-removed.txt": nil, |
Paul Duffin | eedc5d5 | 2020-06-12 17:46:39 +0100 | [diff] [blame] | 6162 | |
Anton Hansson | dff2c78 | 2020-12-21 17:10:01 +0000 | [diff] [blame] | 6163 | "100/public/api/foo.txt": nil, |
| 6164 | "100/public/api/foo-removed.txt": nil, |
| 6165 | "100/system/api/foo.txt": nil, |
| 6166 | "100/system/api/foo-removed.txt": nil, |
| 6167 | |
Paul Duffin | eedc5d5 | 2020-06-12 17:46:39 +0100 | [diff] [blame] | 6168 | // For java_sdk_library_import |
| 6169 | "a.jar": nil, |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 6170 | } |
| 6171 | |
Jooyung Han | 58f26ab | 2019-12-18 15:34:32 +0900 | [diff] [blame] | 6172 | func TestJavaSDKLibrary(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6173 | ctx := testApex(t, ` |
Jooyung Han | 58f26ab | 2019-12-18 15:34:32 +0900 | [diff] [blame] | 6174 | apex { |
| 6175 | name: "myapex", |
| 6176 | key: "myapex.key", |
| 6177 | java_libs: ["foo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6178 | updatable: false, |
Jooyung Han | 58f26ab | 2019-12-18 15:34:32 +0900 | [diff] [blame] | 6179 | } |
| 6180 | |
| 6181 | apex_key { |
| 6182 | name: "myapex.key", |
| 6183 | public_key: "testkey.avbpubkey", |
| 6184 | private_key: "testkey.pem", |
| 6185 | } |
| 6186 | |
| 6187 | java_sdk_library { |
| 6188 | name: "foo", |
| 6189 | srcs: ["a.java"], |
| 6190 | api_packages: ["foo"], |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 6191 | apex_available: [ "myapex" ], |
Jooyung Han | 58f26ab | 2019-12-18 15:34:32 +0900 | [diff] [blame] | 6192 | } |
Anton Hansson | dff2c78 | 2020-12-21 17:10:01 +0000 | [diff] [blame] | 6193 | |
| 6194 | prebuilt_apis { |
| 6195 | name: "sdk", |
| 6196 | api_dirs: ["100"], |
| 6197 | } |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 6198 | `, withFiles(filesForSdkLibrary)) |
Jooyung Han | 58f26ab | 2019-12-18 15:34:32 +0900 | [diff] [blame] | 6199 | |
| 6200 | // java_sdk_library installs both impl jar and permission XML |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 6201 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
Jooyung Han | 58f26ab | 2019-12-18 15:34:32 +0900 | [diff] [blame] | 6202 | "javalib/foo.jar", |
| 6203 | "etc/permissions/foo.xml", |
| 6204 | }) |
| 6205 | // Permission XML should point to the activated path of impl jar of java_sdk_library |
Jiyong Park | e383388 | 2020-02-17 17:28:10 +0900 | [diff] [blame] | 6206 | sdkLibrary := ctx.ModuleForTests("foo.xml", "android_common_myapex").Rule("java_sdk_xml") |
| 6207 | ensureContains(t, sdkLibrary.RuleParams.Command, `<library name=\"foo\" file=\"/apex/myapex/javalib/foo.jar\"`) |
Jooyung Han | 58f26ab | 2019-12-18 15:34:32 +0900 | [diff] [blame] | 6208 | } |
| 6209 | |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 6210 | func TestJavaSDKLibrary_WithinApex(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6211 | ctx := testApex(t, ` |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 6212 | apex { |
| 6213 | name: "myapex", |
| 6214 | key: "myapex.key", |
| 6215 | java_libs: ["foo", "bar"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6216 | updatable: false, |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 6217 | } |
| 6218 | |
| 6219 | apex_key { |
| 6220 | name: "myapex.key", |
| 6221 | public_key: "testkey.avbpubkey", |
| 6222 | private_key: "testkey.pem", |
| 6223 | } |
| 6224 | |
| 6225 | java_sdk_library { |
| 6226 | name: "foo", |
| 6227 | srcs: ["a.java"], |
| 6228 | api_packages: ["foo"], |
| 6229 | apex_available: ["myapex"], |
| 6230 | sdk_version: "none", |
| 6231 | system_modules: "none", |
| 6232 | } |
| 6233 | |
| 6234 | java_library { |
| 6235 | name: "bar", |
| 6236 | srcs: ["a.java"], |
| 6237 | libs: ["foo"], |
| 6238 | apex_available: ["myapex"], |
| 6239 | sdk_version: "none", |
| 6240 | system_modules: "none", |
| 6241 | } |
Anton Hansson | dff2c78 | 2020-12-21 17:10:01 +0000 | [diff] [blame] | 6242 | |
| 6243 | prebuilt_apis { |
| 6244 | name: "sdk", |
| 6245 | api_dirs: ["100"], |
| 6246 | } |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 6247 | `, withFiles(filesForSdkLibrary)) |
| 6248 | |
| 6249 | // java_sdk_library installs both impl jar and permission XML |
| 6250 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 6251 | "javalib/bar.jar", |
| 6252 | "javalib/foo.jar", |
| 6253 | "etc/permissions/foo.xml", |
| 6254 | }) |
| 6255 | |
| 6256 | // The bar library should depend on the implementation jar. |
| 6257 | barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac") |
Paul Duffin | cf8d7db | 2021-03-29 00:29:53 +0100 | [diff] [blame] | 6258 | if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) { |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 6259 | t.Errorf("expected %q, found %#q", expected, actual) |
| 6260 | } |
| 6261 | } |
| 6262 | |
| 6263 | func TestJavaSDKLibrary_CrossBoundary(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6264 | ctx := testApex(t, ` |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 6265 | apex { |
| 6266 | name: "myapex", |
| 6267 | key: "myapex.key", |
| 6268 | java_libs: ["foo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6269 | updatable: false, |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 6270 | } |
| 6271 | |
| 6272 | apex_key { |
| 6273 | name: "myapex.key", |
| 6274 | public_key: "testkey.avbpubkey", |
| 6275 | private_key: "testkey.pem", |
| 6276 | } |
| 6277 | |
| 6278 | java_sdk_library { |
| 6279 | name: "foo", |
| 6280 | srcs: ["a.java"], |
| 6281 | api_packages: ["foo"], |
| 6282 | apex_available: ["myapex"], |
| 6283 | sdk_version: "none", |
| 6284 | system_modules: "none", |
| 6285 | } |
| 6286 | |
| 6287 | java_library { |
| 6288 | name: "bar", |
| 6289 | srcs: ["a.java"], |
| 6290 | libs: ["foo"], |
| 6291 | sdk_version: "none", |
| 6292 | system_modules: "none", |
| 6293 | } |
Anton Hansson | dff2c78 | 2020-12-21 17:10:01 +0000 | [diff] [blame] | 6294 | |
| 6295 | prebuilt_apis { |
| 6296 | name: "sdk", |
| 6297 | api_dirs: ["100"], |
| 6298 | } |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 6299 | `, withFiles(filesForSdkLibrary)) |
| 6300 | |
| 6301 | // java_sdk_library installs both impl jar and permission XML |
| 6302 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 6303 | "javalib/foo.jar", |
| 6304 | "etc/permissions/foo.xml", |
| 6305 | }) |
| 6306 | |
| 6307 | // The bar library should depend on the stubs jar. |
| 6308 | barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac") |
Paul Duffin | cf8d7db | 2021-03-29 00:29:53 +0100 | [diff] [blame] | 6309 | if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) { |
Paul Duffin | 9b87959 | 2020-05-26 13:21:35 +0100 | [diff] [blame] | 6310 | t.Errorf("expected %q, found %#q", expected, actual) |
| 6311 | } |
| 6312 | } |
| 6313 | |
Paul Duffin | eedc5d5 | 2020-06-12 17:46:39 +0100 | [diff] [blame] | 6314 | func TestJavaSDKLibrary_ImportPreferred(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6315 | ctx := testApex(t, ` |
Anton Hansson | dff2c78 | 2020-12-21 17:10:01 +0000 | [diff] [blame] | 6316 | prebuilt_apis { |
| 6317 | name: "sdk", |
| 6318 | api_dirs: ["100"], |
| 6319 | }`, |
Paul Duffin | eedc5d5 | 2020-06-12 17:46:39 +0100 | [diff] [blame] | 6320 | withFiles(map[string][]byte{ |
| 6321 | "apex/a.java": nil, |
| 6322 | "apex/apex_manifest.json": nil, |
| 6323 | "apex/Android.bp": []byte(` |
| 6324 | package { |
| 6325 | default_visibility: ["//visibility:private"], |
| 6326 | } |
| 6327 | |
| 6328 | apex { |
| 6329 | name: "myapex", |
| 6330 | key: "myapex.key", |
| 6331 | java_libs: ["foo", "bar"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6332 | updatable: false, |
Paul Duffin | eedc5d5 | 2020-06-12 17:46:39 +0100 | [diff] [blame] | 6333 | } |
| 6334 | |
| 6335 | apex_key { |
| 6336 | name: "myapex.key", |
| 6337 | public_key: "testkey.avbpubkey", |
| 6338 | private_key: "testkey.pem", |
| 6339 | } |
| 6340 | |
| 6341 | java_library { |
| 6342 | name: "bar", |
| 6343 | srcs: ["a.java"], |
| 6344 | libs: ["foo"], |
| 6345 | apex_available: ["myapex"], |
| 6346 | sdk_version: "none", |
| 6347 | system_modules: "none", |
| 6348 | } |
| 6349 | `), |
| 6350 | "source/a.java": nil, |
| 6351 | "source/api/current.txt": nil, |
| 6352 | "source/api/removed.txt": nil, |
| 6353 | "source/Android.bp": []byte(` |
| 6354 | package { |
| 6355 | default_visibility: ["//visibility:private"], |
| 6356 | } |
| 6357 | |
| 6358 | java_sdk_library { |
| 6359 | name: "foo", |
| 6360 | visibility: ["//apex"], |
| 6361 | srcs: ["a.java"], |
| 6362 | api_packages: ["foo"], |
| 6363 | apex_available: ["myapex"], |
| 6364 | sdk_version: "none", |
| 6365 | system_modules: "none", |
| 6366 | public: { |
| 6367 | enabled: true, |
| 6368 | }, |
| 6369 | } |
| 6370 | `), |
| 6371 | "prebuilt/a.jar": nil, |
| 6372 | "prebuilt/Android.bp": []byte(` |
| 6373 | package { |
| 6374 | default_visibility: ["//visibility:private"], |
| 6375 | } |
| 6376 | |
| 6377 | java_sdk_library_import { |
| 6378 | name: "foo", |
| 6379 | visibility: ["//apex", "//source"], |
| 6380 | apex_available: ["myapex"], |
| 6381 | prefer: true, |
| 6382 | public: { |
| 6383 | jars: ["a.jar"], |
| 6384 | }, |
| 6385 | } |
| 6386 | `), |
Anton Hansson | dff2c78 | 2020-12-21 17:10:01 +0000 | [diff] [blame] | 6387 | }), withFiles(filesForSdkLibrary), |
Paul Duffin | eedc5d5 | 2020-06-12 17:46:39 +0100 | [diff] [blame] | 6388 | ) |
| 6389 | |
| 6390 | // java_sdk_library installs both impl jar and permission XML |
| 6391 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 6392 | "javalib/bar.jar", |
| 6393 | "javalib/foo.jar", |
| 6394 | "etc/permissions/foo.xml", |
| 6395 | }) |
| 6396 | |
| 6397 | // The bar library should depend on the implementation jar. |
| 6398 | barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac") |
Paul Duffin | cf8d7db | 2021-03-29 00:29:53 +0100 | [diff] [blame] | 6399 | if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.impl\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) { |
Paul Duffin | eedc5d5 | 2020-06-12 17:46:39 +0100 | [diff] [blame] | 6400 | t.Errorf("expected %q, found %#q", expected, actual) |
| 6401 | } |
| 6402 | } |
| 6403 | |
| 6404 | func TestJavaSDKLibrary_ImportOnly(t *testing.T) { |
| 6405 | testApexError(t, `java_libs: "foo" is not configured to be compiled into dex`, ` |
| 6406 | apex { |
| 6407 | name: "myapex", |
| 6408 | key: "myapex.key", |
| 6409 | java_libs: ["foo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6410 | updatable: false, |
Paul Duffin | eedc5d5 | 2020-06-12 17:46:39 +0100 | [diff] [blame] | 6411 | } |
| 6412 | |
| 6413 | apex_key { |
| 6414 | name: "myapex.key", |
| 6415 | public_key: "testkey.avbpubkey", |
| 6416 | private_key: "testkey.pem", |
| 6417 | } |
| 6418 | |
| 6419 | java_sdk_library_import { |
| 6420 | name: "foo", |
| 6421 | apex_available: ["myapex"], |
| 6422 | prefer: true, |
| 6423 | public: { |
| 6424 | jars: ["a.jar"], |
| 6425 | }, |
| 6426 | } |
| 6427 | |
| 6428 | `, withFiles(filesForSdkLibrary)) |
| 6429 | } |
| 6430 | |
atrost | 6e12625 | 2020-01-27 17:01:16 +0000 | [diff] [blame] | 6431 | func TestCompatConfig(t *testing.T) { |
Paul Duffin | 284165a | 2021-03-29 01:50:31 +0100 | [diff] [blame] | 6432 | result := android.GroupFixturePreparers( |
| 6433 | prepareForApexTest, |
| 6434 | java.PrepareForTestWithPlatformCompatConfig, |
| 6435 | ).RunTestWithBp(t, ` |
atrost | 6e12625 | 2020-01-27 17:01:16 +0000 | [diff] [blame] | 6436 | apex { |
| 6437 | name: "myapex", |
| 6438 | key: "myapex.key", |
Paul Duffin | 3abc174 | 2021-03-15 19:32:23 +0000 | [diff] [blame] | 6439 | compat_configs: ["myjar-platform-compat-config"], |
atrost | 6e12625 | 2020-01-27 17:01:16 +0000 | [diff] [blame] | 6440 | java_libs: ["myjar"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6441 | updatable: false, |
atrost | 6e12625 | 2020-01-27 17:01:16 +0000 | [diff] [blame] | 6442 | } |
| 6443 | |
| 6444 | apex_key { |
| 6445 | name: "myapex.key", |
| 6446 | public_key: "testkey.avbpubkey", |
| 6447 | private_key: "testkey.pem", |
| 6448 | } |
| 6449 | |
| 6450 | platform_compat_config { |
| 6451 | name: "myjar-platform-compat-config", |
| 6452 | src: ":myjar", |
| 6453 | } |
| 6454 | |
| 6455 | java_library { |
| 6456 | name: "myjar", |
| 6457 | srcs: ["foo/bar/MyClass.java"], |
| 6458 | sdk_version: "none", |
| 6459 | system_modules: "none", |
atrost | 6e12625 | 2020-01-27 17:01:16 +0000 | [diff] [blame] | 6460 | apex_available: [ "myapex" ], |
| 6461 | } |
Paul Duffin | 1b29e00 | 2021-03-16 15:06:54 +0000 | [diff] [blame] | 6462 | |
| 6463 | // Make sure that a preferred prebuilt does not affect the apex contents. |
| 6464 | prebuilt_platform_compat_config { |
| 6465 | name: "myjar-platform-compat-config", |
| 6466 | metadata: "compat-config/metadata.xml", |
| 6467 | prefer: true, |
| 6468 | } |
atrost | 6e12625 | 2020-01-27 17:01:16 +0000 | [diff] [blame] | 6469 | `) |
Paul Duffin | a369c7b | 2021-03-09 03:08:05 +0000 | [diff] [blame] | 6470 | ctx := result.TestContext |
atrost | 6e12625 | 2020-01-27 17:01:16 +0000 | [diff] [blame] | 6471 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 6472 | "etc/compatconfig/myjar-platform-compat-config.xml", |
| 6473 | "javalib/myjar.jar", |
| 6474 | }) |
| 6475 | } |
| 6476 | |
Jiyong Park | 479321d | 2019-12-16 11:47:12 +0900 | [diff] [blame] | 6477 | func TestRejectNonInstallableJavaLibrary(t *testing.T) { |
| 6478 | testApexError(t, `"myjar" is not configured to be compiled into dex`, ` |
| 6479 | apex { |
| 6480 | name: "myapex", |
| 6481 | key: "myapex.key", |
| 6482 | java_libs: ["myjar"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6483 | updatable: false, |
Jiyong Park | 479321d | 2019-12-16 11:47:12 +0900 | [diff] [blame] | 6484 | } |
| 6485 | |
| 6486 | apex_key { |
| 6487 | name: "myapex.key", |
| 6488 | public_key: "testkey.avbpubkey", |
| 6489 | private_key: "testkey.pem", |
| 6490 | } |
| 6491 | |
| 6492 | java_library { |
| 6493 | name: "myjar", |
| 6494 | srcs: ["foo/bar/MyClass.java"], |
| 6495 | sdk_version: "none", |
| 6496 | system_modules: "none", |
Jiyong Park | 6b21c7d | 2020-02-11 09:16:01 +0900 | [diff] [blame] | 6497 | compile_dex: false, |
Jooyung Han | 5e9013b | 2020-03-10 06:23:13 +0900 | [diff] [blame] | 6498 | apex_available: ["myapex"], |
Jiyong Park | 479321d | 2019-12-16 11:47:12 +0900 | [diff] [blame] | 6499 | } |
| 6500 | `) |
| 6501 | } |
| 6502 | |
Jiyong Park | 7afd107 | 2019-12-30 16:56:33 +0900 | [diff] [blame] | 6503 | func TestCarryRequiredModuleNames(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6504 | ctx := testApex(t, ` |
Jiyong Park | 7afd107 | 2019-12-30 16:56:33 +0900 | [diff] [blame] | 6505 | apex { |
| 6506 | name: "myapex", |
| 6507 | key: "myapex.key", |
| 6508 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6509 | updatable: false, |
Jiyong Park | 7afd107 | 2019-12-30 16:56:33 +0900 | [diff] [blame] | 6510 | } |
| 6511 | |
| 6512 | apex_key { |
| 6513 | name: "myapex.key", |
| 6514 | public_key: "testkey.avbpubkey", |
| 6515 | private_key: "testkey.pem", |
| 6516 | } |
| 6517 | |
| 6518 | cc_library { |
| 6519 | name: "mylib", |
| 6520 | srcs: ["mylib.cpp"], |
| 6521 | system_shared_libs: [], |
| 6522 | stl: "none", |
| 6523 | required: ["a", "b"], |
| 6524 | host_required: ["c", "d"], |
| 6525 | target_required: ["e", "f"], |
Anton Hansson | eec79eb | 2020-01-10 15:12:39 +0000 | [diff] [blame] | 6526 | apex_available: [ "myapex" ], |
Jiyong Park | 7afd107 | 2019-12-30 16:56:33 +0900 | [diff] [blame] | 6527 | } |
| 6528 | `) |
| 6529 | |
| 6530 | apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 6531 | data := android.AndroidMkDataForTest(t, ctx, apexBundle) |
Jiyong Park | 7afd107 | 2019-12-30 16:56:33 +0900 | [diff] [blame] | 6532 | name := apexBundle.BaseModuleName() |
| 6533 | prefix := "TARGET_" |
| 6534 | var builder strings.Builder |
| 6535 | data.Custom(&builder, name, prefix, "", data) |
| 6536 | androidMk := builder.String() |
| 6537 | ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += a b\n") |
| 6538 | ensureContains(t, androidMk, "LOCAL_HOST_REQUIRED_MODULES += c d\n") |
| 6539 | ensureContains(t, androidMk, "LOCAL_TARGET_REQUIRED_MODULES += e f\n") |
| 6540 | } |
| 6541 | |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6542 | func TestSymlinksFromApexToSystem(t *testing.T) { |
| 6543 | bp := ` |
| 6544 | apex { |
| 6545 | name: "myapex", |
| 6546 | key: "myapex.key", |
| 6547 | native_shared_libs: ["mylib"], |
| 6548 | java_libs: ["myjar"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6549 | updatable: false, |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6550 | } |
| 6551 | |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 6552 | apex { |
| 6553 | name: "myapex.updatable", |
| 6554 | key: "myapex.key", |
| 6555 | native_shared_libs: ["mylib"], |
| 6556 | java_libs: ["myjar"], |
| 6557 | updatable: true, |
Jooyung Han | 548640b | 2020-04-27 12:10:30 +0900 | [diff] [blame] | 6558 | min_sdk_version: "current", |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 6559 | } |
| 6560 | |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6561 | apex_key { |
| 6562 | name: "myapex.key", |
| 6563 | public_key: "testkey.avbpubkey", |
| 6564 | private_key: "testkey.pem", |
| 6565 | } |
| 6566 | |
| 6567 | cc_library { |
| 6568 | name: "mylib", |
| 6569 | srcs: ["mylib.cpp"], |
| 6570 | shared_libs: ["myotherlib"], |
| 6571 | system_shared_libs: [], |
| 6572 | stl: "none", |
| 6573 | apex_available: [ |
| 6574 | "myapex", |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 6575 | "myapex.updatable", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6576 | "//apex_available:platform", |
| 6577 | ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 6578 | min_sdk_version: "current", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6579 | } |
| 6580 | |
| 6581 | cc_library { |
| 6582 | name: "myotherlib", |
| 6583 | srcs: ["mylib.cpp"], |
| 6584 | system_shared_libs: [], |
| 6585 | stl: "none", |
| 6586 | apex_available: [ |
| 6587 | "myapex", |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 6588 | "myapex.updatable", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6589 | "//apex_available:platform", |
| 6590 | ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 6591 | min_sdk_version: "current", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6592 | } |
| 6593 | |
| 6594 | java_library { |
| 6595 | name: "myjar", |
| 6596 | srcs: ["foo/bar/MyClass.java"], |
| 6597 | sdk_version: "none", |
| 6598 | system_modules: "none", |
| 6599 | libs: ["myotherjar"], |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6600 | apex_available: [ |
| 6601 | "myapex", |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 6602 | "myapex.updatable", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6603 | "//apex_available:platform", |
| 6604 | ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 6605 | min_sdk_version: "current", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6606 | } |
| 6607 | |
| 6608 | java_library { |
| 6609 | name: "myotherjar", |
| 6610 | srcs: ["foo/bar/MyClass.java"], |
| 6611 | sdk_version: "none", |
| 6612 | system_modules: "none", |
| 6613 | apex_available: [ |
| 6614 | "myapex", |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 6615 | "myapex.updatable", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6616 | "//apex_available:platform", |
| 6617 | ], |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 6618 | min_sdk_version: "current", |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6619 | } |
| 6620 | ` |
| 6621 | |
| 6622 | ensureRealfileExists := func(t *testing.T, files []fileInApex, file string) { |
| 6623 | for _, f := range files { |
| 6624 | if f.path == file { |
| 6625 | if f.isLink { |
| 6626 | t.Errorf("%q is not a real file", file) |
| 6627 | } |
| 6628 | return |
| 6629 | } |
| 6630 | } |
| 6631 | t.Errorf("%q is not found", file) |
| 6632 | } |
| 6633 | |
| 6634 | ensureSymlinkExists := func(t *testing.T, files []fileInApex, file string) { |
| 6635 | for _, f := range files { |
| 6636 | if f.path == file { |
| 6637 | if !f.isLink { |
| 6638 | t.Errorf("%q is not a symlink", file) |
| 6639 | } |
| 6640 | return |
| 6641 | } |
| 6642 | } |
| 6643 | t.Errorf("%q is not found", file) |
| 6644 | } |
| 6645 | |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 6646 | // For unbundled build, symlink shouldn't exist regardless of whether an APEX |
| 6647 | // is updatable or not |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6648 | ctx := testApex(t, bp, withUnbundledBuild) |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 6649 | files := getFiles(t, ctx, "myapex", "android_common_myapex_image") |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6650 | ensureRealfileExists(t, files, "javalib/myjar.jar") |
| 6651 | ensureRealfileExists(t, files, "lib64/mylib.so") |
| 6652 | ensureRealfileExists(t, files, "lib64/myotherlib.so") |
| 6653 | |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 6654 | files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image") |
| 6655 | ensureRealfileExists(t, files, "javalib/myjar.jar") |
| 6656 | ensureRealfileExists(t, files, "lib64/mylib.so") |
| 6657 | ensureRealfileExists(t, files, "lib64/myotherlib.so") |
| 6658 | |
| 6659 | // For bundled build, symlink to the system for the non-updatable APEXes only |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6660 | ctx = testApex(t, bp) |
Jooyung Han | a57af4a | 2020-01-23 05:36:59 +0000 | [diff] [blame] | 6661 | files = getFiles(t, ctx, "myapex", "android_common_myapex_image") |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6662 | ensureRealfileExists(t, files, "javalib/myjar.jar") |
| 6663 | ensureRealfileExists(t, files, "lib64/mylib.so") |
| 6664 | ensureSymlinkExists(t, files, "lib64/myotherlib.so") // this is symlink |
Jiyong Park | 9d67720 | 2020-02-19 16:29:35 +0900 | [diff] [blame] | 6665 | |
| 6666 | files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image") |
| 6667 | ensureRealfileExists(t, files, "javalib/myjar.jar") |
| 6668 | ensureRealfileExists(t, files, "lib64/mylib.so") |
| 6669 | ensureRealfileExists(t, files, "lib64/myotherlib.so") // this is a real file |
Jiyong Park | 7cd10e3 | 2020-01-14 09:22:18 +0900 | [diff] [blame] | 6670 | } |
| 6671 | |
Yo Chiang | e812805 | 2020-07-23 20:09:18 +0800 | [diff] [blame] | 6672 | func TestSymlinksFromApexToSystemRequiredModuleNames(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6673 | ctx := testApex(t, ` |
Yo Chiang | e812805 | 2020-07-23 20:09:18 +0800 | [diff] [blame] | 6674 | apex { |
| 6675 | name: "myapex", |
| 6676 | key: "myapex.key", |
| 6677 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6678 | updatable: false, |
Yo Chiang | e812805 | 2020-07-23 20:09:18 +0800 | [diff] [blame] | 6679 | } |
| 6680 | |
| 6681 | apex_key { |
| 6682 | name: "myapex.key", |
| 6683 | public_key: "testkey.avbpubkey", |
| 6684 | private_key: "testkey.pem", |
| 6685 | } |
| 6686 | |
| 6687 | cc_library_shared { |
| 6688 | name: "mylib", |
| 6689 | srcs: ["mylib.cpp"], |
| 6690 | shared_libs: ["myotherlib"], |
| 6691 | system_shared_libs: [], |
| 6692 | stl: "none", |
| 6693 | apex_available: [ |
| 6694 | "myapex", |
| 6695 | "//apex_available:platform", |
| 6696 | ], |
| 6697 | } |
| 6698 | |
| 6699 | cc_prebuilt_library_shared { |
| 6700 | name: "myotherlib", |
| 6701 | srcs: ["prebuilt.so"], |
| 6702 | system_shared_libs: [], |
| 6703 | stl: "none", |
| 6704 | apex_available: [ |
| 6705 | "myapex", |
| 6706 | "//apex_available:platform", |
| 6707 | ], |
| 6708 | } |
| 6709 | `) |
| 6710 | |
| 6711 | apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 6712 | data := android.AndroidMkDataForTest(t, ctx, apexBundle) |
Yo Chiang | e812805 | 2020-07-23 20:09:18 +0800 | [diff] [blame] | 6713 | var builder strings.Builder |
| 6714 | data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data) |
| 6715 | androidMk := builder.String() |
| 6716 | // `myotherlib` is added to `myapex` as symlink |
| 6717 | ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n") |
| 6718 | ensureNotContains(t, androidMk, "LOCAL_MODULE := prebuilt_myotherlib.myapex\n") |
| 6719 | ensureNotContains(t, androidMk, "LOCAL_MODULE := myotherlib.myapex\n") |
| 6720 | // `myapex` should have `myotherlib` in its required line, not `prebuilt_myotherlib` |
Jiyong Park | 57621b2 | 2021-01-20 20:33:11 +0900 | [diff] [blame] | 6721 | ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += mylib.myapex:64 myotherlib:64 apex_manifest.pb.myapex apex_pubkey.myapex\n") |
Yo Chiang | e812805 | 2020-07-23 20:09:18 +0800 | [diff] [blame] | 6722 | } |
| 6723 | |
Jooyung Han | 643adc4 | 2020-02-27 13:50:06 +0900 | [diff] [blame] | 6724 | func TestApexWithJniLibs(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6725 | ctx := testApex(t, ` |
Jooyung Han | 643adc4 | 2020-02-27 13:50:06 +0900 | [diff] [blame] | 6726 | apex { |
| 6727 | name: "myapex", |
| 6728 | key: "myapex.key", |
| 6729 | jni_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6730 | updatable: false, |
Jooyung Han | 643adc4 | 2020-02-27 13:50:06 +0900 | [diff] [blame] | 6731 | } |
| 6732 | |
| 6733 | apex_key { |
| 6734 | name: "myapex.key", |
| 6735 | public_key: "testkey.avbpubkey", |
| 6736 | private_key: "testkey.pem", |
| 6737 | } |
| 6738 | |
| 6739 | cc_library { |
| 6740 | name: "mylib", |
| 6741 | srcs: ["mylib.cpp"], |
| 6742 | shared_libs: ["mylib2"], |
| 6743 | system_shared_libs: [], |
| 6744 | stl: "none", |
| 6745 | apex_available: [ "myapex" ], |
| 6746 | } |
| 6747 | |
| 6748 | cc_library { |
| 6749 | name: "mylib2", |
| 6750 | srcs: ["mylib.cpp"], |
| 6751 | system_shared_libs: [], |
| 6752 | stl: "none", |
| 6753 | apex_available: [ "myapex" ], |
| 6754 | } |
| 6755 | `) |
| 6756 | |
| 6757 | rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule") |
| 6758 | // Notice mylib2.so (transitive dep) is not added as a jni_lib |
| 6759 | ensureEquals(t, rule.Args["opt"], "-a jniLibs mylib.so") |
| 6760 | ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{ |
| 6761 | "lib64/mylib.so", |
| 6762 | "lib64/mylib2.so", |
| 6763 | }) |
| 6764 | } |
| 6765 | |
Jooyung Han | 49f6701 | 2020-04-17 13:43:10 +0900 | [diff] [blame] | 6766 | func TestApexMutatorsDontRunIfDisabled(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6767 | ctx := testApex(t, ` |
Jooyung Han | 49f6701 | 2020-04-17 13:43:10 +0900 | [diff] [blame] | 6768 | apex { |
| 6769 | name: "myapex", |
| 6770 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6771 | updatable: false, |
Jooyung Han | 49f6701 | 2020-04-17 13:43:10 +0900 | [diff] [blame] | 6772 | } |
| 6773 | apex_key { |
| 6774 | name: "myapex.key", |
| 6775 | public_key: "testkey.avbpubkey", |
| 6776 | private_key: "testkey.pem", |
| 6777 | } |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 6778 | `, |
| 6779 | android.FixtureModifyConfig(func(config android.Config) { |
| 6780 | delete(config.Targets, android.Android) |
| 6781 | config.AndroidCommonTarget = android.Target{} |
| 6782 | }), |
| 6783 | ) |
Jooyung Han | 49f6701 | 2020-04-17 13:43:10 +0900 | [diff] [blame] | 6784 | |
| 6785 | if expected, got := []string{""}, ctx.ModuleVariantsForTests("myapex"); !reflect.DeepEqual(expected, got) { |
| 6786 | t.Errorf("Expected variants: %v, but got: %v", expected, got) |
| 6787 | } |
| 6788 | } |
| 6789 | |
Jiyong Park | bd15961 | 2020-02-28 15:22:21 +0900 | [diff] [blame] | 6790 | func TestAppBundle(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6791 | ctx := testApex(t, ` |
Jiyong Park | bd15961 | 2020-02-28 15:22:21 +0900 | [diff] [blame] | 6792 | apex { |
| 6793 | name: "myapex", |
| 6794 | key: "myapex.key", |
| 6795 | apps: ["AppFoo"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6796 | updatable: false, |
Jiyong Park | bd15961 | 2020-02-28 15:22:21 +0900 | [diff] [blame] | 6797 | } |
| 6798 | |
| 6799 | apex_key { |
| 6800 | name: "myapex.key", |
| 6801 | public_key: "testkey.avbpubkey", |
| 6802 | private_key: "testkey.pem", |
| 6803 | } |
| 6804 | |
| 6805 | android_app { |
| 6806 | name: "AppFoo", |
| 6807 | srcs: ["foo/bar/MyClass.java"], |
| 6808 | sdk_version: "none", |
| 6809 | system_modules: "none", |
| 6810 | apex_available: [ "myapex" ], |
| 6811 | } |
Jiyong Park | cfaa164 | 2020-02-28 16:51:07 +0900 | [diff] [blame] | 6812 | `, withManifestPackageNameOverrides([]string{"AppFoo:com.android.foo"})) |
Jiyong Park | bd15961 | 2020-02-28 15:22:21 +0900 | [diff] [blame] | 6813 | |
Colin Cross | cf371cc | 2020-11-13 11:48:42 -0800 | [diff] [blame] | 6814 | bundleConfigRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("bundle_config.json") |
Jiyong Park | bd15961 | 2020-02-28 15:22:21 +0900 | [diff] [blame] | 6815 | content := bundleConfigRule.Args["content"] |
| 6816 | |
| 6817 | ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`) |
Jiyong Park | cfaa164 | 2020-02-28 16:51:07 +0900 | [diff] [blame] | 6818 | ensureContains(t, content, `"apex_config":{"apex_embedded_apk_config":[{"package_name":"com.android.foo","path":"app/AppFoo/AppFoo.apk"}]}`) |
Jiyong Park | bd15961 | 2020-02-28 15:22:21 +0900 | [diff] [blame] | 6819 | } |
| 6820 | |
Sasha Smundak | 18d98bc | 2020-05-27 16:36:07 -0700 | [diff] [blame] | 6821 | func TestAppSetBundle(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 6822 | ctx := testApex(t, ` |
Sasha Smundak | 18d98bc | 2020-05-27 16:36:07 -0700 | [diff] [blame] | 6823 | apex { |
| 6824 | name: "myapex", |
| 6825 | key: "myapex.key", |
| 6826 | apps: ["AppSet"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6827 | updatable: false, |
Sasha Smundak | 18d98bc | 2020-05-27 16:36:07 -0700 | [diff] [blame] | 6828 | } |
| 6829 | |
| 6830 | apex_key { |
| 6831 | name: "myapex.key", |
| 6832 | public_key: "testkey.avbpubkey", |
| 6833 | private_key: "testkey.pem", |
| 6834 | } |
| 6835 | |
| 6836 | android_app_set { |
| 6837 | name: "AppSet", |
| 6838 | set: "AppSet.apks", |
| 6839 | }`) |
| 6840 | mod := ctx.ModuleForTests("myapex", "android_common_myapex_image") |
Colin Cross | cf371cc | 2020-11-13 11:48:42 -0800 | [diff] [blame] | 6841 | bundleConfigRule := mod.Output("bundle_config.json") |
Sasha Smundak | 18d98bc | 2020-05-27 16:36:07 -0700 | [diff] [blame] | 6842 | content := bundleConfigRule.Args["content"] |
| 6843 | ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`) |
| 6844 | s := mod.Rule("apexRule").Args["copy_commands"] |
| 6845 | copyCmds := regexp.MustCompile(" *&& *").Split(s, -1) |
| 6846 | if len(copyCmds) != 3 { |
| 6847 | t.Fatalf("Expected 3 commands, got %d in:\n%s", len(copyCmds), s) |
| 6848 | } |
| 6849 | ensureMatches(t, copyCmds[0], "^rm -rf .*/app/AppSet$") |
| 6850 | ensureMatches(t, copyCmds[1], "^mkdir -p .*/app/AppSet$") |
| 6851 | ensureMatches(t, copyCmds[2], "^unzip .*-d .*/app/AppSet .*/AppSet.zip$") |
| 6852 | } |
| 6853 | |
Evgenii Stepanov | 2080bfe | 2020-07-24 15:35:40 -0700 | [diff] [blame] | 6854 | func TestAppSetBundlePrebuilt(t *testing.T) { |
Paul Duffin | 2470467 | 2021-04-06 16:09:30 +0100 | [diff] [blame] | 6855 | bp := ` |
Evgenii Stepanov | 2080bfe | 2020-07-24 15:35:40 -0700 | [diff] [blame] | 6856 | apex_set { |
| 6857 | name: "myapex", |
| 6858 | filename: "foo_v2.apex", |
| 6859 | sanitized: { |
| 6860 | none: { set: "myapex.apks", }, |
| 6861 | hwaddress: { set: "myapex.hwasan.apks", }, |
| 6862 | }, |
Paul Duffin | 2470467 | 2021-04-06 16:09:30 +0100 | [diff] [blame] | 6863 | } |
| 6864 | ` |
| 6865 | ctx := testApex(t, bp, prepareForTestWithSantitizeHwaddress) |
Evgenii Stepanov | 2080bfe | 2020-07-24 15:35:40 -0700 | [diff] [blame] | 6866 | |
Paul Duffin | 2470467 | 2021-04-06 16:09:30 +0100 | [diff] [blame] | 6867 | // Check that the extractor produces the correct output file from the correct input file. |
| 6868 | extractorOutput := "out/soong/.intermediates/myapex.apex.extractor/android_common/extracted/myapex.hwasan.apks" |
Evgenii Stepanov | 2080bfe | 2020-07-24 15:35:40 -0700 | [diff] [blame] | 6869 | |
Paul Duffin | 2470467 | 2021-04-06 16:09:30 +0100 | [diff] [blame] | 6870 | m := ctx.ModuleForTests("myapex.apex.extractor", "android_common") |
| 6871 | extractedApex := m.Output(extractorOutput) |
Evgenii Stepanov | 2080bfe | 2020-07-24 15:35:40 -0700 | [diff] [blame] | 6872 | |
Paul Duffin | 2470467 | 2021-04-06 16:09:30 +0100 | [diff] [blame] | 6873 | android.AssertArrayString(t, "extractor input", []string{"myapex.hwasan.apks"}, extractedApex.Inputs.Strings()) |
| 6874 | |
| 6875 | // Ditto for the apex. |
Paul Duffin | 6717d88 | 2021-06-15 19:09:41 +0100 | [diff] [blame] | 6876 | m = ctx.ModuleForTests("myapex", "android_common_myapex") |
| 6877 | copiedApex := m.Output("out/soong/.intermediates/myapex/android_common_myapex/foo_v2.apex") |
Paul Duffin | 2470467 | 2021-04-06 16:09:30 +0100 | [diff] [blame] | 6878 | |
| 6879 | android.AssertStringEquals(t, "myapex input", extractorOutput, copiedApex.Input.String()) |
Evgenii Stepanov | 2080bfe | 2020-07-24 15:35:40 -0700 | [diff] [blame] | 6880 | } |
| 6881 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6882 | func testNoUpdatableJarsInBootImage(t *testing.T, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) { |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6883 | t.Helper() |
| 6884 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6885 | bp := ` |
| 6886 | java_library { |
| 6887 | name: "some-updatable-apex-lib", |
| 6888 | srcs: ["a.java"], |
| 6889 | sdk_version: "current", |
| 6890 | apex_available: [ |
| 6891 | "some-updatable-apex", |
| 6892 | ], |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 6893 | permitted_packages: ["some.updatable.apex.lib"], |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6894 | } |
| 6895 | |
| 6896 | java_library { |
| 6897 | name: "some-non-updatable-apex-lib", |
| 6898 | srcs: ["a.java"], |
| 6899 | apex_available: [ |
| 6900 | "some-non-updatable-apex", |
| 6901 | ], |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6902 | compile_dex: true, |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 6903 | permitted_packages: ["some.non.updatable.apex.lib"], |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6904 | } |
| 6905 | |
| 6906 | bootclasspath_fragment { |
| 6907 | name: "some-non-updatable-fragment", |
| 6908 | contents: ["some-non-updatable-apex-lib"], |
| 6909 | apex_available: [ |
| 6910 | "some-non-updatable-apex", |
| 6911 | ], |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6912 | } |
| 6913 | |
| 6914 | java_library { |
| 6915 | name: "some-platform-lib", |
| 6916 | srcs: ["a.java"], |
| 6917 | sdk_version: "current", |
| 6918 | installable: true, |
| 6919 | } |
| 6920 | |
| 6921 | java_library { |
| 6922 | name: "some-art-lib", |
| 6923 | srcs: ["a.java"], |
| 6924 | sdk_version: "current", |
| 6925 | apex_available: [ |
Paul Duffin | d376f79 | 2021-01-26 11:59:35 +0000 | [diff] [blame] | 6926 | "com.android.art.debug", |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6927 | ], |
| 6928 | hostdex: true, |
Paul Duffin | e521881 | 2021-06-07 13:28:19 +0100 | [diff] [blame] | 6929 | compile_dex: true, |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6930 | } |
| 6931 | |
| 6932 | apex { |
| 6933 | name: "some-updatable-apex", |
| 6934 | key: "some-updatable-apex.key", |
| 6935 | java_libs: ["some-updatable-apex-lib"], |
| 6936 | updatable: true, |
| 6937 | min_sdk_version: "current", |
| 6938 | } |
| 6939 | |
| 6940 | apex { |
| 6941 | name: "some-non-updatable-apex", |
| 6942 | key: "some-non-updatable-apex.key", |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6943 | bootclasspath_fragments: ["some-non-updatable-fragment"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 6944 | updatable: false, |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6945 | } |
| 6946 | |
| 6947 | apex_key { |
| 6948 | name: "some-updatable-apex.key", |
| 6949 | } |
| 6950 | |
| 6951 | apex_key { |
| 6952 | name: "some-non-updatable-apex.key", |
| 6953 | } |
| 6954 | |
| 6955 | apex { |
Paul Duffin | d376f79 | 2021-01-26 11:59:35 +0000 | [diff] [blame] | 6956 | name: "com.android.art.debug", |
| 6957 | key: "com.android.art.debug.key", |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6958 | bootclasspath_fragments: ["art-bootclasspath-fragment"], |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6959 | updatable: true, |
| 6960 | min_sdk_version: "current", |
| 6961 | } |
| 6962 | |
Paul Duffin | f23bc47 | 2021-04-27 12:42:20 +0100 | [diff] [blame] | 6963 | bootclasspath_fragment { |
| 6964 | name: "art-bootclasspath-fragment", |
| 6965 | image_name: "art", |
| 6966 | contents: ["some-art-lib"], |
| 6967 | apex_available: [ |
| 6968 | "com.android.art.debug", |
| 6969 | ], |
| 6970 | } |
| 6971 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6972 | apex_key { |
Paul Duffin | d376f79 | 2021-01-26 11:59:35 +0000 | [diff] [blame] | 6973 | name: "com.android.art.debug.key", |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 6974 | } |
| 6975 | |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6976 | filegroup { |
| 6977 | name: "some-updatable-apex-file_contexts", |
| 6978 | srcs: [ |
| 6979 | "system/sepolicy/apex/some-updatable-apex-file_contexts", |
| 6980 | ], |
| 6981 | } |
Ulya Trafimovich | 7c140d8 | 2020-04-22 18:05:58 +0100 | [diff] [blame] | 6982 | |
| 6983 | filegroup { |
| 6984 | name: "some-non-updatable-apex-file_contexts", |
| 6985 | srcs: [ |
| 6986 | "system/sepolicy/apex/some-non-updatable-apex-file_contexts", |
| 6987 | ], |
| 6988 | } |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 6989 | ` |
Paul Duffin | c3bbb96 | 2020-12-10 19:15:49 +0000 | [diff] [blame] | 6990 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6991 | testDexpreoptWithApexes(t, bp, errmsg, preparer, fragments...) |
Paul Duffin | c3bbb96 | 2020-12-10 19:15:49 +0000 | [diff] [blame] | 6992 | } |
| 6993 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 6994 | func testDexpreoptWithApexes(t *testing.T, bp, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) *android.TestContext { |
Paul Duffin | c3bbb96 | 2020-12-10 19:15:49 +0000 | [diff] [blame] | 6995 | t.Helper() |
| 6996 | |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 6997 | fs := android.MockFS{ |
| 6998 | "a.java": nil, |
| 6999 | "a.jar": nil, |
| 7000 | "apex_manifest.json": nil, |
| 7001 | "AndroidManifest.xml": nil, |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 7002 | "system/sepolicy/apex/myapex-file_contexts": nil, |
Paul Duffin | d376f79 | 2021-01-26 11:59:35 +0000 | [diff] [blame] | 7003 | "system/sepolicy/apex/some-updatable-apex-file_contexts": nil, |
| 7004 | "system/sepolicy/apex/some-non-updatable-apex-file_contexts": nil, |
| 7005 | "system/sepolicy/apex/com.android.art.debug-file_contexts": nil, |
Martin Stjernholm | 1dc0d6d | 2021-01-17 21:05:12 +0000 | [diff] [blame] | 7006 | "framework/aidl/a.aidl": nil, |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 7007 | } |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 7008 | |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 7009 | errorHandler := android.FixtureExpectsNoErrors |
| 7010 | if errmsg != "" { |
| 7011 | errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 7012 | } |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 7013 | |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 7014 | result := android.GroupFixturePreparers( |
| 7015 | cc.PrepareForTestWithCcDefaultModules, |
| 7016 | java.PrepareForTestWithHiddenApiBuildComponents, |
| 7017 | java.PrepareForTestWithJavaDefaultModules, |
| 7018 | java.PrepareForTestWithJavaSdkLibraryFiles, |
| 7019 | PrepareForTestWithApexBuildComponents, |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 7020 | preparer, |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 7021 | fs.AddToFixture(), |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 7022 | android.FixtureModifyMockFS(func(fs android.MockFS) { |
| 7023 | if _, ok := fs["frameworks/base/boot/Android.bp"]; !ok { |
| 7024 | insert := "" |
| 7025 | for _, fragment := range fragments { |
| 7026 | insert += fmt.Sprintf("{apex: %q, module: %q},\n", *fragment.Apex, *fragment.Module) |
| 7027 | } |
| 7028 | fs["frameworks/base/boot/Android.bp"] = []byte(fmt.Sprintf(` |
| 7029 | platform_bootclasspath { |
| 7030 | name: "platform-bootclasspath", |
| 7031 | fragments: [ |
| 7032 | %s |
| 7033 | ], |
| 7034 | } |
| 7035 | `, insert)) |
Paul Duffin | 8f146b9 | 2021-04-12 17:24:18 +0100 | [diff] [blame] | 7036 | } |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 7037 | }), |
Paul Duffin | 5560712 | 2021-03-30 23:32:51 +0100 | [diff] [blame] | 7038 | ). |
| 7039 | ExtendWithErrorHandler(errorHandler). |
| 7040 | RunTestWithBp(t, bp) |
| 7041 | |
| 7042 | return result.TestContext |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 7043 | } |
| 7044 | |
Jooyung Han | 548640b | 2020-04-27 12:10:30 +0900 | [diff] [blame] | 7045 | func TestUpdatable_should_set_min_sdk_version(t *testing.T) { |
| 7046 | testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, ` |
| 7047 | apex { |
| 7048 | name: "myapex", |
| 7049 | key: "myapex.key", |
| 7050 | updatable: true, |
| 7051 | } |
| 7052 | |
| 7053 | apex_key { |
| 7054 | name: "myapex.key", |
| 7055 | public_key: "testkey.avbpubkey", |
| 7056 | private_key: "testkey.pem", |
| 7057 | } |
| 7058 | `) |
| 7059 | } |
| 7060 | |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7061 | func TestUpdatableDefault_should_set_min_sdk_version(t *testing.T) { |
| 7062 | testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, ` |
| 7063 | apex { |
| 7064 | name: "myapex", |
| 7065 | key: "myapex.key", |
| 7066 | } |
| 7067 | |
| 7068 | apex_key { |
| 7069 | name: "myapex.key", |
| 7070 | public_key: "testkey.avbpubkey", |
| 7071 | private_key: "testkey.pem", |
| 7072 | } |
| 7073 | `) |
| 7074 | } |
| 7075 | |
satayev | b98371c | 2021-06-15 16:49:50 +0100 | [diff] [blame] | 7076 | func TestUpdatable_should_not_set_generate_classpaths_proto(t *testing.T) { |
| 7077 | testApexError(t, `"mysystemserverclasspathfragment" .* it must not set generate_classpaths_proto to false`, ` |
| 7078 | apex { |
| 7079 | name: "myapex", |
| 7080 | key: "myapex.key", |
| 7081 | systemserverclasspath_fragments: [ |
| 7082 | "mysystemserverclasspathfragment", |
| 7083 | ], |
| 7084 | min_sdk_version: "29", |
| 7085 | updatable: true, |
| 7086 | } |
| 7087 | |
| 7088 | apex_key { |
| 7089 | name: "myapex.key", |
| 7090 | public_key: "testkey.avbpubkey", |
| 7091 | private_key: "testkey.pem", |
| 7092 | } |
| 7093 | |
| 7094 | java_library { |
| 7095 | name: "foo", |
| 7096 | srcs: ["b.java"], |
| 7097 | min_sdk_version: "29", |
| 7098 | installable: true, |
| 7099 | apex_available: [ |
| 7100 | "myapex", |
| 7101 | ], |
| 7102 | } |
| 7103 | |
| 7104 | systemserverclasspath_fragment { |
| 7105 | name: "mysystemserverclasspathfragment", |
| 7106 | generate_classpaths_proto: false, |
| 7107 | contents: [ |
| 7108 | "foo", |
| 7109 | ], |
| 7110 | apex_available: [ |
| 7111 | "myapex", |
| 7112 | ], |
| 7113 | } |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 7114 | `, |
| 7115 | dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"), |
| 7116 | ) |
satayev | b98371c | 2021-06-15 16:49:50 +0100 | [diff] [blame] | 7117 | } |
| 7118 | |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 7119 | func TestNoUpdatableJarsInBootImage(t *testing.T) { |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 7120 | // Set the BootJars in dexpreopt.GlobalConfig and productVariables to the same value. This can |
| 7121 | // result in an invalid configuration as it does not set the ArtApexJars and allows art apex |
| 7122 | // modules to be included in the BootJars. |
| 7123 | prepareSetBootJars := func(bootJars ...string) android.FixturePreparer { |
| 7124 | return android.GroupFixturePreparers( |
| 7125 | dexpreopt.FixtureSetBootJars(bootJars...), |
| 7126 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 7127 | variables.BootJars = android.CreateTestConfiguredJarList(bootJars) |
| 7128 | }), |
| 7129 | ) |
| 7130 | } |
| 7131 | |
| 7132 | // Set the ArtApexJars and BootJars in dexpreopt.GlobalConfig and productVariables all to the |
| 7133 | // same value. This can result in an invalid configuration as it allows non art apex jars to be |
| 7134 | // specified in the ArtApexJars configuration. |
| 7135 | prepareSetArtJars := func(bootJars ...string) android.FixturePreparer { |
| 7136 | return android.GroupFixturePreparers( |
| 7137 | dexpreopt.FixtureSetArtBootJars(bootJars...), |
| 7138 | dexpreopt.FixtureSetBootJars(bootJars...), |
| 7139 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 7140 | variables.BootJars = android.CreateTestConfiguredJarList(bootJars) |
| 7141 | }), |
| 7142 | ) |
| 7143 | } |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 7144 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7145 | t.Run("updatable jar from ART apex in the ART boot image => ok", func(t *testing.T) { |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 7146 | preparer := android.GroupFixturePreparers( |
| 7147 | java.FixtureConfigureBootJars("com.android.art.debug:some-art-lib"), |
| 7148 | java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"), |
| 7149 | ) |
| 7150 | fragments := []java.ApexVariantReference{ |
| 7151 | { |
| 7152 | Apex: proptools.StringPtr("com.android.art.debug"), |
| 7153 | Module: proptools.StringPtr("art-bootclasspath-fragment"), |
| 7154 | }, |
| 7155 | { |
| 7156 | Apex: proptools.StringPtr("some-non-updatable-apex"), |
| 7157 | Module: proptools.StringPtr("some-non-updatable-fragment"), |
| 7158 | }, |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 7159 | } |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 7160 | testNoUpdatableJarsInBootImage(t, "", preparer, fragments...) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7161 | }) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 7162 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7163 | t.Run("updatable jar from ART apex in the framework boot image => error", func(t *testing.T) { |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 7164 | err := `module "some-art-lib" from updatable apexes \["com.android.art.debug"\] is not allowed in the framework boot image` |
| 7165 | // Update the dexpreopt BootJars directly. |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 7166 | preparer := android.GroupFixturePreparers( |
| 7167 | prepareSetBootJars("com.android.art.debug:some-art-lib"), |
| 7168 | java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"), |
| 7169 | ) |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 7170 | testNoUpdatableJarsInBootImage(t, err, preparer) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7171 | }) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 7172 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7173 | t.Run("updatable jar from some other apex in the ART boot image => error", func(t *testing.T) { |
Paul Duffin | f23bc47 | 2021-04-27 12:42:20 +0100 | [diff] [blame] | 7174 | err := `ArtApexJars expects this to be in apex "some-updatable-apex" but this is only in apexes.*"com.android.art.debug"` |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 7175 | // Update the dexpreopt ArtApexJars directly. |
| 7176 | preparer := prepareSetArtJars("some-updatable-apex:some-updatable-apex-lib") |
| 7177 | testNoUpdatableJarsInBootImage(t, err, preparer) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7178 | }) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 7179 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7180 | t.Run("non-updatable jar from some other apex in the ART boot image => error", func(t *testing.T) { |
Paul Duffin | f23bc47 | 2021-04-27 12:42:20 +0100 | [diff] [blame] | 7181 | err := `ArtApexJars expects this to be in apex "some-non-updatable-apex" but this is only in apexes.*"com.android.art.debug"` |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 7182 | // Update the dexpreopt ArtApexJars directly. |
| 7183 | preparer := prepareSetArtJars("some-non-updatable-apex:some-non-updatable-apex-lib") |
| 7184 | testNoUpdatableJarsInBootImage(t, err, preparer) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7185 | }) |
Ulya Trafimovich | 7c140d8 | 2020-04-22 18:05:58 +0100 | [diff] [blame] | 7186 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7187 | t.Run("updatable jar from some other apex in the framework boot image => error", func(t *testing.T) { |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 7188 | err := `module "some-updatable-apex-lib" from updatable apexes \["some-updatable-apex"\] is not allowed in the framework boot image` |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 7189 | preparer := android.GroupFixturePreparers( |
| 7190 | java.FixtureConfigureBootJars("some-updatable-apex:some-updatable-apex-lib"), |
| 7191 | java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"), |
| 7192 | ) |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 7193 | testNoUpdatableJarsInBootImage(t, err, preparer) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7194 | }) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 7195 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7196 | t.Run("non-updatable jar from some other apex in the framework boot image => ok", func(t *testing.T) { |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 7197 | preparer := java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib") |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 7198 | fragment := java.ApexVariantReference{ |
| 7199 | Apex: proptools.StringPtr("some-non-updatable-apex"), |
| 7200 | Module: proptools.StringPtr("some-non-updatable-fragment"), |
| 7201 | } |
| 7202 | testNoUpdatableJarsInBootImage(t, "", preparer, fragment) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7203 | }) |
Ulya Trafimovich | 7c140d8 | 2020-04-22 18:05:58 +0100 | [diff] [blame] | 7204 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7205 | t.Run("nonexistent jar in the ART boot image => error", func(t *testing.T) { |
Paul Duffin | 8f146b9 | 2021-04-12 17:24:18 +0100 | [diff] [blame] | 7206 | err := `"platform-bootclasspath" depends on undefined module "nonexistent"` |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 7207 | preparer := java.FixtureConfigureBootJars("platform:nonexistent") |
| 7208 | testNoUpdatableJarsInBootImage(t, err, preparer) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7209 | }) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 7210 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7211 | t.Run("nonexistent jar in the framework boot image => error", func(t *testing.T) { |
Paul Duffin | 8f146b9 | 2021-04-12 17:24:18 +0100 | [diff] [blame] | 7212 | err := `"platform-bootclasspath" depends on undefined module "nonexistent"` |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 7213 | preparer := java.FixtureConfigureBootJars("platform:nonexistent") |
| 7214 | testNoUpdatableJarsInBootImage(t, err, preparer) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7215 | }) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 7216 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7217 | t.Run("platform jar in the ART boot image => error", func(t *testing.T) { |
Paul Duffin | f23bc47 | 2021-04-27 12:42:20 +0100 | [diff] [blame] | 7218 | err := `ArtApexJars is invalid as it requests a platform variant of "some-platform-lib"` |
Paul Duffin | 60264a0 | 2021-04-12 20:02:36 +0100 | [diff] [blame] | 7219 | // Update the dexpreopt ArtApexJars directly. |
| 7220 | preparer := prepareSetArtJars("platform:some-platform-lib") |
| 7221 | testNoUpdatableJarsInBootImage(t, err, preparer) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7222 | }) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 7223 | |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7224 | t.Run("platform jar in the framework boot image => ok", func(t *testing.T) { |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 7225 | preparer := android.GroupFixturePreparers( |
| 7226 | java.FixtureConfigureBootJars("platform:some-platform-lib"), |
| 7227 | java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"), |
| 7228 | ) |
| 7229 | fragments := []java.ApexVariantReference{ |
| 7230 | { |
| 7231 | Apex: proptools.StringPtr("some-non-updatable-apex"), |
| 7232 | Module: proptools.StringPtr("some-non-updatable-fragment"), |
| 7233 | }, |
| 7234 | } |
| 7235 | testNoUpdatableJarsInBootImage(t, "", preparer, fragments...) |
Ulya Trafimovich | 7caef20 | 2020-05-19 12:00:52 +0100 | [diff] [blame] | 7236 | }) |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 7237 | } |
| 7238 | |
| 7239 | func TestDexpreoptAccessDexFilesFromPrebuiltApex(t *testing.T) { |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 7240 | preparer := java.FixtureConfigureApexBootJars("myapex:libfoo") |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 7241 | t.Run("prebuilt no source", func(t *testing.T) { |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 7242 | fragment := java.ApexVariantReference{ |
| 7243 | Apex: proptools.StringPtr("myapex"), |
| 7244 | Module: proptools.StringPtr("my-bootclasspath-fragment"), |
| 7245 | } |
| 7246 | |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 7247 | testDexpreoptWithApexes(t, ` |
| 7248 | prebuilt_apex { |
| 7249 | name: "myapex" , |
| 7250 | arch: { |
| 7251 | arm64: { |
| 7252 | src: "myapex-arm64.apex", |
| 7253 | }, |
| 7254 | arm: { |
| 7255 | src: "myapex-arm.apex", |
| 7256 | }, |
| 7257 | }, |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 7258 | exported_bootclasspath_fragments: ["my-bootclasspath-fragment"], |
| 7259 | } |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 7260 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 7261 | prebuilt_bootclasspath_fragment { |
| 7262 | name: "my-bootclasspath-fragment", |
| 7263 | contents: ["libfoo"], |
| 7264 | apex_available: ["myapex"], |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 7265 | hidden_api: { |
| 7266 | annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv", |
| 7267 | metadata: "my-bootclasspath-fragment/metadata.csv", |
| 7268 | index: "my-bootclasspath-fragment/index.csv", |
Paul Duffin | 191be3a | 2021-08-10 16:14:16 +0100 | [diff] [blame] | 7269 | signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv", |
| 7270 | filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv", |
| 7271 | filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv", |
Paul Duffin | 54e4197 | 2021-07-19 13:23:40 +0100 | [diff] [blame] | 7272 | }, |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 7273 | } |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 7274 | |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 7275 | java_import { |
| 7276 | name: "libfoo", |
| 7277 | jars: ["libfoo.jar"], |
| 7278 | apex_available: ["myapex"], |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 7279 | permitted_packages: ["libfoo"], |
Paul Duffin | 89f570a | 2021-06-16 01:42:33 +0100 | [diff] [blame] | 7280 | } |
| 7281 | `, "", preparer, fragment) |
Paul Duffin | 064b70c | 2020-11-02 17:32:38 +0000 | [diff] [blame] | 7282 | }) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 7283 | } |
| 7284 | |
satayev | d604b21 | 2021-07-21 14:23:52 +0100 | [diff] [blame] | 7285 | func testApexPermittedPackagesRules(t *testing.T, errmsg, bp string, bootJars []string, rules []android.Rule) { |
Andrei Onea | 115e7e7 | 2020-06-05 21:14:03 +0100 | [diff] [blame] | 7286 | t.Helper() |
Andrei Onea | 115e7e7 | 2020-06-05 21:14:03 +0100 | [diff] [blame] | 7287 | bp += ` |
| 7288 | apex_key { |
| 7289 | name: "myapex.key", |
| 7290 | public_key: "testkey.avbpubkey", |
| 7291 | private_key: "testkey.pem", |
| 7292 | }` |
Paul Duffin | 45338f0 | 2021-03-30 23:07:52 +0100 | [diff] [blame] | 7293 | fs := android.MockFS{ |
Andrei Onea | 115e7e7 | 2020-06-05 21:14:03 +0100 | [diff] [blame] | 7294 | "lib1/src/A.java": nil, |
| 7295 | "lib2/src/B.java": nil, |
| 7296 | "system/sepolicy/apex/myapex-file_contexts": nil, |
| 7297 | } |
| 7298 | |
Paul Duffin | 45338f0 | 2021-03-30 23:07:52 +0100 | [diff] [blame] | 7299 | errorHandler := android.FixtureExpectsNoErrors |
| 7300 | if errmsg != "" { |
| 7301 | errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg) |
Colin Cross | ae8600b | 2020-10-29 17:09:13 -0700 | [diff] [blame] | 7302 | } |
Colin Cross | ae8600b | 2020-10-29 17:09:13 -0700 | [diff] [blame] | 7303 | |
Paul Duffin | 45338f0 | 2021-03-30 23:07:52 +0100 | [diff] [blame] | 7304 | android.GroupFixturePreparers( |
| 7305 | android.PrepareForTestWithAndroidBuildComponents, |
| 7306 | java.PrepareForTestWithJavaBuildComponents, |
| 7307 | PrepareForTestWithApexBuildComponents, |
| 7308 | android.PrepareForTestWithNeverallowRules(rules), |
| 7309 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
satayev | d604b21 | 2021-07-21 14:23:52 +0100 | [diff] [blame] | 7310 | apexBootJars := make([]string, 0, len(bootJars)) |
| 7311 | for _, apexBootJar := range bootJars { |
| 7312 | apexBootJars = append(apexBootJars, "myapex:"+apexBootJar) |
Paul Duffin | 45338f0 | 2021-03-30 23:07:52 +0100 | [diff] [blame] | 7313 | } |
satayev | d604b21 | 2021-07-21 14:23:52 +0100 | [diff] [blame] | 7314 | variables.ApexBootJars = android.CreateTestConfiguredJarList(apexBootJars) |
Paul Duffin | 45338f0 | 2021-03-30 23:07:52 +0100 | [diff] [blame] | 7315 | }), |
| 7316 | fs.AddToFixture(), |
| 7317 | ). |
| 7318 | ExtendWithErrorHandler(errorHandler). |
| 7319 | RunTestWithBp(t, bp) |
Andrei Onea | 115e7e7 | 2020-06-05 21:14:03 +0100 | [diff] [blame] | 7320 | } |
| 7321 | |
| 7322 | func TestApexPermittedPackagesRules(t *testing.T) { |
| 7323 | testcases := []struct { |
| 7324 | name string |
| 7325 | expectedError string |
| 7326 | bp string |
| 7327 | bootJars []string |
| 7328 | modulesPackages map[string][]string |
| 7329 | }{ |
| 7330 | |
| 7331 | { |
| 7332 | name: "Non-Bootclasspath apex jar not satisfying allowed module packages.", |
| 7333 | expectedError: "", |
| 7334 | bp: ` |
| 7335 | java_library { |
| 7336 | name: "bcp_lib1", |
| 7337 | srcs: ["lib1/src/*.java"], |
| 7338 | permitted_packages: ["foo.bar"], |
| 7339 | apex_available: ["myapex"], |
| 7340 | sdk_version: "none", |
| 7341 | system_modules: "none", |
| 7342 | } |
| 7343 | java_library { |
| 7344 | name: "nonbcp_lib2", |
| 7345 | srcs: ["lib2/src/*.java"], |
| 7346 | apex_available: ["myapex"], |
| 7347 | permitted_packages: ["a.b"], |
| 7348 | sdk_version: "none", |
| 7349 | system_modules: "none", |
| 7350 | } |
| 7351 | apex { |
| 7352 | name: "myapex", |
| 7353 | key: "myapex.key", |
| 7354 | java_libs: ["bcp_lib1", "nonbcp_lib2"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7355 | updatable: false, |
Andrei Onea | 115e7e7 | 2020-06-05 21:14:03 +0100 | [diff] [blame] | 7356 | }`, |
| 7357 | bootJars: []string{"bcp_lib1"}, |
| 7358 | modulesPackages: map[string][]string{ |
| 7359 | "myapex": []string{ |
| 7360 | "foo.bar", |
| 7361 | }, |
| 7362 | }, |
| 7363 | }, |
| 7364 | { |
| 7365 | name: "Bootclasspath apex jar not satisfying allowed module packages.", |
| 7366 | expectedError: `module "bcp_lib2" .* which is restricted because jars that are part of the myapex module may only allow these packages: foo.bar. Please jarjar or move code around.`, |
| 7367 | bp: ` |
| 7368 | java_library { |
| 7369 | name: "bcp_lib1", |
| 7370 | srcs: ["lib1/src/*.java"], |
| 7371 | apex_available: ["myapex"], |
| 7372 | permitted_packages: ["foo.bar"], |
| 7373 | sdk_version: "none", |
| 7374 | system_modules: "none", |
| 7375 | } |
| 7376 | java_library { |
| 7377 | name: "bcp_lib2", |
| 7378 | srcs: ["lib2/src/*.java"], |
| 7379 | apex_available: ["myapex"], |
| 7380 | permitted_packages: ["foo.bar", "bar.baz"], |
| 7381 | sdk_version: "none", |
| 7382 | system_modules: "none", |
| 7383 | } |
| 7384 | apex { |
| 7385 | name: "myapex", |
| 7386 | key: "myapex.key", |
| 7387 | java_libs: ["bcp_lib1", "bcp_lib2"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7388 | updatable: false, |
Andrei Onea | 115e7e7 | 2020-06-05 21:14:03 +0100 | [diff] [blame] | 7389 | } |
| 7390 | `, |
| 7391 | bootJars: []string{"bcp_lib1", "bcp_lib2"}, |
| 7392 | modulesPackages: map[string][]string{ |
| 7393 | "myapex": []string{ |
| 7394 | "foo.bar", |
| 7395 | }, |
| 7396 | }, |
| 7397 | }, |
| 7398 | } |
| 7399 | for _, tc := range testcases { |
| 7400 | t.Run(tc.name, func(t *testing.T) { |
| 7401 | rules := createApexPermittedPackagesRules(tc.modulesPackages) |
| 7402 | testApexPermittedPackagesRules(t, tc.expectedError, tc.bp, tc.bootJars, rules) |
| 7403 | }) |
| 7404 | } |
| 7405 | } |
| 7406 | |
Jiyong Park | 62304bb | 2020-04-13 16:19:48 +0900 | [diff] [blame] | 7407 | func TestTestFor(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 7408 | ctx := testApex(t, ` |
Jiyong Park | 62304bb | 2020-04-13 16:19:48 +0900 | [diff] [blame] | 7409 | apex { |
| 7410 | name: "myapex", |
| 7411 | key: "myapex.key", |
| 7412 | native_shared_libs: ["mylib", "myprivlib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7413 | updatable: false, |
Jiyong Park | 62304bb | 2020-04-13 16:19:48 +0900 | [diff] [blame] | 7414 | } |
| 7415 | |
| 7416 | apex_key { |
| 7417 | name: "myapex.key", |
| 7418 | public_key: "testkey.avbpubkey", |
| 7419 | private_key: "testkey.pem", |
| 7420 | } |
| 7421 | |
| 7422 | cc_library { |
| 7423 | name: "mylib", |
| 7424 | srcs: ["mylib.cpp"], |
| 7425 | system_shared_libs: [], |
| 7426 | stl: "none", |
| 7427 | stubs: { |
| 7428 | versions: ["1"], |
| 7429 | }, |
| 7430 | apex_available: ["myapex"], |
| 7431 | } |
| 7432 | |
| 7433 | cc_library { |
| 7434 | name: "myprivlib", |
| 7435 | srcs: ["mylib.cpp"], |
| 7436 | system_shared_libs: [], |
| 7437 | stl: "none", |
| 7438 | apex_available: ["myapex"], |
| 7439 | } |
| 7440 | |
| 7441 | |
| 7442 | cc_test { |
| 7443 | name: "mytest", |
| 7444 | gtest: false, |
| 7445 | srcs: ["mylib.cpp"], |
| 7446 | system_shared_libs: [], |
| 7447 | stl: "none", |
Jiyong Park | 46a512f | 2020-12-04 18:02:13 +0900 | [diff] [blame] | 7448 | shared_libs: ["mylib", "myprivlib", "mytestlib"], |
Jiyong Park | 62304bb | 2020-04-13 16:19:48 +0900 | [diff] [blame] | 7449 | test_for: ["myapex"] |
| 7450 | } |
Jiyong Park | 46a512f | 2020-12-04 18:02:13 +0900 | [diff] [blame] | 7451 | |
| 7452 | cc_library { |
| 7453 | name: "mytestlib", |
| 7454 | srcs: ["mylib.cpp"], |
| 7455 | system_shared_libs: [], |
| 7456 | shared_libs: ["mylib", "myprivlib"], |
| 7457 | stl: "none", |
| 7458 | test_for: ["myapex"], |
| 7459 | } |
| 7460 | |
| 7461 | cc_benchmark { |
| 7462 | name: "mybench", |
| 7463 | srcs: ["mylib.cpp"], |
| 7464 | system_shared_libs: [], |
| 7465 | shared_libs: ["mylib", "myprivlib"], |
| 7466 | stl: "none", |
| 7467 | test_for: ["myapex"], |
| 7468 | } |
Jiyong Park | 62304bb | 2020-04-13 16:19:48 +0900 | [diff] [blame] | 7469 | `) |
| 7470 | |
Martin Stjernholm | 4e6c269 | 2021-03-25 01:25:06 +0000 | [diff] [blame] | 7471 | ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) { |
Paul Duffin | a71a67a | 2021-03-29 00:42:57 +0100 | [diff] [blame] | 7472 | ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ") |
Martin Stjernholm | 4e6c269 | 2021-03-25 01:25:06 +0000 | [diff] [blame] | 7473 | mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) }) |
| 7474 | android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags) |
| 7475 | } |
| 7476 | |
| 7477 | // These modules are tests for the apex, therefore are linked to the |
Jiyong Park | 62304bb | 2020-04-13 16:19:48 +0900 | [diff] [blame] | 7478 | // actual implementation of mylib instead of its stub. |
Martin Stjernholm | 4e6c269 | 2021-03-25 01:25:06 +0000 | [diff] [blame] | 7479 | ensureLinkedLibIs("mytest", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so") |
| 7480 | ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so") |
| 7481 | ensureLinkedLibIs("mybench", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so") |
| 7482 | } |
Jiyong Park | 46a512f | 2020-12-04 18:02:13 +0900 | [diff] [blame] | 7483 | |
Martin Stjernholm | 4e6c269 | 2021-03-25 01:25:06 +0000 | [diff] [blame] | 7484 | func TestIndirectTestFor(t *testing.T) { |
| 7485 | ctx := testApex(t, ` |
| 7486 | apex { |
| 7487 | name: "myapex", |
| 7488 | key: "myapex.key", |
| 7489 | native_shared_libs: ["mylib", "myprivlib"], |
| 7490 | updatable: false, |
| 7491 | } |
Jiyong Park | 46a512f | 2020-12-04 18:02:13 +0900 | [diff] [blame] | 7492 | |
Martin Stjernholm | 4e6c269 | 2021-03-25 01:25:06 +0000 | [diff] [blame] | 7493 | apex_key { |
| 7494 | name: "myapex.key", |
| 7495 | public_key: "testkey.avbpubkey", |
| 7496 | private_key: "testkey.pem", |
| 7497 | } |
| 7498 | |
| 7499 | cc_library { |
| 7500 | name: "mylib", |
| 7501 | srcs: ["mylib.cpp"], |
| 7502 | system_shared_libs: [], |
| 7503 | stl: "none", |
| 7504 | stubs: { |
| 7505 | versions: ["1"], |
| 7506 | }, |
| 7507 | apex_available: ["myapex"], |
| 7508 | } |
| 7509 | |
| 7510 | cc_library { |
| 7511 | name: "myprivlib", |
| 7512 | srcs: ["mylib.cpp"], |
| 7513 | system_shared_libs: [], |
| 7514 | stl: "none", |
| 7515 | shared_libs: ["mylib"], |
| 7516 | apex_available: ["myapex"], |
| 7517 | } |
| 7518 | |
| 7519 | cc_library { |
| 7520 | name: "mytestlib", |
| 7521 | srcs: ["mylib.cpp"], |
| 7522 | system_shared_libs: [], |
| 7523 | shared_libs: ["myprivlib"], |
| 7524 | stl: "none", |
| 7525 | test_for: ["myapex"], |
| 7526 | } |
| 7527 | `) |
| 7528 | |
| 7529 | ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) { |
Paul Duffin | a71a67a | 2021-03-29 00:42:57 +0100 | [diff] [blame] | 7530 | ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ") |
Martin Stjernholm | 4e6c269 | 2021-03-25 01:25:06 +0000 | [diff] [blame] | 7531 | mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) }) |
| 7532 | android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags) |
| 7533 | } |
| 7534 | |
| 7535 | // The platform variant of mytestlib links to the platform variant of the |
| 7536 | // internal myprivlib. |
| 7537 | ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/myprivlib/", "android_arm64_armv8-a_shared/myprivlib.so") |
| 7538 | |
| 7539 | // The platform variant of myprivlib links to the platform variant of mylib |
| 7540 | // and bypasses its stubs. |
| 7541 | ensureLinkedLibIs("myprivlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so") |
Jiyong Park | 62304bb | 2020-04-13 16:19:48 +0900 | [diff] [blame] | 7542 | } |
| 7543 | |
Martin Stjernholm | ec00900 | 2021-03-27 15:18:31 +0000 | [diff] [blame] | 7544 | func TestTestForForLibInOtherApex(t *testing.T) { |
| 7545 | // This case is only allowed for known overlapping APEXes, i.e. the ART APEXes. |
| 7546 | _ = testApex(t, ` |
| 7547 | apex { |
| 7548 | name: "com.android.art", |
| 7549 | key: "myapex.key", |
| 7550 | native_shared_libs: ["mylib"], |
| 7551 | updatable: false, |
| 7552 | } |
| 7553 | |
| 7554 | apex { |
| 7555 | name: "com.android.art.debug", |
| 7556 | key: "myapex.key", |
| 7557 | native_shared_libs: ["mylib", "mytestlib"], |
| 7558 | updatable: false, |
| 7559 | } |
| 7560 | |
| 7561 | apex_key { |
| 7562 | name: "myapex.key", |
| 7563 | public_key: "testkey.avbpubkey", |
| 7564 | private_key: "testkey.pem", |
| 7565 | } |
| 7566 | |
| 7567 | cc_library { |
| 7568 | name: "mylib", |
| 7569 | srcs: ["mylib.cpp"], |
| 7570 | system_shared_libs: [], |
| 7571 | stl: "none", |
| 7572 | stubs: { |
| 7573 | versions: ["1"], |
| 7574 | }, |
| 7575 | apex_available: ["com.android.art", "com.android.art.debug"], |
| 7576 | } |
| 7577 | |
| 7578 | cc_library { |
| 7579 | name: "mytestlib", |
| 7580 | srcs: ["mylib.cpp"], |
| 7581 | system_shared_libs: [], |
| 7582 | shared_libs: ["mylib"], |
| 7583 | stl: "none", |
| 7584 | apex_available: ["com.android.art.debug"], |
| 7585 | test_for: ["com.android.art"], |
| 7586 | } |
| 7587 | `, |
| 7588 | android.MockFS{ |
| 7589 | "system/sepolicy/apex/com.android.art-file_contexts": nil, |
| 7590 | "system/sepolicy/apex/com.android.art.debug-file_contexts": nil, |
| 7591 | }.AddToFixture()) |
| 7592 | } |
| 7593 | |
Jaewoong Jung | fa00c06 | 2020-05-14 14:15:24 -0700 | [diff] [blame] | 7594 | // TODO(jungjw): Move this to proptools |
| 7595 | func intPtr(i int) *int { |
| 7596 | return &i |
| 7597 | } |
| 7598 | |
| 7599 | func TestApexSet(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 7600 | ctx := testApex(t, ` |
Jaewoong Jung | fa00c06 | 2020-05-14 14:15:24 -0700 | [diff] [blame] | 7601 | apex_set { |
| 7602 | name: "myapex", |
| 7603 | set: "myapex.apks", |
| 7604 | filename: "foo_v2.apex", |
| 7605 | overrides: ["foo"], |
| 7606 | } |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 7607 | `, |
| 7608 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 7609 | variables.Platform_sdk_version = intPtr(30) |
| 7610 | }), |
| 7611 | android.FixtureModifyConfig(func(config android.Config) { |
| 7612 | config.Targets[android.Android] = []android.Target{ |
| 7613 | {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}}, |
| 7614 | {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}}, |
| 7615 | } |
| 7616 | }), |
| 7617 | ) |
Jaewoong Jung | fa00c06 | 2020-05-14 14:15:24 -0700 | [diff] [blame] | 7618 | |
Paul Duffin | 2470467 | 2021-04-06 16:09:30 +0100 | [diff] [blame] | 7619 | m := ctx.ModuleForTests("myapex.apex.extractor", "android_common") |
Jaewoong Jung | fa00c06 | 2020-05-14 14:15:24 -0700 | [diff] [blame] | 7620 | |
| 7621 | // Check extract_apks tool parameters. |
Paul Duffin | 2470467 | 2021-04-06 16:09:30 +0100 | [diff] [blame] | 7622 | extractedApex := m.Output("extracted/myapex.apks") |
Jaewoong Jung | fa00c06 | 2020-05-14 14:15:24 -0700 | [diff] [blame] | 7623 | actual := extractedApex.Args["abis"] |
| 7624 | expected := "ARMEABI_V7A,ARM64_V8A" |
| 7625 | if actual != expected { |
| 7626 | t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual) |
| 7627 | } |
| 7628 | actual = extractedApex.Args["sdk-version"] |
| 7629 | expected = "30" |
| 7630 | if actual != expected { |
| 7631 | t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual) |
| 7632 | } |
| 7633 | |
Paul Duffin | 6717d88 | 2021-06-15 19:09:41 +0100 | [diff] [blame] | 7634 | m = ctx.ModuleForTests("myapex", "android_common_myapex") |
Jaewoong Jung | fa00c06 | 2020-05-14 14:15:24 -0700 | [diff] [blame] | 7635 | a := m.Module().(*ApexSet) |
| 7636 | expectedOverrides := []string{"foo"} |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 7637 | actualOverrides := android.AndroidMkEntriesForTest(t, ctx, a)[0].EntryMap["LOCAL_OVERRIDES_MODULES"] |
Jaewoong Jung | fa00c06 | 2020-05-14 14:15:24 -0700 | [diff] [blame] | 7638 | if !reflect.DeepEqual(actualOverrides, expectedOverrides) { |
| 7639 | t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES - expected %q vs actual %q", expectedOverrides, actualOverrides) |
| 7640 | } |
| 7641 | } |
| 7642 | |
Jiyong Park | 7d95a51 | 2020-05-10 15:16:24 +0900 | [diff] [blame] | 7643 | func TestNoStaticLinkingToStubsLib(t *testing.T) { |
| 7644 | testApexError(t, `.*required by "mylib" is a native library providing stub.*`, ` |
| 7645 | apex { |
| 7646 | name: "myapex", |
| 7647 | key: "myapex.key", |
| 7648 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7649 | updatable: false, |
Jiyong Park | 7d95a51 | 2020-05-10 15:16:24 +0900 | [diff] [blame] | 7650 | } |
| 7651 | |
| 7652 | apex_key { |
| 7653 | name: "myapex.key", |
| 7654 | public_key: "testkey.avbpubkey", |
| 7655 | private_key: "testkey.pem", |
| 7656 | } |
| 7657 | |
| 7658 | cc_library { |
| 7659 | name: "mylib", |
| 7660 | srcs: ["mylib.cpp"], |
| 7661 | static_libs: ["otherlib"], |
| 7662 | system_shared_libs: [], |
| 7663 | stl: "none", |
| 7664 | apex_available: [ "myapex" ], |
| 7665 | } |
| 7666 | |
| 7667 | cc_library { |
| 7668 | name: "otherlib", |
| 7669 | srcs: ["mylib.cpp"], |
| 7670 | system_shared_libs: [], |
| 7671 | stl: "none", |
| 7672 | stubs: { |
| 7673 | versions: ["1", "2", "3"], |
| 7674 | }, |
| 7675 | apex_available: [ "myapex" ], |
| 7676 | } |
| 7677 | `) |
| 7678 | } |
| 7679 | |
Jiyong Park | 8d6c51e | 2020-06-12 17:26:31 +0900 | [diff] [blame] | 7680 | func TestApexKeysTxt(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 7681 | ctx := testApex(t, ` |
Jiyong Park | 8d6c51e | 2020-06-12 17:26:31 +0900 | [diff] [blame] | 7682 | apex { |
| 7683 | name: "myapex", |
| 7684 | key: "myapex.key", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7685 | updatable: false, |
Jiyong Park | 8d6c51e | 2020-06-12 17:26:31 +0900 | [diff] [blame] | 7686 | } |
| 7687 | |
| 7688 | apex_key { |
| 7689 | name: "myapex.key", |
| 7690 | public_key: "testkey.avbpubkey", |
| 7691 | private_key: "testkey.pem", |
| 7692 | } |
| 7693 | |
| 7694 | prebuilt_apex { |
| 7695 | name: "myapex", |
| 7696 | prefer: true, |
| 7697 | arch: { |
| 7698 | arm64: { |
| 7699 | src: "myapex-arm64.apex", |
| 7700 | }, |
| 7701 | arm: { |
| 7702 | src: "myapex-arm.apex", |
| 7703 | }, |
| 7704 | }, |
| 7705 | } |
| 7706 | |
| 7707 | apex_set { |
| 7708 | name: "myapex_set", |
| 7709 | set: "myapex.apks", |
| 7710 | filename: "myapex_set.apex", |
| 7711 | overrides: ["myapex"], |
| 7712 | } |
| 7713 | `) |
| 7714 | |
| 7715 | apexKeysText := ctx.SingletonForTests("apex_keys_text") |
| 7716 | content := apexKeysText.MaybeDescription("apexkeys.txt").BuildParams.Args["content"] |
| 7717 | ensureContains(t, content, `name="myapex_set.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`) |
Jiyong Park | 03a7f3e | 2020-06-18 19:34:42 +0900 | [diff] [blame] | 7718 | ensureContains(t, content, `name="myapex.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`) |
Jiyong Park | 8d6c51e | 2020-06-12 17:26:31 +0900 | [diff] [blame] | 7719 | } |
| 7720 | |
Jooyung Han | 938b593 | 2020-06-20 12:47:47 +0900 | [diff] [blame] | 7721 | func TestAllowedFiles(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 7722 | ctx := testApex(t, ` |
Jooyung Han | 938b593 | 2020-06-20 12:47:47 +0900 | [diff] [blame] | 7723 | apex { |
| 7724 | name: "myapex", |
| 7725 | key: "myapex.key", |
| 7726 | apps: ["app"], |
| 7727 | allowed_files: "allowed.txt", |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7728 | updatable: false, |
Jooyung Han | 938b593 | 2020-06-20 12:47:47 +0900 | [diff] [blame] | 7729 | } |
| 7730 | |
| 7731 | apex_key { |
| 7732 | name: "myapex.key", |
| 7733 | public_key: "testkey.avbpubkey", |
| 7734 | private_key: "testkey.pem", |
| 7735 | } |
| 7736 | |
| 7737 | android_app { |
| 7738 | name: "app", |
| 7739 | srcs: ["foo/bar/MyClass.java"], |
| 7740 | package_name: "foo", |
| 7741 | sdk_version: "none", |
| 7742 | system_modules: "none", |
| 7743 | apex_available: [ "myapex" ], |
| 7744 | } |
| 7745 | `, withFiles(map[string][]byte{ |
| 7746 | "sub/Android.bp": []byte(` |
| 7747 | override_apex { |
| 7748 | name: "override_myapex", |
| 7749 | base: "myapex", |
| 7750 | apps: ["override_app"], |
| 7751 | allowed_files: ":allowed", |
| 7752 | } |
| 7753 | // Overridable "path" property should be referenced indirectly |
| 7754 | filegroup { |
| 7755 | name: "allowed", |
| 7756 | srcs: ["allowed.txt"], |
| 7757 | } |
| 7758 | override_android_app { |
| 7759 | name: "override_app", |
| 7760 | base: "app", |
| 7761 | package_name: "bar", |
| 7762 | } |
| 7763 | `), |
| 7764 | })) |
| 7765 | |
| 7766 | rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("diffApexContentRule") |
| 7767 | if expected, actual := "allowed.txt", rule.Args["allowed_files_file"]; expected != actual { |
| 7768 | t.Errorf("allowed_files_file: expected %q but got %q", expected, actual) |
| 7769 | } |
| 7770 | |
| 7771 | rule2 := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Rule("diffApexContentRule") |
| 7772 | if expected, actual := "sub/allowed.txt", rule2.Args["allowed_files_file"]; expected != actual { |
| 7773 | t.Errorf("allowed_files_file: expected %q but got %q", expected, actual) |
| 7774 | } |
| 7775 | } |
| 7776 | |
Martin Stjernholm | 58c33f0 | 2020-07-06 22:56:01 +0100 | [diff] [blame] | 7777 | func TestNonPreferredPrebuiltDependency(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 7778 | testApex(t, ` |
Martin Stjernholm | 58c33f0 | 2020-07-06 22:56:01 +0100 | [diff] [blame] | 7779 | apex { |
| 7780 | name: "myapex", |
| 7781 | key: "myapex.key", |
| 7782 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7783 | updatable: false, |
Martin Stjernholm | 58c33f0 | 2020-07-06 22:56:01 +0100 | [diff] [blame] | 7784 | } |
| 7785 | |
| 7786 | apex_key { |
| 7787 | name: "myapex.key", |
| 7788 | public_key: "testkey.avbpubkey", |
| 7789 | private_key: "testkey.pem", |
| 7790 | } |
| 7791 | |
| 7792 | cc_library { |
| 7793 | name: "mylib", |
| 7794 | srcs: ["mylib.cpp"], |
| 7795 | stubs: { |
Dan Albert | c806053 | 2020-07-22 22:32:17 -0700 | [diff] [blame] | 7796 | versions: ["current"], |
Martin Stjernholm | 58c33f0 | 2020-07-06 22:56:01 +0100 | [diff] [blame] | 7797 | }, |
| 7798 | apex_available: ["myapex"], |
| 7799 | } |
| 7800 | |
| 7801 | cc_prebuilt_library_shared { |
| 7802 | name: "mylib", |
| 7803 | prefer: false, |
| 7804 | srcs: ["prebuilt.so"], |
| 7805 | stubs: { |
Dan Albert | c806053 | 2020-07-22 22:32:17 -0700 | [diff] [blame] | 7806 | versions: ["current"], |
Martin Stjernholm | 58c33f0 | 2020-07-06 22:56:01 +0100 | [diff] [blame] | 7807 | }, |
| 7808 | apex_available: ["myapex"], |
| 7809 | } |
| 7810 | `) |
| 7811 | } |
| 7812 | |
Mohammad Samiul Islam | 3cd005d | 2020-11-26 13:32:26 +0000 | [diff] [blame] | 7813 | func TestCompressedApex(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 7814 | ctx := testApex(t, ` |
Mohammad Samiul Islam | 3cd005d | 2020-11-26 13:32:26 +0000 | [diff] [blame] | 7815 | apex { |
| 7816 | name: "myapex", |
| 7817 | key: "myapex.key", |
| 7818 | compressible: true, |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7819 | updatable: false, |
Mohammad Samiul Islam | 3cd005d | 2020-11-26 13:32:26 +0000 | [diff] [blame] | 7820 | } |
| 7821 | apex_key { |
| 7822 | name: "myapex.key", |
| 7823 | public_key: "testkey.avbpubkey", |
| 7824 | private_key: "testkey.pem", |
| 7825 | } |
Paul Duffin | 0a49fdc | 2021-03-08 11:28:25 +0000 | [diff] [blame] | 7826 | `, |
| 7827 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 7828 | variables.CompressedApex = proptools.BoolPtr(true) |
| 7829 | }), |
| 7830 | ) |
Mohammad Samiul Islam | 3cd005d | 2020-11-26 13:32:26 +0000 | [diff] [blame] | 7831 | |
| 7832 | compressRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("compressRule") |
| 7833 | ensureContains(t, compressRule.Output.String(), "myapex.capex.unsigned") |
| 7834 | |
| 7835 | signApkRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Description("sign compressedApex") |
| 7836 | ensureEquals(t, signApkRule.Input.String(), compressRule.Output.String()) |
| 7837 | |
| 7838 | // Make sure output of bundle is .capex |
| 7839 | ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
| 7840 | ensureContains(t, ab.outputFile.String(), "myapex.capex") |
| 7841 | |
| 7842 | // Verify android.mk rules |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 7843 | data := android.AndroidMkDataForTest(t, ctx, ab) |
Mohammad Samiul Islam | 3cd005d | 2020-11-26 13:32:26 +0000 | [diff] [blame] | 7844 | var builder strings.Builder |
| 7845 | data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data) |
| 7846 | androidMk := builder.String() |
| 7847 | ensureContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.capex\n") |
| 7848 | } |
| 7849 | |
Martin Stjernholm | 2856c66 | 2020-12-02 15:03:42 +0000 | [diff] [blame] | 7850 | func TestPreferredPrebuiltSharedLibDep(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 7851 | ctx := testApex(t, ` |
Martin Stjernholm | 2856c66 | 2020-12-02 15:03:42 +0000 | [diff] [blame] | 7852 | apex { |
| 7853 | name: "myapex", |
| 7854 | key: "myapex.key", |
| 7855 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7856 | updatable: false, |
Martin Stjernholm | 2856c66 | 2020-12-02 15:03:42 +0000 | [diff] [blame] | 7857 | } |
| 7858 | |
| 7859 | apex_key { |
| 7860 | name: "myapex.key", |
| 7861 | public_key: "testkey.avbpubkey", |
| 7862 | private_key: "testkey.pem", |
| 7863 | } |
| 7864 | |
| 7865 | cc_library { |
| 7866 | name: "mylib", |
| 7867 | srcs: ["mylib.cpp"], |
| 7868 | apex_available: ["myapex"], |
| 7869 | shared_libs: ["otherlib"], |
| 7870 | system_shared_libs: [], |
| 7871 | } |
| 7872 | |
| 7873 | cc_library { |
| 7874 | name: "otherlib", |
| 7875 | srcs: ["mylib.cpp"], |
| 7876 | stubs: { |
| 7877 | versions: ["current"], |
| 7878 | }, |
| 7879 | } |
| 7880 | |
| 7881 | cc_prebuilt_library_shared { |
| 7882 | name: "otherlib", |
| 7883 | prefer: true, |
| 7884 | srcs: ["prebuilt.so"], |
| 7885 | stubs: { |
| 7886 | versions: ["current"], |
| 7887 | }, |
| 7888 | } |
| 7889 | `) |
| 7890 | |
| 7891 | ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 7892 | data := android.AndroidMkDataForTest(t, ctx, ab) |
Martin Stjernholm | 2856c66 | 2020-12-02 15:03:42 +0000 | [diff] [blame] | 7893 | var builder strings.Builder |
| 7894 | data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data) |
| 7895 | androidMk := builder.String() |
| 7896 | |
| 7897 | // The make level dependency needs to be on otherlib - prebuilt_otherlib isn't |
| 7898 | // a thing there. |
| 7899 | ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += otherlib\n") |
| 7900 | } |
| 7901 | |
Jiyong Park | e386754 | 2020-12-03 17:28:25 +0900 | [diff] [blame] | 7902 | func TestExcludeDependency(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 7903 | ctx := testApex(t, ` |
Jiyong Park | e386754 | 2020-12-03 17:28:25 +0900 | [diff] [blame] | 7904 | apex { |
| 7905 | name: "myapex", |
| 7906 | key: "myapex.key", |
| 7907 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7908 | updatable: false, |
Jiyong Park | e386754 | 2020-12-03 17:28:25 +0900 | [diff] [blame] | 7909 | } |
| 7910 | |
| 7911 | apex_key { |
| 7912 | name: "myapex.key", |
| 7913 | public_key: "testkey.avbpubkey", |
| 7914 | private_key: "testkey.pem", |
| 7915 | } |
| 7916 | |
| 7917 | cc_library { |
| 7918 | name: "mylib", |
| 7919 | srcs: ["mylib.cpp"], |
| 7920 | system_shared_libs: [], |
| 7921 | stl: "none", |
| 7922 | apex_available: ["myapex"], |
| 7923 | shared_libs: ["mylib2"], |
| 7924 | target: { |
| 7925 | apex: { |
| 7926 | exclude_shared_libs: ["mylib2"], |
| 7927 | }, |
| 7928 | }, |
| 7929 | } |
| 7930 | |
| 7931 | cc_library { |
| 7932 | name: "mylib2", |
| 7933 | srcs: ["mylib.cpp"], |
| 7934 | system_shared_libs: [], |
| 7935 | stl: "none", |
| 7936 | } |
| 7937 | `) |
| 7938 | |
| 7939 | // Check if mylib is linked to mylib2 for the non-apex target |
| 7940 | ldFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"] |
| 7941 | ensureContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so") |
| 7942 | |
| 7943 | // Make sure that the link doesn't occur for the apex target |
| 7944 | ldFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"] |
| 7945 | ensureNotContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared_apex10000/mylib2.so") |
| 7946 | |
| 7947 | // It shouldn't appear in the copy cmd as well. |
| 7948 | copyCmds := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule").Args["copy_commands"] |
| 7949 | ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so") |
| 7950 | } |
| 7951 | |
Jiyong Park | f7c3bbe | 2020-12-09 21:18:56 +0900 | [diff] [blame] | 7952 | func TestPrebuiltStubLibDep(t *testing.T) { |
| 7953 | bpBase := ` |
| 7954 | apex { |
| 7955 | name: "myapex", |
| 7956 | key: "myapex.key", |
| 7957 | native_shared_libs: ["mylib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7958 | updatable: false, |
Jiyong Park | f7c3bbe | 2020-12-09 21:18:56 +0900 | [diff] [blame] | 7959 | } |
| 7960 | apex_key { |
| 7961 | name: "myapex.key", |
| 7962 | public_key: "testkey.avbpubkey", |
| 7963 | private_key: "testkey.pem", |
| 7964 | } |
| 7965 | cc_library { |
| 7966 | name: "mylib", |
| 7967 | srcs: ["mylib.cpp"], |
| 7968 | apex_available: ["myapex"], |
| 7969 | shared_libs: ["stublib"], |
| 7970 | system_shared_libs: [], |
| 7971 | } |
| 7972 | apex { |
| 7973 | name: "otherapex", |
| 7974 | enabled: %s, |
| 7975 | key: "myapex.key", |
| 7976 | native_shared_libs: ["stublib"], |
Mathew Inwood | f8dcf5e | 2021-02-16 11:40:16 +0000 | [diff] [blame] | 7977 | updatable: false, |
Jiyong Park | f7c3bbe | 2020-12-09 21:18:56 +0900 | [diff] [blame] | 7978 | } |
| 7979 | ` |
| 7980 | |
| 7981 | stublibSourceBp := ` |
| 7982 | cc_library { |
| 7983 | name: "stublib", |
| 7984 | srcs: ["mylib.cpp"], |
| 7985 | apex_available: ["otherapex"], |
| 7986 | system_shared_libs: [], |
| 7987 | stl: "none", |
| 7988 | stubs: { |
| 7989 | versions: ["1"], |
| 7990 | }, |
| 7991 | } |
| 7992 | ` |
| 7993 | |
| 7994 | stublibPrebuiltBp := ` |
| 7995 | cc_prebuilt_library_shared { |
| 7996 | name: "stublib", |
| 7997 | srcs: ["prebuilt.so"], |
| 7998 | apex_available: ["otherapex"], |
| 7999 | stubs: { |
| 8000 | versions: ["1"], |
| 8001 | }, |
| 8002 | %s |
| 8003 | } |
| 8004 | ` |
| 8005 | |
| 8006 | tests := []struct { |
| 8007 | name string |
| 8008 | stublibBp string |
| 8009 | usePrebuilt bool |
| 8010 | modNames []string // Modules to collect AndroidMkEntries for |
| 8011 | otherApexEnabled []string |
| 8012 | }{ |
| 8013 | { |
| 8014 | name: "only_source", |
| 8015 | stublibBp: stublibSourceBp, |
| 8016 | usePrebuilt: false, |
| 8017 | modNames: []string{"stublib"}, |
| 8018 | otherApexEnabled: []string{"true", "false"}, |
| 8019 | }, |
| 8020 | { |
| 8021 | name: "source_preferred", |
| 8022 | stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, ""), |
| 8023 | usePrebuilt: false, |
| 8024 | modNames: []string{"stublib", "prebuilt_stublib"}, |
| 8025 | otherApexEnabled: []string{"true", "false"}, |
| 8026 | }, |
| 8027 | { |
| 8028 | name: "prebuilt_preferred", |
| 8029 | stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, "prefer: true,"), |
| 8030 | usePrebuilt: true, |
| 8031 | modNames: []string{"stublib", "prebuilt_stublib"}, |
| 8032 | otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt. |
| 8033 | }, |
| 8034 | { |
| 8035 | name: "only_prebuilt", |
| 8036 | stublibBp: fmt.Sprintf(stublibPrebuiltBp, ""), |
| 8037 | usePrebuilt: true, |
| 8038 | modNames: []string{"stublib"}, |
| 8039 | otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt. |
| 8040 | }, |
| 8041 | } |
| 8042 | |
| 8043 | for _, test := range tests { |
| 8044 | t.Run(test.name, func(t *testing.T) { |
| 8045 | for _, otherApexEnabled := range test.otherApexEnabled { |
| 8046 | t.Run("otherapex_enabled_"+otherApexEnabled, func(t *testing.T) { |
Colin Cross | 1c46056 | 2021-02-16 17:55:47 -0800 | [diff] [blame] | 8047 | ctx := testApex(t, fmt.Sprintf(bpBase, otherApexEnabled)+test.stublibBp) |
Jiyong Park | f7c3bbe | 2020-12-09 21:18:56 +0900 | [diff] [blame] | 8048 | |
| 8049 | type modAndMkEntries struct { |
| 8050 | mod *cc.Module |
| 8051 | mkEntries android.AndroidMkEntries |
| 8052 | } |
| 8053 | entries := []*modAndMkEntries{} |
| 8054 | |
| 8055 | // Gather shared lib modules that are installable |
| 8056 | for _, modName := range test.modNames { |
| 8057 | for _, variant := range ctx.ModuleVariantsForTests(modName) { |
| 8058 | if !strings.HasPrefix(variant, "android_arm64_armv8-a_shared") { |
| 8059 | continue |
| 8060 | } |
| 8061 | mod := ctx.ModuleForTests(modName, variant).Module().(*cc.Module) |
Colin Cross | a9c8c9f | 2020-12-16 10:20:23 -0800 | [diff] [blame] | 8062 | if !mod.Enabled() || mod.IsHideFromMake() { |
Jiyong Park | f7c3bbe | 2020-12-09 21:18:56 +0900 | [diff] [blame] | 8063 | continue |
| 8064 | } |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 8065 | for _, ent := range android.AndroidMkEntriesForTest(t, ctx, mod) { |
Jiyong Park | f7c3bbe | 2020-12-09 21:18:56 +0900 | [diff] [blame] | 8066 | if ent.Disabled { |
| 8067 | continue |
| 8068 | } |
| 8069 | entries = append(entries, &modAndMkEntries{ |
| 8070 | mod: mod, |
| 8071 | mkEntries: ent, |
| 8072 | }) |
| 8073 | } |
| 8074 | } |
| 8075 | } |
| 8076 | |
| 8077 | var entry *modAndMkEntries = nil |
| 8078 | for _, ent := range entries { |
| 8079 | if strings.Join(ent.mkEntries.EntryMap["LOCAL_MODULE"], ",") == "stublib" { |
| 8080 | if entry != nil { |
| 8081 | t.Errorf("More than one AndroidMk entry for \"stublib\": %s and %s", entry.mod, ent.mod) |
| 8082 | } else { |
| 8083 | entry = ent |
| 8084 | } |
| 8085 | } |
| 8086 | } |
| 8087 | |
| 8088 | if entry == nil { |
| 8089 | t.Errorf("AndroidMk entry for \"stublib\" missing") |
| 8090 | } else { |
| 8091 | isPrebuilt := entry.mod.Prebuilt() != nil |
| 8092 | if isPrebuilt != test.usePrebuilt { |
| 8093 | t.Errorf("Wrong module for \"stublib\" AndroidMk entry: got prebuilt %t, want prebuilt %t", isPrebuilt, test.usePrebuilt) |
| 8094 | } |
| 8095 | if !entry.mod.IsStubs() { |
| 8096 | t.Errorf("Module for \"stublib\" AndroidMk entry isn't a stub: %s", entry.mod) |
| 8097 | } |
| 8098 | if entry.mkEntries.EntryMap["LOCAL_NOT_AVAILABLE_FOR_PLATFORM"] != nil { |
| 8099 | t.Errorf("AndroidMk entry for \"stublib\" has LOCAL_NOT_AVAILABLE_FOR_PLATFORM set: %+v", entry.mkEntries) |
| 8100 | } |
Jiyong Park | 892a98f | 2020-12-14 09:20:00 +0900 | [diff] [blame] | 8101 | cflags := entry.mkEntries.EntryMap["LOCAL_EXPORT_CFLAGS"] |
Jiyong Park | d4a3a13 | 2021-03-17 20:21:35 +0900 | [diff] [blame] | 8102 | expected := "-D__STUBLIB_API__=10000" |
Jiyong Park | 892a98f | 2020-12-14 09:20:00 +0900 | [diff] [blame] | 8103 | if !android.InList(expected, cflags) { |
| 8104 | t.Errorf("LOCAL_EXPORT_CFLAGS expected to have %q, but got %q", expected, cflags) |
| 8105 | } |
Jiyong Park | f7c3bbe | 2020-12-09 21:18:56 +0900 | [diff] [blame] | 8106 | } |
| 8107 | }) |
| 8108 | } |
| 8109 | }) |
| 8110 | } |
| 8111 | } |
| 8112 | |
Martin Stjernholm | df298b3 | 2021-05-21 20:57:29 +0100 | [diff] [blame] | 8113 | func TestHostApexInHostOnlyBuild(t *testing.T) { |
| 8114 | testApex(t, ` |
| 8115 | apex { |
| 8116 | name: "myapex", |
| 8117 | host_supported: true, |
| 8118 | key: "myapex.key", |
| 8119 | updatable: false, |
| 8120 | payload_type: "zip", |
| 8121 | } |
| 8122 | apex_key { |
| 8123 | name: "myapex.key", |
| 8124 | public_key: "testkey.avbpubkey", |
| 8125 | private_key: "testkey.pem", |
| 8126 | } |
| 8127 | `, |
| 8128 | android.FixtureModifyConfig(func(config android.Config) { |
| 8129 | // We may not have device targets in all builds, e.g. in |
| 8130 | // prebuilts/build-tools/build-prebuilts.sh |
| 8131 | config.Targets[android.Android] = []android.Target{} |
| 8132 | })) |
| 8133 | } |
| 8134 | |
Colin Cross | c33e521 | 2021-05-25 18:16:02 -0700 | [diff] [blame] | 8135 | func TestApexJavaCoverage(t *testing.T) { |
| 8136 | bp := ` |
| 8137 | apex { |
| 8138 | name: "myapex", |
| 8139 | key: "myapex.key", |
| 8140 | java_libs: ["mylib"], |
| 8141 | bootclasspath_fragments: ["mybootclasspathfragment"], |
| 8142 | systemserverclasspath_fragments: ["mysystemserverclasspathfragment"], |
| 8143 | updatable: false, |
| 8144 | } |
| 8145 | |
| 8146 | apex_key { |
| 8147 | name: "myapex.key", |
| 8148 | public_key: "testkey.avbpubkey", |
| 8149 | private_key: "testkey.pem", |
| 8150 | } |
| 8151 | |
| 8152 | java_library { |
| 8153 | name: "mylib", |
| 8154 | srcs: ["mylib.java"], |
| 8155 | apex_available: ["myapex"], |
| 8156 | compile_dex: true, |
| 8157 | } |
| 8158 | |
| 8159 | bootclasspath_fragment { |
| 8160 | name: "mybootclasspathfragment", |
| 8161 | contents: ["mybootclasspathlib"], |
| 8162 | apex_available: ["myapex"], |
| 8163 | } |
| 8164 | |
| 8165 | java_library { |
| 8166 | name: "mybootclasspathlib", |
| 8167 | srcs: ["mybootclasspathlib.java"], |
| 8168 | apex_available: ["myapex"], |
| 8169 | compile_dex: true, |
| 8170 | } |
| 8171 | |
| 8172 | systemserverclasspath_fragment { |
| 8173 | name: "mysystemserverclasspathfragment", |
| 8174 | contents: ["mysystemserverclasspathlib"], |
| 8175 | apex_available: ["myapex"], |
| 8176 | } |
| 8177 | |
| 8178 | java_library { |
| 8179 | name: "mysystemserverclasspathlib", |
| 8180 | srcs: ["mysystemserverclasspathlib.java"], |
| 8181 | apex_available: ["myapex"], |
| 8182 | compile_dex: true, |
| 8183 | } |
| 8184 | ` |
| 8185 | |
| 8186 | result := android.GroupFixturePreparers( |
| 8187 | PrepareForTestWithApexBuildComponents, |
| 8188 | prepareForTestWithMyapex, |
| 8189 | java.PrepareForTestWithJavaDefaultModules, |
| 8190 | android.PrepareForTestWithAndroidBuildComponents, |
| 8191 | android.FixtureWithRootAndroidBp(bp), |
satayev | abcd597 | 2021-08-06 17:49:46 +0100 | [diff] [blame] | 8192 | dexpreopt.FixtureSetApexBootJars("myapex:mybootclasspathlib"), |
| 8193 | dexpreopt.FixtureSetApexSystemServerJars("myapex:mysystemserverclasspathlib"), |
Colin Cross | c33e521 | 2021-05-25 18:16:02 -0700 | [diff] [blame] | 8194 | android.FixtureMergeEnv(map[string]string{ |
| 8195 | "EMMA_INSTRUMENT": "true", |
| 8196 | }), |
| 8197 | ).RunTest(t) |
| 8198 | |
| 8199 | // Make sure jacoco ran on both mylib and mybootclasspathlib |
| 8200 | if result.ModuleForTests("mylib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil { |
| 8201 | t.Errorf("Failed to find jacoco rule for mylib") |
| 8202 | } |
| 8203 | if result.ModuleForTests("mybootclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil { |
| 8204 | t.Errorf("Failed to find jacoco rule for mybootclasspathlib") |
| 8205 | } |
| 8206 | if result.ModuleForTests("mysystemserverclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil { |
| 8207 | t.Errorf("Failed to find jacoco rule for mysystemserverclasspathlib") |
| 8208 | } |
| 8209 | } |
| 8210 | |
Jiyong Park | 192600a | 2021-08-03 07:52:17 +0000 | [diff] [blame] | 8211 | func TestProhibitStaticExecutable(t *testing.T) { |
| 8212 | testApexError(t, `executable mybin is static`, ` |
| 8213 | apex { |
| 8214 | name: "myapex", |
| 8215 | key: "myapex.key", |
| 8216 | binaries: ["mybin"], |
| 8217 | min_sdk_version: "29", |
| 8218 | } |
| 8219 | |
| 8220 | apex_key { |
| 8221 | name: "myapex.key", |
| 8222 | public_key: "testkey.avbpubkey", |
| 8223 | private_key: "testkey.pem", |
| 8224 | } |
| 8225 | |
| 8226 | cc_binary { |
| 8227 | name: "mybin", |
| 8228 | srcs: ["mylib.cpp"], |
| 8229 | relative_install_path: "foo/bar", |
| 8230 | static_executable: true, |
| 8231 | system_shared_libs: [], |
| 8232 | stl: "none", |
| 8233 | apex_available: [ "myapex" ], |
Jiyong Park | d12979d | 2021-08-03 13:36:09 +0900 | [diff] [blame] | 8234 | min_sdk_version: "29", |
| 8235 | } |
| 8236 | `) |
| 8237 | |
| 8238 | testApexError(t, `executable mybin.rust is static`, ` |
| 8239 | apex { |
| 8240 | name: "myapex", |
| 8241 | key: "myapex.key", |
| 8242 | binaries: ["mybin.rust"], |
| 8243 | min_sdk_version: "29", |
| 8244 | } |
| 8245 | |
| 8246 | apex_key { |
| 8247 | name: "myapex.key", |
| 8248 | public_key: "testkey.avbpubkey", |
| 8249 | private_key: "testkey.pem", |
| 8250 | } |
| 8251 | |
| 8252 | rust_binary { |
| 8253 | name: "mybin.rust", |
| 8254 | srcs: ["foo.rs"], |
| 8255 | static_executable: true, |
| 8256 | apex_available: ["myapex"], |
| 8257 | min_sdk_version: "29", |
Jiyong Park | 192600a | 2021-08-03 07:52:17 +0000 | [diff] [blame] | 8258 | } |
| 8259 | `) |
| 8260 | } |
| 8261 | |
Jiakai Zhang | 470b7e2 | 2021-09-30 09:34:26 +0000 | [diff] [blame] | 8262 | func TestAndroidMk_DexpreoptBuiltInstalledForApex(t *testing.T) { |
| 8263 | ctx := testApex(t, ` |
| 8264 | apex { |
| 8265 | name: "myapex", |
| 8266 | key: "myapex.key", |
| 8267 | updatable: false, |
| 8268 | java_libs: ["foo"], |
| 8269 | } |
| 8270 | |
| 8271 | apex_key { |
| 8272 | name: "myapex.key", |
| 8273 | public_key: "testkey.avbpubkey", |
| 8274 | private_key: "testkey.pem", |
| 8275 | } |
| 8276 | |
| 8277 | java_library { |
| 8278 | name: "foo", |
| 8279 | srcs: ["foo.java"], |
| 8280 | apex_available: ["myapex"], |
| 8281 | installable: true, |
| 8282 | } |
| 8283 | `, |
| 8284 | dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"), |
| 8285 | ) |
| 8286 | |
| 8287 | apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle) |
| 8288 | data := android.AndroidMkDataForTest(t, ctx, apexBundle) |
| 8289 | var builder strings.Builder |
| 8290 | data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data) |
| 8291 | androidMk := builder.String() |
| 8292 | ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.odex foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.vdex") |
| 8293 | } |
| 8294 | |
| 8295 | func TestAndroidMk_DexpreoptBuiltInstalledForApex_Prebuilt(t *testing.T) { |
| 8296 | ctx := testApex(t, ` |
| 8297 | prebuilt_apex { |
| 8298 | name: "myapex", |
| 8299 | arch: { |
| 8300 | arm64: { |
| 8301 | src: "myapex-arm64.apex", |
| 8302 | }, |
| 8303 | arm: { |
| 8304 | src: "myapex-arm.apex", |
| 8305 | }, |
| 8306 | }, |
| 8307 | exported_java_libs: ["foo"], |
| 8308 | } |
| 8309 | |
| 8310 | java_import { |
| 8311 | name: "foo", |
| 8312 | jars: ["foo.jar"], |
| 8313 | installable: true, |
| 8314 | } |
| 8315 | `, |
| 8316 | dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"), |
| 8317 | ) |
| 8318 | |
| 8319 | prebuilt := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt) |
| 8320 | entriesList := android.AndroidMkEntriesForTest(t, ctx, prebuilt) |
| 8321 | mainModuleEntries := entriesList[0] |
| 8322 | android.AssertArrayString(t, |
| 8323 | "LOCAL_REQUIRED_MODULES", |
| 8324 | mainModuleEntries.EntryMap["LOCAL_REQUIRED_MODULES"], |
| 8325 | []string{ |
| 8326 | "foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.odex", |
| 8327 | "foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.vdex", |
| 8328 | }) |
| 8329 | } |
| 8330 | |
Jaewoong Jung | c1001ec | 2019-06-25 11:20:53 -0700 | [diff] [blame] | 8331 | func TestMain(m *testing.M) { |
Paul Duffin | 37ba344 | 2021-03-29 00:21:08 +0100 | [diff] [blame] | 8332 | os.Exit(m.Run()) |
Jaewoong Jung | c1001ec | 2019-06-25 11:20:53 -0700 | [diff] [blame] | 8333 | } |