blob: 9a5c2b49bcefa0e7fdb33684c44ec791f3cb443d [file] [log] [blame]
Jiyong Park25fc6a92018-11-18 18:02:45 +09001// Copyright 2018 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package apex
16
17import (
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +090018 "fmt"
Jooyung Han39edb6c2019-11-06 16:53:07 +090019 "path"
Paul Duffin37856732021-02-26 14:24:15 +000020 "path/filepath"
Jaewoong Jung22f7d182019-07-16 18:25:41 -070021 "reflect"
Paul Duffin9b879592020-05-26 13:21:35 +010022 "regexp"
Jooyung Han31c470b2019-10-18 16:26:59 +090023 "sort"
Jiyong Parkd4a3a132021-03-17 20:21:35 +090024 "strconv"
Jiyong Park25fc6a92018-11-18 18:02:45 +090025 "strings"
26 "testing"
Jiyong Parkda6eb592018-12-19 17:12:36 +090027
Yu Liueae7b362023-11-16 17:05:47 -080028 "android/soong/aconfig/codegen"
Jooyung Han20348752023-12-05 15:23:56 +090029
Kiyoung Kim487689e2022-07-26 09:48:22 +090030 "github.com/google/blueprint"
Jiyong Parkda6eb592018-12-19 17:12:36 +090031 "github.com/google/blueprint/proptools"
32
33 "android/soong/android"
markchien2f59ec92020-09-02 16:23:38 +080034 "android/soong/bpf"
Jiyong Parkda6eb592018-12-19 17:12:36 +090035 "android/soong/cc"
Ulya Trafimovichb28cc372020-01-13 15:18:16 +000036 "android/soong/dexpreopt"
Jaewoong Jung4b79e982020-06-01 10:45:49 -070037 prebuilt_etc "android/soong/etc"
Colin Crossbd3a16b2023-04-25 11:30:51 -070038 "android/soong/filesystem"
Jiyong Parkb2742fd2019-02-11 11:38:15 +090039 "android/soong/java"
Jiyong Park99644e92020-11-17 22:21:02 +090040 "android/soong/rust"
Jaewoong Jung4b79e982020-06-01 10:45:49 -070041 "android/soong/sh"
Jiyong Park25fc6a92018-11-18 18:02:45 +090042)
43
Jooyung Hand3639552019-08-09 12:57:43 +090044// names returns name list from white space separated string
45func names(s string) (ns []string) {
46 for _, n := range strings.Split(s, " ") {
47 if len(n) > 0 {
48 ns = append(ns, n)
49 }
50 }
51 return
52}
53
Paul Duffin40b62572021-03-20 11:39:01 +000054func testApexError(t *testing.T, pattern, bp string, preparers ...android.FixturePreparer) {
Jooyung Han344d5432019-08-23 11:17:39 +090055 t.Helper()
Paul Duffin284165a2021-03-29 01:50:31 +010056 android.GroupFixturePreparers(
57 prepareForApexTest,
58 android.GroupFixturePreparers(preparers...),
59 ).
Paul Duffine05480a2021-03-08 15:07:14 +000060 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)).
Paul Duffin40b62572021-03-20 11:39:01 +000061 RunTestWithBp(t, bp)
Jooyung Han5c998b92019-06-27 11:30:33 +090062}
63
Paul Duffin40b62572021-03-20 11:39:01 +000064func testApex(t *testing.T, bp string, preparers ...android.FixturePreparer) *android.TestContext {
Jooyung Han344d5432019-08-23 11:17:39 +090065 t.Helper()
Paul Duffin284165a2021-03-29 01:50:31 +010066
67 optionalBpPreparer := android.NullFixturePreparer
Paul Duffin40b62572021-03-20 11:39:01 +000068 if bp != "" {
Paul Duffin284165a2021-03-29 01:50:31 +010069 optionalBpPreparer = android.FixtureWithRootAndroidBp(bp)
Paul Duffin40b62572021-03-20 11:39:01 +000070 }
Paul Duffin284165a2021-03-29 01:50:31 +010071
72 result := android.GroupFixturePreparers(
73 prepareForApexTest,
74 android.GroupFixturePreparers(preparers...),
75 optionalBpPreparer,
76 ).RunTest(t)
77
Paul Duffine05480a2021-03-08 15:07:14 +000078 return result.TestContext
Jooyung Han5c998b92019-06-27 11:30:33 +090079}
80
Paul Duffin810f33d2021-03-09 14:12:32 +000081func withFiles(files android.MockFS) android.FixturePreparer {
82 return files.AddToFixture()
Jooyung Han344d5432019-08-23 11:17:39 +090083}
84
Paul Duffin810f33d2021-03-09 14:12:32 +000085func withTargets(targets map[android.OsType][]android.Target) android.FixturePreparer {
86 return android.FixtureModifyConfig(func(config android.Config) {
Jooyung Han344d5432019-08-23 11:17:39 +090087 for k, v := range targets {
88 config.Targets[k] = v
89 }
Paul Duffin810f33d2021-03-09 14:12:32 +000090 })
Jooyung Han344d5432019-08-23 11:17:39 +090091}
92
Jooyung Han35155c42020-02-06 17:33:20 +090093// withNativeBridgeTargets sets configuration with targets including:
94// - X86_64 (primary)
95// - X86 (secondary)
96// - Arm64 on X86_64 (native bridge)
97// - Arm on X86 (native bridge)
Paul Duffin810f33d2021-03-09 14:12:32 +000098var withNativeBridgeEnabled = android.FixtureModifyConfig(
99 func(config android.Config) {
100 config.Targets[android.Android] = []android.Target{
101 {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "silvermont", Abi: []string{"arm64-v8a"}},
102 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
103 {Os: android.Android, Arch: android.Arch{ArchType: android.X86, ArchVariant: "silvermont", Abi: []string{"armeabi-v7a"}},
104 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
105 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}},
106 NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86_64", NativeBridgeRelativePath: "arm64"},
107 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
108 NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86", NativeBridgeRelativePath: "arm"},
109 }
110 },
111)
112
113func withManifestPackageNameOverrides(specs []string) android.FixturePreparer {
114 return android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
115 variables.ManifestPackageNameOverrides = specs
116 })
Jooyung Han35155c42020-02-06 17:33:20 +0900117}
118
Albert Martineefabcf2022-03-21 20:11:16 +0000119func withApexGlobalMinSdkVersionOverride(minSdkOverride *string) android.FixturePreparer {
120 return android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
121 variables.ApexGlobalMinSdkVersionOverride = minSdkOverride
122 })
123}
124
Paul Duffin810f33d2021-03-09 14:12:32 +0000125var withBinder32bit = android.FixtureModifyProductVariables(
126 func(variables android.FixtureProductVariables) {
127 variables.Binder32bit = proptools.BoolPtr(true)
128 },
129)
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900130
Paul Duffin810f33d2021-03-09 14:12:32 +0000131var withUnbundledBuild = android.FixtureModifyProductVariables(
132 func(variables android.FixtureProductVariables) {
133 variables.Unbundled_build = proptools.BoolPtr(true)
134 },
135)
Jiyong Park7cd10e32020-01-14 09:22:18 +0900136
Paul Duffin284165a2021-03-29 01:50:31 +0100137// Legacy preparer used for running tests within the apex package.
138//
139// This includes everything that was needed to run any test in the apex package prior to the
140// introduction of the test fixtures. Tests that are being converted to use fixtures directly
141// rather than through the testApex...() methods should avoid using this and instead use the
142// various preparers directly, using android.GroupFixturePreparers(...) to group them when
143// necessary.
144//
145// deprecated
146var prepareForApexTest = android.GroupFixturePreparers(
Paul Duffin37aad602021-03-08 09:47:16 +0000147 // General preparers in alphabetical order as test infrastructure will enforce correct
148 // registration order.
149 android.PrepareForTestWithAndroidBuildComponents,
150 bpf.PrepareForTestWithBpf,
151 cc.PrepareForTestWithCcBuildComponents,
Jiakai Zhangb95998b2023-05-11 16:39:27 +0100152 java.PrepareForTestWithDexpreopt,
Paul Duffin37aad602021-03-08 09:47:16 +0000153 prebuilt_etc.PrepareForTestWithPrebuiltEtc,
154 rust.PrepareForTestWithRustDefaultModules,
155 sh.PrepareForTestWithShBuildComponents,
Yu Liueae7b362023-11-16 17:05:47 -0800156 codegen.PrepareForTestWithAconfigBuildComponents,
Paul Duffin37aad602021-03-08 09:47:16 +0000157
158 PrepareForTestWithApexBuildComponents,
159
160 // Additional apex test specific preparers.
161 android.FixtureAddTextFile("system/sepolicy/Android.bp", `
162 filegroup {
163 name: "myapex-file_contexts",
164 srcs: [
165 "apex/myapex-file_contexts",
166 ],
167 }
168 `),
Paul Duffin52bfaa42021-03-23 23:40:12 +0000169 prepareForTestWithMyapex,
Paul Duffin37aad602021-03-08 09:47:16 +0000170 android.FixtureMergeMockFs(android.MockFS{
Paul Duffin52bfaa42021-03-23 23:40:12 +0000171 "a.java": nil,
172 "PrebuiltAppFoo.apk": nil,
173 "PrebuiltAppFooPriv.apk": nil,
174 "apex_manifest.json": nil,
175 "AndroidManifest.xml": nil,
Paul Duffin37aad602021-03-08 09:47:16 +0000176 "system/sepolicy/apex/myapex.updatable-file_contexts": nil,
177 "system/sepolicy/apex/myapex2-file_contexts": nil,
178 "system/sepolicy/apex/otherapex-file_contexts": nil,
179 "system/sepolicy/apex/com.android.vndk-file_contexts": nil,
180 "system/sepolicy/apex/com.android.vndk.current-file_contexts": nil,
Colin Crossabc0dab2022-04-07 17:39:21 -0700181 "mylib.cpp": nil,
182 "mytest.cpp": nil,
183 "mytest1.cpp": nil,
184 "mytest2.cpp": nil,
185 "mytest3.cpp": nil,
186 "myprebuilt": nil,
187 "my_include": nil,
188 "foo/bar/MyClass.java": nil,
189 "prebuilt.jar": nil,
190 "prebuilt.so": nil,
191 "vendor/foo/devkeys/test.x509.pem": nil,
192 "vendor/foo/devkeys/test.pk8": nil,
193 "testkey.x509.pem": nil,
194 "testkey.pk8": nil,
195 "testkey.override.x509.pem": nil,
196 "testkey.override.pk8": nil,
197 "vendor/foo/devkeys/testkey.avbpubkey": nil,
198 "vendor/foo/devkeys/testkey.pem": nil,
199 "NOTICE": nil,
200 "custom_notice": nil,
201 "custom_notice_for_static_lib": nil,
202 "testkey2.avbpubkey": nil,
203 "testkey2.pem": nil,
204 "myapex-arm64.apex": nil,
205 "myapex-arm.apex": nil,
206 "myapex.apks": nil,
207 "frameworks/base/api/current.txt": nil,
208 "framework/aidl/a.aidl": nil,
209 "dummy.txt": nil,
210 "baz": nil,
211 "bar/baz": nil,
212 "testdata/baz": nil,
213 "AppSet.apks": nil,
214 "foo.rs": nil,
215 "libfoo.jar": nil,
216 "libbar.jar": nil,
Paul Duffin37aad602021-03-08 09:47:16 +0000217 },
218 ),
219
220 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
Paul Duffin37aad602021-03-08 09:47:16 +0000221 variables.DefaultAppCertificate = proptools.StringPtr("vendor/foo/devkeys/test")
222 variables.CertificateOverrides = []string{"myapex_keytest:myapex.certificate.override"}
223 variables.Platform_sdk_codename = proptools.StringPtr("Q")
224 variables.Platform_sdk_final = proptools.BoolPtr(false)
Pedro Loureiroc3621422021-09-28 15:40:23 +0000225 // "Tiramisu" needs to be in the next line for compatibility with soong code,
226 // not because of these tests specifically (it's not used by the tests)
227 variables.Platform_version_active_codenames = []string{"Q", "Tiramisu"}
Oriol Prieto Gasco17e22902022-05-05 13:52:25 +0000228 variables.BuildId = proptools.StringPtr("TEST.BUILD_ID")
Paul Duffin37aad602021-03-08 09:47:16 +0000229 }),
230)
231
Paul Duffin52bfaa42021-03-23 23:40:12 +0000232var prepareForTestWithMyapex = android.FixtureMergeMockFs(android.MockFS{
233 "system/sepolicy/apex/myapex-file_contexts": nil,
234})
235
Jooyung Han643adc42020-02-27 13:50:06 +0900236// ensure that 'result' equals 'expected'
237func ensureEquals(t *testing.T, result string, expected string) {
238 t.Helper()
239 if result != expected {
240 t.Errorf("%q != %q", expected, result)
241 }
242}
243
Jiyong Park25fc6a92018-11-18 18:02:45 +0900244// ensure that 'result' contains 'expected'
245func ensureContains(t *testing.T, result string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900246 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900247 if !strings.Contains(result, expected) {
248 t.Errorf("%q is not found in %q", expected, result)
249 }
250}
251
Liz Kammer5bd365f2020-05-27 15:15:11 -0700252// ensure that 'result' contains 'expected' exactly one time
253func ensureContainsOnce(t *testing.T, result string, expected string) {
254 t.Helper()
255 count := strings.Count(result, expected)
256 if count != 1 {
257 t.Errorf("%q is found %d times (expected 1 time) in %q", expected, count, result)
258 }
259}
260
Jiyong Park25fc6a92018-11-18 18:02:45 +0900261// ensures that 'result' does not contain 'notExpected'
262func ensureNotContains(t *testing.T, result string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900263 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900264 if strings.Contains(result, notExpected) {
265 t.Errorf("%q is found in %q", notExpected, result)
266 }
267}
268
Sasha Smundak18d98bc2020-05-27 16:36:07 -0700269func ensureMatches(t *testing.T, result string, expectedRex string) {
270 ok, err := regexp.MatchString(expectedRex, result)
271 if err != nil {
272 t.Fatalf("regexp failure trying to match %s against `%s` expression: %s", result, expectedRex, err)
273 return
274 }
275 if !ok {
276 t.Errorf("%s does not match regular expession %s", result, expectedRex)
277 }
278}
279
Jiyong Park25fc6a92018-11-18 18:02:45 +0900280func ensureListContains(t *testing.T, result []string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900281 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900282 if !android.InList(expected, result) {
283 t.Errorf("%q is not found in %v", expected, result)
284 }
285}
286
287func ensureListNotContains(t *testing.T, result []string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900288 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900289 if android.InList(notExpected, result) {
290 t.Errorf("%q is found in %v", notExpected, result)
291 }
292}
293
Jooyung Hane1633032019-08-01 17:41:43 +0900294func ensureListEmpty(t *testing.T, result []string) {
295 t.Helper()
296 if len(result) > 0 {
297 t.Errorf("%q is expected to be empty", result)
298 }
299}
300
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +0000301func ensureListNotEmpty(t *testing.T, result []string) {
302 t.Helper()
303 if len(result) == 0 {
304 t.Errorf("%q is expected to be not empty", result)
305 }
306}
307
Jiyong Park25fc6a92018-11-18 18:02:45 +0900308// Minimal test
309func TestBasicApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800310 ctx := testApex(t, `
Jiyong Park30ca9372019-02-07 16:27:23 +0900311 apex_defaults {
312 name: "myapex-defaults",
Jiyong Park809bb722019-02-13 21:33:49 +0900313 manifest: ":myapex.manifest",
314 androidManifest: ":myapex.androidmanifest",
Jiyong Park25fc6a92018-11-18 18:02:45 +0900315 key: "myapex.key",
Jiyong Park99644e92020-11-17 22:21:02 +0900316 binaries: ["foo.rust"],
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900317 native_shared_libs: [
318 "mylib",
319 "libfoo.ffi",
320 ],
Jiyong Park99644e92020-11-17 22:21:02 +0900321 rust_dyn_libs: ["libfoo.dylib.rust"],
Alex Light3d673592019-01-18 14:37:31 -0800322 multilib: {
323 both: {
Jiyong Park99644e92020-11-17 22:21:02 +0900324 binaries: ["foo"],
Alex Light3d673592019-01-18 14:37:31 -0800325 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900326 },
Jiyong Park77acec62020-06-01 21:39:15 +0900327 java_libs: [
328 "myjar",
329 "myjar_dex",
330 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000331 updatable: false,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900332 }
333
Jiyong Park30ca9372019-02-07 16:27:23 +0900334 apex {
335 name: "myapex",
336 defaults: ["myapex-defaults"],
337 }
338
Jiyong Park25fc6a92018-11-18 18:02:45 +0900339 apex_key {
340 name: "myapex.key",
341 public_key: "testkey.avbpubkey",
342 private_key: "testkey.pem",
343 }
344
Jiyong Park809bb722019-02-13 21:33:49 +0900345 filegroup {
346 name: "myapex.manifest",
347 srcs: ["apex_manifest.json"],
348 }
349
350 filegroup {
351 name: "myapex.androidmanifest",
352 srcs: ["AndroidManifest.xml"],
353 }
354
Jiyong Park25fc6a92018-11-18 18:02:45 +0900355 cc_library {
356 name: "mylib",
357 srcs: ["mylib.cpp"],
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900358 shared_libs: [
359 "mylib2",
360 "libbar.ffi",
361 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900362 system_shared_libs: [],
363 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000364 // TODO: remove //apex_available:platform
365 apex_available: [
366 "//apex_available:platform",
367 "myapex",
368 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900369 }
370
Alex Light3d673592019-01-18 14:37:31 -0800371 cc_binary {
372 name: "foo",
373 srcs: ["mylib.cpp"],
374 compile_multilib: "both",
375 multilib: {
376 lib32: {
377 suffix: "32",
378 },
379 lib64: {
380 suffix: "64",
381 },
382 },
383 symlinks: ["foo_link_"],
384 symlink_preferred_arch: true,
385 system_shared_libs: [],
Alex Light3d673592019-01-18 14:37:31 -0800386 stl: "none",
Yifan Hongd22a84a2020-07-28 17:37:46 -0700387 apex_available: [ "myapex", "com.android.gki.*" ],
388 }
389
Jiyong Park99644e92020-11-17 22:21:02 +0900390 rust_binary {
Artur Satayev533b98c2021-03-11 18:03:42 +0000391 name: "foo.rust",
Jiyong Park99644e92020-11-17 22:21:02 +0900392 srcs: ["foo.rs"],
393 rlibs: ["libfoo.rlib.rust"],
Vinh Tran4eeb2a92023-08-14 13:29:30 -0400394 rustlibs: ["libfoo.dylib.rust"],
Jiyong Park99644e92020-11-17 22:21:02 +0900395 apex_available: ["myapex"],
396 }
397
398 rust_library_rlib {
Artur Satayev533b98c2021-03-11 18:03:42 +0000399 name: "libfoo.rlib.rust",
Jiyong Park99644e92020-11-17 22:21:02 +0900400 srcs: ["foo.rs"],
401 crate_name: "foo",
402 apex_available: ["myapex"],
Jiyong Park94e22fd2021-04-08 18:19:15 +0900403 shared_libs: ["libfoo.shared_from_rust"],
404 }
405
406 cc_library_shared {
407 name: "libfoo.shared_from_rust",
408 srcs: ["mylib.cpp"],
409 system_shared_libs: [],
410 stl: "none",
411 apex_available: ["myapex"],
Jiyong Park99644e92020-11-17 22:21:02 +0900412 }
413
414 rust_library_dylib {
Artur Satayev533b98c2021-03-11 18:03:42 +0000415 name: "libfoo.dylib.rust",
Jiyong Park99644e92020-11-17 22:21:02 +0900416 srcs: ["foo.rs"],
417 crate_name: "foo",
418 apex_available: ["myapex"],
419 }
420
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900421 rust_ffi_shared {
422 name: "libfoo.ffi",
423 srcs: ["foo.rs"],
424 crate_name: "foo",
425 apex_available: ["myapex"],
426 }
427
428 rust_ffi_shared {
429 name: "libbar.ffi",
430 srcs: ["foo.rs"],
431 crate_name: "bar",
432 apex_available: ["myapex"],
433 }
434
Yifan Hongd22a84a2020-07-28 17:37:46 -0700435 apex {
436 name: "com.android.gki.fake",
437 binaries: ["foo"],
438 key: "myapex.key",
439 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000440 updatable: false,
Alex Light3d673592019-01-18 14:37:31 -0800441 }
442
Paul Duffindddd5462020-04-07 15:25:44 +0100443 cc_library_shared {
Jiyong Park25fc6a92018-11-18 18:02:45 +0900444 name: "mylib2",
445 srcs: ["mylib.cpp"],
446 system_shared_libs: [],
447 stl: "none",
Jiyong Park9918e1a2020-03-17 19:16:40 +0900448 static_libs: ["libstatic"],
449 // TODO: remove //apex_available:platform
450 apex_available: [
451 "//apex_available:platform",
452 "myapex",
453 ],
454 }
455
Paul Duffindddd5462020-04-07 15:25:44 +0100456 cc_prebuilt_library_shared {
457 name: "mylib2",
458 srcs: ["prebuilt.so"],
459 // TODO: remove //apex_available:platform
460 apex_available: [
461 "//apex_available:platform",
462 "myapex",
463 ],
464 }
465
Jiyong Park9918e1a2020-03-17 19:16:40 +0900466 cc_library_static {
467 name: "libstatic",
468 srcs: ["mylib.cpp"],
469 system_shared_libs: [],
470 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000471 // TODO: remove //apex_available:platform
472 apex_available: [
473 "//apex_available:platform",
474 "myapex",
475 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900476 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900477
478 java_library {
479 name: "myjar",
480 srcs: ["foo/bar/MyClass.java"],
Jiyong Parka62aa232020-05-28 23:46:55 +0900481 stem: "myjar_stem",
Jiyong Park7f7766d2019-07-25 22:02:35 +0900482 sdk_version: "none",
483 system_modules: "none",
Jiyong Park7f7766d2019-07-25 22:02:35 +0900484 static_libs: ["myotherjar"],
Jiyong Park3ff16992019-12-27 14:11:47 +0900485 libs: ["mysharedjar"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000486 // TODO: remove //apex_available:platform
487 apex_available: [
488 "//apex_available:platform",
489 "myapex",
490 ],
Jiyong Park7f7766d2019-07-25 22:02:35 +0900491 }
492
Jiyong Park77acec62020-06-01 21:39:15 +0900493 dex_import {
494 name: "myjar_dex",
495 jars: ["prebuilt.jar"],
496 apex_available: [
497 "//apex_available:platform",
498 "myapex",
499 ],
500 }
501
Jiyong Park7f7766d2019-07-25 22:02:35 +0900502 java_library {
503 name: "myotherjar",
504 srcs: ["foo/bar/MyClass.java"],
505 sdk_version: "none",
506 system_modules: "none",
Jiyong Park0f80c182020-01-31 02:49:53 +0900507 // TODO: remove //apex_available:platform
508 apex_available: [
509 "//apex_available:platform",
510 "myapex",
511 ],
Jiyong Park7f7766d2019-07-25 22:02:35 +0900512 }
Jiyong Park3ff16992019-12-27 14:11:47 +0900513
514 java_library {
515 name: "mysharedjar",
516 srcs: ["foo/bar/MyClass.java"],
517 sdk_version: "none",
518 system_modules: "none",
Jiyong Park3ff16992019-12-27 14:11:47 +0900519 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900520 `)
521
Jooyung Hana0503a52023-08-23 13:12:50 +0900522 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("apexRule")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900523
Jiyong Park9e83f0b2020-06-11 00:35:03 +0900524 // Make sure that Android.mk is created
Jooyung Hana0503a52023-08-23 13:12:50 +0900525 ab := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -0700526 data := android.AndroidMkDataForTest(t, ctx, ab)
Jiyong Park9e83f0b2020-06-11 00:35:03 +0900527 var builder strings.Builder
528 data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
529
530 androidMk := builder.String()
Diwas Sharmabb9202e2023-01-26 18:42:21 +0000531 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
Jiyong Park9e83f0b2020-06-11 00:35:03 +0900532 ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
533
Jiyong Park42cca6c2019-04-01 11:15:50 +0900534 optFlags := apexRule.Args["opt_flags"]
535 ensureContains(t, optFlags, "--pubkey vendor/foo/devkeys/testkey.avbpubkey")
Jaewoong Jung14f5ff62019-06-18 13:09:13 -0700536 // Ensure that the NOTICE output is being packaged as an asset.
Jooyung Hana0503a52023-08-23 13:12:50 +0900537 ensureContains(t, optFlags, "--assets_dir out/soong/.intermediates/myapex/android_common_myapex/NOTICE")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900538
Jiyong Park25fc6a92018-11-18 18:02:45 +0900539 copyCmds := apexRule.Args["copy_commands"]
540
541 // Ensure that main rule creates an output
542 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
543
544 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -0700545 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
546 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common_apex10000")
547 ensureListContains(t, ctx.ModuleVariantsForTests("myjar_dex"), "android_common_apex10000")
Jiyong Park99644e92020-11-17 22:21:02 +0900548 ensureListContains(t, ctx.ModuleVariantsForTests("foo.rust"), "android_arm64_armv8-a_apex10000")
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900549 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.ffi"), "android_arm64_armv8-a_shared_apex10000")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900550
551 // Ensure that apex variant is created for the indirect dep
Colin Crossaede88c2020-08-11 12:17:01 -0700552 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
553 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common_apex10000")
Jiyong Park99644e92020-11-17 22:21:02 +0900554 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.rlib.rust"), "android_arm64_armv8-a_rlib_dylib-std_apex10000")
555 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.dylib.rust"), "android_arm64_armv8-a_dylib_apex10000")
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900556 ensureListContains(t, ctx.ModuleVariantsForTests("libbar.ffi"), "android_arm64_armv8-a_shared_apex10000")
Jiyong Park94e22fd2021-04-08 18:19:15 +0900557 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.shared_from_rust"), "android_arm64_armv8-a_shared_apex10000")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900558
559 // Ensure that both direct and indirect deps are copied into apex
Alex Light5098a612018-11-29 17:12:15 -0800560 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
561 ensureContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Parka62aa232020-05-28 23:46:55 +0900562 ensureContains(t, copyCmds, "image.apex/javalib/myjar_stem.jar")
Jiyong Park77acec62020-06-01 21:39:15 +0900563 ensureContains(t, copyCmds, "image.apex/javalib/myjar_dex.jar")
Jiyong Park99644e92020-11-17 22:21:02 +0900564 ensureContains(t, copyCmds, "image.apex/lib64/libfoo.dylib.rust.dylib.so")
Jiyong Parkf2cc1b72020-12-09 00:20:45 +0900565 ensureContains(t, copyCmds, "image.apex/lib64/libfoo.ffi.so")
566 ensureContains(t, copyCmds, "image.apex/lib64/libbar.ffi.so")
Jiyong Park94e22fd2021-04-08 18:19:15 +0900567 ensureContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900568 // .. but not for java libs
569 ensureNotContains(t, copyCmds, "image.apex/javalib/myotherjar.jar")
Jiyong Park3ff16992019-12-27 14:11:47 +0900570 ensureNotContains(t, copyCmds, "image.apex/javalib/msharedjar.jar")
Logan Chien3aeedc92018-12-26 15:32:21 +0800571
Colin Cross7113d202019-11-20 16:39:12 -0800572 // Ensure that the platform variant ends with _shared or _common
573 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
574 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900575 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common")
576 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common")
Jiyong Park3ff16992019-12-27 14:11:47 +0900577 ensureListContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common")
578
579 // Ensure that dynamic dependency to java libs are not included
580 ensureListNotContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common_myapex")
Alex Light3d673592019-01-18 14:37:31 -0800581
582 // Ensure that all symlinks are present.
583 found_foo_link_64 := false
584 found_foo := false
585 for _, cmd := range strings.Split(copyCmds, " && ") {
Jiyong Park7cd10e32020-01-14 09:22:18 +0900586 if strings.HasPrefix(cmd, "ln -sfn foo64") {
Alex Light3d673592019-01-18 14:37:31 -0800587 if strings.HasSuffix(cmd, "bin/foo") {
588 found_foo = true
589 } else if strings.HasSuffix(cmd, "bin/foo_link_64") {
590 found_foo_link_64 = true
591 }
592 }
593 }
594 good := found_foo && found_foo_link_64
595 if !good {
596 t.Errorf("Could not find all expected symlinks! foo: %t, foo_link_64: %t. Command was %s", found_foo, found_foo_link_64, copyCmds)
597 }
Jiyong Park52818fc2019-03-18 12:01:38 +0900598
Colin Crossf61d03d2023-11-02 16:56:39 -0700599 fullDepsInfo := strings.Split(android.ContentFromFileRuleForTests(t, ctx,
600 ctx.ModuleForTests("myapex", "android_common_myapex").Output("depsinfo/fulllist.txt")), "\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100601 ensureListContains(t, fullDepsInfo, " myjar(minSdkVersion:(no version)) <- myapex")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100602 ensureListContains(t, fullDepsInfo, " mylib2(minSdkVersion:(no version)) <- mylib")
603 ensureListContains(t, fullDepsInfo, " myotherjar(minSdkVersion:(no version)) <- myjar")
604 ensureListContains(t, fullDepsInfo, " mysharedjar(minSdkVersion:(no version)) (external) <- myjar")
Artur Satayeva8bd1132020-04-27 18:07:06 +0100605
Colin Crossf61d03d2023-11-02 16:56:39 -0700606 flatDepsInfo := strings.Split(android.ContentFromFileRuleForTests(t, ctx,
607 ctx.ModuleForTests("myapex", "android_common_myapex").Output("depsinfo/flatlist.txt")), "\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100608 ensureListContains(t, flatDepsInfo, "myjar(minSdkVersion:(no version))")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +0100609 ensureListContains(t, flatDepsInfo, "mylib2(minSdkVersion:(no version))")
610 ensureListContains(t, flatDepsInfo, "myotherjar(minSdkVersion:(no version))")
611 ensureListContains(t, flatDepsInfo, "mysharedjar(minSdkVersion:(no version)) (external)")
Alex Light5098a612018-11-29 17:12:15 -0800612}
613
Jooyung Hanf21c7972019-12-16 22:32:06 +0900614func TestDefaults(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800615 ctx := testApex(t, `
Jooyung Hanf21c7972019-12-16 22:32:06 +0900616 apex_defaults {
617 name: "myapex-defaults",
618 key: "myapex.key",
619 prebuilts: ["myetc"],
620 native_shared_libs: ["mylib"],
621 java_libs: ["myjar"],
622 apps: ["AppFoo"],
Jiyong Park69aeba92020-04-24 21:16:36 +0900623 rros: ["rro"],
Ken Chen5372a242022-07-07 17:48:06 +0800624 bpfs: ["bpf", "netdTest"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000625 updatable: false,
Jooyung Hanf21c7972019-12-16 22:32:06 +0900626 }
627
628 prebuilt_etc {
629 name: "myetc",
630 src: "myprebuilt",
631 }
632
633 apex {
634 name: "myapex",
635 defaults: ["myapex-defaults"],
636 }
637
638 apex_key {
639 name: "myapex.key",
640 public_key: "testkey.avbpubkey",
641 private_key: "testkey.pem",
642 }
643
644 cc_library {
645 name: "mylib",
646 system_shared_libs: [],
647 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000648 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900649 }
650
651 java_library {
652 name: "myjar",
653 srcs: ["foo/bar/MyClass.java"],
654 sdk_version: "none",
655 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000656 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900657 }
658
659 android_app {
660 name: "AppFoo",
661 srcs: ["foo/bar/MyClass.java"],
662 sdk_version: "none",
663 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000664 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900665 }
Jiyong Park69aeba92020-04-24 21:16:36 +0900666
667 runtime_resource_overlay {
668 name: "rro",
669 theme: "blue",
670 }
671
markchien2f59ec92020-09-02 16:23:38 +0800672 bpf {
673 name: "bpf",
674 srcs: ["bpf.c", "bpf2.c"],
675 }
676
Ken Chenfad7f9d2021-11-10 22:02:57 +0800677 bpf {
Ken Chen5372a242022-07-07 17:48:06 +0800678 name: "netdTest",
679 srcs: ["netdTest.c"],
Ken Chenfad7f9d2021-11-10 22:02:57 +0800680 sub_dir: "netd",
681 }
682
Jooyung Hanf21c7972019-12-16 22:32:06 +0900683 `)
Jooyung Hana0503a52023-08-23 13:12:50 +0900684 ensureExactContents(t, ctx, "myapex", "android_common_myapex", []string{
Jooyung Hanf21c7972019-12-16 22:32:06 +0900685 "etc/myetc",
686 "javalib/myjar.jar",
687 "lib64/mylib.so",
Oriol Prieto Gasco17e22902022-05-05 13:52:25 +0000688 "app/AppFoo@TEST.BUILD_ID/AppFoo.apk",
Jiyong Park69aeba92020-04-24 21:16:36 +0900689 "overlay/blue/rro.apk",
markchien2f59ec92020-09-02 16:23:38 +0800690 "etc/bpf/bpf.o",
691 "etc/bpf/bpf2.o",
Ken Chen5372a242022-07-07 17:48:06 +0800692 "etc/bpf/netd/netdTest.o",
Jooyung Hanf21c7972019-12-16 22:32:06 +0900693 })
694}
695
Jooyung Han01a3ee22019-11-02 02:52:25 +0900696func TestApexManifest(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800697 ctx := testApex(t, `
Jooyung Han01a3ee22019-11-02 02:52:25 +0900698 apex {
699 name: "myapex",
700 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000701 updatable: false,
Jooyung Han01a3ee22019-11-02 02:52:25 +0900702 }
703
704 apex_key {
705 name: "myapex.key",
706 public_key: "testkey.avbpubkey",
707 private_key: "testkey.pem",
708 }
709 `)
710
Jooyung Hana0503a52023-08-23 13:12:50 +0900711 module := ctx.ModuleForTests("myapex", "android_common_myapex")
Jooyung Han214bf372019-11-12 13:03:50 +0900712 args := module.Rule("apexRule").Args
713 if manifest := args["manifest"]; manifest != module.Output("apex_manifest.pb").Output.String() {
714 t.Error("manifest should be apex_manifest.pb, but " + manifest)
715 }
Jooyung Han01a3ee22019-11-02 02:52:25 +0900716}
717
Liz Kammer4854a7d2021-05-27 14:28:27 -0400718func TestApexManifestMinSdkVersion(t *testing.T) {
719 ctx := testApex(t, `
720 apex_defaults {
721 name: "my_defaults",
722 key: "myapex.key",
723 product_specific: true,
724 file_contexts: ":my-file-contexts",
725 updatable: false,
726 }
727 apex {
728 name: "myapex_30",
729 min_sdk_version: "30",
730 defaults: ["my_defaults"],
731 }
732
733 apex {
734 name: "myapex_current",
735 min_sdk_version: "current",
736 defaults: ["my_defaults"],
737 }
738
739 apex {
740 name: "myapex_none",
741 defaults: ["my_defaults"],
742 }
743
744 apex_key {
745 name: "myapex.key",
746 public_key: "testkey.avbpubkey",
747 private_key: "testkey.pem",
748 }
749
750 filegroup {
751 name: "my-file-contexts",
752 srcs: ["product_specific_file_contexts"],
753 }
754 `, withFiles(map[string][]byte{
755 "product_specific_file_contexts": nil,
756 }), android.FixtureModifyProductVariables(
757 func(variables android.FixtureProductVariables) {
758 variables.Unbundled_build = proptools.BoolPtr(true)
759 variables.Always_use_prebuilt_sdks = proptools.BoolPtr(false)
760 }), android.FixtureMergeEnv(map[string]string{
761 "UNBUNDLED_BUILD_TARGET_SDK_WITH_API_FINGERPRINT": "true",
762 }))
763
764 testCases := []struct {
765 module string
766 minSdkVersion string
767 }{
768 {
769 module: "myapex_30",
770 minSdkVersion: "30",
771 },
772 {
773 module: "myapex_current",
774 minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
775 },
776 {
777 module: "myapex_none",
778 minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
779 },
780 }
781 for _, tc := range testCases {
Jooyung Hana0503a52023-08-23 13:12:50 +0900782 module := ctx.ModuleForTests(tc.module, "android_common_"+tc.module)
Liz Kammer4854a7d2021-05-27 14:28:27 -0400783 args := module.Rule("apexRule").Args
784 optFlags := args["opt_flags"]
785 if !strings.Contains(optFlags, "--min_sdk_version "+tc.minSdkVersion) {
786 t.Errorf("%s: Expected min_sdk_version=%s, got: %s", tc.module, tc.minSdkVersion, optFlags)
787 }
788 }
789}
790
Jihoon Kang842b9992024-02-08 01:41:51 +0000791func TestApexWithDessertSha(t *testing.T) {
792 ctx := testApex(t, `
793 apex_defaults {
794 name: "my_defaults",
795 key: "myapex.key",
796 product_specific: true,
797 file_contexts: ":my-file-contexts",
798 updatable: false,
799 }
800 apex {
801 name: "myapex_30",
802 min_sdk_version: "30",
803 defaults: ["my_defaults"],
804 }
805
806 apex {
807 name: "myapex_current",
808 min_sdk_version: "current",
809 defaults: ["my_defaults"],
810 }
811
812 apex {
813 name: "myapex_none",
814 defaults: ["my_defaults"],
815 }
816
817 apex_key {
818 name: "myapex.key",
819 public_key: "testkey.avbpubkey",
820 private_key: "testkey.pem",
821 }
822
823 filegroup {
824 name: "my-file-contexts",
825 srcs: ["product_specific_file_contexts"],
826 }
827 `, withFiles(map[string][]byte{
828 "product_specific_file_contexts": nil,
829 }), android.FixtureModifyProductVariables(
830 func(variables android.FixtureProductVariables) {
831 variables.Unbundled_build = proptools.BoolPtr(true)
832 variables.Always_use_prebuilt_sdks = proptools.BoolPtr(false)
833 }), android.FixtureMergeEnv(map[string]string{
834 "UNBUNDLED_BUILD_TARGET_SDK_WITH_DESSERT_SHA": "UpsideDownCake.abcdefghijklmnopqrstuvwxyz123456",
835 }))
836
837 testCases := []struct {
838 module string
839 minSdkVersion string
840 }{
841 {
842 module: "myapex_30",
843 minSdkVersion: "30",
844 },
845 {
846 module: "myapex_current",
847 minSdkVersion: "UpsideDownCake.abcdefghijklmnopqrstuvwxyz123456",
848 },
849 {
850 module: "myapex_none",
851 minSdkVersion: "UpsideDownCake.abcdefghijklmnopqrstuvwxyz123456",
852 },
853 }
854 for _, tc := range testCases {
855 module := ctx.ModuleForTests(tc.module, "android_common_"+tc.module)
856 args := module.Rule("apexRule").Args
857 optFlags := args["opt_flags"]
858 if !strings.Contains(optFlags, "--min_sdk_version "+tc.minSdkVersion) {
859 t.Errorf("%s: Expected min_sdk_version=%s, got: %s", tc.module, tc.minSdkVersion, optFlags)
860 }
861 }
862}
863
Jooyung Hanaf730952023-02-28 14:13:38 +0900864func TestFileContexts(t *testing.T) {
Jooyung Hanbe953902023-05-31 16:42:16 +0900865 for _, vendor := range []bool{true, false} {
Jooyung Hanaf730952023-02-28 14:13:38 +0900866 prop := ""
Jooyung Hanbe953902023-05-31 16:42:16 +0900867 if vendor {
868 prop = "vendor: true,\n"
Jooyung Hanaf730952023-02-28 14:13:38 +0900869 }
870 ctx := testApex(t, `
871 apex {
872 name: "myapex",
873 key: "myapex.key",
Jooyung Hanaf730952023-02-28 14:13:38 +0900874 updatable: false,
Jooyung Hanaf730952023-02-28 14:13:38 +0900875 `+prop+`
876 }
877
878 apex_key {
879 name: "myapex.key",
880 public_key: "testkey.avbpubkey",
881 private_key: "testkey.pem",
882 }
Jooyung Hanbe953902023-05-31 16:42:16 +0900883 `)
Jooyung Hanaf730952023-02-28 14:13:38 +0900884
Jooyung Hana0503a52023-08-23 13:12:50 +0900885 rule := ctx.ModuleForTests("myapex", "android_common_myapex").Output("file_contexts")
Jooyung Hanbe953902023-05-31 16:42:16 +0900886 if vendor {
887 android.AssertStringDoesContain(t, "should force-label as vendor_apex_metadata_file",
888 rule.RuleParams.Command,
889 "apex_manifest\\\\.pb u:object_r:vendor_apex_metadata_file:s0")
Jooyung Hanaf730952023-02-28 14:13:38 +0900890 } else {
Jooyung Hanbe953902023-05-31 16:42:16 +0900891 android.AssertStringDoesContain(t, "should force-label as system_file",
892 rule.RuleParams.Command,
893 "apex_manifest\\\\.pb u:object_r:system_file:s0")
Jooyung Hanaf730952023-02-28 14:13:38 +0900894 }
895 }
896}
897
Jiyong Park25fc6a92018-11-18 18:02:45 +0900898func TestApexWithStubs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -0800899 ctx := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +0900900 apex {
901 name: "myapex",
902 key: "myapex.key",
903 native_shared_libs: ["mylib", "mylib3"],
Jiyong Park105dc322021-06-11 17:22:09 +0900904 binaries: ["foo.rust"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +0000905 updatable: false,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900906 }
907
908 apex_key {
909 name: "myapex.key",
910 public_key: "testkey.avbpubkey",
911 private_key: "testkey.pem",
912 }
913
914 cc_library {
915 name: "mylib",
916 srcs: ["mylib.cpp"],
917 shared_libs: ["mylib2", "mylib3"],
918 system_shared_libs: [],
919 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000920 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900921 }
922
923 cc_library {
924 name: "mylib2",
925 srcs: ["mylib.cpp"],
Jiyong Park64379952018-12-13 18:37:29 +0900926 cflags: ["-include mylib.h"],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900927 system_shared_libs: [],
928 stl: "none",
929 stubs: {
930 versions: ["1", "2", "3"],
931 },
932 }
933
934 cc_library {
935 name: "mylib3",
Jiyong Park28d395a2018-12-07 22:42:47 +0900936 srcs: ["mylib.cpp"],
937 shared_libs: ["mylib4"],
938 system_shared_libs: [],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900939 stl: "none",
940 stubs: {
941 versions: ["10", "11", "12"],
942 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000943 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900944 }
Jiyong Park28d395a2018-12-07 22:42:47 +0900945
946 cc_library {
947 name: "mylib4",
948 srcs: ["mylib.cpp"],
949 system_shared_libs: [],
950 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000951 apex_available: [ "myapex" ],
Jiyong Park28d395a2018-12-07 22:42:47 +0900952 }
Jiyong Park105dc322021-06-11 17:22:09 +0900953
954 rust_binary {
955 name: "foo.rust",
956 srcs: ["foo.rs"],
957 shared_libs: ["libfoo.shared_from_rust"],
958 prefer_rlib: true,
959 apex_available: ["myapex"],
960 }
961
962 cc_library_shared {
963 name: "libfoo.shared_from_rust",
964 srcs: ["mylib.cpp"],
965 system_shared_libs: [],
966 stl: "none",
967 stubs: {
968 versions: ["10", "11", "12"],
969 },
970 }
971
Jiyong Park25fc6a92018-11-18 18:02:45 +0900972 `)
973
Jooyung Hana0503a52023-08-23 13:12:50 +0900974 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900975 copyCmds := apexRule.Args["copy_commands"]
976
977 // Ensure that direct non-stubs dep is always included
Alex Light5098a612018-11-29 17:12:15 -0800978 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900979
980 // Ensure that indirect stubs dep is not included
Alex Light5098a612018-11-29 17:12:15 -0800981 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900982
983 // Ensure that direct stubs dep is included
Alex Light5098a612018-11-29 17:12:15 -0800984 ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900985
Colin Crossaede88c2020-08-11 12:17:01 -0700986 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +0900987
988 // Ensure that mylib is linking with the latest version of stubs for mylib2
Jiyong Parkd4a3a132021-03-17 20:21:35 +0900989 ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900990 // ... and not linking to the non-stub (impl) variant of mylib2
Jiyong Park3ff16992019-12-27 14:11:47 +0900991 ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900992
993 // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
Colin Crossaede88c2020-08-11 12:17:01 -0700994 ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex10000/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900995 // .. and not linking to the stubs variant of mylib3
Colin Crossaede88c2020-08-11 12:17:01 -0700996 ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_12/mylib3.so")
Jiyong Park64379952018-12-13 18:37:29 +0900997
Chih-Hung Hsiehb8082292021-09-09 23:20:39 -0700998 // Comment out this test. Now it fails after the optimization of sharing "cflags" in cc/cc.go
999 // is replaced by sharing of "cFlags" in cc/builder.go.
1000 // The "cflags" contains "-include mylib.h", but cFlags contained only a reference to the
1001 // module variable representing "cflags". So it was not detected by ensureNotContains.
1002 // Now "cFlags" is a reference to a module variable like $flags1, which includes all previous
1003 // content of "cflags". ModuleForTests...Args["cFlags"] returns the full string of $flags1,
1004 // including the original cflags's "-include mylib.h".
1005 //
Jiyong Park64379952018-12-13 18:37:29 +09001006 // Ensure that stubs libs are built without -include flags
Chih-Hung Hsiehb8082292021-09-09 23:20:39 -07001007 // mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
1008 // ensureNotContains(t, mylib2Cflags, "-include ")
Jiyong Park3fd0baf2018-12-07 16:25:39 +09001009
Jiyong Park85cc35a2022-07-17 11:30:47 +09001010 // Ensure that genstub for platform-provided lib is invoked with --systemapi
1011 ensureContains(t, ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_3").Rule("genStubSrc").Args["flags"], "--systemapi")
1012 // Ensure that genstub for apex-provided lib is invoked with --apex
1013 ensureContains(t, ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_shared_12").Rule("genStubSrc").Args["flags"], "--apex")
Jooyung Han671f1ce2019-12-17 12:47:13 +09001014
Jooyung Hana0503a52023-08-23 13:12:50 +09001015 ensureExactContents(t, ctx, "myapex", "android_common_myapex", []string{
Jooyung Han671f1ce2019-12-17 12:47:13 +09001016 "lib64/mylib.so",
1017 "lib64/mylib3.so",
1018 "lib64/mylib4.so",
Jiyong Park105dc322021-06-11 17:22:09 +09001019 "bin/foo.rust",
1020 "lib64/libc++.so", // by the implicit dependency from foo.rust
1021 "lib64/liblog.so", // by the implicit dependency from foo.rust
Jooyung Han671f1ce2019-12-17 12:47:13 +09001022 })
Jiyong Park105dc322021-06-11 17:22:09 +09001023
1024 // Ensure that stub dependency from a rust module is not included
1025 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
1026 // The rust module is linked to the stub cc library
Colin Cross004bd3f2023-10-02 11:39:17 -07001027 rustDeps := ctx.ModuleForTests("foo.rust", "android_arm64_armv8-a_apex10000").Rule("rustc").Args["linkFlags"]
Jiyong Park105dc322021-06-11 17:22:09 +09001028 ensureContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared_current/libfoo.shared_from_rust.so")
1029 ensureNotContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared/libfoo.shared_from_rust.so")
Jiyong Park34d5c332022-02-24 18:02:44 +09001030
Jooyung Hana0503a52023-08-23 13:12:50 +09001031 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("apexManifestRule")
Jiyong Park34d5c332022-02-24 18:02:44 +09001032 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.shared_from_rust.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001033}
1034
Jooyung Han20348752023-12-05 15:23:56 +09001035func TestApexShouldNotEmbedStubVariant(t *testing.T) {
1036 testApexError(t, `module "myapex" .*: native_shared_libs: "libbar" is a stub`, `
1037 apex {
1038 name: "myapex",
1039 key: "myapex.key",
1040 vendor: true,
1041 updatable: false,
1042 native_shared_libs: ["libbar"], // should not add an LLNDK stub in a vendor apex
1043 }
1044
1045 apex_key {
1046 name: "myapex.key",
1047 public_key: "testkey.avbpubkey",
1048 private_key: "testkey.pem",
1049 }
1050
1051 cc_library {
1052 name: "libbar",
1053 srcs: ["mylib.cpp"],
1054 llndk: {
1055 symbol_file: "libbar.map.txt",
1056 }
1057 }
1058 `)
1059}
1060
Jiyong Park1bc84122021-06-22 20:23:05 +09001061func TestApexCanUsePrivateApis(t *testing.T) {
1062 ctx := testApex(t, `
1063 apex {
1064 name: "myapex",
1065 key: "myapex.key",
1066 native_shared_libs: ["mylib"],
1067 binaries: ["foo.rust"],
1068 updatable: false,
1069 platform_apis: true,
1070 }
1071
1072 apex_key {
1073 name: "myapex.key",
1074 public_key: "testkey.avbpubkey",
1075 private_key: "testkey.pem",
1076 }
1077
1078 cc_library {
1079 name: "mylib",
1080 srcs: ["mylib.cpp"],
1081 shared_libs: ["mylib2"],
1082 system_shared_libs: [],
1083 stl: "none",
1084 apex_available: [ "myapex" ],
1085 }
1086
1087 cc_library {
1088 name: "mylib2",
1089 srcs: ["mylib.cpp"],
1090 cflags: ["-include mylib.h"],
1091 system_shared_libs: [],
1092 stl: "none",
1093 stubs: {
1094 versions: ["1", "2", "3"],
1095 },
1096 }
1097
1098 rust_binary {
1099 name: "foo.rust",
1100 srcs: ["foo.rs"],
1101 shared_libs: ["libfoo.shared_from_rust"],
1102 prefer_rlib: true,
1103 apex_available: ["myapex"],
1104 }
1105
1106 cc_library_shared {
1107 name: "libfoo.shared_from_rust",
1108 srcs: ["mylib.cpp"],
1109 system_shared_libs: [],
1110 stl: "none",
1111 stubs: {
1112 versions: ["10", "11", "12"],
1113 },
1114 }
1115 `)
1116
Jooyung Hana0503a52023-08-23 13:12:50 +09001117 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("apexRule")
Jiyong Park1bc84122021-06-22 20:23:05 +09001118 copyCmds := apexRule.Args["copy_commands"]
1119
1120 // Ensure that indirect stubs dep is not included
1121 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
1122 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
1123
1124 // Ensure that we are using non-stub variants of mylib2 and libfoo.shared_from_rust (because
1125 // of the platform_apis: true)
Jiyong Parkd4a00632022-04-12 12:23:20 +09001126 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
Jiyong Park1bc84122021-06-22 20:23:05 +09001127 ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
1128 ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
Colin Cross004bd3f2023-10-02 11:39:17 -07001129 rustDeps := ctx.ModuleForTests("foo.rust", "android_arm64_armv8-a_apex10000").Rule("rustc").Args["linkFlags"]
Jiyong Park1bc84122021-06-22 20:23:05 +09001130 ensureNotContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared_current/libfoo.shared_from_rust.so")
1131 ensureContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared/libfoo.shared_from_rust.so")
1132}
1133
Colin Cross7812fd32020-09-25 12:35:10 -07001134func TestApexWithStubsWithMinSdkVersion(t *testing.T) {
1135 t.Parallel()
Colin Cross1c460562021-02-16 17:55:47 -08001136 ctx := testApex(t, `
Colin Cross7812fd32020-09-25 12:35:10 -07001137 apex {
1138 name: "myapex",
1139 key: "myapex.key",
1140 native_shared_libs: ["mylib", "mylib3"],
1141 min_sdk_version: "29",
1142 }
1143
1144 apex_key {
1145 name: "myapex.key",
1146 public_key: "testkey.avbpubkey",
1147 private_key: "testkey.pem",
1148 }
1149
1150 cc_library {
1151 name: "mylib",
1152 srcs: ["mylib.cpp"],
1153 shared_libs: ["mylib2", "mylib3"],
1154 system_shared_libs: [],
1155 stl: "none",
1156 apex_available: [ "myapex" ],
1157 min_sdk_version: "28",
1158 }
1159
1160 cc_library {
1161 name: "mylib2",
1162 srcs: ["mylib.cpp"],
1163 cflags: ["-include mylib.h"],
1164 system_shared_libs: [],
1165 stl: "none",
1166 stubs: {
1167 versions: ["28", "29", "30", "current"],
1168 },
1169 min_sdk_version: "28",
1170 }
1171
1172 cc_library {
1173 name: "mylib3",
1174 srcs: ["mylib.cpp"],
1175 shared_libs: ["mylib4"],
1176 system_shared_libs: [],
1177 stl: "none",
1178 stubs: {
1179 versions: ["28", "29", "30", "current"],
1180 },
1181 apex_available: [ "myapex" ],
1182 min_sdk_version: "28",
1183 }
1184
1185 cc_library {
1186 name: "mylib4",
1187 srcs: ["mylib.cpp"],
1188 system_shared_libs: [],
1189 stl: "none",
1190 apex_available: [ "myapex" ],
1191 min_sdk_version: "28",
1192 }
1193 `)
1194
Jooyung Hana0503a52023-08-23 13:12:50 +09001195 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("apexRule")
Colin Cross7812fd32020-09-25 12:35:10 -07001196 copyCmds := apexRule.Args["copy_commands"]
1197
1198 // Ensure that direct non-stubs dep is always included
1199 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
1200
1201 // Ensure that indirect stubs dep is not included
1202 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
1203
1204 // Ensure that direct stubs dep is included
1205 ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
1206
1207 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex29").Rule("ld").Args["libFlags"]
1208
Jiyong Park55549df2021-02-26 23:57:23 +09001209 // Ensure that mylib is linking with the latest version of stub for mylib2
1210 ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
Colin Cross7812fd32020-09-25 12:35:10 -07001211 // ... and not linking to the non-stub (impl) variant of mylib2
1212 ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
1213
1214 // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
1215 ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex29/mylib3.so")
1216 // .. and not linking to the stubs variant of mylib3
1217 ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_29/mylib3.so")
1218
1219 // Ensure that stubs libs are built without -include flags
Colin Crossa717db72020-10-23 14:53:06 -07001220 mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("cc").Args["cFlags"]
Colin Cross7812fd32020-09-25 12:35:10 -07001221 ensureNotContains(t, mylib2Cflags, "-include ")
1222
Jiyong Park85cc35a2022-07-17 11:30:47 +09001223 // Ensure that genstub is invoked with --systemapi
1224 ensureContains(t, ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("genStubSrc").Args["flags"], "--systemapi")
Colin Cross7812fd32020-09-25 12:35:10 -07001225
Jooyung Hana0503a52023-08-23 13:12:50 +09001226 ensureExactContents(t, ctx, "myapex", "android_common_myapex", []string{
Colin Cross7812fd32020-09-25 12:35:10 -07001227 "lib64/mylib.so",
1228 "lib64/mylib3.so",
1229 "lib64/mylib4.so",
1230 })
1231}
1232
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001233func TestApex_PlatformUsesLatestStubFromApex(t *testing.T) {
1234 t.Parallel()
1235 // myapex (Z)
1236 // mylib -----------------.
1237 // |
1238 // otherapex (29) |
1239 // libstub's versions: 29 Z current
1240 // |
1241 // <platform> |
1242 // libplatform ----------------'
Colin Cross1c460562021-02-16 17:55:47 -08001243 ctx := testApex(t, `
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001244 apex {
1245 name: "myapex",
1246 key: "myapex.key",
1247 native_shared_libs: ["mylib"],
1248 min_sdk_version: "Z", // non-final
1249 }
1250
1251 cc_library {
1252 name: "mylib",
1253 srcs: ["mylib.cpp"],
1254 shared_libs: ["libstub"],
1255 apex_available: ["myapex"],
1256 min_sdk_version: "Z",
1257 }
1258
1259 apex_key {
1260 name: "myapex.key",
1261 public_key: "testkey.avbpubkey",
1262 private_key: "testkey.pem",
1263 }
1264
1265 apex {
1266 name: "otherapex",
1267 key: "myapex.key",
1268 native_shared_libs: ["libstub"],
1269 min_sdk_version: "29",
1270 }
1271
1272 cc_library {
1273 name: "libstub",
1274 srcs: ["mylib.cpp"],
1275 stubs: {
1276 versions: ["29", "Z", "current"],
1277 },
1278 apex_available: ["otherapex"],
1279 min_sdk_version: "29",
1280 }
1281
1282 // platform module depending on libstub from otherapex should use the latest stub("current")
1283 cc_library {
1284 name: "libplatform",
1285 srcs: ["mylib.cpp"],
1286 shared_libs: ["libstub"],
1287 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001288 `,
1289 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1290 variables.Platform_sdk_codename = proptools.StringPtr("Z")
1291 variables.Platform_sdk_final = proptools.BoolPtr(false)
1292 variables.Platform_version_active_codenames = []string{"Z"}
1293 }),
1294 )
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001295
Jiyong Park55549df2021-02-26 23:57:23 +09001296 // Ensure that mylib from myapex is built against the latest stub (current)
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001297 mylibCflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
Jiyong Park55549df2021-02-26 23:57:23 +09001298 ensureContains(t, mylibCflags, "-D__LIBSTUB_API__=10000 ")
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001299 mylibLdflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
Jiyong Park55549df2021-02-26 23:57:23 +09001300 ensureContains(t, mylibLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
Jooyung Han11b0fbd2021-02-05 02:28:22 +09001301
1302 // Ensure that libplatform is built against latest stub ("current") of mylib3 from the apex
1303 libplatformCflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
1304 ensureContains(t, libplatformCflags, "-D__LIBSTUB_API__=10000 ") // "current" maps to 10000
1305 libplatformLdflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
1306 ensureContains(t, libplatformLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
1307}
1308
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001309func TestApexWithExplicitStubsDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001310 ctx := testApex(t, `
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001311 apex {
Jiyong Park83dc74b2020-01-14 18:38:44 +09001312 name: "myapex2",
1313 key: "myapex2.key",
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001314 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001315 updatable: false,
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001316 }
1317
1318 apex_key {
Jiyong Park83dc74b2020-01-14 18:38:44 +09001319 name: "myapex2.key",
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001320 public_key: "testkey.avbpubkey",
1321 private_key: "testkey.pem",
1322 }
1323
1324 cc_library {
1325 name: "mylib",
1326 srcs: ["mylib.cpp"],
1327 shared_libs: ["libfoo#10"],
Jiyong Park678c8812020-02-07 17:25:49 +09001328 static_libs: ["libbaz"],
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001329 system_shared_libs: [],
1330 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001331 apex_available: [ "myapex2" ],
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001332 }
1333
1334 cc_library {
1335 name: "libfoo",
1336 srcs: ["mylib.cpp"],
1337 shared_libs: ["libbar"],
1338 system_shared_libs: [],
1339 stl: "none",
1340 stubs: {
1341 versions: ["10", "20", "30"],
1342 },
1343 }
1344
1345 cc_library {
1346 name: "libbar",
1347 srcs: ["mylib.cpp"],
1348 system_shared_libs: [],
1349 stl: "none",
1350 }
1351
Jiyong Park678c8812020-02-07 17:25:49 +09001352 cc_library_static {
1353 name: "libbaz",
1354 srcs: ["mylib.cpp"],
1355 system_shared_libs: [],
1356 stl: "none",
1357 apex_available: [ "myapex2" ],
1358 }
1359
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001360 `)
1361
Jooyung Hana0503a52023-08-23 13:12:50 +09001362 apexRule := ctx.ModuleForTests("myapex2", "android_common_myapex2").Rule("apexRule")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001363 copyCmds := apexRule.Args["copy_commands"]
1364
1365 // Ensure that direct non-stubs dep is always included
1366 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
1367
1368 // Ensure that indirect stubs dep is not included
1369 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
1370
1371 // Ensure that dependency of stubs is not included
1372 ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so")
1373
Colin Crossaede88c2020-08-11 12:17:01 -07001374 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001375
1376 // Ensure that mylib is linking with version 10 of libfoo
Jiyong Park3ff16992019-12-27 14:11:47 +09001377 ensureContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared_10/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001378 // ... and not linking to the non-stub (impl) variant of libfoo
Jiyong Park3ff16992019-12-27 14:11:47 +09001379 ensureNotContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001380
Jiyong Park3ff16992019-12-27 14:11:47 +09001381 libFooStubsLdFlags := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_10").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001382
1383 // Ensure that libfoo stubs is not linking to libbar (since it is a stubs)
1384 ensureNotContains(t, libFooStubsLdFlags, "libbar.so")
Jiyong Park83dc74b2020-01-14 18:38:44 +09001385
Colin Crossf61d03d2023-11-02 16:56:39 -07001386 fullDepsInfo := strings.Split(android.ContentFromFileRuleForTests(t, ctx,
1387 ctx.ModuleForTests("myapex2", "android_common_myapex2").Output("depsinfo/fulllist.txt")), "\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +01001388 ensureListContains(t, fullDepsInfo, " libfoo(minSdkVersion:(no version)) (external) <- mylib")
Jiyong Park678c8812020-02-07 17:25:49 +09001389
Colin Crossf61d03d2023-11-02 16:56:39 -07001390 flatDepsInfo := strings.Split(android.ContentFromFileRuleForTests(t, ctx,
1391 ctx.ModuleForTests("myapex2", "android_common_myapex2").Output("depsinfo/flatlist.txt")), "\n")
Artur Satayev4e1f2bd2020-05-14 15:15:01 +01001392 ensureListContains(t, flatDepsInfo, "libfoo(minSdkVersion:(no version)) (external)")
Jiyong Park0ddfcd12018-12-11 01:35:25 +09001393}
1394
Jooyung Hand3639552019-08-09 12:57:43 +09001395func TestApexWithRuntimeLibsDependency(t *testing.T) {
1396 /*
1397 myapex
1398 |
1399 v (runtime_libs)
1400 mylib ------+------> libfoo [provides stub]
1401 |
1402 `------> libbar
1403 */
Colin Cross1c460562021-02-16 17:55:47 -08001404 ctx := testApex(t, `
Jooyung Hand3639552019-08-09 12:57:43 +09001405 apex {
1406 name: "myapex",
1407 key: "myapex.key",
1408 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001409 updatable: false,
Jooyung Hand3639552019-08-09 12:57:43 +09001410 }
1411
1412 apex_key {
1413 name: "myapex.key",
1414 public_key: "testkey.avbpubkey",
1415 private_key: "testkey.pem",
1416 }
1417
1418 cc_library {
1419 name: "mylib",
1420 srcs: ["mylib.cpp"],
Liz Kammer5f108fa2023-05-11 14:33:17 -04001421 static_libs: ["libstatic"],
1422 shared_libs: ["libshared"],
Jooyung Hand3639552019-08-09 12:57:43 +09001423 runtime_libs: ["libfoo", "libbar"],
1424 system_shared_libs: [],
1425 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001426 apex_available: [ "myapex" ],
Jooyung Hand3639552019-08-09 12:57:43 +09001427 }
1428
1429 cc_library {
1430 name: "libfoo",
1431 srcs: ["mylib.cpp"],
1432 system_shared_libs: [],
1433 stl: "none",
1434 stubs: {
1435 versions: ["10", "20", "30"],
1436 },
1437 }
1438
1439 cc_library {
1440 name: "libbar",
1441 srcs: ["mylib.cpp"],
1442 system_shared_libs: [],
1443 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001444 apex_available: [ "myapex" ],
Jooyung Hand3639552019-08-09 12:57:43 +09001445 }
1446
Liz Kammer5f108fa2023-05-11 14:33:17 -04001447 cc_library {
1448 name: "libstatic",
1449 srcs: ["mylib.cpp"],
1450 system_shared_libs: [],
1451 stl: "none",
1452 apex_available: [ "myapex" ],
1453 runtime_libs: ["libstatic_to_runtime"],
1454 }
1455
1456 cc_library {
1457 name: "libshared",
1458 srcs: ["mylib.cpp"],
1459 system_shared_libs: [],
1460 stl: "none",
1461 apex_available: [ "myapex" ],
1462 runtime_libs: ["libshared_to_runtime"],
1463 }
1464
1465 cc_library {
1466 name: "libstatic_to_runtime",
1467 srcs: ["mylib.cpp"],
1468 system_shared_libs: [],
1469 stl: "none",
1470 apex_available: [ "myapex" ],
1471 }
1472
1473 cc_library {
1474 name: "libshared_to_runtime",
1475 srcs: ["mylib.cpp"],
1476 system_shared_libs: [],
1477 stl: "none",
1478 apex_available: [ "myapex" ],
1479 }
Jooyung Hand3639552019-08-09 12:57:43 +09001480 `)
1481
Jooyung Hana0503a52023-08-23 13:12:50 +09001482 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("apexRule")
Jooyung Hand3639552019-08-09 12:57:43 +09001483 copyCmds := apexRule.Args["copy_commands"]
1484
1485 // Ensure that direct non-stubs dep is always included
1486 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
1487
1488 // Ensure that indirect stubs dep is not included
1489 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
1490
1491 // Ensure that runtime_libs dep in included
1492 ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
Liz Kammer5f108fa2023-05-11 14:33:17 -04001493 ensureContains(t, copyCmds, "image.apex/lib64/libshared.so")
1494 ensureContains(t, copyCmds, "image.apex/lib64/libshared_to_runtime.so")
1495
1496 ensureNotContains(t, copyCmds, "image.apex/lib64/libstatic_to_runtime.so")
Jooyung Hand3639552019-08-09 12:57:43 +09001497
Jooyung Hana0503a52023-08-23 13:12:50 +09001498 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001499 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
1500 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.so")
Jooyung Hand3639552019-08-09 12:57:43 +09001501}
1502
Paul Duffina02cae32021-03-09 01:44:06 +00001503var prepareForTestOfRuntimeApexWithHwasan = android.GroupFixturePreparers(
1504 cc.PrepareForTestWithCcBuildComponents,
1505 PrepareForTestWithApexBuildComponents,
1506 android.FixtureAddTextFile("bionic/apex/Android.bp", `
Jooyung Han8ce8db92020-05-15 19:05:05 +09001507 apex {
1508 name: "com.android.runtime",
1509 key: "com.android.runtime.key",
1510 native_shared_libs: ["libc"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001511 updatable: false,
Jooyung Han8ce8db92020-05-15 19:05:05 +09001512 }
1513
1514 apex_key {
1515 name: "com.android.runtime.key",
1516 public_key: "testkey.avbpubkey",
1517 private_key: "testkey.pem",
1518 }
Paul Duffina02cae32021-03-09 01:44:06 +00001519 `),
1520 android.FixtureAddFile("system/sepolicy/apex/com.android.runtime-file_contexts", nil),
1521)
Jooyung Han8ce8db92020-05-15 19:05:05 +09001522
Paul Duffina02cae32021-03-09 01:44:06 +00001523func TestRuntimeApexShouldInstallHwasanIfLibcDependsOnIt(t *testing.T) {
Paul Duffin70d3bee2021-03-21 11:26:05 +00001524 result := android.GroupFixturePreparers(prepareForTestOfRuntimeApexWithHwasan).RunTestWithBp(t, `
Jooyung Han8ce8db92020-05-15 19:05:05 +09001525 cc_library {
1526 name: "libc",
1527 no_libcrt: true,
1528 nocrt: true,
Kalesh Singhf4ffe0a2024-01-29 13:01:51 -08001529 no_crt_pad_segment: true,
Jooyung Han8ce8db92020-05-15 19:05:05 +09001530 stl: "none",
1531 system_shared_libs: [],
1532 stubs: { versions: ["1"] },
1533 apex_available: ["com.android.runtime"],
1534
1535 sanitize: {
1536 hwaddress: true,
1537 }
1538 }
1539
1540 cc_prebuilt_library_shared {
Colin Cross4c4c1be2022-02-10 11:41:18 -08001541 name: "libclang_rt.hwasan",
Jooyung Han8ce8db92020-05-15 19:05:05 +09001542 no_libcrt: true,
1543 nocrt: true,
Kalesh Singhf4ffe0a2024-01-29 13:01:51 -08001544 no_crt_pad_segment: true,
Jooyung Han8ce8db92020-05-15 19:05:05 +09001545 stl: "none",
1546 system_shared_libs: [],
1547 srcs: [""],
1548 stubs: { versions: ["1"] },
Colin Cross4c4c1be2022-02-10 11:41:18 -08001549 stem: "libclang_rt.hwasan-aarch64-android",
Jooyung Han8ce8db92020-05-15 19:05:05 +09001550
1551 sanitize: {
1552 never: true,
1553 },
Spandan Das4de7b492023-05-05 21:13:01 +00001554 apex_available: [
1555 "//apex_available:anyapex",
1556 "//apex_available:platform",
1557 ],
Paul Duffina02cae32021-03-09 01:44:06 +00001558 } `)
1559 ctx := result.TestContext
Jooyung Han8ce8db92020-05-15 19:05:05 +09001560
Jooyung Hana0503a52023-08-23 13:12:50 +09001561 ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime", []string{
Jooyung Han8ce8db92020-05-15 19:05:05 +09001562 "lib64/bionic/libc.so",
1563 "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
1564 })
1565
Colin Cross4c4c1be2022-02-10 11:41:18 -08001566 hwasan := ctx.ModuleForTests("libclang_rt.hwasan", "android_arm64_armv8-a_shared")
Jooyung Han8ce8db92020-05-15 19:05:05 +09001567
1568 installed := hwasan.Description("install libclang_rt.hwasan")
1569 ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
1570
1571 symlink := hwasan.Description("install symlink libclang_rt.hwasan")
1572 ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
1573 ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
1574}
1575
1576func TestRuntimeApexShouldInstallHwasanIfHwaddressSanitized(t *testing.T) {
Paul Duffin70d3bee2021-03-21 11:26:05 +00001577 result := android.GroupFixturePreparers(
Paul Duffina02cae32021-03-09 01:44:06 +00001578 prepareForTestOfRuntimeApexWithHwasan,
1579 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1580 variables.SanitizeDevice = []string{"hwaddress"}
1581 }),
1582 ).RunTestWithBp(t, `
Jooyung Han8ce8db92020-05-15 19:05:05 +09001583 cc_library {
1584 name: "libc",
1585 no_libcrt: true,
1586 nocrt: true,
Kalesh Singhf4ffe0a2024-01-29 13:01:51 -08001587 no_crt_pad_segment: true,
Jooyung Han8ce8db92020-05-15 19:05:05 +09001588 stl: "none",
1589 system_shared_libs: [],
1590 stubs: { versions: ["1"] },
1591 apex_available: ["com.android.runtime"],
1592 }
1593
1594 cc_prebuilt_library_shared {
Colin Cross4c4c1be2022-02-10 11:41:18 -08001595 name: "libclang_rt.hwasan",
Jooyung Han8ce8db92020-05-15 19:05:05 +09001596 no_libcrt: true,
1597 nocrt: true,
Kalesh Singhf4ffe0a2024-01-29 13:01:51 -08001598 no_crt_pad_segment: true,
Jooyung Han8ce8db92020-05-15 19:05:05 +09001599 stl: "none",
1600 system_shared_libs: [],
1601 srcs: [""],
1602 stubs: { versions: ["1"] },
Colin Cross4c4c1be2022-02-10 11:41:18 -08001603 stem: "libclang_rt.hwasan-aarch64-android",
Jooyung Han8ce8db92020-05-15 19:05:05 +09001604
1605 sanitize: {
1606 never: true,
1607 },
Spandan Das4de7b492023-05-05 21:13:01 +00001608 apex_available: [
1609 "//apex_available:anyapex",
1610 "//apex_available:platform",
1611 ],
Jooyung Han8ce8db92020-05-15 19:05:05 +09001612 }
Paul Duffina02cae32021-03-09 01:44:06 +00001613 `)
1614 ctx := result.TestContext
Jooyung Han8ce8db92020-05-15 19:05:05 +09001615
Jooyung Hana0503a52023-08-23 13:12:50 +09001616 ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime", []string{
Jooyung Han8ce8db92020-05-15 19:05:05 +09001617 "lib64/bionic/libc.so",
1618 "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
1619 })
1620
Colin Cross4c4c1be2022-02-10 11:41:18 -08001621 hwasan := ctx.ModuleForTests("libclang_rt.hwasan", "android_arm64_armv8-a_shared")
Jooyung Han8ce8db92020-05-15 19:05:05 +09001622
1623 installed := hwasan.Description("install libclang_rt.hwasan")
1624 ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
1625
1626 symlink := hwasan.Description("install symlink libclang_rt.hwasan")
1627 ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
1628 ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
1629}
1630
Jooyung Han61b66e92020-03-21 14:21:46 +00001631func TestApexDependsOnLLNDKTransitively(t *testing.T) {
1632 testcases := []struct {
1633 name string
1634 minSdkVersion string
Colin Crossaede88c2020-08-11 12:17:01 -07001635 apexVariant string
Jooyung Han61b66e92020-03-21 14:21:46 +00001636 shouldLink string
1637 shouldNotLink []string
1638 }{
1639 {
Jiyong Park55549df2021-02-26 23:57:23 +09001640 name: "unspecified version links to the latest",
Jooyung Han749dc692020-04-15 11:03:39 +09001641 minSdkVersion: "",
Colin Crossaede88c2020-08-11 12:17:01 -07001642 apexVariant: "apex10000",
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001643 shouldLink: "current",
1644 shouldNotLink: []string{"29", "30"},
Jooyung Han61b66e92020-03-21 14:21:46 +00001645 },
1646 {
Jiyong Park55549df2021-02-26 23:57:23 +09001647 name: "always use the latest",
Jooyung Han749dc692020-04-15 11:03:39 +09001648 minSdkVersion: "min_sdk_version: \"29\",",
Colin Crossaede88c2020-08-11 12:17:01 -07001649 apexVariant: "apex29",
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001650 shouldLink: "current",
1651 shouldNotLink: []string{"29", "30"},
Jooyung Han61b66e92020-03-21 14:21:46 +00001652 },
1653 }
1654 for _, tc := range testcases {
1655 t.Run(tc.name, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001656 ctx := testApex(t, `
Jooyung Han61b66e92020-03-21 14:21:46 +00001657 apex {
1658 name: "myapex",
1659 key: "myapex.key",
Jooyung Han61b66e92020-03-21 14:21:46 +00001660 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001661 updatable: false,
Jooyung Han749dc692020-04-15 11:03:39 +09001662 `+tc.minSdkVersion+`
Jooyung Han61b66e92020-03-21 14:21:46 +00001663 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001664
Jooyung Han61b66e92020-03-21 14:21:46 +00001665 apex_key {
1666 name: "myapex.key",
1667 public_key: "testkey.avbpubkey",
1668 private_key: "testkey.pem",
1669 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001670
Jooyung Han61b66e92020-03-21 14:21:46 +00001671 cc_library {
1672 name: "mylib",
1673 srcs: ["mylib.cpp"],
1674 vendor_available: true,
1675 shared_libs: ["libbar"],
1676 system_shared_libs: [],
1677 stl: "none",
1678 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001679 min_sdk_version: "29",
Jooyung Han61b66e92020-03-21 14:21:46 +00001680 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001681
Jooyung Han61b66e92020-03-21 14:21:46 +00001682 cc_library {
1683 name: "libbar",
1684 srcs: ["mylib.cpp"],
1685 system_shared_libs: [],
1686 stl: "none",
1687 stubs: { versions: ["29","30"] },
Colin Cross203b4212021-04-26 17:19:41 -07001688 llndk: {
1689 symbol_file: "libbar.map.txt",
1690 }
Jooyung Han61b66e92020-03-21 14:21:46 +00001691 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001692 `,
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001693 withUnbundledBuild,
1694 )
Jooyung Han9c80bae2019-08-20 17:30:57 +09001695
Jooyung Han61b66e92020-03-21 14:21:46 +00001696 // Ensure that LLNDK dep is not included
Jooyung Hana0503a52023-08-23 13:12:50 +09001697 ensureExactContents(t, ctx, "myapex", "android_common_myapex", []string{
Jooyung Han61b66e92020-03-21 14:21:46 +00001698 "lib64/mylib.so",
1699 })
Jooyung Han9c80bae2019-08-20 17:30:57 +09001700
Jooyung Han61b66e92020-03-21 14:21:46 +00001701 // Ensure that LLNDK dep is required
Jooyung Hana0503a52023-08-23 13:12:50 +09001702 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("apexManifestRule")
Jooyung Han61b66e92020-03-21 14:21:46 +00001703 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
1704 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libbar.so")
Jooyung Han9c80bae2019-08-20 17:30:57 +09001705
Steven Moreland2c4000c2021-04-27 02:08:49 +00001706 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_"+tc.apexVariant).Rule("ld").Args["libFlags"]
1707 ensureContains(t, mylibLdFlags, "libbar/android_arm64_armv8-a_shared_"+tc.shouldLink+"/libbar.so")
Jooyung Han61b66e92020-03-21 14:21:46 +00001708 for _, ver := range tc.shouldNotLink {
Steven Moreland2c4000c2021-04-27 02:08:49 +00001709 ensureNotContains(t, mylibLdFlags, "libbar/android_arm64_armv8-a_shared_"+ver+"/libbar.so")
Jooyung Han61b66e92020-03-21 14:21:46 +00001710 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001711
Steven Moreland2c4000c2021-04-27 02:08:49 +00001712 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_"+tc.apexVariant).Rule("cc").Args["cFlags"]
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001713 ver := tc.shouldLink
1714 if tc.shouldLink == "current" {
1715 ver = strconv.Itoa(android.FutureApiLevelInt)
1716 }
1717 ensureContains(t, mylibCFlags, "__LIBBAR_API__="+ver)
Jooyung Han61b66e92020-03-21 14:21:46 +00001718 })
1719 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001720}
1721
Jiyong Park25fc6a92018-11-18 18:02:45 +09001722func TestApexWithSystemLibsStubs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001723 ctx := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +09001724 apex {
1725 name: "myapex",
1726 key: "myapex.key",
1727 native_shared_libs: ["mylib", "mylib_shared", "libdl", "libm"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001728 updatable: false,
Jiyong Park25fc6a92018-11-18 18:02:45 +09001729 }
1730
1731 apex_key {
1732 name: "myapex.key",
1733 public_key: "testkey.avbpubkey",
1734 private_key: "testkey.pem",
1735 }
1736
1737 cc_library {
1738 name: "mylib",
1739 srcs: ["mylib.cpp"],
Colin Cross0de8a1e2020-09-18 14:15:30 -07001740 system_shared_libs: ["libc", "libm"],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001741 shared_libs: ["libdl#27"],
1742 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001743 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001744 }
1745
1746 cc_library_shared {
1747 name: "mylib_shared",
1748 srcs: ["mylib.cpp"],
1749 shared_libs: ["libdl#27"],
1750 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001751 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001752 }
1753
1754 cc_library {
Jiyong Parkb0788572018-12-20 22:10:17 +09001755 name: "libBootstrap",
1756 srcs: ["mylib.cpp"],
1757 stl: "none",
1758 bootstrap: true,
1759 }
Jiyong Park25fc6a92018-11-18 18:02:45 +09001760 `)
1761
Jooyung Hana0503a52023-08-23 13:12:50 +09001762 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001763 copyCmds := apexRule.Args["copy_commands"]
1764
1765 // Ensure that mylib, libm, libdl are included.
Alex Light5098a612018-11-29 17:12:15 -08001766 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Parkb0788572018-12-20 22:10:17 +09001767 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libm.so")
1768 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001769
1770 // Ensure that libc is not included (since it has stubs and not listed in native_shared_libs)
Jiyong Parkb0788572018-12-20 22:10:17 +09001771 ensureNotContains(t, copyCmds, "image.apex/lib64/bionic/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001772
Colin Crossaede88c2020-08-11 12:17:01 -07001773 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
1774 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
1775 mylibSharedCFlags := ctx.ModuleForTests("mylib_shared", "android_arm64_armv8-a_shared_apex10000").Rule("cc").Args["cFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +09001776
1777 // For dependency to libc
1778 // Ensure that mylib is linking with the latest version of stubs
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001779 ensureContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared_current/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001780 // ... and not linking to the non-stub (impl) variant
Jiyong Park3ff16992019-12-27 14:11:47 +09001781 ensureNotContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001782 // ... Cflags from stub is correctly exported to mylib
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001783 ensureContains(t, mylibCFlags, "__LIBC_API__=10000")
1784 ensureContains(t, mylibSharedCFlags, "__LIBC_API__=10000")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001785
1786 // For dependency to libm
1787 // Ensure that mylib is linking with the non-stub (impl) variant
Colin Crossaede88c2020-08-11 12:17:01 -07001788 ensureContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_apex10000/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001789 // ... and not linking to the stub variant
Jiyong Park3ff16992019-12-27 14:11:47 +09001790 ensureNotContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_29/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001791 // ... and is not compiling with the stub
1792 ensureNotContains(t, mylibCFlags, "__LIBM_API__=29")
1793 ensureNotContains(t, mylibSharedCFlags, "__LIBM_API__=29")
1794
1795 // For dependency to libdl
1796 // Ensure that mylib is linking with the specified version of stubs
Jiyong Park3ff16992019-12-27 14:11:47 +09001797 ensureContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_27/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001798 // ... and not linking to the other versions of stubs
Jiyong Park3ff16992019-12-27 14:11:47 +09001799 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_28/libdl.so")
1800 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_29/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001801 // ... and not linking to the non-stub (impl) variant
Colin Crossaede88c2020-08-11 12:17:01 -07001802 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_apex10000/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001803 // ... Cflags from stub is correctly exported to mylib
1804 ensureContains(t, mylibCFlags, "__LIBDL_API__=27")
1805 ensureContains(t, mylibSharedCFlags, "__LIBDL_API__=27")
Jiyong Parkb0788572018-12-20 22:10:17 +09001806
1807 // Ensure that libBootstrap is depending on the platform variant of bionic libs
Colin Cross7113d202019-11-20 16:39:12 -08001808 libFlags := ctx.ModuleForTests("libBootstrap", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
1809 ensureContains(t, libFlags, "libc/android_arm64_armv8-a_shared/libc.so")
1810 ensureContains(t, libFlags, "libm/android_arm64_armv8-a_shared/libm.so")
1811 ensureContains(t, libFlags, "libdl/android_arm64_armv8-a_shared/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001812}
Jiyong Park7c2ee712018-12-07 00:42:25 +09001813
Jooyung Han749dc692020-04-15 11:03:39 +09001814func TestApexMinSdkVersion_NativeModulesShouldBeBuiltAgainstStubs(t *testing.T) {
Jiyong Park55549df2021-02-26 23:57:23 +09001815 // there are three links between liba --> libz.
1816 // 1) myapex -> libx -> liba -> libz : this should be #30 link
Jooyung Han749dc692020-04-15 11:03:39 +09001817 // 2) otherapex -> liby -> liba -> libz : this should be #30 link
Jooyung Han03b51852020-02-26 22:45:42 +09001818 // 3) (platform) -> liba -> libz : this should be non-stub link
Colin Cross1c460562021-02-16 17:55:47 -08001819 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001820 apex {
1821 name: "myapex",
1822 key: "myapex.key",
1823 native_shared_libs: ["libx"],
Jooyung Han749dc692020-04-15 11:03:39 +09001824 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001825 }
1826
1827 apex {
1828 name: "otherapex",
1829 key: "myapex.key",
1830 native_shared_libs: ["liby"],
Jooyung Han749dc692020-04-15 11:03:39 +09001831 min_sdk_version: "30",
Jooyung Han03b51852020-02-26 22:45:42 +09001832 }
1833
1834 apex_key {
1835 name: "myapex.key",
1836 public_key: "testkey.avbpubkey",
1837 private_key: "testkey.pem",
1838 }
1839
1840 cc_library {
1841 name: "libx",
1842 shared_libs: ["liba"],
1843 system_shared_libs: [],
1844 stl: "none",
1845 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001846 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001847 }
1848
1849 cc_library {
1850 name: "liby",
1851 shared_libs: ["liba"],
1852 system_shared_libs: [],
1853 stl: "none",
1854 apex_available: [ "otherapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001855 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001856 }
1857
1858 cc_library {
1859 name: "liba",
1860 shared_libs: ["libz"],
1861 system_shared_libs: [],
1862 stl: "none",
1863 apex_available: [
1864 "//apex_available:anyapex",
1865 "//apex_available:platform",
1866 ],
Jooyung Han749dc692020-04-15 11:03:39 +09001867 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09001868 }
1869
1870 cc_library {
1871 name: "libz",
1872 system_shared_libs: [],
1873 stl: "none",
1874 stubs: {
Jooyung Han749dc692020-04-15 11:03:39 +09001875 versions: ["28", "30"],
Jooyung Han03b51852020-02-26 22:45:42 +09001876 },
1877 }
Jooyung Han749dc692020-04-15 11:03:39 +09001878 `)
Jooyung Han03b51852020-02-26 22:45:42 +09001879
1880 expectLink := func(from, from_variant, to, to_variant string) {
1881 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1882 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1883 }
1884 expectNoLink := func(from, from_variant, to, to_variant string) {
1885 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1886 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1887 }
1888 // platform liba is linked to non-stub version
1889 expectLink("liba", "shared", "libz", "shared")
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001890 // liba in myapex is linked to current
1891 expectLink("liba", "shared_apex29", "libz", "shared_current")
1892 expectNoLink("liba", "shared_apex29", "libz", "shared_30")
Jiyong Park55549df2021-02-26 23:57:23 +09001893 expectNoLink("liba", "shared_apex29", "libz", "shared_28")
Colin Crossaede88c2020-08-11 12:17:01 -07001894 expectNoLink("liba", "shared_apex29", "libz", "shared")
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001895 // liba in otherapex is linked to current
1896 expectLink("liba", "shared_apex30", "libz", "shared_current")
1897 expectNoLink("liba", "shared_apex30", "libz", "shared_30")
Colin Crossaede88c2020-08-11 12:17:01 -07001898 expectNoLink("liba", "shared_apex30", "libz", "shared_28")
1899 expectNoLink("liba", "shared_apex30", "libz", "shared")
Jooyung Han03b51852020-02-26 22:45:42 +09001900}
1901
Jooyung Hanaed150d2020-04-02 01:41:41 +09001902func TestApexMinSdkVersion_SupportsCodeNames(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001903 ctx := testApex(t, `
Jooyung Hanaed150d2020-04-02 01:41:41 +09001904 apex {
1905 name: "myapex",
1906 key: "myapex.key",
1907 native_shared_libs: ["libx"],
1908 min_sdk_version: "R",
1909 }
1910
1911 apex_key {
1912 name: "myapex.key",
1913 public_key: "testkey.avbpubkey",
1914 private_key: "testkey.pem",
1915 }
1916
1917 cc_library {
1918 name: "libx",
1919 shared_libs: ["libz"],
1920 system_shared_libs: [],
1921 stl: "none",
1922 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09001923 min_sdk_version: "R",
Jooyung Hanaed150d2020-04-02 01:41:41 +09001924 }
1925
1926 cc_library {
1927 name: "libz",
1928 system_shared_libs: [],
1929 stl: "none",
1930 stubs: {
1931 versions: ["29", "R"],
1932 },
1933 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00001934 `,
1935 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1936 variables.Platform_version_active_codenames = []string{"R"}
1937 }),
1938 )
Jooyung Hanaed150d2020-04-02 01:41:41 +09001939
1940 expectLink := func(from, from_variant, to, to_variant string) {
1941 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1942 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1943 }
1944 expectNoLink := func(from, from_variant, to, to_variant string) {
1945 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1946 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1947 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09001948 expectLink("libx", "shared_apex10000", "libz", "shared_current")
1949 expectNoLink("libx", "shared_apex10000", "libz", "shared_R")
Colin Crossaede88c2020-08-11 12:17:01 -07001950 expectNoLink("libx", "shared_apex10000", "libz", "shared_29")
1951 expectNoLink("libx", "shared_apex10000", "libz", "shared")
Jooyung Hanaed150d2020-04-02 01:41:41 +09001952}
1953
Jooyung Han4c4da062021-06-23 10:23:16 +09001954func TestApexMinSdkVersion_SupportsCodeNames_JavaLibs(t *testing.T) {
1955 testApex(t, `
1956 apex {
1957 name: "myapex",
1958 key: "myapex.key",
1959 java_libs: ["libx"],
1960 min_sdk_version: "S",
1961 }
1962
1963 apex_key {
1964 name: "myapex.key",
1965 public_key: "testkey.avbpubkey",
1966 private_key: "testkey.pem",
1967 }
1968
1969 java_library {
1970 name: "libx",
1971 srcs: ["a.java"],
1972 apex_available: [ "myapex" ],
1973 sdk_version: "current",
1974 min_sdk_version: "S", // should be okay
1975 }
1976 `,
1977 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
1978 variables.Platform_version_active_codenames = []string{"S"}
1979 variables.Platform_sdk_codename = proptools.StringPtr("S")
1980 }),
1981 )
1982}
1983
Jooyung Han749dc692020-04-15 11:03:39 +09001984func TestApexMinSdkVersion_DefaultsToLatest(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08001985 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09001986 apex {
1987 name: "myapex",
1988 key: "myapex.key",
1989 native_shared_libs: ["libx"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00001990 updatable: false,
Jooyung Han03b51852020-02-26 22:45:42 +09001991 }
1992
1993 apex_key {
1994 name: "myapex.key",
1995 public_key: "testkey.avbpubkey",
1996 private_key: "testkey.pem",
1997 }
1998
1999 cc_library {
2000 name: "libx",
2001 shared_libs: ["libz"],
2002 system_shared_libs: [],
2003 stl: "none",
2004 apex_available: [ "myapex" ],
2005 }
2006
2007 cc_library {
2008 name: "libz",
2009 system_shared_libs: [],
2010 stl: "none",
2011 stubs: {
2012 versions: ["1", "2"],
2013 },
2014 }
2015 `)
2016
2017 expectLink := func(from, from_variant, to, to_variant string) {
2018 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
2019 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
2020 }
2021 expectNoLink := func(from, from_variant, to, to_variant string) {
2022 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
2023 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
2024 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002025 expectLink("libx", "shared_apex10000", "libz", "shared_current")
Colin Crossaede88c2020-08-11 12:17:01 -07002026 expectNoLink("libx", "shared_apex10000", "libz", "shared_1")
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002027 expectNoLink("libx", "shared_apex10000", "libz", "shared_2")
Colin Crossaede88c2020-08-11 12:17:01 -07002028 expectNoLink("libx", "shared_apex10000", "libz", "shared")
Jooyung Han03b51852020-02-26 22:45:42 +09002029}
2030
Jooyung Handfc864c2023-03-20 18:19:07 +09002031func TestApexMinSdkVersion_InVendorApex(t *testing.T) {
Jiyong Park5df7bd32021-08-25 16:18:46 +09002032 ctx := testApex(t, `
2033 apex {
2034 name: "myapex",
2035 key: "myapex.key",
2036 native_shared_libs: ["mylib"],
Jooyung Handfc864c2023-03-20 18:19:07 +09002037 updatable: true,
Jiyong Park5df7bd32021-08-25 16:18:46 +09002038 vendor: true,
2039 min_sdk_version: "29",
2040 }
2041
2042 apex_key {
2043 name: "myapex.key",
2044 public_key: "testkey.avbpubkey",
2045 private_key: "testkey.pem",
2046 }
2047
2048 cc_library {
2049 name: "mylib",
Jooyung Handfc864c2023-03-20 18:19:07 +09002050 srcs: ["mylib.cpp"],
Jiyong Park5df7bd32021-08-25 16:18:46 +09002051 vendor_available: true,
Jiyong Park5df7bd32021-08-25 16:18:46 +09002052 min_sdk_version: "29",
Jooyung Handfc864c2023-03-20 18:19:07 +09002053 shared_libs: ["libbar"],
2054 }
2055
2056 cc_library {
2057 name: "libbar",
2058 stubs: { versions: ["29", "30"] },
2059 llndk: { symbol_file: "libbar.map.txt" },
Jiyong Park5df7bd32021-08-25 16:18:46 +09002060 }
2061 `)
2062
Kiyoung Kim0d1c1e62024-03-26 16:33:58 +09002063 vendorVariant := "android_vendor_arm64_armv8-a"
Jiyong Park5df7bd32021-08-25 16:18:46 +09002064
Kiyoung Kim0d1c1e62024-03-26 16:33:58 +09002065 mylib := ctx.ModuleForTests("mylib", vendorVariant+"_shared_apex29")
Jooyung Handfc864c2023-03-20 18:19:07 +09002066
2067 // Ensure that mylib links with "current" LLNDK
2068 libFlags := names(mylib.Rule("ld").Args["libFlags"])
Jooyung Han5e8994e2024-03-12 14:12:12 +09002069 ensureListContains(t, libFlags, "out/soong/.intermediates/libbar/"+vendorVariant+"_shared/libbar.so")
Jooyung Handfc864c2023-03-20 18:19:07 +09002070
2071 // Ensure that mylib is targeting 29
2072 ccRule := ctx.ModuleForTests("mylib", vendorVariant+"_static_apex29").Output("obj/mylib.o")
2073 ensureContains(t, ccRule.Args["cFlags"], "-target aarch64-linux-android29")
2074
2075 // Ensure that the correct variant of crtbegin_so is used.
2076 crtBegin := mylib.Rule("ld").Args["crtBegin"]
2077 ensureContains(t, crtBegin, "out/soong/.intermediates/"+cc.DefaultCcCommonTestModulesDir+"crtbegin_so/"+vendorVariant+"_apex29/crtbegin_so.o")
Jiyong Park5df7bd32021-08-25 16:18:46 +09002078
2079 // Ensure that the crtbegin_so used by the APEX is targeting 29
2080 cflags := ctx.ModuleForTests("crtbegin_so", vendorVariant+"_apex29").Rule("cc").Args["cFlags"]
2081 android.AssertStringDoesContain(t, "cflags", cflags, "-target aarch64-linux-android29")
2082}
2083
Jooyung Han4495f842023-04-25 16:39:59 +09002084func TestTrackAllowedDeps(t *testing.T) {
2085 ctx := testApex(t, `
2086 apex {
2087 name: "myapex",
2088 key: "myapex.key",
2089 updatable: true,
2090 native_shared_libs: [
2091 "mylib",
2092 "yourlib",
2093 ],
2094 min_sdk_version: "29",
2095 }
2096
2097 apex {
2098 name: "myapex2",
2099 key: "myapex.key",
2100 updatable: false,
2101 native_shared_libs: ["yourlib"],
2102 }
2103
2104 apex_key {
2105 name: "myapex.key",
2106 public_key: "testkey.avbpubkey",
2107 private_key: "testkey.pem",
2108 }
2109
2110 cc_library {
2111 name: "mylib",
2112 srcs: ["mylib.cpp"],
2113 shared_libs: ["libbar"],
2114 min_sdk_version: "29",
2115 apex_available: ["myapex"],
2116 }
2117
2118 cc_library {
2119 name: "libbar",
2120 stubs: { versions: ["29", "30"] },
2121 }
2122
2123 cc_library {
2124 name: "yourlib",
2125 srcs: ["mylib.cpp"],
2126 min_sdk_version: "29",
2127 apex_available: ["myapex", "myapex2", "//apex_available:platform"],
2128 }
2129 `, withFiles(android.MockFS{
2130 "packages/modules/common/build/allowed_deps.txt": nil,
2131 }))
2132
2133 depsinfo := ctx.SingletonForTests("apex_depsinfo_singleton")
2134 inputs := depsinfo.Rule("generateApexDepsInfoFilesRule").BuildParams.Inputs.Strings()
2135 android.AssertStringListContains(t, "updatable myapex should generate depsinfo file", inputs,
Jooyung Hana0503a52023-08-23 13:12:50 +09002136 "out/soong/.intermediates/myapex/android_common_myapex/depsinfo/flatlist.txt")
Jooyung Han4495f842023-04-25 16:39:59 +09002137 android.AssertStringListDoesNotContain(t, "non-updatable myapex2 should not generate depsinfo file", inputs,
Jooyung Hana0503a52023-08-23 13:12:50 +09002138 "out/soong/.intermediates/myapex2/android_common_myapex2/depsinfo/flatlist.txt")
Jooyung Han4495f842023-04-25 16:39:59 +09002139
Jooyung Hana0503a52023-08-23 13:12:50 +09002140 myapex := ctx.ModuleForTests("myapex", "android_common_myapex")
Colin Crossf61d03d2023-11-02 16:56:39 -07002141 flatlist := strings.Split(android.ContentFromFileRuleForTests(t, ctx,
2142 myapex.Output("depsinfo/flatlist.txt")), "\n")
Jooyung Han4495f842023-04-25 16:39:59 +09002143 android.AssertStringListContains(t, "deps with stubs should be tracked in depsinfo as external dep",
2144 flatlist, "libbar(minSdkVersion:(no version)) (external)")
2145 android.AssertStringListDoesNotContain(t, "do not track if not available for platform",
2146 flatlist, "mylib:(minSdkVersion:29)")
2147 android.AssertStringListContains(t, "track platform-available lib",
2148 flatlist, "yourlib(minSdkVersion:29)")
2149}
2150
2151func TestTrackAllowedDeps_SkipWithoutAllowedDepsTxt(t *testing.T) {
2152 ctx := testApex(t, `
2153 apex {
2154 name: "myapex",
2155 key: "myapex.key",
2156 updatable: true,
2157 min_sdk_version: "29",
2158 }
2159
2160 apex_key {
2161 name: "myapex.key",
2162 public_key: "testkey.avbpubkey",
2163 private_key: "testkey.pem",
2164 }
2165 `)
2166 depsinfo := ctx.SingletonForTests("apex_depsinfo_singleton")
2167 if nil != depsinfo.MaybeRule("generateApexDepsInfoFilesRule").Output {
2168 t.Error("apex_depsinfo_singleton shouldn't run when allowed_deps.txt doesn't exist")
2169 }
2170}
2171
Jooyung Han03b51852020-02-26 22:45:42 +09002172func TestPlatformUsesLatestStubsFromApexes(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002173 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09002174 apex {
2175 name: "myapex",
2176 key: "myapex.key",
2177 native_shared_libs: ["libx"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002178 updatable: false,
Jooyung Han03b51852020-02-26 22:45:42 +09002179 }
2180
2181 apex_key {
2182 name: "myapex.key",
2183 public_key: "testkey.avbpubkey",
2184 private_key: "testkey.pem",
2185 }
2186
2187 cc_library {
2188 name: "libx",
2189 system_shared_libs: [],
2190 stl: "none",
2191 apex_available: [ "myapex" ],
2192 stubs: {
2193 versions: ["1", "2"],
2194 },
2195 }
2196
2197 cc_library {
2198 name: "libz",
2199 shared_libs: ["libx"],
2200 system_shared_libs: [],
2201 stl: "none",
2202 }
2203 `)
2204
2205 expectLink := func(from, from_variant, to, to_variant string) {
Colin Cross56a83212020-09-15 18:30:11 -07002206 t.Helper()
Jooyung Han03b51852020-02-26 22:45:42 +09002207 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
2208 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
2209 }
2210 expectNoLink := func(from, from_variant, to, to_variant string) {
Colin Cross56a83212020-09-15 18:30:11 -07002211 t.Helper()
Jooyung Han03b51852020-02-26 22:45:42 +09002212 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
2213 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
2214 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002215 expectLink("libz", "shared", "libx", "shared_current")
2216 expectNoLink("libz", "shared", "libx", "shared_2")
Jooyung Han03b51852020-02-26 22:45:42 +09002217 expectNoLink("libz", "shared", "libz", "shared_1")
2218 expectNoLink("libz", "shared", "libz", "shared")
2219}
2220
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002221var prepareForTestWithSantitizeHwaddress = android.FixtureModifyProductVariables(
2222 func(variables android.FixtureProductVariables) {
2223 variables.SanitizeDevice = []string{"hwaddress"}
2224 },
2225)
2226
Jooyung Han75568392020-03-20 04:29:24 +09002227func TestQApexesUseLatestStubsInBundledBuildsAndHWASAN(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002228 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09002229 apex {
2230 name: "myapex",
2231 key: "myapex.key",
2232 native_shared_libs: ["libx"],
2233 min_sdk_version: "29",
2234 }
2235
2236 apex_key {
2237 name: "myapex.key",
2238 public_key: "testkey.avbpubkey",
2239 private_key: "testkey.pem",
2240 }
2241
2242 cc_library {
2243 name: "libx",
2244 shared_libs: ["libbar"],
2245 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09002246 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09002247 }
2248
2249 cc_library {
2250 name: "libbar",
2251 stubs: {
2252 versions: ["29", "30"],
2253 },
2254 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002255 `,
2256 prepareForTestWithSantitizeHwaddress,
2257 )
Jooyung Han03b51852020-02-26 22:45:42 +09002258 expectLink := func(from, from_variant, to, to_variant string) {
2259 ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
2260 libFlags := ld.Args["libFlags"]
2261 ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
2262 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002263 expectLink("libx", "shared_hwasan_apex29", "libbar", "shared_current")
Jooyung Han03b51852020-02-26 22:45:42 +09002264}
2265
Jooyung Han75568392020-03-20 04:29:24 +09002266func TestQTargetApexUsesStaticUnwinder(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002267 ctx := testApex(t, `
Jooyung Han03b51852020-02-26 22:45:42 +09002268 apex {
2269 name: "myapex",
2270 key: "myapex.key",
2271 native_shared_libs: ["libx"],
2272 min_sdk_version: "29",
2273 }
2274
2275 apex_key {
2276 name: "myapex.key",
2277 public_key: "testkey.avbpubkey",
2278 private_key: "testkey.pem",
2279 }
2280
2281 cc_library {
2282 name: "libx",
2283 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09002284 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09002285 }
Jooyung Han75568392020-03-20 04:29:24 +09002286 `)
Jooyung Han03b51852020-02-26 22:45:42 +09002287
2288 // ensure apex variant of c++ is linked with static unwinder
Colin Crossaede88c2020-08-11 12:17:01 -07002289 cm := ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared_apex29").Module().(*cc.Module)
Ryan Prichardb35a85e2021-01-13 19:18:53 -08002290 ensureListContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
Jooyung Han03b51852020-02-26 22:45:42 +09002291 // note that platform variant is not.
2292 cm = ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared").Module().(*cc.Module)
Ryan Prichardb35a85e2021-01-13 19:18:53 -08002293 ensureListNotContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
Jooyung Han03b51852020-02-26 22:45:42 +09002294}
2295
Jooyung Han749dc692020-04-15 11:03:39 +09002296func TestApexMinSdkVersion_ErrorIfIncompatibleVersion(t *testing.T) {
2297 testApexError(t, `module "mylib".*: should support min_sdk_version\(29\)`, `
Jooyung Han03b51852020-02-26 22:45:42 +09002298 apex {
2299 name: "myapex",
2300 key: "myapex.key",
Jooyung Han749dc692020-04-15 11:03:39 +09002301 native_shared_libs: ["mylib"],
2302 min_sdk_version: "29",
Jooyung Han03b51852020-02-26 22:45:42 +09002303 }
2304
2305 apex_key {
2306 name: "myapex.key",
2307 public_key: "testkey.avbpubkey",
2308 private_key: "testkey.pem",
2309 }
Jooyung Han749dc692020-04-15 11:03:39 +09002310
2311 cc_library {
2312 name: "mylib",
2313 srcs: ["mylib.cpp"],
2314 system_shared_libs: [],
2315 stl: "none",
2316 apex_available: [
2317 "myapex",
2318 ],
2319 min_sdk_version: "30",
2320 }
2321 `)
Ivan Lozano3e9f9e42020-12-04 15:05:43 -05002322
2323 testApexError(t, `module "libfoo.ffi".*: should support min_sdk_version\(29\)`, `
2324 apex {
2325 name: "myapex",
2326 key: "myapex.key",
2327 native_shared_libs: ["libfoo.ffi"],
2328 min_sdk_version: "29",
2329 }
2330
2331 apex_key {
2332 name: "myapex.key",
2333 public_key: "testkey.avbpubkey",
2334 private_key: "testkey.pem",
2335 }
2336
2337 rust_ffi_shared {
2338 name: "libfoo.ffi",
2339 srcs: ["foo.rs"],
2340 crate_name: "foo",
2341 apex_available: [
2342 "myapex",
2343 ],
2344 min_sdk_version: "30",
2345 }
2346 `)
Jaewoong Jung56e12db2021-04-02 00:38:25 +00002347
2348 testApexError(t, `module "libfoo".*: should support min_sdk_version\(29\)`, `
2349 apex {
2350 name: "myapex",
2351 key: "myapex.key",
2352 java_libs: ["libfoo"],
2353 min_sdk_version: "29",
2354 }
2355
2356 apex_key {
2357 name: "myapex.key",
2358 public_key: "testkey.avbpubkey",
2359 private_key: "testkey.pem",
2360 }
2361
2362 java_import {
2363 name: "libfoo",
2364 jars: ["libfoo.jar"],
2365 apex_available: [
2366 "myapex",
2367 ],
2368 min_sdk_version: "30",
2369 }
2370 `)
Spandan Das7fa982c2023-02-24 18:38:56 +00002371
2372 // Skip check for modules compiling against core API surface
2373 testApex(t, `
2374 apex {
2375 name: "myapex",
2376 key: "myapex.key",
2377 java_libs: ["libfoo"],
2378 min_sdk_version: "29",
2379 }
2380
2381 apex_key {
2382 name: "myapex.key",
2383 public_key: "testkey.avbpubkey",
2384 private_key: "testkey.pem",
2385 }
2386
2387 java_library {
2388 name: "libfoo",
2389 srcs: ["Foo.java"],
2390 apex_available: [
2391 "myapex",
2392 ],
2393 // Compile against core API surface
2394 sdk_version: "core_current",
2395 min_sdk_version: "30",
2396 }
2397 `)
2398
Jooyung Han749dc692020-04-15 11:03:39 +09002399}
2400
2401func TestApexMinSdkVersion_Okay(t *testing.T) {
2402 testApex(t, `
2403 apex {
2404 name: "myapex",
2405 key: "myapex.key",
2406 native_shared_libs: ["libfoo"],
2407 java_libs: ["libbar"],
2408 min_sdk_version: "29",
2409 }
2410
2411 apex_key {
2412 name: "myapex.key",
2413 public_key: "testkey.avbpubkey",
2414 private_key: "testkey.pem",
2415 }
2416
2417 cc_library {
2418 name: "libfoo",
2419 srcs: ["mylib.cpp"],
2420 shared_libs: ["libfoo_dep"],
2421 apex_available: ["myapex"],
2422 min_sdk_version: "29",
2423 }
2424
2425 cc_library {
2426 name: "libfoo_dep",
2427 srcs: ["mylib.cpp"],
2428 apex_available: ["myapex"],
2429 min_sdk_version: "29",
2430 }
2431
2432 java_library {
2433 name: "libbar",
2434 sdk_version: "current",
2435 srcs: ["a.java"],
Jaewoong Jung56e12db2021-04-02 00:38:25 +00002436 static_libs: [
2437 "libbar_dep",
2438 "libbar_import_dep",
2439 ],
Jooyung Han749dc692020-04-15 11:03:39 +09002440 apex_available: ["myapex"],
2441 min_sdk_version: "29",
2442 }
2443
2444 java_library {
2445 name: "libbar_dep",
2446 sdk_version: "current",
2447 srcs: ["a.java"],
2448 apex_available: ["myapex"],
2449 min_sdk_version: "29",
2450 }
Jaewoong Jung56e12db2021-04-02 00:38:25 +00002451
2452 java_import {
2453 name: "libbar_import_dep",
2454 jars: ["libbar.jar"],
2455 apex_available: ["myapex"],
2456 min_sdk_version: "29",
2457 }
Jooyung Han03b51852020-02-26 22:45:42 +09002458 `)
2459}
2460
Colin Cross8ca61c12022-10-06 21:00:14 -07002461func TestApexMinSdkVersion_MinApiForArch(t *testing.T) {
2462 // Tests that an apex dependency with min_sdk_version higher than the
2463 // min_sdk_version of the apex is allowed as long as the dependency's
2464 // min_sdk_version is less than or equal to the api level that the
2465 // architecture was introduced in. In this case, arm64 didn't exist
2466 // until api level 21, so the arm64 code will never need to run on
2467 // an api level 20 device, even if other architectures of the apex
2468 // will.
2469 testApex(t, `
2470 apex {
2471 name: "myapex",
2472 key: "myapex.key",
2473 native_shared_libs: ["libfoo"],
2474 min_sdk_version: "20",
2475 }
2476
2477 apex_key {
2478 name: "myapex.key",
2479 public_key: "testkey.avbpubkey",
2480 private_key: "testkey.pem",
2481 }
2482
2483 cc_library {
2484 name: "libfoo",
2485 srcs: ["mylib.cpp"],
2486 apex_available: ["myapex"],
2487 min_sdk_version: "21",
2488 stl: "none",
2489 }
2490 `)
2491}
2492
Artur Satayev8cf899a2020-04-15 17:29:42 +01002493func TestJavaStableSdkVersion(t *testing.T) {
2494 testCases := []struct {
2495 name string
2496 expectedError string
2497 bp string
Paul Duffin1ea7c9f2021-03-15 09:39:13 +00002498 preparer android.FixturePreparer
Artur Satayev8cf899a2020-04-15 17:29:42 +01002499 }{
2500 {
2501 name: "Non-updatable apex with non-stable dep",
2502 bp: `
2503 apex {
2504 name: "myapex",
2505 java_libs: ["myjar"],
2506 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002507 updatable: false,
Artur Satayev8cf899a2020-04-15 17:29:42 +01002508 }
2509 apex_key {
2510 name: "myapex.key",
2511 public_key: "testkey.avbpubkey",
2512 private_key: "testkey.pem",
2513 }
2514 java_library {
2515 name: "myjar",
2516 srcs: ["foo/bar/MyClass.java"],
Paul Duffin043f5e72021-03-05 00:00:01 +00002517 sdk_version: "test_current",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002518 apex_available: ["myapex"],
2519 }
2520 `,
2521 },
2522 {
2523 name: "Updatable apex with stable dep",
2524 bp: `
2525 apex {
2526 name: "myapex",
2527 java_libs: ["myjar"],
2528 key: "myapex.key",
2529 updatable: true,
2530 min_sdk_version: "29",
2531 }
2532 apex_key {
2533 name: "myapex.key",
2534 public_key: "testkey.avbpubkey",
2535 private_key: "testkey.pem",
2536 }
2537 java_library {
2538 name: "myjar",
2539 srcs: ["foo/bar/MyClass.java"],
2540 sdk_version: "current",
2541 apex_available: ["myapex"],
Jooyung Han749dc692020-04-15 11:03:39 +09002542 min_sdk_version: "29",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002543 }
2544 `,
2545 },
2546 {
2547 name: "Updatable apex with non-stable dep",
2548 expectedError: "cannot depend on \"myjar\"",
2549 bp: `
2550 apex {
2551 name: "myapex",
2552 java_libs: ["myjar"],
2553 key: "myapex.key",
2554 updatable: true,
2555 }
2556 apex_key {
2557 name: "myapex.key",
2558 public_key: "testkey.avbpubkey",
2559 private_key: "testkey.pem",
2560 }
2561 java_library {
2562 name: "myjar",
2563 srcs: ["foo/bar/MyClass.java"],
Paul Duffin043f5e72021-03-05 00:00:01 +00002564 sdk_version: "test_current",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002565 apex_available: ["myapex"],
2566 }
2567 `,
2568 },
2569 {
Paul Duffin1ea7c9f2021-03-15 09:39:13 +00002570 name: "Updatable apex with non-stable legacy core platform dep",
2571 expectedError: `\Qcannot depend on "myjar-uses-legacy": non stable SDK core_platform_current - uses legacy core platform\E`,
2572 bp: `
2573 apex {
2574 name: "myapex",
2575 java_libs: ["myjar-uses-legacy"],
2576 key: "myapex.key",
2577 updatable: true,
2578 }
2579 apex_key {
2580 name: "myapex.key",
2581 public_key: "testkey.avbpubkey",
2582 private_key: "testkey.pem",
2583 }
2584 java_library {
2585 name: "myjar-uses-legacy",
2586 srcs: ["foo/bar/MyClass.java"],
2587 sdk_version: "core_platform",
2588 apex_available: ["myapex"],
2589 }
2590 `,
2591 preparer: java.FixtureUseLegacyCorePlatformApi("myjar-uses-legacy"),
2592 },
2593 {
Paul Duffin043f5e72021-03-05 00:00:01 +00002594 name: "Updatable apex with non-stable transitive dep",
2595 // This is not actually detecting that the transitive dependency is unstable, rather it is
2596 // detecting that the transitive dependency is building against a wider API surface than the
2597 // module that depends on it is using.
Jiyong Park670e0f62021-02-18 13:10:18 +09002598 expectedError: "compiles against Android API, but dependency \"transitive-jar\" is compiling against private API.",
Artur Satayev8cf899a2020-04-15 17:29:42 +01002599 bp: `
2600 apex {
2601 name: "myapex",
2602 java_libs: ["myjar"],
2603 key: "myapex.key",
2604 updatable: true,
2605 }
2606 apex_key {
2607 name: "myapex.key",
2608 public_key: "testkey.avbpubkey",
2609 private_key: "testkey.pem",
2610 }
2611 java_library {
2612 name: "myjar",
2613 srcs: ["foo/bar/MyClass.java"],
2614 sdk_version: "current",
2615 apex_available: ["myapex"],
2616 static_libs: ["transitive-jar"],
2617 }
2618 java_library {
2619 name: "transitive-jar",
2620 srcs: ["foo/bar/MyClass.java"],
2621 sdk_version: "core_platform",
2622 apex_available: ["myapex"],
2623 }
2624 `,
2625 },
2626 }
2627
2628 for _, test := range testCases {
Paul Duffin1ea7c9f2021-03-15 09:39:13 +00002629 if test.name != "Updatable apex with non-stable legacy core platform dep" {
2630 continue
2631 }
Artur Satayev8cf899a2020-04-15 17:29:42 +01002632 t.Run(test.name, func(t *testing.T) {
Paul Duffin1ea7c9f2021-03-15 09:39:13 +00002633 errorHandler := android.FixtureExpectsNoErrors
2634 if test.expectedError != "" {
2635 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(test.expectedError)
Artur Satayev8cf899a2020-04-15 17:29:42 +01002636 }
Paul Duffin1ea7c9f2021-03-15 09:39:13 +00002637 android.GroupFixturePreparers(
2638 java.PrepareForTestWithJavaDefaultModules,
2639 PrepareForTestWithApexBuildComponents,
2640 prepareForTestWithMyapex,
2641 android.OptionalFixturePreparer(test.preparer),
2642 ).
2643 ExtendWithErrorHandler(errorHandler).
2644 RunTestWithBp(t, test.bp)
Artur Satayev8cf899a2020-04-15 17:29:42 +01002645 })
2646 }
2647}
2648
Jooyung Han749dc692020-04-15 11:03:39 +09002649func TestApexMinSdkVersion_ErrorIfDepIsNewer(t *testing.T) {
2650 testApexError(t, `module "mylib2".*: should support min_sdk_version\(29\) for "myapex"`, `
2651 apex {
2652 name: "myapex",
2653 key: "myapex.key",
2654 native_shared_libs: ["mylib"],
2655 min_sdk_version: "29",
2656 }
2657
2658 apex_key {
2659 name: "myapex.key",
2660 public_key: "testkey.avbpubkey",
2661 private_key: "testkey.pem",
2662 }
2663
2664 cc_library {
2665 name: "mylib",
2666 srcs: ["mylib.cpp"],
2667 shared_libs: ["mylib2"],
2668 system_shared_libs: [],
2669 stl: "none",
2670 apex_available: [
2671 "myapex",
2672 ],
2673 min_sdk_version: "29",
2674 }
2675
2676 // indirect part of the apex
2677 cc_library {
2678 name: "mylib2",
2679 srcs: ["mylib.cpp"],
2680 system_shared_libs: [],
2681 stl: "none",
2682 apex_available: [
2683 "myapex",
2684 ],
2685 min_sdk_version: "30",
2686 }
2687 `)
2688}
2689
2690func TestApexMinSdkVersion_ErrorIfDepIsNewer_Java(t *testing.T) {
2691 testApexError(t, `module "bar".*: should support min_sdk_version\(29\) for "myapex"`, `
2692 apex {
2693 name: "myapex",
2694 key: "myapex.key",
2695 apps: ["AppFoo"],
2696 min_sdk_version: "29",
Spandan Das42e89502022-05-06 22:12:55 +00002697 updatable: false,
Jooyung Han749dc692020-04-15 11:03:39 +09002698 }
2699
2700 apex_key {
2701 name: "myapex.key",
2702 public_key: "testkey.avbpubkey",
2703 private_key: "testkey.pem",
2704 }
2705
2706 android_app {
2707 name: "AppFoo",
2708 srcs: ["foo/bar/MyClass.java"],
2709 sdk_version: "current",
2710 min_sdk_version: "29",
2711 system_modules: "none",
2712 stl: "none",
2713 static_libs: ["bar"],
2714 apex_available: [ "myapex" ],
2715 }
2716
2717 java_library {
2718 name: "bar",
2719 sdk_version: "current",
2720 srcs: ["a.java"],
2721 apex_available: [ "myapex" ],
2722 }
2723 `)
2724}
2725
2726func TestApexMinSdkVersion_OkayEvenWhenDepIsNewer_IfItSatisfiesApexMinSdkVersion(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002727 ctx := testApex(t, `
Jooyung Han749dc692020-04-15 11:03:39 +09002728 apex {
2729 name: "myapex",
2730 key: "myapex.key",
2731 native_shared_libs: ["mylib"],
2732 min_sdk_version: "29",
2733 }
2734
2735 apex_key {
2736 name: "myapex.key",
2737 public_key: "testkey.avbpubkey",
2738 private_key: "testkey.pem",
2739 }
2740
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002741 // mylib in myapex will link to mylib2#current
Jooyung Han749dc692020-04-15 11:03:39 +09002742 // mylib in otherapex will link to mylib2(non-stub) in otherapex as well
2743 cc_library {
2744 name: "mylib",
2745 srcs: ["mylib.cpp"],
2746 shared_libs: ["mylib2"],
2747 system_shared_libs: [],
2748 stl: "none",
2749 apex_available: ["myapex", "otherapex"],
2750 min_sdk_version: "29",
2751 }
2752
2753 cc_library {
2754 name: "mylib2",
2755 srcs: ["mylib.cpp"],
2756 system_shared_libs: [],
2757 stl: "none",
2758 apex_available: ["otherapex"],
2759 stubs: { versions: ["29", "30"] },
2760 min_sdk_version: "30",
2761 }
2762
2763 apex {
2764 name: "otherapex",
2765 key: "myapex.key",
2766 native_shared_libs: ["mylib", "mylib2"],
2767 min_sdk_version: "30",
2768 }
2769 `)
2770 expectLink := func(from, from_variant, to, to_variant string) {
2771 ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
2772 libFlags := ld.Args["libFlags"]
2773 ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
2774 }
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002775 expectLink("mylib", "shared_apex29", "mylib2", "shared_current")
Colin Crossaede88c2020-08-11 12:17:01 -07002776 expectLink("mylib", "shared_apex30", "mylib2", "shared_apex30")
Jooyung Han749dc692020-04-15 11:03:39 +09002777}
2778
Jooyung Haned124c32021-01-26 11:43:46 +09002779func TestApexMinSdkVersion_WorksWithSdkCodename(t *testing.T) {
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002780 withSAsActiveCodeNames := android.FixtureModifyProductVariables(
2781 func(variables android.FixtureProductVariables) {
2782 variables.Platform_sdk_codename = proptools.StringPtr("S")
2783 variables.Platform_version_active_codenames = []string{"S"}
2784 },
2785 )
Jooyung Haned124c32021-01-26 11:43:46 +09002786 testApexError(t, `libbar.*: should support min_sdk_version\(S\)`, `
2787 apex {
2788 name: "myapex",
2789 key: "myapex.key",
2790 native_shared_libs: ["libfoo"],
2791 min_sdk_version: "S",
2792 }
2793 apex_key {
2794 name: "myapex.key",
2795 public_key: "testkey.avbpubkey",
2796 private_key: "testkey.pem",
2797 }
2798 cc_library {
2799 name: "libfoo",
2800 shared_libs: ["libbar"],
2801 apex_available: ["myapex"],
2802 min_sdk_version: "29",
2803 }
2804 cc_library {
2805 name: "libbar",
2806 apex_available: ["myapex"],
2807 }
2808 `, withSAsActiveCodeNames)
2809}
2810
2811func TestApexMinSdkVersion_WorksWithActiveCodenames(t *testing.T) {
Paul Duffin0a49fdc2021-03-08 11:28:25 +00002812 withSAsActiveCodeNames := android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
2813 variables.Platform_sdk_codename = proptools.StringPtr("S")
2814 variables.Platform_version_active_codenames = []string{"S", "T"}
2815 })
Colin Cross1c460562021-02-16 17:55:47 -08002816 ctx := testApex(t, `
Jooyung Haned124c32021-01-26 11:43:46 +09002817 apex {
2818 name: "myapex",
2819 key: "myapex.key",
2820 native_shared_libs: ["libfoo"],
2821 min_sdk_version: "S",
2822 }
2823 apex_key {
2824 name: "myapex.key",
2825 public_key: "testkey.avbpubkey",
2826 private_key: "testkey.pem",
2827 }
2828 cc_library {
2829 name: "libfoo",
2830 shared_libs: ["libbar"],
2831 apex_available: ["myapex"],
2832 min_sdk_version: "S",
2833 }
2834 cc_library {
2835 name: "libbar",
2836 stubs: {
2837 symbol_file: "libbar.map.txt",
2838 versions: ["30", "S", "T"],
2839 },
2840 }
2841 `, withSAsActiveCodeNames)
2842
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002843 // ensure libfoo is linked with current version of libbar stub
Jooyung Haned124c32021-01-26 11:43:46 +09002844 libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_apex10000")
2845 libFlags := libfoo.Rule("ld").Args["libFlags"]
Jiyong Parkd4a3a132021-03-17 20:21:35 +09002846 ensureContains(t, libFlags, "android_arm64_armv8-a_shared_current/libbar.so")
Jooyung Haned124c32021-01-26 11:43:46 +09002847}
2848
Jiyong Park7c2ee712018-12-07 00:42:25 +09002849func TestFilesInSubDir(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002850 ctx := testApex(t, `
Jiyong Park7c2ee712018-12-07 00:42:25 +09002851 apex {
2852 name: "myapex",
2853 key: "myapex.key",
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002854 native_shared_libs: ["mylib"],
Jooyung Han4ed512b2023-08-11 16:30:04 +09002855 binaries: ["mybin", "mybin.rust"],
Jiyong Park7c2ee712018-12-07 00:42:25 +09002856 prebuilts: ["myetc"],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002857 compile_multilib: "both",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002858 updatable: false,
Jiyong Park7c2ee712018-12-07 00:42:25 +09002859 }
2860
2861 apex_key {
2862 name: "myapex.key",
2863 public_key: "testkey.avbpubkey",
2864 private_key: "testkey.pem",
2865 }
2866
2867 prebuilt_etc {
2868 name: "myetc",
2869 src: "myprebuilt",
2870 sub_dir: "foo/bar",
2871 }
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002872
2873 cc_library {
2874 name: "mylib",
2875 srcs: ["mylib.cpp"],
2876 relative_install_path: "foo/bar",
2877 system_shared_libs: [],
2878 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002879 apex_available: [ "myapex" ],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002880 }
2881
2882 cc_binary {
2883 name: "mybin",
2884 srcs: ["mylib.cpp"],
2885 relative_install_path: "foo/bar",
2886 system_shared_libs: [],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002887 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002888 apex_available: [ "myapex" ],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002889 }
Jooyung Han4ed512b2023-08-11 16:30:04 +09002890
2891 rust_binary {
2892 name: "mybin.rust",
2893 srcs: ["foo.rs"],
2894 relative_install_path: "rust_subdir",
2895 apex_available: [ "myapex" ],
2896 }
Jiyong Park7c2ee712018-12-07 00:42:25 +09002897 `)
2898
Jooyung Hana0503a52023-08-23 13:12:50 +09002899 generateFsRule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("generateFsConfig")
Jiyong Park1b0893e2021-12-13 23:40:17 +09002900 cmd := generateFsRule.RuleParams.Command
Jiyong Park7c2ee712018-12-07 00:42:25 +09002901
Jiyong Parkb7c24df2019-02-01 12:03:59 +09002902 // Ensure that the subdirectories are all listed
Jiyong Park1b0893e2021-12-13 23:40:17 +09002903 ensureContains(t, cmd, "/etc ")
2904 ensureContains(t, cmd, "/etc/foo ")
2905 ensureContains(t, cmd, "/etc/foo/bar ")
2906 ensureContains(t, cmd, "/lib64 ")
2907 ensureContains(t, cmd, "/lib64/foo ")
2908 ensureContains(t, cmd, "/lib64/foo/bar ")
2909 ensureContains(t, cmd, "/lib ")
2910 ensureContains(t, cmd, "/lib/foo ")
2911 ensureContains(t, cmd, "/lib/foo/bar ")
2912 ensureContains(t, cmd, "/bin ")
2913 ensureContains(t, cmd, "/bin/foo ")
2914 ensureContains(t, cmd, "/bin/foo/bar ")
Jooyung Han4ed512b2023-08-11 16:30:04 +09002915 ensureContains(t, cmd, "/bin/rust_subdir ")
Jiyong Park7c2ee712018-12-07 00:42:25 +09002916}
Jiyong Parkda6eb592018-12-19 17:12:36 +09002917
Jooyung Han35155c42020-02-06 17:33:20 +09002918func TestFilesInSubDirWhenNativeBridgeEnabled(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08002919 ctx := testApex(t, `
Jooyung Han35155c42020-02-06 17:33:20 +09002920 apex {
2921 name: "myapex",
2922 key: "myapex.key",
2923 multilib: {
2924 both: {
2925 native_shared_libs: ["mylib"],
2926 binaries: ["mybin"],
2927 },
2928 },
2929 compile_multilib: "both",
2930 native_bridge_supported: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002931 updatable: false,
Jooyung Han35155c42020-02-06 17:33:20 +09002932 }
2933
2934 apex_key {
2935 name: "myapex.key",
2936 public_key: "testkey.avbpubkey",
2937 private_key: "testkey.pem",
2938 }
2939
2940 cc_library {
2941 name: "mylib",
2942 relative_install_path: "foo/bar",
2943 system_shared_libs: [],
2944 stl: "none",
2945 apex_available: [ "myapex" ],
2946 native_bridge_supported: true,
2947 }
2948
2949 cc_binary {
2950 name: "mybin",
2951 relative_install_path: "foo/bar",
2952 system_shared_libs: [],
Jooyung Han35155c42020-02-06 17:33:20 +09002953 stl: "none",
2954 apex_available: [ "myapex" ],
2955 native_bridge_supported: true,
2956 compile_multilib: "both", // default is "first" for binary
2957 multilib: {
2958 lib64: {
2959 suffix: "64",
2960 },
2961 },
2962 }
2963 `, withNativeBridgeEnabled)
Jooyung Hana0503a52023-08-23 13:12:50 +09002964 ensureExactContents(t, ctx, "myapex", "android_common_myapex", []string{
Jooyung Han35155c42020-02-06 17:33:20 +09002965 "bin/foo/bar/mybin",
2966 "bin/foo/bar/mybin64",
2967 "bin/arm/foo/bar/mybin",
2968 "bin/arm64/foo/bar/mybin64",
2969 "lib/foo/bar/mylib.so",
2970 "lib/arm/foo/bar/mylib.so",
2971 "lib64/foo/bar/mylib.so",
2972 "lib64/arm64/foo/bar/mylib.so",
2973 })
2974}
2975
Jooyung Han85d61762020-06-24 23:50:26 +09002976func TestVendorApex(t *testing.T) {
Colin Crossc68db4b2021-11-11 18:59:15 -08002977 result := android.GroupFixturePreparers(
2978 prepareForApexTest,
2979 android.FixtureModifyConfig(android.SetKatiEnabledForTests),
2980 ).RunTestWithBp(t, `
Jooyung Han85d61762020-06-24 23:50:26 +09002981 apex {
2982 name: "myapex",
2983 key: "myapex.key",
2984 binaries: ["mybin"],
2985 vendor: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00002986 updatable: false,
Jooyung Han85d61762020-06-24 23:50:26 +09002987 }
2988 apex_key {
2989 name: "myapex.key",
2990 public_key: "testkey.avbpubkey",
2991 private_key: "testkey.pem",
2992 }
2993 cc_binary {
2994 name: "mybin",
2995 vendor: true,
2996 shared_libs: ["libfoo"],
2997 }
2998 cc_library {
2999 name: "libfoo",
3000 proprietary: true,
3001 }
3002 `)
3003
Jooyung Hana0503a52023-08-23 13:12:50 +09003004 ensureExactContents(t, result.TestContext, "myapex", "android_common_myapex", []string{
Jooyung Han85d61762020-06-24 23:50:26 +09003005 "bin/mybin",
3006 "lib64/libfoo.so",
3007 // TODO(b/159195575): Add an option to use VNDK libs from VNDK APEX
3008 "lib64/libc++.so",
3009 })
3010
Jooyung Hana0503a52023-08-23 13:12:50 +09003011 apexBundle := result.ModuleForTests("myapex", "android_common_myapex").Module().(*apexBundle)
Colin Crossc68db4b2021-11-11 18:59:15 -08003012 data := android.AndroidMkDataForTest(t, result.TestContext, apexBundle)
Jooyung Han85d61762020-06-24 23:50:26 +09003013 name := apexBundle.BaseModuleName()
3014 prefix := "TARGET_"
3015 var builder strings.Builder
3016 data.Custom(&builder, name, prefix, "", data)
Colin Crossc68db4b2021-11-11 18:59:15 -08003017 androidMk := android.StringRelativeToTop(result.Config, builder.String())
Paul Duffin37ba3442021-03-29 00:21:08 +01003018 installPath := "out/target/product/test_device/vendor/apex"
Lukacs T. Berki7690c092021-02-26 14:27:36 +01003019 ensureContains(t, androidMk, "LOCAL_MODULE_PATH := "+installPath)
Jooyung Han6c4cc9c2020-07-29 16:00:54 +09003020
Jooyung Hana0503a52023-08-23 13:12:50 +09003021 apexManifestRule := result.ModuleForTests("myapex", "android_common_myapex").Rule("apexManifestRule")
Jooyung Han6c4cc9c2020-07-29 16:00:54 +09003022 requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
3023 ensureListNotContains(t, requireNativeLibs, ":vndk")
Jooyung Han85d61762020-06-24 23:50:26 +09003024}
3025
Justin Yun13decfb2021-03-08 19:25:55 +09003026func TestProductVariant(t *testing.T) {
3027 ctx := testApex(t, `
3028 apex {
3029 name: "myapex",
3030 key: "myapex.key",
3031 updatable: false,
3032 product_specific: true,
3033 binaries: ["foo"],
3034 }
3035
3036 apex_key {
3037 name: "myapex.key",
3038 public_key: "testkey.avbpubkey",
3039 private_key: "testkey.pem",
3040 }
3041
3042 cc_binary {
3043 name: "foo",
3044 product_available: true,
3045 apex_available: ["myapex"],
3046 srcs: ["foo.cpp"],
3047 }
Justin Yunaf1fde42023-09-27 16:22:10 +09003048 `)
Justin Yun13decfb2021-03-08 19:25:55 +09003049
3050 cflags := strings.Fields(
Kiyoung Kim0d1c1e62024-03-26 16:33:58 +09003051 ctx.ModuleForTests("foo", "android_product_arm64_armv8-a_apex10000").Rule("cc").Args["cFlags"])
Justin Yun13decfb2021-03-08 19:25:55 +09003052 ensureListContains(t, cflags, "-D__ANDROID_VNDK__")
3053 ensureListContains(t, cflags, "-D__ANDROID_APEX__")
3054 ensureListContains(t, cflags, "-D__ANDROID_PRODUCT__")
3055 ensureListNotContains(t, cflags, "-D__ANDROID_VENDOR__")
3056}
3057
Jooyung Han8e5685d2020-09-21 11:02:57 +09003058func TestApex_withPrebuiltFirmware(t *testing.T) {
3059 testCases := []struct {
3060 name string
3061 additionalProp string
3062 }{
3063 {"system apex with prebuilt_firmware", ""},
3064 {"vendor apex with prebuilt_firmware", "vendor: true,"},
3065 }
3066 for _, tc := range testCases {
3067 t.Run(tc.name, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003068 ctx := testApex(t, `
Jooyung Han8e5685d2020-09-21 11:02:57 +09003069 apex {
3070 name: "myapex",
3071 key: "myapex.key",
3072 prebuilts: ["myfirmware"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003073 updatable: false,
Jooyung Han8e5685d2020-09-21 11:02:57 +09003074 `+tc.additionalProp+`
3075 }
3076 apex_key {
3077 name: "myapex.key",
3078 public_key: "testkey.avbpubkey",
3079 private_key: "testkey.pem",
3080 }
3081 prebuilt_firmware {
3082 name: "myfirmware",
3083 src: "myfirmware.bin",
3084 filename_from_src: true,
3085 `+tc.additionalProp+`
3086 }
3087 `)
Jooyung Hana0503a52023-08-23 13:12:50 +09003088 ensureExactContents(t, ctx, "myapex", "android_common_myapex", []string{
Jooyung Han8e5685d2020-09-21 11:02:57 +09003089 "etc/firmware/myfirmware.bin",
3090 })
3091 })
3092 }
Jooyung Han0703fd82020-08-26 22:11:53 +09003093}
3094
Jooyung Hanefb184e2020-06-25 17:14:25 +09003095func TestAndroidMk_VendorApexRequired(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003096 ctx := testApex(t, `
Jooyung Hanefb184e2020-06-25 17:14:25 +09003097 apex {
3098 name: "myapex",
3099 key: "myapex.key",
3100 vendor: true,
3101 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003102 updatable: false,
Jooyung Hanefb184e2020-06-25 17:14:25 +09003103 }
3104
3105 apex_key {
3106 name: "myapex.key",
3107 public_key: "testkey.avbpubkey",
3108 private_key: "testkey.pem",
3109 }
3110
3111 cc_library {
3112 name: "mylib",
3113 vendor_available: true,
3114 }
3115 `)
3116
Jooyung Hana0503a52023-08-23 13:12:50 +09003117 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07003118 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Hanefb184e2020-06-25 17:14:25 +09003119 name := apexBundle.BaseModuleName()
3120 prefix := "TARGET_"
3121 var builder strings.Builder
3122 data.Custom(&builder, name, prefix, "", data)
3123 androidMk := builder.String()
Jooyung Haneec1b3f2023-06-20 16:25:59 +09003124 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := libc++.vendor.myapex:64 mylib.vendor.myapex:64 libc.vendor libm.vendor libdl.vendor\n")
Jooyung Hanefb184e2020-06-25 17:14:25 +09003125}
3126
Jooyung Han2ed99d02020-06-24 23:26:26 +09003127func TestAndroidMkWritesCommonProperties(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003128 ctx := testApex(t, `
Jooyung Han2ed99d02020-06-24 23:26:26 +09003129 apex {
3130 name: "myapex",
3131 key: "myapex.key",
3132 vintf_fragments: ["fragment.xml"],
3133 init_rc: ["init.rc"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003134 updatable: false,
Jooyung Han2ed99d02020-06-24 23:26:26 +09003135 }
3136 apex_key {
3137 name: "myapex.key",
3138 public_key: "testkey.avbpubkey",
3139 private_key: "testkey.pem",
3140 }
3141 cc_binary {
3142 name: "mybin",
3143 }
3144 `)
3145
Jooyung Hana0503a52023-08-23 13:12:50 +09003146 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07003147 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jooyung Han2ed99d02020-06-24 23:26:26 +09003148 name := apexBundle.BaseModuleName()
3149 prefix := "TARGET_"
3150 var builder strings.Builder
3151 data.Custom(&builder, name, prefix, "", data)
3152 androidMk := builder.String()
Liz Kammer7b3dc8a2021-04-16 16:41:59 -04003153 ensureContains(t, androidMk, "LOCAL_FULL_VINTF_FRAGMENTS := fragment.xml\n")
Liz Kammer0c4f71c2021-04-06 10:35:10 -04003154 ensureContains(t, androidMk, "LOCAL_FULL_INIT_RC := init.rc\n")
Jooyung Han2ed99d02020-06-24 23:26:26 +09003155}
3156
Jiyong Park16e91a02018-12-20 18:18:08 +09003157func TestStaticLinking(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003158 ctx := testApex(t, `
Jiyong Park16e91a02018-12-20 18:18:08 +09003159 apex {
3160 name: "myapex",
3161 key: "myapex.key",
3162 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003163 updatable: false,
Jiyong Park16e91a02018-12-20 18:18:08 +09003164 }
3165
3166 apex_key {
3167 name: "myapex.key",
3168 public_key: "testkey.avbpubkey",
3169 private_key: "testkey.pem",
3170 }
3171
3172 cc_library {
3173 name: "mylib",
3174 srcs: ["mylib.cpp"],
3175 system_shared_libs: [],
3176 stl: "none",
3177 stubs: {
3178 versions: ["1", "2", "3"],
3179 },
Spandan Das20fce2d2023-04-12 17:21:39 +00003180 apex_available: ["myapex"],
Jiyong Park16e91a02018-12-20 18:18:08 +09003181 }
3182
3183 cc_binary {
3184 name: "not_in_apex",
3185 srcs: ["mylib.cpp"],
3186 static_libs: ["mylib"],
3187 static_executable: true,
3188 system_shared_libs: [],
3189 stl: "none",
3190 }
Jiyong Park16e91a02018-12-20 18:18:08 +09003191 `)
3192
Colin Cross7113d202019-11-20 16:39:12 -08003193 ldFlags := ctx.ModuleForTests("not_in_apex", "android_arm64_armv8-a").Rule("ld").Args["libFlags"]
Jiyong Park16e91a02018-12-20 18:18:08 +09003194
3195 // Ensure that not_in_apex is linking with the static variant of mylib
Colin Cross7113d202019-11-20 16:39:12 -08003196 ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_static/mylib.a")
Jiyong Park16e91a02018-12-20 18:18:08 +09003197}
Jiyong Park9335a262018-12-24 11:31:58 +09003198
3199func TestKeys(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003200 ctx := testApex(t, `
Jiyong Park9335a262018-12-24 11:31:58 +09003201 apex {
Jiyong Parkb2742fd2019-02-11 11:38:15 +09003202 name: "myapex_keytest",
Jiyong Park9335a262018-12-24 11:31:58 +09003203 key: "myapex.key",
Jiyong Parkb2742fd2019-02-11 11:38:15 +09003204 certificate: ":myapex.certificate",
Jiyong Park9335a262018-12-24 11:31:58 +09003205 native_shared_libs: ["mylib"],
Jooyung Han54aca7b2019-11-20 02:26:02 +09003206 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003207 updatable: false,
Jiyong Park9335a262018-12-24 11:31:58 +09003208 }
3209
3210 cc_library {
3211 name: "mylib",
3212 srcs: ["mylib.cpp"],
3213 system_shared_libs: [],
3214 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003215 apex_available: [ "myapex_keytest" ],
Jiyong Park9335a262018-12-24 11:31:58 +09003216 }
3217
3218 apex_key {
3219 name: "myapex.key",
3220 public_key: "testkey.avbpubkey",
3221 private_key: "testkey.pem",
3222 }
3223
Jiyong Parkb2742fd2019-02-11 11:38:15 +09003224 android_app_certificate {
3225 name: "myapex.certificate",
3226 certificate: "testkey",
3227 }
3228
3229 android_app_certificate {
3230 name: "myapex.certificate.override",
3231 certificate: "testkey.override",
3232 }
3233
Jiyong Park9335a262018-12-24 11:31:58 +09003234 `)
3235
3236 // check the APEX keys
Jiyong Parkd1e293d2019-03-15 02:13:21 +09003237 keys := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
Jiyong Park9335a262018-12-24 11:31:58 +09003238
Jaewoong Jung18aefc12020-12-21 09:11:10 -08003239 if keys.publicKeyFile.String() != "vendor/foo/devkeys/testkey.avbpubkey" {
3240 t.Errorf("public key %q is not %q", keys.publicKeyFile.String(),
Jiyong Park9335a262018-12-24 11:31:58 +09003241 "vendor/foo/devkeys/testkey.avbpubkey")
3242 }
Jaewoong Jung18aefc12020-12-21 09:11:10 -08003243 if keys.privateKeyFile.String() != "vendor/foo/devkeys/testkey.pem" {
3244 t.Errorf("private key %q is not %q", keys.privateKeyFile.String(),
Jiyong Park9335a262018-12-24 11:31:58 +09003245 "vendor/foo/devkeys/testkey.pem")
3246 }
3247
Jiyong Parkb2742fd2019-02-11 11:38:15 +09003248 // check the APK certs. It should be overridden to myapex.certificate.override
Jooyung Hana0503a52023-08-23 13:12:50 +09003249 certs := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest").Rule("signapk").Args["certificates"]
Jiyong Parkb2742fd2019-02-11 11:38:15 +09003250 if certs != "testkey.override.x509.pem testkey.override.pk8" {
Jiyong Park9335a262018-12-24 11:31:58 +09003251 t.Errorf("cert and private key %q are not %q", certs,
Jiyong Parkb2742fd2019-02-11 11:38:15 +09003252 "testkey.override.509.pem testkey.override.pk8")
Jiyong Park9335a262018-12-24 11:31:58 +09003253 }
3254}
Jiyong Park58e364a2019-01-19 19:24:06 +09003255
Jooyung Hanf121a652019-12-17 14:30:11 +09003256func TestCertificate(t *testing.T) {
3257 t.Run("if unspecified, it defaults to DefaultAppCertificate", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003258 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003259 apex {
3260 name: "myapex",
3261 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003262 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003263 }
3264 apex_key {
3265 name: "myapex.key",
3266 public_key: "testkey.avbpubkey",
3267 private_key: "testkey.pem",
3268 }`)
Jooyung Hana0503a52023-08-23 13:12:50 +09003269 rule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("signapk")
Jooyung Hanf121a652019-12-17 14:30:11 +09003270 expected := "vendor/foo/devkeys/test.x509.pem vendor/foo/devkeys/test.pk8"
3271 if actual := rule.Args["certificates"]; actual != expected {
3272 t.Errorf("certificates should be %q, not %q", expected, actual)
3273 }
3274 })
3275 t.Run("override when unspecified", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003276 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003277 apex {
3278 name: "myapex_keytest",
3279 key: "myapex.key",
3280 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003281 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003282 }
3283 apex_key {
3284 name: "myapex.key",
3285 public_key: "testkey.avbpubkey",
3286 private_key: "testkey.pem",
3287 }
3288 android_app_certificate {
3289 name: "myapex.certificate.override",
3290 certificate: "testkey.override",
3291 }`)
Jooyung Hana0503a52023-08-23 13:12:50 +09003292 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest").Rule("signapk")
Jooyung Hanf121a652019-12-17 14:30:11 +09003293 expected := "testkey.override.x509.pem testkey.override.pk8"
3294 if actual := rule.Args["certificates"]; actual != expected {
3295 t.Errorf("certificates should be %q, not %q", expected, actual)
3296 }
3297 })
3298 t.Run("if specified as :module, it respects the prop", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003299 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003300 apex {
3301 name: "myapex",
3302 key: "myapex.key",
3303 certificate: ":myapex.certificate",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003304 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003305 }
3306 apex_key {
3307 name: "myapex.key",
3308 public_key: "testkey.avbpubkey",
3309 private_key: "testkey.pem",
3310 }
3311 android_app_certificate {
3312 name: "myapex.certificate",
3313 certificate: "testkey",
3314 }`)
Jooyung Hana0503a52023-08-23 13:12:50 +09003315 rule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("signapk")
Jooyung Hanf121a652019-12-17 14:30:11 +09003316 expected := "testkey.x509.pem testkey.pk8"
3317 if actual := rule.Args["certificates"]; actual != expected {
3318 t.Errorf("certificates should be %q, not %q", expected, actual)
3319 }
3320 })
3321 t.Run("override when specifiec as <:module>", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003322 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003323 apex {
3324 name: "myapex_keytest",
3325 key: "myapex.key",
3326 file_contexts: ":myapex-file_contexts",
3327 certificate: ":myapex.certificate",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003328 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003329 }
3330 apex_key {
3331 name: "myapex.key",
3332 public_key: "testkey.avbpubkey",
3333 private_key: "testkey.pem",
3334 }
3335 android_app_certificate {
3336 name: "myapex.certificate.override",
3337 certificate: "testkey.override",
3338 }`)
Jooyung Hana0503a52023-08-23 13:12:50 +09003339 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest").Rule("signapk")
Jooyung Hanf121a652019-12-17 14:30:11 +09003340 expected := "testkey.override.x509.pem testkey.override.pk8"
3341 if actual := rule.Args["certificates"]; actual != expected {
3342 t.Errorf("certificates should be %q, not %q", expected, actual)
3343 }
3344 })
3345 t.Run("if specified as name, finds it from DefaultDevKeyDir", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003346 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003347 apex {
3348 name: "myapex",
3349 key: "myapex.key",
3350 certificate: "testkey",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003351 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003352 }
3353 apex_key {
3354 name: "myapex.key",
3355 public_key: "testkey.avbpubkey",
3356 private_key: "testkey.pem",
3357 }`)
Jooyung Hana0503a52023-08-23 13:12:50 +09003358 rule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("signapk")
Jooyung Hanf121a652019-12-17 14:30:11 +09003359 expected := "vendor/foo/devkeys/testkey.x509.pem vendor/foo/devkeys/testkey.pk8"
3360 if actual := rule.Args["certificates"]; actual != expected {
3361 t.Errorf("certificates should be %q, not %q", expected, actual)
3362 }
3363 })
3364 t.Run("override when specified as <name>", func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003365 ctx := testApex(t, `
Jooyung Hanf121a652019-12-17 14:30:11 +09003366 apex {
3367 name: "myapex_keytest",
3368 key: "myapex.key",
3369 file_contexts: ":myapex-file_contexts",
3370 certificate: "testkey",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003371 updatable: false,
Jooyung Hanf121a652019-12-17 14:30:11 +09003372 }
3373 apex_key {
3374 name: "myapex.key",
3375 public_key: "testkey.avbpubkey",
3376 private_key: "testkey.pem",
3377 }
3378 android_app_certificate {
3379 name: "myapex.certificate.override",
3380 certificate: "testkey.override",
3381 }`)
Jooyung Hana0503a52023-08-23 13:12:50 +09003382 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest").Rule("signapk")
Jooyung Hanf121a652019-12-17 14:30:11 +09003383 expected := "testkey.override.x509.pem testkey.override.pk8"
3384 if actual := rule.Args["certificates"]; actual != expected {
3385 t.Errorf("certificates should be %q, not %q", expected, actual)
3386 }
3387 })
3388}
3389
Jiyong Park58e364a2019-01-19 19:24:06 +09003390func TestMacro(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003391 ctx := testApex(t, `
Jiyong Park58e364a2019-01-19 19:24:06 +09003392 apex {
3393 name: "myapex",
3394 key: "myapex.key",
Jooyung Hanc87a0592020-03-02 17:44:33 +09003395 native_shared_libs: ["mylib", "mylib2"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003396 updatable: false,
Jiyong Park58e364a2019-01-19 19:24:06 +09003397 }
3398
3399 apex {
3400 name: "otherapex",
3401 key: "myapex.key",
Jooyung Hanc87a0592020-03-02 17:44:33 +09003402 native_shared_libs: ["mylib", "mylib2"],
Jooyung Hanccce2f22020-03-07 03:45:53 +09003403 min_sdk_version: "29",
Jiyong Park58e364a2019-01-19 19:24:06 +09003404 }
3405
3406 apex_key {
3407 name: "myapex.key",
3408 public_key: "testkey.avbpubkey",
3409 private_key: "testkey.pem",
3410 }
3411
3412 cc_library {
3413 name: "mylib",
3414 srcs: ["mylib.cpp"],
3415 system_shared_libs: [],
3416 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003417 apex_available: [
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003418 "myapex",
3419 "otherapex",
3420 ],
Jooyung Han24282772020-03-21 23:20:55 +09003421 recovery_available: true,
Jooyung Han749dc692020-04-15 11:03:39 +09003422 min_sdk_version: "29",
Jiyong Park58e364a2019-01-19 19:24:06 +09003423 }
Jooyung Hanc87a0592020-03-02 17:44:33 +09003424 cc_library {
3425 name: "mylib2",
3426 srcs: ["mylib.cpp"],
3427 system_shared_libs: [],
3428 stl: "none",
3429 apex_available: [
3430 "myapex",
3431 "otherapex",
3432 ],
Colin Crossaede88c2020-08-11 12:17:01 -07003433 static_libs: ["mylib3"],
3434 recovery_available: true,
3435 min_sdk_version: "29",
3436 }
3437 cc_library {
3438 name: "mylib3",
3439 srcs: ["mylib.cpp"],
3440 system_shared_libs: [],
3441 stl: "none",
3442 apex_available: [
3443 "myapex",
3444 "otherapex",
3445 ],
Colin Crossaede88c2020-08-11 12:17:01 -07003446 recovery_available: true,
Jooyung Han749dc692020-04-15 11:03:39 +09003447 min_sdk_version: "29",
Jooyung Hanc87a0592020-03-02 17:44:33 +09003448 }
Jiyong Park58e364a2019-01-19 19:24:06 +09003449 `)
3450
Jooyung Hanc87a0592020-03-02 17:44:33 +09003451 // non-APEX variant does not have __ANDROID_APEX__ defined
Colin Cross7113d202019-11-20 16:39:12 -08003452 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09003453 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Hanc87a0592020-03-02 17:44:33 +09003454
Vinh Tranf9754732023-01-19 22:41:46 -05003455 // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX__ defined
Colin Crossaede88c2020-08-11 12:17:01 -07003456 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
Jooyung Hanc87a0592020-03-02 17:44:33 +09003457 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Hanc87a0592020-03-02 17:44:33 +09003458
Vinh Tranf9754732023-01-19 22:41:46 -05003459 // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX__ defined
Colin Crossaede88c2020-08-11 12:17:01 -07003460 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex29").Rule("cc").Args["cFlags"]
Jooyung Hanc87a0592020-03-02 17:44:33 +09003461 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09003462
Colin Crossaede88c2020-08-11 12:17:01 -07003463 // When a cc_library sets use_apex_name_macro: true each apex gets a unique variant and
3464 // each variant defines additional macros to distinguish which apex variant it is built for
3465
3466 // non-APEX variant does not have __ANDROID_APEX__ defined
3467 mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
3468 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3469
Vinh Tranf9754732023-01-19 22:41:46 -05003470 // recovery variant does not set __ANDROID_APEX__
Colin Crossaede88c2020-08-11 12:17:01 -07003471 mylibCFlags = ctx.ModuleForTests("mylib3", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
3472 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Colin Crossaede88c2020-08-11 12:17:01 -07003473
Jooyung Hanc87a0592020-03-02 17:44:33 +09003474 // non-APEX variant does not have __ANDROID_APEX__ defined
3475 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
3476 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
3477
Vinh Tranf9754732023-01-19 22:41:46 -05003478 // recovery variant does not set __ANDROID_APEX__
Colin Crossaede88c2020-08-11 12:17:01 -07003479 mylibCFlags = ctx.ModuleForTests("mylib2", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jooyung Han24282772020-03-21 23:20:55 +09003480 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09003481}
Jiyong Park7e636d02019-01-28 16:16:54 +09003482
3483func TestHeaderLibsDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003484 ctx := testApex(t, `
Jiyong Park7e636d02019-01-28 16:16:54 +09003485 apex {
3486 name: "myapex",
3487 key: "myapex.key",
3488 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003489 updatable: false,
Jiyong Park7e636d02019-01-28 16:16:54 +09003490 }
3491
3492 apex_key {
3493 name: "myapex.key",
3494 public_key: "testkey.avbpubkey",
3495 private_key: "testkey.pem",
3496 }
3497
3498 cc_library_headers {
3499 name: "mylib_headers",
3500 export_include_dirs: ["my_include"],
3501 system_shared_libs: [],
3502 stl: "none",
Jiyong Park0f80c182020-01-31 02:49:53 +09003503 apex_available: [ "myapex" ],
Jiyong Park7e636d02019-01-28 16:16:54 +09003504 }
3505
3506 cc_library {
3507 name: "mylib",
3508 srcs: ["mylib.cpp"],
3509 system_shared_libs: [],
3510 stl: "none",
3511 header_libs: ["mylib_headers"],
3512 export_header_lib_headers: ["mylib_headers"],
3513 stubs: {
3514 versions: ["1", "2", "3"],
3515 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003516 apex_available: [ "myapex" ],
Jiyong Park7e636d02019-01-28 16:16:54 +09003517 }
3518
3519 cc_library {
3520 name: "otherlib",
3521 srcs: ["mylib.cpp"],
3522 system_shared_libs: [],
3523 stl: "none",
3524 shared_libs: ["mylib"],
3525 }
3526 `)
3527
Colin Cross7113d202019-11-20 16:39:12 -08003528 cFlags := ctx.ModuleForTests("otherlib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jiyong Park7e636d02019-01-28 16:16:54 +09003529
3530 // Ensure that the include path of the header lib is exported to 'otherlib'
3531 ensureContains(t, cFlags, "-Imy_include")
3532}
Alex Light9670d332019-01-29 18:07:33 -08003533
Jiyong Park7cd10e32020-01-14 09:22:18 +09003534type fileInApex struct {
3535 path string // path in apex
Jooyung Hana57af4a2020-01-23 05:36:59 +00003536 src string // src path
Jiyong Park7cd10e32020-01-14 09:22:18 +09003537 isLink bool
3538}
3539
Jooyung Han1724d582022-12-21 10:17:44 +09003540func (f fileInApex) String() string {
3541 return f.src + ":" + f.path
3542}
3543
3544func (f fileInApex) match(expectation string) bool {
3545 parts := strings.Split(expectation, ":")
3546 if len(parts) == 1 {
3547 match, _ := path.Match(parts[0], f.path)
3548 return match
3549 }
3550 if len(parts) == 2 {
3551 matchSrc, _ := path.Match(parts[0], f.src)
3552 matchDst, _ := path.Match(parts[1], f.path)
3553 return matchSrc && matchDst
3554 }
3555 panic("invalid expected file specification: " + expectation)
3556}
3557
Jooyung Hana57af4a2020-01-23 05:36:59 +00003558func getFiles(t *testing.T, ctx *android.TestContext, moduleName, variant string) []fileInApex {
Jooyung Han31c470b2019-10-18 16:26:59 +09003559 t.Helper()
Jooyung Han1724d582022-12-21 10:17:44 +09003560 module := ctx.ModuleForTests(moduleName, variant)
3561 apexRule := module.MaybeRule("apexRule")
3562 apexDir := "/image.apex/"
Jooyung Han31c470b2019-10-18 16:26:59 +09003563 copyCmds := apexRule.Args["copy_commands"]
Jiyong Park7cd10e32020-01-14 09:22:18 +09003564 var ret []fileInApex
Jooyung Han31c470b2019-10-18 16:26:59 +09003565 for _, cmd := range strings.Split(copyCmds, "&&") {
3566 cmd = strings.TrimSpace(cmd)
3567 if cmd == "" {
3568 continue
3569 }
3570 terms := strings.Split(cmd, " ")
Jooyung Hana57af4a2020-01-23 05:36:59 +00003571 var dst, src string
Jiyong Park7cd10e32020-01-14 09:22:18 +09003572 var isLink bool
Jooyung Han31c470b2019-10-18 16:26:59 +09003573 switch terms[0] {
3574 case "mkdir":
3575 case "cp":
Jiyong Park7cd10e32020-01-14 09:22:18 +09003576 if len(terms) != 3 && len(terms) != 4 {
Jooyung Han31c470b2019-10-18 16:26:59 +09003577 t.Fatal("copyCmds contains invalid cp command", cmd)
3578 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09003579 dst = terms[len(terms)-1]
Jooyung Hana57af4a2020-01-23 05:36:59 +00003580 src = terms[len(terms)-2]
Jiyong Park7cd10e32020-01-14 09:22:18 +09003581 isLink = false
3582 case "ln":
3583 if len(terms) != 3 && len(terms) != 4 {
3584 // ln LINK TARGET or ln -s LINK TARGET
3585 t.Fatal("copyCmds contains invalid ln command", cmd)
3586 }
3587 dst = terms[len(terms)-1]
Jooyung Hana57af4a2020-01-23 05:36:59 +00003588 src = terms[len(terms)-2]
Jiyong Park7cd10e32020-01-14 09:22:18 +09003589 isLink = true
3590 default:
3591 t.Fatalf("copyCmds should contain mkdir/cp commands only: %q", cmd)
3592 }
3593 if dst != "" {
Jooyung Han1724d582022-12-21 10:17:44 +09003594 index := strings.Index(dst, apexDir)
Jooyung Han31c470b2019-10-18 16:26:59 +09003595 if index == -1 {
Jooyung Han1724d582022-12-21 10:17:44 +09003596 t.Fatal("copyCmds should copy a file to "+apexDir, cmd)
Jooyung Han31c470b2019-10-18 16:26:59 +09003597 }
Jooyung Han1724d582022-12-21 10:17:44 +09003598 dstFile := dst[index+len(apexDir):]
Jooyung Hana57af4a2020-01-23 05:36:59 +00003599 ret = append(ret, fileInApex{path: dstFile, src: src, isLink: isLink})
Jooyung Han31c470b2019-10-18 16:26:59 +09003600 }
3601 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09003602 return ret
3603}
3604
Jiakai Zhangebf48bf2023-02-10 01:51:53 +08003605func assertFileListEquals(t *testing.T, expectedFiles []string, actualFiles []fileInApex) {
Jooyung Hana57af4a2020-01-23 05:36:59 +00003606 t.Helper()
Jiyong Park7cd10e32020-01-14 09:22:18 +09003607 var failed bool
3608 var surplus []string
3609 filesMatched := make(map[string]bool)
Jiakai Zhangebf48bf2023-02-10 01:51:53 +08003610 for _, file := range actualFiles {
Jooyung Han1724d582022-12-21 10:17:44 +09003611 matchFound := false
Jiakai Zhangebf48bf2023-02-10 01:51:53 +08003612 for _, expected := range expectedFiles {
Jooyung Han1724d582022-12-21 10:17:44 +09003613 if file.match(expected) {
3614 matchFound = true
Jiyong Park7cd10e32020-01-14 09:22:18 +09003615 filesMatched[expected] = true
Jooyung Hane6436d72020-02-27 13:31:56 +09003616 break
Jiyong Park7cd10e32020-01-14 09:22:18 +09003617 }
3618 }
Jooyung Han1724d582022-12-21 10:17:44 +09003619 if !matchFound {
3620 surplus = append(surplus, file.String())
Jooyung Hane6436d72020-02-27 13:31:56 +09003621 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09003622 }
Jooyung Han31c470b2019-10-18 16:26:59 +09003623
Jooyung Han31c470b2019-10-18 16:26:59 +09003624 if len(surplus) > 0 {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003625 sort.Strings(surplus)
Jooyung Han31c470b2019-10-18 16:26:59 +09003626 t.Log("surplus files", surplus)
3627 failed = true
3628 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003629
Jiakai Zhangebf48bf2023-02-10 01:51:53 +08003630 if len(expectedFiles) > len(filesMatched) {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003631 var missing []string
Jiakai Zhangebf48bf2023-02-10 01:51:53 +08003632 for _, expected := range expectedFiles {
Jooyung Han39edb6c2019-11-06 16:53:07 +09003633 if !filesMatched[expected] {
3634 missing = append(missing, expected)
3635 }
3636 }
3637 sort.Strings(missing)
Jooyung Han31c470b2019-10-18 16:26:59 +09003638 t.Log("missing files", missing)
3639 failed = true
3640 }
3641 if failed {
3642 t.Fail()
3643 }
3644}
3645
Jiakai Zhangebf48bf2023-02-10 01:51:53 +08003646func ensureExactContents(t *testing.T, ctx *android.TestContext, moduleName, variant string, files []string) {
3647 assertFileListEquals(t, files, getFiles(t, ctx, moduleName, variant))
3648}
3649
3650func ensureExactDeapexedContents(t *testing.T, ctx *android.TestContext, moduleName string, variant string, files []string) {
Spandan Das2069c3f2023-12-06 19:40:24 +00003651 deapexer := ctx.ModuleForTests(moduleName+".deapexer", variant).Description("deapex")
Jiakai Zhangebf48bf2023-02-10 01:51:53 +08003652 outputs := make([]string, 0, len(deapexer.ImplicitOutputs)+1)
3653 if deapexer.Output != nil {
3654 outputs = append(outputs, deapexer.Output.String())
3655 }
3656 for _, output := range deapexer.ImplicitOutputs {
3657 outputs = append(outputs, output.String())
3658 }
3659 actualFiles := make([]fileInApex, 0, len(outputs))
3660 for _, output := range outputs {
3661 dir := "/deapexer/"
3662 pos := strings.LastIndex(output, dir)
3663 if pos == -1 {
3664 t.Fatal("Unknown deapexer output ", output)
3665 }
3666 path := output[pos+len(dir):]
3667 actualFiles = append(actualFiles, fileInApex{path: path, src: "", isLink: false})
3668 }
3669 assertFileListEquals(t, files, actualFiles)
3670}
3671
Jooyung Han39edb6c2019-11-06 16:53:07 +09003672func vndkLibrariesTxtFiles(vers ...string) (result string) {
3673 for _, v := range vers {
Kiyoung Kim973cb6f2024-04-29 14:14:53 +09003674 for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
Justin Yund5784122023-10-25 13:25:32 +09003675 result += `
Jooyung Han39edb6c2019-11-06 16:53:07 +09003676 prebuilt_etc {
3677 name: "` + txt + `.libraries.` + v + `.txt",
3678 src: "dummy.txt",
3679 }
3680 `
Jooyung Han39edb6c2019-11-06 16:53:07 +09003681 }
3682 }
3683 return
3684}
3685
Jooyung Han344d5432019-08-23 11:17:39 +09003686func TestVndkApexVersion(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003687 ctx := testApex(t, `
Jooyung Han344d5432019-08-23 11:17:39 +09003688 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003689 name: "com.android.vndk.v27",
Jooyung Han344d5432019-08-23 11:17:39 +09003690 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003691 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09003692 vndk_version: "27",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003693 updatable: false,
Jooyung Han344d5432019-08-23 11:17:39 +09003694 }
3695
3696 apex_key {
3697 name: "myapex.key",
3698 public_key: "testkey.avbpubkey",
3699 private_key: "testkey.pem",
3700 }
3701
Jooyung Han31c470b2019-10-18 16:26:59 +09003702 vndk_prebuilt_shared {
3703 name: "libvndk27",
3704 version: "27",
Jooyung Han344d5432019-08-23 11:17:39 +09003705 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003706 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003707 vndk: {
3708 enabled: true,
3709 },
Jooyung Han31c470b2019-10-18 16:26:59 +09003710 target_arch: "arm64",
3711 arch: {
3712 arm: {
3713 srcs: ["libvndk27_arm.so"],
3714 },
3715 arm64: {
3716 srcs: ["libvndk27_arm64.so"],
3717 },
3718 },
Colin Cross2807f002021-03-02 10:15:29 -08003719 apex_available: [ "com.android.vndk.v27" ],
Jooyung Han344d5432019-08-23 11:17:39 +09003720 }
3721
3722 vndk_prebuilt_shared {
3723 name: "libvndk27",
3724 version: "27",
3725 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003726 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003727 vndk: {
3728 enabled: true,
3729 },
Jooyung Han31c470b2019-10-18 16:26:59 +09003730 target_arch: "x86_64",
3731 arch: {
3732 x86: {
3733 srcs: ["libvndk27_x86.so"],
3734 },
3735 x86_64: {
3736 srcs: ["libvndk27_x86_64.so"],
3737 },
3738 },
Jooyung Han39edb6c2019-11-06 16:53:07 +09003739 }
3740 `+vndkLibrariesTxtFiles("27"),
3741 withFiles(map[string][]byte{
3742 "libvndk27_arm.so": nil,
3743 "libvndk27_arm64.so": nil,
3744 "libvndk27_x86.so": nil,
3745 "libvndk27_x86_64.so": nil,
3746 }))
Jooyung Han344d5432019-08-23 11:17:39 +09003747
Jooyung Hana0503a52023-08-23 13:12:50 +09003748 ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003749 "lib/libvndk27_arm.so",
3750 "lib64/libvndk27_arm64.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003751 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003752 })
Jooyung Han344d5432019-08-23 11:17:39 +09003753}
3754
Jooyung Han90eee022019-10-01 20:02:42 +09003755func TestVndkApexNameRule(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003756 ctx := testApex(t, `
Jooyung Han90eee022019-10-01 20:02:42 +09003757 apex_vndk {
Kiyoung Kim0d1c1e62024-03-26 16:33:58 +09003758 name: "com.android.vndk.v29",
Jooyung Han90eee022019-10-01 20:02:42 +09003759 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003760 file_contexts: ":myapex-file_contexts",
Kiyoung Kim0d1c1e62024-03-26 16:33:58 +09003761 vndk_version: "29",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003762 updatable: false,
Jooyung Han90eee022019-10-01 20:02:42 +09003763 }
3764 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003765 name: "com.android.vndk.v28",
Jooyung Han90eee022019-10-01 20:02:42 +09003766 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003767 file_contexts: ":myapex-file_contexts",
Jooyung Han90eee022019-10-01 20:02:42 +09003768 vndk_version: "28",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003769 updatable: false,
Jooyung Han90eee022019-10-01 20:02:42 +09003770 }
3771 apex_key {
3772 name: "myapex.key",
3773 public_key: "testkey.avbpubkey",
3774 private_key: "testkey.pem",
Kiyoung Kim0d1c1e62024-03-26 16:33:58 +09003775 }`+vndkLibrariesTxtFiles("28", "29"))
Jooyung Han90eee022019-10-01 20:02:42 +09003776
3777 assertApexName := func(expected, moduleName string) {
Jooyung Hana0503a52023-08-23 13:12:50 +09003778 module := ctx.ModuleForTests(moduleName, "android_common")
Jooyung Han2cd2f9a2023-02-06 18:29:08 +09003779 apexManifestRule := module.Rule("apexManifestRule")
3780 ensureContains(t, apexManifestRule.Args["opt"], "-v name "+expected)
Jooyung Han90eee022019-10-01 20:02:42 +09003781 }
3782
Kiyoung Kim0d1c1e62024-03-26 16:33:58 +09003783 assertApexName("com.android.vndk.v29", "com.android.vndk.v29")
Colin Cross2807f002021-03-02 10:15:29 -08003784 assertApexName("com.android.vndk.v28", "com.android.vndk.v28")
Jooyung Han90eee022019-10-01 20:02:42 +09003785}
3786
Jooyung Han344d5432019-08-23 11:17:39 +09003787func TestVndkApexDoesntSupportNativeBridgeSupported(t *testing.T) {
Colin Cross2807f002021-03-02 10:15:29 -08003788 testApexError(t, `module "com.android.vndk.current" .*: native_bridge_supported: .* doesn't support native bridge binary`, `
Jooyung Han344d5432019-08-23 11:17:39 +09003789 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003790 name: "com.android.vndk.current",
3791 key: "com.android.vndk.current.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003792 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09003793 native_bridge_supported: true,
3794 }
3795
3796 apex_key {
Colin Cross2807f002021-03-02 10:15:29 -08003797 name: "com.android.vndk.current.key",
Jooyung Han344d5432019-08-23 11:17:39 +09003798 public_key: "testkey.avbpubkey",
3799 private_key: "testkey.pem",
3800 }
3801
3802 cc_library {
3803 name: "libvndk",
3804 srcs: ["mylib.cpp"],
3805 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003806 product_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +09003807 native_bridge_supported: true,
3808 host_supported: true,
3809 vndk: {
3810 enabled: true,
3811 },
3812 system_shared_libs: [],
3813 stl: "none",
3814 }
3815 `)
3816}
3817
Jooyung Han31c470b2019-10-18 16:26:59 +09003818func TestVndkApexWithBinder32(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003819 ctx := testApex(t, `
Jooyung Han31c470b2019-10-18 16:26:59 +09003820 apex_vndk {
Colin Cross2807f002021-03-02 10:15:29 -08003821 name: "com.android.vndk.v27",
Jooyung Han31c470b2019-10-18 16:26:59 +09003822 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003823 file_contexts: ":myapex-file_contexts",
Jooyung Han31c470b2019-10-18 16:26:59 +09003824 vndk_version: "27",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003825 updatable: false,
Jooyung Han31c470b2019-10-18 16:26:59 +09003826 }
3827
3828 apex_key {
3829 name: "myapex.key",
3830 public_key: "testkey.avbpubkey",
3831 private_key: "testkey.pem",
3832 }
3833
3834 vndk_prebuilt_shared {
3835 name: "libvndk27",
3836 version: "27",
3837 target_arch: "arm",
3838 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003839 product_available: true,
Jooyung Han31c470b2019-10-18 16:26:59 +09003840 vndk: {
3841 enabled: true,
3842 },
3843 arch: {
3844 arm: {
3845 srcs: ["libvndk27.so"],
3846 }
3847 },
3848 }
3849
3850 vndk_prebuilt_shared {
3851 name: "libvndk27",
3852 version: "27",
3853 target_arch: "arm",
3854 binder32bit: true,
3855 vendor_available: true,
Justin Yun63e9ec72020-10-29 16:49:43 +09003856 product_available: true,
Jooyung Han31c470b2019-10-18 16:26:59 +09003857 vndk: {
3858 enabled: true,
3859 },
3860 arch: {
3861 arm: {
3862 srcs: ["libvndk27binder32.so"],
3863 }
3864 },
Colin Cross2807f002021-03-02 10:15:29 -08003865 apex_available: [ "com.android.vndk.v27" ],
Jooyung Han31c470b2019-10-18 16:26:59 +09003866 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09003867 `+vndkLibrariesTxtFiles("27"),
Jooyung Han31c470b2019-10-18 16:26:59 +09003868 withFiles(map[string][]byte{
3869 "libvndk27.so": nil,
3870 "libvndk27binder32.so": nil,
3871 }),
3872 withBinder32bit,
3873 withTargets(map[android.OsType][]android.Target{
Wei Li340ee8e2022-03-18 17:33:24 -07003874 android.Android: {
Jooyung Han35155c42020-02-06 17:33:20 +09003875 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
3876 NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
Jooyung Han31c470b2019-10-18 16:26:59 +09003877 },
3878 }),
3879 )
3880
Jooyung Hana0503a52023-08-23 13:12:50 +09003881 ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09003882 "lib/libvndk27binder32.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09003883 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09003884 })
3885}
3886
Jooyung Hane1633032019-08-01 17:41:43 +09003887func TestDependenciesInApexManifest(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08003888 ctx := testApex(t, `
Jooyung Hane1633032019-08-01 17:41:43 +09003889 apex {
3890 name: "myapex_nodep",
3891 key: "myapex.key",
3892 native_shared_libs: ["lib_nodep"],
3893 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003894 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003895 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003896 }
3897
3898 apex {
3899 name: "myapex_dep",
3900 key: "myapex.key",
3901 native_shared_libs: ["lib_dep"],
3902 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003903 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003904 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003905 }
3906
3907 apex {
3908 name: "myapex_provider",
3909 key: "myapex.key",
3910 native_shared_libs: ["libfoo"],
3911 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003912 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003913 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003914 }
3915
3916 apex {
3917 name: "myapex_selfcontained",
3918 key: "myapex.key",
Spandan Das20fce2d2023-04-12 17:21:39 +00003919 native_shared_libs: ["lib_dep_on_bar", "libbar"],
Jooyung Hane1633032019-08-01 17:41:43 +09003920 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09003921 file_contexts: ":myapex-file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00003922 updatable: false,
Jooyung Hane1633032019-08-01 17:41:43 +09003923 }
3924
3925 apex_key {
3926 name: "myapex.key",
3927 public_key: "testkey.avbpubkey",
3928 private_key: "testkey.pem",
3929 }
3930
3931 cc_library {
3932 name: "lib_nodep",
3933 srcs: ["mylib.cpp"],
3934 system_shared_libs: [],
3935 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003936 apex_available: [ "myapex_nodep" ],
Jooyung Hane1633032019-08-01 17:41:43 +09003937 }
3938
3939 cc_library {
3940 name: "lib_dep",
3941 srcs: ["mylib.cpp"],
3942 shared_libs: ["libfoo"],
3943 system_shared_libs: [],
3944 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003945 apex_available: [
3946 "myapex_dep",
3947 "myapex_provider",
3948 "myapex_selfcontained",
3949 ],
Jooyung Hane1633032019-08-01 17:41:43 +09003950 }
3951
3952 cc_library {
Spandan Das20fce2d2023-04-12 17:21:39 +00003953 name: "lib_dep_on_bar",
3954 srcs: ["mylib.cpp"],
3955 shared_libs: ["libbar"],
3956 system_shared_libs: [],
3957 stl: "none",
3958 apex_available: [
3959 "myapex_selfcontained",
3960 ],
3961 }
3962
3963
3964 cc_library {
Jooyung Hane1633032019-08-01 17:41:43 +09003965 name: "libfoo",
3966 srcs: ["mytest.cpp"],
3967 stubs: {
3968 versions: ["1"],
3969 },
3970 system_shared_libs: [],
3971 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003972 apex_available: [
3973 "myapex_provider",
Spandan Das20fce2d2023-04-12 17:21:39 +00003974 ],
3975 }
3976
3977 cc_library {
3978 name: "libbar",
3979 srcs: ["mytest.cpp"],
3980 stubs: {
3981 versions: ["1"],
3982 },
3983 system_shared_libs: [],
3984 stl: "none",
3985 apex_available: [
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003986 "myapex_selfcontained",
3987 ],
Jooyung Hane1633032019-08-01 17:41:43 +09003988 }
Spandan Das20fce2d2023-04-12 17:21:39 +00003989
Jooyung Hane1633032019-08-01 17:41:43 +09003990 `)
3991
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003992 var apexManifestRule android.TestingBuildParams
Jooyung Hane1633032019-08-01 17:41:43 +09003993 var provideNativeLibs, requireNativeLibs []string
3994
Jooyung Hana0503a52023-08-23 13:12:50 +09003995 apexManifestRule = ctx.ModuleForTests("myapex_nodep", "android_common_myapex_nodep").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09003996 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
3997 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09003998 ensureListEmpty(t, provideNativeLibs)
3999 ensureListEmpty(t, requireNativeLibs)
4000
Jooyung Hana0503a52023-08-23 13:12:50 +09004001 apexManifestRule = ctx.ModuleForTests("myapex_dep", "android_common_myapex_dep").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09004002 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
4003 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09004004 ensureListEmpty(t, provideNativeLibs)
4005 ensureListContains(t, requireNativeLibs, "libfoo.so")
4006
Jooyung Hana0503a52023-08-23 13:12:50 +09004007 apexManifestRule = ctx.ModuleForTests("myapex_provider", "android_common_myapex_provider").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09004008 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
4009 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09004010 ensureListContains(t, provideNativeLibs, "libfoo.so")
4011 ensureListEmpty(t, requireNativeLibs)
4012
Jooyung Hana0503a52023-08-23 13:12:50 +09004013 apexManifestRule = ctx.ModuleForTests("myapex_selfcontained", "android_common_myapex_selfcontained").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09004014 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
4015 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Spandan Das20fce2d2023-04-12 17:21:39 +00004016 ensureListContains(t, provideNativeLibs, "libbar.so")
Jooyung Hane1633032019-08-01 17:41:43 +09004017 ensureListEmpty(t, requireNativeLibs)
4018}
4019
Sahana Rao16ebdfd2022-12-02 17:00:22 +00004020func TestOverrideApexManifestDefaultVersion(t *testing.T) {
4021 ctx := testApex(t, `
4022 apex {
4023 name: "myapex",
4024 key: "myapex.key",
Sahana Rao16ebdfd2022-12-02 17:00:22 +00004025 native_shared_libs: ["mylib"],
4026 updatable: false,
4027 }
4028
4029 apex_key {
4030 name: "myapex.key",
4031 public_key: "testkey.avbpubkey",
4032 private_key: "testkey.pem",
4033 }
4034
4035 cc_library {
4036 name: "mylib",
4037 srcs: ["mylib.cpp"],
4038 system_shared_libs: [],
4039 stl: "none",
4040 apex_available: [
4041 "//apex_available:platform",
4042 "myapex",
4043 ],
4044 }
4045 `, android.FixtureMergeEnv(map[string]string{
4046 "OVERRIDE_APEX_MANIFEST_DEFAULT_VERSION": "1234",
4047 }))
4048
Jooyung Hana0503a52023-08-23 13:12:50 +09004049 module := ctx.ModuleForTests("myapex", "android_common_myapex")
Sahana Rao16ebdfd2022-12-02 17:00:22 +00004050 apexManifestRule := module.Rule("apexManifestRule")
4051 ensureContains(t, apexManifestRule.Args["default_version"], "1234")
4052}
4053
Vinh Tran8f5310f2022-10-07 18:16:47 -04004054func TestCompileMultilibProp(t *testing.T) {
4055 testCases := []struct {
4056 compileMultiLibProp string
4057 containedLibs []string
4058 notContainedLibs []string
4059 }{
4060 {
4061 containedLibs: []string{
4062 "image.apex/lib64/mylib.so",
4063 "image.apex/lib/mylib.so",
4064 },
4065 compileMultiLibProp: `compile_multilib: "both",`,
4066 },
4067 {
4068 containedLibs: []string{"image.apex/lib64/mylib.so"},
4069 notContainedLibs: []string{"image.apex/lib/mylib.so"},
4070 compileMultiLibProp: `compile_multilib: "first",`,
4071 },
4072 {
4073 containedLibs: []string{"image.apex/lib64/mylib.so"},
4074 notContainedLibs: []string{"image.apex/lib/mylib.so"},
4075 // compile_multilib, when unset, should result to the same output as when compile_multilib is "first"
4076 },
4077 {
4078 containedLibs: []string{"image.apex/lib64/mylib.so"},
4079 notContainedLibs: []string{"image.apex/lib/mylib.so"},
4080 compileMultiLibProp: `compile_multilib: "64",`,
4081 },
4082 {
4083 containedLibs: []string{"image.apex/lib/mylib.so"},
4084 notContainedLibs: []string{"image.apex/lib64/mylib.so"},
4085 compileMultiLibProp: `compile_multilib: "32",`,
4086 },
4087 }
4088 for _, testCase := range testCases {
4089 ctx := testApex(t, fmt.Sprintf(`
4090 apex {
4091 name: "myapex",
4092 key: "myapex.key",
4093 %s
4094 native_shared_libs: ["mylib"],
4095 updatable: false,
4096 }
4097 apex_key {
4098 name: "myapex.key",
4099 public_key: "testkey.avbpubkey",
4100 private_key: "testkey.pem",
4101 }
4102 cc_library {
4103 name: "mylib",
4104 srcs: ["mylib.cpp"],
4105 apex_available: [
4106 "//apex_available:platform",
4107 "myapex",
4108 ],
4109 }
4110 `, testCase.compileMultiLibProp),
4111 )
Jooyung Hana0503a52023-08-23 13:12:50 +09004112 module := ctx.ModuleForTests("myapex", "android_common_myapex")
Vinh Tran8f5310f2022-10-07 18:16:47 -04004113 apexRule := module.Rule("apexRule")
4114 copyCmds := apexRule.Args["copy_commands"]
4115 for _, containedLib := range testCase.containedLibs {
4116 ensureContains(t, copyCmds, containedLib)
4117 }
4118 for _, notContainedLib := range testCase.notContainedLibs {
4119 ensureNotContains(t, copyCmds, notContainedLib)
4120 }
4121 }
4122}
4123
Alex Light0851b882019-02-07 13:20:53 -08004124func TestNonTestApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004125 ctx := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08004126 apex {
4127 name: "myapex",
4128 key: "myapex.key",
4129 native_shared_libs: ["mylib_common"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004130 updatable: false,
Alex Light0851b882019-02-07 13:20:53 -08004131 }
4132
4133 apex_key {
4134 name: "myapex.key",
4135 public_key: "testkey.avbpubkey",
4136 private_key: "testkey.pem",
4137 }
4138
4139 cc_library {
4140 name: "mylib_common",
4141 srcs: ["mylib.cpp"],
4142 system_shared_libs: [],
4143 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004144 apex_available: [
4145 "//apex_available:platform",
4146 "myapex",
4147 ],
Alex Light0851b882019-02-07 13:20:53 -08004148 }
4149 `)
4150
Jooyung Hana0503a52023-08-23 13:12:50 +09004151 module := ctx.ModuleForTests("myapex", "android_common_myapex")
Alex Light0851b882019-02-07 13:20:53 -08004152 apexRule := module.Rule("apexRule")
4153 copyCmds := apexRule.Args["copy_commands"]
4154
4155 if apex, ok := module.Module().(*apexBundle); !ok || apex.testApex {
4156 t.Log("Apex was a test apex!")
4157 t.Fail()
4158 }
4159 // Ensure that main rule creates an output
4160 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
4161
4162 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -07004163 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
Alex Light0851b882019-02-07 13:20:53 -08004164
4165 // Ensure that both direct and indirect deps are copied into apex
4166 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
4167
Colin Cross7113d202019-11-20 16:39:12 -08004168 // Ensure that the platform variant ends with _shared
4169 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
Alex Light0851b882019-02-07 13:20:53 -08004170
Colin Cross56a83212020-09-15 18:30:11 -07004171 if !ctx.ModuleForTests("mylib_common", "android_arm64_armv8-a_shared_apex10000").Module().(*cc.Module).InAnyApex() {
Alex Light0851b882019-02-07 13:20:53 -08004172 t.Log("Found mylib_common not in any apex!")
4173 t.Fail()
4174 }
4175}
4176
4177func TestTestApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004178 ctx := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08004179 apex_test {
4180 name: "myapex",
4181 key: "myapex.key",
4182 native_shared_libs: ["mylib_common_test"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004183 updatable: false,
Alex Light0851b882019-02-07 13:20:53 -08004184 }
4185
4186 apex_key {
4187 name: "myapex.key",
4188 public_key: "testkey.avbpubkey",
4189 private_key: "testkey.pem",
4190 }
4191
4192 cc_library {
4193 name: "mylib_common_test",
4194 srcs: ["mylib.cpp"],
4195 system_shared_libs: [],
4196 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004197 // TODO: remove //apex_available:platform
4198 apex_available: [
4199 "//apex_available:platform",
4200 "myapex",
4201 ],
Alex Light0851b882019-02-07 13:20:53 -08004202 }
4203 `)
4204
Jooyung Hana0503a52023-08-23 13:12:50 +09004205 module := ctx.ModuleForTests("myapex", "android_common_myapex")
Alex Light0851b882019-02-07 13:20:53 -08004206 apexRule := module.Rule("apexRule")
4207 copyCmds := apexRule.Args["copy_commands"]
4208
4209 if apex, ok := module.Module().(*apexBundle); !ok || !apex.testApex {
4210 t.Log("Apex was not a test apex!")
4211 t.Fail()
4212 }
4213 // Ensure that main rule creates an output
4214 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
4215
4216 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -07004217 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared_apex10000")
Alex Light0851b882019-02-07 13:20:53 -08004218
4219 // Ensure that both direct and indirect deps are copied into apex
4220 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common_test.so")
4221
Colin Cross7113d202019-11-20 16:39:12 -08004222 // Ensure that the platform variant ends with _shared
4223 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared")
Alex Light0851b882019-02-07 13:20:53 -08004224}
4225
Jooyung Han85707de2023-12-01 14:21:13 +09004226func TestLibzVendorIsntStable(t *testing.T) {
4227 ctx := testApex(t, `
4228 apex {
4229 name: "myapex",
4230 key: "myapex.key",
4231 updatable: false,
4232 binaries: ["mybin"],
4233 }
4234 apex {
4235 name: "myvendorapex",
4236 key: "myapex.key",
4237 file_contexts: "myvendorapex_file_contexts",
4238 vendor: true,
4239 updatable: false,
4240 binaries: ["mybin"],
4241 }
4242 apex_key {
4243 name: "myapex.key",
4244 public_key: "testkey.avbpubkey",
4245 private_key: "testkey.pem",
4246 }
4247 cc_binary {
4248 name: "mybin",
4249 vendor_available: true,
4250 system_shared_libs: [],
4251 stl: "none",
4252 shared_libs: ["libz"],
4253 apex_available: ["//apex_available:anyapex"],
4254 }
4255 cc_library {
4256 name: "libz",
4257 vendor_available: true,
4258 system_shared_libs: [],
4259 stl: "none",
4260 stubs: {
4261 versions: ["28", "30"],
4262 },
4263 target: {
4264 vendor: {
4265 no_stubs: true,
4266 },
4267 },
4268 }
4269 `, withFiles(map[string][]byte{
4270 "myvendorapex_file_contexts": nil,
4271 }))
4272
4273 // libz provides stubs for core variant.
4274 {
4275 ensureExactContents(t, ctx, "myapex", "android_common_myapex", []string{
4276 "bin/mybin",
4277 })
4278 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("apexManifestRule")
4279 android.AssertStringEquals(t, "should require libz", apexManifestRule.Args["requireNativeLibs"], "libz.so")
4280 }
4281 // libz doesn't provide stubs for vendor variant.
4282 {
4283 ensureExactContents(t, ctx, "myvendorapex", "android_common_myvendorapex", []string{
4284 "bin/mybin",
4285 "lib64/libz.so",
4286 })
4287 apexManifestRule := ctx.ModuleForTests("myvendorapex", "android_common_myvendorapex").Rule("apexManifestRule")
4288 android.AssertStringEquals(t, "should not require libz", apexManifestRule.Args["requireNativeLibs"], "")
4289 }
4290}
4291
Alex Light9670d332019-01-29 18:07:33 -08004292func TestApexWithTarget(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004293 ctx := testApex(t, `
Alex Light9670d332019-01-29 18:07:33 -08004294 apex {
4295 name: "myapex",
4296 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004297 updatable: false,
Alex Light9670d332019-01-29 18:07:33 -08004298 multilib: {
4299 first: {
4300 native_shared_libs: ["mylib_common"],
4301 }
4302 },
4303 target: {
4304 android: {
4305 multilib: {
4306 first: {
4307 native_shared_libs: ["mylib"],
4308 }
4309 }
4310 },
4311 host: {
4312 multilib: {
4313 first: {
4314 native_shared_libs: ["mylib2"],
4315 }
4316 }
4317 }
4318 }
4319 }
4320
4321 apex_key {
4322 name: "myapex.key",
4323 public_key: "testkey.avbpubkey",
4324 private_key: "testkey.pem",
4325 }
4326
4327 cc_library {
4328 name: "mylib",
4329 srcs: ["mylib.cpp"],
4330 system_shared_libs: [],
4331 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004332 // TODO: remove //apex_available:platform
4333 apex_available: [
4334 "//apex_available:platform",
4335 "myapex",
4336 ],
Alex Light9670d332019-01-29 18:07:33 -08004337 }
4338
4339 cc_library {
4340 name: "mylib_common",
4341 srcs: ["mylib.cpp"],
4342 system_shared_libs: [],
4343 stl: "none",
4344 compile_multilib: "first",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004345 // TODO: remove //apex_available:platform
4346 apex_available: [
4347 "//apex_available:platform",
4348 "myapex",
4349 ],
Alex Light9670d332019-01-29 18:07:33 -08004350 }
4351
4352 cc_library {
4353 name: "mylib2",
4354 srcs: ["mylib.cpp"],
4355 system_shared_libs: [],
4356 stl: "none",
4357 compile_multilib: "first",
4358 }
4359 `)
4360
Jooyung Hana0503a52023-08-23 13:12:50 +09004361 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("apexRule")
Alex Light9670d332019-01-29 18:07:33 -08004362 copyCmds := apexRule.Args["copy_commands"]
4363
4364 // Ensure that main rule creates an output
4365 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
4366
4367 // Ensure that apex variant is created for the direct dep
Colin Crossaede88c2020-08-11 12:17:01 -07004368 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
4369 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
4370 ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
Alex Light9670d332019-01-29 18:07:33 -08004371
4372 // Ensure that both direct and indirect deps are copied into apex
4373 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
4374 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
4375 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
4376
Colin Cross7113d202019-11-20 16:39:12 -08004377 // Ensure that the platform variant ends with _shared
4378 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
4379 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
4380 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
Alex Light9670d332019-01-29 18:07:33 -08004381}
Jiyong Park04480cf2019-02-06 00:16:29 +09004382
Jiyong Park59140302020-12-14 18:44:04 +09004383func TestApexWithArch(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004384 ctx := testApex(t, `
Jiyong Park59140302020-12-14 18:44:04 +09004385 apex {
4386 name: "myapex",
4387 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004388 updatable: false,
Colin Cross70572ed2022-11-02 13:14:20 -07004389 native_shared_libs: ["mylib.generic"],
Jiyong Park59140302020-12-14 18:44:04 +09004390 arch: {
4391 arm64: {
4392 native_shared_libs: ["mylib.arm64"],
Colin Cross70572ed2022-11-02 13:14:20 -07004393 exclude_native_shared_libs: ["mylib.generic"],
Jiyong Park59140302020-12-14 18:44:04 +09004394 },
4395 x86_64: {
4396 native_shared_libs: ["mylib.x64"],
Colin Cross70572ed2022-11-02 13:14:20 -07004397 exclude_native_shared_libs: ["mylib.generic"],
Jiyong Park59140302020-12-14 18:44:04 +09004398 },
4399 }
4400 }
4401
4402 apex_key {
4403 name: "myapex.key",
4404 public_key: "testkey.avbpubkey",
4405 private_key: "testkey.pem",
4406 }
4407
4408 cc_library {
Colin Cross70572ed2022-11-02 13:14:20 -07004409 name: "mylib.generic",
4410 srcs: ["mylib.cpp"],
4411 system_shared_libs: [],
4412 stl: "none",
4413 // TODO: remove //apex_available:platform
4414 apex_available: [
4415 "//apex_available:platform",
4416 "myapex",
4417 ],
4418 }
4419
4420 cc_library {
Jiyong Park59140302020-12-14 18:44:04 +09004421 name: "mylib.arm64",
4422 srcs: ["mylib.cpp"],
4423 system_shared_libs: [],
4424 stl: "none",
4425 // TODO: remove //apex_available:platform
4426 apex_available: [
4427 "//apex_available:platform",
4428 "myapex",
4429 ],
4430 }
4431
4432 cc_library {
4433 name: "mylib.x64",
4434 srcs: ["mylib.cpp"],
4435 system_shared_libs: [],
4436 stl: "none",
4437 // TODO: remove //apex_available:platform
4438 apex_available: [
4439 "//apex_available:platform",
4440 "myapex",
4441 ],
4442 }
4443 `)
4444
Jooyung Hana0503a52023-08-23 13:12:50 +09004445 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("apexRule")
Jiyong Park59140302020-12-14 18:44:04 +09004446 copyCmds := apexRule.Args["copy_commands"]
4447
4448 // Ensure that apex variant is created for the direct dep
4449 ensureListContains(t, ctx.ModuleVariantsForTests("mylib.arm64"), "android_arm64_armv8-a_shared_apex10000")
Colin Cross70572ed2022-11-02 13:14:20 -07004450 ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib.generic"), "android_arm64_armv8-a_shared_apex10000")
Jiyong Park59140302020-12-14 18:44:04 +09004451 ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib.x64"), "android_arm64_armv8-a_shared_apex10000")
4452
4453 // Ensure that both direct and indirect deps are copied into apex
4454 ensureContains(t, copyCmds, "image.apex/lib64/mylib.arm64.so")
4455 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib.x64.so")
4456}
4457
Jiyong Park04480cf2019-02-06 00:16:29 +09004458func TestApexWithShBinary(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004459 ctx := testApex(t, `
Jiyong Park04480cf2019-02-06 00:16:29 +09004460 apex {
4461 name: "myapex",
4462 key: "myapex.key",
Sundong Ahn80c04892021-11-23 00:57:19 +00004463 sh_binaries: ["myscript"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004464 updatable: false,
Riya Thakur654461c2024-02-27 07:21:05 +00004465 compile_multilib: "both",
Jiyong Park04480cf2019-02-06 00:16:29 +09004466 }
4467
4468 apex_key {
4469 name: "myapex.key",
4470 public_key: "testkey.avbpubkey",
4471 private_key: "testkey.pem",
4472 }
4473
4474 sh_binary {
4475 name: "myscript",
4476 src: "mylib.cpp",
4477 filename: "myscript.sh",
4478 sub_dir: "script",
4479 }
4480 `)
4481
Jooyung Hana0503a52023-08-23 13:12:50 +09004482 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("apexRule")
Jiyong Park04480cf2019-02-06 00:16:29 +09004483 copyCmds := apexRule.Args["copy_commands"]
4484
4485 ensureContains(t, copyCmds, "image.apex/bin/script/myscript.sh")
4486}
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004487
Jooyung Han91df2082019-11-20 01:49:42 +09004488func TestApexInVariousPartition(t *testing.T) {
4489 testcases := []struct {
Jooyung Haneec1b3f2023-06-20 16:25:59 +09004490 propName, partition string
Jooyung Han91df2082019-11-20 01:49:42 +09004491 }{
Jooyung Haneec1b3f2023-06-20 16:25:59 +09004492 {"", "system"},
4493 {"product_specific: true", "product"},
4494 {"soc_specific: true", "vendor"},
4495 {"proprietary: true", "vendor"},
4496 {"vendor: true", "vendor"},
4497 {"system_ext_specific: true", "system_ext"},
Jooyung Han91df2082019-11-20 01:49:42 +09004498 }
4499 for _, tc := range testcases {
Jooyung Haneec1b3f2023-06-20 16:25:59 +09004500 t.Run(tc.propName+":"+tc.partition, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004501 ctx := testApex(t, `
Jooyung Han91df2082019-11-20 01:49:42 +09004502 apex {
4503 name: "myapex",
4504 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004505 updatable: false,
Jooyung Han91df2082019-11-20 01:49:42 +09004506 `+tc.propName+`
4507 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004508
Jooyung Han91df2082019-11-20 01:49:42 +09004509 apex_key {
4510 name: "myapex.key",
4511 public_key: "testkey.avbpubkey",
4512 private_key: "testkey.pem",
4513 }
4514 `)
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004515
Jooyung Hana0503a52023-08-23 13:12:50 +09004516 apex := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*apexBundle)
Jooyung Haneec1b3f2023-06-20 16:25:59 +09004517 expected := "out/soong/target/product/test_device/" + tc.partition + "/apex"
Paul Duffin37ba3442021-03-29 00:21:08 +01004518 actual := apex.installDir.RelativeToTop().String()
Jooyung Han91df2082019-11-20 01:49:42 +09004519 if actual != expected {
4520 t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
4521 }
Jooyung Han91df2082019-11-20 01:49:42 +09004522 })
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004523 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09004524}
Jiyong Park67882562019-03-21 01:11:21 +09004525
Jooyung Han580eb4f2020-06-24 19:33:06 +09004526func TestFileContexts_FindInDefaultLocationIfNotSet(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004527 ctx := testApex(t, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004528 apex {
4529 name: "myapex",
4530 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004531 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004532 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004533
Jooyung Han580eb4f2020-06-24 19:33:06 +09004534 apex_key {
4535 name: "myapex.key",
4536 public_key: "testkey.avbpubkey",
4537 private_key: "testkey.pem",
4538 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004539 `)
Jooyung Hana0503a52023-08-23 13:12:50 +09004540 module := ctx.ModuleForTests("myapex", "android_common_myapex")
Jooyung Han580eb4f2020-06-24 19:33:06 +09004541 rule := module.Output("file_contexts")
4542 ensureContains(t, rule.RuleParams.Command, "cat system/sepolicy/apex/myapex-file_contexts")
4543}
Jooyung Han54aca7b2019-11-20 02:26:02 +09004544
Jooyung Han580eb4f2020-06-24 19:33:06 +09004545func TestFileContexts_ShouldBeUnderSystemSepolicyForSystemApexes(t *testing.T) {
Jooyung Han54aca7b2019-11-20 02:26:02 +09004546 testApexError(t, `"myapex" .*: file_contexts: should be under system/sepolicy`, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004547 apex {
4548 name: "myapex",
4549 key: "myapex.key",
4550 file_contexts: "my_own_file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004551 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004552 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004553
Jooyung Han580eb4f2020-06-24 19:33:06 +09004554 apex_key {
4555 name: "myapex.key",
4556 public_key: "testkey.avbpubkey",
4557 private_key: "testkey.pem",
4558 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004559 `, withFiles(map[string][]byte{
4560 "my_own_file_contexts": nil,
4561 }))
Jooyung Han580eb4f2020-06-24 19:33:06 +09004562}
Jooyung Han54aca7b2019-11-20 02:26:02 +09004563
Jooyung Han580eb4f2020-06-24 19:33:06 +09004564func TestFileContexts_ProductSpecificApexes(t *testing.T) {
Jooyung Han54aca7b2019-11-20 02:26:02 +09004565 testApexError(t, `"myapex" .*: file_contexts: cannot find`, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004566 apex {
4567 name: "myapex",
4568 key: "myapex.key",
4569 product_specific: true,
4570 file_contexts: "product_specific_file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004571 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004572 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004573
Jooyung Han580eb4f2020-06-24 19:33:06 +09004574 apex_key {
4575 name: "myapex.key",
4576 public_key: "testkey.avbpubkey",
4577 private_key: "testkey.pem",
4578 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004579 `)
4580
Colin Cross1c460562021-02-16 17:55:47 -08004581 ctx := testApex(t, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004582 apex {
4583 name: "myapex",
4584 key: "myapex.key",
4585 product_specific: true,
4586 file_contexts: "product_specific_file_contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004587 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004588 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004589
Jooyung Han580eb4f2020-06-24 19:33:06 +09004590 apex_key {
4591 name: "myapex.key",
4592 public_key: "testkey.avbpubkey",
4593 private_key: "testkey.pem",
4594 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004595 `, withFiles(map[string][]byte{
4596 "product_specific_file_contexts": nil,
4597 }))
Jooyung Hana0503a52023-08-23 13:12:50 +09004598 module := ctx.ModuleForTests("myapex", "android_common_myapex")
Jooyung Han580eb4f2020-06-24 19:33:06 +09004599 rule := module.Output("file_contexts")
4600 ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
4601}
Jooyung Han54aca7b2019-11-20 02:26:02 +09004602
Jooyung Han580eb4f2020-06-24 19:33:06 +09004603func TestFileContexts_SetViaFileGroup(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004604 ctx := testApex(t, `
Jooyung Han580eb4f2020-06-24 19:33:06 +09004605 apex {
4606 name: "myapex",
4607 key: "myapex.key",
4608 product_specific: true,
4609 file_contexts: ":my-file-contexts",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00004610 updatable: false,
Jooyung Han580eb4f2020-06-24 19:33:06 +09004611 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004612
Jooyung Han580eb4f2020-06-24 19:33:06 +09004613 apex_key {
4614 name: "myapex.key",
4615 public_key: "testkey.avbpubkey",
4616 private_key: "testkey.pem",
4617 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004618
Jooyung Han580eb4f2020-06-24 19:33:06 +09004619 filegroup {
4620 name: "my-file-contexts",
4621 srcs: ["product_specific_file_contexts"],
4622 }
Jooyung Han54aca7b2019-11-20 02:26:02 +09004623 `, withFiles(map[string][]byte{
4624 "product_specific_file_contexts": nil,
4625 }))
Jooyung Hana0503a52023-08-23 13:12:50 +09004626 module := ctx.ModuleForTests("myapex", "android_common_myapex")
Jooyung Han580eb4f2020-06-24 19:33:06 +09004627 rule := module.Output("file_contexts")
4628 ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
Jooyung Han54aca7b2019-11-20 02:26:02 +09004629}
4630
Jiyong Park67882562019-03-21 01:11:21 +09004631func TestApexKeyFromOtherModule(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004632 ctx := testApex(t, `
Jiyong Park67882562019-03-21 01:11:21 +09004633 apex_key {
4634 name: "myapex.key",
4635 public_key: ":my.avbpubkey",
4636 private_key: ":my.pem",
4637 product_specific: true,
4638 }
4639
4640 filegroup {
4641 name: "my.avbpubkey",
4642 srcs: ["testkey2.avbpubkey"],
4643 }
4644
4645 filegroup {
4646 name: "my.pem",
4647 srcs: ["testkey2.pem"],
4648 }
4649 `)
4650
4651 apex_key := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
4652 expected_pubkey := "testkey2.avbpubkey"
Jaewoong Jung18aefc12020-12-21 09:11:10 -08004653 actual_pubkey := apex_key.publicKeyFile.String()
Jiyong Park67882562019-03-21 01:11:21 +09004654 if actual_pubkey != expected_pubkey {
4655 t.Errorf("wrong public key path. expected %q. actual %q", expected_pubkey, actual_pubkey)
4656 }
4657 expected_privkey := "testkey2.pem"
Jaewoong Jung18aefc12020-12-21 09:11:10 -08004658 actual_privkey := apex_key.privateKeyFile.String()
Jiyong Park67882562019-03-21 01:11:21 +09004659 if actual_privkey != expected_privkey {
4660 t.Errorf("wrong private key path. expected %q. actual %q", expected_privkey, actual_privkey)
4661 }
4662}
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004663
4664func TestPrebuilt(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004665 ctx := testApex(t, `
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004666 prebuilt_apex {
4667 name: "myapex",
Jiyong Parkc95714e2019-03-29 14:23:10 +09004668 arch: {
4669 arm64: {
4670 src: "myapex-arm64.apex",
4671 },
4672 arm: {
4673 src: "myapex-arm.apex",
4674 },
4675 },
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004676 }
4677 `)
4678
Wei Li340ee8e2022-03-18 17:33:24 -07004679 testingModule := ctx.ModuleForTests("myapex", "android_common_myapex")
4680 prebuilt := testingModule.Module().(*Prebuilt)
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004681
Jiyong Parkc95714e2019-03-29 14:23:10 +09004682 expectedInput := "myapex-arm64.apex"
4683 if prebuilt.inputApex.String() != expectedInput {
4684 t.Errorf("inputApex invalid. expected: %q, actual: %q", expectedInput, prebuilt.inputApex.String())
4685 }
Wei Li340ee8e2022-03-18 17:33:24 -07004686 android.AssertStringDoesContain(t, "Invalid provenance metadata file",
4687 prebuilt.ProvenanceMetaDataFile().String(), "soong/.intermediates/provenance_metadata/myapex/provenance_metadata.textproto")
4688 rule := testingModule.Rule("genProvenanceMetaData")
4689 android.AssertStringEquals(t, "Invalid input", "myapex-arm64.apex", rule.Inputs[0].String())
4690 android.AssertStringEquals(t, "Invalid output", "out/soong/.intermediates/provenance_metadata/myapex/provenance_metadata.textproto", rule.Output.String())
4691 android.AssertStringEquals(t, "Invalid args", "myapex", rule.Args["module_name"])
4692 android.AssertStringEquals(t, "Invalid args", "/system/apex/myapex.apex", rule.Args["install_path"])
Wei Li598f92d2023-01-04 17:12:24 -08004693
4694 entries := android.AndroidMkEntriesForTest(t, ctx, testingModule.Module())[0]
4695 android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "prebuilt_apex", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0])
Jaewoong Jung939ebd52019-03-26 15:07:36 -07004696}
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004697
Paul Duffinc0609c62021-03-01 17:27:16 +00004698func TestPrebuiltMissingSrc(t *testing.T) {
Paul Duffin6717d882021-06-15 19:09:41 +01004699 testApexError(t, `module "myapex" variant "android_common_myapex".*: prebuilt_apex does not support "arm64_armv8-a"`, `
Paul Duffinc0609c62021-03-01 17:27:16 +00004700 prebuilt_apex {
4701 name: "myapex",
4702 }
4703 `)
4704}
4705
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004706func TestPrebuiltFilenameOverride(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004707 ctx := testApex(t, `
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004708 prebuilt_apex {
4709 name: "myapex",
4710 src: "myapex-arm.apex",
4711 filename: "notmyapex.apex",
4712 }
4713 `)
4714
Wei Li340ee8e2022-03-18 17:33:24 -07004715 testingModule := ctx.ModuleForTests("myapex", "android_common_myapex")
4716 p := testingModule.Module().(*Prebuilt)
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004717
4718 expected := "notmyapex.apex"
4719 if p.installFilename != expected {
4720 t.Errorf("installFilename invalid. expected: %q, actual: %q", expected, p.installFilename)
4721 }
Wei Li340ee8e2022-03-18 17:33:24 -07004722 rule := testingModule.Rule("genProvenanceMetaData")
4723 android.AssertStringEquals(t, "Invalid input", "myapex-arm.apex", rule.Inputs[0].String())
4724 android.AssertStringEquals(t, "Invalid output", "out/soong/.intermediates/provenance_metadata/myapex/provenance_metadata.textproto", rule.Output.String())
4725 android.AssertStringEquals(t, "Invalid args", "myapex", rule.Args["module_name"])
4726 android.AssertStringEquals(t, "Invalid args", "/system/apex/notmyapex.apex", rule.Args["install_path"])
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01004727}
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07004728
Samiul Islam7c02e262021-09-08 17:48:28 +01004729func TestApexSetFilenameOverride(t *testing.T) {
4730 testApex(t, `
4731 apex_set {
4732 name: "com.company.android.myapex",
4733 apex_name: "com.android.myapex",
4734 set: "company-myapex.apks",
4735 filename: "com.company.android.myapex.apex"
4736 }
4737 `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
4738
4739 testApex(t, `
4740 apex_set {
4741 name: "com.company.android.myapex",
4742 apex_name: "com.android.myapex",
4743 set: "company-myapex.apks",
4744 filename: "com.company.android.myapex.capex"
4745 }
4746 `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
4747
4748 testApexError(t, `filename should end in .apex or .capex for apex_set`, `
4749 apex_set {
4750 name: "com.company.android.myapex",
4751 apex_name: "com.android.myapex",
4752 set: "company-myapex.apks",
4753 filename: "some-random-suffix"
4754 }
4755 `)
4756}
4757
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004758func TestPrebuiltOverrides(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08004759 ctx := testApex(t, `
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004760 prebuilt_apex {
4761 name: "myapex.prebuilt",
4762 src: "myapex-arm.apex",
4763 overrides: [
4764 "myapex",
4765 ],
4766 }
4767 `)
4768
Wei Li340ee8e2022-03-18 17:33:24 -07004769 testingModule := ctx.ModuleForTests("myapex.prebuilt", "android_common_myapex.prebuilt")
4770 p := testingModule.Module().(*Prebuilt)
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004771
4772 expected := []string{"myapex"}
Colin Crossaa255532020-07-03 13:18:24 -07004773 actual := android.AndroidMkEntriesForTest(t, ctx, p)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004774 if !reflect.DeepEqual(actual, expected) {
Jiyong Parkb0a012c2019-11-14 17:17:03 +09004775 t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES value '%s', expected '%s'", actual, expected)
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004776 }
Wei Li340ee8e2022-03-18 17:33:24 -07004777 rule := testingModule.Rule("genProvenanceMetaData")
4778 android.AssertStringEquals(t, "Invalid input", "myapex-arm.apex", rule.Inputs[0].String())
4779 android.AssertStringEquals(t, "Invalid output", "out/soong/.intermediates/provenance_metadata/myapex.prebuilt/provenance_metadata.textproto", rule.Output.String())
4780 android.AssertStringEquals(t, "Invalid args", "myapex.prebuilt", rule.Args["module_name"])
4781 android.AssertStringEquals(t, "Invalid args", "/system/apex/myapex.prebuilt.apex", rule.Args["install_path"])
Jaewoong Jung22f7d182019-07-16 18:25:41 -07004782}
4783
Martin Stjernholmbfffae72021-06-24 14:37:13 +01004784func TestPrebuiltApexName(t *testing.T) {
4785 testApex(t, `
4786 prebuilt_apex {
4787 name: "com.company.android.myapex",
4788 apex_name: "com.android.myapex",
4789 src: "company-myapex-arm.apex",
4790 }
4791 `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
4792
4793 testApex(t, `
4794 apex_set {
4795 name: "com.company.android.myapex",
4796 apex_name: "com.android.myapex",
4797 set: "company-myapex.apks",
4798 }
4799 `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
4800}
4801
4802func TestPrebuiltApexNameWithPlatformBootclasspath(t *testing.T) {
4803 _ = android.GroupFixturePreparers(
4804 java.PrepareForTestWithJavaDefaultModules,
4805 PrepareForTestWithApexBuildComponents,
4806 android.FixtureWithRootAndroidBp(`
4807 platform_bootclasspath {
4808 name: "platform-bootclasspath",
4809 fragments: [
4810 {
4811 apex: "com.android.art",
4812 module: "art-bootclasspath-fragment",
4813 },
4814 ],
4815 }
4816
4817 prebuilt_apex {
4818 name: "com.company.android.art",
4819 apex_name: "com.android.art",
4820 src: "com.company.android.art-arm.apex",
4821 exported_bootclasspath_fragments: ["art-bootclasspath-fragment"],
4822 }
4823
4824 prebuilt_bootclasspath_fragment {
4825 name: "art-bootclasspath-fragment",
satayevabcd5972021-08-06 17:49:46 +01004826 image_name: "art",
Martin Stjernholmbfffae72021-06-24 14:37:13 +01004827 contents: ["core-oj"],
Paul Duffin54e41972021-07-19 13:23:40 +01004828 hidden_api: {
4829 annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
4830 metadata: "my-bootclasspath-fragment/metadata.csv",
4831 index: "my-bootclasspath-fragment/index.csv",
4832 stub_flags: "my-bootclasspath-fragment/stub-flags.csv",
4833 all_flags: "my-bootclasspath-fragment/all-flags.csv",
4834 },
Martin Stjernholmbfffae72021-06-24 14:37:13 +01004835 }
4836
4837 java_import {
4838 name: "core-oj",
4839 jars: ["prebuilt.jar"],
4840 }
4841 `),
4842 ).RunTest(t)
4843}
4844
Spandan Das59a4a2b2024-01-09 21:35:56 +00004845// A minimal context object for use with DexJarBuildPath
4846type moduleErrorfTestCtx struct {
4847}
4848
4849func (ctx moduleErrorfTestCtx) ModuleErrorf(format string, args ...interface{}) {
4850}
4851
Paul Duffin092153d2021-01-26 11:42:39 +00004852// These tests verify that the prebuilt_apex/deapexer to java_import wiring allows for the
4853// propagation of paths to dex implementation jars from the former to the latter.
Paul Duffin064b70c2020-11-02 17:32:38 +00004854func TestPrebuiltExportDexImplementationJars(t *testing.T) {
Paul Duffin60264a02021-04-12 20:02:36 +01004855 transform := android.NullFixturePreparer
Paul Duffin064b70c2020-11-02 17:32:38 +00004856
Paul Duffin89886cb2021-02-05 16:44:03 +00004857 checkDexJarBuildPath := func(t *testing.T, ctx *android.TestContext, name string) {
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01004858 t.Helper()
Paul Duffin064b70c2020-11-02 17:32:38 +00004859 // Make sure the import has been given the correct path to the dex jar.
Colin Crossdcf71b22021-02-01 13:59:03 -08004860 p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency)
Spandan Das59a4a2b2024-01-09 21:35:56 +00004861 dexJarBuildPath := p.DexJarBuildPath(moduleErrorfTestCtx{}).PathOrNil()
Paul Duffin39853512021-02-26 11:09:39 +00004862 stem := android.RemoveOptionalPrebuiltPrefix(name)
Jeongik Chad5fe8782021-07-08 01:13:11 +09004863 android.AssertStringEquals(t, "DexJarBuildPath should be apex-related path.",
Spandan Das3576e762024-01-03 18:57:03 +00004864 ".intermediates/prebuilt_myapex.deapexer/android_common/deapexer/javalib/"+stem+".jar",
Jeongik Chad5fe8782021-07-08 01:13:11 +09004865 android.NormalizePathForTesting(dexJarBuildPath))
4866 }
4867
4868 checkDexJarInstallPath := func(t *testing.T, ctx *android.TestContext, name string) {
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01004869 t.Helper()
Jeongik Chad5fe8782021-07-08 01:13:11 +09004870 // Make sure the import has been given the correct path to the dex jar.
4871 p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency)
4872 dexJarBuildPath := p.DexJarInstallPath()
4873 stem := android.RemoveOptionalPrebuiltPrefix(name)
4874 android.AssertStringEquals(t, "DexJarInstallPath should be apex-related path.",
4875 "target/product/test_device/apex/myapex/javalib/"+stem+".jar",
4876 android.NormalizePathForTesting(dexJarBuildPath))
Paul Duffin064b70c2020-11-02 17:32:38 +00004877 }
4878
Paul Duffin39853512021-02-26 11:09:39 +00004879 ensureNoSourceVariant := func(t *testing.T, ctx *android.TestContext, name string) {
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01004880 t.Helper()
Paul Duffin064b70c2020-11-02 17:32:38 +00004881 // Make sure that an apex variant is not created for the source module.
Jeongik Chad5fe8782021-07-08 01:13:11 +09004882 android.AssertArrayString(t, "Check if there is no source variant",
4883 []string{"android_common"},
4884 ctx.ModuleVariantsForTests(name))
Paul Duffin064b70c2020-11-02 17:32:38 +00004885 }
4886
4887 t.Run("prebuilt only", func(t *testing.T) {
4888 bp := `
4889 prebuilt_apex {
4890 name: "myapex",
4891 arch: {
4892 arm64: {
4893 src: "myapex-arm64.apex",
4894 },
4895 arm: {
4896 src: "myapex-arm.apex",
4897 },
4898 },
Paul Duffin39853512021-02-26 11:09:39 +00004899 exported_java_libs: ["libfoo", "libbar"],
Paul Duffin064b70c2020-11-02 17:32:38 +00004900 }
4901
4902 java_import {
4903 name: "libfoo",
4904 jars: ["libfoo.jar"],
4905 }
Paul Duffin39853512021-02-26 11:09:39 +00004906
4907 java_sdk_library_import {
4908 name: "libbar",
4909 public: {
4910 jars: ["libbar.jar"],
4911 },
4912 }
Paul Duffin064b70c2020-11-02 17:32:38 +00004913 `
4914
4915 // Make sure that dexpreopt can access dex implementation files from the prebuilt.
4916 ctx := testDexpreoptWithApexes(t, bp, "", transform)
4917
Spandan Das3576e762024-01-03 18:57:03 +00004918 deapexerName := deapexerModuleName("prebuilt_myapex")
4919 android.AssertStringEquals(t, "APEX module name from deapexer name", "prebuilt_myapex", apexModuleName(deapexerName))
Martin Stjernholm44825602021-09-17 01:44:12 +01004920
Paul Duffinf6932af2021-02-26 18:21:56 +00004921 // Make sure that the deapexer has the correct input APEX.
Martin Stjernholm44825602021-09-17 01:44:12 +01004922 deapexer := ctx.ModuleForTests(deapexerName, "android_common")
Paul Duffinf6932af2021-02-26 18:21:56 +00004923 rule := deapexer.Rule("deapexer")
4924 if expected, actual := []string{"myapex-arm64.apex"}, android.NormalizePathsForTesting(rule.Implicits); !reflect.DeepEqual(expected, actual) {
4925 t.Errorf("expected: %q, found: %q", expected, actual)
4926 }
4927
Paul Duffin0d10c3c2021-03-01 17:09:32 +00004928 // Make sure that the prebuilt_apex has the correct input APEX.
Paul Duffin6717d882021-06-15 19:09:41 +01004929 prebuiltApex := ctx.ModuleForTests("myapex", "android_common_myapex")
Paul Duffin0d10c3c2021-03-01 17:09:32 +00004930 rule = prebuiltApex.Rule("android/soong/android.Cp")
4931 if expected, actual := "myapex-arm64.apex", android.NormalizePathForTesting(rule.Input); !reflect.DeepEqual(expected, actual) {
4932 t.Errorf("expected: %q, found: %q", expected, actual)
4933 }
4934
Paul Duffin89886cb2021-02-05 16:44:03 +00004935 checkDexJarBuildPath(t, ctx, "libfoo")
Jeongik Chad5fe8782021-07-08 01:13:11 +09004936 checkDexJarInstallPath(t, ctx, "libfoo")
Paul Duffin39853512021-02-26 11:09:39 +00004937
4938 checkDexJarBuildPath(t, ctx, "libbar")
Jeongik Chad5fe8782021-07-08 01:13:11 +09004939 checkDexJarInstallPath(t, ctx, "libbar")
Paul Duffin064b70c2020-11-02 17:32:38 +00004940 })
4941
4942 t.Run("prebuilt with source preferred", func(t *testing.T) {
4943
4944 bp := `
4945 prebuilt_apex {
4946 name: "myapex",
4947 arch: {
4948 arm64: {
4949 src: "myapex-arm64.apex",
4950 },
4951 arm: {
4952 src: "myapex-arm.apex",
4953 },
4954 },
Paul Duffin39853512021-02-26 11:09:39 +00004955 exported_java_libs: ["libfoo", "libbar"],
Paul Duffin064b70c2020-11-02 17:32:38 +00004956 }
4957
4958 java_import {
4959 name: "libfoo",
4960 jars: ["libfoo.jar"],
4961 }
4962
4963 java_library {
4964 name: "libfoo",
4965 }
Paul Duffin39853512021-02-26 11:09:39 +00004966
4967 java_sdk_library_import {
4968 name: "libbar",
4969 public: {
4970 jars: ["libbar.jar"],
4971 },
4972 }
4973
4974 java_sdk_library {
4975 name: "libbar",
4976 srcs: ["foo/bar/MyClass.java"],
4977 unsafe_ignore_missing_latest_api: true,
4978 }
Paul Duffin064b70c2020-11-02 17:32:38 +00004979 `
4980
4981 // Make sure that dexpreopt can access dex implementation files from the prebuilt.
4982 ctx := testDexpreoptWithApexes(t, bp, "", transform)
4983
Paul Duffin89886cb2021-02-05 16:44:03 +00004984 checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
Jeongik Chad5fe8782021-07-08 01:13:11 +09004985 checkDexJarInstallPath(t, ctx, "prebuilt_libfoo")
Paul Duffin39853512021-02-26 11:09:39 +00004986 ensureNoSourceVariant(t, ctx, "libfoo")
4987
4988 checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
Jeongik Chad5fe8782021-07-08 01:13:11 +09004989 checkDexJarInstallPath(t, ctx, "prebuilt_libbar")
Paul Duffin39853512021-02-26 11:09:39 +00004990 ensureNoSourceVariant(t, ctx, "libbar")
Paul Duffin064b70c2020-11-02 17:32:38 +00004991 })
4992
4993 t.Run("prebuilt preferred with source", func(t *testing.T) {
4994 bp := `
4995 prebuilt_apex {
4996 name: "myapex",
Paul Duffin064b70c2020-11-02 17:32:38 +00004997 arch: {
4998 arm64: {
4999 src: "myapex-arm64.apex",
5000 },
5001 arm: {
5002 src: "myapex-arm.apex",
5003 },
5004 },
Paul Duffin39853512021-02-26 11:09:39 +00005005 exported_java_libs: ["libfoo", "libbar"],
Paul Duffin064b70c2020-11-02 17:32:38 +00005006 }
5007
5008 java_import {
5009 name: "libfoo",
Paul Duffin092153d2021-01-26 11:42:39 +00005010 prefer: true,
Paul Duffin064b70c2020-11-02 17:32:38 +00005011 jars: ["libfoo.jar"],
5012 }
5013
5014 java_library {
5015 name: "libfoo",
5016 }
Paul Duffin39853512021-02-26 11:09:39 +00005017
5018 java_sdk_library_import {
5019 name: "libbar",
5020 prefer: true,
5021 public: {
5022 jars: ["libbar.jar"],
5023 },
5024 }
5025
5026 java_sdk_library {
5027 name: "libbar",
5028 srcs: ["foo/bar/MyClass.java"],
5029 unsafe_ignore_missing_latest_api: true,
5030 }
Paul Duffin064b70c2020-11-02 17:32:38 +00005031 `
5032
5033 // Make sure that dexpreopt can access dex implementation files from the prebuilt.
5034 ctx := testDexpreoptWithApexes(t, bp, "", transform)
5035
Paul Duffin89886cb2021-02-05 16:44:03 +00005036 checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
Jeongik Chad5fe8782021-07-08 01:13:11 +09005037 checkDexJarInstallPath(t, ctx, "prebuilt_libfoo")
Paul Duffin39853512021-02-26 11:09:39 +00005038 ensureNoSourceVariant(t, ctx, "libfoo")
5039
5040 checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
Jeongik Chad5fe8782021-07-08 01:13:11 +09005041 checkDexJarInstallPath(t, ctx, "prebuilt_libbar")
Paul Duffin39853512021-02-26 11:09:39 +00005042 ensureNoSourceVariant(t, ctx, "libbar")
Paul Duffin064b70c2020-11-02 17:32:38 +00005043 })
5044}
5045
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005046func TestBootDexJarsFromSourcesAndPrebuilts(t *testing.T) {
Paul Duffinb6f53c02021-05-14 07:52:42 +01005047 preparer := android.GroupFixturePreparers(
satayevabcd5972021-08-06 17:49:46 +01005048 java.FixtureConfigureApexBootJars("myapex:libfoo", "myapex:libbar"),
Paul Duffinb6f53c02021-05-14 07:52:42 +01005049 // Make sure that the frameworks/base/Android.bp file exists as otherwise hidden API encoding
5050 // is disabled.
5051 android.FixtureAddTextFile("frameworks/base/Android.bp", ""),
5052 )
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005053
Paul Duffin37856732021-02-26 14:24:15 +00005054 checkBootDexJarPath := func(t *testing.T, ctx *android.TestContext, stem string, bootDexJarPath string) {
5055 t.Helper()
Jiakai Zhangc6879f32023-11-06 16:31:19 +00005056 s := ctx.ModuleForTests("dex_bootjars", "android_common")
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005057 foundLibfooJar := false
Paul Duffin37856732021-02-26 14:24:15 +00005058 base := stem + ".jar"
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005059 for _, output := range s.AllOutputs() {
Paul Duffin37856732021-02-26 14:24:15 +00005060 if filepath.Base(output) == base {
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005061 foundLibfooJar = true
5062 buildRule := s.Output(output)
Paul Duffin55607122021-03-30 23:32:51 +01005063 android.AssertStringEquals(t, "boot dex jar path", bootDexJarPath, buildRule.Input.String())
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005064 }
5065 }
5066 if !foundLibfooJar {
Lukacs T. Berki9f6c24a2021-08-26 15:07:24 +02005067 t.Errorf("Rule for libfoo.jar missing in dex_bootjars singleton outputs %q", android.StringPathsRelativeToTop(ctx.Config().SoongOutDir(), s.AllOutputs()))
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005068 }
5069 }
5070
Paul Duffin40a3f652021-07-19 13:11:24 +01005071 checkHiddenAPIIndexFromClassesInputs := func(t *testing.T, ctx *android.TestContext, expectedIntermediateInputs string) {
Paul Duffin37856732021-02-26 14:24:15 +00005072 t.Helper()
Paul Duffin00b2bfd2021-04-12 17:24:36 +01005073 platformBootclasspath := ctx.ModuleForTests("platform-bootclasspath", "android_common")
Paul Duffind061d402021-06-07 21:36:01 +01005074 var rule android.TestingBuildParams
5075
5076 rule = platformBootclasspath.Output("hiddenapi-monolithic/index-from-classes.csv")
5077 java.CheckHiddenAPIRuleInputs(t, "intermediate index", expectedIntermediateInputs, rule)
Paul Duffin4fd997b2021-02-03 20:06:33 +00005078 }
5079
Paul Duffin40a3f652021-07-19 13:11:24 +01005080 checkHiddenAPIIndexFromFlagsInputs := func(t *testing.T, ctx *android.TestContext, expectedIntermediateInputs string) {
5081 t.Helper()
5082 platformBootclasspath := ctx.ModuleForTests("platform-bootclasspath", "android_common")
5083 var rule android.TestingBuildParams
5084
5085 rule = platformBootclasspath.Output("hiddenapi-index.csv")
5086 java.CheckHiddenAPIRuleInputs(t, "monolithic index", expectedIntermediateInputs, rule)
5087 }
5088
Paul Duffin89f570a2021-06-16 01:42:33 +01005089 fragment := java.ApexVariantReference{
5090 Apex: proptools.StringPtr("myapex"),
5091 Module: proptools.StringPtr("my-bootclasspath-fragment"),
5092 }
5093
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005094 t.Run("prebuilt only", func(t *testing.T) {
5095 bp := `
5096 prebuilt_apex {
5097 name: "myapex",
5098 arch: {
5099 arm64: {
5100 src: "myapex-arm64.apex",
5101 },
5102 arm: {
5103 src: "myapex-arm.apex",
5104 },
5105 },
Paul Duffin89f570a2021-06-16 01:42:33 +01005106 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
5107 }
5108
5109 prebuilt_bootclasspath_fragment {
5110 name: "my-bootclasspath-fragment",
5111 contents: ["libfoo", "libbar"],
5112 apex_available: ["myapex"],
Paul Duffin54e41972021-07-19 13:23:40 +01005113 hidden_api: {
5114 annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
5115 metadata: "my-bootclasspath-fragment/metadata.csv",
5116 index: "my-bootclasspath-fragment/index.csv",
Paul Duffin191be3a2021-08-10 16:14:16 +01005117 signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
5118 filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
5119 filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
Paul Duffin54e41972021-07-19 13:23:40 +01005120 },
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005121 }
5122
5123 java_import {
5124 name: "libfoo",
5125 jars: ["libfoo.jar"],
5126 apex_available: ["myapex"],
satayevabcd5972021-08-06 17:49:46 +01005127 permitted_packages: ["foo"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005128 }
Paul Duffin37856732021-02-26 14:24:15 +00005129
5130 java_sdk_library_import {
5131 name: "libbar",
5132 public: {
5133 jars: ["libbar.jar"],
5134 },
5135 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01005136 shared_library: false,
satayevabcd5972021-08-06 17:49:46 +01005137 permitted_packages: ["bar"],
Paul Duffin37856732021-02-26 14:24:15 +00005138 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005139 `
5140
Paul Duffin89f570a2021-06-16 01:42:33 +01005141 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Spandan Das3576e762024-01-03 18:57:03 +00005142 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/prebuilt_myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
5143 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/prebuilt_myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00005144
Paul Duffin537ea3d2021-05-14 10:38:00 +01005145 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin54e41972021-07-19 13:23:40 +01005146 checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
Paul Duffin40a3f652021-07-19 13:11:24 +01005147 checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
Paul Duffin54e41972021-07-19 13:23:40 +01005148 my-bootclasspath-fragment/index.csv
Paul Duffin40a3f652021-07-19 13:11:24 +01005149 out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
Jiakai Zhangb69e8952023-07-11 14:31:22 +01005150 out/soong/.intermediates/packages/modules/com.android.art/art-bootclasspath-fragment/android_common_apex10000/modular-hiddenapi/index.csv
Paul Duffin40a3f652021-07-19 13:11:24 +01005151 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005152 })
5153
Paul Duffinf58fd9a2021-04-06 16:00:22 +01005154 t.Run("apex_set only", func(t *testing.T) {
5155 bp := `
5156 apex_set {
5157 name: "myapex",
5158 set: "myapex.apks",
Liz Kammer2dc72442023-04-20 10:10:48 -04005159 exported_java_libs: ["myjavalib"],
Paul Duffin89f570a2021-06-16 01:42:33 +01005160 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
Liz Kammer2dc72442023-04-20 10:10:48 -04005161 exported_systemserverclasspath_fragments: ["my-systemserverclasspath-fragment"],
5162 }
5163
5164 java_import {
5165 name: "myjavalib",
5166 jars: ["myjavalib.jar"],
5167 apex_available: ["myapex"],
5168 permitted_packages: ["javalib"],
Paul Duffin89f570a2021-06-16 01:42:33 +01005169 }
5170
5171 prebuilt_bootclasspath_fragment {
5172 name: "my-bootclasspath-fragment",
5173 contents: ["libfoo", "libbar"],
5174 apex_available: ["myapex"],
Paul Duffin54e41972021-07-19 13:23:40 +01005175 hidden_api: {
5176 annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
5177 metadata: "my-bootclasspath-fragment/metadata.csv",
5178 index: "my-bootclasspath-fragment/index.csv",
Paul Duffin191be3a2021-08-10 16:14:16 +01005179 signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
5180 filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
5181 filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
Paul Duffin54e41972021-07-19 13:23:40 +01005182 },
Paul Duffinf58fd9a2021-04-06 16:00:22 +01005183 }
5184
Liz Kammer2dc72442023-04-20 10:10:48 -04005185 prebuilt_systemserverclasspath_fragment {
5186 name: "my-systemserverclasspath-fragment",
5187 contents: ["libbaz"],
5188 apex_available: ["myapex"],
5189 }
5190
Paul Duffinf58fd9a2021-04-06 16:00:22 +01005191 java_import {
5192 name: "libfoo",
5193 jars: ["libfoo.jar"],
5194 apex_available: ["myapex"],
satayevabcd5972021-08-06 17:49:46 +01005195 permitted_packages: ["foo"],
Paul Duffinf58fd9a2021-04-06 16:00:22 +01005196 }
5197
5198 java_sdk_library_import {
5199 name: "libbar",
5200 public: {
5201 jars: ["libbar.jar"],
5202 },
5203 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01005204 shared_library: false,
satayevabcd5972021-08-06 17:49:46 +01005205 permitted_packages: ["bar"],
Paul Duffinf58fd9a2021-04-06 16:00:22 +01005206 }
Liz Kammer2dc72442023-04-20 10:10:48 -04005207
5208 java_sdk_library_import {
5209 name: "libbaz",
5210 public: {
5211 jars: ["libbaz.jar"],
5212 },
5213 apex_available: ["myapex"],
5214 shared_library: false,
5215 permitted_packages: ["baz"],
5216 }
Paul Duffinf58fd9a2021-04-06 16:00:22 +01005217 `
5218
Paul Duffin89f570a2021-06-16 01:42:33 +01005219 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Spandan Das3576e762024-01-03 18:57:03 +00005220 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/prebuilt_myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
5221 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/prebuilt_myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
Paul Duffinf58fd9a2021-04-06 16:00:22 +01005222
Paul Duffin537ea3d2021-05-14 10:38:00 +01005223 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin54e41972021-07-19 13:23:40 +01005224 checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
Paul Duffin40a3f652021-07-19 13:11:24 +01005225 checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
Paul Duffin54e41972021-07-19 13:23:40 +01005226 my-bootclasspath-fragment/index.csv
Paul Duffin40a3f652021-07-19 13:11:24 +01005227 out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
Jiakai Zhangb69e8952023-07-11 14:31:22 +01005228 out/soong/.intermediates/packages/modules/com.android.art/art-bootclasspath-fragment/android_common_apex10000/modular-hiddenapi/index.csv
Paul Duffin40a3f652021-07-19 13:11:24 +01005229 `)
Liz Kammer2dc72442023-04-20 10:10:48 -04005230
5231 myApex := ctx.ModuleForTests("myapex", "android_common_myapex").Module()
5232
5233 overrideNames := []string{
Spandan Das3576e762024-01-03 18:57:03 +00005234 "myapex",
Liz Kammer2dc72442023-04-20 10:10:48 -04005235 "myjavalib.myapex",
5236 "libfoo.myapex",
5237 "libbar.myapex",
5238 "libbaz.myapex",
5239 }
5240 mkEntries := android.AndroidMkEntriesForTest(t, ctx, myApex)
5241 for i, e := range mkEntries {
5242 g := e.OverrideName
5243 if w := overrideNames[i]; w != g {
5244 t.Errorf("Expected override name %q, got %q", w, g)
5245 }
5246 }
5247
Paul Duffinf58fd9a2021-04-06 16:00:22 +01005248 })
5249
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005250 t.Run("prebuilt with source library preferred", func(t *testing.T) {
5251 bp := `
5252 prebuilt_apex {
5253 name: "myapex",
5254 arch: {
5255 arm64: {
5256 src: "myapex-arm64.apex",
5257 },
5258 arm: {
5259 src: "myapex-arm.apex",
5260 },
5261 },
Paul Duffin89f570a2021-06-16 01:42:33 +01005262 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
5263 }
5264
5265 prebuilt_bootclasspath_fragment {
5266 name: "my-bootclasspath-fragment",
5267 contents: ["libfoo", "libbar"],
5268 apex_available: ["myapex"],
Paul Duffin54e41972021-07-19 13:23:40 +01005269 hidden_api: {
5270 annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
5271 metadata: "my-bootclasspath-fragment/metadata.csv",
5272 index: "my-bootclasspath-fragment/index.csv",
5273 stub_flags: "my-bootclasspath-fragment/stub-flags.csv",
5274 all_flags: "my-bootclasspath-fragment/all-flags.csv",
5275 },
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005276 }
5277
5278 java_import {
5279 name: "libfoo",
5280 jars: ["libfoo.jar"],
5281 apex_available: ["myapex"],
5282 }
5283
5284 java_library {
5285 name: "libfoo",
5286 srcs: ["foo/bar/MyClass.java"],
5287 apex_available: ["myapex"],
5288 }
Paul Duffin37856732021-02-26 14:24:15 +00005289
5290 java_sdk_library_import {
5291 name: "libbar",
5292 public: {
5293 jars: ["libbar.jar"],
5294 },
5295 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01005296 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00005297 }
5298
5299 java_sdk_library {
5300 name: "libbar",
5301 srcs: ["foo/bar/MyClass.java"],
5302 unsafe_ignore_missing_latest_api: true,
5303 apex_available: ["myapex"],
5304 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005305 `
5306
5307 // In this test the source (java_library) libfoo is active since the
5308 // prebuilt (java_import) defaults to prefer:false. However the
5309 // prebuilt_apex module always depends on the prebuilt, and so it doesn't
5310 // find the dex boot jar in it. We either need to disable the source libfoo
5311 // or make the prebuilt libfoo preferred.
Paul Duffin89f570a2021-06-16 01:42:33 +01005312 testDexpreoptWithApexes(t, bp, "module libfoo does not provide a dex boot jar", preparer, fragment)
Spandan Das10ea4bf2021-08-20 19:18:16 +00005313 // dexbootjar check is skipped if AllowMissingDependencies is true
5314 preparerAllowMissingDeps := android.GroupFixturePreparers(
5315 preparer,
5316 android.PrepareForTestWithAllowMissingDependencies,
5317 )
5318 testDexpreoptWithApexes(t, bp, "", preparerAllowMissingDeps, fragment)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005319 })
5320
5321 t.Run("prebuilt library preferred with source", func(t *testing.T) {
5322 bp := `
Jiakai Zhangb69e8952023-07-11 14:31:22 +01005323 apex {
5324 name: "myapex",
5325 key: "myapex.key",
5326 updatable: false,
5327 bootclasspath_fragments: ["my-bootclasspath-fragment"],
5328 }
5329
5330 apex_key {
5331 name: "myapex.key",
5332 public_key: "testkey.avbpubkey",
5333 private_key: "testkey.pem",
5334 }
5335
5336 bootclasspath_fragment {
5337 name: "my-bootclasspath-fragment",
5338 contents: ["libfoo", "libbar"],
5339 apex_available: ["myapex"],
5340 hidden_api: {
5341 split_packages: ["*"],
5342 },
5343 }
5344
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005345 prebuilt_apex {
5346 name: "myapex",
5347 arch: {
5348 arm64: {
5349 src: "myapex-arm64.apex",
5350 },
5351 arm: {
5352 src: "myapex-arm.apex",
5353 },
5354 },
Paul Duffin89f570a2021-06-16 01:42:33 +01005355 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
5356 }
5357
5358 prebuilt_bootclasspath_fragment {
5359 name: "my-bootclasspath-fragment",
Jiakai Zhangb69e8952023-07-11 14:31:22 +01005360 prefer: true,
Paul Duffin89f570a2021-06-16 01:42:33 +01005361 contents: ["libfoo", "libbar"],
5362 apex_available: ["myapex"],
Paul Duffin54e41972021-07-19 13:23:40 +01005363 hidden_api: {
5364 annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
5365 metadata: "my-bootclasspath-fragment/metadata.csv",
5366 index: "my-bootclasspath-fragment/index.csv",
Paul Duffin191be3a2021-08-10 16:14:16 +01005367 signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
5368 filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
5369 filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
Paul Duffin54e41972021-07-19 13:23:40 +01005370 },
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005371 }
5372
5373 java_import {
5374 name: "libfoo",
5375 prefer: true,
5376 jars: ["libfoo.jar"],
5377 apex_available: ["myapex"],
satayevabcd5972021-08-06 17:49:46 +01005378 permitted_packages: ["foo"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005379 }
5380
5381 java_library {
5382 name: "libfoo",
5383 srcs: ["foo/bar/MyClass.java"],
5384 apex_available: ["myapex"],
Jiakai Zhangb69e8952023-07-11 14:31:22 +01005385 installable: true,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005386 }
Paul Duffin37856732021-02-26 14:24:15 +00005387
5388 java_sdk_library_import {
5389 name: "libbar",
5390 prefer: true,
5391 public: {
5392 jars: ["libbar.jar"],
5393 },
5394 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01005395 shared_library: false,
satayevabcd5972021-08-06 17:49:46 +01005396 permitted_packages: ["bar"],
Paul Duffin37856732021-02-26 14:24:15 +00005397 }
5398
5399 java_sdk_library {
5400 name: "libbar",
5401 srcs: ["foo/bar/MyClass.java"],
5402 unsafe_ignore_missing_latest_api: true,
5403 apex_available: ["myapex"],
Jiakai Zhangb69e8952023-07-11 14:31:22 +01005404 compile_dex: true,
Paul Duffin37856732021-02-26 14:24:15 +00005405 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005406 `
5407
Paul Duffin89f570a2021-06-16 01:42:33 +01005408 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Spandan Das3576e762024-01-03 18:57:03 +00005409 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/prebuilt_myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
5410 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/prebuilt_myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00005411
Paul Duffin537ea3d2021-05-14 10:38:00 +01005412 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin54e41972021-07-19 13:23:40 +01005413 checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
Paul Duffin40a3f652021-07-19 13:11:24 +01005414 checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
Paul Duffin54e41972021-07-19 13:23:40 +01005415 my-bootclasspath-fragment/index.csv
Paul Duffin40a3f652021-07-19 13:11:24 +01005416 out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
Jiakai Zhangb69e8952023-07-11 14:31:22 +01005417 out/soong/.intermediates/packages/modules/com.android.art/art-bootclasspath-fragment/android_common_apex10000/modular-hiddenapi/index.csv
Paul Duffin40a3f652021-07-19 13:11:24 +01005418 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005419 })
5420
5421 t.Run("prebuilt with source apex preferred", func(t *testing.T) {
5422 bp := `
5423 apex {
5424 name: "myapex",
5425 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005426 updatable: false,
Jiakai Zhangb69e8952023-07-11 14:31:22 +01005427 bootclasspath_fragments: ["my-bootclasspath-fragment"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005428 }
5429
5430 apex_key {
5431 name: "myapex.key",
5432 public_key: "testkey.avbpubkey",
5433 private_key: "testkey.pem",
5434 }
5435
Jiakai Zhangb69e8952023-07-11 14:31:22 +01005436 bootclasspath_fragment {
5437 name: "my-bootclasspath-fragment",
5438 contents: ["libfoo", "libbar"],
5439 apex_available: ["myapex"],
5440 hidden_api: {
5441 split_packages: ["*"],
5442 },
5443 }
5444
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005445 prebuilt_apex {
5446 name: "myapex",
5447 arch: {
5448 arm64: {
5449 src: "myapex-arm64.apex",
5450 },
5451 arm: {
5452 src: "myapex-arm.apex",
5453 },
5454 },
Paul Duffin89f570a2021-06-16 01:42:33 +01005455 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
5456 }
5457
5458 prebuilt_bootclasspath_fragment {
5459 name: "my-bootclasspath-fragment",
5460 contents: ["libfoo", "libbar"],
5461 apex_available: ["myapex"],
Paul Duffin54e41972021-07-19 13:23:40 +01005462 hidden_api: {
5463 annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
5464 metadata: "my-bootclasspath-fragment/metadata.csv",
5465 index: "my-bootclasspath-fragment/index.csv",
Paul Duffin191be3a2021-08-10 16:14:16 +01005466 signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
5467 filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
5468 filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
Paul Duffin54e41972021-07-19 13:23:40 +01005469 },
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005470 }
5471
5472 java_import {
5473 name: "libfoo",
5474 jars: ["libfoo.jar"],
5475 apex_available: ["myapex"],
5476 }
5477
5478 java_library {
5479 name: "libfoo",
5480 srcs: ["foo/bar/MyClass.java"],
5481 apex_available: ["myapex"],
satayevabcd5972021-08-06 17:49:46 +01005482 permitted_packages: ["foo"],
Jiakai Zhangb69e8952023-07-11 14:31:22 +01005483 installable: true,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005484 }
Paul Duffin37856732021-02-26 14:24:15 +00005485
5486 java_sdk_library_import {
5487 name: "libbar",
5488 public: {
5489 jars: ["libbar.jar"],
5490 },
5491 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01005492 shared_library: false,
Paul Duffin37856732021-02-26 14:24:15 +00005493 }
5494
5495 java_sdk_library {
5496 name: "libbar",
5497 srcs: ["foo/bar/MyClass.java"],
5498 unsafe_ignore_missing_latest_api: true,
5499 apex_available: ["myapex"],
satayevabcd5972021-08-06 17:49:46 +01005500 permitted_packages: ["bar"],
Jiakai Zhangb69e8952023-07-11 14:31:22 +01005501 compile_dex: true,
Paul Duffin37856732021-02-26 14:24:15 +00005502 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005503 `
5504
Paul Duffin89f570a2021-06-16 01:42:33 +01005505 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Jiakai Zhangc6879f32023-11-06 16:31:19 +00005506 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/my-bootclasspath-fragment/android_common_myapex/hiddenapi-modular/encoded/libfoo.jar")
5507 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/my-bootclasspath-fragment/android_common_myapex/hiddenapi-modular/encoded/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00005508
Paul Duffin537ea3d2021-05-14 10:38:00 +01005509 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin54e41972021-07-19 13:23:40 +01005510 checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
Paul Duffin40a3f652021-07-19 13:11:24 +01005511 checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
5512 out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
Jiakai Zhangb69e8952023-07-11 14:31:22 +01005513 out/soong/.intermediates/my-bootclasspath-fragment/android_common_myapex/modular-hiddenapi/index.csv
5514 out/soong/.intermediates/packages/modules/com.android.art/art-bootclasspath-fragment/android_common_apex10000/modular-hiddenapi/index.csv
Paul Duffin40a3f652021-07-19 13:11:24 +01005515 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005516 })
5517
5518 t.Run("prebuilt preferred with source apex disabled", func(t *testing.T) {
5519 bp := `
5520 apex {
5521 name: "myapex",
5522 enabled: false,
5523 key: "myapex.key",
Jiakai Zhangb69e8952023-07-11 14:31:22 +01005524 bootclasspath_fragments: ["my-bootclasspath-fragment"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005525 }
5526
5527 apex_key {
5528 name: "myapex.key",
5529 public_key: "testkey.avbpubkey",
5530 private_key: "testkey.pem",
5531 }
5532
Jiakai Zhangb69e8952023-07-11 14:31:22 +01005533 bootclasspath_fragment {
5534 name: "my-bootclasspath-fragment",
5535 enabled: false,
5536 contents: ["libfoo", "libbar"],
5537 apex_available: ["myapex"],
5538 hidden_api: {
5539 split_packages: ["*"],
5540 },
5541 }
5542
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005543 prebuilt_apex {
5544 name: "myapex",
5545 arch: {
5546 arm64: {
5547 src: "myapex-arm64.apex",
5548 },
5549 arm: {
5550 src: "myapex-arm.apex",
5551 },
5552 },
Paul Duffin89f570a2021-06-16 01:42:33 +01005553 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
5554 }
5555
5556 prebuilt_bootclasspath_fragment {
5557 name: "my-bootclasspath-fragment",
5558 contents: ["libfoo", "libbar"],
5559 apex_available: ["myapex"],
Paul Duffin54e41972021-07-19 13:23:40 +01005560 hidden_api: {
5561 annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
5562 metadata: "my-bootclasspath-fragment/metadata.csv",
5563 index: "my-bootclasspath-fragment/index.csv",
Paul Duffin191be3a2021-08-10 16:14:16 +01005564 signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
5565 filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
5566 filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
Paul Duffin54e41972021-07-19 13:23:40 +01005567 },
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005568 }
5569
5570 java_import {
5571 name: "libfoo",
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005572 jars: ["libfoo.jar"],
5573 apex_available: ["myapex"],
satayevabcd5972021-08-06 17:49:46 +01005574 permitted_packages: ["foo"],
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005575 }
5576
5577 java_library {
5578 name: "libfoo",
Jiakai Zhangb69e8952023-07-11 14:31:22 +01005579 enabled: false,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005580 srcs: ["foo/bar/MyClass.java"],
5581 apex_available: ["myapex"],
Jiakai Zhangb69e8952023-07-11 14:31:22 +01005582 installable: true,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005583 }
Paul Duffin37856732021-02-26 14:24:15 +00005584
5585 java_sdk_library_import {
5586 name: "libbar",
Paul Duffin37856732021-02-26 14:24:15 +00005587 public: {
5588 jars: ["libbar.jar"],
5589 },
5590 apex_available: ["myapex"],
Paul Duffin89f570a2021-06-16 01:42:33 +01005591 shared_library: false,
satayevabcd5972021-08-06 17:49:46 +01005592 permitted_packages: ["bar"],
Paul Duffin37856732021-02-26 14:24:15 +00005593 }
5594
5595 java_sdk_library {
5596 name: "libbar",
Jiakai Zhangb69e8952023-07-11 14:31:22 +01005597 enabled: false,
Paul Duffin37856732021-02-26 14:24:15 +00005598 srcs: ["foo/bar/MyClass.java"],
5599 unsafe_ignore_missing_latest_api: true,
5600 apex_available: ["myapex"],
Jiakai Zhangb69e8952023-07-11 14:31:22 +01005601 compile_dex: true,
Paul Duffin37856732021-02-26 14:24:15 +00005602 }
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005603 `
Cole Fausta963b942024-04-11 17:43:00 -07005604 // This test disables libbar, which causes the ComponentDepsMutator to add
5605 // deps on libbar.stubs and other sub-modules that don't exist. We can
5606 // enable AllowMissingDependencies to work around that, but enabling that
5607 // causes extra checks for missing source files to dex_bootjars, so add those
5608 // to the mock fs as well.
5609 preparer2 := android.GroupFixturePreparers(
5610 preparer,
5611 android.PrepareForTestWithAllowMissingDependencies,
5612 android.FixtureMergeMockFs(map[string][]byte{
5613 "build/soong/scripts/check_boot_jars/package_allowed_list.txt": nil,
5614 "frameworks/base/config/boot-profile.txt": nil,
5615 }),
5616 )
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005617
Cole Fausta963b942024-04-11 17:43:00 -07005618 ctx := testDexpreoptWithApexes(t, bp, "", preparer2, fragment)
Spandan Das3576e762024-01-03 18:57:03 +00005619 checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/prebuilt_myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
5620 checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/prebuilt_myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
Paul Duffin4fd997b2021-02-03 20:06:33 +00005621
Paul Duffin537ea3d2021-05-14 10:38:00 +01005622 // Verify the correct module jars contribute to the hiddenapi index file.
Paul Duffin54e41972021-07-19 13:23:40 +01005623 checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
Paul Duffin40a3f652021-07-19 13:11:24 +01005624 checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
Paul Duffin54e41972021-07-19 13:23:40 +01005625 my-bootclasspath-fragment/index.csv
Paul Duffin40a3f652021-07-19 13:11:24 +01005626 out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
Jiakai Zhangb69e8952023-07-11 14:31:22 +01005627 out/soong/.intermediates/packages/modules/com.android.art/art-bootclasspath-fragment/android_common_apex10000/modular-hiddenapi/index.csv
Paul Duffin40a3f652021-07-19 13:11:24 +01005628 `)
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005629 })
Spandan Das3a392012024-01-17 18:26:27 +00005630
Spandan Dasf2c10572024-02-27 04:49:52 +00005631 t.Run("Co-existing unflagged apexes should create a duplicate module error", func(t *testing.T) {
Spandan Das3a392012024-01-17 18:26:27 +00005632 bp := `
5633 // Source
5634 apex {
5635 name: "myapex",
5636 enabled: false,
5637 key: "myapex.key",
5638 bootclasspath_fragments: ["my-bootclasspath-fragment"],
5639 }
5640
5641 apex_key {
5642 name: "myapex.key",
5643 public_key: "testkey.avbpubkey",
5644 private_key: "testkey.pem",
5645 }
5646
5647 // Prebuilt
5648 prebuilt_apex {
5649 name: "myapex.v1",
5650 source_apex_name: "myapex",
5651 arch: {
5652 arm64: {
5653 src: "myapex-arm64.apex",
5654 },
5655 arm: {
5656 src: "myapex-arm.apex",
5657 },
5658 },
5659 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
5660 prefer: true,
5661 }
5662 prebuilt_apex {
5663 name: "myapex.v2",
5664 source_apex_name: "myapex",
5665 arch: {
5666 arm64: {
5667 src: "myapex-arm64.apex",
5668 },
5669 arm: {
5670 src: "myapex-arm.apex",
5671 },
5672 },
5673 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
5674 prefer: true,
5675 }
5676
5677 prebuilt_bootclasspath_fragment {
5678 name: "my-bootclasspath-fragment",
5679 contents: ["libfoo", "libbar"],
5680 apex_available: ["myapex"],
5681 hidden_api: {
5682 annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
5683 metadata: "my-bootclasspath-fragment/metadata.csv",
5684 index: "my-bootclasspath-fragment/index.csv",
5685 stub_flags: "my-bootclasspath-fragment/stub-flags.csv",
5686 all_flags: "my-bootclasspath-fragment/all-flags.csv",
5687 },
5688 prefer: true,
5689 }
5690
5691 java_import {
5692 name: "libfoo",
5693 jars: ["libfoo.jar"],
5694 apex_available: ["myapex"],
5695 prefer: true,
5696 }
5697 java_import {
5698 name: "libbar",
5699 jars: ["libbar.jar"],
5700 apex_available: ["myapex"],
5701 prefer: true,
5702 }
5703 `
5704
Spandan Dasf2c10572024-02-27 04:49:52 +00005705 testDexpreoptWithApexes(t, bp, "Multiple prebuilt modules prebuilt_myapex.v1 and prebuilt_myapex.v2 have been marked as preferred for this source module", preparer, fragment)
Spandan Das3a392012024-01-17 18:26:27 +00005706 })
5707
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00005708}
5709
Roland Levillain630846d2019-06-26 12:48:34 +01005710func TestApexWithTests(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005711 ctx := testApex(t, `
Roland Levillain630846d2019-06-26 12:48:34 +01005712 apex_test {
5713 name: "myapex",
5714 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005715 updatable: false,
Roland Levillain630846d2019-06-26 12:48:34 +01005716 tests: [
5717 "mytest",
Roland Levillain9b5fde92019-06-28 15:41:19 +01005718 "mytests",
Roland Levillain630846d2019-06-26 12:48:34 +01005719 ],
5720 }
5721
5722 apex_key {
5723 name: "myapex.key",
5724 public_key: "testkey.avbpubkey",
5725 private_key: "testkey.pem",
5726 }
5727
Liz Kammer1c14a212020-05-12 15:26:55 -07005728 filegroup {
5729 name: "fg",
5730 srcs: [
5731 "baz",
5732 "bar/baz"
5733 ],
5734 }
5735
Roland Levillain630846d2019-06-26 12:48:34 +01005736 cc_test {
5737 name: "mytest",
5738 gtest: false,
5739 srcs: ["mytest.cpp"],
5740 relative_install_path: "test",
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005741 shared_libs: ["mylib"],
Roland Levillain630846d2019-06-26 12:48:34 +01005742 system_shared_libs: [],
5743 static_executable: true,
5744 stl: "none",
Liz Kammer1c14a212020-05-12 15:26:55 -07005745 data: [":fg"],
Roland Levillain630846d2019-06-26 12:48:34 +01005746 }
Roland Levillain9b5fde92019-06-28 15:41:19 +01005747
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005748 cc_library {
5749 name: "mylib",
5750 srcs: ["mylib.cpp"],
5751 system_shared_libs: [],
5752 stl: "none",
5753 }
5754
Liz Kammer5bd365f2020-05-27 15:15:11 -07005755 filegroup {
5756 name: "fg2",
5757 srcs: [
5758 "testdata/baz"
5759 ],
5760 }
5761
Roland Levillain9b5fde92019-06-28 15:41:19 +01005762 cc_test {
5763 name: "mytests",
5764 gtest: false,
5765 srcs: [
5766 "mytest1.cpp",
5767 "mytest2.cpp",
5768 "mytest3.cpp",
5769 ],
5770 test_per_src: true,
5771 relative_install_path: "test",
5772 system_shared_libs: [],
5773 static_executable: true,
5774 stl: "none",
Liz Kammer5bd365f2020-05-27 15:15:11 -07005775 data: [
5776 ":fg",
5777 ":fg2",
5778 ],
Roland Levillain9b5fde92019-06-28 15:41:19 +01005779 }
Roland Levillain630846d2019-06-26 12:48:34 +01005780 `)
5781
Jooyung Hana0503a52023-08-23 13:12:50 +09005782 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("apexRule")
Roland Levillain630846d2019-06-26 12:48:34 +01005783 copyCmds := apexRule.Args["copy_commands"]
5784
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005785 // Ensure that test dep (and their transitive dependencies) are copied into apex.
Roland Levillain630846d2019-06-26 12:48:34 +01005786 ensureContains(t, copyCmds, "image.apex/bin/test/mytest")
Jiyong Parkaf9539f2020-05-04 10:31:32 +09005787 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Roland Levillain9b5fde92019-06-28 15:41:19 +01005788
Liz Kammer1c14a212020-05-12 15:26:55 -07005789 //Ensure that test data are copied into apex.
5790 ensureContains(t, copyCmds, "image.apex/bin/test/baz")
5791 ensureContains(t, copyCmds, "image.apex/bin/test/bar/baz")
5792
Roland Levillain9b5fde92019-06-28 15:41:19 +01005793 // Ensure that test deps built with `test_per_src` are copied into apex.
5794 ensureContains(t, copyCmds, "image.apex/bin/test/mytest1")
5795 ensureContains(t, copyCmds, "image.apex/bin/test/mytest2")
5796 ensureContains(t, copyCmds, "image.apex/bin/test/mytest3")
Roland Levillainf89cd092019-07-29 16:22:59 +01005797
5798 // Ensure the module is correctly translated.
Jooyung Hana0503a52023-08-23 13:12:50 +09005799 bundle := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07005800 data := android.AndroidMkDataForTest(t, ctx, bundle)
Liz Kammer81faaaf2020-05-20 09:57:08 -07005801 name := bundle.BaseModuleName()
Roland Levillainf89cd092019-07-29 16:22:59 +01005802 prefix := "TARGET_"
5803 var builder strings.Builder
5804 data.Custom(&builder, name, prefix, "", data)
5805 androidMk := builder.String()
Diwas Sharmabb9202e2023-01-26 18:42:21 +00005806 ensureContains(t, androidMk, "LOCAL_MODULE := mytest.myapex\n")
5807 ensureContains(t, androidMk, "LOCAL_MODULE := mytest1.myapex\n")
5808 ensureContains(t, androidMk, "LOCAL_MODULE := mytest2.myapex\n")
5809 ensureContains(t, androidMk, "LOCAL_MODULE := mytest3.myapex\n")
Roland Levillainf89cd092019-07-29 16:22:59 +01005810 ensureContains(t, androidMk, "LOCAL_MODULE := myapex\n")
Roland Levillain630846d2019-06-26 12:48:34 +01005811}
5812
Jooyung Hand48f3c32019-08-23 11:18:57 +09005813func TestErrorsIfDepsAreNotEnabled(t *testing.T) {
5814 testApexError(t, `module "myapex" .* depends on disabled module "libfoo"`, `
5815 apex {
5816 name: "myapex",
5817 key: "myapex.key",
5818 native_shared_libs: ["libfoo"],
5819 }
5820
5821 apex_key {
5822 name: "myapex.key",
5823 public_key: "testkey.avbpubkey",
5824 private_key: "testkey.pem",
5825 }
5826
5827 cc_library {
5828 name: "libfoo",
5829 stl: "none",
5830 system_shared_libs: [],
5831 enabled: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09005832 apex_available: ["myapex"],
Jooyung Hand48f3c32019-08-23 11:18:57 +09005833 }
5834 `)
5835 testApexError(t, `module "myapex" .* depends on disabled module "myjar"`, `
5836 apex {
5837 name: "myapex",
5838 key: "myapex.key",
5839 java_libs: ["myjar"],
5840 }
5841
5842 apex_key {
5843 name: "myapex.key",
5844 public_key: "testkey.avbpubkey",
5845 private_key: "testkey.pem",
5846 }
5847
5848 java_library {
5849 name: "myjar",
5850 srcs: ["foo/bar/MyClass.java"],
5851 sdk_version: "none",
5852 system_modules: "none",
Jooyung Hand48f3c32019-08-23 11:18:57 +09005853 enabled: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09005854 apex_available: ["myapex"],
Jooyung Hand48f3c32019-08-23 11:18:57 +09005855 }
5856 `)
5857}
5858
Bill Peckhama41a6962021-01-11 10:58:54 -08005859func TestApexWithJavaImport(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005860 ctx := testApex(t, `
Bill Peckhama41a6962021-01-11 10:58:54 -08005861 apex {
5862 name: "myapex",
5863 key: "myapex.key",
5864 java_libs: ["myjavaimport"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005865 updatable: false,
Bill Peckhama41a6962021-01-11 10:58:54 -08005866 }
5867
5868 apex_key {
5869 name: "myapex.key",
5870 public_key: "testkey.avbpubkey",
5871 private_key: "testkey.pem",
5872 }
5873
5874 java_import {
5875 name: "myjavaimport",
5876 apex_available: ["myapex"],
5877 jars: ["my.jar"],
5878 compile_dex: true,
5879 }
5880 `)
5881
Jooyung Hana0503a52023-08-23 13:12:50 +09005882 module := ctx.ModuleForTests("myapex", "android_common_myapex")
Bill Peckhama41a6962021-01-11 10:58:54 -08005883 apexRule := module.Rule("apexRule")
5884 copyCmds := apexRule.Args["copy_commands"]
5885 ensureContains(t, copyCmds, "image.apex/javalib/myjavaimport.jar")
5886}
5887
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005888func TestApexWithApps(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08005889 ctx := testApex(t, `
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005890 apex {
5891 name: "myapex",
5892 key: "myapex.key",
5893 apps: [
5894 "AppFoo",
Jiyong Parkf7487312019-10-17 12:54:30 +09005895 "AppFooPriv",
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005896 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00005897 updatable: false,
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005898 }
5899
5900 apex_key {
5901 name: "myapex.key",
5902 public_key: "testkey.avbpubkey",
5903 private_key: "testkey.pem",
5904 }
5905
5906 android_app {
5907 name: "AppFoo",
5908 srcs: ["foo/bar/MyClass.java"],
Colin Cross094cde42020-02-15 10:38:00 -08005909 sdk_version: "current",
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005910 system_modules: "none",
Jiyong Park8be103b2019-11-08 15:53:48 +09005911 jni_libs: ["libjni"],
Colin Cross094cde42020-02-15 10:38:00 -08005912 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005913 apex_available: [ "myapex" ],
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005914 }
Jiyong Parkf7487312019-10-17 12:54:30 +09005915
5916 android_app {
5917 name: "AppFooPriv",
5918 srcs: ["foo/bar/MyClass.java"],
Colin Cross094cde42020-02-15 10:38:00 -08005919 sdk_version: "current",
Jiyong Parkf7487312019-10-17 12:54:30 +09005920 system_modules: "none",
5921 privileged: true,
Sam Delmerico15809f82023-05-15 17:21:47 -04005922 privapp_allowlist: "privapp_allowlist_com.android.AppFooPriv.xml",
Colin Cross094cde42020-02-15 10:38:00 -08005923 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00005924 apex_available: [ "myapex" ],
Jiyong Parkf7487312019-10-17 12:54:30 +09005925 }
Jiyong Park8be103b2019-11-08 15:53:48 +09005926
5927 cc_library_shared {
5928 name: "libjni",
5929 srcs: ["mylib.cpp"],
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005930 shared_libs: ["libfoo"],
5931 stl: "none",
5932 system_shared_libs: [],
5933 apex_available: [ "myapex" ],
5934 sdk_version: "current",
5935 }
5936
5937 cc_library_shared {
5938 name: "libfoo",
Jiyong Park8be103b2019-11-08 15:53:48 +09005939 stl: "none",
5940 system_shared_libs: [],
Jiyong Park0f80c182020-01-31 02:49:53 +09005941 apex_available: [ "myapex" ],
Colin Cross094cde42020-02-15 10:38:00 -08005942 sdk_version: "current",
Jiyong Park8be103b2019-11-08 15:53:48 +09005943 }
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005944 `)
5945
Jooyung Hana0503a52023-08-23 13:12:50 +09005946 module := ctx.ModuleForTests("myapex", "android_common_myapex")
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005947 apexRule := module.Rule("apexRule")
5948 copyCmds := apexRule.Args["copy_commands"]
5949
Oriol Prieto Gasco17e22902022-05-05 13:52:25 +00005950 ensureContains(t, copyCmds, "image.apex/app/AppFoo@TEST.BUILD_ID/AppFoo.apk")
5951 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPriv@TEST.BUILD_ID/AppFooPriv.apk")
Andrei Onea580636b2022-08-17 16:53:46 +00005952 ensureContains(t, copyCmds, "image.apex/etc/permissions/privapp_allowlist_com.android.AppFooPriv.xml")
Jiyong Park52cd06f2019-11-11 10:14:32 +09005953
Colin Crossaede88c2020-08-11 12:17:01 -07005954 appZipRule := ctx.ModuleForTests("AppFoo", "android_common_apex10000").Description("zip jni libs")
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005955 // JNI libraries are uncompressed
Jiyong Park52cd06f2019-11-11 10:14:32 +09005956 if args := appZipRule.Args["jarArgs"]; !strings.Contains(args, "-L 0") {
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005957 t.Errorf("jni libs are not uncompressed for AppFoo")
Jiyong Park52cd06f2019-11-11 10:14:32 +09005958 }
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005959 // JNI libraries including transitive deps are
5960 for _, jni := range []string{"libjni", "libfoo"} {
Paul Duffinafdd4062021-03-30 19:44:07 +01005961 jniOutput := ctx.ModuleForTests(jni, "android_arm64_armv8-a_sdk_shared_apex10000").Module().(*cc.Module).OutputFile().RelativeToTop()
Jooyung Hanb7bebe22020-02-25 16:59:29 +09005962 // ... embedded inside APK (jnilibs.zip)
5963 ensureListContains(t, appZipRule.Implicits.Strings(), jniOutput.String())
5964 // ... and not directly inside the APEX
5965 ensureNotContains(t, copyCmds, "image.apex/lib64/"+jni+".so")
5966 }
Sam Delmericob1daccd2023-05-25 14:45:30 -04005967
5968 apexBundle := module.Module().(*apexBundle)
5969 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
5970 var builder strings.Builder
5971 data.Custom(&builder, apexBundle.Name(), "TARGET_", "", data)
5972 androidMk := builder.String()
5973 ensureContains(t, androidMk, "LOCAL_MODULE := AppFooPriv.myapex")
5974 ensureContains(t, androidMk, "LOCAL_MODULE := AppFoo.myapex")
5975 ensureMatches(t, androidMk, "LOCAL_SOONG_INSTALLED_MODULE := \\S+AppFooPriv.apk")
5976 ensureMatches(t, androidMk, "LOCAL_SOONG_INSTALLED_MODULE := \\S+AppFoo.apk")
5977 ensureMatches(t, androidMk, "LOCAL_SOONG_INSTALL_PAIRS := \\S+AppFooPriv.apk")
5978 ensureContains(t, androidMk, "LOCAL_SOONG_INSTALL_PAIRS := privapp_allowlist_com.android.AppFooPriv.xml:$(PRODUCT_OUT)/apex/myapex/etc/permissions/privapp_allowlist_com.android.AppFooPriv.xml")
Dario Frenicde2a032019-10-27 00:29:22 +01005979}
Sundong Ahne1f05aa2019-08-27 13:55:42 +09005980
Oriol Prieto Gasco17e22902022-05-05 13:52:25 +00005981func TestApexWithAppImportBuildId(t *testing.T) {
5982 invalidBuildIds := []string{"../", "a b", "a/b", "a/b/../c", "/a"}
5983 for _, id := range invalidBuildIds {
5984 message := fmt.Sprintf("Unable to use build id %s as filename suffix", id)
5985 fixture := android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
5986 variables.BuildId = proptools.StringPtr(id)
5987 })
5988 testApexError(t, message, `apex {
5989 name: "myapex",
5990 key: "myapex.key",
5991 apps: ["AppFooPrebuilt"],
5992 updatable: false,
5993 }
5994
5995 apex_key {
5996 name: "myapex.key",
5997 public_key: "testkey.avbpubkey",
5998 private_key: "testkey.pem",
5999 }
6000
6001 android_app_import {
6002 name: "AppFooPrebuilt",
6003 apk: "PrebuiltAppFoo.apk",
6004 presigned: true,
6005 apex_available: ["myapex"],
6006 }
6007 `, fixture)
6008 }
6009}
6010
Dario Frenicde2a032019-10-27 00:29:22 +01006011func TestApexWithAppImports(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006012 ctx := testApex(t, `
Dario Frenicde2a032019-10-27 00:29:22 +01006013 apex {
6014 name: "myapex",
6015 key: "myapex.key",
6016 apps: [
6017 "AppFooPrebuilt",
6018 "AppFooPrivPrebuilt",
6019 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006020 updatable: false,
Dario Frenicde2a032019-10-27 00:29:22 +01006021 }
6022
6023 apex_key {
6024 name: "myapex.key",
6025 public_key: "testkey.avbpubkey",
6026 private_key: "testkey.pem",
6027 }
6028
6029 android_app_import {
6030 name: "AppFooPrebuilt",
6031 apk: "PrebuiltAppFoo.apk",
6032 presigned: true,
6033 dex_preopt: {
6034 enabled: false,
6035 },
Jiyong Park592a6a42020-04-21 22:34:28 +09006036 apex_available: ["myapex"],
Dario Frenicde2a032019-10-27 00:29:22 +01006037 }
6038
6039 android_app_import {
6040 name: "AppFooPrivPrebuilt",
6041 apk: "PrebuiltAppFooPriv.apk",
6042 privileged: true,
6043 presigned: true,
6044 dex_preopt: {
6045 enabled: false,
6046 },
Jooyung Han39ee1192020-03-23 20:21:11 +09006047 filename: "AwesomePrebuiltAppFooPriv.apk",
Jiyong Park592a6a42020-04-21 22:34:28 +09006048 apex_available: ["myapex"],
Dario Frenicde2a032019-10-27 00:29:22 +01006049 }
6050 `)
6051
Jooyung Hana0503a52023-08-23 13:12:50 +09006052 module := ctx.ModuleForTests("myapex", "android_common_myapex")
Dario Frenicde2a032019-10-27 00:29:22 +01006053 apexRule := module.Rule("apexRule")
6054 copyCmds := apexRule.Args["copy_commands"]
6055
Oriol Prieto Gasco17e22902022-05-05 13:52:25 +00006056 ensureContains(t, copyCmds, "image.apex/app/AppFooPrebuilt@TEST.BUILD_ID/AppFooPrebuilt.apk")
6057 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPrivPrebuilt@TEST.BUILD_ID/AwesomePrebuiltAppFooPriv.apk")
Jooyung Han39ee1192020-03-23 20:21:11 +09006058}
6059
6060func TestApexWithAppImportsPrefer(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006061 ctx := testApex(t, `
Jooyung Han39ee1192020-03-23 20:21:11 +09006062 apex {
6063 name: "myapex",
6064 key: "myapex.key",
6065 apps: [
6066 "AppFoo",
6067 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006068 updatable: false,
Jooyung Han39ee1192020-03-23 20:21:11 +09006069 }
6070
6071 apex_key {
6072 name: "myapex.key",
6073 public_key: "testkey.avbpubkey",
6074 private_key: "testkey.pem",
6075 }
6076
6077 android_app {
6078 name: "AppFoo",
6079 srcs: ["foo/bar/MyClass.java"],
6080 sdk_version: "none",
6081 system_modules: "none",
6082 apex_available: [ "myapex" ],
6083 }
6084
6085 android_app_import {
6086 name: "AppFoo",
6087 apk: "AppFooPrebuilt.apk",
6088 filename: "AppFooPrebuilt.apk",
6089 presigned: true,
6090 prefer: true,
Jiyong Park592a6a42020-04-21 22:34:28 +09006091 apex_available: ["myapex"],
Jooyung Han39ee1192020-03-23 20:21:11 +09006092 }
6093 `, withFiles(map[string][]byte{
6094 "AppFooPrebuilt.apk": nil,
6095 }))
6096
Jooyung Hana0503a52023-08-23 13:12:50 +09006097 ensureExactContents(t, ctx, "myapex", "android_common_myapex", []string{
Oriol Prieto Gasco17e22902022-05-05 13:52:25 +00006098 "app/AppFoo@TEST.BUILD_ID/AppFooPrebuilt.apk",
Jooyung Han39ee1192020-03-23 20:21:11 +09006099 })
Sundong Ahne1f05aa2019-08-27 13:55:42 +09006100}
6101
Dario Freni6f3937c2019-12-20 22:58:03 +00006102func TestApexWithTestHelperApp(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006103 ctx := testApex(t, `
Dario Freni6f3937c2019-12-20 22:58:03 +00006104 apex {
6105 name: "myapex",
6106 key: "myapex.key",
6107 apps: [
6108 "TesterHelpAppFoo",
6109 ],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006110 updatable: false,
Dario Freni6f3937c2019-12-20 22:58:03 +00006111 }
6112
6113 apex_key {
6114 name: "myapex.key",
6115 public_key: "testkey.avbpubkey",
6116 private_key: "testkey.pem",
6117 }
6118
6119 android_test_helper_app {
6120 name: "TesterHelpAppFoo",
6121 srcs: ["foo/bar/MyClass.java"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00006122 apex_available: [ "myapex" ],
Dario Freni6f3937c2019-12-20 22:58:03 +00006123 }
6124
6125 `)
6126
Jooyung Hana0503a52023-08-23 13:12:50 +09006127 module := ctx.ModuleForTests("myapex", "android_common_myapex")
Dario Freni6f3937c2019-12-20 22:58:03 +00006128 apexRule := module.Rule("apexRule")
6129 copyCmds := apexRule.Args["copy_commands"]
6130
Oriol Prieto Gasco17e22902022-05-05 13:52:25 +00006131 ensureContains(t, copyCmds, "image.apex/app/TesterHelpAppFoo@TEST.BUILD_ID/TesterHelpAppFoo.apk")
Dario Freni6f3937c2019-12-20 22:58:03 +00006132}
6133
Jooyung Han18020ea2019-11-13 10:50:48 +09006134func TestApexPropertiesShouldBeDefaultable(t *testing.T) {
6135 // libfoo's apex_available comes from cc_defaults
Steven Moreland6e36cd62020-10-22 01:08:35 +00006136 testApexError(t, `requires "libfoo" that doesn't list the APEX under 'apex_available'.`, `
Jooyung Han18020ea2019-11-13 10:50:48 +09006137 apex {
6138 name: "myapex",
6139 key: "myapex.key",
6140 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006141 updatable: false,
Jooyung Han18020ea2019-11-13 10:50:48 +09006142 }
6143
6144 apex_key {
6145 name: "myapex.key",
6146 public_key: "testkey.avbpubkey",
6147 private_key: "testkey.pem",
6148 }
6149
6150 apex {
6151 name: "otherapex",
6152 key: "myapex.key",
6153 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006154 updatable: false,
Jooyung Han18020ea2019-11-13 10:50:48 +09006155 }
6156
6157 cc_defaults {
6158 name: "libfoo-defaults",
6159 apex_available: ["otherapex"],
6160 }
6161
6162 cc_library {
6163 name: "libfoo",
6164 defaults: ["libfoo-defaults"],
6165 stl: "none",
6166 system_shared_libs: [],
6167 }`)
6168}
6169
Paul Duffine52e66f2020-03-30 17:54:29 +01006170func TestApexAvailable_DirectDep(t *testing.T) {
Jiyong Park127b40b2019-09-30 16:04:35 +09006171 // libfoo is not available to myapex, but only to otherapex
Steven Moreland6e36cd62020-10-22 01:08:35 +00006172 testApexError(t, "requires \"libfoo\" that doesn't list the APEX under 'apex_available'.", `
Jiyong Park127b40b2019-09-30 16:04:35 +09006173 apex {
6174 name: "myapex",
6175 key: "myapex.key",
6176 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006177 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09006178 }
6179
6180 apex_key {
6181 name: "myapex.key",
6182 public_key: "testkey.avbpubkey",
6183 private_key: "testkey.pem",
6184 }
6185
6186 apex {
6187 name: "otherapex",
6188 key: "otherapex.key",
6189 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006190 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09006191 }
6192
6193 apex_key {
6194 name: "otherapex.key",
6195 public_key: "testkey.avbpubkey",
6196 private_key: "testkey.pem",
6197 }
6198
6199 cc_library {
6200 name: "libfoo",
6201 stl: "none",
6202 system_shared_libs: [],
6203 apex_available: ["otherapex"],
6204 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01006205}
Jiyong Park127b40b2019-09-30 16:04:35 +09006206
Paul Duffine52e66f2020-03-30 17:54:29 +01006207func TestApexAvailable_IndirectDep(t *testing.T) {
Jooyung Han5e9013b2020-03-10 06:23:13 +09006208 // libbbaz is an indirect dep
Jiyong Park767dbd92021-03-04 13:03:10 +09006209 testApexError(t, `requires "libbaz" that doesn't list the APEX under 'apex_available'.\n\nDependency path:
Paul Duffin520917a2022-05-13 13:01:59 +00006210.*via tag apex\.dependencyTag\{"sharedLib"\}
Paul Duffindf915ff2020-03-30 17:58:21 +01006211.*-> libfoo.*link:shared.*
Colin Cross6e511a92020-07-27 21:26:48 -07006212.*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
Paul Duffindf915ff2020-03-30 17:58:21 +01006213.*-> libbar.*link:shared.*
Colin Cross6e511a92020-07-27 21:26:48 -07006214.*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
Paul Duffin65347702020-03-31 15:23:40 +01006215.*-> libbaz.*link:shared.*`, `
Jiyong Park127b40b2019-09-30 16:04:35 +09006216 apex {
6217 name: "myapex",
6218 key: "myapex.key",
6219 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006220 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09006221 }
6222
6223 apex_key {
6224 name: "myapex.key",
6225 public_key: "testkey.avbpubkey",
6226 private_key: "testkey.pem",
6227 }
6228
Jiyong Park127b40b2019-09-30 16:04:35 +09006229 cc_library {
6230 name: "libfoo",
6231 stl: "none",
6232 shared_libs: ["libbar"],
6233 system_shared_libs: [],
Jooyung Han5e9013b2020-03-10 06:23:13 +09006234 apex_available: ["myapex"],
Jiyong Park127b40b2019-09-30 16:04:35 +09006235 }
6236
6237 cc_library {
6238 name: "libbar",
6239 stl: "none",
Jooyung Han5e9013b2020-03-10 06:23:13 +09006240 shared_libs: ["libbaz"],
Jiyong Park127b40b2019-09-30 16:04:35 +09006241 system_shared_libs: [],
Jooyung Han5e9013b2020-03-10 06:23:13 +09006242 apex_available: ["myapex"],
6243 }
6244
6245 cc_library {
6246 name: "libbaz",
6247 stl: "none",
6248 system_shared_libs: [],
Jiyong Park127b40b2019-09-30 16:04:35 +09006249 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01006250}
Jiyong Park127b40b2019-09-30 16:04:35 +09006251
Liz Kammer5f108fa2023-05-11 14:33:17 -04006252func TestApexAvailable_IndirectStaticDep(t *testing.T) {
6253 testApex(t, `
6254 apex {
6255 name: "myapex",
6256 key: "myapex.key",
6257 native_shared_libs: ["libfoo"],
6258 updatable: false,
6259 }
6260
6261 apex_key {
6262 name: "myapex.key",
6263 public_key: "testkey.avbpubkey",
6264 private_key: "testkey.pem",
6265 }
6266
6267 cc_library {
6268 name: "libfoo",
6269 stl: "none",
6270 static_libs: ["libbar"],
6271 system_shared_libs: [],
6272 apex_available: ["myapex"],
6273 }
6274
6275 cc_library {
6276 name: "libbar",
6277 stl: "none",
6278 shared_libs: ["libbaz"],
6279 system_shared_libs: [],
6280 apex_available: ["myapex"],
6281 }
6282
6283 cc_library {
6284 name: "libbaz",
6285 stl: "none",
6286 system_shared_libs: [],
6287 }`)
6288
6289 testApexError(t, `requires "libbar" that doesn't list the APEX under 'apex_available'.`, `
6290 apex {
6291 name: "myapex",
6292 key: "myapex.key",
6293 native_shared_libs: ["libfoo"],
6294 updatable: false,
6295 }
6296
6297 apex_key {
6298 name: "myapex.key",
6299 public_key: "testkey.avbpubkey",
6300 private_key: "testkey.pem",
6301 }
6302
6303 cc_library {
6304 name: "libfoo",
6305 stl: "none",
6306 static_libs: ["libbar"],
6307 system_shared_libs: [],
6308 apex_available: ["myapex"],
6309 }
6310
6311 cc_library {
6312 name: "libbar",
6313 stl: "none",
6314 system_shared_libs: [],
6315 }`)
6316}
6317
Paul Duffine52e66f2020-03-30 17:54:29 +01006318func TestApexAvailable_InvalidApexName(t *testing.T) {
Jiyong Park127b40b2019-09-30 16:04:35 +09006319 testApexError(t, "\"otherapex\" is not a valid module name", `
6320 apex {
6321 name: "myapex",
6322 key: "myapex.key",
6323 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006324 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09006325 }
6326
6327 apex_key {
6328 name: "myapex.key",
6329 public_key: "testkey.avbpubkey",
6330 private_key: "testkey.pem",
6331 }
6332
6333 cc_library {
6334 name: "libfoo",
6335 stl: "none",
6336 system_shared_libs: [],
6337 apex_available: ["otherapex"],
6338 }`)
6339
Paul Duffine52e66f2020-03-30 17:54:29 +01006340 testApex(t, `
Jiyong Park127b40b2019-09-30 16:04:35 +09006341 apex {
6342 name: "myapex",
6343 key: "myapex.key",
6344 native_shared_libs: ["libfoo", "libbar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006345 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09006346 }
6347
6348 apex_key {
6349 name: "myapex.key",
6350 public_key: "testkey.avbpubkey",
6351 private_key: "testkey.pem",
6352 }
6353
6354 cc_library {
6355 name: "libfoo",
6356 stl: "none",
6357 system_shared_libs: [],
Jiyong Park323a4c32020-03-01 17:29:06 +09006358 runtime_libs: ["libbaz"],
Jiyong Park127b40b2019-09-30 16:04:35 +09006359 apex_available: ["myapex"],
6360 }
6361
6362 cc_library {
6363 name: "libbar",
6364 stl: "none",
6365 system_shared_libs: [],
6366 apex_available: ["//apex_available:anyapex"],
Jiyong Park323a4c32020-03-01 17:29:06 +09006367 }
6368
6369 cc_library {
6370 name: "libbaz",
6371 stl: "none",
6372 system_shared_libs: [],
6373 stubs: {
6374 versions: ["10", "20", "30"],
6375 },
Jiyong Park127b40b2019-09-30 16:04:35 +09006376 }`)
Paul Duffine52e66f2020-03-30 17:54:29 +01006377}
Jiyong Park127b40b2019-09-30 16:04:35 +09006378
Sam Delmerico6d65a0f2023-06-05 15:55:57 -04006379func TestApexAvailable_ApexAvailableNameWithVersionCodeError(t *testing.T) {
6380 t.Run("negative variant_version produces error", func(t *testing.T) {
6381 testApexError(t, "expected an integer between 0-9; got -1", `
6382 apex {
6383 name: "myapex",
6384 key: "myapex.key",
6385 apex_available_name: "com.android.foo",
6386 variant_version: "-1",
6387 updatable: false,
6388 }
6389 apex_key {
6390 name: "myapex.key",
6391 public_key: "testkey.avbpubkey",
6392 private_key: "testkey.pem",
6393 }
6394 `)
6395 })
6396
6397 t.Run("variant_version greater than 9 produces error", func(t *testing.T) {
6398 testApexError(t, "expected an integer between 0-9; got 10", `
6399 apex {
6400 name: "myapex",
6401 key: "myapex.key",
6402 apex_available_name: "com.android.foo",
6403 variant_version: "10",
6404 updatable: false,
6405 }
6406 apex_key {
6407 name: "myapex.key",
6408 public_key: "testkey.avbpubkey",
6409 private_key: "testkey.pem",
6410 }
6411 `)
6412 })
6413}
6414
6415func TestApexAvailable_ApexAvailableNameWithVersionCode(t *testing.T) {
6416 context := android.GroupFixturePreparers(
6417 android.PrepareForIntegrationTestWithAndroid,
6418 PrepareForTestWithApexBuildComponents,
6419 android.FixtureMergeMockFs(android.MockFS{
6420 "system/sepolicy/apex/foo-file_contexts": nil,
6421 "system/sepolicy/apex/bar-file_contexts": nil,
6422 }),
6423 )
6424 result := context.RunTestWithBp(t, `
6425 apex {
6426 name: "foo",
6427 key: "myapex.key",
6428 apex_available_name: "com.android.foo",
6429 variant_version: "0",
6430 updatable: false,
6431 }
6432 apex {
6433 name: "bar",
6434 key: "myapex.key",
6435 apex_available_name: "com.android.foo",
6436 variant_version: "3",
6437 updatable: false,
6438 }
6439 apex_key {
6440 name: "myapex.key",
6441 public_key: "testkey.avbpubkey",
6442 private_key: "testkey.pem",
6443 }
Sam Delmerico419f9a32023-07-21 12:00:13 -04006444 override_apex {
6445 name: "myoverrideapex",
6446 base: "bar",
6447 }
Sam Delmerico6d65a0f2023-06-05 15:55:57 -04006448 `)
6449
Jooyung Hana0503a52023-08-23 13:12:50 +09006450 fooManifestRule := result.ModuleForTests("foo", "android_common_foo").Rule("apexManifestRule")
Sam Delmerico6d65a0f2023-06-05 15:55:57 -04006451 fooExpectedDefaultVersion := android.DefaultUpdatableModuleVersion
6452 fooActualDefaultVersion := fooManifestRule.Args["default_version"]
6453 if fooActualDefaultVersion != fooExpectedDefaultVersion {
6454 t.Errorf("expected to find defaultVersion %q; got %q", fooExpectedDefaultVersion, fooActualDefaultVersion)
6455 }
6456
Jooyung Hana0503a52023-08-23 13:12:50 +09006457 barManifestRule := result.ModuleForTests("bar", "android_common_bar").Rule("apexManifestRule")
Sam Delmerico6d65a0f2023-06-05 15:55:57 -04006458 defaultVersionInt, _ := strconv.Atoi(android.DefaultUpdatableModuleVersion)
6459 barExpectedDefaultVersion := fmt.Sprint(defaultVersionInt + 3)
6460 barActualDefaultVersion := barManifestRule.Args["default_version"]
6461 if barActualDefaultVersion != barExpectedDefaultVersion {
6462 t.Errorf("expected to find defaultVersion %q; got %q", barExpectedDefaultVersion, barActualDefaultVersion)
6463 }
Sam Delmerico419f9a32023-07-21 12:00:13 -04006464
Jooyung Hana0503a52023-08-23 13:12:50 +09006465 overrideBarManifestRule := result.ModuleForTests("bar", "android_common_myoverrideapex_bar").Rule("apexManifestRule")
Sam Delmerico419f9a32023-07-21 12:00:13 -04006466 overrideBarActualDefaultVersion := overrideBarManifestRule.Args["default_version"]
6467 if overrideBarActualDefaultVersion != barExpectedDefaultVersion {
6468 t.Errorf("expected to find defaultVersion %q; got %q", barExpectedDefaultVersion, barActualDefaultVersion)
6469 }
Sam Delmerico6d65a0f2023-06-05 15:55:57 -04006470}
6471
Sam Delmericoca816532023-06-02 14:09:50 -04006472func TestApexAvailable_ApexAvailableName(t *testing.T) {
6473 t.Run("using name of apex that sets apex_available_name is not allowed", func(t *testing.T) {
6474 testApexError(t, "Consider adding \"myapex\" to 'apex_available' property of \"AppFoo\"", `
6475 apex {
6476 name: "myapex_sminus",
6477 key: "myapex.key",
6478 apps: ["AppFoo"],
6479 apex_available_name: "myapex",
6480 updatable: false,
6481 }
6482 apex {
6483 name: "myapex",
6484 key: "myapex.key",
6485 apps: ["AppFoo"],
6486 updatable: false,
6487 }
6488 apex_key {
6489 name: "myapex.key",
6490 public_key: "testkey.avbpubkey",
6491 private_key: "testkey.pem",
6492 }
6493 android_app {
6494 name: "AppFoo",
6495 srcs: ["foo/bar/MyClass.java"],
6496 sdk_version: "none",
6497 system_modules: "none",
6498 apex_available: [ "myapex_sminus" ],
6499 }`,
6500 android.FixtureMergeMockFs(android.MockFS{
6501 "system/sepolicy/apex/myapex_sminus-file_contexts": nil,
6502 }),
6503 )
6504 })
6505
6506 t.Run("apex_available_name allows module to be used in two different apexes", func(t *testing.T) {
6507 testApex(t, `
6508 apex {
6509 name: "myapex_sminus",
6510 key: "myapex.key",
6511 apps: ["AppFoo"],
6512 apex_available_name: "myapex",
6513 updatable: false,
6514 }
6515 apex {
6516 name: "myapex",
6517 key: "myapex.key",
6518 apps: ["AppFoo"],
6519 updatable: false,
6520 }
6521 apex_key {
6522 name: "myapex.key",
6523 public_key: "testkey.avbpubkey",
6524 private_key: "testkey.pem",
6525 }
6526 android_app {
6527 name: "AppFoo",
6528 srcs: ["foo/bar/MyClass.java"],
6529 sdk_version: "none",
6530 system_modules: "none",
6531 apex_available: [ "myapex" ],
6532 }`,
6533 android.FixtureMergeMockFs(android.MockFS{
6534 "system/sepolicy/apex/myapex_sminus-file_contexts": nil,
6535 }),
6536 )
6537 })
6538
6539 t.Run("override_apexes work with apex_available_name", func(t *testing.T) {
6540 testApex(t, `
6541 override_apex {
6542 name: "myoverrideapex_sminus",
6543 base: "myapex_sminus",
6544 key: "myapex.key",
6545 apps: ["AppFooOverride"],
6546 }
6547 override_apex {
6548 name: "myoverrideapex",
6549 base: "myapex",
6550 key: "myapex.key",
6551 apps: ["AppFooOverride"],
6552 }
6553 apex {
6554 name: "myapex_sminus",
6555 key: "myapex.key",
6556 apps: ["AppFoo"],
6557 apex_available_name: "myapex",
6558 updatable: false,
6559 }
6560 apex {
6561 name: "myapex",
6562 key: "myapex.key",
6563 apps: ["AppFoo"],
6564 updatable: false,
6565 }
6566 apex_key {
6567 name: "myapex.key",
6568 public_key: "testkey.avbpubkey",
6569 private_key: "testkey.pem",
6570 }
6571 android_app {
6572 name: "AppFooOverride",
6573 srcs: ["foo/bar/MyClass.java"],
6574 sdk_version: "none",
6575 system_modules: "none",
6576 apex_available: [ "myapex" ],
6577 }
6578 android_app {
6579 name: "AppFoo",
6580 srcs: ["foo/bar/MyClass.java"],
6581 sdk_version: "none",
6582 system_modules: "none",
6583 apex_available: [ "myapex" ],
6584 }`,
6585 android.FixtureMergeMockFs(android.MockFS{
6586 "system/sepolicy/apex/myapex_sminus-file_contexts": nil,
6587 }),
6588 )
6589 })
6590}
6591
6592func TestApexAvailable_ApexAvailableNameWithOverrides(t *testing.T) {
6593 context := android.GroupFixturePreparers(
6594 android.PrepareForIntegrationTestWithAndroid,
6595 PrepareForTestWithApexBuildComponents,
6596 java.PrepareForTestWithDexpreopt,
6597 android.FixtureMergeMockFs(android.MockFS{
6598 "system/sepolicy/apex/myapex-file_contexts": nil,
6599 "system/sepolicy/apex/myapex_sminus-file_contexts": nil,
6600 }),
6601 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
6602 variables.BuildId = proptools.StringPtr("buildid")
6603 }),
6604 )
6605 context.RunTestWithBp(t, `
6606 override_apex {
6607 name: "myoverrideapex_sminus",
6608 base: "myapex_sminus",
6609 }
6610 override_apex {
6611 name: "myoverrideapex",
6612 base: "myapex",
6613 }
6614 apex {
6615 name: "myapex",
6616 key: "myapex.key",
6617 apps: ["AppFoo"],
6618 updatable: false,
6619 }
6620 apex {
6621 name: "myapex_sminus",
6622 apex_available_name: "myapex",
6623 key: "myapex.key",
6624 apps: ["AppFoo_sminus"],
6625 updatable: false,
6626 }
6627 apex_key {
6628 name: "myapex.key",
6629 public_key: "testkey.avbpubkey",
6630 private_key: "testkey.pem",
6631 }
6632 android_app {
6633 name: "AppFoo",
6634 srcs: ["foo/bar/MyClass.java"],
6635 sdk_version: "none",
6636 system_modules: "none",
6637 apex_available: [ "myapex" ],
6638 }
6639 android_app {
6640 name: "AppFoo_sminus",
6641 srcs: ["foo/bar/MyClass.java"],
6642 sdk_version: "none",
6643 min_sdk_version: "29",
6644 system_modules: "none",
6645 apex_available: [ "myapex" ],
6646 }`)
6647}
6648
Jiyong Park89e850a2020-04-07 16:37:39 +09006649func TestApexAvailable_CheckForPlatform(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006650 ctx := testApex(t, `
Jiyong Park127b40b2019-09-30 16:04:35 +09006651 apex {
6652 name: "myapex",
6653 key: "myapex.key",
Jiyong Park89e850a2020-04-07 16:37:39 +09006654 native_shared_libs: ["libbar", "libbaz"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006655 updatable: false,
Jiyong Park127b40b2019-09-30 16:04:35 +09006656 }
6657
6658 apex_key {
6659 name: "myapex.key",
6660 public_key: "testkey.avbpubkey",
6661 private_key: "testkey.pem",
6662 }
6663
6664 cc_library {
6665 name: "libfoo",
6666 stl: "none",
6667 system_shared_libs: [],
Jiyong Park89e850a2020-04-07 16:37:39 +09006668 shared_libs: ["libbar"],
Jiyong Park127b40b2019-09-30 16:04:35 +09006669 apex_available: ["//apex_available:platform"],
Jiyong Park89e850a2020-04-07 16:37:39 +09006670 }
6671
6672 cc_library {
6673 name: "libfoo2",
6674 stl: "none",
6675 system_shared_libs: [],
6676 shared_libs: ["libbaz"],
6677 apex_available: ["//apex_available:platform"],
6678 }
6679
6680 cc_library {
6681 name: "libbar",
6682 stl: "none",
6683 system_shared_libs: [],
6684 apex_available: ["myapex"],
6685 }
6686
6687 cc_library {
6688 name: "libbaz",
6689 stl: "none",
6690 system_shared_libs: [],
6691 apex_available: ["myapex"],
6692 stubs: {
6693 versions: ["1"],
6694 },
Jiyong Park127b40b2019-09-30 16:04:35 +09006695 }`)
6696
Jiyong Park89e850a2020-04-07 16:37:39 +09006697 // libfoo shouldn't be available to platform even though it has "//apex_available:platform",
6698 // because it depends on libbar which isn't available to platform
6699 libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
6700 if libfoo.NotAvailableForPlatform() != true {
6701 t.Errorf("%q shouldn't be available to platform", libfoo.String())
6702 }
6703
6704 // libfoo2 however can be available to platform because it depends on libbaz which provides
6705 // stubs
6706 libfoo2 := ctx.ModuleForTests("libfoo2", "android_arm64_armv8-a_shared").Module().(*cc.Module)
6707 if libfoo2.NotAvailableForPlatform() == true {
6708 t.Errorf("%q should be available to platform", libfoo2.String())
6709 }
Paul Duffine52e66f2020-03-30 17:54:29 +01006710}
Jiyong Parka90ca002019-10-07 15:47:24 +09006711
Paul Duffine52e66f2020-03-30 17:54:29 +01006712func TestApexAvailable_CreatedForApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006713 ctx := testApex(t, `
Jiyong Parka90ca002019-10-07 15:47:24 +09006714 apex {
6715 name: "myapex",
6716 key: "myapex.key",
6717 native_shared_libs: ["libfoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006718 updatable: false,
Jiyong Parka90ca002019-10-07 15:47:24 +09006719 }
6720
6721 apex_key {
6722 name: "myapex.key",
6723 public_key: "testkey.avbpubkey",
6724 private_key: "testkey.pem",
6725 }
6726
6727 cc_library {
6728 name: "libfoo",
6729 stl: "none",
6730 system_shared_libs: [],
6731 apex_available: ["myapex"],
6732 static: {
6733 apex_available: ["//apex_available:platform"],
6734 },
6735 }`)
6736
Jiyong Park89e850a2020-04-07 16:37:39 +09006737 libfooShared := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
6738 if libfooShared.NotAvailableForPlatform() != true {
6739 t.Errorf("%q shouldn't be available to platform", libfooShared.String())
6740 }
6741 libfooStatic := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_static").Module().(*cc.Module)
6742 if libfooStatic.NotAvailableForPlatform() != false {
6743 t.Errorf("%q should be available to platform", libfooStatic.String())
6744 }
Jiyong Park127b40b2019-09-30 16:04:35 +09006745}
6746
Jiyong Park5d790c32019-11-15 18:40:32 +09006747func TestOverrideApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08006748 ctx := testApex(t, `
Jiyong Park5d790c32019-11-15 18:40:32 +09006749 apex {
6750 name: "myapex",
6751 key: "myapex.key",
6752 apps: ["app"],
markchien7c803b82021-08-26 22:10:06 +08006753 bpfs: ["bpf"],
Daniel Norman5a3ce132021-08-26 15:44:43 -07006754 prebuilts: ["myetc"],
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08006755 overrides: ["oldapex"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00006756 updatable: false,
Jiyong Park5d790c32019-11-15 18:40:32 +09006757 }
6758
6759 override_apex {
6760 name: "override_myapex",
6761 base: "myapex",
6762 apps: ["override_app"],
Ken Chen5372a242022-07-07 17:48:06 +08006763 bpfs: ["overrideBpf"],
Daniel Norman5a3ce132021-08-26 15:44:43 -07006764 prebuilts: ["override_myetc"],
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08006765 overrides: ["unknownapex"],
Jesse Melhuishec60e252024-03-29 19:08:20 +00006766 compile_multilib: "first",
6767 multilib: {
6768 lib32: {
6769 native_shared_libs: ["mylib32"],
6770 },
6771 lib64: {
6772 native_shared_libs: ["mylib64"],
6773 },
6774 },
Baligh Uddin004d7172020-02-19 21:29:28 -08006775 logging_parent: "com.foo.bar",
Baligh Uddin5b57dba2020-03-15 13:01:05 -07006776 package_name: "test.overridden.package",
Jaewoong Jung4cfdf7d2021-04-20 16:21:24 -07006777 key: "mynewapex.key",
6778 certificate: ":myapex.certificate",
Jiyong Park5d790c32019-11-15 18:40:32 +09006779 }
6780
6781 apex_key {
6782 name: "myapex.key",
6783 public_key: "testkey.avbpubkey",
6784 private_key: "testkey.pem",
6785 }
6786
Jaewoong Jung4cfdf7d2021-04-20 16:21:24 -07006787 apex_key {
6788 name: "mynewapex.key",
6789 public_key: "testkey2.avbpubkey",
6790 private_key: "testkey2.pem",
6791 }
6792
6793 android_app_certificate {
6794 name: "myapex.certificate",
6795 certificate: "testkey",
6796 }
6797
Jiyong Park5d790c32019-11-15 18:40:32 +09006798 android_app {
6799 name: "app",
6800 srcs: ["foo/bar/MyClass.java"],
6801 package_name: "foo",
6802 sdk_version: "none",
6803 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00006804 apex_available: [ "myapex" ],
Jiyong Park5d790c32019-11-15 18:40:32 +09006805 }
6806
6807 override_android_app {
6808 name: "override_app",
6809 base: "app",
6810 package_name: "bar",
6811 }
markchien7c803b82021-08-26 22:10:06 +08006812
6813 bpf {
6814 name: "bpf",
6815 srcs: ["bpf.c"],
6816 }
6817
6818 bpf {
Ken Chen5372a242022-07-07 17:48:06 +08006819 name: "overrideBpf",
6820 srcs: ["overrideBpf.c"],
markchien7c803b82021-08-26 22:10:06 +08006821 }
Daniel Norman5a3ce132021-08-26 15:44:43 -07006822
6823 prebuilt_etc {
6824 name: "myetc",
6825 src: "myprebuilt",
6826 }
6827
6828 prebuilt_etc {
6829 name: "override_myetc",
6830 src: "override_myprebuilt",
6831 }
Jesse Melhuishec60e252024-03-29 19:08:20 +00006832
6833 cc_library {
6834 name: "mylib32",
6835 apex_available: [ "myapex" ],
6836 }
6837
6838 cc_library {
6839 name: "mylib64",
6840 apex_available: [ "myapex" ],
6841 }
Jiyong Park20bacab2020-03-03 11:45:41 +09006842 `, withManifestPackageNameOverrides([]string{"myapex:com.android.myapex"}))
Jiyong Park5d790c32019-11-15 18:40:32 +09006843
Jooyung Hana0503a52023-08-23 13:12:50 +09006844 originalVariant := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(android.OverridableModule)
6845 overriddenVariant := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex").Module().(android.OverridableModule)
Jiyong Park317645e2019-12-05 13:20:58 +09006846 if originalVariant.GetOverriddenBy() != "" {
6847 t.Errorf("GetOverriddenBy should be empty, but was %q", originalVariant.GetOverriddenBy())
6848 }
6849 if overriddenVariant.GetOverriddenBy() != "override_myapex" {
6850 t.Errorf("GetOverriddenBy should be \"override_myapex\", but was %q", overriddenVariant.GetOverriddenBy())
6851 }
6852
Jooyung Hana0503a52023-08-23 13:12:50 +09006853 module := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex")
Jiyong Park5d790c32019-11-15 18:40:32 +09006854 apexRule := module.Rule("apexRule")
6855 copyCmds := apexRule.Args["copy_commands"]
6856
Oriol Prieto Gasco17e22902022-05-05 13:52:25 +00006857 ensureNotContains(t, copyCmds, "image.apex/app/app@TEST.BUILD_ID/app.apk")
6858 ensureContains(t, copyCmds, "image.apex/app/override_app@TEST.BUILD_ID/override_app.apk")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08006859
markchien7c803b82021-08-26 22:10:06 +08006860 ensureNotContains(t, copyCmds, "image.apex/etc/bpf/bpf.o")
Ken Chen5372a242022-07-07 17:48:06 +08006861 ensureContains(t, copyCmds, "image.apex/etc/bpf/overrideBpf.o")
markchien7c803b82021-08-26 22:10:06 +08006862
Daniel Norman5a3ce132021-08-26 15:44:43 -07006863 ensureNotContains(t, copyCmds, "image.apex/etc/myetc")
6864 ensureContains(t, copyCmds, "image.apex/etc/override_myetc")
6865
Jaewoong Jung1670ca02019-11-22 14:50:42 -08006866 apexBundle := module.Module().(*apexBundle)
6867 name := apexBundle.Name()
6868 if name != "override_myapex" {
6869 t.Errorf("name should be \"override_myapex\", but was %q", name)
6870 }
6871
Baligh Uddin004d7172020-02-19 21:29:28 -08006872 if apexBundle.overridableProperties.Logging_parent != "com.foo.bar" {
6873 t.Errorf("override_myapex should have logging parent (com.foo.bar), but was %q.", apexBundle.overridableProperties.Logging_parent)
6874 }
6875
Jiyong Park20bacab2020-03-03 11:45:41 +09006876 optFlags := apexRule.Args["opt_flags"]
Baligh Uddin5b57dba2020-03-15 13:01:05 -07006877 ensureContains(t, optFlags, "--override_apk_package_name test.overridden.package")
Jaewoong Jung4cfdf7d2021-04-20 16:21:24 -07006878 ensureContains(t, optFlags, "--pubkey testkey2.avbpubkey")
6879
6880 signApkRule := module.Rule("signapk")
6881 ensureEquals(t, signApkRule.Args["certificates"], "testkey.x509.pem testkey.pk8")
Jiyong Park20bacab2020-03-03 11:45:41 +09006882
Colin Crossaa255532020-07-03 13:18:24 -07006883 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jaewoong Jung1670ca02019-11-22 14:50:42 -08006884 var builder strings.Builder
6885 data.Custom(&builder, name, "TARGET_", "", data)
6886 androidMk := builder.String()
Diwas Sharmabb9202e2023-01-26 18:42:21 +00006887 ensureContains(t, androidMk, "LOCAL_MODULE := override_app.override_myapex")
6888 ensureContains(t, androidMk, "LOCAL_MODULE := overrideBpf.o.override_myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08006889 ensureContains(t, androidMk, "LOCAL_MODULE_STEM := override_myapex.apex")
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08006890 ensureContains(t, androidMk, "LOCAL_OVERRIDES_MODULES := unknownapex myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08006891 ensureNotContains(t, androidMk, "LOCAL_MODULE := app.myapex")
markchien7c803b82021-08-26 22:10:06 +08006892 ensureNotContains(t, androidMk, "LOCAL_MODULE := bpf.myapex")
Jiyong Parkf653b052019-11-18 15:39:01 +09006893 ensureNotContains(t, androidMk, "LOCAL_MODULE := override_app.myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08006894 ensureNotContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.apex")
Jiyong Park5d790c32019-11-15 18:40:32 +09006895}
6896
Albert Martineefabcf2022-03-21 20:11:16 +00006897func TestMinSdkVersionOverride(t *testing.T) {
6898 // Override from 29 to 31
6899 minSdkOverride31 := "31"
6900 ctx := testApex(t, `
6901 apex {
6902 name: "myapex",
6903 key: "myapex.key",
6904 native_shared_libs: ["mylib"],
6905 updatable: true,
6906 min_sdk_version: "29"
6907 }
6908
6909 override_apex {
6910 name: "override_myapex",
6911 base: "myapex",
6912 logging_parent: "com.foo.bar",
6913 package_name: "test.overridden.package"
6914 }
6915
6916 apex_key {
6917 name: "myapex.key",
6918 public_key: "testkey.avbpubkey",
6919 private_key: "testkey.pem",
6920 }
6921
6922 cc_library {
6923 name: "mylib",
6924 srcs: ["mylib.cpp"],
6925 runtime_libs: ["libbar"],
6926 system_shared_libs: [],
6927 stl: "none",
6928 apex_available: [ "myapex" ],
6929 min_sdk_version: "apex_inherit"
6930 }
6931
6932 cc_library {
6933 name: "libbar",
6934 srcs: ["mylib.cpp"],
6935 system_shared_libs: [],
6936 stl: "none",
6937 apex_available: [ "myapex" ],
6938 min_sdk_version: "apex_inherit"
6939 }
6940
6941 `, withApexGlobalMinSdkVersionOverride(&minSdkOverride31))
6942
Jooyung Hana0503a52023-08-23 13:12:50 +09006943 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("apexRule")
Albert Martineefabcf2022-03-21 20:11:16 +00006944 copyCmds := apexRule.Args["copy_commands"]
6945
6946 // Ensure that direct non-stubs dep is always included
6947 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
6948
6949 // Ensure that runtime_libs dep in included
6950 ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
6951
6952 // Ensure libraries target overridden min_sdk_version value
6953 ensureListContains(t, ctx.ModuleVariantsForTests("libbar"), "android_arm64_armv8-a_shared_apex31")
6954}
6955
6956func TestMinSdkVersionOverrideToLowerVersionNoOp(t *testing.T) {
6957 // Attempt to override from 31 to 29, should be a NOOP
6958 minSdkOverride29 := "29"
6959 ctx := testApex(t, `
6960 apex {
6961 name: "myapex",
6962 key: "myapex.key",
6963 native_shared_libs: ["mylib"],
6964 updatable: true,
6965 min_sdk_version: "31"
6966 }
6967
6968 override_apex {
6969 name: "override_myapex",
6970 base: "myapex",
6971 logging_parent: "com.foo.bar",
6972 package_name: "test.overridden.package"
6973 }
6974
6975 apex_key {
6976 name: "myapex.key",
6977 public_key: "testkey.avbpubkey",
6978 private_key: "testkey.pem",
6979 }
6980
6981 cc_library {
6982 name: "mylib",
6983 srcs: ["mylib.cpp"],
6984 runtime_libs: ["libbar"],
6985 system_shared_libs: [],
6986 stl: "none",
6987 apex_available: [ "myapex" ],
6988 min_sdk_version: "apex_inherit"
6989 }
6990
6991 cc_library {
6992 name: "libbar",
6993 srcs: ["mylib.cpp"],
6994 system_shared_libs: [],
6995 stl: "none",
6996 apex_available: [ "myapex" ],
6997 min_sdk_version: "apex_inherit"
6998 }
6999
7000 `, withApexGlobalMinSdkVersionOverride(&minSdkOverride29))
7001
Jooyung Hana0503a52023-08-23 13:12:50 +09007002 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("apexRule")
Albert Martineefabcf2022-03-21 20:11:16 +00007003 copyCmds := apexRule.Args["copy_commands"]
7004
7005 // Ensure that direct non-stubs dep is always included
7006 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
7007
7008 // Ensure that runtime_libs dep in included
7009 ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
7010
7011 // Ensure libraries target the original min_sdk_version value rather than the overridden
7012 ensureListContains(t, ctx.ModuleVariantsForTests("libbar"), "android_arm64_armv8-a_shared_apex31")
7013}
7014
Jooyung Han214bf372019-11-12 13:03:50 +09007015func TestLegacyAndroid10Support(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007016 ctx := testApex(t, `
Jooyung Han214bf372019-11-12 13:03:50 +09007017 apex {
7018 name: "myapex",
7019 key: "myapex.key",
Peter Collingbournedc4f9862020-02-12 17:13:25 -08007020 native_shared_libs: ["mylib"],
Jooyung Han5417f772020-03-12 18:37:20 +09007021 min_sdk_version: "29",
Jooyung Han214bf372019-11-12 13:03:50 +09007022 }
7023
7024 apex_key {
7025 name: "myapex.key",
7026 public_key: "testkey.avbpubkey",
7027 private_key: "testkey.pem",
7028 }
Peter Collingbournedc4f9862020-02-12 17:13:25 -08007029
7030 cc_library {
7031 name: "mylib",
7032 srcs: ["mylib.cpp"],
7033 stl: "libc++",
7034 system_shared_libs: [],
7035 apex_available: [ "myapex" ],
Jooyung Han749dc692020-04-15 11:03:39 +09007036 min_sdk_version: "29",
Peter Collingbournedc4f9862020-02-12 17:13:25 -08007037 }
Peter Collingbournedc4f9862020-02-12 17:13:25 -08007038 `, withUnbundledBuild)
Jooyung Han214bf372019-11-12 13:03:50 +09007039
Jooyung Hana0503a52023-08-23 13:12:50 +09007040 module := ctx.ModuleForTests("myapex", "android_common_myapex")
Jooyung Han214bf372019-11-12 13:03:50 +09007041 args := module.Rule("apexRule").Args
7042 ensureContains(t, args["opt_flags"], "--manifest_json "+module.Output("apex_manifest.json").Output.String())
Dario Frenie3546902020-01-14 23:50:25 +00007043 ensureNotContains(t, args["opt_flags"], "--no_hashtree")
Peter Collingbournedc4f9862020-02-12 17:13:25 -08007044
7045 // The copies of the libraries in the apex should have one more dependency than
7046 // the ones outside the apex, namely the unwinder. Ideally we should check
7047 // the dependency names directly here but for some reason the names are blank in
7048 // this test.
7049 for _, lib := range []string{"libc++", "mylib"} {
Colin Crossaede88c2020-08-11 12:17:01 -07007050 apexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared_apex29").Rule("ld").Implicits
Peter Collingbournedc4f9862020-02-12 17:13:25 -08007051 nonApexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared").Rule("ld").Implicits
7052 if len(apexImplicits) != len(nonApexImplicits)+1 {
7053 t.Errorf("%q missing unwinder dep", lib)
7054 }
7055 }
Jooyung Han214bf372019-11-12 13:03:50 +09007056}
7057
Paul Duffine05480a2021-03-08 15:07:14 +00007058var filesForSdkLibrary = android.MockFS{
Paul Duffin9b879592020-05-26 13:21:35 +01007059 "api/current.txt": nil,
7060 "api/removed.txt": nil,
7061 "api/system-current.txt": nil,
7062 "api/system-removed.txt": nil,
7063 "api/test-current.txt": nil,
7064 "api/test-removed.txt": nil,
Paul Duffineedc5d52020-06-12 17:46:39 +01007065
Anton Hanssondff2c782020-12-21 17:10:01 +00007066 "100/public/api/foo.txt": nil,
7067 "100/public/api/foo-removed.txt": nil,
7068 "100/system/api/foo.txt": nil,
7069 "100/system/api/foo-removed.txt": nil,
7070
Paul Duffineedc5d52020-06-12 17:46:39 +01007071 // For java_sdk_library_import
7072 "a.jar": nil,
Paul Duffin9b879592020-05-26 13:21:35 +01007073}
7074
Jooyung Han58f26ab2019-12-18 15:34:32 +09007075func TestJavaSDKLibrary(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007076 ctx := testApex(t, `
Jooyung Han58f26ab2019-12-18 15:34:32 +09007077 apex {
7078 name: "myapex",
7079 key: "myapex.key",
7080 java_libs: ["foo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007081 updatable: false,
Jooyung Han58f26ab2019-12-18 15:34:32 +09007082 }
7083
7084 apex_key {
7085 name: "myapex.key",
7086 public_key: "testkey.avbpubkey",
7087 private_key: "testkey.pem",
7088 }
7089
7090 java_sdk_library {
7091 name: "foo",
7092 srcs: ["a.java"],
7093 api_packages: ["foo"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00007094 apex_available: [ "myapex" ],
Jooyung Han58f26ab2019-12-18 15:34:32 +09007095 }
Anton Hanssondff2c782020-12-21 17:10:01 +00007096
7097 prebuilt_apis {
7098 name: "sdk",
7099 api_dirs: ["100"],
7100 }
Paul Duffin9b879592020-05-26 13:21:35 +01007101 `, withFiles(filesForSdkLibrary))
Jooyung Han58f26ab2019-12-18 15:34:32 +09007102
7103 // java_sdk_library installs both impl jar and permission XML
Jooyung Hana0503a52023-08-23 13:12:50 +09007104 ensureExactContents(t, ctx, "myapex", "android_common_myapex", []string{
Jooyung Han58f26ab2019-12-18 15:34:32 +09007105 "javalib/foo.jar",
7106 "etc/permissions/foo.xml",
7107 })
7108 // Permission XML should point to the activated path of impl jar of java_sdk_library
Paul Duffin1816cde2024-04-10 10:58:21 +01007109 sdkLibrary := ctx.ModuleForTests("foo.xml", "android_common_myapex").Output("foo.xml")
7110 contents := android.ContentFromFileRuleForTests(t, ctx, sdkLibrary)
7111 ensureMatches(t, contents, "<library\\n\\s+name=\\\"foo\\\"\\n\\s+file=\\\"/apex/myapex/javalib/foo.jar\\\"")
Jooyung Han58f26ab2019-12-18 15:34:32 +09007112}
7113
Paul Duffin9b879592020-05-26 13:21:35 +01007114func TestJavaSDKLibrary_WithinApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007115 ctx := testApex(t, `
Paul Duffin9b879592020-05-26 13:21:35 +01007116 apex {
7117 name: "myapex",
7118 key: "myapex.key",
7119 java_libs: ["foo", "bar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007120 updatable: false,
Paul Duffin9b879592020-05-26 13:21:35 +01007121 }
7122
7123 apex_key {
7124 name: "myapex.key",
7125 public_key: "testkey.avbpubkey",
7126 private_key: "testkey.pem",
7127 }
7128
7129 java_sdk_library {
7130 name: "foo",
7131 srcs: ["a.java"],
7132 api_packages: ["foo"],
7133 apex_available: ["myapex"],
7134 sdk_version: "none",
7135 system_modules: "none",
7136 }
7137
7138 java_library {
7139 name: "bar",
7140 srcs: ["a.java"],
7141 libs: ["foo"],
7142 apex_available: ["myapex"],
7143 sdk_version: "none",
7144 system_modules: "none",
7145 }
Anton Hanssondff2c782020-12-21 17:10:01 +00007146
7147 prebuilt_apis {
7148 name: "sdk",
7149 api_dirs: ["100"],
7150 }
Paul Duffin9b879592020-05-26 13:21:35 +01007151 `, withFiles(filesForSdkLibrary))
7152
7153 // java_sdk_library installs both impl jar and permission XML
Jooyung Hana0503a52023-08-23 13:12:50 +09007154 ensureExactContents(t, ctx, "myapex", "android_common_myapex", []string{
Paul Duffin9b879592020-05-26 13:21:35 +01007155 "javalib/bar.jar",
7156 "javalib/foo.jar",
7157 "etc/permissions/foo.xml",
7158 })
7159
7160 // The bar library should depend on the implementation jar.
7161 barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
Jihoon Kanga3a05462024-04-05 00:36:44 +00007162 if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Paul Duffin9b879592020-05-26 13:21:35 +01007163 t.Errorf("expected %q, found %#q", expected, actual)
7164 }
7165}
7166
7167func TestJavaSDKLibrary_CrossBoundary(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007168 ctx := testApex(t, `
Paul Duffin9b879592020-05-26 13:21:35 +01007169 apex {
7170 name: "myapex",
7171 key: "myapex.key",
7172 java_libs: ["foo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007173 updatable: false,
Paul Duffin9b879592020-05-26 13:21:35 +01007174 }
7175
7176 apex_key {
7177 name: "myapex.key",
7178 public_key: "testkey.avbpubkey",
7179 private_key: "testkey.pem",
7180 }
7181
7182 java_sdk_library {
7183 name: "foo",
7184 srcs: ["a.java"],
7185 api_packages: ["foo"],
7186 apex_available: ["myapex"],
7187 sdk_version: "none",
7188 system_modules: "none",
7189 }
7190
7191 java_library {
7192 name: "bar",
7193 srcs: ["a.java"],
7194 libs: ["foo"],
7195 sdk_version: "none",
7196 system_modules: "none",
7197 }
Anton Hanssondff2c782020-12-21 17:10:01 +00007198
7199 prebuilt_apis {
7200 name: "sdk",
7201 api_dirs: ["100"],
7202 }
Paul Duffin9b879592020-05-26 13:21:35 +01007203 `, withFiles(filesForSdkLibrary))
7204
7205 // java_sdk_library installs both impl jar and permission XML
Jooyung Hana0503a52023-08-23 13:12:50 +09007206 ensureExactContents(t, ctx, "myapex", "android_common_myapex", []string{
Paul Duffin9b879592020-05-26 13:21:35 +01007207 "javalib/foo.jar",
7208 "etc/permissions/foo.xml",
7209 })
7210
7211 // The bar library should depend on the stubs jar.
7212 barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
Paul Duffincf8d7db2021-03-29 00:29:53 +01007213 if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Paul Duffin9b879592020-05-26 13:21:35 +01007214 t.Errorf("expected %q, found %#q", expected, actual)
7215 }
7216}
7217
Paul Duffineedc5d52020-06-12 17:46:39 +01007218func TestJavaSDKLibrary_ImportPreferred(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007219 ctx := testApex(t, `
Anton Hanssondff2c782020-12-21 17:10:01 +00007220 prebuilt_apis {
7221 name: "sdk",
7222 api_dirs: ["100"],
7223 }`,
Paul Duffineedc5d52020-06-12 17:46:39 +01007224 withFiles(map[string][]byte{
7225 "apex/a.java": nil,
7226 "apex/apex_manifest.json": nil,
7227 "apex/Android.bp": []byte(`
7228 package {
7229 default_visibility: ["//visibility:private"],
7230 }
7231
7232 apex {
7233 name: "myapex",
7234 key: "myapex.key",
7235 java_libs: ["foo", "bar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007236 updatable: false,
Paul Duffineedc5d52020-06-12 17:46:39 +01007237 }
7238
7239 apex_key {
7240 name: "myapex.key",
7241 public_key: "testkey.avbpubkey",
7242 private_key: "testkey.pem",
7243 }
7244
7245 java_library {
7246 name: "bar",
7247 srcs: ["a.java"],
7248 libs: ["foo"],
7249 apex_available: ["myapex"],
7250 sdk_version: "none",
7251 system_modules: "none",
7252 }
7253`),
7254 "source/a.java": nil,
7255 "source/api/current.txt": nil,
7256 "source/api/removed.txt": nil,
7257 "source/Android.bp": []byte(`
7258 package {
7259 default_visibility: ["//visibility:private"],
7260 }
7261
7262 java_sdk_library {
7263 name: "foo",
7264 visibility: ["//apex"],
7265 srcs: ["a.java"],
7266 api_packages: ["foo"],
7267 apex_available: ["myapex"],
7268 sdk_version: "none",
7269 system_modules: "none",
7270 public: {
7271 enabled: true,
7272 },
7273 }
7274`),
7275 "prebuilt/a.jar": nil,
7276 "prebuilt/Android.bp": []byte(`
7277 package {
7278 default_visibility: ["//visibility:private"],
7279 }
7280
7281 java_sdk_library_import {
7282 name: "foo",
7283 visibility: ["//apex", "//source"],
7284 apex_available: ["myapex"],
7285 prefer: true,
7286 public: {
7287 jars: ["a.jar"],
7288 },
7289 }
7290`),
Anton Hanssondff2c782020-12-21 17:10:01 +00007291 }), withFiles(filesForSdkLibrary),
Paul Duffineedc5d52020-06-12 17:46:39 +01007292 )
7293
7294 // java_sdk_library installs both impl jar and permission XML
Jooyung Hana0503a52023-08-23 13:12:50 +09007295 ensureExactContents(t, ctx, "myapex", "android_common_myapex", []string{
Paul Duffineedc5d52020-06-12 17:46:39 +01007296 "javalib/bar.jar",
7297 "javalib/foo.jar",
7298 "etc/permissions/foo.xml",
7299 })
7300
7301 // The bar library should depend on the implementation jar.
7302 barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
Jihoon Kanga3a05462024-04-05 00:36:44 +00007303 if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Paul Duffineedc5d52020-06-12 17:46:39 +01007304 t.Errorf("expected %q, found %#q", expected, actual)
7305 }
7306}
7307
7308func TestJavaSDKLibrary_ImportOnly(t *testing.T) {
7309 testApexError(t, `java_libs: "foo" is not configured to be compiled into dex`, `
7310 apex {
7311 name: "myapex",
7312 key: "myapex.key",
7313 java_libs: ["foo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007314 updatable: false,
Paul Duffineedc5d52020-06-12 17:46:39 +01007315 }
7316
7317 apex_key {
7318 name: "myapex.key",
7319 public_key: "testkey.avbpubkey",
7320 private_key: "testkey.pem",
7321 }
7322
7323 java_sdk_library_import {
7324 name: "foo",
7325 apex_available: ["myapex"],
7326 prefer: true,
7327 public: {
7328 jars: ["a.jar"],
7329 },
7330 }
7331
7332 `, withFiles(filesForSdkLibrary))
7333}
7334
atrost6e126252020-01-27 17:01:16 +00007335func TestCompatConfig(t *testing.T) {
Paul Duffin284165a2021-03-29 01:50:31 +01007336 result := android.GroupFixturePreparers(
7337 prepareForApexTest,
7338 java.PrepareForTestWithPlatformCompatConfig,
7339 ).RunTestWithBp(t, `
atrost6e126252020-01-27 17:01:16 +00007340 apex {
7341 name: "myapex",
7342 key: "myapex.key",
Paul Duffin3abc1742021-03-15 19:32:23 +00007343 compat_configs: ["myjar-platform-compat-config"],
atrost6e126252020-01-27 17:01:16 +00007344 java_libs: ["myjar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007345 updatable: false,
atrost6e126252020-01-27 17:01:16 +00007346 }
7347
7348 apex_key {
7349 name: "myapex.key",
7350 public_key: "testkey.avbpubkey",
7351 private_key: "testkey.pem",
7352 }
7353
7354 platform_compat_config {
7355 name: "myjar-platform-compat-config",
7356 src: ":myjar",
7357 }
7358
7359 java_library {
7360 name: "myjar",
7361 srcs: ["foo/bar/MyClass.java"],
7362 sdk_version: "none",
7363 system_modules: "none",
atrost6e126252020-01-27 17:01:16 +00007364 apex_available: [ "myapex" ],
7365 }
Paul Duffin1b29e002021-03-16 15:06:54 +00007366
7367 // Make sure that a preferred prebuilt does not affect the apex contents.
7368 prebuilt_platform_compat_config {
7369 name: "myjar-platform-compat-config",
7370 metadata: "compat-config/metadata.xml",
7371 prefer: true,
7372 }
atrost6e126252020-01-27 17:01:16 +00007373 `)
Paul Duffina369c7b2021-03-09 03:08:05 +00007374 ctx := result.TestContext
Jooyung Hana0503a52023-08-23 13:12:50 +09007375 ensureExactContents(t, ctx, "myapex", "android_common_myapex", []string{
atrost6e126252020-01-27 17:01:16 +00007376 "etc/compatconfig/myjar-platform-compat-config.xml",
7377 "javalib/myjar.jar",
7378 })
7379}
7380
Jooyung Han862c0d62022-12-21 10:15:37 +09007381func TestNoDupeApexFiles(t *testing.T) {
7382 android.GroupFixturePreparers(
7383 android.PrepareForTestWithAndroidBuildComponents,
7384 PrepareForTestWithApexBuildComponents,
7385 prepareForTestWithMyapex,
7386 prebuilt_etc.PrepareForTestWithPrebuiltEtc,
7387 ).
7388 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern("is provided by two different files")).
7389 RunTestWithBp(t, `
7390 apex {
7391 name: "myapex",
7392 key: "myapex.key",
7393 prebuilts: ["foo", "bar"],
7394 updatable: false,
7395 }
7396
7397 apex_key {
7398 name: "myapex.key",
7399 public_key: "testkey.avbpubkey",
7400 private_key: "testkey.pem",
7401 }
7402
7403 prebuilt_etc {
7404 name: "foo",
7405 src: "myprebuilt",
7406 filename_from_src: true,
7407 }
7408
7409 prebuilt_etc {
7410 name: "bar",
7411 src: "myprebuilt",
7412 filename_from_src: true,
7413 }
7414 `)
7415}
7416
Jooyung Hana8bd72a2023-11-02 11:56:48 +09007417func TestApexUnwantedTransitiveDeps(t *testing.T) {
7418 bp := `
7419 apex {
7420 name: "myapex",
7421 key: "myapex.key",
7422 native_shared_libs: ["libfoo"],
7423 updatable: false,
7424 unwanted_transitive_deps: ["libbar"],
7425 }
7426
7427 apex_key {
7428 name: "myapex.key",
7429 public_key: "testkey.avbpubkey",
7430 private_key: "testkey.pem",
7431 }
7432
7433 cc_library {
7434 name: "libfoo",
7435 srcs: ["foo.cpp"],
7436 shared_libs: ["libbar"],
7437 apex_available: ["myapex"],
7438 }
7439
7440 cc_library {
7441 name: "libbar",
7442 srcs: ["bar.cpp"],
7443 apex_available: ["myapex"],
7444 }`
7445 ctx := testApex(t, bp)
7446 ensureExactContents(t, ctx, "myapex", "android_common_myapex", []string{
7447 "*/libc++.so",
7448 "*/libfoo.so",
7449 // not libbar.so
7450 })
7451}
7452
Jiyong Park479321d2019-12-16 11:47:12 +09007453func TestRejectNonInstallableJavaLibrary(t *testing.T) {
7454 testApexError(t, `"myjar" is not configured to be compiled into dex`, `
7455 apex {
7456 name: "myapex",
7457 key: "myapex.key",
7458 java_libs: ["myjar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007459 updatable: false,
Jiyong Park479321d2019-12-16 11:47:12 +09007460 }
7461
7462 apex_key {
7463 name: "myapex.key",
7464 public_key: "testkey.avbpubkey",
7465 private_key: "testkey.pem",
7466 }
7467
7468 java_library {
7469 name: "myjar",
7470 srcs: ["foo/bar/MyClass.java"],
7471 sdk_version: "none",
7472 system_modules: "none",
Jiyong Park6b21c7d2020-02-11 09:16:01 +09007473 compile_dex: false,
Jooyung Han5e9013b2020-03-10 06:23:13 +09007474 apex_available: ["myapex"],
Jiyong Park479321d2019-12-16 11:47:12 +09007475 }
7476 `)
7477}
7478
Jiyong Park7afd1072019-12-30 16:56:33 +09007479func TestCarryRequiredModuleNames(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007480 ctx := testApex(t, `
Jiyong Park7afd1072019-12-30 16:56:33 +09007481 apex {
7482 name: "myapex",
7483 key: "myapex.key",
7484 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007485 updatable: false,
Jiyong Park7afd1072019-12-30 16:56:33 +09007486 }
7487
7488 apex_key {
7489 name: "myapex.key",
7490 public_key: "testkey.avbpubkey",
7491 private_key: "testkey.pem",
7492 }
7493
7494 cc_library {
7495 name: "mylib",
7496 srcs: ["mylib.cpp"],
7497 system_shared_libs: [],
7498 stl: "none",
7499 required: ["a", "b"],
7500 host_required: ["c", "d"],
7501 target_required: ["e", "f"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00007502 apex_available: [ "myapex" ],
Jiyong Park7afd1072019-12-30 16:56:33 +09007503 }
7504 `)
7505
Jooyung Hana0503a52023-08-23 13:12:50 +09007506 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07007507 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Jiyong Park7afd1072019-12-30 16:56:33 +09007508 name := apexBundle.BaseModuleName()
7509 prefix := "TARGET_"
7510 var builder strings.Builder
7511 data.Custom(&builder, name, prefix, "", data)
7512 androidMk := builder.String()
Jooyung Haneec1b3f2023-06-20 16:25:59 +09007513 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := mylib.myapex:64 a b\n")
Sasha Smundakdcb61292022-12-08 10:41:33 -08007514 ensureContains(t, androidMk, "LOCAL_HOST_REQUIRED_MODULES := c d\n")
7515 ensureContains(t, androidMk, "LOCAL_TARGET_REQUIRED_MODULES := e f\n")
Jiyong Park7afd1072019-12-30 16:56:33 +09007516}
7517
Jiyong Park7cd10e32020-01-14 09:22:18 +09007518func TestSymlinksFromApexToSystem(t *testing.T) {
7519 bp := `
7520 apex {
7521 name: "myapex",
7522 key: "myapex.key",
7523 native_shared_libs: ["mylib"],
7524 java_libs: ["myjar"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007525 updatable: false,
Jiyong Park7cd10e32020-01-14 09:22:18 +09007526 }
7527
Jiyong Park9d677202020-02-19 16:29:35 +09007528 apex {
7529 name: "myapex.updatable",
7530 key: "myapex.key",
7531 native_shared_libs: ["mylib"],
7532 java_libs: ["myjar"],
7533 updatable: true,
Spandan Das1a92db52023-04-06 18:55:06 +00007534 min_sdk_version: "33",
Jiyong Park9d677202020-02-19 16:29:35 +09007535 }
7536
Jiyong Park7cd10e32020-01-14 09:22:18 +09007537 apex_key {
7538 name: "myapex.key",
7539 public_key: "testkey.avbpubkey",
7540 private_key: "testkey.pem",
7541 }
7542
7543 cc_library {
7544 name: "mylib",
7545 srcs: ["mylib.cpp"],
Jiyong Parkce243632023-02-17 18:22:25 +09007546 shared_libs: [
7547 "myotherlib",
7548 "myotherlib_ext",
7549 ],
Jiyong Park7cd10e32020-01-14 09:22:18 +09007550 system_shared_libs: [],
7551 stl: "none",
7552 apex_available: [
7553 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09007554 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09007555 "//apex_available:platform",
7556 ],
Spandan Das1a92db52023-04-06 18:55:06 +00007557 min_sdk_version: "33",
Jiyong Park7cd10e32020-01-14 09:22:18 +09007558 }
7559
7560 cc_library {
7561 name: "myotherlib",
7562 srcs: ["mylib.cpp"],
7563 system_shared_libs: [],
7564 stl: "none",
7565 apex_available: [
7566 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09007567 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09007568 "//apex_available:platform",
7569 ],
Spandan Das1a92db52023-04-06 18:55:06 +00007570 min_sdk_version: "33",
Jiyong Park7cd10e32020-01-14 09:22:18 +09007571 }
7572
Jiyong Parkce243632023-02-17 18:22:25 +09007573 cc_library {
7574 name: "myotherlib_ext",
7575 srcs: ["mylib.cpp"],
7576 system_shared_libs: [],
7577 system_ext_specific: true,
7578 stl: "none",
7579 apex_available: [
7580 "myapex",
7581 "myapex.updatable",
7582 "//apex_available:platform",
7583 ],
Spandan Das1a92db52023-04-06 18:55:06 +00007584 min_sdk_version: "33",
Jiyong Parkce243632023-02-17 18:22:25 +09007585 }
7586
Jiyong Park7cd10e32020-01-14 09:22:18 +09007587 java_library {
7588 name: "myjar",
7589 srcs: ["foo/bar/MyClass.java"],
7590 sdk_version: "none",
7591 system_modules: "none",
7592 libs: ["myotherjar"],
Jiyong Park7cd10e32020-01-14 09:22:18 +09007593 apex_available: [
7594 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09007595 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09007596 "//apex_available:platform",
7597 ],
Spandan Das1a92db52023-04-06 18:55:06 +00007598 min_sdk_version: "33",
Jiyong Park7cd10e32020-01-14 09:22:18 +09007599 }
7600
7601 java_library {
7602 name: "myotherjar",
7603 srcs: ["foo/bar/MyClass.java"],
7604 sdk_version: "none",
7605 system_modules: "none",
7606 apex_available: [
7607 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09007608 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09007609 "//apex_available:platform",
7610 ],
Spandan Das1a92db52023-04-06 18:55:06 +00007611 min_sdk_version: "33",
Jiyong Park7cd10e32020-01-14 09:22:18 +09007612 }
7613 `
7614
7615 ensureRealfileExists := func(t *testing.T, files []fileInApex, file string) {
7616 for _, f := range files {
7617 if f.path == file {
7618 if f.isLink {
7619 t.Errorf("%q is not a real file", file)
7620 }
7621 return
7622 }
7623 }
7624 t.Errorf("%q is not found", file)
7625 }
7626
Jiyong Parkce243632023-02-17 18:22:25 +09007627 ensureSymlinkExists := func(t *testing.T, files []fileInApex, file string, target string) {
Jiyong Park7cd10e32020-01-14 09:22:18 +09007628 for _, f := range files {
7629 if f.path == file {
7630 if !f.isLink {
7631 t.Errorf("%q is not a symlink", file)
7632 }
Jiyong Parkce243632023-02-17 18:22:25 +09007633 if f.src != target {
7634 t.Errorf("expected symlink target to be %q, got %q", target, f.src)
7635 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09007636 return
7637 }
7638 }
7639 t.Errorf("%q is not found", file)
7640 }
7641
Jiyong Park9d677202020-02-19 16:29:35 +09007642 // For unbundled build, symlink shouldn't exist regardless of whether an APEX
7643 // is updatable or not
Colin Cross1c460562021-02-16 17:55:47 -08007644 ctx := testApex(t, bp, withUnbundledBuild)
Jooyung Hana0503a52023-08-23 13:12:50 +09007645 files := getFiles(t, ctx, "myapex", "android_common_myapex")
Jiyong Park7cd10e32020-01-14 09:22:18 +09007646 ensureRealfileExists(t, files, "javalib/myjar.jar")
7647 ensureRealfileExists(t, files, "lib64/mylib.so")
7648 ensureRealfileExists(t, files, "lib64/myotherlib.so")
Jiyong Parkce243632023-02-17 18:22:25 +09007649 ensureRealfileExists(t, files, "lib64/myotherlib_ext.so")
Jiyong Park7cd10e32020-01-14 09:22:18 +09007650
Jooyung Hana0503a52023-08-23 13:12:50 +09007651 files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable")
Jiyong Park9d677202020-02-19 16:29:35 +09007652 ensureRealfileExists(t, files, "javalib/myjar.jar")
7653 ensureRealfileExists(t, files, "lib64/mylib.so")
7654 ensureRealfileExists(t, files, "lib64/myotherlib.so")
Jiyong Parkce243632023-02-17 18:22:25 +09007655 ensureRealfileExists(t, files, "lib64/myotherlib_ext.so")
Jiyong Park9d677202020-02-19 16:29:35 +09007656
7657 // For bundled build, symlink to the system for the non-updatable APEXes only
Colin Cross1c460562021-02-16 17:55:47 -08007658 ctx = testApex(t, bp)
Jooyung Hana0503a52023-08-23 13:12:50 +09007659 files = getFiles(t, ctx, "myapex", "android_common_myapex")
Jiyong Park7cd10e32020-01-14 09:22:18 +09007660 ensureRealfileExists(t, files, "javalib/myjar.jar")
7661 ensureRealfileExists(t, files, "lib64/mylib.so")
Jiyong Parkce243632023-02-17 18:22:25 +09007662 ensureSymlinkExists(t, files, "lib64/myotherlib.so", "/system/lib64/myotherlib.so") // this is symlink
7663 ensureSymlinkExists(t, files, "lib64/myotherlib_ext.so", "/system_ext/lib64/myotherlib_ext.so") // this is symlink
Jiyong Park9d677202020-02-19 16:29:35 +09007664
Jooyung Hana0503a52023-08-23 13:12:50 +09007665 files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable")
Jiyong Park9d677202020-02-19 16:29:35 +09007666 ensureRealfileExists(t, files, "javalib/myjar.jar")
7667 ensureRealfileExists(t, files, "lib64/mylib.so")
Jiyong Parkce243632023-02-17 18:22:25 +09007668 ensureRealfileExists(t, files, "lib64/myotherlib.so") // this is a real file
7669 ensureRealfileExists(t, files, "lib64/myotherlib_ext.so") // this is a real file
Jiyong Park7cd10e32020-01-14 09:22:18 +09007670}
7671
Yo Chiange8128052020-07-23 20:09:18 +08007672func TestSymlinksFromApexToSystemRequiredModuleNames(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007673 ctx := testApex(t, `
Yo Chiange8128052020-07-23 20:09:18 +08007674 apex {
7675 name: "myapex",
7676 key: "myapex.key",
7677 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007678 updatable: false,
Yo Chiange8128052020-07-23 20:09:18 +08007679 }
7680
7681 apex_key {
7682 name: "myapex.key",
7683 public_key: "testkey.avbpubkey",
7684 private_key: "testkey.pem",
7685 }
7686
7687 cc_library_shared {
7688 name: "mylib",
7689 srcs: ["mylib.cpp"],
7690 shared_libs: ["myotherlib"],
7691 system_shared_libs: [],
7692 stl: "none",
7693 apex_available: [
7694 "myapex",
7695 "//apex_available:platform",
7696 ],
7697 }
7698
7699 cc_prebuilt_library_shared {
7700 name: "myotherlib",
7701 srcs: ["prebuilt.so"],
7702 system_shared_libs: [],
7703 stl: "none",
7704 apex_available: [
7705 "myapex",
7706 "//apex_available:platform",
7707 ],
7708 }
7709 `)
7710
Jooyung Hana0503a52023-08-23 13:12:50 +09007711 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07007712 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
Yo Chiange8128052020-07-23 20:09:18 +08007713 var builder strings.Builder
7714 data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
7715 androidMk := builder.String()
7716 // `myotherlib` is added to `myapex` as symlink
Diwas Sharmabb9202e2023-01-26 18:42:21 +00007717 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
Yo Chiange8128052020-07-23 20:09:18 +08007718 ensureNotContains(t, androidMk, "LOCAL_MODULE := prebuilt_myotherlib.myapex\n")
7719 ensureNotContains(t, androidMk, "LOCAL_MODULE := myotherlib.myapex\n")
7720 // `myapex` should have `myotherlib` in its required line, not `prebuilt_myotherlib`
Jooyung Haneec1b3f2023-06-20 16:25:59 +09007721 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := mylib.myapex:64 myotherlib:64\n")
Yo Chiange8128052020-07-23 20:09:18 +08007722}
7723
Jooyung Han643adc42020-02-27 13:50:06 +09007724func TestApexWithJniLibs(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007725 ctx := testApex(t, `
Jooyung Han643adc42020-02-27 13:50:06 +09007726 apex {
7727 name: "myapex",
7728 key: "myapex.key",
Jiakai Zhang9c60c172023-09-05 15:19:21 +01007729 binaries: ["mybin"],
7730 jni_libs: ["mylib", "mylib3", "libfoo.rust"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007731 updatable: false,
Jooyung Han643adc42020-02-27 13:50:06 +09007732 }
7733
7734 apex_key {
7735 name: "myapex.key",
7736 public_key: "testkey.avbpubkey",
7737 private_key: "testkey.pem",
7738 }
7739
7740 cc_library {
7741 name: "mylib",
7742 srcs: ["mylib.cpp"],
7743 shared_libs: ["mylib2"],
7744 system_shared_libs: [],
7745 stl: "none",
7746 apex_available: [ "myapex" ],
7747 }
7748
7749 cc_library {
7750 name: "mylib2",
7751 srcs: ["mylib.cpp"],
7752 system_shared_libs: [],
7753 stl: "none",
7754 apex_available: [ "myapex" ],
7755 }
Jiyong Park34d5c332022-02-24 18:02:44 +09007756
Jiakai Zhang9c60c172023-09-05 15:19:21 +01007757 // Used as both a JNI library and a regular shared library.
7758 cc_library {
7759 name: "mylib3",
7760 srcs: ["mylib.cpp"],
7761 system_shared_libs: [],
7762 stl: "none",
7763 apex_available: [ "myapex" ],
7764 }
7765
7766 cc_binary {
7767 name: "mybin",
7768 srcs: ["mybin.cpp"],
7769 shared_libs: ["mylib3"],
7770 system_shared_libs: [],
7771 stl: "none",
7772 apex_available: [ "myapex" ],
7773 }
7774
Jiyong Park34d5c332022-02-24 18:02:44 +09007775 rust_ffi_shared {
7776 name: "libfoo.rust",
7777 crate_name: "foo",
7778 srcs: ["foo.rs"],
7779 shared_libs: ["libfoo.shared_from_rust"],
7780 prefer_rlib: true,
7781 apex_available: ["myapex"],
7782 }
7783
7784 cc_library_shared {
7785 name: "libfoo.shared_from_rust",
7786 srcs: ["mylib.cpp"],
7787 system_shared_libs: [],
7788 stl: "none",
7789 stubs: {
7790 versions: ["10", "11", "12"],
7791 },
7792 }
7793
Jooyung Han643adc42020-02-27 13:50:06 +09007794 `)
7795
Jooyung Hana0503a52023-08-23 13:12:50 +09007796 rule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("apexManifestRule")
Jooyung Han643adc42020-02-27 13:50:06 +09007797 // Notice mylib2.so (transitive dep) is not added as a jni_lib
Jiakai Zhang9c60c172023-09-05 15:19:21 +01007798 ensureEquals(t, rule.Args["opt"], "-a jniLibs libfoo.rust.so mylib.so mylib3.so")
Jooyung Hana0503a52023-08-23 13:12:50 +09007799 ensureExactContents(t, ctx, "myapex", "android_common_myapex", []string{
Jiakai Zhang9c60c172023-09-05 15:19:21 +01007800 "bin/mybin",
Jooyung Han643adc42020-02-27 13:50:06 +09007801 "lib64/mylib.so",
7802 "lib64/mylib2.so",
Jiakai Zhang9c60c172023-09-05 15:19:21 +01007803 "lib64/mylib3.so",
Jiyong Park34d5c332022-02-24 18:02:44 +09007804 "lib64/libfoo.rust.so",
7805 "lib64/libc++.so", // auto-added to libfoo.rust by Soong
7806 "lib64/liblog.so", // auto-added to libfoo.rust by Soong
Jooyung Han643adc42020-02-27 13:50:06 +09007807 })
Jiyong Park34d5c332022-02-24 18:02:44 +09007808
7809 // b/220397949
7810 ensureListContains(t, names(rule.Args["requireNativeLibs"]), "libfoo.shared_from_rust.so")
Jooyung Han643adc42020-02-27 13:50:06 +09007811}
7812
Jooyung Han49f67012020-04-17 13:43:10 +09007813func TestApexMutatorsDontRunIfDisabled(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007814 ctx := testApex(t, `
Jooyung Han49f67012020-04-17 13:43:10 +09007815 apex {
7816 name: "myapex",
7817 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007818 updatable: false,
Jooyung Han49f67012020-04-17 13:43:10 +09007819 }
7820 apex_key {
7821 name: "myapex.key",
7822 public_key: "testkey.avbpubkey",
7823 private_key: "testkey.pem",
7824 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00007825 `,
7826 android.FixtureModifyConfig(func(config android.Config) {
7827 delete(config.Targets, android.Android)
7828 config.AndroidCommonTarget = android.Target{}
7829 }),
7830 )
Jooyung Han49f67012020-04-17 13:43:10 +09007831
7832 if expected, got := []string{""}, ctx.ModuleVariantsForTests("myapex"); !reflect.DeepEqual(expected, got) {
7833 t.Errorf("Expected variants: %v, but got: %v", expected, got)
7834 }
7835}
7836
Jiyong Parkbd159612020-02-28 15:22:21 +09007837func TestAppBundle(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007838 ctx := testApex(t, `
Jiyong Parkbd159612020-02-28 15:22:21 +09007839 apex {
7840 name: "myapex",
7841 key: "myapex.key",
7842 apps: ["AppFoo"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007843 updatable: false,
Jiyong Parkbd159612020-02-28 15:22:21 +09007844 }
7845
7846 apex_key {
7847 name: "myapex.key",
7848 public_key: "testkey.avbpubkey",
7849 private_key: "testkey.pem",
7850 }
7851
7852 android_app {
7853 name: "AppFoo",
7854 srcs: ["foo/bar/MyClass.java"],
7855 sdk_version: "none",
7856 system_modules: "none",
7857 apex_available: [ "myapex" ],
7858 }
Jiyong Parkcfaa1642020-02-28 16:51:07 +09007859 `, withManifestPackageNameOverrides([]string{"AppFoo:com.android.foo"}))
Jiyong Parkbd159612020-02-28 15:22:21 +09007860
Jooyung Hana0503a52023-08-23 13:12:50 +09007861 bundleConfigRule := ctx.ModuleForTests("myapex", "android_common_myapex").Output("bundle_config.json")
Colin Crossf61d03d2023-11-02 16:56:39 -07007862 content := android.ContentFromFileRuleForTests(t, ctx, bundleConfigRule)
Jiyong Parkbd159612020-02-28 15:22:21 +09007863
7864 ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
Oriol Prieto Gasco17e22902022-05-05 13:52:25 +00007865 ensureContains(t, content, `"apex_config":{"apex_embedded_apk_config":[{"package_name":"com.android.foo","path":"app/AppFoo@TEST.BUILD_ID/AppFoo.apk"}]}`)
Jiyong Parkbd159612020-02-28 15:22:21 +09007866}
7867
Sasha Smundak18d98bc2020-05-27 16:36:07 -07007868func TestAppSetBundle(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08007869 ctx := testApex(t, `
Sasha Smundak18d98bc2020-05-27 16:36:07 -07007870 apex {
7871 name: "myapex",
7872 key: "myapex.key",
7873 apps: ["AppSet"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00007874 updatable: false,
Sasha Smundak18d98bc2020-05-27 16:36:07 -07007875 }
7876
7877 apex_key {
7878 name: "myapex.key",
7879 public_key: "testkey.avbpubkey",
7880 private_key: "testkey.pem",
7881 }
7882
7883 android_app_set {
7884 name: "AppSet",
7885 set: "AppSet.apks",
7886 }`)
Jooyung Hana0503a52023-08-23 13:12:50 +09007887 mod := ctx.ModuleForTests("myapex", "android_common_myapex")
Colin Crosscf371cc2020-11-13 11:48:42 -08007888 bundleConfigRule := mod.Output("bundle_config.json")
Colin Crossf61d03d2023-11-02 16:56:39 -07007889 content := android.ContentFromFileRuleForTests(t, ctx, bundleConfigRule)
Sasha Smundak18d98bc2020-05-27 16:36:07 -07007890 ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
7891 s := mod.Rule("apexRule").Args["copy_commands"]
7892 copyCmds := regexp.MustCompile(" *&& *").Split(s, -1)
Jiyong Park4169a252022-09-29 21:30:25 +09007893 if len(copyCmds) != 4 {
7894 t.Fatalf("Expected 4 commands, got %d in:\n%s", len(copyCmds), s)
Sasha Smundak18d98bc2020-05-27 16:36:07 -07007895 }
Oriol Prieto Gasco17e22902022-05-05 13:52:25 +00007896 ensureMatches(t, copyCmds[0], "^rm -rf .*/app/AppSet@TEST.BUILD_ID$")
7897 ensureMatches(t, copyCmds[1], "^mkdir -p .*/app/AppSet@TEST.BUILD_ID$")
Jiyong Park4169a252022-09-29 21:30:25 +09007898 ensureMatches(t, copyCmds[2], "^cp -f .*/app/AppSet@TEST.BUILD_ID/AppSet.apk$")
7899 ensureMatches(t, copyCmds[3], "^unzip .*-d .*/app/AppSet@TEST.BUILD_ID .*/AppSet.zip$")
Jiyong Parke1b69142022-09-26 14:48:56 +09007900
7901 // Ensure that canned_fs_config has an entry for the app set zip file
7902 generateFsRule := mod.Rule("generateFsConfig")
7903 cmd := generateFsRule.RuleParams.Command
7904 ensureContains(t, cmd, "AppSet.zip")
Sasha Smundak18d98bc2020-05-27 16:36:07 -07007905}
7906
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07007907func TestAppSetBundlePrebuilt(t *testing.T) {
Paul Duffin24704672021-04-06 16:09:30 +01007908 bp := `
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07007909 apex_set {
7910 name: "myapex",
7911 filename: "foo_v2.apex",
7912 sanitized: {
7913 none: { set: "myapex.apks", },
7914 hwaddress: { set: "myapex.hwasan.apks", },
7915 },
Paul Duffin24704672021-04-06 16:09:30 +01007916 }
7917 `
7918 ctx := testApex(t, bp, prepareForTestWithSantitizeHwaddress)
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07007919
Paul Duffin24704672021-04-06 16:09:30 +01007920 // Check that the extractor produces the correct output file from the correct input file.
Spandan Das3576e762024-01-03 18:57:03 +00007921 extractorOutput := "out/soong/.intermediates/prebuilt_myapex.apex.extractor/android_common/extracted/myapex.hwasan.apks"
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07007922
Spandan Das3576e762024-01-03 18:57:03 +00007923 m := ctx.ModuleForTests("prebuilt_myapex.apex.extractor", "android_common")
Paul Duffin24704672021-04-06 16:09:30 +01007924 extractedApex := m.Output(extractorOutput)
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07007925
Paul Duffin24704672021-04-06 16:09:30 +01007926 android.AssertArrayString(t, "extractor input", []string{"myapex.hwasan.apks"}, extractedApex.Inputs.Strings())
7927
7928 // Ditto for the apex.
Paul Duffin6717d882021-06-15 19:09:41 +01007929 m = ctx.ModuleForTests("myapex", "android_common_myapex")
7930 copiedApex := m.Output("out/soong/.intermediates/myapex/android_common_myapex/foo_v2.apex")
Paul Duffin24704672021-04-06 16:09:30 +01007931
7932 android.AssertStringEquals(t, "myapex input", extractorOutput, copiedApex.Input.String())
Evgenii Stepanov2080bfe2020-07-24 15:35:40 -07007933}
7934
Pranav Guptaeba03b02022-09-27 00:27:08 +00007935func TestApexSetApksModuleAssignment(t *testing.T) {
7936 ctx := testApex(t, `
7937 apex_set {
7938 name: "myapex",
7939 set: ":myapex_apks_file",
7940 }
7941
7942 filegroup {
7943 name: "myapex_apks_file",
7944 srcs: ["myapex.apks"],
7945 }
7946 `)
7947
Spandan Das3576e762024-01-03 18:57:03 +00007948 m := ctx.ModuleForTests("prebuilt_myapex.apex.extractor", "android_common")
Pranav Guptaeba03b02022-09-27 00:27:08 +00007949
7950 // Check that the extractor produces the correct apks file from the input module
Spandan Das3576e762024-01-03 18:57:03 +00007951 extractorOutput := "out/soong/.intermediates/prebuilt_myapex.apex.extractor/android_common/extracted/myapex.apks"
Pranav Guptaeba03b02022-09-27 00:27:08 +00007952 extractedApex := m.Output(extractorOutput)
7953
7954 android.AssertArrayString(t, "extractor input", []string{"myapex.apks"}, extractedApex.Inputs.Strings())
7955}
7956
Paul Duffin89f570a2021-06-16 01:42:33 +01007957func testDexpreoptWithApexes(t *testing.T, bp, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) *android.TestContext {
Paul Duffinc3bbb962020-12-10 19:15:49 +00007958 t.Helper()
7959
Paul Duffin55607122021-03-30 23:32:51 +01007960 fs := android.MockFS{
7961 "a.java": nil,
7962 "a.jar": nil,
7963 "apex_manifest.json": nil,
7964 "AndroidManifest.xml": nil,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00007965 "system/sepolicy/apex/myapex-file_contexts": nil,
Paul Duffind376f792021-01-26 11:59:35 +00007966 "system/sepolicy/apex/some-updatable-apex-file_contexts": nil,
7967 "system/sepolicy/apex/some-non-updatable-apex-file_contexts": nil,
7968 "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
Martin Stjernholm1dc0d6d2021-01-17 21:05:12 +00007969 "framework/aidl/a.aidl": nil,
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00007970 }
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00007971
Paul Duffin55607122021-03-30 23:32:51 +01007972 errorHandler := android.FixtureExpectsNoErrors
7973 if errmsg != "" {
7974 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00007975 }
Paul Duffin064b70c2020-11-02 17:32:38 +00007976
Paul Duffin55607122021-03-30 23:32:51 +01007977 result := android.GroupFixturePreparers(
7978 cc.PrepareForTestWithCcDefaultModules,
7979 java.PrepareForTestWithHiddenApiBuildComponents,
Jiakai Zhangb69e8952023-07-11 14:31:22 +01007980 java.PrepareForTestWithDexpreopt,
Paul Duffin55607122021-03-30 23:32:51 +01007981 java.PrepareForTestWithJavaSdkLibraryFiles,
7982 PrepareForTestWithApexBuildComponents,
Paul Duffin60264a02021-04-12 20:02:36 +01007983 preparer,
Paul Duffin55607122021-03-30 23:32:51 +01007984 fs.AddToFixture(),
Paul Duffin89f570a2021-06-16 01:42:33 +01007985 android.FixtureModifyMockFS(func(fs android.MockFS) {
7986 if _, ok := fs["frameworks/base/boot/Android.bp"]; !ok {
7987 insert := ""
7988 for _, fragment := range fragments {
7989 insert += fmt.Sprintf("{apex: %q, module: %q},\n", *fragment.Apex, *fragment.Module)
7990 }
7991 fs["frameworks/base/boot/Android.bp"] = []byte(fmt.Sprintf(`
7992 platform_bootclasspath {
7993 name: "platform-bootclasspath",
7994 fragments: [
Jiakai Zhangb69e8952023-07-11 14:31:22 +01007995 {apex: "com.android.art", module: "art-bootclasspath-fragment"},
Paul Duffin89f570a2021-06-16 01:42:33 +01007996 %s
7997 ],
7998 }
7999 `, insert))
Paul Duffin8f146b92021-04-12 17:24:18 +01008000 }
Paul Duffin89f570a2021-06-16 01:42:33 +01008001 }),
Jiakai Zhangb69e8952023-07-11 14:31:22 +01008002 // Dexpreopt for boot jars requires the ART boot image profile.
8003 java.PrepareApexBootJarModule("com.android.art", "core-oj"),
8004 dexpreopt.FixtureSetArtBootJars("com.android.art:core-oj"),
Jiakai Zhang49b1eb62021-11-26 18:09:27 +00008005 dexpreopt.FixtureSetBootImageProfiles("art/build/boot/boot-image-profile.txt"),
Paul Duffin55607122021-03-30 23:32:51 +01008006 ).
8007 ExtendWithErrorHandler(errorHandler).
8008 RunTestWithBp(t, bp)
8009
8010 return result.TestContext
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00008011}
8012
Paul Duffin5556c5f2022-06-09 17:32:21 +00008013func TestDuplicateDeapexersFromPrebuiltApexes(t *testing.T) {
Martin Stjernholm43c44b02021-06-30 16:35:07 +01008014 preparers := android.GroupFixturePreparers(
8015 java.PrepareForTestWithJavaDefaultModules,
Spandan Das5be63332023-12-13 00:06:32 +00008016 prepareForTestWithBootclasspathFragment,
8017 dexpreopt.FixtureSetTestOnlyArtBootImageJars("com.android.art:libfoo"),
Martin Stjernholm43c44b02021-06-30 16:35:07 +01008018 PrepareForTestWithApexBuildComponents,
8019 ).
8020 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(
Spandan Das3576e762024-01-03 18:57:03 +00008021 "Multiple installable prebuilt APEXes provide ambiguous deapexers: prebuilt_com.android.art and prebuilt_com.mycompany.android.art"))
Martin Stjernholm43c44b02021-06-30 16:35:07 +01008022
8023 bpBase := `
8024 apex_set {
Spandan Das5be63332023-12-13 00:06:32 +00008025 name: "com.android.art",
Martin Stjernholm43c44b02021-06-30 16:35:07 +01008026 installable: true,
Spandan Das5be63332023-12-13 00:06:32 +00008027 exported_bootclasspath_fragments: ["art-bootclasspath-fragment"],
Martin Stjernholm43c44b02021-06-30 16:35:07 +01008028 set: "myapex.apks",
8029 }
8030
8031 apex_set {
Spandan Das5be63332023-12-13 00:06:32 +00008032 name: "com.mycompany.android.art",
8033 apex_name: "com.android.art",
Martin Stjernholm43c44b02021-06-30 16:35:07 +01008034 installable: true,
Spandan Das5be63332023-12-13 00:06:32 +00008035 exported_bootclasspath_fragments: ["art-bootclasspath-fragment"],
Martin Stjernholm43c44b02021-06-30 16:35:07 +01008036 set: "company-myapex.apks",
8037 }
8038
8039 prebuilt_bootclasspath_fragment {
Spandan Das5be63332023-12-13 00:06:32 +00008040 name: "art-bootclasspath-fragment",
8041 apex_available: ["com.android.art"],
Spandan Dasfae468e2023-12-12 23:23:53 +00008042 hidden_api: {
8043 annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
8044 metadata: "my-bootclasspath-fragment/metadata.csv",
8045 index: "my-bootclasspath-fragment/index.csv",
8046 stub_flags: "my-bootclasspath-fragment/stub-flags.csv",
8047 all_flags: "my-bootclasspath-fragment/all-flags.csv",
8048 },
Martin Stjernholm43c44b02021-06-30 16:35:07 +01008049 %s
8050 }
8051 `
8052
8053 t.Run("java_import", func(t *testing.T) {
8054 _ = preparers.RunTestWithBp(t, fmt.Sprintf(bpBase, `contents: ["libfoo"]`)+`
8055 java_import {
8056 name: "libfoo",
8057 jars: ["libfoo.jar"],
Spandan Das5be63332023-12-13 00:06:32 +00008058 apex_available: ["com.android.art"],
Martin Stjernholm43c44b02021-06-30 16:35:07 +01008059 }
8060 `)
8061 })
8062
8063 t.Run("java_sdk_library_import", func(t *testing.T) {
8064 _ = preparers.RunTestWithBp(t, fmt.Sprintf(bpBase, `contents: ["libfoo"]`)+`
8065 java_sdk_library_import {
8066 name: "libfoo",
8067 public: {
8068 jars: ["libbar.jar"],
8069 },
Spandan Dasfae468e2023-12-12 23:23:53 +00008070 shared_library: false,
Spandan Das5be63332023-12-13 00:06:32 +00008071 apex_available: ["com.android.art"],
Martin Stjernholm43c44b02021-06-30 16:35:07 +01008072 }
8073 `)
8074 })
8075
8076 t.Run("prebuilt_bootclasspath_fragment", func(t *testing.T) {
8077 _ = preparers.RunTestWithBp(t, fmt.Sprintf(bpBase, `
8078 image_name: "art",
8079 contents: ["libfoo"],
8080 `)+`
8081 java_sdk_library_import {
8082 name: "libfoo",
8083 public: {
8084 jars: ["libbar.jar"],
8085 },
Spandan Dasfae468e2023-12-12 23:23:53 +00008086 shared_library: false,
Spandan Das5be63332023-12-13 00:06:32 +00008087 apex_available: ["com.android.art"],
Martin Stjernholm43c44b02021-06-30 16:35:07 +01008088 }
8089 `)
8090 })
8091}
8092
Paul Duffin5556c5f2022-06-09 17:32:21 +00008093func TestDuplicateButEquivalentDeapexersFromPrebuiltApexes(t *testing.T) {
8094 preparers := android.GroupFixturePreparers(
8095 java.PrepareForTestWithJavaDefaultModules,
8096 PrepareForTestWithApexBuildComponents,
8097 )
8098
Spandan Das59a4a2b2024-01-09 21:35:56 +00008099 errCtx := moduleErrorfTestCtx{}
8100
Paul Duffin5556c5f2022-06-09 17:32:21 +00008101 bpBase := `
8102 apex_set {
8103 name: "com.android.myapex",
8104 installable: true,
8105 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
8106 set: "myapex.apks",
8107 }
8108
8109 apex_set {
8110 name: "com.android.myapex_compressed",
8111 apex_name: "com.android.myapex",
8112 installable: true,
8113 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
8114 set: "myapex_compressed.apks",
8115 }
8116
8117 prebuilt_bootclasspath_fragment {
8118 name: "my-bootclasspath-fragment",
8119 apex_available: [
8120 "com.android.myapex",
8121 "com.android.myapex_compressed",
8122 ],
8123 hidden_api: {
8124 annotation_flags: "annotation-flags.csv",
8125 metadata: "metadata.csv",
8126 index: "index.csv",
8127 signature_patterns: "signature_patterns.csv",
8128 },
8129 %s
8130 }
8131 `
8132
8133 t.Run("java_import", func(t *testing.T) {
8134 result := preparers.RunTestWithBp(t,
8135 fmt.Sprintf(bpBase, `contents: ["libfoo"]`)+`
8136 java_import {
8137 name: "libfoo",
8138 jars: ["libfoo.jar"],
8139 apex_available: [
8140 "com.android.myapex",
8141 "com.android.myapex_compressed",
8142 ],
8143 }
8144 `)
8145
8146 module := result.Module("libfoo", "android_common_com.android.myapex")
8147 usesLibraryDep := module.(java.UsesLibraryDependency)
8148 android.AssertPathRelativeToTopEquals(t, "dex jar path",
Spandan Das3576e762024-01-03 18:57:03 +00008149 "out/soong/.intermediates/prebuilt_com.android.myapex.deapexer/android_common/deapexer/javalib/libfoo.jar",
Spandan Das59a4a2b2024-01-09 21:35:56 +00008150 usesLibraryDep.DexJarBuildPath(errCtx).Path())
Paul Duffin5556c5f2022-06-09 17:32:21 +00008151 })
8152
8153 t.Run("java_sdk_library_import", func(t *testing.T) {
8154 result := preparers.RunTestWithBp(t,
8155 fmt.Sprintf(bpBase, `contents: ["libfoo"]`)+`
8156 java_sdk_library_import {
8157 name: "libfoo",
8158 public: {
8159 jars: ["libbar.jar"],
8160 },
8161 apex_available: [
8162 "com.android.myapex",
8163 "com.android.myapex_compressed",
8164 ],
8165 compile_dex: true,
8166 }
8167 `)
8168
8169 module := result.Module("libfoo", "android_common_com.android.myapex")
8170 usesLibraryDep := module.(java.UsesLibraryDependency)
8171 android.AssertPathRelativeToTopEquals(t, "dex jar path",
Spandan Das3576e762024-01-03 18:57:03 +00008172 "out/soong/.intermediates/prebuilt_com.android.myapex.deapexer/android_common/deapexer/javalib/libfoo.jar",
Spandan Das59a4a2b2024-01-09 21:35:56 +00008173 usesLibraryDep.DexJarBuildPath(errCtx).Path())
Paul Duffin5556c5f2022-06-09 17:32:21 +00008174 })
8175
8176 t.Run("prebuilt_bootclasspath_fragment", func(t *testing.T) {
8177 _ = preparers.RunTestWithBp(t, fmt.Sprintf(bpBase, `
8178 image_name: "art",
8179 contents: ["libfoo"],
8180 `)+`
8181 java_sdk_library_import {
8182 name: "libfoo",
8183 public: {
8184 jars: ["libbar.jar"],
8185 },
8186 apex_available: [
8187 "com.android.myapex",
8188 "com.android.myapex_compressed",
8189 ],
8190 compile_dex: true,
8191 }
8192 `)
8193 })
8194}
8195
Jooyung Han548640b2020-04-27 12:10:30 +09008196func TestUpdatable_should_set_min_sdk_version(t *testing.T) {
8197 testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
8198 apex {
8199 name: "myapex",
8200 key: "myapex.key",
8201 updatable: true,
8202 }
8203
8204 apex_key {
8205 name: "myapex.key",
8206 public_key: "testkey.avbpubkey",
8207 private_key: "testkey.pem",
8208 }
8209 `)
8210}
8211
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00008212func TestUpdatableDefault_should_set_min_sdk_version(t *testing.T) {
8213 testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
8214 apex {
8215 name: "myapex",
8216 key: "myapex.key",
8217 }
8218
8219 apex_key {
8220 name: "myapex.key",
8221 public_key: "testkey.avbpubkey",
8222 private_key: "testkey.pem",
8223 }
8224 `)
8225}
8226
Jooyung Handfc864c2023-03-20 18:19:07 +09008227func Test_use_vndk_as_stable_shouldnt_be_used_for_updatable_vendor_apexes(t *testing.T) {
8228 testApexError(t, `"myapex" .*: use_vndk_as_stable: updatable APEXes can't use external VNDK libs`, `
Daniel Norman69109112021-12-02 12:52:42 -08008229 apex {
8230 name: "myapex",
8231 key: "myapex.key",
8232 updatable: true,
Jooyung Handfc864c2023-03-20 18:19:07 +09008233 use_vndk_as_stable: true,
Daniel Norman69109112021-12-02 12:52:42 -08008234 soc_specific: true,
8235 }
8236
8237 apex_key {
8238 name: "myapex.key",
8239 public_key: "testkey.avbpubkey",
8240 private_key: "testkey.pem",
8241 }
8242 `)
8243}
8244
Jooyung Han02873da2023-03-22 17:41:03 +09008245func Test_use_vndk_as_stable_shouldnt_be_used_with_min_sdk_version(t *testing.T) {
8246 testApexError(t, `"myapex" .*: use_vndk_as_stable: not supported when min_sdk_version is set`, `
8247 apex {
8248 name: "myapex",
8249 key: "myapex.key",
8250 updatable: false,
8251 min_sdk_version: "29",
8252 use_vndk_as_stable: true,
8253 vendor: true,
8254 }
8255
8256 apex_key {
8257 name: "myapex.key",
8258 public_key: "testkey.avbpubkey",
8259 private_key: "testkey.pem",
8260 }
8261 `)
8262}
8263
Jooyung Handfc864c2023-03-20 18:19:07 +09008264func Test_use_vndk_as_stable_shouldnt_be_used_for_non_vendor_apexes(t *testing.T) {
8265 testApexError(t, `"myapex" .*: use_vndk_as_stable: not supported for system/system_ext APEXes`, `
8266 apex {
8267 name: "myapex",
8268 key: "myapex.key",
8269 updatable: false,
8270 use_vndk_as_stable: true,
8271 }
8272
8273 apex_key {
8274 name: "myapex.key",
8275 public_key: "testkey.avbpubkey",
8276 private_key: "testkey.pem",
8277 }
8278 `)
8279}
8280
satayevb98371c2021-06-15 16:49:50 +01008281func TestUpdatable_should_not_set_generate_classpaths_proto(t *testing.T) {
8282 testApexError(t, `"mysystemserverclasspathfragment" .* it must not set generate_classpaths_proto to false`, `
8283 apex {
8284 name: "myapex",
8285 key: "myapex.key",
8286 systemserverclasspath_fragments: [
8287 "mysystemserverclasspathfragment",
8288 ],
8289 min_sdk_version: "29",
8290 updatable: true,
8291 }
8292
8293 apex_key {
8294 name: "myapex.key",
8295 public_key: "testkey.avbpubkey",
8296 private_key: "testkey.pem",
8297 }
8298
8299 java_library {
8300 name: "foo",
8301 srcs: ["b.java"],
8302 min_sdk_version: "29",
8303 installable: true,
8304 apex_available: [
8305 "myapex",
8306 ],
8307 }
8308
8309 systemserverclasspath_fragment {
8310 name: "mysystemserverclasspathfragment",
8311 generate_classpaths_proto: false,
8312 contents: [
8313 "foo",
8314 ],
8315 apex_available: [
8316 "myapex",
8317 ],
8318 }
satayevabcd5972021-08-06 17:49:46 +01008319 `,
8320 dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"),
8321 )
satayevb98371c2021-06-15 16:49:50 +01008322}
8323
Paul Duffin064b70c2020-11-02 17:32:38 +00008324func TestDexpreoptAccessDexFilesFromPrebuiltApex(t *testing.T) {
satayevabcd5972021-08-06 17:49:46 +01008325 preparer := java.FixtureConfigureApexBootJars("myapex:libfoo")
Paul Duffin064b70c2020-11-02 17:32:38 +00008326 t.Run("prebuilt no source", func(t *testing.T) {
Paul Duffin89f570a2021-06-16 01:42:33 +01008327 fragment := java.ApexVariantReference{
8328 Apex: proptools.StringPtr("myapex"),
8329 Module: proptools.StringPtr("my-bootclasspath-fragment"),
8330 }
8331
Paul Duffin064b70c2020-11-02 17:32:38 +00008332 testDexpreoptWithApexes(t, `
8333 prebuilt_apex {
8334 name: "myapex" ,
8335 arch: {
8336 arm64: {
8337 src: "myapex-arm64.apex",
8338 },
8339 arm: {
8340 src: "myapex-arm.apex",
8341 },
8342 },
Paul Duffin89f570a2021-06-16 01:42:33 +01008343 exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
8344 }
Paul Duffin064b70c2020-11-02 17:32:38 +00008345
Paul Duffin89f570a2021-06-16 01:42:33 +01008346 prebuilt_bootclasspath_fragment {
8347 name: "my-bootclasspath-fragment",
8348 contents: ["libfoo"],
8349 apex_available: ["myapex"],
Paul Duffin54e41972021-07-19 13:23:40 +01008350 hidden_api: {
8351 annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
8352 metadata: "my-bootclasspath-fragment/metadata.csv",
8353 index: "my-bootclasspath-fragment/index.csv",
Paul Duffin191be3a2021-08-10 16:14:16 +01008354 signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
8355 filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
8356 filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
Paul Duffin54e41972021-07-19 13:23:40 +01008357 },
Paul Duffin89f570a2021-06-16 01:42:33 +01008358 }
Paul Duffin064b70c2020-11-02 17:32:38 +00008359
Paul Duffin89f570a2021-06-16 01:42:33 +01008360 java_import {
8361 name: "libfoo",
8362 jars: ["libfoo.jar"],
8363 apex_available: ["myapex"],
satayevabcd5972021-08-06 17:49:46 +01008364 permitted_packages: ["libfoo"],
Paul Duffin89f570a2021-06-16 01:42:33 +01008365 }
8366 `, "", preparer, fragment)
Paul Duffin064b70c2020-11-02 17:32:38 +00008367 })
Ulya Trafimovichb28cc372020-01-13 15:18:16 +00008368}
8369
Spandan Dasf14e2542021-11-12 00:01:37 +00008370func testBootJarPermittedPackagesRules(t *testing.T, errmsg, bp string, bootJars []string, rules []android.Rule) {
Andrei Onea115e7e72020-06-05 21:14:03 +01008371 t.Helper()
Andrei Onea115e7e72020-06-05 21:14:03 +01008372 bp += `
8373 apex_key {
8374 name: "myapex.key",
8375 public_key: "testkey.avbpubkey",
8376 private_key: "testkey.pem",
8377 }`
Paul Duffin45338f02021-03-30 23:07:52 +01008378 fs := android.MockFS{
Andrei Onea115e7e72020-06-05 21:14:03 +01008379 "lib1/src/A.java": nil,
8380 "lib2/src/B.java": nil,
8381 "system/sepolicy/apex/myapex-file_contexts": nil,
8382 }
8383
Paul Duffin45338f02021-03-30 23:07:52 +01008384 errorHandler := android.FixtureExpectsNoErrors
8385 if errmsg != "" {
8386 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
Colin Crossae8600b2020-10-29 17:09:13 -07008387 }
Colin Crossae8600b2020-10-29 17:09:13 -07008388
Paul Duffin45338f02021-03-30 23:07:52 +01008389 android.GroupFixturePreparers(
8390 android.PrepareForTestWithAndroidBuildComponents,
8391 java.PrepareForTestWithJavaBuildComponents,
8392 PrepareForTestWithApexBuildComponents,
8393 android.PrepareForTestWithNeverallowRules(rules),
8394 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
satayevd604b212021-07-21 14:23:52 +01008395 apexBootJars := make([]string, 0, len(bootJars))
8396 for _, apexBootJar := range bootJars {
8397 apexBootJars = append(apexBootJars, "myapex:"+apexBootJar)
Paul Duffin45338f02021-03-30 23:07:52 +01008398 }
satayevd604b212021-07-21 14:23:52 +01008399 variables.ApexBootJars = android.CreateTestConfiguredJarList(apexBootJars)
Paul Duffin45338f02021-03-30 23:07:52 +01008400 }),
8401 fs.AddToFixture(),
8402 ).
8403 ExtendWithErrorHandler(errorHandler).
8404 RunTestWithBp(t, bp)
Andrei Onea115e7e72020-06-05 21:14:03 +01008405}
8406
8407func TestApexPermittedPackagesRules(t *testing.T) {
8408 testcases := []struct {
Spandan Dasf14e2542021-11-12 00:01:37 +00008409 name string
8410 expectedError string
8411 bp string
8412 bootJars []string
8413 bcpPermittedPackages map[string][]string
Andrei Onea115e7e72020-06-05 21:14:03 +01008414 }{
8415
8416 {
8417 name: "Non-Bootclasspath apex jar not satisfying allowed module packages.",
8418 expectedError: "",
8419 bp: `
8420 java_library {
8421 name: "bcp_lib1",
8422 srcs: ["lib1/src/*.java"],
8423 permitted_packages: ["foo.bar"],
8424 apex_available: ["myapex"],
8425 sdk_version: "none",
8426 system_modules: "none",
8427 }
8428 java_library {
8429 name: "nonbcp_lib2",
8430 srcs: ["lib2/src/*.java"],
8431 apex_available: ["myapex"],
8432 permitted_packages: ["a.b"],
8433 sdk_version: "none",
8434 system_modules: "none",
8435 }
8436 apex {
8437 name: "myapex",
8438 key: "myapex.key",
8439 java_libs: ["bcp_lib1", "nonbcp_lib2"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00008440 updatable: false,
Andrei Onea115e7e72020-06-05 21:14:03 +01008441 }`,
8442 bootJars: []string{"bcp_lib1"},
Spandan Dasf14e2542021-11-12 00:01:37 +00008443 bcpPermittedPackages: map[string][]string{
8444 "bcp_lib1": []string{
Andrei Onea115e7e72020-06-05 21:14:03 +01008445 "foo.bar",
8446 },
8447 },
8448 },
8449 {
Anton Hanssone1b18362021-12-23 15:05:38 +00008450 name: "Bootclasspath apex jar not satisfying allowed module packages.",
Spandan Dasf14e2542021-11-12 00:01:37 +00008451 expectedError: `(?s)module "bcp_lib2" .* which is restricted because bcp_lib2 bootjar may only use these package prefixes: foo.bar. Please consider the following alternatives:\n 1. If the offending code is from a statically linked library, consider removing that dependency and using an alternative already in the bootclasspath, or perhaps a shared library. 2. Move the offending code into an allowed package.\n 3. Jarjar the offending code. Please be mindful of the potential system health implications of bundling that code, particularly if the offending jar is part of the bootclasspath.`,
Andrei Onea115e7e72020-06-05 21:14:03 +01008452 bp: `
8453 java_library {
8454 name: "bcp_lib1",
8455 srcs: ["lib1/src/*.java"],
8456 apex_available: ["myapex"],
8457 permitted_packages: ["foo.bar"],
8458 sdk_version: "none",
8459 system_modules: "none",
8460 }
8461 java_library {
8462 name: "bcp_lib2",
8463 srcs: ["lib2/src/*.java"],
8464 apex_available: ["myapex"],
8465 permitted_packages: ["foo.bar", "bar.baz"],
8466 sdk_version: "none",
8467 system_modules: "none",
8468 }
8469 apex {
8470 name: "myapex",
8471 key: "myapex.key",
8472 java_libs: ["bcp_lib1", "bcp_lib2"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00008473 updatable: false,
Andrei Onea115e7e72020-06-05 21:14:03 +01008474 }
8475 `,
8476 bootJars: []string{"bcp_lib1", "bcp_lib2"},
Spandan Dasf14e2542021-11-12 00:01:37 +00008477 bcpPermittedPackages: map[string][]string{
8478 "bcp_lib1": []string{
Andrei Onea115e7e72020-06-05 21:14:03 +01008479 "foo.bar",
8480 },
Spandan Dasf14e2542021-11-12 00:01:37 +00008481 "bcp_lib2": []string{
8482 "foo.bar",
8483 },
8484 },
8485 },
8486 {
8487 name: "Updateable Bootclasspath apex jar not satisfying allowed module packages.",
8488 expectedError: "",
8489 bp: `
8490 java_library {
8491 name: "bcp_lib_restricted",
8492 srcs: ["lib1/src/*.java"],
8493 apex_available: ["myapex"],
8494 permitted_packages: ["foo.bar"],
8495 sdk_version: "none",
8496 min_sdk_version: "29",
8497 system_modules: "none",
8498 }
8499 java_library {
8500 name: "bcp_lib_unrestricted",
8501 srcs: ["lib2/src/*.java"],
8502 apex_available: ["myapex"],
8503 permitted_packages: ["foo.bar", "bar.baz"],
8504 sdk_version: "none",
8505 min_sdk_version: "29",
8506 system_modules: "none",
8507 }
8508 apex {
8509 name: "myapex",
8510 key: "myapex.key",
8511 java_libs: ["bcp_lib_restricted", "bcp_lib_unrestricted"],
8512 updatable: true,
8513 min_sdk_version: "29",
8514 }
8515 `,
8516 bootJars: []string{"bcp_lib1", "bcp_lib2"},
8517 bcpPermittedPackages: map[string][]string{
8518 "bcp_lib1_non_updateable": []string{
8519 "foo.bar",
8520 },
8521 // bcp_lib2_updateable has no entry here since updateable bcp can contain new packages - tracking via an allowlist is not necessary
Andrei Onea115e7e72020-06-05 21:14:03 +01008522 },
8523 },
8524 }
8525 for _, tc := range testcases {
8526 t.Run(tc.name, func(t *testing.T) {
Spandan Dasf14e2542021-11-12 00:01:37 +00008527 rules := createBcpPermittedPackagesRules(tc.bcpPermittedPackages)
8528 testBootJarPermittedPackagesRules(t, tc.expectedError, tc.bp, tc.bootJars, rules)
Andrei Onea115e7e72020-06-05 21:14:03 +01008529 })
8530 }
8531}
8532
Jiyong Park62304bb2020-04-13 16:19:48 +09008533func TestTestFor(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08008534 ctx := testApex(t, `
Jiyong Park62304bb2020-04-13 16:19:48 +09008535 apex {
8536 name: "myapex",
8537 key: "myapex.key",
8538 native_shared_libs: ["mylib", "myprivlib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00008539 updatable: false,
Jiyong Park62304bb2020-04-13 16:19:48 +09008540 }
8541
8542 apex_key {
8543 name: "myapex.key",
8544 public_key: "testkey.avbpubkey",
8545 private_key: "testkey.pem",
8546 }
8547
8548 cc_library {
8549 name: "mylib",
8550 srcs: ["mylib.cpp"],
8551 system_shared_libs: [],
8552 stl: "none",
8553 stubs: {
8554 versions: ["1"],
8555 },
8556 apex_available: ["myapex"],
8557 }
8558
8559 cc_library {
8560 name: "myprivlib",
8561 srcs: ["mylib.cpp"],
8562 system_shared_libs: [],
8563 stl: "none",
8564 apex_available: ["myapex"],
8565 }
8566
8567
8568 cc_test {
8569 name: "mytest",
8570 gtest: false,
8571 srcs: ["mylib.cpp"],
8572 system_shared_libs: [],
8573 stl: "none",
Jiyong Park46a512f2020-12-04 18:02:13 +09008574 shared_libs: ["mylib", "myprivlib", "mytestlib"],
Jiyong Park62304bb2020-04-13 16:19:48 +09008575 test_for: ["myapex"]
8576 }
Jiyong Park46a512f2020-12-04 18:02:13 +09008577
8578 cc_library {
8579 name: "mytestlib",
8580 srcs: ["mylib.cpp"],
8581 system_shared_libs: [],
8582 shared_libs: ["mylib", "myprivlib"],
8583 stl: "none",
8584 test_for: ["myapex"],
8585 }
8586
8587 cc_benchmark {
8588 name: "mybench",
8589 srcs: ["mylib.cpp"],
8590 system_shared_libs: [],
8591 shared_libs: ["mylib", "myprivlib"],
8592 stl: "none",
8593 test_for: ["myapex"],
8594 }
Jiyong Park62304bb2020-04-13 16:19:48 +09008595 `)
8596
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00008597 ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
Paul Duffina71a67a2021-03-29 00:42:57 +01008598 ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00008599 mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
8600 android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
8601 }
8602
8603 // These modules are tests for the apex, therefore are linked to the
Jiyong Park62304bb2020-04-13 16:19:48 +09008604 // actual implementation of mylib instead of its stub.
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00008605 ensureLinkedLibIs("mytest", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
8606 ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
8607 ensureLinkedLibIs("mybench", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
8608}
Jiyong Park46a512f2020-12-04 18:02:13 +09008609
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00008610func TestIndirectTestFor(t *testing.T) {
8611 ctx := testApex(t, `
8612 apex {
8613 name: "myapex",
8614 key: "myapex.key",
8615 native_shared_libs: ["mylib", "myprivlib"],
8616 updatable: false,
8617 }
Jiyong Park46a512f2020-12-04 18:02:13 +09008618
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00008619 apex_key {
8620 name: "myapex.key",
8621 public_key: "testkey.avbpubkey",
8622 private_key: "testkey.pem",
8623 }
8624
8625 cc_library {
8626 name: "mylib",
8627 srcs: ["mylib.cpp"],
8628 system_shared_libs: [],
8629 stl: "none",
8630 stubs: {
8631 versions: ["1"],
8632 },
8633 apex_available: ["myapex"],
8634 }
8635
8636 cc_library {
8637 name: "myprivlib",
8638 srcs: ["mylib.cpp"],
8639 system_shared_libs: [],
8640 stl: "none",
8641 shared_libs: ["mylib"],
8642 apex_available: ["myapex"],
8643 }
8644
8645 cc_library {
8646 name: "mytestlib",
8647 srcs: ["mylib.cpp"],
8648 system_shared_libs: [],
8649 shared_libs: ["myprivlib"],
8650 stl: "none",
8651 test_for: ["myapex"],
8652 }
8653 `)
8654
8655 ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
Paul Duffina71a67a2021-03-29 00:42:57 +01008656 ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
Martin Stjernholm4e6c2692021-03-25 01:25:06 +00008657 mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
8658 android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
8659 }
8660
8661 // The platform variant of mytestlib links to the platform variant of the
8662 // internal myprivlib.
8663 ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/myprivlib/", "android_arm64_armv8-a_shared/myprivlib.so")
8664
8665 // The platform variant of myprivlib links to the platform variant of mylib
8666 // and bypasses its stubs.
8667 ensureLinkedLibIs("myprivlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
Jiyong Park62304bb2020-04-13 16:19:48 +09008668}
8669
Martin Stjernholmec009002021-03-27 15:18:31 +00008670func TestTestForForLibInOtherApex(t *testing.T) {
8671 // This case is only allowed for known overlapping APEXes, i.e. the ART APEXes.
8672 _ = testApex(t, `
8673 apex {
8674 name: "com.android.art",
8675 key: "myapex.key",
Spandan Das20fce2d2023-04-12 17:21:39 +00008676 native_shared_libs: ["libnativebridge"],
Martin Stjernholmec009002021-03-27 15:18:31 +00008677 updatable: false,
8678 }
8679
8680 apex {
8681 name: "com.android.art.debug",
8682 key: "myapex.key",
Spandan Das20fce2d2023-04-12 17:21:39 +00008683 native_shared_libs: ["libnativebridge", "libnativebrdige_test"],
Martin Stjernholmec009002021-03-27 15:18:31 +00008684 updatable: false,
8685 }
8686
8687 apex_key {
8688 name: "myapex.key",
8689 public_key: "testkey.avbpubkey",
8690 private_key: "testkey.pem",
8691 }
8692
8693 cc_library {
Spandan Das20fce2d2023-04-12 17:21:39 +00008694 name: "libnativebridge",
8695 srcs: ["libnativebridge.cpp"],
Martin Stjernholmec009002021-03-27 15:18:31 +00008696 system_shared_libs: [],
8697 stl: "none",
8698 stubs: {
8699 versions: ["1"],
8700 },
8701 apex_available: ["com.android.art", "com.android.art.debug"],
8702 }
8703
8704 cc_library {
Spandan Das20fce2d2023-04-12 17:21:39 +00008705 name: "libnativebrdige_test",
Martin Stjernholmec009002021-03-27 15:18:31 +00008706 srcs: ["mylib.cpp"],
8707 system_shared_libs: [],
Spandan Das20fce2d2023-04-12 17:21:39 +00008708 shared_libs: ["libnativebridge"],
Martin Stjernholmec009002021-03-27 15:18:31 +00008709 stl: "none",
8710 apex_available: ["com.android.art.debug"],
8711 test_for: ["com.android.art"],
8712 }
8713 `,
8714 android.MockFS{
8715 "system/sepolicy/apex/com.android.art-file_contexts": nil,
8716 "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
8717 }.AddToFixture())
8718}
8719
Jaewoong Jungfa00c062020-05-14 14:15:24 -07008720// TODO(jungjw): Move this to proptools
8721func intPtr(i int) *int {
8722 return &i
8723}
8724
8725func TestApexSet(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08008726 ctx := testApex(t, `
Jaewoong Jungfa00c062020-05-14 14:15:24 -07008727 apex_set {
8728 name: "myapex",
8729 set: "myapex.apks",
8730 filename: "foo_v2.apex",
8731 overrides: ["foo"],
8732 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00008733 `,
8734 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
8735 variables.Platform_sdk_version = intPtr(30)
8736 }),
8737 android.FixtureModifyConfig(func(config android.Config) {
8738 config.Targets[android.Android] = []android.Target{
8739 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}},
8740 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}},
8741 }
8742 }),
8743 )
Jaewoong Jungfa00c062020-05-14 14:15:24 -07008744
Spandan Das3576e762024-01-03 18:57:03 +00008745 m := ctx.ModuleForTests("prebuilt_myapex.apex.extractor", "android_common")
Jaewoong Jungfa00c062020-05-14 14:15:24 -07008746
8747 // Check extract_apks tool parameters.
Paul Duffin24704672021-04-06 16:09:30 +01008748 extractedApex := m.Output("extracted/myapex.apks")
Jaewoong Jungfa00c062020-05-14 14:15:24 -07008749 actual := extractedApex.Args["abis"]
8750 expected := "ARMEABI_V7A,ARM64_V8A"
8751 if actual != expected {
8752 t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
8753 }
8754 actual = extractedApex.Args["sdk-version"]
8755 expected = "30"
8756 if actual != expected {
8757 t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
8758 }
8759
Paul Duffin6717d882021-06-15 19:09:41 +01008760 m = ctx.ModuleForTests("myapex", "android_common_myapex")
Jaewoong Jungfa00c062020-05-14 14:15:24 -07008761 a := m.Module().(*ApexSet)
8762 expectedOverrides := []string{"foo"}
Colin Crossaa255532020-07-03 13:18:24 -07008763 actualOverrides := android.AndroidMkEntriesForTest(t, ctx, a)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
Jaewoong Jungfa00c062020-05-14 14:15:24 -07008764 if !reflect.DeepEqual(actualOverrides, expectedOverrides) {
8765 t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES - expected %q vs actual %q", expectedOverrides, actualOverrides)
8766 }
8767}
8768
Anton Hansson805e0a52022-11-25 14:06:46 +00008769func TestApexSet_NativeBridge(t *testing.T) {
8770 ctx := testApex(t, `
8771 apex_set {
8772 name: "myapex",
8773 set: "myapex.apks",
8774 filename: "foo_v2.apex",
8775 overrides: ["foo"],
8776 }
8777 `,
8778 android.FixtureModifyConfig(func(config android.Config) {
8779 config.Targets[android.Android] = []android.Target{
8780 {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "", Abi: []string{"x86_64"}}},
8781 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}, NativeBridge: android.NativeBridgeEnabled},
8782 }
8783 }),
8784 )
8785
Spandan Das3576e762024-01-03 18:57:03 +00008786 m := ctx.ModuleForTests("prebuilt_myapex.apex.extractor", "android_common")
Anton Hansson805e0a52022-11-25 14:06:46 +00008787
8788 // Check extract_apks tool parameters. No native bridge arch expected
8789 extractedApex := m.Output("extracted/myapex.apks")
8790 android.AssertStringEquals(t, "abis", "X86_64", extractedApex.Args["abis"])
8791}
8792
Jiyong Park7d95a512020-05-10 15:16:24 +09008793func TestNoStaticLinkingToStubsLib(t *testing.T) {
8794 testApexError(t, `.*required by "mylib" is a native library providing stub.*`, `
8795 apex {
8796 name: "myapex",
8797 key: "myapex.key",
8798 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00008799 updatable: false,
Jiyong Park7d95a512020-05-10 15:16:24 +09008800 }
8801
8802 apex_key {
8803 name: "myapex.key",
8804 public_key: "testkey.avbpubkey",
8805 private_key: "testkey.pem",
8806 }
8807
8808 cc_library {
8809 name: "mylib",
8810 srcs: ["mylib.cpp"],
8811 static_libs: ["otherlib"],
8812 system_shared_libs: [],
8813 stl: "none",
8814 apex_available: [ "myapex" ],
8815 }
8816
8817 cc_library {
8818 name: "otherlib",
8819 srcs: ["mylib.cpp"],
8820 system_shared_libs: [],
8821 stl: "none",
8822 stubs: {
8823 versions: ["1", "2", "3"],
8824 },
8825 apex_available: [ "myapex" ],
8826 }
8827 `)
8828}
8829
Jiyong Park8d6c51e2020-06-12 17:26:31 +09008830func TestApexKeysTxt(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08008831 ctx := testApex(t, `
Jiyong Park8d6c51e2020-06-12 17:26:31 +09008832 apex {
8833 name: "myapex",
8834 key: "myapex.key",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00008835 updatable: false,
Jooyung Han09c11ad2021-10-27 03:45:31 +09008836 custom_sign_tool: "sign_myapex",
8837 }
8838
8839 apex_key {
8840 name: "myapex.key",
8841 public_key: "testkey.avbpubkey",
8842 private_key: "testkey.pem",
8843 }
8844 `)
8845
Jooyung Han286957d2023-10-30 16:17:56 +09008846 myapex := ctx.ModuleForTests("myapex", "android_common_myapex")
Colin Crossf61d03d2023-11-02 16:56:39 -07008847 content := android.ContentFromFileRuleForTests(t, ctx, myapex.Output("apexkeys.txt"))
Jooyung Haneec1b3f2023-06-20 16:25:59 +09008848 ensureContains(t, content, `name="myapex.apex" public_key="vendor/foo/devkeys/testkey.avbpubkey" private_key="vendor/foo/devkeys/testkey.pem" container_certificate="vendor/foo/devkeys/test.x509.pem" container_private_key="vendor/foo/devkeys/test.pk8" partition="system" sign_tool="sign_myapex"`)
Jooyung Han09c11ad2021-10-27 03:45:31 +09008849}
8850
8851func TestApexKeysTxtOverrides(t *testing.T) {
8852 ctx := testApex(t, `
8853 apex {
8854 name: "myapex",
8855 key: "myapex.key",
8856 updatable: false,
8857 custom_sign_tool: "sign_myapex",
Jiyong Park8d6c51e2020-06-12 17:26:31 +09008858 }
8859
8860 apex_key {
8861 name: "myapex.key",
8862 public_key: "testkey.avbpubkey",
8863 private_key: "testkey.pem",
8864 }
8865
8866 prebuilt_apex {
8867 name: "myapex",
8868 prefer: true,
8869 arch: {
8870 arm64: {
8871 src: "myapex-arm64.apex",
8872 },
8873 arm: {
8874 src: "myapex-arm.apex",
8875 },
8876 },
8877 }
8878
8879 apex_set {
8880 name: "myapex_set",
8881 set: "myapex.apks",
8882 filename: "myapex_set.apex",
8883 overrides: ["myapex"],
8884 }
8885 `)
8886
Colin Crossf61d03d2023-11-02 16:56:39 -07008887 content := android.ContentFromFileRuleForTests(t, ctx,
8888 ctx.ModuleForTests("myapex", "android_common_myapex").Output("apexkeys.txt"))
Jooyung Han286957d2023-10-30 16:17:56 +09008889 ensureContains(t, content, `name="myapex.apex" public_key="vendor/foo/devkeys/testkey.avbpubkey" private_key="vendor/foo/devkeys/testkey.pem" container_certificate="vendor/foo/devkeys/test.x509.pem" container_private_key="vendor/foo/devkeys/test.pk8" partition="system" sign_tool="sign_myapex"`)
Colin Crossf61d03d2023-11-02 16:56:39 -07008890 content = android.ContentFromFileRuleForTests(t, ctx,
8891 ctx.ModuleForTests("myapex_set", "android_common_myapex_set").Output("apexkeys.txt"))
Jiyong Park8d6c51e2020-06-12 17:26:31 +09008892 ensureContains(t, content, `name="myapex_set.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
Jiyong Park8d6c51e2020-06-12 17:26:31 +09008893}
8894
Jooyung Han938b5932020-06-20 12:47:47 +09008895func TestAllowedFiles(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08008896 ctx := testApex(t, `
Jooyung Han938b5932020-06-20 12:47:47 +09008897 apex {
8898 name: "myapex",
8899 key: "myapex.key",
8900 apps: ["app"],
8901 allowed_files: "allowed.txt",
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00008902 updatable: false,
Jooyung Han938b5932020-06-20 12:47:47 +09008903 }
8904
8905 apex_key {
8906 name: "myapex.key",
8907 public_key: "testkey.avbpubkey",
8908 private_key: "testkey.pem",
8909 }
8910
8911 android_app {
8912 name: "app",
8913 srcs: ["foo/bar/MyClass.java"],
8914 package_name: "foo",
8915 sdk_version: "none",
8916 system_modules: "none",
8917 apex_available: [ "myapex" ],
8918 }
8919 `, withFiles(map[string][]byte{
8920 "sub/Android.bp": []byte(`
8921 override_apex {
8922 name: "override_myapex",
8923 base: "myapex",
8924 apps: ["override_app"],
8925 allowed_files: ":allowed",
8926 }
8927 // Overridable "path" property should be referenced indirectly
8928 filegroup {
8929 name: "allowed",
8930 srcs: ["allowed.txt"],
8931 }
8932 override_android_app {
8933 name: "override_app",
8934 base: "app",
8935 package_name: "bar",
8936 }
8937 `),
8938 }))
8939
Jooyung Hana0503a52023-08-23 13:12:50 +09008940 rule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("diffApexContentRule")
Jooyung Han938b5932020-06-20 12:47:47 +09008941 if expected, actual := "allowed.txt", rule.Args["allowed_files_file"]; expected != actual {
8942 t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
8943 }
8944
Jooyung Hana0503a52023-08-23 13:12:50 +09008945 rule2 := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex").Rule("diffApexContentRule")
Jooyung Han938b5932020-06-20 12:47:47 +09008946 if expected, actual := "sub/allowed.txt", rule2.Args["allowed_files_file"]; expected != actual {
8947 t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
8948 }
8949}
8950
Martin Stjernholm58c33f02020-07-06 22:56:01 +01008951func TestNonPreferredPrebuiltDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08008952 testApex(t, `
Martin Stjernholm58c33f02020-07-06 22:56:01 +01008953 apex {
8954 name: "myapex",
8955 key: "myapex.key",
8956 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00008957 updatable: false,
Martin Stjernholm58c33f02020-07-06 22:56:01 +01008958 }
8959
8960 apex_key {
8961 name: "myapex.key",
8962 public_key: "testkey.avbpubkey",
8963 private_key: "testkey.pem",
8964 }
8965
8966 cc_library {
8967 name: "mylib",
8968 srcs: ["mylib.cpp"],
8969 stubs: {
Dan Albertc8060532020-07-22 22:32:17 -07008970 versions: ["current"],
Martin Stjernholm58c33f02020-07-06 22:56:01 +01008971 },
8972 apex_available: ["myapex"],
8973 }
8974
8975 cc_prebuilt_library_shared {
8976 name: "mylib",
8977 prefer: false,
8978 srcs: ["prebuilt.so"],
8979 stubs: {
Dan Albertc8060532020-07-22 22:32:17 -07008980 versions: ["current"],
Martin Stjernholm58c33f02020-07-06 22:56:01 +01008981 },
8982 apex_available: ["myapex"],
8983 }
8984 `)
8985}
8986
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00008987func TestCompressedApex(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08008988 ctx := testApex(t, `
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00008989 apex {
8990 name: "myapex",
8991 key: "myapex.key",
8992 compressible: true,
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00008993 updatable: false,
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00008994 }
8995 apex_key {
8996 name: "myapex.key",
8997 public_key: "testkey.avbpubkey",
8998 private_key: "testkey.pem",
8999 }
Paul Duffin0a49fdc2021-03-08 11:28:25 +00009000 `,
9001 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
9002 variables.CompressedApex = proptools.BoolPtr(true)
9003 }),
9004 )
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00009005
Jooyung Hana0503a52023-08-23 13:12:50 +09009006 compressRule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("compressRule")
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00009007 ensureContains(t, compressRule.Output.String(), "myapex.capex.unsigned")
9008
Jooyung Hana0503a52023-08-23 13:12:50 +09009009 signApkRule := ctx.ModuleForTests("myapex", "android_common_myapex").Description("sign compressedApex")
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00009010 ensureEquals(t, signApkRule.Input.String(), compressRule.Output.String())
9011
9012 // Make sure output of bundle is .capex
Jooyung Hana0503a52023-08-23 13:12:50 +09009013 ab := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*apexBundle)
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00009014 ensureContains(t, ab.outputFile.String(), "myapex.capex")
9015
9016 // Verify android.mk rules
Colin Crossaa255532020-07-03 13:18:24 -07009017 data := android.AndroidMkDataForTest(t, ctx, ab)
Mohammad Samiul Islam3cd005d2020-11-26 13:32:26 +00009018 var builder strings.Builder
9019 data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
9020 androidMk := builder.String()
9021 ensureContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.capex\n")
9022}
9023
Martin Stjernholm2856c662020-12-02 15:03:42 +00009024func TestPreferredPrebuiltSharedLibDep(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08009025 ctx := testApex(t, `
Martin Stjernholm2856c662020-12-02 15:03:42 +00009026 apex {
9027 name: "myapex",
9028 key: "myapex.key",
9029 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00009030 updatable: false,
Martin Stjernholm2856c662020-12-02 15:03:42 +00009031 }
9032
9033 apex_key {
9034 name: "myapex.key",
9035 public_key: "testkey.avbpubkey",
9036 private_key: "testkey.pem",
9037 }
9038
9039 cc_library {
9040 name: "mylib",
9041 srcs: ["mylib.cpp"],
9042 apex_available: ["myapex"],
9043 shared_libs: ["otherlib"],
9044 system_shared_libs: [],
9045 }
9046
9047 cc_library {
9048 name: "otherlib",
9049 srcs: ["mylib.cpp"],
9050 stubs: {
9051 versions: ["current"],
9052 },
9053 }
9054
9055 cc_prebuilt_library_shared {
9056 name: "otherlib",
9057 prefer: true,
9058 srcs: ["prebuilt.so"],
9059 stubs: {
9060 versions: ["current"],
9061 },
9062 }
9063 `)
9064
Jooyung Hana0503a52023-08-23 13:12:50 +09009065 ab := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*apexBundle)
Colin Crossaa255532020-07-03 13:18:24 -07009066 data := android.AndroidMkDataForTest(t, ctx, ab)
Martin Stjernholm2856c662020-12-02 15:03:42 +00009067 var builder strings.Builder
9068 data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
9069 androidMk := builder.String()
9070
9071 // The make level dependency needs to be on otherlib - prebuilt_otherlib isn't
9072 // a thing there.
Jooyung Haneec1b3f2023-06-20 16:25:59 +09009073 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := libc++:64 mylib.myapex:64 otherlib\n")
Martin Stjernholm2856c662020-12-02 15:03:42 +00009074}
9075
Jiyong Parke3867542020-12-03 17:28:25 +09009076func TestExcludeDependency(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08009077 ctx := testApex(t, `
Jiyong Parke3867542020-12-03 17:28:25 +09009078 apex {
9079 name: "myapex",
9080 key: "myapex.key",
9081 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00009082 updatable: false,
Jiyong Parke3867542020-12-03 17:28:25 +09009083 }
9084
9085 apex_key {
9086 name: "myapex.key",
9087 public_key: "testkey.avbpubkey",
9088 private_key: "testkey.pem",
9089 }
9090
9091 cc_library {
9092 name: "mylib",
9093 srcs: ["mylib.cpp"],
9094 system_shared_libs: [],
9095 stl: "none",
9096 apex_available: ["myapex"],
9097 shared_libs: ["mylib2"],
9098 target: {
9099 apex: {
9100 exclude_shared_libs: ["mylib2"],
9101 },
9102 },
9103 }
9104
9105 cc_library {
9106 name: "mylib2",
9107 srcs: ["mylib.cpp"],
9108 system_shared_libs: [],
9109 stl: "none",
9110 }
9111 `)
9112
9113 // Check if mylib is linked to mylib2 for the non-apex target
9114 ldFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
9115 ensureContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
9116
9117 // Make sure that the link doesn't occur for the apex target
9118 ldFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
9119 ensureNotContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared_apex10000/mylib2.so")
9120
9121 // It shouldn't appear in the copy cmd as well.
Jooyung Hana0503a52023-08-23 13:12:50 +09009122 copyCmds := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("apexRule").Args["copy_commands"]
Jiyong Parke3867542020-12-03 17:28:25 +09009123 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
9124}
9125
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09009126func TestPrebuiltStubLibDep(t *testing.T) {
9127 bpBase := `
9128 apex {
9129 name: "myapex",
9130 key: "myapex.key",
9131 native_shared_libs: ["mylib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00009132 updatable: false,
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09009133 }
9134 apex_key {
9135 name: "myapex.key",
9136 public_key: "testkey.avbpubkey",
9137 private_key: "testkey.pem",
9138 }
9139 cc_library {
9140 name: "mylib",
9141 srcs: ["mylib.cpp"],
9142 apex_available: ["myapex"],
9143 shared_libs: ["stublib"],
9144 system_shared_libs: [],
9145 }
9146 apex {
9147 name: "otherapex",
9148 enabled: %s,
9149 key: "myapex.key",
9150 native_shared_libs: ["stublib"],
Mathew Inwoodf8dcf5e2021-02-16 11:40:16 +00009151 updatable: false,
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09009152 }
9153 `
9154
9155 stublibSourceBp := `
9156 cc_library {
9157 name: "stublib",
9158 srcs: ["mylib.cpp"],
9159 apex_available: ["otherapex"],
9160 system_shared_libs: [],
9161 stl: "none",
9162 stubs: {
9163 versions: ["1"],
9164 },
9165 }
9166 `
9167
9168 stublibPrebuiltBp := `
9169 cc_prebuilt_library_shared {
9170 name: "stublib",
9171 srcs: ["prebuilt.so"],
9172 apex_available: ["otherapex"],
9173 stubs: {
9174 versions: ["1"],
9175 },
9176 %s
9177 }
9178 `
9179
9180 tests := []struct {
9181 name string
9182 stublibBp string
9183 usePrebuilt bool
9184 modNames []string // Modules to collect AndroidMkEntries for
9185 otherApexEnabled []string
9186 }{
9187 {
9188 name: "only_source",
9189 stublibBp: stublibSourceBp,
9190 usePrebuilt: false,
9191 modNames: []string{"stublib"},
9192 otherApexEnabled: []string{"true", "false"},
9193 },
9194 {
9195 name: "source_preferred",
9196 stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, ""),
9197 usePrebuilt: false,
9198 modNames: []string{"stublib", "prebuilt_stublib"},
9199 otherApexEnabled: []string{"true", "false"},
9200 },
9201 {
9202 name: "prebuilt_preferred",
9203 stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, "prefer: true,"),
9204 usePrebuilt: true,
9205 modNames: []string{"stublib", "prebuilt_stublib"},
9206 otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
9207 },
9208 {
9209 name: "only_prebuilt",
9210 stublibBp: fmt.Sprintf(stublibPrebuiltBp, ""),
9211 usePrebuilt: true,
9212 modNames: []string{"stublib"},
9213 otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
9214 },
9215 }
9216
9217 for _, test := range tests {
9218 t.Run(test.name, func(t *testing.T) {
9219 for _, otherApexEnabled := range test.otherApexEnabled {
9220 t.Run("otherapex_enabled_"+otherApexEnabled, func(t *testing.T) {
Colin Cross1c460562021-02-16 17:55:47 -08009221 ctx := testApex(t, fmt.Sprintf(bpBase, otherApexEnabled)+test.stublibBp)
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09009222
9223 type modAndMkEntries struct {
9224 mod *cc.Module
9225 mkEntries android.AndroidMkEntries
9226 }
9227 entries := []*modAndMkEntries{}
9228
9229 // Gather shared lib modules that are installable
9230 for _, modName := range test.modNames {
9231 for _, variant := range ctx.ModuleVariantsForTests(modName) {
9232 if !strings.HasPrefix(variant, "android_arm64_armv8-a_shared") {
9233 continue
9234 }
9235 mod := ctx.ModuleForTests(modName, variant).Module().(*cc.Module)
Cole Fausta963b942024-04-11 17:43:00 -07009236 if !mod.Enabled(android.PanickingConfigAndErrorContext(ctx)) || mod.IsHideFromMake() {
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09009237 continue
9238 }
Colin Crossaa255532020-07-03 13:18:24 -07009239 for _, ent := range android.AndroidMkEntriesForTest(t, ctx, mod) {
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09009240 if ent.Disabled {
9241 continue
9242 }
9243 entries = append(entries, &modAndMkEntries{
9244 mod: mod,
9245 mkEntries: ent,
9246 })
9247 }
9248 }
9249 }
9250
9251 var entry *modAndMkEntries = nil
9252 for _, ent := range entries {
9253 if strings.Join(ent.mkEntries.EntryMap["LOCAL_MODULE"], ",") == "stublib" {
9254 if entry != nil {
9255 t.Errorf("More than one AndroidMk entry for \"stublib\": %s and %s", entry.mod, ent.mod)
9256 } else {
9257 entry = ent
9258 }
9259 }
9260 }
9261
9262 if entry == nil {
9263 t.Errorf("AndroidMk entry for \"stublib\" missing")
9264 } else {
9265 isPrebuilt := entry.mod.Prebuilt() != nil
9266 if isPrebuilt != test.usePrebuilt {
9267 t.Errorf("Wrong module for \"stublib\" AndroidMk entry: got prebuilt %t, want prebuilt %t", isPrebuilt, test.usePrebuilt)
9268 }
9269 if !entry.mod.IsStubs() {
9270 t.Errorf("Module for \"stublib\" AndroidMk entry isn't a stub: %s", entry.mod)
9271 }
9272 if entry.mkEntries.EntryMap["LOCAL_NOT_AVAILABLE_FOR_PLATFORM"] != nil {
9273 t.Errorf("AndroidMk entry for \"stublib\" has LOCAL_NOT_AVAILABLE_FOR_PLATFORM set: %+v", entry.mkEntries)
9274 }
Jiyong Park892a98f2020-12-14 09:20:00 +09009275 cflags := entry.mkEntries.EntryMap["LOCAL_EXPORT_CFLAGS"]
Jiyong Parkd4a3a132021-03-17 20:21:35 +09009276 expected := "-D__STUBLIB_API__=10000"
Jiyong Park892a98f2020-12-14 09:20:00 +09009277 if !android.InList(expected, cflags) {
9278 t.Errorf("LOCAL_EXPORT_CFLAGS expected to have %q, but got %q", expected, cflags)
9279 }
Jiyong Parkf7c3bbe2020-12-09 21:18:56 +09009280 }
9281 })
9282 }
9283 })
9284 }
9285}
9286
Colin Crossc33e5212021-05-25 18:16:02 -07009287func TestApexJavaCoverage(t *testing.T) {
9288 bp := `
9289 apex {
9290 name: "myapex",
9291 key: "myapex.key",
9292 java_libs: ["mylib"],
9293 bootclasspath_fragments: ["mybootclasspathfragment"],
9294 systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
9295 updatable: false,
9296 }
9297
9298 apex_key {
9299 name: "myapex.key",
9300 public_key: "testkey.avbpubkey",
9301 private_key: "testkey.pem",
9302 }
9303
9304 java_library {
9305 name: "mylib",
9306 srcs: ["mylib.java"],
9307 apex_available: ["myapex"],
9308 compile_dex: true,
9309 }
9310
9311 bootclasspath_fragment {
9312 name: "mybootclasspathfragment",
9313 contents: ["mybootclasspathlib"],
9314 apex_available: ["myapex"],
Paul Duffin9fd56472022-03-31 15:42:30 +01009315 hidden_api: {
9316 split_packages: ["*"],
9317 },
Colin Crossc33e5212021-05-25 18:16:02 -07009318 }
9319
9320 java_library {
9321 name: "mybootclasspathlib",
9322 srcs: ["mybootclasspathlib.java"],
9323 apex_available: ["myapex"],
9324 compile_dex: true,
9325 }
9326
9327 systemserverclasspath_fragment {
9328 name: "mysystemserverclasspathfragment",
9329 contents: ["mysystemserverclasspathlib"],
9330 apex_available: ["myapex"],
9331 }
9332
9333 java_library {
9334 name: "mysystemserverclasspathlib",
9335 srcs: ["mysystemserverclasspathlib.java"],
9336 apex_available: ["myapex"],
9337 compile_dex: true,
9338 }
9339 `
9340
9341 result := android.GroupFixturePreparers(
9342 PrepareForTestWithApexBuildComponents,
9343 prepareForTestWithMyapex,
9344 java.PrepareForTestWithJavaDefaultModules,
9345 android.PrepareForTestWithAndroidBuildComponents,
9346 android.FixtureWithRootAndroidBp(bp),
satayevabcd5972021-08-06 17:49:46 +01009347 dexpreopt.FixtureSetApexBootJars("myapex:mybootclasspathlib"),
9348 dexpreopt.FixtureSetApexSystemServerJars("myapex:mysystemserverclasspathlib"),
Sam Delmerico1e3f78f2022-09-07 12:07:07 -04009349 java.PrepareForTestWithJacocoInstrumentation,
Colin Crossc33e5212021-05-25 18:16:02 -07009350 ).RunTest(t)
9351
9352 // Make sure jacoco ran on both mylib and mybootclasspathlib
9353 if result.ModuleForTests("mylib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
9354 t.Errorf("Failed to find jacoco rule for mylib")
9355 }
9356 if result.ModuleForTests("mybootclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
9357 t.Errorf("Failed to find jacoco rule for mybootclasspathlib")
9358 }
9359 if result.ModuleForTests("mysystemserverclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
9360 t.Errorf("Failed to find jacoco rule for mysystemserverclasspathlib")
9361 }
9362}
9363
Jiyong Park192600a2021-08-03 07:52:17 +00009364func TestProhibitStaticExecutable(t *testing.T) {
9365 testApexError(t, `executable mybin is static`, `
9366 apex {
9367 name: "myapex",
9368 key: "myapex.key",
9369 binaries: ["mybin"],
9370 min_sdk_version: "29",
9371 }
9372
9373 apex_key {
9374 name: "myapex.key",
9375 public_key: "testkey.avbpubkey",
9376 private_key: "testkey.pem",
9377 }
9378
9379 cc_binary {
9380 name: "mybin",
9381 srcs: ["mylib.cpp"],
9382 relative_install_path: "foo/bar",
9383 static_executable: true,
9384 system_shared_libs: [],
9385 stl: "none",
9386 apex_available: [ "myapex" ],
Jiyong Parkd12979d2021-08-03 13:36:09 +09009387 min_sdk_version: "29",
9388 }
9389 `)
9390
9391 testApexError(t, `executable mybin.rust is static`, `
9392 apex {
9393 name: "myapex",
9394 key: "myapex.key",
9395 binaries: ["mybin.rust"],
9396 min_sdk_version: "29",
9397 }
9398
9399 apex_key {
9400 name: "myapex.key",
9401 public_key: "testkey.avbpubkey",
9402 private_key: "testkey.pem",
9403 }
9404
9405 rust_binary {
9406 name: "mybin.rust",
9407 srcs: ["foo.rs"],
9408 static_executable: true,
9409 apex_available: ["myapex"],
9410 min_sdk_version: "29",
Jiyong Park192600a2021-08-03 07:52:17 +00009411 }
9412 `)
9413}
9414
Jiakai Zhang470b7e22021-09-30 09:34:26 +00009415func TestAndroidMk_DexpreoptBuiltInstalledForApex(t *testing.T) {
9416 ctx := testApex(t, `
9417 apex {
9418 name: "myapex",
9419 key: "myapex.key",
9420 updatable: false,
9421 java_libs: ["foo"],
9422 }
9423
9424 apex_key {
9425 name: "myapex.key",
9426 public_key: "testkey.avbpubkey",
9427 private_key: "testkey.pem",
9428 }
9429
9430 java_library {
9431 name: "foo",
9432 srcs: ["foo.java"],
9433 apex_available: ["myapex"],
9434 installable: true,
9435 }
9436 `,
9437 dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"),
9438 )
9439
Jooyung Hana0503a52023-08-23 13:12:50 +09009440 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*apexBundle)
Jiakai Zhang470b7e22021-09-30 09:34:26 +00009441 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
9442 var builder strings.Builder
9443 data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
9444 androidMk := builder.String()
Jooyung Haneec1b3f2023-06-20 16:25:59 +09009445 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := foo.myapex foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.odex foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.vdex\n")
Jiakai Zhang470b7e22021-09-30 09:34:26 +00009446}
9447
9448func TestAndroidMk_DexpreoptBuiltInstalledForApex_Prebuilt(t *testing.T) {
9449 ctx := testApex(t, `
9450 prebuilt_apex {
9451 name: "myapex",
9452 arch: {
9453 arm64: {
9454 src: "myapex-arm64.apex",
9455 },
9456 arm: {
9457 src: "myapex-arm.apex",
9458 },
9459 },
9460 exported_java_libs: ["foo"],
9461 }
9462
9463 java_import {
9464 name: "foo",
9465 jars: ["foo.jar"],
Jiakai Zhang28bc9a82021-12-20 15:08:57 +00009466 apex_available: ["myapex"],
Jiakai Zhang470b7e22021-09-30 09:34:26 +00009467 }
9468 `,
9469 dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"),
9470 )
9471
9472 prebuilt := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt)
9473 entriesList := android.AndroidMkEntriesForTest(t, ctx, prebuilt)
9474 mainModuleEntries := entriesList[0]
9475 android.AssertArrayString(t,
9476 "LOCAL_REQUIRED_MODULES",
9477 mainModuleEntries.EntryMap["LOCAL_REQUIRED_MODULES"],
9478 []string{
9479 "foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.odex",
9480 "foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.vdex",
9481 })
9482}
9483
Jiyong Parkcacc4f32021-10-28 14:26:03 +09009484func TestAndroidMk_RequiredModules(t *testing.T) {
9485 ctx := testApex(t, `
9486 apex {
9487 name: "myapex",
9488 key: "myapex.key",
9489 updatable: false,
9490 java_libs: ["foo"],
9491 required: ["otherapex"],
9492 }
9493
9494 apex {
9495 name: "otherapex",
9496 key: "myapex.key",
9497 updatable: false,
9498 java_libs: ["foo"],
Jiyong Parkcacc4f32021-10-28 14:26:03 +09009499 }
9500
9501 apex_key {
9502 name: "myapex.key",
9503 public_key: "testkey.avbpubkey",
9504 private_key: "testkey.pem",
9505 }
9506
9507 java_library {
9508 name: "foo",
9509 srcs: ["foo.java"],
9510 apex_available: ["myapex", "otherapex"],
9511 installable: true,
9512 }
9513 `)
9514
Jooyung Hana0503a52023-08-23 13:12:50 +09009515 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*apexBundle)
Jiyong Parkcacc4f32021-10-28 14:26:03 +09009516 data := android.AndroidMkDataForTest(t, ctx, apexBundle)
9517 var builder strings.Builder
9518 data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
9519 androidMk := builder.String()
Jooyung Haneec1b3f2023-06-20 16:25:59 +09009520 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := foo.myapex otherapex")
Jiyong Parkcacc4f32021-10-28 14:26:03 +09009521}
9522
Jiakai Zhangd70dff72022-02-24 15:06:05 +00009523func TestAndroidMk_RequiredDeps(t *testing.T) {
9524 ctx := testApex(t, `
9525 apex {
9526 name: "myapex",
9527 key: "myapex.key",
9528 updatable: false,
9529 }
9530
9531 apex_key {
9532 name: "myapex.key",
9533 public_key: "testkey.avbpubkey",
9534 private_key: "testkey.pem",
9535 }
9536 `)
9537
Jooyung Hana0503a52023-08-23 13:12:50 +09009538 bundle := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*apexBundle)
Jingwen Chen29743c82023-01-25 17:49:46 +00009539 bundle.makeModulesToInstall = append(bundle.makeModulesToInstall, "foo")
Jiakai Zhangd70dff72022-02-24 15:06:05 +00009540 data := android.AndroidMkDataForTest(t, ctx, bundle)
9541 var builder strings.Builder
9542 data.Custom(&builder, bundle.BaseModuleName(), "TARGET_", "", data)
9543 androidMk := builder.String()
Jooyung Haneec1b3f2023-06-20 16:25:59 +09009544 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := foo\n")
Jiakai Zhangd70dff72022-02-24 15:06:05 +00009545}
9546
Jooyung Hana6d36672022-02-24 13:58:07 +09009547func TestApexOutputFileProducer(t *testing.T) {
9548 for _, tc := range []struct {
9549 name string
9550 ref string
9551 expected_data []string
9552 }{
9553 {
9554 name: "test_using_output",
9555 ref: ":myapex",
Jooyung Hana0503a52023-08-23 13:12:50 +09009556 expected_data: []string{"out/soong/.intermediates/myapex/android_common_myapex/myapex.capex:myapex.capex"},
Jooyung Hana6d36672022-02-24 13:58:07 +09009557 },
9558 {
9559 name: "test_using_apex",
9560 ref: ":myapex{.apex}",
Jooyung Hana0503a52023-08-23 13:12:50 +09009561 expected_data: []string{"out/soong/.intermediates/myapex/android_common_myapex/myapex.apex:myapex.apex"},
Jooyung Hana6d36672022-02-24 13:58:07 +09009562 },
9563 } {
9564 t.Run(tc.name, func(t *testing.T) {
9565 ctx := testApex(t, `
9566 apex {
9567 name: "myapex",
9568 key: "myapex.key",
9569 compressible: true,
9570 updatable: false,
9571 }
9572
9573 apex_key {
9574 name: "myapex.key",
9575 public_key: "testkey.avbpubkey",
9576 private_key: "testkey.pem",
9577 }
9578
9579 java_test {
9580 name: "`+tc.name+`",
9581 srcs: ["a.java"],
9582 data: ["`+tc.ref+`"],
9583 }
9584 `,
9585 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
9586 variables.CompressedApex = proptools.BoolPtr(true)
9587 }))
9588 javaTest := ctx.ModuleForTests(tc.name, "android_common").Module().(*java.Test)
9589 data := android.AndroidMkEntriesForTest(t, ctx, javaTest)[0].EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
9590 android.AssertStringPathsRelativeToTopEquals(t, "data", ctx.Config(), tc.expected_data, data)
9591 })
9592 }
9593}
9594
satayev758968a2021-12-06 11:42:40 +00009595func TestSdkLibraryCanHaveHigherMinSdkVersion(t *testing.T) {
9596 preparer := android.GroupFixturePreparers(
9597 PrepareForTestWithApexBuildComponents,
9598 prepareForTestWithMyapex,
9599 java.PrepareForTestWithJavaSdkLibraryFiles,
9600 java.PrepareForTestWithJavaDefaultModules,
9601 android.PrepareForTestWithAndroidBuildComponents,
9602 dexpreopt.FixtureSetApexBootJars("myapex:mybootclasspathlib"),
9603 dexpreopt.FixtureSetApexSystemServerJars("myapex:mysystemserverclasspathlib"),
9604 )
9605
9606 // Test java_sdk_library in bootclasspath_fragment may define higher min_sdk_version than the apex
9607 t.Run("bootclasspath_fragment jar has higher min_sdk_version than apex", func(t *testing.T) {
9608 preparer.RunTestWithBp(t, `
9609 apex {
9610 name: "myapex",
9611 key: "myapex.key",
9612 bootclasspath_fragments: ["mybootclasspathfragment"],
9613 min_sdk_version: "30",
9614 updatable: false,
9615 }
9616
9617 apex_key {
9618 name: "myapex.key",
9619 public_key: "testkey.avbpubkey",
9620 private_key: "testkey.pem",
9621 }
9622
9623 bootclasspath_fragment {
9624 name: "mybootclasspathfragment",
9625 contents: ["mybootclasspathlib"],
9626 apex_available: ["myapex"],
Paul Duffin9fd56472022-03-31 15:42:30 +01009627 hidden_api: {
9628 split_packages: ["*"],
9629 },
satayev758968a2021-12-06 11:42:40 +00009630 }
9631
9632 java_sdk_library {
9633 name: "mybootclasspathlib",
9634 srcs: ["mybootclasspathlib.java"],
9635 apex_available: ["myapex"],
9636 compile_dex: true,
9637 unsafe_ignore_missing_latest_api: true,
9638 min_sdk_version: "31",
9639 static_libs: ["util"],
9640 }
9641
9642 java_library {
9643 name: "util",
9644 srcs: ["a.java"],
9645 apex_available: ["myapex"],
9646 min_sdk_version: "31",
9647 static_libs: ["another_util"],
9648 }
9649
9650 java_library {
9651 name: "another_util",
9652 srcs: ["a.java"],
9653 min_sdk_version: "31",
9654 apex_available: ["myapex"],
9655 }
9656 `)
9657 })
9658
9659 // Test java_sdk_library in systemserverclasspath_fragment may define higher min_sdk_version than the apex
9660 t.Run("systemserverclasspath_fragment jar has higher min_sdk_version than apex", func(t *testing.T) {
9661 preparer.RunTestWithBp(t, `
9662 apex {
9663 name: "myapex",
9664 key: "myapex.key",
9665 systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
9666 min_sdk_version: "30",
9667 updatable: false,
9668 }
9669
9670 apex_key {
9671 name: "myapex.key",
9672 public_key: "testkey.avbpubkey",
9673 private_key: "testkey.pem",
9674 }
9675
9676 systemserverclasspath_fragment {
9677 name: "mysystemserverclasspathfragment",
9678 contents: ["mysystemserverclasspathlib"],
9679 apex_available: ["myapex"],
9680 }
9681
9682 java_sdk_library {
9683 name: "mysystemserverclasspathlib",
9684 srcs: ["mysystemserverclasspathlib.java"],
9685 apex_available: ["myapex"],
9686 compile_dex: true,
9687 min_sdk_version: "32",
9688 unsafe_ignore_missing_latest_api: true,
9689 static_libs: ["util"],
9690 }
9691
9692 java_library {
9693 name: "util",
9694 srcs: ["a.java"],
9695 apex_available: ["myapex"],
9696 min_sdk_version: "31",
9697 static_libs: ["another_util"],
9698 }
9699
9700 java_library {
9701 name: "another_util",
9702 srcs: ["a.java"],
9703 min_sdk_version: "31",
9704 apex_available: ["myapex"],
9705 }
9706 `)
9707 })
9708
9709 t.Run("bootclasspath_fragment jar must set min_sdk_version", func(t *testing.T) {
9710 preparer.ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`module "mybootclasspathlib".*must set min_sdk_version`)).
9711 RunTestWithBp(t, `
9712 apex {
9713 name: "myapex",
9714 key: "myapex.key",
9715 bootclasspath_fragments: ["mybootclasspathfragment"],
9716 min_sdk_version: "30",
9717 updatable: false,
9718 }
9719
9720 apex_key {
9721 name: "myapex.key",
9722 public_key: "testkey.avbpubkey",
9723 private_key: "testkey.pem",
9724 }
9725
9726 bootclasspath_fragment {
9727 name: "mybootclasspathfragment",
9728 contents: ["mybootclasspathlib"],
9729 apex_available: ["myapex"],
Paul Duffin9fd56472022-03-31 15:42:30 +01009730 hidden_api: {
9731 split_packages: ["*"],
9732 },
satayev758968a2021-12-06 11:42:40 +00009733 }
9734
9735 java_sdk_library {
9736 name: "mybootclasspathlib",
9737 srcs: ["mybootclasspathlib.java"],
9738 apex_available: ["myapex"],
9739 compile_dex: true,
9740 unsafe_ignore_missing_latest_api: true,
9741 }
9742 `)
9743 })
9744
9745 t.Run("systemserverclasspath_fragment jar must set min_sdk_version", func(t *testing.T) {
9746 preparer.ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`module "mysystemserverclasspathlib".*must set min_sdk_version`)).
9747 RunTestWithBp(t, `
9748 apex {
9749 name: "myapex",
9750 key: "myapex.key",
9751 systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
9752 min_sdk_version: "30",
9753 updatable: false,
9754 }
9755
9756 apex_key {
9757 name: "myapex.key",
9758 public_key: "testkey.avbpubkey",
9759 private_key: "testkey.pem",
9760 }
9761
9762 systemserverclasspath_fragment {
9763 name: "mysystemserverclasspathfragment",
9764 contents: ["mysystemserverclasspathlib"],
9765 apex_available: ["myapex"],
9766 }
9767
9768 java_sdk_library {
9769 name: "mysystemserverclasspathlib",
9770 srcs: ["mysystemserverclasspathlib.java"],
9771 apex_available: ["myapex"],
9772 compile_dex: true,
9773 unsafe_ignore_missing_latest_api: true,
9774 }
9775 `)
9776 })
9777}
9778
Jiakai Zhang6decef92022-01-12 17:56:19 +00009779// Verifies that the APEX depends on all the Make modules in the list.
9780func ensureContainsRequiredDeps(t *testing.T, ctx *android.TestContext, moduleName, variant string, deps []string) {
9781 a := ctx.ModuleForTests(moduleName, variant).Module().(*apexBundle)
9782 for _, dep := range deps {
Jingwen Chen29743c82023-01-25 17:49:46 +00009783 android.AssertStringListContains(t, "", a.makeModulesToInstall, dep)
Jiakai Zhang6decef92022-01-12 17:56:19 +00009784 }
9785}
9786
9787// Verifies that the APEX does not depend on any of the Make modules in the list.
9788func ensureDoesNotContainRequiredDeps(t *testing.T, ctx *android.TestContext, moduleName, variant string, deps []string) {
9789 a := ctx.ModuleForTests(moduleName, variant).Module().(*apexBundle)
9790 for _, dep := range deps {
Jingwen Chen29743c82023-01-25 17:49:46 +00009791 android.AssertStringListDoesNotContain(t, "", a.makeModulesToInstall, dep)
Jiakai Zhang6decef92022-01-12 17:56:19 +00009792 }
9793}
9794
Cole Faust1021ccd2023-02-26 21:15:25 -08009795// TODO(b/193460475): Re-enable this test
9796//func TestApexStrictUpdtabilityLint(t *testing.T) {
9797// bpTemplate := `
9798// apex {
9799// name: "myapex",
9800// key: "myapex.key",
9801// java_libs: ["myjavalib"],
9802// updatable: %v,
9803// min_sdk_version: "29",
9804// }
9805// apex_key {
9806// name: "myapex.key",
9807// }
9808// java_library {
9809// name: "myjavalib",
9810// srcs: ["MyClass.java"],
9811// apex_available: [ "myapex" ],
9812// lint: {
9813// strict_updatability_linting: %v,
9814// },
9815// sdk_version: "current",
9816// min_sdk_version: "29",
9817// }
9818// `
9819// fs := android.MockFS{
9820// "lint-baseline.xml": nil,
9821// }
9822//
9823// testCases := []struct {
9824// testCaseName string
9825// apexUpdatable bool
9826// javaStrictUpdtabilityLint bool
9827// lintFileExists bool
9828// disallowedFlagExpected bool
9829// }{
9830// {
9831// testCaseName: "lint-baseline.xml does not exist, no disallowed flag necessary in lint cmd",
9832// apexUpdatable: true,
9833// javaStrictUpdtabilityLint: true,
9834// lintFileExists: false,
9835// disallowedFlagExpected: false,
9836// },
9837// {
9838// testCaseName: "non-updatable apex respects strict_updatability of javalib",
9839// apexUpdatable: false,
9840// javaStrictUpdtabilityLint: false,
9841// lintFileExists: true,
9842// disallowedFlagExpected: false,
9843// },
9844// {
9845// testCaseName: "non-updatable apex respects strict updatability of javalib",
9846// apexUpdatable: false,
9847// javaStrictUpdtabilityLint: true,
9848// lintFileExists: true,
9849// disallowedFlagExpected: true,
9850// },
9851// {
9852// testCaseName: "updatable apex sets strict updatability of javalib to true",
9853// apexUpdatable: true,
9854// javaStrictUpdtabilityLint: false, // will be set to true by mutator
9855// lintFileExists: true,
9856// disallowedFlagExpected: true,
9857// },
9858// }
9859//
9860// for _, testCase := range testCases {
9861// bp := fmt.Sprintf(bpTemplate, testCase.apexUpdatable, testCase.javaStrictUpdtabilityLint)
9862// fixtures := []android.FixturePreparer{}
9863// if testCase.lintFileExists {
9864// fixtures = append(fixtures, fs.AddToFixture())
9865// }
9866//
9867// result := testApex(t, bp, fixtures...)
9868// myjavalib := result.ModuleForTests("myjavalib", "android_common_apex29")
9869// sboxProto := android.RuleBuilderSboxProtoForTests(t, myjavalib.Output("lint.sbox.textproto"))
9870// disallowedFlagActual := strings.Contains(*sboxProto.Commands[0].Command, "--baseline lint-baseline.xml --disallowed_issues NewApi")
9871//
9872// if disallowedFlagActual != testCase.disallowedFlagExpected {
9873// t.Errorf("Failed testcase: %v \nActual lint cmd: %v", testCase.testCaseName, *sboxProto.Commands[0].Command)
9874// }
9875// }
9876//}
9877//
9878//func TestUpdatabilityLintSkipLibcore(t *testing.T) {
9879// bp := `
9880// apex {
9881// name: "myapex",
9882// key: "myapex.key",
9883// java_libs: ["myjavalib"],
9884// updatable: true,
9885// min_sdk_version: "29",
9886// }
9887// apex_key {
9888// name: "myapex.key",
9889// }
9890// java_library {
9891// name: "myjavalib",
9892// srcs: ["MyClass.java"],
9893// apex_available: [ "myapex" ],
9894// sdk_version: "current",
9895// min_sdk_version: "29",
9896// }
9897// `
9898//
9899// testCases := []struct {
9900// testCaseName string
9901// moduleDirectory string
9902// disallowedFlagExpected bool
9903// }{
9904// {
9905// testCaseName: "lintable module defined outside libcore",
9906// moduleDirectory: "",
9907// disallowedFlagExpected: true,
9908// },
9909// {
9910// testCaseName: "lintable module defined in libcore root directory",
9911// moduleDirectory: "libcore/",
9912// disallowedFlagExpected: false,
9913// },
9914// {
9915// testCaseName: "lintable module defined in libcore child directory",
9916// moduleDirectory: "libcore/childdir/",
9917// disallowedFlagExpected: true,
9918// },
9919// }
9920//
9921// for _, testCase := range testCases {
9922// lintFileCreator := android.FixtureAddTextFile(testCase.moduleDirectory+"lint-baseline.xml", "")
9923// bpFileCreator := android.FixtureAddTextFile(testCase.moduleDirectory+"Android.bp", bp)
9924// result := testApex(t, "", lintFileCreator, bpFileCreator)
9925// myjavalib := result.ModuleForTests("myjavalib", "android_common_apex29")
9926// sboxProto := android.RuleBuilderSboxProtoForTests(t, myjavalib.Output("lint.sbox.textproto"))
9927// cmdFlags := fmt.Sprintf("--baseline %vlint-baseline.xml --disallowed_issues NewApi", testCase.moduleDirectory)
9928// disallowedFlagActual := strings.Contains(*sboxProto.Commands[0].Command, cmdFlags)
9929//
9930// if disallowedFlagActual != testCase.disallowedFlagExpected {
9931// t.Errorf("Failed testcase: %v \nActual lint cmd: %v", testCase.testCaseName, *sboxProto.Commands[0].Command)
9932// }
9933// }
9934//}
9935//
9936//// checks transtive deps of an apex coming from bootclasspath_fragment
9937//func TestApexStrictUpdtabilityLintBcpFragmentDeps(t *testing.T) {
9938// bp := `
9939// apex {
9940// name: "myapex",
9941// key: "myapex.key",
9942// bootclasspath_fragments: ["mybootclasspathfragment"],
9943// updatable: true,
9944// min_sdk_version: "29",
9945// }
9946// apex_key {
9947// name: "myapex.key",
9948// }
9949// bootclasspath_fragment {
9950// name: "mybootclasspathfragment",
9951// contents: ["myjavalib"],
9952// apex_available: ["myapex"],
9953// hidden_api: {
9954// split_packages: ["*"],
9955// },
9956// }
9957// java_library {
9958// name: "myjavalib",
9959// srcs: ["MyClass.java"],
9960// apex_available: [ "myapex" ],
9961// sdk_version: "current",
9962// min_sdk_version: "29",
9963// compile_dex: true,
9964// }
9965// `
9966// fs := android.MockFS{
9967// "lint-baseline.xml": nil,
9968// }
9969//
9970// result := testApex(t, bp, dexpreopt.FixtureSetApexBootJars("myapex:myjavalib"), fs.AddToFixture())
9971// myjavalib := result.ModuleForTests("myjavalib", "android_common_apex29")
9972// sboxProto := android.RuleBuilderSboxProtoForTests(t, myjavalib.Output("lint.sbox.textproto"))
9973// if !strings.Contains(*sboxProto.Commands[0].Command, "--baseline lint-baseline.xml --disallowed_issues NewApi") {
9974// t.Errorf("Strict updabality lint missing in myjavalib coming from bootclasspath_fragment mybootclasspath-fragment\nActual lint cmd: %v", *sboxProto.Commands[0].Command)
9975// }
9976//}
Spandan Das66773252022-01-15 00:23:18 +00009977
Spandan Das42e89502022-05-06 22:12:55 +00009978// updatable apexes should propagate updatable=true to its apps
9979func TestUpdatableApexEnforcesAppUpdatability(t *testing.T) {
9980 bp := `
9981 apex {
9982 name: "myapex",
9983 key: "myapex.key",
9984 updatable: %v,
9985 apps: [
9986 "myapp",
9987 ],
9988 min_sdk_version: "30",
9989 }
9990 apex_key {
9991 name: "myapex.key",
9992 }
9993 android_app {
9994 name: "myapp",
9995 updatable: %v,
9996 apex_available: [
9997 "myapex",
9998 ],
9999 sdk_version: "current",
10000 min_sdk_version: "30",
10001 }
10002 `
10003 testCases := []struct {
10004 name string
10005 apex_is_updatable_bp bool
10006 app_is_updatable_bp bool
10007 app_is_updatable_expected bool
10008 }{
10009 {
10010 name: "Non-updatable apex respects updatable property of non-updatable app",
10011 apex_is_updatable_bp: false,
10012 app_is_updatable_bp: false,
10013 app_is_updatable_expected: false,
10014 },
10015 {
10016 name: "Non-updatable apex respects updatable property of updatable app",
10017 apex_is_updatable_bp: false,
10018 app_is_updatable_bp: true,
10019 app_is_updatable_expected: true,
10020 },
10021 {
10022 name: "Updatable apex respects updatable property of updatable app",
10023 apex_is_updatable_bp: true,
10024 app_is_updatable_bp: true,
10025 app_is_updatable_expected: true,
10026 },
10027 {
10028 name: "Updatable apex sets updatable=true on non-updatable app",
10029 apex_is_updatable_bp: true,
10030 app_is_updatable_bp: false,
10031 app_is_updatable_expected: true,
10032 },
10033 }
10034 for _, testCase := range testCases {
10035 result := testApex(t, fmt.Sprintf(bp, testCase.apex_is_updatable_bp, testCase.app_is_updatable_bp))
10036 myapp := result.ModuleForTests("myapp", "android_common").Module().(*java.AndroidApp)
10037 android.AssertBoolEquals(t, testCase.name, testCase.app_is_updatable_expected, myapp.Updatable())
10038 }
10039}
10040
Kiyoung Kim487689e2022-07-26 09:48:22 +090010041func TestApexBuildsAgainstApiSurfaceStubLibraries(t *testing.T) {
10042 bp := `
10043 apex {
10044 name: "myapex",
10045 key: "myapex.key",
Kiyoung Kim76b06f32023-02-06 22:08:13 +090010046 native_shared_libs: ["libbaz"],
10047 binaries: ["binfoo"],
Kiyoung Kim487689e2022-07-26 09:48:22 +090010048 min_sdk_version: "29",
10049 }
10050 apex_key {
10051 name: "myapex.key",
10052 }
Kiyoung Kim76b06f32023-02-06 22:08:13 +090010053 cc_binary {
10054 name: "binfoo",
10055 shared_libs: ["libbar", "libbaz", "libqux",],
Kiyoung Kim487689e2022-07-26 09:48:22 +090010056 apex_available: ["myapex"],
10057 min_sdk_version: "29",
Kiyoung Kim76b06f32023-02-06 22:08:13 +090010058 recovery_available: false,
10059 }
10060 cc_library {
10061 name: "libbar",
10062 srcs: ["libbar.cc"],
10063 stubs: {
10064 symbol_file: "libbar.map.txt",
10065 versions: [
10066 "29",
10067 ],
10068 },
10069 }
10070 cc_library {
10071 name: "libbaz",
10072 srcs: ["libbaz.cc"],
10073 apex_available: ["myapex"],
10074 min_sdk_version: "29",
10075 stubs: {
10076 symbol_file: "libbaz.map.txt",
10077 versions: [
10078 "29",
10079 ],
10080 },
Kiyoung Kim487689e2022-07-26 09:48:22 +090010081 }
10082 cc_api_library {
Kiyoung Kim76b06f32023-02-06 22:08:13 +090010083 name: "libbar",
10084 src: "libbar_stub.so",
Kiyoung Kim487689e2022-07-26 09:48:22 +090010085 min_sdk_version: "29",
Kiyoung Kim76b06f32023-02-06 22:08:13 +090010086 variants: ["apex.29"],
10087 }
10088 cc_api_variant {
10089 name: "libbar",
10090 variant: "apex",
10091 version: "29",
10092 src: "libbar_apex_29.so",
10093 }
10094 cc_api_library {
10095 name: "libbaz",
10096 src: "libbaz_stub.so",
10097 min_sdk_version: "29",
10098 variants: ["apex.29"],
10099 }
10100 cc_api_variant {
10101 name: "libbaz",
10102 variant: "apex",
10103 version: "29",
10104 src: "libbaz_apex_29.so",
10105 }
10106 cc_api_library {
10107 name: "libqux",
10108 src: "libqux_stub.so",
10109 min_sdk_version: "29",
10110 variants: ["apex.29"],
10111 }
10112 cc_api_variant {
10113 name: "libqux",
10114 variant: "apex",
10115 version: "29",
10116 src: "libqux_apex_29.so",
Kiyoung Kim487689e2022-07-26 09:48:22 +090010117 }
10118 api_imports {
10119 name: "api_imports",
Kiyoung Kim76b06f32023-02-06 22:08:13 +090010120 apex_shared_libs: [
10121 "libbar",
10122 "libbaz",
10123 "libqux",
Kiyoung Kim487689e2022-07-26 09:48:22 +090010124 ],
Kiyoung Kim487689e2022-07-26 09:48:22 +090010125 }
10126 `
10127 result := testApex(t, bp)
10128
10129 hasDep := func(m android.Module, wantDep android.Module) bool {
10130 t.Helper()
10131 var found bool
10132 result.VisitDirectDeps(m, func(dep blueprint.Module) {
10133 if dep == wantDep {
10134 found = true
10135 }
10136 })
10137 return found
10138 }
10139
Kiyoung Kim76b06f32023-02-06 22:08:13 +090010140 // Library defines stubs and cc_api_library should be used with cc_api_library
10141 binfooApexVariant := result.ModuleForTests("binfoo", "android_arm64_armv8-a_apex29").Module()
10142 libbarCoreVariant := result.ModuleForTests("libbar", "android_arm64_armv8-a_shared").Module()
10143 libbarApiImportCoreVariant := result.ModuleForTests("libbar.apiimport", "android_arm64_armv8-a_shared").Module()
Kiyoung Kim487689e2022-07-26 09:48:22 +090010144
Kiyoung Kim76b06f32023-02-06 22:08:13 +090010145 android.AssertBoolEquals(t, "apex variant should link against API surface stub libraries", true, hasDep(binfooApexVariant, libbarApiImportCoreVariant))
10146 android.AssertBoolEquals(t, "apex variant should link against original library if exists", true, hasDep(binfooApexVariant, libbarCoreVariant))
Kiyoung Kim487689e2022-07-26 09:48:22 +090010147
Kiyoung Kim76b06f32023-02-06 22:08:13 +090010148 binFooCFlags := result.ModuleForTests("binfoo", "android_arm64_armv8-a_apex29").Rule("ld").Args["libFlags"]
10149 android.AssertStringDoesContain(t, "binfoo should link against APEX variant", binFooCFlags, "libbar.apex.29.apiimport.so")
10150 android.AssertStringDoesNotContain(t, "binfoo should not link against cc_api_library itself", binFooCFlags, "libbar.apiimport.so")
10151 android.AssertStringDoesNotContain(t, "binfoo should not link against original definition", binFooCFlags, "libbar.so")
10152
10153 // Library defined in the same APEX should be linked with original definition instead of cc_api_library
10154 libbazApexVariant := result.ModuleForTests("libbaz", "android_arm64_armv8-a_shared_apex29").Module()
10155 libbazApiImportCoreVariant := result.ModuleForTests("libbaz.apiimport", "android_arm64_armv8-a_shared").Module()
10156 android.AssertBoolEquals(t, "apex variant should link against API surface stub libraries even from same APEX", true, hasDep(binfooApexVariant, libbazApiImportCoreVariant))
10157 android.AssertBoolEquals(t, "apex variant should link against original library if exists", true, hasDep(binfooApexVariant, libbazApexVariant))
10158
10159 android.AssertStringDoesContain(t, "binfoo should link against APEX variant", binFooCFlags, "libbaz.so")
10160 android.AssertStringDoesNotContain(t, "binfoo should not link against cc_api_library itself", binFooCFlags, "libbaz.apiimport.so")
10161 android.AssertStringDoesNotContain(t, "binfoo should not link against original definition", binFooCFlags, "libbaz.apex.29.apiimport.so")
10162
10163 // cc_api_library defined without original library should be linked with cc_api_library
10164 libquxApiImportApexVariant := result.ModuleForTests("libqux.apiimport", "android_arm64_armv8-a_shared").Module()
10165 android.AssertBoolEquals(t, "apex variant should link against API surface stub libraries even original library definition does not exist", true, hasDep(binfooApexVariant, libquxApiImportApexVariant))
10166 android.AssertStringDoesContain(t, "binfoo should link against APEX variant", binFooCFlags, "libqux.apex.29.apiimport.so")
10167}
10168
10169func TestPlatformBinaryBuildsAgainstApiSurfaceStubLibraries(t *testing.T) {
10170 bp := `
10171 apex {
10172 name: "myapex",
10173 key: "myapex.key",
10174 native_shared_libs: ["libbar"],
10175 min_sdk_version: "29",
10176 }
10177 apex_key {
10178 name: "myapex.key",
10179 }
10180 cc_binary {
10181 name: "binfoo",
10182 shared_libs: ["libbar"],
10183 recovery_available: false,
10184 }
10185 cc_library {
10186 name: "libbar",
10187 srcs: ["libbar.cc"],
10188 apex_available: ["myapex"],
10189 min_sdk_version: "29",
10190 stubs: {
10191 symbol_file: "libbar.map.txt",
10192 versions: [
10193 "29",
10194 ],
10195 },
10196 }
10197 cc_api_library {
10198 name: "libbar",
10199 src: "libbar_stub.so",
10200 variants: ["apex.29"],
10201 }
10202 cc_api_variant {
10203 name: "libbar",
10204 variant: "apex",
10205 version: "29",
10206 src: "libbar_apex_29.so",
10207 }
10208 api_imports {
10209 name: "api_imports",
10210 apex_shared_libs: [
10211 "libbar",
10212 ],
10213 }
10214 `
10215
10216 result := testApex(t, bp)
10217
10218 hasDep := func(m android.Module, wantDep android.Module) bool {
10219 t.Helper()
10220 var found bool
10221 result.VisitDirectDeps(m, func(dep blueprint.Module) {
10222 if dep == wantDep {
10223 found = true
10224 }
10225 })
10226 return found
10227 }
10228
10229 // Library defines stubs and cc_api_library should be used with cc_api_library
10230 binfooApexVariant := result.ModuleForTests("binfoo", "android_arm64_armv8-a").Module()
10231 libbarCoreVariant := result.ModuleForTests("libbar", "android_arm64_armv8-a_shared").Module()
10232 libbarApiImportCoreVariant := result.ModuleForTests("libbar.apiimport", "android_arm64_armv8-a_shared").Module()
10233
10234 android.AssertBoolEquals(t, "apex variant should link against API surface stub libraries", true, hasDep(binfooApexVariant, libbarApiImportCoreVariant))
10235 android.AssertBoolEquals(t, "apex variant should link against original library if exists", true, hasDep(binfooApexVariant, libbarCoreVariant))
10236
10237 binFooCFlags := result.ModuleForTests("binfoo", "android_arm64_armv8-a").Rule("ld").Args["libFlags"]
10238 android.AssertStringDoesContain(t, "binfoo should link against APEX variant", binFooCFlags, "libbar.apex.29.apiimport.so")
10239 android.AssertStringDoesNotContain(t, "binfoo should not link against cc_api_library itself", binFooCFlags, "libbar.apiimport.so")
10240 android.AssertStringDoesNotContain(t, "binfoo should not link against original definition", binFooCFlags, "libbar.so")
Kiyoung Kim487689e2022-07-26 09:48:22 +090010241}
Dennis Shend4f5d932023-01-31 20:27:21 +000010242
10243func TestTrimmedApex(t *testing.T) {
10244 bp := `
10245 apex {
10246 name: "myapex",
10247 key: "myapex.key",
10248 native_shared_libs: ["libfoo","libbaz"],
10249 min_sdk_version: "29",
10250 trim_against: "mydcla",
10251 }
10252 apex {
10253 name: "mydcla",
10254 key: "myapex.key",
10255 native_shared_libs: ["libfoo","libbar"],
10256 min_sdk_version: "29",
10257 file_contexts: ":myapex-file_contexts",
10258 dynamic_common_lib_apex: true,
10259 }
10260 apex_key {
10261 name: "myapex.key",
10262 }
10263 cc_library {
10264 name: "libfoo",
10265 shared_libs: ["libc"],
10266 apex_available: ["myapex","mydcla"],
10267 min_sdk_version: "29",
10268 }
10269 cc_library {
10270 name: "libbar",
10271 shared_libs: ["libc"],
10272 apex_available: ["myapex","mydcla"],
10273 min_sdk_version: "29",
10274 }
10275 cc_library {
10276 name: "libbaz",
10277 shared_libs: ["libc"],
10278 apex_available: ["myapex","mydcla"],
10279 min_sdk_version: "29",
10280 }
10281 cc_api_library {
10282 name: "libc",
10283 src: "libc.so",
10284 min_sdk_version: "29",
10285 recovery_available: true,
Ivan Lozanoadd122a2023-07-13 11:01:41 -040010286 vendor_available: true,
Justin Yunaf1fde42023-09-27 16:22:10 +090010287 product_available: true,
Dennis Shend4f5d932023-01-31 20:27:21 +000010288 }
10289 api_imports {
10290 name: "api_imports",
10291 shared_libs: [
10292 "libc",
10293 ],
10294 header_libs: [],
10295 }
10296 `
10297 ctx := testApex(t, bp)
Jooyung Hana0503a52023-08-23 13:12:50 +090010298 module := ctx.ModuleForTests("myapex", "android_common_myapex")
Dennis Shend4f5d932023-01-31 20:27:21 +000010299 apexRule := module.MaybeRule("apexRule")
10300 if apexRule.Rule == nil {
10301 t.Errorf("Expecting regular apex rule but a non regular apex rule found")
10302 }
10303
10304 ctx = testApex(t, bp, android.FixtureModifyConfig(android.SetTrimmedApexEnabledForTests))
Jooyung Hana0503a52023-08-23 13:12:50 +090010305 trimmedApexRule := ctx.ModuleForTests("myapex", "android_common_myapex").Rule("TrimmedApexRule")
Dennis Shend4f5d932023-01-31 20:27:21 +000010306 libs_to_trim := trimmedApexRule.Args["libs_to_trim"]
10307 android.AssertStringDoesContain(t, "missing lib to trim", libs_to_trim, "libfoo")
10308 android.AssertStringDoesContain(t, "missing lib to trim", libs_to_trim, "libbar")
10309 android.AssertStringDoesNotContain(t, "unexpected libs in the libs to trim", libs_to_trim, "libbaz")
10310}
Jingwen Chendea7a642023-03-28 11:30:50 +000010311
10312func TestCannedFsConfig(t *testing.T) {
10313 ctx := testApex(t, `
10314 apex {
10315 name: "myapex",
10316 key: "myapex.key",
10317 updatable: false,
10318 }
10319
10320 apex_key {
10321 name: "myapex.key",
10322 public_key: "testkey.avbpubkey",
10323 private_key: "testkey.pem",
10324 }`)
Jooyung Hana0503a52023-08-23 13:12:50 +090010325 mod := ctx.ModuleForTests("myapex", "android_common_myapex")
Jingwen Chendea7a642023-03-28 11:30:50 +000010326 generateFsRule := mod.Rule("generateFsConfig")
10327 cmd := generateFsRule.RuleParams.Command
10328
10329 ensureContains(t, cmd, `( echo '/ 1000 1000 0755'; echo '/apex_manifest.json 1000 1000 0644'; echo '/apex_manifest.pb 1000 1000 0644'; ) >`)
10330}
10331
10332func TestCannedFsConfig_HasCustomConfig(t *testing.T) {
10333 ctx := testApex(t, `
10334 apex {
10335 name: "myapex",
10336 key: "myapex.key",
10337 canned_fs_config: "my_config",
10338 updatable: false,
10339 }
10340
10341 apex_key {
10342 name: "myapex.key",
10343 public_key: "testkey.avbpubkey",
10344 private_key: "testkey.pem",
10345 }`)
Jooyung Hana0503a52023-08-23 13:12:50 +090010346 mod := ctx.ModuleForTests("myapex", "android_common_myapex")
Jingwen Chendea7a642023-03-28 11:30:50 +000010347 generateFsRule := mod.Rule("generateFsConfig")
10348 cmd := generateFsRule.RuleParams.Command
10349
10350 // Ensure that canned_fs_config has "cat my_config" at the end
10351 ensureContains(t, cmd, `( echo '/ 1000 1000 0755'; echo '/apex_manifest.json 1000 1000 0644'; echo '/apex_manifest.pb 1000 1000 0644'; cat my_config ) >`)
10352}
Spandan Das20fce2d2023-04-12 17:21:39 +000010353
10354func TestStubLibrariesMultipleApexViolation(t *testing.T) {
10355 testCases := []struct {
10356 desc string
10357 hasStubs bool
10358 apexAvailable string
10359 expectedError string
10360 }{
10361 {
10362 desc: "non-stub library can have multiple apex_available",
10363 hasStubs: false,
10364 apexAvailable: `["myapex", "otherapex"]`,
10365 },
10366 {
10367 desc: "stub library should not be available to anyapex",
10368 hasStubs: true,
10369 apexAvailable: `["//apex_available:anyapex"]`,
10370 expectedError: "Stub libraries should have a single apex_available.*anyapex",
10371 },
10372 {
10373 desc: "stub library should not be available to multiple apexes",
10374 hasStubs: true,
10375 apexAvailable: `["myapex", "otherapex"]`,
10376 expectedError: "Stub libraries should have a single apex_available.*myapex.*otherapex",
10377 },
10378 {
10379 desc: "stub library can be available to a core apex and a test apex",
10380 hasStubs: true,
10381 apexAvailable: `["myapex", "test_myapex"]`,
10382 },
10383 }
10384 bpTemplate := `
10385 cc_library {
10386 name: "libfoo",
10387 %v
10388 apex_available: %v,
10389 }
10390 apex {
10391 name: "myapex",
10392 key: "apex.key",
10393 updatable: false,
10394 native_shared_libs: ["libfoo"],
10395 }
10396 apex {
10397 name: "otherapex",
10398 key: "apex.key",
10399 updatable: false,
10400 }
10401 apex_test {
10402 name: "test_myapex",
10403 key: "apex.key",
10404 updatable: false,
10405 native_shared_libs: ["libfoo"],
10406 }
10407 apex_key {
10408 name: "apex.key",
10409 }
10410 `
10411 for _, tc := range testCases {
10412 stubs := ""
10413 if tc.hasStubs {
10414 stubs = `stubs: {symbol_file: "libfoo.map.txt"},`
10415 }
10416 bp := fmt.Sprintf(bpTemplate, stubs, tc.apexAvailable)
10417 mockFsFixturePreparer := android.FixtureModifyMockFS(func(fs android.MockFS) {
10418 fs["system/sepolicy/apex/test_myapex-file_contexts"] = nil
10419 })
10420 if tc.expectedError == "" {
10421 testApex(t, bp, mockFsFixturePreparer)
10422 } else {
10423 testApexError(t, tc.expectedError, bp, mockFsFixturePreparer)
10424 }
10425 }
10426}
Colin Crossbd3a16b2023-04-25 11:30:51 -070010427
10428func TestFileSystemShouldSkipApexLibraries(t *testing.T) {
10429 context := android.GroupFixturePreparers(
10430 android.PrepareForIntegrationTestWithAndroid,
10431 cc.PrepareForIntegrationTestWithCc,
10432 PrepareForTestWithApexBuildComponents,
10433 prepareForTestWithMyapex,
10434 filesystem.PrepareForTestWithFilesystemBuildComponents,
10435 )
10436 result := context.RunTestWithBp(t, `
10437 android_system_image {
10438 name: "myfilesystem",
10439 deps: [
10440 "libfoo",
10441 ],
10442 linker_config_src: "linker.config.json",
10443 }
10444
10445 cc_library {
10446 name: "libfoo",
10447 shared_libs: [
10448 "libbar",
10449 ],
10450 stl: "none",
10451 }
10452
10453 cc_library {
10454 name: "libbar",
10455 stl: "none",
10456 apex_available: ["myapex"],
10457 }
10458
10459 apex {
10460 name: "myapex",
10461 native_shared_libs: ["libbar"],
10462 key: "myapex.key",
10463 updatable: false,
10464 }
10465
10466 apex_key {
10467 name: "myapex.key",
10468 public_key: "testkey.avbpubkey",
10469 private_key: "testkey.pem",
10470 }
10471 `)
10472
Cole Faust3b806d32024-03-11 15:15:03 -070010473 inputs := result.ModuleForTests("myfilesystem", "android_common").Output("myfilesystem.img").Implicits
Colin Crossbd3a16b2023-04-25 11:30:51 -070010474 android.AssertStringListDoesNotContain(t, "filesystem should not have libbar",
10475 inputs.Strings(),
10476 "out/soong/.intermediates/libbar/android_arm64_armv8-a_shared/libbar.so")
10477}
Yu Liueae7b362023-11-16 17:05:47 -080010478
10479var apex_default_bp = `
10480 apex_key {
10481 name: "myapex.key",
10482 public_key: "testkey.avbpubkey",
10483 private_key: "testkey.pem",
10484 }
10485
10486 filegroup {
10487 name: "myapex.manifest",
10488 srcs: ["apex_manifest.json"],
10489 }
10490
10491 filegroup {
10492 name: "myapex.androidmanifest",
10493 srcs: ["AndroidManifest.xml"],
10494 }
10495`
10496
10497func TestAconfigFilesJavaDeps(t *testing.T) {
10498 ctx := testApex(t, apex_default_bp+`
10499 apex {
10500 name: "myapex",
10501 manifest: ":myapex.manifest",
10502 androidManifest: ":myapex.androidmanifest",
10503 key: "myapex.key",
10504 java_libs: [
10505 "my_java_library_foo",
10506 "my_java_library_bar",
10507 ],
10508 updatable: false,
10509 }
10510
10511 java_library {
10512 name: "my_java_library_foo",
10513 srcs: ["foo/bar/MyClass.java"],
10514 sdk_version: "none",
10515 system_modules: "none",
10516 static_libs: ["my_java_aconfig_library_foo"],
Yu Liueae7b362023-11-16 17:05:47 -080010517 apex_available: [
Yu Liueae7b362023-11-16 17:05:47 -080010518 "myapex",
10519 ],
10520 }
10521
10522 java_library {
10523 name: "my_java_library_bar",
10524 srcs: ["foo/bar/MyClass.java"],
10525 sdk_version: "none",
10526 system_modules: "none",
10527 static_libs: ["my_java_aconfig_library_bar"],
Yu Liueae7b362023-11-16 17:05:47 -080010528 apex_available: [
Yu Liueae7b362023-11-16 17:05:47 -080010529 "myapex",
10530 ],
10531 }
10532
10533 aconfig_declarations {
10534 name: "my_aconfig_declarations_foo",
10535 package: "com.example.package",
10536 container: "myapex",
10537 srcs: ["foo.aconfig"],
10538 }
10539
10540 java_aconfig_library {
10541 name: "my_java_aconfig_library_foo",
10542 aconfig_declarations: "my_aconfig_declarations_foo",
Yu Liueae7b362023-11-16 17:05:47 -080010543 apex_available: [
Yu Liueae7b362023-11-16 17:05:47 -080010544 "myapex",
10545 ],
10546 }
10547
10548 aconfig_declarations {
10549 name: "my_aconfig_declarations_bar",
10550 package: "com.example.package",
10551 container: "myapex",
10552 srcs: ["bar.aconfig"],
10553 }
10554
10555 java_aconfig_library {
10556 name: "my_java_aconfig_library_bar",
10557 aconfig_declarations: "my_aconfig_declarations_bar",
Yu Liueae7b362023-11-16 17:05:47 -080010558 apex_available: [
Yu Liueae7b362023-11-16 17:05:47 -080010559 "myapex",
10560 ],
10561 }
10562 `)
10563
10564 mod := ctx.ModuleForTests("myapex", "android_common_myapex")
10565 s := mod.Rule("apexRule").Args["copy_commands"]
10566 copyCmds := regexp.MustCompile(" *&& *").Split(s, -1)
Yu Liubba555e2024-02-17 00:36:42 +000010567 if len(copyCmds) != 8 {
Yu Liueae7b362023-11-16 17:05:47 -080010568 t.Fatalf("Expected 5 commands, got %d in:\n%s", len(copyCmds), s)
10569 }
10570
Yu Liuab31c822024-02-28 22:21:31 +000010571 ensureMatches(t, copyCmds[4], "^cp -f .*/aconfig_flags.pb .*/image.apex/etc$")
10572 ensureMatches(t, copyCmds[5], "^cp -f .*/package.map .*/image.apex/etc$")
10573 ensureMatches(t, copyCmds[6], "^cp -f .*/flag.map .*/image.apex/etc$")
10574 ensureMatches(t, copyCmds[7], "^cp -f .*/flag.val .*/image.apex/etc$")
Yu Liueae7b362023-11-16 17:05:47 -080010575
Yu Liubba555e2024-02-17 00:36:42 +000010576 inputs := []string{
10577 "my_aconfig_declarations_foo/intermediate.pb",
10578 "my_aconfig_declarations_bar/intermediate.pb",
Yu Liueae7b362023-11-16 17:05:47 -080010579 }
Yu Liubba555e2024-02-17 00:36:42 +000010580 VerifyAconfigRule(t, &mod, "combine_aconfig_declarations", inputs, "android_common_myapex/aconfig_flags.pb", "", "")
10581 VerifyAconfigRule(t, &mod, "create_aconfig_package_map_file", inputs, "android_common_myapex/package.map", "myapex", "package_map")
10582 VerifyAconfigRule(t, &mod, "create_aconfig_flag_map_file", inputs, "android_common_myapex/flag.map", "myapex", "flag_map")
10583 VerifyAconfigRule(t, &mod, "create_aconfig_flag_val_file", inputs, "android_common_myapex/flag.val", "myapex", "flag_val")
Yu Liueae7b362023-11-16 17:05:47 -080010584}
10585
10586func TestAconfigFilesJavaAndCcDeps(t *testing.T) {
10587 ctx := testApex(t, apex_default_bp+`
10588 apex {
10589 name: "myapex",
10590 manifest: ":myapex.manifest",
10591 androidManifest: ":myapex.androidmanifest",
10592 key: "myapex.key",
10593 java_libs: [
10594 "my_java_library_foo",
10595 ],
10596 native_shared_libs: [
10597 "my_cc_library_bar",
10598 ],
10599 binaries: [
10600 "my_cc_binary_baz",
10601 ],
10602 updatable: false,
10603 }
10604
10605 java_library {
10606 name: "my_java_library_foo",
10607 srcs: ["foo/bar/MyClass.java"],
10608 sdk_version: "none",
10609 system_modules: "none",
10610 static_libs: ["my_java_aconfig_library_foo"],
Yu Liueae7b362023-11-16 17:05:47 -080010611 apex_available: [
Yu Liueae7b362023-11-16 17:05:47 -080010612 "myapex",
10613 ],
10614 }
10615
10616 cc_library {
10617 name: "my_cc_library_bar",
10618 srcs: ["foo/bar/MyClass.cc"],
Yu Liucec0e412023-11-30 16:45:50 -080010619 static_libs: [
10620 "my_cc_aconfig_library_bar",
10621 "my_cc_aconfig_library_baz",
10622 ],
Yu Liueae7b362023-11-16 17:05:47 -080010623 apex_available: [
Yu Liueae7b362023-11-16 17:05:47 -080010624 "myapex",
10625 ],
10626 }
10627
10628 cc_binary {
10629 name: "my_cc_binary_baz",
10630 srcs: ["foo/bar/MyClass.cc"],
10631 static_libs: ["my_cc_aconfig_library_baz"],
Yu Liueae7b362023-11-16 17:05:47 -080010632 apex_available: [
Yu Liueae7b362023-11-16 17:05:47 -080010633 "myapex",
10634 ],
10635 }
10636
10637 aconfig_declarations {
10638 name: "my_aconfig_declarations_foo",
10639 package: "com.example.package",
10640 container: "myapex",
10641 srcs: ["foo.aconfig"],
10642 }
10643
10644 java_aconfig_library {
10645 name: "my_java_aconfig_library_foo",
10646 aconfig_declarations: "my_aconfig_declarations_foo",
Yu Liueae7b362023-11-16 17:05:47 -080010647 apex_available: [
Yu Liueae7b362023-11-16 17:05:47 -080010648 "myapex",
10649 ],
10650 }
10651
10652 aconfig_declarations {
10653 name: "my_aconfig_declarations_bar",
10654 package: "com.example.package",
10655 container: "myapex",
10656 srcs: ["bar.aconfig"],
10657 }
10658
10659 cc_aconfig_library {
10660 name: "my_cc_aconfig_library_bar",
10661 aconfig_declarations: "my_aconfig_declarations_bar",
Yu Liueae7b362023-11-16 17:05:47 -080010662 apex_available: [
Yu Liueae7b362023-11-16 17:05:47 -080010663 "myapex",
10664 ],
10665 }
10666
10667 aconfig_declarations {
10668 name: "my_aconfig_declarations_baz",
10669 package: "com.example.package",
10670 container: "myapex",
10671 srcs: ["baz.aconfig"],
10672 }
10673
10674 cc_aconfig_library {
10675 name: "my_cc_aconfig_library_baz",
10676 aconfig_declarations: "my_aconfig_declarations_baz",
Yu Liueae7b362023-11-16 17:05:47 -080010677 apex_available: [
Yu Liueae7b362023-11-16 17:05:47 -080010678 "myapex",
10679 ],
10680 }
10681
10682 cc_library {
10683 name: "server_configurable_flags",
10684 srcs: ["server_configurable_flags.cc"],
10685 }
Ted Bauerf0f18592024-04-23 18:25:26 +000010686 cc_library {
10687 name: "libbase",
10688 srcs: ["libbase.cc"],
Ted Bauer1e96f8c2024-04-25 19:50:01 +000010689 apex_available: [
10690 "myapex",
10691 ],
Ted Bauerf0f18592024-04-23 18:25:26 +000010692 }
10693 cc_library {
10694 name: "libaconfig_storage_read_api_cc",
10695 srcs: ["libaconfig_storage_read_api_cc.cc"],
10696 }
10697 cc_library {
10698 name: "libaconfig_storage_protos_cc",
10699 srcs: ["libaconfig_storage_protos_cc.cc"],
10700 }
Yu Liueae7b362023-11-16 17:05:47 -080010701 `)
10702
10703 mod := ctx.ModuleForTests("myapex", "android_common_myapex")
10704 s := mod.Rule("apexRule").Args["copy_commands"]
10705 copyCmds := regexp.MustCompile(" *&& *").Split(s, -1)
Yu Liubba555e2024-02-17 00:36:42 +000010706 if len(copyCmds) != 12 {
10707 t.Fatalf("Expected 12 commands, got %d in:\n%s", len(copyCmds), s)
Yu Liueae7b362023-11-16 17:05:47 -080010708 }
10709
Yu Liuab31c822024-02-28 22:21:31 +000010710 ensureMatches(t, copyCmds[8], "^cp -f .*/aconfig_flags.pb .*/image.apex/etc$")
10711 ensureMatches(t, copyCmds[9], "^cp -f .*/package.map .*/image.apex/etc$")
10712 ensureMatches(t, copyCmds[10], "^cp -f .*/flag.map .*/image.apex/etc$")
10713 ensureMatches(t, copyCmds[11], "^cp -f .*/flag.val .*/image.apex/etc$")
Yu Liueae7b362023-11-16 17:05:47 -080010714
Yu Liubba555e2024-02-17 00:36:42 +000010715 inputs := []string{
10716 "my_aconfig_declarations_foo/intermediate.pb",
10717 "my_cc_library_bar/android_arm64_armv8-a_shared_apex10000/myapex/aconfig_merged.pb",
10718 "my_aconfig_declarations_baz/intermediate.pb",
Yu Liueae7b362023-11-16 17:05:47 -080010719 }
Yu Liubba555e2024-02-17 00:36:42 +000010720 VerifyAconfigRule(t, &mod, "combine_aconfig_declarations", inputs, "android_common_myapex/aconfig_flags.pb", "", "")
10721 VerifyAconfigRule(t, &mod, "create_aconfig_package_map_file", inputs, "android_common_myapex/package.map", "myapex", "package_map")
10722 VerifyAconfigRule(t, &mod, "create_aconfig_flag_map_file", inputs, "android_common_myapex/flag.map", "myapex", "flag_map")
10723 VerifyAconfigRule(t, &mod, "create_aconfig_flag_val_file", inputs, "android_common_myapex/flag.val", "myapex", "flag_val")
Yu Liueae7b362023-11-16 17:05:47 -080010724}
10725
Yu Liucec0e412023-11-30 16:45:50 -080010726func TestAconfigFilesRustDeps(t *testing.T) {
10727 ctx := testApex(t, apex_default_bp+`
10728 apex {
10729 name: "myapex",
10730 manifest: ":myapex.manifest",
10731 androidManifest: ":myapex.androidmanifest",
10732 key: "myapex.key",
10733 native_shared_libs: [
10734 "libmy_rust_library",
10735 ],
10736 binaries: [
10737 "my_rust_binary",
10738 ],
10739 rust_dyn_libs: [
10740 "libmy_rust_dylib",
10741 ],
10742 updatable: false,
10743 }
10744
10745 rust_library {
10746 name: "libflags_rust", // test mock
10747 crate_name: "flags_rust",
10748 srcs: ["lib.rs"],
10749 apex_available: [
10750 "myapex",
10751 ],
10752 }
10753
10754 rust_library {
10755 name: "liblazy_static", // test mock
10756 crate_name: "lazy_static",
10757 srcs: ["src/lib.rs"],
10758 apex_available: [
10759 "myapex",
10760 ],
10761 }
10762
Ted Bauer02d475c2024-03-27 20:56:26 +000010763 rust_library {
10764 name: "libaconfig_storage_read_api", // test mock
10765 crate_name: "aconfig_storage_read_api",
10766 srcs: ["src/lib.rs"],
10767 apex_available: [
10768 "myapex",
10769 ],
10770 }
10771
Ted Bauer6ef40db2024-03-29 14:04:10 +000010772 rust_library {
10773 name: "liblogger", // test mock
10774 crate_name: "logger",
10775 srcs: ["src/lib.rs"],
10776 apex_available: [
10777 "myapex",
10778 ],
10779 }
10780
10781 rust_library {
10782 name: "liblog_rust", // test mock
10783 crate_name: "log_rust",
10784 srcs: ["src/lib.rs"],
10785 apex_available: [
10786 "myapex",
10787 ],
10788 }
10789
Yu Liucec0e412023-11-30 16:45:50 -080010790 rust_ffi_shared {
10791 name: "libmy_rust_library",
10792 srcs: ["src/lib.rs"],
10793 rustlibs: ["libmy_rust_aconfig_library_foo"],
10794 crate_name: "my_rust_library",
10795 apex_available: [
10796 "myapex",
10797 ],
10798 }
10799
10800 rust_library_dylib {
10801 name: "libmy_rust_dylib",
10802 srcs: ["foo/bar/MyClass.rs"],
10803 rustlibs: ["libmy_rust_aconfig_library_bar"],
10804 crate_name: "my_rust_dylib",
10805 apex_available: [
10806 "myapex",
10807 ],
10808 }
10809
10810 rust_binary {
10811 name: "my_rust_binary",
10812 srcs: ["foo/bar/MyClass.rs"],
10813 rustlibs: [
10814 "libmy_rust_aconfig_library_baz",
10815 "libmy_rust_dylib",
10816 ],
10817 apex_available: [
10818 "myapex",
10819 ],
10820 }
10821
10822 aconfig_declarations {
10823 name: "my_aconfig_declarations_foo",
10824 package: "com.example.package",
10825 container: "myapex",
10826 srcs: ["foo.aconfig"],
10827 }
10828
10829 aconfig_declarations {
10830 name: "my_aconfig_declarations_bar",
10831 package: "com.example.package",
10832 container: "myapex",
10833 srcs: ["bar.aconfig"],
10834 }
10835
10836 aconfig_declarations {
10837 name: "my_aconfig_declarations_baz",
10838 package: "com.example.package",
10839 container: "myapex",
10840 srcs: ["baz.aconfig"],
10841 }
10842
10843 rust_aconfig_library {
10844 name: "libmy_rust_aconfig_library_foo",
10845 aconfig_declarations: "my_aconfig_declarations_foo",
10846 crate_name: "my_rust_aconfig_library_foo",
10847 apex_available: [
10848 "myapex",
10849 ],
10850 }
10851
10852 rust_aconfig_library {
10853 name: "libmy_rust_aconfig_library_bar",
10854 aconfig_declarations: "my_aconfig_declarations_bar",
10855 crate_name: "my_rust_aconfig_library_bar",
10856 apex_available: [
10857 "myapex",
10858 ],
10859 }
10860
10861 rust_aconfig_library {
10862 name: "libmy_rust_aconfig_library_baz",
10863 aconfig_declarations: "my_aconfig_declarations_baz",
10864 crate_name: "my_rust_aconfig_library_baz",
10865 apex_available: [
10866 "myapex",
10867 ],
10868 }
10869 `)
10870
10871 mod := ctx.ModuleForTests("myapex", "android_common_myapex")
10872 s := mod.Rule("apexRule").Args["copy_commands"]
10873 copyCmds := regexp.MustCompile(" *&& *").Split(s, -1)
Ted Bauer6ef40db2024-03-29 14:04:10 +000010874 if len(copyCmds) != 32 {
Ted Bauer02d475c2024-03-27 20:56:26 +000010875 t.Fatalf("Expected 28 commands, got %d in:\n%s", len(copyCmds), s)
Yu Liucec0e412023-11-30 16:45:50 -080010876 }
10877
Ted Bauer6ef40db2024-03-29 14:04:10 +000010878 ensureMatches(t, copyCmds[28], "^cp -f .*/aconfig_flags.pb .*/image.apex/etc$")
10879 ensureMatches(t, copyCmds[29], "^cp -f .*/package.map .*/image.apex/etc$")
10880 ensureMatches(t, copyCmds[30], "^cp -f .*/flag.map .*/image.apex/etc$")
10881 ensureMatches(t, copyCmds[31], "^cp -f .*/flag.val .*/image.apex/etc$")
Yu Liucec0e412023-11-30 16:45:50 -080010882
Yu Liubba555e2024-02-17 00:36:42 +000010883 inputs := []string{
10884 "my_aconfig_declarations_foo/intermediate.pb",
Yu Liuab31c822024-02-28 22:21:31 +000010885 "my_aconfig_declarations_bar/intermediate.pb",
10886 "my_aconfig_declarations_baz/intermediate.pb",
Yu Liubba555e2024-02-17 00:36:42 +000010887 "my_rust_binary/android_arm64_armv8-a_apex10000/myapex/aconfig_merged.pb",
10888 }
10889 VerifyAconfigRule(t, &mod, "combine_aconfig_declarations", inputs, "android_common_myapex/aconfig_flags.pb", "", "")
10890 VerifyAconfigRule(t, &mod, "create_aconfig_package_map_file", inputs, "android_common_myapex/package.map", "myapex", "package_map")
10891 VerifyAconfigRule(t, &mod, "create_aconfig_flag_map_file", inputs, "android_common_myapex/flag.map", "myapex", "flag_map")
10892 VerifyAconfigRule(t, &mod, "create_aconfig_flag_val_file", inputs, "android_common_myapex/flag.val", "myapex", "flag_val")
10893}
10894
10895func VerifyAconfigRule(t *testing.T, mod *android.TestingModule, desc string, inputs []string, output string, container string, file_type string) {
10896 aconfigRule := mod.Description(desc)
10897 s := " " + aconfigRule.Args["cache_files"]
Yu Liucec0e412023-11-30 16:45:50 -080010898 aconfigArgs := regexp.MustCompile(" --cache ").Split(s, -1)[1:]
Yu Liubba555e2024-02-17 00:36:42 +000010899 if len(aconfigArgs) != len(inputs) {
10900 t.Fatalf("Expected %d commands, got %d in:\n%s", len(inputs), len(aconfigArgs), s)
Yu Liucec0e412023-11-30 16:45:50 -080010901 }
Yu Liucec0e412023-11-30 16:45:50 -080010902
Yu Liubba555e2024-02-17 00:36:42 +000010903 ensureEquals(t, container, aconfigRule.Args["container"])
10904 ensureEquals(t, file_type, aconfigRule.Args["file_type"])
10905
10906 buildParams := aconfigRule.BuildParams
10907 for _, input := range inputs {
10908 android.EnsureListContainsSuffix(t, aconfigArgs, input)
10909 android.EnsureListContainsSuffix(t, buildParams.Inputs.Strings(), input)
Yu Liucec0e412023-11-30 16:45:50 -080010910 }
Yu Liubba555e2024-02-17 00:36:42 +000010911
10912 ensureContains(t, buildParams.Output.String(), output)
Yu Liucec0e412023-11-30 16:45:50 -080010913}
10914
Yu Liueae7b362023-11-16 17:05:47 -080010915func TestAconfigFilesOnlyMatchCurrentApex(t *testing.T) {
10916 ctx := testApex(t, apex_default_bp+`
10917 apex {
10918 name: "myapex",
10919 manifest: ":myapex.manifest",
10920 androidManifest: ":myapex.androidmanifest",
10921 key: "myapex.key",
10922 java_libs: [
10923 "my_java_library_foo",
10924 "other_java_library_bar",
10925 ],
10926 updatable: false,
10927 }
10928
10929 java_library {
10930 name: "my_java_library_foo",
10931 srcs: ["foo/bar/MyClass.java"],
10932 sdk_version: "none",
10933 system_modules: "none",
10934 static_libs: ["my_java_aconfig_library_foo"],
Yu Liueae7b362023-11-16 17:05:47 -080010935 apex_available: [
Yu Liueae7b362023-11-16 17:05:47 -080010936 "myapex",
10937 ],
10938 }
10939
10940 java_library {
10941 name: "other_java_library_bar",
10942 srcs: ["foo/bar/MyClass.java"],
10943 sdk_version: "none",
10944 system_modules: "none",
10945 static_libs: ["other_java_aconfig_library_bar"],
Yu Liueae7b362023-11-16 17:05:47 -080010946 apex_available: [
Yu Liueae7b362023-11-16 17:05:47 -080010947 "myapex",
10948 ],
10949 }
10950
10951 aconfig_declarations {
10952 name: "my_aconfig_declarations_foo",
10953 package: "com.example.package",
10954 container: "myapex",
10955 srcs: ["foo.aconfig"],
10956 }
10957
10958 java_aconfig_library {
10959 name: "my_java_aconfig_library_foo",
10960 aconfig_declarations: "my_aconfig_declarations_foo",
Yu Liueae7b362023-11-16 17:05:47 -080010961 apex_available: [
Yu Liueae7b362023-11-16 17:05:47 -080010962 "myapex",
10963 ],
10964 }
10965
10966 aconfig_declarations {
10967 name: "other_aconfig_declarations_bar",
10968 package: "com.example.package",
10969 container: "otherapex",
10970 srcs: ["bar.aconfig"],
10971 }
10972
10973 java_aconfig_library {
10974 name: "other_java_aconfig_library_bar",
10975 aconfig_declarations: "other_aconfig_declarations_bar",
Yu Liueae7b362023-11-16 17:05:47 -080010976 apex_available: [
Yu Liueae7b362023-11-16 17:05:47 -080010977 "myapex",
10978 ],
10979 }
10980 `)
10981
10982 mod := ctx.ModuleForTests("myapex", "android_common_myapex")
10983 combineAconfigRule := mod.Rule("All_aconfig_declarations_dump")
10984 s := " " + combineAconfigRule.Args["cache_files"]
10985 aconfigArgs := regexp.MustCompile(" --cache ").Split(s, -1)[1:]
10986 if len(aconfigArgs) != 1 {
10987 t.Fatalf("Expected 1 commands, got %d in:\n%s", len(aconfigArgs), s)
10988 }
10989 android.EnsureListContainsSuffix(t, aconfigArgs, "my_aconfig_declarations_foo/intermediate.pb")
10990
10991 buildParams := combineAconfigRule.BuildParams
10992 if len(buildParams.Inputs) != 1 {
10993 t.Fatalf("Expected 1 input, got %d", len(buildParams.Inputs))
10994 }
10995 android.EnsureListContainsSuffix(t, buildParams.Inputs.Strings(), "my_aconfig_declarations_foo/intermediate.pb")
10996 ensureContains(t, buildParams.Output.String(), "android_common_myapex/aconfig_flags.pb")
10997}
10998
10999func TestAconfigFilesRemoveDuplicates(t *testing.T) {
11000 ctx := testApex(t, apex_default_bp+`
11001 apex {
11002 name: "myapex",
11003 manifest: ":myapex.manifest",
11004 androidManifest: ":myapex.androidmanifest",
11005 key: "myapex.key",
11006 java_libs: [
11007 "my_java_library_foo",
11008 "my_java_library_bar",
11009 ],
11010 updatable: false,
11011 }
11012
11013 java_library {
11014 name: "my_java_library_foo",
11015 srcs: ["foo/bar/MyClass.java"],
11016 sdk_version: "none",
11017 system_modules: "none",
11018 static_libs: ["my_java_aconfig_library_foo"],
Yu Liueae7b362023-11-16 17:05:47 -080011019 apex_available: [
Yu Liueae7b362023-11-16 17:05:47 -080011020 "myapex",
11021 ],
11022 }
11023
11024 java_library {
11025 name: "my_java_library_bar",
11026 srcs: ["foo/bar/MyClass.java"],
11027 sdk_version: "none",
11028 system_modules: "none",
11029 static_libs: ["my_java_aconfig_library_bar"],
Yu Liueae7b362023-11-16 17:05:47 -080011030 apex_available: [
Yu Liueae7b362023-11-16 17:05:47 -080011031 "myapex",
11032 ],
11033 }
11034
11035 aconfig_declarations {
11036 name: "my_aconfig_declarations_foo",
11037 package: "com.example.package",
11038 container: "myapex",
11039 srcs: ["foo.aconfig"],
11040 }
11041
11042 java_aconfig_library {
11043 name: "my_java_aconfig_library_foo",
11044 aconfig_declarations: "my_aconfig_declarations_foo",
Yu Liueae7b362023-11-16 17:05:47 -080011045 apex_available: [
Yu Liueae7b362023-11-16 17:05:47 -080011046 "myapex",
11047 ],
11048 }
11049
11050 java_aconfig_library {
11051 name: "my_java_aconfig_library_bar",
11052 aconfig_declarations: "my_aconfig_declarations_foo",
Yu Liueae7b362023-11-16 17:05:47 -080011053 apex_available: [
Yu Liueae7b362023-11-16 17:05:47 -080011054 "myapex",
11055 ],
11056 }
11057 `)
11058
11059 mod := ctx.ModuleForTests("myapex", "android_common_myapex")
11060 combineAconfigRule := mod.Rule("All_aconfig_declarations_dump")
11061 s := " " + combineAconfigRule.Args["cache_files"]
11062 aconfigArgs := regexp.MustCompile(" --cache ").Split(s, -1)[1:]
11063 if len(aconfigArgs) != 1 {
11064 t.Fatalf("Expected 1 commands, got %d in:\n%s", len(aconfigArgs), s)
11065 }
11066 android.EnsureListContainsSuffix(t, aconfigArgs, "my_aconfig_declarations_foo/intermediate.pb")
11067
11068 buildParams := combineAconfigRule.BuildParams
11069 if len(buildParams.Inputs) != 1 {
11070 t.Fatalf("Expected 1 input, got %d", len(buildParams.Inputs))
11071 }
11072 android.EnsureListContainsSuffix(t, buildParams.Inputs.Strings(), "my_aconfig_declarations_foo/intermediate.pb")
11073 ensureContains(t, buildParams.Output.String(), "android_common_myapex/aconfig_flags.pb")
11074}
Spandan Das5be63332023-12-13 00:06:32 +000011075
11076// Test that the boot jars come from the _selected_ apex prebuilt
11077// RELEASE_APEX_CONTIRBUTIONS_* build flags will be used to select the correct prebuilt for a specific release config
11078func TestBootDexJarsMultipleApexPrebuilts(t *testing.T) {
11079 checkBootDexJarPath := func(t *testing.T, ctx *android.TestContext, stem string, bootDexJarPath string) {
11080 t.Helper()
11081 s := ctx.ModuleForTests("dex_bootjars", "android_common")
11082 foundLibfooJar := false
11083 base := stem + ".jar"
11084 for _, output := range s.AllOutputs() {
11085 if filepath.Base(output) == base {
11086 foundLibfooJar = true
11087 buildRule := s.Output(output)
11088 android.AssertStringEquals(t, "boot dex jar path", bootDexJarPath, buildRule.Input.String())
11089 }
11090 }
11091 if !foundLibfooJar {
11092 t.Errorf("Rule for libfoo.jar missing in dex_bootjars singleton outputs %q", android.StringPathsRelativeToTop(ctx.Config().SoongOutDir(), s.AllOutputs()))
11093 }
11094 }
11095
Spandan Das64c9e0c2023-12-20 20:13:34 +000011096 // Check that the boot jars of the selected apex are run through boot_jars_package_check
11097 // This validates that the jars on the bootclasspath do not contain packages outside an allowlist
11098 checkBootJarsPackageCheck := func(t *testing.T, ctx *android.TestContext, expectedBootJar string) {
11099 platformBcp := ctx.ModuleForTests("platform-bootclasspath", "android_common")
11100 bootJarsCheckRule := platformBcp.Rule("boot_jars_package_check")
11101 android.AssertStringMatches(t, "Could not find the correct boot dex jar in package check rule", bootJarsCheckRule.RuleParams.Command, "build/soong/scripts/check_boot_jars/package_allowed_list.txt.*"+expectedBootJar)
11102 }
11103
11104 // Check that the boot jars used to generate the monolithic hiddenapi flags come from the selected apex
11105 checkBootJarsForMonolithicHiddenapi := func(t *testing.T, ctx *android.TestContext, expectedBootJar string) {
11106 monolithicHiddenapiFlagsCmd := ctx.ModuleForTests("platform-bootclasspath", "android_common").Output("out/soong/hiddenapi/hiddenapi-stub-flags.txt").RuleParams.Command
11107 android.AssertStringMatches(t, "Could not find the correct boot dex jar in monolithic hiddenapi flags generation command", monolithicHiddenapiFlagsCmd, "--boot-dex="+expectedBootJar)
11108 }
11109
Spandan Das5be63332023-12-13 00:06:32 +000011110 bp := `
11111 // Source APEX.
11112
11113 java_library {
11114 name: "framework-foo",
11115 srcs: ["foo.java"],
11116 installable: true,
11117 apex_available: [
11118 "com.android.foo",
11119 ],
11120 }
11121
11122 bootclasspath_fragment {
11123 name: "foo-bootclasspath-fragment",
11124 contents: ["framework-foo"],
11125 apex_available: [
11126 "com.android.foo",
11127 ],
11128 hidden_api: {
11129 split_packages: ["*"],
11130 },
11131 }
11132
11133 apex_key {
11134 name: "com.android.foo.key",
11135 public_key: "com.android.foo.avbpubkey",
11136 private_key: "com.android.foo.pem",
11137 }
11138
11139 apex {
11140 name: "com.android.foo",
11141 key: "com.android.foo.key",
11142 bootclasspath_fragments: ["foo-bootclasspath-fragment"],
11143 updatable: false,
11144 }
11145
11146 // Prebuilt APEX.
11147
Spandan Dasb2fd4ff2024-01-25 04:25:38 +000011148 java_sdk_library_import {
Spandan Das5be63332023-12-13 00:06:32 +000011149 name: "framework-foo",
Spandan Dasb2fd4ff2024-01-25 04:25:38 +000011150 public: {
11151 jars: ["foo.jar"],
11152 },
Spandan Das5be63332023-12-13 00:06:32 +000011153 apex_available: ["com.android.foo"],
Spandan Dasb2fd4ff2024-01-25 04:25:38 +000011154 shared_library: false,
Spandan Das5be63332023-12-13 00:06:32 +000011155 }
11156
11157 prebuilt_bootclasspath_fragment {
11158 name: "foo-bootclasspath-fragment",
11159 contents: ["framework-foo"],
11160 hidden_api: {
11161 annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
11162 metadata: "my-bootclasspath-fragment/metadata.csv",
11163 index: "my-bootclasspath-fragment/index.csv",
11164 stub_flags: "my-bootclasspath-fragment/stub-flags.csv",
11165 all_flags: "my-bootclasspath-fragment/all-flags.csv",
11166 },
11167 apex_available: [
11168 "com.android.foo",
11169 ],
11170 }
11171
11172 prebuilt_apex {
11173 name: "com.android.foo",
11174 apex_name: "com.android.foo",
11175 src: "com.android.foo-arm.apex",
11176 exported_bootclasspath_fragments: ["foo-bootclasspath-fragment"],
11177 }
11178
11179 // Another Prebuilt ART APEX
11180 prebuilt_apex {
11181 name: "com.android.foo.v2",
11182 apex_name: "com.android.foo", // Used to determine the API domain
11183 src: "com.android.foo-arm.apex",
11184 exported_bootclasspath_fragments: ["foo-bootclasspath-fragment"],
11185 }
11186
11187 // APEX contribution modules
11188
11189 apex_contributions {
Spandan Dasb2fd4ff2024-01-25 04:25:38 +000011190 name: "foo.source.contributions",
Spandan Das5be63332023-12-13 00:06:32 +000011191 api_domain: "com.android.foo",
Spandan Dasb2fd4ff2024-01-25 04:25:38 +000011192 contents: ["com.android.foo"],
11193 }
11194
11195 apex_contributions {
11196 name: "foo.prebuilt.contributions",
11197 api_domain: "com.android.foo",
11198 contents: ["prebuilt_com.android.foo"],
11199 }
11200
11201 apex_contributions {
11202 name: "foo.prebuilt.v2.contributions",
11203 api_domain: "com.android.foo",
11204 contents: ["com.android.foo.v2"], // prebuilt_ prefix is missing because of prebuilt_rename mutator
Spandan Das5be63332023-12-13 00:06:32 +000011205 }
11206 `
11207
11208 testCases := []struct {
Spandan Dasb2fd4ff2024-01-25 04:25:38 +000011209 desc string
11210 selectedApexContributions string
11211 expectedBootJar string
Spandan Das5be63332023-12-13 00:06:32 +000011212 }{
11213 {
Spandan Dasb2fd4ff2024-01-25 04:25:38 +000011214 desc: "Source apex com.android.foo is selected, bootjar should come from source java library",
11215 selectedApexContributions: "foo.source.contributions",
11216 expectedBootJar: "out/soong/.intermediates/foo-bootclasspath-fragment/android_common_apex10000/hiddenapi-modular/encoded/framework-foo.jar",
Spandan Das5be63332023-12-13 00:06:32 +000011217 },
11218 {
Spandan Dasb2fd4ff2024-01-25 04:25:38 +000011219 desc: "Prebuilt apex prebuilt_com.android.foo is selected, profile should come from .prof deapexed from the prebuilt",
11220 selectedApexContributions: "foo.prebuilt.contributions",
11221 expectedBootJar: "out/soong/.intermediates/prebuilt_com.android.foo.deapexer/android_common/deapexer/javalib/framework-foo.jar",
Spandan Das5be63332023-12-13 00:06:32 +000011222 },
11223 {
Spandan Dasb2fd4ff2024-01-25 04:25:38 +000011224 desc: "Prebuilt apex prebuilt_com.android.foo.v2 is selected, profile should come from .prof deapexed from the prebuilt",
11225 selectedApexContributions: "foo.prebuilt.v2.contributions",
11226 expectedBootJar: "out/soong/.intermediates/prebuilt_com.android.foo.v2.deapexer/android_common/deapexer/javalib/framework-foo.jar",
Spandan Das5be63332023-12-13 00:06:32 +000011227 },
11228 }
11229
11230 fragment := java.ApexVariantReference{
11231 Apex: proptools.StringPtr("com.android.foo"),
11232 Module: proptools.StringPtr("foo-bootclasspath-fragment"),
11233 }
11234
11235 for _, tc := range testCases {
11236 preparer := android.GroupFixturePreparers(
11237 java.FixtureConfigureApexBootJars("com.android.foo:framework-foo"),
11238 android.FixtureMergeMockFs(map[string][]byte{
11239 "system/sepolicy/apex/com.android.foo-file_contexts": nil,
11240 }),
11241 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
11242 variables.BuildFlags = map[string]string{
Spandan Dasb2fd4ff2024-01-25 04:25:38 +000011243 "RELEASE_APEX_CONTRIBUTIONS_ADSERVICES": tc.selectedApexContributions,
Spandan Das5be63332023-12-13 00:06:32 +000011244 }
11245 }),
11246 )
Spandan Dasb2fd4ff2024-01-25 04:25:38 +000011247 ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
Spandan Das5be63332023-12-13 00:06:32 +000011248 checkBootDexJarPath(t, ctx, "framework-foo", tc.expectedBootJar)
Spandan Das64c9e0c2023-12-20 20:13:34 +000011249 checkBootJarsPackageCheck(t, ctx, tc.expectedBootJar)
11250 checkBootJarsForMonolithicHiddenapi(t, ctx, tc.expectedBootJar)
Spandan Das5be63332023-12-13 00:06:32 +000011251 }
11252}
Spandan Das3576e762024-01-03 18:57:03 +000011253
11254// Test that product packaging installs the selected mainline module (either source or a specific prebuilt)
11255// RELEASE_APEX_CONTIRBUTIONS_* build flags will be used to select the correct prebuilt for a specific release config
11256func TestInstallationRulesForMultipleApexPrebuilts(t *testing.T) {
11257 // check that the LOCAL_MODULE in the generated mk file matches the name used in PRODUCT_PACKAGES
11258 // Since the name used in PRODUCT_PACKAGES does not contain prebuilt_ prefix, LOCAL_MODULE should not contain any prefix either
11259 checkLocalModuleName := func(t *testing.T, ctx *android.TestContext, soongApexModuleName string, expectedLocalModuleName string) {
11260 // Variations are created based on apex_name
11261 entries := android.AndroidMkEntriesForTest(t, ctx, ctx.ModuleForTests(soongApexModuleName, "android_common_com.android.foo").Module())
11262 android.AssertStringEquals(t, "LOCAL_MODULE of the prebuilt apex must match the name listed in PRODUCT_PACKAGES", expectedLocalModuleName, entries[0].EntryMap["LOCAL_MODULE"][0])
11263 }
11264 // for a mainline module family, check that only the flagged soong module is visible to make
11265 checkHideFromMake := func(t *testing.T, ctx *android.TestContext, visibleModuleName string, hiddenModuleNames []string) {
11266 variation := func(moduleName string) string {
11267 ret := "android_common_com.android.foo"
11268 if moduleName == "com.google.android.foo" {
11269 ret = "android_common_com.google.android.foo_com.android.foo"
11270 }
11271 return ret
11272 }
11273
11274 visibleModule := ctx.ModuleForTests(visibleModuleName, variation(visibleModuleName)).Module()
11275 android.AssertBoolEquals(t, "Apex "+visibleModuleName+" selected using apex_contributions should be visible to make", false, visibleModule.IsHideFromMake())
11276
11277 for _, hiddenModuleName := range hiddenModuleNames {
11278 hiddenModule := ctx.ModuleForTests(hiddenModuleName, variation(hiddenModuleName)).Module()
11279 android.AssertBoolEquals(t, "Apex "+hiddenModuleName+" not selected using apex_contributions should be hidden from make", true, hiddenModule.IsHideFromMake())
11280
11281 }
11282 }
11283
11284 bp := `
11285 apex_key {
11286 name: "com.android.foo.key",
11287 public_key: "com.android.foo.avbpubkey",
11288 private_key: "com.android.foo.pem",
11289 }
11290
11291 // AOSP source apex
11292 apex {
11293 name: "com.android.foo",
11294 key: "com.android.foo.key",
11295 updatable: false,
11296 }
11297
11298 // Google source apex
11299 override_apex {
11300 name: "com.google.android.foo",
11301 base: "com.android.foo",
11302 key: "com.android.foo.key",
11303 }
11304
11305 // Prebuilt Google APEX.
11306
11307 prebuilt_apex {
11308 name: "com.google.android.foo",
11309 apex_name: "com.android.foo",
11310 src: "com.android.foo-arm.apex",
11311 prefer: true, // prefer is set to true on both the prebuilts to induce an error if flagging is not present
11312 }
11313
11314 // Another Prebuilt Google APEX
11315 prebuilt_apex {
11316 name: "com.google.android.foo.v2",
11317 apex_name: "com.android.foo",
11318 source_apex_name: "com.google.android.foo", // source_apex_name becomes LOCAL_MODULE in the generated mk file
11319 src: "com.android.foo-arm.apex",
11320 prefer: true, // prefer is set to true on both the prebuilts to induce an error if flagging is not present
11321 }
11322
11323 // APEX contribution modules
11324
11325 apex_contributions {
11326 name: "foo.source.contributions",
11327 api_domain: "com.android.foo",
11328 contents: ["com.google.android.foo"],
11329 }
11330
11331 apex_contributions {
11332 name: "foo.prebuilt.contributions",
11333 api_domain: "com.android.foo",
11334 contents: ["prebuilt_com.google.android.foo"],
11335 }
11336
11337 apex_contributions {
11338 name: "foo.prebuilt.v2.contributions",
11339 api_domain: "com.android.foo",
11340 contents: ["prebuilt_com.google.android.foo.v2"],
11341 }
11342
11343 // This is an incompatible module because it selects multiple versions of the same mainline module
11344 apex_contributions {
11345 name: "foo.prebuilt.duplicate.contributions",
11346 api_domain: "com.android.foo",
11347 contents: [
11348 "prebuilt_com.google.android.foo",
11349 "prebuilt_com.google.android.foo.v2",
11350 ],
11351 }
11352 `
11353
11354 testCases := []struct {
11355 desc string
11356 selectedApexContributions string
11357 expectedVisibleModuleName string
11358 expectedHiddenModuleNames []string
11359 expectedError string
11360 }{
11361 {
11362 desc: "Source apex is selected, prebuilts should be hidden from make",
11363 selectedApexContributions: "foo.source.contributions",
11364 expectedVisibleModuleName: "com.google.android.foo",
11365 expectedHiddenModuleNames: []string{"prebuilt_com.google.android.foo", "prebuilt_com.google.android.foo.v2"},
11366 },
11367 {
11368 desc: "Prebuilt apex prebuilt_com.android.foo is selected, source and the other prebuilt should be hidden from make",
11369 selectedApexContributions: "foo.prebuilt.contributions",
11370 expectedVisibleModuleName: "prebuilt_com.google.android.foo",
11371 expectedHiddenModuleNames: []string{"com.google.android.foo", "prebuilt_com.google.android.foo.v2"},
11372 },
11373 {
11374 desc: "Prebuilt apex prebuilt_com.android.fooi.v2 is selected, source and the other prebuilt should be hidden from make",
11375 selectedApexContributions: "foo.prebuilt.v2.contributions",
11376 expectedVisibleModuleName: "prebuilt_com.google.android.foo.v2",
11377 expectedHiddenModuleNames: []string{"com.google.android.foo", "prebuilt_com.google.android.foo"},
11378 },
11379 {
11380 desc: "Multiple versions of a prebuilt apex is selected in the same release config",
11381 selectedApexContributions: "foo.prebuilt.duplicate.contributions",
11382 expectedError: "Found duplicate variations of the same module in apex_contributions: prebuilt_com.google.android.foo and prebuilt_com.google.android.foo.v2",
11383 },
11384 }
11385
11386 for _, tc := range testCases {
11387 preparer := android.GroupFixturePreparers(
11388 android.FixtureMergeMockFs(map[string][]byte{
11389 "system/sepolicy/apex/com.android.foo-file_contexts": nil,
11390 }),
11391 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
11392 variables.BuildFlags = map[string]string{
11393 "RELEASE_APEX_CONTRIBUTIONS_ADSERVICES": tc.selectedApexContributions,
11394 }
11395 }),
11396 )
11397 if tc.expectedError != "" {
11398 preparer = preparer.ExtendWithErrorHandler(android.FixtureExpectsOneErrorPattern(tc.expectedError))
11399 testApex(t, bp, preparer)
11400 return
11401 }
11402 ctx := testApex(t, bp, preparer)
11403
11404 // Check that the LOCAL_MODULE of the two prebuilts is com.android.foo
11405 // This ensures that product packaging can pick them for installation if it has been flagged by apex_contributions
11406 checkLocalModuleName(t, ctx, "prebuilt_com.google.android.foo", "com.google.android.foo")
11407 checkLocalModuleName(t, ctx, "prebuilt_com.google.android.foo.v2", "com.google.android.foo")
11408
11409 // Check that
11410 // 1. The contents of the selected apex_contributions are visible to make
11411 // 2. The rest of the apexes in the mainline module family (source or other prebuilt) is hidden from make
11412 checkHideFromMake(t, ctx, tc.expectedVisibleModuleName, tc.expectedHiddenModuleNames)
11413 }
11414}
Jihoon Kang3921f0b2024-03-12 23:51:37 +000011415
11416func TestAconfifDeclarationsValidation(t *testing.T) {
11417 aconfigDeclarationLibraryString := func(moduleNames []string) (ret string) {
11418 for _, moduleName := range moduleNames {
11419 ret += fmt.Sprintf(`
11420 aconfig_declarations {
11421 name: "%[1]s",
11422 package: "com.example.package",
Yu Liu315a53c2024-04-24 16:41:57 +000011423 container: "system",
Jihoon Kang3921f0b2024-03-12 23:51:37 +000011424 srcs: [
11425 "%[1]s.aconfig",
11426 ],
11427 }
11428 java_aconfig_library {
11429 name: "%[1]s-lib",
11430 aconfig_declarations: "%[1]s",
11431 }
11432 `, moduleName)
11433 }
11434 return ret
11435 }
11436
11437 result := android.GroupFixturePreparers(
11438 prepareForApexTest,
11439 java.PrepareForTestWithJavaSdkLibraryFiles,
11440 java.FixtureWithLastReleaseApis("foo"),
11441 android.FixtureModifyConfig(func(config android.Config) {
11442 config.SetApiLibraries([]string{"foo"})
11443 }),
11444 ).RunTestWithBp(t, `
11445 java_library {
11446 name: "baz-java-lib",
11447 static_libs: [
11448 "baz-lib",
11449 ],
11450 }
11451 filegroup {
11452 name: "qux-filegroup",
11453 srcs: [
11454 ":qux-lib{.generated_srcjars}",
11455 ],
11456 }
11457 filegroup {
11458 name: "qux-another-filegroup",
11459 srcs: [
11460 ":qux-filegroup",
11461 ],
11462 }
11463 java_library {
11464 name: "quux-java-lib",
11465 srcs: [
11466 "a.java",
11467 ],
11468 libs: [
11469 "quux-lib",
11470 ],
11471 }
11472 java_sdk_library {
11473 name: "foo",
11474 srcs: [
11475 ":qux-another-filegroup",
11476 ],
11477 api_packages: ["foo"],
11478 system: {
11479 enabled: true,
11480 },
11481 module_lib: {
11482 enabled: true,
11483 },
11484 test: {
11485 enabled: true,
11486 },
11487 static_libs: [
11488 "bar-lib",
11489 ],
11490 libs: [
11491 "baz-java-lib",
11492 "quux-java-lib",
11493 ],
11494 aconfig_declarations: [
11495 "bar",
11496 ],
11497 }
11498 `+aconfigDeclarationLibraryString([]string{"bar", "baz", "qux", "quux"}))
11499
11500 m := result.ModuleForTests("foo.stubs.source", "android_common")
11501 outDir := "out/soong/.intermediates"
11502
11503 // Arguments passed to aconfig to retrieve the state of the flags defined in the
11504 // textproto files
11505 aconfigFlagArgs := m.Output("released-flagged-apis-exportable.txt").Args["flags_path"]
11506
11507 // "bar-lib" is a static_lib of "foo" and is passed to metalava as classpath. Thus the
11508 // cache file provided by the associated aconfig_declarations module "bar" should be passed
11509 // to aconfig.
11510 android.AssertStringDoesContain(t, "cache file of a java_aconfig_library static_lib "+
11511 "passed as an input",
11512 aconfigFlagArgs, fmt.Sprintf("%s/%s/intermediate.pb", outDir, "bar"))
11513
11514 // "baz-java-lib", which statically depends on "baz-lib", is a lib of "foo" and is passed
11515 // to metalava as classpath. Thus the cache file provided by the associated
11516 // aconfig_declarations module "baz" should be passed to aconfig.
11517 android.AssertStringDoesContain(t, "cache file of a lib that statically depends on "+
11518 "java_aconfig_library passed as an input",
11519 aconfigFlagArgs, fmt.Sprintf("%s/%s/intermediate.pb", outDir, "baz"))
11520
11521 // "qux-lib" is passed to metalava as src via the filegroup, thus the cache file provided by
11522 // the associated aconfig_declarations module "qux" should be passed to aconfig.
11523 android.AssertStringDoesContain(t, "cache file of srcs java_aconfig_library passed as an "+
11524 "input",
11525 aconfigFlagArgs, fmt.Sprintf("%s/%s/intermediate.pb", outDir, "qux"))
11526
11527 // "quux-java-lib" is a lib of "foo" and is passed to metalava as classpath, but does not
11528 // statically depend on "quux-lib". Therefore, the cache file provided by the associated
11529 // aconfig_declarations module "quux" should not be passed to aconfig.
11530 android.AssertStringDoesNotContain(t, "cache file of a lib that does not statically "+
11531 "depend on java_aconfig_library not passed as an input",
11532 aconfigFlagArgs, fmt.Sprintf("%s/%s/intermediate.pb", outDir, "quux"))
11533}