blob: d5c4ebaafdfd589f94525d77e101853b5fbc250a [file] [log] [blame]
Colin Cross30e076a2015-04-13 13:58:27 -07001// Copyright 2015 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
Jaewoong Jungf9b44652020-12-21 12:29:12 -080017// This file contains the module implementations for android_app, android_test, and some more
18// related module types, including their override variants.
Colin Cross30e076a2015-04-13 13:58:27 -070019
20import (
Jiakai Zhang4f65a032023-06-01 15:16:58 +010021 "fmt"
Jaewoong Junga5e5abc2019-04-26 14:31:50 -070022 "path/filepath"
Jaewoong Junga5e5abc2019-04-26 14:31:50 -070023 "strings"
Colin Cross30e076a2015-04-13 13:58:27 -070024
Jihoon Kang84b25892023-12-01 22:01:06 +000025 "android/soong/aconfig"
Aditya Choudhary9b593522023-10-06 19:54:58 +000026 "android/soong/testing"
Jihoon Kang84b25892023-12-01 22:01:06 +000027
Colin Cross50ddcc42019-05-16 12:28:22 -070028 "github.com/google/blueprint"
29 "github.com/google/blueprint/proptools"
30
Colin Cross635c3b02016-05-18 15:37:25 -070031 "android/soong/android"
Colin Crossa4f08812018-10-02 22:03:40 -070032 "android/soong/cc"
Ulya Trafimovichd4bcea42020-06-03 14:57:22 +010033 "android/soong/dexpreopt"
Romain Jobredeaux9973ace2023-08-30 00:27:09 -040034 "android/soong/genrule"
Colin Cross303e21f2018-08-07 16:49:25 -070035 "android/soong/tradefed"
Colin Cross30e076a2015-04-13 13:58:27 -070036)
37
Colin Cross3bc7ffa2017-11-22 16:19:37 -080038func init() {
Paul Duffinf9b1da02019-12-18 19:51:55 +000039 RegisterAppBuildComponents(android.InitRegistrationContext)
Andrei Onea580636b2022-08-17 16:53:46 +000040 pctx.HostBinToolVariable("ModifyAllowlistCmd", "modify_permissions_allowlist")
Colin Cross3bc7ffa2017-11-22 16:19:37 -080041}
42
Andrei Onea580636b2022-08-17 16:53:46 +000043var (
44 modifyAllowlist = pctx.AndroidStaticRule("modifyAllowlist",
45 blueprint.RuleParams{
46 Command: "${ModifyAllowlistCmd} $in $packageName $out",
47 CommandDeps: []string{"${ModifyAllowlistCmd}"},
48 }, "packageName")
49)
50
Paul Duffinf9b1da02019-12-18 19:51:55 +000051func RegisterAppBuildComponents(ctx android.RegistrationContext) {
52 ctx.RegisterModuleType("android_app", AndroidAppFactory)
53 ctx.RegisterModuleType("android_test", AndroidTestFactory)
54 ctx.RegisterModuleType("android_test_helper_app", AndroidTestHelperAppFactory)
55 ctx.RegisterModuleType("android_app_certificate", AndroidAppCertificateFactory)
56 ctx.RegisterModuleType("override_android_app", OverrideAndroidAppModuleFactory)
57 ctx.RegisterModuleType("override_android_test", OverrideAndroidTestModuleFactory)
Paul Duffinf9b1da02019-12-18 19:51:55 +000058}
59
Colin Cross30e076a2015-04-13 13:58:27 -070060// AndroidManifest.xml merging
61// package splits
62
Colin Crossfabb6082018-02-20 17:22:23 -080063type appProperties struct {
Colin Crossbd01e2a2018-10-04 15:21:03 -070064 // Names of extra android_app_certificate modules to sign the apk with in the form ":module".
Colin Cross7d5136f2015-05-11 13:39:40 -070065 Additional_certificates []string
66
67 // If set, create package-export.apk, which other packages can
68 // use to get PRODUCT-agnostic resource data like IDs and type definitions.
Nan Zhangea568a42017-11-08 21:20:04 -080069 Export_package_resources *bool
Colin Cross7d5136f2015-05-11 13:39:40 -070070
Colin Cross16056062017-12-13 22:46:28 -080071 // Specifies that this app should be installed to the priv-app directory,
72 // where the system will grant it additional privileges not available to
73 // normal apps.
74 Privileged *bool
Colin Crossa97c5d32018-03-28 14:58:31 -070075
76 // list of resource labels to generate individual resource packages
77 Package_splits []string
Jason Monkd4122be2018-08-10 09:33:36 -040078
Colin Crossa4f08812018-10-02 22:03:40 -070079 // list of native libraries that will be provided in or alongside the resulting jar
80 Jni_libs []string `android:"arch_variant"`
81
Colin Cross7204cf02020-05-06 17:51:39 -070082 // if true, use JNI libraries that link against platform APIs even if this module sets
Colin Crossee87c602020-02-19 16:57:15 -080083 // sdk_version.
84 Jni_uses_platform_apis *bool
85
Colin Cross7204cf02020-05-06 17:51:39 -070086 // if true, use JNI libraries that link against SDK APIs even if this module does not set
87 // sdk_version.
88 Jni_uses_sdk_apis *bool
89
Jaewoong Jungbc625cd2019-05-06 15:48:44 -070090 // STL library to use for JNI libraries.
91 Stl *string `android:"arch_variant"`
92
Colin Crosse4246ab2019-02-05 21:55:21 -080093 // Store native libraries uncompressed in the APK and set the android:extractNativeLibs="false" manifest
94 // flag so that they are used from inside the APK at runtime. Defaults to true for android_test modules unless
Jiyong Park52cd06f2019-11-11 10:14:32 +090095 // sdk_version or min_sdk_version is set to a version that doesn't support it (<23), defaults to true for
96 // android_app modules that are embedded to APEXes, defaults to false for other module types where the native
97 // libraries are generally preinstalled outside the APK.
Colin Crosse4246ab2019-02-05 21:55:21 -080098 Use_embedded_native_libs *bool
Colin Cross46abdad2019-02-07 13:07:08 -080099
100 // Store dex files uncompressed in the APK and set the android:useEmbeddedDex="true" manifest attribute so that
101 // they are used from inside the APK at runtime.
102 Use_embedded_dex *bool
Colin Cross47fa9d32019-03-26 10:51:39 -0700103
104 // Forces native libraries to always be packaged into the APK,
105 // Use_embedded_native_libs still selects whether they are stored uncompressed and aligned or compressed.
106 // True for android_test* modules.
107 AlwaysPackageNativeLibs bool `blueprint:"mutated"`
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700108
109 // If set, find and merge all NOTICE files that this module and its dependencies have and store
110 // it in the APK as an asset.
111 Embed_notices *bool
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700112
113 // cc.Coverage related properties
114 PreventInstall bool `blueprint:"mutated"`
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700115 IsCoverageVariant bool `blueprint:"mutated"`
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100116
Harshit Mahajan5b8b7302022-06-10 11:24:05 +0000117 // It can be set to test the behaviour of default target sdk version.
118 // Only required when updatable: false. It is an error if updatable: true and this is false.
119 Enforce_default_target_sdk_version *bool
120
121 // If set, the targetSdkVersion for the target is set to the latest default API level.
122 // This would be by default false, unless updatable: true or
123 // enforce_default_target_sdk_version: true in which case this defaults to true.
124 EnforceDefaultTargetSdkVersion bool `blueprint:"mutated"`
125
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100126 // Whether this app is considered mainline updatable or not. When set to true, this will enforce
Artur Satayevf40fc852020-04-16 13:43:02 +0100127 // additional rules to make sure an app can safely be updated. Default is false.
128 // Prefer using other specific properties if build behaviour must be changed; avoid using this
129 // flag for anything but neverallow rules (unless the behaviour change is invisible to owners).
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100130 Updatable *bool
Andrei Onea580636b2022-08-17 16:53:46 +0000131
132 // Specifies the file that contains the allowlist for this app.
133 Privapp_allowlist *string `android:"path"`
Inseob Kim34dc4cd2023-11-07 13:37:14 +0900134
135 // If set, create an RRO package which contains only resources having PRODUCT_CHARACTERISTICS
136 // and install the RRO package to /product partition, instead of passing --product argument
137 // to aapt2. Default is false.
138 // Setting this will make this APK identical to all targets, regardless of
139 // PRODUCT_CHARACTERISTICS.
140 Generate_product_characteristics_rro *bool
141
Cole Faustdf1efd72023-12-08 12:27:24 -0800142 // A list of files or dependencies to make available to the build sandbox. This is
143 // useful if source files are symlinks, the targets of the symlinks must be listed here.
144 // Note that currently not all actions implemented by android_apps are sandboxed, so you
145 // may only see this being necessary in lint builds.
146 Compile_data []string
147
Inseob Kim34dc4cd2023-11-07 13:37:14 +0900148 ProductCharacteristicsRROPackageName *string `blueprint:"mutated"`
149 ProductCharacteristicsRROManifestModuleName *string `blueprint:"mutated"`
Colin Cross7d5136f2015-05-11 13:39:40 -0700150}
151
Jaewoong Jung525443a2019-02-28 15:35:54 -0800152// android_app properties that can be overridden by override_android_app
153type overridableAppProperties struct {
154 // The name of a certificate in the default certificate directory, blank to use the default product certificate,
155 // or an android_app_certificate module name in the form ":module".
156 Certificate *string
Jaewoong Jung6f373f62019-03-13 10:13:24 -0700157
Jaewoong Jung1c1b6e62021-03-09 15:02:31 -0800158 // Name of the signing certificate lineage file or filegroup module.
159 Lineage *string `android:"path"`
Liz Kammere2b27f42020-05-07 13:24:05 -0700160
Rupert Shuttleworth8eab8692021-11-03 10:39:39 -0400161 // For overriding the --rotation-min-sdk-version property of apksig
162 RotationMinSdkVersion *string
163
Jaewoong Jung6f373f62019-03-13 10:13:24 -0700164 // the package name of this app. The package name in the manifest file is used if one was not given.
165 Package_name *string
Baligh Uddin5b16dfb2020-02-11 17:27:19 -0800166
167 // the logging parent of this app.
168 Logging_parent *string
Liz Kammer9f9fd022020-06-18 19:44:06 +0000169
170 // Whether to rename the package in resources to the override name rather than the base name. Defaults to true.
171 Rename_resources_package *bool
zhidou198f5892022-02-17 02:33:12 +0000172
173 // Names of modules to be overridden. Listed modules can only be other binaries
174 // (in Make or Soong).
175 // This does not completely prevent installation of the overridden binaries, but if both
176 // binaries would be installed by default (in PRODUCT_PACKAGES) the other binary will be removed
177 // from PRODUCT_PACKAGES.
178 Overrides []string
Jihoon Kang84b25892023-12-01 22:01:06 +0000179
180 // Names of aconfig_declarations modules that specify aconfig flags that the app depends on.
181 Flags_packages []string
Jaewoong Jung525443a2019-02-28 15:35:54 -0800182}
183
Colin Cross30e076a2015-04-13 13:58:27 -0700184type AndroidApp struct {
Colin Crossa97c5d32018-03-28 14:58:31 -0700185 Library
186 aapt
Jaewoong Jung525443a2019-02-28 15:35:54 -0800187 android.OverridableModuleBase
Colin Crossa97c5d32018-03-28 14:58:31 -0700188
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900189 certificate Certificate
Colin Cross30e076a2015-04-13 13:58:27 -0700190
Colin Crossfabb6082018-02-20 17:22:23 -0800191 appProperties appProperties
Colin Crossae5caf52018-05-22 11:11:52 -0700192
Jaewoong Jung525443a2019-02-28 15:35:54 -0800193 overridableAppProperties overridableAppProperties
194
Colin Cross403cc152020-07-06 14:15:24 -0700195 jniLibs []jniLib
196 installPathForJNISymbols android.Path
197 embeddedJniLibs bool
198 jniCoverageOutputs android.Paths
Colin Crossf6237212018-10-29 23:14:58 -0700199
200 bundleFile android.Path
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800201
202 // the install APK name is normally the same as the module name, but can be overridden with PRODUCT_PACKAGE_NAME_OVERRIDES.
203 installApkName string
Jaewoong Jung4102e5d2019-02-27 16:26:28 -0800204
Colin Cross70dda7e2019-10-01 22:05:35 -0700205 installDir android.InstallPath
Jaewoong Jung0949f312019-09-11 10:25:18 -0700206
Jaewoong Jung7dd4ae22019-09-27 17:13:15 -0700207 onDeviceDir string
208
Jaewoong Jung4102e5d2019-02-27 16:26:28 -0800209 additionalAaptFlags []string
Jaewoong Jung98772792019-07-01 17:15:13 -0700210
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900211 overriddenManifestPackageName string
Artur Satayev1111b842020-04-27 19:05:28 +0100212
213 android.ApexBundleDepsInfo
Matt Banda8c801262022-04-01 17:48:31 +0000214
215 javaApiUsedByOutputFile android.ModuleOutPath
Andrei Onea580636b2022-08-17 16:53:46 +0000216
217 privAppAllowlist android.OptionalPath
Colin Crosse1731a52017-12-14 11:22:55 -0800218}
219
Martin Stjernholm6d415272020-01-31 17:10:36 +0000220func (a *AndroidApp) IsInstallable() bool {
221 return Bool(a.properties.Installable)
222}
223
Colin Crossab8d1382023-07-14 17:23:41 +0000224func (a *AndroidApp) ResourcesNodeDepSet() *android.DepSet[*resourcesNode] {
225 return a.aapt.resourcesNodesDepSet
Colin Cross66f78822018-05-02 12:58:28 -0700226}
227
Sundong Ahne1f05aa2019-08-27 13:55:42 +0900228func (a *AndroidApp) OutputFile() android.Path {
229 return a.outputFile
230}
231
Colin Cross503c1d02020-01-28 14:00:53 -0800232func (a *AndroidApp) Certificate() Certificate {
233 return a.certificate
234}
235
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700236func (a *AndroidApp) JniCoverageOutputs() android.Paths {
237 return a.jniCoverageOutputs
238}
239
Andrei Onea580636b2022-08-17 16:53:46 +0000240func (a *AndroidApp) PrivAppAllowlist() android.OptionalPath {
241 return a.privAppAllowlist
242}
243
Colin Crossa97c5d32018-03-28 14:58:31 -0700244var _ AndroidLibraryDependency = (*AndroidApp)(nil)
245
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900246type Certificate struct {
Colin Cross503c1d02020-01-28 14:00:53 -0800247 Pem, Key android.Path
248 presigned bool
249}
250
Sasha Smundak18d98bc2020-05-27 16:36:07 -0700251var PresignedCertificate = Certificate{presigned: true}
Colin Cross503c1d02020-01-28 14:00:53 -0800252
253func (c Certificate) AndroidMkString() string {
254 if c.presigned {
255 return "PRESIGNED"
256 } else {
257 return c.Pem.String()
258 }
Colin Cross30e076a2015-04-13 13:58:27 -0700259}
260
Colin Cross46c9b8b2017-06-22 16:51:17 -0700261func (a *AndroidApp) DepsMutator(ctx android.BottomUpMutatorContext) {
262 a.Module.deps(ctx)
Colin Crossa4f08812018-10-02 22:03:40 -0700263
Jiyong Park92315372021-04-02 08:45:46 +0900264 if String(a.appProperties.Stl) == "c++_shared" && !a.SdkVersion(ctx).Specified() {
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700265 ctx.PropertyErrorf("stl", "sdk_version must be set in order to use c++_shared")
266 }
267
Jiyong Parkf1691d22021-03-29 20:11:58 +0900268 sdkDep := decodeSdkDep(ctx, android.SdkContext(a))
Paul Duffin250e6192019-06-07 10:44:37 +0100269 if sdkDep.hasFrameworkLibs() {
270 a.aapt.deps(ctx, sdkDep)
Colin Cross30e076a2015-04-13 13:58:27 -0700271 }
Colin Crossa4f08812018-10-02 22:03:40 -0700272
Jiyong Park92315372021-04-02 08:45:46 +0900273 usesSDK := a.SdkVersion(ctx).Specified() && a.SdkVersion(ctx).Kind != android.SdkCorePlatform
Colin Cross3c007702020-05-08 11:20:24 -0700274
275 if usesSDK && Bool(a.appProperties.Jni_uses_sdk_apis) {
276 ctx.PropertyErrorf("jni_uses_sdk_apis",
277 "can only be set for modules that do not set sdk_version")
278 } else if !usesSDK && Bool(a.appProperties.Jni_uses_platform_apis) {
279 ctx.PropertyErrorf("jni_uses_platform_apis",
280 "can only be set for modules that set sdk_version")
281 }
282
Colin Crossa4f08812018-10-02 22:03:40 -0700283 for _, jniTarget := range ctx.MultiTargets() {
Colin Cross0f7d2ef2019-10-16 11:03:10 -0700284 variation := append(jniTarget.Variations(),
285 blueprint.Variation{Mutator: "link", Variation: "shared"})
Colin Crossc511bc52020-04-07 16:50:32 +0000286
287 // If the app builds against an Android SDK use the SDK variant of JNI dependencies
288 // unless jni_uses_platform_apis is set.
Colin Crossc2d24052020-05-13 11:05:02 -0700289 // Don't require the SDK variant for apps that are shipped on vendor, etc., as they already
290 // have stable APIs through the VNDK.
291 if (usesSDK && !a.RequiresStableAPIs(ctx) &&
292 !Bool(a.appProperties.Jni_uses_platform_apis)) ||
Colin Cross7204cf02020-05-06 17:51:39 -0700293 Bool(a.appProperties.Jni_uses_sdk_apis) {
Colin Crossc511bc52020-04-07 16:50:32 +0000294 variation = append(variation, blueprint.Variation{Mutator: "sdk", Variation: "sdk"})
295 }
Colin Crossde78d132020-10-09 18:59:49 -0700296 ctx.AddFarVariationDependencies(variation, jniLibTag, a.appProperties.Jni_libs...)
Colin Crossa4f08812018-10-02 22:03:40 -0700297 }
Colin Cross50ddcc42019-05-16 12:28:22 -0700298
Paul Duffin250e6192019-06-07 10:44:37 +0100299 a.usesLibrary.deps(ctx, sdkDep.hasFrameworkLibs())
Jaewoong Jungb639a6a2019-05-10 15:16:29 -0700300}
Colin Crossbd01e2a2018-10-04 15:21:03 -0700301
Jaewoong Jungb639a6a2019-05-10 15:16:29 -0700302func (a *AndroidApp) OverridablePropertiesDepsMutator(ctx android.BottomUpMutatorContext) {
Jaewoong Jung2ad817c2019-01-18 14:27:16 -0800303 cert := android.SrcIsModule(a.getCertString(ctx))
Colin Crossbd01e2a2018-10-04 15:21:03 -0700304 if cert != "" {
305 ctx.AddDependency(ctx.Module(), certificateTag, cert)
306 }
307
Andrei Onea580636b2022-08-17 16:53:46 +0000308 if a.appProperties.Privapp_allowlist != nil && !Bool(a.appProperties.Privileged) {
Anton Hanssone3f31cf2023-06-03 08:53:47 +0000309 // There are a few uids that are explicitly considered privileged regardless of their
310 // app's location. Bluetooth is one such app. It should arguably be moved to priv-app,
311 // but for now, allow it not to be in priv-app.
312 privilegedBecauseOfUid := ctx.ModuleName() == "Bluetooth"
313 if !privilegedBecauseOfUid {
314 ctx.PropertyErrorf("privapp_allowlist", "privileged must be set in order to use privapp_allowlist (with a few exceptions)")
315 }
Andrei Onea580636b2022-08-17 16:53:46 +0000316 }
317
Colin Crossbd01e2a2018-10-04 15:21:03 -0700318 for _, cert := range a.appProperties.Additional_certificates {
319 cert = android.SrcIsModule(cert)
320 if cert != "" {
321 ctx.AddDependency(ctx.Module(), certificateTag, cert)
322 } else {
323 ctx.PropertyErrorf("additional_certificates",
324 `must be names of android_app_certificate modules in the form ":module"`)
325 }
326 }
Jihoon Kang84b25892023-12-01 22:01:06 +0000327
328 for _, aconfig_declaration := range a.overridableAppProperties.Flags_packages {
329 ctx.AddDependency(ctx.Module(), aconfigDeclarationTag, aconfig_declaration)
330 }
Colin Cross30e076a2015-04-13 13:58:27 -0700331}
332
Jeongik Cha538c0d02019-07-11 15:54:27 +0900333func (a *AndroidTestHelperApp) GenerateAndroidBuildActions(ctx android.ModuleContext) {
Alix96ea88452023-08-31 15:48:23 +0000334 applicationId := a.appTestHelperAppProperties.Manifest_values.ApplicationId
335 if applicationId != nil {
336 if a.overridableAppProperties.Package_name != nil {
337 ctx.PropertyErrorf("manifest_values.applicationId", "property is not supported when property package_name is set.")
338 }
339 a.aapt.manifestValues.applicationId = *applicationId
340 }
Jeongik Cha538c0d02019-07-11 15:54:27 +0900341 a.generateAndroidBuildActions(ctx)
342}
343
Colin Cross46c9b8b2017-06-22 16:51:17 -0700344func (a *AndroidApp) GenerateAndroidBuildActions(ctx android.ModuleContext) {
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100345 a.checkAppSdkVersions(ctx)
Colin Crossae5caf52018-05-22 11:11:52 -0700346 a.generateAndroidBuildActions(ctx)
Matt Banda8c801262022-04-01 17:48:31 +0000347 a.generateJavaUsedByApex(ctx)
Colin Crossae5caf52018-05-22 11:11:52 -0700348}
349
Sam Delmerico0e0d96e2023-08-18 22:43:28 +0000350func (a *AndroidApp) MinSdkVersion(ctx android.EarlyModuleContext) android.ApiLevel {
351 defaultMinSdkVersion := a.Module.MinSdkVersion(ctx)
352 if proptools.Bool(a.appProperties.Updatable) {
353 overrideApiLevel := android.MinSdkVersionFromValue(ctx, ctx.DeviceConfig().ApexGlobalMinSdkVersionOverride())
354 if !overrideApiLevel.IsNone() && overrideApiLevel.CompareTo(defaultMinSdkVersion) > 0 {
355 return overrideApiLevel
356 }
357 }
358 return defaultMinSdkVersion
359}
360
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100361func (a *AndroidApp) checkAppSdkVersions(ctx android.ModuleContext) {
Artur Satayev849f8442020-04-28 14:57:42 +0100362 if a.Updatable() {
Jiyong Park92315372021-04-02 08:45:46 +0900363 if !a.SdkVersion(ctx).Stable() {
364 ctx.PropertyErrorf("sdk_version", "Updatable apps must use stable SDKs, found %v", a.SdkVersion(ctx))
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100365 }
Artur Satayevf40fc852020-04-16 13:43:02 +0100366 if String(a.deviceProperties.Min_sdk_version) == "" {
367 ctx.PropertyErrorf("updatable", "updatable apps must set min_sdk_version.")
368 }
Jooyung Han749dc692020-04-15 11:03:39 +0900369
Jiyong Park92315372021-04-02 08:45:46 +0900370 if minSdkVersion, err := a.MinSdkVersion(ctx).EffectiveVersion(ctx); err == nil {
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900371 a.checkJniLibsSdkVersion(ctx, minSdkVersion)
satayevb3fd4112021-12-02 13:59:35 +0000372 android.CheckMinSdkVersion(ctx, minSdkVersion, a.WalkPayloadDeps)
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900373 } else {
374 ctx.PropertyErrorf("min_sdk_version", "%s", err.Error())
375 }
Harshit Mahajan5b8b7302022-06-10 11:24:05 +0000376
377 if !BoolDefault(a.appProperties.Enforce_default_target_sdk_version, true) {
378 ctx.PropertyErrorf("enforce_default_target_sdk_version", "Updatable apps must enforce default target sdk version")
379 }
380 // TODO(b/227460469) after all the modules removes the target sdk version, throw an error if the target sdk version is explicitly set.
381 if a.deviceProperties.Target_sdk_version == nil {
382 a.SetEnforceDefaultTargetSdkVersion(true)
383 }
384 }
385
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100386 a.checkPlatformAPI(ctx)
387 a.checkSdkVersions(ctx)
388}
389
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900390// If an updatable APK sets min_sdk_version, min_sdk_vesion of JNI libs should match with it.
391// This check is enforced for "updatable" APKs (including APK-in-APEX).
Jiyong Park54105c42021-03-31 18:17:53 +0900392func (a *AndroidApp) checkJniLibsSdkVersion(ctx android.ModuleContext, minSdkVersion android.ApiLevel) {
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900393 // It's enough to check direct JNI deps' sdk_version because all transitive deps from JNI deps are checked in cc.checkLinkType()
394 ctx.VisitDirectDeps(func(m android.Module) {
395 if !IsJniDepTag(ctx.OtherModuleDependencyTag(m)) {
396 return
397 }
398 dep, _ := m.(*cc.Module)
Jooyung Han652d5b32020-05-20 17:12:13 +0900399 // The domain of cc.sdk_version is "current" and <number>
Jiyong Parkf1691d22021-03-29 20:11:58 +0900400 // We can rely on android.SdkSpec to convert it to <number> so that "current" is
401 // handled properly regardless of sdk finalization.
Spandan Das2e8c0442022-05-08 00:39:35 +0000402 jniSdkVersion, err := android.SdkSpecFrom(ctx, dep.MinSdkVersion()).EffectiveVersion(ctx)
Jiyong Park54105c42021-03-31 18:17:53 +0900403 if err != nil || minSdkVersion.LessThan(jniSdkVersion) {
Spandan Das2e8c0442022-05-08 00:39:35 +0000404 ctx.OtherModuleErrorf(dep, "min_sdk_version(%v) is higher than min_sdk_version(%v) of the containing android_app(%v)",
405 dep.MinSdkVersion(), minSdkVersion, ctx.ModuleName())
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900406 return
407 }
408
409 })
410}
411
Sasha Smundak6ad77252019-05-01 13:16:22 -0700412// Returns true if the native libraries should be stored in the APK uncompressed and the
Colin Crosse4246ab2019-02-05 21:55:21 -0800413// extractNativeLibs application flag should be set to false in the manifest.
Sasha Smundak6ad77252019-05-01 13:16:22 -0700414func (a *AndroidApp) useEmbeddedNativeLibs(ctx android.ModuleContext) bool {
Jiyong Park92315372021-04-02 08:45:46 +0900415 minSdkVersion, err := a.MinSdkVersion(ctx).EffectiveVersion(ctx)
Colin Crosse4246ab2019-02-05 21:55:21 -0800416 if err != nil {
Jiyong Park92315372021-04-02 08:45:46 +0900417 ctx.PropertyErrorf("min_sdk_version", "invalid value %q: %s", a.MinSdkVersion(ctx), err)
Colin Crosse4246ab2019-02-05 21:55:21 -0800418 }
419
Colin Cross56a83212020-09-15 18:30:11 -0700420 apexInfo := ctx.Provider(android.ApexInfoProvider).(android.ApexInfo)
Jiyong Park54105c42021-03-31 18:17:53 +0900421 return (minSdkVersion.FinalOrFutureInt() >= 23 && Bool(a.appProperties.Use_embedded_native_libs)) ||
Colin Cross56a83212020-09-15 18:30:11 -0700422 !apexInfo.IsForPlatform()
Colin Crosse4246ab2019-02-05 21:55:21 -0800423}
424
Colin Cross43f08db2018-11-12 10:13:39 -0800425// Returns whether this module should have the dex file stored uncompressed in the APK.
426func (a *AndroidApp) shouldUncompressDex(ctx android.ModuleContext) bool {
Colin Cross46abdad2019-02-07 13:07:08 -0800427 if Bool(a.appProperties.Use_embedded_dex) {
428 return true
429 }
430
Colin Cross53a87f52019-06-25 13:35:30 -0700431 // Uncompress dex in APKs of privileged apps (even for unbundled builds, they may
432 // be preinstalled as prebuilts).
Jiyong Parkf7487312019-10-17 12:54:30 +0900433 if ctx.Config().UncompressPrivAppDex() && a.Privileged() {
Nicolas Geoffrayfa6e9ec2019-02-12 13:12:16 +0000434 return true
435 }
436
Colin Cross53a87f52019-06-25 13:35:30 -0700437 if ctx.Config().UnbundledBuild() {
438 return false
439 }
440
Jaewoong Jungacf18d72019-05-02 14:55:29 -0700441 return shouldUncompressDex(ctx, &a.dexpreopter)
Colin Cross5a0dcd52018-10-05 14:20:06 -0700442}
443
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700444func (a *AndroidApp) shouldEmbedJnis(ctx android.BaseModuleContext) bool {
Colin Cross56a83212020-09-15 18:30:11 -0700445 apexInfo := ctx.Provider(android.ApexInfoProvider).(android.ApexInfo)
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700446 return ctx.Config().UnbundledBuild() || Bool(a.appProperties.Use_embedded_native_libs) ||
Colin Cross56a83212020-09-15 18:30:11 -0700447 !apexInfo.IsForPlatform() || a.appProperties.AlwaysPackageNativeLibs
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700448}
449
Liz Kammer9f9fd022020-06-18 19:44:06 +0000450func generateAaptRenamePackageFlags(packageName string, renameResourcesPackage bool) []string {
451 aaptFlags := []string{"--rename-manifest-package " + packageName}
452 if renameResourcesPackage {
453 // Required to rename the package name in the resources table.
454 aaptFlags = append(aaptFlags, "--rename-resources-package "+packageName)
455 }
456 return aaptFlags
457}
458
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900459func (a *AndroidApp) OverriddenManifestPackageName() string {
460 return a.overriddenManifestPackageName
461}
462
Liz Kammer9f9fd022020-06-18 19:44:06 +0000463func (a *AndroidApp) renameResourcesPackage() bool {
464 return proptools.BoolDefault(a.overridableAppProperties.Rename_resources_package, true)
465}
466
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800467func (a *AndroidApp) aaptBuildActions(ctx android.ModuleContext) {
Lorenzo Colittifa9b3f32021-03-30 10:38:26 +0900468 usePlatformAPI := proptools.Bool(a.Module.deviceProperties.Platform_apis)
Jiyong Park92315372021-04-02 08:45:46 +0900469 if ctx.Module().(android.SdkContext).SdkVersion(ctx).Kind == android.SdkModule {
Lorenzo Colittifa9b3f32021-03-30 10:38:26 +0900470 usePlatformAPI = true
471 }
472 a.aapt.usesNonSdkApis = usePlatformAPI
David Brazdild25060a2019-02-18 18:24:16 +0000473
Jaewoong Jungc27ab662019-05-30 15:51:14 -0700474 // Ask manifest_fixer to add or update the application element indicating this app has no code.
475 a.aapt.hasNoCode = !a.hasCode(ctx)
476
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800477 aaptLinkFlags := []string{}
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800478
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800479 // Add TARGET_AAPT_CHARACTERISTICS values to AAPT link flags if they exist and --product flags were not provided.
Inseob Kim34dc4cd2023-11-07 13:37:14 +0900480 autogenerateRRO := proptools.Bool(a.appProperties.Generate_product_characteristics_rro)
Jaewoong Jung3aff5782020-02-11 07:54:35 -0800481 hasProduct := android.PrefixInList(a.aaptProperties.Aaptflags, "--product")
Inseob Kim34dc4cd2023-11-07 13:37:14 +0900482 if !autogenerateRRO && !hasProduct && len(ctx.Config().ProductAAPTCharacteristics()) > 0 {
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800483 aaptLinkFlags = append(aaptLinkFlags, "--product", ctx.Config().ProductAAPTCharacteristics())
Colin Crosse78dcd32018-04-19 15:25:19 -0700484 }
485
Dan Willemsen72be5902018-10-24 20:24:57 -0700486 if !Bool(a.aaptProperties.Aapt_include_all_resources) {
487 // Product AAPT config
488 for _, aaptConfig := range ctx.Config().ProductAAPTConfig() {
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800489 aaptLinkFlags = append(aaptLinkFlags, "-c", aaptConfig)
Dan Willemsen72be5902018-10-24 20:24:57 -0700490 }
Colin Crosse78dcd32018-04-19 15:25:19 -0700491
Dan Willemsen72be5902018-10-24 20:24:57 -0700492 // Product AAPT preferred config
493 if len(ctx.Config().ProductAAPTPreferredConfig()) > 0 {
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800494 aaptLinkFlags = append(aaptLinkFlags, "--preferred-density", ctx.Config().ProductAAPTPreferredConfig())
Dan Willemsen72be5902018-10-24 20:24:57 -0700495 }
Colin Crosse78dcd32018-04-19 15:25:19 -0700496 }
497
Jiyong Park7f67f482019-01-05 12:57:48 +0900498 manifestPackageName, overridden := ctx.DeviceConfig().OverrideManifestPackageNameFor(ctx.ModuleName())
Jaewoong Jung6f373f62019-03-13 10:13:24 -0700499 if overridden || a.overridableAppProperties.Package_name != nil {
500 // The product override variable has a priority over the package_name property.
501 if !overridden {
502 manifestPackageName = *a.overridableAppProperties.Package_name
503 }
Liz Kammer9f9fd022020-06-18 19:44:06 +0000504 aaptLinkFlags = append(aaptLinkFlags, generateAaptRenamePackageFlags(manifestPackageName, a.renameResourcesPackage())...)
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900505 a.overriddenManifestPackageName = manifestPackageName
Jiyong Park7f67f482019-01-05 12:57:48 +0900506 }
507
Jaewoong Jung4102e5d2019-02-27 16:26:28 -0800508 aaptLinkFlags = append(aaptLinkFlags, a.additionalAaptFlags...)
509
Colin Crosse560c4a2019-03-19 16:03:11 -0700510 a.aapt.splitNames = a.appProperties.Package_splits
Baligh Uddin5b16dfb2020-02-11 17:27:19 -0800511 a.aapt.LoggingParent = String(a.overridableAppProperties.Logging_parent)
Alexei Nicoara69cf0f32022-07-27 14:59:18 +0100512 if a.Updatable() {
513 a.aapt.defaultManifestVersion = android.DefaultUpdatableModuleVersion
514 }
Jihoon Kang84b25892023-12-01 22:01:06 +0000515
516 var aconfigTextFilePaths android.Paths
517 ctx.VisitDirectDepsWithTag(aconfigDeclarationTag, func(dep android.Module) {
518 if provider, ok := ctx.OtherModuleProvider(dep, aconfig.DeclarationsProviderKey).(aconfig.DeclarationsProviderData); ok {
519 aconfigTextFilePaths = append(aconfigTextFilePaths, provider.IntermediateDumpOutputPath)
520 } else {
521 ctx.ModuleErrorf("Only aconfig_declarations module type is allowed for "+
522 "flags_packages property, but %s is not aconfig_declarations module type",
523 dep.Name(),
524 )
525 }
526 })
527
Alixf7a10272023-09-27 16:47:56 +0000528 a.aapt.buildActions(ctx,
529 aaptBuildActionOptions{
Jihoon Kang84b25892023-12-01 22:01:06 +0000530 sdkContext: android.SdkContext(a),
531 classLoaderContexts: a.classLoaderContexts,
532 excludedLibs: a.usesLibraryProperties.Exclude_uses_libs,
533 enforceDefaultTargetSdkVersion: a.enforceDefaultTargetSdkVersion(),
534 extraLinkFlags: aaptLinkFlags,
535 aconfigTextFiles: aconfigTextFilePaths,
Alixf7a10272023-09-27 16:47:56 +0000536 },
537 )
Colin Cross30e076a2015-04-13 13:58:27 -0700538
Colin Cross46c9b8b2017-06-22 16:51:17 -0700539 // apps manifests are handled by aapt, don't let Module see them
Dan Willemsen34cc69e2015-09-23 15:26:20 -0700540 a.properties.Manifest = nil
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800541}
Colin Cross30e076a2015-04-13 13:58:27 -0700542
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800543func (a *AndroidApp) proguardBuildActions(ctx android.ModuleContext) {
Colin Cross89c31582018-04-30 15:55:11 -0700544 var staticLibProguardFlagFiles android.Paths
545 ctx.VisitDirectDeps(func(m android.Module) {
Sam Delmerico95d70942023-08-02 18:00:35 -0400546 depProguardInfo := ctx.OtherModuleProvider(m, ProguardSpecInfoProvider).(ProguardSpecInfo)
547 staticLibProguardFlagFiles = append(staticLibProguardFlagFiles, depProguardInfo.UnconditionallyExportedProguardFlags.ToList()...)
548 if ctx.OtherModuleDependencyTag(m) == staticLibTag {
549 staticLibProguardFlagFiles = append(staticLibProguardFlagFiles, depProguardInfo.ProguardFlagsFiles.ToList()...)
Colin Cross89c31582018-04-30 15:55:11 -0700550 }
551 })
552
553 staticLibProguardFlagFiles = android.FirstUniquePaths(staticLibProguardFlagFiles)
554
Colin Cross312634e2023-11-21 15:13:56 -0800555 a.Module.extraProguardFlagsFiles = append(a.Module.extraProguardFlagsFiles, staticLibProguardFlagFiles...)
556 a.Module.extraProguardFlagsFiles = append(a.Module.extraProguardFlagsFiles, a.proguardOptionsFile)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800557}
Colin Cross66dbc0b2017-12-28 12:23:20 -0800558
Colin Cross403cc152020-07-06 14:15:24 -0700559func (a *AndroidApp) installPath(ctx android.ModuleContext) android.InstallPath {
Colin Cross43f08db2018-11-12 10:13:39 -0800560 var installDir string
561 if ctx.ModuleName() == "framework-res" {
562 // framework-res.apk is installed as system/framework/framework-res.apk
563 installDir = "framework"
Jiyong Parkf7487312019-10-17 12:54:30 +0900564 } else if a.Privileged() {
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800565 installDir = filepath.Join("priv-app", a.installApkName)
Colin Cross43f08db2018-11-12 10:13:39 -0800566 } else {
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800567 installDir = filepath.Join("app", a.installApkName)
Colin Cross43f08db2018-11-12 10:13:39 -0800568 }
Colin Cross403cc152020-07-06 14:15:24 -0700569
570 return android.PathForModuleInstall(ctx, installDir, a.installApkName+".apk")
571}
572
Rico Wind98e7fa82023-11-27 09:44:03 +0100573func (a *AndroidApp) dexBuildActions(ctx android.ModuleContext) (android.Path, android.Path) {
Colin Cross403cc152020-07-06 14:15:24 -0700574 a.dexpreopter.installPath = a.installPath(ctx)
Ulya Trafimovich76b08522021-01-14 17:52:43 +0000575 a.dexpreopter.isApp = true
Liz Kammera7a64f32020-07-09 15:16:41 -0700576 if a.dexProperties.Uncompress_dex == nil {
David Srbeckye033cba2020-05-20 22:20:28 +0100577 // If the value was not force-set by the user, use reasonable default based on the module.
Liz Kammera7a64f32020-07-09 15:16:41 -0700578 a.dexProperties.Uncompress_dex = proptools.BoolPtr(a.shouldUncompressDex(ctx))
David Srbeckye033cba2020-05-20 22:20:28 +0100579 }
Liz Kammera7a64f32020-07-09 15:16:41 -0700580 a.dexpreopter.uncompressedDex = *a.dexProperties.Uncompress_dex
Colin Cross50ddcc42019-05-16 12:28:22 -0700581 a.dexpreopter.enforceUsesLibs = a.usesLibrary.enforceUsesLibraries()
Ulya Trafimovichb23d28c2020-10-08 12:53:58 +0100582 a.dexpreopter.classLoaderContexts = a.classLoaderContexts
Colin Cross50ddcc42019-05-16 12:28:22 -0700583 a.dexpreopter.manifestFile = a.mergedManifestFile
Colin Crossfa9bfcd2021-11-10 16:42:38 -0800584 a.dexpreopter.preventInstall = a.appProperties.PreventInstall
Colin Cross50ddcc42019-05-16 12:28:22 -0700585
Rico Wind98e7fa82023-11-27 09:44:03 +0100586 var packageResources = a.exportPackage
587
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800588 if ctx.ModuleName() != "framework-res" {
Rico Wind98e7fa82023-11-27 09:44:03 +0100589 if Bool(a.dexProperties.Optimize.Shrink_resources) {
590 protoFile := android.PathForModuleOut(ctx, packageResources.Base()+".proto.apk")
591 aapt2Convert(ctx, protoFile, packageResources, "proto")
592 a.dexer.resourcesInput = android.OptionalPathForPath(protoFile)
593 }
594
Colin Cross4eae06d2023-06-20 22:40:02 -0700595 var extraSrcJars android.Paths
596 var extraClasspathJars android.Paths
597 var extraCombinedJars android.Paths
598 if a.useResourceProcessorBusyBox() {
599 // When building an app with ResourceProcessorBusyBox enabled ResourceProcessorBusyBox has already
600 // created R.class files that provide IDs for resources in busybox/R.jar. Pass that file in the
601 // classpath when compiling everything else, and add it to the final classes jar.
602 extraClasspathJars = android.Paths{a.aapt.rJar}
603 extraCombinedJars = android.Paths{a.aapt.rJar}
604 } else {
605 // When building an app without ResourceProcessorBusyBox the aapt2 rule creates R.srcjar containing
606 // R.java files for the app's package and the packages from all transitive static android_library
607 // dependencies. Compile the srcjar alongside the rest of the sources.
608 extraSrcJars = android.Paths{a.aapt.aaptSrcJar}
609 }
610
611 a.Module.compile(ctx, extraSrcJars, extraClasspathJars, extraCombinedJars)
Rico Wind98e7fa82023-11-27 09:44:03 +0100612 if Bool(a.dexProperties.Optimize.Shrink_resources) {
613 binaryResources := android.PathForModuleOut(ctx, packageResources.Base()+".binary.out.apk")
614 aapt2Convert(ctx, binaryResources, a.dexer.resourcesOutput.Path(), "binary")
615 packageResources = binaryResources
616 }
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800617 }
Colin Cross30e076a2015-04-13 13:58:27 -0700618
Rico Wind98e7fa82023-11-27 09:44:03 +0100619 return a.dexJarFile.PathOrNil(), packageResources
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800620}
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800621
Sam Delmerico82602492022-06-10 17:05:42 +0000622func (a *AndroidApp) jniBuildActions(jniLibs []jniLib, prebuiltJniPackages android.Paths, ctx android.ModuleContext) android.WritablePath {
Colin Crossa4f08812018-10-02 22:03:40 -0700623 var jniJarFile android.WritablePath
Sam Delmerico82602492022-06-10 17:05:42 +0000624 if len(jniLibs) > 0 || len(prebuiltJniPackages) > 0 {
Colin Cross403cc152020-07-06 14:15:24 -0700625 a.jniLibs = jniLibs
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700626 if a.shouldEmbedJnis(ctx) {
Colin Crossa4f08812018-10-02 22:03:40 -0700627 jniJarFile = android.PathForModuleOut(ctx, "jnilibs.zip")
Colin Crossc68db4b2021-11-11 18:59:15 -0800628 a.installPathForJNISymbols = a.installPath(ctx)
Sam Delmerico82602492022-06-10 17:05:42 +0000629 TransformJniLibsToJar(ctx, jniJarFile, jniLibs, prebuiltJniPackages, a.useEmbeddedNativeLibs(ctx))
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700630 for _, jni := range jniLibs {
631 if jni.coverageFile.Valid() {
Jaewoong Jung46984ee2020-04-07 13:07:55 -0700632 // Only collect coverage for the first target arch if this is a multilib target.
633 // TODO(jungjw): Ideally, we want to collect both reports, but that would cause coverage
634 // data file path collisions since the current coverage file path format doesn't contain
635 // arch-related strings. This is fine for now though; the code coverage team doesn't use
636 // multi-arch targets such as test_suite_* for coverage collections yet.
637 //
638 // Work with the team to come up with a new format that handles multilib modules properly
639 // and change this.
640 if len(ctx.Config().Targets[android.Android]) == 1 ||
Jaewoong Jung642916f2020-10-09 17:25:15 -0700641 ctx.Config().AndroidFirstDeviceTarget.Arch.ArchType == jni.target.Arch.ArchType {
Jaewoong Jung46984ee2020-04-07 13:07:55 -0700642 a.jniCoverageOutputs = append(a.jniCoverageOutputs, jni.coverageFile.Path())
643 }
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700644 }
645 }
Colin Cross403cc152020-07-06 14:15:24 -0700646 a.embeddedJniLibs = true
Colin Crossa4f08812018-10-02 22:03:40 -0700647 }
648 }
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800649 return jniJarFile
650}
Colin Crossa4f08812018-10-02 22:03:40 -0700651
Colin Cross403cc152020-07-06 14:15:24 -0700652func (a *AndroidApp) JNISymbolsInstalls(installPath string) android.RuleBuilderInstalls {
653 var jniSymbols android.RuleBuilderInstalls
654 for _, jniLib := range a.jniLibs {
655 if jniLib.unstrippedFile != nil {
656 jniSymbols = append(jniSymbols, android.RuleBuilderInstall{
657 From: jniLib.unstrippedFile,
658 To: filepath.Join(installPath, targetToJniDir(jniLib.target), jniLib.unstrippedFile.Base()),
659 })
660 }
661 }
662 return jniSymbols
663}
664
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700665// Reads and prepends a main cert from the default cert dir if it hasn't been set already, i.e. it
666// isn't a cert module reference. Also checks and enforces system cert restriction if applicable.
Colin Crossbc2c8a72022-09-14 12:45:42 -0700667func processMainCert(m android.ModuleBase, certPropValue string, certificates []Certificate,
668 ctx android.ModuleContext) (mainCertificate Certificate, allCertificates []Certificate) {
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700669 if android.SrcIsModule(certPropValue) == "" {
670 var mainCert Certificate
671 if certPropValue != "" {
672 defaultDir := ctx.Config().DefaultAppCertificateDir(ctx)
673 mainCert = Certificate{
Colin Cross503c1d02020-01-28 14:00:53 -0800674 Pem: defaultDir.Join(ctx, certPropValue+".x509.pem"),
675 Key: defaultDir.Join(ctx, certPropValue+".pk8"),
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700676 }
677 } else {
678 pem, key := ctx.Config().DefaultAppCertificate(ctx)
Colin Cross503c1d02020-01-28 14:00:53 -0800679 mainCert = Certificate{
680 Pem: pem,
681 Key: key,
682 }
Colin Crossbd01e2a2018-10-04 15:21:03 -0700683 }
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700684 certificates = append([]Certificate{mainCert}, certificates...)
Colin Crossbd01e2a2018-10-04 15:21:03 -0700685 }
686
Colin Crossbc2c8a72022-09-14 12:45:42 -0700687 if len(certificates) > 0 {
688 mainCertificate = certificates[0]
689 } else {
690 // This can be reached with an empty certificate list if AllowMissingDependencies is set
691 // and the certificate property for this module is a module reference to a missing module.
692 if !ctx.Config().AllowMissingDependencies() && len(ctx.GetMissingDependencies()) > 0 {
693 panic("Should only get here if AllowMissingDependencies set and there are missing dependencies")
694 }
695 // Set a certificate to avoid panics later when accessing it.
696 mainCertificate = Certificate{
697 Key: android.PathForModuleOut(ctx, "missing.pk8"),
Colin Crossa54f4b52022-11-21 04:35:53 +0000698 Pem: android.PathForModuleOut(ctx, "missing.x509.pem"),
Colin Crossbc2c8a72022-09-14 12:45:42 -0700699 }
700 }
701
Zyan Wub7550aa2023-05-18 15:46:31 +0800702 if !m.Platform() {
703 certPath := mainCertificate.Pem.String()
704 systemCertPath := ctx.Config().DefaultAppCertificateDir(ctx).String()
705 if strings.HasPrefix(certPath, systemCertPath) {
706 enforceSystemCert := ctx.Config().EnforceSystemCertificate()
707 allowed := ctx.Config().EnforceSystemCertificateAllowList()
708
709 if enforceSystemCert && !inList(m.Name(), allowed) {
710 ctx.PropertyErrorf("certificate", "The module in product partition cannot be signed with certificate in system.")
711 }
712 }
713 }
714
Colin Crossbc2c8a72022-09-14 12:45:42 -0700715 return mainCertificate, certificates
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800716}
717
Jooyung Han39ee1192020-03-23 20:21:11 +0900718func (a *AndroidApp) InstallApkName() string {
719 return a.installApkName
720}
721
Sam Delmerico15809f82023-05-15 17:21:47 -0400722func (a *AndroidApp) createPrivappAllowlist(ctx android.ModuleContext) android.Path {
Andrei Onea580636b2022-08-17 16:53:46 +0000723 if a.appProperties.Privapp_allowlist == nil {
724 return nil
725 }
Sam Delmerico15809f82023-05-15 17:21:47 -0400726
727 isOverrideApp := a.GetOverriddenBy() != ""
728 if !isOverrideApp {
729 // if this is not an override, we don't need to rewrite the existing privapp allowlist
730 return android.PathForModuleSrc(ctx, *a.appProperties.Privapp_allowlist)
731 }
732
Andrei Onea580636b2022-08-17 16:53:46 +0000733 if a.overridableAppProperties.Package_name == nil {
734 ctx.PropertyErrorf("privapp_allowlist", "package_name must be set to use privapp_allowlist")
735 }
Sam Delmerico15809f82023-05-15 17:21:47 -0400736
Andrei Onea580636b2022-08-17 16:53:46 +0000737 packageName := *a.overridableAppProperties.Package_name
738 fileName := "privapp_allowlist_" + packageName + ".xml"
739 outPath := android.PathForModuleOut(ctx, fileName).OutputPath
740 ctx.Build(pctx, android.BuildParams{
741 Rule: modifyAllowlist,
742 Input: android.PathForModuleSrc(ctx, *a.appProperties.Privapp_allowlist),
743 Output: outPath,
744 Args: map[string]string{
745 "packageName": packageName,
746 },
747 })
748 return &outPath
749}
750
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800751func (a *AndroidApp) generateAndroidBuildActions(ctx android.ModuleContext) {
Colin Cross50ddcc42019-05-16 12:28:22 -0700752 var apkDeps android.Paths
753
Colin Cross56a83212020-09-15 18:30:11 -0700754 if !ctx.Provider(android.ApexInfoProvider).(android.ApexInfo).IsForPlatform() {
755 a.hideApexVariantFromMake = true
756 }
757
Jeongik Cha538c0d02019-07-11 15:54:27 +0900758 a.aapt.useEmbeddedNativeLibs = a.useEmbeddedNativeLibs(ctx)
759 a.aapt.useEmbeddedDex = Bool(a.appProperties.Use_embedded_dex)
760
Jihoon Kang1bfb6f22023-07-01 00:13:47 +0000761 // Unlike installApkName, a.stem should respect base module name for override_android_app.
762 // Therefore, use ctx.ModuleName() instead of a.Name().
763 a.stem = proptools.StringDefault(a.overridableDeviceProperties.Stem, ctx.ModuleName())
764
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800765 // Check if the install APK name needs to be overridden.
Jihoon Kang1bfb6f22023-07-01 00:13:47 +0000766 // Both android_app and override_android_app module are expected to possess
767 // its module bound apk path. However, override_android_app inherits ctx.ModuleName()
768 // from the base module. Therefore, use a.Name() which represents
769 // the module name for both android_app and override_android_app.
770 a.installApkName = ctx.DeviceConfig().OverridePackageNameFor(
771 proptools.StringDefault(a.overridableDeviceProperties.Stem, a.Name()))
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800772
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700773 if ctx.ModuleName() == "framework-res" {
774 // framework-res.apk is installed as system/framework/framework-res.apk
Jaewoong Jung0949f312019-09-11 10:25:18 -0700775 a.installDir = android.PathForModuleInstall(ctx, "framework")
Jiyong Parkf7487312019-10-17 12:54:30 +0900776 } else if a.Privileged() {
Jaewoong Jung0949f312019-09-11 10:25:18 -0700777 a.installDir = android.PathForModuleInstall(ctx, "priv-app", a.installApkName)
778 } else if ctx.InstallInTestcases() {
Jaewoong Jung326a9412019-11-21 10:41:00 -0800779 a.installDir = android.PathForModuleInstall(ctx, a.installApkName, ctx.DeviceConfig().DeviceArch())
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700780 } else {
Jaewoong Jung0949f312019-09-11 10:25:18 -0700781 a.installDir = android.PathForModuleInstall(ctx, "app", a.installApkName)
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700782 }
Jaewoong Jung7dd4ae22019-09-27 17:13:15 -0700783 a.onDeviceDir = android.InstallPathToOnDevicePath(ctx, a.installDir)
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700784
Ulya Trafimovichb23d28c2020-10-08 12:53:58 +0100785 a.classLoaderContexts = a.usesLibrary.classLoaderContextForUsesLibDeps(ctx)
Ulya Trafimovich18554242020-11-03 15:55:11 +0000786
Colin Cross61fb62e2022-06-23 10:46:28 -0700787 var noticeAssetPath android.WritablePath
788 if Bool(a.appProperties.Embed_notices) || ctx.Config().IsEnvTrue("ALWAYS_EMBED_NOTICES") {
789 // The rule to create the notice file can't be generated yet, as the final output path
790 // for the apk isn't known yet. Add the path where the notice file will be generated to the
791 // aapt rules now before calling aaptBuildActions, the rule to create the notice file will
792 // be generated later.
793 noticeAssetPath = android.PathForModuleOut(ctx, "NOTICE", "NOTICE.html.gz")
794 a.aapt.noticeFile = android.OptionalPathForPath(noticeAssetPath)
795 }
796
Harshit Mahajan8f202ad2023-01-09 20:45:55 +0000797 // For apps targeting latest target_sdk_version
798 if Bool(a.appProperties.Enforce_default_target_sdk_version) {
799 a.SetEnforceDefaultTargetSdkVersion(true)
800 }
801
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800802 // Process all building blocks, from AAPT to certificates.
803 a.aaptBuildActions(ctx)
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +0100804 // The decision to enforce <uses-library> checks is made before adding implicit SDK libraries.
805 a.usesLibrary.freezeEnforceUsesLibraries()
806
807 // Add implicit SDK libraries to <uses-library> list.
Ulya Trafimovichfc0f6e32021-08-12 16:16:11 +0100808 requiredUsesLibs, optionalUsesLibs := a.classLoaderContexts.UsesLibs()
809 for _, usesLib := range requiredUsesLibs {
810 a.usesLibrary.addLib(usesLib, false)
811 }
812 for _, usesLib := range optionalUsesLibs {
813 a.usesLibrary.addLib(usesLib, true)
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +0100814 }
815
816 // Check that the <uses-library> list is coherent with the manifest.
Colin Cross50ddcc42019-05-16 12:28:22 -0700817 if a.usesLibrary.enforceUsesLibraries() {
818 manifestCheckFile := a.usesLibrary.verifyUsesLibrariesManifest(ctx, a.mergedManifestFile)
819 apkDeps = append(apkDeps, manifestCheckFile)
820 }
821
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800822 a.proguardBuildActions(ctx)
823
Colin Cross014489c2020-06-02 20:09:13 -0700824 a.linter.mergedManifest = a.aapt.mergedManifestFile
825 a.linter.manifest = a.aapt.manifestPath
826 a.linter.resources = a.aapt.resourceFiles
Cole Faustdf1efd72023-12-08 12:27:24 -0800827 a.linter.compile_data = android.PathsForModuleSrc(ctx, a.appProperties.Compile_data)
Colin Crossc0efd1d2020-07-03 11:56:24 -0700828 a.linter.buildModuleReportZip = ctx.Config().UnbundledBuildApps()
Colin Cross014489c2020-06-02 20:09:13 -0700829
Rico Wind98e7fa82023-11-27 09:44:03 +0100830 dexJarFile, packageResources := a.dexBuildActions(ctx)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800831
Colin Crossbc2c8a72022-09-14 12:45:42 -0700832 jniLibs, prebuiltJniPackages, certificates := collectAppDeps(ctx, a, a.shouldEmbedJnis(ctx), !Bool(a.appProperties.Jni_uses_platform_apis))
Sam Delmerico82602492022-06-10 17:05:42 +0000833 jniJarFile := a.jniBuildActions(jniLibs, prebuiltJniPackages, ctx)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800834
835 if ctx.Failed() {
836 return
837 }
838
Colin Crossbc2c8a72022-09-14 12:45:42 -0700839 a.certificate, certificates = processMainCert(a.ModuleBase, a.getCertString(ctx), certificates, ctx)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800840
841 // Build a final signed app package.
Jaewoong Jung5a498812019-11-07 14:14:38 -0800842 packageFile := android.PathForModuleOut(ctx, a.installApkName+".apk")
Songchun Fan17d69e32020-03-24 20:32:24 -0700843 v4SigningRequested := Bool(a.Module.deviceProperties.V4_signature)
844 var v4SignatureFile android.WritablePath = nil
845 if v4SigningRequested {
846 v4SignatureFile = android.PathForModuleOut(ctx, a.installApkName+".apk.idsig")
847 }
Liz Kammere2b27f42020-05-07 13:24:05 -0700848 var lineageFile android.Path
849 if lineage := String(a.overridableAppProperties.Lineage); lineage != "" {
850 lineageFile = android.PathForModuleSrc(ctx, lineage)
851 }
Rupert Shuttleworth8eab8692021-11-03 10:39:39 -0400852 rotationMinSdkVersion := String(a.overridableAppProperties.RotationMinSdkVersion)
853
Rico Wind98e7fa82023-11-27 09:44:03 +0100854 CreateAndSignAppPackage(ctx, packageFile, packageResources, jniJarFile, dexJarFile, certificates, apkDeps, v4SignatureFile, lineageFile, rotationMinSdkVersion)
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800855 a.outputFile = packageFile
Songchun Fan17d69e32020-03-24 20:32:24 -0700856 if v4SigningRequested {
857 a.extraOutputFiles = append(a.extraOutputFiles, v4SignatureFile)
858 }
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800859
Colin Cross61fb62e2022-06-23 10:46:28 -0700860 if a.aapt.noticeFile.Valid() {
861 // Generating the notice file rule has to be here after a.outputFile is known.
Bob Badoureef4c1c2022-05-16 12:20:04 -0700862 noticeFile := android.PathForModuleOut(ctx, "NOTICE.html.gz")
Bob Badourc6ec9fb2022-06-08 15:59:35 -0700863 android.BuildNoticeHtmlOutputFromLicenseMetadata(
864 ctx, noticeFile, "", "",
865 []string{
866 a.installDir.String() + "/",
867 android.PathForModuleInstall(ctx).String() + "/",
868 a.outputFile.String(),
869 })
Bob Badoureef4c1c2022-05-16 12:20:04 -0700870 builder := android.NewRuleBuilder(pctx, ctx)
871 builder.Command().Text("cp").
872 Input(noticeFile).
873 Output(noticeAssetPath)
874 builder.Build("notice_dir", "Building notice dir")
Bob Badoureef4c1c2022-05-16 12:20:04 -0700875 }
876
Colin Crosse560c4a2019-03-19 16:03:11 -0700877 for _, split := range a.aapt.splits {
878 // Sign the split APKs
Jaewoong Jung5a498812019-11-07 14:14:38 -0800879 packageFile := android.PathForModuleOut(ctx, a.installApkName+"_"+split.suffix+".apk")
Songchun Fan17d69e32020-03-24 20:32:24 -0700880 if v4SigningRequested {
881 v4SignatureFile = android.PathForModuleOut(ctx, a.installApkName+"_"+split.suffix+".apk.idsig")
882 }
Rico Wind98e7fa82023-11-27 09:44:03 +0100883 CreateAndSignAppPackage(ctx, packageFile, split.path, nil, nil, certificates, apkDeps, v4SignatureFile, lineageFile, rotationMinSdkVersion)
Colin Crosse560c4a2019-03-19 16:03:11 -0700884 a.extraOutputFiles = append(a.extraOutputFiles, packageFile)
Songchun Fan17d69e32020-03-24 20:32:24 -0700885 if v4SigningRequested {
886 a.extraOutputFiles = append(a.extraOutputFiles, v4SignatureFile)
887 }
Colin Crosse560c4a2019-03-19 16:03:11 -0700888 }
889
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800890 // Build an app bundle.
Colin Crossf6237212018-10-29 23:14:58 -0700891 bundleFile := android.PathForModuleOut(ctx, "base.zip")
892 BuildBundleModule(ctx, bundleFile, a.exportPackage, jniJarFile, dexJarFile)
893 a.bundleFile = bundleFile
894
Andrei Onea580636b2022-08-17 16:53:46 +0000895 allowlist := a.createPrivappAllowlist(ctx)
896 if allowlist != nil {
897 a.privAppAllowlist = android.OptionalPathForPath(allowlist)
898 }
899
Colin Cross56a83212020-09-15 18:30:11 -0700900 apexInfo := ctx.Provider(android.ApexInfoProvider).(android.ApexInfo)
901
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800902 // Install the app package.
Andrei Onea580636b2022-08-17 16:53:46 +0000903 shouldInstallAppPackage := (Bool(a.Module.properties.Installable) || ctx.Host()) && apexInfo.IsForPlatform() && !a.appProperties.PreventInstall
904 if shouldInstallAppPackage {
Sam Delmericob1daccd2023-05-25 14:45:30 -0400905 if a.privAppAllowlist.Valid() {
Anton Hansson0e486a42023-06-01 16:38:35 +0000906 allowlistInstallPath := android.PathForModuleInstall(ctx, "etc", "permissions")
907 allowlistInstallFilename := a.installApkName + ".xml"
908 ctx.InstallFile(allowlistInstallPath, allowlistInstallFilename, a.privAppAllowlist.Path())
Sam Delmericob1daccd2023-05-25 14:45:30 -0400909 }
910
Colin Cross09ad3a62023-11-15 12:29:33 -0800911 var extraInstalledPaths android.InstallPaths
Jiyong Park8ba50f92019-11-13 15:01:01 +0900912 for _, extra := range a.extraOutputFiles {
Colin Cross1d0eb7a2021-11-03 14:08:20 -0700913 installed := ctx.InstallFile(a.installDir, extra.Base(), extra)
914 extraInstalledPaths = append(extraInstalledPaths, installed)
Jiyong Park8ba50f92019-11-13 15:01:01 +0900915 }
Colin Cross1d0eb7a2021-11-03 14:08:20 -0700916 ctx.InstallFile(a.installDir, a.outputFile.Base(), a.outputFile, extraInstalledPaths...)
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800917 }
Artur Satayev1111b842020-04-27 19:05:28 +0100918
919 a.buildAppDependencyInfo(ctx)
Colin Cross30e076a2015-04-13 13:58:27 -0700920}
921
Colin Crossc2d24052020-05-13 11:05:02 -0700922type appDepsInterface interface {
Jiyong Park92315372021-04-02 08:45:46 +0900923 SdkVersion(ctx android.EarlyModuleContext) android.SdkSpec
Spandan Das8c9ae7e2023-03-03 21:20:36 +0000924 MinSdkVersion(ctx android.EarlyModuleContext) android.ApiLevel
Colin Crossc2d24052020-05-13 11:05:02 -0700925 RequiresStableAPIs(ctx android.BaseModuleContext) bool
926}
927
928func collectAppDeps(ctx android.ModuleContext, app appDepsInterface,
929 shouldCollectRecursiveNativeDeps bool,
Sam Delmerico82602492022-06-10 17:05:42 +0000930 checkNativeSdkVersion bool) ([]jniLib, android.Paths, []Certificate) {
Colin Crossc2d24052020-05-13 11:05:02 -0700931
Colin Crossa4f08812018-10-02 22:03:40 -0700932 var jniLibs []jniLib
Sam Delmerico82602492022-06-10 17:05:42 +0000933 var prebuiltJniPackages android.Paths
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900934 var certificates []Certificate
Peter Collingbournead84f972019-12-17 16:46:18 -0800935 seenModulePaths := make(map[string]bool)
Colin Crossa4f08812018-10-02 22:03:40 -0700936
Colin Crossc2d24052020-05-13 11:05:02 -0700937 if checkNativeSdkVersion {
Jiyong Park92315372021-04-02 08:45:46 +0900938 checkNativeSdkVersion = app.SdkVersion(ctx).Specified() &&
939 app.SdkVersion(ctx).Kind != android.SdkCorePlatform && !app.RequiresStableAPIs(ctx)
Colin Crossc2d24052020-05-13 11:05:02 -0700940 }
941
Peter Collingbournead84f972019-12-17 16:46:18 -0800942 ctx.WalkDeps(func(module android.Module, parent android.Module) bool {
Colin Crossa4f08812018-10-02 22:03:40 -0700943 otherName := ctx.OtherModuleName(module)
944 tag := ctx.OtherModuleDependencyTag(module)
945
Colin Crossf0913fb2020-07-29 12:59:39 -0700946 if IsJniDepTag(tag) || cc.IsSharedDepTag(tag) {
Ivan Lozano7f67c2a2022-06-27 16:00:26 -0400947 if dep, ok := module.(cc.LinkableInterface); ok {
Colin Cross95f1ca02020-10-29 20:47:22 -0700948 if dep.IsNdk(ctx.Config()) || dep.IsStubs() {
Peter Collingbournead84f972019-12-17 16:46:18 -0800949 return false
950 }
951
Colin Crossa4f08812018-10-02 22:03:40 -0700952 lib := dep.OutputFile()
953 if lib.Valid() {
Cole Faust64cb7c92021-09-14 17:32:49 -0700954 path := lib.Path()
955 if seenModulePaths[path.String()] {
956 return false
957 }
958 seenModulePaths[path.String()] = true
959
960 if checkNativeSdkVersion && dep.SdkVersion() == "" {
961 ctx.PropertyErrorf("jni_libs", "JNI dependency %q uses platform APIs, but this module does not",
962 otherName)
963 }
964
Colin Crossa4f08812018-10-02 22:03:40 -0700965 jniLibs = append(jniLibs, jniLib{
Colin Cross403cc152020-07-06 14:15:24 -0700966 name: ctx.OtherModuleName(module),
967 path: path,
968 target: module.Target(),
969 coverageFile: dep.CoverageOutputFile(),
970 unstrippedFile: dep.UnstrippedOutputFile(),
Jihoon Kangf78a8902022-09-01 22:47:07 +0000971 partition: dep.Partition(),
Colin Crossa4f08812018-10-02 22:03:40 -0700972 })
Colin Crossdd5261c2022-12-19 12:26:43 -0800973 } else if ctx.Config().AllowMissingDependencies() {
974 ctx.AddMissingDependencies([]string{otherName})
Colin Crossa4f08812018-10-02 22:03:40 -0700975 } else {
976 ctx.ModuleErrorf("dependency %q missing output file", otherName)
977 }
978 } else {
979 ctx.ModuleErrorf("jni_libs dependency %q must be a cc library", otherName)
Colin Crossa4f08812018-10-02 22:03:40 -0700980 }
Peter Collingbournead84f972019-12-17 16:46:18 -0800981
982 return shouldCollectRecursiveNativeDeps
983 }
984
Sam Delmerico82602492022-06-10 17:05:42 +0000985 if info, ok := ctx.OtherModuleProvider(module, JniPackageProvider).(JniPackageInfo); ok {
986 prebuiltJniPackages = append(prebuiltJniPackages, info.JniPackages...)
987 }
988
Peter Collingbournead84f972019-12-17 16:46:18 -0800989 if tag == certificateTag {
Colin Crossbd01e2a2018-10-04 15:21:03 -0700990 if dep, ok := module.(*AndroidAppCertificate); ok {
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900991 certificates = append(certificates, dep.Certificate)
Colin Crossbd01e2a2018-10-04 15:21:03 -0700992 } else {
993 ctx.ModuleErrorf("certificate dependency %q must be an android_app_certificate module", otherName)
994 }
Colin Crossa4f08812018-10-02 22:03:40 -0700995 }
Peter Collingbournead84f972019-12-17 16:46:18 -0800996
997 return false
Colin Crossa4f08812018-10-02 22:03:40 -0700998 })
999
Sam Delmerico82602492022-06-10 17:05:42 +00001000 return jniLibs, prebuiltJniPackages, certificates
Colin Crossa4f08812018-10-02 22:03:40 -07001001}
1002
Jooyung Han749dc692020-04-15 11:03:39 +09001003func (a *AndroidApp) WalkPayloadDeps(ctx android.ModuleContext, do android.PayloadDepsCallback) {
Artur Satayev1111b842020-04-27 19:05:28 +01001004 ctx.WalkDeps(func(child, parent android.Module) bool {
1005 isExternal := !a.DepIsInSameApex(ctx, child)
1006 if am, ok := child.(android.ApexModule); ok {
Jooyung Han749dc692020-04-15 11:03:39 +09001007 if !do(ctx, parent, am, isExternal) {
1008 return false
1009 }
Artur Satayev1111b842020-04-27 19:05:28 +01001010 }
1011 return !isExternal
1012 })
1013}
1014
1015func (a *AndroidApp) buildAppDependencyInfo(ctx android.ModuleContext) {
1016 if ctx.Host() {
1017 return
1018 }
1019
1020 depsInfo := android.DepNameToDepInfoMap{}
Jooyung Han749dc692020-04-15 11:03:39 +09001021 a.WalkPayloadDeps(ctx, func(ctx android.ModuleContext, from blueprint.Module, to android.ApexModule, externalDep bool) bool {
Artur Satayev1111b842020-04-27 19:05:28 +01001022 depName := to.Name()
Artur Satayev533b98c2021-03-11 18:03:42 +00001023
1024 // Skip dependencies that are only available to APEXes; they are developed with updatability
1025 // in mind and don't need manual approval.
1026 if to.(android.ApexModule).NotAvailableForPlatform() {
1027 return true
1028 }
1029
Artur Satayev1111b842020-04-27 19:05:28 +01001030 if info, exist := depsInfo[depName]; exist {
1031 info.From = append(info.From, from.Name())
1032 info.IsExternal = info.IsExternal && externalDep
1033 depsInfo[depName] = info
1034 } else {
1035 toMinSdkVersion := "(no version)"
Jiyong Park92315372021-04-02 08:45:46 +09001036 if m, ok := to.(interface {
Spandan Das8c9ae7e2023-03-03 21:20:36 +00001037 MinSdkVersion(ctx android.EarlyModuleContext) android.ApiLevel
Jiyong Park92315372021-04-02 08:45:46 +09001038 }); ok {
Spandan Das8c9ae7e2023-03-03 21:20:36 +00001039 if v := m.MinSdkVersion(ctx); !v.IsNone() {
1040 toMinSdkVersion = v.String()
Artur Satayev1111b842020-04-27 19:05:28 +01001041 }
Jiyong Park92315372021-04-02 08:45:46 +09001042 } else if m, ok := to.(interface{ MinSdkVersion() string }); ok {
1043 // TODO(b/175678607) eliminate the use of MinSdkVersion returning
1044 // string
1045 if v := m.MinSdkVersion(); v != "" {
Jiyong Parkf1691d22021-03-29 20:11:58 +09001046 toMinSdkVersion = v
1047 }
Artur Satayev1111b842020-04-27 19:05:28 +01001048 }
1049 depsInfo[depName] = android.ApexModuleDepInfo{
1050 To: depName,
1051 From: []string{from.Name()},
1052 IsExternal: externalDep,
1053 MinSdkVersion: toMinSdkVersion,
1054 }
1055 }
Jooyung Han749dc692020-04-15 11:03:39 +09001056 return true
Artur Satayev1111b842020-04-27 19:05:28 +01001057 })
1058
Jiyong Park92315372021-04-02 08:45:46 +09001059 a.ApexBundleDepsInfo.BuildDepsInfoLists(ctx, a.MinSdkVersion(ctx).String(), depsInfo)
Artur Satayev1111b842020-04-27 19:05:28 +01001060}
1061
Harshit Mahajan5b8b7302022-06-10 11:24:05 +00001062func (a *AndroidApp) enforceDefaultTargetSdkVersion() bool {
1063 return a.appProperties.EnforceDefaultTargetSdkVersion
1064}
1065
1066func (a *AndroidApp) SetEnforceDefaultTargetSdkVersion(val bool) {
1067 a.appProperties.EnforceDefaultTargetSdkVersion = val
1068}
1069
Artur Satayev849f8442020-04-28 14:57:42 +01001070func (a *AndroidApp) Updatable() bool {
Colin Cross56a83212020-09-15 18:30:11 -07001071 return Bool(a.appProperties.Updatable)
Artur Satayev849f8442020-04-28 14:57:42 +01001072}
1073
Spandan Das42e89502022-05-06 22:12:55 +00001074func (a *AndroidApp) SetUpdatable(val bool) {
1075 a.appProperties.Updatable = &val
1076}
1077
Colin Cross0ea8ba82019-06-06 14:33:29 -07001078func (a *AndroidApp) getCertString(ctx android.BaseModuleContext) string {
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001079 certificate, overridden := ctx.DeviceConfig().OverrideCertificateFor(ctx.ModuleName())
1080 if overridden {
Jaewoong Jungacb6db32019-02-28 16:22:30 +00001081 return ":" + certificate
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001082 }
Jaewoong Jung525443a2019-02-28 15:35:54 -08001083 return String(a.overridableAppProperties.Certificate)
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001084}
1085
Jiyong Park0f80c182020-01-31 02:49:53 +09001086func (a *AndroidApp) DepIsInSameApex(ctx android.BaseModuleContext, dep android.Module) bool {
1087 if IsJniDepTag(ctx.OtherModuleDependencyTag(dep)) {
1088 return true
1089 }
1090 return a.Library.DepIsInSameApex(ctx, dep)
1091}
1092
Jiyong Parkb7c639e2019-08-19 14:56:02 +09001093// For OutputFileProducer interface
1094func (a *AndroidApp) OutputFiles(tag string) (android.Paths, error) {
1095 switch tag {
Jared Duke34b080d2023-03-30 16:40:24 -07001096 // In some instances, it can be useful to reference the aapt-generated flags from another
1097 // target, e.g., system server implements services declared in the framework-res manifest.
1098 case ".aapt.proguardOptionsFile":
1099 return []android.Path{a.proguardOptionsFile}, nil
Jiyong Parkb7c639e2019-08-19 14:56:02 +09001100 case ".aapt.srcjar":
Colin Crossf3b7bad2023-08-02 15:49:00 -07001101 if a.aaptSrcJar != nil {
1102 return []android.Path{a.aaptSrcJar}, nil
1103 }
1104 case ".aapt.jar":
1105 if a.rJar != nil {
1106 return []android.Path{a.rJar}, nil
1107 }
Anton Hansson092aca42020-08-13 19:37:22 +01001108 case ".export-package.apk":
1109 return []android.Path{a.exportPackage}, nil
Inseob Kim34dc4cd2023-11-07 13:37:14 +09001110 case ".manifest.xml":
1111 return []android.Path{a.aapt.manifestPath}, nil
Jiyong Parkb7c639e2019-08-19 14:56:02 +09001112 }
1113 return a.Library.OutputFiles(tag)
1114}
1115
Jiyong Parkf7487312019-10-17 12:54:30 +09001116func (a *AndroidApp) Privileged() bool {
1117 return Bool(a.appProperties.Privileged)
1118}
1119
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001120func (a *AndroidApp) IsNativeCoverageNeeded(ctx android.BaseModuleContext) bool {
Colin Cross1a6acd42020-06-16 17:51:46 -07001121 return ctx.Device() && ctx.DeviceConfig().NativeCoverageEnabled()
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001122}
1123
Ivan Lozanod7586b62021-04-01 09:49:36 -04001124func (a *AndroidApp) SetPreventInstall() {
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001125 a.appProperties.PreventInstall = true
1126}
1127
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001128func (a *AndroidApp) MarkAsCoverageVariant(coverage bool) {
1129 a.appProperties.IsCoverageVariant = coverage
1130}
1131
Ivan Lozanoa0cd8f92020-04-09 09:56:02 -04001132func (a *AndroidApp) EnableCoverageIfNeeded() {}
1133
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001134var _ cc.Coverage = (*AndroidApp)(nil)
1135
Colin Cross95b53b82023-10-17 13:21:02 -07001136func (a *AndroidApp) IDEInfo(dpInfo *android.IdeInfo) {
1137 a.Library.IDEInfo(dpInfo)
1138 a.aapt.IDEInfo(dpInfo)
1139}
1140
Inseob Kim34dc4cd2023-11-07 13:37:14 +09001141func (a *AndroidApp) productCharacteristicsRROPackageName() string {
1142 return proptools.String(a.appProperties.ProductCharacteristicsRROPackageName)
1143}
1144
1145func (a *AndroidApp) productCharacteristicsRROManifestModuleName() string {
1146 return proptools.String(a.appProperties.ProductCharacteristicsRROManifestModuleName)
1147}
1148
Colin Cross1b16b0e2019-02-12 14:41:32 -08001149// android_app compiles sources and Android resources into an Android application package `.apk` file.
Colin Cross36242852017-06-23 15:06:31 -07001150func AndroidAppFactory() android.Module {
Colin Cross30e076a2015-04-13 13:58:27 -07001151 module := &AndroidApp{}
1152
Liz Kammera7a64f32020-07-09 15:16:41 -07001153 module.Module.dexProperties.Optimize.EnabledByDefault = true
1154 module.Module.dexProperties.Optimize.Shrink = proptools.BoolPtr(true)
Jared Dukeaa88b3d2023-08-29 17:07:20 +00001155 module.Module.dexProperties.Optimize.Proguard_compatibility = proptools.BoolPtr(false)
Colin Cross66dbc0b2017-12-28 12:23:20 -08001156
Colin Crossae5caf52018-05-22 11:11:52 -07001157 module.Module.properties.Instrument = true
Paul Duffin0038a8d2022-05-03 00:28:40 +00001158 module.Module.properties.Supports_static_instrumentation = true
Colin Cross9ae1b922018-06-26 17:59:05 -07001159 module.Module.properties.Installable = proptools.BoolPtr(true)
Colin Crossae5caf52018-05-22 11:11:52 -07001160
Colin Crossce6734e2020-06-15 16:09:53 -07001161 module.addHostAndDeviceProperties()
Colin Cross36242852017-06-23 15:06:31 -07001162 module.AddProperties(
Colin Crossa97c5d32018-03-28 14:58:31 -07001163 &module.aaptProperties,
Jaewoong Jung525443a2019-02-28 15:35:54 -08001164 &module.appProperties,
Ulya Trafimovich21a73752020-09-01 17:33:48 +01001165 &module.overridableAppProperties)
Colin Cross36242852017-06-23 15:06:31 -07001166
Ulya Trafimovich22890c42021-01-05 12:04:17 +00001167 module.usesLibrary.enforce = true
1168
Colin Crossa4f08812018-10-02 22:03:40 -07001169 android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
1170 android.InitDefaultableModule(module)
zhidou198f5892022-02-17 02:33:12 +00001171 android.InitOverridableModule(module, &module.overridableAppProperties.Overrides)
Jiyong Park52cd06f2019-11-11 10:14:32 +09001172 android.InitApexModule(module)
Colin Crossa4f08812018-10-02 22:03:40 -07001173
Inseob Kim34dc4cd2023-11-07 13:37:14 +09001174 android.AddLoadHook(module, func(ctx android.LoadHookContext) {
1175 a := ctx.Module().(*AndroidApp)
1176
1177 characteristics := ctx.Config().ProductAAPTCharacteristics()
1178 if characteristics == "default" || characteristics == "" {
1179 module.appProperties.Generate_product_characteristics_rro = nil
1180 // no need to create RRO
1181 return
1182 }
1183
1184 if !proptools.Bool(module.appProperties.Generate_product_characteristics_rro) {
1185 return
1186 }
1187
1188 rroPackageName := a.Name() + "__" + strings.ReplaceAll(characteristics, ",", "_") + "__auto_generated_characteristics_rro"
1189 rroManifestName := rroPackageName + "_manifest"
1190
1191 a.appProperties.ProductCharacteristicsRROPackageName = proptools.StringPtr(rroPackageName)
1192 a.appProperties.ProductCharacteristicsRROManifestModuleName = proptools.StringPtr(rroManifestName)
1193
1194 rroManifestProperties := struct {
1195 Name *string
1196 Tools []string
1197 Out []string
1198 Srcs []string
1199 Cmd *string
1200 }{
1201 Name: proptools.StringPtr(rroManifestName),
1202 Tools: []string{"characteristics_rro_generator"},
1203 Out: []string{"AndroidManifest.xml"},
1204 Srcs: []string{":" + a.Name() + "{.manifest.xml}"},
1205 Cmd: proptools.StringPtr("$(location characteristics_rro_generator) $(in) $(out)"),
1206 }
1207 ctx.CreateModule(genrule.GenRuleFactory, &rroManifestProperties)
1208
1209 rroProperties := struct {
1210 Name *string
1211 Filter_product *string
1212 Aaptflags []string
1213 Manifest *string
1214 Resource_dirs []string
1215 }{
1216 Name: proptools.StringPtr(rroPackageName),
1217 Filter_product: proptools.StringPtr(characteristics),
1218 Aaptflags: []string{"--auto-add-overlay"},
1219 Manifest: proptools.StringPtr(":" + rroManifestName),
1220 Resource_dirs: a.aaptProperties.Resource_dirs,
1221 }
1222 ctx.CreateModule(RuntimeResourceOverlayFactory, &rroProperties)
1223 })
1224
Colin Cross36242852017-06-23 15:06:31 -07001225 return module
Colin Cross30e076a2015-04-13 13:58:27 -07001226}
Colin Crossae5caf52018-05-22 11:11:52 -07001227
Alix96ea88452023-08-31 15:48:23 +00001228// A dictionary of values to be overridden in the manifest.
1229type Manifest_values struct {
1230 // Overrides the value of package_name in the manifest
1231 ApplicationId *string
1232}
1233
Colin Crossae5caf52018-05-22 11:11:52 -07001234type appTestProperties struct {
Liz Kammer6b0c5522020-04-28 16:10:55 -07001235 // The name of the android_app module that the tests will run against.
Colin Crossae5caf52018-05-22 11:11:52 -07001236 Instrumentation_for *string
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001237
Seth Moorec6f4b532023-02-02 13:22:26 -08001238 // If specified, the instrumentation target package name in the manifest is overwritten by it.
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001239 Instrumentation_target_package *string
Seth Moorec6f4b532023-02-02 13:22:26 -08001240
1241 // If specified, the mainline module package name in the test config is overwritten by it.
1242 Mainline_package_name *string
Alix96ea88452023-08-31 15:48:23 +00001243
1244 Manifest_values Manifest_values
Colin Crossae5caf52018-05-22 11:11:52 -07001245}
1246
1247type AndroidTest struct {
1248 AndroidApp
1249
1250 appTestProperties appTestProperties
1251
1252 testProperties testProperties
Colin Cross303e21f2018-08-07 16:49:25 -07001253
Dan Shi95d19422020-08-15 12:24:26 -07001254 testConfig android.Path
1255 extraTestConfigs android.Paths
1256 data android.Paths
Colin Crossae5caf52018-05-22 11:11:52 -07001257}
1258
Jaewoong Jung0949f312019-09-11 10:25:18 -07001259func (a *AndroidTest) InstallInTestcases() bool {
1260 return true
1261}
1262
Spandan Das9f7ae7f2022-07-25 00:34:18 +00001263type androidTestApp interface {
1264 includedInTestSuite(searchPrefix string) bool
1265}
1266
1267func (a *AndroidTest) includedInTestSuite(searchPrefix string) bool {
1268 return android.PrefixInList(a.testProperties.Test_suites, searchPrefix)
1269}
1270
1271func (a *AndroidTestHelperApp) includedInTestSuite(searchPrefix string) bool {
1272 return android.PrefixInList(a.appTestHelperAppProperties.Test_suites, searchPrefix)
1273}
1274
Colin Crossae5caf52018-05-22 11:11:52 -07001275func (a *AndroidTest) GenerateAndroidBuildActions(ctx android.ModuleContext) {
easoncylee5bcff5d2020-04-30 14:57:06 +08001276 var configs []tradefed.Config
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001277 if a.appTestProperties.Instrumentation_target_package != nil {
1278 a.additionalAaptFlags = append(a.additionalAaptFlags,
1279 "--rename-instrumentation-target-package "+*a.appTestProperties.Instrumentation_target_package)
1280 } else if a.appTestProperties.Instrumentation_for != nil {
1281 // Check if the instrumentation target package is overridden.
Jaewoong Jung4102e5d2019-02-27 16:26:28 -08001282 manifestPackageName, overridden := ctx.DeviceConfig().OverrideManifestPackageNameFor(*a.appTestProperties.Instrumentation_for)
1283 if overridden {
1284 a.additionalAaptFlags = append(a.additionalAaptFlags, "--rename-instrumentation-target-package "+manifestPackageName)
1285 }
1286 }
Alix96ea88452023-08-31 15:48:23 +00001287 applicationId := a.appTestProperties.Manifest_values.ApplicationId
1288 if applicationId != nil {
1289 if a.overridableAppProperties.Package_name != nil {
1290 ctx.PropertyErrorf("manifest_values.applicationId", "property is not supported when property package_name is set.")
1291 }
1292 a.aapt.manifestValues.applicationId = *applicationId
1293 }
Colin Crossae5caf52018-05-22 11:11:52 -07001294 a.generateAndroidBuildActions(ctx)
Colin Cross303e21f2018-08-07 16:49:25 -07001295
easoncylee5bcff5d2020-04-30 14:57:06 +08001296 for _, module := range a.testProperties.Test_mainline_modules {
1297 configs = append(configs, tradefed.Option{Name: "config-descriptor:metadata", Key: "mainline-param", Value: module})
1298 }
1299
Jaewoong Jung39982342020-01-14 10:27:18 -08001300 testConfig := tradefed.AutoGenInstrumentationTestConfig(ctx, a.testProperties.Test_config,
easoncylee5bcff5d2020-04-30 14:57:06 +08001301 a.testProperties.Test_config_template, a.manifestPath, a.testProperties.Test_suites, a.testProperties.Auto_gen_config, configs)
Jaewoong Jung39982342020-01-14 10:27:18 -08001302 a.testConfig = a.FixTestConfig(ctx, testConfig)
Dan Shi95d19422020-08-15 12:24:26 -07001303 a.extraTestConfigs = android.PathsForModuleSrc(ctx, a.testProperties.Test_options.Extra_test_configs)
Colin Cross8a497952019-03-05 22:25:09 -08001304 a.data = android.PathsForModuleSrc(ctx, a.testProperties.Data)
Aditya Choudhary9b593522023-10-06 19:54:58 +00001305 ctx.SetProvider(testing.TestModuleProviderKey, testing.TestModuleProviderData{})
Colin Cross303e21f2018-08-07 16:49:25 -07001306}
1307
Jaewoong Jung39982342020-01-14 10:27:18 -08001308func (a *AndroidTest) FixTestConfig(ctx android.ModuleContext, testConfig android.Path) android.Path {
1309 if testConfig == nil {
1310 return nil
1311 }
1312
1313 fixedConfig := android.PathForModuleOut(ctx, "test_config_fixer", "AndroidTest.xml")
Colin Crossf1a035e2020-11-16 17:32:30 -08001314 rule := android.NewRuleBuilder(pctx, ctx)
1315 command := rule.Command().BuiltTool("test_config_fixer").Input(testConfig).Output(fixedConfig)
Jaewoong Jung39982342020-01-14 10:27:18 -08001316 fixNeeded := false
1317
Jooyung Han29e2f6d2022-01-08 12:13:59 +09001318 // Auto-generated test config uses `ModuleName` as the APK name. So fix it if it is not the case.
Jaewoong Jung39982342020-01-14 10:27:18 -08001319 if ctx.ModuleName() != a.installApkName {
1320 fixNeeded = true
1321 command.FlagWithArg("--test-file-name ", a.installApkName+".apk")
1322 }
1323
1324 if a.overridableAppProperties.Package_name != nil {
1325 fixNeeded = true
1326 command.FlagWithInput("--manifest ", a.manifestPath).
1327 FlagWithArg("--package-name ", *a.overridableAppProperties.Package_name)
1328 }
1329
Seth Moorec6f4b532023-02-02 13:22:26 -08001330 if a.appTestProperties.Mainline_package_name != nil {
1331 fixNeeded = true
1332 command.FlagWithArg("--mainline-package-name ", *a.appTestProperties.Mainline_package_name)
1333 }
1334
Jaewoong Jung39982342020-01-14 10:27:18 -08001335 if fixNeeded {
Colin Crossf1a035e2020-11-16 17:32:30 -08001336 rule.Build("fix_test_config", "fix test config")
Jaewoong Jung39982342020-01-14 10:27:18 -08001337 return fixedConfig
1338 }
1339 return testConfig
1340}
1341
Colin Cross303e21f2018-08-07 16:49:25 -07001342func (a *AndroidTest) DepsMutator(ctx android.BottomUpMutatorContext) {
Colin Cross303e21f2018-08-07 16:49:25 -07001343 a.AndroidApp.DepsMutator(ctx)
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001344}
1345
1346func (a *AndroidTest) OverridablePropertiesDepsMutator(ctx android.BottomUpMutatorContext) {
1347 a.AndroidApp.OverridablePropertiesDepsMutator(ctx)
Colin Cross4b964c02018-10-15 16:18:06 -07001348 if a.appTestProperties.Instrumentation_for != nil {
1349 // The android_app dependency listed in instrumentation_for needs to be added to the classpath for javac,
1350 // but not added to the aapt2 link includes like a normal android_app or android_library dependency, so
1351 // use instrumentationForTag instead of libTag.
1352 ctx.AddVariationDependencies(nil, instrumentationForTag, String(a.appTestProperties.Instrumentation_for))
1353 }
Colin Crossae5caf52018-05-22 11:11:52 -07001354}
1355
Colin Cross1b16b0e2019-02-12 14:41:32 -08001356// android_test compiles test sources and Android resources into an Android application package `.apk` file and
1357// creates an `AndroidTest.xml` file to allow running the test with `atest` or a `TEST_MAPPING` file.
Colin Crossae5caf52018-05-22 11:11:52 -07001358func AndroidTestFactory() android.Module {
1359 module := &AndroidTest{}
1360
Jared Duke63a3da92022-06-02 19:11:14 +00001361 module.Module.dexProperties.Optimize.EnabledByDefault = false
Colin Cross5067db92018-09-17 16:46:35 -07001362
1363 module.Module.properties.Instrument = true
Paul Duffin0038a8d2022-05-03 00:28:40 +00001364 module.Module.properties.Supports_static_instrumentation = true
Colin Cross9ae1b922018-06-26 17:59:05 -07001365 module.Module.properties.Installable = proptools.BoolPtr(true)
Colin Crosse4246ab2019-02-05 21:55:21 -08001366 module.appProperties.Use_embedded_native_libs = proptools.BoolPtr(true)
Colin Cross47fa9d32019-03-26 10:51:39 -07001367 module.appProperties.AlwaysPackageNativeLibs = true
Colin Cross43f08db2018-11-12 10:13:39 -08001368 module.Module.dexpreopter.isTest = true
Cole Faustd57e8b22022-08-11 11:59:04 -07001369 module.Module.linter.properties.Lint.Test = proptools.BoolPtr(true)
Colin Crossae5caf52018-05-22 11:11:52 -07001370
Colin Crossce6734e2020-06-15 16:09:53 -07001371 module.addHostAndDeviceProperties()
Colin Crossae5caf52018-05-22 11:11:52 -07001372 module.AddProperties(
Colin Crossae5caf52018-05-22 11:11:52 -07001373 &module.aaptProperties,
1374 &module.appProperties,
Dan Willemsenf5531d22018-07-16 17:21:19 -07001375 &module.appTestProperties,
Jaewoong Jung525443a2019-02-28 15:35:54 -08001376 &module.overridableAppProperties,
Dan Willemsenf5531d22018-07-16 17:21:19 -07001377 &module.testProperties)
Colin Crossae5caf52018-05-22 11:11:52 -07001378
Colin Crossa4f08812018-10-02 22:03:40 -07001379 android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
1380 android.InitDefaultableModule(module)
zhidou198f5892022-02-17 02:33:12 +00001381 android.InitOverridableModule(module, &module.overridableAppProperties.Overrides)
Jingwen Chene12c0832023-08-25 09:00:16 +00001382
Colin Crossae5caf52018-05-22 11:11:52 -07001383 return module
1384}
Colin Crossbd01e2a2018-10-04 15:21:03 -07001385
Colin Cross252fc6f2018-10-04 15:22:03 -07001386type appTestHelperAppProperties struct {
1387 // list of compatibility suites (for example "cts", "vts") that the module should be
1388 // installed into.
1389 Test_suites []string `android:"arch_variant"`
Dan Shi6ffaaa82019-09-26 11:41:36 -07001390
1391 // Flag to indicate whether or not to create test config automatically. If AndroidTest.xml
1392 // doesn't exist next to the Android.bp, this attribute doesn't need to be set to true
1393 // explicitly.
1394 Auto_gen_config *bool
Colin Crosscfb0f5e2021-09-24 15:47:17 -07001395
1396 // Install the test into a folder named for the module in all test suites.
1397 Per_testcase_directory *bool
Alix96ea88452023-08-31 15:48:23 +00001398
1399 Manifest_values Manifest_values
Colin Cross252fc6f2018-10-04 15:22:03 -07001400}
1401
1402type AndroidTestHelperApp struct {
1403 AndroidApp
1404
1405 appTestHelperAppProperties appTestHelperAppProperties
1406}
1407
Jaewoong Jung326a9412019-11-21 10:41:00 -08001408func (a *AndroidTestHelperApp) InstallInTestcases() bool {
1409 return true
1410}
1411
Colin Cross1b16b0e2019-02-12 14:41:32 -08001412// android_test_helper_app compiles sources and Android resources into an Android application package `.apk` file that
1413// will be used by tests, but does not produce an `AndroidTest.xml` file so the module will not be run directly as a
1414// test.
Colin Cross252fc6f2018-10-04 15:22:03 -07001415func AndroidTestHelperAppFactory() android.Module {
1416 module := &AndroidTestHelperApp{}
1417
Jared Duke63a3da92022-06-02 19:11:14 +00001418 // TODO(b/192032291): Disable by default after auditing downstream usage.
Liz Kammera7a64f32020-07-09 15:16:41 -07001419 module.Module.dexProperties.Optimize.EnabledByDefault = true
Colin Cross252fc6f2018-10-04 15:22:03 -07001420
1421 module.Module.properties.Installable = proptools.BoolPtr(true)
Colin Crosse4246ab2019-02-05 21:55:21 -08001422 module.appProperties.Use_embedded_native_libs = proptools.BoolPtr(true)
Colin Cross47fa9d32019-03-26 10:51:39 -07001423 module.appProperties.AlwaysPackageNativeLibs = true
Colin Cross43f08db2018-11-12 10:13:39 -08001424 module.Module.dexpreopter.isTest = true
Cole Faustd57e8b22022-08-11 11:59:04 -07001425 module.Module.linter.properties.Lint.Test = proptools.BoolPtr(true)
Colin Cross252fc6f2018-10-04 15:22:03 -07001426
Colin Crossce6734e2020-06-15 16:09:53 -07001427 module.addHostAndDeviceProperties()
Colin Cross252fc6f2018-10-04 15:22:03 -07001428 module.AddProperties(
Colin Cross252fc6f2018-10-04 15:22:03 -07001429 &module.aaptProperties,
1430 &module.appProperties,
Jaewoong Jung525443a2019-02-28 15:35:54 -08001431 &module.appTestHelperAppProperties,
Ulya Trafimovich21a73752020-09-01 17:33:48 +01001432 &module.overridableAppProperties)
Colin Cross252fc6f2018-10-04 15:22:03 -07001433
1434 android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
1435 android.InitDefaultableModule(module)
Anton Hansson3d2b6b42020-01-10 15:06:01 +00001436 android.InitApexModule(module)
Colin Cross252fc6f2018-10-04 15:22:03 -07001437 return module
1438}
1439
Colin Crossbd01e2a2018-10-04 15:21:03 -07001440type AndroidAppCertificate struct {
1441 android.ModuleBase
Rupert Shuttleworth6e4950a2021-07-27 01:34:59 -04001442
Colin Crossbd01e2a2018-10-04 15:21:03 -07001443 properties AndroidAppCertificateProperties
Jiyong Parkc00cbd92018-10-30 21:20:05 +09001444 Certificate Certificate
Colin Crossbd01e2a2018-10-04 15:21:03 -07001445}
1446
1447type AndroidAppCertificateProperties struct {
1448 // Name of the certificate files. Extensions .x509.pem and .pk8 will be added to the name.
1449 Certificate *string
1450}
1451
Colin Cross1b16b0e2019-02-12 14:41:32 -08001452// android_app_certificate modules can be referenced by the certificates property of android_app modules to select
1453// the signing key.
Colin Crossbd01e2a2018-10-04 15:21:03 -07001454func AndroidAppCertificateFactory() android.Module {
1455 module := &AndroidAppCertificate{}
1456 module.AddProperties(&module.properties)
1457 android.InitAndroidModule(module)
1458 return module
1459}
1460
Colin Crossbd01e2a2018-10-04 15:21:03 -07001461func (c *AndroidAppCertificate) GenerateAndroidBuildActions(ctx android.ModuleContext) {
1462 cert := String(c.properties.Certificate)
Jiyong Parkc00cbd92018-10-30 21:20:05 +09001463 c.Certificate = Certificate{
Colin Cross503c1d02020-01-28 14:00:53 -08001464 Pem: android.PathForModuleSrc(ctx, cert+".x509.pem"),
1465 Key: android.PathForModuleSrc(ctx, cert+".pk8"),
Colin Crossbd01e2a2018-10-04 15:21:03 -07001466 }
1467}
Jaewoong Jung525443a2019-02-28 15:35:54 -08001468
1469type OverrideAndroidApp struct {
1470 android.ModuleBase
1471 android.OverrideModuleBase
1472}
1473
Sasha Smundak613cbb12020-06-05 10:27:23 -07001474func (i *OverrideAndroidApp) GenerateAndroidBuildActions(_ android.ModuleContext) {
Jaewoong Jung525443a2019-02-28 15:35:54 -08001475 // All the overrides happen in the base module.
1476 // TODO(jungjw): Check the base module type.
1477}
1478
1479// override_android_app is used to create an android_app module based on another android_app by overriding
1480// some of its properties.
1481func OverrideAndroidAppModuleFactory() android.Module {
1482 m := &OverrideAndroidApp{}
Jooyung Han01d80d82022-01-08 12:16:32 +09001483 m.AddProperties(
1484 &OverridableDeviceProperties{},
1485 &overridableAppProperties{},
1486 )
Jaewoong Jung525443a2019-02-28 15:35:54 -08001487
Jaewoong Jungb639a6a2019-05-10 15:16:29 -07001488 android.InitAndroidMultiTargetsArchModule(m, android.DeviceSupported, android.MultilibCommon)
Jaewoong Jung525443a2019-02-28 15:35:54 -08001489 android.InitOverrideModule(m)
1490 return m
1491}
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001492
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001493type OverrideAndroidTest struct {
1494 android.ModuleBase
1495 android.OverrideModuleBase
1496}
1497
Sasha Smundak613cbb12020-06-05 10:27:23 -07001498func (i *OverrideAndroidTest) GenerateAndroidBuildActions(_ android.ModuleContext) {
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001499 // All the overrides happen in the base module.
1500 // TODO(jungjw): Check the base module type.
1501}
1502
1503// override_android_test is used to create an android_app module based on another android_test by overriding
1504// some of its properties.
1505func OverrideAndroidTestModuleFactory() android.Module {
1506 m := &OverrideAndroidTest{}
1507 m.AddProperties(&overridableAppProperties{})
1508 m.AddProperties(&appTestProperties{})
1509
1510 android.InitAndroidMultiTargetsArchModule(m, android.DeviceSupported, android.MultilibCommon)
1511 android.InitOverrideModule(m)
1512 return m
1513}
1514
Colin Cross50ddcc42019-05-16 12:28:22 -07001515type UsesLibraryProperties struct {
1516 // A list of shared library modules that will be listed in uses-library tags in the AndroidManifest.xml file.
1517 Uses_libs []string
1518
1519 // A list of shared library modules that will be listed in uses-library tags in the AndroidManifest.xml file with
1520 // required=false.
1521 Optional_uses_libs []string
1522
1523 // If true, the list of uses_libs and optional_uses_libs modules must match the AndroidManifest.xml file. Defaults
1524 // to true if either uses_libs or optional_uses_libs is set. Will unconditionally default to true in the future.
1525 Enforce_uses_libs *bool
Ulya Trafimovich21a73752020-09-01 17:33:48 +01001526
Ulya Trafimovich54027b52020-09-09 14:08:23 +01001527 // Optional name of the <uses-library> provided by this module. This is needed for non-SDK
1528 // libraries, because SDK ones are automatically picked up by Soong. The <uses-library> name
1529 // normally is the same as the module name, but there are exceptions.
1530 Provides_uses_lib *string
Paul Duffin06530572022-02-03 17:54:15 +00001531
1532 // A list of shared library names to exclude from the classpath of the APK. Adding a library here
1533 // will prevent it from being used when precompiling the APK and prevent it from being implicitly
1534 // added to the APK's manifest's <uses-library> elements.
1535 //
1536 // Care must be taken when using this as it could result in runtime errors if the APK actually
1537 // uses classes provided by the library and which are not provided in any other way.
1538 //
1539 // This is primarily intended for use by various CTS tests that check the runtime handling of the
1540 // android.test.base shared library (and related libraries) but which depend on some common
1541 // libraries that depend on the android.test.base library. Without this those tests will end up
1542 // with a <uses-library android:name="android.test.base"/> in their manifest which would either
1543 // render the tests worthless (as they would be testing the wrong behavior), or would break the
1544 // test altogether by providing access to classes that the tests were not expecting. Those tests
1545 // provide the android.test.base statically and use jarjar to rename them so they do not collide
1546 // with the classes provided by the android.test.base library.
1547 Exclude_uses_libs []string
Colin Cross50ddcc42019-05-16 12:28:22 -07001548}
1549
1550// usesLibrary provides properties and helper functions for AndroidApp and AndroidAppImport to verify that the
1551// <uses-library> tags that end up in the manifest of an APK match the ones known to the build system through the
1552// uses_libs and optional_uses_libs properties. The build system's values are used by dexpreopt to preopt apps
1553// with knowledge of their shared libraries.
1554type usesLibrary struct {
1555 usesLibraryProperties UsesLibraryProperties
Ulya Trafimovich22890c42021-01-05 12:04:17 +00001556
1557 // Whether to enforce verify_uses_library check.
1558 enforce bool
Colin Cross50ddcc42019-05-16 12:28:22 -07001559}
1560
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +01001561func (u *usesLibrary) addLib(lib string, optional bool) {
1562 if !android.InList(lib, u.usesLibraryProperties.Uses_libs) && !android.InList(lib, u.usesLibraryProperties.Optional_uses_libs) {
1563 if optional {
1564 u.usesLibraryProperties.Optional_uses_libs = append(u.usesLibraryProperties.Optional_uses_libs, lib)
1565 } else {
1566 u.usesLibraryProperties.Uses_libs = append(u.usesLibraryProperties.Uses_libs, lib)
1567 }
1568 }
1569}
1570
Colin Cross4a80a152022-12-21 21:51:52 -08001571func (u *usesLibrary) deps(ctx android.BottomUpMutatorContext, addCompatDeps bool) {
Jeongik Cha4b073cd2021-06-08 11:35:00 +09001572 if !ctx.Config().UnbundledBuild() || ctx.Config().UnbundledBuildImage() {
Ulya Trafimovichf5d91bb2022-05-04 12:00:02 +01001573 ctx.AddVariationDependencies(nil, usesLibReqTag, u.usesLibraryProperties.Uses_libs...)
1574 ctx.AddVariationDependencies(nil, usesLibOptTag, u.presentOptionalUsesLibs(ctx)...)
Colin Cross4a80a152022-12-21 21:51:52 -08001575 // Only add these extra dependencies if the module is an app that depends on framework
1576 // libs. This avoids creating a cyclic dependency:
Paul Duffin250e6192019-06-07 10:44:37 +01001577 // e.g. framework-res -> org.apache.http.legacy -> ... -> framework-res.
Colin Cross4a80a152022-12-21 21:51:52 -08001578 if addCompatDeps {
Ulya Trafimovichf5d91bb2022-05-04 12:00:02 +01001579 // Dexpreopt needs paths to the dex jars of these libraries in order to construct
1580 // class loader context for dex2oat. Add them as a dependency with a special tag.
1581 ctx.AddVariationDependencies(nil, usesLibCompat29ReqTag, dexpreopt.CompatUsesLibs29...)
1582 ctx.AddVariationDependencies(nil, usesLibCompat28OptTag, dexpreopt.OptionalCompatUsesLibs28...)
1583 ctx.AddVariationDependencies(nil, usesLibCompat30OptTag, dexpreopt.OptionalCompatUsesLibs30...)
Colin Cross3245b2c2019-06-07 13:18:09 -07001584 }
Sam Delmerico9f9c0a22022-11-29 11:19:37 -05001585 } else {
1586 ctx.AddVariationDependencies(nil, r8LibraryJarTag, u.usesLibraryProperties.Uses_libs...)
1587 ctx.AddVariationDependencies(nil, r8LibraryJarTag, u.presentOptionalUsesLibs(ctx)...)
Colin Cross50ddcc42019-05-16 12:28:22 -07001588 }
1589}
1590
Jiakai Zhang4f65a032023-06-01 15:16:58 +01001591// presentOptionalUsesLibs returns optional_uses_libs after filtering out libraries that don't exist in the source tree.
Colin Cross50ddcc42019-05-16 12:28:22 -07001592func (u *usesLibrary) presentOptionalUsesLibs(ctx android.BaseModuleContext) []string {
Jiakai Zhang4f65a032023-06-01 15:16:58 +01001593 optionalUsesLibs := android.FilterListPred(u.usesLibraryProperties.Optional_uses_libs, func(s string) bool {
1594 exists := ctx.OtherModuleExists(s)
Jiakai Zhang48203e32023-06-02 23:42:21 +01001595 if !exists && !android.InList(ctx.ModuleName(), ctx.Config().BuildWarningBadOptionalUsesLibsAllowlist()) {
Jiakai Zhang4f65a032023-06-01 15:16:58 +01001596 fmt.Printf("Warning: Module '%s' depends on non-existing optional_uses_libs '%s'\n", ctx.ModuleName(), s)
1597 }
1598 return exists
1599 })
Colin Cross50ddcc42019-05-16 12:28:22 -07001600 return optionalUsesLibs
1601}
1602
Ulya Trafimovicheea486a2021-02-26 11:38:21 +00001603// Helper function to replace string in a list.
1604func replaceInList(list []string, oldstr, newstr string) {
1605 for i, str := range list {
1606 if str == oldstr {
1607 list[i] = newstr
1608 }
1609 }
1610}
1611
Ulya Trafimovich24446712021-07-15 14:59:34 +01001612// Returns a map of module names of shared library dependencies to the paths to their dex jars on
1613// host and on device.
Ulya Trafimovich8cbc5d22020-11-03 15:15:46 +00001614func (u *usesLibrary) classLoaderContextForUsesLibDeps(ctx android.ModuleContext) dexpreopt.ClassLoaderContextMap {
1615 clcMap := make(dexpreopt.ClassLoaderContextMap)
Ulya Trafimovich24446712021-07-15 14:59:34 +01001616
1617 // Skip when UnbundledBuild() is true, but UnbundledBuildImage() is false. With
1618 // UnbundledBuildImage() it is necessary to generate dexpreopt.config for post-dexpreopting.
1619 if ctx.Config().UnbundledBuild() && !ctx.Config().UnbundledBuildImage() {
1620 return clcMap
Colin Cross50ddcc42019-05-16 12:28:22 -07001621 }
1622
Ulya Trafimovich24446712021-07-15 14:59:34 +01001623 ctx.VisitDirectDeps(func(m android.Module) {
1624 tag, isUsesLibTag := ctx.OtherModuleDependencyTag(m).(usesLibraryDependencyTag)
1625 if !isUsesLibTag {
1626 return
1627 }
1628
Ulya Trafimoviche14f80b2021-07-15 15:05:48 +01001629 dep := android.RemoveOptionalPrebuiltPrefix(ctx.OtherModuleName(m))
Ulya Trafimovich24446712021-07-15 14:59:34 +01001630
Ulya Trafimovich840efb62021-07-15 14:34:40 +01001631 // Skip stub libraries. A dependency on the implementation library has been added earlier,
1632 // so it will be added to CLC, but the stub shouldn't be. Stub libraries can be distingushed
1633 // from implementation libraries by their name, which is different as it has a suffix.
1634 if comp, ok := m.(SdkLibraryComponentDependency); ok {
1635 if impl := comp.OptionalSdkLibraryImplementation(); impl != nil && *impl != dep {
1636 return
1637 }
1638 }
1639
Ulya Trafimovich24446712021-07-15 14:59:34 +01001640 if lib, ok := m.(UsesLibraryDependency); ok {
Ulya Trafimoviche14f80b2021-07-15 15:05:48 +01001641 libName := dep
Ulya Trafimovich24446712021-07-15 14:59:34 +01001642 if ulib, ok := m.(ProvidesUsesLib); ok && ulib.ProvidesUsesLib() != nil {
Ulya Trafimoviche14f80b2021-07-15 15:05:48 +01001643 libName = *ulib.ProvidesUsesLib()
Ulya Trafimovich24446712021-07-15 14:59:34 +01001644 // Replace module name with library name in `uses_libs`/`optional_uses_libs` in
1645 // order to pass verify_uses_libraries check (which compares these properties
1646 // against library names written in the manifest).
1647 replaceInList(u.usesLibraryProperties.Uses_libs, dep, libName)
1648 replaceInList(u.usesLibraryProperties.Optional_uses_libs, dep, libName)
1649 }
Ulya Trafimovichf5d91bb2022-05-04 12:00:02 +01001650 clcMap.AddContext(ctx, tag.sdkVersion, libName, tag.optional,
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01001651 lib.DexJarBuildPath().PathOrNil(), lib.DexJarInstallPath(),
1652 lib.ClassLoaderContexts())
Ulya Trafimovich24446712021-07-15 14:59:34 +01001653 } else if ctx.Config().AllowMissingDependencies() {
1654 ctx.AddMissingDependencies([]string{dep})
1655 } else {
1656 ctx.ModuleErrorf("module %q in uses_libs or optional_uses_libs must be a java library", dep)
1657 }
1658 })
Ulya Trafimovich8cbc5d22020-11-03 15:15:46 +00001659 return clcMap
Colin Cross50ddcc42019-05-16 12:28:22 -07001660}
1661
1662// enforceUsesLibraries returns true of <uses-library> tags should be checked against uses_libs and optional_uses_libs
1663// properties. Defaults to true if either of uses_libs or optional_uses_libs is specified. Will default to true
1664// unconditionally in the future.
1665func (u *usesLibrary) enforceUsesLibraries() bool {
1666 defaultEnforceUsesLibs := len(u.usesLibraryProperties.Uses_libs) > 0 ||
1667 len(u.usesLibraryProperties.Optional_uses_libs) > 0
Ulya Trafimovich22890c42021-01-05 12:04:17 +00001668 return BoolDefault(u.usesLibraryProperties.Enforce_uses_libs, u.enforce || defaultEnforceUsesLibs)
Colin Cross50ddcc42019-05-16 12:28:22 -07001669}
1670
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +01001671// Freeze the value of `enforce_uses_libs` based on the current values of `uses_libs` and `optional_uses_libs`.
1672func (u *usesLibrary) freezeEnforceUsesLibraries() {
1673 enforce := u.enforceUsesLibraries()
1674 u.usesLibraryProperties.Enforce_uses_libs = &enforce
1675}
1676
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001677// verifyUsesLibraries checks the <uses-library> tags in the manifest against the ones specified
1678// in the `uses_libs`/`optional_uses_libs` properties. The input can be either an XML manifest, or
1679// an APK with the manifest embedded in it (manifest_check will know which one it is by the file
1680// extension: APKs are supposed to end with '.apk').
1681func (u *usesLibrary) verifyUsesLibraries(ctx android.ModuleContext, inputFile android.Path,
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001682 outputFile android.WritablePath) android.Path {
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001683
Ulya Trafimovich8c35fcf2021-02-17 16:23:28 +00001684 statusFile := dexpreopt.UsesLibrariesStatusFile(ctx)
Colin Cross50ddcc42019-05-16 12:28:22 -07001685
Ulya Trafimovich6e55ef12021-03-04 12:37:50 +00001686 // Disable verify_uses_libraries check if dexpreopt is globally disabled. Without dexpreopt the
1687 // check is not necessary, and although it is good to have, it is difficult to maintain on
1688 // non-linux build platforms where dexpreopt is generally disabled (the check may fail due to
1689 // various unrelated reasons, such as a failure to get manifest from an APK).
Ulya Trafimovich39dd0a42021-03-29 14:57:34 +01001690 global := dexpreopt.GetGlobalConfig(ctx)
Jiakai Zhang23984422023-11-09 16:47:04 +00001691 if global.DisablePreopt || global.OnlyPreoptArtBootImage {
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001692 return inputFile
Ulya Trafimovich6e55ef12021-03-04 12:37:50 +00001693 }
1694
Colin Crossf1a035e2020-11-16 17:32:30 -08001695 rule := android.NewRuleBuilder(pctx, ctx)
1696 cmd := rule.Command().BuiltTool("manifest_check").
Colin Cross50ddcc42019-05-16 12:28:22 -07001697 Flag("--enforce-uses-libraries").
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001698 Input(inputFile).
Ulya Trafimovich8c35fcf2021-02-17 16:23:28 +00001699 FlagWithOutput("--enforce-uses-libraries-status ", statusFile).
Saeid Farivar Asanjanfd27c7c2022-08-08 20:21:26 +00001700 FlagWithInput("--aapt ", ctx.Config().HostToolPath(ctx, "aapt2"))
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001701
1702 if outputFile != nil {
1703 cmd.FlagWithOutput("-o ", outputFile)
1704 }
Colin Cross50ddcc42019-05-16 12:28:22 -07001705
Ulya Trafimovich8c35fcf2021-02-17 16:23:28 +00001706 if dexpreopt.GetGlobalConfig(ctx).RelaxUsesLibraryCheck {
1707 cmd.Flag("--enforce-uses-libraries-relax")
1708 }
1709
Colin Cross50ddcc42019-05-16 12:28:22 -07001710 for _, lib := range u.usesLibraryProperties.Uses_libs {
1711 cmd.FlagWithArg("--uses-library ", lib)
1712 }
1713
1714 for _, lib := range u.usesLibraryProperties.Optional_uses_libs {
1715 cmd.FlagWithArg("--optional-uses-library ", lib)
1716 }
1717
Colin Crossf1a035e2020-11-16 17:32:30 -08001718 rule.Build("verify_uses_libraries", "verify <uses-library>")
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001719 return outputFile
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001720}
Colin Cross50ddcc42019-05-16 12:28:22 -07001721
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001722// verifyUsesLibrariesManifest checks the <uses-library> tags in an AndroidManifest.xml against
1723// the build system and returns the path to a copy of the manifest.
1724func (u *usesLibrary) verifyUsesLibrariesManifest(ctx android.ModuleContext, manifest android.Path) android.Path {
1725 outputFile := android.PathForModuleOut(ctx, "manifest_check", "AndroidManifest.xml")
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001726 return u.verifyUsesLibraries(ctx, manifest, outputFile)
Colin Cross50ddcc42019-05-16 12:28:22 -07001727}
1728
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001729// verifyUsesLibrariesAPK checks the <uses-library> tags in the manifest of an APK against the build
1730// system and returns the path to a copy of the APK.
Cole Faust2f1da162023-04-17 15:06:56 -07001731func (u *usesLibrary) verifyUsesLibrariesAPK(ctx android.ModuleContext, apk android.Path) {
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001732 u.verifyUsesLibraries(ctx, apk, nil) // for APKs manifest_check does not write output file
Colin Cross50ddcc42019-05-16 12:28:22 -07001733}