blob: ce00974b3e11b8287acf2939be71aa4ef1db1d08 [file] [log] [blame]
Colin Cross30e076a2015-04-13 13:58:27 -07001// Copyright 2015 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
Jaewoong Jungf9b44652020-12-21 12:29:12 -080017// This file contains the module implementations for android_app, android_test, and some more
18// related module types, including their override variants.
Colin Cross30e076a2015-04-13 13:58:27 -070019
20import (
Jiakai Zhang4f65a032023-06-01 15:16:58 +010021 "fmt"
Jaewoong Junga5e5abc2019-04-26 14:31:50 -070022 "path/filepath"
Jaewoong Junga5e5abc2019-04-26 14:31:50 -070023 "strings"
Colin Cross30e076a2015-04-13 13:58:27 -070024
Colin Cross50ddcc42019-05-16 12:28:22 -070025 "github.com/google/blueprint"
26 "github.com/google/blueprint/proptools"
27
Colin Cross635c3b02016-05-18 15:37:25 -070028 "android/soong/android"
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -040029 "android/soong/bazel"
Colin Crossa4f08812018-10-02 22:03:40 -070030 "android/soong/cc"
Ulya Trafimovichd4bcea42020-06-03 14:57:22 +010031 "android/soong/dexpreopt"
Colin Cross303e21f2018-08-07 16:49:25 -070032 "android/soong/tradefed"
Colin Cross30e076a2015-04-13 13:58:27 -070033)
34
Colin Cross3bc7ffa2017-11-22 16:19:37 -080035func init() {
Paul Duffinf9b1da02019-12-18 19:51:55 +000036 RegisterAppBuildComponents(android.InitRegistrationContext)
Andrei Onea580636b2022-08-17 16:53:46 +000037 pctx.HostBinToolVariable("ModifyAllowlistCmd", "modify_permissions_allowlist")
Colin Cross3bc7ffa2017-11-22 16:19:37 -080038}
39
Andrei Onea580636b2022-08-17 16:53:46 +000040var (
41 modifyAllowlist = pctx.AndroidStaticRule("modifyAllowlist",
42 blueprint.RuleParams{
43 Command: "${ModifyAllowlistCmd} $in $packageName $out",
44 CommandDeps: []string{"${ModifyAllowlistCmd}"},
45 }, "packageName")
46)
47
Paul Duffinf9b1da02019-12-18 19:51:55 +000048func RegisterAppBuildComponents(ctx android.RegistrationContext) {
49 ctx.RegisterModuleType("android_app", AndroidAppFactory)
50 ctx.RegisterModuleType("android_test", AndroidTestFactory)
51 ctx.RegisterModuleType("android_test_helper_app", AndroidTestHelperAppFactory)
52 ctx.RegisterModuleType("android_app_certificate", AndroidAppCertificateFactory)
53 ctx.RegisterModuleType("override_android_app", OverrideAndroidAppModuleFactory)
54 ctx.RegisterModuleType("override_android_test", OverrideAndroidTestModuleFactory)
Paul Duffinf9b1da02019-12-18 19:51:55 +000055}
56
Colin Cross30e076a2015-04-13 13:58:27 -070057// AndroidManifest.xml merging
58// package splits
59
Colin Crossfabb6082018-02-20 17:22:23 -080060type appProperties struct {
Colin Crossbd01e2a2018-10-04 15:21:03 -070061 // Names of extra android_app_certificate modules to sign the apk with in the form ":module".
Colin Cross7d5136f2015-05-11 13:39:40 -070062 Additional_certificates []string
63
64 // If set, create package-export.apk, which other packages can
65 // use to get PRODUCT-agnostic resource data like IDs and type definitions.
Nan Zhangea568a42017-11-08 21:20:04 -080066 Export_package_resources *bool
Colin Cross7d5136f2015-05-11 13:39:40 -070067
Colin Cross16056062017-12-13 22:46:28 -080068 // Specifies that this app should be installed to the priv-app directory,
69 // where the system will grant it additional privileges not available to
70 // normal apps.
71 Privileged *bool
Colin Crossa97c5d32018-03-28 14:58:31 -070072
73 // list of resource labels to generate individual resource packages
74 Package_splits []string
Jason Monkd4122be2018-08-10 09:33:36 -040075
Colin Crossa4f08812018-10-02 22:03:40 -070076 // list of native libraries that will be provided in or alongside the resulting jar
77 Jni_libs []string `android:"arch_variant"`
78
Colin Cross7204cf02020-05-06 17:51:39 -070079 // if true, use JNI libraries that link against platform APIs even if this module sets
Colin Crossee87c602020-02-19 16:57:15 -080080 // sdk_version.
81 Jni_uses_platform_apis *bool
82
Colin Cross7204cf02020-05-06 17:51:39 -070083 // if true, use JNI libraries that link against SDK APIs even if this module does not set
84 // sdk_version.
85 Jni_uses_sdk_apis *bool
86
Jaewoong Jungbc625cd2019-05-06 15:48:44 -070087 // STL library to use for JNI libraries.
88 Stl *string `android:"arch_variant"`
89
Colin Crosse4246ab2019-02-05 21:55:21 -080090 // Store native libraries uncompressed in the APK and set the android:extractNativeLibs="false" manifest
91 // flag so that they are used from inside the APK at runtime. Defaults to true for android_test modules unless
Jiyong Park52cd06f2019-11-11 10:14:32 +090092 // sdk_version or min_sdk_version is set to a version that doesn't support it (<23), defaults to true for
93 // android_app modules that are embedded to APEXes, defaults to false for other module types where the native
94 // libraries are generally preinstalled outside the APK.
Colin Crosse4246ab2019-02-05 21:55:21 -080095 Use_embedded_native_libs *bool
Colin Cross46abdad2019-02-07 13:07:08 -080096
97 // Store dex files uncompressed in the APK and set the android:useEmbeddedDex="true" manifest attribute so that
98 // they are used from inside the APK at runtime.
99 Use_embedded_dex *bool
Colin Cross47fa9d32019-03-26 10:51:39 -0700100
101 // Forces native libraries to always be packaged into the APK,
102 // Use_embedded_native_libs still selects whether they are stored uncompressed and aligned or compressed.
103 // True for android_test* modules.
104 AlwaysPackageNativeLibs bool `blueprint:"mutated"`
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700105
106 // If set, find and merge all NOTICE files that this module and its dependencies have and store
107 // it in the APK as an asset.
108 Embed_notices *bool
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700109
110 // cc.Coverage related properties
111 PreventInstall bool `blueprint:"mutated"`
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700112 IsCoverageVariant bool `blueprint:"mutated"`
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100113
Harshit Mahajan5b8b7302022-06-10 11:24:05 +0000114 // It can be set to test the behaviour of default target sdk version.
115 // Only required when updatable: false. It is an error if updatable: true and this is false.
116 Enforce_default_target_sdk_version *bool
117
118 // If set, the targetSdkVersion for the target is set to the latest default API level.
119 // This would be by default false, unless updatable: true or
120 // enforce_default_target_sdk_version: true in which case this defaults to true.
121 EnforceDefaultTargetSdkVersion bool `blueprint:"mutated"`
122
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100123 // Whether this app is considered mainline updatable or not. When set to true, this will enforce
Artur Satayevf40fc852020-04-16 13:43:02 +0100124 // additional rules to make sure an app can safely be updated. Default is false.
125 // Prefer using other specific properties if build behaviour must be changed; avoid using this
126 // flag for anything but neverallow rules (unless the behaviour change is invisible to owners).
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100127 Updatable *bool
Andrei Onea580636b2022-08-17 16:53:46 +0000128
129 // Specifies the file that contains the allowlist for this app.
130 Privapp_allowlist *string `android:"path"`
Colin Cross7d5136f2015-05-11 13:39:40 -0700131}
132
Jaewoong Jung525443a2019-02-28 15:35:54 -0800133// android_app properties that can be overridden by override_android_app
134type overridableAppProperties struct {
135 // The name of a certificate in the default certificate directory, blank to use the default product certificate,
136 // or an android_app_certificate module name in the form ":module".
137 Certificate *string
Jaewoong Jung6f373f62019-03-13 10:13:24 -0700138
Jaewoong Jung1c1b6e62021-03-09 15:02:31 -0800139 // Name of the signing certificate lineage file or filegroup module.
140 Lineage *string `android:"path"`
Liz Kammere2b27f42020-05-07 13:24:05 -0700141
Rupert Shuttleworth8eab8692021-11-03 10:39:39 -0400142 // For overriding the --rotation-min-sdk-version property of apksig
143 RotationMinSdkVersion *string
144
Jaewoong Jung6f373f62019-03-13 10:13:24 -0700145 // the package name of this app. The package name in the manifest file is used if one was not given.
146 Package_name *string
Baligh Uddin5b16dfb2020-02-11 17:27:19 -0800147
148 // the logging parent of this app.
149 Logging_parent *string
Liz Kammer9f9fd022020-06-18 19:44:06 +0000150
151 // Whether to rename the package in resources to the override name rather than the base name. Defaults to true.
152 Rename_resources_package *bool
zhidou198f5892022-02-17 02:33:12 +0000153
154 // Names of modules to be overridden. Listed modules can only be other binaries
155 // (in Make or Soong).
156 // This does not completely prevent installation of the overridden binaries, but if both
157 // binaries would be installed by default (in PRODUCT_PACKAGES) the other binary will be removed
158 // from PRODUCT_PACKAGES.
159 Overrides []string
Jaewoong Jung525443a2019-02-28 15:35:54 -0800160}
161
Colin Cross30e076a2015-04-13 13:58:27 -0700162type AndroidApp struct {
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400163 android.BazelModuleBase
Colin Crossa97c5d32018-03-28 14:58:31 -0700164 Library
165 aapt
Jaewoong Jung525443a2019-02-28 15:35:54 -0800166 android.OverridableModuleBase
Colin Crossa97c5d32018-03-28 14:58:31 -0700167
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900168 certificate Certificate
Colin Cross30e076a2015-04-13 13:58:27 -0700169
Colin Crossfabb6082018-02-20 17:22:23 -0800170 appProperties appProperties
Colin Crossae5caf52018-05-22 11:11:52 -0700171
Jaewoong Jung525443a2019-02-28 15:35:54 -0800172 overridableAppProperties overridableAppProperties
173
Colin Cross403cc152020-07-06 14:15:24 -0700174 jniLibs []jniLib
175 installPathForJNISymbols android.Path
176 embeddedJniLibs bool
177 jniCoverageOutputs android.Paths
Colin Crossf6237212018-10-29 23:14:58 -0700178
179 bundleFile android.Path
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800180
181 // the install APK name is normally the same as the module name, but can be overridden with PRODUCT_PACKAGE_NAME_OVERRIDES.
182 installApkName string
Jaewoong Jung4102e5d2019-02-27 16:26:28 -0800183
Colin Cross70dda7e2019-10-01 22:05:35 -0700184 installDir android.InstallPath
Jaewoong Jung0949f312019-09-11 10:25:18 -0700185
Jaewoong Jung7dd4ae22019-09-27 17:13:15 -0700186 onDeviceDir string
187
Jaewoong Jung4102e5d2019-02-27 16:26:28 -0800188 additionalAaptFlags []string
Jaewoong Jung98772792019-07-01 17:15:13 -0700189
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900190 overriddenManifestPackageName string
Artur Satayev1111b842020-04-27 19:05:28 +0100191
192 android.ApexBundleDepsInfo
Matt Banda8c801262022-04-01 17:48:31 +0000193
194 javaApiUsedByOutputFile android.ModuleOutPath
Andrei Onea580636b2022-08-17 16:53:46 +0000195
196 privAppAllowlist android.OptionalPath
Colin Crosse1731a52017-12-14 11:22:55 -0800197}
198
Martin Stjernholm6d415272020-01-31 17:10:36 +0000199func (a *AndroidApp) IsInstallable() bool {
200 return Bool(a.properties.Installable)
201}
202
Colin Crossab8d1382023-07-14 17:23:41 +0000203func (a *AndroidApp) ResourcesNodeDepSet() *android.DepSet[*resourcesNode] {
204 return a.aapt.resourcesNodesDepSet
Colin Cross66f78822018-05-02 12:58:28 -0700205}
206
Sundong Ahne1f05aa2019-08-27 13:55:42 +0900207func (a *AndroidApp) OutputFile() android.Path {
208 return a.outputFile
209}
210
Colin Cross503c1d02020-01-28 14:00:53 -0800211func (a *AndroidApp) Certificate() Certificate {
212 return a.certificate
213}
214
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700215func (a *AndroidApp) JniCoverageOutputs() android.Paths {
216 return a.jniCoverageOutputs
217}
218
Andrei Onea580636b2022-08-17 16:53:46 +0000219func (a *AndroidApp) PrivAppAllowlist() android.OptionalPath {
220 return a.privAppAllowlist
221}
222
Colin Crossa97c5d32018-03-28 14:58:31 -0700223var _ AndroidLibraryDependency = (*AndroidApp)(nil)
224
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900225type Certificate struct {
Colin Cross503c1d02020-01-28 14:00:53 -0800226 Pem, Key android.Path
227 presigned bool
228}
229
Sasha Smundak18d98bc2020-05-27 16:36:07 -0700230var PresignedCertificate = Certificate{presigned: true}
Colin Cross503c1d02020-01-28 14:00:53 -0800231
232func (c Certificate) AndroidMkString() string {
233 if c.presigned {
234 return "PRESIGNED"
235 } else {
236 return c.Pem.String()
237 }
Colin Cross30e076a2015-04-13 13:58:27 -0700238}
239
Colin Cross46c9b8b2017-06-22 16:51:17 -0700240func (a *AndroidApp) DepsMutator(ctx android.BottomUpMutatorContext) {
241 a.Module.deps(ctx)
Colin Crossa4f08812018-10-02 22:03:40 -0700242
Jiyong Park92315372021-04-02 08:45:46 +0900243 if String(a.appProperties.Stl) == "c++_shared" && !a.SdkVersion(ctx).Specified() {
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700244 ctx.PropertyErrorf("stl", "sdk_version must be set in order to use c++_shared")
245 }
246
Jiyong Parkf1691d22021-03-29 20:11:58 +0900247 sdkDep := decodeSdkDep(ctx, android.SdkContext(a))
Paul Duffin250e6192019-06-07 10:44:37 +0100248 if sdkDep.hasFrameworkLibs() {
249 a.aapt.deps(ctx, sdkDep)
Colin Cross30e076a2015-04-13 13:58:27 -0700250 }
Colin Crossa4f08812018-10-02 22:03:40 -0700251
Jiyong Park92315372021-04-02 08:45:46 +0900252 usesSDK := a.SdkVersion(ctx).Specified() && a.SdkVersion(ctx).Kind != android.SdkCorePlatform
Colin Cross3c007702020-05-08 11:20:24 -0700253
254 if usesSDK && Bool(a.appProperties.Jni_uses_sdk_apis) {
255 ctx.PropertyErrorf("jni_uses_sdk_apis",
256 "can only be set for modules that do not set sdk_version")
257 } else if !usesSDK && Bool(a.appProperties.Jni_uses_platform_apis) {
258 ctx.PropertyErrorf("jni_uses_platform_apis",
259 "can only be set for modules that set sdk_version")
260 }
261
Colin Crossa4f08812018-10-02 22:03:40 -0700262 for _, jniTarget := range ctx.MultiTargets() {
Colin Cross0f7d2ef2019-10-16 11:03:10 -0700263 variation := append(jniTarget.Variations(),
264 blueprint.Variation{Mutator: "link", Variation: "shared"})
Colin Crossc511bc52020-04-07 16:50:32 +0000265
266 // If the app builds against an Android SDK use the SDK variant of JNI dependencies
267 // unless jni_uses_platform_apis is set.
Colin Crossc2d24052020-05-13 11:05:02 -0700268 // Don't require the SDK variant for apps that are shipped on vendor, etc., as they already
269 // have stable APIs through the VNDK.
270 if (usesSDK && !a.RequiresStableAPIs(ctx) &&
271 !Bool(a.appProperties.Jni_uses_platform_apis)) ||
Colin Cross7204cf02020-05-06 17:51:39 -0700272 Bool(a.appProperties.Jni_uses_sdk_apis) {
Colin Crossc511bc52020-04-07 16:50:32 +0000273 variation = append(variation, blueprint.Variation{Mutator: "sdk", Variation: "sdk"})
274 }
Colin Crossde78d132020-10-09 18:59:49 -0700275 ctx.AddFarVariationDependencies(variation, jniLibTag, a.appProperties.Jni_libs...)
Colin Crossa4f08812018-10-02 22:03:40 -0700276 }
Colin Cross50ddcc42019-05-16 12:28:22 -0700277
Paul Duffin250e6192019-06-07 10:44:37 +0100278 a.usesLibrary.deps(ctx, sdkDep.hasFrameworkLibs())
Jaewoong Jungb639a6a2019-05-10 15:16:29 -0700279}
Colin Crossbd01e2a2018-10-04 15:21:03 -0700280
Jaewoong Jungb639a6a2019-05-10 15:16:29 -0700281func (a *AndroidApp) OverridablePropertiesDepsMutator(ctx android.BottomUpMutatorContext) {
Jaewoong Jung2ad817c2019-01-18 14:27:16 -0800282 cert := android.SrcIsModule(a.getCertString(ctx))
Colin Crossbd01e2a2018-10-04 15:21:03 -0700283 if cert != "" {
284 ctx.AddDependency(ctx.Module(), certificateTag, cert)
285 }
286
Andrei Onea580636b2022-08-17 16:53:46 +0000287 if a.appProperties.Privapp_allowlist != nil && !Bool(a.appProperties.Privileged) {
Anton Hanssone3f31cf2023-06-03 08:53:47 +0000288 // There are a few uids that are explicitly considered privileged regardless of their
289 // app's location. Bluetooth is one such app. It should arguably be moved to priv-app,
290 // but for now, allow it not to be in priv-app.
291 privilegedBecauseOfUid := ctx.ModuleName() == "Bluetooth"
292 if !privilegedBecauseOfUid {
293 ctx.PropertyErrorf("privapp_allowlist", "privileged must be set in order to use privapp_allowlist (with a few exceptions)")
294 }
Andrei Onea580636b2022-08-17 16:53:46 +0000295 }
296
Colin Crossbd01e2a2018-10-04 15:21:03 -0700297 for _, cert := range a.appProperties.Additional_certificates {
298 cert = android.SrcIsModule(cert)
299 if cert != "" {
300 ctx.AddDependency(ctx.Module(), certificateTag, cert)
301 } else {
302 ctx.PropertyErrorf("additional_certificates",
303 `must be names of android_app_certificate modules in the form ":module"`)
304 }
305 }
Colin Cross30e076a2015-04-13 13:58:27 -0700306}
307
Jeongik Cha538c0d02019-07-11 15:54:27 +0900308func (a *AndroidTestHelperApp) GenerateAndroidBuildActions(ctx android.ModuleContext) {
309 a.generateAndroidBuildActions(ctx)
310}
311
Colin Cross46c9b8b2017-06-22 16:51:17 -0700312func (a *AndroidApp) GenerateAndroidBuildActions(ctx android.ModuleContext) {
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100313 a.checkAppSdkVersions(ctx)
Colin Crossae5caf52018-05-22 11:11:52 -0700314 a.generateAndroidBuildActions(ctx)
Matt Banda8c801262022-04-01 17:48:31 +0000315 a.generateJavaUsedByApex(ctx)
Colin Crossae5caf52018-05-22 11:11:52 -0700316}
317
Sam Delmerico0e0d96e2023-08-18 22:43:28 +0000318func (a *AndroidApp) MinSdkVersion(ctx android.EarlyModuleContext) android.ApiLevel {
319 defaultMinSdkVersion := a.Module.MinSdkVersion(ctx)
320 if proptools.Bool(a.appProperties.Updatable) {
321 overrideApiLevel := android.MinSdkVersionFromValue(ctx, ctx.DeviceConfig().ApexGlobalMinSdkVersionOverride())
322 if !overrideApiLevel.IsNone() && overrideApiLevel.CompareTo(defaultMinSdkVersion) > 0 {
323 return overrideApiLevel
324 }
325 }
326 return defaultMinSdkVersion
327}
328
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100329func (a *AndroidApp) checkAppSdkVersions(ctx android.ModuleContext) {
Artur Satayev849f8442020-04-28 14:57:42 +0100330 if a.Updatable() {
Jiyong Park92315372021-04-02 08:45:46 +0900331 if !a.SdkVersion(ctx).Stable() {
332 ctx.PropertyErrorf("sdk_version", "Updatable apps must use stable SDKs, found %v", a.SdkVersion(ctx))
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100333 }
Artur Satayevf40fc852020-04-16 13:43:02 +0100334 if String(a.deviceProperties.Min_sdk_version) == "" {
335 ctx.PropertyErrorf("updatable", "updatable apps must set min_sdk_version.")
336 }
Jooyung Han749dc692020-04-15 11:03:39 +0900337
Jiyong Park92315372021-04-02 08:45:46 +0900338 if minSdkVersion, err := a.MinSdkVersion(ctx).EffectiveVersion(ctx); err == nil {
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900339 a.checkJniLibsSdkVersion(ctx, minSdkVersion)
satayevb3fd4112021-12-02 13:59:35 +0000340 android.CheckMinSdkVersion(ctx, minSdkVersion, a.WalkPayloadDeps)
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900341 } else {
342 ctx.PropertyErrorf("min_sdk_version", "%s", err.Error())
343 }
Harshit Mahajan5b8b7302022-06-10 11:24:05 +0000344
345 if !BoolDefault(a.appProperties.Enforce_default_target_sdk_version, true) {
346 ctx.PropertyErrorf("enforce_default_target_sdk_version", "Updatable apps must enforce default target sdk version")
347 }
348 // TODO(b/227460469) after all the modules removes the target sdk version, throw an error if the target sdk version is explicitly set.
349 if a.deviceProperties.Target_sdk_version == nil {
350 a.SetEnforceDefaultTargetSdkVersion(true)
351 }
352 }
353
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100354 a.checkPlatformAPI(ctx)
355 a.checkSdkVersions(ctx)
356}
357
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900358// If an updatable APK sets min_sdk_version, min_sdk_vesion of JNI libs should match with it.
359// This check is enforced for "updatable" APKs (including APK-in-APEX).
Jiyong Park54105c42021-03-31 18:17:53 +0900360func (a *AndroidApp) checkJniLibsSdkVersion(ctx android.ModuleContext, minSdkVersion android.ApiLevel) {
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900361 // It's enough to check direct JNI deps' sdk_version because all transitive deps from JNI deps are checked in cc.checkLinkType()
362 ctx.VisitDirectDeps(func(m android.Module) {
363 if !IsJniDepTag(ctx.OtherModuleDependencyTag(m)) {
364 return
365 }
366 dep, _ := m.(*cc.Module)
Jooyung Han652d5b32020-05-20 17:12:13 +0900367 // The domain of cc.sdk_version is "current" and <number>
Jiyong Parkf1691d22021-03-29 20:11:58 +0900368 // We can rely on android.SdkSpec to convert it to <number> so that "current" is
369 // handled properly regardless of sdk finalization.
Spandan Das2e8c0442022-05-08 00:39:35 +0000370 jniSdkVersion, err := android.SdkSpecFrom(ctx, dep.MinSdkVersion()).EffectiveVersion(ctx)
Jiyong Park54105c42021-03-31 18:17:53 +0900371 if err != nil || minSdkVersion.LessThan(jniSdkVersion) {
Spandan Das2e8c0442022-05-08 00:39:35 +0000372 ctx.OtherModuleErrorf(dep, "min_sdk_version(%v) is higher than min_sdk_version(%v) of the containing android_app(%v)",
373 dep.MinSdkVersion(), minSdkVersion, ctx.ModuleName())
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900374 return
375 }
376
377 })
378}
379
Sasha Smundak6ad77252019-05-01 13:16:22 -0700380// Returns true if the native libraries should be stored in the APK uncompressed and the
Colin Crosse4246ab2019-02-05 21:55:21 -0800381// extractNativeLibs application flag should be set to false in the manifest.
Sasha Smundak6ad77252019-05-01 13:16:22 -0700382func (a *AndroidApp) useEmbeddedNativeLibs(ctx android.ModuleContext) bool {
Jiyong Park92315372021-04-02 08:45:46 +0900383 minSdkVersion, err := a.MinSdkVersion(ctx).EffectiveVersion(ctx)
Colin Crosse4246ab2019-02-05 21:55:21 -0800384 if err != nil {
Jiyong Park92315372021-04-02 08:45:46 +0900385 ctx.PropertyErrorf("min_sdk_version", "invalid value %q: %s", a.MinSdkVersion(ctx), err)
Colin Crosse4246ab2019-02-05 21:55:21 -0800386 }
387
Colin Cross56a83212020-09-15 18:30:11 -0700388 apexInfo := ctx.Provider(android.ApexInfoProvider).(android.ApexInfo)
Jiyong Park54105c42021-03-31 18:17:53 +0900389 return (minSdkVersion.FinalOrFutureInt() >= 23 && Bool(a.appProperties.Use_embedded_native_libs)) ||
Colin Cross56a83212020-09-15 18:30:11 -0700390 !apexInfo.IsForPlatform()
Colin Crosse4246ab2019-02-05 21:55:21 -0800391}
392
Colin Cross43f08db2018-11-12 10:13:39 -0800393// Returns whether this module should have the dex file stored uncompressed in the APK.
394func (a *AndroidApp) shouldUncompressDex(ctx android.ModuleContext) bool {
Colin Cross46abdad2019-02-07 13:07:08 -0800395 if Bool(a.appProperties.Use_embedded_dex) {
396 return true
397 }
398
Colin Cross53a87f52019-06-25 13:35:30 -0700399 // Uncompress dex in APKs of privileged apps (even for unbundled builds, they may
400 // be preinstalled as prebuilts).
Jiyong Parkf7487312019-10-17 12:54:30 +0900401 if ctx.Config().UncompressPrivAppDex() && a.Privileged() {
Nicolas Geoffrayfa6e9ec2019-02-12 13:12:16 +0000402 return true
403 }
404
Colin Cross53a87f52019-06-25 13:35:30 -0700405 if ctx.Config().UnbundledBuild() {
406 return false
407 }
408
Jaewoong Jungacf18d72019-05-02 14:55:29 -0700409 return shouldUncompressDex(ctx, &a.dexpreopter)
Colin Cross5a0dcd52018-10-05 14:20:06 -0700410}
411
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700412func (a *AndroidApp) shouldEmbedJnis(ctx android.BaseModuleContext) bool {
Colin Cross56a83212020-09-15 18:30:11 -0700413 apexInfo := ctx.Provider(android.ApexInfoProvider).(android.ApexInfo)
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700414 return ctx.Config().UnbundledBuild() || Bool(a.appProperties.Use_embedded_native_libs) ||
Colin Cross56a83212020-09-15 18:30:11 -0700415 !apexInfo.IsForPlatform() || a.appProperties.AlwaysPackageNativeLibs
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700416}
417
Liz Kammer9f9fd022020-06-18 19:44:06 +0000418func generateAaptRenamePackageFlags(packageName string, renameResourcesPackage bool) []string {
419 aaptFlags := []string{"--rename-manifest-package " + packageName}
420 if renameResourcesPackage {
421 // Required to rename the package name in the resources table.
422 aaptFlags = append(aaptFlags, "--rename-resources-package "+packageName)
423 }
424 return aaptFlags
425}
426
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900427func (a *AndroidApp) OverriddenManifestPackageName() string {
428 return a.overriddenManifestPackageName
429}
430
Liz Kammer9f9fd022020-06-18 19:44:06 +0000431func (a *AndroidApp) renameResourcesPackage() bool {
432 return proptools.BoolDefault(a.overridableAppProperties.Rename_resources_package, true)
433}
434
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800435func (a *AndroidApp) aaptBuildActions(ctx android.ModuleContext) {
Lorenzo Colittifa9b3f32021-03-30 10:38:26 +0900436 usePlatformAPI := proptools.Bool(a.Module.deviceProperties.Platform_apis)
Jiyong Park92315372021-04-02 08:45:46 +0900437 if ctx.Module().(android.SdkContext).SdkVersion(ctx).Kind == android.SdkModule {
Lorenzo Colittifa9b3f32021-03-30 10:38:26 +0900438 usePlatformAPI = true
439 }
440 a.aapt.usesNonSdkApis = usePlatformAPI
David Brazdild25060a2019-02-18 18:24:16 +0000441
Jaewoong Jungc27ab662019-05-30 15:51:14 -0700442 // Ask manifest_fixer to add or update the application element indicating this app has no code.
443 a.aapt.hasNoCode = !a.hasCode(ctx)
444
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800445 aaptLinkFlags := []string{}
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800446
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800447 // Add TARGET_AAPT_CHARACTERISTICS values to AAPT link flags if they exist and --product flags were not provided.
Jaewoong Jung3aff5782020-02-11 07:54:35 -0800448 hasProduct := android.PrefixInList(a.aaptProperties.Aaptflags, "--product")
Colin Crosse78dcd32018-04-19 15:25:19 -0700449 if !hasProduct && len(ctx.Config().ProductAAPTCharacteristics()) > 0 {
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800450 aaptLinkFlags = append(aaptLinkFlags, "--product", ctx.Config().ProductAAPTCharacteristics())
Colin Crosse78dcd32018-04-19 15:25:19 -0700451 }
452
Dan Willemsen72be5902018-10-24 20:24:57 -0700453 if !Bool(a.aaptProperties.Aapt_include_all_resources) {
454 // Product AAPT config
455 for _, aaptConfig := range ctx.Config().ProductAAPTConfig() {
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800456 aaptLinkFlags = append(aaptLinkFlags, "-c", aaptConfig)
Dan Willemsen72be5902018-10-24 20:24:57 -0700457 }
Colin Crosse78dcd32018-04-19 15:25:19 -0700458
Dan Willemsen72be5902018-10-24 20:24:57 -0700459 // Product AAPT preferred config
460 if len(ctx.Config().ProductAAPTPreferredConfig()) > 0 {
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800461 aaptLinkFlags = append(aaptLinkFlags, "--preferred-density", ctx.Config().ProductAAPTPreferredConfig())
Dan Willemsen72be5902018-10-24 20:24:57 -0700462 }
Colin Crosse78dcd32018-04-19 15:25:19 -0700463 }
464
Jiyong Park7f67f482019-01-05 12:57:48 +0900465 manifestPackageName, overridden := ctx.DeviceConfig().OverrideManifestPackageNameFor(ctx.ModuleName())
Jaewoong Jung6f373f62019-03-13 10:13:24 -0700466 if overridden || a.overridableAppProperties.Package_name != nil {
467 // The product override variable has a priority over the package_name property.
468 if !overridden {
469 manifestPackageName = *a.overridableAppProperties.Package_name
470 }
Liz Kammer9f9fd022020-06-18 19:44:06 +0000471 aaptLinkFlags = append(aaptLinkFlags, generateAaptRenamePackageFlags(manifestPackageName, a.renameResourcesPackage())...)
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900472 a.overriddenManifestPackageName = manifestPackageName
Jiyong Park7f67f482019-01-05 12:57:48 +0900473 }
474
Jaewoong Jung4102e5d2019-02-27 16:26:28 -0800475 aaptLinkFlags = append(aaptLinkFlags, a.additionalAaptFlags...)
476
Colin Crosse560c4a2019-03-19 16:03:11 -0700477 a.aapt.splitNames = a.appProperties.Package_splits
Baligh Uddin5b16dfb2020-02-11 17:27:19 -0800478 a.aapt.LoggingParent = String(a.overridableAppProperties.Logging_parent)
Alexei Nicoara69cf0f32022-07-27 14:59:18 +0100479 if a.Updatable() {
480 a.aapt.defaultManifestVersion = android.DefaultUpdatableModuleVersion
481 }
Paul Duffin06530572022-02-03 17:54:15 +0000482 a.aapt.buildActions(ctx, android.SdkContext(a), a.classLoaderContexts,
Harshit Mahajan5b8b7302022-06-10 11:24:05 +0000483 a.usesLibraryProperties.Exclude_uses_libs, a.enforceDefaultTargetSdkVersion(), aaptLinkFlags...)
Colin Cross30e076a2015-04-13 13:58:27 -0700484
Colin Cross46c9b8b2017-06-22 16:51:17 -0700485 // apps manifests are handled by aapt, don't let Module see them
Dan Willemsen34cc69e2015-09-23 15:26:20 -0700486 a.properties.Manifest = nil
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800487}
Colin Cross30e076a2015-04-13 13:58:27 -0700488
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800489func (a *AndroidApp) proguardBuildActions(ctx android.ModuleContext) {
Colin Cross89c31582018-04-30 15:55:11 -0700490 var staticLibProguardFlagFiles android.Paths
491 ctx.VisitDirectDeps(func(m android.Module) {
Sam Delmerico95d70942023-08-02 18:00:35 -0400492 depProguardInfo := ctx.OtherModuleProvider(m, ProguardSpecInfoProvider).(ProguardSpecInfo)
493 staticLibProguardFlagFiles = append(staticLibProguardFlagFiles, depProguardInfo.UnconditionallyExportedProguardFlags.ToList()...)
494 if ctx.OtherModuleDependencyTag(m) == staticLibTag {
495 staticLibProguardFlagFiles = append(staticLibProguardFlagFiles, depProguardInfo.ProguardFlagsFiles.ToList()...)
Colin Cross89c31582018-04-30 15:55:11 -0700496 }
497 })
498
499 staticLibProguardFlagFiles = android.FirstUniquePaths(staticLibProguardFlagFiles)
500
501 a.Module.extraProguardFlagFiles = append(a.Module.extraProguardFlagFiles, staticLibProguardFlagFiles...)
502 a.Module.extraProguardFlagFiles = append(a.Module.extraProguardFlagFiles, a.proguardOptionsFile)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800503}
Colin Cross66dbc0b2017-12-28 12:23:20 -0800504
Colin Cross403cc152020-07-06 14:15:24 -0700505func (a *AndroidApp) installPath(ctx android.ModuleContext) android.InstallPath {
Colin Cross43f08db2018-11-12 10:13:39 -0800506 var installDir string
507 if ctx.ModuleName() == "framework-res" {
508 // framework-res.apk is installed as system/framework/framework-res.apk
509 installDir = "framework"
Jiyong Parkf7487312019-10-17 12:54:30 +0900510 } else if a.Privileged() {
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800511 installDir = filepath.Join("priv-app", a.installApkName)
Colin Cross43f08db2018-11-12 10:13:39 -0800512 } else {
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800513 installDir = filepath.Join("app", a.installApkName)
Colin Cross43f08db2018-11-12 10:13:39 -0800514 }
Colin Cross403cc152020-07-06 14:15:24 -0700515
516 return android.PathForModuleInstall(ctx, installDir, a.installApkName+".apk")
517}
518
Ulya Trafimovich18554242020-11-03 15:55:11 +0000519func (a *AndroidApp) dexBuildActions(ctx android.ModuleContext) android.Path {
Colin Cross403cc152020-07-06 14:15:24 -0700520 a.dexpreopter.installPath = a.installPath(ctx)
Ulya Trafimovich76b08522021-01-14 17:52:43 +0000521 a.dexpreopter.isApp = true
Liz Kammera7a64f32020-07-09 15:16:41 -0700522 if a.dexProperties.Uncompress_dex == nil {
David Srbeckye033cba2020-05-20 22:20:28 +0100523 // If the value was not force-set by the user, use reasonable default based on the module.
Liz Kammera7a64f32020-07-09 15:16:41 -0700524 a.dexProperties.Uncompress_dex = proptools.BoolPtr(a.shouldUncompressDex(ctx))
David Srbeckye033cba2020-05-20 22:20:28 +0100525 }
Liz Kammera7a64f32020-07-09 15:16:41 -0700526 a.dexpreopter.uncompressedDex = *a.dexProperties.Uncompress_dex
Colin Cross50ddcc42019-05-16 12:28:22 -0700527 a.dexpreopter.enforceUsesLibs = a.usesLibrary.enforceUsesLibraries()
Ulya Trafimovichb23d28c2020-10-08 12:53:58 +0100528 a.dexpreopter.classLoaderContexts = a.classLoaderContexts
Colin Cross50ddcc42019-05-16 12:28:22 -0700529 a.dexpreopter.manifestFile = a.mergedManifestFile
Colin Crossfa9bfcd2021-11-10 16:42:38 -0800530 a.dexpreopter.preventInstall = a.appProperties.PreventInstall
Colin Cross50ddcc42019-05-16 12:28:22 -0700531
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800532 if ctx.ModuleName() != "framework-res" {
Colin Cross4eae06d2023-06-20 22:40:02 -0700533 var extraSrcJars android.Paths
534 var extraClasspathJars android.Paths
535 var extraCombinedJars android.Paths
536 if a.useResourceProcessorBusyBox() {
537 // When building an app with ResourceProcessorBusyBox enabled ResourceProcessorBusyBox has already
538 // created R.class files that provide IDs for resources in busybox/R.jar. Pass that file in the
539 // classpath when compiling everything else, and add it to the final classes jar.
540 extraClasspathJars = android.Paths{a.aapt.rJar}
541 extraCombinedJars = android.Paths{a.aapt.rJar}
542 } else {
543 // When building an app without ResourceProcessorBusyBox the aapt2 rule creates R.srcjar containing
544 // R.java files for the app's package and the packages from all transitive static android_library
545 // dependencies. Compile the srcjar alongside the rest of the sources.
546 extraSrcJars = android.Paths{a.aapt.aaptSrcJar}
547 }
548
549 a.Module.compile(ctx, extraSrcJars, extraClasspathJars, extraCombinedJars)
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800550 }
Colin Cross30e076a2015-04-13 13:58:27 -0700551
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +0100552 return a.dexJarFile.PathOrNil()
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800553}
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800554
Sam Delmerico82602492022-06-10 17:05:42 +0000555func (a *AndroidApp) jniBuildActions(jniLibs []jniLib, prebuiltJniPackages android.Paths, ctx android.ModuleContext) android.WritablePath {
Colin Crossa4f08812018-10-02 22:03:40 -0700556 var jniJarFile android.WritablePath
Sam Delmerico82602492022-06-10 17:05:42 +0000557 if len(jniLibs) > 0 || len(prebuiltJniPackages) > 0 {
Colin Cross403cc152020-07-06 14:15:24 -0700558 a.jniLibs = jniLibs
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700559 if a.shouldEmbedJnis(ctx) {
Colin Crossa4f08812018-10-02 22:03:40 -0700560 jniJarFile = android.PathForModuleOut(ctx, "jnilibs.zip")
Colin Crossc68db4b2021-11-11 18:59:15 -0800561 a.installPathForJNISymbols = a.installPath(ctx)
Sam Delmerico82602492022-06-10 17:05:42 +0000562 TransformJniLibsToJar(ctx, jniJarFile, jniLibs, prebuiltJniPackages, a.useEmbeddedNativeLibs(ctx))
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700563 for _, jni := range jniLibs {
564 if jni.coverageFile.Valid() {
Jaewoong Jung46984ee2020-04-07 13:07:55 -0700565 // Only collect coverage for the first target arch if this is a multilib target.
566 // TODO(jungjw): Ideally, we want to collect both reports, but that would cause coverage
567 // data file path collisions since the current coverage file path format doesn't contain
568 // arch-related strings. This is fine for now though; the code coverage team doesn't use
569 // multi-arch targets such as test_suite_* for coverage collections yet.
570 //
571 // Work with the team to come up with a new format that handles multilib modules properly
572 // and change this.
573 if len(ctx.Config().Targets[android.Android]) == 1 ||
Jaewoong Jung642916f2020-10-09 17:25:15 -0700574 ctx.Config().AndroidFirstDeviceTarget.Arch.ArchType == jni.target.Arch.ArchType {
Jaewoong Jung46984ee2020-04-07 13:07:55 -0700575 a.jniCoverageOutputs = append(a.jniCoverageOutputs, jni.coverageFile.Path())
576 }
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700577 }
578 }
Colin Cross403cc152020-07-06 14:15:24 -0700579 a.embeddedJniLibs = true
Colin Crossa4f08812018-10-02 22:03:40 -0700580 }
581 }
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800582 return jniJarFile
583}
Colin Crossa4f08812018-10-02 22:03:40 -0700584
Colin Cross403cc152020-07-06 14:15:24 -0700585func (a *AndroidApp) JNISymbolsInstalls(installPath string) android.RuleBuilderInstalls {
586 var jniSymbols android.RuleBuilderInstalls
587 for _, jniLib := range a.jniLibs {
588 if jniLib.unstrippedFile != nil {
589 jniSymbols = append(jniSymbols, android.RuleBuilderInstall{
590 From: jniLib.unstrippedFile,
591 To: filepath.Join(installPath, targetToJniDir(jniLib.target), jniLib.unstrippedFile.Base()),
592 })
593 }
594 }
595 return jniSymbols
596}
597
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700598// Reads and prepends a main cert from the default cert dir if it hasn't been set already, i.e. it
599// isn't a cert module reference. Also checks and enforces system cert restriction if applicable.
Colin Crossbc2c8a72022-09-14 12:45:42 -0700600func processMainCert(m android.ModuleBase, certPropValue string, certificates []Certificate,
601 ctx android.ModuleContext) (mainCertificate Certificate, allCertificates []Certificate) {
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700602 if android.SrcIsModule(certPropValue) == "" {
603 var mainCert Certificate
604 if certPropValue != "" {
605 defaultDir := ctx.Config().DefaultAppCertificateDir(ctx)
606 mainCert = Certificate{
Colin Cross503c1d02020-01-28 14:00:53 -0800607 Pem: defaultDir.Join(ctx, certPropValue+".x509.pem"),
608 Key: defaultDir.Join(ctx, certPropValue+".pk8"),
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700609 }
610 } else {
611 pem, key := ctx.Config().DefaultAppCertificate(ctx)
Colin Cross503c1d02020-01-28 14:00:53 -0800612 mainCert = Certificate{
613 Pem: pem,
614 Key: key,
615 }
Colin Crossbd01e2a2018-10-04 15:21:03 -0700616 }
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700617 certificates = append([]Certificate{mainCert}, certificates...)
Colin Crossbd01e2a2018-10-04 15:21:03 -0700618 }
619
Colin Crossbc2c8a72022-09-14 12:45:42 -0700620 if len(certificates) > 0 {
621 mainCertificate = certificates[0]
622 } else {
623 // This can be reached with an empty certificate list if AllowMissingDependencies is set
624 // and the certificate property for this module is a module reference to a missing module.
625 if !ctx.Config().AllowMissingDependencies() && len(ctx.GetMissingDependencies()) > 0 {
626 panic("Should only get here if AllowMissingDependencies set and there are missing dependencies")
627 }
628 // Set a certificate to avoid panics later when accessing it.
629 mainCertificate = Certificate{
630 Key: android.PathForModuleOut(ctx, "missing.pk8"),
Colin Crossa54f4b52022-11-21 04:35:53 +0000631 Pem: android.PathForModuleOut(ctx, "missing.x509.pem"),
Colin Crossbc2c8a72022-09-14 12:45:42 -0700632 }
633 }
634
Zyan Wub7550aa2023-05-18 15:46:31 +0800635 if !m.Platform() {
636 certPath := mainCertificate.Pem.String()
637 systemCertPath := ctx.Config().DefaultAppCertificateDir(ctx).String()
638 if strings.HasPrefix(certPath, systemCertPath) {
639 enforceSystemCert := ctx.Config().EnforceSystemCertificate()
640 allowed := ctx.Config().EnforceSystemCertificateAllowList()
641
642 if enforceSystemCert && !inList(m.Name(), allowed) {
643 ctx.PropertyErrorf("certificate", "The module in product partition cannot be signed with certificate in system.")
644 }
645 }
646 }
647
Colin Crossbc2c8a72022-09-14 12:45:42 -0700648 return mainCertificate, certificates
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800649}
650
Jooyung Han39ee1192020-03-23 20:21:11 +0900651func (a *AndroidApp) InstallApkName() string {
652 return a.installApkName
653}
654
Sam Delmerico15809f82023-05-15 17:21:47 -0400655func (a *AndroidApp) createPrivappAllowlist(ctx android.ModuleContext) android.Path {
Andrei Onea580636b2022-08-17 16:53:46 +0000656 if a.appProperties.Privapp_allowlist == nil {
657 return nil
658 }
Sam Delmerico15809f82023-05-15 17:21:47 -0400659
660 isOverrideApp := a.GetOverriddenBy() != ""
661 if !isOverrideApp {
662 // if this is not an override, we don't need to rewrite the existing privapp allowlist
663 return android.PathForModuleSrc(ctx, *a.appProperties.Privapp_allowlist)
664 }
665
Andrei Onea580636b2022-08-17 16:53:46 +0000666 if a.overridableAppProperties.Package_name == nil {
667 ctx.PropertyErrorf("privapp_allowlist", "package_name must be set to use privapp_allowlist")
668 }
Sam Delmerico15809f82023-05-15 17:21:47 -0400669
Andrei Onea580636b2022-08-17 16:53:46 +0000670 packageName := *a.overridableAppProperties.Package_name
671 fileName := "privapp_allowlist_" + packageName + ".xml"
672 outPath := android.PathForModuleOut(ctx, fileName).OutputPath
673 ctx.Build(pctx, android.BuildParams{
674 Rule: modifyAllowlist,
675 Input: android.PathForModuleSrc(ctx, *a.appProperties.Privapp_allowlist),
676 Output: outPath,
677 Args: map[string]string{
678 "packageName": packageName,
679 },
680 })
681 return &outPath
682}
683
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800684func (a *AndroidApp) generateAndroidBuildActions(ctx android.ModuleContext) {
Colin Cross50ddcc42019-05-16 12:28:22 -0700685 var apkDeps android.Paths
686
Colin Cross56a83212020-09-15 18:30:11 -0700687 if !ctx.Provider(android.ApexInfoProvider).(android.ApexInfo).IsForPlatform() {
688 a.hideApexVariantFromMake = true
689 }
690
Jeongik Cha538c0d02019-07-11 15:54:27 +0900691 a.aapt.useEmbeddedNativeLibs = a.useEmbeddedNativeLibs(ctx)
692 a.aapt.useEmbeddedDex = Bool(a.appProperties.Use_embedded_dex)
693
Jihoon Kang1bfb6f22023-07-01 00:13:47 +0000694 // Unlike installApkName, a.stem should respect base module name for override_android_app.
695 // Therefore, use ctx.ModuleName() instead of a.Name().
696 a.stem = proptools.StringDefault(a.overridableDeviceProperties.Stem, ctx.ModuleName())
697
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800698 // Check if the install APK name needs to be overridden.
Jihoon Kang1bfb6f22023-07-01 00:13:47 +0000699 // Both android_app and override_android_app module are expected to possess
700 // its module bound apk path. However, override_android_app inherits ctx.ModuleName()
701 // from the base module. Therefore, use a.Name() which represents
702 // the module name for both android_app and override_android_app.
703 a.installApkName = ctx.DeviceConfig().OverridePackageNameFor(
704 proptools.StringDefault(a.overridableDeviceProperties.Stem, a.Name()))
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800705
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700706 if ctx.ModuleName() == "framework-res" {
707 // framework-res.apk is installed as system/framework/framework-res.apk
Jaewoong Jung0949f312019-09-11 10:25:18 -0700708 a.installDir = android.PathForModuleInstall(ctx, "framework")
Jiyong Parkf7487312019-10-17 12:54:30 +0900709 } else if a.Privileged() {
Jaewoong Jung0949f312019-09-11 10:25:18 -0700710 a.installDir = android.PathForModuleInstall(ctx, "priv-app", a.installApkName)
711 } else if ctx.InstallInTestcases() {
Jaewoong Jung326a9412019-11-21 10:41:00 -0800712 a.installDir = android.PathForModuleInstall(ctx, a.installApkName, ctx.DeviceConfig().DeviceArch())
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700713 } else {
Jaewoong Jung0949f312019-09-11 10:25:18 -0700714 a.installDir = android.PathForModuleInstall(ctx, "app", a.installApkName)
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700715 }
Jaewoong Jung7dd4ae22019-09-27 17:13:15 -0700716 a.onDeviceDir = android.InstallPathToOnDevicePath(ctx, a.installDir)
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700717
Ulya Trafimovichb23d28c2020-10-08 12:53:58 +0100718 a.classLoaderContexts = a.usesLibrary.classLoaderContextForUsesLibDeps(ctx)
Ulya Trafimovich18554242020-11-03 15:55:11 +0000719
Colin Cross61fb62e2022-06-23 10:46:28 -0700720 var noticeAssetPath android.WritablePath
721 if Bool(a.appProperties.Embed_notices) || ctx.Config().IsEnvTrue("ALWAYS_EMBED_NOTICES") {
722 // The rule to create the notice file can't be generated yet, as the final output path
723 // for the apk isn't known yet. Add the path where the notice file will be generated to the
724 // aapt rules now before calling aaptBuildActions, the rule to create the notice file will
725 // be generated later.
726 noticeAssetPath = android.PathForModuleOut(ctx, "NOTICE", "NOTICE.html.gz")
727 a.aapt.noticeFile = android.OptionalPathForPath(noticeAssetPath)
728 }
729
Harshit Mahajan8f202ad2023-01-09 20:45:55 +0000730 // For apps targeting latest target_sdk_version
731 if Bool(a.appProperties.Enforce_default_target_sdk_version) {
732 a.SetEnforceDefaultTargetSdkVersion(true)
733 }
734
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800735 // Process all building blocks, from AAPT to certificates.
736 a.aaptBuildActions(ctx)
737
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +0100738 // The decision to enforce <uses-library> checks is made before adding implicit SDK libraries.
739 a.usesLibrary.freezeEnforceUsesLibraries()
740
741 // Add implicit SDK libraries to <uses-library> list.
Ulya Trafimovichfc0f6e32021-08-12 16:16:11 +0100742 requiredUsesLibs, optionalUsesLibs := a.classLoaderContexts.UsesLibs()
743 for _, usesLib := range requiredUsesLibs {
744 a.usesLibrary.addLib(usesLib, false)
745 }
746 for _, usesLib := range optionalUsesLibs {
747 a.usesLibrary.addLib(usesLib, true)
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +0100748 }
749
750 // Check that the <uses-library> list is coherent with the manifest.
Colin Cross50ddcc42019-05-16 12:28:22 -0700751 if a.usesLibrary.enforceUsesLibraries() {
752 manifestCheckFile := a.usesLibrary.verifyUsesLibrariesManifest(ctx, a.mergedManifestFile)
753 apkDeps = append(apkDeps, manifestCheckFile)
754 }
755
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800756 a.proguardBuildActions(ctx)
757
Colin Cross014489c2020-06-02 20:09:13 -0700758 a.linter.mergedManifest = a.aapt.mergedManifestFile
759 a.linter.manifest = a.aapt.manifestPath
760 a.linter.resources = a.aapt.resourceFiles
Colin Crossc0efd1d2020-07-03 11:56:24 -0700761 a.linter.buildModuleReportZip = ctx.Config().UnbundledBuildApps()
Colin Cross014489c2020-06-02 20:09:13 -0700762
Ulya Trafimovich18554242020-11-03 15:55:11 +0000763 dexJarFile := a.dexBuildActions(ctx)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800764
Colin Crossbc2c8a72022-09-14 12:45:42 -0700765 jniLibs, prebuiltJniPackages, certificates := collectAppDeps(ctx, a, a.shouldEmbedJnis(ctx), !Bool(a.appProperties.Jni_uses_platform_apis))
Sam Delmerico82602492022-06-10 17:05:42 +0000766 jniJarFile := a.jniBuildActions(jniLibs, prebuiltJniPackages, ctx)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800767
768 if ctx.Failed() {
769 return
770 }
771
Colin Crossbc2c8a72022-09-14 12:45:42 -0700772 a.certificate, certificates = processMainCert(a.ModuleBase, a.getCertString(ctx), certificates, ctx)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800773
774 // Build a final signed app package.
Jaewoong Jung5a498812019-11-07 14:14:38 -0800775 packageFile := android.PathForModuleOut(ctx, a.installApkName+".apk")
Songchun Fan17d69e32020-03-24 20:32:24 -0700776 v4SigningRequested := Bool(a.Module.deviceProperties.V4_signature)
777 var v4SignatureFile android.WritablePath = nil
778 if v4SigningRequested {
779 v4SignatureFile = android.PathForModuleOut(ctx, a.installApkName+".apk.idsig")
780 }
Liz Kammere2b27f42020-05-07 13:24:05 -0700781 var lineageFile android.Path
782 if lineage := String(a.overridableAppProperties.Lineage); lineage != "" {
783 lineageFile = android.PathForModuleSrc(ctx, lineage)
784 }
Rupert Shuttleworth8eab8692021-11-03 10:39:39 -0400785 rotationMinSdkVersion := String(a.overridableAppProperties.RotationMinSdkVersion)
786
Rico Wind351bac92022-09-22 10:41:42 +0200787 CreateAndSignAppPackage(ctx, packageFile, a.exportPackage, jniJarFile, dexJarFile, certificates, apkDeps, v4SignatureFile, lineageFile, rotationMinSdkVersion, Bool(a.dexProperties.Optimize.Shrink_resources))
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800788 a.outputFile = packageFile
Songchun Fan17d69e32020-03-24 20:32:24 -0700789 if v4SigningRequested {
790 a.extraOutputFiles = append(a.extraOutputFiles, v4SignatureFile)
791 }
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800792
Colin Cross61fb62e2022-06-23 10:46:28 -0700793 if a.aapt.noticeFile.Valid() {
794 // Generating the notice file rule has to be here after a.outputFile is known.
Bob Badoureef4c1c2022-05-16 12:20:04 -0700795 noticeFile := android.PathForModuleOut(ctx, "NOTICE.html.gz")
Bob Badourc6ec9fb2022-06-08 15:59:35 -0700796 android.BuildNoticeHtmlOutputFromLicenseMetadata(
797 ctx, noticeFile, "", "",
798 []string{
799 a.installDir.String() + "/",
800 android.PathForModuleInstall(ctx).String() + "/",
801 a.outputFile.String(),
802 })
Bob Badoureef4c1c2022-05-16 12:20:04 -0700803 builder := android.NewRuleBuilder(pctx, ctx)
804 builder.Command().Text("cp").
805 Input(noticeFile).
806 Output(noticeAssetPath)
807 builder.Build("notice_dir", "Building notice dir")
Bob Badoureef4c1c2022-05-16 12:20:04 -0700808 }
809
Colin Crosse560c4a2019-03-19 16:03:11 -0700810 for _, split := range a.aapt.splits {
811 // Sign the split APKs
Jaewoong Jung5a498812019-11-07 14:14:38 -0800812 packageFile := android.PathForModuleOut(ctx, a.installApkName+"_"+split.suffix+".apk")
Songchun Fan17d69e32020-03-24 20:32:24 -0700813 if v4SigningRequested {
814 v4SignatureFile = android.PathForModuleOut(ctx, a.installApkName+"_"+split.suffix+".apk.idsig")
815 }
Rico Wind351bac92022-09-22 10:41:42 +0200816 CreateAndSignAppPackage(ctx, packageFile, split.path, nil, nil, certificates, apkDeps, v4SignatureFile, lineageFile, rotationMinSdkVersion, false)
Colin Crosse560c4a2019-03-19 16:03:11 -0700817 a.extraOutputFiles = append(a.extraOutputFiles, packageFile)
Songchun Fan17d69e32020-03-24 20:32:24 -0700818 if v4SigningRequested {
819 a.extraOutputFiles = append(a.extraOutputFiles, v4SignatureFile)
820 }
Colin Crosse560c4a2019-03-19 16:03:11 -0700821 }
822
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800823 // Build an app bundle.
Colin Crossf6237212018-10-29 23:14:58 -0700824 bundleFile := android.PathForModuleOut(ctx, "base.zip")
825 BuildBundleModule(ctx, bundleFile, a.exportPackage, jniJarFile, dexJarFile)
826 a.bundleFile = bundleFile
827
Andrei Onea580636b2022-08-17 16:53:46 +0000828 allowlist := a.createPrivappAllowlist(ctx)
829 if allowlist != nil {
830 a.privAppAllowlist = android.OptionalPathForPath(allowlist)
831 }
832
Colin Cross56a83212020-09-15 18:30:11 -0700833 apexInfo := ctx.Provider(android.ApexInfoProvider).(android.ApexInfo)
834
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800835 // Install the app package.
Andrei Onea580636b2022-08-17 16:53:46 +0000836 shouldInstallAppPackage := (Bool(a.Module.properties.Installable) || ctx.Host()) && apexInfo.IsForPlatform() && !a.appProperties.PreventInstall
837 if shouldInstallAppPackage {
Sam Delmericob1daccd2023-05-25 14:45:30 -0400838 if a.privAppAllowlist.Valid() {
Anton Hansson0e486a42023-06-01 16:38:35 +0000839 allowlistInstallPath := android.PathForModuleInstall(ctx, "etc", "permissions")
840 allowlistInstallFilename := a.installApkName + ".xml"
841 ctx.InstallFile(allowlistInstallPath, allowlistInstallFilename, a.privAppAllowlist.Path())
Sam Delmericob1daccd2023-05-25 14:45:30 -0400842 }
843
Colin Cross1d0eb7a2021-11-03 14:08:20 -0700844 var extraInstalledPaths android.Paths
Jiyong Park8ba50f92019-11-13 15:01:01 +0900845 for _, extra := range a.extraOutputFiles {
Colin Cross1d0eb7a2021-11-03 14:08:20 -0700846 installed := ctx.InstallFile(a.installDir, extra.Base(), extra)
847 extraInstalledPaths = append(extraInstalledPaths, installed)
Jiyong Park8ba50f92019-11-13 15:01:01 +0900848 }
Colin Cross1d0eb7a2021-11-03 14:08:20 -0700849 ctx.InstallFile(a.installDir, a.outputFile.Base(), a.outputFile, extraInstalledPaths...)
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800850 }
Artur Satayev1111b842020-04-27 19:05:28 +0100851
852 a.buildAppDependencyInfo(ctx)
Colin Cross30e076a2015-04-13 13:58:27 -0700853}
854
Colin Crossc2d24052020-05-13 11:05:02 -0700855type appDepsInterface interface {
Jiyong Park92315372021-04-02 08:45:46 +0900856 SdkVersion(ctx android.EarlyModuleContext) android.SdkSpec
Spandan Das8c9ae7e2023-03-03 21:20:36 +0000857 MinSdkVersion(ctx android.EarlyModuleContext) android.ApiLevel
Colin Crossc2d24052020-05-13 11:05:02 -0700858 RequiresStableAPIs(ctx android.BaseModuleContext) bool
859}
860
861func collectAppDeps(ctx android.ModuleContext, app appDepsInterface,
862 shouldCollectRecursiveNativeDeps bool,
Sam Delmerico82602492022-06-10 17:05:42 +0000863 checkNativeSdkVersion bool) ([]jniLib, android.Paths, []Certificate) {
Colin Crossc2d24052020-05-13 11:05:02 -0700864
Colin Crossa4f08812018-10-02 22:03:40 -0700865 var jniLibs []jniLib
Sam Delmerico82602492022-06-10 17:05:42 +0000866 var prebuiltJniPackages android.Paths
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900867 var certificates []Certificate
Peter Collingbournead84f972019-12-17 16:46:18 -0800868 seenModulePaths := make(map[string]bool)
Colin Crossa4f08812018-10-02 22:03:40 -0700869
Colin Crossc2d24052020-05-13 11:05:02 -0700870 if checkNativeSdkVersion {
Jiyong Park92315372021-04-02 08:45:46 +0900871 checkNativeSdkVersion = app.SdkVersion(ctx).Specified() &&
872 app.SdkVersion(ctx).Kind != android.SdkCorePlatform && !app.RequiresStableAPIs(ctx)
Colin Crossc2d24052020-05-13 11:05:02 -0700873 }
874
Peter Collingbournead84f972019-12-17 16:46:18 -0800875 ctx.WalkDeps(func(module android.Module, parent android.Module) bool {
Colin Crossa4f08812018-10-02 22:03:40 -0700876 otherName := ctx.OtherModuleName(module)
877 tag := ctx.OtherModuleDependencyTag(module)
878
Colin Crossf0913fb2020-07-29 12:59:39 -0700879 if IsJniDepTag(tag) || cc.IsSharedDepTag(tag) {
Ivan Lozano7f67c2a2022-06-27 16:00:26 -0400880 if dep, ok := module.(cc.LinkableInterface); ok {
Colin Cross95f1ca02020-10-29 20:47:22 -0700881 if dep.IsNdk(ctx.Config()) || dep.IsStubs() {
Peter Collingbournead84f972019-12-17 16:46:18 -0800882 return false
883 }
884
Colin Crossa4f08812018-10-02 22:03:40 -0700885 lib := dep.OutputFile()
886 if lib.Valid() {
Cole Faust64cb7c92021-09-14 17:32:49 -0700887 path := lib.Path()
888 if seenModulePaths[path.String()] {
889 return false
890 }
891 seenModulePaths[path.String()] = true
892
893 if checkNativeSdkVersion && dep.SdkVersion() == "" {
894 ctx.PropertyErrorf("jni_libs", "JNI dependency %q uses platform APIs, but this module does not",
895 otherName)
896 }
897
Colin Crossa4f08812018-10-02 22:03:40 -0700898 jniLibs = append(jniLibs, jniLib{
Colin Cross403cc152020-07-06 14:15:24 -0700899 name: ctx.OtherModuleName(module),
900 path: path,
901 target: module.Target(),
902 coverageFile: dep.CoverageOutputFile(),
903 unstrippedFile: dep.UnstrippedOutputFile(),
Jihoon Kangf78a8902022-09-01 22:47:07 +0000904 partition: dep.Partition(),
Colin Crossa4f08812018-10-02 22:03:40 -0700905 })
Colin Crossdd5261c2022-12-19 12:26:43 -0800906 } else if ctx.Config().AllowMissingDependencies() {
907 ctx.AddMissingDependencies([]string{otherName})
Colin Crossa4f08812018-10-02 22:03:40 -0700908 } else {
909 ctx.ModuleErrorf("dependency %q missing output file", otherName)
910 }
911 } else {
912 ctx.ModuleErrorf("jni_libs dependency %q must be a cc library", otherName)
Colin Crossa4f08812018-10-02 22:03:40 -0700913 }
Peter Collingbournead84f972019-12-17 16:46:18 -0800914
915 return shouldCollectRecursiveNativeDeps
916 }
917
Sam Delmerico82602492022-06-10 17:05:42 +0000918 if info, ok := ctx.OtherModuleProvider(module, JniPackageProvider).(JniPackageInfo); ok {
919 prebuiltJniPackages = append(prebuiltJniPackages, info.JniPackages...)
920 }
921
Peter Collingbournead84f972019-12-17 16:46:18 -0800922 if tag == certificateTag {
Colin Crossbd01e2a2018-10-04 15:21:03 -0700923 if dep, ok := module.(*AndroidAppCertificate); ok {
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900924 certificates = append(certificates, dep.Certificate)
Colin Crossbd01e2a2018-10-04 15:21:03 -0700925 } else {
926 ctx.ModuleErrorf("certificate dependency %q must be an android_app_certificate module", otherName)
927 }
Colin Crossa4f08812018-10-02 22:03:40 -0700928 }
Peter Collingbournead84f972019-12-17 16:46:18 -0800929
930 return false
Colin Crossa4f08812018-10-02 22:03:40 -0700931 })
932
Sam Delmerico82602492022-06-10 17:05:42 +0000933 return jniLibs, prebuiltJniPackages, certificates
Colin Crossa4f08812018-10-02 22:03:40 -0700934}
935
Jooyung Han749dc692020-04-15 11:03:39 +0900936func (a *AndroidApp) WalkPayloadDeps(ctx android.ModuleContext, do android.PayloadDepsCallback) {
Artur Satayev1111b842020-04-27 19:05:28 +0100937 ctx.WalkDeps(func(child, parent android.Module) bool {
938 isExternal := !a.DepIsInSameApex(ctx, child)
939 if am, ok := child.(android.ApexModule); ok {
Jooyung Han749dc692020-04-15 11:03:39 +0900940 if !do(ctx, parent, am, isExternal) {
941 return false
942 }
Artur Satayev1111b842020-04-27 19:05:28 +0100943 }
944 return !isExternal
945 })
946}
947
948func (a *AndroidApp) buildAppDependencyInfo(ctx android.ModuleContext) {
949 if ctx.Host() {
950 return
951 }
952
953 depsInfo := android.DepNameToDepInfoMap{}
Jooyung Han749dc692020-04-15 11:03:39 +0900954 a.WalkPayloadDeps(ctx, func(ctx android.ModuleContext, from blueprint.Module, to android.ApexModule, externalDep bool) bool {
Artur Satayev1111b842020-04-27 19:05:28 +0100955 depName := to.Name()
Artur Satayev533b98c2021-03-11 18:03:42 +0000956
957 // Skip dependencies that are only available to APEXes; they are developed with updatability
958 // in mind and don't need manual approval.
959 if to.(android.ApexModule).NotAvailableForPlatform() {
960 return true
961 }
962
Artur Satayev1111b842020-04-27 19:05:28 +0100963 if info, exist := depsInfo[depName]; exist {
964 info.From = append(info.From, from.Name())
965 info.IsExternal = info.IsExternal && externalDep
966 depsInfo[depName] = info
967 } else {
968 toMinSdkVersion := "(no version)"
Jiyong Park92315372021-04-02 08:45:46 +0900969 if m, ok := to.(interface {
Spandan Das8c9ae7e2023-03-03 21:20:36 +0000970 MinSdkVersion(ctx android.EarlyModuleContext) android.ApiLevel
Jiyong Park92315372021-04-02 08:45:46 +0900971 }); ok {
Spandan Das8c9ae7e2023-03-03 21:20:36 +0000972 if v := m.MinSdkVersion(ctx); !v.IsNone() {
973 toMinSdkVersion = v.String()
Artur Satayev1111b842020-04-27 19:05:28 +0100974 }
Jiyong Park92315372021-04-02 08:45:46 +0900975 } else if m, ok := to.(interface{ MinSdkVersion() string }); ok {
976 // TODO(b/175678607) eliminate the use of MinSdkVersion returning
977 // string
978 if v := m.MinSdkVersion(); v != "" {
Jiyong Parkf1691d22021-03-29 20:11:58 +0900979 toMinSdkVersion = v
980 }
Artur Satayev1111b842020-04-27 19:05:28 +0100981 }
982 depsInfo[depName] = android.ApexModuleDepInfo{
983 To: depName,
984 From: []string{from.Name()},
985 IsExternal: externalDep,
986 MinSdkVersion: toMinSdkVersion,
987 }
988 }
Jooyung Han749dc692020-04-15 11:03:39 +0900989 return true
Artur Satayev1111b842020-04-27 19:05:28 +0100990 })
991
Jiyong Park92315372021-04-02 08:45:46 +0900992 a.ApexBundleDepsInfo.BuildDepsInfoLists(ctx, a.MinSdkVersion(ctx).String(), depsInfo)
Artur Satayev1111b842020-04-27 19:05:28 +0100993}
994
Harshit Mahajan5b8b7302022-06-10 11:24:05 +0000995func (a *AndroidApp) enforceDefaultTargetSdkVersion() bool {
996 return a.appProperties.EnforceDefaultTargetSdkVersion
997}
998
999func (a *AndroidApp) SetEnforceDefaultTargetSdkVersion(val bool) {
1000 a.appProperties.EnforceDefaultTargetSdkVersion = val
1001}
1002
Artur Satayev849f8442020-04-28 14:57:42 +01001003func (a *AndroidApp) Updatable() bool {
Colin Cross56a83212020-09-15 18:30:11 -07001004 return Bool(a.appProperties.Updatable)
Artur Satayev849f8442020-04-28 14:57:42 +01001005}
1006
Spandan Das42e89502022-05-06 22:12:55 +00001007func (a *AndroidApp) SetUpdatable(val bool) {
1008 a.appProperties.Updatable = &val
1009}
1010
Colin Cross0ea8ba82019-06-06 14:33:29 -07001011func (a *AndroidApp) getCertString(ctx android.BaseModuleContext) string {
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001012 certificate, overridden := ctx.DeviceConfig().OverrideCertificateFor(ctx.ModuleName())
1013 if overridden {
Jaewoong Jungacb6db32019-02-28 16:22:30 +00001014 return ":" + certificate
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001015 }
Jaewoong Jung525443a2019-02-28 15:35:54 -08001016 return String(a.overridableAppProperties.Certificate)
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001017}
1018
Jiyong Park0f80c182020-01-31 02:49:53 +09001019func (a *AndroidApp) DepIsInSameApex(ctx android.BaseModuleContext, dep android.Module) bool {
1020 if IsJniDepTag(ctx.OtherModuleDependencyTag(dep)) {
1021 return true
1022 }
1023 return a.Library.DepIsInSameApex(ctx, dep)
1024}
1025
Jiyong Parkb7c639e2019-08-19 14:56:02 +09001026// For OutputFileProducer interface
1027func (a *AndroidApp) OutputFiles(tag string) (android.Paths, error) {
1028 switch tag {
Jared Duke34b080d2023-03-30 16:40:24 -07001029 // In some instances, it can be useful to reference the aapt-generated flags from another
1030 // target, e.g., system server implements services declared in the framework-res manifest.
1031 case ".aapt.proguardOptionsFile":
1032 return []android.Path{a.proguardOptionsFile}, nil
Jiyong Parkb7c639e2019-08-19 14:56:02 +09001033 case ".aapt.srcjar":
Colin Crossf3b7bad2023-08-02 15:49:00 -07001034 if a.aaptSrcJar != nil {
1035 return []android.Path{a.aaptSrcJar}, nil
1036 }
1037 case ".aapt.jar":
1038 if a.rJar != nil {
1039 return []android.Path{a.rJar}, nil
1040 }
Anton Hansson092aca42020-08-13 19:37:22 +01001041 case ".export-package.apk":
1042 return []android.Path{a.exportPackage}, nil
Jiyong Parkb7c639e2019-08-19 14:56:02 +09001043 }
1044 return a.Library.OutputFiles(tag)
1045}
1046
Jiyong Parkf7487312019-10-17 12:54:30 +09001047func (a *AndroidApp) Privileged() bool {
1048 return Bool(a.appProperties.Privileged)
1049}
1050
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001051func (a *AndroidApp) IsNativeCoverageNeeded(ctx android.BaseModuleContext) bool {
Colin Cross1a6acd42020-06-16 17:51:46 -07001052 return ctx.Device() && ctx.DeviceConfig().NativeCoverageEnabled()
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001053}
1054
Ivan Lozanod7586b62021-04-01 09:49:36 -04001055func (a *AndroidApp) SetPreventInstall() {
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001056 a.appProperties.PreventInstall = true
1057}
1058
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001059func (a *AndroidApp) MarkAsCoverageVariant(coverage bool) {
1060 a.appProperties.IsCoverageVariant = coverage
1061}
1062
Ivan Lozanoa0cd8f92020-04-09 09:56:02 -04001063func (a *AndroidApp) EnableCoverageIfNeeded() {}
1064
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001065var _ cc.Coverage = (*AndroidApp)(nil)
1066
Colin Cross1b16b0e2019-02-12 14:41:32 -08001067// android_app compiles sources and Android resources into an Android application package `.apk` file.
Colin Cross36242852017-06-23 15:06:31 -07001068func AndroidAppFactory() android.Module {
Colin Cross30e076a2015-04-13 13:58:27 -07001069 module := &AndroidApp{}
1070
Liz Kammera7a64f32020-07-09 15:16:41 -07001071 module.Module.dexProperties.Optimize.EnabledByDefault = true
1072 module.Module.dexProperties.Optimize.Shrink = proptools.BoolPtr(true)
Jared Dukeaa88b3d2023-08-29 17:07:20 +00001073 module.Module.dexProperties.Optimize.Proguard_compatibility = proptools.BoolPtr(false)
Colin Cross66dbc0b2017-12-28 12:23:20 -08001074
Colin Crossae5caf52018-05-22 11:11:52 -07001075 module.Module.properties.Instrument = true
Paul Duffin0038a8d2022-05-03 00:28:40 +00001076 module.Module.properties.Supports_static_instrumentation = true
Colin Cross9ae1b922018-06-26 17:59:05 -07001077 module.Module.properties.Installable = proptools.BoolPtr(true)
Colin Crossae5caf52018-05-22 11:11:52 -07001078
Colin Crossce6734e2020-06-15 16:09:53 -07001079 module.addHostAndDeviceProperties()
Colin Cross36242852017-06-23 15:06:31 -07001080 module.AddProperties(
Colin Crossa97c5d32018-03-28 14:58:31 -07001081 &module.aaptProperties,
Jaewoong Jung525443a2019-02-28 15:35:54 -08001082 &module.appProperties,
Ulya Trafimovich21a73752020-09-01 17:33:48 +01001083 &module.overridableAppProperties)
Colin Cross36242852017-06-23 15:06:31 -07001084
Ulya Trafimovich22890c42021-01-05 12:04:17 +00001085 module.usesLibrary.enforce = true
1086
Colin Crossa4f08812018-10-02 22:03:40 -07001087 android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
1088 android.InitDefaultableModule(module)
zhidou198f5892022-02-17 02:33:12 +00001089 android.InitOverridableModule(module, &module.overridableAppProperties.Overrides)
Jiyong Park52cd06f2019-11-11 10:14:32 +09001090 android.InitApexModule(module)
Liz Kammerbe46fcc2021-11-01 15:32:43 -04001091 android.InitBazelModule(module)
Colin Crossa4f08812018-10-02 22:03:40 -07001092
Colin Cross36242852017-06-23 15:06:31 -07001093 return module
Colin Cross30e076a2015-04-13 13:58:27 -07001094}
Colin Crossae5caf52018-05-22 11:11:52 -07001095
1096type appTestProperties struct {
Liz Kammer6b0c5522020-04-28 16:10:55 -07001097 // The name of the android_app module that the tests will run against.
Colin Crossae5caf52018-05-22 11:11:52 -07001098 Instrumentation_for *string
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001099
Seth Moorec6f4b532023-02-02 13:22:26 -08001100 // If specified, the instrumentation target package name in the manifest is overwritten by it.
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001101 Instrumentation_target_package *string
Seth Moorec6f4b532023-02-02 13:22:26 -08001102
1103 // If specified, the mainline module package name in the test config is overwritten by it.
1104 Mainline_package_name *string
Colin Crossae5caf52018-05-22 11:11:52 -07001105}
1106
1107type AndroidTest struct {
1108 AndroidApp
1109
1110 appTestProperties appTestProperties
1111
1112 testProperties testProperties
Colin Cross303e21f2018-08-07 16:49:25 -07001113
Dan Shi95d19422020-08-15 12:24:26 -07001114 testConfig android.Path
1115 extraTestConfigs android.Paths
1116 data android.Paths
Colin Crossae5caf52018-05-22 11:11:52 -07001117}
1118
Jaewoong Jung0949f312019-09-11 10:25:18 -07001119func (a *AndroidTest) InstallInTestcases() bool {
1120 return true
1121}
1122
Spandan Das9f7ae7f2022-07-25 00:34:18 +00001123type androidTestApp interface {
1124 includedInTestSuite(searchPrefix string) bool
1125}
1126
1127func (a *AndroidTest) includedInTestSuite(searchPrefix string) bool {
1128 return android.PrefixInList(a.testProperties.Test_suites, searchPrefix)
1129}
1130
1131func (a *AndroidTestHelperApp) includedInTestSuite(searchPrefix string) bool {
1132 return android.PrefixInList(a.appTestHelperAppProperties.Test_suites, searchPrefix)
1133}
1134
Colin Crossae5caf52018-05-22 11:11:52 -07001135func (a *AndroidTest) GenerateAndroidBuildActions(ctx android.ModuleContext) {
easoncylee5bcff5d2020-04-30 14:57:06 +08001136 var configs []tradefed.Config
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001137 if a.appTestProperties.Instrumentation_target_package != nil {
1138 a.additionalAaptFlags = append(a.additionalAaptFlags,
1139 "--rename-instrumentation-target-package "+*a.appTestProperties.Instrumentation_target_package)
1140 } else if a.appTestProperties.Instrumentation_for != nil {
1141 // Check if the instrumentation target package is overridden.
Jaewoong Jung4102e5d2019-02-27 16:26:28 -08001142 manifestPackageName, overridden := ctx.DeviceConfig().OverrideManifestPackageNameFor(*a.appTestProperties.Instrumentation_for)
1143 if overridden {
1144 a.additionalAaptFlags = append(a.additionalAaptFlags, "--rename-instrumentation-target-package "+manifestPackageName)
1145 }
1146 }
Colin Crossae5caf52018-05-22 11:11:52 -07001147 a.generateAndroidBuildActions(ctx)
Colin Cross303e21f2018-08-07 16:49:25 -07001148
easoncylee5bcff5d2020-04-30 14:57:06 +08001149 for _, module := range a.testProperties.Test_mainline_modules {
1150 configs = append(configs, tradefed.Option{Name: "config-descriptor:metadata", Key: "mainline-param", Value: module})
1151 }
1152
Jaewoong Jung39982342020-01-14 10:27:18 -08001153 testConfig := tradefed.AutoGenInstrumentationTestConfig(ctx, a.testProperties.Test_config,
easoncylee5bcff5d2020-04-30 14:57:06 +08001154 a.testProperties.Test_config_template, a.manifestPath, a.testProperties.Test_suites, a.testProperties.Auto_gen_config, configs)
Jaewoong Jung39982342020-01-14 10:27:18 -08001155 a.testConfig = a.FixTestConfig(ctx, testConfig)
Dan Shi95d19422020-08-15 12:24:26 -07001156 a.extraTestConfigs = android.PathsForModuleSrc(ctx, a.testProperties.Test_options.Extra_test_configs)
Colin Cross8a497952019-03-05 22:25:09 -08001157 a.data = android.PathsForModuleSrc(ctx, a.testProperties.Data)
Colin Cross303e21f2018-08-07 16:49:25 -07001158}
1159
Jaewoong Jung39982342020-01-14 10:27:18 -08001160func (a *AndroidTest) FixTestConfig(ctx android.ModuleContext, testConfig android.Path) android.Path {
1161 if testConfig == nil {
1162 return nil
1163 }
1164
1165 fixedConfig := android.PathForModuleOut(ctx, "test_config_fixer", "AndroidTest.xml")
Colin Crossf1a035e2020-11-16 17:32:30 -08001166 rule := android.NewRuleBuilder(pctx, ctx)
1167 command := rule.Command().BuiltTool("test_config_fixer").Input(testConfig).Output(fixedConfig)
Jaewoong Jung39982342020-01-14 10:27:18 -08001168 fixNeeded := false
1169
Jooyung Han29e2f6d2022-01-08 12:13:59 +09001170 // Auto-generated test config uses `ModuleName` as the APK name. So fix it if it is not the case.
Jaewoong Jung39982342020-01-14 10:27:18 -08001171 if ctx.ModuleName() != a.installApkName {
1172 fixNeeded = true
1173 command.FlagWithArg("--test-file-name ", a.installApkName+".apk")
1174 }
1175
1176 if a.overridableAppProperties.Package_name != nil {
1177 fixNeeded = true
1178 command.FlagWithInput("--manifest ", a.manifestPath).
1179 FlagWithArg("--package-name ", *a.overridableAppProperties.Package_name)
1180 }
1181
Seth Moorec6f4b532023-02-02 13:22:26 -08001182 if a.appTestProperties.Mainline_package_name != nil {
1183 fixNeeded = true
1184 command.FlagWithArg("--mainline-package-name ", *a.appTestProperties.Mainline_package_name)
1185 }
1186
Jaewoong Jung39982342020-01-14 10:27:18 -08001187 if fixNeeded {
Colin Crossf1a035e2020-11-16 17:32:30 -08001188 rule.Build("fix_test_config", "fix test config")
Jaewoong Jung39982342020-01-14 10:27:18 -08001189 return fixedConfig
1190 }
1191 return testConfig
1192}
1193
Colin Cross303e21f2018-08-07 16:49:25 -07001194func (a *AndroidTest) DepsMutator(ctx android.BottomUpMutatorContext) {
Colin Cross303e21f2018-08-07 16:49:25 -07001195 a.AndroidApp.DepsMutator(ctx)
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001196}
1197
1198func (a *AndroidTest) OverridablePropertiesDepsMutator(ctx android.BottomUpMutatorContext) {
1199 a.AndroidApp.OverridablePropertiesDepsMutator(ctx)
Colin Cross4b964c02018-10-15 16:18:06 -07001200 if a.appTestProperties.Instrumentation_for != nil {
1201 // The android_app dependency listed in instrumentation_for needs to be added to the classpath for javac,
1202 // but not added to the aapt2 link includes like a normal android_app or android_library dependency, so
1203 // use instrumentationForTag instead of libTag.
1204 ctx.AddVariationDependencies(nil, instrumentationForTag, String(a.appTestProperties.Instrumentation_for))
1205 }
Colin Crossae5caf52018-05-22 11:11:52 -07001206}
1207
Colin Cross1b16b0e2019-02-12 14:41:32 -08001208// android_test compiles test sources and Android resources into an Android application package `.apk` file and
1209// creates an `AndroidTest.xml` file to allow running the test with `atest` or a `TEST_MAPPING` file.
Colin Crossae5caf52018-05-22 11:11:52 -07001210func AndroidTestFactory() android.Module {
1211 module := &AndroidTest{}
1212
Jared Duke63a3da92022-06-02 19:11:14 +00001213 module.Module.dexProperties.Optimize.EnabledByDefault = false
Colin Cross5067db92018-09-17 16:46:35 -07001214
1215 module.Module.properties.Instrument = true
Paul Duffin0038a8d2022-05-03 00:28:40 +00001216 module.Module.properties.Supports_static_instrumentation = true
Colin Cross9ae1b922018-06-26 17:59:05 -07001217 module.Module.properties.Installable = proptools.BoolPtr(true)
Colin Crosse4246ab2019-02-05 21:55:21 -08001218 module.appProperties.Use_embedded_native_libs = proptools.BoolPtr(true)
Colin Cross47fa9d32019-03-26 10:51:39 -07001219 module.appProperties.AlwaysPackageNativeLibs = true
Colin Cross43f08db2018-11-12 10:13:39 -08001220 module.Module.dexpreopter.isTest = true
Cole Faustd57e8b22022-08-11 11:59:04 -07001221 module.Module.linter.properties.Lint.Test = proptools.BoolPtr(true)
Colin Crossae5caf52018-05-22 11:11:52 -07001222
Colin Crossce6734e2020-06-15 16:09:53 -07001223 module.addHostAndDeviceProperties()
Colin Crossae5caf52018-05-22 11:11:52 -07001224 module.AddProperties(
Colin Crossae5caf52018-05-22 11:11:52 -07001225 &module.aaptProperties,
1226 &module.appProperties,
Dan Willemsenf5531d22018-07-16 17:21:19 -07001227 &module.appTestProperties,
Jaewoong Jung525443a2019-02-28 15:35:54 -08001228 &module.overridableAppProperties,
Dan Willemsenf5531d22018-07-16 17:21:19 -07001229 &module.testProperties)
Colin Crossae5caf52018-05-22 11:11:52 -07001230
Colin Crossa4f08812018-10-02 22:03:40 -07001231 android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
1232 android.InitDefaultableModule(module)
zhidou198f5892022-02-17 02:33:12 +00001233 android.InitOverridableModule(module, &module.overridableAppProperties.Overrides)
Colin Crossae5caf52018-05-22 11:11:52 -07001234 return module
1235}
Colin Crossbd01e2a2018-10-04 15:21:03 -07001236
Colin Cross252fc6f2018-10-04 15:22:03 -07001237type appTestHelperAppProperties struct {
1238 // list of compatibility suites (for example "cts", "vts") that the module should be
1239 // installed into.
1240 Test_suites []string `android:"arch_variant"`
Dan Shi6ffaaa82019-09-26 11:41:36 -07001241
1242 // Flag to indicate whether or not to create test config automatically. If AndroidTest.xml
1243 // doesn't exist next to the Android.bp, this attribute doesn't need to be set to true
1244 // explicitly.
1245 Auto_gen_config *bool
Colin Crosscfb0f5e2021-09-24 15:47:17 -07001246
1247 // Install the test into a folder named for the module in all test suites.
1248 Per_testcase_directory *bool
Colin Cross252fc6f2018-10-04 15:22:03 -07001249}
1250
1251type AndroidTestHelperApp struct {
1252 AndroidApp
1253
1254 appTestHelperAppProperties appTestHelperAppProperties
1255}
1256
Jaewoong Jung326a9412019-11-21 10:41:00 -08001257func (a *AndroidTestHelperApp) InstallInTestcases() bool {
1258 return true
1259}
1260
Colin Cross1b16b0e2019-02-12 14:41:32 -08001261// android_test_helper_app compiles sources and Android resources into an Android application package `.apk` file that
1262// will be used by tests, but does not produce an `AndroidTest.xml` file so the module will not be run directly as a
1263// test.
Colin Cross252fc6f2018-10-04 15:22:03 -07001264func AndroidTestHelperAppFactory() android.Module {
1265 module := &AndroidTestHelperApp{}
1266
Jared Duke63a3da92022-06-02 19:11:14 +00001267 // TODO(b/192032291): Disable by default after auditing downstream usage.
Liz Kammera7a64f32020-07-09 15:16:41 -07001268 module.Module.dexProperties.Optimize.EnabledByDefault = true
Colin Cross252fc6f2018-10-04 15:22:03 -07001269
1270 module.Module.properties.Installable = proptools.BoolPtr(true)
Colin Crosse4246ab2019-02-05 21:55:21 -08001271 module.appProperties.Use_embedded_native_libs = proptools.BoolPtr(true)
Colin Cross47fa9d32019-03-26 10:51:39 -07001272 module.appProperties.AlwaysPackageNativeLibs = true
Colin Cross43f08db2018-11-12 10:13:39 -08001273 module.Module.dexpreopter.isTest = true
Cole Faustd57e8b22022-08-11 11:59:04 -07001274 module.Module.linter.properties.Lint.Test = proptools.BoolPtr(true)
Colin Cross252fc6f2018-10-04 15:22:03 -07001275
Colin Crossce6734e2020-06-15 16:09:53 -07001276 module.addHostAndDeviceProperties()
Colin Cross252fc6f2018-10-04 15:22:03 -07001277 module.AddProperties(
Colin Cross252fc6f2018-10-04 15:22:03 -07001278 &module.aaptProperties,
1279 &module.appProperties,
Jaewoong Jung525443a2019-02-28 15:35:54 -08001280 &module.appTestHelperAppProperties,
Ulya Trafimovich21a73752020-09-01 17:33:48 +01001281 &module.overridableAppProperties)
Colin Cross252fc6f2018-10-04 15:22:03 -07001282
1283 android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
1284 android.InitDefaultableModule(module)
Anton Hansson3d2b6b42020-01-10 15:06:01 +00001285 android.InitApexModule(module)
Colin Cross252fc6f2018-10-04 15:22:03 -07001286 return module
1287}
1288
Colin Crossbd01e2a2018-10-04 15:21:03 -07001289type AndroidAppCertificate struct {
1290 android.ModuleBase
Rupert Shuttleworth6e4950a2021-07-27 01:34:59 -04001291 android.BazelModuleBase
1292
Colin Crossbd01e2a2018-10-04 15:21:03 -07001293 properties AndroidAppCertificateProperties
Jiyong Parkc00cbd92018-10-30 21:20:05 +09001294 Certificate Certificate
Colin Crossbd01e2a2018-10-04 15:21:03 -07001295}
1296
1297type AndroidAppCertificateProperties struct {
1298 // Name of the certificate files. Extensions .x509.pem and .pk8 will be added to the name.
1299 Certificate *string
1300}
1301
Colin Cross1b16b0e2019-02-12 14:41:32 -08001302// android_app_certificate modules can be referenced by the certificates property of android_app modules to select
1303// the signing key.
Colin Crossbd01e2a2018-10-04 15:21:03 -07001304func AndroidAppCertificateFactory() android.Module {
1305 module := &AndroidAppCertificate{}
1306 module.AddProperties(&module.properties)
1307 android.InitAndroidModule(module)
Rupert Shuttleworth6e4950a2021-07-27 01:34:59 -04001308 android.InitBazelModule(module)
Colin Crossbd01e2a2018-10-04 15:21:03 -07001309 return module
1310}
1311
Colin Crossbd01e2a2018-10-04 15:21:03 -07001312func (c *AndroidAppCertificate) GenerateAndroidBuildActions(ctx android.ModuleContext) {
1313 cert := String(c.properties.Certificate)
Jiyong Parkc00cbd92018-10-30 21:20:05 +09001314 c.Certificate = Certificate{
Colin Cross503c1d02020-01-28 14:00:53 -08001315 Pem: android.PathForModuleSrc(ctx, cert+".x509.pem"),
1316 Key: android.PathForModuleSrc(ctx, cert+".pk8"),
Colin Crossbd01e2a2018-10-04 15:21:03 -07001317 }
1318}
Jaewoong Jung525443a2019-02-28 15:35:54 -08001319
1320type OverrideAndroidApp struct {
1321 android.ModuleBase
1322 android.OverrideModuleBase
1323}
1324
Sasha Smundak613cbb12020-06-05 10:27:23 -07001325func (i *OverrideAndroidApp) GenerateAndroidBuildActions(_ android.ModuleContext) {
Jaewoong Jung525443a2019-02-28 15:35:54 -08001326 // All the overrides happen in the base module.
1327 // TODO(jungjw): Check the base module type.
1328}
1329
1330// override_android_app is used to create an android_app module based on another android_app by overriding
1331// some of its properties.
1332func OverrideAndroidAppModuleFactory() android.Module {
1333 m := &OverrideAndroidApp{}
Jooyung Han01d80d82022-01-08 12:16:32 +09001334 m.AddProperties(
1335 &OverridableDeviceProperties{},
1336 &overridableAppProperties{},
1337 )
Jaewoong Jung525443a2019-02-28 15:35:54 -08001338
Jaewoong Jungb639a6a2019-05-10 15:16:29 -07001339 android.InitAndroidMultiTargetsArchModule(m, android.DeviceSupported, android.MultilibCommon)
Jaewoong Jung525443a2019-02-28 15:35:54 -08001340 android.InitOverrideModule(m)
1341 return m
1342}
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001343
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001344type OverrideAndroidTest struct {
1345 android.ModuleBase
1346 android.OverrideModuleBase
1347}
1348
Sasha Smundak613cbb12020-06-05 10:27:23 -07001349func (i *OverrideAndroidTest) GenerateAndroidBuildActions(_ android.ModuleContext) {
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001350 // All the overrides happen in the base module.
1351 // TODO(jungjw): Check the base module type.
1352}
1353
1354// override_android_test is used to create an android_app module based on another android_test by overriding
1355// some of its properties.
1356func OverrideAndroidTestModuleFactory() android.Module {
1357 m := &OverrideAndroidTest{}
1358 m.AddProperties(&overridableAppProperties{})
1359 m.AddProperties(&appTestProperties{})
1360
1361 android.InitAndroidMultiTargetsArchModule(m, android.DeviceSupported, android.MultilibCommon)
1362 android.InitOverrideModule(m)
1363 return m
1364}
1365
Colin Cross50ddcc42019-05-16 12:28:22 -07001366type UsesLibraryProperties struct {
1367 // A list of shared library modules that will be listed in uses-library tags in the AndroidManifest.xml file.
1368 Uses_libs []string
1369
1370 // A list of shared library modules that will be listed in uses-library tags in the AndroidManifest.xml file with
1371 // required=false.
1372 Optional_uses_libs []string
1373
1374 // If true, the list of uses_libs and optional_uses_libs modules must match the AndroidManifest.xml file. Defaults
1375 // to true if either uses_libs or optional_uses_libs is set. Will unconditionally default to true in the future.
1376 Enforce_uses_libs *bool
Ulya Trafimovich21a73752020-09-01 17:33:48 +01001377
Ulya Trafimovich54027b52020-09-09 14:08:23 +01001378 // Optional name of the <uses-library> provided by this module. This is needed for non-SDK
1379 // libraries, because SDK ones are automatically picked up by Soong. The <uses-library> name
1380 // normally is the same as the module name, but there are exceptions.
1381 Provides_uses_lib *string
Paul Duffin06530572022-02-03 17:54:15 +00001382
1383 // A list of shared library names to exclude from the classpath of the APK. Adding a library here
1384 // will prevent it from being used when precompiling the APK and prevent it from being implicitly
1385 // added to the APK's manifest's <uses-library> elements.
1386 //
1387 // Care must be taken when using this as it could result in runtime errors if the APK actually
1388 // uses classes provided by the library and which are not provided in any other way.
1389 //
1390 // This is primarily intended for use by various CTS tests that check the runtime handling of the
1391 // android.test.base shared library (and related libraries) but which depend on some common
1392 // libraries that depend on the android.test.base library. Without this those tests will end up
1393 // with a <uses-library android:name="android.test.base"/> in their manifest which would either
1394 // render the tests worthless (as they would be testing the wrong behavior), or would break the
1395 // test altogether by providing access to classes that the tests were not expecting. Those tests
1396 // provide the android.test.base statically and use jarjar to rename them so they do not collide
1397 // with the classes provided by the android.test.base library.
1398 Exclude_uses_libs []string
Colin Cross50ddcc42019-05-16 12:28:22 -07001399}
1400
1401// usesLibrary provides properties and helper functions for AndroidApp and AndroidAppImport to verify that the
1402// <uses-library> tags that end up in the manifest of an APK match the ones known to the build system through the
1403// uses_libs and optional_uses_libs properties. The build system's values are used by dexpreopt to preopt apps
1404// with knowledge of their shared libraries.
1405type usesLibrary struct {
1406 usesLibraryProperties UsesLibraryProperties
Ulya Trafimovich22890c42021-01-05 12:04:17 +00001407
1408 // Whether to enforce verify_uses_library check.
1409 enforce bool
Colin Cross50ddcc42019-05-16 12:28:22 -07001410}
1411
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +01001412func (u *usesLibrary) addLib(lib string, optional bool) {
1413 if !android.InList(lib, u.usesLibraryProperties.Uses_libs) && !android.InList(lib, u.usesLibraryProperties.Optional_uses_libs) {
1414 if optional {
1415 u.usesLibraryProperties.Optional_uses_libs = append(u.usesLibraryProperties.Optional_uses_libs, lib)
1416 } else {
1417 u.usesLibraryProperties.Uses_libs = append(u.usesLibraryProperties.Uses_libs, lib)
1418 }
1419 }
1420}
1421
Colin Cross4a80a152022-12-21 21:51:52 -08001422func (u *usesLibrary) deps(ctx android.BottomUpMutatorContext, addCompatDeps bool) {
Jeongik Cha4b073cd2021-06-08 11:35:00 +09001423 if !ctx.Config().UnbundledBuild() || ctx.Config().UnbundledBuildImage() {
Ulya Trafimovichf5d91bb2022-05-04 12:00:02 +01001424 ctx.AddVariationDependencies(nil, usesLibReqTag, u.usesLibraryProperties.Uses_libs...)
1425 ctx.AddVariationDependencies(nil, usesLibOptTag, u.presentOptionalUsesLibs(ctx)...)
Colin Cross4a80a152022-12-21 21:51:52 -08001426 // Only add these extra dependencies if the module is an app that depends on framework
1427 // libs. This avoids creating a cyclic dependency:
Paul Duffin250e6192019-06-07 10:44:37 +01001428 // e.g. framework-res -> org.apache.http.legacy -> ... -> framework-res.
Colin Cross4a80a152022-12-21 21:51:52 -08001429 if addCompatDeps {
Ulya Trafimovichf5d91bb2022-05-04 12:00:02 +01001430 // Dexpreopt needs paths to the dex jars of these libraries in order to construct
1431 // class loader context for dex2oat. Add them as a dependency with a special tag.
1432 ctx.AddVariationDependencies(nil, usesLibCompat29ReqTag, dexpreopt.CompatUsesLibs29...)
1433 ctx.AddVariationDependencies(nil, usesLibCompat28OptTag, dexpreopt.OptionalCompatUsesLibs28...)
1434 ctx.AddVariationDependencies(nil, usesLibCompat30OptTag, dexpreopt.OptionalCompatUsesLibs30...)
Colin Cross3245b2c2019-06-07 13:18:09 -07001435 }
Sam Delmerico9f9c0a22022-11-29 11:19:37 -05001436 } else {
1437 ctx.AddVariationDependencies(nil, r8LibraryJarTag, u.usesLibraryProperties.Uses_libs...)
1438 ctx.AddVariationDependencies(nil, r8LibraryJarTag, u.presentOptionalUsesLibs(ctx)...)
Colin Cross50ddcc42019-05-16 12:28:22 -07001439 }
1440}
1441
Jiakai Zhang4f65a032023-06-01 15:16:58 +01001442// presentOptionalUsesLibs returns optional_uses_libs after filtering out libraries that don't exist in the source tree.
Colin Cross50ddcc42019-05-16 12:28:22 -07001443func (u *usesLibrary) presentOptionalUsesLibs(ctx android.BaseModuleContext) []string {
Jiakai Zhang4f65a032023-06-01 15:16:58 +01001444 optionalUsesLibs := android.FilterListPred(u.usesLibraryProperties.Optional_uses_libs, func(s string) bool {
1445 exists := ctx.OtherModuleExists(s)
Jiakai Zhang48203e32023-06-02 23:42:21 +01001446 if !exists && !android.InList(ctx.ModuleName(), ctx.Config().BuildWarningBadOptionalUsesLibsAllowlist()) {
Jiakai Zhang4f65a032023-06-01 15:16:58 +01001447 fmt.Printf("Warning: Module '%s' depends on non-existing optional_uses_libs '%s'\n", ctx.ModuleName(), s)
1448 }
1449 return exists
1450 })
Colin Cross50ddcc42019-05-16 12:28:22 -07001451 return optionalUsesLibs
1452}
1453
Ulya Trafimovicheea486a2021-02-26 11:38:21 +00001454// Helper function to replace string in a list.
1455func replaceInList(list []string, oldstr, newstr string) {
1456 for i, str := range list {
1457 if str == oldstr {
1458 list[i] = newstr
1459 }
1460 }
1461}
1462
Ulya Trafimovich24446712021-07-15 14:59:34 +01001463// Returns a map of module names of shared library dependencies to the paths to their dex jars on
1464// host and on device.
Ulya Trafimovich8cbc5d22020-11-03 15:15:46 +00001465func (u *usesLibrary) classLoaderContextForUsesLibDeps(ctx android.ModuleContext) dexpreopt.ClassLoaderContextMap {
1466 clcMap := make(dexpreopt.ClassLoaderContextMap)
Ulya Trafimovich24446712021-07-15 14:59:34 +01001467
1468 // Skip when UnbundledBuild() is true, but UnbundledBuildImage() is false. With
1469 // UnbundledBuildImage() it is necessary to generate dexpreopt.config for post-dexpreopting.
1470 if ctx.Config().UnbundledBuild() && !ctx.Config().UnbundledBuildImage() {
1471 return clcMap
Colin Cross50ddcc42019-05-16 12:28:22 -07001472 }
1473
Ulya Trafimovich24446712021-07-15 14:59:34 +01001474 ctx.VisitDirectDeps(func(m android.Module) {
1475 tag, isUsesLibTag := ctx.OtherModuleDependencyTag(m).(usesLibraryDependencyTag)
1476 if !isUsesLibTag {
1477 return
1478 }
1479
Ulya Trafimoviche14f80b2021-07-15 15:05:48 +01001480 dep := android.RemoveOptionalPrebuiltPrefix(ctx.OtherModuleName(m))
Ulya Trafimovich24446712021-07-15 14:59:34 +01001481
Ulya Trafimovich840efb62021-07-15 14:34:40 +01001482 // Skip stub libraries. A dependency on the implementation library has been added earlier,
1483 // so it will be added to CLC, but the stub shouldn't be. Stub libraries can be distingushed
1484 // from implementation libraries by their name, which is different as it has a suffix.
1485 if comp, ok := m.(SdkLibraryComponentDependency); ok {
1486 if impl := comp.OptionalSdkLibraryImplementation(); impl != nil && *impl != dep {
1487 return
1488 }
1489 }
1490
Ulya Trafimovich24446712021-07-15 14:59:34 +01001491 if lib, ok := m.(UsesLibraryDependency); ok {
Ulya Trafimoviche14f80b2021-07-15 15:05:48 +01001492 libName := dep
Ulya Trafimovich24446712021-07-15 14:59:34 +01001493 if ulib, ok := m.(ProvidesUsesLib); ok && ulib.ProvidesUsesLib() != nil {
Ulya Trafimoviche14f80b2021-07-15 15:05:48 +01001494 libName = *ulib.ProvidesUsesLib()
Ulya Trafimovich24446712021-07-15 14:59:34 +01001495 // Replace module name with library name in `uses_libs`/`optional_uses_libs` in
1496 // order to pass verify_uses_libraries check (which compares these properties
1497 // against library names written in the manifest).
1498 replaceInList(u.usesLibraryProperties.Uses_libs, dep, libName)
1499 replaceInList(u.usesLibraryProperties.Optional_uses_libs, dep, libName)
1500 }
Ulya Trafimovichf5d91bb2022-05-04 12:00:02 +01001501 clcMap.AddContext(ctx, tag.sdkVersion, libName, tag.optional,
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01001502 lib.DexJarBuildPath().PathOrNil(), lib.DexJarInstallPath(),
1503 lib.ClassLoaderContexts())
Ulya Trafimovich24446712021-07-15 14:59:34 +01001504 } else if ctx.Config().AllowMissingDependencies() {
1505 ctx.AddMissingDependencies([]string{dep})
1506 } else {
1507 ctx.ModuleErrorf("module %q in uses_libs or optional_uses_libs must be a java library", dep)
1508 }
1509 })
Ulya Trafimovich8cbc5d22020-11-03 15:15:46 +00001510 return clcMap
Colin Cross50ddcc42019-05-16 12:28:22 -07001511}
1512
1513// enforceUsesLibraries returns true of <uses-library> tags should be checked against uses_libs and optional_uses_libs
1514// properties. Defaults to true if either of uses_libs or optional_uses_libs is specified. Will default to true
1515// unconditionally in the future.
1516func (u *usesLibrary) enforceUsesLibraries() bool {
1517 defaultEnforceUsesLibs := len(u.usesLibraryProperties.Uses_libs) > 0 ||
1518 len(u.usesLibraryProperties.Optional_uses_libs) > 0
Ulya Trafimovich22890c42021-01-05 12:04:17 +00001519 return BoolDefault(u.usesLibraryProperties.Enforce_uses_libs, u.enforce || defaultEnforceUsesLibs)
Colin Cross50ddcc42019-05-16 12:28:22 -07001520}
1521
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +01001522// Freeze the value of `enforce_uses_libs` based on the current values of `uses_libs` and `optional_uses_libs`.
1523func (u *usesLibrary) freezeEnforceUsesLibraries() {
1524 enforce := u.enforceUsesLibraries()
1525 u.usesLibraryProperties.Enforce_uses_libs = &enforce
1526}
1527
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001528// verifyUsesLibraries checks the <uses-library> tags in the manifest against the ones specified
1529// in the `uses_libs`/`optional_uses_libs` properties. The input can be either an XML manifest, or
1530// an APK with the manifest embedded in it (manifest_check will know which one it is by the file
1531// extension: APKs are supposed to end with '.apk').
1532func (u *usesLibrary) verifyUsesLibraries(ctx android.ModuleContext, inputFile android.Path,
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001533 outputFile android.WritablePath) android.Path {
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001534
Ulya Trafimovich8c35fcf2021-02-17 16:23:28 +00001535 statusFile := dexpreopt.UsesLibrariesStatusFile(ctx)
Colin Cross50ddcc42019-05-16 12:28:22 -07001536
Ulya Trafimovich6e55ef12021-03-04 12:37:50 +00001537 // Disable verify_uses_libraries check if dexpreopt is globally disabled. Without dexpreopt the
1538 // check is not necessary, and although it is good to have, it is difficult to maintain on
1539 // non-linux build platforms where dexpreopt is generally disabled (the check may fail due to
1540 // various unrelated reasons, such as a failure to get manifest from an APK).
Ulya Trafimovich39dd0a42021-03-29 14:57:34 +01001541 global := dexpreopt.GetGlobalConfig(ctx)
1542 if global.DisablePreopt || global.OnlyPreoptBootImageAndSystemServer {
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001543 return inputFile
Ulya Trafimovich6e55ef12021-03-04 12:37:50 +00001544 }
1545
Colin Crossf1a035e2020-11-16 17:32:30 -08001546 rule := android.NewRuleBuilder(pctx, ctx)
1547 cmd := rule.Command().BuiltTool("manifest_check").
Colin Cross50ddcc42019-05-16 12:28:22 -07001548 Flag("--enforce-uses-libraries").
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001549 Input(inputFile).
Ulya Trafimovich8c35fcf2021-02-17 16:23:28 +00001550 FlagWithOutput("--enforce-uses-libraries-status ", statusFile).
Saeid Farivar Asanjanfd27c7c2022-08-08 20:21:26 +00001551 FlagWithInput("--aapt ", ctx.Config().HostToolPath(ctx, "aapt2"))
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001552
1553 if outputFile != nil {
1554 cmd.FlagWithOutput("-o ", outputFile)
1555 }
Colin Cross50ddcc42019-05-16 12:28:22 -07001556
Ulya Trafimovich8c35fcf2021-02-17 16:23:28 +00001557 if dexpreopt.GetGlobalConfig(ctx).RelaxUsesLibraryCheck {
1558 cmd.Flag("--enforce-uses-libraries-relax")
1559 }
1560
Colin Cross50ddcc42019-05-16 12:28:22 -07001561 for _, lib := range u.usesLibraryProperties.Uses_libs {
1562 cmd.FlagWithArg("--uses-library ", lib)
1563 }
1564
1565 for _, lib := range u.usesLibraryProperties.Optional_uses_libs {
1566 cmd.FlagWithArg("--optional-uses-library ", lib)
1567 }
1568
Colin Crossf1a035e2020-11-16 17:32:30 -08001569 rule.Build("verify_uses_libraries", "verify <uses-library>")
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001570 return outputFile
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001571}
Colin Cross50ddcc42019-05-16 12:28:22 -07001572
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001573// verifyUsesLibrariesManifest checks the <uses-library> tags in an AndroidManifest.xml against
1574// the build system and returns the path to a copy of the manifest.
1575func (u *usesLibrary) verifyUsesLibrariesManifest(ctx android.ModuleContext, manifest android.Path) android.Path {
1576 outputFile := android.PathForModuleOut(ctx, "manifest_check", "AndroidManifest.xml")
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001577 return u.verifyUsesLibraries(ctx, manifest, outputFile)
Colin Cross50ddcc42019-05-16 12:28:22 -07001578}
1579
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001580// verifyUsesLibrariesAPK checks the <uses-library> tags in the manifest of an APK against the build
1581// system and returns the path to a copy of the APK.
Cole Faust2f1da162023-04-17 15:06:56 -07001582func (u *usesLibrary) verifyUsesLibrariesAPK(ctx android.ModuleContext, apk android.Path) {
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001583 u.verifyUsesLibraries(ctx, apk, nil) // for APKs manifest_check does not write output file
Colin Cross50ddcc42019-05-16 12:28:22 -07001584}
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001585
1586// For Bazel / bp2build
1587
1588type bazelAndroidAppCertificateAttributes struct {
1589 Certificate string
1590}
1591
Liz Kammerbe46fcc2021-11-01 15:32:43 -04001592func (m *AndroidAppCertificate) ConvertWithBp2build(ctx android.TopDownMutatorContext) {
1593 androidAppCertificateBp2Build(ctx, m)
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001594}
1595
Liz Kammerbe46fcc2021-11-01 15:32:43 -04001596func androidAppCertificateBp2Build(ctx android.TopDownMutatorContext, module *AndroidAppCertificate) {
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001597 var certificate string
1598 if module.properties.Certificate != nil {
1599 certificate = *module.properties.Certificate
1600 }
1601
1602 attrs := &bazelAndroidAppCertificateAttributes{
1603 Certificate: certificate,
1604 }
1605
1606 props := bazel.BazelTargetModuleProperties{
1607 Rule_class: "android_app_certificate",
Alixa381cd12023-05-10 14:49:38 +00001608 Bzl_load_location: "//build/bazel/rules/android:android_app_certificate.bzl",
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001609 }
1610
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux447f6c92021-08-31 20:30:36 +00001611 ctx.CreateBazelTargetModule(props, android.CommonAttributes{Name: module.Name()}, attrs)
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001612}
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001613
Alixe5085eb2023-01-31 19:38:41 +00001614type manifestValueAttribute struct {
Romain Jobredeaux496660d2023-07-10 11:50:00 -04001615 MinSdkVersion *string
1616 MaxSdkVersion *string
1617 TargetSdkVersion *string
Alixe5085eb2023-01-31 19:38:41 +00001618}
1619
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001620type bazelAndroidAppAttributes struct {
Sam Delmericoc0161432022-02-25 21:34:51 +00001621 *javaCommonAttributes
Romain Jobredeauxc9b2bba2022-02-15 09:35:07 -05001622 *bazelAapt
Sam Delmericoc0161432022-02-25 21:34:51 +00001623 Deps bazel.LabelListAttribute
Sam Delmerico9dfb1392022-02-10 21:11:59 +00001624 Custom_package *string
Jingwen Chen6817bbb2022-10-14 09:56:07 +00001625 Certificate bazel.LabelAttribute
1626 Certificate_name bazel.StringAttribute
Alixe5085eb2023-01-31 19:38:41 +00001627 Manifest_values *manifestValueAttribute
Jingwen Chenbea58092022-09-29 16:56:02 +00001628}
1629
Liz Kammerbe46fcc2021-11-01 15:32:43 -04001630// ConvertWithBp2build is used to convert android_app to Bazel.
1631func (a *AndroidApp) ConvertWithBp2build(ctx android.TopDownMutatorContext) {
Liz Kammer7f375862023-08-04 16:37:42 -04001632 commonAttrs, bp2BuildInfo, supported := a.convertLibraryAttrsBp2Build(ctx)
1633 if !supported {
1634 return
1635 }
Alix8062f4d2022-11-14 21:38:07 +00001636 depLabels := bp2BuildInfo.DepLabels
Sam Delmericoc0161432022-02-25 21:34:51 +00001637
1638 deps := depLabels.Deps
Romain Jobredeauxc9b2bba2022-02-15 09:35:07 -05001639 deps.Append(depLabels.StaticDeps)
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001640
Romain Jobredeaux7a71e072023-08-16 17:39:12 -04001641 aapt, supported := a.convertAaptAttrsWithBp2Build(ctx)
1642 if !supported {
1643 return
1644 }
Jingwen Chen6817bbb2022-10-14 09:56:07 +00001645 certificate, certificateName := android.BazelStringOrLabelFromProp(ctx, a.overridableAppProperties.Certificate)
1646
Alixe5085eb2023-01-31 19:38:41 +00001647 manifestValues := &manifestValueAttribute{}
Alixffdeacb2023-03-20 18:22:45 +00001648 // TODO(b/274474008 ): Directly convert deviceProperties.Min_sdk_version in bp2build
Alixe5085eb2023-01-31 19:38:41 +00001649 // MinSdkVersion(ctx) calls SdkVersion(ctx) if no value for min_sdk_version is set
Spandan Das8c9ae7e2023-03-03 21:20:36 +00001650 minSdkVersion := a.MinSdkVersion(ctx)
1651 if !minSdkVersion.IsPreview() && !minSdkVersion.IsInvalid() {
Romain Jobredeaux496660d2023-07-10 11:50:00 -04001652 if minSdkStr, err := minSdkVersion.EffectiveVersionString(ctx); err == nil {
Alixe5085eb2023-01-31 19:38:41 +00001653 manifestValues.MinSdkVersion = &minSdkStr
1654 }
1655 }
1656
Romain Jobredeaux496660d2023-07-10 11:50:00 -04001657 maxSdkVersion := a.MaxSdkVersion(ctx)
1658 if !maxSdkVersion.IsPreview() && !maxSdkVersion.IsInvalid() {
1659 if maxSdkStr, err := maxSdkVersion.EffectiveVersionString(ctx); err == nil {
1660 manifestValues.MaxSdkVersion = &maxSdkStr
1661 }
1662 }
1663
1664 targetSdkVersion := a.TargetSdkVersion(ctx)
1665 if !targetSdkVersion.IsPreview() && !targetSdkVersion.IsInvalid() {
1666 if targetSdkStr, err := targetSdkVersion.EffectiveVersionString(ctx); err == nil {
1667 manifestValues.TargetSdkVersion = &targetSdkStr
1668 }
1669 }
1670
Alix0856f9e2023-01-20 22:15:30 +00001671 appAttrs := &bazelAndroidAppAttributes{
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001672 // TODO(b/209576404): handle package name override by product variable PRODUCT_MANIFEST_PACKAGE_NAME_OVERRIDES
Alix0856f9e2023-01-20 22:15:30 +00001673 Custom_package: a.overridableAppProperties.Package_name,
1674 Certificate: certificate,
1675 Certificate_name: certificateName,
Alixe5085eb2023-01-31 19:38:41 +00001676 Manifest_values: manifestValues,
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001677 }
Sam Delmerico9dfb1392022-02-10 21:11:59 +00001678
1679 props := bazel.BazelTargetModuleProperties{
1680 Rule_class: "android_binary",
Alixa381cd12023-05-10 14:49:38 +00001681 Bzl_load_location: "//build/bazel/rules/android:android_binary.bzl",
Sam Delmerico9dfb1392022-02-10 21:11:59 +00001682 }
Alix0856f9e2023-01-20 22:15:30 +00001683
Alix75db7842023-03-06 22:08:49 +00001684 if !bp2BuildInfo.hasKotlin {
Alix0856f9e2023-01-20 22:15:30 +00001685 appAttrs.javaCommonAttributes = commonAttrs
1686 appAttrs.bazelAapt = aapt
1687 appAttrs.Deps = deps
Alix0856f9e2023-01-20 22:15:30 +00001688 } else {
1689 ktName := a.Name() + "_kt"
Alix0856f9e2023-01-20 22:15:30 +00001690 ctx.CreateBazelTargetModule(
Alix32540022023-03-16 21:06:13 +00001691 AndroidLibraryBazelTargetModuleProperties(),
Alix0856f9e2023-01-20 22:15:30 +00001692 android.CommonAttributes{Name: ktName},
1693 &bazelAndroidLibrary{
1694 javaLibraryAttributes: &javaLibraryAttributes{
1695 javaCommonAttributes: commonAttrs,
1696 Deps: deps,
1697 },
1698 bazelAapt: aapt,
1699 },
1700 )
1701
1702 appAttrs.bazelAapt = &bazelAapt{Manifest: aapt.Manifest}
1703 appAttrs.Deps = bazel.MakeSingleLabelListAttribute(bazel.Label{Label: ":" + ktName})
Romain Jobredeaux2eef2e12023-02-24 12:07:08 -05001704 appAttrs.javaCommonAttributes = &javaCommonAttributes{
1705 Sdk_version: commonAttrs.Sdk_version,
1706 }
Alix0856f9e2023-01-20 22:15:30 +00001707 }
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001708
Alix733110e2023-02-06 14:53:10 +00001709 ctx.CreateBazelTargetModule(
1710 props,
Romain Jobredeaux56d41d02023-05-09 16:34:16 -04001711 android.CommonAttributes{Name: a.Name(), SkipData: proptools.BoolPtr(true)},
Alix733110e2023-02-06 14:53:10 +00001712 appAttrs,
1713 )
1714
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001715}