blob: a11da4d83809980c2fbe6a82278e27508d303608 [file] [log] [blame]
Colin Cross30e076a2015-04-13 13:58:27 -07001// Copyright 2015 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
Jaewoong Jungf9b44652020-12-21 12:29:12 -080017// This file contains the module implementations for android_app, android_test, and some more
18// related module types, including their override variants.
Colin Cross30e076a2015-04-13 13:58:27 -070019
20import (
Jiakai Zhang4f65a032023-06-01 15:16:58 +010021 "fmt"
Jaewoong Junga5e5abc2019-04-26 14:31:50 -070022 "path/filepath"
Jaewoong Junga5e5abc2019-04-26 14:31:50 -070023 "strings"
Colin Cross30e076a2015-04-13 13:58:27 -070024
Colin Cross50ddcc42019-05-16 12:28:22 -070025 "github.com/google/blueprint"
26 "github.com/google/blueprint/proptools"
27
Colin Cross635c3b02016-05-18 15:37:25 -070028 "android/soong/android"
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -040029 "android/soong/bazel"
Colin Crossa4f08812018-10-02 22:03:40 -070030 "android/soong/cc"
Ulya Trafimovichd4bcea42020-06-03 14:57:22 +010031 "android/soong/dexpreopt"
Romain Jobredeaux9973ace2023-08-30 00:27:09 -040032 "android/soong/genrule"
Colin Cross303e21f2018-08-07 16:49:25 -070033 "android/soong/tradefed"
Spandan Das0e0a8802023-09-20 19:53:30 +000034 "android/soong/ui/metrics/bp2build_metrics_proto"
Colin Cross30e076a2015-04-13 13:58:27 -070035)
36
Colin Cross3bc7ffa2017-11-22 16:19:37 -080037func init() {
Paul Duffinf9b1da02019-12-18 19:51:55 +000038 RegisterAppBuildComponents(android.InitRegistrationContext)
Andrei Onea580636b2022-08-17 16:53:46 +000039 pctx.HostBinToolVariable("ModifyAllowlistCmd", "modify_permissions_allowlist")
Colin Cross3bc7ffa2017-11-22 16:19:37 -080040}
41
Andrei Onea580636b2022-08-17 16:53:46 +000042var (
43 modifyAllowlist = pctx.AndroidStaticRule("modifyAllowlist",
44 blueprint.RuleParams{
45 Command: "${ModifyAllowlistCmd} $in $packageName $out",
46 CommandDeps: []string{"${ModifyAllowlistCmd}"},
47 }, "packageName")
48)
49
Paul Duffinf9b1da02019-12-18 19:51:55 +000050func RegisterAppBuildComponents(ctx android.RegistrationContext) {
51 ctx.RegisterModuleType("android_app", AndroidAppFactory)
52 ctx.RegisterModuleType("android_test", AndroidTestFactory)
53 ctx.RegisterModuleType("android_test_helper_app", AndroidTestHelperAppFactory)
54 ctx.RegisterModuleType("android_app_certificate", AndroidAppCertificateFactory)
55 ctx.RegisterModuleType("override_android_app", OverrideAndroidAppModuleFactory)
56 ctx.RegisterModuleType("override_android_test", OverrideAndroidTestModuleFactory)
Paul Duffinf9b1da02019-12-18 19:51:55 +000057}
58
Colin Cross30e076a2015-04-13 13:58:27 -070059// AndroidManifest.xml merging
60// package splits
61
Colin Crossfabb6082018-02-20 17:22:23 -080062type appProperties struct {
Colin Crossbd01e2a2018-10-04 15:21:03 -070063 // Names of extra android_app_certificate modules to sign the apk with in the form ":module".
Colin Cross7d5136f2015-05-11 13:39:40 -070064 Additional_certificates []string
65
66 // If set, create package-export.apk, which other packages can
67 // use to get PRODUCT-agnostic resource data like IDs and type definitions.
Nan Zhangea568a42017-11-08 21:20:04 -080068 Export_package_resources *bool
Colin Cross7d5136f2015-05-11 13:39:40 -070069
Colin Cross16056062017-12-13 22:46:28 -080070 // Specifies that this app should be installed to the priv-app directory,
71 // where the system will grant it additional privileges not available to
72 // normal apps.
73 Privileged *bool
Colin Crossa97c5d32018-03-28 14:58:31 -070074
75 // list of resource labels to generate individual resource packages
76 Package_splits []string
Jason Monkd4122be2018-08-10 09:33:36 -040077
Colin Crossa4f08812018-10-02 22:03:40 -070078 // list of native libraries that will be provided in or alongside the resulting jar
79 Jni_libs []string `android:"arch_variant"`
80
Colin Cross7204cf02020-05-06 17:51:39 -070081 // if true, use JNI libraries that link against platform APIs even if this module sets
Colin Crossee87c602020-02-19 16:57:15 -080082 // sdk_version.
83 Jni_uses_platform_apis *bool
84
Colin Cross7204cf02020-05-06 17:51:39 -070085 // if true, use JNI libraries that link against SDK APIs even if this module does not set
86 // sdk_version.
87 Jni_uses_sdk_apis *bool
88
Jaewoong Jungbc625cd2019-05-06 15:48:44 -070089 // STL library to use for JNI libraries.
90 Stl *string `android:"arch_variant"`
91
Colin Crosse4246ab2019-02-05 21:55:21 -080092 // Store native libraries uncompressed in the APK and set the android:extractNativeLibs="false" manifest
93 // flag so that they are used from inside the APK at runtime. Defaults to true for android_test modules unless
Jiyong Park52cd06f2019-11-11 10:14:32 +090094 // sdk_version or min_sdk_version is set to a version that doesn't support it (<23), defaults to true for
95 // android_app modules that are embedded to APEXes, defaults to false for other module types where the native
96 // libraries are generally preinstalled outside the APK.
Colin Crosse4246ab2019-02-05 21:55:21 -080097 Use_embedded_native_libs *bool
Colin Cross46abdad2019-02-07 13:07:08 -080098
99 // Store dex files uncompressed in the APK and set the android:useEmbeddedDex="true" manifest attribute so that
100 // they are used from inside the APK at runtime.
101 Use_embedded_dex *bool
Colin Cross47fa9d32019-03-26 10:51:39 -0700102
103 // Forces native libraries to always be packaged into the APK,
104 // Use_embedded_native_libs still selects whether they are stored uncompressed and aligned or compressed.
105 // True for android_test* modules.
106 AlwaysPackageNativeLibs bool `blueprint:"mutated"`
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700107
108 // If set, find and merge all NOTICE files that this module and its dependencies have and store
109 // it in the APK as an asset.
110 Embed_notices *bool
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700111
112 // cc.Coverage related properties
113 PreventInstall bool `blueprint:"mutated"`
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700114 IsCoverageVariant bool `blueprint:"mutated"`
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100115
Harshit Mahajan5b8b7302022-06-10 11:24:05 +0000116 // It can be set to test the behaviour of default target sdk version.
117 // Only required when updatable: false. It is an error if updatable: true and this is false.
118 Enforce_default_target_sdk_version *bool
119
120 // If set, the targetSdkVersion for the target is set to the latest default API level.
121 // This would be by default false, unless updatable: true or
122 // enforce_default_target_sdk_version: true in which case this defaults to true.
123 EnforceDefaultTargetSdkVersion bool `blueprint:"mutated"`
124
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100125 // Whether this app is considered mainline updatable or not. When set to true, this will enforce
Artur Satayevf40fc852020-04-16 13:43:02 +0100126 // additional rules to make sure an app can safely be updated. Default is false.
127 // Prefer using other specific properties if build behaviour must be changed; avoid using this
128 // flag for anything but neverallow rules (unless the behaviour change is invisible to owners).
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100129 Updatable *bool
Andrei Onea580636b2022-08-17 16:53:46 +0000130
131 // Specifies the file that contains the allowlist for this app.
132 Privapp_allowlist *string `android:"path"`
Inseob Kim34dc4cd2023-11-07 13:37:14 +0900133
134 // If set, create an RRO package which contains only resources having PRODUCT_CHARACTERISTICS
135 // and install the RRO package to /product partition, instead of passing --product argument
136 // to aapt2. Default is false.
137 // Setting this will make this APK identical to all targets, regardless of
138 // PRODUCT_CHARACTERISTICS.
139 Generate_product_characteristics_rro *bool
140
141 ProductCharacteristicsRROPackageName *string `blueprint:"mutated"`
142 ProductCharacteristicsRROManifestModuleName *string `blueprint:"mutated"`
Colin Cross7d5136f2015-05-11 13:39:40 -0700143}
144
Jaewoong Jung525443a2019-02-28 15:35:54 -0800145// android_app properties that can be overridden by override_android_app
146type overridableAppProperties struct {
147 // The name of a certificate in the default certificate directory, blank to use the default product certificate,
148 // or an android_app_certificate module name in the form ":module".
149 Certificate *string
Jaewoong Jung6f373f62019-03-13 10:13:24 -0700150
Jaewoong Jung1c1b6e62021-03-09 15:02:31 -0800151 // Name of the signing certificate lineage file or filegroup module.
152 Lineage *string `android:"path"`
Liz Kammere2b27f42020-05-07 13:24:05 -0700153
Rupert Shuttleworth8eab8692021-11-03 10:39:39 -0400154 // For overriding the --rotation-min-sdk-version property of apksig
155 RotationMinSdkVersion *string
156
Jaewoong Jung6f373f62019-03-13 10:13:24 -0700157 // the package name of this app. The package name in the manifest file is used if one was not given.
158 Package_name *string
Baligh Uddin5b16dfb2020-02-11 17:27:19 -0800159
160 // the logging parent of this app.
161 Logging_parent *string
Liz Kammer9f9fd022020-06-18 19:44:06 +0000162
163 // Whether to rename the package in resources to the override name rather than the base name. Defaults to true.
164 Rename_resources_package *bool
zhidou198f5892022-02-17 02:33:12 +0000165
166 // Names of modules to be overridden. Listed modules can only be other binaries
167 // (in Make or Soong).
168 // This does not completely prevent installation of the overridden binaries, but if both
169 // binaries would be installed by default (in PRODUCT_PACKAGES) the other binary will be removed
170 // from PRODUCT_PACKAGES.
171 Overrides []string
Jaewoong Jung525443a2019-02-28 15:35:54 -0800172}
173
Colin Cross30e076a2015-04-13 13:58:27 -0700174type AndroidApp struct {
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400175 android.BazelModuleBase
Colin Crossa97c5d32018-03-28 14:58:31 -0700176 Library
177 aapt
Jaewoong Jung525443a2019-02-28 15:35:54 -0800178 android.OverridableModuleBase
Colin Crossa97c5d32018-03-28 14:58:31 -0700179
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900180 certificate Certificate
Colin Cross30e076a2015-04-13 13:58:27 -0700181
Colin Crossfabb6082018-02-20 17:22:23 -0800182 appProperties appProperties
Colin Crossae5caf52018-05-22 11:11:52 -0700183
Jaewoong Jung525443a2019-02-28 15:35:54 -0800184 overridableAppProperties overridableAppProperties
185
Colin Cross403cc152020-07-06 14:15:24 -0700186 jniLibs []jniLib
187 installPathForJNISymbols android.Path
188 embeddedJniLibs bool
189 jniCoverageOutputs android.Paths
Colin Crossf6237212018-10-29 23:14:58 -0700190
191 bundleFile android.Path
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800192
193 // the install APK name is normally the same as the module name, but can be overridden with PRODUCT_PACKAGE_NAME_OVERRIDES.
194 installApkName string
Jaewoong Jung4102e5d2019-02-27 16:26:28 -0800195
Colin Cross70dda7e2019-10-01 22:05:35 -0700196 installDir android.InstallPath
Jaewoong Jung0949f312019-09-11 10:25:18 -0700197
Jaewoong Jung7dd4ae22019-09-27 17:13:15 -0700198 onDeviceDir string
199
Jaewoong Jung4102e5d2019-02-27 16:26:28 -0800200 additionalAaptFlags []string
Jaewoong Jung98772792019-07-01 17:15:13 -0700201
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900202 overriddenManifestPackageName string
Artur Satayev1111b842020-04-27 19:05:28 +0100203
204 android.ApexBundleDepsInfo
Matt Banda8c801262022-04-01 17:48:31 +0000205
206 javaApiUsedByOutputFile android.ModuleOutPath
Andrei Onea580636b2022-08-17 16:53:46 +0000207
208 privAppAllowlist android.OptionalPath
Colin Crosse1731a52017-12-14 11:22:55 -0800209}
210
Martin Stjernholm6d415272020-01-31 17:10:36 +0000211func (a *AndroidApp) IsInstallable() bool {
212 return Bool(a.properties.Installable)
213}
214
Colin Crossab8d1382023-07-14 17:23:41 +0000215func (a *AndroidApp) ResourcesNodeDepSet() *android.DepSet[*resourcesNode] {
216 return a.aapt.resourcesNodesDepSet
Colin Cross66f78822018-05-02 12:58:28 -0700217}
218
Sundong Ahne1f05aa2019-08-27 13:55:42 +0900219func (a *AndroidApp) OutputFile() android.Path {
220 return a.outputFile
221}
222
Colin Cross503c1d02020-01-28 14:00:53 -0800223func (a *AndroidApp) Certificate() Certificate {
224 return a.certificate
225}
226
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700227func (a *AndroidApp) JniCoverageOutputs() android.Paths {
228 return a.jniCoverageOutputs
229}
230
Andrei Onea580636b2022-08-17 16:53:46 +0000231func (a *AndroidApp) PrivAppAllowlist() android.OptionalPath {
232 return a.privAppAllowlist
233}
234
Colin Crossa97c5d32018-03-28 14:58:31 -0700235var _ AndroidLibraryDependency = (*AndroidApp)(nil)
236
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900237type Certificate struct {
Colin Cross503c1d02020-01-28 14:00:53 -0800238 Pem, Key android.Path
239 presigned bool
240}
241
Sasha Smundak18d98bc2020-05-27 16:36:07 -0700242var PresignedCertificate = Certificate{presigned: true}
Colin Cross503c1d02020-01-28 14:00:53 -0800243
244func (c Certificate) AndroidMkString() string {
245 if c.presigned {
246 return "PRESIGNED"
247 } else {
248 return c.Pem.String()
249 }
Colin Cross30e076a2015-04-13 13:58:27 -0700250}
251
Colin Cross46c9b8b2017-06-22 16:51:17 -0700252func (a *AndroidApp) DepsMutator(ctx android.BottomUpMutatorContext) {
253 a.Module.deps(ctx)
Colin Crossa4f08812018-10-02 22:03:40 -0700254
Jiyong Park92315372021-04-02 08:45:46 +0900255 if String(a.appProperties.Stl) == "c++_shared" && !a.SdkVersion(ctx).Specified() {
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700256 ctx.PropertyErrorf("stl", "sdk_version must be set in order to use c++_shared")
257 }
258
Jiyong Parkf1691d22021-03-29 20:11:58 +0900259 sdkDep := decodeSdkDep(ctx, android.SdkContext(a))
Paul Duffin250e6192019-06-07 10:44:37 +0100260 if sdkDep.hasFrameworkLibs() {
261 a.aapt.deps(ctx, sdkDep)
Colin Cross30e076a2015-04-13 13:58:27 -0700262 }
Colin Crossa4f08812018-10-02 22:03:40 -0700263
Jiyong Park92315372021-04-02 08:45:46 +0900264 usesSDK := a.SdkVersion(ctx).Specified() && a.SdkVersion(ctx).Kind != android.SdkCorePlatform
Colin Cross3c007702020-05-08 11:20:24 -0700265
266 if usesSDK && Bool(a.appProperties.Jni_uses_sdk_apis) {
267 ctx.PropertyErrorf("jni_uses_sdk_apis",
268 "can only be set for modules that do not set sdk_version")
269 } else if !usesSDK && Bool(a.appProperties.Jni_uses_platform_apis) {
270 ctx.PropertyErrorf("jni_uses_platform_apis",
271 "can only be set for modules that set sdk_version")
272 }
273
Colin Crossa4f08812018-10-02 22:03:40 -0700274 for _, jniTarget := range ctx.MultiTargets() {
Colin Cross0f7d2ef2019-10-16 11:03:10 -0700275 variation := append(jniTarget.Variations(),
276 blueprint.Variation{Mutator: "link", Variation: "shared"})
Colin Crossc511bc52020-04-07 16:50:32 +0000277
278 // If the app builds against an Android SDK use the SDK variant of JNI dependencies
279 // unless jni_uses_platform_apis is set.
Colin Crossc2d24052020-05-13 11:05:02 -0700280 // Don't require the SDK variant for apps that are shipped on vendor, etc., as they already
281 // have stable APIs through the VNDK.
282 if (usesSDK && !a.RequiresStableAPIs(ctx) &&
283 !Bool(a.appProperties.Jni_uses_platform_apis)) ||
Colin Cross7204cf02020-05-06 17:51:39 -0700284 Bool(a.appProperties.Jni_uses_sdk_apis) {
Colin Crossc511bc52020-04-07 16:50:32 +0000285 variation = append(variation, blueprint.Variation{Mutator: "sdk", Variation: "sdk"})
286 }
Colin Crossde78d132020-10-09 18:59:49 -0700287 ctx.AddFarVariationDependencies(variation, jniLibTag, a.appProperties.Jni_libs...)
Colin Crossa4f08812018-10-02 22:03:40 -0700288 }
Colin Cross50ddcc42019-05-16 12:28:22 -0700289
Paul Duffin250e6192019-06-07 10:44:37 +0100290 a.usesLibrary.deps(ctx, sdkDep.hasFrameworkLibs())
Jaewoong Jungb639a6a2019-05-10 15:16:29 -0700291}
Colin Crossbd01e2a2018-10-04 15:21:03 -0700292
Jaewoong Jungb639a6a2019-05-10 15:16:29 -0700293func (a *AndroidApp) OverridablePropertiesDepsMutator(ctx android.BottomUpMutatorContext) {
Jaewoong Jung2ad817c2019-01-18 14:27:16 -0800294 cert := android.SrcIsModule(a.getCertString(ctx))
Colin Crossbd01e2a2018-10-04 15:21:03 -0700295 if cert != "" {
296 ctx.AddDependency(ctx.Module(), certificateTag, cert)
297 }
298
Andrei Onea580636b2022-08-17 16:53:46 +0000299 if a.appProperties.Privapp_allowlist != nil && !Bool(a.appProperties.Privileged) {
Anton Hanssone3f31cf2023-06-03 08:53:47 +0000300 // There are a few uids that are explicitly considered privileged regardless of their
301 // app's location. Bluetooth is one such app. It should arguably be moved to priv-app,
302 // but for now, allow it not to be in priv-app.
303 privilegedBecauseOfUid := ctx.ModuleName() == "Bluetooth"
304 if !privilegedBecauseOfUid {
305 ctx.PropertyErrorf("privapp_allowlist", "privileged must be set in order to use privapp_allowlist (with a few exceptions)")
306 }
Andrei Onea580636b2022-08-17 16:53:46 +0000307 }
308
Colin Crossbd01e2a2018-10-04 15:21:03 -0700309 for _, cert := range a.appProperties.Additional_certificates {
310 cert = android.SrcIsModule(cert)
311 if cert != "" {
312 ctx.AddDependency(ctx.Module(), certificateTag, cert)
313 } else {
314 ctx.PropertyErrorf("additional_certificates",
315 `must be names of android_app_certificate modules in the form ":module"`)
316 }
317 }
Colin Cross30e076a2015-04-13 13:58:27 -0700318}
319
Jeongik Cha538c0d02019-07-11 15:54:27 +0900320func (a *AndroidTestHelperApp) GenerateAndroidBuildActions(ctx android.ModuleContext) {
Alix96ea88452023-08-31 15:48:23 +0000321 applicationId := a.appTestHelperAppProperties.Manifest_values.ApplicationId
322 if applicationId != nil {
323 if a.overridableAppProperties.Package_name != nil {
324 ctx.PropertyErrorf("manifest_values.applicationId", "property is not supported when property package_name is set.")
325 }
326 a.aapt.manifestValues.applicationId = *applicationId
327 }
Jeongik Cha538c0d02019-07-11 15:54:27 +0900328 a.generateAndroidBuildActions(ctx)
329}
330
Colin Cross46c9b8b2017-06-22 16:51:17 -0700331func (a *AndroidApp) GenerateAndroidBuildActions(ctx android.ModuleContext) {
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100332 a.checkAppSdkVersions(ctx)
Colin Crossae5caf52018-05-22 11:11:52 -0700333 a.generateAndroidBuildActions(ctx)
Matt Banda8c801262022-04-01 17:48:31 +0000334 a.generateJavaUsedByApex(ctx)
Colin Crossae5caf52018-05-22 11:11:52 -0700335}
336
Sam Delmerico0e0d96e2023-08-18 22:43:28 +0000337func (a *AndroidApp) MinSdkVersion(ctx android.EarlyModuleContext) android.ApiLevel {
338 defaultMinSdkVersion := a.Module.MinSdkVersion(ctx)
339 if proptools.Bool(a.appProperties.Updatable) {
340 overrideApiLevel := android.MinSdkVersionFromValue(ctx, ctx.DeviceConfig().ApexGlobalMinSdkVersionOverride())
341 if !overrideApiLevel.IsNone() && overrideApiLevel.CompareTo(defaultMinSdkVersion) > 0 {
342 return overrideApiLevel
343 }
344 }
345 return defaultMinSdkVersion
346}
347
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100348func (a *AndroidApp) checkAppSdkVersions(ctx android.ModuleContext) {
Artur Satayev849f8442020-04-28 14:57:42 +0100349 if a.Updatable() {
Jiyong Park92315372021-04-02 08:45:46 +0900350 if !a.SdkVersion(ctx).Stable() {
351 ctx.PropertyErrorf("sdk_version", "Updatable apps must use stable SDKs, found %v", a.SdkVersion(ctx))
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100352 }
Artur Satayevf40fc852020-04-16 13:43:02 +0100353 if String(a.deviceProperties.Min_sdk_version) == "" {
354 ctx.PropertyErrorf("updatable", "updatable apps must set min_sdk_version.")
355 }
Jooyung Han749dc692020-04-15 11:03:39 +0900356
Jiyong Park92315372021-04-02 08:45:46 +0900357 if minSdkVersion, err := a.MinSdkVersion(ctx).EffectiveVersion(ctx); err == nil {
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900358 a.checkJniLibsSdkVersion(ctx, minSdkVersion)
satayevb3fd4112021-12-02 13:59:35 +0000359 android.CheckMinSdkVersion(ctx, minSdkVersion, a.WalkPayloadDeps)
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900360 } else {
361 ctx.PropertyErrorf("min_sdk_version", "%s", err.Error())
362 }
Harshit Mahajan5b8b7302022-06-10 11:24:05 +0000363
364 if !BoolDefault(a.appProperties.Enforce_default_target_sdk_version, true) {
365 ctx.PropertyErrorf("enforce_default_target_sdk_version", "Updatable apps must enforce default target sdk version")
366 }
367 // TODO(b/227460469) after all the modules removes the target sdk version, throw an error if the target sdk version is explicitly set.
368 if a.deviceProperties.Target_sdk_version == nil {
369 a.SetEnforceDefaultTargetSdkVersion(true)
370 }
371 }
372
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100373 a.checkPlatformAPI(ctx)
374 a.checkSdkVersions(ctx)
375}
376
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900377// If an updatable APK sets min_sdk_version, min_sdk_vesion of JNI libs should match with it.
378// This check is enforced for "updatable" APKs (including APK-in-APEX).
Jiyong Park54105c42021-03-31 18:17:53 +0900379func (a *AndroidApp) checkJniLibsSdkVersion(ctx android.ModuleContext, minSdkVersion android.ApiLevel) {
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900380 // It's enough to check direct JNI deps' sdk_version because all transitive deps from JNI deps are checked in cc.checkLinkType()
381 ctx.VisitDirectDeps(func(m android.Module) {
382 if !IsJniDepTag(ctx.OtherModuleDependencyTag(m)) {
383 return
384 }
385 dep, _ := m.(*cc.Module)
Jooyung Han652d5b32020-05-20 17:12:13 +0900386 // The domain of cc.sdk_version is "current" and <number>
Jiyong Parkf1691d22021-03-29 20:11:58 +0900387 // We can rely on android.SdkSpec to convert it to <number> so that "current" is
388 // handled properly regardless of sdk finalization.
Spandan Das2e8c0442022-05-08 00:39:35 +0000389 jniSdkVersion, err := android.SdkSpecFrom(ctx, dep.MinSdkVersion()).EffectiveVersion(ctx)
Jiyong Park54105c42021-03-31 18:17:53 +0900390 if err != nil || minSdkVersion.LessThan(jniSdkVersion) {
Spandan Das2e8c0442022-05-08 00:39:35 +0000391 ctx.OtherModuleErrorf(dep, "min_sdk_version(%v) is higher than min_sdk_version(%v) of the containing android_app(%v)",
392 dep.MinSdkVersion(), minSdkVersion, ctx.ModuleName())
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900393 return
394 }
395
396 })
397}
398
Sasha Smundak6ad77252019-05-01 13:16:22 -0700399// Returns true if the native libraries should be stored in the APK uncompressed and the
Colin Crosse4246ab2019-02-05 21:55:21 -0800400// extractNativeLibs application flag should be set to false in the manifest.
Sasha Smundak6ad77252019-05-01 13:16:22 -0700401func (a *AndroidApp) useEmbeddedNativeLibs(ctx android.ModuleContext) bool {
Jiyong Park92315372021-04-02 08:45:46 +0900402 minSdkVersion, err := a.MinSdkVersion(ctx).EffectiveVersion(ctx)
Colin Crosse4246ab2019-02-05 21:55:21 -0800403 if err != nil {
Jiyong Park92315372021-04-02 08:45:46 +0900404 ctx.PropertyErrorf("min_sdk_version", "invalid value %q: %s", a.MinSdkVersion(ctx), err)
Colin Crosse4246ab2019-02-05 21:55:21 -0800405 }
406
Colin Cross56a83212020-09-15 18:30:11 -0700407 apexInfo := ctx.Provider(android.ApexInfoProvider).(android.ApexInfo)
Jiyong Park54105c42021-03-31 18:17:53 +0900408 return (minSdkVersion.FinalOrFutureInt() >= 23 && Bool(a.appProperties.Use_embedded_native_libs)) ||
Colin Cross56a83212020-09-15 18:30:11 -0700409 !apexInfo.IsForPlatform()
Colin Crosse4246ab2019-02-05 21:55:21 -0800410}
411
Colin Cross43f08db2018-11-12 10:13:39 -0800412// Returns whether this module should have the dex file stored uncompressed in the APK.
413func (a *AndroidApp) shouldUncompressDex(ctx android.ModuleContext) bool {
Colin Cross46abdad2019-02-07 13:07:08 -0800414 if Bool(a.appProperties.Use_embedded_dex) {
415 return true
416 }
417
Colin Cross53a87f52019-06-25 13:35:30 -0700418 // Uncompress dex in APKs of privileged apps (even for unbundled builds, they may
419 // be preinstalled as prebuilts).
Jiyong Parkf7487312019-10-17 12:54:30 +0900420 if ctx.Config().UncompressPrivAppDex() && a.Privileged() {
Nicolas Geoffrayfa6e9ec2019-02-12 13:12:16 +0000421 return true
422 }
423
Colin Cross53a87f52019-06-25 13:35:30 -0700424 if ctx.Config().UnbundledBuild() {
425 return false
426 }
427
Jaewoong Jungacf18d72019-05-02 14:55:29 -0700428 return shouldUncompressDex(ctx, &a.dexpreopter)
Colin Cross5a0dcd52018-10-05 14:20:06 -0700429}
430
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700431func (a *AndroidApp) shouldEmbedJnis(ctx android.BaseModuleContext) bool {
Colin Cross56a83212020-09-15 18:30:11 -0700432 apexInfo := ctx.Provider(android.ApexInfoProvider).(android.ApexInfo)
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700433 return ctx.Config().UnbundledBuild() || Bool(a.appProperties.Use_embedded_native_libs) ||
Colin Cross56a83212020-09-15 18:30:11 -0700434 !apexInfo.IsForPlatform() || a.appProperties.AlwaysPackageNativeLibs
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700435}
436
Liz Kammer9f9fd022020-06-18 19:44:06 +0000437func generateAaptRenamePackageFlags(packageName string, renameResourcesPackage bool) []string {
438 aaptFlags := []string{"--rename-manifest-package " + packageName}
439 if renameResourcesPackage {
440 // Required to rename the package name in the resources table.
441 aaptFlags = append(aaptFlags, "--rename-resources-package "+packageName)
442 }
443 return aaptFlags
444}
445
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900446func (a *AndroidApp) OverriddenManifestPackageName() string {
447 return a.overriddenManifestPackageName
448}
449
Liz Kammer9f9fd022020-06-18 19:44:06 +0000450func (a *AndroidApp) renameResourcesPackage() bool {
451 return proptools.BoolDefault(a.overridableAppProperties.Rename_resources_package, true)
452}
453
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800454func (a *AndroidApp) aaptBuildActions(ctx android.ModuleContext) {
Lorenzo Colittifa9b3f32021-03-30 10:38:26 +0900455 usePlatformAPI := proptools.Bool(a.Module.deviceProperties.Platform_apis)
Jiyong Park92315372021-04-02 08:45:46 +0900456 if ctx.Module().(android.SdkContext).SdkVersion(ctx).Kind == android.SdkModule {
Lorenzo Colittifa9b3f32021-03-30 10:38:26 +0900457 usePlatformAPI = true
458 }
459 a.aapt.usesNonSdkApis = usePlatformAPI
David Brazdild25060a2019-02-18 18:24:16 +0000460
Jaewoong Jungc27ab662019-05-30 15:51:14 -0700461 // Ask manifest_fixer to add or update the application element indicating this app has no code.
462 a.aapt.hasNoCode = !a.hasCode(ctx)
463
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800464 aaptLinkFlags := []string{}
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800465
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800466 // Add TARGET_AAPT_CHARACTERISTICS values to AAPT link flags if they exist and --product flags were not provided.
Inseob Kim34dc4cd2023-11-07 13:37:14 +0900467 autogenerateRRO := proptools.Bool(a.appProperties.Generate_product_characteristics_rro)
Jaewoong Jung3aff5782020-02-11 07:54:35 -0800468 hasProduct := android.PrefixInList(a.aaptProperties.Aaptflags, "--product")
Inseob Kim34dc4cd2023-11-07 13:37:14 +0900469 if !autogenerateRRO && !hasProduct && len(ctx.Config().ProductAAPTCharacteristics()) > 0 {
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800470 aaptLinkFlags = append(aaptLinkFlags, "--product", ctx.Config().ProductAAPTCharacteristics())
Colin Crosse78dcd32018-04-19 15:25:19 -0700471 }
472
Dan Willemsen72be5902018-10-24 20:24:57 -0700473 if !Bool(a.aaptProperties.Aapt_include_all_resources) {
474 // Product AAPT config
475 for _, aaptConfig := range ctx.Config().ProductAAPTConfig() {
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800476 aaptLinkFlags = append(aaptLinkFlags, "-c", aaptConfig)
Dan Willemsen72be5902018-10-24 20:24:57 -0700477 }
Colin Crosse78dcd32018-04-19 15:25:19 -0700478
Dan Willemsen72be5902018-10-24 20:24:57 -0700479 // Product AAPT preferred config
480 if len(ctx.Config().ProductAAPTPreferredConfig()) > 0 {
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800481 aaptLinkFlags = append(aaptLinkFlags, "--preferred-density", ctx.Config().ProductAAPTPreferredConfig())
Dan Willemsen72be5902018-10-24 20:24:57 -0700482 }
Colin Crosse78dcd32018-04-19 15:25:19 -0700483 }
484
Jiyong Park7f67f482019-01-05 12:57:48 +0900485 manifestPackageName, overridden := ctx.DeviceConfig().OverrideManifestPackageNameFor(ctx.ModuleName())
Jaewoong Jung6f373f62019-03-13 10:13:24 -0700486 if overridden || a.overridableAppProperties.Package_name != nil {
487 // The product override variable has a priority over the package_name property.
488 if !overridden {
489 manifestPackageName = *a.overridableAppProperties.Package_name
490 }
Liz Kammer9f9fd022020-06-18 19:44:06 +0000491 aaptLinkFlags = append(aaptLinkFlags, generateAaptRenamePackageFlags(manifestPackageName, a.renameResourcesPackage())...)
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900492 a.overriddenManifestPackageName = manifestPackageName
Jiyong Park7f67f482019-01-05 12:57:48 +0900493 }
494
Jaewoong Jung4102e5d2019-02-27 16:26:28 -0800495 aaptLinkFlags = append(aaptLinkFlags, a.additionalAaptFlags...)
496
Colin Crosse560c4a2019-03-19 16:03:11 -0700497 a.aapt.splitNames = a.appProperties.Package_splits
Baligh Uddin5b16dfb2020-02-11 17:27:19 -0800498 a.aapt.LoggingParent = String(a.overridableAppProperties.Logging_parent)
Alexei Nicoara69cf0f32022-07-27 14:59:18 +0100499 if a.Updatable() {
500 a.aapt.defaultManifestVersion = android.DefaultUpdatableModuleVersion
501 }
Alixf7a10272023-09-27 16:47:56 +0000502 a.aapt.buildActions(ctx,
503 aaptBuildActionOptions{
504 android.SdkContext(a),
505 a.classLoaderContexts,
506 a.usesLibraryProperties.Exclude_uses_libs,
507 a.enforceDefaultTargetSdkVersion(),
508 aaptLinkFlags,
509 },
510 )
Colin Cross30e076a2015-04-13 13:58:27 -0700511
Colin Cross46c9b8b2017-06-22 16:51:17 -0700512 // apps manifests are handled by aapt, don't let Module see them
Dan Willemsen34cc69e2015-09-23 15:26:20 -0700513 a.properties.Manifest = nil
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800514}
Colin Cross30e076a2015-04-13 13:58:27 -0700515
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800516func (a *AndroidApp) proguardBuildActions(ctx android.ModuleContext) {
Colin Cross89c31582018-04-30 15:55:11 -0700517 var staticLibProguardFlagFiles android.Paths
518 ctx.VisitDirectDeps(func(m android.Module) {
Sam Delmerico95d70942023-08-02 18:00:35 -0400519 depProguardInfo := ctx.OtherModuleProvider(m, ProguardSpecInfoProvider).(ProguardSpecInfo)
520 staticLibProguardFlagFiles = append(staticLibProguardFlagFiles, depProguardInfo.UnconditionallyExportedProguardFlags.ToList()...)
521 if ctx.OtherModuleDependencyTag(m) == staticLibTag {
522 staticLibProguardFlagFiles = append(staticLibProguardFlagFiles, depProguardInfo.ProguardFlagsFiles.ToList()...)
Colin Cross89c31582018-04-30 15:55:11 -0700523 }
524 })
525
526 staticLibProguardFlagFiles = android.FirstUniquePaths(staticLibProguardFlagFiles)
527
528 a.Module.extraProguardFlagFiles = append(a.Module.extraProguardFlagFiles, staticLibProguardFlagFiles...)
529 a.Module.extraProguardFlagFiles = append(a.Module.extraProguardFlagFiles, a.proguardOptionsFile)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800530}
Colin Cross66dbc0b2017-12-28 12:23:20 -0800531
Colin Cross403cc152020-07-06 14:15:24 -0700532func (a *AndroidApp) installPath(ctx android.ModuleContext) android.InstallPath {
Colin Cross43f08db2018-11-12 10:13:39 -0800533 var installDir string
534 if ctx.ModuleName() == "framework-res" {
535 // framework-res.apk is installed as system/framework/framework-res.apk
536 installDir = "framework"
Jiyong Parkf7487312019-10-17 12:54:30 +0900537 } else if a.Privileged() {
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800538 installDir = filepath.Join("priv-app", a.installApkName)
Colin Cross43f08db2018-11-12 10:13:39 -0800539 } else {
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800540 installDir = filepath.Join("app", a.installApkName)
Colin Cross43f08db2018-11-12 10:13:39 -0800541 }
Colin Cross403cc152020-07-06 14:15:24 -0700542
543 return android.PathForModuleInstall(ctx, installDir, a.installApkName+".apk")
544}
545
Rico Winda9fd59a2023-11-03 10:26:38 +0000546func (a *AndroidApp) dexBuildActions(ctx android.ModuleContext) android.Path {
Colin Cross403cc152020-07-06 14:15:24 -0700547 a.dexpreopter.installPath = a.installPath(ctx)
Ulya Trafimovich76b08522021-01-14 17:52:43 +0000548 a.dexpreopter.isApp = true
Liz Kammera7a64f32020-07-09 15:16:41 -0700549 if a.dexProperties.Uncompress_dex == nil {
David Srbeckye033cba2020-05-20 22:20:28 +0100550 // If the value was not force-set by the user, use reasonable default based on the module.
Liz Kammera7a64f32020-07-09 15:16:41 -0700551 a.dexProperties.Uncompress_dex = proptools.BoolPtr(a.shouldUncompressDex(ctx))
David Srbeckye033cba2020-05-20 22:20:28 +0100552 }
Liz Kammera7a64f32020-07-09 15:16:41 -0700553 a.dexpreopter.uncompressedDex = *a.dexProperties.Uncompress_dex
Colin Cross50ddcc42019-05-16 12:28:22 -0700554 a.dexpreopter.enforceUsesLibs = a.usesLibrary.enforceUsesLibraries()
Ulya Trafimovichb23d28c2020-10-08 12:53:58 +0100555 a.dexpreopter.classLoaderContexts = a.classLoaderContexts
Colin Cross50ddcc42019-05-16 12:28:22 -0700556 a.dexpreopter.manifestFile = a.mergedManifestFile
Colin Crossfa9bfcd2021-11-10 16:42:38 -0800557 a.dexpreopter.preventInstall = a.appProperties.PreventInstall
Colin Cross50ddcc42019-05-16 12:28:22 -0700558
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800559 if ctx.ModuleName() != "framework-res" {
Colin Cross4eae06d2023-06-20 22:40:02 -0700560 var extraSrcJars android.Paths
561 var extraClasspathJars android.Paths
562 var extraCombinedJars android.Paths
563 if a.useResourceProcessorBusyBox() {
564 // When building an app with ResourceProcessorBusyBox enabled ResourceProcessorBusyBox has already
565 // created R.class files that provide IDs for resources in busybox/R.jar. Pass that file in the
566 // classpath when compiling everything else, and add it to the final classes jar.
567 extraClasspathJars = android.Paths{a.aapt.rJar}
568 extraCombinedJars = android.Paths{a.aapt.rJar}
569 } else {
570 // When building an app without ResourceProcessorBusyBox the aapt2 rule creates R.srcjar containing
571 // R.java files for the app's package and the packages from all transitive static android_library
572 // dependencies. Compile the srcjar alongside the rest of the sources.
573 extraSrcJars = android.Paths{a.aapt.aaptSrcJar}
574 }
575
576 a.Module.compile(ctx, extraSrcJars, extraClasspathJars, extraCombinedJars)
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800577 }
Colin Cross30e076a2015-04-13 13:58:27 -0700578
Rico Winda9fd59a2023-11-03 10:26:38 +0000579 return a.dexJarFile.PathOrNil()
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800580}
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800581
Sam Delmerico82602492022-06-10 17:05:42 +0000582func (a *AndroidApp) jniBuildActions(jniLibs []jniLib, prebuiltJniPackages android.Paths, ctx android.ModuleContext) android.WritablePath {
Colin Crossa4f08812018-10-02 22:03:40 -0700583 var jniJarFile android.WritablePath
Sam Delmerico82602492022-06-10 17:05:42 +0000584 if len(jniLibs) > 0 || len(prebuiltJniPackages) > 0 {
Colin Cross403cc152020-07-06 14:15:24 -0700585 a.jniLibs = jniLibs
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700586 if a.shouldEmbedJnis(ctx) {
Colin Crossa4f08812018-10-02 22:03:40 -0700587 jniJarFile = android.PathForModuleOut(ctx, "jnilibs.zip")
Colin Crossc68db4b2021-11-11 18:59:15 -0800588 a.installPathForJNISymbols = a.installPath(ctx)
Sam Delmerico82602492022-06-10 17:05:42 +0000589 TransformJniLibsToJar(ctx, jniJarFile, jniLibs, prebuiltJniPackages, a.useEmbeddedNativeLibs(ctx))
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700590 for _, jni := range jniLibs {
591 if jni.coverageFile.Valid() {
Jaewoong Jung46984ee2020-04-07 13:07:55 -0700592 // Only collect coverage for the first target arch if this is a multilib target.
593 // TODO(jungjw): Ideally, we want to collect both reports, but that would cause coverage
594 // data file path collisions since the current coverage file path format doesn't contain
595 // arch-related strings. This is fine for now though; the code coverage team doesn't use
596 // multi-arch targets such as test_suite_* for coverage collections yet.
597 //
598 // Work with the team to come up with a new format that handles multilib modules properly
599 // and change this.
600 if len(ctx.Config().Targets[android.Android]) == 1 ||
Jaewoong Jung642916f2020-10-09 17:25:15 -0700601 ctx.Config().AndroidFirstDeviceTarget.Arch.ArchType == jni.target.Arch.ArchType {
Jaewoong Jung46984ee2020-04-07 13:07:55 -0700602 a.jniCoverageOutputs = append(a.jniCoverageOutputs, jni.coverageFile.Path())
603 }
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700604 }
605 }
Colin Cross403cc152020-07-06 14:15:24 -0700606 a.embeddedJniLibs = true
Colin Crossa4f08812018-10-02 22:03:40 -0700607 }
608 }
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800609 return jniJarFile
610}
Colin Crossa4f08812018-10-02 22:03:40 -0700611
Colin Cross403cc152020-07-06 14:15:24 -0700612func (a *AndroidApp) JNISymbolsInstalls(installPath string) android.RuleBuilderInstalls {
613 var jniSymbols android.RuleBuilderInstalls
614 for _, jniLib := range a.jniLibs {
615 if jniLib.unstrippedFile != nil {
616 jniSymbols = append(jniSymbols, android.RuleBuilderInstall{
617 From: jniLib.unstrippedFile,
618 To: filepath.Join(installPath, targetToJniDir(jniLib.target), jniLib.unstrippedFile.Base()),
619 })
620 }
621 }
622 return jniSymbols
623}
624
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700625// Reads and prepends a main cert from the default cert dir if it hasn't been set already, i.e. it
626// isn't a cert module reference. Also checks and enforces system cert restriction if applicable.
Colin Crossbc2c8a72022-09-14 12:45:42 -0700627func processMainCert(m android.ModuleBase, certPropValue string, certificates []Certificate,
628 ctx android.ModuleContext) (mainCertificate Certificate, allCertificates []Certificate) {
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700629 if android.SrcIsModule(certPropValue) == "" {
630 var mainCert Certificate
631 if certPropValue != "" {
632 defaultDir := ctx.Config().DefaultAppCertificateDir(ctx)
633 mainCert = Certificate{
Colin Cross503c1d02020-01-28 14:00:53 -0800634 Pem: defaultDir.Join(ctx, certPropValue+".x509.pem"),
635 Key: defaultDir.Join(ctx, certPropValue+".pk8"),
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700636 }
637 } else {
638 pem, key := ctx.Config().DefaultAppCertificate(ctx)
Colin Cross503c1d02020-01-28 14:00:53 -0800639 mainCert = Certificate{
640 Pem: pem,
641 Key: key,
642 }
Colin Crossbd01e2a2018-10-04 15:21:03 -0700643 }
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700644 certificates = append([]Certificate{mainCert}, certificates...)
Colin Crossbd01e2a2018-10-04 15:21:03 -0700645 }
646
Colin Crossbc2c8a72022-09-14 12:45:42 -0700647 if len(certificates) > 0 {
648 mainCertificate = certificates[0]
649 } else {
650 // This can be reached with an empty certificate list if AllowMissingDependencies is set
651 // and the certificate property for this module is a module reference to a missing module.
652 if !ctx.Config().AllowMissingDependencies() && len(ctx.GetMissingDependencies()) > 0 {
653 panic("Should only get here if AllowMissingDependencies set and there are missing dependencies")
654 }
655 // Set a certificate to avoid panics later when accessing it.
656 mainCertificate = Certificate{
657 Key: android.PathForModuleOut(ctx, "missing.pk8"),
Colin Crossa54f4b52022-11-21 04:35:53 +0000658 Pem: android.PathForModuleOut(ctx, "missing.x509.pem"),
Colin Crossbc2c8a72022-09-14 12:45:42 -0700659 }
660 }
661
Zyan Wub7550aa2023-05-18 15:46:31 +0800662 if !m.Platform() {
663 certPath := mainCertificate.Pem.String()
664 systemCertPath := ctx.Config().DefaultAppCertificateDir(ctx).String()
665 if strings.HasPrefix(certPath, systemCertPath) {
666 enforceSystemCert := ctx.Config().EnforceSystemCertificate()
667 allowed := ctx.Config().EnforceSystemCertificateAllowList()
668
669 if enforceSystemCert && !inList(m.Name(), allowed) {
670 ctx.PropertyErrorf("certificate", "The module in product partition cannot be signed with certificate in system.")
671 }
672 }
673 }
674
Colin Crossbc2c8a72022-09-14 12:45:42 -0700675 return mainCertificate, certificates
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800676}
677
Jooyung Han39ee1192020-03-23 20:21:11 +0900678func (a *AndroidApp) InstallApkName() string {
679 return a.installApkName
680}
681
Sam Delmerico15809f82023-05-15 17:21:47 -0400682func (a *AndroidApp) createPrivappAllowlist(ctx android.ModuleContext) android.Path {
Andrei Onea580636b2022-08-17 16:53:46 +0000683 if a.appProperties.Privapp_allowlist == nil {
684 return nil
685 }
Sam Delmerico15809f82023-05-15 17:21:47 -0400686
687 isOverrideApp := a.GetOverriddenBy() != ""
688 if !isOverrideApp {
689 // if this is not an override, we don't need to rewrite the existing privapp allowlist
690 return android.PathForModuleSrc(ctx, *a.appProperties.Privapp_allowlist)
691 }
692
Andrei Onea580636b2022-08-17 16:53:46 +0000693 if a.overridableAppProperties.Package_name == nil {
694 ctx.PropertyErrorf("privapp_allowlist", "package_name must be set to use privapp_allowlist")
695 }
Sam Delmerico15809f82023-05-15 17:21:47 -0400696
Andrei Onea580636b2022-08-17 16:53:46 +0000697 packageName := *a.overridableAppProperties.Package_name
698 fileName := "privapp_allowlist_" + packageName + ".xml"
699 outPath := android.PathForModuleOut(ctx, fileName).OutputPath
700 ctx.Build(pctx, android.BuildParams{
701 Rule: modifyAllowlist,
702 Input: android.PathForModuleSrc(ctx, *a.appProperties.Privapp_allowlist),
703 Output: outPath,
704 Args: map[string]string{
705 "packageName": packageName,
706 },
707 })
708 return &outPath
709}
710
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800711func (a *AndroidApp) generateAndroidBuildActions(ctx android.ModuleContext) {
Colin Cross50ddcc42019-05-16 12:28:22 -0700712 var apkDeps android.Paths
713
Colin Cross56a83212020-09-15 18:30:11 -0700714 if !ctx.Provider(android.ApexInfoProvider).(android.ApexInfo).IsForPlatform() {
715 a.hideApexVariantFromMake = true
716 }
717
Jeongik Cha538c0d02019-07-11 15:54:27 +0900718 a.aapt.useEmbeddedNativeLibs = a.useEmbeddedNativeLibs(ctx)
719 a.aapt.useEmbeddedDex = Bool(a.appProperties.Use_embedded_dex)
720
Jihoon Kang1bfb6f22023-07-01 00:13:47 +0000721 // Unlike installApkName, a.stem should respect base module name for override_android_app.
722 // Therefore, use ctx.ModuleName() instead of a.Name().
723 a.stem = proptools.StringDefault(a.overridableDeviceProperties.Stem, ctx.ModuleName())
724
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800725 // Check if the install APK name needs to be overridden.
Jihoon Kang1bfb6f22023-07-01 00:13:47 +0000726 // Both android_app and override_android_app module are expected to possess
727 // its module bound apk path. However, override_android_app inherits ctx.ModuleName()
728 // from the base module. Therefore, use a.Name() which represents
729 // the module name for both android_app and override_android_app.
730 a.installApkName = ctx.DeviceConfig().OverridePackageNameFor(
731 proptools.StringDefault(a.overridableDeviceProperties.Stem, a.Name()))
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800732
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700733 if ctx.ModuleName() == "framework-res" {
734 // framework-res.apk is installed as system/framework/framework-res.apk
Jaewoong Jung0949f312019-09-11 10:25:18 -0700735 a.installDir = android.PathForModuleInstall(ctx, "framework")
Jiyong Parkf7487312019-10-17 12:54:30 +0900736 } else if a.Privileged() {
Jaewoong Jung0949f312019-09-11 10:25:18 -0700737 a.installDir = android.PathForModuleInstall(ctx, "priv-app", a.installApkName)
738 } else if ctx.InstallInTestcases() {
Jaewoong Jung326a9412019-11-21 10:41:00 -0800739 a.installDir = android.PathForModuleInstall(ctx, a.installApkName, ctx.DeviceConfig().DeviceArch())
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700740 } else {
Jaewoong Jung0949f312019-09-11 10:25:18 -0700741 a.installDir = android.PathForModuleInstall(ctx, "app", a.installApkName)
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700742 }
Jaewoong Jung7dd4ae22019-09-27 17:13:15 -0700743 a.onDeviceDir = android.InstallPathToOnDevicePath(ctx, a.installDir)
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700744
Ulya Trafimovichb23d28c2020-10-08 12:53:58 +0100745 a.classLoaderContexts = a.usesLibrary.classLoaderContextForUsesLibDeps(ctx)
Ulya Trafimovich18554242020-11-03 15:55:11 +0000746
Colin Cross61fb62e2022-06-23 10:46:28 -0700747 var noticeAssetPath android.WritablePath
748 if Bool(a.appProperties.Embed_notices) || ctx.Config().IsEnvTrue("ALWAYS_EMBED_NOTICES") {
749 // The rule to create the notice file can't be generated yet, as the final output path
750 // for the apk isn't known yet. Add the path where the notice file will be generated to the
751 // aapt rules now before calling aaptBuildActions, the rule to create the notice file will
752 // be generated later.
753 noticeAssetPath = android.PathForModuleOut(ctx, "NOTICE", "NOTICE.html.gz")
754 a.aapt.noticeFile = android.OptionalPathForPath(noticeAssetPath)
755 }
756
Harshit Mahajan8f202ad2023-01-09 20:45:55 +0000757 // For apps targeting latest target_sdk_version
758 if Bool(a.appProperties.Enforce_default_target_sdk_version) {
759 a.SetEnforceDefaultTargetSdkVersion(true)
760 }
761
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800762 // Process all building blocks, from AAPT to certificates.
763 a.aaptBuildActions(ctx)
Rico Winda9fd59a2023-11-03 10:26:38 +0000764
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +0100765 // The decision to enforce <uses-library> checks is made before adding implicit SDK libraries.
766 a.usesLibrary.freezeEnforceUsesLibraries()
767
768 // Add implicit SDK libraries to <uses-library> list.
Ulya Trafimovichfc0f6e32021-08-12 16:16:11 +0100769 requiredUsesLibs, optionalUsesLibs := a.classLoaderContexts.UsesLibs()
770 for _, usesLib := range requiredUsesLibs {
771 a.usesLibrary.addLib(usesLib, false)
772 }
773 for _, usesLib := range optionalUsesLibs {
774 a.usesLibrary.addLib(usesLib, true)
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +0100775 }
776
777 // Check that the <uses-library> list is coherent with the manifest.
Colin Cross50ddcc42019-05-16 12:28:22 -0700778 if a.usesLibrary.enforceUsesLibraries() {
779 manifestCheckFile := a.usesLibrary.verifyUsesLibrariesManifest(ctx, a.mergedManifestFile)
780 apkDeps = append(apkDeps, manifestCheckFile)
781 }
782
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800783 a.proguardBuildActions(ctx)
784
Colin Cross014489c2020-06-02 20:09:13 -0700785 a.linter.mergedManifest = a.aapt.mergedManifestFile
786 a.linter.manifest = a.aapt.manifestPath
787 a.linter.resources = a.aapt.resourceFiles
Colin Crossc0efd1d2020-07-03 11:56:24 -0700788 a.linter.buildModuleReportZip = ctx.Config().UnbundledBuildApps()
Colin Cross014489c2020-06-02 20:09:13 -0700789
Rico Winda9fd59a2023-11-03 10:26:38 +0000790 dexJarFile := a.dexBuildActions(ctx)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800791
Colin Crossbc2c8a72022-09-14 12:45:42 -0700792 jniLibs, prebuiltJniPackages, certificates := collectAppDeps(ctx, a, a.shouldEmbedJnis(ctx), !Bool(a.appProperties.Jni_uses_platform_apis))
Sam Delmerico82602492022-06-10 17:05:42 +0000793 jniJarFile := a.jniBuildActions(jniLibs, prebuiltJniPackages, ctx)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800794
795 if ctx.Failed() {
796 return
797 }
798
Colin Crossbc2c8a72022-09-14 12:45:42 -0700799 a.certificate, certificates = processMainCert(a.ModuleBase, a.getCertString(ctx), certificates, ctx)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800800
801 // Build a final signed app package.
Jaewoong Jung5a498812019-11-07 14:14:38 -0800802 packageFile := android.PathForModuleOut(ctx, a.installApkName+".apk")
Songchun Fan17d69e32020-03-24 20:32:24 -0700803 v4SigningRequested := Bool(a.Module.deviceProperties.V4_signature)
804 var v4SignatureFile android.WritablePath = nil
805 if v4SigningRequested {
806 v4SignatureFile = android.PathForModuleOut(ctx, a.installApkName+".apk.idsig")
807 }
Liz Kammere2b27f42020-05-07 13:24:05 -0700808 var lineageFile android.Path
809 if lineage := String(a.overridableAppProperties.Lineage); lineage != "" {
810 lineageFile = android.PathForModuleSrc(ctx, lineage)
811 }
Rupert Shuttleworth8eab8692021-11-03 10:39:39 -0400812 rotationMinSdkVersion := String(a.overridableAppProperties.RotationMinSdkVersion)
813
Rico Winda9fd59a2023-11-03 10:26:38 +0000814 CreateAndSignAppPackage(ctx, packageFile, a.exportPackage, jniJarFile, dexJarFile, certificates, apkDeps, v4SignatureFile, lineageFile, rotationMinSdkVersion, Bool(a.dexProperties.Optimize.Shrink_resources))
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800815 a.outputFile = packageFile
Songchun Fan17d69e32020-03-24 20:32:24 -0700816 if v4SigningRequested {
817 a.extraOutputFiles = append(a.extraOutputFiles, v4SignatureFile)
818 }
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800819
Colin Cross61fb62e2022-06-23 10:46:28 -0700820 if a.aapt.noticeFile.Valid() {
821 // Generating the notice file rule has to be here after a.outputFile is known.
Bob Badoureef4c1c2022-05-16 12:20:04 -0700822 noticeFile := android.PathForModuleOut(ctx, "NOTICE.html.gz")
Bob Badourc6ec9fb2022-06-08 15:59:35 -0700823 android.BuildNoticeHtmlOutputFromLicenseMetadata(
824 ctx, noticeFile, "", "",
825 []string{
826 a.installDir.String() + "/",
827 android.PathForModuleInstall(ctx).String() + "/",
828 a.outputFile.String(),
829 })
Bob Badoureef4c1c2022-05-16 12:20:04 -0700830 builder := android.NewRuleBuilder(pctx, ctx)
831 builder.Command().Text("cp").
832 Input(noticeFile).
833 Output(noticeAssetPath)
834 builder.Build("notice_dir", "Building notice dir")
Bob Badoureef4c1c2022-05-16 12:20:04 -0700835 }
836
Colin Crosse560c4a2019-03-19 16:03:11 -0700837 for _, split := range a.aapt.splits {
838 // Sign the split APKs
Jaewoong Jung5a498812019-11-07 14:14:38 -0800839 packageFile := android.PathForModuleOut(ctx, a.installApkName+"_"+split.suffix+".apk")
Songchun Fan17d69e32020-03-24 20:32:24 -0700840 if v4SigningRequested {
841 v4SignatureFile = android.PathForModuleOut(ctx, a.installApkName+"_"+split.suffix+".apk.idsig")
842 }
Rico Winda9fd59a2023-11-03 10:26:38 +0000843 CreateAndSignAppPackage(ctx, packageFile, split.path, nil, nil, certificates, apkDeps, v4SignatureFile, lineageFile, rotationMinSdkVersion, false)
Colin Crosse560c4a2019-03-19 16:03:11 -0700844 a.extraOutputFiles = append(a.extraOutputFiles, packageFile)
Songchun Fan17d69e32020-03-24 20:32:24 -0700845 if v4SigningRequested {
846 a.extraOutputFiles = append(a.extraOutputFiles, v4SignatureFile)
847 }
Colin Crosse560c4a2019-03-19 16:03:11 -0700848 }
849
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800850 // Build an app bundle.
Colin Crossf6237212018-10-29 23:14:58 -0700851 bundleFile := android.PathForModuleOut(ctx, "base.zip")
852 BuildBundleModule(ctx, bundleFile, a.exportPackage, jniJarFile, dexJarFile)
853 a.bundleFile = bundleFile
854
Andrei Onea580636b2022-08-17 16:53:46 +0000855 allowlist := a.createPrivappAllowlist(ctx)
856 if allowlist != nil {
857 a.privAppAllowlist = android.OptionalPathForPath(allowlist)
858 }
859
Colin Cross56a83212020-09-15 18:30:11 -0700860 apexInfo := ctx.Provider(android.ApexInfoProvider).(android.ApexInfo)
861
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800862 // Install the app package.
Andrei Onea580636b2022-08-17 16:53:46 +0000863 shouldInstallAppPackage := (Bool(a.Module.properties.Installable) || ctx.Host()) && apexInfo.IsForPlatform() && !a.appProperties.PreventInstall
864 if shouldInstallAppPackage {
Sam Delmericob1daccd2023-05-25 14:45:30 -0400865 if a.privAppAllowlist.Valid() {
Anton Hansson0e486a42023-06-01 16:38:35 +0000866 allowlistInstallPath := android.PathForModuleInstall(ctx, "etc", "permissions")
867 allowlistInstallFilename := a.installApkName + ".xml"
868 ctx.InstallFile(allowlistInstallPath, allowlistInstallFilename, a.privAppAllowlist.Path())
Sam Delmericob1daccd2023-05-25 14:45:30 -0400869 }
870
Colin Cross1d0eb7a2021-11-03 14:08:20 -0700871 var extraInstalledPaths android.Paths
Jiyong Park8ba50f92019-11-13 15:01:01 +0900872 for _, extra := range a.extraOutputFiles {
Colin Cross1d0eb7a2021-11-03 14:08:20 -0700873 installed := ctx.InstallFile(a.installDir, extra.Base(), extra)
874 extraInstalledPaths = append(extraInstalledPaths, installed)
Jiyong Park8ba50f92019-11-13 15:01:01 +0900875 }
Colin Cross1d0eb7a2021-11-03 14:08:20 -0700876 ctx.InstallFile(a.installDir, a.outputFile.Base(), a.outputFile, extraInstalledPaths...)
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800877 }
Artur Satayev1111b842020-04-27 19:05:28 +0100878
879 a.buildAppDependencyInfo(ctx)
Colin Cross30e076a2015-04-13 13:58:27 -0700880}
881
Colin Crossc2d24052020-05-13 11:05:02 -0700882type appDepsInterface interface {
Jiyong Park92315372021-04-02 08:45:46 +0900883 SdkVersion(ctx android.EarlyModuleContext) android.SdkSpec
Spandan Das8c9ae7e2023-03-03 21:20:36 +0000884 MinSdkVersion(ctx android.EarlyModuleContext) android.ApiLevel
Colin Crossc2d24052020-05-13 11:05:02 -0700885 RequiresStableAPIs(ctx android.BaseModuleContext) bool
886}
887
888func collectAppDeps(ctx android.ModuleContext, app appDepsInterface,
889 shouldCollectRecursiveNativeDeps bool,
Sam Delmerico82602492022-06-10 17:05:42 +0000890 checkNativeSdkVersion bool) ([]jniLib, android.Paths, []Certificate) {
Colin Crossc2d24052020-05-13 11:05:02 -0700891
Colin Crossa4f08812018-10-02 22:03:40 -0700892 var jniLibs []jniLib
Sam Delmerico82602492022-06-10 17:05:42 +0000893 var prebuiltJniPackages android.Paths
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900894 var certificates []Certificate
Peter Collingbournead84f972019-12-17 16:46:18 -0800895 seenModulePaths := make(map[string]bool)
Colin Crossa4f08812018-10-02 22:03:40 -0700896
Colin Crossc2d24052020-05-13 11:05:02 -0700897 if checkNativeSdkVersion {
Jiyong Park92315372021-04-02 08:45:46 +0900898 checkNativeSdkVersion = app.SdkVersion(ctx).Specified() &&
899 app.SdkVersion(ctx).Kind != android.SdkCorePlatform && !app.RequiresStableAPIs(ctx)
Colin Crossc2d24052020-05-13 11:05:02 -0700900 }
901
Peter Collingbournead84f972019-12-17 16:46:18 -0800902 ctx.WalkDeps(func(module android.Module, parent android.Module) bool {
Colin Crossa4f08812018-10-02 22:03:40 -0700903 otherName := ctx.OtherModuleName(module)
904 tag := ctx.OtherModuleDependencyTag(module)
905
Colin Crossf0913fb2020-07-29 12:59:39 -0700906 if IsJniDepTag(tag) || cc.IsSharedDepTag(tag) {
Ivan Lozano7f67c2a2022-06-27 16:00:26 -0400907 if dep, ok := module.(cc.LinkableInterface); ok {
Colin Cross95f1ca02020-10-29 20:47:22 -0700908 if dep.IsNdk(ctx.Config()) || dep.IsStubs() {
Peter Collingbournead84f972019-12-17 16:46:18 -0800909 return false
910 }
911
Colin Crossa4f08812018-10-02 22:03:40 -0700912 lib := dep.OutputFile()
913 if lib.Valid() {
Cole Faust64cb7c92021-09-14 17:32:49 -0700914 path := lib.Path()
915 if seenModulePaths[path.String()] {
916 return false
917 }
918 seenModulePaths[path.String()] = true
919
920 if checkNativeSdkVersion && dep.SdkVersion() == "" {
921 ctx.PropertyErrorf("jni_libs", "JNI dependency %q uses platform APIs, but this module does not",
922 otherName)
923 }
924
Colin Crossa4f08812018-10-02 22:03:40 -0700925 jniLibs = append(jniLibs, jniLib{
Colin Cross403cc152020-07-06 14:15:24 -0700926 name: ctx.OtherModuleName(module),
927 path: path,
928 target: module.Target(),
929 coverageFile: dep.CoverageOutputFile(),
930 unstrippedFile: dep.UnstrippedOutputFile(),
Jihoon Kangf78a8902022-09-01 22:47:07 +0000931 partition: dep.Partition(),
Colin Crossa4f08812018-10-02 22:03:40 -0700932 })
Colin Crossdd5261c2022-12-19 12:26:43 -0800933 } else if ctx.Config().AllowMissingDependencies() {
934 ctx.AddMissingDependencies([]string{otherName})
Colin Crossa4f08812018-10-02 22:03:40 -0700935 } else {
936 ctx.ModuleErrorf("dependency %q missing output file", otherName)
937 }
938 } else {
939 ctx.ModuleErrorf("jni_libs dependency %q must be a cc library", otherName)
Colin Crossa4f08812018-10-02 22:03:40 -0700940 }
Peter Collingbournead84f972019-12-17 16:46:18 -0800941
942 return shouldCollectRecursiveNativeDeps
943 }
944
Sam Delmerico82602492022-06-10 17:05:42 +0000945 if info, ok := ctx.OtherModuleProvider(module, JniPackageProvider).(JniPackageInfo); ok {
946 prebuiltJniPackages = append(prebuiltJniPackages, info.JniPackages...)
947 }
948
Peter Collingbournead84f972019-12-17 16:46:18 -0800949 if tag == certificateTag {
Colin Crossbd01e2a2018-10-04 15:21:03 -0700950 if dep, ok := module.(*AndroidAppCertificate); ok {
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900951 certificates = append(certificates, dep.Certificate)
Colin Crossbd01e2a2018-10-04 15:21:03 -0700952 } else {
953 ctx.ModuleErrorf("certificate dependency %q must be an android_app_certificate module", otherName)
954 }
Colin Crossa4f08812018-10-02 22:03:40 -0700955 }
Peter Collingbournead84f972019-12-17 16:46:18 -0800956
957 return false
Colin Crossa4f08812018-10-02 22:03:40 -0700958 })
959
Sam Delmerico82602492022-06-10 17:05:42 +0000960 return jniLibs, prebuiltJniPackages, certificates
Colin Crossa4f08812018-10-02 22:03:40 -0700961}
962
Jooyung Han749dc692020-04-15 11:03:39 +0900963func (a *AndroidApp) WalkPayloadDeps(ctx android.ModuleContext, do android.PayloadDepsCallback) {
Artur Satayev1111b842020-04-27 19:05:28 +0100964 ctx.WalkDeps(func(child, parent android.Module) bool {
965 isExternal := !a.DepIsInSameApex(ctx, child)
966 if am, ok := child.(android.ApexModule); ok {
Jooyung Han749dc692020-04-15 11:03:39 +0900967 if !do(ctx, parent, am, isExternal) {
968 return false
969 }
Artur Satayev1111b842020-04-27 19:05:28 +0100970 }
971 return !isExternal
972 })
973}
974
975func (a *AndroidApp) buildAppDependencyInfo(ctx android.ModuleContext) {
976 if ctx.Host() {
977 return
978 }
979
980 depsInfo := android.DepNameToDepInfoMap{}
Jooyung Han749dc692020-04-15 11:03:39 +0900981 a.WalkPayloadDeps(ctx, func(ctx android.ModuleContext, from blueprint.Module, to android.ApexModule, externalDep bool) bool {
Artur Satayev1111b842020-04-27 19:05:28 +0100982 depName := to.Name()
Artur Satayev533b98c2021-03-11 18:03:42 +0000983
984 // Skip dependencies that are only available to APEXes; they are developed with updatability
985 // in mind and don't need manual approval.
986 if to.(android.ApexModule).NotAvailableForPlatform() {
987 return true
988 }
989
Artur Satayev1111b842020-04-27 19:05:28 +0100990 if info, exist := depsInfo[depName]; exist {
991 info.From = append(info.From, from.Name())
992 info.IsExternal = info.IsExternal && externalDep
993 depsInfo[depName] = info
994 } else {
995 toMinSdkVersion := "(no version)"
Jiyong Park92315372021-04-02 08:45:46 +0900996 if m, ok := to.(interface {
Spandan Das8c9ae7e2023-03-03 21:20:36 +0000997 MinSdkVersion(ctx android.EarlyModuleContext) android.ApiLevel
Jiyong Park92315372021-04-02 08:45:46 +0900998 }); ok {
Spandan Das8c9ae7e2023-03-03 21:20:36 +0000999 if v := m.MinSdkVersion(ctx); !v.IsNone() {
1000 toMinSdkVersion = v.String()
Artur Satayev1111b842020-04-27 19:05:28 +01001001 }
Jiyong Park92315372021-04-02 08:45:46 +09001002 } else if m, ok := to.(interface{ MinSdkVersion() string }); ok {
1003 // TODO(b/175678607) eliminate the use of MinSdkVersion returning
1004 // string
1005 if v := m.MinSdkVersion(); v != "" {
Jiyong Parkf1691d22021-03-29 20:11:58 +09001006 toMinSdkVersion = v
1007 }
Artur Satayev1111b842020-04-27 19:05:28 +01001008 }
1009 depsInfo[depName] = android.ApexModuleDepInfo{
1010 To: depName,
1011 From: []string{from.Name()},
1012 IsExternal: externalDep,
1013 MinSdkVersion: toMinSdkVersion,
1014 }
1015 }
Jooyung Han749dc692020-04-15 11:03:39 +09001016 return true
Artur Satayev1111b842020-04-27 19:05:28 +01001017 })
1018
Jiyong Park92315372021-04-02 08:45:46 +09001019 a.ApexBundleDepsInfo.BuildDepsInfoLists(ctx, a.MinSdkVersion(ctx).String(), depsInfo)
Artur Satayev1111b842020-04-27 19:05:28 +01001020}
1021
Harshit Mahajan5b8b7302022-06-10 11:24:05 +00001022func (a *AndroidApp) enforceDefaultTargetSdkVersion() bool {
1023 return a.appProperties.EnforceDefaultTargetSdkVersion
1024}
1025
1026func (a *AndroidApp) SetEnforceDefaultTargetSdkVersion(val bool) {
1027 a.appProperties.EnforceDefaultTargetSdkVersion = val
1028}
1029
Artur Satayev849f8442020-04-28 14:57:42 +01001030func (a *AndroidApp) Updatable() bool {
Colin Cross56a83212020-09-15 18:30:11 -07001031 return Bool(a.appProperties.Updatable)
Artur Satayev849f8442020-04-28 14:57:42 +01001032}
1033
Spandan Das42e89502022-05-06 22:12:55 +00001034func (a *AndroidApp) SetUpdatable(val bool) {
1035 a.appProperties.Updatable = &val
1036}
1037
Colin Cross0ea8ba82019-06-06 14:33:29 -07001038func (a *AndroidApp) getCertString(ctx android.BaseModuleContext) string {
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001039 certificate, overridden := ctx.DeviceConfig().OverrideCertificateFor(ctx.ModuleName())
1040 if overridden {
Jaewoong Jungacb6db32019-02-28 16:22:30 +00001041 return ":" + certificate
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001042 }
Jaewoong Jung525443a2019-02-28 15:35:54 -08001043 return String(a.overridableAppProperties.Certificate)
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001044}
1045
Jiyong Park0f80c182020-01-31 02:49:53 +09001046func (a *AndroidApp) DepIsInSameApex(ctx android.BaseModuleContext, dep android.Module) bool {
1047 if IsJniDepTag(ctx.OtherModuleDependencyTag(dep)) {
1048 return true
1049 }
1050 return a.Library.DepIsInSameApex(ctx, dep)
1051}
1052
Jiyong Parkb7c639e2019-08-19 14:56:02 +09001053// For OutputFileProducer interface
1054func (a *AndroidApp) OutputFiles(tag string) (android.Paths, error) {
1055 switch tag {
Jared Duke34b080d2023-03-30 16:40:24 -07001056 // In some instances, it can be useful to reference the aapt-generated flags from another
1057 // target, e.g., system server implements services declared in the framework-res manifest.
1058 case ".aapt.proguardOptionsFile":
1059 return []android.Path{a.proguardOptionsFile}, nil
Jiyong Parkb7c639e2019-08-19 14:56:02 +09001060 case ".aapt.srcjar":
Colin Crossf3b7bad2023-08-02 15:49:00 -07001061 if a.aaptSrcJar != nil {
1062 return []android.Path{a.aaptSrcJar}, nil
1063 }
1064 case ".aapt.jar":
1065 if a.rJar != nil {
1066 return []android.Path{a.rJar}, nil
1067 }
Anton Hansson092aca42020-08-13 19:37:22 +01001068 case ".export-package.apk":
1069 return []android.Path{a.exportPackage}, nil
Inseob Kim34dc4cd2023-11-07 13:37:14 +09001070 case ".manifest.xml":
1071 return []android.Path{a.aapt.manifestPath}, nil
Jiyong Parkb7c639e2019-08-19 14:56:02 +09001072 }
1073 return a.Library.OutputFiles(tag)
1074}
1075
Jiyong Parkf7487312019-10-17 12:54:30 +09001076func (a *AndroidApp) Privileged() bool {
1077 return Bool(a.appProperties.Privileged)
1078}
1079
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001080func (a *AndroidApp) IsNativeCoverageNeeded(ctx android.BaseModuleContext) bool {
Colin Cross1a6acd42020-06-16 17:51:46 -07001081 return ctx.Device() && ctx.DeviceConfig().NativeCoverageEnabled()
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001082}
1083
Ivan Lozanod7586b62021-04-01 09:49:36 -04001084func (a *AndroidApp) SetPreventInstall() {
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001085 a.appProperties.PreventInstall = true
1086}
1087
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001088func (a *AndroidApp) MarkAsCoverageVariant(coverage bool) {
1089 a.appProperties.IsCoverageVariant = coverage
1090}
1091
Ivan Lozanoa0cd8f92020-04-09 09:56:02 -04001092func (a *AndroidApp) EnableCoverageIfNeeded() {}
1093
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001094var _ cc.Coverage = (*AndroidApp)(nil)
1095
Colin Cross95b53b82023-10-17 13:21:02 -07001096func (a *AndroidApp) IDEInfo(dpInfo *android.IdeInfo) {
1097 a.Library.IDEInfo(dpInfo)
1098 a.aapt.IDEInfo(dpInfo)
1099}
1100
Inseob Kim34dc4cd2023-11-07 13:37:14 +09001101func (a *AndroidApp) productCharacteristicsRROPackageName() string {
1102 return proptools.String(a.appProperties.ProductCharacteristicsRROPackageName)
1103}
1104
1105func (a *AndroidApp) productCharacteristicsRROManifestModuleName() string {
1106 return proptools.String(a.appProperties.ProductCharacteristicsRROManifestModuleName)
1107}
1108
Colin Cross1b16b0e2019-02-12 14:41:32 -08001109// android_app compiles sources and Android resources into an Android application package `.apk` file.
Colin Cross36242852017-06-23 15:06:31 -07001110func AndroidAppFactory() android.Module {
Colin Cross30e076a2015-04-13 13:58:27 -07001111 module := &AndroidApp{}
1112
Liz Kammera7a64f32020-07-09 15:16:41 -07001113 module.Module.dexProperties.Optimize.EnabledByDefault = true
1114 module.Module.dexProperties.Optimize.Shrink = proptools.BoolPtr(true)
Jared Dukeaa88b3d2023-08-29 17:07:20 +00001115 module.Module.dexProperties.Optimize.Proguard_compatibility = proptools.BoolPtr(false)
Colin Cross66dbc0b2017-12-28 12:23:20 -08001116
Colin Crossae5caf52018-05-22 11:11:52 -07001117 module.Module.properties.Instrument = true
Paul Duffin0038a8d2022-05-03 00:28:40 +00001118 module.Module.properties.Supports_static_instrumentation = true
Colin Cross9ae1b922018-06-26 17:59:05 -07001119 module.Module.properties.Installable = proptools.BoolPtr(true)
Colin Crossae5caf52018-05-22 11:11:52 -07001120
Colin Crossce6734e2020-06-15 16:09:53 -07001121 module.addHostAndDeviceProperties()
Colin Cross36242852017-06-23 15:06:31 -07001122 module.AddProperties(
Colin Crossa97c5d32018-03-28 14:58:31 -07001123 &module.aaptProperties,
Jaewoong Jung525443a2019-02-28 15:35:54 -08001124 &module.appProperties,
Ulya Trafimovich21a73752020-09-01 17:33:48 +01001125 &module.overridableAppProperties)
Colin Cross36242852017-06-23 15:06:31 -07001126
Ulya Trafimovich22890c42021-01-05 12:04:17 +00001127 module.usesLibrary.enforce = true
1128
Colin Crossa4f08812018-10-02 22:03:40 -07001129 android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
1130 android.InitDefaultableModule(module)
zhidou198f5892022-02-17 02:33:12 +00001131 android.InitOverridableModule(module, &module.overridableAppProperties.Overrides)
Jiyong Park52cd06f2019-11-11 10:14:32 +09001132 android.InitApexModule(module)
Liz Kammerbe46fcc2021-11-01 15:32:43 -04001133 android.InitBazelModule(module)
Colin Crossa4f08812018-10-02 22:03:40 -07001134
Inseob Kim34dc4cd2023-11-07 13:37:14 +09001135 android.AddLoadHook(module, func(ctx android.LoadHookContext) {
1136 a := ctx.Module().(*AndroidApp)
1137
1138 characteristics := ctx.Config().ProductAAPTCharacteristics()
1139 if characteristics == "default" || characteristics == "" {
1140 module.appProperties.Generate_product_characteristics_rro = nil
1141 // no need to create RRO
1142 return
1143 }
1144
1145 if !proptools.Bool(module.appProperties.Generate_product_characteristics_rro) {
1146 return
1147 }
1148
1149 rroPackageName := a.Name() + "__" + strings.ReplaceAll(characteristics, ",", "_") + "__auto_generated_characteristics_rro"
1150 rroManifestName := rroPackageName + "_manifest"
1151
1152 a.appProperties.ProductCharacteristicsRROPackageName = proptools.StringPtr(rroPackageName)
1153 a.appProperties.ProductCharacteristicsRROManifestModuleName = proptools.StringPtr(rroManifestName)
1154
1155 rroManifestProperties := struct {
1156 Name *string
1157 Tools []string
1158 Out []string
1159 Srcs []string
1160 Cmd *string
1161 }{
1162 Name: proptools.StringPtr(rroManifestName),
1163 Tools: []string{"characteristics_rro_generator"},
1164 Out: []string{"AndroidManifest.xml"},
1165 Srcs: []string{":" + a.Name() + "{.manifest.xml}"},
1166 Cmd: proptools.StringPtr("$(location characteristics_rro_generator) $(in) $(out)"),
1167 }
1168 ctx.CreateModule(genrule.GenRuleFactory, &rroManifestProperties)
1169
1170 rroProperties := struct {
1171 Name *string
1172 Filter_product *string
1173 Aaptflags []string
1174 Manifest *string
1175 Resource_dirs []string
1176 }{
1177 Name: proptools.StringPtr(rroPackageName),
1178 Filter_product: proptools.StringPtr(characteristics),
1179 Aaptflags: []string{"--auto-add-overlay"},
1180 Manifest: proptools.StringPtr(":" + rroManifestName),
1181 Resource_dirs: a.aaptProperties.Resource_dirs,
1182 }
1183 ctx.CreateModule(RuntimeResourceOverlayFactory, &rroProperties)
1184 })
1185
Colin Cross36242852017-06-23 15:06:31 -07001186 return module
Colin Cross30e076a2015-04-13 13:58:27 -07001187}
Colin Crossae5caf52018-05-22 11:11:52 -07001188
Alix96ea88452023-08-31 15:48:23 +00001189// A dictionary of values to be overridden in the manifest.
1190type Manifest_values struct {
1191 // Overrides the value of package_name in the manifest
1192 ApplicationId *string
1193}
1194
Colin Crossae5caf52018-05-22 11:11:52 -07001195type appTestProperties struct {
Liz Kammer6b0c5522020-04-28 16:10:55 -07001196 // The name of the android_app module that the tests will run against.
Colin Crossae5caf52018-05-22 11:11:52 -07001197 Instrumentation_for *string
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001198
Seth Moorec6f4b532023-02-02 13:22:26 -08001199 // If specified, the instrumentation target package name in the manifest is overwritten by it.
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001200 Instrumentation_target_package *string
Seth Moorec6f4b532023-02-02 13:22:26 -08001201
1202 // If specified, the mainline module package name in the test config is overwritten by it.
1203 Mainline_package_name *string
Alix96ea88452023-08-31 15:48:23 +00001204
1205 Manifest_values Manifest_values
Colin Crossae5caf52018-05-22 11:11:52 -07001206}
1207
1208type AndroidTest struct {
1209 AndroidApp
1210
1211 appTestProperties appTestProperties
1212
1213 testProperties testProperties
Colin Cross303e21f2018-08-07 16:49:25 -07001214
Dan Shi95d19422020-08-15 12:24:26 -07001215 testConfig android.Path
1216 extraTestConfigs android.Paths
1217 data android.Paths
Jingwen Chene12c0832023-08-25 09:00:16 +00001218
1219 android.BazelModuleBase
Colin Crossae5caf52018-05-22 11:11:52 -07001220}
1221
Jaewoong Jung0949f312019-09-11 10:25:18 -07001222func (a *AndroidTest) InstallInTestcases() bool {
1223 return true
1224}
1225
Spandan Das9f7ae7f2022-07-25 00:34:18 +00001226type androidTestApp interface {
1227 includedInTestSuite(searchPrefix string) bool
1228}
1229
1230func (a *AndroidTest) includedInTestSuite(searchPrefix string) bool {
1231 return android.PrefixInList(a.testProperties.Test_suites, searchPrefix)
1232}
1233
1234func (a *AndroidTestHelperApp) includedInTestSuite(searchPrefix string) bool {
1235 return android.PrefixInList(a.appTestHelperAppProperties.Test_suites, searchPrefix)
1236}
1237
Colin Crossae5caf52018-05-22 11:11:52 -07001238func (a *AndroidTest) GenerateAndroidBuildActions(ctx android.ModuleContext) {
easoncylee5bcff5d2020-04-30 14:57:06 +08001239 var configs []tradefed.Config
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001240 if a.appTestProperties.Instrumentation_target_package != nil {
1241 a.additionalAaptFlags = append(a.additionalAaptFlags,
1242 "--rename-instrumentation-target-package "+*a.appTestProperties.Instrumentation_target_package)
1243 } else if a.appTestProperties.Instrumentation_for != nil {
1244 // Check if the instrumentation target package is overridden.
Jaewoong Jung4102e5d2019-02-27 16:26:28 -08001245 manifestPackageName, overridden := ctx.DeviceConfig().OverrideManifestPackageNameFor(*a.appTestProperties.Instrumentation_for)
1246 if overridden {
1247 a.additionalAaptFlags = append(a.additionalAaptFlags, "--rename-instrumentation-target-package "+manifestPackageName)
1248 }
1249 }
Alix96ea88452023-08-31 15:48:23 +00001250 applicationId := a.appTestProperties.Manifest_values.ApplicationId
1251 if applicationId != nil {
1252 if a.overridableAppProperties.Package_name != nil {
1253 ctx.PropertyErrorf("manifest_values.applicationId", "property is not supported when property package_name is set.")
1254 }
1255 a.aapt.manifestValues.applicationId = *applicationId
1256 }
Colin Crossae5caf52018-05-22 11:11:52 -07001257 a.generateAndroidBuildActions(ctx)
Colin Cross303e21f2018-08-07 16:49:25 -07001258
easoncylee5bcff5d2020-04-30 14:57:06 +08001259 for _, module := range a.testProperties.Test_mainline_modules {
1260 configs = append(configs, tradefed.Option{Name: "config-descriptor:metadata", Key: "mainline-param", Value: module})
1261 }
1262
Jaewoong Jung39982342020-01-14 10:27:18 -08001263 testConfig := tradefed.AutoGenInstrumentationTestConfig(ctx, a.testProperties.Test_config,
easoncylee5bcff5d2020-04-30 14:57:06 +08001264 a.testProperties.Test_config_template, a.manifestPath, a.testProperties.Test_suites, a.testProperties.Auto_gen_config, configs)
Jaewoong Jung39982342020-01-14 10:27:18 -08001265 a.testConfig = a.FixTestConfig(ctx, testConfig)
Dan Shi95d19422020-08-15 12:24:26 -07001266 a.extraTestConfigs = android.PathsForModuleSrc(ctx, a.testProperties.Test_options.Extra_test_configs)
Colin Cross8a497952019-03-05 22:25:09 -08001267 a.data = android.PathsForModuleSrc(ctx, a.testProperties.Data)
Colin Cross303e21f2018-08-07 16:49:25 -07001268}
1269
Jaewoong Jung39982342020-01-14 10:27:18 -08001270func (a *AndroidTest) FixTestConfig(ctx android.ModuleContext, testConfig android.Path) android.Path {
1271 if testConfig == nil {
1272 return nil
1273 }
1274
1275 fixedConfig := android.PathForModuleOut(ctx, "test_config_fixer", "AndroidTest.xml")
Colin Crossf1a035e2020-11-16 17:32:30 -08001276 rule := android.NewRuleBuilder(pctx, ctx)
1277 command := rule.Command().BuiltTool("test_config_fixer").Input(testConfig).Output(fixedConfig)
Jaewoong Jung39982342020-01-14 10:27:18 -08001278 fixNeeded := false
1279
Jooyung Han29e2f6d2022-01-08 12:13:59 +09001280 // Auto-generated test config uses `ModuleName` as the APK name. So fix it if it is not the case.
Jaewoong Jung39982342020-01-14 10:27:18 -08001281 if ctx.ModuleName() != a.installApkName {
1282 fixNeeded = true
1283 command.FlagWithArg("--test-file-name ", a.installApkName+".apk")
1284 }
1285
1286 if a.overridableAppProperties.Package_name != nil {
1287 fixNeeded = true
1288 command.FlagWithInput("--manifest ", a.manifestPath).
1289 FlagWithArg("--package-name ", *a.overridableAppProperties.Package_name)
1290 }
1291
Seth Moorec6f4b532023-02-02 13:22:26 -08001292 if a.appTestProperties.Mainline_package_name != nil {
1293 fixNeeded = true
1294 command.FlagWithArg("--mainline-package-name ", *a.appTestProperties.Mainline_package_name)
1295 }
1296
Jaewoong Jung39982342020-01-14 10:27:18 -08001297 if fixNeeded {
Colin Crossf1a035e2020-11-16 17:32:30 -08001298 rule.Build("fix_test_config", "fix test config")
Jaewoong Jung39982342020-01-14 10:27:18 -08001299 return fixedConfig
1300 }
1301 return testConfig
1302}
1303
Colin Cross303e21f2018-08-07 16:49:25 -07001304func (a *AndroidTest) DepsMutator(ctx android.BottomUpMutatorContext) {
Colin Cross303e21f2018-08-07 16:49:25 -07001305 a.AndroidApp.DepsMutator(ctx)
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001306}
1307
1308func (a *AndroidTest) OverridablePropertiesDepsMutator(ctx android.BottomUpMutatorContext) {
1309 a.AndroidApp.OverridablePropertiesDepsMutator(ctx)
Colin Cross4b964c02018-10-15 16:18:06 -07001310 if a.appTestProperties.Instrumentation_for != nil {
1311 // The android_app dependency listed in instrumentation_for needs to be added to the classpath for javac,
1312 // but not added to the aapt2 link includes like a normal android_app or android_library dependency, so
1313 // use instrumentationForTag instead of libTag.
1314 ctx.AddVariationDependencies(nil, instrumentationForTag, String(a.appTestProperties.Instrumentation_for))
1315 }
Colin Crossae5caf52018-05-22 11:11:52 -07001316}
1317
Colin Cross1b16b0e2019-02-12 14:41:32 -08001318// android_test compiles test sources and Android resources into an Android application package `.apk` file and
1319// creates an `AndroidTest.xml` file to allow running the test with `atest` or a `TEST_MAPPING` file.
Colin Crossae5caf52018-05-22 11:11:52 -07001320func AndroidTestFactory() android.Module {
1321 module := &AndroidTest{}
1322
Jared Duke63a3da92022-06-02 19:11:14 +00001323 module.Module.dexProperties.Optimize.EnabledByDefault = false
Colin Cross5067db92018-09-17 16:46:35 -07001324
1325 module.Module.properties.Instrument = true
Paul Duffin0038a8d2022-05-03 00:28:40 +00001326 module.Module.properties.Supports_static_instrumentation = true
Colin Cross9ae1b922018-06-26 17:59:05 -07001327 module.Module.properties.Installable = proptools.BoolPtr(true)
Colin Crosse4246ab2019-02-05 21:55:21 -08001328 module.appProperties.Use_embedded_native_libs = proptools.BoolPtr(true)
Colin Cross47fa9d32019-03-26 10:51:39 -07001329 module.appProperties.AlwaysPackageNativeLibs = true
Colin Cross43f08db2018-11-12 10:13:39 -08001330 module.Module.dexpreopter.isTest = true
Cole Faustd57e8b22022-08-11 11:59:04 -07001331 module.Module.linter.properties.Lint.Test = proptools.BoolPtr(true)
Colin Crossae5caf52018-05-22 11:11:52 -07001332
Colin Crossce6734e2020-06-15 16:09:53 -07001333 module.addHostAndDeviceProperties()
Colin Crossae5caf52018-05-22 11:11:52 -07001334 module.AddProperties(
Colin Crossae5caf52018-05-22 11:11:52 -07001335 &module.aaptProperties,
1336 &module.appProperties,
Dan Willemsenf5531d22018-07-16 17:21:19 -07001337 &module.appTestProperties,
Jaewoong Jung525443a2019-02-28 15:35:54 -08001338 &module.overridableAppProperties,
Dan Willemsenf5531d22018-07-16 17:21:19 -07001339 &module.testProperties)
Colin Crossae5caf52018-05-22 11:11:52 -07001340
Colin Crossa4f08812018-10-02 22:03:40 -07001341 android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
1342 android.InitDefaultableModule(module)
zhidou198f5892022-02-17 02:33:12 +00001343 android.InitOverridableModule(module, &module.overridableAppProperties.Overrides)
Jingwen Chene12c0832023-08-25 09:00:16 +00001344
1345 android.InitBazelModule(module)
Colin Crossae5caf52018-05-22 11:11:52 -07001346 return module
1347}
Colin Crossbd01e2a2018-10-04 15:21:03 -07001348
Colin Cross252fc6f2018-10-04 15:22:03 -07001349type appTestHelperAppProperties struct {
1350 // list of compatibility suites (for example "cts", "vts") that the module should be
1351 // installed into.
1352 Test_suites []string `android:"arch_variant"`
Dan Shi6ffaaa82019-09-26 11:41:36 -07001353
1354 // Flag to indicate whether or not to create test config automatically. If AndroidTest.xml
1355 // doesn't exist next to the Android.bp, this attribute doesn't need to be set to true
1356 // explicitly.
1357 Auto_gen_config *bool
Colin Crosscfb0f5e2021-09-24 15:47:17 -07001358
1359 // Install the test into a folder named for the module in all test suites.
1360 Per_testcase_directory *bool
Alix96ea88452023-08-31 15:48:23 +00001361
1362 Manifest_values Manifest_values
Colin Cross252fc6f2018-10-04 15:22:03 -07001363}
1364
1365type AndroidTestHelperApp struct {
1366 AndroidApp
1367
1368 appTestHelperAppProperties appTestHelperAppProperties
Jingwen Chen65289992023-09-21 15:15:47 +00001369
1370 android.BazelModuleBase
Colin Cross252fc6f2018-10-04 15:22:03 -07001371}
1372
Jaewoong Jung326a9412019-11-21 10:41:00 -08001373func (a *AndroidTestHelperApp) InstallInTestcases() bool {
1374 return true
1375}
1376
Colin Cross1b16b0e2019-02-12 14:41:32 -08001377// android_test_helper_app compiles sources and Android resources into an Android application package `.apk` file that
1378// will be used by tests, but does not produce an `AndroidTest.xml` file so the module will not be run directly as a
1379// test.
Colin Cross252fc6f2018-10-04 15:22:03 -07001380func AndroidTestHelperAppFactory() android.Module {
1381 module := &AndroidTestHelperApp{}
1382
Jared Duke63a3da92022-06-02 19:11:14 +00001383 // TODO(b/192032291): Disable by default after auditing downstream usage.
Liz Kammera7a64f32020-07-09 15:16:41 -07001384 module.Module.dexProperties.Optimize.EnabledByDefault = true
Colin Cross252fc6f2018-10-04 15:22:03 -07001385
1386 module.Module.properties.Installable = proptools.BoolPtr(true)
Colin Crosse4246ab2019-02-05 21:55:21 -08001387 module.appProperties.Use_embedded_native_libs = proptools.BoolPtr(true)
Colin Cross47fa9d32019-03-26 10:51:39 -07001388 module.appProperties.AlwaysPackageNativeLibs = true
Colin Cross43f08db2018-11-12 10:13:39 -08001389 module.Module.dexpreopter.isTest = true
Cole Faustd57e8b22022-08-11 11:59:04 -07001390 module.Module.linter.properties.Lint.Test = proptools.BoolPtr(true)
Colin Cross252fc6f2018-10-04 15:22:03 -07001391
Colin Crossce6734e2020-06-15 16:09:53 -07001392 module.addHostAndDeviceProperties()
Colin Cross252fc6f2018-10-04 15:22:03 -07001393 module.AddProperties(
Colin Cross252fc6f2018-10-04 15:22:03 -07001394 &module.aaptProperties,
1395 &module.appProperties,
Jaewoong Jung525443a2019-02-28 15:35:54 -08001396 &module.appTestHelperAppProperties,
Ulya Trafimovich21a73752020-09-01 17:33:48 +01001397 &module.overridableAppProperties)
Colin Cross252fc6f2018-10-04 15:22:03 -07001398
1399 android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
1400 android.InitDefaultableModule(module)
Anton Hansson3d2b6b42020-01-10 15:06:01 +00001401 android.InitApexModule(module)
Jingwen Chen65289992023-09-21 15:15:47 +00001402 android.InitBazelModule(module)
Colin Cross252fc6f2018-10-04 15:22:03 -07001403 return module
1404}
1405
Colin Crossbd01e2a2018-10-04 15:21:03 -07001406type AndroidAppCertificate struct {
1407 android.ModuleBase
Rupert Shuttleworth6e4950a2021-07-27 01:34:59 -04001408 android.BazelModuleBase
1409
Colin Crossbd01e2a2018-10-04 15:21:03 -07001410 properties AndroidAppCertificateProperties
Jiyong Parkc00cbd92018-10-30 21:20:05 +09001411 Certificate Certificate
Colin Crossbd01e2a2018-10-04 15:21:03 -07001412}
1413
1414type AndroidAppCertificateProperties struct {
1415 // Name of the certificate files. Extensions .x509.pem and .pk8 will be added to the name.
1416 Certificate *string
1417}
1418
Colin Cross1b16b0e2019-02-12 14:41:32 -08001419// android_app_certificate modules can be referenced by the certificates property of android_app modules to select
1420// the signing key.
Colin Crossbd01e2a2018-10-04 15:21:03 -07001421func AndroidAppCertificateFactory() android.Module {
1422 module := &AndroidAppCertificate{}
1423 module.AddProperties(&module.properties)
1424 android.InitAndroidModule(module)
Rupert Shuttleworth6e4950a2021-07-27 01:34:59 -04001425 android.InitBazelModule(module)
Colin Crossbd01e2a2018-10-04 15:21:03 -07001426 return module
1427}
1428
Colin Crossbd01e2a2018-10-04 15:21:03 -07001429func (c *AndroidAppCertificate) GenerateAndroidBuildActions(ctx android.ModuleContext) {
1430 cert := String(c.properties.Certificate)
Jiyong Parkc00cbd92018-10-30 21:20:05 +09001431 c.Certificate = Certificate{
Colin Cross503c1d02020-01-28 14:00:53 -08001432 Pem: android.PathForModuleSrc(ctx, cert+".x509.pem"),
1433 Key: android.PathForModuleSrc(ctx, cert+".pk8"),
Colin Crossbd01e2a2018-10-04 15:21:03 -07001434 }
1435}
Jaewoong Jung525443a2019-02-28 15:35:54 -08001436
1437type OverrideAndroidApp struct {
1438 android.ModuleBase
1439 android.OverrideModuleBase
1440}
1441
Sasha Smundak613cbb12020-06-05 10:27:23 -07001442func (i *OverrideAndroidApp) GenerateAndroidBuildActions(_ android.ModuleContext) {
Jaewoong Jung525443a2019-02-28 15:35:54 -08001443 // All the overrides happen in the base module.
1444 // TODO(jungjw): Check the base module type.
1445}
1446
1447// override_android_app is used to create an android_app module based on another android_app by overriding
1448// some of its properties.
1449func OverrideAndroidAppModuleFactory() android.Module {
1450 m := &OverrideAndroidApp{}
Jooyung Han01d80d82022-01-08 12:16:32 +09001451 m.AddProperties(
1452 &OverridableDeviceProperties{},
1453 &overridableAppProperties{},
1454 )
Jaewoong Jung525443a2019-02-28 15:35:54 -08001455
Jaewoong Jungb639a6a2019-05-10 15:16:29 -07001456 android.InitAndroidMultiTargetsArchModule(m, android.DeviceSupported, android.MultilibCommon)
Jaewoong Jung525443a2019-02-28 15:35:54 -08001457 android.InitOverrideModule(m)
1458 return m
1459}
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001460
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001461type OverrideAndroidTest struct {
1462 android.ModuleBase
1463 android.OverrideModuleBase
1464}
1465
Sasha Smundak613cbb12020-06-05 10:27:23 -07001466func (i *OverrideAndroidTest) GenerateAndroidBuildActions(_ android.ModuleContext) {
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001467 // All the overrides happen in the base module.
1468 // TODO(jungjw): Check the base module type.
1469}
1470
1471// override_android_test is used to create an android_app module based on another android_test by overriding
1472// some of its properties.
1473func OverrideAndroidTestModuleFactory() android.Module {
1474 m := &OverrideAndroidTest{}
1475 m.AddProperties(&overridableAppProperties{})
1476 m.AddProperties(&appTestProperties{})
1477
1478 android.InitAndroidMultiTargetsArchModule(m, android.DeviceSupported, android.MultilibCommon)
1479 android.InitOverrideModule(m)
1480 return m
1481}
1482
Colin Cross50ddcc42019-05-16 12:28:22 -07001483type UsesLibraryProperties struct {
1484 // A list of shared library modules that will be listed in uses-library tags in the AndroidManifest.xml file.
1485 Uses_libs []string
1486
1487 // A list of shared library modules that will be listed in uses-library tags in the AndroidManifest.xml file with
1488 // required=false.
1489 Optional_uses_libs []string
1490
1491 // If true, the list of uses_libs and optional_uses_libs modules must match the AndroidManifest.xml file. Defaults
1492 // to true if either uses_libs or optional_uses_libs is set. Will unconditionally default to true in the future.
1493 Enforce_uses_libs *bool
Ulya Trafimovich21a73752020-09-01 17:33:48 +01001494
Ulya Trafimovich54027b52020-09-09 14:08:23 +01001495 // Optional name of the <uses-library> provided by this module. This is needed for non-SDK
1496 // libraries, because SDK ones are automatically picked up by Soong. The <uses-library> name
1497 // normally is the same as the module name, but there are exceptions.
1498 Provides_uses_lib *string
Paul Duffin06530572022-02-03 17:54:15 +00001499
1500 // A list of shared library names to exclude from the classpath of the APK. Adding a library here
1501 // will prevent it from being used when precompiling the APK and prevent it from being implicitly
1502 // added to the APK's manifest's <uses-library> elements.
1503 //
1504 // Care must be taken when using this as it could result in runtime errors if the APK actually
1505 // uses classes provided by the library and which are not provided in any other way.
1506 //
1507 // This is primarily intended for use by various CTS tests that check the runtime handling of the
1508 // android.test.base shared library (and related libraries) but which depend on some common
1509 // libraries that depend on the android.test.base library. Without this those tests will end up
1510 // with a <uses-library android:name="android.test.base"/> in their manifest which would either
1511 // render the tests worthless (as they would be testing the wrong behavior), or would break the
1512 // test altogether by providing access to classes that the tests were not expecting. Those tests
1513 // provide the android.test.base statically and use jarjar to rename them so they do not collide
1514 // with the classes provided by the android.test.base library.
1515 Exclude_uses_libs []string
Colin Cross50ddcc42019-05-16 12:28:22 -07001516}
1517
1518// usesLibrary provides properties and helper functions for AndroidApp and AndroidAppImport to verify that the
1519// <uses-library> tags that end up in the manifest of an APK match the ones known to the build system through the
1520// uses_libs and optional_uses_libs properties. The build system's values are used by dexpreopt to preopt apps
1521// with knowledge of their shared libraries.
1522type usesLibrary struct {
1523 usesLibraryProperties UsesLibraryProperties
Ulya Trafimovich22890c42021-01-05 12:04:17 +00001524
1525 // Whether to enforce verify_uses_library check.
1526 enforce bool
Colin Cross50ddcc42019-05-16 12:28:22 -07001527}
1528
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +01001529func (u *usesLibrary) addLib(lib string, optional bool) {
1530 if !android.InList(lib, u.usesLibraryProperties.Uses_libs) && !android.InList(lib, u.usesLibraryProperties.Optional_uses_libs) {
1531 if optional {
1532 u.usesLibraryProperties.Optional_uses_libs = append(u.usesLibraryProperties.Optional_uses_libs, lib)
1533 } else {
1534 u.usesLibraryProperties.Uses_libs = append(u.usesLibraryProperties.Uses_libs, lib)
1535 }
1536 }
1537}
1538
Colin Cross4a80a152022-12-21 21:51:52 -08001539func (u *usesLibrary) deps(ctx android.BottomUpMutatorContext, addCompatDeps bool) {
Jeongik Cha4b073cd2021-06-08 11:35:00 +09001540 if !ctx.Config().UnbundledBuild() || ctx.Config().UnbundledBuildImage() {
Ulya Trafimovichf5d91bb2022-05-04 12:00:02 +01001541 ctx.AddVariationDependencies(nil, usesLibReqTag, u.usesLibraryProperties.Uses_libs...)
1542 ctx.AddVariationDependencies(nil, usesLibOptTag, u.presentOptionalUsesLibs(ctx)...)
Colin Cross4a80a152022-12-21 21:51:52 -08001543 // Only add these extra dependencies if the module is an app that depends on framework
1544 // libs. This avoids creating a cyclic dependency:
Paul Duffin250e6192019-06-07 10:44:37 +01001545 // e.g. framework-res -> org.apache.http.legacy -> ... -> framework-res.
Colin Cross4a80a152022-12-21 21:51:52 -08001546 if addCompatDeps {
Ulya Trafimovichf5d91bb2022-05-04 12:00:02 +01001547 // Dexpreopt needs paths to the dex jars of these libraries in order to construct
1548 // class loader context for dex2oat. Add them as a dependency with a special tag.
1549 ctx.AddVariationDependencies(nil, usesLibCompat29ReqTag, dexpreopt.CompatUsesLibs29...)
1550 ctx.AddVariationDependencies(nil, usesLibCompat28OptTag, dexpreopt.OptionalCompatUsesLibs28...)
1551 ctx.AddVariationDependencies(nil, usesLibCompat30OptTag, dexpreopt.OptionalCompatUsesLibs30...)
Colin Cross3245b2c2019-06-07 13:18:09 -07001552 }
Sam Delmerico9f9c0a22022-11-29 11:19:37 -05001553 } else {
1554 ctx.AddVariationDependencies(nil, r8LibraryJarTag, u.usesLibraryProperties.Uses_libs...)
1555 ctx.AddVariationDependencies(nil, r8LibraryJarTag, u.presentOptionalUsesLibs(ctx)...)
Colin Cross50ddcc42019-05-16 12:28:22 -07001556 }
1557}
1558
Jiakai Zhang4f65a032023-06-01 15:16:58 +01001559// presentOptionalUsesLibs returns optional_uses_libs after filtering out libraries that don't exist in the source tree.
Colin Cross50ddcc42019-05-16 12:28:22 -07001560func (u *usesLibrary) presentOptionalUsesLibs(ctx android.BaseModuleContext) []string {
Jiakai Zhang4f65a032023-06-01 15:16:58 +01001561 optionalUsesLibs := android.FilterListPred(u.usesLibraryProperties.Optional_uses_libs, func(s string) bool {
1562 exists := ctx.OtherModuleExists(s)
Jiakai Zhang48203e32023-06-02 23:42:21 +01001563 if !exists && !android.InList(ctx.ModuleName(), ctx.Config().BuildWarningBadOptionalUsesLibsAllowlist()) {
Jiakai Zhang4f65a032023-06-01 15:16:58 +01001564 fmt.Printf("Warning: Module '%s' depends on non-existing optional_uses_libs '%s'\n", ctx.ModuleName(), s)
1565 }
1566 return exists
1567 })
Colin Cross50ddcc42019-05-16 12:28:22 -07001568 return optionalUsesLibs
1569}
1570
Ulya Trafimovicheea486a2021-02-26 11:38:21 +00001571// Helper function to replace string in a list.
1572func replaceInList(list []string, oldstr, newstr string) {
1573 for i, str := range list {
1574 if str == oldstr {
1575 list[i] = newstr
1576 }
1577 }
1578}
1579
Ulya Trafimovich24446712021-07-15 14:59:34 +01001580// Returns a map of module names of shared library dependencies to the paths to their dex jars on
1581// host and on device.
Ulya Trafimovich8cbc5d22020-11-03 15:15:46 +00001582func (u *usesLibrary) classLoaderContextForUsesLibDeps(ctx android.ModuleContext) dexpreopt.ClassLoaderContextMap {
1583 clcMap := make(dexpreopt.ClassLoaderContextMap)
Ulya Trafimovich24446712021-07-15 14:59:34 +01001584
1585 // Skip when UnbundledBuild() is true, but UnbundledBuildImage() is false. With
1586 // UnbundledBuildImage() it is necessary to generate dexpreopt.config for post-dexpreopting.
1587 if ctx.Config().UnbundledBuild() && !ctx.Config().UnbundledBuildImage() {
1588 return clcMap
Colin Cross50ddcc42019-05-16 12:28:22 -07001589 }
1590
Ulya Trafimovich24446712021-07-15 14:59:34 +01001591 ctx.VisitDirectDeps(func(m android.Module) {
1592 tag, isUsesLibTag := ctx.OtherModuleDependencyTag(m).(usesLibraryDependencyTag)
1593 if !isUsesLibTag {
1594 return
1595 }
1596
Ulya Trafimoviche14f80b2021-07-15 15:05:48 +01001597 dep := android.RemoveOptionalPrebuiltPrefix(ctx.OtherModuleName(m))
Ulya Trafimovich24446712021-07-15 14:59:34 +01001598
Ulya Trafimovich840efb62021-07-15 14:34:40 +01001599 // Skip stub libraries. A dependency on the implementation library has been added earlier,
1600 // so it will be added to CLC, but the stub shouldn't be. Stub libraries can be distingushed
1601 // from implementation libraries by their name, which is different as it has a suffix.
1602 if comp, ok := m.(SdkLibraryComponentDependency); ok {
1603 if impl := comp.OptionalSdkLibraryImplementation(); impl != nil && *impl != dep {
1604 return
1605 }
1606 }
1607
Ulya Trafimovich24446712021-07-15 14:59:34 +01001608 if lib, ok := m.(UsesLibraryDependency); ok {
Ulya Trafimoviche14f80b2021-07-15 15:05:48 +01001609 libName := dep
Ulya Trafimovich24446712021-07-15 14:59:34 +01001610 if ulib, ok := m.(ProvidesUsesLib); ok && ulib.ProvidesUsesLib() != nil {
Ulya Trafimoviche14f80b2021-07-15 15:05:48 +01001611 libName = *ulib.ProvidesUsesLib()
Ulya Trafimovich24446712021-07-15 14:59:34 +01001612 // Replace module name with library name in `uses_libs`/`optional_uses_libs` in
1613 // order to pass verify_uses_libraries check (which compares these properties
1614 // against library names written in the manifest).
1615 replaceInList(u.usesLibraryProperties.Uses_libs, dep, libName)
1616 replaceInList(u.usesLibraryProperties.Optional_uses_libs, dep, libName)
1617 }
Ulya Trafimovichf5d91bb2022-05-04 12:00:02 +01001618 clcMap.AddContext(ctx, tag.sdkVersion, libName, tag.optional,
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01001619 lib.DexJarBuildPath().PathOrNil(), lib.DexJarInstallPath(),
1620 lib.ClassLoaderContexts())
Ulya Trafimovich24446712021-07-15 14:59:34 +01001621 } else if ctx.Config().AllowMissingDependencies() {
1622 ctx.AddMissingDependencies([]string{dep})
1623 } else {
1624 ctx.ModuleErrorf("module %q in uses_libs or optional_uses_libs must be a java library", dep)
1625 }
1626 })
Ulya Trafimovich8cbc5d22020-11-03 15:15:46 +00001627 return clcMap
Colin Cross50ddcc42019-05-16 12:28:22 -07001628}
1629
1630// enforceUsesLibraries returns true of <uses-library> tags should be checked against uses_libs and optional_uses_libs
1631// properties. Defaults to true if either of uses_libs or optional_uses_libs is specified. Will default to true
1632// unconditionally in the future.
1633func (u *usesLibrary) enforceUsesLibraries() bool {
1634 defaultEnforceUsesLibs := len(u.usesLibraryProperties.Uses_libs) > 0 ||
1635 len(u.usesLibraryProperties.Optional_uses_libs) > 0
Ulya Trafimovich22890c42021-01-05 12:04:17 +00001636 return BoolDefault(u.usesLibraryProperties.Enforce_uses_libs, u.enforce || defaultEnforceUsesLibs)
Colin Cross50ddcc42019-05-16 12:28:22 -07001637}
1638
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +01001639// Freeze the value of `enforce_uses_libs` based on the current values of `uses_libs` and `optional_uses_libs`.
1640func (u *usesLibrary) freezeEnforceUsesLibraries() {
1641 enforce := u.enforceUsesLibraries()
1642 u.usesLibraryProperties.Enforce_uses_libs = &enforce
1643}
1644
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001645// verifyUsesLibraries checks the <uses-library> tags in the manifest against the ones specified
1646// in the `uses_libs`/`optional_uses_libs` properties. The input can be either an XML manifest, or
1647// an APK with the manifest embedded in it (manifest_check will know which one it is by the file
1648// extension: APKs are supposed to end with '.apk').
1649func (u *usesLibrary) verifyUsesLibraries(ctx android.ModuleContext, inputFile android.Path,
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001650 outputFile android.WritablePath) android.Path {
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001651
Ulya Trafimovich8c35fcf2021-02-17 16:23:28 +00001652 statusFile := dexpreopt.UsesLibrariesStatusFile(ctx)
Colin Cross50ddcc42019-05-16 12:28:22 -07001653
Ulya Trafimovich6e55ef12021-03-04 12:37:50 +00001654 // Disable verify_uses_libraries check if dexpreopt is globally disabled. Without dexpreopt the
1655 // check is not necessary, and although it is good to have, it is difficult to maintain on
1656 // non-linux build platforms where dexpreopt is generally disabled (the check may fail due to
1657 // various unrelated reasons, such as a failure to get manifest from an APK).
Ulya Trafimovich39dd0a42021-03-29 14:57:34 +01001658 global := dexpreopt.GetGlobalConfig(ctx)
Jiakai Zhang23984422023-11-09 16:47:04 +00001659 if global.DisablePreopt || global.OnlyPreoptArtBootImage {
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001660 return inputFile
Ulya Trafimovich6e55ef12021-03-04 12:37:50 +00001661 }
1662
Colin Crossf1a035e2020-11-16 17:32:30 -08001663 rule := android.NewRuleBuilder(pctx, ctx)
1664 cmd := rule.Command().BuiltTool("manifest_check").
Colin Cross50ddcc42019-05-16 12:28:22 -07001665 Flag("--enforce-uses-libraries").
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001666 Input(inputFile).
Ulya Trafimovich8c35fcf2021-02-17 16:23:28 +00001667 FlagWithOutput("--enforce-uses-libraries-status ", statusFile).
Saeid Farivar Asanjanfd27c7c2022-08-08 20:21:26 +00001668 FlagWithInput("--aapt ", ctx.Config().HostToolPath(ctx, "aapt2"))
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001669
1670 if outputFile != nil {
1671 cmd.FlagWithOutput("-o ", outputFile)
1672 }
Colin Cross50ddcc42019-05-16 12:28:22 -07001673
Ulya Trafimovich8c35fcf2021-02-17 16:23:28 +00001674 if dexpreopt.GetGlobalConfig(ctx).RelaxUsesLibraryCheck {
1675 cmd.Flag("--enforce-uses-libraries-relax")
1676 }
1677
Colin Cross50ddcc42019-05-16 12:28:22 -07001678 for _, lib := range u.usesLibraryProperties.Uses_libs {
1679 cmd.FlagWithArg("--uses-library ", lib)
1680 }
1681
1682 for _, lib := range u.usesLibraryProperties.Optional_uses_libs {
1683 cmd.FlagWithArg("--optional-uses-library ", lib)
1684 }
1685
Colin Crossf1a035e2020-11-16 17:32:30 -08001686 rule.Build("verify_uses_libraries", "verify <uses-library>")
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001687 return outputFile
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001688}
Colin Cross50ddcc42019-05-16 12:28:22 -07001689
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001690// verifyUsesLibrariesManifest checks the <uses-library> tags in an AndroidManifest.xml against
1691// the build system and returns the path to a copy of the manifest.
1692func (u *usesLibrary) verifyUsesLibrariesManifest(ctx android.ModuleContext, manifest android.Path) android.Path {
1693 outputFile := android.PathForModuleOut(ctx, "manifest_check", "AndroidManifest.xml")
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001694 return u.verifyUsesLibraries(ctx, manifest, outputFile)
Colin Cross50ddcc42019-05-16 12:28:22 -07001695}
1696
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001697// verifyUsesLibrariesAPK checks the <uses-library> tags in the manifest of an APK against the build
1698// system and returns the path to a copy of the APK.
Cole Faust2f1da162023-04-17 15:06:56 -07001699func (u *usesLibrary) verifyUsesLibrariesAPK(ctx android.ModuleContext, apk android.Path) {
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001700 u.verifyUsesLibraries(ctx, apk, nil) // for APKs manifest_check does not write output file
Colin Cross50ddcc42019-05-16 12:28:22 -07001701}
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001702
1703// For Bazel / bp2build
1704
1705type bazelAndroidAppCertificateAttributes struct {
1706 Certificate string
1707}
1708
Chris Parsons637458d2023-09-19 20:09:00 +00001709func (m *AndroidAppCertificate) ConvertWithBp2build(ctx android.Bp2buildMutatorContext) {
Liz Kammerbe46fcc2021-11-01 15:32:43 -04001710 androidAppCertificateBp2Build(ctx, m)
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001711}
1712
Chris Parsons637458d2023-09-19 20:09:00 +00001713func androidAppCertificateBp2Build(ctx android.Bp2buildMutatorContext, module *AndroidAppCertificate) {
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001714 var certificate string
1715 if module.properties.Certificate != nil {
1716 certificate = *module.properties.Certificate
1717 }
1718
1719 attrs := &bazelAndroidAppCertificateAttributes{
1720 Certificate: certificate,
1721 }
1722
1723 props := bazel.BazelTargetModuleProperties{
1724 Rule_class: "android_app_certificate",
Alixa381cd12023-05-10 14:49:38 +00001725 Bzl_load_location: "//build/bazel/rules/android:android_app_certificate.bzl",
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001726 }
1727
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux447f6c92021-08-31 20:30:36 +00001728 ctx.CreateBazelTargetModule(props, android.CommonAttributes{Name: module.Name()}, attrs)
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001729}
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001730
Alixe5085eb2023-01-31 19:38:41 +00001731type manifestValueAttribute struct {
Romain Jobredeaux496660d2023-07-10 11:50:00 -04001732 MinSdkVersion *string
Romain Jobredeaux496660d2023-07-10 11:50:00 -04001733 TargetSdkVersion *string
Alixe5085eb2023-01-31 19:38:41 +00001734}
1735
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001736type bazelAndroidAppAttributes struct {
Sam Delmericoc0161432022-02-25 21:34:51 +00001737 *javaCommonAttributes
Romain Jobredeauxc9b2bba2022-02-15 09:35:07 -05001738 *bazelAapt
Sam Delmericoc0161432022-02-25 21:34:51 +00001739 Deps bazel.LabelListAttribute
Sam Delmerico9dfb1392022-02-10 21:11:59 +00001740 Custom_package *string
Jingwen Chen6817bbb2022-10-14 09:56:07 +00001741 Certificate bazel.LabelAttribute
1742 Certificate_name bazel.StringAttribute
Alixe5085eb2023-01-31 19:38:41 +00001743 Manifest_values *manifestValueAttribute
Romain Jobredeaux9973ace2023-08-30 00:27:09 -04001744 Optimize *bool
1745 Proguard_specs bazel.LabelListAttribute
Romain Jobredeaux3132f842023-09-15 10:06:16 -04001746 Updatable *bool
Jingwen Chenbea58092022-09-29 16:56:02 +00001747}
1748
Alixee51bd62023-08-29 16:01:46 +00001749func (b bazelAapt) ConvertJavaResources(ctx android.Bp2buildMutatorContext, javaAttrs *javaCommonAttributes) bool {
1750 // TODO (b/300470246) bp2build support for java_resources & java_resource_dirs in android rules
1751 hasJavaResources := !javaAttrs.javaResourcesAttributes.Resources.IsEmpty()
1752 if hasJavaResources {
1753 ctx.MarkBp2buildUnconvertible(bp2build_metrics_proto.UnconvertedReasonType_UNSUPPORTED, "(b/300470246) java resources in android_* module")
1754 }
1755 return hasJavaResources
1756}
1757
Chris Parsons637458d2023-09-19 20:09:00 +00001758func convertWithBp2build(ctx android.Bp2buildMutatorContext, a *AndroidApp) (bool, android.CommonAttributes, *bazelAndroidAppAttributes) {
Romain Jobredeaux7a71e072023-08-16 17:39:12 -04001759 aapt, supported := a.convertAaptAttrsWithBp2Build(ctx)
1760 if !supported {
Jingwen Chene12c0832023-08-25 09:00:16 +00001761 return false, android.CommonAttributes{}, &bazelAndroidAppAttributes{}
Romain Jobredeaux7a71e072023-08-16 17:39:12 -04001762 }
Spandan Das0e0a8802023-09-20 19:53:30 +00001763 if a.appProperties.Jni_uses_platform_apis != nil {
1764 ctx.MarkBp2buildUnconvertible(
1765 bp2build_metrics_proto.UnconvertedReasonType_UNSUPPORTED,
1766 "TODO - b/299360988: Add bp2build support for jni_uses_platform_apis",
1767 )
1768 return false, android.CommonAttributes{}, &bazelAndroidAppAttributes{}
1769 }
1770 if a.appProperties.Jni_uses_sdk_apis != nil {
1771 ctx.MarkBp2buildUnconvertible(
1772 bp2build_metrics_proto.UnconvertedReasonType_UNSUPPORTED,
1773 "TODO - b/299360988: Add bp2build support for jni_uses_sdk_apis",
1774 )
1775 return false, android.CommonAttributes{}, &bazelAndroidAppAttributes{}
1776 }
1777
Jingwen Chen6817bbb2022-10-14 09:56:07 +00001778 certificate, certificateName := android.BazelStringOrLabelFromProp(ctx, a.overridableAppProperties.Certificate)
1779
Romain Jobredeaux3132f842023-09-15 10:06:16 -04001780 manifestValues := &manifestValueAttribute{
1781 MinSdkVersion: a.deviceProperties.Min_sdk_version,
1782 TargetSdkVersion: a.deviceProperties.Target_sdk_version,
Romain Jobredeaux496660d2023-07-10 11:50:00 -04001783 }
1784
Alix0856f9e2023-01-20 22:15:30 +00001785 appAttrs := &bazelAndroidAppAttributes{
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001786 // TODO(b/209576404): handle package name override by product variable PRODUCT_MANIFEST_PACKAGE_NAME_OVERRIDES
Alix0856f9e2023-01-20 22:15:30 +00001787 Custom_package: a.overridableAppProperties.Package_name,
1788 Certificate: certificate,
1789 Certificate_name: certificateName,
Alixe5085eb2023-01-31 19:38:41 +00001790 Manifest_values: manifestValues,
Romain Jobredeaux3132f842023-09-15 10:06:16 -04001791 Updatable: a.appProperties.Updatable,
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001792 }
Sam Delmerico9dfb1392022-02-10 21:11:59 +00001793
Romain Jobredeaux9c06ef32023-08-21 18:05:29 -04001794 // As framework-res has no sources, no deps in the Bazel sense, and java compilation, dexing and optimization is skipped by
1795 // Soong specifically for it, return early here before any of the conversion work for the above is attempted.
1796 if ctx.ModuleName() == "framework-res" {
1797 appAttrs.bazelAapt = aapt
1798 return true, android.CommonAttributes{Name: a.Name(), SkipData: proptools.BoolPtr(true)}, appAttrs
1799 }
1800
Jingwen Chen65229202023-09-20 13:34:16 +00001801 // Optimization is..
1802 // - enabled by default for android_app, android_test_helper_app
1803 // - disabled by default for android_test
1804 //
1805 // TODO(b/192032291): Disable android_test_helper_app optimization by
1806 // default after auditing downstream usage.
Jingwen Chen256c3892023-09-26 05:51:40 +00001807 if a.dexProperties.Optimize.EnabledByDefault != a.dexer.effectiveOptimizeEnabled() {
1808 // Property is explicitly defined by default from default, so emit the Bazel attribute.
1809 appAttrs.Optimize = proptools.BoolPtr(a.dexer.effectiveOptimizeEnabled())
Jingwen Chen65229202023-09-20 13:34:16 +00001810 }
Jingwen Chen65229202023-09-20 13:34:16 +00001811
Jingwen Chen256c3892023-09-26 05:51:40 +00001812 if a.dexer.effectiveOptimizeEnabled() {
Romain Jobredeaux9973ace2023-08-30 00:27:09 -04001813 handCraftedFlags := ""
1814 if Bool(a.dexProperties.Optimize.Ignore_warnings) {
1815 handCraftedFlags += "-ignorewarning "
1816 }
1817 if !Bool(a.dexProperties.Optimize.Shrink) {
1818 handCraftedFlags += "-dontshrink "
1819 }
1820 if !Bool(a.dexProperties.Optimize.Optimize) {
1821 handCraftedFlags += "-dontoptimize "
1822 }
1823 if !Bool(a.dexProperties.Optimize.Obfuscate) {
1824 handCraftedFlags += "-dontobfuscate "
1825 }
1826 appAttrs.Proguard_specs = bazel.MakeLabelListAttribute(android.BazelLabelForModuleSrc(ctx, a.dexProperties.Optimize.Proguard_flags_files))
1827 if handCraftedFlags != "" {
1828 generatedFlagFileRuleName := a.Name() + "_proguard_flags"
1829 ctx.CreateBazelTargetModule(bazel.BazelTargetModuleProperties{
1830 Rule_class: "genrule",
1831 }, android.CommonAttributes{
1832 Name: generatedFlagFileRuleName,
1833 SkipData: proptools.BoolPtr(true),
1834 }, &genrule.BazelGenruleAttributes{
1835 Outs: []string{a.Name() + "_proguard.flags"},
1836 Cmd: bazel.StringAttribute{
1837 Value: proptools.StringPtr("echo " + handCraftedFlags + "> $(OUTS)"),
1838 },
1839 })
1840 appAttrs.Proguard_specs.Add(bazel.MakeLabelAttribute(":" + generatedFlagFileRuleName))
1841 }
Romain Jobredeaux9973ace2023-08-30 00:27:09 -04001842 }
1843
Romain Jobredeauxd2cc5032023-09-11 16:37:50 -04001844 commonAttrs, bp2BuildInfo, supported := a.convertLibraryAttrsBp2Build(ctx)
1845 if !supported {
Jingwen Chene12c0832023-08-25 09:00:16 +00001846 return false, android.CommonAttributes{}, &bazelAndroidAppAttributes{}
Romain Jobredeauxd2cc5032023-09-11 16:37:50 -04001847 }
Alixee51bd62023-08-29 16:01:46 +00001848 if hasJavaResources := aapt.ConvertJavaResources(ctx, commonAttrs); hasJavaResources {
1849 return false, android.CommonAttributes{}, &bazelAndroidAppAttributes{}
1850 }
1851
Romain Jobredeauxd2cc5032023-09-11 16:37:50 -04001852 depLabels := bp2BuildInfo.DepLabels
1853
1854 deps := depLabels.Deps
1855 deps.Append(depLabels.StaticDeps)
1856
Romain Jobredeaux947dfa72023-06-12 15:40:35 -04001857 var jniDeps bazel.LabelListAttribute
1858 archVariantProps := a.GetArchVariantProperties(ctx, &appProperties{})
1859 for axis, configToProps := range archVariantProps {
1860 for config, _props := range configToProps {
1861 if archProps, ok := _props.(*appProperties); ok {
1862 archJniLibs := android.BazelLabelForModuleDeps(
1863 ctx,
1864 android.LastUniqueStrings(android.CopyOf(archProps.Jni_libs)))
1865 jniDeps.SetSelectValue(axis, config, archJniLibs)
1866 }
1867 }
1868 }
1869 deps.Append(jniDeps)
1870
Alix75db7842023-03-06 22:08:49 +00001871 if !bp2BuildInfo.hasKotlin {
Alix0856f9e2023-01-20 22:15:30 +00001872 appAttrs.javaCommonAttributes = commonAttrs
1873 appAttrs.bazelAapt = aapt
1874 appAttrs.Deps = deps
Alix0856f9e2023-01-20 22:15:30 +00001875 } else {
1876 ktName := a.Name() + "_kt"
Alix0856f9e2023-01-20 22:15:30 +00001877 ctx.CreateBazelTargetModule(
Alix32540022023-03-16 21:06:13 +00001878 AndroidLibraryBazelTargetModuleProperties(),
Alix0856f9e2023-01-20 22:15:30 +00001879 android.CommonAttributes{Name: ktName},
1880 &bazelAndroidLibrary{
1881 javaLibraryAttributes: &javaLibraryAttributes{
1882 javaCommonAttributes: commonAttrs,
1883 Deps: deps,
1884 },
1885 bazelAapt: aapt,
1886 },
1887 )
1888
1889 appAttrs.bazelAapt = &bazelAapt{Manifest: aapt.Manifest}
1890 appAttrs.Deps = bazel.MakeSingleLabelListAttribute(bazel.Label{Label: ":" + ktName})
Romain Jobredeaux2eef2e12023-02-24 12:07:08 -05001891 appAttrs.javaCommonAttributes = &javaCommonAttributes{
1892 Sdk_version: commonAttrs.Sdk_version,
1893 }
Alix0856f9e2023-01-20 22:15:30 +00001894 }
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001895
Jingwen Chene12c0832023-08-25 09:00:16 +00001896 return true, android.CommonAttributes{Name: a.Name(), SkipData: proptools.BoolPtr(true)}, appAttrs
1897}
1898
1899// ConvertWithBp2build is used to convert android_app to Bazel.
Chris Parsons637458d2023-09-19 20:09:00 +00001900func (a *AndroidApp) ConvertWithBp2build(ctx android.Bp2buildMutatorContext) {
Jingwen Chene12c0832023-08-25 09:00:16 +00001901 if ok, commonAttrs, appAttrs := convertWithBp2build(ctx, a); ok {
Romain Jobredeaux9c06ef32023-08-21 18:05:29 -04001902 var props bazel.BazelTargetModuleProperties
1903 if ctx.ModuleName() == "framework-res" {
1904 props = bazel.BazelTargetModuleProperties{
1905 Rule_class: "framework_resources",
1906 Bzl_load_location: "//build/bazel/rules/android:framework_resources.bzl",
1907 }
1908 } else {
1909 props = bazel.BazelTargetModuleProperties{
1910 Rule_class: "android_binary",
1911 Bzl_load_location: "//build/bazel/rules/android:android_binary.bzl",
1912 }
Jingwen Chene12c0832023-08-25 09:00:16 +00001913 }
Jingwen Chene12c0832023-08-25 09:00:16 +00001914 ctx.CreateBazelTargetModule(props, commonAttrs, appAttrs)
1915 }
1916
1917}
1918
1919// ConvertWithBp2build is used to convert android_test to Bazel.
Chris Parsons637458d2023-09-19 20:09:00 +00001920func (at *AndroidTest) ConvertWithBp2build(ctx android.Bp2buildMutatorContext) {
Jingwen Chene12c0832023-08-25 09:00:16 +00001921 if ok, commonAttrs, appAttrs := convertWithBp2build(ctx, &at.AndroidApp); ok {
1922 props := bazel.BazelTargetModuleProperties{
1923 Rule_class: "android_test",
1924 Bzl_load_location: "//build/bazel/rules/android:android_test.bzl",
1925 }
1926
1927 ctx.CreateBazelTargetModule(props, commonAttrs, appAttrs)
1928 }
Alix733110e2023-02-06 14:53:10 +00001929
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001930}
Jingwen Chen65289992023-09-21 15:15:47 +00001931
1932func (atha *AndroidTestHelperApp) ConvertWithBp2build(ctx android.Bp2buildMutatorContext) {
1933 if ok, commonAttrs, appAttrs := convertWithBp2build(ctx, &atha.AndroidApp); ok {
1934 // an android_test_helper_app is an android_binary with testonly = True
1935 commonAttrs.Testonly = proptools.BoolPtr(true)
1936
Jingwen Chen65229202023-09-20 13:34:16 +00001937 // android_test_helper_app sets default values differently to android_app,
Jingwen Chen65289992023-09-21 15:15:47 +00001938 // https://cs.android.com/android/platform/superproject/main/+/main:build/soong/java/app.go;l=1273-1279;drc=e12c083198403ec694af6c625aed11327eb2bf7f
1939 //
1940 // installable: true (settable prop)
1941 // use_embedded_native_libs: true (settable prop)
1942 // lint.test: true (settable prop)
Jingwen Chen65289992023-09-21 15:15:47 +00001943 // AlwaysPackageNativeLibs: true (blueprint mutated prop)
1944 // dexpreopt isTest: true (not prop)
1945
1946 props := bazel.BazelTargetModuleProperties{
1947 Rule_class: "android_binary",
1948 Bzl_load_location: "//build/bazel/rules/android:android_binary.bzl",
1949 }
1950
1951 ctx.CreateBazelTargetModule(props, commonAttrs, appAttrs)
1952 }
1953}