blob: 7b9e6bb147312ffce782113ecabec6f6d2d27f41 [file] [log] [blame]
Colin Cross30e076a2015-04-13 13:58:27 -07001// Copyright 2015 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
Jaewoong Jungf9b44652020-12-21 12:29:12 -080017// This file contains the module implementations for android_app, android_test, and some more
18// related module types, including their override variants.
Colin Cross30e076a2015-04-13 13:58:27 -070019
20import (
Jiakai Zhang4f65a032023-06-01 15:16:58 +010021 "fmt"
Jaewoong Junga5e5abc2019-04-26 14:31:50 -070022 "path/filepath"
Jaewoong Junga5e5abc2019-04-26 14:31:50 -070023 "strings"
Colin Cross30e076a2015-04-13 13:58:27 -070024
Colin Cross50ddcc42019-05-16 12:28:22 -070025 "github.com/google/blueprint"
26 "github.com/google/blueprint/proptools"
27
Colin Cross635c3b02016-05-18 15:37:25 -070028 "android/soong/android"
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -040029 "android/soong/bazel"
Colin Crossa4f08812018-10-02 22:03:40 -070030 "android/soong/cc"
Ulya Trafimovichd4bcea42020-06-03 14:57:22 +010031 "android/soong/dexpreopt"
Romain Jobredeaux9973ace2023-08-30 00:27:09 -040032 "android/soong/genrule"
Colin Cross303e21f2018-08-07 16:49:25 -070033 "android/soong/tradefed"
Spandan Das0e0a8802023-09-20 19:53:30 +000034 "android/soong/ui/metrics/bp2build_metrics_proto"
Colin Cross30e076a2015-04-13 13:58:27 -070035)
36
Colin Cross3bc7ffa2017-11-22 16:19:37 -080037func init() {
Paul Duffinf9b1da02019-12-18 19:51:55 +000038 RegisterAppBuildComponents(android.InitRegistrationContext)
Andrei Onea580636b2022-08-17 16:53:46 +000039 pctx.HostBinToolVariable("ModifyAllowlistCmd", "modify_permissions_allowlist")
Colin Cross3bc7ffa2017-11-22 16:19:37 -080040}
41
Andrei Onea580636b2022-08-17 16:53:46 +000042var (
43 modifyAllowlist = pctx.AndroidStaticRule("modifyAllowlist",
44 blueprint.RuleParams{
45 Command: "${ModifyAllowlistCmd} $in $packageName $out",
46 CommandDeps: []string{"${ModifyAllowlistCmd}"},
47 }, "packageName")
48)
49
Paul Duffinf9b1da02019-12-18 19:51:55 +000050func RegisterAppBuildComponents(ctx android.RegistrationContext) {
51 ctx.RegisterModuleType("android_app", AndroidAppFactory)
52 ctx.RegisterModuleType("android_test", AndroidTestFactory)
53 ctx.RegisterModuleType("android_test_helper_app", AndroidTestHelperAppFactory)
54 ctx.RegisterModuleType("android_app_certificate", AndroidAppCertificateFactory)
55 ctx.RegisterModuleType("override_android_app", OverrideAndroidAppModuleFactory)
56 ctx.RegisterModuleType("override_android_test", OverrideAndroidTestModuleFactory)
Paul Duffinf9b1da02019-12-18 19:51:55 +000057}
58
Colin Cross30e076a2015-04-13 13:58:27 -070059// AndroidManifest.xml merging
60// package splits
61
Colin Crossfabb6082018-02-20 17:22:23 -080062type appProperties struct {
Colin Crossbd01e2a2018-10-04 15:21:03 -070063 // Names of extra android_app_certificate modules to sign the apk with in the form ":module".
Colin Cross7d5136f2015-05-11 13:39:40 -070064 Additional_certificates []string
65
66 // If set, create package-export.apk, which other packages can
67 // use to get PRODUCT-agnostic resource data like IDs and type definitions.
Nan Zhangea568a42017-11-08 21:20:04 -080068 Export_package_resources *bool
Colin Cross7d5136f2015-05-11 13:39:40 -070069
Colin Cross16056062017-12-13 22:46:28 -080070 // Specifies that this app should be installed to the priv-app directory,
71 // where the system will grant it additional privileges not available to
72 // normal apps.
73 Privileged *bool
Colin Crossa97c5d32018-03-28 14:58:31 -070074
75 // list of resource labels to generate individual resource packages
76 Package_splits []string
Jason Monkd4122be2018-08-10 09:33:36 -040077
Colin Crossa4f08812018-10-02 22:03:40 -070078 // list of native libraries that will be provided in or alongside the resulting jar
79 Jni_libs []string `android:"arch_variant"`
80
Colin Cross7204cf02020-05-06 17:51:39 -070081 // if true, use JNI libraries that link against platform APIs even if this module sets
Colin Crossee87c602020-02-19 16:57:15 -080082 // sdk_version.
83 Jni_uses_platform_apis *bool
84
Colin Cross7204cf02020-05-06 17:51:39 -070085 // if true, use JNI libraries that link against SDK APIs even if this module does not set
86 // sdk_version.
87 Jni_uses_sdk_apis *bool
88
Jaewoong Jungbc625cd2019-05-06 15:48:44 -070089 // STL library to use for JNI libraries.
90 Stl *string `android:"arch_variant"`
91
Colin Crosse4246ab2019-02-05 21:55:21 -080092 // Store native libraries uncompressed in the APK and set the android:extractNativeLibs="false" manifest
93 // flag so that they are used from inside the APK at runtime. Defaults to true for android_test modules unless
Jiyong Park52cd06f2019-11-11 10:14:32 +090094 // sdk_version or min_sdk_version is set to a version that doesn't support it (<23), defaults to true for
95 // android_app modules that are embedded to APEXes, defaults to false for other module types where the native
96 // libraries are generally preinstalled outside the APK.
Colin Crosse4246ab2019-02-05 21:55:21 -080097 Use_embedded_native_libs *bool
Colin Cross46abdad2019-02-07 13:07:08 -080098
99 // Store dex files uncompressed in the APK and set the android:useEmbeddedDex="true" manifest attribute so that
100 // they are used from inside the APK at runtime.
101 Use_embedded_dex *bool
Colin Cross47fa9d32019-03-26 10:51:39 -0700102
103 // Forces native libraries to always be packaged into the APK,
104 // Use_embedded_native_libs still selects whether they are stored uncompressed and aligned or compressed.
105 // True for android_test* modules.
106 AlwaysPackageNativeLibs bool `blueprint:"mutated"`
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700107
108 // If set, find and merge all NOTICE files that this module and its dependencies have and store
109 // it in the APK as an asset.
110 Embed_notices *bool
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700111
112 // cc.Coverage related properties
113 PreventInstall bool `blueprint:"mutated"`
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700114 IsCoverageVariant bool `blueprint:"mutated"`
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100115
Harshit Mahajan5b8b7302022-06-10 11:24:05 +0000116 // It can be set to test the behaviour of default target sdk version.
117 // Only required when updatable: false. It is an error if updatable: true and this is false.
118 Enforce_default_target_sdk_version *bool
119
120 // If set, the targetSdkVersion for the target is set to the latest default API level.
121 // This would be by default false, unless updatable: true or
122 // enforce_default_target_sdk_version: true in which case this defaults to true.
123 EnforceDefaultTargetSdkVersion bool `blueprint:"mutated"`
124
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100125 // Whether this app is considered mainline updatable or not. When set to true, this will enforce
Artur Satayevf40fc852020-04-16 13:43:02 +0100126 // additional rules to make sure an app can safely be updated. Default is false.
127 // Prefer using other specific properties if build behaviour must be changed; avoid using this
128 // flag for anything but neverallow rules (unless the behaviour change is invisible to owners).
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100129 Updatable *bool
Andrei Onea580636b2022-08-17 16:53:46 +0000130
131 // Specifies the file that contains the allowlist for this app.
132 Privapp_allowlist *string `android:"path"`
Colin Cross7d5136f2015-05-11 13:39:40 -0700133}
134
Jaewoong Jung525443a2019-02-28 15:35:54 -0800135// android_app properties that can be overridden by override_android_app
136type overridableAppProperties struct {
137 // The name of a certificate in the default certificate directory, blank to use the default product certificate,
138 // or an android_app_certificate module name in the form ":module".
139 Certificate *string
Jaewoong Jung6f373f62019-03-13 10:13:24 -0700140
Jaewoong Jung1c1b6e62021-03-09 15:02:31 -0800141 // Name of the signing certificate lineage file or filegroup module.
142 Lineage *string `android:"path"`
Liz Kammere2b27f42020-05-07 13:24:05 -0700143
Rupert Shuttleworth8eab8692021-11-03 10:39:39 -0400144 // For overriding the --rotation-min-sdk-version property of apksig
145 RotationMinSdkVersion *string
146
Jaewoong Jung6f373f62019-03-13 10:13:24 -0700147 // the package name of this app. The package name in the manifest file is used if one was not given.
148 Package_name *string
Baligh Uddin5b16dfb2020-02-11 17:27:19 -0800149
150 // the logging parent of this app.
151 Logging_parent *string
Liz Kammer9f9fd022020-06-18 19:44:06 +0000152
153 // Whether to rename the package in resources to the override name rather than the base name. Defaults to true.
154 Rename_resources_package *bool
zhidou198f5892022-02-17 02:33:12 +0000155
156 // Names of modules to be overridden. Listed modules can only be other binaries
157 // (in Make or Soong).
158 // This does not completely prevent installation of the overridden binaries, but if both
159 // binaries would be installed by default (in PRODUCT_PACKAGES) the other binary will be removed
160 // from PRODUCT_PACKAGES.
161 Overrides []string
Jaewoong Jung525443a2019-02-28 15:35:54 -0800162}
163
Colin Cross30e076a2015-04-13 13:58:27 -0700164type AndroidApp struct {
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400165 android.BazelModuleBase
Colin Crossa97c5d32018-03-28 14:58:31 -0700166 Library
167 aapt
Jaewoong Jung525443a2019-02-28 15:35:54 -0800168 android.OverridableModuleBase
Colin Crossa97c5d32018-03-28 14:58:31 -0700169
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900170 certificate Certificate
Colin Cross30e076a2015-04-13 13:58:27 -0700171
Colin Crossfabb6082018-02-20 17:22:23 -0800172 appProperties appProperties
Colin Crossae5caf52018-05-22 11:11:52 -0700173
Jaewoong Jung525443a2019-02-28 15:35:54 -0800174 overridableAppProperties overridableAppProperties
175
Colin Cross403cc152020-07-06 14:15:24 -0700176 jniLibs []jniLib
177 installPathForJNISymbols android.Path
178 embeddedJniLibs bool
179 jniCoverageOutputs android.Paths
Colin Crossf6237212018-10-29 23:14:58 -0700180
181 bundleFile android.Path
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800182
183 // the install APK name is normally the same as the module name, but can be overridden with PRODUCT_PACKAGE_NAME_OVERRIDES.
184 installApkName string
Jaewoong Jung4102e5d2019-02-27 16:26:28 -0800185
Colin Cross70dda7e2019-10-01 22:05:35 -0700186 installDir android.InstallPath
Jaewoong Jung0949f312019-09-11 10:25:18 -0700187
Jaewoong Jung7dd4ae22019-09-27 17:13:15 -0700188 onDeviceDir string
189
Jaewoong Jung4102e5d2019-02-27 16:26:28 -0800190 additionalAaptFlags []string
Jaewoong Jung98772792019-07-01 17:15:13 -0700191
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900192 overriddenManifestPackageName string
Artur Satayev1111b842020-04-27 19:05:28 +0100193
194 android.ApexBundleDepsInfo
Matt Banda8c801262022-04-01 17:48:31 +0000195
196 javaApiUsedByOutputFile android.ModuleOutPath
Andrei Onea580636b2022-08-17 16:53:46 +0000197
198 privAppAllowlist android.OptionalPath
Colin Crosse1731a52017-12-14 11:22:55 -0800199}
200
Martin Stjernholm6d415272020-01-31 17:10:36 +0000201func (a *AndroidApp) IsInstallable() bool {
202 return Bool(a.properties.Installable)
203}
204
Colin Crossab8d1382023-07-14 17:23:41 +0000205func (a *AndroidApp) ResourcesNodeDepSet() *android.DepSet[*resourcesNode] {
206 return a.aapt.resourcesNodesDepSet
Colin Cross66f78822018-05-02 12:58:28 -0700207}
208
Sundong Ahne1f05aa2019-08-27 13:55:42 +0900209func (a *AndroidApp) OutputFile() android.Path {
210 return a.outputFile
211}
212
Colin Cross503c1d02020-01-28 14:00:53 -0800213func (a *AndroidApp) Certificate() Certificate {
214 return a.certificate
215}
216
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700217func (a *AndroidApp) JniCoverageOutputs() android.Paths {
218 return a.jniCoverageOutputs
219}
220
Andrei Onea580636b2022-08-17 16:53:46 +0000221func (a *AndroidApp) PrivAppAllowlist() android.OptionalPath {
222 return a.privAppAllowlist
223}
224
Colin Crossa97c5d32018-03-28 14:58:31 -0700225var _ AndroidLibraryDependency = (*AndroidApp)(nil)
226
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900227type Certificate struct {
Colin Cross503c1d02020-01-28 14:00:53 -0800228 Pem, Key android.Path
229 presigned bool
230}
231
Sasha Smundak18d98bc2020-05-27 16:36:07 -0700232var PresignedCertificate = Certificate{presigned: true}
Colin Cross503c1d02020-01-28 14:00:53 -0800233
234func (c Certificate) AndroidMkString() string {
235 if c.presigned {
236 return "PRESIGNED"
237 } else {
238 return c.Pem.String()
239 }
Colin Cross30e076a2015-04-13 13:58:27 -0700240}
241
Colin Cross46c9b8b2017-06-22 16:51:17 -0700242func (a *AndroidApp) DepsMutator(ctx android.BottomUpMutatorContext) {
243 a.Module.deps(ctx)
Colin Crossa4f08812018-10-02 22:03:40 -0700244
Jiyong Park92315372021-04-02 08:45:46 +0900245 if String(a.appProperties.Stl) == "c++_shared" && !a.SdkVersion(ctx).Specified() {
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700246 ctx.PropertyErrorf("stl", "sdk_version must be set in order to use c++_shared")
247 }
248
Jiyong Parkf1691d22021-03-29 20:11:58 +0900249 sdkDep := decodeSdkDep(ctx, android.SdkContext(a))
Paul Duffin250e6192019-06-07 10:44:37 +0100250 if sdkDep.hasFrameworkLibs() {
251 a.aapt.deps(ctx, sdkDep)
Colin Cross30e076a2015-04-13 13:58:27 -0700252 }
Colin Crossa4f08812018-10-02 22:03:40 -0700253
Jiyong Park92315372021-04-02 08:45:46 +0900254 usesSDK := a.SdkVersion(ctx).Specified() && a.SdkVersion(ctx).Kind != android.SdkCorePlatform
Colin Cross3c007702020-05-08 11:20:24 -0700255
256 if usesSDK && Bool(a.appProperties.Jni_uses_sdk_apis) {
257 ctx.PropertyErrorf("jni_uses_sdk_apis",
258 "can only be set for modules that do not set sdk_version")
259 } else if !usesSDK && Bool(a.appProperties.Jni_uses_platform_apis) {
260 ctx.PropertyErrorf("jni_uses_platform_apis",
261 "can only be set for modules that set sdk_version")
262 }
263
Colin Crossa4f08812018-10-02 22:03:40 -0700264 for _, jniTarget := range ctx.MultiTargets() {
Colin Cross0f7d2ef2019-10-16 11:03:10 -0700265 variation := append(jniTarget.Variations(),
266 blueprint.Variation{Mutator: "link", Variation: "shared"})
Colin Crossc511bc52020-04-07 16:50:32 +0000267
268 // If the app builds against an Android SDK use the SDK variant of JNI dependencies
269 // unless jni_uses_platform_apis is set.
Colin Crossc2d24052020-05-13 11:05:02 -0700270 // Don't require the SDK variant for apps that are shipped on vendor, etc., as they already
271 // have stable APIs through the VNDK.
272 if (usesSDK && !a.RequiresStableAPIs(ctx) &&
273 !Bool(a.appProperties.Jni_uses_platform_apis)) ||
Colin Cross7204cf02020-05-06 17:51:39 -0700274 Bool(a.appProperties.Jni_uses_sdk_apis) {
Colin Crossc511bc52020-04-07 16:50:32 +0000275 variation = append(variation, blueprint.Variation{Mutator: "sdk", Variation: "sdk"})
276 }
Colin Crossde78d132020-10-09 18:59:49 -0700277 ctx.AddFarVariationDependencies(variation, jniLibTag, a.appProperties.Jni_libs...)
Colin Crossa4f08812018-10-02 22:03:40 -0700278 }
Colin Cross50ddcc42019-05-16 12:28:22 -0700279
Paul Duffin250e6192019-06-07 10:44:37 +0100280 a.usesLibrary.deps(ctx, sdkDep.hasFrameworkLibs())
Jaewoong Jungb639a6a2019-05-10 15:16:29 -0700281}
Colin Crossbd01e2a2018-10-04 15:21:03 -0700282
Jaewoong Jungb639a6a2019-05-10 15:16:29 -0700283func (a *AndroidApp) OverridablePropertiesDepsMutator(ctx android.BottomUpMutatorContext) {
Jaewoong Jung2ad817c2019-01-18 14:27:16 -0800284 cert := android.SrcIsModule(a.getCertString(ctx))
Colin Crossbd01e2a2018-10-04 15:21:03 -0700285 if cert != "" {
286 ctx.AddDependency(ctx.Module(), certificateTag, cert)
287 }
288
Andrei Onea580636b2022-08-17 16:53:46 +0000289 if a.appProperties.Privapp_allowlist != nil && !Bool(a.appProperties.Privileged) {
Anton Hanssone3f31cf2023-06-03 08:53:47 +0000290 // There are a few uids that are explicitly considered privileged regardless of their
291 // app's location. Bluetooth is one such app. It should arguably be moved to priv-app,
292 // but for now, allow it not to be in priv-app.
293 privilegedBecauseOfUid := ctx.ModuleName() == "Bluetooth"
294 if !privilegedBecauseOfUid {
295 ctx.PropertyErrorf("privapp_allowlist", "privileged must be set in order to use privapp_allowlist (with a few exceptions)")
296 }
Andrei Onea580636b2022-08-17 16:53:46 +0000297 }
298
Colin Crossbd01e2a2018-10-04 15:21:03 -0700299 for _, cert := range a.appProperties.Additional_certificates {
300 cert = android.SrcIsModule(cert)
301 if cert != "" {
302 ctx.AddDependency(ctx.Module(), certificateTag, cert)
303 } else {
304 ctx.PropertyErrorf("additional_certificates",
305 `must be names of android_app_certificate modules in the form ":module"`)
306 }
307 }
Colin Cross30e076a2015-04-13 13:58:27 -0700308}
309
Jeongik Cha538c0d02019-07-11 15:54:27 +0900310func (a *AndroidTestHelperApp) GenerateAndroidBuildActions(ctx android.ModuleContext) {
Alix96ea88452023-08-31 15:48:23 +0000311 applicationId := a.appTestHelperAppProperties.Manifest_values.ApplicationId
312 if applicationId != nil {
313 if a.overridableAppProperties.Package_name != nil {
314 ctx.PropertyErrorf("manifest_values.applicationId", "property is not supported when property package_name is set.")
315 }
316 a.aapt.manifestValues.applicationId = *applicationId
317 }
Jeongik Cha538c0d02019-07-11 15:54:27 +0900318 a.generateAndroidBuildActions(ctx)
319}
320
Colin Cross46c9b8b2017-06-22 16:51:17 -0700321func (a *AndroidApp) GenerateAndroidBuildActions(ctx android.ModuleContext) {
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100322 a.checkAppSdkVersions(ctx)
Colin Crossae5caf52018-05-22 11:11:52 -0700323 a.generateAndroidBuildActions(ctx)
Matt Banda8c801262022-04-01 17:48:31 +0000324 a.generateJavaUsedByApex(ctx)
Colin Crossae5caf52018-05-22 11:11:52 -0700325}
326
Sam Delmerico0e0d96e2023-08-18 22:43:28 +0000327func (a *AndroidApp) MinSdkVersion(ctx android.EarlyModuleContext) android.ApiLevel {
328 defaultMinSdkVersion := a.Module.MinSdkVersion(ctx)
329 if proptools.Bool(a.appProperties.Updatable) {
330 overrideApiLevel := android.MinSdkVersionFromValue(ctx, ctx.DeviceConfig().ApexGlobalMinSdkVersionOverride())
331 if !overrideApiLevel.IsNone() && overrideApiLevel.CompareTo(defaultMinSdkVersion) > 0 {
332 return overrideApiLevel
333 }
334 }
335 return defaultMinSdkVersion
336}
337
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100338func (a *AndroidApp) checkAppSdkVersions(ctx android.ModuleContext) {
Artur Satayev849f8442020-04-28 14:57:42 +0100339 if a.Updatable() {
Jiyong Park92315372021-04-02 08:45:46 +0900340 if !a.SdkVersion(ctx).Stable() {
341 ctx.PropertyErrorf("sdk_version", "Updatable apps must use stable SDKs, found %v", a.SdkVersion(ctx))
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100342 }
Artur Satayevf40fc852020-04-16 13:43:02 +0100343 if String(a.deviceProperties.Min_sdk_version) == "" {
344 ctx.PropertyErrorf("updatable", "updatable apps must set min_sdk_version.")
345 }
Jooyung Han749dc692020-04-15 11:03:39 +0900346
Jiyong Park92315372021-04-02 08:45:46 +0900347 if minSdkVersion, err := a.MinSdkVersion(ctx).EffectiveVersion(ctx); err == nil {
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900348 a.checkJniLibsSdkVersion(ctx, minSdkVersion)
satayevb3fd4112021-12-02 13:59:35 +0000349 android.CheckMinSdkVersion(ctx, minSdkVersion, a.WalkPayloadDeps)
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900350 } else {
351 ctx.PropertyErrorf("min_sdk_version", "%s", err.Error())
352 }
Harshit Mahajan5b8b7302022-06-10 11:24:05 +0000353
354 if !BoolDefault(a.appProperties.Enforce_default_target_sdk_version, true) {
355 ctx.PropertyErrorf("enforce_default_target_sdk_version", "Updatable apps must enforce default target sdk version")
356 }
357 // TODO(b/227460469) after all the modules removes the target sdk version, throw an error if the target sdk version is explicitly set.
358 if a.deviceProperties.Target_sdk_version == nil {
359 a.SetEnforceDefaultTargetSdkVersion(true)
360 }
361 }
362
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100363 a.checkPlatformAPI(ctx)
364 a.checkSdkVersions(ctx)
365}
366
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900367// If an updatable APK sets min_sdk_version, min_sdk_vesion of JNI libs should match with it.
368// This check is enforced for "updatable" APKs (including APK-in-APEX).
Jiyong Park54105c42021-03-31 18:17:53 +0900369func (a *AndroidApp) checkJniLibsSdkVersion(ctx android.ModuleContext, minSdkVersion android.ApiLevel) {
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900370 // It's enough to check direct JNI deps' sdk_version because all transitive deps from JNI deps are checked in cc.checkLinkType()
371 ctx.VisitDirectDeps(func(m android.Module) {
372 if !IsJniDepTag(ctx.OtherModuleDependencyTag(m)) {
373 return
374 }
375 dep, _ := m.(*cc.Module)
Jooyung Han652d5b32020-05-20 17:12:13 +0900376 // The domain of cc.sdk_version is "current" and <number>
Jiyong Parkf1691d22021-03-29 20:11:58 +0900377 // We can rely on android.SdkSpec to convert it to <number> so that "current" is
378 // handled properly regardless of sdk finalization.
Spandan Das2e8c0442022-05-08 00:39:35 +0000379 jniSdkVersion, err := android.SdkSpecFrom(ctx, dep.MinSdkVersion()).EffectiveVersion(ctx)
Jiyong Park54105c42021-03-31 18:17:53 +0900380 if err != nil || minSdkVersion.LessThan(jniSdkVersion) {
Spandan Das2e8c0442022-05-08 00:39:35 +0000381 ctx.OtherModuleErrorf(dep, "min_sdk_version(%v) is higher than min_sdk_version(%v) of the containing android_app(%v)",
382 dep.MinSdkVersion(), minSdkVersion, ctx.ModuleName())
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900383 return
384 }
385
386 })
387}
388
Sasha Smundak6ad77252019-05-01 13:16:22 -0700389// Returns true if the native libraries should be stored in the APK uncompressed and the
Colin Crosse4246ab2019-02-05 21:55:21 -0800390// extractNativeLibs application flag should be set to false in the manifest.
Sasha Smundak6ad77252019-05-01 13:16:22 -0700391func (a *AndroidApp) useEmbeddedNativeLibs(ctx android.ModuleContext) bool {
Jiyong Park92315372021-04-02 08:45:46 +0900392 minSdkVersion, err := a.MinSdkVersion(ctx).EffectiveVersion(ctx)
Colin Crosse4246ab2019-02-05 21:55:21 -0800393 if err != nil {
Jiyong Park92315372021-04-02 08:45:46 +0900394 ctx.PropertyErrorf("min_sdk_version", "invalid value %q: %s", a.MinSdkVersion(ctx), err)
Colin Crosse4246ab2019-02-05 21:55:21 -0800395 }
396
Colin Cross56a83212020-09-15 18:30:11 -0700397 apexInfo := ctx.Provider(android.ApexInfoProvider).(android.ApexInfo)
Jiyong Park54105c42021-03-31 18:17:53 +0900398 return (minSdkVersion.FinalOrFutureInt() >= 23 && Bool(a.appProperties.Use_embedded_native_libs)) ||
Colin Cross56a83212020-09-15 18:30:11 -0700399 !apexInfo.IsForPlatform()
Colin Crosse4246ab2019-02-05 21:55:21 -0800400}
401
Colin Cross43f08db2018-11-12 10:13:39 -0800402// Returns whether this module should have the dex file stored uncompressed in the APK.
403func (a *AndroidApp) shouldUncompressDex(ctx android.ModuleContext) bool {
Colin Cross46abdad2019-02-07 13:07:08 -0800404 if Bool(a.appProperties.Use_embedded_dex) {
405 return true
406 }
407
Colin Cross53a87f52019-06-25 13:35:30 -0700408 // Uncompress dex in APKs of privileged apps (even for unbundled builds, they may
409 // be preinstalled as prebuilts).
Jiyong Parkf7487312019-10-17 12:54:30 +0900410 if ctx.Config().UncompressPrivAppDex() && a.Privileged() {
Nicolas Geoffrayfa6e9ec2019-02-12 13:12:16 +0000411 return true
412 }
413
Colin Cross53a87f52019-06-25 13:35:30 -0700414 if ctx.Config().UnbundledBuild() {
415 return false
416 }
417
Jaewoong Jungacf18d72019-05-02 14:55:29 -0700418 return shouldUncompressDex(ctx, &a.dexpreopter)
Colin Cross5a0dcd52018-10-05 14:20:06 -0700419}
420
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700421func (a *AndroidApp) shouldEmbedJnis(ctx android.BaseModuleContext) bool {
Colin Cross56a83212020-09-15 18:30:11 -0700422 apexInfo := ctx.Provider(android.ApexInfoProvider).(android.ApexInfo)
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700423 return ctx.Config().UnbundledBuild() || Bool(a.appProperties.Use_embedded_native_libs) ||
Colin Cross56a83212020-09-15 18:30:11 -0700424 !apexInfo.IsForPlatform() || a.appProperties.AlwaysPackageNativeLibs
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700425}
426
Liz Kammer9f9fd022020-06-18 19:44:06 +0000427func generateAaptRenamePackageFlags(packageName string, renameResourcesPackage bool) []string {
428 aaptFlags := []string{"--rename-manifest-package " + packageName}
429 if renameResourcesPackage {
430 // Required to rename the package name in the resources table.
431 aaptFlags = append(aaptFlags, "--rename-resources-package "+packageName)
432 }
433 return aaptFlags
434}
435
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900436func (a *AndroidApp) OverriddenManifestPackageName() string {
437 return a.overriddenManifestPackageName
438}
439
Liz Kammer9f9fd022020-06-18 19:44:06 +0000440func (a *AndroidApp) renameResourcesPackage() bool {
441 return proptools.BoolDefault(a.overridableAppProperties.Rename_resources_package, true)
442}
443
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800444func (a *AndroidApp) aaptBuildActions(ctx android.ModuleContext) {
Lorenzo Colittifa9b3f32021-03-30 10:38:26 +0900445 usePlatformAPI := proptools.Bool(a.Module.deviceProperties.Platform_apis)
Jiyong Park92315372021-04-02 08:45:46 +0900446 if ctx.Module().(android.SdkContext).SdkVersion(ctx).Kind == android.SdkModule {
Lorenzo Colittifa9b3f32021-03-30 10:38:26 +0900447 usePlatformAPI = true
448 }
449 a.aapt.usesNonSdkApis = usePlatformAPI
David Brazdild25060a2019-02-18 18:24:16 +0000450
Jaewoong Jungc27ab662019-05-30 15:51:14 -0700451 // Ask manifest_fixer to add or update the application element indicating this app has no code.
452 a.aapt.hasNoCode = !a.hasCode(ctx)
453
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800454 aaptLinkFlags := []string{}
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800455
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800456 // Add TARGET_AAPT_CHARACTERISTICS values to AAPT link flags if they exist and --product flags were not provided.
Jaewoong Jung3aff5782020-02-11 07:54:35 -0800457 hasProduct := android.PrefixInList(a.aaptProperties.Aaptflags, "--product")
Colin Crosse78dcd32018-04-19 15:25:19 -0700458 if !hasProduct && len(ctx.Config().ProductAAPTCharacteristics()) > 0 {
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800459 aaptLinkFlags = append(aaptLinkFlags, "--product", ctx.Config().ProductAAPTCharacteristics())
Colin Crosse78dcd32018-04-19 15:25:19 -0700460 }
461
Dan Willemsen72be5902018-10-24 20:24:57 -0700462 if !Bool(a.aaptProperties.Aapt_include_all_resources) {
463 // Product AAPT config
464 for _, aaptConfig := range ctx.Config().ProductAAPTConfig() {
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800465 aaptLinkFlags = append(aaptLinkFlags, "-c", aaptConfig)
Dan Willemsen72be5902018-10-24 20:24:57 -0700466 }
Colin Crosse78dcd32018-04-19 15:25:19 -0700467
Dan Willemsen72be5902018-10-24 20:24:57 -0700468 // Product AAPT preferred config
469 if len(ctx.Config().ProductAAPTPreferredConfig()) > 0 {
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800470 aaptLinkFlags = append(aaptLinkFlags, "--preferred-density", ctx.Config().ProductAAPTPreferredConfig())
Dan Willemsen72be5902018-10-24 20:24:57 -0700471 }
Colin Crosse78dcd32018-04-19 15:25:19 -0700472 }
473
Jiyong Park7f67f482019-01-05 12:57:48 +0900474 manifestPackageName, overridden := ctx.DeviceConfig().OverrideManifestPackageNameFor(ctx.ModuleName())
Jaewoong Jung6f373f62019-03-13 10:13:24 -0700475 if overridden || a.overridableAppProperties.Package_name != nil {
476 // The product override variable has a priority over the package_name property.
477 if !overridden {
478 manifestPackageName = *a.overridableAppProperties.Package_name
479 }
Liz Kammer9f9fd022020-06-18 19:44:06 +0000480 aaptLinkFlags = append(aaptLinkFlags, generateAaptRenamePackageFlags(manifestPackageName, a.renameResourcesPackage())...)
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900481 a.overriddenManifestPackageName = manifestPackageName
Jiyong Park7f67f482019-01-05 12:57:48 +0900482 }
483
Jaewoong Jung4102e5d2019-02-27 16:26:28 -0800484 aaptLinkFlags = append(aaptLinkFlags, a.additionalAaptFlags...)
485
Colin Crosse560c4a2019-03-19 16:03:11 -0700486 a.aapt.splitNames = a.appProperties.Package_splits
Baligh Uddin5b16dfb2020-02-11 17:27:19 -0800487 a.aapt.LoggingParent = String(a.overridableAppProperties.Logging_parent)
Alexei Nicoara69cf0f32022-07-27 14:59:18 +0100488 if a.Updatable() {
489 a.aapt.defaultManifestVersion = android.DefaultUpdatableModuleVersion
490 }
Alixf7a10272023-09-27 16:47:56 +0000491 a.aapt.buildActions(ctx,
492 aaptBuildActionOptions{
493 android.SdkContext(a),
494 a.classLoaderContexts,
495 a.usesLibraryProperties.Exclude_uses_libs,
496 a.enforceDefaultTargetSdkVersion(),
497 aaptLinkFlags,
498 },
499 )
Colin Cross30e076a2015-04-13 13:58:27 -0700500
Colin Cross46c9b8b2017-06-22 16:51:17 -0700501 // apps manifests are handled by aapt, don't let Module see them
Dan Willemsen34cc69e2015-09-23 15:26:20 -0700502 a.properties.Manifest = nil
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800503}
Colin Cross30e076a2015-04-13 13:58:27 -0700504
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800505func (a *AndroidApp) proguardBuildActions(ctx android.ModuleContext) {
Colin Cross89c31582018-04-30 15:55:11 -0700506 var staticLibProguardFlagFiles android.Paths
507 ctx.VisitDirectDeps(func(m android.Module) {
Sam Delmerico95d70942023-08-02 18:00:35 -0400508 depProguardInfo := ctx.OtherModuleProvider(m, ProguardSpecInfoProvider).(ProguardSpecInfo)
509 staticLibProguardFlagFiles = append(staticLibProguardFlagFiles, depProguardInfo.UnconditionallyExportedProguardFlags.ToList()...)
510 if ctx.OtherModuleDependencyTag(m) == staticLibTag {
511 staticLibProguardFlagFiles = append(staticLibProguardFlagFiles, depProguardInfo.ProguardFlagsFiles.ToList()...)
Colin Cross89c31582018-04-30 15:55:11 -0700512 }
513 })
514
515 staticLibProguardFlagFiles = android.FirstUniquePaths(staticLibProguardFlagFiles)
516
517 a.Module.extraProguardFlagFiles = append(a.Module.extraProguardFlagFiles, staticLibProguardFlagFiles...)
518 a.Module.extraProguardFlagFiles = append(a.Module.extraProguardFlagFiles, a.proguardOptionsFile)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800519}
Colin Cross66dbc0b2017-12-28 12:23:20 -0800520
Colin Cross403cc152020-07-06 14:15:24 -0700521func (a *AndroidApp) installPath(ctx android.ModuleContext) android.InstallPath {
Colin Cross43f08db2018-11-12 10:13:39 -0800522 var installDir string
523 if ctx.ModuleName() == "framework-res" {
524 // framework-res.apk is installed as system/framework/framework-res.apk
525 installDir = "framework"
Jiyong Parkf7487312019-10-17 12:54:30 +0900526 } else if a.Privileged() {
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800527 installDir = filepath.Join("priv-app", a.installApkName)
Colin Cross43f08db2018-11-12 10:13:39 -0800528 } else {
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800529 installDir = filepath.Join("app", a.installApkName)
Colin Cross43f08db2018-11-12 10:13:39 -0800530 }
Colin Cross403cc152020-07-06 14:15:24 -0700531
532 return android.PathForModuleInstall(ctx, installDir, a.installApkName+".apk")
533}
534
Ulya Trafimovich18554242020-11-03 15:55:11 +0000535func (a *AndroidApp) dexBuildActions(ctx android.ModuleContext) android.Path {
Colin Cross403cc152020-07-06 14:15:24 -0700536 a.dexpreopter.installPath = a.installPath(ctx)
Ulya Trafimovich76b08522021-01-14 17:52:43 +0000537 a.dexpreopter.isApp = true
Liz Kammera7a64f32020-07-09 15:16:41 -0700538 if a.dexProperties.Uncompress_dex == nil {
David Srbeckye033cba2020-05-20 22:20:28 +0100539 // If the value was not force-set by the user, use reasonable default based on the module.
Liz Kammera7a64f32020-07-09 15:16:41 -0700540 a.dexProperties.Uncompress_dex = proptools.BoolPtr(a.shouldUncompressDex(ctx))
David Srbeckye033cba2020-05-20 22:20:28 +0100541 }
Liz Kammera7a64f32020-07-09 15:16:41 -0700542 a.dexpreopter.uncompressedDex = *a.dexProperties.Uncompress_dex
Colin Cross50ddcc42019-05-16 12:28:22 -0700543 a.dexpreopter.enforceUsesLibs = a.usesLibrary.enforceUsesLibraries()
Ulya Trafimovichb23d28c2020-10-08 12:53:58 +0100544 a.dexpreopter.classLoaderContexts = a.classLoaderContexts
Colin Cross50ddcc42019-05-16 12:28:22 -0700545 a.dexpreopter.manifestFile = a.mergedManifestFile
Colin Crossfa9bfcd2021-11-10 16:42:38 -0800546 a.dexpreopter.preventInstall = a.appProperties.PreventInstall
Colin Cross50ddcc42019-05-16 12:28:22 -0700547
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800548 if ctx.ModuleName() != "framework-res" {
Colin Cross4eae06d2023-06-20 22:40:02 -0700549 var extraSrcJars android.Paths
550 var extraClasspathJars android.Paths
551 var extraCombinedJars android.Paths
552 if a.useResourceProcessorBusyBox() {
553 // When building an app with ResourceProcessorBusyBox enabled ResourceProcessorBusyBox has already
554 // created R.class files that provide IDs for resources in busybox/R.jar. Pass that file in the
555 // classpath when compiling everything else, and add it to the final classes jar.
556 extraClasspathJars = android.Paths{a.aapt.rJar}
557 extraCombinedJars = android.Paths{a.aapt.rJar}
558 } else {
559 // When building an app without ResourceProcessorBusyBox the aapt2 rule creates R.srcjar containing
560 // R.java files for the app's package and the packages from all transitive static android_library
561 // dependencies. Compile the srcjar alongside the rest of the sources.
562 extraSrcJars = android.Paths{a.aapt.aaptSrcJar}
563 }
564
565 a.Module.compile(ctx, extraSrcJars, extraClasspathJars, extraCombinedJars)
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800566 }
Colin Cross30e076a2015-04-13 13:58:27 -0700567
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +0100568 return a.dexJarFile.PathOrNil()
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800569}
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800570
Sam Delmerico82602492022-06-10 17:05:42 +0000571func (a *AndroidApp) jniBuildActions(jniLibs []jniLib, prebuiltJniPackages android.Paths, ctx android.ModuleContext) android.WritablePath {
Colin Crossa4f08812018-10-02 22:03:40 -0700572 var jniJarFile android.WritablePath
Sam Delmerico82602492022-06-10 17:05:42 +0000573 if len(jniLibs) > 0 || len(prebuiltJniPackages) > 0 {
Colin Cross403cc152020-07-06 14:15:24 -0700574 a.jniLibs = jniLibs
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700575 if a.shouldEmbedJnis(ctx) {
Colin Crossa4f08812018-10-02 22:03:40 -0700576 jniJarFile = android.PathForModuleOut(ctx, "jnilibs.zip")
Colin Crossc68db4b2021-11-11 18:59:15 -0800577 a.installPathForJNISymbols = a.installPath(ctx)
Sam Delmerico82602492022-06-10 17:05:42 +0000578 TransformJniLibsToJar(ctx, jniJarFile, jniLibs, prebuiltJniPackages, a.useEmbeddedNativeLibs(ctx))
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700579 for _, jni := range jniLibs {
580 if jni.coverageFile.Valid() {
Jaewoong Jung46984ee2020-04-07 13:07:55 -0700581 // Only collect coverage for the first target arch if this is a multilib target.
582 // TODO(jungjw): Ideally, we want to collect both reports, but that would cause coverage
583 // data file path collisions since the current coverage file path format doesn't contain
584 // arch-related strings. This is fine for now though; the code coverage team doesn't use
585 // multi-arch targets such as test_suite_* for coverage collections yet.
586 //
587 // Work with the team to come up with a new format that handles multilib modules properly
588 // and change this.
589 if len(ctx.Config().Targets[android.Android]) == 1 ||
Jaewoong Jung642916f2020-10-09 17:25:15 -0700590 ctx.Config().AndroidFirstDeviceTarget.Arch.ArchType == jni.target.Arch.ArchType {
Jaewoong Jung46984ee2020-04-07 13:07:55 -0700591 a.jniCoverageOutputs = append(a.jniCoverageOutputs, jni.coverageFile.Path())
592 }
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700593 }
594 }
Colin Cross403cc152020-07-06 14:15:24 -0700595 a.embeddedJniLibs = true
Colin Crossa4f08812018-10-02 22:03:40 -0700596 }
597 }
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800598 return jniJarFile
599}
Colin Crossa4f08812018-10-02 22:03:40 -0700600
Colin Cross403cc152020-07-06 14:15:24 -0700601func (a *AndroidApp) JNISymbolsInstalls(installPath string) android.RuleBuilderInstalls {
602 var jniSymbols android.RuleBuilderInstalls
603 for _, jniLib := range a.jniLibs {
604 if jniLib.unstrippedFile != nil {
605 jniSymbols = append(jniSymbols, android.RuleBuilderInstall{
606 From: jniLib.unstrippedFile,
607 To: filepath.Join(installPath, targetToJniDir(jniLib.target), jniLib.unstrippedFile.Base()),
608 })
609 }
610 }
611 return jniSymbols
612}
613
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700614// Reads and prepends a main cert from the default cert dir if it hasn't been set already, i.e. it
615// isn't a cert module reference. Also checks and enforces system cert restriction if applicable.
Colin Crossbc2c8a72022-09-14 12:45:42 -0700616func processMainCert(m android.ModuleBase, certPropValue string, certificates []Certificate,
617 ctx android.ModuleContext) (mainCertificate Certificate, allCertificates []Certificate) {
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700618 if android.SrcIsModule(certPropValue) == "" {
619 var mainCert Certificate
620 if certPropValue != "" {
621 defaultDir := ctx.Config().DefaultAppCertificateDir(ctx)
622 mainCert = Certificate{
Colin Cross503c1d02020-01-28 14:00:53 -0800623 Pem: defaultDir.Join(ctx, certPropValue+".x509.pem"),
624 Key: defaultDir.Join(ctx, certPropValue+".pk8"),
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700625 }
626 } else {
627 pem, key := ctx.Config().DefaultAppCertificate(ctx)
Colin Cross503c1d02020-01-28 14:00:53 -0800628 mainCert = Certificate{
629 Pem: pem,
630 Key: key,
631 }
Colin Crossbd01e2a2018-10-04 15:21:03 -0700632 }
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700633 certificates = append([]Certificate{mainCert}, certificates...)
Colin Crossbd01e2a2018-10-04 15:21:03 -0700634 }
635
Colin Crossbc2c8a72022-09-14 12:45:42 -0700636 if len(certificates) > 0 {
637 mainCertificate = certificates[0]
638 } else {
639 // This can be reached with an empty certificate list if AllowMissingDependencies is set
640 // and the certificate property for this module is a module reference to a missing module.
641 if !ctx.Config().AllowMissingDependencies() && len(ctx.GetMissingDependencies()) > 0 {
642 panic("Should only get here if AllowMissingDependencies set and there are missing dependencies")
643 }
644 // Set a certificate to avoid panics later when accessing it.
645 mainCertificate = Certificate{
646 Key: android.PathForModuleOut(ctx, "missing.pk8"),
Colin Crossa54f4b52022-11-21 04:35:53 +0000647 Pem: android.PathForModuleOut(ctx, "missing.x509.pem"),
Colin Crossbc2c8a72022-09-14 12:45:42 -0700648 }
649 }
650
Zyan Wub7550aa2023-05-18 15:46:31 +0800651 if !m.Platform() {
652 certPath := mainCertificate.Pem.String()
653 systemCertPath := ctx.Config().DefaultAppCertificateDir(ctx).String()
654 if strings.HasPrefix(certPath, systemCertPath) {
655 enforceSystemCert := ctx.Config().EnforceSystemCertificate()
656 allowed := ctx.Config().EnforceSystemCertificateAllowList()
657
658 if enforceSystemCert && !inList(m.Name(), allowed) {
659 ctx.PropertyErrorf("certificate", "The module in product partition cannot be signed with certificate in system.")
660 }
661 }
662 }
663
Colin Crossbc2c8a72022-09-14 12:45:42 -0700664 return mainCertificate, certificates
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800665}
666
Jooyung Han39ee1192020-03-23 20:21:11 +0900667func (a *AndroidApp) InstallApkName() string {
668 return a.installApkName
669}
670
Sam Delmerico15809f82023-05-15 17:21:47 -0400671func (a *AndroidApp) createPrivappAllowlist(ctx android.ModuleContext) android.Path {
Andrei Onea580636b2022-08-17 16:53:46 +0000672 if a.appProperties.Privapp_allowlist == nil {
673 return nil
674 }
Sam Delmerico15809f82023-05-15 17:21:47 -0400675
676 isOverrideApp := a.GetOverriddenBy() != ""
677 if !isOverrideApp {
678 // if this is not an override, we don't need to rewrite the existing privapp allowlist
679 return android.PathForModuleSrc(ctx, *a.appProperties.Privapp_allowlist)
680 }
681
Andrei Onea580636b2022-08-17 16:53:46 +0000682 if a.overridableAppProperties.Package_name == nil {
683 ctx.PropertyErrorf("privapp_allowlist", "package_name must be set to use privapp_allowlist")
684 }
Sam Delmerico15809f82023-05-15 17:21:47 -0400685
Andrei Onea580636b2022-08-17 16:53:46 +0000686 packageName := *a.overridableAppProperties.Package_name
687 fileName := "privapp_allowlist_" + packageName + ".xml"
688 outPath := android.PathForModuleOut(ctx, fileName).OutputPath
689 ctx.Build(pctx, android.BuildParams{
690 Rule: modifyAllowlist,
691 Input: android.PathForModuleSrc(ctx, *a.appProperties.Privapp_allowlist),
692 Output: outPath,
693 Args: map[string]string{
694 "packageName": packageName,
695 },
696 })
697 return &outPath
698}
699
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800700func (a *AndroidApp) generateAndroidBuildActions(ctx android.ModuleContext) {
Colin Cross50ddcc42019-05-16 12:28:22 -0700701 var apkDeps android.Paths
702
Colin Cross56a83212020-09-15 18:30:11 -0700703 if !ctx.Provider(android.ApexInfoProvider).(android.ApexInfo).IsForPlatform() {
704 a.hideApexVariantFromMake = true
705 }
706
Jeongik Cha538c0d02019-07-11 15:54:27 +0900707 a.aapt.useEmbeddedNativeLibs = a.useEmbeddedNativeLibs(ctx)
708 a.aapt.useEmbeddedDex = Bool(a.appProperties.Use_embedded_dex)
709
Jihoon Kang1bfb6f22023-07-01 00:13:47 +0000710 // Unlike installApkName, a.stem should respect base module name for override_android_app.
711 // Therefore, use ctx.ModuleName() instead of a.Name().
712 a.stem = proptools.StringDefault(a.overridableDeviceProperties.Stem, ctx.ModuleName())
713
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800714 // Check if the install APK name needs to be overridden.
Jihoon Kang1bfb6f22023-07-01 00:13:47 +0000715 // Both android_app and override_android_app module are expected to possess
716 // its module bound apk path. However, override_android_app inherits ctx.ModuleName()
717 // from the base module. Therefore, use a.Name() which represents
718 // the module name for both android_app and override_android_app.
719 a.installApkName = ctx.DeviceConfig().OverridePackageNameFor(
720 proptools.StringDefault(a.overridableDeviceProperties.Stem, a.Name()))
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800721
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700722 if ctx.ModuleName() == "framework-res" {
723 // framework-res.apk is installed as system/framework/framework-res.apk
Jaewoong Jung0949f312019-09-11 10:25:18 -0700724 a.installDir = android.PathForModuleInstall(ctx, "framework")
Jiyong Parkf7487312019-10-17 12:54:30 +0900725 } else if a.Privileged() {
Jaewoong Jung0949f312019-09-11 10:25:18 -0700726 a.installDir = android.PathForModuleInstall(ctx, "priv-app", a.installApkName)
727 } else if ctx.InstallInTestcases() {
Jaewoong Jung326a9412019-11-21 10:41:00 -0800728 a.installDir = android.PathForModuleInstall(ctx, a.installApkName, ctx.DeviceConfig().DeviceArch())
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700729 } else {
Jaewoong Jung0949f312019-09-11 10:25:18 -0700730 a.installDir = android.PathForModuleInstall(ctx, "app", a.installApkName)
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700731 }
Jaewoong Jung7dd4ae22019-09-27 17:13:15 -0700732 a.onDeviceDir = android.InstallPathToOnDevicePath(ctx, a.installDir)
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700733
Ulya Trafimovichb23d28c2020-10-08 12:53:58 +0100734 a.classLoaderContexts = a.usesLibrary.classLoaderContextForUsesLibDeps(ctx)
Ulya Trafimovich18554242020-11-03 15:55:11 +0000735
Colin Cross61fb62e2022-06-23 10:46:28 -0700736 var noticeAssetPath android.WritablePath
737 if Bool(a.appProperties.Embed_notices) || ctx.Config().IsEnvTrue("ALWAYS_EMBED_NOTICES") {
738 // The rule to create the notice file can't be generated yet, as the final output path
739 // for the apk isn't known yet. Add the path where the notice file will be generated to the
740 // aapt rules now before calling aaptBuildActions, the rule to create the notice file will
741 // be generated later.
742 noticeAssetPath = android.PathForModuleOut(ctx, "NOTICE", "NOTICE.html.gz")
743 a.aapt.noticeFile = android.OptionalPathForPath(noticeAssetPath)
744 }
745
Harshit Mahajan8f202ad2023-01-09 20:45:55 +0000746 // For apps targeting latest target_sdk_version
747 if Bool(a.appProperties.Enforce_default_target_sdk_version) {
748 a.SetEnforceDefaultTargetSdkVersion(true)
749 }
750
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800751 // Process all building blocks, from AAPT to certificates.
752 a.aaptBuildActions(ctx)
753
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +0100754 // The decision to enforce <uses-library> checks is made before adding implicit SDK libraries.
755 a.usesLibrary.freezeEnforceUsesLibraries()
756
757 // Add implicit SDK libraries to <uses-library> list.
Ulya Trafimovichfc0f6e32021-08-12 16:16:11 +0100758 requiredUsesLibs, optionalUsesLibs := a.classLoaderContexts.UsesLibs()
759 for _, usesLib := range requiredUsesLibs {
760 a.usesLibrary.addLib(usesLib, false)
761 }
762 for _, usesLib := range optionalUsesLibs {
763 a.usesLibrary.addLib(usesLib, true)
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +0100764 }
765
766 // Check that the <uses-library> list is coherent with the manifest.
Colin Cross50ddcc42019-05-16 12:28:22 -0700767 if a.usesLibrary.enforceUsesLibraries() {
768 manifestCheckFile := a.usesLibrary.verifyUsesLibrariesManifest(ctx, a.mergedManifestFile)
769 apkDeps = append(apkDeps, manifestCheckFile)
770 }
771
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800772 a.proguardBuildActions(ctx)
773
Colin Cross014489c2020-06-02 20:09:13 -0700774 a.linter.mergedManifest = a.aapt.mergedManifestFile
775 a.linter.manifest = a.aapt.manifestPath
776 a.linter.resources = a.aapt.resourceFiles
Colin Crossc0efd1d2020-07-03 11:56:24 -0700777 a.linter.buildModuleReportZip = ctx.Config().UnbundledBuildApps()
Colin Cross014489c2020-06-02 20:09:13 -0700778
Ulya Trafimovich18554242020-11-03 15:55:11 +0000779 dexJarFile := a.dexBuildActions(ctx)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800780
Colin Crossbc2c8a72022-09-14 12:45:42 -0700781 jniLibs, prebuiltJniPackages, certificates := collectAppDeps(ctx, a, a.shouldEmbedJnis(ctx), !Bool(a.appProperties.Jni_uses_platform_apis))
Sam Delmerico82602492022-06-10 17:05:42 +0000782 jniJarFile := a.jniBuildActions(jniLibs, prebuiltJniPackages, ctx)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800783
784 if ctx.Failed() {
785 return
786 }
787
Colin Crossbc2c8a72022-09-14 12:45:42 -0700788 a.certificate, certificates = processMainCert(a.ModuleBase, a.getCertString(ctx), certificates, ctx)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800789
790 // Build a final signed app package.
Jaewoong Jung5a498812019-11-07 14:14:38 -0800791 packageFile := android.PathForModuleOut(ctx, a.installApkName+".apk")
Songchun Fan17d69e32020-03-24 20:32:24 -0700792 v4SigningRequested := Bool(a.Module.deviceProperties.V4_signature)
793 var v4SignatureFile android.WritablePath = nil
794 if v4SigningRequested {
795 v4SignatureFile = android.PathForModuleOut(ctx, a.installApkName+".apk.idsig")
796 }
Liz Kammere2b27f42020-05-07 13:24:05 -0700797 var lineageFile android.Path
798 if lineage := String(a.overridableAppProperties.Lineage); lineage != "" {
799 lineageFile = android.PathForModuleSrc(ctx, lineage)
800 }
Rupert Shuttleworth8eab8692021-11-03 10:39:39 -0400801 rotationMinSdkVersion := String(a.overridableAppProperties.RotationMinSdkVersion)
802
Rico Wind351bac92022-09-22 10:41:42 +0200803 CreateAndSignAppPackage(ctx, packageFile, a.exportPackage, jniJarFile, dexJarFile, certificates, apkDeps, v4SignatureFile, lineageFile, rotationMinSdkVersion, Bool(a.dexProperties.Optimize.Shrink_resources))
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800804 a.outputFile = packageFile
Songchun Fan17d69e32020-03-24 20:32:24 -0700805 if v4SigningRequested {
806 a.extraOutputFiles = append(a.extraOutputFiles, v4SignatureFile)
807 }
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800808
Colin Cross61fb62e2022-06-23 10:46:28 -0700809 if a.aapt.noticeFile.Valid() {
810 // Generating the notice file rule has to be here after a.outputFile is known.
Bob Badoureef4c1c2022-05-16 12:20:04 -0700811 noticeFile := android.PathForModuleOut(ctx, "NOTICE.html.gz")
Bob Badourc6ec9fb2022-06-08 15:59:35 -0700812 android.BuildNoticeHtmlOutputFromLicenseMetadata(
813 ctx, noticeFile, "", "",
814 []string{
815 a.installDir.String() + "/",
816 android.PathForModuleInstall(ctx).String() + "/",
817 a.outputFile.String(),
818 })
Bob Badoureef4c1c2022-05-16 12:20:04 -0700819 builder := android.NewRuleBuilder(pctx, ctx)
820 builder.Command().Text("cp").
821 Input(noticeFile).
822 Output(noticeAssetPath)
823 builder.Build("notice_dir", "Building notice dir")
Bob Badoureef4c1c2022-05-16 12:20:04 -0700824 }
825
Colin Crosse560c4a2019-03-19 16:03:11 -0700826 for _, split := range a.aapt.splits {
827 // Sign the split APKs
Jaewoong Jung5a498812019-11-07 14:14:38 -0800828 packageFile := android.PathForModuleOut(ctx, a.installApkName+"_"+split.suffix+".apk")
Songchun Fan17d69e32020-03-24 20:32:24 -0700829 if v4SigningRequested {
830 v4SignatureFile = android.PathForModuleOut(ctx, a.installApkName+"_"+split.suffix+".apk.idsig")
831 }
Rico Wind351bac92022-09-22 10:41:42 +0200832 CreateAndSignAppPackage(ctx, packageFile, split.path, nil, nil, certificates, apkDeps, v4SignatureFile, lineageFile, rotationMinSdkVersion, false)
Colin Crosse560c4a2019-03-19 16:03:11 -0700833 a.extraOutputFiles = append(a.extraOutputFiles, packageFile)
Songchun Fan17d69e32020-03-24 20:32:24 -0700834 if v4SigningRequested {
835 a.extraOutputFiles = append(a.extraOutputFiles, v4SignatureFile)
836 }
Colin Crosse560c4a2019-03-19 16:03:11 -0700837 }
838
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800839 // Build an app bundle.
Colin Crossf6237212018-10-29 23:14:58 -0700840 bundleFile := android.PathForModuleOut(ctx, "base.zip")
841 BuildBundleModule(ctx, bundleFile, a.exportPackage, jniJarFile, dexJarFile)
842 a.bundleFile = bundleFile
843
Andrei Onea580636b2022-08-17 16:53:46 +0000844 allowlist := a.createPrivappAllowlist(ctx)
845 if allowlist != nil {
846 a.privAppAllowlist = android.OptionalPathForPath(allowlist)
847 }
848
Colin Cross56a83212020-09-15 18:30:11 -0700849 apexInfo := ctx.Provider(android.ApexInfoProvider).(android.ApexInfo)
850
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800851 // Install the app package.
Andrei Onea580636b2022-08-17 16:53:46 +0000852 shouldInstallAppPackage := (Bool(a.Module.properties.Installable) || ctx.Host()) && apexInfo.IsForPlatform() && !a.appProperties.PreventInstall
853 if shouldInstallAppPackage {
Sam Delmericob1daccd2023-05-25 14:45:30 -0400854 if a.privAppAllowlist.Valid() {
Anton Hansson0e486a42023-06-01 16:38:35 +0000855 allowlistInstallPath := android.PathForModuleInstall(ctx, "etc", "permissions")
856 allowlistInstallFilename := a.installApkName + ".xml"
857 ctx.InstallFile(allowlistInstallPath, allowlistInstallFilename, a.privAppAllowlist.Path())
Sam Delmericob1daccd2023-05-25 14:45:30 -0400858 }
859
Colin Cross1d0eb7a2021-11-03 14:08:20 -0700860 var extraInstalledPaths android.Paths
Jiyong Park8ba50f92019-11-13 15:01:01 +0900861 for _, extra := range a.extraOutputFiles {
Colin Cross1d0eb7a2021-11-03 14:08:20 -0700862 installed := ctx.InstallFile(a.installDir, extra.Base(), extra)
863 extraInstalledPaths = append(extraInstalledPaths, installed)
Jiyong Park8ba50f92019-11-13 15:01:01 +0900864 }
Colin Cross1d0eb7a2021-11-03 14:08:20 -0700865 ctx.InstallFile(a.installDir, a.outputFile.Base(), a.outputFile, extraInstalledPaths...)
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800866 }
Artur Satayev1111b842020-04-27 19:05:28 +0100867
868 a.buildAppDependencyInfo(ctx)
Colin Cross30e076a2015-04-13 13:58:27 -0700869}
870
Colin Crossc2d24052020-05-13 11:05:02 -0700871type appDepsInterface interface {
Jiyong Park92315372021-04-02 08:45:46 +0900872 SdkVersion(ctx android.EarlyModuleContext) android.SdkSpec
Spandan Das8c9ae7e2023-03-03 21:20:36 +0000873 MinSdkVersion(ctx android.EarlyModuleContext) android.ApiLevel
Colin Crossc2d24052020-05-13 11:05:02 -0700874 RequiresStableAPIs(ctx android.BaseModuleContext) bool
875}
876
877func collectAppDeps(ctx android.ModuleContext, app appDepsInterface,
878 shouldCollectRecursiveNativeDeps bool,
Sam Delmerico82602492022-06-10 17:05:42 +0000879 checkNativeSdkVersion bool) ([]jniLib, android.Paths, []Certificate) {
Colin Crossc2d24052020-05-13 11:05:02 -0700880
Colin Crossa4f08812018-10-02 22:03:40 -0700881 var jniLibs []jniLib
Sam Delmerico82602492022-06-10 17:05:42 +0000882 var prebuiltJniPackages android.Paths
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900883 var certificates []Certificate
Peter Collingbournead84f972019-12-17 16:46:18 -0800884 seenModulePaths := make(map[string]bool)
Colin Crossa4f08812018-10-02 22:03:40 -0700885
Colin Crossc2d24052020-05-13 11:05:02 -0700886 if checkNativeSdkVersion {
Jiyong Park92315372021-04-02 08:45:46 +0900887 checkNativeSdkVersion = app.SdkVersion(ctx).Specified() &&
888 app.SdkVersion(ctx).Kind != android.SdkCorePlatform && !app.RequiresStableAPIs(ctx)
Colin Crossc2d24052020-05-13 11:05:02 -0700889 }
890
Peter Collingbournead84f972019-12-17 16:46:18 -0800891 ctx.WalkDeps(func(module android.Module, parent android.Module) bool {
Colin Crossa4f08812018-10-02 22:03:40 -0700892 otherName := ctx.OtherModuleName(module)
893 tag := ctx.OtherModuleDependencyTag(module)
894
Colin Crossf0913fb2020-07-29 12:59:39 -0700895 if IsJniDepTag(tag) || cc.IsSharedDepTag(tag) {
Ivan Lozano7f67c2a2022-06-27 16:00:26 -0400896 if dep, ok := module.(cc.LinkableInterface); ok {
Colin Cross95f1ca02020-10-29 20:47:22 -0700897 if dep.IsNdk(ctx.Config()) || dep.IsStubs() {
Peter Collingbournead84f972019-12-17 16:46:18 -0800898 return false
899 }
900
Colin Crossa4f08812018-10-02 22:03:40 -0700901 lib := dep.OutputFile()
902 if lib.Valid() {
Cole Faust64cb7c92021-09-14 17:32:49 -0700903 path := lib.Path()
904 if seenModulePaths[path.String()] {
905 return false
906 }
907 seenModulePaths[path.String()] = true
908
909 if checkNativeSdkVersion && dep.SdkVersion() == "" {
910 ctx.PropertyErrorf("jni_libs", "JNI dependency %q uses platform APIs, but this module does not",
911 otherName)
912 }
913
Colin Crossa4f08812018-10-02 22:03:40 -0700914 jniLibs = append(jniLibs, jniLib{
Colin Cross403cc152020-07-06 14:15:24 -0700915 name: ctx.OtherModuleName(module),
916 path: path,
917 target: module.Target(),
918 coverageFile: dep.CoverageOutputFile(),
919 unstrippedFile: dep.UnstrippedOutputFile(),
Jihoon Kangf78a8902022-09-01 22:47:07 +0000920 partition: dep.Partition(),
Colin Crossa4f08812018-10-02 22:03:40 -0700921 })
Colin Crossdd5261c2022-12-19 12:26:43 -0800922 } else if ctx.Config().AllowMissingDependencies() {
923 ctx.AddMissingDependencies([]string{otherName})
Colin Crossa4f08812018-10-02 22:03:40 -0700924 } else {
925 ctx.ModuleErrorf("dependency %q missing output file", otherName)
926 }
927 } else {
928 ctx.ModuleErrorf("jni_libs dependency %q must be a cc library", otherName)
Colin Crossa4f08812018-10-02 22:03:40 -0700929 }
Peter Collingbournead84f972019-12-17 16:46:18 -0800930
931 return shouldCollectRecursiveNativeDeps
932 }
933
Sam Delmerico82602492022-06-10 17:05:42 +0000934 if info, ok := ctx.OtherModuleProvider(module, JniPackageProvider).(JniPackageInfo); ok {
935 prebuiltJniPackages = append(prebuiltJniPackages, info.JniPackages...)
936 }
937
Peter Collingbournead84f972019-12-17 16:46:18 -0800938 if tag == certificateTag {
Colin Crossbd01e2a2018-10-04 15:21:03 -0700939 if dep, ok := module.(*AndroidAppCertificate); ok {
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900940 certificates = append(certificates, dep.Certificate)
Colin Crossbd01e2a2018-10-04 15:21:03 -0700941 } else {
942 ctx.ModuleErrorf("certificate dependency %q must be an android_app_certificate module", otherName)
943 }
Colin Crossa4f08812018-10-02 22:03:40 -0700944 }
Peter Collingbournead84f972019-12-17 16:46:18 -0800945
946 return false
Colin Crossa4f08812018-10-02 22:03:40 -0700947 })
948
Sam Delmerico82602492022-06-10 17:05:42 +0000949 return jniLibs, prebuiltJniPackages, certificates
Colin Crossa4f08812018-10-02 22:03:40 -0700950}
951
Jooyung Han749dc692020-04-15 11:03:39 +0900952func (a *AndroidApp) WalkPayloadDeps(ctx android.ModuleContext, do android.PayloadDepsCallback) {
Artur Satayev1111b842020-04-27 19:05:28 +0100953 ctx.WalkDeps(func(child, parent android.Module) bool {
954 isExternal := !a.DepIsInSameApex(ctx, child)
955 if am, ok := child.(android.ApexModule); ok {
Jooyung Han749dc692020-04-15 11:03:39 +0900956 if !do(ctx, parent, am, isExternal) {
957 return false
958 }
Artur Satayev1111b842020-04-27 19:05:28 +0100959 }
960 return !isExternal
961 })
962}
963
964func (a *AndroidApp) buildAppDependencyInfo(ctx android.ModuleContext) {
965 if ctx.Host() {
966 return
967 }
968
969 depsInfo := android.DepNameToDepInfoMap{}
Jooyung Han749dc692020-04-15 11:03:39 +0900970 a.WalkPayloadDeps(ctx, func(ctx android.ModuleContext, from blueprint.Module, to android.ApexModule, externalDep bool) bool {
Artur Satayev1111b842020-04-27 19:05:28 +0100971 depName := to.Name()
Artur Satayev533b98c2021-03-11 18:03:42 +0000972
973 // Skip dependencies that are only available to APEXes; they are developed with updatability
974 // in mind and don't need manual approval.
975 if to.(android.ApexModule).NotAvailableForPlatform() {
976 return true
977 }
978
Artur Satayev1111b842020-04-27 19:05:28 +0100979 if info, exist := depsInfo[depName]; exist {
980 info.From = append(info.From, from.Name())
981 info.IsExternal = info.IsExternal && externalDep
982 depsInfo[depName] = info
983 } else {
984 toMinSdkVersion := "(no version)"
Jiyong Park92315372021-04-02 08:45:46 +0900985 if m, ok := to.(interface {
Spandan Das8c9ae7e2023-03-03 21:20:36 +0000986 MinSdkVersion(ctx android.EarlyModuleContext) android.ApiLevel
Jiyong Park92315372021-04-02 08:45:46 +0900987 }); ok {
Spandan Das8c9ae7e2023-03-03 21:20:36 +0000988 if v := m.MinSdkVersion(ctx); !v.IsNone() {
989 toMinSdkVersion = v.String()
Artur Satayev1111b842020-04-27 19:05:28 +0100990 }
Jiyong Park92315372021-04-02 08:45:46 +0900991 } else if m, ok := to.(interface{ MinSdkVersion() string }); ok {
992 // TODO(b/175678607) eliminate the use of MinSdkVersion returning
993 // string
994 if v := m.MinSdkVersion(); v != "" {
Jiyong Parkf1691d22021-03-29 20:11:58 +0900995 toMinSdkVersion = v
996 }
Artur Satayev1111b842020-04-27 19:05:28 +0100997 }
998 depsInfo[depName] = android.ApexModuleDepInfo{
999 To: depName,
1000 From: []string{from.Name()},
1001 IsExternal: externalDep,
1002 MinSdkVersion: toMinSdkVersion,
1003 }
1004 }
Jooyung Han749dc692020-04-15 11:03:39 +09001005 return true
Artur Satayev1111b842020-04-27 19:05:28 +01001006 })
1007
Jiyong Park92315372021-04-02 08:45:46 +09001008 a.ApexBundleDepsInfo.BuildDepsInfoLists(ctx, a.MinSdkVersion(ctx).String(), depsInfo)
Artur Satayev1111b842020-04-27 19:05:28 +01001009}
1010
Harshit Mahajan5b8b7302022-06-10 11:24:05 +00001011func (a *AndroidApp) enforceDefaultTargetSdkVersion() bool {
1012 return a.appProperties.EnforceDefaultTargetSdkVersion
1013}
1014
1015func (a *AndroidApp) SetEnforceDefaultTargetSdkVersion(val bool) {
1016 a.appProperties.EnforceDefaultTargetSdkVersion = val
1017}
1018
Artur Satayev849f8442020-04-28 14:57:42 +01001019func (a *AndroidApp) Updatable() bool {
Colin Cross56a83212020-09-15 18:30:11 -07001020 return Bool(a.appProperties.Updatable)
Artur Satayev849f8442020-04-28 14:57:42 +01001021}
1022
Spandan Das42e89502022-05-06 22:12:55 +00001023func (a *AndroidApp) SetUpdatable(val bool) {
1024 a.appProperties.Updatable = &val
1025}
1026
Colin Cross0ea8ba82019-06-06 14:33:29 -07001027func (a *AndroidApp) getCertString(ctx android.BaseModuleContext) string {
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001028 certificate, overridden := ctx.DeviceConfig().OverrideCertificateFor(ctx.ModuleName())
1029 if overridden {
Jaewoong Jungacb6db32019-02-28 16:22:30 +00001030 return ":" + certificate
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001031 }
Jaewoong Jung525443a2019-02-28 15:35:54 -08001032 return String(a.overridableAppProperties.Certificate)
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001033}
1034
Jiyong Park0f80c182020-01-31 02:49:53 +09001035func (a *AndroidApp) DepIsInSameApex(ctx android.BaseModuleContext, dep android.Module) bool {
1036 if IsJniDepTag(ctx.OtherModuleDependencyTag(dep)) {
1037 return true
1038 }
1039 return a.Library.DepIsInSameApex(ctx, dep)
1040}
1041
Jiyong Parkb7c639e2019-08-19 14:56:02 +09001042// For OutputFileProducer interface
1043func (a *AndroidApp) OutputFiles(tag string) (android.Paths, error) {
1044 switch tag {
Jared Duke34b080d2023-03-30 16:40:24 -07001045 // In some instances, it can be useful to reference the aapt-generated flags from another
1046 // target, e.g., system server implements services declared in the framework-res manifest.
1047 case ".aapt.proguardOptionsFile":
1048 return []android.Path{a.proguardOptionsFile}, nil
Jiyong Parkb7c639e2019-08-19 14:56:02 +09001049 case ".aapt.srcjar":
Colin Crossf3b7bad2023-08-02 15:49:00 -07001050 if a.aaptSrcJar != nil {
1051 return []android.Path{a.aaptSrcJar}, nil
1052 }
1053 case ".aapt.jar":
1054 if a.rJar != nil {
1055 return []android.Path{a.rJar}, nil
1056 }
Anton Hansson092aca42020-08-13 19:37:22 +01001057 case ".export-package.apk":
1058 return []android.Path{a.exportPackage}, nil
Jiyong Parkb7c639e2019-08-19 14:56:02 +09001059 }
1060 return a.Library.OutputFiles(tag)
1061}
1062
Jiyong Parkf7487312019-10-17 12:54:30 +09001063func (a *AndroidApp) Privileged() bool {
1064 return Bool(a.appProperties.Privileged)
1065}
1066
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001067func (a *AndroidApp) IsNativeCoverageNeeded(ctx android.BaseModuleContext) bool {
Colin Cross1a6acd42020-06-16 17:51:46 -07001068 return ctx.Device() && ctx.DeviceConfig().NativeCoverageEnabled()
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001069}
1070
Ivan Lozanod7586b62021-04-01 09:49:36 -04001071func (a *AndroidApp) SetPreventInstall() {
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001072 a.appProperties.PreventInstall = true
1073}
1074
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001075func (a *AndroidApp) MarkAsCoverageVariant(coverage bool) {
1076 a.appProperties.IsCoverageVariant = coverage
1077}
1078
Ivan Lozanoa0cd8f92020-04-09 09:56:02 -04001079func (a *AndroidApp) EnableCoverageIfNeeded() {}
1080
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001081var _ cc.Coverage = (*AndroidApp)(nil)
1082
Colin Cross95b53b82023-10-17 13:21:02 -07001083func (a *AndroidApp) IDEInfo(dpInfo *android.IdeInfo) {
1084 a.Library.IDEInfo(dpInfo)
1085 a.aapt.IDEInfo(dpInfo)
1086}
1087
Colin Cross1b16b0e2019-02-12 14:41:32 -08001088// android_app compiles sources and Android resources into an Android application package `.apk` file.
Colin Cross36242852017-06-23 15:06:31 -07001089func AndroidAppFactory() android.Module {
Colin Cross30e076a2015-04-13 13:58:27 -07001090 module := &AndroidApp{}
1091
Liz Kammera7a64f32020-07-09 15:16:41 -07001092 module.Module.dexProperties.Optimize.EnabledByDefault = true
1093 module.Module.dexProperties.Optimize.Shrink = proptools.BoolPtr(true)
Jared Dukeaa88b3d2023-08-29 17:07:20 +00001094 module.Module.dexProperties.Optimize.Proguard_compatibility = proptools.BoolPtr(false)
Colin Cross66dbc0b2017-12-28 12:23:20 -08001095
Colin Crossae5caf52018-05-22 11:11:52 -07001096 module.Module.properties.Instrument = true
Paul Duffin0038a8d2022-05-03 00:28:40 +00001097 module.Module.properties.Supports_static_instrumentation = true
Colin Cross9ae1b922018-06-26 17:59:05 -07001098 module.Module.properties.Installable = proptools.BoolPtr(true)
Colin Crossae5caf52018-05-22 11:11:52 -07001099
Colin Crossce6734e2020-06-15 16:09:53 -07001100 module.addHostAndDeviceProperties()
Colin Cross36242852017-06-23 15:06:31 -07001101 module.AddProperties(
Colin Crossa97c5d32018-03-28 14:58:31 -07001102 &module.aaptProperties,
Jaewoong Jung525443a2019-02-28 15:35:54 -08001103 &module.appProperties,
Ulya Trafimovich21a73752020-09-01 17:33:48 +01001104 &module.overridableAppProperties)
Colin Cross36242852017-06-23 15:06:31 -07001105
Ulya Trafimovich22890c42021-01-05 12:04:17 +00001106 module.usesLibrary.enforce = true
1107
Colin Crossa4f08812018-10-02 22:03:40 -07001108 android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
1109 android.InitDefaultableModule(module)
zhidou198f5892022-02-17 02:33:12 +00001110 android.InitOverridableModule(module, &module.overridableAppProperties.Overrides)
Jiyong Park52cd06f2019-11-11 10:14:32 +09001111 android.InitApexModule(module)
Liz Kammerbe46fcc2021-11-01 15:32:43 -04001112 android.InitBazelModule(module)
Colin Crossa4f08812018-10-02 22:03:40 -07001113
Colin Cross36242852017-06-23 15:06:31 -07001114 return module
Colin Cross30e076a2015-04-13 13:58:27 -07001115}
Colin Crossae5caf52018-05-22 11:11:52 -07001116
Alix96ea88452023-08-31 15:48:23 +00001117// A dictionary of values to be overridden in the manifest.
1118type Manifest_values struct {
1119 // Overrides the value of package_name in the manifest
1120 ApplicationId *string
1121}
1122
Colin Crossae5caf52018-05-22 11:11:52 -07001123type appTestProperties struct {
Liz Kammer6b0c5522020-04-28 16:10:55 -07001124 // The name of the android_app module that the tests will run against.
Colin Crossae5caf52018-05-22 11:11:52 -07001125 Instrumentation_for *string
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001126
Seth Moorec6f4b532023-02-02 13:22:26 -08001127 // If specified, the instrumentation target package name in the manifest is overwritten by it.
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001128 Instrumentation_target_package *string
Seth Moorec6f4b532023-02-02 13:22:26 -08001129
1130 // If specified, the mainline module package name in the test config is overwritten by it.
1131 Mainline_package_name *string
Alix96ea88452023-08-31 15:48:23 +00001132
1133 Manifest_values Manifest_values
Colin Crossae5caf52018-05-22 11:11:52 -07001134}
1135
1136type AndroidTest struct {
1137 AndroidApp
1138
1139 appTestProperties appTestProperties
1140
1141 testProperties testProperties
Colin Cross303e21f2018-08-07 16:49:25 -07001142
Dan Shi95d19422020-08-15 12:24:26 -07001143 testConfig android.Path
1144 extraTestConfigs android.Paths
1145 data android.Paths
Jingwen Chene12c0832023-08-25 09:00:16 +00001146
1147 android.BazelModuleBase
Colin Crossae5caf52018-05-22 11:11:52 -07001148}
1149
Jaewoong Jung0949f312019-09-11 10:25:18 -07001150func (a *AndroidTest) InstallInTestcases() bool {
1151 return true
1152}
1153
Spandan Das9f7ae7f2022-07-25 00:34:18 +00001154type androidTestApp interface {
1155 includedInTestSuite(searchPrefix string) bool
1156}
1157
1158func (a *AndroidTest) includedInTestSuite(searchPrefix string) bool {
1159 return android.PrefixInList(a.testProperties.Test_suites, searchPrefix)
1160}
1161
1162func (a *AndroidTestHelperApp) includedInTestSuite(searchPrefix string) bool {
1163 return android.PrefixInList(a.appTestHelperAppProperties.Test_suites, searchPrefix)
1164}
1165
Colin Crossae5caf52018-05-22 11:11:52 -07001166func (a *AndroidTest) GenerateAndroidBuildActions(ctx android.ModuleContext) {
easoncylee5bcff5d2020-04-30 14:57:06 +08001167 var configs []tradefed.Config
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001168 if a.appTestProperties.Instrumentation_target_package != nil {
1169 a.additionalAaptFlags = append(a.additionalAaptFlags,
1170 "--rename-instrumentation-target-package "+*a.appTestProperties.Instrumentation_target_package)
1171 } else if a.appTestProperties.Instrumentation_for != nil {
1172 // Check if the instrumentation target package is overridden.
Jaewoong Jung4102e5d2019-02-27 16:26:28 -08001173 manifestPackageName, overridden := ctx.DeviceConfig().OverrideManifestPackageNameFor(*a.appTestProperties.Instrumentation_for)
1174 if overridden {
1175 a.additionalAaptFlags = append(a.additionalAaptFlags, "--rename-instrumentation-target-package "+manifestPackageName)
1176 }
1177 }
Alix96ea88452023-08-31 15:48:23 +00001178 applicationId := a.appTestProperties.Manifest_values.ApplicationId
1179 if applicationId != nil {
1180 if a.overridableAppProperties.Package_name != nil {
1181 ctx.PropertyErrorf("manifest_values.applicationId", "property is not supported when property package_name is set.")
1182 }
1183 a.aapt.manifestValues.applicationId = *applicationId
1184 }
Colin Crossae5caf52018-05-22 11:11:52 -07001185 a.generateAndroidBuildActions(ctx)
Colin Cross303e21f2018-08-07 16:49:25 -07001186
easoncylee5bcff5d2020-04-30 14:57:06 +08001187 for _, module := range a.testProperties.Test_mainline_modules {
1188 configs = append(configs, tradefed.Option{Name: "config-descriptor:metadata", Key: "mainline-param", Value: module})
1189 }
1190
Jaewoong Jung39982342020-01-14 10:27:18 -08001191 testConfig := tradefed.AutoGenInstrumentationTestConfig(ctx, a.testProperties.Test_config,
easoncylee5bcff5d2020-04-30 14:57:06 +08001192 a.testProperties.Test_config_template, a.manifestPath, a.testProperties.Test_suites, a.testProperties.Auto_gen_config, configs)
Jaewoong Jung39982342020-01-14 10:27:18 -08001193 a.testConfig = a.FixTestConfig(ctx, testConfig)
Dan Shi95d19422020-08-15 12:24:26 -07001194 a.extraTestConfigs = android.PathsForModuleSrc(ctx, a.testProperties.Test_options.Extra_test_configs)
Colin Cross8a497952019-03-05 22:25:09 -08001195 a.data = android.PathsForModuleSrc(ctx, a.testProperties.Data)
Colin Cross303e21f2018-08-07 16:49:25 -07001196}
1197
Jaewoong Jung39982342020-01-14 10:27:18 -08001198func (a *AndroidTest) FixTestConfig(ctx android.ModuleContext, testConfig android.Path) android.Path {
1199 if testConfig == nil {
1200 return nil
1201 }
1202
1203 fixedConfig := android.PathForModuleOut(ctx, "test_config_fixer", "AndroidTest.xml")
Colin Crossf1a035e2020-11-16 17:32:30 -08001204 rule := android.NewRuleBuilder(pctx, ctx)
1205 command := rule.Command().BuiltTool("test_config_fixer").Input(testConfig).Output(fixedConfig)
Jaewoong Jung39982342020-01-14 10:27:18 -08001206 fixNeeded := false
1207
Jooyung Han29e2f6d2022-01-08 12:13:59 +09001208 // Auto-generated test config uses `ModuleName` as the APK name. So fix it if it is not the case.
Jaewoong Jung39982342020-01-14 10:27:18 -08001209 if ctx.ModuleName() != a.installApkName {
1210 fixNeeded = true
1211 command.FlagWithArg("--test-file-name ", a.installApkName+".apk")
1212 }
1213
1214 if a.overridableAppProperties.Package_name != nil {
1215 fixNeeded = true
1216 command.FlagWithInput("--manifest ", a.manifestPath).
1217 FlagWithArg("--package-name ", *a.overridableAppProperties.Package_name)
1218 }
1219
Seth Moorec6f4b532023-02-02 13:22:26 -08001220 if a.appTestProperties.Mainline_package_name != nil {
1221 fixNeeded = true
1222 command.FlagWithArg("--mainline-package-name ", *a.appTestProperties.Mainline_package_name)
1223 }
1224
Jaewoong Jung39982342020-01-14 10:27:18 -08001225 if fixNeeded {
Colin Crossf1a035e2020-11-16 17:32:30 -08001226 rule.Build("fix_test_config", "fix test config")
Jaewoong Jung39982342020-01-14 10:27:18 -08001227 return fixedConfig
1228 }
1229 return testConfig
1230}
1231
Colin Cross303e21f2018-08-07 16:49:25 -07001232func (a *AndroidTest) DepsMutator(ctx android.BottomUpMutatorContext) {
Colin Cross303e21f2018-08-07 16:49:25 -07001233 a.AndroidApp.DepsMutator(ctx)
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001234}
1235
1236func (a *AndroidTest) OverridablePropertiesDepsMutator(ctx android.BottomUpMutatorContext) {
1237 a.AndroidApp.OverridablePropertiesDepsMutator(ctx)
Colin Cross4b964c02018-10-15 16:18:06 -07001238 if a.appTestProperties.Instrumentation_for != nil {
1239 // The android_app dependency listed in instrumentation_for needs to be added to the classpath for javac,
1240 // but not added to the aapt2 link includes like a normal android_app or android_library dependency, so
1241 // use instrumentationForTag instead of libTag.
1242 ctx.AddVariationDependencies(nil, instrumentationForTag, String(a.appTestProperties.Instrumentation_for))
1243 }
Colin Crossae5caf52018-05-22 11:11:52 -07001244}
1245
Colin Cross1b16b0e2019-02-12 14:41:32 -08001246// android_test compiles test sources and Android resources into an Android application package `.apk` file and
1247// creates an `AndroidTest.xml` file to allow running the test with `atest` or a `TEST_MAPPING` file.
Colin Crossae5caf52018-05-22 11:11:52 -07001248func AndroidTestFactory() android.Module {
1249 module := &AndroidTest{}
1250
Jared Duke63a3da92022-06-02 19:11:14 +00001251 module.Module.dexProperties.Optimize.EnabledByDefault = false
Colin Cross5067db92018-09-17 16:46:35 -07001252
1253 module.Module.properties.Instrument = true
Paul Duffin0038a8d2022-05-03 00:28:40 +00001254 module.Module.properties.Supports_static_instrumentation = true
Colin Cross9ae1b922018-06-26 17:59:05 -07001255 module.Module.properties.Installable = proptools.BoolPtr(true)
Colin Crosse4246ab2019-02-05 21:55:21 -08001256 module.appProperties.Use_embedded_native_libs = proptools.BoolPtr(true)
Colin Cross47fa9d32019-03-26 10:51:39 -07001257 module.appProperties.AlwaysPackageNativeLibs = true
Colin Cross43f08db2018-11-12 10:13:39 -08001258 module.Module.dexpreopter.isTest = true
Cole Faustd57e8b22022-08-11 11:59:04 -07001259 module.Module.linter.properties.Lint.Test = proptools.BoolPtr(true)
Colin Crossae5caf52018-05-22 11:11:52 -07001260
Colin Crossce6734e2020-06-15 16:09:53 -07001261 module.addHostAndDeviceProperties()
Colin Crossae5caf52018-05-22 11:11:52 -07001262 module.AddProperties(
Colin Crossae5caf52018-05-22 11:11:52 -07001263 &module.aaptProperties,
1264 &module.appProperties,
Dan Willemsenf5531d22018-07-16 17:21:19 -07001265 &module.appTestProperties,
Jaewoong Jung525443a2019-02-28 15:35:54 -08001266 &module.overridableAppProperties,
Dan Willemsenf5531d22018-07-16 17:21:19 -07001267 &module.testProperties)
Colin Crossae5caf52018-05-22 11:11:52 -07001268
Colin Crossa4f08812018-10-02 22:03:40 -07001269 android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
1270 android.InitDefaultableModule(module)
zhidou198f5892022-02-17 02:33:12 +00001271 android.InitOverridableModule(module, &module.overridableAppProperties.Overrides)
Jingwen Chene12c0832023-08-25 09:00:16 +00001272
1273 android.InitBazelModule(module)
Colin Crossae5caf52018-05-22 11:11:52 -07001274 return module
1275}
Colin Crossbd01e2a2018-10-04 15:21:03 -07001276
Colin Cross252fc6f2018-10-04 15:22:03 -07001277type appTestHelperAppProperties struct {
1278 // list of compatibility suites (for example "cts", "vts") that the module should be
1279 // installed into.
1280 Test_suites []string `android:"arch_variant"`
Dan Shi6ffaaa82019-09-26 11:41:36 -07001281
1282 // Flag to indicate whether or not to create test config automatically. If AndroidTest.xml
1283 // doesn't exist next to the Android.bp, this attribute doesn't need to be set to true
1284 // explicitly.
1285 Auto_gen_config *bool
Colin Crosscfb0f5e2021-09-24 15:47:17 -07001286
1287 // Install the test into a folder named for the module in all test suites.
1288 Per_testcase_directory *bool
Alix96ea88452023-08-31 15:48:23 +00001289
1290 Manifest_values Manifest_values
Colin Cross252fc6f2018-10-04 15:22:03 -07001291}
1292
1293type AndroidTestHelperApp struct {
1294 AndroidApp
1295
1296 appTestHelperAppProperties appTestHelperAppProperties
Jingwen Chen65289992023-09-21 15:15:47 +00001297
1298 android.BazelModuleBase
Colin Cross252fc6f2018-10-04 15:22:03 -07001299}
1300
Jaewoong Jung326a9412019-11-21 10:41:00 -08001301func (a *AndroidTestHelperApp) InstallInTestcases() bool {
1302 return true
1303}
1304
Colin Cross1b16b0e2019-02-12 14:41:32 -08001305// android_test_helper_app compiles sources and Android resources into an Android application package `.apk` file that
1306// will be used by tests, but does not produce an `AndroidTest.xml` file so the module will not be run directly as a
1307// test.
Colin Cross252fc6f2018-10-04 15:22:03 -07001308func AndroidTestHelperAppFactory() android.Module {
1309 module := &AndroidTestHelperApp{}
1310
Jared Duke63a3da92022-06-02 19:11:14 +00001311 // TODO(b/192032291): Disable by default after auditing downstream usage.
Liz Kammera7a64f32020-07-09 15:16:41 -07001312 module.Module.dexProperties.Optimize.EnabledByDefault = true
Colin Cross252fc6f2018-10-04 15:22:03 -07001313
1314 module.Module.properties.Installable = proptools.BoolPtr(true)
Colin Crosse4246ab2019-02-05 21:55:21 -08001315 module.appProperties.Use_embedded_native_libs = proptools.BoolPtr(true)
Colin Cross47fa9d32019-03-26 10:51:39 -07001316 module.appProperties.AlwaysPackageNativeLibs = true
Colin Cross43f08db2018-11-12 10:13:39 -08001317 module.Module.dexpreopter.isTest = true
Cole Faustd57e8b22022-08-11 11:59:04 -07001318 module.Module.linter.properties.Lint.Test = proptools.BoolPtr(true)
Colin Cross252fc6f2018-10-04 15:22:03 -07001319
Colin Crossce6734e2020-06-15 16:09:53 -07001320 module.addHostAndDeviceProperties()
Colin Cross252fc6f2018-10-04 15:22:03 -07001321 module.AddProperties(
Colin Cross252fc6f2018-10-04 15:22:03 -07001322 &module.aaptProperties,
1323 &module.appProperties,
Jaewoong Jung525443a2019-02-28 15:35:54 -08001324 &module.appTestHelperAppProperties,
Ulya Trafimovich21a73752020-09-01 17:33:48 +01001325 &module.overridableAppProperties)
Colin Cross252fc6f2018-10-04 15:22:03 -07001326
1327 android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
1328 android.InitDefaultableModule(module)
Anton Hansson3d2b6b42020-01-10 15:06:01 +00001329 android.InitApexModule(module)
Jingwen Chen65289992023-09-21 15:15:47 +00001330 android.InitBazelModule(module)
Colin Cross252fc6f2018-10-04 15:22:03 -07001331 return module
1332}
1333
Colin Crossbd01e2a2018-10-04 15:21:03 -07001334type AndroidAppCertificate struct {
1335 android.ModuleBase
Rupert Shuttleworth6e4950a2021-07-27 01:34:59 -04001336 android.BazelModuleBase
1337
Colin Crossbd01e2a2018-10-04 15:21:03 -07001338 properties AndroidAppCertificateProperties
Jiyong Parkc00cbd92018-10-30 21:20:05 +09001339 Certificate Certificate
Colin Crossbd01e2a2018-10-04 15:21:03 -07001340}
1341
1342type AndroidAppCertificateProperties struct {
1343 // Name of the certificate files. Extensions .x509.pem and .pk8 will be added to the name.
1344 Certificate *string
1345}
1346
Colin Cross1b16b0e2019-02-12 14:41:32 -08001347// android_app_certificate modules can be referenced by the certificates property of android_app modules to select
1348// the signing key.
Colin Crossbd01e2a2018-10-04 15:21:03 -07001349func AndroidAppCertificateFactory() android.Module {
1350 module := &AndroidAppCertificate{}
1351 module.AddProperties(&module.properties)
1352 android.InitAndroidModule(module)
Rupert Shuttleworth6e4950a2021-07-27 01:34:59 -04001353 android.InitBazelModule(module)
Colin Crossbd01e2a2018-10-04 15:21:03 -07001354 return module
1355}
1356
Colin Crossbd01e2a2018-10-04 15:21:03 -07001357func (c *AndroidAppCertificate) GenerateAndroidBuildActions(ctx android.ModuleContext) {
1358 cert := String(c.properties.Certificate)
Jiyong Parkc00cbd92018-10-30 21:20:05 +09001359 c.Certificate = Certificate{
Colin Cross503c1d02020-01-28 14:00:53 -08001360 Pem: android.PathForModuleSrc(ctx, cert+".x509.pem"),
1361 Key: android.PathForModuleSrc(ctx, cert+".pk8"),
Colin Crossbd01e2a2018-10-04 15:21:03 -07001362 }
1363}
Jaewoong Jung525443a2019-02-28 15:35:54 -08001364
1365type OverrideAndroidApp struct {
1366 android.ModuleBase
1367 android.OverrideModuleBase
1368}
1369
Sasha Smundak613cbb12020-06-05 10:27:23 -07001370func (i *OverrideAndroidApp) GenerateAndroidBuildActions(_ android.ModuleContext) {
Jaewoong Jung525443a2019-02-28 15:35:54 -08001371 // All the overrides happen in the base module.
1372 // TODO(jungjw): Check the base module type.
1373}
1374
1375// override_android_app is used to create an android_app module based on another android_app by overriding
1376// some of its properties.
1377func OverrideAndroidAppModuleFactory() android.Module {
1378 m := &OverrideAndroidApp{}
Jooyung Han01d80d82022-01-08 12:16:32 +09001379 m.AddProperties(
1380 &OverridableDeviceProperties{},
1381 &overridableAppProperties{},
1382 )
Jaewoong Jung525443a2019-02-28 15:35:54 -08001383
Jaewoong Jungb639a6a2019-05-10 15:16:29 -07001384 android.InitAndroidMultiTargetsArchModule(m, android.DeviceSupported, android.MultilibCommon)
Jaewoong Jung525443a2019-02-28 15:35:54 -08001385 android.InitOverrideModule(m)
1386 return m
1387}
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001388
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001389type OverrideAndroidTest struct {
1390 android.ModuleBase
1391 android.OverrideModuleBase
1392}
1393
Sasha Smundak613cbb12020-06-05 10:27:23 -07001394func (i *OverrideAndroidTest) GenerateAndroidBuildActions(_ android.ModuleContext) {
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001395 // All the overrides happen in the base module.
1396 // TODO(jungjw): Check the base module type.
1397}
1398
1399// override_android_test is used to create an android_app module based on another android_test by overriding
1400// some of its properties.
1401func OverrideAndroidTestModuleFactory() android.Module {
1402 m := &OverrideAndroidTest{}
1403 m.AddProperties(&overridableAppProperties{})
1404 m.AddProperties(&appTestProperties{})
1405
1406 android.InitAndroidMultiTargetsArchModule(m, android.DeviceSupported, android.MultilibCommon)
1407 android.InitOverrideModule(m)
1408 return m
1409}
1410
Colin Cross50ddcc42019-05-16 12:28:22 -07001411type UsesLibraryProperties struct {
1412 // A list of shared library modules that will be listed in uses-library tags in the AndroidManifest.xml file.
1413 Uses_libs []string
1414
1415 // A list of shared library modules that will be listed in uses-library tags in the AndroidManifest.xml file with
1416 // required=false.
1417 Optional_uses_libs []string
1418
1419 // If true, the list of uses_libs and optional_uses_libs modules must match the AndroidManifest.xml file. Defaults
1420 // to true if either uses_libs or optional_uses_libs is set. Will unconditionally default to true in the future.
1421 Enforce_uses_libs *bool
Ulya Trafimovich21a73752020-09-01 17:33:48 +01001422
Ulya Trafimovich54027b52020-09-09 14:08:23 +01001423 // Optional name of the <uses-library> provided by this module. This is needed for non-SDK
1424 // libraries, because SDK ones are automatically picked up by Soong. The <uses-library> name
1425 // normally is the same as the module name, but there are exceptions.
1426 Provides_uses_lib *string
Paul Duffin06530572022-02-03 17:54:15 +00001427
1428 // A list of shared library names to exclude from the classpath of the APK. Adding a library here
1429 // will prevent it from being used when precompiling the APK and prevent it from being implicitly
1430 // added to the APK's manifest's <uses-library> elements.
1431 //
1432 // Care must be taken when using this as it could result in runtime errors if the APK actually
1433 // uses classes provided by the library and which are not provided in any other way.
1434 //
1435 // This is primarily intended for use by various CTS tests that check the runtime handling of the
1436 // android.test.base shared library (and related libraries) but which depend on some common
1437 // libraries that depend on the android.test.base library. Without this those tests will end up
1438 // with a <uses-library android:name="android.test.base"/> in their manifest which would either
1439 // render the tests worthless (as they would be testing the wrong behavior), or would break the
1440 // test altogether by providing access to classes that the tests were not expecting. Those tests
1441 // provide the android.test.base statically and use jarjar to rename them so they do not collide
1442 // with the classes provided by the android.test.base library.
1443 Exclude_uses_libs []string
Colin Cross50ddcc42019-05-16 12:28:22 -07001444}
1445
1446// usesLibrary provides properties and helper functions for AndroidApp and AndroidAppImport to verify that the
1447// <uses-library> tags that end up in the manifest of an APK match the ones known to the build system through the
1448// uses_libs and optional_uses_libs properties. The build system's values are used by dexpreopt to preopt apps
1449// with knowledge of their shared libraries.
1450type usesLibrary struct {
1451 usesLibraryProperties UsesLibraryProperties
Ulya Trafimovich22890c42021-01-05 12:04:17 +00001452
1453 // Whether to enforce verify_uses_library check.
1454 enforce bool
Colin Cross50ddcc42019-05-16 12:28:22 -07001455}
1456
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +01001457func (u *usesLibrary) addLib(lib string, optional bool) {
1458 if !android.InList(lib, u.usesLibraryProperties.Uses_libs) && !android.InList(lib, u.usesLibraryProperties.Optional_uses_libs) {
1459 if optional {
1460 u.usesLibraryProperties.Optional_uses_libs = append(u.usesLibraryProperties.Optional_uses_libs, lib)
1461 } else {
1462 u.usesLibraryProperties.Uses_libs = append(u.usesLibraryProperties.Uses_libs, lib)
1463 }
1464 }
1465}
1466
Colin Cross4a80a152022-12-21 21:51:52 -08001467func (u *usesLibrary) deps(ctx android.BottomUpMutatorContext, addCompatDeps bool) {
Jeongik Cha4b073cd2021-06-08 11:35:00 +09001468 if !ctx.Config().UnbundledBuild() || ctx.Config().UnbundledBuildImage() {
Ulya Trafimovichf5d91bb2022-05-04 12:00:02 +01001469 ctx.AddVariationDependencies(nil, usesLibReqTag, u.usesLibraryProperties.Uses_libs...)
1470 ctx.AddVariationDependencies(nil, usesLibOptTag, u.presentOptionalUsesLibs(ctx)...)
Colin Cross4a80a152022-12-21 21:51:52 -08001471 // Only add these extra dependencies if the module is an app that depends on framework
1472 // libs. This avoids creating a cyclic dependency:
Paul Duffin250e6192019-06-07 10:44:37 +01001473 // e.g. framework-res -> org.apache.http.legacy -> ... -> framework-res.
Colin Cross4a80a152022-12-21 21:51:52 -08001474 if addCompatDeps {
Ulya Trafimovichf5d91bb2022-05-04 12:00:02 +01001475 // Dexpreopt needs paths to the dex jars of these libraries in order to construct
1476 // class loader context for dex2oat. Add them as a dependency with a special tag.
1477 ctx.AddVariationDependencies(nil, usesLibCompat29ReqTag, dexpreopt.CompatUsesLibs29...)
1478 ctx.AddVariationDependencies(nil, usesLibCompat28OptTag, dexpreopt.OptionalCompatUsesLibs28...)
1479 ctx.AddVariationDependencies(nil, usesLibCompat30OptTag, dexpreopt.OptionalCompatUsesLibs30...)
Colin Cross3245b2c2019-06-07 13:18:09 -07001480 }
Sam Delmerico9f9c0a22022-11-29 11:19:37 -05001481 } else {
1482 ctx.AddVariationDependencies(nil, r8LibraryJarTag, u.usesLibraryProperties.Uses_libs...)
1483 ctx.AddVariationDependencies(nil, r8LibraryJarTag, u.presentOptionalUsesLibs(ctx)...)
Colin Cross50ddcc42019-05-16 12:28:22 -07001484 }
1485}
1486
Jiakai Zhang4f65a032023-06-01 15:16:58 +01001487// presentOptionalUsesLibs returns optional_uses_libs after filtering out libraries that don't exist in the source tree.
Colin Cross50ddcc42019-05-16 12:28:22 -07001488func (u *usesLibrary) presentOptionalUsesLibs(ctx android.BaseModuleContext) []string {
Jiakai Zhang4f65a032023-06-01 15:16:58 +01001489 optionalUsesLibs := android.FilterListPred(u.usesLibraryProperties.Optional_uses_libs, func(s string) bool {
1490 exists := ctx.OtherModuleExists(s)
Jiakai Zhang48203e32023-06-02 23:42:21 +01001491 if !exists && !android.InList(ctx.ModuleName(), ctx.Config().BuildWarningBadOptionalUsesLibsAllowlist()) {
Jiakai Zhang4f65a032023-06-01 15:16:58 +01001492 fmt.Printf("Warning: Module '%s' depends on non-existing optional_uses_libs '%s'\n", ctx.ModuleName(), s)
1493 }
1494 return exists
1495 })
Colin Cross50ddcc42019-05-16 12:28:22 -07001496 return optionalUsesLibs
1497}
1498
Ulya Trafimovicheea486a2021-02-26 11:38:21 +00001499// Helper function to replace string in a list.
1500func replaceInList(list []string, oldstr, newstr string) {
1501 for i, str := range list {
1502 if str == oldstr {
1503 list[i] = newstr
1504 }
1505 }
1506}
1507
Ulya Trafimovich24446712021-07-15 14:59:34 +01001508// Returns a map of module names of shared library dependencies to the paths to their dex jars on
1509// host and on device.
Ulya Trafimovich8cbc5d22020-11-03 15:15:46 +00001510func (u *usesLibrary) classLoaderContextForUsesLibDeps(ctx android.ModuleContext) dexpreopt.ClassLoaderContextMap {
1511 clcMap := make(dexpreopt.ClassLoaderContextMap)
Ulya Trafimovich24446712021-07-15 14:59:34 +01001512
1513 // Skip when UnbundledBuild() is true, but UnbundledBuildImage() is false. With
1514 // UnbundledBuildImage() it is necessary to generate dexpreopt.config for post-dexpreopting.
1515 if ctx.Config().UnbundledBuild() && !ctx.Config().UnbundledBuildImage() {
1516 return clcMap
Colin Cross50ddcc42019-05-16 12:28:22 -07001517 }
1518
Ulya Trafimovich24446712021-07-15 14:59:34 +01001519 ctx.VisitDirectDeps(func(m android.Module) {
1520 tag, isUsesLibTag := ctx.OtherModuleDependencyTag(m).(usesLibraryDependencyTag)
1521 if !isUsesLibTag {
1522 return
1523 }
1524
Ulya Trafimoviche14f80b2021-07-15 15:05:48 +01001525 dep := android.RemoveOptionalPrebuiltPrefix(ctx.OtherModuleName(m))
Ulya Trafimovich24446712021-07-15 14:59:34 +01001526
Ulya Trafimovich840efb62021-07-15 14:34:40 +01001527 // Skip stub libraries. A dependency on the implementation library has been added earlier,
1528 // so it will be added to CLC, but the stub shouldn't be. Stub libraries can be distingushed
1529 // from implementation libraries by their name, which is different as it has a suffix.
1530 if comp, ok := m.(SdkLibraryComponentDependency); ok {
1531 if impl := comp.OptionalSdkLibraryImplementation(); impl != nil && *impl != dep {
1532 return
1533 }
1534 }
1535
Ulya Trafimovich24446712021-07-15 14:59:34 +01001536 if lib, ok := m.(UsesLibraryDependency); ok {
Ulya Trafimoviche14f80b2021-07-15 15:05:48 +01001537 libName := dep
Ulya Trafimovich24446712021-07-15 14:59:34 +01001538 if ulib, ok := m.(ProvidesUsesLib); ok && ulib.ProvidesUsesLib() != nil {
Ulya Trafimoviche14f80b2021-07-15 15:05:48 +01001539 libName = *ulib.ProvidesUsesLib()
Ulya Trafimovich24446712021-07-15 14:59:34 +01001540 // Replace module name with library name in `uses_libs`/`optional_uses_libs` in
1541 // order to pass verify_uses_libraries check (which compares these properties
1542 // against library names written in the manifest).
1543 replaceInList(u.usesLibraryProperties.Uses_libs, dep, libName)
1544 replaceInList(u.usesLibraryProperties.Optional_uses_libs, dep, libName)
1545 }
Ulya Trafimovichf5d91bb2022-05-04 12:00:02 +01001546 clcMap.AddContext(ctx, tag.sdkVersion, libName, tag.optional,
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01001547 lib.DexJarBuildPath().PathOrNil(), lib.DexJarInstallPath(),
1548 lib.ClassLoaderContexts())
Ulya Trafimovich24446712021-07-15 14:59:34 +01001549 } else if ctx.Config().AllowMissingDependencies() {
1550 ctx.AddMissingDependencies([]string{dep})
1551 } else {
1552 ctx.ModuleErrorf("module %q in uses_libs or optional_uses_libs must be a java library", dep)
1553 }
1554 })
Ulya Trafimovich8cbc5d22020-11-03 15:15:46 +00001555 return clcMap
Colin Cross50ddcc42019-05-16 12:28:22 -07001556}
1557
1558// enforceUsesLibraries returns true of <uses-library> tags should be checked against uses_libs and optional_uses_libs
1559// properties. Defaults to true if either of uses_libs or optional_uses_libs is specified. Will default to true
1560// unconditionally in the future.
1561func (u *usesLibrary) enforceUsesLibraries() bool {
1562 defaultEnforceUsesLibs := len(u.usesLibraryProperties.Uses_libs) > 0 ||
1563 len(u.usesLibraryProperties.Optional_uses_libs) > 0
Ulya Trafimovich22890c42021-01-05 12:04:17 +00001564 return BoolDefault(u.usesLibraryProperties.Enforce_uses_libs, u.enforce || defaultEnforceUsesLibs)
Colin Cross50ddcc42019-05-16 12:28:22 -07001565}
1566
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +01001567// Freeze the value of `enforce_uses_libs` based on the current values of `uses_libs` and `optional_uses_libs`.
1568func (u *usesLibrary) freezeEnforceUsesLibraries() {
1569 enforce := u.enforceUsesLibraries()
1570 u.usesLibraryProperties.Enforce_uses_libs = &enforce
1571}
1572
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001573// verifyUsesLibraries checks the <uses-library> tags in the manifest against the ones specified
1574// in the `uses_libs`/`optional_uses_libs` properties. The input can be either an XML manifest, or
1575// an APK with the manifest embedded in it (manifest_check will know which one it is by the file
1576// extension: APKs are supposed to end with '.apk').
1577func (u *usesLibrary) verifyUsesLibraries(ctx android.ModuleContext, inputFile android.Path,
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001578 outputFile android.WritablePath) android.Path {
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001579
Ulya Trafimovich8c35fcf2021-02-17 16:23:28 +00001580 statusFile := dexpreopt.UsesLibrariesStatusFile(ctx)
Colin Cross50ddcc42019-05-16 12:28:22 -07001581
Ulya Trafimovich6e55ef12021-03-04 12:37:50 +00001582 // Disable verify_uses_libraries check if dexpreopt is globally disabled. Without dexpreopt the
1583 // check is not necessary, and although it is good to have, it is difficult to maintain on
1584 // non-linux build platforms where dexpreopt is generally disabled (the check may fail due to
1585 // various unrelated reasons, such as a failure to get manifest from an APK).
Ulya Trafimovich39dd0a42021-03-29 14:57:34 +01001586 global := dexpreopt.GetGlobalConfig(ctx)
1587 if global.DisablePreopt || global.OnlyPreoptBootImageAndSystemServer {
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001588 return inputFile
Ulya Trafimovich6e55ef12021-03-04 12:37:50 +00001589 }
1590
Colin Crossf1a035e2020-11-16 17:32:30 -08001591 rule := android.NewRuleBuilder(pctx, ctx)
1592 cmd := rule.Command().BuiltTool("manifest_check").
Colin Cross50ddcc42019-05-16 12:28:22 -07001593 Flag("--enforce-uses-libraries").
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001594 Input(inputFile).
Ulya Trafimovich8c35fcf2021-02-17 16:23:28 +00001595 FlagWithOutput("--enforce-uses-libraries-status ", statusFile).
Saeid Farivar Asanjanfd27c7c2022-08-08 20:21:26 +00001596 FlagWithInput("--aapt ", ctx.Config().HostToolPath(ctx, "aapt2"))
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001597
1598 if outputFile != nil {
1599 cmd.FlagWithOutput("-o ", outputFile)
1600 }
Colin Cross50ddcc42019-05-16 12:28:22 -07001601
Ulya Trafimovich8c35fcf2021-02-17 16:23:28 +00001602 if dexpreopt.GetGlobalConfig(ctx).RelaxUsesLibraryCheck {
1603 cmd.Flag("--enforce-uses-libraries-relax")
1604 }
1605
Colin Cross50ddcc42019-05-16 12:28:22 -07001606 for _, lib := range u.usesLibraryProperties.Uses_libs {
1607 cmd.FlagWithArg("--uses-library ", lib)
1608 }
1609
1610 for _, lib := range u.usesLibraryProperties.Optional_uses_libs {
1611 cmd.FlagWithArg("--optional-uses-library ", lib)
1612 }
1613
Colin Crossf1a035e2020-11-16 17:32:30 -08001614 rule.Build("verify_uses_libraries", "verify <uses-library>")
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001615 return outputFile
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001616}
Colin Cross50ddcc42019-05-16 12:28:22 -07001617
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001618// verifyUsesLibrariesManifest checks the <uses-library> tags in an AndroidManifest.xml against
1619// the build system and returns the path to a copy of the manifest.
1620func (u *usesLibrary) verifyUsesLibrariesManifest(ctx android.ModuleContext, manifest android.Path) android.Path {
1621 outputFile := android.PathForModuleOut(ctx, "manifest_check", "AndroidManifest.xml")
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001622 return u.verifyUsesLibraries(ctx, manifest, outputFile)
Colin Cross50ddcc42019-05-16 12:28:22 -07001623}
1624
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001625// verifyUsesLibrariesAPK checks the <uses-library> tags in the manifest of an APK against the build
1626// system and returns the path to a copy of the APK.
Cole Faust2f1da162023-04-17 15:06:56 -07001627func (u *usesLibrary) verifyUsesLibrariesAPK(ctx android.ModuleContext, apk android.Path) {
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001628 u.verifyUsesLibraries(ctx, apk, nil) // for APKs manifest_check does not write output file
Colin Cross50ddcc42019-05-16 12:28:22 -07001629}
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001630
1631// For Bazel / bp2build
1632
1633type bazelAndroidAppCertificateAttributes struct {
1634 Certificate string
1635}
1636
Chris Parsons637458d2023-09-19 20:09:00 +00001637func (m *AndroidAppCertificate) ConvertWithBp2build(ctx android.Bp2buildMutatorContext) {
Liz Kammerbe46fcc2021-11-01 15:32:43 -04001638 androidAppCertificateBp2Build(ctx, m)
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001639}
1640
Chris Parsons637458d2023-09-19 20:09:00 +00001641func androidAppCertificateBp2Build(ctx android.Bp2buildMutatorContext, module *AndroidAppCertificate) {
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001642 var certificate string
1643 if module.properties.Certificate != nil {
1644 certificate = *module.properties.Certificate
1645 }
1646
1647 attrs := &bazelAndroidAppCertificateAttributes{
1648 Certificate: certificate,
1649 }
1650
1651 props := bazel.BazelTargetModuleProperties{
1652 Rule_class: "android_app_certificate",
Alixa381cd12023-05-10 14:49:38 +00001653 Bzl_load_location: "//build/bazel/rules/android:android_app_certificate.bzl",
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001654 }
1655
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux447f6c92021-08-31 20:30:36 +00001656 ctx.CreateBazelTargetModule(props, android.CommonAttributes{Name: module.Name()}, attrs)
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001657}
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001658
Alixe5085eb2023-01-31 19:38:41 +00001659type manifestValueAttribute struct {
Romain Jobredeaux496660d2023-07-10 11:50:00 -04001660 MinSdkVersion *string
Romain Jobredeaux496660d2023-07-10 11:50:00 -04001661 TargetSdkVersion *string
Alixe5085eb2023-01-31 19:38:41 +00001662}
1663
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001664type bazelAndroidAppAttributes struct {
Sam Delmericoc0161432022-02-25 21:34:51 +00001665 *javaCommonAttributes
Romain Jobredeauxc9b2bba2022-02-15 09:35:07 -05001666 *bazelAapt
Sam Delmericoc0161432022-02-25 21:34:51 +00001667 Deps bazel.LabelListAttribute
Sam Delmerico9dfb1392022-02-10 21:11:59 +00001668 Custom_package *string
Jingwen Chen6817bbb2022-10-14 09:56:07 +00001669 Certificate bazel.LabelAttribute
1670 Certificate_name bazel.StringAttribute
Alixe5085eb2023-01-31 19:38:41 +00001671 Manifest_values *manifestValueAttribute
Romain Jobredeaux9973ace2023-08-30 00:27:09 -04001672 Optimize *bool
1673 Proguard_specs bazel.LabelListAttribute
Romain Jobredeaux3132f842023-09-15 10:06:16 -04001674 Updatable *bool
Jingwen Chenbea58092022-09-29 16:56:02 +00001675}
1676
Alixee51bd62023-08-29 16:01:46 +00001677func (b bazelAapt) ConvertJavaResources(ctx android.Bp2buildMutatorContext, javaAttrs *javaCommonAttributes) bool {
1678 // TODO (b/300470246) bp2build support for java_resources & java_resource_dirs in android rules
1679 hasJavaResources := !javaAttrs.javaResourcesAttributes.Resources.IsEmpty()
1680 if hasJavaResources {
1681 ctx.MarkBp2buildUnconvertible(bp2build_metrics_proto.UnconvertedReasonType_UNSUPPORTED, "(b/300470246) java resources in android_* module")
1682 }
1683 return hasJavaResources
1684}
1685
Chris Parsons637458d2023-09-19 20:09:00 +00001686func convertWithBp2build(ctx android.Bp2buildMutatorContext, a *AndroidApp) (bool, android.CommonAttributes, *bazelAndroidAppAttributes) {
Romain Jobredeaux7a71e072023-08-16 17:39:12 -04001687 aapt, supported := a.convertAaptAttrsWithBp2Build(ctx)
1688 if !supported {
Jingwen Chene12c0832023-08-25 09:00:16 +00001689 return false, android.CommonAttributes{}, &bazelAndroidAppAttributes{}
Romain Jobredeaux7a71e072023-08-16 17:39:12 -04001690 }
Spandan Das0e0a8802023-09-20 19:53:30 +00001691 if a.appProperties.Jni_uses_platform_apis != nil {
1692 ctx.MarkBp2buildUnconvertible(
1693 bp2build_metrics_proto.UnconvertedReasonType_UNSUPPORTED,
1694 "TODO - b/299360988: Add bp2build support for jni_uses_platform_apis",
1695 )
1696 return false, android.CommonAttributes{}, &bazelAndroidAppAttributes{}
1697 }
1698 if a.appProperties.Jni_uses_sdk_apis != nil {
1699 ctx.MarkBp2buildUnconvertible(
1700 bp2build_metrics_proto.UnconvertedReasonType_UNSUPPORTED,
1701 "TODO - b/299360988: Add bp2build support for jni_uses_sdk_apis",
1702 )
1703 return false, android.CommonAttributes{}, &bazelAndroidAppAttributes{}
1704 }
1705
Jingwen Chen6817bbb2022-10-14 09:56:07 +00001706 certificate, certificateName := android.BazelStringOrLabelFromProp(ctx, a.overridableAppProperties.Certificate)
1707
Romain Jobredeaux3132f842023-09-15 10:06:16 -04001708 manifestValues := &manifestValueAttribute{
1709 MinSdkVersion: a.deviceProperties.Min_sdk_version,
1710 TargetSdkVersion: a.deviceProperties.Target_sdk_version,
Romain Jobredeaux496660d2023-07-10 11:50:00 -04001711 }
1712
Alix0856f9e2023-01-20 22:15:30 +00001713 appAttrs := &bazelAndroidAppAttributes{
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001714 // TODO(b/209576404): handle package name override by product variable PRODUCT_MANIFEST_PACKAGE_NAME_OVERRIDES
Alix0856f9e2023-01-20 22:15:30 +00001715 Custom_package: a.overridableAppProperties.Package_name,
1716 Certificate: certificate,
1717 Certificate_name: certificateName,
Alixe5085eb2023-01-31 19:38:41 +00001718 Manifest_values: manifestValues,
Romain Jobredeaux3132f842023-09-15 10:06:16 -04001719 Updatable: a.appProperties.Updatable,
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001720 }
Sam Delmerico9dfb1392022-02-10 21:11:59 +00001721
Romain Jobredeaux9c06ef32023-08-21 18:05:29 -04001722 // As framework-res has no sources, no deps in the Bazel sense, and java compilation, dexing and optimization is skipped by
1723 // Soong specifically for it, return early here before any of the conversion work for the above is attempted.
1724 if ctx.ModuleName() == "framework-res" {
1725 appAttrs.bazelAapt = aapt
1726 return true, android.CommonAttributes{Name: a.Name(), SkipData: proptools.BoolPtr(true)}, appAttrs
1727 }
1728
Jingwen Chen65229202023-09-20 13:34:16 +00001729 // Optimization is..
1730 // - enabled by default for android_app, android_test_helper_app
1731 // - disabled by default for android_test
1732 //
1733 // TODO(b/192032291): Disable android_test_helper_app optimization by
1734 // default after auditing downstream usage.
Jingwen Chen256c3892023-09-26 05:51:40 +00001735 if a.dexProperties.Optimize.EnabledByDefault != a.dexer.effectiveOptimizeEnabled() {
1736 // Property is explicitly defined by default from default, so emit the Bazel attribute.
1737 appAttrs.Optimize = proptools.BoolPtr(a.dexer.effectiveOptimizeEnabled())
Jingwen Chen65229202023-09-20 13:34:16 +00001738 }
Jingwen Chen65229202023-09-20 13:34:16 +00001739
Jingwen Chen256c3892023-09-26 05:51:40 +00001740 if a.dexer.effectiveOptimizeEnabled() {
Romain Jobredeaux9973ace2023-08-30 00:27:09 -04001741 handCraftedFlags := ""
1742 if Bool(a.dexProperties.Optimize.Ignore_warnings) {
1743 handCraftedFlags += "-ignorewarning "
1744 }
1745 if !Bool(a.dexProperties.Optimize.Shrink) {
1746 handCraftedFlags += "-dontshrink "
1747 }
1748 if !Bool(a.dexProperties.Optimize.Optimize) {
1749 handCraftedFlags += "-dontoptimize "
1750 }
1751 if !Bool(a.dexProperties.Optimize.Obfuscate) {
1752 handCraftedFlags += "-dontobfuscate "
1753 }
1754 appAttrs.Proguard_specs = bazel.MakeLabelListAttribute(android.BazelLabelForModuleSrc(ctx, a.dexProperties.Optimize.Proguard_flags_files))
1755 if handCraftedFlags != "" {
1756 generatedFlagFileRuleName := a.Name() + "_proguard_flags"
1757 ctx.CreateBazelTargetModule(bazel.BazelTargetModuleProperties{
1758 Rule_class: "genrule",
1759 }, android.CommonAttributes{
1760 Name: generatedFlagFileRuleName,
1761 SkipData: proptools.BoolPtr(true),
1762 }, &genrule.BazelGenruleAttributes{
1763 Outs: []string{a.Name() + "_proguard.flags"},
1764 Cmd: bazel.StringAttribute{
1765 Value: proptools.StringPtr("echo " + handCraftedFlags + "> $(OUTS)"),
1766 },
1767 })
1768 appAttrs.Proguard_specs.Add(bazel.MakeLabelAttribute(":" + generatedFlagFileRuleName))
1769 }
Romain Jobredeaux9973ace2023-08-30 00:27:09 -04001770 }
1771
Romain Jobredeauxd2cc5032023-09-11 16:37:50 -04001772 commonAttrs, bp2BuildInfo, supported := a.convertLibraryAttrsBp2Build(ctx)
1773 if !supported {
Jingwen Chene12c0832023-08-25 09:00:16 +00001774 return false, android.CommonAttributes{}, &bazelAndroidAppAttributes{}
Romain Jobredeauxd2cc5032023-09-11 16:37:50 -04001775 }
Alixee51bd62023-08-29 16:01:46 +00001776 if hasJavaResources := aapt.ConvertJavaResources(ctx, commonAttrs); hasJavaResources {
1777 return false, android.CommonAttributes{}, &bazelAndroidAppAttributes{}
1778 }
1779
Romain Jobredeauxd2cc5032023-09-11 16:37:50 -04001780 depLabels := bp2BuildInfo.DepLabels
1781
1782 deps := depLabels.Deps
1783 deps.Append(depLabels.StaticDeps)
1784
Romain Jobredeaux947dfa72023-06-12 15:40:35 -04001785 var jniDeps bazel.LabelListAttribute
1786 archVariantProps := a.GetArchVariantProperties(ctx, &appProperties{})
1787 for axis, configToProps := range archVariantProps {
1788 for config, _props := range configToProps {
1789 if archProps, ok := _props.(*appProperties); ok {
1790 archJniLibs := android.BazelLabelForModuleDeps(
1791 ctx,
1792 android.LastUniqueStrings(android.CopyOf(archProps.Jni_libs)))
1793 jniDeps.SetSelectValue(axis, config, archJniLibs)
1794 }
1795 }
1796 }
1797 deps.Append(jniDeps)
1798
Alix75db7842023-03-06 22:08:49 +00001799 if !bp2BuildInfo.hasKotlin {
Alix0856f9e2023-01-20 22:15:30 +00001800 appAttrs.javaCommonAttributes = commonAttrs
1801 appAttrs.bazelAapt = aapt
1802 appAttrs.Deps = deps
Alix0856f9e2023-01-20 22:15:30 +00001803 } else {
1804 ktName := a.Name() + "_kt"
Alix0856f9e2023-01-20 22:15:30 +00001805 ctx.CreateBazelTargetModule(
Alix32540022023-03-16 21:06:13 +00001806 AndroidLibraryBazelTargetModuleProperties(),
Alix0856f9e2023-01-20 22:15:30 +00001807 android.CommonAttributes{Name: ktName},
1808 &bazelAndroidLibrary{
1809 javaLibraryAttributes: &javaLibraryAttributes{
1810 javaCommonAttributes: commonAttrs,
1811 Deps: deps,
1812 },
1813 bazelAapt: aapt,
1814 },
1815 )
1816
1817 appAttrs.bazelAapt = &bazelAapt{Manifest: aapt.Manifest}
1818 appAttrs.Deps = bazel.MakeSingleLabelListAttribute(bazel.Label{Label: ":" + ktName})
Romain Jobredeaux2eef2e12023-02-24 12:07:08 -05001819 appAttrs.javaCommonAttributes = &javaCommonAttributes{
1820 Sdk_version: commonAttrs.Sdk_version,
1821 }
Alix0856f9e2023-01-20 22:15:30 +00001822 }
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001823
Jingwen Chene12c0832023-08-25 09:00:16 +00001824 return true, android.CommonAttributes{Name: a.Name(), SkipData: proptools.BoolPtr(true)}, appAttrs
1825}
1826
1827// ConvertWithBp2build is used to convert android_app to Bazel.
Chris Parsons637458d2023-09-19 20:09:00 +00001828func (a *AndroidApp) ConvertWithBp2build(ctx android.Bp2buildMutatorContext) {
Jingwen Chene12c0832023-08-25 09:00:16 +00001829 if ok, commonAttrs, appAttrs := convertWithBp2build(ctx, a); ok {
Romain Jobredeaux9c06ef32023-08-21 18:05:29 -04001830 var props bazel.BazelTargetModuleProperties
1831 if ctx.ModuleName() == "framework-res" {
1832 props = bazel.BazelTargetModuleProperties{
1833 Rule_class: "framework_resources",
1834 Bzl_load_location: "//build/bazel/rules/android:framework_resources.bzl",
1835 }
1836 } else {
1837 props = bazel.BazelTargetModuleProperties{
1838 Rule_class: "android_binary",
1839 Bzl_load_location: "//build/bazel/rules/android:android_binary.bzl",
1840 }
Jingwen Chene12c0832023-08-25 09:00:16 +00001841 }
Jingwen Chene12c0832023-08-25 09:00:16 +00001842 ctx.CreateBazelTargetModule(props, commonAttrs, appAttrs)
1843 }
1844
1845}
1846
1847// ConvertWithBp2build is used to convert android_test to Bazel.
Chris Parsons637458d2023-09-19 20:09:00 +00001848func (at *AndroidTest) ConvertWithBp2build(ctx android.Bp2buildMutatorContext) {
Jingwen Chene12c0832023-08-25 09:00:16 +00001849 if ok, commonAttrs, appAttrs := convertWithBp2build(ctx, &at.AndroidApp); ok {
1850 props := bazel.BazelTargetModuleProperties{
1851 Rule_class: "android_test",
1852 Bzl_load_location: "//build/bazel/rules/android:android_test.bzl",
1853 }
1854
1855 ctx.CreateBazelTargetModule(props, commonAttrs, appAttrs)
1856 }
Alix733110e2023-02-06 14:53:10 +00001857
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001858}
Jingwen Chen65289992023-09-21 15:15:47 +00001859
1860func (atha *AndroidTestHelperApp) ConvertWithBp2build(ctx android.Bp2buildMutatorContext) {
1861 if ok, commonAttrs, appAttrs := convertWithBp2build(ctx, &atha.AndroidApp); ok {
1862 // an android_test_helper_app is an android_binary with testonly = True
1863 commonAttrs.Testonly = proptools.BoolPtr(true)
1864
Jingwen Chen65229202023-09-20 13:34:16 +00001865 // android_test_helper_app sets default values differently to android_app,
Jingwen Chen65289992023-09-21 15:15:47 +00001866 // https://cs.android.com/android/platform/superproject/main/+/main:build/soong/java/app.go;l=1273-1279;drc=e12c083198403ec694af6c625aed11327eb2bf7f
1867 //
1868 // installable: true (settable prop)
1869 // use_embedded_native_libs: true (settable prop)
1870 // lint.test: true (settable prop)
Jingwen Chen65289992023-09-21 15:15:47 +00001871 // AlwaysPackageNativeLibs: true (blueprint mutated prop)
1872 // dexpreopt isTest: true (not prop)
1873
1874 props := bazel.BazelTargetModuleProperties{
1875 Rule_class: "android_binary",
1876 Bzl_load_location: "//build/bazel/rules/android:android_binary.bzl",
1877 }
1878
1879 ctx.CreateBazelTargetModule(props, commonAttrs, appAttrs)
1880 }
1881}