blob: 0f46b4ec862daa8ad571bb9ac30d1889b084155a [file] [log] [blame]
Colin Cross30e076a2015-04-13 13:58:27 -07001// Copyright 2015 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
Jaewoong Jungf9b44652020-12-21 12:29:12 -080017// This file contains the module implementations for android_app, android_test, and some more
18// related module types, including their override variants.
Colin Cross30e076a2015-04-13 13:58:27 -070019
20import (
Jiakai Zhang4f65a032023-06-01 15:16:58 +010021 "fmt"
Jaewoong Junga5e5abc2019-04-26 14:31:50 -070022 "path/filepath"
Jaewoong Junga5e5abc2019-04-26 14:31:50 -070023 "strings"
Colin Cross30e076a2015-04-13 13:58:27 -070024
Aditya Choudhary9b593522023-10-06 19:54:58 +000025 "android/soong/testing"
Colin Cross50ddcc42019-05-16 12:28:22 -070026 "github.com/google/blueprint"
27 "github.com/google/blueprint/proptools"
28
Colin Cross635c3b02016-05-18 15:37:25 -070029 "android/soong/android"
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -040030 "android/soong/bazel"
Colin Crossa4f08812018-10-02 22:03:40 -070031 "android/soong/cc"
Ulya Trafimovichd4bcea42020-06-03 14:57:22 +010032 "android/soong/dexpreopt"
Romain Jobredeaux9973ace2023-08-30 00:27:09 -040033 "android/soong/genrule"
Colin Cross303e21f2018-08-07 16:49:25 -070034 "android/soong/tradefed"
Spandan Das0e0a8802023-09-20 19:53:30 +000035 "android/soong/ui/metrics/bp2build_metrics_proto"
Colin Cross30e076a2015-04-13 13:58:27 -070036)
37
Colin Cross3bc7ffa2017-11-22 16:19:37 -080038func init() {
Paul Duffinf9b1da02019-12-18 19:51:55 +000039 RegisterAppBuildComponents(android.InitRegistrationContext)
Andrei Onea580636b2022-08-17 16:53:46 +000040 pctx.HostBinToolVariable("ModifyAllowlistCmd", "modify_permissions_allowlist")
Colin Cross3bc7ffa2017-11-22 16:19:37 -080041}
42
Andrei Onea580636b2022-08-17 16:53:46 +000043var (
44 modifyAllowlist = pctx.AndroidStaticRule("modifyAllowlist",
45 blueprint.RuleParams{
46 Command: "${ModifyAllowlistCmd} $in $packageName $out",
47 CommandDeps: []string{"${ModifyAllowlistCmd}"},
48 }, "packageName")
49)
50
Paul Duffinf9b1da02019-12-18 19:51:55 +000051func RegisterAppBuildComponents(ctx android.RegistrationContext) {
52 ctx.RegisterModuleType("android_app", AndroidAppFactory)
53 ctx.RegisterModuleType("android_test", AndroidTestFactory)
54 ctx.RegisterModuleType("android_test_helper_app", AndroidTestHelperAppFactory)
55 ctx.RegisterModuleType("android_app_certificate", AndroidAppCertificateFactory)
56 ctx.RegisterModuleType("override_android_app", OverrideAndroidAppModuleFactory)
57 ctx.RegisterModuleType("override_android_test", OverrideAndroidTestModuleFactory)
Paul Duffinf9b1da02019-12-18 19:51:55 +000058}
59
Colin Cross30e076a2015-04-13 13:58:27 -070060// AndroidManifest.xml merging
61// package splits
62
Colin Crossfabb6082018-02-20 17:22:23 -080063type appProperties struct {
Colin Crossbd01e2a2018-10-04 15:21:03 -070064 // Names of extra android_app_certificate modules to sign the apk with in the form ":module".
Colin Cross7d5136f2015-05-11 13:39:40 -070065 Additional_certificates []string
66
67 // If set, create package-export.apk, which other packages can
68 // use to get PRODUCT-agnostic resource data like IDs and type definitions.
Nan Zhangea568a42017-11-08 21:20:04 -080069 Export_package_resources *bool
Colin Cross7d5136f2015-05-11 13:39:40 -070070
Colin Cross16056062017-12-13 22:46:28 -080071 // Specifies that this app should be installed to the priv-app directory,
72 // where the system will grant it additional privileges not available to
73 // normal apps.
74 Privileged *bool
Colin Crossa97c5d32018-03-28 14:58:31 -070075
76 // list of resource labels to generate individual resource packages
77 Package_splits []string
Jason Monkd4122be2018-08-10 09:33:36 -040078
Colin Crossa4f08812018-10-02 22:03:40 -070079 // list of native libraries that will be provided in or alongside the resulting jar
80 Jni_libs []string `android:"arch_variant"`
81
Colin Cross7204cf02020-05-06 17:51:39 -070082 // if true, use JNI libraries that link against platform APIs even if this module sets
Colin Crossee87c602020-02-19 16:57:15 -080083 // sdk_version.
84 Jni_uses_platform_apis *bool
85
Colin Cross7204cf02020-05-06 17:51:39 -070086 // if true, use JNI libraries that link against SDK APIs even if this module does not set
87 // sdk_version.
88 Jni_uses_sdk_apis *bool
89
Jaewoong Jungbc625cd2019-05-06 15:48:44 -070090 // STL library to use for JNI libraries.
91 Stl *string `android:"arch_variant"`
92
Colin Crosse4246ab2019-02-05 21:55:21 -080093 // Store native libraries uncompressed in the APK and set the android:extractNativeLibs="false" manifest
94 // flag so that they are used from inside the APK at runtime. Defaults to true for android_test modules unless
Jiyong Park52cd06f2019-11-11 10:14:32 +090095 // sdk_version or min_sdk_version is set to a version that doesn't support it (<23), defaults to true for
96 // android_app modules that are embedded to APEXes, defaults to false for other module types where the native
97 // libraries are generally preinstalled outside the APK.
Colin Crosse4246ab2019-02-05 21:55:21 -080098 Use_embedded_native_libs *bool
Colin Cross46abdad2019-02-07 13:07:08 -080099
100 // Store dex files uncompressed in the APK and set the android:useEmbeddedDex="true" manifest attribute so that
101 // they are used from inside the APK at runtime.
102 Use_embedded_dex *bool
Colin Cross47fa9d32019-03-26 10:51:39 -0700103
104 // Forces native libraries to always be packaged into the APK,
105 // Use_embedded_native_libs still selects whether they are stored uncompressed and aligned or compressed.
106 // True for android_test* modules.
107 AlwaysPackageNativeLibs bool `blueprint:"mutated"`
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700108
109 // If set, find and merge all NOTICE files that this module and its dependencies have and store
110 // it in the APK as an asset.
111 Embed_notices *bool
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700112
113 // cc.Coverage related properties
114 PreventInstall bool `blueprint:"mutated"`
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700115 IsCoverageVariant bool `blueprint:"mutated"`
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100116
Harshit Mahajan5b8b7302022-06-10 11:24:05 +0000117 // It can be set to test the behaviour of default target sdk version.
118 // Only required when updatable: false. It is an error if updatable: true and this is false.
119 Enforce_default_target_sdk_version *bool
120
121 // If set, the targetSdkVersion for the target is set to the latest default API level.
122 // This would be by default false, unless updatable: true or
123 // enforce_default_target_sdk_version: true in which case this defaults to true.
124 EnforceDefaultTargetSdkVersion bool `blueprint:"mutated"`
125
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100126 // Whether this app is considered mainline updatable or not. When set to true, this will enforce
Artur Satayevf40fc852020-04-16 13:43:02 +0100127 // additional rules to make sure an app can safely be updated. Default is false.
128 // Prefer using other specific properties if build behaviour must be changed; avoid using this
129 // flag for anything but neverallow rules (unless the behaviour change is invisible to owners).
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100130 Updatable *bool
Andrei Onea580636b2022-08-17 16:53:46 +0000131
132 // Specifies the file that contains the allowlist for this app.
133 Privapp_allowlist *string `android:"path"`
Inseob Kim34dc4cd2023-11-07 13:37:14 +0900134
135 // If set, create an RRO package which contains only resources having PRODUCT_CHARACTERISTICS
136 // and install the RRO package to /product partition, instead of passing --product argument
137 // to aapt2. Default is false.
138 // Setting this will make this APK identical to all targets, regardless of
139 // PRODUCT_CHARACTERISTICS.
140 Generate_product_characteristics_rro *bool
141
142 ProductCharacteristicsRROPackageName *string `blueprint:"mutated"`
143 ProductCharacteristicsRROManifestModuleName *string `blueprint:"mutated"`
Colin Cross7d5136f2015-05-11 13:39:40 -0700144}
145
Jaewoong Jung525443a2019-02-28 15:35:54 -0800146// android_app properties that can be overridden by override_android_app
147type overridableAppProperties struct {
148 // The name of a certificate in the default certificate directory, blank to use the default product certificate,
149 // or an android_app_certificate module name in the form ":module".
150 Certificate *string
Jaewoong Jung6f373f62019-03-13 10:13:24 -0700151
Jaewoong Jung1c1b6e62021-03-09 15:02:31 -0800152 // Name of the signing certificate lineage file or filegroup module.
153 Lineage *string `android:"path"`
Liz Kammere2b27f42020-05-07 13:24:05 -0700154
Rupert Shuttleworth8eab8692021-11-03 10:39:39 -0400155 // For overriding the --rotation-min-sdk-version property of apksig
156 RotationMinSdkVersion *string
157
Jaewoong Jung6f373f62019-03-13 10:13:24 -0700158 // the package name of this app. The package name in the manifest file is used if one was not given.
159 Package_name *string
Baligh Uddin5b16dfb2020-02-11 17:27:19 -0800160
161 // the logging parent of this app.
162 Logging_parent *string
Liz Kammer9f9fd022020-06-18 19:44:06 +0000163
164 // Whether to rename the package in resources to the override name rather than the base name. Defaults to true.
165 Rename_resources_package *bool
zhidou198f5892022-02-17 02:33:12 +0000166
167 // Names of modules to be overridden. Listed modules can only be other binaries
168 // (in Make or Soong).
169 // This does not completely prevent installation of the overridden binaries, but if both
170 // binaries would be installed by default (in PRODUCT_PACKAGES) the other binary will be removed
171 // from PRODUCT_PACKAGES.
172 Overrides []string
Jaewoong Jung525443a2019-02-28 15:35:54 -0800173}
174
Colin Cross30e076a2015-04-13 13:58:27 -0700175type AndroidApp struct {
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400176 android.BazelModuleBase
Colin Crossa97c5d32018-03-28 14:58:31 -0700177 Library
178 aapt
Jaewoong Jung525443a2019-02-28 15:35:54 -0800179 android.OverridableModuleBase
Colin Crossa97c5d32018-03-28 14:58:31 -0700180
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900181 certificate Certificate
Colin Cross30e076a2015-04-13 13:58:27 -0700182
Colin Crossfabb6082018-02-20 17:22:23 -0800183 appProperties appProperties
Colin Crossae5caf52018-05-22 11:11:52 -0700184
Jaewoong Jung525443a2019-02-28 15:35:54 -0800185 overridableAppProperties overridableAppProperties
186
Colin Cross403cc152020-07-06 14:15:24 -0700187 jniLibs []jniLib
188 installPathForJNISymbols android.Path
189 embeddedJniLibs bool
190 jniCoverageOutputs android.Paths
Colin Crossf6237212018-10-29 23:14:58 -0700191
192 bundleFile android.Path
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800193
194 // the install APK name is normally the same as the module name, but can be overridden with PRODUCT_PACKAGE_NAME_OVERRIDES.
195 installApkName string
Jaewoong Jung4102e5d2019-02-27 16:26:28 -0800196
Colin Cross70dda7e2019-10-01 22:05:35 -0700197 installDir android.InstallPath
Jaewoong Jung0949f312019-09-11 10:25:18 -0700198
Jaewoong Jung7dd4ae22019-09-27 17:13:15 -0700199 onDeviceDir string
200
Jaewoong Jung4102e5d2019-02-27 16:26:28 -0800201 additionalAaptFlags []string
Jaewoong Jung98772792019-07-01 17:15:13 -0700202
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900203 overriddenManifestPackageName string
Artur Satayev1111b842020-04-27 19:05:28 +0100204
205 android.ApexBundleDepsInfo
Matt Banda8c801262022-04-01 17:48:31 +0000206
207 javaApiUsedByOutputFile android.ModuleOutPath
Andrei Onea580636b2022-08-17 16:53:46 +0000208
209 privAppAllowlist android.OptionalPath
Colin Crosse1731a52017-12-14 11:22:55 -0800210}
211
Martin Stjernholm6d415272020-01-31 17:10:36 +0000212func (a *AndroidApp) IsInstallable() bool {
213 return Bool(a.properties.Installable)
214}
215
Colin Crossab8d1382023-07-14 17:23:41 +0000216func (a *AndroidApp) ResourcesNodeDepSet() *android.DepSet[*resourcesNode] {
217 return a.aapt.resourcesNodesDepSet
Colin Cross66f78822018-05-02 12:58:28 -0700218}
219
Sundong Ahne1f05aa2019-08-27 13:55:42 +0900220func (a *AndroidApp) OutputFile() android.Path {
221 return a.outputFile
222}
223
Colin Cross503c1d02020-01-28 14:00:53 -0800224func (a *AndroidApp) Certificate() Certificate {
225 return a.certificate
226}
227
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700228func (a *AndroidApp) JniCoverageOutputs() android.Paths {
229 return a.jniCoverageOutputs
230}
231
Andrei Onea580636b2022-08-17 16:53:46 +0000232func (a *AndroidApp) PrivAppAllowlist() android.OptionalPath {
233 return a.privAppAllowlist
234}
235
Colin Crossa97c5d32018-03-28 14:58:31 -0700236var _ AndroidLibraryDependency = (*AndroidApp)(nil)
237
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900238type Certificate struct {
Colin Cross503c1d02020-01-28 14:00:53 -0800239 Pem, Key android.Path
240 presigned bool
241}
242
Sasha Smundak18d98bc2020-05-27 16:36:07 -0700243var PresignedCertificate = Certificate{presigned: true}
Colin Cross503c1d02020-01-28 14:00:53 -0800244
245func (c Certificate) AndroidMkString() string {
246 if c.presigned {
247 return "PRESIGNED"
248 } else {
249 return c.Pem.String()
250 }
Colin Cross30e076a2015-04-13 13:58:27 -0700251}
252
Colin Cross46c9b8b2017-06-22 16:51:17 -0700253func (a *AndroidApp) DepsMutator(ctx android.BottomUpMutatorContext) {
254 a.Module.deps(ctx)
Colin Crossa4f08812018-10-02 22:03:40 -0700255
Jiyong Park92315372021-04-02 08:45:46 +0900256 if String(a.appProperties.Stl) == "c++_shared" && !a.SdkVersion(ctx).Specified() {
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700257 ctx.PropertyErrorf("stl", "sdk_version must be set in order to use c++_shared")
258 }
259
Jiyong Parkf1691d22021-03-29 20:11:58 +0900260 sdkDep := decodeSdkDep(ctx, android.SdkContext(a))
Paul Duffin250e6192019-06-07 10:44:37 +0100261 if sdkDep.hasFrameworkLibs() {
262 a.aapt.deps(ctx, sdkDep)
Colin Cross30e076a2015-04-13 13:58:27 -0700263 }
Colin Crossa4f08812018-10-02 22:03:40 -0700264
Jiyong Park92315372021-04-02 08:45:46 +0900265 usesSDK := a.SdkVersion(ctx).Specified() && a.SdkVersion(ctx).Kind != android.SdkCorePlatform
Colin Cross3c007702020-05-08 11:20:24 -0700266
267 if usesSDK && Bool(a.appProperties.Jni_uses_sdk_apis) {
268 ctx.PropertyErrorf("jni_uses_sdk_apis",
269 "can only be set for modules that do not set sdk_version")
270 } else if !usesSDK && Bool(a.appProperties.Jni_uses_platform_apis) {
271 ctx.PropertyErrorf("jni_uses_platform_apis",
272 "can only be set for modules that set sdk_version")
273 }
274
Colin Crossa4f08812018-10-02 22:03:40 -0700275 for _, jniTarget := range ctx.MultiTargets() {
Colin Cross0f7d2ef2019-10-16 11:03:10 -0700276 variation := append(jniTarget.Variations(),
277 blueprint.Variation{Mutator: "link", Variation: "shared"})
Colin Crossc511bc52020-04-07 16:50:32 +0000278
279 // If the app builds against an Android SDK use the SDK variant of JNI dependencies
280 // unless jni_uses_platform_apis is set.
Colin Crossc2d24052020-05-13 11:05:02 -0700281 // Don't require the SDK variant for apps that are shipped on vendor, etc., as they already
282 // have stable APIs through the VNDK.
283 if (usesSDK && !a.RequiresStableAPIs(ctx) &&
284 !Bool(a.appProperties.Jni_uses_platform_apis)) ||
Colin Cross7204cf02020-05-06 17:51:39 -0700285 Bool(a.appProperties.Jni_uses_sdk_apis) {
Colin Crossc511bc52020-04-07 16:50:32 +0000286 variation = append(variation, blueprint.Variation{Mutator: "sdk", Variation: "sdk"})
287 }
Colin Crossde78d132020-10-09 18:59:49 -0700288 ctx.AddFarVariationDependencies(variation, jniLibTag, a.appProperties.Jni_libs...)
Colin Crossa4f08812018-10-02 22:03:40 -0700289 }
Colin Cross50ddcc42019-05-16 12:28:22 -0700290
Paul Duffin250e6192019-06-07 10:44:37 +0100291 a.usesLibrary.deps(ctx, sdkDep.hasFrameworkLibs())
Jaewoong Jungb639a6a2019-05-10 15:16:29 -0700292}
Colin Crossbd01e2a2018-10-04 15:21:03 -0700293
Jaewoong Jungb639a6a2019-05-10 15:16:29 -0700294func (a *AndroidApp) OverridablePropertiesDepsMutator(ctx android.BottomUpMutatorContext) {
Jaewoong Jung2ad817c2019-01-18 14:27:16 -0800295 cert := android.SrcIsModule(a.getCertString(ctx))
Colin Crossbd01e2a2018-10-04 15:21:03 -0700296 if cert != "" {
297 ctx.AddDependency(ctx.Module(), certificateTag, cert)
298 }
299
Andrei Onea580636b2022-08-17 16:53:46 +0000300 if a.appProperties.Privapp_allowlist != nil && !Bool(a.appProperties.Privileged) {
Anton Hanssone3f31cf2023-06-03 08:53:47 +0000301 // There are a few uids that are explicitly considered privileged regardless of their
302 // app's location. Bluetooth is one such app. It should arguably be moved to priv-app,
303 // but for now, allow it not to be in priv-app.
304 privilegedBecauseOfUid := ctx.ModuleName() == "Bluetooth"
305 if !privilegedBecauseOfUid {
306 ctx.PropertyErrorf("privapp_allowlist", "privileged must be set in order to use privapp_allowlist (with a few exceptions)")
307 }
Andrei Onea580636b2022-08-17 16:53:46 +0000308 }
309
Colin Crossbd01e2a2018-10-04 15:21:03 -0700310 for _, cert := range a.appProperties.Additional_certificates {
311 cert = android.SrcIsModule(cert)
312 if cert != "" {
313 ctx.AddDependency(ctx.Module(), certificateTag, cert)
314 } else {
315 ctx.PropertyErrorf("additional_certificates",
316 `must be names of android_app_certificate modules in the form ":module"`)
317 }
318 }
Colin Cross30e076a2015-04-13 13:58:27 -0700319}
320
Jeongik Cha538c0d02019-07-11 15:54:27 +0900321func (a *AndroidTestHelperApp) GenerateAndroidBuildActions(ctx android.ModuleContext) {
Alix96ea88452023-08-31 15:48:23 +0000322 applicationId := a.appTestHelperAppProperties.Manifest_values.ApplicationId
323 if applicationId != nil {
324 if a.overridableAppProperties.Package_name != nil {
325 ctx.PropertyErrorf("manifest_values.applicationId", "property is not supported when property package_name is set.")
326 }
327 a.aapt.manifestValues.applicationId = *applicationId
328 }
Jeongik Cha538c0d02019-07-11 15:54:27 +0900329 a.generateAndroidBuildActions(ctx)
330}
331
Colin Cross46c9b8b2017-06-22 16:51:17 -0700332func (a *AndroidApp) GenerateAndroidBuildActions(ctx android.ModuleContext) {
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100333 a.checkAppSdkVersions(ctx)
Colin Crossae5caf52018-05-22 11:11:52 -0700334 a.generateAndroidBuildActions(ctx)
Matt Banda8c801262022-04-01 17:48:31 +0000335 a.generateJavaUsedByApex(ctx)
Colin Crossae5caf52018-05-22 11:11:52 -0700336}
337
Sam Delmerico0e0d96e2023-08-18 22:43:28 +0000338func (a *AndroidApp) MinSdkVersion(ctx android.EarlyModuleContext) android.ApiLevel {
339 defaultMinSdkVersion := a.Module.MinSdkVersion(ctx)
340 if proptools.Bool(a.appProperties.Updatable) {
341 overrideApiLevel := android.MinSdkVersionFromValue(ctx, ctx.DeviceConfig().ApexGlobalMinSdkVersionOverride())
342 if !overrideApiLevel.IsNone() && overrideApiLevel.CompareTo(defaultMinSdkVersion) > 0 {
343 return overrideApiLevel
344 }
345 }
346 return defaultMinSdkVersion
347}
348
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100349func (a *AndroidApp) checkAppSdkVersions(ctx android.ModuleContext) {
Artur Satayev849f8442020-04-28 14:57:42 +0100350 if a.Updatable() {
Jiyong Park92315372021-04-02 08:45:46 +0900351 if !a.SdkVersion(ctx).Stable() {
352 ctx.PropertyErrorf("sdk_version", "Updatable apps must use stable SDKs, found %v", a.SdkVersion(ctx))
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100353 }
Artur Satayevf40fc852020-04-16 13:43:02 +0100354 if String(a.deviceProperties.Min_sdk_version) == "" {
355 ctx.PropertyErrorf("updatable", "updatable apps must set min_sdk_version.")
356 }
Jooyung Han749dc692020-04-15 11:03:39 +0900357
Jiyong Park92315372021-04-02 08:45:46 +0900358 if minSdkVersion, err := a.MinSdkVersion(ctx).EffectiveVersion(ctx); err == nil {
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900359 a.checkJniLibsSdkVersion(ctx, minSdkVersion)
satayevb3fd4112021-12-02 13:59:35 +0000360 android.CheckMinSdkVersion(ctx, minSdkVersion, a.WalkPayloadDeps)
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900361 } else {
362 ctx.PropertyErrorf("min_sdk_version", "%s", err.Error())
363 }
Harshit Mahajan5b8b7302022-06-10 11:24:05 +0000364
365 if !BoolDefault(a.appProperties.Enforce_default_target_sdk_version, true) {
366 ctx.PropertyErrorf("enforce_default_target_sdk_version", "Updatable apps must enforce default target sdk version")
367 }
368 // TODO(b/227460469) after all the modules removes the target sdk version, throw an error if the target sdk version is explicitly set.
369 if a.deviceProperties.Target_sdk_version == nil {
370 a.SetEnforceDefaultTargetSdkVersion(true)
371 }
372 }
373
Artur Satayev2db1c3f2020-04-08 19:09:30 +0100374 a.checkPlatformAPI(ctx)
375 a.checkSdkVersions(ctx)
376}
377
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900378// If an updatable APK sets min_sdk_version, min_sdk_vesion of JNI libs should match with it.
379// This check is enforced for "updatable" APKs (including APK-in-APEX).
Jiyong Park54105c42021-03-31 18:17:53 +0900380func (a *AndroidApp) checkJniLibsSdkVersion(ctx android.ModuleContext, minSdkVersion android.ApiLevel) {
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900381 // It's enough to check direct JNI deps' sdk_version because all transitive deps from JNI deps are checked in cc.checkLinkType()
382 ctx.VisitDirectDeps(func(m android.Module) {
383 if !IsJniDepTag(ctx.OtherModuleDependencyTag(m)) {
384 return
385 }
386 dep, _ := m.(*cc.Module)
Jooyung Han652d5b32020-05-20 17:12:13 +0900387 // The domain of cc.sdk_version is "current" and <number>
Jiyong Parkf1691d22021-03-29 20:11:58 +0900388 // We can rely on android.SdkSpec to convert it to <number> so that "current" is
389 // handled properly regardless of sdk finalization.
Spandan Das2e8c0442022-05-08 00:39:35 +0000390 jniSdkVersion, err := android.SdkSpecFrom(ctx, dep.MinSdkVersion()).EffectiveVersion(ctx)
Jiyong Park54105c42021-03-31 18:17:53 +0900391 if err != nil || minSdkVersion.LessThan(jniSdkVersion) {
Spandan Das2e8c0442022-05-08 00:39:35 +0000392 ctx.OtherModuleErrorf(dep, "min_sdk_version(%v) is higher than min_sdk_version(%v) of the containing android_app(%v)",
393 dep.MinSdkVersion(), minSdkVersion, ctx.ModuleName())
Jooyung Hanbbc3fb72020-04-29 14:01:06 +0900394 return
395 }
396
397 })
398}
399
Sasha Smundak6ad77252019-05-01 13:16:22 -0700400// Returns true if the native libraries should be stored in the APK uncompressed and the
Colin Crosse4246ab2019-02-05 21:55:21 -0800401// extractNativeLibs application flag should be set to false in the manifest.
Sasha Smundak6ad77252019-05-01 13:16:22 -0700402func (a *AndroidApp) useEmbeddedNativeLibs(ctx android.ModuleContext) bool {
Jiyong Park92315372021-04-02 08:45:46 +0900403 minSdkVersion, err := a.MinSdkVersion(ctx).EffectiveVersion(ctx)
Colin Crosse4246ab2019-02-05 21:55:21 -0800404 if err != nil {
Jiyong Park92315372021-04-02 08:45:46 +0900405 ctx.PropertyErrorf("min_sdk_version", "invalid value %q: %s", a.MinSdkVersion(ctx), err)
Colin Crosse4246ab2019-02-05 21:55:21 -0800406 }
407
Colin Cross56a83212020-09-15 18:30:11 -0700408 apexInfo := ctx.Provider(android.ApexInfoProvider).(android.ApexInfo)
Jiyong Park54105c42021-03-31 18:17:53 +0900409 return (minSdkVersion.FinalOrFutureInt() >= 23 && Bool(a.appProperties.Use_embedded_native_libs)) ||
Colin Cross56a83212020-09-15 18:30:11 -0700410 !apexInfo.IsForPlatform()
Colin Crosse4246ab2019-02-05 21:55:21 -0800411}
412
Colin Cross43f08db2018-11-12 10:13:39 -0800413// Returns whether this module should have the dex file stored uncompressed in the APK.
414func (a *AndroidApp) shouldUncompressDex(ctx android.ModuleContext) bool {
Colin Cross46abdad2019-02-07 13:07:08 -0800415 if Bool(a.appProperties.Use_embedded_dex) {
416 return true
417 }
418
Colin Cross53a87f52019-06-25 13:35:30 -0700419 // Uncompress dex in APKs of privileged apps (even for unbundled builds, they may
420 // be preinstalled as prebuilts).
Jiyong Parkf7487312019-10-17 12:54:30 +0900421 if ctx.Config().UncompressPrivAppDex() && a.Privileged() {
Nicolas Geoffrayfa6e9ec2019-02-12 13:12:16 +0000422 return true
423 }
424
Colin Cross53a87f52019-06-25 13:35:30 -0700425 if ctx.Config().UnbundledBuild() {
426 return false
427 }
428
Jaewoong Jungacf18d72019-05-02 14:55:29 -0700429 return shouldUncompressDex(ctx, &a.dexpreopter)
Colin Cross5a0dcd52018-10-05 14:20:06 -0700430}
431
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700432func (a *AndroidApp) shouldEmbedJnis(ctx android.BaseModuleContext) bool {
Colin Cross56a83212020-09-15 18:30:11 -0700433 apexInfo := ctx.Provider(android.ApexInfoProvider).(android.ApexInfo)
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700434 return ctx.Config().UnbundledBuild() || Bool(a.appProperties.Use_embedded_native_libs) ||
Colin Cross56a83212020-09-15 18:30:11 -0700435 !apexInfo.IsForPlatform() || a.appProperties.AlwaysPackageNativeLibs
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700436}
437
Liz Kammer9f9fd022020-06-18 19:44:06 +0000438func generateAaptRenamePackageFlags(packageName string, renameResourcesPackage bool) []string {
439 aaptFlags := []string{"--rename-manifest-package " + packageName}
440 if renameResourcesPackage {
441 // Required to rename the package name in the resources table.
442 aaptFlags = append(aaptFlags, "--rename-resources-package "+packageName)
443 }
444 return aaptFlags
445}
446
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900447func (a *AndroidApp) OverriddenManifestPackageName() string {
448 return a.overriddenManifestPackageName
449}
450
Liz Kammer9f9fd022020-06-18 19:44:06 +0000451func (a *AndroidApp) renameResourcesPackage() bool {
452 return proptools.BoolDefault(a.overridableAppProperties.Rename_resources_package, true)
453}
454
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800455func (a *AndroidApp) aaptBuildActions(ctx android.ModuleContext) {
Lorenzo Colittifa9b3f32021-03-30 10:38:26 +0900456 usePlatformAPI := proptools.Bool(a.Module.deviceProperties.Platform_apis)
Jiyong Park92315372021-04-02 08:45:46 +0900457 if ctx.Module().(android.SdkContext).SdkVersion(ctx).Kind == android.SdkModule {
Lorenzo Colittifa9b3f32021-03-30 10:38:26 +0900458 usePlatformAPI = true
459 }
460 a.aapt.usesNonSdkApis = usePlatformAPI
David Brazdild25060a2019-02-18 18:24:16 +0000461
Jaewoong Jungc27ab662019-05-30 15:51:14 -0700462 // Ask manifest_fixer to add or update the application element indicating this app has no code.
463 a.aapt.hasNoCode = !a.hasCode(ctx)
464
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800465 aaptLinkFlags := []string{}
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800466
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800467 // Add TARGET_AAPT_CHARACTERISTICS values to AAPT link flags if they exist and --product flags were not provided.
Inseob Kim34dc4cd2023-11-07 13:37:14 +0900468 autogenerateRRO := proptools.Bool(a.appProperties.Generate_product_characteristics_rro)
Jaewoong Jung3aff5782020-02-11 07:54:35 -0800469 hasProduct := android.PrefixInList(a.aaptProperties.Aaptflags, "--product")
Inseob Kim34dc4cd2023-11-07 13:37:14 +0900470 if !autogenerateRRO && !hasProduct && len(ctx.Config().ProductAAPTCharacteristics()) > 0 {
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800471 aaptLinkFlags = append(aaptLinkFlags, "--product", ctx.Config().ProductAAPTCharacteristics())
Colin Crosse78dcd32018-04-19 15:25:19 -0700472 }
473
Dan Willemsen72be5902018-10-24 20:24:57 -0700474 if !Bool(a.aaptProperties.Aapt_include_all_resources) {
475 // Product AAPT config
476 for _, aaptConfig := range ctx.Config().ProductAAPTConfig() {
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800477 aaptLinkFlags = append(aaptLinkFlags, "-c", aaptConfig)
Dan Willemsen72be5902018-10-24 20:24:57 -0700478 }
Colin Crosse78dcd32018-04-19 15:25:19 -0700479
Dan Willemsen72be5902018-10-24 20:24:57 -0700480 // Product AAPT preferred config
481 if len(ctx.Config().ProductAAPTPreferredConfig()) > 0 {
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800482 aaptLinkFlags = append(aaptLinkFlags, "--preferred-density", ctx.Config().ProductAAPTPreferredConfig())
Dan Willemsen72be5902018-10-24 20:24:57 -0700483 }
Colin Crosse78dcd32018-04-19 15:25:19 -0700484 }
485
Jiyong Park7f67f482019-01-05 12:57:48 +0900486 manifestPackageName, overridden := ctx.DeviceConfig().OverrideManifestPackageNameFor(ctx.ModuleName())
Jaewoong Jung6f373f62019-03-13 10:13:24 -0700487 if overridden || a.overridableAppProperties.Package_name != nil {
488 // The product override variable has a priority over the package_name property.
489 if !overridden {
490 manifestPackageName = *a.overridableAppProperties.Package_name
491 }
Liz Kammer9f9fd022020-06-18 19:44:06 +0000492 aaptLinkFlags = append(aaptLinkFlags, generateAaptRenamePackageFlags(manifestPackageName, a.renameResourcesPackage())...)
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900493 a.overriddenManifestPackageName = manifestPackageName
Jiyong Park7f67f482019-01-05 12:57:48 +0900494 }
495
Jaewoong Jung4102e5d2019-02-27 16:26:28 -0800496 aaptLinkFlags = append(aaptLinkFlags, a.additionalAaptFlags...)
497
Colin Crosse560c4a2019-03-19 16:03:11 -0700498 a.aapt.splitNames = a.appProperties.Package_splits
Baligh Uddin5b16dfb2020-02-11 17:27:19 -0800499 a.aapt.LoggingParent = String(a.overridableAppProperties.Logging_parent)
Alexei Nicoara69cf0f32022-07-27 14:59:18 +0100500 if a.Updatable() {
501 a.aapt.defaultManifestVersion = android.DefaultUpdatableModuleVersion
502 }
Alixf7a10272023-09-27 16:47:56 +0000503 a.aapt.buildActions(ctx,
504 aaptBuildActionOptions{
505 android.SdkContext(a),
506 a.classLoaderContexts,
507 a.usesLibraryProperties.Exclude_uses_libs,
508 a.enforceDefaultTargetSdkVersion(),
509 aaptLinkFlags,
510 },
511 )
Colin Cross30e076a2015-04-13 13:58:27 -0700512
Colin Cross46c9b8b2017-06-22 16:51:17 -0700513 // apps manifests are handled by aapt, don't let Module see them
Dan Willemsen34cc69e2015-09-23 15:26:20 -0700514 a.properties.Manifest = nil
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800515}
Colin Cross30e076a2015-04-13 13:58:27 -0700516
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800517func (a *AndroidApp) proguardBuildActions(ctx android.ModuleContext) {
Colin Cross89c31582018-04-30 15:55:11 -0700518 var staticLibProguardFlagFiles android.Paths
519 ctx.VisitDirectDeps(func(m android.Module) {
Sam Delmerico95d70942023-08-02 18:00:35 -0400520 depProguardInfo := ctx.OtherModuleProvider(m, ProguardSpecInfoProvider).(ProguardSpecInfo)
521 staticLibProguardFlagFiles = append(staticLibProguardFlagFiles, depProguardInfo.UnconditionallyExportedProguardFlags.ToList()...)
522 if ctx.OtherModuleDependencyTag(m) == staticLibTag {
523 staticLibProguardFlagFiles = append(staticLibProguardFlagFiles, depProguardInfo.ProguardFlagsFiles.ToList()...)
Colin Cross89c31582018-04-30 15:55:11 -0700524 }
525 })
526
527 staticLibProguardFlagFiles = android.FirstUniquePaths(staticLibProguardFlagFiles)
528
Colin Cross312634e2023-11-21 15:13:56 -0800529 a.Module.extraProguardFlagsFiles = append(a.Module.extraProguardFlagsFiles, staticLibProguardFlagFiles...)
530 a.Module.extraProguardFlagsFiles = append(a.Module.extraProguardFlagsFiles, a.proguardOptionsFile)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800531}
Colin Cross66dbc0b2017-12-28 12:23:20 -0800532
Colin Cross403cc152020-07-06 14:15:24 -0700533func (a *AndroidApp) installPath(ctx android.ModuleContext) android.InstallPath {
Colin Cross43f08db2018-11-12 10:13:39 -0800534 var installDir string
535 if ctx.ModuleName() == "framework-res" {
536 // framework-res.apk is installed as system/framework/framework-res.apk
537 installDir = "framework"
Jiyong Parkf7487312019-10-17 12:54:30 +0900538 } else if a.Privileged() {
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800539 installDir = filepath.Join("priv-app", a.installApkName)
Colin Cross43f08db2018-11-12 10:13:39 -0800540 } else {
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800541 installDir = filepath.Join("app", a.installApkName)
Colin Cross43f08db2018-11-12 10:13:39 -0800542 }
Colin Cross403cc152020-07-06 14:15:24 -0700543
544 return android.PathForModuleInstall(ctx, installDir, a.installApkName+".apk")
545}
546
Rico Wind98e7fa82023-11-27 09:44:03 +0100547func (a *AndroidApp) dexBuildActions(ctx android.ModuleContext) (android.Path, android.Path) {
Colin Cross403cc152020-07-06 14:15:24 -0700548 a.dexpreopter.installPath = a.installPath(ctx)
Ulya Trafimovich76b08522021-01-14 17:52:43 +0000549 a.dexpreopter.isApp = true
Liz Kammera7a64f32020-07-09 15:16:41 -0700550 if a.dexProperties.Uncompress_dex == nil {
David Srbeckye033cba2020-05-20 22:20:28 +0100551 // If the value was not force-set by the user, use reasonable default based on the module.
Liz Kammera7a64f32020-07-09 15:16:41 -0700552 a.dexProperties.Uncompress_dex = proptools.BoolPtr(a.shouldUncompressDex(ctx))
David Srbeckye033cba2020-05-20 22:20:28 +0100553 }
Liz Kammera7a64f32020-07-09 15:16:41 -0700554 a.dexpreopter.uncompressedDex = *a.dexProperties.Uncompress_dex
Colin Cross50ddcc42019-05-16 12:28:22 -0700555 a.dexpreopter.enforceUsesLibs = a.usesLibrary.enforceUsesLibraries()
Ulya Trafimovichb23d28c2020-10-08 12:53:58 +0100556 a.dexpreopter.classLoaderContexts = a.classLoaderContexts
Colin Cross50ddcc42019-05-16 12:28:22 -0700557 a.dexpreopter.manifestFile = a.mergedManifestFile
Colin Crossfa9bfcd2021-11-10 16:42:38 -0800558 a.dexpreopter.preventInstall = a.appProperties.PreventInstall
Colin Cross50ddcc42019-05-16 12:28:22 -0700559
Rico Wind98e7fa82023-11-27 09:44:03 +0100560 var packageResources = a.exportPackage
561
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800562 if ctx.ModuleName() != "framework-res" {
Rico Wind98e7fa82023-11-27 09:44:03 +0100563 if Bool(a.dexProperties.Optimize.Shrink_resources) {
564 protoFile := android.PathForModuleOut(ctx, packageResources.Base()+".proto.apk")
565 aapt2Convert(ctx, protoFile, packageResources, "proto")
566 a.dexer.resourcesInput = android.OptionalPathForPath(protoFile)
567 }
568
Colin Cross4eae06d2023-06-20 22:40:02 -0700569 var extraSrcJars android.Paths
570 var extraClasspathJars android.Paths
571 var extraCombinedJars android.Paths
572 if a.useResourceProcessorBusyBox() {
573 // When building an app with ResourceProcessorBusyBox enabled ResourceProcessorBusyBox has already
574 // created R.class files that provide IDs for resources in busybox/R.jar. Pass that file in the
575 // classpath when compiling everything else, and add it to the final classes jar.
576 extraClasspathJars = android.Paths{a.aapt.rJar}
577 extraCombinedJars = android.Paths{a.aapt.rJar}
578 } else {
579 // When building an app without ResourceProcessorBusyBox the aapt2 rule creates R.srcjar containing
580 // R.java files for the app's package and the packages from all transitive static android_library
581 // dependencies. Compile the srcjar alongside the rest of the sources.
582 extraSrcJars = android.Paths{a.aapt.aaptSrcJar}
583 }
584
585 a.Module.compile(ctx, extraSrcJars, extraClasspathJars, extraCombinedJars)
Rico Wind98e7fa82023-11-27 09:44:03 +0100586 if Bool(a.dexProperties.Optimize.Shrink_resources) {
587 binaryResources := android.PathForModuleOut(ctx, packageResources.Base()+".binary.out.apk")
588 aapt2Convert(ctx, binaryResources, a.dexer.resourcesOutput.Path(), "binary")
589 packageResources = binaryResources
590 }
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800591 }
Colin Cross30e076a2015-04-13 13:58:27 -0700592
Rico Wind98e7fa82023-11-27 09:44:03 +0100593 return a.dexJarFile.PathOrNil(), packageResources
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800594}
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800595
Sam Delmerico82602492022-06-10 17:05:42 +0000596func (a *AndroidApp) jniBuildActions(jniLibs []jniLib, prebuiltJniPackages android.Paths, ctx android.ModuleContext) android.WritablePath {
Colin Crossa4f08812018-10-02 22:03:40 -0700597 var jniJarFile android.WritablePath
Sam Delmerico82602492022-06-10 17:05:42 +0000598 if len(jniLibs) > 0 || len(prebuiltJniPackages) > 0 {
Colin Cross403cc152020-07-06 14:15:24 -0700599 a.jniLibs = jniLibs
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700600 if a.shouldEmbedJnis(ctx) {
Colin Crossa4f08812018-10-02 22:03:40 -0700601 jniJarFile = android.PathForModuleOut(ctx, "jnilibs.zip")
Colin Crossc68db4b2021-11-11 18:59:15 -0800602 a.installPathForJNISymbols = a.installPath(ctx)
Sam Delmerico82602492022-06-10 17:05:42 +0000603 TransformJniLibsToJar(ctx, jniJarFile, jniLibs, prebuiltJniPackages, a.useEmbeddedNativeLibs(ctx))
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700604 for _, jni := range jniLibs {
605 if jni.coverageFile.Valid() {
Jaewoong Jung46984ee2020-04-07 13:07:55 -0700606 // Only collect coverage for the first target arch if this is a multilib target.
607 // TODO(jungjw): Ideally, we want to collect both reports, but that would cause coverage
608 // data file path collisions since the current coverage file path format doesn't contain
609 // arch-related strings. This is fine for now though; the code coverage team doesn't use
610 // multi-arch targets such as test_suite_* for coverage collections yet.
611 //
612 // Work with the team to come up with a new format that handles multilib modules properly
613 // and change this.
614 if len(ctx.Config().Targets[android.Android]) == 1 ||
Jaewoong Jung642916f2020-10-09 17:25:15 -0700615 ctx.Config().AndroidFirstDeviceTarget.Arch.ArchType == jni.target.Arch.ArchType {
Jaewoong Jung46984ee2020-04-07 13:07:55 -0700616 a.jniCoverageOutputs = append(a.jniCoverageOutputs, jni.coverageFile.Path())
617 }
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700618 }
619 }
Colin Cross403cc152020-07-06 14:15:24 -0700620 a.embeddedJniLibs = true
Colin Crossa4f08812018-10-02 22:03:40 -0700621 }
622 }
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800623 return jniJarFile
624}
Colin Crossa4f08812018-10-02 22:03:40 -0700625
Colin Cross403cc152020-07-06 14:15:24 -0700626func (a *AndroidApp) JNISymbolsInstalls(installPath string) android.RuleBuilderInstalls {
627 var jniSymbols android.RuleBuilderInstalls
628 for _, jniLib := range a.jniLibs {
629 if jniLib.unstrippedFile != nil {
630 jniSymbols = append(jniSymbols, android.RuleBuilderInstall{
631 From: jniLib.unstrippedFile,
632 To: filepath.Join(installPath, targetToJniDir(jniLib.target), jniLib.unstrippedFile.Base()),
633 })
634 }
635 }
636 return jniSymbols
637}
638
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700639// Reads and prepends a main cert from the default cert dir if it hasn't been set already, i.e. it
640// isn't a cert module reference. Also checks and enforces system cert restriction if applicable.
Colin Crossbc2c8a72022-09-14 12:45:42 -0700641func processMainCert(m android.ModuleBase, certPropValue string, certificates []Certificate,
642 ctx android.ModuleContext) (mainCertificate Certificate, allCertificates []Certificate) {
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700643 if android.SrcIsModule(certPropValue) == "" {
644 var mainCert Certificate
645 if certPropValue != "" {
646 defaultDir := ctx.Config().DefaultAppCertificateDir(ctx)
647 mainCert = Certificate{
Colin Cross503c1d02020-01-28 14:00:53 -0800648 Pem: defaultDir.Join(ctx, certPropValue+".x509.pem"),
649 Key: defaultDir.Join(ctx, certPropValue+".pk8"),
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700650 }
651 } else {
652 pem, key := ctx.Config().DefaultAppCertificate(ctx)
Colin Cross503c1d02020-01-28 14:00:53 -0800653 mainCert = Certificate{
654 Pem: pem,
655 Key: key,
656 }
Colin Crossbd01e2a2018-10-04 15:21:03 -0700657 }
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700658 certificates = append([]Certificate{mainCert}, certificates...)
Colin Crossbd01e2a2018-10-04 15:21:03 -0700659 }
660
Colin Crossbc2c8a72022-09-14 12:45:42 -0700661 if len(certificates) > 0 {
662 mainCertificate = certificates[0]
663 } else {
664 // This can be reached with an empty certificate list if AllowMissingDependencies is set
665 // and the certificate property for this module is a module reference to a missing module.
666 if !ctx.Config().AllowMissingDependencies() && len(ctx.GetMissingDependencies()) > 0 {
667 panic("Should only get here if AllowMissingDependencies set and there are missing dependencies")
668 }
669 // Set a certificate to avoid panics later when accessing it.
670 mainCertificate = Certificate{
671 Key: android.PathForModuleOut(ctx, "missing.pk8"),
Colin Crossa54f4b52022-11-21 04:35:53 +0000672 Pem: android.PathForModuleOut(ctx, "missing.x509.pem"),
Colin Crossbc2c8a72022-09-14 12:45:42 -0700673 }
674 }
675
Zyan Wub7550aa2023-05-18 15:46:31 +0800676 if !m.Platform() {
677 certPath := mainCertificate.Pem.String()
678 systemCertPath := ctx.Config().DefaultAppCertificateDir(ctx).String()
679 if strings.HasPrefix(certPath, systemCertPath) {
680 enforceSystemCert := ctx.Config().EnforceSystemCertificate()
681 allowed := ctx.Config().EnforceSystemCertificateAllowList()
682
683 if enforceSystemCert && !inList(m.Name(), allowed) {
684 ctx.PropertyErrorf("certificate", "The module in product partition cannot be signed with certificate in system.")
685 }
686 }
687 }
688
Colin Crossbc2c8a72022-09-14 12:45:42 -0700689 return mainCertificate, certificates
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800690}
691
Jooyung Han39ee1192020-03-23 20:21:11 +0900692func (a *AndroidApp) InstallApkName() string {
693 return a.installApkName
694}
695
Sam Delmerico15809f82023-05-15 17:21:47 -0400696func (a *AndroidApp) createPrivappAllowlist(ctx android.ModuleContext) android.Path {
Andrei Onea580636b2022-08-17 16:53:46 +0000697 if a.appProperties.Privapp_allowlist == nil {
698 return nil
699 }
Sam Delmerico15809f82023-05-15 17:21:47 -0400700
701 isOverrideApp := a.GetOverriddenBy() != ""
702 if !isOverrideApp {
703 // if this is not an override, we don't need to rewrite the existing privapp allowlist
704 return android.PathForModuleSrc(ctx, *a.appProperties.Privapp_allowlist)
705 }
706
Andrei Onea580636b2022-08-17 16:53:46 +0000707 if a.overridableAppProperties.Package_name == nil {
708 ctx.PropertyErrorf("privapp_allowlist", "package_name must be set to use privapp_allowlist")
709 }
Sam Delmerico15809f82023-05-15 17:21:47 -0400710
Andrei Onea580636b2022-08-17 16:53:46 +0000711 packageName := *a.overridableAppProperties.Package_name
712 fileName := "privapp_allowlist_" + packageName + ".xml"
713 outPath := android.PathForModuleOut(ctx, fileName).OutputPath
714 ctx.Build(pctx, android.BuildParams{
715 Rule: modifyAllowlist,
716 Input: android.PathForModuleSrc(ctx, *a.appProperties.Privapp_allowlist),
717 Output: outPath,
718 Args: map[string]string{
719 "packageName": packageName,
720 },
721 })
722 return &outPath
723}
724
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800725func (a *AndroidApp) generateAndroidBuildActions(ctx android.ModuleContext) {
Colin Cross50ddcc42019-05-16 12:28:22 -0700726 var apkDeps android.Paths
727
Colin Cross56a83212020-09-15 18:30:11 -0700728 if !ctx.Provider(android.ApexInfoProvider).(android.ApexInfo).IsForPlatform() {
729 a.hideApexVariantFromMake = true
730 }
731
Jeongik Cha538c0d02019-07-11 15:54:27 +0900732 a.aapt.useEmbeddedNativeLibs = a.useEmbeddedNativeLibs(ctx)
733 a.aapt.useEmbeddedDex = Bool(a.appProperties.Use_embedded_dex)
734
Jihoon Kang1bfb6f22023-07-01 00:13:47 +0000735 // Unlike installApkName, a.stem should respect base module name for override_android_app.
736 // Therefore, use ctx.ModuleName() instead of a.Name().
737 a.stem = proptools.StringDefault(a.overridableDeviceProperties.Stem, ctx.ModuleName())
738
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800739 // Check if the install APK name needs to be overridden.
Jihoon Kang1bfb6f22023-07-01 00:13:47 +0000740 // Both android_app and override_android_app module are expected to possess
741 // its module bound apk path. However, override_android_app inherits ctx.ModuleName()
742 // from the base module. Therefore, use a.Name() which represents
743 // the module name for both android_app and override_android_app.
744 a.installApkName = ctx.DeviceConfig().OverridePackageNameFor(
745 proptools.StringDefault(a.overridableDeviceProperties.Stem, a.Name()))
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800746
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700747 if ctx.ModuleName() == "framework-res" {
748 // framework-res.apk is installed as system/framework/framework-res.apk
Jaewoong Jung0949f312019-09-11 10:25:18 -0700749 a.installDir = android.PathForModuleInstall(ctx, "framework")
Jiyong Parkf7487312019-10-17 12:54:30 +0900750 } else if a.Privileged() {
Jaewoong Jung0949f312019-09-11 10:25:18 -0700751 a.installDir = android.PathForModuleInstall(ctx, "priv-app", a.installApkName)
752 } else if ctx.InstallInTestcases() {
Jaewoong Jung326a9412019-11-21 10:41:00 -0800753 a.installDir = android.PathForModuleInstall(ctx, a.installApkName, ctx.DeviceConfig().DeviceArch())
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700754 } else {
Jaewoong Jung0949f312019-09-11 10:25:18 -0700755 a.installDir = android.PathForModuleInstall(ctx, "app", a.installApkName)
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700756 }
Jaewoong Jung7dd4ae22019-09-27 17:13:15 -0700757 a.onDeviceDir = android.InstallPathToOnDevicePath(ctx, a.installDir)
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700758
Ulya Trafimovichb23d28c2020-10-08 12:53:58 +0100759 a.classLoaderContexts = a.usesLibrary.classLoaderContextForUsesLibDeps(ctx)
Ulya Trafimovich18554242020-11-03 15:55:11 +0000760
Colin Cross61fb62e2022-06-23 10:46:28 -0700761 var noticeAssetPath android.WritablePath
762 if Bool(a.appProperties.Embed_notices) || ctx.Config().IsEnvTrue("ALWAYS_EMBED_NOTICES") {
763 // The rule to create the notice file can't be generated yet, as the final output path
764 // for the apk isn't known yet. Add the path where the notice file will be generated to the
765 // aapt rules now before calling aaptBuildActions, the rule to create the notice file will
766 // be generated later.
767 noticeAssetPath = android.PathForModuleOut(ctx, "NOTICE", "NOTICE.html.gz")
768 a.aapt.noticeFile = android.OptionalPathForPath(noticeAssetPath)
769 }
770
Harshit Mahajan8f202ad2023-01-09 20:45:55 +0000771 // For apps targeting latest target_sdk_version
772 if Bool(a.appProperties.Enforce_default_target_sdk_version) {
773 a.SetEnforceDefaultTargetSdkVersion(true)
774 }
775
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800776 // Process all building blocks, from AAPT to certificates.
777 a.aaptBuildActions(ctx)
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +0100778 // The decision to enforce <uses-library> checks is made before adding implicit SDK libraries.
779 a.usesLibrary.freezeEnforceUsesLibraries()
780
781 // Add implicit SDK libraries to <uses-library> list.
Ulya Trafimovichfc0f6e32021-08-12 16:16:11 +0100782 requiredUsesLibs, optionalUsesLibs := a.classLoaderContexts.UsesLibs()
783 for _, usesLib := range requiredUsesLibs {
784 a.usesLibrary.addLib(usesLib, false)
785 }
786 for _, usesLib := range optionalUsesLibs {
787 a.usesLibrary.addLib(usesLib, true)
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +0100788 }
789
790 // Check that the <uses-library> list is coherent with the manifest.
Colin Cross50ddcc42019-05-16 12:28:22 -0700791 if a.usesLibrary.enforceUsesLibraries() {
792 manifestCheckFile := a.usesLibrary.verifyUsesLibrariesManifest(ctx, a.mergedManifestFile)
793 apkDeps = append(apkDeps, manifestCheckFile)
794 }
795
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800796 a.proguardBuildActions(ctx)
797
Colin Cross014489c2020-06-02 20:09:13 -0700798 a.linter.mergedManifest = a.aapt.mergedManifestFile
799 a.linter.manifest = a.aapt.manifestPath
800 a.linter.resources = a.aapt.resourceFiles
Colin Crossc0efd1d2020-07-03 11:56:24 -0700801 a.linter.buildModuleReportZip = ctx.Config().UnbundledBuildApps()
Colin Cross014489c2020-06-02 20:09:13 -0700802
Rico Wind98e7fa82023-11-27 09:44:03 +0100803 dexJarFile, packageResources := a.dexBuildActions(ctx)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800804
Colin Crossbc2c8a72022-09-14 12:45:42 -0700805 jniLibs, prebuiltJniPackages, certificates := collectAppDeps(ctx, a, a.shouldEmbedJnis(ctx), !Bool(a.appProperties.Jni_uses_platform_apis))
Sam Delmerico82602492022-06-10 17:05:42 +0000806 jniJarFile := a.jniBuildActions(jniLibs, prebuiltJniPackages, ctx)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800807
808 if ctx.Failed() {
809 return
810 }
811
Colin Crossbc2c8a72022-09-14 12:45:42 -0700812 a.certificate, certificates = processMainCert(a.ModuleBase, a.getCertString(ctx), certificates, ctx)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800813
814 // Build a final signed app package.
Jaewoong Jung5a498812019-11-07 14:14:38 -0800815 packageFile := android.PathForModuleOut(ctx, a.installApkName+".apk")
Songchun Fan17d69e32020-03-24 20:32:24 -0700816 v4SigningRequested := Bool(a.Module.deviceProperties.V4_signature)
817 var v4SignatureFile android.WritablePath = nil
818 if v4SigningRequested {
819 v4SignatureFile = android.PathForModuleOut(ctx, a.installApkName+".apk.idsig")
820 }
Liz Kammere2b27f42020-05-07 13:24:05 -0700821 var lineageFile android.Path
822 if lineage := String(a.overridableAppProperties.Lineage); lineage != "" {
823 lineageFile = android.PathForModuleSrc(ctx, lineage)
824 }
Rupert Shuttleworth8eab8692021-11-03 10:39:39 -0400825 rotationMinSdkVersion := String(a.overridableAppProperties.RotationMinSdkVersion)
826
Rico Wind98e7fa82023-11-27 09:44:03 +0100827 CreateAndSignAppPackage(ctx, packageFile, packageResources, jniJarFile, dexJarFile, certificates, apkDeps, v4SignatureFile, lineageFile, rotationMinSdkVersion)
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800828 a.outputFile = packageFile
Songchun Fan17d69e32020-03-24 20:32:24 -0700829 if v4SigningRequested {
830 a.extraOutputFiles = append(a.extraOutputFiles, v4SignatureFile)
831 }
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800832
Colin Cross61fb62e2022-06-23 10:46:28 -0700833 if a.aapt.noticeFile.Valid() {
834 // Generating the notice file rule has to be here after a.outputFile is known.
Bob Badoureef4c1c2022-05-16 12:20:04 -0700835 noticeFile := android.PathForModuleOut(ctx, "NOTICE.html.gz")
Bob Badourc6ec9fb2022-06-08 15:59:35 -0700836 android.BuildNoticeHtmlOutputFromLicenseMetadata(
837 ctx, noticeFile, "", "",
838 []string{
839 a.installDir.String() + "/",
840 android.PathForModuleInstall(ctx).String() + "/",
841 a.outputFile.String(),
842 })
Bob Badoureef4c1c2022-05-16 12:20:04 -0700843 builder := android.NewRuleBuilder(pctx, ctx)
844 builder.Command().Text("cp").
845 Input(noticeFile).
846 Output(noticeAssetPath)
847 builder.Build("notice_dir", "Building notice dir")
Bob Badoureef4c1c2022-05-16 12:20:04 -0700848 }
849
Colin Crosse560c4a2019-03-19 16:03:11 -0700850 for _, split := range a.aapt.splits {
851 // Sign the split APKs
Jaewoong Jung5a498812019-11-07 14:14:38 -0800852 packageFile := android.PathForModuleOut(ctx, a.installApkName+"_"+split.suffix+".apk")
Songchun Fan17d69e32020-03-24 20:32:24 -0700853 if v4SigningRequested {
854 v4SignatureFile = android.PathForModuleOut(ctx, a.installApkName+"_"+split.suffix+".apk.idsig")
855 }
Rico Wind98e7fa82023-11-27 09:44:03 +0100856 CreateAndSignAppPackage(ctx, packageFile, split.path, nil, nil, certificates, apkDeps, v4SignatureFile, lineageFile, rotationMinSdkVersion)
Colin Crosse560c4a2019-03-19 16:03:11 -0700857 a.extraOutputFiles = append(a.extraOutputFiles, packageFile)
Songchun Fan17d69e32020-03-24 20:32:24 -0700858 if v4SigningRequested {
859 a.extraOutputFiles = append(a.extraOutputFiles, v4SignatureFile)
860 }
Colin Crosse560c4a2019-03-19 16:03:11 -0700861 }
862
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800863 // Build an app bundle.
Colin Crossf6237212018-10-29 23:14:58 -0700864 bundleFile := android.PathForModuleOut(ctx, "base.zip")
865 BuildBundleModule(ctx, bundleFile, a.exportPackage, jniJarFile, dexJarFile)
866 a.bundleFile = bundleFile
867
Andrei Onea580636b2022-08-17 16:53:46 +0000868 allowlist := a.createPrivappAllowlist(ctx)
869 if allowlist != nil {
870 a.privAppAllowlist = android.OptionalPathForPath(allowlist)
871 }
872
Colin Cross56a83212020-09-15 18:30:11 -0700873 apexInfo := ctx.Provider(android.ApexInfoProvider).(android.ApexInfo)
874
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800875 // Install the app package.
Andrei Onea580636b2022-08-17 16:53:46 +0000876 shouldInstallAppPackage := (Bool(a.Module.properties.Installable) || ctx.Host()) && apexInfo.IsForPlatform() && !a.appProperties.PreventInstall
877 if shouldInstallAppPackage {
Sam Delmericob1daccd2023-05-25 14:45:30 -0400878 if a.privAppAllowlist.Valid() {
Anton Hansson0e486a42023-06-01 16:38:35 +0000879 allowlistInstallPath := android.PathForModuleInstall(ctx, "etc", "permissions")
880 allowlistInstallFilename := a.installApkName + ".xml"
881 ctx.InstallFile(allowlistInstallPath, allowlistInstallFilename, a.privAppAllowlist.Path())
Sam Delmericob1daccd2023-05-25 14:45:30 -0400882 }
883
Colin Cross09ad3a62023-11-15 12:29:33 -0800884 var extraInstalledPaths android.InstallPaths
Jiyong Park8ba50f92019-11-13 15:01:01 +0900885 for _, extra := range a.extraOutputFiles {
Colin Cross1d0eb7a2021-11-03 14:08:20 -0700886 installed := ctx.InstallFile(a.installDir, extra.Base(), extra)
887 extraInstalledPaths = append(extraInstalledPaths, installed)
Jiyong Park8ba50f92019-11-13 15:01:01 +0900888 }
Colin Cross1d0eb7a2021-11-03 14:08:20 -0700889 ctx.InstallFile(a.installDir, a.outputFile.Base(), a.outputFile, extraInstalledPaths...)
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800890 }
Artur Satayev1111b842020-04-27 19:05:28 +0100891
892 a.buildAppDependencyInfo(ctx)
Colin Cross30e076a2015-04-13 13:58:27 -0700893}
894
Colin Crossc2d24052020-05-13 11:05:02 -0700895type appDepsInterface interface {
Jiyong Park92315372021-04-02 08:45:46 +0900896 SdkVersion(ctx android.EarlyModuleContext) android.SdkSpec
Spandan Das8c9ae7e2023-03-03 21:20:36 +0000897 MinSdkVersion(ctx android.EarlyModuleContext) android.ApiLevel
Colin Crossc2d24052020-05-13 11:05:02 -0700898 RequiresStableAPIs(ctx android.BaseModuleContext) bool
899}
900
901func collectAppDeps(ctx android.ModuleContext, app appDepsInterface,
902 shouldCollectRecursiveNativeDeps bool,
Sam Delmerico82602492022-06-10 17:05:42 +0000903 checkNativeSdkVersion bool) ([]jniLib, android.Paths, []Certificate) {
Colin Crossc2d24052020-05-13 11:05:02 -0700904
Colin Crossa4f08812018-10-02 22:03:40 -0700905 var jniLibs []jniLib
Sam Delmerico82602492022-06-10 17:05:42 +0000906 var prebuiltJniPackages android.Paths
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900907 var certificates []Certificate
Peter Collingbournead84f972019-12-17 16:46:18 -0800908 seenModulePaths := make(map[string]bool)
Colin Crossa4f08812018-10-02 22:03:40 -0700909
Colin Crossc2d24052020-05-13 11:05:02 -0700910 if checkNativeSdkVersion {
Jiyong Park92315372021-04-02 08:45:46 +0900911 checkNativeSdkVersion = app.SdkVersion(ctx).Specified() &&
912 app.SdkVersion(ctx).Kind != android.SdkCorePlatform && !app.RequiresStableAPIs(ctx)
Colin Crossc2d24052020-05-13 11:05:02 -0700913 }
914
Peter Collingbournead84f972019-12-17 16:46:18 -0800915 ctx.WalkDeps(func(module android.Module, parent android.Module) bool {
Colin Crossa4f08812018-10-02 22:03:40 -0700916 otherName := ctx.OtherModuleName(module)
917 tag := ctx.OtherModuleDependencyTag(module)
918
Colin Crossf0913fb2020-07-29 12:59:39 -0700919 if IsJniDepTag(tag) || cc.IsSharedDepTag(tag) {
Ivan Lozano7f67c2a2022-06-27 16:00:26 -0400920 if dep, ok := module.(cc.LinkableInterface); ok {
Colin Cross95f1ca02020-10-29 20:47:22 -0700921 if dep.IsNdk(ctx.Config()) || dep.IsStubs() {
Peter Collingbournead84f972019-12-17 16:46:18 -0800922 return false
923 }
924
Colin Crossa4f08812018-10-02 22:03:40 -0700925 lib := dep.OutputFile()
926 if lib.Valid() {
Cole Faust64cb7c92021-09-14 17:32:49 -0700927 path := lib.Path()
928 if seenModulePaths[path.String()] {
929 return false
930 }
931 seenModulePaths[path.String()] = true
932
933 if checkNativeSdkVersion && dep.SdkVersion() == "" {
934 ctx.PropertyErrorf("jni_libs", "JNI dependency %q uses platform APIs, but this module does not",
935 otherName)
936 }
937
Colin Crossa4f08812018-10-02 22:03:40 -0700938 jniLibs = append(jniLibs, jniLib{
Colin Cross403cc152020-07-06 14:15:24 -0700939 name: ctx.OtherModuleName(module),
940 path: path,
941 target: module.Target(),
942 coverageFile: dep.CoverageOutputFile(),
943 unstrippedFile: dep.UnstrippedOutputFile(),
Jihoon Kangf78a8902022-09-01 22:47:07 +0000944 partition: dep.Partition(),
Colin Crossa4f08812018-10-02 22:03:40 -0700945 })
Colin Crossdd5261c2022-12-19 12:26:43 -0800946 } else if ctx.Config().AllowMissingDependencies() {
947 ctx.AddMissingDependencies([]string{otherName})
Colin Crossa4f08812018-10-02 22:03:40 -0700948 } else {
949 ctx.ModuleErrorf("dependency %q missing output file", otherName)
950 }
951 } else {
952 ctx.ModuleErrorf("jni_libs dependency %q must be a cc library", otherName)
Colin Crossa4f08812018-10-02 22:03:40 -0700953 }
Peter Collingbournead84f972019-12-17 16:46:18 -0800954
955 return shouldCollectRecursiveNativeDeps
956 }
957
Sam Delmerico82602492022-06-10 17:05:42 +0000958 if info, ok := ctx.OtherModuleProvider(module, JniPackageProvider).(JniPackageInfo); ok {
959 prebuiltJniPackages = append(prebuiltJniPackages, info.JniPackages...)
960 }
961
Peter Collingbournead84f972019-12-17 16:46:18 -0800962 if tag == certificateTag {
Colin Crossbd01e2a2018-10-04 15:21:03 -0700963 if dep, ok := module.(*AndroidAppCertificate); ok {
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900964 certificates = append(certificates, dep.Certificate)
Colin Crossbd01e2a2018-10-04 15:21:03 -0700965 } else {
966 ctx.ModuleErrorf("certificate dependency %q must be an android_app_certificate module", otherName)
967 }
Colin Crossa4f08812018-10-02 22:03:40 -0700968 }
Peter Collingbournead84f972019-12-17 16:46:18 -0800969
970 return false
Colin Crossa4f08812018-10-02 22:03:40 -0700971 })
972
Sam Delmerico82602492022-06-10 17:05:42 +0000973 return jniLibs, prebuiltJniPackages, certificates
Colin Crossa4f08812018-10-02 22:03:40 -0700974}
975
Jooyung Han749dc692020-04-15 11:03:39 +0900976func (a *AndroidApp) WalkPayloadDeps(ctx android.ModuleContext, do android.PayloadDepsCallback) {
Artur Satayev1111b842020-04-27 19:05:28 +0100977 ctx.WalkDeps(func(child, parent android.Module) bool {
978 isExternal := !a.DepIsInSameApex(ctx, child)
979 if am, ok := child.(android.ApexModule); ok {
Jooyung Han749dc692020-04-15 11:03:39 +0900980 if !do(ctx, parent, am, isExternal) {
981 return false
982 }
Artur Satayev1111b842020-04-27 19:05:28 +0100983 }
984 return !isExternal
985 })
986}
987
988func (a *AndroidApp) buildAppDependencyInfo(ctx android.ModuleContext) {
989 if ctx.Host() {
990 return
991 }
992
993 depsInfo := android.DepNameToDepInfoMap{}
Jooyung Han749dc692020-04-15 11:03:39 +0900994 a.WalkPayloadDeps(ctx, func(ctx android.ModuleContext, from blueprint.Module, to android.ApexModule, externalDep bool) bool {
Artur Satayev1111b842020-04-27 19:05:28 +0100995 depName := to.Name()
Artur Satayev533b98c2021-03-11 18:03:42 +0000996
997 // Skip dependencies that are only available to APEXes; they are developed with updatability
998 // in mind and don't need manual approval.
999 if to.(android.ApexModule).NotAvailableForPlatform() {
1000 return true
1001 }
1002
Artur Satayev1111b842020-04-27 19:05:28 +01001003 if info, exist := depsInfo[depName]; exist {
1004 info.From = append(info.From, from.Name())
1005 info.IsExternal = info.IsExternal && externalDep
1006 depsInfo[depName] = info
1007 } else {
1008 toMinSdkVersion := "(no version)"
Jiyong Park92315372021-04-02 08:45:46 +09001009 if m, ok := to.(interface {
Spandan Das8c9ae7e2023-03-03 21:20:36 +00001010 MinSdkVersion(ctx android.EarlyModuleContext) android.ApiLevel
Jiyong Park92315372021-04-02 08:45:46 +09001011 }); ok {
Spandan Das8c9ae7e2023-03-03 21:20:36 +00001012 if v := m.MinSdkVersion(ctx); !v.IsNone() {
1013 toMinSdkVersion = v.String()
Artur Satayev1111b842020-04-27 19:05:28 +01001014 }
Jiyong Park92315372021-04-02 08:45:46 +09001015 } else if m, ok := to.(interface{ MinSdkVersion() string }); ok {
1016 // TODO(b/175678607) eliminate the use of MinSdkVersion returning
1017 // string
1018 if v := m.MinSdkVersion(); v != "" {
Jiyong Parkf1691d22021-03-29 20:11:58 +09001019 toMinSdkVersion = v
1020 }
Artur Satayev1111b842020-04-27 19:05:28 +01001021 }
1022 depsInfo[depName] = android.ApexModuleDepInfo{
1023 To: depName,
1024 From: []string{from.Name()},
1025 IsExternal: externalDep,
1026 MinSdkVersion: toMinSdkVersion,
1027 }
1028 }
Jooyung Han749dc692020-04-15 11:03:39 +09001029 return true
Artur Satayev1111b842020-04-27 19:05:28 +01001030 })
1031
Jiyong Park92315372021-04-02 08:45:46 +09001032 a.ApexBundleDepsInfo.BuildDepsInfoLists(ctx, a.MinSdkVersion(ctx).String(), depsInfo)
Artur Satayev1111b842020-04-27 19:05:28 +01001033}
1034
Harshit Mahajan5b8b7302022-06-10 11:24:05 +00001035func (a *AndroidApp) enforceDefaultTargetSdkVersion() bool {
1036 return a.appProperties.EnforceDefaultTargetSdkVersion
1037}
1038
1039func (a *AndroidApp) SetEnforceDefaultTargetSdkVersion(val bool) {
1040 a.appProperties.EnforceDefaultTargetSdkVersion = val
1041}
1042
Artur Satayev849f8442020-04-28 14:57:42 +01001043func (a *AndroidApp) Updatable() bool {
Colin Cross56a83212020-09-15 18:30:11 -07001044 return Bool(a.appProperties.Updatable)
Artur Satayev849f8442020-04-28 14:57:42 +01001045}
1046
Spandan Das42e89502022-05-06 22:12:55 +00001047func (a *AndroidApp) SetUpdatable(val bool) {
1048 a.appProperties.Updatable = &val
1049}
1050
Colin Cross0ea8ba82019-06-06 14:33:29 -07001051func (a *AndroidApp) getCertString(ctx android.BaseModuleContext) string {
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001052 certificate, overridden := ctx.DeviceConfig().OverrideCertificateFor(ctx.ModuleName())
1053 if overridden {
Jaewoong Jungacb6db32019-02-28 16:22:30 +00001054 return ":" + certificate
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001055 }
Jaewoong Jung525443a2019-02-28 15:35:54 -08001056 return String(a.overridableAppProperties.Certificate)
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001057}
1058
Jiyong Park0f80c182020-01-31 02:49:53 +09001059func (a *AndroidApp) DepIsInSameApex(ctx android.BaseModuleContext, dep android.Module) bool {
1060 if IsJniDepTag(ctx.OtherModuleDependencyTag(dep)) {
1061 return true
1062 }
1063 return a.Library.DepIsInSameApex(ctx, dep)
1064}
1065
Jiyong Parkb7c639e2019-08-19 14:56:02 +09001066// For OutputFileProducer interface
1067func (a *AndroidApp) OutputFiles(tag string) (android.Paths, error) {
1068 switch tag {
Jared Duke34b080d2023-03-30 16:40:24 -07001069 // In some instances, it can be useful to reference the aapt-generated flags from another
1070 // target, e.g., system server implements services declared in the framework-res manifest.
1071 case ".aapt.proguardOptionsFile":
1072 return []android.Path{a.proguardOptionsFile}, nil
Jiyong Parkb7c639e2019-08-19 14:56:02 +09001073 case ".aapt.srcjar":
Colin Crossf3b7bad2023-08-02 15:49:00 -07001074 if a.aaptSrcJar != nil {
1075 return []android.Path{a.aaptSrcJar}, nil
1076 }
1077 case ".aapt.jar":
1078 if a.rJar != nil {
1079 return []android.Path{a.rJar}, nil
1080 }
Anton Hansson092aca42020-08-13 19:37:22 +01001081 case ".export-package.apk":
1082 return []android.Path{a.exportPackage}, nil
Inseob Kim34dc4cd2023-11-07 13:37:14 +09001083 case ".manifest.xml":
1084 return []android.Path{a.aapt.manifestPath}, nil
Jiyong Parkb7c639e2019-08-19 14:56:02 +09001085 }
1086 return a.Library.OutputFiles(tag)
1087}
1088
Jiyong Parkf7487312019-10-17 12:54:30 +09001089func (a *AndroidApp) Privileged() bool {
1090 return Bool(a.appProperties.Privileged)
1091}
1092
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001093func (a *AndroidApp) IsNativeCoverageNeeded(ctx android.BaseModuleContext) bool {
Colin Cross1a6acd42020-06-16 17:51:46 -07001094 return ctx.Device() && ctx.DeviceConfig().NativeCoverageEnabled()
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001095}
1096
Ivan Lozanod7586b62021-04-01 09:49:36 -04001097func (a *AndroidApp) SetPreventInstall() {
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001098 a.appProperties.PreventInstall = true
1099}
1100
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001101func (a *AndroidApp) MarkAsCoverageVariant(coverage bool) {
1102 a.appProperties.IsCoverageVariant = coverage
1103}
1104
Ivan Lozanoa0cd8f92020-04-09 09:56:02 -04001105func (a *AndroidApp) EnableCoverageIfNeeded() {}
1106
Jaewoong Jung87a33e72020-03-26 14:01:48 -07001107var _ cc.Coverage = (*AndroidApp)(nil)
1108
Colin Cross95b53b82023-10-17 13:21:02 -07001109func (a *AndroidApp) IDEInfo(dpInfo *android.IdeInfo) {
1110 a.Library.IDEInfo(dpInfo)
1111 a.aapt.IDEInfo(dpInfo)
1112}
1113
Inseob Kim34dc4cd2023-11-07 13:37:14 +09001114func (a *AndroidApp) productCharacteristicsRROPackageName() string {
1115 return proptools.String(a.appProperties.ProductCharacteristicsRROPackageName)
1116}
1117
1118func (a *AndroidApp) productCharacteristicsRROManifestModuleName() string {
1119 return proptools.String(a.appProperties.ProductCharacteristicsRROManifestModuleName)
1120}
1121
Colin Cross1b16b0e2019-02-12 14:41:32 -08001122// android_app compiles sources and Android resources into an Android application package `.apk` file.
Colin Cross36242852017-06-23 15:06:31 -07001123func AndroidAppFactory() android.Module {
Colin Cross30e076a2015-04-13 13:58:27 -07001124 module := &AndroidApp{}
1125
Liz Kammera7a64f32020-07-09 15:16:41 -07001126 module.Module.dexProperties.Optimize.EnabledByDefault = true
1127 module.Module.dexProperties.Optimize.Shrink = proptools.BoolPtr(true)
Jared Dukeaa88b3d2023-08-29 17:07:20 +00001128 module.Module.dexProperties.Optimize.Proguard_compatibility = proptools.BoolPtr(false)
Colin Cross66dbc0b2017-12-28 12:23:20 -08001129
Colin Crossae5caf52018-05-22 11:11:52 -07001130 module.Module.properties.Instrument = true
Paul Duffin0038a8d2022-05-03 00:28:40 +00001131 module.Module.properties.Supports_static_instrumentation = true
Colin Cross9ae1b922018-06-26 17:59:05 -07001132 module.Module.properties.Installable = proptools.BoolPtr(true)
Colin Crossae5caf52018-05-22 11:11:52 -07001133
Colin Crossce6734e2020-06-15 16:09:53 -07001134 module.addHostAndDeviceProperties()
Colin Cross36242852017-06-23 15:06:31 -07001135 module.AddProperties(
Colin Crossa97c5d32018-03-28 14:58:31 -07001136 &module.aaptProperties,
Jaewoong Jung525443a2019-02-28 15:35:54 -08001137 &module.appProperties,
Ulya Trafimovich21a73752020-09-01 17:33:48 +01001138 &module.overridableAppProperties)
Colin Cross36242852017-06-23 15:06:31 -07001139
Ulya Trafimovich22890c42021-01-05 12:04:17 +00001140 module.usesLibrary.enforce = true
1141
Colin Crossa4f08812018-10-02 22:03:40 -07001142 android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
1143 android.InitDefaultableModule(module)
zhidou198f5892022-02-17 02:33:12 +00001144 android.InitOverridableModule(module, &module.overridableAppProperties.Overrides)
Jiyong Park52cd06f2019-11-11 10:14:32 +09001145 android.InitApexModule(module)
Liz Kammerbe46fcc2021-11-01 15:32:43 -04001146 android.InitBazelModule(module)
Colin Crossa4f08812018-10-02 22:03:40 -07001147
Inseob Kim34dc4cd2023-11-07 13:37:14 +09001148 android.AddLoadHook(module, func(ctx android.LoadHookContext) {
1149 a := ctx.Module().(*AndroidApp)
1150
1151 characteristics := ctx.Config().ProductAAPTCharacteristics()
1152 if characteristics == "default" || characteristics == "" {
1153 module.appProperties.Generate_product_characteristics_rro = nil
1154 // no need to create RRO
1155 return
1156 }
1157
1158 if !proptools.Bool(module.appProperties.Generate_product_characteristics_rro) {
1159 return
1160 }
1161
1162 rroPackageName := a.Name() + "__" + strings.ReplaceAll(characteristics, ",", "_") + "__auto_generated_characteristics_rro"
1163 rroManifestName := rroPackageName + "_manifest"
1164
1165 a.appProperties.ProductCharacteristicsRROPackageName = proptools.StringPtr(rroPackageName)
1166 a.appProperties.ProductCharacteristicsRROManifestModuleName = proptools.StringPtr(rroManifestName)
1167
1168 rroManifestProperties := struct {
1169 Name *string
1170 Tools []string
1171 Out []string
1172 Srcs []string
1173 Cmd *string
1174 }{
1175 Name: proptools.StringPtr(rroManifestName),
1176 Tools: []string{"characteristics_rro_generator"},
1177 Out: []string{"AndroidManifest.xml"},
1178 Srcs: []string{":" + a.Name() + "{.manifest.xml}"},
1179 Cmd: proptools.StringPtr("$(location characteristics_rro_generator) $(in) $(out)"),
1180 }
1181 ctx.CreateModule(genrule.GenRuleFactory, &rroManifestProperties)
1182
1183 rroProperties := struct {
1184 Name *string
1185 Filter_product *string
1186 Aaptflags []string
1187 Manifest *string
1188 Resource_dirs []string
1189 }{
1190 Name: proptools.StringPtr(rroPackageName),
1191 Filter_product: proptools.StringPtr(characteristics),
1192 Aaptflags: []string{"--auto-add-overlay"},
1193 Manifest: proptools.StringPtr(":" + rroManifestName),
1194 Resource_dirs: a.aaptProperties.Resource_dirs,
1195 }
1196 ctx.CreateModule(RuntimeResourceOverlayFactory, &rroProperties)
1197 })
1198
Colin Cross36242852017-06-23 15:06:31 -07001199 return module
Colin Cross30e076a2015-04-13 13:58:27 -07001200}
Colin Crossae5caf52018-05-22 11:11:52 -07001201
Alix96ea88452023-08-31 15:48:23 +00001202// A dictionary of values to be overridden in the manifest.
1203type Manifest_values struct {
1204 // Overrides the value of package_name in the manifest
1205 ApplicationId *string
1206}
1207
Colin Crossae5caf52018-05-22 11:11:52 -07001208type appTestProperties struct {
Liz Kammer6b0c5522020-04-28 16:10:55 -07001209 // The name of the android_app module that the tests will run against.
Colin Crossae5caf52018-05-22 11:11:52 -07001210 Instrumentation_for *string
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001211
Seth Moorec6f4b532023-02-02 13:22:26 -08001212 // If specified, the instrumentation target package name in the manifest is overwritten by it.
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001213 Instrumentation_target_package *string
Seth Moorec6f4b532023-02-02 13:22:26 -08001214
1215 // If specified, the mainline module package name in the test config is overwritten by it.
1216 Mainline_package_name *string
Alix96ea88452023-08-31 15:48:23 +00001217
1218 Manifest_values Manifest_values
Colin Crossae5caf52018-05-22 11:11:52 -07001219}
1220
1221type AndroidTest struct {
1222 AndroidApp
1223
1224 appTestProperties appTestProperties
1225
1226 testProperties testProperties
Colin Cross303e21f2018-08-07 16:49:25 -07001227
Dan Shi95d19422020-08-15 12:24:26 -07001228 testConfig android.Path
1229 extraTestConfigs android.Paths
1230 data android.Paths
Jingwen Chene12c0832023-08-25 09:00:16 +00001231
1232 android.BazelModuleBase
Colin Crossae5caf52018-05-22 11:11:52 -07001233}
1234
Jaewoong Jung0949f312019-09-11 10:25:18 -07001235func (a *AndroidTest) InstallInTestcases() bool {
1236 return true
1237}
1238
Spandan Das9f7ae7f2022-07-25 00:34:18 +00001239type androidTestApp interface {
1240 includedInTestSuite(searchPrefix string) bool
1241}
1242
1243func (a *AndroidTest) includedInTestSuite(searchPrefix string) bool {
1244 return android.PrefixInList(a.testProperties.Test_suites, searchPrefix)
1245}
1246
1247func (a *AndroidTestHelperApp) includedInTestSuite(searchPrefix string) bool {
1248 return android.PrefixInList(a.appTestHelperAppProperties.Test_suites, searchPrefix)
1249}
1250
Colin Crossae5caf52018-05-22 11:11:52 -07001251func (a *AndroidTest) GenerateAndroidBuildActions(ctx android.ModuleContext) {
easoncylee5bcff5d2020-04-30 14:57:06 +08001252 var configs []tradefed.Config
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001253 if a.appTestProperties.Instrumentation_target_package != nil {
1254 a.additionalAaptFlags = append(a.additionalAaptFlags,
1255 "--rename-instrumentation-target-package "+*a.appTestProperties.Instrumentation_target_package)
1256 } else if a.appTestProperties.Instrumentation_for != nil {
1257 // Check if the instrumentation target package is overridden.
Jaewoong Jung4102e5d2019-02-27 16:26:28 -08001258 manifestPackageName, overridden := ctx.DeviceConfig().OverrideManifestPackageNameFor(*a.appTestProperties.Instrumentation_for)
1259 if overridden {
1260 a.additionalAaptFlags = append(a.additionalAaptFlags, "--rename-instrumentation-target-package "+manifestPackageName)
1261 }
1262 }
Alix96ea88452023-08-31 15:48:23 +00001263 applicationId := a.appTestProperties.Manifest_values.ApplicationId
1264 if applicationId != nil {
1265 if a.overridableAppProperties.Package_name != nil {
1266 ctx.PropertyErrorf("manifest_values.applicationId", "property is not supported when property package_name is set.")
1267 }
1268 a.aapt.manifestValues.applicationId = *applicationId
1269 }
Colin Crossae5caf52018-05-22 11:11:52 -07001270 a.generateAndroidBuildActions(ctx)
Colin Cross303e21f2018-08-07 16:49:25 -07001271
easoncylee5bcff5d2020-04-30 14:57:06 +08001272 for _, module := range a.testProperties.Test_mainline_modules {
1273 configs = append(configs, tradefed.Option{Name: "config-descriptor:metadata", Key: "mainline-param", Value: module})
1274 }
1275
Jaewoong Jung39982342020-01-14 10:27:18 -08001276 testConfig := tradefed.AutoGenInstrumentationTestConfig(ctx, a.testProperties.Test_config,
easoncylee5bcff5d2020-04-30 14:57:06 +08001277 a.testProperties.Test_config_template, a.manifestPath, a.testProperties.Test_suites, a.testProperties.Auto_gen_config, configs)
Jaewoong Jung39982342020-01-14 10:27:18 -08001278 a.testConfig = a.FixTestConfig(ctx, testConfig)
Dan Shi95d19422020-08-15 12:24:26 -07001279 a.extraTestConfigs = android.PathsForModuleSrc(ctx, a.testProperties.Test_options.Extra_test_configs)
Colin Cross8a497952019-03-05 22:25:09 -08001280 a.data = android.PathsForModuleSrc(ctx, a.testProperties.Data)
Aditya Choudhary9b593522023-10-06 19:54:58 +00001281 ctx.SetProvider(testing.TestModuleProviderKey, testing.TestModuleProviderData{})
Colin Cross303e21f2018-08-07 16:49:25 -07001282}
1283
Jaewoong Jung39982342020-01-14 10:27:18 -08001284func (a *AndroidTest) FixTestConfig(ctx android.ModuleContext, testConfig android.Path) android.Path {
1285 if testConfig == nil {
1286 return nil
1287 }
1288
1289 fixedConfig := android.PathForModuleOut(ctx, "test_config_fixer", "AndroidTest.xml")
Colin Crossf1a035e2020-11-16 17:32:30 -08001290 rule := android.NewRuleBuilder(pctx, ctx)
1291 command := rule.Command().BuiltTool("test_config_fixer").Input(testConfig).Output(fixedConfig)
Jaewoong Jung39982342020-01-14 10:27:18 -08001292 fixNeeded := false
1293
Jooyung Han29e2f6d2022-01-08 12:13:59 +09001294 // Auto-generated test config uses `ModuleName` as the APK name. So fix it if it is not the case.
Jaewoong Jung39982342020-01-14 10:27:18 -08001295 if ctx.ModuleName() != a.installApkName {
1296 fixNeeded = true
1297 command.FlagWithArg("--test-file-name ", a.installApkName+".apk")
1298 }
1299
1300 if a.overridableAppProperties.Package_name != nil {
1301 fixNeeded = true
1302 command.FlagWithInput("--manifest ", a.manifestPath).
1303 FlagWithArg("--package-name ", *a.overridableAppProperties.Package_name)
1304 }
1305
Seth Moorec6f4b532023-02-02 13:22:26 -08001306 if a.appTestProperties.Mainline_package_name != nil {
1307 fixNeeded = true
1308 command.FlagWithArg("--mainline-package-name ", *a.appTestProperties.Mainline_package_name)
1309 }
1310
Jaewoong Jung39982342020-01-14 10:27:18 -08001311 if fixNeeded {
Colin Crossf1a035e2020-11-16 17:32:30 -08001312 rule.Build("fix_test_config", "fix test config")
Jaewoong Jung39982342020-01-14 10:27:18 -08001313 return fixedConfig
1314 }
1315 return testConfig
1316}
1317
Colin Cross303e21f2018-08-07 16:49:25 -07001318func (a *AndroidTest) DepsMutator(ctx android.BottomUpMutatorContext) {
Colin Cross303e21f2018-08-07 16:49:25 -07001319 a.AndroidApp.DepsMutator(ctx)
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001320}
1321
1322func (a *AndroidTest) OverridablePropertiesDepsMutator(ctx android.BottomUpMutatorContext) {
1323 a.AndroidApp.OverridablePropertiesDepsMutator(ctx)
Colin Cross4b964c02018-10-15 16:18:06 -07001324 if a.appTestProperties.Instrumentation_for != nil {
1325 // The android_app dependency listed in instrumentation_for needs to be added to the classpath for javac,
1326 // but not added to the aapt2 link includes like a normal android_app or android_library dependency, so
1327 // use instrumentationForTag instead of libTag.
1328 ctx.AddVariationDependencies(nil, instrumentationForTag, String(a.appTestProperties.Instrumentation_for))
1329 }
Colin Crossae5caf52018-05-22 11:11:52 -07001330}
1331
Colin Cross1b16b0e2019-02-12 14:41:32 -08001332// android_test compiles test sources and Android resources into an Android application package `.apk` file and
1333// creates an `AndroidTest.xml` file to allow running the test with `atest` or a `TEST_MAPPING` file.
Colin Crossae5caf52018-05-22 11:11:52 -07001334func AndroidTestFactory() android.Module {
1335 module := &AndroidTest{}
1336
Jared Duke63a3da92022-06-02 19:11:14 +00001337 module.Module.dexProperties.Optimize.EnabledByDefault = false
Colin Cross5067db92018-09-17 16:46:35 -07001338
1339 module.Module.properties.Instrument = true
Paul Duffin0038a8d2022-05-03 00:28:40 +00001340 module.Module.properties.Supports_static_instrumentation = true
Colin Cross9ae1b922018-06-26 17:59:05 -07001341 module.Module.properties.Installable = proptools.BoolPtr(true)
Colin Crosse4246ab2019-02-05 21:55:21 -08001342 module.appProperties.Use_embedded_native_libs = proptools.BoolPtr(true)
Colin Cross47fa9d32019-03-26 10:51:39 -07001343 module.appProperties.AlwaysPackageNativeLibs = true
Colin Cross43f08db2018-11-12 10:13:39 -08001344 module.Module.dexpreopter.isTest = true
Cole Faustd57e8b22022-08-11 11:59:04 -07001345 module.Module.linter.properties.Lint.Test = proptools.BoolPtr(true)
Colin Crossae5caf52018-05-22 11:11:52 -07001346
Colin Crossce6734e2020-06-15 16:09:53 -07001347 module.addHostAndDeviceProperties()
Colin Crossae5caf52018-05-22 11:11:52 -07001348 module.AddProperties(
Colin Crossae5caf52018-05-22 11:11:52 -07001349 &module.aaptProperties,
1350 &module.appProperties,
Dan Willemsenf5531d22018-07-16 17:21:19 -07001351 &module.appTestProperties,
Jaewoong Jung525443a2019-02-28 15:35:54 -08001352 &module.overridableAppProperties,
Dan Willemsenf5531d22018-07-16 17:21:19 -07001353 &module.testProperties)
Colin Crossae5caf52018-05-22 11:11:52 -07001354
Colin Crossa4f08812018-10-02 22:03:40 -07001355 android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
1356 android.InitDefaultableModule(module)
zhidou198f5892022-02-17 02:33:12 +00001357 android.InitOverridableModule(module, &module.overridableAppProperties.Overrides)
Jingwen Chene12c0832023-08-25 09:00:16 +00001358
1359 android.InitBazelModule(module)
Colin Crossae5caf52018-05-22 11:11:52 -07001360 return module
1361}
Colin Crossbd01e2a2018-10-04 15:21:03 -07001362
Colin Cross252fc6f2018-10-04 15:22:03 -07001363type appTestHelperAppProperties struct {
1364 // list of compatibility suites (for example "cts", "vts") that the module should be
1365 // installed into.
1366 Test_suites []string `android:"arch_variant"`
Dan Shi6ffaaa82019-09-26 11:41:36 -07001367
1368 // Flag to indicate whether or not to create test config automatically. If AndroidTest.xml
1369 // doesn't exist next to the Android.bp, this attribute doesn't need to be set to true
1370 // explicitly.
1371 Auto_gen_config *bool
Colin Crosscfb0f5e2021-09-24 15:47:17 -07001372
1373 // Install the test into a folder named for the module in all test suites.
1374 Per_testcase_directory *bool
Alix96ea88452023-08-31 15:48:23 +00001375
1376 Manifest_values Manifest_values
Colin Cross252fc6f2018-10-04 15:22:03 -07001377}
1378
1379type AndroidTestHelperApp struct {
1380 AndroidApp
1381
1382 appTestHelperAppProperties appTestHelperAppProperties
Jingwen Chen65289992023-09-21 15:15:47 +00001383
1384 android.BazelModuleBase
Colin Cross252fc6f2018-10-04 15:22:03 -07001385}
1386
Jaewoong Jung326a9412019-11-21 10:41:00 -08001387func (a *AndroidTestHelperApp) InstallInTestcases() bool {
1388 return true
1389}
1390
Colin Cross1b16b0e2019-02-12 14:41:32 -08001391// android_test_helper_app compiles sources and Android resources into an Android application package `.apk` file that
1392// will be used by tests, but does not produce an `AndroidTest.xml` file so the module will not be run directly as a
1393// test.
Colin Cross252fc6f2018-10-04 15:22:03 -07001394func AndroidTestHelperAppFactory() android.Module {
1395 module := &AndroidTestHelperApp{}
1396
Jared Duke63a3da92022-06-02 19:11:14 +00001397 // TODO(b/192032291): Disable by default after auditing downstream usage.
Liz Kammera7a64f32020-07-09 15:16:41 -07001398 module.Module.dexProperties.Optimize.EnabledByDefault = true
Colin Cross252fc6f2018-10-04 15:22:03 -07001399
1400 module.Module.properties.Installable = proptools.BoolPtr(true)
Colin Crosse4246ab2019-02-05 21:55:21 -08001401 module.appProperties.Use_embedded_native_libs = proptools.BoolPtr(true)
Colin Cross47fa9d32019-03-26 10:51:39 -07001402 module.appProperties.AlwaysPackageNativeLibs = true
Colin Cross43f08db2018-11-12 10:13:39 -08001403 module.Module.dexpreopter.isTest = true
Cole Faustd57e8b22022-08-11 11:59:04 -07001404 module.Module.linter.properties.Lint.Test = proptools.BoolPtr(true)
Colin Cross252fc6f2018-10-04 15:22:03 -07001405
Colin Crossce6734e2020-06-15 16:09:53 -07001406 module.addHostAndDeviceProperties()
Colin Cross252fc6f2018-10-04 15:22:03 -07001407 module.AddProperties(
Colin Cross252fc6f2018-10-04 15:22:03 -07001408 &module.aaptProperties,
1409 &module.appProperties,
Jaewoong Jung525443a2019-02-28 15:35:54 -08001410 &module.appTestHelperAppProperties,
Ulya Trafimovich21a73752020-09-01 17:33:48 +01001411 &module.overridableAppProperties)
Colin Cross252fc6f2018-10-04 15:22:03 -07001412
1413 android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
1414 android.InitDefaultableModule(module)
Anton Hansson3d2b6b42020-01-10 15:06:01 +00001415 android.InitApexModule(module)
Jingwen Chen65289992023-09-21 15:15:47 +00001416 android.InitBazelModule(module)
Colin Cross252fc6f2018-10-04 15:22:03 -07001417 return module
1418}
1419
Colin Crossbd01e2a2018-10-04 15:21:03 -07001420type AndroidAppCertificate struct {
1421 android.ModuleBase
Rupert Shuttleworth6e4950a2021-07-27 01:34:59 -04001422 android.BazelModuleBase
1423
Colin Crossbd01e2a2018-10-04 15:21:03 -07001424 properties AndroidAppCertificateProperties
Jiyong Parkc00cbd92018-10-30 21:20:05 +09001425 Certificate Certificate
Colin Crossbd01e2a2018-10-04 15:21:03 -07001426}
1427
1428type AndroidAppCertificateProperties struct {
1429 // Name of the certificate files. Extensions .x509.pem and .pk8 will be added to the name.
1430 Certificate *string
1431}
1432
Colin Cross1b16b0e2019-02-12 14:41:32 -08001433// android_app_certificate modules can be referenced by the certificates property of android_app modules to select
1434// the signing key.
Colin Crossbd01e2a2018-10-04 15:21:03 -07001435func AndroidAppCertificateFactory() android.Module {
1436 module := &AndroidAppCertificate{}
1437 module.AddProperties(&module.properties)
1438 android.InitAndroidModule(module)
Rupert Shuttleworth6e4950a2021-07-27 01:34:59 -04001439 android.InitBazelModule(module)
Colin Crossbd01e2a2018-10-04 15:21:03 -07001440 return module
1441}
1442
Colin Crossbd01e2a2018-10-04 15:21:03 -07001443func (c *AndroidAppCertificate) GenerateAndroidBuildActions(ctx android.ModuleContext) {
1444 cert := String(c.properties.Certificate)
Jiyong Parkc00cbd92018-10-30 21:20:05 +09001445 c.Certificate = Certificate{
Colin Cross503c1d02020-01-28 14:00:53 -08001446 Pem: android.PathForModuleSrc(ctx, cert+".x509.pem"),
1447 Key: android.PathForModuleSrc(ctx, cert+".pk8"),
Colin Crossbd01e2a2018-10-04 15:21:03 -07001448 }
1449}
Jaewoong Jung525443a2019-02-28 15:35:54 -08001450
1451type OverrideAndroidApp struct {
1452 android.ModuleBase
1453 android.OverrideModuleBase
1454}
1455
Sasha Smundak613cbb12020-06-05 10:27:23 -07001456func (i *OverrideAndroidApp) GenerateAndroidBuildActions(_ android.ModuleContext) {
Jaewoong Jung525443a2019-02-28 15:35:54 -08001457 // All the overrides happen in the base module.
1458 // TODO(jungjw): Check the base module type.
1459}
1460
1461// override_android_app is used to create an android_app module based on another android_app by overriding
1462// some of its properties.
1463func OverrideAndroidAppModuleFactory() android.Module {
1464 m := &OverrideAndroidApp{}
Jooyung Han01d80d82022-01-08 12:16:32 +09001465 m.AddProperties(
1466 &OverridableDeviceProperties{},
1467 &overridableAppProperties{},
1468 )
Jaewoong Jung525443a2019-02-28 15:35:54 -08001469
Jaewoong Jungb639a6a2019-05-10 15:16:29 -07001470 android.InitAndroidMultiTargetsArchModule(m, android.DeviceSupported, android.MultilibCommon)
Jaewoong Jung525443a2019-02-28 15:35:54 -08001471 android.InitOverrideModule(m)
1472 return m
1473}
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001474
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001475type OverrideAndroidTest struct {
1476 android.ModuleBase
1477 android.OverrideModuleBase
1478}
1479
Sasha Smundak613cbb12020-06-05 10:27:23 -07001480func (i *OverrideAndroidTest) GenerateAndroidBuildActions(_ android.ModuleContext) {
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001481 // All the overrides happen in the base module.
1482 // TODO(jungjw): Check the base module type.
1483}
1484
1485// override_android_test is used to create an android_app module based on another android_test by overriding
1486// some of its properties.
1487func OverrideAndroidTestModuleFactory() android.Module {
1488 m := &OverrideAndroidTest{}
1489 m.AddProperties(&overridableAppProperties{})
1490 m.AddProperties(&appTestProperties{})
1491
1492 android.InitAndroidMultiTargetsArchModule(m, android.DeviceSupported, android.MultilibCommon)
1493 android.InitOverrideModule(m)
1494 return m
1495}
1496
Colin Cross50ddcc42019-05-16 12:28:22 -07001497type UsesLibraryProperties struct {
1498 // A list of shared library modules that will be listed in uses-library tags in the AndroidManifest.xml file.
1499 Uses_libs []string
1500
1501 // A list of shared library modules that will be listed in uses-library tags in the AndroidManifest.xml file with
1502 // required=false.
1503 Optional_uses_libs []string
1504
1505 // If true, the list of uses_libs and optional_uses_libs modules must match the AndroidManifest.xml file. Defaults
1506 // to true if either uses_libs or optional_uses_libs is set. Will unconditionally default to true in the future.
1507 Enforce_uses_libs *bool
Ulya Trafimovich21a73752020-09-01 17:33:48 +01001508
Ulya Trafimovich54027b52020-09-09 14:08:23 +01001509 // Optional name of the <uses-library> provided by this module. This is needed for non-SDK
1510 // libraries, because SDK ones are automatically picked up by Soong. The <uses-library> name
1511 // normally is the same as the module name, but there are exceptions.
1512 Provides_uses_lib *string
Paul Duffin06530572022-02-03 17:54:15 +00001513
1514 // A list of shared library names to exclude from the classpath of the APK. Adding a library here
1515 // will prevent it from being used when precompiling the APK and prevent it from being implicitly
1516 // added to the APK's manifest's <uses-library> elements.
1517 //
1518 // Care must be taken when using this as it could result in runtime errors if the APK actually
1519 // uses classes provided by the library and which are not provided in any other way.
1520 //
1521 // This is primarily intended for use by various CTS tests that check the runtime handling of the
1522 // android.test.base shared library (and related libraries) but which depend on some common
1523 // libraries that depend on the android.test.base library. Without this those tests will end up
1524 // with a <uses-library android:name="android.test.base"/> in their manifest which would either
1525 // render the tests worthless (as they would be testing the wrong behavior), or would break the
1526 // test altogether by providing access to classes that the tests were not expecting. Those tests
1527 // provide the android.test.base statically and use jarjar to rename them so they do not collide
1528 // with the classes provided by the android.test.base library.
1529 Exclude_uses_libs []string
Colin Cross50ddcc42019-05-16 12:28:22 -07001530}
1531
1532// usesLibrary provides properties and helper functions for AndroidApp and AndroidAppImport to verify that the
1533// <uses-library> tags that end up in the manifest of an APK match the ones known to the build system through the
1534// uses_libs and optional_uses_libs properties. The build system's values are used by dexpreopt to preopt apps
1535// with knowledge of their shared libraries.
1536type usesLibrary struct {
1537 usesLibraryProperties UsesLibraryProperties
Ulya Trafimovich22890c42021-01-05 12:04:17 +00001538
1539 // Whether to enforce verify_uses_library check.
1540 enforce bool
Colin Cross50ddcc42019-05-16 12:28:22 -07001541}
1542
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +01001543func (u *usesLibrary) addLib(lib string, optional bool) {
1544 if !android.InList(lib, u.usesLibraryProperties.Uses_libs) && !android.InList(lib, u.usesLibraryProperties.Optional_uses_libs) {
1545 if optional {
1546 u.usesLibraryProperties.Optional_uses_libs = append(u.usesLibraryProperties.Optional_uses_libs, lib)
1547 } else {
1548 u.usesLibraryProperties.Uses_libs = append(u.usesLibraryProperties.Uses_libs, lib)
1549 }
1550 }
1551}
1552
Colin Cross4a80a152022-12-21 21:51:52 -08001553func (u *usesLibrary) deps(ctx android.BottomUpMutatorContext, addCompatDeps bool) {
Jeongik Cha4b073cd2021-06-08 11:35:00 +09001554 if !ctx.Config().UnbundledBuild() || ctx.Config().UnbundledBuildImage() {
Ulya Trafimovichf5d91bb2022-05-04 12:00:02 +01001555 ctx.AddVariationDependencies(nil, usesLibReqTag, u.usesLibraryProperties.Uses_libs...)
1556 ctx.AddVariationDependencies(nil, usesLibOptTag, u.presentOptionalUsesLibs(ctx)...)
Colin Cross4a80a152022-12-21 21:51:52 -08001557 // Only add these extra dependencies if the module is an app that depends on framework
1558 // libs. This avoids creating a cyclic dependency:
Paul Duffin250e6192019-06-07 10:44:37 +01001559 // e.g. framework-res -> org.apache.http.legacy -> ... -> framework-res.
Colin Cross4a80a152022-12-21 21:51:52 -08001560 if addCompatDeps {
Ulya Trafimovichf5d91bb2022-05-04 12:00:02 +01001561 // Dexpreopt needs paths to the dex jars of these libraries in order to construct
1562 // class loader context for dex2oat. Add them as a dependency with a special tag.
1563 ctx.AddVariationDependencies(nil, usesLibCompat29ReqTag, dexpreopt.CompatUsesLibs29...)
1564 ctx.AddVariationDependencies(nil, usesLibCompat28OptTag, dexpreopt.OptionalCompatUsesLibs28...)
1565 ctx.AddVariationDependencies(nil, usesLibCompat30OptTag, dexpreopt.OptionalCompatUsesLibs30...)
Colin Cross3245b2c2019-06-07 13:18:09 -07001566 }
Sam Delmerico9f9c0a22022-11-29 11:19:37 -05001567 } else {
1568 ctx.AddVariationDependencies(nil, r8LibraryJarTag, u.usesLibraryProperties.Uses_libs...)
1569 ctx.AddVariationDependencies(nil, r8LibraryJarTag, u.presentOptionalUsesLibs(ctx)...)
Colin Cross50ddcc42019-05-16 12:28:22 -07001570 }
1571}
1572
Jiakai Zhang4f65a032023-06-01 15:16:58 +01001573// presentOptionalUsesLibs returns optional_uses_libs after filtering out libraries that don't exist in the source tree.
Colin Cross50ddcc42019-05-16 12:28:22 -07001574func (u *usesLibrary) presentOptionalUsesLibs(ctx android.BaseModuleContext) []string {
Jiakai Zhang4f65a032023-06-01 15:16:58 +01001575 optionalUsesLibs := android.FilterListPred(u.usesLibraryProperties.Optional_uses_libs, func(s string) bool {
1576 exists := ctx.OtherModuleExists(s)
Jiakai Zhang48203e32023-06-02 23:42:21 +01001577 if !exists && !android.InList(ctx.ModuleName(), ctx.Config().BuildWarningBadOptionalUsesLibsAllowlist()) {
Jiakai Zhang4f65a032023-06-01 15:16:58 +01001578 fmt.Printf("Warning: Module '%s' depends on non-existing optional_uses_libs '%s'\n", ctx.ModuleName(), s)
1579 }
1580 return exists
1581 })
Colin Cross50ddcc42019-05-16 12:28:22 -07001582 return optionalUsesLibs
1583}
1584
Ulya Trafimovicheea486a2021-02-26 11:38:21 +00001585// Helper function to replace string in a list.
1586func replaceInList(list []string, oldstr, newstr string) {
1587 for i, str := range list {
1588 if str == oldstr {
1589 list[i] = newstr
1590 }
1591 }
1592}
1593
Ulya Trafimovich24446712021-07-15 14:59:34 +01001594// Returns a map of module names of shared library dependencies to the paths to their dex jars on
1595// host and on device.
Ulya Trafimovich8cbc5d22020-11-03 15:15:46 +00001596func (u *usesLibrary) classLoaderContextForUsesLibDeps(ctx android.ModuleContext) dexpreopt.ClassLoaderContextMap {
1597 clcMap := make(dexpreopt.ClassLoaderContextMap)
Ulya Trafimovich24446712021-07-15 14:59:34 +01001598
1599 // Skip when UnbundledBuild() is true, but UnbundledBuildImage() is false. With
1600 // UnbundledBuildImage() it is necessary to generate dexpreopt.config for post-dexpreopting.
1601 if ctx.Config().UnbundledBuild() && !ctx.Config().UnbundledBuildImage() {
1602 return clcMap
Colin Cross50ddcc42019-05-16 12:28:22 -07001603 }
1604
Ulya Trafimovich24446712021-07-15 14:59:34 +01001605 ctx.VisitDirectDeps(func(m android.Module) {
1606 tag, isUsesLibTag := ctx.OtherModuleDependencyTag(m).(usesLibraryDependencyTag)
1607 if !isUsesLibTag {
1608 return
1609 }
1610
Ulya Trafimoviche14f80b2021-07-15 15:05:48 +01001611 dep := android.RemoveOptionalPrebuiltPrefix(ctx.OtherModuleName(m))
Ulya Trafimovich24446712021-07-15 14:59:34 +01001612
Ulya Trafimovich840efb62021-07-15 14:34:40 +01001613 // Skip stub libraries. A dependency on the implementation library has been added earlier,
1614 // so it will be added to CLC, but the stub shouldn't be. Stub libraries can be distingushed
1615 // from implementation libraries by their name, which is different as it has a suffix.
1616 if comp, ok := m.(SdkLibraryComponentDependency); ok {
1617 if impl := comp.OptionalSdkLibraryImplementation(); impl != nil && *impl != dep {
1618 return
1619 }
1620 }
1621
Ulya Trafimovich24446712021-07-15 14:59:34 +01001622 if lib, ok := m.(UsesLibraryDependency); ok {
Ulya Trafimoviche14f80b2021-07-15 15:05:48 +01001623 libName := dep
Ulya Trafimovich24446712021-07-15 14:59:34 +01001624 if ulib, ok := m.(ProvidesUsesLib); ok && ulib.ProvidesUsesLib() != nil {
Ulya Trafimoviche14f80b2021-07-15 15:05:48 +01001625 libName = *ulib.ProvidesUsesLib()
Ulya Trafimovich24446712021-07-15 14:59:34 +01001626 // Replace module name with library name in `uses_libs`/`optional_uses_libs` in
1627 // order to pass verify_uses_libraries check (which compares these properties
1628 // against library names written in the manifest).
1629 replaceInList(u.usesLibraryProperties.Uses_libs, dep, libName)
1630 replaceInList(u.usesLibraryProperties.Optional_uses_libs, dep, libName)
1631 }
Ulya Trafimovichf5d91bb2022-05-04 12:00:02 +01001632 clcMap.AddContext(ctx, tag.sdkVersion, libName, tag.optional,
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01001633 lib.DexJarBuildPath().PathOrNil(), lib.DexJarInstallPath(),
1634 lib.ClassLoaderContexts())
Ulya Trafimovich24446712021-07-15 14:59:34 +01001635 } else if ctx.Config().AllowMissingDependencies() {
1636 ctx.AddMissingDependencies([]string{dep})
1637 } else {
1638 ctx.ModuleErrorf("module %q in uses_libs or optional_uses_libs must be a java library", dep)
1639 }
1640 })
Ulya Trafimovich8cbc5d22020-11-03 15:15:46 +00001641 return clcMap
Colin Cross50ddcc42019-05-16 12:28:22 -07001642}
1643
1644// enforceUsesLibraries returns true of <uses-library> tags should be checked against uses_libs and optional_uses_libs
1645// properties. Defaults to true if either of uses_libs or optional_uses_libs is specified. Will default to true
1646// unconditionally in the future.
1647func (u *usesLibrary) enforceUsesLibraries() bool {
1648 defaultEnforceUsesLibs := len(u.usesLibraryProperties.Uses_libs) > 0 ||
1649 len(u.usesLibraryProperties.Optional_uses_libs) > 0
Ulya Trafimovich22890c42021-01-05 12:04:17 +00001650 return BoolDefault(u.usesLibraryProperties.Enforce_uses_libs, u.enforce || defaultEnforceUsesLibs)
Colin Cross50ddcc42019-05-16 12:28:22 -07001651}
1652
Ulya Trafimovichfc24ad32020-08-19 16:32:54 +01001653// Freeze the value of `enforce_uses_libs` based on the current values of `uses_libs` and `optional_uses_libs`.
1654func (u *usesLibrary) freezeEnforceUsesLibraries() {
1655 enforce := u.enforceUsesLibraries()
1656 u.usesLibraryProperties.Enforce_uses_libs = &enforce
1657}
1658
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001659// verifyUsesLibraries checks the <uses-library> tags in the manifest against the ones specified
1660// in the `uses_libs`/`optional_uses_libs` properties. The input can be either an XML manifest, or
1661// an APK with the manifest embedded in it (manifest_check will know which one it is by the file
1662// extension: APKs are supposed to end with '.apk').
1663func (u *usesLibrary) verifyUsesLibraries(ctx android.ModuleContext, inputFile android.Path,
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001664 outputFile android.WritablePath) android.Path {
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001665
Ulya Trafimovich8c35fcf2021-02-17 16:23:28 +00001666 statusFile := dexpreopt.UsesLibrariesStatusFile(ctx)
Colin Cross50ddcc42019-05-16 12:28:22 -07001667
Ulya Trafimovich6e55ef12021-03-04 12:37:50 +00001668 // Disable verify_uses_libraries check if dexpreopt is globally disabled. Without dexpreopt the
1669 // check is not necessary, and although it is good to have, it is difficult to maintain on
1670 // non-linux build platforms where dexpreopt is generally disabled (the check may fail due to
1671 // various unrelated reasons, such as a failure to get manifest from an APK).
Ulya Trafimovich39dd0a42021-03-29 14:57:34 +01001672 global := dexpreopt.GetGlobalConfig(ctx)
Jiakai Zhang23984422023-11-09 16:47:04 +00001673 if global.DisablePreopt || global.OnlyPreoptArtBootImage {
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001674 return inputFile
Ulya Trafimovich6e55ef12021-03-04 12:37:50 +00001675 }
1676
Colin Crossf1a035e2020-11-16 17:32:30 -08001677 rule := android.NewRuleBuilder(pctx, ctx)
1678 cmd := rule.Command().BuiltTool("manifest_check").
Colin Cross50ddcc42019-05-16 12:28:22 -07001679 Flag("--enforce-uses-libraries").
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001680 Input(inputFile).
Ulya Trafimovich8c35fcf2021-02-17 16:23:28 +00001681 FlagWithOutput("--enforce-uses-libraries-status ", statusFile).
Saeid Farivar Asanjanfd27c7c2022-08-08 20:21:26 +00001682 FlagWithInput("--aapt ", ctx.Config().HostToolPath(ctx, "aapt2"))
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001683
1684 if outputFile != nil {
1685 cmd.FlagWithOutput("-o ", outputFile)
1686 }
Colin Cross50ddcc42019-05-16 12:28:22 -07001687
Ulya Trafimovich8c35fcf2021-02-17 16:23:28 +00001688 if dexpreopt.GetGlobalConfig(ctx).RelaxUsesLibraryCheck {
1689 cmd.Flag("--enforce-uses-libraries-relax")
1690 }
1691
Colin Cross50ddcc42019-05-16 12:28:22 -07001692 for _, lib := range u.usesLibraryProperties.Uses_libs {
1693 cmd.FlagWithArg("--uses-library ", lib)
1694 }
1695
1696 for _, lib := range u.usesLibraryProperties.Optional_uses_libs {
1697 cmd.FlagWithArg("--optional-uses-library ", lib)
1698 }
1699
Colin Crossf1a035e2020-11-16 17:32:30 -08001700 rule.Build("verify_uses_libraries", "verify <uses-library>")
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001701 return outputFile
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001702}
Colin Cross50ddcc42019-05-16 12:28:22 -07001703
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001704// verifyUsesLibrariesManifest checks the <uses-library> tags in an AndroidManifest.xml against
1705// the build system and returns the path to a copy of the manifest.
1706func (u *usesLibrary) verifyUsesLibrariesManifest(ctx android.ModuleContext, manifest android.Path) android.Path {
1707 outputFile := android.PathForModuleOut(ctx, "manifest_check", "AndroidManifest.xml")
Ulya Trafimovicha76d6602021-03-16 15:34:50 +00001708 return u.verifyUsesLibraries(ctx, manifest, outputFile)
Colin Cross50ddcc42019-05-16 12:28:22 -07001709}
1710
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001711// verifyUsesLibrariesAPK checks the <uses-library> tags in the manifest of an APK against the build
1712// system and returns the path to a copy of the APK.
Cole Faust2f1da162023-04-17 15:06:56 -07001713func (u *usesLibrary) verifyUsesLibrariesAPK(ctx android.ModuleContext, apk android.Path) {
Ulya Trafimovich0aba2522021-03-03 16:38:37 +00001714 u.verifyUsesLibraries(ctx, apk, nil) // for APKs manifest_check does not write output file
Colin Cross50ddcc42019-05-16 12:28:22 -07001715}
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001716
1717// For Bazel / bp2build
1718
1719type bazelAndroidAppCertificateAttributes struct {
1720 Certificate string
1721}
1722
Chris Parsons637458d2023-09-19 20:09:00 +00001723func (m *AndroidAppCertificate) ConvertWithBp2build(ctx android.Bp2buildMutatorContext) {
Liz Kammerbe46fcc2021-11-01 15:32:43 -04001724 androidAppCertificateBp2Build(ctx, m)
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001725}
1726
Chris Parsons637458d2023-09-19 20:09:00 +00001727func androidAppCertificateBp2Build(ctx android.Bp2buildMutatorContext, module *AndroidAppCertificate) {
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001728 var certificate string
1729 if module.properties.Certificate != nil {
1730 certificate = *module.properties.Certificate
1731 }
1732
1733 attrs := &bazelAndroidAppCertificateAttributes{
1734 Certificate: certificate,
1735 }
1736
1737 props := bazel.BazelTargetModuleProperties{
1738 Rule_class: "android_app_certificate",
Alixa381cd12023-05-10 14:49:38 +00001739 Bzl_load_location: "//build/bazel/rules/android:android_app_certificate.bzl",
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001740 }
1741
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux447f6c92021-08-31 20:30:36 +00001742 ctx.CreateBazelTargetModule(props, android.CommonAttributes{Name: module.Name()}, attrs)
Rupert Shuttleworth5c4881c2021-07-28 06:21:31 -04001743}
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001744
Alixe5085eb2023-01-31 19:38:41 +00001745type manifestValueAttribute struct {
Romain Jobredeaux496660d2023-07-10 11:50:00 -04001746 MinSdkVersion *string
Romain Jobredeaux496660d2023-07-10 11:50:00 -04001747 TargetSdkVersion *string
Alixe5085eb2023-01-31 19:38:41 +00001748}
1749
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001750type bazelAndroidAppAttributes struct {
Sam Delmericoc0161432022-02-25 21:34:51 +00001751 *javaCommonAttributes
Romain Jobredeauxc9b2bba2022-02-15 09:35:07 -05001752 *bazelAapt
Sam Delmericoc0161432022-02-25 21:34:51 +00001753 Deps bazel.LabelListAttribute
Sam Delmerico9dfb1392022-02-10 21:11:59 +00001754 Custom_package *string
Jingwen Chen6817bbb2022-10-14 09:56:07 +00001755 Certificate bazel.LabelAttribute
1756 Certificate_name bazel.StringAttribute
Alixe5085eb2023-01-31 19:38:41 +00001757 Manifest_values *manifestValueAttribute
Romain Jobredeaux9973ace2023-08-30 00:27:09 -04001758 Optimize *bool
1759 Proguard_specs bazel.LabelListAttribute
Romain Jobredeaux3132f842023-09-15 10:06:16 -04001760 Updatable *bool
Jingwen Chenbea58092022-09-29 16:56:02 +00001761}
1762
Alixee51bd62023-08-29 16:01:46 +00001763func (b bazelAapt) ConvertJavaResources(ctx android.Bp2buildMutatorContext, javaAttrs *javaCommonAttributes) bool {
1764 // TODO (b/300470246) bp2build support for java_resources & java_resource_dirs in android rules
1765 hasJavaResources := !javaAttrs.javaResourcesAttributes.Resources.IsEmpty()
1766 if hasJavaResources {
1767 ctx.MarkBp2buildUnconvertible(bp2build_metrics_proto.UnconvertedReasonType_UNSUPPORTED, "(b/300470246) java resources in android_* module")
1768 }
1769 return hasJavaResources
1770}
1771
Chris Parsons637458d2023-09-19 20:09:00 +00001772func convertWithBp2build(ctx android.Bp2buildMutatorContext, a *AndroidApp) (bool, android.CommonAttributes, *bazelAndroidAppAttributes) {
Romain Jobredeaux7a71e072023-08-16 17:39:12 -04001773 aapt, supported := a.convertAaptAttrsWithBp2Build(ctx)
1774 if !supported {
Jingwen Chene12c0832023-08-25 09:00:16 +00001775 return false, android.CommonAttributes{}, &bazelAndroidAppAttributes{}
Romain Jobredeaux7a71e072023-08-16 17:39:12 -04001776 }
Spandan Das0e0a8802023-09-20 19:53:30 +00001777 if a.appProperties.Jni_uses_platform_apis != nil {
1778 ctx.MarkBp2buildUnconvertible(
1779 bp2build_metrics_proto.UnconvertedReasonType_UNSUPPORTED,
1780 "TODO - b/299360988: Add bp2build support for jni_uses_platform_apis",
1781 )
1782 return false, android.CommonAttributes{}, &bazelAndroidAppAttributes{}
1783 }
1784 if a.appProperties.Jni_uses_sdk_apis != nil {
1785 ctx.MarkBp2buildUnconvertible(
1786 bp2build_metrics_proto.UnconvertedReasonType_UNSUPPORTED,
1787 "TODO - b/299360988: Add bp2build support for jni_uses_sdk_apis",
1788 )
1789 return false, android.CommonAttributes{}, &bazelAndroidAppAttributes{}
1790 }
1791
Jingwen Chen6817bbb2022-10-14 09:56:07 +00001792 certificate, certificateName := android.BazelStringOrLabelFromProp(ctx, a.overridableAppProperties.Certificate)
1793
Romain Jobredeaux3132f842023-09-15 10:06:16 -04001794 manifestValues := &manifestValueAttribute{
1795 MinSdkVersion: a.deviceProperties.Min_sdk_version,
1796 TargetSdkVersion: a.deviceProperties.Target_sdk_version,
Romain Jobredeaux496660d2023-07-10 11:50:00 -04001797 }
1798
Alix0856f9e2023-01-20 22:15:30 +00001799 appAttrs := &bazelAndroidAppAttributes{
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001800 // TODO(b/209576404): handle package name override by product variable PRODUCT_MANIFEST_PACKAGE_NAME_OVERRIDES
Alix0856f9e2023-01-20 22:15:30 +00001801 Custom_package: a.overridableAppProperties.Package_name,
1802 Certificate: certificate,
1803 Certificate_name: certificateName,
Alixe5085eb2023-01-31 19:38:41 +00001804 Manifest_values: manifestValues,
Romain Jobredeaux3132f842023-09-15 10:06:16 -04001805 Updatable: a.appProperties.Updatable,
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001806 }
Sam Delmerico9dfb1392022-02-10 21:11:59 +00001807
Romain Jobredeaux9c06ef32023-08-21 18:05:29 -04001808 // As framework-res has no sources, no deps in the Bazel sense, and java compilation, dexing and optimization is skipped by
1809 // Soong specifically for it, return early here before any of the conversion work for the above is attempted.
1810 if ctx.ModuleName() == "framework-res" {
1811 appAttrs.bazelAapt = aapt
1812 return true, android.CommonAttributes{Name: a.Name(), SkipData: proptools.BoolPtr(true)}, appAttrs
1813 }
1814
Jingwen Chen65229202023-09-20 13:34:16 +00001815 // Optimization is..
1816 // - enabled by default for android_app, android_test_helper_app
1817 // - disabled by default for android_test
1818 //
1819 // TODO(b/192032291): Disable android_test_helper_app optimization by
1820 // default after auditing downstream usage.
Jingwen Chen256c3892023-09-26 05:51:40 +00001821 if a.dexProperties.Optimize.EnabledByDefault != a.dexer.effectiveOptimizeEnabled() {
1822 // Property is explicitly defined by default from default, so emit the Bazel attribute.
1823 appAttrs.Optimize = proptools.BoolPtr(a.dexer.effectiveOptimizeEnabled())
Jingwen Chen65229202023-09-20 13:34:16 +00001824 }
Jingwen Chen65229202023-09-20 13:34:16 +00001825
Jingwen Chen256c3892023-09-26 05:51:40 +00001826 if a.dexer.effectiveOptimizeEnabled() {
Romain Jobredeaux9973ace2023-08-30 00:27:09 -04001827 handCraftedFlags := ""
1828 if Bool(a.dexProperties.Optimize.Ignore_warnings) {
1829 handCraftedFlags += "-ignorewarning "
1830 }
1831 if !Bool(a.dexProperties.Optimize.Shrink) {
1832 handCraftedFlags += "-dontshrink "
1833 }
1834 if !Bool(a.dexProperties.Optimize.Optimize) {
1835 handCraftedFlags += "-dontoptimize "
1836 }
1837 if !Bool(a.dexProperties.Optimize.Obfuscate) {
1838 handCraftedFlags += "-dontobfuscate "
1839 }
1840 appAttrs.Proguard_specs = bazel.MakeLabelListAttribute(android.BazelLabelForModuleSrc(ctx, a.dexProperties.Optimize.Proguard_flags_files))
1841 if handCraftedFlags != "" {
1842 generatedFlagFileRuleName := a.Name() + "_proguard_flags"
1843 ctx.CreateBazelTargetModule(bazel.BazelTargetModuleProperties{
1844 Rule_class: "genrule",
1845 }, android.CommonAttributes{
1846 Name: generatedFlagFileRuleName,
1847 SkipData: proptools.BoolPtr(true),
1848 }, &genrule.BazelGenruleAttributes{
1849 Outs: []string{a.Name() + "_proguard.flags"},
1850 Cmd: bazel.StringAttribute{
1851 Value: proptools.StringPtr("echo " + handCraftedFlags + "> $(OUTS)"),
1852 },
1853 })
1854 appAttrs.Proguard_specs.Add(bazel.MakeLabelAttribute(":" + generatedFlagFileRuleName))
1855 }
Romain Jobredeaux9973ace2023-08-30 00:27:09 -04001856 }
1857
Romain Jobredeauxd2cc5032023-09-11 16:37:50 -04001858 commonAttrs, bp2BuildInfo, supported := a.convertLibraryAttrsBp2Build(ctx)
1859 if !supported {
Jingwen Chene12c0832023-08-25 09:00:16 +00001860 return false, android.CommonAttributes{}, &bazelAndroidAppAttributes{}
Romain Jobredeauxd2cc5032023-09-11 16:37:50 -04001861 }
Alixee51bd62023-08-29 16:01:46 +00001862 if hasJavaResources := aapt.ConvertJavaResources(ctx, commonAttrs); hasJavaResources {
1863 return false, android.CommonAttributes{}, &bazelAndroidAppAttributes{}
1864 }
1865
Romain Jobredeauxd2cc5032023-09-11 16:37:50 -04001866 depLabels := bp2BuildInfo.DepLabels
1867
1868 deps := depLabels.Deps
1869 deps.Append(depLabels.StaticDeps)
1870
Romain Jobredeaux947dfa72023-06-12 15:40:35 -04001871 var jniDeps bazel.LabelListAttribute
1872 archVariantProps := a.GetArchVariantProperties(ctx, &appProperties{})
1873 for axis, configToProps := range archVariantProps {
1874 for config, _props := range configToProps {
1875 if archProps, ok := _props.(*appProperties); ok {
1876 archJniLibs := android.BazelLabelForModuleDeps(
1877 ctx,
1878 android.LastUniqueStrings(android.CopyOf(archProps.Jni_libs)))
1879 jniDeps.SetSelectValue(axis, config, archJniLibs)
1880 }
1881 }
1882 }
1883 deps.Append(jniDeps)
1884
Alix75db7842023-03-06 22:08:49 +00001885 if !bp2BuildInfo.hasKotlin {
Alix0856f9e2023-01-20 22:15:30 +00001886 appAttrs.javaCommonAttributes = commonAttrs
1887 appAttrs.bazelAapt = aapt
1888 appAttrs.Deps = deps
Alix0856f9e2023-01-20 22:15:30 +00001889 } else {
1890 ktName := a.Name() + "_kt"
Alix0856f9e2023-01-20 22:15:30 +00001891 ctx.CreateBazelTargetModule(
Alix32540022023-03-16 21:06:13 +00001892 AndroidLibraryBazelTargetModuleProperties(),
Alix0856f9e2023-01-20 22:15:30 +00001893 android.CommonAttributes{Name: ktName},
1894 &bazelAndroidLibrary{
1895 javaLibraryAttributes: &javaLibraryAttributes{
1896 javaCommonAttributes: commonAttrs,
1897 Deps: deps,
1898 },
1899 bazelAapt: aapt,
1900 },
1901 )
1902
1903 appAttrs.bazelAapt = &bazelAapt{Manifest: aapt.Manifest}
1904 appAttrs.Deps = bazel.MakeSingleLabelListAttribute(bazel.Label{Label: ":" + ktName})
Romain Jobredeaux2eef2e12023-02-24 12:07:08 -05001905 appAttrs.javaCommonAttributes = &javaCommonAttributes{
1906 Sdk_version: commonAttrs.Sdk_version,
1907 }
Alix0856f9e2023-01-20 22:15:30 +00001908 }
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001909
Jingwen Chene12c0832023-08-25 09:00:16 +00001910 return true, android.CommonAttributes{Name: a.Name(), SkipData: proptools.BoolPtr(true)}, appAttrs
1911}
1912
1913// ConvertWithBp2build is used to convert android_app to Bazel.
Chris Parsons637458d2023-09-19 20:09:00 +00001914func (a *AndroidApp) ConvertWithBp2build(ctx android.Bp2buildMutatorContext) {
Jingwen Chene12c0832023-08-25 09:00:16 +00001915 if ok, commonAttrs, appAttrs := convertWithBp2build(ctx, a); ok {
Romain Jobredeaux9c06ef32023-08-21 18:05:29 -04001916 var props bazel.BazelTargetModuleProperties
1917 if ctx.ModuleName() == "framework-res" {
1918 props = bazel.BazelTargetModuleProperties{
1919 Rule_class: "framework_resources",
1920 Bzl_load_location: "//build/bazel/rules/android:framework_resources.bzl",
1921 }
1922 } else {
1923 props = bazel.BazelTargetModuleProperties{
1924 Rule_class: "android_binary",
1925 Bzl_load_location: "//build/bazel/rules/android:android_binary.bzl",
1926 }
Jingwen Chene12c0832023-08-25 09:00:16 +00001927 }
Jingwen Chene12c0832023-08-25 09:00:16 +00001928 ctx.CreateBazelTargetModule(props, commonAttrs, appAttrs)
1929 }
1930
1931}
1932
1933// ConvertWithBp2build is used to convert android_test to Bazel.
Chris Parsons637458d2023-09-19 20:09:00 +00001934func (at *AndroidTest) ConvertWithBp2build(ctx android.Bp2buildMutatorContext) {
Jingwen Chene12c0832023-08-25 09:00:16 +00001935 if ok, commonAttrs, appAttrs := convertWithBp2build(ctx, &at.AndroidApp); ok {
1936 props := bazel.BazelTargetModuleProperties{
1937 Rule_class: "android_test",
1938 Bzl_load_location: "//build/bazel/rules/android:android_test.bzl",
1939 }
1940
1941 ctx.CreateBazelTargetModule(props, commonAttrs, appAttrs)
1942 }
Alix733110e2023-02-06 14:53:10 +00001943
Romain Jobredeaux1282c422021-10-29 10:52:59 -04001944}
Jingwen Chen65289992023-09-21 15:15:47 +00001945
1946func (atha *AndroidTestHelperApp) ConvertWithBp2build(ctx android.Bp2buildMutatorContext) {
1947 if ok, commonAttrs, appAttrs := convertWithBp2build(ctx, &atha.AndroidApp); ok {
1948 // an android_test_helper_app is an android_binary with testonly = True
1949 commonAttrs.Testonly = proptools.BoolPtr(true)
1950
Jingwen Chen65229202023-09-20 13:34:16 +00001951 // android_test_helper_app sets default values differently to android_app,
Jingwen Chen65289992023-09-21 15:15:47 +00001952 // https://cs.android.com/android/platform/superproject/main/+/main:build/soong/java/app.go;l=1273-1279;drc=e12c083198403ec694af6c625aed11327eb2bf7f
1953 //
1954 // installable: true (settable prop)
1955 // use_embedded_native_libs: true (settable prop)
1956 // lint.test: true (settable prop)
Jingwen Chen65289992023-09-21 15:15:47 +00001957 // AlwaysPackageNativeLibs: true (blueprint mutated prop)
1958 // dexpreopt isTest: true (not prop)
1959
1960 props := bazel.BazelTargetModuleProperties{
1961 Rule_class: "android_binary",
1962 Bzl_load_location: "//build/bazel/rules/android:android_binary.bzl",
1963 }
1964
1965 ctx.CreateBazelTargetModule(props, commonAttrs, appAttrs)
1966 }
1967}