| Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 1 | // Copyright 2021 Google Inc. All rights reserved. | 
|  | 2 | // | 
|  | 3 | // Licensed under the Apache License, Version 2.0 (the "License"); | 
|  | 4 | // you may not use this file except in compliance with the License. | 
|  | 5 | // You may obtain a copy of the License at | 
|  | 6 | // | 
|  | 7 | //     http://www.apache.org/licenses/LICENSE-2.0 | 
|  | 8 | // | 
|  | 9 | // Unless required by applicable law or agreed to in writing, software | 
|  | 10 | // distributed under the License is distributed on an "AS IS" BASIS, | 
|  | 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | 
|  | 12 | // See the License for the specific language governing permissions and | 
|  | 13 | // limitations under the License. | 
|  | 14 |  | 
|  | 15 | package bp2build | 
|  | 16 |  | 
|  | 17 | import ( | 
| Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 18 | "fmt" | 
| Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 1c92aef | 2021-08-23 16:10:00 +0000 | [diff] [blame] | 19 | "testing" | 
|  | 20 |  | 
| Vinh Tran | 367d89d | 2023-04-28 11:21:25 -0400 | [diff] [blame] | 21 | "android/soong/aidl_library" | 
| Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 22 | "android/soong/android" | 
|  | 23 | "android/soong/cc" | 
| Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 24 | ) | 
|  | 25 |  | 
|  | 26 | const ( | 
|  | 27 | // See cc/testing.go for more context | 
|  | 28 | soongCcLibraryPreamble = ` | 
|  | 29 | cc_defaults { | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 30 | name: "linux_bionic_supported", | 
| Liz Kammer | baced71 | 2022-09-16 09:01:29 -0400 | [diff] [blame] | 31 | } | 
|  | 32 | ` | 
|  | 33 |  | 
|  | 34 | soongCcVersionLibBpPath = "build/soong/cc/libbuildversion/Android.bp" | 
|  | 35 | soongCcVersionLibBp     = ` | 
|  | 36 | cc_library_static { | 
|  | 37 | name: "libbuildversion", | 
|  | 38 | bazel_module: { bp2build_available: false }, | 
|  | 39 | } | 
|  | 40 | ` | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 41 |  | 
|  | 42 | soongCcProtoLibraries = ` | 
|  | 43 | cc_library { | 
|  | 44 | name: "libprotobuf-cpp-lite", | 
|  | 45 | bazel_module: { bp2build_available: false }, | 
|  | 46 | } | 
|  | 47 |  | 
|  | 48 | cc_library { | 
|  | 49 | name: "libprotobuf-cpp-full", | 
|  | 50 | bazel_module: { bp2build_available: false }, | 
|  | 51 | }` | 
|  | 52 |  | 
|  | 53 | soongCcProtoPreamble = soongCcLibraryPreamble + soongCcProtoLibraries | 
| Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 54 | ) | 
|  | 55 |  | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 56 | func runCcLibraryTestCase(t *testing.T, tc Bp2buildTestCase) { | 
| Liz Kammer | e4982e8 | 2021-05-25 10:39:35 -0400 | [diff] [blame] | 57 | t.Helper() | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 58 | RunBp2BuildTestCase(t, registerCcLibraryModuleTypes, tc) | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 59 | } | 
|  | 60 |  | 
|  | 61 | func registerCcLibraryModuleTypes(ctx android.RegistrationContext) { | 
|  | 62 | cc.RegisterCCBuildComponents(ctx) | 
| Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 63 | ctx.RegisterModuleType("filegroup", android.FileGroupFactory) | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 64 | ctx.RegisterModuleType("cc_library_static", cc.LibraryStaticFactory) | 
| Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 65 | ctx.RegisterModuleType("cc_prebuilt_library_static", cc.PrebuiltStaticLibraryFactory) | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 66 | ctx.RegisterModuleType("cc_library_headers", cc.LibraryHeaderFactory) | 
| Vinh Tran | 367d89d | 2023-04-28 11:21:25 -0400 | [diff] [blame] | 67 | ctx.RegisterModuleType("aidl_library", aidl_library.AidlLibraryFactory) | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 68 | } | 
|  | 69 |  | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 70 | func TestCcLibrarySimple(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 71 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 72 | Description:                "cc_library - simple example", | 
|  | 73 | ModuleTypeUnderTest:        "cc_library", | 
|  | 74 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 75 | Filesystem: map[string]string{ | 
| Liz Kammer | baced71 | 2022-09-16 09:01:29 -0400 | [diff] [blame] | 76 | soongCcVersionLibBpPath: soongCcVersionLibBp, | 
|  | 77 | "android.cpp":           "", | 
|  | 78 | "bionic.cpp":            "", | 
|  | 79 | "darwin.cpp":            "", | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 80 | // Refer to cc.headerExts for the supported header extensions in Soong. | 
|  | 81 | "header.h":         "", | 
|  | 82 | "header.hh":        "", | 
|  | 83 | "header.hpp":       "", | 
|  | 84 | "header.hxx":       "", | 
|  | 85 | "header.h++":       "", | 
|  | 86 | "header.inl":       "", | 
|  | 87 | "header.inc":       "", | 
|  | 88 | "header.ipp":       "", | 
|  | 89 | "header.h.generic": "", | 
|  | 90 | "impl.cpp":         "", | 
|  | 91 | "linux.cpp":        "", | 
|  | 92 | "x86.cpp":          "", | 
|  | 93 | "x86_64.cpp":       "", | 
|  | 94 | "foo-dir/a.h":      "", | 
|  | 95 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 96 | Blueprint: soongCcLibraryPreamble + | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 97 | simpleModuleDoNotConvertBp2build("cc_library_headers", "some-headers") + ` | 
| Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 98 | cc_library { | 
|  | 99 | name: "foo-lib", | 
|  | 100 | srcs: ["impl.cpp"], | 
|  | 101 | cflags: ["-Wall"], | 
|  | 102 | header_libs: ["some-headers"], | 
|  | 103 | export_include_dirs: ["foo-dir"], | 
|  | 104 | ldflags: ["-Wl,--exclude-libs=bar.a"], | 
|  | 105 | arch: { | 
|  | 106 | x86: { | 
|  | 107 | ldflags: ["-Wl,--exclude-libs=baz.a"], | 
|  | 108 | srcs: ["x86.cpp"], | 
|  | 109 | }, | 
|  | 110 | x86_64: { | 
|  | 111 | ldflags: ["-Wl,--exclude-libs=qux.a"], | 
|  | 112 | srcs: ["x86_64.cpp"], | 
|  | 113 | }, | 
|  | 114 | }, | 
|  | 115 | target: { | 
|  | 116 | android: { | 
|  | 117 | srcs: ["android.cpp"], | 
|  | 118 | }, | 
|  | 119 | linux_glibc: { | 
|  | 120 | srcs: ["linux.cpp"], | 
|  | 121 | }, | 
|  | 122 | darwin: { | 
|  | 123 | srcs: ["darwin.cpp"], | 
|  | 124 | }, | 
| Liz Kammer | 01a16e8 | 2021-07-16 16:33:47 -0400 | [diff] [blame] | 125 | bionic: { | 
|  | 126 | srcs: ["bionic.cpp"] | 
|  | 127 | }, | 
| Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 128 | }, | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 129 | include_build_directory: false, | 
| Yu Liu | fc60316 | 2022-03-01 15:44:08 -0800 | [diff] [blame] | 130 | sdk_version: "current", | 
|  | 131 | min_sdk_version: "29", | 
| Yu Liu | a79c946 | 2022-03-22 16:35:22 -0700 | [diff] [blame] | 132 | use_version_lib: true, | 
| Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 133 | } | 
|  | 134 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 135 | ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 136 | "copts":               `["-Wall"]`, | 
|  | 137 | "export_includes":     `["foo-dir"]`, | 
|  | 138 | "implementation_deps": `[":some-headers"]`, | 
|  | 139 | "linkopts": `["-Wl,--exclude-libs=bar.a"] + select({ | 
| Jingwen Chen | ed9c17d | 2021-04-13 07:14:55 +0000 | [diff] [blame] | 140 | "//build/bazel/platforms/arch:x86": ["-Wl,--exclude-libs=baz.a"], | 
|  | 141 | "//build/bazel/platforms/arch:x86_64": ["-Wl,--exclude-libs=qux.a"], | 
|  | 142 | "//conditions:default": [], | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 143 | })`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 144 | "srcs": `["impl.cpp"] + select({ | 
| Jingwen Chen | b4628eb | 2021-04-08 14:40:57 +0000 | [diff] [blame] | 145 | "//build/bazel/platforms/arch:x86": ["x86.cpp"], | 
|  | 146 | "//build/bazel/platforms/arch:x86_64": ["x86_64.cpp"], | 
| Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 147 | "//conditions:default": [], | 
|  | 148 | }) + select({ | 
| Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 149 | "//build/bazel/platforms/os:android": [ | 
| Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 150 | "bionic.cpp", | 
| Liz Kammer | fdd72e6 | 2021-10-11 15:41:03 -0400 | [diff] [blame] | 151 | "android.cpp", | 
| Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 152 | ], | 
| Jingwen Chen | b4628eb | 2021-04-08 14:40:57 +0000 | [diff] [blame] | 153 | "//build/bazel/platforms/os:darwin": ["darwin.cpp"], | 
| Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 154 | "//build/bazel/platforms/os:linux_bionic": ["bionic.cpp"], | 
| Colin Cross | 133782e | 2022-12-20 15:29:31 -0800 | [diff] [blame] | 155 | "//build/bazel/platforms/os:linux_glibc": ["linux.cpp"], | 
| Liz Kammer | 01a16e8 | 2021-07-16 16:33:47 -0400 | [diff] [blame] | 156 | "//conditions:default": [], | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 157 | })`, | 
| Yu Liu | fe978fd | 2023-04-24 16:37:18 -0700 | [diff] [blame] | 158 | "sdk_version":        `"current"`, | 
|  | 159 | "min_sdk_version":    `"29"`, | 
|  | 160 | "use_version_lib":    `True`, | 
|  | 161 | "whole_archive_deps": `["//build/soong/cc/libbuildversion:libbuildversion"]`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 162 | }), | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 163 | }) | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 164 | } | 
|  | 165 |  | 
|  | 166 | func TestCcLibraryTrimmedLdAndroid(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 167 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 168 | Description:                "cc_library - trimmed example of //bionic/linker:ld-android", | 
|  | 169 | ModuleTypeUnderTest:        "cc_library", | 
|  | 170 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 171 | Filesystem: map[string]string{ | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 172 | "ld-android.cpp":           "", | 
|  | 173 | "linked_list.h":            "", | 
|  | 174 | "linker.h":                 "", | 
|  | 175 | "linker_block_allocator.h": "", | 
|  | 176 | "linker_cfi.h":             "", | 
| Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 177 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 178 | Blueprint: soongCcLibraryPreamble + | 
| Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 179 | simpleModuleDoNotConvertBp2build("cc_library_headers", "libc_headers") + ` | 
| Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 180 | cc_library { | 
|  | 181 | name: "fake-ld-android", | 
|  | 182 | srcs: ["ld_android.cpp"], | 
|  | 183 | cflags: [ | 
|  | 184 | "-Wall", | 
|  | 185 | "-Wextra", | 
|  | 186 | "-Wunused", | 
|  | 187 | "-Werror", | 
|  | 188 | ], | 
|  | 189 | header_libs: ["libc_headers"], | 
|  | 190 | ldflags: [ | 
|  | 191 | "-Wl,--exclude-libs=libgcc.a", | 
|  | 192 | "-Wl,--exclude-libs=libgcc_stripped.a", | 
|  | 193 | "-Wl,--exclude-libs=libclang_rt.builtins-arm-android.a", | 
|  | 194 | "-Wl,--exclude-libs=libclang_rt.builtins-aarch64-android.a", | 
|  | 195 | "-Wl,--exclude-libs=libclang_rt.builtins-i686-android.a", | 
|  | 196 | "-Wl,--exclude-libs=libclang_rt.builtins-x86_64-android.a", | 
|  | 197 | ], | 
|  | 198 | arch: { | 
|  | 199 | x86: { | 
|  | 200 | ldflags: ["-Wl,--exclude-libs=libgcc_eh.a"], | 
|  | 201 | }, | 
|  | 202 | x86_64: { | 
|  | 203 | ldflags: ["-Wl,--exclude-libs=libgcc_eh.a"], | 
|  | 204 | }, | 
|  | 205 | }, | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 206 | include_build_directory: false, | 
| Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 207 | } | 
|  | 208 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 209 | ExpectedBazelTargets: makeCcLibraryTargets("fake-ld-android", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 210 | "srcs": `["ld_android.cpp"]`, | 
|  | 211 | "copts": `[ | 
| Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 212 | "-Wall", | 
|  | 213 | "-Wextra", | 
|  | 214 | "-Wunused", | 
|  | 215 | "-Werror", | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 216 | ]`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 217 | "implementation_deps": `[":libc_headers"]`, | 
|  | 218 | "linkopts": `[ | 
| Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 219 | "-Wl,--exclude-libs=libgcc.a", | 
|  | 220 | "-Wl,--exclude-libs=libgcc_stripped.a", | 
|  | 221 | "-Wl,--exclude-libs=libclang_rt.builtins-arm-android.a", | 
|  | 222 | "-Wl,--exclude-libs=libclang_rt.builtins-aarch64-android.a", | 
|  | 223 | "-Wl,--exclude-libs=libclang_rt.builtins-i686-android.a", | 
|  | 224 | "-Wl,--exclude-libs=libclang_rt.builtins-x86_64-android.a", | 
|  | 225 | ] + select({ | 
| Jingwen Chen | b4628eb | 2021-04-08 14:40:57 +0000 | [diff] [blame] | 226 | "//build/bazel/platforms/arch:x86": ["-Wl,--exclude-libs=libgcc_eh.a"], | 
|  | 227 | "//build/bazel/platforms/arch:x86_64": ["-Wl,--exclude-libs=libgcc_eh.a"], | 
| Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 228 | "//conditions:default": [], | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 229 | })`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 230 | }), | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 231 | }) | 
|  | 232 | } | 
|  | 233 |  | 
|  | 234 | func TestCcLibraryExcludeSrcs(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 235 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 236 | Description:                "cc_library exclude_srcs - trimmed example of //external/arm-optimized-routines:libarm-optimized-routines-math", | 
|  | 237 | ModuleTypeUnderTest:        "cc_library", | 
|  | 238 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 239 | Dir:                        "external", | 
|  | 240 | Filesystem: map[string]string{ | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 241 | "external/math/cosf.c":      "", | 
|  | 242 | "external/math/erf.c":       "", | 
|  | 243 | "external/math/erf_data.c":  "", | 
|  | 244 | "external/math/erff.c":      "", | 
|  | 245 | "external/math/erff_data.c": "", | 
|  | 246 | "external/Android.bp": ` | 
| Jingwen Chen | 4ecc67d | 2021-04-27 09:47:02 +0000 | [diff] [blame] | 247 | cc_library { | 
|  | 248 | name: "fake-libarm-optimized-routines-math", | 
|  | 249 | exclude_srcs: [ | 
|  | 250 | // Provided by: | 
|  | 251 | // bionic/libm/upstream-freebsd/lib/msun/src/s_erf.c | 
|  | 252 | // bionic/libm/upstream-freebsd/lib/msun/src/s_erff.c | 
|  | 253 | "math/erf.c", | 
|  | 254 | "math/erf_data.c", | 
|  | 255 | "math/erff.c", | 
|  | 256 | "math/erff_data.c", | 
|  | 257 | ], | 
|  | 258 | srcs: [ | 
|  | 259 | "math/*.c", | 
|  | 260 | ], | 
|  | 261 | // arch-specific settings | 
|  | 262 | arch: { | 
|  | 263 | arm64: { | 
|  | 264 | cflags: [ | 
|  | 265 | "-DHAVE_FAST_FMA=1", | 
|  | 266 | ], | 
|  | 267 | }, | 
|  | 268 | }, | 
|  | 269 | bazel_module: { bp2build_available: true }, | 
|  | 270 | } | 
|  | 271 | `, | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 272 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 273 | Blueprint: soongCcLibraryPreamble, | 
|  | 274 | ExpectedBazelTargets: makeCcLibraryTargets("fake-libarm-optimized-routines-math", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 275 | "copts": `select({ | 
| Jingwen Chen | 4ecc67d | 2021-04-27 09:47:02 +0000 | [diff] [blame] | 276 | "//build/bazel/platforms/arch:arm64": ["-DHAVE_FAST_FMA=1"], | 
|  | 277 | "//conditions:default": [], | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 278 | })`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 279 | "local_includes": `["."]`, | 
|  | 280 | "srcs_c":         `["math/cosf.c"]`, | 
|  | 281 | }), | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 282 | }) | 
|  | 283 | } | 
|  | 284 |  | 
|  | 285 | func TestCcLibrarySharedStaticProps(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 286 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 287 | Description:                "cc_library shared/static props", | 
|  | 288 | ModuleTypeUnderTest:        "cc_library", | 
|  | 289 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 290 | Filesystem: map[string]string{ | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 291 | "both.cpp":       "", | 
|  | 292 | "sharedonly.cpp": "", | 
|  | 293 | "staticonly.cpp": "", | 
|  | 294 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 295 | Blueprint: soongCcLibraryPreamble + ` | 
| Jingwen Chen | 53681ef | 2021-04-29 08:15:13 +0000 | [diff] [blame] | 296 | cc_library { | 
|  | 297 | name: "a", | 
| Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 298 | srcs: ["both.cpp"], | 
|  | 299 | cflags: ["bothflag"], | 
|  | 300 | shared_libs: ["shared_dep_for_both"], | 
| Liz Kammer | cc2c1ef | 2022-03-21 09:03:29 -0400 | [diff] [blame] | 301 | static_libs: ["static_dep_for_both", "whole_and_static_lib_for_both"], | 
|  | 302 | whole_static_libs: ["whole_static_lib_for_both", "whole_and_static_lib_for_both"], | 
| Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 303 | static: { | 
|  | 304 | srcs: ["staticonly.cpp"], | 
|  | 305 | cflags: ["staticflag"], | 
|  | 306 | shared_libs: ["shared_dep_for_static"], | 
|  | 307 | static_libs: ["static_dep_for_static"], | 
|  | 308 | whole_static_libs: ["whole_static_lib_for_static"], | 
|  | 309 | }, | 
|  | 310 | shared: { | 
|  | 311 | srcs: ["sharedonly.cpp"], | 
|  | 312 | cflags: ["sharedflag"], | 
|  | 313 | shared_libs: ["shared_dep_for_shared"], | 
|  | 314 | static_libs: ["static_dep_for_shared"], | 
|  | 315 | whole_static_libs: ["whole_static_lib_for_shared"], | 
|  | 316 | }, | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 317 | include_build_directory: false, | 
| Jingwen Chen | 53681ef | 2021-04-29 08:15:13 +0000 | [diff] [blame] | 318 | } | 
|  | 319 |  | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 320 | cc_library_static { | 
|  | 321 | name: "static_dep_for_shared", | 
|  | 322 | bazel_module: { bp2build_available: false }, | 
|  | 323 | } | 
| Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 324 |  | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 325 | cc_library_static { | 
|  | 326 | name: "static_dep_for_static", | 
|  | 327 | bazel_module: { bp2build_available: false }, | 
|  | 328 | } | 
| Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 329 |  | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 330 | cc_library_static { | 
|  | 331 | name: "static_dep_for_both", | 
|  | 332 | bazel_module: { bp2build_available: false }, | 
|  | 333 | } | 
| Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 334 |  | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 335 | cc_library_static { | 
|  | 336 | name: "whole_static_lib_for_shared", | 
|  | 337 | bazel_module: { bp2build_available: false }, | 
|  | 338 | } | 
| Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 339 |  | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 340 | cc_library_static { | 
|  | 341 | name: "whole_static_lib_for_static", | 
|  | 342 | bazel_module: { bp2build_available: false }, | 
|  | 343 | } | 
| Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 344 |  | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 345 | cc_library_static { | 
|  | 346 | name: "whole_static_lib_for_both", | 
|  | 347 | bazel_module: { bp2build_available: false }, | 
|  | 348 | } | 
| Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 349 |  | 
| Liz Kammer | cc2c1ef | 2022-03-21 09:03:29 -0400 | [diff] [blame] | 350 | cc_library_static { | 
|  | 351 | name: "whole_and_static_lib_for_both", | 
|  | 352 | bazel_module: { bp2build_available: false }, | 
|  | 353 | } | 
|  | 354 |  | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 355 | cc_library { | 
|  | 356 | name: "shared_dep_for_shared", | 
|  | 357 | bazel_module: { bp2build_available: false }, | 
|  | 358 | } | 
| Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 359 |  | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 360 | cc_library { | 
|  | 361 | name: "shared_dep_for_static", | 
|  | 362 | bazel_module: { bp2build_available: false }, | 
|  | 363 | } | 
| Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 364 |  | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 365 | cc_library { | 
|  | 366 | name: "shared_dep_for_both", | 
|  | 367 | bazel_module: { bp2build_available: false }, | 
|  | 368 | } | 
| Jingwen Chen | 53681ef | 2021-04-29 08:15:13 +0000 | [diff] [blame] | 369 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 370 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 371 | MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 372 | "copts": `[ | 
|  | 373 | "bothflag", | 
|  | 374 | "staticflag", | 
|  | 375 | ]`, | 
|  | 376 | "implementation_deps": `[ | 
|  | 377 | ":static_dep_for_both", | 
|  | 378 | ":static_dep_for_static", | 
|  | 379 | ]`, | 
|  | 380 | "implementation_dynamic_deps": `[ | 
|  | 381 | ":shared_dep_for_both", | 
|  | 382 | ":shared_dep_for_static", | 
|  | 383 | ]`, | 
|  | 384 | "srcs": `[ | 
|  | 385 | "both.cpp", | 
|  | 386 | "staticonly.cpp", | 
|  | 387 | ]`, | 
|  | 388 | "whole_archive_deps": `[ | 
|  | 389 | ":whole_static_lib_for_both", | 
| Liz Kammer | cc2c1ef | 2022-03-21 09:03:29 -0400 | [diff] [blame] | 390 | ":whole_and_static_lib_for_both", | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 391 | ":whole_static_lib_for_static", | 
|  | 392 | ]`}), | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 393 | MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 394 | "copts": `[ | 
|  | 395 | "bothflag", | 
|  | 396 | "sharedflag", | 
|  | 397 | ]`, | 
|  | 398 | "implementation_deps": `[ | 
|  | 399 | ":static_dep_for_both", | 
|  | 400 | ":static_dep_for_shared", | 
|  | 401 | ]`, | 
|  | 402 | "implementation_dynamic_deps": `[ | 
|  | 403 | ":shared_dep_for_both", | 
|  | 404 | ":shared_dep_for_shared", | 
|  | 405 | ]`, | 
|  | 406 | "srcs": `[ | 
|  | 407 | "both.cpp", | 
|  | 408 | "sharedonly.cpp", | 
|  | 409 | ]`, | 
|  | 410 | "whole_archive_deps": `[ | 
|  | 411 | ":whole_static_lib_for_both", | 
| Liz Kammer | cc2c1ef | 2022-03-21 09:03:29 -0400 | [diff] [blame] | 412 | ":whole_and_static_lib_for_both", | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 413 | ":whole_static_lib_for_shared", | 
|  | 414 | ]`, | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 415 | }), | 
|  | 416 | }, | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 417 | }) | 
|  | 418 | } | 
|  | 419 |  | 
| Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 420 | func TestCcLibraryDeps(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 421 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 422 | Description:                "cc_library shared/static props", | 
|  | 423 | ModuleTypeUnderTest:        "cc_library", | 
|  | 424 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 425 | Filesystem: map[string]string{ | 
| Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 426 | "both.cpp":       "", | 
|  | 427 | "sharedonly.cpp": "", | 
|  | 428 | "staticonly.cpp": "", | 
|  | 429 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 430 | Blueprint: soongCcLibraryPreamble + ` | 
| Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 431 | cc_library { | 
|  | 432 | name: "a", | 
|  | 433 | srcs: ["both.cpp"], | 
|  | 434 | cflags: ["bothflag"], | 
|  | 435 | shared_libs: ["implementation_shared_dep_for_both", "shared_dep_for_both"], | 
|  | 436 | export_shared_lib_headers: ["shared_dep_for_both"], | 
|  | 437 | static_libs: ["implementation_static_dep_for_both", "static_dep_for_both"], | 
|  | 438 | export_static_lib_headers: ["static_dep_for_both", "whole_static_dep_for_both"], | 
|  | 439 | whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_both", "whole_static_dep_for_both"], | 
|  | 440 | static: { | 
|  | 441 | srcs: ["staticonly.cpp"], | 
|  | 442 | cflags: ["staticflag"], | 
|  | 443 | shared_libs: ["implementation_shared_dep_for_static", "shared_dep_for_static"], | 
|  | 444 | export_shared_lib_headers: ["shared_dep_for_static"], | 
|  | 445 | static_libs: ["implementation_static_dep_for_static", "static_dep_for_static"], | 
|  | 446 | export_static_lib_headers: ["static_dep_for_static", "whole_static_dep_for_static"], | 
|  | 447 | whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_static", "whole_static_dep_for_static"], | 
|  | 448 | }, | 
|  | 449 | shared: { | 
|  | 450 | srcs: ["sharedonly.cpp"], | 
|  | 451 | cflags: ["sharedflag"], | 
|  | 452 | shared_libs: ["implementation_shared_dep_for_shared", "shared_dep_for_shared"], | 
|  | 453 | export_shared_lib_headers: ["shared_dep_for_shared"], | 
|  | 454 | static_libs: ["implementation_static_dep_for_shared", "static_dep_for_shared"], | 
|  | 455 | export_static_lib_headers: ["static_dep_for_shared", "whole_static_dep_for_shared"], | 
|  | 456 | whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_shared", "whole_static_dep_for_shared"], | 
|  | 457 | }, | 
|  | 458 | include_build_directory: false, | 
|  | 459 | } | 
|  | 460 | ` + simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_shared") + | 
|  | 461 | simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_shared") + | 
|  | 462 | simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_static") + | 
|  | 463 | simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_static") + | 
|  | 464 | simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_both") + | 
|  | 465 | simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_both") + | 
|  | 466 | simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_shared") + | 
|  | 467 | simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_shared") + | 
|  | 468 | simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_static") + | 
|  | 469 | simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_static") + | 
|  | 470 | simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_both") + | 
|  | 471 | simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_both") + | 
|  | 472 | simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_shared") + | 
|  | 473 | simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_shared") + | 
|  | 474 | simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_static") + | 
|  | 475 | simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_static") + | 
|  | 476 | simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_both") + | 
|  | 477 | simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_both"), | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 478 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 479 | MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 480 | "copts": `[ | 
|  | 481 | "bothflag", | 
|  | 482 | "staticflag", | 
|  | 483 | ]`, | 
|  | 484 | "deps": `[ | 
|  | 485 | ":static_dep_for_both", | 
|  | 486 | ":static_dep_for_static", | 
|  | 487 | ]`, | 
|  | 488 | "dynamic_deps": `[ | 
|  | 489 | ":shared_dep_for_both", | 
|  | 490 | ":shared_dep_for_static", | 
|  | 491 | ]`, | 
|  | 492 | "implementation_deps": `[ | 
|  | 493 | ":implementation_static_dep_for_both", | 
|  | 494 | ":implementation_static_dep_for_static", | 
|  | 495 | ]`, | 
|  | 496 | "implementation_dynamic_deps": `[ | 
|  | 497 | ":implementation_shared_dep_for_both", | 
|  | 498 | ":implementation_shared_dep_for_static", | 
|  | 499 | ]`, | 
|  | 500 | "srcs": `[ | 
|  | 501 | "both.cpp", | 
|  | 502 | "staticonly.cpp", | 
|  | 503 | ]`, | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 504 | "whole_archive_deps": `[ | 
| Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 505 | ":not_explicitly_exported_whole_static_dep_for_both", | 
|  | 506 | ":whole_static_dep_for_both", | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 507 | ":not_explicitly_exported_whole_static_dep_for_static", | 
|  | 508 | ":whole_static_dep_for_static", | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 509 | ]`, | 
|  | 510 | }), | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 511 | MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 512 | "copts": `[ | 
|  | 513 | "bothflag", | 
|  | 514 | "sharedflag", | 
|  | 515 | ]`, | 
|  | 516 | "deps": `[ | 
|  | 517 | ":static_dep_for_both", | 
|  | 518 | ":static_dep_for_shared", | 
|  | 519 | ]`, | 
|  | 520 | "dynamic_deps": `[ | 
|  | 521 | ":shared_dep_for_both", | 
|  | 522 | ":shared_dep_for_shared", | 
|  | 523 | ]`, | 
|  | 524 | "implementation_deps": `[ | 
|  | 525 | ":implementation_static_dep_for_both", | 
|  | 526 | ":implementation_static_dep_for_shared", | 
|  | 527 | ]`, | 
|  | 528 | "implementation_dynamic_deps": `[ | 
|  | 529 | ":implementation_shared_dep_for_both", | 
|  | 530 | ":implementation_shared_dep_for_shared", | 
|  | 531 | ]`, | 
|  | 532 | "srcs": `[ | 
|  | 533 | "both.cpp", | 
|  | 534 | "sharedonly.cpp", | 
|  | 535 | ]`, | 
|  | 536 | "whole_archive_deps": `[ | 
|  | 537 | ":not_explicitly_exported_whole_static_dep_for_both", | 
|  | 538 | ":whole_static_dep_for_both", | 
|  | 539 | ":not_explicitly_exported_whole_static_dep_for_shared", | 
|  | 540 | ":whole_static_dep_for_shared", | 
|  | 541 | ]`, | 
|  | 542 | })}, | 
|  | 543 | }, | 
|  | 544 | ) | 
| Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 545 | } | 
|  | 546 |  | 
| Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 547 | func TestCcLibraryWholeStaticLibsAlwaysLink(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 548 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 549 | ModuleTypeUnderTest:        "cc_library", | 
|  | 550 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 551 | Dir:                        "foo/bar", | 
|  | 552 | Filesystem: map[string]string{ | 
| Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 553 | "foo/bar/Android.bp": ` | 
|  | 554 | cc_library { | 
|  | 555 | name: "a", | 
|  | 556 | whole_static_libs: ["whole_static_lib_for_both"], | 
|  | 557 | static: { | 
|  | 558 | whole_static_libs: ["whole_static_lib_for_static"], | 
|  | 559 | }, | 
|  | 560 | shared: { | 
|  | 561 | whole_static_libs: ["whole_static_lib_for_shared"], | 
|  | 562 | }, | 
|  | 563 | bazel_module: { bp2build_available: true }, | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 564 | include_build_directory: false, | 
| Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 565 | } | 
|  | 566 |  | 
|  | 567 | cc_prebuilt_library_static { name: "whole_static_lib_for_shared" } | 
|  | 568 |  | 
|  | 569 | cc_prebuilt_library_static { name: "whole_static_lib_for_static" } | 
|  | 570 |  | 
|  | 571 | cc_prebuilt_library_static { name: "whole_static_lib_for_both" } | 
|  | 572 | `, | 
|  | 573 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 574 | Blueprint: soongCcLibraryPreamble, | 
|  | 575 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 576 | MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 577 | "whole_archive_deps": `[ | 
|  | 578 | ":whole_static_lib_for_both_alwayslink", | 
|  | 579 | ":whole_static_lib_for_static_alwayslink", | 
|  | 580 | ]`, | 
|  | 581 | }), | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 582 | MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 583 | "whole_archive_deps": `[ | 
|  | 584 | ":whole_static_lib_for_both_alwayslink", | 
|  | 585 | ":whole_static_lib_for_shared_alwayslink", | 
|  | 586 | ]`, | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 587 | }), | 
|  | 588 | }, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 589 | }, | 
|  | 590 | ) | 
| Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 591 | } | 
|  | 592 |  | 
| Jingwen Chen | bcf5304 | 2021-05-26 04:42:42 +0000 | [diff] [blame] | 593 | func TestCcLibrarySharedStaticPropsInArch(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 594 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 595 | Description:                "cc_library shared/static props in arch", | 
|  | 596 | ModuleTypeUnderTest:        "cc_library", | 
|  | 597 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 598 | Dir:                        "foo/bar", | 
|  | 599 | Filesystem: map[string]string{ | 
| Jingwen Chen | bcf5304 | 2021-05-26 04:42:42 +0000 | [diff] [blame] | 600 | "foo/bar/arm.cpp":        "", | 
|  | 601 | "foo/bar/x86.cpp":        "", | 
|  | 602 | "foo/bar/sharedonly.cpp": "", | 
|  | 603 | "foo/bar/staticonly.cpp": "", | 
|  | 604 | "foo/bar/Android.bp": ` | 
|  | 605 | cc_library { | 
|  | 606 | name: "a", | 
|  | 607 | arch: { | 
|  | 608 | arm: { | 
|  | 609 | shared: { | 
|  | 610 | srcs: ["arm_shared.cpp"], | 
|  | 611 | cflags: ["-DARM_SHARED"], | 
|  | 612 | static_libs: ["arm_static_dep_for_shared"], | 
|  | 613 | whole_static_libs: ["arm_whole_static_dep_for_shared"], | 
|  | 614 | shared_libs: ["arm_shared_dep_for_shared"], | 
|  | 615 | }, | 
|  | 616 | }, | 
|  | 617 | x86: { | 
|  | 618 | static: { | 
|  | 619 | srcs: ["x86_static.cpp"], | 
|  | 620 | cflags: ["-DX86_STATIC"], | 
|  | 621 | static_libs: ["x86_dep_for_static"], | 
|  | 622 | }, | 
|  | 623 | }, | 
|  | 624 | }, | 
|  | 625 | target: { | 
|  | 626 | android: { | 
|  | 627 | shared: { | 
|  | 628 | srcs: ["android_shared.cpp"], | 
|  | 629 | cflags: ["-DANDROID_SHARED"], | 
|  | 630 | static_libs: ["android_dep_for_shared"], | 
|  | 631 | }, | 
|  | 632 | }, | 
|  | 633 | android_arm: { | 
|  | 634 | shared: { | 
|  | 635 | cflags: ["-DANDROID_ARM_SHARED"], | 
|  | 636 | }, | 
|  | 637 | }, | 
|  | 638 | }, | 
|  | 639 | srcs: ["both.cpp"], | 
|  | 640 | cflags: ["bothflag"], | 
|  | 641 | static_libs: ["static_dep_for_both"], | 
|  | 642 | static: { | 
|  | 643 | srcs: ["staticonly.cpp"], | 
|  | 644 | cflags: ["staticflag"], | 
|  | 645 | static_libs: ["static_dep_for_static"], | 
|  | 646 | }, | 
|  | 647 | shared: { | 
|  | 648 | srcs: ["sharedonly.cpp"], | 
|  | 649 | cflags: ["sharedflag"], | 
|  | 650 | static_libs: ["static_dep_for_shared"], | 
|  | 651 | }, | 
|  | 652 | bazel_module: { bp2build_available: true }, | 
|  | 653 | } | 
|  | 654 |  | 
|  | 655 | cc_library_static { name: "static_dep_for_shared" } | 
|  | 656 | cc_library_static { name: "static_dep_for_static" } | 
|  | 657 | cc_library_static { name: "static_dep_for_both" } | 
|  | 658 |  | 
|  | 659 | cc_library_static { name: "arm_static_dep_for_shared" } | 
|  | 660 | cc_library_static { name: "arm_whole_static_dep_for_shared" } | 
|  | 661 | cc_library_static { name: "arm_shared_dep_for_shared" } | 
|  | 662 |  | 
|  | 663 | cc_library_static { name: "x86_dep_for_static" } | 
|  | 664 |  | 
|  | 665 | cc_library_static { name: "android_dep_for_shared" } | 
|  | 666 | `, | 
|  | 667 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 668 | Blueprint: soongCcLibraryPreamble, | 
|  | 669 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 670 | MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 671 | "copts": `[ | 
|  | 672 | "bothflag", | 
|  | 673 | "staticflag", | 
|  | 674 | ] + select({ | 
|  | 675 | "//build/bazel/platforms/arch:x86": ["-DX86_STATIC"], | 
|  | 676 | "//conditions:default": [], | 
|  | 677 | })`, | 
|  | 678 | "implementation_deps": `[ | 
|  | 679 | ":static_dep_for_both", | 
|  | 680 | ":static_dep_for_static", | 
|  | 681 | ] + select({ | 
|  | 682 | "//build/bazel/platforms/arch:x86": [":x86_dep_for_static"], | 
|  | 683 | "//conditions:default": [], | 
|  | 684 | })`, | 
|  | 685 | "local_includes": `["."]`, | 
|  | 686 | "srcs": `[ | 
|  | 687 | "both.cpp", | 
|  | 688 | "staticonly.cpp", | 
|  | 689 | ] + select({ | 
|  | 690 | "//build/bazel/platforms/arch:x86": ["x86_static.cpp"], | 
|  | 691 | "//conditions:default": [], | 
|  | 692 | })`, | 
|  | 693 | }), | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 694 | MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 695 | "copts": `[ | 
|  | 696 | "bothflag", | 
|  | 697 | "sharedflag", | 
|  | 698 | ] + select({ | 
|  | 699 | "//build/bazel/platforms/arch:arm": ["-DARM_SHARED"], | 
|  | 700 | "//conditions:default": [], | 
|  | 701 | }) + select({ | 
|  | 702 | "//build/bazel/platforms/os:android": ["-DANDROID_SHARED"], | 
|  | 703 | "//conditions:default": [], | 
|  | 704 | }) + select({ | 
|  | 705 | "//build/bazel/platforms/os_arch:android_arm": ["-DANDROID_ARM_SHARED"], | 
|  | 706 | "//conditions:default": [], | 
|  | 707 | })`, | 
|  | 708 | "implementation_deps": `[ | 
|  | 709 | ":static_dep_for_both", | 
|  | 710 | ":static_dep_for_shared", | 
|  | 711 | ] + select({ | 
|  | 712 | "//build/bazel/platforms/arch:arm": [":arm_static_dep_for_shared"], | 
|  | 713 | "//conditions:default": [], | 
|  | 714 | }) + select({ | 
|  | 715 | "//build/bazel/platforms/os:android": [":android_dep_for_shared"], | 
|  | 716 | "//conditions:default": [], | 
|  | 717 | })`, | 
|  | 718 | "implementation_dynamic_deps": `select({ | 
|  | 719 | "//build/bazel/platforms/arch:arm": [":arm_shared_dep_for_shared"], | 
|  | 720 | "//conditions:default": [], | 
|  | 721 | })`, | 
|  | 722 | "local_includes": `["."]`, | 
|  | 723 | "srcs": `[ | 
|  | 724 | "both.cpp", | 
|  | 725 | "sharedonly.cpp", | 
|  | 726 | ] + select({ | 
|  | 727 | "//build/bazel/platforms/arch:arm": ["arm_shared.cpp"], | 
|  | 728 | "//conditions:default": [], | 
|  | 729 | }) + select({ | 
|  | 730 | "//build/bazel/platforms/os:android": ["android_shared.cpp"], | 
|  | 731 | "//conditions:default": [], | 
|  | 732 | })`, | 
|  | 733 | "whole_archive_deps": `select({ | 
|  | 734 | "//build/bazel/platforms/arch:arm": [":arm_whole_static_dep_for_shared"], | 
|  | 735 | "//conditions:default": [], | 
|  | 736 | })`, | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 737 | }), | 
|  | 738 | }, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 739 | }, | 
|  | 740 | ) | 
| Jingwen Chen | bcf5304 | 2021-05-26 04:42:42 +0000 | [diff] [blame] | 741 | } | 
|  | 742 |  | 
| Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 743 | func TestCcLibrarySharedStaticPropsWithMixedSources(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 744 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 745 | Description:                "cc_library shared/static props with c/cpp/s mixed sources", | 
|  | 746 | ModuleTypeUnderTest:        "cc_library", | 
|  | 747 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 748 | Dir:                        "foo/bar", | 
|  | 749 | Filesystem: map[string]string{ | 
| Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 750 | "foo/bar/both_source.cpp":   "", | 
|  | 751 | "foo/bar/both_source.cc":    "", | 
|  | 752 | "foo/bar/both_source.c":     "", | 
|  | 753 | "foo/bar/both_source.s":     "", | 
|  | 754 | "foo/bar/both_source.S":     "", | 
|  | 755 | "foo/bar/shared_source.cpp": "", | 
|  | 756 | "foo/bar/shared_source.cc":  "", | 
|  | 757 | "foo/bar/shared_source.c":   "", | 
|  | 758 | "foo/bar/shared_source.s":   "", | 
|  | 759 | "foo/bar/shared_source.S":   "", | 
|  | 760 | "foo/bar/static_source.cpp": "", | 
|  | 761 | "foo/bar/static_source.cc":  "", | 
|  | 762 | "foo/bar/static_source.c":   "", | 
|  | 763 | "foo/bar/static_source.s":   "", | 
|  | 764 | "foo/bar/static_source.S":   "", | 
|  | 765 | "foo/bar/Android.bp": ` | 
|  | 766 | cc_library { | 
|  | 767 | name: "a", | 
|  | 768 | srcs: [ | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 769 | "both_source.cpp", | 
|  | 770 | "both_source.cc", | 
|  | 771 | "both_source.c", | 
|  | 772 | "both_source.s", | 
|  | 773 | "both_source.S", | 
| Liz Kammer | 57e2e7a | 2021-09-20 12:55:02 -0400 | [diff] [blame] | 774 | ":both_filegroup", | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 775 | ], | 
| Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 776 | static: { | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 777 | srcs: [ | 
|  | 778 | "static_source.cpp", | 
|  | 779 | "static_source.cc", | 
|  | 780 | "static_source.c", | 
|  | 781 | "static_source.s", | 
|  | 782 | "static_source.S", | 
|  | 783 | ":static_filegroup", | 
|  | 784 | ], | 
| Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 785 | }, | 
|  | 786 | shared: { | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 787 | srcs: [ | 
|  | 788 | "shared_source.cpp", | 
|  | 789 | "shared_source.cc", | 
|  | 790 | "shared_source.c", | 
|  | 791 | "shared_source.s", | 
|  | 792 | "shared_source.S", | 
|  | 793 | ":shared_filegroup", | 
|  | 794 | ], | 
| Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 795 | }, | 
|  | 796 | bazel_module: { bp2build_available: true }, | 
|  | 797 | } | 
|  | 798 |  | 
|  | 799 | filegroup { | 
|  | 800 | name: "both_filegroup", | 
|  | 801 | srcs: [ | 
|  | 802 | // Not relevant, handled by filegroup macro | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 803 | ], | 
| Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 804 | } | 
|  | 805 |  | 
|  | 806 | filegroup { | 
|  | 807 | name: "shared_filegroup", | 
|  | 808 | srcs: [ | 
|  | 809 | // Not relevant, handled by filegroup macro | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 810 | ], | 
| Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 811 | } | 
|  | 812 |  | 
|  | 813 | filegroup { | 
|  | 814 | name: "static_filegroup", | 
|  | 815 | srcs: [ | 
|  | 816 | // Not relevant, handled by filegroup macro | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 817 | ], | 
| Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 818 | } | 
|  | 819 | `, | 
|  | 820 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 821 | Blueprint: soongCcLibraryPreamble, | 
|  | 822 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 823 | MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{ | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 824 | "local_includes": `["."]`, | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 825 | "srcs": `[ | 
| Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 826 | "both_source.cpp", | 
| Liz Kammer | 57e2e7a | 2021-09-20 12:55:02 -0400 | [diff] [blame] | 827 | "both_source.cc", | 
|  | 828 | ":both_filegroup_cpp_srcs", | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 829 | "static_source.cpp", | 
|  | 830 | "static_source.cc", | 
|  | 831 | ":static_filegroup_cpp_srcs", | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 832 | ]`, | 
|  | 833 | "srcs_as": `[ | 
| Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 834 | "both_source.s", | 
|  | 835 | "both_source.S", | 
|  | 836 | ":both_filegroup_as_srcs", | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 837 | "static_source.s", | 
|  | 838 | "static_source.S", | 
|  | 839 | ":static_filegroup_as_srcs", | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 840 | ]`, | 
|  | 841 | "srcs_c": `[ | 
| Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 842 | "both_source.c", | 
|  | 843 | ":both_filegroup_c_srcs", | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 844 | "static_source.c", | 
|  | 845 | ":static_filegroup_c_srcs", | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 846 | ]`, | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 847 | }), | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 848 | MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 849 | "local_includes": `["."]`, | 
|  | 850 | "srcs": `[ | 
|  | 851 | "both_source.cpp", | 
|  | 852 | "both_source.cc", | 
|  | 853 | ":both_filegroup_cpp_srcs", | 
|  | 854 | "shared_source.cpp", | 
|  | 855 | "shared_source.cc", | 
|  | 856 | ":shared_filegroup_cpp_srcs", | 
|  | 857 | ]`, | 
|  | 858 | "srcs_as": `[ | 
|  | 859 | "both_source.s", | 
|  | 860 | "both_source.S", | 
|  | 861 | ":both_filegroup_as_srcs", | 
|  | 862 | "shared_source.s", | 
|  | 863 | "shared_source.S", | 
|  | 864 | ":shared_filegroup_as_srcs", | 
|  | 865 | ]`, | 
|  | 866 | "srcs_c": `[ | 
|  | 867 | "both_source.c", | 
|  | 868 | ":both_filegroup_c_srcs", | 
|  | 869 | "shared_source.c", | 
|  | 870 | ":shared_filegroup_c_srcs", | 
|  | 871 | ]`, | 
|  | 872 | })}}) | 
| Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 873 | } | 
|  | 874 |  | 
| Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 875 | func TestCcLibraryNonConfiguredVersionScriptAndDynamicList(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 876 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
| Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 877 | Description:                "cc_library non-configured version script and dynamic list", | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 878 | ModuleTypeUnderTest:        "cc_library", | 
|  | 879 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 880 | Dir:                        "foo/bar", | 
|  | 881 | Filesystem: map[string]string{ | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 882 | "foo/bar/Android.bp": ` | 
| Lukacs T. Berki | 1353e59 | 2021-04-30 15:35:09 +0200 | [diff] [blame] | 883 | cc_library { | 
|  | 884 | name: "a", | 
|  | 885 | srcs: ["a.cpp"], | 
|  | 886 | version_script: "v.map", | 
| Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 887 | dynamic_list: "dynamic.list", | 
| Lukacs T. Berki | 1353e59 | 2021-04-30 15:35:09 +0200 | [diff] [blame] | 888 | bazel_module: { bp2build_available: true }, | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 889 | include_build_directory: false, | 
| Lukacs T. Berki | 1353e59 | 2021-04-30 15:35:09 +0200 | [diff] [blame] | 890 | } | 
|  | 891 | `, | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 892 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 893 | Blueprint: soongCcLibraryPreamble, | 
|  | 894 | ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{ | 
| Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 895 | "additional_linker_inputs": `[ | 
|  | 896 | "v.map", | 
|  | 897 | "dynamic.list", | 
|  | 898 | ]`, | 
|  | 899 | "linkopts": `[ | 
|  | 900 | "-Wl,--version-script,$(location v.map)", | 
|  | 901 | "-Wl,--dynamic-list,$(location dynamic.list)", | 
|  | 902 | ]`, | 
| Trevor Radcliffe | f06dd91 | 2023-05-19 14:51:41 +0000 | [diff] [blame] | 903 | "srcs":     `["a.cpp"]`, | 
|  | 904 | "features": `["android_cfi_exports_map"]`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 905 | }), | 
|  | 906 | }, | 
|  | 907 | ) | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 908 | } | 
|  | 909 |  | 
| Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 910 | func TestCcLibraryConfiguredVersionScriptAndDynamicList(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 911 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
| Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 912 | Description:                "cc_library configured version script and dynamic list", | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 913 | ModuleTypeUnderTest:        "cc_library", | 
|  | 914 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 915 | Dir:                        "foo/bar", | 
|  | 916 | Filesystem: map[string]string{ | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 917 | "foo/bar/Android.bp": ` | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 918 | cc_library { | 
|  | 919 | name: "a", | 
|  | 920 | srcs: ["a.cpp"], | 
|  | 921 | arch: { | 
|  | 922 | arm: { | 
|  | 923 | version_script: "arm.map", | 
| Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 924 | dynamic_list: "dynamic_arm.list", | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 925 | }, | 
|  | 926 | arm64: { | 
|  | 927 | version_script: "arm64.map", | 
| Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 928 | dynamic_list: "dynamic_arm64.list", | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 929 | }, | 
|  | 930 | }, | 
| Lukacs T. Berki | 56bb083 | 2021-05-12 12:36:45 +0200 | [diff] [blame] | 931 |  | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 932 | bazel_module: { bp2build_available: true }, | 
|  | 933 | include_build_directory: false, | 
|  | 934 | } | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 935 | `, | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 936 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 937 | Blueprint: soongCcLibraryPreamble, | 
|  | 938 | ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 939 | "additional_linker_inputs": `select({ | 
| Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 940 | "//build/bazel/platforms/arch:arm": [ | 
|  | 941 | "arm.map", | 
|  | 942 | "dynamic_arm.list", | 
|  | 943 | ], | 
|  | 944 | "//build/bazel/platforms/arch:arm64": [ | 
|  | 945 | "arm64.map", | 
|  | 946 | "dynamic_arm64.list", | 
|  | 947 | ], | 
| Liz Kammer | d287118 | 2021-10-04 13:54:37 -0400 | [diff] [blame] | 948 | "//conditions:default": [], | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 949 | })`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 950 | "linkopts": `select({ | 
| Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 951 | "//build/bazel/platforms/arch:arm": [ | 
|  | 952 | "-Wl,--version-script,$(location arm.map)", | 
|  | 953 | "-Wl,--dynamic-list,$(location dynamic_arm.list)", | 
|  | 954 | ], | 
|  | 955 | "//build/bazel/platforms/arch:arm64": [ | 
|  | 956 | "-Wl,--version-script,$(location arm64.map)", | 
|  | 957 | "-Wl,--dynamic-list,$(location dynamic_arm64.list)", | 
|  | 958 | ], | 
| Liz Kammer | d287118 | 2021-10-04 13:54:37 -0400 | [diff] [blame] | 959 | "//conditions:default": [], | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 960 | })`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 961 | "srcs": `["a.cpp"]`, | 
| Trevor Radcliffe | f06dd91 | 2023-05-19 14:51:41 +0000 | [diff] [blame] | 962 | "features": `select({ | 
|  | 963 | "//build/bazel/platforms/arch:arm": ["android_cfi_exports_map"], | 
|  | 964 | "//build/bazel/platforms/arch:arm64": ["android_cfi_exports_map"], | 
|  | 965 | "//conditions:default": [], | 
|  | 966 | })`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 967 | }), | 
|  | 968 | }, | 
|  | 969 | ) | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 970 | } | 
|  | 971 |  | 
| Trevor Radcliffe | ea6a45d | 2022-09-20 18:58:01 +0000 | [diff] [blame] | 972 | func TestCcLibraryLdflagsSplitBySpaceExceptSoongAdded(t *testing.T) { | 
|  | 973 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 974 | Description:                "ldflags are split by spaces except for the ones added by soong (version script and dynamic list)", | 
|  | 975 | ModuleTypeUnderTest:        "cc_library", | 
|  | 976 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 977 | Filesystem: map[string]string{ | 
|  | 978 | "version_script": "", | 
|  | 979 | "dynamic.list":   "", | 
|  | 980 | }, | 
|  | 981 | Blueprint: ` | 
|  | 982 | cc_library { | 
|  | 983 | name: "foo", | 
|  | 984 | ldflags: [ | 
|  | 985 | "--nospace_flag", | 
|  | 986 | "-z spaceflag", | 
|  | 987 | ], | 
|  | 988 | version_script: "version_script", | 
|  | 989 | dynamic_list: "dynamic.list", | 
|  | 990 | include_build_directory: false, | 
|  | 991 | } | 
|  | 992 | `, | 
|  | 993 | ExpectedBazelTargets: []string{ | 
| Trevor Radcliffe | f06dd91 | 2023-05-19 14:51:41 +0000 | [diff] [blame] | 994 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 995 | "features": `["android_cfi_exports_map"]`, | 
|  | 996 | }), | 
| Trevor Radcliffe | ea6a45d | 2022-09-20 18:58:01 +0000 | [diff] [blame] | 997 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 998 | "additional_linker_inputs": `[ | 
|  | 999 | "version_script", | 
|  | 1000 | "dynamic.list", | 
|  | 1001 | ]`, | 
| Trevor Radcliffe | f06dd91 | 2023-05-19 14:51:41 +0000 | [diff] [blame] | 1002 | "features": `["android_cfi_exports_map"]`, | 
| Trevor Radcliffe | ea6a45d | 2022-09-20 18:58:01 +0000 | [diff] [blame] | 1003 | "linkopts": `[ | 
|  | 1004 | "--nospace_flag", | 
|  | 1005 | "-z", | 
|  | 1006 | "spaceflag", | 
|  | 1007 | "-Wl,--version-script,$(location version_script)", | 
|  | 1008 | "-Wl,--dynamic-list,$(location dynamic.list)", | 
|  | 1009 | ]`, | 
|  | 1010 | }), | 
|  | 1011 | }, | 
|  | 1012 | }) | 
|  | 1013 | } | 
|  | 1014 |  | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 1015 | func TestCcLibrarySharedLibs(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1016 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1017 | Description:                "cc_library shared_libs", | 
|  | 1018 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1019 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1020 | Blueprint: soongCcLibraryPreamble + ` | 
| Rupert Shuttleworth | c50fa8d | 2021-05-06 02:40:33 -0400 | [diff] [blame] | 1021 | cc_library { | 
|  | 1022 | name: "mylib", | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1023 | bazel_module: { bp2build_available: false }, | 
| Rupert Shuttleworth | c50fa8d | 2021-05-06 02:40:33 -0400 | [diff] [blame] | 1024 | } | 
|  | 1025 |  | 
|  | 1026 | cc_library { | 
|  | 1027 | name: "a", | 
|  | 1028 | shared_libs: ["mylib",], | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1029 | include_build_directory: false, | 
| Rupert Shuttleworth | c50fa8d | 2021-05-06 02:40:33 -0400 | [diff] [blame] | 1030 | } | 
|  | 1031 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1032 | ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1033 | "implementation_dynamic_deps": `[":mylib"]`, | 
|  | 1034 | }), | 
|  | 1035 | }, | 
|  | 1036 | ) | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 1037 | } | 
|  | 1038 |  | 
| Liz Kammer | 0eae52e | 2021-10-06 10:32:26 -0400 | [diff] [blame] | 1039 | func TestCcLibraryFeatures(t *testing.T) { | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1040 | expected_targets := []string{} | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1041 | expected_targets = append(expected_targets, makeCcLibraryTargets("a", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1042 | "features": `[ | 
|  | 1043 | "disable_pack_relocations", | 
|  | 1044 | "-no_undefined_symbols", | 
|  | 1045 | ]`, | 
| Yu Liu | f01a0f0 | 2022-12-07 15:45:30 -0800 | [diff] [blame] | 1046 | "native_coverage": `False`, | 
|  | 1047 | "srcs":            `["a.cpp"]`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1048 | })...) | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1049 | expected_targets = append(expected_targets, makeCcLibraryTargets("b", AttrNameToString{ | 
| Yu Liu | f01a0f0 | 2022-12-07 15:45:30 -0800 | [diff] [blame] | 1050 | "features": `select({ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1051 | "//build/bazel/platforms/arch:x86_64": [ | 
|  | 1052 | "disable_pack_relocations", | 
|  | 1053 | "-no_undefined_symbols", | 
|  | 1054 | ], | 
|  | 1055 | "//conditions:default": [], | 
|  | 1056 | })`, | 
| Yu Liu | f01a0f0 | 2022-12-07 15:45:30 -0800 | [diff] [blame] | 1057 | "native_coverage": `False`, | 
|  | 1058 | "srcs":            `["b.cpp"]`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1059 | })...) | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1060 | expected_targets = append(expected_targets, makeCcLibraryTargets("c", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1061 | "features": `select({ | 
|  | 1062 | "//build/bazel/platforms/os:darwin": [ | 
|  | 1063 | "disable_pack_relocations", | 
|  | 1064 | "-no_undefined_symbols", | 
|  | 1065 | ], | 
|  | 1066 | "//conditions:default": [], | 
|  | 1067 | })`, | 
|  | 1068 | "srcs": `["c.cpp"]`, | 
|  | 1069 | })...) | 
|  | 1070 |  | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1071 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1072 | Description:                "cc_library pack_relocations test", | 
|  | 1073 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1074 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1075 | Blueprint: soongCcLibraryPreamble + ` | 
| Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1076 | cc_library { | 
|  | 1077 | name: "a", | 
|  | 1078 | srcs: ["a.cpp"], | 
|  | 1079 | pack_relocations: false, | 
| Liz Kammer | 0eae52e | 2021-10-06 10:32:26 -0400 | [diff] [blame] | 1080 | allow_undefined_symbols: true, | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1081 | include_build_directory: false, | 
| Yu Liu | 8d82ac5 | 2022-05-17 15:13:28 -0700 | [diff] [blame] | 1082 | native_coverage: false, | 
| Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1083 | } | 
|  | 1084 |  | 
|  | 1085 | cc_library { | 
|  | 1086 | name: "b", | 
|  | 1087 | srcs: ["b.cpp"], | 
|  | 1088 | arch: { | 
|  | 1089 | x86_64: { | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1090 | pack_relocations: false, | 
| Liz Kammer | 0eae52e | 2021-10-06 10:32:26 -0400 | [diff] [blame] | 1091 | allow_undefined_symbols: true, | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1092 | }, | 
| Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1093 | }, | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1094 | include_build_directory: false, | 
| Yu Liu | 8d82ac5 | 2022-05-17 15:13:28 -0700 | [diff] [blame] | 1095 | native_coverage: false, | 
| Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1096 | } | 
|  | 1097 |  | 
|  | 1098 | cc_library { | 
|  | 1099 | name: "c", | 
|  | 1100 | srcs: ["c.cpp"], | 
|  | 1101 | target: { | 
|  | 1102 | darwin: { | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1103 | pack_relocations: false, | 
| Liz Kammer | 0eae52e | 2021-10-06 10:32:26 -0400 | [diff] [blame] | 1104 | allow_undefined_symbols: true, | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1105 | }, | 
| Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1106 | }, | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1107 | include_build_directory: false, | 
| Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1108 | }`, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1109 | ExpectedBazelTargets: expected_targets, | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 1110 | }) | 
|  | 1111 | } | 
|  | 1112 |  | 
|  | 1113 | func TestCcLibrarySpacesInCopts(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1114 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1115 | Description:                "cc_library spaces in copts", | 
|  | 1116 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1117 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1118 | Blueprint: soongCcLibraryPreamble + ` | 
| Jingwen Chen | 3950cd6 | 2021-05-12 04:33:00 +0000 | [diff] [blame] | 1119 | cc_library { | 
|  | 1120 | name: "a", | 
|  | 1121 | cflags: ["-include header.h",], | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1122 | include_build_directory: false, | 
| Jingwen Chen | 3950cd6 | 2021-05-12 04:33:00 +0000 | [diff] [blame] | 1123 | } | 
|  | 1124 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1125 | ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1126 | "copts": `[ | 
| Jingwen Chen | 3950cd6 | 2021-05-12 04:33:00 +0000 | [diff] [blame] | 1127 | "-include", | 
|  | 1128 | "header.h", | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1129 | ]`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1130 | }), | 
|  | 1131 | }, | 
|  | 1132 | ) | 
| Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 1133 | } | 
|  | 1134 |  | 
|  | 1135 | func TestCcLibraryCppFlagsGoesIntoCopts(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1136 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1137 | Description:                "cc_library cppflags usage", | 
|  | 1138 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1139 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1140 | Blueprint: soongCcLibraryPreamble + `cc_library { | 
| Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1141 | name: "a", | 
|  | 1142 | srcs: ["a.cpp"], | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1143 | cflags: ["-Wall"], | 
| Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1144 | cppflags: [ | 
|  | 1145 | "-fsigned-char", | 
|  | 1146 | "-pedantic", | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1147 | ], | 
| Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1148 | arch: { | 
|  | 1149 | arm64: { | 
|  | 1150 | cppflags: ["-DARM64=1"], | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1151 | }, | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1152 | }, | 
| Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1153 | target: { | 
|  | 1154 | android: { | 
|  | 1155 | cppflags: ["-DANDROID=1"], | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1156 | }, | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1157 | }, | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1158 | include_build_directory: false, | 
| Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1159 | } | 
|  | 1160 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1161 | ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1162 | "copts": `["-Wall"]`, | 
|  | 1163 | "cppflags": `[ | 
| Chris Parsons | 990c4f4 | 2021-05-25 12:10:58 -0400 | [diff] [blame] | 1164 | "-fsigned-char", | 
|  | 1165 | "-pedantic", | 
| Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1166 | ] + select({ | 
|  | 1167 | "//build/bazel/platforms/arch:arm64": ["-DARM64=1"], | 
|  | 1168 | "//conditions:default": [], | 
|  | 1169 | }) + select({ | 
|  | 1170 | "//build/bazel/platforms/os:android": ["-DANDROID=1"], | 
|  | 1171 | "//conditions:default": [], | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1172 | })`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1173 | "srcs": `["a.cpp"]`, | 
|  | 1174 | }), | 
|  | 1175 | }, | 
|  | 1176 | ) | 
| Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 1177 | } | 
| Rupert Shuttleworth | 22cd2eb | 2021-05-27 02:15:54 -0400 | [diff] [blame] | 1178 |  | 
| Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1179 | func TestCcLibraryExcludeLibs(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1180 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1181 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1182 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1183 | Filesystem:                 map[string]string{}, | 
|  | 1184 | Blueprint: soongCcLibraryStaticPreamble + ` | 
| Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1185 | cc_library { | 
|  | 1186 | name: "foo_static", | 
|  | 1187 | srcs: ["common.c"], | 
|  | 1188 | whole_static_libs: [ | 
|  | 1189 | "arm_whole_static_lib_excludes", | 
|  | 1190 | "malloc_not_svelte_whole_static_lib_excludes" | 
|  | 1191 | ], | 
|  | 1192 | static_libs: [ | 
|  | 1193 | "arm_static_lib_excludes", | 
|  | 1194 | "malloc_not_svelte_static_lib_excludes" | 
|  | 1195 | ], | 
|  | 1196 | shared_libs: [ | 
|  | 1197 | "arm_shared_lib_excludes", | 
|  | 1198 | ], | 
|  | 1199 | arch: { | 
|  | 1200 | arm: { | 
|  | 1201 | exclude_shared_libs: [ | 
|  | 1202 | "arm_shared_lib_excludes", | 
|  | 1203 | ], | 
|  | 1204 | exclude_static_libs: [ | 
|  | 1205 | "arm_static_lib_excludes", | 
|  | 1206 | "arm_whole_static_lib_excludes", | 
|  | 1207 | ], | 
|  | 1208 | }, | 
|  | 1209 | }, | 
|  | 1210 | product_variables: { | 
|  | 1211 | malloc_not_svelte: { | 
|  | 1212 | shared_libs: ["malloc_not_svelte_shared_lib"], | 
|  | 1213 | whole_static_libs: ["malloc_not_svelte_whole_static_lib"], | 
|  | 1214 | exclude_static_libs: [ | 
|  | 1215 | "malloc_not_svelte_static_lib_excludes", | 
|  | 1216 | "malloc_not_svelte_whole_static_lib_excludes", | 
|  | 1217 | ], | 
|  | 1218 | }, | 
|  | 1219 | }, | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1220 | include_build_directory: false, | 
| Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1221 | } | 
|  | 1222 |  | 
|  | 1223 | cc_library { | 
|  | 1224 | name: "arm_whole_static_lib_excludes", | 
|  | 1225 | bazel_module: { bp2build_available: false }, | 
|  | 1226 | } | 
|  | 1227 |  | 
|  | 1228 | cc_library { | 
|  | 1229 | name: "malloc_not_svelte_whole_static_lib", | 
|  | 1230 | bazel_module: { bp2build_available: false }, | 
|  | 1231 | } | 
|  | 1232 |  | 
|  | 1233 | cc_library { | 
|  | 1234 | name: "malloc_not_svelte_whole_static_lib_excludes", | 
|  | 1235 | bazel_module: { bp2build_available: false }, | 
|  | 1236 | } | 
|  | 1237 |  | 
|  | 1238 | cc_library { | 
|  | 1239 | name: "arm_static_lib_excludes", | 
|  | 1240 | bazel_module: { bp2build_available: false }, | 
|  | 1241 | } | 
|  | 1242 |  | 
|  | 1243 | cc_library { | 
|  | 1244 | name: "malloc_not_svelte_static_lib_excludes", | 
|  | 1245 | bazel_module: { bp2build_available: false }, | 
|  | 1246 | } | 
|  | 1247 |  | 
|  | 1248 | cc_library { | 
|  | 1249 | name: "arm_shared_lib_excludes", | 
|  | 1250 | bazel_module: { bp2build_available: false }, | 
|  | 1251 | } | 
|  | 1252 |  | 
|  | 1253 | cc_library { | 
|  | 1254 | name: "malloc_not_svelte_shared_lib", | 
|  | 1255 | bazel_module: { bp2build_available: false }, | 
|  | 1256 | } | 
|  | 1257 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1258 | ExpectedBazelTargets: makeCcLibraryTargets("foo_static", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1259 | "implementation_deps": `select({ | 
| Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1260 | "//build/bazel/platforms/arch:arm": [], | 
| Chris Parsons | 953b356 | 2021-09-20 15:14:39 -0400 | [diff] [blame] | 1261 | "//conditions:default": [":arm_static_lib_excludes_bp2build_cc_library_static"], | 
| Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1262 | }) + select({ | 
| Cole Faust | 87c0c33 | 2023-07-31 12:10:12 -0700 | [diff] [blame] | 1263 | "//build/bazel/product_config/config_settings:malloc_not_svelte": [], | 
| Chris Parsons | 953b356 | 2021-09-20 15:14:39 -0400 | [diff] [blame] | 1264 | "//conditions:default": [":malloc_not_svelte_static_lib_excludes_bp2build_cc_library_static"], | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1265 | })`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1266 | "implementation_dynamic_deps": `select({ | 
| Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 1267 | "//build/bazel/platforms/arch:arm": [], | 
|  | 1268 | "//conditions:default": [":arm_shared_lib_excludes"], | 
|  | 1269 | }) + select({ | 
| Cole Faust | 87c0c33 | 2023-07-31 12:10:12 -0700 | [diff] [blame] | 1270 | "//build/bazel/product_config/config_settings:malloc_not_svelte": [":malloc_not_svelte_shared_lib"], | 
| Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 1271 | "//conditions:default": [], | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1272 | })`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1273 | "srcs_c": `["common.c"]`, | 
|  | 1274 | "whole_archive_deps": `select({ | 
| Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1275 | "//build/bazel/platforms/arch:arm": [], | 
| Chris Parsons | 953b356 | 2021-09-20 15:14:39 -0400 | [diff] [blame] | 1276 | "//conditions:default": [":arm_whole_static_lib_excludes_bp2build_cc_library_static"], | 
| Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1277 | }) + select({ | 
| Cole Faust | 87c0c33 | 2023-07-31 12:10:12 -0700 | [diff] [blame] | 1278 | "//build/bazel/product_config/config_settings:malloc_not_svelte": [":malloc_not_svelte_whole_static_lib_bp2build_cc_library_static"], | 
| Chris Parsons | 953b356 | 2021-09-20 15:14:39 -0400 | [diff] [blame] | 1279 | "//conditions:default": [":malloc_not_svelte_whole_static_lib_excludes_bp2build_cc_library_static"], | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1280 | })`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1281 | }), | 
|  | 1282 | }, | 
|  | 1283 | ) | 
| Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1284 | } | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1285 |  | 
| Zi Wang | 0a8a129 | 2022-08-30 06:27:01 +0000 | [diff] [blame] | 1286 | func TestCcLibraryProductVariablesHeaderLibs(t *testing.T) { | 
|  | 1287 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1288 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1289 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1290 | Filesystem:                 map[string]string{}, | 
|  | 1291 | Blueprint: soongCcLibraryStaticPreamble + ` | 
|  | 1292 | cc_library { | 
|  | 1293 | name: "foo_static", | 
|  | 1294 | srcs: ["common.c"], | 
|  | 1295 | product_variables: { | 
|  | 1296 | malloc_not_svelte: { | 
|  | 1297 | header_libs: ["malloc_not_svelte_header_lib"], | 
|  | 1298 | }, | 
|  | 1299 | }, | 
|  | 1300 | include_build_directory: false, | 
|  | 1301 | } | 
|  | 1302 |  | 
|  | 1303 | cc_library { | 
|  | 1304 | name: "malloc_not_svelte_header_lib", | 
|  | 1305 | bazel_module: { bp2build_available: false }, | 
|  | 1306 | } | 
|  | 1307 | `, | 
|  | 1308 | ExpectedBazelTargets: makeCcLibraryTargets("foo_static", AttrNameToString{ | 
|  | 1309 | "implementation_deps": `select({ | 
| Cole Faust | 87c0c33 | 2023-07-31 12:10:12 -0700 | [diff] [blame] | 1310 | "//build/bazel/product_config/config_settings:malloc_not_svelte": [":malloc_not_svelte_header_lib"], | 
| Zi Wang | 0a8a129 | 2022-08-30 06:27:01 +0000 | [diff] [blame] | 1311 | "//conditions:default": [], | 
|  | 1312 | })`, | 
|  | 1313 | "srcs_c":                 `["common.c"]`, | 
|  | 1314 | "target_compatible_with": `["//build/bazel/platforms/os:android"]`, | 
|  | 1315 | }), | 
|  | 1316 | }, | 
|  | 1317 | ) | 
|  | 1318 | } | 
|  | 1319 |  | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1320 | func TestCCLibraryNoCrtTrue(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1321 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
| Alex Márquez Pérez Muñíz Díaz Puras Thaureaux | 01ec55e | 2023-01-30 22:53:04 +0000 | [diff] [blame] | 1322 | Description:                "cc_library - nocrt: true disables feature", | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1323 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1324 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1325 | Filesystem: map[string]string{ | 
| Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1326 | "impl.cpp": "", | 
|  | 1327 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1328 | Blueprint: soongCcLibraryPreamble + ` | 
| Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1329 | cc_library { | 
|  | 1330 | name: "foo-lib", | 
|  | 1331 | srcs: ["impl.cpp"], | 
|  | 1332 | nocrt: true, | 
|  | 1333 | include_build_directory: false, | 
|  | 1334 | } | 
|  | 1335 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1336 | ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{ | 
| Alex Márquez Pérez Muñíz Díaz Puras Thaureaux | 01ec55e | 2023-01-30 22:53:04 +0000 | [diff] [blame] | 1337 | "features": `["-link_crt"]`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1338 | "srcs":     `["impl.cpp"]`, | 
|  | 1339 | }), | 
|  | 1340 | }, | 
|  | 1341 | ) | 
| Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1342 | } | 
|  | 1343 |  | 
|  | 1344 | func TestCCLibraryNoCrtFalse(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1345 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1346 | Description:                "cc_library - nocrt: false - does not emit attribute", | 
|  | 1347 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1348 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1349 | Filesystem: map[string]string{ | 
| Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1350 | "impl.cpp": "", | 
|  | 1351 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1352 | Blueprint: soongCcLibraryPreamble + ` | 
| Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1353 | cc_library { | 
|  | 1354 | name: "foo-lib", | 
|  | 1355 | srcs: ["impl.cpp"], | 
|  | 1356 | nocrt: false, | 
|  | 1357 | include_build_directory: false, | 
|  | 1358 | } | 
|  | 1359 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1360 | ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1361 | "srcs": `["impl.cpp"]`, | 
|  | 1362 | }), | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1363 | }) | 
| Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1364 | } | 
|  | 1365 |  | 
|  | 1366 | func TestCCLibraryNoCrtArchVariant(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1367 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1368 | Description:                "cc_library - nocrt in select", | 
|  | 1369 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1370 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1371 | Filesystem: map[string]string{ | 
| Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1372 | "impl.cpp": "", | 
|  | 1373 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1374 | Blueprint: soongCcLibraryPreamble + ` | 
| Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1375 | cc_library { | 
|  | 1376 | name: "foo-lib", | 
|  | 1377 | srcs: ["impl.cpp"], | 
|  | 1378 | arch: { | 
|  | 1379 | arm: { | 
|  | 1380 | nocrt: true, | 
|  | 1381 | }, | 
|  | 1382 | x86: { | 
|  | 1383 | nocrt: false, | 
|  | 1384 | }, | 
|  | 1385 | }, | 
|  | 1386 | include_build_directory: false, | 
|  | 1387 | } | 
|  | 1388 | `, | 
| Alex Márquez Pérez Muñíz Díaz Puras Thaureaux | 01ec55e | 2023-01-30 22:53:04 +0000 | [diff] [blame] | 1389 | ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{ | 
|  | 1390 | "features": `select({ | 
|  | 1391 | "//build/bazel/platforms/arch:arm": ["-link_crt"], | 
|  | 1392 | "//conditions:default": [], | 
|  | 1393 | })`, | 
|  | 1394 | "srcs": `["impl.cpp"]`, | 
|  | 1395 | }), | 
| Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1396 | }) | 
|  | 1397 | } | 
|  | 1398 |  | 
|  | 1399 | func TestCCLibraryNoLibCrtTrue(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1400 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1401 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1402 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1403 | Filesystem: map[string]string{ | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1404 | "impl.cpp": "", | 
|  | 1405 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1406 | Blueprint: soongCcLibraryPreamble + ` | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1407 | cc_library { | 
|  | 1408 | name: "foo-lib", | 
|  | 1409 | srcs: ["impl.cpp"], | 
|  | 1410 | no_libcrt: true, | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1411 | include_build_directory: false, | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1412 | } | 
|  | 1413 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1414 | ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{ | 
| Alex Márquez Pérez Muñíz Díaz Puras Thaureaux | 01ec55e | 2023-01-30 22:53:04 +0000 | [diff] [blame] | 1415 | "features": `["-use_libcrt"]`, | 
|  | 1416 | "srcs":     `["impl.cpp"]`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1417 | }), | 
|  | 1418 | }) | 
|  | 1419 | } | 
|  | 1420 |  | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1421 | func makeCcLibraryTargets(name string, attrs AttrNameToString) []string { | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1422 | STATIC_ONLY_ATTRS := map[string]bool{} | 
|  | 1423 | SHARED_ONLY_ATTRS := map[string]bool{ | 
|  | 1424 | "link_crt":                 true, | 
|  | 1425 | "additional_linker_inputs": true, | 
|  | 1426 | "linkopts":                 true, | 
|  | 1427 | "strip":                    true, | 
| Yu Liu | 75be7b9 | 2022-02-01 09:54:09 -0800 | [diff] [blame] | 1428 | "inject_bssl_hash":         true, | 
| Yu Liu | 56ccb1a | 2022-11-12 10:47:07 -0800 | [diff] [blame] | 1429 | "stubs_symbol_file":        true, | 
| Liz Kammer | baced71 | 2022-09-16 09:01:29 -0400 | [diff] [blame] | 1430 | "use_version_lib":          true, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1431 | } | 
| Wei Li | 81852ca | 2022-07-27 00:22:06 -0700 | [diff] [blame] | 1432 |  | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1433 | sharedAttrs := AttrNameToString{} | 
|  | 1434 | staticAttrs := AttrNameToString{} | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1435 | for key, val := range attrs { | 
|  | 1436 | if _, staticOnly := STATIC_ONLY_ATTRS[key]; !staticOnly { | 
|  | 1437 | sharedAttrs[key] = val | 
|  | 1438 | } | 
|  | 1439 | if _, sharedOnly := SHARED_ONLY_ATTRS[key]; !sharedOnly { | 
|  | 1440 | staticAttrs[key] = val | 
|  | 1441 | } | 
|  | 1442 | } | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 1443 | sharedTarget := MakeBazelTarget("cc_library_shared", name, sharedAttrs) | 
|  | 1444 | staticTarget := MakeBazelTarget("cc_library_static", name+"_bp2build_cc_library_static", staticAttrs) | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1445 |  | 
|  | 1446 | return []string{staticTarget, sharedTarget} | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1447 | } | 
|  | 1448 |  | 
| Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1449 | func TestCCLibraryNoLibCrtFalse(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1450 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1451 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1452 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1453 | Filesystem: map[string]string{ | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1454 | "impl.cpp": "", | 
|  | 1455 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1456 | Blueprint: soongCcLibraryPreamble + ` | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1457 | cc_library { | 
|  | 1458 | name: "foo-lib", | 
|  | 1459 | srcs: ["impl.cpp"], | 
|  | 1460 | no_libcrt: false, | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1461 | include_build_directory: false, | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1462 | } | 
|  | 1463 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1464 | ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{ | 
| Alex Márquez Pérez Muñíz Díaz Puras Thaureaux | 01ec55e | 2023-01-30 22:53:04 +0000 | [diff] [blame] | 1465 | "srcs": `["impl.cpp"]`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1466 | }), | 
|  | 1467 | }) | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1468 | } | 
|  | 1469 |  | 
| Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1470 | func TestCCLibraryNoLibCrtArchVariant(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1471 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1472 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1473 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1474 | Filesystem: map[string]string{ | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1475 | "impl.cpp": "", | 
|  | 1476 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1477 | Blueprint: soongCcLibraryPreamble + ` | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1478 | cc_library { | 
|  | 1479 | name: "foo-lib", | 
|  | 1480 | srcs: ["impl.cpp"], | 
|  | 1481 | arch: { | 
|  | 1482 | arm: { | 
|  | 1483 | no_libcrt: true, | 
|  | 1484 | }, | 
|  | 1485 | x86: { | 
|  | 1486 | no_libcrt: true, | 
|  | 1487 | }, | 
|  | 1488 | }, | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1489 | include_build_directory: false, | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1490 | } | 
|  | 1491 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1492 | ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1493 | "srcs": `["impl.cpp"]`, | 
| Alex Márquez Pérez Muñíz Díaz Puras Thaureaux | 01ec55e | 2023-01-30 22:53:04 +0000 | [diff] [blame] | 1494 | "features": `select({ | 
|  | 1495 | "//build/bazel/platforms/arch:arm": ["-use_libcrt"], | 
|  | 1496 | "//build/bazel/platforms/arch:x86": ["-use_libcrt"], | 
|  | 1497 | "//conditions:default": [], | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1498 | })`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1499 | }), | 
|  | 1500 | }) | 
| Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1501 | } | 
|  | 1502 |  | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 1503 | func TestCCLibraryNoLibCrtArchAndTargetVariant(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1504 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1505 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1506 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1507 | Filesystem: map[string]string{ | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 1508 | "impl.cpp": "", | 
|  | 1509 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1510 | Blueprint: soongCcLibraryPreamble + ` | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 1511 | cc_library { | 
|  | 1512 | name: "foo-lib", | 
|  | 1513 | srcs: ["impl.cpp"], | 
|  | 1514 | arch: { | 
|  | 1515 | arm: { | 
|  | 1516 | no_libcrt: true, | 
|  | 1517 | }, | 
|  | 1518 | x86: { | 
|  | 1519 | no_libcrt: true, | 
|  | 1520 | }, | 
|  | 1521 | }, | 
|  | 1522 | target: { | 
|  | 1523 | darwin: { | 
|  | 1524 | no_libcrt: true, | 
|  | 1525 | } | 
|  | 1526 | }, | 
|  | 1527 | include_build_directory: false, | 
|  | 1528 | } | 
|  | 1529 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1530 | ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{ | 
| Alex Márquez Pérez Muñíz Díaz Puras Thaureaux | 01ec55e | 2023-01-30 22:53:04 +0000 | [diff] [blame] | 1531 | "features": `select({ | 
|  | 1532 | "//build/bazel/platforms/arch:arm": ["-use_libcrt"], | 
|  | 1533 | "//build/bazel/platforms/arch:x86": ["-use_libcrt"], | 
|  | 1534 | "//conditions:default": [], | 
|  | 1535 | }) + select({ | 
|  | 1536 | "//build/bazel/platforms/os:darwin": ["-use_libcrt"], | 
|  | 1537 | "//conditions:default": [], | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 1538 | })`, | 
| Alex Márquez Pérez Muñíz Díaz Puras Thaureaux | 01ec55e | 2023-01-30 22:53:04 +0000 | [diff] [blame] | 1539 | "srcs": `["impl.cpp"]`, | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 1540 | }), | 
|  | 1541 | }) | 
|  | 1542 | } | 
|  | 1543 |  | 
|  | 1544 | func TestCCLibraryNoLibCrtArchAndTargetVariantConflict(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1545 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1546 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1547 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1548 | Filesystem: map[string]string{ | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 1549 | "impl.cpp": "", | 
|  | 1550 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1551 | Blueprint: soongCcLibraryPreamble + ` | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 1552 | cc_library { | 
|  | 1553 | name: "foo-lib", | 
|  | 1554 | srcs: ["impl.cpp"], | 
|  | 1555 | arch: { | 
|  | 1556 | arm: { | 
|  | 1557 | no_libcrt: true, | 
|  | 1558 | }, | 
|  | 1559 | // This is expected to override the value for darwin_x86_64. | 
|  | 1560 | x86_64: { | 
|  | 1561 | no_libcrt: true, | 
|  | 1562 | }, | 
|  | 1563 | }, | 
|  | 1564 | target: { | 
|  | 1565 | darwin: { | 
|  | 1566 | no_libcrt: false, | 
|  | 1567 | } | 
|  | 1568 | }, | 
|  | 1569 | include_build_directory: false, | 
|  | 1570 | } | 
|  | 1571 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1572 | ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{ | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 1573 | "srcs": `["impl.cpp"]`, | 
| Alex Márquez Pérez Muñíz Díaz Puras Thaureaux | 01ec55e | 2023-01-30 22:53:04 +0000 | [diff] [blame] | 1574 | "features": `select({ | 
|  | 1575 | "//build/bazel/platforms/arch:arm": ["-use_libcrt"], | 
|  | 1576 | "//build/bazel/platforms/arch:x86_64": ["-use_libcrt"], | 
|  | 1577 | "//conditions:default": [], | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 1578 | })`, | 
|  | 1579 | }), | 
|  | 1580 | }) | 
|  | 1581 | } | 
|  | 1582 |  | 
| Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1583 | func TestCcLibraryStrip(t *testing.T) { | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1584 | expectedTargets := []string{} | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1585 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("all", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1586 | "strip": `{ | 
|  | 1587 | "all": True, | 
|  | 1588 | }`, | 
|  | 1589 | })...) | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1590 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1591 | "strip": `{ | 
|  | 1592 | "keep_symbols": True, | 
|  | 1593 | }`, | 
|  | 1594 | })...) | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1595 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols_and_debug_frame", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1596 | "strip": `{ | 
|  | 1597 | "keep_symbols_and_debug_frame": True, | 
|  | 1598 | }`, | 
|  | 1599 | })...) | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1600 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols_list", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1601 | "strip": `{ | 
|  | 1602 | "keep_symbols_list": ["symbol"], | 
|  | 1603 | }`, | 
|  | 1604 | })...) | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1605 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("none", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1606 | "strip": `{ | 
|  | 1607 | "none": True, | 
|  | 1608 | }`, | 
|  | 1609 | })...) | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1610 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("nothing", AttrNameToString{})...) | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1611 |  | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1612 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1613 | Description:                "cc_library strip args", | 
|  | 1614 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1615 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1616 | Blueprint: soongCcLibraryPreamble + ` | 
| Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1617 | cc_library { | 
|  | 1618 | name: "nothing", | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1619 | include_build_directory: false, | 
| Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1620 | } | 
|  | 1621 | cc_library { | 
|  | 1622 | name: "keep_symbols", | 
| Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1623 | strip: { | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1624 | keep_symbols: true, | 
|  | 1625 | }, | 
|  | 1626 | include_build_directory: false, | 
| Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1627 | } | 
|  | 1628 | cc_library { | 
|  | 1629 | name: "keep_symbols_and_debug_frame", | 
| Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1630 | strip: { | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1631 | keep_symbols_and_debug_frame: true, | 
|  | 1632 | }, | 
|  | 1633 | include_build_directory: false, | 
| Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1634 | } | 
|  | 1635 | cc_library { | 
|  | 1636 | name: "none", | 
| Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1637 | strip: { | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1638 | none: true, | 
|  | 1639 | }, | 
|  | 1640 | include_build_directory: false, | 
| Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1641 | } | 
|  | 1642 | cc_library { | 
|  | 1643 | name: "keep_symbols_list", | 
| Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1644 | strip: { | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1645 | keep_symbols_list: ["symbol"], | 
|  | 1646 | }, | 
|  | 1647 | include_build_directory: false, | 
| Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1648 | } | 
|  | 1649 | cc_library { | 
|  | 1650 | name: "all", | 
| Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1651 | strip: { | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1652 | all: true, | 
|  | 1653 | }, | 
|  | 1654 | include_build_directory: false, | 
| Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1655 | } | 
|  | 1656 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1657 | ExpectedBazelTargets: expectedTargets, | 
| Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1658 | }) | 
|  | 1659 | } | 
|  | 1660 |  | 
|  | 1661 | func TestCcLibraryStripWithArch(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1662 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1663 | Description:                "cc_library strip args", | 
|  | 1664 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1665 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1666 | Blueprint: soongCcLibraryPreamble + ` | 
| Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1667 | cc_library { | 
|  | 1668 | name: "multi-arch", | 
| Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1669 | target: { | 
|  | 1670 | darwin: { | 
|  | 1671 | strip: { | 
|  | 1672 | keep_symbols_list: ["foo", "bar"] | 
|  | 1673 | } | 
|  | 1674 | }, | 
|  | 1675 | }, | 
|  | 1676 | arch: { | 
|  | 1677 | arm: { | 
|  | 1678 | strip: { | 
|  | 1679 | keep_symbols_and_debug_frame: true, | 
|  | 1680 | }, | 
|  | 1681 | }, | 
|  | 1682 | arm64: { | 
|  | 1683 | strip: { | 
|  | 1684 | keep_symbols: true, | 
|  | 1685 | }, | 
|  | 1686 | }, | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1687 | }, | 
|  | 1688 | include_build_directory: false, | 
| Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1689 | } | 
|  | 1690 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1691 | ExpectedBazelTargets: makeCcLibraryTargets("multi-arch", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1692 | "strip": `{ | 
| Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1693 | "keep_symbols": select({ | 
|  | 1694 | "//build/bazel/platforms/arch:arm64": True, | 
|  | 1695 | "//conditions:default": None, | 
|  | 1696 | }), | 
|  | 1697 | "keep_symbols_and_debug_frame": select({ | 
|  | 1698 | "//build/bazel/platforms/arch:arm": True, | 
|  | 1699 | "//conditions:default": None, | 
|  | 1700 | }), | 
|  | 1701 | "keep_symbols_list": select({ | 
|  | 1702 | "//build/bazel/platforms/os:darwin": [ | 
|  | 1703 | "foo", | 
|  | 1704 | "bar", | 
|  | 1705 | ], | 
|  | 1706 | "//conditions:default": [], | 
|  | 1707 | }), | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1708 | }`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1709 | }), | 
|  | 1710 | }, | 
|  | 1711 | ) | 
| Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1712 | } | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1713 |  | 
|  | 1714 | func TestCcLibrary_SystemSharedLibsRootEmpty(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1715 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1716 | Description:                "cc_library system_shared_libs empty at root", | 
|  | 1717 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1718 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1719 | Blueprint: soongCcLibraryPreamble + ` | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1720 | cc_library { | 
|  | 1721 | name: "root_empty", | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1722 | system_shared_libs: [], | 
|  | 1723 | include_build_directory: false, | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1724 | } | 
|  | 1725 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1726 | ExpectedBazelTargets: makeCcLibraryTargets("root_empty", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1727 | "system_dynamic_deps": `[]`, | 
|  | 1728 | }), | 
|  | 1729 | }, | 
|  | 1730 | ) | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1731 | } | 
|  | 1732 |  | 
|  | 1733 | func TestCcLibrary_SystemSharedLibsStaticEmpty(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1734 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1735 | Description:                "cc_library system_shared_libs empty for static variant", | 
|  | 1736 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1737 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1738 | Blueprint: soongCcLibraryPreamble + ` | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1739 | cc_library { | 
|  | 1740 | name: "static_empty", | 
|  | 1741 | static: { | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1742 | system_shared_libs: [], | 
|  | 1743 | }, | 
|  | 1744 | include_build_directory: false, | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1745 | } | 
|  | 1746 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1747 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 1748 | MakeBazelTarget("cc_library_static", "static_empty_bp2build_cc_library_static", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1749 | "system_dynamic_deps": "[]", | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1750 | }), | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 1751 | MakeBazelTarget("cc_library_shared", "static_empty", AttrNameToString{}), | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1752 | }, | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1753 | }) | 
|  | 1754 | } | 
|  | 1755 |  | 
|  | 1756 | func TestCcLibrary_SystemSharedLibsSharedEmpty(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1757 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1758 | Description:                "cc_library system_shared_libs empty for shared variant", | 
|  | 1759 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1760 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1761 | Blueprint: soongCcLibraryPreamble + ` | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1762 | cc_library { | 
|  | 1763 | name: "shared_empty", | 
|  | 1764 | shared: { | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1765 | system_shared_libs: [], | 
|  | 1766 | }, | 
|  | 1767 | include_build_directory: false, | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1768 | } | 
|  | 1769 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1770 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 1771 | MakeBazelTarget("cc_library_static", "shared_empty_bp2build_cc_library_static", AttrNameToString{}), | 
|  | 1772 | MakeBazelTarget("cc_library_shared", "shared_empty", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1773 | "system_dynamic_deps": "[]", | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1774 | }), | 
|  | 1775 | }, | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1776 | }) | 
|  | 1777 | } | 
|  | 1778 |  | 
|  | 1779 | func TestCcLibrary_SystemSharedLibsSharedBionicEmpty(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1780 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1781 | Description:                "cc_library system_shared_libs empty for shared, bionic variant", | 
|  | 1782 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1783 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1784 | Blueprint: soongCcLibraryPreamble + ` | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1785 | cc_library { | 
|  | 1786 | name: "shared_empty", | 
|  | 1787 | target: { | 
|  | 1788 | bionic: { | 
|  | 1789 | shared: { | 
|  | 1790 | system_shared_libs: [], | 
|  | 1791 | } | 
|  | 1792 | } | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1793 | }, | 
|  | 1794 | include_build_directory: false, | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1795 | } | 
|  | 1796 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1797 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 1798 | MakeBazelTarget("cc_library_static", "shared_empty_bp2build_cc_library_static", AttrNameToString{}), | 
|  | 1799 | MakeBazelTarget("cc_library_shared", "shared_empty", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1800 | "system_dynamic_deps": "[]", | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1801 | }), | 
|  | 1802 | }, | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1803 | }) | 
|  | 1804 | } | 
|  | 1805 |  | 
|  | 1806 | func TestCcLibrary_SystemSharedLibsLinuxBionicEmpty(t *testing.T) { | 
|  | 1807 | // Note that this behavior is technically incorrect (it's a simplification). | 
|  | 1808 | // The correct behavior would be if bp2build wrote `system_dynamic_deps = []` | 
|  | 1809 | // only for linux_bionic, but `android` had `["libc", "libdl", "libm"]. | 
|  | 1810 | // b/195791252 tracks the fix. | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1811 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1812 | Description:                "cc_library system_shared_libs empty for linux_bionic variant", | 
|  | 1813 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1814 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1815 | Blueprint: soongCcLibraryPreamble + ` | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1816 | cc_library { | 
| Trevor Radcliffe | 0d1b402 | 2022-12-12 22:26:34 +0000 | [diff] [blame] | 1817 | name: "libc_musl", | 
|  | 1818 | bazel_module: { bp2build_available: false }, | 
|  | 1819 | } | 
|  | 1820 |  | 
|  | 1821 | cc_library { | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1822 | name: "target_linux_bionic_empty", | 
|  | 1823 | target: { | 
|  | 1824 | linux_bionic: { | 
|  | 1825 | system_shared_libs: [], | 
|  | 1826 | }, | 
|  | 1827 | }, | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1828 | include_build_directory: false, | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1829 | } | 
|  | 1830 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1831 | ExpectedBazelTargets: makeCcLibraryTargets("target_linux_bionic_empty", AttrNameToString{ | 
| Trevor Radcliffe | 0d1b402 | 2022-12-12 22:26:34 +0000 | [diff] [blame] | 1832 | "system_dynamic_deps": `select({ | 
|  | 1833 | "//build/bazel/platforms/os:linux_musl": [":libc_musl"], | 
|  | 1834 | "//conditions:default": [], | 
|  | 1835 | })`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1836 | }), | 
|  | 1837 | }, | 
|  | 1838 | ) | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1839 | } | 
|  | 1840 |  | 
|  | 1841 | func TestCcLibrary_SystemSharedLibsBionicEmpty(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1842 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1843 | Description:                "cc_library system_shared_libs empty for bionic variant", | 
|  | 1844 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1845 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1846 | Blueprint: soongCcLibraryPreamble + ` | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1847 | cc_library { | 
| Trevor Radcliffe | 0d1b402 | 2022-12-12 22:26:34 +0000 | [diff] [blame] | 1848 | name: "libc_musl", | 
|  | 1849 | bazel_module: { bp2build_available: false }, | 
|  | 1850 | } | 
|  | 1851 |  | 
|  | 1852 | cc_library { | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1853 | name: "target_bionic_empty", | 
|  | 1854 | target: { | 
|  | 1855 | bionic: { | 
|  | 1856 | system_shared_libs: [], | 
|  | 1857 | }, | 
|  | 1858 | }, | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1859 | include_build_directory: false, | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1860 | } | 
|  | 1861 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1862 | ExpectedBazelTargets: makeCcLibraryTargets("target_bionic_empty", AttrNameToString{ | 
| Trevor Radcliffe | 0d1b402 | 2022-12-12 22:26:34 +0000 | [diff] [blame] | 1863 | "system_dynamic_deps": `select({ | 
|  | 1864 | "//build/bazel/platforms/os:linux_musl": [":libc_musl"], | 
|  | 1865 | "//conditions:default": [], | 
|  | 1866 | })`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1867 | }), | 
|  | 1868 | }, | 
|  | 1869 | ) | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1870 | } | 
|  | 1871 |  | 
| Trevor Radcliffe | 0d1b402 | 2022-12-12 22:26:34 +0000 | [diff] [blame] | 1872 | func TestCcLibrary_SystemSharedLibsMuslEmpty(t *testing.T) { | 
|  | 1873 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1874 | Description:                "cc_library system_shared_lib empty for musl variant", | 
|  | 1875 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1876 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1877 | Blueprint: soongCcLibraryPreamble + ` | 
|  | 1878 | cc_library { | 
|  | 1879 | name: "libc_musl", | 
|  | 1880 | bazel_module: { bp2build_available: false }, | 
|  | 1881 | } | 
|  | 1882 |  | 
|  | 1883 | cc_library { | 
|  | 1884 | name: "target_musl_empty", | 
|  | 1885 | target: { | 
|  | 1886 | musl: { | 
|  | 1887 | system_shared_libs: [], | 
|  | 1888 | }, | 
|  | 1889 | }, | 
|  | 1890 | include_build_directory: false, | 
|  | 1891 | } | 
|  | 1892 | `, | 
|  | 1893 | ExpectedBazelTargets: makeCcLibraryTargets("target_musl_empty", AttrNameToString{ | 
|  | 1894 | "system_dynamic_deps": `[]`, | 
|  | 1895 | }), | 
|  | 1896 | }) | 
|  | 1897 | } | 
|  | 1898 |  | 
|  | 1899 | func TestCcLibrary_SystemSharedLibsLinuxMuslEmpty(t *testing.T) { | 
|  | 1900 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1901 | Description:                "cc_library system_shared_lib empty for linux_musl variant", | 
|  | 1902 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1903 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1904 | Blueprint: soongCcLibraryPreamble + ` | 
|  | 1905 | cc_library { | 
|  | 1906 | name: "libc_musl", | 
|  | 1907 | bazel_module: { bp2build_available: false }, | 
|  | 1908 | } | 
|  | 1909 |  | 
|  | 1910 | cc_library { | 
|  | 1911 | name: "target_linux_musl_empty", | 
|  | 1912 | target: { | 
|  | 1913 | linux_musl: { | 
|  | 1914 | system_shared_libs: [], | 
|  | 1915 | }, | 
|  | 1916 | }, | 
|  | 1917 | include_build_directory: false, | 
|  | 1918 | } | 
|  | 1919 | `, | 
|  | 1920 | ExpectedBazelTargets: makeCcLibraryTargets("target_linux_musl_empty", AttrNameToString{ | 
|  | 1921 | "system_dynamic_deps": `[]`, | 
|  | 1922 | }), | 
|  | 1923 | }) | 
|  | 1924 | } | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1925 | func TestCcLibrary_SystemSharedLibsSharedAndRoot(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1926 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1927 | Description:                "cc_library system_shared_libs set for shared and root", | 
|  | 1928 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1929 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1930 | Blueprint: soongCcLibraryPreamble + ` | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1931 | cc_library { | 
|  | 1932 | name: "libc", | 
|  | 1933 | bazel_module: { bp2build_available: false }, | 
|  | 1934 | } | 
|  | 1935 | cc_library { | 
|  | 1936 | name: "libm", | 
|  | 1937 | bazel_module: { bp2build_available: false }, | 
|  | 1938 | } | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1939 |  | 
|  | 1940 | cc_library { | 
|  | 1941 | name: "foo", | 
|  | 1942 | system_shared_libs: ["libc"], | 
|  | 1943 | shared: { | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1944 | system_shared_libs: ["libm"], | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1945 | }, | 
| Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1946 | include_build_directory: false, | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1947 | } | 
|  | 1948 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1949 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 1950 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1951 | "system_dynamic_deps": `[":libc"]`, | 
|  | 1952 | }), | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 1953 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1954 | "system_dynamic_deps": `[ | 
|  | 1955 | ":libc", | 
|  | 1956 | ":libm", | 
|  | 1957 | ]`, | 
|  | 1958 | }), | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1959 | }, | 
| Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1960 | }) | 
|  | 1961 | } | 
| Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1962 |  | 
|  | 1963 | func TestCcLibraryOsSelects(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1964 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 1965 | Description:                "cc_library - selects for all os targets", | 
|  | 1966 | ModuleTypeUnderTest:        "cc_library", | 
|  | 1967 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 1968 | Filesystem:                 map[string]string{}, | 
|  | 1969 | Blueprint: soongCcLibraryPreamble + ` | 
| Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1970 | cc_library { | 
|  | 1971 | name: "foo-lib", | 
|  | 1972 | srcs: ["base.cpp"], | 
|  | 1973 | target: { | 
|  | 1974 | android: { | 
|  | 1975 | srcs: ["android.cpp"], | 
|  | 1976 | }, | 
|  | 1977 | linux: { | 
|  | 1978 | srcs: ["linux.cpp"], | 
|  | 1979 | }, | 
|  | 1980 | linux_glibc: { | 
|  | 1981 | srcs: ["linux_glibc.cpp"], | 
|  | 1982 | }, | 
|  | 1983 | darwin: { | 
|  | 1984 | srcs: ["darwin.cpp"], | 
|  | 1985 | }, | 
|  | 1986 | bionic: { | 
|  | 1987 | srcs: ["bionic.cpp"], | 
|  | 1988 | }, | 
|  | 1989 | linux_musl: { | 
|  | 1990 | srcs: ["linux_musl.cpp"], | 
|  | 1991 | }, | 
|  | 1992 | windows: { | 
|  | 1993 | srcs: ["windows.cpp"], | 
|  | 1994 | }, | 
|  | 1995 | }, | 
|  | 1996 | include_build_directory: false, | 
|  | 1997 | } | 
|  | 1998 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1999 | ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2000 | "srcs": `["base.cpp"] + select({ | 
| Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 2001 | "//build/bazel/platforms/os:android": [ | 
| Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 2002 | "linux.cpp", | 
| Liz Kammer | 9bad9d6 | 2021-10-11 15:40:35 -0400 | [diff] [blame] | 2003 | "bionic.cpp", | 
| Liz Kammer | fdd72e6 | 2021-10-11 15:41:03 -0400 | [diff] [blame] | 2004 | "android.cpp", | 
| Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 2005 | ], | 
|  | 2006 | "//build/bazel/platforms/os:darwin": ["darwin.cpp"], | 
| Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 2007 | "//build/bazel/platforms/os:linux_bionic": [ | 
| Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 2008 | "linux.cpp", | 
| Liz Kammer | 9bad9d6 | 2021-10-11 15:40:35 -0400 | [diff] [blame] | 2009 | "bionic.cpp", | 
| Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 2010 | ], | 
| Colin Cross | 133782e | 2022-12-20 15:29:31 -0800 | [diff] [blame] | 2011 | "//build/bazel/platforms/os:linux_glibc": [ | 
|  | 2012 | "linux.cpp", | 
|  | 2013 | "linux_glibc.cpp", | 
|  | 2014 | ], | 
| Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 2015 | "//build/bazel/platforms/os:linux_musl": [ | 
| Liz Kammer | 9bad9d6 | 2021-10-11 15:40:35 -0400 | [diff] [blame] | 2016 | "linux.cpp", | 
| Liz Kammer | fdd72e6 | 2021-10-11 15:41:03 -0400 | [diff] [blame] | 2017 | "linux_musl.cpp", | 
| Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 2018 | ], | 
|  | 2019 | "//build/bazel/platforms/os:windows": ["windows.cpp"], | 
|  | 2020 | "//conditions:default": [], | 
| Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 2021 | })`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2022 | }), | 
|  | 2023 | }, | 
|  | 2024 | ) | 
| Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2025 | } | 
|  | 2026 |  | 
| Yu Liu | 75be7b9 | 2022-02-01 09:54:09 -0800 | [diff] [blame] | 2027 | func TestLibcryptoHashInjection(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2028 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 2029 | Description:                "cc_library - libcrypto hash injection", | 
|  | 2030 | ModuleTypeUnderTest:        "cc_library", | 
|  | 2031 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 2032 | Filesystem:                 map[string]string{}, | 
|  | 2033 | Blueprint: soongCcLibraryPreamble + ` | 
| Yu Liu | 75be7b9 | 2022-02-01 09:54:09 -0800 | [diff] [blame] | 2034 | cc_library { | 
|  | 2035 | name: "libcrypto", | 
|  | 2036 | target: { | 
|  | 2037 | android: { | 
|  | 2038 | inject_bssl_hash: true, | 
|  | 2039 | }, | 
|  | 2040 | }, | 
|  | 2041 | include_build_directory: false, | 
|  | 2042 | } | 
|  | 2043 | `, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2044 | ExpectedBazelTargets: makeCcLibraryTargets("libcrypto", AttrNameToString{ | 
| Yu Liu | 75be7b9 | 2022-02-01 09:54:09 -0800 | [diff] [blame] | 2045 | "inject_bssl_hash": `select({ | 
|  | 2046 | "//build/bazel/platforms/os:android": True, | 
|  | 2047 | "//conditions:default": None, | 
|  | 2048 | })`, | 
|  | 2049 | }), | 
|  | 2050 | }, | 
|  | 2051 | ) | 
|  | 2052 | } | 
|  | 2053 |  | 
| Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2054 | func TestCcLibraryCppStdWithGnuExtensions_ConvertsToFeatureAttr(t *testing.T) { | 
| Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2055 | type testCase struct { | 
|  | 2056 | cpp_std        string | 
| Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2057 | c_std          string | 
| Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2058 | gnu_extensions string | 
|  | 2059 | bazel_cpp_std  string | 
| Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2060 | bazel_c_std    string | 
| Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2061 | } | 
|  | 2062 |  | 
|  | 2063 | testCases := []testCase{ | 
|  | 2064 | // Existing usages of cpp_std in AOSP are: | 
|  | 2065 | // experimental, c++11, c++17, c++2a, c++98, gnu++11, gnu++17 | 
|  | 2066 | // | 
|  | 2067 | // not set, only emit if gnu_extensions is disabled. the default (gnu+17 | 
|  | 2068 | // is set in the toolchain.) | 
|  | 2069 | {cpp_std: "", gnu_extensions: "", bazel_cpp_std: ""}, | 
| Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2070 | {cpp_std: "", gnu_extensions: "false", bazel_cpp_std: "cpp_std_default_no_gnu", bazel_c_std: "c_std_default_no_gnu"}, | 
| Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2071 | {cpp_std: "", gnu_extensions: "true", bazel_cpp_std: ""}, | 
|  | 2072 | // experimental defaults to gnu++2a | 
| Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2073 | {cpp_std: "experimental", gnu_extensions: "", bazel_cpp_std: "cpp_std_experimental"}, | 
|  | 2074 | {cpp_std: "experimental", gnu_extensions: "false", bazel_cpp_std: "cpp_std_experimental_no_gnu", bazel_c_std: "c_std_default_no_gnu"}, | 
|  | 2075 | {cpp_std: "experimental", gnu_extensions: "true", bazel_cpp_std: "cpp_std_experimental"}, | 
| Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2076 | // Explicitly setting a c++ std does not use replace gnu++ std even if | 
|  | 2077 | // gnu_extensions is true. | 
|  | 2078 | // "c++11", | 
|  | 2079 | {cpp_std: "c++11", gnu_extensions: "", bazel_cpp_std: "c++11"}, | 
| Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2080 | {cpp_std: "c++11", gnu_extensions: "false", bazel_cpp_std: "c++11", bazel_c_std: "c_std_default_no_gnu"}, | 
| Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2081 | {cpp_std: "c++11", gnu_extensions: "true", bazel_cpp_std: "c++11"}, | 
|  | 2082 | // "c++17", | 
|  | 2083 | {cpp_std: "c++17", gnu_extensions: "", bazel_cpp_std: "c++17"}, | 
| Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2084 | {cpp_std: "c++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c_std_default_no_gnu"}, | 
| Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2085 | {cpp_std: "c++17", gnu_extensions: "true", bazel_cpp_std: "c++17"}, | 
|  | 2086 | // "c++2a", | 
|  | 2087 | {cpp_std: "c++2a", gnu_extensions: "", bazel_cpp_std: "c++2a"}, | 
| Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2088 | {cpp_std: "c++2a", gnu_extensions: "false", bazel_cpp_std: "c++2a", bazel_c_std: "c_std_default_no_gnu"}, | 
| Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2089 | {cpp_std: "c++2a", gnu_extensions: "true", bazel_cpp_std: "c++2a"}, | 
|  | 2090 | // "c++98", | 
|  | 2091 | {cpp_std: "c++98", gnu_extensions: "", bazel_cpp_std: "c++98"}, | 
| Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2092 | {cpp_std: "c++98", gnu_extensions: "false", bazel_cpp_std: "c++98", bazel_c_std: "c_std_default_no_gnu"}, | 
| Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2093 | {cpp_std: "c++98", gnu_extensions: "true", bazel_cpp_std: "c++98"}, | 
|  | 2094 | // gnu++ is replaced with c++ if gnu_extensions is explicitly false. | 
|  | 2095 | // "gnu++11", | 
|  | 2096 | {cpp_std: "gnu++11", gnu_extensions: "", bazel_cpp_std: "gnu++11"}, | 
| Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2097 | {cpp_std: "gnu++11", gnu_extensions: "false", bazel_cpp_std: "c++11", bazel_c_std: "c_std_default_no_gnu"}, | 
| Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2098 | {cpp_std: "gnu++11", gnu_extensions: "true", bazel_cpp_std: "gnu++11"}, | 
|  | 2099 | // "gnu++17", | 
|  | 2100 | {cpp_std: "gnu++17", gnu_extensions: "", bazel_cpp_std: "gnu++17"}, | 
| Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2101 | {cpp_std: "gnu++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c_std_default_no_gnu"}, | 
| Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2102 | {cpp_std: "gnu++17", gnu_extensions: "true", bazel_cpp_std: "gnu++17"}, | 
| Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2103 |  | 
|  | 2104 | // some c_std test cases | 
| Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2105 | {c_std: "experimental", gnu_extensions: "", bazel_c_std: "c_std_experimental"}, | 
|  | 2106 | {c_std: "experimental", gnu_extensions: "false", bazel_cpp_std: "cpp_std_default_no_gnu", bazel_c_std: "c_std_experimental_no_gnu"}, | 
|  | 2107 | {c_std: "experimental", gnu_extensions: "true", bazel_c_std: "c_std_experimental"}, | 
| Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2108 | {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "", bazel_cpp_std: "gnu++17", bazel_c_std: "gnu11"}, | 
|  | 2109 | {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c11"}, | 
|  | 2110 | {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "true", bazel_cpp_std: "gnu++17", bazel_c_std: "gnu11"}, | 
| Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2111 | } | 
| Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2112 | for i, tc := range testCases { | 
| Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2113 | name := fmt.Sprintf("cpp std: %q, c std: %q, gnu_extensions: %q", tc.cpp_std, tc.c_std, tc.gnu_extensions) | 
|  | 2114 | t.Run(name, func(t *testing.T) { | 
|  | 2115 | name_prefix := fmt.Sprintf("a_%v", i) | 
|  | 2116 | cppStdProp := "" | 
|  | 2117 | if tc.cpp_std != "" { | 
|  | 2118 | cppStdProp = fmt.Sprintf("    cpp_std: \"%s\",", tc.cpp_std) | 
|  | 2119 | } | 
|  | 2120 | cStdProp := "" | 
|  | 2121 | if tc.c_std != "" { | 
|  | 2122 | cStdProp = fmt.Sprintf("    c_std: \"%s\",", tc.c_std) | 
|  | 2123 | } | 
|  | 2124 | gnuExtensionsProp := "" | 
|  | 2125 | if tc.gnu_extensions != "" { | 
|  | 2126 | gnuExtensionsProp = fmt.Sprintf("    gnu_extensions: %s,", tc.gnu_extensions) | 
|  | 2127 | } | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2128 | attrs := AttrNameToString{} | 
| Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2129 | if tc.bazel_cpp_std != "" { | 
|  | 2130 | attrs["cpp_std"] = fmt.Sprintf(`"%s"`, tc.bazel_cpp_std) | 
|  | 2131 | } | 
|  | 2132 | if tc.bazel_c_std != "" { | 
|  | 2133 | attrs["c_std"] = fmt.Sprintf(`"%s"`, tc.bazel_c_std) | 
|  | 2134 | } | 
| Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2135 |  | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2136 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 2137 | Description: fmt.Sprintf( | 
| Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2138 | "cc_library with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions), | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2139 | ModuleTypeUnderTest:        "cc_library", | 
|  | 2140 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 2141 | Blueprint: soongCcLibraryPreamble + fmt.Sprintf(` | 
| Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2142 | cc_library { | 
| Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2143 | name: "%s_full", | 
| Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2144 | %s // cpp_std: *string | 
| Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2145 | %s // c_std: *string | 
| Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2146 | %s // gnu_extensions: *bool | 
|  | 2147 | include_build_directory: false, | 
|  | 2148 | } | 
| Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2149 | `, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp), | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2150 | ExpectedBazelTargets: makeCcLibraryTargets(name_prefix+"_full", attrs), | 
| Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2151 | }) | 
| Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2152 |  | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2153 | runCcLibraryStaticTestCase(t, Bp2buildTestCase{ | 
|  | 2154 | Description: fmt.Sprintf( | 
| Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2155 | "cc_library_static with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions), | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2156 | ModuleTypeUnderTest:        "cc_library_static", | 
|  | 2157 | ModuleTypeUnderTestFactory: cc.LibraryStaticFactory, | 
|  | 2158 | Blueprint: soongCcLibraryPreamble + fmt.Sprintf(` | 
| Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2159 | cc_library_static { | 
| Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2160 | name: "%s_static", | 
| Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2161 | %s // cpp_std: *string | 
| Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2162 | %s // c_std: *string | 
| Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2163 | %s // gnu_extensions: *bool | 
|  | 2164 | include_build_directory: false, | 
|  | 2165 | } | 
| Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2166 | `, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp), | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2167 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2168 | MakeBazelTarget("cc_library_static", name_prefix+"_static", attrs), | 
| Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2169 | }, | 
|  | 2170 | }) | 
| Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2171 |  | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2172 | runCcLibrarySharedTestCase(t, Bp2buildTestCase{ | 
|  | 2173 | Description: fmt.Sprintf( | 
| Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2174 | "cc_library_shared with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions), | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2175 | ModuleTypeUnderTest:        "cc_library_shared", | 
|  | 2176 | ModuleTypeUnderTestFactory: cc.LibrarySharedFactory, | 
|  | 2177 | Blueprint: soongCcLibraryPreamble + fmt.Sprintf(` | 
| Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2178 | cc_library_shared { | 
| Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2179 | name: "%s_shared", | 
| Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2180 | %s // cpp_std: *string | 
| Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2181 | %s // c_std: *string | 
| Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2182 | %s // gnu_extensions: *bool | 
|  | 2183 | include_build_directory: false, | 
|  | 2184 | } | 
| Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2185 | `, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp), | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2186 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2187 | MakeBazelTarget("cc_library_shared", name_prefix+"_shared", attrs), | 
| Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2188 | }, | 
|  | 2189 | }) | 
| Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2190 | }) | 
| Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2191 | } | 
| Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 2192 | } | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2193 |  | 
|  | 2194 | func TestCcLibraryProtoSimple(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2195 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 2196 | ModuleTypeUnderTest:        "cc_library", | 
|  | 2197 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 2198 | Blueprint: soongCcProtoPreamble + `cc_library { | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2199 | name: "foo", | 
|  | 2200 | srcs: ["foo.proto"], | 
|  | 2201 | include_build_directory: false, | 
|  | 2202 | }`, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2203 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2204 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ | 
| Liz Kammer | 7756c8f | 2022-02-14 20:49:15 -0500 | [diff] [blame] | 2205 | "srcs": `["foo.proto"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2206 | }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{ | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2207 | "deps": `[":foo_proto"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2208 | }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2209 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2210 | "deps":                              `[":libprotobuf-cpp-lite"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2211 | }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
| Liz Kammer | 84b0ecb | 2022-09-14 10:49:13 -0400 | [diff] [blame] | 2212 | "dynamic_deps":                      `[":libprotobuf-cpp-lite"]`, | 
|  | 2213 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2214 | }), | 
|  | 2215 | }, | 
|  | 2216 | }) | 
|  | 2217 | } | 
|  | 2218 |  | 
|  | 2219 | func TestCcLibraryProtoNoCanonicalPathFromRoot(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2220 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 2221 | ModuleTypeUnderTest:        "cc_library", | 
|  | 2222 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 2223 | Blueprint: soongCcProtoPreamble + `cc_library { | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2224 | name: "foo", | 
|  | 2225 | srcs: ["foo.proto"], | 
|  | 2226 | proto: { canonical_path_from_root: false}, | 
|  | 2227 | include_build_directory: false, | 
|  | 2228 | }`, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2229 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2230 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ | 
| Liz Kammer | 7756c8f | 2022-02-14 20:49:15 -0500 | [diff] [blame] | 2231 | "srcs":                `["foo.proto"]`, | 
|  | 2232 | "strip_import_prefix": `""`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2233 | }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{ | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2234 | "deps": `[":foo_proto"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2235 | }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2236 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2237 | "deps":                              `[":libprotobuf-cpp-lite"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2238 | }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
| Liz Kammer | 84b0ecb | 2022-09-14 10:49:13 -0400 | [diff] [blame] | 2239 | "dynamic_deps":                      `[":libprotobuf-cpp-lite"]`, | 
|  | 2240 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2241 | }), | 
|  | 2242 | }, | 
|  | 2243 | }) | 
|  | 2244 | } | 
|  | 2245 |  | 
|  | 2246 | func TestCcLibraryProtoExplicitCanonicalPathFromRoot(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2247 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 2248 | ModuleTypeUnderTest:        "cc_library", | 
|  | 2249 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 2250 | Blueprint: soongCcProtoPreamble + `cc_library { | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2251 | name: "foo", | 
|  | 2252 | srcs: ["foo.proto"], | 
|  | 2253 | proto: { canonical_path_from_root: true}, | 
|  | 2254 | include_build_directory: false, | 
|  | 2255 | }`, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2256 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2257 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ | 
| Liz Kammer | 7756c8f | 2022-02-14 20:49:15 -0500 | [diff] [blame] | 2258 | "srcs": `["foo.proto"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2259 | }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{ | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2260 | "deps": `[":foo_proto"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2261 | }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2262 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2263 | "deps":                              `[":libprotobuf-cpp-lite"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2264 | }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
| Liz Kammer | 84b0ecb | 2022-09-14 10:49:13 -0400 | [diff] [blame] | 2265 | "dynamic_deps":                      `[":libprotobuf-cpp-lite"]`, | 
|  | 2266 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2267 | }), | 
|  | 2268 | }, | 
|  | 2269 | }) | 
|  | 2270 | } | 
|  | 2271 |  | 
|  | 2272 | func TestCcLibraryProtoFull(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2273 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 2274 | ModuleTypeUnderTest:        "cc_library", | 
|  | 2275 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 2276 | Blueprint: soongCcProtoPreamble + `cc_library { | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2277 | name: "foo", | 
|  | 2278 | srcs: ["foo.proto"], | 
|  | 2279 | proto: { | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2280 | type: "full", | 
|  | 2281 | }, | 
|  | 2282 | include_build_directory: false, | 
|  | 2283 | }`, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2284 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2285 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2286 | "srcs": `["foo.proto"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2287 | }), MakeBazelTarget("cc_proto_library", "foo_cc_proto", AttrNameToString{ | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2288 | "deps": `[":foo_proto"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2289 | }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2290 | "implementation_whole_archive_deps": `[":foo_cc_proto"]`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2291 | "deps":                              `[":libprotobuf-cpp-full"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2292 | }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
| Liz Kammer | 84b0ecb | 2022-09-14 10:49:13 -0400 | [diff] [blame] | 2293 | "dynamic_deps":                      `[":libprotobuf-cpp-full"]`, | 
|  | 2294 | "implementation_whole_archive_deps": `[":foo_cc_proto"]`, | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2295 | }), | 
|  | 2296 | }, | 
|  | 2297 | }) | 
|  | 2298 | } | 
|  | 2299 |  | 
|  | 2300 | func TestCcLibraryProtoLite(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2301 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 2302 | ModuleTypeUnderTest:        "cc_library", | 
|  | 2303 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 2304 | Blueprint: soongCcProtoPreamble + `cc_library { | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2305 | name: "foo", | 
|  | 2306 | srcs: ["foo.proto"], | 
|  | 2307 | proto: { | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2308 | type: "lite", | 
|  | 2309 | }, | 
|  | 2310 | include_build_directory: false, | 
|  | 2311 | }`, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2312 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2313 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2314 | "srcs": `["foo.proto"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2315 | }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{ | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2316 | "deps": `[":foo_proto"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2317 | }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2318 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2319 | "deps":                              `[":libprotobuf-cpp-lite"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2320 | }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
| Liz Kammer | 84b0ecb | 2022-09-14 10:49:13 -0400 | [diff] [blame] | 2321 | "dynamic_deps":                      `[":libprotobuf-cpp-lite"]`, | 
|  | 2322 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2323 | }), | 
|  | 2324 | }, | 
|  | 2325 | }) | 
|  | 2326 | } | 
|  | 2327 |  | 
|  | 2328 | func TestCcLibraryProtoExportHeaders(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2329 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 2330 | ModuleTypeUnderTest:        "cc_library", | 
|  | 2331 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 2332 | Blueprint: soongCcProtoPreamble + `cc_library { | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2333 | name: "foo", | 
|  | 2334 | srcs: ["foo.proto"], | 
|  | 2335 | proto: { | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2336 | export_proto_headers: true, | 
|  | 2337 | }, | 
|  | 2338 | include_build_directory: false, | 
|  | 2339 | }`, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2340 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2341 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2342 | "srcs": `["foo.proto"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2343 | }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{ | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2344 | "deps": `[":foo_proto"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2345 | }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2346 | "deps":               `[":libprotobuf-cpp-lite"]`, | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2347 | "whole_archive_deps": `[":foo_cc_proto_lite"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2348 | }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
| Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2349 | "dynamic_deps":       `[":libprotobuf-cpp-lite"]`, | 
|  | 2350 | "whole_archive_deps": `[":foo_cc_proto_lite"]`, | 
| Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2351 | }), | 
|  | 2352 | }, | 
|  | 2353 | }) | 
|  | 2354 | } | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2355 |  | 
| Yu Liu | 2d13614 | 2022-08-18 14:46:13 -0700 | [diff] [blame] | 2356 | func TestCcLibraryProtoIncludeDirs(t *testing.T) { | 
|  | 2357 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 2358 | ModuleTypeUnderTest:        "cc_library", | 
|  | 2359 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 2360 | Blueprint: soongCcProtoPreamble + `cc_library { | 
|  | 2361 | name: "foo", | 
|  | 2362 | srcs: ["foo.proto"], | 
|  | 2363 | proto: { | 
|  | 2364 | include_dirs: ["external/protobuf/src"], | 
|  | 2365 | }, | 
|  | 2366 | include_build_directory: false, | 
|  | 2367 | }`, | 
|  | 2368 | ExpectedBazelTargets: []string{ | 
|  | 2369 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ | 
|  | 2370 | "srcs": `["foo.proto"]`, | 
|  | 2371 | "deps": `["//external/protobuf:libprotobuf-proto"]`, | 
|  | 2372 | }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{ | 
|  | 2373 | "deps": `[":foo_proto"]`, | 
|  | 2374 | }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 2375 | "deps":                              `[":libprotobuf-cpp-lite"]`, | 
|  | 2376 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, | 
|  | 2377 | }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
| Liz Kammer | 84b0ecb | 2022-09-14 10:49:13 -0400 | [diff] [blame] | 2378 | "dynamic_deps":                      `[":libprotobuf-cpp-lite"]`, | 
|  | 2379 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, | 
| Yu Liu | 2d13614 | 2022-08-18 14:46:13 -0700 | [diff] [blame] | 2380 | }), | 
|  | 2381 | }, | 
|  | 2382 | }) | 
|  | 2383 | } | 
|  | 2384 |  | 
|  | 2385 | func TestCcLibraryProtoIncludeDirsUnknown(t *testing.T) { | 
|  | 2386 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 2387 | ModuleTypeUnderTest:        "cc_library", | 
|  | 2388 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 2389 | Blueprint: soongCcProtoPreamble + `cc_library { | 
|  | 2390 | name: "foo", | 
|  | 2391 | srcs: ["foo.proto"], | 
|  | 2392 | proto: { | 
|  | 2393 | include_dirs: ["external/protobuf/abc"], | 
|  | 2394 | }, | 
|  | 2395 | include_build_directory: false, | 
|  | 2396 | }`, | 
| Spandan Das | ec39d51 | 2023-08-15 22:08:18 +0000 | [diff] [blame] | 2397 | ExpectedErr: fmt.Errorf("module \"foo\": TODO: Add support for proto.include_dir: external/protobuf/abc. This directory does not contain an Android.bp file"), | 
| Yu Liu | 2d13614 | 2022-08-18 14:46:13 -0700 | [diff] [blame] | 2398 | }) | 
|  | 2399 | } | 
|  | 2400 |  | 
| Yu Liu | 2aa806b | 2022-09-01 11:54:47 -0700 | [diff] [blame] | 2401 | func TestCcLibraryConvertedProtoFilegroups(t *testing.T) { | 
|  | 2402 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 2403 | ModuleTypeUnderTest:        "cc_library", | 
|  | 2404 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 2405 | Blueprint: soongCcProtoPreamble + ` | 
|  | 2406 | filegroup { | 
|  | 2407 | name: "a_fg_proto", | 
|  | 2408 | srcs: ["a_fg.proto"], | 
|  | 2409 | } | 
|  | 2410 |  | 
|  | 2411 | cc_library { | 
|  | 2412 | name: "a", | 
|  | 2413 | srcs: [ | 
|  | 2414 | ":a_fg_proto", | 
|  | 2415 | "a.proto", | 
|  | 2416 | ], | 
|  | 2417 | proto: { | 
|  | 2418 | export_proto_headers: true, | 
|  | 2419 | }, | 
|  | 2420 | include_build_directory: false, | 
|  | 2421 | }`, | 
|  | 2422 | ExpectedBazelTargets: []string{ | 
|  | 2423 | MakeBazelTarget("proto_library", "a_proto", AttrNameToString{ | 
| Yu Liu | 2a85fb1 | 2022-09-15 22:18:48 -0700 | [diff] [blame] | 2424 | "deps": `[":a_fg_proto_bp2build_converted"]`, | 
| Yu Liu | 2aa806b | 2022-09-01 11:54:47 -0700 | [diff] [blame] | 2425 | "srcs": `["a.proto"]`, | 
|  | 2426 | }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{ | 
|  | 2427 | "deps": `[ | 
|  | 2428 | ":a_fg_proto_bp2build_converted", | 
|  | 2429 | ":a_proto", | 
|  | 2430 | ]`, | 
|  | 2431 | }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{ | 
|  | 2432 | "deps":               `[":libprotobuf-cpp-lite"]`, | 
|  | 2433 | "whole_archive_deps": `[":a_cc_proto_lite"]`, | 
|  | 2434 | }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ | 
|  | 2435 | "dynamic_deps":       `[":libprotobuf-cpp-lite"]`, | 
|  | 2436 | "whole_archive_deps": `[":a_cc_proto_lite"]`, | 
| Spandan Das | df3ec82 | 2023-08-04 02:19:53 +0000 | [diff] [blame] | 2437 | }), MakeBazelTargetNoRestrictions("proto_library", "a_fg_proto_proto", AttrNameToString{ | 
| Yu Liu | 2aa806b | 2022-09-01 11:54:47 -0700 | [diff] [blame] | 2438 | "srcs": `["a_fg.proto"]`, | 
| Liz Kammer | 2b3f56e | 2023-03-23 11:51:49 -0400 | [diff] [blame] | 2439 | "tags": `[ | 
|  | 2440 | "apex_available=//apex_available:anyapex", | 
|  | 2441 | "manual", | 
|  | 2442 | ]`, | 
| Spandan Das | df3ec82 | 2023-08-04 02:19:53 +0000 | [diff] [blame] | 2443 | }), MakeBazelTargetNoRestrictions("alias", "a_fg_proto_bp2build_converted", AttrNameToString{ | 
|  | 2444 | "actual": `"//.:a_fg_proto_proto"`, | 
|  | 2445 | "tags": `[ | 
|  | 2446 | "apex_available=//apex_available:anyapex", | 
|  | 2447 | "manual", | 
|  | 2448 | ]`, | 
| Yu Liu | 2aa806b | 2022-09-01 11:54:47 -0700 | [diff] [blame] | 2449 | }), MakeBazelTargetNoRestrictions("filegroup", "a_fg_proto", AttrNameToString{ | 
|  | 2450 | "srcs": `["a_fg.proto"]`, | 
|  | 2451 | }), | 
|  | 2452 | }, | 
|  | 2453 | }) | 
|  | 2454 | } | 
|  | 2455 |  | 
|  | 2456 | func TestCcLibraryConvertedProtoFilegroupsNoProtoFiles(t *testing.T) { | 
|  | 2457 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 2458 | ModuleTypeUnderTest:        "cc_library", | 
|  | 2459 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 2460 | Blueprint: soongCcProtoPreamble + ` | 
|  | 2461 | filegroup { | 
|  | 2462 | name: "a_fg_proto", | 
|  | 2463 | srcs: ["a_fg.proto"], | 
|  | 2464 | } | 
|  | 2465 |  | 
|  | 2466 | cc_library { | 
|  | 2467 | name: "a", | 
|  | 2468 | srcs: [ | 
|  | 2469 | ":a_fg_proto", | 
|  | 2470 | ], | 
|  | 2471 | proto: { | 
|  | 2472 | export_proto_headers: true, | 
|  | 2473 | }, | 
|  | 2474 | include_build_directory: false, | 
|  | 2475 | }`, | 
|  | 2476 | ExpectedBazelTargets: []string{ | 
|  | 2477 | MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{ | 
|  | 2478 | "deps": `[":a_fg_proto_bp2build_converted"]`, | 
|  | 2479 | }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{ | 
|  | 2480 | "deps":               `[":libprotobuf-cpp-lite"]`, | 
|  | 2481 | "whole_archive_deps": `[":a_cc_proto_lite"]`, | 
|  | 2482 | }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ | 
|  | 2483 | "dynamic_deps":       `[":libprotobuf-cpp-lite"]`, | 
|  | 2484 | "whole_archive_deps": `[":a_cc_proto_lite"]`, | 
| Spandan Das | df3ec82 | 2023-08-04 02:19:53 +0000 | [diff] [blame] | 2485 | }), MakeBazelTargetNoRestrictions("proto_library", "a_fg_proto_proto", AttrNameToString{ | 
| Yu Liu | 2aa806b | 2022-09-01 11:54:47 -0700 | [diff] [blame] | 2486 | "srcs": `["a_fg.proto"]`, | 
| Liz Kammer | 2b3f56e | 2023-03-23 11:51:49 -0400 | [diff] [blame] | 2487 | "tags": `[ | 
|  | 2488 | "apex_available=//apex_available:anyapex", | 
|  | 2489 | "manual", | 
|  | 2490 | ]`, | 
| Spandan Das | df3ec82 | 2023-08-04 02:19:53 +0000 | [diff] [blame] | 2491 | }), MakeBazelTargetNoRestrictions("alias", "a_fg_proto_bp2build_converted", AttrNameToString{ | 
|  | 2492 | "actual": `"//.:a_fg_proto_proto"`, | 
|  | 2493 | "tags": `[ | 
|  | 2494 | "apex_available=//apex_available:anyapex", | 
|  | 2495 | "manual", | 
|  | 2496 | ]`, | 
| Yu Liu | 2aa806b | 2022-09-01 11:54:47 -0700 | [diff] [blame] | 2497 | }), MakeBazelTargetNoRestrictions("filegroup", "a_fg_proto", AttrNameToString{ | 
|  | 2498 | "srcs": `["a_fg.proto"]`, | 
|  | 2499 | }), | 
|  | 2500 | }, | 
|  | 2501 | }) | 
|  | 2502 | } | 
|  | 2503 |  | 
|  | 2504 | func TestCcLibraryExternalConvertedProtoFilegroups(t *testing.T) { | 
|  | 2505 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 2506 | ModuleTypeUnderTest:        "cc_library", | 
|  | 2507 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 2508 | Filesystem: map[string]string{ | 
|  | 2509 | "path/to/A/Android.bp": ` | 
|  | 2510 | filegroup { | 
|  | 2511 | name: "a_fg_proto", | 
|  | 2512 | srcs: ["a_fg.proto"], | 
|  | 2513 | }`, | 
|  | 2514 | }, | 
|  | 2515 | Blueprint: soongCcProtoPreamble + ` | 
|  | 2516 | cc_library { | 
|  | 2517 | name: "a", | 
|  | 2518 | srcs: [ | 
|  | 2519 | ":a_fg_proto", | 
|  | 2520 | "a.proto", | 
|  | 2521 | ], | 
|  | 2522 | proto: { | 
|  | 2523 | export_proto_headers: true, | 
|  | 2524 | }, | 
|  | 2525 | include_build_directory: false, | 
|  | 2526 | }`, | 
|  | 2527 | ExpectedBazelTargets: []string{ | 
|  | 2528 | MakeBazelTarget("proto_library", "a_proto", AttrNameToString{ | 
| Yu Liu | 2a85fb1 | 2022-09-15 22:18:48 -0700 | [diff] [blame] | 2529 | "deps": `["//path/to/A:a_fg_proto_bp2build_converted"]`, | 
| Yu Liu | 2aa806b | 2022-09-01 11:54:47 -0700 | [diff] [blame] | 2530 | "srcs": `["a.proto"]`, | 
|  | 2531 | }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{ | 
|  | 2532 | "deps": `[ | 
|  | 2533 | "//path/to/A:a_fg_proto_bp2build_converted", | 
|  | 2534 | ":a_proto", | 
|  | 2535 | ]`, | 
|  | 2536 | }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{ | 
|  | 2537 | "deps":               `[":libprotobuf-cpp-lite"]`, | 
|  | 2538 | "whole_archive_deps": `[":a_cc_proto_lite"]`, | 
|  | 2539 | }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ | 
|  | 2540 | "dynamic_deps":       `[":libprotobuf-cpp-lite"]`, | 
|  | 2541 | "whole_archive_deps": `[":a_cc_proto_lite"]`, | 
|  | 2542 | }), | 
|  | 2543 | }, | 
|  | 2544 | }) | 
|  | 2545 | } | 
|  | 2546 |  | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2547 | func TestCcLibraryProtoFilegroups(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2548 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 2549 | ModuleTypeUnderTest:        "cc_library", | 
|  | 2550 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 2551 | Blueprint: soongCcProtoPreamble + | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2552 | simpleModuleDoNotConvertBp2build("filegroup", "a_fg_proto") + | 
|  | 2553 | simpleModuleDoNotConvertBp2build("filegroup", "b_protos") + | 
|  | 2554 | simpleModuleDoNotConvertBp2build("filegroup", "c-proto-srcs") + | 
|  | 2555 | simpleModuleDoNotConvertBp2build("filegroup", "proto-srcs-d") + ` | 
|  | 2556 | cc_library { | 
|  | 2557 | name: "a", | 
|  | 2558 | srcs: [":a_fg_proto"], | 
|  | 2559 | proto: { | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2560 | export_proto_headers: true, | 
|  | 2561 | }, | 
|  | 2562 | include_build_directory: false, | 
|  | 2563 | } | 
|  | 2564 |  | 
|  | 2565 | cc_library { | 
|  | 2566 | name: "b", | 
|  | 2567 | srcs: [":b_protos"], | 
|  | 2568 | proto: { | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2569 | export_proto_headers: true, | 
|  | 2570 | }, | 
|  | 2571 | include_build_directory: false, | 
|  | 2572 | } | 
|  | 2573 |  | 
|  | 2574 | cc_library { | 
|  | 2575 | name: "c", | 
|  | 2576 | srcs: [":c-proto-srcs"], | 
|  | 2577 | proto: { | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2578 | export_proto_headers: true, | 
|  | 2579 | }, | 
|  | 2580 | include_build_directory: false, | 
|  | 2581 | } | 
|  | 2582 |  | 
|  | 2583 | cc_library { | 
|  | 2584 | name: "d", | 
|  | 2585 | srcs: [":proto-srcs-d"], | 
|  | 2586 | proto: { | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2587 | export_proto_headers: true, | 
|  | 2588 | }, | 
|  | 2589 | include_build_directory: false, | 
|  | 2590 | }`, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2591 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2592 | MakeBazelTarget("proto_library", "a_proto", AttrNameToString{ | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2593 | "srcs": `[":a_fg_proto"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2594 | }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{ | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2595 | "deps": `[":a_proto"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2596 | }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{ | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2597 | "deps":               `[":libprotobuf-cpp-lite"]`, | 
|  | 2598 | "whole_archive_deps": `[":a_cc_proto_lite"]`, | 
|  | 2599 | "srcs":               `[":a_fg_proto_cpp_srcs"]`, | 
|  | 2600 | "srcs_as":            `[":a_fg_proto_as_srcs"]`, | 
|  | 2601 | "srcs_c":             `[":a_fg_proto_c_srcs"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2602 | }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2603 | "dynamic_deps":       `[":libprotobuf-cpp-lite"]`, | 
|  | 2604 | "whole_archive_deps": `[":a_cc_proto_lite"]`, | 
|  | 2605 | "srcs":               `[":a_fg_proto_cpp_srcs"]`, | 
|  | 2606 | "srcs_as":            `[":a_fg_proto_as_srcs"]`, | 
|  | 2607 | "srcs_c":             `[":a_fg_proto_c_srcs"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2608 | }), MakeBazelTarget("proto_library", "b_proto", AttrNameToString{ | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2609 | "srcs": `[":b_protos"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2610 | }), MakeBazelTarget("cc_lite_proto_library", "b_cc_proto_lite", AttrNameToString{ | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2611 | "deps": `[":b_proto"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2612 | }), MakeBazelTarget("cc_library_static", "b_bp2build_cc_library_static", AttrNameToString{ | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2613 | "deps":               `[":libprotobuf-cpp-lite"]`, | 
|  | 2614 | "whole_archive_deps": `[":b_cc_proto_lite"]`, | 
|  | 2615 | "srcs":               `[":b_protos_cpp_srcs"]`, | 
|  | 2616 | "srcs_as":            `[":b_protos_as_srcs"]`, | 
|  | 2617 | "srcs_c":             `[":b_protos_c_srcs"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2618 | }), MakeBazelTarget("cc_library_shared", "b", AttrNameToString{ | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2619 | "dynamic_deps":       `[":libprotobuf-cpp-lite"]`, | 
|  | 2620 | "whole_archive_deps": `[":b_cc_proto_lite"]`, | 
|  | 2621 | "srcs":               `[":b_protos_cpp_srcs"]`, | 
|  | 2622 | "srcs_as":            `[":b_protos_as_srcs"]`, | 
|  | 2623 | "srcs_c":             `[":b_protos_c_srcs"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2624 | }), MakeBazelTarget("proto_library", "c_proto", AttrNameToString{ | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2625 | "srcs": `[":c-proto-srcs"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2626 | }), MakeBazelTarget("cc_lite_proto_library", "c_cc_proto_lite", AttrNameToString{ | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2627 | "deps": `[":c_proto"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2628 | }), MakeBazelTarget("cc_library_static", "c_bp2build_cc_library_static", AttrNameToString{ | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2629 | "deps":               `[":libprotobuf-cpp-lite"]`, | 
|  | 2630 | "whole_archive_deps": `[":c_cc_proto_lite"]`, | 
|  | 2631 | "srcs":               `[":c-proto-srcs_cpp_srcs"]`, | 
|  | 2632 | "srcs_as":            `[":c-proto-srcs_as_srcs"]`, | 
|  | 2633 | "srcs_c":             `[":c-proto-srcs_c_srcs"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2634 | }), MakeBazelTarget("cc_library_shared", "c", AttrNameToString{ | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2635 | "dynamic_deps":       `[":libprotobuf-cpp-lite"]`, | 
|  | 2636 | "whole_archive_deps": `[":c_cc_proto_lite"]`, | 
|  | 2637 | "srcs":               `[":c-proto-srcs_cpp_srcs"]`, | 
|  | 2638 | "srcs_as":            `[":c-proto-srcs_as_srcs"]`, | 
|  | 2639 | "srcs_c":             `[":c-proto-srcs_c_srcs"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2640 | }), MakeBazelTarget("proto_library", "d_proto", AttrNameToString{ | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2641 | "srcs": `[":proto-srcs-d"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2642 | }), MakeBazelTarget("cc_lite_proto_library", "d_cc_proto_lite", AttrNameToString{ | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2643 | "deps": `[":d_proto"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2644 | }), MakeBazelTarget("cc_library_static", "d_bp2build_cc_library_static", AttrNameToString{ | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2645 | "deps":               `[":libprotobuf-cpp-lite"]`, | 
|  | 2646 | "whole_archive_deps": `[":d_cc_proto_lite"]`, | 
|  | 2647 | "srcs":               `[":proto-srcs-d_cpp_srcs"]`, | 
|  | 2648 | "srcs_as":            `[":proto-srcs-d_as_srcs"]`, | 
|  | 2649 | "srcs_c":             `[":proto-srcs-d_c_srcs"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2650 | }), MakeBazelTarget("cc_library_shared", "d", AttrNameToString{ | 
| Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2651 | "dynamic_deps":       `[":libprotobuf-cpp-lite"]`, | 
|  | 2652 | "whole_archive_deps": `[":d_cc_proto_lite"]`, | 
|  | 2653 | "srcs":               `[":proto-srcs-d_cpp_srcs"]`, | 
|  | 2654 | "srcs_as":            `[":proto-srcs-d_as_srcs"]`, | 
|  | 2655 | "srcs_c":             `[":proto-srcs-d_c_srcs"]`, | 
|  | 2656 | }), | 
|  | 2657 | }, | 
|  | 2658 | }) | 
|  | 2659 | } | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2660 |  | 
|  | 2661 | func TestCcLibraryDisabledArchAndTarget(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2662 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 2663 | ModuleTypeUnderTest:        "cc_library", | 
|  | 2664 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 2665 | Blueprint: soongCcProtoPreamble + `cc_library { | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2666 | name: "foo", | 
|  | 2667 | srcs: ["foo.cpp"], | 
| Liz Kammer | dfeb120 | 2022-05-13 17:20:20 -0400 | [diff] [blame] | 2668 | host_supported: true, | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2669 | target: { | 
|  | 2670 | darwin: { | 
|  | 2671 | enabled: false, | 
|  | 2672 | }, | 
|  | 2673 | windows: { | 
|  | 2674 | enabled: false, | 
|  | 2675 | }, | 
|  | 2676 | linux_glibc_x86: { | 
|  | 2677 | enabled: false, | 
|  | 2678 | }, | 
|  | 2679 | }, | 
|  | 2680 | include_build_directory: false, | 
|  | 2681 | }`, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2682 | ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{ | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2683 | "srcs": `["foo.cpp"]`, | 
|  | 2684 | "target_compatible_with": `select({ | 
|  | 2685 | "//build/bazel/platforms/os_arch:darwin_arm64": ["@platforms//:incompatible"], | 
|  | 2686 | "//build/bazel/platforms/os_arch:darwin_x86_64": ["@platforms//:incompatible"], | 
|  | 2687 | "//build/bazel/platforms/os_arch:linux_glibc_x86": ["@platforms//:incompatible"], | 
|  | 2688 | "//build/bazel/platforms/os_arch:windows_x86": ["@platforms//:incompatible"], | 
|  | 2689 | "//build/bazel/platforms/os_arch:windows_x86_64": ["@platforms//:incompatible"], | 
|  | 2690 | "//conditions:default": [], | 
|  | 2691 | })`, | 
|  | 2692 | }), | 
|  | 2693 | }) | 
|  | 2694 | } | 
|  | 2695 |  | 
|  | 2696 | func TestCcLibraryDisabledArchAndTargetWithDefault(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2697 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 2698 | ModuleTypeUnderTest:        "cc_library", | 
|  | 2699 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 2700 | Blueprint: soongCcProtoPreamble + `cc_library { | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2701 | name: "foo", | 
|  | 2702 | srcs: ["foo.cpp"], | 
|  | 2703 | enabled: false, | 
| Liz Kammer | dfeb120 | 2022-05-13 17:20:20 -0400 | [diff] [blame] | 2704 | host_supported: true, | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2705 | target: { | 
|  | 2706 | darwin: { | 
|  | 2707 | enabled: true, | 
|  | 2708 | }, | 
|  | 2709 | windows: { | 
|  | 2710 | enabled: false, | 
|  | 2711 | }, | 
|  | 2712 | linux_glibc_x86: { | 
|  | 2713 | enabled: false, | 
|  | 2714 | }, | 
|  | 2715 | }, | 
|  | 2716 | include_build_directory: false, | 
|  | 2717 | }`, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2718 | ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{ | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2719 | "srcs": `["foo.cpp"]`, | 
|  | 2720 | "target_compatible_with": `select({ | 
|  | 2721 | "//build/bazel/platforms/os_arch:darwin_arm64": [], | 
|  | 2722 | "//build/bazel/platforms/os_arch:darwin_x86_64": [], | 
|  | 2723 | "//conditions:default": ["@platforms//:incompatible"], | 
|  | 2724 | })`, | 
|  | 2725 | }), | 
|  | 2726 | }) | 
|  | 2727 | } | 
|  | 2728 |  | 
|  | 2729 | func TestCcLibrarySharedDisabled(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2730 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 2731 | ModuleTypeUnderTest:        "cc_library", | 
|  | 2732 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 2733 | Blueprint: soongCcProtoPreamble + `cc_library { | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2734 | name: "foo", | 
|  | 2735 | srcs: ["foo.cpp"], | 
|  | 2736 | enabled: false, | 
|  | 2737 | shared: { | 
|  | 2738 | enabled: true, | 
|  | 2739 | }, | 
|  | 2740 | target: { | 
|  | 2741 | android: { | 
|  | 2742 | shared: { | 
|  | 2743 | enabled: false, | 
|  | 2744 | }, | 
|  | 2745 | } | 
|  | 2746 | }, | 
|  | 2747 | include_build_directory: false, | 
|  | 2748 | }`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2749 | ExpectedBazelTargets: []string{MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2750 | "srcs":                   `["foo.cpp"]`, | 
|  | 2751 | "target_compatible_with": `["@platforms//:incompatible"]`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2752 | }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2753 | "srcs": `["foo.cpp"]`, | 
|  | 2754 | "target_compatible_with": `select({ | 
|  | 2755 | "//build/bazel/platforms/os:android": ["@platforms//:incompatible"], | 
|  | 2756 | "//conditions:default": [], | 
|  | 2757 | })`, | 
|  | 2758 | }), | 
|  | 2759 | }, | 
|  | 2760 | }) | 
|  | 2761 | } | 
|  | 2762 |  | 
|  | 2763 | func TestCcLibraryStaticDisabledForSomeArch(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2764 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 2765 | ModuleTypeUnderTest:        "cc_library", | 
|  | 2766 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 2767 | Blueprint: soongCcProtoPreamble + `cc_library { | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2768 | name: "foo", | 
| Liz Kammer | dfeb120 | 2022-05-13 17:20:20 -0400 | [diff] [blame] | 2769 | host_supported: true, | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2770 | srcs: ["foo.cpp"], | 
|  | 2771 | shared: { | 
|  | 2772 | enabled: false | 
|  | 2773 | }, | 
|  | 2774 | target: { | 
|  | 2775 | darwin: { | 
|  | 2776 | enabled: true, | 
|  | 2777 | }, | 
|  | 2778 | windows: { | 
|  | 2779 | enabled: false, | 
|  | 2780 | }, | 
|  | 2781 | linux_glibc_x86: { | 
|  | 2782 | shared: { | 
|  | 2783 | enabled: true, | 
|  | 2784 | }, | 
|  | 2785 | }, | 
|  | 2786 | }, | 
|  | 2787 | include_build_directory: false, | 
|  | 2788 | }`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2789 | ExpectedBazelTargets: []string{MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2790 | "srcs": `["foo.cpp"]`, | 
|  | 2791 | "target_compatible_with": `select({ | 
|  | 2792 | "//build/bazel/platforms/os:windows": ["@platforms//:incompatible"], | 
|  | 2793 | "//conditions:default": [], | 
|  | 2794 | })`, | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2795 | }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
| Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2796 | "srcs": `["foo.cpp"]`, | 
|  | 2797 | "target_compatible_with": `select({ | 
|  | 2798 | "//build/bazel/platforms/os_arch:darwin_arm64": [], | 
|  | 2799 | "//build/bazel/platforms/os_arch:darwin_x86_64": [], | 
|  | 2800 | "//build/bazel/platforms/os_arch:linux_glibc_x86": [], | 
|  | 2801 | "//conditions:default": ["@platforms//:incompatible"], | 
|  | 2802 | })`, | 
|  | 2803 | }), | 
|  | 2804 | }}) | 
|  | 2805 | } | 
| Jingwen Chen | 0ee88a6 | 2022-01-07 14:55:29 +0000 | [diff] [blame] | 2806 |  | 
|  | 2807 | func TestCcLibraryStubs(t *testing.T) { | 
| Wei Li | 81852ca | 2022-07-27 00:22:06 -0700 | [diff] [blame] | 2808 | expectedBazelTargets := makeCcLibraryTargets("a", AttrNameToString{ | 
| Yu Liu | 56ccb1a | 2022-11-12 10:47:07 -0800 | [diff] [blame] | 2809 | "stubs_symbol_file": `"a.map.txt"`, | 
| Wei Li | 81852ca | 2022-07-27 00:22:06 -0700 | [diff] [blame] | 2810 | }) | 
|  | 2811 | expectedBazelTargets = append(expectedBazelTargets, makeCcStubSuiteTargets("a", AttrNameToString{ | 
| Sam Delmerico | 5f90649 | 2023-03-15 18:06:18 -0400 | [diff] [blame] | 2812 | "soname":               `"a.so"`, | 
|  | 2813 | "source_library_label": `"//foo/bar:a"`, | 
|  | 2814 | "stubs_symbol_file":    `"a.map.txt"`, | 
| Wei Li | 81852ca | 2022-07-27 00:22:06 -0700 | [diff] [blame] | 2815 | "stubs_versions": `[ | 
|  | 2816 | "28", | 
|  | 2817 | "29", | 
|  | 2818 | "current", | 
|  | 2819 | ]`, | 
|  | 2820 | })) | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2821 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 2822 | Description:                "cc_library stubs", | 
|  | 2823 | ModuleTypeUnderTest:        "cc_library", | 
|  | 2824 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 2825 | Dir:                        "foo/bar", | 
|  | 2826 | Filesystem: map[string]string{ | 
| Jingwen Chen | 0ee88a6 | 2022-01-07 14:55:29 +0000 | [diff] [blame] | 2827 | "foo/bar/Android.bp": ` | 
|  | 2828 | cc_library { | 
|  | 2829 | name: "a", | 
|  | 2830 | stubs: { symbol_file: "a.map.txt", versions: ["28", "29", "current"] }, | 
|  | 2831 | bazel_module: { bp2build_available: true }, | 
|  | 2832 | include_build_directory: false, | 
|  | 2833 | } | 
|  | 2834 | `, | 
|  | 2835 | }, | 
| Wei Li | 81852ca | 2022-07-27 00:22:06 -0700 | [diff] [blame] | 2836 | Blueprint:            soongCcLibraryPreamble, | 
|  | 2837 | ExpectedBazelTargets: expectedBazelTargets, | 
| Jingwen Chen | 0ee88a6 | 2022-01-07 14:55:29 +0000 | [diff] [blame] | 2838 | }, | 
|  | 2839 | ) | 
|  | 2840 | } | 
| Liz Kammer | f38a837 | 2022-02-04 15:39:00 -0500 | [diff] [blame] | 2841 |  | 
| Spandan Das | 4238c65 | 2022-09-09 01:38:47 +0000 | [diff] [blame] | 2842 | func TestCcApiContributionsWithHdrs(t *testing.T) { | 
|  | 2843 | bp := ` | 
|  | 2844 | cc_library { | 
|  | 2845 | name: "libfoo", | 
|  | 2846 | stubs: { symbol_file: "libfoo.map.txt", versions: ["28", "29", "current"] }, | 
|  | 2847 | llndk: { symbol_file: "libfoo.map.txt", override_export_include_dirs: ["dir2"]}, | 
|  | 2848 | export_include_dirs: ["dir1"], | 
|  | 2849 | } | 
|  | 2850 | ` | 
|  | 2851 | expectedBazelTargets := []string{ | 
|  | 2852 | MakeBazelTarget( | 
|  | 2853 | "cc_api_library_headers", | 
| Spandan Das | 627fc3e | 2023-01-26 23:02:00 +0000 | [diff] [blame] | 2854 | "libfoo.module-libapi.headers", | 
| Spandan Das | 4238c65 | 2022-09-09 01:38:47 +0000 | [diff] [blame] | 2855 | AttrNameToString{ | 
|  | 2856 | "export_includes": `["dir1"]`, | 
|  | 2857 | }), | 
|  | 2858 | MakeBazelTarget( | 
|  | 2859 | "cc_api_library_headers", | 
|  | 2860 | "libfoo.vendorapi.headers", | 
|  | 2861 | AttrNameToString{ | 
|  | 2862 | "export_includes": `["dir2"]`, | 
|  | 2863 | }), | 
|  | 2864 | MakeBazelTarget( | 
|  | 2865 | "cc_api_contribution", | 
|  | 2866 | "libfoo.contribution", | 
|  | 2867 | AttrNameToString{ | 
|  | 2868 | "api":          `"libfoo.map.txt"`, | 
|  | 2869 | "library_name": `"libfoo"`, | 
|  | 2870 | "api_surfaces": `[ | 
| Spandan Das | 627fc3e | 2023-01-26 23:02:00 +0000 | [diff] [blame] | 2871 | "module-libapi", | 
| Spandan Das | 4238c65 | 2022-09-09 01:38:47 +0000 | [diff] [blame] | 2872 | "vendorapi", | 
|  | 2873 | ]`, | 
|  | 2874 | "hdrs": `[ | 
| Spandan Das | 627fc3e | 2023-01-26 23:02:00 +0000 | [diff] [blame] | 2875 | ":libfoo.module-libapi.headers", | 
| Spandan Das | 4238c65 | 2022-09-09 01:38:47 +0000 | [diff] [blame] | 2876 | ":libfoo.vendorapi.headers", | 
|  | 2877 | ]`, | 
|  | 2878 | }), | 
|  | 2879 | } | 
|  | 2880 | RunApiBp2BuildTestCase(t, cc.RegisterLibraryBuildComponents, Bp2buildTestCase{ | 
|  | 2881 | Blueprint:            bp, | 
| Spandan Das | 627fc3e | 2023-01-26 23:02:00 +0000 | [diff] [blame] | 2882 | Description:          "cc API contributions to module-libapi and vendorapi", | 
| Spandan Das | 4238c65 | 2022-09-09 01:38:47 +0000 | [diff] [blame] | 2883 | ExpectedBazelTargets: expectedBazelTargets, | 
|  | 2884 | }) | 
|  | 2885 | } | 
|  | 2886 |  | 
|  | 2887 | func TestCcApiSurfaceCombinations(t *testing.T) { | 
|  | 2888 | testCases := []struct { | 
|  | 2889 | bp                  string | 
|  | 2890 | expectedApi         string | 
|  | 2891 | expectedApiSurfaces string | 
|  | 2892 | description         string | 
|  | 2893 | }{ | 
|  | 2894 | { | 
|  | 2895 | bp: ` | 
|  | 2896 | cc_library { | 
|  | 2897 | name: "a", | 
|  | 2898 | stubs: {symbol_file: "a.map.txt"}, | 
|  | 2899 | }`, | 
|  | 2900 | expectedApi:         `"a.map.txt"`, | 
| Spandan Das | 627fc3e | 2023-01-26 23:02:00 +0000 | [diff] [blame] | 2901 | expectedApiSurfaces: `["module-libapi"]`, | 
|  | 2902 | description:         "Library that contributes to module-libapi", | 
| Spandan Das | 4238c65 | 2022-09-09 01:38:47 +0000 | [diff] [blame] | 2903 | }, | 
|  | 2904 | { | 
|  | 2905 | bp: ` | 
|  | 2906 | cc_library { | 
|  | 2907 | name: "a", | 
|  | 2908 | llndk: {symbol_file: "a.map.txt"}, | 
|  | 2909 | }`, | 
|  | 2910 | expectedApi:         `"a.map.txt"`, | 
|  | 2911 | expectedApiSurfaces: `["vendorapi"]`, | 
|  | 2912 | description:         "Library that contributes to vendorapi", | 
|  | 2913 | }, | 
|  | 2914 | { | 
|  | 2915 | bp: ` | 
|  | 2916 | cc_library { | 
|  | 2917 | name: "a", | 
|  | 2918 | llndk: {symbol_file: "a.map.txt"}, | 
|  | 2919 | stubs: {symbol_file: "a.map.txt"}, | 
|  | 2920 | }`, | 
|  | 2921 | expectedApi: `"a.map.txt"`, | 
|  | 2922 | expectedApiSurfaces: `[ | 
| Spandan Das | 627fc3e | 2023-01-26 23:02:00 +0000 | [diff] [blame] | 2923 | "module-libapi", | 
| Spandan Das | 4238c65 | 2022-09-09 01:38:47 +0000 | [diff] [blame] | 2924 | "vendorapi", | 
|  | 2925 | ]`, | 
| Spandan Das | 627fc3e | 2023-01-26 23:02:00 +0000 | [diff] [blame] | 2926 | description: "Library that contributes to module-libapi and vendorapi", | 
| Spandan Das | 4238c65 | 2022-09-09 01:38:47 +0000 | [diff] [blame] | 2927 | }, | 
|  | 2928 | } | 
|  | 2929 | for _, testCase := range testCases { | 
|  | 2930 | expectedBazelTargets := []string{ | 
|  | 2931 | MakeBazelTarget( | 
|  | 2932 | "cc_api_contribution", | 
|  | 2933 | "a.contribution", | 
|  | 2934 | AttrNameToString{ | 
|  | 2935 | "library_name": `"a"`, | 
|  | 2936 | "hdrs":         `[]`, | 
|  | 2937 | "api":          testCase.expectedApi, | 
|  | 2938 | "api_surfaces": testCase.expectedApiSurfaces, | 
|  | 2939 | }, | 
|  | 2940 | ), | 
|  | 2941 | } | 
|  | 2942 | RunApiBp2BuildTestCase(t, cc.RegisterLibraryBuildComponents, Bp2buildTestCase{ | 
|  | 2943 | Blueprint:            testCase.bp, | 
|  | 2944 | Description:          testCase.description, | 
|  | 2945 | ExpectedBazelTargets: expectedBazelTargets, | 
|  | 2946 | }) | 
|  | 2947 | } | 
|  | 2948 | } | 
|  | 2949 |  | 
|  | 2950 | // llndk struct property in Soong provides users with several options to configure the exported include dirs | 
|  | 2951 | // Test the generated bazel targets for the different configurations | 
|  | 2952 | func TestCcVendorApiHeaders(t *testing.T) { | 
|  | 2953 | testCases := []struct { | 
|  | 2954 | bp                     string | 
|  | 2955 | expectedIncludes       string | 
|  | 2956 | expectedSystemIncludes string | 
|  | 2957 | description            string | 
|  | 2958 | }{ | 
|  | 2959 | { | 
|  | 2960 | bp: ` | 
|  | 2961 | cc_library { | 
|  | 2962 | name: "a", | 
|  | 2963 | export_include_dirs: ["include"], | 
|  | 2964 | export_system_include_dirs: ["base_system_include"], | 
|  | 2965 | llndk: { | 
|  | 2966 | symbol_file: "a.map.txt", | 
|  | 2967 | export_headers_as_system: true, | 
|  | 2968 | }, | 
|  | 2969 | } | 
|  | 2970 | `, | 
|  | 2971 | expectedIncludes: "", | 
|  | 2972 | expectedSystemIncludes: `[ | 
|  | 2973 | "base_system_include", | 
|  | 2974 | "include", | 
|  | 2975 | ]`, | 
|  | 2976 | description: "Headers are exported as system to API surface", | 
|  | 2977 | }, | 
|  | 2978 | { | 
|  | 2979 | bp: ` | 
|  | 2980 | cc_library { | 
|  | 2981 | name: "a", | 
|  | 2982 | export_include_dirs: ["include"], | 
|  | 2983 | export_system_include_dirs: ["base_system_include"], | 
|  | 2984 | llndk: { | 
|  | 2985 | symbol_file: "a.map.txt", | 
|  | 2986 | override_export_include_dirs: ["llndk_include"], | 
|  | 2987 | }, | 
|  | 2988 | } | 
|  | 2989 | `, | 
|  | 2990 | expectedIncludes:       `["llndk_include"]`, | 
|  | 2991 | expectedSystemIncludes: `["base_system_include"]`, | 
|  | 2992 | description:            "Non-system Headers are ovverriden before export to API surface", | 
|  | 2993 | }, | 
|  | 2994 | { | 
|  | 2995 | bp: ` | 
|  | 2996 | cc_library { | 
|  | 2997 | name: "a", | 
|  | 2998 | export_include_dirs: ["include"], | 
|  | 2999 | export_system_include_dirs: ["base_system_include"], | 
|  | 3000 | llndk: { | 
|  | 3001 | symbol_file: "a.map.txt", | 
|  | 3002 | override_export_include_dirs: ["llndk_include"], | 
|  | 3003 | export_headers_as_system: true, | 
|  | 3004 | }, | 
|  | 3005 | } | 
|  | 3006 | `, | 
|  | 3007 | expectedIncludes: "", // includes are set to nil | 
|  | 3008 | expectedSystemIncludes: `[ | 
|  | 3009 | "base_system_include", | 
|  | 3010 | "llndk_include", | 
|  | 3011 | ]`, | 
|  | 3012 | description: "System Headers are extended before export to API surface", | 
|  | 3013 | }, | 
|  | 3014 | } | 
|  | 3015 | for _, testCase := range testCases { | 
|  | 3016 | attrs := AttrNameToString{} | 
|  | 3017 | if testCase.expectedIncludes != "" { | 
|  | 3018 | attrs["export_includes"] = testCase.expectedIncludes | 
|  | 3019 | } | 
|  | 3020 | if testCase.expectedSystemIncludes != "" { | 
|  | 3021 | attrs["export_system_includes"] = testCase.expectedSystemIncludes | 
|  | 3022 | } | 
|  | 3023 |  | 
|  | 3024 | expectedBazelTargets := []string{ | 
|  | 3025 | MakeBazelTarget("cc_api_library_headers", "a.vendorapi.headers", attrs), | 
|  | 3026 | // Create a target for cc_api_contribution target | 
|  | 3027 | MakeBazelTarget("cc_api_contribution", "a.contribution", AttrNameToString{ | 
|  | 3028 | "api":          `"a.map.txt"`, | 
|  | 3029 | "api_surfaces": `["vendorapi"]`, | 
|  | 3030 | "hdrs":         `[":a.vendorapi.headers"]`, | 
|  | 3031 | "library_name": `"a"`, | 
|  | 3032 | }), | 
|  | 3033 | } | 
|  | 3034 | RunApiBp2BuildTestCase(t, cc.RegisterLibraryBuildComponents, Bp2buildTestCase{ | 
|  | 3035 | Blueprint:            testCase.bp, | 
|  | 3036 | ExpectedBazelTargets: expectedBazelTargets, | 
|  | 3037 | }) | 
|  | 3038 | } | 
|  | 3039 | } | 
|  | 3040 |  | 
| Trevor Radcliffe | 0ed6b7d | 2022-09-12 20:19:26 +0000 | [diff] [blame] | 3041 | func TestCcLibraryStubsAcrossConfigsDuplicatesRemoved(t *testing.T) { | 
|  | 3042 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3043 | Description:                "stub target generation of the same lib across configs should not result in duplicates", | 
|  | 3044 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3045 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3046 | Filesystem: map[string]string{ | 
|  | 3047 | "bar.map.txt": "", | 
|  | 3048 | }, | 
|  | 3049 | Blueprint: ` | 
|  | 3050 | cc_library { | 
|  | 3051 | name: "barlib", | 
|  | 3052 | stubs: { symbol_file: "bar.map.txt", versions: ["28", "29", "current"] }, | 
|  | 3053 | bazel_module: { bp2build_available: false }, | 
|  | 3054 | } | 
|  | 3055 | cc_library { | 
|  | 3056 | name: "foolib", | 
|  | 3057 | shared_libs: ["barlib"], | 
|  | 3058 | target: { | 
|  | 3059 | android: { | 
|  | 3060 | shared_libs: ["barlib"], | 
|  | 3061 | }, | 
|  | 3062 | }, | 
|  | 3063 | bazel_module: { bp2build_available: true }, | 
| Liz Kammer | 48cdbeb | 2023-03-17 10:17:50 -0400 | [diff] [blame] | 3064 | apex_available: ["foo"], | 
| Trevor Radcliffe | 0ed6b7d | 2022-09-12 20:19:26 +0000 | [diff] [blame] | 3065 | }`, | 
|  | 3066 | ExpectedBazelTargets: makeCcLibraryTargets("foolib", AttrNameToString{ | 
|  | 3067 | "implementation_dynamic_deps": `select({ | 
| Spandan Das | 6d4d9da | 2023-04-18 06:20:40 +0000 | [diff] [blame] | 3068 | "//build/bazel/rules/apex:foo": ["@api_surfaces//module-libapi/current:barlib"], | 
|  | 3069 | "//build/bazel/rules/apex:system": ["@api_surfaces//module-libapi/current:barlib"], | 
| Trevor Radcliffe | 0ed6b7d | 2022-09-12 20:19:26 +0000 | [diff] [blame] | 3070 | "//conditions:default": [":barlib"], | 
|  | 3071 | })`, | 
|  | 3072 | "local_includes": `["."]`, | 
| Liz Kammer | 48cdbeb | 2023-03-17 10:17:50 -0400 | [diff] [blame] | 3073 | "tags":           `["apex_available=foo"]`, | 
| Trevor Radcliffe | 0ed6b7d | 2022-09-12 20:19:26 +0000 | [diff] [blame] | 3074 | }), | 
|  | 3075 | }) | 
|  | 3076 | } | 
|  | 3077 |  | 
| Liz Kammer | ffc17e4 | 2022-11-23 09:42:05 -0500 | [diff] [blame] | 3078 | func TestCcLibraryExcludesLibsHost(t *testing.T) { | 
|  | 3079 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3080 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3081 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3082 | Filesystem: map[string]string{ | 
|  | 3083 | "bar.map.txt": "", | 
|  | 3084 | }, | 
|  | 3085 | Blueprint: simpleModuleDoNotConvertBp2build("cc_library", "bazlib") + ` | 
|  | 3086 | cc_library { | 
|  | 3087 | name: "quxlib", | 
|  | 3088 | stubs: { symbol_file: "bar.map.txt", versions: ["current"] }, | 
|  | 3089 | bazel_module: { bp2build_available: false }, | 
|  | 3090 | } | 
|  | 3091 | cc_library { | 
|  | 3092 | name: "barlib", | 
|  | 3093 | stubs: { symbol_file: "bar.map.txt", versions: ["28", "29", "current"] }, | 
|  | 3094 | bazel_module: { bp2build_available: false }, | 
|  | 3095 | } | 
|  | 3096 | cc_library { | 
|  | 3097 | name: "foolib", | 
|  | 3098 | shared_libs: ["barlib", "quxlib"], | 
|  | 3099 | target: { | 
|  | 3100 | host: { | 
|  | 3101 | shared_libs: ["bazlib"], | 
|  | 3102 | exclude_shared_libs: ["barlib"], | 
|  | 3103 | }, | 
|  | 3104 | }, | 
|  | 3105 | include_build_directory: false, | 
|  | 3106 | bazel_module: { bp2build_available: true }, | 
| Liz Kammer | 48cdbeb | 2023-03-17 10:17:50 -0400 | [diff] [blame] | 3107 | apex_available: ["foo"], | 
| Liz Kammer | ffc17e4 | 2022-11-23 09:42:05 -0500 | [diff] [blame] | 3108 | }`, | 
|  | 3109 | ExpectedBazelTargets: makeCcLibraryTargets("foolib", AttrNameToString{ | 
|  | 3110 | "implementation_dynamic_deps": `select({ | 
|  | 3111 | "//build/bazel/platforms/os:darwin": [":bazlib"], | 
| Liz Kammer | ffc17e4 | 2022-11-23 09:42:05 -0500 | [diff] [blame] | 3112 | "//build/bazel/platforms/os:linux_bionic": [":bazlib"], | 
| Colin Cross | 133782e | 2022-12-20 15:29:31 -0800 | [diff] [blame] | 3113 | "//build/bazel/platforms/os:linux_glibc": [":bazlib"], | 
| Liz Kammer | ffc17e4 | 2022-11-23 09:42:05 -0500 | [diff] [blame] | 3114 | "//build/bazel/platforms/os:linux_musl": [":bazlib"], | 
|  | 3115 | "//build/bazel/platforms/os:windows": [":bazlib"], | 
|  | 3116 | "//conditions:default": [], | 
|  | 3117 | }) + select({ | 
|  | 3118 | "//build/bazel/platforms/os:darwin": [":quxlib"], | 
| Liz Kammer | ffc17e4 | 2022-11-23 09:42:05 -0500 | [diff] [blame] | 3119 | "//build/bazel/platforms/os:linux_bionic": [":quxlib"], | 
| Colin Cross | 133782e | 2022-12-20 15:29:31 -0800 | [diff] [blame] | 3120 | "//build/bazel/platforms/os:linux_glibc": [":quxlib"], | 
| Liz Kammer | ffc17e4 | 2022-11-23 09:42:05 -0500 | [diff] [blame] | 3121 | "//build/bazel/platforms/os:linux_musl": [":quxlib"], | 
|  | 3122 | "//build/bazel/platforms/os:windows": [":quxlib"], | 
| Spandan Das | 6d4d9da | 2023-04-18 06:20:40 +0000 | [diff] [blame] | 3123 | "//build/bazel/rules/apex:foo": [ | 
|  | 3124 | "@api_surfaces//module-libapi/current:barlib", | 
|  | 3125 | "@api_surfaces//module-libapi/current:quxlib", | 
|  | 3126 | ], | 
|  | 3127 | "//build/bazel/rules/apex:system": [ | 
| Spandan Das | 2518c02 | 2023-03-17 03:02:32 +0000 | [diff] [blame] | 3128 | "@api_surfaces//module-libapi/current:barlib", | 
|  | 3129 | "@api_surfaces//module-libapi/current:quxlib", | 
| Liz Kammer | ffc17e4 | 2022-11-23 09:42:05 -0500 | [diff] [blame] | 3130 | ], | 
|  | 3131 | "//conditions:default": [ | 
|  | 3132 | ":barlib", | 
|  | 3133 | ":quxlib", | 
|  | 3134 | ], | 
|  | 3135 | })`, | 
| Liz Kammer | 48cdbeb | 2023-03-17 10:17:50 -0400 | [diff] [blame] | 3136 | "tags": `["apex_available=foo"]`, | 
| Liz Kammer | ffc17e4 | 2022-11-23 09:42:05 -0500 | [diff] [blame] | 3137 | }), | 
|  | 3138 | }) | 
|  | 3139 | } | 
|  | 3140 |  | 
| Liz Kammer | f38a837 | 2022-02-04 15:39:00 -0500 | [diff] [blame] | 3141 | func TestCcLibraryEscapeLdflags(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 3142 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3143 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3144 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3145 | Blueprint: soongCcProtoPreamble + `cc_library { | 
| Liz Kammer | f38a837 | 2022-02-04 15:39:00 -0500 | [diff] [blame] | 3146 | name: "foo", | 
|  | 3147 | ldflags: ["-Wl,--rpath,${ORIGIN}"], | 
|  | 3148 | include_build_directory: false, | 
|  | 3149 | }`, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 3150 | ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{ | 
| Liz Kammer | f38a837 | 2022-02-04 15:39:00 -0500 | [diff] [blame] | 3151 | "linkopts": `["-Wl,--rpath,$${ORIGIN}"]`, | 
|  | 3152 | }), | 
|  | 3153 | }) | 
|  | 3154 | } | 
| Trevor Radcliffe | ef9c900 | 2022-05-13 20:55:35 +0000 | [diff] [blame] | 3155 |  | 
|  | 3156 | func TestCcLibraryConvertLex(t *testing.T) { | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 3157 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3158 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3159 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3160 | Filesystem: map[string]string{ | 
| Trevor Radcliffe | ef9c900 | 2022-05-13 20:55:35 +0000 | [diff] [blame] | 3161 | "foo.c":   "", | 
|  | 3162 | "bar.cc":  "", | 
|  | 3163 | "foo1.l":  "", | 
|  | 3164 | "bar1.ll": "", | 
|  | 3165 | "foo2.l":  "", | 
|  | 3166 | "bar2.ll": "", | 
|  | 3167 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 3168 | Blueprint: `cc_library { | 
| Trevor Radcliffe | ef9c900 | 2022-05-13 20:55:35 +0000 | [diff] [blame] | 3169 | name: "foo_lib", | 
|  | 3170 | srcs: ["foo.c", "bar.cc", "foo1.l", "foo2.l", "bar1.ll", "bar2.ll"], | 
|  | 3171 | lex: { flags: ["--foo_flags"] }, | 
|  | 3172 | include_build_directory: false, | 
|  | 3173 | bazel_module: { bp2build_available: true }, | 
|  | 3174 | }`, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 3175 | ExpectedBazelTargets: append([]string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3176 | MakeBazelTarget("genlex", "foo_lib_genlex_l", AttrNameToString{ | 
| Trevor Radcliffe | ef9c900 | 2022-05-13 20:55:35 +0000 | [diff] [blame] | 3177 | "srcs": `[ | 
|  | 3178 | "foo1.l", | 
|  | 3179 | "foo2.l", | 
|  | 3180 | ]`, | 
|  | 3181 | "lexopts": `["--foo_flags"]`, | 
|  | 3182 | }), | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3183 | MakeBazelTarget("genlex", "foo_lib_genlex_ll", AttrNameToString{ | 
| Trevor Radcliffe | ef9c900 | 2022-05-13 20:55:35 +0000 | [diff] [blame] | 3184 | "srcs": `[ | 
|  | 3185 | "bar1.ll", | 
|  | 3186 | "bar2.ll", | 
|  | 3187 | ]`, | 
|  | 3188 | "lexopts": `["--foo_flags"]`, | 
|  | 3189 | }), | 
|  | 3190 | }, | 
| Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 3191 | makeCcLibraryTargets("foo_lib", AttrNameToString{ | 
| Trevor Radcliffe | ef9c900 | 2022-05-13 20:55:35 +0000 | [diff] [blame] | 3192 | "srcs": `[ | 
|  | 3193 | "bar.cc", | 
|  | 3194 | ":foo_lib_genlex_ll", | 
|  | 3195 | ]`, | 
|  | 3196 | "srcs_c": `[ | 
|  | 3197 | "foo.c", | 
|  | 3198 | ":foo_lib_genlex_l", | 
|  | 3199 | ]`, | 
|  | 3200 | })...), | 
|  | 3201 | }) | 
|  | 3202 | } | 
| Cole Faust | 6b29f59 | 2022-08-09 09:50:56 -0700 | [diff] [blame] | 3203 |  | 
|  | 3204 | func TestCCLibraryRuntimeDeps(t *testing.T) { | 
|  | 3205 | runCcLibrarySharedTestCase(t, Bp2buildTestCase{ | 
|  | 3206 | Blueprint: `cc_library_shared { | 
|  | 3207 | name: "bar", | 
|  | 3208 | } | 
|  | 3209 |  | 
|  | 3210 | cc_library { | 
|  | 3211 | name: "foo", | 
|  | 3212 | runtime_libs: ["foo"], | 
|  | 3213 | }`, | 
|  | 3214 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3215 | MakeBazelTarget("cc_library_shared", "bar", AttrNameToString{ | 
| Cole Faust | 6b29f59 | 2022-08-09 09:50:56 -0700 | [diff] [blame] | 3216 | "local_includes": `["."]`, | 
|  | 3217 | }), | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3218 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
| Cole Faust | 6b29f59 | 2022-08-09 09:50:56 -0700 | [diff] [blame] | 3219 | "runtime_deps":   `[":foo"]`, | 
|  | 3220 | "local_includes": `["."]`, | 
|  | 3221 | }), | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3222 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
| Cole Faust | 6b29f59 | 2022-08-09 09:50:56 -0700 | [diff] [blame] | 3223 | "runtime_deps":   `[":foo"]`, | 
|  | 3224 | "local_includes": `["."]`, | 
|  | 3225 | }), | 
|  | 3226 | }, | 
|  | 3227 | }) | 
|  | 3228 | } | 
| Cole Faust | 5fa4e96 | 2022-08-22 14:31:04 -0700 | [diff] [blame] | 3229 |  | 
|  | 3230 | func TestCcLibraryWithInstructionSet(t *testing.T) { | 
|  | 3231 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3232 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3233 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3234 | Blueprint: `cc_library { | 
|  | 3235 | name: "foo", | 
|  | 3236 | arch: { | 
|  | 3237 | arm: { | 
|  | 3238 | instruction_set: "arm", | 
|  | 3239 | } | 
|  | 3240 | } | 
|  | 3241 | } | 
|  | 3242 | `, | 
|  | 3243 | ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{ | 
|  | 3244 | "features": `select({ | 
| Trevor Radcliffe | 5f0c2ac | 2023-05-15 18:00:59 +0000 | [diff] [blame] | 3245 | "//build/bazel/platforms/arch:arm": ["arm_isa_arm"], | 
| Cole Faust | 5fa4e96 | 2022-08-22 14:31:04 -0700 | [diff] [blame] | 3246 | "//conditions:default": [], | 
|  | 3247 | })`, | 
|  | 3248 | "local_includes": `["."]`, | 
|  | 3249 | }), | 
|  | 3250 | }) | 
|  | 3251 | } | 
| Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3252 |  | 
| Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | a56e970 | 2022-02-23 18:39:59 -0500 | [diff] [blame] | 3253 | func TestCcLibraryEmptySuffix(t *testing.T) { | 
|  | 3254 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3255 | Description:                "cc_library with empty suffix", | 
|  | 3256 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3257 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3258 | Filesystem: map[string]string{ | 
|  | 3259 | "foo.c": "", | 
|  | 3260 | }, | 
|  | 3261 | Blueprint: `cc_library { | 
|  | 3262 | name: "foo", | 
|  | 3263 | suffix: "", | 
|  | 3264 | srcs: ["foo.c"], | 
|  | 3265 | include_build_directory: false, | 
|  | 3266 | }`, | 
|  | 3267 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3268 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
| Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | a56e970 | 2022-02-23 18:39:59 -0500 | [diff] [blame] | 3269 | "srcs_c": `["foo.c"]`, | 
|  | 3270 | }), | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3271 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
| Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | a56e970 | 2022-02-23 18:39:59 -0500 | [diff] [blame] | 3272 | "srcs_c": `["foo.c"]`, | 
|  | 3273 | "suffix": `""`, | 
|  | 3274 | }), | 
|  | 3275 | }, | 
|  | 3276 | }) | 
|  | 3277 | } | 
|  | 3278 |  | 
|  | 3279 | func TestCcLibrarySuffix(t *testing.T) { | 
|  | 3280 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3281 | Description:                "cc_library with suffix", | 
|  | 3282 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3283 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3284 | Filesystem: map[string]string{ | 
|  | 3285 | "foo.c": "", | 
|  | 3286 | }, | 
|  | 3287 | Blueprint: `cc_library { | 
|  | 3288 | name: "foo", | 
|  | 3289 | suffix: "-suf", | 
|  | 3290 | srcs: ["foo.c"], | 
|  | 3291 | include_build_directory: false, | 
|  | 3292 | }`, | 
|  | 3293 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3294 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
| Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | a56e970 | 2022-02-23 18:39:59 -0500 | [diff] [blame] | 3295 | "srcs_c": `["foo.c"]`, | 
|  | 3296 | }), | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3297 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
| Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | a56e970 | 2022-02-23 18:39:59 -0500 | [diff] [blame] | 3298 | "srcs_c": `["foo.c"]`, | 
|  | 3299 | "suffix": `"-suf"`, | 
|  | 3300 | }), | 
|  | 3301 | }, | 
|  | 3302 | }) | 
|  | 3303 | } | 
|  | 3304 |  | 
|  | 3305 | func TestCcLibraryArchVariantSuffix(t *testing.T) { | 
|  | 3306 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3307 | Description:                "cc_library with arch-variant suffix", | 
|  | 3308 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3309 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3310 | Filesystem: map[string]string{ | 
|  | 3311 | "foo.c": "", | 
|  | 3312 | }, | 
|  | 3313 | Blueprint: `cc_library { | 
|  | 3314 | name: "foo", | 
|  | 3315 | arch: { | 
|  | 3316 | arm64: { suffix: "-64" }, | 
|  | 3317 | arm:   { suffix: "-32" }, | 
|  | 3318 | }, | 
|  | 3319 | srcs: ["foo.c"], | 
|  | 3320 | include_build_directory: false, | 
|  | 3321 | }`, | 
|  | 3322 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3323 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
| Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | a56e970 | 2022-02-23 18:39:59 -0500 | [diff] [blame] | 3324 | "srcs_c": `["foo.c"]`, | 
|  | 3325 | }), | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3326 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
| Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | a56e970 | 2022-02-23 18:39:59 -0500 | [diff] [blame] | 3327 | "srcs_c": `["foo.c"]`, | 
|  | 3328 | "suffix": `select({ | 
|  | 3329 | "//build/bazel/platforms/arch:arm": "-32", | 
|  | 3330 | "//build/bazel/platforms/arch:arm64": "-64", | 
|  | 3331 | "//conditions:default": None, | 
|  | 3332 | })`, | 
|  | 3333 | }), | 
|  | 3334 | }, | 
|  | 3335 | }) | 
|  | 3336 | } | 
|  | 3337 |  | 
| Vinh Tran | 367d89d | 2023-04-28 11:21:25 -0400 | [diff] [blame] | 3338 | func TestCcLibraryWithAidlLibrary(t *testing.T) { | 
|  | 3339 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3340 | Description:                "cc_library with aidl_library", | 
|  | 3341 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3342 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3343 | Blueprint: ` | 
|  | 3344 | aidl_library { | 
|  | 3345 | name: "A_aidl", | 
|  | 3346 | srcs: ["aidl/A.aidl"], | 
|  | 3347 | hdrs: ["aidl/Header.aidl"], | 
|  | 3348 | strip_import_prefix: "aidl", | 
|  | 3349 | } | 
|  | 3350 | cc_library { | 
|  | 3351 | name: "foo", | 
|  | 3352 | aidl: { | 
|  | 3353 | libs: ["A_aidl"], | 
| Vinh Tran | e684294 | 2023-04-28 11:21:25 -0400 | [diff] [blame] | 3354 | }, | 
|  | 3355 | export_include_dirs: ["include"], | 
| Vinh Tran | 367d89d | 2023-04-28 11:21:25 -0400 | [diff] [blame] | 3356 | }`, | 
|  | 3357 | ExpectedBazelTargets: []string{ | 
|  | 3358 | MakeBazelTargetNoRestrictions("aidl_library", "A_aidl", AttrNameToString{ | 
|  | 3359 | "srcs":                `["aidl/A.aidl"]`, | 
|  | 3360 | "hdrs":                `["aidl/Header.aidl"]`, | 
|  | 3361 | "strip_import_prefix": `"aidl"`, | 
|  | 3362 | "tags":                `["apex_available=//apex_available:anyapex"]`, | 
|  | 3363 | }), | 
|  | 3364 | MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{ | 
| Vinh Tran | e684294 | 2023-04-28 11:21:25 -0400 | [diff] [blame] | 3365 | "deps":            `[":A_aidl"]`, | 
|  | 3366 | "local_includes":  `["."]`, | 
|  | 3367 | "export_includes": `["include"]`, | 
| Vinh Tran | 367d89d | 2023-04-28 11:21:25 -0400 | [diff] [blame] | 3368 | }), | 
|  | 3369 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 3370 | "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`, | 
|  | 3371 | "local_includes":                    `["."]`, | 
| Vinh Tran | e684294 | 2023-04-28 11:21:25 -0400 | [diff] [blame] | 3372 | "export_includes":                   `["include"]`, | 
| Vinh Tran | 367d89d | 2023-04-28 11:21:25 -0400 | [diff] [blame] | 3373 | }), | 
|  | 3374 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 3375 | "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`, | 
|  | 3376 | "local_includes":                    `["."]`, | 
| Vinh Tran | e684294 | 2023-04-28 11:21:25 -0400 | [diff] [blame] | 3377 | "export_includes":                   `["include"]`, | 
| Vinh Tran | 367d89d | 2023-04-28 11:21:25 -0400 | [diff] [blame] | 3378 | }), | 
|  | 3379 | }, | 
|  | 3380 | }) | 
|  | 3381 | } | 
|  | 3382 |  | 
| Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3383 | func TestCcLibraryWithAidlSrcs(t *testing.T) { | 
|  | 3384 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3385 | Description:                "cc_library with aidl srcs", | 
|  | 3386 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3387 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3388 | Blueprint: ` | 
|  | 3389 | filegroup { | 
|  | 3390 | name: "A_aidl", | 
|  | 3391 | srcs: ["aidl/A.aidl"], | 
|  | 3392 | path: "aidl", | 
|  | 3393 | } | 
|  | 3394 | cc_library { | 
|  | 3395 | name: "foo", | 
|  | 3396 | srcs: [ | 
|  | 3397 | ":A_aidl", | 
|  | 3398 | "B.aidl", | 
|  | 3399 | ], | 
|  | 3400 | }`, | 
|  | 3401 | ExpectedBazelTargets: []string{ | 
|  | 3402 | MakeBazelTargetNoRestrictions("aidl_library", "A_aidl", AttrNameToString{ | 
|  | 3403 | "srcs":                `["aidl/A.aidl"]`, | 
|  | 3404 | "strip_import_prefix": `"aidl"`, | 
| Liz Kammer | 2b3f56e | 2023-03-23 11:51:49 -0400 | [diff] [blame] | 3405 | "tags":                `["apex_available=//apex_available:anyapex"]`, | 
| Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3406 | }), | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3407 | MakeBazelTarget("aidl_library", "foo_aidl_library", AttrNameToString{ | 
| Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3408 | "srcs": `["B.aidl"]`, | 
|  | 3409 | }), | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3410 | MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{ | 
| Vinh Tran | e684294 | 2023-04-28 11:21:25 -0400 | [diff] [blame] | 3411 | "local_includes": `["."]`, | 
| Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3412 | "deps": `[ | 
|  | 3413 | ":A_aidl", | 
|  | 3414 | ":foo_aidl_library", | 
|  | 3415 | ]`, | 
|  | 3416 | }), | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3417 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
| Vinh Tran | fde57eb | 2022-08-29 17:46:58 -0400 | [diff] [blame] | 3418 | "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`, | 
|  | 3419 | "local_includes":                    `["."]`, | 
| Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3420 | }), | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3421 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
| Liz Kammer | 84b0ecb | 2022-09-14 10:49:13 -0400 | [diff] [blame] | 3422 | "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`, | 
|  | 3423 | "local_includes":                    `["."]`, | 
| Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3424 | }), | 
|  | 3425 | }, | 
|  | 3426 | }) | 
|  | 3427 | } | 
|  | 3428 |  | 
|  | 3429 | func TestCcLibraryWithNonAdjacentAidlFilegroup(t *testing.T) { | 
|  | 3430 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3431 | Description:                "cc_library with non aidl filegroup", | 
|  | 3432 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3433 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3434 | Filesystem: map[string]string{ | 
|  | 3435 | "path/to/A/Android.bp": ` | 
|  | 3436 | filegroup { | 
| Vinh Tran | fde57eb | 2022-08-29 17:46:58 -0400 | [diff] [blame] | 3437 | name: "A_aidl", | 
|  | 3438 | srcs: ["aidl/A.aidl"], | 
|  | 3439 | path: "aidl", | 
| Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3440 | }`, | 
|  | 3441 | }, | 
|  | 3442 | Blueprint: ` | 
|  | 3443 | cc_library { | 
| Vinh Tran | fde57eb | 2022-08-29 17:46:58 -0400 | [diff] [blame] | 3444 | name: "foo", | 
|  | 3445 | srcs: [ | 
|  | 3446 | ":A_aidl", | 
|  | 3447 | ], | 
| Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3448 | }`, | 
|  | 3449 | ExpectedBazelTargets: []string{ | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3450 | MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{ | 
| Vinh Tran | e684294 | 2023-04-28 11:21:25 -0400 | [diff] [blame] | 3451 | "local_includes": `["."]`, | 
|  | 3452 | "deps":           `["//path/to/A:A_aidl"]`, | 
| Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3453 | }), | 
| Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3454 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
| Vinh Tran | fde57eb | 2022-08-29 17:46:58 -0400 | [diff] [blame] | 3455 | "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`, | 
|  | 3456 | "local_includes":                    `["."]`, | 
|  | 3457 | }), | 
| Vinh Tran | fde57eb | 2022-08-29 17:46:58 -0400 | [diff] [blame] | 3458 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
| Liz Kammer | 84b0ecb | 2022-09-14 10:49:13 -0400 | [diff] [blame] | 3459 | "local_includes":                    `["."]`, | 
|  | 3460 | "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`, | 
| Vinh Tran | fde57eb | 2022-08-29 17:46:58 -0400 | [diff] [blame] | 3461 | }), | 
|  | 3462 | }, | 
|  | 3463 | }) | 
|  | 3464 | } | 
|  | 3465 |  | 
|  | 3466 | func TestCcLibraryWithExportAidlHeaders(t *testing.T) { | 
| Vinh Tran | 367d89d | 2023-04-28 11:21:25 -0400 | [diff] [blame] | 3467 | t.Parallel() | 
|  | 3468 |  | 
|  | 3469 | expectedBazelTargets := []string{ | 
|  | 3470 | MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{ | 
| Vinh Tran | e684294 | 2023-04-28 11:21:25 -0400 | [diff] [blame] | 3471 | "local_includes": `["."]`, | 
|  | 3472 | "deps":           `[":foo_aidl_library"]`, | 
| Vinh Tran | 367d89d | 2023-04-28 11:21:25 -0400 | [diff] [blame] | 3473 | }), | 
|  | 3474 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 3475 | "whole_archive_deps": `[":foo_cc_aidl_library"]`, | 
|  | 3476 | "local_includes":     `["."]`, | 
|  | 3477 | }), | 
|  | 3478 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 3479 | "whole_archive_deps": `[":foo_cc_aidl_library"]`, | 
|  | 3480 | "local_includes":     `["."]`, | 
|  | 3481 | }), | 
|  | 3482 | } | 
|  | 3483 | testCases := []struct { | 
|  | 3484 | description          string | 
|  | 3485 | bp                   string | 
|  | 3486 | expectedBazelTargets []string | 
|  | 3487 | }{ | 
|  | 3488 | { | 
|  | 3489 | description: "cc_library with aidl srcs and aidl.export_aidl_headers set", | 
|  | 3490 | bp: ` | 
|  | 3491 | cc_library { | 
|  | 3492 | name: "foo", | 
|  | 3493 | srcs: [ | 
|  | 3494 | "Foo.aidl", | 
|  | 3495 | ], | 
|  | 3496 | aidl: { | 
|  | 3497 | export_aidl_headers: true, | 
|  | 3498 | } | 
|  | 3499 | }`, | 
|  | 3500 | expectedBazelTargets: append( | 
|  | 3501 | expectedBazelTargets, | 
|  | 3502 | MakeBazelTarget("aidl_library", "foo_aidl_library", AttrNameToString{ | 
|  | 3503 | "srcs": `["Foo.aidl"]`, | 
|  | 3504 | })), | 
| Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3505 | }, | 
| Vinh Tran | 367d89d | 2023-04-28 11:21:25 -0400 | [diff] [blame] | 3506 | { | 
|  | 3507 | description: "cc_library with aidl.libs and aidl.export_aidl_headers set", | 
|  | 3508 | bp: ` | 
|  | 3509 | aidl_library { | 
|  | 3510 | name: "foo_aidl_library", | 
|  | 3511 | srcs: ["Foo.aidl"], | 
|  | 3512 | } | 
|  | 3513 | cc_library { | 
|  | 3514 | name: "foo", | 
|  | 3515 | aidl: { | 
|  | 3516 | libs: ["foo_aidl_library"], | 
|  | 3517 | export_aidl_headers: true, | 
|  | 3518 | } | 
|  | 3519 | }`, | 
|  | 3520 | expectedBazelTargets: append( | 
|  | 3521 | expectedBazelTargets, | 
|  | 3522 | MakeBazelTargetNoRestrictions("aidl_library", "foo_aidl_library", AttrNameToString{ | 
|  | 3523 | "srcs": `["Foo.aidl"]`, | 
|  | 3524 | "tags": `["apex_available=//apex_available:anyapex"]`, | 
|  | 3525 | }), | 
|  | 3526 | ), | 
|  | 3527 | }, | 
|  | 3528 | } | 
|  | 3529 |  | 
|  | 3530 | for _, testCase := range testCases { | 
|  | 3531 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3532 | Description:                "cc_library with export aidl headers", | 
|  | 3533 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3534 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3535 | Blueprint:                  testCase.bp, | 
|  | 3536 | ExpectedBazelTargets:       testCase.expectedBazelTargets, | 
|  | 3537 | }) | 
|  | 3538 | } | 
| Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3539 | } | 
| Vinh Tran | 85fb07c | 2022-09-16 16:17:48 -0400 | [diff] [blame] | 3540 |  | 
|  | 3541 | func TestCcLibraryWithTargetApex(t *testing.T) { | 
|  | 3542 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3543 | Description:                "cc_library with target.apex", | 
|  | 3544 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3545 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3546 | Blueprint: ` | 
|  | 3547 | cc_library { | 
|  | 3548 | name: "foo", | 
|  | 3549 | shared_libs: ["bar", "baz"], | 
|  | 3550 | static_libs: ["baz", "buh"], | 
|  | 3551 | target: { | 
|  | 3552 | apex: { | 
|  | 3553 | exclude_shared_libs: ["bar"], | 
|  | 3554 | exclude_static_libs: ["buh"], | 
|  | 3555 | } | 
|  | 3556 | } | 
|  | 3557 | }`, | 
|  | 3558 | ExpectedBazelTargets: []string{ | 
|  | 3559 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 3560 | "implementation_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({ | 
| Liz Kammer | 748d707 | 2023-01-25 12:07:43 -0500 | [diff] [blame] | 3561 | "//build/bazel/rules/apex:in_apex": [], | 
|  | 3562 | "//conditions:default": [":buh__BP2BUILD__MISSING__DEP"], | 
| Vinh Tran | 85fb07c | 2022-09-16 16:17:48 -0400 | [diff] [blame] | 3563 | })`, | 
|  | 3564 | "implementation_dynamic_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({ | 
| Liz Kammer | 748d707 | 2023-01-25 12:07:43 -0500 | [diff] [blame] | 3565 | "//build/bazel/rules/apex:in_apex": [], | 
|  | 3566 | "//conditions:default": [":bar__BP2BUILD__MISSING__DEP"], | 
| Vinh Tran | 85fb07c | 2022-09-16 16:17:48 -0400 | [diff] [blame] | 3567 | })`, | 
|  | 3568 | "local_includes": `["."]`, | 
|  | 3569 | }), | 
|  | 3570 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 3571 | "implementation_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({ | 
| Liz Kammer | 748d707 | 2023-01-25 12:07:43 -0500 | [diff] [blame] | 3572 | "//build/bazel/rules/apex:in_apex": [], | 
|  | 3573 | "//conditions:default": [":buh__BP2BUILD__MISSING__DEP"], | 
| Vinh Tran | 85fb07c | 2022-09-16 16:17:48 -0400 | [diff] [blame] | 3574 | })`, | 
|  | 3575 | "implementation_dynamic_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({ | 
| Liz Kammer | 748d707 | 2023-01-25 12:07:43 -0500 | [diff] [blame] | 3576 | "//build/bazel/rules/apex:in_apex": [], | 
|  | 3577 | "//conditions:default": [":bar__BP2BUILD__MISSING__DEP"], | 
| Vinh Tran | 85fb07c | 2022-09-16 16:17:48 -0400 | [diff] [blame] | 3578 | })`, | 
|  | 3579 | "local_includes": `["."]`, | 
|  | 3580 | }), | 
|  | 3581 | }, | 
|  | 3582 | }) | 
|  | 3583 | } | 
|  | 3584 |  | 
|  | 3585 | func TestCcLibraryWithTargetApexAndExportLibHeaders(t *testing.T) { | 
|  | 3586 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3587 | Description:                "cc_library with target.apex and export_shared|static_lib_headers", | 
|  | 3588 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3589 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3590 | Blueprint: ` | 
|  | 3591 | cc_library_static { | 
|  | 3592 | name: "foo", | 
|  | 3593 | shared_libs: ["bar", "baz"], | 
|  | 3594 | static_libs: ["abc"], | 
|  | 3595 | export_shared_lib_headers: ["baz"], | 
|  | 3596 | export_static_lib_headers: ["abc"], | 
|  | 3597 | target: { | 
|  | 3598 | apex: { | 
|  | 3599 | exclude_shared_libs: ["baz", "bar"], | 
|  | 3600 | exclude_static_libs: ["abc"], | 
|  | 3601 | } | 
|  | 3602 | } | 
|  | 3603 | }`, | 
|  | 3604 | ExpectedBazelTargets: []string{ | 
|  | 3605 | MakeBazelTarget("cc_library_static", "foo", AttrNameToString{ | 
|  | 3606 | "implementation_dynamic_deps": `select({ | 
| Liz Kammer | 748d707 | 2023-01-25 12:07:43 -0500 | [diff] [blame] | 3607 | "//build/bazel/rules/apex:in_apex": [], | 
|  | 3608 | "//conditions:default": [":bar__BP2BUILD__MISSING__DEP"], | 
| Vinh Tran | 85fb07c | 2022-09-16 16:17:48 -0400 | [diff] [blame] | 3609 | })`, | 
|  | 3610 | "dynamic_deps": `select({ | 
| Liz Kammer | 748d707 | 2023-01-25 12:07:43 -0500 | [diff] [blame] | 3611 | "//build/bazel/rules/apex:in_apex": [], | 
|  | 3612 | "//conditions:default": [":baz__BP2BUILD__MISSING__DEP"], | 
| Vinh Tran | 85fb07c | 2022-09-16 16:17:48 -0400 | [diff] [blame] | 3613 | })`, | 
|  | 3614 | "deps": `select({ | 
| Liz Kammer | 748d707 | 2023-01-25 12:07:43 -0500 | [diff] [blame] | 3615 | "//build/bazel/rules/apex:in_apex": [], | 
|  | 3616 | "//conditions:default": [":abc__BP2BUILD__MISSING__DEP"], | 
| Vinh Tran | 85fb07c | 2022-09-16 16:17:48 -0400 | [diff] [blame] | 3617 | })`, | 
|  | 3618 | "local_includes": `["."]`, | 
|  | 3619 | }), | 
|  | 3620 | }, | 
|  | 3621 | }) | 
|  | 3622 | } | 
| Trevor Radcliffe | cee4e05 | 2022-09-06 19:31:25 +0000 | [diff] [blame] | 3623 |  | 
|  | 3624 | func TestCcLibraryWithSyspropSrcs(t *testing.T) { | 
|  | 3625 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3626 | Description:                "cc_library with sysprop sources", | 
|  | 3627 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3628 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3629 | Blueprint: ` | 
|  | 3630 | cc_library { | 
|  | 3631 | name: "foo", | 
|  | 3632 | srcs: [ | 
|  | 3633 | "bar.sysprop", | 
|  | 3634 | "baz.sysprop", | 
|  | 3635 | "blah.cpp", | 
|  | 3636 | ], | 
|  | 3637 | min_sdk_version: "5", | 
|  | 3638 | }`, | 
|  | 3639 | ExpectedBazelTargets: []string{ | 
|  | 3640 | MakeBazelTarget("sysprop_library", "foo_sysprop_library", AttrNameToString{ | 
|  | 3641 | "srcs": `[ | 
|  | 3642 | "bar.sysprop", | 
|  | 3643 | "baz.sysprop", | 
|  | 3644 | ]`, | 
|  | 3645 | }), | 
|  | 3646 | MakeBazelTarget("cc_sysprop_library_static", "foo_cc_sysprop_library_static", AttrNameToString{ | 
|  | 3647 | "dep":             `":foo_sysprop_library"`, | 
|  | 3648 | "min_sdk_version": `"5"`, | 
|  | 3649 | }), | 
|  | 3650 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 3651 | "srcs":               `["blah.cpp"]`, | 
|  | 3652 | "local_includes":     `["."]`, | 
|  | 3653 | "min_sdk_version":    `"5"`, | 
|  | 3654 | "whole_archive_deps": `[":foo_cc_sysprop_library_static"]`, | 
|  | 3655 | }), | 
|  | 3656 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 3657 | "srcs":               `["blah.cpp"]`, | 
|  | 3658 | "local_includes":     `["."]`, | 
|  | 3659 | "min_sdk_version":    `"5"`, | 
|  | 3660 | "whole_archive_deps": `[":foo_cc_sysprop_library_static"]`, | 
|  | 3661 | }), | 
|  | 3662 | }, | 
|  | 3663 | }) | 
|  | 3664 | } | 
|  | 3665 |  | 
|  | 3666 | func TestCcLibraryWithSyspropSrcsSomeConfigs(t *testing.T) { | 
|  | 3667 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3668 | Description:                "cc_library with sysprop sources in some configs but not others", | 
|  | 3669 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3670 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3671 | Blueprint: ` | 
|  | 3672 | cc_library { | 
|  | 3673 | name: "foo", | 
|  | 3674 | host_supported: true, | 
|  | 3675 | srcs: [ | 
|  | 3676 | "blah.cpp", | 
|  | 3677 | ], | 
|  | 3678 | target: { | 
|  | 3679 | android: { | 
|  | 3680 | srcs: ["bar.sysprop"], | 
|  | 3681 | }, | 
|  | 3682 | }, | 
|  | 3683 | min_sdk_version: "5", | 
|  | 3684 | }`, | 
|  | 3685 | ExpectedBazelTargets: []string{ | 
|  | 3686 | MakeBazelTargetNoRestrictions("sysprop_library", "foo_sysprop_library", AttrNameToString{ | 
|  | 3687 | "srcs": `select({ | 
|  | 3688 | "//build/bazel/platforms/os:android": ["bar.sysprop"], | 
|  | 3689 | "//conditions:default": [], | 
|  | 3690 | })`, | 
|  | 3691 | }), | 
|  | 3692 | MakeBazelTargetNoRestrictions("cc_sysprop_library_static", "foo_cc_sysprop_library_static", AttrNameToString{ | 
|  | 3693 | "dep":             `":foo_sysprop_library"`, | 
|  | 3694 | "min_sdk_version": `"5"`, | 
|  | 3695 | }), | 
|  | 3696 | MakeBazelTargetNoRestrictions("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 3697 | "srcs":            `["blah.cpp"]`, | 
|  | 3698 | "local_includes":  `["."]`, | 
|  | 3699 | "min_sdk_version": `"5"`, | 
|  | 3700 | "whole_archive_deps": `select({ | 
|  | 3701 | "//build/bazel/platforms/os:android": [":foo_cc_sysprop_library_static"], | 
|  | 3702 | "//conditions:default": [], | 
|  | 3703 | })`, | 
|  | 3704 | }), | 
|  | 3705 | MakeBazelTargetNoRestrictions("cc_library_shared", "foo", AttrNameToString{ | 
|  | 3706 | "srcs":            `["blah.cpp"]`, | 
|  | 3707 | "local_includes":  `["."]`, | 
|  | 3708 | "min_sdk_version": `"5"`, | 
|  | 3709 | "whole_archive_deps": `select({ | 
|  | 3710 | "//build/bazel/platforms/os:android": [":foo_cc_sysprop_library_static"], | 
|  | 3711 | "//conditions:default": [], | 
|  | 3712 | })`, | 
|  | 3713 | }), | 
|  | 3714 | }, | 
|  | 3715 | }) | 
|  | 3716 | } | 
| Vinh Tran | 395a1e9 | 2022-09-16 18:27:29 -0400 | [diff] [blame] | 3717 |  | 
| Sam Delmerico | 512437b | 2023-03-17 11:34:15 -0400 | [diff] [blame] | 3718 | func TestCcLibraryWithAidlAndLibs(t *testing.T) { | 
| Vinh Tran | 395a1e9 | 2022-09-16 18:27:29 -0400 | [diff] [blame] | 3719 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
| Sam Delmerico | 512437b | 2023-03-17 11:34:15 -0400 | [diff] [blame] | 3720 | Description:                "cc_aidl_library depends on libs from parent cc_library_static", | 
| Vinh Tran | 395a1e9 | 2022-09-16 18:27:29 -0400 | [diff] [blame] | 3721 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3722 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3723 | Blueprint: ` | 
|  | 3724 | cc_library_static { | 
| Sam Delmerico | 512437b | 2023-03-17 11:34:15 -0400 | [diff] [blame] | 3725 | name: "foo", | 
|  | 3726 | srcs: [ | 
|  | 3727 | "Foo.aidl", | 
|  | 3728 | ], | 
|  | 3729 | static_libs: [ | 
|  | 3730 | "bar-static", | 
|  | 3731 | "baz-static", | 
|  | 3732 | ], | 
| Vinh Tran | 395a1e9 | 2022-09-16 18:27:29 -0400 | [diff] [blame] | 3733 | shared_libs: [ | 
| Sam Delmerico | 512437b | 2023-03-17 11:34:15 -0400 | [diff] [blame] | 3734 | "bar-shared", | 
|  | 3735 | "baz-shared", | 
|  | 3736 | ], | 
|  | 3737 | export_static_lib_headers: [ | 
|  | 3738 | "baz-static", | 
| Vinh Tran | 395a1e9 | 2022-09-16 18:27:29 -0400 | [diff] [blame] | 3739 | ], | 
|  | 3740 | export_shared_lib_headers: [ | 
| Sam Delmerico | 512437b | 2023-03-17 11:34:15 -0400 | [diff] [blame] | 3741 | "baz-shared", | 
| Vinh Tran | 395a1e9 | 2022-09-16 18:27:29 -0400 | [diff] [blame] | 3742 | ], | 
|  | 3743 | }` + | 
| Sam Delmerico | 512437b | 2023-03-17 11:34:15 -0400 | [diff] [blame] | 3744 | simpleModuleDoNotConvertBp2build("cc_library_static", "bar-static") + | 
|  | 3745 | simpleModuleDoNotConvertBp2build("cc_library_static", "baz-static") + | 
|  | 3746 | simpleModuleDoNotConvertBp2build("cc_library", "bar-shared") + | 
|  | 3747 | simpleModuleDoNotConvertBp2build("cc_library", "baz-shared"), | 
| Vinh Tran | 395a1e9 | 2022-09-16 18:27:29 -0400 | [diff] [blame] | 3748 | ExpectedBazelTargets: []string{ | 
|  | 3749 | MakeBazelTarget("aidl_library", "foo_aidl_library", AttrNameToString{ | 
|  | 3750 | "srcs": `["Foo.aidl"]`, | 
|  | 3751 | }), | 
|  | 3752 | MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{ | 
| Vinh Tran | e684294 | 2023-04-28 11:21:25 -0400 | [diff] [blame] | 3753 | "local_includes": `["."]`, | 
|  | 3754 | "deps":           `[":foo_aidl_library"]`, | 
| Sam Delmerico | 512437b | 2023-03-17 11:34:15 -0400 | [diff] [blame] | 3755 | "implementation_deps": `[ | 
|  | 3756 | ":baz-static", | 
|  | 3757 | ":bar-static", | 
|  | 3758 | ]`, | 
| Vinh Tran | 395a1e9 | 2022-09-16 18:27:29 -0400 | [diff] [blame] | 3759 | "implementation_dynamic_deps": `[ | 
| Sam Delmerico | 512437b | 2023-03-17 11:34:15 -0400 | [diff] [blame] | 3760 | ":baz-shared", | 
|  | 3761 | ":bar-shared", | 
| Vinh Tran | 395a1e9 | 2022-09-16 18:27:29 -0400 | [diff] [blame] | 3762 | ]`, | 
|  | 3763 | }), | 
|  | 3764 | MakeBazelTarget("cc_library_static", "foo", AttrNameToString{ | 
|  | 3765 | "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`, | 
| Sam Delmerico | 512437b | 2023-03-17 11:34:15 -0400 | [diff] [blame] | 3766 | "deps":                              `[":baz-static"]`, | 
|  | 3767 | "implementation_deps":               `[":bar-static"]`, | 
|  | 3768 | "dynamic_deps":                      `[":baz-shared"]`, | 
|  | 3769 | "implementation_dynamic_deps":       `[":bar-shared"]`, | 
| Vinh Tran | 395a1e9 | 2022-09-16 18:27:29 -0400 | [diff] [blame] | 3770 | "local_includes":                    `["."]`, | 
|  | 3771 | }), | 
|  | 3772 | }, | 
|  | 3773 | }) | 
|  | 3774 | } | 
| Sam Delmerico | c9b8fbd | 2022-10-25 15:47:17 -0400 | [diff] [blame] | 3775 |  | 
|  | 3776 | func TestCcLibraryWithTidy(t *testing.T) { | 
|  | 3777 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3778 | Description:                "cc_library uses tidy properties", | 
|  | 3779 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3780 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3781 | Blueprint: ` | 
|  | 3782 | cc_library_static { | 
| Sam Delmerico | 63f0c93 | 2023-03-14 14:05:28 -0400 | [diff] [blame] | 3783 | name: "foo", | 
|  | 3784 | srcs: ["foo.cpp"], | 
|  | 3785 | } | 
|  | 3786 | cc_library_static { | 
|  | 3787 | name: "foo-no-tidy", | 
|  | 3788 | srcs: ["foo.cpp"], | 
|  | 3789 | tidy: false, | 
|  | 3790 | } | 
|  | 3791 | cc_library_static { | 
|  | 3792 | name: "foo-tidy", | 
|  | 3793 | srcs: ["foo.cpp"], | 
| Sam Delmerico | c9b8fbd | 2022-10-25 15:47:17 -0400 | [diff] [blame] | 3794 | tidy: true, | 
|  | 3795 | tidy_checks: ["check1", "check2"], | 
|  | 3796 | tidy_checks_as_errors: ["check1error", "check2error"], | 
|  | 3797 | tidy_disabled_srcs: ["bar.cpp"], | 
| Sam Delmerico | 4c902d6 | 2022-11-02 14:17:15 -0400 | [diff] [blame] | 3798 | tidy_timeout_srcs: ["baz.cpp"], | 
| Sam Delmerico | c9b8fbd | 2022-10-25 15:47:17 -0400 | [diff] [blame] | 3799 | }`, | 
|  | 3800 | ExpectedBazelTargets: []string{ | 
|  | 3801 | MakeBazelTarget("cc_library_static", "foo", AttrNameToString{ | 
|  | 3802 | "local_includes": `["."]`, | 
|  | 3803 | "srcs":           `["foo.cpp"]`, | 
| Sam Delmerico | 63f0c93 | 2023-03-14 14:05:28 -0400 | [diff] [blame] | 3804 | }), | 
|  | 3805 | MakeBazelTarget("cc_library_static", "foo-no-tidy", AttrNameToString{ | 
|  | 3806 | "local_includes": `["."]`, | 
|  | 3807 | "srcs":           `["foo.cpp"]`, | 
|  | 3808 | "tidy":           `"never"`, | 
|  | 3809 | }), | 
|  | 3810 | MakeBazelTarget("cc_library_static", "foo-tidy", AttrNameToString{ | 
|  | 3811 | "local_includes": `["."]`, | 
|  | 3812 | "srcs":           `["foo.cpp"]`, | 
|  | 3813 | "tidy":           `"local"`, | 
| Sam Delmerico | c9b8fbd | 2022-10-25 15:47:17 -0400 | [diff] [blame] | 3814 | "tidy_checks": `[ | 
|  | 3815 | "check1", | 
|  | 3816 | "check2", | 
|  | 3817 | ]`, | 
|  | 3818 | "tidy_checks_as_errors": `[ | 
|  | 3819 | "check1error", | 
|  | 3820 | "check2error", | 
|  | 3821 | ]`, | 
|  | 3822 | "tidy_disabled_srcs": `["bar.cpp"]`, | 
| Sam Delmerico | 4c902d6 | 2022-11-02 14:17:15 -0400 | [diff] [blame] | 3823 | "tidy_timeout_srcs":  `["baz.cpp"]`, | 
| Sam Delmerico | c9b8fbd | 2022-10-25 15:47:17 -0400 | [diff] [blame] | 3824 | }), | 
|  | 3825 | }, | 
|  | 3826 | }) | 
|  | 3827 | } | 
| Yu Liu | 56ccb1a | 2022-11-12 10:47:07 -0800 | [diff] [blame] | 3828 |  | 
| Vinh Tran | 99270ea | 2022-11-28 11:15:23 -0500 | [diff] [blame] | 3829 | func TestCcLibraryWithAfdoEnabled(t *testing.T) { | 
|  | 3830 | bp := ` | 
|  | 3831 | cc_library { | 
|  | 3832 | name: "foo", | 
|  | 3833 | afdo: true, | 
|  | 3834 | include_build_directory: false, | 
|  | 3835 | }` | 
|  | 3836 |  | 
|  | 3837 | // TODO(b/260714900): Add test case for arch-specific afdo profile | 
|  | 3838 | testCases := []struct { | 
|  | 3839 | description          string | 
|  | 3840 | filesystem           map[string]string | 
|  | 3841 | expectedBazelTargets []string | 
|  | 3842 | }{ | 
|  | 3843 | { | 
|  | 3844 | description: "cc_library with afdo enabled and existing profile", | 
| Vinh Tran | bc9c8b4 | 2022-12-09 12:03:52 -0500 | [diff] [blame] | 3845 | filesystem: map[string]string{ | 
|  | 3846 | "vendor/google_data/pgo_profile/sampling/BUILD":    "", | 
|  | 3847 | "vendor/google_data/pgo_profile/sampling/foo.afdo": "", | 
|  | 3848 | }, | 
| Vinh Tran | 99270ea | 2022-11-28 11:15:23 -0500 | [diff] [blame] | 3849 | expectedBazelTargets: []string{ | 
|  | 3850 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}), | 
|  | 3851 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 3852 | "fdo_profile": `"//vendor/google_data/pgo_profile/sampling:foo"`, | 
|  | 3853 | }), | 
|  | 3854 | }, | 
|  | 3855 | }, | 
|  | 3856 | { | 
|  | 3857 | description: "cc_library with afdo enabled and existing profile in AOSP", | 
| Vinh Tran | bc9c8b4 | 2022-12-09 12:03:52 -0500 | [diff] [blame] | 3858 | filesystem: map[string]string{ | 
|  | 3859 | "toolchain/pgo-profiles/sampling/BUILD":    "", | 
|  | 3860 | "toolchain/pgo-profiles/sampling/foo.afdo": "", | 
|  | 3861 | }, | 
| Vinh Tran | 99270ea | 2022-11-28 11:15:23 -0500 | [diff] [blame] | 3862 | expectedBazelTargets: []string{ | 
|  | 3863 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}), | 
|  | 3864 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 3865 | "fdo_profile": `"//toolchain/pgo-profiles/sampling:foo"`, | 
|  | 3866 | }), | 
|  | 3867 | }, | 
|  | 3868 | }, | 
|  | 3869 | { | 
|  | 3870 | description: "cc_library with afdo enabled but profile filename doesn't match with module name", | 
| Vinh Tran | bc9c8b4 | 2022-12-09 12:03:52 -0500 | [diff] [blame] | 3871 | filesystem: map[string]string{ | 
|  | 3872 | "toolchain/pgo-profiles/sampling/BUILD":    "", | 
|  | 3873 | "toolchain/pgo-profiles/sampling/bar.afdo": "", | 
|  | 3874 | }, | 
| Vinh Tran | 99270ea | 2022-11-28 11:15:23 -0500 | [diff] [blame] | 3875 | expectedBazelTargets: []string{ | 
|  | 3876 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}), | 
|  | 3877 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{}), | 
|  | 3878 | }, | 
|  | 3879 | }, | 
|  | 3880 | { | 
|  | 3881 | description: "cc_library with afdo enabled but profile doesn't exist", | 
|  | 3882 | expectedBazelTargets: []string{ | 
|  | 3883 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}), | 
|  | 3884 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{}), | 
|  | 3885 | }, | 
|  | 3886 | }, | 
| Vinh Tran | bc9c8b4 | 2022-12-09 12:03:52 -0500 | [diff] [blame] | 3887 | { | 
|  | 3888 | description: "cc_library with afdo enabled and existing profile but BUILD file doesn't exist", | 
|  | 3889 | filesystem: map[string]string{ | 
|  | 3890 | "vendor/google_data/pgo_profile/sampling/foo.afdo": "", | 
|  | 3891 | }, | 
|  | 3892 | expectedBazelTargets: []string{ | 
|  | 3893 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}), | 
|  | 3894 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{}), | 
|  | 3895 | }, | 
|  | 3896 | }, | 
| Vinh Tran | 99270ea | 2022-11-28 11:15:23 -0500 | [diff] [blame] | 3897 | } | 
|  | 3898 | for _, testCase := range testCases { | 
|  | 3899 | t.Run(testCase.description, func(t *testing.T) { | 
|  | 3900 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3901 | ExpectedBazelTargets:       testCase.expectedBazelTargets, | 
|  | 3902 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3903 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3904 | Description:                testCase.description, | 
|  | 3905 | Blueprint:                  binaryReplacer.Replace(bp), | 
|  | 3906 | Filesystem:                 testCase.filesystem, | 
|  | 3907 | }) | 
|  | 3908 | }) | 
|  | 3909 | } | 
|  | 3910 | } | 
|  | 3911 |  | 
| Yu Liu | 56ccb1a | 2022-11-12 10:47:07 -0800 | [diff] [blame] | 3912 | func TestCcLibraryHeaderAbiChecker(t *testing.T) { | 
|  | 3913 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3914 | Description:                "cc_library with header abi checker", | 
|  | 3915 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3916 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3917 | Blueprint: `cc_library { | 
|  | 3918 | name: "foo", | 
|  | 3919 | header_abi_checker: { | 
|  | 3920 | enabled: true, | 
|  | 3921 | symbol_file: "a.map.txt", | 
|  | 3922 | exclude_symbol_versions: [ | 
|  | 3923 | "29", | 
|  | 3924 | "30", | 
|  | 3925 | ], | 
|  | 3926 | exclude_symbol_tags: [ | 
|  | 3927 | "tag1", | 
|  | 3928 | "tag2", | 
|  | 3929 | ], | 
|  | 3930 | check_all_apis: true, | 
|  | 3931 | diff_flags: ["-allow-adding-removing-weak-symbols"], | 
|  | 3932 | }, | 
|  | 3933 | include_build_directory: false, | 
|  | 3934 | }`, | 
|  | 3935 | ExpectedBazelTargets: []string{ | 
|  | 3936 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}), | 
|  | 3937 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 3938 | "abi_checker_enabled":     `True`, | 
|  | 3939 | "abi_checker_symbol_file": `"a.map.txt"`, | 
|  | 3940 | "abi_checker_exclude_symbol_versions": `[ | 
|  | 3941 | "29", | 
|  | 3942 | "30", | 
|  | 3943 | ]`, | 
|  | 3944 | "abi_checker_exclude_symbol_tags": `[ | 
|  | 3945 | "tag1", | 
|  | 3946 | "tag2", | 
|  | 3947 | ]`, | 
|  | 3948 | "abi_checker_check_all_apis": `True`, | 
|  | 3949 | "abi_checker_diff_flags":     `["-allow-adding-removing-weak-symbols"]`, | 
|  | 3950 | }), | 
|  | 3951 | }, | 
|  | 3952 | }) | 
|  | 3953 | } | 
| Jingwen Chen | c4c34e1 | 2022-11-29 12:07:45 +0000 | [diff] [blame] | 3954 |  | 
|  | 3955 | func TestCcLibraryApexAvailable(t *testing.T) { | 
|  | 3956 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3957 | Description:                "cc_library apex_available converted to tags", | 
|  | 3958 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3959 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3960 | Blueprint: soongCcLibraryPreamble + ` | 
|  | 3961 | cc_library { | 
|  | 3962 | name: "a", | 
|  | 3963 | srcs: ["a.cpp"], | 
|  | 3964 | apex_available: ["com.android.foo"], | 
|  | 3965 | } | 
|  | 3966 | `, | 
|  | 3967 | ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{ | 
|  | 3968 | "tags":           `["apex_available=com.android.foo"]`, | 
|  | 3969 | "srcs":           `["a.cpp"]`, | 
|  | 3970 | "local_includes": `["."]`, | 
|  | 3971 | }), | 
|  | 3972 | }, | 
|  | 3973 | ) | 
|  | 3974 | } | 
|  | 3975 |  | 
|  | 3976 | func TestCcLibraryApexAvailableMultiple(t *testing.T) { | 
|  | 3977 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 3978 | Description:                "cc_library apex_available converted to multiple tags", | 
|  | 3979 | ModuleTypeUnderTest:        "cc_library", | 
|  | 3980 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 3981 | Blueprint: soongCcLibraryPreamble + ` | 
|  | 3982 | cc_library { | 
|  | 3983 | name: "a", | 
|  | 3984 | srcs: ["a.cpp"], | 
|  | 3985 | apex_available: ["com.android.foo", "//apex_available:platform", "com.android.bar"], | 
|  | 3986 | } | 
|  | 3987 | `, | 
|  | 3988 | ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{ | 
|  | 3989 | "tags": `[ | 
|  | 3990 | "apex_available=com.android.foo", | 
|  | 3991 | "apex_available=//apex_available:platform", | 
|  | 3992 | "apex_available=com.android.bar", | 
|  | 3993 | ]`, | 
|  | 3994 | "srcs":           `["a.cpp"]`, | 
|  | 3995 | "local_includes": `["."]`, | 
|  | 3996 | }), | 
|  | 3997 | }, | 
|  | 3998 | ) | 
|  | 3999 | } | 
| Zi Wang | 0f82844 | 2022-12-28 11:18:11 -0800 | [diff] [blame] | 4000 |  | 
|  | 4001 | // Export_include_dirs and Export_system_include_dirs have "variant_prepend" tag. | 
|  | 4002 | // In bp2build output, variant info(select) should go before general info. | 
|  | 4003 | // Internal order of the property should be unchanged. (e.g. ["eid1", "eid2"]) | 
|  | 4004 | func TestCcLibraryVariantPrependPropOrder(t *testing.T) { | 
|  | 4005 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4006 | Description:                "cc_library variant prepend properties order", | 
|  | 4007 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4008 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4009 | Blueprint: soongCcLibraryPreamble + ` | 
|  | 4010 | cc_library { | 
|  | 4011 | name: "a", | 
|  | 4012 | srcs: ["a.cpp"], | 
|  | 4013 | export_include_dirs: ["eid1", "eid2"], | 
|  | 4014 | export_system_include_dirs: ["esid1", "esid2"], | 
|  | 4015 | target: { | 
|  | 4016 | android: { | 
|  | 4017 | export_include_dirs: ["android_eid1", "android_eid2"], | 
|  | 4018 | export_system_include_dirs: ["android_esid1", "android_esid2"], | 
|  | 4019 | }, | 
|  | 4020 | android_arm: { | 
|  | 4021 | export_include_dirs: ["android_arm_eid1", "android_arm_eid2"], | 
|  | 4022 | export_system_include_dirs: ["android_arm_esid1", "android_arm_esid2"], | 
|  | 4023 | }, | 
|  | 4024 | linux: { | 
|  | 4025 | export_include_dirs: ["linux_eid1", "linux_eid2"], | 
|  | 4026 | export_system_include_dirs: ["linux_esid1", "linux_esid2"], | 
|  | 4027 | }, | 
|  | 4028 | }, | 
|  | 4029 | multilib: { | 
|  | 4030 | lib32: { | 
|  | 4031 | export_include_dirs: ["lib32_eid1", "lib32_eid2"], | 
|  | 4032 | export_system_include_dirs: ["lib32_esid1", "lib32_esid2"], | 
|  | 4033 | }, | 
|  | 4034 | }, | 
|  | 4035 | arch: { | 
|  | 4036 | arm: { | 
|  | 4037 | export_include_dirs: ["arm_eid1", "arm_eid2"], | 
|  | 4038 | export_system_include_dirs: ["arm_esid1", "arm_esid2"], | 
|  | 4039 | }, | 
|  | 4040 | } | 
|  | 4041 | } | 
|  | 4042 | `, | 
|  | 4043 | ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{ | 
|  | 4044 | "export_includes": `select({ | 
|  | 4045 | "//build/bazel/platforms/os_arch:android_arm": [ | 
|  | 4046 | "android_arm_eid1", | 
|  | 4047 | "android_arm_eid2", | 
|  | 4048 | ], | 
|  | 4049 | "//conditions:default": [], | 
|  | 4050 | }) + select({ | 
|  | 4051 | "//build/bazel/platforms/os:android": [ | 
|  | 4052 | "android_eid1", | 
|  | 4053 | "android_eid2", | 
|  | 4054 | "linux_eid1", | 
|  | 4055 | "linux_eid2", | 
|  | 4056 | ], | 
|  | 4057 | "//build/bazel/platforms/os:linux_bionic": [ | 
|  | 4058 | "linux_eid1", | 
|  | 4059 | "linux_eid2", | 
|  | 4060 | ], | 
|  | 4061 | "//build/bazel/platforms/os:linux_glibc": [ | 
|  | 4062 | "linux_eid1", | 
|  | 4063 | "linux_eid2", | 
|  | 4064 | ], | 
|  | 4065 | "//build/bazel/platforms/os:linux_musl": [ | 
|  | 4066 | "linux_eid1", | 
|  | 4067 | "linux_eid2", | 
|  | 4068 | ], | 
|  | 4069 | "//conditions:default": [], | 
|  | 4070 | }) + select({ | 
|  | 4071 | "//build/bazel/platforms/arch:arm": [ | 
|  | 4072 | "lib32_eid1", | 
|  | 4073 | "lib32_eid2", | 
|  | 4074 | "arm_eid1", | 
|  | 4075 | "arm_eid2", | 
|  | 4076 | ], | 
|  | 4077 | "//build/bazel/platforms/arch:x86": [ | 
|  | 4078 | "lib32_eid1", | 
|  | 4079 | "lib32_eid2", | 
|  | 4080 | ], | 
|  | 4081 | "//conditions:default": [], | 
|  | 4082 | }) + [ | 
|  | 4083 | "eid1", | 
|  | 4084 | "eid2", | 
|  | 4085 | ]`, | 
|  | 4086 | "export_system_includes": `select({ | 
|  | 4087 | "//build/bazel/platforms/os_arch:android_arm": [ | 
|  | 4088 | "android_arm_esid1", | 
|  | 4089 | "android_arm_esid2", | 
|  | 4090 | ], | 
|  | 4091 | "//conditions:default": [], | 
|  | 4092 | }) + select({ | 
|  | 4093 | "//build/bazel/platforms/os:android": [ | 
|  | 4094 | "android_esid1", | 
|  | 4095 | "android_esid2", | 
|  | 4096 | "linux_esid1", | 
|  | 4097 | "linux_esid2", | 
|  | 4098 | ], | 
|  | 4099 | "//build/bazel/platforms/os:linux_bionic": [ | 
|  | 4100 | "linux_esid1", | 
|  | 4101 | "linux_esid2", | 
|  | 4102 | ], | 
|  | 4103 | "//build/bazel/platforms/os:linux_glibc": [ | 
|  | 4104 | "linux_esid1", | 
|  | 4105 | "linux_esid2", | 
|  | 4106 | ], | 
|  | 4107 | "//build/bazel/platforms/os:linux_musl": [ | 
|  | 4108 | "linux_esid1", | 
|  | 4109 | "linux_esid2", | 
|  | 4110 | ], | 
|  | 4111 | "//conditions:default": [], | 
|  | 4112 | }) + select({ | 
|  | 4113 | "//build/bazel/platforms/arch:arm": [ | 
|  | 4114 | "lib32_esid1", | 
|  | 4115 | "lib32_esid2", | 
|  | 4116 | "arm_esid1", | 
|  | 4117 | "arm_esid2", | 
|  | 4118 | ], | 
|  | 4119 | "//build/bazel/platforms/arch:x86": [ | 
|  | 4120 | "lib32_esid1", | 
|  | 4121 | "lib32_esid2", | 
|  | 4122 | ], | 
|  | 4123 | "//conditions:default": [], | 
|  | 4124 | }) + [ | 
|  | 4125 | "esid1", | 
|  | 4126 | "esid2", | 
|  | 4127 | ]`, | 
|  | 4128 | "srcs":                   `["a.cpp"]`, | 
|  | 4129 | "local_includes":         `["."]`, | 
|  | 4130 | "target_compatible_with": `["//build/bazel/platforms/os:android"]`, | 
|  | 4131 | }), | 
|  | 4132 | }, | 
|  | 4133 | ) | 
|  | 4134 | } | 
| Trevor Radcliffe | db7e026 | 2022-10-28 16:48:18 +0000 | [diff] [blame] | 4135 |  | 
|  | 4136 | func TestCcLibraryWithIntegerOverflowProperty(t *testing.T) { | 
|  | 4137 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4138 | Description:                "cc_library has correct features when integer_overflow property is provided", | 
|  | 4139 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4140 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4141 | Blueprint: ` | 
|  | 4142 | cc_library { | 
|  | 4143 | name: "foo", | 
|  | 4144 | sanitize: { | 
|  | 4145 | integer_overflow: true, | 
|  | 4146 | }, | 
|  | 4147 | } | 
|  | 4148 | `, | 
|  | 4149 | ExpectedBazelTargets: []string{ | 
|  | 4150 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 4151 | "features":       `["ubsan_integer_overflow"]`, | 
|  | 4152 | "local_includes": `["."]`, | 
|  | 4153 | }), | 
|  | 4154 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 4155 | "features":       `["ubsan_integer_overflow"]`, | 
|  | 4156 | "local_includes": `["."]`, | 
|  | 4157 | }), | 
|  | 4158 | }, | 
|  | 4159 | }) | 
|  | 4160 | } | 
|  | 4161 |  | 
|  | 4162 | func TestCcLibraryWithMiscUndefinedProperty(t *testing.T) { | 
|  | 4163 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4164 | Description:                "cc_library has correct features when misc_undefined property is provided", | 
|  | 4165 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4166 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4167 | Blueprint: ` | 
|  | 4168 | cc_library { | 
|  | 4169 | name: "foo", | 
|  | 4170 | sanitize: { | 
|  | 4171 | misc_undefined: ["undefined", "nullability"], | 
|  | 4172 | }, | 
|  | 4173 | } | 
|  | 4174 | `, | 
|  | 4175 | ExpectedBazelTargets: []string{ | 
|  | 4176 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 4177 | "features": `[ | 
|  | 4178 | "ubsan_undefined", | 
|  | 4179 | "ubsan_nullability", | 
|  | 4180 | ]`, | 
|  | 4181 | "local_includes": `["."]`, | 
|  | 4182 | }), | 
|  | 4183 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 4184 | "features": `[ | 
|  | 4185 | "ubsan_undefined", | 
|  | 4186 | "ubsan_nullability", | 
|  | 4187 | ]`, | 
|  | 4188 | "local_includes": `["."]`, | 
|  | 4189 | }), | 
|  | 4190 | }, | 
|  | 4191 | }) | 
|  | 4192 | } | 
|  | 4193 |  | 
| Trevor Radcliffe | ded095c | 2023-06-12 19:18:28 +0000 | [diff] [blame] | 4194 | func TestCcLibraryWithSanitizerBlocklist(t *testing.T) { | 
|  | 4195 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4196 | Description:                "cc_library has correct feature when sanitize.blocklist is provided", | 
|  | 4197 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4198 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4199 | Blueprint: ` | 
|  | 4200 | cc_library { | 
|  | 4201 | name: "foo", | 
|  | 4202 | sanitize: { | 
|  | 4203 | blocklist: "foo_blocklist.txt", | 
|  | 4204 | }, | 
|  | 4205 | } | 
|  | 4206 | `, | 
|  | 4207 | ExpectedBazelTargets: []string{ | 
|  | 4208 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
| Trevor Radcliffe | d9b7f17 | 2023-08-09 22:21:38 +0000 | [diff] [blame] | 4209 | "copts": `select({ | 
|  | 4210 | "//build/bazel/rules/cc:sanitizers_enabled": ["-fsanitize-ignorelist=$(location foo_blocklist.txt)"], | 
|  | 4211 | "//conditions:default": [], | 
|  | 4212 | })`, | 
|  | 4213 | "additional_compiler_inputs": `select({ | 
|  | 4214 | "//build/bazel/rules/cc:sanitizers_enabled": [":foo_blocklist.txt"], | 
|  | 4215 | "//conditions:default": [], | 
|  | 4216 | })`, | 
| Trevor Radcliffe | ded095c | 2023-06-12 19:18:28 +0000 | [diff] [blame] | 4217 | "local_includes": `["."]`, | 
|  | 4218 | }), | 
|  | 4219 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
| Trevor Radcliffe | d9b7f17 | 2023-08-09 22:21:38 +0000 | [diff] [blame] | 4220 | "copts": `select({ | 
|  | 4221 | "//build/bazel/rules/cc:sanitizers_enabled": ["-fsanitize-ignorelist=$(location foo_blocklist.txt)"], | 
|  | 4222 | "//conditions:default": [], | 
|  | 4223 | })`, | 
|  | 4224 | "additional_compiler_inputs": `select({ | 
|  | 4225 | "//build/bazel/rules/cc:sanitizers_enabled": [":foo_blocklist.txt"], | 
|  | 4226 | "//conditions:default": [], | 
|  | 4227 | })`, | 
| Trevor Radcliffe | ded095c | 2023-06-12 19:18:28 +0000 | [diff] [blame] | 4228 | "local_includes": `["."]`, | 
|  | 4229 | }), | 
|  | 4230 | }, | 
|  | 4231 | }) | 
|  | 4232 | } | 
|  | 4233 |  | 
| Trevor Radcliffe | db7e026 | 2022-10-28 16:48:18 +0000 | [diff] [blame] | 4234 | func TestCcLibraryWithUBSanPropertiesArchSpecific(t *testing.T) { | 
|  | 4235 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4236 | Description:                "cc_library has correct feature select when UBSan props are specified in arch specific blocks", | 
|  | 4237 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4238 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4239 | Blueprint: ` | 
|  | 4240 | cc_library { | 
|  | 4241 | name: "foo", | 
|  | 4242 | sanitize: { | 
|  | 4243 | misc_undefined: ["undefined", "nullability"], | 
|  | 4244 | }, | 
|  | 4245 | target: { | 
|  | 4246 | android: { | 
|  | 4247 | sanitize: { | 
|  | 4248 | misc_undefined: ["alignment"], | 
|  | 4249 | }, | 
|  | 4250 | }, | 
|  | 4251 | linux_glibc: { | 
|  | 4252 | sanitize: { | 
|  | 4253 | integer_overflow: true, | 
|  | 4254 | }, | 
|  | 4255 | }, | 
|  | 4256 | }, | 
|  | 4257 | } | 
|  | 4258 | `, | 
|  | 4259 | ExpectedBazelTargets: []string{ | 
|  | 4260 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 4261 | "features": `[ | 
|  | 4262 | "ubsan_undefined", | 
|  | 4263 | "ubsan_nullability", | 
|  | 4264 | ] + select({ | 
|  | 4265 | "//build/bazel/platforms/os:android": ["ubsan_alignment"], | 
|  | 4266 | "//build/bazel/platforms/os:linux_glibc": ["ubsan_integer_overflow"], | 
|  | 4267 | "//conditions:default": [], | 
|  | 4268 | })`, | 
|  | 4269 | "local_includes": `["."]`, | 
|  | 4270 | }), | 
|  | 4271 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 4272 | "features": `[ | 
|  | 4273 | "ubsan_undefined", | 
|  | 4274 | "ubsan_nullability", | 
|  | 4275 | ] + select({ | 
|  | 4276 | "//build/bazel/platforms/os:android": ["ubsan_alignment"], | 
|  | 4277 | "//build/bazel/platforms/os:linux_glibc": ["ubsan_integer_overflow"], | 
|  | 4278 | "//conditions:default": [], | 
|  | 4279 | })`, | 
|  | 4280 | "local_includes": `["."]`, | 
|  | 4281 | }), | 
|  | 4282 | }, | 
|  | 4283 | }) | 
|  | 4284 | } | 
| Yu Liu | 10174ff | 2023-02-21 12:05:26 -0800 | [diff] [blame] | 4285 |  | 
|  | 4286 | func TestCcLibraryInApexWithStubSharedLibs(t *testing.T) { | 
|  | 4287 | runCcLibrarySharedTestCase(t, Bp2buildTestCase{ | 
|  | 4288 | Description:                "cc_library with in apex with stub shared_libs and export_shared_lib_headers", | 
|  | 4289 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4290 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4291 | Blueprint: ` | 
|  | 4292 | cc_library { | 
|  | 4293 | name: "barlib", | 
|  | 4294 | stubs: { symbol_file: "bar.map.txt", versions: ["28", "29", "current"] }, | 
|  | 4295 | bazel_module: { bp2build_available: false }, | 
| Spandan Das | 6d4d9da | 2023-04-18 06:20:40 +0000 | [diff] [blame] | 4296 | apex_available: ["//apex_available:platform",], | 
| Yu Liu | 10174ff | 2023-02-21 12:05:26 -0800 | [diff] [blame] | 4297 | } | 
|  | 4298 | cc_library { | 
|  | 4299 | name: "bazlib", | 
|  | 4300 | stubs: { symbol_file: "bar.map.txt", versions: ["28", "29", "current"] }, | 
|  | 4301 | bazel_module: { bp2build_available: false }, | 
| Spandan Das | 6d4d9da | 2023-04-18 06:20:40 +0000 | [diff] [blame] | 4302 | apex_available: ["//apex_available:platform",], | 
| Yu Liu | 10174ff | 2023-02-21 12:05:26 -0800 | [diff] [blame] | 4303 | } | 
|  | 4304 | cc_library { | 
|  | 4305 | name: "foo", | 
|  | 4306 | shared_libs: ["barlib", "bazlib"], | 
|  | 4307 | export_shared_lib_headers: ["bazlib"], | 
|  | 4308 | apex_available: [ | 
| Spandan Das | 6d4d9da | 2023-04-18 06:20:40 +0000 | [diff] [blame] | 4309 | "//apex_available:platform", | 
| Yu Liu | 10174ff | 2023-02-21 12:05:26 -0800 | [diff] [blame] | 4310 | ], | 
|  | 4311 | }`, | 
|  | 4312 | ExpectedBazelTargets: []string{ | 
|  | 4313 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
| Spandan Das | 6d4d9da | 2023-04-18 06:20:40 +0000 | [diff] [blame] | 4314 | "implementation_dynamic_deps": `[":barlib"]`, | 
|  | 4315 | "dynamic_deps":                `[":bazlib"]`, | 
|  | 4316 | "local_includes":              `["."]`, | 
|  | 4317 | "tags":                        `["apex_available=//apex_available:platform"]`, | 
| Yu Liu | 10174ff | 2023-02-21 12:05:26 -0800 | [diff] [blame] | 4318 | }), | 
|  | 4319 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
| Spandan Das | 6d4d9da | 2023-04-18 06:20:40 +0000 | [diff] [blame] | 4320 | "implementation_dynamic_deps": `[":barlib"]`, | 
|  | 4321 | "dynamic_deps":                `[":bazlib"]`, | 
|  | 4322 | "local_includes":              `["."]`, | 
|  | 4323 | "tags":                        `["apex_available=//apex_available:platform"]`, | 
| Yu Liu | 10174ff | 2023-02-21 12:05:26 -0800 | [diff] [blame] | 4324 | }), | 
|  | 4325 | }, | 
|  | 4326 | }) | 
|  | 4327 | } | 
| Trevor Radcliffe | 56b1a2b | 2023-02-06 21:58:30 +0000 | [diff] [blame] | 4328 |  | 
|  | 4329 | func TestCcLibraryWithThinLto(t *testing.T) { | 
|  | 4330 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4331 | Description:                "cc_library has correct features when thin LTO is enabled", | 
|  | 4332 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4333 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4334 | Blueprint: ` | 
|  | 4335 | cc_library { | 
|  | 4336 | name: "foo", | 
|  | 4337 | lto: { | 
|  | 4338 | thin: true, | 
|  | 4339 | }, | 
|  | 4340 | }`, | 
|  | 4341 | ExpectedBazelTargets: []string{ | 
|  | 4342 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 4343 | "features":       `["android_thin_lto"]`, | 
|  | 4344 | "local_includes": `["."]`, | 
|  | 4345 | }), | 
|  | 4346 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 4347 | "features":       `["android_thin_lto"]`, | 
|  | 4348 | "local_includes": `["."]`, | 
|  | 4349 | }), | 
|  | 4350 | }, | 
|  | 4351 | }) | 
|  | 4352 | } | 
|  | 4353 |  | 
|  | 4354 | func TestCcLibraryWithLtoNever(t *testing.T) { | 
|  | 4355 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4356 | Description:                "cc_library has correct features when LTO is explicitly disabled", | 
|  | 4357 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4358 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4359 | Blueprint: ` | 
|  | 4360 | cc_library { | 
|  | 4361 | name: "foo", | 
|  | 4362 | lto: { | 
|  | 4363 | never: true, | 
|  | 4364 | }, | 
|  | 4365 | }`, | 
|  | 4366 | ExpectedBazelTargets: []string{ | 
|  | 4367 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 4368 | "features":       `["-android_thin_lto"]`, | 
|  | 4369 | "local_includes": `["."]`, | 
|  | 4370 | }), | 
|  | 4371 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 4372 | "features":       `["-android_thin_lto"]`, | 
|  | 4373 | "local_includes": `["."]`, | 
|  | 4374 | }), | 
|  | 4375 | }, | 
|  | 4376 | }) | 
|  | 4377 | } | 
|  | 4378 |  | 
|  | 4379 | func TestCcLibraryWithThinLtoArchSpecific(t *testing.T) { | 
|  | 4380 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4381 | Description:                "cc_library has correct features when LTO differs across arch and os variants", | 
|  | 4382 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4383 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4384 | Blueprint: ` | 
|  | 4385 | cc_library { | 
|  | 4386 | name: "foo", | 
|  | 4387 | target: { | 
|  | 4388 | android: { | 
|  | 4389 | lto: { | 
|  | 4390 | thin: true, | 
|  | 4391 | }, | 
|  | 4392 | }, | 
|  | 4393 | }, | 
|  | 4394 | arch: { | 
|  | 4395 | riscv64: { | 
|  | 4396 | lto: { | 
|  | 4397 | thin: false, | 
|  | 4398 | }, | 
|  | 4399 | }, | 
|  | 4400 | }, | 
|  | 4401 | }`, | 
|  | 4402 | ExpectedBazelTargets: []string{ | 
|  | 4403 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 4404 | "local_includes": `["."]`, | 
|  | 4405 | "features": `select({ | 
|  | 4406 | "//build/bazel/platforms/os_arch:android_arm": ["android_thin_lto"], | 
|  | 4407 | "//build/bazel/platforms/os_arch:android_arm64": ["android_thin_lto"], | 
|  | 4408 | "//build/bazel/platforms/os_arch:android_riscv64": ["-android_thin_lto"], | 
|  | 4409 | "//build/bazel/platforms/os_arch:android_x86": ["android_thin_lto"], | 
|  | 4410 | "//build/bazel/platforms/os_arch:android_x86_64": ["android_thin_lto"], | 
|  | 4411 | "//conditions:default": [], | 
|  | 4412 | })`}), | 
|  | 4413 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 4414 | "local_includes": `["."]`, | 
|  | 4415 | "features": `select({ | 
|  | 4416 | "//build/bazel/platforms/os_arch:android_arm": ["android_thin_lto"], | 
|  | 4417 | "//build/bazel/platforms/os_arch:android_arm64": ["android_thin_lto"], | 
|  | 4418 | "//build/bazel/platforms/os_arch:android_riscv64": ["-android_thin_lto"], | 
|  | 4419 | "//build/bazel/platforms/os_arch:android_x86": ["android_thin_lto"], | 
|  | 4420 | "//build/bazel/platforms/os_arch:android_x86_64": ["android_thin_lto"], | 
|  | 4421 | "//conditions:default": [], | 
|  | 4422 | })`}), | 
|  | 4423 | }, | 
|  | 4424 | }) | 
|  | 4425 | } | 
|  | 4426 |  | 
|  | 4427 | func TestCcLibraryWithThinLtoDisabledDefaultEnabledVariant(t *testing.T) { | 
|  | 4428 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4429 | Description:                "cc_library has correct features when LTO disabled by default but enabled on a particular variant", | 
|  | 4430 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4431 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4432 | Blueprint: ` | 
|  | 4433 | cc_library { | 
|  | 4434 | name: "foo", | 
|  | 4435 | lto: { | 
|  | 4436 | never: true, | 
|  | 4437 | }, | 
|  | 4438 | target: { | 
|  | 4439 | android: { | 
|  | 4440 | lto: { | 
|  | 4441 | thin: true, | 
|  | 4442 | never: false, | 
|  | 4443 | }, | 
|  | 4444 | }, | 
|  | 4445 | }, | 
|  | 4446 | }`, | 
|  | 4447 | ExpectedBazelTargets: []string{ | 
|  | 4448 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 4449 | "local_includes": `["."]`, | 
|  | 4450 | "features": `select({ | 
|  | 4451 | "//build/bazel/platforms/os:android": ["android_thin_lto"], | 
|  | 4452 | "//conditions:default": ["-android_thin_lto"], | 
|  | 4453 | })`, | 
|  | 4454 | }), | 
|  | 4455 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 4456 | "local_includes": `["."]`, | 
|  | 4457 | "features": `select({ | 
|  | 4458 | "//build/bazel/platforms/os:android": ["android_thin_lto"], | 
|  | 4459 | "//conditions:default": ["-android_thin_lto"], | 
|  | 4460 | })`, | 
|  | 4461 | }), | 
|  | 4462 | }, | 
|  | 4463 | }) | 
|  | 4464 | } | 
|  | 4465 |  | 
|  | 4466 | func TestCcLibraryWithThinLtoWholeProgramVtables(t *testing.T) { | 
|  | 4467 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4468 | Description:                "cc_library has correct features when thin LTO is enabled with whole_program_vtables", | 
|  | 4469 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4470 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4471 | Blueprint: ` | 
|  | 4472 | cc_library { | 
|  | 4473 | name: "foo", | 
|  | 4474 | lto: { | 
|  | 4475 | thin: true, | 
|  | 4476 | }, | 
|  | 4477 | whole_program_vtables: true, | 
|  | 4478 | }`, | 
|  | 4479 | ExpectedBazelTargets: []string{ | 
|  | 4480 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 4481 | "features": `[ | 
|  | 4482 | "android_thin_lto", | 
|  | 4483 | "android_thin_lto_whole_program_vtables", | 
|  | 4484 | ]`, | 
|  | 4485 | "local_includes": `["."]`, | 
|  | 4486 | }), | 
|  | 4487 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 4488 | "features": `[ | 
|  | 4489 | "android_thin_lto", | 
|  | 4490 | "android_thin_lto_whole_program_vtables", | 
|  | 4491 | ]`, | 
|  | 4492 | "local_includes": `["."]`, | 
|  | 4493 | }), | 
|  | 4494 | }, | 
|  | 4495 | }) | 
|  | 4496 | } | 
| Trevor Radcliffe | a8b4416 | 2023-04-14 18:25:24 +0000 | [diff] [blame] | 4497 |  | 
|  | 4498 | func TestCcLibraryHiddenVisibilityConvertedToFeature(t *testing.T) { | 
|  | 4499 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4500 | Description:                "cc_library changes hidden visibility flag to feature", | 
|  | 4501 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4502 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4503 | Blueprint: ` | 
|  | 4504 | cc_library { | 
|  | 4505 | name: "foo", | 
|  | 4506 | cflags: ["-fvisibility=hidden"], | 
|  | 4507 | }`, | 
|  | 4508 | ExpectedBazelTargets: []string{ | 
|  | 4509 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 4510 | "features":       `["visibility_hidden"]`, | 
|  | 4511 | "local_includes": `["."]`, | 
|  | 4512 | }), | 
|  | 4513 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 4514 | "features":       `["visibility_hidden"]`, | 
|  | 4515 | "local_includes": `["."]`, | 
|  | 4516 | }), | 
|  | 4517 | }, | 
|  | 4518 | }) | 
|  | 4519 | } | 
|  | 4520 |  | 
|  | 4521 | func TestCcLibraryHiddenVisibilityConvertedToFeatureSharedSpecific(t *testing.T) { | 
|  | 4522 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4523 | Description:                "cc_library changes hidden visibility flag to feature when specific to shared variant", | 
|  | 4524 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4525 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4526 | Blueprint: ` | 
|  | 4527 | cc_library { | 
|  | 4528 | name: "foo", | 
|  | 4529 | shared: { | 
|  | 4530 | cflags: ["-fvisibility=hidden"], | 
|  | 4531 | }, | 
|  | 4532 | }`, | 
|  | 4533 | ExpectedBazelTargets: []string{ | 
|  | 4534 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 4535 | "local_includes": `["."]`, | 
|  | 4536 | }), | 
|  | 4537 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 4538 | "features":       `["visibility_hidden"]`, | 
|  | 4539 | "local_includes": `["."]`, | 
|  | 4540 | }), | 
|  | 4541 | }, | 
|  | 4542 | }) | 
|  | 4543 | } | 
|  | 4544 |  | 
|  | 4545 | func TestCcLibraryHiddenVisibilityConvertedToFeatureStaticSpecific(t *testing.T) { | 
|  | 4546 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4547 | Description:                "cc_library changes hidden visibility flag to feature when specific to static variant", | 
|  | 4548 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4549 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4550 | Blueprint: ` | 
|  | 4551 | cc_library { | 
|  | 4552 | name: "foo", | 
|  | 4553 | static: { | 
|  | 4554 | cflags: ["-fvisibility=hidden"], | 
|  | 4555 | }, | 
|  | 4556 | }`, | 
|  | 4557 | ExpectedBazelTargets: []string{ | 
|  | 4558 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 4559 | "features":       `["visibility_hidden"]`, | 
|  | 4560 | "local_includes": `["."]`, | 
|  | 4561 | }), | 
|  | 4562 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 4563 | "local_includes": `["."]`, | 
|  | 4564 | }), | 
|  | 4565 | }, | 
|  | 4566 | }) | 
|  | 4567 | } | 
|  | 4568 |  | 
|  | 4569 | func TestCcLibraryHiddenVisibilityConvertedToFeatureOsSpecific(t *testing.T) { | 
|  | 4570 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4571 | Description:                "cc_library changes hidden visibility flag to feature when specific to an os", | 
|  | 4572 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4573 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4574 | Blueprint: ` | 
|  | 4575 | cc_library { | 
|  | 4576 | name: "foo", | 
|  | 4577 | target: { | 
|  | 4578 | android: { | 
|  | 4579 | cflags: ["-fvisibility=hidden"], | 
|  | 4580 | }, | 
|  | 4581 | }, | 
|  | 4582 | }`, | 
|  | 4583 | ExpectedBazelTargets: []string{ | 
|  | 4584 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 4585 | "features": `select({ | 
|  | 4586 | "//build/bazel/platforms/os:android": ["visibility_hidden"], | 
|  | 4587 | "//conditions:default": [], | 
|  | 4588 | })`, | 
|  | 4589 | "local_includes": `["."]`, | 
|  | 4590 | }), | 
|  | 4591 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 4592 | "features": `select({ | 
|  | 4593 | "//build/bazel/platforms/os:android": ["visibility_hidden"], | 
|  | 4594 | "//conditions:default": [], | 
|  | 4595 | })`, | 
|  | 4596 | "local_includes": `["."]`, | 
|  | 4597 | }), | 
|  | 4598 | }, | 
|  | 4599 | }) | 
|  | 4600 | } | 
| Spandan Das | 4242f10 | 2023-04-19 22:31:54 +0000 | [diff] [blame] | 4601 |  | 
|  | 4602 | // Test that a config_setting specific to an apex is created by cc_library. | 
|  | 4603 | func TestCcLibraryCreatesInApexConfigSetting(t *testing.T) { | 
|  | 4604 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4605 | Description:                "cc_library creates a config_setting for each apex in apex_available", | 
|  | 4606 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4607 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4608 | Dir:                        "build/bazel/rules/apex", | 
|  | 4609 | Blueprint: ` | 
|  | 4610 | cc_library { | 
|  | 4611 | name: "foo", | 
|  | 4612 | apex_available: [ | 
|  | 4613 | "//apex_available:platform", // This will be skipped, since it is equivalent to //build/bazel/rules/apex:android-non_apex | 
|  | 4614 | "myapex" | 
|  | 4615 | ], | 
|  | 4616 | }`, | 
|  | 4617 | ExpectedBazelTargets: []string{ | 
|  | 4618 | MakeBazelTargetNoRestrictions( | 
|  | 4619 | "config_setting", | 
| Spandan Das | 9cad90f | 2023-05-04 17:15:44 +0000 | [diff] [blame] | 4620 | "myapex", | 
| Spandan Das | 4242f10 | 2023-04-19 22:31:54 +0000 | [diff] [blame] | 4621 | AttrNameToString{ | 
|  | 4622 | "flag_values": `{ | 
| Spandan Das | 9cad90f | 2023-05-04 17:15:44 +0000 | [diff] [blame] | 4623 | "//build/bazel/rules/apex:api_domain": "myapex", | 
| Spandan Das | 4242f10 | 2023-04-19 22:31:54 +0000 | [diff] [blame] | 4624 | }`, | 
| Spandan Das | 9cad90f | 2023-05-04 17:15:44 +0000 | [diff] [blame] | 4625 | "constraint_values": `["//build/bazel/platforms/os:android"]`, | 
| Spandan Das | 4242f10 | 2023-04-19 22:31:54 +0000 | [diff] [blame] | 4626 | }, | 
|  | 4627 | ), | 
|  | 4628 | }, | 
|  | 4629 | }) | 
|  | 4630 | } | 
| Yu Liu | 93893ba | 2023-05-01 13:49:52 -0700 | [diff] [blame] | 4631 |  | 
|  | 4632 | func TestCcLibraryCppFlagsInProductVariables(t *testing.T) { | 
|  | 4633 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4634 | Description:                "cc_library cppflags in product variables", | 
|  | 4635 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4636 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4637 | Blueprint: soongCcLibraryPreamble + `cc_library { | 
|  | 4638 | name: "a", | 
|  | 4639 | srcs: ["a.cpp"], | 
|  | 4640 | cppflags: [ | 
|  | 4641 | "-Wextra", | 
|  | 4642 | "-DDEBUG_ONLY_CODE=0", | 
|  | 4643 | ], | 
|  | 4644 | product_variables: { | 
|  | 4645 | eng: { | 
|  | 4646 | cppflags: [ | 
|  | 4647 | "-UDEBUG_ONLY_CODE", | 
|  | 4648 | "-DDEBUG_ONLY_CODE=1", | 
|  | 4649 | ], | 
|  | 4650 | }, | 
|  | 4651 | }, | 
|  | 4652 | include_build_directory: false, | 
|  | 4653 | } | 
|  | 4654 | `, | 
|  | 4655 | ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{ | 
|  | 4656 | "cppflags": `[ | 
|  | 4657 | "-Wextra", | 
|  | 4658 | "-DDEBUG_ONLY_CODE=0", | 
|  | 4659 | ] + select({ | 
| Cole Faust | 87c0c33 | 2023-07-31 12:10:12 -0700 | [diff] [blame] | 4660 | "//build/bazel/product_config/config_settings:eng": [ | 
| Yu Liu | 93893ba | 2023-05-01 13:49:52 -0700 | [diff] [blame] | 4661 | "-UDEBUG_ONLY_CODE", | 
|  | 4662 | "-DDEBUG_ONLY_CODE=1", | 
|  | 4663 | ], | 
|  | 4664 | "//conditions:default": [], | 
|  | 4665 | })`, | 
|  | 4666 | "srcs": `["a.cpp"]`, | 
|  | 4667 | }), | 
|  | 4668 | }, | 
|  | 4669 | ) | 
|  | 4670 | } | 
| Spandan Das | df4c213 | 2023-05-09 23:58:52 +0000 | [diff] [blame] | 4671 |  | 
|  | 4672 | func TestCcLibraryYaccConversion(t *testing.T) { | 
|  | 4673 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4674 | Description:                "cc_library is built from .y/.yy files", | 
|  | 4675 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4676 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4677 | Blueprint: soongCcLibraryPreamble + `cc_library { | 
|  | 4678 | name: "a", | 
|  | 4679 | srcs: [ | 
|  | 4680 | "a.cpp", | 
|  | 4681 | "a.yy", | 
|  | 4682 | ], | 
|  | 4683 | shared_libs: ["sharedlib"], | 
|  | 4684 | static_libs: ["staticlib"], | 
|  | 4685 | yacc: { | 
|  | 4686 | flags: ["someYaccFlag"], | 
|  | 4687 | gen_location_hh: true, | 
|  | 4688 | gen_position_hh: true, | 
|  | 4689 | }, | 
|  | 4690 | } | 
|  | 4691 | cc_library_static { | 
|  | 4692 | name: "staticlib", | 
|  | 4693 | bazel_module: { bp2build_available: false }, | 
|  | 4694 | } | 
|  | 4695 | cc_library { | 
|  | 4696 | name: "sharedlib", | 
|  | 4697 | bazel_module: { bp2build_available: false }, | 
|  | 4698 | } | 
|  | 4699 | `, | 
|  | 4700 | ExpectedBazelTargets: []string{ | 
|  | 4701 | MakeBazelTarget("cc_yacc_static_library", "a_yacc", AttrNameToString{ | 
|  | 4702 | "src":                         `"a.yy"`, | 
|  | 4703 | "implementation_deps":         `[":staticlib"]`, | 
|  | 4704 | "implementation_dynamic_deps": `[":sharedlib"]`, | 
|  | 4705 | "flags":                       `["someYaccFlag"]`, | 
|  | 4706 | "gen_location_hh":             "True", | 
|  | 4707 | "gen_position_hh":             "True", | 
|  | 4708 | "local_includes":              `["."]`, | 
|  | 4709 | }), | 
|  | 4710 | MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ | 
|  | 4711 | "srcs":                              `["a.cpp"]`, | 
|  | 4712 | "implementation_deps":               `[":staticlib"]`, | 
|  | 4713 | "implementation_dynamic_deps":       `[":sharedlib"]`, | 
|  | 4714 | "implementation_whole_archive_deps": `[":a_yacc"]`, | 
|  | 4715 | "local_includes":                    `["."]`, | 
|  | 4716 | }), | 
|  | 4717 | MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{ | 
|  | 4718 | "srcs":                              `["a.cpp"]`, | 
|  | 4719 | "implementation_deps":               `[":staticlib"]`, | 
|  | 4720 | "implementation_dynamic_deps":       `[":sharedlib"]`, | 
|  | 4721 | "implementation_whole_archive_deps": `[":a_yacc"]`, | 
|  | 4722 | "local_includes":                    `["."]`, | 
|  | 4723 | }), | 
|  | 4724 | }, | 
|  | 4725 | }) | 
|  | 4726 | } | 
| Spandan Das | fb04c41 | 2023-05-15 18:35:36 +0000 | [diff] [blame] | 4727 |  | 
|  | 4728 | func TestCcLibraryHostLdLibs(t *testing.T) { | 
|  | 4729 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4730 | Description:                "cc_binary linker flags for host_ldlibs", | 
|  | 4731 | ModuleTypeUnderTest:        "cc_binary", | 
|  | 4732 | ModuleTypeUnderTestFactory: cc.BinaryFactory, | 
|  | 4733 | Blueprint: soongCcLibraryPreamble + `cc_binary { | 
|  | 4734 | name: "a", | 
|  | 4735 | host_supported: true, | 
|  | 4736 | ldflags: ["-lcommon"], | 
|  | 4737 | target: { | 
|  | 4738 | linux: { | 
|  | 4739 | host_ldlibs: [ | 
|  | 4740 | "-llinux", | 
|  | 4741 | ], | 
|  | 4742 | }, | 
|  | 4743 | darwin: { | 
|  | 4744 | ldflags: ["-ldarwinadditional"], | 
|  | 4745 | host_ldlibs: [ | 
|  | 4746 | "-ldarwin", | 
|  | 4747 | ], | 
|  | 4748 | }, | 
|  | 4749 | windows: { | 
|  | 4750 | host_ldlibs: [ | 
|  | 4751 | "-lwindows", | 
|  | 4752 | ], | 
|  | 4753 | }, | 
|  | 4754 | }, | 
|  | 4755 | } | 
|  | 4756 | `, | 
|  | 4757 | ExpectedBazelTargets: []string{ | 
|  | 4758 | MakeBazelTargetNoRestrictions("cc_binary", "a", AttrNameToString{ | 
|  | 4759 | "linkopts": `["-lcommon"] + select({ | 
|  | 4760 | "//build/bazel/platforms/os:darwin": [ | 
|  | 4761 | "-ldarwinadditional", | 
|  | 4762 | "-ldarwin", | 
|  | 4763 | ], | 
|  | 4764 | "//build/bazel/platforms/os:linux_glibc": ["-llinux"], | 
|  | 4765 | "//build/bazel/platforms/os:windows": ["-lwindows"], | 
|  | 4766 | "//conditions:default": [], | 
|  | 4767 | })`, | 
|  | 4768 | "local_includes": `["."]`, | 
|  | 4769 | }), | 
|  | 4770 | }, | 
|  | 4771 | }) | 
|  | 4772 | } | 
| Trevor Radcliffe | 27669c0 | 2023-03-28 20:47:10 +0000 | [diff] [blame] | 4773 |  | 
|  | 4774 | func TestCcLibraryWithCfi(t *testing.T) { | 
|  | 4775 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4776 | Description:                "cc_library has correct features when cfi is enabled", | 
|  | 4777 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4778 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4779 | Blueprint: ` | 
|  | 4780 | cc_library { | 
|  | 4781 | name: "foo", | 
|  | 4782 | sanitize: { | 
|  | 4783 | cfi: true, | 
|  | 4784 | }, | 
|  | 4785 | }`, | 
|  | 4786 | ExpectedBazelTargets: []string{ | 
|  | 4787 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 4788 | "features":       `["android_cfi"]`, | 
|  | 4789 | "local_includes": `["."]`, | 
|  | 4790 | }), | 
|  | 4791 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 4792 | "features":       `["android_cfi"]`, | 
|  | 4793 | "local_includes": `["."]`, | 
|  | 4794 | }), | 
|  | 4795 | }, | 
|  | 4796 | }) | 
|  | 4797 | } | 
|  | 4798 |  | 
|  | 4799 | func TestCcLibraryWithCfiOsSpecific(t *testing.T) { | 
|  | 4800 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4801 | Description:                "cc_library has correct features when cfi is enabled for specific variants", | 
|  | 4802 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4803 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4804 | Blueprint: ` | 
|  | 4805 | cc_library { | 
|  | 4806 | name: "foo", | 
|  | 4807 | target: { | 
|  | 4808 | android: { | 
|  | 4809 | sanitize: { | 
|  | 4810 | cfi: true, | 
|  | 4811 | }, | 
|  | 4812 | }, | 
|  | 4813 | }, | 
|  | 4814 | }`, | 
|  | 4815 | ExpectedBazelTargets: []string{ | 
|  | 4816 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 4817 | "features": `select({ | 
|  | 4818 | "//build/bazel/platforms/os:android": ["android_cfi"], | 
|  | 4819 | "//conditions:default": [], | 
|  | 4820 | })`, | 
|  | 4821 | "local_includes": `["."]`, | 
|  | 4822 | }), | 
|  | 4823 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 4824 | "features": `select({ | 
|  | 4825 | "//build/bazel/platforms/os:android": ["android_cfi"], | 
|  | 4826 | "//conditions:default": [], | 
|  | 4827 | })`, | 
|  | 4828 | "local_includes": `["."]`, | 
|  | 4829 | }), | 
|  | 4830 | }, | 
|  | 4831 | }) | 
|  | 4832 | } | 
|  | 4833 |  | 
|  | 4834 | func TestCcLibraryWithCfiAndCfiAssemblySupport(t *testing.T) { | 
|  | 4835 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4836 | Description:                "cc_library has correct features when cfi is enabled with cfi_assembly_support", | 
|  | 4837 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4838 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4839 | Blueprint: ` | 
|  | 4840 | cc_library { | 
|  | 4841 | name: "foo", | 
|  | 4842 | sanitize: { | 
|  | 4843 | cfi: true, | 
|  | 4844 | config: { | 
|  | 4845 | cfi_assembly_support: true, | 
|  | 4846 | }, | 
|  | 4847 | }, | 
|  | 4848 | }`, | 
|  | 4849 | ExpectedBazelTargets: []string{ | 
|  | 4850 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 4851 | "features": `[ | 
|  | 4852 | "android_cfi", | 
|  | 4853 | "android_cfi_assembly_support", | 
|  | 4854 | ]`, | 
|  | 4855 | "local_includes": `["."]`, | 
|  | 4856 | }), | 
|  | 4857 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 4858 | "features": `[ | 
|  | 4859 | "android_cfi", | 
|  | 4860 | "android_cfi_assembly_support", | 
|  | 4861 | ]`, | 
|  | 4862 | "local_includes": `["."]`, | 
|  | 4863 | }), | 
|  | 4864 | }, | 
|  | 4865 | }) | 
|  | 4866 | } | 
| Spandan Das | 39ccf93 | 2023-05-26 18:03:39 +0000 | [diff] [blame] | 4867 |  | 
| Trevor Radcliffe | 523c5c6 | 2023-06-16 20:15:45 +0000 | [diff] [blame] | 4868 | func TestCcLibraryExplicitlyDisablesCfiWhenFalse(t *testing.T) { | 
|  | 4869 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4870 | Description:                "cc_library disables cfi when explciitly set to false in the bp", | 
|  | 4871 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4872 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4873 | Blueprint: ` | 
|  | 4874 | cc_library { | 
|  | 4875 | name: "foo", | 
|  | 4876 | sanitize: { | 
|  | 4877 | cfi: false, | 
|  | 4878 | }, | 
|  | 4879 | } | 
|  | 4880 | `, | 
|  | 4881 | ExpectedBazelTargets: []string{ | 
|  | 4882 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ | 
|  | 4883 | "features":       `["-android_cfi"]`, | 
|  | 4884 | "local_includes": `["."]`, | 
|  | 4885 | }), | 
|  | 4886 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ | 
|  | 4887 | "features":       `["-android_cfi"]`, | 
|  | 4888 | "local_includes": `["."]`, | 
|  | 4889 | }), | 
|  | 4890 | }, | 
|  | 4891 | }) | 
|  | 4892 | } | 
|  | 4893 |  | 
| Spandan Das | 39ccf93 | 2023-05-26 18:03:39 +0000 | [diff] [blame] | 4894 | func TestCcLibraryWithStem(t *testing.T) { | 
|  | 4895 | runCcLibraryTestCase(t, Bp2buildTestCase{ | 
|  | 4896 | Description:                "cc_library with stem property", | 
|  | 4897 | ModuleTypeUnderTest:        "cc_library_shared", | 
|  | 4898 | ModuleTypeUnderTestFactory: cc.LibrarySharedFactory, | 
|  | 4899 | Blueprint: soongCcLibraryPreamble + ` | 
|  | 4900 | cc_library_shared { | 
|  | 4901 | name: "foo_with_stem_simple", | 
|  | 4902 | stem: "foo", | 
|  | 4903 | } | 
|  | 4904 | cc_library_shared { | 
|  | 4905 | name: "foo_with_arch_variant_stem", | 
|  | 4906 | arch: { | 
|  | 4907 | arm: { | 
|  | 4908 | stem: "foo-arm", | 
|  | 4909 | }, | 
|  | 4910 | arm64: { | 
|  | 4911 | stem: "foo-arm64", | 
|  | 4912 | }, | 
|  | 4913 | }, | 
|  | 4914 | } | 
|  | 4915 | `, | 
|  | 4916 | ExpectedBazelTargets: []string{ | 
|  | 4917 | MakeBazelTarget("cc_library_shared", "foo_with_stem_simple", AttrNameToString{ | 
|  | 4918 | "stem":           `"foo"`, | 
|  | 4919 | "local_includes": `["."]`, | 
|  | 4920 | }), | 
|  | 4921 | MakeBazelTarget("cc_library_shared", "foo_with_arch_variant_stem", AttrNameToString{ | 
|  | 4922 | "stem": `select({ | 
|  | 4923 | "//build/bazel/platforms/arch:arm": "foo-arm", | 
|  | 4924 | "//build/bazel/platforms/arch:arm64": "foo-arm64", | 
|  | 4925 | "//conditions:default": None, | 
|  | 4926 | })`, | 
|  | 4927 | "local_includes": `["."]`, | 
|  | 4928 | }), | 
|  | 4929 | }, | 
|  | 4930 | }) | 
|  | 4931 | } | 
| Spandan Das | c53767e | 2023-08-03 23:02:26 +0000 | [diff] [blame] | 4932 |  | 
|  | 4933 | // Bazel enforces that proto_library and the .proto file are in the same bazel package | 
|  | 4934 | func TestGenerateProtoLibraryInSamePackage(t *testing.T) { | 
|  | 4935 | tc := Bp2buildTestCase{ | 
|  | 4936 | Description:                "cc_library depends on .proto files from multiple packages", | 
|  | 4937 | ModuleTypeUnderTest:        "cc_library", | 
|  | 4938 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 4939 | Blueprint: ` | 
|  | 4940 | cc_library_static { | 
|  | 4941 | name: "foo", | 
|  | 4942 | srcs: [ | 
|  | 4943 | "foo.proto", | 
|  | 4944 | "bar/bar.proto", // Different package because there is a bar/Android.bp | 
|  | 4945 | "baz/subbaz/baz.proto", // Different package because there is baz/subbaz/Android.bp | 
|  | 4946 | ], | 
| Liz Kammer | 7dc6bcb | 2023-08-10 12:51:59 -0400 | [diff] [blame] | 4947 | proto: { | 
|  | 4948 | canonical_path_from_root: true, | 
|  | 4949 | } | 
| Spandan Das | c53767e | 2023-08-03 23:02:26 +0000 | [diff] [blame] | 4950 | } | 
|  | 4951 | ` + simpleModuleDoNotConvertBp2build("cc_library", "libprotobuf-cpp-lite"), | 
|  | 4952 | Filesystem: map[string]string{ | 
|  | 4953 | "bar/Android.bp":        "", | 
|  | 4954 | "baz/subbaz/Android.bp": "", | 
|  | 4955 | }, | 
|  | 4956 | } | 
|  | 4957 |  | 
|  | 4958 | // We will run the test 3 times and check in the root, bar and baz/subbaz directories | 
|  | 4959 | // Root dir | 
|  | 4960 | tc.ExpectedBazelTargets = []string{ | 
|  | 4961 | MakeBazelTarget("cc_library_static", "foo", AttrNameToString{ | 
|  | 4962 | "local_includes":                    `["."]`, | 
|  | 4963 | "deps":                              `[":libprotobuf-cpp-lite"]`, | 
|  | 4964 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, | 
|  | 4965 | }), | 
|  | 4966 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ | 
|  | 4967 | "srcs": `["foo.proto"]`, | 
| Spandan Das | e0f2ed5 | 2023-08-22 18:19:44 +0000 | [diff] [blame] | 4968 | "tags": `["manual"]`, | 
| Spandan Das | c53767e | 2023-08-03 23:02:26 +0000 | [diff] [blame] | 4969 | }), | 
|  | 4970 | MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{ | 
|  | 4971 | "deps": `[ | 
|  | 4972 | ":foo_proto", | 
|  | 4973 | "//bar:foo_proto", | 
|  | 4974 | "//baz/subbaz:foo_proto", | 
|  | 4975 | ]`, | 
|  | 4976 | }), | 
|  | 4977 | } | 
|  | 4978 | runCcLibraryTestCase(t, tc) | 
|  | 4979 |  | 
|  | 4980 | // bar dir | 
|  | 4981 | tc.Dir = "bar" | 
|  | 4982 | tc.ExpectedBazelTargets = []string{ | 
|  | 4983 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ | 
| Liz Kammer | 7dc6bcb | 2023-08-10 12:51:59 -0400 | [diff] [blame] | 4984 | "srcs": `["//bar:bar.proto"]`, | 
| Spandan Das | 215adb4 | 2023-08-14 16:52:24 +0000 | [diff] [blame] | 4985 | "tags": `["manual"]`, | 
| Spandan Das | c53767e | 2023-08-03 23:02:26 +0000 | [diff] [blame] | 4986 | }), | 
|  | 4987 | } | 
|  | 4988 | runCcLibraryTestCase(t, tc) | 
|  | 4989 |  | 
|  | 4990 | // baz/subbaz dir | 
|  | 4991 | tc.Dir = "baz/subbaz" | 
|  | 4992 | tc.ExpectedBazelTargets = []string{ | 
|  | 4993 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ | 
| Liz Kammer | 7dc6bcb | 2023-08-10 12:51:59 -0400 | [diff] [blame] | 4994 | "srcs": `["//baz/subbaz:baz.proto"]`, | 
| Spandan Das | 215adb4 | 2023-08-14 16:52:24 +0000 | [diff] [blame] | 4995 | "tags": `["manual"]`, | 
| Liz Kammer | 7dc6bcb | 2023-08-10 12:51:59 -0400 | [diff] [blame] | 4996 | }), | 
|  | 4997 | } | 
|  | 4998 | runCcLibraryTestCase(t, tc) | 
|  | 4999 | } | 
|  | 5000 |  | 
|  | 5001 | // Bazel enforces that proto_library and the .proto file are in the same bazel package | 
|  | 5002 | func TestGenerateProtoLibraryInSamePackageNotCanonicalFromRoot(t *testing.T) { | 
|  | 5003 | tc := Bp2buildTestCase{ | 
|  | 5004 | Description:                "cc_library depends on .proto files from multiple packages", | 
|  | 5005 | ModuleTypeUnderTest:        "cc_library", | 
|  | 5006 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 5007 | Blueprint: ` | 
|  | 5008 | cc_library_static { | 
|  | 5009 | name: "foo", | 
|  | 5010 | srcs: [ | 
|  | 5011 | "foo.proto", | 
|  | 5012 | "bar/bar.proto", // Different package because there is a bar/Android.bp | 
|  | 5013 | "baz/subbaz/baz.proto", // Different package because there is baz/subbaz/Android.bp | 
|  | 5014 | ], | 
|  | 5015 | proto: { | 
|  | 5016 | canonical_path_from_root: false, | 
|  | 5017 | } | 
|  | 5018 | } | 
|  | 5019 | ` + simpleModuleDoNotConvertBp2build("cc_library", "libprotobuf-cpp-lite"), | 
|  | 5020 | Filesystem: map[string]string{ | 
|  | 5021 | "bar/Android.bp":        "", | 
|  | 5022 | "baz/subbaz/Android.bp": "", | 
|  | 5023 | }, | 
|  | 5024 | } | 
|  | 5025 |  | 
|  | 5026 | // We will run the test 3 times and check in the root, bar and baz/subbaz directories | 
|  | 5027 | // Root dir | 
|  | 5028 | tc.ExpectedBazelTargets = []string{ | 
|  | 5029 | MakeBazelTarget("cc_library_static", "foo", AttrNameToString{ | 
|  | 5030 | "local_includes":                    `["."]`, | 
|  | 5031 | "deps":                              `[":libprotobuf-cpp-lite"]`, | 
|  | 5032 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, | 
|  | 5033 | }), | 
|  | 5034 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ | 
|  | 5035 | "srcs":                `["foo.proto"]`, | 
|  | 5036 | "strip_import_prefix": `""`, | 
| Spandan Das | e0f2ed5 | 2023-08-22 18:19:44 +0000 | [diff] [blame] | 5037 | "tags":                `["manual"]`, | 
| Liz Kammer | 7dc6bcb | 2023-08-10 12:51:59 -0400 | [diff] [blame] | 5038 | }), | 
|  | 5039 | MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{ | 
|  | 5040 | "deps": `[ | 
|  | 5041 | ":foo_proto", | 
|  | 5042 | "//bar:foo_proto", | 
|  | 5043 | "//baz/subbaz:foo_proto", | 
|  | 5044 | ]`, | 
|  | 5045 | }), | 
|  | 5046 | } | 
|  | 5047 | runCcLibraryTestCase(t, tc) | 
|  | 5048 |  | 
|  | 5049 | // bar dir | 
|  | 5050 | tc.Dir = "bar" | 
|  | 5051 | tc.ExpectedBazelTargets = []string{ | 
|  | 5052 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ | 
|  | 5053 | "srcs":                `["//bar:bar.proto"]`, | 
|  | 5054 | "strip_import_prefix": `""`, | 
|  | 5055 | "import_prefix":       `"bar"`, | 
| Spandan Das | 215adb4 | 2023-08-14 16:52:24 +0000 | [diff] [blame] | 5056 | "tags":                `["manual"]`, | 
| Liz Kammer | 7dc6bcb | 2023-08-10 12:51:59 -0400 | [diff] [blame] | 5057 | }), | 
|  | 5058 | } | 
|  | 5059 | runCcLibraryTestCase(t, tc) | 
|  | 5060 |  | 
|  | 5061 | // baz/subbaz dir | 
|  | 5062 | tc.Dir = "baz/subbaz" | 
|  | 5063 | tc.ExpectedBazelTargets = []string{ | 
|  | 5064 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ | 
|  | 5065 | "srcs":                `["//baz/subbaz:baz.proto"]`, | 
|  | 5066 | "strip_import_prefix": `""`, | 
|  | 5067 | "import_prefix":       `"baz/subbaz"`, | 
| Spandan Das | 215adb4 | 2023-08-14 16:52:24 +0000 | [diff] [blame] | 5068 | "tags":                `["manual"]`, | 
| Spandan Das | c53767e | 2023-08-03 23:02:26 +0000 | [diff] [blame] | 5069 | }), | 
|  | 5070 | } | 
|  | 5071 | runCcLibraryTestCase(t, tc) | 
|  | 5072 | } | 
| Spandan Das | ec39d51 | 2023-08-15 22:08:18 +0000 | [diff] [blame] | 5073 |  | 
|  | 5074 | func TestProtoIncludeDirs(t *testing.T) { | 
|  | 5075 | tc := Bp2buildTestCase{ | 
|  | 5076 | Description:                "cc_library depends on .proto files using proto.include_dirs", | 
|  | 5077 | ModuleTypeUnderTest:        "cc_library", | 
|  | 5078 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 5079 | Blueprint: ` | 
|  | 5080 | cc_library_static { | 
|  | 5081 | name: "foo", | 
|  | 5082 | srcs: [ | 
|  | 5083 | "foo.proto", | 
|  | 5084 | ], | 
|  | 5085 | proto: { | 
|  | 5086 | include_dirs: ["bar"], | 
|  | 5087 | } | 
|  | 5088 | } | 
|  | 5089 | ` + simpleModuleDoNotConvertBp2build("cc_library", "libprotobuf-cpp-lite"), | 
|  | 5090 | Filesystem: map[string]string{ | 
|  | 5091 | "bar/Android.bp":     "", | 
|  | 5092 | "bar/bar.proto":      "", | 
|  | 5093 | "bar/baz/Android.bp": "", | 
|  | 5094 | "bar/baz/baz.proto":  "", | 
|  | 5095 | }, | 
|  | 5096 | } | 
|  | 5097 |  | 
|  | 5098 | // We will run the test 3 times and check in the root, bar and bar/baz directories | 
|  | 5099 | // Root dir | 
|  | 5100 | tc.ExpectedBazelTargets = []string{ | 
|  | 5101 | MakeBazelTarget("cc_library_static", "foo", AttrNameToString{ | 
|  | 5102 | "local_includes":                    `["."]`, | 
|  | 5103 | "deps":                              `[":libprotobuf-cpp-lite"]`, | 
|  | 5104 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, | 
|  | 5105 | }), | 
|  | 5106 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ | 
|  | 5107 | "srcs": `["foo.proto"]`, | 
| Spandan Das | e0f2ed5 | 2023-08-22 18:19:44 +0000 | [diff] [blame] | 5108 | "tags": `["manual"]`, | 
| Spandan Das | ec39d51 | 2023-08-15 22:08:18 +0000 | [diff] [blame] | 5109 | }), | 
|  | 5110 | MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{ | 
|  | 5111 | "deps": `[":foo_proto"]`, | 
|  | 5112 | "transitive_deps": `[ | 
|  | 5113 | "//bar:bar.include_dir_bp2build_generated_proto", | 
|  | 5114 | "//bar/baz:bar.include_dir_bp2build_generated_proto", | 
|  | 5115 | ]`, | 
|  | 5116 | }), | 
|  | 5117 | } | 
|  | 5118 | runCcLibraryTestCase(t, tc) | 
|  | 5119 |  | 
|  | 5120 | // bar dir | 
|  | 5121 | tc.Dir = "bar" | 
|  | 5122 | tc.ExpectedBazelTargets = []string{ | 
| Spandan Das | f26ee15 | 2023-08-24 23:21:04 +0000 | [diff] [blame] | 5123 | MakeBazelTargetNoRestrictions("proto_library", "bar.include_dir_bp2build_generated_proto", AttrNameToString{ | 
| Spandan Das | ec39d51 | 2023-08-15 22:08:18 +0000 | [diff] [blame] | 5124 | "srcs":                `["bar.proto"]`, | 
|  | 5125 | "strip_import_prefix": `""`, | 
|  | 5126 | "tags":                `["manual"]`, | 
|  | 5127 | }), | 
|  | 5128 | } | 
|  | 5129 | runCcLibraryTestCase(t, tc) | 
|  | 5130 |  | 
|  | 5131 | // bar/baz dir | 
|  | 5132 | tc.Dir = "bar/baz" | 
|  | 5133 | tc.ExpectedBazelTargets = []string{ | 
| Spandan Das | f26ee15 | 2023-08-24 23:21:04 +0000 | [diff] [blame] | 5134 | MakeBazelTargetNoRestrictions("proto_library", "bar.include_dir_bp2build_generated_proto", AttrNameToString{ | 
| Spandan Das | ec39d51 | 2023-08-15 22:08:18 +0000 | [diff] [blame] | 5135 | "srcs":                `["//bar/baz:baz.proto"]`, | 
|  | 5136 | "strip_import_prefix": `""`, | 
|  | 5137 | "import_prefix":       `"baz"`, | 
|  | 5138 | "tags":                `["manual"]`, | 
|  | 5139 | }), | 
|  | 5140 | } | 
|  | 5141 | runCcLibraryTestCase(t, tc) | 
|  | 5142 | } | 
| Spandan Das | 4e5a194 | 2023-08-22 19:20:39 +0000 | [diff] [blame] | 5143 |  | 
| Spandan Das | f26ee15 | 2023-08-24 23:21:04 +0000 | [diff] [blame] | 5144 | func TestProtoIncludeDirsWithSrcsInMultiplePackages(t *testing.T) { | 
|  | 5145 | tc := Bp2buildTestCase{ | 
|  | 5146 | Description:                "cc_library has srcs in multiple bazel packages and uses proto.include_dirs", | 
|  | 5147 | ModuleTypeUnderTest:        "cc_library", | 
|  | 5148 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 5149 | Blueprint: ` | 
|  | 5150 | cc_library_static { | 
|  | 5151 | name: "foo", | 
|  | 5152 | srcs: [ | 
|  | 5153 | "foo.proto", | 
|  | 5154 | "bar/bar.proto", | 
|  | 5155 | ], | 
|  | 5156 | proto: { | 
|  | 5157 | include_dirs: ["baz"], | 
|  | 5158 | } | 
|  | 5159 | } | 
|  | 5160 | ` + simpleModuleDoNotConvertBp2build("cc_library", "libprotobuf-cpp-lite"), | 
|  | 5161 | Filesystem: map[string]string{ | 
|  | 5162 | "bar/Android.bp": "", // package boundary | 
|  | 5163 | "baz/Android.bp": "", | 
|  | 5164 | "baz/baz.proto":  "", | 
|  | 5165 | }, | 
|  | 5166 | } | 
|  | 5167 |  | 
|  | 5168 | tc.ExpectedBazelTargets = []string{ | 
|  | 5169 | MakeBazelTarget("cc_library_static", "foo", AttrNameToString{ | 
|  | 5170 | "local_includes":                    `["."]`, | 
|  | 5171 | "deps":                              `[":libprotobuf-cpp-lite"]`, | 
|  | 5172 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, | 
|  | 5173 | }), | 
|  | 5174 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ | 
|  | 5175 | "srcs": `["foo.proto"]`, | 
|  | 5176 | "tags": `["manual"]`, | 
|  | 5177 | }), | 
|  | 5178 | MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{ | 
|  | 5179 | "deps": `[ | 
|  | 5180 | ":foo_proto", | 
|  | 5181 | "//bar:foo_proto", | 
|  | 5182 | ]`, | 
|  | 5183 | "transitive_deps": `["//baz:baz.include_dir_bp2build_generated_proto"]`, | 
|  | 5184 | }), | 
|  | 5185 | } | 
|  | 5186 | runCcLibraryTestCase(t, tc) | 
|  | 5187 |  | 
|  | 5188 | } | 
|  | 5189 |  | 
| Spandan Das | 4e5a194 | 2023-08-22 19:20:39 +0000 | [diff] [blame] | 5190 | func TestProtoLocalIncludeDirs(t *testing.T) { | 
|  | 5191 | tc := Bp2buildTestCase{ | 
|  | 5192 | Description:                "cc_library depends on .proto files using proto.local_include_dirs", | 
|  | 5193 | ModuleTypeUnderTest:        "cc_library", | 
|  | 5194 | ModuleTypeUnderTestFactory: cc.LibraryFactory, | 
|  | 5195 | Blueprint:                  simpleModuleDoNotConvertBp2build("cc_library", "libprotobuf-cpp-lite"), | 
|  | 5196 | Filesystem: map[string]string{ | 
|  | 5197 | "foo/Android.bp": `cc_library_static { | 
|  | 5198 | name: "foo", | 
|  | 5199 | srcs: [ | 
|  | 5200 | "foo.proto", | 
|  | 5201 | ], | 
|  | 5202 | proto: { | 
|  | 5203 | local_include_dirs: ["foo_subdir"], | 
|  | 5204 | }, | 
|  | 5205 | bazel_module: { bp2build_available: true }, | 
|  | 5206 | }`, | 
|  | 5207 | "foo/foo.proto":                   "", | 
|  | 5208 | "foo/foo_subdir/Android.bp":       "", | 
|  | 5209 | "foo/foo_subdir/foo_subdir.proto": "", | 
|  | 5210 | }, | 
|  | 5211 | } | 
|  | 5212 |  | 
|  | 5213 | // We will run the test 2 times and check in foo and foo/foo_subdir directories | 
|  | 5214 | // foo dir | 
|  | 5215 | tc.Dir = "foo" | 
|  | 5216 | tc.ExpectedBazelTargets = []string{ | 
|  | 5217 | MakeBazelTarget("cc_library_static", "foo", AttrNameToString{ | 
|  | 5218 | "local_includes":                    `["."]`, | 
|  | 5219 | "deps":                              `["//:libprotobuf-cpp-lite"]`, | 
|  | 5220 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, | 
|  | 5221 | }), | 
|  | 5222 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ | 
|  | 5223 | "srcs": `["foo.proto"]`, | 
|  | 5224 | "tags": `["manual"]`, | 
|  | 5225 | }), | 
|  | 5226 | MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{ | 
|  | 5227 | "deps":            `[":foo_proto"]`, | 
|  | 5228 | "transitive_deps": `["//foo/foo_subdir:foo.foo_subdir.include_dir_bp2build_generated_proto"]`, | 
|  | 5229 | }), | 
|  | 5230 | } | 
|  | 5231 | runCcLibraryTestCase(t, tc) | 
|  | 5232 |  | 
|  | 5233 | // foo/foo_subdir | 
|  | 5234 | tc.Dir = "foo/foo_subdir" | 
|  | 5235 | tc.ExpectedBazelTargets = []string{ | 
| Spandan Das | f26ee15 | 2023-08-24 23:21:04 +0000 | [diff] [blame] | 5236 | MakeBazelTargetNoRestrictions("proto_library", "foo.foo_subdir.include_dir_bp2build_generated_proto", AttrNameToString{ | 
| Spandan Das | 4e5a194 | 2023-08-22 19:20:39 +0000 | [diff] [blame] | 5237 | "srcs":                `["foo_subdir.proto"]`, | 
|  | 5238 | "strip_import_prefix": `""`, | 
|  | 5239 | "tags":                `["manual"]`, | 
|  | 5240 | }), | 
|  | 5241 | } | 
|  | 5242 | runCcLibraryTestCase(t, tc) | 
|  | 5243 | } |