Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 1 | // Copyright 2021 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package bp2build |
| 16 | |
| 17 | import ( |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 18 | "fmt" |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 1c92aef | 2021-08-23 16:10:00 +0000 | [diff] [blame] | 19 | "testing" |
| 20 | |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 21 | "android/soong/android" |
| 22 | "android/soong/cc" |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 23 | ) |
| 24 | |
| 25 | const ( |
| 26 | // See cc/testing.go for more context |
| 27 | soongCcLibraryPreamble = ` |
| 28 | cc_defaults { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 29 | name: "linux_bionic_supported", |
Liz Kammer | baced71 | 2022-09-16 09:01:29 -0400 | [diff] [blame] | 30 | } |
| 31 | ` |
| 32 | |
| 33 | soongCcVersionLibBpPath = "build/soong/cc/libbuildversion/Android.bp" |
| 34 | soongCcVersionLibBp = ` |
| 35 | cc_library_static { |
| 36 | name: "libbuildversion", |
| 37 | bazel_module: { bp2build_available: false }, |
| 38 | } |
| 39 | ` |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 40 | |
| 41 | soongCcProtoLibraries = ` |
| 42 | cc_library { |
| 43 | name: "libprotobuf-cpp-lite", |
| 44 | bazel_module: { bp2build_available: false }, |
| 45 | } |
| 46 | |
| 47 | cc_library { |
| 48 | name: "libprotobuf-cpp-full", |
| 49 | bazel_module: { bp2build_available: false }, |
| 50 | }` |
| 51 | |
| 52 | soongCcProtoPreamble = soongCcLibraryPreamble + soongCcProtoLibraries |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 53 | ) |
| 54 | |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 55 | func runCcLibraryTestCase(t *testing.T, tc Bp2buildTestCase) { |
Liz Kammer | e4982e8 | 2021-05-25 10:39:35 -0400 | [diff] [blame] | 56 | t.Helper() |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 57 | RunBp2BuildTestCase(t, registerCcLibraryModuleTypes, tc) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 58 | } |
| 59 | |
| 60 | func registerCcLibraryModuleTypes(ctx android.RegistrationContext) { |
| 61 | cc.RegisterCCBuildComponents(ctx) |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 62 | ctx.RegisterModuleType("filegroup", android.FileGroupFactory) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 63 | ctx.RegisterModuleType("cc_library_static", cc.LibraryStaticFactory) |
Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 64 | ctx.RegisterModuleType("cc_prebuilt_library_static", cc.PrebuiltStaticLibraryFactory) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 65 | ctx.RegisterModuleType("cc_library_headers", cc.LibraryHeaderFactory) |
| 66 | } |
| 67 | |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 68 | func TestCcLibrarySimple(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 69 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 70 | Description: "cc_library - simple example", |
| 71 | ModuleTypeUnderTest: "cc_library", |
| 72 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 73 | Filesystem: map[string]string{ |
Liz Kammer | baced71 | 2022-09-16 09:01:29 -0400 | [diff] [blame] | 74 | soongCcVersionLibBpPath: soongCcVersionLibBp, |
| 75 | "android.cpp": "", |
| 76 | "bionic.cpp": "", |
| 77 | "darwin.cpp": "", |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 78 | // Refer to cc.headerExts for the supported header extensions in Soong. |
| 79 | "header.h": "", |
| 80 | "header.hh": "", |
| 81 | "header.hpp": "", |
| 82 | "header.hxx": "", |
| 83 | "header.h++": "", |
| 84 | "header.inl": "", |
| 85 | "header.inc": "", |
| 86 | "header.ipp": "", |
| 87 | "header.h.generic": "", |
| 88 | "impl.cpp": "", |
| 89 | "linux.cpp": "", |
| 90 | "x86.cpp": "", |
| 91 | "x86_64.cpp": "", |
| 92 | "foo-dir/a.h": "", |
| 93 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 94 | Blueprint: soongCcLibraryPreamble + |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 95 | simpleModuleDoNotConvertBp2build("cc_library_headers", "some-headers") + ` |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 96 | cc_library { |
| 97 | name: "foo-lib", |
| 98 | srcs: ["impl.cpp"], |
| 99 | cflags: ["-Wall"], |
| 100 | header_libs: ["some-headers"], |
| 101 | export_include_dirs: ["foo-dir"], |
| 102 | ldflags: ["-Wl,--exclude-libs=bar.a"], |
| 103 | arch: { |
| 104 | x86: { |
| 105 | ldflags: ["-Wl,--exclude-libs=baz.a"], |
| 106 | srcs: ["x86.cpp"], |
| 107 | }, |
| 108 | x86_64: { |
| 109 | ldflags: ["-Wl,--exclude-libs=qux.a"], |
| 110 | srcs: ["x86_64.cpp"], |
| 111 | }, |
| 112 | }, |
| 113 | target: { |
| 114 | android: { |
| 115 | srcs: ["android.cpp"], |
| 116 | }, |
| 117 | linux_glibc: { |
| 118 | srcs: ["linux.cpp"], |
| 119 | }, |
| 120 | darwin: { |
| 121 | srcs: ["darwin.cpp"], |
| 122 | }, |
Liz Kammer | 01a16e8 | 2021-07-16 16:33:47 -0400 | [diff] [blame] | 123 | bionic: { |
| 124 | srcs: ["bionic.cpp"] |
| 125 | }, |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 126 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 127 | include_build_directory: false, |
Yu Liu | fc60316 | 2022-03-01 15:44:08 -0800 | [diff] [blame] | 128 | sdk_version: "current", |
| 129 | min_sdk_version: "29", |
Yu Liu | a79c946 | 2022-03-22 16:35:22 -0700 | [diff] [blame] | 130 | use_version_lib: true, |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 131 | } |
| 132 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 133 | ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 134 | "copts": `["-Wall"]`, |
| 135 | "export_includes": `["foo-dir"]`, |
| 136 | "implementation_deps": `[":some-headers"]`, |
| 137 | "linkopts": `["-Wl,--exclude-libs=bar.a"] + select({ |
Jingwen Chen | ed9c17d | 2021-04-13 07:14:55 +0000 | [diff] [blame] | 138 | "//build/bazel/platforms/arch:x86": ["-Wl,--exclude-libs=baz.a"], |
| 139 | "//build/bazel/platforms/arch:x86_64": ["-Wl,--exclude-libs=qux.a"], |
| 140 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 141 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 142 | "srcs": `["impl.cpp"] + select({ |
Jingwen Chen | b4628eb | 2021-04-08 14:40:57 +0000 | [diff] [blame] | 143 | "//build/bazel/platforms/arch:x86": ["x86.cpp"], |
| 144 | "//build/bazel/platforms/arch:x86_64": ["x86_64.cpp"], |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 145 | "//conditions:default": [], |
| 146 | }) + select({ |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 147 | "//build/bazel/platforms/os:android": [ |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 148 | "bionic.cpp", |
Liz Kammer | fdd72e6 | 2021-10-11 15:41:03 -0400 | [diff] [blame] | 149 | "android.cpp", |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 150 | ], |
Jingwen Chen | b4628eb | 2021-04-08 14:40:57 +0000 | [diff] [blame] | 151 | "//build/bazel/platforms/os:darwin": ["darwin.cpp"], |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 152 | "//build/bazel/platforms/os:linux_bionic": ["bionic.cpp"], |
Colin Cross | 133782e | 2022-12-20 15:29:31 -0800 | [diff] [blame] | 153 | "//build/bazel/platforms/os:linux_glibc": ["linux.cpp"], |
Liz Kammer | 01a16e8 | 2021-07-16 16:33:47 -0400 | [diff] [blame] | 154 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 155 | })`, |
Liz Kammer | baced71 | 2022-09-16 09:01:29 -0400 | [diff] [blame] | 156 | "sdk_version": `"current"`, |
| 157 | "min_sdk_version": `"29"`, |
| 158 | "use_version_lib": `True`, |
| 159 | "implementation_whole_archive_deps": `["//build/soong/cc/libbuildversion:libbuildversion"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 160 | }), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 161 | }) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 162 | } |
| 163 | |
| 164 | func TestCcLibraryTrimmedLdAndroid(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 165 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 166 | Description: "cc_library - trimmed example of //bionic/linker:ld-android", |
| 167 | ModuleTypeUnderTest: "cc_library", |
| 168 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 169 | Filesystem: map[string]string{ |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 170 | "ld-android.cpp": "", |
| 171 | "linked_list.h": "", |
| 172 | "linker.h": "", |
| 173 | "linker_block_allocator.h": "", |
| 174 | "linker_cfi.h": "", |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 175 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 176 | Blueprint: soongCcLibraryPreamble + |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 177 | simpleModuleDoNotConvertBp2build("cc_library_headers", "libc_headers") + ` |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 178 | cc_library { |
| 179 | name: "fake-ld-android", |
| 180 | srcs: ["ld_android.cpp"], |
| 181 | cflags: [ |
| 182 | "-Wall", |
| 183 | "-Wextra", |
| 184 | "-Wunused", |
| 185 | "-Werror", |
| 186 | ], |
| 187 | header_libs: ["libc_headers"], |
| 188 | ldflags: [ |
| 189 | "-Wl,--exclude-libs=libgcc.a", |
| 190 | "-Wl,--exclude-libs=libgcc_stripped.a", |
| 191 | "-Wl,--exclude-libs=libclang_rt.builtins-arm-android.a", |
| 192 | "-Wl,--exclude-libs=libclang_rt.builtins-aarch64-android.a", |
| 193 | "-Wl,--exclude-libs=libclang_rt.builtins-i686-android.a", |
| 194 | "-Wl,--exclude-libs=libclang_rt.builtins-x86_64-android.a", |
| 195 | ], |
| 196 | arch: { |
| 197 | x86: { |
| 198 | ldflags: ["-Wl,--exclude-libs=libgcc_eh.a"], |
| 199 | }, |
| 200 | x86_64: { |
| 201 | ldflags: ["-Wl,--exclude-libs=libgcc_eh.a"], |
| 202 | }, |
| 203 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 204 | include_build_directory: false, |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 205 | } |
| 206 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 207 | ExpectedBazelTargets: makeCcLibraryTargets("fake-ld-android", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 208 | "srcs": `["ld_android.cpp"]`, |
| 209 | "copts": `[ |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 210 | "-Wall", |
| 211 | "-Wextra", |
| 212 | "-Wunused", |
| 213 | "-Werror", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 214 | ]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 215 | "implementation_deps": `[":libc_headers"]`, |
| 216 | "linkopts": `[ |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 217 | "-Wl,--exclude-libs=libgcc.a", |
| 218 | "-Wl,--exclude-libs=libgcc_stripped.a", |
| 219 | "-Wl,--exclude-libs=libclang_rt.builtins-arm-android.a", |
| 220 | "-Wl,--exclude-libs=libclang_rt.builtins-aarch64-android.a", |
| 221 | "-Wl,--exclude-libs=libclang_rt.builtins-i686-android.a", |
| 222 | "-Wl,--exclude-libs=libclang_rt.builtins-x86_64-android.a", |
| 223 | ] + select({ |
Jingwen Chen | b4628eb | 2021-04-08 14:40:57 +0000 | [diff] [blame] | 224 | "//build/bazel/platforms/arch:x86": ["-Wl,--exclude-libs=libgcc_eh.a"], |
| 225 | "//build/bazel/platforms/arch:x86_64": ["-Wl,--exclude-libs=libgcc_eh.a"], |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 226 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 227 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 228 | }), |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 229 | }) |
| 230 | } |
| 231 | |
| 232 | func TestCcLibraryExcludeSrcs(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 233 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 234 | Description: "cc_library exclude_srcs - trimmed example of //external/arm-optimized-routines:libarm-optimized-routines-math", |
| 235 | ModuleTypeUnderTest: "cc_library", |
| 236 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 237 | Dir: "external", |
| 238 | Filesystem: map[string]string{ |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 239 | "external/math/cosf.c": "", |
| 240 | "external/math/erf.c": "", |
| 241 | "external/math/erf_data.c": "", |
| 242 | "external/math/erff.c": "", |
| 243 | "external/math/erff_data.c": "", |
| 244 | "external/Android.bp": ` |
Jingwen Chen | 4ecc67d | 2021-04-27 09:47:02 +0000 | [diff] [blame] | 245 | cc_library { |
| 246 | name: "fake-libarm-optimized-routines-math", |
| 247 | exclude_srcs: [ |
| 248 | // Provided by: |
| 249 | // bionic/libm/upstream-freebsd/lib/msun/src/s_erf.c |
| 250 | // bionic/libm/upstream-freebsd/lib/msun/src/s_erff.c |
| 251 | "math/erf.c", |
| 252 | "math/erf_data.c", |
| 253 | "math/erff.c", |
| 254 | "math/erff_data.c", |
| 255 | ], |
| 256 | srcs: [ |
| 257 | "math/*.c", |
| 258 | ], |
| 259 | // arch-specific settings |
| 260 | arch: { |
| 261 | arm64: { |
| 262 | cflags: [ |
| 263 | "-DHAVE_FAST_FMA=1", |
| 264 | ], |
| 265 | }, |
| 266 | }, |
| 267 | bazel_module: { bp2build_available: true }, |
| 268 | } |
| 269 | `, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 270 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 271 | Blueprint: soongCcLibraryPreamble, |
| 272 | ExpectedBazelTargets: makeCcLibraryTargets("fake-libarm-optimized-routines-math", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 273 | "copts": `select({ |
Jingwen Chen | 4ecc67d | 2021-04-27 09:47:02 +0000 | [diff] [blame] | 274 | "//build/bazel/platforms/arch:arm64": ["-DHAVE_FAST_FMA=1"], |
| 275 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 276 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 277 | "local_includes": `["."]`, |
| 278 | "srcs_c": `["math/cosf.c"]`, |
| 279 | }), |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 280 | }) |
| 281 | } |
| 282 | |
| 283 | func TestCcLibrarySharedStaticProps(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 284 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 285 | Description: "cc_library shared/static props", |
| 286 | ModuleTypeUnderTest: "cc_library", |
| 287 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 288 | Filesystem: map[string]string{ |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 289 | "both.cpp": "", |
| 290 | "sharedonly.cpp": "", |
| 291 | "staticonly.cpp": "", |
| 292 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 293 | Blueprint: soongCcLibraryPreamble + ` |
Jingwen Chen | 53681ef | 2021-04-29 08:15:13 +0000 | [diff] [blame] | 294 | cc_library { |
| 295 | name: "a", |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 296 | srcs: ["both.cpp"], |
| 297 | cflags: ["bothflag"], |
| 298 | shared_libs: ["shared_dep_for_both"], |
Liz Kammer | cc2c1ef | 2022-03-21 09:03:29 -0400 | [diff] [blame] | 299 | static_libs: ["static_dep_for_both", "whole_and_static_lib_for_both"], |
| 300 | whole_static_libs: ["whole_static_lib_for_both", "whole_and_static_lib_for_both"], |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 301 | static: { |
| 302 | srcs: ["staticonly.cpp"], |
| 303 | cflags: ["staticflag"], |
| 304 | shared_libs: ["shared_dep_for_static"], |
| 305 | static_libs: ["static_dep_for_static"], |
| 306 | whole_static_libs: ["whole_static_lib_for_static"], |
| 307 | }, |
| 308 | shared: { |
| 309 | srcs: ["sharedonly.cpp"], |
| 310 | cflags: ["sharedflag"], |
| 311 | shared_libs: ["shared_dep_for_shared"], |
| 312 | static_libs: ["static_dep_for_shared"], |
| 313 | whole_static_libs: ["whole_static_lib_for_shared"], |
| 314 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 315 | include_build_directory: false, |
Jingwen Chen | 53681ef | 2021-04-29 08:15:13 +0000 | [diff] [blame] | 316 | } |
| 317 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 318 | cc_library_static { |
| 319 | name: "static_dep_for_shared", |
| 320 | bazel_module: { bp2build_available: false }, |
| 321 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 322 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 323 | cc_library_static { |
| 324 | name: "static_dep_for_static", |
| 325 | bazel_module: { bp2build_available: false }, |
| 326 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 327 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 328 | cc_library_static { |
| 329 | name: "static_dep_for_both", |
| 330 | bazel_module: { bp2build_available: false }, |
| 331 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 332 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 333 | cc_library_static { |
| 334 | name: "whole_static_lib_for_shared", |
| 335 | bazel_module: { bp2build_available: false }, |
| 336 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 337 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 338 | cc_library_static { |
| 339 | name: "whole_static_lib_for_static", |
| 340 | bazel_module: { bp2build_available: false }, |
| 341 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 342 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 343 | cc_library_static { |
| 344 | name: "whole_static_lib_for_both", |
| 345 | bazel_module: { bp2build_available: false }, |
| 346 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 347 | |
Liz Kammer | cc2c1ef | 2022-03-21 09:03:29 -0400 | [diff] [blame] | 348 | cc_library_static { |
| 349 | name: "whole_and_static_lib_for_both", |
| 350 | bazel_module: { bp2build_available: false }, |
| 351 | } |
| 352 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 353 | cc_library { |
| 354 | name: "shared_dep_for_shared", |
| 355 | bazel_module: { bp2build_available: false }, |
| 356 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 357 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 358 | cc_library { |
| 359 | name: "shared_dep_for_static", |
| 360 | bazel_module: { bp2build_available: false }, |
| 361 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 362 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 363 | cc_library { |
| 364 | name: "shared_dep_for_both", |
| 365 | bazel_module: { bp2build_available: false }, |
| 366 | } |
Jingwen Chen | 53681ef | 2021-04-29 08:15:13 +0000 | [diff] [blame] | 367 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 368 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 369 | MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 370 | "copts": `[ |
| 371 | "bothflag", |
| 372 | "staticflag", |
| 373 | ]`, |
| 374 | "implementation_deps": `[ |
| 375 | ":static_dep_for_both", |
| 376 | ":static_dep_for_static", |
| 377 | ]`, |
| 378 | "implementation_dynamic_deps": `[ |
| 379 | ":shared_dep_for_both", |
| 380 | ":shared_dep_for_static", |
| 381 | ]`, |
| 382 | "srcs": `[ |
| 383 | "both.cpp", |
| 384 | "staticonly.cpp", |
| 385 | ]`, |
| 386 | "whole_archive_deps": `[ |
| 387 | ":whole_static_lib_for_both", |
Liz Kammer | cc2c1ef | 2022-03-21 09:03:29 -0400 | [diff] [blame] | 388 | ":whole_and_static_lib_for_both", |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 389 | ":whole_static_lib_for_static", |
| 390 | ]`}), |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 391 | MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 392 | "copts": `[ |
| 393 | "bothflag", |
| 394 | "sharedflag", |
| 395 | ]`, |
| 396 | "implementation_deps": `[ |
| 397 | ":static_dep_for_both", |
| 398 | ":static_dep_for_shared", |
| 399 | ]`, |
| 400 | "implementation_dynamic_deps": `[ |
| 401 | ":shared_dep_for_both", |
| 402 | ":shared_dep_for_shared", |
| 403 | ]`, |
| 404 | "srcs": `[ |
| 405 | "both.cpp", |
| 406 | "sharedonly.cpp", |
| 407 | ]`, |
| 408 | "whole_archive_deps": `[ |
| 409 | ":whole_static_lib_for_both", |
Liz Kammer | cc2c1ef | 2022-03-21 09:03:29 -0400 | [diff] [blame] | 410 | ":whole_and_static_lib_for_both", |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 411 | ":whole_static_lib_for_shared", |
| 412 | ]`, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 413 | }), |
| 414 | }, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 415 | }) |
| 416 | } |
| 417 | |
Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 418 | func TestCcLibraryDeps(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 419 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 420 | Description: "cc_library shared/static props", |
| 421 | ModuleTypeUnderTest: "cc_library", |
| 422 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 423 | Filesystem: map[string]string{ |
Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 424 | "both.cpp": "", |
| 425 | "sharedonly.cpp": "", |
| 426 | "staticonly.cpp": "", |
| 427 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 428 | Blueprint: soongCcLibraryPreamble + ` |
Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 429 | cc_library { |
| 430 | name: "a", |
| 431 | srcs: ["both.cpp"], |
| 432 | cflags: ["bothflag"], |
| 433 | shared_libs: ["implementation_shared_dep_for_both", "shared_dep_for_both"], |
| 434 | export_shared_lib_headers: ["shared_dep_for_both"], |
| 435 | static_libs: ["implementation_static_dep_for_both", "static_dep_for_both"], |
| 436 | export_static_lib_headers: ["static_dep_for_both", "whole_static_dep_for_both"], |
| 437 | whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_both", "whole_static_dep_for_both"], |
| 438 | static: { |
| 439 | srcs: ["staticonly.cpp"], |
| 440 | cflags: ["staticflag"], |
| 441 | shared_libs: ["implementation_shared_dep_for_static", "shared_dep_for_static"], |
| 442 | export_shared_lib_headers: ["shared_dep_for_static"], |
| 443 | static_libs: ["implementation_static_dep_for_static", "static_dep_for_static"], |
| 444 | export_static_lib_headers: ["static_dep_for_static", "whole_static_dep_for_static"], |
| 445 | whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_static", "whole_static_dep_for_static"], |
| 446 | }, |
| 447 | shared: { |
| 448 | srcs: ["sharedonly.cpp"], |
| 449 | cflags: ["sharedflag"], |
| 450 | shared_libs: ["implementation_shared_dep_for_shared", "shared_dep_for_shared"], |
| 451 | export_shared_lib_headers: ["shared_dep_for_shared"], |
| 452 | static_libs: ["implementation_static_dep_for_shared", "static_dep_for_shared"], |
| 453 | export_static_lib_headers: ["static_dep_for_shared", "whole_static_dep_for_shared"], |
| 454 | whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_shared", "whole_static_dep_for_shared"], |
| 455 | }, |
| 456 | include_build_directory: false, |
| 457 | } |
| 458 | ` + simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_shared") + |
| 459 | simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_shared") + |
| 460 | simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_static") + |
| 461 | simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_static") + |
| 462 | simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_both") + |
| 463 | simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_both") + |
| 464 | simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_shared") + |
| 465 | simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_shared") + |
| 466 | simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_static") + |
| 467 | simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_static") + |
| 468 | simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_both") + |
| 469 | simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_both") + |
| 470 | simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_shared") + |
| 471 | simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_shared") + |
| 472 | simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_static") + |
| 473 | simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_static") + |
| 474 | simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_both") + |
| 475 | simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_both"), |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 476 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 477 | MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 478 | "copts": `[ |
| 479 | "bothflag", |
| 480 | "staticflag", |
| 481 | ]`, |
| 482 | "deps": `[ |
| 483 | ":static_dep_for_both", |
| 484 | ":static_dep_for_static", |
| 485 | ]`, |
| 486 | "dynamic_deps": `[ |
| 487 | ":shared_dep_for_both", |
| 488 | ":shared_dep_for_static", |
| 489 | ]`, |
| 490 | "implementation_deps": `[ |
| 491 | ":implementation_static_dep_for_both", |
| 492 | ":implementation_static_dep_for_static", |
| 493 | ]`, |
| 494 | "implementation_dynamic_deps": `[ |
| 495 | ":implementation_shared_dep_for_both", |
| 496 | ":implementation_shared_dep_for_static", |
| 497 | ]`, |
| 498 | "srcs": `[ |
| 499 | "both.cpp", |
| 500 | "staticonly.cpp", |
| 501 | ]`, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 502 | "whole_archive_deps": `[ |
Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 503 | ":not_explicitly_exported_whole_static_dep_for_both", |
| 504 | ":whole_static_dep_for_both", |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 505 | ":not_explicitly_exported_whole_static_dep_for_static", |
| 506 | ":whole_static_dep_for_static", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 507 | ]`, |
| 508 | }), |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 509 | MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 510 | "copts": `[ |
| 511 | "bothflag", |
| 512 | "sharedflag", |
| 513 | ]`, |
| 514 | "deps": `[ |
| 515 | ":static_dep_for_both", |
| 516 | ":static_dep_for_shared", |
| 517 | ]`, |
| 518 | "dynamic_deps": `[ |
| 519 | ":shared_dep_for_both", |
| 520 | ":shared_dep_for_shared", |
| 521 | ]`, |
| 522 | "implementation_deps": `[ |
| 523 | ":implementation_static_dep_for_both", |
| 524 | ":implementation_static_dep_for_shared", |
| 525 | ]`, |
| 526 | "implementation_dynamic_deps": `[ |
| 527 | ":implementation_shared_dep_for_both", |
| 528 | ":implementation_shared_dep_for_shared", |
| 529 | ]`, |
| 530 | "srcs": `[ |
| 531 | "both.cpp", |
| 532 | "sharedonly.cpp", |
| 533 | ]`, |
| 534 | "whole_archive_deps": `[ |
| 535 | ":not_explicitly_exported_whole_static_dep_for_both", |
| 536 | ":whole_static_dep_for_both", |
| 537 | ":not_explicitly_exported_whole_static_dep_for_shared", |
| 538 | ":whole_static_dep_for_shared", |
| 539 | ]`, |
| 540 | })}, |
| 541 | }, |
| 542 | ) |
Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 543 | } |
| 544 | |
Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 545 | func TestCcLibraryWholeStaticLibsAlwaysLink(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 546 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 547 | ModuleTypeUnderTest: "cc_library", |
| 548 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 549 | Dir: "foo/bar", |
| 550 | Filesystem: map[string]string{ |
Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 551 | "foo/bar/Android.bp": ` |
| 552 | cc_library { |
| 553 | name: "a", |
| 554 | whole_static_libs: ["whole_static_lib_for_both"], |
| 555 | static: { |
| 556 | whole_static_libs: ["whole_static_lib_for_static"], |
| 557 | }, |
| 558 | shared: { |
| 559 | whole_static_libs: ["whole_static_lib_for_shared"], |
| 560 | }, |
| 561 | bazel_module: { bp2build_available: true }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 562 | include_build_directory: false, |
Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 563 | } |
| 564 | |
| 565 | cc_prebuilt_library_static { name: "whole_static_lib_for_shared" } |
| 566 | |
| 567 | cc_prebuilt_library_static { name: "whole_static_lib_for_static" } |
| 568 | |
| 569 | cc_prebuilt_library_static { name: "whole_static_lib_for_both" } |
| 570 | `, |
| 571 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 572 | Blueprint: soongCcLibraryPreamble, |
| 573 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 574 | MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 575 | "whole_archive_deps": `[ |
| 576 | ":whole_static_lib_for_both_alwayslink", |
| 577 | ":whole_static_lib_for_static_alwayslink", |
| 578 | ]`, |
| 579 | }), |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 580 | MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 581 | "whole_archive_deps": `[ |
| 582 | ":whole_static_lib_for_both_alwayslink", |
| 583 | ":whole_static_lib_for_shared_alwayslink", |
| 584 | ]`, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 585 | }), |
| 586 | }, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 587 | }, |
| 588 | ) |
Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 589 | } |
| 590 | |
Jingwen Chen | bcf5304 | 2021-05-26 04:42:42 +0000 | [diff] [blame] | 591 | func TestCcLibrarySharedStaticPropsInArch(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 592 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 593 | Description: "cc_library shared/static props in arch", |
| 594 | ModuleTypeUnderTest: "cc_library", |
| 595 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 596 | Dir: "foo/bar", |
| 597 | Filesystem: map[string]string{ |
Jingwen Chen | bcf5304 | 2021-05-26 04:42:42 +0000 | [diff] [blame] | 598 | "foo/bar/arm.cpp": "", |
| 599 | "foo/bar/x86.cpp": "", |
| 600 | "foo/bar/sharedonly.cpp": "", |
| 601 | "foo/bar/staticonly.cpp": "", |
| 602 | "foo/bar/Android.bp": ` |
| 603 | cc_library { |
| 604 | name: "a", |
| 605 | arch: { |
| 606 | arm: { |
| 607 | shared: { |
| 608 | srcs: ["arm_shared.cpp"], |
| 609 | cflags: ["-DARM_SHARED"], |
| 610 | static_libs: ["arm_static_dep_for_shared"], |
| 611 | whole_static_libs: ["arm_whole_static_dep_for_shared"], |
| 612 | shared_libs: ["arm_shared_dep_for_shared"], |
| 613 | }, |
| 614 | }, |
| 615 | x86: { |
| 616 | static: { |
| 617 | srcs: ["x86_static.cpp"], |
| 618 | cflags: ["-DX86_STATIC"], |
| 619 | static_libs: ["x86_dep_for_static"], |
| 620 | }, |
| 621 | }, |
| 622 | }, |
| 623 | target: { |
| 624 | android: { |
| 625 | shared: { |
| 626 | srcs: ["android_shared.cpp"], |
| 627 | cflags: ["-DANDROID_SHARED"], |
| 628 | static_libs: ["android_dep_for_shared"], |
| 629 | }, |
| 630 | }, |
| 631 | android_arm: { |
| 632 | shared: { |
| 633 | cflags: ["-DANDROID_ARM_SHARED"], |
| 634 | }, |
| 635 | }, |
| 636 | }, |
| 637 | srcs: ["both.cpp"], |
| 638 | cflags: ["bothflag"], |
| 639 | static_libs: ["static_dep_for_both"], |
| 640 | static: { |
| 641 | srcs: ["staticonly.cpp"], |
| 642 | cflags: ["staticflag"], |
| 643 | static_libs: ["static_dep_for_static"], |
| 644 | }, |
| 645 | shared: { |
| 646 | srcs: ["sharedonly.cpp"], |
| 647 | cflags: ["sharedflag"], |
| 648 | static_libs: ["static_dep_for_shared"], |
| 649 | }, |
| 650 | bazel_module: { bp2build_available: true }, |
| 651 | } |
| 652 | |
| 653 | cc_library_static { name: "static_dep_for_shared" } |
| 654 | cc_library_static { name: "static_dep_for_static" } |
| 655 | cc_library_static { name: "static_dep_for_both" } |
| 656 | |
| 657 | cc_library_static { name: "arm_static_dep_for_shared" } |
| 658 | cc_library_static { name: "arm_whole_static_dep_for_shared" } |
| 659 | cc_library_static { name: "arm_shared_dep_for_shared" } |
| 660 | |
| 661 | cc_library_static { name: "x86_dep_for_static" } |
| 662 | |
| 663 | cc_library_static { name: "android_dep_for_shared" } |
| 664 | `, |
| 665 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 666 | Blueprint: soongCcLibraryPreamble, |
| 667 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 668 | MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 669 | "copts": `[ |
| 670 | "bothflag", |
| 671 | "staticflag", |
| 672 | ] + select({ |
| 673 | "//build/bazel/platforms/arch:x86": ["-DX86_STATIC"], |
| 674 | "//conditions:default": [], |
| 675 | })`, |
| 676 | "implementation_deps": `[ |
| 677 | ":static_dep_for_both", |
| 678 | ":static_dep_for_static", |
| 679 | ] + select({ |
| 680 | "//build/bazel/platforms/arch:x86": [":x86_dep_for_static"], |
| 681 | "//conditions:default": [], |
| 682 | })`, |
| 683 | "local_includes": `["."]`, |
| 684 | "srcs": `[ |
| 685 | "both.cpp", |
| 686 | "staticonly.cpp", |
| 687 | ] + select({ |
| 688 | "//build/bazel/platforms/arch:x86": ["x86_static.cpp"], |
| 689 | "//conditions:default": [], |
| 690 | })`, |
| 691 | }), |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 692 | MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 693 | "copts": `[ |
| 694 | "bothflag", |
| 695 | "sharedflag", |
| 696 | ] + select({ |
| 697 | "//build/bazel/platforms/arch:arm": ["-DARM_SHARED"], |
| 698 | "//conditions:default": [], |
| 699 | }) + select({ |
| 700 | "//build/bazel/platforms/os:android": ["-DANDROID_SHARED"], |
| 701 | "//conditions:default": [], |
| 702 | }) + select({ |
| 703 | "//build/bazel/platforms/os_arch:android_arm": ["-DANDROID_ARM_SHARED"], |
| 704 | "//conditions:default": [], |
| 705 | })`, |
| 706 | "implementation_deps": `[ |
| 707 | ":static_dep_for_both", |
| 708 | ":static_dep_for_shared", |
| 709 | ] + select({ |
| 710 | "//build/bazel/platforms/arch:arm": [":arm_static_dep_for_shared"], |
| 711 | "//conditions:default": [], |
| 712 | }) + select({ |
| 713 | "//build/bazel/platforms/os:android": [":android_dep_for_shared"], |
| 714 | "//conditions:default": [], |
| 715 | })`, |
| 716 | "implementation_dynamic_deps": `select({ |
| 717 | "//build/bazel/platforms/arch:arm": [":arm_shared_dep_for_shared"], |
| 718 | "//conditions:default": [], |
| 719 | })`, |
| 720 | "local_includes": `["."]`, |
| 721 | "srcs": `[ |
| 722 | "both.cpp", |
| 723 | "sharedonly.cpp", |
| 724 | ] + select({ |
| 725 | "//build/bazel/platforms/arch:arm": ["arm_shared.cpp"], |
| 726 | "//conditions:default": [], |
| 727 | }) + select({ |
| 728 | "//build/bazel/platforms/os:android": ["android_shared.cpp"], |
| 729 | "//conditions:default": [], |
| 730 | })`, |
| 731 | "whole_archive_deps": `select({ |
| 732 | "//build/bazel/platforms/arch:arm": [":arm_whole_static_dep_for_shared"], |
| 733 | "//conditions:default": [], |
| 734 | })`, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 735 | }), |
| 736 | }, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 737 | }, |
| 738 | ) |
Jingwen Chen | bcf5304 | 2021-05-26 04:42:42 +0000 | [diff] [blame] | 739 | } |
| 740 | |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 741 | func TestCcLibrarySharedStaticPropsWithMixedSources(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 742 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 743 | Description: "cc_library shared/static props with c/cpp/s mixed sources", |
| 744 | ModuleTypeUnderTest: "cc_library", |
| 745 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 746 | Dir: "foo/bar", |
| 747 | Filesystem: map[string]string{ |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 748 | "foo/bar/both_source.cpp": "", |
| 749 | "foo/bar/both_source.cc": "", |
| 750 | "foo/bar/both_source.c": "", |
| 751 | "foo/bar/both_source.s": "", |
| 752 | "foo/bar/both_source.S": "", |
| 753 | "foo/bar/shared_source.cpp": "", |
| 754 | "foo/bar/shared_source.cc": "", |
| 755 | "foo/bar/shared_source.c": "", |
| 756 | "foo/bar/shared_source.s": "", |
| 757 | "foo/bar/shared_source.S": "", |
| 758 | "foo/bar/static_source.cpp": "", |
| 759 | "foo/bar/static_source.cc": "", |
| 760 | "foo/bar/static_source.c": "", |
| 761 | "foo/bar/static_source.s": "", |
| 762 | "foo/bar/static_source.S": "", |
| 763 | "foo/bar/Android.bp": ` |
| 764 | cc_library { |
| 765 | name: "a", |
| 766 | srcs: [ |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 767 | "both_source.cpp", |
| 768 | "both_source.cc", |
| 769 | "both_source.c", |
| 770 | "both_source.s", |
| 771 | "both_source.S", |
Liz Kammer | 57e2e7a | 2021-09-20 12:55:02 -0400 | [diff] [blame] | 772 | ":both_filegroup", |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 773 | ], |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 774 | static: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 775 | srcs: [ |
| 776 | "static_source.cpp", |
| 777 | "static_source.cc", |
| 778 | "static_source.c", |
| 779 | "static_source.s", |
| 780 | "static_source.S", |
| 781 | ":static_filegroup", |
| 782 | ], |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 783 | }, |
| 784 | shared: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 785 | srcs: [ |
| 786 | "shared_source.cpp", |
| 787 | "shared_source.cc", |
| 788 | "shared_source.c", |
| 789 | "shared_source.s", |
| 790 | "shared_source.S", |
| 791 | ":shared_filegroup", |
| 792 | ], |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 793 | }, |
| 794 | bazel_module: { bp2build_available: true }, |
| 795 | } |
| 796 | |
| 797 | filegroup { |
| 798 | name: "both_filegroup", |
| 799 | srcs: [ |
| 800 | // Not relevant, handled by filegroup macro |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 801 | ], |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 802 | } |
| 803 | |
| 804 | filegroup { |
| 805 | name: "shared_filegroup", |
| 806 | srcs: [ |
| 807 | // Not relevant, handled by filegroup macro |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 808 | ], |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 809 | } |
| 810 | |
| 811 | filegroup { |
| 812 | name: "static_filegroup", |
| 813 | srcs: [ |
| 814 | // Not relevant, handled by filegroup macro |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 815 | ], |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 816 | } |
| 817 | `, |
| 818 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 819 | Blueprint: soongCcLibraryPreamble, |
| 820 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 821 | MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{ |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 822 | "local_includes": `["."]`, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 823 | "srcs": `[ |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 824 | "both_source.cpp", |
Liz Kammer | 57e2e7a | 2021-09-20 12:55:02 -0400 | [diff] [blame] | 825 | "both_source.cc", |
| 826 | ":both_filegroup_cpp_srcs", |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 827 | "static_source.cpp", |
| 828 | "static_source.cc", |
| 829 | ":static_filegroup_cpp_srcs", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 830 | ]`, |
| 831 | "srcs_as": `[ |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 832 | "both_source.s", |
| 833 | "both_source.S", |
| 834 | ":both_filegroup_as_srcs", |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 835 | "static_source.s", |
| 836 | "static_source.S", |
| 837 | ":static_filegroup_as_srcs", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 838 | ]`, |
| 839 | "srcs_c": `[ |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 840 | "both_source.c", |
| 841 | ":both_filegroup_c_srcs", |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 842 | "static_source.c", |
| 843 | ":static_filegroup_c_srcs", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 844 | ]`, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 845 | }), |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 846 | MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 847 | "local_includes": `["."]`, |
| 848 | "srcs": `[ |
| 849 | "both_source.cpp", |
| 850 | "both_source.cc", |
| 851 | ":both_filegroup_cpp_srcs", |
| 852 | "shared_source.cpp", |
| 853 | "shared_source.cc", |
| 854 | ":shared_filegroup_cpp_srcs", |
| 855 | ]`, |
| 856 | "srcs_as": `[ |
| 857 | "both_source.s", |
| 858 | "both_source.S", |
| 859 | ":both_filegroup_as_srcs", |
| 860 | "shared_source.s", |
| 861 | "shared_source.S", |
| 862 | ":shared_filegroup_as_srcs", |
| 863 | ]`, |
| 864 | "srcs_c": `[ |
| 865 | "both_source.c", |
| 866 | ":both_filegroup_c_srcs", |
| 867 | "shared_source.c", |
| 868 | ":shared_filegroup_c_srcs", |
| 869 | ]`, |
| 870 | })}}) |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 871 | } |
| 872 | |
Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 873 | func TestCcLibraryNonConfiguredVersionScriptAndDynamicList(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 874 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 875 | Description: "cc_library non-configured version script and dynamic list", |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 876 | ModuleTypeUnderTest: "cc_library", |
| 877 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 878 | Dir: "foo/bar", |
| 879 | Filesystem: map[string]string{ |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 880 | "foo/bar/Android.bp": ` |
Lukacs T. Berki | 1353e59 | 2021-04-30 15:35:09 +0200 | [diff] [blame] | 881 | cc_library { |
| 882 | name: "a", |
| 883 | srcs: ["a.cpp"], |
| 884 | version_script: "v.map", |
Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 885 | dynamic_list: "dynamic.list", |
Lukacs T. Berki | 1353e59 | 2021-04-30 15:35:09 +0200 | [diff] [blame] | 886 | bazel_module: { bp2build_available: true }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 887 | include_build_directory: false, |
Lukacs T. Berki | 1353e59 | 2021-04-30 15:35:09 +0200 | [diff] [blame] | 888 | } |
| 889 | `, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 890 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 891 | Blueprint: soongCcLibraryPreamble, |
| 892 | ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{ |
Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 893 | "additional_linker_inputs": `[ |
| 894 | "v.map", |
| 895 | "dynamic.list", |
| 896 | ]`, |
| 897 | "linkopts": `[ |
| 898 | "-Wl,--version-script,$(location v.map)", |
| 899 | "-Wl,--dynamic-list,$(location dynamic.list)", |
| 900 | ]`, |
| 901 | "srcs": `["a.cpp"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 902 | }), |
| 903 | }, |
| 904 | ) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 905 | } |
| 906 | |
Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 907 | func TestCcLibraryConfiguredVersionScriptAndDynamicList(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 908 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 909 | Description: "cc_library configured version script and dynamic list", |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 910 | ModuleTypeUnderTest: "cc_library", |
| 911 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 912 | Dir: "foo/bar", |
| 913 | Filesystem: map[string]string{ |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 914 | "foo/bar/Android.bp": ` |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 915 | cc_library { |
| 916 | name: "a", |
| 917 | srcs: ["a.cpp"], |
| 918 | arch: { |
| 919 | arm: { |
| 920 | version_script: "arm.map", |
Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 921 | dynamic_list: "dynamic_arm.list", |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 922 | }, |
| 923 | arm64: { |
| 924 | version_script: "arm64.map", |
Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 925 | dynamic_list: "dynamic_arm64.list", |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 926 | }, |
| 927 | }, |
Lukacs T. Berki | 56bb083 | 2021-05-12 12:36:45 +0200 | [diff] [blame] | 928 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 929 | bazel_module: { bp2build_available: true }, |
| 930 | include_build_directory: false, |
| 931 | } |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 932 | `, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 933 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 934 | Blueprint: soongCcLibraryPreamble, |
| 935 | ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 936 | "additional_linker_inputs": `select({ |
Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 937 | "//build/bazel/platforms/arch:arm": [ |
| 938 | "arm.map", |
| 939 | "dynamic_arm.list", |
| 940 | ], |
| 941 | "//build/bazel/platforms/arch:arm64": [ |
| 942 | "arm64.map", |
| 943 | "dynamic_arm64.list", |
| 944 | ], |
Liz Kammer | d287118 | 2021-10-04 13:54:37 -0400 | [diff] [blame] | 945 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 946 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 947 | "linkopts": `select({ |
Trevor Radcliffe | 82dd855 | 2022-10-03 20:27:27 +0000 | [diff] [blame] | 948 | "//build/bazel/platforms/arch:arm": [ |
| 949 | "-Wl,--version-script,$(location arm.map)", |
| 950 | "-Wl,--dynamic-list,$(location dynamic_arm.list)", |
| 951 | ], |
| 952 | "//build/bazel/platforms/arch:arm64": [ |
| 953 | "-Wl,--version-script,$(location arm64.map)", |
| 954 | "-Wl,--dynamic-list,$(location dynamic_arm64.list)", |
| 955 | ], |
Liz Kammer | d287118 | 2021-10-04 13:54:37 -0400 | [diff] [blame] | 956 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 957 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 958 | "srcs": `["a.cpp"]`, |
| 959 | }), |
| 960 | }, |
| 961 | ) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 962 | } |
| 963 | |
Trevor Radcliffe | ea6a45d | 2022-09-20 18:58:01 +0000 | [diff] [blame] | 964 | func TestCcLibraryLdflagsSplitBySpaceExceptSoongAdded(t *testing.T) { |
| 965 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 966 | Description: "ldflags are split by spaces except for the ones added by soong (version script and dynamic list)", |
| 967 | ModuleTypeUnderTest: "cc_library", |
| 968 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 969 | Filesystem: map[string]string{ |
| 970 | "version_script": "", |
| 971 | "dynamic.list": "", |
| 972 | }, |
| 973 | Blueprint: ` |
| 974 | cc_library { |
| 975 | name: "foo", |
| 976 | ldflags: [ |
| 977 | "--nospace_flag", |
| 978 | "-z spaceflag", |
| 979 | ], |
| 980 | version_script: "version_script", |
| 981 | dynamic_list: "dynamic.list", |
| 982 | include_build_directory: false, |
| 983 | } |
| 984 | `, |
| 985 | ExpectedBazelTargets: []string{ |
| 986 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}), |
| 987 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
| 988 | "additional_linker_inputs": `[ |
| 989 | "version_script", |
| 990 | "dynamic.list", |
| 991 | ]`, |
| 992 | "linkopts": `[ |
| 993 | "--nospace_flag", |
| 994 | "-z", |
| 995 | "spaceflag", |
| 996 | "-Wl,--version-script,$(location version_script)", |
| 997 | "-Wl,--dynamic-list,$(location dynamic.list)", |
| 998 | ]`, |
| 999 | }), |
| 1000 | }, |
| 1001 | }) |
| 1002 | } |
| 1003 | |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 1004 | func TestCcLibrarySharedLibs(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1005 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1006 | Description: "cc_library shared_libs", |
| 1007 | ModuleTypeUnderTest: "cc_library", |
| 1008 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1009 | Blueprint: soongCcLibraryPreamble + ` |
Rupert Shuttleworth | c50fa8d | 2021-05-06 02:40:33 -0400 | [diff] [blame] | 1010 | cc_library { |
| 1011 | name: "mylib", |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1012 | bazel_module: { bp2build_available: false }, |
Rupert Shuttleworth | c50fa8d | 2021-05-06 02:40:33 -0400 | [diff] [blame] | 1013 | } |
| 1014 | |
| 1015 | cc_library { |
| 1016 | name: "a", |
| 1017 | shared_libs: ["mylib",], |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1018 | include_build_directory: false, |
Rupert Shuttleworth | c50fa8d | 2021-05-06 02:40:33 -0400 | [diff] [blame] | 1019 | } |
| 1020 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1021 | ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1022 | "implementation_dynamic_deps": `[":mylib"]`, |
| 1023 | }), |
| 1024 | }, |
| 1025 | ) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 1026 | } |
| 1027 | |
Liz Kammer | 0eae52e | 2021-10-06 10:32:26 -0400 | [diff] [blame] | 1028 | func TestCcLibraryFeatures(t *testing.T) { |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1029 | expected_targets := []string{} |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1030 | expected_targets = append(expected_targets, makeCcLibraryTargets("a", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1031 | "features": `[ |
| 1032 | "disable_pack_relocations", |
| 1033 | "-no_undefined_symbols", |
| 1034 | ]`, |
Yu Liu | f01a0f0 | 2022-12-07 15:45:30 -0800 | [diff] [blame] | 1035 | "native_coverage": `False`, |
| 1036 | "srcs": `["a.cpp"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1037 | })...) |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1038 | expected_targets = append(expected_targets, makeCcLibraryTargets("b", AttrNameToString{ |
Yu Liu | f01a0f0 | 2022-12-07 15:45:30 -0800 | [diff] [blame] | 1039 | "features": `select({ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1040 | "//build/bazel/platforms/arch:x86_64": [ |
| 1041 | "disable_pack_relocations", |
| 1042 | "-no_undefined_symbols", |
| 1043 | ], |
| 1044 | "//conditions:default": [], |
| 1045 | })`, |
Yu Liu | f01a0f0 | 2022-12-07 15:45:30 -0800 | [diff] [blame] | 1046 | "native_coverage": `False`, |
| 1047 | "srcs": `["b.cpp"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1048 | })...) |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1049 | expected_targets = append(expected_targets, makeCcLibraryTargets("c", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1050 | "features": `select({ |
| 1051 | "//build/bazel/platforms/os:darwin": [ |
| 1052 | "disable_pack_relocations", |
| 1053 | "-no_undefined_symbols", |
| 1054 | ], |
| 1055 | "//conditions:default": [], |
| 1056 | })`, |
| 1057 | "srcs": `["c.cpp"]`, |
| 1058 | })...) |
| 1059 | |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1060 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1061 | Description: "cc_library pack_relocations test", |
| 1062 | ModuleTypeUnderTest: "cc_library", |
| 1063 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1064 | Blueprint: soongCcLibraryPreamble + ` |
Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1065 | cc_library { |
| 1066 | name: "a", |
| 1067 | srcs: ["a.cpp"], |
| 1068 | pack_relocations: false, |
Liz Kammer | 0eae52e | 2021-10-06 10:32:26 -0400 | [diff] [blame] | 1069 | allow_undefined_symbols: true, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1070 | include_build_directory: false, |
Yu Liu | 8d82ac5 | 2022-05-17 15:13:28 -0700 | [diff] [blame] | 1071 | native_coverage: false, |
Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1072 | } |
| 1073 | |
| 1074 | cc_library { |
| 1075 | name: "b", |
| 1076 | srcs: ["b.cpp"], |
| 1077 | arch: { |
| 1078 | x86_64: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1079 | pack_relocations: false, |
Liz Kammer | 0eae52e | 2021-10-06 10:32:26 -0400 | [diff] [blame] | 1080 | allow_undefined_symbols: true, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1081 | }, |
Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1082 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1083 | include_build_directory: false, |
Yu Liu | 8d82ac5 | 2022-05-17 15:13:28 -0700 | [diff] [blame] | 1084 | native_coverage: false, |
Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1085 | } |
| 1086 | |
| 1087 | cc_library { |
| 1088 | name: "c", |
| 1089 | srcs: ["c.cpp"], |
| 1090 | target: { |
| 1091 | darwin: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1092 | pack_relocations: false, |
Liz Kammer | 0eae52e | 2021-10-06 10:32:26 -0400 | [diff] [blame] | 1093 | allow_undefined_symbols: true, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1094 | }, |
Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1095 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1096 | include_build_directory: false, |
Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1097 | }`, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1098 | ExpectedBazelTargets: expected_targets, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 1099 | }) |
| 1100 | } |
| 1101 | |
| 1102 | func TestCcLibrarySpacesInCopts(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1103 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1104 | Description: "cc_library spaces in copts", |
| 1105 | ModuleTypeUnderTest: "cc_library", |
| 1106 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1107 | Blueprint: soongCcLibraryPreamble + ` |
Jingwen Chen | 3950cd6 | 2021-05-12 04:33:00 +0000 | [diff] [blame] | 1108 | cc_library { |
| 1109 | name: "a", |
| 1110 | cflags: ["-include header.h",], |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1111 | include_build_directory: false, |
Jingwen Chen | 3950cd6 | 2021-05-12 04:33:00 +0000 | [diff] [blame] | 1112 | } |
| 1113 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1114 | ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1115 | "copts": `[ |
Jingwen Chen | 3950cd6 | 2021-05-12 04:33:00 +0000 | [diff] [blame] | 1116 | "-include", |
| 1117 | "header.h", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1118 | ]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1119 | }), |
| 1120 | }, |
| 1121 | ) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 1122 | } |
| 1123 | |
| 1124 | func TestCcLibraryCppFlagsGoesIntoCopts(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1125 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1126 | Description: "cc_library cppflags usage", |
| 1127 | ModuleTypeUnderTest: "cc_library", |
| 1128 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1129 | Blueprint: soongCcLibraryPreamble + `cc_library { |
Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1130 | name: "a", |
| 1131 | srcs: ["a.cpp"], |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1132 | cflags: ["-Wall"], |
Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1133 | cppflags: [ |
| 1134 | "-fsigned-char", |
| 1135 | "-pedantic", |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1136 | ], |
Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1137 | arch: { |
| 1138 | arm64: { |
| 1139 | cppflags: ["-DARM64=1"], |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1140 | }, |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1141 | }, |
Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1142 | target: { |
| 1143 | android: { |
| 1144 | cppflags: ["-DANDROID=1"], |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1145 | }, |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1146 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1147 | include_build_directory: false, |
Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1148 | } |
| 1149 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1150 | ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1151 | "copts": `["-Wall"]`, |
| 1152 | "cppflags": `[ |
Chris Parsons | 990c4f4 | 2021-05-25 12:10:58 -0400 | [diff] [blame] | 1153 | "-fsigned-char", |
| 1154 | "-pedantic", |
Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1155 | ] + select({ |
| 1156 | "//build/bazel/platforms/arch:arm64": ["-DARM64=1"], |
| 1157 | "//conditions:default": [], |
| 1158 | }) + select({ |
| 1159 | "//build/bazel/platforms/os:android": ["-DANDROID=1"], |
| 1160 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1161 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1162 | "srcs": `["a.cpp"]`, |
| 1163 | }), |
| 1164 | }, |
| 1165 | ) |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 1166 | } |
Rupert Shuttleworth | 22cd2eb | 2021-05-27 02:15:54 -0400 | [diff] [blame] | 1167 | |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1168 | func TestCcLibraryExcludeLibs(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1169 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1170 | ModuleTypeUnderTest: "cc_library", |
| 1171 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1172 | Filesystem: map[string]string{}, |
| 1173 | Blueprint: soongCcLibraryStaticPreamble + ` |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1174 | cc_library { |
| 1175 | name: "foo_static", |
| 1176 | srcs: ["common.c"], |
| 1177 | whole_static_libs: [ |
| 1178 | "arm_whole_static_lib_excludes", |
| 1179 | "malloc_not_svelte_whole_static_lib_excludes" |
| 1180 | ], |
| 1181 | static_libs: [ |
| 1182 | "arm_static_lib_excludes", |
| 1183 | "malloc_not_svelte_static_lib_excludes" |
| 1184 | ], |
| 1185 | shared_libs: [ |
| 1186 | "arm_shared_lib_excludes", |
| 1187 | ], |
| 1188 | arch: { |
| 1189 | arm: { |
| 1190 | exclude_shared_libs: [ |
| 1191 | "arm_shared_lib_excludes", |
| 1192 | ], |
| 1193 | exclude_static_libs: [ |
| 1194 | "arm_static_lib_excludes", |
| 1195 | "arm_whole_static_lib_excludes", |
| 1196 | ], |
| 1197 | }, |
| 1198 | }, |
| 1199 | product_variables: { |
| 1200 | malloc_not_svelte: { |
| 1201 | shared_libs: ["malloc_not_svelte_shared_lib"], |
| 1202 | whole_static_libs: ["malloc_not_svelte_whole_static_lib"], |
| 1203 | exclude_static_libs: [ |
| 1204 | "malloc_not_svelte_static_lib_excludes", |
| 1205 | "malloc_not_svelte_whole_static_lib_excludes", |
| 1206 | ], |
| 1207 | }, |
| 1208 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1209 | include_build_directory: false, |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1210 | } |
| 1211 | |
| 1212 | cc_library { |
| 1213 | name: "arm_whole_static_lib_excludes", |
| 1214 | bazel_module: { bp2build_available: false }, |
| 1215 | } |
| 1216 | |
| 1217 | cc_library { |
| 1218 | name: "malloc_not_svelte_whole_static_lib", |
| 1219 | bazel_module: { bp2build_available: false }, |
| 1220 | } |
| 1221 | |
| 1222 | cc_library { |
| 1223 | name: "malloc_not_svelte_whole_static_lib_excludes", |
| 1224 | bazel_module: { bp2build_available: false }, |
| 1225 | } |
| 1226 | |
| 1227 | cc_library { |
| 1228 | name: "arm_static_lib_excludes", |
| 1229 | bazel_module: { bp2build_available: false }, |
| 1230 | } |
| 1231 | |
| 1232 | cc_library { |
| 1233 | name: "malloc_not_svelte_static_lib_excludes", |
| 1234 | bazel_module: { bp2build_available: false }, |
| 1235 | } |
| 1236 | |
| 1237 | cc_library { |
| 1238 | name: "arm_shared_lib_excludes", |
| 1239 | bazel_module: { bp2build_available: false }, |
| 1240 | } |
| 1241 | |
| 1242 | cc_library { |
| 1243 | name: "malloc_not_svelte_shared_lib", |
| 1244 | bazel_module: { bp2build_available: false }, |
| 1245 | } |
| 1246 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1247 | ExpectedBazelTargets: makeCcLibraryTargets("foo_static", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1248 | "implementation_deps": `select({ |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1249 | "//build/bazel/platforms/arch:arm": [], |
Chris Parsons | 953b356 | 2021-09-20 15:14:39 -0400 | [diff] [blame] | 1250 | "//conditions:default": [":arm_static_lib_excludes_bp2build_cc_library_static"], |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1251 | }) + select({ |
| 1252 | "//build/bazel/product_variables:malloc_not_svelte": [], |
Chris Parsons | 953b356 | 2021-09-20 15:14:39 -0400 | [diff] [blame] | 1253 | "//conditions:default": [":malloc_not_svelte_static_lib_excludes_bp2build_cc_library_static"], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1254 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1255 | "implementation_dynamic_deps": `select({ |
Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 1256 | "//build/bazel/platforms/arch:arm": [], |
| 1257 | "//conditions:default": [":arm_shared_lib_excludes"], |
| 1258 | }) + select({ |
| 1259 | "//build/bazel/product_variables:malloc_not_svelte": [":malloc_not_svelte_shared_lib"], |
| 1260 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1261 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1262 | "srcs_c": `["common.c"]`, |
| 1263 | "whole_archive_deps": `select({ |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1264 | "//build/bazel/platforms/arch:arm": [], |
Chris Parsons | 953b356 | 2021-09-20 15:14:39 -0400 | [diff] [blame] | 1265 | "//conditions:default": [":arm_whole_static_lib_excludes_bp2build_cc_library_static"], |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1266 | }) + select({ |
Chris Parsons | 953b356 | 2021-09-20 15:14:39 -0400 | [diff] [blame] | 1267 | "//build/bazel/product_variables:malloc_not_svelte": [":malloc_not_svelte_whole_static_lib_bp2build_cc_library_static"], |
| 1268 | "//conditions:default": [":malloc_not_svelte_whole_static_lib_excludes_bp2build_cc_library_static"], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1269 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1270 | }), |
| 1271 | }, |
| 1272 | ) |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1273 | } |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1274 | |
Zi Wang | 0a8a129 | 2022-08-30 06:27:01 +0000 | [diff] [blame] | 1275 | func TestCcLibraryProductVariablesHeaderLibs(t *testing.T) { |
| 1276 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1277 | ModuleTypeUnderTest: "cc_library", |
| 1278 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1279 | Filesystem: map[string]string{}, |
| 1280 | Blueprint: soongCcLibraryStaticPreamble + ` |
| 1281 | cc_library { |
| 1282 | name: "foo_static", |
| 1283 | srcs: ["common.c"], |
| 1284 | product_variables: { |
| 1285 | malloc_not_svelte: { |
| 1286 | header_libs: ["malloc_not_svelte_header_lib"], |
| 1287 | }, |
| 1288 | }, |
| 1289 | include_build_directory: false, |
| 1290 | } |
| 1291 | |
| 1292 | cc_library { |
| 1293 | name: "malloc_not_svelte_header_lib", |
| 1294 | bazel_module: { bp2build_available: false }, |
| 1295 | } |
| 1296 | `, |
| 1297 | ExpectedBazelTargets: makeCcLibraryTargets("foo_static", AttrNameToString{ |
| 1298 | "implementation_deps": `select({ |
| 1299 | "//build/bazel/product_variables:malloc_not_svelte": [":malloc_not_svelte_header_lib"], |
| 1300 | "//conditions:default": [], |
| 1301 | })`, |
| 1302 | "srcs_c": `["common.c"]`, |
| 1303 | "target_compatible_with": `["//build/bazel/platforms/os:android"]`, |
| 1304 | }), |
| 1305 | }, |
| 1306 | ) |
| 1307 | } |
| 1308 | |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1309 | func TestCCLibraryNoCrtTrue(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1310 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1311 | Description: "cc_library - nocrt: true emits attribute", |
| 1312 | ModuleTypeUnderTest: "cc_library", |
| 1313 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1314 | Filesystem: map[string]string{ |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1315 | "impl.cpp": "", |
| 1316 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1317 | Blueprint: soongCcLibraryPreamble + ` |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1318 | cc_library { |
| 1319 | name: "foo-lib", |
| 1320 | srcs: ["impl.cpp"], |
| 1321 | nocrt: true, |
| 1322 | include_build_directory: false, |
| 1323 | } |
| 1324 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1325 | ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1326 | "link_crt": `False`, |
| 1327 | "srcs": `["impl.cpp"]`, |
| 1328 | }), |
| 1329 | }, |
| 1330 | ) |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1331 | } |
| 1332 | |
| 1333 | func TestCCLibraryNoCrtFalse(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1334 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1335 | Description: "cc_library - nocrt: false - does not emit attribute", |
| 1336 | ModuleTypeUnderTest: "cc_library", |
| 1337 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1338 | Filesystem: map[string]string{ |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1339 | "impl.cpp": "", |
| 1340 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1341 | Blueprint: soongCcLibraryPreamble + ` |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1342 | cc_library { |
| 1343 | name: "foo-lib", |
| 1344 | srcs: ["impl.cpp"], |
| 1345 | nocrt: false, |
| 1346 | include_build_directory: false, |
| 1347 | } |
| 1348 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1349 | ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1350 | "srcs": `["impl.cpp"]`, |
| 1351 | }), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1352 | }) |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1353 | } |
| 1354 | |
| 1355 | func TestCCLibraryNoCrtArchVariant(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1356 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1357 | Description: "cc_library - nocrt in select", |
| 1358 | ModuleTypeUnderTest: "cc_library", |
| 1359 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1360 | Filesystem: map[string]string{ |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1361 | "impl.cpp": "", |
| 1362 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1363 | Blueprint: soongCcLibraryPreamble + ` |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1364 | cc_library { |
| 1365 | name: "foo-lib", |
| 1366 | srcs: ["impl.cpp"], |
| 1367 | arch: { |
| 1368 | arm: { |
| 1369 | nocrt: true, |
| 1370 | }, |
| 1371 | x86: { |
| 1372 | nocrt: false, |
| 1373 | }, |
| 1374 | }, |
| 1375 | include_build_directory: false, |
| 1376 | } |
| 1377 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1378 | ExpectedErr: fmt.Errorf("module \"foo-lib\": nocrt is not supported for arch variants"), |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1379 | }) |
| 1380 | } |
| 1381 | |
| 1382 | func TestCCLibraryNoLibCrtTrue(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1383 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1384 | ModuleTypeUnderTest: "cc_library", |
| 1385 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1386 | Filesystem: map[string]string{ |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1387 | "impl.cpp": "", |
| 1388 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1389 | Blueprint: soongCcLibraryPreamble + ` |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1390 | cc_library { |
| 1391 | name: "foo-lib", |
| 1392 | srcs: ["impl.cpp"], |
| 1393 | no_libcrt: true, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1394 | include_build_directory: false, |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1395 | } |
| 1396 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1397 | ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1398 | "srcs": `["impl.cpp"]`, |
| 1399 | "use_libcrt": `False`, |
| 1400 | }), |
| 1401 | }) |
| 1402 | } |
| 1403 | |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1404 | func makeCcLibraryTargets(name string, attrs AttrNameToString) []string { |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1405 | STATIC_ONLY_ATTRS := map[string]bool{} |
| 1406 | SHARED_ONLY_ATTRS := map[string]bool{ |
| 1407 | "link_crt": true, |
| 1408 | "additional_linker_inputs": true, |
| 1409 | "linkopts": true, |
| 1410 | "strip": true, |
Yu Liu | 75be7b9 | 2022-02-01 09:54:09 -0800 | [diff] [blame] | 1411 | "inject_bssl_hash": true, |
Yu Liu | 56ccb1a | 2022-11-12 10:47:07 -0800 | [diff] [blame] | 1412 | "stubs_symbol_file": true, |
Liz Kammer | baced71 | 2022-09-16 09:01:29 -0400 | [diff] [blame] | 1413 | "use_version_lib": true, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1414 | } |
Wei Li | 81852ca | 2022-07-27 00:22:06 -0700 | [diff] [blame] | 1415 | |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1416 | sharedAttrs := AttrNameToString{} |
| 1417 | staticAttrs := AttrNameToString{} |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1418 | for key, val := range attrs { |
| 1419 | if _, staticOnly := STATIC_ONLY_ATTRS[key]; !staticOnly { |
| 1420 | sharedAttrs[key] = val |
| 1421 | } |
| 1422 | if _, sharedOnly := SHARED_ONLY_ATTRS[key]; !sharedOnly { |
| 1423 | staticAttrs[key] = val |
| 1424 | } |
| 1425 | } |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 1426 | sharedTarget := MakeBazelTarget("cc_library_shared", name, sharedAttrs) |
| 1427 | staticTarget := MakeBazelTarget("cc_library_static", name+"_bp2build_cc_library_static", staticAttrs) |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1428 | |
| 1429 | return []string{staticTarget, sharedTarget} |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1430 | } |
| 1431 | |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1432 | func TestCCLibraryNoLibCrtFalse(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1433 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1434 | ModuleTypeUnderTest: "cc_library", |
| 1435 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1436 | Filesystem: map[string]string{ |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1437 | "impl.cpp": "", |
| 1438 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1439 | Blueprint: soongCcLibraryPreamble + ` |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1440 | cc_library { |
| 1441 | name: "foo-lib", |
| 1442 | srcs: ["impl.cpp"], |
| 1443 | no_libcrt: false, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1444 | include_build_directory: false, |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1445 | } |
| 1446 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1447 | ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1448 | "srcs": `["impl.cpp"]`, |
| 1449 | "use_libcrt": `True`, |
| 1450 | }), |
| 1451 | }) |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1452 | } |
| 1453 | |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1454 | func TestCCLibraryNoLibCrtArchVariant(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1455 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1456 | ModuleTypeUnderTest: "cc_library", |
| 1457 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1458 | Filesystem: map[string]string{ |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1459 | "impl.cpp": "", |
| 1460 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1461 | Blueprint: soongCcLibraryPreamble + ` |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1462 | cc_library { |
| 1463 | name: "foo-lib", |
| 1464 | srcs: ["impl.cpp"], |
| 1465 | arch: { |
| 1466 | arm: { |
| 1467 | no_libcrt: true, |
| 1468 | }, |
| 1469 | x86: { |
| 1470 | no_libcrt: true, |
| 1471 | }, |
| 1472 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1473 | include_build_directory: false, |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1474 | } |
| 1475 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1476 | ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1477 | "srcs": `["impl.cpp"]`, |
| 1478 | "use_libcrt": `select({ |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1479 | "//build/bazel/platforms/arch:arm": False, |
| 1480 | "//build/bazel/platforms/arch:x86": False, |
| 1481 | "//conditions:default": None, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1482 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1483 | }), |
| 1484 | }) |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1485 | } |
| 1486 | |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 1487 | func TestCCLibraryNoLibCrtArchAndTargetVariant(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1488 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1489 | ModuleTypeUnderTest: "cc_library", |
| 1490 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1491 | Filesystem: map[string]string{ |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 1492 | "impl.cpp": "", |
| 1493 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1494 | Blueprint: soongCcLibraryPreamble + ` |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 1495 | cc_library { |
| 1496 | name: "foo-lib", |
| 1497 | srcs: ["impl.cpp"], |
| 1498 | arch: { |
| 1499 | arm: { |
| 1500 | no_libcrt: true, |
| 1501 | }, |
| 1502 | x86: { |
| 1503 | no_libcrt: true, |
| 1504 | }, |
| 1505 | }, |
| 1506 | target: { |
| 1507 | darwin: { |
| 1508 | no_libcrt: true, |
| 1509 | } |
| 1510 | }, |
| 1511 | include_build_directory: false, |
| 1512 | } |
| 1513 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1514 | ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{ |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 1515 | "srcs": `["impl.cpp"]`, |
| 1516 | "use_libcrt": `select({ |
| 1517 | "//build/bazel/platforms/os_arch:android_arm": False, |
| 1518 | "//build/bazel/platforms/os_arch:android_x86": False, |
| 1519 | "//build/bazel/platforms/os_arch:darwin_arm64": False, |
| 1520 | "//build/bazel/platforms/os_arch:darwin_x86_64": False, |
| 1521 | "//build/bazel/platforms/os_arch:linux_glibc_x86": False, |
| 1522 | "//build/bazel/platforms/os_arch:linux_musl_x86": False, |
| 1523 | "//build/bazel/platforms/os_arch:windows_x86": False, |
| 1524 | "//conditions:default": None, |
| 1525 | })`, |
| 1526 | }), |
| 1527 | }) |
| 1528 | } |
| 1529 | |
| 1530 | func TestCCLibraryNoLibCrtArchAndTargetVariantConflict(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1531 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1532 | ModuleTypeUnderTest: "cc_library", |
| 1533 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1534 | Filesystem: map[string]string{ |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 1535 | "impl.cpp": "", |
| 1536 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1537 | Blueprint: soongCcLibraryPreamble + ` |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 1538 | cc_library { |
| 1539 | name: "foo-lib", |
| 1540 | srcs: ["impl.cpp"], |
| 1541 | arch: { |
| 1542 | arm: { |
| 1543 | no_libcrt: true, |
| 1544 | }, |
| 1545 | // This is expected to override the value for darwin_x86_64. |
| 1546 | x86_64: { |
| 1547 | no_libcrt: true, |
| 1548 | }, |
| 1549 | }, |
| 1550 | target: { |
| 1551 | darwin: { |
| 1552 | no_libcrt: false, |
| 1553 | } |
| 1554 | }, |
| 1555 | include_build_directory: false, |
| 1556 | } |
| 1557 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1558 | ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{ |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 1559 | "srcs": `["impl.cpp"]`, |
| 1560 | "use_libcrt": `select({ |
| 1561 | "//build/bazel/platforms/os_arch:android_arm": False, |
| 1562 | "//build/bazel/platforms/os_arch:android_x86_64": False, |
| 1563 | "//build/bazel/platforms/os_arch:darwin_arm64": True, |
| 1564 | "//build/bazel/platforms/os_arch:darwin_x86_64": False, |
| 1565 | "//build/bazel/platforms/os_arch:linux_bionic_x86_64": False, |
| 1566 | "//build/bazel/platforms/os_arch:linux_glibc_x86_64": False, |
| 1567 | "//build/bazel/platforms/os_arch:linux_musl_x86_64": False, |
| 1568 | "//build/bazel/platforms/os_arch:windows_x86_64": False, |
| 1569 | "//conditions:default": None, |
| 1570 | })`, |
| 1571 | }), |
| 1572 | }) |
| 1573 | } |
| 1574 | |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1575 | func TestCcLibraryStrip(t *testing.T) { |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1576 | expectedTargets := []string{} |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1577 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("all", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1578 | "strip": `{ |
| 1579 | "all": True, |
| 1580 | }`, |
| 1581 | })...) |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1582 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1583 | "strip": `{ |
| 1584 | "keep_symbols": True, |
| 1585 | }`, |
| 1586 | })...) |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1587 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols_and_debug_frame", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1588 | "strip": `{ |
| 1589 | "keep_symbols_and_debug_frame": True, |
| 1590 | }`, |
| 1591 | })...) |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1592 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols_list", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1593 | "strip": `{ |
| 1594 | "keep_symbols_list": ["symbol"], |
| 1595 | }`, |
| 1596 | })...) |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1597 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("none", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1598 | "strip": `{ |
| 1599 | "none": True, |
| 1600 | }`, |
| 1601 | })...) |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1602 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("nothing", AttrNameToString{})...) |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1603 | |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1604 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1605 | Description: "cc_library strip args", |
| 1606 | ModuleTypeUnderTest: "cc_library", |
| 1607 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1608 | Blueprint: soongCcLibraryPreamble + ` |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1609 | cc_library { |
| 1610 | name: "nothing", |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1611 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1612 | } |
| 1613 | cc_library { |
| 1614 | name: "keep_symbols", |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1615 | strip: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1616 | keep_symbols: true, |
| 1617 | }, |
| 1618 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1619 | } |
| 1620 | cc_library { |
| 1621 | name: "keep_symbols_and_debug_frame", |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1622 | strip: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1623 | keep_symbols_and_debug_frame: true, |
| 1624 | }, |
| 1625 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1626 | } |
| 1627 | cc_library { |
| 1628 | name: "none", |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1629 | strip: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1630 | none: true, |
| 1631 | }, |
| 1632 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1633 | } |
| 1634 | cc_library { |
| 1635 | name: "keep_symbols_list", |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1636 | strip: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1637 | keep_symbols_list: ["symbol"], |
| 1638 | }, |
| 1639 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1640 | } |
| 1641 | cc_library { |
| 1642 | name: "all", |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1643 | strip: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1644 | all: true, |
| 1645 | }, |
| 1646 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1647 | } |
| 1648 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1649 | ExpectedBazelTargets: expectedTargets, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1650 | }) |
| 1651 | } |
| 1652 | |
| 1653 | func TestCcLibraryStripWithArch(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1654 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1655 | Description: "cc_library strip args", |
| 1656 | ModuleTypeUnderTest: "cc_library", |
| 1657 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1658 | Blueprint: soongCcLibraryPreamble + ` |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1659 | cc_library { |
| 1660 | name: "multi-arch", |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1661 | target: { |
| 1662 | darwin: { |
| 1663 | strip: { |
| 1664 | keep_symbols_list: ["foo", "bar"] |
| 1665 | } |
| 1666 | }, |
| 1667 | }, |
| 1668 | arch: { |
| 1669 | arm: { |
| 1670 | strip: { |
| 1671 | keep_symbols_and_debug_frame: true, |
| 1672 | }, |
| 1673 | }, |
| 1674 | arm64: { |
| 1675 | strip: { |
| 1676 | keep_symbols: true, |
| 1677 | }, |
| 1678 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1679 | }, |
| 1680 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1681 | } |
| 1682 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1683 | ExpectedBazelTargets: makeCcLibraryTargets("multi-arch", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1684 | "strip": `{ |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1685 | "keep_symbols": select({ |
| 1686 | "//build/bazel/platforms/arch:arm64": True, |
| 1687 | "//conditions:default": None, |
| 1688 | }), |
| 1689 | "keep_symbols_and_debug_frame": select({ |
| 1690 | "//build/bazel/platforms/arch:arm": True, |
| 1691 | "//conditions:default": None, |
| 1692 | }), |
| 1693 | "keep_symbols_list": select({ |
| 1694 | "//build/bazel/platforms/os:darwin": [ |
| 1695 | "foo", |
| 1696 | "bar", |
| 1697 | ], |
| 1698 | "//conditions:default": [], |
| 1699 | }), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1700 | }`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1701 | }), |
| 1702 | }, |
| 1703 | ) |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1704 | } |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1705 | |
| 1706 | func TestCcLibrary_SystemSharedLibsRootEmpty(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1707 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1708 | Description: "cc_library system_shared_libs empty at root", |
| 1709 | ModuleTypeUnderTest: "cc_library", |
| 1710 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1711 | Blueprint: soongCcLibraryPreamble + ` |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1712 | cc_library { |
| 1713 | name: "root_empty", |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1714 | system_shared_libs: [], |
| 1715 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1716 | } |
| 1717 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1718 | ExpectedBazelTargets: makeCcLibraryTargets("root_empty", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1719 | "system_dynamic_deps": `[]`, |
| 1720 | }), |
| 1721 | }, |
| 1722 | ) |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1723 | } |
| 1724 | |
| 1725 | func TestCcLibrary_SystemSharedLibsStaticEmpty(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1726 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1727 | Description: "cc_library system_shared_libs empty for static variant", |
| 1728 | ModuleTypeUnderTest: "cc_library", |
| 1729 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1730 | Blueprint: soongCcLibraryPreamble + ` |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1731 | cc_library { |
| 1732 | name: "static_empty", |
| 1733 | static: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1734 | system_shared_libs: [], |
| 1735 | }, |
| 1736 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1737 | } |
| 1738 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1739 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 1740 | MakeBazelTarget("cc_library_static", "static_empty_bp2build_cc_library_static", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1741 | "system_dynamic_deps": "[]", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1742 | }), |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 1743 | MakeBazelTarget("cc_library_shared", "static_empty", AttrNameToString{}), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1744 | }, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1745 | }) |
| 1746 | } |
| 1747 | |
| 1748 | func TestCcLibrary_SystemSharedLibsSharedEmpty(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1749 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1750 | Description: "cc_library system_shared_libs empty for shared variant", |
| 1751 | ModuleTypeUnderTest: "cc_library", |
| 1752 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1753 | Blueprint: soongCcLibraryPreamble + ` |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1754 | cc_library { |
| 1755 | name: "shared_empty", |
| 1756 | shared: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1757 | system_shared_libs: [], |
| 1758 | }, |
| 1759 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1760 | } |
| 1761 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1762 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 1763 | MakeBazelTarget("cc_library_static", "shared_empty_bp2build_cc_library_static", AttrNameToString{}), |
| 1764 | MakeBazelTarget("cc_library_shared", "shared_empty", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1765 | "system_dynamic_deps": "[]", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1766 | }), |
| 1767 | }, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1768 | }) |
| 1769 | } |
| 1770 | |
| 1771 | func TestCcLibrary_SystemSharedLibsSharedBionicEmpty(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1772 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1773 | Description: "cc_library system_shared_libs empty for shared, bionic variant", |
| 1774 | ModuleTypeUnderTest: "cc_library", |
| 1775 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1776 | Blueprint: soongCcLibraryPreamble + ` |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1777 | cc_library { |
| 1778 | name: "shared_empty", |
| 1779 | target: { |
| 1780 | bionic: { |
| 1781 | shared: { |
| 1782 | system_shared_libs: [], |
| 1783 | } |
| 1784 | } |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1785 | }, |
| 1786 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1787 | } |
| 1788 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1789 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 1790 | MakeBazelTarget("cc_library_static", "shared_empty_bp2build_cc_library_static", AttrNameToString{}), |
| 1791 | MakeBazelTarget("cc_library_shared", "shared_empty", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1792 | "system_dynamic_deps": "[]", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1793 | }), |
| 1794 | }, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1795 | }) |
| 1796 | } |
| 1797 | |
| 1798 | func TestCcLibrary_SystemSharedLibsLinuxBionicEmpty(t *testing.T) { |
| 1799 | // Note that this behavior is technically incorrect (it's a simplification). |
| 1800 | // The correct behavior would be if bp2build wrote `system_dynamic_deps = []` |
| 1801 | // only for linux_bionic, but `android` had `["libc", "libdl", "libm"]. |
| 1802 | // b/195791252 tracks the fix. |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1803 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1804 | Description: "cc_library system_shared_libs empty for linux_bionic variant", |
| 1805 | ModuleTypeUnderTest: "cc_library", |
| 1806 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1807 | Blueprint: soongCcLibraryPreamble + ` |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1808 | cc_library { |
Trevor Radcliffe | 0d1b402 | 2022-12-12 22:26:34 +0000 | [diff] [blame] | 1809 | name: "libc_musl", |
| 1810 | bazel_module: { bp2build_available: false }, |
| 1811 | } |
| 1812 | |
| 1813 | cc_library { |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1814 | name: "target_linux_bionic_empty", |
| 1815 | target: { |
| 1816 | linux_bionic: { |
| 1817 | system_shared_libs: [], |
| 1818 | }, |
| 1819 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1820 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1821 | } |
| 1822 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1823 | ExpectedBazelTargets: makeCcLibraryTargets("target_linux_bionic_empty", AttrNameToString{ |
Trevor Radcliffe | 0d1b402 | 2022-12-12 22:26:34 +0000 | [diff] [blame] | 1824 | "system_dynamic_deps": `select({ |
| 1825 | "//build/bazel/platforms/os:linux_musl": [":libc_musl"], |
| 1826 | "//conditions:default": [], |
| 1827 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1828 | }), |
| 1829 | }, |
| 1830 | ) |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1831 | } |
| 1832 | |
| 1833 | func TestCcLibrary_SystemSharedLibsBionicEmpty(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1834 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1835 | Description: "cc_library system_shared_libs empty for bionic variant", |
| 1836 | ModuleTypeUnderTest: "cc_library", |
| 1837 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1838 | Blueprint: soongCcLibraryPreamble + ` |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1839 | cc_library { |
Trevor Radcliffe | 0d1b402 | 2022-12-12 22:26:34 +0000 | [diff] [blame] | 1840 | name: "libc_musl", |
| 1841 | bazel_module: { bp2build_available: false }, |
| 1842 | } |
| 1843 | |
| 1844 | cc_library { |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1845 | name: "target_bionic_empty", |
| 1846 | target: { |
| 1847 | bionic: { |
| 1848 | system_shared_libs: [], |
| 1849 | }, |
| 1850 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1851 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1852 | } |
| 1853 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1854 | ExpectedBazelTargets: makeCcLibraryTargets("target_bionic_empty", AttrNameToString{ |
Trevor Radcliffe | 0d1b402 | 2022-12-12 22:26:34 +0000 | [diff] [blame] | 1855 | "system_dynamic_deps": `select({ |
| 1856 | "//build/bazel/platforms/os:linux_musl": [":libc_musl"], |
| 1857 | "//conditions:default": [], |
| 1858 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1859 | }), |
| 1860 | }, |
| 1861 | ) |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1862 | } |
| 1863 | |
Trevor Radcliffe | 0d1b402 | 2022-12-12 22:26:34 +0000 | [diff] [blame] | 1864 | func TestCcLibrary_SystemSharedLibsMuslEmpty(t *testing.T) { |
| 1865 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1866 | Description: "cc_library system_shared_lib empty for musl variant", |
| 1867 | ModuleTypeUnderTest: "cc_library", |
| 1868 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1869 | Blueprint: soongCcLibraryPreamble + ` |
| 1870 | cc_library { |
| 1871 | name: "libc_musl", |
| 1872 | bazel_module: { bp2build_available: false }, |
| 1873 | } |
| 1874 | |
| 1875 | cc_library { |
| 1876 | name: "target_musl_empty", |
| 1877 | target: { |
| 1878 | musl: { |
| 1879 | system_shared_libs: [], |
| 1880 | }, |
| 1881 | }, |
| 1882 | include_build_directory: false, |
| 1883 | } |
| 1884 | `, |
| 1885 | ExpectedBazelTargets: makeCcLibraryTargets("target_musl_empty", AttrNameToString{ |
| 1886 | "system_dynamic_deps": `[]`, |
| 1887 | }), |
| 1888 | }) |
| 1889 | } |
| 1890 | |
| 1891 | func TestCcLibrary_SystemSharedLibsLinuxMuslEmpty(t *testing.T) { |
| 1892 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1893 | Description: "cc_library system_shared_lib empty for linux_musl variant", |
| 1894 | ModuleTypeUnderTest: "cc_library", |
| 1895 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1896 | Blueprint: soongCcLibraryPreamble + ` |
| 1897 | cc_library { |
| 1898 | name: "libc_musl", |
| 1899 | bazel_module: { bp2build_available: false }, |
| 1900 | } |
| 1901 | |
| 1902 | cc_library { |
| 1903 | name: "target_linux_musl_empty", |
| 1904 | target: { |
| 1905 | linux_musl: { |
| 1906 | system_shared_libs: [], |
| 1907 | }, |
| 1908 | }, |
| 1909 | include_build_directory: false, |
| 1910 | } |
| 1911 | `, |
| 1912 | ExpectedBazelTargets: makeCcLibraryTargets("target_linux_musl_empty", AttrNameToString{ |
| 1913 | "system_dynamic_deps": `[]`, |
| 1914 | }), |
| 1915 | }) |
| 1916 | } |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1917 | func TestCcLibrary_SystemSharedLibsSharedAndRoot(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1918 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1919 | Description: "cc_library system_shared_libs set for shared and root", |
| 1920 | ModuleTypeUnderTest: "cc_library", |
| 1921 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1922 | Blueprint: soongCcLibraryPreamble + ` |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1923 | cc_library { |
| 1924 | name: "libc", |
| 1925 | bazel_module: { bp2build_available: false }, |
| 1926 | } |
| 1927 | cc_library { |
| 1928 | name: "libm", |
| 1929 | bazel_module: { bp2build_available: false }, |
| 1930 | } |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1931 | |
| 1932 | cc_library { |
| 1933 | name: "foo", |
| 1934 | system_shared_libs: ["libc"], |
| 1935 | shared: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1936 | system_shared_libs: ["libm"], |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1937 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1938 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1939 | } |
| 1940 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1941 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 1942 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1943 | "system_dynamic_deps": `[":libc"]`, |
| 1944 | }), |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 1945 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1946 | "system_dynamic_deps": `[ |
| 1947 | ":libc", |
| 1948 | ":libm", |
| 1949 | ]`, |
| 1950 | }), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1951 | }, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1952 | }) |
| 1953 | } |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1954 | |
| 1955 | func TestCcLibraryOsSelects(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1956 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 1957 | Description: "cc_library - selects for all os targets", |
| 1958 | ModuleTypeUnderTest: "cc_library", |
| 1959 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 1960 | Filesystem: map[string]string{}, |
| 1961 | Blueprint: soongCcLibraryPreamble + ` |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1962 | cc_library { |
| 1963 | name: "foo-lib", |
| 1964 | srcs: ["base.cpp"], |
| 1965 | target: { |
| 1966 | android: { |
| 1967 | srcs: ["android.cpp"], |
| 1968 | }, |
| 1969 | linux: { |
| 1970 | srcs: ["linux.cpp"], |
| 1971 | }, |
| 1972 | linux_glibc: { |
| 1973 | srcs: ["linux_glibc.cpp"], |
| 1974 | }, |
| 1975 | darwin: { |
| 1976 | srcs: ["darwin.cpp"], |
| 1977 | }, |
| 1978 | bionic: { |
| 1979 | srcs: ["bionic.cpp"], |
| 1980 | }, |
| 1981 | linux_musl: { |
| 1982 | srcs: ["linux_musl.cpp"], |
| 1983 | }, |
| 1984 | windows: { |
| 1985 | srcs: ["windows.cpp"], |
| 1986 | }, |
| 1987 | }, |
| 1988 | include_build_directory: false, |
| 1989 | } |
| 1990 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 1991 | ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1992 | "srcs": `["base.cpp"] + select({ |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1993 | "//build/bazel/platforms/os:android": [ |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1994 | "linux.cpp", |
Liz Kammer | 9bad9d6 | 2021-10-11 15:40:35 -0400 | [diff] [blame] | 1995 | "bionic.cpp", |
Liz Kammer | fdd72e6 | 2021-10-11 15:41:03 -0400 | [diff] [blame] | 1996 | "android.cpp", |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1997 | ], |
| 1998 | "//build/bazel/platforms/os:darwin": ["darwin.cpp"], |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1999 | "//build/bazel/platforms/os:linux_bionic": [ |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 2000 | "linux.cpp", |
Liz Kammer | 9bad9d6 | 2021-10-11 15:40:35 -0400 | [diff] [blame] | 2001 | "bionic.cpp", |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 2002 | ], |
Colin Cross | 133782e | 2022-12-20 15:29:31 -0800 | [diff] [blame] | 2003 | "//build/bazel/platforms/os:linux_glibc": [ |
| 2004 | "linux.cpp", |
| 2005 | "linux_glibc.cpp", |
| 2006 | ], |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 2007 | "//build/bazel/platforms/os:linux_musl": [ |
Liz Kammer | 9bad9d6 | 2021-10-11 15:40:35 -0400 | [diff] [blame] | 2008 | "linux.cpp", |
Liz Kammer | fdd72e6 | 2021-10-11 15:41:03 -0400 | [diff] [blame] | 2009 | "linux_musl.cpp", |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 2010 | ], |
| 2011 | "//build/bazel/platforms/os:windows": ["windows.cpp"], |
| 2012 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 2013 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2014 | }), |
| 2015 | }, |
| 2016 | ) |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2017 | } |
| 2018 | |
Yu Liu | 75be7b9 | 2022-02-01 09:54:09 -0800 | [diff] [blame] | 2019 | func TestLibcryptoHashInjection(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2020 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 2021 | Description: "cc_library - libcrypto hash injection", |
| 2022 | ModuleTypeUnderTest: "cc_library", |
| 2023 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 2024 | Filesystem: map[string]string{}, |
| 2025 | Blueprint: soongCcLibraryPreamble + ` |
Yu Liu | 75be7b9 | 2022-02-01 09:54:09 -0800 | [diff] [blame] | 2026 | cc_library { |
| 2027 | name: "libcrypto", |
| 2028 | target: { |
| 2029 | android: { |
| 2030 | inject_bssl_hash: true, |
| 2031 | }, |
| 2032 | }, |
| 2033 | include_build_directory: false, |
| 2034 | } |
| 2035 | `, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2036 | ExpectedBazelTargets: makeCcLibraryTargets("libcrypto", AttrNameToString{ |
Yu Liu | 75be7b9 | 2022-02-01 09:54:09 -0800 | [diff] [blame] | 2037 | "inject_bssl_hash": `select({ |
| 2038 | "//build/bazel/platforms/os:android": True, |
| 2039 | "//conditions:default": None, |
| 2040 | })`, |
| 2041 | }), |
| 2042 | }, |
| 2043 | ) |
| 2044 | } |
| 2045 | |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2046 | func TestCcLibraryCppStdWithGnuExtensions_ConvertsToFeatureAttr(t *testing.T) { |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2047 | type testCase struct { |
| 2048 | cpp_std string |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2049 | c_std string |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2050 | gnu_extensions string |
| 2051 | bazel_cpp_std string |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2052 | bazel_c_std string |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2053 | } |
| 2054 | |
| 2055 | testCases := []testCase{ |
| 2056 | // Existing usages of cpp_std in AOSP are: |
| 2057 | // experimental, c++11, c++17, c++2a, c++98, gnu++11, gnu++17 |
| 2058 | // |
| 2059 | // not set, only emit if gnu_extensions is disabled. the default (gnu+17 |
| 2060 | // is set in the toolchain.) |
| 2061 | {cpp_std: "", gnu_extensions: "", bazel_cpp_std: ""}, |
Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2062 | {cpp_std: "", gnu_extensions: "false", bazel_cpp_std: "cpp_std_default_no_gnu", bazel_c_std: "c_std_default_no_gnu"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2063 | {cpp_std: "", gnu_extensions: "true", bazel_cpp_std: ""}, |
| 2064 | // experimental defaults to gnu++2a |
Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2065 | {cpp_std: "experimental", gnu_extensions: "", bazel_cpp_std: "cpp_std_experimental"}, |
| 2066 | {cpp_std: "experimental", gnu_extensions: "false", bazel_cpp_std: "cpp_std_experimental_no_gnu", bazel_c_std: "c_std_default_no_gnu"}, |
| 2067 | {cpp_std: "experimental", gnu_extensions: "true", bazel_cpp_std: "cpp_std_experimental"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2068 | // Explicitly setting a c++ std does not use replace gnu++ std even if |
| 2069 | // gnu_extensions is true. |
| 2070 | // "c++11", |
| 2071 | {cpp_std: "c++11", gnu_extensions: "", bazel_cpp_std: "c++11"}, |
Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2072 | {cpp_std: "c++11", gnu_extensions: "false", bazel_cpp_std: "c++11", bazel_c_std: "c_std_default_no_gnu"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2073 | {cpp_std: "c++11", gnu_extensions: "true", bazel_cpp_std: "c++11"}, |
| 2074 | // "c++17", |
| 2075 | {cpp_std: "c++17", gnu_extensions: "", bazel_cpp_std: "c++17"}, |
Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2076 | {cpp_std: "c++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c_std_default_no_gnu"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2077 | {cpp_std: "c++17", gnu_extensions: "true", bazel_cpp_std: "c++17"}, |
| 2078 | // "c++2a", |
| 2079 | {cpp_std: "c++2a", gnu_extensions: "", bazel_cpp_std: "c++2a"}, |
Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2080 | {cpp_std: "c++2a", gnu_extensions: "false", bazel_cpp_std: "c++2a", bazel_c_std: "c_std_default_no_gnu"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2081 | {cpp_std: "c++2a", gnu_extensions: "true", bazel_cpp_std: "c++2a"}, |
| 2082 | // "c++98", |
| 2083 | {cpp_std: "c++98", gnu_extensions: "", bazel_cpp_std: "c++98"}, |
Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2084 | {cpp_std: "c++98", gnu_extensions: "false", bazel_cpp_std: "c++98", bazel_c_std: "c_std_default_no_gnu"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2085 | {cpp_std: "c++98", gnu_extensions: "true", bazel_cpp_std: "c++98"}, |
| 2086 | // gnu++ is replaced with c++ if gnu_extensions is explicitly false. |
| 2087 | // "gnu++11", |
| 2088 | {cpp_std: "gnu++11", gnu_extensions: "", bazel_cpp_std: "gnu++11"}, |
Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2089 | {cpp_std: "gnu++11", gnu_extensions: "false", bazel_cpp_std: "c++11", bazel_c_std: "c_std_default_no_gnu"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2090 | {cpp_std: "gnu++11", gnu_extensions: "true", bazel_cpp_std: "gnu++11"}, |
| 2091 | // "gnu++17", |
| 2092 | {cpp_std: "gnu++17", gnu_extensions: "", bazel_cpp_std: "gnu++17"}, |
Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2093 | {cpp_std: "gnu++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c_std_default_no_gnu"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2094 | {cpp_std: "gnu++17", gnu_extensions: "true", bazel_cpp_std: "gnu++17"}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2095 | |
| 2096 | // some c_std test cases |
Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2097 | {c_std: "experimental", gnu_extensions: "", bazel_c_std: "c_std_experimental"}, |
| 2098 | {c_std: "experimental", gnu_extensions: "false", bazel_cpp_std: "cpp_std_default_no_gnu", bazel_c_std: "c_std_experimental_no_gnu"}, |
| 2099 | {c_std: "experimental", gnu_extensions: "true", bazel_c_std: "c_std_experimental"}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2100 | {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "", bazel_cpp_std: "gnu++17", bazel_c_std: "gnu11"}, |
| 2101 | {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c11"}, |
| 2102 | {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "true", bazel_cpp_std: "gnu++17", bazel_c_std: "gnu11"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2103 | } |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2104 | for i, tc := range testCases { |
Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2105 | name := fmt.Sprintf("cpp std: %q, c std: %q, gnu_extensions: %q", tc.cpp_std, tc.c_std, tc.gnu_extensions) |
| 2106 | t.Run(name, func(t *testing.T) { |
| 2107 | name_prefix := fmt.Sprintf("a_%v", i) |
| 2108 | cppStdProp := "" |
| 2109 | if tc.cpp_std != "" { |
| 2110 | cppStdProp = fmt.Sprintf(" cpp_std: \"%s\",", tc.cpp_std) |
| 2111 | } |
| 2112 | cStdProp := "" |
| 2113 | if tc.c_std != "" { |
| 2114 | cStdProp = fmt.Sprintf(" c_std: \"%s\",", tc.c_std) |
| 2115 | } |
| 2116 | gnuExtensionsProp := "" |
| 2117 | if tc.gnu_extensions != "" { |
| 2118 | gnuExtensionsProp = fmt.Sprintf(" gnu_extensions: %s,", tc.gnu_extensions) |
| 2119 | } |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2120 | attrs := AttrNameToString{} |
Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2121 | if tc.bazel_cpp_std != "" { |
| 2122 | attrs["cpp_std"] = fmt.Sprintf(`"%s"`, tc.bazel_cpp_std) |
| 2123 | } |
| 2124 | if tc.bazel_c_std != "" { |
| 2125 | attrs["c_std"] = fmt.Sprintf(`"%s"`, tc.bazel_c_std) |
| 2126 | } |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2127 | |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2128 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 2129 | Description: fmt.Sprintf( |
Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2130 | "cc_library with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions), |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2131 | ModuleTypeUnderTest: "cc_library", |
| 2132 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 2133 | Blueprint: soongCcLibraryPreamble + fmt.Sprintf(` |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2134 | cc_library { |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2135 | name: "%s_full", |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2136 | %s // cpp_std: *string |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2137 | %s // c_std: *string |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2138 | %s // gnu_extensions: *bool |
| 2139 | include_build_directory: false, |
| 2140 | } |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2141 | `, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp), |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2142 | ExpectedBazelTargets: makeCcLibraryTargets(name_prefix+"_full", attrs), |
Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2143 | }) |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2144 | |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2145 | runCcLibraryStaticTestCase(t, Bp2buildTestCase{ |
| 2146 | Description: fmt.Sprintf( |
Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2147 | "cc_library_static with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions), |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2148 | ModuleTypeUnderTest: "cc_library_static", |
| 2149 | ModuleTypeUnderTestFactory: cc.LibraryStaticFactory, |
| 2150 | Blueprint: soongCcLibraryPreamble + fmt.Sprintf(` |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2151 | cc_library_static { |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2152 | name: "%s_static", |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2153 | %s // cpp_std: *string |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2154 | %s // c_std: *string |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2155 | %s // gnu_extensions: *bool |
| 2156 | include_build_directory: false, |
| 2157 | } |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2158 | `, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp), |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2159 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2160 | MakeBazelTarget("cc_library_static", name_prefix+"_static", attrs), |
Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2161 | }, |
| 2162 | }) |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2163 | |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2164 | runCcLibrarySharedTestCase(t, Bp2buildTestCase{ |
| 2165 | Description: fmt.Sprintf( |
Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2166 | "cc_library_shared with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions), |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2167 | ModuleTypeUnderTest: "cc_library_shared", |
| 2168 | ModuleTypeUnderTestFactory: cc.LibrarySharedFactory, |
| 2169 | Blueprint: soongCcLibraryPreamble + fmt.Sprintf(` |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2170 | cc_library_shared { |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2171 | name: "%s_shared", |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2172 | %s // cpp_std: *string |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2173 | %s // c_std: *string |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2174 | %s // gnu_extensions: *bool |
| 2175 | include_build_directory: false, |
| 2176 | } |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 2177 | `, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp), |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2178 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2179 | MakeBazelTarget("cc_library_shared", name_prefix+"_shared", attrs), |
Liz Kammer | a5a29de | 2022-05-25 23:19:37 -0400 | [diff] [blame] | 2180 | }, |
| 2181 | }) |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 2182 | }) |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 2183 | } |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 2184 | } |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2185 | |
| 2186 | func TestCcLibraryProtoSimple(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2187 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 2188 | ModuleTypeUnderTest: "cc_library", |
| 2189 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 2190 | Blueprint: soongCcProtoPreamble + `cc_library { |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2191 | name: "foo", |
| 2192 | srcs: ["foo.proto"], |
| 2193 | include_build_directory: false, |
| 2194 | }`, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2195 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2196 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ |
Liz Kammer | 7756c8f | 2022-02-14 20:49:15 -0500 | [diff] [blame] | 2197 | "srcs": `["foo.proto"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2198 | }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2199 | "deps": `[":foo_proto"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2200 | }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2201 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2202 | "deps": `[":libprotobuf-cpp-lite"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2203 | }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
Liz Kammer | 84b0ecb | 2022-09-14 10:49:13 -0400 | [diff] [blame] | 2204 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
| 2205 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2206 | }), |
| 2207 | }, |
| 2208 | }) |
| 2209 | } |
| 2210 | |
| 2211 | func TestCcLibraryProtoNoCanonicalPathFromRoot(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2212 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 2213 | ModuleTypeUnderTest: "cc_library", |
| 2214 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 2215 | Blueprint: soongCcProtoPreamble + `cc_library { |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2216 | name: "foo", |
| 2217 | srcs: ["foo.proto"], |
| 2218 | proto: { canonical_path_from_root: false}, |
| 2219 | include_build_directory: false, |
| 2220 | }`, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2221 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2222 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ |
Liz Kammer | 7756c8f | 2022-02-14 20:49:15 -0500 | [diff] [blame] | 2223 | "srcs": `["foo.proto"]`, |
| 2224 | "strip_import_prefix": `""`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2225 | }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2226 | "deps": `[":foo_proto"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2227 | }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2228 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2229 | "deps": `[":libprotobuf-cpp-lite"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2230 | }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
Liz Kammer | 84b0ecb | 2022-09-14 10:49:13 -0400 | [diff] [blame] | 2231 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
| 2232 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2233 | }), |
| 2234 | }, |
| 2235 | }) |
| 2236 | } |
| 2237 | |
| 2238 | func TestCcLibraryProtoExplicitCanonicalPathFromRoot(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2239 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 2240 | ModuleTypeUnderTest: "cc_library", |
| 2241 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 2242 | Blueprint: soongCcProtoPreamble + `cc_library { |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2243 | name: "foo", |
| 2244 | srcs: ["foo.proto"], |
| 2245 | proto: { canonical_path_from_root: true}, |
| 2246 | include_build_directory: false, |
| 2247 | }`, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2248 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2249 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ |
Liz Kammer | 7756c8f | 2022-02-14 20:49:15 -0500 | [diff] [blame] | 2250 | "srcs": `["foo.proto"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2251 | }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2252 | "deps": `[":foo_proto"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2253 | }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2254 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2255 | "deps": `[":libprotobuf-cpp-lite"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2256 | }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
Liz Kammer | 84b0ecb | 2022-09-14 10:49:13 -0400 | [diff] [blame] | 2257 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
| 2258 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2259 | }), |
| 2260 | }, |
| 2261 | }) |
| 2262 | } |
| 2263 | |
| 2264 | func TestCcLibraryProtoFull(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2265 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 2266 | ModuleTypeUnderTest: "cc_library", |
| 2267 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 2268 | Blueprint: soongCcProtoPreamble + `cc_library { |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2269 | name: "foo", |
| 2270 | srcs: ["foo.proto"], |
| 2271 | proto: { |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2272 | type: "full", |
| 2273 | }, |
| 2274 | include_build_directory: false, |
| 2275 | }`, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2276 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2277 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2278 | "srcs": `["foo.proto"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2279 | }), MakeBazelTarget("cc_proto_library", "foo_cc_proto", AttrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2280 | "deps": `[":foo_proto"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2281 | }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2282 | "implementation_whole_archive_deps": `[":foo_cc_proto"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2283 | "deps": `[":libprotobuf-cpp-full"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2284 | }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
Liz Kammer | 84b0ecb | 2022-09-14 10:49:13 -0400 | [diff] [blame] | 2285 | "dynamic_deps": `[":libprotobuf-cpp-full"]`, |
| 2286 | "implementation_whole_archive_deps": `[":foo_cc_proto"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2287 | }), |
| 2288 | }, |
| 2289 | }) |
| 2290 | } |
| 2291 | |
| 2292 | func TestCcLibraryProtoLite(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2293 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 2294 | ModuleTypeUnderTest: "cc_library", |
| 2295 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 2296 | Blueprint: soongCcProtoPreamble + `cc_library { |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2297 | name: "foo", |
| 2298 | srcs: ["foo.proto"], |
| 2299 | proto: { |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2300 | type: "lite", |
| 2301 | }, |
| 2302 | include_build_directory: false, |
| 2303 | }`, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2304 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2305 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2306 | "srcs": `["foo.proto"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2307 | }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2308 | "deps": `[":foo_proto"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2309 | }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2310 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2311 | "deps": `[":libprotobuf-cpp-lite"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2312 | }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
Liz Kammer | 84b0ecb | 2022-09-14 10:49:13 -0400 | [diff] [blame] | 2313 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
| 2314 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2315 | }), |
| 2316 | }, |
| 2317 | }) |
| 2318 | } |
| 2319 | |
| 2320 | func TestCcLibraryProtoExportHeaders(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2321 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 2322 | ModuleTypeUnderTest: "cc_library", |
| 2323 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 2324 | Blueprint: soongCcProtoPreamble + `cc_library { |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2325 | name: "foo", |
| 2326 | srcs: ["foo.proto"], |
| 2327 | proto: { |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2328 | export_proto_headers: true, |
| 2329 | }, |
| 2330 | include_build_directory: false, |
| 2331 | }`, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2332 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2333 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2334 | "srcs": `["foo.proto"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2335 | }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2336 | "deps": `[":foo_proto"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2337 | }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2338 | "deps": `[":libprotobuf-cpp-lite"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2339 | "whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2340 | }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2341 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
| 2342 | "whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2343 | }), |
| 2344 | }, |
| 2345 | }) |
| 2346 | } |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2347 | |
Yu Liu | 2d13614 | 2022-08-18 14:46:13 -0700 | [diff] [blame] | 2348 | func TestCcLibraryProtoIncludeDirs(t *testing.T) { |
| 2349 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 2350 | ModuleTypeUnderTest: "cc_library", |
| 2351 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 2352 | Blueprint: soongCcProtoPreamble + `cc_library { |
| 2353 | name: "foo", |
| 2354 | srcs: ["foo.proto"], |
| 2355 | proto: { |
| 2356 | include_dirs: ["external/protobuf/src"], |
| 2357 | }, |
| 2358 | include_build_directory: false, |
| 2359 | }`, |
| 2360 | ExpectedBazelTargets: []string{ |
| 2361 | MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{ |
| 2362 | "srcs": `["foo.proto"]`, |
| 2363 | "deps": `["//external/protobuf:libprotobuf-proto"]`, |
| 2364 | }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{ |
| 2365 | "deps": `[":foo_proto"]`, |
| 2366 | }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
| 2367 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 2368 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, |
| 2369 | }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
Liz Kammer | 84b0ecb | 2022-09-14 10:49:13 -0400 | [diff] [blame] | 2370 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
| 2371 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Yu Liu | 2d13614 | 2022-08-18 14:46:13 -0700 | [diff] [blame] | 2372 | }), |
| 2373 | }, |
| 2374 | }) |
| 2375 | } |
| 2376 | |
| 2377 | func TestCcLibraryProtoIncludeDirsUnknown(t *testing.T) { |
| 2378 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 2379 | ModuleTypeUnderTest: "cc_library", |
| 2380 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 2381 | Blueprint: soongCcProtoPreamble + `cc_library { |
| 2382 | name: "foo", |
| 2383 | srcs: ["foo.proto"], |
| 2384 | proto: { |
| 2385 | include_dirs: ["external/protobuf/abc"], |
| 2386 | }, |
| 2387 | include_build_directory: false, |
| 2388 | }`, |
| 2389 | ExpectedErr: fmt.Errorf("module \"foo\": Could not find the proto_library target for include dir: external/protobuf/abc"), |
| 2390 | }) |
| 2391 | } |
| 2392 | |
Yu Liu | 2aa806b | 2022-09-01 11:54:47 -0700 | [diff] [blame] | 2393 | func TestCcLibraryConvertedProtoFilegroups(t *testing.T) { |
| 2394 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 2395 | ModuleTypeUnderTest: "cc_library", |
| 2396 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 2397 | Blueprint: soongCcProtoPreamble + ` |
| 2398 | filegroup { |
| 2399 | name: "a_fg_proto", |
| 2400 | srcs: ["a_fg.proto"], |
| 2401 | } |
| 2402 | |
| 2403 | cc_library { |
| 2404 | name: "a", |
| 2405 | srcs: [ |
| 2406 | ":a_fg_proto", |
| 2407 | "a.proto", |
| 2408 | ], |
| 2409 | proto: { |
| 2410 | export_proto_headers: true, |
| 2411 | }, |
| 2412 | include_build_directory: false, |
| 2413 | }`, |
| 2414 | ExpectedBazelTargets: []string{ |
| 2415 | MakeBazelTarget("proto_library", "a_proto", AttrNameToString{ |
Yu Liu | 2a85fb1 | 2022-09-15 22:18:48 -0700 | [diff] [blame] | 2416 | "deps": `[":a_fg_proto_bp2build_converted"]`, |
Yu Liu | 2aa806b | 2022-09-01 11:54:47 -0700 | [diff] [blame] | 2417 | "srcs": `["a.proto"]`, |
| 2418 | }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{ |
| 2419 | "deps": `[ |
| 2420 | ":a_fg_proto_bp2build_converted", |
| 2421 | ":a_proto", |
| 2422 | ]`, |
| 2423 | }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{ |
| 2424 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 2425 | "whole_archive_deps": `[":a_cc_proto_lite"]`, |
| 2426 | }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ |
| 2427 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
| 2428 | "whole_archive_deps": `[":a_cc_proto_lite"]`, |
| 2429 | }), MakeBazelTargetNoRestrictions("proto_library", "a_fg_proto_bp2build_converted", AttrNameToString{ |
| 2430 | "srcs": `["a_fg.proto"]`, |
Yu Liu | 2a85fb1 | 2022-09-15 22:18:48 -0700 | [diff] [blame] | 2431 | "tags": `["manual"]`, |
Yu Liu | 2aa806b | 2022-09-01 11:54:47 -0700 | [diff] [blame] | 2432 | }), MakeBazelTargetNoRestrictions("filegroup", "a_fg_proto", AttrNameToString{ |
| 2433 | "srcs": `["a_fg.proto"]`, |
| 2434 | }), |
| 2435 | }, |
| 2436 | }) |
| 2437 | } |
| 2438 | |
| 2439 | func TestCcLibraryConvertedProtoFilegroupsNoProtoFiles(t *testing.T) { |
| 2440 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 2441 | ModuleTypeUnderTest: "cc_library", |
| 2442 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 2443 | Blueprint: soongCcProtoPreamble + ` |
| 2444 | filegroup { |
| 2445 | name: "a_fg_proto", |
| 2446 | srcs: ["a_fg.proto"], |
| 2447 | } |
| 2448 | |
| 2449 | cc_library { |
| 2450 | name: "a", |
| 2451 | srcs: [ |
| 2452 | ":a_fg_proto", |
| 2453 | ], |
| 2454 | proto: { |
| 2455 | export_proto_headers: true, |
| 2456 | }, |
| 2457 | include_build_directory: false, |
| 2458 | }`, |
| 2459 | ExpectedBazelTargets: []string{ |
| 2460 | MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{ |
| 2461 | "deps": `[":a_fg_proto_bp2build_converted"]`, |
| 2462 | }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{ |
| 2463 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 2464 | "whole_archive_deps": `[":a_cc_proto_lite"]`, |
| 2465 | }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ |
| 2466 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
| 2467 | "whole_archive_deps": `[":a_cc_proto_lite"]`, |
| 2468 | }), MakeBazelTargetNoRestrictions("proto_library", "a_fg_proto_bp2build_converted", AttrNameToString{ |
| 2469 | "srcs": `["a_fg.proto"]`, |
Yu Liu | 2a85fb1 | 2022-09-15 22:18:48 -0700 | [diff] [blame] | 2470 | "tags": `["manual"]`, |
Yu Liu | 2aa806b | 2022-09-01 11:54:47 -0700 | [diff] [blame] | 2471 | }), MakeBazelTargetNoRestrictions("filegroup", "a_fg_proto", AttrNameToString{ |
| 2472 | "srcs": `["a_fg.proto"]`, |
| 2473 | }), |
| 2474 | }, |
| 2475 | }) |
| 2476 | } |
| 2477 | |
| 2478 | func TestCcLibraryExternalConvertedProtoFilegroups(t *testing.T) { |
| 2479 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 2480 | ModuleTypeUnderTest: "cc_library", |
| 2481 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 2482 | Filesystem: map[string]string{ |
| 2483 | "path/to/A/Android.bp": ` |
| 2484 | filegroup { |
| 2485 | name: "a_fg_proto", |
| 2486 | srcs: ["a_fg.proto"], |
| 2487 | }`, |
| 2488 | }, |
| 2489 | Blueprint: soongCcProtoPreamble + ` |
| 2490 | cc_library { |
| 2491 | name: "a", |
| 2492 | srcs: [ |
| 2493 | ":a_fg_proto", |
| 2494 | "a.proto", |
| 2495 | ], |
| 2496 | proto: { |
| 2497 | export_proto_headers: true, |
| 2498 | }, |
| 2499 | include_build_directory: false, |
| 2500 | }`, |
| 2501 | ExpectedBazelTargets: []string{ |
| 2502 | MakeBazelTarget("proto_library", "a_proto", AttrNameToString{ |
Yu Liu | 2a85fb1 | 2022-09-15 22:18:48 -0700 | [diff] [blame] | 2503 | "deps": `["//path/to/A:a_fg_proto_bp2build_converted"]`, |
Yu Liu | 2aa806b | 2022-09-01 11:54:47 -0700 | [diff] [blame] | 2504 | "srcs": `["a.proto"]`, |
| 2505 | }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{ |
| 2506 | "deps": `[ |
| 2507 | "//path/to/A:a_fg_proto_bp2build_converted", |
| 2508 | ":a_proto", |
| 2509 | ]`, |
| 2510 | }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{ |
| 2511 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 2512 | "whole_archive_deps": `[":a_cc_proto_lite"]`, |
| 2513 | }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ |
| 2514 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
| 2515 | "whole_archive_deps": `[":a_cc_proto_lite"]`, |
| 2516 | }), |
| 2517 | }, |
| 2518 | }) |
| 2519 | } |
| 2520 | |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2521 | func TestCcLibraryProtoFilegroups(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2522 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 2523 | ModuleTypeUnderTest: "cc_library", |
| 2524 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 2525 | Blueprint: soongCcProtoPreamble + |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2526 | simpleModuleDoNotConvertBp2build("filegroup", "a_fg_proto") + |
| 2527 | simpleModuleDoNotConvertBp2build("filegroup", "b_protos") + |
| 2528 | simpleModuleDoNotConvertBp2build("filegroup", "c-proto-srcs") + |
| 2529 | simpleModuleDoNotConvertBp2build("filegroup", "proto-srcs-d") + ` |
| 2530 | cc_library { |
| 2531 | name: "a", |
| 2532 | srcs: [":a_fg_proto"], |
| 2533 | proto: { |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2534 | export_proto_headers: true, |
| 2535 | }, |
| 2536 | include_build_directory: false, |
| 2537 | } |
| 2538 | |
| 2539 | cc_library { |
| 2540 | name: "b", |
| 2541 | srcs: [":b_protos"], |
| 2542 | proto: { |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2543 | export_proto_headers: true, |
| 2544 | }, |
| 2545 | include_build_directory: false, |
| 2546 | } |
| 2547 | |
| 2548 | cc_library { |
| 2549 | name: "c", |
| 2550 | srcs: [":c-proto-srcs"], |
| 2551 | proto: { |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2552 | export_proto_headers: true, |
| 2553 | }, |
| 2554 | include_build_directory: false, |
| 2555 | } |
| 2556 | |
| 2557 | cc_library { |
| 2558 | name: "d", |
| 2559 | srcs: [":proto-srcs-d"], |
| 2560 | proto: { |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2561 | export_proto_headers: true, |
| 2562 | }, |
| 2563 | include_build_directory: false, |
| 2564 | }`, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2565 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2566 | MakeBazelTarget("proto_library", "a_proto", AttrNameToString{ |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2567 | "srcs": `[":a_fg_proto"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2568 | }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{ |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2569 | "deps": `[":a_proto"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2570 | }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{ |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2571 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 2572 | "whole_archive_deps": `[":a_cc_proto_lite"]`, |
| 2573 | "srcs": `[":a_fg_proto_cpp_srcs"]`, |
| 2574 | "srcs_as": `[":a_fg_proto_as_srcs"]`, |
| 2575 | "srcs_c": `[":a_fg_proto_c_srcs"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2576 | }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2577 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
| 2578 | "whole_archive_deps": `[":a_cc_proto_lite"]`, |
| 2579 | "srcs": `[":a_fg_proto_cpp_srcs"]`, |
| 2580 | "srcs_as": `[":a_fg_proto_as_srcs"]`, |
| 2581 | "srcs_c": `[":a_fg_proto_c_srcs"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2582 | }), MakeBazelTarget("proto_library", "b_proto", AttrNameToString{ |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2583 | "srcs": `[":b_protos"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2584 | }), MakeBazelTarget("cc_lite_proto_library", "b_cc_proto_lite", AttrNameToString{ |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2585 | "deps": `[":b_proto"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2586 | }), MakeBazelTarget("cc_library_static", "b_bp2build_cc_library_static", AttrNameToString{ |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2587 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 2588 | "whole_archive_deps": `[":b_cc_proto_lite"]`, |
| 2589 | "srcs": `[":b_protos_cpp_srcs"]`, |
| 2590 | "srcs_as": `[":b_protos_as_srcs"]`, |
| 2591 | "srcs_c": `[":b_protos_c_srcs"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2592 | }), MakeBazelTarget("cc_library_shared", "b", AttrNameToString{ |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2593 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
| 2594 | "whole_archive_deps": `[":b_cc_proto_lite"]`, |
| 2595 | "srcs": `[":b_protos_cpp_srcs"]`, |
| 2596 | "srcs_as": `[":b_protos_as_srcs"]`, |
| 2597 | "srcs_c": `[":b_protos_c_srcs"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2598 | }), MakeBazelTarget("proto_library", "c_proto", AttrNameToString{ |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2599 | "srcs": `[":c-proto-srcs"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2600 | }), MakeBazelTarget("cc_lite_proto_library", "c_cc_proto_lite", AttrNameToString{ |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2601 | "deps": `[":c_proto"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2602 | }), MakeBazelTarget("cc_library_static", "c_bp2build_cc_library_static", AttrNameToString{ |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2603 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 2604 | "whole_archive_deps": `[":c_cc_proto_lite"]`, |
| 2605 | "srcs": `[":c-proto-srcs_cpp_srcs"]`, |
| 2606 | "srcs_as": `[":c-proto-srcs_as_srcs"]`, |
| 2607 | "srcs_c": `[":c-proto-srcs_c_srcs"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2608 | }), MakeBazelTarget("cc_library_shared", "c", AttrNameToString{ |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2609 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
| 2610 | "whole_archive_deps": `[":c_cc_proto_lite"]`, |
| 2611 | "srcs": `[":c-proto-srcs_cpp_srcs"]`, |
| 2612 | "srcs_as": `[":c-proto-srcs_as_srcs"]`, |
| 2613 | "srcs_c": `[":c-proto-srcs_c_srcs"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2614 | }), MakeBazelTarget("proto_library", "d_proto", AttrNameToString{ |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2615 | "srcs": `[":proto-srcs-d"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2616 | }), MakeBazelTarget("cc_lite_proto_library", "d_cc_proto_lite", AttrNameToString{ |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2617 | "deps": `[":d_proto"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2618 | }), MakeBazelTarget("cc_library_static", "d_bp2build_cc_library_static", AttrNameToString{ |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2619 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 2620 | "whole_archive_deps": `[":d_cc_proto_lite"]`, |
| 2621 | "srcs": `[":proto-srcs-d_cpp_srcs"]`, |
| 2622 | "srcs_as": `[":proto-srcs-d_as_srcs"]`, |
| 2623 | "srcs_c": `[":proto-srcs-d_c_srcs"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2624 | }), MakeBazelTarget("cc_library_shared", "d", AttrNameToString{ |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2625 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
| 2626 | "whole_archive_deps": `[":d_cc_proto_lite"]`, |
| 2627 | "srcs": `[":proto-srcs-d_cpp_srcs"]`, |
| 2628 | "srcs_as": `[":proto-srcs-d_as_srcs"]`, |
| 2629 | "srcs_c": `[":proto-srcs-d_c_srcs"]`, |
| 2630 | }), |
| 2631 | }, |
| 2632 | }) |
| 2633 | } |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2634 | |
| 2635 | func TestCcLibraryDisabledArchAndTarget(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2636 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 2637 | ModuleTypeUnderTest: "cc_library", |
| 2638 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 2639 | Blueprint: soongCcProtoPreamble + `cc_library { |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2640 | name: "foo", |
| 2641 | srcs: ["foo.cpp"], |
Liz Kammer | dfeb120 | 2022-05-13 17:20:20 -0400 | [diff] [blame] | 2642 | host_supported: true, |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2643 | target: { |
| 2644 | darwin: { |
| 2645 | enabled: false, |
| 2646 | }, |
| 2647 | windows: { |
| 2648 | enabled: false, |
| 2649 | }, |
| 2650 | linux_glibc_x86: { |
| 2651 | enabled: false, |
| 2652 | }, |
| 2653 | }, |
| 2654 | include_build_directory: false, |
| 2655 | }`, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2656 | ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{ |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2657 | "srcs": `["foo.cpp"]`, |
| 2658 | "target_compatible_with": `select({ |
| 2659 | "//build/bazel/platforms/os_arch:darwin_arm64": ["@platforms//:incompatible"], |
| 2660 | "//build/bazel/platforms/os_arch:darwin_x86_64": ["@platforms//:incompatible"], |
| 2661 | "//build/bazel/platforms/os_arch:linux_glibc_x86": ["@platforms//:incompatible"], |
| 2662 | "//build/bazel/platforms/os_arch:windows_x86": ["@platforms//:incompatible"], |
| 2663 | "//build/bazel/platforms/os_arch:windows_x86_64": ["@platforms//:incompatible"], |
| 2664 | "//conditions:default": [], |
| 2665 | })`, |
| 2666 | }), |
| 2667 | }) |
| 2668 | } |
| 2669 | |
| 2670 | func TestCcLibraryDisabledArchAndTargetWithDefault(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2671 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 2672 | ModuleTypeUnderTest: "cc_library", |
| 2673 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 2674 | Blueprint: soongCcProtoPreamble + `cc_library { |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2675 | name: "foo", |
| 2676 | srcs: ["foo.cpp"], |
| 2677 | enabled: false, |
Liz Kammer | dfeb120 | 2022-05-13 17:20:20 -0400 | [diff] [blame] | 2678 | host_supported: true, |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2679 | target: { |
| 2680 | darwin: { |
| 2681 | enabled: true, |
| 2682 | }, |
| 2683 | windows: { |
| 2684 | enabled: false, |
| 2685 | }, |
| 2686 | linux_glibc_x86: { |
| 2687 | enabled: false, |
| 2688 | }, |
| 2689 | }, |
| 2690 | include_build_directory: false, |
| 2691 | }`, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2692 | ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{ |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2693 | "srcs": `["foo.cpp"]`, |
| 2694 | "target_compatible_with": `select({ |
| 2695 | "//build/bazel/platforms/os_arch:darwin_arm64": [], |
| 2696 | "//build/bazel/platforms/os_arch:darwin_x86_64": [], |
| 2697 | "//conditions:default": ["@platforms//:incompatible"], |
| 2698 | })`, |
| 2699 | }), |
| 2700 | }) |
| 2701 | } |
| 2702 | |
| 2703 | func TestCcLibrarySharedDisabled(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2704 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 2705 | ModuleTypeUnderTest: "cc_library", |
| 2706 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 2707 | Blueprint: soongCcProtoPreamble + `cc_library { |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2708 | name: "foo", |
| 2709 | srcs: ["foo.cpp"], |
| 2710 | enabled: false, |
| 2711 | shared: { |
| 2712 | enabled: true, |
| 2713 | }, |
| 2714 | target: { |
| 2715 | android: { |
| 2716 | shared: { |
| 2717 | enabled: false, |
| 2718 | }, |
| 2719 | } |
| 2720 | }, |
| 2721 | include_build_directory: false, |
| 2722 | }`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2723 | ExpectedBazelTargets: []string{MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2724 | "srcs": `["foo.cpp"]`, |
| 2725 | "target_compatible_with": `["@platforms//:incompatible"]`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2726 | }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2727 | "srcs": `["foo.cpp"]`, |
| 2728 | "target_compatible_with": `select({ |
| 2729 | "//build/bazel/platforms/os:android": ["@platforms//:incompatible"], |
| 2730 | "//conditions:default": [], |
| 2731 | })`, |
| 2732 | }), |
| 2733 | }, |
| 2734 | }) |
| 2735 | } |
| 2736 | |
| 2737 | func TestCcLibraryStaticDisabledForSomeArch(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2738 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 2739 | ModuleTypeUnderTest: "cc_library", |
| 2740 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 2741 | Blueprint: soongCcProtoPreamble + `cc_library { |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2742 | name: "foo", |
Liz Kammer | dfeb120 | 2022-05-13 17:20:20 -0400 | [diff] [blame] | 2743 | host_supported: true, |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2744 | srcs: ["foo.cpp"], |
| 2745 | shared: { |
| 2746 | enabled: false |
| 2747 | }, |
| 2748 | target: { |
| 2749 | darwin: { |
| 2750 | enabled: true, |
| 2751 | }, |
| 2752 | windows: { |
| 2753 | enabled: false, |
| 2754 | }, |
| 2755 | linux_glibc_x86: { |
| 2756 | shared: { |
| 2757 | enabled: true, |
| 2758 | }, |
| 2759 | }, |
| 2760 | }, |
| 2761 | include_build_directory: false, |
| 2762 | }`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2763 | ExpectedBazelTargets: []string{MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2764 | "srcs": `["foo.cpp"]`, |
| 2765 | "target_compatible_with": `select({ |
| 2766 | "//build/bazel/platforms/os:windows": ["@platforms//:incompatible"], |
| 2767 | "//conditions:default": [], |
| 2768 | })`, |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 2769 | }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2770 | "srcs": `["foo.cpp"]`, |
| 2771 | "target_compatible_with": `select({ |
| 2772 | "//build/bazel/platforms/os_arch:darwin_arm64": [], |
| 2773 | "//build/bazel/platforms/os_arch:darwin_x86_64": [], |
| 2774 | "//build/bazel/platforms/os_arch:linux_glibc_x86": [], |
| 2775 | "//conditions:default": ["@platforms//:incompatible"], |
| 2776 | })`, |
| 2777 | }), |
| 2778 | }}) |
| 2779 | } |
Jingwen Chen | 0ee88a6 | 2022-01-07 14:55:29 +0000 | [diff] [blame] | 2780 | |
| 2781 | func TestCcLibraryStubs(t *testing.T) { |
Wei Li | 81852ca | 2022-07-27 00:22:06 -0700 | [diff] [blame] | 2782 | expectedBazelTargets := makeCcLibraryTargets("a", AttrNameToString{ |
Yu Liu | 56ccb1a | 2022-11-12 10:47:07 -0800 | [diff] [blame] | 2783 | "stubs_symbol_file": `"a.map.txt"`, |
Wei Li | 81852ca | 2022-07-27 00:22:06 -0700 | [diff] [blame] | 2784 | }) |
| 2785 | expectedBazelTargets = append(expectedBazelTargets, makeCcStubSuiteTargets("a", AttrNameToString{ |
| 2786 | "soname": `"a.so"`, |
| 2787 | "source_library": `":a"`, |
| 2788 | "stubs_symbol_file": `"a.map.txt"`, |
| 2789 | "stubs_versions": `[ |
| 2790 | "28", |
| 2791 | "29", |
| 2792 | "current", |
| 2793 | ]`, |
| 2794 | })) |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 2795 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 2796 | Description: "cc_library stubs", |
| 2797 | ModuleTypeUnderTest: "cc_library", |
| 2798 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 2799 | Dir: "foo/bar", |
| 2800 | Filesystem: map[string]string{ |
Jingwen Chen | 0ee88a6 | 2022-01-07 14:55:29 +0000 | [diff] [blame] | 2801 | "foo/bar/Android.bp": ` |
| 2802 | cc_library { |
| 2803 | name: "a", |
| 2804 | stubs: { symbol_file: "a.map.txt", versions: ["28", "29", "current"] }, |
| 2805 | bazel_module: { bp2build_available: true }, |
| 2806 | include_build_directory: false, |
| 2807 | } |
| 2808 | `, |
| 2809 | }, |
Wei Li | 81852ca | 2022-07-27 00:22:06 -0700 | [diff] [blame] | 2810 | Blueprint: soongCcLibraryPreamble, |
| 2811 | ExpectedBazelTargets: expectedBazelTargets, |
Jingwen Chen | 0ee88a6 | 2022-01-07 14:55:29 +0000 | [diff] [blame] | 2812 | }, |
| 2813 | ) |
| 2814 | } |
Liz Kammer | f38a837 | 2022-02-04 15:39:00 -0500 | [diff] [blame] | 2815 | |
Spandan Das | 4238c65 | 2022-09-09 01:38:47 +0000 | [diff] [blame] | 2816 | func TestCcApiContributionsWithHdrs(t *testing.T) { |
| 2817 | bp := ` |
| 2818 | cc_library { |
| 2819 | name: "libfoo", |
| 2820 | stubs: { symbol_file: "libfoo.map.txt", versions: ["28", "29", "current"] }, |
| 2821 | llndk: { symbol_file: "libfoo.map.txt", override_export_include_dirs: ["dir2"]}, |
| 2822 | export_include_dirs: ["dir1"], |
| 2823 | } |
| 2824 | ` |
| 2825 | expectedBazelTargets := []string{ |
| 2826 | MakeBazelTarget( |
| 2827 | "cc_api_library_headers", |
Spandan Das | 627fc3e | 2023-01-26 23:02:00 +0000 | [diff] [blame^] | 2828 | "libfoo.module-libapi.headers", |
Spandan Das | 4238c65 | 2022-09-09 01:38:47 +0000 | [diff] [blame] | 2829 | AttrNameToString{ |
| 2830 | "export_includes": `["dir1"]`, |
| 2831 | }), |
| 2832 | MakeBazelTarget( |
| 2833 | "cc_api_library_headers", |
| 2834 | "libfoo.vendorapi.headers", |
| 2835 | AttrNameToString{ |
| 2836 | "export_includes": `["dir2"]`, |
| 2837 | }), |
| 2838 | MakeBazelTarget( |
| 2839 | "cc_api_contribution", |
| 2840 | "libfoo.contribution", |
| 2841 | AttrNameToString{ |
| 2842 | "api": `"libfoo.map.txt"`, |
| 2843 | "library_name": `"libfoo"`, |
| 2844 | "api_surfaces": `[ |
Spandan Das | 627fc3e | 2023-01-26 23:02:00 +0000 | [diff] [blame^] | 2845 | "module-libapi", |
Spandan Das | 4238c65 | 2022-09-09 01:38:47 +0000 | [diff] [blame] | 2846 | "vendorapi", |
| 2847 | ]`, |
| 2848 | "hdrs": `[ |
Spandan Das | 627fc3e | 2023-01-26 23:02:00 +0000 | [diff] [blame^] | 2849 | ":libfoo.module-libapi.headers", |
Spandan Das | 4238c65 | 2022-09-09 01:38:47 +0000 | [diff] [blame] | 2850 | ":libfoo.vendorapi.headers", |
| 2851 | ]`, |
| 2852 | }), |
| 2853 | } |
| 2854 | RunApiBp2BuildTestCase(t, cc.RegisterLibraryBuildComponents, Bp2buildTestCase{ |
| 2855 | Blueprint: bp, |
Spandan Das | 627fc3e | 2023-01-26 23:02:00 +0000 | [diff] [blame^] | 2856 | Description: "cc API contributions to module-libapi and vendorapi", |
Spandan Das | 4238c65 | 2022-09-09 01:38:47 +0000 | [diff] [blame] | 2857 | ExpectedBazelTargets: expectedBazelTargets, |
| 2858 | }) |
| 2859 | } |
| 2860 | |
| 2861 | func TestCcApiSurfaceCombinations(t *testing.T) { |
| 2862 | testCases := []struct { |
| 2863 | bp string |
| 2864 | expectedApi string |
| 2865 | expectedApiSurfaces string |
| 2866 | description string |
| 2867 | }{ |
| 2868 | { |
| 2869 | bp: ` |
| 2870 | cc_library { |
| 2871 | name: "a", |
| 2872 | stubs: {symbol_file: "a.map.txt"}, |
| 2873 | }`, |
| 2874 | expectedApi: `"a.map.txt"`, |
Spandan Das | 627fc3e | 2023-01-26 23:02:00 +0000 | [diff] [blame^] | 2875 | expectedApiSurfaces: `["module-libapi"]`, |
| 2876 | description: "Library that contributes to module-libapi", |
Spandan Das | 4238c65 | 2022-09-09 01:38:47 +0000 | [diff] [blame] | 2877 | }, |
| 2878 | { |
| 2879 | bp: ` |
| 2880 | cc_library { |
| 2881 | name: "a", |
| 2882 | llndk: {symbol_file: "a.map.txt"}, |
| 2883 | }`, |
| 2884 | expectedApi: `"a.map.txt"`, |
| 2885 | expectedApiSurfaces: `["vendorapi"]`, |
| 2886 | description: "Library that contributes to vendorapi", |
| 2887 | }, |
| 2888 | { |
| 2889 | bp: ` |
| 2890 | cc_library { |
| 2891 | name: "a", |
| 2892 | llndk: {symbol_file: "a.map.txt"}, |
| 2893 | stubs: {symbol_file: "a.map.txt"}, |
| 2894 | }`, |
| 2895 | expectedApi: `"a.map.txt"`, |
| 2896 | expectedApiSurfaces: `[ |
Spandan Das | 627fc3e | 2023-01-26 23:02:00 +0000 | [diff] [blame^] | 2897 | "module-libapi", |
Spandan Das | 4238c65 | 2022-09-09 01:38:47 +0000 | [diff] [blame] | 2898 | "vendorapi", |
| 2899 | ]`, |
Spandan Das | 627fc3e | 2023-01-26 23:02:00 +0000 | [diff] [blame^] | 2900 | description: "Library that contributes to module-libapi and vendorapi", |
Spandan Das | 4238c65 | 2022-09-09 01:38:47 +0000 | [diff] [blame] | 2901 | }, |
| 2902 | } |
| 2903 | for _, testCase := range testCases { |
| 2904 | expectedBazelTargets := []string{ |
| 2905 | MakeBazelTarget( |
| 2906 | "cc_api_contribution", |
| 2907 | "a.contribution", |
| 2908 | AttrNameToString{ |
| 2909 | "library_name": `"a"`, |
| 2910 | "hdrs": `[]`, |
| 2911 | "api": testCase.expectedApi, |
| 2912 | "api_surfaces": testCase.expectedApiSurfaces, |
| 2913 | }, |
| 2914 | ), |
| 2915 | } |
| 2916 | RunApiBp2BuildTestCase(t, cc.RegisterLibraryBuildComponents, Bp2buildTestCase{ |
| 2917 | Blueprint: testCase.bp, |
| 2918 | Description: testCase.description, |
| 2919 | ExpectedBazelTargets: expectedBazelTargets, |
| 2920 | }) |
| 2921 | } |
| 2922 | } |
| 2923 | |
| 2924 | // llndk struct property in Soong provides users with several options to configure the exported include dirs |
| 2925 | // Test the generated bazel targets for the different configurations |
| 2926 | func TestCcVendorApiHeaders(t *testing.T) { |
| 2927 | testCases := []struct { |
| 2928 | bp string |
| 2929 | expectedIncludes string |
| 2930 | expectedSystemIncludes string |
| 2931 | description string |
| 2932 | }{ |
| 2933 | { |
| 2934 | bp: ` |
| 2935 | cc_library { |
| 2936 | name: "a", |
| 2937 | export_include_dirs: ["include"], |
| 2938 | export_system_include_dirs: ["base_system_include"], |
| 2939 | llndk: { |
| 2940 | symbol_file: "a.map.txt", |
| 2941 | export_headers_as_system: true, |
| 2942 | }, |
| 2943 | } |
| 2944 | `, |
| 2945 | expectedIncludes: "", |
| 2946 | expectedSystemIncludes: `[ |
| 2947 | "base_system_include", |
| 2948 | "include", |
| 2949 | ]`, |
| 2950 | description: "Headers are exported as system to API surface", |
| 2951 | }, |
| 2952 | { |
| 2953 | bp: ` |
| 2954 | cc_library { |
| 2955 | name: "a", |
| 2956 | export_include_dirs: ["include"], |
| 2957 | export_system_include_dirs: ["base_system_include"], |
| 2958 | llndk: { |
| 2959 | symbol_file: "a.map.txt", |
| 2960 | override_export_include_dirs: ["llndk_include"], |
| 2961 | }, |
| 2962 | } |
| 2963 | `, |
| 2964 | expectedIncludes: `["llndk_include"]`, |
| 2965 | expectedSystemIncludes: `["base_system_include"]`, |
| 2966 | description: "Non-system Headers are ovverriden before export to API surface", |
| 2967 | }, |
| 2968 | { |
| 2969 | bp: ` |
| 2970 | cc_library { |
| 2971 | name: "a", |
| 2972 | export_include_dirs: ["include"], |
| 2973 | export_system_include_dirs: ["base_system_include"], |
| 2974 | llndk: { |
| 2975 | symbol_file: "a.map.txt", |
| 2976 | override_export_include_dirs: ["llndk_include"], |
| 2977 | export_headers_as_system: true, |
| 2978 | }, |
| 2979 | } |
| 2980 | `, |
| 2981 | expectedIncludes: "", // includes are set to nil |
| 2982 | expectedSystemIncludes: `[ |
| 2983 | "base_system_include", |
| 2984 | "llndk_include", |
| 2985 | ]`, |
| 2986 | description: "System Headers are extended before export to API surface", |
| 2987 | }, |
| 2988 | } |
| 2989 | for _, testCase := range testCases { |
| 2990 | attrs := AttrNameToString{} |
| 2991 | if testCase.expectedIncludes != "" { |
| 2992 | attrs["export_includes"] = testCase.expectedIncludes |
| 2993 | } |
| 2994 | if testCase.expectedSystemIncludes != "" { |
| 2995 | attrs["export_system_includes"] = testCase.expectedSystemIncludes |
| 2996 | } |
| 2997 | |
| 2998 | expectedBazelTargets := []string{ |
| 2999 | MakeBazelTarget("cc_api_library_headers", "a.vendorapi.headers", attrs), |
| 3000 | // Create a target for cc_api_contribution target |
| 3001 | MakeBazelTarget("cc_api_contribution", "a.contribution", AttrNameToString{ |
| 3002 | "api": `"a.map.txt"`, |
| 3003 | "api_surfaces": `["vendorapi"]`, |
| 3004 | "hdrs": `[":a.vendorapi.headers"]`, |
| 3005 | "library_name": `"a"`, |
| 3006 | }), |
| 3007 | } |
| 3008 | RunApiBp2BuildTestCase(t, cc.RegisterLibraryBuildComponents, Bp2buildTestCase{ |
| 3009 | Blueprint: testCase.bp, |
| 3010 | ExpectedBazelTargets: expectedBazelTargets, |
| 3011 | }) |
| 3012 | } |
| 3013 | } |
| 3014 | |
Trevor Radcliffe | 0ed6b7d | 2022-09-12 20:19:26 +0000 | [diff] [blame] | 3015 | func TestCcLibraryStubsAcrossConfigsDuplicatesRemoved(t *testing.T) { |
| 3016 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3017 | Description: "stub target generation of the same lib across configs should not result in duplicates", |
| 3018 | ModuleTypeUnderTest: "cc_library", |
| 3019 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3020 | Filesystem: map[string]string{ |
| 3021 | "bar.map.txt": "", |
| 3022 | }, |
| 3023 | Blueprint: ` |
| 3024 | cc_library { |
| 3025 | name: "barlib", |
| 3026 | stubs: { symbol_file: "bar.map.txt", versions: ["28", "29", "current"] }, |
| 3027 | bazel_module: { bp2build_available: false }, |
| 3028 | } |
| 3029 | cc_library { |
| 3030 | name: "foolib", |
| 3031 | shared_libs: ["barlib"], |
| 3032 | target: { |
| 3033 | android: { |
| 3034 | shared_libs: ["barlib"], |
| 3035 | }, |
| 3036 | }, |
| 3037 | bazel_module: { bp2build_available: true }, |
| 3038 | }`, |
| 3039 | ExpectedBazelTargets: makeCcLibraryTargets("foolib", AttrNameToString{ |
| 3040 | "implementation_dynamic_deps": `select({ |
| 3041 | "//build/bazel/rules/apex:android-in_apex": [":barlib_stub_libs_current"], |
| 3042 | "//conditions:default": [":barlib"], |
| 3043 | })`, |
| 3044 | "local_includes": `["."]`, |
| 3045 | }), |
| 3046 | }) |
| 3047 | } |
| 3048 | |
Liz Kammer | ffc17e4 | 2022-11-23 09:42:05 -0500 | [diff] [blame] | 3049 | func TestCcLibraryExcludesLibsHost(t *testing.T) { |
| 3050 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3051 | ModuleTypeUnderTest: "cc_library", |
| 3052 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3053 | Filesystem: map[string]string{ |
| 3054 | "bar.map.txt": "", |
| 3055 | }, |
| 3056 | Blueprint: simpleModuleDoNotConvertBp2build("cc_library", "bazlib") + ` |
| 3057 | cc_library { |
| 3058 | name: "quxlib", |
| 3059 | stubs: { symbol_file: "bar.map.txt", versions: ["current"] }, |
| 3060 | bazel_module: { bp2build_available: false }, |
| 3061 | } |
| 3062 | cc_library { |
| 3063 | name: "barlib", |
| 3064 | stubs: { symbol_file: "bar.map.txt", versions: ["28", "29", "current"] }, |
| 3065 | bazel_module: { bp2build_available: false }, |
| 3066 | } |
| 3067 | cc_library { |
| 3068 | name: "foolib", |
| 3069 | shared_libs: ["barlib", "quxlib"], |
| 3070 | target: { |
| 3071 | host: { |
| 3072 | shared_libs: ["bazlib"], |
| 3073 | exclude_shared_libs: ["barlib"], |
| 3074 | }, |
| 3075 | }, |
| 3076 | include_build_directory: false, |
| 3077 | bazel_module: { bp2build_available: true }, |
| 3078 | }`, |
| 3079 | ExpectedBazelTargets: makeCcLibraryTargets("foolib", AttrNameToString{ |
| 3080 | "implementation_dynamic_deps": `select({ |
| 3081 | "//build/bazel/platforms/os:darwin": [":bazlib"], |
Liz Kammer | ffc17e4 | 2022-11-23 09:42:05 -0500 | [diff] [blame] | 3082 | "//build/bazel/platforms/os:linux_bionic": [":bazlib"], |
Colin Cross | 133782e | 2022-12-20 15:29:31 -0800 | [diff] [blame] | 3083 | "//build/bazel/platforms/os:linux_glibc": [":bazlib"], |
Liz Kammer | ffc17e4 | 2022-11-23 09:42:05 -0500 | [diff] [blame] | 3084 | "//build/bazel/platforms/os:linux_musl": [":bazlib"], |
| 3085 | "//build/bazel/platforms/os:windows": [":bazlib"], |
| 3086 | "//conditions:default": [], |
| 3087 | }) + select({ |
| 3088 | "//build/bazel/platforms/os:darwin": [":quxlib"], |
Liz Kammer | ffc17e4 | 2022-11-23 09:42:05 -0500 | [diff] [blame] | 3089 | "//build/bazel/platforms/os:linux_bionic": [":quxlib"], |
Colin Cross | 133782e | 2022-12-20 15:29:31 -0800 | [diff] [blame] | 3090 | "//build/bazel/platforms/os:linux_glibc": [":quxlib"], |
Liz Kammer | ffc17e4 | 2022-11-23 09:42:05 -0500 | [diff] [blame] | 3091 | "//build/bazel/platforms/os:linux_musl": [":quxlib"], |
| 3092 | "//build/bazel/platforms/os:windows": [":quxlib"], |
| 3093 | "//build/bazel/rules/apex:android-in_apex": [ |
| 3094 | ":barlib_stub_libs_current", |
| 3095 | ":quxlib_stub_libs_current", |
| 3096 | ], |
| 3097 | "//conditions:default": [ |
| 3098 | ":barlib", |
| 3099 | ":quxlib", |
| 3100 | ], |
| 3101 | })`, |
| 3102 | }), |
| 3103 | }) |
| 3104 | } |
| 3105 | |
Liz Kammer | f38a837 | 2022-02-04 15:39:00 -0500 | [diff] [blame] | 3106 | func TestCcLibraryEscapeLdflags(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 3107 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3108 | ModuleTypeUnderTest: "cc_library", |
| 3109 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3110 | Blueprint: soongCcProtoPreamble + `cc_library { |
Liz Kammer | f38a837 | 2022-02-04 15:39:00 -0500 | [diff] [blame] | 3111 | name: "foo", |
| 3112 | ldflags: ["-Wl,--rpath,${ORIGIN}"], |
| 3113 | include_build_directory: false, |
| 3114 | }`, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 3115 | ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{ |
Liz Kammer | f38a837 | 2022-02-04 15:39:00 -0500 | [diff] [blame] | 3116 | "linkopts": `["-Wl,--rpath,$${ORIGIN}"]`, |
| 3117 | }), |
| 3118 | }) |
| 3119 | } |
Trevor Radcliffe | ef9c900 | 2022-05-13 20:55:35 +0000 | [diff] [blame] | 3120 | |
| 3121 | func TestCcLibraryConvertLex(t *testing.T) { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 3122 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3123 | ModuleTypeUnderTest: "cc_library", |
| 3124 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3125 | Filesystem: map[string]string{ |
Trevor Radcliffe | ef9c900 | 2022-05-13 20:55:35 +0000 | [diff] [blame] | 3126 | "foo.c": "", |
| 3127 | "bar.cc": "", |
| 3128 | "foo1.l": "", |
| 3129 | "bar1.ll": "", |
| 3130 | "foo2.l": "", |
| 3131 | "bar2.ll": "", |
| 3132 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 3133 | Blueprint: `cc_library { |
Trevor Radcliffe | ef9c900 | 2022-05-13 20:55:35 +0000 | [diff] [blame] | 3134 | name: "foo_lib", |
| 3135 | srcs: ["foo.c", "bar.cc", "foo1.l", "foo2.l", "bar1.ll", "bar2.ll"], |
| 3136 | lex: { flags: ["--foo_flags"] }, |
| 3137 | include_build_directory: false, |
| 3138 | bazel_module: { bp2build_available: true }, |
| 3139 | }`, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 3140 | ExpectedBazelTargets: append([]string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3141 | MakeBazelTarget("genlex", "foo_lib_genlex_l", AttrNameToString{ |
Trevor Radcliffe | ef9c900 | 2022-05-13 20:55:35 +0000 | [diff] [blame] | 3142 | "srcs": `[ |
| 3143 | "foo1.l", |
| 3144 | "foo2.l", |
| 3145 | ]`, |
| 3146 | "lexopts": `["--foo_flags"]`, |
| 3147 | }), |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3148 | MakeBazelTarget("genlex", "foo_lib_genlex_ll", AttrNameToString{ |
Trevor Radcliffe | ef9c900 | 2022-05-13 20:55:35 +0000 | [diff] [blame] | 3149 | "srcs": `[ |
| 3150 | "bar1.ll", |
| 3151 | "bar2.ll", |
| 3152 | ]`, |
| 3153 | "lexopts": `["--foo_flags"]`, |
| 3154 | }), |
| 3155 | }, |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 3156 | makeCcLibraryTargets("foo_lib", AttrNameToString{ |
Trevor Radcliffe | ef9c900 | 2022-05-13 20:55:35 +0000 | [diff] [blame] | 3157 | "srcs": `[ |
| 3158 | "bar.cc", |
| 3159 | ":foo_lib_genlex_ll", |
| 3160 | ]`, |
| 3161 | "srcs_c": `[ |
| 3162 | "foo.c", |
| 3163 | ":foo_lib_genlex_l", |
| 3164 | ]`, |
| 3165 | })...), |
| 3166 | }) |
| 3167 | } |
Cole Faust | 6b29f59 | 2022-08-09 09:50:56 -0700 | [diff] [blame] | 3168 | |
| 3169 | func TestCCLibraryRuntimeDeps(t *testing.T) { |
| 3170 | runCcLibrarySharedTestCase(t, Bp2buildTestCase{ |
| 3171 | Blueprint: `cc_library_shared { |
| 3172 | name: "bar", |
| 3173 | } |
| 3174 | |
| 3175 | cc_library { |
| 3176 | name: "foo", |
| 3177 | runtime_libs: ["foo"], |
| 3178 | }`, |
| 3179 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3180 | MakeBazelTarget("cc_library_shared", "bar", AttrNameToString{ |
Cole Faust | 6b29f59 | 2022-08-09 09:50:56 -0700 | [diff] [blame] | 3181 | "local_includes": `["."]`, |
| 3182 | }), |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3183 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
Cole Faust | 6b29f59 | 2022-08-09 09:50:56 -0700 | [diff] [blame] | 3184 | "runtime_deps": `[":foo"]`, |
| 3185 | "local_includes": `["."]`, |
| 3186 | }), |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3187 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
Cole Faust | 6b29f59 | 2022-08-09 09:50:56 -0700 | [diff] [blame] | 3188 | "runtime_deps": `[":foo"]`, |
| 3189 | "local_includes": `["."]`, |
| 3190 | }), |
| 3191 | }, |
| 3192 | }) |
| 3193 | } |
Cole Faust | 5fa4e96 | 2022-08-22 14:31:04 -0700 | [diff] [blame] | 3194 | |
| 3195 | func TestCcLibraryWithInstructionSet(t *testing.T) { |
| 3196 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3197 | ModuleTypeUnderTest: "cc_library", |
| 3198 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3199 | Blueprint: `cc_library { |
| 3200 | name: "foo", |
| 3201 | arch: { |
| 3202 | arm: { |
| 3203 | instruction_set: "arm", |
| 3204 | } |
| 3205 | } |
| 3206 | } |
| 3207 | `, |
| 3208 | ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{ |
| 3209 | "features": `select({ |
| 3210 | "//build/bazel/platforms/arch:arm": [ |
| 3211 | "arm_isa_arm", |
| 3212 | "-arm_isa_thumb", |
| 3213 | ], |
| 3214 | "//conditions:default": [], |
| 3215 | })`, |
| 3216 | "local_includes": `["."]`, |
| 3217 | }), |
| 3218 | }) |
| 3219 | } |
Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3220 | |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | a56e970 | 2022-02-23 18:39:59 -0500 | [diff] [blame] | 3221 | func TestCcLibraryEmptySuffix(t *testing.T) { |
| 3222 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3223 | Description: "cc_library with empty suffix", |
| 3224 | ModuleTypeUnderTest: "cc_library", |
| 3225 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3226 | Filesystem: map[string]string{ |
| 3227 | "foo.c": "", |
| 3228 | }, |
| 3229 | Blueprint: `cc_library { |
| 3230 | name: "foo", |
| 3231 | suffix: "", |
| 3232 | srcs: ["foo.c"], |
| 3233 | include_build_directory: false, |
| 3234 | }`, |
| 3235 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3236 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | a56e970 | 2022-02-23 18:39:59 -0500 | [diff] [blame] | 3237 | "srcs_c": `["foo.c"]`, |
| 3238 | }), |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3239 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | a56e970 | 2022-02-23 18:39:59 -0500 | [diff] [blame] | 3240 | "srcs_c": `["foo.c"]`, |
| 3241 | "suffix": `""`, |
| 3242 | }), |
| 3243 | }, |
| 3244 | }) |
| 3245 | } |
| 3246 | |
| 3247 | func TestCcLibrarySuffix(t *testing.T) { |
| 3248 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3249 | Description: "cc_library with suffix", |
| 3250 | ModuleTypeUnderTest: "cc_library", |
| 3251 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3252 | Filesystem: map[string]string{ |
| 3253 | "foo.c": "", |
| 3254 | }, |
| 3255 | Blueprint: `cc_library { |
| 3256 | name: "foo", |
| 3257 | suffix: "-suf", |
| 3258 | srcs: ["foo.c"], |
| 3259 | include_build_directory: false, |
| 3260 | }`, |
| 3261 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3262 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | a56e970 | 2022-02-23 18:39:59 -0500 | [diff] [blame] | 3263 | "srcs_c": `["foo.c"]`, |
| 3264 | }), |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3265 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | a56e970 | 2022-02-23 18:39:59 -0500 | [diff] [blame] | 3266 | "srcs_c": `["foo.c"]`, |
| 3267 | "suffix": `"-suf"`, |
| 3268 | }), |
| 3269 | }, |
| 3270 | }) |
| 3271 | } |
| 3272 | |
| 3273 | func TestCcLibraryArchVariantSuffix(t *testing.T) { |
| 3274 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3275 | Description: "cc_library with arch-variant suffix", |
| 3276 | ModuleTypeUnderTest: "cc_library", |
| 3277 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3278 | Filesystem: map[string]string{ |
| 3279 | "foo.c": "", |
| 3280 | }, |
| 3281 | Blueprint: `cc_library { |
| 3282 | name: "foo", |
| 3283 | arch: { |
| 3284 | arm64: { suffix: "-64" }, |
| 3285 | arm: { suffix: "-32" }, |
| 3286 | }, |
| 3287 | srcs: ["foo.c"], |
| 3288 | include_build_directory: false, |
| 3289 | }`, |
| 3290 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3291 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | a56e970 | 2022-02-23 18:39:59 -0500 | [diff] [blame] | 3292 | "srcs_c": `["foo.c"]`, |
| 3293 | }), |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3294 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | a56e970 | 2022-02-23 18:39:59 -0500 | [diff] [blame] | 3295 | "srcs_c": `["foo.c"]`, |
| 3296 | "suffix": `select({ |
| 3297 | "//build/bazel/platforms/arch:arm": "-32", |
| 3298 | "//build/bazel/platforms/arch:arm64": "-64", |
| 3299 | "//conditions:default": None, |
| 3300 | })`, |
| 3301 | }), |
| 3302 | }, |
| 3303 | }) |
| 3304 | } |
| 3305 | |
Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3306 | func TestCcLibraryWithAidlSrcs(t *testing.T) { |
| 3307 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3308 | Description: "cc_library with aidl srcs", |
| 3309 | ModuleTypeUnderTest: "cc_library", |
| 3310 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3311 | Blueprint: ` |
| 3312 | filegroup { |
| 3313 | name: "A_aidl", |
| 3314 | srcs: ["aidl/A.aidl"], |
| 3315 | path: "aidl", |
| 3316 | } |
| 3317 | cc_library { |
| 3318 | name: "foo", |
| 3319 | srcs: [ |
| 3320 | ":A_aidl", |
| 3321 | "B.aidl", |
| 3322 | ], |
| 3323 | }`, |
| 3324 | ExpectedBazelTargets: []string{ |
| 3325 | MakeBazelTargetNoRestrictions("aidl_library", "A_aidl", AttrNameToString{ |
| 3326 | "srcs": `["aidl/A.aidl"]`, |
| 3327 | "strip_import_prefix": `"aidl"`, |
| 3328 | }), |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3329 | MakeBazelTarget("aidl_library", "foo_aidl_library", AttrNameToString{ |
Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3330 | "srcs": `["B.aidl"]`, |
| 3331 | }), |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3332 | MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{ |
Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3333 | "deps": `[ |
| 3334 | ":A_aidl", |
| 3335 | ":foo_aidl_library", |
| 3336 | ]`, |
| 3337 | }), |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3338 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
Vinh Tran | fde57eb | 2022-08-29 17:46:58 -0400 | [diff] [blame] | 3339 | "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`, |
| 3340 | "local_includes": `["."]`, |
Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3341 | }), |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3342 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
Liz Kammer | 84b0ecb | 2022-09-14 10:49:13 -0400 | [diff] [blame] | 3343 | "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`, |
| 3344 | "local_includes": `["."]`, |
Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3345 | }), |
| 3346 | }, |
| 3347 | }) |
| 3348 | } |
| 3349 | |
| 3350 | func TestCcLibraryWithNonAdjacentAidlFilegroup(t *testing.T) { |
| 3351 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3352 | Description: "cc_library with non aidl filegroup", |
| 3353 | ModuleTypeUnderTest: "cc_library", |
| 3354 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3355 | Filesystem: map[string]string{ |
| 3356 | "path/to/A/Android.bp": ` |
| 3357 | filegroup { |
Vinh Tran | fde57eb | 2022-08-29 17:46:58 -0400 | [diff] [blame] | 3358 | name: "A_aidl", |
| 3359 | srcs: ["aidl/A.aidl"], |
| 3360 | path: "aidl", |
Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3361 | }`, |
| 3362 | }, |
| 3363 | Blueprint: ` |
| 3364 | cc_library { |
Vinh Tran | fde57eb | 2022-08-29 17:46:58 -0400 | [diff] [blame] | 3365 | name: "foo", |
| 3366 | srcs: [ |
| 3367 | ":A_aidl", |
| 3368 | ], |
Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3369 | }`, |
| 3370 | ExpectedBazelTargets: []string{ |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3371 | MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{ |
Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3372 | "deps": `["//path/to/A:A_aidl"]`, |
| 3373 | }), |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3374 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
Vinh Tran | fde57eb | 2022-08-29 17:46:58 -0400 | [diff] [blame] | 3375 | "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`, |
| 3376 | "local_includes": `["."]`, |
| 3377 | }), |
Vinh Tran | fde57eb | 2022-08-29 17:46:58 -0400 | [diff] [blame] | 3378 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
Liz Kammer | 84b0ecb | 2022-09-14 10:49:13 -0400 | [diff] [blame] | 3379 | "local_includes": `["."]`, |
| 3380 | "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`, |
Vinh Tran | fde57eb | 2022-08-29 17:46:58 -0400 | [diff] [blame] | 3381 | }), |
| 3382 | }, |
| 3383 | }) |
| 3384 | } |
| 3385 | |
| 3386 | func TestCcLibraryWithExportAidlHeaders(t *testing.T) { |
| 3387 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3388 | Description: "cc_library with export aidl headers", |
| 3389 | ModuleTypeUnderTest: "cc_library", |
| 3390 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3391 | Blueprint: ` |
| 3392 | cc_library { |
| 3393 | name: "foo", |
| 3394 | srcs: [ |
| 3395 | "Foo.aidl", |
| 3396 | ], |
| 3397 | aidl: { |
| 3398 | export_aidl_headers: true, |
| 3399 | } |
| 3400 | }`, |
| 3401 | ExpectedBazelTargets: []string{ |
| 3402 | MakeBazelTarget("aidl_library", "foo_aidl_library", AttrNameToString{ |
| 3403 | "srcs": `["Foo.aidl"]`, |
| 3404 | }), |
| 3405 | MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{ |
| 3406 | "deps": `[":foo_aidl_library"]`, |
| 3407 | }), |
| 3408 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3409 | "whole_archive_deps": `[":foo_cc_aidl_library"]`, |
| 3410 | "local_includes": `["."]`, |
| 3411 | }), |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 3412 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
Vinh Tran | 9f6796a | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 3413 | "whole_archive_deps": `[":foo_cc_aidl_library"]`, |
| 3414 | "local_includes": `["."]`, |
| 3415 | }), |
| 3416 | }, |
| 3417 | }) |
| 3418 | } |
Vinh Tran | 85fb07c | 2022-09-16 16:17:48 -0400 | [diff] [blame] | 3419 | |
| 3420 | func TestCcLibraryWithTargetApex(t *testing.T) { |
| 3421 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3422 | Description: "cc_library with target.apex", |
| 3423 | ModuleTypeUnderTest: "cc_library", |
| 3424 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3425 | Blueprint: ` |
| 3426 | cc_library { |
| 3427 | name: "foo", |
| 3428 | shared_libs: ["bar", "baz"], |
| 3429 | static_libs: ["baz", "buh"], |
| 3430 | target: { |
| 3431 | apex: { |
| 3432 | exclude_shared_libs: ["bar"], |
| 3433 | exclude_static_libs: ["buh"], |
| 3434 | } |
| 3435 | } |
| 3436 | }`, |
| 3437 | ExpectedBazelTargets: []string{ |
| 3438 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
| 3439 | "implementation_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({ |
Liz Kammer | 748d707 | 2023-01-25 12:07:43 -0500 | [diff] [blame] | 3440 | "//build/bazel/rules/apex:in_apex": [], |
| 3441 | "//conditions:default": [":buh__BP2BUILD__MISSING__DEP"], |
Vinh Tran | 85fb07c | 2022-09-16 16:17:48 -0400 | [diff] [blame] | 3442 | })`, |
| 3443 | "implementation_dynamic_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({ |
Liz Kammer | 748d707 | 2023-01-25 12:07:43 -0500 | [diff] [blame] | 3444 | "//build/bazel/rules/apex:in_apex": [], |
| 3445 | "//conditions:default": [":bar__BP2BUILD__MISSING__DEP"], |
Vinh Tran | 85fb07c | 2022-09-16 16:17:48 -0400 | [diff] [blame] | 3446 | })`, |
| 3447 | "local_includes": `["."]`, |
| 3448 | }), |
| 3449 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
| 3450 | "implementation_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({ |
Liz Kammer | 748d707 | 2023-01-25 12:07:43 -0500 | [diff] [blame] | 3451 | "//build/bazel/rules/apex:in_apex": [], |
| 3452 | "//conditions:default": [":buh__BP2BUILD__MISSING__DEP"], |
Vinh Tran | 85fb07c | 2022-09-16 16:17:48 -0400 | [diff] [blame] | 3453 | })`, |
| 3454 | "implementation_dynamic_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({ |
Liz Kammer | 748d707 | 2023-01-25 12:07:43 -0500 | [diff] [blame] | 3455 | "//build/bazel/rules/apex:in_apex": [], |
| 3456 | "//conditions:default": [":bar__BP2BUILD__MISSING__DEP"], |
Vinh Tran | 85fb07c | 2022-09-16 16:17:48 -0400 | [diff] [blame] | 3457 | })`, |
| 3458 | "local_includes": `["."]`, |
| 3459 | }), |
| 3460 | }, |
| 3461 | }) |
| 3462 | } |
| 3463 | |
| 3464 | func TestCcLibraryWithTargetApexAndExportLibHeaders(t *testing.T) { |
| 3465 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3466 | Description: "cc_library with target.apex and export_shared|static_lib_headers", |
| 3467 | ModuleTypeUnderTest: "cc_library", |
| 3468 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3469 | Blueprint: ` |
| 3470 | cc_library_static { |
| 3471 | name: "foo", |
| 3472 | shared_libs: ["bar", "baz"], |
| 3473 | static_libs: ["abc"], |
| 3474 | export_shared_lib_headers: ["baz"], |
| 3475 | export_static_lib_headers: ["abc"], |
| 3476 | target: { |
| 3477 | apex: { |
| 3478 | exclude_shared_libs: ["baz", "bar"], |
| 3479 | exclude_static_libs: ["abc"], |
| 3480 | } |
| 3481 | } |
| 3482 | }`, |
| 3483 | ExpectedBazelTargets: []string{ |
| 3484 | MakeBazelTarget("cc_library_static", "foo", AttrNameToString{ |
| 3485 | "implementation_dynamic_deps": `select({ |
Liz Kammer | 748d707 | 2023-01-25 12:07:43 -0500 | [diff] [blame] | 3486 | "//build/bazel/rules/apex:in_apex": [], |
| 3487 | "//conditions:default": [":bar__BP2BUILD__MISSING__DEP"], |
Vinh Tran | 85fb07c | 2022-09-16 16:17:48 -0400 | [diff] [blame] | 3488 | })`, |
| 3489 | "dynamic_deps": `select({ |
Liz Kammer | 748d707 | 2023-01-25 12:07:43 -0500 | [diff] [blame] | 3490 | "//build/bazel/rules/apex:in_apex": [], |
| 3491 | "//conditions:default": [":baz__BP2BUILD__MISSING__DEP"], |
Vinh Tran | 85fb07c | 2022-09-16 16:17:48 -0400 | [diff] [blame] | 3492 | })`, |
| 3493 | "deps": `select({ |
Liz Kammer | 748d707 | 2023-01-25 12:07:43 -0500 | [diff] [blame] | 3494 | "//build/bazel/rules/apex:in_apex": [], |
| 3495 | "//conditions:default": [":abc__BP2BUILD__MISSING__DEP"], |
Vinh Tran | 85fb07c | 2022-09-16 16:17:48 -0400 | [diff] [blame] | 3496 | })`, |
| 3497 | "local_includes": `["."]`, |
| 3498 | }), |
| 3499 | }, |
| 3500 | }) |
| 3501 | } |
Trevor Radcliffe | cee4e05 | 2022-09-06 19:31:25 +0000 | [diff] [blame] | 3502 | |
| 3503 | func TestCcLibraryWithSyspropSrcs(t *testing.T) { |
| 3504 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3505 | Description: "cc_library with sysprop sources", |
| 3506 | ModuleTypeUnderTest: "cc_library", |
| 3507 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3508 | Blueprint: ` |
| 3509 | cc_library { |
| 3510 | name: "foo", |
| 3511 | srcs: [ |
| 3512 | "bar.sysprop", |
| 3513 | "baz.sysprop", |
| 3514 | "blah.cpp", |
| 3515 | ], |
| 3516 | min_sdk_version: "5", |
| 3517 | }`, |
| 3518 | ExpectedBazelTargets: []string{ |
| 3519 | MakeBazelTarget("sysprop_library", "foo_sysprop_library", AttrNameToString{ |
| 3520 | "srcs": `[ |
| 3521 | "bar.sysprop", |
| 3522 | "baz.sysprop", |
| 3523 | ]`, |
| 3524 | }), |
| 3525 | MakeBazelTarget("cc_sysprop_library_static", "foo_cc_sysprop_library_static", AttrNameToString{ |
| 3526 | "dep": `":foo_sysprop_library"`, |
| 3527 | "min_sdk_version": `"5"`, |
| 3528 | }), |
| 3529 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
| 3530 | "srcs": `["blah.cpp"]`, |
| 3531 | "local_includes": `["."]`, |
| 3532 | "min_sdk_version": `"5"`, |
| 3533 | "whole_archive_deps": `[":foo_cc_sysprop_library_static"]`, |
| 3534 | }), |
| 3535 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
| 3536 | "srcs": `["blah.cpp"]`, |
| 3537 | "local_includes": `["."]`, |
| 3538 | "min_sdk_version": `"5"`, |
| 3539 | "whole_archive_deps": `[":foo_cc_sysprop_library_static"]`, |
| 3540 | }), |
| 3541 | }, |
| 3542 | }) |
| 3543 | } |
| 3544 | |
| 3545 | func TestCcLibraryWithSyspropSrcsSomeConfigs(t *testing.T) { |
| 3546 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3547 | Description: "cc_library with sysprop sources in some configs but not others", |
| 3548 | ModuleTypeUnderTest: "cc_library", |
| 3549 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3550 | Blueprint: ` |
| 3551 | cc_library { |
| 3552 | name: "foo", |
| 3553 | host_supported: true, |
| 3554 | srcs: [ |
| 3555 | "blah.cpp", |
| 3556 | ], |
| 3557 | target: { |
| 3558 | android: { |
| 3559 | srcs: ["bar.sysprop"], |
| 3560 | }, |
| 3561 | }, |
| 3562 | min_sdk_version: "5", |
| 3563 | }`, |
| 3564 | ExpectedBazelTargets: []string{ |
| 3565 | MakeBazelTargetNoRestrictions("sysprop_library", "foo_sysprop_library", AttrNameToString{ |
| 3566 | "srcs": `select({ |
| 3567 | "//build/bazel/platforms/os:android": ["bar.sysprop"], |
| 3568 | "//conditions:default": [], |
| 3569 | })`, |
| 3570 | }), |
| 3571 | MakeBazelTargetNoRestrictions("cc_sysprop_library_static", "foo_cc_sysprop_library_static", AttrNameToString{ |
| 3572 | "dep": `":foo_sysprop_library"`, |
| 3573 | "min_sdk_version": `"5"`, |
| 3574 | }), |
| 3575 | MakeBazelTargetNoRestrictions("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
| 3576 | "srcs": `["blah.cpp"]`, |
| 3577 | "local_includes": `["."]`, |
| 3578 | "min_sdk_version": `"5"`, |
| 3579 | "whole_archive_deps": `select({ |
| 3580 | "//build/bazel/platforms/os:android": [":foo_cc_sysprop_library_static"], |
| 3581 | "//conditions:default": [], |
| 3582 | })`, |
| 3583 | }), |
| 3584 | MakeBazelTargetNoRestrictions("cc_library_shared", "foo", AttrNameToString{ |
| 3585 | "srcs": `["blah.cpp"]`, |
| 3586 | "local_includes": `["."]`, |
| 3587 | "min_sdk_version": `"5"`, |
| 3588 | "whole_archive_deps": `select({ |
| 3589 | "//build/bazel/platforms/os:android": [":foo_cc_sysprop_library_static"], |
| 3590 | "//conditions:default": [], |
| 3591 | })`, |
| 3592 | }), |
| 3593 | }, |
| 3594 | }) |
| 3595 | } |
Vinh Tran | 395a1e9 | 2022-09-16 18:27:29 -0400 | [diff] [blame] | 3596 | |
| 3597 | func TestCcLibraryWithAidlAndSharedLibs(t *testing.T) { |
| 3598 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3599 | Description: "cc_aidl_library depends on shared libs from parent cc_library_static", |
| 3600 | ModuleTypeUnderTest: "cc_library", |
| 3601 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3602 | Blueprint: ` |
| 3603 | cc_library_static { |
| 3604 | name: "foo", |
| 3605 | srcs: [ |
| 3606 | "Foo.aidl", |
| 3607 | ], |
| 3608 | shared_libs: [ |
| 3609 | "bar", |
| 3610 | "baz", |
| 3611 | ], |
| 3612 | export_shared_lib_headers: [ |
| 3613 | "baz", |
| 3614 | ], |
| 3615 | }` + |
| 3616 | simpleModuleDoNotConvertBp2build("cc_library", "bar") + |
| 3617 | simpleModuleDoNotConvertBp2build("cc_library", "baz"), |
| 3618 | ExpectedBazelTargets: []string{ |
| 3619 | MakeBazelTarget("aidl_library", "foo_aidl_library", AttrNameToString{ |
| 3620 | "srcs": `["Foo.aidl"]`, |
| 3621 | }), |
| 3622 | MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{ |
| 3623 | "deps": `[":foo_aidl_library"]`, |
| 3624 | "implementation_dynamic_deps": `[ |
| 3625 | ":baz", |
| 3626 | ":bar", |
| 3627 | ]`, |
| 3628 | }), |
| 3629 | MakeBazelTarget("cc_library_static", "foo", AttrNameToString{ |
| 3630 | "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`, |
| 3631 | "dynamic_deps": `[":baz"]`, |
| 3632 | "implementation_dynamic_deps": `[":bar"]`, |
| 3633 | "local_includes": `["."]`, |
| 3634 | }), |
| 3635 | }, |
| 3636 | }) |
| 3637 | } |
Sam Delmerico | c9b8fbd | 2022-10-25 15:47:17 -0400 | [diff] [blame] | 3638 | |
| 3639 | func TestCcLibraryWithTidy(t *testing.T) { |
| 3640 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3641 | Description: "cc_library uses tidy properties", |
| 3642 | ModuleTypeUnderTest: "cc_library", |
| 3643 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3644 | Blueprint: ` |
| 3645 | cc_library_static { |
| 3646 | name: "foo", |
| 3647 | srcs: ["foo.cpp"], |
| 3648 | tidy: true, |
| 3649 | tidy_checks: ["check1", "check2"], |
| 3650 | tidy_checks_as_errors: ["check1error", "check2error"], |
| 3651 | tidy_disabled_srcs: ["bar.cpp"], |
Sam Delmerico | 4c902d6 | 2022-11-02 14:17:15 -0400 | [diff] [blame] | 3652 | tidy_timeout_srcs: ["baz.cpp"], |
Sam Delmerico | c9b8fbd | 2022-10-25 15:47:17 -0400 | [diff] [blame] | 3653 | }`, |
| 3654 | ExpectedBazelTargets: []string{ |
| 3655 | MakeBazelTarget("cc_library_static", "foo", AttrNameToString{ |
| 3656 | "local_includes": `["."]`, |
| 3657 | "srcs": `["foo.cpp"]`, |
| 3658 | "tidy": `True`, |
| 3659 | "tidy_checks": `[ |
| 3660 | "check1", |
| 3661 | "check2", |
| 3662 | ]`, |
| 3663 | "tidy_checks_as_errors": `[ |
| 3664 | "check1error", |
| 3665 | "check2error", |
| 3666 | ]`, |
| 3667 | "tidy_disabled_srcs": `["bar.cpp"]`, |
Sam Delmerico | 4c902d6 | 2022-11-02 14:17:15 -0400 | [diff] [blame] | 3668 | "tidy_timeout_srcs": `["baz.cpp"]`, |
Sam Delmerico | c9b8fbd | 2022-10-25 15:47:17 -0400 | [diff] [blame] | 3669 | }), |
| 3670 | }, |
| 3671 | }) |
| 3672 | } |
Yu Liu | 56ccb1a | 2022-11-12 10:47:07 -0800 | [diff] [blame] | 3673 | |
Vinh Tran | 99270ea | 2022-11-28 11:15:23 -0500 | [diff] [blame] | 3674 | func TestCcLibraryWithAfdoEnabled(t *testing.T) { |
| 3675 | bp := ` |
| 3676 | cc_library { |
| 3677 | name: "foo", |
| 3678 | afdo: true, |
| 3679 | include_build_directory: false, |
| 3680 | }` |
| 3681 | |
| 3682 | // TODO(b/260714900): Add test case for arch-specific afdo profile |
| 3683 | testCases := []struct { |
| 3684 | description string |
| 3685 | filesystem map[string]string |
| 3686 | expectedBazelTargets []string |
| 3687 | }{ |
| 3688 | { |
| 3689 | description: "cc_library with afdo enabled and existing profile", |
Vinh Tran | bc9c8b4 | 2022-12-09 12:03:52 -0500 | [diff] [blame] | 3690 | filesystem: map[string]string{ |
| 3691 | "vendor/google_data/pgo_profile/sampling/BUILD": "", |
| 3692 | "vendor/google_data/pgo_profile/sampling/foo.afdo": "", |
| 3693 | }, |
Vinh Tran | 99270ea | 2022-11-28 11:15:23 -0500 | [diff] [blame] | 3694 | expectedBazelTargets: []string{ |
| 3695 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}), |
| 3696 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
| 3697 | "fdo_profile": `"//vendor/google_data/pgo_profile/sampling:foo"`, |
| 3698 | }), |
| 3699 | }, |
| 3700 | }, |
| 3701 | { |
| 3702 | description: "cc_library with afdo enabled and existing profile in AOSP", |
Vinh Tran | bc9c8b4 | 2022-12-09 12:03:52 -0500 | [diff] [blame] | 3703 | filesystem: map[string]string{ |
| 3704 | "toolchain/pgo-profiles/sampling/BUILD": "", |
| 3705 | "toolchain/pgo-profiles/sampling/foo.afdo": "", |
| 3706 | }, |
Vinh Tran | 99270ea | 2022-11-28 11:15:23 -0500 | [diff] [blame] | 3707 | expectedBazelTargets: []string{ |
| 3708 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}), |
| 3709 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
| 3710 | "fdo_profile": `"//toolchain/pgo-profiles/sampling:foo"`, |
| 3711 | }), |
| 3712 | }, |
| 3713 | }, |
| 3714 | { |
| 3715 | description: "cc_library with afdo enabled but profile filename doesn't match with module name", |
Vinh Tran | bc9c8b4 | 2022-12-09 12:03:52 -0500 | [diff] [blame] | 3716 | filesystem: map[string]string{ |
| 3717 | "toolchain/pgo-profiles/sampling/BUILD": "", |
| 3718 | "toolchain/pgo-profiles/sampling/bar.afdo": "", |
| 3719 | }, |
Vinh Tran | 99270ea | 2022-11-28 11:15:23 -0500 | [diff] [blame] | 3720 | expectedBazelTargets: []string{ |
| 3721 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}), |
| 3722 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{}), |
| 3723 | }, |
| 3724 | }, |
| 3725 | { |
| 3726 | description: "cc_library with afdo enabled but profile doesn't exist", |
| 3727 | expectedBazelTargets: []string{ |
| 3728 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}), |
| 3729 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{}), |
| 3730 | }, |
| 3731 | }, |
Vinh Tran | bc9c8b4 | 2022-12-09 12:03:52 -0500 | [diff] [blame] | 3732 | { |
| 3733 | description: "cc_library with afdo enabled and existing profile but BUILD file doesn't exist", |
| 3734 | filesystem: map[string]string{ |
| 3735 | "vendor/google_data/pgo_profile/sampling/foo.afdo": "", |
| 3736 | }, |
| 3737 | expectedBazelTargets: []string{ |
| 3738 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}), |
| 3739 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{}), |
| 3740 | }, |
| 3741 | }, |
Vinh Tran | 99270ea | 2022-11-28 11:15:23 -0500 | [diff] [blame] | 3742 | } |
| 3743 | for _, testCase := range testCases { |
| 3744 | t.Run(testCase.description, func(t *testing.T) { |
| 3745 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3746 | ExpectedBazelTargets: testCase.expectedBazelTargets, |
| 3747 | ModuleTypeUnderTest: "cc_library", |
| 3748 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3749 | Description: testCase.description, |
| 3750 | Blueprint: binaryReplacer.Replace(bp), |
| 3751 | Filesystem: testCase.filesystem, |
| 3752 | }) |
| 3753 | }) |
| 3754 | } |
| 3755 | } |
| 3756 | |
Yu Liu | 56ccb1a | 2022-11-12 10:47:07 -0800 | [diff] [blame] | 3757 | func TestCcLibraryHeaderAbiChecker(t *testing.T) { |
| 3758 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3759 | Description: "cc_library with header abi checker", |
| 3760 | ModuleTypeUnderTest: "cc_library", |
| 3761 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3762 | Blueprint: `cc_library { |
| 3763 | name: "foo", |
| 3764 | header_abi_checker: { |
| 3765 | enabled: true, |
| 3766 | symbol_file: "a.map.txt", |
| 3767 | exclude_symbol_versions: [ |
| 3768 | "29", |
| 3769 | "30", |
| 3770 | ], |
| 3771 | exclude_symbol_tags: [ |
| 3772 | "tag1", |
| 3773 | "tag2", |
| 3774 | ], |
| 3775 | check_all_apis: true, |
| 3776 | diff_flags: ["-allow-adding-removing-weak-symbols"], |
| 3777 | }, |
| 3778 | include_build_directory: false, |
| 3779 | }`, |
| 3780 | ExpectedBazelTargets: []string{ |
| 3781 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}), |
| 3782 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
| 3783 | "abi_checker_enabled": `True`, |
| 3784 | "abi_checker_symbol_file": `"a.map.txt"`, |
| 3785 | "abi_checker_exclude_symbol_versions": `[ |
| 3786 | "29", |
| 3787 | "30", |
| 3788 | ]`, |
| 3789 | "abi_checker_exclude_symbol_tags": `[ |
| 3790 | "tag1", |
| 3791 | "tag2", |
| 3792 | ]`, |
| 3793 | "abi_checker_check_all_apis": `True`, |
| 3794 | "abi_checker_diff_flags": `["-allow-adding-removing-weak-symbols"]`, |
| 3795 | }), |
| 3796 | }, |
| 3797 | }) |
| 3798 | } |
Jingwen Chen | c4c34e1 | 2022-11-29 12:07:45 +0000 | [diff] [blame] | 3799 | |
| 3800 | func TestCcLibraryApexAvailable(t *testing.T) { |
| 3801 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3802 | Description: "cc_library apex_available converted to tags", |
| 3803 | ModuleTypeUnderTest: "cc_library", |
| 3804 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3805 | Blueprint: soongCcLibraryPreamble + ` |
| 3806 | cc_library { |
| 3807 | name: "a", |
| 3808 | srcs: ["a.cpp"], |
| 3809 | apex_available: ["com.android.foo"], |
| 3810 | } |
| 3811 | `, |
| 3812 | ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{ |
| 3813 | "tags": `["apex_available=com.android.foo"]`, |
| 3814 | "srcs": `["a.cpp"]`, |
| 3815 | "local_includes": `["."]`, |
| 3816 | }), |
| 3817 | }, |
| 3818 | ) |
| 3819 | } |
| 3820 | |
| 3821 | func TestCcLibraryApexAvailableMultiple(t *testing.T) { |
| 3822 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3823 | Description: "cc_library apex_available converted to multiple tags", |
| 3824 | ModuleTypeUnderTest: "cc_library", |
| 3825 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3826 | Blueprint: soongCcLibraryPreamble + ` |
| 3827 | cc_library { |
| 3828 | name: "a", |
| 3829 | srcs: ["a.cpp"], |
| 3830 | apex_available: ["com.android.foo", "//apex_available:platform", "com.android.bar"], |
| 3831 | } |
| 3832 | `, |
| 3833 | ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{ |
| 3834 | "tags": `[ |
| 3835 | "apex_available=com.android.foo", |
| 3836 | "apex_available=//apex_available:platform", |
| 3837 | "apex_available=com.android.bar", |
| 3838 | ]`, |
| 3839 | "srcs": `["a.cpp"]`, |
| 3840 | "local_includes": `["."]`, |
| 3841 | }), |
| 3842 | }, |
| 3843 | ) |
| 3844 | } |
Zi Wang | 0f82844 | 2022-12-28 11:18:11 -0800 | [diff] [blame] | 3845 | |
| 3846 | // Export_include_dirs and Export_system_include_dirs have "variant_prepend" tag. |
| 3847 | // In bp2build output, variant info(select) should go before general info. |
| 3848 | // Internal order of the property should be unchanged. (e.g. ["eid1", "eid2"]) |
| 3849 | func TestCcLibraryVariantPrependPropOrder(t *testing.T) { |
| 3850 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3851 | Description: "cc_library variant prepend properties order", |
| 3852 | ModuleTypeUnderTest: "cc_library", |
| 3853 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3854 | Blueprint: soongCcLibraryPreamble + ` |
| 3855 | cc_library { |
| 3856 | name: "a", |
| 3857 | srcs: ["a.cpp"], |
| 3858 | export_include_dirs: ["eid1", "eid2"], |
| 3859 | export_system_include_dirs: ["esid1", "esid2"], |
| 3860 | target: { |
| 3861 | android: { |
| 3862 | export_include_dirs: ["android_eid1", "android_eid2"], |
| 3863 | export_system_include_dirs: ["android_esid1", "android_esid2"], |
| 3864 | }, |
| 3865 | android_arm: { |
| 3866 | export_include_dirs: ["android_arm_eid1", "android_arm_eid2"], |
| 3867 | export_system_include_dirs: ["android_arm_esid1", "android_arm_esid2"], |
| 3868 | }, |
| 3869 | linux: { |
| 3870 | export_include_dirs: ["linux_eid1", "linux_eid2"], |
| 3871 | export_system_include_dirs: ["linux_esid1", "linux_esid2"], |
| 3872 | }, |
| 3873 | }, |
| 3874 | multilib: { |
| 3875 | lib32: { |
| 3876 | export_include_dirs: ["lib32_eid1", "lib32_eid2"], |
| 3877 | export_system_include_dirs: ["lib32_esid1", "lib32_esid2"], |
| 3878 | }, |
| 3879 | }, |
| 3880 | arch: { |
| 3881 | arm: { |
| 3882 | export_include_dirs: ["arm_eid1", "arm_eid2"], |
| 3883 | export_system_include_dirs: ["arm_esid1", "arm_esid2"], |
| 3884 | }, |
| 3885 | } |
| 3886 | } |
| 3887 | `, |
| 3888 | ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{ |
| 3889 | "export_includes": `select({ |
| 3890 | "//build/bazel/platforms/os_arch:android_arm": [ |
| 3891 | "android_arm_eid1", |
| 3892 | "android_arm_eid2", |
| 3893 | ], |
| 3894 | "//conditions:default": [], |
| 3895 | }) + select({ |
| 3896 | "//build/bazel/platforms/os:android": [ |
| 3897 | "android_eid1", |
| 3898 | "android_eid2", |
| 3899 | "linux_eid1", |
| 3900 | "linux_eid2", |
| 3901 | ], |
| 3902 | "//build/bazel/platforms/os:linux_bionic": [ |
| 3903 | "linux_eid1", |
| 3904 | "linux_eid2", |
| 3905 | ], |
| 3906 | "//build/bazel/platforms/os:linux_glibc": [ |
| 3907 | "linux_eid1", |
| 3908 | "linux_eid2", |
| 3909 | ], |
| 3910 | "//build/bazel/platforms/os:linux_musl": [ |
| 3911 | "linux_eid1", |
| 3912 | "linux_eid2", |
| 3913 | ], |
| 3914 | "//conditions:default": [], |
| 3915 | }) + select({ |
| 3916 | "//build/bazel/platforms/arch:arm": [ |
| 3917 | "lib32_eid1", |
| 3918 | "lib32_eid2", |
| 3919 | "arm_eid1", |
| 3920 | "arm_eid2", |
| 3921 | ], |
| 3922 | "//build/bazel/platforms/arch:x86": [ |
| 3923 | "lib32_eid1", |
| 3924 | "lib32_eid2", |
| 3925 | ], |
| 3926 | "//conditions:default": [], |
| 3927 | }) + [ |
| 3928 | "eid1", |
| 3929 | "eid2", |
| 3930 | ]`, |
| 3931 | "export_system_includes": `select({ |
| 3932 | "//build/bazel/platforms/os_arch:android_arm": [ |
| 3933 | "android_arm_esid1", |
| 3934 | "android_arm_esid2", |
| 3935 | ], |
| 3936 | "//conditions:default": [], |
| 3937 | }) + select({ |
| 3938 | "//build/bazel/platforms/os:android": [ |
| 3939 | "android_esid1", |
| 3940 | "android_esid2", |
| 3941 | "linux_esid1", |
| 3942 | "linux_esid2", |
| 3943 | ], |
| 3944 | "//build/bazel/platforms/os:linux_bionic": [ |
| 3945 | "linux_esid1", |
| 3946 | "linux_esid2", |
| 3947 | ], |
| 3948 | "//build/bazel/platforms/os:linux_glibc": [ |
| 3949 | "linux_esid1", |
| 3950 | "linux_esid2", |
| 3951 | ], |
| 3952 | "//build/bazel/platforms/os:linux_musl": [ |
| 3953 | "linux_esid1", |
| 3954 | "linux_esid2", |
| 3955 | ], |
| 3956 | "//conditions:default": [], |
| 3957 | }) + select({ |
| 3958 | "//build/bazel/platforms/arch:arm": [ |
| 3959 | "lib32_esid1", |
| 3960 | "lib32_esid2", |
| 3961 | "arm_esid1", |
| 3962 | "arm_esid2", |
| 3963 | ], |
| 3964 | "//build/bazel/platforms/arch:x86": [ |
| 3965 | "lib32_esid1", |
| 3966 | "lib32_esid2", |
| 3967 | ], |
| 3968 | "//conditions:default": [], |
| 3969 | }) + [ |
| 3970 | "esid1", |
| 3971 | "esid2", |
| 3972 | ]`, |
| 3973 | "srcs": `["a.cpp"]`, |
| 3974 | "local_includes": `["."]`, |
| 3975 | "target_compatible_with": `["//build/bazel/platforms/os:android"]`, |
| 3976 | }), |
| 3977 | }, |
| 3978 | ) |
| 3979 | } |
Trevor Radcliffe | db7e026 | 2022-10-28 16:48:18 +0000 | [diff] [blame] | 3980 | |
| 3981 | func TestCcLibraryWithIntegerOverflowProperty(t *testing.T) { |
| 3982 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 3983 | Description: "cc_library has correct features when integer_overflow property is provided", |
| 3984 | ModuleTypeUnderTest: "cc_library", |
| 3985 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 3986 | Blueprint: ` |
| 3987 | cc_library { |
| 3988 | name: "foo", |
| 3989 | sanitize: { |
| 3990 | integer_overflow: true, |
| 3991 | }, |
| 3992 | } |
| 3993 | `, |
| 3994 | ExpectedBazelTargets: []string{ |
| 3995 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
| 3996 | "features": `["ubsan_integer_overflow"]`, |
| 3997 | "local_includes": `["."]`, |
| 3998 | }), |
| 3999 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
| 4000 | "features": `["ubsan_integer_overflow"]`, |
| 4001 | "local_includes": `["."]`, |
| 4002 | }), |
| 4003 | }, |
| 4004 | }) |
| 4005 | } |
| 4006 | |
| 4007 | func TestCcLibraryWithMiscUndefinedProperty(t *testing.T) { |
| 4008 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 4009 | Description: "cc_library has correct features when misc_undefined property is provided", |
| 4010 | ModuleTypeUnderTest: "cc_library", |
| 4011 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 4012 | Blueprint: ` |
| 4013 | cc_library { |
| 4014 | name: "foo", |
| 4015 | sanitize: { |
| 4016 | misc_undefined: ["undefined", "nullability"], |
| 4017 | }, |
| 4018 | } |
| 4019 | `, |
| 4020 | ExpectedBazelTargets: []string{ |
| 4021 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
| 4022 | "features": `[ |
| 4023 | "ubsan_undefined", |
| 4024 | "ubsan_nullability", |
| 4025 | ]`, |
| 4026 | "local_includes": `["."]`, |
| 4027 | }), |
| 4028 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
| 4029 | "features": `[ |
| 4030 | "ubsan_undefined", |
| 4031 | "ubsan_nullability", |
| 4032 | ]`, |
| 4033 | "local_includes": `["."]`, |
| 4034 | }), |
| 4035 | }, |
| 4036 | }) |
| 4037 | } |
| 4038 | |
| 4039 | func TestCcLibraryWithUBSanPropertiesArchSpecific(t *testing.T) { |
| 4040 | runCcLibraryTestCase(t, Bp2buildTestCase{ |
| 4041 | Description: "cc_library has correct feature select when UBSan props are specified in arch specific blocks", |
| 4042 | ModuleTypeUnderTest: "cc_library", |
| 4043 | ModuleTypeUnderTestFactory: cc.LibraryFactory, |
| 4044 | Blueprint: ` |
| 4045 | cc_library { |
| 4046 | name: "foo", |
| 4047 | sanitize: { |
| 4048 | misc_undefined: ["undefined", "nullability"], |
| 4049 | }, |
| 4050 | target: { |
| 4051 | android: { |
| 4052 | sanitize: { |
| 4053 | misc_undefined: ["alignment"], |
| 4054 | }, |
| 4055 | }, |
| 4056 | linux_glibc: { |
| 4057 | sanitize: { |
| 4058 | integer_overflow: true, |
| 4059 | }, |
| 4060 | }, |
| 4061 | }, |
| 4062 | } |
| 4063 | `, |
| 4064 | ExpectedBazelTargets: []string{ |
| 4065 | MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{ |
| 4066 | "features": `[ |
| 4067 | "ubsan_undefined", |
| 4068 | "ubsan_nullability", |
| 4069 | ] + select({ |
| 4070 | "//build/bazel/platforms/os:android": ["ubsan_alignment"], |
| 4071 | "//build/bazel/platforms/os:linux_glibc": ["ubsan_integer_overflow"], |
| 4072 | "//conditions:default": [], |
| 4073 | })`, |
| 4074 | "local_includes": `["."]`, |
| 4075 | }), |
| 4076 | MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ |
| 4077 | "features": `[ |
| 4078 | "ubsan_undefined", |
| 4079 | "ubsan_nullability", |
| 4080 | ] + select({ |
| 4081 | "//build/bazel/platforms/os:android": ["ubsan_alignment"], |
| 4082 | "//build/bazel/platforms/os:linux_glibc": ["ubsan_integer_overflow"], |
| 4083 | "//conditions:default": [], |
| 4084 | })`, |
| 4085 | "local_includes": `["."]`, |
| 4086 | }), |
| 4087 | }, |
| 4088 | }) |
| 4089 | } |