blob: c26ffa7f797af53cfd39c23c3e293c5187028403 [file] [log] [blame]
Jingwen Chen63930982021-03-24 10:04:33 -04001// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package bp2build
16
17import (
Jingwen Chen6ada5892021-09-17 11:38:09 +000018 "fmt"
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux1c92aef2021-08-23 16:10:00 +000019 "testing"
20
Jingwen Chen63930982021-03-24 10:04:33 -040021 "android/soong/android"
22 "android/soong/cc"
Jingwen Chen63930982021-03-24 10:04:33 -040023)
24
25const (
26 // See cc/testing.go for more context
27 soongCcLibraryPreamble = `
28cc_defaults {
Liz Kammer8337ea42021-09-10 10:06:32 -040029 name: "linux_bionic_supported",
Liz Kammerbaced712022-09-16 09:01:29 -040030}
31`
32
33 soongCcVersionLibBpPath = "build/soong/cc/libbuildversion/Android.bp"
34 soongCcVersionLibBp = `
35cc_library_static {
36 name: "libbuildversion",
37 bazel_module: { bp2build_available: false },
38}
39`
Liz Kammer12615db2021-09-28 09:19:17 -040040
41 soongCcProtoLibraries = `
42cc_library {
43 name: "libprotobuf-cpp-lite",
44 bazel_module: { bp2build_available: false },
45}
46
47cc_library {
48 name: "libprotobuf-cpp-full",
49 bazel_module: { bp2build_available: false },
50}`
51
52 soongCcProtoPreamble = soongCcLibraryPreamble + soongCcProtoLibraries
Jingwen Chen63930982021-03-24 10:04:33 -040053)
54
Sam Delmerico3177a6e2022-06-21 19:28:33 +000055func runCcLibraryTestCase(t *testing.T, tc Bp2buildTestCase) {
Liz Kammere4982e82021-05-25 10:39:35 -040056 t.Helper()
Sam Delmerico3177a6e2022-06-21 19:28:33 +000057 RunBp2BuildTestCase(t, registerCcLibraryModuleTypes, tc)
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020058}
59
60func registerCcLibraryModuleTypes(ctx android.RegistrationContext) {
61 cc.RegisterCCBuildComponents(ctx)
Jingwen Chen14a8bda2021-06-02 11:10:02 +000062 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020063 ctx.RegisterModuleType("cc_library_static", cc.LibraryStaticFactory)
Liz Kammer2d7bbe32021-06-10 18:20:06 -040064 ctx.RegisterModuleType("cc_prebuilt_library_static", cc.PrebuiltStaticLibraryFactory)
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020065 ctx.RegisterModuleType("cc_library_headers", cc.LibraryHeaderFactory)
66}
67
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020068func TestCcLibrarySimple(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +000069 runCcLibraryTestCase(t, Bp2buildTestCase{
70 Description: "cc_library - simple example",
71 ModuleTypeUnderTest: "cc_library",
72 ModuleTypeUnderTestFactory: cc.LibraryFactory,
73 Filesystem: map[string]string{
Liz Kammerbaced712022-09-16 09:01:29 -040074 soongCcVersionLibBpPath: soongCcVersionLibBp,
75 "android.cpp": "",
76 "bionic.cpp": "",
77 "darwin.cpp": "",
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020078 // Refer to cc.headerExts for the supported header extensions in Soong.
79 "header.h": "",
80 "header.hh": "",
81 "header.hpp": "",
82 "header.hxx": "",
83 "header.h++": "",
84 "header.inl": "",
85 "header.inc": "",
86 "header.ipp": "",
87 "header.h.generic": "",
88 "impl.cpp": "",
89 "linux.cpp": "",
90 "x86.cpp": "",
91 "x86_64.cpp": "",
92 "foo-dir/a.h": "",
93 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +000094 Blueprint: soongCcLibraryPreamble +
Liz Kammer78cfdaa2021-11-08 12:56:31 -050095 simpleModuleDoNotConvertBp2build("cc_library_headers", "some-headers") + `
Jingwen Chen63930982021-03-24 10:04:33 -040096cc_library {
97 name: "foo-lib",
98 srcs: ["impl.cpp"],
99 cflags: ["-Wall"],
100 header_libs: ["some-headers"],
101 export_include_dirs: ["foo-dir"],
102 ldflags: ["-Wl,--exclude-libs=bar.a"],
103 arch: {
104 x86: {
105 ldflags: ["-Wl,--exclude-libs=baz.a"],
106 srcs: ["x86.cpp"],
107 },
108 x86_64: {
109 ldflags: ["-Wl,--exclude-libs=qux.a"],
110 srcs: ["x86_64.cpp"],
111 },
112 },
113 target: {
114 android: {
115 srcs: ["android.cpp"],
116 },
117 linux_glibc: {
118 srcs: ["linux.cpp"],
119 },
120 darwin: {
121 srcs: ["darwin.cpp"],
122 },
Liz Kammer01a16e82021-07-16 16:33:47 -0400123 bionic: {
124 srcs: ["bionic.cpp"]
125 },
Jingwen Chen63930982021-03-24 10:04:33 -0400126 },
Liz Kammer8337ea42021-09-10 10:06:32 -0400127 include_build_directory: false,
Yu Liufc603162022-03-01 15:44:08 -0800128 sdk_version: "current",
129 min_sdk_version: "29",
Yu Liua79c9462022-03-22 16:35:22 -0700130 use_version_lib: true,
Jingwen Chen63930982021-03-24 10:04:33 -0400131}
132`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000133 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500134 "copts": `["-Wall"]`,
135 "export_includes": `["foo-dir"]`,
136 "implementation_deps": `[":some-headers"]`,
137 "linkopts": `["-Wl,--exclude-libs=bar.a"] + select({
Jingwen Chened9c17d2021-04-13 07:14:55 +0000138 "//build/bazel/platforms/arch:x86": ["-Wl,--exclude-libs=baz.a"],
139 "//build/bazel/platforms/arch:x86_64": ["-Wl,--exclude-libs=qux.a"],
140 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500141 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500142 "srcs": `["impl.cpp"] + select({
Jingwen Chenb4628eb2021-04-08 14:40:57 +0000143 "//build/bazel/platforms/arch:x86": ["x86.cpp"],
144 "//build/bazel/platforms/arch:x86_64": ["x86_64.cpp"],
Jingwen Chen63930982021-03-24 10:04:33 -0400145 "//conditions:default": [],
146 }) + select({
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400147 "//build/bazel/platforms/os:android": [
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400148 "bionic.cpp",
Liz Kammerfdd72e62021-10-11 15:41:03 -0400149 "android.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400150 ],
Jingwen Chenb4628eb2021-04-08 14:40:57 +0000151 "//build/bazel/platforms/os:darwin": ["darwin.cpp"],
152 "//build/bazel/platforms/os:linux": ["linux.cpp"],
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400153 "//build/bazel/platforms/os:linux_bionic": ["bionic.cpp"],
Liz Kammer01a16e82021-07-16 16:33:47 -0400154 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500155 })`,
Liz Kammerbaced712022-09-16 09:01:29 -0400156 "sdk_version": `"current"`,
157 "min_sdk_version": `"29"`,
158 "use_version_lib": `True`,
159 "implementation_whole_archive_deps": `["//build/soong/cc/libbuildversion:libbuildversion"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500160 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500161 })
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200162}
163
164func TestCcLibraryTrimmedLdAndroid(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000165 runCcLibraryTestCase(t, Bp2buildTestCase{
166 Description: "cc_library - trimmed example of //bionic/linker:ld-android",
167 ModuleTypeUnderTest: "cc_library",
168 ModuleTypeUnderTestFactory: cc.LibraryFactory,
169 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200170 "ld-android.cpp": "",
171 "linked_list.h": "",
172 "linker.h": "",
173 "linker_block_allocator.h": "",
174 "linker_cfi.h": "",
Jingwen Chen63930982021-03-24 10:04:33 -0400175 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000176 Blueprint: soongCcLibraryPreamble +
Liz Kammerbe46fcc2021-11-01 15:32:43 -0400177 simpleModuleDoNotConvertBp2build("cc_library_headers", "libc_headers") + `
Jingwen Chen63930982021-03-24 10:04:33 -0400178cc_library {
179 name: "fake-ld-android",
180 srcs: ["ld_android.cpp"],
181 cflags: [
182 "-Wall",
183 "-Wextra",
184 "-Wunused",
185 "-Werror",
186 ],
187 header_libs: ["libc_headers"],
188 ldflags: [
189 "-Wl,--exclude-libs=libgcc.a",
190 "-Wl,--exclude-libs=libgcc_stripped.a",
191 "-Wl,--exclude-libs=libclang_rt.builtins-arm-android.a",
192 "-Wl,--exclude-libs=libclang_rt.builtins-aarch64-android.a",
193 "-Wl,--exclude-libs=libclang_rt.builtins-i686-android.a",
194 "-Wl,--exclude-libs=libclang_rt.builtins-x86_64-android.a",
195 ],
196 arch: {
197 x86: {
198 ldflags: ["-Wl,--exclude-libs=libgcc_eh.a"],
199 },
200 x86_64: {
201 ldflags: ["-Wl,--exclude-libs=libgcc_eh.a"],
202 },
203 },
Liz Kammer8337ea42021-09-10 10:06:32 -0400204 include_build_directory: false,
Jingwen Chen63930982021-03-24 10:04:33 -0400205}
206`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000207 ExpectedBazelTargets: makeCcLibraryTargets("fake-ld-android", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500208 "srcs": `["ld_android.cpp"]`,
209 "copts": `[
Jingwen Chen63930982021-03-24 10:04:33 -0400210 "-Wall",
211 "-Wextra",
212 "-Wunused",
213 "-Werror",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500214 ]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500215 "implementation_deps": `[":libc_headers"]`,
216 "linkopts": `[
Jingwen Chen63930982021-03-24 10:04:33 -0400217 "-Wl,--exclude-libs=libgcc.a",
218 "-Wl,--exclude-libs=libgcc_stripped.a",
219 "-Wl,--exclude-libs=libclang_rt.builtins-arm-android.a",
220 "-Wl,--exclude-libs=libclang_rt.builtins-aarch64-android.a",
221 "-Wl,--exclude-libs=libclang_rt.builtins-i686-android.a",
222 "-Wl,--exclude-libs=libclang_rt.builtins-x86_64-android.a",
223 ] + select({
Jingwen Chenb4628eb2021-04-08 14:40:57 +0000224 "//build/bazel/platforms/arch:x86": ["-Wl,--exclude-libs=libgcc_eh.a"],
225 "//build/bazel/platforms/arch:x86_64": ["-Wl,--exclude-libs=libgcc_eh.a"],
Jingwen Chen63930982021-03-24 10:04:33 -0400226 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500227 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500228 }),
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200229 })
230}
231
232func TestCcLibraryExcludeSrcs(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000233 runCcLibraryTestCase(t, Bp2buildTestCase{
234 Description: "cc_library exclude_srcs - trimmed example of //external/arm-optimized-routines:libarm-optimized-routines-math",
235 ModuleTypeUnderTest: "cc_library",
236 ModuleTypeUnderTestFactory: cc.LibraryFactory,
237 Dir: "external",
238 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200239 "external/math/cosf.c": "",
240 "external/math/erf.c": "",
241 "external/math/erf_data.c": "",
242 "external/math/erff.c": "",
243 "external/math/erff_data.c": "",
244 "external/Android.bp": `
Jingwen Chen4ecc67d2021-04-27 09:47:02 +0000245cc_library {
246 name: "fake-libarm-optimized-routines-math",
247 exclude_srcs: [
248 // Provided by:
249 // bionic/libm/upstream-freebsd/lib/msun/src/s_erf.c
250 // bionic/libm/upstream-freebsd/lib/msun/src/s_erff.c
251 "math/erf.c",
252 "math/erf_data.c",
253 "math/erff.c",
254 "math/erff_data.c",
255 ],
256 srcs: [
257 "math/*.c",
258 ],
259 // arch-specific settings
260 arch: {
261 arm64: {
262 cflags: [
263 "-DHAVE_FAST_FMA=1",
264 ],
265 },
266 },
267 bazel_module: { bp2build_available: true },
268}
269`,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200270 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000271 Blueprint: soongCcLibraryPreamble,
272 ExpectedBazelTargets: makeCcLibraryTargets("fake-libarm-optimized-routines-math", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500273 "copts": `select({
Jingwen Chen4ecc67d2021-04-27 09:47:02 +0000274 "//build/bazel/platforms/arch:arm64": ["-DHAVE_FAST_FMA=1"],
275 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500276 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500277 "local_includes": `["."]`,
278 "srcs_c": `["math/cosf.c"]`,
279 }),
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200280 })
281}
282
283func TestCcLibrarySharedStaticProps(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000284 runCcLibraryTestCase(t, Bp2buildTestCase{
285 Description: "cc_library shared/static props",
286 ModuleTypeUnderTest: "cc_library",
287 ModuleTypeUnderTestFactory: cc.LibraryFactory,
288 Filesystem: map[string]string{
Liz Kammer8337ea42021-09-10 10:06:32 -0400289 "both.cpp": "",
290 "sharedonly.cpp": "",
291 "staticonly.cpp": "",
292 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000293 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen53681ef2021-04-29 08:15:13 +0000294cc_library {
295 name: "a",
Chris Parsons08648312021-05-06 16:23:19 -0400296 srcs: ["both.cpp"],
297 cflags: ["bothflag"],
298 shared_libs: ["shared_dep_for_both"],
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400299 static_libs: ["static_dep_for_both", "whole_and_static_lib_for_both"],
300 whole_static_libs: ["whole_static_lib_for_both", "whole_and_static_lib_for_both"],
Chris Parsons08648312021-05-06 16:23:19 -0400301 static: {
302 srcs: ["staticonly.cpp"],
303 cflags: ["staticflag"],
304 shared_libs: ["shared_dep_for_static"],
305 static_libs: ["static_dep_for_static"],
306 whole_static_libs: ["whole_static_lib_for_static"],
307 },
308 shared: {
309 srcs: ["sharedonly.cpp"],
310 cflags: ["sharedflag"],
311 shared_libs: ["shared_dep_for_shared"],
312 static_libs: ["static_dep_for_shared"],
313 whole_static_libs: ["whole_static_lib_for_shared"],
314 },
Liz Kammer8337ea42021-09-10 10:06:32 -0400315 include_build_directory: false,
Jingwen Chen53681ef2021-04-29 08:15:13 +0000316}
317
Liz Kammer8337ea42021-09-10 10:06:32 -0400318cc_library_static {
319 name: "static_dep_for_shared",
320 bazel_module: { bp2build_available: false },
321}
Chris Parsons08648312021-05-06 16:23:19 -0400322
Liz Kammer8337ea42021-09-10 10:06:32 -0400323cc_library_static {
324 name: "static_dep_for_static",
325 bazel_module: { bp2build_available: false },
326}
Chris Parsons08648312021-05-06 16:23:19 -0400327
Liz Kammer8337ea42021-09-10 10:06:32 -0400328cc_library_static {
329 name: "static_dep_for_both",
330 bazel_module: { bp2build_available: false },
331}
Chris Parsons08648312021-05-06 16:23:19 -0400332
Liz Kammer8337ea42021-09-10 10:06:32 -0400333cc_library_static {
334 name: "whole_static_lib_for_shared",
335 bazel_module: { bp2build_available: false },
336}
Chris Parsons08648312021-05-06 16:23:19 -0400337
Liz Kammer8337ea42021-09-10 10:06:32 -0400338cc_library_static {
339 name: "whole_static_lib_for_static",
340 bazel_module: { bp2build_available: false },
341}
Chris Parsons08648312021-05-06 16:23:19 -0400342
Liz Kammer8337ea42021-09-10 10:06:32 -0400343cc_library_static {
344 name: "whole_static_lib_for_both",
345 bazel_module: { bp2build_available: false },
346}
Chris Parsons08648312021-05-06 16:23:19 -0400347
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400348cc_library_static {
349 name: "whole_and_static_lib_for_both",
350 bazel_module: { bp2build_available: false },
351}
352
Liz Kammer8337ea42021-09-10 10:06:32 -0400353cc_library {
354 name: "shared_dep_for_shared",
355 bazel_module: { bp2build_available: false },
356}
Chris Parsons08648312021-05-06 16:23:19 -0400357
Liz Kammer8337ea42021-09-10 10:06:32 -0400358cc_library {
359 name: "shared_dep_for_static",
360 bazel_module: { bp2build_available: false },
361}
Chris Parsons08648312021-05-06 16:23:19 -0400362
Liz Kammer8337ea42021-09-10 10:06:32 -0400363cc_library {
364 name: "shared_dep_for_both",
365 bazel_module: { bp2build_available: false },
366}
Jingwen Chen53681ef2021-04-29 08:15:13 +0000367`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000368 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000369 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500370 "copts": `[
371 "bothflag",
372 "staticflag",
373 ]`,
374 "implementation_deps": `[
375 ":static_dep_for_both",
376 ":static_dep_for_static",
377 ]`,
378 "implementation_dynamic_deps": `[
379 ":shared_dep_for_both",
380 ":shared_dep_for_static",
381 ]`,
382 "srcs": `[
383 "both.cpp",
384 "staticonly.cpp",
385 ]`,
386 "whole_archive_deps": `[
387 ":whole_static_lib_for_both",
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400388 ":whole_and_static_lib_for_both",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500389 ":whole_static_lib_for_static",
390 ]`}),
Alixe06d75b2022-08-31 18:28:19 +0000391 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500392 "copts": `[
393 "bothflag",
394 "sharedflag",
395 ]`,
396 "implementation_deps": `[
397 ":static_dep_for_both",
398 ":static_dep_for_shared",
399 ]`,
400 "implementation_dynamic_deps": `[
401 ":shared_dep_for_both",
402 ":shared_dep_for_shared",
403 ]`,
404 "srcs": `[
405 "both.cpp",
406 "sharedonly.cpp",
407 ]`,
408 "whole_archive_deps": `[
409 ":whole_static_lib_for_both",
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400410 ":whole_and_static_lib_for_both",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500411 ":whole_static_lib_for_shared",
412 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500413 }),
414 },
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200415 })
416}
417
Liz Kammer7a210ac2021-09-22 15:52:58 -0400418func TestCcLibraryDeps(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000419 runCcLibraryTestCase(t, Bp2buildTestCase{
420 Description: "cc_library shared/static props",
421 ModuleTypeUnderTest: "cc_library",
422 ModuleTypeUnderTestFactory: cc.LibraryFactory,
423 Filesystem: map[string]string{
Liz Kammer7a210ac2021-09-22 15:52:58 -0400424 "both.cpp": "",
425 "sharedonly.cpp": "",
426 "staticonly.cpp": "",
427 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000428 Blueprint: soongCcLibraryPreamble + `
Liz Kammer7a210ac2021-09-22 15:52:58 -0400429cc_library {
430 name: "a",
431 srcs: ["both.cpp"],
432 cflags: ["bothflag"],
433 shared_libs: ["implementation_shared_dep_for_both", "shared_dep_for_both"],
434 export_shared_lib_headers: ["shared_dep_for_both"],
435 static_libs: ["implementation_static_dep_for_both", "static_dep_for_both"],
436 export_static_lib_headers: ["static_dep_for_both", "whole_static_dep_for_both"],
437 whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_both", "whole_static_dep_for_both"],
438 static: {
439 srcs: ["staticonly.cpp"],
440 cflags: ["staticflag"],
441 shared_libs: ["implementation_shared_dep_for_static", "shared_dep_for_static"],
442 export_shared_lib_headers: ["shared_dep_for_static"],
443 static_libs: ["implementation_static_dep_for_static", "static_dep_for_static"],
444 export_static_lib_headers: ["static_dep_for_static", "whole_static_dep_for_static"],
445 whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_static", "whole_static_dep_for_static"],
446 },
447 shared: {
448 srcs: ["sharedonly.cpp"],
449 cflags: ["sharedflag"],
450 shared_libs: ["implementation_shared_dep_for_shared", "shared_dep_for_shared"],
451 export_shared_lib_headers: ["shared_dep_for_shared"],
452 static_libs: ["implementation_static_dep_for_shared", "static_dep_for_shared"],
453 export_static_lib_headers: ["static_dep_for_shared", "whole_static_dep_for_shared"],
454 whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_shared", "whole_static_dep_for_shared"],
455 },
456 include_build_directory: false,
457}
458` + simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_shared") +
459 simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_shared") +
460 simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_static") +
461 simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_static") +
462 simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_both") +
463 simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_both") +
464 simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_shared") +
465 simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_shared") +
466 simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_static") +
467 simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_static") +
468 simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_both") +
469 simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_both") +
470 simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_shared") +
471 simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_shared") +
472 simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_static") +
473 simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_static") +
474 simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_both") +
475 simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_both"),
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000476 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000477 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500478 "copts": `[
479 "bothflag",
480 "staticflag",
481 ]`,
482 "deps": `[
483 ":static_dep_for_both",
484 ":static_dep_for_static",
485 ]`,
486 "dynamic_deps": `[
487 ":shared_dep_for_both",
488 ":shared_dep_for_static",
489 ]`,
490 "implementation_deps": `[
491 ":implementation_static_dep_for_both",
492 ":implementation_static_dep_for_static",
493 ]`,
494 "implementation_dynamic_deps": `[
495 ":implementation_shared_dep_for_both",
496 ":implementation_shared_dep_for_static",
497 ]`,
498 "srcs": `[
499 "both.cpp",
500 "staticonly.cpp",
501 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500502 "whole_archive_deps": `[
Liz Kammer7a210ac2021-09-22 15:52:58 -0400503 ":not_explicitly_exported_whole_static_dep_for_both",
504 ":whole_static_dep_for_both",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500505 ":not_explicitly_exported_whole_static_dep_for_static",
506 ":whole_static_dep_for_static",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500507 ]`,
508 }),
Alixe06d75b2022-08-31 18:28:19 +0000509 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500510 "copts": `[
511 "bothflag",
512 "sharedflag",
513 ]`,
514 "deps": `[
515 ":static_dep_for_both",
516 ":static_dep_for_shared",
517 ]`,
518 "dynamic_deps": `[
519 ":shared_dep_for_both",
520 ":shared_dep_for_shared",
521 ]`,
522 "implementation_deps": `[
523 ":implementation_static_dep_for_both",
524 ":implementation_static_dep_for_shared",
525 ]`,
526 "implementation_dynamic_deps": `[
527 ":implementation_shared_dep_for_both",
528 ":implementation_shared_dep_for_shared",
529 ]`,
530 "srcs": `[
531 "both.cpp",
532 "sharedonly.cpp",
533 ]`,
534 "whole_archive_deps": `[
535 ":not_explicitly_exported_whole_static_dep_for_both",
536 ":whole_static_dep_for_both",
537 ":not_explicitly_exported_whole_static_dep_for_shared",
538 ":whole_static_dep_for_shared",
539 ]`,
540 })},
541 },
542 )
Liz Kammer7a210ac2021-09-22 15:52:58 -0400543}
544
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400545func TestCcLibraryWholeStaticLibsAlwaysLink(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000546 runCcLibraryTestCase(t, Bp2buildTestCase{
547 ModuleTypeUnderTest: "cc_library",
548 ModuleTypeUnderTestFactory: cc.LibraryFactory,
549 Dir: "foo/bar",
550 Filesystem: map[string]string{
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400551 "foo/bar/Android.bp": `
552cc_library {
553 name: "a",
554 whole_static_libs: ["whole_static_lib_for_both"],
555 static: {
556 whole_static_libs: ["whole_static_lib_for_static"],
557 },
558 shared: {
559 whole_static_libs: ["whole_static_lib_for_shared"],
560 },
561 bazel_module: { bp2build_available: true },
Liz Kammer8337ea42021-09-10 10:06:32 -0400562 include_build_directory: false,
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400563}
564
565cc_prebuilt_library_static { name: "whole_static_lib_for_shared" }
566
567cc_prebuilt_library_static { name: "whole_static_lib_for_static" }
568
569cc_prebuilt_library_static { name: "whole_static_lib_for_both" }
570`,
571 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000572 Blueprint: soongCcLibraryPreamble,
573 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000574 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500575 "whole_archive_deps": `[
576 ":whole_static_lib_for_both_alwayslink",
577 ":whole_static_lib_for_static_alwayslink",
578 ]`,
579 }),
Alixe06d75b2022-08-31 18:28:19 +0000580 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500581 "whole_archive_deps": `[
582 ":whole_static_lib_for_both_alwayslink",
583 ":whole_static_lib_for_shared_alwayslink",
584 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500585 }),
586 },
Chris Parsons77acf2e2021-12-03 17:27:16 -0500587 },
588 )
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400589}
590
Jingwen Chenbcf53042021-05-26 04:42:42 +0000591func TestCcLibrarySharedStaticPropsInArch(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000592 runCcLibraryTestCase(t, Bp2buildTestCase{
593 Description: "cc_library shared/static props in arch",
594 ModuleTypeUnderTest: "cc_library",
595 ModuleTypeUnderTestFactory: cc.LibraryFactory,
596 Dir: "foo/bar",
597 Filesystem: map[string]string{
Jingwen Chenbcf53042021-05-26 04:42:42 +0000598 "foo/bar/arm.cpp": "",
599 "foo/bar/x86.cpp": "",
600 "foo/bar/sharedonly.cpp": "",
601 "foo/bar/staticonly.cpp": "",
602 "foo/bar/Android.bp": `
603cc_library {
604 name: "a",
605 arch: {
606 arm: {
607 shared: {
608 srcs: ["arm_shared.cpp"],
609 cflags: ["-DARM_SHARED"],
610 static_libs: ["arm_static_dep_for_shared"],
611 whole_static_libs: ["arm_whole_static_dep_for_shared"],
612 shared_libs: ["arm_shared_dep_for_shared"],
613 },
614 },
615 x86: {
616 static: {
617 srcs: ["x86_static.cpp"],
618 cflags: ["-DX86_STATIC"],
619 static_libs: ["x86_dep_for_static"],
620 },
621 },
622 },
623 target: {
624 android: {
625 shared: {
626 srcs: ["android_shared.cpp"],
627 cflags: ["-DANDROID_SHARED"],
628 static_libs: ["android_dep_for_shared"],
629 },
630 },
631 android_arm: {
632 shared: {
633 cflags: ["-DANDROID_ARM_SHARED"],
634 },
635 },
636 },
637 srcs: ["both.cpp"],
638 cflags: ["bothflag"],
639 static_libs: ["static_dep_for_both"],
640 static: {
641 srcs: ["staticonly.cpp"],
642 cflags: ["staticflag"],
643 static_libs: ["static_dep_for_static"],
644 },
645 shared: {
646 srcs: ["sharedonly.cpp"],
647 cflags: ["sharedflag"],
648 static_libs: ["static_dep_for_shared"],
649 },
650 bazel_module: { bp2build_available: true },
651}
652
653cc_library_static { name: "static_dep_for_shared" }
654cc_library_static { name: "static_dep_for_static" }
655cc_library_static { name: "static_dep_for_both" }
656
657cc_library_static { name: "arm_static_dep_for_shared" }
658cc_library_static { name: "arm_whole_static_dep_for_shared" }
659cc_library_static { name: "arm_shared_dep_for_shared" }
660
661cc_library_static { name: "x86_dep_for_static" }
662
663cc_library_static { name: "android_dep_for_shared" }
664`,
665 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000666 Blueprint: soongCcLibraryPreamble,
667 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000668 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500669 "copts": `[
670 "bothflag",
671 "staticflag",
672 ] + select({
673 "//build/bazel/platforms/arch:x86": ["-DX86_STATIC"],
674 "//conditions:default": [],
675 })`,
676 "implementation_deps": `[
677 ":static_dep_for_both",
678 ":static_dep_for_static",
679 ] + select({
680 "//build/bazel/platforms/arch:x86": [":x86_dep_for_static"],
681 "//conditions:default": [],
682 })`,
683 "local_includes": `["."]`,
684 "srcs": `[
685 "both.cpp",
686 "staticonly.cpp",
687 ] + select({
688 "//build/bazel/platforms/arch:x86": ["x86_static.cpp"],
689 "//conditions:default": [],
690 })`,
691 }),
Alixe06d75b2022-08-31 18:28:19 +0000692 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500693 "copts": `[
694 "bothflag",
695 "sharedflag",
696 ] + select({
697 "//build/bazel/platforms/arch:arm": ["-DARM_SHARED"],
698 "//conditions:default": [],
699 }) + select({
700 "//build/bazel/platforms/os:android": ["-DANDROID_SHARED"],
701 "//conditions:default": [],
702 }) + select({
703 "//build/bazel/platforms/os_arch:android_arm": ["-DANDROID_ARM_SHARED"],
704 "//conditions:default": [],
705 })`,
706 "implementation_deps": `[
707 ":static_dep_for_both",
708 ":static_dep_for_shared",
709 ] + select({
710 "//build/bazel/platforms/arch:arm": [":arm_static_dep_for_shared"],
711 "//conditions:default": [],
712 }) + select({
713 "//build/bazel/platforms/os:android": [":android_dep_for_shared"],
714 "//conditions:default": [],
715 })`,
716 "implementation_dynamic_deps": `select({
717 "//build/bazel/platforms/arch:arm": [":arm_shared_dep_for_shared"],
718 "//conditions:default": [],
719 })`,
720 "local_includes": `["."]`,
721 "srcs": `[
722 "both.cpp",
723 "sharedonly.cpp",
724 ] + select({
725 "//build/bazel/platforms/arch:arm": ["arm_shared.cpp"],
726 "//conditions:default": [],
727 }) + select({
728 "//build/bazel/platforms/os:android": ["android_shared.cpp"],
729 "//conditions:default": [],
730 })`,
731 "whole_archive_deps": `select({
732 "//build/bazel/platforms/arch:arm": [":arm_whole_static_dep_for_shared"],
733 "//conditions:default": [],
734 })`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500735 }),
736 },
Chris Parsons77acf2e2021-12-03 17:27:16 -0500737 },
738 )
Jingwen Chenbcf53042021-05-26 04:42:42 +0000739}
740
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000741func TestCcLibrarySharedStaticPropsWithMixedSources(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000742 runCcLibraryTestCase(t, Bp2buildTestCase{
743 Description: "cc_library shared/static props with c/cpp/s mixed sources",
744 ModuleTypeUnderTest: "cc_library",
745 ModuleTypeUnderTestFactory: cc.LibraryFactory,
746 Dir: "foo/bar",
747 Filesystem: map[string]string{
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000748 "foo/bar/both_source.cpp": "",
749 "foo/bar/both_source.cc": "",
750 "foo/bar/both_source.c": "",
751 "foo/bar/both_source.s": "",
752 "foo/bar/both_source.S": "",
753 "foo/bar/shared_source.cpp": "",
754 "foo/bar/shared_source.cc": "",
755 "foo/bar/shared_source.c": "",
756 "foo/bar/shared_source.s": "",
757 "foo/bar/shared_source.S": "",
758 "foo/bar/static_source.cpp": "",
759 "foo/bar/static_source.cc": "",
760 "foo/bar/static_source.c": "",
761 "foo/bar/static_source.s": "",
762 "foo/bar/static_source.S": "",
763 "foo/bar/Android.bp": `
764cc_library {
765 name: "a",
766 srcs: [
Liz Kammerd366c902021-06-03 13:43:01 -0400767 "both_source.cpp",
768 "both_source.cc",
769 "both_source.c",
770 "both_source.s",
771 "both_source.S",
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400772 ":both_filegroup",
Liz Kammerd366c902021-06-03 13:43:01 -0400773 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000774 static: {
Liz Kammer8337ea42021-09-10 10:06:32 -0400775 srcs: [
776 "static_source.cpp",
777 "static_source.cc",
778 "static_source.c",
779 "static_source.s",
780 "static_source.S",
781 ":static_filegroup",
782 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000783 },
784 shared: {
Liz Kammer8337ea42021-09-10 10:06:32 -0400785 srcs: [
786 "shared_source.cpp",
787 "shared_source.cc",
788 "shared_source.c",
789 "shared_source.s",
790 "shared_source.S",
791 ":shared_filegroup",
792 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000793 },
794 bazel_module: { bp2build_available: true },
795}
796
797filegroup {
798 name: "both_filegroup",
799 srcs: [
800 // Not relevant, handled by filegroup macro
Liz Kammerd366c902021-06-03 13:43:01 -0400801 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000802}
803
804filegroup {
805 name: "shared_filegroup",
806 srcs: [
807 // Not relevant, handled by filegroup macro
Liz Kammerd366c902021-06-03 13:43:01 -0400808 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000809}
810
811filegroup {
812 name: "static_filegroup",
813 srcs: [
814 // Not relevant, handled by filegroup macro
Liz Kammerd366c902021-06-03 13:43:01 -0400815 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000816}
817`,
818 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000819 Blueprint: soongCcLibraryPreamble,
820 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000821 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500822 "local_includes": `["."]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500823 "srcs": `[
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000824 "both_source.cpp",
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400825 "both_source.cc",
826 ":both_filegroup_cpp_srcs",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500827 "static_source.cpp",
828 "static_source.cc",
829 ":static_filegroup_cpp_srcs",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500830 ]`,
831 "srcs_as": `[
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000832 "both_source.s",
833 "both_source.S",
834 ":both_filegroup_as_srcs",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500835 "static_source.s",
836 "static_source.S",
837 ":static_filegroup_as_srcs",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500838 ]`,
839 "srcs_c": `[
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000840 "both_source.c",
841 ":both_filegroup_c_srcs",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500842 "static_source.c",
843 ":static_filegroup_c_srcs",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500844 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500845 }),
Alixe06d75b2022-08-31 18:28:19 +0000846 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500847 "local_includes": `["."]`,
848 "srcs": `[
849 "both_source.cpp",
850 "both_source.cc",
851 ":both_filegroup_cpp_srcs",
852 "shared_source.cpp",
853 "shared_source.cc",
854 ":shared_filegroup_cpp_srcs",
855 ]`,
856 "srcs_as": `[
857 "both_source.s",
858 "both_source.S",
859 ":both_filegroup_as_srcs",
860 "shared_source.s",
861 "shared_source.S",
862 ":shared_filegroup_as_srcs",
863 ]`,
864 "srcs_c": `[
865 "both_source.c",
866 ":both_filegroup_c_srcs",
867 "shared_source.c",
868 ":shared_filegroup_c_srcs",
869 ]`,
870 })}})
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000871}
872
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200873func TestCcLibraryNonConfiguredVersionScript(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000874 runCcLibraryTestCase(t, Bp2buildTestCase{
875 Description: "cc_library non-configured version script",
876 ModuleTypeUnderTest: "cc_library",
877 ModuleTypeUnderTestFactory: cc.LibraryFactory,
878 Dir: "foo/bar",
879 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200880 "foo/bar/Android.bp": `
Lukacs T. Berki1353e592021-04-30 15:35:09 +0200881cc_library {
882 name: "a",
883 srcs: ["a.cpp"],
884 version_script: "v.map",
885 bazel_module: { bp2build_available: true },
Liz Kammer8337ea42021-09-10 10:06:32 -0400886 include_build_directory: false,
Lukacs T. Berki1353e592021-04-30 15:35:09 +0200887}
888`,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200889 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000890 Blueprint: soongCcLibraryPreamble,
891 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500892 "additional_linker_inputs": `["v.map"]`,
893 "linkopts": `["-Wl,--version-script,$(location v.map)"]`,
894 "srcs": `["a.cpp"]`,
895 }),
896 },
897 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200898}
899
900func TestCcLibraryConfiguredVersionScript(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000901 runCcLibraryTestCase(t, Bp2buildTestCase{
902 Description: "cc_library configured version script",
903 ModuleTypeUnderTest: "cc_library",
904 ModuleTypeUnderTestFactory: cc.LibraryFactory,
905 Dir: "foo/bar",
906 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200907 "foo/bar/Android.bp": `
Liz Kammer8337ea42021-09-10 10:06:32 -0400908cc_library {
909 name: "a",
910 srcs: ["a.cpp"],
911 arch: {
912 arm: {
913 version_script: "arm.map",
914 },
915 arm64: {
916 version_script: "arm64.map",
917 },
918 },
Lukacs T. Berki56bb0832021-05-12 12:36:45 +0200919
Liz Kammer8337ea42021-09-10 10:06:32 -0400920 bazel_module: { bp2build_available: true },
921 include_build_directory: false,
922}
Liz Kammerd366c902021-06-03 13:43:01 -0400923 `,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200924 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000925 Blueprint: soongCcLibraryPreamble,
926 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500927 "additional_linker_inputs": `select({
Liz Kammerd2871182021-10-04 13:54:37 -0400928 "//build/bazel/platforms/arch:arm": ["arm.map"],
929 "//build/bazel/platforms/arch:arm64": ["arm64.map"],
930 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500931 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500932 "linkopts": `select({
Liz Kammerd2871182021-10-04 13:54:37 -0400933 "//build/bazel/platforms/arch:arm": ["-Wl,--version-script,$(location arm.map)"],
934 "//build/bazel/platforms/arch:arm64": ["-Wl,--version-script,$(location arm64.map)"],
935 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500936 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500937 "srcs": `["a.cpp"]`,
938 }),
939 },
940 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200941}
942
943func TestCcLibrarySharedLibs(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000944 runCcLibraryTestCase(t, Bp2buildTestCase{
945 Description: "cc_library shared_libs",
946 ModuleTypeUnderTest: "cc_library",
947 ModuleTypeUnderTestFactory: cc.LibraryFactory,
948 Blueprint: soongCcLibraryPreamble + `
Rupert Shuttleworthc50fa8d2021-05-06 02:40:33 -0400949cc_library {
950 name: "mylib",
Liz Kammer8337ea42021-09-10 10:06:32 -0400951 bazel_module: { bp2build_available: false },
Rupert Shuttleworthc50fa8d2021-05-06 02:40:33 -0400952}
953
954cc_library {
955 name: "a",
956 shared_libs: ["mylib",],
Liz Kammer8337ea42021-09-10 10:06:32 -0400957 include_build_directory: false,
Rupert Shuttleworthc50fa8d2021-05-06 02:40:33 -0400958}
959`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000960 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500961 "implementation_dynamic_deps": `[":mylib"]`,
962 }),
963 },
964 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200965}
966
Liz Kammer0eae52e2021-10-06 10:32:26 -0400967func TestCcLibraryFeatures(t *testing.T) {
Chris Parsons77acf2e2021-12-03 17:27:16 -0500968 expected_targets := []string{}
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000969 expected_targets = append(expected_targets, makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500970 "features": `[
971 "disable_pack_relocations",
972 "-no_undefined_symbols",
Yu Liu8d82ac52022-05-17 15:13:28 -0700973 "-coverage",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500974 ]`,
975 "srcs": `["a.cpp"]`,
976 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000977 expected_targets = append(expected_targets, makeCcLibraryTargets("b", AttrNameToString{
Yu Liu8d82ac52022-05-17 15:13:28 -0700978 "features": `["-coverage"] + select({
Chris Parsons77acf2e2021-12-03 17:27:16 -0500979 "//build/bazel/platforms/arch:x86_64": [
980 "disable_pack_relocations",
981 "-no_undefined_symbols",
982 ],
983 "//conditions:default": [],
984 })`,
985 "srcs": `["b.cpp"]`,
986 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000987 expected_targets = append(expected_targets, makeCcLibraryTargets("c", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500988 "features": `select({
989 "//build/bazel/platforms/os:darwin": [
990 "disable_pack_relocations",
991 "-no_undefined_symbols",
992 ],
993 "//conditions:default": [],
994 })`,
995 "srcs": `["c.cpp"]`,
996 })...)
997
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000998 runCcLibraryTestCase(t, Bp2buildTestCase{
999 Description: "cc_library pack_relocations test",
1000 ModuleTypeUnderTest: "cc_library",
1001 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1002 Blueprint: soongCcLibraryPreamble + `
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001003cc_library {
1004 name: "a",
1005 srcs: ["a.cpp"],
1006 pack_relocations: false,
Liz Kammer0eae52e2021-10-06 10:32:26 -04001007 allow_undefined_symbols: true,
Liz Kammer8337ea42021-09-10 10:06:32 -04001008 include_build_directory: false,
Yu Liu8d82ac52022-05-17 15:13:28 -07001009 native_coverage: false,
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001010}
1011
1012cc_library {
1013 name: "b",
1014 srcs: ["b.cpp"],
1015 arch: {
1016 x86_64: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001017 pack_relocations: false,
Liz Kammer0eae52e2021-10-06 10:32:26 -04001018 allow_undefined_symbols: true,
Liz Kammer8337ea42021-09-10 10:06:32 -04001019 },
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001020 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001021 include_build_directory: false,
Yu Liu8d82ac52022-05-17 15:13:28 -07001022 native_coverage: false,
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001023}
1024
1025cc_library {
1026 name: "c",
1027 srcs: ["c.cpp"],
1028 target: {
1029 darwin: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001030 pack_relocations: false,
Liz Kammer0eae52e2021-10-06 10:32:26 -04001031 allow_undefined_symbols: true,
Liz Kammer8337ea42021-09-10 10:06:32 -04001032 },
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001033 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001034 include_build_directory: false,
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001035}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001036 ExpectedBazelTargets: expected_targets,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +02001037 })
1038}
1039
1040func TestCcLibrarySpacesInCopts(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001041 runCcLibraryTestCase(t, Bp2buildTestCase{
1042 Description: "cc_library spaces in copts",
1043 ModuleTypeUnderTest: "cc_library",
1044 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1045 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen3950cd62021-05-12 04:33:00 +00001046cc_library {
1047 name: "a",
1048 cflags: ["-include header.h",],
Liz Kammer8337ea42021-09-10 10:06:32 -04001049 include_build_directory: false,
Jingwen Chen3950cd62021-05-12 04:33:00 +00001050}
1051`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001052 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001053 "copts": `[
Jingwen Chen3950cd62021-05-12 04:33:00 +00001054 "-include",
1055 "header.h",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001056 ]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001057 }),
1058 },
1059 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +02001060}
1061
1062func TestCcLibraryCppFlagsGoesIntoCopts(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001063 runCcLibraryTestCase(t, Bp2buildTestCase{
1064 Description: "cc_library cppflags usage",
1065 ModuleTypeUnderTest: "cc_library",
1066 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1067 Blueprint: soongCcLibraryPreamble + `cc_library {
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001068 name: "a",
1069 srcs: ["a.cpp"],
Liz Kammer8337ea42021-09-10 10:06:32 -04001070 cflags: ["-Wall"],
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001071 cppflags: [
1072 "-fsigned-char",
1073 "-pedantic",
Liz Kammer8337ea42021-09-10 10:06:32 -04001074 ],
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001075 arch: {
1076 arm64: {
1077 cppflags: ["-DARM64=1"],
Liz Kammer8337ea42021-09-10 10:06:32 -04001078 },
Liz Kammerd366c902021-06-03 13:43:01 -04001079 },
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001080 target: {
1081 android: {
1082 cppflags: ["-DANDROID=1"],
Liz Kammer8337ea42021-09-10 10:06:32 -04001083 },
Liz Kammerd366c902021-06-03 13:43:01 -04001084 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001085 include_build_directory: false,
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001086}
1087`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001088 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001089 "copts": `["-Wall"]`,
1090 "cppflags": `[
Chris Parsons990c4f42021-05-25 12:10:58 -04001091 "-fsigned-char",
1092 "-pedantic",
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001093 ] + select({
1094 "//build/bazel/platforms/arch:arm64": ["-DARM64=1"],
1095 "//conditions:default": [],
1096 }) + select({
1097 "//build/bazel/platforms/os:android": ["-DANDROID=1"],
1098 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001099 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001100 "srcs": `["a.cpp"]`,
1101 }),
1102 },
1103 )
Jingwen Chen63930982021-03-24 10:04:33 -04001104}
Rupert Shuttleworth22cd2eb2021-05-27 02:15:54 -04001105
Liz Kammer47535c52021-06-02 16:02:22 -04001106func TestCcLibraryExcludeLibs(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001107 runCcLibraryTestCase(t, Bp2buildTestCase{
1108 ModuleTypeUnderTest: "cc_library",
1109 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1110 Filesystem: map[string]string{},
1111 Blueprint: soongCcLibraryStaticPreamble + `
Liz Kammer47535c52021-06-02 16:02:22 -04001112cc_library {
1113 name: "foo_static",
1114 srcs: ["common.c"],
1115 whole_static_libs: [
1116 "arm_whole_static_lib_excludes",
1117 "malloc_not_svelte_whole_static_lib_excludes"
1118 ],
1119 static_libs: [
1120 "arm_static_lib_excludes",
1121 "malloc_not_svelte_static_lib_excludes"
1122 ],
1123 shared_libs: [
1124 "arm_shared_lib_excludes",
1125 ],
1126 arch: {
1127 arm: {
1128 exclude_shared_libs: [
1129 "arm_shared_lib_excludes",
1130 ],
1131 exclude_static_libs: [
1132 "arm_static_lib_excludes",
1133 "arm_whole_static_lib_excludes",
1134 ],
1135 },
1136 },
1137 product_variables: {
1138 malloc_not_svelte: {
1139 shared_libs: ["malloc_not_svelte_shared_lib"],
1140 whole_static_libs: ["malloc_not_svelte_whole_static_lib"],
1141 exclude_static_libs: [
1142 "malloc_not_svelte_static_lib_excludes",
1143 "malloc_not_svelte_whole_static_lib_excludes",
1144 ],
1145 },
1146 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001147 include_build_directory: false,
Liz Kammer47535c52021-06-02 16:02:22 -04001148}
1149
1150cc_library {
1151 name: "arm_whole_static_lib_excludes",
1152 bazel_module: { bp2build_available: false },
1153}
1154
1155cc_library {
1156 name: "malloc_not_svelte_whole_static_lib",
1157 bazel_module: { bp2build_available: false },
1158}
1159
1160cc_library {
1161 name: "malloc_not_svelte_whole_static_lib_excludes",
1162 bazel_module: { bp2build_available: false },
1163}
1164
1165cc_library {
1166 name: "arm_static_lib_excludes",
1167 bazel_module: { bp2build_available: false },
1168}
1169
1170cc_library {
1171 name: "malloc_not_svelte_static_lib_excludes",
1172 bazel_module: { bp2build_available: false },
1173}
1174
1175cc_library {
1176 name: "arm_shared_lib_excludes",
1177 bazel_module: { bp2build_available: false },
1178}
1179
1180cc_library {
1181 name: "malloc_not_svelte_shared_lib",
1182 bazel_module: { bp2build_available: false },
1183}
1184`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001185 ExpectedBazelTargets: makeCcLibraryTargets("foo_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001186 "implementation_deps": `select({
Liz Kammer47535c52021-06-02 16:02:22 -04001187 "//build/bazel/platforms/arch:arm": [],
Chris Parsons953b3562021-09-20 15:14:39 -04001188 "//conditions:default": [":arm_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer47535c52021-06-02 16:02:22 -04001189 }) + select({
1190 "//build/bazel/product_variables:malloc_not_svelte": [],
Chris Parsons953b3562021-09-20 15:14:39 -04001191 "//conditions:default": [":malloc_not_svelte_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001192 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001193 "implementation_dynamic_deps": `select({
Liz Kammer7a210ac2021-09-22 15:52:58 -04001194 "//build/bazel/platforms/arch:arm": [],
1195 "//conditions:default": [":arm_shared_lib_excludes"],
1196 }) + select({
1197 "//build/bazel/product_variables:malloc_not_svelte": [":malloc_not_svelte_shared_lib"],
1198 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001199 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001200 "srcs_c": `["common.c"]`,
1201 "whole_archive_deps": `select({
Liz Kammer47535c52021-06-02 16:02:22 -04001202 "//build/bazel/platforms/arch:arm": [],
Chris Parsons953b3562021-09-20 15:14:39 -04001203 "//conditions:default": [":arm_whole_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer47535c52021-06-02 16:02:22 -04001204 }) + select({
Chris Parsons953b3562021-09-20 15:14:39 -04001205 "//build/bazel/product_variables:malloc_not_svelte": [":malloc_not_svelte_whole_static_lib_bp2build_cc_library_static"],
1206 "//conditions:default": [":malloc_not_svelte_whole_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001207 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001208 }),
1209 },
1210 )
Liz Kammer47535c52021-06-02 16:02:22 -04001211}
Liz Kammerd366c902021-06-03 13:43:01 -04001212
Zi Wang0a8a1292022-08-30 06:27:01 +00001213func TestCcLibraryProductVariablesHeaderLibs(t *testing.T) {
1214 runCcLibraryTestCase(t, Bp2buildTestCase{
1215 ModuleTypeUnderTest: "cc_library",
1216 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1217 Filesystem: map[string]string{},
1218 Blueprint: soongCcLibraryStaticPreamble + `
1219cc_library {
1220 name: "foo_static",
1221 srcs: ["common.c"],
1222 product_variables: {
1223 malloc_not_svelte: {
1224 header_libs: ["malloc_not_svelte_header_lib"],
1225 },
1226 },
1227 include_build_directory: false,
1228}
1229
1230cc_library {
1231 name: "malloc_not_svelte_header_lib",
1232 bazel_module: { bp2build_available: false },
1233}
1234`,
1235 ExpectedBazelTargets: makeCcLibraryTargets("foo_static", AttrNameToString{
1236 "implementation_deps": `select({
1237 "//build/bazel/product_variables:malloc_not_svelte": [":malloc_not_svelte_header_lib"],
1238 "//conditions:default": [],
1239 })`,
1240 "srcs_c": `["common.c"]`,
1241 "target_compatible_with": `["//build/bazel/platforms/os:android"]`,
1242 }),
1243 },
1244 )
1245}
1246
Liz Kammerd366c902021-06-03 13:43:01 -04001247func TestCCLibraryNoCrtTrue(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001248 runCcLibraryTestCase(t, Bp2buildTestCase{
1249 Description: "cc_library - nocrt: true emits attribute",
1250 ModuleTypeUnderTest: "cc_library",
1251 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1252 Filesystem: map[string]string{
Jingwen Chen6ada5892021-09-17 11:38:09 +00001253 "impl.cpp": "",
1254 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001255 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen6ada5892021-09-17 11:38:09 +00001256cc_library {
1257 name: "foo-lib",
1258 srcs: ["impl.cpp"],
1259 nocrt: true,
1260 include_build_directory: false,
1261}
1262`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001263 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001264 "link_crt": `False`,
1265 "srcs": `["impl.cpp"]`,
1266 }),
1267 },
1268 )
Jingwen Chen6ada5892021-09-17 11:38:09 +00001269}
1270
1271func TestCCLibraryNoCrtFalse(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001272 runCcLibraryTestCase(t, Bp2buildTestCase{
1273 Description: "cc_library - nocrt: false - does not emit attribute",
1274 ModuleTypeUnderTest: "cc_library",
1275 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1276 Filesystem: map[string]string{
Jingwen Chen6ada5892021-09-17 11:38:09 +00001277 "impl.cpp": "",
1278 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001279 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen6ada5892021-09-17 11:38:09 +00001280cc_library {
1281 name: "foo-lib",
1282 srcs: ["impl.cpp"],
1283 nocrt: false,
1284 include_build_directory: false,
1285}
1286`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001287 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001288 "srcs": `["impl.cpp"]`,
1289 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001290 })
Jingwen Chen6ada5892021-09-17 11:38:09 +00001291}
1292
1293func TestCCLibraryNoCrtArchVariant(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001294 runCcLibraryTestCase(t, Bp2buildTestCase{
1295 Description: "cc_library - nocrt in select",
1296 ModuleTypeUnderTest: "cc_library",
1297 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1298 Filesystem: map[string]string{
Jingwen Chen6ada5892021-09-17 11:38:09 +00001299 "impl.cpp": "",
1300 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001301 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen6ada5892021-09-17 11:38:09 +00001302cc_library {
1303 name: "foo-lib",
1304 srcs: ["impl.cpp"],
1305 arch: {
1306 arm: {
1307 nocrt: true,
1308 },
1309 x86: {
1310 nocrt: false,
1311 },
1312 },
1313 include_build_directory: false,
1314}
1315`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001316 ExpectedErr: fmt.Errorf("module \"foo-lib\": nocrt is not supported for arch variants"),
Jingwen Chen6ada5892021-09-17 11:38:09 +00001317 })
1318}
1319
1320func TestCCLibraryNoLibCrtTrue(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001321 runCcLibraryTestCase(t, Bp2buildTestCase{
1322 ModuleTypeUnderTest: "cc_library",
1323 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1324 Filesystem: map[string]string{
Liz Kammerd366c902021-06-03 13:43:01 -04001325 "impl.cpp": "",
1326 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001327 Blueprint: soongCcLibraryPreamble + `
Liz Kammerd366c902021-06-03 13:43:01 -04001328cc_library {
1329 name: "foo-lib",
1330 srcs: ["impl.cpp"],
1331 no_libcrt: true,
Liz Kammer8337ea42021-09-10 10:06:32 -04001332 include_build_directory: false,
Liz Kammerd366c902021-06-03 13:43:01 -04001333}
1334`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001335 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001336 "srcs": `["impl.cpp"]`,
1337 "use_libcrt": `False`,
1338 }),
1339 })
1340}
1341
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001342func makeCcLibraryTargets(name string, attrs AttrNameToString) []string {
Chris Parsons77acf2e2021-12-03 17:27:16 -05001343 STATIC_ONLY_ATTRS := map[string]bool{}
1344 SHARED_ONLY_ATTRS := map[string]bool{
1345 "link_crt": true,
1346 "additional_linker_inputs": true,
1347 "linkopts": true,
1348 "strip": true,
Yu Liu75be7b92022-02-01 09:54:09 -08001349 "inject_bssl_hash": true,
Wei Li81852ca2022-07-27 00:22:06 -07001350 "has_stubs": true,
Liz Kammerbaced712022-09-16 09:01:29 -04001351 "use_version_lib": true,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001352 }
Wei Li81852ca2022-07-27 00:22:06 -07001353
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001354 sharedAttrs := AttrNameToString{}
1355 staticAttrs := AttrNameToString{}
Chris Parsons77acf2e2021-12-03 17:27:16 -05001356 for key, val := range attrs {
1357 if _, staticOnly := STATIC_ONLY_ATTRS[key]; !staticOnly {
1358 sharedAttrs[key] = val
1359 }
1360 if _, sharedOnly := SHARED_ONLY_ATTRS[key]; !sharedOnly {
1361 staticAttrs[key] = val
1362 }
1363 }
Alixe06d75b2022-08-31 18:28:19 +00001364 sharedTarget := MakeBazelTarget("cc_library_shared", name, sharedAttrs)
1365 staticTarget := MakeBazelTarget("cc_library_static", name+"_bp2build_cc_library_static", staticAttrs)
Chris Parsons77acf2e2021-12-03 17:27:16 -05001366
1367 return []string{staticTarget, sharedTarget}
Liz Kammerd366c902021-06-03 13:43:01 -04001368}
1369
Wei Li81852ca2022-07-27 00:22:06 -07001370func makeCcStubSuiteTargets(name string, attrs AttrNameToString) string {
1371 if _, hasStubs := attrs["stubs_symbol_file"]; !hasStubs {
1372 return ""
1373 }
1374 STUB_SUITE_ATTRS := map[string]string{
1375 "stubs_symbol_file": "symbol_file",
1376 "stubs_versions": "versions",
1377 "soname": "soname",
1378 "source_library": "source_library",
1379 }
1380
1381 stubSuiteAttrs := AttrNameToString{}
1382 for key, _ := range attrs {
1383 if _, stubSuiteAttr := STUB_SUITE_ATTRS[key]; stubSuiteAttr {
1384 stubSuiteAttrs[STUB_SUITE_ATTRS[key]] = attrs[key]
1385 }
1386 }
Alixe06d75b2022-08-31 18:28:19 +00001387 return MakeBazelTarget("cc_stub_suite", name+"_stub_libs", stubSuiteAttrs)
Wei Li81852ca2022-07-27 00:22:06 -07001388}
1389
Jingwen Chen6ada5892021-09-17 11:38:09 +00001390func TestCCLibraryNoLibCrtFalse(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001391 runCcLibraryTestCase(t, Bp2buildTestCase{
1392 ModuleTypeUnderTest: "cc_library",
1393 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1394 Filesystem: map[string]string{
Liz Kammerd366c902021-06-03 13:43:01 -04001395 "impl.cpp": "",
1396 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001397 Blueprint: soongCcLibraryPreamble + `
Liz Kammerd366c902021-06-03 13:43:01 -04001398cc_library {
1399 name: "foo-lib",
1400 srcs: ["impl.cpp"],
1401 no_libcrt: false,
Liz Kammer8337ea42021-09-10 10:06:32 -04001402 include_build_directory: false,
Liz Kammerd366c902021-06-03 13:43:01 -04001403}
1404`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001405 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001406 "srcs": `["impl.cpp"]`,
1407 "use_libcrt": `True`,
1408 }),
1409 })
Liz Kammerd366c902021-06-03 13:43:01 -04001410}
1411
Jingwen Chen6ada5892021-09-17 11:38:09 +00001412func TestCCLibraryNoLibCrtArchVariant(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001413 runCcLibraryTestCase(t, Bp2buildTestCase{
1414 ModuleTypeUnderTest: "cc_library",
1415 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1416 Filesystem: map[string]string{
Liz Kammerd366c902021-06-03 13:43:01 -04001417 "impl.cpp": "",
1418 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001419 Blueprint: soongCcLibraryPreamble + `
Liz Kammerd366c902021-06-03 13:43:01 -04001420cc_library {
1421 name: "foo-lib",
1422 srcs: ["impl.cpp"],
1423 arch: {
1424 arm: {
1425 no_libcrt: true,
1426 },
1427 x86: {
1428 no_libcrt: true,
1429 },
1430 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001431 include_build_directory: false,
Liz Kammerd366c902021-06-03 13:43:01 -04001432}
1433`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001434 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001435 "srcs": `["impl.cpp"]`,
1436 "use_libcrt": `select({
Liz Kammerd366c902021-06-03 13:43:01 -04001437 "//build/bazel/platforms/arch:arm": False,
1438 "//build/bazel/platforms/arch:x86": False,
1439 "//conditions:default": None,
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001440 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001441 }),
1442 })
Liz Kammerd366c902021-06-03 13:43:01 -04001443}
1444
Chris Parsons58852a02021-12-09 18:10:18 -05001445func TestCCLibraryNoLibCrtArchAndTargetVariant(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001446 runCcLibraryTestCase(t, Bp2buildTestCase{
1447 ModuleTypeUnderTest: "cc_library",
1448 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1449 Filesystem: map[string]string{
Chris Parsons58852a02021-12-09 18:10:18 -05001450 "impl.cpp": "",
1451 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001452 Blueprint: soongCcLibraryPreamble + `
Chris Parsons58852a02021-12-09 18:10:18 -05001453cc_library {
1454 name: "foo-lib",
1455 srcs: ["impl.cpp"],
1456 arch: {
1457 arm: {
1458 no_libcrt: true,
1459 },
1460 x86: {
1461 no_libcrt: true,
1462 },
1463 },
1464 target: {
1465 darwin: {
1466 no_libcrt: true,
1467 }
1468 },
1469 include_build_directory: false,
1470}
1471`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001472 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05001473 "srcs": `["impl.cpp"]`,
1474 "use_libcrt": `select({
1475 "//build/bazel/platforms/os_arch:android_arm": False,
1476 "//build/bazel/platforms/os_arch:android_x86": False,
1477 "//build/bazel/platforms/os_arch:darwin_arm64": False,
1478 "//build/bazel/platforms/os_arch:darwin_x86_64": False,
1479 "//build/bazel/platforms/os_arch:linux_glibc_x86": False,
1480 "//build/bazel/platforms/os_arch:linux_musl_x86": False,
1481 "//build/bazel/platforms/os_arch:windows_x86": False,
1482 "//conditions:default": None,
1483 })`,
1484 }),
1485 })
1486}
1487
1488func TestCCLibraryNoLibCrtArchAndTargetVariantConflict(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001489 runCcLibraryTestCase(t, Bp2buildTestCase{
1490 ModuleTypeUnderTest: "cc_library",
1491 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1492 Filesystem: map[string]string{
Chris Parsons58852a02021-12-09 18:10:18 -05001493 "impl.cpp": "",
1494 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001495 Blueprint: soongCcLibraryPreamble + `
Chris Parsons58852a02021-12-09 18:10:18 -05001496cc_library {
1497 name: "foo-lib",
1498 srcs: ["impl.cpp"],
1499 arch: {
1500 arm: {
1501 no_libcrt: true,
1502 },
1503 // This is expected to override the value for darwin_x86_64.
1504 x86_64: {
1505 no_libcrt: true,
1506 },
1507 },
1508 target: {
1509 darwin: {
1510 no_libcrt: false,
1511 }
1512 },
1513 include_build_directory: false,
1514}
1515`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001516 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05001517 "srcs": `["impl.cpp"]`,
1518 "use_libcrt": `select({
1519 "//build/bazel/platforms/os_arch:android_arm": False,
1520 "//build/bazel/platforms/os_arch:android_x86_64": False,
1521 "//build/bazel/platforms/os_arch:darwin_arm64": True,
1522 "//build/bazel/platforms/os_arch:darwin_x86_64": False,
1523 "//build/bazel/platforms/os_arch:linux_bionic_x86_64": False,
1524 "//build/bazel/platforms/os_arch:linux_glibc_x86_64": False,
1525 "//build/bazel/platforms/os_arch:linux_musl_x86_64": False,
1526 "//build/bazel/platforms/os_arch:windows_x86_64": False,
1527 "//conditions:default": None,
1528 })`,
1529 }),
1530 })
1531}
1532
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001533func TestCcLibraryStrip(t *testing.T) {
Chris Parsons77acf2e2021-12-03 17:27:16 -05001534 expectedTargets := []string{}
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001535 expectedTargets = append(expectedTargets, makeCcLibraryTargets("all", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001536 "strip": `{
1537 "all": True,
1538 }`,
1539 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001540 expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001541 "strip": `{
1542 "keep_symbols": True,
1543 }`,
1544 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001545 expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols_and_debug_frame", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001546 "strip": `{
1547 "keep_symbols_and_debug_frame": True,
1548 }`,
1549 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001550 expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols_list", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001551 "strip": `{
1552 "keep_symbols_list": ["symbol"],
1553 }`,
1554 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001555 expectedTargets = append(expectedTargets, makeCcLibraryTargets("none", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001556 "strip": `{
1557 "none": True,
1558 }`,
1559 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001560 expectedTargets = append(expectedTargets, makeCcLibraryTargets("nothing", AttrNameToString{})...)
Chris Parsons77acf2e2021-12-03 17:27:16 -05001561
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001562 runCcLibraryTestCase(t, Bp2buildTestCase{
1563 Description: "cc_library strip args",
1564 ModuleTypeUnderTest: "cc_library",
1565 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1566 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001567cc_library {
1568 name: "nothing",
Liz Kammer8337ea42021-09-10 10:06:32 -04001569 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001570}
1571cc_library {
1572 name: "keep_symbols",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001573 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001574 keep_symbols: true,
1575 },
1576 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001577}
1578cc_library {
1579 name: "keep_symbols_and_debug_frame",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001580 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001581 keep_symbols_and_debug_frame: true,
1582 },
1583 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001584}
1585cc_library {
1586 name: "none",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001587 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001588 none: true,
1589 },
1590 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001591}
1592cc_library {
1593 name: "keep_symbols_list",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001594 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001595 keep_symbols_list: ["symbol"],
1596 },
1597 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001598}
1599cc_library {
1600 name: "all",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001601 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001602 all: true,
1603 },
1604 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001605}
1606`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001607 ExpectedBazelTargets: expectedTargets,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001608 })
1609}
1610
1611func TestCcLibraryStripWithArch(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001612 runCcLibraryTestCase(t, Bp2buildTestCase{
1613 Description: "cc_library strip args",
1614 ModuleTypeUnderTest: "cc_library",
1615 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1616 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001617cc_library {
1618 name: "multi-arch",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001619 target: {
1620 darwin: {
1621 strip: {
1622 keep_symbols_list: ["foo", "bar"]
1623 }
1624 },
1625 },
1626 arch: {
1627 arm: {
1628 strip: {
1629 keep_symbols_and_debug_frame: true,
1630 },
1631 },
1632 arm64: {
1633 strip: {
1634 keep_symbols: true,
1635 },
1636 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001637 },
1638 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001639}
1640`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001641 ExpectedBazelTargets: makeCcLibraryTargets("multi-arch", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001642 "strip": `{
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001643 "keep_symbols": select({
1644 "//build/bazel/platforms/arch:arm64": True,
1645 "//conditions:default": None,
1646 }),
1647 "keep_symbols_and_debug_frame": select({
1648 "//build/bazel/platforms/arch:arm": True,
1649 "//conditions:default": None,
1650 }),
1651 "keep_symbols_list": select({
1652 "//build/bazel/platforms/os:darwin": [
1653 "foo",
1654 "bar",
1655 ],
1656 "//conditions:default": [],
1657 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001658 }`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001659 }),
1660 },
1661 )
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001662}
Chris Parsons51f8c392021-08-03 21:01:05 -04001663
1664func TestCcLibrary_SystemSharedLibsRootEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001665 runCcLibraryTestCase(t, Bp2buildTestCase{
1666 Description: "cc_library system_shared_libs empty at root",
1667 ModuleTypeUnderTest: "cc_library",
1668 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1669 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001670cc_library {
1671 name: "root_empty",
Liz Kammer8337ea42021-09-10 10:06:32 -04001672 system_shared_libs: [],
1673 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001674}
1675`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001676 ExpectedBazelTargets: makeCcLibraryTargets("root_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001677 "system_dynamic_deps": `[]`,
1678 }),
1679 },
1680 )
Chris Parsons51f8c392021-08-03 21:01:05 -04001681}
1682
1683func TestCcLibrary_SystemSharedLibsStaticEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001684 runCcLibraryTestCase(t, Bp2buildTestCase{
1685 Description: "cc_library system_shared_libs empty for static variant",
1686 ModuleTypeUnderTest: "cc_library",
1687 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1688 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001689cc_library {
1690 name: "static_empty",
1691 static: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001692 system_shared_libs: [],
1693 },
1694 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001695}
1696`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001697 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001698 MakeBazelTarget("cc_library_static", "static_empty_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001699 "system_dynamic_deps": "[]",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001700 }),
Alixe06d75b2022-08-31 18:28:19 +00001701 MakeBazelTarget("cc_library_shared", "static_empty", AttrNameToString{}),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001702 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001703 })
1704}
1705
1706func TestCcLibrary_SystemSharedLibsSharedEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001707 runCcLibraryTestCase(t, Bp2buildTestCase{
1708 Description: "cc_library system_shared_libs empty for shared variant",
1709 ModuleTypeUnderTest: "cc_library",
1710 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1711 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001712cc_library {
1713 name: "shared_empty",
1714 shared: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001715 system_shared_libs: [],
1716 },
1717 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001718}
1719`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001720 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001721 MakeBazelTarget("cc_library_static", "shared_empty_bp2build_cc_library_static", AttrNameToString{}),
1722 MakeBazelTarget("cc_library_shared", "shared_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001723 "system_dynamic_deps": "[]",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001724 }),
1725 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001726 })
1727}
1728
1729func TestCcLibrary_SystemSharedLibsSharedBionicEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001730 runCcLibraryTestCase(t, Bp2buildTestCase{
1731 Description: "cc_library system_shared_libs empty for shared, bionic variant",
1732 ModuleTypeUnderTest: "cc_library",
1733 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1734 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001735cc_library {
1736 name: "shared_empty",
1737 target: {
1738 bionic: {
1739 shared: {
1740 system_shared_libs: [],
1741 }
1742 }
Liz Kammer8337ea42021-09-10 10:06:32 -04001743 },
1744 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001745}
1746`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001747 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001748 MakeBazelTarget("cc_library_static", "shared_empty_bp2build_cc_library_static", AttrNameToString{}),
1749 MakeBazelTarget("cc_library_shared", "shared_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001750 "system_dynamic_deps": "[]",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001751 }),
1752 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001753 })
1754}
1755
1756func TestCcLibrary_SystemSharedLibsLinuxBionicEmpty(t *testing.T) {
1757 // Note that this behavior is technically incorrect (it's a simplification).
1758 // The correct behavior would be if bp2build wrote `system_dynamic_deps = []`
1759 // only for linux_bionic, but `android` had `["libc", "libdl", "libm"].
1760 // b/195791252 tracks the fix.
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001761 runCcLibraryTestCase(t, Bp2buildTestCase{
1762 Description: "cc_library system_shared_libs empty for linux_bionic variant",
1763 ModuleTypeUnderTest: "cc_library",
1764 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1765 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001766cc_library {
1767 name: "target_linux_bionic_empty",
1768 target: {
1769 linux_bionic: {
1770 system_shared_libs: [],
1771 },
1772 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001773 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001774}
1775`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001776 ExpectedBazelTargets: makeCcLibraryTargets("target_linux_bionic_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001777 "system_dynamic_deps": `[]`,
1778 }),
1779 },
1780 )
Chris Parsons51f8c392021-08-03 21:01:05 -04001781}
1782
1783func TestCcLibrary_SystemSharedLibsBionicEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001784 runCcLibraryTestCase(t, Bp2buildTestCase{
1785 Description: "cc_library system_shared_libs empty for bionic variant",
1786 ModuleTypeUnderTest: "cc_library",
1787 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1788 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001789cc_library {
1790 name: "target_bionic_empty",
1791 target: {
1792 bionic: {
1793 system_shared_libs: [],
1794 },
1795 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001796 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001797}
1798`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001799 ExpectedBazelTargets: makeCcLibraryTargets("target_bionic_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001800 "system_dynamic_deps": `[]`,
1801 }),
1802 },
1803 )
Chris Parsons51f8c392021-08-03 21:01:05 -04001804}
1805
1806func TestCcLibrary_SystemSharedLibsSharedAndRoot(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001807 runCcLibraryTestCase(t, Bp2buildTestCase{
1808 Description: "cc_library system_shared_libs set for shared and root",
1809 ModuleTypeUnderTest: "cc_library",
1810 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1811 Blueprint: soongCcLibraryPreamble + `
Liz Kammer8337ea42021-09-10 10:06:32 -04001812cc_library {
1813 name: "libc",
1814 bazel_module: { bp2build_available: false },
1815}
1816cc_library {
1817 name: "libm",
1818 bazel_module: { bp2build_available: false },
1819}
Chris Parsons51f8c392021-08-03 21:01:05 -04001820
1821cc_library {
1822 name: "foo",
1823 system_shared_libs: ["libc"],
1824 shared: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001825 system_shared_libs: ["libm"],
Chris Parsons51f8c392021-08-03 21:01:05 -04001826 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001827 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001828}
1829`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001830 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001831 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001832 "system_dynamic_deps": `[":libc"]`,
1833 }),
Alixe06d75b2022-08-31 18:28:19 +00001834 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001835 "system_dynamic_deps": `[
1836 ":libc",
1837 ":libm",
1838 ]`,
1839 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001840 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001841 })
1842}
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001843
1844func TestCcLibraryOsSelects(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001845 runCcLibraryTestCase(t, Bp2buildTestCase{
1846 Description: "cc_library - selects for all os targets",
1847 ModuleTypeUnderTest: "cc_library",
1848 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1849 Filesystem: map[string]string{},
1850 Blueprint: soongCcLibraryPreamble + `
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001851cc_library {
1852 name: "foo-lib",
1853 srcs: ["base.cpp"],
1854 target: {
1855 android: {
1856 srcs: ["android.cpp"],
1857 },
1858 linux: {
1859 srcs: ["linux.cpp"],
1860 },
1861 linux_glibc: {
1862 srcs: ["linux_glibc.cpp"],
1863 },
1864 darwin: {
1865 srcs: ["darwin.cpp"],
1866 },
1867 bionic: {
1868 srcs: ["bionic.cpp"],
1869 },
1870 linux_musl: {
1871 srcs: ["linux_musl.cpp"],
1872 },
1873 windows: {
1874 srcs: ["windows.cpp"],
1875 },
1876 },
1877 include_build_directory: false,
1878}
1879`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001880 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001881 "srcs": `["base.cpp"] + select({
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001882 "//build/bazel/platforms/os:android": [
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001883 "linux.cpp",
Liz Kammer9bad9d62021-10-11 15:40:35 -04001884 "bionic.cpp",
Liz Kammerfdd72e62021-10-11 15:41:03 -04001885 "android.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001886 ],
1887 "//build/bazel/platforms/os:darwin": ["darwin.cpp"],
1888 "//build/bazel/platforms/os:linux": [
Liz Kammer9bad9d62021-10-11 15:40:35 -04001889 "linux.cpp",
Liz Kammerfdd72e62021-10-11 15:41:03 -04001890 "linux_glibc.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001891 ],
1892 "//build/bazel/platforms/os:linux_bionic": [
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001893 "linux.cpp",
Liz Kammer9bad9d62021-10-11 15:40:35 -04001894 "bionic.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001895 ],
1896 "//build/bazel/platforms/os:linux_musl": [
Liz Kammer9bad9d62021-10-11 15:40:35 -04001897 "linux.cpp",
Liz Kammerfdd72e62021-10-11 15:41:03 -04001898 "linux_musl.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001899 ],
1900 "//build/bazel/platforms/os:windows": ["windows.cpp"],
1901 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001902 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001903 }),
1904 },
1905 )
Jingwen Chen97b85312021-10-08 10:41:31 +00001906}
1907
Yu Liu75be7b92022-02-01 09:54:09 -08001908func TestLibcryptoHashInjection(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001909 runCcLibraryTestCase(t, Bp2buildTestCase{
1910 Description: "cc_library - libcrypto hash injection",
1911 ModuleTypeUnderTest: "cc_library",
1912 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1913 Filesystem: map[string]string{},
1914 Blueprint: soongCcLibraryPreamble + `
Yu Liu75be7b92022-02-01 09:54:09 -08001915cc_library {
1916 name: "libcrypto",
1917 target: {
1918 android: {
1919 inject_bssl_hash: true,
1920 },
1921 },
1922 include_build_directory: false,
1923}
1924`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001925 ExpectedBazelTargets: makeCcLibraryTargets("libcrypto", AttrNameToString{
Yu Liu75be7b92022-02-01 09:54:09 -08001926 "inject_bssl_hash": `select({
1927 "//build/bazel/platforms/os:android": True,
1928 "//conditions:default": None,
1929 })`,
1930 }),
1931 },
1932 )
1933}
1934
Jingwen Chen5b11ab12021-10-11 17:44:33 +00001935func TestCcLibraryCppStdWithGnuExtensions_ConvertsToFeatureAttr(t *testing.T) {
Jingwen Chen97b85312021-10-08 10:41:31 +00001936 type testCase struct {
1937 cpp_std string
Chris Parsons79bd2b72021-11-29 17:52:41 -05001938 c_std string
Jingwen Chen97b85312021-10-08 10:41:31 +00001939 gnu_extensions string
1940 bazel_cpp_std string
Chris Parsons79bd2b72021-11-29 17:52:41 -05001941 bazel_c_std string
Jingwen Chen97b85312021-10-08 10:41:31 +00001942 }
1943
1944 testCases := []testCase{
1945 // Existing usages of cpp_std in AOSP are:
1946 // experimental, c++11, c++17, c++2a, c++98, gnu++11, gnu++17
1947 //
1948 // not set, only emit if gnu_extensions is disabled. the default (gnu+17
1949 // is set in the toolchain.)
1950 {cpp_std: "", gnu_extensions: "", bazel_cpp_std: ""},
Liz Kammera5a29de2022-05-25 23:19:37 -04001951 {cpp_std: "", gnu_extensions: "false", bazel_cpp_std: "cpp_std_default_no_gnu", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001952 {cpp_std: "", gnu_extensions: "true", bazel_cpp_std: ""},
1953 // experimental defaults to gnu++2a
Liz Kammera5a29de2022-05-25 23:19:37 -04001954 {cpp_std: "experimental", gnu_extensions: "", bazel_cpp_std: "cpp_std_experimental"},
1955 {cpp_std: "experimental", gnu_extensions: "false", bazel_cpp_std: "cpp_std_experimental_no_gnu", bazel_c_std: "c_std_default_no_gnu"},
1956 {cpp_std: "experimental", gnu_extensions: "true", bazel_cpp_std: "cpp_std_experimental"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001957 // Explicitly setting a c++ std does not use replace gnu++ std even if
1958 // gnu_extensions is true.
1959 // "c++11",
1960 {cpp_std: "c++11", gnu_extensions: "", bazel_cpp_std: "c++11"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001961 {cpp_std: "c++11", gnu_extensions: "false", bazel_cpp_std: "c++11", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001962 {cpp_std: "c++11", gnu_extensions: "true", bazel_cpp_std: "c++11"},
1963 // "c++17",
1964 {cpp_std: "c++17", gnu_extensions: "", bazel_cpp_std: "c++17"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001965 {cpp_std: "c++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001966 {cpp_std: "c++17", gnu_extensions: "true", bazel_cpp_std: "c++17"},
1967 // "c++2a",
1968 {cpp_std: "c++2a", gnu_extensions: "", bazel_cpp_std: "c++2a"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001969 {cpp_std: "c++2a", gnu_extensions: "false", bazel_cpp_std: "c++2a", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001970 {cpp_std: "c++2a", gnu_extensions: "true", bazel_cpp_std: "c++2a"},
1971 // "c++98",
1972 {cpp_std: "c++98", gnu_extensions: "", bazel_cpp_std: "c++98"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001973 {cpp_std: "c++98", gnu_extensions: "false", bazel_cpp_std: "c++98", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001974 {cpp_std: "c++98", gnu_extensions: "true", bazel_cpp_std: "c++98"},
1975 // gnu++ is replaced with c++ if gnu_extensions is explicitly false.
1976 // "gnu++11",
1977 {cpp_std: "gnu++11", gnu_extensions: "", bazel_cpp_std: "gnu++11"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001978 {cpp_std: "gnu++11", gnu_extensions: "false", bazel_cpp_std: "c++11", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001979 {cpp_std: "gnu++11", gnu_extensions: "true", bazel_cpp_std: "gnu++11"},
1980 // "gnu++17",
1981 {cpp_std: "gnu++17", gnu_extensions: "", bazel_cpp_std: "gnu++17"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001982 {cpp_std: "gnu++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001983 {cpp_std: "gnu++17", gnu_extensions: "true", bazel_cpp_std: "gnu++17"},
Chris Parsons79bd2b72021-11-29 17:52:41 -05001984
1985 // some c_std test cases
Liz Kammera5a29de2022-05-25 23:19:37 -04001986 {c_std: "experimental", gnu_extensions: "", bazel_c_std: "c_std_experimental"},
1987 {c_std: "experimental", gnu_extensions: "false", bazel_cpp_std: "cpp_std_default_no_gnu", bazel_c_std: "c_std_experimental_no_gnu"},
1988 {c_std: "experimental", gnu_extensions: "true", bazel_c_std: "c_std_experimental"},
Chris Parsons79bd2b72021-11-29 17:52:41 -05001989 {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "", bazel_cpp_std: "gnu++17", bazel_c_std: "gnu11"},
1990 {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c11"},
1991 {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "true", bazel_cpp_std: "gnu++17", bazel_c_std: "gnu11"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001992 }
Chris Parsons79bd2b72021-11-29 17:52:41 -05001993 for i, tc := range testCases {
Liz Kammera5a29de2022-05-25 23:19:37 -04001994 name := fmt.Sprintf("cpp std: %q, c std: %q, gnu_extensions: %q", tc.cpp_std, tc.c_std, tc.gnu_extensions)
1995 t.Run(name, func(t *testing.T) {
1996 name_prefix := fmt.Sprintf("a_%v", i)
1997 cppStdProp := ""
1998 if tc.cpp_std != "" {
1999 cppStdProp = fmt.Sprintf(" cpp_std: \"%s\",", tc.cpp_std)
2000 }
2001 cStdProp := ""
2002 if tc.c_std != "" {
2003 cStdProp = fmt.Sprintf(" c_std: \"%s\",", tc.c_std)
2004 }
2005 gnuExtensionsProp := ""
2006 if tc.gnu_extensions != "" {
2007 gnuExtensionsProp = fmt.Sprintf(" gnu_extensions: %s,", tc.gnu_extensions)
2008 }
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002009 attrs := AttrNameToString{}
Liz Kammera5a29de2022-05-25 23:19:37 -04002010 if tc.bazel_cpp_std != "" {
2011 attrs["cpp_std"] = fmt.Sprintf(`"%s"`, tc.bazel_cpp_std)
2012 }
2013 if tc.bazel_c_std != "" {
2014 attrs["c_std"] = fmt.Sprintf(`"%s"`, tc.bazel_c_std)
2015 }
Jingwen Chen97b85312021-10-08 10:41:31 +00002016
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002017 runCcLibraryTestCase(t, Bp2buildTestCase{
2018 Description: fmt.Sprintf(
Liz Kammera5a29de2022-05-25 23:19:37 -04002019 "cc_library with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002020 ModuleTypeUnderTest: "cc_library",
2021 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2022 Blueprint: soongCcLibraryPreamble + fmt.Sprintf(`
Jingwen Chen97b85312021-10-08 10:41:31 +00002023cc_library {
Chris Parsons79bd2b72021-11-29 17:52:41 -05002024 name: "%s_full",
Jingwen Chen97b85312021-10-08 10:41:31 +00002025%s // cpp_std: *string
Chris Parsons79bd2b72021-11-29 17:52:41 -05002026%s // c_std: *string
Jingwen Chen97b85312021-10-08 10:41:31 +00002027%s // gnu_extensions: *bool
2028 include_build_directory: false,
2029}
Chris Parsons79bd2b72021-11-29 17:52:41 -05002030`, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002031 ExpectedBazelTargets: makeCcLibraryTargets(name_prefix+"_full", attrs),
Liz Kammera5a29de2022-05-25 23:19:37 -04002032 })
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002033
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002034 runCcLibraryStaticTestCase(t, Bp2buildTestCase{
2035 Description: fmt.Sprintf(
Liz Kammera5a29de2022-05-25 23:19:37 -04002036 "cc_library_static with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002037 ModuleTypeUnderTest: "cc_library_static",
2038 ModuleTypeUnderTestFactory: cc.LibraryStaticFactory,
2039 Blueprint: soongCcLibraryPreamble + fmt.Sprintf(`
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002040cc_library_static {
Chris Parsons79bd2b72021-11-29 17:52:41 -05002041 name: "%s_static",
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002042%s // cpp_std: *string
Chris Parsons79bd2b72021-11-29 17:52:41 -05002043%s // c_std: *string
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002044%s // gnu_extensions: *bool
2045 include_build_directory: false,
2046}
Chris Parsons79bd2b72021-11-29 17:52:41 -05002047`, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002048 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002049 MakeBazelTarget("cc_library_static", name_prefix+"_static", attrs),
Liz Kammera5a29de2022-05-25 23:19:37 -04002050 },
2051 })
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002052
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002053 runCcLibrarySharedTestCase(t, Bp2buildTestCase{
2054 Description: fmt.Sprintf(
Liz Kammera5a29de2022-05-25 23:19:37 -04002055 "cc_library_shared with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002056 ModuleTypeUnderTest: "cc_library_shared",
2057 ModuleTypeUnderTestFactory: cc.LibrarySharedFactory,
2058 Blueprint: soongCcLibraryPreamble + fmt.Sprintf(`
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002059cc_library_shared {
Chris Parsons79bd2b72021-11-29 17:52:41 -05002060 name: "%s_shared",
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002061%s // cpp_std: *string
Chris Parsons79bd2b72021-11-29 17:52:41 -05002062%s // c_std: *string
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002063%s // gnu_extensions: *bool
2064 include_build_directory: false,
2065}
Chris Parsons79bd2b72021-11-29 17:52:41 -05002066`, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002067 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002068 MakeBazelTarget("cc_library_shared", name_prefix+"_shared", attrs),
Liz Kammera5a29de2022-05-25 23:19:37 -04002069 },
2070 })
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002071 })
Jingwen Chen97b85312021-10-08 10:41:31 +00002072 }
Chris Parsons2dde0cb2021-10-01 14:45:30 -04002073}
Liz Kammer12615db2021-09-28 09:19:17 -04002074
2075func TestCcLibraryProtoSimple(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002076 runCcLibraryTestCase(t, Bp2buildTestCase{
2077 ModuleTypeUnderTest: "cc_library",
2078 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2079 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002080 name: "foo",
2081 srcs: ["foo.proto"],
2082 include_build_directory: false,
2083}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002084 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002085 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer7756c8f2022-02-14 20:49:15 -05002086 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002087 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002088 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002089 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002090 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002091 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002092 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002093 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2094 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002095 }),
2096 },
2097 })
2098}
2099
2100func TestCcLibraryProtoNoCanonicalPathFromRoot(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002101 runCcLibraryTestCase(t, Bp2buildTestCase{
2102 ModuleTypeUnderTest: "cc_library",
2103 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2104 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002105 name: "foo",
2106 srcs: ["foo.proto"],
2107 proto: { canonical_path_from_root: false},
2108 include_build_directory: false,
2109}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002110 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002111 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer7756c8f2022-02-14 20:49:15 -05002112 "srcs": `["foo.proto"]`,
2113 "strip_import_prefix": `""`,
Alixe06d75b2022-08-31 18:28:19 +00002114 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002115 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002116 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002117 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002118 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002119 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002120 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2121 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002122 }),
2123 },
2124 })
2125}
2126
2127func TestCcLibraryProtoExplicitCanonicalPathFromRoot(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002128 runCcLibraryTestCase(t, Bp2buildTestCase{
2129 ModuleTypeUnderTest: "cc_library",
2130 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2131 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002132 name: "foo",
2133 srcs: ["foo.proto"],
2134 proto: { canonical_path_from_root: true},
2135 include_build_directory: false,
2136}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002137 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002138 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer7756c8f2022-02-14 20:49:15 -05002139 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002140 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002141 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002142 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002143 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002144 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002145 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002146 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2147 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002148 }),
2149 },
2150 })
2151}
2152
2153func TestCcLibraryProtoFull(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002154 runCcLibraryTestCase(t, Bp2buildTestCase{
2155 ModuleTypeUnderTest: "cc_library",
2156 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2157 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002158 name: "foo",
2159 srcs: ["foo.proto"],
2160 proto: {
Liz Kammer12615db2021-09-28 09:19:17 -04002161 type: "full",
2162 },
2163 include_build_directory: false,
2164}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002165 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002166 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002167 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002168 }), MakeBazelTarget("cc_proto_library", "foo_cc_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002169 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002170 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002171 "implementation_whole_archive_deps": `[":foo_cc_proto"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002172 "deps": `[":libprotobuf-cpp-full"]`,
Alixe06d75b2022-08-31 18:28:19 +00002173 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002174 "dynamic_deps": `[":libprotobuf-cpp-full"]`,
2175 "implementation_whole_archive_deps": `[":foo_cc_proto"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002176 }),
2177 },
2178 })
2179}
2180
2181func TestCcLibraryProtoLite(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002182 runCcLibraryTestCase(t, Bp2buildTestCase{
2183 ModuleTypeUnderTest: "cc_library",
2184 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2185 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002186 name: "foo",
2187 srcs: ["foo.proto"],
2188 proto: {
Liz Kammer12615db2021-09-28 09:19:17 -04002189 type: "lite",
2190 },
2191 include_build_directory: false,
2192}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002193 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002194 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002195 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002196 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002197 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002198 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002199 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002200 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002201 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002202 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2203 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002204 }),
2205 },
2206 })
2207}
2208
2209func TestCcLibraryProtoExportHeaders(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002210 runCcLibraryTestCase(t, Bp2buildTestCase{
2211 ModuleTypeUnderTest: "cc_library",
2212 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2213 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002214 name: "foo",
2215 srcs: ["foo.proto"],
2216 proto: {
Liz Kammer12615db2021-09-28 09:19:17 -04002217 export_proto_headers: true,
2218 },
2219 include_build_directory: false,
2220}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002221 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002222 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002223 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002224 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002225 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002226 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05002227 "deps": `[":libprotobuf-cpp-lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002228 "whole_archive_deps": `[":foo_cc_proto_lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002229 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05002230 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2231 "whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002232 }),
2233 },
2234 })
2235}
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002236
Yu Liu2d136142022-08-18 14:46:13 -07002237func TestCcLibraryProtoIncludeDirs(t *testing.T) {
2238 runCcLibraryTestCase(t, Bp2buildTestCase{
2239 ModuleTypeUnderTest: "cc_library",
2240 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2241 Blueprint: soongCcProtoPreamble + `cc_library {
2242 name: "foo",
2243 srcs: ["foo.proto"],
2244 proto: {
2245 include_dirs: ["external/protobuf/src"],
2246 },
2247 include_build_directory: false,
2248}`,
2249 ExpectedBazelTargets: []string{
2250 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
2251 "srcs": `["foo.proto"]`,
2252 "deps": `["//external/protobuf:libprotobuf-proto"]`,
2253 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
2254 "deps": `[":foo_proto"]`,
2255 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
2256 "deps": `[":libprotobuf-cpp-lite"]`,
2257 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
2258 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002259 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2260 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Yu Liu2d136142022-08-18 14:46:13 -07002261 }),
2262 },
2263 })
2264}
2265
2266func TestCcLibraryProtoIncludeDirsUnknown(t *testing.T) {
2267 runCcLibraryTestCase(t, Bp2buildTestCase{
2268 ModuleTypeUnderTest: "cc_library",
2269 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2270 Blueprint: soongCcProtoPreamble + `cc_library {
2271 name: "foo",
2272 srcs: ["foo.proto"],
2273 proto: {
2274 include_dirs: ["external/protobuf/abc"],
2275 },
2276 include_build_directory: false,
2277}`,
2278 ExpectedErr: fmt.Errorf("module \"foo\": Could not find the proto_library target for include dir: external/protobuf/abc"),
2279 })
2280}
2281
Yu Liu2aa806b2022-09-01 11:54:47 -07002282func TestCcLibraryConvertedProtoFilegroups(t *testing.T) {
2283 runCcLibraryTestCase(t, Bp2buildTestCase{
2284 ModuleTypeUnderTest: "cc_library",
2285 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2286 Blueprint: soongCcProtoPreamble + `
2287filegroup {
2288 name: "a_fg_proto",
2289 srcs: ["a_fg.proto"],
2290}
2291
2292cc_library {
2293 name: "a",
2294 srcs: [
2295 ":a_fg_proto",
2296 "a.proto",
2297 ],
2298 proto: {
2299 export_proto_headers: true,
2300 },
2301 include_build_directory: false,
2302}`,
2303 ExpectedBazelTargets: []string{
2304 MakeBazelTarget("proto_library", "a_proto", AttrNameToString{
Yu Liu2a85fb12022-09-15 22:18:48 -07002305 "deps": `[":a_fg_proto_bp2build_converted"]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002306 "srcs": `["a.proto"]`,
2307 }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
2308 "deps": `[
2309 ":a_fg_proto_bp2build_converted",
2310 ":a_proto",
2311 ]`,
2312 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
2313 "deps": `[":libprotobuf-cpp-lite"]`,
2314 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2315 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
2316 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2317 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2318 }), MakeBazelTargetNoRestrictions("proto_library", "a_fg_proto_bp2build_converted", AttrNameToString{
2319 "srcs": `["a_fg.proto"]`,
Yu Liu2a85fb12022-09-15 22:18:48 -07002320 "tags": `["manual"]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002321 }), MakeBazelTargetNoRestrictions("filegroup", "a_fg_proto", AttrNameToString{
2322 "srcs": `["a_fg.proto"]`,
2323 }),
2324 },
2325 })
2326}
2327
2328func TestCcLibraryConvertedProtoFilegroupsNoProtoFiles(t *testing.T) {
2329 runCcLibraryTestCase(t, Bp2buildTestCase{
2330 ModuleTypeUnderTest: "cc_library",
2331 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2332 Blueprint: soongCcProtoPreamble + `
2333filegroup {
2334 name: "a_fg_proto",
2335 srcs: ["a_fg.proto"],
2336}
2337
2338cc_library {
2339 name: "a",
2340 srcs: [
2341 ":a_fg_proto",
2342 ],
2343 proto: {
2344 export_proto_headers: true,
2345 },
2346 include_build_directory: false,
2347}`,
2348 ExpectedBazelTargets: []string{
2349 MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
2350 "deps": `[":a_fg_proto_bp2build_converted"]`,
2351 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
2352 "deps": `[":libprotobuf-cpp-lite"]`,
2353 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2354 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
2355 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2356 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2357 }), MakeBazelTargetNoRestrictions("proto_library", "a_fg_proto_bp2build_converted", AttrNameToString{
2358 "srcs": `["a_fg.proto"]`,
Yu Liu2a85fb12022-09-15 22:18:48 -07002359 "tags": `["manual"]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002360 }), MakeBazelTargetNoRestrictions("filegroup", "a_fg_proto", AttrNameToString{
2361 "srcs": `["a_fg.proto"]`,
2362 }),
2363 },
2364 })
2365}
2366
2367func TestCcLibraryExternalConvertedProtoFilegroups(t *testing.T) {
2368 runCcLibraryTestCase(t, Bp2buildTestCase{
2369 ModuleTypeUnderTest: "cc_library",
2370 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2371 Filesystem: map[string]string{
2372 "path/to/A/Android.bp": `
2373filegroup {
2374 name: "a_fg_proto",
2375 srcs: ["a_fg.proto"],
2376}`,
2377 },
2378 Blueprint: soongCcProtoPreamble + `
2379cc_library {
2380 name: "a",
2381 srcs: [
2382 ":a_fg_proto",
2383 "a.proto",
2384 ],
2385 proto: {
2386 export_proto_headers: true,
2387 },
2388 include_build_directory: false,
2389}`,
2390 ExpectedBazelTargets: []string{
2391 MakeBazelTarget("proto_library", "a_proto", AttrNameToString{
Yu Liu2a85fb12022-09-15 22:18:48 -07002392 "deps": `["//path/to/A:a_fg_proto_bp2build_converted"]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002393 "srcs": `["a.proto"]`,
2394 }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
2395 "deps": `[
2396 "//path/to/A:a_fg_proto_bp2build_converted",
2397 ":a_proto",
2398 ]`,
2399 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
2400 "deps": `[":libprotobuf-cpp-lite"]`,
2401 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2402 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
2403 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2404 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2405 }),
2406 },
2407 })
2408}
2409
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002410func TestCcLibraryProtoFilegroups(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002411 runCcLibraryTestCase(t, Bp2buildTestCase{
2412 ModuleTypeUnderTest: "cc_library",
2413 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2414 Blueprint: soongCcProtoPreamble +
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002415 simpleModuleDoNotConvertBp2build("filegroup", "a_fg_proto") +
2416 simpleModuleDoNotConvertBp2build("filegroup", "b_protos") +
2417 simpleModuleDoNotConvertBp2build("filegroup", "c-proto-srcs") +
2418 simpleModuleDoNotConvertBp2build("filegroup", "proto-srcs-d") + `
2419cc_library {
2420 name: "a",
2421 srcs: [":a_fg_proto"],
2422 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002423 export_proto_headers: true,
2424 },
2425 include_build_directory: false,
2426}
2427
2428cc_library {
2429 name: "b",
2430 srcs: [":b_protos"],
2431 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002432 export_proto_headers: true,
2433 },
2434 include_build_directory: false,
2435}
2436
2437cc_library {
2438 name: "c",
2439 srcs: [":c-proto-srcs"],
2440 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002441 export_proto_headers: true,
2442 },
2443 include_build_directory: false,
2444}
2445
2446cc_library {
2447 name: "d",
2448 srcs: [":proto-srcs-d"],
2449 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002450 export_proto_headers: true,
2451 },
2452 include_build_directory: false,
2453}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002454 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002455 MakeBazelTarget("proto_library", "a_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002456 "srcs": `[":a_fg_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002457 }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002458 "deps": `[":a_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002459 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002460 "deps": `[":libprotobuf-cpp-lite"]`,
2461 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2462 "srcs": `[":a_fg_proto_cpp_srcs"]`,
2463 "srcs_as": `[":a_fg_proto_as_srcs"]`,
2464 "srcs_c": `[":a_fg_proto_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002465 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002466 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2467 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2468 "srcs": `[":a_fg_proto_cpp_srcs"]`,
2469 "srcs_as": `[":a_fg_proto_as_srcs"]`,
2470 "srcs_c": `[":a_fg_proto_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002471 }), MakeBazelTarget("proto_library", "b_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002472 "srcs": `[":b_protos"]`,
Alixe06d75b2022-08-31 18:28:19 +00002473 }), MakeBazelTarget("cc_lite_proto_library", "b_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002474 "deps": `[":b_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002475 }), MakeBazelTarget("cc_library_static", "b_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002476 "deps": `[":libprotobuf-cpp-lite"]`,
2477 "whole_archive_deps": `[":b_cc_proto_lite"]`,
2478 "srcs": `[":b_protos_cpp_srcs"]`,
2479 "srcs_as": `[":b_protos_as_srcs"]`,
2480 "srcs_c": `[":b_protos_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002481 }), MakeBazelTarget("cc_library_shared", "b", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002482 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2483 "whole_archive_deps": `[":b_cc_proto_lite"]`,
2484 "srcs": `[":b_protos_cpp_srcs"]`,
2485 "srcs_as": `[":b_protos_as_srcs"]`,
2486 "srcs_c": `[":b_protos_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002487 }), MakeBazelTarget("proto_library", "c_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002488 "srcs": `[":c-proto-srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002489 }), MakeBazelTarget("cc_lite_proto_library", "c_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002490 "deps": `[":c_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002491 }), MakeBazelTarget("cc_library_static", "c_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002492 "deps": `[":libprotobuf-cpp-lite"]`,
2493 "whole_archive_deps": `[":c_cc_proto_lite"]`,
2494 "srcs": `[":c-proto-srcs_cpp_srcs"]`,
2495 "srcs_as": `[":c-proto-srcs_as_srcs"]`,
2496 "srcs_c": `[":c-proto-srcs_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002497 }), MakeBazelTarget("cc_library_shared", "c", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002498 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2499 "whole_archive_deps": `[":c_cc_proto_lite"]`,
2500 "srcs": `[":c-proto-srcs_cpp_srcs"]`,
2501 "srcs_as": `[":c-proto-srcs_as_srcs"]`,
2502 "srcs_c": `[":c-proto-srcs_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002503 }), MakeBazelTarget("proto_library", "d_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002504 "srcs": `[":proto-srcs-d"]`,
Alixe06d75b2022-08-31 18:28:19 +00002505 }), MakeBazelTarget("cc_lite_proto_library", "d_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002506 "deps": `[":d_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002507 }), MakeBazelTarget("cc_library_static", "d_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002508 "deps": `[":libprotobuf-cpp-lite"]`,
2509 "whole_archive_deps": `[":d_cc_proto_lite"]`,
2510 "srcs": `[":proto-srcs-d_cpp_srcs"]`,
2511 "srcs_as": `[":proto-srcs-d_as_srcs"]`,
2512 "srcs_c": `[":proto-srcs-d_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002513 }), MakeBazelTarget("cc_library_shared", "d", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002514 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2515 "whole_archive_deps": `[":d_cc_proto_lite"]`,
2516 "srcs": `[":proto-srcs-d_cpp_srcs"]`,
2517 "srcs_as": `[":proto-srcs-d_as_srcs"]`,
2518 "srcs_c": `[":proto-srcs-d_c_srcs"]`,
2519 }),
2520 },
2521 })
2522}
Chris Parsons58852a02021-12-09 18:10:18 -05002523
2524func TestCcLibraryDisabledArchAndTarget(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002525 runCcLibraryTestCase(t, Bp2buildTestCase{
2526 ModuleTypeUnderTest: "cc_library",
2527 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2528 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002529 name: "foo",
2530 srcs: ["foo.cpp"],
Liz Kammerdfeb1202022-05-13 17:20:20 -04002531 host_supported: true,
Chris Parsons58852a02021-12-09 18:10:18 -05002532 target: {
2533 darwin: {
2534 enabled: false,
2535 },
2536 windows: {
2537 enabled: false,
2538 },
2539 linux_glibc_x86: {
2540 enabled: false,
2541 },
2542 },
2543 include_build_directory: false,
2544}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002545 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002546 "srcs": `["foo.cpp"]`,
2547 "target_compatible_with": `select({
2548 "//build/bazel/platforms/os_arch:darwin_arm64": ["@platforms//:incompatible"],
2549 "//build/bazel/platforms/os_arch:darwin_x86_64": ["@platforms//:incompatible"],
2550 "//build/bazel/platforms/os_arch:linux_glibc_x86": ["@platforms//:incompatible"],
2551 "//build/bazel/platforms/os_arch:windows_x86": ["@platforms//:incompatible"],
2552 "//build/bazel/platforms/os_arch:windows_x86_64": ["@platforms//:incompatible"],
2553 "//conditions:default": [],
2554 })`,
2555 }),
2556 })
2557}
2558
2559func TestCcLibraryDisabledArchAndTargetWithDefault(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002560 runCcLibraryTestCase(t, Bp2buildTestCase{
2561 ModuleTypeUnderTest: "cc_library",
2562 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2563 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002564 name: "foo",
2565 srcs: ["foo.cpp"],
2566 enabled: false,
Liz Kammerdfeb1202022-05-13 17:20:20 -04002567 host_supported: true,
Chris Parsons58852a02021-12-09 18:10:18 -05002568 target: {
2569 darwin: {
2570 enabled: true,
2571 },
2572 windows: {
2573 enabled: false,
2574 },
2575 linux_glibc_x86: {
2576 enabled: false,
2577 },
2578 },
2579 include_build_directory: false,
2580}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002581 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002582 "srcs": `["foo.cpp"]`,
2583 "target_compatible_with": `select({
2584 "//build/bazel/platforms/os_arch:darwin_arm64": [],
2585 "//build/bazel/platforms/os_arch:darwin_x86_64": [],
2586 "//conditions:default": ["@platforms//:incompatible"],
2587 })`,
2588 }),
2589 })
2590}
2591
2592func TestCcLibrarySharedDisabled(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002593 runCcLibraryTestCase(t, Bp2buildTestCase{
2594 ModuleTypeUnderTest: "cc_library",
2595 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2596 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002597 name: "foo",
2598 srcs: ["foo.cpp"],
2599 enabled: false,
2600 shared: {
2601 enabled: true,
2602 },
2603 target: {
2604 android: {
2605 shared: {
2606 enabled: false,
2607 },
2608 }
2609 },
2610 include_build_directory: false,
2611}`,
Alixe06d75b2022-08-31 18:28:19 +00002612 ExpectedBazelTargets: []string{MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002613 "srcs": `["foo.cpp"]`,
2614 "target_compatible_with": `["@platforms//:incompatible"]`,
Alixe06d75b2022-08-31 18:28:19 +00002615 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002616 "srcs": `["foo.cpp"]`,
2617 "target_compatible_with": `select({
2618 "//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
2619 "//conditions:default": [],
2620 })`,
2621 }),
2622 },
2623 })
2624}
2625
2626func TestCcLibraryStaticDisabledForSomeArch(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002627 runCcLibraryTestCase(t, Bp2buildTestCase{
2628 ModuleTypeUnderTest: "cc_library",
2629 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2630 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002631 name: "foo",
Liz Kammerdfeb1202022-05-13 17:20:20 -04002632 host_supported: true,
Chris Parsons58852a02021-12-09 18:10:18 -05002633 srcs: ["foo.cpp"],
2634 shared: {
2635 enabled: false
2636 },
2637 target: {
2638 darwin: {
2639 enabled: true,
2640 },
2641 windows: {
2642 enabled: false,
2643 },
2644 linux_glibc_x86: {
2645 shared: {
2646 enabled: true,
2647 },
2648 },
2649 },
2650 include_build_directory: false,
2651}`,
Alixe06d75b2022-08-31 18:28:19 +00002652 ExpectedBazelTargets: []string{MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002653 "srcs": `["foo.cpp"]`,
2654 "target_compatible_with": `select({
2655 "//build/bazel/platforms/os:windows": ["@platforms//:incompatible"],
2656 "//conditions:default": [],
2657 })`,
Alixe06d75b2022-08-31 18:28:19 +00002658 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002659 "srcs": `["foo.cpp"]`,
2660 "target_compatible_with": `select({
2661 "//build/bazel/platforms/os_arch:darwin_arm64": [],
2662 "//build/bazel/platforms/os_arch:darwin_x86_64": [],
2663 "//build/bazel/platforms/os_arch:linux_glibc_x86": [],
2664 "//conditions:default": ["@platforms//:incompatible"],
2665 })`,
2666 }),
2667 }})
2668}
Jingwen Chen0ee88a62022-01-07 14:55:29 +00002669
2670func TestCcLibraryStubs(t *testing.T) {
Wei Li81852ca2022-07-27 00:22:06 -07002671 expectedBazelTargets := makeCcLibraryTargets("a", AttrNameToString{
2672 "has_stubs": `True`,
2673 })
2674 expectedBazelTargets = append(expectedBazelTargets, makeCcStubSuiteTargets("a", AttrNameToString{
2675 "soname": `"a.so"`,
2676 "source_library": `":a"`,
2677 "stubs_symbol_file": `"a.map.txt"`,
2678 "stubs_versions": `[
2679 "28",
2680 "29",
2681 "current",
2682 ]`,
2683 }))
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002684 runCcLibraryTestCase(t, Bp2buildTestCase{
2685 Description: "cc_library stubs",
2686 ModuleTypeUnderTest: "cc_library",
2687 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2688 Dir: "foo/bar",
2689 Filesystem: map[string]string{
Jingwen Chen0ee88a62022-01-07 14:55:29 +00002690 "foo/bar/Android.bp": `
2691cc_library {
2692 name: "a",
2693 stubs: { symbol_file: "a.map.txt", versions: ["28", "29", "current"] },
2694 bazel_module: { bp2build_available: true },
2695 include_build_directory: false,
2696}
2697`,
2698 },
Wei Li81852ca2022-07-27 00:22:06 -07002699 Blueprint: soongCcLibraryPreamble,
2700 ExpectedBazelTargets: expectedBazelTargets,
Jingwen Chen0ee88a62022-01-07 14:55:29 +00002701 },
2702 )
2703}
Liz Kammerf38a8372022-02-04 15:39:00 -05002704
Trevor Radcliffe0ed6b7d2022-09-12 20:19:26 +00002705func TestCcLibraryStubsAcrossConfigsDuplicatesRemoved(t *testing.T) {
2706 runCcLibraryTestCase(t, Bp2buildTestCase{
2707 Description: "stub target generation of the same lib across configs should not result in duplicates",
2708 ModuleTypeUnderTest: "cc_library",
2709 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2710 Filesystem: map[string]string{
2711 "bar.map.txt": "",
2712 },
2713 Blueprint: `
2714cc_library {
2715 name: "barlib",
2716 stubs: { symbol_file: "bar.map.txt", versions: ["28", "29", "current"] },
2717 bazel_module: { bp2build_available: false },
2718}
2719cc_library {
2720 name: "foolib",
2721 shared_libs: ["barlib"],
2722 target: {
2723 android: {
2724 shared_libs: ["barlib"],
2725 },
2726 },
2727 bazel_module: { bp2build_available: true },
2728}`,
2729 ExpectedBazelTargets: makeCcLibraryTargets("foolib", AttrNameToString{
2730 "implementation_dynamic_deps": `select({
2731 "//build/bazel/rules/apex:android-in_apex": [":barlib_stub_libs_current"],
2732 "//conditions:default": [":barlib"],
2733 })`,
2734 "local_includes": `["."]`,
2735 }),
2736 })
2737}
2738
Liz Kammerf38a8372022-02-04 15:39:00 -05002739func TestCcLibraryEscapeLdflags(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002740 runCcLibraryTestCase(t, Bp2buildTestCase{
2741 ModuleTypeUnderTest: "cc_library",
2742 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2743 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammerf38a8372022-02-04 15:39:00 -05002744 name: "foo",
2745 ldflags: ["-Wl,--rpath,${ORIGIN}"],
2746 include_build_directory: false,
2747}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002748 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
Liz Kammerf38a8372022-02-04 15:39:00 -05002749 "linkopts": `["-Wl,--rpath,$${ORIGIN}"]`,
2750 }),
2751 })
2752}
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002753
2754func TestCcLibraryConvertLex(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002755 runCcLibraryTestCase(t, Bp2buildTestCase{
2756 ModuleTypeUnderTest: "cc_library",
2757 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2758 Filesystem: map[string]string{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002759 "foo.c": "",
2760 "bar.cc": "",
2761 "foo1.l": "",
2762 "bar1.ll": "",
2763 "foo2.l": "",
2764 "bar2.ll": "",
2765 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002766 Blueprint: `cc_library {
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002767 name: "foo_lib",
2768 srcs: ["foo.c", "bar.cc", "foo1.l", "foo2.l", "bar1.ll", "bar2.ll"],
2769 lex: { flags: ["--foo_flags"] },
2770 include_build_directory: false,
2771 bazel_module: { bp2build_available: true },
2772}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002773 ExpectedBazelTargets: append([]string{
Alixe06d75b2022-08-31 18:28:19 +00002774 MakeBazelTarget("genlex", "foo_lib_genlex_l", AttrNameToString{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002775 "srcs": `[
2776 "foo1.l",
2777 "foo2.l",
2778 ]`,
2779 "lexopts": `["--foo_flags"]`,
2780 }),
Alixe06d75b2022-08-31 18:28:19 +00002781 MakeBazelTarget("genlex", "foo_lib_genlex_ll", AttrNameToString{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002782 "srcs": `[
2783 "bar1.ll",
2784 "bar2.ll",
2785 ]`,
2786 "lexopts": `["--foo_flags"]`,
2787 }),
2788 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002789 makeCcLibraryTargets("foo_lib", AttrNameToString{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002790 "srcs": `[
2791 "bar.cc",
2792 ":foo_lib_genlex_ll",
2793 ]`,
2794 "srcs_c": `[
2795 "foo.c",
2796 ":foo_lib_genlex_l",
2797 ]`,
2798 })...),
2799 })
2800}
Cole Faust6b29f592022-08-09 09:50:56 -07002801
2802func TestCCLibraryRuntimeDeps(t *testing.T) {
2803 runCcLibrarySharedTestCase(t, Bp2buildTestCase{
2804 Blueprint: `cc_library_shared {
2805 name: "bar",
2806}
2807
2808cc_library {
2809 name: "foo",
2810 runtime_libs: ["foo"],
2811}`,
2812 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002813 MakeBazelTarget("cc_library_shared", "bar", AttrNameToString{
Cole Faust6b29f592022-08-09 09:50:56 -07002814 "local_includes": `["."]`,
2815 }),
Alixe06d75b2022-08-31 18:28:19 +00002816 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Cole Faust6b29f592022-08-09 09:50:56 -07002817 "runtime_deps": `[":foo"]`,
2818 "local_includes": `["."]`,
2819 }),
Alixe06d75b2022-08-31 18:28:19 +00002820 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Cole Faust6b29f592022-08-09 09:50:56 -07002821 "runtime_deps": `[":foo"]`,
2822 "local_includes": `["."]`,
2823 }),
2824 },
2825 })
2826}
Cole Faust5fa4e962022-08-22 14:31:04 -07002827
2828func TestCcLibraryWithInstructionSet(t *testing.T) {
2829 runCcLibraryTestCase(t, Bp2buildTestCase{
2830 ModuleTypeUnderTest: "cc_library",
2831 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2832 Blueprint: `cc_library {
2833 name: "foo",
2834 arch: {
2835 arm: {
2836 instruction_set: "arm",
2837 }
2838 }
2839}
2840`,
2841 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
2842 "features": `select({
2843 "//build/bazel/platforms/arch:arm": [
2844 "arm_isa_arm",
2845 "-arm_isa_thumb",
2846 ],
2847 "//conditions:default": [],
2848 })`,
2849 "local_includes": `["."]`,
2850 }),
2851 })
2852}
Vinh Tran9f6796a2022-08-16 13:10:31 -04002853
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002854func TestCcLibraryEmptySuffix(t *testing.T) {
2855 runCcLibraryTestCase(t, Bp2buildTestCase{
2856 Description: "cc_library with empty suffix",
2857 ModuleTypeUnderTest: "cc_library",
2858 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2859 Filesystem: map[string]string{
2860 "foo.c": "",
2861 },
2862 Blueprint: `cc_library {
2863 name: "foo",
2864 suffix: "",
2865 srcs: ["foo.c"],
2866 include_build_directory: false,
2867}`,
2868 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002869 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002870 "srcs_c": `["foo.c"]`,
2871 }),
Alixe06d75b2022-08-31 18:28:19 +00002872 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002873 "srcs_c": `["foo.c"]`,
2874 "suffix": `""`,
2875 }),
2876 },
2877 })
2878}
2879
2880func TestCcLibrarySuffix(t *testing.T) {
2881 runCcLibraryTestCase(t, Bp2buildTestCase{
2882 Description: "cc_library with suffix",
2883 ModuleTypeUnderTest: "cc_library",
2884 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2885 Filesystem: map[string]string{
2886 "foo.c": "",
2887 },
2888 Blueprint: `cc_library {
2889 name: "foo",
2890 suffix: "-suf",
2891 srcs: ["foo.c"],
2892 include_build_directory: false,
2893}`,
2894 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002895 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002896 "srcs_c": `["foo.c"]`,
2897 }),
Alixe06d75b2022-08-31 18:28:19 +00002898 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002899 "srcs_c": `["foo.c"]`,
2900 "suffix": `"-suf"`,
2901 }),
2902 },
2903 })
2904}
2905
2906func TestCcLibraryArchVariantSuffix(t *testing.T) {
2907 runCcLibraryTestCase(t, Bp2buildTestCase{
2908 Description: "cc_library with arch-variant suffix",
2909 ModuleTypeUnderTest: "cc_library",
2910 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2911 Filesystem: map[string]string{
2912 "foo.c": "",
2913 },
2914 Blueprint: `cc_library {
2915 name: "foo",
2916 arch: {
2917 arm64: { suffix: "-64" },
2918 arm: { suffix: "-32" },
2919 },
2920 srcs: ["foo.c"],
2921 include_build_directory: false,
2922}`,
2923 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002924 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002925 "srcs_c": `["foo.c"]`,
2926 }),
Alixe06d75b2022-08-31 18:28:19 +00002927 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002928 "srcs_c": `["foo.c"]`,
2929 "suffix": `select({
2930 "//build/bazel/platforms/arch:arm": "-32",
2931 "//build/bazel/platforms/arch:arm64": "-64",
2932 "//conditions:default": None,
2933 })`,
2934 }),
2935 },
2936 })
2937}
2938
Vinh Tran9f6796a2022-08-16 13:10:31 -04002939func TestCcLibraryWithAidlSrcs(t *testing.T) {
2940 runCcLibraryTestCase(t, Bp2buildTestCase{
2941 Description: "cc_library with aidl srcs",
2942 ModuleTypeUnderTest: "cc_library",
2943 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2944 Blueprint: `
2945filegroup {
2946 name: "A_aidl",
2947 srcs: ["aidl/A.aidl"],
2948 path: "aidl",
2949}
2950cc_library {
2951 name: "foo",
2952 srcs: [
2953 ":A_aidl",
2954 "B.aidl",
2955 ],
2956}`,
2957 ExpectedBazelTargets: []string{
2958 MakeBazelTargetNoRestrictions("aidl_library", "A_aidl", AttrNameToString{
2959 "srcs": `["aidl/A.aidl"]`,
2960 "strip_import_prefix": `"aidl"`,
2961 }),
Alixe06d75b2022-08-31 18:28:19 +00002962 MakeBazelTarget("aidl_library", "foo_aidl_library", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04002963 "srcs": `["B.aidl"]`,
2964 }),
Alixe06d75b2022-08-31 18:28:19 +00002965 MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04002966 "deps": `[
2967 ":A_aidl",
2968 ":foo_aidl_library",
2969 ]`,
2970 }),
Alixe06d75b2022-08-31 18:28:19 +00002971 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Vinh Tranfde57eb2022-08-29 17:46:58 -04002972 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
2973 "local_includes": `["."]`,
Vinh Tran9f6796a2022-08-16 13:10:31 -04002974 }),
Alixe06d75b2022-08-31 18:28:19 +00002975 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002976 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
2977 "local_includes": `["."]`,
Vinh Tran9f6796a2022-08-16 13:10:31 -04002978 }),
2979 },
2980 })
2981}
2982
2983func TestCcLibraryWithNonAdjacentAidlFilegroup(t *testing.T) {
2984 runCcLibraryTestCase(t, Bp2buildTestCase{
2985 Description: "cc_library with non aidl filegroup",
2986 ModuleTypeUnderTest: "cc_library",
2987 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2988 Filesystem: map[string]string{
2989 "path/to/A/Android.bp": `
2990filegroup {
Vinh Tranfde57eb2022-08-29 17:46:58 -04002991 name: "A_aidl",
2992 srcs: ["aidl/A.aidl"],
2993 path: "aidl",
Vinh Tran9f6796a2022-08-16 13:10:31 -04002994}`,
2995 },
2996 Blueprint: `
2997cc_library {
Vinh Tranfde57eb2022-08-29 17:46:58 -04002998 name: "foo",
2999 srcs: [
3000 ":A_aidl",
3001 ],
Vinh Tran9f6796a2022-08-16 13:10:31 -04003002}`,
3003 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00003004 MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04003005 "deps": `["//path/to/A:A_aidl"]`,
3006 }),
Alixe06d75b2022-08-31 18:28:19 +00003007 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Vinh Tranfde57eb2022-08-29 17:46:58 -04003008 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
3009 "local_includes": `["."]`,
3010 }),
Vinh Tranfde57eb2022-08-29 17:46:58 -04003011 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04003012 "local_includes": `["."]`,
3013 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
Vinh Tranfde57eb2022-08-29 17:46:58 -04003014 }),
3015 },
3016 })
3017}
3018
3019func TestCcLibraryWithExportAidlHeaders(t *testing.T) {
3020 runCcLibraryTestCase(t, Bp2buildTestCase{
3021 Description: "cc_library with export aidl headers",
3022 ModuleTypeUnderTest: "cc_library",
3023 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3024 Blueprint: `
3025cc_library {
3026 name: "foo",
3027 srcs: [
3028 "Foo.aidl",
3029 ],
3030 aidl: {
3031 export_aidl_headers: true,
3032 }
3033}`,
3034 ExpectedBazelTargets: []string{
3035 MakeBazelTarget("aidl_library", "foo_aidl_library", AttrNameToString{
3036 "srcs": `["Foo.aidl"]`,
3037 }),
3038 MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{
3039 "deps": `[":foo_aidl_library"]`,
3040 }),
3041 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04003042 "whole_archive_deps": `[":foo_cc_aidl_library"]`,
3043 "local_includes": `["."]`,
3044 }),
Alixe06d75b2022-08-31 18:28:19 +00003045 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04003046 "whole_archive_deps": `[":foo_cc_aidl_library"]`,
3047 "local_includes": `["."]`,
3048 }),
3049 },
3050 })
3051}
Vinh Tran85fb07c2022-09-16 16:17:48 -04003052
3053func TestCcLibraryWithTargetApex(t *testing.T) {
3054 runCcLibraryTestCase(t, Bp2buildTestCase{
3055 Description: "cc_library with target.apex",
3056 ModuleTypeUnderTest: "cc_library",
3057 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3058 Blueprint: `
3059cc_library {
3060 name: "foo",
3061 shared_libs: ["bar", "baz"],
3062 static_libs: ["baz", "buh"],
3063 target: {
3064 apex: {
3065 exclude_shared_libs: ["bar"],
3066 exclude_static_libs: ["buh"],
3067 }
3068 }
3069}`,
3070 ExpectedBazelTargets: []string{
3071 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
3072 "implementation_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({
3073 "//build/bazel/rules/apex:non_apex": [":buh__BP2BUILD__MISSING__DEP"],
3074 "//conditions:default": [],
3075 })`,
3076 "implementation_dynamic_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({
3077 "//build/bazel/rules/apex:non_apex": [":bar__BP2BUILD__MISSING__DEP"],
3078 "//conditions:default": [],
3079 })`,
3080 "local_includes": `["."]`,
3081 }),
3082 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
3083 "implementation_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({
3084 "//build/bazel/rules/apex:non_apex": [":buh__BP2BUILD__MISSING__DEP"],
3085 "//conditions:default": [],
3086 })`,
3087 "implementation_dynamic_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({
3088 "//build/bazel/rules/apex:non_apex": [":bar__BP2BUILD__MISSING__DEP"],
3089 "//conditions:default": [],
3090 })`,
3091 "local_includes": `["."]`,
3092 }),
3093 },
3094 })
3095}
3096
3097func TestCcLibraryWithTargetApexAndExportLibHeaders(t *testing.T) {
3098 runCcLibraryTestCase(t, Bp2buildTestCase{
3099 Description: "cc_library with target.apex and export_shared|static_lib_headers",
3100 ModuleTypeUnderTest: "cc_library",
3101 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3102 Blueprint: `
3103cc_library_static {
3104 name: "foo",
3105 shared_libs: ["bar", "baz"],
3106 static_libs: ["abc"],
3107 export_shared_lib_headers: ["baz"],
3108 export_static_lib_headers: ["abc"],
3109 target: {
3110 apex: {
3111 exclude_shared_libs: ["baz", "bar"],
3112 exclude_static_libs: ["abc"],
3113 }
3114 }
3115}`,
3116 ExpectedBazelTargets: []string{
3117 MakeBazelTarget("cc_library_static", "foo", AttrNameToString{
3118 "implementation_dynamic_deps": `select({
3119 "//build/bazel/rules/apex:non_apex": [":bar__BP2BUILD__MISSING__DEP"],
3120 "//conditions:default": [],
3121 })`,
3122 "dynamic_deps": `select({
3123 "//build/bazel/rules/apex:non_apex": [":baz__BP2BUILD__MISSING__DEP"],
3124 "//conditions:default": [],
3125 })`,
3126 "deps": `select({
3127 "//build/bazel/rules/apex:non_apex": [":abc__BP2BUILD__MISSING__DEP"],
3128 "//conditions:default": [],
3129 })`,
3130 "local_includes": `["."]`,
3131 }),
3132 },
3133 })
3134}
Trevor Radcliffecee4e052022-09-06 19:31:25 +00003135
3136func TestCcLibraryWithSyspropSrcs(t *testing.T) {
3137 runCcLibraryTestCase(t, Bp2buildTestCase{
3138 Description: "cc_library with sysprop sources",
3139 ModuleTypeUnderTest: "cc_library",
3140 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3141 Blueprint: `
3142cc_library {
3143 name: "foo",
3144 srcs: [
3145 "bar.sysprop",
3146 "baz.sysprop",
3147 "blah.cpp",
3148 ],
3149 min_sdk_version: "5",
3150}`,
3151 ExpectedBazelTargets: []string{
3152 MakeBazelTarget("sysprop_library", "foo_sysprop_library", AttrNameToString{
3153 "srcs": `[
3154 "bar.sysprop",
3155 "baz.sysprop",
3156 ]`,
3157 }),
3158 MakeBazelTarget("cc_sysprop_library_static", "foo_cc_sysprop_library_static", AttrNameToString{
3159 "dep": `":foo_sysprop_library"`,
3160 "min_sdk_version": `"5"`,
3161 }),
3162 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
3163 "srcs": `["blah.cpp"]`,
3164 "local_includes": `["."]`,
3165 "min_sdk_version": `"5"`,
3166 "whole_archive_deps": `[":foo_cc_sysprop_library_static"]`,
3167 }),
3168 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
3169 "srcs": `["blah.cpp"]`,
3170 "local_includes": `["."]`,
3171 "min_sdk_version": `"5"`,
3172 "whole_archive_deps": `[":foo_cc_sysprop_library_static"]`,
3173 }),
3174 },
3175 })
3176}
3177
3178func TestCcLibraryWithSyspropSrcsSomeConfigs(t *testing.T) {
3179 runCcLibraryTestCase(t, Bp2buildTestCase{
3180 Description: "cc_library with sysprop sources in some configs but not others",
3181 ModuleTypeUnderTest: "cc_library",
3182 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3183 Blueprint: `
3184cc_library {
3185 name: "foo",
3186 host_supported: true,
3187 srcs: [
3188 "blah.cpp",
3189 ],
3190 target: {
3191 android: {
3192 srcs: ["bar.sysprop"],
3193 },
3194 },
3195 min_sdk_version: "5",
3196}`,
3197 ExpectedBazelTargets: []string{
3198 MakeBazelTargetNoRestrictions("sysprop_library", "foo_sysprop_library", AttrNameToString{
3199 "srcs": `select({
3200 "//build/bazel/platforms/os:android": ["bar.sysprop"],
3201 "//conditions:default": [],
3202 })`,
3203 }),
3204 MakeBazelTargetNoRestrictions("cc_sysprop_library_static", "foo_cc_sysprop_library_static", AttrNameToString{
3205 "dep": `":foo_sysprop_library"`,
3206 "min_sdk_version": `"5"`,
3207 }),
3208 MakeBazelTargetNoRestrictions("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
3209 "srcs": `["blah.cpp"]`,
3210 "local_includes": `["."]`,
3211 "min_sdk_version": `"5"`,
3212 "whole_archive_deps": `select({
3213 "//build/bazel/platforms/os:android": [":foo_cc_sysprop_library_static"],
3214 "//conditions:default": [],
3215 })`,
3216 }),
3217 MakeBazelTargetNoRestrictions("cc_library_shared", "foo", AttrNameToString{
3218 "srcs": `["blah.cpp"]`,
3219 "local_includes": `["."]`,
3220 "min_sdk_version": `"5"`,
3221 "whole_archive_deps": `select({
3222 "//build/bazel/platforms/os:android": [":foo_cc_sysprop_library_static"],
3223 "//conditions:default": [],
3224 })`,
3225 }),
3226 },
3227 })
3228}