blob: 12cffc304214ca3a4362cf489f626e6f28ee9057 [file] [log] [blame]
Jingwen Chen63930982021-03-24 10:04:33 -04001// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package bp2build
16
17import (
Jingwen Chen6ada5892021-09-17 11:38:09 +000018 "fmt"
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux1c92aef2021-08-23 16:10:00 +000019 "testing"
20
Jingwen Chen63930982021-03-24 10:04:33 -040021 "android/soong/android"
22 "android/soong/cc"
Jingwen Chen63930982021-03-24 10:04:33 -040023)
24
25const (
26 // See cc/testing.go for more context
27 soongCcLibraryPreamble = `
28cc_defaults {
Liz Kammer8337ea42021-09-10 10:06:32 -040029 name: "linux_bionic_supported",
Jingwen Chen63930982021-03-24 10:04:33 -040030}`
Liz Kammer12615db2021-09-28 09:19:17 -040031
32 soongCcProtoLibraries = `
33cc_library {
34 name: "libprotobuf-cpp-lite",
35 bazel_module: { bp2build_available: false },
36}
37
38cc_library {
39 name: "libprotobuf-cpp-full",
40 bazel_module: { bp2build_available: false },
41}`
42
43 soongCcProtoPreamble = soongCcLibraryPreamble + soongCcProtoLibraries
Jingwen Chen63930982021-03-24 10:04:33 -040044)
45
Sam Delmerico3177a6e2022-06-21 19:28:33 +000046func runCcLibraryTestCase(t *testing.T, tc Bp2buildTestCase) {
Liz Kammere4982e82021-05-25 10:39:35 -040047 t.Helper()
Sam Delmerico3177a6e2022-06-21 19:28:33 +000048 RunBp2BuildTestCase(t, registerCcLibraryModuleTypes, tc)
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020049}
50
51func registerCcLibraryModuleTypes(ctx android.RegistrationContext) {
52 cc.RegisterCCBuildComponents(ctx)
Jingwen Chen14a8bda2021-06-02 11:10:02 +000053 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020054 ctx.RegisterModuleType("cc_library_static", cc.LibraryStaticFactory)
Liz Kammer2d7bbe32021-06-10 18:20:06 -040055 ctx.RegisterModuleType("cc_prebuilt_library_static", cc.PrebuiltStaticLibraryFactory)
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020056 ctx.RegisterModuleType("cc_library_headers", cc.LibraryHeaderFactory)
57}
58
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020059func TestCcLibrarySimple(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +000060 runCcLibraryTestCase(t, Bp2buildTestCase{
61 Description: "cc_library - simple example",
62 ModuleTypeUnderTest: "cc_library",
63 ModuleTypeUnderTestFactory: cc.LibraryFactory,
64 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020065 "android.cpp": "",
Liz Kammer01a16e82021-07-16 16:33:47 -040066 "bionic.cpp": "",
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020067 "darwin.cpp": "",
68 // Refer to cc.headerExts for the supported header extensions in Soong.
69 "header.h": "",
70 "header.hh": "",
71 "header.hpp": "",
72 "header.hxx": "",
73 "header.h++": "",
74 "header.inl": "",
75 "header.inc": "",
76 "header.ipp": "",
77 "header.h.generic": "",
78 "impl.cpp": "",
79 "linux.cpp": "",
80 "x86.cpp": "",
81 "x86_64.cpp": "",
82 "foo-dir/a.h": "",
83 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +000084 Blueprint: soongCcLibraryPreamble +
Liz Kammer78cfdaa2021-11-08 12:56:31 -050085 simpleModuleDoNotConvertBp2build("cc_library_headers", "some-headers") + `
Jingwen Chen63930982021-03-24 10:04:33 -040086cc_library {
87 name: "foo-lib",
88 srcs: ["impl.cpp"],
89 cflags: ["-Wall"],
90 header_libs: ["some-headers"],
91 export_include_dirs: ["foo-dir"],
92 ldflags: ["-Wl,--exclude-libs=bar.a"],
93 arch: {
94 x86: {
95 ldflags: ["-Wl,--exclude-libs=baz.a"],
96 srcs: ["x86.cpp"],
97 },
98 x86_64: {
99 ldflags: ["-Wl,--exclude-libs=qux.a"],
100 srcs: ["x86_64.cpp"],
101 },
102 },
103 target: {
104 android: {
105 srcs: ["android.cpp"],
106 },
107 linux_glibc: {
108 srcs: ["linux.cpp"],
109 },
110 darwin: {
111 srcs: ["darwin.cpp"],
112 },
Liz Kammer01a16e82021-07-16 16:33:47 -0400113 bionic: {
114 srcs: ["bionic.cpp"]
115 },
Jingwen Chen63930982021-03-24 10:04:33 -0400116 },
Liz Kammer8337ea42021-09-10 10:06:32 -0400117 include_build_directory: false,
Yu Liufc603162022-03-01 15:44:08 -0800118 sdk_version: "current",
119 min_sdk_version: "29",
Yu Liua79c9462022-03-22 16:35:22 -0700120 use_version_lib: true,
Jingwen Chen63930982021-03-24 10:04:33 -0400121}
122`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000123 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500124 "copts": `["-Wall"]`,
125 "export_includes": `["foo-dir"]`,
126 "implementation_deps": `[":some-headers"]`,
127 "linkopts": `["-Wl,--exclude-libs=bar.a"] + select({
Jingwen Chened9c17d2021-04-13 07:14:55 +0000128 "//build/bazel/platforms/arch:x86": ["-Wl,--exclude-libs=baz.a"],
129 "//build/bazel/platforms/arch:x86_64": ["-Wl,--exclude-libs=qux.a"],
130 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500131 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500132 "srcs": `["impl.cpp"] + select({
Jingwen Chenb4628eb2021-04-08 14:40:57 +0000133 "//build/bazel/platforms/arch:x86": ["x86.cpp"],
134 "//build/bazel/platforms/arch:x86_64": ["x86_64.cpp"],
Jingwen Chen63930982021-03-24 10:04:33 -0400135 "//conditions:default": [],
136 }) + select({
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400137 "//build/bazel/platforms/os:android": [
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400138 "bionic.cpp",
Liz Kammerfdd72e62021-10-11 15:41:03 -0400139 "android.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400140 ],
Jingwen Chenb4628eb2021-04-08 14:40:57 +0000141 "//build/bazel/platforms/os:darwin": ["darwin.cpp"],
142 "//build/bazel/platforms/os:linux": ["linux.cpp"],
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400143 "//build/bazel/platforms/os:linux_bionic": ["bionic.cpp"],
Liz Kammer01a16e82021-07-16 16:33:47 -0400144 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500145 })`,
Yu Liua79c9462022-03-22 16:35:22 -0700146 "sdk_version": `"current"`,
147 "min_sdk_version": `"29"`,
148 "use_version_lib": `True`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500149 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500150 })
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200151}
152
153func TestCcLibraryTrimmedLdAndroid(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000154 runCcLibraryTestCase(t, Bp2buildTestCase{
155 Description: "cc_library - trimmed example of //bionic/linker:ld-android",
156 ModuleTypeUnderTest: "cc_library",
157 ModuleTypeUnderTestFactory: cc.LibraryFactory,
158 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200159 "ld-android.cpp": "",
160 "linked_list.h": "",
161 "linker.h": "",
162 "linker_block_allocator.h": "",
163 "linker_cfi.h": "",
Jingwen Chen63930982021-03-24 10:04:33 -0400164 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000165 Blueprint: soongCcLibraryPreamble +
Liz Kammerbe46fcc2021-11-01 15:32:43 -0400166 simpleModuleDoNotConvertBp2build("cc_library_headers", "libc_headers") + `
Jingwen Chen63930982021-03-24 10:04:33 -0400167cc_library {
168 name: "fake-ld-android",
169 srcs: ["ld_android.cpp"],
170 cflags: [
171 "-Wall",
172 "-Wextra",
173 "-Wunused",
174 "-Werror",
175 ],
176 header_libs: ["libc_headers"],
177 ldflags: [
178 "-Wl,--exclude-libs=libgcc.a",
179 "-Wl,--exclude-libs=libgcc_stripped.a",
180 "-Wl,--exclude-libs=libclang_rt.builtins-arm-android.a",
181 "-Wl,--exclude-libs=libclang_rt.builtins-aarch64-android.a",
182 "-Wl,--exclude-libs=libclang_rt.builtins-i686-android.a",
183 "-Wl,--exclude-libs=libclang_rt.builtins-x86_64-android.a",
184 ],
185 arch: {
186 x86: {
187 ldflags: ["-Wl,--exclude-libs=libgcc_eh.a"],
188 },
189 x86_64: {
190 ldflags: ["-Wl,--exclude-libs=libgcc_eh.a"],
191 },
192 },
Liz Kammer8337ea42021-09-10 10:06:32 -0400193 include_build_directory: false,
Jingwen Chen63930982021-03-24 10:04:33 -0400194}
195`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000196 ExpectedBazelTargets: makeCcLibraryTargets("fake-ld-android", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500197 "srcs": `["ld_android.cpp"]`,
198 "copts": `[
Jingwen Chen63930982021-03-24 10:04:33 -0400199 "-Wall",
200 "-Wextra",
201 "-Wunused",
202 "-Werror",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500203 ]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500204 "implementation_deps": `[":libc_headers"]`,
205 "linkopts": `[
Jingwen Chen63930982021-03-24 10:04:33 -0400206 "-Wl,--exclude-libs=libgcc.a",
207 "-Wl,--exclude-libs=libgcc_stripped.a",
208 "-Wl,--exclude-libs=libclang_rt.builtins-arm-android.a",
209 "-Wl,--exclude-libs=libclang_rt.builtins-aarch64-android.a",
210 "-Wl,--exclude-libs=libclang_rt.builtins-i686-android.a",
211 "-Wl,--exclude-libs=libclang_rt.builtins-x86_64-android.a",
212 ] + select({
Jingwen Chenb4628eb2021-04-08 14:40:57 +0000213 "//build/bazel/platforms/arch:x86": ["-Wl,--exclude-libs=libgcc_eh.a"],
214 "//build/bazel/platforms/arch:x86_64": ["-Wl,--exclude-libs=libgcc_eh.a"],
Jingwen Chen63930982021-03-24 10:04:33 -0400215 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500216 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500217 }),
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200218 })
219}
220
221func TestCcLibraryExcludeSrcs(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000222 runCcLibraryTestCase(t, Bp2buildTestCase{
223 Description: "cc_library exclude_srcs - trimmed example of //external/arm-optimized-routines:libarm-optimized-routines-math",
224 ModuleTypeUnderTest: "cc_library",
225 ModuleTypeUnderTestFactory: cc.LibraryFactory,
226 Dir: "external",
227 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200228 "external/math/cosf.c": "",
229 "external/math/erf.c": "",
230 "external/math/erf_data.c": "",
231 "external/math/erff.c": "",
232 "external/math/erff_data.c": "",
233 "external/Android.bp": `
Jingwen Chen4ecc67d2021-04-27 09:47:02 +0000234cc_library {
235 name: "fake-libarm-optimized-routines-math",
236 exclude_srcs: [
237 // Provided by:
238 // bionic/libm/upstream-freebsd/lib/msun/src/s_erf.c
239 // bionic/libm/upstream-freebsd/lib/msun/src/s_erff.c
240 "math/erf.c",
241 "math/erf_data.c",
242 "math/erff.c",
243 "math/erff_data.c",
244 ],
245 srcs: [
246 "math/*.c",
247 ],
248 // arch-specific settings
249 arch: {
250 arm64: {
251 cflags: [
252 "-DHAVE_FAST_FMA=1",
253 ],
254 },
255 },
256 bazel_module: { bp2build_available: true },
257}
258`,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200259 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000260 Blueprint: soongCcLibraryPreamble,
261 ExpectedBazelTargets: makeCcLibraryTargets("fake-libarm-optimized-routines-math", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500262 "copts": `select({
Jingwen Chen4ecc67d2021-04-27 09:47:02 +0000263 "//build/bazel/platforms/arch:arm64": ["-DHAVE_FAST_FMA=1"],
264 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500265 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500266 "local_includes": `["."]`,
267 "srcs_c": `["math/cosf.c"]`,
268 }),
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200269 })
270}
271
272func TestCcLibrarySharedStaticProps(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000273 runCcLibraryTestCase(t, Bp2buildTestCase{
274 Description: "cc_library shared/static props",
275 ModuleTypeUnderTest: "cc_library",
276 ModuleTypeUnderTestFactory: cc.LibraryFactory,
277 Filesystem: map[string]string{
Liz Kammer8337ea42021-09-10 10:06:32 -0400278 "both.cpp": "",
279 "sharedonly.cpp": "",
280 "staticonly.cpp": "",
281 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000282 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen53681ef2021-04-29 08:15:13 +0000283cc_library {
284 name: "a",
Chris Parsons08648312021-05-06 16:23:19 -0400285 srcs: ["both.cpp"],
286 cflags: ["bothflag"],
287 shared_libs: ["shared_dep_for_both"],
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400288 static_libs: ["static_dep_for_both", "whole_and_static_lib_for_both"],
289 whole_static_libs: ["whole_static_lib_for_both", "whole_and_static_lib_for_both"],
Chris Parsons08648312021-05-06 16:23:19 -0400290 static: {
291 srcs: ["staticonly.cpp"],
292 cflags: ["staticflag"],
293 shared_libs: ["shared_dep_for_static"],
294 static_libs: ["static_dep_for_static"],
295 whole_static_libs: ["whole_static_lib_for_static"],
296 },
297 shared: {
298 srcs: ["sharedonly.cpp"],
299 cflags: ["sharedflag"],
300 shared_libs: ["shared_dep_for_shared"],
301 static_libs: ["static_dep_for_shared"],
302 whole_static_libs: ["whole_static_lib_for_shared"],
303 },
Liz Kammer8337ea42021-09-10 10:06:32 -0400304 include_build_directory: false,
Jingwen Chen53681ef2021-04-29 08:15:13 +0000305}
306
Liz Kammer8337ea42021-09-10 10:06:32 -0400307cc_library_static {
308 name: "static_dep_for_shared",
309 bazel_module: { bp2build_available: false },
310}
Chris Parsons08648312021-05-06 16:23:19 -0400311
Liz Kammer8337ea42021-09-10 10:06:32 -0400312cc_library_static {
313 name: "static_dep_for_static",
314 bazel_module: { bp2build_available: false },
315}
Chris Parsons08648312021-05-06 16:23:19 -0400316
Liz Kammer8337ea42021-09-10 10:06:32 -0400317cc_library_static {
318 name: "static_dep_for_both",
319 bazel_module: { bp2build_available: false },
320}
Chris Parsons08648312021-05-06 16:23:19 -0400321
Liz Kammer8337ea42021-09-10 10:06:32 -0400322cc_library_static {
323 name: "whole_static_lib_for_shared",
324 bazel_module: { bp2build_available: false },
325}
Chris Parsons08648312021-05-06 16:23:19 -0400326
Liz Kammer8337ea42021-09-10 10:06:32 -0400327cc_library_static {
328 name: "whole_static_lib_for_static",
329 bazel_module: { bp2build_available: false },
330}
Chris Parsons08648312021-05-06 16:23:19 -0400331
Liz Kammer8337ea42021-09-10 10:06:32 -0400332cc_library_static {
333 name: "whole_static_lib_for_both",
334 bazel_module: { bp2build_available: false },
335}
Chris Parsons08648312021-05-06 16:23:19 -0400336
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400337cc_library_static {
338 name: "whole_and_static_lib_for_both",
339 bazel_module: { bp2build_available: false },
340}
341
Liz Kammer8337ea42021-09-10 10:06:32 -0400342cc_library {
343 name: "shared_dep_for_shared",
344 bazel_module: { bp2build_available: false },
345}
Chris Parsons08648312021-05-06 16:23:19 -0400346
Liz Kammer8337ea42021-09-10 10:06:32 -0400347cc_library {
348 name: "shared_dep_for_static",
349 bazel_module: { bp2build_available: false },
350}
Chris Parsons08648312021-05-06 16:23:19 -0400351
Liz Kammer8337ea42021-09-10 10:06:32 -0400352cc_library {
353 name: "shared_dep_for_both",
354 bazel_module: { bp2build_available: false },
355}
Jingwen Chen53681ef2021-04-29 08:15:13 +0000356`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000357 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000358 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500359 "copts": `[
360 "bothflag",
361 "staticflag",
362 ]`,
363 "implementation_deps": `[
364 ":static_dep_for_both",
365 ":static_dep_for_static",
366 ]`,
367 "implementation_dynamic_deps": `[
368 ":shared_dep_for_both",
369 ":shared_dep_for_static",
370 ]`,
371 "srcs": `[
372 "both.cpp",
373 "staticonly.cpp",
374 ]`,
375 "whole_archive_deps": `[
376 ":whole_static_lib_for_both",
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400377 ":whole_and_static_lib_for_both",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500378 ":whole_static_lib_for_static",
379 ]`}),
Alixe06d75b2022-08-31 18:28:19 +0000380 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500381 "copts": `[
382 "bothflag",
383 "sharedflag",
384 ]`,
385 "implementation_deps": `[
386 ":static_dep_for_both",
387 ":static_dep_for_shared",
388 ]`,
389 "implementation_dynamic_deps": `[
390 ":shared_dep_for_both",
391 ":shared_dep_for_shared",
392 ]`,
393 "srcs": `[
394 "both.cpp",
395 "sharedonly.cpp",
396 ]`,
397 "whole_archive_deps": `[
398 ":whole_static_lib_for_both",
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400399 ":whole_and_static_lib_for_both",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500400 ":whole_static_lib_for_shared",
401 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500402 }),
403 },
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200404 })
405}
406
Liz Kammer7a210ac2021-09-22 15:52:58 -0400407func TestCcLibraryDeps(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000408 runCcLibraryTestCase(t, Bp2buildTestCase{
409 Description: "cc_library shared/static props",
410 ModuleTypeUnderTest: "cc_library",
411 ModuleTypeUnderTestFactory: cc.LibraryFactory,
412 Filesystem: map[string]string{
Liz Kammer7a210ac2021-09-22 15:52:58 -0400413 "both.cpp": "",
414 "sharedonly.cpp": "",
415 "staticonly.cpp": "",
416 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000417 Blueprint: soongCcLibraryPreamble + `
Liz Kammer7a210ac2021-09-22 15:52:58 -0400418cc_library {
419 name: "a",
420 srcs: ["both.cpp"],
421 cflags: ["bothflag"],
422 shared_libs: ["implementation_shared_dep_for_both", "shared_dep_for_both"],
423 export_shared_lib_headers: ["shared_dep_for_both"],
424 static_libs: ["implementation_static_dep_for_both", "static_dep_for_both"],
425 export_static_lib_headers: ["static_dep_for_both", "whole_static_dep_for_both"],
426 whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_both", "whole_static_dep_for_both"],
427 static: {
428 srcs: ["staticonly.cpp"],
429 cflags: ["staticflag"],
430 shared_libs: ["implementation_shared_dep_for_static", "shared_dep_for_static"],
431 export_shared_lib_headers: ["shared_dep_for_static"],
432 static_libs: ["implementation_static_dep_for_static", "static_dep_for_static"],
433 export_static_lib_headers: ["static_dep_for_static", "whole_static_dep_for_static"],
434 whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_static", "whole_static_dep_for_static"],
435 },
436 shared: {
437 srcs: ["sharedonly.cpp"],
438 cflags: ["sharedflag"],
439 shared_libs: ["implementation_shared_dep_for_shared", "shared_dep_for_shared"],
440 export_shared_lib_headers: ["shared_dep_for_shared"],
441 static_libs: ["implementation_static_dep_for_shared", "static_dep_for_shared"],
442 export_static_lib_headers: ["static_dep_for_shared", "whole_static_dep_for_shared"],
443 whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_shared", "whole_static_dep_for_shared"],
444 },
445 include_build_directory: false,
446}
447` + simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_shared") +
448 simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_shared") +
449 simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_static") +
450 simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_static") +
451 simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_both") +
452 simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_both") +
453 simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_shared") +
454 simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_shared") +
455 simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_static") +
456 simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_static") +
457 simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_both") +
458 simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_both") +
459 simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_shared") +
460 simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_shared") +
461 simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_static") +
462 simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_static") +
463 simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_both") +
464 simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_both"),
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000465 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000466 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500467 "copts": `[
468 "bothflag",
469 "staticflag",
470 ]`,
471 "deps": `[
472 ":static_dep_for_both",
473 ":static_dep_for_static",
474 ]`,
475 "dynamic_deps": `[
476 ":shared_dep_for_both",
477 ":shared_dep_for_static",
478 ]`,
479 "implementation_deps": `[
480 ":implementation_static_dep_for_both",
481 ":implementation_static_dep_for_static",
482 ]`,
483 "implementation_dynamic_deps": `[
484 ":implementation_shared_dep_for_both",
485 ":implementation_shared_dep_for_static",
486 ]`,
487 "srcs": `[
488 "both.cpp",
489 "staticonly.cpp",
490 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500491 "whole_archive_deps": `[
Liz Kammer7a210ac2021-09-22 15:52:58 -0400492 ":not_explicitly_exported_whole_static_dep_for_both",
493 ":whole_static_dep_for_both",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500494 ":not_explicitly_exported_whole_static_dep_for_static",
495 ":whole_static_dep_for_static",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500496 ]`,
497 }),
Alixe06d75b2022-08-31 18:28:19 +0000498 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500499 "copts": `[
500 "bothflag",
501 "sharedflag",
502 ]`,
503 "deps": `[
504 ":static_dep_for_both",
505 ":static_dep_for_shared",
506 ]`,
507 "dynamic_deps": `[
508 ":shared_dep_for_both",
509 ":shared_dep_for_shared",
510 ]`,
511 "implementation_deps": `[
512 ":implementation_static_dep_for_both",
513 ":implementation_static_dep_for_shared",
514 ]`,
515 "implementation_dynamic_deps": `[
516 ":implementation_shared_dep_for_both",
517 ":implementation_shared_dep_for_shared",
518 ]`,
519 "srcs": `[
520 "both.cpp",
521 "sharedonly.cpp",
522 ]`,
523 "whole_archive_deps": `[
524 ":not_explicitly_exported_whole_static_dep_for_both",
525 ":whole_static_dep_for_both",
526 ":not_explicitly_exported_whole_static_dep_for_shared",
527 ":whole_static_dep_for_shared",
528 ]`,
529 })},
530 },
531 )
Liz Kammer7a210ac2021-09-22 15:52:58 -0400532}
533
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400534func TestCcLibraryWholeStaticLibsAlwaysLink(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000535 runCcLibraryTestCase(t, Bp2buildTestCase{
536 ModuleTypeUnderTest: "cc_library",
537 ModuleTypeUnderTestFactory: cc.LibraryFactory,
538 Dir: "foo/bar",
539 Filesystem: map[string]string{
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400540 "foo/bar/Android.bp": `
541cc_library {
542 name: "a",
543 whole_static_libs: ["whole_static_lib_for_both"],
544 static: {
545 whole_static_libs: ["whole_static_lib_for_static"],
546 },
547 shared: {
548 whole_static_libs: ["whole_static_lib_for_shared"],
549 },
550 bazel_module: { bp2build_available: true },
Liz Kammer8337ea42021-09-10 10:06:32 -0400551 include_build_directory: false,
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400552}
553
554cc_prebuilt_library_static { name: "whole_static_lib_for_shared" }
555
556cc_prebuilt_library_static { name: "whole_static_lib_for_static" }
557
558cc_prebuilt_library_static { name: "whole_static_lib_for_both" }
559`,
560 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000561 Blueprint: soongCcLibraryPreamble,
562 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000563 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500564 "whole_archive_deps": `[
565 ":whole_static_lib_for_both_alwayslink",
566 ":whole_static_lib_for_static_alwayslink",
567 ]`,
568 }),
Alixe06d75b2022-08-31 18:28:19 +0000569 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500570 "whole_archive_deps": `[
571 ":whole_static_lib_for_both_alwayslink",
572 ":whole_static_lib_for_shared_alwayslink",
573 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500574 }),
575 },
Chris Parsons77acf2e2021-12-03 17:27:16 -0500576 },
577 )
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400578}
579
Jingwen Chenbcf53042021-05-26 04:42:42 +0000580func TestCcLibrarySharedStaticPropsInArch(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000581 runCcLibraryTestCase(t, Bp2buildTestCase{
582 Description: "cc_library shared/static props in arch",
583 ModuleTypeUnderTest: "cc_library",
584 ModuleTypeUnderTestFactory: cc.LibraryFactory,
585 Dir: "foo/bar",
586 Filesystem: map[string]string{
Jingwen Chenbcf53042021-05-26 04:42:42 +0000587 "foo/bar/arm.cpp": "",
588 "foo/bar/x86.cpp": "",
589 "foo/bar/sharedonly.cpp": "",
590 "foo/bar/staticonly.cpp": "",
591 "foo/bar/Android.bp": `
592cc_library {
593 name: "a",
594 arch: {
595 arm: {
596 shared: {
597 srcs: ["arm_shared.cpp"],
598 cflags: ["-DARM_SHARED"],
599 static_libs: ["arm_static_dep_for_shared"],
600 whole_static_libs: ["arm_whole_static_dep_for_shared"],
601 shared_libs: ["arm_shared_dep_for_shared"],
602 },
603 },
604 x86: {
605 static: {
606 srcs: ["x86_static.cpp"],
607 cflags: ["-DX86_STATIC"],
608 static_libs: ["x86_dep_for_static"],
609 },
610 },
611 },
612 target: {
613 android: {
614 shared: {
615 srcs: ["android_shared.cpp"],
616 cflags: ["-DANDROID_SHARED"],
617 static_libs: ["android_dep_for_shared"],
618 },
619 },
620 android_arm: {
621 shared: {
622 cflags: ["-DANDROID_ARM_SHARED"],
623 },
624 },
625 },
626 srcs: ["both.cpp"],
627 cflags: ["bothflag"],
628 static_libs: ["static_dep_for_both"],
629 static: {
630 srcs: ["staticonly.cpp"],
631 cflags: ["staticflag"],
632 static_libs: ["static_dep_for_static"],
633 },
634 shared: {
635 srcs: ["sharedonly.cpp"],
636 cflags: ["sharedflag"],
637 static_libs: ["static_dep_for_shared"],
638 },
639 bazel_module: { bp2build_available: true },
640}
641
642cc_library_static { name: "static_dep_for_shared" }
643cc_library_static { name: "static_dep_for_static" }
644cc_library_static { name: "static_dep_for_both" }
645
646cc_library_static { name: "arm_static_dep_for_shared" }
647cc_library_static { name: "arm_whole_static_dep_for_shared" }
648cc_library_static { name: "arm_shared_dep_for_shared" }
649
650cc_library_static { name: "x86_dep_for_static" }
651
652cc_library_static { name: "android_dep_for_shared" }
653`,
654 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000655 Blueprint: soongCcLibraryPreamble,
656 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000657 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500658 "copts": `[
659 "bothflag",
660 "staticflag",
661 ] + select({
662 "//build/bazel/platforms/arch:x86": ["-DX86_STATIC"],
663 "//conditions:default": [],
664 })`,
665 "implementation_deps": `[
666 ":static_dep_for_both",
667 ":static_dep_for_static",
668 ] + select({
669 "//build/bazel/platforms/arch:x86": [":x86_dep_for_static"],
670 "//conditions:default": [],
671 })`,
672 "local_includes": `["."]`,
673 "srcs": `[
674 "both.cpp",
675 "staticonly.cpp",
676 ] + select({
677 "//build/bazel/platforms/arch:x86": ["x86_static.cpp"],
678 "//conditions:default": [],
679 })`,
680 }),
Alixe06d75b2022-08-31 18:28:19 +0000681 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500682 "copts": `[
683 "bothflag",
684 "sharedflag",
685 ] + select({
686 "//build/bazel/platforms/arch:arm": ["-DARM_SHARED"],
687 "//conditions:default": [],
688 }) + select({
689 "//build/bazel/platforms/os:android": ["-DANDROID_SHARED"],
690 "//conditions:default": [],
691 }) + select({
692 "//build/bazel/platforms/os_arch:android_arm": ["-DANDROID_ARM_SHARED"],
693 "//conditions:default": [],
694 })`,
695 "implementation_deps": `[
696 ":static_dep_for_both",
697 ":static_dep_for_shared",
698 ] + select({
699 "//build/bazel/platforms/arch:arm": [":arm_static_dep_for_shared"],
700 "//conditions:default": [],
701 }) + select({
702 "//build/bazel/platforms/os:android": [":android_dep_for_shared"],
703 "//conditions:default": [],
704 })`,
705 "implementation_dynamic_deps": `select({
706 "//build/bazel/platforms/arch:arm": [":arm_shared_dep_for_shared"],
707 "//conditions:default": [],
708 })`,
709 "local_includes": `["."]`,
710 "srcs": `[
711 "both.cpp",
712 "sharedonly.cpp",
713 ] + select({
714 "//build/bazel/platforms/arch:arm": ["arm_shared.cpp"],
715 "//conditions:default": [],
716 }) + select({
717 "//build/bazel/platforms/os:android": ["android_shared.cpp"],
718 "//conditions:default": [],
719 })`,
720 "whole_archive_deps": `select({
721 "//build/bazel/platforms/arch:arm": [":arm_whole_static_dep_for_shared"],
722 "//conditions:default": [],
723 })`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500724 }),
725 },
Chris Parsons77acf2e2021-12-03 17:27:16 -0500726 },
727 )
Jingwen Chenbcf53042021-05-26 04:42:42 +0000728}
729
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000730func TestCcLibrarySharedStaticPropsWithMixedSources(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000731 runCcLibraryTestCase(t, Bp2buildTestCase{
732 Description: "cc_library shared/static props with c/cpp/s mixed sources",
733 ModuleTypeUnderTest: "cc_library",
734 ModuleTypeUnderTestFactory: cc.LibraryFactory,
735 Dir: "foo/bar",
736 Filesystem: map[string]string{
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000737 "foo/bar/both_source.cpp": "",
738 "foo/bar/both_source.cc": "",
739 "foo/bar/both_source.c": "",
740 "foo/bar/both_source.s": "",
741 "foo/bar/both_source.S": "",
742 "foo/bar/shared_source.cpp": "",
743 "foo/bar/shared_source.cc": "",
744 "foo/bar/shared_source.c": "",
745 "foo/bar/shared_source.s": "",
746 "foo/bar/shared_source.S": "",
747 "foo/bar/static_source.cpp": "",
748 "foo/bar/static_source.cc": "",
749 "foo/bar/static_source.c": "",
750 "foo/bar/static_source.s": "",
751 "foo/bar/static_source.S": "",
752 "foo/bar/Android.bp": `
753cc_library {
754 name: "a",
755 srcs: [
Liz Kammerd366c902021-06-03 13:43:01 -0400756 "both_source.cpp",
757 "both_source.cc",
758 "both_source.c",
759 "both_source.s",
760 "both_source.S",
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400761 ":both_filegroup",
Liz Kammerd366c902021-06-03 13:43:01 -0400762 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000763 static: {
Liz Kammer8337ea42021-09-10 10:06:32 -0400764 srcs: [
765 "static_source.cpp",
766 "static_source.cc",
767 "static_source.c",
768 "static_source.s",
769 "static_source.S",
770 ":static_filegroup",
771 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000772 },
773 shared: {
Liz Kammer8337ea42021-09-10 10:06:32 -0400774 srcs: [
775 "shared_source.cpp",
776 "shared_source.cc",
777 "shared_source.c",
778 "shared_source.s",
779 "shared_source.S",
780 ":shared_filegroup",
781 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000782 },
783 bazel_module: { bp2build_available: true },
784}
785
786filegroup {
787 name: "both_filegroup",
788 srcs: [
789 // Not relevant, handled by filegroup macro
Liz Kammerd366c902021-06-03 13:43:01 -0400790 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000791}
792
793filegroup {
794 name: "shared_filegroup",
795 srcs: [
796 // Not relevant, handled by filegroup macro
Liz Kammerd366c902021-06-03 13:43:01 -0400797 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000798}
799
800filegroup {
801 name: "static_filegroup",
802 srcs: [
803 // Not relevant, handled by filegroup macro
Liz Kammerd366c902021-06-03 13:43:01 -0400804 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000805}
806`,
807 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000808 Blueprint: soongCcLibraryPreamble,
809 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000810 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500811 "local_includes": `["."]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500812 "srcs": `[
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000813 "both_source.cpp",
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400814 "both_source.cc",
815 ":both_filegroup_cpp_srcs",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500816 "static_source.cpp",
817 "static_source.cc",
818 ":static_filegroup_cpp_srcs",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500819 ]`,
820 "srcs_as": `[
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000821 "both_source.s",
822 "both_source.S",
823 ":both_filegroup_as_srcs",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500824 "static_source.s",
825 "static_source.S",
826 ":static_filegroup_as_srcs",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500827 ]`,
828 "srcs_c": `[
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000829 "both_source.c",
830 ":both_filegroup_c_srcs",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500831 "static_source.c",
832 ":static_filegroup_c_srcs",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500833 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500834 }),
Alixe06d75b2022-08-31 18:28:19 +0000835 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500836 "local_includes": `["."]`,
837 "srcs": `[
838 "both_source.cpp",
839 "both_source.cc",
840 ":both_filegroup_cpp_srcs",
841 "shared_source.cpp",
842 "shared_source.cc",
843 ":shared_filegroup_cpp_srcs",
844 ]`,
845 "srcs_as": `[
846 "both_source.s",
847 "both_source.S",
848 ":both_filegroup_as_srcs",
849 "shared_source.s",
850 "shared_source.S",
851 ":shared_filegroup_as_srcs",
852 ]`,
853 "srcs_c": `[
854 "both_source.c",
855 ":both_filegroup_c_srcs",
856 "shared_source.c",
857 ":shared_filegroup_c_srcs",
858 ]`,
859 })}})
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000860}
861
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200862func TestCcLibraryNonConfiguredVersionScript(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000863 runCcLibraryTestCase(t, Bp2buildTestCase{
864 Description: "cc_library non-configured version script",
865 ModuleTypeUnderTest: "cc_library",
866 ModuleTypeUnderTestFactory: cc.LibraryFactory,
867 Dir: "foo/bar",
868 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200869 "foo/bar/Android.bp": `
Lukacs T. Berki1353e592021-04-30 15:35:09 +0200870cc_library {
871 name: "a",
872 srcs: ["a.cpp"],
873 version_script: "v.map",
874 bazel_module: { bp2build_available: true },
Liz Kammer8337ea42021-09-10 10:06:32 -0400875 include_build_directory: false,
Lukacs T. Berki1353e592021-04-30 15:35:09 +0200876}
877`,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200878 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000879 Blueprint: soongCcLibraryPreamble,
880 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500881 "additional_linker_inputs": `["v.map"]`,
882 "linkopts": `["-Wl,--version-script,$(location v.map)"]`,
883 "srcs": `["a.cpp"]`,
884 }),
885 },
886 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200887}
888
889func TestCcLibraryConfiguredVersionScript(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000890 runCcLibraryTestCase(t, Bp2buildTestCase{
891 Description: "cc_library configured version script",
892 ModuleTypeUnderTest: "cc_library",
893 ModuleTypeUnderTestFactory: cc.LibraryFactory,
894 Dir: "foo/bar",
895 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200896 "foo/bar/Android.bp": `
Liz Kammer8337ea42021-09-10 10:06:32 -0400897cc_library {
898 name: "a",
899 srcs: ["a.cpp"],
900 arch: {
901 arm: {
902 version_script: "arm.map",
903 },
904 arm64: {
905 version_script: "arm64.map",
906 },
907 },
Lukacs T. Berki56bb0832021-05-12 12:36:45 +0200908
Liz Kammer8337ea42021-09-10 10:06:32 -0400909 bazel_module: { bp2build_available: true },
910 include_build_directory: false,
911}
Liz Kammerd366c902021-06-03 13:43:01 -0400912 `,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200913 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000914 Blueprint: soongCcLibraryPreamble,
915 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500916 "additional_linker_inputs": `select({
Liz Kammerd2871182021-10-04 13:54:37 -0400917 "//build/bazel/platforms/arch:arm": ["arm.map"],
918 "//build/bazel/platforms/arch:arm64": ["arm64.map"],
919 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500920 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500921 "linkopts": `select({
Liz Kammerd2871182021-10-04 13:54:37 -0400922 "//build/bazel/platforms/arch:arm": ["-Wl,--version-script,$(location arm.map)"],
923 "//build/bazel/platforms/arch:arm64": ["-Wl,--version-script,$(location arm64.map)"],
924 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500925 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500926 "srcs": `["a.cpp"]`,
927 }),
928 },
929 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200930}
931
932func TestCcLibrarySharedLibs(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000933 runCcLibraryTestCase(t, Bp2buildTestCase{
934 Description: "cc_library shared_libs",
935 ModuleTypeUnderTest: "cc_library",
936 ModuleTypeUnderTestFactory: cc.LibraryFactory,
937 Blueprint: soongCcLibraryPreamble + `
Rupert Shuttleworthc50fa8d2021-05-06 02:40:33 -0400938cc_library {
939 name: "mylib",
Liz Kammer8337ea42021-09-10 10:06:32 -0400940 bazel_module: { bp2build_available: false },
Rupert Shuttleworthc50fa8d2021-05-06 02:40:33 -0400941}
942
943cc_library {
944 name: "a",
945 shared_libs: ["mylib",],
Liz Kammer8337ea42021-09-10 10:06:32 -0400946 include_build_directory: false,
Rupert Shuttleworthc50fa8d2021-05-06 02:40:33 -0400947}
948`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000949 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500950 "implementation_dynamic_deps": `[":mylib"]`,
951 }),
952 },
953 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200954}
955
Liz Kammer0eae52e2021-10-06 10:32:26 -0400956func TestCcLibraryFeatures(t *testing.T) {
Chris Parsons77acf2e2021-12-03 17:27:16 -0500957 expected_targets := []string{}
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000958 expected_targets = append(expected_targets, makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500959 "features": `[
960 "disable_pack_relocations",
961 "-no_undefined_symbols",
Yu Liu8d82ac52022-05-17 15:13:28 -0700962 "-coverage",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500963 ]`,
964 "srcs": `["a.cpp"]`,
965 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000966 expected_targets = append(expected_targets, makeCcLibraryTargets("b", AttrNameToString{
Yu Liu8d82ac52022-05-17 15:13:28 -0700967 "features": `["-coverage"] + select({
Chris Parsons77acf2e2021-12-03 17:27:16 -0500968 "//build/bazel/platforms/arch:x86_64": [
969 "disable_pack_relocations",
970 "-no_undefined_symbols",
971 ],
972 "//conditions:default": [],
973 })`,
974 "srcs": `["b.cpp"]`,
975 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000976 expected_targets = append(expected_targets, makeCcLibraryTargets("c", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500977 "features": `select({
978 "//build/bazel/platforms/os:darwin": [
979 "disable_pack_relocations",
980 "-no_undefined_symbols",
981 ],
982 "//conditions:default": [],
983 })`,
984 "srcs": `["c.cpp"]`,
985 })...)
986
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000987 runCcLibraryTestCase(t, Bp2buildTestCase{
988 Description: "cc_library pack_relocations test",
989 ModuleTypeUnderTest: "cc_library",
990 ModuleTypeUnderTestFactory: cc.LibraryFactory,
991 Blueprint: soongCcLibraryPreamble + `
Rupert Shuttleworth143be942021-05-09 23:55:51 -0400992cc_library {
993 name: "a",
994 srcs: ["a.cpp"],
995 pack_relocations: false,
Liz Kammer0eae52e2021-10-06 10:32:26 -0400996 allow_undefined_symbols: true,
Liz Kammer8337ea42021-09-10 10:06:32 -0400997 include_build_directory: false,
Yu Liu8d82ac52022-05-17 15:13:28 -0700998 native_coverage: false,
Rupert Shuttleworth143be942021-05-09 23:55:51 -0400999}
1000
1001cc_library {
1002 name: "b",
1003 srcs: ["b.cpp"],
1004 arch: {
1005 x86_64: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001006 pack_relocations: false,
Liz Kammer0eae52e2021-10-06 10:32:26 -04001007 allow_undefined_symbols: true,
Liz Kammer8337ea42021-09-10 10:06:32 -04001008 },
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001009 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001010 include_build_directory: false,
Yu Liu8d82ac52022-05-17 15:13:28 -07001011 native_coverage: false,
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001012}
1013
1014cc_library {
1015 name: "c",
1016 srcs: ["c.cpp"],
1017 target: {
1018 darwin: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001019 pack_relocations: false,
Liz Kammer0eae52e2021-10-06 10:32:26 -04001020 allow_undefined_symbols: true,
Liz Kammer8337ea42021-09-10 10:06:32 -04001021 },
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001022 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001023 include_build_directory: false,
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001024}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001025 ExpectedBazelTargets: expected_targets,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +02001026 })
1027}
1028
1029func TestCcLibrarySpacesInCopts(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001030 runCcLibraryTestCase(t, Bp2buildTestCase{
1031 Description: "cc_library spaces in copts",
1032 ModuleTypeUnderTest: "cc_library",
1033 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1034 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen3950cd62021-05-12 04:33:00 +00001035cc_library {
1036 name: "a",
1037 cflags: ["-include header.h",],
Liz Kammer8337ea42021-09-10 10:06:32 -04001038 include_build_directory: false,
Jingwen Chen3950cd62021-05-12 04:33:00 +00001039}
1040`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001041 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001042 "copts": `[
Jingwen Chen3950cd62021-05-12 04:33:00 +00001043 "-include",
1044 "header.h",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001045 ]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001046 }),
1047 },
1048 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +02001049}
1050
1051func TestCcLibraryCppFlagsGoesIntoCopts(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001052 runCcLibraryTestCase(t, Bp2buildTestCase{
1053 Description: "cc_library cppflags usage",
1054 ModuleTypeUnderTest: "cc_library",
1055 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1056 Blueprint: soongCcLibraryPreamble + `cc_library {
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001057 name: "a",
1058 srcs: ["a.cpp"],
Liz Kammer8337ea42021-09-10 10:06:32 -04001059 cflags: ["-Wall"],
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001060 cppflags: [
1061 "-fsigned-char",
1062 "-pedantic",
Liz Kammer8337ea42021-09-10 10:06:32 -04001063 ],
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001064 arch: {
1065 arm64: {
1066 cppflags: ["-DARM64=1"],
Liz Kammer8337ea42021-09-10 10:06:32 -04001067 },
Liz Kammerd366c902021-06-03 13:43:01 -04001068 },
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001069 target: {
1070 android: {
1071 cppflags: ["-DANDROID=1"],
Liz Kammer8337ea42021-09-10 10:06:32 -04001072 },
Liz Kammerd366c902021-06-03 13:43:01 -04001073 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001074 include_build_directory: false,
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001075}
1076`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001077 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001078 "copts": `["-Wall"]`,
1079 "cppflags": `[
Chris Parsons990c4f42021-05-25 12:10:58 -04001080 "-fsigned-char",
1081 "-pedantic",
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001082 ] + select({
1083 "//build/bazel/platforms/arch:arm64": ["-DARM64=1"],
1084 "//conditions:default": [],
1085 }) + select({
1086 "//build/bazel/platforms/os:android": ["-DANDROID=1"],
1087 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001088 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001089 "srcs": `["a.cpp"]`,
1090 }),
1091 },
1092 )
Jingwen Chen63930982021-03-24 10:04:33 -04001093}
Rupert Shuttleworth22cd2eb2021-05-27 02:15:54 -04001094
Liz Kammer47535c52021-06-02 16:02:22 -04001095func TestCcLibraryExcludeLibs(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001096 runCcLibraryTestCase(t, Bp2buildTestCase{
1097 ModuleTypeUnderTest: "cc_library",
1098 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1099 Filesystem: map[string]string{},
1100 Blueprint: soongCcLibraryStaticPreamble + `
Liz Kammer47535c52021-06-02 16:02:22 -04001101cc_library {
1102 name: "foo_static",
1103 srcs: ["common.c"],
1104 whole_static_libs: [
1105 "arm_whole_static_lib_excludes",
1106 "malloc_not_svelte_whole_static_lib_excludes"
1107 ],
1108 static_libs: [
1109 "arm_static_lib_excludes",
1110 "malloc_not_svelte_static_lib_excludes"
1111 ],
1112 shared_libs: [
1113 "arm_shared_lib_excludes",
1114 ],
1115 arch: {
1116 arm: {
1117 exclude_shared_libs: [
1118 "arm_shared_lib_excludes",
1119 ],
1120 exclude_static_libs: [
1121 "arm_static_lib_excludes",
1122 "arm_whole_static_lib_excludes",
1123 ],
1124 },
1125 },
1126 product_variables: {
1127 malloc_not_svelte: {
1128 shared_libs: ["malloc_not_svelte_shared_lib"],
1129 whole_static_libs: ["malloc_not_svelte_whole_static_lib"],
1130 exclude_static_libs: [
1131 "malloc_not_svelte_static_lib_excludes",
1132 "malloc_not_svelte_whole_static_lib_excludes",
1133 ],
1134 },
1135 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001136 include_build_directory: false,
Liz Kammer47535c52021-06-02 16:02:22 -04001137}
1138
1139cc_library {
1140 name: "arm_whole_static_lib_excludes",
1141 bazel_module: { bp2build_available: false },
1142}
1143
1144cc_library {
1145 name: "malloc_not_svelte_whole_static_lib",
1146 bazel_module: { bp2build_available: false },
1147}
1148
1149cc_library {
1150 name: "malloc_not_svelte_whole_static_lib_excludes",
1151 bazel_module: { bp2build_available: false },
1152}
1153
1154cc_library {
1155 name: "arm_static_lib_excludes",
1156 bazel_module: { bp2build_available: false },
1157}
1158
1159cc_library {
1160 name: "malloc_not_svelte_static_lib_excludes",
1161 bazel_module: { bp2build_available: false },
1162}
1163
1164cc_library {
1165 name: "arm_shared_lib_excludes",
1166 bazel_module: { bp2build_available: false },
1167}
1168
1169cc_library {
1170 name: "malloc_not_svelte_shared_lib",
1171 bazel_module: { bp2build_available: false },
1172}
1173`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001174 ExpectedBazelTargets: makeCcLibraryTargets("foo_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001175 "implementation_deps": `select({
Liz Kammer47535c52021-06-02 16:02:22 -04001176 "//build/bazel/platforms/arch:arm": [],
Chris Parsons953b3562021-09-20 15:14:39 -04001177 "//conditions:default": [":arm_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer47535c52021-06-02 16:02:22 -04001178 }) + select({
1179 "//build/bazel/product_variables:malloc_not_svelte": [],
Chris Parsons953b3562021-09-20 15:14:39 -04001180 "//conditions:default": [":malloc_not_svelte_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001181 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001182 "implementation_dynamic_deps": `select({
Liz Kammer7a210ac2021-09-22 15:52:58 -04001183 "//build/bazel/platforms/arch:arm": [],
1184 "//conditions:default": [":arm_shared_lib_excludes"],
1185 }) + select({
1186 "//build/bazel/product_variables:malloc_not_svelte": [":malloc_not_svelte_shared_lib"],
1187 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001188 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001189 "srcs_c": `["common.c"]`,
1190 "whole_archive_deps": `select({
Liz Kammer47535c52021-06-02 16:02:22 -04001191 "//build/bazel/platforms/arch:arm": [],
Chris Parsons953b3562021-09-20 15:14:39 -04001192 "//conditions:default": [":arm_whole_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer47535c52021-06-02 16:02:22 -04001193 }) + select({
Chris Parsons953b3562021-09-20 15:14:39 -04001194 "//build/bazel/product_variables:malloc_not_svelte": [":malloc_not_svelte_whole_static_lib_bp2build_cc_library_static"],
1195 "//conditions:default": [":malloc_not_svelte_whole_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001196 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001197 }),
1198 },
1199 )
Liz Kammer47535c52021-06-02 16:02:22 -04001200}
Liz Kammerd366c902021-06-03 13:43:01 -04001201
Zi Wang0a8a1292022-08-30 06:27:01 +00001202func TestCcLibraryProductVariablesHeaderLibs(t *testing.T) {
1203 runCcLibraryTestCase(t, Bp2buildTestCase{
1204 ModuleTypeUnderTest: "cc_library",
1205 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1206 Filesystem: map[string]string{},
1207 Blueprint: soongCcLibraryStaticPreamble + `
1208cc_library {
1209 name: "foo_static",
1210 srcs: ["common.c"],
1211 product_variables: {
1212 malloc_not_svelte: {
1213 header_libs: ["malloc_not_svelte_header_lib"],
1214 },
1215 },
1216 include_build_directory: false,
1217}
1218
1219cc_library {
1220 name: "malloc_not_svelte_header_lib",
1221 bazel_module: { bp2build_available: false },
1222}
1223`,
1224 ExpectedBazelTargets: makeCcLibraryTargets("foo_static", AttrNameToString{
1225 "implementation_deps": `select({
1226 "//build/bazel/product_variables:malloc_not_svelte": [":malloc_not_svelte_header_lib"],
1227 "//conditions:default": [],
1228 })`,
1229 "srcs_c": `["common.c"]`,
1230 "target_compatible_with": `["//build/bazel/platforms/os:android"]`,
1231 }),
1232 },
1233 )
1234}
1235
Liz Kammerd366c902021-06-03 13:43:01 -04001236func TestCCLibraryNoCrtTrue(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001237 runCcLibraryTestCase(t, Bp2buildTestCase{
1238 Description: "cc_library - nocrt: true emits attribute",
1239 ModuleTypeUnderTest: "cc_library",
1240 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1241 Filesystem: map[string]string{
Jingwen Chen6ada5892021-09-17 11:38:09 +00001242 "impl.cpp": "",
1243 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001244 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen6ada5892021-09-17 11:38:09 +00001245cc_library {
1246 name: "foo-lib",
1247 srcs: ["impl.cpp"],
1248 nocrt: true,
1249 include_build_directory: false,
1250}
1251`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001252 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001253 "link_crt": `False`,
1254 "srcs": `["impl.cpp"]`,
1255 }),
1256 },
1257 )
Jingwen Chen6ada5892021-09-17 11:38:09 +00001258}
1259
1260func TestCCLibraryNoCrtFalse(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001261 runCcLibraryTestCase(t, Bp2buildTestCase{
1262 Description: "cc_library - nocrt: false - does not emit attribute",
1263 ModuleTypeUnderTest: "cc_library",
1264 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1265 Filesystem: map[string]string{
Jingwen Chen6ada5892021-09-17 11:38:09 +00001266 "impl.cpp": "",
1267 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001268 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen6ada5892021-09-17 11:38:09 +00001269cc_library {
1270 name: "foo-lib",
1271 srcs: ["impl.cpp"],
1272 nocrt: false,
1273 include_build_directory: false,
1274}
1275`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001276 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001277 "srcs": `["impl.cpp"]`,
1278 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001279 })
Jingwen Chen6ada5892021-09-17 11:38:09 +00001280}
1281
1282func TestCCLibraryNoCrtArchVariant(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001283 runCcLibraryTestCase(t, Bp2buildTestCase{
1284 Description: "cc_library - nocrt in select",
1285 ModuleTypeUnderTest: "cc_library",
1286 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1287 Filesystem: map[string]string{
Jingwen Chen6ada5892021-09-17 11:38:09 +00001288 "impl.cpp": "",
1289 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001290 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen6ada5892021-09-17 11:38:09 +00001291cc_library {
1292 name: "foo-lib",
1293 srcs: ["impl.cpp"],
1294 arch: {
1295 arm: {
1296 nocrt: true,
1297 },
1298 x86: {
1299 nocrt: false,
1300 },
1301 },
1302 include_build_directory: false,
1303}
1304`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001305 ExpectedErr: fmt.Errorf("module \"foo-lib\": nocrt is not supported for arch variants"),
Jingwen Chen6ada5892021-09-17 11:38:09 +00001306 })
1307}
1308
1309func TestCCLibraryNoLibCrtTrue(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001310 runCcLibraryTestCase(t, Bp2buildTestCase{
1311 ModuleTypeUnderTest: "cc_library",
1312 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1313 Filesystem: map[string]string{
Liz Kammerd366c902021-06-03 13:43:01 -04001314 "impl.cpp": "",
1315 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001316 Blueprint: soongCcLibraryPreamble + `
Liz Kammerd366c902021-06-03 13:43:01 -04001317cc_library {
1318 name: "foo-lib",
1319 srcs: ["impl.cpp"],
1320 no_libcrt: true,
Liz Kammer8337ea42021-09-10 10:06:32 -04001321 include_build_directory: false,
Liz Kammerd366c902021-06-03 13:43:01 -04001322}
1323`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001324 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001325 "srcs": `["impl.cpp"]`,
1326 "use_libcrt": `False`,
1327 }),
1328 })
1329}
1330
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001331func makeCcLibraryTargets(name string, attrs AttrNameToString) []string {
Chris Parsons77acf2e2021-12-03 17:27:16 -05001332 STATIC_ONLY_ATTRS := map[string]bool{}
1333 SHARED_ONLY_ATTRS := map[string]bool{
1334 "link_crt": true,
1335 "additional_linker_inputs": true,
1336 "linkopts": true,
1337 "strip": true,
Yu Liu75be7b92022-02-01 09:54:09 -08001338 "inject_bssl_hash": true,
Wei Li81852ca2022-07-27 00:22:06 -07001339 "has_stubs": true,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001340 }
Wei Li81852ca2022-07-27 00:22:06 -07001341
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001342 sharedAttrs := AttrNameToString{}
1343 staticAttrs := AttrNameToString{}
Chris Parsons77acf2e2021-12-03 17:27:16 -05001344 for key, val := range attrs {
1345 if _, staticOnly := STATIC_ONLY_ATTRS[key]; !staticOnly {
1346 sharedAttrs[key] = val
1347 }
1348 if _, sharedOnly := SHARED_ONLY_ATTRS[key]; !sharedOnly {
1349 staticAttrs[key] = val
1350 }
1351 }
Alixe06d75b2022-08-31 18:28:19 +00001352 sharedTarget := MakeBazelTarget("cc_library_shared", name, sharedAttrs)
1353 staticTarget := MakeBazelTarget("cc_library_static", name+"_bp2build_cc_library_static", staticAttrs)
Chris Parsons77acf2e2021-12-03 17:27:16 -05001354
1355 return []string{staticTarget, sharedTarget}
Liz Kammerd366c902021-06-03 13:43:01 -04001356}
1357
Wei Li81852ca2022-07-27 00:22:06 -07001358func makeCcStubSuiteTargets(name string, attrs AttrNameToString) string {
1359 if _, hasStubs := attrs["stubs_symbol_file"]; !hasStubs {
1360 return ""
1361 }
1362 STUB_SUITE_ATTRS := map[string]string{
1363 "stubs_symbol_file": "symbol_file",
1364 "stubs_versions": "versions",
1365 "soname": "soname",
1366 "source_library": "source_library",
1367 }
1368
1369 stubSuiteAttrs := AttrNameToString{}
1370 for key, _ := range attrs {
1371 if _, stubSuiteAttr := STUB_SUITE_ATTRS[key]; stubSuiteAttr {
1372 stubSuiteAttrs[STUB_SUITE_ATTRS[key]] = attrs[key]
1373 }
1374 }
Alixe06d75b2022-08-31 18:28:19 +00001375 return MakeBazelTarget("cc_stub_suite", name+"_stub_libs", stubSuiteAttrs)
Wei Li81852ca2022-07-27 00:22:06 -07001376}
1377
Jingwen Chen6ada5892021-09-17 11:38:09 +00001378func TestCCLibraryNoLibCrtFalse(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001379 runCcLibraryTestCase(t, Bp2buildTestCase{
1380 ModuleTypeUnderTest: "cc_library",
1381 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1382 Filesystem: map[string]string{
Liz Kammerd366c902021-06-03 13:43:01 -04001383 "impl.cpp": "",
1384 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001385 Blueprint: soongCcLibraryPreamble + `
Liz Kammerd366c902021-06-03 13:43:01 -04001386cc_library {
1387 name: "foo-lib",
1388 srcs: ["impl.cpp"],
1389 no_libcrt: false,
Liz Kammer8337ea42021-09-10 10:06:32 -04001390 include_build_directory: false,
Liz Kammerd366c902021-06-03 13:43:01 -04001391}
1392`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001393 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001394 "srcs": `["impl.cpp"]`,
1395 "use_libcrt": `True`,
1396 }),
1397 })
Liz Kammerd366c902021-06-03 13:43:01 -04001398}
1399
Jingwen Chen6ada5892021-09-17 11:38:09 +00001400func TestCCLibraryNoLibCrtArchVariant(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001401 runCcLibraryTestCase(t, Bp2buildTestCase{
1402 ModuleTypeUnderTest: "cc_library",
1403 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1404 Filesystem: map[string]string{
Liz Kammerd366c902021-06-03 13:43:01 -04001405 "impl.cpp": "",
1406 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001407 Blueprint: soongCcLibraryPreamble + `
Liz Kammerd366c902021-06-03 13:43:01 -04001408cc_library {
1409 name: "foo-lib",
1410 srcs: ["impl.cpp"],
1411 arch: {
1412 arm: {
1413 no_libcrt: true,
1414 },
1415 x86: {
1416 no_libcrt: true,
1417 },
1418 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001419 include_build_directory: false,
Liz Kammerd366c902021-06-03 13:43:01 -04001420}
1421`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001422 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001423 "srcs": `["impl.cpp"]`,
1424 "use_libcrt": `select({
Liz Kammerd366c902021-06-03 13:43:01 -04001425 "//build/bazel/platforms/arch:arm": False,
1426 "//build/bazel/platforms/arch:x86": False,
1427 "//conditions:default": None,
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001428 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001429 }),
1430 })
Liz Kammerd366c902021-06-03 13:43:01 -04001431}
1432
Chris Parsons58852a02021-12-09 18:10:18 -05001433func TestCCLibraryNoLibCrtArchAndTargetVariant(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001434 runCcLibraryTestCase(t, Bp2buildTestCase{
1435 ModuleTypeUnderTest: "cc_library",
1436 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1437 Filesystem: map[string]string{
Chris Parsons58852a02021-12-09 18:10:18 -05001438 "impl.cpp": "",
1439 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001440 Blueprint: soongCcLibraryPreamble + `
Chris Parsons58852a02021-12-09 18:10:18 -05001441cc_library {
1442 name: "foo-lib",
1443 srcs: ["impl.cpp"],
1444 arch: {
1445 arm: {
1446 no_libcrt: true,
1447 },
1448 x86: {
1449 no_libcrt: true,
1450 },
1451 },
1452 target: {
1453 darwin: {
1454 no_libcrt: true,
1455 }
1456 },
1457 include_build_directory: false,
1458}
1459`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001460 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05001461 "srcs": `["impl.cpp"]`,
1462 "use_libcrt": `select({
1463 "//build/bazel/platforms/os_arch:android_arm": False,
1464 "//build/bazel/platforms/os_arch:android_x86": False,
1465 "//build/bazel/platforms/os_arch:darwin_arm64": False,
1466 "//build/bazel/platforms/os_arch:darwin_x86_64": False,
1467 "//build/bazel/platforms/os_arch:linux_glibc_x86": False,
1468 "//build/bazel/platforms/os_arch:linux_musl_x86": False,
1469 "//build/bazel/platforms/os_arch:windows_x86": False,
1470 "//conditions:default": None,
1471 })`,
1472 }),
1473 })
1474}
1475
1476func TestCCLibraryNoLibCrtArchAndTargetVariantConflict(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001477 runCcLibraryTestCase(t, Bp2buildTestCase{
1478 ModuleTypeUnderTest: "cc_library",
1479 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1480 Filesystem: map[string]string{
Chris Parsons58852a02021-12-09 18:10:18 -05001481 "impl.cpp": "",
1482 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001483 Blueprint: soongCcLibraryPreamble + `
Chris Parsons58852a02021-12-09 18:10:18 -05001484cc_library {
1485 name: "foo-lib",
1486 srcs: ["impl.cpp"],
1487 arch: {
1488 arm: {
1489 no_libcrt: true,
1490 },
1491 // This is expected to override the value for darwin_x86_64.
1492 x86_64: {
1493 no_libcrt: true,
1494 },
1495 },
1496 target: {
1497 darwin: {
1498 no_libcrt: false,
1499 }
1500 },
1501 include_build_directory: false,
1502}
1503`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001504 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05001505 "srcs": `["impl.cpp"]`,
1506 "use_libcrt": `select({
1507 "//build/bazel/platforms/os_arch:android_arm": False,
1508 "//build/bazel/platforms/os_arch:android_x86_64": False,
1509 "//build/bazel/platforms/os_arch:darwin_arm64": True,
1510 "//build/bazel/platforms/os_arch:darwin_x86_64": False,
1511 "//build/bazel/platforms/os_arch:linux_bionic_x86_64": False,
1512 "//build/bazel/platforms/os_arch:linux_glibc_x86_64": False,
1513 "//build/bazel/platforms/os_arch:linux_musl_x86_64": False,
1514 "//build/bazel/platforms/os_arch:windows_x86_64": False,
1515 "//conditions:default": None,
1516 })`,
1517 }),
1518 })
1519}
1520
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001521func TestCcLibraryStrip(t *testing.T) {
Chris Parsons77acf2e2021-12-03 17:27:16 -05001522 expectedTargets := []string{}
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001523 expectedTargets = append(expectedTargets, makeCcLibraryTargets("all", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001524 "strip": `{
1525 "all": True,
1526 }`,
1527 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001528 expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001529 "strip": `{
1530 "keep_symbols": True,
1531 }`,
1532 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001533 expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols_and_debug_frame", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001534 "strip": `{
1535 "keep_symbols_and_debug_frame": True,
1536 }`,
1537 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001538 expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols_list", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001539 "strip": `{
1540 "keep_symbols_list": ["symbol"],
1541 }`,
1542 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001543 expectedTargets = append(expectedTargets, makeCcLibraryTargets("none", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001544 "strip": `{
1545 "none": True,
1546 }`,
1547 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001548 expectedTargets = append(expectedTargets, makeCcLibraryTargets("nothing", AttrNameToString{})...)
Chris Parsons77acf2e2021-12-03 17:27:16 -05001549
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001550 runCcLibraryTestCase(t, Bp2buildTestCase{
1551 Description: "cc_library strip args",
1552 ModuleTypeUnderTest: "cc_library",
1553 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1554 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001555cc_library {
1556 name: "nothing",
Liz Kammer8337ea42021-09-10 10:06:32 -04001557 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001558}
1559cc_library {
1560 name: "keep_symbols",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001561 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001562 keep_symbols: true,
1563 },
1564 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001565}
1566cc_library {
1567 name: "keep_symbols_and_debug_frame",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001568 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001569 keep_symbols_and_debug_frame: true,
1570 },
1571 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001572}
1573cc_library {
1574 name: "none",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001575 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001576 none: true,
1577 },
1578 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001579}
1580cc_library {
1581 name: "keep_symbols_list",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001582 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001583 keep_symbols_list: ["symbol"],
1584 },
1585 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001586}
1587cc_library {
1588 name: "all",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001589 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001590 all: true,
1591 },
1592 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001593}
1594`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001595 ExpectedBazelTargets: expectedTargets,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001596 })
1597}
1598
1599func TestCcLibraryStripWithArch(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001600 runCcLibraryTestCase(t, Bp2buildTestCase{
1601 Description: "cc_library strip args",
1602 ModuleTypeUnderTest: "cc_library",
1603 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1604 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001605cc_library {
1606 name: "multi-arch",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001607 target: {
1608 darwin: {
1609 strip: {
1610 keep_symbols_list: ["foo", "bar"]
1611 }
1612 },
1613 },
1614 arch: {
1615 arm: {
1616 strip: {
1617 keep_symbols_and_debug_frame: true,
1618 },
1619 },
1620 arm64: {
1621 strip: {
1622 keep_symbols: true,
1623 },
1624 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001625 },
1626 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001627}
1628`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001629 ExpectedBazelTargets: makeCcLibraryTargets("multi-arch", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001630 "strip": `{
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001631 "keep_symbols": select({
1632 "//build/bazel/platforms/arch:arm64": True,
1633 "//conditions:default": None,
1634 }),
1635 "keep_symbols_and_debug_frame": select({
1636 "//build/bazel/platforms/arch:arm": True,
1637 "//conditions:default": None,
1638 }),
1639 "keep_symbols_list": select({
1640 "//build/bazel/platforms/os:darwin": [
1641 "foo",
1642 "bar",
1643 ],
1644 "//conditions:default": [],
1645 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001646 }`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001647 }),
1648 },
1649 )
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001650}
Chris Parsons51f8c392021-08-03 21:01:05 -04001651
1652func TestCcLibrary_SystemSharedLibsRootEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001653 runCcLibraryTestCase(t, Bp2buildTestCase{
1654 Description: "cc_library system_shared_libs empty at root",
1655 ModuleTypeUnderTest: "cc_library",
1656 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1657 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001658cc_library {
1659 name: "root_empty",
Liz Kammer8337ea42021-09-10 10:06:32 -04001660 system_shared_libs: [],
1661 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001662}
1663`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001664 ExpectedBazelTargets: makeCcLibraryTargets("root_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001665 "system_dynamic_deps": `[]`,
1666 }),
1667 },
1668 )
Chris Parsons51f8c392021-08-03 21:01:05 -04001669}
1670
1671func TestCcLibrary_SystemSharedLibsStaticEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001672 runCcLibraryTestCase(t, Bp2buildTestCase{
1673 Description: "cc_library system_shared_libs empty for static variant",
1674 ModuleTypeUnderTest: "cc_library",
1675 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1676 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001677cc_library {
1678 name: "static_empty",
1679 static: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001680 system_shared_libs: [],
1681 },
1682 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001683}
1684`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001685 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001686 MakeBazelTarget("cc_library_static", "static_empty_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001687 "system_dynamic_deps": "[]",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001688 }),
Alixe06d75b2022-08-31 18:28:19 +00001689 MakeBazelTarget("cc_library_shared", "static_empty", AttrNameToString{}),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001690 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001691 })
1692}
1693
1694func TestCcLibrary_SystemSharedLibsSharedEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001695 runCcLibraryTestCase(t, Bp2buildTestCase{
1696 Description: "cc_library system_shared_libs empty for shared variant",
1697 ModuleTypeUnderTest: "cc_library",
1698 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1699 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001700cc_library {
1701 name: "shared_empty",
1702 shared: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001703 system_shared_libs: [],
1704 },
1705 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001706}
1707`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001708 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001709 MakeBazelTarget("cc_library_static", "shared_empty_bp2build_cc_library_static", AttrNameToString{}),
1710 MakeBazelTarget("cc_library_shared", "shared_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001711 "system_dynamic_deps": "[]",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001712 }),
1713 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001714 })
1715}
1716
1717func TestCcLibrary_SystemSharedLibsSharedBionicEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001718 runCcLibraryTestCase(t, Bp2buildTestCase{
1719 Description: "cc_library system_shared_libs empty for shared, bionic variant",
1720 ModuleTypeUnderTest: "cc_library",
1721 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1722 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001723cc_library {
1724 name: "shared_empty",
1725 target: {
1726 bionic: {
1727 shared: {
1728 system_shared_libs: [],
1729 }
1730 }
Liz Kammer8337ea42021-09-10 10:06:32 -04001731 },
1732 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001733}
1734`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001735 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001736 MakeBazelTarget("cc_library_static", "shared_empty_bp2build_cc_library_static", AttrNameToString{}),
1737 MakeBazelTarget("cc_library_shared", "shared_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001738 "system_dynamic_deps": "[]",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001739 }),
1740 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001741 })
1742}
1743
1744func TestCcLibrary_SystemSharedLibsLinuxBionicEmpty(t *testing.T) {
1745 // Note that this behavior is technically incorrect (it's a simplification).
1746 // The correct behavior would be if bp2build wrote `system_dynamic_deps = []`
1747 // only for linux_bionic, but `android` had `["libc", "libdl", "libm"].
1748 // b/195791252 tracks the fix.
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001749 runCcLibraryTestCase(t, Bp2buildTestCase{
1750 Description: "cc_library system_shared_libs empty for linux_bionic variant",
1751 ModuleTypeUnderTest: "cc_library",
1752 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1753 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001754cc_library {
1755 name: "target_linux_bionic_empty",
1756 target: {
1757 linux_bionic: {
1758 system_shared_libs: [],
1759 },
1760 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001761 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001762}
1763`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001764 ExpectedBazelTargets: makeCcLibraryTargets("target_linux_bionic_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001765 "system_dynamic_deps": `[]`,
1766 }),
1767 },
1768 )
Chris Parsons51f8c392021-08-03 21:01:05 -04001769}
1770
1771func TestCcLibrary_SystemSharedLibsBionicEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001772 runCcLibraryTestCase(t, Bp2buildTestCase{
1773 Description: "cc_library system_shared_libs empty for bionic variant",
1774 ModuleTypeUnderTest: "cc_library",
1775 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1776 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001777cc_library {
1778 name: "target_bionic_empty",
1779 target: {
1780 bionic: {
1781 system_shared_libs: [],
1782 },
1783 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001784 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001785}
1786`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001787 ExpectedBazelTargets: makeCcLibraryTargets("target_bionic_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001788 "system_dynamic_deps": `[]`,
1789 }),
1790 },
1791 )
Chris Parsons51f8c392021-08-03 21:01:05 -04001792}
1793
1794func TestCcLibrary_SystemSharedLibsSharedAndRoot(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001795 runCcLibraryTestCase(t, Bp2buildTestCase{
1796 Description: "cc_library system_shared_libs set for shared and root",
1797 ModuleTypeUnderTest: "cc_library",
1798 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1799 Blueprint: soongCcLibraryPreamble + `
Liz Kammer8337ea42021-09-10 10:06:32 -04001800cc_library {
1801 name: "libc",
1802 bazel_module: { bp2build_available: false },
1803}
1804cc_library {
1805 name: "libm",
1806 bazel_module: { bp2build_available: false },
1807}
Chris Parsons51f8c392021-08-03 21:01:05 -04001808
1809cc_library {
1810 name: "foo",
1811 system_shared_libs: ["libc"],
1812 shared: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001813 system_shared_libs: ["libm"],
Chris Parsons51f8c392021-08-03 21:01:05 -04001814 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001815 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001816}
1817`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001818 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001819 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001820 "system_dynamic_deps": `[":libc"]`,
1821 }),
Alixe06d75b2022-08-31 18:28:19 +00001822 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001823 "system_dynamic_deps": `[
1824 ":libc",
1825 ":libm",
1826 ]`,
1827 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001828 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001829 })
1830}
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001831
1832func TestCcLibraryOsSelects(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001833 runCcLibraryTestCase(t, Bp2buildTestCase{
1834 Description: "cc_library - selects for all os targets",
1835 ModuleTypeUnderTest: "cc_library",
1836 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1837 Filesystem: map[string]string{},
1838 Blueprint: soongCcLibraryPreamble + `
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001839cc_library {
1840 name: "foo-lib",
1841 srcs: ["base.cpp"],
1842 target: {
1843 android: {
1844 srcs: ["android.cpp"],
1845 },
1846 linux: {
1847 srcs: ["linux.cpp"],
1848 },
1849 linux_glibc: {
1850 srcs: ["linux_glibc.cpp"],
1851 },
1852 darwin: {
1853 srcs: ["darwin.cpp"],
1854 },
1855 bionic: {
1856 srcs: ["bionic.cpp"],
1857 },
1858 linux_musl: {
1859 srcs: ["linux_musl.cpp"],
1860 },
1861 windows: {
1862 srcs: ["windows.cpp"],
1863 },
1864 },
1865 include_build_directory: false,
1866}
1867`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001868 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001869 "srcs": `["base.cpp"] + select({
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001870 "//build/bazel/platforms/os:android": [
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001871 "linux.cpp",
Liz Kammer9bad9d62021-10-11 15:40:35 -04001872 "bionic.cpp",
Liz Kammerfdd72e62021-10-11 15:41:03 -04001873 "android.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001874 ],
1875 "//build/bazel/platforms/os:darwin": ["darwin.cpp"],
1876 "//build/bazel/platforms/os:linux": [
Liz Kammer9bad9d62021-10-11 15:40:35 -04001877 "linux.cpp",
Liz Kammerfdd72e62021-10-11 15:41:03 -04001878 "linux_glibc.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001879 ],
1880 "//build/bazel/platforms/os:linux_bionic": [
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001881 "linux.cpp",
Liz Kammer9bad9d62021-10-11 15:40:35 -04001882 "bionic.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001883 ],
1884 "//build/bazel/platforms/os:linux_musl": [
Liz Kammer9bad9d62021-10-11 15:40:35 -04001885 "linux.cpp",
Liz Kammerfdd72e62021-10-11 15:41:03 -04001886 "linux_musl.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001887 ],
1888 "//build/bazel/platforms/os:windows": ["windows.cpp"],
1889 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001890 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001891 }),
1892 },
1893 )
Jingwen Chen97b85312021-10-08 10:41:31 +00001894}
1895
Yu Liu75be7b92022-02-01 09:54:09 -08001896func TestLibcryptoHashInjection(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001897 runCcLibraryTestCase(t, Bp2buildTestCase{
1898 Description: "cc_library - libcrypto hash injection",
1899 ModuleTypeUnderTest: "cc_library",
1900 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1901 Filesystem: map[string]string{},
1902 Blueprint: soongCcLibraryPreamble + `
Yu Liu75be7b92022-02-01 09:54:09 -08001903cc_library {
1904 name: "libcrypto",
1905 target: {
1906 android: {
1907 inject_bssl_hash: true,
1908 },
1909 },
1910 include_build_directory: false,
1911}
1912`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001913 ExpectedBazelTargets: makeCcLibraryTargets("libcrypto", AttrNameToString{
Yu Liu75be7b92022-02-01 09:54:09 -08001914 "inject_bssl_hash": `select({
1915 "//build/bazel/platforms/os:android": True,
1916 "//conditions:default": None,
1917 })`,
1918 }),
1919 },
1920 )
1921}
1922
Jingwen Chen5b11ab12021-10-11 17:44:33 +00001923func TestCcLibraryCppStdWithGnuExtensions_ConvertsToFeatureAttr(t *testing.T) {
Jingwen Chen97b85312021-10-08 10:41:31 +00001924 type testCase struct {
1925 cpp_std string
Chris Parsons79bd2b72021-11-29 17:52:41 -05001926 c_std string
Jingwen Chen97b85312021-10-08 10:41:31 +00001927 gnu_extensions string
1928 bazel_cpp_std string
Chris Parsons79bd2b72021-11-29 17:52:41 -05001929 bazel_c_std string
Jingwen Chen97b85312021-10-08 10:41:31 +00001930 }
1931
1932 testCases := []testCase{
1933 // Existing usages of cpp_std in AOSP are:
1934 // experimental, c++11, c++17, c++2a, c++98, gnu++11, gnu++17
1935 //
1936 // not set, only emit if gnu_extensions is disabled. the default (gnu+17
1937 // is set in the toolchain.)
1938 {cpp_std: "", gnu_extensions: "", bazel_cpp_std: ""},
Liz Kammera5a29de2022-05-25 23:19:37 -04001939 {cpp_std: "", gnu_extensions: "false", bazel_cpp_std: "cpp_std_default_no_gnu", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001940 {cpp_std: "", gnu_extensions: "true", bazel_cpp_std: ""},
1941 // experimental defaults to gnu++2a
Liz Kammera5a29de2022-05-25 23:19:37 -04001942 {cpp_std: "experimental", gnu_extensions: "", bazel_cpp_std: "cpp_std_experimental"},
1943 {cpp_std: "experimental", gnu_extensions: "false", bazel_cpp_std: "cpp_std_experimental_no_gnu", bazel_c_std: "c_std_default_no_gnu"},
1944 {cpp_std: "experimental", gnu_extensions: "true", bazel_cpp_std: "cpp_std_experimental"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001945 // Explicitly setting a c++ std does not use replace gnu++ std even if
1946 // gnu_extensions is true.
1947 // "c++11",
1948 {cpp_std: "c++11", gnu_extensions: "", bazel_cpp_std: "c++11"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001949 {cpp_std: "c++11", gnu_extensions: "false", bazel_cpp_std: "c++11", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001950 {cpp_std: "c++11", gnu_extensions: "true", bazel_cpp_std: "c++11"},
1951 // "c++17",
1952 {cpp_std: "c++17", gnu_extensions: "", bazel_cpp_std: "c++17"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001953 {cpp_std: "c++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001954 {cpp_std: "c++17", gnu_extensions: "true", bazel_cpp_std: "c++17"},
1955 // "c++2a",
1956 {cpp_std: "c++2a", gnu_extensions: "", bazel_cpp_std: "c++2a"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001957 {cpp_std: "c++2a", gnu_extensions: "false", bazel_cpp_std: "c++2a", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001958 {cpp_std: "c++2a", gnu_extensions: "true", bazel_cpp_std: "c++2a"},
1959 // "c++98",
1960 {cpp_std: "c++98", gnu_extensions: "", bazel_cpp_std: "c++98"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001961 {cpp_std: "c++98", gnu_extensions: "false", bazel_cpp_std: "c++98", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001962 {cpp_std: "c++98", gnu_extensions: "true", bazel_cpp_std: "c++98"},
1963 // gnu++ is replaced with c++ if gnu_extensions is explicitly false.
1964 // "gnu++11",
1965 {cpp_std: "gnu++11", gnu_extensions: "", bazel_cpp_std: "gnu++11"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001966 {cpp_std: "gnu++11", gnu_extensions: "false", bazel_cpp_std: "c++11", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001967 {cpp_std: "gnu++11", gnu_extensions: "true", bazel_cpp_std: "gnu++11"},
1968 // "gnu++17",
1969 {cpp_std: "gnu++17", gnu_extensions: "", bazel_cpp_std: "gnu++17"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001970 {cpp_std: "gnu++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001971 {cpp_std: "gnu++17", gnu_extensions: "true", bazel_cpp_std: "gnu++17"},
Chris Parsons79bd2b72021-11-29 17:52:41 -05001972
1973 // some c_std test cases
Liz Kammera5a29de2022-05-25 23:19:37 -04001974 {c_std: "experimental", gnu_extensions: "", bazel_c_std: "c_std_experimental"},
1975 {c_std: "experimental", gnu_extensions: "false", bazel_cpp_std: "cpp_std_default_no_gnu", bazel_c_std: "c_std_experimental_no_gnu"},
1976 {c_std: "experimental", gnu_extensions: "true", bazel_c_std: "c_std_experimental"},
Chris Parsons79bd2b72021-11-29 17:52:41 -05001977 {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "", bazel_cpp_std: "gnu++17", bazel_c_std: "gnu11"},
1978 {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c11"},
1979 {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "true", bazel_cpp_std: "gnu++17", bazel_c_std: "gnu11"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001980 }
Chris Parsons79bd2b72021-11-29 17:52:41 -05001981 for i, tc := range testCases {
Liz Kammera5a29de2022-05-25 23:19:37 -04001982 name := fmt.Sprintf("cpp std: %q, c std: %q, gnu_extensions: %q", tc.cpp_std, tc.c_std, tc.gnu_extensions)
1983 t.Run(name, func(t *testing.T) {
1984 name_prefix := fmt.Sprintf("a_%v", i)
1985 cppStdProp := ""
1986 if tc.cpp_std != "" {
1987 cppStdProp = fmt.Sprintf(" cpp_std: \"%s\",", tc.cpp_std)
1988 }
1989 cStdProp := ""
1990 if tc.c_std != "" {
1991 cStdProp = fmt.Sprintf(" c_std: \"%s\",", tc.c_std)
1992 }
1993 gnuExtensionsProp := ""
1994 if tc.gnu_extensions != "" {
1995 gnuExtensionsProp = fmt.Sprintf(" gnu_extensions: %s,", tc.gnu_extensions)
1996 }
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001997 attrs := AttrNameToString{}
Liz Kammera5a29de2022-05-25 23:19:37 -04001998 if tc.bazel_cpp_std != "" {
1999 attrs["cpp_std"] = fmt.Sprintf(`"%s"`, tc.bazel_cpp_std)
2000 }
2001 if tc.bazel_c_std != "" {
2002 attrs["c_std"] = fmt.Sprintf(`"%s"`, tc.bazel_c_std)
2003 }
Jingwen Chen97b85312021-10-08 10:41:31 +00002004
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002005 runCcLibraryTestCase(t, Bp2buildTestCase{
2006 Description: fmt.Sprintf(
Liz Kammera5a29de2022-05-25 23:19:37 -04002007 "cc_library with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002008 ModuleTypeUnderTest: "cc_library",
2009 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2010 Blueprint: soongCcLibraryPreamble + fmt.Sprintf(`
Jingwen Chen97b85312021-10-08 10:41:31 +00002011cc_library {
Chris Parsons79bd2b72021-11-29 17:52:41 -05002012 name: "%s_full",
Jingwen Chen97b85312021-10-08 10:41:31 +00002013%s // cpp_std: *string
Chris Parsons79bd2b72021-11-29 17:52:41 -05002014%s // c_std: *string
Jingwen Chen97b85312021-10-08 10:41:31 +00002015%s // gnu_extensions: *bool
2016 include_build_directory: false,
2017}
Chris Parsons79bd2b72021-11-29 17:52:41 -05002018`, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002019 ExpectedBazelTargets: makeCcLibraryTargets(name_prefix+"_full", attrs),
Liz Kammera5a29de2022-05-25 23:19:37 -04002020 })
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002021
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002022 runCcLibraryStaticTestCase(t, Bp2buildTestCase{
2023 Description: fmt.Sprintf(
Liz Kammera5a29de2022-05-25 23:19:37 -04002024 "cc_library_static with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002025 ModuleTypeUnderTest: "cc_library_static",
2026 ModuleTypeUnderTestFactory: cc.LibraryStaticFactory,
2027 Blueprint: soongCcLibraryPreamble + fmt.Sprintf(`
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002028cc_library_static {
Chris Parsons79bd2b72021-11-29 17:52:41 -05002029 name: "%s_static",
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002030%s // cpp_std: *string
Chris Parsons79bd2b72021-11-29 17:52:41 -05002031%s // c_std: *string
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002032%s // gnu_extensions: *bool
2033 include_build_directory: false,
2034}
Chris Parsons79bd2b72021-11-29 17:52:41 -05002035`, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002036 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002037 MakeBazelTarget("cc_library_static", name_prefix+"_static", attrs),
Liz Kammera5a29de2022-05-25 23:19:37 -04002038 },
2039 })
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002040
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002041 runCcLibrarySharedTestCase(t, Bp2buildTestCase{
2042 Description: fmt.Sprintf(
Liz Kammera5a29de2022-05-25 23:19:37 -04002043 "cc_library_shared with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002044 ModuleTypeUnderTest: "cc_library_shared",
2045 ModuleTypeUnderTestFactory: cc.LibrarySharedFactory,
2046 Blueprint: soongCcLibraryPreamble + fmt.Sprintf(`
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002047cc_library_shared {
Chris Parsons79bd2b72021-11-29 17:52:41 -05002048 name: "%s_shared",
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002049%s // cpp_std: *string
Chris Parsons79bd2b72021-11-29 17:52:41 -05002050%s // c_std: *string
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002051%s // gnu_extensions: *bool
2052 include_build_directory: false,
2053}
Chris Parsons79bd2b72021-11-29 17:52:41 -05002054`, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002055 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002056 MakeBazelTarget("cc_library_shared", name_prefix+"_shared", attrs),
Liz Kammera5a29de2022-05-25 23:19:37 -04002057 },
2058 })
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002059 })
Jingwen Chen97b85312021-10-08 10:41:31 +00002060 }
Chris Parsons2dde0cb2021-10-01 14:45:30 -04002061}
Liz Kammer12615db2021-09-28 09:19:17 -04002062
2063func TestCcLibraryProtoSimple(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002064 runCcLibraryTestCase(t, Bp2buildTestCase{
2065 ModuleTypeUnderTest: "cc_library",
2066 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2067 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002068 name: "foo",
2069 srcs: ["foo.proto"],
2070 include_build_directory: false,
2071}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002072 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002073 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer7756c8f2022-02-14 20:49:15 -05002074 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002075 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002076 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002077 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002078 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002079 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002080 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05002081 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002082 }),
2083 },
2084 })
2085}
2086
2087func TestCcLibraryProtoNoCanonicalPathFromRoot(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002088 runCcLibraryTestCase(t, Bp2buildTestCase{
2089 ModuleTypeUnderTest: "cc_library",
2090 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2091 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002092 name: "foo",
2093 srcs: ["foo.proto"],
2094 proto: { canonical_path_from_root: false},
2095 include_build_directory: false,
2096}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002097 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002098 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer7756c8f2022-02-14 20:49:15 -05002099 "srcs": `["foo.proto"]`,
2100 "strip_import_prefix": `""`,
Alixe06d75b2022-08-31 18:28:19 +00002101 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002102 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002103 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002104 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002105 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002106 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05002107 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002108 }),
2109 },
2110 })
2111}
2112
2113func TestCcLibraryProtoExplicitCanonicalPathFromRoot(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002114 runCcLibraryTestCase(t, Bp2buildTestCase{
2115 ModuleTypeUnderTest: "cc_library",
2116 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2117 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002118 name: "foo",
2119 srcs: ["foo.proto"],
2120 proto: { canonical_path_from_root: true},
2121 include_build_directory: false,
2122}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002123 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002124 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer7756c8f2022-02-14 20:49:15 -05002125 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002126 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002127 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002128 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002129 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002130 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002131 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05002132 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002133 }),
2134 },
2135 })
2136}
2137
2138func TestCcLibraryProtoFull(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002139 runCcLibraryTestCase(t, Bp2buildTestCase{
2140 ModuleTypeUnderTest: "cc_library",
2141 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2142 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002143 name: "foo",
2144 srcs: ["foo.proto"],
2145 proto: {
Liz Kammer12615db2021-09-28 09:19:17 -04002146 type: "full",
2147 },
2148 include_build_directory: false,
2149}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002150 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002151 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002152 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002153 }), MakeBazelTarget("cc_proto_library", "foo_cc_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002154 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002155 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002156 "implementation_whole_archive_deps": `[":foo_cc_proto"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002157 "deps": `[":libprotobuf-cpp-full"]`,
Alixe06d75b2022-08-31 18:28:19 +00002158 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05002159 "dynamic_deps": `[":libprotobuf-cpp-full"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002160 }),
2161 },
2162 })
2163}
2164
2165func TestCcLibraryProtoLite(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002166 runCcLibraryTestCase(t, Bp2buildTestCase{
2167 ModuleTypeUnderTest: "cc_library",
2168 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2169 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002170 name: "foo",
2171 srcs: ["foo.proto"],
2172 proto: {
Liz Kammer12615db2021-09-28 09:19:17 -04002173 type: "lite",
2174 },
2175 include_build_directory: false,
2176}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002177 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002178 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002179 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002180 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002181 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002182 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002183 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002184 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002185 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05002186 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002187 }),
2188 },
2189 })
2190}
2191
2192func TestCcLibraryProtoExportHeaders(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002193 runCcLibraryTestCase(t, Bp2buildTestCase{
2194 ModuleTypeUnderTest: "cc_library",
2195 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2196 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002197 name: "foo",
2198 srcs: ["foo.proto"],
2199 proto: {
Liz Kammer12615db2021-09-28 09:19:17 -04002200 export_proto_headers: true,
2201 },
2202 include_build_directory: false,
2203}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002204 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002205 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002206 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002207 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002208 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002209 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05002210 "deps": `[":libprotobuf-cpp-lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002211 "whole_archive_deps": `[":foo_cc_proto_lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002212 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05002213 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2214 "whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002215 }),
2216 },
2217 })
2218}
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002219
Yu Liu2d136142022-08-18 14:46:13 -07002220func TestCcLibraryProtoIncludeDirs(t *testing.T) {
2221 runCcLibraryTestCase(t, Bp2buildTestCase{
2222 ModuleTypeUnderTest: "cc_library",
2223 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2224 Blueprint: soongCcProtoPreamble + `cc_library {
2225 name: "foo",
2226 srcs: ["foo.proto"],
2227 proto: {
2228 include_dirs: ["external/protobuf/src"],
2229 },
2230 include_build_directory: false,
2231}`,
2232 ExpectedBazelTargets: []string{
2233 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
2234 "srcs": `["foo.proto"]`,
2235 "deps": `["//external/protobuf:libprotobuf-proto"]`,
2236 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
2237 "deps": `[":foo_proto"]`,
2238 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
2239 "deps": `[":libprotobuf-cpp-lite"]`,
2240 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
2241 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
2242 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2243 }),
2244 },
2245 })
2246}
2247
2248func TestCcLibraryProtoIncludeDirsUnknown(t *testing.T) {
2249 runCcLibraryTestCase(t, Bp2buildTestCase{
2250 ModuleTypeUnderTest: "cc_library",
2251 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2252 Blueprint: soongCcProtoPreamble + `cc_library {
2253 name: "foo",
2254 srcs: ["foo.proto"],
2255 proto: {
2256 include_dirs: ["external/protobuf/abc"],
2257 },
2258 include_build_directory: false,
2259}`,
2260 ExpectedErr: fmt.Errorf("module \"foo\": Could not find the proto_library target for include dir: external/protobuf/abc"),
2261 })
2262}
2263
Yu Liu2aa806b2022-09-01 11:54:47 -07002264func TestCcLibraryConvertedProtoFilegroups(t *testing.T) {
2265 runCcLibraryTestCase(t, Bp2buildTestCase{
2266 ModuleTypeUnderTest: "cc_library",
2267 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2268 Blueprint: soongCcProtoPreamble + `
2269filegroup {
2270 name: "a_fg_proto",
2271 srcs: ["a_fg.proto"],
2272}
2273
2274cc_library {
2275 name: "a",
2276 srcs: [
2277 ":a_fg_proto",
2278 "a.proto",
2279 ],
2280 proto: {
2281 export_proto_headers: true,
2282 },
2283 include_build_directory: false,
2284}`,
2285 ExpectedBazelTargets: []string{
2286 MakeBazelTarget("proto_library", "a_proto", AttrNameToString{
Yu Liu2a85fb12022-09-15 22:18:48 -07002287 "deps": `[":a_fg_proto_bp2build_converted"]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002288 "srcs": `["a.proto"]`,
2289 }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
2290 "deps": `[
2291 ":a_fg_proto_bp2build_converted",
2292 ":a_proto",
2293 ]`,
2294 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
2295 "deps": `[":libprotobuf-cpp-lite"]`,
2296 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2297 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
2298 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2299 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2300 }), MakeBazelTargetNoRestrictions("proto_library", "a_fg_proto_bp2build_converted", AttrNameToString{
2301 "srcs": `["a_fg.proto"]`,
Yu Liu2a85fb12022-09-15 22:18:48 -07002302 "tags": `["manual"]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002303 }), MakeBazelTargetNoRestrictions("filegroup", "a_fg_proto", AttrNameToString{
2304 "srcs": `["a_fg.proto"]`,
2305 }),
2306 },
2307 })
2308}
2309
2310func TestCcLibraryConvertedProtoFilegroupsNoProtoFiles(t *testing.T) {
2311 runCcLibraryTestCase(t, Bp2buildTestCase{
2312 ModuleTypeUnderTest: "cc_library",
2313 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2314 Blueprint: soongCcProtoPreamble + `
2315filegroup {
2316 name: "a_fg_proto",
2317 srcs: ["a_fg.proto"],
2318}
2319
2320cc_library {
2321 name: "a",
2322 srcs: [
2323 ":a_fg_proto",
2324 ],
2325 proto: {
2326 export_proto_headers: true,
2327 },
2328 include_build_directory: false,
2329}`,
2330 ExpectedBazelTargets: []string{
2331 MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
2332 "deps": `[":a_fg_proto_bp2build_converted"]`,
2333 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
2334 "deps": `[":libprotobuf-cpp-lite"]`,
2335 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2336 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
2337 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2338 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2339 }), MakeBazelTargetNoRestrictions("proto_library", "a_fg_proto_bp2build_converted", AttrNameToString{
2340 "srcs": `["a_fg.proto"]`,
Yu Liu2a85fb12022-09-15 22:18:48 -07002341 "tags": `["manual"]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002342 }), MakeBazelTargetNoRestrictions("filegroup", "a_fg_proto", AttrNameToString{
2343 "srcs": `["a_fg.proto"]`,
2344 }),
2345 },
2346 })
2347}
2348
2349func TestCcLibraryExternalConvertedProtoFilegroups(t *testing.T) {
2350 runCcLibraryTestCase(t, Bp2buildTestCase{
2351 ModuleTypeUnderTest: "cc_library",
2352 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2353 Filesystem: map[string]string{
2354 "path/to/A/Android.bp": `
2355filegroup {
2356 name: "a_fg_proto",
2357 srcs: ["a_fg.proto"],
2358}`,
2359 },
2360 Blueprint: soongCcProtoPreamble + `
2361cc_library {
2362 name: "a",
2363 srcs: [
2364 ":a_fg_proto",
2365 "a.proto",
2366 ],
2367 proto: {
2368 export_proto_headers: true,
2369 },
2370 include_build_directory: false,
2371}`,
2372 ExpectedBazelTargets: []string{
2373 MakeBazelTarget("proto_library", "a_proto", AttrNameToString{
Yu Liu2a85fb12022-09-15 22:18:48 -07002374 "deps": `["//path/to/A:a_fg_proto_bp2build_converted"]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002375 "srcs": `["a.proto"]`,
2376 }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
2377 "deps": `[
2378 "//path/to/A:a_fg_proto_bp2build_converted",
2379 ":a_proto",
2380 ]`,
2381 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
2382 "deps": `[":libprotobuf-cpp-lite"]`,
2383 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2384 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
2385 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2386 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2387 }),
2388 },
2389 })
2390}
2391
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002392func TestCcLibraryProtoFilegroups(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002393 runCcLibraryTestCase(t, Bp2buildTestCase{
2394 ModuleTypeUnderTest: "cc_library",
2395 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2396 Blueprint: soongCcProtoPreamble +
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002397 simpleModuleDoNotConvertBp2build("filegroup", "a_fg_proto") +
2398 simpleModuleDoNotConvertBp2build("filegroup", "b_protos") +
2399 simpleModuleDoNotConvertBp2build("filegroup", "c-proto-srcs") +
2400 simpleModuleDoNotConvertBp2build("filegroup", "proto-srcs-d") + `
2401cc_library {
2402 name: "a",
2403 srcs: [":a_fg_proto"],
2404 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002405 export_proto_headers: true,
2406 },
2407 include_build_directory: false,
2408}
2409
2410cc_library {
2411 name: "b",
2412 srcs: [":b_protos"],
2413 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002414 export_proto_headers: true,
2415 },
2416 include_build_directory: false,
2417}
2418
2419cc_library {
2420 name: "c",
2421 srcs: [":c-proto-srcs"],
2422 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002423 export_proto_headers: true,
2424 },
2425 include_build_directory: false,
2426}
2427
2428cc_library {
2429 name: "d",
2430 srcs: [":proto-srcs-d"],
2431 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002432 export_proto_headers: true,
2433 },
2434 include_build_directory: false,
2435}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002436 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002437 MakeBazelTarget("proto_library", "a_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002438 "srcs": `[":a_fg_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002439 }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002440 "deps": `[":a_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002441 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002442 "deps": `[":libprotobuf-cpp-lite"]`,
2443 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2444 "srcs": `[":a_fg_proto_cpp_srcs"]`,
2445 "srcs_as": `[":a_fg_proto_as_srcs"]`,
2446 "srcs_c": `[":a_fg_proto_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002447 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002448 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2449 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2450 "srcs": `[":a_fg_proto_cpp_srcs"]`,
2451 "srcs_as": `[":a_fg_proto_as_srcs"]`,
2452 "srcs_c": `[":a_fg_proto_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002453 }), MakeBazelTarget("proto_library", "b_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002454 "srcs": `[":b_protos"]`,
Alixe06d75b2022-08-31 18:28:19 +00002455 }), MakeBazelTarget("cc_lite_proto_library", "b_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002456 "deps": `[":b_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002457 }), MakeBazelTarget("cc_library_static", "b_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002458 "deps": `[":libprotobuf-cpp-lite"]`,
2459 "whole_archive_deps": `[":b_cc_proto_lite"]`,
2460 "srcs": `[":b_protos_cpp_srcs"]`,
2461 "srcs_as": `[":b_protos_as_srcs"]`,
2462 "srcs_c": `[":b_protos_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002463 }), MakeBazelTarget("cc_library_shared", "b", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002464 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2465 "whole_archive_deps": `[":b_cc_proto_lite"]`,
2466 "srcs": `[":b_protos_cpp_srcs"]`,
2467 "srcs_as": `[":b_protos_as_srcs"]`,
2468 "srcs_c": `[":b_protos_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002469 }), MakeBazelTarget("proto_library", "c_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002470 "srcs": `[":c-proto-srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002471 }), MakeBazelTarget("cc_lite_proto_library", "c_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002472 "deps": `[":c_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002473 }), MakeBazelTarget("cc_library_static", "c_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002474 "deps": `[":libprotobuf-cpp-lite"]`,
2475 "whole_archive_deps": `[":c_cc_proto_lite"]`,
2476 "srcs": `[":c-proto-srcs_cpp_srcs"]`,
2477 "srcs_as": `[":c-proto-srcs_as_srcs"]`,
2478 "srcs_c": `[":c-proto-srcs_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002479 }), MakeBazelTarget("cc_library_shared", "c", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002480 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2481 "whole_archive_deps": `[":c_cc_proto_lite"]`,
2482 "srcs": `[":c-proto-srcs_cpp_srcs"]`,
2483 "srcs_as": `[":c-proto-srcs_as_srcs"]`,
2484 "srcs_c": `[":c-proto-srcs_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002485 }), MakeBazelTarget("proto_library", "d_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002486 "srcs": `[":proto-srcs-d"]`,
Alixe06d75b2022-08-31 18:28:19 +00002487 }), MakeBazelTarget("cc_lite_proto_library", "d_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002488 "deps": `[":d_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002489 }), MakeBazelTarget("cc_library_static", "d_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002490 "deps": `[":libprotobuf-cpp-lite"]`,
2491 "whole_archive_deps": `[":d_cc_proto_lite"]`,
2492 "srcs": `[":proto-srcs-d_cpp_srcs"]`,
2493 "srcs_as": `[":proto-srcs-d_as_srcs"]`,
2494 "srcs_c": `[":proto-srcs-d_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002495 }), MakeBazelTarget("cc_library_shared", "d", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002496 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2497 "whole_archive_deps": `[":d_cc_proto_lite"]`,
2498 "srcs": `[":proto-srcs-d_cpp_srcs"]`,
2499 "srcs_as": `[":proto-srcs-d_as_srcs"]`,
2500 "srcs_c": `[":proto-srcs-d_c_srcs"]`,
2501 }),
2502 },
2503 })
2504}
Chris Parsons58852a02021-12-09 18:10:18 -05002505
2506func TestCcLibraryDisabledArchAndTarget(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002507 runCcLibraryTestCase(t, Bp2buildTestCase{
2508 ModuleTypeUnderTest: "cc_library",
2509 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2510 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002511 name: "foo",
2512 srcs: ["foo.cpp"],
Liz Kammerdfeb1202022-05-13 17:20:20 -04002513 host_supported: true,
Chris Parsons58852a02021-12-09 18:10:18 -05002514 target: {
2515 darwin: {
2516 enabled: false,
2517 },
2518 windows: {
2519 enabled: false,
2520 },
2521 linux_glibc_x86: {
2522 enabled: false,
2523 },
2524 },
2525 include_build_directory: false,
2526}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002527 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002528 "srcs": `["foo.cpp"]`,
2529 "target_compatible_with": `select({
2530 "//build/bazel/platforms/os_arch:darwin_arm64": ["@platforms//:incompatible"],
2531 "//build/bazel/platforms/os_arch:darwin_x86_64": ["@platforms//:incompatible"],
2532 "//build/bazel/platforms/os_arch:linux_glibc_x86": ["@platforms//:incompatible"],
2533 "//build/bazel/platforms/os_arch:windows_x86": ["@platforms//:incompatible"],
2534 "//build/bazel/platforms/os_arch:windows_x86_64": ["@platforms//:incompatible"],
2535 "//conditions:default": [],
2536 })`,
2537 }),
2538 })
2539}
2540
2541func TestCcLibraryDisabledArchAndTargetWithDefault(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002542 runCcLibraryTestCase(t, Bp2buildTestCase{
2543 ModuleTypeUnderTest: "cc_library",
2544 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2545 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002546 name: "foo",
2547 srcs: ["foo.cpp"],
2548 enabled: false,
Liz Kammerdfeb1202022-05-13 17:20:20 -04002549 host_supported: true,
Chris Parsons58852a02021-12-09 18:10:18 -05002550 target: {
2551 darwin: {
2552 enabled: true,
2553 },
2554 windows: {
2555 enabled: false,
2556 },
2557 linux_glibc_x86: {
2558 enabled: false,
2559 },
2560 },
2561 include_build_directory: false,
2562}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002563 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002564 "srcs": `["foo.cpp"]`,
2565 "target_compatible_with": `select({
2566 "//build/bazel/platforms/os_arch:darwin_arm64": [],
2567 "//build/bazel/platforms/os_arch:darwin_x86_64": [],
2568 "//conditions:default": ["@platforms//:incompatible"],
2569 })`,
2570 }),
2571 })
2572}
2573
2574func TestCcLibrarySharedDisabled(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002575 runCcLibraryTestCase(t, Bp2buildTestCase{
2576 ModuleTypeUnderTest: "cc_library",
2577 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2578 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002579 name: "foo",
2580 srcs: ["foo.cpp"],
2581 enabled: false,
2582 shared: {
2583 enabled: true,
2584 },
2585 target: {
2586 android: {
2587 shared: {
2588 enabled: false,
2589 },
2590 }
2591 },
2592 include_build_directory: false,
2593}`,
Alixe06d75b2022-08-31 18:28:19 +00002594 ExpectedBazelTargets: []string{MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002595 "srcs": `["foo.cpp"]`,
2596 "target_compatible_with": `["@platforms//:incompatible"]`,
Alixe06d75b2022-08-31 18:28:19 +00002597 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002598 "srcs": `["foo.cpp"]`,
2599 "target_compatible_with": `select({
2600 "//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
2601 "//conditions:default": [],
2602 })`,
2603 }),
2604 },
2605 })
2606}
2607
2608func TestCcLibraryStaticDisabledForSomeArch(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002609 runCcLibraryTestCase(t, Bp2buildTestCase{
2610 ModuleTypeUnderTest: "cc_library",
2611 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2612 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002613 name: "foo",
Liz Kammerdfeb1202022-05-13 17:20:20 -04002614 host_supported: true,
Chris Parsons58852a02021-12-09 18:10:18 -05002615 srcs: ["foo.cpp"],
2616 shared: {
2617 enabled: false
2618 },
2619 target: {
2620 darwin: {
2621 enabled: true,
2622 },
2623 windows: {
2624 enabled: false,
2625 },
2626 linux_glibc_x86: {
2627 shared: {
2628 enabled: true,
2629 },
2630 },
2631 },
2632 include_build_directory: false,
2633}`,
Alixe06d75b2022-08-31 18:28:19 +00002634 ExpectedBazelTargets: []string{MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002635 "srcs": `["foo.cpp"]`,
2636 "target_compatible_with": `select({
2637 "//build/bazel/platforms/os:windows": ["@platforms//:incompatible"],
2638 "//conditions:default": [],
2639 })`,
Alixe06d75b2022-08-31 18:28:19 +00002640 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002641 "srcs": `["foo.cpp"]`,
2642 "target_compatible_with": `select({
2643 "//build/bazel/platforms/os_arch:darwin_arm64": [],
2644 "//build/bazel/platforms/os_arch:darwin_x86_64": [],
2645 "//build/bazel/platforms/os_arch:linux_glibc_x86": [],
2646 "//conditions:default": ["@platforms//:incompatible"],
2647 })`,
2648 }),
2649 }})
2650}
Jingwen Chen0ee88a62022-01-07 14:55:29 +00002651
2652func TestCcLibraryStubs(t *testing.T) {
Wei Li81852ca2022-07-27 00:22:06 -07002653 expectedBazelTargets := makeCcLibraryTargets("a", AttrNameToString{
2654 "has_stubs": `True`,
2655 })
2656 expectedBazelTargets = append(expectedBazelTargets, makeCcStubSuiteTargets("a", AttrNameToString{
2657 "soname": `"a.so"`,
2658 "source_library": `":a"`,
2659 "stubs_symbol_file": `"a.map.txt"`,
2660 "stubs_versions": `[
2661 "28",
2662 "29",
2663 "current",
2664 ]`,
2665 }))
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002666 runCcLibraryTestCase(t, Bp2buildTestCase{
2667 Description: "cc_library stubs",
2668 ModuleTypeUnderTest: "cc_library",
2669 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2670 Dir: "foo/bar",
2671 Filesystem: map[string]string{
Jingwen Chen0ee88a62022-01-07 14:55:29 +00002672 "foo/bar/Android.bp": `
2673cc_library {
2674 name: "a",
2675 stubs: { symbol_file: "a.map.txt", versions: ["28", "29", "current"] },
2676 bazel_module: { bp2build_available: true },
2677 include_build_directory: false,
2678}
2679`,
2680 },
Wei Li81852ca2022-07-27 00:22:06 -07002681 Blueprint: soongCcLibraryPreamble,
2682 ExpectedBazelTargets: expectedBazelTargets,
Jingwen Chen0ee88a62022-01-07 14:55:29 +00002683 },
2684 )
2685}
Liz Kammerf38a8372022-02-04 15:39:00 -05002686
2687func TestCcLibraryEscapeLdflags(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002688 runCcLibraryTestCase(t, Bp2buildTestCase{
2689 ModuleTypeUnderTest: "cc_library",
2690 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2691 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammerf38a8372022-02-04 15:39:00 -05002692 name: "foo",
2693 ldflags: ["-Wl,--rpath,${ORIGIN}"],
2694 include_build_directory: false,
2695}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002696 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
Liz Kammerf38a8372022-02-04 15:39:00 -05002697 "linkopts": `["-Wl,--rpath,$${ORIGIN}"]`,
2698 }),
2699 })
2700}
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002701
2702func TestCcLibraryConvertLex(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002703 runCcLibraryTestCase(t, Bp2buildTestCase{
2704 ModuleTypeUnderTest: "cc_library",
2705 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2706 Filesystem: map[string]string{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002707 "foo.c": "",
2708 "bar.cc": "",
2709 "foo1.l": "",
2710 "bar1.ll": "",
2711 "foo2.l": "",
2712 "bar2.ll": "",
2713 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002714 Blueprint: `cc_library {
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002715 name: "foo_lib",
2716 srcs: ["foo.c", "bar.cc", "foo1.l", "foo2.l", "bar1.ll", "bar2.ll"],
2717 lex: { flags: ["--foo_flags"] },
2718 include_build_directory: false,
2719 bazel_module: { bp2build_available: true },
2720}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002721 ExpectedBazelTargets: append([]string{
Alixe06d75b2022-08-31 18:28:19 +00002722 MakeBazelTarget("genlex", "foo_lib_genlex_l", AttrNameToString{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002723 "srcs": `[
2724 "foo1.l",
2725 "foo2.l",
2726 ]`,
2727 "lexopts": `["--foo_flags"]`,
2728 }),
Alixe06d75b2022-08-31 18:28:19 +00002729 MakeBazelTarget("genlex", "foo_lib_genlex_ll", AttrNameToString{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002730 "srcs": `[
2731 "bar1.ll",
2732 "bar2.ll",
2733 ]`,
2734 "lexopts": `["--foo_flags"]`,
2735 }),
2736 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002737 makeCcLibraryTargets("foo_lib", AttrNameToString{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002738 "srcs": `[
2739 "bar.cc",
2740 ":foo_lib_genlex_ll",
2741 ]`,
2742 "srcs_c": `[
2743 "foo.c",
2744 ":foo_lib_genlex_l",
2745 ]`,
2746 })...),
2747 })
2748}
Cole Faust6b29f592022-08-09 09:50:56 -07002749
2750func TestCCLibraryRuntimeDeps(t *testing.T) {
2751 runCcLibrarySharedTestCase(t, Bp2buildTestCase{
2752 Blueprint: `cc_library_shared {
2753 name: "bar",
2754}
2755
2756cc_library {
2757 name: "foo",
2758 runtime_libs: ["foo"],
2759}`,
2760 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002761 MakeBazelTarget("cc_library_shared", "bar", AttrNameToString{
Cole Faust6b29f592022-08-09 09:50:56 -07002762 "local_includes": `["."]`,
2763 }),
Alixe06d75b2022-08-31 18:28:19 +00002764 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Cole Faust6b29f592022-08-09 09:50:56 -07002765 "runtime_deps": `[":foo"]`,
2766 "local_includes": `["."]`,
2767 }),
Alixe06d75b2022-08-31 18:28:19 +00002768 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Cole Faust6b29f592022-08-09 09:50:56 -07002769 "runtime_deps": `[":foo"]`,
2770 "local_includes": `["."]`,
2771 }),
2772 },
2773 })
2774}
Cole Faust5fa4e962022-08-22 14:31:04 -07002775
2776func TestCcLibraryWithInstructionSet(t *testing.T) {
2777 runCcLibraryTestCase(t, Bp2buildTestCase{
2778 ModuleTypeUnderTest: "cc_library",
2779 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2780 Blueprint: `cc_library {
2781 name: "foo",
2782 arch: {
2783 arm: {
2784 instruction_set: "arm",
2785 }
2786 }
2787}
2788`,
2789 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
2790 "features": `select({
2791 "//build/bazel/platforms/arch:arm": [
2792 "arm_isa_arm",
2793 "-arm_isa_thumb",
2794 ],
2795 "//conditions:default": [],
2796 })`,
2797 "local_includes": `["."]`,
2798 }),
2799 })
2800}
Vinh Tran9f6796a2022-08-16 13:10:31 -04002801
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002802func TestCcLibraryEmptySuffix(t *testing.T) {
2803 runCcLibraryTestCase(t, Bp2buildTestCase{
2804 Description: "cc_library with empty suffix",
2805 ModuleTypeUnderTest: "cc_library",
2806 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2807 Filesystem: map[string]string{
2808 "foo.c": "",
2809 },
2810 Blueprint: `cc_library {
2811 name: "foo",
2812 suffix: "",
2813 srcs: ["foo.c"],
2814 include_build_directory: false,
2815}`,
2816 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002817 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002818 "srcs_c": `["foo.c"]`,
2819 }),
Alixe06d75b2022-08-31 18:28:19 +00002820 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002821 "srcs_c": `["foo.c"]`,
2822 "suffix": `""`,
2823 }),
2824 },
2825 })
2826}
2827
2828func TestCcLibrarySuffix(t *testing.T) {
2829 runCcLibraryTestCase(t, Bp2buildTestCase{
2830 Description: "cc_library with suffix",
2831 ModuleTypeUnderTest: "cc_library",
2832 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2833 Filesystem: map[string]string{
2834 "foo.c": "",
2835 },
2836 Blueprint: `cc_library {
2837 name: "foo",
2838 suffix: "-suf",
2839 srcs: ["foo.c"],
2840 include_build_directory: false,
2841}`,
2842 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002843 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002844 "srcs_c": `["foo.c"]`,
2845 }),
Alixe06d75b2022-08-31 18:28:19 +00002846 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002847 "srcs_c": `["foo.c"]`,
2848 "suffix": `"-suf"`,
2849 }),
2850 },
2851 })
2852}
2853
2854func TestCcLibraryArchVariantSuffix(t *testing.T) {
2855 runCcLibraryTestCase(t, Bp2buildTestCase{
2856 Description: "cc_library with arch-variant suffix",
2857 ModuleTypeUnderTest: "cc_library",
2858 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2859 Filesystem: map[string]string{
2860 "foo.c": "",
2861 },
2862 Blueprint: `cc_library {
2863 name: "foo",
2864 arch: {
2865 arm64: { suffix: "-64" },
2866 arm: { suffix: "-32" },
2867 },
2868 srcs: ["foo.c"],
2869 include_build_directory: false,
2870}`,
2871 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002872 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002873 "srcs_c": `["foo.c"]`,
2874 }),
Alixe06d75b2022-08-31 18:28:19 +00002875 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002876 "srcs_c": `["foo.c"]`,
2877 "suffix": `select({
2878 "//build/bazel/platforms/arch:arm": "-32",
2879 "//build/bazel/platforms/arch:arm64": "-64",
2880 "//conditions:default": None,
2881 })`,
2882 }),
2883 },
2884 })
2885}
2886
Vinh Tran9f6796a2022-08-16 13:10:31 -04002887func TestCcLibraryWithAidlSrcs(t *testing.T) {
2888 runCcLibraryTestCase(t, Bp2buildTestCase{
2889 Description: "cc_library with aidl srcs",
2890 ModuleTypeUnderTest: "cc_library",
2891 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2892 Blueprint: `
2893filegroup {
2894 name: "A_aidl",
2895 srcs: ["aidl/A.aidl"],
2896 path: "aidl",
2897}
2898cc_library {
2899 name: "foo",
2900 srcs: [
2901 ":A_aidl",
2902 "B.aidl",
2903 ],
2904}`,
2905 ExpectedBazelTargets: []string{
2906 MakeBazelTargetNoRestrictions("aidl_library", "A_aidl", AttrNameToString{
2907 "srcs": `["aidl/A.aidl"]`,
2908 "strip_import_prefix": `"aidl"`,
2909 }),
Alixe06d75b2022-08-31 18:28:19 +00002910 MakeBazelTarget("aidl_library", "foo_aidl_library", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04002911 "srcs": `["B.aidl"]`,
2912 }),
Alixe06d75b2022-08-31 18:28:19 +00002913 MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04002914 "deps": `[
2915 ":A_aidl",
2916 ":foo_aidl_library",
2917 ]`,
2918 }),
Alixe06d75b2022-08-31 18:28:19 +00002919 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Vinh Tranfde57eb2022-08-29 17:46:58 -04002920 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
2921 "local_includes": `["."]`,
Vinh Tran9f6796a2022-08-16 13:10:31 -04002922 }),
Vinh Tranfde57eb2022-08-29 17:46:58 -04002923 // TODO(b/239311679) Add implementation_whole_archive_deps to cc_library_shared
2924 // for bp2build to be fully correct. This fallback is affecting proto as well.
Alixe06d75b2022-08-31 18:28:19 +00002925 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Vinh Tranfde57eb2022-08-29 17:46:58 -04002926 "local_includes": `["."]`,
Vinh Tran9f6796a2022-08-16 13:10:31 -04002927 }),
2928 },
2929 })
2930}
2931
2932func TestCcLibraryWithNonAdjacentAidlFilegroup(t *testing.T) {
2933 runCcLibraryTestCase(t, Bp2buildTestCase{
2934 Description: "cc_library with non aidl filegroup",
2935 ModuleTypeUnderTest: "cc_library",
2936 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2937 Filesystem: map[string]string{
2938 "path/to/A/Android.bp": `
2939filegroup {
Vinh Tranfde57eb2022-08-29 17:46:58 -04002940 name: "A_aidl",
2941 srcs: ["aidl/A.aidl"],
2942 path: "aidl",
Vinh Tran9f6796a2022-08-16 13:10:31 -04002943}`,
2944 },
2945 Blueprint: `
2946cc_library {
Vinh Tranfde57eb2022-08-29 17:46:58 -04002947 name: "foo",
2948 srcs: [
2949 ":A_aidl",
2950 ],
Vinh Tran9f6796a2022-08-16 13:10:31 -04002951}`,
2952 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002953 MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04002954 "deps": `["//path/to/A:A_aidl"]`,
2955 }),
Alixe06d75b2022-08-31 18:28:19 +00002956 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Vinh Tranfde57eb2022-08-29 17:46:58 -04002957 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
2958 "local_includes": `["."]`,
2959 }),
2960 // TODO(b/239311679) Add implementation_whole_archive_deps to cc_library_shared
2961 // for bp2build to be fully correct. This fallback is affecting proto as well.
2962 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
2963 "local_includes": `["."]`,
2964 }),
2965 },
2966 })
2967}
2968
2969func TestCcLibraryWithExportAidlHeaders(t *testing.T) {
2970 runCcLibraryTestCase(t, Bp2buildTestCase{
2971 Description: "cc_library with export aidl headers",
2972 ModuleTypeUnderTest: "cc_library",
2973 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2974 Blueprint: `
2975cc_library {
2976 name: "foo",
2977 srcs: [
2978 "Foo.aidl",
2979 ],
2980 aidl: {
2981 export_aidl_headers: true,
2982 }
2983}`,
2984 ExpectedBazelTargets: []string{
2985 MakeBazelTarget("aidl_library", "foo_aidl_library", AttrNameToString{
2986 "srcs": `["Foo.aidl"]`,
2987 }),
2988 MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{
2989 "deps": `[":foo_aidl_library"]`,
2990 }),
2991 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04002992 "whole_archive_deps": `[":foo_cc_aidl_library"]`,
2993 "local_includes": `["."]`,
2994 }),
Alixe06d75b2022-08-31 18:28:19 +00002995 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04002996 "whole_archive_deps": `[":foo_cc_aidl_library"]`,
2997 "local_includes": `["."]`,
2998 }),
2999 },
3000 })
3001}