Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 1 | // Copyright 2021 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package bp2build |
| 16 | |
| 17 | import ( |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 18 | "fmt" |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 1c92aef | 2021-08-23 16:10:00 +0000 | [diff] [blame] | 19 | "testing" |
| 20 | |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 21 | "android/soong/android" |
| 22 | "android/soong/cc" |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 23 | ) |
| 24 | |
| 25 | const ( |
| 26 | // See cc/testing.go for more context |
| 27 | soongCcLibraryPreamble = ` |
| 28 | cc_defaults { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 29 | name: "linux_bionic_supported", |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 30 | }` |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 31 | |
| 32 | soongCcProtoLibraries = ` |
| 33 | cc_library { |
| 34 | name: "libprotobuf-cpp-lite", |
| 35 | bazel_module: { bp2build_available: false }, |
| 36 | } |
| 37 | |
| 38 | cc_library { |
| 39 | name: "libprotobuf-cpp-full", |
| 40 | bazel_module: { bp2build_available: false }, |
| 41 | }` |
| 42 | |
| 43 | soongCcProtoPreamble = soongCcLibraryPreamble + soongCcProtoLibraries |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 44 | ) |
| 45 | |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 46 | func runCcLibraryTestCase(t *testing.T, tc bp2buildTestCase) { |
Liz Kammer | e4982e8 | 2021-05-25 10:39:35 -0400 | [diff] [blame] | 47 | t.Helper() |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 48 | runBp2BuildTestCase(t, registerCcLibraryModuleTypes, tc) |
| 49 | } |
| 50 | |
| 51 | func registerCcLibraryModuleTypes(ctx android.RegistrationContext) { |
| 52 | cc.RegisterCCBuildComponents(ctx) |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 53 | ctx.RegisterModuleType("filegroup", android.FileGroupFactory) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 54 | ctx.RegisterModuleType("cc_library_static", cc.LibraryStaticFactory) |
Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 55 | ctx.RegisterModuleType("cc_prebuilt_library_static", cc.PrebuiltStaticLibraryFactory) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 56 | ctx.RegisterModuleType("cc_library_headers", cc.LibraryHeaderFactory) |
| 57 | } |
| 58 | |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 59 | func TestCcLibrarySimple(t *testing.T) { |
| 60 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 61 | description: "cc_library - simple example", |
| 62 | moduleTypeUnderTest: "cc_library", |
| 63 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 64 | filesystem: map[string]string{ |
| 65 | "android.cpp": "", |
Liz Kammer | 01a16e8 | 2021-07-16 16:33:47 -0400 | [diff] [blame] | 66 | "bionic.cpp": "", |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 67 | "darwin.cpp": "", |
| 68 | // Refer to cc.headerExts for the supported header extensions in Soong. |
| 69 | "header.h": "", |
| 70 | "header.hh": "", |
| 71 | "header.hpp": "", |
| 72 | "header.hxx": "", |
| 73 | "header.h++": "", |
| 74 | "header.inl": "", |
| 75 | "header.inc": "", |
| 76 | "header.ipp": "", |
| 77 | "header.h.generic": "", |
| 78 | "impl.cpp": "", |
| 79 | "linux.cpp": "", |
| 80 | "x86.cpp": "", |
| 81 | "x86_64.cpp": "", |
| 82 | "foo-dir/a.h": "", |
| 83 | }, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 84 | blueprint: soongCcLibraryPreamble + |
| 85 | simpleModuleDoNotConvertBp2build("cc_library_headers", "some-headers") + ` |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 86 | cc_library { |
| 87 | name: "foo-lib", |
| 88 | srcs: ["impl.cpp"], |
| 89 | cflags: ["-Wall"], |
| 90 | header_libs: ["some-headers"], |
| 91 | export_include_dirs: ["foo-dir"], |
| 92 | ldflags: ["-Wl,--exclude-libs=bar.a"], |
| 93 | arch: { |
| 94 | x86: { |
| 95 | ldflags: ["-Wl,--exclude-libs=baz.a"], |
| 96 | srcs: ["x86.cpp"], |
| 97 | }, |
| 98 | x86_64: { |
| 99 | ldflags: ["-Wl,--exclude-libs=qux.a"], |
| 100 | srcs: ["x86_64.cpp"], |
| 101 | }, |
| 102 | }, |
| 103 | target: { |
| 104 | android: { |
| 105 | srcs: ["android.cpp"], |
| 106 | }, |
| 107 | linux_glibc: { |
| 108 | srcs: ["linux.cpp"], |
| 109 | }, |
| 110 | darwin: { |
| 111 | srcs: ["darwin.cpp"], |
| 112 | }, |
Liz Kammer | 01a16e8 | 2021-07-16 16:33:47 -0400 | [diff] [blame] | 113 | bionic: { |
| 114 | srcs: ["bionic.cpp"] |
| 115 | }, |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 116 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 117 | include_build_directory: false, |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 118 | } |
| 119 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 120 | expectedBazelTargets: makeCcLibraryTargets("foo-lib", attrNameToString{ |
| 121 | "copts": `["-Wall"]`, |
| 122 | "export_includes": `["foo-dir"]`, |
| 123 | "implementation_deps": `[":some-headers"]`, |
| 124 | "linkopts": `["-Wl,--exclude-libs=bar.a"] + select({ |
Jingwen Chen | ed9c17d | 2021-04-13 07:14:55 +0000 | [diff] [blame] | 125 | "//build/bazel/platforms/arch:x86": ["-Wl,--exclude-libs=baz.a"], |
| 126 | "//build/bazel/platforms/arch:x86_64": ["-Wl,--exclude-libs=qux.a"], |
| 127 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 128 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 129 | "srcs": `["impl.cpp"] + select({ |
Jingwen Chen | b4628eb | 2021-04-08 14:40:57 +0000 | [diff] [blame] | 130 | "//build/bazel/platforms/arch:x86": ["x86.cpp"], |
| 131 | "//build/bazel/platforms/arch:x86_64": ["x86_64.cpp"], |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 132 | "//conditions:default": [], |
| 133 | }) + select({ |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 134 | "//build/bazel/platforms/os:android": [ |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 135 | "bionic.cpp", |
Liz Kammer | fdd72e6 | 2021-10-11 15:41:03 -0400 | [diff] [blame] | 136 | "android.cpp", |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 137 | ], |
Jingwen Chen | b4628eb | 2021-04-08 14:40:57 +0000 | [diff] [blame] | 138 | "//build/bazel/platforms/os:darwin": ["darwin.cpp"], |
| 139 | "//build/bazel/platforms/os:linux": ["linux.cpp"], |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 140 | "//build/bazel/platforms/os:linux_bionic": ["bionic.cpp"], |
Liz Kammer | 01a16e8 | 2021-07-16 16:33:47 -0400 | [diff] [blame] | 141 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 142 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 143 | }), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 144 | }) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 145 | } |
| 146 | |
| 147 | func TestCcLibraryTrimmedLdAndroid(t *testing.T) { |
| 148 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 149 | description: "cc_library - trimmed example of //bionic/linker:ld-android", |
| 150 | moduleTypeUnderTest: "cc_library", |
| 151 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 152 | filesystem: map[string]string{ |
| 153 | "ld-android.cpp": "", |
| 154 | "linked_list.h": "", |
| 155 | "linker.h": "", |
| 156 | "linker_block_allocator.h": "", |
| 157 | "linker_cfi.h": "", |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 158 | }, |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 159 | blueprint: soongCcLibraryPreamble + |
| 160 | simpleModuleDoNotConvertBp2build("cc_library_headers", "libc_headers") + ` |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 161 | cc_library { |
| 162 | name: "fake-ld-android", |
| 163 | srcs: ["ld_android.cpp"], |
| 164 | cflags: [ |
| 165 | "-Wall", |
| 166 | "-Wextra", |
| 167 | "-Wunused", |
| 168 | "-Werror", |
| 169 | ], |
| 170 | header_libs: ["libc_headers"], |
| 171 | ldflags: [ |
| 172 | "-Wl,--exclude-libs=libgcc.a", |
| 173 | "-Wl,--exclude-libs=libgcc_stripped.a", |
| 174 | "-Wl,--exclude-libs=libclang_rt.builtins-arm-android.a", |
| 175 | "-Wl,--exclude-libs=libclang_rt.builtins-aarch64-android.a", |
| 176 | "-Wl,--exclude-libs=libclang_rt.builtins-i686-android.a", |
| 177 | "-Wl,--exclude-libs=libclang_rt.builtins-x86_64-android.a", |
| 178 | ], |
| 179 | arch: { |
| 180 | x86: { |
| 181 | ldflags: ["-Wl,--exclude-libs=libgcc_eh.a"], |
| 182 | }, |
| 183 | x86_64: { |
| 184 | ldflags: ["-Wl,--exclude-libs=libgcc_eh.a"], |
| 185 | }, |
| 186 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 187 | include_build_directory: false, |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 188 | } |
| 189 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 190 | expectedBazelTargets: makeCcLibraryTargets("fake-ld-android", attrNameToString{ |
| 191 | "srcs": `["ld_android.cpp"]`, |
| 192 | "copts": `[ |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 193 | "-Wall", |
| 194 | "-Wextra", |
| 195 | "-Wunused", |
| 196 | "-Werror", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 197 | ]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 198 | "implementation_deps": `[":libc_headers"]`, |
| 199 | "linkopts": `[ |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 200 | "-Wl,--exclude-libs=libgcc.a", |
| 201 | "-Wl,--exclude-libs=libgcc_stripped.a", |
| 202 | "-Wl,--exclude-libs=libclang_rt.builtins-arm-android.a", |
| 203 | "-Wl,--exclude-libs=libclang_rt.builtins-aarch64-android.a", |
| 204 | "-Wl,--exclude-libs=libclang_rt.builtins-i686-android.a", |
| 205 | "-Wl,--exclude-libs=libclang_rt.builtins-x86_64-android.a", |
| 206 | ] + select({ |
Jingwen Chen | b4628eb | 2021-04-08 14:40:57 +0000 | [diff] [blame] | 207 | "//build/bazel/platforms/arch:x86": ["-Wl,--exclude-libs=libgcc_eh.a"], |
| 208 | "//build/bazel/platforms/arch:x86_64": ["-Wl,--exclude-libs=libgcc_eh.a"], |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 209 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 210 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 211 | }), |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 212 | }) |
| 213 | } |
| 214 | |
| 215 | func TestCcLibraryExcludeSrcs(t *testing.T) { |
| 216 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 217 | description: "cc_library exclude_srcs - trimmed example of //external/arm-optimized-routines:libarm-optimized-routines-math", |
| 218 | moduleTypeUnderTest: "cc_library", |
| 219 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 220 | dir: "external", |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 221 | filesystem: map[string]string{ |
| 222 | "external/math/cosf.c": "", |
| 223 | "external/math/erf.c": "", |
| 224 | "external/math/erf_data.c": "", |
| 225 | "external/math/erff.c": "", |
| 226 | "external/math/erff_data.c": "", |
| 227 | "external/Android.bp": ` |
Jingwen Chen | 4ecc67d | 2021-04-27 09:47:02 +0000 | [diff] [blame] | 228 | cc_library { |
| 229 | name: "fake-libarm-optimized-routines-math", |
| 230 | exclude_srcs: [ |
| 231 | // Provided by: |
| 232 | // bionic/libm/upstream-freebsd/lib/msun/src/s_erf.c |
| 233 | // bionic/libm/upstream-freebsd/lib/msun/src/s_erff.c |
| 234 | "math/erf.c", |
| 235 | "math/erf_data.c", |
| 236 | "math/erff.c", |
| 237 | "math/erff_data.c", |
| 238 | ], |
| 239 | srcs: [ |
| 240 | "math/*.c", |
| 241 | ], |
| 242 | // arch-specific settings |
| 243 | arch: { |
| 244 | arm64: { |
| 245 | cflags: [ |
| 246 | "-DHAVE_FAST_FMA=1", |
| 247 | ], |
| 248 | }, |
| 249 | }, |
| 250 | bazel_module: { bp2build_available: true }, |
| 251 | } |
| 252 | `, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 253 | }, |
| 254 | blueprint: soongCcLibraryPreamble, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 255 | expectedBazelTargets: makeCcLibraryTargets("fake-libarm-optimized-routines-math", attrNameToString{ |
| 256 | "copts": `select({ |
Jingwen Chen | 4ecc67d | 2021-04-27 09:47:02 +0000 | [diff] [blame] | 257 | "//build/bazel/platforms/arch:arm64": ["-DHAVE_FAST_FMA=1"], |
| 258 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 259 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 260 | "local_includes": `["."]`, |
| 261 | "srcs_c": `["math/cosf.c"]`, |
| 262 | }), |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 263 | }) |
| 264 | } |
| 265 | |
| 266 | func TestCcLibrarySharedStaticProps(t *testing.T) { |
| 267 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 268 | description: "cc_library shared/static props", |
| 269 | moduleTypeUnderTest: "cc_library", |
| 270 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 271 | filesystem: map[string]string{ |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 272 | "both.cpp": "", |
| 273 | "sharedonly.cpp": "", |
| 274 | "staticonly.cpp": "", |
| 275 | }, |
| 276 | blueprint: soongCcLibraryPreamble + ` |
Jingwen Chen | 53681ef | 2021-04-29 08:15:13 +0000 | [diff] [blame] | 277 | cc_library { |
| 278 | name: "a", |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 279 | srcs: ["both.cpp"], |
| 280 | cflags: ["bothflag"], |
| 281 | shared_libs: ["shared_dep_for_both"], |
| 282 | static_libs: ["static_dep_for_both"], |
| 283 | whole_static_libs: ["whole_static_lib_for_both"], |
| 284 | static: { |
| 285 | srcs: ["staticonly.cpp"], |
| 286 | cflags: ["staticflag"], |
| 287 | shared_libs: ["shared_dep_for_static"], |
| 288 | static_libs: ["static_dep_for_static"], |
| 289 | whole_static_libs: ["whole_static_lib_for_static"], |
| 290 | }, |
| 291 | shared: { |
| 292 | srcs: ["sharedonly.cpp"], |
| 293 | cflags: ["sharedflag"], |
| 294 | shared_libs: ["shared_dep_for_shared"], |
| 295 | static_libs: ["static_dep_for_shared"], |
| 296 | whole_static_libs: ["whole_static_lib_for_shared"], |
| 297 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 298 | include_build_directory: false, |
Jingwen Chen | 53681ef | 2021-04-29 08:15:13 +0000 | [diff] [blame] | 299 | } |
| 300 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 301 | cc_library_static { |
| 302 | name: "static_dep_for_shared", |
| 303 | bazel_module: { bp2build_available: false }, |
| 304 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 305 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 306 | cc_library_static { |
| 307 | name: "static_dep_for_static", |
| 308 | bazel_module: { bp2build_available: false }, |
| 309 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 310 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 311 | cc_library_static { |
| 312 | name: "static_dep_for_both", |
| 313 | bazel_module: { bp2build_available: false }, |
| 314 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 315 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 316 | cc_library_static { |
| 317 | name: "whole_static_lib_for_shared", |
| 318 | bazel_module: { bp2build_available: false }, |
| 319 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 320 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 321 | cc_library_static { |
| 322 | name: "whole_static_lib_for_static", |
| 323 | bazel_module: { bp2build_available: false }, |
| 324 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 325 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 326 | cc_library_static { |
| 327 | name: "whole_static_lib_for_both", |
| 328 | bazel_module: { bp2build_available: false }, |
| 329 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 330 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 331 | cc_library { |
| 332 | name: "shared_dep_for_shared", |
| 333 | bazel_module: { bp2build_available: false }, |
| 334 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 335 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 336 | cc_library { |
| 337 | name: "shared_dep_for_static", |
| 338 | bazel_module: { bp2build_available: false }, |
| 339 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 340 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 341 | cc_library { |
| 342 | name: "shared_dep_for_both", |
| 343 | bazel_module: { bp2build_available: false }, |
| 344 | } |
Jingwen Chen | 53681ef | 2021-04-29 08:15:13 +0000 | [diff] [blame] | 345 | `, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 346 | expectedBazelTargets: []string{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 347 | makeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", attrNameToString{ |
| 348 | "copts": `[ |
| 349 | "bothflag", |
| 350 | "staticflag", |
| 351 | ]`, |
| 352 | "implementation_deps": `[ |
| 353 | ":static_dep_for_both", |
| 354 | ":static_dep_for_static", |
| 355 | ]`, |
| 356 | "implementation_dynamic_deps": `[ |
| 357 | ":shared_dep_for_both", |
| 358 | ":shared_dep_for_static", |
| 359 | ]`, |
| 360 | "srcs": `[ |
| 361 | "both.cpp", |
| 362 | "staticonly.cpp", |
| 363 | ]`, |
| 364 | "whole_archive_deps": `[ |
| 365 | ":whole_static_lib_for_both", |
| 366 | ":whole_static_lib_for_static", |
| 367 | ]`}), |
| 368 | makeBazelTarget("cc_library_shared", "a", attrNameToString{ |
| 369 | "copts": `[ |
| 370 | "bothflag", |
| 371 | "sharedflag", |
| 372 | ]`, |
| 373 | "implementation_deps": `[ |
| 374 | ":static_dep_for_both", |
| 375 | ":static_dep_for_shared", |
| 376 | ]`, |
| 377 | "implementation_dynamic_deps": `[ |
| 378 | ":shared_dep_for_both", |
| 379 | ":shared_dep_for_shared", |
| 380 | ]`, |
| 381 | "srcs": `[ |
| 382 | "both.cpp", |
| 383 | "sharedonly.cpp", |
| 384 | ]`, |
| 385 | "whole_archive_deps": `[ |
| 386 | ":whole_static_lib_for_both", |
| 387 | ":whole_static_lib_for_shared", |
| 388 | ]`, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 389 | }), |
| 390 | }, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 391 | }) |
| 392 | } |
| 393 | |
Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 394 | func TestCcLibraryDeps(t *testing.T) { |
| 395 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 396 | description: "cc_library shared/static props", |
| 397 | moduleTypeUnderTest: "cc_library", |
| 398 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 399 | filesystem: map[string]string{ |
| 400 | "both.cpp": "", |
| 401 | "sharedonly.cpp": "", |
| 402 | "staticonly.cpp": "", |
| 403 | }, |
| 404 | blueprint: soongCcLibraryPreamble + ` |
| 405 | cc_library { |
| 406 | name: "a", |
| 407 | srcs: ["both.cpp"], |
| 408 | cflags: ["bothflag"], |
| 409 | shared_libs: ["implementation_shared_dep_for_both", "shared_dep_for_both"], |
| 410 | export_shared_lib_headers: ["shared_dep_for_both"], |
| 411 | static_libs: ["implementation_static_dep_for_both", "static_dep_for_both"], |
| 412 | export_static_lib_headers: ["static_dep_for_both", "whole_static_dep_for_both"], |
| 413 | whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_both", "whole_static_dep_for_both"], |
| 414 | static: { |
| 415 | srcs: ["staticonly.cpp"], |
| 416 | cflags: ["staticflag"], |
| 417 | shared_libs: ["implementation_shared_dep_for_static", "shared_dep_for_static"], |
| 418 | export_shared_lib_headers: ["shared_dep_for_static"], |
| 419 | static_libs: ["implementation_static_dep_for_static", "static_dep_for_static"], |
| 420 | export_static_lib_headers: ["static_dep_for_static", "whole_static_dep_for_static"], |
| 421 | whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_static", "whole_static_dep_for_static"], |
| 422 | }, |
| 423 | shared: { |
| 424 | srcs: ["sharedonly.cpp"], |
| 425 | cflags: ["sharedflag"], |
| 426 | shared_libs: ["implementation_shared_dep_for_shared", "shared_dep_for_shared"], |
| 427 | export_shared_lib_headers: ["shared_dep_for_shared"], |
| 428 | static_libs: ["implementation_static_dep_for_shared", "static_dep_for_shared"], |
| 429 | export_static_lib_headers: ["static_dep_for_shared", "whole_static_dep_for_shared"], |
| 430 | whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_shared", "whole_static_dep_for_shared"], |
| 431 | }, |
| 432 | include_build_directory: false, |
| 433 | } |
| 434 | ` + simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_shared") + |
| 435 | simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_shared") + |
| 436 | simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_static") + |
| 437 | simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_static") + |
| 438 | simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_both") + |
| 439 | simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_both") + |
| 440 | simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_shared") + |
| 441 | simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_shared") + |
| 442 | simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_static") + |
| 443 | simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_static") + |
| 444 | simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_both") + |
| 445 | simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_both") + |
| 446 | simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_shared") + |
| 447 | simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_shared") + |
| 448 | simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_static") + |
| 449 | simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_static") + |
| 450 | simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_both") + |
| 451 | simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_both"), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 452 | expectedBazelTargets: []string{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 453 | makeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", attrNameToString{ |
| 454 | "copts": `[ |
| 455 | "bothflag", |
| 456 | "staticflag", |
| 457 | ]`, |
| 458 | "deps": `[ |
| 459 | ":static_dep_for_both", |
| 460 | ":static_dep_for_static", |
| 461 | ]`, |
| 462 | "dynamic_deps": `[ |
| 463 | ":shared_dep_for_both", |
| 464 | ":shared_dep_for_static", |
| 465 | ]`, |
| 466 | "implementation_deps": `[ |
| 467 | ":implementation_static_dep_for_both", |
| 468 | ":implementation_static_dep_for_static", |
| 469 | ]`, |
| 470 | "implementation_dynamic_deps": `[ |
| 471 | ":implementation_shared_dep_for_both", |
| 472 | ":implementation_shared_dep_for_static", |
| 473 | ]`, |
| 474 | "srcs": `[ |
| 475 | "both.cpp", |
| 476 | "staticonly.cpp", |
| 477 | ]`, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 478 | "whole_archive_deps": `[ |
Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 479 | ":not_explicitly_exported_whole_static_dep_for_both", |
| 480 | ":whole_static_dep_for_both", |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 481 | ":not_explicitly_exported_whole_static_dep_for_static", |
| 482 | ":whole_static_dep_for_static", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 483 | ]`, |
| 484 | }), |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 485 | makeBazelTarget("cc_library_shared", "a", attrNameToString{ |
| 486 | "copts": `[ |
| 487 | "bothflag", |
| 488 | "sharedflag", |
| 489 | ]`, |
| 490 | "deps": `[ |
| 491 | ":static_dep_for_both", |
| 492 | ":static_dep_for_shared", |
| 493 | ]`, |
| 494 | "dynamic_deps": `[ |
| 495 | ":shared_dep_for_both", |
| 496 | ":shared_dep_for_shared", |
| 497 | ]`, |
| 498 | "implementation_deps": `[ |
| 499 | ":implementation_static_dep_for_both", |
| 500 | ":implementation_static_dep_for_shared", |
| 501 | ]`, |
| 502 | "implementation_dynamic_deps": `[ |
| 503 | ":implementation_shared_dep_for_both", |
| 504 | ":implementation_shared_dep_for_shared", |
| 505 | ]`, |
| 506 | "srcs": `[ |
| 507 | "both.cpp", |
| 508 | "sharedonly.cpp", |
| 509 | ]`, |
| 510 | "whole_archive_deps": `[ |
| 511 | ":not_explicitly_exported_whole_static_dep_for_both", |
| 512 | ":whole_static_dep_for_both", |
| 513 | ":not_explicitly_exported_whole_static_dep_for_shared", |
| 514 | ":whole_static_dep_for_shared", |
| 515 | ]`, |
| 516 | })}, |
| 517 | }, |
| 518 | ) |
Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 519 | } |
| 520 | |
Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 521 | func TestCcLibraryWholeStaticLibsAlwaysLink(t *testing.T) { |
| 522 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 523 | moduleTypeUnderTest: "cc_library", |
| 524 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 525 | dir: "foo/bar", |
Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 526 | filesystem: map[string]string{ |
| 527 | "foo/bar/Android.bp": ` |
| 528 | cc_library { |
| 529 | name: "a", |
| 530 | whole_static_libs: ["whole_static_lib_for_both"], |
| 531 | static: { |
| 532 | whole_static_libs: ["whole_static_lib_for_static"], |
| 533 | }, |
| 534 | shared: { |
| 535 | whole_static_libs: ["whole_static_lib_for_shared"], |
| 536 | }, |
| 537 | bazel_module: { bp2build_available: true }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 538 | include_build_directory: false, |
Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 539 | } |
| 540 | |
| 541 | cc_prebuilt_library_static { name: "whole_static_lib_for_shared" } |
| 542 | |
| 543 | cc_prebuilt_library_static { name: "whole_static_lib_for_static" } |
| 544 | |
| 545 | cc_prebuilt_library_static { name: "whole_static_lib_for_both" } |
| 546 | `, |
| 547 | }, |
| 548 | blueprint: soongCcLibraryPreamble, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 549 | expectedBazelTargets: []string{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 550 | makeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", attrNameToString{ |
| 551 | "whole_archive_deps": `[ |
| 552 | ":whole_static_lib_for_both_alwayslink", |
| 553 | ":whole_static_lib_for_static_alwayslink", |
| 554 | ]`, |
| 555 | }), |
| 556 | makeBazelTarget("cc_library_shared", "a", attrNameToString{ |
| 557 | "whole_archive_deps": `[ |
| 558 | ":whole_static_lib_for_both_alwayslink", |
| 559 | ":whole_static_lib_for_shared_alwayslink", |
| 560 | ]`, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 561 | }), |
| 562 | }, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 563 | }, |
| 564 | ) |
Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 565 | } |
| 566 | |
Jingwen Chen | bcf5304 | 2021-05-26 04:42:42 +0000 | [diff] [blame] | 567 | func TestCcLibrarySharedStaticPropsInArch(t *testing.T) { |
| 568 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 569 | description: "cc_library shared/static props in arch", |
| 570 | moduleTypeUnderTest: "cc_library", |
| 571 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 572 | dir: "foo/bar", |
Jingwen Chen | bcf5304 | 2021-05-26 04:42:42 +0000 | [diff] [blame] | 573 | filesystem: map[string]string{ |
| 574 | "foo/bar/arm.cpp": "", |
| 575 | "foo/bar/x86.cpp": "", |
| 576 | "foo/bar/sharedonly.cpp": "", |
| 577 | "foo/bar/staticonly.cpp": "", |
| 578 | "foo/bar/Android.bp": ` |
| 579 | cc_library { |
| 580 | name: "a", |
| 581 | arch: { |
| 582 | arm: { |
| 583 | shared: { |
| 584 | srcs: ["arm_shared.cpp"], |
| 585 | cflags: ["-DARM_SHARED"], |
| 586 | static_libs: ["arm_static_dep_for_shared"], |
| 587 | whole_static_libs: ["arm_whole_static_dep_for_shared"], |
| 588 | shared_libs: ["arm_shared_dep_for_shared"], |
| 589 | }, |
| 590 | }, |
| 591 | x86: { |
| 592 | static: { |
| 593 | srcs: ["x86_static.cpp"], |
| 594 | cflags: ["-DX86_STATIC"], |
| 595 | static_libs: ["x86_dep_for_static"], |
| 596 | }, |
| 597 | }, |
| 598 | }, |
| 599 | target: { |
| 600 | android: { |
| 601 | shared: { |
| 602 | srcs: ["android_shared.cpp"], |
| 603 | cflags: ["-DANDROID_SHARED"], |
| 604 | static_libs: ["android_dep_for_shared"], |
| 605 | }, |
| 606 | }, |
| 607 | android_arm: { |
| 608 | shared: { |
| 609 | cflags: ["-DANDROID_ARM_SHARED"], |
| 610 | }, |
| 611 | }, |
| 612 | }, |
| 613 | srcs: ["both.cpp"], |
| 614 | cflags: ["bothflag"], |
| 615 | static_libs: ["static_dep_for_both"], |
| 616 | static: { |
| 617 | srcs: ["staticonly.cpp"], |
| 618 | cflags: ["staticflag"], |
| 619 | static_libs: ["static_dep_for_static"], |
| 620 | }, |
| 621 | shared: { |
| 622 | srcs: ["sharedonly.cpp"], |
| 623 | cflags: ["sharedflag"], |
| 624 | static_libs: ["static_dep_for_shared"], |
| 625 | }, |
| 626 | bazel_module: { bp2build_available: true }, |
| 627 | } |
| 628 | |
| 629 | cc_library_static { name: "static_dep_for_shared" } |
| 630 | cc_library_static { name: "static_dep_for_static" } |
| 631 | cc_library_static { name: "static_dep_for_both" } |
| 632 | |
| 633 | cc_library_static { name: "arm_static_dep_for_shared" } |
| 634 | cc_library_static { name: "arm_whole_static_dep_for_shared" } |
| 635 | cc_library_static { name: "arm_shared_dep_for_shared" } |
| 636 | |
| 637 | cc_library_static { name: "x86_dep_for_static" } |
| 638 | |
| 639 | cc_library_static { name: "android_dep_for_shared" } |
| 640 | `, |
| 641 | }, |
| 642 | blueprint: soongCcLibraryPreamble, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 643 | expectedBazelTargets: []string{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 644 | makeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", attrNameToString{ |
| 645 | "copts": `[ |
| 646 | "bothflag", |
| 647 | "staticflag", |
| 648 | ] + select({ |
| 649 | "//build/bazel/platforms/arch:x86": ["-DX86_STATIC"], |
| 650 | "//conditions:default": [], |
| 651 | })`, |
| 652 | "implementation_deps": `[ |
| 653 | ":static_dep_for_both", |
| 654 | ":static_dep_for_static", |
| 655 | ] + select({ |
| 656 | "//build/bazel/platforms/arch:x86": [":x86_dep_for_static"], |
| 657 | "//conditions:default": [], |
| 658 | })`, |
| 659 | "local_includes": `["."]`, |
| 660 | "srcs": `[ |
| 661 | "both.cpp", |
| 662 | "staticonly.cpp", |
| 663 | ] + select({ |
| 664 | "//build/bazel/platforms/arch:x86": ["x86_static.cpp"], |
| 665 | "//conditions:default": [], |
| 666 | })`, |
| 667 | }), |
| 668 | makeBazelTarget("cc_library_shared", "a", attrNameToString{ |
| 669 | "copts": `[ |
| 670 | "bothflag", |
| 671 | "sharedflag", |
| 672 | ] + select({ |
| 673 | "//build/bazel/platforms/arch:arm": ["-DARM_SHARED"], |
| 674 | "//conditions:default": [], |
| 675 | }) + select({ |
| 676 | "//build/bazel/platforms/os:android": ["-DANDROID_SHARED"], |
| 677 | "//conditions:default": [], |
| 678 | }) + select({ |
| 679 | "//build/bazel/platforms/os_arch:android_arm": ["-DANDROID_ARM_SHARED"], |
| 680 | "//conditions:default": [], |
| 681 | })`, |
| 682 | "implementation_deps": `[ |
| 683 | ":static_dep_for_both", |
| 684 | ":static_dep_for_shared", |
| 685 | ] + select({ |
| 686 | "//build/bazel/platforms/arch:arm": [":arm_static_dep_for_shared"], |
| 687 | "//conditions:default": [], |
| 688 | }) + select({ |
| 689 | "//build/bazel/platforms/os:android": [":android_dep_for_shared"], |
| 690 | "//conditions:default": [], |
| 691 | })`, |
| 692 | "implementation_dynamic_deps": `select({ |
| 693 | "//build/bazel/platforms/arch:arm": [":arm_shared_dep_for_shared"], |
| 694 | "//conditions:default": [], |
| 695 | })`, |
| 696 | "local_includes": `["."]`, |
| 697 | "srcs": `[ |
| 698 | "both.cpp", |
| 699 | "sharedonly.cpp", |
| 700 | ] + select({ |
| 701 | "//build/bazel/platforms/arch:arm": ["arm_shared.cpp"], |
| 702 | "//conditions:default": [], |
| 703 | }) + select({ |
| 704 | "//build/bazel/platforms/os:android": ["android_shared.cpp"], |
| 705 | "//conditions:default": [], |
| 706 | })`, |
| 707 | "whole_archive_deps": `select({ |
| 708 | "//build/bazel/platforms/arch:arm": [":arm_whole_static_dep_for_shared"], |
| 709 | "//conditions:default": [], |
| 710 | })`, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 711 | }), |
| 712 | }, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 713 | }, |
| 714 | ) |
Jingwen Chen | bcf5304 | 2021-05-26 04:42:42 +0000 | [diff] [blame] | 715 | } |
| 716 | |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 717 | func TestCcLibrarySharedStaticPropsWithMixedSources(t *testing.T) { |
| 718 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 719 | description: "cc_library shared/static props with c/cpp/s mixed sources", |
| 720 | moduleTypeUnderTest: "cc_library", |
| 721 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 722 | dir: "foo/bar", |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 723 | filesystem: map[string]string{ |
| 724 | "foo/bar/both_source.cpp": "", |
| 725 | "foo/bar/both_source.cc": "", |
| 726 | "foo/bar/both_source.c": "", |
| 727 | "foo/bar/both_source.s": "", |
| 728 | "foo/bar/both_source.S": "", |
| 729 | "foo/bar/shared_source.cpp": "", |
| 730 | "foo/bar/shared_source.cc": "", |
| 731 | "foo/bar/shared_source.c": "", |
| 732 | "foo/bar/shared_source.s": "", |
| 733 | "foo/bar/shared_source.S": "", |
| 734 | "foo/bar/static_source.cpp": "", |
| 735 | "foo/bar/static_source.cc": "", |
| 736 | "foo/bar/static_source.c": "", |
| 737 | "foo/bar/static_source.s": "", |
| 738 | "foo/bar/static_source.S": "", |
| 739 | "foo/bar/Android.bp": ` |
| 740 | cc_library { |
| 741 | name: "a", |
| 742 | srcs: [ |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 743 | "both_source.cpp", |
| 744 | "both_source.cc", |
| 745 | "both_source.c", |
| 746 | "both_source.s", |
| 747 | "both_source.S", |
Liz Kammer | 57e2e7a | 2021-09-20 12:55:02 -0400 | [diff] [blame] | 748 | ":both_filegroup", |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 749 | ], |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 750 | static: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 751 | srcs: [ |
| 752 | "static_source.cpp", |
| 753 | "static_source.cc", |
| 754 | "static_source.c", |
| 755 | "static_source.s", |
| 756 | "static_source.S", |
| 757 | ":static_filegroup", |
| 758 | ], |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 759 | }, |
| 760 | shared: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 761 | srcs: [ |
| 762 | "shared_source.cpp", |
| 763 | "shared_source.cc", |
| 764 | "shared_source.c", |
| 765 | "shared_source.s", |
| 766 | "shared_source.S", |
| 767 | ":shared_filegroup", |
| 768 | ], |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 769 | }, |
| 770 | bazel_module: { bp2build_available: true }, |
| 771 | } |
| 772 | |
| 773 | filegroup { |
| 774 | name: "both_filegroup", |
| 775 | srcs: [ |
| 776 | // Not relevant, handled by filegroup macro |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 777 | ], |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 778 | } |
| 779 | |
| 780 | filegroup { |
| 781 | name: "shared_filegroup", |
| 782 | srcs: [ |
| 783 | // Not relevant, handled by filegroup macro |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 784 | ], |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 785 | } |
| 786 | |
| 787 | filegroup { |
| 788 | name: "static_filegroup", |
| 789 | srcs: [ |
| 790 | // Not relevant, handled by filegroup macro |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 791 | ], |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 792 | } |
| 793 | `, |
| 794 | }, |
| 795 | blueprint: soongCcLibraryPreamble, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 796 | expectedBazelTargets: []string{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 797 | makeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", attrNameToString{ |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 798 | "local_includes": `["."]`, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 799 | "srcs": `[ |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 800 | "both_source.cpp", |
Liz Kammer | 57e2e7a | 2021-09-20 12:55:02 -0400 | [diff] [blame] | 801 | "both_source.cc", |
| 802 | ":both_filegroup_cpp_srcs", |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 803 | "static_source.cpp", |
| 804 | "static_source.cc", |
| 805 | ":static_filegroup_cpp_srcs", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 806 | ]`, |
| 807 | "srcs_as": `[ |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 808 | "both_source.s", |
| 809 | "both_source.S", |
| 810 | ":both_filegroup_as_srcs", |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 811 | "static_source.s", |
| 812 | "static_source.S", |
| 813 | ":static_filegroup_as_srcs", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 814 | ]`, |
| 815 | "srcs_c": `[ |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 816 | "both_source.c", |
| 817 | ":both_filegroup_c_srcs", |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 818 | "static_source.c", |
| 819 | ":static_filegroup_c_srcs", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 820 | ]`, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 821 | }), |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 822 | makeBazelTarget("cc_library_shared", "a", attrNameToString{ |
| 823 | "local_includes": `["."]`, |
| 824 | "srcs": `[ |
| 825 | "both_source.cpp", |
| 826 | "both_source.cc", |
| 827 | ":both_filegroup_cpp_srcs", |
| 828 | "shared_source.cpp", |
| 829 | "shared_source.cc", |
| 830 | ":shared_filegroup_cpp_srcs", |
| 831 | ]`, |
| 832 | "srcs_as": `[ |
| 833 | "both_source.s", |
| 834 | "both_source.S", |
| 835 | ":both_filegroup_as_srcs", |
| 836 | "shared_source.s", |
| 837 | "shared_source.S", |
| 838 | ":shared_filegroup_as_srcs", |
| 839 | ]`, |
| 840 | "srcs_c": `[ |
| 841 | "both_source.c", |
| 842 | ":both_filegroup_c_srcs", |
| 843 | "shared_source.c", |
| 844 | ":shared_filegroup_c_srcs", |
| 845 | ]`, |
| 846 | })}}) |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 847 | } |
| 848 | |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 849 | func TestCcLibraryNonConfiguredVersionScript(t *testing.T) { |
| 850 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 851 | description: "cc_library non-configured version script", |
| 852 | moduleTypeUnderTest: "cc_library", |
| 853 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 854 | dir: "foo/bar", |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 855 | filesystem: map[string]string{ |
| 856 | "foo/bar/Android.bp": ` |
Lukacs T. Berki | 1353e59 | 2021-04-30 15:35:09 +0200 | [diff] [blame] | 857 | cc_library { |
| 858 | name: "a", |
| 859 | srcs: ["a.cpp"], |
| 860 | version_script: "v.map", |
| 861 | bazel_module: { bp2build_available: true }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 862 | include_build_directory: false, |
Lukacs T. Berki | 1353e59 | 2021-04-30 15:35:09 +0200 | [diff] [blame] | 863 | } |
| 864 | `, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 865 | }, |
| 866 | blueprint: soongCcLibraryPreamble, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 867 | expectedBazelTargets: makeCcLibraryTargets("a", attrNameToString{ |
| 868 | "additional_linker_inputs": `["v.map"]`, |
| 869 | "linkopts": `["-Wl,--version-script,$(location v.map)"]`, |
| 870 | "srcs": `["a.cpp"]`, |
| 871 | }), |
| 872 | }, |
| 873 | ) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 874 | } |
| 875 | |
| 876 | func TestCcLibraryConfiguredVersionScript(t *testing.T) { |
| 877 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 878 | description: "cc_library configured version script", |
| 879 | moduleTypeUnderTest: "cc_library", |
| 880 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 881 | dir: "foo/bar", |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 882 | filesystem: map[string]string{ |
| 883 | "foo/bar/Android.bp": ` |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 884 | cc_library { |
| 885 | name: "a", |
| 886 | srcs: ["a.cpp"], |
| 887 | arch: { |
| 888 | arm: { |
| 889 | version_script: "arm.map", |
| 890 | }, |
| 891 | arm64: { |
| 892 | version_script: "arm64.map", |
| 893 | }, |
| 894 | }, |
Lukacs T. Berki | 56bb083 | 2021-05-12 12:36:45 +0200 | [diff] [blame] | 895 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 896 | bazel_module: { bp2build_available: true }, |
| 897 | include_build_directory: false, |
| 898 | } |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 899 | `, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 900 | }, |
| 901 | blueprint: soongCcLibraryPreamble, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 902 | expectedBazelTargets: makeCcLibraryTargets("a", attrNameToString{ |
| 903 | "additional_linker_inputs": `select({ |
Liz Kammer | d287118 | 2021-10-04 13:54:37 -0400 | [diff] [blame] | 904 | "//build/bazel/platforms/arch:arm": ["arm.map"], |
| 905 | "//build/bazel/platforms/arch:arm64": ["arm64.map"], |
| 906 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 907 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 908 | "linkopts": `select({ |
Liz Kammer | d287118 | 2021-10-04 13:54:37 -0400 | [diff] [blame] | 909 | "//build/bazel/platforms/arch:arm": ["-Wl,--version-script,$(location arm.map)"], |
| 910 | "//build/bazel/platforms/arch:arm64": ["-Wl,--version-script,$(location arm64.map)"], |
| 911 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 912 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 913 | "srcs": `["a.cpp"]`, |
| 914 | }), |
| 915 | }, |
| 916 | ) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 917 | } |
| 918 | |
| 919 | func TestCcLibrarySharedLibs(t *testing.T) { |
| 920 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 921 | description: "cc_library shared_libs", |
| 922 | moduleTypeUnderTest: "cc_library", |
| 923 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 924 | blueprint: soongCcLibraryPreamble + ` |
Rupert Shuttleworth | c50fa8d | 2021-05-06 02:40:33 -0400 | [diff] [blame] | 925 | cc_library { |
| 926 | name: "mylib", |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 927 | bazel_module: { bp2build_available: false }, |
Rupert Shuttleworth | c50fa8d | 2021-05-06 02:40:33 -0400 | [diff] [blame] | 928 | } |
| 929 | |
| 930 | cc_library { |
| 931 | name: "a", |
| 932 | shared_libs: ["mylib",], |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 933 | include_build_directory: false, |
Rupert Shuttleworth | c50fa8d | 2021-05-06 02:40:33 -0400 | [diff] [blame] | 934 | } |
| 935 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 936 | expectedBazelTargets: makeCcLibraryTargets("a", attrNameToString{ |
| 937 | "implementation_dynamic_deps": `[":mylib"]`, |
| 938 | }), |
| 939 | }, |
| 940 | ) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 941 | } |
| 942 | |
Liz Kammer | 0eae52e | 2021-10-06 10:32:26 -0400 | [diff] [blame] | 943 | func TestCcLibraryFeatures(t *testing.T) { |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 944 | expected_targets := []string{} |
| 945 | expected_targets = append(expected_targets, makeCcLibraryTargets("a", attrNameToString{ |
| 946 | "features": `[ |
| 947 | "disable_pack_relocations", |
| 948 | "-no_undefined_symbols", |
| 949 | ]`, |
| 950 | "srcs": `["a.cpp"]`, |
| 951 | })...) |
| 952 | expected_targets = append(expected_targets, makeCcLibraryTargets("b", attrNameToString{ |
| 953 | "features": `select({ |
| 954 | "//build/bazel/platforms/arch:x86_64": [ |
| 955 | "disable_pack_relocations", |
| 956 | "-no_undefined_symbols", |
| 957 | ], |
| 958 | "//conditions:default": [], |
| 959 | })`, |
| 960 | "srcs": `["b.cpp"]`, |
| 961 | })...) |
| 962 | expected_targets = append(expected_targets, makeCcLibraryTargets("c", attrNameToString{ |
| 963 | "features": `select({ |
| 964 | "//build/bazel/platforms/os:darwin": [ |
| 965 | "disable_pack_relocations", |
| 966 | "-no_undefined_symbols", |
| 967 | ], |
| 968 | "//conditions:default": [], |
| 969 | })`, |
| 970 | "srcs": `["c.cpp"]`, |
| 971 | })...) |
| 972 | |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 973 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 974 | description: "cc_library pack_relocations test", |
| 975 | moduleTypeUnderTest: "cc_library", |
| 976 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 977 | blueprint: soongCcLibraryPreamble + ` |
Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 978 | cc_library { |
| 979 | name: "a", |
| 980 | srcs: ["a.cpp"], |
| 981 | pack_relocations: false, |
Liz Kammer | 0eae52e | 2021-10-06 10:32:26 -0400 | [diff] [blame] | 982 | allow_undefined_symbols: true, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 983 | include_build_directory: false, |
Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 984 | } |
| 985 | |
| 986 | cc_library { |
| 987 | name: "b", |
| 988 | srcs: ["b.cpp"], |
| 989 | arch: { |
| 990 | x86_64: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 991 | pack_relocations: false, |
Liz Kammer | 0eae52e | 2021-10-06 10:32:26 -0400 | [diff] [blame] | 992 | allow_undefined_symbols: true, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 993 | }, |
Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 994 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 995 | include_build_directory: false, |
Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 996 | } |
| 997 | |
| 998 | cc_library { |
| 999 | name: "c", |
| 1000 | srcs: ["c.cpp"], |
| 1001 | target: { |
| 1002 | darwin: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1003 | pack_relocations: false, |
Liz Kammer | 0eae52e | 2021-10-06 10:32:26 -0400 | [diff] [blame] | 1004 | allow_undefined_symbols: true, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1005 | }, |
Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1006 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1007 | include_build_directory: false, |
Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1008 | }`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1009 | expectedBazelTargets: expected_targets, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 1010 | }) |
| 1011 | } |
| 1012 | |
| 1013 | func TestCcLibrarySpacesInCopts(t *testing.T) { |
| 1014 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1015 | description: "cc_library spaces in copts", |
| 1016 | moduleTypeUnderTest: "cc_library", |
| 1017 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1018 | blueprint: soongCcLibraryPreamble + ` |
Jingwen Chen | 3950cd6 | 2021-05-12 04:33:00 +0000 | [diff] [blame] | 1019 | cc_library { |
| 1020 | name: "a", |
| 1021 | cflags: ["-include header.h",], |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1022 | include_build_directory: false, |
Jingwen Chen | 3950cd6 | 2021-05-12 04:33:00 +0000 | [diff] [blame] | 1023 | } |
| 1024 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1025 | expectedBazelTargets: makeCcLibraryTargets("a", attrNameToString{ |
| 1026 | "copts": `[ |
Jingwen Chen | 3950cd6 | 2021-05-12 04:33:00 +0000 | [diff] [blame] | 1027 | "-include", |
| 1028 | "header.h", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1029 | ]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1030 | }), |
| 1031 | }, |
| 1032 | ) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 1033 | } |
| 1034 | |
| 1035 | func TestCcLibraryCppFlagsGoesIntoCopts(t *testing.T) { |
| 1036 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1037 | description: "cc_library cppflags usage", |
| 1038 | moduleTypeUnderTest: "cc_library", |
| 1039 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1040 | blueprint: soongCcLibraryPreamble + `cc_library { |
Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1041 | name: "a", |
| 1042 | srcs: ["a.cpp"], |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1043 | cflags: ["-Wall"], |
Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1044 | cppflags: [ |
| 1045 | "-fsigned-char", |
| 1046 | "-pedantic", |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1047 | ], |
Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1048 | arch: { |
| 1049 | arm64: { |
| 1050 | cppflags: ["-DARM64=1"], |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1051 | }, |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1052 | }, |
Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1053 | target: { |
| 1054 | android: { |
| 1055 | cppflags: ["-DANDROID=1"], |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1056 | }, |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1057 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1058 | include_build_directory: false, |
Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1059 | } |
| 1060 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1061 | expectedBazelTargets: makeCcLibraryTargets("a", attrNameToString{ |
| 1062 | "copts": `["-Wall"]`, |
| 1063 | "cppflags": `[ |
Chris Parsons | 990c4f4 | 2021-05-25 12:10:58 -0400 | [diff] [blame] | 1064 | "-fsigned-char", |
| 1065 | "-pedantic", |
Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1066 | ] + select({ |
| 1067 | "//build/bazel/platforms/arch:arm64": ["-DARM64=1"], |
| 1068 | "//conditions:default": [], |
| 1069 | }) + select({ |
| 1070 | "//build/bazel/platforms/os:android": ["-DANDROID=1"], |
| 1071 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1072 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1073 | "srcs": `["a.cpp"]`, |
| 1074 | }), |
| 1075 | }, |
| 1076 | ) |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 1077 | } |
Rupert Shuttleworth | 22cd2eb | 2021-05-27 02:15:54 -0400 | [diff] [blame] | 1078 | |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1079 | func TestCcLibraryExcludeLibs(t *testing.T) { |
| 1080 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1081 | moduleTypeUnderTest: "cc_library", |
| 1082 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1083 | filesystem: map[string]string{}, |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1084 | blueprint: soongCcLibraryStaticPreamble + ` |
| 1085 | cc_library { |
| 1086 | name: "foo_static", |
| 1087 | srcs: ["common.c"], |
| 1088 | whole_static_libs: [ |
| 1089 | "arm_whole_static_lib_excludes", |
| 1090 | "malloc_not_svelte_whole_static_lib_excludes" |
| 1091 | ], |
| 1092 | static_libs: [ |
| 1093 | "arm_static_lib_excludes", |
| 1094 | "malloc_not_svelte_static_lib_excludes" |
| 1095 | ], |
| 1096 | shared_libs: [ |
| 1097 | "arm_shared_lib_excludes", |
| 1098 | ], |
| 1099 | arch: { |
| 1100 | arm: { |
| 1101 | exclude_shared_libs: [ |
| 1102 | "arm_shared_lib_excludes", |
| 1103 | ], |
| 1104 | exclude_static_libs: [ |
| 1105 | "arm_static_lib_excludes", |
| 1106 | "arm_whole_static_lib_excludes", |
| 1107 | ], |
| 1108 | }, |
| 1109 | }, |
| 1110 | product_variables: { |
| 1111 | malloc_not_svelte: { |
| 1112 | shared_libs: ["malloc_not_svelte_shared_lib"], |
| 1113 | whole_static_libs: ["malloc_not_svelte_whole_static_lib"], |
| 1114 | exclude_static_libs: [ |
| 1115 | "malloc_not_svelte_static_lib_excludes", |
| 1116 | "malloc_not_svelte_whole_static_lib_excludes", |
| 1117 | ], |
| 1118 | }, |
| 1119 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1120 | include_build_directory: false, |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1121 | } |
| 1122 | |
| 1123 | cc_library { |
| 1124 | name: "arm_whole_static_lib_excludes", |
| 1125 | bazel_module: { bp2build_available: false }, |
| 1126 | } |
| 1127 | |
| 1128 | cc_library { |
| 1129 | name: "malloc_not_svelte_whole_static_lib", |
| 1130 | bazel_module: { bp2build_available: false }, |
| 1131 | } |
| 1132 | |
| 1133 | cc_library { |
| 1134 | name: "malloc_not_svelte_whole_static_lib_excludes", |
| 1135 | bazel_module: { bp2build_available: false }, |
| 1136 | } |
| 1137 | |
| 1138 | cc_library { |
| 1139 | name: "arm_static_lib_excludes", |
| 1140 | bazel_module: { bp2build_available: false }, |
| 1141 | } |
| 1142 | |
| 1143 | cc_library { |
| 1144 | name: "malloc_not_svelte_static_lib_excludes", |
| 1145 | bazel_module: { bp2build_available: false }, |
| 1146 | } |
| 1147 | |
| 1148 | cc_library { |
| 1149 | name: "arm_shared_lib_excludes", |
| 1150 | bazel_module: { bp2build_available: false }, |
| 1151 | } |
| 1152 | |
| 1153 | cc_library { |
| 1154 | name: "malloc_not_svelte_shared_lib", |
| 1155 | bazel_module: { bp2build_available: false }, |
| 1156 | } |
| 1157 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1158 | expectedBazelTargets: makeCcLibraryTargets("foo_static", attrNameToString{ |
| 1159 | "implementation_deps": `select({ |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1160 | "//build/bazel/platforms/arch:arm": [], |
Chris Parsons | 953b356 | 2021-09-20 15:14:39 -0400 | [diff] [blame] | 1161 | "//conditions:default": [":arm_static_lib_excludes_bp2build_cc_library_static"], |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1162 | }) + select({ |
| 1163 | "//build/bazel/product_variables:malloc_not_svelte": [], |
Chris Parsons | 953b356 | 2021-09-20 15:14:39 -0400 | [diff] [blame] | 1164 | "//conditions:default": [":malloc_not_svelte_static_lib_excludes_bp2build_cc_library_static"], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1165 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1166 | "implementation_dynamic_deps": `select({ |
Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 1167 | "//build/bazel/platforms/arch:arm": [], |
| 1168 | "//conditions:default": [":arm_shared_lib_excludes"], |
| 1169 | }) + select({ |
| 1170 | "//build/bazel/product_variables:malloc_not_svelte": [":malloc_not_svelte_shared_lib"], |
| 1171 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1172 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1173 | "srcs_c": `["common.c"]`, |
| 1174 | "whole_archive_deps": `select({ |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1175 | "//build/bazel/platforms/arch:arm": [], |
Chris Parsons | 953b356 | 2021-09-20 15:14:39 -0400 | [diff] [blame] | 1176 | "//conditions:default": [":arm_whole_static_lib_excludes_bp2build_cc_library_static"], |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1177 | }) + select({ |
Chris Parsons | 953b356 | 2021-09-20 15:14:39 -0400 | [diff] [blame] | 1178 | "//build/bazel/product_variables:malloc_not_svelte": [":malloc_not_svelte_whole_static_lib_bp2build_cc_library_static"], |
| 1179 | "//conditions:default": [":malloc_not_svelte_whole_static_lib_excludes_bp2build_cc_library_static"], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1180 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1181 | }), |
| 1182 | }, |
| 1183 | ) |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1184 | } |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1185 | |
| 1186 | func TestCCLibraryNoCrtTrue(t *testing.T) { |
| 1187 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1188 | description: "cc_library - nocrt: true emits attribute", |
| 1189 | moduleTypeUnderTest: "cc_library", |
| 1190 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1191 | filesystem: map[string]string{ |
| 1192 | "impl.cpp": "", |
| 1193 | }, |
| 1194 | blueprint: soongCcLibraryPreamble + ` |
| 1195 | cc_library { |
| 1196 | name: "foo-lib", |
| 1197 | srcs: ["impl.cpp"], |
| 1198 | nocrt: true, |
| 1199 | include_build_directory: false, |
| 1200 | } |
| 1201 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1202 | expectedBazelTargets: makeCcLibraryTargets("foo-lib", attrNameToString{ |
| 1203 | "link_crt": `False`, |
| 1204 | "srcs": `["impl.cpp"]`, |
| 1205 | }), |
| 1206 | }, |
| 1207 | ) |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1208 | } |
| 1209 | |
| 1210 | func TestCCLibraryNoCrtFalse(t *testing.T) { |
| 1211 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1212 | description: "cc_library - nocrt: false - does not emit attribute", |
| 1213 | moduleTypeUnderTest: "cc_library", |
| 1214 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1215 | filesystem: map[string]string{ |
| 1216 | "impl.cpp": "", |
| 1217 | }, |
| 1218 | blueprint: soongCcLibraryPreamble + ` |
| 1219 | cc_library { |
| 1220 | name: "foo-lib", |
| 1221 | srcs: ["impl.cpp"], |
| 1222 | nocrt: false, |
| 1223 | include_build_directory: false, |
| 1224 | } |
| 1225 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1226 | expectedBazelTargets: makeCcLibraryTargets("foo-lib", attrNameToString{ |
| 1227 | "srcs": `["impl.cpp"]`, |
| 1228 | }), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1229 | }) |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1230 | } |
| 1231 | |
| 1232 | func TestCCLibraryNoCrtArchVariant(t *testing.T) { |
| 1233 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1234 | description: "cc_library - nocrt in select", |
| 1235 | moduleTypeUnderTest: "cc_library", |
| 1236 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1237 | filesystem: map[string]string{ |
| 1238 | "impl.cpp": "", |
| 1239 | }, |
| 1240 | blueprint: soongCcLibraryPreamble + ` |
| 1241 | cc_library { |
| 1242 | name: "foo-lib", |
| 1243 | srcs: ["impl.cpp"], |
| 1244 | arch: { |
| 1245 | arm: { |
| 1246 | nocrt: true, |
| 1247 | }, |
| 1248 | x86: { |
| 1249 | nocrt: false, |
| 1250 | }, |
| 1251 | }, |
| 1252 | include_build_directory: false, |
| 1253 | } |
| 1254 | `, |
Liz Kammer | 718eb27 | 2022-01-07 10:53:37 -0500 | [diff] [blame] | 1255 | expectedErr: fmt.Errorf("module \"foo-lib\": nocrt is not supported for arch variants"), |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1256 | }) |
| 1257 | } |
| 1258 | |
| 1259 | func TestCCLibraryNoLibCrtTrue(t *testing.T) { |
| 1260 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1261 | moduleTypeUnderTest: "cc_library", |
| 1262 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1263 | filesystem: map[string]string{ |
| 1264 | "impl.cpp": "", |
| 1265 | }, |
| 1266 | blueprint: soongCcLibraryPreamble + ` |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1267 | cc_library { |
| 1268 | name: "foo-lib", |
| 1269 | srcs: ["impl.cpp"], |
| 1270 | no_libcrt: true, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1271 | include_build_directory: false, |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1272 | } |
| 1273 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1274 | expectedBazelTargets: makeCcLibraryTargets("foo-lib", attrNameToString{ |
| 1275 | "srcs": `["impl.cpp"]`, |
| 1276 | "use_libcrt": `False`, |
| 1277 | }), |
| 1278 | }) |
| 1279 | } |
| 1280 | |
| 1281 | func makeCcLibraryTargets(name string, attrs attrNameToString) []string { |
| 1282 | STATIC_ONLY_ATTRS := map[string]bool{} |
| 1283 | SHARED_ONLY_ATTRS := map[string]bool{ |
| 1284 | "link_crt": true, |
| 1285 | "additional_linker_inputs": true, |
| 1286 | "linkopts": true, |
| 1287 | "strip": true, |
Jingwen Chen | 0ee88a6 | 2022-01-07 14:55:29 +0000 | [diff] [blame] | 1288 | "stubs_symbol_file": true, |
| 1289 | "stubs_versions": true, |
Yu Liu | 75be7b9 | 2022-02-01 09:54:09 -0800 | [diff] [blame] | 1290 | "inject_bssl_hash": true, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1291 | } |
| 1292 | sharedAttrs := attrNameToString{} |
| 1293 | staticAttrs := attrNameToString{} |
| 1294 | for key, val := range attrs { |
| 1295 | if _, staticOnly := STATIC_ONLY_ATTRS[key]; !staticOnly { |
| 1296 | sharedAttrs[key] = val |
| 1297 | } |
| 1298 | if _, sharedOnly := SHARED_ONLY_ATTRS[key]; !sharedOnly { |
| 1299 | staticAttrs[key] = val |
| 1300 | } |
| 1301 | } |
| 1302 | sharedTarget := makeBazelTarget("cc_library_shared", name, sharedAttrs) |
| 1303 | staticTarget := makeBazelTarget("cc_library_static", name+"_bp2build_cc_library_static", staticAttrs) |
| 1304 | |
| 1305 | return []string{staticTarget, sharedTarget} |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1306 | } |
| 1307 | |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1308 | func TestCCLibraryNoLibCrtFalse(t *testing.T) { |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1309 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1310 | moduleTypeUnderTest: "cc_library", |
| 1311 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1312 | filesystem: map[string]string{ |
| 1313 | "impl.cpp": "", |
| 1314 | }, |
| 1315 | blueprint: soongCcLibraryPreamble + ` |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1316 | cc_library { |
| 1317 | name: "foo-lib", |
| 1318 | srcs: ["impl.cpp"], |
| 1319 | no_libcrt: false, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1320 | include_build_directory: false, |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1321 | } |
| 1322 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1323 | expectedBazelTargets: makeCcLibraryTargets("foo-lib", attrNameToString{ |
| 1324 | "srcs": `["impl.cpp"]`, |
| 1325 | "use_libcrt": `True`, |
| 1326 | }), |
| 1327 | }) |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1328 | } |
| 1329 | |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1330 | func TestCCLibraryNoLibCrtArchVariant(t *testing.T) { |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1331 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1332 | moduleTypeUnderTest: "cc_library", |
| 1333 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1334 | filesystem: map[string]string{ |
| 1335 | "impl.cpp": "", |
| 1336 | }, |
| 1337 | blueprint: soongCcLibraryPreamble + ` |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1338 | cc_library { |
| 1339 | name: "foo-lib", |
| 1340 | srcs: ["impl.cpp"], |
| 1341 | arch: { |
| 1342 | arm: { |
| 1343 | no_libcrt: true, |
| 1344 | }, |
| 1345 | x86: { |
| 1346 | no_libcrt: true, |
| 1347 | }, |
| 1348 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1349 | include_build_directory: false, |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1350 | } |
| 1351 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1352 | expectedBazelTargets: makeCcLibraryTargets("foo-lib", attrNameToString{ |
| 1353 | "srcs": `["impl.cpp"]`, |
| 1354 | "use_libcrt": `select({ |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1355 | "//build/bazel/platforms/arch:arm": False, |
| 1356 | "//build/bazel/platforms/arch:x86": False, |
| 1357 | "//conditions:default": None, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1358 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1359 | }), |
| 1360 | }) |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1361 | } |
| 1362 | |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 1363 | func TestCCLibraryNoLibCrtArchAndTargetVariant(t *testing.T) { |
| 1364 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1365 | moduleTypeUnderTest: "cc_library", |
| 1366 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1367 | filesystem: map[string]string{ |
| 1368 | "impl.cpp": "", |
| 1369 | }, |
| 1370 | blueprint: soongCcLibraryPreamble + ` |
| 1371 | cc_library { |
| 1372 | name: "foo-lib", |
| 1373 | srcs: ["impl.cpp"], |
| 1374 | arch: { |
| 1375 | arm: { |
| 1376 | no_libcrt: true, |
| 1377 | }, |
| 1378 | x86: { |
| 1379 | no_libcrt: true, |
| 1380 | }, |
| 1381 | }, |
| 1382 | target: { |
| 1383 | darwin: { |
| 1384 | no_libcrt: true, |
| 1385 | } |
| 1386 | }, |
| 1387 | include_build_directory: false, |
| 1388 | } |
| 1389 | `, |
| 1390 | expectedBazelTargets: makeCcLibraryTargets("foo-lib", attrNameToString{ |
| 1391 | "srcs": `["impl.cpp"]`, |
| 1392 | "use_libcrt": `select({ |
| 1393 | "//build/bazel/platforms/os_arch:android_arm": False, |
| 1394 | "//build/bazel/platforms/os_arch:android_x86": False, |
| 1395 | "//build/bazel/platforms/os_arch:darwin_arm64": False, |
| 1396 | "//build/bazel/platforms/os_arch:darwin_x86_64": False, |
| 1397 | "//build/bazel/platforms/os_arch:linux_glibc_x86": False, |
| 1398 | "//build/bazel/platforms/os_arch:linux_musl_x86": False, |
| 1399 | "//build/bazel/platforms/os_arch:windows_x86": False, |
| 1400 | "//conditions:default": None, |
| 1401 | })`, |
| 1402 | }), |
| 1403 | }) |
| 1404 | } |
| 1405 | |
| 1406 | func TestCCLibraryNoLibCrtArchAndTargetVariantConflict(t *testing.T) { |
| 1407 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1408 | moduleTypeUnderTest: "cc_library", |
| 1409 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1410 | filesystem: map[string]string{ |
| 1411 | "impl.cpp": "", |
| 1412 | }, |
| 1413 | blueprint: soongCcLibraryPreamble + ` |
| 1414 | cc_library { |
| 1415 | name: "foo-lib", |
| 1416 | srcs: ["impl.cpp"], |
| 1417 | arch: { |
| 1418 | arm: { |
| 1419 | no_libcrt: true, |
| 1420 | }, |
| 1421 | // This is expected to override the value for darwin_x86_64. |
| 1422 | x86_64: { |
| 1423 | no_libcrt: true, |
| 1424 | }, |
| 1425 | }, |
| 1426 | target: { |
| 1427 | darwin: { |
| 1428 | no_libcrt: false, |
| 1429 | } |
| 1430 | }, |
| 1431 | include_build_directory: false, |
| 1432 | } |
| 1433 | `, |
| 1434 | expectedBazelTargets: makeCcLibraryTargets("foo-lib", attrNameToString{ |
| 1435 | "srcs": `["impl.cpp"]`, |
| 1436 | "use_libcrt": `select({ |
| 1437 | "//build/bazel/platforms/os_arch:android_arm": False, |
| 1438 | "//build/bazel/platforms/os_arch:android_x86_64": False, |
| 1439 | "//build/bazel/platforms/os_arch:darwin_arm64": True, |
| 1440 | "//build/bazel/platforms/os_arch:darwin_x86_64": False, |
| 1441 | "//build/bazel/platforms/os_arch:linux_bionic_x86_64": False, |
| 1442 | "//build/bazel/platforms/os_arch:linux_glibc_x86_64": False, |
| 1443 | "//build/bazel/platforms/os_arch:linux_musl_x86_64": False, |
| 1444 | "//build/bazel/platforms/os_arch:windows_x86_64": False, |
| 1445 | "//conditions:default": None, |
| 1446 | })`, |
| 1447 | }), |
| 1448 | }) |
| 1449 | } |
| 1450 | |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1451 | func TestCcLibraryStrip(t *testing.T) { |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1452 | expectedTargets := []string{} |
| 1453 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("all", attrNameToString{ |
| 1454 | "strip": `{ |
| 1455 | "all": True, |
| 1456 | }`, |
| 1457 | })...) |
| 1458 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols", attrNameToString{ |
| 1459 | "strip": `{ |
| 1460 | "keep_symbols": True, |
| 1461 | }`, |
| 1462 | })...) |
| 1463 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols_and_debug_frame", attrNameToString{ |
| 1464 | "strip": `{ |
| 1465 | "keep_symbols_and_debug_frame": True, |
| 1466 | }`, |
| 1467 | })...) |
| 1468 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols_list", attrNameToString{ |
| 1469 | "strip": `{ |
| 1470 | "keep_symbols_list": ["symbol"], |
| 1471 | }`, |
| 1472 | })...) |
| 1473 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("none", attrNameToString{ |
| 1474 | "strip": `{ |
| 1475 | "none": True, |
| 1476 | }`, |
| 1477 | })...) |
| 1478 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("nothing", attrNameToString{})...) |
| 1479 | |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1480 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1481 | description: "cc_library strip args", |
| 1482 | moduleTypeUnderTest: "cc_library", |
| 1483 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1484 | blueprint: soongCcLibraryPreamble + ` |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1485 | cc_library { |
| 1486 | name: "nothing", |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1487 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1488 | } |
| 1489 | cc_library { |
| 1490 | name: "keep_symbols", |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1491 | strip: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1492 | keep_symbols: true, |
| 1493 | }, |
| 1494 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1495 | } |
| 1496 | cc_library { |
| 1497 | name: "keep_symbols_and_debug_frame", |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1498 | strip: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1499 | keep_symbols_and_debug_frame: true, |
| 1500 | }, |
| 1501 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1502 | } |
| 1503 | cc_library { |
| 1504 | name: "none", |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1505 | strip: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1506 | none: true, |
| 1507 | }, |
| 1508 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1509 | } |
| 1510 | cc_library { |
| 1511 | name: "keep_symbols_list", |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1512 | strip: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1513 | keep_symbols_list: ["symbol"], |
| 1514 | }, |
| 1515 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1516 | } |
| 1517 | cc_library { |
| 1518 | name: "all", |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1519 | strip: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1520 | all: true, |
| 1521 | }, |
| 1522 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1523 | } |
| 1524 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1525 | expectedBazelTargets: expectedTargets, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1526 | }) |
| 1527 | } |
| 1528 | |
| 1529 | func TestCcLibraryStripWithArch(t *testing.T) { |
| 1530 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1531 | description: "cc_library strip args", |
| 1532 | moduleTypeUnderTest: "cc_library", |
| 1533 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1534 | blueprint: soongCcLibraryPreamble + ` |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1535 | cc_library { |
| 1536 | name: "multi-arch", |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1537 | target: { |
| 1538 | darwin: { |
| 1539 | strip: { |
| 1540 | keep_symbols_list: ["foo", "bar"] |
| 1541 | } |
| 1542 | }, |
| 1543 | }, |
| 1544 | arch: { |
| 1545 | arm: { |
| 1546 | strip: { |
| 1547 | keep_symbols_and_debug_frame: true, |
| 1548 | }, |
| 1549 | }, |
| 1550 | arm64: { |
| 1551 | strip: { |
| 1552 | keep_symbols: true, |
| 1553 | }, |
| 1554 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1555 | }, |
| 1556 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1557 | } |
| 1558 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1559 | expectedBazelTargets: makeCcLibraryTargets("multi-arch", attrNameToString{ |
| 1560 | "strip": `{ |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1561 | "keep_symbols": select({ |
| 1562 | "//build/bazel/platforms/arch:arm64": True, |
| 1563 | "//conditions:default": None, |
| 1564 | }), |
| 1565 | "keep_symbols_and_debug_frame": select({ |
| 1566 | "//build/bazel/platforms/arch:arm": True, |
| 1567 | "//conditions:default": None, |
| 1568 | }), |
| 1569 | "keep_symbols_list": select({ |
| 1570 | "//build/bazel/platforms/os:darwin": [ |
| 1571 | "foo", |
| 1572 | "bar", |
| 1573 | ], |
| 1574 | "//conditions:default": [], |
| 1575 | }), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1576 | }`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1577 | }), |
| 1578 | }, |
| 1579 | ) |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1580 | } |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1581 | |
| 1582 | func TestCcLibrary_SystemSharedLibsRootEmpty(t *testing.T) { |
| 1583 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1584 | description: "cc_library system_shared_libs empty at root", |
| 1585 | moduleTypeUnderTest: "cc_library", |
| 1586 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1587 | blueprint: soongCcLibraryPreamble + ` |
| 1588 | cc_library { |
| 1589 | name: "root_empty", |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1590 | system_shared_libs: [], |
| 1591 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1592 | } |
| 1593 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1594 | expectedBazelTargets: makeCcLibraryTargets("root_empty", attrNameToString{ |
| 1595 | "system_dynamic_deps": `[]`, |
| 1596 | }), |
| 1597 | }, |
| 1598 | ) |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1599 | } |
| 1600 | |
| 1601 | func TestCcLibrary_SystemSharedLibsStaticEmpty(t *testing.T) { |
| 1602 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1603 | description: "cc_library system_shared_libs empty for static variant", |
| 1604 | moduleTypeUnderTest: "cc_library", |
| 1605 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1606 | blueprint: soongCcLibraryPreamble + ` |
| 1607 | cc_library { |
| 1608 | name: "static_empty", |
| 1609 | static: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1610 | system_shared_libs: [], |
| 1611 | }, |
| 1612 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1613 | } |
| 1614 | `, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1615 | expectedBazelTargets: []string{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1616 | makeBazelTarget("cc_library_static", "static_empty_bp2build_cc_library_static", attrNameToString{ |
| 1617 | "system_dynamic_deps": "[]", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1618 | }), |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1619 | makeBazelTarget("cc_library_shared", "static_empty", attrNameToString{}), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1620 | }, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1621 | }) |
| 1622 | } |
| 1623 | |
| 1624 | func TestCcLibrary_SystemSharedLibsSharedEmpty(t *testing.T) { |
| 1625 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1626 | description: "cc_library system_shared_libs empty for shared variant", |
| 1627 | moduleTypeUnderTest: "cc_library", |
| 1628 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1629 | blueprint: soongCcLibraryPreamble + ` |
| 1630 | cc_library { |
| 1631 | name: "shared_empty", |
| 1632 | shared: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1633 | system_shared_libs: [], |
| 1634 | }, |
| 1635 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1636 | } |
| 1637 | `, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1638 | expectedBazelTargets: []string{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1639 | makeBazelTarget("cc_library_static", "shared_empty_bp2build_cc_library_static", attrNameToString{}), |
| 1640 | makeBazelTarget("cc_library_shared", "shared_empty", attrNameToString{ |
| 1641 | "system_dynamic_deps": "[]", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1642 | }), |
| 1643 | }, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1644 | }) |
| 1645 | } |
| 1646 | |
| 1647 | func TestCcLibrary_SystemSharedLibsSharedBionicEmpty(t *testing.T) { |
| 1648 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1649 | description: "cc_library system_shared_libs empty for shared, bionic variant", |
| 1650 | moduleTypeUnderTest: "cc_library", |
| 1651 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1652 | blueprint: soongCcLibraryPreamble + ` |
| 1653 | cc_library { |
| 1654 | name: "shared_empty", |
| 1655 | target: { |
| 1656 | bionic: { |
| 1657 | shared: { |
| 1658 | system_shared_libs: [], |
| 1659 | } |
| 1660 | } |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1661 | }, |
| 1662 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1663 | } |
| 1664 | `, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1665 | expectedBazelTargets: []string{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1666 | makeBazelTarget("cc_library_static", "shared_empty_bp2build_cc_library_static", attrNameToString{}), |
| 1667 | makeBazelTarget("cc_library_shared", "shared_empty", attrNameToString{ |
| 1668 | "system_dynamic_deps": "[]", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1669 | }), |
| 1670 | }, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1671 | }) |
| 1672 | } |
| 1673 | |
| 1674 | func TestCcLibrary_SystemSharedLibsLinuxBionicEmpty(t *testing.T) { |
| 1675 | // Note that this behavior is technically incorrect (it's a simplification). |
| 1676 | // The correct behavior would be if bp2build wrote `system_dynamic_deps = []` |
| 1677 | // only for linux_bionic, but `android` had `["libc", "libdl", "libm"]. |
| 1678 | // b/195791252 tracks the fix. |
| 1679 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1680 | description: "cc_library system_shared_libs empty for linux_bionic variant", |
| 1681 | moduleTypeUnderTest: "cc_library", |
| 1682 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1683 | blueprint: soongCcLibraryPreamble + ` |
| 1684 | cc_library { |
| 1685 | name: "target_linux_bionic_empty", |
| 1686 | target: { |
| 1687 | linux_bionic: { |
| 1688 | system_shared_libs: [], |
| 1689 | }, |
| 1690 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1691 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1692 | } |
| 1693 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1694 | expectedBazelTargets: makeCcLibraryTargets("target_linux_bionic_empty", attrNameToString{ |
| 1695 | "system_dynamic_deps": `[]`, |
| 1696 | }), |
| 1697 | }, |
| 1698 | ) |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1699 | } |
| 1700 | |
| 1701 | func TestCcLibrary_SystemSharedLibsBionicEmpty(t *testing.T) { |
| 1702 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1703 | description: "cc_library system_shared_libs empty for bionic variant", |
| 1704 | moduleTypeUnderTest: "cc_library", |
| 1705 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1706 | blueprint: soongCcLibraryPreamble + ` |
| 1707 | cc_library { |
| 1708 | name: "target_bionic_empty", |
| 1709 | target: { |
| 1710 | bionic: { |
| 1711 | system_shared_libs: [], |
| 1712 | }, |
| 1713 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1714 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1715 | } |
| 1716 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1717 | expectedBazelTargets: makeCcLibraryTargets("target_bionic_empty", attrNameToString{ |
| 1718 | "system_dynamic_deps": `[]`, |
| 1719 | }), |
| 1720 | }, |
| 1721 | ) |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1722 | } |
| 1723 | |
| 1724 | func TestCcLibrary_SystemSharedLibsSharedAndRoot(t *testing.T) { |
| 1725 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1726 | description: "cc_library system_shared_libs set for shared and root", |
| 1727 | moduleTypeUnderTest: "cc_library", |
| 1728 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1729 | blueprint: soongCcLibraryPreamble + ` |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1730 | cc_library { |
| 1731 | name: "libc", |
| 1732 | bazel_module: { bp2build_available: false }, |
| 1733 | } |
| 1734 | cc_library { |
| 1735 | name: "libm", |
| 1736 | bazel_module: { bp2build_available: false }, |
| 1737 | } |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1738 | |
| 1739 | cc_library { |
| 1740 | name: "foo", |
| 1741 | system_shared_libs: ["libc"], |
| 1742 | shared: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1743 | system_shared_libs: ["libm"], |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1744 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1745 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1746 | } |
| 1747 | `, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1748 | expectedBazelTargets: []string{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1749 | makeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", attrNameToString{ |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1750 | "system_dynamic_deps": `[":libc"]`, |
| 1751 | }), |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1752 | makeBazelTarget("cc_library_shared", "foo", attrNameToString{ |
| 1753 | "system_dynamic_deps": `[ |
| 1754 | ":libc", |
| 1755 | ":libm", |
| 1756 | ]`, |
| 1757 | }), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1758 | }, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1759 | }) |
| 1760 | } |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1761 | |
| 1762 | func TestCcLibraryOsSelects(t *testing.T) { |
| 1763 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1764 | description: "cc_library - selects for all os targets", |
| 1765 | moduleTypeUnderTest: "cc_library", |
| 1766 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1767 | filesystem: map[string]string{}, |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1768 | blueprint: soongCcLibraryPreamble + ` |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1769 | cc_library { |
| 1770 | name: "foo-lib", |
| 1771 | srcs: ["base.cpp"], |
| 1772 | target: { |
| 1773 | android: { |
| 1774 | srcs: ["android.cpp"], |
| 1775 | }, |
| 1776 | linux: { |
| 1777 | srcs: ["linux.cpp"], |
| 1778 | }, |
| 1779 | linux_glibc: { |
| 1780 | srcs: ["linux_glibc.cpp"], |
| 1781 | }, |
| 1782 | darwin: { |
| 1783 | srcs: ["darwin.cpp"], |
| 1784 | }, |
| 1785 | bionic: { |
| 1786 | srcs: ["bionic.cpp"], |
| 1787 | }, |
| 1788 | linux_musl: { |
| 1789 | srcs: ["linux_musl.cpp"], |
| 1790 | }, |
| 1791 | windows: { |
| 1792 | srcs: ["windows.cpp"], |
| 1793 | }, |
| 1794 | }, |
| 1795 | include_build_directory: false, |
| 1796 | } |
| 1797 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1798 | expectedBazelTargets: makeCcLibraryTargets("foo-lib", attrNameToString{ |
| 1799 | "srcs": `["base.cpp"] + select({ |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1800 | "//build/bazel/platforms/os:android": [ |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1801 | "linux.cpp", |
Liz Kammer | 9bad9d6 | 2021-10-11 15:40:35 -0400 | [diff] [blame] | 1802 | "bionic.cpp", |
Liz Kammer | fdd72e6 | 2021-10-11 15:41:03 -0400 | [diff] [blame] | 1803 | "android.cpp", |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1804 | ], |
| 1805 | "//build/bazel/platforms/os:darwin": ["darwin.cpp"], |
| 1806 | "//build/bazel/platforms/os:linux": [ |
Liz Kammer | 9bad9d6 | 2021-10-11 15:40:35 -0400 | [diff] [blame] | 1807 | "linux.cpp", |
Liz Kammer | fdd72e6 | 2021-10-11 15:41:03 -0400 | [diff] [blame] | 1808 | "linux_glibc.cpp", |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1809 | ], |
| 1810 | "//build/bazel/platforms/os:linux_bionic": [ |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1811 | "linux.cpp", |
Liz Kammer | 9bad9d6 | 2021-10-11 15:40:35 -0400 | [diff] [blame] | 1812 | "bionic.cpp", |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1813 | ], |
| 1814 | "//build/bazel/platforms/os:linux_musl": [ |
Liz Kammer | 9bad9d6 | 2021-10-11 15:40:35 -0400 | [diff] [blame] | 1815 | "linux.cpp", |
Liz Kammer | fdd72e6 | 2021-10-11 15:41:03 -0400 | [diff] [blame] | 1816 | "linux_musl.cpp", |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1817 | ], |
| 1818 | "//build/bazel/platforms/os:windows": ["windows.cpp"], |
| 1819 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1820 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1821 | }), |
| 1822 | }, |
| 1823 | ) |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1824 | } |
| 1825 | |
Yu Liu | 75be7b9 | 2022-02-01 09:54:09 -0800 | [diff] [blame] | 1826 | func TestLibcryptoHashInjection(t *testing.T) { |
| 1827 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1828 | description: "cc_library - libcrypto hash injection", |
| 1829 | moduleTypeUnderTest: "cc_library", |
| 1830 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1831 | filesystem: map[string]string{}, |
| 1832 | blueprint: soongCcLibraryPreamble + ` |
| 1833 | cc_library { |
| 1834 | name: "libcrypto", |
| 1835 | target: { |
| 1836 | android: { |
| 1837 | inject_bssl_hash: true, |
| 1838 | }, |
| 1839 | }, |
| 1840 | include_build_directory: false, |
| 1841 | } |
| 1842 | `, |
| 1843 | expectedBazelTargets: makeCcLibraryTargets("libcrypto", attrNameToString{ |
| 1844 | "inject_bssl_hash": `select({ |
| 1845 | "//build/bazel/platforms/os:android": True, |
| 1846 | "//conditions:default": None, |
| 1847 | })`, |
| 1848 | }), |
| 1849 | }, |
| 1850 | ) |
| 1851 | } |
| 1852 | |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1853 | func TestCcLibraryCppStdWithGnuExtensions_ConvertsToFeatureAttr(t *testing.T) { |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1854 | type testCase struct { |
| 1855 | cpp_std string |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1856 | c_std string |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1857 | gnu_extensions string |
| 1858 | bazel_cpp_std string |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1859 | bazel_c_std string |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1860 | } |
| 1861 | |
| 1862 | testCases := []testCase{ |
| 1863 | // Existing usages of cpp_std in AOSP are: |
| 1864 | // experimental, c++11, c++17, c++2a, c++98, gnu++11, gnu++17 |
| 1865 | // |
| 1866 | // not set, only emit if gnu_extensions is disabled. the default (gnu+17 |
| 1867 | // is set in the toolchain.) |
| 1868 | {cpp_std: "", gnu_extensions: "", bazel_cpp_std: ""}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1869 | {cpp_std: "", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c99"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1870 | {cpp_std: "", gnu_extensions: "true", bazel_cpp_std: ""}, |
| 1871 | // experimental defaults to gnu++2a |
| 1872 | {cpp_std: "experimental", gnu_extensions: "", bazel_cpp_std: "gnu++2a"}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1873 | {cpp_std: "experimental", gnu_extensions: "false", bazel_cpp_std: "c++2a", bazel_c_std: "c99"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1874 | {cpp_std: "experimental", gnu_extensions: "true", bazel_cpp_std: "gnu++2a"}, |
| 1875 | // Explicitly setting a c++ std does not use replace gnu++ std even if |
| 1876 | // gnu_extensions is true. |
| 1877 | // "c++11", |
| 1878 | {cpp_std: "c++11", gnu_extensions: "", bazel_cpp_std: "c++11"}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1879 | {cpp_std: "c++11", gnu_extensions: "false", bazel_cpp_std: "c++11", bazel_c_std: "c99"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1880 | {cpp_std: "c++11", gnu_extensions: "true", bazel_cpp_std: "c++11"}, |
| 1881 | // "c++17", |
| 1882 | {cpp_std: "c++17", gnu_extensions: "", bazel_cpp_std: "c++17"}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1883 | {cpp_std: "c++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c99"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1884 | {cpp_std: "c++17", gnu_extensions: "true", bazel_cpp_std: "c++17"}, |
| 1885 | // "c++2a", |
| 1886 | {cpp_std: "c++2a", gnu_extensions: "", bazel_cpp_std: "c++2a"}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1887 | {cpp_std: "c++2a", gnu_extensions: "false", bazel_cpp_std: "c++2a", bazel_c_std: "c99"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1888 | {cpp_std: "c++2a", gnu_extensions: "true", bazel_cpp_std: "c++2a"}, |
| 1889 | // "c++98", |
| 1890 | {cpp_std: "c++98", gnu_extensions: "", bazel_cpp_std: "c++98"}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1891 | {cpp_std: "c++98", gnu_extensions: "false", bazel_cpp_std: "c++98", bazel_c_std: "c99"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1892 | {cpp_std: "c++98", gnu_extensions: "true", bazel_cpp_std: "c++98"}, |
| 1893 | // gnu++ is replaced with c++ if gnu_extensions is explicitly false. |
| 1894 | // "gnu++11", |
| 1895 | {cpp_std: "gnu++11", gnu_extensions: "", bazel_cpp_std: "gnu++11"}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1896 | {cpp_std: "gnu++11", gnu_extensions: "false", bazel_cpp_std: "c++11", bazel_c_std: "c99"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1897 | {cpp_std: "gnu++11", gnu_extensions: "true", bazel_cpp_std: "gnu++11"}, |
| 1898 | // "gnu++17", |
| 1899 | {cpp_std: "gnu++17", gnu_extensions: "", bazel_cpp_std: "gnu++17"}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1900 | {cpp_std: "gnu++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c99"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1901 | {cpp_std: "gnu++17", gnu_extensions: "true", bazel_cpp_std: "gnu++17"}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1902 | |
| 1903 | // some c_std test cases |
| 1904 | {c_std: "experimental", gnu_extensions: "", bazel_c_std: "gnu11"}, |
| 1905 | {c_std: "experimental", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c11"}, |
| 1906 | {c_std: "experimental", gnu_extensions: "true", bazel_c_std: "gnu11"}, |
| 1907 | {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "", bazel_cpp_std: "gnu++17", bazel_c_std: "gnu11"}, |
| 1908 | {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c11"}, |
| 1909 | {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "true", bazel_cpp_std: "gnu++17", bazel_c_std: "gnu11"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1910 | } |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1911 | for i, tc := range testCases { |
| 1912 | name_prefix := fmt.Sprintf("a_%v", i) |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1913 | cppStdProp := "" |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1914 | if tc.cpp_std != "" { |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1915 | cppStdProp = fmt.Sprintf(" cpp_std: \"%s\",", tc.cpp_std) |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1916 | } |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1917 | cStdProp := "" |
| 1918 | if tc.c_std != "" { |
| 1919 | cStdProp = fmt.Sprintf(" c_std: \"%s\",", tc.c_std) |
| 1920 | } |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1921 | gnuExtensionsProp := "" |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1922 | if tc.gnu_extensions != "" { |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1923 | gnuExtensionsProp = fmt.Sprintf(" gnu_extensions: %s,", tc.gnu_extensions) |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1924 | } |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1925 | attrs := attrNameToString{} |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1926 | if tc.bazel_cpp_std != "" { |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1927 | attrs["cpp_std"] = fmt.Sprintf(`"%s"`, tc.bazel_cpp_std) |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1928 | } |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1929 | if tc.bazel_c_std != "" { |
| 1930 | attrs["c_std"] = fmt.Sprintf(`"%s"`, tc.bazel_c_std) |
| 1931 | } |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1932 | |
| 1933 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1934 | description: fmt.Sprintf( |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1935 | "cc_library with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions), |
| 1936 | moduleTypeUnderTest: "cc_library", |
| 1937 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1938 | blueprint: soongCcLibraryPreamble + fmt.Sprintf(` |
| 1939 | cc_library { |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1940 | name: "%s_full", |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1941 | %s // cpp_std: *string |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1942 | %s // c_std: *string |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1943 | %s // gnu_extensions: *bool |
| 1944 | include_build_directory: false, |
| 1945 | } |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1946 | `, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp), |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 1947 | expectedBazelTargets: makeCcLibraryTargets(name_prefix+"_full", attrs), |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1948 | }) |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1949 | |
| 1950 | runCcLibraryStaticTestCase(t, bp2buildTestCase{ |
| 1951 | description: fmt.Sprintf( |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1952 | "cc_library_static with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions), |
| 1953 | moduleTypeUnderTest: "cc_library_static", |
| 1954 | moduleTypeUnderTestFactory: cc.LibraryStaticFactory, |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1955 | blueprint: soongCcLibraryPreamble + fmt.Sprintf(` |
| 1956 | cc_library_static { |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1957 | name: "%s_static", |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1958 | %s // cpp_std: *string |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1959 | %s // c_std: *string |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1960 | %s // gnu_extensions: *bool |
| 1961 | include_build_directory: false, |
| 1962 | } |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1963 | `, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1964 | expectedBazelTargets: []string{ |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1965 | makeBazelTarget("cc_library_static", name_prefix+"_static", attrs), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1966 | }, |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1967 | }) |
| 1968 | |
| 1969 | runCcLibrarySharedTestCase(t, bp2buildTestCase{ |
| 1970 | description: fmt.Sprintf( |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1971 | "cc_library_shared with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions), |
| 1972 | moduleTypeUnderTest: "cc_library_shared", |
| 1973 | moduleTypeUnderTestFactory: cc.LibrarySharedFactory, |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1974 | blueprint: soongCcLibraryPreamble + fmt.Sprintf(` |
| 1975 | cc_library_shared { |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1976 | name: "%s_shared", |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1977 | %s // cpp_std: *string |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1978 | %s // c_std: *string |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1979 | %s // gnu_extensions: *bool |
| 1980 | include_build_directory: false, |
| 1981 | } |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1982 | `, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1983 | expectedBazelTargets: []string{ |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1984 | makeBazelTarget("cc_library_shared", name_prefix+"_shared", attrs), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1985 | }, |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1986 | }) |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1987 | } |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1988 | } |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 1989 | |
| 1990 | func TestCcLibraryProtoSimple(t *testing.T) { |
| 1991 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 1992 | moduleTypeUnderTest: "cc_library", |
| 1993 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 1994 | blueprint: soongCcProtoPreamble + `cc_library { |
| 1995 | name: "foo", |
| 1996 | srcs: ["foo.proto"], |
| 1997 | include_build_directory: false, |
| 1998 | }`, |
| 1999 | expectedBazelTargets: []string{ |
| 2000 | makeBazelTarget("proto_library", "foo_proto", attrNameToString{ |
Liz Kammer | 7756c8f | 2022-02-14 20:49:15 -0500 | [diff] [blame^] | 2001 | "srcs": `["foo.proto"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2002 | }), makeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", attrNameToString{ |
| 2003 | "deps": `[":foo_proto"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2004 | }), makeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", attrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2005 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2006 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 2007 | }), makeBazelTarget("cc_library_shared", "foo", attrNameToString{ |
| 2008 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2009 | }), |
| 2010 | }, |
| 2011 | }) |
| 2012 | } |
| 2013 | |
| 2014 | func TestCcLibraryProtoNoCanonicalPathFromRoot(t *testing.T) { |
| 2015 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 2016 | moduleTypeUnderTest: "cc_library", |
| 2017 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2018 | blueprint: soongCcProtoPreamble + `cc_library { |
| 2019 | name: "foo", |
| 2020 | srcs: ["foo.proto"], |
| 2021 | proto: { canonical_path_from_root: false}, |
| 2022 | include_build_directory: false, |
| 2023 | }`, |
| 2024 | expectedBazelTargets: []string{ |
| 2025 | makeBazelTarget("proto_library", "foo_proto", attrNameToString{ |
Liz Kammer | 7756c8f | 2022-02-14 20:49:15 -0500 | [diff] [blame^] | 2026 | "srcs": `["foo.proto"]`, |
| 2027 | "strip_import_prefix": `""`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2028 | }), makeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", attrNameToString{ |
| 2029 | "deps": `[":foo_proto"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2030 | }), makeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", attrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2031 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2032 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 2033 | }), makeBazelTarget("cc_library_shared", "foo", attrNameToString{ |
| 2034 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2035 | }), |
| 2036 | }, |
| 2037 | }) |
| 2038 | } |
| 2039 | |
| 2040 | func TestCcLibraryProtoExplicitCanonicalPathFromRoot(t *testing.T) { |
| 2041 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 2042 | moduleTypeUnderTest: "cc_library", |
| 2043 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2044 | blueprint: soongCcProtoPreamble + `cc_library { |
| 2045 | name: "foo", |
| 2046 | srcs: ["foo.proto"], |
| 2047 | proto: { canonical_path_from_root: true}, |
| 2048 | include_build_directory: false, |
| 2049 | }`, |
| 2050 | expectedBazelTargets: []string{ |
| 2051 | makeBazelTarget("proto_library", "foo_proto", attrNameToString{ |
Liz Kammer | 7756c8f | 2022-02-14 20:49:15 -0500 | [diff] [blame^] | 2052 | "srcs": `["foo.proto"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2053 | }), makeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", attrNameToString{ |
| 2054 | "deps": `[":foo_proto"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2055 | }), makeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", attrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2056 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2057 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 2058 | }), makeBazelTarget("cc_library_shared", "foo", attrNameToString{ |
| 2059 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2060 | }), |
| 2061 | }, |
| 2062 | }) |
| 2063 | } |
| 2064 | |
| 2065 | func TestCcLibraryProtoFull(t *testing.T) { |
| 2066 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 2067 | moduleTypeUnderTest: "cc_library", |
| 2068 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2069 | blueprint: soongCcProtoPreamble + `cc_library { |
| 2070 | name: "foo", |
| 2071 | srcs: ["foo.proto"], |
| 2072 | proto: { |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2073 | type: "full", |
| 2074 | }, |
| 2075 | include_build_directory: false, |
| 2076 | }`, |
| 2077 | expectedBazelTargets: []string{ |
| 2078 | makeBazelTarget("proto_library", "foo_proto", attrNameToString{ |
| 2079 | "srcs": `["foo.proto"]`, |
| 2080 | }), makeBazelTarget("cc_proto_library", "foo_cc_proto", attrNameToString{ |
| 2081 | "deps": `[":foo_proto"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2082 | }), makeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", attrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2083 | "implementation_whole_archive_deps": `[":foo_cc_proto"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2084 | "deps": `[":libprotobuf-cpp-full"]`, |
| 2085 | }), makeBazelTarget("cc_library_shared", "foo", attrNameToString{ |
| 2086 | "dynamic_deps": `[":libprotobuf-cpp-full"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2087 | }), |
| 2088 | }, |
| 2089 | }) |
| 2090 | } |
| 2091 | |
| 2092 | func TestCcLibraryProtoLite(t *testing.T) { |
| 2093 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 2094 | moduleTypeUnderTest: "cc_library", |
| 2095 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2096 | blueprint: soongCcProtoPreamble + `cc_library { |
| 2097 | name: "foo", |
| 2098 | srcs: ["foo.proto"], |
| 2099 | proto: { |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2100 | type: "lite", |
| 2101 | }, |
| 2102 | include_build_directory: false, |
| 2103 | }`, |
| 2104 | expectedBazelTargets: []string{ |
| 2105 | makeBazelTarget("proto_library", "foo_proto", attrNameToString{ |
| 2106 | "srcs": `["foo.proto"]`, |
| 2107 | }), makeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", attrNameToString{ |
| 2108 | "deps": `[":foo_proto"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2109 | }), makeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", attrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2110 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2111 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 2112 | }), makeBazelTarget("cc_library_shared", "foo", attrNameToString{ |
| 2113 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2114 | }), |
| 2115 | }, |
| 2116 | }) |
| 2117 | } |
| 2118 | |
| 2119 | func TestCcLibraryProtoExportHeaders(t *testing.T) { |
| 2120 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 2121 | moduleTypeUnderTest: "cc_library", |
| 2122 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2123 | blueprint: soongCcProtoPreamble + `cc_library { |
| 2124 | name: "foo", |
| 2125 | srcs: ["foo.proto"], |
| 2126 | proto: { |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2127 | export_proto_headers: true, |
| 2128 | }, |
| 2129 | include_build_directory: false, |
| 2130 | }`, |
| 2131 | expectedBazelTargets: []string{ |
| 2132 | makeBazelTarget("proto_library", "foo_proto", attrNameToString{ |
| 2133 | "srcs": `["foo.proto"]`, |
| 2134 | }), makeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", attrNameToString{ |
| 2135 | "deps": `[":foo_proto"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2136 | }), makeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", attrNameToString{ |
| 2137 | "deps": `[":libprotobuf-cpp-lite"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2138 | "whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame] | 2139 | }), makeBazelTarget("cc_library_shared", "foo", attrNameToString{ |
| 2140 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
| 2141 | "whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2142 | }), |
| 2143 | }, |
| 2144 | }) |
| 2145 | } |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2146 | |
| 2147 | func TestCcLibraryProtoFilegroups(t *testing.T) { |
| 2148 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 2149 | moduleTypeUnderTest: "cc_library", |
| 2150 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 2151 | blueprint: soongCcProtoPreamble + |
| 2152 | simpleModuleDoNotConvertBp2build("filegroup", "a_fg_proto") + |
| 2153 | simpleModuleDoNotConvertBp2build("filegroup", "b_protos") + |
| 2154 | simpleModuleDoNotConvertBp2build("filegroup", "c-proto-srcs") + |
| 2155 | simpleModuleDoNotConvertBp2build("filegroup", "proto-srcs-d") + ` |
| 2156 | cc_library { |
| 2157 | name: "a", |
| 2158 | srcs: [":a_fg_proto"], |
| 2159 | proto: { |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2160 | export_proto_headers: true, |
| 2161 | }, |
| 2162 | include_build_directory: false, |
| 2163 | } |
| 2164 | |
| 2165 | cc_library { |
| 2166 | name: "b", |
| 2167 | srcs: [":b_protos"], |
| 2168 | proto: { |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2169 | export_proto_headers: true, |
| 2170 | }, |
| 2171 | include_build_directory: false, |
| 2172 | } |
| 2173 | |
| 2174 | cc_library { |
| 2175 | name: "c", |
| 2176 | srcs: [":c-proto-srcs"], |
| 2177 | proto: { |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2178 | export_proto_headers: true, |
| 2179 | }, |
| 2180 | include_build_directory: false, |
| 2181 | } |
| 2182 | |
| 2183 | cc_library { |
| 2184 | name: "d", |
| 2185 | srcs: [":proto-srcs-d"], |
| 2186 | proto: { |
Liz Kammer | aabfb5d | 2021-12-08 15:25:06 -0500 | [diff] [blame] | 2187 | export_proto_headers: true, |
| 2188 | }, |
| 2189 | include_build_directory: false, |
| 2190 | }`, |
| 2191 | expectedBazelTargets: []string{ |
| 2192 | makeBazelTarget("proto_library", "a_proto", attrNameToString{ |
| 2193 | "srcs": `[":a_fg_proto"]`, |
| 2194 | }), makeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", attrNameToString{ |
| 2195 | "deps": `[":a_proto"]`, |
| 2196 | }), makeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", attrNameToString{ |
| 2197 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 2198 | "whole_archive_deps": `[":a_cc_proto_lite"]`, |
| 2199 | "srcs": `[":a_fg_proto_cpp_srcs"]`, |
| 2200 | "srcs_as": `[":a_fg_proto_as_srcs"]`, |
| 2201 | "srcs_c": `[":a_fg_proto_c_srcs"]`, |
| 2202 | }), makeBazelTarget("cc_library_shared", "a", attrNameToString{ |
| 2203 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
| 2204 | "whole_archive_deps": `[":a_cc_proto_lite"]`, |
| 2205 | "srcs": `[":a_fg_proto_cpp_srcs"]`, |
| 2206 | "srcs_as": `[":a_fg_proto_as_srcs"]`, |
| 2207 | "srcs_c": `[":a_fg_proto_c_srcs"]`, |
| 2208 | }), makeBazelTarget("proto_library", "b_proto", attrNameToString{ |
| 2209 | "srcs": `[":b_protos"]`, |
| 2210 | }), makeBazelTarget("cc_lite_proto_library", "b_cc_proto_lite", attrNameToString{ |
| 2211 | "deps": `[":b_proto"]`, |
| 2212 | }), makeBazelTarget("cc_library_static", "b_bp2build_cc_library_static", attrNameToString{ |
| 2213 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 2214 | "whole_archive_deps": `[":b_cc_proto_lite"]`, |
| 2215 | "srcs": `[":b_protos_cpp_srcs"]`, |
| 2216 | "srcs_as": `[":b_protos_as_srcs"]`, |
| 2217 | "srcs_c": `[":b_protos_c_srcs"]`, |
| 2218 | }), makeBazelTarget("cc_library_shared", "b", attrNameToString{ |
| 2219 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
| 2220 | "whole_archive_deps": `[":b_cc_proto_lite"]`, |
| 2221 | "srcs": `[":b_protos_cpp_srcs"]`, |
| 2222 | "srcs_as": `[":b_protos_as_srcs"]`, |
| 2223 | "srcs_c": `[":b_protos_c_srcs"]`, |
| 2224 | }), makeBazelTarget("proto_library", "c_proto", attrNameToString{ |
| 2225 | "srcs": `[":c-proto-srcs"]`, |
| 2226 | }), makeBazelTarget("cc_lite_proto_library", "c_cc_proto_lite", attrNameToString{ |
| 2227 | "deps": `[":c_proto"]`, |
| 2228 | }), makeBazelTarget("cc_library_static", "c_bp2build_cc_library_static", attrNameToString{ |
| 2229 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 2230 | "whole_archive_deps": `[":c_cc_proto_lite"]`, |
| 2231 | "srcs": `[":c-proto-srcs_cpp_srcs"]`, |
| 2232 | "srcs_as": `[":c-proto-srcs_as_srcs"]`, |
| 2233 | "srcs_c": `[":c-proto-srcs_c_srcs"]`, |
| 2234 | }), makeBazelTarget("cc_library_shared", "c", attrNameToString{ |
| 2235 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
| 2236 | "whole_archive_deps": `[":c_cc_proto_lite"]`, |
| 2237 | "srcs": `[":c-proto-srcs_cpp_srcs"]`, |
| 2238 | "srcs_as": `[":c-proto-srcs_as_srcs"]`, |
| 2239 | "srcs_c": `[":c-proto-srcs_c_srcs"]`, |
| 2240 | }), makeBazelTarget("proto_library", "d_proto", attrNameToString{ |
| 2241 | "srcs": `[":proto-srcs-d"]`, |
| 2242 | }), makeBazelTarget("cc_lite_proto_library", "d_cc_proto_lite", attrNameToString{ |
| 2243 | "deps": `[":d_proto"]`, |
| 2244 | }), makeBazelTarget("cc_library_static", "d_bp2build_cc_library_static", attrNameToString{ |
| 2245 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 2246 | "whole_archive_deps": `[":d_cc_proto_lite"]`, |
| 2247 | "srcs": `[":proto-srcs-d_cpp_srcs"]`, |
| 2248 | "srcs_as": `[":proto-srcs-d_as_srcs"]`, |
| 2249 | "srcs_c": `[":proto-srcs-d_c_srcs"]`, |
| 2250 | }), makeBazelTarget("cc_library_shared", "d", attrNameToString{ |
| 2251 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
| 2252 | "whole_archive_deps": `[":d_cc_proto_lite"]`, |
| 2253 | "srcs": `[":proto-srcs-d_cpp_srcs"]`, |
| 2254 | "srcs_as": `[":proto-srcs-d_as_srcs"]`, |
| 2255 | "srcs_c": `[":proto-srcs-d_c_srcs"]`, |
| 2256 | }), |
| 2257 | }, |
| 2258 | }) |
| 2259 | } |
Chris Parsons | 58852a0 | 2021-12-09 18:10:18 -0500 | [diff] [blame] | 2260 | |
| 2261 | func TestCcLibraryDisabledArchAndTarget(t *testing.T) { |
| 2262 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 2263 | moduleTypeUnderTest: "cc_library", |
| 2264 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 2265 | blueprint: soongCcProtoPreamble + `cc_library { |
| 2266 | name: "foo", |
| 2267 | srcs: ["foo.cpp"], |
| 2268 | target: { |
| 2269 | darwin: { |
| 2270 | enabled: false, |
| 2271 | }, |
| 2272 | windows: { |
| 2273 | enabled: false, |
| 2274 | }, |
| 2275 | linux_glibc_x86: { |
| 2276 | enabled: false, |
| 2277 | }, |
| 2278 | }, |
| 2279 | include_build_directory: false, |
| 2280 | }`, |
| 2281 | expectedBazelTargets: makeCcLibraryTargets("foo", attrNameToString{ |
| 2282 | "srcs": `["foo.cpp"]`, |
| 2283 | "target_compatible_with": `select({ |
| 2284 | "//build/bazel/platforms/os_arch:darwin_arm64": ["@platforms//:incompatible"], |
| 2285 | "//build/bazel/platforms/os_arch:darwin_x86_64": ["@platforms//:incompatible"], |
| 2286 | "//build/bazel/platforms/os_arch:linux_glibc_x86": ["@platforms//:incompatible"], |
| 2287 | "//build/bazel/platforms/os_arch:windows_x86": ["@platforms//:incompatible"], |
| 2288 | "//build/bazel/platforms/os_arch:windows_x86_64": ["@platforms//:incompatible"], |
| 2289 | "//conditions:default": [], |
| 2290 | })`, |
| 2291 | }), |
| 2292 | }) |
| 2293 | } |
| 2294 | |
| 2295 | func TestCcLibraryDisabledArchAndTargetWithDefault(t *testing.T) { |
| 2296 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 2297 | moduleTypeUnderTest: "cc_library", |
| 2298 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 2299 | blueprint: soongCcProtoPreamble + `cc_library { |
| 2300 | name: "foo", |
| 2301 | srcs: ["foo.cpp"], |
| 2302 | enabled: false, |
| 2303 | target: { |
| 2304 | darwin: { |
| 2305 | enabled: true, |
| 2306 | }, |
| 2307 | windows: { |
| 2308 | enabled: false, |
| 2309 | }, |
| 2310 | linux_glibc_x86: { |
| 2311 | enabled: false, |
| 2312 | }, |
| 2313 | }, |
| 2314 | include_build_directory: false, |
| 2315 | }`, |
| 2316 | expectedBazelTargets: makeCcLibraryTargets("foo", attrNameToString{ |
| 2317 | "srcs": `["foo.cpp"]`, |
| 2318 | "target_compatible_with": `select({ |
| 2319 | "//build/bazel/platforms/os_arch:darwin_arm64": [], |
| 2320 | "//build/bazel/platforms/os_arch:darwin_x86_64": [], |
| 2321 | "//conditions:default": ["@platforms//:incompatible"], |
| 2322 | })`, |
| 2323 | }), |
| 2324 | }) |
| 2325 | } |
| 2326 | |
| 2327 | func TestCcLibrarySharedDisabled(t *testing.T) { |
| 2328 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 2329 | moduleTypeUnderTest: "cc_library", |
| 2330 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 2331 | blueprint: soongCcProtoPreamble + `cc_library { |
| 2332 | name: "foo", |
| 2333 | srcs: ["foo.cpp"], |
| 2334 | enabled: false, |
| 2335 | shared: { |
| 2336 | enabled: true, |
| 2337 | }, |
| 2338 | target: { |
| 2339 | android: { |
| 2340 | shared: { |
| 2341 | enabled: false, |
| 2342 | }, |
| 2343 | } |
| 2344 | }, |
| 2345 | include_build_directory: false, |
| 2346 | }`, |
| 2347 | expectedBazelTargets: []string{makeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", attrNameToString{ |
| 2348 | "srcs": `["foo.cpp"]`, |
| 2349 | "target_compatible_with": `["@platforms//:incompatible"]`, |
| 2350 | }), makeBazelTarget("cc_library_shared", "foo", attrNameToString{ |
| 2351 | "srcs": `["foo.cpp"]`, |
| 2352 | "target_compatible_with": `select({ |
| 2353 | "//build/bazel/platforms/os:android": ["@platforms//:incompatible"], |
| 2354 | "//conditions:default": [], |
| 2355 | })`, |
| 2356 | }), |
| 2357 | }, |
| 2358 | }) |
| 2359 | } |
| 2360 | |
| 2361 | func TestCcLibraryStaticDisabledForSomeArch(t *testing.T) { |
| 2362 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 2363 | moduleTypeUnderTest: "cc_library", |
| 2364 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 2365 | blueprint: soongCcProtoPreamble + `cc_library { |
| 2366 | name: "foo", |
| 2367 | srcs: ["foo.cpp"], |
| 2368 | shared: { |
| 2369 | enabled: false |
| 2370 | }, |
| 2371 | target: { |
| 2372 | darwin: { |
| 2373 | enabled: true, |
| 2374 | }, |
| 2375 | windows: { |
| 2376 | enabled: false, |
| 2377 | }, |
| 2378 | linux_glibc_x86: { |
| 2379 | shared: { |
| 2380 | enabled: true, |
| 2381 | }, |
| 2382 | }, |
| 2383 | }, |
| 2384 | include_build_directory: false, |
| 2385 | }`, |
| 2386 | expectedBazelTargets: []string{makeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", attrNameToString{ |
| 2387 | "srcs": `["foo.cpp"]`, |
| 2388 | "target_compatible_with": `select({ |
| 2389 | "//build/bazel/platforms/os:windows": ["@platforms//:incompatible"], |
| 2390 | "//conditions:default": [], |
| 2391 | })`, |
| 2392 | }), makeBazelTarget("cc_library_shared", "foo", attrNameToString{ |
| 2393 | "srcs": `["foo.cpp"]`, |
| 2394 | "target_compatible_with": `select({ |
| 2395 | "//build/bazel/platforms/os_arch:darwin_arm64": [], |
| 2396 | "//build/bazel/platforms/os_arch:darwin_x86_64": [], |
| 2397 | "//build/bazel/platforms/os_arch:linux_glibc_x86": [], |
| 2398 | "//conditions:default": ["@platforms//:incompatible"], |
| 2399 | })`, |
| 2400 | }), |
| 2401 | }}) |
| 2402 | } |
Jingwen Chen | 0ee88a6 | 2022-01-07 14:55:29 +0000 | [diff] [blame] | 2403 | |
| 2404 | func TestCcLibraryStubs(t *testing.T) { |
| 2405 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 2406 | description: "cc_library stubs", |
| 2407 | moduleTypeUnderTest: "cc_library", |
| 2408 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 2409 | dir: "foo/bar", |
| 2410 | filesystem: map[string]string{ |
| 2411 | "foo/bar/Android.bp": ` |
| 2412 | cc_library { |
| 2413 | name: "a", |
| 2414 | stubs: { symbol_file: "a.map.txt", versions: ["28", "29", "current"] }, |
| 2415 | bazel_module: { bp2build_available: true }, |
| 2416 | include_build_directory: false, |
| 2417 | } |
| 2418 | `, |
| 2419 | }, |
| 2420 | blueprint: soongCcLibraryPreamble, |
| 2421 | expectedBazelTargets: makeCcLibraryTargets("a", attrNameToString{ |
| 2422 | "stubs_symbol_file": `"a.map.txt"`, |
| 2423 | "stubs_versions": `[ |
| 2424 | "28", |
| 2425 | "29", |
| 2426 | "current", |
| 2427 | ]`, |
| 2428 | }), |
| 2429 | }, |
| 2430 | ) |
| 2431 | } |
Liz Kammer | f38a837 | 2022-02-04 15:39:00 -0500 | [diff] [blame] | 2432 | |
| 2433 | func TestCcLibraryEscapeLdflags(t *testing.T) { |
| 2434 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 2435 | moduleTypeUnderTest: "cc_library", |
| 2436 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 2437 | blueprint: soongCcProtoPreamble + `cc_library { |
| 2438 | name: "foo", |
| 2439 | ldflags: ["-Wl,--rpath,${ORIGIN}"], |
| 2440 | include_build_directory: false, |
| 2441 | }`, |
| 2442 | expectedBazelTargets: makeCcLibraryTargets("foo", attrNameToString{ |
| 2443 | "linkopts": `["-Wl,--rpath,$${ORIGIN}"]`, |
| 2444 | }), |
| 2445 | }) |
| 2446 | } |