blob: 728a4dc5f936ba45fb1cc2e21883ba1f22581b88 [file] [log] [blame]
Jingwen Chen63930982021-03-24 10:04:33 -04001// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package bp2build
16
17import (
Jingwen Chen6ada5892021-09-17 11:38:09 +000018 "fmt"
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux1c92aef2021-08-23 16:10:00 +000019 "testing"
20
Jingwen Chen63930982021-03-24 10:04:33 -040021 "android/soong/android"
22 "android/soong/cc"
Jingwen Chen63930982021-03-24 10:04:33 -040023)
24
25const (
26 // See cc/testing.go for more context
27 soongCcLibraryPreamble = `
28cc_defaults {
Liz Kammer8337ea42021-09-10 10:06:32 -040029 name: "linux_bionic_supported",
Liz Kammerbaced712022-09-16 09:01:29 -040030}
31`
32
33 soongCcVersionLibBpPath = "build/soong/cc/libbuildversion/Android.bp"
34 soongCcVersionLibBp = `
35cc_library_static {
36 name: "libbuildversion",
37 bazel_module: { bp2build_available: false },
38}
39`
Liz Kammer12615db2021-09-28 09:19:17 -040040
41 soongCcProtoLibraries = `
42cc_library {
43 name: "libprotobuf-cpp-lite",
44 bazel_module: { bp2build_available: false },
45}
46
47cc_library {
48 name: "libprotobuf-cpp-full",
49 bazel_module: { bp2build_available: false },
50}`
51
52 soongCcProtoPreamble = soongCcLibraryPreamble + soongCcProtoLibraries
Jingwen Chen63930982021-03-24 10:04:33 -040053)
54
Sam Delmerico3177a6e2022-06-21 19:28:33 +000055func runCcLibraryTestCase(t *testing.T, tc Bp2buildTestCase) {
Liz Kammere4982e82021-05-25 10:39:35 -040056 t.Helper()
Sam Delmerico3177a6e2022-06-21 19:28:33 +000057 RunBp2BuildTestCase(t, registerCcLibraryModuleTypes, tc)
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020058}
59
60func registerCcLibraryModuleTypes(ctx android.RegistrationContext) {
61 cc.RegisterCCBuildComponents(ctx)
Jingwen Chen14a8bda2021-06-02 11:10:02 +000062 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020063 ctx.RegisterModuleType("cc_library_static", cc.LibraryStaticFactory)
Liz Kammer2d7bbe32021-06-10 18:20:06 -040064 ctx.RegisterModuleType("cc_prebuilt_library_static", cc.PrebuiltStaticLibraryFactory)
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020065 ctx.RegisterModuleType("cc_library_headers", cc.LibraryHeaderFactory)
66}
67
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020068func TestCcLibrarySimple(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +000069 runCcLibraryTestCase(t, Bp2buildTestCase{
70 Description: "cc_library - simple example",
71 ModuleTypeUnderTest: "cc_library",
72 ModuleTypeUnderTestFactory: cc.LibraryFactory,
73 Filesystem: map[string]string{
Liz Kammerbaced712022-09-16 09:01:29 -040074 soongCcVersionLibBpPath: soongCcVersionLibBp,
75 "android.cpp": "",
76 "bionic.cpp": "",
77 "darwin.cpp": "",
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020078 // Refer to cc.headerExts for the supported header extensions in Soong.
79 "header.h": "",
80 "header.hh": "",
81 "header.hpp": "",
82 "header.hxx": "",
83 "header.h++": "",
84 "header.inl": "",
85 "header.inc": "",
86 "header.ipp": "",
87 "header.h.generic": "",
88 "impl.cpp": "",
89 "linux.cpp": "",
90 "x86.cpp": "",
91 "x86_64.cpp": "",
92 "foo-dir/a.h": "",
93 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +000094 Blueprint: soongCcLibraryPreamble +
Liz Kammer78cfdaa2021-11-08 12:56:31 -050095 simpleModuleDoNotConvertBp2build("cc_library_headers", "some-headers") + `
Jingwen Chen63930982021-03-24 10:04:33 -040096cc_library {
97 name: "foo-lib",
98 srcs: ["impl.cpp"],
99 cflags: ["-Wall"],
100 header_libs: ["some-headers"],
101 export_include_dirs: ["foo-dir"],
102 ldflags: ["-Wl,--exclude-libs=bar.a"],
103 arch: {
104 x86: {
105 ldflags: ["-Wl,--exclude-libs=baz.a"],
106 srcs: ["x86.cpp"],
107 },
108 x86_64: {
109 ldflags: ["-Wl,--exclude-libs=qux.a"],
110 srcs: ["x86_64.cpp"],
111 },
112 },
113 target: {
114 android: {
115 srcs: ["android.cpp"],
116 },
117 linux_glibc: {
118 srcs: ["linux.cpp"],
119 },
120 darwin: {
121 srcs: ["darwin.cpp"],
122 },
Liz Kammer01a16e82021-07-16 16:33:47 -0400123 bionic: {
124 srcs: ["bionic.cpp"]
125 },
Jingwen Chen63930982021-03-24 10:04:33 -0400126 },
Liz Kammer8337ea42021-09-10 10:06:32 -0400127 include_build_directory: false,
Yu Liufc603162022-03-01 15:44:08 -0800128 sdk_version: "current",
129 min_sdk_version: "29",
Yu Liua79c9462022-03-22 16:35:22 -0700130 use_version_lib: true,
Jingwen Chen63930982021-03-24 10:04:33 -0400131}
132`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000133 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500134 "copts": `["-Wall"]`,
135 "export_includes": `["foo-dir"]`,
136 "implementation_deps": `[":some-headers"]`,
137 "linkopts": `["-Wl,--exclude-libs=bar.a"] + select({
Jingwen Chened9c17d2021-04-13 07:14:55 +0000138 "//build/bazel/platforms/arch:x86": ["-Wl,--exclude-libs=baz.a"],
139 "//build/bazel/platforms/arch:x86_64": ["-Wl,--exclude-libs=qux.a"],
140 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500141 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500142 "srcs": `["impl.cpp"] + select({
Jingwen Chenb4628eb2021-04-08 14:40:57 +0000143 "//build/bazel/platforms/arch:x86": ["x86.cpp"],
144 "//build/bazel/platforms/arch:x86_64": ["x86_64.cpp"],
Jingwen Chen63930982021-03-24 10:04:33 -0400145 "//conditions:default": [],
146 }) + select({
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400147 "//build/bazel/platforms/os:android": [
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400148 "bionic.cpp",
Liz Kammerfdd72e62021-10-11 15:41:03 -0400149 "android.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400150 ],
Jingwen Chenb4628eb2021-04-08 14:40:57 +0000151 "//build/bazel/platforms/os:darwin": ["darwin.cpp"],
152 "//build/bazel/platforms/os:linux": ["linux.cpp"],
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400153 "//build/bazel/platforms/os:linux_bionic": ["bionic.cpp"],
Liz Kammer01a16e82021-07-16 16:33:47 -0400154 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500155 })`,
Liz Kammerbaced712022-09-16 09:01:29 -0400156 "sdk_version": `"current"`,
157 "min_sdk_version": `"29"`,
158 "use_version_lib": `True`,
159 "implementation_whole_archive_deps": `["//build/soong/cc/libbuildversion:libbuildversion"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500160 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500161 })
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200162}
163
164func TestCcLibraryTrimmedLdAndroid(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000165 runCcLibraryTestCase(t, Bp2buildTestCase{
166 Description: "cc_library - trimmed example of //bionic/linker:ld-android",
167 ModuleTypeUnderTest: "cc_library",
168 ModuleTypeUnderTestFactory: cc.LibraryFactory,
169 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200170 "ld-android.cpp": "",
171 "linked_list.h": "",
172 "linker.h": "",
173 "linker_block_allocator.h": "",
174 "linker_cfi.h": "",
Jingwen Chen63930982021-03-24 10:04:33 -0400175 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000176 Blueprint: soongCcLibraryPreamble +
Liz Kammerbe46fcc2021-11-01 15:32:43 -0400177 simpleModuleDoNotConvertBp2build("cc_library_headers", "libc_headers") + `
Jingwen Chen63930982021-03-24 10:04:33 -0400178cc_library {
179 name: "fake-ld-android",
180 srcs: ["ld_android.cpp"],
181 cflags: [
182 "-Wall",
183 "-Wextra",
184 "-Wunused",
185 "-Werror",
186 ],
187 header_libs: ["libc_headers"],
188 ldflags: [
189 "-Wl,--exclude-libs=libgcc.a",
190 "-Wl,--exclude-libs=libgcc_stripped.a",
191 "-Wl,--exclude-libs=libclang_rt.builtins-arm-android.a",
192 "-Wl,--exclude-libs=libclang_rt.builtins-aarch64-android.a",
193 "-Wl,--exclude-libs=libclang_rt.builtins-i686-android.a",
194 "-Wl,--exclude-libs=libclang_rt.builtins-x86_64-android.a",
195 ],
196 arch: {
197 x86: {
198 ldflags: ["-Wl,--exclude-libs=libgcc_eh.a"],
199 },
200 x86_64: {
201 ldflags: ["-Wl,--exclude-libs=libgcc_eh.a"],
202 },
203 },
Liz Kammer8337ea42021-09-10 10:06:32 -0400204 include_build_directory: false,
Jingwen Chen63930982021-03-24 10:04:33 -0400205}
206`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000207 ExpectedBazelTargets: makeCcLibraryTargets("fake-ld-android", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500208 "srcs": `["ld_android.cpp"]`,
209 "copts": `[
Jingwen Chen63930982021-03-24 10:04:33 -0400210 "-Wall",
211 "-Wextra",
212 "-Wunused",
213 "-Werror",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500214 ]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500215 "implementation_deps": `[":libc_headers"]`,
216 "linkopts": `[
Jingwen Chen63930982021-03-24 10:04:33 -0400217 "-Wl,--exclude-libs=libgcc.a",
218 "-Wl,--exclude-libs=libgcc_stripped.a",
219 "-Wl,--exclude-libs=libclang_rt.builtins-arm-android.a",
220 "-Wl,--exclude-libs=libclang_rt.builtins-aarch64-android.a",
221 "-Wl,--exclude-libs=libclang_rt.builtins-i686-android.a",
222 "-Wl,--exclude-libs=libclang_rt.builtins-x86_64-android.a",
223 ] + select({
Jingwen Chenb4628eb2021-04-08 14:40:57 +0000224 "//build/bazel/platforms/arch:x86": ["-Wl,--exclude-libs=libgcc_eh.a"],
225 "//build/bazel/platforms/arch:x86_64": ["-Wl,--exclude-libs=libgcc_eh.a"],
Jingwen Chen63930982021-03-24 10:04:33 -0400226 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500227 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500228 }),
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200229 })
230}
231
232func TestCcLibraryExcludeSrcs(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000233 runCcLibraryTestCase(t, Bp2buildTestCase{
234 Description: "cc_library exclude_srcs - trimmed example of //external/arm-optimized-routines:libarm-optimized-routines-math",
235 ModuleTypeUnderTest: "cc_library",
236 ModuleTypeUnderTestFactory: cc.LibraryFactory,
237 Dir: "external",
238 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200239 "external/math/cosf.c": "",
240 "external/math/erf.c": "",
241 "external/math/erf_data.c": "",
242 "external/math/erff.c": "",
243 "external/math/erff_data.c": "",
244 "external/Android.bp": `
Jingwen Chen4ecc67d2021-04-27 09:47:02 +0000245cc_library {
246 name: "fake-libarm-optimized-routines-math",
247 exclude_srcs: [
248 // Provided by:
249 // bionic/libm/upstream-freebsd/lib/msun/src/s_erf.c
250 // bionic/libm/upstream-freebsd/lib/msun/src/s_erff.c
251 "math/erf.c",
252 "math/erf_data.c",
253 "math/erff.c",
254 "math/erff_data.c",
255 ],
256 srcs: [
257 "math/*.c",
258 ],
259 // arch-specific settings
260 arch: {
261 arm64: {
262 cflags: [
263 "-DHAVE_FAST_FMA=1",
264 ],
265 },
266 },
267 bazel_module: { bp2build_available: true },
268}
269`,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200270 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000271 Blueprint: soongCcLibraryPreamble,
272 ExpectedBazelTargets: makeCcLibraryTargets("fake-libarm-optimized-routines-math", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500273 "copts": `select({
Jingwen Chen4ecc67d2021-04-27 09:47:02 +0000274 "//build/bazel/platforms/arch:arm64": ["-DHAVE_FAST_FMA=1"],
275 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500276 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500277 "local_includes": `["."]`,
278 "srcs_c": `["math/cosf.c"]`,
279 }),
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200280 })
281}
282
283func TestCcLibrarySharedStaticProps(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000284 runCcLibraryTestCase(t, Bp2buildTestCase{
285 Description: "cc_library shared/static props",
286 ModuleTypeUnderTest: "cc_library",
287 ModuleTypeUnderTestFactory: cc.LibraryFactory,
288 Filesystem: map[string]string{
Liz Kammer8337ea42021-09-10 10:06:32 -0400289 "both.cpp": "",
290 "sharedonly.cpp": "",
291 "staticonly.cpp": "",
292 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000293 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen53681ef2021-04-29 08:15:13 +0000294cc_library {
295 name: "a",
Chris Parsons08648312021-05-06 16:23:19 -0400296 srcs: ["both.cpp"],
297 cflags: ["bothflag"],
298 shared_libs: ["shared_dep_for_both"],
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400299 static_libs: ["static_dep_for_both", "whole_and_static_lib_for_both"],
300 whole_static_libs: ["whole_static_lib_for_both", "whole_and_static_lib_for_both"],
Chris Parsons08648312021-05-06 16:23:19 -0400301 static: {
302 srcs: ["staticonly.cpp"],
303 cflags: ["staticflag"],
304 shared_libs: ["shared_dep_for_static"],
305 static_libs: ["static_dep_for_static"],
306 whole_static_libs: ["whole_static_lib_for_static"],
307 },
308 shared: {
309 srcs: ["sharedonly.cpp"],
310 cflags: ["sharedflag"],
311 shared_libs: ["shared_dep_for_shared"],
312 static_libs: ["static_dep_for_shared"],
313 whole_static_libs: ["whole_static_lib_for_shared"],
314 },
Liz Kammer8337ea42021-09-10 10:06:32 -0400315 include_build_directory: false,
Jingwen Chen53681ef2021-04-29 08:15:13 +0000316}
317
Liz Kammer8337ea42021-09-10 10:06:32 -0400318cc_library_static {
319 name: "static_dep_for_shared",
320 bazel_module: { bp2build_available: false },
321}
Chris Parsons08648312021-05-06 16:23:19 -0400322
Liz Kammer8337ea42021-09-10 10:06:32 -0400323cc_library_static {
324 name: "static_dep_for_static",
325 bazel_module: { bp2build_available: false },
326}
Chris Parsons08648312021-05-06 16:23:19 -0400327
Liz Kammer8337ea42021-09-10 10:06:32 -0400328cc_library_static {
329 name: "static_dep_for_both",
330 bazel_module: { bp2build_available: false },
331}
Chris Parsons08648312021-05-06 16:23:19 -0400332
Liz Kammer8337ea42021-09-10 10:06:32 -0400333cc_library_static {
334 name: "whole_static_lib_for_shared",
335 bazel_module: { bp2build_available: false },
336}
Chris Parsons08648312021-05-06 16:23:19 -0400337
Liz Kammer8337ea42021-09-10 10:06:32 -0400338cc_library_static {
339 name: "whole_static_lib_for_static",
340 bazel_module: { bp2build_available: false },
341}
Chris Parsons08648312021-05-06 16:23:19 -0400342
Liz Kammer8337ea42021-09-10 10:06:32 -0400343cc_library_static {
344 name: "whole_static_lib_for_both",
345 bazel_module: { bp2build_available: false },
346}
Chris Parsons08648312021-05-06 16:23:19 -0400347
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400348cc_library_static {
349 name: "whole_and_static_lib_for_both",
350 bazel_module: { bp2build_available: false },
351}
352
Liz Kammer8337ea42021-09-10 10:06:32 -0400353cc_library {
354 name: "shared_dep_for_shared",
355 bazel_module: { bp2build_available: false },
356}
Chris Parsons08648312021-05-06 16:23:19 -0400357
Liz Kammer8337ea42021-09-10 10:06:32 -0400358cc_library {
359 name: "shared_dep_for_static",
360 bazel_module: { bp2build_available: false },
361}
Chris Parsons08648312021-05-06 16:23:19 -0400362
Liz Kammer8337ea42021-09-10 10:06:32 -0400363cc_library {
364 name: "shared_dep_for_both",
365 bazel_module: { bp2build_available: false },
366}
Jingwen Chen53681ef2021-04-29 08:15:13 +0000367`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000368 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000369 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500370 "copts": `[
371 "bothflag",
372 "staticflag",
373 ]`,
374 "implementation_deps": `[
375 ":static_dep_for_both",
376 ":static_dep_for_static",
377 ]`,
378 "implementation_dynamic_deps": `[
379 ":shared_dep_for_both",
380 ":shared_dep_for_static",
381 ]`,
382 "srcs": `[
383 "both.cpp",
384 "staticonly.cpp",
385 ]`,
386 "whole_archive_deps": `[
387 ":whole_static_lib_for_both",
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400388 ":whole_and_static_lib_for_both",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500389 ":whole_static_lib_for_static",
390 ]`}),
Alixe06d75b2022-08-31 18:28:19 +0000391 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500392 "copts": `[
393 "bothflag",
394 "sharedflag",
395 ]`,
396 "implementation_deps": `[
397 ":static_dep_for_both",
398 ":static_dep_for_shared",
399 ]`,
400 "implementation_dynamic_deps": `[
401 ":shared_dep_for_both",
402 ":shared_dep_for_shared",
403 ]`,
404 "srcs": `[
405 "both.cpp",
406 "sharedonly.cpp",
407 ]`,
408 "whole_archive_deps": `[
409 ":whole_static_lib_for_both",
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400410 ":whole_and_static_lib_for_both",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500411 ":whole_static_lib_for_shared",
412 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500413 }),
414 },
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200415 })
416}
417
Liz Kammer7a210ac2021-09-22 15:52:58 -0400418func TestCcLibraryDeps(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000419 runCcLibraryTestCase(t, Bp2buildTestCase{
420 Description: "cc_library shared/static props",
421 ModuleTypeUnderTest: "cc_library",
422 ModuleTypeUnderTestFactory: cc.LibraryFactory,
423 Filesystem: map[string]string{
Liz Kammer7a210ac2021-09-22 15:52:58 -0400424 "both.cpp": "",
425 "sharedonly.cpp": "",
426 "staticonly.cpp": "",
427 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000428 Blueprint: soongCcLibraryPreamble + `
Liz Kammer7a210ac2021-09-22 15:52:58 -0400429cc_library {
430 name: "a",
431 srcs: ["both.cpp"],
432 cflags: ["bothflag"],
433 shared_libs: ["implementation_shared_dep_for_both", "shared_dep_for_both"],
434 export_shared_lib_headers: ["shared_dep_for_both"],
435 static_libs: ["implementation_static_dep_for_both", "static_dep_for_both"],
436 export_static_lib_headers: ["static_dep_for_both", "whole_static_dep_for_both"],
437 whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_both", "whole_static_dep_for_both"],
438 static: {
439 srcs: ["staticonly.cpp"],
440 cflags: ["staticflag"],
441 shared_libs: ["implementation_shared_dep_for_static", "shared_dep_for_static"],
442 export_shared_lib_headers: ["shared_dep_for_static"],
443 static_libs: ["implementation_static_dep_for_static", "static_dep_for_static"],
444 export_static_lib_headers: ["static_dep_for_static", "whole_static_dep_for_static"],
445 whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_static", "whole_static_dep_for_static"],
446 },
447 shared: {
448 srcs: ["sharedonly.cpp"],
449 cflags: ["sharedflag"],
450 shared_libs: ["implementation_shared_dep_for_shared", "shared_dep_for_shared"],
451 export_shared_lib_headers: ["shared_dep_for_shared"],
452 static_libs: ["implementation_static_dep_for_shared", "static_dep_for_shared"],
453 export_static_lib_headers: ["static_dep_for_shared", "whole_static_dep_for_shared"],
454 whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_shared", "whole_static_dep_for_shared"],
455 },
456 include_build_directory: false,
457}
458` + simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_shared") +
459 simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_shared") +
460 simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_static") +
461 simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_static") +
462 simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_both") +
463 simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_both") +
464 simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_shared") +
465 simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_shared") +
466 simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_static") +
467 simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_static") +
468 simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_both") +
469 simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_both") +
470 simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_shared") +
471 simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_shared") +
472 simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_static") +
473 simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_static") +
474 simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_both") +
475 simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_both"),
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000476 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000477 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500478 "copts": `[
479 "bothflag",
480 "staticflag",
481 ]`,
482 "deps": `[
483 ":static_dep_for_both",
484 ":static_dep_for_static",
485 ]`,
486 "dynamic_deps": `[
487 ":shared_dep_for_both",
488 ":shared_dep_for_static",
489 ]`,
490 "implementation_deps": `[
491 ":implementation_static_dep_for_both",
492 ":implementation_static_dep_for_static",
493 ]`,
494 "implementation_dynamic_deps": `[
495 ":implementation_shared_dep_for_both",
496 ":implementation_shared_dep_for_static",
497 ]`,
498 "srcs": `[
499 "both.cpp",
500 "staticonly.cpp",
501 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500502 "whole_archive_deps": `[
Liz Kammer7a210ac2021-09-22 15:52:58 -0400503 ":not_explicitly_exported_whole_static_dep_for_both",
504 ":whole_static_dep_for_both",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500505 ":not_explicitly_exported_whole_static_dep_for_static",
506 ":whole_static_dep_for_static",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500507 ]`,
508 }),
Alixe06d75b2022-08-31 18:28:19 +0000509 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500510 "copts": `[
511 "bothflag",
512 "sharedflag",
513 ]`,
514 "deps": `[
515 ":static_dep_for_both",
516 ":static_dep_for_shared",
517 ]`,
518 "dynamic_deps": `[
519 ":shared_dep_for_both",
520 ":shared_dep_for_shared",
521 ]`,
522 "implementation_deps": `[
523 ":implementation_static_dep_for_both",
524 ":implementation_static_dep_for_shared",
525 ]`,
526 "implementation_dynamic_deps": `[
527 ":implementation_shared_dep_for_both",
528 ":implementation_shared_dep_for_shared",
529 ]`,
530 "srcs": `[
531 "both.cpp",
532 "sharedonly.cpp",
533 ]`,
534 "whole_archive_deps": `[
535 ":not_explicitly_exported_whole_static_dep_for_both",
536 ":whole_static_dep_for_both",
537 ":not_explicitly_exported_whole_static_dep_for_shared",
538 ":whole_static_dep_for_shared",
539 ]`,
540 })},
541 },
542 )
Liz Kammer7a210ac2021-09-22 15:52:58 -0400543}
544
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400545func TestCcLibraryWholeStaticLibsAlwaysLink(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000546 runCcLibraryTestCase(t, Bp2buildTestCase{
547 ModuleTypeUnderTest: "cc_library",
548 ModuleTypeUnderTestFactory: cc.LibraryFactory,
549 Dir: "foo/bar",
550 Filesystem: map[string]string{
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400551 "foo/bar/Android.bp": `
552cc_library {
553 name: "a",
554 whole_static_libs: ["whole_static_lib_for_both"],
555 static: {
556 whole_static_libs: ["whole_static_lib_for_static"],
557 },
558 shared: {
559 whole_static_libs: ["whole_static_lib_for_shared"],
560 },
561 bazel_module: { bp2build_available: true },
Liz Kammer8337ea42021-09-10 10:06:32 -0400562 include_build_directory: false,
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400563}
564
565cc_prebuilt_library_static { name: "whole_static_lib_for_shared" }
566
567cc_prebuilt_library_static { name: "whole_static_lib_for_static" }
568
569cc_prebuilt_library_static { name: "whole_static_lib_for_both" }
570`,
571 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000572 Blueprint: soongCcLibraryPreamble,
573 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000574 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500575 "whole_archive_deps": `[
576 ":whole_static_lib_for_both_alwayslink",
577 ":whole_static_lib_for_static_alwayslink",
578 ]`,
579 }),
Alixe06d75b2022-08-31 18:28:19 +0000580 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500581 "whole_archive_deps": `[
582 ":whole_static_lib_for_both_alwayslink",
583 ":whole_static_lib_for_shared_alwayslink",
584 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500585 }),
586 },
Chris Parsons77acf2e2021-12-03 17:27:16 -0500587 },
588 )
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400589}
590
Jingwen Chenbcf53042021-05-26 04:42:42 +0000591func TestCcLibrarySharedStaticPropsInArch(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000592 runCcLibraryTestCase(t, Bp2buildTestCase{
593 Description: "cc_library shared/static props in arch",
594 ModuleTypeUnderTest: "cc_library",
595 ModuleTypeUnderTestFactory: cc.LibraryFactory,
596 Dir: "foo/bar",
597 Filesystem: map[string]string{
Jingwen Chenbcf53042021-05-26 04:42:42 +0000598 "foo/bar/arm.cpp": "",
599 "foo/bar/x86.cpp": "",
600 "foo/bar/sharedonly.cpp": "",
601 "foo/bar/staticonly.cpp": "",
602 "foo/bar/Android.bp": `
603cc_library {
604 name: "a",
605 arch: {
606 arm: {
607 shared: {
608 srcs: ["arm_shared.cpp"],
609 cflags: ["-DARM_SHARED"],
610 static_libs: ["arm_static_dep_for_shared"],
611 whole_static_libs: ["arm_whole_static_dep_for_shared"],
612 shared_libs: ["arm_shared_dep_for_shared"],
613 },
614 },
615 x86: {
616 static: {
617 srcs: ["x86_static.cpp"],
618 cflags: ["-DX86_STATIC"],
619 static_libs: ["x86_dep_for_static"],
620 },
621 },
622 },
623 target: {
624 android: {
625 shared: {
626 srcs: ["android_shared.cpp"],
627 cflags: ["-DANDROID_SHARED"],
628 static_libs: ["android_dep_for_shared"],
629 },
630 },
631 android_arm: {
632 shared: {
633 cflags: ["-DANDROID_ARM_SHARED"],
634 },
635 },
636 },
637 srcs: ["both.cpp"],
638 cflags: ["bothflag"],
639 static_libs: ["static_dep_for_both"],
640 static: {
641 srcs: ["staticonly.cpp"],
642 cflags: ["staticflag"],
643 static_libs: ["static_dep_for_static"],
644 },
645 shared: {
646 srcs: ["sharedonly.cpp"],
647 cflags: ["sharedflag"],
648 static_libs: ["static_dep_for_shared"],
649 },
650 bazel_module: { bp2build_available: true },
651}
652
653cc_library_static { name: "static_dep_for_shared" }
654cc_library_static { name: "static_dep_for_static" }
655cc_library_static { name: "static_dep_for_both" }
656
657cc_library_static { name: "arm_static_dep_for_shared" }
658cc_library_static { name: "arm_whole_static_dep_for_shared" }
659cc_library_static { name: "arm_shared_dep_for_shared" }
660
661cc_library_static { name: "x86_dep_for_static" }
662
663cc_library_static { name: "android_dep_for_shared" }
664`,
665 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000666 Blueprint: soongCcLibraryPreamble,
667 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000668 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500669 "copts": `[
670 "bothflag",
671 "staticflag",
672 ] + select({
673 "//build/bazel/platforms/arch:x86": ["-DX86_STATIC"],
674 "//conditions:default": [],
675 })`,
676 "implementation_deps": `[
677 ":static_dep_for_both",
678 ":static_dep_for_static",
679 ] + select({
680 "//build/bazel/platforms/arch:x86": [":x86_dep_for_static"],
681 "//conditions:default": [],
682 })`,
683 "local_includes": `["."]`,
684 "srcs": `[
685 "both.cpp",
686 "staticonly.cpp",
687 ] + select({
688 "//build/bazel/platforms/arch:x86": ["x86_static.cpp"],
689 "//conditions:default": [],
690 })`,
691 }),
Alixe06d75b2022-08-31 18:28:19 +0000692 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500693 "copts": `[
694 "bothflag",
695 "sharedflag",
696 ] + select({
697 "//build/bazel/platforms/arch:arm": ["-DARM_SHARED"],
698 "//conditions:default": [],
699 }) + select({
700 "//build/bazel/platforms/os:android": ["-DANDROID_SHARED"],
701 "//conditions:default": [],
702 }) + select({
703 "//build/bazel/platforms/os_arch:android_arm": ["-DANDROID_ARM_SHARED"],
704 "//conditions:default": [],
705 })`,
706 "implementation_deps": `[
707 ":static_dep_for_both",
708 ":static_dep_for_shared",
709 ] + select({
710 "//build/bazel/platforms/arch:arm": [":arm_static_dep_for_shared"],
711 "//conditions:default": [],
712 }) + select({
713 "//build/bazel/platforms/os:android": [":android_dep_for_shared"],
714 "//conditions:default": [],
715 })`,
716 "implementation_dynamic_deps": `select({
717 "//build/bazel/platforms/arch:arm": [":arm_shared_dep_for_shared"],
718 "//conditions:default": [],
719 })`,
720 "local_includes": `["."]`,
721 "srcs": `[
722 "both.cpp",
723 "sharedonly.cpp",
724 ] + select({
725 "//build/bazel/platforms/arch:arm": ["arm_shared.cpp"],
726 "//conditions:default": [],
727 }) + select({
728 "//build/bazel/platforms/os:android": ["android_shared.cpp"],
729 "//conditions:default": [],
730 })`,
731 "whole_archive_deps": `select({
732 "//build/bazel/platforms/arch:arm": [":arm_whole_static_dep_for_shared"],
733 "//conditions:default": [],
734 })`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500735 }),
736 },
Chris Parsons77acf2e2021-12-03 17:27:16 -0500737 },
738 )
Jingwen Chenbcf53042021-05-26 04:42:42 +0000739}
740
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000741func TestCcLibrarySharedStaticPropsWithMixedSources(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000742 runCcLibraryTestCase(t, Bp2buildTestCase{
743 Description: "cc_library shared/static props with c/cpp/s mixed sources",
744 ModuleTypeUnderTest: "cc_library",
745 ModuleTypeUnderTestFactory: cc.LibraryFactory,
746 Dir: "foo/bar",
747 Filesystem: map[string]string{
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000748 "foo/bar/both_source.cpp": "",
749 "foo/bar/both_source.cc": "",
750 "foo/bar/both_source.c": "",
751 "foo/bar/both_source.s": "",
752 "foo/bar/both_source.S": "",
753 "foo/bar/shared_source.cpp": "",
754 "foo/bar/shared_source.cc": "",
755 "foo/bar/shared_source.c": "",
756 "foo/bar/shared_source.s": "",
757 "foo/bar/shared_source.S": "",
758 "foo/bar/static_source.cpp": "",
759 "foo/bar/static_source.cc": "",
760 "foo/bar/static_source.c": "",
761 "foo/bar/static_source.s": "",
762 "foo/bar/static_source.S": "",
763 "foo/bar/Android.bp": `
764cc_library {
765 name: "a",
766 srcs: [
Liz Kammerd366c902021-06-03 13:43:01 -0400767 "both_source.cpp",
768 "both_source.cc",
769 "both_source.c",
770 "both_source.s",
771 "both_source.S",
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400772 ":both_filegroup",
Liz Kammerd366c902021-06-03 13:43:01 -0400773 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000774 static: {
Liz Kammer8337ea42021-09-10 10:06:32 -0400775 srcs: [
776 "static_source.cpp",
777 "static_source.cc",
778 "static_source.c",
779 "static_source.s",
780 "static_source.S",
781 ":static_filegroup",
782 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000783 },
784 shared: {
Liz Kammer8337ea42021-09-10 10:06:32 -0400785 srcs: [
786 "shared_source.cpp",
787 "shared_source.cc",
788 "shared_source.c",
789 "shared_source.s",
790 "shared_source.S",
791 ":shared_filegroup",
792 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000793 },
794 bazel_module: { bp2build_available: true },
795}
796
797filegroup {
798 name: "both_filegroup",
799 srcs: [
800 // Not relevant, handled by filegroup macro
Liz Kammerd366c902021-06-03 13:43:01 -0400801 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000802}
803
804filegroup {
805 name: "shared_filegroup",
806 srcs: [
807 // Not relevant, handled by filegroup macro
Liz Kammerd366c902021-06-03 13:43:01 -0400808 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000809}
810
811filegroup {
812 name: "static_filegroup",
813 srcs: [
814 // Not relevant, handled by filegroup macro
Liz Kammerd366c902021-06-03 13:43:01 -0400815 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000816}
817`,
818 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000819 Blueprint: soongCcLibraryPreamble,
820 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000821 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500822 "local_includes": `["."]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500823 "srcs": `[
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000824 "both_source.cpp",
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400825 "both_source.cc",
826 ":both_filegroup_cpp_srcs",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500827 "static_source.cpp",
828 "static_source.cc",
829 ":static_filegroup_cpp_srcs",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500830 ]`,
831 "srcs_as": `[
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000832 "both_source.s",
833 "both_source.S",
834 ":both_filegroup_as_srcs",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500835 "static_source.s",
836 "static_source.S",
837 ":static_filegroup_as_srcs",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500838 ]`,
839 "srcs_c": `[
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000840 "both_source.c",
841 ":both_filegroup_c_srcs",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500842 "static_source.c",
843 ":static_filegroup_c_srcs",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500844 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500845 }),
Alixe06d75b2022-08-31 18:28:19 +0000846 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500847 "local_includes": `["."]`,
848 "srcs": `[
849 "both_source.cpp",
850 "both_source.cc",
851 ":both_filegroup_cpp_srcs",
852 "shared_source.cpp",
853 "shared_source.cc",
854 ":shared_filegroup_cpp_srcs",
855 ]`,
856 "srcs_as": `[
857 "both_source.s",
858 "both_source.S",
859 ":both_filegroup_as_srcs",
860 "shared_source.s",
861 "shared_source.S",
862 ":shared_filegroup_as_srcs",
863 ]`,
864 "srcs_c": `[
865 "both_source.c",
866 ":both_filegroup_c_srcs",
867 "shared_source.c",
868 ":shared_filegroup_c_srcs",
869 ]`,
870 })}})
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000871}
872
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000873func TestCcLibraryNonConfiguredVersionScriptAndDynamicList(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000874 runCcLibraryTestCase(t, Bp2buildTestCase{
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000875 Description: "cc_library non-configured version script and dynamic list",
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000876 ModuleTypeUnderTest: "cc_library",
877 ModuleTypeUnderTestFactory: cc.LibraryFactory,
878 Dir: "foo/bar",
879 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200880 "foo/bar/Android.bp": `
Lukacs T. Berki1353e592021-04-30 15:35:09 +0200881cc_library {
882 name: "a",
883 srcs: ["a.cpp"],
884 version_script: "v.map",
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000885 dynamic_list: "dynamic.list",
Lukacs T. Berki1353e592021-04-30 15:35:09 +0200886 bazel_module: { bp2build_available: true },
Liz Kammer8337ea42021-09-10 10:06:32 -0400887 include_build_directory: false,
Lukacs T. Berki1353e592021-04-30 15:35:09 +0200888}
889`,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200890 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000891 Blueprint: soongCcLibraryPreamble,
892 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000893 "additional_linker_inputs": `[
894 "v.map",
895 "dynamic.list",
896 ]`,
897 "linkopts": `[
898 "-Wl,--version-script,$(location v.map)",
899 "-Wl,--dynamic-list,$(location dynamic.list)",
900 ]`,
901 "srcs": `["a.cpp"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500902 }),
903 },
904 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200905}
906
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000907func TestCcLibraryConfiguredVersionScriptAndDynamicList(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000908 runCcLibraryTestCase(t, Bp2buildTestCase{
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000909 Description: "cc_library configured version script and dynamic list",
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000910 ModuleTypeUnderTest: "cc_library",
911 ModuleTypeUnderTestFactory: cc.LibraryFactory,
912 Dir: "foo/bar",
913 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200914 "foo/bar/Android.bp": `
Liz Kammer8337ea42021-09-10 10:06:32 -0400915cc_library {
916 name: "a",
917 srcs: ["a.cpp"],
918 arch: {
919 arm: {
920 version_script: "arm.map",
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000921 dynamic_list: "dynamic_arm.list",
Liz Kammer8337ea42021-09-10 10:06:32 -0400922 },
923 arm64: {
924 version_script: "arm64.map",
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000925 dynamic_list: "dynamic_arm64.list",
Liz Kammer8337ea42021-09-10 10:06:32 -0400926 },
927 },
Lukacs T. Berki56bb0832021-05-12 12:36:45 +0200928
Liz Kammer8337ea42021-09-10 10:06:32 -0400929 bazel_module: { bp2build_available: true },
930 include_build_directory: false,
931}
Liz Kammerd366c902021-06-03 13:43:01 -0400932 `,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200933 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000934 Blueprint: soongCcLibraryPreamble,
935 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500936 "additional_linker_inputs": `select({
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000937 "//build/bazel/platforms/arch:arm": [
938 "arm.map",
939 "dynamic_arm.list",
940 ],
941 "//build/bazel/platforms/arch:arm64": [
942 "arm64.map",
943 "dynamic_arm64.list",
944 ],
Liz Kammerd2871182021-10-04 13:54:37 -0400945 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500946 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500947 "linkopts": `select({
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000948 "//build/bazel/platforms/arch:arm": [
949 "-Wl,--version-script,$(location arm.map)",
950 "-Wl,--dynamic-list,$(location dynamic_arm.list)",
951 ],
952 "//build/bazel/platforms/arch:arm64": [
953 "-Wl,--version-script,$(location arm64.map)",
954 "-Wl,--dynamic-list,$(location dynamic_arm64.list)",
955 ],
Liz Kammerd2871182021-10-04 13:54:37 -0400956 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500957 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500958 "srcs": `["a.cpp"]`,
959 }),
960 },
961 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200962}
963
964func TestCcLibrarySharedLibs(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000965 runCcLibraryTestCase(t, Bp2buildTestCase{
966 Description: "cc_library shared_libs",
967 ModuleTypeUnderTest: "cc_library",
968 ModuleTypeUnderTestFactory: cc.LibraryFactory,
969 Blueprint: soongCcLibraryPreamble + `
Rupert Shuttleworthc50fa8d2021-05-06 02:40:33 -0400970cc_library {
971 name: "mylib",
Liz Kammer8337ea42021-09-10 10:06:32 -0400972 bazel_module: { bp2build_available: false },
Rupert Shuttleworthc50fa8d2021-05-06 02:40:33 -0400973}
974
975cc_library {
976 name: "a",
977 shared_libs: ["mylib",],
Liz Kammer8337ea42021-09-10 10:06:32 -0400978 include_build_directory: false,
Rupert Shuttleworthc50fa8d2021-05-06 02:40:33 -0400979}
980`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000981 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500982 "implementation_dynamic_deps": `[":mylib"]`,
983 }),
984 },
985 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200986}
987
Liz Kammer0eae52e2021-10-06 10:32:26 -0400988func TestCcLibraryFeatures(t *testing.T) {
Chris Parsons77acf2e2021-12-03 17:27:16 -0500989 expected_targets := []string{}
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000990 expected_targets = append(expected_targets, makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500991 "features": `[
992 "disable_pack_relocations",
993 "-no_undefined_symbols",
Yu Liu8d82ac52022-05-17 15:13:28 -0700994 "-coverage",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500995 ]`,
996 "srcs": `["a.cpp"]`,
997 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000998 expected_targets = append(expected_targets, makeCcLibraryTargets("b", AttrNameToString{
Yu Liu8d82ac52022-05-17 15:13:28 -0700999 "features": `["-coverage"] + select({
Chris Parsons77acf2e2021-12-03 17:27:16 -05001000 "//build/bazel/platforms/arch:x86_64": [
1001 "disable_pack_relocations",
1002 "-no_undefined_symbols",
1003 ],
1004 "//conditions:default": [],
1005 })`,
1006 "srcs": `["b.cpp"]`,
1007 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001008 expected_targets = append(expected_targets, makeCcLibraryTargets("c", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001009 "features": `select({
1010 "//build/bazel/platforms/os:darwin": [
1011 "disable_pack_relocations",
1012 "-no_undefined_symbols",
1013 ],
1014 "//conditions:default": [],
1015 })`,
1016 "srcs": `["c.cpp"]`,
1017 })...)
1018
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001019 runCcLibraryTestCase(t, Bp2buildTestCase{
1020 Description: "cc_library pack_relocations test",
1021 ModuleTypeUnderTest: "cc_library",
1022 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1023 Blueprint: soongCcLibraryPreamble + `
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001024cc_library {
1025 name: "a",
1026 srcs: ["a.cpp"],
1027 pack_relocations: false,
Liz Kammer0eae52e2021-10-06 10:32:26 -04001028 allow_undefined_symbols: true,
Liz Kammer8337ea42021-09-10 10:06:32 -04001029 include_build_directory: false,
Yu Liu8d82ac52022-05-17 15:13:28 -07001030 native_coverage: false,
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001031}
1032
1033cc_library {
1034 name: "b",
1035 srcs: ["b.cpp"],
1036 arch: {
1037 x86_64: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001038 pack_relocations: false,
Liz Kammer0eae52e2021-10-06 10:32:26 -04001039 allow_undefined_symbols: true,
Liz Kammer8337ea42021-09-10 10:06:32 -04001040 },
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001041 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001042 include_build_directory: false,
Yu Liu8d82ac52022-05-17 15:13:28 -07001043 native_coverage: false,
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001044}
1045
1046cc_library {
1047 name: "c",
1048 srcs: ["c.cpp"],
1049 target: {
1050 darwin: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001051 pack_relocations: false,
Liz Kammer0eae52e2021-10-06 10:32:26 -04001052 allow_undefined_symbols: true,
Liz Kammer8337ea42021-09-10 10:06:32 -04001053 },
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001054 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001055 include_build_directory: false,
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001056}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001057 ExpectedBazelTargets: expected_targets,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +02001058 })
1059}
1060
1061func TestCcLibrarySpacesInCopts(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001062 runCcLibraryTestCase(t, Bp2buildTestCase{
1063 Description: "cc_library spaces in copts",
1064 ModuleTypeUnderTest: "cc_library",
1065 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1066 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen3950cd62021-05-12 04:33:00 +00001067cc_library {
1068 name: "a",
1069 cflags: ["-include header.h",],
Liz Kammer8337ea42021-09-10 10:06:32 -04001070 include_build_directory: false,
Jingwen Chen3950cd62021-05-12 04:33:00 +00001071}
1072`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001073 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001074 "copts": `[
Jingwen Chen3950cd62021-05-12 04:33:00 +00001075 "-include",
1076 "header.h",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001077 ]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001078 }),
1079 },
1080 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +02001081}
1082
1083func TestCcLibraryCppFlagsGoesIntoCopts(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001084 runCcLibraryTestCase(t, Bp2buildTestCase{
1085 Description: "cc_library cppflags usage",
1086 ModuleTypeUnderTest: "cc_library",
1087 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1088 Blueprint: soongCcLibraryPreamble + `cc_library {
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001089 name: "a",
1090 srcs: ["a.cpp"],
Liz Kammer8337ea42021-09-10 10:06:32 -04001091 cflags: ["-Wall"],
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001092 cppflags: [
1093 "-fsigned-char",
1094 "-pedantic",
Liz Kammer8337ea42021-09-10 10:06:32 -04001095 ],
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001096 arch: {
1097 arm64: {
1098 cppflags: ["-DARM64=1"],
Liz Kammer8337ea42021-09-10 10:06:32 -04001099 },
Liz Kammerd366c902021-06-03 13:43:01 -04001100 },
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001101 target: {
1102 android: {
1103 cppflags: ["-DANDROID=1"],
Liz Kammer8337ea42021-09-10 10:06:32 -04001104 },
Liz Kammerd366c902021-06-03 13:43:01 -04001105 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001106 include_build_directory: false,
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001107}
1108`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001109 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001110 "copts": `["-Wall"]`,
1111 "cppflags": `[
Chris Parsons990c4f42021-05-25 12:10:58 -04001112 "-fsigned-char",
1113 "-pedantic",
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001114 ] + select({
1115 "//build/bazel/platforms/arch:arm64": ["-DARM64=1"],
1116 "//conditions:default": [],
1117 }) + select({
1118 "//build/bazel/platforms/os:android": ["-DANDROID=1"],
1119 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001120 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001121 "srcs": `["a.cpp"]`,
1122 }),
1123 },
1124 )
Jingwen Chen63930982021-03-24 10:04:33 -04001125}
Rupert Shuttleworth22cd2eb2021-05-27 02:15:54 -04001126
Liz Kammer47535c52021-06-02 16:02:22 -04001127func TestCcLibraryExcludeLibs(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001128 runCcLibraryTestCase(t, Bp2buildTestCase{
1129 ModuleTypeUnderTest: "cc_library",
1130 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1131 Filesystem: map[string]string{},
1132 Blueprint: soongCcLibraryStaticPreamble + `
Liz Kammer47535c52021-06-02 16:02:22 -04001133cc_library {
1134 name: "foo_static",
1135 srcs: ["common.c"],
1136 whole_static_libs: [
1137 "arm_whole_static_lib_excludes",
1138 "malloc_not_svelte_whole_static_lib_excludes"
1139 ],
1140 static_libs: [
1141 "arm_static_lib_excludes",
1142 "malloc_not_svelte_static_lib_excludes"
1143 ],
1144 shared_libs: [
1145 "arm_shared_lib_excludes",
1146 ],
1147 arch: {
1148 arm: {
1149 exclude_shared_libs: [
1150 "arm_shared_lib_excludes",
1151 ],
1152 exclude_static_libs: [
1153 "arm_static_lib_excludes",
1154 "arm_whole_static_lib_excludes",
1155 ],
1156 },
1157 },
1158 product_variables: {
1159 malloc_not_svelte: {
1160 shared_libs: ["malloc_not_svelte_shared_lib"],
1161 whole_static_libs: ["malloc_not_svelte_whole_static_lib"],
1162 exclude_static_libs: [
1163 "malloc_not_svelte_static_lib_excludes",
1164 "malloc_not_svelte_whole_static_lib_excludes",
1165 ],
1166 },
1167 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001168 include_build_directory: false,
Liz Kammer47535c52021-06-02 16:02:22 -04001169}
1170
1171cc_library {
1172 name: "arm_whole_static_lib_excludes",
1173 bazel_module: { bp2build_available: false },
1174}
1175
1176cc_library {
1177 name: "malloc_not_svelte_whole_static_lib",
1178 bazel_module: { bp2build_available: false },
1179}
1180
1181cc_library {
1182 name: "malloc_not_svelte_whole_static_lib_excludes",
1183 bazel_module: { bp2build_available: false },
1184}
1185
1186cc_library {
1187 name: "arm_static_lib_excludes",
1188 bazel_module: { bp2build_available: false },
1189}
1190
1191cc_library {
1192 name: "malloc_not_svelte_static_lib_excludes",
1193 bazel_module: { bp2build_available: false },
1194}
1195
1196cc_library {
1197 name: "arm_shared_lib_excludes",
1198 bazel_module: { bp2build_available: false },
1199}
1200
1201cc_library {
1202 name: "malloc_not_svelte_shared_lib",
1203 bazel_module: { bp2build_available: false },
1204}
1205`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001206 ExpectedBazelTargets: makeCcLibraryTargets("foo_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001207 "implementation_deps": `select({
Liz Kammer47535c52021-06-02 16:02:22 -04001208 "//build/bazel/platforms/arch:arm": [],
Chris Parsons953b3562021-09-20 15:14:39 -04001209 "//conditions:default": [":arm_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer47535c52021-06-02 16:02:22 -04001210 }) + select({
1211 "//build/bazel/product_variables:malloc_not_svelte": [],
Chris Parsons953b3562021-09-20 15:14:39 -04001212 "//conditions:default": [":malloc_not_svelte_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001213 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001214 "implementation_dynamic_deps": `select({
Liz Kammer7a210ac2021-09-22 15:52:58 -04001215 "//build/bazel/platforms/arch:arm": [],
1216 "//conditions:default": [":arm_shared_lib_excludes"],
1217 }) + select({
1218 "//build/bazel/product_variables:malloc_not_svelte": [":malloc_not_svelte_shared_lib"],
1219 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001220 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001221 "srcs_c": `["common.c"]`,
1222 "whole_archive_deps": `select({
Liz Kammer47535c52021-06-02 16:02:22 -04001223 "//build/bazel/platforms/arch:arm": [],
Chris Parsons953b3562021-09-20 15:14:39 -04001224 "//conditions:default": [":arm_whole_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer47535c52021-06-02 16:02:22 -04001225 }) + select({
Chris Parsons953b3562021-09-20 15:14:39 -04001226 "//build/bazel/product_variables:malloc_not_svelte": [":malloc_not_svelte_whole_static_lib_bp2build_cc_library_static"],
1227 "//conditions:default": [":malloc_not_svelte_whole_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001228 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001229 }),
1230 },
1231 )
Liz Kammer47535c52021-06-02 16:02:22 -04001232}
Liz Kammerd366c902021-06-03 13:43:01 -04001233
Zi Wang0a8a1292022-08-30 06:27:01 +00001234func TestCcLibraryProductVariablesHeaderLibs(t *testing.T) {
1235 runCcLibraryTestCase(t, Bp2buildTestCase{
1236 ModuleTypeUnderTest: "cc_library",
1237 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1238 Filesystem: map[string]string{},
1239 Blueprint: soongCcLibraryStaticPreamble + `
1240cc_library {
1241 name: "foo_static",
1242 srcs: ["common.c"],
1243 product_variables: {
1244 malloc_not_svelte: {
1245 header_libs: ["malloc_not_svelte_header_lib"],
1246 },
1247 },
1248 include_build_directory: false,
1249}
1250
1251cc_library {
1252 name: "malloc_not_svelte_header_lib",
1253 bazel_module: { bp2build_available: false },
1254}
1255`,
1256 ExpectedBazelTargets: makeCcLibraryTargets("foo_static", AttrNameToString{
1257 "implementation_deps": `select({
1258 "//build/bazel/product_variables:malloc_not_svelte": [":malloc_not_svelte_header_lib"],
1259 "//conditions:default": [],
1260 })`,
1261 "srcs_c": `["common.c"]`,
1262 "target_compatible_with": `["//build/bazel/platforms/os:android"]`,
1263 }),
1264 },
1265 )
1266}
1267
Liz Kammerd366c902021-06-03 13:43:01 -04001268func TestCCLibraryNoCrtTrue(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001269 runCcLibraryTestCase(t, Bp2buildTestCase{
1270 Description: "cc_library - nocrt: true emits attribute",
1271 ModuleTypeUnderTest: "cc_library",
1272 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1273 Filesystem: map[string]string{
Jingwen Chen6ada5892021-09-17 11:38:09 +00001274 "impl.cpp": "",
1275 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001276 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen6ada5892021-09-17 11:38:09 +00001277cc_library {
1278 name: "foo-lib",
1279 srcs: ["impl.cpp"],
1280 nocrt: true,
1281 include_build_directory: false,
1282}
1283`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001284 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001285 "link_crt": `False`,
1286 "srcs": `["impl.cpp"]`,
1287 }),
1288 },
1289 )
Jingwen Chen6ada5892021-09-17 11:38:09 +00001290}
1291
1292func TestCCLibraryNoCrtFalse(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001293 runCcLibraryTestCase(t, Bp2buildTestCase{
1294 Description: "cc_library - nocrt: false - does not emit attribute",
1295 ModuleTypeUnderTest: "cc_library",
1296 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1297 Filesystem: map[string]string{
Jingwen Chen6ada5892021-09-17 11:38:09 +00001298 "impl.cpp": "",
1299 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001300 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen6ada5892021-09-17 11:38:09 +00001301cc_library {
1302 name: "foo-lib",
1303 srcs: ["impl.cpp"],
1304 nocrt: false,
1305 include_build_directory: false,
1306}
1307`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001308 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001309 "srcs": `["impl.cpp"]`,
1310 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001311 })
Jingwen Chen6ada5892021-09-17 11:38:09 +00001312}
1313
1314func TestCCLibraryNoCrtArchVariant(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001315 runCcLibraryTestCase(t, Bp2buildTestCase{
1316 Description: "cc_library - nocrt in select",
1317 ModuleTypeUnderTest: "cc_library",
1318 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1319 Filesystem: map[string]string{
Jingwen Chen6ada5892021-09-17 11:38:09 +00001320 "impl.cpp": "",
1321 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001322 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen6ada5892021-09-17 11:38:09 +00001323cc_library {
1324 name: "foo-lib",
1325 srcs: ["impl.cpp"],
1326 arch: {
1327 arm: {
1328 nocrt: true,
1329 },
1330 x86: {
1331 nocrt: false,
1332 },
1333 },
1334 include_build_directory: false,
1335}
1336`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001337 ExpectedErr: fmt.Errorf("module \"foo-lib\": nocrt is not supported for arch variants"),
Jingwen Chen6ada5892021-09-17 11:38:09 +00001338 })
1339}
1340
1341func TestCCLibraryNoLibCrtTrue(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001342 runCcLibraryTestCase(t, Bp2buildTestCase{
1343 ModuleTypeUnderTest: "cc_library",
1344 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1345 Filesystem: map[string]string{
Liz Kammerd366c902021-06-03 13:43:01 -04001346 "impl.cpp": "",
1347 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001348 Blueprint: soongCcLibraryPreamble + `
Liz Kammerd366c902021-06-03 13:43:01 -04001349cc_library {
1350 name: "foo-lib",
1351 srcs: ["impl.cpp"],
1352 no_libcrt: true,
Liz Kammer8337ea42021-09-10 10:06:32 -04001353 include_build_directory: false,
Liz Kammerd366c902021-06-03 13:43:01 -04001354}
1355`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001356 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001357 "srcs": `["impl.cpp"]`,
1358 "use_libcrt": `False`,
1359 }),
1360 })
1361}
1362
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001363func makeCcLibraryTargets(name string, attrs AttrNameToString) []string {
Chris Parsons77acf2e2021-12-03 17:27:16 -05001364 STATIC_ONLY_ATTRS := map[string]bool{}
1365 SHARED_ONLY_ATTRS := map[string]bool{
1366 "link_crt": true,
1367 "additional_linker_inputs": true,
1368 "linkopts": true,
1369 "strip": true,
Yu Liu75be7b92022-02-01 09:54:09 -08001370 "inject_bssl_hash": true,
Wei Li81852ca2022-07-27 00:22:06 -07001371 "has_stubs": true,
Liz Kammerbaced712022-09-16 09:01:29 -04001372 "use_version_lib": true,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001373 }
Wei Li81852ca2022-07-27 00:22:06 -07001374
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001375 sharedAttrs := AttrNameToString{}
1376 staticAttrs := AttrNameToString{}
Chris Parsons77acf2e2021-12-03 17:27:16 -05001377 for key, val := range attrs {
1378 if _, staticOnly := STATIC_ONLY_ATTRS[key]; !staticOnly {
1379 sharedAttrs[key] = val
1380 }
1381 if _, sharedOnly := SHARED_ONLY_ATTRS[key]; !sharedOnly {
1382 staticAttrs[key] = val
1383 }
1384 }
Alixe06d75b2022-08-31 18:28:19 +00001385 sharedTarget := MakeBazelTarget("cc_library_shared", name, sharedAttrs)
1386 staticTarget := MakeBazelTarget("cc_library_static", name+"_bp2build_cc_library_static", staticAttrs)
Chris Parsons77acf2e2021-12-03 17:27:16 -05001387
1388 return []string{staticTarget, sharedTarget}
Liz Kammerd366c902021-06-03 13:43:01 -04001389}
1390
Jingwen Chen6ada5892021-09-17 11:38:09 +00001391func TestCCLibraryNoLibCrtFalse(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001392 runCcLibraryTestCase(t, Bp2buildTestCase{
1393 ModuleTypeUnderTest: "cc_library",
1394 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1395 Filesystem: map[string]string{
Liz Kammerd366c902021-06-03 13:43:01 -04001396 "impl.cpp": "",
1397 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001398 Blueprint: soongCcLibraryPreamble + `
Liz Kammerd366c902021-06-03 13:43:01 -04001399cc_library {
1400 name: "foo-lib",
1401 srcs: ["impl.cpp"],
1402 no_libcrt: false,
Liz Kammer8337ea42021-09-10 10:06:32 -04001403 include_build_directory: false,
Liz Kammerd366c902021-06-03 13:43:01 -04001404}
1405`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001406 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001407 "srcs": `["impl.cpp"]`,
1408 "use_libcrt": `True`,
1409 }),
1410 })
Liz Kammerd366c902021-06-03 13:43:01 -04001411}
1412
Jingwen Chen6ada5892021-09-17 11:38:09 +00001413func TestCCLibraryNoLibCrtArchVariant(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001414 runCcLibraryTestCase(t, Bp2buildTestCase{
1415 ModuleTypeUnderTest: "cc_library",
1416 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1417 Filesystem: map[string]string{
Liz Kammerd366c902021-06-03 13:43:01 -04001418 "impl.cpp": "",
1419 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001420 Blueprint: soongCcLibraryPreamble + `
Liz Kammerd366c902021-06-03 13:43:01 -04001421cc_library {
1422 name: "foo-lib",
1423 srcs: ["impl.cpp"],
1424 arch: {
1425 arm: {
1426 no_libcrt: true,
1427 },
1428 x86: {
1429 no_libcrt: true,
1430 },
1431 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001432 include_build_directory: false,
Liz Kammerd366c902021-06-03 13:43:01 -04001433}
1434`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001435 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001436 "srcs": `["impl.cpp"]`,
1437 "use_libcrt": `select({
Liz Kammerd366c902021-06-03 13:43:01 -04001438 "//build/bazel/platforms/arch:arm": False,
1439 "//build/bazel/platforms/arch:x86": False,
1440 "//conditions:default": None,
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001441 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001442 }),
1443 })
Liz Kammerd366c902021-06-03 13:43:01 -04001444}
1445
Chris Parsons58852a02021-12-09 18:10:18 -05001446func TestCCLibraryNoLibCrtArchAndTargetVariant(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001447 runCcLibraryTestCase(t, Bp2buildTestCase{
1448 ModuleTypeUnderTest: "cc_library",
1449 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1450 Filesystem: map[string]string{
Chris Parsons58852a02021-12-09 18:10:18 -05001451 "impl.cpp": "",
1452 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001453 Blueprint: soongCcLibraryPreamble + `
Chris Parsons58852a02021-12-09 18:10:18 -05001454cc_library {
1455 name: "foo-lib",
1456 srcs: ["impl.cpp"],
1457 arch: {
1458 arm: {
1459 no_libcrt: true,
1460 },
1461 x86: {
1462 no_libcrt: true,
1463 },
1464 },
1465 target: {
1466 darwin: {
1467 no_libcrt: true,
1468 }
1469 },
1470 include_build_directory: false,
1471}
1472`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001473 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05001474 "srcs": `["impl.cpp"]`,
1475 "use_libcrt": `select({
1476 "//build/bazel/platforms/os_arch:android_arm": False,
1477 "//build/bazel/platforms/os_arch:android_x86": False,
1478 "//build/bazel/platforms/os_arch:darwin_arm64": False,
1479 "//build/bazel/platforms/os_arch:darwin_x86_64": False,
1480 "//build/bazel/platforms/os_arch:linux_glibc_x86": False,
1481 "//build/bazel/platforms/os_arch:linux_musl_x86": False,
1482 "//build/bazel/platforms/os_arch:windows_x86": False,
1483 "//conditions:default": None,
1484 })`,
1485 }),
1486 })
1487}
1488
1489func TestCCLibraryNoLibCrtArchAndTargetVariantConflict(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001490 runCcLibraryTestCase(t, Bp2buildTestCase{
1491 ModuleTypeUnderTest: "cc_library",
1492 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1493 Filesystem: map[string]string{
Chris Parsons58852a02021-12-09 18:10:18 -05001494 "impl.cpp": "",
1495 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001496 Blueprint: soongCcLibraryPreamble + `
Chris Parsons58852a02021-12-09 18:10:18 -05001497cc_library {
1498 name: "foo-lib",
1499 srcs: ["impl.cpp"],
1500 arch: {
1501 arm: {
1502 no_libcrt: true,
1503 },
1504 // This is expected to override the value for darwin_x86_64.
1505 x86_64: {
1506 no_libcrt: true,
1507 },
1508 },
1509 target: {
1510 darwin: {
1511 no_libcrt: false,
1512 }
1513 },
1514 include_build_directory: false,
1515}
1516`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001517 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05001518 "srcs": `["impl.cpp"]`,
1519 "use_libcrt": `select({
1520 "//build/bazel/platforms/os_arch:android_arm": False,
1521 "//build/bazel/platforms/os_arch:android_x86_64": False,
1522 "//build/bazel/platforms/os_arch:darwin_arm64": True,
1523 "//build/bazel/platforms/os_arch:darwin_x86_64": False,
1524 "//build/bazel/platforms/os_arch:linux_bionic_x86_64": False,
1525 "//build/bazel/platforms/os_arch:linux_glibc_x86_64": False,
1526 "//build/bazel/platforms/os_arch:linux_musl_x86_64": False,
1527 "//build/bazel/platforms/os_arch:windows_x86_64": False,
1528 "//conditions:default": None,
1529 })`,
1530 }),
1531 })
1532}
1533
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001534func TestCcLibraryStrip(t *testing.T) {
Chris Parsons77acf2e2021-12-03 17:27:16 -05001535 expectedTargets := []string{}
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001536 expectedTargets = append(expectedTargets, makeCcLibraryTargets("all", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001537 "strip": `{
1538 "all": True,
1539 }`,
1540 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001541 expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001542 "strip": `{
1543 "keep_symbols": True,
1544 }`,
1545 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001546 expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols_and_debug_frame", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001547 "strip": `{
1548 "keep_symbols_and_debug_frame": True,
1549 }`,
1550 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001551 expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols_list", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001552 "strip": `{
1553 "keep_symbols_list": ["symbol"],
1554 }`,
1555 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001556 expectedTargets = append(expectedTargets, makeCcLibraryTargets("none", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001557 "strip": `{
1558 "none": True,
1559 }`,
1560 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001561 expectedTargets = append(expectedTargets, makeCcLibraryTargets("nothing", AttrNameToString{})...)
Chris Parsons77acf2e2021-12-03 17:27:16 -05001562
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001563 runCcLibraryTestCase(t, Bp2buildTestCase{
1564 Description: "cc_library strip args",
1565 ModuleTypeUnderTest: "cc_library",
1566 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1567 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001568cc_library {
1569 name: "nothing",
Liz Kammer8337ea42021-09-10 10:06:32 -04001570 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001571}
1572cc_library {
1573 name: "keep_symbols",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001574 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001575 keep_symbols: true,
1576 },
1577 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001578}
1579cc_library {
1580 name: "keep_symbols_and_debug_frame",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001581 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001582 keep_symbols_and_debug_frame: true,
1583 },
1584 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001585}
1586cc_library {
1587 name: "none",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001588 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001589 none: true,
1590 },
1591 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001592}
1593cc_library {
1594 name: "keep_symbols_list",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001595 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001596 keep_symbols_list: ["symbol"],
1597 },
1598 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001599}
1600cc_library {
1601 name: "all",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001602 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001603 all: true,
1604 },
1605 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001606}
1607`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001608 ExpectedBazelTargets: expectedTargets,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001609 })
1610}
1611
1612func TestCcLibraryStripWithArch(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001613 runCcLibraryTestCase(t, Bp2buildTestCase{
1614 Description: "cc_library strip args",
1615 ModuleTypeUnderTest: "cc_library",
1616 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1617 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001618cc_library {
1619 name: "multi-arch",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001620 target: {
1621 darwin: {
1622 strip: {
1623 keep_symbols_list: ["foo", "bar"]
1624 }
1625 },
1626 },
1627 arch: {
1628 arm: {
1629 strip: {
1630 keep_symbols_and_debug_frame: true,
1631 },
1632 },
1633 arm64: {
1634 strip: {
1635 keep_symbols: true,
1636 },
1637 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001638 },
1639 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001640}
1641`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001642 ExpectedBazelTargets: makeCcLibraryTargets("multi-arch", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001643 "strip": `{
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001644 "keep_symbols": select({
1645 "//build/bazel/platforms/arch:arm64": True,
1646 "//conditions:default": None,
1647 }),
1648 "keep_symbols_and_debug_frame": select({
1649 "//build/bazel/platforms/arch:arm": True,
1650 "//conditions:default": None,
1651 }),
1652 "keep_symbols_list": select({
1653 "//build/bazel/platforms/os:darwin": [
1654 "foo",
1655 "bar",
1656 ],
1657 "//conditions:default": [],
1658 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001659 }`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001660 }),
1661 },
1662 )
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001663}
Chris Parsons51f8c392021-08-03 21:01:05 -04001664
1665func TestCcLibrary_SystemSharedLibsRootEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001666 runCcLibraryTestCase(t, Bp2buildTestCase{
1667 Description: "cc_library system_shared_libs empty at root",
1668 ModuleTypeUnderTest: "cc_library",
1669 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1670 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001671cc_library {
1672 name: "root_empty",
Liz Kammer8337ea42021-09-10 10:06:32 -04001673 system_shared_libs: [],
1674 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001675}
1676`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001677 ExpectedBazelTargets: makeCcLibraryTargets("root_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001678 "system_dynamic_deps": `[]`,
1679 }),
1680 },
1681 )
Chris Parsons51f8c392021-08-03 21:01:05 -04001682}
1683
1684func TestCcLibrary_SystemSharedLibsStaticEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001685 runCcLibraryTestCase(t, Bp2buildTestCase{
1686 Description: "cc_library system_shared_libs empty for static variant",
1687 ModuleTypeUnderTest: "cc_library",
1688 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1689 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001690cc_library {
1691 name: "static_empty",
1692 static: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001693 system_shared_libs: [],
1694 },
1695 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001696}
1697`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001698 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001699 MakeBazelTarget("cc_library_static", "static_empty_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001700 "system_dynamic_deps": "[]",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001701 }),
Alixe06d75b2022-08-31 18:28:19 +00001702 MakeBazelTarget("cc_library_shared", "static_empty", AttrNameToString{}),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001703 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001704 })
1705}
1706
1707func TestCcLibrary_SystemSharedLibsSharedEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001708 runCcLibraryTestCase(t, Bp2buildTestCase{
1709 Description: "cc_library system_shared_libs empty for shared variant",
1710 ModuleTypeUnderTest: "cc_library",
1711 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1712 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001713cc_library {
1714 name: "shared_empty",
1715 shared: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001716 system_shared_libs: [],
1717 },
1718 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001719}
1720`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001721 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001722 MakeBazelTarget("cc_library_static", "shared_empty_bp2build_cc_library_static", AttrNameToString{}),
1723 MakeBazelTarget("cc_library_shared", "shared_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001724 "system_dynamic_deps": "[]",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001725 }),
1726 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001727 })
1728}
1729
1730func TestCcLibrary_SystemSharedLibsSharedBionicEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001731 runCcLibraryTestCase(t, Bp2buildTestCase{
1732 Description: "cc_library system_shared_libs empty for shared, bionic variant",
1733 ModuleTypeUnderTest: "cc_library",
1734 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1735 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001736cc_library {
1737 name: "shared_empty",
1738 target: {
1739 bionic: {
1740 shared: {
1741 system_shared_libs: [],
1742 }
1743 }
Liz Kammer8337ea42021-09-10 10:06:32 -04001744 },
1745 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001746}
1747`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001748 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001749 MakeBazelTarget("cc_library_static", "shared_empty_bp2build_cc_library_static", AttrNameToString{}),
1750 MakeBazelTarget("cc_library_shared", "shared_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001751 "system_dynamic_deps": "[]",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001752 }),
1753 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001754 })
1755}
1756
1757func TestCcLibrary_SystemSharedLibsLinuxBionicEmpty(t *testing.T) {
1758 // Note that this behavior is technically incorrect (it's a simplification).
1759 // The correct behavior would be if bp2build wrote `system_dynamic_deps = []`
1760 // only for linux_bionic, but `android` had `["libc", "libdl", "libm"].
1761 // b/195791252 tracks the fix.
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001762 runCcLibraryTestCase(t, Bp2buildTestCase{
1763 Description: "cc_library system_shared_libs empty for linux_bionic variant",
1764 ModuleTypeUnderTest: "cc_library",
1765 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1766 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001767cc_library {
1768 name: "target_linux_bionic_empty",
1769 target: {
1770 linux_bionic: {
1771 system_shared_libs: [],
1772 },
1773 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001774 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001775}
1776`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001777 ExpectedBazelTargets: makeCcLibraryTargets("target_linux_bionic_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001778 "system_dynamic_deps": `[]`,
1779 }),
1780 },
1781 )
Chris Parsons51f8c392021-08-03 21:01:05 -04001782}
1783
1784func TestCcLibrary_SystemSharedLibsBionicEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001785 runCcLibraryTestCase(t, Bp2buildTestCase{
1786 Description: "cc_library system_shared_libs empty for bionic variant",
1787 ModuleTypeUnderTest: "cc_library",
1788 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1789 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001790cc_library {
1791 name: "target_bionic_empty",
1792 target: {
1793 bionic: {
1794 system_shared_libs: [],
1795 },
1796 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001797 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001798}
1799`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001800 ExpectedBazelTargets: makeCcLibraryTargets("target_bionic_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001801 "system_dynamic_deps": `[]`,
1802 }),
1803 },
1804 )
Chris Parsons51f8c392021-08-03 21:01:05 -04001805}
1806
1807func TestCcLibrary_SystemSharedLibsSharedAndRoot(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001808 runCcLibraryTestCase(t, Bp2buildTestCase{
1809 Description: "cc_library system_shared_libs set for shared and root",
1810 ModuleTypeUnderTest: "cc_library",
1811 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1812 Blueprint: soongCcLibraryPreamble + `
Liz Kammer8337ea42021-09-10 10:06:32 -04001813cc_library {
1814 name: "libc",
1815 bazel_module: { bp2build_available: false },
1816}
1817cc_library {
1818 name: "libm",
1819 bazel_module: { bp2build_available: false },
1820}
Chris Parsons51f8c392021-08-03 21:01:05 -04001821
1822cc_library {
1823 name: "foo",
1824 system_shared_libs: ["libc"],
1825 shared: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001826 system_shared_libs: ["libm"],
Chris Parsons51f8c392021-08-03 21:01:05 -04001827 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001828 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001829}
1830`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001831 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001832 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001833 "system_dynamic_deps": `[":libc"]`,
1834 }),
Alixe06d75b2022-08-31 18:28:19 +00001835 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001836 "system_dynamic_deps": `[
1837 ":libc",
1838 ":libm",
1839 ]`,
1840 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001841 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001842 })
1843}
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001844
1845func TestCcLibraryOsSelects(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001846 runCcLibraryTestCase(t, Bp2buildTestCase{
1847 Description: "cc_library - selects for all os targets",
1848 ModuleTypeUnderTest: "cc_library",
1849 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1850 Filesystem: map[string]string{},
1851 Blueprint: soongCcLibraryPreamble + `
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001852cc_library {
1853 name: "foo-lib",
1854 srcs: ["base.cpp"],
1855 target: {
1856 android: {
1857 srcs: ["android.cpp"],
1858 },
1859 linux: {
1860 srcs: ["linux.cpp"],
1861 },
1862 linux_glibc: {
1863 srcs: ["linux_glibc.cpp"],
1864 },
1865 darwin: {
1866 srcs: ["darwin.cpp"],
1867 },
1868 bionic: {
1869 srcs: ["bionic.cpp"],
1870 },
1871 linux_musl: {
1872 srcs: ["linux_musl.cpp"],
1873 },
1874 windows: {
1875 srcs: ["windows.cpp"],
1876 },
1877 },
1878 include_build_directory: false,
1879}
1880`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001881 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001882 "srcs": `["base.cpp"] + select({
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001883 "//build/bazel/platforms/os:android": [
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001884 "linux.cpp",
Liz Kammer9bad9d62021-10-11 15:40:35 -04001885 "bionic.cpp",
Liz Kammerfdd72e62021-10-11 15:41:03 -04001886 "android.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001887 ],
1888 "//build/bazel/platforms/os:darwin": ["darwin.cpp"],
1889 "//build/bazel/platforms/os:linux": [
Liz Kammer9bad9d62021-10-11 15:40:35 -04001890 "linux.cpp",
Liz Kammerfdd72e62021-10-11 15:41:03 -04001891 "linux_glibc.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001892 ],
1893 "//build/bazel/platforms/os:linux_bionic": [
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001894 "linux.cpp",
Liz Kammer9bad9d62021-10-11 15:40:35 -04001895 "bionic.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001896 ],
1897 "//build/bazel/platforms/os:linux_musl": [
Liz Kammer9bad9d62021-10-11 15:40:35 -04001898 "linux.cpp",
Liz Kammerfdd72e62021-10-11 15:41:03 -04001899 "linux_musl.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001900 ],
1901 "//build/bazel/platforms/os:windows": ["windows.cpp"],
1902 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001903 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001904 }),
1905 },
1906 )
Jingwen Chen97b85312021-10-08 10:41:31 +00001907}
1908
Yu Liu75be7b92022-02-01 09:54:09 -08001909func TestLibcryptoHashInjection(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001910 runCcLibraryTestCase(t, Bp2buildTestCase{
1911 Description: "cc_library - libcrypto hash injection",
1912 ModuleTypeUnderTest: "cc_library",
1913 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1914 Filesystem: map[string]string{},
1915 Blueprint: soongCcLibraryPreamble + `
Yu Liu75be7b92022-02-01 09:54:09 -08001916cc_library {
1917 name: "libcrypto",
1918 target: {
1919 android: {
1920 inject_bssl_hash: true,
1921 },
1922 },
1923 include_build_directory: false,
1924}
1925`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001926 ExpectedBazelTargets: makeCcLibraryTargets("libcrypto", AttrNameToString{
Yu Liu75be7b92022-02-01 09:54:09 -08001927 "inject_bssl_hash": `select({
1928 "//build/bazel/platforms/os:android": True,
1929 "//conditions:default": None,
1930 })`,
1931 }),
1932 },
1933 )
1934}
1935
Jingwen Chen5b11ab12021-10-11 17:44:33 +00001936func TestCcLibraryCppStdWithGnuExtensions_ConvertsToFeatureAttr(t *testing.T) {
Jingwen Chen97b85312021-10-08 10:41:31 +00001937 type testCase struct {
1938 cpp_std string
Chris Parsons79bd2b72021-11-29 17:52:41 -05001939 c_std string
Jingwen Chen97b85312021-10-08 10:41:31 +00001940 gnu_extensions string
1941 bazel_cpp_std string
Chris Parsons79bd2b72021-11-29 17:52:41 -05001942 bazel_c_std string
Jingwen Chen97b85312021-10-08 10:41:31 +00001943 }
1944
1945 testCases := []testCase{
1946 // Existing usages of cpp_std in AOSP are:
1947 // experimental, c++11, c++17, c++2a, c++98, gnu++11, gnu++17
1948 //
1949 // not set, only emit if gnu_extensions is disabled. the default (gnu+17
1950 // is set in the toolchain.)
1951 {cpp_std: "", gnu_extensions: "", bazel_cpp_std: ""},
Liz Kammera5a29de2022-05-25 23:19:37 -04001952 {cpp_std: "", gnu_extensions: "false", bazel_cpp_std: "cpp_std_default_no_gnu", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001953 {cpp_std: "", gnu_extensions: "true", bazel_cpp_std: ""},
1954 // experimental defaults to gnu++2a
Liz Kammera5a29de2022-05-25 23:19:37 -04001955 {cpp_std: "experimental", gnu_extensions: "", bazel_cpp_std: "cpp_std_experimental"},
1956 {cpp_std: "experimental", gnu_extensions: "false", bazel_cpp_std: "cpp_std_experimental_no_gnu", bazel_c_std: "c_std_default_no_gnu"},
1957 {cpp_std: "experimental", gnu_extensions: "true", bazel_cpp_std: "cpp_std_experimental"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001958 // Explicitly setting a c++ std does not use replace gnu++ std even if
1959 // gnu_extensions is true.
1960 // "c++11",
1961 {cpp_std: "c++11", gnu_extensions: "", bazel_cpp_std: "c++11"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001962 {cpp_std: "c++11", gnu_extensions: "false", bazel_cpp_std: "c++11", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001963 {cpp_std: "c++11", gnu_extensions: "true", bazel_cpp_std: "c++11"},
1964 // "c++17",
1965 {cpp_std: "c++17", gnu_extensions: "", bazel_cpp_std: "c++17"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001966 {cpp_std: "c++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001967 {cpp_std: "c++17", gnu_extensions: "true", bazel_cpp_std: "c++17"},
1968 // "c++2a",
1969 {cpp_std: "c++2a", gnu_extensions: "", bazel_cpp_std: "c++2a"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001970 {cpp_std: "c++2a", gnu_extensions: "false", bazel_cpp_std: "c++2a", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001971 {cpp_std: "c++2a", gnu_extensions: "true", bazel_cpp_std: "c++2a"},
1972 // "c++98",
1973 {cpp_std: "c++98", gnu_extensions: "", bazel_cpp_std: "c++98"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001974 {cpp_std: "c++98", gnu_extensions: "false", bazel_cpp_std: "c++98", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001975 {cpp_std: "c++98", gnu_extensions: "true", bazel_cpp_std: "c++98"},
1976 // gnu++ is replaced with c++ if gnu_extensions is explicitly false.
1977 // "gnu++11",
1978 {cpp_std: "gnu++11", gnu_extensions: "", bazel_cpp_std: "gnu++11"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001979 {cpp_std: "gnu++11", gnu_extensions: "false", bazel_cpp_std: "c++11", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001980 {cpp_std: "gnu++11", gnu_extensions: "true", bazel_cpp_std: "gnu++11"},
1981 // "gnu++17",
1982 {cpp_std: "gnu++17", gnu_extensions: "", bazel_cpp_std: "gnu++17"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001983 {cpp_std: "gnu++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001984 {cpp_std: "gnu++17", gnu_extensions: "true", bazel_cpp_std: "gnu++17"},
Chris Parsons79bd2b72021-11-29 17:52:41 -05001985
1986 // some c_std test cases
Liz Kammera5a29de2022-05-25 23:19:37 -04001987 {c_std: "experimental", gnu_extensions: "", bazel_c_std: "c_std_experimental"},
1988 {c_std: "experimental", gnu_extensions: "false", bazel_cpp_std: "cpp_std_default_no_gnu", bazel_c_std: "c_std_experimental_no_gnu"},
1989 {c_std: "experimental", gnu_extensions: "true", bazel_c_std: "c_std_experimental"},
Chris Parsons79bd2b72021-11-29 17:52:41 -05001990 {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "", bazel_cpp_std: "gnu++17", bazel_c_std: "gnu11"},
1991 {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c11"},
1992 {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "true", bazel_cpp_std: "gnu++17", bazel_c_std: "gnu11"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001993 }
Chris Parsons79bd2b72021-11-29 17:52:41 -05001994 for i, tc := range testCases {
Liz Kammera5a29de2022-05-25 23:19:37 -04001995 name := fmt.Sprintf("cpp std: %q, c std: %q, gnu_extensions: %q", tc.cpp_std, tc.c_std, tc.gnu_extensions)
1996 t.Run(name, func(t *testing.T) {
1997 name_prefix := fmt.Sprintf("a_%v", i)
1998 cppStdProp := ""
1999 if tc.cpp_std != "" {
2000 cppStdProp = fmt.Sprintf(" cpp_std: \"%s\",", tc.cpp_std)
2001 }
2002 cStdProp := ""
2003 if tc.c_std != "" {
2004 cStdProp = fmt.Sprintf(" c_std: \"%s\",", tc.c_std)
2005 }
2006 gnuExtensionsProp := ""
2007 if tc.gnu_extensions != "" {
2008 gnuExtensionsProp = fmt.Sprintf(" gnu_extensions: %s,", tc.gnu_extensions)
2009 }
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002010 attrs := AttrNameToString{}
Liz Kammera5a29de2022-05-25 23:19:37 -04002011 if tc.bazel_cpp_std != "" {
2012 attrs["cpp_std"] = fmt.Sprintf(`"%s"`, tc.bazel_cpp_std)
2013 }
2014 if tc.bazel_c_std != "" {
2015 attrs["c_std"] = fmt.Sprintf(`"%s"`, tc.bazel_c_std)
2016 }
Jingwen Chen97b85312021-10-08 10:41:31 +00002017
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002018 runCcLibraryTestCase(t, Bp2buildTestCase{
2019 Description: fmt.Sprintf(
Liz Kammera5a29de2022-05-25 23:19:37 -04002020 "cc_library with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002021 ModuleTypeUnderTest: "cc_library",
2022 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2023 Blueprint: soongCcLibraryPreamble + fmt.Sprintf(`
Jingwen Chen97b85312021-10-08 10:41:31 +00002024cc_library {
Chris Parsons79bd2b72021-11-29 17:52:41 -05002025 name: "%s_full",
Jingwen Chen97b85312021-10-08 10:41:31 +00002026%s // cpp_std: *string
Chris Parsons79bd2b72021-11-29 17:52:41 -05002027%s // c_std: *string
Jingwen Chen97b85312021-10-08 10:41:31 +00002028%s // gnu_extensions: *bool
2029 include_build_directory: false,
2030}
Chris Parsons79bd2b72021-11-29 17:52:41 -05002031`, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002032 ExpectedBazelTargets: makeCcLibraryTargets(name_prefix+"_full", attrs),
Liz Kammera5a29de2022-05-25 23:19:37 -04002033 })
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002034
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002035 runCcLibraryStaticTestCase(t, Bp2buildTestCase{
2036 Description: fmt.Sprintf(
Liz Kammera5a29de2022-05-25 23:19:37 -04002037 "cc_library_static with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002038 ModuleTypeUnderTest: "cc_library_static",
2039 ModuleTypeUnderTestFactory: cc.LibraryStaticFactory,
2040 Blueprint: soongCcLibraryPreamble + fmt.Sprintf(`
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002041cc_library_static {
Chris Parsons79bd2b72021-11-29 17:52:41 -05002042 name: "%s_static",
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002043%s // cpp_std: *string
Chris Parsons79bd2b72021-11-29 17:52:41 -05002044%s // c_std: *string
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002045%s // gnu_extensions: *bool
2046 include_build_directory: false,
2047}
Chris Parsons79bd2b72021-11-29 17:52:41 -05002048`, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002049 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002050 MakeBazelTarget("cc_library_static", name_prefix+"_static", attrs),
Liz Kammera5a29de2022-05-25 23:19:37 -04002051 },
2052 })
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002053
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002054 runCcLibrarySharedTestCase(t, Bp2buildTestCase{
2055 Description: fmt.Sprintf(
Liz Kammera5a29de2022-05-25 23:19:37 -04002056 "cc_library_shared with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002057 ModuleTypeUnderTest: "cc_library_shared",
2058 ModuleTypeUnderTestFactory: cc.LibrarySharedFactory,
2059 Blueprint: soongCcLibraryPreamble + fmt.Sprintf(`
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002060cc_library_shared {
Chris Parsons79bd2b72021-11-29 17:52:41 -05002061 name: "%s_shared",
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002062%s // cpp_std: *string
Chris Parsons79bd2b72021-11-29 17:52:41 -05002063%s // c_std: *string
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002064%s // gnu_extensions: *bool
2065 include_build_directory: false,
2066}
Chris Parsons79bd2b72021-11-29 17:52:41 -05002067`, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002068 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002069 MakeBazelTarget("cc_library_shared", name_prefix+"_shared", attrs),
Liz Kammera5a29de2022-05-25 23:19:37 -04002070 },
2071 })
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002072 })
Jingwen Chen97b85312021-10-08 10:41:31 +00002073 }
Chris Parsons2dde0cb2021-10-01 14:45:30 -04002074}
Liz Kammer12615db2021-09-28 09:19:17 -04002075
2076func TestCcLibraryProtoSimple(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002077 runCcLibraryTestCase(t, Bp2buildTestCase{
2078 ModuleTypeUnderTest: "cc_library",
2079 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2080 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002081 name: "foo",
2082 srcs: ["foo.proto"],
2083 include_build_directory: false,
2084}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002085 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002086 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer7756c8f2022-02-14 20:49:15 -05002087 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002088 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002089 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002090 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002091 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002092 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002093 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002094 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2095 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002096 }),
2097 },
2098 })
2099}
2100
2101func TestCcLibraryProtoNoCanonicalPathFromRoot(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002102 runCcLibraryTestCase(t, Bp2buildTestCase{
2103 ModuleTypeUnderTest: "cc_library",
2104 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2105 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002106 name: "foo",
2107 srcs: ["foo.proto"],
2108 proto: { canonical_path_from_root: false},
2109 include_build_directory: false,
2110}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002111 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002112 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer7756c8f2022-02-14 20:49:15 -05002113 "srcs": `["foo.proto"]`,
2114 "strip_import_prefix": `""`,
Alixe06d75b2022-08-31 18:28:19 +00002115 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002116 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002117 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002118 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002119 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002120 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002121 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2122 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002123 }),
2124 },
2125 })
2126}
2127
2128func TestCcLibraryProtoExplicitCanonicalPathFromRoot(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002129 runCcLibraryTestCase(t, Bp2buildTestCase{
2130 ModuleTypeUnderTest: "cc_library",
2131 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2132 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002133 name: "foo",
2134 srcs: ["foo.proto"],
2135 proto: { canonical_path_from_root: true},
2136 include_build_directory: false,
2137}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002138 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002139 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer7756c8f2022-02-14 20:49:15 -05002140 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002141 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002142 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002143 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002144 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002145 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002146 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002147 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2148 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002149 }),
2150 },
2151 })
2152}
2153
2154func TestCcLibraryProtoFull(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002155 runCcLibraryTestCase(t, Bp2buildTestCase{
2156 ModuleTypeUnderTest: "cc_library",
2157 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2158 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002159 name: "foo",
2160 srcs: ["foo.proto"],
2161 proto: {
Liz Kammer12615db2021-09-28 09:19:17 -04002162 type: "full",
2163 },
2164 include_build_directory: false,
2165}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002166 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002167 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002168 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002169 }), MakeBazelTarget("cc_proto_library", "foo_cc_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002170 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002171 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002172 "implementation_whole_archive_deps": `[":foo_cc_proto"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002173 "deps": `[":libprotobuf-cpp-full"]`,
Alixe06d75b2022-08-31 18:28:19 +00002174 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002175 "dynamic_deps": `[":libprotobuf-cpp-full"]`,
2176 "implementation_whole_archive_deps": `[":foo_cc_proto"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002177 }),
2178 },
2179 })
2180}
2181
2182func TestCcLibraryProtoLite(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002183 runCcLibraryTestCase(t, Bp2buildTestCase{
2184 ModuleTypeUnderTest: "cc_library",
2185 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2186 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002187 name: "foo",
2188 srcs: ["foo.proto"],
2189 proto: {
Liz Kammer12615db2021-09-28 09:19:17 -04002190 type: "lite",
2191 },
2192 include_build_directory: false,
2193}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002194 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002195 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002196 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002197 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002198 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002199 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002200 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002201 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002202 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002203 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2204 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002205 }),
2206 },
2207 })
2208}
2209
2210func TestCcLibraryProtoExportHeaders(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002211 runCcLibraryTestCase(t, Bp2buildTestCase{
2212 ModuleTypeUnderTest: "cc_library",
2213 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2214 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002215 name: "foo",
2216 srcs: ["foo.proto"],
2217 proto: {
Liz Kammer12615db2021-09-28 09:19:17 -04002218 export_proto_headers: true,
2219 },
2220 include_build_directory: false,
2221}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002222 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002223 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002224 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002225 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002226 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002227 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05002228 "deps": `[":libprotobuf-cpp-lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002229 "whole_archive_deps": `[":foo_cc_proto_lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002230 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05002231 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2232 "whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002233 }),
2234 },
2235 })
2236}
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002237
Yu Liu2d136142022-08-18 14:46:13 -07002238func TestCcLibraryProtoIncludeDirs(t *testing.T) {
2239 runCcLibraryTestCase(t, Bp2buildTestCase{
2240 ModuleTypeUnderTest: "cc_library",
2241 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2242 Blueprint: soongCcProtoPreamble + `cc_library {
2243 name: "foo",
2244 srcs: ["foo.proto"],
2245 proto: {
2246 include_dirs: ["external/protobuf/src"],
2247 },
2248 include_build_directory: false,
2249}`,
2250 ExpectedBazelTargets: []string{
2251 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
2252 "srcs": `["foo.proto"]`,
2253 "deps": `["//external/protobuf:libprotobuf-proto"]`,
2254 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
2255 "deps": `[":foo_proto"]`,
2256 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
2257 "deps": `[":libprotobuf-cpp-lite"]`,
2258 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
2259 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002260 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2261 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Yu Liu2d136142022-08-18 14:46:13 -07002262 }),
2263 },
2264 })
2265}
2266
2267func TestCcLibraryProtoIncludeDirsUnknown(t *testing.T) {
2268 runCcLibraryTestCase(t, Bp2buildTestCase{
2269 ModuleTypeUnderTest: "cc_library",
2270 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2271 Blueprint: soongCcProtoPreamble + `cc_library {
2272 name: "foo",
2273 srcs: ["foo.proto"],
2274 proto: {
2275 include_dirs: ["external/protobuf/abc"],
2276 },
2277 include_build_directory: false,
2278}`,
2279 ExpectedErr: fmt.Errorf("module \"foo\": Could not find the proto_library target for include dir: external/protobuf/abc"),
2280 })
2281}
2282
Yu Liu2aa806b2022-09-01 11:54:47 -07002283func TestCcLibraryConvertedProtoFilegroups(t *testing.T) {
2284 runCcLibraryTestCase(t, Bp2buildTestCase{
2285 ModuleTypeUnderTest: "cc_library",
2286 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2287 Blueprint: soongCcProtoPreamble + `
2288filegroup {
2289 name: "a_fg_proto",
2290 srcs: ["a_fg.proto"],
2291}
2292
2293cc_library {
2294 name: "a",
2295 srcs: [
2296 ":a_fg_proto",
2297 "a.proto",
2298 ],
2299 proto: {
2300 export_proto_headers: true,
2301 },
2302 include_build_directory: false,
2303}`,
2304 ExpectedBazelTargets: []string{
2305 MakeBazelTarget("proto_library", "a_proto", AttrNameToString{
Yu Liu2a85fb12022-09-15 22:18:48 -07002306 "deps": `[":a_fg_proto_bp2build_converted"]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002307 "srcs": `["a.proto"]`,
2308 }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
2309 "deps": `[
2310 ":a_fg_proto_bp2build_converted",
2311 ":a_proto",
2312 ]`,
2313 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
2314 "deps": `[":libprotobuf-cpp-lite"]`,
2315 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2316 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
2317 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2318 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2319 }), MakeBazelTargetNoRestrictions("proto_library", "a_fg_proto_bp2build_converted", AttrNameToString{
2320 "srcs": `["a_fg.proto"]`,
Yu Liu2a85fb12022-09-15 22:18:48 -07002321 "tags": `["manual"]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002322 }), MakeBazelTargetNoRestrictions("filegroup", "a_fg_proto", AttrNameToString{
2323 "srcs": `["a_fg.proto"]`,
2324 }),
2325 },
2326 })
2327}
2328
2329func TestCcLibraryConvertedProtoFilegroupsNoProtoFiles(t *testing.T) {
2330 runCcLibraryTestCase(t, Bp2buildTestCase{
2331 ModuleTypeUnderTest: "cc_library",
2332 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2333 Blueprint: soongCcProtoPreamble + `
2334filegroup {
2335 name: "a_fg_proto",
2336 srcs: ["a_fg.proto"],
2337}
2338
2339cc_library {
2340 name: "a",
2341 srcs: [
2342 ":a_fg_proto",
2343 ],
2344 proto: {
2345 export_proto_headers: true,
2346 },
2347 include_build_directory: false,
2348}`,
2349 ExpectedBazelTargets: []string{
2350 MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
2351 "deps": `[":a_fg_proto_bp2build_converted"]`,
2352 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
2353 "deps": `[":libprotobuf-cpp-lite"]`,
2354 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2355 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
2356 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2357 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2358 }), MakeBazelTargetNoRestrictions("proto_library", "a_fg_proto_bp2build_converted", AttrNameToString{
2359 "srcs": `["a_fg.proto"]`,
Yu Liu2a85fb12022-09-15 22:18:48 -07002360 "tags": `["manual"]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002361 }), MakeBazelTargetNoRestrictions("filegroup", "a_fg_proto", AttrNameToString{
2362 "srcs": `["a_fg.proto"]`,
2363 }),
2364 },
2365 })
2366}
2367
2368func TestCcLibraryExternalConvertedProtoFilegroups(t *testing.T) {
2369 runCcLibraryTestCase(t, Bp2buildTestCase{
2370 ModuleTypeUnderTest: "cc_library",
2371 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2372 Filesystem: map[string]string{
2373 "path/to/A/Android.bp": `
2374filegroup {
2375 name: "a_fg_proto",
2376 srcs: ["a_fg.proto"],
2377}`,
2378 },
2379 Blueprint: soongCcProtoPreamble + `
2380cc_library {
2381 name: "a",
2382 srcs: [
2383 ":a_fg_proto",
2384 "a.proto",
2385 ],
2386 proto: {
2387 export_proto_headers: true,
2388 },
2389 include_build_directory: false,
2390}`,
2391 ExpectedBazelTargets: []string{
2392 MakeBazelTarget("proto_library", "a_proto", AttrNameToString{
Yu Liu2a85fb12022-09-15 22:18:48 -07002393 "deps": `["//path/to/A:a_fg_proto_bp2build_converted"]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002394 "srcs": `["a.proto"]`,
2395 }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
2396 "deps": `[
2397 "//path/to/A:a_fg_proto_bp2build_converted",
2398 ":a_proto",
2399 ]`,
2400 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
2401 "deps": `[":libprotobuf-cpp-lite"]`,
2402 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2403 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
2404 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2405 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2406 }),
2407 },
2408 })
2409}
2410
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002411func TestCcLibraryProtoFilegroups(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002412 runCcLibraryTestCase(t, Bp2buildTestCase{
2413 ModuleTypeUnderTest: "cc_library",
2414 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2415 Blueprint: soongCcProtoPreamble +
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002416 simpleModuleDoNotConvertBp2build("filegroup", "a_fg_proto") +
2417 simpleModuleDoNotConvertBp2build("filegroup", "b_protos") +
2418 simpleModuleDoNotConvertBp2build("filegroup", "c-proto-srcs") +
2419 simpleModuleDoNotConvertBp2build("filegroup", "proto-srcs-d") + `
2420cc_library {
2421 name: "a",
2422 srcs: [":a_fg_proto"],
2423 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002424 export_proto_headers: true,
2425 },
2426 include_build_directory: false,
2427}
2428
2429cc_library {
2430 name: "b",
2431 srcs: [":b_protos"],
2432 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002433 export_proto_headers: true,
2434 },
2435 include_build_directory: false,
2436}
2437
2438cc_library {
2439 name: "c",
2440 srcs: [":c-proto-srcs"],
2441 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002442 export_proto_headers: true,
2443 },
2444 include_build_directory: false,
2445}
2446
2447cc_library {
2448 name: "d",
2449 srcs: [":proto-srcs-d"],
2450 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002451 export_proto_headers: true,
2452 },
2453 include_build_directory: false,
2454}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002455 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002456 MakeBazelTarget("proto_library", "a_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002457 "srcs": `[":a_fg_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002458 }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002459 "deps": `[":a_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002460 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002461 "deps": `[":libprotobuf-cpp-lite"]`,
2462 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2463 "srcs": `[":a_fg_proto_cpp_srcs"]`,
2464 "srcs_as": `[":a_fg_proto_as_srcs"]`,
2465 "srcs_c": `[":a_fg_proto_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002466 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002467 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2468 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2469 "srcs": `[":a_fg_proto_cpp_srcs"]`,
2470 "srcs_as": `[":a_fg_proto_as_srcs"]`,
2471 "srcs_c": `[":a_fg_proto_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002472 }), MakeBazelTarget("proto_library", "b_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002473 "srcs": `[":b_protos"]`,
Alixe06d75b2022-08-31 18:28:19 +00002474 }), MakeBazelTarget("cc_lite_proto_library", "b_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002475 "deps": `[":b_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002476 }), MakeBazelTarget("cc_library_static", "b_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002477 "deps": `[":libprotobuf-cpp-lite"]`,
2478 "whole_archive_deps": `[":b_cc_proto_lite"]`,
2479 "srcs": `[":b_protos_cpp_srcs"]`,
2480 "srcs_as": `[":b_protos_as_srcs"]`,
2481 "srcs_c": `[":b_protos_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002482 }), MakeBazelTarget("cc_library_shared", "b", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002483 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2484 "whole_archive_deps": `[":b_cc_proto_lite"]`,
2485 "srcs": `[":b_protos_cpp_srcs"]`,
2486 "srcs_as": `[":b_protos_as_srcs"]`,
2487 "srcs_c": `[":b_protos_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002488 }), MakeBazelTarget("proto_library", "c_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002489 "srcs": `[":c-proto-srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002490 }), MakeBazelTarget("cc_lite_proto_library", "c_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002491 "deps": `[":c_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002492 }), MakeBazelTarget("cc_library_static", "c_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002493 "deps": `[":libprotobuf-cpp-lite"]`,
2494 "whole_archive_deps": `[":c_cc_proto_lite"]`,
2495 "srcs": `[":c-proto-srcs_cpp_srcs"]`,
2496 "srcs_as": `[":c-proto-srcs_as_srcs"]`,
2497 "srcs_c": `[":c-proto-srcs_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002498 }), MakeBazelTarget("cc_library_shared", "c", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002499 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2500 "whole_archive_deps": `[":c_cc_proto_lite"]`,
2501 "srcs": `[":c-proto-srcs_cpp_srcs"]`,
2502 "srcs_as": `[":c-proto-srcs_as_srcs"]`,
2503 "srcs_c": `[":c-proto-srcs_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002504 }), MakeBazelTarget("proto_library", "d_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002505 "srcs": `[":proto-srcs-d"]`,
Alixe06d75b2022-08-31 18:28:19 +00002506 }), MakeBazelTarget("cc_lite_proto_library", "d_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002507 "deps": `[":d_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002508 }), MakeBazelTarget("cc_library_static", "d_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002509 "deps": `[":libprotobuf-cpp-lite"]`,
2510 "whole_archive_deps": `[":d_cc_proto_lite"]`,
2511 "srcs": `[":proto-srcs-d_cpp_srcs"]`,
2512 "srcs_as": `[":proto-srcs-d_as_srcs"]`,
2513 "srcs_c": `[":proto-srcs-d_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002514 }), MakeBazelTarget("cc_library_shared", "d", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002515 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2516 "whole_archive_deps": `[":d_cc_proto_lite"]`,
2517 "srcs": `[":proto-srcs-d_cpp_srcs"]`,
2518 "srcs_as": `[":proto-srcs-d_as_srcs"]`,
2519 "srcs_c": `[":proto-srcs-d_c_srcs"]`,
2520 }),
2521 },
2522 })
2523}
Chris Parsons58852a02021-12-09 18:10:18 -05002524
2525func TestCcLibraryDisabledArchAndTarget(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002526 runCcLibraryTestCase(t, Bp2buildTestCase{
2527 ModuleTypeUnderTest: "cc_library",
2528 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2529 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002530 name: "foo",
2531 srcs: ["foo.cpp"],
Liz Kammerdfeb1202022-05-13 17:20:20 -04002532 host_supported: true,
Chris Parsons58852a02021-12-09 18:10:18 -05002533 target: {
2534 darwin: {
2535 enabled: false,
2536 },
2537 windows: {
2538 enabled: false,
2539 },
2540 linux_glibc_x86: {
2541 enabled: false,
2542 },
2543 },
2544 include_build_directory: false,
2545}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002546 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002547 "srcs": `["foo.cpp"]`,
2548 "target_compatible_with": `select({
2549 "//build/bazel/platforms/os_arch:darwin_arm64": ["@platforms//:incompatible"],
2550 "//build/bazel/platforms/os_arch:darwin_x86_64": ["@platforms//:incompatible"],
2551 "//build/bazel/platforms/os_arch:linux_glibc_x86": ["@platforms//:incompatible"],
2552 "//build/bazel/platforms/os_arch:windows_x86": ["@platforms//:incompatible"],
2553 "//build/bazel/platforms/os_arch:windows_x86_64": ["@platforms//:incompatible"],
2554 "//conditions:default": [],
2555 })`,
2556 }),
2557 })
2558}
2559
2560func TestCcLibraryDisabledArchAndTargetWithDefault(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002561 runCcLibraryTestCase(t, Bp2buildTestCase{
2562 ModuleTypeUnderTest: "cc_library",
2563 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2564 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002565 name: "foo",
2566 srcs: ["foo.cpp"],
2567 enabled: false,
Liz Kammerdfeb1202022-05-13 17:20:20 -04002568 host_supported: true,
Chris Parsons58852a02021-12-09 18:10:18 -05002569 target: {
2570 darwin: {
2571 enabled: true,
2572 },
2573 windows: {
2574 enabled: false,
2575 },
2576 linux_glibc_x86: {
2577 enabled: false,
2578 },
2579 },
2580 include_build_directory: false,
2581}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002582 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002583 "srcs": `["foo.cpp"]`,
2584 "target_compatible_with": `select({
2585 "//build/bazel/platforms/os_arch:darwin_arm64": [],
2586 "//build/bazel/platforms/os_arch:darwin_x86_64": [],
2587 "//conditions:default": ["@platforms//:incompatible"],
2588 })`,
2589 }),
2590 })
2591}
2592
2593func TestCcLibrarySharedDisabled(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002594 runCcLibraryTestCase(t, Bp2buildTestCase{
2595 ModuleTypeUnderTest: "cc_library",
2596 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2597 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002598 name: "foo",
2599 srcs: ["foo.cpp"],
2600 enabled: false,
2601 shared: {
2602 enabled: true,
2603 },
2604 target: {
2605 android: {
2606 shared: {
2607 enabled: false,
2608 },
2609 }
2610 },
2611 include_build_directory: false,
2612}`,
Alixe06d75b2022-08-31 18:28:19 +00002613 ExpectedBazelTargets: []string{MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002614 "srcs": `["foo.cpp"]`,
2615 "target_compatible_with": `["@platforms//:incompatible"]`,
Alixe06d75b2022-08-31 18:28:19 +00002616 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002617 "srcs": `["foo.cpp"]`,
2618 "target_compatible_with": `select({
2619 "//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
2620 "//conditions:default": [],
2621 })`,
2622 }),
2623 },
2624 })
2625}
2626
2627func TestCcLibraryStaticDisabledForSomeArch(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002628 runCcLibraryTestCase(t, Bp2buildTestCase{
2629 ModuleTypeUnderTest: "cc_library",
2630 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2631 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002632 name: "foo",
Liz Kammerdfeb1202022-05-13 17:20:20 -04002633 host_supported: true,
Chris Parsons58852a02021-12-09 18:10:18 -05002634 srcs: ["foo.cpp"],
2635 shared: {
2636 enabled: false
2637 },
2638 target: {
2639 darwin: {
2640 enabled: true,
2641 },
2642 windows: {
2643 enabled: false,
2644 },
2645 linux_glibc_x86: {
2646 shared: {
2647 enabled: true,
2648 },
2649 },
2650 },
2651 include_build_directory: false,
2652}`,
Alixe06d75b2022-08-31 18:28:19 +00002653 ExpectedBazelTargets: []string{MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002654 "srcs": `["foo.cpp"]`,
2655 "target_compatible_with": `select({
2656 "//build/bazel/platforms/os:windows": ["@platforms//:incompatible"],
2657 "//conditions:default": [],
2658 })`,
Alixe06d75b2022-08-31 18:28:19 +00002659 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002660 "srcs": `["foo.cpp"]`,
2661 "target_compatible_with": `select({
2662 "//build/bazel/platforms/os_arch:darwin_arm64": [],
2663 "//build/bazel/platforms/os_arch:darwin_x86_64": [],
2664 "//build/bazel/platforms/os_arch:linux_glibc_x86": [],
2665 "//conditions:default": ["@platforms//:incompatible"],
2666 })`,
2667 }),
2668 }})
2669}
Jingwen Chen0ee88a62022-01-07 14:55:29 +00002670
2671func TestCcLibraryStubs(t *testing.T) {
Wei Li81852ca2022-07-27 00:22:06 -07002672 expectedBazelTargets := makeCcLibraryTargets("a", AttrNameToString{
2673 "has_stubs": `True`,
2674 })
2675 expectedBazelTargets = append(expectedBazelTargets, makeCcStubSuiteTargets("a", AttrNameToString{
2676 "soname": `"a.so"`,
2677 "source_library": `":a"`,
2678 "stubs_symbol_file": `"a.map.txt"`,
2679 "stubs_versions": `[
2680 "28",
2681 "29",
2682 "current",
2683 ]`,
2684 }))
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002685 runCcLibraryTestCase(t, Bp2buildTestCase{
2686 Description: "cc_library stubs",
2687 ModuleTypeUnderTest: "cc_library",
2688 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2689 Dir: "foo/bar",
2690 Filesystem: map[string]string{
Jingwen Chen0ee88a62022-01-07 14:55:29 +00002691 "foo/bar/Android.bp": `
2692cc_library {
2693 name: "a",
2694 stubs: { symbol_file: "a.map.txt", versions: ["28", "29", "current"] },
2695 bazel_module: { bp2build_available: true },
2696 include_build_directory: false,
2697}
2698`,
2699 },
Wei Li81852ca2022-07-27 00:22:06 -07002700 Blueprint: soongCcLibraryPreamble,
2701 ExpectedBazelTargets: expectedBazelTargets,
Jingwen Chen0ee88a62022-01-07 14:55:29 +00002702 },
2703 )
2704}
Liz Kammerf38a8372022-02-04 15:39:00 -05002705
Trevor Radcliffe0ed6b7d2022-09-12 20:19:26 +00002706func TestCcLibraryStubsAcrossConfigsDuplicatesRemoved(t *testing.T) {
2707 runCcLibraryTestCase(t, Bp2buildTestCase{
2708 Description: "stub target generation of the same lib across configs should not result in duplicates",
2709 ModuleTypeUnderTest: "cc_library",
2710 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2711 Filesystem: map[string]string{
2712 "bar.map.txt": "",
2713 },
2714 Blueprint: `
2715cc_library {
2716 name: "barlib",
2717 stubs: { symbol_file: "bar.map.txt", versions: ["28", "29", "current"] },
2718 bazel_module: { bp2build_available: false },
2719}
2720cc_library {
2721 name: "foolib",
2722 shared_libs: ["barlib"],
2723 target: {
2724 android: {
2725 shared_libs: ["barlib"],
2726 },
2727 },
2728 bazel_module: { bp2build_available: true },
2729}`,
2730 ExpectedBazelTargets: makeCcLibraryTargets("foolib", AttrNameToString{
2731 "implementation_dynamic_deps": `select({
2732 "//build/bazel/rules/apex:android-in_apex": [":barlib_stub_libs_current"],
2733 "//conditions:default": [":barlib"],
2734 })`,
2735 "local_includes": `["."]`,
2736 }),
2737 })
2738}
2739
Liz Kammerf38a8372022-02-04 15:39:00 -05002740func TestCcLibraryEscapeLdflags(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002741 runCcLibraryTestCase(t, Bp2buildTestCase{
2742 ModuleTypeUnderTest: "cc_library",
2743 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2744 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammerf38a8372022-02-04 15:39:00 -05002745 name: "foo",
2746 ldflags: ["-Wl,--rpath,${ORIGIN}"],
2747 include_build_directory: false,
2748}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002749 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
Liz Kammerf38a8372022-02-04 15:39:00 -05002750 "linkopts": `["-Wl,--rpath,$${ORIGIN}"]`,
2751 }),
2752 })
2753}
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002754
2755func TestCcLibraryConvertLex(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002756 runCcLibraryTestCase(t, Bp2buildTestCase{
2757 ModuleTypeUnderTest: "cc_library",
2758 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2759 Filesystem: map[string]string{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002760 "foo.c": "",
2761 "bar.cc": "",
2762 "foo1.l": "",
2763 "bar1.ll": "",
2764 "foo2.l": "",
2765 "bar2.ll": "",
2766 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002767 Blueprint: `cc_library {
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002768 name: "foo_lib",
2769 srcs: ["foo.c", "bar.cc", "foo1.l", "foo2.l", "bar1.ll", "bar2.ll"],
2770 lex: { flags: ["--foo_flags"] },
2771 include_build_directory: false,
2772 bazel_module: { bp2build_available: true },
2773}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002774 ExpectedBazelTargets: append([]string{
Alixe06d75b2022-08-31 18:28:19 +00002775 MakeBazelTarget("genlex", "foo_lib_genlex_l", AttrNameToString{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002776 "srcs": `[
2777 "foo1.l",
2778 "foo2.l",
2779 ]`,
2780 "lexopts": `["--foo_flags"]`,
2781 }),
Alixe06d75b2022-08-31 18:28:19 +00002782 MakeBazelTarget("genlex", "foo_lib_genlex_ll", AttrNameToString{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002783 "srcs": `[
2784 "bar1.ll",
2785 "bar2.ll",
2786 ]`,
2787 "lexopts": `["--foo_flags"]`,
2788 }),
2789 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002790 makeCcLibraryTargets("foo_lib", AttrNameToString{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002791 "srcs": `[
2792 "bar.cc",
2793 ":foo_lib_genlex_ll",
2794 ]`,
2795 "srcs_c": `[
2796 "foo.c",
2797 ":foo_lib_genlex_l",
2798 ]`,
2799 })...),
2800 })
2801}
Cole Faust6b29f592022-08-09 09:50:56 -07002802
2803func TestCCLibraryRuntimeDeps(t *testing.T) {
2804 runCcLibrarySharedTestCase(t, Bp2buildTestCase{
2805 Blueprint: `cc_library_shared {
2806 name: "bar",
2807}
2808
2809cc_library {
2810 name: "foo",
2811 runtime_libs: ["foo"],
2812}`,
2813 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002814 MakeBazelTarget("cc_library_shared", "bar", AttrNameToString{
Cole Faust6b29f592022-08-09 09:50:56 -07002815 "local_includes": `["."]`,
2816 }),
Alixe06d75b2022-08-31 18:28:19 +00002817 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Cole Faust6b29f592022-08-09 09:50:56 -07002818 "runtime_deps": `[":foo"]`,
2819 "local_includes": `["."]`,
2820 }),
Alixe06d75b2022-08-31 18:28:19 +00002821 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Cole Faust6b29f592022-08-09 09:50:56 -07002822 "runtime_deps": `[":foo"]`,
2823 "local_includes": `["."]`,
2824 }),
2825 },
2826 })
2827}
Cole Faust5fa4e962022-08-22 14:31:04 -07002828
2829func TestCcLibraryWithInstructionSet(t *testing.T) {
2830 runCcLibraryTestCase(t, Bp2buildTestCase{
2831 ModuleTypeUnderTest: "cc_library",
2832 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2833 Blueprint: `cc_library {
2834 name: "foo",
2835 arch: {
2836 arm: {
2837 instruction_set: "arm",
2838 }
2839 }
2840}
2841`,
2842 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
2843 "features": `select({
2844 "//build/bazel/platforms/arch:arm": [
2845 "arm_isa_arm",
2846 "-arm_isa_thumb",
2847 ],
2848 "//conditions:default": [],
2849 })`,
2850 "local_includes": `["."]`,
2851 }),
2852 })
2853}
Vinh Tran9f6796a2022-08-16 13:10:31 -04002854
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002855func TestCcLibraryEmptySuffix(t *testing.T) {
2856 runCcLibraryTestCase(t, Bp2buildTestCase{
2857 Description: "cc_library with empty suffix",
2858 ModuleTypeUnderTest: "cc_library",
2859 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2860 Filesystem: map[string]string{
2861 "foo.c": "",
2862 },
2863 Blueprint: `cc_library {
2864 name: "foo",
2865 suffix: "",
2866 srcs: ["foo.c"],
2867 include_build_directory: false,
2868}`,
2869 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002870 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002871 "srcs_c": `["foo.c"]`,
2872 }),
Alixe06d75b2022-08-31 18:28:19 +00002873 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002874 "srcs_c": `["foo.c"]`,
2875 "suffix": `""`,
2876 }),
2877 },
2878 })
2879}
2880
2881func TestCcLibrarySuffix(t *testing.T) {
2882 runCcLibraryTestCase(t, Bp2buildTestCase{
2883 Description: "cc_library with suffix",
2884 ModuleTypeUnderTest: "cc_library",
2885 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2886 Filesystem: map[string]string{
2887 "foo.c": "",
2888 },
2889 Blueprint: `cc_library {
2890 name: "foo",
2891 suffix: "-suf",
2892 srcs: ["foo.c"],
2893 include_build_directory: false,
2894}`,
2895 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002896 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002897 "srcs_c": `["foo.c"]`,
2898 }),
Alixe06d75b2022-08-31 18:28:19 +00002899 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002900 "srcs_c": `["foo.c"]`,
2901 "suffix": `"-suf"`,
2902 }),
2903 },
2904 })
2905}
2906
2907func TestCcLibraryArchVariantSuffix(t *testing.T) {
2908 runCcLibraryTestCase(t, Bp2buildTestCase{
2909 Description: "cc_library with arch-variant suffix",
2910 ModuleTypeUnderTest: "cc_library",
2911 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2912 Filesystem: map[string]string{
2913 "foo.c": "",
2914 },
2915 Blueprint: `cc_library {
2916 name: "foo",
2917 arch: {
2918 arm64: { suffix: "-64" },
2919 arm: { suffix: "-32" },
2920 },
2921 srcs: ["foo.c"],
2922 include_build_directory: false,
2923}`,
2924 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002925 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002926 "srcs_c": `["foo.c"]`,
2927 }),
Alixe06d75b2022-08-31 18:28:19 +00002928 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002929 "srcs_c": `["foo.c"]`,
2930 "suffix": `select({
2931 "//build/bazel/platforms/arch:arm": "-32",
2932 "//build/bazel/platforms/arch:arm64": "-64",
2933 "//conditions:default": None,
2934 })`,
2935 }),
2936 },
2937 })
2938}
2939
Vinh Tran9f6796a2022-08-16 13:10:31 -04002940func TestCcLibraryWithAidlSrcs(t *testing.T) {
2941 runCcLibraryTestCase(t, Bp2buildTestCase{
2942 Description: "cc_library with aidl srcs",
2943 ModuleTypeUnderTest: "cc_library",
2944 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2945 Blueprint: `
2946filegroup {
2947 name: "A_aidl",
2948 srcs: ["aidl/A.aidl"],
2949 path: "aidl",
2950}
2951cc_library {
2952 name: "foo",
2953 srcs: [
2954 ":A_aidl",
2955 "B.aidl",
2956 ],
2957}`,
2958 ExpectedBazelTargets: []string{
2959 MakeBazelTargetNoRestrictions("aidl_library", "A_aidl", AttrNameToString{
2960 "srcs": `["aidl/A.aidl"]`,
2961 "strip_import_prefix": `"aidl"`,
2962 }),
Alixe06d75b2022-08-31 18:28:19 +00002963 MakeBazelTarget("aidl_library", "foo_aidl_library", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04002964 "srcs": `["B.aidl"]`,
2965 }),
Alixe06d75b2022-08-31 18:28:19 +00002966 MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04002967 "deps": `[
2968 ":A_aidl",
2969 ":foo_aidl_library",
2970 ]`,
2971 }),
Alixe06d75b2022-08-31 18:28:19 +00002972 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Vinh Tranfde57eb2022-08-29 17:46:58 -04002973 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
2974 "local_includes": `["."]`,
Vinh Tran9f6796a2022-08-16 13:10:31 -04002975 }),
Alixe06d75b2022-08-31 18:28:19 +00002976 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002977 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
2978 "local_includes": `["."]`,
Vinh Tran9f6796a2022-08-16 13:10:31 -04002979 }),
2980 },
2981 })
2982}
2983
2984func TestCcLibraryWithNonAdjacentAidlFilegroup(t *testing.T) {
2985 runCcLibraryTestCase(t, Bp2buildTestCase{
2986 Description: "cc_library with non aidl filegroup",
2987 ModuleTypeUnderTest: "cc_library",
2988 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2989 Filesystem: map[string]string{
2990 "path/to/A/Android.bp": `
2991filegroup {
Vinh Tranfde57eb2022-08-29 17:46:58 -04002992 name: "A_aidl",
2993 srcs: ["aidl/A.aidl"],
2994 path: "aidl",
Vinh Tran9f6796a2022-08-16 13:10:31 -04002995}`,
2996 },
2997 Blueprint: `
2998cc_library {
Vinh Tranfde57eb2022-08-29 17:46:58 -04002999 name: "foo",
3000 srcs: [
3001 ":A_aidl",
3002 ],
Vinh Tran9f6796a2022-08-16 13:10:31 -04003003}`,
3004 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00003005 MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04003006 "deps": `["//path/to/A:A_aidl"]`,
3007 }),
Alixe06d75b2022-08-31 18:28:19 +00003008 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Vinh Tranfde57eb2022-08-29 17:46:58 -04003009 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
3010 "local_includes": `["."]`,
3011 }),
Vinh Tranfde57eb2022-08-29 17:46:58 -04003012 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04003013 "local_includes": `["."]`,
3014 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
Vinh Tranfde57eb2022-08-29 17:46:58 -04003015 }),
3016 },
3017 })
3018}
3019
3020func TestCcLibraryWithExportAidlHeaders(t *testing.T) {
3021 runCcLibraryTestCase(t, Bp2buildTestCase{
3022 Description: "cc_library with export aidl headers",
3023 ModuleTypeUnderTest: "cc_library",
3024 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3025 Blueprint: `
3026cc_library {
3027 name: "foo",
3028 srcs: [
3029 "Foo.aidl",
3030 ],
3031 aidl: {
3032 export_aidl_headers: true,
3033 }
3034}`,
3035 ExpectedBazelTargets: []string{
3036 MakeBazelTarget("aidl_library", "foo_aidl_library", AttrNameToString{
3037 "srcs": `["Foo.aidl"]`,
3038 }),
3039 MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{
3040 "deps": `[":foo_aidl_library"]`,
3041 }),
3042 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04003043 "whole_archive_deps": `[":foo_cc_aidl_library"]`,
3044 "local_includes": `["."]`,
3045 }),
Alixe06d75b2022-08-31 18:28:19 +00003046 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04003047 "whole_archive_deps": `[":foo_cc_aidl_library"]`,
3048 "local_includes": `["."]`,
3049 }),
3050 },
3051 })
3052}
Vinh Tran85fb07c2022-09-16 16:17:48 -04003053
3054func TestCcLibraryWithTargetApex(t *testing.T) {
3055 runCcLibraryTestCase(t, Bp2buildTestCase{
3056 Description: "cc_library with target.apex",
3057 ModuleTypeUnderTest: "cc_library",
3058 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3059 Blueprint: `
3060cc_library {
3061 name: "foo",
3062 shared_libs: ["bar", "baz"],
3063 static_libs: ["baz", "buh"],
3064 target: {
3065 apex: {
3066 exclude_shared_libs: ["bar"],
3067 exclude_static_libs: ["buh"],
3068 }
3069 }
3070}`,
3071 ExpectedBazelTargets: []string{
3072 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
3073 "implementation_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({
3074 "//build/bazel/rules/apex:non_apex": [":buh__BP2BUILD__MISSING__DEP"],
3075 "//conditions:default": [],
3076 })`,
3077 "implementation_dynamic_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({
3078 "//build/bazel/rules/apex:non_apex": [":bar__BP2BUILD__MISSING__DEP"],
3079 "//conditions:default": [],
3080 })`,
3081 "local_includes": `["."]`,
3082 }),
3083 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
3084 "implementation_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({
3085 "//build/bazel/rules/apex:non_apex": [":buh__BP2BUILD__MISSING__DEP"],
3086 "//conditions:default": [],
3087 })`,
3088 "implementation_dynamic_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({
3089 "//build/bazel/rules/apex:non_apex": [":bar__BP2BUILD__MISSING__DEP"],
3090 "//conditions:default": [],
3091 })`,
3092 "local_includes": `["."]`,
3093 }),
3094 },
3095 })
3096}
3097
3098func TestCcLibraryWithTargetApexAndExportLibHeaders(t *testing.T) {
3099 runCcLibraryTestCase(t, Bp2buildTestCase{
3100 Description: "cc_library with target.apex and export_shared|static_lib_headers",
3101 ModuleTypeUnderTest: "cc_library",
3102 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3103 Blueprint: `
3104cc_library_static {
3105 name: "foo",
3106 shared_libs: ["bar", "baz"],
3107 static_libs: ["abc"],
3108 export_shared_lib_headers: ["baz"],
3109 export_static_lib_headers: ["abc"],
3110 target: {
3111 apex: {
3112 exclude_shared_libs: ["baz", "bar"],
3113 exclude_static_libs: ["abc"],
3114 }
3115 }
3116}`,
3117 ExpectedBazelTargets: []string{
3118 MakeBazelTarget("cc_library_static", "foo", AttrNameToString{
3119 "implementation_dynamic_deps": `select({
3120 "//build/bazel/rules/apex:non_apex": [":bar__BP2BUILD__MISSING__DEP"],
3121 "//conditions:default": [],
3122 })`,
3123 "dynamic_deps": `select({
3124 "//build/bazel/rules/apex:non_apex": [":baz__BP2BUILD__MISSING__DEP"],
3125 "//conditions:default": [],
3126 })`,
3127 "deps": `select({
3128 "//build/bazel/rules/apex:non_apex": [":abc__BP2BUILD__MISSING__DEP"],
3129 "//conditions:default": [],
3130 })`,
3131 "local_includes": `["."]`,
3132 }),
3133 },
3134 })
3135}
Trevor Radcliffecee4e052022-09-06 19:31:25 +00003136
3137func TestCcLibraryWithSyspropSrcs(t *testing.T) {
3138 runCcLibraryTestCase(t, Bp2buildTestCase{
3139 Description: "cc_library with sysprop sources",
3140 ModuleTypeUnderTest: "cc_library",
3141 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3142 Blueprint: `
3143cc_library {
3144 name: "foo",
3145 srcs: [
3146 "bar.sysprop",
3147 "baz.sysprop",
3148 "blah.cpp",
3149 ],
3150 min_sdk_version: "5",
3151}`,
3152 ExpectedBazelTargets: []string{
3153 MakeBazelTarget("sysprop_library", "foo_sysprop_library", AttrNameToString{
3154 "srcs": `[
3155 "bar.sysprop",
3156 "baz.sysprop",
3157 ]`,
3158 }),
3159 MakeBazelTarget("cc_sysprop_library_static", "foo_cc_sysprop_library_static", AttrNameToString{
3160 "dep": `":foo_sysprop_library"`,
3161 "min_sdk_version": `"5"`,
3162 }),
3163 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
3164 "srcs": `["blah.cpp"]`,
3165 "local_includes": `["."]`,
3166 "min_sdk_version": `"5"`,
3167 "whole_archive_deps": `[":foo_cc_sysprop_library_static"]`,
3168 }),
3169 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
3170 "srcs": `["blah.cpp"]`,
3171 "local_includes": `["."]`,
3172 "min_sdk_version": `"5"`,
3173 "whole_archive_deps": `[":foo_cc_sysprop_library_static"]`,
3174 }),
3175 },
3176 })
3177}
3178
3179func TestCcLibraryWithSyspropSrcsSomeConfigs(t *testing.T) {
3180 runCcLibraryTestCase(t, Bp2buildTestCase{
3181 Description: "cc_library with sysprop sources in some configs but not others",
3182 ModuleTypeUnderTest: "cc_library",
3183 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3184 Blueprint: `
3185cc_library {
3186 name: "foo",
3187 host_supported: true,
3188 srcs: [
3189 "blah.cpp",
3190 ],
3191 target: {
3192 android: {
3193 srcs: ["bar.sysprop"],
3194 },
3195 },
3196 min_sdk_version: "5",
3197}`,
3198 ExpectedBazelTargets: []string{
3199 MakeBazelTargetNoRestrictions("sysprop_library", "foo_sysprop_library", AttrNameToString{
3200 "srcs": `select({
3201 "//build/bazel/platforms/os:android": ["bar.sysprop"],
3202 "//conditions:default": [],
3203 })`,
3204 }),
3205 MakeBazelTargetNoRestrictions("cc_sysprop_library_static", "foo_cc_sysprop_library_static", AttrNameToString{
3206 "dep": `":foo_sysprop_library"`,
3207 "min_sdk_version": `"5"`,
3208 }),
3209 MakeBazelTargetNoRestrictions("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
3210 "srcs": `["blah.cpp"]`,
3211 "local_includes": `["."]`,
3212 "min_sdk_version": `"5"`,
3213 "whole_archive_deps": `select({
3214 "//build/bazel/platforms/os:android": [":foo_cc_sysprop_library_static"],
3215 "//conditions:default": [],
3216 })`,
3217 }),
3218 MakeBazelTargetNoRestrictions("cc_library_shared", "foo", AttrNameToString{
3219 "srcs": `["blah.cpp"]`,
3220 "local_includes": `["."]`,
3221 "min_sdk_version": `"5"`,
3222 "whole_archive_deps": `select({
3223 "//build/bazel/platforms/os:android": [":foo_cc_sysprop_library_static"],
3224 "//conditions:default": [],
3225 })`,
3226 }),
3227 },
3228 })
3229}
Vinh Tran395a1e92022-09-16 18:27:29 -04003230
3231func TestCcLibraryWithAidlAndSharedLibs(t *testing.T) {
3232 runCcLibraryTestCase(t, Bp2buildTestCase{
3233 Description: "cc_aidl_library depends on shared libs from parent cc_library_static",
3234 ModuleTypeUnderTest: "cc_library",
3235 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3236 Blueprint: `
3237cc_library_static {
3238 name: "foo",
3239 srcs: [
3240 "Foo.aidl",
3241 ],
3242 shared_libs: [
3243 "bar",
3244 "baz",
3245 ],
3246 export_shared_lib_headers: [
3247 "baz",
3248 ],
3249}` +
3250 simpleModuleDoNotConvertBp2build("cc_library", "bar") +
3251 simpleModuleDoNotConvertBp2build("cc_library", "baz"),
3252 ExpectedBazelTargets: []string{
3253 MakeBazelTarget("aidl_library", "foo_aidl_library", AttrNameToString{
3254 "srcs": `["Foo.aidl"]`,
3255 }),
3256 MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{
3257 "deps": `[":foo_aidl_library"]`,
3258 "implementation_dynamic_deps": `[
3259 ":baz",
3260 ":bar",
3261 ]`,
3262 }),
3263 MakeBazelTarget("cc_library_static", "foo", AttrNameToString{
3264 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
3265 "dynamic_deps": `[":baz"]`,
3266 "implementation_dynamic_deps": `[":bar"]`,
3267 "local_includes": `["."]`,
3268 }),
3269 },
3270 })
3271}