Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 1 | // Copyright 2021 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package bp2build |
| 16 | |
| 17 | import ( |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 18 | "fmt" |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 1c92aef | 2021-08-23 16:10:00 +0000 | [diff] [blame] | 19 | "testing" |
| 20 | |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 21 | "android/soong/android" |
| 22 | "android/soong/cc" |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 23 | ) |
| 24 | |
| 25 | const ( |
| 26 | // See cc/testing.go for more context |
| 27 | soongCcLibraryPreamble = ` |
| 28 | cc_defaults { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 29 | name: "linux_bionic_supported", |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 30 | } |
| 31 | |
| 32 | toolchain_library { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 33 | name: "libclang_rt.builtins-x86_64-android", |
| 34 | defaults: ["linux_bionic_supported"], |
| 35 | vendor_available: true, |
| 36 | vendor_ramdisk_available: true, |
| 37 | product_available: true, |
| 38 | recovery_available: true, |
| 39 | native_bridge_supported: true, |
| 40 | src: "", |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 41 | }` |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 42 | |
| 43 | soongCcProtoLibraries = ` |
| 44 | cc_library { |
| 45 | name: "libprotobuf-cpp-lite", |
| 46 | bazel_module: { bp2build_available: false }, |
| 47 | } |
| 48 | |
| 49 | cc_library { |
| 50 | name: "libprotobuf-cpp-full", |
| 51 | bazel_module: { bp2build_available: false }, |
| 52 | }` |
| 53 | |
| 54 | soongCcProtoPreamble = soongCcLibraryPreamble + soongCcProtoLibraries |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 55 | ) |
| 56 | |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 57 | func runCcLibraryTestCase(t *testing.T, tc bp2buildTestCase) { |
Liz Kammer | e4982e8 | 2021-05-25 10:39:35 -0400 | [diff] [blame] | 58 | t.Helper() |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 59 | runBp2BuildTestCase(t, registerCcLibraryModuleTypes, tc) |
| 60 | } |
| 61 | |
| 62 | func registerCcLibraryModuleTypes(ctx android.RegistrationContext) { |
| 63 | cc.RegisterCCBuildComponents(ctx) |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 64 | ctx.RegisterModuleType("filegroup", android.FileGroupFactory) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 65 | ctx.RegisterModuleType("cc_library_static", cc.LibraryStaticFactory) |
Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 66 | ctx.RegisterModuleType("cc_prebuilt_library_static", cc.PrebuiltStaticLibraryFactory) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 67 | ctx.RegisterModuleType("toolchain_library", cc.ToolchainLibraryFactory) |
| 68 | ctx.RegisterModuleType("cc_library_headers", cc.LibraryHeaderFactory) |
| 69 | } |
| 70 | |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 71 | func TestCcLibrarySimple(t *testing.T) { |
| 72 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 73 | description: "cc_library - simple example", |
| 74 | moduleTypeUnderTest: "cc_library", |
| 75 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 76 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 77 | filesystem: map[string]string{ |
| 78 | "android.cpp": "", |
Liz Kammer | 01a16e8 | 2021-07-16 16:33:47 -0400 | [diff] [blame] | 79 | "bionic.cpp": "", |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 80 | "darwin.cpp": "", |
| 81 | // Refer to cc.headerExts for the supported header extensions in Soong. |
| 82 | "header.h": "", |
| 83 | "header.hh": "", |
| 84 | "header.hpp": "", |
| 85 | "header.hxx": "", |
| 86 | "header.h++": "", |
| 87 | "header.inl": "", |
| 88 | "header.inc": "", |
| 89 | "header.ipp": "", |
| 90 | "header.h.generic": "", |
| 91 | "impl.cpp": "", |
| 92 | "linux.cpp": "", |
| 93 | "x86.cpp": "", |
| 94 | "x86_64.cpp": "", |
| 95 | "foo-dir/a.h": "", |
| 96 | }, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 97 | blueprint: soongCcLibraryPreamble + |
| 98 | simpleModuleDoNotConvertBp2build("cc_library_headers", "some-headers") + ` |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 99 | cc_library { |
| 100 | name: "foo-lib", |
| 101 | srcs: ["impl.cpp"], |
| 102 | cflags: ["-Wall"], |
| 103 | header_libs: ["some-headers"], |
| 104 | export_include_dirs: ["foo-dir"], |
| 105 | ldflags: ["-Wl,--exclude-libs=bar.a"], |
| 106 | arch: { |
| 107 | x86: { |
| 108 | ldflags: ["-Wl,--exclude-libs=baz.a"], |
| 109 | srcs: ["x86.cpp"], |
| 110 | }, |
| 111 | x86_64: { |
| 112 | ldflags: ["-Wl,--exclude-libs=qux.a"], |
| 113 | srcs: ["x86_64.cpp"], |
| 114 | }, |
| 115 | }, |
| 116 | target: { |
| 117 | android: { |
| 118 | srcs: ["android.cpp"], |
| 119 | }, |
| 120 | linux_glibc: { |
| 121 | srcs: ["linux.cpp"], |
| 122 | }, |
| 123 | darwin: { |
| 124 | srcs: ["darwin.cpp"], |
| 125 | }, |
Liz Kammer | 01a16e8 | 2021-07-16 16:33:47 -0400 | [diff] [blame] | 126 | bionic: { |
| 127 | srcs: ["bionic.cpp"] |
| 128 | }, |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 129 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 130 | include_build_directory: false, |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 131 | } |
| 132 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 133 | expectedBazelTargets: makeCcLibraryTargets("foo-lib", attrNameToString{ |
| 134 | "copts": `["-Wall"]`, |
| 135 | "export_includes": `["foo-dir"]`, |
| 136 | "implementation_deps": `[":some-headers"]`, |
| 137 | "linkopts": `["-Wl,--exclude-libs=bar.a"] + select({ |
Jingwen Chen | ed9c17d | 2021-04-13 07:14:55 +0000 | [diff] [blame] | 138 | "//build/bazel/platforms/arch:x86": ["-Wl,--exclude-libs=baz.a"], |
| 139 | "//build/bazel/platforms/arch:x86_64": ["-Wl,--exclude-libs=qux.a"], |
| 140 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 141 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 142 | "srcs": `["impl.cpp"] + select({ |
Jingwen Chen | b4628eb | 2021-04-08 14:40:57 +0000 | [diff] [blame] | 143 | "//build/bazel/platforms/arch:x86": ["x86.cpp"], |
| 144 | "//build/bazel/platforms/arch:x86_64": ["x86_64.cpp"], |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 145 | "//conditions:default": [], |
| 146 | }) + select({ |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 147 | "//build/bazel/platforms/os:android": [ |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 148 | "bionic.cpp", |
Liz Kammer | fdd72e6 | 2021-10-11 15:41:03 -0400 | [diff] [blame] | 149 | "android.cpp", |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 150 | ], |
Jingwen Chen | b4628eb | 2021-04-08 14:40:57 +0000 | [diff] [blame] | 151 | "//build/bazel/platforms/os:darwin": ["darwin.cpp"], |
| 152 | "//build/bazel/platforms/os:linux": ["linux.cpp"], |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 153 | "//build/bazel/platforms/os:linux_bionic": ["bionic.cpp"], |
Liz Kammer | 01a16e8 | 2021-07-16 16:33:47 -0400 | [diff] [blame] | 154 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 155 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 156 | }), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 157 | }) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 158 | } |
| 159 | |
| 160 | func TestCcLibraryTrimmedLdAndroid(t *testing.T) { |
| 161 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 162 | description: "cc_library - trimmed example of //bionic/linker:ld-android", |
| 163 | moduleTypeUnderTest: "cc_library", |
| 164 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 165 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 166 | filesystem: map[string]string{ |
| 167 | "ld-android.cpp": "", |
| 168 | "linked_list.h": "", |
| 169 | "linker.h": "", |
| 170 | "linker_block_allocator.h": "", |
| 171 | "linker_cfi.h": "", |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 172 | }, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 173 | blueprint: soongCcLibraryPreamble + ` |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 174 | cc_library_headers { name: "libc_headers" } |
| 175 | cc_library { |
| 176 | name: "fake-ld-android", |
| 177 | srcs: ["ld_android.cpp"], |
| 178 | cflags: [ |
| 179 | "-Wall", |
| 180 | "-Wextra", |
| 181 | "-Wunused", |
| 182 | "-Werror", |
| 183 | ], |
| 184 | header_libs: ["libc_headers"], |
| 185 | ldflags: [ |
| 186 | "-Wl,--exclude-libs=libgcc.a", |
| 187 | "-Wl,--exclude-libs=libgcc_stripped.a", |
| 188 | "-Wl,--exclude-libs=libclang_rt.builtins-arm-android.a", |
| 189 | "-Wl,--exclude-libs=libclang_rt.builtins-aarch64-android.a", |
| 190 | "-Wl,--exclude-libs=libclang_rt.builtins-i686-android.a", |
| 191 | "-Wl,--exclude-libs=libclang_rt.builtins-x86_64-android.a", |
| 192 | ], |
| 193 | arch: { |
| 194 | x86: { |
| 195 | ldflags: ["-Wl,--exclude-libs=libgcc_eh.a"], |
| 196 | }, |
| 197 | x86_64: { |
| 198 | ldflags: ["-Wl,--exclude-libs=libgcc_eh.a"], |
| 199 | }, |
| 200 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 201 | include_build_directory: false, |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 202 | } |
| 203 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 204 | expectedBazelTargets: makeCcLibraryTargets("fake-ld-android", attrNameToString{ |
| 205 | "srcs": `["ld_android.cpp"]`, |
| 206 | "copts": `[ |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 207 | "-Wall", |
| 208 | "-Wextra", |
| 209 | "-Wunused", |
| 210 | "-Werror", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 211 | ]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 212 | "implementation_deps": `[":libc_headers"]`, |
| 213 | "linkopts": `[ |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 214 | "-Wl,--exclude-libs=libgcc.a", |
| 215 | "-Wl,--exclude-libs=libgcc_stripped.a", |
| 216 | "-Wl,--exclude-libs=libclang_rt.builtins-arm-android.a", |
| 217 | "-Wl,--exclude-libs=libclang_rt.builtins-aarch64-android.a", |
| 218 | "-Wl,--exclude-libs=libclang_rt.builtins-i686-android.a", |
| 219 | "-Wl,--exclude-libs=libclang_rt.builtins-x86_64-android.a", |
| 220 | ] + select({ |
Jingwen Chen | b4628eb | 2021-04-08 14:40:57 +0000 | [diff] [blame] | 221 | "//build/bazel/platforms/arch:x86": ["-Wl,--exclude-libs=libgcc_eh.a"], |
| 222 | "//build/bazel/platforms/arch:x86_64": ["-Wl,--exclude-libs=libgcc_eh.a"], |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 223 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 224 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 225 | }), |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 226 | }) |
| 227 | } |
| 228 | |
| 229 | func TestCcLibraryExcludeSrcs(t *testing.T) { |
| 230 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 231 | description: "cc_library exclude_srcs - trimmed example of //external/arm-optimized-routines:libarm-optimized-routines-math", |
| 232 | moduleTypeUnderTest: "cc_library", |
| 233 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 234 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 235 | dir: "external", |
| 236 | filesystem: map[string]string{ |
| 237 | "external/math/cosf.c": "", |
| 238 | "external/math/erf.c": "", |
| 239 | "external/math/erf_data.c": "", |
| 240 | "external/math/erff.c": "", |
| 241 | "external/math/erff_data.c": "", |
| 242 | "external/Android.bp": ` |
Jingwen Chen | 4ecc67d | 2021-04-27 09:47:02 +0000 | [diff] [blame] | 243 | cc_library { |
| 244 | name: "fake-libarm-optimized-routines-math", |
| 245 | exclude_srcs: [ |
| 246 | // Provided by: |
| 247 | // bionic/libm/upstream-freebsd/lib/msun/src/s_erf.c |
| 248 | // bionic/libm/upstream-freebsd/lib/msun/src/s_erff.c |
| 249 | "math/erf.c", |
| 250 | "math/erf_data.c", |
| 251 | "math/erff.c", |
| 252 | "math/erff_data.c", |
| 253 | ], |
| 254 | srcs: [ |
| 255 | "math/*.c", |
| 256 | ], |
| 257 | // arch-specific settings |
| 258 | arch: { |
| 259 | arm64: { |
| 260 | cflags: [ |
| 261 | "-DHAVE_FAST_FMA=1", |
| 262 | ], |
| 263 | }, |
| 264 | }, |
| 265 | bazel_module: { bp2build_available: true }, |
| 266 | } |
| 267 | `, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 268 | }, |
| 269 | blueprint: soongCcLibraryPreamble, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 270 | expectedBazelTargets: makeCcLibraryTargets("fake-libarm-optimized-routines-math", attrNameToString{ |
| 271 | "copts": `select({ |
Jingwen Chen | 4ecc67d | 2021-04-27 09:47:02 +0000 | [diff] [blame] | 272 | "//build/bazel/platforms/arch:arm64": ["-DHAVE_FAST_FMA=1"], |
| 273 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 274 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 275 | "local_includes": `["."]`, |
| 276 | "srcs_c": `["math/cosf.c"]`, |
| 277 | }), |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 278 | }) |
| 279 | } |
| 280 | |
| 281 | func TestCcLibrarySharedStaticProps(t *testing.T) { |
| 282 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 283 | description: "cc_library shared/static props", |
| 284 | moduleTypeUnderTest: "cc_library", |
| 285 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 286 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 287 | filesystem: map[string]string{ |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 288 | "both.cpp": "", |
| 289 | "sharedonly.cpp": "", |
| 290 | "staticonly.cpp": "", |
| 291 | }, |
| 292 | blueprint: soongCcLibraryPreamble + ` |
Jingwen Chen | 53681ef | 2021-04-29 08:15:13 +0000 | [diff] [blame] | 293 | cc_library { |
| 294 | name: "a", |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 295 | srcs: ["both.cpp"], |
| 296 | cflags: ["bothflag"], |
| 297 | shared_libs: ["shared_dep_for_both"], |
| 298 | static_libs: ["static_dep_for_both"], |
| 299 | whole_static_libs: ["whole_static_lib_for_both"], |
| 300 | static: { |
| 301 | srcs: ["staticonly.cpp"], |
| 302 | cflags: ["staticflag"], |
| 303 | shared_libs: ["shared_dep_for_static"], |
| 304 | static_libs: ["static_dep_for_static"], |
| 305 | whole_static_libs: ["whole_static_lib_for_static"], |
| 306 | }, |
| 307 | shared: { |
| 308 | srcs: ["sharedonly.cpp"], |
| 309 | cflags: ["sharedflag"], |
| 310 | shared_libs: ["shared_dep_for_shared"], |
| 311 | static_libs: ["static_dep_for_shared"], |
| 312 | whole_static_libs: ["whole_static_lib_for_shared"], |
| 313 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 314 | include_build_directory: false, |
Jingwen Chen | 53681ef | 2021-04-29 08:15:13 +0000 | [diff] [blame] | 315 | } |
| 316 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 317 | cc_library_static { |
| 318 | name: "static_dep_for_shared", |
| 319 | bazel_module: { bp2build_available: false }, |
| 320 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 321 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 322 | cc_library_static { |
| 323 | name: "static_dep_for_static", |
| 324 | bazel_module: { bp2build_available: false }, |
| 325 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 326 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 327 | cc_library_static { |
| 328 | name: "static_dep_for_both", |
| 329 | bazel_module: { bp2build_available: false }, |
| 330 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 331 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 332 | cc_library_static { |
| 333 | name: "whole_static_lib_for_shared", |
| 334 | bazel_module: { bp2build_available: false }, |
| 335 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 336 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 337 | cc_library_static { |
| 338 | name: "whole_static_lib_for_static", |
| 339 | bazel_module: { bp2build_available: false }, |
| 340 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 341 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 342 | cc_library_static { |
| 343 | name: "whole_static_lib_for_both", |
| 344 | bazel_module: { bp2build_available: false }, |
| 345 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 346 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 347 | cc_library { |
| 348 | name: "shared_dep_for_shared", |
| 349 | bazel_module: { bp2build_available: false }, |
| 350 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 351 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 352 | cc_library { |
| 353 | name: "shared_dep_for_static", |
| 354 | bazel_module: { bp2build_available: false }, |
| 355 | } |
Chris Parsons | 0864831 | 2021-05-06 16:23:19 -0400 | [diff] [blame] | 356 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 357 | cc_library { |
| 358 | name: "shared_dep_for_both", |
| 359 | bazel_module: { bp2build_available: false }, |
| 360 | } |
Jingwen Chen | 53681ef | 2021-04-29 08:15:13 +0000 | [diff] [blame] | 361 | `, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 362 | expectedBazelTargets: []string{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 363 | makeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", attrNameToString{ |
| 364 | "copts": `[ |
| 365 | "bothflag", |
| 366 | "staticflag", |
| 367 | ]`, |
| 368 | "implementation_deps": `[ |
| 369 | ":static_dep_for_both", |
| 370 | ":static_dep_for_static", |
| 371 | ]`, |
| 372 | "implementation_dynamic_deps": `[ |
| 373 | ":shared_dep_for_both", |
| 374 | ":shared_dep_for_static", |
| 375 | ]`, |
| 376 | "srcs": `[ |
| 377 | "both.cpp", |
| 378 | "staticonly.cpp", |
| 379 | ]`, |
| 380 | "whole_archive_deps": `[ |
| 381 | ":whole_static_lib_for_both", |
| 382 | ":whole_static_lib_for_static", |
| 383 | ]`}), |
| 384 | makeBazelTarget("cc_library_shared", "a", attrNameToString{ |
| 385 | "copts": `[ |
| 386 | "bothflag", |
| 387 | "sharedflag", |
| 388 | ]`, |
| 389 | "implementation_deps": `[ |
| 390 | ":static_dep_for_both", |
| 391 | ":static_dep_for_shared", |
| 392 | ]`, |
| 393 | "implementation_dynamic_deps": `[ |
| 394 | ":shared_dep_for_both", |
| 395 | ":shared_dep_for_shared", |
| 396 | ]`, |
| 397 | "srcs": `[ |
| 398 | "both.cpp", |
| 399 | "sharedonly.cpp", |
| 400 | ]`, |
| 401 | "whole_archive_deps": `[ |
| 402 | ":whole_static_lib_for_both", |
| 403 | ":whole_static_lib_for_shared", |
| 404 | ]`, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 405 | }), |
| 406 | }, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 407 | }) |
| 408 | } |
| 409 | |
Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 410 | func TestCcLibraryDeps(t *testing.T) { |
| 411 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 412 | description: "cc_library shared/static props", |
| 413 | moduleTypeUnderTest: "cc_library", |
| 414 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 415 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 416 | filesystem: map[string]string{ |
| 417 | "both.cpp": "", |
| 418 | "sharedonly.cpp": "", |
| 419 | "staticonly.cpp": "", |
| 420 | }, |
| 421 | blueprint: soongCcLibraryPreamble + ` |
| 422 | cc_library { |
| 423 | name: "a", |
| 424 | srcs: ["both.cpp"], |
| 425 | cflags: ["bothflag"], |
| 426 | shared_libs: ["implementation_shared_dep_for_both", "shared_dep_for_both"], |
| 427 | export_shared_lib_headers: ["shared_dep_for_both"], |
| 428 | static_libs: ["implementation_static_dep_for_both", "static_dep_for_both"], |
| 429 | export_static_lib_headers: ["static_dep_for_both", "whole_static_dep_for_both"], |
| 430 | whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_both", "whole_static_dep_for_both"], |
| 431 | static: { |
| 432 | srcs: ["staticonly.cpp"], |
| 433 | cflags: ["staticflag"], |
| 434 | shared_libs: ["implementation_shared_dep_for_static", "shared_dep_for_static"], |
| 435 | export_shared_lib_headers: ["shared_dep_for_static"], |
| 436 | static_libs: ["implementation_static_dep_for_static", "static_dep_for_static"], |
| 437 | export_static_lib_headers: ["static_dep_for_static", "whole_static_dep_for_static"], |
| 438 | whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_static", "whole_static_dep_for_static"], |
| 439 | }, |
| 440 | shared: { |
| 441 | srcs: ["sharedonly.cpp"], |
| 442 | cflags: ["sharedflag"], |
| 443 | shared_libs: ["implementation_shared_dep_for_shared", "shared_dep_for_shared"], |
| 444 | export_shared_lib_headers: ["shared_dep_for_shared"], |
| 445 | static_libs: ["implementation_static_dep_for_shared", "static_dep_for_shared"], |
| 446 | export_static_lib_headers: ["static_dep_for_shared", "whole_static_dep_for_shared"], |
| 447 | whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_shared", "whole_static_dep_for_shared"], |
| 448 | }, |
| 449 | include_build_directory: false, |
| 450 | } |
| 451 | ` + simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_shared") + |
| 452 | simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_shared") + |
| 453 | simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_static") + |
| 454 | simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_static") + |
| 455 | simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_both") + |
| 456 | simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_both") + |
| 457 | simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_shared") + |
| 458 | simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_shared") + |
| 459 | simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_static") + |
| 460 | simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_static") + |
| 461 | simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_both") + |
| 462 | simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_both") + |
| 463 | simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_shared") + |
| 464 | simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_shared") + |
| 465 | simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_static") + |
| 466 | simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_static") + |
| 467 | simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_both") + |
| 468 | simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_both"), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 469 | expectedBazelTargets: []string{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 470 | makeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", attrNameToString{ |
| 471 | "copts": `[ |
| 472 | "bothflag", |
| 473 | "staticflag", |
| 474 | ]`, |
| 475 | "deps": `[ |
| 476 | ":static_dep_for_both", |
| 477 | ":static_dep_for_static", |
| 478 | ]`, |
| 479 | "dynamic_deps": `[ |
| 480 | ":shared_dep_for_both", |
| 481 | ":shared_dep_for_static", |
| 482 | ]`, |
| 483 | "implementation_deps": `[ |
| 484 | ":implementation_static_dep_for_both", |
| 485 | ":implementation_static_dep_for_static", |
| 486 | ]`, |
| 487 | "implementation_dynamic_deps": `[ |
| 488 | ":implementation_shared_dep_for_both", |
| 489 | ":implementation_shared_dep_for_static", |
| 490 | ]`, |
| 491 | "srcs": `[ |
| 492 | "both.cpp", |
| 493 | "staticonly.cpp", |
| 494 | ]`, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 495 | "whole_archive_deps": `[ |
Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 496 | ":not_explicitly_exported_whole_static_dep_for_both", |
| 497 | ":whole_static_dep_for_both", |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 498 | ":not_explicitly_exported_whole_static_dep_for_static", |
| 499 | ":whole_static_dep_for_static", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 500 | ]`, |
| 501 | }), |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 502 | makeBazelTarget("cc_library_shared", "a", attrNameToString{ |
| 503 | "copts": `[ |
| 504 | "bothflag", |
| 505 | "sharedflag", |
| 506 | ]`, |
| 507 | "deps": `[ |
| 508 | ":static_dep_for_both", |
| 509 | ":static_dep_for_shared", |
| 510 | ]`, |
| 511 | "dynamic_deps": `[ |
| 512 | ":shared_dep_for_both", |
| 513 | ":shared_dep_for_shared", |
| 514 | ]`, |
| 515 | "implementation_deps": `[ |
| 516 | ":implementation_static_dep_for_both", |
| 517 | ":implementation_static_dep_for_shared", |
| 518 | ]`, |
| 519 | "implementation_dynamic_deps": `[ |
| 520 | ":implementation_shared_dep_for_both", |
| 521 | ":implementation_shared_dep_for_shared", |
| 522 | ]`, |
| 523 | "srcs": `[ |
| 524 | "both.cpp", |
| 525 | "sharedonly.cpp", |
| 526 | ]`, |
| 527 | "whole_archive_deps": `[ |
| 528 | ":not_explicitly_exported_whole_static_dep_for_both", |
| 529 | ":whole_static_dep_for_both", |
| 530 | ":not_explicitly_exported_whole_static_dep_for_shared", |
| 531 | ":whole_static_dep_for_shared", |
| 532 | ]`, |
| 533 | })}, |
| 534 | }, |
| 535 | ) |
Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 536 | } |
| 537 | |
Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 538 | func TestCcLibraryWholeStaticLibsAlwaysLink(t *testing.T) { |
| 539 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 540 | moduleTypeUnderTest: "cc_library", |
| 541 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 542 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 543 | dir: "foo/bar", |
| 544 | filesystem: map[string]string{ |
| 545 | "foo/bar/Android.bp": ` |
| 546 | cc_library { |
| 547 | name: "a", |
| 548 | whole_static_libs: ["whole_static_lib_for_both"], |
| 549 | static: { |
| 550 | whole_static_libs: ["whole_static_lib_for_static"], |
| 551 | }, |
| 552 | shared: { |
| 553 | whole_static_libs: ["whole_static_lib_for_shared"], |
| 554 | }, |
| 555 | bazel_module: { bp2build_available: true }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 556 | include_build_directory: false, |
Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 557 | } |
| 558 | |
| 559 | cc_prebuilt_library_static { name: "whole_static_lib_for_shared" } |
| 560 | |
| 561 | cc_prebuilt_library_static { name: "whole_static_lib_for_static" } |
| 562 | |
| 563 | cc_prebuilt_library_static { name: "whole_static_lib_for_both" } |
| 564 | `, |
| 565 | }, |
| 566 | blueprint: soongCcLibraryPreamble, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 567 | expectedBazelTargets: []string{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 568 | makeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", attrNameToString{ |
| 569 | "whole_archive_deps": `[ |
| 570 | ":whole_static_lib_for_both_alwayslink", |
| 571 | ":whole_static_lib_for_static_alwayslink", |
| 572 | ]`, |
| 573 | }), |
| 574 | makeBazelTarget("cc_library_shared", "a", attrNameToString{ |
| 575 | "whole_archive_deps": `[ |
| 576 | ":whole_static_lib_for_both_alwayslink", |
| 577 | ":whole_static_lib_for_shared_alwayslink", |
| 578 | ]`, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 579 | }), |
| 580 | }, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 581 | }, |
| 582 | ) |
Liz Kammer | 2d7bbe3 | 2021-06-10 18:20:06 -0400 | [diff] [blame] | 583 | } |
| 584 | |
Jingwen Chen | bcf5304 | 2021-05-26 04:42:42 +0000 | [diff] [blame] | 585 | func TestCcLibrarySharedStaticPropsInArch(t *testing.T) { |
| 586 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 587 | description: "cc_library shared/static props in arch", |
| 588 | moduleTypeUnderTest: "cc_library", |
| 589 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 590 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
Jingwen Chen | bcf5304 | 2021-05-26 04:42:42 +0000 | [diff] [blame] | 591 | dir: "foo/bar", |
| 592 | filesystem: map[string]string{ |
| 593 | "foo/bar/arm.cpp": "", |
| 594 | "foo/bar/x86.cpp": "", |
| 595 | "foo/bar/sharedonly.cpp": "", |
| 596 | "foo/bar/staticonly.cpp": "", |
| 597 | "foo/bar/Android.bp": ` |
| 598 | cc_library { |
| 599 | name: "a", |
| 600 | arch: { |
| 601 | arm: { |
| 602 | shared: { |
| 603 | srcs: ["arm_shared.cpp"], |
| 604 | cflags: ["-DARM_SHARED"], |
| 605 | static_libs: ["arm_static_dep_for_shared"], |
| 606 | whole_static_libs: ["arm_whole_static_dep_for_shared"], |
| 607 | shared_libs: ["arm_shared_dep_for_shared"], |
| 608 | }, |
| 609 | }, |
| 610 | x86: { |
| 611 | static: { |
| 612 | srcs: ["x86_static.cpp"], |
| 613 | cflags: ["-DX86_STATIC"], |
| 614 | static_libs: ["x86_dep_for_static"], |
| 615 | }, |
| 616 | }, |
| 617 | }, |
| 618 | target: { |
| 619 | android: { |
| 620 | shared: { |
| 621 | srcs: ["android_shared.cpp"], |
| 622 | cflags: ["-DANDROID_SHARED"], |
| 623 | static_libs: ["android_dep_for_shared"], |
| 624 | }, |
| 625 | }, |
| 626 | android_arm: { |
| 627 | shared: { |
| 628 | cflags: ["-DANDROID_ARM_SHARED"], |
| 629 | }, |
| 630 | }, |
| 631 | }, |
| 632 | srcs: ["both.cpp"], |
| 633 | cflags: ["bothflag"], |
| 634 | static_libs: ["static_dep_for_both"], |
| 635 | static: { |
| 636 | srcs: ["staticonly.cpp"], |
| 637 | cflags: ["staticflag"], |
| 638 | static_libs: ["static_dep_for_static"], |
| 639 | }, |
| 640 | shared: { |
| 641 | srcs: ["sharedonly.cpp"], |
| 642 | cflags: ["sharedflag"], |
| 643 | static_libs: ["static_dep_for_shared"], |
| 644 | }, |
| 645 | bazel_module: { bp2build_available: true }, |
| 646 | } |
| 647 | |
| 648 | cc_library_static { name: "static_dep_for_shared" } |
| 649 | cc_library_static { name: "static_dep_for_static" } |
| 650 | cc_library_static { name: "static_dep_for_both" } |
| 651 | |
| 652 | cc_library_static { name: "arm_static_dep_for_shared" } |
| 653 | cc_library_static { name: "arm_whole_static_dep_for_shared" } |
| 654 | cc_library_static { name: "arm_shared_dep_for_shared" } |
| 655 | |
| 656 | cc_library_static { name: "x86_dep_for_static" } |
| 657 | |
| 658 | cc_library_static { name: "android_dep_for_shared" } |
| 659 | `, |
| 660 | }, |
| 661 | blueprint: soongCcLibraryPreamble, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 662 | expectedBazelTargets: []string{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 663 | makeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", attrNameToString{ |
| 664 | "copts": `[ |
| 665 | "bothflag", |
| 666 | "staticflag", |
| 667 | ] + select({ |
| 668 | "//build/bazel/platforms/arch:x86": ["-DX86_STATIC"], |
| 669 | "//conditions:default": [], |
| 670 | })`, |
| 671 | "implementation_deps": `[ |
| 672 | ":static_dep_for_both", |
| 673 | ":static_dep_for_static", |
| 674 | ] + select({ |
| 675 | "//build/bazel/platforms/arch:x86": [":x86_dep_for_static"], |
| 676 | "//conditions:default": [], |
| 677 | })`, |
| 678 | "local_includes": `["."]`, |
| 679 | "srcs": `[ |
| 680 | "both.cpp", |
| 681 | "staticonly.cpp", |
| 682 | ] + select({ |
| 683 | "//build/bazel/platforms/arch:x86": ["x86_static.cpp"], |
| 684 | "//conditions:default": [], |
| 685 | })`, |
| 686 | }), |
| 687 | makeBazelTarget("cc_library_shared", "a", attrNameToString{ |
| 688 | "copts": `[ |
| 689 | "bothflag", |
| 690 | "sharedflag", |
| 691 | ] + select({ |
| 692 | "//build/bazel/platforms/arch:arm": ["-DARM_SHARED"], |
| 693 | "//conditions:default": [], |
| 694 | }) + select({ |
| 695 | "//build/bazel/platforms/os:android": ["-DANDROID_SHARED"], |
| 696 | "//conditions:default": [], |
| 697 | }) + select({ |
| 698 | "//build/bazel/platforms/os_arch:android_arm": ["-DANDROID_ARM_SHARED"], |
| 699 | "//conditions:default": [], |
| 700 | })`, |
| 701 | "implementation_deps": `[ |
| 702 | ":static_dep_for_both", |
| 703 | ":static_dep_for_shared", |
| 704 | ] + select({ |
| 705 | "//build/bazel/platforms/arch:arm": [":arm_static_dep_for_shared"], |
| 706 | "//conditions:default": [], |
| 707 | }) + select({ |
| 708 | "//build/bazel/platforms/os:android": [":android_dep_for_shared"], |
| 709 | "//conditions:default": [], |
| 710 | })`, |
| 711 | "implementation_dynamic_deps": `select({ |
| 712 | "//build/bazel/platforms/arch:arm": [":arm_shared_dep_for_shared"], |
| 713 | "//conditions:default": [], |
| 714 | })`, |
| 715 | "local_includes": `["."]`, |
| 716 | "srcs": `[ |
| 717 | "both.cpp", |
| 718 | "sharedonly.cpp", |
| 719 | ] + select({ |
| 720 | "//build/bazel/platforms/arch:arm": ["arm_shared.cpp"], |
| 721 | "//conditions:default": [], |
| 722 | }) + select({ |
| 723 | "//build/bazel/platforms/os:android": ["android_shared.cpp"], |
| 724 | "//conditions:default": [], |
| 725 | })`, |
| 726 | "whole_archive_deps": `select({ |
| 727 | "//build/bazel/platforms/arch:arm": [":arm_whole_static_dep_for_shared"], |
| 728 | "//conditions:default": [], |
| 729 | })`, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 730 | }), |
| 731 | }, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 732 | }, |
| 733 | ) |
Jingwen Chen | bcf5304 | 2021-05-26 04:42:42 +0000 | [diff] [blame] | 734 | } |
| 735 | |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 736 | func TestCcLibrarySharedStaticPropsWithMixedSources(t *testing.T) { |
| 737 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 738 | description: "cc_library shared/static props with c/cpp/s mixed sources", |
| 739 | moduleTypeUnderTest: "cc_library", |
| 740 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 741 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 742 | dir: "foo/bar", |
| 743 | filesystem: map[string]string{ |
| 744 | "foo/bar/both_source.cpp": "", |
| 745 | "foo/bar/both_source.cc": "", |
| 746 | "foo/bar/both_source.c": "", |
| 747 | "foo/bar/both_source.s": "", |
| 748 | "foo/bar/both_source.S": "", |
| 749 | "foo/bar/shared_source.cpp": "", |
| 750 | "foo/bar/shared_source.cc": "", |
| 751 | "foo/bar/shared_source.c": "", |
| 752 | "foo/bar/shared_source.s": "", |
| 753 | "foo/bar/shared_source.S": "", |
| 754 | "foo/bar/static_source.cpp": "", |
| 755 | "foo/bar/static_source.cc": "", |
| 756 | "foo/bar/static_source.c": "", |
| 757 | "foo/bar/static_source.s": "", |
| 758 | "foo/bar/static_source.S": "", |
| 759 | "foo/bar/Android.bp": ` |
| 760 | cc_library { |
| 761 | name: "a", |
| 762 | srcs: [ |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 763 | "both_source.cpp", |
| 764 | "both_source.cc", |
| 765 | "both_source.c", |
| 766 | "both_source.s", |
| 767 | "both_source.S", |
Liz Kammer | 57e2e7a | 2021-09-20 12:55:02 -0400 | [diff] [blame] | 768 | ":both_filegroup", |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 769 | ], |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 770 | static: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 771 | srcs: [ |
| 772 | "static_source.cpp", |
| 773 | "static_source.cc", |
| 774 | "static_source.c", |
| 775 | "static_source.s", |
| 776 | "static_source.S", |
| 777 | ":static_filegroup", |
| 778 | ], |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 779 | }, |
| 780 | shared: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 781 | srcs: [ |
| 782 | "shared_source.cpp", |
| 783 | "shared_source.cc", |
| 784 | "shared_source.c", |
| 785 | "shared_source.s", |
| 786 | "shared_source.S", |
| 787 | ":shared_filegroup", |
| 788 | ], |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 789 | }, |
| 790 | bazel_module: { bp2build_available: true }, |
| 791 | } |
| 792 | |
| 793 | filegroup { |
| 794 | name: "both_filegroup", |
| 795 | srcs: [ |
| 796 | // Not relevant, handled by filegroup macro |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 797 | ], |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 798 | } |
| 799 | |
| 800 | filegroup { |
| 801 | name: "shared_filegroup", |
| 802 | srcs: [ |
| 803 | // Not relevant, handled by filegroup macro |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 804 | ], |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 805 | } |
| 806 | |
| 807 | filegroup { |
| 808 | name: "static_filegroup", |
| 809 | srcs: [ |
| 810 | // Not relevant, handled by filegroup macro |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 811 | ], |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 812 | } |
| 813 | `, |
| 814 | }, |
| 815 | blueprint: soongCcLibraryPreamble, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 816 | expectedBazelTargets: []string{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 817 | makeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", attrNameToString{ |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 818 | "local_includes": `["."]`, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 819 | "srcs": `[ |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 820 | "both_source.cpp", |
Liz Kammer | 57e2e7a | 2021-09-20 12:55:02 -0400 | [diff] [blame] | 821 | "both_source.cc", |
| 822 | ":both_filegroup_cpp_srcs", |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 823 | "static_source.cpp", |
| 824 | "static_source.cc", |
| 825 | ":static_filegroup_cpp_srcs", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 826 | ]`, |
| 827 | "srcs_as": `[ |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 828 | "both_source.s", |
| 829 | "both_source.S", |
| 830 | ":both_filegroup_as_srcs", |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 831 | "static_source.s", |
| 832 | "static_source.S", |
| 833 | ":static_filegroup_as_srcs", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 834 | ]`, |
| 835 | "srcs_c": `[ |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 836 | "both_source.c", |
| 837 | ":both_filegroup_c_srcs", |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 838 | "static_source.c", |
| 839 | ":static_filegroup_c_srcs", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 840 | ]`, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 841 | }), |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 842 | makeBazelTarget("cc_library_shared", "a", attrNameToString{ |
| 843 | "local_includes": `["."]`, |
| 844 | "srcs": `[ |
| 845 | "both_source.cpp", |
| 846 | "both_source.cc", |
| 847 | ":both_filegroup_cpp_srcs", |
| 848 | "shared_source.cpp", |
| 849 | "shared_source.cc", |
| 850 | ":shared_filegroup_cpp_srcs", |
| 851 | ]`, |
| 852 | "srcs_as": `[ |
| 853 | "both_source.s", |
| 854 | "both_source.S", |
| 855 | ":both_filegroup_as_srcs", |
| 856 | "shared_source.s", |
| 857 | "shared_source.S", |
| 858 | ":shared_filegroup_as_srcs", |
| 859 | ]`, |
| 860 | "srcs_c": `[ |
| 861 | "both_source.c", |
| 862 | ":both_filegroup_c_srcs", |
| 863 | "shared_source.c", |
| 864 | ":shared_filegroup_c_srcs", |
| 865 | ]`, |
| 866 | })}}) |
Jingwen Chen | 14a8bda | 2021-06-02 11:10:02 +0000 | [diff] [blame] | 867 | } |
| 868 | |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 869 | func TestCcLibraryNonConfiguredVersionScript(t *testing.T) { |
| 870 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 871 | description: "cc_library non-configured version script", |
| 872 | moduleTypeUnderTest: "cc_library", |
| 873 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 874 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 875 | dir: "foo/bar", |
| 876 | filesystem: map[string]string{ |
| 877 | "foo/bar/Android.bp": ` |
Lukacs T. Berki | 1353e59 | 2021-04-30 15:35:09 +0200 | [diff] [blame] | 878 | cc_library { |
| 879 | name: "a", |
| 880 | srcs: ["a.cpp"], |
| 881 | version_script: "v.map", |
| 882 | bazel_module: { bp2build_available: true }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 883 | include_build_directory: false, |
Lukacs T. Berki | 1353e59 | 2021-04-30 15:35:09 +0200 | [diff] [blame] | 884 | } |
| 885 | `, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 886 | }, |
| 887 | blueprint: soongCcLibraryPreamble, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 888 | expectedBazelTargets: makeCcLibraryTargets("a", attrNameToString{ |
| 889 | "additional_linker_inputs": `["v.map"]`, |
| 890 | "linkopts": `["-Wl,--version-script,$(location v.map)"]`, |
| 891 | "srcs": `["a.cpp"]`, |
| 892 | }), |
| 893 | }, |
| 894 | ) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 895 | } |
| 896 | |
| 897 | func TestCcLibraryConfiguredVersionScript(t *testing.T) { |
| 898 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 899 | description: "cc_library configured version script", |
| 900 | moduleTypeUnderTest: "cc_library", |
| 901 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 902 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 903 | dir: "foo/bar", |
| 904 | filesystem: map[string]string{ |
| 905 | "foo/bar/Android.bp": ` |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 906 | cc_library { |
| 907 | name: "a", |
| 908 | srcs: ["a.cpp"], |
| 909 | arch: { |
| 910 | arm: { |
| 911 | version_script: "arm.map", |
| 912 | }, |
| 913 | arm64: { |
| 914 | version_script: "arm64.map", |
| 915 | }, |
| 916 | }, |
Lukacs T. Berki | 56bb083 | 2021-05-12 12:36:45 +0200 | [diff] [blame] | 917 | |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 918 | bazel_module: { bp2build_available: true }, |
| 919 | include_build_directory: false, |
| 920 | } |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 921 | `, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 922 | }, |
| 923 | blueprint: soongCcLibraryPreamble, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 924 | expectedBazelTargets: makeCcLibraryTargets("a", attrNameToString{ |
| 925 | "additional_linker_inputs": `select({ |
Liz Kammer | d287118 | 2021-10-04 13:54:37 -0400 | [diff] [blame] | 926 | "//build/bazel/platforms/arch:arm": ["arm.map"], |
| 927 | "//build/bazel/platforms/arch:arm64": ["arm64.map"], |
| 928 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 929 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 930 | "linkopts": `select({ |
Liz Kammer | d287118 | 2021-10-04 13:54:37 -0400 | [diff] [blame] | 931 | "//build/bazel/platforms/arch:arm": ["-Wl,--version-script,$(location arm.map)"], |
| 932 | "//build/bazel/platforms/arch:arm64": ["-Wl,--version-script,$(location arm64.map)"], |
| 933 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 934 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 935 | "srcs": `["a.cpp"]`, |
| 936 | }), |
| 937 | }, |
| 938 | ) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 939 | } |
| 940 | |
| 941 | func TestCcLibrarySharedLibs(t *testing.T) { |
| 942 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 943 | description: "cc_library shared_libs", |
| 944 | moduleTypeUnderTest: "cc_library", |
| 945 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 946 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 947 | blueprint: soongCcLibraryPreamble + ` |
Rupert Shuttleworth | c50fa8d | 2021-05-06 02:40:33 -0400 | [diff] [blame] | 948 | cc_library { |
| 949 | name: "mylib", |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 950 | bazel_module: { bp2build_available: false }, |
Rupert Shuttleworth | c50fa8d | 2021-05-06 02:40:33 -0400 | [diff] [blame] | 951 | } |
| 952 | |
| 953 | cc_library { |
| 954 | name: "a", |
| 955 | shared_libs: ["mylib",], |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 956 | include_build_directory: false, |
Rupert Shuttleworth | c50fa8d | 2021-05-06 02:40:33 -0400 | [diff] [blame] | 957 | } |
| 958 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 959 | expectedBazelTargets: makeCcLibraryTargets("a", attrNameToString{ |
| 960 | "implementation_dynamic_deps": `[":mylib"]`, |
| 961 | }), |
| 962 | }, |
| 963 | ) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 964 | } |
| 965 | |
Liz Kammer | 0eae52e | 2021-10-06 10:32:26 -0400 | [diff] [blame] | 966 | func TestCcLibraryFeatures(t *testing.T) { |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 967 | expected_targets := []string{} |
| 968 | expected_targets = append(expected_targets, makeCcLibraryTargets("a", attrNameToString{ |
| 969 | "features": `[ |
| 970 | "disable_pack_relocations", |
| 971 | "-no_undefined_symbols", |
| 972 | ]`, |
| 973 | "srcs": `["a.cpp"]`, |
| 974 | })...) |
| 975 | expected_targets = append(expected_targets, makeCcLibraryTargets("b", attrNameToString{ |
| 976 | "features": `select({ |
| 977 | "//build/bazel/platforms/arch:x86_64": [ |
| 978 | "disable_pack_relocations", |
| 979 | "-no_undefined_symbols", |
| 980 | ], |
| 981 | "//conditions:default": [], |
| 982 | })`, |
| 983 | "srcs": `["b.cpp"]`, |
| 984 | })...) |
| 985 | expected_targets = append(expected_targets, makeCcLibraryTargets("c", attrNameToString{ |
| 986 | "features": `select({ |
| 987 | "//build/bazel/platforms/os:darwin": [ |
| 988 | "disable_pack_relocations", |
| 989 | "-no_undefined_symbols", |
| 990 | ], |
| 991 | "//conditions:default": [], |
| 992 | })`, |
| 993 | "srcs": `["c.cpp"]`, |
| 994 | })...) |
| 995 | |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 996 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 997 | description: "cc_library pack_relocations test", |
| 998 | moduleTypeUnderTest: "cc_library", |
| 999 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1000 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1001 | blueprint: soongCcLibraryPreamble + ` |
Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1002 | cc_library { |
| 1003 | name: "a", |
| 1004 | srcs: ["a.cpp"], |
| 1005 | pack_relocations: false, |
Liz Kammer | 0eae52e | 2021-10-06 10:32:26 -0400 | [diff] [blame] | 1006 | allow_undefined_symbols: true, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1007 | include_build_directory: false, |
Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1008 | } |
| 1009 | |
| 1010 | cc_library { |
| 1011 | name: "b", |
| 1012 | srcs: ["b.cpp"], |
| 1013 | arch: { |
| 1014 | x86_64: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1015 | pack_relocations: false, |
Liz Kammer | 0eae52e | 2021-10-06 10:32:26 -0400 | [diff] [blame] | 1016 | allow_undefined_symbols: true, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1017 | }, |
Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1018 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1019 | include_build_directory: false, |
Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1020 | } |
| 1021 | |
| 1022 | cc_library { |
| 1023 | name: "c", |
| 1024 | srcs: ["c.cpp"], |
| 1025 | target: { |
| 1026 | darwin: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1027 | pack_relocations: false, |
Liz Kammer | 0eae52e | 2021-10-06 10:32:26 -0400 | [diff] [blame] | 1028 | allow_undefined_symbols: true, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1029 | }, |
Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1030 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1031 | include_build_directory: false, |
Rupert Shuttleworth | 143be94 | 2021-05-09 23:55:51 -0400 | [diff] [blame] | 1032 | }`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1033 | expectedBazelTargets: expected_targets, |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 1034 | }) |
| 1035 | } |
| 1036 | |
| 1037 | func TestCcLibrarySpacesInCopts(t *testing.T) { |
| 1038 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1039 | description: "cc_library spaces in copts", |
| 1040 | moduleTypeUnderTest: "cc_library", |
| 1041 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1042 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1043 | blueprint: soongCcLibraryPreamble + ` |
Jingwen Chen | 3950cd6 | 2021-05-12 04:33:00 +0000 | [diff] [blame] | 1044 | cc_library { |
| 1045 | name: "a", |
| 1046 | cflags: ["-include header.h",], |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1047 | include_build_directory: false, |
Jingwen Chen | 3950cd6 | 2021-05-12 04:33:00 +0000 | [diff] [blame] | 1048 | } |
| 1049 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1050 | expectedBazelTargets: makeCcLibraryTargets("a", attrNameToString{ |
| 1051 | "copts": `[ |
Jingwen Chen | 3950cd6 | 2021-05-12 04:33:00 +0000 | [diff] [blame] | 1052 | "-include", |
| 1053 | "header.h", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1054 | ]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1055 | }), |
| 1056 | }, |
| 1057 | ) |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 1058 | } |
| 1059 | |
| 1060 | func TestCcLibraryCppFlagsGoesIntoCopts(t *testing.T) { |
| 1061 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Chris Parsons | 990c4f4 | 2021-05-25 12:10:58 -0400 | [diff] [blame] | 1062 | description: "cc_library cppflags usage", |
Lukacs T. Berki | c1cc3b9 | 2021-05-21 09:37:00 +0200 | [diff] [blame] | 1063 | moduleTypeUnderTest: "cc_library", |
| 1064 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1065 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1066 | blueprint: soongCcLibraryPreamble + `cc_library { |
Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1067 | name: "a", |
| 1068 | srcs: ["a.cpp"], |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1069 | cflags: ["-Wall"], |
Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1070 | cppflags: [ |
| 1071 | "-fsigned-char", |
| 1072 | "-pedantic", |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1073 | ], |
Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1074 | arch: { |
| 1075 | arm64: { |
| 1076 | cppflags: ["-DARM64=1"], |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1077 | }, |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1078 | }, |
Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1079 | target: { |
| 1080 | android: { |
| 1081 | cppflags: ["-DANDROID=1"], |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1082 | }, |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1083 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1084 | include_build_directory: false, |
Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1085 | } |
| 1086 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1087 | expectedBazelTargets: makeCcLibraryTargets("a", attrNameToString{ |
| 1088 | "copts": `["-Wall"]`, |
| 1089 | "cppflags": `[ |
Chris Parsons | 990c4f4 | 2021-05-25 12:10:58 -0400 | [diff] [blame] | 1090 | "-fsigned-char", |
| 1091 | "-pedantic", |
Jingwen Chen | 75be1ca | 2021-05-12 05:04:58 +0000 | [diff] [blame] | 1092 | ] + select({ |
| 1093 | "//build/bazel/platforms/arch:arm64": ["-DARM64=1"], |
| 1094 | "//conditions:default": [], |
| 1095 | }) + select({ |
| 1096 | "//build/bazel/platforms/os:android": ["-DANDROID=1"], |
| 1097 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1098 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1099 | "srcs": `["a.cpp"]`, |
| 1100 | }), |
| 1101 | }, |
| 1102 | ) |
Jingwen Chen | 6393098 | 2021-03-24 10:04:33 -0400 | [diff] [blame] | 1103 | } |
Rupert Shuttleworth | 22cd2eb | 2021-05-27 02:15:54 -0400 | [diff] [blame] | 1104 | |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1105 | func TestCcLibraryExcludeLibs(t *testing.T) { |
| 1106 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1107 | moduleTypeUnderTest: "cc_library", |
| 1108 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1109 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1110 | filesystem: map[string]string{}, |
| 1111 | blueprint: soongCcLibraryStaticPreamble + ` |
| 1112 | cc_library { |
| 1113 | name: "foo_static", |
| 1114 | srcs: ["common.c"], |
| 1115 | whole_static_libs: [ |
| 1116 | "arm_whole_static_lib_excludes", |
| 1117 | "malloc_not_svelte_whole_static_lib_excludes" |
| 1118 | ], |
| 1119 | static_libs: [ |
| 1120 | "arm_static_lib_excludes", |
| 1121 | "malloc_not_svelte_static_lib_excludes" |
| 1122 | ], |
| 1123 | shared_libs: [ |
| 1124 | "arm_shared_lib_excludes", |
| 1125 | ], |
| 1126 | arch: { |
| 1127 | arm: { |
| 1128 | exclude_shared_libs: [ |
| 1129 | "arm_shared_lib_excludes", |
| 1130 | ], |
| 1131 | exclude_static_libs: [ |
| 1132 | "arm_static_lib_excludes", |
| 1133 | "arm_whole_static_lib_excludes", |
| 1134 | ], |
| 1135 | }, |
| 1136 | }, |
| 1137 | product_variables: { |
| 1138 | malloc_not_svelte: { |
| 1139 | shared_libs: ["malloc_not_svelte_shared_lib"], |
| 1140 | whole_static_libs: ["malloc_not_svelte_whole_static_lib"], |
| 1141 | exclude_static_libs: [ |
| 1142 | "malloc_not_svelte_static_lib_excludes", |
| 1143 | "malloc_not_svelte_whole_static_lib_excludes", |
| 1144 | ], |
| 1145 | }, |
| 1146 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1147 | include_build_directory: false, |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1148 | } |
| 1149 | |
| 1150 | cc_library { |
| 1151 | name: "arm_whole_static_lib_excludes", |
| 1152 | bazel_module: { bp2build_available: false }, |
| 1153 | } |
| 1154 | |
| 1155 | cc_library { |
| 1156 | name: "malloc_not_svelte_whole_static_lib", |
| 1157 | bazel_module: { bp2build_available: false }, |
| 1158 | } |
| 1159 | |
| 1160 | cc_library { |
| 1161 | name: "malloc_not_svelte_whole_static_lib_excludes", |
| 1162 | bazel_module: { bp2build_available: false }, |
| 1163 | } |
| 1164 | |
| 1165 | cc_library { |
| 1166 | name: "arm_static_lib_excludes", |
| 1167 | bazel_module: { bp2build_available: false }, |
| 1168 | } |
| 1169 | |
| 1170 | cc_library { |
| 1171 | name: "malloc_not_svelte_static_lib_excludes", |
| 1172 | bazel_module: { bp2build_available: false }, |
| 1173 | } |
| 1174 | |
| 1175 | cc_library { |
| 1176 | name: "arm_shared_lib_excludes", |
| 1177 | bazel_module: { bp2build_available: false }, |
| 1178 | } |
| 1179 | |
| 1180 | cc_library { |
| 1181 | name: "malloc_not_svelte_shared_lib", |
| 1182 | bazel_module: { bp2build_available: false }, |
| 1183 | } |
| 1184 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1185 | expectedBazelTargets: makeCcLibraryTargets("foo_static", attrNameToString{ |
| 1186 | "implementation_deps": `select({ |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1187 | "//build/bazel/platforms/arch:arm": [], |
Chris Parsons | 953b356 | 2021-09-20 15:14:39 -0400 | [diff] [blame] | 1188 | "//conditions:default": [":arm_static_lib_excludes_bp2build_cc_library_static"], |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1189 | }) + select({ |
| 1190 | "//build/bazel/product_variables:malloc_not_svelte": [], |
Chris Parsons | 953b356 | 2021-09-20 15:14:39 -0400 | [diff] [blame] | 1191 | "//conditions:default": [":malloc_not_svelte_static_lib_excludes_bp2build_cc_library_static"], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1192 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1193 | "implementation_dynamic_deps": `select({ |
Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 1194 | "//build/bazel/platforms/arch:arm": [], |
| 1195 | "//conditions:default": [":arm_shared_lib_excludes"], |
| 1196 | }) + select({ |
| 1197 | "//build/bazel/product_variables:malloc_not_svelte": [":malloc_not_svelte_shared_lib"], |
| 1198 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1199 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1200 | "srcs_c": `["common.c"]`, |
| 1201 | "whole_archive_deps": `select({ |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1202 | "//build/bazel/platforms/arch:arm": [], |
Chris Parsons | 953b356 | 2021-09-20 15:14:39 -0400 | [diff] [blame] | 1203 | "//conditions:default": [":arm_whole_static_lib_excludes_bp2build_cc_library_static"], |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1204 | }) + select({ |
Chris Parsons | 953b356 | 2021-09-20 15:14:39 -0400 | [diff] [blame] | 1205 | "//build/bazel/product_variables:malloc_not_svelte": [":malloc_not_svelte_whole_static_lib_bp2build_cc_library_static"], |
| 1206 | "//conditions:default": [":malloc_not_svelte_whole_static_lib_excludes_bp2build_cc_library_static"], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1207 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1208 | }), |
| 1209 | }, |
| 1210 | ) |
Liz Kammer | 47535c5 | 2021-06-02 16:02:22 -0400 | [diff] [blame] | 1211 | } |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1212 | |
| 1213 | func TestCCLibraryNoCrtTrue(t *testing.T) { |
| 1214 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1215 | description: "cc_library - nocrt: true emits attribute", |
| 1216 | moduleTypeUnderTest: "cc_library", |
| 1217 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1218 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 1219 | filesystem: map[string]string{ |
| 1220 | "impl.cpp": "", |
| 1221 | }, |
| 1222 | blueprint: soongCcLibraryPreamble + ` |
| 1223 | cc_library { |
| 1224 | name: "foo-lib", |
| 1225 | srcs: ["impl.cpp"], |
| 1226 | nocrt: true, |
| 1227 | include_build_directory: false, |
| 1228 | } |
| 1229 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1230 | expectedBazelTargets: makeCcLibraryTargets("foo-lib", attrNameToString{ |
| 1231 | "link_crt": `False`, |
| 1232 | "srcs": `["impl.cpp"]`, |
| 1233 | }), |
| 1234 | }, |
| 1235 | ) |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1236 | } |
| 1237 | |
| 1238 | func TestCCLibraryNoCrtFalse(t *testing.T) { |
| 1239 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1240 | description: "cc_library - nocrt: false - does not emit attribute", |
| 1241 | moduleTypeUnderTest: "cc_library", |
| 1242 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1243 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 1244 | filesystem: map[string]string{ |
| 1245 | "impl.cpp": "", |
| 1246 | }, |
| 1247 | blueprint: soongCcLibraryPreamble + ` |
| 1248 | cc_library { |
| 1249 | name: "foo-lib", |
| 1250 | srcs: ["impl.cpp"], |
| 1251 | nocrt: false, |
| 1252 | include_build_directory: false, |
| 1253 | } |
| 1254 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1255 | expectedBazelTargets: makeCcLibraryTargets("foo-lib", attrNameToString{ |
| 1256 | "srcs": `["impl.cpp"]`, |
| 1257 | }), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1258 | }) |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1259 | } |
| 1260 | |
| 1261 | func TestCCLibraryNoCrtArchVariant(t *testing.T) { |
| 1262 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1263 | description: "cc_library - nocrt in select", |
| 1264 | moduleTypeUnderTest: "cc_library", |
| 1265 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1266 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 1267 | filesystem: map[string]string{ |
| 1268 | "impl.cpp": "", |
| 1269 | }, |
| 1270 | blueprint: soongCcLibraryPreamble + ` |
| 1271 | cc_library { |
| 1272 | name: "foo-lib", |
| 1273 | srcs: ["impl.cpp"], |
| 1274 | arch: { |
| 1275 | arm: { |
| 1276 | nocrt: true, |
| 1277 | }, |
| 1278 | x86: { |
| 1279 | nocrt: false, |
| 1280 | }, |
| 1281 | }, |
| 1282 | include_build_directory: false, |
| 1283 | } |
| 1284 | `, |
| 1285 | expectedErr: fmt.Errorf("Android.bp:16:1: module \"foo-lib\": nocrt is not supported for arch variants"), |
| 1286 | }) |
| 1287 | } |
| 1288 | |
| 1289 | func TestCCLibraryNoLibCrtTrue(t *testing.T) { |
| 1290 | runCcLibraryTestCase(t, bp2buildTestCase{ |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1291 | description: "cc_library - simple example", |
| 1292 | moduleTypeUnderTest: "cc_library", |
| 1293 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1294 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 1295 | filesystem: map[string]string{ |
| 1296 | "impl.cpp": "", |
| 1297 | }, |
| 1298 | blueprint: soongCcLibraryPreamble + ` |
| 1299 | cc_library_headers { name: "some-headers" } |
| 1300 | cc_library { |
| 1301 | name: "foo-lib", |
| 1302 | srcs: ["impl.cpp"], |
| 1303 | no_libcrt: true, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1304 | include_build_directory: false, |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1305 | } |
| 1306 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1307 | expectedBazelTargets: makeCcLibraryTargets("foo-lib", attrNameToString{ |
| 1308 | "srcs": `["impl.cpp"]`, |
| 1309 | "use_libcrt": `False`, |
| 1310 | }), |
| 1311 | }) |
| 1312 | } |
| 1313 | |
| 1314 | func makeCcLibraryTargets(name string, attrs attrNameToString) []string { |
| 1315 | STATIC_ONLY_ATTRS := map[string]bool{} |
| 1316 | SHARED_ONLY_ATTRS := map[string]bool{ |
| 1317 | "link_crt": true, |
| 1318 | "additional_linker_inputs": true, |
| 1319 | "linkopts": true, |
| 1320 | "strip": true, |
| 1321 | } |
| 1322 | sharedAttrs := attrNameToString{} |
| 1323 | staticAttrs := attrNameToString{} |
| 1324 | for key, val := range attrs { |
| 1325 | if _, staticOnly := STATIC_ONLY_ATTRS[key]; !staticOnly { |
| 1326 | sharedAttrs[key] = val |
| 1327 | } |
| 1328 | if _, sharedOnly := SHARED_ONLY_ATTRS[key]; !sharedOnly { |
| 1329 | staticAttrs[key] = val |
| 1330 | } |
| 1331 | } |
| 1332 | sharedTarget := makeBazelTarget("cc_library_shared", name, sharedAttrs) |
| 1333 | staticTarget := makeBazelTarget("cc_library_static", name+"_bp2build_cc_library_static", staticAttrs) |
| 1334 | |
| 1335 | return []string{staticTarget, sharedTarget} |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1336 | } |
| 1337 | |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1338 | func TestCCLibraryNoLibCrtFalse(t *testing.T) { |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1339 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1340 | moduleTypeUnderTest: "cc_library", |
| 1341 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1342 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 1343 | filesystem: map[string]string{ |
| 1344 | "impl.cpp": "", |
| 1345 | }, |
| 1346 | blueprint: soongCcLibraryPreamble + ` |
| 1347 | cc_library_headers { name: "some-headers" } |
| 1348 | cc_library { |
| 1349 | name: "foo-lib", |
| 1350 | srcs: ["impl.cpp"], |
| 1351 | no_libcrt: false, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1352 | include_build_directory: false, |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1353 | } |
| 1354 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1355 | expectedBazelTargets: makeCcLibraryTargets("foo-lib", attrNameToString{ |
| 1356 | "srcs": `["impl.cpp"]`, |
| 1357 | "use_libcrt": `True`, |
| 1358 | }), |
| 1359 | }) |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1360 | } |
| 1361 | |
Jingwen Chen | 6ada589 | 2021-09-17 11:38:09 +0000 | [diff] [blame] | 1362 | func TestCCLibraryNoLibCrtArchVariant(t *testing.T) { |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1363 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1364 | moduleTypeUnderTest: "cc_library", |
| 1365 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1366 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 1367 | filesystem: map[string]string{ |
| 1368 | "impl.cpp": "", |
| 1369 | }, |
| 1370 | blueprint: soongCcLibraryPreamble + ` |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1371 | cc_library { |
| 1372 | name: "foo-lib", |
| 1373 | srcs: ["impl.cpp"], |
| 1374 | arch: { |
| 1375 | arm: { |
| 1376 | no_libcrt: true, |
| 1377 | }, |
| 1378 | x86: { |
| 1379 | no_libcrt: true, |
| 1380 | }, |
| 1381 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1382 | include_build_directory: false, |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1383 | } |
| 1384 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1385 | expectedBazelTargets: makeCcLibraryTargets("foo-lib", attrNameToString{ |
| 1386 | "srcs": `["impl.cpp"]`, |
| 1387 | "use_libcrt": `select({ |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1388 | "//build/bazel/platforms/arch:arm": False, |
| 1389 | "//build/bazel/platforms/arch:x86": False, |
| 1390 | "//conditions:default": None, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1391 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1392 | }), |
| 1393 | }) |
Liz Kammer | d366c90 | 2021-06-03 13:43:01 -0400 | [diff] [blame] | 1394 | } |
| 1395 | |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1396 | func TestCcLibraryStrip(t *testing.T) { |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1397 | expectedTargets := []string{} |
| 1398 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("all", attrNameToString{ |
| 1399 | "strip": `{ |
| 1400 | "all": True, |
| 1401 | }`, |
| 1402 | })...) |
| 1403 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols", attrNameToString{ |
| 1404 | "strip": `{ |
| 1405 | "keep_symbols": True, |
| 1406 | }`, |
| 1407 | })...) |
| 1408 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols_and_debug_frame", attrNameToString{ |
| 1409 | "strip": `{ |
| 1410 | "keep_symbols_and_debug_frame": True, |
| 1411 | }`, |
| 1412 | })...) |
| 1413 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols_list", attrNameToString{ |
| 1414 | "strip": `{ |
| 1415 | "keep_symbols_list": ["symbol"], |
| 1416 | }`, |
| 1417 | })...) |
| 1418 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("none", attrNameToString{ |
| 1419 | "strip": `{ |
| 1420 | "none": True, |
| 1421 | }`, |
| 1422 | })...) |
| 1423 | expectedTargets = append(expectedTargets, makeCcLibraryTargets("nothing", attrNameToString{})...) |
| 1424 | |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1425 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1426 | description: "cc_library strip args", |
| 1427 | moduleTypeUnderTest: "cc_library", |
| 1428 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1429 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1430 | blueprint: soongCcLibraryPreamble + ` |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1431 | cc_library { |
| 1432 | name: "nothing", |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1433 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1434 | } |
| 1435 | cc_library { |
| 1436 | name: "keep_symbols", |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1437 | strip: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1438 | keep_symbols: true, |
| 1439 | }, |
| 1440 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1441 | } |
| 1442 | cc_library { |
| 1443 | name: "keep_symbols_and_debug_frame", |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1444 | strip: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1445 | keep_symbols_and_debug_frame: true, |
| 1446 | }, |
| 1447 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1448 | } |
| 1449 | cc_library { |
| 1450 | name: "none", |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1451 | strip: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1452 | none: true, |
| 1453 | }, |
| 1454 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1455 | } |
| 1456 | cc_library { |
| 1457 | name: "keep_symbols_list", |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1458 | strip: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1459 | keep_symbols_list: ["symbol"], |
| 1460 | }, |
| 1461 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1462 | } |
| 1463 | cc_library { |
| 1464 | name: "all", |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1465 | strip: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1466 | all: true, |
| 1467 | }, |
| 1468 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1469 | } |
| 1470 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1471 | expectedBazelTargets: expectedTargets, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1472 | }) |
| 1473 | } |
| 1474 | |
| 1475 | func TestCcLibraryStripWithArch(t *testing.T) { |
| 1476 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1477 | description: "cc_library strip args", |
| 1478 | moduleTypeUnderTest: "cc_library", |
| 1479 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1480 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1481 | blueprint: soongCcLibraryPreamble + ` |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1482 | cc_library { |
| 1483 | name: "multi-arch", |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1484 | target: { |
| 1485 | darwin: { |
| 1486 | strip: { |
| 1487 | keep_symbols_list: ["foo", "bar"] |
| 1488 | } |
| 1489 | }, |
| 1490 | }, |
| 1491 | arch: { |
| 1492 | arm: { |
| 1493 | strip: { |
| 1494 | keep_symbols_and_debug_frame: true, |
| 1495 | }, |
| 1496 | }, |
| 1497 | arm64: { |
| 1498 | strip: { |
| 1499 | keep_symbols: true, |
| 1500 | }, |
| 1501 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1502 | }, |
| 1503 | include_build_directory: false, |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1504 | } |
| 1505 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1506 | expectedBazelTargets: makeCcLibraryTargets("multi-arch", attrNameToString{ |
| 1507 | "strip": `{ |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1508 | "keep_symbols": select({ |
| 1509 | "//build/bazel/platforms/arch:arm64": True, |
| 1510 | "//conditions:default": None, |
| 1511 | }), |
| 1512 | "keep_symbols_and_debug_frame": select({ |
| 1513 | "//build/bazel/platforms/arch:arm": True, |
| 1514 | "//conditions:default": None, |
| 1515 | }), |
| 1516 | "keep_symbols_list": select({ |
| 1517 | "//build/bazel/platforms/os:darwin": [ |
| 1518 | "foo", |
| 1519 | "bar", |
| 1520 | ], |
| 1521 | "//conditions:default": [], |
| 1522 | }), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1523 | }`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1524 | }), |
| 1525 | }, |
| 1526 | ) |
Jingwen Chen | 3d383bb | 2021-06-09 07:18:37 +0000 | [diff] [blame] | 1527 | } |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1528 | |
| 1529 | func TestCcLibrary_SystemSharedLibsRootEmpty(t *testing.T) { |
| 1530 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1531 | description: "cc_library system_shared_libs empty at root", |
| 1532 | moduleTypeUnderTest: "cc_library", |
| 1533 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1534 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 1535 | blueprint: soongCcLibraryPreamble + ` |
| 1536 | cc_library { |
| 1537 | name: "root_empty", |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1538 | system_shared_libs: [], |
| 1539 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1540 | } |
| 1541 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1542 | expectedBazelTargets: makeCcLibraryTargets("root_empty", attrNameToString{ |
| 1543 | "system_dynamic_deps": `[]`, |
| 1544 | }), |
| 1545 | }, |
| 1546 | ) |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1547 | } |
| 1548 | |
| 1549 | func TestCcLibrary_SystemSharedLibsStaticEmpty(t *testing.T) { |
| 1550 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1551 | description: "cc_library system_shared_libs empty for static variant", |
| 1552 | moduleTypeUnderTest: "cc_library", |
| 1553 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1554 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 1555 | blueprint: soongCcLibraryPreamble + ` |
| 1556 | cc_library { |
| 1557 | name: "static_empty", |
| 1558 | static: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1559 | system_shared_libs: [], |
| 1560 | }, |
| 1561 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1562 | } |
| 1563 | `, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1564 | expectedBazelTargets: []string{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1565 | makeBazelTarget("cc_library_static", "static_empty_bp2build_cc_library_static", attrNameToString{ |
| 1566 | "system_dynamic_deps": "[]", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1567 | }), |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1568 | makeBazelTarget("cc_library_shared", "static_empty", attrNameToString{}), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1569 | }, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1570 | }) |
| 1571 | } |
| 1572 | |
| 1573 | func TestCcLibrary_SystemSharedLibsSharedEmpty(t *testing.T) { |
| 1574 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1575 | description: "cc_library system_shared_libs empty for shared variant", |
| 1576 | moduleTypeUnderTest: "cc_library", |
| 1577 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1578 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 1579 | blueprint: soongCcLibraryPreamble + ` |
| 1580 | cc_library { |
| 1581 | name: "shared_empty", |
| 1582 | shared: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1583 | system_shared_libs: [], |
| 1584 | }, |
| 1585 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1586 | } |
| 1587 | `, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1588 | expectedBazelTargets: []string{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1589 | makeBazelTarget("cc_library_static", "shared_empty_bp2build_cc_library_static", attrNameToString{}), |
| 1590 | makeBazelTarget("cc_library_shared", "shared_empty", attrNameToString{ |
| 1591 | "system_dynamic_deps": "[]", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1592 | }), |
| 1593 | }, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1594 | }) |
| 1595 | } |
| 1596 | |
| 1597 | func TestCcLibrary_SystemSharedLibsSharedBionicEmpty(t *testing.T) { |
| 1598 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1599 | description: "cc_library system_shared_libs empty for shared, bionic variant", |
| 1600 | moduleTypeUnderTest: "cc_library", |
| 1601 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1602 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 1603 | blueprint: soongCcLibraryPreamble + ` |
| 1604 | cc_library { |
| 1605 | name: "shared_empty", |
| 1606 | target: { |
| 1607 | bionic: { |
| 1608 | shared: { |
| 1609 | system_shared_libs: [], |
| 1610 | } |
| 1611 | } |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1612 | }, |
| 1613 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1614 | } |
| 1615 | `, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1616 | expectedBazelTargets: []string{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1617 | makeBazelTarget("cc_library_static", "shared_empty_bp2build_cc_library_static", attrNameToString{}), |
| 1618 | makeBazelTarget("cc_library_shared", "shared_empty", attrNameToString{ |
| 1619 | "system_dynamic_deps": "[]", |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1620 | }), |
| 1621 | }, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1622 | }) |
| 1623 | } |
| 1624 | |
| 1625 | func TestCcLibrary_SystemSharedLibsLinuxBionicEmpty(t *testing.T) { |
| 1626 | // Note that this behavior is technically incorrect (it's a simplification). |
| 1627 | // The correct behavior would be if bp2build wrote `system_dynamic_deps = []` |
| 1628 | // only for linux_bionic, but `android` had `["libc", "libdl", "libm"]. |
| 1629 | // b/195791252 tracks the fix. |
| 1630 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1631 | description: "cc_library system_shared_libs empty for linux_bionic variant", |
| 1632 | moduleTypeUnderTest: "cc_library", |
| 1633 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1634 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 1635 | blueprint: soongCcLibraryPreamble + ` |
| 1636 | cc_library { |
| 1637 | name: "target_linux_bionic_empty", |
| 1638 | target: { |
| 1639 | linux_bionic: { |
| 1640 | system_shared_libs: [], |
| 1641 | }, |
| 1642 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1643 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1644 | } |
| 1645 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1646 | expectedBazelTargets: makeCcLibraryTargets("target_linux_bionic_empty", attrNameToString{ |
| 1647 | "system_dynamic_deps": `[]`, |
| 1648 | }), |
| 1649 | }, |
| 1650 | ) |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1651 | } |
| 1652 | |
| 1653 | func TestCcLibrary_SystemSharedLibsBionicEmpty(t *testing.T) { |
| 1654 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1655 | description: "cc_library system_shared_libs empty for bionic variant", |
| 1656 | moduleTypeUnderTest: "cc_library", |
| 1657 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1658 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 1659 | blueprint: soongCcLibraryPreamble + ` |
| 1660 | cc_library { |
| 1661 | name: "target_bionic_empty", |
| 1662 | target: { |
| 1663 | bionic: { |
| 1664 | system_shared_libs: [], |
| 1665 | }, |
| 1666 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1667 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1668 | } |
| 1669 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1670 | expectedBazelTargets: makeCcLibraryTargets("target_bionic_empty", attrNameToString{ |
| 1671 | "system_dynamic_deps": `[]`, |
| 1672 | }), |
| 1673 | }, |
| 1674 | ) |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1675 | } |
| 1676 | |
| 1677 | func TestCcLibrary_SystemSharedLibsSharedAndRoot(t *testing.T) { |
| 1678 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1679 | description: "cc_library system_shared_libs set for shared and root", |
| 1680 | moduleTypeUnderTest: "cc_library", |
| 1681 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1682 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 1683 | blueprint: soongCcLibraryPreamble + ` |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1684 | cc_library { |
| 1685 | name: "libc", |
| 1686 | bazel_module: { bp2build_available: false }, |
| 1687 | } |
| 1688 | cc_library { |
| 1689 | name: "libm", |
| 1690 | bazel_module: { bp2build_available: false }, |
| 1691 | } |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1692 | |
| 1693 | cc_library { |
| 1694 | name: "foo", |
| 1695 | system_shared_libs: ["libc"], |
| 1696 | shared: { |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1697 | system_shared_libs: ["libm"], |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1698 | }, |
Liz Kammer | 8337ea4 | 2021-09-10 10:06:32 -0400 | [diff] [blame] | 1699 | include_build_directory: false, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1700 | } |
| 1701 | `, |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1702 | expectedBazelTargets: []string{ |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1703 | makeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", attrNameToString{ |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1704 | "system_dynamic_deps": `[":libc"]`, |
| 1705 | }), |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1706 | makeBazelTarget("cc_library_shared", "foo", attrNameToString{ |
| 1707 | "system_dynamic_deps": `[ |
| 1708 | ":libc", |
| 1709 | ":libm", |
| 1710 | ]`, |
| 1711 | }), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1712 | }, |
Chris Parsons | 51f8c39 | 2021-08-03 21:01:05 -0400 | [diff] [blame] | 1713 | }) |
| 1714 | } |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1715 | |
| 1716 | func TestCcLibraryOsSelects(t *testing.T) { |
| 1717 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1718 | description: "cc_library - selects for all os targets", |
| 1719 | moduleTypeUnderTest: "cc_library", |
| 1720 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1721 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 1722 | filesystem: map[string]string{}, |
| 1723 | blueprint: soongCcLibraryPreamble + ` |
| 1724 | cc_library_headers { name: "some-headers" } |
| 1725 | cc_library { |
| 1726 | name: "foo-lib", |
| 1727 | srcs: ["base.cpp"], |
| 1728 | target: { |
| 1729 | android: { |
| 1730 | srcs: ["android.cpp"], |
| 1731 | }, |
| 1732 | linux: { |
| 1733 | srcs: ["linux.cpp"], |
| 1734 | }, |
| 1735 | linux_glibc: { |
| 1736 | srcs: ["linux_glibc.cpp"], |
| 1737 | }, |
| 1738 | darwin: { |
| 1739 | srcs: ["darwin.cpp"], |
| 1740 | }, |
| 1741 | bionic: { |
| 1742 | srcs: ["bionic.cpp"], |
| 1743 | }, |
| 1744 | linux_musl: { |
| 1745 | srcs: ["linux_musl.cpp"], |
| 1746 | }, |
| 1747 | windows: { |
| 1748 | srcs: ["windows.cpp"], |
| 1749 | }, |
| 1750 | }, |
| 1751 | include_build_directory: false, |
| 1752 | } |
| 1753 | `, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1754 | expectedBazelTargets: makeCcLibraryTargets("foo-lib", attrNameToString{ |
| 1755 | "srcs": `["base.cpp"] + select({ |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1756 | "//build/bazel/platforms/os:android": [ |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1757 | "linux.cpp", |
Liz Kammer | 9bad9d6 | 2021-10-11 15:40:35 -0400 | [diff] [blame] | 1758 | "bionic.cpp", |
Liz Kammer | fdd72e6 | 2021-10-11 15:41:03 -0400 | [diff] [blame] | 1759 | "android.cpp", |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1760 | ], |
| 1761 | "//build/bazel/platforms/os:darwin": ["darwin.cpp"], |
| 1762 | "//build/bazel/platforms/os:linux": [ |
Liz Kammer | 9bad9d6 | 2021-10-11 15:40:35 -0400 | [diff] [blame] | 1763 | "linux.cpp", |
Liz Kammer | fdd72e6 | 2021-10-11 15:41:03 -0400 | [diff] [blame] | 1764 | "linux_glibc.cpp", |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1765 | ], |
| 1766 | "//build/bazel/platforms/os:linux_bionic": [ |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1767 | "linux.cpp", |
Liz Kammer | 9bad9d6 | 2021-10-11 15:40:35 -0400 | [diff] [blame] | 1768 | "bionic.cpp", |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1769 | ], |
| 1770 | "//build/bazel/platforms/os:linux_musl": [ |
Liz Kammer | 9bad9d6 | 2021-10-11 15:40:35 -0400 | [diff] [blame] | 1771 | "linux.cpp", |
Liz Kammer | fdd72e6 | 2021-10-11 15:41:03 -0400 | [diff] [blame] | 1772 | "linux_musl.cpp", |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1773 | ], |
| 1774 | "//build/bazel/platforms/os:windows": ["windows.cpp"], |
| 1775 | "//conditions:default": [], |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1776 | })`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1777 | }), |
| 1778 | }, |
| 1779 | ) |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1780 | } |
| 1781 | |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1782 | func TestCcLibraryCppStdWithGnuExtensions_ConvertsToFeatureAttr(t *testing.T) { |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1783 | type testCase struct { |
| 1784 | cpp_std string |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1785 | c_std string |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1786 | gnu_extensions string |
| 1787 | bazel_cpp_std string |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1788 | bazel_c_std string |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1789 | } |
| 1790 | |
| 1791 | testCases := []testCase{ |
| 1792 | // Existing usages of cpp_std in AOSP are: |
| 1793 | // experimental, c++11, c++17, c++2a, c++98, gnu++11, gnu++17 |
| 1794 | // |
| 1795 | // not set, only emit if gnu_extensions is disabled. the default (gnu+17 |
| 1796 | // is set in the toolchain.) |
| 1797 | {cpp_std: "", gnu_extensions: "", bazel_cpp_std: ""}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1798 | {cpp_std: "", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c99"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1799 | {cpp_std: "", gnu_extensions: "true", bazel_cpp_std: ""}, |
| 1800 | // experimental defaults to gnu++2a |
| 1801 | {cpp_std: "experimental", gnu_extensions: "", bazel_cpp_std: "gnu++2a"}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1802 | {cpp_std: "experimental", gnu_extensions: "false", bazel_cpp_std: "c++2a", bazel_c_std: "c99"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1803 | {cpp_std: "experimental", gnu_extensions: "true", bazel_cpp_std: "gnu++2a"}, |
| 1804 | // Explicitly setting a c++ std does not use replace gnu++ std even if |
| 1805 | // gnu_extensions is true. |
| 1806 | // "c++11", |
| 1807 | {cpp_std: "c++11", gnu_extensions: "", bazel_cpp_std: "c++11"}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1808 | {cpp_std: "c++11", gnu_extensions: "false", bazel_cpp_std: "c++11", bazel_c_std: "c99"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1809 | {cpp_std: "c++11", gnu_extensions: "true", bazel_cpp_std: "c++11"}, |
| 1810 | // "c++17", |
| 1811 | {cpp_std: "c++17", gnu_extensions: "", bazel_cpp_std: "c++17"}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1812 | {cpp_std: "c++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c99"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1813 | {cpp_std: "c++17", gnu_extensions: "true", bazel_cpp_std: "c++17"}, |
| 1814 | // "c++2a", |
| 1815 | {cpp_std: "c++2a", gnu_extensions: "", bazel_cpp_std: "c++2a"}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1816 | {cpp_std: "c++2a", gnu_extensions: "false", bazel_cpp_std: "c++2a", bazel_c_std: "c99"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1817 | {cpp_std: "c++2a", gnu_extensions: "true", bazel_cpp_std: "c++2a"}, |
| 1818 | // "c++98", |
| 1819 | {cpp_std: "c++98", gnu_extensions: "", bazel_cpp_std: "c++98"}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1820 | {cpp_std: "c++98", gnu_extensions: "false", bazel_cpp_std: "c++98", bazel_c_std: "c99"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1821 | {cpp_std: "c++98", gnu_extensions: "true", bazel_cpp_std: "c++98"}, |
| 1822 | // gnu++ is replaced with c++ if gnu_extensions is explicitly false. |
| 1823 | // "gnu++11", |
| 1824 | {cpp_std: "gnu++11", gnu_extensions: "", bazel_cpp_std: "gnu++11"}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1825 | {cpp_std: "gnu++11", gnu_extensions: "false", bazel_cpp_std: "c++11", bazel_c_std: "c99"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1826 | {cpp_std: "gnu++11", gnu_extensions: "true", bazel_cpp_std: "gnu++11"}, |
| 1827 | // "gnu++17", |
| 1828 | {cpp_std: "gnu++17", gnu_extensions: "", bazel_cpp_std: "gnu++17"}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1829 | {cpp_std: "gnu++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c99"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1830 | {cpp_std: "gnu++17", gnu_extensions: "true", bazel_cpp_std: "gnu++17"}, |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1831 | |
| 1832 | // some c_std test cases |
| 1833 | {c_std: "experimental", gnu_extensions: "", bazel_c_std: "gnu11"}, |
| 1834 | {c_std: "experimental", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c11"}, |
| 1835 | {c_std: "experimental", gnu_extensions: "true", bazel_c_std: "gnu11"}, |
| 1836 | {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "", bazel_cpp_std: "gnu++17", bazel_c_std: "gnu11"}, |
| 1837 | {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c11"}, |
| 1838 | {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "true", bazel_cpp_std: "gnu++17", bazel_c_std: "gnu11"}, |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1839 | } |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1840 | for i, tc := range testCases { |
| 1841 | name_prefix := fmt.Sprintf("a_%v", i) |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1842 | cppStdProp := "" |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1843 | if tc.cpp_std != "" { |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1844 | cppStdProp = fmt.Sprintf(" cpp_std: \"%s\",", tc.cpp_std) |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1845 | } |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1846 | cStdProp := "" |
| 1847 | if tc.c_std != "" { |
| 1848 | cStdProp = fmt.Sprintf(" c_std: \"%s\",", tc.c_std) |
| 1849 | } |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1850 | gnuExtensionsProp := "" |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1851 | if tc.gnu_extensions != "" { |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1852 | gnuExtensionsProp = fmt.Sprintf(" gnu_extensions: %s,", tc.gnu_extensions) |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1853 | } |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1854 | attrs := attrNameToString{} |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1855 | if tc.bazel_cpp_std != "" { |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1856 | attrs["cpp_std"] = fmt.Sprintf(`"%s"`, tc.bazel_cpp_std) |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1857 | } |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1858 | if tc.bazel_c_std != "" { |
| 1859 | attrs["c_std"] = fmt.Sprintf(`"%s"`, tc.bazel_c_std) |
| 1860 | } |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1861 | |
| 1862 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1863 | description: fmt.Sprintf( |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1864 | "cc_library with c_std: %s, cpp_std: %s and gnu_extensions: %s", tc.c_std, tc.cpp_std, tc.gnu_extensions), |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1865 | moduleTypeUnderTest: "cc_library", |
| 1866 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1867 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 1868 | blueprint: soongCcLibraryPreamble + fmt.Sprintf(` |
| 1869 | cc_library { |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1870 | name: "%s_full", |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1871 | %s // cpp_std: *string |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1872 | %s // c_std: *string |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1873 | %s // gnu_extensions: *bool |
| 1874 | include_build_directory: false, |
| 1875 | } |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1876 | `, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp), |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1877 | expectedBazelTargets: makeCcLibraryTargets(name_prefix+"_full", attrs), |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1878 | }) |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1879 | |
| 1880 | runCcLibraryStaticTestCase(t, bp2buildTestCase{ |
| 1881 | description: fmt.Sprintf( |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1882 | "cc_library_static with c_std: %s, cpp_std: %s and gnu_extensions: %s", tc.c_std, tc.cpp_std, tc.gnu_extensions), |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1883 | moduleTypeUnderTest: "cc_library_static", |
| 1884 | moduleTypeUnderTestFactory: cc.LibraryStaticFactory, |
| 1885 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, |
| 1886 | blueprint: soongCcLibraryPreamble + fmt.Sprintf(` |
| 1887 | cc_library_static { |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1888 | name: "%s_static", |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1889 | %s // cpp_std: *string |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1890 | %s // c_std: *string |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1891 | %s // gnu_extensions: *bool |
| 1892 | include_build_directory: false, |
| 1893 | } |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1894 | `, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1895 | expectedBazelTargets: []string{ |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1896 | makeBazelTarget("cc_library_static", name_prefix+"_static", attrs), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1897 | }, |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1898 | }) |
| 1899 | |
| 1900 | runCcLibrarySharedTestCase(t, bp2buildTestCase{ |
| 1901 | description: fmt.Sprintf( |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1902 | "cc_library_shared with c_std: %s, cpp_std: %s and gnu_extensions: %s", tc.c_std, tc.cpp_std, tc.gnu_extensions), |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1903 | moduleTypeUnderTest: "cc_library_shared", |
| 1904 | moduleTypeUnderTestFactory: cc.LibrarySharedFactory, |
| 1905 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibrarySharedBp2Build, |
| 1906 | blueprint: soongCcLibraryPreamble + fmt.Sprintf(` |
| 1907 | cc_library_shared { |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1908 | name: "%s_shared", |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1909 | %s // cpp_std: *string |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1910 | %s // c_std: *string |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1911 | %s // gnu_extensions: *bool |
| 1912 | include_build_directory: false, |
| 1913 | } |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1914 | `, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1915 | expectedBazelTargets: []string{ |
Chris Parsons | 79bd2b7 | 2021-11-29 17:52:41 -0500 | [diff] [blame] | 1916 | makeBazelTarget("cc_library_shared", name_prefix+"_shared", attrs), |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 1917 | }, |
Jingwen Chen | 5b11ab1 | 2021-10-11 17:44:33 +0000 | [diff] [blame] | 1918 | }) |
Jingwen Chen | 97b8531 | 2021-10-08 10:41:31 +0000 | [diff] [blame] | 1919 | } |
Chris Parsons | 2dde0cb | 2021-10-01 14:45:30 -0400 | [diff] [blame] | 1920 | } |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 1921 | |
| 1922 | func TestCcLibraryProtoSimple(t *testing.T) { |
| 1923 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1924 | moduleTypeUnderTest: "cc_library", |
| 1925 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1926 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 1927 | blueprint: soongCcProtoPreamble + `cc_library { |
| 1928 | name: "foo", |
| 1929 | srcs: ["foo.proto"], |
| 1930 | include_build_directory: false, |
| 1931 | }`, |
| 1932 | expectedBazelTargets: []string{ |
| 1933 | makeBazelTarget("proto_library", "foo_proto", attrNameToString{ |
| 1934 | "srcs": `["foo.proto"]`, |
| 1935 | "strip_import_prefix": `""`, |
| 1936 | }), makeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", attrNameToString{ |
| 1937 | "deps": `[":foo_proto"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1938 | }), makeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", attrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 1939 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1940 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 1941 | }), makeBazelTarget("cc_library_shared", "foo", attrNameToString{ |
| 1942 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 1943 | }), |
| 1944 | }, |
| 1945 | }) |
| 1946 | } |
| 1947 | |
| 1948 | func TestCcLibraryProtoNoCanonicalPathFromRoot(t *testing.T) { |
| 1949 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1950 | moduleTypeUnderTest: "cc_library", |
| 1951 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1952 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 1953 | blueprint: soongCcProtoPreamble + `cc_library { |
| 1954 | name: "foo", |
| 1955 | srcs: ["foo.proto"], |
| 1956 | proto: { canonical_path_from_root: false}, |
| 1957 | include_build_directory: false, |
| 1958 | }`, |
| 1959 | expectedBazelTargets: []string{ |
| 1960 | makeBazelTarget("proto_library", "foo_proto", attrNameToString{ |
| 1961 | "srcs": `["foo.proto"]`, |
| 1962 | }), makeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", attrNameToString{ |
| 1963 | "deps": `[":foo_proto"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1964 | }), makeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", attrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 1965 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1966 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 1967 | }), makeBazelTarget("cc_library_shared", "foo", attrNameToString{ |
| 1968 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 1969 | }), |
| 1970 | }, |
| 1971 | }) |
| 1972 | } |
| 1973 | |
| 1974 | func TestCcLibraryProtoExplicitCanonicalPathFromRoot(t *testing.T) { |
| 1975 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 1976 | moduleTypeUnderTest: "cc_library", |
| 1977 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 1978 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 1979 | blueprint: soongCcProtoPreamble + `cc_library { |
| 1980 | name: "foo", |
| 1981 | srcs: ["foo.proto"], |
| 1982 | proto: { canonical_path_from_root: true}, |
| 1983 | include_build_directory: false, |
| 1984 | }`, |
| 1985 | expectedBazelTargets: []string{ |
| 1986 | makeBazelTarget("proto_library", "foo_proto", attrNameToString{ |
| 1987 | "srcs": `["foo.proto"]`, |
| 1988 | "strip_import_prefix": `""`, |
| 1989 | }), makeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", attrNameToString{ |
| 1990 | "deps": `[":foo_proto"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1991 | }), makeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", attrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 1992 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 1993 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 1994 | }), makeBazelTarget("cc_library_shared", "foo", attrNameToString{ |
| 1995 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 1996 | }), |
| 1997 | }, |
| 1998 | }) |
| 1999 | } |
| 2000 | |
| 2001 | func TestCcLibraryProtoFull(t *testing.T) { |
| 2002 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 2003 | moduleTypeUnderTest: "cc_library", |
| 2004 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 2005 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 2006 | blueprint: soongCcProtoPreamble + `cc_library { |
| 2007 | name: "foo", |
| 2008 | srcs: ["foo.proto"], |
| 2009 | proto: { |
| 2010 | canonical_path_from_root: false, |
| 2011 | type: "full", |
| 2012 | }, |
| 2013 | include_build_directory: false, |
| 2014 | }`, |
| 2015 | expectedBazelTargets: []string{ |
| 2016 | makeBazelTarget("proto_library", "foo_proto", attrNameToString{ |
| 2017 | "srcs": `["foo.proto"]`, |
| 2018 | }), makeBazelTarget("cc_proto_library", "foo_cc_proto", attrNameToString{ |
| 2019 | "deps": `[":foo_proto"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 2020 | }), makeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", attrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2021 | "implementation_whole_archive_deps": `[":foo_cc_proto"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 2022 | "deps": `[":libprotobuf-cpp-full"]`, |
| 2023 | }), makeBazelTarget("cc_library_shared", "foo", attrNameToString{ |
| 2024 | "dynamic_deps": `[":libprotobuf-cpp-full"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2025 | }), |
| 2026 | }, |
| 2027 | }) |
| 2028 | } |
| 2029 | |
| 2030 | func TestCcLibraryProtoLite(t *testing.T) { |
| 2031 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 2032 | moduleTypeUnderTest: "cc_library", |
| 2033 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 2034 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 2035 | blueprint: soongCcProtoPreamble + `cc_library { |
| 2036 | name: "foo", |
| 2037 | srcs: ["foo.proto"], |
| 2038 | proto: { |
| 2039 | canonical_path_from_root: false, |
| 2040 | type: "lite", |
| 2041 | }, |
| 2042 | include_build_directory: false, |
| 2043 | }`, |
| 2044 | expectedBazelTargets: []string{ |
| 2045 | makeBazelTarget("proto_library", "foo_proto", attrNameToString{ |
| 2046 | "srcs": `["foo.proto"]`, |
| 2047 | }), makeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", attrNameToString{ |
| 2048 | "deps": `[":foo_proto"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 2049 | }), makeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", attrNameToString{ |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2050 | "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 2051 | "deps": `[":libprotobuf-cpp-lite"]`, |
| 2052 | }), makeBazelTarget("cc_library_shared", "foo", attrNameToString{ |
| 2053 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2054 | }), |
| 2055 | }, |
| 2056 | }) |
| 2057 | } |
| 2058 | |
| 2059 | func TestCcLibraryProtoExportHeaders(t *testing.T) { |
| 2060 | runCcLibraryTestCase(t, bp2buildTestCase{ |
| 2061 | moduleTypeUnderTest: "cc_library", |
| 2062 | moduleTypeUnderTestFactory: cc.LibraryFactory, |
| 2063 | moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryBp2Build, |
| 2064 | blueprint: soongCcProtoPreamble + `cc_library { |
| 2065 | name: "foo", |
| 2066 | srcs: ["foo.proto"], |
| 2067 | proto: { |
| 2068 | canonical_path_from_root: false, |
| 2069 | export_proto_headers: true, |
| 2070 | }, |
| 2071 | include_build_directory: false, |
| 2072 | }`, |
| 2073 | expectedBazelTargets: []string{ |
| 2074 | makeBazelTarget("proto_library", "foo_proto", attrNameToString{ |
| 2075 | "srcs": `["foo.proto"]`, |
| 2076 | }), makeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", attrNameToString{ |
| 2077 | "deps": `[":foo_proto"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 2078 | }), makeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", attrNameToString{ |
| 2079 | "deps": `[":libprotobuf-cpp-lite"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2080 | "whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Chris Parsons | 77acf2e | 2021-12-03 17:27:16 -0500 | [diff] [blame^] | 2081 | }), makeBazelTarget("cc_library_shared", "foo", attrNameToString{ |
| 2082 | "dynamic_deps": `[":libprotobuf-cpp-lite"]`, |
| 2083 | "whole_archive_deps": `[":foo_cc_proto_lite"]`, |
Liz Kammer | 12615db | 2021-09-28 09:19:17 -0400 | [diff] [blame] | 2084 | }), |
| 2085 | }, |
| 2086 | }) |
| 2087 | } |