blob: b6038f917fed7b5089d0ff5a2d6489729f311caa [file] [log] [blame]
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07001/*
2 * Copyright (C) 2016 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
Alan Stokescb27c342018-04-20 17:09:25 +010016#define LOG_TAG "installd"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070017
Alan Stokesa25d90c2017-10-16 10:56:00 +010018#include <array>
Jeff Sharkey90aff262016-12-12 14:28:24 -070019#include <fcntl.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070020#include <stdlib.h>
21#include <string.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070022#include <sys/capability.h>
23#include <sys/file.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070024#include <sys/stat.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070025#include <sys/time.h>
26#include <sys/types.h>
27#include <sys/resource.h>
28#include <sys/wait.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070029#include <unistd.h>
30
Andreas Gampe023b2242018-02-28 16:03:25 -080031#include <iomanip>
32
Alan Stokesa25d90c2017-10-16 10:56:00 +010033#include <android-base/file.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070034#include <android-base/logging.h>
Andreas Gampe6a9cf722017-07-24 16:49:10 -070035#include <android-base/properties.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070036#include <android-base/stringprintf.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070037#include <android-base/strings.h>
38#include <android-base/unique_fd.h>
Calin Juravle80a21252017-01-17 14:43:25 -080039#include <cutils/fs.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070040#include <cutils/properties.h>
41#include <cutils/sched_policy.h>
Andreas Gampefa2dadd2018-02-28 19:52:47 -080042#include <dex2oat_return_codes.h>
Mark Salyzyn7823e122016-09-29 08:08:05 -070043#include <log/log.h> // TODO: Move everything to base/logging.
Alan Stokesa25d90c2017-10-16 10:56:00 +010044#include <openssl/sha.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070045#include <private/android_filesystem_config.h>
Calin Juravlecb556e32017-04-04 20:22:50 -070046#include <selinux/android.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070047#include <system/thread_defs.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070048
49#include "dexopt.h"
Andreas Gampefa2dadd2018-02-28 19:52:47 -080050#include "dexopt_return_codes.h"
Jeff Sharkeyc1149c92017-09-21 14:51:09 -060051#include "globals.h"
Jeff Sharkey90aff262016-12-12 14:28:24 -070052#include "installd_deps.h"
53#include "otapreopt_utils.h"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070054#include "utils.h"
55
Jeff Sharkey90aff262016-12-12 14:28:24 -070056using android::base::EndsWith;
Alan Stokesa25d90c2017-10-16 10:56:00 +010057using android::base::ReadFully;
58using android::base::StringPrintf;
59using android::base::WriteFully;
Calin Juravle1a0af3b2017-03-09 14:33:33 -080060using android::base::unique_fd;
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070061
62namespace android {
63namespace installd {
64
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -070065// Should minidebug info be included in compiled artifacts? Even if this value is
66// "true," usage might still be conditional to other constraints, e.g., system
67// property overrides.
68static constexpr bool kEnableMinidebugInfo = true;
69
70static constexpr const char* kMinidebugInfoSystemProperty = "dalvik.vm.dex2oat-minidebuginfo";
71static constexpr bool kMinidebugInfoSystemPropertyDefault = false;
72static constexpr const char* kMinidebugDex2oatFlag = "--generate-mini-debug-info";
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -080073static constexpr const char* kDisableCompactDexFlag = "--compact-dex-level=none";
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -070074
Andreas Gampefa2dadd2018-02-28 19:52:47 -080075
Calin Juravle114f0812017-03-08 19:05:07 -080076// Deleter using free() for use with std::unique_ptr<>. See also UniqueCPtr<> below.
77struct FreeDelete {
78 // NOTE: Deleting a const object is valid but free() takes a non-const pointer.
79 void operator()(const void* ptr) const {
80 free(const_cast<void*>(ptr));
81 }
82};
83
84// Alias for std::unique_ptr<> that uses the C function free() to delete objects.
85template <typename T>
86using UniqueCPtr = std::unique_ptr<T, FreeDelete>;
87
Calin Juravle1a0af3b2017-03-09 14:33:33 -080088static unique_fd invalid_unique_fd() {
89 return unique_fd(-1);
90}
91
Andreas Gampe6a9cf722017-07-24 16:49:10 -070092static bool is_debug_runtime() {
93 return android::base::GetProperty("persist.sys.dalvik.vm.lib.2", "") == "libartd.so";
94}
95
David Sehra3b5ab62017-10-25 14:27:29 -070096static bool is_debuggable_build() {
97 return android::base::GetBoolProperty("ro.debuggable", false);
98}
99
Jeff Sharkey90aff262016-12-12 14:28:24 -0700100static bool clear_profile(const std::string& profile) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800101 unique_fd ufd(open(profile.c_str(), O_WRONLY | O_NOFOLLOW | O_CLOEXEC));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700102 if (ufd.get() < 0) {
103 if (errno != ENOENT) {
104 PLOG(WARNING) << "Could not open profile " << profile;
105 return false;
106 } else {
107 // Nothing to clear. That's ok.
108 return true;
109 }
110 }
111
112 if (flock(ufd.get(), LOCK_EX | LOCK_NB) != 0) {
113 if (errno != EWOULDBLOCK) {
114 PLOG(WARNING) << "Error locking profile " << profile;
115 }
116 // This implies that the app owning this profile is running
117 // (and has acquired the lock).
118 //
119 // If we can't acquire the lock bail out since clearing is useless anyway
120 // (the app will write again to the profile).
121 //
122 // Note:
123 // This does not impact the this is not an issue for the profiling correctness.
124 // In case this is needed because of an app upgrade, profiles will still be
125 // eventually cleared by the app itself due to checksum mismatch.
126 // If this is needed because profman advised, then keeping the data around
127 // until the next run is again not an issue.
128 //
129 // If the app attempts to acquire a lock while we've held one here,
130 // it will simply skip the current write cycle.
131 return false;
132 }
133
134 bool truncated = ftruncate(ufd.get(), 0) == 0;
135 if (!truncated) {
136 PLOG(WARNING) << "Could not truncate " << profile;
137 }
138 if (flock(ufd.get(), LOCK_UN) != 0) {
139 PLOG(WARNING) << "Error unlocking profile " << profile;
140 }
141 return truncated;
142}
143
Calin Juravle114f0812017-03-08 19:05:07 -0800144// Clear the reference profile for the given location.
Calin Juravle824a64d2018-01-18 20:23:17 -0800145// The location is the profile name for primary apks or the dex path for secondary dex files.
146static bool clear_reference_profile(const std::string& package_name, const std::string& location,
147 bool is_secondary_dex) {
148 return clear_profile(create_reference_profile_path(package_name, location, is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700149}
150
Calin Juravle114f0812017-03-08 19:05:07 -0800151// Clear the reference profile for the given location.
Calin Juravle824a64d2018-01-18 20:23:17 -0800152// The location is the profile name for primary apks or the dex path for secondary dex files.
153static bool clear_current_profile(const std::string& package_name, const std::string& location,
154 userid_t user, bool is_secondary_dex) {
155 return clear_profile(create_current_profile_path(user, package_name, location,
156 is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700157}
158
Calin Juravle114f0812017-03-08 19:05:07 -0800159// Clear the reference profile for the primary apk of the given package.
Calin Juravle824a64d2018-01-18 20:23:17 -0800160// The location is the profile name for primary apks or the dex path for secondary dex files.
161bool clear_primary_reference_profile(const std::string& package_name,
162 const std::string& location) {
163 return clear_reference_profile(package_name, location, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800164}
165
166// Clear all current profile for the primary apk of the given package.
Calin Juravle824a64d2018-01-18 20:23:17 -0800167// The location is the profile name for primary apks or the dex path for secondary dex files.
168bool clear_primary_current_profiles(const std::string& package_name, const std::string& location) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700169 bool success = true;
Calin Juravle114f0812017-03-08 19:05:07 -0800170 // For secondary dex files, we don't really need the user but we use it for sanity checks.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700171 std::vector<userid_t> users = get_known_users(/*volume_uuid*/ nullptr);
172 for (auto user : users) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800173 success &= clear_current_profile(package_name, location, user, /*is_secondary_dex*/false);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700174 }
175 return success;
176}
177
Calin Juravle114f0812017-03-08 19:05:07 -0800178// Clear the current profile for the primary apk of the given package and user.
Calin Juravle824a64d2018-01-18 20:23:17 -0800179bool clear_primary_current_profile(const std::string& package_name, const std::string& location,
180 userid_t user) {
181 return clear_current_profile(package_name, location, user, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800182}
183
Jeff Sharkey90aff262016-12-12 14:28:24 -0700184static int split_count(const char *str)
185{
186 char *ctx;
187 int count = 0;
188 char buf[kPropertyValueMax];
189
Jeff Sharkeyc1149c92017-09-21 14:51:09 -0600190 strlcpy(buf, str, sizeof(buf));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700191 char *pBuf = buf;
192
Yi Kong954cf642018-07-17 16:16:24 -0700193 while(strtok_r(pBuf, " ", &ctx) != nullptr) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700194 count++;
Yi Kong954cf642018-07-17 16:16:24 -0700195 pBuf = nullptr;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700196 }
197
198 return count;
199}
200
201static int split(char *buf, const char **argv)
202{
203 char *ctx;
204 int count = 0;
205 char *tok;
206 char *pBuf = buf;
207
Yi Kong954cf642018-07-17 16:16:24 -0700208 while((tok = strtok_r(pBuf, " ", &ctx)) != nullptr) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700209 argv[count++] = tok;
Yi Kong954cf642018-07-17 16:16:24 -0700210 pBuf = nullptr;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700211 }
212
213 return count;
214}
215
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700216static const char* get_location_from_path(const char* path) {
217 static constexpr char kLocationSeparator = '/';
218 const char *location = strrchr(path, kLocationSeparator);
Yi Kong954cf642018-07-17 16:16:24 -0700219 if (location == nullptr) {
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700220 return path;
221 } else {
222 // Skip the separator character.
223 return location + 1;
224 }
225}
226
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800227[[ noreturn ]]
Jeff Sharkey90aff262016-12-12 14:28:24 -0700228static void run_dex2oat(int zip_fd, int oat_fd, int input_vdex_fd, int output_vdex_fd, int image_fd,
229 const char* input_file_name, const char* output_file_name, int swap_fd,
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100230 const char* instruction_set, const char* compiler_filter,
Andreas Gampea73a0cb2017-11-02 18:14:42 -0700231 bool debuggable, bool post_bootcomplete, bool background_job_compile, int profile_fd,
Calin Juravle62c5a372018-02-01 17:03:23 +0000232 const char* class_loader_context, int target_sdk_version, bool enable_hidden_api_checks,
Mathieu Chartierf69c2f72018-03-06 13:55:58 -0800233 bool generate_compact_dex, int dex_metadata_fd, const char* compilation_reason) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700234 static const unsigned int MAX_INSTRUCTION_SET_LEN = 7;
235
236 if (strlen(instruction_set) >= MAX_INSTRUCTION_SET_LEN) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800237 LOG(ERROR) << "Instruction set '" << instruction_set << "' longer than max length of "
238 << MAX_INSTRUCTION_SET_LEN;
239 exit(DexoptReturnCodes::kInstructionSetLength);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700240 }
241
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700242 // Get the relative path to the input file.
243 const char* relative_input_file_name = get_location_from_path(input_file_name);
244
Jeff Sharkey90aff262016-12-12 14:28:24 -0700245 char dex2oat_Xms_flag[kPropertyValueMax];
Yi Kong954cf642018-07-17 16:16:24 -0700246 bool have_dex2oat_Xms_flag = get_property("dalvik.vm.dex2oat-Xms", dex2oat_Xms_flag, nullptr) > 0;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700247
248 char dex2oat_Xmx_flag[kPropertyValueMax];
Yi Kong954cf642018-07-17 16:16:24 -0700249 bool have_dex2oat_Xmx_flag = get_property("dalvik.vm.dex2oat-Xmx", dex2oat_Xmx_flag, nullptr) > 0;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700250
251 char dex2oat_threads_buf[kPropertyValueMax];
252 bool have_dex2oat_threads_flag = get_property(post_bootcomplete
253 ? "dalvik.vm.dex2oat-threads"
254 : "dalvik.vm.boot-dex2oat-threads",
255 dex2oat_threads_buf,
Yi Kong954cf642018-07-17 16:16:24 -0700256 nullptr) > 0;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700257 char dex2oat_threads_arg[kPropertyValueMax + 2];
258 if (have_dex2oat_threads_flag) {
259 sprintf(dex2oat_threads_arg, "-j%s", dex2oat_threads_buf);
260 }
261
262 char dex2oat_isa_features_key[kPropertyKeyMax];
263 sprintf(dex2oat_isa_features_key, "dalvik.vm.isa.%s.features", instruction_set);
264 char dex2oat_isa_features[kPropertyValueMax];
265 bool have_dex2oat_isa_features = get_property(dex2oat_isa_features_key,
Yi Kong954cf642018-07-17 16:16:24 -0700266 dex2oat_isa_features, nullptr) > 0;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700267
268 char dex2oat_isa_variant_key[kPropertyKeyMax];
269 sprintf(dex2oat_isa_variant_key, "dalvik.vm.isa.%s.variant", instruction_set);
270 char dex2oat_isa_variant[kPropertyValueMax];
271 bool have_dex2oat_isa_variant = get_property(dex2oat_isa_variant_key,
Yi Kong954cf642018-07-17 16:16:24 -0700272 dex2oat_isa_variant, nullptr) > 0;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700273
274 const char *dex2oat_norelocation = "-Xnorelocate";
275 bool have_dex2oat_relocation_skip_flag = false;
276
277 char dex2oat_flags[kPropertyValueMax];
278 int dex2oat_flags_count = get_property("dalvik.vm.dex2oat-flags",
Yi Kong954cf642018-07-17 16:16:24 -0700279 dex2oat_flags, nullptr) <= 0 ? 0 : split_count(dex2oat_flags);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700280 ALOGV("dalvik.vm.dex2oat-flags=%s\n", dex2oat_flags);
281
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100282 // If we are booting without the real /data, don't spend time compiling.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700283 char vold_decrypt[kPropertyValueMax];
284 bool have_vold_decrypt = get_property("vold.decrypt", vold_decrypt, "") > 0;
285 bool skip_compilation = (have_vold_decrypt &&
286 (strcmp(vold_decrypt, "trigger_restart_min_framework") == 0 ||
287 (strcmp(vold_decrypt, "1") == 0)));
288
289 bool generate_debug_info = property_get_bool("debug.generate-debug-info", false);
Mathieu Chartierf2088282018-10-26 15:07:50 -0700290 const bool resolve_startup_strings =
291 property_get_bool("dalvik.vm.dex2oat-resolve-startup-strings", false);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700292
293 char app_image_format[kPropertyValueMax];
294 char image_format_arg[strlen("--image-format=") + kPropertyValueMax];
295 bool have_app_image_format =
Yi Kong954cf642018-07-17 16:16:24 -0700296 image_fd >= 0 && get_property("dalvik.vm.appimageformat", app_image_format, nullptr) > 0;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700297 if (have_app_image_format) {
298 sprintf(image_format_arg, "--image-format=%s", app_image_format);
299 }
300
301 char dex2oat_large_app_threshold[kPropertyValueMax];
302 bool have_dex2oat_large_app_threshold =
Yi Kong954cf642018-07-17 16:16:24 -0700303 get_property("dalvik.vm.dex2oat-very-large", dex2oat_large_app_threshold, nullptr) > 0;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700304 char dex2oat_large_app_threshold_arg[strlen("--very-large-app-threshold=") + kPropertyValueMax];
305 if (have_dex2oat_large_app_threshold) {
306 sprintf(dex2oat_large_app_threshold_arg,
307 "--very-large-app-threshold=%s",
308 dex2oat_large_app_threshold);
309 }
310
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700311 // If the runtime was requested to use libartd.so, we'll run dex2oatd, otherwise dex2oat.
David Sehra3b5ab62017-10-25 14:27:29 -0700312 const char* dex2oat_bin = "/system/bin/dex2oat";
Andreas Gampee87fe0a2018-03-01 23:55:53 -0800313 constexpr const char* kDex2oatDebugPath = "/system/bin/dex2oatd";
David Sehr31419e72018-05-24 15:00:09 -0700314 // Do not use dex2oatd for release candidates (give dex2oat more soak time).
315 bool is_release = android::base::GetProperty("ro.build.version.codename", "") == "REL";
316 if (is_debug_runtime() || (background_job_compile && is_debuggable_build() && !is_release)) {
Andreas Gampee87fe0a2018-03-01 23:55:53 -0800317 if (access(kDex2oatDebugPath, X_OK) == 0) {
318 dex2oat_bin = kDex2oatDebugPath;
319 }
David Sehra3b5ab62017-10-25 14:27:29 -0700320 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700321
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -0700322 bool generate_minidebug_info = kEnableMinidebugInfo &&
323 android::base::GetBoolProperty(kMinidebugInfoSystemProperty,
324 kMinidebugInfoSystemPropertyDefault);
325
Jeff Sharkey90aff262016-12-12 14:28:24 -0700326 static const char* RUNTIME_ARG = "--runtime-arg";
327
328 static const int MAX_INT_LEN = 12; // '-'+10dig+'\0' -OR- 0x+8dig
329
George Burgess IV36cebe772017-01-25 11:52:01 -0800330 // clang FORTIFY doesn't let us use strlen in constant array bounds, so we
331 // use arraysize instead.
332 char zip_fd_arg[arraysize("--zip-fd=") + MAX_INT_LEN];
333 char zip_location_arg[arraysize("--zip-location=") + PKG_PATH_MAX];
334 char input_vdex_fd_arg[arraysize("--input-vdex-fd=") + MAX_INT_LEN];
335 char output_vdex_fd_arg[arraysize("--output-vdex-fd=") + MAX_INT_LEN];
336 char oat_fd_arg[arraysize("--oat-fd=") + MAX_INT_LEN];
337 char oat_location_arg[arraysize("--oat-location=") + PKG_PATH_MAX];
338 char instruction_set_arg[arraysize("--instruction-set=") + MAX_INSTRUCTION_SET_LEN];
339 char instruction_set_variant_arg[arraysize("--instruction-set-variant=") + kPropertyValueMax];
340 char instruction_set_features_arg[arraysize("--instruction-set-features=") + kPropertyValueMax];
341 char dex2oat_Xms_arg[arraysize("-Xms") + kPropertyValueMax];
342 char dex2oat_Xmx_arg[arraysize("-Xmx") + kPropertyValueMax];
343 char dex2oat_compiler_filter_arg[arraysize("--compiler-filter=") + kPropertyValueMax];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700344 bool have_dex2oat_swap_fd = false;
George Burgess IV36cebe772017-01-25 11:52:01 -0800345 char dex2oat_swap_fd[arraysize("--swap-fd=") + MAX_INT_LEN];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700346 bool have_dex2oat_image_fd = false;
George Burgess IV36cebe772017-01-25 11:52:01 -0800347 char dex2oat_image_fd[arraysize("--app-image-fd=") + MAX_INT_LEN];
Calin Juravle52c45822017-07-13 22:50:21 -0700348 size_t class_loader_context_size = arraysize("--class-loader-context=") + PKG_PATH_MAX;
David Brazdil570d3982018-01-16 20:15:43 +0000349 char target_sdk_version_arg[arraysize("-Xtarget-sdk-version:") + MAX_INT_LEN];
Calin Juravle52c45822017-07-13 22:50:21 -0700350 char class_loader_context_arg[class_loader_context_size];
351 if (class_loader_context != nullptr) {
352 snprintf(class_loader_context_arg, class_loader_context_size, "--class-loader-context=%s",
353 class_loader_context);
354 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700355
356 sprintf(zip_fd_arg, "--zip-fd=%d", zip_fd);
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700357 sprintf(zip_location_arg, "--zip-location=%s", relative_input_file_name);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700358 sprintf(input_vdex_fd_arg, "--input-vdex-fd=%d", input_vdex_fd);
359 sprintf(output_vdex_fd_arg, "--output-vdex-fd=%d", output_vdex_fd);
360 sprintf(oat_fd_arg, "--oat-fd=%d", oat_fd);
361 sprintf(oat_location_arg, "--oat-location=%s", output_file_name);
362 sprintf(instruction_set_arg, "--instruction-set=%s", instruction_set);
363 sprintf(instruction_set_variant_arg, "--instruction-set-variant=%s", dex2oat_isa_variant);
364 sprintf(instruction_set_features_arg, "--instruction-set-features=%s", dex2oat_isa_features);
365 if (swap_fd >= 0) {
366 have_dex2oat_swap_fd = true;
367 sprintf(dex2oat_swap_fd, "--swap-fd=%d", swap_fd);
368 }
369 if (image_fd >= 0) {
370 have_dex2oat_image_fd = true;
371 sprintf(dex2oat_image_fd, "--app-image-fd=%d", image_fd);
372 }
373
374 if (have_dex2oat_Xms_flag) {
375 sprintf(dex2oat_Xms_arg, "-Xms%s", dex2oat_Xms_flag);
376 }
377 if (have_dex2oat_Xmx_flag) {
378 sprintf(dex2oat_Xmx_arg, "-Xmx%s", dex2oat_Xmx_flag);
379 }
David Brazdil570d3982018-01-16 20:15:43 +0000380 sprintf(target_sdk_version_arg, "-Xtarget-sdk-version:%d", target_sdk_version);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700381
382 // Compute compiler filter.
383
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100384 bool have_dex2oat_compiler_filter_flag = false;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700385 if (skip_compilation) {
Jeff Sharkeyc1149c92017-09-21 14:51:09 -0600386 strlcpy(dex2oat_compiler_filter_arg, "--compiler-filter=extract",
387 sizeof(dex2oat_compiler_filter_arg));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700388 have_dex2oat_compiler_filter_flag = true;
389 have_dex2oat_relocation_skip_flag = true;
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100390 } else if (compiler_filter != nullptr) {
391 if (strlen(compiler_filter) + strlen("--compiler-filter=") <
Jeff Sharkey90aff262016-12-12 14:28:24 -0700392 arraysize(dex2oat_compiler_filter_arg)) {
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100393 sprintf(dex2oat_compiler_filter_arg, "--compiler-filter=%s", compiler_filter);
394 have_dex2oat_compiler_filter_flag = true;
395 } else {
396 ALOGW("Compiler filter name '%s' is too large (max characters is %zu)",
397 compiler_filter,
398 kPropertyValueMax);
399 }
400 }
401
402 if (!have_dex2oat_compiler_filter_flag) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700403 char dex2oat_compiler_filter_flag[kPropertyValueMax];
404 have_dex2oat_compiler_filter_flag = get_property("dalvik.vm.dex2oat-filter",
Yi Kong954cf642018-07-17 16:16:24 -0700405 dex2oat_compiler_filter_flag, nullptr) > 0;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700406 if (have_dex2oat_compiler_filter_flag) {
407 sprintf(dex2oat_compiler_filter_arg,
408 "--compiler-filter=%s",
409 dex2oat_compiler_filter_flag);
410 }
411 }
412
413 // Check whether all apps should be compiled debuggable.
414 if (!debuggable) {
415 char prop_buf[kPropertyValueMax];
416 debuggable =
417 (get_property("dalvik.vm.always_debuggable", prop_buf, "0") > 0) &&
418 (prop_buf[0] == '1');
419 }
420 char profile_arg[strlen("--profile-file-fd=") + MAX_INT_LEN];
421 if (profile_fd != -1) {
422 sprintf(profile_arg, "--profile-file-fd=%d", profile_fd);
423 }
424
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700425 // Get the directory of the apk to pass as a base classpath directory.
426 char base_dir[arraysize("--classpath-dir=") + PKG_PATH_MAX];
427 std::string apk_dir(input_file_name);
428 unsigned long dir_index = apk_dir.rfind('/');
429 bool has_base_dir = dir_index != std::string::npos;
430 if (has_base_dir) {
431 apk_dir = apk_dir.substr(0, dir_index);
432 sprintf(base_dir, "--classpath-dir=%s", apk_dir.c_str());
433 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700434
Calin Juravle62c5a372018-02-01 17:03:23 +0000435 std::string dex_metadata_fd_arg = "--dm-fd=" + std::to_string(dex_metadata_fd);
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700436
Calin Juravle2efc4022018-02-13 18:31:32 -0800437 std::string compilation_reason_arg = compilation_reason == nullptr
438 ? ""
439 : std::string("--compilation-reason=") + compilation_reason;
440
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700441 ALOGV("Running %s in=%s out=%s\n", dex2oat_bin, relative_input_file_name, output_file_name);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700442
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800443 // Disable cdex if update input vdex is true since this combination of options is not
444 // supported.
Mathieu Chartierf69c2f72018-03-06 13:55:58 -0800445 const bool disable_cdex = !generate_compact_dex || (input_vdex_fd == output_vdex_fd);
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800446
Mathieu Chartierf2088282018-10-26 15:07:50 -0700447 const char* argv[10 // program name, mandatory arguments and the final NULL
Jeff Sharkey90aff262016-12-12 14:28:24 -0700448 + (have_dex2oat_isa_variant ? 1 : 0)
449 + (have_dex2oat_isa_features ? 1 : 0)
450 + (have_dex2oat_Xms_flag ? 2 : 0)
451 + (have_dex2oat_Xmx_flag ? 2 : 0)
452 + (have_dex2oat_compiler_filter_flag ? 1 : 0)
453 + (have_dex2oat_threads_flag ? 1 : 0)
454 + (have_dex2oat_swap_fd ? 1 : 0)
455 + (have_dex2oat_image_fd ? 1 : 0)
456 + (have_dex2oat_relocation_skip_flag ? 2 : 0)
457 + (generate_debug_info ? 1 : 0)
458 + (debuggable ? 1 : 0)
459 + (have_app_image_format ? 1 : 0)
460 + dex2oat_flags_count
461 + (profile_fd == -1 ? 0 : 1)
Calin Juravle52c45822017-07-13 22:50:21 -0700462 + (class_loader_context != nullptr ? 1 : 0)
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700463 + (has_base_dir ? 1 : 0)
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -0700464 + (have_dex2oat_large_app_threshold ? 1 : 0)
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800465 + (disable_cdex ? 1 : 0)
David Brazdil570d3982018-01-16 20:15:43 +0000466 + (generate_minidebug_info ? 1 : 0)
David Brazdil7fcbb812018-01-17 17:05:40 +0000467 + (target_sdk_version != 0 ? 2 : 0)
Calin Juravle62c5a372018-02-01 17:03:23 +0000468 + (enable_hidden_api_checks ? 2 : 0)
Calin Juravle2efc4022018-02-13 18:31:32 -0800469 + (dex_metadata_fd > -1 ? 1 : 0)
470 + (compilation_reason != nullptr ? 1 : 0)];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700471 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700472 argv[i++] = dex2oat_bin;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700473 argv[i++] = zip_fd_arg;
474 argv[i++] = zip_location_arg;
475 argv[i++] = input_vdex_fd_arg;
476 argv[i++] = output_vdex_fd_arg;
477 argv[i++] = oat_fd_arg;
478 argv[i++] = oat_location_arg;
479 argv[i++] = instruction_set_arg;
Mathieu Chartierf2088282018-10-26 15:07:50 -0700480 argv[i++] = resolve_startup_strings ? "--resolve-startup-const-strings=true" :
481 "--resolve-startup-const-strings=false";
Jeff Sharkey90aff262016-12-12 14:28:24 -0700482 if (have_dex2oat_isa_variant) {
483 argv[i++] = instruction_set_variant_arg;
484 }
485 if (have_dex2oat_isa_features) {
486 argv[i++] = instruction_set_features_arg;
487 }
488 if (have_dex2oat_Xms_flag) {
489 argv[i++] = RUNTIME_ARG;
490 argv[i++] = dex2oat_Xms_arg;
491 }
492 if (have_dex2oat_Xmx_flag) {
493 argv[i++] = RUNTIME_ARG;
494 argv[i++] = dex2oat_Xmx_arg;
495 }
496 if (have_dex2oat_compiler_filter_flag) {
497 argv[i++] = dex2oat_compiler_filter_arg;
498 }
499 if (have_dex2oat_threads_flag) {
500 argv[i++] = dex2oat_threads_arg;
501 }
502 if (have_dex2oat_swap_fd) {
503 argv[i++] = dex2oat_swap_fd;
504 }
505 if (have_dex2oat_image_fd) {
506 argv[i++] = dex2oat_image_fd;
507 }
508 if (generate_debug_info) {
509 argv[i++] = "--generate-debug-info";
510 }
511 if (debuggable) {
512 argv[i++] = "--debuggable";
513 }
514 if (have_app_image_format) {
515 argv[i++] = image_format_arg;
516 }
517 if (have_dex2oat_large_app_threshold) {
518 argv[i++] = dex2oat_large_app_threshold_arg;
519 }
520 if (dex2oat_flags_count) {
521 i += split(dex2oat_flags, argv + i);
522 }
523 if (have_dex2oat_relocation_skip_flag) {
524 argv[i++] = RUNTIME_ARG;
525 argv[i++] = dex2oat_norelocation;
526 }
527 if (profile_fd != -1) {
528 argv[i++] = profile_arg;
529 }
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700530 if (has_base_dir) {
531 argv[i++] = base_dir;
532 }
Calin Juravle52c45822017-07-13 22:50:21 -0700533 if (class_loader_context != nullptr) {
534 argv[i++] = class_loader_context_arg;
535 }
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -0700536 if (generate_minidebug_info) {
537 argv[i++] = kMinidebugDex2oatFlag;
538 }
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800539 if (disable_cdex) {
540 argv[i++] = kDisableCompactDexFlag;
541 }
David Brazdil570d3982018-01-16 20:15:43 +0000542 if (target_sdk_version != 0) {
543 argv[i++] = RUNTIME_ARG;
544 argv[i++] = target_sdk_version_arg;
545 }
David Brazdil52249162018-02-12 18:04:59 -0800546 if (enable_hidden_api_checks) {
David Brazdil7fcbb812018-01-17 17:05:40 +0000547 argv[i++] = RUNTIME_ARG;
David Brazdil52249162018-02-12 18:04:59 -0800548 argv[i++] = "-Xhidden-api-checks";
David Brazdil7fcbb812018-01-17 17:05:40 +0000549 }
Calin Juravle52c45822017-07-13 22:50:21 -0700550
Calin Juravle62c5a372018-02-01 17:03:23 +0000551 if (dex_metadata_fd > -1) {
552 argv[i++] = dex_metadata_fd_arg.c_str();
553 }
Calin Juravle2efc4022018-02-13 18:31:32 -0800554
555 if(compilation_reason != nullptr) {
556 argv[i++] = compilation_reason_arg.c_str();
557 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700558 // Do not add after dex2oat_flags, they should override others for debugging.
Yi Kong954cf642018-07-17 16:16:24 -0700559 argv[i] = nullptr;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700560
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700561 execv(dex2oat_bin, (char * const *)argv);
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800562 PLOG(ERROR) << "execv(" << dex2oat_bin << ") failed";
563 exit(DexoptReturnCodes::kDex2oatExec);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700564}
565
566/*
567 * Whether dexopt should use a swap file when compiling an APK.
568 *
569 * If kAlwaysProvideSwapFile, do this on all devices (dex2oat will make a more informed decision
570 * itself, anyways).
571 *
572 * Otherwise, read "dalvik.vm.dex2oat-swap". If the property exists, return whether it is "true".
573 *
574 * Otherwise, return true if this is a low-mem device.
575 *
576 * Otherwise, return default value.
577 */
578static bool kAlwaysProvideSwapFile = false;
579static bool kDefaultProvideSwapFile = true;
580
581static bool ShouldUseSwapFileForDexopt() {
582 if (kAlwaysProvideSwapFile) {
583 return true;
584 }
585
586 // Check the "override" property. If it exists, return value == "true".
587 char dex2oat_prop_buf[kPropertyValueMax];
588 if (get_property("dalvik.vm.dex2oat-swap", dex2oat_prop_buf, "") > 0) {
589 if (strcmp(dex2oat_prop_buf, "true") == 0) {
590 return true;
591 } else {
592 return false;
593 }
594 }
595
596 // Shortcut for default value. This is an implementation optimization for the process sketched
597 // above. If the default value is true, we can avoid to check whether this is a low-mem device,
598 // as low-mem is never returning false. The compiler will optimize this away if it can.
599 if (kDefaultProvideSwapFile) {
600 return true;
601 }
602
603 bool is_low_mem = property_get_bool("ro.config.low_ram", false);
604 if (is_low_mem) {
605 return true;
606 }
607
608 // Default value must be false here.
609 return kDefaultProvideSwapFile;
610}
611
Richard Uhler76cc0272016-12-08 10:46:35 +0000612static void SetDex2OatScheduling(bool set_to_bg) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700613 if (set_to_bg) {
614 if (set_sched_policy(0, SP_BACKGROUND) < 0) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800615 PLOG(ERROR) << "set_sched_policy failed";
616 exit(DexoptReturnCodes::kSetSchedPolicy);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700617 }
618 if (setpriority(PRIO_PROCESS, 0, ANDROID_PRIORITY_BACKGROUND) < 0) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800619 PLOG(ERROR) << "setpriority failed";
620 exit(DexoptReturnCodes::kSetPriority);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700621 }
622 }
623}
624
Calin Juravle29591732017-11-20 17:46:19 -0800625static unique_fd create_profile(uid_t uid, const std::string& profile, int32_t flags) {
626 unique_fd fd(TEMP_FAILURE_RETRY(open(profile.c_str(), flags, 0600)));
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800627 if (fd.get() < 0) {
Calin Juravle29591732017-11-20 17:46:19 -0800628 if (errno != EEXIST) {
Calin Juravle114f0812017-03-08 19:05:07 -0800629 PLOG(ERROR) << "Failed to create profile " << profile;
Calin Juravle29591732017-11-20 17:46:19 -0800630 return invalid_unique_fd();
Calin Juravle114f0812017-03-08 19:05:07 -0800631 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700632 }
Calin Juravle114f0812017-03-08 19:05:07 -0800633 // Profiles should belong to the app; make sure of that by giving ownership to
634 // the app uid. If we cannot do that, there's no point in returning the fd
635 // since dex2oat/profman will fail with SElinux denials.
636 if (fchown(fd.get(), uid, uid) < 0) {
637 PLOG(ERROR) << "Could not chwon profile " << profile;
Calin Juravle29591732017-11-20 17:46:19 -0800638 return invalid_unique_fd();
Calin Juravle114f0812017-03-08 19:05:07 -0800639 }
Calin Juravle29591732017-11-20 17:46:19 -0800640 return fd;
Calin Juravle114f0812017-03-08 19:05:07 -0800641}
642
Calin Juravle29591732017-11-20 17:46:19 -0800643static unique_fd open_profile(uid_t uid, const std::string& profile, int32_t flags) {
Calin Juravle114f0812017-03-08 19:05:07 -0800644 // Do not follow symlinks when opening a profile:
645 // - primary profiles should not contain symlinks in their paths
646 // - secondary dex paths should have been already resolved and validated
647 flags |= O_NOFOLLOW;
648
Calin Juravle29591732017-11-20 17:46:19 -0800649 // Check if we need to create the profile
650 // Reference profiles and snapshots are created on the fly; so they might not exist beforehand.
651 unique_fd fd;
652 if ((flags & O_CREAT) != 0) {
653 fd = create_profile(uid, profile, flags);
654 } else {
655 fd.reset(TEMP_FAILURE_RETRY(open(profile.c_str(), flags)));
656 }
657
Calin Juravle114f0812017-03-08 19:05:07 -0800658 if (fd.get() < 0) {
659 if (errno != ENOENT) {
660 // Profiles might be missing for various reasons. For example, in a
661 // multi-user environment, the profile directory for one user can be created
662 // after we start a merge. In this case the current profile for that user
663 // will not be found.
664 // Also, the secondary dex profiles might be deleted by the app at any time,
665 // so we can't we need to prepare if they are missing.
666 PLOG(ERROR) << "Failed to open profile " << profile;
667 }
668 return invalid_unique_fd();
669 }
670
Jeff Sharkey90aff262016-12-12 14:28:24 -0700671 return fd;
672}
673
Calin Juravle824a64d2018-01-18 20:23:17 -0800674static unique_fd open_current_profile(uid_t uid, userid_t user, const std::string& package_name,
675 const std::string& location, bool is_secondary_dex) {
676 std::string profile = create_current_profile_path(user, package_name, location,
677 is_secondary_dex);
Calin Juravle29591732017-11-20 17:46:19 -0800678 return open_profile(uid, profile, O_RDONLY);
Calin Juravle114f0812017-03-08 19:05:07 -0800679}
680
Calin Juravle824a64d2018-01-18 20:23:17 -0800681static unique_fd open_reference_profile(uid_t uid, const std::string& package_name,
682 const std::string& location, bool read_write, bool is_secondary_dex) {
683 std::string profile = create_reference_profile_path(package_name, location, is_secondary_dex);
Calin Juravle29591732017-11-20 17:46:19 -0800684 return open_profile(uid, profile, read_write ? (O_CREAT | O_RDWR) : O_RDONLY);
685}
686
687static unique_fd open_spnashot_profile(uid_t uid, const std::string& package_name,
Calin Juravle824a64d2018-01-18 20:23:17 -0800688 const std::string& location) {
689 std::string profile = create_snapshot_profile_path(package_name, location);
Calin Juravle29591732017-11-20 17:46:19 -0800690 return open_profile(uid, profile, O_CREAT | O_RDWR | O_TRUNC);
Calin Juravle114f0812017-03-08 19:05:07 -0800691}
692
Calin Juravle824a64d2018-01-18 20:23:17 -0800693static void open_profile_files(uid_t uid, const std::string& package_name,
694 const std::string& location, bool is_secondary_dex,
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800695 /*out*/ std::vector<unique_fd>* profiles_fd, /*out*/ unique_fd* reference_profile_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700696 // Open the reference profile in read-write mode as profman might need to save the merge.
Calin Juravle824a64d2018-01-18 20:23:17 -0800697 *reference_profile_fd = open_reference_profile(uid, package_name, location,
698 /*read_write*/ true, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700699
Calin Juravle114f0812017-03-08 19:05:07 -0800700 // For secondary dex files, we don't really need the user but we use it for sanity checks.
701 // Note: the user owning the dex file should be the current user.
702 std::vector<userid_t> users;
703 if (is_secondary_dex){
704 users.push_back(multiuser_get_user_id(uid));
705 } else {
706 users = get_known_users(/*volume_uuid*/ nullptr);
707 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700708 for (auto user : users) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800709 unique_fd profile_fd = open_current_profile(uid, user, package_name, location,
710 is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700711 // Add to the lists only if both fds are valid.
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800712 if (profile_fd.get() >= 0) {
713 profiles_fd->push_back(std::move(profile_fd));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700714 }
715 }
716}
717
718static void drop_capabilities(uid_t uid) {
719 if (setgid(uid) != 0) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800720 PLOG(ERROR) << "setgid(" << uid << ") failed in installd during dexopt";
721 exit(DexoptReturnCodes::kSetGid);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700722 }
723 if (setuid(uid) != 0) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800724 PLOG(ERROR) << "setuid(" << uid << ") failed in installd during dexopt";
725 exit(DexoptReturnCodes::kSetUid);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700726 }
727 // drop capabilities
728 struct __user_cap_header_struct capheader;
729 struct __user_cap_data_struct capdata[2];
730 memset(&capheader, 0, sizeof(capheader));
731 memset(&capdata, 0, sizeof(capdata));
732 capheader.version = _LINUX_CAPABILITY_VERSION_3;
733 if (capset(&capheader, &capdata[0]) < 0) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800734 PLOG(ERROR) << "capset failed";
735 exit(DexoptReturnCodes::kCapSet);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700736 }
737}
738
739static constexpr int PROFMAN_BIN_RETURN_CODE_COMPILE = 0;
740static constexpr int PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION = 1;
741static constexpr int PROFMAN_BIN_RETURN_CODE_BAD_PROFILES = 2;
742static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_IO = 3;
743static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING = 4;
744
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800745[[ noreturn ]]
Calin Juravlef63d4792018-01-30 17:43:34 +0000746static void run_profman(const std::vector<unique_fd>& profile_fds,
747 const unique_fd& reference_profile_fd,
748 const std::vector<unique_fd>* apk_fds,
Calin Juravle59f7ab82018-04-27 17:50:23 -0700749 const std::vector<std::string>* dex_locations,
Calin Juravlef63d4792018-01-30 17:43:34 +0000750 bool copy_and_update) {
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700751 const char* profman_bin = is_debug_runtime() ? "/system/bin/profmand" : "/system/bin/profman";
Jeff Sharkey90aff262016-12-12 14:28:24 -0700752
Calin Juravlef63d4792018-01-30 17:43:34 +0000753 if (copy_and_update) {
754 CHECK_EQ(1u, profile_fds.size());
755 CHECK(apk_fds != nullptr);
756 CHECK_EQ(1u, apk_fds->size());
757 }
758 std::vector<std::string> profile_args(profile_fds.size());
759 for (size_t k = 0; k < profile_fds.size(); k++) {
760 profile_args[k] = "--profile-file-fd=" + std::to_string(profile_fds[k].get());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700761 }
Calin Juravle0d0a4922018-01-23 19:54:11 -0800762 std::string reference_profile_arg = "--reference-profile-file-fd="
763 + std::to_string(reference_profile_fd.get());
764
765 std::vector<std::string> apk_args;
766 if (apk_fds != nullptr) {
767 for (size_t k = 0; k < apk_fds->size(); k++) {
768 apk_args.push_back("--apk-fd=" + std::to_string((*apk_fds)[k].get()));
769 }
770 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700771
Calin Juravle59f7ab82018-04-27 17:50:23 -0700772 std::vector<std::string> dex_location_args;
773 if (dex_locations != nullptr) {
774 for (size_t k = 0; k < dex_locations->size(); k++) {
775 dex_location_args.push_back("--dex-location=" + (*dex_locations)[k]);
776 }
777 }
778
Jeff Sharkey90aff262016-12-12 14:28:24 -0700779 // program name, reference profile fd, the final NULL and the profile fds
Calin Juravlea30265a2018-06-11 13:28:15 -0700780 const char* argv[3 + profile_args.size() + apk_args.size()
781 + dex_location_args.size() + (copy_and_update ? 1 : 0)];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700782 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700783 argv[i++] = profman_bin;
Calin Juravle0d0a4922018-01-23 19:54:11 -0800784 argv[i++] = reference_profile_arg.c_str();
Jeff Sharkey90aff262016-12-12 14:28:24 -0700785 for (size_t k = 0; k < profile_args.size(); k++) {
786 argv[i++] = profile_args[k].c_str();
787 }
Calin Juravle0d0a4922018-01-23 19:54:11 -0800788 for (size_t k = 0; k < apk_args.size(); k++) {
789 argv[i++] = apk_args[k].c_str();
790 }
Calin Juravle59f7ab82018-04-27 17:50:23 -0700791 for (size_t k = 0; k < dex_location_args.size(); k++) {
792 argv[i++] = dex_location_args[k].c_str();
793 }
Calin Juravlef63d4792018-01-30 17:43:34 +0000794 if (copy_and_update) {
795 argv[i++] = "--copy-and-update-profile-key";
796 }
Calin Juravle59f7ab82018-04-27 17:50:23 -0700797
Jeff Sharkey90aff262016-12-12 14:28:24 -0700798 // Do not add after dex2oat_flags, they should override others for debugging.
Yi Kong954cf642018-07-17 16:16:24 -0700799 argv[i] = nullptr;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700800
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700801 execv(profman_bin, (char * const *)argv);
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800802 PLOG(ERROR) << "execv(" << profman_bin << ") failed";
803 exit(DexoptReturnCodes::kProfmanExec); /* only get here on exec failure */
Jeff Sharkey90aff262016-12-12 14:28:24 -0700804}
805
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800806[[ noreturn ]]
Calin Juravlef63d4792018-01-30 17:43:34 +0000807static void run_profman_merge(const std::vector<unique_fd>& profiles_fd,
808 const unique_fd& reference_profile_fd,
Calin Juravle59f7ab82018-04-27 17:50:23 -0700809 const std::vector<unique_fd>* apk_fds = nullptr,
810 const std::vector<std::string>* dex_locations = nullptr) {
811 run_profman(profiles_fd, reference_profile_fd, apk_fds, dex_locations,
812 /*copy_and_update*/false);
Calin Juravlef63d4792018-01-30 17:43:34 +0000813}
814
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800815[[ noreturn ]]
Calin Juravlef63d4792018-01-30 17:43:34 +0000816static void run_profman_copy_and_update(unique_fd&& profile_fd,
817 unique_fd&& reference_profile_fd,
Calin Juravle59f7ab82018-04-27 17:50:23 -0700818 unique_fd&& apk_fd,
819 const std::string& dex_location) {
Calin Juravlef63d4792018-01-30 17:43:34 +0000820 std::vector<unique_fd> profiles_fd;
821 profiles_fd.push_back(std::move(profile_fd));
822 std::vector<unique_fd> apk_fds;
823 apk_fds.push_back(std::move(apk_fd));
Calin Juravle59f7ab82018-04-27 17:50:23 -0700824 std::vector<std::string> dex_locations;
825 dex_locations.push_back(dex_location);
Calin Juravlef63d4792018-01-30 17:43:34 +0000826
Calin Juravle59f7ab82018-04-27 17:50:23 -0700827 run_profman(profiles_fd, reference_profile_fd, &apk_fds, &dex_locations,
828 /*copy_and_update*/true);
Calin Juravlef63d4792018-01-30 17:43:34 +0000829}
830
Jeff Sharkey90aff262016-12-12 14:28:24 -0700831// Decides if profile guided compilation is needed or not based on existing profiles.
Calin Juravle114f0812017-03-08 19:05:07 -0800832// The location is the package name for primary apks or the dex path for secondary dex files.
833// Returns true if there is enough information in the current profiles that makes it
834// worth to recompile the given location.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700835// If the return value is true all the current profiles would have been merged into
836// the reference profiles accessible with open_reference_profile().
Calin Juravle824a64d2018-01-18 20:23:17 -0800837static bool analyze_profiles(uid_t uid, const std::string& package_name,
838 const std::string& location, bool is_secondary_dex) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800839 std::vector<unique_fd> profiles_fd;
840 unique_fd reference_profile_fd;
Calin Juravle824a64d2018-01-18 20:23:17 -0800841 open_profile_files(uid, package_name, location, is_secondary_dex,
842 &profiles_fd, &reference_profile_fd);
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800843 if (profiles_fd.empty() || (reference_profile_fd.get() < 0)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700844 // Skip profile guided compilation because no profiles were found.
845 // Or if the reference profile info couldn't be opened.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700846 return false;
847 }
848
Jeff Sharkey90aff262016-12-12 14:28:24 -0700849 pid_t pid = fork();
850 if (pid == 0) {
851 /* child -- drop privileges before continuing */
852 drop_capabilities(uid);
853 run_profman_merge(profiles_fd, reference_profile_fd);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700854 }
855 /* parent */
856 int return_code = wait_child(pid);
857 bool need_to_compile = false;
858 bool should_clear_current_profiles = false;
859 bool should_clear_reference_profile = false;
860 if (!WIFEXITED(return_code)) {
Calin Juravle114f0812017-03-08 19:05:07 -0800861 LOG(WARNING) << "profman failed for location " << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700862 } else {
863 return_code = WEXITSTATUS(return_code);
864 switch (return_code) {
865 case PROFMAN_BIN_RETURN_CODE_COMPILE:
866 need_to_compile = true;
867 should_clear_current_profiles = true;
868 should_clear_reference_profile = false;
869 break;
870 case PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION:
871 need_to_compile = false;
872 should_clear_current_profiles = false;
873 should_clear_reference_profile = false;
874 break;
875 case PROFMAN_BIN_RETURN_CODE_BAD_PROFILES:
Calin Juravle114f0812017-03-08 19:05:07 -0800876 LOG(WARNING) << "Bad profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700877 need_to_compile = false;
878 should_clear_current_profiles = true;
879 should_clear_reference_profile = true;
880 break;
881 case PROFMAN_BIN_RETURN_CODE_ERROR_IO: // fall-through
882 case PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING:
883 // Temporary IO problem (e.g. locking). Ignore but log a warning.
Calin Juravle114f0812017-03-08 19:05:07 -0800884 LOG(WARNING) << "IO error while reading profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700885 need_to_compile = false;
886 should_clear_current_profiles = false;
887 should_clear_reference_profile = false;
888 break;
889 default:
890 // Unknown return code or error. Unlink profiles.
Calin Juravle114f0812017-03-08 19:05:07 -0800891 LOG(WARNING) << "Unknown error code while processing profiles for location "
892 << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700893 need_to_compile = false;
894 should_clear_current_profiles = true;
895 should_clear_reference_profile = true;
896 break;
897 }
898 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800899
Jeff Sharkey90aff262016-12-12 14:28:24 -0700900 if (should_clear_current_profiles) {
Calin Juravle114f0812017-03-08 19:05:07 -0800901 if (is_secondary_dex) {
902 // For secondary dex files, the owning user is the current user.
Calin Juravle824a64d2018-01-18 20:23:17 -0800903 clear_current_profile(package_name, location, multiuser_get_user_id(uid),
904 is_secondary_dex);
Calin Juravle114f0812017-03-08 19:05:07 -0800905 } else {
Calin Juravle824a64d2018-01-18 20:23:17 -0800906 clear_primary_current_profiles(package_name, location);
Calin Juravle114f0812017-03-08 19:05:07 -0800907 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700908 }
909 if (should_clear_reference_profile) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800910 clear_reference_profile(package_name, location, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700911 }
912 return need_to_compile;
913}
914
Calin Juravle114f0812017-03-08 19:05:07 -0800915// Decides if profile guided compilation is needed or not based on existing profiles.
916// The analysis is done for the primary apks of the given package.
917// Returns true if there is enough information in the current profiles that makes it
918// worth to recompile the package.
919// If the return value is true all the current profiles would have been merged into
920// the reference profiles accessible with open_reference_profile().
Calin Juravle824a64d2018-01-18 20:23:17 -0800921bool analyze_primary_profiles(uid_t uid, const std::string& package_name,
922 const std::string& profile_name) {
923 return analyze_profiles(uid, package_name, profile_name, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800924}
925
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800926[[ noreturn ]]
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800927static void run_profman_dump(const std::vector<unique_fd>& profile_fds,
928 const unique_fd& reference_profile_fd,
Jeff Sharkey90aff262016-12-12 14:28:24 -0700929 const std::vector<std::string>& dex_locations,
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800930 const std::vector<unique_fd>& apk_fds,
931 const unique_fd& output_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700932 std::vector<std::string> profman_args;
933 static const char* PROFMAN_BIN = "/system/bin/profman";
934 profman_args.push_back(PROFMAN_BIN);
935 profman_args.push_back("--dump-only");
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800936 profman_args.push_back(StringPrintf("--dump-output-to-fd=%d", output_fd.get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700937 if (reference_profile_fd != -1) {
938 profman_args.push_back(StringPrintf("--reference-profile-file-fd=%d",
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800939 reference_profile_fd.get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700940 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800941 for (size_t i = 0; i < profile_fds.size(); i++) {
942 profman_args.push_back(StringPrintf("--profile-file-fd=%d", profile_fds[i].get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700943 }
944 for (const std::string& dex_location : dex_locations) {
945 profman_args.push_back(StringPrintf("--dex-location=%s", dex_location.c_str()));
946 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800947 for (size_t i = 0; i < apk_fds.size(); i++) {
948 profman_args.push_back(StringPrintf("--apk-fd=%d", apk_fds[i].get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700949 }
950 const char **argv = new const char*[profman_args.size() + 1];
951 size_t i = 0;
952 for (const std::string& profman_arg : profman_args) {
953 argv[i++] = profman_arg.c_str();
954 }
Yi Kong954cf642018-07-17 16:16:24 -0700955 argv[i] = nullptr;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700956
957 execv(PROFMAN_BIN, (char * const *)argv);
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800958 PLOG(ERROR) << "execv(" << PROFMAN_BIN << ") failed";
959 exit(DexoptReturnCodes::kProfmanExec); /* only get here on exec failure */
Jeff Sharkey90aff262016-12-12 14:28:24 -0700960}
961
Calin Juravle408cd4a2018-01-20 23:34:18 -0800962bool dump_profiles(int32_t uid, const std::string& pkgname, const std::string& profile_name,
963 const std::string& code_path) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800964 std::vector<unique_fd> profile_fds;
965 unique_fd reference_profile_fd;
Calin Juravle408cd4a2018-01-20 23:34:18 -0800966 std::string out_file_name = StringPrintf("/data/misc/profman/%s-%s.txt",
967 pkgname.c_str(), profile_name.c_str());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700968
Calin Juravle408cd4a2018-01-20 23:34:18 -0800969 open_profile_files(uid, pkgname, profile_name, /*is_secondary_dex*/false,
Calin Juravle114f0812017-03-08 19:05:07 -0800970 &profile_fds, &reference_profile_fd);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700971
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800972 const bool has_reference_profile = (reference_profile_fd.get() != -1);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700973 const bool has_profiles = !profile_fds.empty();
974
975 if (!has_reference_profile && !has_profiles) {
Calin Juravle76268c52017-03-09 13:19:42 -0800976 LOG(ERROR) << "profman dump: no profiles to dump for " << pkgname;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700977 return false;
978 }
979
Calin Juravle114f0812017-03-08 19:05:07 -0800980 unique_fd output_fd(open(out_file_name.c_str(),
981 O_WRONLY | O_CREAT | O_TRUNC | O_NOFOLLOW, 0644));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700982 if (fchmod(output_fd, S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH) < 0) {
Calin Juravle408cd4a2018-01-20 23:34:18 -0800983 LOG(ERROR) << "installd cannot chmod file for dump_profile" << out_file_name;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700984 return false;
985 }
Calin Juravle408cd4a2018-01-20 23:34:18 -0800986
Jeff Sharkey90aff262016-12-12 14:28:24 -0700987 std::vector<std::string> dex_locations;
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800988 std::vector<unique_fd> apk_fds;
Calin Juravle408cd4a2018-01-20 23:34:18 -0800989 unique_fd apk_fd(open(code_path.c_str(), O_RDONLY | O_NOFOLLOW));
990 if (apk_fd == -1) {
991 PLOG(ERROR) << "installd cannot open " << code_path.c_str();
992 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700993 }
Calin Juravle408cd4a2018-01-20 23:34:18 -0800994 dex_locations.push_back(get_location_from_path(code_path.c_str()));
995 apk_fds.push_back(std::move(apk_fd));
996
Jeff Sharkey90aff262016-12-12 14:28:24 -0700997
998 pid_t pid = fork();
999 if (pid == 0) {
1000 /* child -- drop privileges before continuing */
1001 drop_capabilities(uid);
1002 run_profman_dump(profile_fds, reference_profile_fd, dex_locations,
1003 apk_fds, output_fd);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001004 }
1005 /* parent */
Jeff Sharkey90aff262016-12-12 14:28:24 -07001006 int return_code = wait_child(pid);
1007 if (!WIFEXITED(return_code)) {
1008 LOG(WARNING) << "profman failed for package " << pkgname << ": "
1009 << return_code;
1010 return false;
1011 }
1012 return true;
1013}
1014
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001015bool copy_system_profile(const std::string& system_profile,
Calin Juravle824a64d2018-01-18 20:23:17 -08001016 uid_t packageUid, const std::string& package_name, const std::string& profile_name) {
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001017 unique_fd in_fd(open(system_profile.c_str(), O_RDONLY | O_NOFOLLOW | O_CLOEXEC));
1018 unique_fd out_fd(open_reference_profile(packageUid,
Calin Juravle824a64d2018-01-18 20:23:17 -08001019 package_name,
1020 profile_name,
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001021 /*read_write*/ true,
1022 /*secondary*/ false));
1023 if (in_fd.get() < 0) {
1024 PLOG(WARNING) << "Could not open profile " << system_profile;
1025 return false;
1026 }
1027 if (out_fd.get() < 0) {
Calin Juravle824a64d2018-01-18 20:23:17 -08001028 PLOG(WARNING) << "Could not open profile " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001029 return false;
1030 }
1031
Mathieu Chartier78f71fe2017-06-14 13:02:26 -07001032 // As a security measure we want to write the profile information with the reduced capabilities
1033 // of the package user id. So we fork and drop capabilities in the child.
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001034 pid_t pid = fork();
1035 if (pid == 0) {
1036 /* child -- drop privileges before continuing */
1037 drop_capabilities(packageUid);
1038
1039 if (flock(out_fd.get(), LOCK_EX | LOCK_NB) != 0) {
1040 if (errno != EWOULDBLOCK) {
Calin Juravle824a64d2018-01-18 20:23:17 -08001041 PLOG(WARNING) << "Error locking profile " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001042 }
1043 // This implies that the app owning this profile is running
1044 // (and has acquired the lock).
1045 //
1046 // The app never acquires the lock for the reference profiles of primary apks.
1047 // Only dex2oat from installd will do that. Since installd is single threaded
1048 // we should not see this case. Nevertheless be prepared for it.
Calin Juravle824a64d2018-01-18 20:23:17 -08001049 PLOG(WARNING) << "Failed to flock " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001050 return false;
1051 }
1052
1053 bool truncated = ftruncate(out_fd.get(), 0) == 0;
1054 if (!truncated) {
Calin Juravle824a64d2018-01-18 20:23:17 -08001055 PLOG(WARNING) << "Could not truncate " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001056 }
1057
1058 // Copy over data.
1059 static constexpr size_t kBufferSize = 4 * 1024;
1060 char buffer[kBufferSize];
1061 while (true) {
1062 ssize_t bytes = read(in_fd.get(), buffer, kBufferSize);
1063 if (bytes == 0) {
1064 break;
1065 }
1066 write(out_fd.get(), buffer, bytes);
1067 }
1068 if (flock(out_fd.get(), LOCK_UN) != 0) {
Calin Juravle824a64d2018-01-18 20:23:17 -08001069 PLOG(WARNING) << "Error unlocking profile " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001070 }
Mathieu Chartier78f71fe2017-06-14 13:02:26 -07001071 // Use _exit since we don't want to run the global destructors in the child.
1072 // b/62597429
1073 _exit(0);
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001074 }
1075 /* parent */
1076 int return_code = wait_child(pid);
1077 return return_code == 0;
1078}
1079
Jeff Sharkey90aff262016-12-12 14:28:24 -07001080static std::string replace_file_extension(const std::string& oat_path, const std::string& new_ext) {
1081 // A standard dalvik-cache entry. Replace ".dex" with `new_ext`.
1082 if (EndsWith(oat_path, ".dex")) {
1083 std::string new_path = oat_path;
1084 new_path.replace(new_path.length() - strlen(".dex"), strlen(".dex"), new_ext);
Elliott Hughes969e4f82017-12-20 12:34:09 -08001085 CHECK(EndsWith(new_path, new_ext));
Jeff Sharkey90aff262016-12-12 14:28:24 -07001086 return new_path;
1087 }
1088
1089 // An odex entry. Not that this may not be an extension, e.g., in the OTA
1090 // case (where the base name will have an extension for the B artifact).
1091 size_t odex_pos = oat_path.rfind(".odex");
1092 if (odex_pos != std::string::npos) {
1093 std::string new_path = oat_path;
1094 new_path.replace(odex_pos, strlen(".odex"), new_ext);
1095 CHECK_NE(new_path.find(new_ext), std::string::npos);
1096 return new_path;
1097 }
1098
1099 // Don't know how to handle this.
1100 return "";
1101}
1102
1103// Translate the given oat path to an art (app image) path. An empty string
1104// denotes an error.
1105static std::string create_image_filename(const std::string& oat_path) {
1106 return replace_file_extension(oat_path, ".art");
1107}
1108
1109// Translate the given oat path to a vdex path. An empty string denotes an error.
1110static std::string create_vdex_filename(const std::string& oat_path) {
1111 return replace_file_extension(oat_path, ".vdex");
1112}
1113
Jeff Sharkey90aff262016-12-12 14:28:24 -07001114static int open_output_file(const char* file_name, bool recreate, int permissions) {
1115 int flags = O_RDWR | O_CREAT;
1116 if (recreate) {
1117 if (unlink(file_name) < 0) {
1118 if (errno != ENOENT) {
1119 PLOG(ERROR) << "open_output_file: Couldn't unlink " << file_name;
1120 }
1121 }
1122 flags |= O_EXCL;
1123 }
1124 return open(file_name, flags, permissions);
1125}
1126
Calin Juravle2289c0a2017-02-15 12:44:14 -08001127static bool set_permissions_and_ownership(
1128 int fd, bool is_public, int uid, const char* path, bool is_secondary_dex) {
1129 // Primary apks are owned by the system. Secondary dex files are owned by the app.
1130 int owning_uid = is_secondary_dex ? uid : AID_SYSTEM;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001131 if (fchmod(fd,
1132 S_IRUSR|S_IWUSR|S_IRGRP |
1133 (is_public ? S_IROTH : 0)) < 0) {
1134 ALOGE("installd cannot chmod '%s' during dexopt\n", path);
1135 return false;
Calin Juravle2289c0a2017-02-15 12:44:14 -08001136 } else if (fchown(fd, owning_uid, uid) < 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001137 ALOGE("installd cannot chown '%s' during dexopt\n", path);
1138 return false;
1139 }
1140 return true;
1141}
1142
1143static bool IsOutputDalvikCache(const char* oat_dir) {
1144 // InstallerConnection.java (which invokes installd) transforms Java null arguments
1145 // into '!'. Play it safe by handling it both.
1146 // TODO: ensure we never get null.
1147 // TODO: pass a flag instead of inferring if the output is dalvik cache.
1148 return oat_dir == nullptr || oat_dir[0] == '!';
1149}
1150
Calin Juravled23dee72017-07-06 16:29:11 -07001151// Best-effort check whether we can fit the the path into our buffers.
1152// Note: the cache path will require an additional 5 bytes for ".swap", but we'll try to run
1153// without a swap file, if necessary. Reference profiles file also add an extra ".prof"
1154// extension to the cache path (5 bytes).
1155// TODO(calin): move away from char* buffers and PKG_PATH_MAX.
1156static bool validate_dex_path_size(const std::string& dex_path) {
1157 if (dex_path.size() >= (PKG_PATH_MAX - 8)) {
1158 LOG(ERROR) << "dex_path too long: " << dex_path;
1159 return false;
1160 }
1161 return true;
1162}
1163
Jeff Sharkey90aff262016-12-12 14:28:24 -07001164static bool create_oat_out_path(const char* apk_path, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -08001165 const char* oat_dir, bool is_secondary_dex, /*out*/ char* out_oat_path) {
Calin Juravled23dee72017-07-06 16:29:11 -07001166 if (!validate_dex_path_size(apk_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001167 return false;
1168 }
1169
1170 if (!IsOutputDalvikCache(oat_dir)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001171 // Oat dirs for secondary dex files are already validated.
1172 if (!is_secondary_dex && validate_apk_path(oat_dir)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001173 ALOGE("cannot validate apk path with oat_dir '%s'\n", oat_dir);
1174 return false;
1175 }
1176 if (!calculate_oat_file_path(out_oat_path, oat_dir, apk_path, instruction_set)) {
1177 return false;
1178 }
1179 } else {
1180 if (!create_cache_path(out_oat_path, apk_path, instruction_set)) {
1181 return false;
1182 }
1183 }
1184 return true;
1185}
1186
1187// Helper for fd management. This is similar to a unique_fd in that it closes the file descriptor
1188// on destruction. It will also run the given cleanup (unless told not to) after closing.
1189//
1190// Usage example:
1191//
Calin Juravle7a570e82017-01-14 16:23:30 -08001192// Dex2oatFileWrapper file(open(...),
Jeff Sharkey90aff262016-12-12 14:28:24 -07001193// [name]() {
1194// unlink(name.c_str());
1195// });
1196// // Note: care needs to be taken about name, as it needs to have a lifetime longer than the
1197// wrapper if captured as a reference.
1198//
1199// if (file.get() == -1) {
1200// // Error opening...
1201// }
1202//
1203// ...
1204// if (error) {
1205// // At this point, when the Dex2oatFileWrapper is destructed, the cleanup function will run
1206// // and delete the file (after the fd is closed).
1207// return -1;
1208// }
1209//
1210// (Success case)
1211// file.SetCleanup(false);
1212// // At this point, when the Dex2oatFileWrapper is destructed, the cleanup function will not run
1213// // (leaving the file around; after the fd is closed).
1214//
Jeff Sharkey90aff262016-12-12 14:28:24 -07001215class Dex2oatFileWrapper {
1216 public:
Calin Juravle7a570e82017-01-14 16:23:30 -08001217 Dex2oatFileWrapper() : value_(-1), cleanup_(), do_cleanup_(true), auto_close_(true) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001218 }
1219
Calin Juravle7a570e82017-01-14 16:23:30 -08001220 Dex2oatFileWrapper(int value, std::function<void ()> cleanup)
1221 : value_(value), cleanup_(cleanup), do_cleanup_(true), auto_close_(true) {}
1222
1223 Dex2oatFileWrapper(Dex2oatFileWrapper&& other) {
1224 value_ = other.value_;
1225 cleanup_ = other.cleanup_;
1226 do_cleanup_ = other.do_cleanup_;
1227 auto_close_ = other.auto_close_;
1228 other.release();
1229 }
1230
1231 Dex2oatFileWrapper& operator=(Dex2oatFileWrapper&& other) {
1232 value_ = other.value_;
1233 cleanup_ = other.cleanup_;
1234 do_cleanup_ = other.do_cleanup_;
1235 auto_close_ = other.auto_close_;
1236 other.release();
1237 return *this;
1238 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001239
1240 ~Dex2oatFileWrapper() {
1241 reset(-1);
1242 }
1243
1244 int get() {
1245 return value_;
1246 }
1247
1248 void SetCleanup(bool cleanup) {
1249 do_cleanup_ = cleanup;
1250 }
1251
1252 void reset(int new_value) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001253 if (auto_close_ && value_ >= 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001254 close(value_);
1255 }
1256 if (do_cleanup_ && cleanup_ != nullptr) {
1257 cleanup_();
1258 }
1259
1260 value_ = new_value;
1261 }
1262
Calin Juravle7a570e82017-01-14 16:23:30 -08001263 void reset(int new_value, std::function<void ()> new_cleanup) {
1264 if (auto_close_ && value_ >= 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001265 close(value_);
1266 }
1267 if (do_cleanup_ && cleanup_ != nullptr) {
1268 cleanup_();
1269 }
1270
1271 value_ = new_value;
1272 cleanup_ = new_cleanup;
1273 }
1274
Calin Juravle7a570e82017-01-14 16:23:30 -08001275 void DisableAutoClose() {
1276 auto_close_ = false;
1277 }
1278
Jeff Sharkey90aff262016-12-12 14:28:24 -07001279 private:
Calin Juravle7a570e82017-01-14 16:23:30 -08001280 void release() {
1281 value_ = -1;
1282 do_cleanup_ = false;
1283 cleanup_ = nullptr;
1284 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001285 int value_;
Calin Juravle7a570e82017-01-14 16:23:30 -08001286 std::function<void ()> cleanup_;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001287 bool do_cleanup_;
Calin Juravle7a570e82017-01-14 16:23:30 -08001288 bool auto_close_;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001289};
1290
Calin Juravle7a570e82017-01-14 16:23:30 -08001291// (re)Creates the app image if needed.
Mathieu Chartier1dc3dfa2018-03-12 17:55:06 -07001292Dex2oatFileWrapper maybe_open_app_image(const char* out_oat_path,
1293 bool generate_app_image, bool is_public, int uid, bool is_secondary_dex) {
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +01001294
1295 // We don't create an image for secondary dex files.
1296 if (is_secondary_dex) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001297 return Dex2oatFileWrapper();
1298 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001299
Calin Juravle7a570e82017-01-14 16:23:30 -08001300 const std::string image_path = create_image_filename(out_oat_path);
1301 if (image_path.empty()) {
1302 // Happens when the out_oat_path has an unknown extension.
1303 return Dex2oatFileWrapper();
1304 }
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +01001305
Mathieu Chartier1dc3dfa2018-03-12 17:55:06 -07001306 // In case there is a stale image, remove it now. Ignore any error.
1307 unlink(image_path.c_str());
1308
1309 // Not enabled, exit.
1310 if (!generate_app_image) {
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +01001311 return Dex2oatFileWrapper();
1312 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001313 char app_image_format[kPropertyValueMax];
1314 bool have_app_image_format =
Yi Kong954cf642018-07-17 16:16:24 -07001315 get_property("dalvik.vm.appimageformat", app_image_format, nullptr) > 0;
Calin Juravle7a570e82017-01-14 16:23:30 -08001316 if (!have_app_image_format) {
1317 return Dex2oatFileWrapper();
1318 }
1319 // Recreate is true since we do not want to modify a mapped image. If the app is
1320 // already running and we modify the image file, it can cause crashes (b/27493510).
1321 Dex2oatFileWrapper wrapper_fd(
1322 open_output_file(image_path.c_str(), true /*recreate*/, 0600 /*permissions*/),
1323 [image_path]() { unlink(image_path.c_str()); });
1324 if (wrapper_fd.get() < 0) {
1325 // Could not create application image file. Go on since we can compile without it.
1326 LOG(ERROR) << "installd could not create '" << image_path
1327 << "' for image file during dexopt";
1328 // If we have a valid image file path but no image fd, explicitly erase the image file.
1329 if (unlink(image_path.c_str()) < 0) {
1330 if (errno != ENOENT) {
1331 PLOG(ERROR) << "Couldn't unlink image file " << image_path;
1332 }
1333 }
1334 } else if (!set_permissions_and_ownership(
Calin Juravle2289c0a2017-02-15 12:44:14 -08001335 wrapper_fd.get(), is_public, uid, image_path.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001336 ALOGE("installd cannot set owner '%s' for image during dexopt\n", image_path.c_str());
1337 wrapper_fd.reset(-1);
1338 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001339
Calin Juravle7a570e82017-01-14 16:23:30 -08001340 return wrapper_fd;
1341}
1342
1343// Creates the dexopt swap file if necessary and return its fd.
1344// Returns -1 if there's no need for a swap or in case of errors.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001345unique_fd maybe_open_dexopt_swap_file(const char* out_oat_path) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001346 if (!ShouldUseSwapFileForDexopt()) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001347 return invalid_unique_fd();
Calin Juravle7a570e82017-01-14 16:23:30 -08001348 }
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001349 auto swap_file_name = std::string(out_oat_path) + ".swap";
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001350 unique_fd swap_fd(open_output_file(
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001351 swap_file_name.c_str(), /*recreate*/true, /*permissions*/0600));
Calin Juravle7a570e82017-01-14 16:23:30 -08001352 if (swap_fd.get() < 0) {
1353 // Could not create swap file. Optimistically go on and hope that we can compile
1354 // without it.
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001355 ALOGE("installd could not create '%s' for swap during dexopt\n", swap_file_name.c_str());
Calin Juravle7a570e82017-01-14 16:23:30 -08001356 } else {
1357 // Immediately unlink. We don't really want to hit flash.
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001358 if (unlink(swap_file_name.c_str()) < 0) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001359 PLOG(ERROR) << "Couldn't unlink swap file " << swap_file_name;
1360 }
1361 }
1362 return swap_fd;
1363}
1364
1365// Opens the reference profiles if needed.
1366// Note that the reference profile might not exist so it's OK if the fd will be -1.
Calin Juravle114f0812017-03-08 19:05:07 -08001367Dex2oatFileWrapper maybe_open_reference_profile(const std::string& pkgname,
Calin Juravlec4f6a0b2018-02-01 01:27:24 +00001368 const std::string& dex_path, const char* profile_name, bool profile_guided,
Calin Juravle824a64d2018-01-18 20:23:17 -08001369 bool is_public, int uid, bool is_secondary_dex) {
Calin Juravle5bd1c722018-02-01 17:23:54 +00001370 // If we are not profile guided compilation, or we are compiling system server
1371 // do not bother to open the profiles; we won't be using them.
1372 if (!profile_guided || (pkgname[0] == '*')) {
1373 return Dex2oatFileWrapper();
1374 }
1375
1376 // If this is a secondary dex path which is public do not open the profile.
1377 // We cannot compile public secondary dex paths with profiles. That's because
1378 // it will expose how the dex files are used by their owner.
1379 //
1380 // Note that the PackageManager is responsible to set the is_public flag for
1381 // primary apks and we do not check it here. In some cases, e.g. when
1382 // compiling with a public profile from the .dm file the PackageManager will
1383 // set is_public toghether with the profile guided compilation.
1384 if (is_secondary_dex && is_public) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001385 return Dex2oatFileWrapper();
Jeff Sharkey90aff262016-12-12 14:28:24 -07001386 }
Calin Juravle114f0812017-03-08 19:05:07 -08001387
1388 // Open reference profile in read only mode as dex2oat does not get write permissions.
Calin Juravlec4f6a0b2018-02-01 01:27:24 +00001389 std::string location;
1390 if (is_secondary_dex) {
1391 location = dex_path;
1392 } else {
1393 if (profile_name == nullptr) {
1394 // This path is taken for system server re-compilation lunched from ZygoteInit.
1395 return Dex2oatFileWrapper();
1396 } else {
1397 location = profile_name;
1398 }
1399 }
Calin Juravle824a64d2018-01-18 20:23:17 -08001400 unique_fd ufd = open_reference_profile(uid, pkgname, location, /*read_write*/false,
1401 is_secondary_dex);
1402 const auto& cleanup = [pkgname, location, is_secondary_dex]() {
1403 clear_reference_profile(pkgname, location, is_secondary_dex);
Calin Juravle114f0812017-03-08 19:05:07 -08001404 };
1405 return Dex2oatFileWrapper(ufd.release(), cleanup);
Calin Juravle7a570e82017-01-14 16:23:30 -08001406}
Jeff Sharkey90aff262016-12-12 14:28:24 -07001407
Calin Juravle7a570e82017-01-14 16:23:30 -08001408// Opens the vdex files and assigns the input fd to in_vdex_wrapper_fd and the output fd to
1409// out_vdex_wrapper_fd. Returns true for success or false in case of errors.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001410bool open_vdex_files_for_dex2oat(const char* apk_path, const char* out_oat_path, int dexopt_needed,
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001411 const char* instruction_set, bool is_public, int uid, bool is_secondary_dex,
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001412 bool profile_guided, Dex2oatFileWrapper* in_vdex_wrapper_fd,
Calin Juravle7a570e82017-01-14 16:23:30 -08001413 Dex2oatFileWrapper* out_vdex_wrapper_fd) {
1414 CHECK(in_vdex_wrapper_fd != nullptr);
1415 CHECK(out_vdex_wrapper_fd != nullptr);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001416 // Open the existing VDEX. We do this before creating the new output VDEX, which will
1417 // unlink the old one.
Richard Uhler76cc0272016-12-08 10:46:35 +00001418 char in_odex_path[PKG_PATH_MAX];
1419 int dexopt_action = abs(dexopt_needed);
1420 bool is_odex_location = dexopt_needed < 0;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001421 std::string in_vdex_path_str;
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001422
1423 // Infer the name of the output VDEX.
1424 const std::string out_vdex_path_str = create_vdex_filename(out_oat_path);
1425 if (out_vdex_path_str.empty()) {
1426 return false;
1427 }
1428
1429 bool update_vdex_in_place = false;
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001430 if (dexopt_action != DEX2OAT_FROM_SCRATCH) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001431 // Open the possibly existing vdex. If none exist, we pass -1 to dex2oat for input-vdex-fd.
1432 const char* path = nullptr;
1433 if (is_odex_location) {
1434 if (calculate_odex_file_path(in_odex_path, apk_path, instruction_set)) {
1435 path = in_odex_path;
1436 } else {
1437 ALOGE("installd cannot compute input vdex location for '%s'\n", apk_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001438 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001439 }
1440 } else {
1441 path = out_oat_path;
1442 }
1443 in_vdex_path_str = create_vdex_filename(path);
1444 if (in_vdex_path_str.empty()) {
1445 ALOGE("installd cannot compute input vdex location for '%s'\n", path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001446 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001447 }
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001448 // We can update in place when all these conditions are met:
1449 // 1) The vdex location to write to is the same as the vdex location to read (vdex files
1450 // on /system typically cannot be updated in place).
1451 // 2) We dex2oat due to boot image change, because we then know the existing vdex file
1452 // cannot be currently used by a running process.
1453 // 3) We are not doing a profile guided compilation, because dexlayout requires two
1454 // different vdex files to operate.
1455 update_vdex_in_place =
1456 (in_vdex_path_str == out_vdex_path_str) &&
1457 (dexopt_action == DEX2OAT_FOR_BOOT_IMAGE) &&
1458 !profile_guided;
1459 if (update_vdex_in_place) {
1460 // Open the file read-write to be able to update it.
1461 in_vdex_wrapper_fd->reset(open(in_vdex_path_str.c_str(), O_RDWR, 0));
1462 if (in_vdex_wrapper_fd->get() == -1) {
1463 // If we failed to open the file, we cannot update it in place.
1464 update_vdex_in_place = false;
1465 }
1466 } else {
1467 in_vdex_wrapper_fd->reset(open(in_vdex_path_str.c_str(), O_RDONLY, 0));
1468 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001469 }
1470
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001471 // If we are updating the vdex in place, we do not need to recreate a vdex,
1472 // and can use the same existing one.
1473 if (update_vdex_in_place) {
1474 // We unlink the file in case the invocation of dex2oat fails, to ensure we don't
1475 // have bogus stale vdex files.
1476 out_vdex_wrapper_fd->reset(
1477 in_vdex_wrapper_fd->get(),
1478 [out_vdex_path_str]() { unlink(out_vdex_path_str.c_str()); });
1479 // Disable auto close for the in wrapper fd (it will be done when destructing the out
1480 // wrapper).
1481 in_vdex_wrapper_fd->DisableAutoClose();
1482 } else {
1483 out_vdex_wrapper_fd->reset(
1484 open_output_file(out_vdex_path_str.c_str(), /*recreate*/true, /*permissions*/0644),
1485 [out_vdex_path_str]() { unlink(out_vdex_path_str.c_str()); });
1486 if (out_vdex_wrapper_fd->get() < 0) {
1487 ALOGE("installd cannot open vdex'%s' during dexopt\n", out_vdex_path_str.c_str());
1488 return false;
1489 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001490 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001491 if (!set_permissions_and_ownership(out_vdex_wrapper_fd->get(), is_public, uid,
Calin Juravle2289c0a2017-02-15 12:44:14 -08001492 out_vdex_path_str.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001493 ALOGE("installd cannot set owner '%s' for vdex during dexopt\n", out_vdex_path_str.c_str());
1494 return false;
1495 }
1496
1497 // If we got here we successfully opened the vdex files.
1498 return true;
1499}
1500
1501// Opens the output oat file for the given apk.
1502// If successful it stores the output path into out_oat_path and returns true.
1503Dex2oatFileWrapper open_oat_out_file(const char* apk_path, const char* oat_dir,
Calin Juravle80a21252017-01-17 14:43:25 -08001504 bool is_public, int uid, const char* instruction_set, bool is_secondary_dex,
1505 char* out_oat_path) {
1506 if (!create_oat_out_path(apk_path, instruction_set, oat_dir, is_secondary_dex, out_oat_path)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001507 return Dex2oatFileWrapper();
1508 }
1509 const std::string out_oat_path_str(out_oat_path);
1510 Dex2oatFileWrapper wrapper_fd(
1511 open_output_file(out_oat_path, /*recreate*/true, /*permissions*/0644),
1512 [out_oat_path_str]() { unlink(out_oat_path_str.c_str()); });
1513 if (wrapper_fd.get() < 0) {
Calin Juravle80a21252017-01-17 14:43:25 -08001514 PLOG(ERROR) << "installd cannot open output during dexopt" << out_oat_path;
Calin Juravle2289c0a2017-02-15 12:44:14 -08001515 } else if (!set_permissions_and_ownership(
1516 wrapper_fd.get(), is_public, uid, out_oat_path, is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001517 ALOGE("installd cannot set owner '%s' for output during dexopt\n", out_oat_path);
1518 wrapper_fd.reset(-1);
1519 }
1520 return wrapper_fd;
1521}
1522
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001523// Creates RDONLY fds for oat and vdex files, if exist.
1524// Returns false if it fails to create oat out path for the given apk path.
1525// Note that the method returns true even if the files could not be opened.
1526bool maybe_open_oat_and_vdex_file(const std::string& apk_path,
1527 const std::string& oat_dir,
1528 const std::string& instruction_set,
1529 bool is_secondary_dex,
1530 unique_fd* oat_file_fd,
1531 unique_fd* vdex_file_fd) {
1532 char oat_path[PKG_PATH_MAX];
1533 if (!create_oat_out_path(apk_path.c_str(),
1534 instruction_set.c_str(),
1535 oat_dir.c_str(),
1536 is_secondary_dex,
1537 oat_path)) {
Calin Juravle7d765462017-09-04 15:57:10 -07001538 LOG(ERROR) << "Could not create oat out path for "
1539 << apk_path << " with oat dir " << oat_dir;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001540 return false;
1541 }
1542 oat_file_fd->reset(open(oat_path, O_RDONLY));
1543 if (oat_file_fd->get() < 0) {
1544 PLOG(INFO) << "installd cannot open oat file during dexopt" << oat_path;
1545 }
1546
1547 std::string vdex_filename = create_vdex_filename(oat_path);
1548 vdex_file_fd->reset(open(vdex_filename.c_str(), O_RDONLY));
1549 if (vdex_file_fd->get() < 0) {
1550 PLOG(INFO) << "installd cannot open vdex file during dexopt" << vdex_filename;
1551 }
1552
1553 return true;
1554}
1555
Calin Juravle7a570e82017-01-14 16:23:30 -08001556// Updates the access times of out_oat_path based on those from apk_path.
1557void update_out_oat_access_times(const char* apk_path, const char* out_oat_path) {
1558 struct stat input_stat;
1559 memset(&input_stat, 0, sizeof(input_stat));
1560 if (stat(apk_path, &input_stat) != 0) {
1561 PLOG(ERROR) << "Could not stat " << apk_path << " during dexopt";
1562 return;
1563 }
1564
1565 struct utimbuf ut;
1566 ut.actime = input_stat.st_atime;
1567 ut.modtime = input_stat.st_mtime;
1568 if (utime(out_oat_path, &ut) != 0) {
1569 PLOG(WARNING) << "Could not update access times for " << apk_path << " during dexopt";
1570 }
1571}
1572
Calin Juravle80a21252017-01-17 14:43:25 -08001573// Runs (execv) dexoptanalyzer on the given arguments.
Calin Juravle114f0812017-03-08 19:05:07 -08001574// The analyzer will check if the dex_file needs to be (re)compiled to match the compiler_filter.
1575// If this is for a profile guided compilation, profile_was_updated will tell whether or not
1576// the profile has changed.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001577static void exec_dexoptanalyzer(const std::string& dex_file, int vdex_fd, int oat_fd,
1578 int zip_fd, const std::string& instruction_set, const std::string& compiler_filter,
1579 bool profile_was_updated, bool downgrade,
Calin Juravle58cab072017-09-12 01:02:26 -07001580 const char* class_loader_context) {
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001581 CHECK_GE(zip_fd, 0);
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001582 const char* dexoptanalyzer_bin =
1583 is_debug_runtime()
1584 ? "/system/bin/dexoptanalyzerd"
1585 : "/system/bin/dexoptanalyzer";
Calin Juravle80a21252017-01-17 14:43:25 -08001586 static const unsigned int MAX_INSTRUCTION_SET_LEN = 7;
1587
Calin Juravled23dee72017-07-06 16:29:11 -07001588 if (instruction_set.size() >= MAX_INSTRUCTION_SET_LEN) {
1589 LOG(ERROR) << "Instruction set " << instruction_set
1590 << " longer than max length of " << MAX_INSTRUCTION_SET_LEN;
Calin Juravle80a21252017-01-17 14:43:25 -08001591 return;
1592 }
1593
Calin Juravled23dee72017-07-06 16:29:11 -07001594 std::string dex_file_arg = "--dex-file=" + dex_file;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001595 std::string oat_fd_arg = "--oat-fd=" + std::to_string(oat_fd);
1596 std::string vdex_fd_arg = "--vdex-fd=" + std::to_string(vdex_fd);
1597 std::string zip_fd_arg = "--zip-fd=" + std::to_string(zip_fd);
Calin Juravled23dee72017-07-06 16:29:11 -07001598 std::string isa_arg = "--isa=" + instruction_set;
1599 std::string compiler_filter_arg = "--compiler-filter=" + compiler_filter;
Calin Juravle114f0812017-03-08 19:05:07 -08001600 const char* assume_profile_changed = "--assume-profile-changed";
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001601 const char* downgrade_flag = "--downgrade";
Calin Juravle58cab072017-09-12 01:02:26 -07001602 std::string class_loader_context_arg = "--class-loader-context=";
1603 if (class_loader_context != nullptr) {
1604 class_loader_context_arg += class_loader_context;
1605 }
Calin Juravle80a21252017-01-17 14:43:25 -08001606
Calin Juravle80a21252017-01-17 14:43:25 -08001607 // program name, dex file, isa, filter, the final NULL
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001608 const int argc = 6 +
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001609 (profile_was_updated ? 1 : 0) +
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001610 (vdex_fd >= 0 ? 1 : 0) +
1611 (oat_fd >= 0 ? 1 : 0) +
Calin Juravle58cab072017-09-12 01:02:26 -07001612 (downgrade ? 1 : 0) +
1613 (class_loader_context != nullptr ? 1 : 0);
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001614 const char* argv[argc];
Calin Juravle80a21252017-01-17 14:43:25 -08001615 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001616 argv[i++] = dexoptanalyzer_bin;
Calin Juravled23dee72017-07-06 16:29:11 -07001617 argv[i++] = dex_file_arg.c_str();
1618 argv[i++] = isa_arg.c_str();
1619 argv[i++] = compiler_filter_arg.c_str();
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001620 if (oat_fd >= 0) {
1621 argv[i++] = oat_fd_arg.c_str();
1622 }
1623 if (vdex_fd >= 0) {
1624 argv[i++] = vdex_fd_arg.c_str();
1625 }
1626 argv[i++] = zip_fd_arg.c_str();
Calin Juravle114f0812017-03-08 19:05:07 -08001627 if (profile_was_updated) {
1628 argv[i++] = assume_profile_changed;
1629 }
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001630 if (downgrade) {
1631 argv[i++] = downgrade_flag;
1632 }
Calin Juravle58cab072017-09-12 01:02:26 -07001633 if (class_loader_context != nullptr) {
Calin Juravle91501072017-10-26 15:44:53 -07001634 argv[i++] = class_loader_context_arg.c_str();
Calin Juravle58cab072017-09-12 01:02:26 -07001635 }
Yi Kong954cf642018-07-17 16:16:24 -07001636 argv[i] = nullptr;
Calin Juravle80a21252017-01-17 14:43:25 -08001637
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001638 execv(dexoptanalyzer_bin, (char * const *)argv);
1639 ALOGE("execv(%s) failed: %s\n", dexoptanalyzer_bin, strerror(errno));
Calin Juravle80a21252017-01-17 14:43:25 -08001640}
1641
1642// Prepares the oat dir for the secondary dex files.
Calin Juravle114f0812017-03-08 19:05:07 -08001643static bool prepare_secondary_dex_oat_dir(const std::string& dex_path, int uid,
Calin Juravle7d765462017-09-04 15:57:10 -07001644 const char* instruction_set) {
Calin Juravle114f0812017-03-08 19:05:07 -08001645 unsigned long dirIndex = dex_path.rfind('/');
Calin Juravle80a21252017-01-17 14:43:25 -08001646 if (dirIndex == std::string::npos) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001647 LOG(ERROR ) << "Unexpected dir structure for secondary dex " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001648 return false;
1649 }
Calin Juravle114f0812017-03-08 19:05:07 -08001650 std::string dex_dir = dex_path.substr(0, dirIndex);
Calin Juravle80a21252017-01-17 14:43:25 -08001651
Calin Juravle80a21252017-01-17 14:43:25 -08001652 // Create oat file output directory.
Calin Juravleebc8a792017-04-04 20:21:05 -07001653 mode_t oat_dir_mode = S_IRWXU | S_IRWXG | S_IXOTH;
1654 if (prepare_app_cache_dir(dex_dir, "oat", oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001655 LOG(ERROR) << "Could not prepare oat dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001656 return false;
1657 }
1658
1659 char oat_dir[PKG_PATH_MAX];
Calin Juravle114f0812017-03-08 19:05:07 -08001660 snprintf(oat_dir, PKG_PATH_MAX, "%s/oat", dex_dir.c_str());
Calin Juravle80a21252017-01-17 14:43:25 -08001661
Calin Juravle7d765462017-09-04 15:57:10 -07001662 if (prepare_app_cache_dir(oat_dir, instruction_set, oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001663 LOG(ERROR) << "Could not prepare oat/isa dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001664 return false;
1665 }
1666
1667 return true;
1668}
1669
Calin Juravle7d765462017-09-04 15:57:10 -07001670// Return codes for identifying the reason why dexoptanalyzer was not invoked when processing
1671// secondary dex files. This return codes are returned by the child process created for
1672// analyzing secondary dex files in process_secondary_dex_dexopt.
Calin Juravle80a21252017-01-17 14:43:25 -08001673
Andreas Gampe194fe422018-02-28 20:16:19 -08001674enum DexoptAnalyzerSkipCodes {
1675 // The dexoptanalyzer was not invoked because of validation or IO errors.
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001676 // Specific errors are encoded in the name.
1677 kSecondaryDexDexoptAnalyzerSkippedValidatePath = 200,
1678 kSecondaryDexDexoptAnalyzerSkippedOpenZip = 201,
1679 kSecondaryDexDexoptAnalyzerSkippedPrepareDir = 202,
1680 kSecondaryDexDexoptAnalyzerSkippedOpenOutput = 203,
1681 kSecondaryDexDexoptAnalyzerSkippedFailExec = 204,
Andreas Gampe194fe422018-02-28 20:16:19 -08001682 // The dexoptanalyzer was not invoked because the dex file does not exist anymore.
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001683 kSecondaryDexDexoptAnalyzerSkippedNoFile = 205,
Andreas Gampe194fe422018-02-28 20:16:19 -08001684};
Calin Juravle7d765462017-09-04 15:57:10 -07001685
1686// Verifies the result of analyzing secondary dex files from process_secondary_dex_dexopt.
Calin Juravle80a21252017-01-17 14:43:25 -08001687// If the result is valid returns true and sets dexopt_needed_out to a valid value.
1688// Returns false for errors or unexpected result values.
Calin Juravle7d765462017-09-04 15:57:10 -07001689// The result is expected to be either one of SECONDARY_DEX_* codes or a valid exit code
1690// of dexoptanalyzer.
1691static bool process_secondary_dexoptanalyzer_result(const std::string& dex_path, int result,
Andreas Gampe194fe422018-02-28 20:16:19 -08001692 int* dexopt_needed_out, std::string* error_msg) {
Calin Juravle80a21252017-01-17 14:43:25 -08001693 // The result values are defined in dexoptanalyzer.
1694 switch (result) {
Calin Juravle7d765462017-09-04 15:57:10 -07001695 case 0: // dexoptanalyzer: no_dexopt_needed
Calin Juravle80a21252017-01-17 14:43:25 -08001696 *dexopt_needed_out = NO_DEXOPT_NEEDED; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001697 case 1: // dexoptanalyzer: dex2oat_from_scratch
Calin Juravle80a21252017-01-17 14:43:25 -08001698 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH; return true;
Vladimir Marko1752a112018-09-03 18:15:16 +01001699 case 4: // dexoptanalyzer: dex2oat_for_bootimage_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001700 *dexopt_needed_out = -DEX2OAT_FOR_BOOT_IMAGE; return true;
Vladimir Marko1752a112018-09-03 18:15:16 +01001701 case 5: // dexoptanalyzer: dex2oat_for_filter_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001702 *dexopt_needed_out = -DEX2OAT_FOR_FILTER; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001703 case 2: // dexoptanalyzer: dex2oat_for_bootimage_oat
1704 case 3: // dexoptanalyzer: dex2oat_for_filter_oat
Andreas Gampe194fe422018-02-28 20:16:19 -08001705 *error_msg = StringPrintf("Dexoptanalyzer return the status of an oat file."
1706 " Expected odex file status for secondary dex %s"
1707 " : dexoptanalyzer result=%d",
1708 dex_path.c_str(),
1709 result);
Calin Juravle80a21252017-01-17 14:43:25 -08001710 return false;
Andreas Gampe194fe422018-02-28 20:16:19 -08001711 }
1712
1713 // Use a second switch for enum switch-case analysis.
1714 switch (static_cast<DexoptAnalyzerSkipCodes>(result)) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001715 case kSecondaryDexDexoptAnalyzerSkippedNoFile:
Calin Juravle7d765462017-09-04 15:57:10 -07001716 // If the file does not exist there's no need for dexopt.
1717 *dexopt_needed_out = NO_DEXOPT_NEEDED;
1718 return true;
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001719
1720 case kSecondaryDexDexoptAnalyzerSkippedValidatePath:
1721 *error_msg = "Dexoptanalyzer path validation failed";
1722 return false;
1723 case kSecondaryDexDexoptAnalyzerSkippedOpenZip:
1724 *error_msg = "Dexoptanalyzer open zip failed";
1725 return false;
1726 case kSecondaryDexDexoptAnalyzerSkippedPrepareDir:
1727 *error_msg = "Dexoptanalyzer dir preparation failed";
1728 return false;
1729 case kSecondaryDexDexoptAnalyzerSkippedOpenOutput:
1730 *error_msg = "Dexoptanalyzer open output failed";
1731 return false;
1732 case kSecondaryDexDexoptAnalyzerSkippedFailExec:
1733 *error_msg = "Dexoptanalyzer failed to execute";
Calin Juravle80a21252017-01-17 14:43:25 -08001734 return false;
1735 }
Andreas Gampe194fe422018-02-28 20:16:19 -08001736
1737 *error_msg = StringPrintf("Unexpected result from analyzing secondary dex %s result=%d",
1738 dex_path.c_str(),
1739 result);
1740 return false;
Calin Juravle80a21252017-01-17 14:43:25 -08001741}
1742
Calin Juravle7d765462017-09-04 15:57:10 -07001743enum SecondaryDexAccess {
1744 kSecondaryDexAccessReadOk = 0,
1745 kSecondaryDexAccessDoesNotExist = 1,
1746 kSecondaryDexAccessPermissionError = 2,
1747 kSecondaryDexAccessIOError = 3
1748};
1749
1750static SecondaryDexAccess check_secondary_dex_access(const std::string& dex_path) {
1751 // Check if the path exists and can be read. If not, there's nothing to do.
1752 if (access(dex_path.c_str(), R_OK) == 0) {
1753 return kSecondaryDexAccessReadOk;
1754 } else {
1755 if (errno == ENOENT) {
1756 LOG(INFO) << "Secondary dex does not exist: " << dex_path;
1757 return kSecondaryDexAccessDoesNotExist;
1758 } else {
1759 PLOG(ERROR) << "Could not access secondary dex " << dex_path;
1760 return errno == EACCES
1761 ? kSecondaryDexAccessPermissionError
1762 : kSecondaryDexAccessIOError;
1763 }
1764 }
1765}
1766
1767static bool is_file_public(const std::string& filename) {
1768 struct stat file_stat;
1769 if (stat(filename.c_str(), &file_stat) == 0) {
1770 return (file_stat.st_mode & S_IROTH) != 0;
1771 }
1772 return false;
1773}
1774
1775// Create the oat file structure for the secondary dex 'dex_path' and assign
1776// the individual path component to the 'out_' parameters.
1777static bool create_secondary_dex_oat_layout(const std::string& dex_path, const std::string& isa,
Andreas Gampe194fe422018-02-28 20:16:19 -08001778 char* out_oat_dir, char* out_oat_isa_dir, char* out_oat_path, std::string* error_msg) {
Calin Juravle7d765462017-09-04 15:57:10 -07001779 size_t dirIndex = dex_path.rfind('/');
1780 if (dirIndex == std::string::npos) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001781 *error_msg = std::string("Unexpected dir structure for dex file ").append(dex_path);
Calin Juravle7d765462017-09-04 15:57:10 -07001782 return false;
1783 }
1784 // TODO(calin): we have similar computations in at lest 3 other places
1785 // (InstalldNativeService, otapropt and dexopt). Unify them and get rid of snprintf by
1786 // using string append.
1787 std::string apk_dir = dex_path.substr(0, dirIndex);
1788 snprintf(out_oat_dir, PKG_PATH_MAX, "%s/oat", apk_dir.c_str());
1789 snprintf(out_oat_isa_dir, PKG_PATH_MAX, "%s/%s", out_oat_dir, isa.c_str());
1790
1791 if (!create_oat_out_path(dex_path.c_str(), isa.c_str(), out_oat_dir,
1792 /*is_secondary_dex*/true, out_oat_path)) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001793 *error_msg = std::string("Could not create oat path for secondary dex ").append(dex_path);
Calin Juravle7d765462017-09-04 15:57:10 -07001794 return false;
1795 }
1796 return true;
1797}
1798
1799// Validate that the dexopt_flags contain a valid storage flag and convert that to an installd
1800// recognized storage flags (FLAG_STORAGE_CE or FLAG_STORAGE_DE).
Andreas Gampe194fe422018-02-28 20:16:19 -08001801static bool validate_dexopt_storage_flags(int dexopt_flags,
1802 int* out_storage_flag,
1803 std::string* error_msg) {
Calin Juravle7d765462017-09-04 15:57:10 -07001804 if ((dexopt_flags & DEXOPT_STORAGE_CE) != 0) {
1805 *out_storage_flag = FLAG_STORAGE_CE;
1806 if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001807 *error_msg = "Ambiguous secondary dex storage flag. Both, CE and DE, flags are set";
Calin Juravle7d765462017-09-04 15:57:10 -07001808 return false;
1809 }
1810 } else if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
1811 *out_storage_flag = FLAG_STORAGE_DE;
1812 } else {
Andreas Gampe194fe422018-02-28 20:16:19 -08001813 *error_msg = "Secondary dex storage flag must be set";
Calin Juravle7d765462017-09-04 15:57:10 -07001814 return false;
1815 }
1816 return true;
1817}
1818
Calin Juravlec9eab382017-01-25 01:17:17 -08001819// Processes the dex_path as a secondary dex files and return true if the path dex file should
Calin Juravle80a21252017-01-17 14:43:25 -08001820// be compiled. Returns false for errors (logged) or true if the secondary dex path was process
1821// successfully.
Calin Juravleebc8a792017-04-04 20:21:05 -07001822// When returning true, the output parameters will be:
1823// - is_public_out: whether or not the oat file should not be made public
1824// - dexopt_needed_out: valid OatFileAsssitant::DexOptNeeded
1825// - oat_dir_out: the oat dir path where the oat file should be stored
Calin Juravle7d765462017-09-04 15:57:10 -07001826static bool process_secondary_dex_dexopt(const std::string& dex_path, const char* pkgname,
Calin Juravle80a21252017-01-17 14:43:25 -08001827 int dexopt_flags, const char* volume_uuid, int uid, const char* instruction_set,
Calin Juravleebc8a792017-04-04 20:21:05 -07001828 const char* compiler_filter, bool* is_public_out, int* dexopt_needed_out,
Andreas Gampe194fe422018-02-28 20:16:19 -08001829 std::string* oat_dir_out, bool downgrade, const char* class_loader_context,
1830 /* out */ std::string* error_msg) {
Calin Juravle7d765462017-09-04 15:57:10 -07001831 LOG(DEBUG) << "Processing secondary dex path " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001832 int storage_flag;
Andreas Gampe194fe422018-02-28 20:16:19 -08001833 if (!validate_dexopt_storage_flags(dexopt_flags, &storage_flag, error_msg)) {
1834 LOG(ERROR) << *error_msg;
Calin Juravle80a21252017-01-17 14:43:25 -08001835 return false;
1836 }
Calin Juravle7d765462017-09-04 15:57:10 -07001837 // Compute the oat dir as it's not easy to extract it from the child computation.
1838 char oat_path[PKG_PATH_MAX];
1839 char oat_dir[PKG_PATH_MAX];
1840 char oat_isa_dir[PKG_PATH_MAX];
1841 if (!create_secondary_dex_oat_layout(
Andreas Gampe194fe422018-02-28 20:16:19 -08001842 dex_path, instruction_set, oat_dir, oat_isa_dir, oat_path, error_msg)) {
1843 LOG(ERROR) << "Could not create secondary odex layout: " << *error_msg;
Calin Juravled23dee72017-07-06 16:29:11 -07001844 return false;
1845 }
Calin Juravle7d765462017-09-04 15:57:10 -07001846 oat_dir_out->assign(oat_dir);
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001847
Calin Juravle80a21252017-01-17 14:43:25 -08001848 pid_t pid = fork();
1849 if (pid == 0) {
1850 // child -- drop privileges before continuing.
1851 drop_capabilities(uid);
Calin Juravle7d765462017-09-04 15:57:10 -07001852
1853 // Validate the path structure.
1854 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid, uid, storage_flag)) {
1855 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001856 _exit(kSecondaryDexDexoptAnalyzerSkippedValidatePath);
Calin Juravle7d765462017-09-04 15:57:10 -07001857 }
1858
1859 // Open the dex file.
1860 unique_fd zip_fd;
1861 zip_fd.reset(open(dex_path.c_str(), O_RDONLY));
1862 if (zip_fd.get() < 0) {
1863 if (errno == ENOENT) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001864 _exit(kSecondaryDexDexoptAnalyzerSkippedNoFile);
Calin Juravle7d765462017-09-04 15:57:10 -07001865 } else {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001866 _exit(kSecondaryDexDexoptAnalyzerSkippedOpenZip);
Calin Juravle7d765462017-09-04 15:57:10 -07001867 }
1868 }
1869
1870 // Prepare the oat directories.
1871 if (!prepare_secondary_dex_oat_dir(dex_path, uid, instruction_set)) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001872 _exit(kSecondaryDexDexoptAnalyzerSkippedPrepareDir);
Calin Juravle7d765462017-09-04 15:57:10 -07001873 }
1874
1875 // Open the vdex/oat files if any.
1876 unique_fd oat_file_fd;
1877 unique_fd vdex_file_fd;
1878 if (!maybe_open_oat_and_vdex_file(dex_path,
1879 *oat_dir_out,
1880 instruction_set,
1881 true /* is_secondary_dex */,
1882 &oat_file_fd,
1883 &vdex_file_fd)) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001884 _exit(kSecondaryDexDexoptAnalyzerSkippedOpenOutput);
Calin Juravle7d765462017-09-04 15:57:10 -07001885 }
1886
1887 // Analyze profiles.
Calin Juravle824a64d2018-01-18 20:23:17 -08001888 bool profile_was_updated = analyze_profiles(uid, pkgname, dex_path,
1889 /*is_secondary_dex*/true);
Calin Juravle7d765462017-09-04 15:57:10 -07001890
1891 // Run dexoptanalyzer to get dexopt_needed code. This is not expected to return.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001892 exec_dexoptanalyzer(dex_path,
1893 vdex_file_fd.get(),
1894 oat_file_fd.get(),
1895 zip_fd.get(),
1896 instruction_set,
Calin Juravle7d765462017-09-04 15:57:10 -07001897 compiler_filter, profile_was_updated,
1898 downgrade,
1899 class_loader_context);
1900 PLOG(ERROR) << "Failed to exec dexoptanalyzer";
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001901 _exit(kSecondaryDexDexoptAnalyzerSkippedFailExec);
Calin Juravle80a21252017-01-17 14:43:25 -08001902 }
1903
1904 /* parent */
Calin Juravle80a21252017-01-17 14:43:25 -08001905 int result = wait_child(pid);
1906 if (!WIFEXITED(result)) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001907 *error_msg = StringPrintf("dexoptanalyzer failed for path %s: 0x%04x",
1908 dex_path.c_str(),
1909 result);
1910 LOG(ERROR) << *error_msg;
Calin Juravle80a21252017-01-17 14:43:25 -08001911 return false;
1912 }
1913 result = WEXITSTATUS(result);
Calin Juravle7d765462017-09-04 15:57:10 -07001914 // Check that we successfully executed dexoptanalyzer.
Andreas Gampe194fe422018-02-28 20:16:19 -08001915 bool success = process_secondary_dexoptanalyzer_result(dex_path,
1916 result,
1917 dexopt_needed_out,
1918 error_msg);
1919 if (!success) {
1920 LOG(ERROR) << *error_msg;
1921 }
Calin Juravle7d765462017-09-04 15:57:10 -07001922
1923 LOG(DEBUG) << "Processed secondary dex file " << dex_path << " result=" << result;
1924
Calin Juravle80a21252017-01-17 14:43:25 -08001925 // Run dexopt only if needed or forced.
Calin Juravle7d765462017-09-04 15:57:10 -07001926 // Note that dexoptanalyzer is executed even if force compilation is enabled (because it
1927 // makes the code simpler; force compilation is only needed during tests).
1928 if (success &&
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001929 (result != kSecondaryDexDexoptAnalyzerSkippedNoFile) &&
Calin Juravle7d765462017-09-04 15:57:10 -07001930 ((dexopt_flags & DEXOPT_FORCE) != 0)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001931 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH;
1932 }
1933
Calin Juravle7d765462017-09-04 15:57:10 -07001934 // Check if we should make the oat file public.
1935 // Note that if the dex file is not public the compiled code cannot be made public.
1936 // It is ok to check this flag outside in the parent process.
1937 *is_public_out = ((dexopt_flags & DEXOPT_PUBLIC) != 0) && is_file_public(dex_path);
1938
Calin Juravle80a21252017-01-17 14:43:25 -08001939 return success;
1940}
1941
Andreas Gampefa2dadd2018-02-28 19:52:47 -08001942static std::string format_dexopt_error(int status, const char* dex_path) {
1943 if (WIFEXITED(status)) {
1944 int int_code = WEXITSTATUS(status);
1945 const char* code_name = get_return_code_name(static_cast<DexoptReturnCodes>(int_code));
1946 if (code_name != nullptr) {
1947 return StringPrintf("Dex2oat invocation for %s failed: %s", dex_path, code_name);
1948 }
1949 }
1950 return StringPrintf("Dex2oat invocation for %s failed with 0x%04x", dex_path, status);
Andreas Gampe023b2242018-02-28 16:03:25 -08001951}
1952
Calin Juravlec9eab382017-01-25 01:17:17 -08001953int dexopt(const char* dex_path, uid_t uid, const char* pkgname, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -08001954 int dexopt_needed, const char* oat_dir, int dexopt_flags, const char* compiler_filter,
Calin Juravle52c45822017-07-13 22:50:21 -07001955 const char* volume_uuid, const char* class_loader_context, const char* se_info,
Calin Juravle62c5a372018-02-01 17:03:23 +00001956 bool downgrade, int target_sdk_version, const char* profile_name,
Andreas Gampe023b2242018-02-28 16:03:25 -08001957 const char* dex_metadata_path, const char* compilation_reason, std::string* error_msg) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001958 CHECK(pkgname != nullptr);
1959 CHECK(pkgname[0] != 0);
Andreas Gampe023b2242018-02-28 16:03:25 -08001960 CHECK(error_msg != nullptr);
Andreas Gamped32eec22018-02-28 16:02:51 -08001961 CHECK_EQ(dexopt_flags & ~DEXOPT_MASK, 0)
1962 << "dexopt flags contains unknown fields: " << dexopt_flags;
Calin Juravle7a570e82017-01-14 16:23:30 -08001963
Calin Juravled23dee72017-07-06 16:29:11 -07001964 if (!validate_dex_path_size(dex_path)) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001965 *error_msg = StringPrintf("Failed to validate %s", dex_path);
Calin Juravle52c45822017-07-13 22:50:21 -07001966 return -1;
1967 }
1968
1969 if (class_loader_context != nullptr && strlen(class_loader_context) > PKG_PATH_MAX) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001970 *error_msg = StringPrintf("Class loader context exceeds the allowed size: %s",
1971 class_loader_context);
1972 LOG(ERROR) << *error_msg;
Calin Juravle52c45822017-07-13 22:50:21 -07001973 return -1;
Calin Juravled23dee72017-07-06 16:29:11 -07001974 }
1975
Calin Juravleebc8a792017-04-04 20:21:05 -07001976 bool is_public = (dexopt_flags & DEXOPT_PUBLIC) != 0;
Calin Juravle7a570e82017-01-14 16:23:30 -08001977 bool debuggable = (dexopt_flags & DEXOPT_DEBUGGABLE) != 0;
1978 bool boot_complete = (dexopt_flags & DEXOPT_BOOTCOMPLETE) != 0;
1979 bool profile_guided = (dexopt_flags & DEXOPT_PROFILE_GUIDED) != 0;
Calin Juravle80a21252017-01-17 14:43:25 -08001980 bool is_secondary_dex = (dexopt_flags & DEXOPT_SECONDARY_DEX) != 0;
Andreas Gampea73a0cb2017-11-02 18:14:42 -07001981 bool background_job_compile = (dexopt_flags & DEXOPT_IDLE_BACKGROUND_JOB) != 0;
David Brazdil52249162018-02-12 18:04:59 -08001982 bool enable_hidden_api_checks = (dexopt_flags & DEXOPT_ENABLE_HIDDEN_API_CHECKS) != 0;
Mathieu Chartierf69c2f72018-03-06 13:55:58 -08001983 bool generate_compact_dex = (dexopt_flags & DEXOPT_GENERATE_COMPACT_DEX) != 0;
Mathieu Chartier1dc3dfa2018-03-12 17:55:06 -07001984 bool generate_app_image = (dexopt_flags & DEXOPT_GENERATE_APP_IMAGE) != 0;
Calin Juravle80a21252017-01-17 14:43:25 -08001985
1986 // Check if we're dealing with a secondary dex file and if we need to compile it.
1987 std::string oat_dir_str;
1988 if (is_secondary_dex) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001989 if (process_secondary_dex_dexopt(dex_path, pkgname, dexopt_flags, volume_uuid, uid,
Calin Juravleebc8a792017-04-04 20:21:05 -07001990 instruction_set, compiler_filter, &is_public, &dexopt_needed, &oat_dir_str,
Andreas Gampe194fe422018-02-28 20:16:19 -08001991 downgrade, class_loader_context, error_msg)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001992 oat_dir = oat_dir_str.c_str();
1993 if (dexopt_needed == NO_DEXOPT_NEEDED) {
1994 return 0; // Nothing to do, report success.
1995 }
1996 } else {
Andreas Gampe194fe422018-02-28 20:16:19 -08001997 if (error_msg->empty()) { // TODO: Make this a CHECK.
1998 *error_msg = "Failed processing secondary.";
1999 }
Calin Juravle80a21252017-01-17 14:43:25 -08002000 return -1; // We had an error, logged in the process method.
2001 }
2002 } else {
Calin Juravlec9eab382017-01-25 01:17:17 -08002003 // Currently these flags are only use for secondary dex files.
2004 // Verify that they are not set for primary apks.
Calin Juravle80a21252017-01-17 14:43:25 -08002005 CHECK((dexopt_flags & DEXOPT_STORAGE_CE) == 0);
2006 CHECK((dexopt_flags & DEXOPT_STORAGE_DE) == 0);
2007 }
Calin Juravle7a570e82017-01-14 16:23:30 -08002008
2009 // Open the input file.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08002010 unique_fd input_fd(open(dex_path, O_RDONLY, 0));
Calin Juravle7a570e82017-01-14 16:23:30 -08002011 if (input_fd.get() < 0) {
Andreas Gampe023b2242018-02-28 16:03:25 -08002012 *error_msg = StringPrintf("installd cannot open '%s' for input during dexopt", dex_path);
2013 LOG(ERROR) << *error_msg;
Calin Juravle7a570e82017-01-14 16:23:30 -08002014 return -1;
2015 }
2016
2017 // Create the output OAT file.
2018 char out_oat_path[PKG_PATH_MAX];
Calin Juravlec9eab382017-01-25 01:17:17 -08002019 Dex2oatFileWrapper out_oat_fd = open_oat_out_file(dex_path, oat_dir, is_public, uid,
Calin Juravle80a21252017-01-17 14:43:25 -08002020 instruction_set, is_secondary_dex, out_oat_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08002021 if (out_oat_fd.get() < 0) {
Andreas Gampe023b2242018-02-28 16:03:25 -08002022 *error_msg = "Could not open out oat file.";
Calin Juravle7a570e82017-01-14 16:23:30 -08002023 return -1;
2024 }
2025
2026 // Open vdex files.
2027 Dex2oatFileWrapper in_vdex_fd;
2028 Dex2oatFileWrapper out_vdex_fd;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07002029 if (!open_vdex_files_for_dex2oat(dex_path, out_oat_path, dexopt_needed, instruction_set,
2030 is_public, uid, is_secondary_dex, profile_guided, &in_vdex_fd, &out_vdex_fd)) {
Andreas Gampe023b2242018-02-28 16:03:25 -08002031 *error_msg = "Could not open vdex files.";
Jeff Sharkey90aff262016-12-12 14:28:24 -07002032 return -1;
2033 }
2034
Calin Juravlecb556e32017-04-04 20:22:50 -07002035 // Ensure that the oat dir and the compiler artifacts of secondary dex files have the correct
2036 // selinux context (we generate them on the fly during the dexopt invocation and they don't
2037 // fully inherit their parent context).
2038 // Note that for primary apk the oat files are created before, in a separate installd
2039 // call which also does the restorecon. TODO(calin): unify the paths.
2040 if (is_secondary_dex) {
2041 if (selinux_android_restorecon_pkgdir(oat_dir, se_info, uid,
2042 SELINUX_ANDROID_RESTORECON_RECURSE)) {
Andreas Gampe023b2242018-02-28 16:03:25 -08002043 *error_msg = std::string("Failed to restorecon ").append(oat_dir);
2044 LOG(ERROR) << *error_msg;
Calin Juravlecb556e32017-04-04 20:22:50 -07002045 return -1;
2046 }
2047 }
2048
Jeff Sharkey90aff262016-12-12 14:28:24 -07002049 // Create a swap file if necessary.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08002050 unique_fd swap_fd = maybe_open_dexopt_swap_file(out_oat_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002051
Calin Juravle7a570e82017-01-14 16:23:30 -08002052 // Create the app image file if needed.
Mathieu Chartier1dc3dfa2018-03-12 17:55:06 -07002053 Dex2oatFileWrapper image_fd = maybe_open_app_image(
2054 out_oat_path, generate_app_image, is_public, uid, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002055
Calin Juravle7a570e82017-01-14 16:23:30 -08002056 // Open the reference profile if needed.
Calin Juravle114f0812017-03-08 19:05:07 -08002057 Dex2oatFileWrapper reference_profile_fd = maybe_open_reference_profile(
Calin Juravle824a64d2018-01-18 20:23:17 -08002058 pkgname, dex_path, profile_name, profile_guided, is_public, uid, is_secondary_dex);
Calin Juravle7a570e82017-01-14 16:23:30 -08002059
Calin Juravle62c5a372018-02-01 17:03:23 +00002060 unique_fd dex_metadata_fd;
2061 if (dex_metadata_path != nullptr) {
2062 dex_metadata_fd.reset(TEMP_FAILURE_RETRY(open(dex_metadata_path, O_RDONLY | O_NOFOLLOW)));
2063 if (dex_metadata_fd.get() < 0) {
2064 PLOG(ERROR) << "Failed to open dex metadata file " << dex_metadata_path;
2065 }
2066 }
2067
Andreas Gampe023b2242018-02-28 16:03:25 -08002068 LOG(VERBOSE) << "DexInv: --- BEGIN '" << dex_path << "' ---";
Jeff Sharkey90aff262016-12-12 14:28:24 -07002069
2070 pid_t pid = fork();
2071 if (pid == 0) {
2072 /* child -- drop privileges before continuing */
2073 drop_capabilities(uid);
2074
Richard Uhler76cc0272016-12-08 10:46:35 +00002075 SetDex2OatScheduling(boot_complete);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002076 if (flock(out_oat_fd.get(), LOCK_EX | LOCK_NB) != 0) {
Andreas Gampe023b2242018-02-28 16:03:25 -08002077 PLOG(ERROR) << "flock(" << out_oat_path << ") failed";
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002078 _exit(DexoptReturnCodes::kFlock);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002079 }
2080
Richard Uhler76cc0272016-12-08 10:46:35 +00002081 run_dex2oat(input_fd.get(),
2082 out_oat_fd.get(),
2083 in_vdex_fd.get(),
Calin Juravle7a570e82017-01-14 16:23:30 -08002084 out_vdex_fd.get(),
Richard Uhler76cc0272016-12-08 10:46:35 +00002085 image_fd.get(),
Jeff Hao10b8a6e2017-04-05 17:11:39 -07002086 dex_path,
Richard Uhler76cc0272016-12-08 10:46:35 +00002087 out_oat_path,
2088 swap_fd.get(),
2089 instruction_set,
2090 compiler_filter,
Richard Uhler76cc0272016-12-08 10:46:35 +00002091 debuggable,
2092 boot_complete,
Andreas Gampea73a0cb2017-11-02 18:14:42 -07002093 background_job_compile,
Richard Uhler76cc0272016-12-08 10:46:35 +00002094 reference_profile_fd.get(),
David Brazdil570d3982018-01-16 20:15:43 +00002095 class_loader_context,
David Brazdil7fcbb812018-01-17 17:05:40 +00002096 target_sdk_version,
Calin Juravle62c5a372018-02-01 17:03:23 +00002097 enable_hidden_api_checks,
Mathieu Chartierf69c2f72018-03-06 13:55:58 -08002098 generate_compact_dex,
Calin Juravle2efc4022018-02-13 18:31:32 -08002099 dex_metadata_fd.get(),
2100 compilation_reason);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002101 } else {
2102 int res = wait_child(pid);
2103 if (res == 0) {
Andreas Gampe023b2242018-02-28 16:03:25 -08002104 LOG(VERBOSE) << "DexInv: --- END '" << dex_path << "' (success) ---";
Jeff Sharkey90aff262016-12-12 14:28:24 -07002105 } else {
Andreas Gampe023b2242018-02-28 16:03:25 -08002106 LOG(VERBOSE) << "DexInv: --- END '" << dex_path << "' --- status=0x"
2107 << std::hex << std::setw(4) << res << ", process failed";
2108 *error_msg = format_dexopt_error(res, dex_path);
Andreas Gampe013f02e2017-03-20 18:36:54 -07002109 return res;
Jeff Sharkey90aff262016-12-12 14:28:24 -07002110 }
2111 }
2112
Calin Juravlec9eab382017-01-25 01:17:17 -08002113 update_out_oat_access_times(dex_path, out_oat_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002114
2115 // We've been successful, don't delete output.
2116 out_oat_fd.SetCleanup(false);
Calin Juravle7a570e82017-01-14 16:23:30 -08002117 out_vdex_fd.SetCleanup(false);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002118 image_fd.SetCleanup(false);
2119 reference_profile_fd.SetCleanup(false);
2120
2121 return 0;
2122}
2123
Calin Juravlec9eab382017-01-25 01:17:17 -08002124// Try to remove the given directory. Log an error if the directory exists
2125// and is empty but could not be removed.
2126static bool rmdir_if_empty(const char* dir) {
2127 if (rmdir(dir) == 0) {
2128 return true;
2129 }
2130 if (errno == ENOENT || errno == ENOTEMPTY) {
2131 return true;
2132 }
2133 PLOG(ERROR) << "Failed to remove dir: " << dir;
2134 return false;
2135}
2136
2137// Try to unlink the given file. Log an error if the file exists and could not
2138// be unlinked.
2139static bool unlink_if_exists(const std::string& file) {
2140 if (unlink(file.c_str()) == 0) {
2141 return true;
2142 }
2143 if (errno == ENOENT) {
2144 return true;
2145
2146 }
2147 PLOG(ERROR) << "Could not unlink: " << file;
2148 return false;
2149}
2150
Calin Juravle7d765462017-09-04 15:57:10 -07002151enum ReconcileSecondaryDexResult {
2152 kReconcileSecondaryDexExists = 0,
2153 kReconcileSecondaryDexCleanedUp = 1,
2154 kReconcileSecondaryDexValidationError = 2,
2155 kReconcileSecondaryDexCleanUpError = 3,
2156 kReconcileSecondaryDexAccessIOError = 4,
2157};
Calin Juravlec9eab382017-01-25 01:17:17 -08002158
2159// Reconcile the secondary dex 'dex_path' and its generated oat files.
2160// Return true if all the parameters are valid and the secondary dex file was
2161// processed successfully (i.e. the dex_path either exists, or if not, its corresponding
2162// oat/vdex/art files where deleted successfully). In this case, out_secondary_dex_exists
2163// will be true if the secondary dex file still exists. If the secondary dex file does not exist,
2164// the method cleans up any previously generated compiler artifacts (oat, vdex, art).
2165// Return false if there were errors during processing. In this case
2166// out_secondary_dex_exists will be set to false.
2167bool reconcile_secondary_dex_file(const std::string& dex_path,
2168 const std::string& pkgname, int uid, const std::vector<std::string>& isas,
2169 const std::unique_ptr<std::string>& volume_uuid, int storage_flag,
2170 /*out*/bool* out_secondary_dex_exists) {
Calin Juravle7d765462017-09-04 15:57:10 -07002171 *out_secondary_dex_exists = false; // start by assuming the file does not exist.
Calin Juravlec9eab382017-01-25 01:17:17 -08002172 if (isas.size() == 0) {
2173 LOG(ERROR) << "reconcile_secondary_dex_file called with empty isas vector";
2174 return false;
2175 }
2176
Calin Juravle7d765462017-09-04 15:57:10 -07002177 if (storage_flag != FLAG_STORAGE_CE && storage_flag != FLAG_STORAGE_DE) {
2178 LOG(ERROR) << "reconcile_secondary_dex_file called with invalid storage_flag: "
2179 << storage_flag;
Calin Juravlec9eab382017-01-25 01:17:17 -08002180 return false;
2181 }
2182
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002183 // As a security measure we want to unlink art artifacts with the reduced capabilities
2184 // of the package user id. So we fork and drop capabilities in the child.
2185 pid_t pid = fork();
2186 if (pid == 0) {
Calin Juravle7d765462017-09-04 15:57:10 -07002187 /* child -- drop privileges before continuing */
2188 drop_capabilities(uid);
2189
2190 const char* volume_uuid_cstr = volume_uuid == nullptr ? nullptr : volume_uuid->c_str();
2191 if (!validate_secondary_dex_path(pkgname.c_str(), dex_path.c_str(), volume_uuid_cstr,
2192 uid, storage_flag)) {
2193 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
2194 _exit(kReconcileSecondaryDexValidationError);
2195 }
2196
2197 SecondaryDexAccess access_check = check_secondary_dex_access(dex_path);
2198 switch (access_check) {
2199 case kSecondaryDexAccessDoesNotExist:
2200 // File does not exist. Proceed with cleaning.
2201 break;
2202 case kSecondaryDexAccessReadOk: _exit(kReconcileSecondaryDexExists);
2203 case kSecondaryDexAccessIOError: _exit(kReconcileSecondaryDexAccessIOError);
2204 case kSecondaryDexAccessPermissionError: _exit(kReconcileSecondaryDexValidationError);
2205 default:
2206 LOG(ERROR) << "Unexpected result from check_secondary_dex_access: " << access_check;
2207 _exit(kReconcileSecondaryDexValidationError);
2208 }
2209
2210 // The secondary dex does not exist anymore or it's. Clear any generated files.
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002211 char oat_path[PKG_PATH_MAX];
2212 char oat_dir[PKG_PATH_MAX];
2213 char oat_isa_dir[PKG_PATH_MAX];
2214 bool result = true;
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002215 for (size_t i = 0; i < isas.size(); i++) {
Andreas Gampe194fe422018-02-28 20:16:19 -08002216 std::string error_msg;
Calin Juravle7d765462017-09-04 15:57:10 -07002217 if (!create_secondary_dex_oat_layout(
Andreas Gampe194fe422018-02-28 20:16:19 -08002218 dex_path,isas[i], oat_dir, oat_isa_dir, oat_path, &error_msg)) {
2219 LOG(ERROR) << error_msg;
Calin Juravle7d765462017-09-04 15:57:10 -07002220 _exit(kReconcileSecondaryDexValidationError);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002221 }
Calin Juravle51314092017-05-18 15:33:05 -07002222
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002223 // Delete oat/vdex/art files.
2224 result = unlink_if_exists(oat_path) && result;
2225 result = unlink_if_exists(create_vdex_filename(oat_path)) && result;
2226 result = unlink_if_exists(create_image_filename(oat_path)) && result;
Calin Juravlec9eab382017-01-25 01:17:17 -08002227
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002228 // Delete profiles.
2229 std::string current_profile = create_current_profile_path(
Calin Juravle824a64d2018-01-18 20:23:17 -08002230 multiuser_get_user_id(uid), pkgname, dex_path, /*is_secondary*/true);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002231 std::string reference_profile = create_reference_profile_path(
Calin Juravle824a64d2018-01-18 20:23:17 -08002232 pkgname, dex_path, /*is_secondary*/true);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002233 result = unlink_if_exists(current_profile) && result;
2234 result = unlink_if_exists(reference_profile) && result;
Calin Juravle51314092017-05-18 15:33:05 -07002235
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002236 // We upgraded once the location of current profile for secondary dex files.
2237 // Check for any previous left-overs and remove them as well.
2238 std::string old_current_profile = dex_path + ".prof";
2239 result = unlink_if_exists(old_current_profile);
Calin Juravle3760ad32017-07-27 16:31:55 -07002240
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002241 // Try removing the directories as well, they might be empty.
2242 result = rmdir_if_empty(oat_isa_dir) && result;
2243 result = rmdir_if_empty(oat_dir) && result;
2244 }
Calin Juravle7d765462017-09-04 15:57:10 -07002245 if (!result) {
2246 PLOG(ERROR) << "Failed to clean secondary dex artifacts for location " << dex_path;
2247 }
2248 _exit(result ? kReconcileSecondaryDexCleanedUp : kReconcileSecondaryDexAccessIOError);
Calin Juravlec9eab382017-01-25 01:17:17 -08002249 }
2250
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002251 int return_code = wait_child(pid);
Calin Juravle7d765462017-09-04 15:57:10 -07002252 if (!WIFEXITED(return_code)) {
2253 LOG(WARNING) << "reconcile dex failed for location " << dex_path << ": " << return_code;
2254 } else {
2255 return_code = WEXITSTATUS(return_code);
2256 }
2257
2258 LOG(DEBUG) << "Reconcile secondary dex path " << dex_path << " result=" << return_code;
2259
2260 switch (return_code) {
2261 case kReconcileSecondaryDexCleanedUp:
2262 case kReconcileSecondaryDexValidationError:
2263 // If we couldn't validate assume the dex file does not exist.
2264 // This will purge the entry from the PM records.
2265 *out_secondary_dex_exists = false;
2266 return true;
2267 case kReconcileSecondaryDexExists:
2268 *out_secondary_dex_exists = true;
2269 return true;
2270 case kReconcileSecondaryDexAccessIOError:
2271 // We had an access IO error.
2272 // Return false so that we can try again.
2273 // The value of out_secondary_dex_exists does not matter in this case and by convention
2274 // is set to false.
2275 *out_secondary_dex_exists = false;
2276 return false;
2277 default:
2278 LOG(ERROR) << "Unexpected code from reconcile_secondary_dex_file: " << return_code;
2279 *out_secondary_dex_exists = false;
2280 return false;
2281 }
Calin Juravlec9eab382017-01-25 01:17:17 -08002282}
2283
Alan Stokesa25d90c2017-10-16 10:56:00 +01002284// Compute and return the hash (SHA-256) of the secondary dex file at dex_path.
2285// Returns true if all parameters are valid and the hash successfully computed and stored in
2286// out_secondary_dex_hash.
2287// Also returns true with an empty hash if the file does not currently exist or is not accessible to
2288// the app.
2289// For any other errors (e.g. if any of the parameters are invalid) returns false.
2290bool hash_secondary_dex_file(const std::string& dex_path, const std::string& pkgname, int uid,
2291 const std::unique_ptr<std::string>& volume_uuid, int storage_flag,
2292 std::vector<uint8_t>* out_secondary_dex_hash) {
2293 out_secondary_dex_hash->clear();
2294
2295 const char* volume_uuid_cstr = volume_uuid == nullptr ? nullptr : volume_uuid->c_str();
2296
2297 if (storage_flag != FLAG_STORAGE_CE && storage_flag != FLAG_STORAGE_DE) {
2298 LOG(ERROR) << "hash_secondary_dex_file called with invalid storage_flag: "
2299 << storage_flag;
2300 return false;
2301 }
2302
2303 // Pipe to get the hash result back from our child process.
2304 unique_fd pipe_read, pipe_write;
2305 if (!Pipe(&pipe_read, &pipe_write)) {
2306 PLOG(ERROR) << "Failed to create pipe";
2307 return false;
2308 }
2309
2310 // Fork so that actual access to the files is done in the app's own UID, to ensure we only
2311 // access data the app itself can access.
2312 pid_t pid = fork();
2313 if (pid == 0) {
2314 // child -- drop privileges before continuing
2315 drop_capabilities(uid);
2316 pipe_read.reset();
2317
2318 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid_cstr, uid, storage_flag)) {
2319 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002320 _exit(DexoptReturnCodes::kHashValidatePath);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002321 }
2322
2323 unique_fd fd(TEMP_FAILURE_RETRY(open(dex_path.c_str(), O_RDONLY | O_CLOEXEC | O_NOFOLLOW)));
2324 if (fd == -1) {
2325 if (errno == EACCES || errno == ENOENT) {
2326 // Not treated as an error.
2327 _exit(0);
2328 }
2329 PLOG(ERROR) << "Failed to open secondary dex " << dex_path;
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002330 _exit(DexoptReturnCodes::kHashOpenPath);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002331 }
2332
2333 SHA256_CTX ctx;
2334 SHA256_Init(&ctx);
2335
2336 std::vector<uint8_t> buffer(65536);
2337 while (true) {
2338 ssize_t bytes_read = TEMP_FAILURE_RETRY(read(fd, buffer.data(), buffer.size()));
2339 if (bytes_read == 0) {
2340 break;
2341 } else if (bytes_read == -1) {
2342 PLOG(ERROR) << "Failed to read secondary dex " << dex_path;
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002343 _exit(DexoptReturnCodes::kHashReadDex);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002344 }
2345
2346 SHA256_Update(&ctx, buffer.data(), bytes_read);
2347 }
2348
2349 std::array<uint8_t, SHA256_DIGEST_LENGTH> hash;
2350 SHA256_Final(hash.data(), &ctx);
2351 if (!WriteFully(pipe_write, hash.data(), hash.size())) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002352 _exit(DexoptReturnCodes::kHashWrite);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002353 }
2354
2355 _exit(0);
2356 }
2357
2358 // parent
2359 pipe_write.reset();
2360
2361 out_secondary_dex_hash->resize(SHA256_DIGEST_LENGTH);
2362 if (!ReadFully(pipe_read, out_secondary_dex_hash->data(), out_secondary_dex_hash->size())) {
2363 out_secondary_dex_hash->clear();
2364 }
2365 return wait_child(pid) == 0;
2366}
2367
Jeff Sharkey90aff262016-12-12 14:28:24 -07002368// Helper for move_ab, so that we can have common failure-case cleanup.
2369static bool unlink_and_rename(const char* from, const char* to) {
2370 // Check whether "from" exists, and if so whether it's regular. If it is, unlink. Otherwise,
2371 // return a failure.
2372 struct stat s;
2373 if (stat(to, &s) == 0) {
2374 if (!S_ISREG(s.st_mode)) {
2375 LOG(ERROR) << from << " is not a regular file to replace for A/B.";
2376 return false;
2377 }
2378 if (unlink(to) != 0) {
2379 LOG(ERROR) << "Could not unlink " << to << " to move A/B.";
2380 return false;
2381 }
2382 } else {
2383 // This may be a permission problem. We could investigate the error code, but we'll just
2384 // let the rename failure do the work for us.
2385 }
2386
2387 // Try to rename "to" to "from."
2388 if (rename(from, to) != 0) {
2389 PLOG(ERROR) << "Could not rename " << from << " to " << to;
2390 return false;
2391 }
2392 return true;
2393}
2394
2395// Move/rename a B artifact (from) to an A artifact (to).
2396static bool move_ab_path(const std::string& b_path, const std::string& a_path) {
2397 // Check whether B exists.
2398 {
2399 struct stat s;
2400 if (stat(b_path.c_str(), &s) != 0) {
2401 // Silently ignore for now. The service calling this isn't smart enough to understand
2402 // lack of artifacts at the moment.
2403 return false;
2404 }
2405 if (!S_ISREG(s.st_mode)) {
2406 LOG(ERROR) << "A/B artifact " << b_path << " is not a regular file.";
2407 // Try to unlink, but swallow errors.
2408 unlink(b_path.c_str());
2409 return false;
2410 }
2411 }
2412
2413 // Rename B to A.
2414 if (!unlink_and_rename(b_path.c_str(), a_path.c_str())) {
2415 // Delete the b_path so we don't try again (or fail earlier).
2416 if (unlink(b_path.c_str()) != 0) {
2417 PLOG(ERROR) << "Could not unlink " << b_path;
2418 }
2419
2420 return false;
2421 }
2422
2423 return true;
2424}
2425
2426bool move_ab(const char* apk_path, const char* instruction_set, const char* oat_dir) {
2427 // Get the current slot suffix. No suffix, no A/B.
2428 std::string slot_suffix;
2429 {
2430 char buf[kPropertyValueMax];
2431 if (get_property("ro.boot.slot_suffix", buf, nullptr) <= 0) {
2432 return false;
2433 }
2434 slot_suffix = buf;
2435
2436 if (!ValidateTargetSlotSuffix(slot_suffix)) {
2437 LOG(ERROR) << "Target slot suffix not legal: " << slot_suffix;
2438 return false;
2439 }
2440 }
2441
2442 // Validate other inputs.
2443 if (validate_apk_path(apk_path) != 0) {
2444 LOG(ERROR) << "Invalid apk_path: " << apk_path;
2445 return false;
2446 }
2447 if (validate_apk_path(oat_dir) != 0) {
2448 LOG(ERROR) << "Invalid oat_dir: " << oat_dir;
2449 return false;
2450 }
2451
2452 char a_path[PKG_PATH_MAX];
2453 if (!calculate_oat_file_path(a_path, oat_dir, apk_path, instruction_set)) {
2454 return false;
2455 }
2456 const std::string a_vdex_path = create_vdex_filename(a_path);
2457 const std::string a_image_path = create_image_filename(a_path);
2458
2459 // B path = A path + slot suffix.
2460 const std::string b_path = StringPrintf("%s.%s", a_path, slot_suffix.c_str());
2461 const std::string b_vdex_path = StringPrintf("%s.%s", a_vdex_path.c_str(), slot_suffix.c_str());
2462 const std::string b_image_path = StringPrintf("%s.%s",
2463 a_image_path.c_str(),
2464 slot_suffix.c_str());
2465
2466 bool success = true;
2467 if (move_ab_path(b_path, a_path)) {
2468 if (move_ab_path(b_vdex_path, a_vdex_path)) {
2469 // Note: we can live without an app image. As such, ignore failure to move the image file.
2470 // If we decide to require the app image, or the app image being moved correctly,
2471 // then change accordingly.
2472 constexpr bool kIgnoreAppImageFailure = true;
2473
2474 if (!a_image_path.empty()) {
2475 if (!move_ab_path(b_image_path, a_image_path)) {
2476 unlink(a_image_path.c_str());
2477 if (!kIgnoreAppImageFailure) {
2478 success = false;
2479 }
2480 }
2481 }
2482 } else {
2483 // Cleanup: delete B image, ignore errors.
2484 unlink(b_image_path.c_str());
2485 success = false;
2486 }
2487 } else {
2488 // Cleanup: delete B image, ignore errors.
2489 unlink(b_vdex_path.c_str());
2490 unlink(b_image_path.c_str());
2491 success = false;
2492 }
2493 return success;
2494}
2495
2496bool delete_odex(const char* apk_path, const char* instruction_set, const char* oat_dir) {
2497 // Delete the oat/odex file.
2498 char out_path[PKG_PATH_MAX];
Calin Juravle80a21252017-01-17 14:43:25 -08002499 if (!create_oat_out_path(apk_path, instruction_set, oat_dir,
Calin Juravle114f0812017-03-08 19:05:07 -08002500 /*is_secondary_dex*/false, out_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07002501 return false;
2502 }
2503
2504 // In case of a permission failure report the issue. Otherwise just print a warning.
2505 auto unlink_and_check = [](const char* path) -> bool {
2506 int result = unlink(path);
2507 if (result != 0) {
2508 if (errno == EACCES || errno == EPERM) {
2509 PLOG(ERROR) << "Could not unlink " << path;
2510 return false;
2511 }
2512 PLOG(WARNING) << "Could not unlink " << path;
2513 }
2514 return true;
2515 };
2516
2517 // Delete the oat/odex file.
2518 bool return_value_oat = unlink_and_check(out_path);
2519
2520 // Derive and delete the app image.
2521 bool return_value_art = unlink_and_check(create_image_filename(out_path).c_str());
2522
Nicolas Geoffray192fb962017-05-25 13:58:06 +01002523 // Derive and delete the vdex file.
2524 bool return_value_vdex = unlink_and_check(create_vdex_filename(out_path).c_str());
2525
Jeff Sharkey90aff262016-12-12 14:28:24 -07002526 // Report success.
Nicolas Geoffray192fb962017-05-25 13:58:06 +01002527 return return_value_oat && return_value_art && return_value_vdex;
Jeff Sharkey90aff262016-12-12 14:28:24 -07002528}
2529
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06002530static bool is_absolute_path(const std::string& path) {
2531 if (path.find('/') != 0 || path.find("..") != std::string::npos) {
2532 LOG(ERROR) << "Invalid absolute path " << path;
2533 return false;
2534 } else {
2535 return true;
2536 }
2537}
2538
2539static bool is_valid_instruction_set(const std::string& instruction_set) {
2540 // TODO: add explicit whitelisting of instruction sets
2541 if (instruction_set.find('/') != std::string::npos) {
2542 LOG(ERROR) << "Invalid instruction set " << instruction_set;
2543 return false;
2544 } else {
2545 return true;
2546 }
2547}
2548
2549bool calculate_oat_file_path_default(char path[PKG_PATH_MAX], const char *oat_dir,
2550 const char *apk_path, const char *instruction_set) {
2551 std::string oat_dir_ = oat_dir;
2552 std::string apk_path_ = apk_path;
2553 std::string instruction_set_ = instruction_set;
2554
2555 if (!is_absolute_path(oat_dir_)) return false;
2556 if (!is_absolute_path(apk_path_)) return false;
2557 if (!is_valid_instruction_set(instruction_set_)) return false;
2558
2559 std::string::size_type end = apk_path_.rfind('.');
2560 std::string::size_type start = apk_path_.rfind('/', end);
2561 if (end == std::string::npos || start == std::string::npos) {
2562 LOG(ERROR) << "Invalid apk_path " << apk_path_;
2563 return false;
2564 }
2565
2566 std::string res_ = oat_dir_ + '/' + instruction_set + '/'
2567 + apk_path_.substr(start + 1, end - start - 1) + ".odex";
2568 const char* res = res_.c_str();
2569 if (strlen(res) >= PKG_PATH_MAX) {
2570 LOG(ERROR) << "Result too large";
2571 return false;
2572 } else {
2573 strlcpy(path, res, PKG_PATH_MAX);
2574 return true;
2575 }
2576}
2577
2578bool calculate_odex_file_path_default(char path[PKG_PATH_MAX], const char *apk_path,
2579 const char *instruction_set) {
2580 std::string apk_path_ = apk_path;
2581 std::string instruction_set_ = instruction_set;
2582
2583 if (!is_absolute_path(apk_path_)) return false;
2584 if (!is_valid_instruction_set(instruction_set_)) return false;
2585
2586 std::string::size_type end = apk_path_.rfind('.');
2587 std::string::size_type start = apk_path_.rfind('/', end);
2588 if (end == std::string::npos || start == std::string::npos) {
2589 LOG(ERROR) << "Invalid apk_path " << apk_path_;
2590 return false;
2591 }
2592
2593 std::string oat_dir = apk_path_.substr(0, start + 1) + "oat";
2594 return calculate_oat_file_path_default(path, oat_dir.c_str(), apk_path, instruction_set);
2595}
2596
2597bool create_cache_path_default(char path[PKG_PATH_MAX], const char *src,
2598 const char *instruction_set) {
2599 std::string src_ = src;
2600 std::string instruction_set_ = instruction_set;
2601
2602 if (!is_absolute_path(src_)) return false;
2603 if (!is_valid_instruction_set(instruction_set_)) return false;
2604
2605 for (auto it = src_.begin() + 1; it < src_.end(); ++it) {
2606 if (*it == '/') {
2607 *it = '@';
2608 }
2609 }
2610
2611 std::string res_ = android_data_dir + DALVIK_CACHE + '/' + instruction_set_ + src_
2612 + DALVIK_CACHE_POSTFIX;
2613 const char* res = res_.c_str();
2614 if (strlen(res) >= PKG_PATH_MAX) {
2615 LOG(ERROR) << "Result too large";
2616 return false;
2617 } else {
2618 strlcpy(path, res, PKG_PATH_MAX);
2619 return true;
2620 }
2621}
2622
Calin Juravle59f7ab82018-04-27 17:50:23 -07002623bool open_classpath_files(const std::string& classpath, std::vector<unique_fd>* apk_fds,
2624 std::vector<std::string>* dex_locations) {
Calin Juravle0d0a4922018-01-23 19:54:11 -08002625 std::vector<std::string> classpaths_elems = base::Split(classpath, ":");
2626 for (const std::string& elem : classpaths_elems) {
2627 unique_fd fd(TEMP_FAILURE_RETRY(open(elem.c_str(), O_RDONLY)));
2628 if (fd < 0) {
2629 PLOG(ERROR) << "Could not open classpath elem " << elem;
2630 return false;
2631 } else {
2632 apk_fds->push_back(std::move(fd));
Calin Juravle59f7ab82018-04-27 17:50:23 -07002633 dex_locations->push_back(elem);
Calin Juravle0d0a4922018-01-23 19:54:11 -08002634 }
2635 }
2636 return true;
2637}
2638
2639static bool create_app_profile_snapshot(int32_t app_id,
2640 const std::string& package_name,
2641 const std::string& profile_name,
2642 const std::string& classpath) {
Calin Juravle29591732017-11-20 17:46:19 -08002643 int app_shared_gid = multiuser_get_shared_gid(/*user_id*/ 0, app_id);
2644
Calin Juravle824a64d2018-01-18 20:23:17 -08002645 unique_fd snapshot_fd = open_spnashot_profile(AID_SYSTEM, package_name, profile_name);
Calin Juravle29591732017-11-20 17:46:19 -08002646 if (snapshot_fd < 0) {
2647 return false;
2648 }
2649
2650 std::vector<unique_fd> profiles_fd;
2651 unique_fd reference_profile_fd;
Calin Juravle824a64d2018-01-18 20:23:17 -08002652 open_profile_files(app_shared_gid, package_name, profile_name, /*is_secondary_dex*/ false,
2653 &profiles_fd, &reference_profile_fd);
Calin Juravle29591732017-11-20 17:46:19 -08002654 if (profiles_fd.empty() || (reference_profile_fd.get() < 0)) {
2655 return false;
2656 }
2657
2658 profiles_fd.push_back(std::move(reference_profile_fd));
2659
Calin Juravle0d0a4922018-01-23 19:54:11 -08002660 // Open the class paths elements. These will be used to filter out profile data that does
2661 // not belong to the classpath during merge.
2662 std::vector<unique_fd> apk_fds;
Calin Juravle59f7ab82018-04-27 17:50:23 -07002663 std::vector<std::string> dex_locations;
2664 if (!open_classpath_files(classpath, &apk_fds, &dex_locations)) {
Calin Juravle0d0a4922018-01-23 19:54:11 -08002665 return false;
2666 }
2667
Calin Juravle29591732017-11-20 17:46:19 -08002668 pid_t pid = fork();
2669 if (pid == 0) {
2670 /* child -- drop privileges before continuing */
2671 drop_capabilities(app_shared_gid);
Calin Juravle59f7ab82018-04-27 17:50:23 -07002672 run_profman_merge(profiles_fd, snapshot_fd, &apk_fds, &dex_locations);
Calin Juravle29591732017-11-20 17:46:19 -08002673 }
2674
2675 /* parent */
2676 int return_code = wait_child(pid);
2677 if (!WIFEXITED(return_code)) {
Calin Juravle824a64d2018-01-18 20:23:17 -08002678 LOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
Calin Juravle29591732017-11-20 17:46:19 -08002679 return false;
2680 }
2681
2682 return true;
2683}
2684
Calin Juravle0d0a4922018-01-23 19:54:11 -08002685static bool create_boot_image_profile_snapshot(const std::string& package_name,
2686 const std::string& profile_name,
2687 const std::string& classpath) {
2688 // The reference profile directory for the android package might not be prepared. Do it now.
2689 const std::string ref_profile_dir =
2690 create_primary_reference_profile_package_dir_path(package_name);
2691 if (fs_prepare_dir(ref_profile_dir.c_str(), 0770, AID_SYSTEM, AID_SYSTEM) != 0) {
2692 PLOG(ERROR) << "Failed to prepare " << ref_profile_dir;
2693 return false;
2694 }
2695
Mathieu Chartiere0d64a12018-11-01 12:07:26 -07002696 // Return false for empty class path since it may otherwise return true below if profiles is
2697 // empty.
2698 if (classpath.empty()) {
2699 PLOG(ERROR) << "Class path is empty";
2700 return false;
2701 }
2702
Calin Juravle0d0a4922018-01-23 19:54:11 -08002703 // Open and create the snapshot profile.
2704 unique_fd snapshot_fd = open_spnashot_profile(AID_SYSTEM, package_name, profile_name);
2705
2706 // Collect all non empty profiles.
2707 // The collection will traverse all applications profiles and find the non empty files.
2708 // This has the potential of inspecting a large number of files and directories (depending
2709 // on the number of applications and users). So there is a slight increase in the chance
2710 // to get get occasionally I/O errors (e.g. for opening the file). When that happens do not
2711 // fail the snapshot and aggregate whatever profile we could open.
2712 //
2713 // The profile snapshot is a best effort based on available data it's ok if some data
2714 // from some apps is missing. It will be counter productive for the snapshot to fail
2715 // because we could not open or read some of the files.
2716 std::vector<std::string> profiles;
2717 if (!collect_profiles(&profiles)) {
2718 LOG(WARNING) << "There were errors while collecting the profiles for the boot image.";
2719 }
2720
2721 // If we have no profiles return early.
2722 if (profiles.empty()) {
2723 return true;
2724 }
2725
2726 // Open the classpath elements. These will be used to filter out profile data that does
2727 // not belong to the classpath during merge.
2728 std::vector<unique_fd> apk_fds;
Calin Juravle59f7ab82018-04-27 17:50:23 -07002729 std::vector<std::string> dex_locations;
2730 if (!open_classpath_files(classpath, &apk_fds, &dex_locations)) {
Calin Juravle0d0a4922018-01-23 19:54:11 -08002731 return false;
2732 }
2733
2734 // If we could not open any files from the classpath return an error.
2735 if (apk_fds.empty()) {
2736 LOG(ERROR) << "Could not open any of the classpath elements.";
2737 return false;
2738 }
2739
2740 // Aggregate the profiles in batches of kAggregationBatchSize.
2741 // We do this to avoid opening a huge a amount of files.
2742 static constexpr size_t kAggregationBatchSize = 10;
2743
2744 std::vector<unique_fd> profiles_fd;
2745 for (size_t i = 0; i < profiles.size(); ) {
2746 for (size_t k = 0; k < kAggregationBatchSize && i < profiles.size(); k++, i++) {
2747 unique_fd fd = open_profile(AID_SYSTEM, profiles[i], O_RDONLY);
2748 if (fd.get() >= 0) {
2749 profiles_fd.push_back(std::move(fd));
2750 }
2751 }
2752 pid_t pid = fork();
2753 if (pid == 0) {
2754 /* child -- drop privileges before continuing */
2755 drop_capabilities(AID_SYSTEM);
2756
Calin Juravle59f7ab82018-04-27 17:50:23 -07002757 // The introduction of new access flags into boot jars causes them to
2758 // fail dex file verification.
2759 run_profman_merge(profiles_fd, snapshot_fd, &apk_fds, &dex_locations);
Calin Juravle0d0a4922018-01-23 19:54:11 -08002760 }
2761
2762 /* parent */
2763 int return_code = wait_child(pid);
2764 if (!WIFEXITED(return_code)) {
2765 PLOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
2766 return false;
2767 }
2768 return true;
2769 }
2770 return true;
2771}
2772
2773bool create_profile_snapshot(int32_t app_id, const std::string& package_name,
2774 const std::string& profile_name, const std::string& classpath) {
2775 if (app_id == -1) {
2776 return create_boot_image_profile_snapshot(package_name, profile_name, classpath);
2777 } else {
2778 return create_app_profile_snapshot(app_id, package_name, profile_name, classpath);
2779 }
2780}
2781
Calin Juravlec3b049e2018-01-18 22:32:58 -08002782bool prepare_app_profile(const std::string& package_name,
2783 userid_t user_id,
2784 appid_t app_id,
2785 const std::string& profile_name,
Calin Juravlef63d4792018-01-30 17:43:34 +00002786 const std::string& code_path,
Calin Juravlec3b049e2018-01-18 22:32:58 -08002787 const std::unique_ptr<std::string>& dex_metadata) {
2788 // Prepare the current profile.
2789 std::string cur_profile = create_current_profile_path(user_id, package_name, profile_name,
2790 /*is_secondary_dex*/ false);
2791 uid_t uid = multiuser_get_uid(user_id, app_id);
2792 if (fs_prepare_file_strict(cur_profile.c_str(), 0600, uid, uid) != 0) {
2793 PLOG(ERROR) << "Failed to prepare " << cur_profile;
2794 return false;
2795 }
2796
2797 // Check if we need to install the profile from the dex metadata.
2798 if (dex_metadata == nullptr) {
2799 return true;
2800 }
2801
2802 // We have a dex metdata. Merge the profile into the reference profile.
2803 unique_fd ref_profile_fd = open_reference_profile(uid, package_name, profile_name,
2804 /*read_write*/ true, /*is_secondary_dex*/ false);
2805 unique_fd dex_metadata_fd(TEMP_FAILURE_RETRY(
2806 open(dex_metadata->c_str(), O_RDONLY | O_NOFOLLOW)));
Calin Juravlef63d4792018-01-30 17:43:34 +00002807 unique_fd apk_fd(TEMP_FAILURE_RETRY(open(code_path.c_str(), O_RDONLY | O_NOFOLLOW)));
2808 if (apk_fd < 0) {
2809 PLOG(ERROR) << "Could not open code path " << code_path;
2810 return false;
2811 }
Calin Juravlec3b049e2018-01-18 22:32:58 -08002812
2813 pid_t pid = fork();
2814 if (pid == 0) {
2815 /* child -- drop privileges before continuing */
2816 gid_t app_shared_gid = multiuser_get_shared_gid(user_id, app_id);
2817 drop_capabilities(app_shared_gid);
2818
Calin Juravlef63d4792018-01-30 17:43:34 +00002819 // The copy and update takes ownership over the fds.
2820 run_profman_copy_and_update(std::move(dex_metadata_fd),
2821 std::move(ref_profile_fd),
Calin Juravle59f7ab82018-04-27 17:50:23 -07002822 std::move(apk_fd),
2823 code_path);
Calin Juravlec3b049e2018-01-18 22:32:58 -08002824 }
2825
2826 /* parent */
2827 int return_code = wait_child(pid);
2828 if (!WIFEXITED(return_code)) {
2829 PLOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
2830 return false;
2831 }
2832 return true;
2833}
2834
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07002835} // namespace installd
2836} // namespace android