blob: 615c7cb9c51557688776c002bff95afc25054114 [file] [log] [blame]
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07001/*
2 * Copyright (C) 2016 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
Mark Salyzyna5e161b2016-09-29 08:08:05 -070016#define LOG_TAG "installed"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070017
Jeff Sharkey90aff262016-12-12 14:28:24 -070018#include <fcntl.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070019#include <stdlib.h>
20#include <string.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070021#include <sys/capability.h>
22#include <sys/file.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070023#include <sys/stat.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070024#include <sys/time.h>
25#include <sys/types.h>
26#include <sys/resource.h>
27#include <sys/wait.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070028#include <unistd.h>
29
30#include <android-base/logging.h>
Andreas Gampe6a9cf722017-07-24 16:49:10 -070031#include <android-base/properties.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070032#include <android-base/stringprintf.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070033#include <android-base/strings.h>
34#include <android-base/unique_fd.h>
Calin Juravle80a21252017-01-17 14:43:25 -080035#include <cutils/fs.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070036#include <cutils/properties.h>
37#include <cutils/sched_policy.h>
Mark Salyzyn7823e122016-09-29 08:08:05 -070038#include <log/log.h> // TODO: Move everything to base/logging.
Jeff Sharkey90aff262016-12-12 14:28:24 -070039#include <private/android_filesystem_config.h>
Calin Juravlecb556e32017-04-04 20:22:50 -070040#include <selinux/android.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070041#include <system/thread_defs.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070042
43#include "dexopt.h"
Jeff Sharkey90aff262016-12-12 14:28:24 -070044#include "installd_deps.h"
45#include "otapreopt_utils.h"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070046#include "utils.h"
47
48using android::base::StringPrintf;
Jeff Sharkey90aff262016-12-12 14:28:24 -070049using android::base::EndsWith;
Calin Juravle1a0af3b2017-03-09 14:33:33 -080050using android::base::unique_fd;
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070051
52namespace android {
53namespace installd {
54
Calin Juravle114f0812017-03-08 19:05:07 -080055// Deleter using free() for use with std::unique_ptr<>. See also UniqueCPtr<> below.
56struct FreeDelete {
57 // NOTE: Deleting a const object is valid but free() takes a non-const pointer.
58 void operator()(const void* ptr) const {
59 free(const_cast<void*>(ptr));
60 }
61};
62
63// Alias for std::unique_ptr<> that uses the C function free() to delete objects.
64template <typename T>
65using UniqueCPtr = std::unique_ptr<T, FreeDelete>;
66
Calin Juravle1a0af3b2017-03-09 14:33:33 -080067static unique_fd invalid_unique_fd() {
68 return unique_fd(-1);
69}
70
Andreas Gampe6a9cf722017-07-24 16:49:10 -070071static bool is_debug_runtime() {
72 return android::base::GetProperty("persist.sys.dalvik.vm.lib.2", "") == "libartd.so";
73}
74
Jeff Sharkey90aff262016-12-12 14:28:24 -070075static bool clear_profile(const std::string& profile) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -080076 unique_fd ufd(open(profile.c_str(), O_WRONLY | O_NOFOLLOW | O_CLOEXEC));
Jeff Sharkey90aff262016-12-12 14:28:24 -070077 if (ufd.get() < 0) {
78 if (errno != ENOENT) {
79 PLOG(WARNING) << "Could not open profile " << profile;
80 return false;
81 } else {
82 // Nothing to clear. That's ok.
83 return true;
84 }
85 }
86
87 if (flock(ufd.get(), LOCK_EX | LOCK_NB) != 0) {
88 if (errno != EWOULDBLOCK) {
89 PLOG(WARNING) << "Error locking profile " << profile;
90 }
91 // This implies that the app owning this profile is running
92 // (and has acquired the lock).
93 //
94 // If we can't acquire the lock bail out since clearing is useless anyway
95 // (the app will write again to the profile).
96 //
97 // Note:
98 // This does not impact the this is not an issue for the profiling correctness.
99 // In case this is needed because of an app upgrade, profiles will still be
100 // eventually cleared by the app itself due to checksum mismatch.
101 // If this is needed because profman advised, then keeping the data around
102 // until the next run is again not an issue.
103 //
104 // If the app attempts to acquire a lock while we've held one here,
105 // it will simply skip the current write cycle.
106 return false;
107 }
108
109 bool truncated = ftruncate(ufd.get(), 0) == 0;
110 if (!truncated) {
111 PLOG(WARNING) << "Could not truncate " << profile;
112 }
113 if (flock(ufd.get(), LOCK_UN) != 0) {
114 PLOG(WARNING) << "Error unlocking profile " << profile;
115 }
116 return truncated;
117}
118
Calin Juravle114f0812017-03-08 19:05:07 -0800119// Clear the reference profile for the given location.
120// The location is the package name for primary apks or the dex path for secondary dex files.
121static bool clear_reference_profile(const std::string& location, bool is_secondary_dex) {
122 return clear_profile(create_reference_profile_path(location, is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700123}
124
Calin Juravle114f0812017-03-08 19:05:07 -0800125// Clear the reference profile for the given location.
126// The location is the package name for primary apks or the dex path for secondary dex files.
127static bool clear_current_profile(const std::string& pkgname, userid_t user,
128 bool is_secondary_dex) {
129 return clear_profile(create_current_profile_path(user, pkgname, is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700130}
131
Calin Juravle114f0812017-03-08 19:05:07 -0800132// Clear the reference profile for the primary apk of the given package.
133bool clear_primary_reference_profile(const std::string& pkgname) {
134 return clear_reference_profile(pkgname, /*is_secondary_dex*/false);
135}
136
137// Clear all current profile for the primary apk of the given package.
138bool clear_primary_current_profiles(const std::string& pkgname) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700139 bool success = true;
Calin Juravle114f0812017-03-08 19:05:07 -0800140 // For secondary dex files, we don't really need the user but we use it for sanity checks.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700141 std::vector<userid_t> users = get_known_users(/*volume_uuid*/ nullptr);
142 for (auto user : users) {
Calin Juravle114f0812017-03-08 19:05:07 -0800143 success &= clear_current_profile(pkgname, user, /*is_secondary_dex*/false);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700144 }
145 return success;
146}
147
Calin Juravle114f0812017-03-08 19:05:07 -0800148// Clear the current profile for the primary apk of the given package and user.
149bool clear_primary_current_profile(const std::string& pkgname, userid_t user) {
150 return clear_current_profile(pkgname, user, /*is_secondary_dex*/false);
151}
152
Jeff Sharkey90aff262016-12-12 14:28:24 -0700153static int split_count(const char *str)
154{
155 char *ctx;
156 int count = 0;
157 char buf[kPropertyValueMax];
158
159 strncpy(buf, str, sizeof(buf));
160 char *pBuf = buf;
161
162 while(strtok_r(pBuf, " ", &ctx) != NULL) {
163 count++;
164 pBuf = NULL;
165 }
166
167 return count;
168}
169
170static int split(char *buf, const char **argv)
171{
172 char *ctx;
173 int count = 0;
174 char *tok;
175 char *pBuf = buf;
176
177 while((tok = strtok_r(pBuf, " ", &ctx)) != NULL) {
178 argv[count++] = tok;
179 pBuf = NULL;
180 }
181
182 return count;
183}
184
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700185static const char* get_location_from_path(const char* path) {
186 static constexpr char kLocationSeparator = '/';
187 const char *location = strrchr(path, kLocationSeparator);
188 if (location == NULL) {
189 return path;
190 } else {
191 // Skip the separator character.
192 return location + 1;
193 }
194}
195
Jeff Sharkey90aff262016-12-12 14:28:24 -0700196static void run_dex2oat(int zip_fd, int oat_fd, int input_vdex_fd, int output_vdex_fd, int image_fd,
197 const char* input_file_name, const char* output_file_name, int swap_fd,
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100198 const char* instruction_set, const char* compiler_filter,
Jeff Sharkey90aff262016-12-12 14:28:24 -0700199 bool debuggable, bool post_bootcomplete, int profile_fd, const char* shared_libraries) {
200 static const unsigned int MAX_INSTRUCTION_SET_LEN = 7;
201
202 if (strlen(instruction_set) >= MAX_INSTRUCTION_SET_LEN) {
203 ALOGE("Instruction set %s longer than max length of %d",
204 instruction_set, MAX_INSTRUCTION_SET_LEN);
205 return;
206 }
207
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700208 // Get the relative path to the input file.
209 const char* relative_input_file_name = get_location_from_path(input_file_name);
210
Jeff Sharkey90aff262016-12-12 14:28:24 -0700211 char dex2oat_Xms_flag[kPropertyValueMax];
212 bool have_dex2oat_Xms_flag = get_property("dalvik.vm.dex2oat-Xms", dex2oat_Xms_flag, NULL) > 0;
213
214 char dex2oat_Xmx_flag[kPropertyValueMax];
215 bool have_dex2oat_Xmx_flag = get_property("dalvik.vm.dex2oat-Xmx", dex2oat_Xmx_flag, NULL) > 0;
216
217 char dex2oat_threads_buf[kPropertyValueMax];
218 bool have_dex2oat_threads_flag = get_property(post_bootcomplete
219 ? "dalvik.vm.dex2oat-threads"
220 : "dalvik.vm.boot-dex2oat-threads",
221 dex2oat_threads_buf,
222 NULL) > 0;
223 char dex2oat_threads_arg[kPropertyValueMax + 2];
224 if (have_dex2oat_threads_flag) {
225 sprintf(dex2oat_threads_arg, "-j%s", dex2oat_threads_buf);
226 }
227
228 char dex2oat_isa_features_key[kPropertyKeyMax];
229 sprintf(dex2oat_isa_features_key, "dalvik.vm.isa.%s.features", instruction_set);
230 char dex2oat_isa_features[kPropertyValueMax];
231 bool have_dex2oat_isa_features = get_property(dex2oat_isa_features_key,
232 dex2oat_isa_features, NULL) > 0;
233
234 char dex2oat_isa_variant_key[kPropertyKeyMax];
235 sprintf(dex2oat_isa_variant_key, "dalvik.vm.isa.%s.variant", instruction_set);
236 char dex2oat_isa_variant[kPropertyValueMax];
237 bool have_dex2oat_isa_variant = get_property(dex2oat_isa_variant_key,
238 dex2oat_isa_variant, NULL) > 0;
239
240 const char *dex2oat_norelocation = "-Xnorelocate";
241 bool have_dex2oat_relocation_skip_flag = false;
242
243 char dex2oat_flags[kPropertyValueMax];
244 int dex2oat_flags_count = get_property("dalvik.vm.dex2oat-flags",
245 dex2oat_flags, NULL) <= 0 ? 0 : split_count(dex2oat_flags);
246 ALOGV("dalvik.vm.dex2oat-flags=%s\n", dex2oat_flags);
247
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100248 // If we are booting without the real /data, don't spend time compiling.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700249 char vold_decrypt[kPropertyValueMax];
250 bool have_vold_decrypt = get_property("vold.decrypt", vold_decrypt, "") > 0;
251 bool skip_compilation = (have_vold_decrypt &&
252 (strcmp(vold_decrypt, "trigger_restart_min_framework") == 0 ||
253 (strcmp(vold_decrypt, "1") == 0)));
254
255 bool generate_debug_info = property_get_bool("debug.generate-debug-info", false);
256
257 char app_image_format[kPropertyValueMax];
258 char image_format_arg[strlen("--image-format=") + kPropertyValueMax];
259 bool have_app_image_format =
260 image_fd >= 0 && get_property("dalvik.vm.appimageformat", app_image_format, NULL) > 0;
261 if (have_app_image_format) {
262 sprintf(image_format_arg, "--image-format=%s", app_image_format);
263 }
264
265 char dex2oat_large_app_threshold[kPropertyValueMax];
266 bool have_dex2oat_large_app_threshold =
267 get_property("dalvik.vm.dex2oat-very-large", dex2oat_large_app_threshold, NULL) > 0;
268 char dex2oat_large_app_threshold_arg[strlen("--very-large-app-threshold=") + kPropertyValueMax];
269 if (have_dex2oat_large_app_threshold) {
270 sprintf(dex2oat_large_app_threshold_arg,
271 "--very-large-app-threshold=%s",
272 dex2oat_large_app_threshold);
273 }
274
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700275 // If the runtime was requested to use libartd.so, we'll run dex2oatd, otherwise dex2oat.
276 const char* dex2oat_bin = is_debug_runtime() ? "/system/bin/dex2oatd" : "/system/bin/dex2oat";
Jeff Sharkey90aff262016-12-12 14:28:24 -0700277
278 static const char* RUNTIME_ARG = "--runtime-arg";
279
280 static const int MAX_INT_LEN = 12; // '-'+10dig+'\0' -OR- 0x+8dig
281
George Burgess IV36cebe772017-01-25 11:52:01 -0800282 // clang FORTIFY doesn't let us use strlen in constant array bounds, so we
283 // use arraysize instead.
284 char zip_fd_arg[arraysize("--zip-fd=") + MAX_INT_LEN];
285 char zip_location_arg[arraysize("--zip-location=") + PKG_PATH_MAX];
286 char input_vdex_fd_arg[arraysize("--input-vdex-fd=") + MAX_INT_LEN];
287 char output_vdex_fd_arg[arraysize("--output-vdex-fd=") + MAX_INT_LEN];
288 char oat_fd_arg[arraysize("--oat-fd=") + MAX_INT_LEN];
289 char oat_location_arg[arraysize("--oat-location=") + PKG_PATH_MAX];
290 char instruction_set_arg[arraysize("--instruction-set=") + MAX_INSTRUCTION_SET_LEN];
291 char instruction_set_variant_arg[arraysize("--instruction-set-variant=") + kPropertyValueMax];
292 char instruction_set_features_arg[arraysize("--instruction-set-features=") + kPropertyValueMax];
293 char dex2oat_Xms_arg[arraysize("-Xms") + kPropertyValueMax];
294 char dex2oat_Xmx_arg[arraysize("-Xmx") + kPropertyValueMax];
295 char dex2oat_compiler_filter_arg[arraysize("--compiler-filter=") + kPropertyValueMax];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700296 bool have_dex2oat_swap_fd = false;
George Burgess IV36cebe772017-01-25 11:52:01 -0800297 char dex2oat_swap_fd[arraysize("--swap-fd=") + MAX_INT_LEN];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700298 bool have_dex2oat_image_fd = false;
George Burgess IV36cebe772017-01-25 11:52:01 -0800299 char dex2oat_image_fd[arraysize("--app-image-fd=") + MAX_INT_LEN];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700300
301 sprintf(zip_fd_arg, "--zip-fd=%d", zip_fd);
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700302 sprintf(zip_location_arg, "--zip-location=%s", relative_input_file_name);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700303 sprintf(input_vdex_fd_arg, "--input-vdex-fd=%d", input_vdex_fd);
304 sprintf(output_vdex_fd_arg, "--output-vdex-fd=%d", output_vdex_fd);
305 sprintf(oat_fd_arg, "--oat-fd=%d", oat_fd);
306 sprintf(oat_location_arg, "--oat-location=%s", output_file_name);
307 sprintf(instruction_set_arg, "--instruction-set=%s", instruction_set);
308 sprintf(instruction_set_variant_arg, "--instruction-set-variant=%s", dex2oat_isa_variant);
309 sprintf(instruction_set_features_arg, "--instruction-set-features=%s", dex2oat_isa_features);
310 if (swap_fd >= 0) {
311 have_dex2oat_swap_fd = true;
312 sprintf(dex2oat_swap_fd, "--swap-fd=%d", swap_fd);
313 }
314 if (image_fd >= 0) {
315 have_dex2oat_image_fd = true;
316 sprintf(dex2oat_image_fd, "--app-image-fd=%d", image_fd);
317 }
318
319 if (have_dex2oat_Xms_flag) {
320 sprintf(dex2oat_Xms_arg, "-Xms%s", dex2oat_Xms_flag);
321 }
322 if (have_dex2oat_Xmx_flag) {
323 sprintf(dex2oat_Xmx_arg, "-Xmx%s", dex2oat_Xmx_flag);
324 }
325
326 // Compute compiler filter.
327
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100328 bool have_dex2oat_compiler_filter_flag = false;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700329 if (skip_compilation) {
Nicolas Geoffray4b64ed92017-04-25 12:28:28 +0100330 strcpy(dex2oat_compiler_filter_arg, "--compiler-filter=extract");
Jeff Sharkey90aff262016-12-12 14:28:24 -0700331 have_dex2oat_compiler_filter_flag = true;
332 have_dex2oat_relocation_skip_flag = true;
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100333 } else if (compiler_filter != nullptr) {
334 if (strlen(compiler_filter) + strlen("--compiler-filter=") <
Jeff Sharkey90aff262016-12-12 14:28:24 -0700335 arraysize(dex2oat_compiler_filter_arg)) {
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100336 sprintf(dex2oat_compiler_filter_arg, "--compiler-filter=%s", compiler_filter);
337 have_dex2oat_compiler_filter_flag = true;
338 } else {
339 ALOGW("Compiler filter name '%s' is too large (max characters is %zu)",
340 compiler_filter,
341 kPropertyValueMax);
342 }
343 }
344
345 if (!have_dex2oat_compiler_filter_flag) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700346 char dex2oat_compiler_filter_flag[kPropertyValueMax];
347 have_dex2oat_compiler_filter_flag = get_property("dalvik.vm.dex2oat-filter",
348 dex2oat_compiler_filter_flag, NULL) > 0;
349 if (have_dex2oat_compiler_filter_flag) {
350 sprintf(dex2oat_compiler_filter_arg,
351 "--compiler-filter=%s",
352 dex2oat_compiler_filter_flag);
353 }
354 }
355
356 // Check whether all apps should be compiled debuggable.
357 if (!debuggable) {
358 char prop_buf[kPropertyValueMax];
359 debuggable =
360 (get_property("dalvik.vm.always_debuggable", prop_buf, "0") > 0) &&
361 (prop_buf[0] == '1');
362 }
363 char profile_arg[strlen("--profile-file-fd=") + MAX_INT_LEN];
364 if (profile_fd != -1) {
365 sprintf(profile_arg, "--profile-file-fd=%d", profile_fd);
366 }
367
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700368 // Get the directory of the apk to pass as a base classpath directory.
369 char base_dir[arraysize("--classpath-dir=") + PKG_PATH_MAX];
370 std::string apk_dir(input_file_name);
371 unsigned long dir_index = apk_dir.rfind('/');
372 bool has_base_dir = dir_index != std::string::npos;
373 if (has_base_dir) {
374 apk_dir = apk_dir.substr(0, dir_index);
375 sprintf(base_dir, "--classpath-dir=%s", apk_dir.c_str());
376 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700377
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700378
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700379 ALOGV("Running %s in=%s out=%s\n", dex2oat_bin, relative_input_file_name, output_file_name);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700380
381 const char* argv[9 // program name, mandatory arguments and the final NULL
382 + (have_dex2oat_isa_variant ? 1 : 0)
383 + (have_dex2oat_isa_features ? 1 : 0)
384 + (have_dex2oat_Xms_flag ? 2 : 0)
385 + (have_dex2oat_Xmx_flag ? 2 : 0)
386 + (have_dex2oat_compiler_filter_flag ? 1 : 0)
387 + (have_dex2oat_threads_flag ? 1 : 0)
388 + (have_dex2oat_swap_fd ? 1 : 0)
389 + (have_dex2oat_image_fd ? 1 : 0)
390 + (have_dex2oat_relocation_skip_flag ? 2 : 0)
391 + (generate_debug_info ? 1 : 0)
392 + (debuggable ? 1 : 0)
393 + (have_app_image_format ? 1 : 0)
394 + dex2oat_flags_count
395 + (profile_fd == -1 ? 0 : 1)
396 + (shared_libraries != nullptr ? 4 : 0)
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700397 + (has_base_dir ? 1 : 0)
Jeff Sharkey90aff262016-12-12 14:28:24 -0700398 + (have_dex2oat_large_app_threshold ? 1 : 0)];
399 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700400 argv[i++] = dex2oat_bin;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700401 argv[i++] = zip_fd_arg;
402 argv[i++] = zip_location_arg;
403 argv[i++] = input_vdex_fd_arg;
404 argv[i++] = output_vdex_fd_arg;
405 argv[i++] = oat_fd_arg;
406 argv[i++] = oat_location_arg;
407 argv[i++] = instruction_set_arg;
408 if (have_dex2oat_isa_variant) {
409 argv[i++] = instruction_set_variant_arg;
410 }
411 if (have_dex2oat_isa_features) {
412 argv[i++] = instruction_set_features_arg;
413 }
414 if (have_dex2oat_Xms_flag) {
415 argv[i++] = RUNTIME_ARG;
416 argv[i++] = dex2oat_Xms_arg;
417 }
418 if (have_dex2oat_Xmx_flag) {
419 argv[i++] = RUNTIME_ARG;
420 argv[i++] = dex2oat_Xmx_arg;
421 }
422 if (have_dex2oat_compiler_filter_flag) {
423 argv[i++] = dex2oat_compiler_filter_arg;
424 }
425 if (have_dex2oat_threads_flag) {
426 argv[i++] = dex2oat_threads_arg;
427 }
428 if (have_dex2oat_swap_fd) {
429 argv[i++] = dex2oat_swap_fd;
430 }
431 if (have_dex2oat_image_fd) {
432 argv[i++] = dex2oat_image_fd;
433 }
434 if (generate_debug_info) {
435 argv[i++] = "--generate-debug-info";
436 }
437 if (debuggable) {
438 argv[i++] = "--debuggable";
439 }
440 if (have_app_image_format) {
441 argv[i++] = image_format_arg;
442 }
443 if (have_dex2oat_large_app_threshold) {
444 argv[i++] = dex2oat_large_app_threshold_arg;
445 }
446 if (dex2oat_flags_count) {
447 i += split(dex2oat_flags, argv + i);
448 }
449 if (have_dex2oat_relocation_skip_flag) {
450 argv[i++] = RUNTIME_ARG;
451 argv[i++] = dex2oat_norelocation;
452 }
453 if (profile_fd != -1) {
454 argv[i++] = profile_arg;
455 }
456 if (shared_libraries != nullptr) {
457 argv[i++] = RUNTIME_ARG;
458 argv[i++] = "-classpath";
459 argv[i++] = RUNTIME_ARG;
460 argv[i++] = shared_libraries;
461 }
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700462 if (has_base_dir) {
463 argv[i++] = base_dir;
464 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700465 // Do not add after dex2oat_flags, they should override others for debugging.
466 argv[i] = NULL;
467
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700468 execv(dex2oat_bin, (char * const *)argv);
469 ALOGE("execv(%s) failed: %s\n", dex2oat_bin, strerror(errno));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700470}
471
472/*
473 * Whether dexopt should use a swap file when compiling an APK.
474 *
475 * If kAlwaysProvideSwapFile, do this on all devices (dex2oat will make a more informed decision
476 * itself, anyways).
477 *
478 * Otherwise, read "dalvik.vm.dex2oat-swap". If the property exists, return whether it is "true".
479 *
480 * Otherwise, return true if this is a low-mem device.
481 *
482 * Otherwise, return default value.
483 */
484static bool kAlwaysProvideSwapFile = false;
485static bool kDefaultProvideSwapFile = true;
486
487static bool ShouldUseSwapFileForDexopt() {
488 if (kAlwaysProvideSwapFile) {
489 return true;
490 }
491
492 // Check the "override" property. If it exists, return value == "true".
493 char dex2oat_prop_buf[kPropertyValueMax];
494 if (get_property("dalvik.vm.dex2oat-swap", dex2oat_prop_buf, "") > 0) {
495 if (strcmp(dex2oat_prop_buf, "true") == 0) {
496 return true;
497 } else {
498 return false;
499 }
500 }
501
502 // Shortcut for default value. This is an implementation optimization for the process sketched
503 // above. If the default value is true, we can avoid to check whether this is a low-mem device,
504 // as low-mem is never returning false. The compiler will optimize this away if it can.
505 if (kDefaultProvideSwapFile) {
506 return true;
507 }
508
509 bool is_low_mem = property_get_bool("ro.config.low_ram", false);
510 if (is_low_mem) {
511 return true;
512 }
513
514 // Default value must be false here.
515 return kDefaultProvideSwapFile;
516}
517
Richard Uhler76cc0272016-12-08 10:46:35 +0000518static void SetDex2OatScheduling(bool set_to_bg) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700519 if (set_to_bg) {
520 if (set_sched_policy(0, SP_BACKGROUND) < 0) {
521 ALOGE("set_sched_policy failed: %s\n", strerror(errno));
522 exit(70);
523 }
524 if (setpriority(PRIO_PROCESS, 0, ANDROID_PRIORITY_BACKGROUND) < 0) {
525 ALOGE("setpriority failed: %s\n", strerror(errno));
526 exit(71);
527 }
528 }
529}
530
Calin Juravle114f0812017-03-08 19:05:07 -0800531static bool create_profile(int uid, const std::string& profile) {
532 unique_fd fd(TEMP_FAILURE_RETRY(open(profile.c_str(), O_CREAT | O_NOFOLLOW, 0600)));
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800533 if (fd.get() < 0) {
Calin Juravle114f0812017-03-08 19:05:07 -0800534 if (errno == EEXIST) {
535 return true;
536 } else {
537 PLOG(ERROR) << "Failed to create profile " << profile;
538 return false;
539 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700540 }
Calin Juravle114f0812017-03-08 19:05:07 -0800541 // Profiles should belong to the app; make sure of that by giving ownership to
542 // the app uid. If we cannot do that, there's no point in returning the fd
543 // since dex2oat/profman will fail with SElinux denials.
544 if (fchown(fd.get(), uid, uid) < 0) {
545 PLOG(ERROR) << "Could not chwon profile " << profile;
546 return false;
547 }
548 return true;
549}
550
551static unique_fd open_profile(int uid, const std::string& profile, bool read_write) {
552 // Check if we need to open the profile for a read-write operation. If so, we
553 // might need to create the profile since the file might not be there. Reference
554 // profiles are created on the fly so they might not exist beforehand.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700555 if (read_write) {
Calin Juravle114f0812017-03-08 19:05:07 -0800556 if (!create_profile(uid, profile)) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800557 return invalid_unique_fd();
Jeff Sharkey90aff262016-12-12 14:28:24 -0700558 }
559 }
Calin Juravle114f0812017-03-08 19:05:07 -0800560 int flags = read_write ? O_RDWR : O_RDONLY;
561 // Do not follow symlinks when opening a profile:
562 // - primary profiles should not contain symlinks in their paths
563 // - secondary dex paths should have been already resolved and validated
564 flags |= O_NOFOLLOW;
565
566 unique_fd fd(TEMP_FAILURE_RETRY(open(profile.c_str(), flags)));
567 if (fd.get() < 0) {
568 if (errno != ENOENT) {
569 // Profiles might be missing for various reasons. For example, in a
570 // multi-user environment, the profile directory for one user can be created
571 // after we start a merge. In this case the current profile for that user
572 // will not be found.
573 // Also, the secondary dex profiles might be deleted by the app at any time,
574 // so we can't we need to prepare if they are missing.
575 PLOG(ERROR) << "Failed to open profile " << profile;
576 }
577 return invalid_unique_fd();
578 }
579
Jeff Sharkey90aff262016-12-12 14:28:24 -0700580 return fd;
581}
582
Calin Juravle114f0812017-03-08 19:05:07 -0800583static unique_fd open_current_profile(uid_t uid, userid_t user, const std::string& location,
584 bool is_secondary_dex) {
585 std::string profile = create_current_profile_path(user, location, is_secondary_dex);
586 return open_profile(uid, profile, /*read_write*/false);
587}
588
589static unique_fd open_reference_profile(uid_t uid, const std::string& location, bool read_write,
590 bool is_secondary_dex) {
591 std::string profile = create_reference_profile_path(location, is_secondary_dex);
592 return open_profile(uid, profile, read_write);
593}
594
595static void open_profile_files(uid_t uid, const std::string& location, bool is_secondary_dex,
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800596 /*out*/ std::vector<unique_fd>* profiles_fd, /*out*/ unique_fd* reference_profile_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700597 // Open the reference profile in read-write mode as profman might need to save the merge.
Calin Juravle114f0812017-03-08 19:05:07 -0800598 *reference_profile_fd = open_reference_profile(uid, location, /*read_write*/ true,
599 is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700600
Calin Juravle114f0812017-03-08 19:05:07 -0800601 // For secondary dex files, we don't really need the user but we use it for sanity checks.
602 // Note: the user owning the dex file should be the current user.
603 std::vector<userid_t> users;
604 if (is_secondary_dex){
605 users.push_back(multiuser_get_user_id(uid));
606 } else {
607 users = get_known_users(/*volume_uuid*/ nullptr);
608 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700609 for (auto user : users) {
Calin Juravle114f0812017-03-08 19:05:07 -0800610 unique_fd profile_fd = open_current_profile(uid, user, location, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700611 // Add to the lists only if both fds are valid.
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800612 if (profile_fd.get() >= 0) {
613 profiles_fd->push_back(std::move(profile_fd));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700614 }
615 }
616}
617
618static void drop_capabilities(uid_t uid) {
619 if (setgid(uid) != 0) {
620 ALOGE("setgid(%d) failed in installd during dexopt\n", uid);
621 exit(64);
622 }
623 if (setuid(uid) != 0) {
624 ALOGE("setuid(%d) failed in installd during dexopt\n", uid);
625 exit(65);
626 }
627 // drop capabilities
628 struct __user_cap_header_struct capheader;
629 struct __user_cap_data_struct capdata[2];
630 memset(&capheader, 0, sizeof(capheader));
631 memset(&capdata, 0, sizeof(capdata));
632 capheader.version = _LINUX_CAPABILITY_VERSION_3;
633 if (capset(&capheader, &capdata[0]) < 0) {
634 ALOGE("capset failed: %s\n", strerror(errno));
635 exit(66);
636 }
637}
638
639static constexpr int PROFMAN_BIN_RETURN_CODE_COMPILE = 0;
640static constexpr int PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION = 1;
641static constexpr int PROFMAN_BIN_RETURN_CODE_BAD_PROFILES = 2;
642static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_IO = 3;
643static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING = 4;
644
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800645static void run_profman_merge(const std::vector<unique_fd>& profiles_fd,
646 const unique_fd& reference_profile_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700647 static const size_t MAX_INT_LEN = 32;
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700648 const char* profman_bin = is_debug_runtime() ? "/system/bin/profmand" : "/system/bin/profman";
Jeff Sharkey90aff262016-12-12 14:28:24 -0700649
650 std::vector<std::string> profile_args(profiles_fd.size());
651 char profile_buf[strlen("--profile-file-fd=") + MAX_INT_LEN];
652 for (size_t k = 0; k < profiles_fd.size(); k++) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800653 sprintf(profile_buf, "--profile-file-fd=%d", profiles_fd[k].get());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700654 profile_args[k].assign(profile_buf);
655 }
656 char reference_profile_arg[strlen("--reference-profile-file-fd=") + MAX_INT_LEN];
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800657 sprintf(reference_profile_arg, "--reference-profile-file-fd=%d", reference_profile_fd.get());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700658
659 // program name, reference profile fd, the final NULL and the profile fds
660 const char* argv[3 + profiles_fd.size()];
661 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700662 argv[i++] = profman_bin;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700663 argv[i++] = reference_profile_arg;
664 for (size_t k = 0; k < profile_args.size(); k++) {
665 argv[i++] = profile_args[k].c_str();
666 }
667 // Do not add after dex2oat_flags, they should override others for debugging.
668 argv[i] = NULL;
669
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700670 execv(profman_bin, (char * const *)argv);
671 ALOGE("execv(%s) failed: %s\n", profman_bin, strerror(errno));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700672 exit(68); /* only get here on exec failure */
673}
674
675// Decides if profile guided compilation is needed or not based on existing profiles.
Calin Juravle114f0812017-03-08 19:05:07 -0800676// The location is the package name for primary apks or the dex path for secondary dex files.
677// Returns true if there is enough information in the current profiles that makes it
678// worth to recompile the given location.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700679// If the return value is true all the current profiles would have been merged into
680// the reference profiles accessible with open_reference_profile().
Calin Juravle114f0812017-03-08 19:05:07 -0800681static bool analyze_profiles(uid_t uid, const std::string& location, bool is_secondary_dex) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800682 std::vector<unique_fd> profiles_fd;
683 unique_fd reference_profile_fd;
Calin Juravle114f0812017-03-08 19:05:07 -0800684 open_profile_files(uid, location, is_secondary_dex, &profiles_fd, &reference_profile_fd);
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800685 if (profiles_fd.empty() || (reference_profile_fd.get() < 0)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700686 // Skip profile guided compilation because no profiles were found.
687 // Or if the reference profile info couldn't be opened.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700688 return false;
689 }
690
Jeff Sharkey90aff262016-12-12 14:28:24 -0700691 pid_t pid = fork();
692 if (pid == 0) {
693 /* child -- drop privileges before continuing */
694 drop_capabilities(uid);
695 run_profman_merge(profiles_fd, reference_profile_fd);
696 exit(68); /* only get here on exec failure */
697 }
698 /* parent */
699 int return_code = wait_child(pid);
700 bool need_to_compile = false;
701 bool should_clear_current_profiles = false;
702 bool should_clear_reference_profile = false;
703 if (!WIFEXITED(return_code)) {
Calin Juravle114f0812017-03-08 19:05:07 -0800704 LOG(WARNING) << "profman failed for location " << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700705 } else {
706 return_code = WEXITSTATUS(return_code);
707 switch (return_code) {
708 case PROFMAN_BIN_RETURN_CODE_COMPILE:
709 need_to_compile = true;
710 should_clear_current_profiles = true;
711 should_clear_reference_profile = false;
712 break;
713 case PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION:
714 need_to_compile = false;
715 should_clear_current_profiles = false;
716 should_clear_reference_profile = false;
717 break;
718 case PROFMAN_BIN_RETURN_CODE_BAD_PROFILES:
Calin Juravle114f0812017-03-08 19:05:07 -0800719 LOG(WARNING) << "Bad profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700720 need_to_compile = false;
721 should_clear_current_profiles = true;
722 should_clear_reference_profile = true;
723 break;
724 case PROFMAN_BIN_RETURN_CODE_ERROR_IO: // fall-through
725 case PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING:
726 // Temporary IO problem (e.g. locking). Ignore but log a warning.
Calin Juravle114f0812017-03-08 19:05:07 -0800727 LOG(WARNING) << "IO error while reading profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700728 need_to_compile = false;
729 should_clear_current_profiles = false;
730 should_clear_reference_profile = false;
731 break;
732 default:
733 // Unknown return code or error. Unlink profiles.
Calin Juravle114f0812017-03-08 19:05:07 -0800734 LOG(WARNING) << "Unknown error code while processing profiles for location "
735 << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700736 need_to_compile = false;
737 should_clear_current_profiles = true;
738 should_clear_reference_profile = true;
739 break;
740 }
741 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800742
Jeff Sharkey90aff262016-12-12 14:28:24 -0700743 if (should_clear_current_profiles) {
Calin Juravle114f0812017-03-08 19:05:07 -0800744 if (is_secondary_dex) {
745 // For secondary dex files, the owning user is the current user.
746 clear_current_profile(location, multiuser_get_user_id(uid), is_secondary_dex);
747 } else {
748 clear_primary_current_profiles(location);
749 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700750 }
751 if (should_clear_reference_profile) {
Calin Juravle114f0812017-03-08 19:05:07 -0800752 clear_reference_profile(location, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700753 }
754 return need_to_compile;
755}
756
Calin Juravle114f0812017-03-08 19:05:07 -0800757// Decides if profile guided compilation is needed or not based on existing profiles.
758// The analysis is done for the primary apks of the given package.
759// Returns true if there is enough information in the current profiles that makes it
760// worth to recompile the package.
761// If the return value is true all the current profiles would have been merged into
762// the reference profiles accessible with open_reference_profile().
763bool analyze_primary_profiles(uid_t uid, const std::string& pkgname) {
764 return analyze_profiles(uid, pkgname, /*is_secondary_dex*/false);
765}
766
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800767static void run_profman_dump(const std::vector<unique_fd>& profile_fds,
768 const unique_fd& reference_profile_fd,
Jeff Sharkey90aff262016-12-12 14:28:24 -0700769 const std::vector<std::string>& dex_locations,
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800770 const std::vector<unique_fd>& apk_fds,
771 const unique_fd& output_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700772 std::vector<std::string> profman_args;
773 static const char* PROFMAN_BIN = "/system/bin/profman";
774 profman_args.push_back(PROFMAN_BIN);
775 profman_args.push_back("--dump-only");
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800776 profman_args.push_back(StringPrintf("--dump-output-to-fd=%d", output_fd.get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700777 if (reference_profile_fd != -1) {
778 profman_args.push_back(StringPrintf("--reference-profile-file-fd=%d",
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800779 reference_profile_fd.get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700780 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800781 for (size_t i = 0; i < profile_fds.size(); i++) {
782 profman_args.push_back(StringPrintf("--profile-file-fd=%d", profile_fds[i].get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700783 }
784 for (const std::string& dex_location : dex_locations) {
785 profman_args.push_back(StringPrintf("--dex-location=%s", dex_location.c_str()));
786 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800787 for (size_t i = 0; i < apk_fds.size(); i++) {
788 profman_args.push_back(StringPrintf("--apk-fd=%d", apk_fds[i].get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700789 }
790 const char **argv = new const char*[profman_args.size() + 1];
791 size_t i = 0;
792 for (const std::string& profman_arg : profman_args) {
793 argv[i++] = profman_arg.c_str();
794 }
795 argv[i] = NULL;
796
797 execv(PROFMAN_BIN, (char * const *)argv);
798 ALOGE("execv(%s) failed: %s\n", PROFMAN_BIN, strerror(errno));
799 exit(68); /* only get here on exec failure */
800}
801
Calin Juravle76268c52017-03-09 13:19:42 -0800802bool dump_profiles(int32_t uid, const std::string& pkgname, const char* code_paths) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800803 std::vector<unique_fd> profile_fds;
804 unique_fd reference_profile_fd;
Calin Juravle76268c52017-03-09 13:19:42 -0800805 std::string out_file_name = StringPrintf("/data/misc/profman/%s.txt", pkgname.c_str());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700806
Calin Juravle114f0812017-03-08 19:05:07 -0800807 open_profile_files(uid, pkgname, /*is_secondary_dex*/false,
808 &profile_fds, &reference_profile_fd);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700809
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800810 const bool has_reference_profile = (reference_profile_fd.get() != -1);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700811 const bool has_profiles = !profile_fds.empty();
812
813 if (!has_reference_profile && !has_profiles) {
Calin Juravle76268c52017-03-09 13:19:42 -0800814 LOG(ERROR) << "profman dump: no profiles to dump for " << pkgname;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700815 return false;
816 }
817
Calin Juravle114f0812017-03-08 19:05:07 -0800818 unique_fd output_fd(open(out_file_name.c_str(),
819 O_WRONLY | O_CREAT | O_TRUNC | O_NOFOLLOW, 0644));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700820 if (fchmod(output_fd, S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH) < 0) {
821 ALOGE("installd cannot chmod '%s' dump_profile\n", out_file_name.c_str());
822 return false;
823 }
824 std::vector<std::string> code_full_paths = base::Split(code_paths, ";");
825 std::vector<std::string> dex_locations;
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800826 std::vector<unique_fd> apk_fds;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700827 for (const std::string& code_full_path : code_full_paths) {
828 const char* full_path = code_full_path.c_str();
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800829 unique_fd apk_fd(open(full_path, O_RDONLY | O_NOFOLLOW));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700830 if (apk_fd == -1) {
831 ALOGE("installd cannot open '%s'\n", full_path);
832 return false;
833 }
834 dex_locations.push_back(get_location_from_path(full_path));
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800835 apk_fds.push_back(std::move(apk_fd));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700836 }
837
838 pid_t pid = fork();
839 if (pid == 0) {
840 /* child -- drop privileges before continuing */
841 drop_capabilities(uid);
842 run_profman_dump(profile_fds, reference_profile_fd, dex_locations,
843 apk_fds, output_fd);
844 exit(68); /* only get here on exec failure */
845 }
846 /* parent */
Jeff Sharkey90aff262016-12-12 14:28:24 -0700847 int return_code = wait_child(pid);
848 if (!WIFEXITED(return_code)) {
849 LOG(WARNING) << "profman failed for package " << pkgname << ": "
850 << return_code;
851 return false;
852 }
853 return true;
854}
855
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700856bool copy_system_profile(const std::string& system_profile,
857 uid_t packageUid, const std::string& data_profile_location) {
858 unique_fd in_fd(open(system_profile.c_str(), O_RDONLY | O_NOFOLLOW | O_CLOEXEC));
859 unique_fd out_fd(open_reference_profile(packageUid,
860 data_profile_location,
861 /*read_write*/ true,
862 /*secondary*/ false));
863 if (in_fd.get() < 0) {
864 PLOG(WARNING) << "Could not open profile " << system_profile;
865 return false;
866 }
867 if (out_fd.get() < 0) {
868 PLOG(WARNING) << "Could not open profile " << data_profile_location;
869 return false;
870 }
871
Mathieu Chartier78f71fe2017-06-14 13:02:26 -0700872 // As a security measure we want to write the profile information with the reduced capabilities
873 // of the package user id. So we fork and drop capabilities in the child.
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700874 pid_t pid = fork();
875 if (pid == 0) {
876 /* child -- drop privileges before continuing */
877 drop_capabilities(packageUid);
878
879 if (flock(out_fd.get(), LOCK_EX | LOCK_NB) != 0) {
880 if (errno != EWOULDBLOCK) {
881 PLOG(WARNING) << "Error locking profile " << data_profile_location;
882 }
883 // This implies that the app owning this profile is running
884 // (and has acquired the lock).
885 //
886 // The app never acquires the lock for the reference profiles of primary apks.
887 // Only dex2oat from installd will do that. Since installd is single threaded
888 // we should not see this case. Nevertheless be prepared for it.
889 PLOG(WARNING) << "Failed to flock " << data_profile_location;
890 return false;
891 }
892
893 bool truncated = ftruncate(out_fd.get(), 0) == 0;
894 if (!truncated) {
895 PLOG(WARNING) << "Could not truncate " << data_profile_location;
896 }
897
898 // Copy over data.
899 static constexpr size_t kBufferSize = 4 * 1024;
900 char buffer[kBufferSize];
901 while (true) {
902 ssize_t bytes = read(in_fd.get(), buffer, kBufferSize);
903 if (bytes == 0) {
904 break;
905 }
906 write(out_fd.get(), buffer, bytes);
907 }
908 if (flock(out_fd.get(), LOCK_UN) != 0) {
909 PLOG(WARNING) << "Error unlocking profile " << data_profile_location;
910 }
Mathieu Chartier78f71fe2017-06-14 13:02:26 -0700911 // Use _exit since we don't want to run the global destructors in the child.
912 // b/62597429
913 _exit(0);
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700914 }
915 /* parent */
916 int return_code = wait_child(pid);
917 return return_code == 0;
918}
919
Jeff Sharkey90aff262016-12-12 14:28:24 -0700920static std::string replace_file_extension(const std::string& oat_path, const std::string& new_ext) {
921 // A standard dalvik-cache entry. Replace ".dex" with `new_ext`.
922 if (EndsWith(oat_path, ".dex")) {
923 std::string new_path = oat_path;
924 new_path.replace(new_path.length() - strlen(".dex"), strlen(".dex"), new_ext);
925 CHECK(EndsWith(new_path, new_ext.c_str()));
926 return new_path;
927 }
928
929 // An odex entry. Not that this may not be an extension, e.g., in the OTA
930 // case (where the base name will have an extension for the B artifact).
931 size_t odex_pos = oat_path.rfind(".odex");
932 if (odex_pos != std::string::npos) {
933 std::string new_path = oat_path;
934 new_path.replace(odex_pos, strlen(".odex"), new_ext);
935 CHECK_NE(new_path.find(new_ext), std::string::npos);
936 return new_path;
937 }
938
939 // Don't know how to handle this.
940 return "";
941}
942
943// Translate the given oat path to an art (app image) path. An empty string
944// denotes an error.
945static std::string create_image_filename(const std::string& oat_path) {
946 return replace_file_extension(oat_path, ".art");
947}
948
949// Translate the given oat path to a vdex path. An empty string denotes an error.
950static std::string create_vdex_filename(const std::string& oat_path) {
951 return replace_file_extension(oat_path, ".vdex");
952}
953
954static bool add_extension_to_file_name(char* file_name, const char* extension) {
955 if (strlen(file_name) + strlen(extension) + 1 > PKG_PATH_MAX) {
956 return false;
957 }
958 strcat(file_name, extension);
959 return true;
960}
961
962static int open_output_file(const char* file_name, bool recreate, int permissions) {
963 int flags = O_RDWR | O_CREAT;
964 if (recreate) {
965 if (unlink(file_name) < 0) {
966 if (errno != ENOENT) {
967 PLOG(ERROR) << "open_output_file: Couldn't unlink " << file_name;
968 }
969 }
970 flags |= O_EXCL;
971 }
972 return open(file_name, flags, permissions);
973}
974
Calin Juravle2289c0a2017-02-15 12:44:14 -0800975static bool set_permissions_and_ownership(
976 int fd, bool is_public, int uid, const char* path, bool is_secondary_dex) {
977 // Primary apks are owned by the system. Secondary dex files are owned by the app.
978 int owning_uid = is_secondary_dex ? uid : AID_SYSTEM;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700979 if (fchmod(fd,
980 S_IRUSR|S_IWUSR|S_IRGRP |
981 (is_public ? S_IROTH : 0)) < 0) {
982 ALOGE("installd cannot chmod '%s' during dexopt\n", path);
983 return false;
Calin Juravle2289c0a2017-02-15 12:44:14 -0800984 } else if (fchown(fd, owning_uid, uid) < 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700985 ALOGE("installd cannot chown '%s' during dexopt\n", path);
986 return false;
987 }
988 return true;
989}
990
991static bool IsOutputDalvikCache(const char* oat_dir) {
992 // InstallerConnection.java (which invokes installd) transforms Java null arguments
993 // into '!'. Play it safe by handling it both.
994 // TODO: ensure we never get null.
995 // TODO: pass a flag instead of inferring if the output is dalvik cache.
996 return oat_dir == nullptr || oat_dir[0] == '!';
997}
998
Calin Juravled23dee72017-07-06 16:29:11 -0700999// Best-effort check whether we can fit the the path into our buffers.
1000// Note: the cache path will require an additional 5 bytes for ".swap", but we'll try to run
1001// without a swap file, if necessary. Reference profiles file also add an extra ".prof"
1002// extension to the cache path (5 bytes).
1003// TODO(calin): move away from char* buffers and PKG_PATH_MAX.
1004static bool validate_dex_path_size(const std::string& dex_path) {
1005 if (dex_path.size() >= (PKG_PATH_MAX - 8)) {
1006 LOG(ERROR) << "dex_path too long: " << dex_path;
1007 return false;
1008 }
1009 return true;
1010}
1011
Jeff Sharkey90aff262016-12-12 14:28:24 -07001012static bool create_oat_out_path(const char* apk_path, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -08001013 const char* oat_dir, bool is_secondary_dex, /*out*/ char* out_oat_path) {
Calin Juravled23dee72017-07-06 16:29:11 -07001014 if (!validate_dex_path_size(apk_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001015 return false;
1016 }
1017
1018 if (!IsOutputDalvikCache(oat_dir)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001019 // Oat dirs for secondary dex files are already validated.
1020 if (!is_secondary_dex && validate_apk_path(oat_dir)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001021 ALOGE("cannot validate apk path with oat_dir '%s'\n", oat_dir);
1022 return false;
1023 }
1024 if (!calculate_oat_file_path(out_oat_path, oat_dir, apk_path, instruction_set)) {
1025 return false;
1026 }
1027 } else {
1028 if (!create_cache_path(out_oat_path, apk_path, instruction_set)) {
1029 return false;
1030 }
1031 }
1032 return true;
1033}
1034
1035// Helper for fd management. This is similar to a unique_fd in that it closes the file descriptor
1036// on destruction. It will also run the given cleanup (unless told not to) after closing.
1037//
1038// Usage example:
1039//
Calin Juravle7a570e82017-01-14 16:23:30 -08001040// Dex2oatFileWrapper file(open(...),
Jeff Sharkey90aff262016-12-12 14:28:24 -07001041// [name]() {
1042// unlink(name.c_str());
1043// });
1044// // Note: care needs to be taken about name, as it needs to have a lifetime longer than the
1045// wrapper if captured as a reference.
1046//
1047// if (file.get() == -1) {
1048// // Error opening...
1049// }
1050//
1051// ...
1052// if (error) {
1053// // At this point, when the Dex2oatFileWrapper is destructed, the cleanup function will run
1054// // and delete the file (after the fd is closed).
1055// return -1;
1056// }
1057//
1058// (Success case)
1059// file.SetCleanup(false);
1060// // At this point, when the Dex2oatFileWrapper is destructed, the cleanup function will not run
1061// // (leaving the file around; after the fd is closed).
1062//
Jeff Sharkey90aff262016-12-12 14:28:24 -07001063class Dex2oatFileWrapper {
1064 public:
Calin Juravle7a570e82017-01-14 16:23:30 -08001065 Dex2oatFileWrapper() : value_(-1), cleanup_(), do_cleanup_(true), auto_close_(true) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001066 }
1067
Calin Juravle7a570e82017-01-14 16:23:30 -08001068 Dex2oatFileWrapper(int value, std::function<void ()> cleanup)
1069 : value_(value), cleanup_(cleanup), do_cleanup_(true), auto_close_(true) {}
1070
1071 Dex2oatFileWrapper(Dex2oatFileWrapper&& other) {
1072 value_ = other.value_;
1073 cleanup_ = other.cleanup_;
1074 do_cleanup_ = other.do_cleanup_;
1075 auto_close_ = other.auto_close_;
1076 other.release();
1077 }
1078
1079 Dex2oatFileWrapper& operator=(Dex2oatFileWrapper&& other) {
1080 value_ = other.value_;
1081 cleanup_ = other.cleanup_;
1082 do_cleanup_ = other.do_cleanup_;
1083 auto_close_ = other.auto_close_;
1084 other.release();
1085 return *this;
1086 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001087
1088 ~Dex2oatFileWrapper() {
1089 reset(-1);
1090 }
1091
1092 int get() {
1093 return value_;
1094 }
1095
1096 void SetCleanup(bool cleanup) {
1097 do_cleanup_ = cleanup;
1098 }
1099
1100 void reset(int new_value) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001101 if (auto_close_ && value_ >= 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001102 close(value_);
1103 }
1104 if (do_cleanup_ && cleanup_ != nullptr) {
1105 cleanup_();
1106 }
1107
1108 value_ = new_value;
1109 }
1110
Calin Juravle7a570e82017-01-14 16:23:30 -08001111 void reset(int new_value, std::function<void ()> new_cleanup) {
1112 if (auto_close_ && value_ >= 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001113 close(value_);
1114 }
1115 if (do_cleanup_ && cleanup_ != nullptr) {
1116 cleanup_();
1117 }
1118
1119 value_ = new_value;
1120 cleanup_ = new_cleanup;
1121 }
1122
Calin Juravle7a570e82017-01-14 16:23:30 -08001123 void DisableAutoClose() {
1124 auto_close_ = false;
1125 }
1126
Jeff Sharkey90aff262016-12-12 14:28:24 -07001127 private:
Calin Juravle7a570e82017-01-14 16:23:30 -08001128 void release() {
1129 value_ = -1;
1130 do_cleanup_ = false;
1131 cleanup_ = nullptr;
1132 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001133 int value_;
Calin Juravle7a570e82017-01-14 16:23:30 -08001134 std::function<void ()> cleanup_;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001135 bool do_cleanup_;
Calin Juravle7a570e82017-01-14 16:23:30 -08001136 bool auto_close_;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001137};
1138
Calin Juravle7a570e82017-01-14 16:23:30 -08001139// (re)Creates the app image if needed.
1140Dex2oatFileWrapper maybe_open_app_image(const char* out_oat_path, bool profile_guided,
Calin Juravle2289c0a2017-02-15 12:44:14 -08001141 bool is_public, int uid, bool is_secondary_dex) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001142 // Use app images only if it is enabled (by a set image format) and we are compiling
1143 // profile-guided (so the app image doesn't conservatively contain all classes).
Calin Juravle2289c0a2017-02-15 12:44:14 -08001144 // Note that we don't create an image for secondary dex files.
1145 if (is_secondary_dex || !profile_guided) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001146 return Dex2oatFileWrapper();
1147 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001148
Calin Juravle7a570e82017-01-14 16:23:30 -08001149 const std::string image_path = create_image_filename(out_oat_path);
1150 if (image_path.empty()) {
1151 // Happens when the out_oat_path has an unknown extension.
1152 return Dex2oatFileWrapper();
1153 }
1154 char app_image_format[kPropertyValueMax];
1155 bool have_app_image_format =
1156 get_property("dalvik.vm.appimageformat", app_image_format, NULL) > 0;
1157 if (!have_app_image_format) {
1158 return Dex2oatFileWrapper();
1159 }
1160 // Recreate is true since we do not want to modify a mapped image. If the app is
1161 // already running and we modify the image file, it can cause crashes (b/27493510).
1162 Dex2oatFileWrapper wrapper_fd(
1163 open_output_file(image_path.c_str(), true /*recreate*/, 0600 /*permissions*/),
1164 [image_path]() { unlink(image_path.c_str()); });
1165 if (wrapper_fd.get() < 0) {
1166 // Could not create application image file. Go on since we can compile without it.
1167 LOG(ERROR) << "installd could not create '" << image_path
1168 << "' for image file during dexopt";
1169 // If we have a valid image file path but no image fd, explicitly erase the image file.
1170 if (unlink(image_path.c_str()) < 0) {
1171 if (errno != ENOENT) {
1172 PLOG(ERROR) << "Couldn't unlink image file " << image_path;
1173 }
1174 }
1175 } else if (!set_permissions_and_ownership(
Calin Juravle2289c0a2017-02-15 12:44:14 -08001176 wrapper_fd.get(), is_public, uid, image_path.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001177 ALOGE("installd cannot set owner '%s' for image during dexopt\n", image_path.c_str());
1178 wrapper_fd.reset(-1);
1179 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001180
Calin Juravle7a570e82017-01-14 16:23:30 -08001181 return wrapper_fd;
1182}
1183
1184// Creates the dexopt swap file if necessary and return its fd.
1185// Returns -1 if there's no need for a swap or in case of errors.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001186unique_fd maybe_open_dexopt_swap_file(const char* out_oat_path) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001187 if (!ShouldUseSwapFileForDexopt()) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001188 return invalid_unique_fd();
Calin Juravle7a570e82017-01-14 16:23:30 -08001189 }
1190 // Make sure there really is enough space.
1191 char swap_file_name[PKG_PATH_MAX];
1192 strcpy(swap_file_name, out_oat_path);
1193 if (!add_extension_to_file_name(swap_file_name, ".swap")) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001194 return invalid_unique_fd();
Calin Juravle7a570e82017-01-14 16:23:30 -08001195 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001196 unique_fd swap_fd(open_output_file(
Calin Juravle7a570e82017-01-14 16:23:30 -08001197 swap_file_name, /*recreate*/true, /*permissions*/0600));
1198 if (swap_fd.get() < 0) {
1199 // Could not create swap file. Optimistically go on and hope that we can compile
1200 // without it.
1201 ALOGE("installd could not create '%s' for swap during dexopt\n", swap_file_name);
1202 } else {
1203 // Immediately unlink. We don't really want to hit flash.
1204 if (unlink(swap_file_name) < 0) {
1205 PLOG(ERROR) << "Couldn't unlink swap file " << swap_file_name;
1206 }
1207 }
1208 return swap_fd;
1209}
1210
1211// Opens the reference profiles if needed.
1212// Note that the reference profile might not exist so it's OK if the fd will be -1.
Calin Juravle114f0812017-03-08 19:05:07 -08001213Dex2oatFileWrapper maybe_open_reference_profile(const std::string& pkgname,
1214 const std::string& dex_path, bool profile_guided, bool is_public, int uid,
1215 bool is_secondary_dex) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001216 // Public apps should not be compiled with profile information ever. Same goes for the special
1217 // package '*' used for the system server.
Calin Juravle114f0812017-03-08 19:05:07 -08001218 if (!profile_guided || is_public || (pkgname[0] == '*')) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001219 return Dex2oatFileWrapper();
Jeff Sharkey90aff262016-12-12 14:28:24 -07001220 }
Calin Juravle114f0812017-03-08 19:05:07 -08001221
1222 // Open reference profile in read only mode as dex2oat does not get write permissions.
1223 const std::string location = is_secondary_dex ? dex_path : pkgname;
1224 unique_fd ufd = open_reference_profile(uid, location, /*read_write*/false, is_secondary_dex);
1225 const auto& cleanup = [location, is_secondary_dex]() {
1226 clear_reference_profile(location.c_str(), is_secondary_dex);
1227 };
1228 return Dex2oatFileWrapper(ufd.release(), cleanup);
Calin Juravle7a570e82017-01-14 16:23:30 -08001229}
Jeff Sharkey90aff262016-12-12 14:28:24 -07001230
Calin Juravle7a570e82017-01-14 16:23:30 -08001231// Opens the vdex files and assigns the input fd to in_vdex_wrapper_fd and the output fd to
1232// out_vdex_wrapper_fd. Returns true for success or false in case of errors.
1233bool open_vdex_files(const char* apk_path, const char* out_oat_path, int dexopt_needed,
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001234 const char* instruction_set, bool is_public, int uid, bool is_secondary_dex,
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001235 bool profile_guided, Dex2oatFileWrapper* in_vdex_wrapper_fd,
Calin Juravle7a570e82017-01-14 16:23:30 -08001236 Dex2oatFileWrapper* out_vdex_wrapper_fd) {
1237 CHECK(in_vdex_wrapper_fd != nullptr);
1238 CHECK(out_vdex_wrapper_fd != nullptr);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001239 // Open the existing VDEX. We do this before creating the new output VDEX, which will
1240 // unlink the old one.
Richard Uhler76cc0272016-12-08 10:46:35 +00001241 char in_odex_path[PKG_PATH_MAX];
1242 int dexopt_action = abs(dexopt_needed);
1243 bool is_odex_location = dexopt_needed < 0;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001244 std::string in_vdex_path_str;
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001245
1246 // Infer the name of the output VDEX.
1247 const std::string out_vdex_path_str = create_vdex_filename(out_oat_path);
1248 if (out_vdex_path_str.empty()) {
1249 return false;
1250 }
1251
1252 bool update_vdex_in_place = false;
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001253 if (dexopt_action != DEX2OAT_FROM_SCRATCH) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001254 // Open the possibly existing vdex. If none exist, we pass -1 to dex2oat for input-vdex-fd.
1255 const char* path = nullptr;
1256 if (is_odex_location) {
1257 if (calculate_odex_file_path(in_odex_path, apk_path, instruction_set)) {
1258 path = in_odex_path;
1259 } else {
1260 ALOGE("installd cannot compute input vdex location for '%s'\n", apk_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001261 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001262 }
1263 } else {
1264 path = out_oat_path;
1265 }
1266 in_vdex_path_str = create_vdex_filename(path);
1267 if (in_vdex_path_str.empty()) {
1268 ALOGE("installd cannot compute input vdex location for '%s'\n", path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001269 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001270 }
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001271 // We can update in place when all these conditions are met:
1272 // 1) The vdex location to write to is the same as the vdex location to read (vdex files
1273 // on /system typically cannot be updated in place).
1274 // 2) We dex2oat due to boot image change, because we then know the existing vdex file
1275 // cannot be currently used by a running process.
1276 // 3) We are not doing a profile guided compilation, because dexlayout requires two
1277 // different vdex files to operate.
1278 update_vdex_in_place =
1279 (in_vdex_path_str == out_vdex_path_str) &&
1280 (dexopt_action == DEX2OAT_FOR_BOOT_IMAGE) &&
1281 !profile_guided;
1282 if (update_vdex_in_place) {
1283 // Open the file read-write to be able to update it.
1284 in_vdex_wrapper_fd->reset(open(in_vdex_path_str.c_str(), O_RDWR, 0));
1285 if (in_vdex_wrapper_fd->get() == -1) {
1286 // If we failed to open the file, we cannot update it in place.
1287 update_vdex_in_place = false;
1288 }
1289 } else {
1290 in_vdex_wrapper_fd->reset(open(in_vdex_path_str.c_str(), O_RDONLY, 0));
1291 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001292 }
1293
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001294 // If we are updating the vdex in place, we do not need to recreate a vdex,
1295 // and can use the same existing one.
1296 if (update_vdex_in_place) {
1297 // We unlink the file in case the invocation of dex2oat fails, to ensure we don't
1298 // have bogus stale vdex files.
1299 out_vdex_wrapper_fd->reset(
1300 in_vdex_wrapper_fd->get(),
1301 [out_vdex_path_str]() { unlink(out_vdex_path_str.c_str()); });
1302 // Disable auto close for the in wrapper fd (it will be done when destructing the out
1303 // wrapper).
1304 in_vdex_wrapper_fd->DisableAutoClose();
1305 } else {
1306 out_vdex_wrapper_fd->reset(
1307 open_output_file(out_vdex_path_str.c_str(), /*recreate*/true, /*permissions*/0644),
1308 [out_vdex_path_str]() { unlink(out_vdex_path_str.c_str()); });
1309 if (out_vdex_wrapper_fd->get() < 0) {
1310 ALOGE("installd cannot open vdex'%s' during dexopt\n", out_vdex_path_str.c_str());
1311 return false;
1312 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001313 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001314 if (!set_permissions_and_ownership(out_vdex_wrapper_fd->get(), is_public, uid,
Calin Juravle2289c0a2017-02-15 12:44:14 -08001315 out_vdex_path_str.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001316 ALOGE("installd cannot set owner '%s' for vdex during dexopt\n", out_vdex_path_str.c_str());
1317 return false;
1318 }
1319
1320 // If we got here we successfully opened the vdex files.
1321 return true;
1322}
1323
1324// Opens the output oat file for the given apk.
1325// If successful it stores the output path into out_oat_path and returns true.
1326Dex2oatFileWrapper open_oat_out_file(const char* apk_path, const char* oat_dir,
Calin Juravle80a21252017-01-17 14:43:25 -08001327 bool is_public, int uid, const char* instruction_set, bool is_secondary_dex,
1328 char* out_oat_path) {
1329 if (!create_oat_out_path(apk_path, instruction_set, oat_dir, is_secondary_dex, out_oat_path)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001330 return Dex2oatFileWrapper();
1331 }
1332 const std::string out_oat_path_str(out_oat_path);
1333 Dex2oatFileWrapper wrapper_fd(
1334 open_output_file(out_oat_path, /*recreate*/true, /*permissions*/0644),
1335 [out_oat_path_str]() { unlink(out_oat_path_str.c_str()); });
1336 if (wrapper_fd.get() < 0) {
Calin Juravle80a21252017-01-17 14:43:25 -08001337 PLOG(ERROR) << "installd cannot open output during dexopt" << out_oat_path;
Calin Juravle2289c0a2017-02-15 12:44:14 -08001338 } else if (!set_permissions_and_ownership(
1339 wrapper_fd.get(), is_public, uid, out_oat_path, is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001340 ALOGE("installd cannot set owner '%s' for output during dexopt\n", out_oat_path);
1341 wrapper_fd.reset(-1);
1342 }
1343 return wrapper_fd;
1344}
1345
1346// Updates the access times of out_oat_path based on those from apk_path.
1347void update_out_oat_access_times(const char* apk_path, const char* out_oat_path) {
1348 struct stat input_stat;
1349 memset(&input_stat, 0, sizeof(input_stat));
1350 if (stat(apk_path, &input_stat) != 0) {
1351 PLOG(ERROR) << "Could not stat " << apk_path << " during dexopt";
1352 return;
1353 }
1354
1355 struct utimbuf ut;
1356 ut.actime = input_stat.st_atime;
1357 ut.modtime = input_stat.st_mtime;
1358 if (utime(out_oat_path, &ut) != 0) {
1359 PLOG(WARNING) << "Could not update access times for " << apk_path << " during dexopt";
1360 }
1361}
1362
Calin Juravle80a21252017-01-17 14:43:25 -08001363// Runs (execv) dexoptanalyzer on the given arguments.
Calin Juravle114f0812017-03-08 19:05:07 -08001364// The analyzer will check if the dex_file needs to be (re)compiled to match the compiler_filter.
1365// If this is for a profile guided compilation, profile_was_updated will tell whether or not
1366// the profile has changed.
Calin Juravled23dee72017-07-06 16:29:11 -07001367static void exec_dexoptanalyzer(const std::string& dex_file, const std::string& instruction_set,
1368 const std::string& compiler_filter, bool profile_was_updated) {
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001369 const char* dexoptanalyzer_bin =
1370 is_debug_runtime()
1371 ? "/system/bin/dexoptanalyzerd"
1372 : "/system/bin/dexoptanalyzer";
Calin Juravle80a21252017-01-17 14:43:25 -08001373 static const unsigned int MAX_INSTRUCTION_SET_LEN = 7;
1374
Calin Juravled23dee72017-07-06 16:29:11 -07001375 if (instruction_set.size() >= MAX_INSTRUCTION_SET_LEN) {
1376 LOG(ERROR) << "Instruction set " << instruction_set
1377 << " longer than max length of " << MAX_INSTRUCTION_SET_LEN;
Calin Juravle80a21252017-01-17 14:43:25 -08001378 return;
1379 }
1380
Calin Juravled23dee72017-07-06 16:29:11 -07001381 std::string dex_file_arg = "--dex-file=" + dex_file;
1382 std::string isa_arg = "--isa=" + instruction_set;
1383 std::string compiler_filter_arg = "--compiler-filter=" + compiler_filter;
Calin Juravle114f0812017-03-08 19:05:07 -08001384 const char* assume_profile_changed = "--assume-profile-changed";
Calin Juravle80a21252017-01-17 14:43:25 -08001385
Calin Juravle80a21252017-01-17 14:43:25 -08001386 // program name, dex file, isa, filter, the final NULL
Calin Juravle114f0812017-03-08 19:05:07 -08001387 const char* argv[5 + (profile_was_updated ? 1 : 0)];
Calin Juravle80a21252017-01-17 14:43:25 -08001388 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001389 argv[i++] = dexoptanalyzer_bin;
Calin Juravled23dee72017-07-06 16:29:11 -07001390 argv[i++] = dex_file_arg.c_str();
1391 argv[i++] = isa_arg.c_str();
1392 argv[i++] = compiler_filter_arg.c_str();
Calin Juravle114f0812017-03-08 19:05:07 -08001393 if (profile_was_updated) {
1394 argv[i++] = assume_profile_changed;
1395 }
Calin Juravle80a21252017-01-17 14:43:25 -08001396 argv[i] = NULL;
1397
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001398 execv(dexoptanalyzer_bin, (char * const *)argv);
1399 ALOGE("execv(%s) failed: %s\n", dexoptanalyzer_bin, strerror(errno));
Calin Juravle80a21252017-01-17 14:43:25 -08001400}
1401
1402// Prepares the oat dir for the secondary dex files.
Calin Juravle114f0812017-03-08 19:05:07 -08001403static bool prepare_secondary_dex_oat_dir(const std::string& dex_path, int uid,
1404 const char* instruction_set, std::string* oat_dir_out) {
1405 unsigned long dirIndex = dex_path.rfind('/');
Calin Juravle80a21252017-01-17 14:43:25 -08001406 if (dirIndex == std::string::npos) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001407 LOG(ERROR ) << "Unexpected dir structure for secondary dex " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001408 return false;
1409 }
Calin Juravle114f0812017-03-08 19:05:07 -08001410 std::string dex_dir = dex_path.substr(0, dirIndex);
Calin Juravle80a21252017-01-17 14:43:25 -08001411
Calin Juravle80a21252017-01-17 14:43:25 -08001412 // Create oat file output directory.
Calin Juravleebc8a792017-04-04 20:21:05 -07001413 mode_t oat_dir_mode = S_IRWXU | S_IRWXG | S_IXOTH;
1414 if (prepare_app_cache_dir(dex_dir, "oat", oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001415 LOG(ERROR) << "Could not prepare oat dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001416 return false;
1417 }
1418
1419 char oat_dir[PKG_PATH_MAX];
Calin Juravle114f0812017-03-08 19:05:07 -08001420 snprintf(oat_dir, PKG_PATH_MAX, "%s/oat", dex_dir.c_str());
Calin Juravle80a21252017-01-17 14:43:25 -08001421 oat_dir_out->assign(oat_dir);
1422
1423 // Create oat/isa output directory.
Calin Juravleebc8a792017-04-04 20:21:05 -07001424 if (prepare_app_cache_dir(*oat_dir_out, instruction_set, oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001425 LOG(ERROR) << "Could not prepare oat/isa dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001426 return false;
1427 }
1428
1429 return true;
1430}
1431
1432static int constexpr DEXOPTANALYZER_BIN_EXEC_ERROR = 200;
1433
1434// Verifies the result of dexoptanalyzer executed for the apk_path.
1435// If the result is valid returns true and sets dexopt_needed_out to a valid value.
1436// Returns false for errors or unexpected result values.
Calin Juravle114f0812017-03-08 19:05:07 -08001437static bool process_dexoptanalyzer_result(const std::string& dex_path, int result,
Calin Juravle80a21252017-01-17 14:43:25 -08001438 int* dexopt_needed_out) {
1439 // The result values are defined in dexoptanalyzer.
1440 switch (result) {
1441 case 0: // no_dexopt_needed
1442 *dexopt_needed_out = NO_DEXOPT_NEEDED; return true;
1443 case 1: // dex2oat_from_scratch
1444 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH; return true;
1445 case 5: // dex2oat_for_bootimage_odex
1446 *dexopt_needed_out = -DEX2OAT_FOR_BOOT_IMAGE; return true;
1447 case 6: // dex2oat_for_filter_odex
1448 *dexopt_needed_out = -DEX2OAT_FOR_FILTER; return true;
1449 case 7: // dex2oat_for_relocation_odex
1450 *dexopt_needed_out = -DEX2OAT_FOR_RELOCATION; return true;
1451 case 2: // dex2oat_for_bootimage_oat
1452 case 3: // dex2oat_for_filter_oat
1453 case 4: // dex2oat_for_relocation_oat
Calin Juravlec9eab382017-01-25 01:17:17 -08001454 LOG(ERROR) << "Dexoptnalyzer return the status of an oat file."
1455 << " Expected odex file status for secondary dex " << dex_path
Calin Juravle80a21252017-01-17 14:43:25 -08001456 << " : dexoptanalyzer result=" << result;
1457 return false;
1458 default:
Calin Juravlec9eab382017-01-25 01:17:17 -08001459 LOG(ERROR) << "Unexpected result for dexoptanalyzer " << dex_path
Calin Juravle80a21252017-01-17 14:43:25 -08001460 << " exec_dexoptanalyzer result=" << result;
1461 return false;
1462 }
1463}
1464
Calin Juravlec9eab382017-01-25 01:17:17 -08001465// Processes the dex_path as a secondary dex files and return true if the path dex file should
Calin Juravle80a21252017-01-17 14:43:25 -08001466// be compiled. Returns false for errors (logged) or true if the secondary dex path was process
1467// successfully.
Calin Juravleebc8a792017-04-04 20:21:05 -07001468// When returning true, the output parameters will be:
1469// - is_public_out: whether or not the oat file should not be made public
1470// - dexopt_needed_out: valid OatFileAsssitant::DexOptNeeded
1471// - oat_dir_out: the oat dir path where the oat file should be stored
1472// - dex_path_out: the real path of the dex file
Calin Juravle114f0812017-03-08 19:05:07 -08001473static bool process_secondary_dex_dexopt(const char* original_dex_path, const char* pkgname,
Calin Juravle80a21252017-01-17 14:43:25 -08001474 int dexopt_flags, const char* volume_uuid, int uid, const char* instruction_set,
Calin Juravleebc8a792017-04-04 20:21:05 -07001475 const char* compiler_filter, bool* is_public_out, int* dexopt_needed_out,
1476 std::string* oat_dir_out, std::string* dex_path_out) {
Calin Juravle80a21252017-01-17 14:43:25 -08001477 int storage_flag;
1478
1479 if ((dexopt_flags & DEXOPT_STORAGE_CE) != 0) {
1480 storage_flag = FLAG_STORAGE_CE;
1481 if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
1482 LOG(ERROR) << "Ambiguous secondary dex storage flag. Both, CE and DE, flags are set";
1483 return false;
1484 }
1485 } else if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
1486 storage_flag = FLAG_STORAGE_DE;
1487 } else {
1488 LOG(ERROR) << "Secondary dex storage flag must be set";
1489 return false;
1490 }
1491
Calin Juravle114f0812017-03-08 19:05:07 -08001492 {
1493 // As opposed to the primary apk, secondary dex files might contain symlinks.
1494 // Resolve the path before passing it to the validate method to
1495 // make sure the verification is done on the real location.
1496 UniqueCPtr<char> dex_real_path_cstr(realpath(original_dex_path, nullptr));
1497 if (dex_real_path_cstr == nullptr) {
1498 PLOG(ERROR) << "Could not get the real path of the secondary dex file "
1499 << original_dex_path;
1500 return false;
1501 } else {
1502 dex_path_out->assign(dex_real_path_cstr.get());
1503 }
1504 }
1505 const std::string& dex_path = *dex_path_out;
Calin Juravled23dee72017-07-06 16:29:11 -07001506 if (!validate_dex_path_size(dex_path)) {
1507 return false;
1508 }
Calin Juravlec9eab382017-01-25 01:17:17 -08001509 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid, uid, storage_flag)) {
1510 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001511 return false;
1512 }
1513
1514 // Check if the path exist. If not, there's nothing to do.
Calin Juravleebc8a792017-04-04 20:21:05 -07001515 struct stat dex_path_stat;
1516 if (stat(dex_path.c_str(), &dex_path_stat) != 0) {
Calin Juravle80a21252017-01-17 14:43:25 -08001517 if (errno == ENOENT) {
1518 // Secondary dex files might be deleted any time by the app.
1519 // Nothing to do if that's the case
Calin Juravle114f0812017-03-08 19:05:07 -08001520 ALOGV("Secondary dex does not exist %s", dex_path.c_str());
Calin Juravle80a21252017-01-17 14:43:25 -08001521 return NO_DEXOPT_NEEDED;
1522 } else {
Calin Juravlec9eab382017-01-25 01:17:17 -08001523 PLOG(ERROR) << "Could not access secondary dex " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001524 }
1525 }
1526
Calin Juravleebc8a792017-04-04 20:21:05 -07001527 // Check if we should make the oat file public.
1528 // Note that if the dex file is not public the compiled code cannot be made public.
1529 *is_public_out = ((dexopt_flags & DEXOPT_PUBLIC) != 0) &&
1530 ((dex_path_stat.st_mode & S_IROTH) != 0);
1531
Calin Juravle80a21252017-01-17 14:43:25 -08001532 // Prepare the oat directories.
Calin Juravle114f0812017-03-08 19:05:07 -08001533 if (!prepare_secondary_dex_oat_dir(dex_path, uid, instruction_set, oat_dir_out)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001534 return false;
1535 }
1536
Calin Juravle114f0812017-03-08 19:05:07 -08001537 // Analyze profiles.
1538 bool profile_was_updated = analyze_profiles(uid, dex_path, /*is_secondary_dex*/true);
1539
Calin Juravle80a21252017-01-17 14:43:25 -08001540 pid_t pid = fork();
1541 if (pid == 0) {
1542 // child -- drop privileges before continuing.
1543 drop_capabilities(uid);
1544 // Run dexoptanalyzer to get dexopt_needed code.
Calin Juravle114f0812017-03-08 19:05:07 -08001545 exec_dexoptanalyzer(dex_path, instruction_set, compiler_filter, profile_was_updated);
Calin Juravle80a21252017-01-17 14:43:25 -08001546 exit(DEXOPTANALYZER_BIN_EXEC_ERROR);
1547 }
1548
1549 /* parent */
1550
1551 int result = wait_child(pid);
1552 if (!WIFEXITED(result)) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001553 LOG(ERROR) << "dexoptanalyzer failed for path " << dex_path << ": " << result;
Calin Juravle80a21252017-01-17 14:43:25 -08001554 return false;
1555 }
1556 result = WEXITSTATUS(result);
Calin Juravlec9eab382017-01-25 01:17:17 -08001557 bool success = process_dexoptanalyzer_result(dex_path, result, dexopt_needed_out);
Calin Juravle80a21252017-01-17 14:43:25 -08001558 // Run dexopt only if needed or forced.
1559 // Note that dexoptanalyzer is executed even if force compilation is enabled.
1560 // We ignore its valid dexopNeeded result, but still check (in process_dexoptanalyzer_result)
1561 // that we only get results for odex files (apk_dir/oat/isa/code.odex) and not
1562 // for oat files from dalvik-cache.
1563 if (success && ((dexopt_flags & DEXOPT_FORCE) != 0)) {
1564 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH;
1565 }
1566
1567 return success;
1568}
1569
Calin Juravlec9eab382017-01-25 01:17:17 -08001570int dexopt(const char* dex_path, uid_t uid, const char* pkgname, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -08001571 int dexopt_needed, const char* oat_dir, int dexopt_flags, const char* compiler_filter,
Calin Juravlecb556e32017-04-04 20:22:50 -07001572 const char* volume_uuid, const char* shared_libraries, const char* se_info) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001573 CHECK(pkgname != nullptr);
1574 CHECK(pkgname[0] != 0);
1575 if ((dexopt_flags & ~DEXOPT_MASK) != 0) {
1576 LOG_FATAL("dexopt flags contains unknown fields\n");
1577 }
1578
Calin Juravled23dee72017-07-06 16:29:11 -07001579 if (!validate_dex_path_size(dex_path)) {
1580 return false;
1581 }
1582
Calin Juravleebc8a792017-04-04 20:21:05 -07001583 bool is_public = (dexopt_flags & DEXOPT_PUBLIC) != 0;
Calin Juravle7a570e82017-01-14 16:23:30 -08001584 bool debuggable = (dexopt_flags & DEXOPT_DEBUGGABLE) != 0;
1585 bool boot_complete = (dexopt_flags & DEXOPT_BOOTCOMPLETE) != 0;
1586 bool profile_guided = (dexopt_flags & DEXOPT_PROFILE_GUIDED) != 0;
Calin Juravle80a21252017-01-17 14:43:25 -08001587 bool is_secondary_dex = (dexopt_flags & DEXOPT_SECONDARY_DEX) != 0;
1588
1589 // Check if we're dealing with a secondary dex file and if we need to compile it.
1590 std::string oat_dir_str;
Calin Juravle114f0812017-03-08 19:05:07 -08001591 std::string dex_real_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001592 if (is_secondary_dex) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001593 if (process_secondary_dex_dexopt(dex_path, pkgname, dexopt_flags, volume_uuid, uid,
Calin Juravleebc8a792017-04-04 20:21:05 -07001594 instruction_set, compiler_filter, &is_public, &dexopt_needed, &oat_dir_str,
1595 &dex_real_path)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001596 oat_dir = oat_dir_str.c_str();
Calin Juravle114f0812017-03-08 19:05:07 -08001597 dex_path = dex_real_path.c_str();
Calin Juravle80a21252017-01-17 14:43:25 -08001598 if (dexopt_needed == NO_DEXOPT_NEEDED) {
1599 return 0; // Nothing to do, report success.
1600 }
1601 } else {
1602 return -1; // We had an error, logged in the process method.
1603 }
1604 } else {
Calin Juravlec9eab382017-01-25 01:17:17 -08001605 // Currently these flags are only use for secondary dex files.
1606 // Verify that they are not set for primary apks.
Calin Juravle80a21252017-01-17 14:43:25 -08001607 CHECK((dexopt_flags & DEXOPT_STORAGE_CE) == 0);
1608 CHECK((dexopt_flags & DEXOPT_STORAGE_DE) == 0);
1609 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001610
1611 // Open the input file.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001612 unique_fd input_fd(open(dex_path, O_RDONLY, 0));
Calin Juravle7a570e82017-01-14 16:23:30 -08001613 if (input_fd.get() < 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001614 ALOGE("installd cannot open '%s' for input during dexopt\n", dex_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001615 return -1;
1616 }
1617
1618 // Create the output OAT file.
1619 char out_oat_path[PKG_PATH_MAX];
Calin Juravlec9eab382017-01-25 01:17:17 -08001620 Dex2oatFileWrapper out_oat_fd = open_oat_out_file(dex_path, oat_dir, is_public, uid,
Calin Juravle80a21252017-01-17 14:43:25 -08001621 instruction_set, is_secondary_dex, out_oat_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001622 if (out_oat_fd.get() < 0) {
1623 return -1;
1624 }
1625
1626 // Open vdex files.
1627 Dex2oatFileWrapper in_vdex_fd;
1628 Dex2oatFileWrapper out_vdex_fd;
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001629 if (!open_vdex_files(dex_path, out_oat_path, dexopt_needed, instruction_set, is_public, uid,
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001630 is_secondary_dex, profile_guided, &in_vdex_fd, &out_vdex_fd)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001631 return -1;
1632 }
1633
Calin Juravlecb556e32017-04-04 20:22:50 -07001634 // Ensure that the oat dir and the compiler artifacts of secondary dex files have the correct
1635 // selinux context (we generate them on the fly during the dexopt invocation and they don't
1636 // fully inherit their parent context).
1637 // Note that for primary apk the oat files are created before, in a separate installd
1638 // call which also does the restorecon. TODO(calin): unify the paths.
1639 if (is_secondary_dex) {
1640 if (selinux_android_restorecon_pkgdir(oat_dir, se_info, uid,
1641 SELINUX_ANDROID_RESTORECON_RECURSE)) {
1642 LOG(ERROR) << "Failed to restorecon " << oat_dir;
1643 return -1;
1644 }
1645 }
1646
Jeff Sharkey90aff262016-12-12 14:28:24 -07001647 // Create a swap file if necessary.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001648 unique_fd swap_fd = maybe_open_dexopt_swap_file(out_oat_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001649
Calin Juravle7a570e82017-01-14 16:23:30 -08001650 // Create the app image file if needed.
1651 Dex2oatFileWrapper image_fd =
Calin Juravle2289c0a2017-02-15 12:44:14 -08001652 maybe_open_app_image(out_oat_path, profile_guided, is_public, uid, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001653
Calin Juravle7a570e82017-01-14 16:23:30 -08001654 // Open the reference profile if needed.
Calin Juravle114f0812017-03-08 19:05:07 -08001655 Dex2oatFileWrapper reference_profile_fd = maybe_open_reference_profile(
1656 pkgname, dex_path, profile_guided, is_public, uid, is_secondary_dex);
Calin Juravle7a570e82017-01-14 16:23:30 -08001657
Calin Juravlec9eab382017-01-25 01:17:17 -08001658 ALOGV("DexInv: --- BEGIN '%s' ---\n", dex_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001659
1660 pid_t pid = fork();
1661 if (pid == 0) {
1662 /* child -- drop privileges before continuing */
1663 drop_capabilities(uid);
1664
Richard Uhler76cc0272016-12-08 10:46:35 +00001665 SetDex2OatScheduling(boot_complete);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001666 if (flock(out_oat_fd.get(), LOCK_EX | LOCK_NB) != 0) {
1667 ALOGE("flock(%s) failed: %s\n", out_oat_path, strerror(errno));
1668 _exit(67);
1669 }
1670
Richard Uhler76cc0272016-12-08 10:46:35 +00001671 run_dex2oat(input_fd.get(),
1672 out_oat_fd.get(),
1673 in_vdex_fd.get(),
Calin Juravle7a570e82017-01-14 16:23:30 -08001674 out_vdex_fd.get(),
Richard Uhler76cc0272016-12-08 10:46:35 +00001675 image_fd.get(),
Jeff Hao10b8a6e2017-04-05 17:11:39 -07001676 dex_path,
Richard Uhler76cc0272016-12-08 10:46:35 +00001677 out_oat_path,
1678 swap_fd.get(),
1679 instruction_set,
1680 compiler_filter,
Richard Uhler76cc0272016-12-08 10:46:35 +00001681 debuggable,
1682 boot_complete,
1683 reference_profile_fd.get(),
1684 shared_libraries);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001685 _exit(68); /* only get here on exec failure */
1686 } else {
1687 int res = wait_child(pid);
1688 if (res == 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001689 ALOGV("DexInv: --- END '%s' (success) ---\n", dex_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001690 } else {
Calin Juravlec9eab382017-01-25 01:17:17 -08001691 ALOGE("DexInv: --- END '%s' --- status=0x%04x, process failed\n", dex_path, res);
Andreas Gampe013f02e2017-03-20 18:36:54 -07001692 return res;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001693 }
1694 }
1695
Calin Juravlec9eab382017-01-25 01:17:17 -08001696 update_out_oat_access_times(dex_path, out_oat_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001697
1698 // We've been successful, don't delete output.
1699 out_oat_fd.SetCleanup(false);
Calin Juravle7a570e82017-01-14 16:23:30 -08001700 out_vdex_fd.SetCleanup(false);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001701 image_fd.SetCleanup(false);
1702 reference_profile_fd.SetCleanup(false);
1703
1704 return 0;
1705}
1706
Calin Juravlec9eab382017-01-25 01:17:17 -08001707// Try to remove the given directory. Log an error if the directory exists
1708// and is empty but could not be removed.
1709static bool rmdir_if_empty(const char* dir) {
1710 if (rmdir(dir) == 0) {
1711 return true;
1712 }
1713 if (errno == ENOENT || errno == ENOTEMPTY) {
1714 return true;
1715 }
1716 PLOG(ERROR) << "Failed to remove dir: " << dir;
1717 return false;
1718}
1719
1720// Try to unlink the given file. Log an error if the file exists and could not
1721// be unlinked.
1722static bool unlink_if_exists(const std::string& file) {
1723 if (unlink(file.c_str()) == 0) {
1724 return true;
1725 }
1726 if (errno == ENOENT) {
1727 return true;
1728
1729 }
1730 PLOG(ERROR) << "Could not unlink: " << file;
1731 return false;
1732}
1733
1734// Create the oat file structure for the secondary dex 'dex_path' and assign
1735// the individual path component to the 'out_' parameters.
1736static bool create_secondary_dex_oat_layout(const std::string& dex_path, const std::string& isa,
1737 /*out*/char* out_oat_dir, /*out*/char* out_oat_isa_dir, /*out*/char* out_oat_path) {
1738 size_t dirIndex = dex_path.rfind('/');
1739 if (dirIndex == std::string::npos) {
1740 LOG(ERROR) << "Unexpected dir structure for dex file " << dex_path;
1741 return false;
1742 }
1743 // TODO(calin): we have similar computations in at lest 3 other places
1744 // (InstalldNativeService, otapropt and dexopt). Unify them and get rid of snprintf by
1745 // use string append.
1746 std::string apk_dir = dex_path.substr(0, dirIndex);
1747 snprintf(out_oat_dir, PKG_PATH_MAX, "%s/oat", apk_dir.c_str());
1748 snprintf(out_oat_isa_dir, PKG_PATH_MAX, "%s/%s", out_oat_dir, isa.c_str());
1749
1750 if (!create_oat_out_path(dex_path.c_str(), isa.c_str(), out_oat_dir,
Calin Juravle114f0812017-03-08 19:05:07 -08001751 /*is_secondary_dex*/true, out_oat_path)) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001752 LOG(ERROR) << "Could not create oat path for secondary dex " << dex_path;
1753 return false;
1754 }
1755 return true;
1756}
1757
1758// Reconcile the secondary dex 'dex_path' and its generated oat files.
1759// Return true if all the parameters are valid and the secondary dex file was
1760// processed successfully (i.e. the dex_path either exists, or if not, its corresponding
1761// oat/vdex/art files where deleted successfully). In this case, out_secondary_dex_exists
1762// will be true if the secondary dex file still exists. If the secondary dex file does not exist,
1763// the method cleans up any previously generated compiler artifacts (oat, vdex, art).
1764// Return false if there were errors during processing. In this case
1765// out_secondary_dex_exists will be set to false.
1766bool reconcile_secondary_dex_file(const std::string& dex_path,
1767 const std::string& pkgname, int uid, const std::vector<std::string>& isas,
1768 const std::unique_ptr<std::string>& volume_uuid, int storage_flag,
1769 /*out*/bool* out_secondary_dex_exists) {
1770 // Set out to false to start with, just in case we have validation errors.
1771 *out_secondary_dex_exists = false;
Calin Juravled23dee72017-07-06 16:29:11 -07001772 if (!validate_dex_path_size(dex_path)) {
1773 return false;
1774 }
1775
Calin Juravlec9eab382017-01-25 01:17:17 -08001776 if (isas.size() == 0) {
1777 LOG(ERROR) << "reconcile_secondary_dex_file called with empty isas vector";
1778 return false;
1779 }
1780
1781 const char* volume_uuid_cstr = volume_uuid == nullptr ? nullptr : volume_uuid->c_str();
1782 if (!validate_secondary_dex_path(pkgname.c_str(), dex_path.c_str(), volume_uuid_cstr,
1783 uid, storage_flag)) {
1784 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
1785 return false;
1786 }
1787
1788 if (access(dex_path.c_str(), F_OK) == 0) {
1789 // The path exists, nothing to do. The odex files (if any) will be left untouched.
1790 *out_secondary_dex_exists = true;
1791 return true;
1792 } else if (errno != ENOENT) {
1793 PLOG(ERROR) << "Failed to check access to secondary dex " << dex_path;
1794 return false;
1795 }
1796
1797 // The secondary dex does not exist anymore. Clear any generated files.
1798 char oat_path[PKG_PATH_MAX];
1799 char oat_dir[PKG_PATH_MAX];
1800 char oat_isa_dir[PKG_PATH_MAX];
1801 bool result = true;
1802 for (size_t i = 0; i < isas.size(); i++) {
1803 if (!create_secondary_dex_oat_layout(dex_path, isas[i], oat_dir, oat_isa_dir, oat_path)) {
1804 LOG(ERROR) << "Could not create secondary odex layout: " << dex_path;
1805 result = false;
1806 continue;
1807 }
Calin Juravle51314092017-05-18 15:33:05 -07001808
1809 // Delete oat/vdex/art files.
Calin Juravlec9eab382017-01-25 01:17:17 -08001810 result = unlink_if_exists(oat_path) && result;
1811 result = unlink_if_exists(create_vdex_filename(oat_path)) && result;
1812 result = unlink_if_exists(create_image_filename(oat_path)) && result;
1813
Calin Juravle51314092017-05-18 15:33:05 -07001814 // Delete profiles.
1815 std::string current_profile = create_current_profile_path(
1816 multiuser_get_user_id(uid), dex_path, /*is_secondary*/true);
1817 std::string reference_profile = create_reference_profile_path(
1818 dex_path, /*is_secondary*/true);
1819 result = unlink_if_exists(current_profile) && result;
1820 result = unlink_if_exists(reference_profile) && result;
1821
Calin Juravlec9eab382017-01-25 01:17:17 -08001822 // Try removing the directories as well, they might be empty.
1823 result = rmdir_if_empty(oat_isa_dir) && result;
1824 result = rmdir_if_empty(oat_dir) && result;
1825 }
1826
1827 return result;
1828}
1829
Jeff Sharkey90aff262016-12-12 14:28:24 -07001830// Helper for move_ab, so that we can have common failure-case cleanup.
1831static bool unlink_and_rename(const char* from, const char* to) {
1832 // Check whether "from" exists, and if so whether it's regular. If it is, unlink. Otherwise,
1833 // return a failure.
1834 struct stat s;
1835 if (stat(to, &s) == 0) {
1836 if (!S_ISREG(s.st_mode)) {
1837 LOG(ERROR) << from << " is not a regular file to replace for A/B.";
1838 return false;
1839 }
1840 if (unlink(to) != 0) {
1841 LOG(ERROR) << "Could not unlink " << to << " to move A/B.";
1842 return false;
1843 }
1844 } else {
1845 // This may be a permission problem. We could investigate the error code, but we'll just
1846 // let the rename failure do the work for us.
1847 }
1848
1849 // Try to rename "to" to "from."
1850 if (rename(from, to) != 0) {
1851 PLOG(ERROR) << "Could not rename " << from << " to " << to;
1852 return false;
1853 }
1854 return true;
1855}
1856
1857// Move/rename a B artifact (from) to an A artifact (to).
1858static bool move_ab_path(const std::string& b_path, const std::string& a_path) {
1859 // Check whether B exists.
1860 {
1861 struct stat s;
1862 if (stat(b_path.c_str(), &s) != 0) {
1863 // Silently ignore for now. The service calling this isn't smart enough to understand
1864 // lack of artifacts at the moment.
1865 return false;
1866 }
1867 if (!S_ISREG(s.st_mode)) {
1868 LOG(ERROR) << "A/B artifact " << b_path << " is not a regular file.";
1869 // Try to unlink, but swallow errors.
1870 unlink(b_path.c_str());
1871 return false;
1872 }
1873 }
1874
1875 // Rename B to A.
1876 if (!unlink_and_rename(b_path.c_str(), a_path.c_str())) {
1877 // Delete the b_path so we don't try again (or fail earlier).
1878 if (unlink(b_path.c_str()) != 0) {
1879 PLOG(ERROR) << "Could not unlink " << b_path;
1880 }
1881
1882 return false;
1883 }
1884
1885 return true;
1886}
1887
1888bool move_ab(const char* apk_path, const char* instruction_set, const char* oat_dir) {
1889 // Get the current slot suffix. No suffix, no A/B.
1890 std::string slot_suffix;
1891 {
1892 char buf[kPropertyValueMax];
1893 if (get_property("ro.boot.slot_suffix", buf, nullptr) <= 0) {
1894 return false;
1895 }
1896 slot_suffix = buf;
1897
1898 if (!ValidateTargetSlotSuffix(slot_suffix)) {
1899 LOG(ERROR) << "Target slot suffix not legal: " << slot_suffix;
1900 return false;
1901 }
1902 }
1903
1904 // Validate other inputs.
1905 if (validate_apk_path(apk_path) != 0) {
1906 LOG(ERROR) << "Invalid apk_path: " << apk_path;
1907 return false;
1908 }
1909 if (validate_apk_path(oat_dir) != 0) {
1910 LOG(ERROR) << "Invalid oat_dir: " << oat_dir;
1911 return false;
1912 }
1913
1914 char a_path[PKG_PATH_MAX];
1915 if (!calculate_oat_file_path(a_path, oat_dir, apk_path, instruction_set)) {
1916 return false;
1917 }
1918 const std::string a_vdex_path = create_vdex_filename(a_path);
1919 const std::string a_image_path = create_image_filename(a_path);
1920
1921 // B path = A path + slot suffix.
1922 const std::string b_path = StringPrintf("%s.%s", a_path, slot_suffix.c_str());
1923 const std::string b_vdex_path = StringPrintf("%s.%s", a_vdex_path.c_str(), slot_suffix.c_str());
1924 const std::string b_image_path = StringPrintf("%s.%s",
1925 a_image_path.c_str(),
1926 slot_suffix.c_str());
1927
1928 bool success = true;
1929 if (move_ab_path(b_path, a_path)) {
1930 if (move_ab_path(b_vdex_path, a_vdex_path)) {
1931 // Note: we can live without an app image. As such, ignore failure to move the image file.
1932 // If we decide to require the app image, or the app image being moved correctly,
1933 // then change accordingly.
1934 constexpr bool kIgnoreAppImageFailure = true;
1935
1936 if (!a_image_path.empty()) {
1937 if (!move_ab_path(b_image_path, a_image_path)) {
1938 unlink(a_image_path.c_str());
1939 if (!kIgnoreAppImageFailure) {
1940 success = false;
1941 }
1942 }
1943 }
1944 } else {
1945 // Cleanup: delete B image, ignore errors.
1946 unlink(b_image_path.c_str());
1947 success = false;
1948 }
1949 } else {
1950 // Cleanup: delete B image, ignore errors.
1951 unlink(b_vdex_path.c_str());
1952 unlink(b_image_path.c_str());
1953 success = false;
1954 }
1955 return success;
1956}
1957
1958bool delete_odex(const char* apk_path, const char* instruction_set, const char* oat_dir) {
1959 // Delete the oat/odex file.
1960 char out_path[PKG_PATH_MAX];
Calin Juravle80a21252017-01-17 14:43:25 -08001961 if (!create_oat_out_path(apk_path, instruction_set, oat_dir,
Calin Juravle114f0812017-03-08 19:05:07 -08001962 /*is_secondary_dex*/false, out_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001963 return false;
1964 }
1965
1966 // In case of a permission failure report the issue. Otherwise just print a warning.
1967 auto unlink_and_check = [](const char* path) -> bool {
1968 int result = unlink(path);
1969 if (result != 0) {
1970 if (errno == EACCES || errno == EPERM) {
1971 PLOG(ERROR) << "Could not unlink " << path;
1972 return false;
1973 }
1974 PLOG(WARNING) << "Could not unlink " << path;
1975 }
1976 return true;
1977 };
1978
1979 // Delete the oat/odex file.
1980 bool return_value_oat = unlink_and_check(out_path);
1981
1982 // Derive and delete the app image.
1983 bool return_value_art = unlink_and_check(create_image_filename(out_path).c_str());
1984
Nicolas Geoffray192fb962017-05-25 13:58:06 +01001985 // Derive and delete the vdex file.
1986 bool return_value_vdex = unlink_and_check(create_vdex_filename(out_path).c_str());
1987
Jeff Sharkey90aff262016-12-12 14:28:24 -07001988 // Report success.
Nicolas Geoffray192fb962017-05-25 13:58:06 +01001989 return return_value_oat && return_value_art && return_value_vdex;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001990}
1991
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07001992} // namespace installd
1993} // namespace android