blob: 84008086ccd3f1880e30f62a53f9da4fe3dfd27f [file] [log] [blame]
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07001/*
2 * Copyright (C) 2016 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
Mark Salyzyna5e161b2016-09-29 08:08:05 -070016#define LOG_TAG "installed"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070017
Alan Stokesa25d90c2017-10-16 10:56:00 +010018#include <array>
Jeff Sharkey90aff262016-12-12 14:28:24 -070019#include <fcntl.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070020#include <stdlib.h>
21#include <string.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070022#include <sys/capability.h>
23#include <sys/file.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070024#include <sys/stat.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070025#include <sys/time.h>
26#include <sys/types.h>
27#include <sys/resource.h>
28#include <sys/wait.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070029#include <unistd.h>
30
Alan Stokesa25d90c2017-10-16 10:56:00 +010031#include <android-base/file.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070032#include <android-base/logging.h>
Andreas Gampe6a9cf722017-07-24 16:49:10 -070033#include <android-base/properties.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070034#include <android-base/stringprintf.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070035#include <android-base/strings.h>
36#include <android-base/unique_fd.h>
Calin Juravle80a21252017-01-17 14:43:25 -080037#include <cutils/fs.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070038#include <cutils/properties.h>
39#include <cutils/sched_policy.h>
Mark Salyzyn7823e122016-09-29 08:08:05 -070040#include <log/log.h> // TODO: Move everything to base/logging.
Alan Stokesa25d90c2017-10-16 10:56:00 +010041#include <openssl/sha.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070042#include <private/android_filesystem_config.h>
Calin Juravlecb556e32017-04-04 20:22:50 -070043#include <selinux/android.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070044#include <system/thread_defs.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070045
46#include "dexopt.h"
Jeff Sharkeyc1149c92017-09-21 14:51:09 -060047#include "globals.h"
Jeff Sharkey90aff262016-12-12 14:28:24 -070048#include "installd_deps.h"
49#include "otapreopt_utils.h"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070050#include "utils.h"
51
Jeff Sharkey90aff262016-12-12 14:28:24 -070052using android::base::EndsWith;
Alan Stokesa25d90c2017-10-16 10:56:00 +010053using android::base::ReadFully;
54using android::base::StringPrintf;
55using android::base::WriteFully;
Calin Juravle1a0af3b2017-03-09 14:33:33 -080056using android::base::unique_fd;
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070057
58namespace android {
59namespace installd {
60
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -070061// Should minidebug info be included in compiled artifacts? Even if this value is
62// "true," usage might still be conditional to other constraints, e.g., system
63// property overrides.
64static constexpr bool kEnableMinidebugInfo = true;
65
66static constexpr const char* kMinidebugInfoSystemProperty = "dalvik.vm.dex2oat-minidebuginfo";
67static constexpr bool kMinidebugInfoSystemPropertyDefault = false;
68static constexpr const char* kMinidebugDex2oatFlag = "--generate-mini-debug-info";
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -080069static constexpr const char* kDisableCompactDexFlag = "--compact-dex-level=none";
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -070070
Calin Juravle114f0812017-03-08 19:05:07 -080071// Deleter using free() for use with std::unique_ptr<>. See also UniqueCPtr<> below.
72struct FreeDelete {
73 // NOTE: Deleting a const object is valid but free() takes a non-const pointer.
74 void operator()(const void* ptr) const {
75 free(const_cast<void*>(ptr));
76 }
77};
78
79// Alias for std::unique_ptr<> that uses the C function free() to delete objects.
80template <typename T>
81using UniqueCPtr = std::unique_ptr<T, FreeDelete>;
82
Calin Juravle1a0af3b2017-03-09 14:33:33 -080083static unique_fd invalid_unique_fd() {
84 return unique_fd(-1);
85}
86
Andreas Gampe6a9cf722017-07-24 16:49:10 -070087static bool is_debug_runtime() {
88 return android::base::GetProperty("persist.sys.dalvik.vm.lib.2", "") == "libartd.so";
89}
90
David Sehra3b5ab62017-10-25 14:27:29 -070091static bool is_debuggable_build() {
92 return android::base::GetBoolProperty("ro.debuggable", false);
93}
94
Jeff Sharkey90aff262016-12-12 14:28:24 -070095static bool clear_profile(const std::string& profile) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -080096 unique_fd ufd(open(profile.c_str(), O_WRONLY | O_NOFOLLOW | O_CLOEXEC));
Jeff Sharkey90aff262016-12-12 14:28:24 -070097 if (ufd.get() < 0) {
98 if (errno != ENOENT) {
99 PLOG(WARNING) << "Could not open profile " << profile;
100 return false;
101 } else {
102 // Nothing to clear. That's ok.
103 return true;
104 }
105 }
106
107 if (flock(ufd.get(), LOCK_EX | LOCK_NB) != 0) {
108 if (errno != EWOULDBLOCK) {
109 PLOG(WARNING) << "Error locking profile " << profile;
110 }
111 // This implies that the app owning this profile is running
112 // (and has acquired the lock).
113 //
114 // If we can't acquire the lock bail out since clearing is useless anyway
115 // (the app will write again to the profile).
116 //
117 // Note:
118 // This does not impact the this is not an issue for the profiling correctness.
119 // In case this is needed because of an app upgrade, profiles will still be
120 // eventually cleared by the app itself due to checksum mismatch.
121 // If this is needed because profman advised, then keeping the data around
122 // until the next run is again not an issue.
123 //
124 // If the app attempts to acquire a lock while we've held one here,
125 // it will simply skip the current write cycle.
126 return false;
127 }
128
129 bool truncated = ftruncate(ufd.get(), 0) == 0;
130 if (!truncated) {
131 PLOG(WARNING) << "Could not truncate " << profile;
132 }
133 if (flock(ufd.get(), LOCK_UN) != 0) {
134 PLOG(WARNING) << "Error unlocking profile " << profile;
135 }
136 return truncated;
137}
138
Calin Juravle114f0812017-03-08 19:05:07 -0800139// Clear the reference profile for the given location.
Calin Juravle824a64d2018-01-18 20:23:17 -0800140// The location is the profile name for primary apks or the dex path for secondary dex files.
141static bool clear_reference_profile(const std::string& package_name, const std::string& location,
142 bool is_secondary_dex) {
143 return clear_profile(create_reference_profile_path(package_name, location, is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700144}
145
Calin Juravle114f0812017-03-08 19:05:07 -0800146// Clear the reference profile for the given location.
Calin Juravle824a64d2018-01-18 20:23:17 -0800147// The location is the profile name for primary apks or the dex path for secondary dex files.
148static bool clear_current_profile(const std::string& package_name, const std::string& location,
149 userid_t user, bool is_secondary_dex) {
150 return clear_profile(create_current_profile_path(user, package_name, location,
151 is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700152}
153
Calin Juravle114f0812017-03-08 19:05:07 -0800154// Clear the reference profile for the primary apk of the given package.
Calin Juravle824a64d2018-01-18 20:23:17 -0800155// The location is the profile name for primary apks or the dex path for secondary dex files.
156bool clear_primary_reference_profile(const std::string& package_name,
157 const std::string& location) {
158 return clear_reference_profile(package_name, location, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800159}
160
161// Clear all current profile for the primary apk of the given package.
Calin Juravle824a64d2018-01-18 20:23:17 -0800162// The location is the profile name for primary apks or the dex path for secondary dex files.
163bool clear_primary_current_profiles(const std::string& package_name, const std::string& location) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700164 bool success = true;
Calin Juravle114f0812017-03-08 19:05:07 -0800165 // For secondary dex files, we don't really need the user but we use it for sanity checks.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700166 std::vector<userid_t> users = get_known_users(/*volume_uuid*/ nullptr);
167 for (auto user : users) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800168 success &= clear_current_profile(package_name, location, user, /*is_secondary_dex*/false);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700169 }
170 return success;
171}
172
Calin Juravle114f0812017-03-08 19:05:07 -0800173// Clear the current profile for the primary apk of the given package and user.
Calin Juravle824a64d2018-01-18 20:23:17 -0800174bool clear_primary_current_profile(const std::string& package_name, const std::string& location,
175 userid_t user) {
176 return clear_current_profile(package_name, location, user, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800177}
178
Jeff Sharkey90aff262016-12-12 14:28:24 -0700179static int split_count(const char *str)
180{
181 char *ctx;
182 int count = 0;
183 char buf[kPropertyValueMax];
184
Jeff Sharkeyc1149c92017-09-21 14:51:09 -0600185 strlcpy(buf, str, sizeof(buf));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700186 char *pBuf = buf;
187
188 while(strtok_r(pBuf, " ", &ctx) != NULL) {
189 count++;
190 pBuf = NULL;
191 }
192
193 return count;
194}
195
196static int split(char *buf, const char **argv)
197{
198 char *ctx;
199 int count = 0;
200 char *tok;
201 char *pBuf = buf;
202
203 while((tok = strtok_r(pBuf, " ", &ctx)) != NULL) {
204 argv[count++] = tok;
205 pBuf = NULL;
206 }
207
208 return count;
209}
210
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700211static const char* get_location_from_path(const char* path) {
212 static constexpr char kLocationSeparator = '/';
213 const char *location = strrchr(path, kLocationSeparator);
214 if (location == NULL) {
215 return path;
216 } else {
217 // Skip the separator character.
218 return location + 1;
219 }
220}
221
Jeff Sharkey90aff262016-12-12 14:28:24 -0700222static void run_dex2oat(int zip_fd, int oat_fd, int input_vdex_fd, int output_vdex_fd, int image_fd,
223 const char* input_file_name, const char* output_file_name, int swap_fd,
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100224 const char* instruction_set, const char* compiler_filter,
Andreas Gampea73a0cb2017-11-02 18:14:42 -0700225 bool debuggable, bool post_bootcomplete, bool background_job_compile, int profile_fd,
David Brazdil52249162018-02-12 18:04:59 -0800226 const char* class_loader_context, int target_sdk_version, bool enable_hidden_api_checks) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700227 static const unsigned int MAX_INSTRUCTION_SET_LEN = 7;
228
229 if (strlen(instruction_set) >= MAX_INSTRUCTION_SET_LEN) {
230 ALOGE("Instruction set %s longer than max length of %d",
231 instruction_set, MAX_INSTRUCTION_SET_LEN);
232 return;
233 }
234
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700235 // Get the relative path to the input file.
236 const char* relative_input_file_name = get_location_from_path(input_file_name);
237
Jeff Sharkey90aff262016-12-12 14:28:24 -0700238 char dex2oat_Xms_flag[kPropertyValueMax];
239 bool have_dex2oat_Xms_flag = get_property("dalvik.vm.dex2oat-Xms", dex2oat_Xms_flag, NULL) > 0;
240
241 char dex2oat_Xmx_flag[kPropertyValueMax];
242 bool have_dex2oat_Xmx_flag = get_property("dalvik.vm.dex2oat-Xmx", dex2oat_Xmx_flag, NULL) > 0;
243
244 char dex2oat_threads_buf[kPropertyValueMax];
245 bool have_dex2oat_threads_flag = get_property(post_bootcomplete
246 ? "dalvik.vm.dex2oat-threads"
247 : "dalvik.vm.boot-dex2oat-threads",
248 dex2oat_threads_buf,
249 NULL) > 0;
250 char dex2oat_threads_arg[kPropertyValueMax + 2];
251 if (have_dex2oat_threads_flag) {
252 sprintf(dex2oat_threads_arg, "-j%s", dex2oat_threads_buf);
253 }
254
255 char dex2oat_isa_features_key[kPropertyKeyMax];
256 sprintf(dex2oat_isa_features_key, "dalvik.vm.isa.%s.features", instruction_set);
257 char dex2oat_isa_features[kPropertyValueMax];
258 bool have_dex2oat_isa_features = get_property(dex2oat_isa_features_key,
259 dex2oat_isa_features, NULL) > 0;
260
261 char dex2oat_isa_variant_key[kPropertyKeyMax];
262 sprintf(dex2oat_isa_variant_key, "dalvik.vm.isa.%s.variant", instruction_set);
263 char dex2oat_isa_variant[kPropertyValueMax];
264 bool have_dex2oat_isa_variant = get_property(dex2oat_isa_variant_key,
265 dex2oat_isa_variant, NULL) > 0;
266
267 const char *dex2oat_norelocation = "-Xnorelocate";
268 bool have_dex2oat_relocation_skip_flag = false;
269
270 char dex2oat_flags[kPropertyValueMax];
271 int dex2oat_flags_count = get_property("dalvik.vm.dex2oat-flags",
272 dex2oat_flags, NULL) <= 0 ? 0 : split_count(dex2oat_flags);
273 ALOGV("dalvik.vm.dex2oat-flags=%s\n", dex2oat_flags);
274
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100275 // If we are booting without the real /data, don't spend time compiling.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700276 char vold_decrypt[kPropertyValueMax];
277 bool have_vold_decrypt = get_property("vold.decrypt", vold_decrypt, "") > 0;
278 bool skip_compilation = (have_vold_decrypt &&
279 (strcmp(vold_decrypt, "trigger_restart_min_framework") == 0 ||
280 (strcmp(vold_decrypt, "1") == 0)));
281
282 bool generate_debug_info = property_get_bool("debug.generate-debug-info", false);
283
284 char app_image_format[kPropertyValueMax];
285 char image_format_arg[strlen("--image-format=") + kPropertyValueMax];
286 bool have_app_image_format =
287 image_fd >= 0 && get_property("dalvik.vm.appimageformat", app_image_format, NULL) > 0;
288 if (have_app_image_format) {
289 sprintf(image_format_arg, "--image-format=%s", app_image_format);
290 }
291
292 char dex2oat_large_app_threshold[kPropertyValueMax];
293 bool have_dex2oat_large_app_threshold =
294 get_property("dalvik.vm.dex2oat-very-large", dex2oat_large_app_threshold, NULL) > 0;
295 char dex2oat_large_app_threshold_arg[strlen("--very-large-app-threshold=") + kPropertyValueMax];
296 if (have_dex2oat_large_app_threshold) {
297 sprintf(dex2oat_large_app_threshold_arg,
298 "--very-large-app-threshold=%s",
299 dex2oat_large_app_threshold);
300 }
301
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700302 // If the runtime was requested to use libartd.so, we'll run dex2oatd, otherwise dex2oat.
David Sehra3b5ab62017-10-25 14:27:29 -0700303 const char* dex2oat_bin = "/system/bin/dex2oat";
304 static const char* kDex2oatDebugPath = "/system/bin/dex2oatd";
Andreas Gampea73a0cb2017-11-02 18:14:42 -0700305 if (is_debug_runtime() || (background_job_compile && is_debuggable_build())) {
David Sehra3b5ab62017-10-25 14:27:29 -0700306 DCHECK(access(kDex2oatDebugPath, X_OK) == 0);
307 dex2oat_bin = kDex2oatDebugPath;
308 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700309
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -0700310 bool generate_minidebug_info = kEnableMinidebugInfo &&
311 android::base::GetBoolProperty(kMinidebugInfoSystemProperty,
312 kMinidebugInfoSystemPropertyDefault);
313
Jeff Sharkey90aff262016-12-12 14:28:24 -0700314 static const char* RUNTIME_ARG = "--runtime-arg";
315
316 static const int MAX_INT_LEN = 12; // '-'+10dig+'\0' -OR- 0x+8dig
317
George Burgess IV36cebe772017-01-25 11:52:01 -0800318 // clang FORTIFY doesn't let us use strlen in constant array bounds, so we
319 // use arraysize instead.
320 char zip_fd_arg[arraysize("--zip-fd=") + MAX_INT_LEN];
321 char zip_location_arg[arraysize("--zip-location=") + PKG_PATH_MAX];
322 char input_vdex_fd_arg[arraysize("--input-vdex-fd=") + MAX_INT_LEN];
323 char output_vdex_fd_arg[arraysize("--output-vdex-fd=") + MAX_INT_LEN];
324 char oat_fd_arg[arraysize("--oat-fd=") + MAX_INT_LEN];
325 char oat_location_arg[arraysize("--oat-location=") + PKG_PATH_MAX];
326 char instruction_set_arg[arraysize("--instruction-set=") + MAX_INSTRUCTION_SET_LEN];
327 char instruction_set_variant_arg[arraysize("--instruction-set-variant=") + kPropertyValueMax];
328 char instruction_set_features_arg[arraysize("--instruction-set-features=") + kPropertyValueMax];
329 char dex2oat_Xms_arg[arraysize("-Xms") + kPropertyValueMax];
330 char dex2oat_Xmx_arg[arraysize("-Xmx") + kPropertyValueMax];
331 char dex2oat_compiler_filter_arg[arraysize("--compiler-filter=") + kPropertyValueMax];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700332 bool have_dex2oat_swap_fd = false;
George Burgess IV36cebe772017-01-25 11:52:01 -0800333 char dex2oat_swap_fd[arraysize("--swap-fd=") + MAX_INT_LEN];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700334 bool have_dex2oat_image_fd = false;
George Burgess IV36cebe772017-01-25 11:52:01 -0800335 char dex2oat_image_fd[arraysize("--app-image-fd=") + MAX_INT_LEN];
Calin Juravle52c45822017-07-13 22:50:21 -0700336 size_t class_loader_context_size = arraysize("--class-loader-context=") + PKG_PATH_MAX;
David Brazdil570d3982018-01-16 20:15:43 +0000337 char target_sdk_version_arg[arraysize("-Xtarget-sdk-version:") + MAX_INT_LEN];
Calin Juravle52c45822017-07-13 22:50:21 -0700338 char class_loader_context_arg[class_loader_context_size];
339 if (class_loader_context != nullptr) {
340 snprintf(class_loader_context_arg, class_loader_context_size, "--class-loader-context=%s",
341 class_loader_context);
342 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700343
344 sprintf(zip_fd_arg, "--zip-fd=%d", zip_fd);
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700345 sprintf(zip_location_arg, "--zip-location=%s", relative_input_file_name);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700346 sprintf(input_vdex_fd_arg, "--input-vdex-fd=%d", input_vdex_fd);
347 sprintf(output_vdex_fd_arg, "--output-vdex-fd=%d", output_vdex_fd);
348 sprintf(oat_fd_arg, "--oat-fd=%d", oat_fd);
349 sprintf(oat_location_arg, "--oat-location=%s", output_file_name);
350 sprintf(instruction_set_arg, "--instruction-set=%s", instruction_set);
351 sprintf(instruction_set_variant_arg, "--instruction-set-variant=%s", dex2oat_isa_variant);
352 sprintf(instruction_set_features_arg, "--instruction-set-features=%s", dex2oat_isa_features);
353 if (swap_fd >= 0) {
354 have_dex2oat_swap_fd = true;
355 sprintf(dex2oat_swap_fd, "--swap-fd=%d", swap_fd);
356 }
357 if (image_fd >= 0) {
358 have_dex2oat_image_fd = true;
359 sprintf(dex2oat_image_fd, "--app-image-fd=%d", image_fd);
360 }
361
362 if (have_dex2oat_Xms_flag) {
363 sprintf(dex2oat_Xms_arg, "-Xms%s", dex2oat_Xms_flag);
364 }
365 if (have_dex2oat_Xmx_flag) {
366 sprintf(dex2oat_Xmx_arg, "-Xmx%s", dex2oat_Xmx_flag);
367 }
David Brazdil570d3982018-01-16 20:15:43 +0000368 sprintf(target_sdk_version_arg, "-Xtarget-sdk-version:%d", target_sdk_version);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700369
370 // Compute compiler filter.
371
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100372 bool have_dex2oat_compiler_filter_flag = false;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700373 if (skip_compilation) {
Jeff Sharkeyc1149c92017-09-21 14:51:09 -0600374 strlcpy(dex2oat_compiler_filter_arg, "--compiler-filter=extract",
375 sizeof(dex2oat_compiler_filter_arg));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700376 have_dex2oat_compiler_filter_flag = true;
377 have_dex2oat_relocation_skip_flag = true;
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100378 } else if (compiler_filter != nullptr) {
379 if (strlen(compiler_filter) + strlen("--compiler-filter=") <
Jeff Sharkey90aff262016-12-12 14:28:24 -0700380 arraysize(dex2oat_compiler_filter_arg)) {
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100381 sprintf(dex2oat_compiler_filter_arg, "--compiler-filter=%s", compiler_filter);
382 have_dex2oat_compiler_filter_flag = true;
383 } else {
384 ALOGW("Compiler filter name '%s' is too large (max characters is %zu)",
385 compiler_filter,
386 kPropertyValueMax);
387 }
388 }
389
390 if (!have_dex2oat_compiler_filter_flag) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700391 char dex2oat_compiler_filter_flag[kPropertyValueMax];
392 have_dex2oat_compiler_filter_flag = get_property("dalvik.vm.dex2oat-filter",
393 dex2oat_compiler_filter_flag, NULL) > 0;
394 if (have_dex2oat_compiler_filter_flag) {
395 sprintf(dex2oat_compiler_filter_arg,
396 "--compiler-filter=%s",
397 dex2oat_compiler_filter_flag);
398 }
399 }
400
401 // Check whether all apps should be compiled debuggable.
402 if (!debuggable) {
403 char prop_buf[kPropertyValueMax];
404 debuggable =
405 (get_property("dalvik.vm.always_debuggable", prop_buf, "0") > 0) &&
406 (prop_buf[0] == '1');
407 }
408 char profile_arg[strlen("--profile-file-fd=") + MAX_INT_LEN];
409 if (profile_fd != -1) {
410 sprintf(profile_arg, "--profile-file-fd=%d", profile_fd);
411 }
412
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700413 // Get the directory of the apk to pass as a base classpath directory.
414 char base_dir[arraysize("--classpath-dir=") + PKG_PATH_MAX];
415 std::string apk_dir(input_file_name);
416 unsigned long dir_index = apk_dir.rfind('/');
417 bool has_base_dir = dir_index != std::string::npos;
418 if (has_base_dir) {
419 apk_dir = apk_dir.substr(0, dir_index);
420 sprintf(base_dir, "--classpath-dir=%s", apk_dir.c_str());
421 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700422
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700423
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700424 ALOGV("Running %s in=%s out=%s\n", dex2oat_bin, relative_input_file_name, output_file_name);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700425
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800426 // Disable cdex if update input vdex is true since this combination of options is not
427 // supported.
Mathieu Chartier1fb463e2018-01-09 15:16:10 -0800428 // Disable cdex for non-background compiles since we don't want to regress app install until
429 // there are enough benefits to justify the tradeoff.
430 const bool disable_cdex = !background_job_compile || (input_vdex_fd == output_vdex_fd);
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800431
Jeff Sharkey90aff262016-12-12 14:28:24 -0700432 const char* argv[9 // program name, mandatory arguments and the final NULL
433 + (have_dex2oat_isa_variant ? 1 : 0)
434 + (have_dex2oat_isa_features ? 1 : 0)
435 + (have_dex2oat_Xms_flag ? 2 : 0)
436 + (have_dex2oat_Xmx_flag ? 2 : 0)
437 + (have_dex2oat_compiler_filter_flag ? 1 : 0)
438 + (have_dex2oat_threads_flag ? 1 : 0)
439 + (have_dex2oat_swap_fd ? 1 : 0)
440 + (have_dex2oat_image_fd ? 1 : 0)
441 + (have_dex2oat_relocation_skip_flag ? 2 : 0)
442 + (generate_debug_info ? 1 : 0)
443 + (debuggable ? 1 : 0)
444 + (have_app_image_format ? 1 : 0)
445 + dex2oat_flags_count
446 + (profile_fd == -1 ? 0 : 1)
Calin Juravle52c45822017-07-13 22:50:21 -0700447 + (class_loader_context != nullptr ? 1 : 0)
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700448 + (has_base_dir ? 1 : 0)
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -0700449 + (have_dex2oat_large_app_threshold ? 1 : 0)
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800450 + (disable_cdex ? 1 : 0)
David Brazdil570d3982018-01-16 20:15:43 +0000451 + (generate_minidebug_info ? 1 : 0)
David Brazdil7fcbb812018-01-17 17:05:40 +0000452 + (target_sdk_version != 0 ? 2 : 0)
David Brazdil52249162018-02-12 18:04:59 -0800453 + (enable_hidden_api_checks ? 2 : 0)];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700454 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700455 argv[i++] = dex2oat_bin;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700456 argv[i++] = zip_fd_arg;
457 argv[i++] = zip_location_arg;
458 argv[i++] = input_vdex_fd_arg;
459 argv[i++] = output_vdex_fd_arg;
460 argv[i++] = oat_fd_arg;
461 argv[i++] = oat_location_arg;
462 argv[i++] = instruction_set_arg;
463 if (have_dex2oat_isa_variant) {
464 argv[i++] = instruction_set_variant_arg;
465 }
466 if (have_dex2oat_isa_features) {
467 argv[i++] = instruction_set_features_arg;
468 }
469 if (have_dex2oat_Xms_flag) {
470 argv[i++] = RUNTIME_ARG;
471 argv[i++] = dex2oat_Xms_arg;
472 }
473 if (have_dex2oat_Xmx_flag) {
474 argv[i++] = RUNTIME_ARG;
475 argv[i++] = dex2oat_Xmx_arg;
476 }
477 if (have_dex2oat_compiler_filter_flag) {
478 argv[i++] = dex2oat_compiler_filter_arg;
479 }
480 if (have_dex2oat_threads_flag) {
481 argv[i++] = dex2oat_threads_arg;
482 }
483 if (have_dex2oat_swap_fd) {
484 argv[i++] = dex2oat_swap_fd;
485 }
486 if (have_dex2oat_image_fd) {
487 argv[i++] = dex2oat_image_fd;
488 }
489 if (generate_debug_info) {
490 argv[i++] = "--generate-debug-info";
491 }
492 if (debuggable) {
493 argv[i++] = "--debuggable";
494 }
495 if (have_app_image_format) {
496 argv[i++] = image_format_arg;
497 }
498 if (have_dex2oat_large_app_threshold) {
499 argv[i++] = dex2oat_large_app_threshold_arg;
500 }
501 if (dex2oat_flags_count) {
502 i += split(dex2oat_flags, argv + i);
503 }
504 if (have_dex2oat_relocation_skip_flag) {
505 argv[i++] = RUNTIME_ARG;
506 argv[i++] = dex2oat_norelocation;
507 }
508 if (profile_fd != -1) {
509 argv[i++] = profile_arg;
510 }
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700511 if (has_base_dir) {
512 argv[i++] = base_dir;
513 }
Calin Juravle52c45822017-07-13 22:50:21 -0700514 if (class_loader_context != nullptr) {
515 argv[i++] = class_loader_context_arg;
516 }
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -0700517 if (generate_minidebug_info) {
518 argv[i++] = kMinidebugDex2oatFlag;
519 }
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800520 if (disable_cdex) {
521 argv[i++] = kDisableCompactDexFlag;
522 }
David Brazdil570d3982018-01-16 20:15:43 +0000523 if (target_sdk_version != 0) {
524 argv[i++] = RUNTIME_ARG;
525 argv[i++] = target_sdk_version_arg;
526 }
David Brazdil52249162018-02-12 18:04:59 -0800527 if (enable_hidden_api_checks) {
David Brazdil7fcbb812018-01-17 17:05:40 +0000528 argv[i++] = RUNTIME_ARG;
David Brazdil52249162018-02-12 18:04:59 -0800529 argv[i++] = "-Xhidden-api-checks";
David Brazdil7fcbb812018-01-17 17:05:40 +0000530 }
Calin Juravle52c45822017-07-13 22:50:21 -0700531
Jeff Sharkey90aff262016-12-12 14:28:24 -0700532 // Do not add after dex2oat_flags, they should override others for debugging.
533 argv[i] = NULL;
534
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700535 execv(dex2oat_bin, (char * const *)argv);
536 ALOGE("execv(%s) failed: %s\n", dex2oat_bin, strerror(errno));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700537}
538
539/*
540 * Whether dexopt should use a swap file when compiling an APK.
541 *
542 * If kAlwaysProvideSwapFile, do this on all devices (dex2oat will make a more informed decision
543 * itself, anyways).
544 *
545 * Otherwise, read "dalvik.vm.dex2oat-swap". If the property exists, return whether it is "true".
546 *
547 * Otherwise, return true if this is a low-mem device.
548 *
549 * Otherwise, return default value.
550 */
551static bool kAlwaysProvideSwapFile = false;
552static bool kDefaultProvideSwapFile = true;
553
554static bool ShouldUseSwapFileForDexopt() {
555 if (kAlwaysProvideSwapFile) {
556 return true;
557 }
558
559 // Check the "override" property. If it exists, return value == "true".
560 char dex2oat_prop_buf[kPropertyValueMax];
561 if (get_property("dalvik.vm.dex2oat-swap", dex2oat_prop_buf, "") > 0) {
562 if (strcmp(dex2oat_prop_buf, "true") == 0) {
563 return true;
564 } else {
565 return false;
566 }
567 }
568
569 // Shortcut for default value. This is an implementation optimization for the process sketched
570 // above. If the default value is true, we can avoid to check whether this is a low-mem device,
571 // as low-mem is never returning false. The compiler will optimize this away if it can.
572 if (kDefaultProvideSwapFile) {
573 return true;
574 }
575
576 bool is_low_mem = property_get_bool("ro.config.low_ram", false);
577 if (is_low_mem) {
578 return true;
579 }
580
581 // Default value must be false here.
582 return kDefaultProvideSwapFile;
583}
584
Richard Uhler76cc0272016-12-08 10:46:35 +0000585static void SetDex2OatScheduling(bool set_to_bg) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700586 if (set_to_bg) {
587 if (set_sched_policy(0, SP_BACKGROUND) < 0) {
588 ALOGE("set_sched_policy failed: %s\n", strerror(errno));
589 exit(70);
590 }
591 if (setpriority(PRIO_PROCESS, 0, ANDROID_PRIORITY_BACKGROUND) < 0) {
592 ALOGE("setpriority failed: %s\n", strerror(errno));
593 exit(71);
594 }
595 }
596}
597
Calin Juravle29591732017-11-20 17:46:19 -0800598static unique_fd create_profile(uid_t uid, const std::string& profile, int32_t flags) {
599 unique_fd fd(TEMP_FAILURE_RETRY(open(profile.c_str(), flags, 0600)));
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800600 if (fd.get() < 0) {
Calin Juravle29591732017-11-20 17:46:19 -0800601 if (errno != EEXIST) {
Calin Juravle114f0812017-03-08 19:05:07 -0800602 PLOG(ERROR) << "Failed to create profile " << profile;
Calin Juravle29591732017-11-20 17:46:19 -0800603 return invalid_unique_fd();
Calin Juravle114f0812017-03-08 19:05:07 -0800604 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700605 }
Calin Juravle114f0812017-03-08 19:05:07 -0800606 // Profiles should belong to the app; make sure of that by giving ownership to
607 // the app uid. If we cannot do that, there's no point in returning the fd
608 // since dex2oat/profman will fail with SElinux denials.
609 if (fchown(fd.get(), uid, uid) < 0) {
610 PLOG(ERROR) << "Could not chwon profile " << profile;
Calin Juravle29591732017-11-20 17:46:19 -0800611 return invalid_unique_fd();
Calin Juravle114f0812017-03-08 19:05:07 -0800612 }
Calin Juravle29591732017-11-20 17:46:19 -0800613 return fd;
Calin Juravle114f0812017-03-08 19:05:07 -0800614}
615
Calin Juravle29591732017-11-20 17:46:19 -0800616static unique_fd open_profile(uid_t uid, const std::string& profile, int32_t flags) {
Calin Juravle114f0812017-03-08 19:05:07 -0800617 // Do not follow symlinks when opening a profile:
618 // - primary profiles should not contain symlinks in their paths
619 // - secondary dex paths should have been already resolved and validated
620 flags |= O_NOFOLLOW;
621
Calin Juravle29591732017-11-20 17:46:19 -0800622 // Check if we need to create the profile
623 // Reference profiles and snapshots are created on the fly; so they might not exist beforehand.
624 unique_fd fd;
625 if ((flags & O_CREAT) != 0) {
626 fd = create_profile(uid, profile, flags);
627 } else {
628 fd.reset(TEMP_FAILURE_RETRY(open(profile.c_str(), flags)));
629 }
630
Calin Juravle114f0812017-03-08 19:05:07 -0800631 if (fd.get() < 0) {
632 if (errno != ENOENT) {
633 // Profiles might be missing for various reasons. For example, in a
634 // multi-user environment, the profile directory for one user can be created
635 // after we start a merge. In this case the current profile for that user
636 // will not be found.
637 // Also, the secondary dex profiles might be deleted by the app at any time,
638 // so we can't we need to prepare if they are missing.
639 PLOG(ERROR) << "Failed to open profile " << profile;
640 }
641 return invalid_unique_fd();
642 }
643
Jeff Sharkey90aff262016-12-12 14:28:24 -0700644 return fd;
645}
646
Calin Juravle824a64d2018-01-18 20:23:17 -0800647static unique_fd open_current_profile(uid_t uid, userid_t user, const std::string& package_name,
648 const std::string& location, bool is_secondary_dex) {
649 std::string profile = create_current_profile_path(user, package_name, location,
650 is_secondary_dex);
Calin Juravle29591732017-11-20 17:46:19 -0800651 return open_profile(uid, profile, O_RDONLY);
Calin Juravle114f0812017-03-08 19:05:07 -0800652}
653
Calin Juravle824a64d2018-01-18 20:23:17 -0800654static unique_fd open_reference_profile(uid_t uid, const std::string& package_name,
655 const std::string& location, bool read_write, bool is_secondary_dex) {
656 std::string profile = create_reference_profile_path(package_name, location, is_secondary_dex);
Calin Juravle29591732017-11-20 17:46:19 -0800657 return open_profile(uid, profile, read_write ? (O_CREAT | O_RDWR) : O_RDONLY);
658}
659
660static unique_fd open_spnashot_profile(uid_t uid, const std::string& package_name,
Calin Juravle824a64d2018-01-18 20:23:17 -0800661 const std::string& location) {
662 std::string profile = create_snapshot_profile_path(package_name, location);
Calin Juravle29591732017-11-20 17:46:19 -0800663 return open_profile(uid, profile, O_CREAT | O_RDWR | O_TRUNC);
Calin Juravle114f0812017-03-08 19:05:07 -0800664}
665
Calin Juravle824a64d2018-01-18 20:23:17 -0800666static void open_profile_files(uid_t uid, const std::string& package_name,
667 const std::string& location, bool is_secondary_dex,
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800668 /*out*/ std::vector<unique_fd>* profiles_fd, /*out*/ unique_fd* reference_profile_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700669 // Open the reference profile in read-write mode as profman might need to save the merge.
Calin Juravle824a64d2018-01-18 20:23:17 -0800670 *reference_profile_fd = open_reference_profile(uid, package_name, location,
671 /*read_write*/ true, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700672
Calin Juravle114f0812017-03-08 19:05:07 -0800673 // For secondary dex files, we don't really need the user but we use it for sanity checks.
674 // Note: the user owning the dex file should be the current user.
675 std::vector<userid_t> users;
676 if (is_secondary_dex){
677 users.push_back(multiuser_get_user_id(uid));
678 } else {
679 users = get_known_users(/*volume_uuid*/ nullptr);
680 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700681 for (auto user : users) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800682 unique_fd profile_fd = open_current_profile(uid, user, package_name, location,
683 is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700684 // Add to the lists only if both fds are valid.
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800685 if (profile_fd.get() >= 0) {
686 profiles_fd->push_back(std::move(profile_fd));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700687 }
688 }
689}
690
691static void drop_capabilities(uid_t uid) {
692 if (setgid(uid) != 0) {
693 ALOGE("setgid(%d) failed in installd during dexopt\n", uid);
694 exit(64);
695 }
696 if (setuid(uid) != 0) {
697 ALOGE("setuid(%d) failed in installd during dexopt\n", uid);
698 exit(65);
699 }
700 // drop capabilities
701 struct __user_cap_header_struct capheader;
702 struct __user_cap_data_struct capdata[2];
703 memset(&capheader, 0, sizeof(capheader));
704 memset(&capdata, 0, sizeof(capdata));
705 capheader.version = _LINUX_CAPABILITY_VERSION_3;
706 if (capset(&capheader, &capdata[0]) < 0) {
707 ALOGE("capset failed: %s\n", strerror(errno));
708 exit(66);
709 }
710}
711
712static constexpr int PROFMAN_BIN_RETURN_CODE_COMPILE = 0;
713static constexpr int PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION = 1;
714static constexpr int PROFMAN_BIN_RETURN_CODE_BAD_PROFILES = 2;
715static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_IO = 3;
716static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING = 4;
717
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800718static void run_profman_merge(const std::vector<unique_fd>& profiles_fd,
719 const unique_fd& reference_profile_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700720 static const size_t MAX_INT_LEN = 32;
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700721 const char* profman_bin = is_debug_runtime() ? "/system/bin/profmand" : "/system/bin/profman";
Jeff Sharkey90aff262016-12-12 14:28:24 -0700722
723 std::vector<std::string> profile_args(profiles_fd.size());
724 char profile_buf[strlen("--profile-file-fd=") + MAX_INT_LEN];
725 for (size_t k = 0; k < profiles_fd.size(); k++) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800726 sprintf(profile_buf, "--profile-file-fd=%d", profiles_fd[k].get());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700727 profile_args[k].assign(profile_buf);
728 }
729 char reference_profile_arg[strlen("--reference-profile-file-fd=") + MAX_INT_LEN];
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800730 sprintf(reference_profile_arg, "--reference-profile-file-fd=%d", reference_profile_fd.get());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700731
732 // program name, reference profile fd, the final NULL and the profile fds
733 const char* argv[3 + profiles_fd.size()];
734 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700735 argv[i++] = profman_bin;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700736 argv[i++] = reference_profile_arg;
737 for (size_t k = 0; k < profile_args.size(); k++) {
738 argv[i++] = profile_args[k].c_str();
739 }
740 // Do not add after dex2oat_flags, they should override others for debugging.
741 argv[i] = NULL;
742
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700743 execv(profman_bin, (char * const *)argv);
744 ALOGE("execv(%s) failed: %s\n", profman_bin, strerror(errno));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700745 exit(68); /* only get here on exec failure */
746}
747
748// Decides if profile guided compilation is needed or not based on existing profiles.
Calin Juravle114f0812017-03-08 19:05:07 -0800749// The location is the package name for primary apks or the dex path for secondary dex files.
750// Returns true if there is enough information in the current profiles that makes it
751// worth to recompile the given location.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700752// If the return value is true all the current profiles would have been merged into
753// the reference profiles accessible with open_reference_profile().
Calin Juravle824a64d2018-01-18 20:23:17 -0800754static bool analyze_profiles(uid_t uid, const std::string& package_name,
755 const std::string& location, bool is_secondary_dex) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800756 std::vector<unique_fd> profiles_fd;
757 unique_fd reference_profile_fd;
Calin Juravle824a64d2018-01-18 20:23:17 -0800758 open_profile_files(uid, package_name, location, is_secondary_dex,
759 &profiles_fd, &reference_profile_fd);
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800760 if (profiles_fd.empty() || (reference_profile_fd.get() < 0)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700761 // Skip profile guided compilation because no profiles were found.
762 // Or if the reference profile info couldn't be opened.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700763 return false;
764 }
765
Jeff Sharkey90aff262016-12-12 14:28:24 -0700766 pid_t pid = fork();
767 if (pid == 0) {
768 /* child -- drop privileges before continuing */
769 drop_capabilities(uid);
770 run_profman_merge(profiles_fd, reference_profile_fd);
771 exit(68); /* only get here on exec failure */
772 }
773 /* parent */
774 int return_code = wait_child(pid);
775 bool need_to_compile = false;
776 bool should_clear_current_profiles = false;
777 bool should_clear_reference_profile = false;
778 if (!WIFEXITED(return_code)) {
Calin Juravle114f0812017-03-08 19:05:07 -0800779 LOG(WARNING) << "profman failed for location " << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700780 } else {
781 return_code = WEXITSTATUS(return_code);
782 switch (return_code) {
783 case PROFMAN_BIN_RETURN_CODE_COMPILE:
784 need_to_compile = true;
785 should_clear_current_profiles = true;
786 should_clear_reference_profile = false;
787 break;
788 case PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION:
789 need_to_compile = false;
790 should_clear_current_profiles = false;
791 should_clear_reference_profile = false;
792 break;
793 case PROFMAN_BIN_RETURN_CODE_BAD_PROFILES:
Calin Juravle114f0812017-03-08 19:05:07 -0800794 LOG(WARNING) << "Bad profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700795 need_to_compile = false;
796 should_clear_current_profiles = true;
797 should_clear_reference_profile = true;
798 break;
799 case PROFMAN_BIN_RETURN_CODE_ERROR_IO: // fall-through
800 case PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING:
801 // Temporary IO problem (e.g. locking). Ignore but log a warning.
Calin Juravle114f0812017-03-08 19:05:07 -0800802 LOG(WARNING) << "IO error while reading profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700803 need_to_compile = false;
804 should_clear_current_profiles = false;
805 should_clear_reference_profile = false;
806 break;
807 default:
808 // Unknown return code or error. Unlink profiles.
Calin Juravle114f0812017-03-08 19:05:07 -0800809 LOG(WARNING) << "Unknown error code while processing profiles for location "
810 << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700811 need_to_compile = false;
812 should_clear_current_profiles = true;
813 should_clear_reference_profile = true;
814 break;
815 }
816 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800817
Jeff Sharkey90aff262016-12-12 14:28:24 -0700818 if (should_clear_current_profiles) {
Calin Juravle114f0812017-03-08 19:05:07 -0800819 if (is_secondary_dex) {
820 // For secondary dex files, the owning user is the current user.
Calin Juravle824a64d2018-01-18 20:23:17 -0800821 clear_current_profile(package_name, location, multiuser_get_user_id(uid),
822 is_secondary_dex);
Calin Juravle114f0812017-03-08 19:05:07 -0800823 } else {
Calin Juravle824a64d2018-01-18 20:23:17 -0800824 clear_primary_current_profiles(package_name, location);
Calin Juravle114f0812017-03-08 19:05:07 -0800825 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700826 }
827 if (should_clear_reference_profile) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800828 clear_reference_profile(package_name, location, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700829 }
830 return need_to_compile;
831}
832
Calin Juravle114f0812017-03-08 19:05:07 -0800833// Decides if profile guided compilation is needed or not based on existing profiles.
834// The analysis is done for the primary apks of the given package.
835// Returns true if there is enough information in the current profiles that makes it
836// worth to recompile the package.
837// If the return value is true all the current profiles would have been merged into
838// the reference profiles accessible with open_reference_profile().
Calin Juravle824a64d2018-01-18 20:23:17 -0800839bool analyze_primary_profiles(uid_t uid, const std::string& package_name,
840 const std::string& profile_name) {
841 return analyze_profiles(uid, package_name, profile_name, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800842}
843
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800844static void run_profman_dump(const std::vector<unique_fd>& profile_fds,
845 const unique_fd& reference_profile_fd,
Jeff Sharkey90aff262016-12-12 14:28:24 -0700846 const std::vector<std::string>& dex_locations,
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800847 const std::vector<unique_fd>& apk_fds,
848 const unique_fd& output_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700849 std::vector<std::string> profman_args;
850 static const char* PROFMAN_BIN = "/system/bin/profman";
851 profman_args.push_back(PROFMAN_BIN);
852 profman_args.push_back("--dump-only");
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800853 profman_args.push_back(StringPrintf("--dump-output-to-fd=%d", output_fd.get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700854 if (reference_profile_fd != -1) {
855 profman_args.push_back(StringPrintf("--reference-profile-file-fd=%d",
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800856 reference_profile_fd.get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700857 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800858 for (size_t i = 0; i < profile_fds.size(); i++) {
859 profman_args.push_back(StringPrintf("--profile-file-fd=%d", profile_fds[i].get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700860 }
861 for (const std::string& dex_location : dex_locations) {
862 profman_args.push_back(StringPrintf("--dex-location=%s", dex_location.c_str()));
863 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800864 for (size_t i = 0; i < apk_fds.size(); i++) {
865 profman_args.push_back(StringPrintf("--apk-fd=%d", apk_fds[i].get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700866 }
867 const char **argv = new const char*[profman_args.size() + 1];
868 size_t i = 0;
869 for (const std::string& profman_arg : profman_args) {
870 argv[i++] = profman_arg.c_str();
871 }
872 argv[i] = NULL;
873
874 execv(PROFMAN_BIN, (char * const *)argv);
875 ALOGE("execv(%s) failed: %s\n", PROFMAN_BIN, strerror(errno));
876 exit(68); /* only get here on exec failure */
877}
878
Calin Juravle408cd4a2018-01-20 23:34:18 -0800879bool dump_profiles(int32_t uid, const std::string& pkgname, const std::string& profile_name,
880 const std::string& code_path) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800881 std::vector<unique_fd> profile_fds;
882 unique_fd reference_profile_fd;
Calin Juravle408cd4a2018-01-20 23:34:18 -0800883 std::string out_file_name = StringPrintf("/data/misc/profman/%s-%s.txt",
884 pkgname.c_str(), profile_name.c_str());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700885
Calin Juravle408cd4a2018-01-20 23:34:18 -0800886 open_profile_files(uid, pkgname, profile_name, /*is_secondary_dex*/false,
Calin Juravle114f0812017-03-08 19:05:07 -0800887 &profile_fds, &reference_profile_fd);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700888
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800889 const bool has_reference_profile = (reference_profile_fd.get() != -1);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700890 const bool has_profiles = !profile_fds.empty();
891
892 if (!has_reference_profile && !has_profiles) {
Calin Juravle76268c52017-03-09 13:19:42 -0800893 LOG(ERROR) << "profman dump: no profiles to dump for " << pkgname;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700894 return false;
895 }
896
Calin Juravle114f0812017-03-08 19:05:07 -0800897 unique_fd output_fd(open(out_file_name.c_str(),
898 O_WRONLY | O_CREAT | O_TRUNC | O_NOFOLLOW, 0644));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700899 if (fchmod(output_fd, S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH) < 0) {
Calin Juravle408cd4a2018-01-20 23:34:18 -0800900 LOG(ERROR) << "installd cannot chmod file for dump_profile" << out_file_name;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700901 return false;
902 }
Calin Juravle408cd4a2018-01-20 23:34:18 -0800903
Jeff Sharkey90aff262016-12-12 14:28:24 -0700904 std::vector<std::string> dex_locations;
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800905 std::vector<unique_fd> apk_fds;
Calin Juravle408cd4a2018-01-20 23:34:18 -0800906 unique_fd apk_fd(open(code_path.c_str(), O_RDONLY | O_NOFOLLOW));
907 if (apk_fd == -1) {
908 PLOG(ERROR) << "installd cannot open " << code_path.c_str();
909 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700910 }
Calin Juravle408cd4a2018-01-20 23:34:18 -0800911 dex_locations.push_back(get_location_from_path(code_path.c_str()));
912 apk_fds.push_back(std::move(apk_fd));
913
Jeff Sharkey90aff262016-12-12 14:28:24 -0700914
915 pid_t pid = fork();
916 if (pid == 0) {
917 /* child -- drop privileges before continuing */
918 drop_capabilities(uid);
919 run_profman_dump(profile_fds, reference_profile_fd, dex_locations,
920 apk_fds, output_fd);
921 exit(68); /* only get here on exec failure */
922 }
923 /* parent */
Jeff Sharkey90aff262016-12-12 14:28:24 -0700924 int return_code = wait_child(pid);
925 if (!WIFEXITED(return_code)) {
926 LOG(WARNING) << "profman failed for package " << pkgname << ": "
927 << return_code;
928 return false;
929 }
930 return true;
931}
932
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700933bool copy_system_profile(const std::string& system_profile,
Calin Juravle824a64d2018-01-18 20:23:17 -0800934 uid_t packageUid, const std::string& package_name, const std::string& profile_name) {
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700935 unique_fd in_fd(open(system_profile.c_str(), O_RDONLY | O_NOFOLLOW | O_CLOEXEC));
936 unique_fd out_fd(open_reference_profile(packageUid,
Calin Juravle824a64d2018-01-18 20:23:17 -0800937 package_name,
938 profile_name,
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700939 /*read_write*/ true,
940 /*secondary*/ false));
941 if (in_fd.get() < 0) {
942 PLOG(WARNING) << "Could not open profile " << system_profile;
943 return false;
944 }
945 if (out_fd.get() < 0) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800946 PLOG(WARNING) << "Could not open profile " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700947 return false;
948 }
949
Mathieu Chartier78f71fe2017-06-14 13:02:26 -0700950 // As a security measure we want to write the profile information with the reduced capabilities
951 // of the package user id. So we fork and drop capabilities in the child.
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700952 pid_t pid = fork();
953 if (pid == 0) {
954 /* child -- drop privileges before continuing */
955 drop_capabilities(packageUid);
956
957 if (flock(out_fd.get(), LOCK_EX | LOCK_NB) != 0) {
958 if (errno != EWOULDBLOCK) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800959 PLOG(WARNING) << "Error locking profile " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700960 }
961 // This implies that the app owning this profile is running
962 // (and has acquired the lock).
963 //
964 // The app never acquires the lock for the reference profiles of primary apks.
965 // Only dex2oat from installd will do that. Since installd is single threaded
966 // we should not see this case. Nevertheless be prepared for it.
Calin Juravle824a64d2018-01-18 20:23:17 -0800967 PLOG(WARNING) << "Failed to flock " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700968 return false;
969 }
970
971 bool truncated = ftruncate(out_fd.get(), 0) == 0;
972 if (!truncated) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800973 PLOG(WARNING) << "Could not truncate " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700974 }
975
976 // Copy over data.
977 static constexpr size_t kBufferSize = 4 * 1024;
978 char buffer[kBufferSize];
979 while (true) {
980 ssize_t bytes = read(in_fd.get(), buffer, kBufferSize);
981 if (bytes == 0) {
982 break;
983 }
984 write(out_fd.get(), buffer, bytes);
985 }
986 if (flock(out_fd.get(), LOCK_UN) != 0) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800987 PLOG(WARNING) << "Error unlocking profile " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700988 }
Mathieu Chartier78f71fe2017-06-14 13:02:26 -0700989 // Use _exit since we don't want to run the global destructors in the child.
990 // b/62597429
991 _exit(0);
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700992 }
993 /* parent */
994 int return_code = wait_child(pid);
995 return return_code == 0;
996}
997
Jeff Sharkey90aff262016-12-12 14:28:24 -0700998static std::string replace_file_extension(const std::string& oat_path, const std::string& new_ext) {
999 // A standard dalvik-cache entry. Replace ".dex" with `new_ext`.
1000 if (EndsWith(oat_path, ".dex")) {
1001 std::string new_path = oat_path;
1002 new_path.replace(new_path.length() - strlen(".dex"), strlen(".dex"), new_ext);
Elliott Hughes969e4f82017-12-20 12:34:09 -08001003 CHECK(EndsWith(new_path, new_ext));
Jeff Sharkey90aff262016-12-12 14:28:24 -07001004 return new_path;
1005 }
1006
1007 // An odex entry. Not that this may not be an extension, e.g., in the OTA
1008 // case (where the base name will have an extension for the B artifact).
1009 size_t odex_pos = oat_path.rfind(".odex");
1010 if (odex_pos != std::string::npos) {
1011 std::string new_path = oat_path;
1012 new_path.replace(odex_pos, strlen(".odex"), new_ext);
1013 CHECK_NE(new_path.find(new_ext), std::string::npos);
1014 return new_path;
1015 }
1016
1017 // Don't know how to handle this.
1018 return "";
1019}
1020
1021// Translate the given oat path to an art (app image) path. An empty string
1022// denotes an error.
1023static std::string create_image_filename(const std::string& oat_path) {
1024 return replace_file_extension(oat_path, ".art");
1025}
1026
1027// Translate the given oat path to a vdex path. An empty string denotes an error.
1028static std::string create_vdex_filename(const std::string& oat_path) {
1029 return replace_file_extension(oat_path, ".vdex");
1030}
1031
Jeff Sharkey90aff262016-12-12 14:28:24 -07001032static int open_output_file(const char* file_name, bool recreate, int permissions) {
1033 int flags = O_RDWR | O_CREAT;
1034 if (recreate) {
1035 if (unlink(file_name) < 0) {
1036 if (errno != ENOENT) {
1037 PLOG(ERROR) << "open_output_file: Couldn't unlink " << file_name;
1038 }
1039 }
1040 flags |= O_EXCL;
1041 }
1042 return open(file_name, flags, permissions);
1043}
1044
Calin Juravle2289c0a2017-02-15 12:44:14 -08001045static bool set_permissions_and_ownership(
1046 int fd, bool is_public, int uid, const char* path, bool is_secondary_dex) {
1047 // Primary apks are owned by the system. Secondary dex files are owned by the app.
1048 int owning_uid = is_secondary_dex ? uid : AID_SYSTEM;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001049 if (fchmod(fd,
1050 S_IRUSR|S_IWUSR|S_IRGRP |
1051 (is_public ? S_IROTH : 0)) < 0) {
1052 ALOGE("installd cannot chmod '%s' during dexopt\n", path);
1053 return false;
Calin Juravle2289c0a2017-02-15 12:44:14 -08001054 } else if (fchown(fd, owning_uid, uid) < 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001055 ALOGE("installd cannot chown '%s' during dexopt\n", path);
1056 return false;
1057 }
1058 return true;
1059}
1060
1061static bool IsOutputDalvikCache(const char* oat_dir) {
1062 // InstallerConnection.java (which invokes installd) transforms Java null arguments
1063 // into '!'. Play it safe by handling it both.
1064 // TODO: ensure we never get null.
1065 // TODO: pass a flag instead of inferring if the output is dalvik cache.
1066 return oat_dir == nullptr || oat_dir[0] == '!';
1067}
1068
Calin Juravled23dee72017-07-06 16:29:11 -07001069// Best-effort check whether we can fit the the path into our buffers.
1070// Note: the cache path will require an additional 5 bytes for ".swap", but we'll try to run
1071// without a swap file, if necessary. Reference profiles file also add an extra ".prof"
1072// extension to the cache path (5 bytes).
1073// TODO(calin): move away from char* buffers and PKG_PATH_MAX.
1074static bool validate_dex_path_size(const std::string& dex_path) {
1075 if (dex_path.size() >= (PKG_PATH_MAX - 8)) {
1076 LOG(ERROR) << "dex_path too long: " << dex_path;
1077 return false;
1078 }
1079 return true;
1080}
1081
Jeff Sharkey90aff262016-12-12 14:28:24 -07001082static bool create_oat_out_path(const char* apk_path, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -08001083 const char* oat_dir, bool is_secondary_dex, /*out*/ char* out_oat_path) {
Calin Juravled23dee72017-07-06 16:29:11 -07001084 if (!validate_dex_path_size(apk_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001085 return false;
1086 }
1087
1088 if (!IsOutputDalvikCache(oat_dir)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001089 // Oat dirs for secondary dex files are already validated.
1090 if (!is_secondary_dex && validate_apk_path(oat_dir)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001091 ALOGE("cannot validate apk path with oat_dir '%s'\n", oat_dir);
1092 return false;
1093 }
1094 if (!calculate_oat_file_path(out_oat_path, oat_dir, apk_path, instruction_set)) {
1095 return false;
1096 }
1097 } else {
1098 if (!create_cache_path(out_oat_path, apk_path, instruction_set)) {
1099 return false;
1100 }
1101 }
1102 return true;
1103}
1104
1105// Helper for fd management. This is similar to a unique_fd in that it closes the file descriptor
1106// on destruction. It will also run the given cleanup (unless told not to) after closing.
1107//
1108// Usage example:
1109//
Calin Juravle7a570e82017-01-14 16:23:30 -08001110// Dex2oatFileWrapper file(open(...),
Jeff Sharkey90aff262016-12-12 14:28:24 -07001111// [name]() {
1112// unlink(name.c_str());
1113// });
1114// // Note: care needs to be taken about name, as it needs to have a lifetime longer than the
1115// wrapper if captured as a reference.
1116//
1117// if (file.get() == -1) {
1118// // Error opening...
1119// }
1120//
1121// ...
1122// if (error) {
1123// // At this point, when the Dex2oatFileWrapper is destructed, the cleanup function will run
1124// // and delete the file (after the fd is closed).
1125// return -1;
1126// }
1127//
1128// (Success case)
1129// file.SetCleanup(false);
1130// // At this point, when the Dex2oatFileWrapper is destructed, the cleanup function will not run
1131// // (leaving the file around; after the fd is closed).
1132//
Jeff Sharkey90aff262016-12-12 14:28:24 -07001133class Dex2oatFileWrapper {
1134 public:
Calin Juravle7a570e82017-01-14 16:23:30 -08001135 Dex2oatFileWrapper() : value_(-1), cleanup_(), do_cleanup_(true), auto_close_(true) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001136 }
1137
Calin Juravle7a570e82017-01-14 16:23:30 -08001138 Dex2oatFileWrapper(int value, std::function<void ()> cleanup)
1139 : value_(value), cleanup_(cleanup), do_cleanup_(true), auto_close_(true) {}
1140
1141 Dex2oatFileWrapper(Dex2oatFileWrapper&& other) {
1142 value_ = other.value_;
1143 cleanup_ = other.cleanup_;
1144 do_cleanup_ = other.do_cleanup_;
1145 auto_close_ = other.auto_close_;
1146 other.release();
1147 }
1148
1149 Dex2oatFileWrapper& operator=(Dex2oatFileWrapper&& other) {
1150 value_ = other.value_;
1151 cleanup_ = other.cleanup_;
1152 do_cleanup_ = other.do_cleanup_;
1153 auto_close_ = other.auto_close_;
1154 other.release();
1155 return *this;
1156 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001157
1158 ~Dex2oatFileWrapper() {
1159 reset(-1);
1160 }
1161
1162 int get() {
1163 return value_;
1164 }
1165
1166 void SetCleanup(bool cleanup) {
1167 do_cleanup_ = cleanup;
1168 }
1169
1170 void reset(int new_value) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001171 if (auto_close_ && value_ >= 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001172 close(value_);
1173 }
1174 if (do_cleanup_ && cleanup_ != nullptr) {
1175 cleanup_();
1176 }
1177
1178 value_ = new_value;
1179 }
1180
Calin Juravle7a570e82017-01-14 16:23:30 -08001181 void reset(int new_value, std::function<void ()> new_cleanup) {
1182 if (auto_close_ && value_ >= 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001183 close(value_);
1184 }
1185 if (do_cleanup_ && cleanup_ != nullptr) {
1186 cleanup_();
1187 }
1188
1189 value_ = new_value;
1190 cleanup_ = new_cleanup;
1191 }
1192
Calin Juravle7a570e82017-01-14 16:23:30 -08001193 void DisableAutoClose() {
1194 auto_close_ = false;
1195 }
1196
Jeff Sharkey90aff262016-12-12 14:28:24 -07001197 private:
Calin Juravle7a570e82017-01-14 16:23:30 -08001198 void release() {
1199 value_ = -1;
1200 do_cleanup_ = false;
1201 cleanup_ = nullptr;
1202 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001203 int value_;
Calin Juravle7a570e82017-01-14 16:23:30 -08001204 std::function<void ()> cleanup_;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001205 bool do_cleanup_;
Calin Juravle7a570e82017-01-14 16:23:30 -08001206 bool auto_close_;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001207};
1208
Calin Juravle7a570e82017-01-14 16:23:30 -08001209// (re)Creates the app image if needed.
1210Dex2oatFileWrapper maybe_open_app_image(const char* out_oat_path, bool profile_guided,
Calin Juravle2289c0a2017-02-15 12:44:14 -08001211 bool is_public, int uid, bool is_secondary_dex) {
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +01001212
1213 // We don't create an image for secondary dex files.
1214 if (is_secondary_dex) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001215 return Dex2oatFileWrapper();
1216 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001217
Calin Juravle7a570e82017-01-14 16:23:30 -08001218 const std::string image_path = create_image_filename(out_oat_path);
1219 if (image_path.empty()) {
1220 // Happens when the out_oat_path has an unknown extension.
1221 return Dex2oatFileWrapper();
1222 }
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +01001223
1224 // Use app images only if it is enabled (by a set image format) and we are compiling
1225 // profile-guided (so the app image doesn't conservatively contain all classes).
1226 if (!profile_guided) {
1227 // In case there is a stale image, remove it now. Ignore any error.
1228 unlink(image_path.c_str());
1229 return Dex2oatFileWrapper();
1230 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001231 char app_image_format[kPropertyValueMax];
1232 bool have_app_image_format =
1233 get_property("dalvik.vm.appimageformat", app_image_format, NULL) > 0;
1234 if (!have_app_image_format) {
1235 return Dex2oatFileWrapper();
1236 }
1237 // Recreate is true since we do not want to modify a mapped image. If the app is
1238 // already running and we modify the image file, it can cause crashes (b/27493510).
1239 Dex2oatFileWrapper wrapper_fd(
1240 open_output_file(image_path.c_str(), true /*recreate*/, 0600 /*permissions*/),
1241 [image_path]() { unlink(image_path.c_str()); });
1242 if (wrapper_fd.get() < 0) {
1243 // Could not create application image file. Go on since we can compile without it.
1244 LOG(ERROR) << "installd could not create '" << image_path
1245 << "' for image file during dexopt";
1246 // If we have a valid image file path but no image fd, explicitly erase the image file.
1247 if (unlink(image_path.c_str()) < 0) {
1248 if (errno != ENOENT) {
1249 PLOG(ERROR) << "Couldn't unlink image file " << image_path;
1250 }
1251 }
1252 } else if (!set_permissions_and_ownership(
Calin Juravle2289c0a2017-02-15 12:44:14 -08001253 wrapper_fd.get(), is_public, uid, image_path.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001254 ALOGE("installd cannot set owner '%s' for image during dexopt\n", image_path.c_str());
1255 wrapper_fd.reset(-1);
1256 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001257
Calin Juravle7a570e82017-01-14 16:23:30 -08001258 return wrapper_fd;
1259}
1260
1261// Creates the dexopt swap file if necessary and return its fd.
1262// Returns -1 if there's no need for a swap or in case of errors.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001263unique_fd maybe_open_dexopt_swap_file(const char* out_oat_path) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001264 if (!ShouldUseSwapFileForDexopt()) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001265 return invalid_unique_fd();
Calin Juravle7a570e82017-01-14 16:23:30 -08001266 }
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001267 auto swap_file_name = std::string(out_oat_path) + ".swap";
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001268 unique_fd swap_fd(open_output_file(
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001269 swap_file_name.c_str(), /*recreate*/true, /*permissions*/0600));
Calin Juravle7a570e82017-01-14 16:23:30 -08001270 if (swap_fd.get() < 0) {
1271 // Could not create swap file. Optimistically go on and hope that we can compile
1272 // without it.
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001273 ALOGE("installd could not create '%s' for swap during dexopt\n", swap_file_name.c_str());
Calin Juravle7a570e82017-01-14 16:23:30 -08001274 } else {
1275 // Immediately unlink. We don't really want to hit flash.
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001276 if (unlink(swap_file_name.c_str()) < 0) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001277 PLOG(ERROR) << "Couldn't unlink swap file " << swap_file_name;
1278 }
1279 }
1280 return swap_fd;
1281}
1282
1283// Opens the reference profiles if needed.
1284// Note that the reference profile might not exist so it's OK if the fd will be -1.
Calin Juravle114f0812017-03-08 19:05:07 -08001285Dex2oatFileWrapper maybe_open_reference_profile(const std::string& pkgname,
Calin Juravle824a64d2018-01-18 20:23:17 -08001286 const std::string& dex_path, const std::string& profile_name, bool profile_guided,
1287 bool is_public, int uid, bool is_secondary_dex) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001288 // Public apps should not be compiled with profile information ever. Same goes for the special
1289 // package '*' used for the system server.
Calin Juravle114f0812017-03-08 19:05:07 -08001290 if (!profile_guided || is_public || (pkgname[0] == '*')) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001291 return Dex2oatFileWrapper();
Jeff Sharkey90aff262016-12-12 14:28:24 -07001292 }
Calin Juravle114f0812017-03-08 19:05:07 -08001293
1294 // Open reference profile in read only mode as dex2oat does not get write permissions.
Calin Juravle824a64d2018-01-18 20:23:17 -08001295 const std::string location = is_secondary_dex ? dex_path : profile_name;
1296 unique_fd ufd = open_reference_profile(uid, pkgname, location, /*read_write*/false,
1297 is_secondary_dex);
1298 const auto& cleanup = [pkgname, location, is_secondary_dex]() {
1299 clear_reference_profile(pkgname, location, is_secondary_dex);
Calin Juravle114f0812017-03-08 19:05:07 -08001300 };
1301 return Dex2oatFileWrapper(ufd.release(), cleanup);
Calin Juravle7a570e82017-01-14 16:23:30 -08001302}
Jeff Sharkey90aff262016-12-12 14:28:24 -07001303
Calin Juravle7a570e82017-01-14 16:23:30 -08001304// Opens the vdex files and assigns the input fd to in_vdex_wrapper_fd and the output fd to
1305// out_vdex_wrapper_fd. Returns true for success or false in case of errors.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001306bool open_vdex_files_for_dex2oat(const char* apk_path, const char* out_oat_path, int dexopt_needed,
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001307 const char* instruction_set, bool is_public, int uid, bool is_secondary_dex,
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001308 bool profile_guided, Dex2oatFileWrapper* in_vdex_wrapper_fd,
Calin Juravle7a570e82017-01-14 16:23:30 -08001309 Dex2oatFileWrapper* out_vdex_wrapper_fd) {
1310 CHECK(in_vdex_wrapper_fd != nullptr);
1311 CHECK(out_vdex_wrapper_fd != nullptr);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001312 // Open the existing VDEX. We do this before creating the new output VDEX, which will
1313 // unlink the old one.
Richard Uhler76cc0272016-12-08 10:46:35 +00001314 char in_odex_path[PKG_PATH_MAX];
1315 int dexopt_action = abs(dexopt_needed);
1316 bool is_odex_location = dexopt_needed < 0;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001317 std::string in_vdex_path_str;
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001318
1319 // Infer the name of the output VDEX.
1320 const std::string out_vdex_path_str = create_vdex_filename(out_oat_path);
1321 if (out_vdex_path_str.empty()) {
1322 return false;
1323 }
1324
1325 bool update_vdex_in_place = false;
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001326 if (dexopt_action != DEX2OAT_FROM_SCRATCH) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001327 // Open the possibly existing vdex. If none exist, we pass -1 to dex2oat for input-vdex-fd.
1328 const char* path = nullptr;
1329 if (is_odex_location) {
1330 if (calculate_odex_file_path(in_odex_path, apk_path, instruction_set)) {
1331 path = in_odex_path;
1332 } else {
1333 ALOGE("installd cannot compute input vdex location for '%s'\n", apk_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001334 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001335 }
1336 } else {
1337 path = out_oat_path;
1338 }
1339 in_vdex_path_str = create_vdex_filename(path);
1340 if (in_vdex_path_str.empty()) {
1341 ALOGE("installd cannot compute input vdex location for '%s'\n", path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001342 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001343 }
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001344 // We can update in place when all these conditions are met:
1345 // 1) The vdex location to write to is the same as the vdex location to read (vdex files
1346 // on /system typically cannot be updated in place).
1347 // 2) We dex2oat due to boot image change, because we then know the existing vdex file
1348 // cannot be currently used by a running process.
1349 // 3) We are not doing a profile guided compilation, because dexlayout requires two
1350 // different vdex files to operate.
1351 update_vdex_in_place =
1352 (in_vdex_path_str == out_vdex_path_str) &&
1353 (dexopt_action == DEX2OAT_FOR_BOOT_IMAGE) &&
1354 !profile_guided;
1355 if (update_vdex_in_place) {
1356 // Open the file read-write to be able to update it.
1357 in_vdex_wrapper_fd->reset(open(in_vdex_path_str.c_str(), O_RDWR, 0));
1358 if (in_vdex_wrapper_fd->get() == -1) {
1359 // If we failed to open the file, we cannot update it in place.
1360 update_vdex_in_place = false;
1361 }
1362 } else {
1363 in_vdex_wrapper_fd->reset(open(in_vdex_path_str.c_str(), O_RDONLY, 0));
1364 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001365 }
1366
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001367 // If we are updating the vdex in place, we do not need to recreate a vdex,
1368 // and can use the same existing one.
1369 if (update_vdex_in_place) {
1370 // We unlink the file in case the invocation of dex2oat fails, to ensure we don't
1371 // have bogus stale vdex files.
1372 out_vdex_wrapper_fd->reset(
1373 in_vdex_wrapper_fd->get(),
1374 [out_vdex_path_str]() { unlink(out_vdex_path_str.c_str()); });
1375 // Disable auto close for the in wrapper fd (it will be done when destructing the out
1376 // wrapper).
1377 in_vdex_wrapper_fd->DisableAutoClose();
1378 } else {
1379 out_vdex_wrapper_fd->reset(
1380 open_output_file(out_vdex_path_str.c_str(), /*recreate*/true, /*permissions*/0644),
1381 [out_vdex_path_str]() { unlink(out_vdex_path_str.c_str()); });
1382 if (out_vdex_wrapper_fd->get() < 0) {
1383 ALOGE("installd cannot open vdex'%s' during dexopt\n", out_vdex_path_str.c_str());
1384 return false;
1385 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001386 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001387 if (!set_permissions_and_ownership(out_vdex_wrapper_fd->get(), is_public, uid,
Calin Juravle2289c0a2017-02-15 12:44:14 -08001388 out_vdex_path_str.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001389 ALOGE("installd cannot set owner '%s' for vdex during dexopt\n", out_vdex_path_str.c_str());
1390 return false;
1391 }
1392
1393 // If we got here we successfully opened the vdex files.
1394 return true;
1395}
1396
1397// Opens the output oat file for the given apk.
1398// If successful it stores the output path into out_oat_path and returns true.
1399Dex2oatFileWrapper open_oat_out_file(const char* apk_path, const char* oat_dir,
Calin Juravle80a21252017-01-17 14:43:25 -08001400 bool is_public, int uid, const char* instruction_set, bool is_secondary_dex,
1401 char* out_oat_path) {
1402 if (!create_oat_out_path(apk_path, instruction_set, oat_dir, is_secondary_dex, out_oat_path)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001403 return Dex2oatFileWrapper();
1404 }
1405 const std::string out_oat_path_str(out_oat_path);
1406 Dex2oatFileWrapper wrapper_fd(
1407 open_output_file(out_oat_path, /*recreate*/true, /*permissions*/0644),
1408 [out_oat_path_str]() { unlink(out_oat_path_str.c_str()); });
1409 if (wrapper_fd.get() < 0) {
Calin Juravle80a21252017-01-17 14:43:25 -08001410 PLOG(ERROR) << "installd cannot open output during dexopt" << out_oat_path;
Calin Juravle2289c0a2017-02-15 12:44:14 -08001411 } else if (!set_permissions_and_ownership(
1412 wrapper_fd.get(), is_public, uid, out_oat_path, is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001413 ALOGE("installd cannot set owner '%s' for output during dexopt\n", out_oat_path);
1414 wrapper_fd.reset(-1);
1415 }
1416 return wrapper_fd;
1417}
1418
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001419// Creates RDONLY fds for oat and vdex files, if exist.
1420// Returns false if it fails to create oat out path for the given apk path.
1421// Note that the method returns true even if the files could not be opened.
1422bool maybe_open_oat_and_vdex_file(const std::string& apk_path,
1423 const std::string& oat_dir,
1424 const std::string& instruction_set,
1425 bool is_secondary_dex,
1426 unique_fd* oat_file_fd,
1427 unique_fd* vdex_file_fd) {
1428 char oat_path[PKG_PATH_MAX];
1429 if (!create_oat_out_path(apk_path.c_str(),
1430 instruction_set.c_str(),
1431 oat_dir.c_str(),
1432 is_secondary_dex,
1433 oat_path)) {
Calin Juravle7d765462017-09-04 15:57:10 -07001434 LOG(ERROR) << "Could not create oat out path for "
1435 << apk_path << " with oat dir " << oat_dir;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001436 return false;
1437 }
1438 oat_file_fd->reset(open(oat_path, O_RDONLY));
1439 if (oat_file_fd->get() < 0) {
1440 PLOG(INFO) << "installd cannot open oat file during dexopt" << oat_path;
1441 }
1442
1443 std::string vdex_filename = create_vdex_filename(oat_path);
1444 vdex_file_fd->reset(open(vdex_filename.c_str(), O_RDONLY));
1445 if (vdex_file_fd->get() < 0) {
1446 PLOG(INFO) << "installd cannot open vdex file during dexopt" << vdex_filename;
1447 }
1448
1449 return true;
1450}
1451
Calin Juravle7a570e82017-01-14 16:23:30 -08001452// Updates the access times of out_oat_path based on those from apk_path.
1453void update_out_oat_access_times(const char* apk_path, const char* out_oat_path) {
1454 struct stat input_stat;
1455 memset(&input_stat, 0, sizeof(input_stat));
1456 if (stat(apk_path, &input_stat) != 0) {
1457 PLOG(ERROR) << "Could not stat " << apk_path << " during dexopt";
1458 return;
1459 }
1460
1461 struct utimbuf ut;
1462 ut.actime = input_stat.st_atime;
1463 ut.modtime = input_stat.st_mtime;
1464 if (utime(out_oat_path, &ut) != 0) {
1465 PLOG(WARNING) << "Could not update access times for " << apk_path << " during dexopt";
1466 }
1467}
1468
Calin Juravle80a21252017-01-17 14:43:25 -08001469// Runs (execv) dexoptanalyzer on the given arguments.
Calin Juravle114f0812017-03-08 19:05:07 -08001470// The analyzer will check if the dex_file needs to be (re)compiled to match the compiler_filter.
1471// If this is for a profile guided compilation, profile_was_updated will tell whether or not
1472// the profile has changed.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001473static void exec_dexoptanalyzer(const std::string& dex_file, int vdex_fd, int oat_fd,
1474 int zip_fd, const std::string& instruction_set, const std::string& compiler_filter,
1475 bool profile_was_updated, bool downgrade,
Calin Juravle58cab072017-09-12 01:02:26 -07001476 const char* class_loader_context) {
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001477 CHECK_GE(zip_fd, 0);
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001478 const char* dexoptanalyzer_bin =
1479 is_debug_runtime()
1480 ? "/system/bin/dexoptanalyzerd"
1481 : "/system/bin/dexoptanalyzer";
Calin Juravle80a21252017-01-17 14:43:25 -08001482 static const unsigned int MAX_INSTRUCTION_SET_LEN = 7;
1483
Calin Juravled23dee72017-07-06 16:29:11 -07001484 if (instruction_set.size() >= MAX_INSTRUCTION_SET_LEN) {
1485 LOG(ERROR) << "Instruction set " << instruction_set
1486 << " longer than max length of " << MAX_INSTRUCTION_SET_LEN;
Calin Juravle80a21252017-01-17 14:43:25 -08001487 return;
1488 }
1489
Calin Juravled23dee72017-07-06 16:29:11 -07001490 std::string dex_file_arg = "--dex-file=" + dex_file;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001491 std::string oat_fd_arg = "--oat-fd=" + std::to_string(oat_fd);
1492 std::string vdex_fd_arg = "--vdex-fd=" + std::to_string(vdex_fd);
1493 std::string zip_fd_arg = "--zip-fd=" + std::to_string(zip_fd);
Calin Juravled23dee72017-07-06 16:29:11 -07001494 std::string isa_arg = "--isa=" + instruction_set;
1495 std::string compiler_filter_arg = "--compiler-filter=" + compiler_filter;
Calin Juravle114f0812017-03-08 19:05:07 -08001496 const char* assume_profile_changed = "--assume-profile-changed";
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001497 const char* downgrade_flag = "--downgrade";
Calin Juravle58cab072017-09-12 01:02:26 -07001498 std::string class_loader_context_arg = "--class-loader-context=";
1499 if (class_loader_context != nullptr) {
1500 class_loader_context_arg += class_loader_context;
1501 }
Calin Juravle80a21252017-01-17 14:43:25 -08001502
Calin Juravle80a21252017-01-17 14:43:25 -08001503 // program name, dex file, isa, filter, the final NULL
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001504 const int argc = 6 +
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001505 (profile_was_updated ? 1 : 0) +
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001506 (vdex_fd >= 0 ? 1 : 0) +
1507 (oat_fd >= 0 ? 1 : 0) +
Calin Juravle58cab072017-09-12 01:02:26 -07001508 (downgrade ? 1 : 0) +
1509 (class_loader_context != nullptr ? 1 : 0);
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001510 const char* argv[argc];
Calin Juravle80a21252017-01-17 14:43:25 -08001511 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001512 argv[i++] = dexoptanalyzer_bin;
Calin Juravled23dee72017-07-06 16:29:11 -07001513 argv[i++] = dex_file_arg.c_str();
1514 argv[i++] = isa_arg.c_str();
1515 argv[i++] = compiler_filter_arg.c_str();
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001516 if (oat_fd >= 0) {
1517 argv[i++] = oat_fd_arg.c_str();
1518 }
1519 if (vdex_fd >= 0) {
1520 argv[i++] = vdex_fd_arg.c_str();
1521 }
1522 argv[i++] = zip_fd_arg.c_str();
Calin Juravle114f0812017-03-08 19:05:07 -08001523 if (profile_was_updated) {
1524 argv[i++] = assume_profile_changed;
1525 }
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001526 if (downgrade) {
1527 argv[i++] = downgrade_flag;
1528 }
Calin Juravle58cab072017-09-12 01:02:26 -07001529 if (class_loader_context != nullptr) {
Calin Juravle91501072017-10-26 15:44:53 -07001530 argv[i++] = class_loader_context_arg.c_str();
Calin Juravle58cab072017-09-12 01:02:26 -07001531 }
Calin Juravle80a21252017-01-17 14:43:25 -08001532 argv[i] = NULL;
1533
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001534 execv(dexoptanalyzer_bin, (char * const *)argv);
1535 ALOGE("execv(%s) failed: %s\n", dexoptanalyzer_bin, strerror(errno));
Calin Juravle80a21252017-01-17 14:43:25 -08001536}
1537
1538// Prepares the oat dir for the secondary dex files.
Calin Juravle114f0812017-03-08 19:05:07 -08001539static bool prepare_secondary_dex_oat_dir(const std::string& dex_path, int uid,
Calin Juravle7d765462017-09-04 15:57:10 -07001540 const char* instruction_set) {
Calin Juravle114f0812017-03-08 19:05:07 -08001541 unsigned long dirIndex = dex_path.rfind('/');
Calin Juravle80a21252017-01-17 14:43:25 -08001542 if (dirIndex == std::string::npos) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001543 LOG(ERROR ) << "Unexpected dir structure for secondary dex " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001544 return false;
1545 }
Calin Juravle114f0812017-03-08 19:05:07 -08001546 std::string dex_dir = dex_path.substr(0, dirIndex);
Calin Juravle80a21252017-01-17 14:43:25 -08001547
Calin Juravle80a21252017-01-17 14:43:25 -08001548 // Create oat file output directory.
Calin Juravleebc8a792017-04-04 20:21:05 -07001549 mode_t oat_dir_mode = S_IRWXU | S_IRWXG | S_IXOTH;
1550 if (prepare_app_cache_dir(dex_dir, "oat", oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001551 LOG(ERROR) << "Could not prepare oat dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001552 return false;
1553 }
1554
1555 char oat_dir[PKG_PATH_MAX];
Calin Juravle114f0812017-03-08 19:05:07 -08001556 snprintf(oat_dir, PKG_PATH_MAX, "%s/oat", dex_dir.c_str());
Calin Juravle80a21252017-01-17 14:43:25 -08001557
Calin Juravle7d765462017-09-04 15:57:10 -07001558 if (prepare_app_cache_dir(oat_dir, instruction_set, oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001559 LOG(ERROR) << "Could not prepare oat/isa dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001560 return false;
1561 }
1562
1563 return true;
1564}
1565
Calin Juravle7d765462017-09-04 15:57:10 -07001566// Return codes for identifying the reason why dexoptanalyzer was not invoked when processing
1567// secondary dex files. This return codes are returned by the child process created for
1568// analyzing secondary dex files in process_secondary_dex_dexopt.
Calin Juravle80a21252017-01-17 14:43:25 -08001569
Calin Juravle7d765462017-09-04 15:57:10 -07001570// The dexoptanalyzer was not invoked because of validation or IO errors.
1571static int constexpr SECONDARY_DEX_DEXOPTANALYZER_SKIPPED = 200;
1572// The dexoptanalyzer was not invoked because the dex file does not exist anymore.
1573static int constexpr SECONDARY_DEX_DEXOPTANALYZER_SKIPPED_NO_FILE = 201;
1574
1575// Verifies the result of analyzing secondary dex files from process_secondary_dex_dexopt.
Calin Juravle80a21252017-01-17 14:43:25 -08001576// If the result is valid returns true and sets dexopt_needed_out to a valid value.
1577// Returns false for errors or unexpected result values.
Calin Juravle7d765462017-09-04 15:57:10 -07001578// The result is expected to be either one of SECONDARY_DEX_* codes or a valid exit code
1579// of dexoptanalyzer.
1580static bool process_secondary_dexoptanalyzer_result(const std::string& dex_path, int result,
Calin Juravle80a21252017-01-17 14:43:25 -08001581 int* dexopt_needed_out) {
1582 // The result values are defined in dexoptanalyzer.
1583 switch (result) {
Calin Juravle7d765462017-09-04 15:57:10 -07001584 case 0: // dexoptanalyzer: no_dexopt_needed
Calin Juravle80a21252017-01-17 14:43:25 -08001585 *dexopt_needed_out = NO_DEXOPT_NEEDED; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001586 case 1: // dexoptanalyzer: dex2oat_from_scratch
Calin Juravle80a21252017-01-17 14:43:25 -08001587 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001588 case 5: // dexoptanalyzer: dex2oat_for_bootimage_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001589 *dexopt_needed_out = -DEX2OAT_FOR_BOOT_IMAGE; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001590 case 6: // dexoptanalyzer: dex2oat_for_filter_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001591 *dexopt_needed_out = -DEX2OAT_FOR_FILTER; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001592 case 7: // dexoptanalyzer: dex2oat_for_relocation_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001593 *dexopt_needed_out = -DEX2OAT_FOR_RELOCATION; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001594 case 2: // dexoptanalyzer: dex2oat_for_bootimage_oat
1595 case 3: // dexoptanalyzer: dex2oat_for_filter_oat
1596 case 4: // dexoptanalyzer: dex2oat_for_relocation_oat
Calin Juravlec9eab382017-01-25 01:17:17 -08001597 LOG(ERROR) << "Dexoptnalyzer return the status of an oat file."
1598 << " Expected odex file status for secondary dex " << dex_path
Calin Juravle80a21252017-01-17 14:43:25 -08001599 << " : dexoptanalyzer result=" << result;
1600 return false;
Calin Juravle7d765462017-09-04 15:57:10 -07001601 case SECONDARY_DEX_DEXOPTANALYZER_SKIPPED_NO_FILE:
1602 // If the file does not exist there's no need for dexopt.
1603 *dexopt_needed_out = NO_DEXOPT_NEEDED;
1604 return true;
1605 case SECONDARY_DEX_DEXOPTANALYZER_SKIPPED:
1606 return false;
Calin Juravle80a21252017-01-17 14:43:25 -08001607 default:
Calin Juravle7d765462017-09-04 15:57:10 -07001608 LOG(ERROR) << "Unexpected result from analyzing secondary dex " << dex_path
1609 << " result=" << result;
Calin Juravle80a21252017-01-17 14:43:25 -08001610 return false;
1611 }
1612}
1613
Calin Juravle7d765462017-09-04 15:57:10 -07001614enum SecondaryDexAccess {
1615 kSecondaryDexAccessReadOk = 0,
1616 kSecondaryDexAccessDoesNotExist = 1,
1617 kSecondaryDexAccessPermissionError = 2,
1618 kSecondaryDexAccessIOError = 3
1619};
1620
1621static SecondaryDexAccess check_secondary_dex_access(const std::string& dex_path) {
1622 // Check if the path exists and can be read. If not, there's nothing to do.
1623 if (access(dex_path.c_str(), R_OK) == 0) {
1624 return kSecondaryDexAccessReadOk;
1625 } else {
1626 if (errno == ENOENT) {
1627 LOG(INFO) << "Secondary dex does not exist: " << dex_path;
1628 return kSecondaryDexAccessDoesNotExist;
1629 } else {
1630 PLOG(ERROR) << "Could not access secondary dex " << dex_path;
1631 return errno == EACCES
1632 ? kSecondaryDexAccessPermissionError
1633 : kSecondaryDexAccessIOError;
1634 }
1635 }
1636}
1637
1638static bool is_file_public(const std::string& filename) {
1639 struct stat file_stat;
1640 if (stat(filename.c_str(), &file_stat) == 0) {
1641 return (file_stat.st_mode & S_IROTH) != 0;
1642 }
1643 return false;
1644}
1645
1646// Create the oat file structure for the secondary dex 'dex_path' and assign
1647// the individual path component to the 'out_' parameters.
1648static bool create_secondary_dex_oat_layout(const std::string& dex_path, const std::string& isa,
1649 char* out_oat_dir, char* out_oat_isa_dir, char* out_oat_path) {
1650 size_t dirIndex = dex_path.rfind('/');
1651 if (dirIndex == std::string::npos) {
1652 LOG(ERROR) << "Unexpected dir structure for dex file " << dex_path;
1653 return false;
1654 }
1655 // TODO(calin): we have similar computations in at lest 3 other places
1656 // (InstalldNativeService, otapropt and dexopt). Unify them and get rid of snprintf by
1657 // using string append.
1658 std::string apk_dir = dex_path.substr(0, dirIndex);
1659 snprintf(out_oat_dir, PKG_PATH_MAX, "%s/oat", apk_dir.c_str());
1660 snprintf(out_oat_isa_dir, PKG_PATH_MAX, "%s/%s", out_oat_dir, isa.c_str());
1661
1662 if (!create_oat_out_path(dex_path.c_str(), isa.c_str(), out_oat_dir,
1663 /*is_secondary_dex*/true, out_oat_path)) {
1664 LOG(ERROR) << "Could not create oat path for secondary dex " << dex_path;
1665 return false;
1666 }
1667 return true;
1668}
1669
1670// Validate that the dexopt_flags contain a valid storage flag and convert that to an installd
1671// recognized storage flags (FLAG_STORAGE_CE or FLAG_STORAGE_DE).
1672static bool validate_dexopt_storage_flags(int dexopt_flags, int* out_storage_flag) {
1673 if ((dexopt_flags & DEXOPT_STORAGE_CE) != 0) {
1674 *out_storage_flag = FLAG_STORAGE_CE;
1675 if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
1676 LOG(ERROR) << "Ambiguous secondary dex storage flag. Both, CE and DE, flags are set";
1677 return false;
1678 }
1679 } else if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
1680 *out_storage_flag = FLAG_STORAGE_DE;
1681 } else {
1682 LOG(ERROR) << "Secondary dex storage flag must be set";
1683 return false;
1684 }
1685 return true;
1686}
1687
Calin Juravlec9eab382017-01-25 01:17:17 -08001688// Processes the dex_path as a secondary dex files and return true if the path dex file should
Calin Juravle80a21252017-01-17 14:43:25 -08001689// be compiled. Returns false for errors (logged) or true if the secondary dex path was process
1690// successfully.
Calin Juravleebc8a792017-04-04 20:21:05 -07001691// When returning true, the output parameters will be:
1692// - is_public_out: whether or not the oat file should not be made public
1693// - dexopt_needed_out: valid OatFileAsssitant::DexOptNeeded
1694// - oat_dir_out: the oat dir path where the oat file should be stored
Calin Juravle7d765462017-09-04 15:57:10 -07001695static bool process_secondary_dex_dexopt(const std::string& dex_path, const char* pkgname,
Calin Juravle80a21252017-01-17 14:43:25 -08001696 int dexopt_flags, const char* volume_uuid, int uid, const char* instruction_set,
Calin Juravleebc8a792017-04-04 20:21:05 -07001697 const char* compiler_filter, bool* is_public_out, int* dexopt_needed_out,
Calin Juravle7d765462017-09-04 15:57:10 -07001698 std::string* oat_dir_out, bool downgrade, const char* class_loader_context) {
1699 LOG(DEBUG) << "Processing secondary dex path " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001700 int storage_flag;
Calin Juravle7d765462017-09-04 15:57:10 -07001701 if (!validate_dexopt_storage_flags(dexopt_flags, &storage_flag)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001702 return false;
1703 }
Calin Juravle7d765462017-09-04 15:57:10 -07001704 // Compute the oat dir as it's not easy to extract it from the child computation.
1705 char oat_path[PKG_PATH_MAX];
1706 char oat_dir[PKG_PATH_MAX];
1707 char oat_isa_dir[PKG_PATH_MAX];
1708 if (!create_secondary_dex_oat_layout(
1709 dex_path, instruction_set, oat_dir, oat_isa_dir, oat_path)) {
1710 LOG(ERROR) << "Could not create secondary odex layout: " << dex_path;
Calin Juravled23dee72017-07-06 16:29:11 -07001711 return false;
1712 }
Calin Juravle7d765462017-09-04 15:57:10 -07001713 oat_dir_out->assign(oat_dir);
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001714
Calin Juravle80a21252017-01-17 14:43:25 -08001715 pid_t pid = fork();
1716 if (pid == 0) {
1717 // child -- drop privileges before continuing.
1718 drop_capabilities(uid);
Calin Juravle7d765462017-09-04 15:57:10 -07001719
1720 // Validate the path structure.
1721 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid, uid, storage_flag)) {
1722 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
1723 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
1724 }
1725
1726 // Open the dex file.
1727 unique_fd zip_fd;
1728 zip_fd.reset(open(dex_path.c_str(), O_RDONLY));
1729 if (zip_fd.get() < 0) {
1730 if (errno == ENOENT) {
1731 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED_NO_FILE);
1732 } else {
1733 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
1734 }
1735 }
1736
1737 // Prepare the oat directories.
1738 if (!prepare_secondary_dex_oat_dir(dex_path, uid, instruction_set)) {
1739 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
1740 }
1741
1742 // Open the vdex/oat files if any.
1743 unique_fd oat_file_fd;
1744 unique_fd vdex_file_fd;
1745 if (!maybe_open_oat_and_vdex_file(dex_path,
1746 *oat_dir_out,
1747 instruction_set,
1748 true /* is_secondary_dex */,
1749 &oat_file_fd,
1750 &vdex_file_fd)) {
1751 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
1752 }
1753
1754 // Analyze profiles.
Calin Juravle824a64d2018-01-18 20:23:17 -08001755 bool profile_was_updated = analyze_profiles(uid, pkgname, dex_path,
1756 /*is_secondary_dex*/true);
Calin Juravle7d765462017-09-04 15:57:10 -07001757
1758 // Run dexoptanalyzer to get dexopt_needed code. This is not expected to return.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001759 exec_dexoptanalyzer(dex_path,
1760 vdex_file_fd.get(),
1761 oat_file_fd.get(),
1762 zip_fd.get(),
1763 instruction_set,
Calin Juravle7d765462017-09-04 15:57:10 -07001764 compiler_filter, profile_was_updated,
1765 downgrade,
1766 class_loader_context);
1767 PLOG(ERROR) << "Failed to exec dexoptanalyzer";
1768 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
Calin Juravle80a21252017-01-17 14:43:25 -08001769 }
1770
1771 /* parent */
Calin Juravle80a21252017-01-17 14:43:25 -08001772 int result = wait_child(pid);
1773 if (!WIFEXITED(result)) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001774 LOG(ERROR) << "dexoptanalyzer failed for path " << dex_path << ": " << result;
Calin Juravle80a21252017-01-17 14:43:25 -08001775 return false;
1776 }
1777 result = WEXITSTATUS(result);
Calin Juravle7d765462017-09-04 15:57:10 -07001778 // Check that we successfully executed dexoptanalyzer.
1779 bool success = process_secondary_dexoptanalyzer_result(dex_path, result, dexopt_needed_out);
1780
1781 LOG(DEBUG) << "Processed secondary dex file " << dex_path << " result=" << result;
1782
Calin Juravle80a21252017-01-17 14:43:25 -08001783 // Run dexopt only if needed or forced.
Calin Juravle7d765462017-09-04 15:57:10 -07001784 // Note that dexoptanalyzer is executed even if force compilation is enabled (because it
1785 // makes the code simpler; force compilation is only needed during tests).
1786 if (success &&
1787 (result != SECONDARY_DEX_DEXOPTANALYZER_SKIPPED_NO_FILE) &&
1788 ((dexopt_flags & DEXOPT_FORCE) != 0)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001789 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH;
1790 }
1791
Calin Juravle7d765462017-09-04 15:57:10 -07001792 // Check if we should make the oat file public.
1793 // Note that if the dex file is not public the compiled code cannot be made public.
1794 // It is ok to check this flag outside in the parent process.
1795 *is_public_out = ((dexopt_flags & DEXOPT_PUBLIC) != 0) && is_file_public(dex_path);
1796
Calin Juravle80a21252017-01-17 14:43:25 -08001797 return success;
1798}
1799
Calin Juravlec9eab382017-01-25 01:17:17 -08001800int dexopt(const char* dex_path, uid_t uid, const char* pkgname, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -08001801 int dexopt_needed, const char* oat_dir, int dexopt_flags, const char* compiler_filter,
Calin Juravle52c45822017-07-13 22:50:21 -07001802 const char* volume_uuid, const char* class_loader_context, const char* se_info,
Calin Juravle824a64d2018-01-18 20:23:17 -08001803 bool downgrade, int target_sdk_version, const char* profile_name) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001804 CHECK(pkgname != nullptr);
1805 CHECK(pkgname[0] != 0);
1806 if ((dexopt_flags & ~DEXOPT_MASK) != 0) {
1807 LOG_FATAL("dexopt flags contains unknown fields\n");
1808 }
1809
Calin Juravled23dee72017-07-06 16:29:11 -07001810 if (!validate_dex_path_size(dex_path)) {
Calin Juravle52c45822017-07-13 22:50:21 -07001811 return -1;
1812 }
1813
1814 if (class_loader_context != nullptr && strlen(class_loader_context) > PKG_PATH_MAX) {
1815 LOG(ERROR) << "Class loader context exceeds the allowed size: " << class_loader_context;
1816 return -1;
Calin Juravled23dee72017-07-06 16:29:11 -07001817 }
1818
Calin Juravleebc8a792017-04-04 20:21:05 -07001819 bool is_public = (dexopt_flags & DEXOPT_PUBLIC) != 0;
Calin Juravle7a570e82017-01-14 16:23:30 -08001820 bool debuggable = (dexopt_flags & DEXOPT_DEBUGGABLE) != 0;
1821 bool boot_complete = (dexopt_flags & DEXOPT_BOOTCOMPLETE) != 0;
1822 bool profile_guided = (dexopt_flags & DEXOPT_PROFILE_GUIDED) != 0;
Calin Juravle80a21252017-01-17 14:43:25 -08001823 bool is_secondary_dex = (dexopt_flags & DEXOPT_SECONDARY_DEX) != 0;
Andreas Gampea73a0cb2017-11-02 18:14:42 -07001824 bool background_job_compile = (dexopt_flags & DEXOPT_IDLE_BACKGROUND_JOB) != 0;
David Brazdil52249162018-02-12 18:04:59 -08001825 bool enable_hidden_api_checks = (dexopt_flags & DEXOPT_ENABLE_HIDDEN_API_CHECKS) != 0;
Calin Juravle80a21252017-01-17 14:43:25 -08001826
1827 // Check if we're dealing with a secondary dex file and if we need to compile it.
1828 std::string oat_dir_str;
1829 if (is_secondary_dex) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001830 if (process_secondary_dex_dexopt(dex_path, pkgname, dexopt_flags, volume_uuid, uid,
Calin Juravleebc8a792017-04-04 20:21:05 -07001831 instruction_set, compiler_filter, &is_public, &dexopt_needed, &oat_dir_str,
Calin Juravle7d765462017-09-04 15:57:10 -07001832 downgrade, class_loader_context)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001833 oat_dir = oat_dir_str.c_str();
1834 if (dexopt_needed == NO_DEXOPT_NEEDED) {
1835 return 0; // Nothing to do, report success.
1836 }
1837 } else {
1838 return -1; // We had an error, logged in the process method.
1839 }
1840 } else {
Calin Juravlec9eab382017-01-25 01:17:17 -08001841 // Currently these flags are only use for secondary dex files.
1842 // Verify that they are not set for primary apks.
Calin Juravle80a21252017-01-17 14:43:25 -08001843 CHECK((dexopt_flags & DEXOPT_STORAGE_CE) == 0);
1844 CHECK((dexopt_flags & DEXOPT_STORAGE_DE) == 0);
1845 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001846
1847 // Open the input file.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001848 unique_fd input_fd(open(dex_path, O_RDONLY, 0));
Calin Juravle7a570e82017-01-14 16:23:30 -08001849 if (input_fd.get() < 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001850 ALOGE("installd cannot open '%s' for input during dexopt\n", dex_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001851 return -1;
1852 }
1853
1854 // Create the output OAT file.
1855 char out_oat_path[PKG_PATH_MAX];
Calin Juravlec9eab382017-01-25 01:17:17 -08001856 Dex2oatFileWrapper out_oat_fd = open_oat_out_file(dex_path, oat_dir, is_public, uid,
Calin Juravle80a21252017-01-17 14:43:25 -08001857 instruction_set, is_secondary_dex, out_oat_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001858 if (out_oat_fd.get() < 0) {
1859 return -1;
1860 }
1861
1862 // Open vdex files.
1863 Dex2oatFileWrapper in_vdex_fd;
1864 Dex2oatFileWrapper out_vdex_fd;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001865 if (!open_vdex_files_for_dex2oat(dex_path, out_oat_path, dexopt_needed, instruction_set,
1866 is_public, uid, is_secondary_dex, profile_guided, &in_vdex_fd, &out_vdex_fd)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001867 return -1;
1868 }
1869
Calin Juravlecb556e32017-04-04 20:22:50 -07001870 // Ensure that the oat dir and the compiler artifacts of secondary dex files have the correct
1871 // selinux context (we generate them on the fly during the dexopt invocation and they don't
1872 // fully inherit their parent context).
1873 // Note that for primary apk the oat files are created before, in a separate installd
1874 // call which also does the restorecon. TODO(calin): unify the paths.
1875 if (is_secondary_dex) {
1876 if (selinux_android_restorecon_pkgdir(oat_dir, se_info, uid,
1877 SELINUX_ANDROID_RESTORECON_RECURSE)) {
1878 LOG(ERROR) << "Failed to restorecon " << oat_dir;
1879 return -1;
1880 }
1881 }
1882
Jeff Sharkey90aff262016-12-12 14:28:24 -07001883 // Create a swap file if necessary.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001884 unique_fd swap_fd = maybe_open_dexopt_swap_file(out_oat_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001885
Calin Juravle7a570e82017-01-14 16:23:30 -08001886 // Create the app image file if needed.
1887 Dex2oatFileWrapper image_fd =
Calin Juravle2289c0a2017-02-15 12:44:14 -08001888 maybe_open_app_image(out_oat_path, profile_guided, is_public, uid, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001889
Calin Juravle7a570e82017-01-14 16:23:30 -08001890 // Open the reference profile if needed.
Calin Juravle114f0812017-03-08 19:05:07 -08001891 Dex2oatFileWrapper reference_profile_fd = maybe_open_reference_profile(
Calin Juravle824a64d2018-01-18 20:23:17 -08001892 pkgname, dex_path, profile_name, profile_guided, is_public, uid, is_secondary_dex);
Calin Juravle7a570e82017-01-14 16:23:30 -08001893
Calin Juravlec9eab382017-01-25 01:17:17 -08001894 ALOGV("DexInv: --- BEGIN '%s' ---\n", dex_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001895
1896 pid_t pid = fork();
1897 if (pid == 0) {
1898 /* child -- drop privileges before continuing */
1899 drop_capabilities(uid);
1900
Richard Uhler76cc0272016-12-08 10:46:35 +00001901 SetDex2OatScheduling(boot_complete);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001902 if (flock(out_oat_fd.get(), LOCK_EX | LOCK_NB) != 0) {
1903 ALOGE("flock(%s) failed: %s\n", out_oat_path, strerror(errno));
1904 _exit(67);
1905 }
1906
Richard Uhler76cc0272016-12-08 10:46:35 +00001907 run_dex2oat(input_fd.get(),
1908 out_oat_fd.get(),
1909 in_vdex_fd.get(),
Calin Juravle7a570e82017-01-14 16:23:30 -08001910 out_vdex_fd.get(),
Richard Uhler76cc0272016-12-08 10:46:35 +00001911 image_fd.get(),
Jeff Hao10b8a6e2017-04-05 17:11:39 -07001912 dex_path,
Richard Uhler76cc0272016-12-08 10:46:35 +00001913 out_oat_path,
1914 swap_fd.get(),
1915 instruction_set,
1916 compiler_filter,
Richard Uhler76cc0272016-12-08 10:46:35 +00001917 debuggable,
1918 boot_complete,
Andreas Gampea73a0cb2017-11-02 18:14:42 -07001919 background_job_compile,
Richard Uhler76cc0272016-12-08 10:46:35 +00001920 reference_profile_fd.get(),
David Brazdil570d3982018-01-16 20:15:43 +00001921 class_loader_context,
David Brazdil7fcbb812018-01-17 17:05:40 +00001922 target_sdk_version,
David Brazdil52249162018-02-12 18:04:59 -08001923 enable_hidden_api_checks);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001924 _exit(68); /* only get here on exec failure */
1925 } else {
1926 int res = wait_child(pid);
1927 if (res == 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001928 ALOGV("DexInv: --- END '%s' (success) ---\n", dex_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001929 } else {
Calin Juravlec9eab382017-01-25 01:17:17 -08001930 ALOGE("DexInv: --- END '%s' --- status=0x%04x, process failed\n", dex_path, res);
Andreas Gampe013f02e2017-03-20 18:36:54 -07001931 return res;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001932 }
1933 }
1934
Calin Juravlec9eab382017-01-25 01:17:17 -08001935 update_out_oat_access_times(dex_path, out_oat_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001936
1937 // We've been successful, don't delete output.
1938 out_oat_fd.SetCleanup(false);
Calin Juravle7a570e82017-01-14 16:23:30 -08001939 out_vdex_fd.SetCleanup(false);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001940 image_fd.SetCleanup(false);
1941 reference_profile_fd.SetCleanup(false);
1942
1943 return 0;
1944}
1945
Calin Juravlec9eab382017-01-25 01:17:17 -08001946// Try to remove the given directory. Log an error if the directory exists
1947// and is empty but could not be removed.
1948static bool rmdir_if_empty(const char* dir) {
1949 if (rmdir(dir) == 0) {
1950 return true;
1951 }
1952 if (errno == ENOENT || errno == ENOTEMPTY) {
1953 return true;
1954 }
1955 PLOG(ERROR) << "Failed to remove dir: " << dir;
1956 return false;
1957}
1958
1959// Try to unlink the given file. Log an error if the file exists and could not
1960// be unlinked.
1961static bool unlink_if_exists(const std::string& file) {
1962 if (unlink(file.c_str()) == 0) {
1963 return true;
1964 }
1965 if (errno == ENOENT) {
1966 return true;
1967
1968 }
1969 PLOG(ERROR) << "Could not unlink: " << file;
1970 return false;
1971}
1972
Calin Juravle7d765462017-09-04 15:57:10 -07001973enum ReconcileSecondaryDexResult {
1974 kReconcileSecondaryDexExists = 0,
1975 kReconcileSecondaryDexCleanedUp = 1,
1976 kReconcileSecondaryDexValidationError = 2,
1977 kReconcileSecondaryDexCleanUpError = 3,
1978 kReconcileSecondaryDexAccessIOError = 4,
1979};
Calin Juravlec9eab382017-01-25 01:17:17 -08001980
1981// Reconcile the secondary dex 'dex_path' and its generated oat files.
1982// Return true if all the parameters are valid and the secondary dex file was
1983// processed successfully (i.e. the dex_path either exists, or if not, its corresponding
1984// oat/vdex/art files where deleted successfully). In this case, out_secondary_dex_exists
1985// will be true if the secondary dex file still exists. If the secondary dex file does not exist,
1986// the method cleans up any previously generated compiler artifacts (oat, vdex, art).
1987// Return false if there were errors during processing. In this case
1988// out_secondary_dex_exists will be set to false.
1989bool reconcile_secondary_dex_file(const std::string& dex_path,
1990 const std::string& pkgname, int uid, const std::vector<std::string>& isas,
1991 const std::unique_ptr<std::string>& volume_uuid, int storage_flag,
1992 /*out*/bool* out_secondary_dex_exists) {
Calin Juravle7d765462017-09-04 15:57:10 -07001993 *out_secondary_dex_exists = false; // start by assuming the file does not exist.
Calin Juravlec9eab382017-01-25 01:17:17 -08001994 if (isas.size() == 0) {
1995 LOG(ERROR) << "reconcile_secondary_dex_file called with empty isas vector";
1996 return false;
1997 }
1998
Calin Juravle7d765462017-09-04 15:57:10 -07001999 if (storage_flag != FLAG_STORAGE_CE && storage_flag != FLAG_STORAGE_DE) {
2000 LOG(ERROR) << "reconcile_secondary_dex_file called with invalid storage_flag: "
2001 << storage_flag;
Calin Juravlec9eab382017-01-25 01:17:17 -08002002 return false;
2003 }
2004
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002005 // As a security measure we want to unlink art artifacts with the reduced capabilities
2006 // of the package user id. So we fork and drop capabilities in the child.
2007 pid_t pid = fork();
2008 if (pid == 0) {
Calin Juravle7d765462017-09-04 15:57:10 -07002009 /* child -- drop privileges before continuing */
2010 drop_capabilities(uid);
2011
2012 const char* volume_uuid_cstr = volume_uuid == nullptr ? nullptr : volume_uuid->c_str();
2013 if (!validate_secondary_dex_path(pkgname.c_str(), dex_path.c_str(), volume_uuid_cstr,
2014 uid, storage_flag)) {
2015 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
2016 _exit(kReconcileSecondaryDexValidationError);
2017 }
2018
2019 SecondaryDexAccess access_check = check_secondary_dex_access(dex_path);
2020 switch (access_check) {
2021 case kSecondaryDexAccessDoesNotExist:
2022 // File does not exist. Proceed with cleaning.
2023 break;
2024 case kSecondaryDexAccessReadOk: _exit(kReconcileSecondaryDexExists);
2025 case kSecondaryDexAccessIOError: _exit(kReconcileSecondaryDexAccessIOError);
2026 case kSecondaryDexAccessPermissionError: _exit(kReconcileSecondaryDexValidationError);
2027 default:
2028 LOG(ERROR) << "Unexpected result from check_secondary_dex_access: " << access_check;
2029 _exit(kReconcileSecondaryDexValidationError);
2030 }
2031
2032 // The secondary dex does not exist anymore or it's. Clear any generated files.
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002033 char oat_path[PKG_PATH_MAX];
2034 char oat_dir[PKG_PATH_MAX];
2035 char oat_isa_dir[PKG_PATH_MAX];
2036 bool result = true;
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002037 for (size_t i = 0; i < isas.size(); i++) {
Calin Juravle7d765462017-09-04 15:57:10 -07002038 if (!create_secondary_dex_oat_layout(
2039 dex_path,isas[i], oat_dir, oat_isa_dir, oat_path)) {
2040 LOG(ERROR) << "Could not create secondary odex layout: " << dex_path;
2041 _exit(kReconcileSecondaryDexValidationError);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002042 }
Calin Juravle51314092017-05-18 15:33:05 -07002043
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002044 // Delete oat/vdex/art files.
2045 result = unlink_if_exists(oat_path) && result;
2046 result = unlink_if_exists(create_vdex_filename(oat_path)) && result;
2047 result = unlink_if_exists(create_image_filename(oat_path)) && result;
Calin Juravlec9eab382017-01-25 01:17:17 -08002048
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002049 // Delete profiles.
2050 std::string current_profile = create_current_profile_path(
Calin Juravle824a64d2018-01-18 20:23:17 -08002051 multiuser_get_user_id(uid), pkgname, dex_path, /*is_secondary*/true);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002052 std::string reference_profile = create_reference_profile_path(
Calin Juravle824a64d2018-01-18 20:23:17 -08002053 pkgname, dex_path, /*is_secondary*/true);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002054 result = unlink_if_exists(current_profile) && result;
2055 result = unlink_if_exists(reference_profile) && result;
Calin Juravle51314092017-05-18 15:33:05 -07002056
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002057 // We upgraded once the location of current profile for secondary dex files.
2058 // Check for any previous left-overs and remove them as well.
2059 std::string old_current_profile = dex_path + ".prof";
2060 result = unlink_if_exists(old_current_profile);
Calin Juravle3760ad32017-07-27 16:31:55 -07002061
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002062 // Try removing the directories as well, they might be empty.
2063 result = rmdir_if_empty(oat_isa_dir) && result;
2064 result = rmdir_if_empty(oat_dir) && result;
2065 }
Calin Juravle7d765462017-09-04 15:57:10 -07002066 if (!result) {
2067 PLOG(ERROR) << "Failed to clean secondary dex artifacts for location " << dex_path;
2068 }
2069 _exit(result ? kReconcileSecondaryDexCleanedUp : kReconcileSecondaryDexAccessIOError);
Calin Juravlec9eab382017-01-25 01:17:17 -08002070 }
2071
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002072 int return_code = wait_child(pid);
Calin Juravle7d765462017-09-04 15:57:10 -07002073 if (!WIFEXITED(return_code)) {
2074 LOG(WARNING) << "reconcile dex failed for location " << dex_path << ": " << return_code;
2075 } else {
2076 return_code = WEXITSTATUS(return_code);
2077 }
2078
2079 LOG(DEBUG) << "Reconcile secondary dex path " << dex_path << " result=" << return_code;
2080
2081 switch (return_code) {
2082 case kReconcileSecondaryDexCleanedUp:
2083 case kReconcileSecondaryDexValidationError:
2084 // If we couldn't validate assume the dex file does not exist.
2085 // This will purge the entry from the PM records.
2086 *out_secondary_dex_exists = false;
2087 return true;
2088 case kReconcileSecondaryDexExists:
2089 *out_secondary_dex_exists = true;
2090 return true;
2091 case kReconcileSecondaryDexAccessIOError:
2092 // We had an access IO error.
2093 // Return false so that we can try again.
2094 // The value of out_secondary_dex_exists does not matter in this case and by convention
2095 // is set to false.
2096 *out_secondary_dex_exists = false;
2097 return false;
2098 default:
2099 LOG(ERROR) << "Unexpected code from reconcile_secondary_dex_file: " << return_code;
2100 *out_secondary_dex_exists = false;
2101 return false;
2102 }
Calin Juravlec9eab382017-01-25 01:17:17 -08002103}
2104
Alan Stokesa25d90c2017-10-16 10:56:00 +01002105// Compute and return the hash (SHA-256) of the secondary dex file at dex_path.
2106// Returns true if all parameters are valid and the hash successfully computed and stored in
2107// out_secondary_dex_hash.
2108// Also returns true with an empty hash if the file does not currently exist or is not accessible to
2109// the app.
2110// For any other errors (e.g. if any of the parameters are invalid) returns false.
2111bool hash_secondary_dex_file(const std::string& dex_path, const std::string& pkgname, int uid,
2112 const std::unique_ptr<std::string>& volume_uuid, int storage_flag,
2113 std::vector<uint8_t>* out_secondary_dex_hash) {
2114 out_secondary_dex_hash->clear();
2115
2116 const char* volume_uuid_cstr = volume_uuid == nullptr ? nullptr : volume_uuid->c_str();
2117
2118 if (storage_flag != FLAG_STORAGE_CE && storage_flag != FLAG_STORAGE_DE) {
2119 LOG(ERROR) << "hash_secondary_dex_file called with invalid storage_flag: "
2120 << storage_flag;
2121 return false;
2122 }
2123
2124 // Pipe to get the hash result back from our child process.
2125 unique_fd pipe_read, pipe_write;
2126 if (!Pipe(&pipe_read, &pipe_write)) {
2127 PLOG(ERROR) << "Failed to create pipe";
2128 return false;
2129 }
2130
2131 // Fork so that actual access to the files is done in the app's own UID, to ensure we only
2132 // access data the app itself can access.
2133 pid_t pid = fork();
2134 if (pid == 0) {
2135 // child -- drop privileges before continuing
2136 drop_capabilities(uid);
2137 pipe_read.reset();
2138
2139 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid_cstr, uid, storage_flag)) {
2140 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
2141 _exit(1);
2142 }
2143
2144 unique_fd fd(TEMP_FAILURE_RETRY(open(dex_path.c_str(), O_RDONLY | O_CLOEXEC | O_NOFOLLOW)));
2145 if (fd == -1) {
2146 if (errno == EACCES || errno == ENOENT) {
2147 // Not treated as an error.
2148 _exit(0);
2149 }
2150 PLOG(ERROR) << "Failed to open secondary dex " << dex_path;
2151 _exit(1);
2152 }
2153
2154 SHA256_CTX ctx;
2155 SHA256_Init(&ctx);
2156
2157 std::vector<uint8_t> buffer(65536);
2158 while (true) {
2159 ssize_t bytes_read = TEMP_FAILURE_RETRY(read(fd, buffer.data(), buffer.size()));
2160 if (bytes_read == 0) {
2161 break;
2162 } else if (bytes_read == -1) {
2163 PLOG(ERROR) << "Failed to read secondary dex " << dex_path;
2164 _exit(1);
2165 }
2166
2167 SHA256_Update(&ctx, buffer.data(), bytes_read);
2168 }
2169
2170 std::array<uint8_t, SHA256_DIGEST_LENGTH> hash;
2171 SHA256_Final(hash.data(), &ctx);
2172 if (!WriteFully(pipe_write, hash.data(), hash.size())) {
2173 _exit(1);
2174 }
2175
2176 _exit(0);
2177 }
2178
2179 // parent
2180 pipe_write.reset();
2181
2182 out_secondary_dex_hash->resize(SHA256_DIGEST_LENGTH);
2183 if (!ReadFully(pipe_read, out_secondary_dex_hash->data(), out_secondary_dex_hash->size())) {
2184 out_secondary_dex_hash->clear();
2185 }
2186 return wait_child(pid) == 0;
2187}
2188
Jeff Sharkey90aff262016-12-12 14:28:24 -07002189// Helper for move_ab, so that we can have common failure-case cleanup.
2190static bool unlink_and_rename(const char* from, const char* to) {
2191 // Check whether "from" exists, and if so whether it's regular. If it is, unlink. Otherwise,
2192 // return a failure.
2193 struct stat s;
2194 if (stat(to, &s) == 0) {
2195 if (!S_ISREG(s.st_mode)) {
2196 LOG(ERROR) << from << " is not a regular file to replace for A/B.";
2197 return false;
2198 }
2199 if (unlink(to) != 0) {
2200 LOG(ERROR) << "Could not unlink " << to << " to move A/B.";
2201 return false;
2202 }
2203 } else {
2204 // This may be a permission problem. We could investigate the error code, but we'll just
2205 // let the rename failure do the work for us.
2206 }
2207
2208 // Try to rename "to" to "from."
2209 if (rename(from, to) != 0) {
2210 PLOG(ERROR) << "Could not rename " << from << " to " << to;
2211 return false;
2212 }
2213 return true;
2214}
2215
2216// Move/rename a B artifact (from) to an A artifact (to).
2217static bool move_ab_path(const std::string& b_path, const std::string& a_path) {
2218 // Check whether B exists.
2219 {
2220 struct stat s;
2221 if (stat(b_path.c_str(), &s) != 0) {
2222 // Silently ignore for now. The service calling this isn't smart enough to understand
2223 // lack of artifacts at the moment.
2224 return false;
2225 }
2226 if (!S_ISREG(s.st_mode)) {
2227 LOG(ERROR) << "A/B artifact " << b_path << " is not a regular file.";
2228 // Try to unlink, but swallow errors.
2229 unlink(b_path.c_str());
2230 return false;
2231 }
2232 }
2233
2234 // Rename B to A.
2235 if (!unlink_and_rename(b_path.c_str(), a_path.c_str())) {
2236 // Delete the b_path so we don't try again (or fail earlier).
2237 if (unlink(b_path.c_str()) != 0) {
2238 PLOG(ERROR) << "Could not unlink " << b_path;
2239 }
2240
2241 return false;
2242 }
2243
2244 return true;
2245}
2246
2247bool move_ab(const char* apk_path, const char* instruction_set, const char* oat_dir) {
2248 // Get the current slot suffix. No suffix, no A/B.
2249 std::string slot_suffix;
2250 {
2251 char buf[kPropertyValueMax];
2252 if (get_property("ro.boot.slot_suffix", buf, nullptr) <= 0) {
2253 return false;
2254 }
2255 slot_suffix = buf;
2256
2257 if (!ValidateTargetSlotSuffix(slot_suffix)) {
2258 LOG(ERROR) << "Target slot suffix not legal: " << slot_suffix;
2259 return false;
2260 }
2261 }
2262
2263 // Validate other inputs.
2264 if (validate_apk_path(apk_path) != 0) {
2265 LOG(ERROR) << "Invalid apk_path: " << apk_path;
2266 return false;
2267 }
2268 if (validate_apk_path(oat_dir) != 0) {
2269 LOG(ERROR) << "Invalid oat_dir: " << oat_dir;
2270 return false;
2271 }
2272
2273 char a_path[PKG_PATH_MAX];
2274 if (!calculate_oat_file_path(a_path, oat_dir, apk_path, instruction_set)) {
2275 return false;
2276 }
2277 const std::string a_vdex_path = create_vdex_filename(a_path);
2278 const std::string a_image_path = create_image_filename(a_path);
2279
2280 // B path = A path + slot suffix.
2281 const std::string b_path = StringPrintf("%s.%s", a_path, slot_suffix.c_str());
2282 const std::string b_vdex_path = StringPrintf("%s.%s", a_vdex_path.c_str(), slot_suffix.c_str());
2283 const std::string b_image_path = StringPrintf("%s.%s",
2284 a_image_path.c_str(),
2285 slot_suffix.c_str());
2286
2287 bool success = true;
2288 if (move_ab_path(b_path, a_path)) {
2289 if (move_ab_path(b_vdex_path, a_vdex_path)) {
2290 // Note: we can live without an app image. As such, ignore failure to move the image file.
2291 // If we decide to require the app image, or the app image being moved correctly,
2292 // then change accordingly.
2293 constexpr bool kIgnoreAppImageFailure = true;
2294
2295 if (!a_image_path.empty()) {
2296 if (!move_ab_path(b_image_path, a_image_path)) {
2297 unlink(a_image_path.c_str());
2298 if (!kIgnoreAppImageFailure) {
2299 success = false;
2300 }
2301 }
2302 }
2303 } else {
2304 // Cleanup: delete B image, ignore errors.
2305 unlink(b_image_path.c_str());
2306 success = false;
2307 }
2308 } else {
2309 // Cleanup: delete B image, ignore errors.
2310 unlink(b_vdex_path.c_str());
2311 unlink(b_image_path.c_str());
2312 success = false;
2313 }
2314 return success;
2315}
2316
2317bool delete_odex(const char* apk_path, const char* instruction_set, const char* oat_dir) {
2318 // Delete the oat/odex file.
2319 char out_path[PKG_PATH_MAX];
Calin Juravle80a21252017-01-17 14:43:25 -08002320 if (!create_oat_out_path(apk_path, instruction_set, oat_dir,
Calin Juravle114f0812017-03-08 19:05:07 -08002321 /*is_secondary_dex*/false, out_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07002322 return false;
2323 }
2324
2325 // In case of a permission failure report the issue. Otherwise just print a warning.
2326 auto unlink_and_check = [](const char* path) -> bool {
2327 int result = unlink(path);
2328 if (result != 0) {
2329 if (errno == EACCES || errno == EPERM) {
2330 PLOG(ERROR) << "Could not unlink " << path;
2331 return false;
2332 }
2333 PLOG(WARNING) << "Could not unlink " << path;
2334 }
2335 return true;
2336 };
2337
2338 // Delete the oat/odex file.
2339 bool return_value_oat = unlink_and_check(out_path);
2340
2341 // Derive and delete the app image.
2342 bool return_value_art = unlink_and_check(create_image_filename(out_path).c_str());
2343
Nicolas Geoffray192fb962017-05-25 13:58:06 +01002344 // Derive and delete the vdex file.
2345 bool return_value_vdex = unlink_and_check(create_vdex_filename(out_path).c_str());
2346
Jeff Sharkey90aff262016-12-12 14:28:24 -07002347 // Report success.
Nicolas Geoffray192fb962017-05-25 13:58:06 +01002348 return return_value_oat && return_value_art && return_value_vdex;
Jeff Sharkey90aff262016-12-12 14:28:24 -07002349}
2350
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06002351static bool is_absolute_path(const std::string& path) {
2352 if (path.find('/') != 0 || path.find("..") != std::string::npos) {
2353 LOG(ERROR) << "Invalid absolute path " << path;
2354 return false;
2355 } else {
2356 return true;
2357 }
2358}
2359
2360static bool is_valid_instruction_set(const std::string& instruction_set) {
2361 // TODO: add explicit whitelisting of instruction sets
2362 if (instruction_set.find('/') != std::string::npos) {
2363 LOG(ERROR) << "Invalid instruction set " << instruction_set;
2364 return false;
2365 } else {
2366 return true;
2367 }
2368}
2369
2370bool calculate_oat_file_path_default(char path[PKG_PATH_MAX], const char *oat_dir,
2371 const char *apk_path, const char *instruction_set) {
2372 std::string oat_dir_ = oat_dir;
2373 std::string apk_path_ = apk_path;
2374 std::string instruction_set_ = instruction_set;
2375
2376 if (!is_absolute_path(oat_dir_)) return false;
2377 if (!is_absolute_path(apk_path_)) return false;
2378 if (!is_valid_instruction_set(instruction_set_)) return false;
2379
2380 std::string::size_type end = apk_path_.rfind('.');
2381 std::string::size_type start = apk_path_.rfind('/', end);
2382 if (end == std::string::npos || start == std::string::npos) {
2383 LOG(ERROR) << "Invalid apk_path " << apk_path_;
2384 return false;
2385 }
2386
2387 std::string res_ = oat_dir_ + '/' + instruction_set + '/'
2388 + apk_path_.substr(start + 1, end - start - 1) + ".odex";
2389 const char* res = res_.c_str();
2390 if (strlen(res) >= PKG_PATH_MAX) {
2391 LOG(ERROR) << "Result too large";
2392 return false;
2393 } else {
2394 strlcpy(path, res, PKG_PATH_MAX);
2395 return true;
2396 }
2397}
2398
2399bool calculate_odex_file_path_default(char path[PKG_PATH_MAX], const char *apk_path,
2400 const char *instruction_set) {
2401 std::string apk_path_ = apk_path;
2402 std::string instruction_set_ = instruction_set;
2403
2404 if (!is_absolute_path(apk_path_)) return false;
2405 if (!is_valid_instruction_set(instruction_set_)) return false;
2406
2407 std::string::size_type end = apk_path_.rfind('.');
2408 std::string::size_type start = apk_path_.rfind('/', end);
2409 if (end == std::string::npos || start == std::string::npos) {
2410 LOG(ERROR) << "Invalid apk_path " << apk_path_;
2411 return false;
2412 }
2413
2414 std::string oat_dir = apk_path_.substr(0, start + 1) + "oat";
2415 return calculate_oat_file_path_default(path, oat_dir.c_str(), apk_path, instruction_set);
2416}
2417
2418bool create_cache_path_default(char path[PKG_PATH_MAX], const char *src,
2419 const char *instruction_set) {
2420 std::string src_ = src;
2421 std::string instruction_set_ = instruction_set;
2422
2423 if (!is_absolute_path(src_)) return false;
2424 if (!is_valid_instruction_set(instruction_set_)) return false;
2425
2426 for (auto it = src_.begin() + 1; it < src_.end(); ++it) {
2427 if (*it == '/') {
2428 *it = '@';
2429 }
2430 }
2431
2432 std::string res_ = android_data_dir + DALVIK_CACHE + '/' + instruction_set_ + src_
2433 + DALVIK_CACHE_POSTFIX;
2434 const char* res = res_.c_str();
2435 if (strlen(res) >= PKG_PATH_MAX) {
2436 LOG(ERROR) << "Result too large";
2437 return false;
2438 } else {
2439 strlcpy(path, res, PKG_PATH_MAX);
2440 return true;
2441 }
2442}
2443
Calin Juravlec3596c32017-12-05 12:29:15 -08002444bool create_profile_snapshot(int32_t app_id, const std::string& package_name,
Calin Juravle824a64d2018-01-18 20:23:17 -08002445 const std::string& profile_name) {
Calin Juravle29591732017-11-20 17:46:19 -08002446 int app_shared_gid = multiuser_get_shared_gid(/*user_id*/ 0, app_id);
2447
Calin Juravle824a64d2018-01-18 20:23:17 -08002448 unique_fd snapshot_fd = open_spnashot_profile(AID_SYSTEM, package_name, profile_name);
Calin Juravle29591732017-11-20 17:46:19 -08002449 if (snapshot_fd < 0) {
2450 return false;
2451 }
2452
2453 std::vector<unique_fd> profiles_fd;
2454 unique_fd reference_profile_fd;
Calin Juravle824a64d2018-01-18 20:23:17 -08002455 open_profile_files(app_shared_gid, package_name, profile_name, /*is_secondary_dex*/ false,
2456 &profiles_fd, &reference_profile_fd);
Calin Juravle29591732017-11-20 17:46:19 -08002457 if (profiles_fd.empty() || (reference_profile_fd.get() < 0)) {
2458 return false;
2459 }
2460
2461 profiles_fd.push_back(std::move(reference_profile_fd));
2462
2463 pid_t pid = fork();
2464 if (pid == 0) {
2465 /* child -- drop privileges before continuing */
2466 drop_capabilities(app_shared_gid);
2467 run_profman_merge(profiles_fd, snapshot_fd);
2468 exit(42); /* only get here on exec failure */
2469 }
2470
2471 /* parent */
2472 int return_code = wait_child(pid);
2473 if (!WIFEXITED(return_code)) {
Calin Juravle824a64d2018-01-18 20:23:17 -08002474 LOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
Calin Juravle29591732017-11-20 17:46:19 -08002475 return false;
2476 }
2477
2478 return true;
2479}
2480
Calin Juravlec3b049e2018-01-18 22:32:58 -08002481bool prepare_app_profile(const std::string& package_name,
2482 userid_t user_id,
2483 appid_t app_id,
2484 const std::string& profile_name,
2485 const std::string& code_path ATTRIBUTE_UNUSED,
2486 const std::unique_ptr<std::string>& dex_metadata) {
2487 // Prepare the current profile.
2488 std::string cur_profile = create_current_profile_path(user_id, package_name, profile_name,
2489 /*is_secondary_dex*/ false);
2490 uid_t uid = multiuser_get_uid(user_id, app_id);
2491 if (fs_prepare_file_strict(cur_profile.c_str(), 0600, uid, uid) != 0) {
2492 PLOG(ERROR) << "Failed to prepare " << cur_profile;
2493 return false;
2494 }
2495
2496 // Check if we need to install the profile from the dex metadata.
2497 if (dex_metadata == nullptr) {
2498 return true;
2499 }
2500
2501 // We have a dex metdata. Merge the profile into the reference profile.
2502 unique_fd ref_profile_fd = open_reference_profile(uid, package_name, profile_name,
2503 /*read_write*/ true, /*is_secondary_dex*/ false);
2504 unique_fd dex_metadata_fd(TEMP_FAILURE_RETRY(
2505 open(dex_metadata->c_str(), O_RDONLY | O_NOFOLLOW)));
2506 std::vector<unique_fd> profiles_fd;
2507 profiles_fd.push_back(std::move(dex_metadata_fd));
2508
2509 pid_t pid = fork();
2510 if (pid == 0) {
2511 /* child -- drop privileges before continuing */
2512 gid_t app_shared_gid = multiuser_get_shared_gid(user_id, app_id);
2513 drop_capabilities(app_shared_gid);
2514
2515 // TODO(calin): the dex metadata profile might embed different names for the
2516 // same code path (e.g. YouTube.apk or base.apk, depending on how the initial
2517 // profile was captured). We should pass the code path to adjust the names in the profile.
2518 run_profman_merge(profiles_fd, ref_profile_fd);
2519 exit(42); /* only get here on exec failure */
2520 }
2521
2522 /* parent */
2523 int return_code = wait_child(pid);
2524 if (!WIFEXITED(return_code)) {
2525 PLOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
2526 return false;
2527 }
2528 return true;
2529}
2530
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07002531} // namespace installd
2532} // namespace android