blob: f281010e5897a171396041ce4a3b0c8de5f82c47 [file] [log] [blame]
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07001/*
2 * Copyright (C) 2016 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
Mark Salyzyna5e161b2016-09-29 08:08:05 -070016#define LOG_TAG "installed"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070017
Jeff Sharkey90aff262016-12-12 14:28:24 -070018#include <fcntl.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070019#include <stdlib.h>
20#include <string.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070021#include <sys/capability.h>
22#include <sys/file.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070023#include <sys/stat.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070024#include <sys/time.h>
25#include <sys/types.h>
26#include <sys/resource.h>
27#include <sys/wait.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070028#include <unistd.h>
29
30#include <android-base/logging.h>
Andreas Gampe6a9cf722017-07-24 16:49:10 -070031#include <android-base/properties.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070032#include <android-base/stringprintf.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070033#include <android-base/strings.h>
34#include <android-base/unique_fd.h>
Calin Juravle80a21252017-01-17 14:43:25 -080035#include <cutils/fs.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070036#include <cutils/properties.h>
37#include <cutils/sched_policy.h>
Mark Salyzyn7823e122016-09-29 08:08:05 -070038#include <log/log.h> // TODO: Move everything to base/logging.
Jeff Sharkey90aff262016-12-12 14:28:24 -070039#include <private/android_filesystem_config.h>
Calin Juravlecb556e32017-04-04 20:22:50 -070040#include <selinux/android.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070041#include <system/thread_defs.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070042
43#include "dexopt.h"
Jeff Sharkeyc1149c92017-09-21 14:51:09 -060044#include "globals.h"
Jeff Sharkey90aff262016-12-12 14:28:24 -070045#include "installd_deps.h"
46#include "otapreopt_utils.h"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070047#include "utils.h"
48
49using android::base::StringPrintf;
Jeff Sharkey90aff262016-12-12 14:28:24 -070050using android::base::EndsWith;
Calin Juravle1a0af3b2017-03-09 14:33:33 -080051using android::base::unique_fd;
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070052
53namespace android {
54namespace installd {
55
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -070056// Should minidebug info be included in compiled artifacts? Even if this value is
57// "true," usage might still be conditional to other constraints, e.g., system
58// property overrides.
59static constexpr bool kEnableMinidebugInfo = true;
60
61static constexpr const char* kMinidebugInfoSystemProperty = "dalvik.vm.dex2oat-minidebuginfo";
62static constexpr bool kMinidebugInfoSystemPropertyDefault = false;
63static constexpr const char* kMinidebugDex2oatFlag = "--generate-mini-debug-info";
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -080064static constexpr const char* kDisableCompactDexFlag = "--compact-dex-level=none";
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -070065
Calin Juravle114f0812017-03-08 19:05:07 -080066// Deleter using free() for use with std::unique_ptr<>. See also UniqueCPtr<> below.
67struct FreeDelete {
68 // NOTE: Deleting a const object is valid but free() takes a non-const pointer.
69 void operator()(const void* ptr) const {
70 free(const_cast<void*>(ptr));
71 }
72};
73
74// Alias for std::unique_ptr<> that uses the C function free() to delete objects.
75template <typename T>
76using UniqueCPtr = std::unique_ptr<T, FreeDelete>;
77
Calin Juravle1a0af3b2017-03-09 14:33:33 -080078static unique_fd invalid_unique_fd() {
79 return unique_fd(-1);
80}
81
Andreas Gampe6a9cf722017-07-24 16:49:10 -070082static bool is_debug_runtime() {
83 return android::base::GetProperty("persist.sys.dalvik.vm.lib.2", "") == "libartd.so";
84}
85
David Sehra3b5ab62017-10-25 14:27:29 -070086static bool is_debuggable_build() {
87 return android::base::GetBoolProperty("ro.debuggable", false);
88}
89
Jeff Sharkey90aff262016-12-12 14:28:24 -070090static bool clear_profile(const std::string& profile) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -080091 unique_fd ufd(open(profile.c_str(), O_WRONLY | O_NOFOLLOW | O_CLOEXEC));
Jeff Sharkey90aff262016-12-12 14:28:24 -070092 if (ufd.get() < 0) {
93 if (errno != ENOENT) {
94 PLOG(WARNING) << "Could not open profile " << profile;
95 return false;
96 } else {
97 // Nothing to clear. That's ok.
98 return true;
99 }
100 }
101
102 if (flock(ufd.get(), LOCK_EX | LOCK_NB) != 0) {
103 if (errno != EWOULDBLOCK) {
104 PLOG(WARNING) << "Error locking profile " << profile;
105 }
106 // This implies that the app owning this profile is running
107 // (and has acquired the lock).
108 //
109 // If we can't acquire the lock bail out since clearing is useless anyway
110 // (the app will write again to the profile).
111 //
112 // Note:
113 // This does not impact the this is not an issue for the profiling correctness.
114 // In case this is needed because of an app upgrade, profiles will still be
115 // eventually cleared by the app itself due to checksum mismatch.
116 // If this is needed because profman advised, then keeping the data around
117 // until the next run is again not an issue.
118 //
119 // If the app attempts to acquire a lock while we've held one here,
120 // it will simply skip the current write cycle.
121 return false;
122 }
123
124 bool truncated = ftruncate(ufd.get(), 0) == 0;
125 if (!truncated) {
126 PLOG(WARNING) << "Could not truncate " << profile;
127 }
128 if (flock(ufd.get(), LOCK_UN) != 0) {
129 PLOG(WARNING) << "Error unlocking profile " << profile;
130 }
131 return truncated;
132}
133
Calin Juravle114f0812017-03-08 19:05:07 -0800134// Clear the reference profile for the given location.
135// The location is the package name for primary apks or the dex path for secondary dex files.
136static bool clear_reference_profile(const std::string& location, bool is_secondary_dex) {
137 return clear_profile(create_reference_profile_path(location, is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700138}
139
Calin Juravle114f0812017-03-08 19:05:07 -0800140// Clear the reference profile for the given location.
141// The location is the package name for primary apks or the dex path for secondary dex files.
142static bool clear_current_profile(const std::string& pkgname, userid_t user,
143 bool is_secondary_dex) {
144 return clear_profile(create_current_profile_path(user, pkgname, is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700145}
146
Calin Juravle114f0812017-03-08 19:05:07 -0800147// Clear the reference profile for the primary apk of the given package.
148bool clear_primary_reference_profile(const std::string& pkgname) {
149 return clear_reference_profile(pkgname, /*is_secondary_dex*/false);
150}
151
152// Clear all current profile for the primary apk of the given package.
153bool clear_primary_current_profiles(const std::string& pkgname) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700154 bool success = true;
Calin Juravle114f0812017-03-08 19:05:07 -0800155 // For secondary dex files, we don't really need the user but we use it for sanity checks.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700156 std::vector<userid_t> users = get_known_users(/*volume_uuid*/ nullptr);
157 for (auto user : users) {
Calin Juravle114f0812017-03-08 19:05:07 -0800158 success &= clear_current_profile(pkgname, user, /*is_secondary_dex*/false);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700159 }
160 return success;
161}
162
Calin Juravle114f0812017-03-08 19:05:07 -0800163// Clear the current profile for the primary apk of the given package and user.
164bool clear_primary_current_profile(const std::string& pkgname, userid_t user) {
165 return clear_current_profile(pkgname, user, /*is_secondary_dex*/false);
166}
167
Jeff Sharkey90aff262016-12-12 14:28:24 -0700168static int split_count(const char *str)
169{
170 char *ctx;
171 int count = 0;
172 char buf[kPropertyValueMax];
173
Jeff Sharkeyc1149c92017-09-21 14:51:09 -0600174 strlcpy(buf, str, sizeof(buf));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700175 char *pBuf = buf;
176
177 while(strtok_r(pBuf, " ", &ctx) != NULL) {
178 count++;
179 pBuf = NULL;
180 }
181
182 return count;
183}
184
185static int split(char *buf, const char **argv)
186{
187 char *ctx;
188 int count = 0;
189 char *tok;
190 char *pBuf = buf;
191
192 while((tok = strtok_r(pBuf, " ", &ctx)) != NULL) {
193 argv[count++] = tok;
194 pBuf = NULL;
195 }
196
197 return count;
198}
199
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700200static const char* get_location_from_path(const char* path) {
201 static constexpr char kLocationSeparator = '/';
202 const char *location = strrchr(path, kLocationSeparator);
203 if (location == NULL) {
204 return path;
205 } else {
206 // Skip the separator character.
207 return location + 1;
208 }
209}
210
Jeff Sharkey90aff262016-12-12 14:28:24 -0700211static void run_dex2oat(int zip_fd, int oat_fd, int input_vdex_fd, int output_vdex_fd, int image_fd,
212 const char* input_file_name, const char* output_file_name, int swap_fd,
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100213 const char* instruction_set, const char* compiler_filter,
Andreas Gampea73a0cb2017-11-02 18:14:42 -0700214 bool debuggable, bool post_bootcomplete, bool background_job_compile, int profile_fd,
David Brazdil7fcbb812018-01-17 17:05:40 +0000215 const char* class_loader_context, int target_sdk_version, bool disable_hidden_api_checks) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700216 static const unsigned int MAX_INSTRUCTION_SET_LEN = 7;
217
218 if (strlen(instruction_set) >= MAX_INSTRUCTION_SET_LEN) {
219 ALOGE("Instruction set %s longer than max length of %d",
220 instruction_set, MAX_INSTRUCTION_SET_LEN);
221 return;
222 }
223
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700224 // Get the relative path to the input file.
225 const char* relative_input_file_name = get_location_from_path(input_file_name);
226
Jeff Sharkey90aff262016-12-12 14:28:24 -0700227 char dex2oat_Xms_flag[kPropertyValueMax];
228 bool have_dex2oat_Xms_flag = get_property("dalvik.vm.dex2oat-Xms", dex2oat_Xms_flag, NULL) > 0;
229
230 char dex2oat_Xmx_flag[kPropertyValueMax];
231 bool have_dex2oat_Xmx_flag = get_property("dalvik.vm.dex2oat-Xmx", dex2oat_Xmx_flag, NULL) > 0;
232
233 char dex2oat_threads_buf[kPropertyValueMax];
234 bool have_dex2oat_threads_flag = get_property(post_bootcomplete
235 ? "dalvik.vm.dex2oat-threads"
236 : "dalvik.vm.boot-dex2oat-threads",
237 dex2oat_threads_buf,
238 NULL) > 0;
239 char dex2oat_threads_arg[kPropertyValueMax + 2];
240 if (have_dex2oat_threads_flag) {
241 sprintf(dex2oat_threads_arg, "-j%s", dex2oat_threads_buf);
242 }
243
244 char dex2oat_isa_features_key[kPropertyKeyMax];
245 sprintf(dex2oat_isa_features_key, "dalvik.vm.isa.%s.features", instruction_set);
246 char dex2oat_isa_features[kPropertyValueMax];
247 bool have_dex2oat_isa_features = get_property(dex2oat_isa_features_key,
248 dex2oat_isa_features, NULL) > 0;
249
250 char dex2oat_isa_variant_key[kPropertyKeyMax];
251 sprintf(dex2oat_isa_variant_key, "dalvik.vm.isa.%s.variant", instruction_set);
252 char dex2oat_isa_variant[kPropertyValueMax];
253 bool have_dex2oat_isa_variant = get_property(dex2oat_isa_variant_key,
254 dex2oat_isa_variant, NULL) > 0;
255
256 const char *dex2oat_norelocation = "-Xnorelocate";
257 bool have_dex2oat_relocation_skip_flag = false;
258
259 char dex2oat_flags[kPropertyValueMax];
260 int dex2oat_flags_count = get_property("dalvik.vm.dex2oat-flags",
261 dex2oat_flags, NULL) <= 0 ? 0 : split_count(dex2oat_flags);
262 ALOGV("dalvik.vm.dex2oat-flags=%s\n", dex2oat_flags);
263
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100264 // If we are booting without the real /data, don't spend time compiling.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700265 char vold_decrypt[kPropertyValueMax];
266 bool have_vold_decrypt = get_property("vold.decrypt", vold_decrypt, "") > 0;
267 bool skip_compilation = (have_vold_decrypt &&
268 (strcmp(vold_decrypt, "trigger_restart_min_framework") == 0 ||
269 (strcmp(vold_decrypt, "1") == 0)));
270
271 bool generate_debug_info = property_get_bool("debug.generate-debug-info", false);
272
273 char app_image_format[kPropertyValueMax];
274 char image_format_arg[strlen("--image-format=") + kPropertyValueMax];
275 bool have_app_image_format =
276 image_fd >= 0 && get_property("dalvik.vm.appimageformat", app_image_format, NULL) > 0;
277 if (have_app_image_format) {
278 sprintf(image_format_arg, "--image-format=%s", app_image_format);
279 }
280
281 char dex2oat_large_app_threshold[kPropertyValueMax];
282 bool have_dex2oat_large_app_threshold =
283 get_property("dalvik.vm.dex2oat-very-large", dex2oat_large_app_threshold, NULL) > 0;
284 char dex2oat_large_app_threshold_arg[strlen("--very-large-app-threshold=") + kPropertyValueMax];
285 if (have_dex2oat_large_app_threshold) {
286 sprintf(dex2oat_large_app_threshold_arg,
287 "--very-large-app-threshold=%s",
288 dex2oat_large_app_threshold);
289 }
290
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700291 // If the runtime was requested to use libartd.so, we'll run dex2oatd, otherwise dex2oat.
David Sehra3b5ab62017-10-25 14:27:29 -0700292 const char* dex2oat_bin = "/system/bin/dex2oat";
293 static const char* kDex2oatDebugPath = "/system/bin/dex2oatd";
Andreas Gampea73a0cb2017-11-02 18:14:42 -0700294 if (is_debug_runtime() || (background_job_compile && is_debuggable_build())) {
David Sehra3b5ab62017-10-25 14:27:29 -0700295 DCHECK(access(kDex2oatDebugPath, X_OK) == 0);
296 dex2oat_bin = kDex2oatDebugPath;
297 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700298
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -0700299 bool generate_minidebug_info = kEnableMinidebugInfo &&
300 android::base::GetBoolProperty(kMinidebugInfoSystemProperty,
301 kMinidebugInfoSystemPropertyDefault);
302
Jeff Sharkey90aff262016-12-12 14:28:24 -0700303 static const char* RUNTIME_ARG = "--runtime-arg";
304
305 static const int MAX_INT_LEN = 12; // '-'+10dig+'\0' -OR- 0x+8dig
306
George Burgess IV36cebe772017-01-25 11:52:01 -0800307 // clang FORTIFY doesn't let us use strlen in constant array bounds, so we
308 // use arraysize instead.
309 char zip_fd_arg[arraysize("--zip-fd=") + MAX_INT_LEN];
310 char zip_location_arg[arraysize("--zip-location=") + PKG_PATH_MAX];
311 char input_vdex_fd_arg[arraysize("--input-vdex-fd=") + MAX_INT_LEN];
312 char output_vdex_fd_arg[arraysize("--output-vdex-fd=") + MAX_INT_LEN];
313 char oat_fd_arg[arraysize("--oat-fd=") + MAX_INT_LEN];
314 char oat_location_arg[arraysize("--oat-location=") + PKG_PATH_MAX];
315 char instruction_set_arg[arraysize("--instruction-set=") + MAX_INSTRUCTION_SET_LEN];
316 char instruction_set_variant_arg[arraysize("--instruction-set-variant=") + kPropertyValueMax];
317 char instruction_set_features_arg[arraysize("--instruction-set-features=") + kPropertyValueMax];
318 char dex2oat_Xms_arg[arraysize("-Xms") + kPropertyValueMax];
319 char dex2oat_Xmx_arg[arraysize("-Xmx") + kPropertyValueMax];
320 char dex2oat_compiler_filter_arg[arraysize("--compiler-filter=") + kPropertyValueMax];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700321 bool have_dex2oat_swap_fd = false;
George Burgess IV36cebe772017-01-25 11:52:01 -0800322 char dex2oat_swap_fd[arraysize("--swap-fd=") + MAX_INT_LEN];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700323 bool have_dex2oat_image_fd = false;
George Burgess IV36cebe772017-01-25 11:52:01 -0800324 char dex2oat_image_fd[arraysize("--app-image-fd=") + MAX_INT_LEN];
Calin Juravle52c45822017-07-13 22:50:21 -0700325 size_t class_loader_context_size = arraysize("--class-loader-context=") + PKG_PATH_MAX;
David Brazdil570d3982018-01-16 20:15:43 +0000326 char target_sdk_version_arg[arraysize("-Xtarget-sdk-version:") + MAX_INT_LEN];
Calin Juravle52c45822017-07-13 22:50:21 -0700327 char class_loader_context_arg[class_loader_context_size];
328 if (class_loader_context != nullptr) {
329 snprintf(class_loader_context_arg, class_loader_context_size, "--class-loader-context=%s",
330 class_loader_context);
331 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700332
333 sprintf(zip_fd_arg, "--zip-fd=%d", zip_fd);
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700334 sprintf(zip_location_arg, "--zip-location=%s", relative_input_file_name);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700335 sprintf(input_vdex_fd_arg, "--input-vdex-fd=%d", input_vdex_fd);
336 sprintf(output_vdex_fd_arg, "--output-vdex-fd=%d", output_vdex_fd);
337 sprintf(oat_fd_arg, "--oat-fd=%d", oat_fd);
338 sprintf(oat_location_arg, "--oat-location=%s", output_file_name);
339 sprintf(instruction_set_arg, "--instruction-set=%s", instruction_set);
340 sprintf(instruction_set_variant_arg, "--instruction-set-variant=%s", dex2oat_isa_variant);
341 sprintf(instruction_set_features_arg, "--instruction-set-features=%s", dex2oat_isa_features);
342 if (swap_fd >= 0) {
343 have_dex2oat_swap_fd = true;
344 sprintf(dex2oat_swap_fd, "--swap-fd=%d", swap_fd);
345 }
346 if (image_fd >= 0) {
347 have_dex2oat_image_fd = true;
348 sprintf(dex2oat_image_fd, "--app-image-fd=%d", image_fd);
349 }
350
351 if (have_dex2oat_Xms_flag) {
352 sprintf(dex2oat_Xms_arg, "-Xms%s", dex2oat_Xms_flag);
353 }
354 if (have_dex2oat_Xmx_flag) {
355 sprintf(dex2oat_Xmx_arg, "-Xmx%s", dex2oat_Xmx_flag);
356 }
David Brazdil570d3982018-01-16 20:15:43 +0000357 sprintf(target_sdk_version_arg, "-Xtarget-sdk-version:%d", target_sdk_version);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700358
359 // Compute compiler filter.
360
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100361 bool have_dex2oat_compiler_filter_flag = false;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700362 if (skip_compilation) {
Jeff Sharkeyc1149c92017-09-21 14:51:09 -0600363 strlcpy(dex2oat_compiler_filter_arg, "--compiler-filter=extract",
364 sizeof(dex2oat_compiler_filter_arg));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700365 have_dex2oat_compiler_filter_flag = true;
366 have_dex2oat_relocation_skip_flag = true;
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100367 } else if (compiler_filter != nullptr) {
368 if (strlen(compiler_filter) + strlen("--compiler-filter=") <
Jeff Sharkey90aff262016-12-12 14:28:24 -0700369 arraysize(dex2oat_compiler_filter_arg)) {
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100370 sprintf(dex2oat_compiler_filter_arg, "--compiler-filter=%s", compiler_filter);
371 have_dex2oat_compiler_filter_flag = true;
372 } else {
373 ALOGW("Compiler filter name '%s' is too large (max characters is %zu)",
374 compiler_filter,
375 kPropertyValueMax);
376 }
377 }
378
379 if (!have_dex2oat_compiler_filter_flag) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700380 char dex2oat_compiler_filter_flag[kPropertyValueMax];
381 have_dex2oat_compiler_filter_flag = get_property("dalvik.vm.dex2oat-filter",
382 dex2oat_compiler_filter_flag, NULL) > 0;
383 if (have_dex2oat_compiler_filter_flag) {
384 sprintf(dex2oat_compiler_filter_arg,
385 "--compiler-filter=%s",
386 dex2oat_compiler_filter_flag);
387 }
388 }
389
390 // Check whether all apps should be compiled debuggable.
391 if (!debuggable) {
392 char prop_buf[kPropertyValueMax];
393 debuggable =
394 (get_property("dalvik.vm.always_debuggable", prop_buf, "0") > 0) &&
395 (prop_buf[0] == '1');
396 }
397 char profile_arg[strlen("--profile-file-fd=") + MAX_INT_LEN];
398 if (profile_fd != -1) {
399 sprintf(profile_arg, "--profile-file-fd=%d", profile_fd);
400 }
401
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700402 // Get the directory of the apk to pass as a base classpath directory.
403 char base_dir[arraysize("--classpath-dir=") + PKG_PATH_MAX];
404 std::string apk_dir(input_file_name);
405 unsigned long dir_index = apk_dir.rfind('/');
406 bool has_base_dir = dir_index != std::string::npos;
407 if (has_base_dir) {
408 apk_dir = apk_dir.substr(0, dir_index);
409 sprintf(base_dir, "--classpath-dir=%s", apk_dir.c_str());
410 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700411
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700412
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700413 ALOGV("Running %s in=%s out=%s\n", dex2oat_bin, relative_input_file_name, output_file_name);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700414
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800415 // Disable cdex if update input vdex is true since this combination of options is not
416 // supported.
Mathieu Chartier1fb463e2018-01-09 15:16:10 -0800417 // Disable cdex for non-background compiles since we don't want to regress app install until
418 // there are enough benefits to justify the tradeoff.
419 const bool disable_cdex = !background_job_compile || (input_vdex_fd == output_vdex_fd);
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800420
Jeff Sharkey90aff262016-12-12 14:28:24 -0700421 const char* argv[9 // program name, mandatory arguments and the final NULL
422 + (have_dex2oat_isa_variant ? 1 : 0)
423 + (have_dex2oat_isa_features ? 1 : 0)
424 + (have_dex2oat_Xms_flag ? 2 : 0)
425 + (have_dex2oat_Xmx_flag ? 2 : 0)
426 + (have_dex2oat_compiler_filter_flag ? 1 : 0)
427 + (have_dex2oat_threads_flag ? 1 : 0)
428 + (have_dex2oat_swap_fd ? 1 : 0)
429 + (have_dex2oat_image_fd ? 1 : 0)
430 + (have_dex2oat_relocation_skip_flag ? 2 : 0)
431 + (generate_debug_info ? 1 : 0)
432 + (debuggable ? 1 : 0)
433 + (have_app_image_format ? 1 : 0)
434 + dex2oat_flags_count
435 + (profile_fd == -1 ? 0 : 1)
Calin Juravle52c45822017-07-13 22:50:21 -0700436 + (class_loader_context != nullptr ? 1 : 0)
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700437 + (has_base_dir ? 1 : 0)
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -0700438 + (have_dex2oat_large_app_threshold ? 1 : 0)
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800439 + (disable_cdex ? 1 : 0)
David Brazdil570d3982018-01-16 20:15:43 +0000440 + (generate_minidebug_info ? 1 : 0)
David Brazdil7fcbb812018-01-17 17:05:40 +0000441 + (target_sdk_version != 0 ? 2 : 0)
442 + (disable_hidden_api_checks ? 2 : 0)];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700443 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700444 argv[i++] = dex2oat_bin;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700445 argv[i++] = zip_fd_arg;
446 argv[i++] = zip_location_arg;
447 argv[i++] = input_vdex_fd_arg;
448 argv[i++] = output_vdex_fd_arg;
449 argv[i++] = oat_fd_arg;
450 argv[i++] = oat_location_arg;
451 argv[i++] = instruction_set_arg;
452 if (have_dex2oat_isa_variant) {
453 argv[i++] = instruction_set_variant_arg;
454 }
455 if (have_dex2oat_isa_features) {
456 argv[i++] = instruction_set_features_arg;
457 }
458 if (have_dex2oat_Xms_flag) {
459 argv[i++] = RUNTIME_ARG;
460 argv[i++] = dex2oat_Xms_arg;
461 }
462 if (have_dex2oat_Xmx_flag) {
463 argv[i++] = RUNTIME_ARG;
464 argv[i++] = dex2oat_Xmx_arg;
465 }
466 if (have_dex2oat_compiler_filter_flag) {
467 argv[i++] = dex2oat_compiler_filter_arg;
468 }
469 if (have_dex2oat_threads_flag) {
470 argv[i++] = dex2oat_threads_arg;
471 }
472 if (have_dex2oat_swap_fd) {
473 argv[i++] = dex2oat_swap_fd;
474 }
475 if (have_dex2oat_image_fd) {
476 argv[i++] = dex2oat_image_fd;
477 }
478 if (generate_debug_info) {
479 argv[i++] = "--generate-debug-info";
480 }
481 if (debuggable) {
482 argv[i++] = "--debuggable";
483 }
484 if (have_app_image_format) {
485 argv[i++] = image_format_arg;
486 }
487 if (have_dex2oat_large_app_threshold) {
488 argv[i++] = dex2oat_large_app_threshold_arg;
489 }
490 if (dex2oat_flags_count) {
491 i += split(dex2oat_flags, argv + i);
492 }
493 if (have_dex2oat_relocation_skip_flag) {
494 argv[i++] = RUNTIME_ARG;
495 argv[i++] = dex2oat_norelocation;
496 }
497 if (profile_fd != -1) {
498 argv[i++] = profile_arg;
499 }
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700500 if (has_base_dir) {
501 argv[i++] = base_dir;
502 }
Calin Juravle52c45822017-07-13 22:50:21 -0700503 if (class_loader_context != nullptr) {
504 argv[i++] = class_loader_context_arg;
505 }
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -0700506 if (generate_minidebug_info) {
507 argv[i++] = kMinidebugDex2oatFlag;
508 }
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800509 if (disable_cdex) {
510 argv[i++] = kDisableCompactDexFlag;
511 }
David Brazdil570d3982018-01-16 20:15:43 +0000512 if (target_sdk_version != 0) {
513 argv[i++] = RUNTIME_ARG;
514 argv[i++] = target_sdk_version_arg;
515 }
David Brazdil7fcbb812018-01-17 17:05:40 +0000516 if (disable_hidden_api_checks) {
517 argv[i++] = RUNTIME_ARG;
518 argv[i++] = "-Xno-hidden-api-checks";
519 }
Calin Juravle52c45822017-07-13 22:50:21 -0700520
Jeff Sharkey90aff262016-12-12 14:28:24 -0700521 // Do not add after dex2oat_flags, they should override others for debugging.
522 argv[i] = NULL;
523
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700524 execv(dex2oat_bin, (char * const *)argv);
525 ALOGE("execv(%s) failed: %s\n", dex2oat_bin, strerror(errno));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700526}
527
528/*
529 * Whether dexopt should use a swap file when compiling an APK.
530 *
531 * If kAlwaysProvideSwapFile, do this on all devices (dex2oat will make a more informed decision
532 * itself, anyways).
533 *
534 * Otherwise, read "dalvik.vm.dex2oat-swap". If the property exists, return whether it is "true".
535 *
536 * Otherwise, return true if this is a low-mem device.
537 *
538 * Otherwise, return default value.
539 */
540static bool kAlwaysProvideSwapFile = false;
541static bool kDefaultProvideSwapFile = true;
542
543static bool ShouldUseSwapFileForDexopt() {
544 if (kAlwaysProvideSwapFile) {
545 return true;
546 }
547
548 // Check the "override" property. If it exists, return value == "true".
549 char dex2oat_prop_buf[kPropertyValueMax];
550 if (get_property("dalvik.vm.dex2oat-swap", dex2oat_prop_buf, "") > 0) {
551 if (strcmp(dex2oat_prop_buf, "true") == 0) {
552 return true;
553 } else {
554 return false;
555 }
556 }
557
558 // Shortcut for default value. This is an implementation optimization for the process sketched
559 // above. If the default value is true, we can avoid to check whether this is a low-mem device,
560 // as low-mem is never returning false. The compiler will optimize this away if it can.
561 if (kDefaultProvideSwapFile) {
562 return true;
563 }
564
565 bool is_low_mem = property_get_bool("ro.config.low_ram", false);
566 if (is_low_mem) {
567 return true;
568 }
569
570 // Default value must be false here.
571 return kDefaultProvideSwapFile;
572}
573
Richard Uhler76cc0272016-12-08 10:46:35 +0000574static void SetDex2OatScheduling(bool set_to_bg) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700575 if (set_to_bg) {
576 if (set_sched_policy(0, SP_BACKGROUND) < 0) {
577 ALOGE("set_sched_policy failed: %s\n", strerror(errno));
578 exit(70);
579 }
580 if (setpriority(PRIO_PROCESS, 0, ANDROID_PRIORITY_BACKGROUND) < 0) {
581 ALOGE("setpriority failed: %s\n", strerror(errno));
582 exit(71);
583 }
584 }
585}
586
Calin Juravle29591732017-11-20 17:46:19 -0800587static unique_fd create_profile(uid_t uid, const std::string& profile, int32_t flags) {
588 unique_fd fd(TEMP_FAILURE_RETRY(open(profile.c_str(), flags, 0600)));
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800589 if (fd.get() < 0) {
Calin Juravle29591732017-11-20 17:46:19 -0800590 if (errno != EEXIST) {
Calin Juravle114f0812017-03-08 19:05:07 -0800591 PLOG(ERROR) << "Failed to create profile " << profile;
Calin Juravle29591732017-11-20 17:46:19 -0800592 return invalid_unique_fd();
Calin Juravle114f0812017-03-08 19:05:07 -0800593 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700594 }
Calin Juravle114f0812017-03-08 19:05:07 -0800595 // Profiles should belong to the app; make sure of that by giving ownership to
596 // the app uid. If we cannot do that, there's no point in returning the fd
597 // since dex2oat/profman will fail with SElinux denials.
598 if (fchown(fd.get(), uid, uid) < 0) {
599 PLOG(ERROR) << "Could not chwon profile " << profile;
Calin Juravle29591732017-11-20 17:46:19 -0800600 return invalid_unique_fd();
Calin Juravle114f0812017-03-08 19:05:07 -0800601 }
Calin Juravle29591732017-11-20 17:46:19 -0800602 return fd;
Calin Juravle114f0812017-03-08 19:05:07 -0800603}
604
Calin Juravle29591732017-11-20 17:46:19 -0800605static unique_fd open_profile(uid_t uid, const std::string& profile, int32_t flags) {
Calin Juravle114f0812017-03-08 19:05:07 -0800606 // Do not follow symlinks when opening a profile:
607 // - primary profiles should not contain symlinks in their paths
608 // - secondary dex paths should have been already resolved and validated
609 flags |= O_NOFOLLOW;
610
Calin Juravle29591732017-11-20 17:46:19 -0800611 // Check if we need to create the profile
612 // Reference profiles and snapshots are created on the fly; so they might not exist beforehand.
613 unique_fd fd;
614 if ((flags & O_CREAT) != 0) {
615 fd = create_profile(uid, profile, flags);
616 } else {
617 fd.reset(TEMP_FAILURE_RETRY(open(profile.c_str(), flags)));
618 }
619
Calin Juravle114f0812017-03-08 19:05:07 -0800620 if (fd.get() < 0) {
621 if (errno != ENOENT) {
622 // Profiles might be missing for various reasons. For example, in a
623 // multi-user environment, the profile directory for one user can be created
624 // after we start a merge. In this case the current profile for that user
625 // will not be found.
626 // Also, the secondary dex profiles might be deleted by the app at any time,
627 // so we can't we need to prepare if they are missing.
628 PLOG(ERROR) << "Failed to open profile " << profile;
629 }
630 return invalid_unique_fd();
631 }
632
Jeff Sharkey90aff262016-12-12 14:28:24 -0700633 return fd;
634}
635
Calin Juravle114f0812017-03-08 19:05:07 -0800636static unique_fd open_current_profile(uid_t uid, userid_t user, const std::string& location,
637 bool is_secondary_dex) {
638 std::string profile = create_current_profile_path(user, location, is_secondary_dex);
Calin Juravle29591732017-11-20 17:46:19 -0800639 return open_profile(uid, profile, O_RDONLY);
Calin Juravle114f0812017-03-08 19:05:07 -0800640}
641
642static unique_fd open_reference_profile(uid_t uid, const std::string& location, bool read_write,
643 bool is_secondary_dex) {
644 std::string profile = create_reference_profile_path(location, is_secondary_dex);
Calin Juravle29591732017-11-20 17:46:19 -0800645 return open_profile(uid, profile, read_write ? (O_CREAT | O_RDWR) : O_RDONLY);
646}
647
648static unique_fd open_spnashot_profile(uid_t uid, const std::string& package_name,
649 const std::string& code_path) {
650 std::string profile = create_snapshot_profile_path(package_name, code_path);
651 return open_profile(uid, profile, O_CREAT | O_RDWR | O_TRUNC);
Calin Juravle114f0812017-03-08 19:05:07 -0800652}
653
654static void open_profile_files(uid_t uid, const std::string& location, bool is_secondary_dex,
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800655 /*out*/ std::vector<unique_fd>* profiles_fd, /*out*/ unique_fd* reference_profile_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700656 // Open the reference profile in read-write mode as profman might need to save the merge.
Calin Juravle114f0812017-03-08 19:05:07 -0800657 *reference_profile_fd = open_reference_profile(uid, location, /*read_write*/ true,
658 is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700659
Calin Juravle114f0812017-03-08 19:05:07 -0800660 // For secondary dex files, we don't really need the user but we use it for sanity checks.
661 // Note: the user owning the dex file should be the current user.
662 std::vector<userid_t> users;
663 if (is_secondary_dex){
664 users.push_back(multiuser_get_user_id(uid));
665 } else {
666 users = get_known_users(/*volume_uuid*/ nullptr);
667 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700668 for (auto user : users) {
Calin Juravle114f0812017-03-08 19:05:07 -0800669 unique_fd profile_fd = open_current_profile(uid, user, location, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700670 // Add to the lists only if both fds are valid.
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800671 if (profile_fd.get() >= 0) {
672 profiles_fd->push_back(std::move(profile_fd));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700673 }
674 }
675}
676
677static void drop_capabilities(uid_t uid) {
678 if (setgid(uid) != 0) {
679 ALOGE("setgid(%d) failed in installd during dexopt\n", uid);
680 exit(64);
681 }
682 if (setuid(uid) != 0) {
683 ALOGE("setuid(%d) failed in installd during dexopt\n", uid);
684 exit(65);
685 }
686 // drop capabilities
687 struct __user_cap_header_struct capheader;
688 struct __user_cap_data_struct capdata[2];
689 memset(&capheader, 0, sizeof(capheader));
690 memset(&capdata, 0, sizeof(capdata));
691 capheader.version = _LINUX_CAPABILITY_VERSION_3;
692 if (capset(&capheader, &capdata[0]) < 0) {
693 ALOGE("capset failed: %s\n", strerror(errno));
694 exit(66);
695 }
696}
697
698static constexpr int PROFMAN_BIN_RETURN_CODE_COMPILE = 0;
699static constexpr int PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION = 1;
700static constexpr int PROFMAN_BIN_RETURN_CODE_BAD_PROFILES = 2;
701static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_IO = 3;
702static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING = 4;
703
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800704static void run_profman_merge(const std::vector<unique_fd>& profiles_fd,
705 const unique_fd& reference_profile_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700706 static const size_t MAX_INT_LEN = 32;
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700707 const char* profman_bin = is_debug_runtime() ? "/system/bin/profmand" : "/system/bin/profman";
Jeff Sharkey90aff262016-12-12 14:28:24 -0700708
709 std::vector<std::string> profile_args(profiles_fd.size());
710 char profile_buf[strlen("--profile-file-fd=") + MAX_INT_LEN];
711 for (size_t k = 0; k < profiles_fd.size(); k++) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800712 sprintf(profile_buf, "--profile-file-fd=%d", profiles_fd[k].get());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700713 profile_args[k].assign(profile_buf);
714 }
715 char reference_profile_arg[strlen("--reference-profile-file-fd=") + MAX_INT_LEN];
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800716 sprintf(reference_profile_arg, "--reference-profile-file-fd=%d", reference_profile_fd.get());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700717
718 // program name, reference profile fd, the final NULL and the profile fds
719 const char* argv[3 + profiles_fd.size()];
720 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700721 argv[i++] = profman_bin;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700722 argv[i++] = reference_profile_arg;
723 for (size_t k = 0; k < profile_args.size(); k++) {
724 argv[i++] = profile_args[k].c_str();
725 }
726 // Do not add after dex2oat_flags, they should override others for debugging.
727 argv[i] = NULL;
728
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700729 execv(profman_bin, (char * const *)argv);
730 ALOGE("execv(%s) failed: %s\n", profman_bin, strerror(errno));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700731 exit(68); /* only get here on exec failure */
732}
733
734// Decides if profile guided compilation is needed or not based on existing profiles.
Calin Juravle114f0812017-03-08 19:05:07 -0800735// The location is the package name for primary apks or the dex path for secondary dex files.
736// Returns true if there is enough information in the current profiles that makes it
737// worth to recompile the given location.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700738// If the return value is true all the current profiles would have been merged into
739// the reference profiles accessible with open_reference_profile().
Calin Juravle114f0812017-03-08 19:05:07 -0800740static bool analyze_profiles(uid_t uid, const std::string& location, bool is_secondary_dex) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800741 std::vector<unique_fd> profiles_fd;
742 unique_fd reference_profile_fd;
Calin Juravle114f0812017-03-08 19:05:07 -0800743 open_profile_files(uid, location, is_secondary_dex, &profiles_fd, &reference_profile_fd);
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800744 if (profiles_fd.empty() || (reference_profile_fd.get() < 0)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700745 // Skip profile guided compilation because no profiles were found.
746 // Or if the reference profile info couldn't be opened.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700747 return false;
748 }
749
Jeff Sharkey90aff262016-12-12 14:28:24 -0700750 pid_t pid = fork();
751 if (pid == 0) {
752 /* child -- drop privileges before continuing */
753 drop_capabilities(uid);
754 run_profman_merge(profiles_fd, reference_profile_fd);
755 exit(68); /* only get here on exec failure */
756 }
757 /* parent */
758 int return_code = wait_child(pid);
759 bool need_to_compile = false;
760 bool should_clear_current_profiles = false;
761 bool should_clear_reference_profile = false;
762 if (!WIFEXITED(return_code)) {
Calin Juravle114f0812017-03-08 19:05:07 -0800763 LOG(WARNING) << "profman failed for location " << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700764 } else {
765 return_code = WEXITSTATUS(return_code);
766 switch (return_code) {
767 case PROFMAN_BIN_RETURN_CODE_COMPILE:
768 need_to_compile = true;
769 should_clear_current_profiles = true;
770 should_clear_reference_profile = false;
771 break;
772 case PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION:
773 need_to_compile = false;
774 should_clear_current_profiles = false;
775 should_clear_reference_profile = false;
776 break;
777 case PROFMAN_BIN_RETURN_CODE_BAD_PROFILES:
Calin Juravle114f0812017-03-08 19:05:07 -0800778 LOG(WARNING) << "Bad profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700779 need_to_compile = false;
780 should_clear_current_profiles = true;
781 should_clear_reference_profile = true;
782 break;
783 case PROFMAN_BIN_RETURN_CODE_ERROR_IO: // fall-through
784 case PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING:
785 // Temporary IO problem (e.g. locking). Ignore but log a warning.
Calin Juravle114f0812017-03-08 19:05:07 -0800786 LOG(WARNING) << "IO error while reading profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700787 need_to_compile = false;
788 should_clear_current_profiles = false;
789 should_clear_reference_profile = false;
790 break;
791 default:
792 // Unknown return code or error. Unlink profiles.
Calin Juravle114f0812017-03-08 19:05:07 -0800793 LOG(WARNING) << "Unknown error code while processing profiles for location "
794 << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700795 need_to_compile = false;
796 should_clear_current_profiles = true;
797 should_clear_reference_profile = true;
798 break;
799 }
800 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800801
Jeff Sharkey90aff262016-12-12 14:28:24 -0700802 if (should_clear_current_profiles) {
Calin Juravle114f0812017-03-08 19:05:07 -0800803 if (is_secondary_dex) {
804 // For secondary dex files, the owning user is the current user.
805 clear_current_profile(location, multiuser_get_user_id(uid), is_secondary_dex);
806 } else {
807 clear_primary_current_profiles(location);
808 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700809 }
810 if (should_clear_reference_profile) {
Calin Juravle114f0812017-03-08 19:05:07 -0800811 clear_reference_profile(location, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700812 }
813 return need_to_compile;
814}
815
Calin Juravle114f0812017-03-08 19:05:07 -0800816// Decides if profile guided compilation is needed or not based on existing profiles.
817// The analysis is done for the primary apks of the given package.
818// Returns true if there is enough information in the current profiles that makes it
819// worth to recompile the package.
820// If the return value is true all the current profiles would have been merged into
821// the reference profiles accessible with open_reference_profile().
822bool analyze_primary_profiles(uid_t uid, const std::string& pkgname) {
823 return analyze_profiles(uid, pkgname, /*is_secondary_dex*/false);
824}
825
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800826static void run_profman_dump(const std::vector<unique_fd>& profile_fds,
827 const unique_fd& reference_profile_fd,
Jeff Sharkey90aff262016-12-12 14:28:24 -0700828 const std::vector<std::string>& dex_locations,
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800829 const std::vector<unique_fd>& apk_fds,
830 const unique_fd& output_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700831 std::vector<std::string> profman_args;
832 static const char* PROFMAN_BIN = "/system/bin/profman";
833 profman_args.push_back(PROFMAN_BIN);
834 profman_args.push_back("--dump-only");
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800835 profman_args.push_back(StringPrintf("--dump-output-to-fd=%d", output_fd.get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700836 if (reference_profile_fd != -1) {
837 profman_args.push_back(StringPrintf("--reference-profile-file-fd=%d",
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800838 reference_profile_fd.get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700839 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800840 for (size_t i = 0; i < profile_fds.size(); i++) {
841 profman_args.push_back(StringPrintf("--profile-file-fd=%d", profile_fds[i].get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700842 }
843 for (const std::string& dex_location : dex_locations) {
844 profman_args.push_back(StringPrintf("--dex-location=%s", dex_location.c_str()));
845 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800846 for (size_t i = 0; i < apk_fds.size(); i++) {
847 profman_args.push_back(StringPrintf("--apk-fd=%d", apk_fds[i].get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700848 }
849 const char **argv = new const char*[profman_args.size() + 1];
850 size_t i = 0;
851 for (const std::string& profman_arg : profman_args) {
852 argv[i++] = profman_arg.c_str();
853 }
854 argv[i] = NULL;
855
856 execv(PROFMAN_BIN, (char * const *)argv);
857 ALOGE("execv(%s) failed: %s\n", PROFMAN_BIN, strerror(errno));
858 exit(68); /* only get here on exec failure */
859}
860
Calin Juravle76268c52017-03-09 13:19:42 -0800861bool dump_profiles(int32_t uid, const std::string& pkgname, const char* code_paths) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800862 std::vector<unique_fd> profile_fds;
863 unique_fd reference_profile_fd;
Calin Juravle76268c52017-03-09 13:19:42 -0800864 std::string out_file_name = StringPrintf("/data/misc/profman/%s.txt", pkgname.c_str());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700865
Calin Juravle114f0812017-03-08 19:05:07 -0800866 open_profile_files(uid, pkgname, /*is_secondary_dex*/false,
867 &profile_fds, &reference_profile_fd);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700868
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800869 const bool has_reference_profile = (reference_profile_fd.get() != -1);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700870 const bool has_profiles = !profile_fds.empty();
871
872 if (!has_reference_profile && !has_profiles) {
Calin Juravle76268c52017-03-09 13:19:42 -0800873 LOG(ERROR) << "profman dump: no profiles to dump for " << pkgname;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700874 return false;
875 }
876
Calin Juravle114f0812017-03-08 19:05:07 -0800877 unique_fd output_fd(open(out_file_name.c_str(),
878 O_WRONLY | O_CREAT | O_TRUNC | O_NOFOLLOW, 0644));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700879 if (fchmod(output_fd, S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH) < 0) {
880 ALOGE("installd cannot chmod '%s' dump_profile\n", out_file_name.c_str());
881 return false;
882 }
883 std::vector<std::string> code_full_paths = base::Split(code_paths, ";");
884 std::vector<std::string> dex_locations;
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800885 std::vector<unique_fd> apk_fds;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700886 for (const std::string& code_full_path : code_full_paths) {
887 const char* full_path = code_full_path.c_str();
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800888 unique_fd apk_fd(open(full_path, O_RDONLY | O_NOFOLLOW));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700889 if (apk_fd == -1) {
890 ALOGE("installd cannot open '%s'\n", full_path);
891 return false;
892 }
893 dex_locations.push_back(get_location_from_path(full_path));
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800894 apk_fds.push_back(std::move(apk_fd));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700895 }
896
897 pid_t pid = fork();
898 if (pid == 0) {
899 /* child -- drop privileges before continuing */
900 drop_capabilities(uid);
901 run_profman_dump(profile_fds, reference_profile_fd, dex_locations,
902 apk_fds, output_fd);
903 exit(68); /* only get here on exec failure */
904 }
905 /* parent */
Jeff Sharkey90aff262016-12-12 14:28:24 -0700906 int return_code = wait_child(pid);
907 if (!WIFEXITED(return_code)) {
908 LOG(WARNING) << "profman failed for package " << pkgname << ": "
909 << return_code;
910 return false;
911 }
912 return true;
913}
914
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700915bool copy_system_profile(const std::string& system_profile,
916 uid_t packageUid, const std::string& data_profile_location) {
917 unique_fd in_fd(open(system_profile.c_str(), O_RDONLY | O_NOFOLLOW | O_CLOEXEC));
918 unique_fd out_fd(open_reference_profile(packageUid,
919 data_profile_location,
920 /*read_write*/ true,
921 /*secondary*/ false));
922 if (in_fd.get() < 0) {
923 PLOG(WARNING) << "Could not open profile " << system_profile;
924 return false;
925 }
926 if (out_fd.get() < 0) {
927 PLOG(WARNING) << "Could not open profile " << data_profile_location;
928 return false;
929 }
930
Mathieu Chartier78f71fe2017-06-14 13:02:26 -0700931 // As a security measure we want to write the profile information with the reduced capabilities
932 // of the package user id. So we fork and drop capabilities in the child.
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700933 pid_t pid = fork();
934 if (pid == 0) {
935 /* child -- drop privileges before continuing */
936 drop_capabilities(packageUid);
937
938 if (flock(out_fd.get(), LOCK_EX | LOCK_NB) != 0) {
939 if (errno != EWOULDBLOCK) {
940 PLOG(WARNING) << "Error locking profile " << data_profile_location;
941 }
942 // This implies that the app owning this profile is running
943 // (and has acquired the lock).
944 //
945 // The app never acquires the lock for the reference profiles of primary apks.
946 // Only dex2oat from installd will do that. Since installd is single threaded
947 // we should not see this case. Nevertheless be prepared for it.
948 PLOG(WARNING) << "Failed to flock " << data_profile_location;
949 return false;
950 }
951
952 bool truncated = ftruncate(out_fd.get(), 0) == 0;
953 if (!truncated) {
954 PLOG(WARNING) << "Could not truncate " << data_profile_location;
955 }
956
957 // Copy over data.
958 static constexpr size_t kBufferSize = 4 * 1024;
959 char buffer[kBufferSize];
960 while (true) {
961 ssize_t bytes = read(in_fd.get(), buffer, kBufferSize);
962 if (bytes == 0) {
963 break;
964 }
965 write(out_fd.get(), buffer, bytes);
966 }
967 if (flock(out_fd.get(), LOCK_UN) != 0) {
968 PLOG(WARNING) << "Error unlocking profile " << data_profile_location;
969 }
Mathieu Chartier78f71fe2017-06-14 13:02:26 -0700970 // Use _exit since we don't want to run the global destructors in the child.
971 // b/62597429
972 _exit(0);
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700973 }
974 /* parent */
975 int return_code = wait_child(pid);
976 return return_code == 0;
977}
978
Jeff Sharkey90aff262016-12-12 14:28:24 -0700979static std::string replace_file_extension(const std::string& oat_path, const std::string& new_ext) {
980 // A standard dalvik-cache entry. Replace ".dex" with `new_ext`.
981 if (EndsWith(oat_path, ".dex")) {
982 std::string new_path = oat_path;
983 new_path.replace(new_path.length() - strlen(".dex"), strlen(".dex"), new_ext);
Elliott Hughes969e4f82017-12-20 12:34:09 -0800984 CHECK(EndsWith(new_path, new_ext));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700985 return new_path;
986 }
987
988 // An odex entry. Not that this may not be an extension, e.g., in the OTA
989 // case (where the base name will have an extension for the B artifact).
990 size_t odex_pos = oat_path.rfind(".odex");
991 if (odex_pos != std::string::npos) {
992 std::string new_path = oat_path;
993 new_path.replace(odex_pos, strlen(".odex"), new_ext);
994 CHECK_NE(new_path.find(new_ext), std::string::npos);
995 return new_path;
996 }
997
998 // Don't know how to handle this.
999 return "";
1000}
1001
1002// Translate the given oat path to an art (app image) path. An empty string
1003// denotes an error.
1004static std::string create_image_filename(const std::string& oat_path) {
1005 return replace_file_extension(oat_path, ".art");
1006}
1007
1008// Translate the given oat path to a vdex path. An empty string denotes an error.
1009static std::string create_vdex_filename(const std::string& oat_path) {
1010 return replace_file_extension(oat_path, ".vdex");
1011}
1012
Jeff Sharkey90aff262016-12-12 14:28:24 -07001013static int open_output_file(const char* file_name, bool recreate, int permissions) {
1014 int flags = O_RDWR | O_CREAT;
1015 if (recreate) {
1016 if (unlink(file_name) < 0) {
1017 if (errno != ENOENT) {
1018 PLOG(ERROR) << "open_output_file: Couldn't unlink " << file_name;
1019 }
1020 }
1021 flags |= O_EXCL;
1022 }
1023 return open(file_name, flags, permissions);
1024}
1025
Calin Juravle2289c0a2017-02-15 12:44:14 -08001026static bool set_permissions_and_ownership(
1027 int fd, bool is_public, int uid, const char* path, bool is_secondary_dex) {
1028 // Primary apks are owned by the system. Secondary dex files are owned by the app.
1029 int owning_uid = is_secondary_dex ? uid : AID_SYSTEM;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001030 if (fchmod(fd,
1031 S_IRUSR|S_IWUSR|S_IRGRP |
1032 (is_public ? S_IROTH : 0)) < 0) {
1033 ALOGE("installd cannot chmod '%s' during dexopt\n", path);
1034 return false;
Calin Juravle2289c0a2017-02-15 12:44:14 -08001035 } else if (fchown(fd, owning_uid, uid) < 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001036 ALOGE("installd cannot chown '%s' during dexopt\n", path);
1037 return false;
1038 }
1039 return true;
1040}
1041
1042static bool IsOutputDalvikCache(const char* oat_dir) {
1043 // InstallerConnection.java (which invokes installd) transforms Java null arguments
1044 // into '!'. Play it safe by handling it both.
1045 // TODO: ensure we never get null.
1046 // TODO: pass a flag instead of inferring if the output is dalvik cache.
1047 return oat_dir == nullptr || oat_dir[0] == '!';
1048}
1049
Calin Juravled23dee72017-07-06 16:29:11 -07001050// Best-effort check whether we can fit the the path into our buffers.
1051// Note: the cache path will require an additional 5 bytes for ".swap", but we'll try to run
1052// without a swap file, if necessary. Reference profiles file also add an extra ".prof"
1053// extension to the cache path (5 bytes).
1054// TODO(calin): move away from char* buffers and PKG_PATH_MAX.
1055static bool validate_dex_path_size(const std::string& dex_path) {
1056 if (dex_path.size() >= (PKG_PATH_MAX - 8)) {
1057 LOG(ERROR) << "dex_path too long: " << dex_path;
1058 return false;
1059 }
1060 return true;
1061}
1062
Jeff Sharkey90aff262016-12-12 14:28:24 -07001063static bool create_oat_out_path(const char* apk_path, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -08001064 const char* oat_dir, bool is_secondary_dex, /*out*/ char* out_oat_path) {
Calin Juravled23dee72017-07-06 16:29:11 -07001065 if (!validate_dex_path_size(apk_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001066 return false;
1067 }
1068
1069 if (!IsOutputDalvikCache(oat_dir)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001070 // Oat dirs for secondary dex files are already validated.
1071 if (!is_secondary_dex && validate_apk_path(oat_dir)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001072 ALOGE("cannot validate apk path with oat_dir '%s'\n", oat_dir);
1073 return false;
1074 }
1075 if (!calculate_oat_file_path(out_oat_path, oat_dir, apk_path, instruction_set)) {
1076 return false;
1077 }
1078 } else {
1079 if (!create_cache_path(out_oat_path, apk_path, instruction_set)) {
1080 return false;
1081 }
1082 }
1083 return true;
1084}
1085
1086// Helper for fd management. This is similar to a unique_fd in that it closes the file descriptor
1087// on destruction. It will also run the given cleanup (unless told not to) after closing.
1088//
1089// Usage example:
1090//
Calin Juravle7a570e82017-01-14 16:23:30 -08001091// Dex2oatFileWrapper file(open(...),
Jeff Sharkey90aff262016-12-12 14:28:24 -07001092// [name]() {
1093// unlink(name.c_str());
1094// });
1095// // Note: care needs to be taken about name, as it needs to have a lifetime longer than the
1096// wrapper if captured as a reference.
1097//
1098// if (file.get() == -1) {
1099// // Error opening...
1100// }
1101//
1102// ...
1103// if (error) {
1104// // At this point, when the Dex2oatFileWrapper is destructed, the cleanup function will run
1105// // and delete the file (after the fd is closed).
1106// return -1;
1107// }
1108//
1109// (Success case)
1110// file.SetCleanup(false);
1111// // At this point, when the Dex2oatFileWrapper is destructed, the cleanup function will not run
1112// // (leaving the file around; after the fd is closed).
1113//
Jeff Sharkey90aff262016-12-12 14:28:24 -07001114class Dex2oatFileWrapper {
1115 public:
Calin Juravle7a570e82017-01-14 16:23:30 -08001116 Dex2oatFileWrapper() : value_(-1), cleanup_(), do_cleanup_(true), auto_close_(true) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001117 }
1118
Calin Juravle7a570e82017-01-14 16:23:30 -08001119 Dex2oatFileWrapper(int value, std::function<void ()> cleanup)
1120 : value_(value), cleanup_(cleanup), do_cleanup_(true), auto_close_(true) {}
1121
1122 Dex2oatFileWrapper(Dex2oatFileWrapper&& other) {
1123 value_ = other.value_;
1124 cleanup_ = other.cleanup_;
1125 do_cleanup_ = other.do_cleanup_;
1126 auto_close_ = other.auto_close_;
1127 other.release();
1128 }
1129
1130 Dex2oatFileWrapper& operator=(Dex2oatFileWrapper&& other) {
1131 value_ = other.value_;
1132 cleanup_ = other.cleanup_;
1133 do_cleanup_ = other.do_cleanup_;
1134 auto_close_ = other.auto_close_;
1135 other.release();
1136 return *this;
1137 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001138
1139 ~Dex2oatFileWrapper() {
1140 reset(-1);
1141 }
1142
1143 int get() {
1144 return value_;
1145 }
1146
1147 void SetCleanup(bool cleanup) {
1148 do_cleanup_ = cleanup;
1149 }
1150
1151 void reset(int new_value) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001152 if (auto_close_ && value_ >= 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001153 close(value_);
1154 }
1155 if (do_cleanup_ && cleanup_ != nullptr) {
1156 cleanup_();
1157 }
1158
1159 value_ = new_value;
1160 }
1161
Calin Juravle7a570e82017-01-14 16:23:30 -08001162 void reset(int new_value, std::function<void ()> new_cleanup) {
1163 if (auto_close_ && value_ >= 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001164 close(value_);
1165 }
1166 if (do_cleanup_ && cleanup_ != nullptr) {
1167 cleanup_();
1168 }
1169
1170 value_ = new_value;
1171 cleanup_ = new_cleanup;
1172 }
1173
Calin Juravle7a570e82017-01-14 16:23:30 -08001174 void DisableAutoClose() {
1175 auto_close_ = false;
1176 }
1177
Jeff Sharkey90aff262016-12-12 14:28:24 -07001178 private:
Calin Juravle7a570e82017-01-14 16:23:30 -08001179 void release() {
1180 value_ = -1;
1181 do_cleanup_ = false;
1182 cleanup_ = nullptr;
1183 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001184 int value_;
Calin Juravle7a570e82017-01-14 16:23:30 -08001185 std::function<void ()> cleanup_;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001186 bool do_cleanup_;
Calin Juravle7a570e82017-01-14 16:23:30 -08001187 bool auto_close_;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001188};
1189
Calin Juravle7a570e82017-01-14 16:23:30 -08001190// (re)Creates the app image if needed.
1191Dex2oatFileWrapper maybe_open_app_image(const char* out_oat_path, bool profile_guided,
Calin Juravle2289c0a2017-02-15 12:44:14 -08001192 bool is_public, int uid, bool is_secondary_dex) {
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +01001193
1194 // We don't create an image for secondary dex files.
1195 if (is_secondary_dex) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001196 return Dex2oatFileWrapper();
1197 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001198
Calin Juravle7a570e82017-01-14 16:23:30 -08001199 const std::string image_path = create_image_filename(out_oat_path);
1200 if (image_path.empty()) {
1201 // Happens when the out_oat_path has an unknown extension.
1202 return Dex2oatFileWrapper();
1203 }
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +01001204
1205 // Use app images only if it is enabled (by a set image format) and we are compiling
1206 // profile-guided (so the app image doesn't conservatively contain all classes).
1207 if (!profile_guided) {
1208 // In case there is a stale image, remove it now. Ignore any error.
1209 unlink(image_path.c_str());
1210 return Dex2oatFileWrapper();
1211 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001212 char app_image_format[kPropertyValueMax];
1213 bool have_app_image_format =
1214 get_property("dalvik.vm.appimageformat", app_image_format, NULL) > 0;
1215 if (!have_app_image_format) {
1216 return Dex2oatFileWrapper();
1217 }
1218 // Recreate is true since we do not want to modify a mapped image. If the app is
1219 // already running and we modify the image file, it can cause crashes (b/27493510).
1220 Dex2oatFileWrapper wrapper_fd(
1221 open_output_file(image_path.c_str(), true /*recreate*/, 0600 /*permissions*/),
1222 [image_path]() { unlink(image_path.c_str()); });
1223 if (wrapper_fd.get() < 0) {
1224 // Could not create application image file. Go on since we can compile without it.
1225 LOG(ERROR) << "installd could not create '" << image_path
1226 << "' for image file during dexopt";
1227 // If we have a valid image file path but no image fd, explicitly erase the image file.
1228 if (unlink(image_path.c_str()) < 0) {
1229 if (errno != ENOENT) {
1230 PLOG(ERROR) << "Couldn't unlink image file " << image_path;
1231 }
1232 }
1233 } else if (!set_permissions_and_ownership(
Calin Juravle2289c0a2017-02-15 12:44:14 -08001234 wrapper_fd.get(), is_public, uid, image_path.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001235 ALOGE("installd cannot set owner '%s' for image during dexopt\n", image_path.c_str());
1236 wrapper_fd.reset(-1);
1237 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001238
Calin Juravle7a570e82017-01-14 16:23:30 -08001239 return wrapper_fd;
1240}
1241
1242// Creates the dexopt swap file if necessary and return its fd.
1243// Returns -1 if there's no need for a swap or in case of errors.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001244unique_fd maybe_open_dexopt_swap_file(const char* out_oat_path) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001245 if (!ShouldUseSwapFileForDexopt()) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001246 return invalid_unique_fd();
Calin Juravle7a570e82017-01-14 16:23:30 -08001247 }
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001248 auto swap_file_name = std::string(out_oat_path) + ".swap";
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001249 unique_fd swap_fd(open_output_file(
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001250 swap_file_name.c_str(), /*recreate*/true, /*permissions*/0600));
Calin Juravle7a570e82017-01-14 16:23:30 -08001251 if (swap_fd.get() < 0) {
1252 // Could not create swap file. Optimistically go on and hope that we can compile
1253 // without it.
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001254 ALOGE("installd could not create '%s' for swap during dexopt\n", swap_file_name.c_str());
Calin Juravle7a570e82017-01-14 16:23:30 -08001255 } else {
1256 // Immediately unlink. We don't really want to hit flash.
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001257 if (unlink(swap_file_name.c_str()) < 0) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001258 PLOG(ERROR) << "Couldn't unlink swap file " << swap_file_name;
1259 }
1260 }
1261 return swap_fd;
1262}
1263
1264// Opens the reference profiles if needed.
1265// Note that the reference profile might not exist so it's OK if the fd will be -1.
Calin Juravle114f0812017-03-08 19:05:07 -08001266Dex2oatFileWrapper maybe_open_reference_profile(const std::string& pkgname,
1267 const std::string& dex_path, bool profile_guided, bool is_public, int uid,
1268 bool is_secondary_dex) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001269 // Public apps should not be compiled with profile information ever. Same goes for the special
1270 // package '*' used for the system server.
Calin Juravle114f0812017-03-08 19:05:07 -08001271 if (!profile_guided || is_public || (pkgname[0] == '*')) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001272 return Dex2oatFileWrapper();
Jeff Sharkey90aff262016-12-12 14:28:24 -07001273 }
Calin Juravle114f0812017-03-08 19:05:07 -08001274
1275 // Open reference profile in read only mode as dex2oat does not get write permissions.
1276 const std::string location = is_secondary_dex ? dex_path : pkgname;
1277 unique_fd ufd = open_reference_profile(uid, location, /*read_write*/false, is_secondary_dex);
1278 const auto& cleanup = [location, is_secondary_dex]() {
1279 clear_reference_profile(location.c_str(), is_secondary_dex);
1280 };
1281 return Dex2oatFileWrapper(ufd.release(), cleanup);
Calin Juravle7a570e82017-01-14 16:23:30 -08001282}
Jeff Sharkey90aff262016-12-12 14:28:24 -07001283
Calin Juravle7a570e82017-01-14 16:23:30 -08001284// Opens the vdex files and assigns the input fd to in_vdex_wrapper_fd and the output fd to
1285// out_vdex_wrapper_fd. Returns true for success or false in case of errors.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001286bool open_vdex_files_for_dex2oat(const char* apk_path, const char* out_oat_path, int dexopt_needed,
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001287 const char* instruction_set, bool is_public, int uid, bool is_secondary_dex,
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001288 bool profile_guided, Dex2oatFileWrapper* in_vdex_wrapper_fd,
Calin Juravle7a570e82017-01-14 16:23:30 -08001289 Dex2oatFileWrapper* out_vdex_wrapper_fd) {
1290 CHECK(in_vdex_wrapper_fd != nullptr);
1291 CHECK(out_vdex_wrapper_fd != nullptr);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001292 // Open the existing VDEX. We do this before creating the new output VDEX, which will
1293 // unlink the old one.
Richard Uhler76cc0272016-12-08 10:46:35 +00001294 char in_odex_path[PKG_PATH_MAX];
1295 int dexopt_action = abs(dexopt_needed);
1296 bool is_odex_location = dexopt_needed < 0;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001297 std::string in_vdex_path_str;
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001298
1299 // Infer the name of the output VDEX.
1300 const std::string out_vdex_path_str = create_vdex_filename(out_oat_path);
1301 if (out_vdex_path_str.empty()) {
1302 return false;
1303 }
1304
1305 bool update_vdex_in_place = false;
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001306 if (dexopt_action != DEX2OAT_FROM_SCRATCH) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001307 // Open the possibly existing vdex. If none exist, we pass -1 to dex2oat for input-vdex-fd.
1308 const char* path = nullptr;
1309 if (is_odex_location) {
1310 if (calculate_odex_file_path(in_odex_path, apk_path, instruction_set)) {
1311 path = in_odex_path;
1312 } else {
1313 ALOGE("installd cannot compute input vdex location for '%s'\n", apk_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001314 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001315 }
1316 } else {
1317 path = out_oat_path;
1318 }
1319 in_vdex_path_str = create_vdex_filename(path);
1320 if (in_vdex_path_str.empty()) {
1321 ALOGE("installd cannot compute input vdex location for '%s'\n", path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001322 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001323 }
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001324 // We can update in place when all these conditions are met:
1325 // 1) The vdex location to write to is the same as the vdex location to read (vdex files
1326 // on /system typically cannot be updated in place).
1327 // 2) We dex2oat due to boot image change, because we then know the existing vdex file
1328 // cannot be currently used by a running process.
1329 // 3) We are not doing a profile guided compilation, because dexlayout requires two
1330 // different vdex files to operate.
1331 update_vdex_in_place =
1332 (in_vdex_path_str == out_vdex_path_str) &&
1333 (dexopt_action == DEX2OAT_FOR_BOOT_IMAGE) &&
1334 !profile_guided;
1335 if (update_vdex_in_place) {
1336 // Open the file read-write to be able to update it.
1337 in_vdex_wrapper_fd->reset(open(in_vdex_path_str.c_str(), O_RDWR, 0));
1338 if (in_vdex_wrapper_fd->get() == -1) {
1339 // If we failed to open the file, we cannot update it in place.
1340 update_vdex_in_place = false;
1341 }
1342 } else {
1343 in_vdex_wrapper_fd->reset(open(in_vdex_path_str.c_str(), O_RDONLY, 0));
1344 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001345 }
1346
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001347 // If we are updating the vdex in place, we do not need to recreate a vdex,
1348 // and can use the same existing one.
1349 if (update_vdex_in_place) {
1350 // We unlink the file in case the invocation of dex2oat fails, to ensure we don't
1351 // have bogus stale vdex files.
1352 out_vdex_wrapper_fd->reset(
1353 in_vdex_wrapper_fd->get(),
1354 [out_vdex_path_str]() { unlink(out_vdex_path_str.c_str()); });
1355 // Disable auto close for the in wrapper fd (it will be done when destructing the out
1356 // wrapper).
1357 in_vdex_wrapper_fd->DisableAutoClose();
1358 } else {
1359 out_vdex_wrapper_fd->reset(
1360 open_output_file(out_vdex_path_str.c_str(), /*recreate*/true, /*permissions*/0644),
1361 [out_vdex_path_str]() { unlink(out_vdex_path_str.c_str()); });
1362 if (out_vdex_wrapper_fd->get() < 0) {
1363 ALOGE("installd cannot open vdex'%s' during dexopt\n", out_vdex_path_str.c_str());
1364 return false;
1365 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001366 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001367 if (!set_permissions_and_ownership(out_vdex_wrapper_fd->get(), is_public, uid,
Calin Juravle2289c0a2017-02-15 12:44:14 -08001368 out_vdex_path_str.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001369 ALOGE("installd cannot set owner '%s' for vdex during dexopt\n", out_vdex_path_str.c_str());
1370 return false;
1371 }
1372
1373 // If we got here we successfully opened the vdex files.
1374 return true;
1375}
1376
1377// Opens the output oat file for the given apk.
1378// If successful it stores the output path into out_oat_path and returns true.
1379Dex2oatFileWrapper open_oat_out_file(const char* apk_path, const char* oat_dir,
Calin Juravle80a21252017-01-17 14:43:25 -08001380 bool is_public, int uid, const char* instruction_set, bool is_secondary_dex,
1381 char* out_oat_path) {
1382 if (!create_oat_out_path(apk_path, instruction_set, oat_dir, is_secondary_dex, out_oat_path)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001383 return Dex2oatFileWrapper();
1384 }
1385 const std::string out_oat_path_str(out_oat_path);
1386 Dex2oatFileWrapper wrapper_fd(
1387 open_output_file(out_oat_path, /*recreate*/true, /*permissions*/0644),
1388 [out_oat_path_str]() { unlink(out_oat_path_str.c_str()); });
1389 if (wrapper_fd.get() < 0) {
Calin Juravle80a21252017-01-17 14:43:25 -08001390 PLOG(ERROR) << "installd cannot open output during dexopt" << out_oat_path;
Calin Juravle2289c0a2017-02-15 12:44:14 -08001391 } else if (!set_permissions_and_ownership(
1392 wrapper_fd.get(), is_public, uid, out_oat_path, is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001393 ALOGE("installd cannot set owner '%s' for output during dexopt\n", out_oat_path);
1394 wrapper_fd.reset(-1);
1395 }
1396 return wrapper_fd;
1397}
1398
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001399// Creates RDONLY fds for oat and vdex files, if exist.
1400// Returns false if it fails to create oat out path for the given apk path.
1401// Note that the method returns true even if the files could not be opened.
1402bool maybe_open_oat_and_vdex_file(const std::string& apk_path,
1403 const std::string& oat_dir,
1404 const std::string& instruction_set,
1405 bool is_secondary_dex,
1406 unique_fd* oat_file_fd,
1407 unique_fd* vdex_file_fd) {
1408 char oat_path[PKG_PATH_MAX];
1409 if (!create_oat_out_path(apk_path.c_str(),
1410 instruction_set.c_str(),
1411 oat_dir.c_str(),
1412 is_secondary_dex,
1413 oat_path)) {
Calin Juravle7d765462017-09-04 15:57:10 -07001414 LOG(ERROR) << "Could not create oat out path for "
1415 << apk_path << " with oat dir " << oat_dir;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001416 return false;
1417 }
1418 oat_file_fd->reset(open(oat_path, O_RDONLY));
1419 if (oat_file_fd->get() < 0) {
1420 PLOG(INFO) << "installd cannot open oat file during dexopt" << oat_path;
1421 }
1422
1423 std::string vdex_filename = create_vdex_filename(oat_path);
1424 vdex_file_fd->reset(open(vdex_filename.c_str(), O_RDONLY));
1425 if (vdex_file_fd->get() < 0) {
1426 PLOG(INFO) << "installd cannot open vdex file during dexopt" << vdex_filename;
1427 }
1428
1429 return true;
1430}
1431
Calin Juravle7a570e82017-01-14 16:23:30 -08001432// Updates the access times of out_oat_path based on those from apk_path.
1433void update_out_oat_access_times(const char* apk_path, const char* out_oat_path) {
1434 struct stat input_stat;
1435 memset(&input_stat, 0, sizeof(input_stat));
1436 if (stat(apk_path, &input_stat) != 0) {
1437 PLOG(ERROR) << "Could not stat " << apk_path << " during dexopt";
1438 return;
1439 }
1440
1441 struct utimbuf ut;
1442 ut.actime = input_stat.st_atime;
1443 ut.modtime = input_stat.st_mtime;
1444 if (utime(out_oat_path, &ut) != 0) {
1445 PLOG(WARNING) << "Could not update access times for " << apk_path << " during dexopt";
1446 }
1447}
1448
Calin Juravle80a21252017-01-17 14:43:25 -08001449// Runs (execv) dexoptanalyzer on the given arguments.
Calin Juravle114f0812017-03-08 19:05:07 -08001450// The analyzer will check if the dex_file needs to be (re)compiled to match the compiler_filter.
1451// If this is for a profile guided compilation, profile_was_updated will tell whether or not
1452// the profile has changed.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001453static void exec_dexoptanalyzer(const std::string& dex_file, int vdex_fd, int oat_fd,
1454 int zip_fd, const std::string& instruction_set, const std::string& compiler_filter,
1455 bool profile_was_updated, bool downgrade,
Calin Juravle58cab072017-09-12 01:02:26 -07001456 const char* class_loader_context) {
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001457 CHECK_GE(zip_fd, 0);
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001458 const char* dexoptanalyzer_bin =
1459 is_debug_runtime()
1460 ? "/system/bin/dexoptanalyzerd"
1461 : "/system/bin/dexoptanalyzer";
Calin Juravle80a21252017-01-17 14:43:25 -08001462 static const unsigned int MAX_INSTRUCTION_SET_LEN = 7;
1463
Calin Juravled23dee72017-07-06 16:29:11 -07001464 if (instruction_set.size() >= MAX_INSTRUCTION_SET_LEN) {
1465 LOG(ERROR) << "Instruction set " << instruction_set
1466 << " longer than max length of " << MAX_INSTRUCTION_SET_LEN;
Calin Juravle80a21252017-01-17 14:43:25 -08001467 return;
1468 }
1469
Calin Juravled23dee72017-07-06 16:29:11 -07001470 std::string dex_file_arg = "--dex-file=" + dex_file;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001471 std::string oat_fd_arg = "--oat-fd=" + std::to_string(oat_fd);
1472 std::string vdex_fd_arg = "--vdex-fd=" + std::to_string(vdex_fd);
1473 std::string zip_fd_arg = "--zip-fd=" + std::to_string(zip_fd);
Calin Juravled23dee72017-07-06 16:29:11 -07001474 std::string isa_arg = "--isa=" + instruction_set;
1475 std::string compiler_filter_arg = "--compiler-filter=" + compiler_filter;
Calin Juravle114f0812017-03-08 19:05:07 -08001476 const char* assume_profile_changed = "--assume-profile-changed";
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001477 const char* downgrade_flag = "--downgrade";
Calin Juravle58cab072017-09-12 01:02:26 -07001478 std::string class_loader_context_arg = "--class-loader-context=";
1479 if (class_loader_context != nullptr) {
1480 class_loader_context_arg += class_loader_context;
1481 }
Calin Juravle80a21252017-01-17 14:43:25 -08001482
Calin Juravle80a21252017-01-17 14:43:25 -08001483 // program name, dex file, isa, filter, the final NULL
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001484 const int argc = 6 +
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001485 (profile_was_updated ? 1 : 0) +
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001486 (vdex_fd >= 0 ? 1 : 0) +
1487 (oat_fd >= 0 ? 1 : 0) +
Calin Juravle58cab072017-09-12 01:02:26 -07001488 (downgrade ? 1 : 0) +
1489 (class_loader_context != nullptr ? 1 : 0);
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001490 const char* argv[argc];
Calin Juravle80a21252017-01-17 14:43:25 -08001491 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001492 argv[i++] = dexoptanalyzer_bin;
Calin Juravled23dee72017-07-06 16:29:11 -07001493 argv[i++] = dex_file_arg.c_str();
1494 argv[i++] = isa_arg.c_str();
1495 argv[i++] = compiler_filter_arg.c_str();
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001496 if (oat_fd >= 0) {
1497 argv[i++] = oat_fd_arg.c_str();
1498 }
1499 if (vdex_fd >= 0) {
1500 argv[i++] = vdex_fd_arg.c_str();
1501 }
1502 argv[i++] = zip_fd_arg.c_str();
Calin Juravle114f0812017-03-08 19:05:07 -08001503 if (profile_was_updated) {
1504 argv[i++] = assume_profile_changed;
1505 }
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001506 if (downgrade) {
1507 argv[i++] = downgrade_flag;
1508 }
Calin Juravle58cab072017-09-12 01:02:26 -07001509 if (class_loader_context != nullptr) {
Calin Juravle91501072017-10-26 15:44:53 -07001510 argv[i++] = class_loader_context_arg.c_str();
Calin Juravle58cab072017-09-12 01:02:26 -07001511 }
Calin Juravle80a21252017-01-17 14:43:25 -08001512 argv[i] = NULL;
1513
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001514 execv(dexoptanalyzer_bin, (char * const *)argv);
1515 ALOGE("execv(%s) failed: %s\n", dexoptanalyzer_bin, strerror(errno));
Calin Juravle80a21252017-01-17 14:43:25 -08001516}
1517
1518// Prepares the oat dir for the secondary dex files.
Calin Juravle114f0812017-03-08 19:05:07 -08001519static bool prepare_secondary_dex_oat_dir(const std::string& dex_path, int uid,
Calin Juravle7d765462017-09-04 15:57:10 -07001520 const char* instruction_set) {
Calin Juravle114f0812017-03-08 19:05:07 -08001521 unsigned long dirIndex = dex_path.rfind('/');
Calin Juravle80a21252017-01-17 14:43:25 -08001522 if (dirIndex == std::string::npos) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001523 LOG(ERROR ) << "Unexpected dir structure for secondary dex " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001524 return false;
1525 }
Calin Juravle114f0812017-03-08 19:05:07 -08001526 std::string dex_dir = dex_path.substr(0, dirIndex);
Calin Juravle80a21252017-01-17 14:43:25 -08001527
Calin Juravle80a21252017-01-17 14:43:25 -08001528 // Create oat file output directory.
Calin Juravleebc8a792017-04-04 20:21:05 -07001529 mode_t oat_dir_mode = S_IRWXU | S_IRWXG | S_IXOTH;
1530 if (prepare_app_cache_dir(dex_dir, "oat", oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001531 LOG(ERROR) << "Could not prepare oat dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001532 return false;
1533 }
1534
1535 char oat_dir[PKG_PATH_MAX];
Calin Juravle114f0812017-03-08 19:05:07 -08001536 snprintf(oat_dir, PKG_PATH_MAX, "%s/oat", dex_dir.c_str());
Calin Juravle80a21252017-01-17 14:43:25 -08001537
Calin Juravle7d765462017-09-04 15:57:10 -07001538 if (prepare_app_cache_dir(oat_dir, instruction_set, oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001539 LOG(ERROR) << "Could not prepare oat/isa dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001540 return false;
1541 }
1542
1543 return true;
1544}
1545
Calin Juravle7d765462017-09-04 15:57:10 -07001546// Return codes for identifying the reason why dexoptanalyzer was not invoked when processing
1547// secondary dex files. This return codes are returned by the child process created for
1548// analyzing secondary dex files in process_secondary_dex_dexopt.
Calin Juravle80a21252017-01-17 14:43:25 -08001549
Calin Juravle7d765462017-09-04 15:57:10 -07001550// The dexoptanalyzer was not invoked because of validation or IO errors.
1551static int constexpr SECONDARY_DEX_DEXOPTANALYZER_SKIPPED = 200;
1552// The dexoptanalyzer was not invoked because the dex file does not exist anymore.
1553static int constexpr SECONDARY_DEX_DEXOPTANALYZER_SKIPPED_NO_FILE = 201;
1554
1555// Verifies the result of analyzing secondary dex files from process_secondary_dex_dexopt.
Calin Juravle80a21252017-01-17 14:43:25 -08001556// If the result is valid returns true and sets dexopt_needed_out to a valid value.
1557// Returns false for errors or unexpected result values.
Calin Juravle7d765462017-09-04 15:57:10 -07001558// The result is expected to be either one of SECONDARY_DEX_* codes or a valid exit code
1559// of dexoptanalyzer.
1560static bool process_secondary_dexoptanalyzer_result(const std::string& dex_path, int result,
Calin Juravle80a21252017-01-17 14:43:25 -08001561 int* dexopt_needed_out) {
1562 // The result values are defined in dexoptanalyzer.
1563 switch (result) {
Calin Juravle7d765462017-09-04 15:57:10 -07001564 case 0: // dexoptanalyzer: no_dexopt_needed
Calin Juravle80a21252017-01-17 14:43:25 -08001565 *dexopt_needed_out = NO_DEXOPT_NEEDED; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001566 case 1: // dexoptanalyzer: dex2oat_from_scratch
Calin Juravle80a21252017-01-17 14:43:25 -08001567 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001568 case 5: // dexoptanalyzer: dex2oat_for_bootimage_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001569 *dexopt_needed_out = -DEX2OAT_FOR_BOOT_IMAGE; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001570 case 6: // dexoptanalyzer: dex2oat_for_filter_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001571 *dexopt_needed_out = -DEX2OAT_FOR_FILTER; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001572 case 7: // dexoptanalyzer: dex2oat_for_relocation_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001573 *dexopt_needed_out = -DEX2OAT_FOR_RELOCATION; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001574 case 2: // dexoptanalyzer: dex2oat_for_bootimage_oat
1575 case 3: // dexoptanalyzer: dex2oat_for_filter_oat
1576 case 4: // dexoptanalyzer: dex2oat_for_relocation_oat
Calin Juravlec9eab382017-01-25 01:17:17 -08001577 LOG(ERROR) << "Dexoptnalyzer return the status of an oat file."
1578 << " Expected odex file status for secondary dex " << dex_path
Calin Juravle80a21252017-01-17 14:43:25 -08001579 << " : dexoptanalyzer result=" << result;
1580 return false;
Calin Juravle7d765462017-09-04 15:57:10 -07001581 case SECONDARY_DEX_DEXOPTANALYZER_SKIPPED_NO_FILE:
1582 // If the file does not exist there's no need for dexopt.
1583 *dexopt_needed_out = NO_DEXOPT_NEEDED;
1584 return true;
1585 case SECONDARY_DEX_DEXOPTANALYZER_SKIPPED:
1586 return false;
Calin Juravle80a21252017-01-17 14:43:25 -08001587 default:
Calin Juravle7d765462017-09-04 15:57:10 -07001588 LOG(ERROR) << "Unexpected result from analyzing secondary dex " << dex_path
1589 << " result=" << result;
Calin Juravle80a21252017-01-17 14:43:25 -08001590 return false;
1591 }
1592}
1593
Calin Juravle7d765462017-09-04 15:57:10 -07001594enum SecondaryDexAccess {
1595 kSecondaryDexAccessReadOk = 0,
1596 kSecondaryDexAccessDoesNotExist = 1,
1597 kSecondaryDexAccessPermissionError = 2,
1598 kSecondaryDexAccessIOError = 3
1599};
1600
1601static SecondaryDexAccess check_secondary_dex_access(const std::string& dex_path) {
1602 // Check if the path exists and can be read. If not, there's nothing to do.
1603 if (access(dex_path.c_str(), R_OK) == 0) {
1604 return kSecondaryDexAccessReadOk;
1605 } else {
1606 if (errno == ENOENT) {
1607 LOG(INFO) << "Secondary dex does not exist: " << dex_path;
1608 return kSecondaryDexAccessDoesNotExist;
1609 } else {
1610 PLOG(ERROR) << "Could not access secondary dex " << dex_path;
1611 return errno == EACCES
1612 ? kSecondaryDexAccessPermissionError
1613 : kSecondaryDexAccessIOError;
1614 }
1615 }
1616}
1617
1618static bool is_file_public(const std::string& filename) {
1619 struct stat file_stat;
1620 if (stat(filename.c_str(), &file_stat) == 0) {
1621 return (file_stat.st_mode & S_IROTH) != 0;
1622 }
1623 return false;
1624}
1625
1626// Create the oat file structure for the secondary dex 'dex_path' and assign
1627// the individual path component to the 'out_' parameters.
1628static bool create_secondary_dex_oat_layout(const std::string& dex_path, const std::string& isa,
1629 char* out_oat_dir, char* out_oat_isa_dir, char* out_oat_path) {
1630 size_t dirIndex = dex_path.rfind('/');
1631 if (dirIndex == std::string::npos) {
1632 LOG(ERROR) << "Unexpected dir structure for dex file " << dex_path;
1633 return false;
1634 }
1635 // TODO(calin): we have similar computations in at lest 3 other places
1636 // (InstalldNativeService, otapropt and dexopt). Unify them and get rid of snprintf by
1637 // using string append.
1638 std::string apk_dir = dex_path.substr(0, dirIndex);
1639 snprintf(out_oat_dir, PKG_PATH_MAX, "%s/oat", apk_dir.c_str());
1640 snprintf(out_oat_isa_dir, PKG_PATH_MAX, "%s/%s", out_oat_dir, isa.c_str());
1641
1642 if (!create_oat_out_path(dex_path.c_str(), isa.c_str(), out_oat_dir,
1643 /*is_secondary_dex*/true, out_oat_path)) {
1644 LOG(ERROR) << "Could not create oat path for secondary dex " << dex_path;
1645 return false;
1646 }
1647 return true;
1648}
1649
1650// Validate that the dexopt_flags contain a valid storage flag and convert that to an installd
1651// recognized storage flags (FLAG_STORAGE_CE or FLAG_STORAGE_DE).
1652static bool validate_dexopt_storage_flags(int dexopt_flags, int* out_storage_flag) {
1653 if ((dexopt_flags & DEXOPT_STORAGE_CE) != 0) {
1654 *out_storage_flag = FLAG_STORAGE_CE;
1655 if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
1656 LOG(ERROR) << "Ambiguous secondary dex storage flag. Both, CE and DE, flags are set";
1657 return false;
1658 }
1659 } else if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
1660 *out_storage_flag = FLAG_STORAGE_DE;
1661 } else {
1662 LOG(ERROR) << "Secondary dex storage flag must be set";
1663 return false;
1664 }
1665 return true;
1666}
1667
Calin Juravlec9eab382017-01-25 01:17:17 -08001668// Processes the dex_path as a secondary dex files and return true if the path dex file should
Calin Juravle80a21252017-01-17 14:43:25 -08001669// be compiled. Returns false for errors (logged) or true if the secondary dex path was process
1670// successfully.
Calin Juravleebc8a792017-04-04 20:21:05 -07001671// When returning true, the output parameters will be:
1672// - is_public_out: whether or not the oat file should not be made public
1673// - dexopt_needed_out: valid OatFileAsssitant::DexOptNeeded
1674// - oat_dir_out: the oat dir path where the oat file should be stored
Calin Juravle7d765462017-09-04 15:57:10 -07001675static bool process_secondary_dex_dexopt(const std::string& dex_path, const char* pkgname,
Calin Juravle80a21252017-01-17 14:43:25 -08001676 int dexopt_flags, const char* volume_uuid, int uid, const char* instruction_set,
Calin Juravleebc8a792017-04-04 20:21:05 -07001677 const char* compiler_filter, bool* is_public_out, int* dexopt_needed_out,
Calin Juravle7d765462017-09-04 15:57:10 -07001678 std::string* oat_dir_out, bool downgrade, const char* class_loader_context) {
1679 LOG(DEBUG) << "Processing secondary dex path " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001680 int storage_flag;
Calin Juravle7d765462017-09-04 15:57:10 -07001681 if (!validate_dexopt_storage_flags(dexopt_flags, &storage_flag)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001682 return false;
1683 }
Calin Juravle7d765462017-09-04 15:57:10 -07001684 // Compute the oat dir as it's not easy to extract it from the child computation.
1685 char oat_path[PKG_PATH_MAX];
1686 char oat_dir[PKG_PATH_MAX];
1687 char oat_isa_dir[PKG_PATH_MAX];
1688 if (!create_secondary_dex_oat_layout(
1689 dex_path, instruction_set, oat_dir, oat_isa_dir, oat_path)) {
1690 LOG(ERROR) << "Could not create secondary odex layout: " << dex_path;
Calin Juravled23dee72017-07-06 16:29:11 -07001691 return false;
1692 }
Calin Juravle7d765462017-09-04 15:57:10 -07001693 oat_dir_out->assign(oat_dir);
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001694
Calin Juravle80a21252017-01-17 14:43:25 -08001695 pid_t pid = fork();
1696 if (pid == 0) {
1697 // child -- drop privileges before continuing.
1698 drop_capabilities(uid);
Calin Juravle7d765462017-09-04 15:57:10 -07001699
1700 // Validate the path structure.
1701 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid, uid, storage_flag)) {
1702 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
1703 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
1704 }
1705
1706 // Open the dex file.
1707 unique_fd zip_fd;
1708 zip_fd.reset(open(dex_path.c_str(), O_RDONLY));
1709 if (zip_fd.get() < 0) {
1710 if (errno == ENOENT) {
1711 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED_NO_FILE);
1712 } else {
1713 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
1714 }
1715 }
1716
1717 // Prepare the oat directories.
1718 if (!prepare_secondary_dex_oat_dir(dex_path, uid, instruction_set)) {
1719 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
1720 }
1721
1722 // Open the vdex/oat files if any.
1723 unique_fd oat_file_fd;
1724 unique_fd vdex_file_fd;
1725 if (!maybe_open_oat_and_vdex_file(dex_path,
1726 *oat_dir_out,
1727 instruction_set,
1728 true /* is_secondary_dex */,
1729 &oat_file_fd,
1730 &vdex_file_fd)) {
1731 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
1732 }
1733
1734 // Analyze profiles.
1735 bool profile_was_updated = analyze_profiles(uid, dex_path, /*is_secondary_dex*/true);
1736
1737 // Run dexoptanalyzer to get dexopt_needed code. This is not expected to return.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001738 exec_dexoptanalyzer(dex_path,
1739 vdex_file_fd.get(),
1740 oat_file_fd.get(),
1741 zip_fd.get(),
1742 instruction_set,
Calin Juravle7d765462017-09-04 15:57:10 -07001743 compiler_filter, profile_was_updated,
1744 downgrade,
1745 class_loader_context);
1746 PLOG(ERROR) << "Failed to exec dexoptanalyzer";
1747 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
Calin Juravle80a21252017-01-17 14:43:25 -08001748 }
1749
1750 /* parent */
Calin Juravle80a21252017-01-17 14:43:25 -08001751 int result = wait_child(pid);
1752 if (!WIFEXITED(result)) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001753 LOG(ERROR) << "dexoptanalyzer failed for path " << dex_path << ": " << result;
Calin Juravle80a21252017-01-17 14:43:25 -08001754 return false;
1755 }
1756 result = WEXITSTATUS(result);
Calin Juravle7d765462017-09-04 15:57:10 -07001757 // Check that we successfully executed dexoptanalyzer.
1758 bool success = process_secondary_dexoptanalyzer_result(dex_path, result, dexopt_needed_out);
1759
1760 LOG(DEBUG) << "Processed secondary dex file " << dex_path << " result=" << result;
1761
Calin Juravle80a21252017-01-17 14:43:25 -08001762 // Run dexopt only if needed or forced.
Calin Juravle7d765462017-09-04 15:57:10 -07001763 // Note that dexoptanalyzer is executed even if force compilation is enabled (because it
1764 // makes the code simpler; force compilation is only needed during tests).
1765 if (success &&
1766 (result != SECONDARY_DEX_DEXOPTANALYZER_SKIPPED_NO_FILE) &&
1767 ((dexopt_flags & DEXOPT_FORCE) != 0)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001768 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH;
1769 }
1770
Calin Juravle7d765462017-09-04 15:57:10 -07001771 // Check if we should make the oat file public.
1772 // Note that if the dex file is not public the compiled code cannot be made public.
1773 // It is ok to check this flag outside in the parent process.
1774 *is_public_out = ((dexopt_flags & DEXOPT_PUBLIC) != 0) && is_file_public(dex_path);
1775
Calin Juravle80a21252017-01-17 14:43:25 -08001776 return success;
1777}
1778
Calin Juravlec9eab382017-01-25 01:17:17 -08001779int dexopt(const char* dex_path, uid_t uid, const char* pkgname, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -08001780 int dexopt_needed, const char* oat_dir, int dexopt_flags, const char* compiler_filter,
Calin Juravle52c45822017-07-13 22:50:21 -07001781 const char* volume_uuid, const char* class_loader_context, const char* se_info,
David Brazdil570d3982018-01-16 20:15:43 +00001782 bool downgrade, int target_sdk_version) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001783 CHECK(pkgname != nullptr);
1784 CHECK(pkgname[0] != 0);
1785 if ((dexopt_flags & ~DEXOPT_MASK) != 0) {
1786 LOG_FATAL("dexopt flags contains unknown fields\n");
1787 }
1788
Calin Juravled23dee72017-07-06 16:29:11 -07001789 if (!validate_dex_path_size(dex_path)) {
Calin Juravle52c45822017-07-13 22:50:21 -07001790 return -1;
1791 }
1792
1793 if (class_loader_context != nullptr && strlen(class_loader_context) > PKG_PATH_MAX) {
1794 LOG(ERROR) << "Class loader context exceeds the allowed size: " << class_loader_context;
1795 return -1;
Calin Juravled23dee72017-07-06 16:29:11 -07001796 }
1797
Calin Juravleebc8a792017-04-04 20:21:05 -07001798 bool is_public = (dexopt_flags & DEXOPT_PUBLIC) != 0;
Calin Juravle7a570e82017-01-14 16:23:30 -08001799 bool debuggable = (dexopt_flags & DEXOPT_DEBUGGABLE) != 0;
1800 bool boot_complete = (dexopt_flags & DEXOPT_BOOTCOMPLETE) != 0;
1801 bool profile_guided = (dexopt_flags & DEXOPT_PROFILE_GUIDED) != 0;
Calin Juravle80a21252017-01-17 14:43:25 -08001802 bool is_secondary_dex = (dexopt_flags & DEXOPT_SECONDARY_DEX) != 0;
Andreas Gampea73a0cb2017-11-02 18:14:42 -07001803 bool background_job_compile = (dexopt_flags & DEXOPT_IDLE_BACKGROUND_JOB) != 0;
David Brazdil7fcbb812018-01-17 17:05:40 +00001804 bool disable_hidden_api_checks = (dexopt_flags & DEXOPT_DISABLE_HIDDEN_API_CHECKS) != 0;
Calin Juravle80a21252017-01-17 14:43:25 -08001805
1806 // Check if we're dealing with a secondary dex file and if we need to compile it.
1807 std::string oat_dir_str;
1808 if (is_secondary_dex) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001809 if (process_secondary_dex_dexopt(dex_path, pkgname, dexopt_flags, volume_uuid, uid,
Calin Juravleebc8a792017-04-04 20:21:05 -07001810 instruction_set, compiler_filter, &is_public, &dexopt_needed, &oat_dir_str,
Calin Juravle7d765462017-09-04 15:57:10 -07001811 downgrade, class_loader_context)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001812 oat_dir = oat_dir_str.c_str();
1813 if (dexopt_needed == NO_DEXOPT_NEEDED) {
1814 return 0; // Nothing to do, report success.
1815 }
1816 } else {
1817 return -1; // We had an error, logged in the process method.
1818 }
1819 } else {
Calin Juravlec9eab382017-01-25 01:17:17 -08001820 // Currently these flags are only use for secondary dex files.
1821 // Verify that they are not set for primary apks.
Calin Juravle80a21252017-01-17 14:43:25 -08001822 CHECK((dexopt_flags & DEXOPT_STORAGE_CE) == 0);
1823 CHECK((dexopt_flags & DEXOPT_STORAGE_DE) == 0);
1824 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001825
1826 // Open the input file.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001827 unique_fd input_fd(open(dex_path, O_RDONLY, 0));
Calin Juravle7a570e82017-01-14 16:23:30 -08001828 if (input_fd.get() < 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001829 ALOGE("installd cannot open '%s' for input during dexopt\n", dex_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001830 return -1;
1831 }
1832
1833 // Create the output OAT file.
1834 char out_oat_path[PKG_PATH_MAX];
Calin Juravlec9eab382017-01-25 01:17:17 -08001835 Dex2oatFileWrapper out_oat_fd = open_oat_out_file(dex_path, oat_dir, is_public, uid,
Calin Juravle80a21252017-01-17 14:43:25 -08001836 instruction_set, is_secondary_dex, out_oat_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001837 if (out_oat_fd.get() < 0) {
1838 return -1;
1839 }
1840
1841 // Open vdex files.
1842 Dex2oatFileWrapper in_vdex_fd;
1843 Dex2oatFileWrapper out_vdex_fd;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001844 if (!open_vdex_files_for_dex2oat(dex_path, out_oat_path, dexopt_needed, instruction_set,
1845 is_public, uid, is_secondary_dex, profile_guided, &in_vdex_fd, &out_vdex_fd)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001846 return -1;
1847 }
1848
Calin Juravlecb556e32017-04-04 20:22:50 -07001849 // Ensure that the oat dir and the compiler artifacts of secondary dex files have the correct
1850 // selinux context (we generate them on the fly during the dexopt invocation and they don't
1851 // fully inherit their parent context).
1852 // Note that for primary apk the oat files are created before, in a separate installd
1853 // call which also does the restorecon. TODO(calin): unify the paths.
1854 if (is_secondary_dex) {
1855 if (selinux_android_restorecon_pkgdir(oat_dir, se_info, uid,
1856 SELINUX_ANDROID_RESTORECON_RECURSE)) {
1857 LOG(ERROR) << "Failed to restorecon " << oat_dir;
1858 return -1;
1859 }
1860 }
1861
Jeff Sharkey90aff262016-12-12 14:28:24 -07001862 // Create a swap file if necessary.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001863 unique_fd swap_fd = maybe_open_dexopt_swap_file(out_oat_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001864
Calin Juravle7a570e82017-01-14 16:23:30 -08001865 // Create the app image file if needed.
1866 Dex2oatFileWrapper image_fd =
Calin Juravle2289c0a2017-02-15 12:44:14 -08001867 maybe_open_app_image(out_oat_path, profile_guided, is_public, uid, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001868
Calin Juravle7a570e82017-01-14 16:23:30 -08001869 // Open the reference profile if needed.
Calin Juravle114f0812017-03-08 19:05:07 -08001870 Dex2oatFileWrapper reference_profile_fd = maybe_open_reference_profile(
1871 pkgname, dex_path, profile_guided, is_public, uid, is_secondary_dex);
Calin Juravle7a570e82017-01-14 16:23:30 -08001872
Calin Juravlec9eab382017-01-25 01:17:17 -08001873 ALOGV("DexInv: --- BEGIN '%s' ---\n", dex_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001874
1875 pid_t pid = fork();
1876 if (pid == 0) {
1877 /* child -- drop privileges before continuing */
1878 drop_capabilities(uid);
1879
Richard Uhler76cc0272016-12-08 10:46:35 +00001880 SetDex2OatScheduling(boot_complete);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001881 if (flock(out_oat_fd.get(), LOCK_EX | LOCK_NB) != 0) {
1882 ALOGE("flock(%s) failed: %s\n", out_oat_path, strerror(errno));
1883 _exit(67);
1884 }
1885
Richard Uhler76cc0272016-12-08 10:46:35 +00001886 run_dex2oat(input_fd.get(),
1887 out_oat_fd.get(),
1888 in_vdex_fd.get(),
Calin Juravle7a570e82017-01-14 16:23:30 -08001889 out_vdex_fd.get(),
Richard Uhler76cc0272016-12-08 10:46:35 +00001890 image_fd.get(),
Jeff Hao10b8a6e2017-04-05 17:11:39 -07001891 dex_path,
Richard Uhler76cc0272016-12-08 10:46:35 +00001892 out_oat_path,
1893 swap_fd.get(),
1894 instruction_set,
1895 compiler_filter,
Richard Uhler76cc0272016-12-08 10:46:35 +00001896 debuggable,
1897 boot_complete,
Andreas Gampea73a0cb2017-11-02 18:14:42 -07001898 background_job_compile,
Richard Uhler76cc0272016-12-08 10:46:35 +00001899 reference_profile_fd.get(),
David Brazdil570d3982018-01-16 20:15:43 +00001900 class_loader_context,
David Brazdil7fcbb812018-01-17 17:05:40 +00001901 target_sdk_version,
1902 disable_hidden_api_checks);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001903 _exit(68); /* only get here on exec failure */
1904 } else {
1905 int res = wait_child(pid);
1906 if (res == 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001907 ALOGV("DexInv: --- END '%s' (success) ---\n", dex_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001908 } else {
Calin Juravlec9eab382017-01-25 01:17:17 -08001909 ALOGE("DexInv: --- END '%s' --- status=0x%04x, process failed\n", dex_path, res);
Andreas Gampe013f02e2017-03-20 18:36:54 -07001910 return res;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001911 }
1912 }
1913
Calin Juravlec9eab382017-01-25 01:17:17 -08001914 update_out_oat_access_times(dex_path, out_oat_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001915
1916 // We've been successful, don't delete output.
1917 out_oat_fd.SetCleanup(false);
Calin Juravle7a570e82017-01-14 16:23:30 -08001918 out_vdex_fd.SetCleanup(false);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001919 image_fd.SetCleanup(false);
1920 reference_profile_fd.SetCleanup(false);
1921
1922 return 0;
1923}
1924
Calin Juravlec9eab382017-01-25 01:17:17 -08001925// Try to remove the given directory. Log an error if the directory exists
1926// and is empty but could not be removed.
1927static bool rmdir_if_empty(const char* dir) {
1928 if (rmdir(dir) == 0) {
1929 return true;
1930 }
1931 if (errno == ENOENT || errno == ENOTEMPTY) {
1932 return true;
1933 }
1934 PLOG(ERROR) << "Failed to remove dir: " << dir;
1935 return false;
1936}
1937
1938// Try to unlink the given file. Log an error if the file exists and could not
1939// be unlinked.
1940static bool unlink_if_exists(const std::string& file) {
1941 if (unlink(file.c_str()) == 0) {
1942 return true;
1943 }
1944 if (errno == ENOENT) {
1945 return true;
1946
1947 }
1948 PLOG(ERROR) << "Could not unlink: " << file;
1949 return false;
1950}
1951
Calin Juravle7d765462017-09-04 15:57:10 -07001952enum ReconcileSecondaryDexResult {
1953 kReconcileSecondaryDexExists = 0,
1954 kReconcileSecondaryDexCleanedUp = 1,
1955 kReconcileSecondaryDexValidationError = 2,
1956 kReconcileSecondaryDexCleanUpError = 3,
1957 kReconcileSecondaryDexAccessIOError = 4,
1958};
Calin Juravlec9eab382017-01-25 01:17:17 -08001959
1960// Reconcile the secondary dex 'dex_path' and its generated oat files.
1961// Return true if all the parameters are valid and the secondary dex file was
1962// processed successfully (i.e. the dex_path either exists, or if not, its corresponding
1963// oat/vdex/art files where deleted successfully). In this case, out_secondary_dex_exists
1964// will be true if the secondary dex file still exists. If the secondary dex file does not exist,
1965// the method cleans up any previously generated compiler artifacts (oat, vdex, art).
1966// Return false if there were errors during processing. In this case
1967// out_secondary_dex_exists will be set to false.
1968bool reconcile_secondary_dex_file(const std::string& dex_path,
1969 const std::string& pkgname, int uid, const std::vector<std::string>& isas,
1970 const std::unique_ptr<std::string>& volume_uuid, int storage_flag,
1971 /*out*/bool* out_secondary_dex_exists) {
Calin Juravle7d765462017-09-04 15:57:10 -07001972 *out_secondary_dex_exists = false; // start by assuming the file does not exist.
Calin Juravlec9eab382017-01-25 01:17:17 -08001973 if (isas.size() == 0) {
1974 LOG(ERROR) << "reconcile_secondary_dex_file called with empty isas vector";
1975 return false;
1976 }
1977
Calin Juravle7d765462017-09-04 15:57:10 -07001978 if (storage_flag != FLAG_STORAGE_CE && storage_flag != FLAG_STORAGE_DE) {
1979 LOG(ERROR) << "reconcile_secondary_dex_file called with invalid storage_flag: "
1980 << storage_flag;
Calin Juravlec9eab382017-01-25 01:17:17 -08001981 return false;
1982 }
1983
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001984 // As a security measure we want to unlink art artifacts with the reduced capabilities
1985 // of the package user id. So we fork and drop capabilities in the child.
1986 pid_t pid = fork();
1987 if (pid == 0) {
Calin Juravle7d765462017-09-04 15:57:10 -07001988 /* child -- drop privileges before continuing */
1989 drop_capabilities(uid);
1990
1991 const char* volume_uuid_cstr = volume_uuid == nullptr ? nullptr : volume_uuid->c_str();
1992 if (!validate_secondary_dex_path(pkgname.c_str(), dex_path.c_str(), volume_uuid_cstr,
1993 uid, storage_flag)) {
1994 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
1995 _exit(kReconcileSecondaryDexValidationError);
1996 }
1997
1998 SecondaryDexAccess access_check = check_secondary_dex_access(dex_path);
1999 switch (access_check) {
2000 case kSecondaryDexAccessDoesNotExist:
2001 // File does not exist. Proceed with cleaning.
2002 break;
2003 case kSecondaryDexAccessReadOk: _exit(kReconcileSecondaryDexExists);
2004 case kSecondaryDexAccessIOError: _exit(kReconcileSecondaryDexAccessIOError);
2005 case kSecondaryDexAccessPermissionError: _exit(kReconcileSecondaryDexValidationError);
2006 default:
2007 LOG(ERROR) << "Unexpected result from check_secondary_dex_access: " << access_check;
2008 _exit(kReconcileSecondaryDexValidationError);
2009 }
2010
2011 // The secondary dex does not exist anymore or it's. Clear any generated files.
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002012 char oat_path[PKG_PATH_MAX];
2013 char oat_dir[PKG_PATH_MAX];
2014 char oat_isa_dir[PKG_PATH_MAX];
2015 bool result = true;
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002016 for (size_t i = 0; i < isas.size(); i++) {
Calin Juravle7d765462017-09-04 15:57:10 -07002017 if (!create_secondary_dex_oat_layout(
2018 dex_path,isas[i], oat_dir, oat_isa_dir, oat_path)) {
2019 LOG(ERROR) << "Could not create secondary odex layout: " << dex_path;
2020 _exit(kReconcileSecondaryDexValidationError);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002021 }
Calin Juravle51314092017-05-18 15:33:05 -07002022
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002023 // Delete oat/vdex/art files.
2024 result = unlink_if_exists(oat_path) && result;
2025 result = unlink_if_exists(create_vdex_filename(oat_path)) && result;
2026 result = unlink_if_exists(create_image_filename(oat_path)) && result;
Calin Juravlec9eab382017-01-25 01:17:17 -08002027
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002028 // Delete profiles.
2029 std::string current_profile = create_current_profile_path(
Calin Juravle51314092017-05-18 15:33:05 -07002030 multiuser_get_user_id(uid), dex_path, /*is_secondary*/true);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002031 std::string reference_profile = create_reference_profile_path(
Calin Juravle51314092017-05-18 15:33:05 -07002032 dex_path, /*is_secondary*/true);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002033 result = unlink_if_exists(current_profile) && result;
2034 result = unlink_if_exists(reference_profile) && result;
Calin Juravle51314092017-05-18 15:33:05 -07002035
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002036 // We upgraded once the location of current profile for secondary dex files.
2037 // Check for any previous left-overs and remove them as well.
2038 std::string old_current_profile = dex_path + ".prof";
2039 result = unlink_if_exists(old_current_profile);
Calin Juravle3760ad32017-07-27 16:31:55 -07002040
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002041 // Try removing the directories as well, they might be empty.
2042 result = rmdir_if_empty(oat_isa_dir) && result;
2043 result = rmdir_if_empty(oat_dir) && result;
2044 }
Calin Juravle7d765462017-09-04 15:57:10 -07002045 if (!result) {
2046 PLOG(ERROR) << "Failed to clean secondary dex artifacts for location " << dex_path;
2047 }
2048 _exit(result ? kReconcileSecondaryDexCleanedUp : kReconcileSecondaryDexAccessIOError);
Calin Juravlec9eab382017-01-25 01:17:17 -08002049 }
2050
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002051 int return_code = wait_child(pid);
Calin Juravle7d765462017-09-04 15:57:10 -07002052 if (!WIFEXITED(return_code)) {
2053 LOG(WARNING) << "reconcile dex failed for location " << dex_path << ": " << return_code;
2054 } else {
2055 return_code = WEXITSTATUS(return_code);
2056 }
2057
2058 LOG(DEBUG) << "Reconcile secondary dex path " << dex_path << " result=" << return_code;
2059
2060 switch (return_code) {
2061 case kReconcileSecondaryDexCleanedUp:
2062 case kReconcileSecondaryDexValidationError:
2063 // If we couldn't validate assume the dex file does not exist.
2064 // This will purge the entry from the PM records.
2065 *out_secondary_dex_exists = false;
2066 return true;
2067 case kReconcileSecondaryDexExists:
2068 *out_secondary_dex_exists = true;
2069 return true;
2070 case kReconcileSecondaryDexAccessIOError:
2071 // We had an access IO error.
2072 // Return false so that we can try again.
2073 // The value of out_secondary_dex_exists does not matter in this case and by convention
2074 // is set to false.
2075 *out_secondary_dex_exists = false;
2076 return false;
2077 default:
2078 LOG(ERROR) << "Unexpected code from reconcile_secondary_dex_file: " << return_code;
2079 *out_secondary_dex_exists = false;
2080 return false;
2081 }
Calin Juravlec9eab382017-01-25 01:17:17 -08002082}
2083
Jeff Sharkey90aff262016-12-12 14:28:24 -07002084// Helper for move_ab, so that we can have common failure-case cleanup.
2085static bool unlink_and_rename(const char* from, const char* to) {
2086 // Check whether "from" exists, and if so whether it's regular. If it is, unlink. Otherwise,
2087 // return a failure.
2088 struct stat s;
2089 if (stat(to, &s) == 0) {
2090 if (!S_ISREG(s.st_mode)) {
2091 LOG(ERROR) << from << " is not a regular file to replace for A/B.";
2092 return false;
2093 }
2094 if (unlink(to) != 0) {
2095 LOG(ERROR) << "Could not unlink " << to << " to move A/B.";
2096 return false;
2097 }
2098 } else {
2099 // This may be a permission problem. We could investigate the error code, but we'll just
2100 // let the rename failure do the work for us.
2101 }
2102
2103 // Try to rename "to" to "from."
2104 if (rename(from, to) != 0) {
2105 PLOG(ERROR) << "Could not rename " << from << " to " << to;
2106 return false;
2107 }
2108 return true;
2109}
2110
2111// Move/rename a B artifact (from) to an A artifact (to).
2112static bool move_ab_path(const std::string& b_path, const std::string& a_path) {
2113 // Check whether B exists.
2114 {
2115 struct stat s;
2116 if (stat(b_path.c_str(), &s) != 0) {
2117 // Silently ignore for now. The service calling this isn't smart enough to understand
2118 // lack of artifacts at the moment.
2119 return false;
2120 }
2121 if (!S_ISREG(s.st_mode)) {
2122 LOG(ERROR) << "A/B artifact " << b_path << " is not a regular file.";
2123 // Try to unlink, but swallow errors.
2124 unlink(b_path.c_str());
2125 return false;
2126 }
2127 }
2128
2129 // Rename B to A.
2130 if (!unlink_and_rename(b_path.c_str(), a_path.c_str())) {
2131 // Delete the b_path so we don't try again (or fail earlier).
2132 if (unlink(b_path.c_str()) != 0) {
2133 PLOG(ERROR) << "Could not unlink " << b_path;
2134 }
2135
2136 return false;
2137 }
2138
2139 return true;
2140}
2141
2142bool move_ab(const char* apk_path, const char* instruction_set, const char* oat_dir) {
2143 // Get the current slot suffix. No suffix, no A/B.
2144 std::string slot_suffix;
2145 {
2146 char buf[kPropertyValueMax];
2147 if (get_property("ro.boot.slot_suffix", buf, nullptr) <= 0) {
2148 return false;
2149 }
2150 slot_suffix = buf;
2151
2152 if (!ValidateTargetSlotSuffix(slot_suffix)) {
2153 LOG(ERROR) << "Target slot suffix not legal: " << slot_suffix;
2154 return false;
2155 }
2156 }
2157
2158 // Validate other inputs.
2159 if (validate_apk_path(apk_path) != 0) {
2160 LOG(ERROR) << "Invalid apk_path: " << apk_path;
2161 return false;
2162 }
2163 if (validate_apk_path(oat_dir) != 0) {
2164 LOG(ERROR) << "Invalid oat_dir: " << oat_dir;
2165 return false;
2166 }
2167
2168 char a_path[PKG_PATH_MAX];
2169 if (!calculate_oat_file_path(a_path, oat_dir, apk_path, instruction_set)) {
2170 return false;
2171 }
2172 const std::string a_vdex_path = create_vdex_filename(a_path);
2173 const std::string a_image_path = create_image_filename(a_path);
2174
2175 // B path = A path + slot suffix.
2176 const std::string b_path = StringPrintf("%s.%s", a_path, slot_suffix.c_str());
2177 const std::string b_vdex_path = StringPrintf("%s.%s", a_vdex_path.c_str(), slot_suffix.c_str());
2178 const std::string b_image_path = StringPrintf("%s.%s",
2179 a_image_path.c_str(),
2180 slot_suffix.c_str());
2181
2182 bool success = true;
2183 if (move_ab_path(b_path, a_path)) {
2184 if (move_ab_path(b_vdex_path, a_vdex_path)) {
2185 // Note: we can live without an app image. As such, ignore failure to move the image file.
2186 // If we decide to require the app image, or the app image being moved correctly,
2187 // then change accordingly.
2188 constexpr bool kIgnoreAppImageFailure = true;
2189
2190 if (!a_image_path.empty()) {
2191 if (!move_ab_path(b_image_path, a_image_path)) {
2192 unlink(a_image_path.c_str());
2193 if (!kIgnoreAppImageFailure) {
2194 success = false;
2195 }
2196 }
2197 }
2198 } else {
2199 // Cleanup: delete B image, ignore errors.
2200 unlink(b_image_path.c_str());
2201 success = false;
2202 }
2203 } else {
2204 // Cleanup: delete B image, ignore errors.
2205 unlink(b_vdex_path.c_str());
2206 unlink(b_image_path.c_str());
2207 success = false;
2208 }
2209 return success;
2210}
2211
2212bool delete_odex(const char* apk_path, const char* instruction_set, const char* oat_dir) {
2213 // Delete the oat/odex file.
2214 char out_path[PKG_PATH_MAX];
Calin Juravle80a21252017-01-17 14:43:25 -08002215 if (!create_oat_out_path(apk_path, instruction_set, oat_dir,
Calin Juravle114f0812017-03-08 19:05:07 -08002216 /*is_secondary_dex*/false, out_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07002217 return false;
2218 }
2219
2220 // In case of a permission failure report the issue. Otherwise just print a warning.
2221 auto unlink_and_check = [](const char* path) -> bool {
2222 int result = unlink(path);
2223 if (result != 0) {
2224 if (errno == EACCES || errno == EPERM) {
2225 PLOG(ERROR) << "Could not unlink " << path;
2226 return false;
2227 }
2228 PLOG(WARNING) << "Could not unlink " << path;
2229 }
2230 return true;
2231 };
2232
2233 // Delete the oat/odex file.
2234 bool return_value_oat = unlink_and_check(out_path);
2235
2236 // Derive and delete the app image.
2237 bool return_value_art = unlink_and_check(create_image_filename(out_path).c_str());
2238
Nicolas Geoffray192fb962017-05-25 13:58:06 +01002239 // Derive and delete the vdex file.
2240 bool return_value_vdex = unlink_and_check(create_vdex_filename(out_path).c_str());
2241
Jeff Sharkey90aff262016-12-12 14:28:24 -07002242 // Report success.
Nicolas Geoffray192fb962017-05-25 13:58:06 +01002243 return return_value_oat && return_value_art && return_value_vdex;
Jeff Sharkey90aff262016-12-12 14:28:24 -07002244}
2245
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06002246static bool is_absolute_path(const std::string& path) {
2247 if (path.find('/') != 0 || path.find("..") != std::string::npos) {
2248 LOG(ERROR) << "Invalid absolute path " << path;
2249 return false;
2250 } else {
2251 return true;
2252 }
2253}
2254
2255static bool is_valid_instruction_set(const std::string& instruction_set) {
2256 // TODO: add explicit whitelisting of instruction sets
2257 if (instruction_set.find('/') != std::string::npos) {
2258 LOG(ERROR) << "Invalid instruction set " << instruction_set;
2259 return false;
2260 } else {
2261 return true;
2262 }
2263}
2264
2265bool calculate_oat_file_path_default(char path[PKG_PATH_MAX], const char *oat_dir,
2266 const char *apk_path, const char *instruction_set) {
2267 std::string oat_dir_ = oat_dir;
2268 std::string apk_path_ = apk_path;
2269 std::string instruction_set_ = instruction_set;
2270
2271 if (!is_absolute_path(oat_dir_)) return false;
2272 if (!is_absolute_path(apk_path_)) return false;
2273 if (!is_valid_instruction_set(instruction_set_)) return false;
2274
2275 std::string::size_type end = apk_path_.rfind('.');
2276 std::string::size_type start = apk_path_.rfind('/', end);
2277 if (end == std::string::npos || start == std::string::npos) {
2278 LOG(ERROR) << "Invalid apk_path " << apk_path_;
2279 return false;
2280 }
2281
2282 std::string res_ = oat_dir_ + '/' + instruction_set + '/'
2283 + apk_path_.substr(start + 1, end - start - 1) + ".odex";
2284 const char* res = res_.c_str();
2285 if (strlen(res) >= PKG_PATH_MAX) {
2286 LOG(ERROR) << "Result too large";
2287 return false;
2288 } else {
2289 strlcpy(path, res, PKG_PATH_MAX);
2290 return true;
2291 }
2292}
2293
2294bool calculate_odex_file_path_default(char path[PKG_PATH_MAX], const char *apk_path,
2295 const char *instruction_set) {
2296 std::string apk_path_ = apk_path;
2297 std::string instruction_set_ = instruction_set;
2298
2299 if (!is_absolute_path(apk_path_)) return false;
2300 if (!is_valid_instruction_set(instruction_set_)) return false;
2301
2302 std::string::size_type end = apk_path_.rfind('.');
2303 std::string::size_type start = apk_path_.rfind('/', end);
2304 if (end == std::string::npos || start == std::string::npos) {
2305 LOG(ERROR) << "Invalid apk_path " << apk_path_;
2306 return false;
2307 }
2308
2309 std::string oat_dir = apk_path_.substr(0, start + 1) + "oat";
2310 return calculate_oat_file_path_default(path, oat_dir.c_str(), apk_path, instruction_set);
2311}
2312
2313bool create_cache_path_default(char path[PKG_PATH_MAX], const char *src,
2314 const char *instruction_set) {
2315 std::string src_ = src;
2316 std::string instruction_set_ = instruction_set;
2317
2318 if (!is_absolute_path(src_)) return false;
2319 if (!is_valid_instruction_set(instruction_set_)) return false;
2320
2321 for (auto it = src_.begin() + 1; it < src_.end(); ++it) {
2322 if (*it == '/') {
2323 *it = '@';
2324 }
2325 }
2326
2327 std::string res_ = android_data_dir + DALVIK_CACHE + '/' + instruction_set_ + src_
2328 + DALVIK_CACHE_POSTFIX;
2329 const char* res = res_.c_str();
2330 if (strlen(res) >= PKG_PATH_MAX) {
2331 LOG(ERROR) << "Result too large";
2332 return false;
2333 } else {
2334 strlcpy(path, res, PKG_PATH_MAX);
2335 return true;
2336 }
2337}
2338
Calin Juravlec3596c32017-12-05 12:29:15 -08002339bool create_profile_snapshot(int32_t app_id, const std::string& package_name,
Calin Juravle29591732017-11-20 17:46:19 -08002340 const std::string& code_path) {
2341 int app_shared_gid = multiuser_get_shared_gid(/*user_id*/ 0, app_id);
2342
2343 unique_fd snapshot_fd = open_spnashot_profile(AID_SYSTEM, package_name, code_path);
2344 if (snapshot_fd < 0) {
2345 return false;
2346 }
2347
2348 std::vector<unique_fd> profiles_fd;
2349 unique_fd reference_profile_fd;
2350 open_profile_files(app_shared_gid, package_name, /*is_secondary_dex*/ false, &profiles_fd,
2351 &reference_profile_fd);
2352 if (profiles_fd.empty() || (reference_profile_fd.get() < 0)) {
2353 return false;
2354 }
2355
2356 profiles_fd.push_back(std::move(reference_profile_fd));
2357
2358 pid_t pid = fork();
2359 if (pid == 0) {
2360 /* child -- drop privileges before continuing */
2361 drop_capabilities(app_shared_gid);
2362 run_profman_merge(profiles_fd, snapshot_fd);
2363 exit(42); /* only get here on exec failure */
2364 }
2365
2366 /* parent */
2367 int return_code = wait_child(pid);
2368 if (!WIFEXITED(return_code)) {
2369 LOG(WARNING) << "profman failed for " << package_name << ":" << code_path;
2370 return false;
2371 }
2372
2373 return true;
2374}
2375
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07002376} // namespace installd
2377} // namespace android