blob: 4cd05b25c8fc39ceff0e9b5a4d619f448e60ab29 [file] [log] [blame]
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07001/*
2 * Copyright (C) 2016 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
Mark Salyzyna5e161b2016-09-29 08:08:05 -070016#define LOG_TAG "installed"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070017
Alan Stokesa25d90c2017-10-16 10:56:00 +010018#include <array>
Jeff Sharkey90aff262016-12-12 14:28:24 -070019#include <fcntl.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070020#include <stdlib.h>
21#include <string.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070022#include <sys/capability.h>
23#include <sys/file.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070024#include <sys/stat.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070025#include <sys/time.h>
26#include <sys/types.h>
27#include <sys/resource.h>
28#include <sys/wait.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070029#include <unistd.h>
30
Alan Stokesa25d90c2017-10-16 10:56:00 +010031#include <android-base/file.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070032#include <android-base/logging.h>
Andreas Gampe6a9cf722017-07-24 16:49:10 -070033#include <android-base/properties.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070034#include <android-base/stringprintf.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070035#include <android-base/strings.h>
36#include <android-base/unique_fd.h>
Calin Juravle80a21252017-01-17 14:43:25 -080037#include <cutils/fs.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070038#include <cutils/properties.h>
39#include <cutils/sched_policy.h>
Mark Salyzyn7823e122016-09-29 08:08:05 -070040#include <log/log.h> // TODO: Move everything to base/logging.
Alan Stokesa25d90c2017-10-16 10:56:00 +010041#include <openssl/sha.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070042#include <private/android_filesystem_config.h>
Calin Juravlecb556e32017-04-04 20:22:50 -070043#include <selinux/android.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070044#include <system/thread_defs.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070045
46#include "dexopt.h"
Jeff Sharkeyc1149c92017-09-21 14:51:09 -060047#include "globals.h"
Jeff Sharkey90aff262016-12-12 14:28:24 -070048#include "installd_deps.h"
49#include "otapreopt_utils.h"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070050#include "utils.h"
51
Jeff Sharkey90aff262016-12-12 14:28:24 -070052using android::base::EndsWith;
Alan Stokesa25d90c2017-10-16 10:56:00 +010053using android::base::ReadFully;
54using android::base::StringPrintf;
55using android::base::WriteFully;
Calin Juravle1a0af3b2017-03-09 14:33:33 -080056using android::base::unique_fd;
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070057
58namespace android {
59namespace installd {
60
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -070061// Should minidebug info be included in compiled artifacts? Even if this value is
62// "true," usage might still be conditional to other constraints, e.g., system
63// property overrides.
64static constexpr bool kEnableMinidebugInfo = true;
65
66static constexpr const char* kMinidebugInfoSystemProperty = "dalvik.vm.dex2oat-minidebuginfo";
67static constexpr bool kMinidebugInfoSystemPropertyDefault = false;
68static constexpr const char* kMinidebugDex2oatFlag = "--generate-mini-debug-info";
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -080069static constexpr const char* kDisableCompactDexFlag = "--compact-dex-level=none";
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -070070
Calin Juravle114f0812017-03-08 19:05:07 -080071// Deleter using free() for use with std::unique_ptr<>. See also UniqueCPtr<> below.
72struct FreeDelete {
73 // NOTE: Deleting a const object is valid but free() takes a non-const pointer.
74 void operator()(const void* ptr) const {
75 free(const_cast<void*>(ptr));
76 }
77};
78
79// Alias for std::unique_ptr<> that uses the C function free() to delete objects.
80template <typename T>
81using UniqueCPtr = std::unique_ptr<T, FreeDelete>;
82
Calin Juravle1a0af3b2017-03-09 14:33:33 -080083static unique_fd invalid_unique_fd() {
84 return unique_fd(-1);
85}
86
Andreas Gampe6a9cf722017-07-24 16:49:10 -070087static bool is_debug_runtime() {
88 return android::base::GetProperty("persist.sys.dalvik.vm.lib.2", "") == "libartd.so";
89}
90
David Sehra3b5ab62017-10-25 14:27:29 -070091static bool is_debuggable_build() {
92 return android::base::GetBoolProperty("ro.debuggable", false);
93}
94
Jeff Sharkey90aff262016-12-12 14:28:24 -070095static bool clear_profile(const std::string& profile) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -080096 unique_fd ufd(open(profile.c_str(), O_WRONLY | O_NOFOLLOW | O_CLOEXEC));
Jeff Sharkey90aff262016-12-12 14:28:24 -070097 if (ufd.get() < 0) {
98 if (errno != ENOENT) {
99 PLOG(WARNING) << "Could not open profile " << profile;
100 return false;
101 } else {
102 // Nothing to clear. That's ok.
103 return true;
104 }
105 }
106
107 if (flock(ufd.get(), LOCK_EX | LOCK_NB) != 0) {
108 if (errno != EWOULDBLOCK) {
109 PLOG(WARNING) << "Error locking profile " << profile;
110 }
111 // This implies that the app owning this profile is running
112 // (and has acquired the lock).
113 //
114 // If we can't acquire the lock bail out since clearing is useless anyway
115 // (the app will write again to the profile).
116 //
117 // Note:
118 // This does not impact the this is not an issue for the profiling correctness.
119 // In case this is needed because of an app upgrade, profiles will still be
120 // eventually cleared by the app itself due to checksum mismatch.
121 // If this is needed because profman advised, then keeping the data around
122 // until the next run is again not an issue.
123 //
124 // If the app attempts to acquire a lock while we've held one here,
125 // it will simply skip the current write cycle.
126 return false;
127 }
128
129 bool truncated = ftruncate(ufd.get(), 0) == 0;
130 if (!truncated) {
131 PLOG(WARNING) << "Could not truncate " << profile;
132 }
133 if (flock(ufd.get(), LOCK_UN) != 0) {
134 PLOG(WARNING) << "Error unlocking profile " << profile;
135 }
136 return truncated;
137}
138
Calin Juravle114f0812017-03-08 19:05:07 -0800139// Clear the reference profile for the given location.
Calin Juravle824a64d2018-01-18 20:23:17 -0800140// The location is the profile name for primary apks or the dex path for secondary dex files.
141static bool clear_reference_profile(const std::string& package_name, const std::string& location,
142 bool is_secondary_dex) {
143 return clear_profile(create_reference_profile_path(package_name, location, is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700144}
145
Calin Juravle114f0812017-03-08 19:05:07 -0800146// Clear the reference profile for the given location.
Calin Juravle824a64d2018-01-18 20:23:17 -0800147// The location is the profile name for primary apks or the dex path for secondary dex files.
148static bool clear_current_profile(const std::string& package_name, const std::string& location,
149 userid_t user, bool is_secondary_dex) {
150 return clear_profile(create_current_profile_path(user, package_name, location,
151 is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700152}
153
Calin Juravle114f0812017-03-08 19:05:07 -0800154// Clear the reference profile for the primary apk of the given package.
Calin Juravle824a64d2018-01-18 20:23:17 -0800155// The location is the profile name for primary apks or the dex path for secondary dex files.
156bool clear_primary_reference_profile(const std::string& package_name,
157 const std::string& location) {
158 return clear_reference_profile(package_name, location, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800159}
160
161// Clear all current profile for the primary apk of the given package.
Calin Juravle824a64d2018-01-18 20:23:17 -0800162// The location is the profile name for primary apks or the dex path for secondary dex files.
163bool clear_primary_current_profiles(const std::string& package_name, const std::string& location) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700164 bool success = true;
Calin Juravle114f0812017-03-08 19:05:07 -0800165 // For secondary dex files, we don't really need the user but we use it for sanity checks.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700166 std::vector<userid_t> users = get_known_users(/*volume_uuid*/ nullptr);
167 for (auto user : users) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800168 success &= clear_current_profile(package_name, location, user, /*is_secondary_dex*/false);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700169 }
170 return success;
171}
172
Calin Juravle114f0812017-03-08 19:05:07 -0800173// Clear the current profile for the primary apk of the given package and user.
Calin Juravle824a64d2018-01-18 20:23:17 -0800174bool clear_primary_current_profile(const std::string& package_name, const std::string& location,
175 userid_t user) {
176 return clear_current_profile(package_name, location, user, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800177}
178
Jeff Sharkey90aff262016-12-12 14:28:24 -0700179static int split_count(const char *str)
180{
181 char *ctx;
182 int count = 0;
183 char buf[kPropertyValueMax];
184
Jeff Sharkeyc1149c92017-09-21 14:51:09 -0600185 strlcpy(buf, str, sizeof(buf));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700186 char *pBuf = buf;
187
188 while(strtok_r(pBuf, " ", &ctx) != NULL) {
189 count++;
190 pBuf = NULL;
191 }
192
193 return count;
194}
195
196static int split(char *buf, const char **argv)
197{
198 char *ctx;
199 int count = 0;
200 char *tok;
201 char *pBuf = buf;
202
203 while((tok = strtok_r(pBuf, " ", &ctx)) != NULL) {
204 argv[count++] = tok;
205 pBuf = NULL;
206 }
207
208 return count;
209}
210
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700211static const char* get_location_from_path(const char* path) {
212 static constexpr char kLocationSeparator = '/';
213 const char *location = strrchr(path, kLocationSeparator);
214 if (location == NULL) {
215 return path;
216 } else {
217 // Skip the separator character.
218 return location + 1;
219 }
220}
221
Jeff Sharkey90aff262016-12-12 14:28:24 -0700222static void run_dex2oat(int zip_fd, int oat_fd, int input_vdex_fd, int output_vdex_fd, int image_fd,
223 const char* input_file_name, const char* output_file_name, int swap_fd,
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100224 const char* instruction_set, const char* compiler_filter,
Andreas Gampea73a0cb2017-11-02 18:14:42 -0700225 bool debuggable, bool post_bootcomplete, bool background_job_compile, int profile_fd,
David Brazdil52249162018-02-12 18:04:59 -0800226 const char* class_loader_context, int target_sdk_version, bool enable_hidden_api_checks) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700227 static const unsigned int MAX_INSTRUCTION_SET_LEN = 7;
228
229 if (strlen(instruction_set) >= MAX_INSTRUCTION_SET_LEN) {
230 ALOGE("Instruction set %s longer than max length of %d",
231 instruction_set, MAX_INSTRUCTION_SET_LEN);
232 return;
233 }
234
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700235 // Get the relative path to the input file.
236 const char* relative_input_file_name = get_location_from_path(input_file_name);
237
Jeff Sharkey90aff262016-12-12 14:28:24 -0700238 char dex2oat_Xms_flag[kPropertyValueMax];
239 bool have_dex2oat_Xms_flag = get_property("dalvik.vm.dex2oat-Xms", dex2oat_Xms_flag, NULL) > 0;
240
241 char dex2oat_Xmx_flag[kPropertyValueMax];
242 bool have_dex2oat_Xmx_flag = get_property("dalvik.vm.dex2oat-Xmx", dex2oat_Xmx_flag, NULL) > 0;
243
244 char dex2oat_threads_buf[kPropertyValueMax];
245 bool have_dex2oat_threads_flag = get_property(post_bootcomplete
246 ? "dalvik.vm.dex2oat-threads"
247 : "dalvik.vm.boot-dex2oat-threads",
248 dex2oat_threads_buf,
249 NULL) > 0;
250 char dex2oat_threads_arg[kPropertyValueMax + 2];
251 if (have_dex2oat_threads_flag) {
252 sprintf(dex2oat_threads_arg, "-j%s", dex2oat_threads_buf);
253 }
254
255 char dex2oat_isa_features_key[kPropertyKeyMax];
256 sprintf(dex2oat_isa_features_key, "dalvik.vm.isa.%s.features", instruction_set);
257 char dex2oat_isa_features[kPropertyValueMax];
258 bool have_dex2oat_isa_features = get_property(dex2oat_isa_features_key,
259 dex2oat_isa_features, NULL) > 0;
260
261 char dex2oat_isa_variant_key[kPropertyKeyMax];
262 sprintf(dex2oat_isa_variant_key, "dalvik.vm.isa.%s.variant", instruction_set);
263 char dex2oat_isa_variant[kPropertyValueMax];
264 bool have_dex2oat_isa_variant = get_property(dex2oat_isa_variant_key,
265 dex2oat_isa_variant, NULL) > 0;
266
267 const char *dex2oat_norelocation = "-Xnorelocate";
268 bool have_dex2oat_relocation_skip_flag = false;
269
270 char dex2oat_flags[kPropertyValueMax];
271 int dex2oat_flags_count = get_property("dalvik.vm.dex2oat-flags",
272 dex2oat_flags, NULL) <= 0 ? 0 : split_count(dex2oat_flags);
273 ALOGV("dalvik.vm.dex2oat-flags=%s\n", dex2oat_flags);
274
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100275 // If we are booting without the real /data, don't spend time compiling.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700276 char vold_decrypt[kPropertyValueMax];
277 bool have_vold_decrypt = get_property("vold.decrypt", vold_decrypt, "") > 0;
278 bool skip_compilation = (have_vold_decrypt &&
279 (strcmp(vold_decrypt, "trigger_restart_min_framework") == 0 ||
280 (strcmp(vold_decrypt, "1") == 0)));
281
282 bool generate_debug_info = property_get_bool("debug.generate-debug-info", false);
283
284 char app_image_format[kPropertyValueMax];
285 char image_format_arg[strlen("--image-format=") + kPropertyValueMax];
286 bool have_app_image_format =
287 image_fd >= 0 && get_property("dalvik.vm.appimageformat", app_image_format, NULL) > 0;
288 if (have_app_image_format) {
289 sprintf(image_format_arg, "--image-format=%s", app_image_format);
290 }
291
292 char dex2oat_large_app_threshold[kPropertyValueMax];
293 bool have_dex2oat_large_app_threshold =
294 get_property("dalvik.vm.dex2oat-very-large", dex2oat_large_app_threshold, NULL) > 0;
295 char dex2oat_large_app_threshold_arg[strlen("--very-large-app-threshold=") + kPropertyValueMax];
296 if (have_dex2oat_large_app_threshold) {
297 sprintf(dex2oat_large_app_threshold_arg,
298 "--very-large-app-threshold=%s",
299 dex2oat_large_app_threshold);
300 }
301
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700302 // If the runtime was requested to use libartd.so, we'll run dex2oatd, otherwise dex2oat.
David Sehra3b5ab62017-10-25 14:27:29 -0700303 const char* dex2oat_bin = "/system/bin/dex2oat";
304 static const char* kDex2oatDebugPath = "/system/bin/dex2oatd";
Andreas Gampea73a0cb2017-11-02 18:14:42 -0700305 if (is_debug_runtime() || (background_job_compile && is_debuggable_build())) {
David Sehra3b5ab62017-10-25 14:27:29 -0700306 DCHECK(access(kDex2oatDebugPath, X_OK) == 0);
307 dex2oat_bin = kDex2oatDebugPath;
308 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700309
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -0700310 bool generate_minidebug_info = kEnableMinidebugInfo &&
311 android::base::GetBoolProperty(kMinidebugInfoSystemProperty,
312 kMinidebugInfoSystemPropertyDefault);
313
Jeff Sharkey90aff262016-12-12 14:28:24 -0700314 static const char* RUNTIME_ARG = "--runtime-arg";
315
316 static const int MAX_INT_LEN = 12; // '-'+10dig+'\0' -OR- 0x+8dig
317
George Burgess IV36cebe772017-01-25 11:52:01 -0800318 // clang FORTIFY doesn't let us use strlen in constant array bounds, so we
319 // use arraysize instead.
320 char zip_fd_arg[arraysize("--zip-fd=") + MAX_INT_LEN];
321 char zip_location_arg[arraysize("--zip-location=") + PKG_PATH_MAX];
322 char input_vdex_fd_arg[arraysize("--input-vdex-fd=") + MAX_INT_LEN];
323 char output_vdex_fd_arg[arraysize("--output-vdex-fd=") + MAX_INT_LEN];
324 char oat_fd_arg[arraysize("--oat-fd=") + MAX_INT_LEN];
325 char oat_location_arg[arraysize("--oat-location=") + PKG_PATH_MAX];
326 char instruction_set_arg[arraysize("--instruction-set=") + MAX_INSTRUCTION_SET_LEN];
327 char instruction_set_variant_arg[arraysize("--instruction-set-variant=") + kPropertyValueMax];
328 char instruction_set_features_arg[arraysize("--instruction-set-features=") + kPropertyValueMax];
329 char dex2oat_Xms_arg[arraysize("-Xms") + kPropertyValueMax];
330 char dex2oat_Xmx_arg[arraysize("-Xmx") + kPropertyValueMax];
331 char dex2oat_compiler_filter_arg[arraysize("--compiler-filter=") + kPropertyValueMax];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700332 bool have_dex2oat_swap_fd = false;
George Burgess IV36cebe772017-01-25 11:52:01 -0800333 char dex2oat_swap_fd[arraysize("--swap-fd=") + MAX_INT_LEN];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700334 bool have_dex2oat_image_fd = false;
George Burgess IV36cebe772017-01-25 11:52:01 -0800335 char dex2oat_image_fd[arraysize("--app-image-fd=") + MAX_INT_LEN];
Calin Juravle52c45822017-07-13 22:50:21 -0700336 size_t class_loader_context_size = arraysize("--class-loader-context=") + PKG_PATH_MAX;
David Brazdil570d3982018-01-16 20:15:43 +0000337 char target_sdk_version_arg[arraysize("-Xtarget-sdk-version:") + MAX_INT_LEN];
Calin Juravle52c45822017-07-13 22:50:21 -0700338 char class_loader_context_arg[class_loader_context_size];
339 if (class_loader_context != nullptr) {
340 snprintf(class_loader_context_arg, class_loader_context_size, "--class-loader-context=%s",
341 class_loader_context);
342 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700343
344 sprintf(zip_fd_arg, "--zip-fd=%d", zip_fd);
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700345 sprintf(zip_location_arg, "--zip-location=%s", relative_input_file_name);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700346 sprintf(input_vdex_fd_arg, "--input-vdex-fd=%d", input_vdex_fd);
347 sprintf(output_vdex_fd_arg, "--output-vdex-fd=%d", output_vdex_fd);
348 sprintf(oat_fd_arg, "--oat-fd=%d", oat_fd);
349 sprintf(oat_location_arg, "--oat-location=%s", output_file_name);
350 sprintf(instruction_set_arg, "--instruction-set=%s", instruction_set);
351 sprintf(instruction_set_variant_arg, "--instruction-set-variant=%s", dex2oat_isa_variant);
352 sprintf(instruction_set_features_arg, "--instruction-set-features=%s", dex2oat_isa_features);
353 if (swap_fd >= 0) {
354 have_dex2oat_swap_fd = true;
355 sprintf(dex2oat_swap_fd, "--swap-fd=%d", swap_fd);
356 }
357 if (image_fd >= 0) {
358 have_dex2oat_image_fd = true;
359 sprintf(dex2oat_image_fd, "--app-image-fd=%d", image_fd);
360 }
361
362 if (have_dex2oat_Xms_flag) {
363 sprintf(dex2oat_Xms_arg, "-Xms%s", dex2oat_Xms_flag);
364 }
365 if (have_dex2oat_Xmx_flag) {
366 sprintf(dex2oat_Xmx_arg, "-Xmx%s", dex2oat_Xmx_flag);
367 }
David Brazdil570d3982018-01-16 20:15:43 +0000368 sprintf(target_sdk_version_arg, "-Xtarget-sdk-version:%d", target_sdk_version);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700369
370 // Compute compiler filter.
371
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100372 bool have_dex2oat_compiler_filter_flag = false;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700373 if (skip_compilation) {
Jeff Sharkeyc1149c92017-09-21 14:51:09 -0600374 strlcpy(dex2oat_compiler_filter_arg, "--compiler-filter=extract",
375 sizeof(dex2oat_compiler_filter_arg));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700376 have_dex2oat_compiler_filter_flag = true;
377 have_dex2oat_relocation_skip_flag = true;
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100378 } else if (compiler_filter != nullptr) {
379 if (strlen(compiler_filter) + strlen("--compiler-filter=") <
Jeff Sharkey90aff262016-12-12 14:28:24 -0700380 arraysize(dex2oat_compiler_filter_arg)) {
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100381 sprintf(dex2oat_compiler_filter_arg, "--compiler-filter=%s", compiler_filter);
382 have_dex2oat_compiler_filter_flag = true;
383 } else {
384 ALOGW("Compiler filter name '%s' is too large (max characters is %zu)",
385 compiler_filter,
386 kPropertyValueMax);
387 }
388 }
389
390 if (!have_dex2oat_compiler_filter_flag) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700391 char dex2oat_compiler_filter_flag[kPropertyValueMax];
392 have_dex2oat_compiler_filter_flag = get_property("dalvik.vm.dex2oat-filter",
393 dex2oat_compiler_filter_flag, NULL) > 0;
394 if (have_dex2oat_compiler_filter_flag) {
395 sprintf(dex2oat_compiler_filter_arg,
396 "--compiler-filter=%s",
397 dex2oat_compiler_filter_flag);
398 }
399 }
400
401 // Check whether all apps should be compiled debuggable.
402 if (!debuggable) {
403 char prop_buf[kPropertyValueMax];
404 debuggable =
405 (get_property("dalvik.vm.always_debuggable", prop_buf, "0") > 0) &&
406 (prop_buf[0] == '1');
407 }
408 char profile_arg[strlen("--profile-file-fd=") + MAX_INT_LEN];
409 if (profile_fd != -1) {
410 sprintf(profile_arg, "--profile-file-fd=%d", profile_fd);
411 }
412
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700413 // Get the directory of the apk to pass as a base classpath directory.
414 char base_dir[arraysize("--classpath-dir=") + PKG_PATH_MAX];
415 std::string apk_dir(input_file_name);
416 unsigned long dir_index = apk_dir.rfind('/');
417 bool has_base_dir = dir_index != std::string::npos;
418 if (has_base_dir) {
419 apk_dir = apk_dir.substr(0, dir_index);
420 sprintf(base_dir, "--classpath-dir=%s", apk_dir.c_str());
421 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700422
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700423
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700424 ALOGV("Running %s in=%s out=%s\n", dex2oat_bin, relative_input_file_name, output_file_name);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700425
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800426 // Disable cdex if update input vdex is true since this combination of options is not
427 // supported.
Mathieu Chartier1fb463e2018-01-09 15:16:10 -0800428 // Disable cdex for non-background compiles since we don't want to regress app install until
429 // there are enough benefits to justify the tradeoff.
430 const bool disable_cdex = !background_job_compile || (input_vdex_fd == output_vdex_fd);
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800431
Jeff Sharkey90aff262016-12-12 14:28:24 -0700432 const char* argv[9 // program name, mandatory arguments and the final NULL
433 + (have_dex2oat_isa_variant ? 1 : 0)
434 + (have_dex2oat_isa_features ? 1 : 0)
435 + (have_dex2oat_Xms_flag ? 2 : 0)
436 + (have_dex2oat_Xmx_flag ? 2 : 0)
437 + (have_dex2oat_compiler_filter_flag ? 1 : 0)
438 + (have_dex2oat_threads_flag ? 1 : 0)
439 + (have_dex2oat_swap_fd ? 1 : 0)
440 + (have_dex2oat_image_fd ? 1 : 0)
441 + (have_dex2oat_relocation_skip_flag ? 2 : 0)
442 + (generate_debug_info ? 1 : 0)
443 + (debuggable ? 1 : 0)
444 + (have_app_image_format ? 1 : 0)
445 + dex2oat_flags_count
446 + (profile_fd == -1 ? 0 : 1)
Calin Juravle52c45822017-07-13 22:50:21 -0700447 + (class_loader_context != nullptr ? 1 : 0)
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700448 + (has_base_dir ? 1 : 0)
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -0700449 + (have_dex2oat_large_app_threshold ? 1 : 0)
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800450 + (disable_cdex ? 1 : 0)
David Brazdil570d3982018-01-16 20:15:43 +0000451 + (generate_minidebug_info ? 1 : 0)
David Brazdil7fcbb812018-01-17 17:05:40 +0000452 + (target_sdk_version != 0 ? 2 : 0)
David Brazdil52249162018-02-12 18:04:59 -0800453 + (enable_hidden_api_checks ? 2 : 0)];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700454 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700455 argv[i++] = dex2oat_bin;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700456 argv[i++] = zip_fd_arg;
457 argv[i++] = zip_location_arg;
458 argv[i++] = input_vdex_fd_arg;
459 argv[i++] = output_vdex_fd_arg;
460 argv[i++] = oat_fd_arg;
461 argv[i++] = oat_location_arg;
462 argv[i++] = instruction_set_arg;
463 if (have_dex2oat_isa_variant) {
464 argv[i++] = instruction_set_variant_arg;
465 }
466 if (have_dex2oat_isa_features) {
467 argv[i++] = instruction_set_features_arg;
468 }
469 if (have_dex2oat_Xms_flag) {
470 argv[i++] = RUNTIME_ARG;
471 argv[i++] = dex2oat_Xms_arg;
472 }
473 if (have_dex2oat_Xmx_flag) {
474 argv[i++] = RUNTIME_ARG;
475 argv[i++] = dex2oat_Xmx_arg;
476 }
477 if (have_dex2oat_compiler_filter_flag) {
478 argv[i++] = dex2oat_compiler_filter_arg;
479 }
480 if (have_dex2oat_threads_flag) {
481 argv[i++] = dex2oat_threads_arg;
482 }
483 if (have_dex2oat_swap_fd) {
484 argv[i++] = dex2oat_swap_fd;
485 }
486 if (have_dex2oat_image_fd) {
487 argv[i++] = dex2oat_image_fd;
488 }
489 if (generate_debug_info) {
490 argv[i++] = "--generate-debug-info";
491 }
492 if (debuggable) {
493 argv[i++] = "--debuggable";
494 }
495 if (have_app_image_format) {
496 argv[i++] = image_format_arg;
497 }
498 if (have_dex2oat_large_app_threshold) {
499 argv[i++] = dex2oat_large_app_threshold_arg;
500 }
501 if (dex2oat_flags_count) {
502 i += split(dex2oat_flags, argv + i);
503 }
504 if (have_dex2oat_relocation_skip_flag) {
505 argv[i++] = RUNTIME_ARG;
506 argv[i++] = dex2oat_norelocation;
507 }
508 if (profile_fd != -1) {
509 argv[i++] = profile_arg;
510 }
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700511 if (has_base_dir) {
512 argv[i++] = base_dir;
513 }
Calin Juravle52c45822017-07-13 22:50:21 -0700514 if (class_loader_context != nullptr) {
515 argv[i++] = class_loader_context_arg;
516 }
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -0700517 if (generate_minidebug_info) {
518 argv[i++] = kMinidebugDex2oatFlag;
519 }
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800520 if (disable_cdex) {
521 argv[i++] = kDisableCompactDexFlag;
522 }
David Brazdil570d3982018-01-16 20:15:43 +0000523 if (target_sdk_version != 0) {
524 argv[i++] = RUNTIME_ARG;
525 argv[i++] = target_sdk_version_arg;
526 }
David Brazdil52249162018-02-12 18:04:59 -0800527 if (enable_hidden_api_checks) {
David Brazdil7fcbb812018-01-17 17:05:40 +0000528 argv[i++] = RUNTIME_ARG;
David Brazdil52249162018-02-12 18:04:59 -0800529 argv[i++] = "-Xhidden-api-checks";
David Brazdil7fcbb812018-01-17 17:05:40 +0000530 }
Calin Juravle52c45822017-07-13 22:50:21 -0700531
Jeff Sharkey90aff262016-12-12 14:28:24 -0700532 // Do not add after dex2oat_flags, they should override others for debugging.
533 argv[i] = NULL;
534
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700535 execv(dex2oat_bin, (char * const *)argv);
536 ALOGE("execv(%s) failed: %s\n", dex2oat_bin, strerror(errno));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700537}
538
539/*
540 * Whether dexopt should use a swap file when compiling an APK.
541 *
542 * If kAlwaysProvideSwapFile, do this on all devices (dex2oat will make a more informed decision
543 * itself, anyways).
544 *
545 * Otherwise, read "dalvik.vm.dex2oat-swap". If the property exists, return whether it is "true".
546 *
547 * Otherwise, return true if this is a low-mem device.
548 *
549 * Otherwise, return default value.
550 */
551static bool kAlwaysProvideSwapFile = false;
552static bool kDefaultProvideSwapFile = true;
553
554static bool ShouldUseSwapFileForDexopt() {
555 if (kAlwaysProvideSwapFile) {
556 return true;
557 }
558
559 // Check the "override" property. If it exists, return value == "true".
560 char dex2oat_prop_buf[kPropertyValueMax];
561 if (get_property("dalvik.vm.dex2oat-swap", dex2oat_prop_buf, "") > 0) {
562 if (strcmp(dex2oat_prop_buf, "true") == 0) {
563 return true;
564 } else {
565 return false;
566 }
567 }
568
569 // Shortcut for default value. This is an implementation optimization for the process sketched
570 // above. If the default value is true, we can avoid to check whether this is a low-mem device,
571 // as low-mem is never returning false. The compiler will optimize this away if it can.
572 if (kDefaultProvideSwapFile) {
573 return true;
574 }
575
576 bool is_low_mem = property_get_bool("ro.config.low_ram", false);
577 if (is_low_mem) {
578 return true;
579 }
580
581 // Default value must be false here.
582 return kDefaultProvideSwapFile;
583}
584
Richard Uhler76cc0272016-12-08 10:46:35 +0000585static void SetDex2OatScheduling(bool set_to_bg) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700586 if (set_to_bg) {
587 if (set_sched_policy(0, SP_BACKGROUND) < 0) {
588 ALOGE("set_sched_policy failed: %s\n", strerror(errno));
589 exit(70);
590 }
591 if (setpriority(PRIO_PROCESS, 0, ANDROID_PRIORITY_BACKGROUND) < 0) {
592 ALOGE("setpriority failed: %s\n", strerror(errno));
593 exit(71);
594 }
595 }
596}
597
Calin Juravle29591732017-11-20 17:46:19 -0800598static unique_fd create_profile(uid_t uid, const std::string& profile, int32_t flags) {
599 unique_fd fd(TEMP_FAILURE_RETRY(open(profile.c_str(), flags, 0600)));
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800600 if (fd.get() < 0) {
Calin Juravle29591732017-11-20 17:46:19 -0800601 if (errno != EEXIST) {
Calin Juravle114f0812017-03-08 19:05:07 -0800602 PLOG(ERROR) << "Failed to create profile " << profile;
Calin Juravle29591732017-11-20 17:46:19 -0800603 return invalid_unique_fd();
Calin Juravle114f0812017-03-08 19:05:07 -0800604 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700605 }
Calin Juravle114f0812017-03-08 19:05:07 -0800606 // Profiles should belong to the app; make sure of that by giving ownership to
607 // the app uid. If we cannot do that, there's no point in returning the fd
608 // since dex2oat/profman will fail with SElinux denials.
609 if (fchown(fd.get(), uid, uid) < 0) {
610 PLOG(ERROR) << "Could not chwon profile " << profile;
Calin Juravle29591732017-11-20 17:46:19 -0800611 return invalid_unique_fd();
Calin Juravle114f0812017-03-08 19:05:07 -0800612 }
Calin Juravle29591732017-11-20 17:46:19 -0800613 return fd;
Calin Juravle114f0812017-03-08 19:05:07 -0800614}
615
Calin Juravle29591732017-11-20 17:46:19 -0800616static unique_fd open_profile(uid_t uid, const std::string& profile, int32_t flags) {
Calin Juravle114f0812017-03-08 19:05:07 -0800617 // Do not follow symlinks when opening a profile:
618 // - primary profiles should not contain symlinks in their paths
619 // - secondary dex paths should have been already resolved and validated
620 flags |= O_NOFOLLOW;
621
Calin Juravle29591732017-11-20 17:46:19 -0800622 // Check if we need to create the profile
623 // Reference profiles and snapshots are created on the fly; so they might not exist beforehand.
624 unique_fd fd;
625 if ((flags & O_CREAT) != 0) {
626 fd = create_profile(uid, profile, flags);
627 } else {
628 fd.reset(TEMP_FAILURE_RETRY(open(profile.c_str(), flags)));
629 }
630
Calin Juravle114f0812017-03-08 19:05:07 -0800631 if (fd.get() < 0) {
632 if (errno != ENOENT) {
633 // Profiles might be missing for various reasons. For example, in a
634 // multi-user environment, the profile directory for one user can be created
635 // after we start a merge. In this case the current profile for that user
636 // will not be found.
637 // Also, the secondary dex profiles might be deleted by the app at any time,
638 // so we can't we need to prepare if they are missing.
639 PLOG(ERROR) << "Failed to open profile " << profile;
640 }
641 return invalid_unique_fd();
642 }
643
Jeff Sharkey90aff262016-12-12 14:28:24 -0700644 return fd;
645}
646
Calin Juravle824a64d2018-01-18 20:23:17 -0800647static unique_fd open_current_profile(uid_t uid, userid_t user, const std::string& package_name,
648 const std::string& location, bool is_secondary_dex) {
649 std::string profile = create_current_profile_path(user, package_name, location,
650 is_secondary_dex);
Calin Juravle29591732017-11-20 17:46:19 -0800651 return open_profile(uid, profile, O_RDONLY);
Calin Juravle114f0812017-03-08 19:05:07 -0800652}
653
Calin Juravle824a64d2018-01-18 20:23:17 -0800654static unique_fd open_reference_profile(uid_t uid, const std::string& package_name,
655 const std::string& location, bool read_write, bool is_secondary_dex) {
656 std::string profile = create_reference_profile_path(package_name, location, is_secondary_dex);
Calin Juravle29591732017-11-20 17:46:19 -0800657 return open_profile(uid, profile, read_write ? (O_CREAT | O_RDWR) : O_RDONLY);
658}
659
660static unique_fd open_spnashot_profile(uid_t uid, const std::string& package_name,
Calin Juravle824a64d2018-01-18 20:23:17 -0800661 const std::string& location) {
662 std::string profile = create_snapshot_profile_path(package_name, location);
Calin Juravle29591732017-11-20 17:46:19 -0800663 return open_profile(uid, profile, O_CREAT | O_RDWR | O_TRUNC);
Calin Juravle114f0812017-03-08 19:05:07 -0800664}
665
Calin Juravle824a64d2018-01-18 20:23:17 -0800666static void open_profile_files(uid_t uid, const std::string& package_name,
667 const std::string& location, bool is_secondary_dex,
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800668 /*out*/ std::vector<unique_fd>* profiles_fd, /*out*/ unique_fd* reference_profile_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700669 // Open the reference profile in read-write mode as profman might need to save the merge.
Calin Juravle824a64d2018-01-18 20:23:17 -0800670 *reference_profile_fd = open_reference_profile(uid, package_name, location,
671 /*read_write*/ true, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700672
Calin Juravle114f0812017-03-08 19:05:07 -0800673 // For secondary dex files, we don't really need the user but we use it for sanity checks.
674 // Note: the user owning the dex file should be the current user.
675 std::vector<userid_t> users;
676 if (is_secondary_dex){
677 users.push_back(multiuser_get_user_id(uid));
678 } else {
679 users = get_known_users(/*volume_uuid*/ nullptr);
680 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700681 for (auto user : users) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800682 unique_fd profile_fd = open_current_profile(uid, user, package_name, location,
683 is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700684 // Add to the lists only if both fds are valid.
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800685 if (profile_fd.get() >= 0) {
686 profiles_fd->push_back(std::move(profile_fd));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700687 }
688 }
689}
690
691static void drop_capabilities(uid_t uid) {
692 if (setgid(uid) != 0) {
693 ALOGE("setgid(%d) failed in installd during dexopt\n", uid);
694 exit(64);
695 }
696 if (setuid(uid) != 0) {
697 ALOGE("setuid(%d) failed in installd during dexopt\n", uid);
698 exit(65);
699 }
700 // drop capabilities
701 struct __user_cap_header_struct capheader;
702 struct __user_cap_data_struct capdata[2];
703 memset(&capheader, 0, sizeof(capheader));
704 memset(&capdata, 0, sizeof(capdata));
705 capheader.version = _LINUX_CAPABILITY_VERSION_3;
706 if (capset(&capheader, &capdata[0]) < 0) {
707 ALOGE("capset failed: %s\n", strerror(errno));
708 exit(66);
709 }
710}
711
712static constexpr int PROFMAN_BIN_RETURN_CODE_COMPILE = 0;
713static constexpr int PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION = 1;
714static constexpr int PROFMAN_BIN_RETURN_CODE_BAD_PROFILES = 2;
715static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_IO = 3;
716static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING = 4;
717
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800718static void run_profman_merge(const std::vector<unique_fd>& profiles_fd,
Calin Juravle0d0a4922018-01-23 19:54:11 -0800719 const unique_fd& reference_profile_fd, const std::vector<unique_fd>* apk_fds = nullptr) {
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700720 const char* profman_bin = is_debug_runtime() ? "/system/bin/profmand" : "/system/bin/profman";
Jeff Sharkey90aff262016-12-12 14:28:24 -0700721
722 std::vector<std::string> profile_args(profiles_fd.size());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700723 for (size_t k = 0; k < profiles_fd.size(); k++) {
Calin Juravle0d0a4922018-01-23 19:54:11 -0800724 profile_args[k] = "--profile-file-fd=" + std::to_string(profiles_fd[k].get());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700725 }
Calin Juravle0d0a4922018-01-23 19:54:11 -0800726 std::string reference_profile_arg = "--reference-profile-file-fd="
727 + std::to_string(reference_profile_fd.get());
728
729 std::vector<std::string> apk_args;
730 if (apk_fds != nullptr) {
731 for (size_t k = 0; k < apk_fds->size(); k++) {
732 apk_args.push_back("--apk-fd=" + std::to_string((*apk_fds)[k].get()));
733 }
734 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700735
736 // program name, reference profile fd, the final NULL and the profile fds
Calin Juravle0d0a4922018-01-23 19:54:11 -0800737 const char* argv[3 + profile_args.size() + apk_args.size()];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700738 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700739 argv[i++] = profman_bin;
Calin Juravle0d0a4922018-01-23 19:54:11 -0800740 argv[i++] = reference_profile_arg.c_str();
Jeff Sharkey90aff262016-12-12 14:28:24 -0700741 for (size_t k = 0; k < profile_args.size(); k++) {
742 argv[i++] = profile_args[k].c_str();
743 }
Calin Juravle0d0a4922018-01-23 19:54:11 -0800744 for (size_t k = 0; k < apk_args.size(); k++) {
745 argv[i++] = apk_args[k].c_str();
746 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700747 // Do not add after dex2oat_flags, they should override others for debugging.
748 argv[i] = NULL;
749
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700750 execv(profman_bin, (char * const *)argv);
751 ALOGE("execv(%s) failed: %s\n", profman_bin, strerror(errno));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700752 exit(68); /* only get here on exec failure */
753}
754
755// Decides if profile guided compilation is needed or not based on existing profiles.
Calin Juravle114f0812017-03-08 19:05:07 -0800756// The location is the package name for primary apks or the dex path for secondary dex files.
757// Returns true if there is enough information in the current profiles that makes it
758// worth to recompile the given location.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700759// If the return value is true all the current profiles would have been merged into
760// the reference profiles accessible with open_reference_profile().
Calin Juravle824a64d2018-01-18 20:23:17 -0800761static bool analyze_profiles(uid_t uid, const std::string& package_name,
762 const std::string& location, bool is_secondary_dex) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800763 std::vector<unique_fd> profiles_fd;
764 unique_fd reference_profile_fd;
Calin Juravle824a64d2018-01-18 20:23:17 -0800765 open_profile_files(uid, package_name, location, is_secondary_dex,
766 &profiles_fd, &reference_profile_fd);
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800767 if (profiles_fd.empty() || (reference_profile_fd.get() < 0)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700768 // Skip profile guided compilation because no profiles were found.
769 // Or if the reference profile info couldn't be opened.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700770 return false;
771 }
772
Jeff Sharkey90aff262016-12-12 14:28:24 -0700773 pid_t pid = fork();
774 if (pid == 0) {
775 /* child -- drop privileges before continuing */
776 drop_capabilities(uid);
777 run_profman_merge(profiles_fd, reference_profile_fd);
778 exit(68); /* only get here on exec failure */
779 }
780 /* parent */
781 int return_code = wait_child(pid);
782 bool need_to_compile = false;
783 bool should_clear_current_profiles = false;
784 bool should_clear_reference_profile = false;
785 if (!WIFEXITED(return_code)) {
Calin Juravle114f0812017-03-08 19:05:07 -0800786 LOG(WARNING) << "profman failed for location " << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700787 } else {
788 return_code = WEXITSTATUS(return_code);
789 switch (return_code) {
790 case PROFMAN_BIN_RETURN_CODE_COMPILE:
791 need_to_compile = true;
792 should_clear_current_profiles = true;
793 should_clear_reference_profile = false;
794 break;
795 case PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION:
796 need_to_compile = false;
797 should_clear_current_profiles = false;
798 should_clear_reference_profile = false;
799 break;
800 case PROFMAN_BIN_RETURN_CODE_BAD_PROFILES:
Calin Juravle114f0812017-03-08 19:05:07 -0800801 LOG(WARNING) << "Bad profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700802 need_to_compile = false;
803 should_clear_current_profiles = true;
804 should_clear_reference_profile = true;
805 break;
806 case PROFMAN_BIN_RETURN_CODE_ERROR_IO: // fall-through
807 case PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING:
808 // Temporary IO problem (e.g. locking). Ignore but log a warning.
Calin Juravle114f0812017-03-08 19:05:07 -0800809 LOG(WARNING) << "IO error while reading profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700810 need_to_compile = false;
811 should_clear_current_profiles = false;
812 should_clear_reference_profile = false;
813 break;
814 default:
815 // Unknown return code or error. Unlink profiles.
Calin Juravle114f0812017-03-08 19:05:07 -0800816 LOG(WARNING) << "Unknown error code while processing profiles for location "
817 << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700818 need_to_compile = false;
819 should_clear_current_profiles = true;
820 should_clear_reference_profile = true;
821 break;
822 }
823 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800824
Jeff Sharkey90aff262016-12-12 14:28:24 -0700825 if (should_clear_current_profiles) {
Calin Juravle114f0812017-03-08 19:05:07 -0800826 if (is_secondary_dex) {
827 // For secondary dex files, the owning user is the current user.
Calin Juravle824a64d2018-01-18 20:23:17 -0800828 clear_current_profile(package_name, location, multiuser_get_user_id(uid),
829 is_secondary_dex);
Calin Juravle114f0812017-03-08 19:05:07 -0800830 } else {
Calin Juravle824a64d2018-01-18 20:23:17 -0800831 clear_primary_current_profiles(package_name, location);
Calin Juravle114f0812017-03-08 19:05:07 -0800832 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700833 }
834 if (should_clear_reference_profile) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800835 clear_reference_profile(package_name, location, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700836 }
837 return need_to_compile;
838}
839
Calin Juravle114f0812017-03-08 19:05:07 -0800840// Decides if profile guided compilation is needed or not based on existing profiles.
841// The analysis is done for the primary apks of the given package.
842// Returns true if there is enough information in the current profiles that makes it
843// worth to recompile the package.
844// If the return value is true all the current profiles would have been merged into
845// the reference profiles accessible with open_reference_profile().
Calin Juravle824a64d2018-01-18 20:23:17 -0800846bool analyze_primary_profiles(uid_t uid, const std::string& package_name,
847 const std::string& profile_name) {
848 return analyze_profiles(uid, package_name, profile_name, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800849}
850
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800851static void run_profman_dump(const std::vector<unique_fd>& profile_fds,
852 const unique_fd& reference_profile_fd,
Jeff Sharkey90aff262016-12-12 14:28:24 -0700853 const std::vector<std::string>& dex_locations,
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800854 const std::vector<unique_fd>& apk_fds,
855 const unique_fd& output_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700856 std::vector<std::string> profman_args;
857 static const char* PROFMAN_BIN = "/system/bin/profman";
858 profman_args.push_back(PROFMAN_BIN);
859 profman_args.push_back("--dump-only");
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800860 profman_args.push_back(StringPrintf("--dump-output-to-fd=%d", output_fd.get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700861 if (reference_profile_fd != -1) {
862 profman_args.push_back(StringPrintf("--reference-profile-file-fd=%d",
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800863 reference_profile_fd.get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700864 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800865 for (size_t i = 0; i < profile_fds.size(); i++) {
866 profman_args.push_back(StringPrintf("--profile-file-fd=%d", profile_fds[i].get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700867 }
868 for (const std::string& dex_location : dex_locations) {
869 profman_args.push_back(StringPrintf("--dex-location=%s", dex_location.c_str()));
870 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800871 for (size_t i = 0; i < apk_fds.size(); i++) {
872 profman_args.push_back(StringPrintf("--apk-fd=%d", apk_fds[i].get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700873 }
874 const char **argv = new const char*[profman_args.size() + 1];
875 size_t i = 0;
876 for (const std::string& profman_arg : profman_args) {
877 argv[i++] = profman_arg.c_str();
878 }
879 argv[i] = NULL;
880
881 execv(PROFMAN_BIN, (char * const *)argv);
882 ALOGE("execv(%s) failed: %s\n", PROFMAN_BIN, strerror(errno));
883 exit(68); /* only get here on exec failure */
884}
885
Calin Juravle408cd4a2018-01-20 23:34:18 -0800886bool dump_profiles(int32_t uid, const std::string& pkgname, const std::string& profile_name,
887 const std::string& code_path) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800888 std::vector<unique_fd> profile_fds;
889 unique_fd reference_profile_fd;
Calin Juravle408cd4a2018-01-20 23:34:18 -0800890 std::string out_file_name = StringPrintf("/data/misc/profman/%s-%s.txt",
891 pkgname.c_str(), profile_name.c_str());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700892
Calin Juravle408cd4a2018-01-20 23:34:18 -0800893 open_profile_files(uid, pkgname, profile_name, /*is_secondary_dex*/false,
Calin Juravle114f0812017-03-08 19:05:07 -0800894 &profile_fds, &reference_profile_fd);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700895
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800896 const bool has_reference_profile = (reference_profile_fd.get() != -1);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700897 const bool has_profiles = !profile_fds.empty();
898
899 if (!has_reference_profile && !has_profiles) {
Calin Juravle76268c52017-03-09 13:19:42 -0800900 LOG(ERROR) << "profman dump: no profiles to dump for " << pkgname;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700901 return false;
902 }
903
Calin Juravle114f0812017-03-08 19:05:07 -0800904 unique_fd output_fd(open(out_file_name.c_str(),
905 O_WRONLY | O_CREAT | O_TRUNC | O_NOFOLLOW, 0644));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700906 if (fchmod(output_fd, S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH) < 0) {
Calin Juravle408cd4a2018-01-20 23:34:18 -0800907 LOG(ERROR) << "installd cannot chmod file for dump_profile" << out_file_name;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700908 return false;
909 }
Calin Juravle408cd4a2018-01-20 23:34:18 -0800910
Jeff Sharkey90aff262016-12-12 14:28:24 -0700911 std::vector<std::string> dex_locations;
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800912 std::vector<unique_fd> apk_fds;
Calin Juravle408cd4a2018-01-20 23:34:18 -0800913 unique_fd apk_fd(open(code_path.c_str(), O_RDONLY | O_NOFOLLOW));
914 if (apk_fd == -1) {
915 PLOG(ERROR) << "installd cannot open " << code_path.c_str();
916 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700917 }
Calin Juravle408cd4a2018-01-20 23:34:18 -0800918 dex_locations.push_back(get_location_from_path(code_path.c_str()));
919 apk_fds.push_back(std::move(apk_fd));
920
Jeff Sharkey90aff262016-12-12 14:28:24 -0700921
922 pid_t pid = fork();
923 if (pid == 0) {
924 /* child -- drop privileges before continuing */
925 drop_capabilities(uid);
926 run_profman_dump(profile_fds, reference_profile_fd, dex_locations,
927 apk_fds, output_fd);
928 exit(68); /* only get here on exec failure */
929 }
930 /* parent */
Jeff Sharkey90aff262016-12-12 14:28:24 -0700931 int return_code = wait_child(pid);
932 if (!WIFEXITED(return_code)) {
933 LOG(WARNING) << "profman failed for package " << pkgname << ": "
934 << return_code;
935 return false;
936 }
937 return true;
938}
939
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700940bool copy_system_profile(const std::string& system_profile,
Calin Juravle824a64d2018-01-18 20:23:17 -0800941 uid_t packageUid, const std::string& package_name, const std::string& profile_name) {
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700942 unique_fd in_fd(open(system_profile.c_str(), O_RDONLY | O_NOFOLLOW | O_CLOEXEC));
943 unique_fd out_fd(open_reference_profile(packageUid,
Calin Juravle824a64d2018-01-18 20:23:17 -0800944 package_name,
945 profile_name,
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700946 /*read_write*/ true,
947 /*secondary*/ false));
948 if (in_fd.get() < 0) {
949 PLOG(WARNING) << "Could not open profile " << system_profile;
950 return false;
951 }
952 if (out_fd.get() < 0) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800953 PLOG(WARNING) << "Could not open profile " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700954 return false;
955 }
956
Mathieu Chartier78f71fe2017-06-14 13:02:26 -0700957 // As a security measure we want to write the profile information with the reduced capabilities
958 // of the package user id. So we fork and drop capabilities in the child.
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700959 pid_t pid = fork();
960 if (pid == 0) {
961 /* child -- drop privileges before continuing */
962 drop_capabilities(packageUid);
963
964 if (flock(out_fd.get(), LOCK_EX | LOCK_NB) != 0) {
965 if (errno != EWOULDBLOCK) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800966 PLOG(WARNING) << "Error locking profile " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700967 }
968 // This implies that the app owning this profile is running
969 // (and has acquired the lock).
970 //
971 // The app never acquires the lock for the reference profiles of primary apks.
972 // Only dex2oat from installd will do that. Since installd is single threaded
973 // we should not see this case. Nevertheless be prepared for it.
Calin Juravle824a64d2018-01-18 20:23:17 -0800974 PLOG(WARNING) << "Failed to flock " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700975 return false;
976 }
977
978 bool truncated = ftruncate(out_fd.get(), 0) == 0;
979 if (!truncated) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800980 PLOG(WARNING) << "Could not truncate " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700981 }
982
983 // Copy over data.
984 static constexpr size_t kBufferSize = 4 * 1024;
985 char buffer[kBufferSize];
986 while (true) {
987 ssize_t bytes = read(in_fd.get(), buffer, kBufferSize);
988 if (bytes == 0) {
989 break;
990 }
991 write(out_fd.get(), buffer, bytes);
992 }
993 if (flock(out_fd.get(), LOCK_UN) != 0) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800994 PLOG(WARNING) << "Error unlocking profile " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700995 }
Mathieu Chartier78f71fe2017-06-14 13:02:26 -0700996 // Use _exit since we don't want to run the global destructors in the child.
997 // b/62597429
998 _exit(0);
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700999 }
1000 /* parent */
1001 int return_code = wait_child(pid);
1002 return return_code == 0;
1003}
1004
Jeff Sharkey90aff262016-12-12 14:28:24 -07001005static std::string replace_file_extension(const std::string& oat_path, const std::string& new_ext) {
1006 // A standard dalvik-cache entry. Replace ".dex" with `new_ext`.
1007 if (EndsWith(oat_path, ".dex")) {
1008 std::string new_path = oat_path;
1009 new_path.replace(new_path.length() - strlen(".dex"), strlen(".dex"), new_ext);
Elliott Hughes969e4f82017-12-20 12:34:09 -08001010 CHECK(EndsWith(new_path, new_ext));
Jeff Sharkey90aff262016-12-12 14:28:24 -07001011 return new_path;
1012 }
1013
1014 // An odex entry. Not that this may not be an extension, e.g., in the OTA
1015 // case (where the base name will have an extension for the B artifact).
1016 size_t odex_pos = oat_path.rfind(".odex");
1017 if (odex_pos != std::string::npos) {
1018 std::string new_path = oat_path;
1019 new_path.replace(odex_pos, strlen(".odex"), new_ext);
1020 CHECK_NE(new_path.find(new_ext), std::string::npos);
1021 return new_path;
1022 }
1023
1024 // Don't know how to handle this.
1025 return "";
1026}
1027
1028// Translate the given oat path to an art (app image) path. An empty string
1029// denotes an error.
1030static std::string create_image_filename(const std::string& oat_path) {
1031 return replace_file_extension(oat_path, ".art");
1032}
1033
1034// Translate the given oat path to a vdex path. An empty string denotes an error.
1035static std::string create_vdex_filename(const std::string& oat_path) {
1036 return replace_file_extension(oat_path, ".vdex");
1037}
1038
Jeff Sharkey90aff262016-12-12 14:28:24 -07001039static int open_output_file(const char* file_name, bool recreate, int permissions) {
1040 int flags = O_RDWR | O_CREAT;
1041 if (recreate) {
1042 if (unlink(file_name) < 0) {
1043 if (errno != ENOENT) {
1044 PLOG(ERROR) << "open_output_file: Couldn't unlink " << file_name;
1045 }
1046 }
1047 flags |= O_EXCL;
1048 }
1049 return open(file_name, flags, permissions);
1050}
1051
Calin Juravle2289c0a2017-02-15 12:44:14 -08001052static bool set_permissions_and_ownership(
1053 int fd, bool is_public, int uid, const char* path, bool is_secondary_dex) {
1054 // Primary apks are owned by the system. Secondary dex files are owned by the app.
1055 int owning_uid = is_secondary_dex ? uid : AID_SYSTEM;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001056 if (fchmod(fd,
1057 S_IRUSR|S_IWUSR|S_IRGRP |
1058 (is_public ? S_IROTH : 0)) < 0) {
1059 ALOGE("installd cannot chmod '%s' during dexopt\n", path);
1060 return false;
Calin Juravle2289c0a2017-02-15 12:44:14 -08001061 } else if (fchown(fd, owning_uid, uid) < 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001062 ALOGE("installd cannot chown '%s' during dexopt\n", path);
1063 return false;
1064 }
1065 return true;
1066}
1067
1068static bool IsOutputDalvikCache(const char* oat_dir) {
1069 // InstallerConnection.java (which invokes installd) transforms Java null arguments
1070 // into '!'. Play it safe by handling it both.
1071 // TODO: ensure we never get null.
1072 // TODO: pass a flag instead of inferring if the output is dalvik cache.
1073 return oat_dir == nullptr || oat_dir[0] == '!';
1074}
1075
Calin Juravled23dee72017-07-06 16:29:11 -07001076// Best-effort check whether we can fit the the path into our buffers.
1077// Note: the cache path will require an additional 5 bytes for ".swap", but we'll try to run
1078// without a swap file, if necessary. Reference profiles file also add an extra ".prof"
1079// extension to the cache path (5 bytes).
1080// TODO(calin): move away from char* buffers and PKG_PATH_MAX.
1081static bool validate_dex_path_size(const std::string& dex_path) {
1082 if (dex_path.size() >= (PKG_PATH_MAX - 8)) {
1083 LOG(ERROR) << "dex_path too long: " << dex_path;
1084 return false;
1085 }
1086 return true;
1087}
1088
Jeff Sharkey90aff262016-12-12 14:28:24 -07001089static bool create_oat_out_path(const char* apk_path, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -08001090 const char* oat_dir, bool is_secondary_dex, /*out*/ char* out_oat_path) {
Calin Juravled23dee72017-07-06 16:29:11 -07001091 if (!validate_dex_path_size(apk_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001092 return false;
1093 }
1094
1095 if (!IsOutputDalvikCache(oat_dir)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001096 // Oat dirs for secondary dex files are already validated.
1097 if (!is_secondary_dex && validate_apk_path(oat_dir)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001098 ALOGE("cannot validate apk path with oat_dir '%s'\n", oat_dir);
1099 return false;
1100 }
1101 if (!calculate_oat_file_path(out_oat_path, oat_dir, apk_path, instruction_set)) {
1102 return false;
1103 }
1104 } else {
1105 if (!create_cache_path(out_oat_path, apk_path, instruction_set)) {
1106 return false;
1107 }
1108 }
1109 return true;
1110}
1111
1112// Helper for fd management. This is similar to a unique_fd in that it closes the file descriptor
1113// on destruction. It will also run the given cleanup (unless told not to) after closing.
1114//
1115// Usage example:
1116//
Calin Juravle7a570e82017-01-14 16:23:30 -08001117// Dex2oatFileWrapper file(open(...),
Jeff Sharkey90aff262016-12-12 14:28:24 -07001118// [name]() {
1119// unlink(name.c_str());
1120// });
1121// // Note: care needs to be taken about name, as it needs to have a lifetime longer than the
1122// wrapper if captured as a reference.
1123//
1124// if (file.get() == -1) {
1125// // Error opening...
1126// }
1127//
1128// ...
1129// if (error) {
1130// // At this point, when the Dex2oatFileWrapper is destructed, the cleanup function will run
1131// // and delete the file (after the fd is closed).
1132// return -1;
1133// }
1134//
1135// (Success case)
1136// file.SetCleanup(false);
1137// // At this point, when the Dex2oatFileWrapper is destructed, the cleanup function will not run
1138// // (leaving the file around; after the fd is closed).
1139//
Jeff Sharkey90aff262016-12-12 14:28:24 -07001140class Dex2oatFileWrapper {
1141 public:
Calin Juravle7a570e82017-01-14 16:23:30 -08001142 Dex2oatFileWrapper() : value_(-1), cleanup_(), do_cleanup_(true), auto_close_(true) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001143 }
1144
Calin Juravle7a570e82017-01-14 16:23:30 -08001145 Dex2oatFileWrapper(int value, std::function<void ()> cleanup)
1146 : value_(value), cleanup_(cleanup), do_cleanup_(true), auto_close_(true) {}
1147
1148 Dex2oatFileWrapper(Dex2oatFileWrapper&& other) {
1149 value_ = other.value_;
1150 cleanup_ = other.cleanup_;
1151 do_cleanup_ = other.do_cleanup_;
1152 auto_close_ = other.auto_close_;
1153 other.release();
1154 }
1155
1156 Dex2oatFileWrapper& operator=(Dex2oatFileWrapper&& other) {
1157 value_ = other.value_;
1158 cleanup_ = other.cleanup_;
1159 do_cleanup_ = other.do_cleanup_;
1160 auto_close_ = other.auto_close_;
1161 other.release();
1162 return *this;
1163 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001164
1165 ~Dex2oatFileWrapper() {
1166 reset(-1);
1167 }
1168
1169 int get() {
1170 return value_;
1171 }
1172
1173 void SetCleanup(bool cleanup) {
1174 do_cleanup_ = cleanup;
1175 }
1176
1177 void reset(int new_value) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001178 if (auto_close_ && value_ >= 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001179 close(value_);
1180 }
1181 if (do_cleanup_ && cleanup_ != nullptr) {
1182 cleanup_();
1183 }
1184
1185 value_ = new_value;
1186 }
1187
Calin Juravle7a570e82017-01-14 16:23:30 -08001188 void reset(int new_value, std::function<void ()> new_cleanup) {
1189 if (auto_close_ && value_ >= 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001190 close(value_);
1191 }
1192 if (do_cleanup_ && cleanup_ != nullptr) {
1193 cleanup_();
1194 }
1195
1196 value_ = new_value;
1197 cleanup_ = new_cleanup;
1198 }
1199
Calin Juravle7a570e82017-01-14 16:23:30 -08001200 void DisableAutoClose() {
1201 auto_close_ = false;
1202 }
1203
Jeff Sharkey90aff262016-12-12 14:28:24 -07001204 private:
Calin Juravle7a570e82017-01-14 16:23:30 -08001205 void release() {
1206 value_ = -1;
1207 do_cleanup_ = false;
1208 cleanup_ = nullptr;
1209 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001210 int value_;
Calin Juravle7a570e82017-01-14 16:23:30 -08001211 std::function<void ()> cleanup_;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001212 bool do_cleanup_;
Calin Juravle7a570e82017-01-14 16:23:30 -08001213 bool auto_close_;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001214};
1215
Calin Juravle7a570e82017-01-14 16:23:30 -08001216// (re)Creates the app image if needed.
1217Dex2oatFileWrapper maybe_open_app_image(const char* out_oat_path, bool profile_guided,
Calin Juravle2289c0a2017-02-15 12:44:14 -08001218 bool is_public, int uid, bool is_secondary_dex) {
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +01001219
1220 // We don't create an image for secondary dex files.
1221 if (is_secondary_dex) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001222 return Dex2oatFileWrapper();
1223 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001224
Calin Juravle7a570e82017-01-14 16:23:30 -08001225 const std::string image_path = create_image_filename(out_oat_path);
1226 if (image_path.empty()) {
1227 // Happens when the out_oat_path has an unknown extension.
1228 return Dex2oatFileWrapper();
1229 }
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +01001230
1231 // Use app images only if it is enabled (by a set image format) and we are compiling
1232 // profile-guided (so the app image doesn't conservatively contain all classes).
1233 if (!profile_guided) {
1234 // In case there is a stale image, remove it now. Ignore any error.
1235 unlink(image_path.c_str());
1236 return Dex2oatFileWrapper();
1237 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001238 char app_image_format[kPropertyValueMax];
1239 bool have_app_image_format =
1240 get_property("dalvik.vm.appimageformat", app_image_format, NULL) > 0;
1241 if (!have_app_image_format) {
1242 return Dex2oatFileWrapper();
1243 }
1244 // Recreate is true since we do not want to modify a mapped image. If the app is
1245 // already running and we modify the image file, it can cause crashes (b/27493510).
1246 Dex2oatFileWrapper wrapper_fd(
1247 open_output_file(image_path.c_str(), true /*recreate*/, 0600 /*permissions*/),
1248 [image_path]() { unlink(image_path.c_str()); });
1249 if (wrapper_fd.get() < 0) {
1250 // Could not create application image file. Go on since we can compile without it.
1251 LOG(ERROR) << "installd could not create '" << image_path
1252 << "' for image file during dexopt";
1253 // If we have a valid image file path but no image fd, explicitly erase the image file.
1254 if (unlink(image_path.c_str()) < 0) {
1255 if (errno != ENOENT) {
1256 PLOG(ERROR) << "Couldn't unlink image file " << image_path;
1257 }
1258 }
1259 } else if (!set_permissions_and_ownership(
Calin Juravle2289c0a2017-02-15 12:44:14 -08001260 wrapper_fd.get(), is_public, uid, image_path.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001261 ALOGE("installd cannot set owner '%s' for image during dexopt\n", image_path.c_str());
1262 wrapper_fd.reset(-1);
1263 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001264
Calin Juravle7a570e82017-01-14 16:23:30 -08001265 return wrapper_fd;
1266}
1267
1268// Creates the dexopt swap file if necessary and return its fd.
1269// Returns -1 if there's no need for a swap or in case of errors.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001270unique_fd maybe_open_dexopt_swap_file(const char* out_oat_path) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001271 if (!ShouldUseSwapFileForDexopt()) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001272 return invalid_unique_fd();
Calin Juravle7a570e82017-01-14 16:23:30 -08001273 }
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001274 auto swap_file_name = std::string(out_oat_path) + ".swap";
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001275 unique_fd swap_fd(open_output_file(
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001276 swap_file_name.c_str(), /*recreate*/true, /*permissions*/0600));
Calin Juravle7a570e82017-01-14 16:23:30 -08001277 if (swap_fd.get() < 0) {
1278 // Could not create swap file. Optimistically go on and hope that we can compile
1279 // without it.
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001280 ALOGE("installd could not create '%s' for swap during dexopt\n", swap_file_name.c_str());
Calin Juravle7a570e82017-01-14 16:23:30 -08001281 } else {
1282 // Immediately unlink. We don't really want to hit flash.
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001283 if (unlink(swap_file_name.c_str()) < 0) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001284 PLOG(ERROR) << "Couldn't unlink swap file " << swap_file_name;
1285 }
1286 }
1287 return swap_fd;
1288}
1289
1290// Opens the reference profiles if needed.
1291// Note that the reference profile might not exist so it's OK if the fd will be -1.
Calin Juravle114f0812017-03-08 19:05:07 -08001292Dex2oatFileWrapper maybe_open_reference_profile(const std::string& pkgname,
Calin Juravlec4f6a0b2018-02-01 01:27:24 +00001293 const std::string& dex_path, const char* profile_name, bool profile_guided,
Calin Juravle824a64d2018-01-18 20:23:17 -08001294 bool is_public, int uid, bool is_secondary_dex) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001295 // Public apps should not be compiled with profile information ever. Same goes for the special
1296 // package '*' used for the system server.
Calin Juravle114f0812017-03-08 19:05:07 -08001297 if (!profile_guided || is_public || (pkgname[0] == '*')) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001298 return Dex2oatFileWrapper();
Jeff Sharkey90aff262016-12-12 14:28:24 -07001299 }
Calin Juravle114f0812017-03-08 19:05:07 -08001300
1301 // Open reference profile in read only mode as dex2oat does not get write permissions.
Calin Juravlec4f6a0b2018-02-01 01:27:24 +00001302 std::string location;
1303 if (is_secondary_dex) {
1304 location = dex_path;
1305 } else {
1306 if (profile_name == nullptr) {
1307 // This path is taken for system server re-compilation lunched from ZygoteInit.
1308 return Dex2oatFileWrapper();
1309 } else {
1310 location = profile_name;
1311 }
1312 }
Calin Juravle824a64d2018-01-18 20:23:17 -08001313 unique_fd ufd = open_reference_profile(uid, pkgname, location, /*read_write*/false,
1314 is_secondary_dex);
1315 const auto& cleanup = [pkgname, location, is_secondary_dex]() {
1316 clear_reference_profile(pkgname, location, is_secondary_dex);
Calin Juravle114f0812017-03-08 19:05:07 -08001317 };
1318 return Dex2oatFileWrapper(ufd.release(), cleanup);
Calin Juravle7a570e82017-01-14 16:23:30 -08001319}
Jeff Sharkey90aff262016-12-12 14:28:24 -07001320
Calin Juravle7a570e82017-01-14 16:23:30 -08001321// Opens the vdex files and assigns the input fd to in_vdex_wrapper_fd and the output fd to
1322// out_vdex_wrapper_fd. Returns true for success or false in case of errors.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001323bool open_vdex_files_for_dex2oat(const char* apk_path, const char* out_oat_path, int dexopt_needed,
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001324 const char* instruction_set, bool is_public, int uid, bool is_secondary_dex,
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001325 bool profile_guided, Dex2oatFileWrapper* in_vdex_wrapper_fd,
Calin Juravle7a570e82017-01-14 16:23:30 -08001326 Dex2oatFileWrapper* out_vdex_wrapper_fd) {
1327 CHECK(in_vdex_wrapper_fd != nullptr);
1328 CHECK(out_vdex_wrapper_fd != nullptr);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001329 // Open the existing VDEX. We do this before creating the new output VDEX, which will
1330 // unlink the old one.
Richard Uhler76cc0272016-12-08 10:46:35 +00001331 char in_odex_path[PKG_PATH_MAX];
1332 int dexopt_action = abs(dexopt_needed);
1333 bool is_odex_location = dexopt_needed < 0;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001334 std::string in_vdex_path_str;
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001335
1336 // Infer the name of the output VDEX.
1337 const std::string out_vdex_path_str = create_vdex_filename(out_oat_path);
1338 if (out_vdex_path_str.empty()) {
1339 return false;
1340 }
1341
1342 bool update_vdex_in_place = false;
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001343 if (dexopt_action != DEX2OAT_FROM_SCRATCH) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001344 // Open the possibly existing vdex. If none exist, we pass -1 to dex2oat for input-vdex-fd.
1345 const char* path = nullptr;
1346 if (is_odex_location) {
1347 if (calculate_odex_file_path(in_odex_path, apk_path, instruction_set)) {
1348 path = in_odex_path;
1349 } else {
1350 ALOGE("installd cannot compute input vdex location for '%s'\n", apk_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001351 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001352 }
1353 } else {
1354 path = out_oat_path;
1355 }
1356 in_vdex_path_str = create_vdex_filename(path);
1357 if (in_vdex_path_str.empty()) {
1358 ALOGE("installd cannot compute input vdex location for '%s'\n", path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001359 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001360 }
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001361 // We can update in place when all these conditions are met:
1362 // 1) The vdex location to write to is the same as the vdex location to read (vdex files
1363 // on /system typically cannot be updated in place).
1364 // 2) We dex2oat due to boot image change, because we then know the existing vdex file
1365 // cannot be currently used by a running process.
1366 // 3) We are not doing a profile guided compilation, because dexlayout requires two
1367 // different vdex files to operate.
1368 update_vdex_in_place =
1369 (in_vdex_path_str == out_vdex_path_str) &&
1370 (dexopt_action == DEX2OAT_FOR_BOOT_IMAGE) &&
1371 !profile_guided;
1372 if (update_vdex_in_place) {
1373 // Open the file read-write to be able to update it.
1374 in_vdex_wrapper_fd->reset(open(in_vdex_path_str.c_str(), O_RDWR, 0));
1375 if (in_vdex_wrapper_fd->get() == -1) {
1376 // If we failed to open the file, we cannot update it in place.
1377 update_vdex_in_place = false;
1378 }
1379 } else {
1380 in_vdex_wrapper_fd->reset(open(in_vdex_path_str.c_str(), O_RDONLY, 0));
1381 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001382 }
1383
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001384 // If we are updating the vdex in place, we do not need to recreate a vdex,
1385 // and can use the same existing one.
1386 if (update_vdex_in_place) {
1387 // We unlink the file in case the invocation of dex2oat fails, to ensure we don't
1388 // have bogus stale vdex files.
1389 out_vdex_wrapper_fd->reset(
1390 in_vdex_wrapper_fd->get(),
1391 [out_vdex_path_str]() { unlink(out_vdex_path_str.c_str()); });
1392 // Disable auto close for the in wrapper fd (it will be done when destructing the out
1393 // wrapper).
1394 in_vdex_wrapper_fd->DisableAutoClose();
1395 } else {
1396 out_vdex_wrapper_fd->reset(
1397 open_output_file(out_vdex_path_str.c_str(), /*recreate*/true, /*permissions*/0644),
1398 [out_vdex_path_str]() { unlink(out_vdex_path_str.c_str()); });
1399 if (out_vdex_wrapper_fd->get() < 0) {
1400 ALOGE("installd cannot open vdex'%s' during dexopt\n", out_vdex_path_str.c_str());
1401 return false;
1402 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001403 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001404 if (!set_permissions_and_ownership(out_vdex_wrapper_fd->get(), is_public, uid,
Calin Juravle2289c0a2017-02-15 12:44:14 -08001405 out_vdex_path_str.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001406 ALOGE("installd cannot set owner '%s' for vdex during dexopt\n", out_vdex_path_str.c_str());
1407 return false;
1408 }
1409
1410 // If we got here we successfully opened the vdex files.
1411 return true;
1412}
1413
1414// Opens the output oat file for the given apk.
1415// If successful it stores the output path into out_oat_path and returns true.
1416Dex2oatFileWrapper open_oat_out_file(const char* apk_path, const char* oat_dir,
Calin Juravle80a21252017-01-17 14:43:25 -08001417 bool is_public, int uid, const char* instruction_set, bool is_secondary_dex,
1418 char* out_oat_path) {
1419 if (!create_oat_out_path(apk_path, instruction_set, oat_dir, is_secondary_dex, out_oat_path)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001420 return Dex2oatFileWrapper();
1421 }
1422 const std::string out_oat_path_str(out_oat_path);
1423 Dex2oatFileWrapper wrapper_fd(
1424 open_output_file(out_oat_path, /*recreate*/true, /*permissions*/0644),
1425 [out_oat_path_str]() { unlink(out_oat_path_str.c_str()); });
1426 if (wrapper_fd.get() < 0) {
Calin Juravle80a21252017-01-17 14:43:25 -08001427 PLOG(ERROR) << "installd cannot open output during dexopt" << out_oat_path;
Calin Juravle2289c0a2017-02-15 12:44:14 -08001428 } else if (!set_permissions_and_ownership(
1429 wrapper_fd.get(), is_public, uid, out_oat_path, is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001430 ALOGE("installd cannot set owner '%s' for output during dexopt\n", out_oat_path);
1431 wrapper_fd.reset(-1);
1432 }
1433 return wrapper_fd;
1434}
1435
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001436// Creates RDONLY fds for oat and vdex files, if exist.
1437// Returns false if it fails to create oat out path for the given apk path.
1438// Note that the method returns true even if the files could not be opened.
1439bool maybe_open_oat_and_vdex_file(const std::string& apk_path,
1440 const std::string& oat_dir,
1441 const std::string& instruction_set,
1442 bool is_secondary_dex,
1443 unique_fd* oat_file_fd,
1444 unique_fd* vdex_file_fd) {
1445 char oat_path[PKG_PATH_MAX];
1446 if (!create_oat_out_path(apk_path.c_str(),
1447 instruction_set.c_str(),
1448 oat_dir.c_str(),
1449 is_secondary_dex,
1450 oat_path)) {
Calin Juravle7d765462017-09-04 15:57:10 -07001451 LOG(ERROR) << "Could not create oat out path for "
1452 << apk_path << " with oat dir " << oat_dir;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001453 return false;
1454 }
1455 oat_file_fd->reset(open(oat_path, O_RDONLY));
1456 if (oat_file_fd->get() < 0) {
1457 PLOG(INFO) << "installd cannot open oat file during dexopt" << oat_path;
1458 }
1459
1460 std::string vdex_filename = create_vdex_filename(oat_path);
1461 vdex_file_fd->reset(open(vdex_filename.c_str(), O_RDONLY));
1462 if (vdex_file_fd->get() < 0) {
1463 PLOG(INFO) << "installd cannot open vdex file during dexopt" << vdex_filename;
1464 }
1465
1466 return true;
1467}
1468
Calin Juravle7a570e82017-01-14 16:23:30 -08001469// Updates the access times of out_oat_path based on those from apk_path.
1470void update_out_oat_access_times(const char* apk_path, const char* out_oat_path) {
1471 struct stat input_stat;
1472 memset(&input_stat, 0, sizeof(input_stat));
1473 if (stat(apk_path, &input_stat) != 0) {
1474 PLOG(ERROR) << "Could not stat " << apk_path << " during dexopt";
1475 return;
1476 }
1477
1478 struct utimbuf ut;
1479 ut.actime = input_stat.st_atime;
1480 ut.modtime = input_stat.st_mtime;
1481 if (utime(out_oat_path, &ut) != 0) {
1482 PLOG(WARNING) << "Could not update access times for " << apk_path << " during dexopt";
1483 }
1484}
1485
Calin Juravle80a21252017-01-17 14:43:25 -08001486// Runs (execv) dexoptanalyzer on the given arguments.
Calin Juravle114f0812017-03-08 19:05:07 -08001487// The analyzer will check if the dex_file needs to be (re)compiled to match the compiler_filter.
1488// If this is for a profile guided compilation, profile_was_updated will tell whether or not
1489// the profile has changed.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001490static void exec_dexoptanalyzer(const std::string& dex_file, int vdex_fd, int oat_fd,
1491 int zip_fd, const std::string& instruction_set, const std::string& compiler_filter,
1492 bool profile_was_updated, bool downgrade,
Calin Juravle58cab072017-09-12 01:02:26 -07001493 const char* class_loader_context) {
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001494 CHECK_GE(zip_fd, 0);
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001495 const char* dexoptanalyzer_bin =
1496 is_debug_runtime()
1497 ? "/system/bin/dexoptanalyzerd"
1498 : "/system/bin/dexoptanalyzer";
Calin Juravle80a21252017-01-17 14:43:25 -08001499 static const unsigned int MAX_INSTRUCTION_SET_LEN = 7;
1500
Calin Juravled23dee72017-07-06 16:29:11 -07001501 if (instruction_set.size() >= MAX_INSTRUCTION_SET_LEN) {
1502 LOG(ERROR) << "Instruction set " << instruction_set
1503 << " longer than max length of " << MAX_INSTRUCTION_SET_LEN;
Calin Juravle80a21252017-01-17 14:43:25 -08001504 return;
1505 }
1506
Calin Juravled23dee72017-07-06 16:29:11 -07001507 std::string dex_file_arg = "--dex-file=" + dex_file;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001508 std::string oat_fd_arg = "--oat-fd=" + std::to_string(oat_fd);
1509 std::string vdex_fd_arg = "--vdex-fd=" + std::to_string(vdex_fd);
1510 std::string zip_fd_arg = "--zip-fd=" + std::to_string(zip_fd);
Calin Juravled23dee72017-07-06 16:29:11 -07001511 std::string isa_arg = "--isa=" + instruction_set;
1512 std::string compiler_filter_arg = "--compiler-filter=" + compiler_filter;
Calin Juravle114f0812017-03-08 19:05:07 -08001513 const char* assume_profile_changed = "--assume-profile-changed";
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001514 const char* downgrade_flag = "--downgrade";
Calin Juravle58cab072017-09-12 01:02:26 -07001515 std::string class_loader_context_arg = "--class-loader-context=";
1516 if (class_loader_context != nullptr) {
1517 class_loader_context_arg += class_loader_context;
1518 }
Calin Juravle80a21252017-01-17 14:43:25 -08001519
Calin Juravle80a21252017-01-17 14:43:25 -08001520 // program name, dex file, isa, filter, the final NULL
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001521 const int argc = 6 +
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001522 (profile_was_updated ? 1 : 0) +
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001523 (vdex_fd >= 0 ? 1 : 0) +
1524 (oat_fd >= 0 ? 1 : 0) +
Calin Juravle58cab072017-09-12 01:02:26 -07001525 (downgrade ? 1 : 0) +
1526 (class_loader_context != nullptr ? 1 : 0);
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001527 const char* argv[argc];
Calin Juravle80a21252017-01-17 14:43:25 -08001528 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001529 argv[i++] = dexoptanalyzer_bin;
Calin Juravled23dee72017-07-06 16:29:11 -07001530 argv[i++] = dex_file_arg.c_str();
1531 argv[i++] = isa_arg.c_str();
1532 argv[i++] = compiler_filter_arg.c_str();
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001533 if (oat_fd >= 0) {
1534 argv[i++] = oat_fd_arg.c_str();
1535 }
1536 if (vdex_fd >= 0) {
1537 argv[i++] = vdex_fd_arg.c_str();
1538 }
1539 argv[i++] = zip_fd_arg.c_str();
Calin Juravle114f0812017-03-08 19:05:07 -08001540 if (profile_was_updated) {
1541 argv[i++] = assume_profile_changed;
1542 }
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001543 if (downgrade) {
1544 argv[i++] = downgrade_flag;
1545 }
Calin Juravle58cab072017-09-12 01:02:26 -07001546 if (class_loader_context != nullptr) {
Calin Juravle91501072017-10-26 15:44:53 -07001547 argv[i++] = class_loader_context_arg.c_str();
Calin Juravle58cab072017-09-12 01:02:26 -07001548 }
Calin Juravle80a21252017-01-17 14:43:25 -08001549 argv[i] = NULL;
1550
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001551 execv(dexoptanalyzer_bin, (char * const *)argv);
1552 ALOGE("execv(%s) failed: %s\n", dexoptanalyzer_bin, strerror(errno));
Calin Juravle80a21252017-01-17 14:43:25 -08001553}
1554
1555// Prepares the oat dir for the secondary dex files.
Calin Juravle114f0812017-03-08 19:05:07 -08001556static bool prepare_secondary_dex_oat_dir(const std::string& dex_path, int uid,
Calin Juravle7d765462017-09-04 15:57:10 -07001557 const char* instruction_set) {
Calin Juravle114f0812017-03-08 19:05:07 -08001558 unsigned long dirIndex = dex_path.rfind('/');
Calin Juravle80a21252017-01-17 14:43:25 -08001559 if (dirIndex == std::string::npos) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001560 LOG(ERROR ) << "Unexpected dir structure for secondary dex " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001561 return false;
1562 }
Calin Juravle114f0812017-03-08 19:05:07 -08001563 std::string dex_dir = dex_path.substr(0, dirIndex);
Calin Juravle80a21252017-01-17 14:43:25 -08001564
Calin Juravle80a21252017-01-17 14:43:25 -08001565 // Create oat file output directory.
Calin Juravleebc8a792017-04-04 20:21:05 -07001566 mode_t oat_dir_mode = S_IRWXU | S_IRWXG | S_IXOTH;
1567 if (prepare_app_cache_dir(dex_dir, "oat", oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001568 LOG(ERROR) << "Could not prepare oat dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001569 return false;
1570 }
1571
1572 char oat_dir[PKG_PATH_MAX];
Calin Juravle114f0812017-03-08 19:05:07 -08001573 snprintf(oat_dir, PKG_PATH_MAX, "%s/oat", dex_dir.c_str());
Calin Juravle80a21252017-01-17 14:43:25 -08001574
Calin Juravle7d765462017-09-04 15:57:10 -07001575 if (prepare_app_cache_dir(oat_dir, instruction_set, oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001576 LOG(ERROR) << "Could not prepare oat/isa dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001577 return false;
1578 }
1579
1580 return true;
1581}
1582
Calin Juravle7d765462017-09-04 15:57:10 -07001583// Return codes for identifying the reason why dexoptanalyzer was not invoked when processing
1584// secondary dex files. This return codes are returned by the child process created for
1585// analyzing secondary dex files in process_secondary_dex_dexopt.
Calin Juravle80a21252017-01-17 14:43:25 -08001586
Calin Juravle7d765462017-09-04 15:57:10 -07001587// The dexoptanalyzer was not invoked because of validation or IO errors.
1588static int constexpr SECONDARY_DEX_DEXOPTANALYZER_SKIPPED = 200;
1589// The dexoptanalyzer was not invoked because the dex file does not exist anymore.
1590static int constexpr SECONDARY_DEX_DEXOPTANALYZER_SKIPPED_NO_FILE = 201;
1591
1592// Verifies the result of analyzing secondary dex files from process_secondary_dex_dexopt.
Calin Juravle80a21252017-01-17 14:43:25 -08001593// If the result is valid returns true and sets dexopt_needed_out to a valid value.
1594// Returns false for errors or unexpected result values.
Calin Juravle7d765462017-09-04 15:57:10 -07001595// The result is expected to be either one of SECONDARY_DEX_* codes or a valid exit code
1596// of dexoptanalyzer.
1597static bool process_secondary_dexoptanalyzer_result(const std::string& dex_path, int result,
Calin Juravle80a21252017-01-17 14:43:25 -08001598 int* dexopt_needed_out) {
1599 // The result values are defined in dexoptanalyzer.
1600 switch (result) {
Calin Juravle7d765462017-09-04 15:57:10 -07001601 case 0: // dexoptanalyzer: no_dexopt_needed
Calin Juravle80a21252017-01-17 14:43:25 -08001602 *dexopt_needed_out = NO_DEXOPT_NEEDED; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001603 case 1: // dexoptanalyzer: dex2oat_from_scratch
Calin Juravle80a21252017-01-17 14:43:25 -08001604 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001605 case 5: // dexoptanalyzer: dex2oat_for_bootimage_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001606 *dexopt_needed_out = -DEX2OAT_FOR_BOOT_IMAGE; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001607 case 6: // dexoptanalyzer: dex2oat_for_filter_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001608 *dexopt_needed_out = -DEX2OAT_FOR_FILTER; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001609 case 7: // dexoptanalyzer: dex2oat_for_relocation_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001610 *dexopt_needed_out = -DEX2OAT_FOR_RELOCATION; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001611 case 2: // dexoptanalyzer: dex2oat_for_bootimage_oat
1612 case 3: // dexoptanalyzer: dex2oat_for_filter_oat
1613 case 4: // dexoptanalyzer: dex2oat_for_relocation_oat
Calin Juravlec9eab382017-01-25 01:17:17 -08001614 LOG(ERROR) << "Dexoptnalyzer return the status of an oat file."
1615 << " Expected odex file status for secondary dex " << dex_path
Calin Juravle80a21252017-01-17 14:43:25 -08001616 << " : dexoptanalyzer result=" << result;
1617 return false;
Calin Juravle7d765462017-09-04 15:57:10 -07001618 case SECONDARY_DEX_DEXOPTANALYZER_SKIPPED_NO_FILE:
1619 // If the file does not exist there's no need for dexopt.
1620 *dexopt_needed_out = NO_DEXOPT_NEEDED;
1621 return true;
1622 case SECONDARY_DEX_DEXOPTANALYZER_SKIPPED:
1623 return false;
Calin Juravle80a21252017-01-17 14:43:25 -08001624 default:
Calin Juravle7d765462017-09-04 15:57:10 -07001625 LOG(ERROR) << "Unexpected result from analyzing secondary dex " << dex_path
1626 << " result=" << result;
Calin Juravle80a21252017-01-17 14:43:25 -08001627 return false;
1628 }
1629}
1630
Calin Juravle7d765462017-09-04 15:57:10 -07001631enum SecondaryDexAccess {
1632 kSecondaryDexAccessReadOk = 0,
1633 kSecondaryDexAccessDoesNotExist = 1,
1634 kSecondaryDexAccessPermissionError = 2,
1635 kSecondaryDexAccessIOError = 3
1636};
1637
1638static SecondaryDexAccess check_secondary_dex_access(const std::string& dex_path) {
1639 // Check if the path exists and can be read. If not, there's nothing to do.
1640 if (access(dex_path.c_str(), R_OK) == 0) {
1641 return kSecondaryDexAccessReadOk;
1642 } else {
1643 if (errno == ENOENT) {
1644 LOG(INFO) << "Secondary dex does not exist: " << dex_path;
1645 return kSecondaryDexAccessDoesNotExist;
1646 } else {
1647 PLOG(ERROR) << "Could not access secondary dex " << dex_path;
1648 return errno == EACCES
1649 ? kSecondaryDexAccessPermissionError
1650 : kSecondaryDexAccessIOError;
1651 }
1652 }
1653}
1654
1655static bool is_file_public(const std::string& filename) {
1656 struct stat file_stat;
1657 if (stat(filename.c_str(), &file_stat) == 0) {
1658 return (file_stat.st_mode & S_IROTH) != 0;
1659 }
1660 return false;
1661}
1662
1663// Create the oat file structure for the secondary dex 'dex_path' and assign
1664// the individual path component to the 'out_' parameters.
1665static bool create_secondary_dex_oat_layout(const std::string& dex_path, const std::string& isa,
1666 char* out_oat_dir, char* out_oat_isa_dir, char* out_oat_path) {
1667 size_t dirIndex = dex_path.rfind('/');
1668 if (dirIndex == std::string::npos) {
1669 LOG(ERROR) << "Unexpected dir structure for dex file " << dex_path;
1670 return false;
1671 }
1672 // TODO(calin): we have similar computations in at lest 3 other places
1673 // (InstalldNativeService, otapropt and dexopt). Unify them and get rid of snprintf by
1674 // using string append.
1675 std::string apk_dir = dex_path.substr(0, dirIndex);
1676 snprintf(out_oat_dir, PKG_PATH_MAX, "%s/oat", apk_dir.c_str());
1677 snprintf(out_oat_isa_dir, PKG_PATH_MAX, "%s/%s", out_oat_dir, isa.c_str());
1678
1679 if (!create_oat_out_path(dex_path.c_str(), isa.c_str(), out_oat_dir,
1680 /*is_secondary_dex*/true, out_oat_path)) {
1681 LOG(ERROR) << "Could not create oat path for secondary dex " << dex_path;
1682 return false;
1683 }
1684 return true;
1685}
1686
1687// Validate that the dexopt_flags contain a valid storage flag and convert that to an installd
1688// recognized storage flags (FLAG_STORAGE_CE or FLAG_STORAGE_DE).
1689static bool validate_dexopt_storage_flags(int dexopt_flags, int* out_storage_flag) {
1690 if ((dexopt_flags & DEXOPT_STORAGE_CE) != 0) {
1691 *out_storage_flag = FLAG_STORAGE_CE;
1692 if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
1693 LOG(ERROR) << "Ambiguous secondary dex storage flag. Both, CE and DE, flags are set";
1694 return false;
1695 }
1696 } else if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
1697 *out_storage_flag = FLAG_STORAGE_DE;
1698 } else {
1699 LOG(ERROR) << "Secondary dex storage flag must be set";
1700 return false;
1701 }
1702 return true;
1703}
1704
Calin Juravlec9eab382017-01-25 01:17:17 -08001705// Processes the dex_path as a secondary dex files and return true if the path dex file should
Calin Juravle80a21252017-01-17 14:43:25 -08001706// be compiled. Returns false for errors (logged) or true if the secondary dex path was process
1707// successfully.
Calin Juravleebc8a792017-04-04 20:21:05 -07001708// When returning true, the output parameters will be:
1709// - is_public_out: whether or not the oat file should not be made public
1710// - dexopt_needed_out: valid OatFileAsssitant::DexOptNeeded
1711// - oat_dir_out: the oat dir path where the oat file should be stored
Calin Juravle7d765462017-09-04 15:57:10 -07001712static bool process_secondary_dex_dexopt(const std::string& dex_path, const char* pkgname,
Calin Juravle80a21252017-01-17 14:43:25 -08001713 int dexopt_flags, const char* volume_uuid, int uid, const char* instruction_set,
Calin Juravleebc8a792017-04-04 20:21:05 -07001714 const char* compiler_filter, bool* is_public_out, int* dexopt_needed_out,
Calin Juravle7d765462017-09-04 15:57:10 -07001715 std::string* oat_dir_out, bool downgrade, const char* class_loader_context) {
1716 LOG(DEBUG) << "Processing secondary dex path " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001717 int storage_flag;
Calin Juravle7d765462017-09-04 15:57:10 -07001718 if (!validate_dexopt_storage_flags(dexopt_flags, &storage_flag)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001719 return false;
1720 }
Calin Juravle7d765462017-09-04 15:57:10 -07001721 // Compute the oat dir as it's not easy to extract it from the child computation.
1722 char oat_path[PKG_PATH_MAX];
1723 char oat_dir[PKG_PATH_MAX];
1724 char oat_isa_dir[PKG_PATH_MAX];
1725 if (!create_secondary_dex_oat_layout(
1726 dex_path, instruction_set, oat_dir, oat_isa_dir, oat_path)) {
1727 LOG(ERROR) << "Could not create secondary odex layout: " << dex_path;
Calin Juravled23dee72017-07-06 16:29:11 -07001728 return false;
1729 }
Calin Juravle7d765462017-09-04 15:57:10 -07001730 oat_dir_out->assign(oat_dir);
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001731
Calin Juravle80a21252017-01-17 14:43:25 -08001732 pid_t pid = fork();
1733 if (pid == 0) {
1734 // child -- drop privileges before continuing.
1735 drop_capabilities(uid);
Calin Juravle7d765462017-09-04 15:57:10 -07001736
1737 // Validate the path structure.
1738 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid, uid, storage_flag)) {
1739 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
1740 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
1741 }
1742
1743 // Open the dex file.
1744 unique_fd zip_fd;
1745 zip_fd.reset(open(dex_path.c_str(), O_RDONLY));
1746 if (zip_fd.get() < 0) {
1747 if (errno == ENOENT) {
1748 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED_NO_FILE);
1749 } else {
1750 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
1751 }
1752 }
1753
1754 // Prepare the oat directories.
1755 if (!prepare_secondary_dex_oat_dir(dex_path, uid, instruction_set)) {
1756 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
1757 }
1758
1759 // Open the vdex/oat files if any.
1760 unique_fd oat_file_fd;
1761 unique_fd vdex_file_fd;
1762 if (!maybe_open_oat_and_vdex_file(dex_path,
1763 *oat_dir_out,
1764 instruction_set,
1765 true /* is_secondary_dex */,
1766 &oat_file_fd,
1767 &vdex_file_fd)) {
1768 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
1769 }
1770
1771 // Analyze profiles.
Calin Juravle824a64d2018-01-18 20:23:17 -08001772 bool profile_was_updated = analyze_profiles(uid, pkgname, dex_path,
1773 /*is_secondary_dex*/true);
Calin Juravle7d765462017-09-04 15:57:10 -07001774
1775 // Run dexoptanalyzer to get dexopt_needed code. This is not expected to return.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001776 exec_dexoptanalyzer(dex_path,
1777 vdex_file_fd.get(),
1778 oat_file_fd.get(),
1779 zip_fd.get(),
1780 instruction_set,
Calin Juravle7d765462017-09-04 15:57:10 -07001781 compiler_filter, profile_was_updated,
1782 downgrade,
1783 class_loader_context);
1784 PLOG(ERROR) << "Failed to exec dexoptanalyzer";
1785 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
Calin Juravle80a21252017-01-17 14:43:25 -08001786 }
1787
1788 /* parent */
Calin Juravle80a21252017-01-17 14:43:25 -08001789 int result = wait_child(pid);
1790 if (!WIFEXITED(result)) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001791 LOG(ERROR) << "dexoptanalyzer failed for path " << dex_path << ": " << result;
Calin Juravle80a21252017-01-17 14:43:25 -08001792 return false;
1793 }
1794 result = WEXITSTATUS(result);
Calin Juravle7d765462017-09-04 15:57:10 -07001795 // Check that we successfully executed dexoptanalyzer.
1796 bool success = process_secondary_dexoptanalyzer_result(dex_path, result, dexopt_needed_out);
1797
1798 LOG(DEBUG) << "Processed secondary dex file " << dex_path << " result=" << result;
1799
Calin Juravle80a21252017-01-17 14:43:25 -08001800 // Run dexopt only if needed or forced.
Calin Juravle7d765462017-09-04 15:57:10 -07001801 // Note that dexoptanalyzer is executed even if force compilation is enabled (because it
1802 // makes the code simpler; force compilation is only needed during tests).
1803 if (success &&
1804 (result != SECONDARY_DEX_DEXOPTANALYZER_SKIPPED_NO_FILE) &&
1805 ((dexopt_flags & DEXOPT_FORCE) != 0)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001806 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH;
1807 }
1808
Calin Juravle7d765462017-09-04 15:57:10 -07001809 // Check if we should make the oat file public.
1810 // Note that if the dex file is not public the compiled code cannot be made public.
1811 // It is ok to check this flag outside in the parent process.
1812 *is_public_out = ((dexopt_flags & DEXOPT_PUBLIC) != 0) && is_file_public(dex_path);
1813
Calin Juravle80a21252017-01-17 14:43:25 -08001814 return success;
1815}
1816
Calin Juravlec9eab382017-01-25 01:17:17 -08001817int dexopt(const char* dex_path, uid_t uid, const char* pkgname, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -08001818 int dexopt_needed, const char* oat_dir, int dexopt_flags, const char* compiler_filter,
Calin Juravle52c45822017-07-13 22:50:21 -07001819 const char* volume_uuid, const char* class_loader_context, const char* se_info,
Calin Juravle824a64d2018-01-18 20:23:17 -08001820 bool downgrade, int target_sdk_version, const char* profile_name) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001821 CHECK(pkgname != nullptr);
1822 CHECK(pkgname[0] != 0);
1823 if ((dexopt_flags & ~DEXOPT_MASK) != 0) {
1824 LOG_FATAL("dexopt flags contains unknown fields\n");
1825 }
1826
Calin Juravled23dee72017-07-06 16:29:11 -07001827 if (!validate_dex_path_size(dex_path)) {
Calin Juravle52c45822017-07-13 22:50:21 -07001828 return -1;
1829 }
1830
1831 if (class_loader_context != nullptr && strlen(class_loader_context) > PKG_PATH_MAX) {
1832 LOG(ERROR) << "Class loader context exceeds the allowed size: " << class_loader_context;
1833 return -1;
Calin Juravled23dee72017-07-06 16:29:11 -07001834 }
1835
Calin Juravleebc8a792017-04-04 20:21:05 -07001836 bool is_public = (dexopt_flags & DEXOPT_PUBLIC) != 0;
Calin Juravle7a570e82017-01-14 16:23:30 -08001837 bool debuggable = (dexopt_flags & DEXOPT_DEBUGGABLE) != 0;
1838 bool boot_complete = (dexopt_flags & DEXOPT_BOOTCOMPLETE) != 0;
1839 bool profile_guided = (dexopt_flags & DEXOPT_PROFILE_GUIDED) != 0;
Calin Juravle80a21252017-01-17 14:43:25 -08001840 bool is_secondary_dex = (dexopt_flags & DEXOPT_SECONDARY_DEX) != 0;
Andreas Gampea73a0cb2017-11-02 18:14:42 -07001841 bool background_job_compile = (dexopt_flags & DEXOPT_IDLE_BACKGROUND_JOB) != 0;
David Brazdil52249162018-02-12 18:04:59 -08001842 bool enable_hidden_api_checks = (dexopt_flags & DEXOPT_ENABLE_HIDDEN_API_CHECKS) != 0;
Calin Juravle80a21252017-01-17 14:43:25 -08001843
1844 // Check if we're dealing with a secondary dex file and if we need to compile it.
1845 std::string oat_dir_str;
1846 if (is_secondary_dex) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001847 if (process_secondary_dex_dexopt(dex_path, pkgname, dexopt_flags, volume_uuid, uid,
Calin Juravleebc8a792017-04-04 20:21:05 -07001848 instruction_set, compiler_filter, &is_public, &dexopt_needed, &oat_dir_str,
Calin Juravle7d765462017-09-04 15:57:10 -07001849 downgrade, class_loader_context)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001850 oat_dir = oat_dir_str.c_str();
1851 if (dexopt_needed == NO_DEXOPT_NEEDED) {
1852 return 0; // Nothing to do, report success.
1853 }
1854 } else {
1855 return -1; // We had an error, logged in the process method.
1856 }
1857 } else {
Calin Juravlec9eab382017-01-25 01:17:17 -08001858 // Currently these flags are only use for secondary dex files.
1859 // Verify that they are not set for primary apks.
Calin Juravle80a21252017-01-17 14:43:25 -08001860 CHECK((dexopt_flags & DEXOPT_STORAGE_CE) == 0);
1861 CHECK((dexopt_flags & DEXOPT_STORAGE_DE) == 0);
1862 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001863
1864 // Open the input file.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001865 unique_fd input_fd(open(dex_path, O_RDONLY, 0));
Calin Juravle7a570e82017-01-14 16:23:30 -08001866 if (input_fd.get() < 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001867 ALOGE("installd cannot open '%s' for input during dexopt\n", dex_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001868 return -1;
1869 }
1870
1871 // Create the output OAT file.
1872 char out_oat_path[PKG_PATH_MAX];
Calin Juravlec9eab382017-01-25 01:17:17 -08001873 Dex2oatFileWrapper out_oat_fd = open_oat_out_file(dex_path, oat_dir, is_public, uid,
Calin Juravle80a21252017-01-17 14:43:25 -08001874 instruction_set, is_secondary_dex, out_oat_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001875 if (out_oat_fd.get() < 0) {
1876 return -1;
1877 }
1878
1879 // Open vdex files.
1880 Dex2oatFileWrapper in_vdex_fd;
1881 Dex2oatFileWrapper out_vdex_fd;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001882 if (!open_vdex_files_for_dex2oat(dex_path, out_oat_path, dexopt_needed, instruction_set,
1883 is_public, uid, is_secondary_dex, profile_guided, &in_vdex_fd, &out_vdex_fd)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001884 return -1;
1885 }
1886
Calin Juravlecb556e32017-04-04 20:22:50 -07001887 // Ensure that the oat dir and the compiler artifacts of secondary dex files have the correct
1888 // selinux context (we generate them on the fly during the dexopt invocation and they don't
1889 // fully inherit their parent context).
1890 // Note that for primary apk the oat files are created before, in a separate installd
1891 // call which also does the restorecon. TODO(calin): unify the paths.
1892 if (is_secondary_dex) {
1893 if (selinux_android_restorecon_pkgdir(oat_dir, se_info, uid,
1894 SELINUX_ANDROID_RESTORECON_RECURSE)) {
1895 LOG(ERROR) << "Failed to restorecon " << oat_dir;
1896 return -1;
1897 }
1898 }
1899
Jeff Sharkey90aff262016-12-12 14:28:24 -07001900 // Create a swap file if necessary.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001901 unique_fd swap_fd = maybe_open_dexopt_swap_file(out_oat_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001902
Calin Juravle7a570e82017-01-14 16:23:30 -08001903 // Create the app image file if needed.
1904 Dex2oatFileWrapper image_fd =
Calin Juravle2289c0a2017-02-15 12:44:14 -08001905 maybe_open_app_image(out_oat_path, profile_guided, is_public, uid, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001906
Calin Juravle7a570e82017-01-14 16:23:30 -08001907 // Open the reference profile if needed.
Calin Juravle114f0812017-03-08 19:05:07 -08001908 Dex2oatFileWrapper reference_profile_fd = maybe_open_reference_profile(
Calin Juravle824a64d2018-01-18 20:23:17 -08001909 pkgname, dex_path, profile_name, profile_guided, is_public, uid, is_secondary_dex);
Calin Juravle7a570e82017-01-14 16:23:30 -08001910
Calin Juravlec9eab382017-01-25 01:17:17 -08001911 ALOGV("DexInv: --- BEGIN '%s' ---\n", dex_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001912
1913 pid_t pid = fork();
1914 if (pid == 0) {
1915 /* child -- drop privileges before continuing */
1916 drop_capabilities(uid);
1917
Richard Uhler76cc0272016-12-08 10:46:35 +00001918 SetDex2OatScheduling(boot_complete);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001919 if (flock(out_oat_fd.get(), LOCK_EX | LOCK_NB) != 0) {
1920 ALOGE("flock(%s) failed: %s\n", out_oat_path, strerror(errno));
1921 _exit(67);
1922 }
1923
Richard Uhler76cc0272016-12-08 10:46:35 +00001924 run_dex2oat(input_fd.get(),
1925 out_oat_fd.get(),
1926 in_vdex_fd.get(),
Calin Juravle7a570e82017-01-14 16:23:30 -08001927 out_vdex_fd.get(),
Richard Uhler76cc0272016-12-08 10:46:35 +00001928 image_fd.get(),
Jeff Hao10b8a6e2017-04-05 17:11:39 -07001929 dex_path,
Richard Uhler76cc0272016-12-08 10:46:35 +00001930 out_oat_path,
1931 swap_fd.get(),
1932 instruction_set,
1933 compiler_filter,
Richard Uhler76cc0272016-12-08 10:46:35 +00001934 debuggable,
1935 boot_complete,
Andreas Gampea73a0cb2017-11-02 18:14:42 -07001936 background_job_compile,
Richard Uhler76cc0272016-12-08 10:46:35 +00001937 reference_profile_fd.get(),
David Brazdil570d3982018-01-16 20:15:43 +00001938 class_loader_context,
David Brazdil7fcbb812018-01-17 17:05:40 +00001939 target_sdk_version,
David Brazdil52249162018-02-12 18:04:59 -08001940 enable_hidden_api_checks);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001941 _exit(68); /* only get here on exec failure */
1942 } else {
1943 int res = wait_child(pid);
1944 if (res == 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001945 ALOGV("DexInv: --- END '%s' (success) ---\n", dex_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001946 } else {
Calin Juravlec9eab382017-01-25 01:17:17 -08001947 ALOGE("DexInv: --- END '%s' --- status=0x%04x, process failed\n", dex_path, res);
Andreas Gampe013f02e2017-03-20 18:36:54 -07001948 return res;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001949 }
1950 }
1951
Calin Juravlec9eab382017-01-25 01:17:17 -08001952 update_out_oat_access_times(dex_path, out_oat_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001953
1954 // We've been successful, don't delete output.
1955 out_oat_fd.SetCleanup(false);
Calin Juravle7a570e82017-01-14 16:23:30 -08001956 out_vdex_fd.SetCleanup(false);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001957 image_fd.SetCleanup(false);
1958 reference_profile_fd.SetCleanup(false);
1959
1960 return 0;
1961}
1962
Calin Juravlec9eab382017-01-25 01:17:17 -08001963// Try to remove the given directory. Log an error if the directory exists
1964// and is empty but could not be removed.
1965static bool rmdir_if_empty(const char* dir) {
1966 if (rmdir(dir) == 0) {
1967 return true;
1968 }
1969 if (errno == ENOENT || errno == ENOTEMPTY) {
1970 return true;
1971 }
1972 PLOG(ERROR) << "Failed to remove dir: " << dir;
1973 return false;
1974}
1975
1976// Try to unlink the given file. Log an error if the file exists and could not
1977// be unlinked.
1978static bool unlink_if_exists(const std::string& file) {
1979 if (unlink(file.c_str()) == 0) {
1980 return true;
1981 }
1982 if (errno == ENOENT) {
1983 return true;
1984
1985 }
1986 PLOG(ERROR) << "Could not unlink: " << file;
1987 return false;
1988}
1989
Calin Juravle7d765462017-09-04 15:57:10 -07001990enum ReconcileSecondaryDexResult {
1991 kReconcileSecondaryDexExists = 0,
1992 kReconcileSecondaryDexCleanedUp = 1,
1993 kReconcileSecondaryDexValidationError = 2,
1994 kReconcileSecondaryDexCleanUpError = 3,
1995 kReconcileSecondaryDexAccessIOError = 4,
1996};
Calin Juravlec9eab382017-01-25 01:17:17 -08001997
1998// Reconcile the secondary dex 'dex_path' and its generated oat files.
1999// Return true if all the parameters are valid and the secondary dex file was
2000// processed successfully (i.e. the dex_path either exists, or if not, its corresponding
2001// oat/vdex/art files where deleted successfully). In this case, out_secondary_dex_exists
2002// will be true if the secondary dex file still exists. If the secondary dex file does not exist,
2003// the method cleans up any previously generated compiler artifacts (oat, vdex, art).
2004// Return false if there were errors during processing. In this case
2005// out_secondary_dex_exists will be set to false.
2006bool reconcile_secondary_dex_file(const std::string& dex_path,
2007 const std::string& pkgname, int uid, const std::vector<std::string>& isas,
2008 const std::unique_ptr<std::string>& volume_uuid, int storage_flag,
2009 /*out*/bool* out_secondary_dex_exists) {
Calin Juravle7d765462017-09-04 15:57:10 -07002010 *out_secondary_dex_exists = false; // start by assuming the file does not exist.
Calin Juravlec9eab382017-01-25 01:17:17 -08002011 if (isas.size() == 0) {
2012 LOG(ERROR) << "reconcile_secondary_dex_file called with empty isas vector";
2013 return false;
2014 }
2015
Calin Juravle7d765462017-09-04 15:57:10 -07002016 if (storage_flag != FLAG_STORAGE_CE && storage_flag != FLAG_STORAGE_DE) {
2017 LOG(ERROR) << "reconcile_secondary_dex_file called with invalid storage_flag: "
2018 << storage_flag;
Calin Juravlec9eab382017-01-25 01:17:17 -08002019 return false;
2020 }
2021
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002022 // As a security measure we want to unlink art artifacts with the reduced capabilities
2023 // of the package user id. So we fork and drop capabilities in the child.
2024 pid_t pid = fork();
2025 if (pid == 0) {
Calin Juravle7d765462017-09-04 15:57:10 -07002026 /* child -- drop privileges before continuing */
2027 drop_capabilities(uid);
2028
2029 const char* volume_uuid_cstr = volume_uuid == nullptr ? nullptr : volume_uuid->c_str();
2030 if (!validate_secondary_dex_path(pkgname.c_str(), dex_path.c_str(), volume_uuid_cstr,
2031 uid, storage_flag)) {
2032 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
2033 _exit(kReconcileSecondaryDexValidationError);
2034 }
2035
2036 SecondaryDexAccess access_check = check_secondary_dex_access(dex_path);
2037 switch (access_check) {
2038 case kSecondaryDexAccessDoesNotExist:
2039 // File does not exist. Proceed with cleaning.
2040 break;
2041 case kSecondaryDexAccessReadOk: _exit(kReconcileSecondaryDexExists);
2042 case kSecondaryDexAccessIOError: _exit(kReconcileSecondaryDexAccessIOError);
2043 case kSecondaryDexAccessPermissionError: _exit(kReconcileSecondaryDexValidationError);
2044 default:
2045 LOG(ERROR) << "Unexpected result from check_secondary_dex_access: " << access_check;
2046 _exit(kReconcileSecondaryDexValidationError);
2047 }
2048
2049 // The secondary dex does not exist anymore or it's. Clear any generated files.
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002050 char oat_path[PKG_PATH_MAX];
2051 char oat_dir[PKG_PATH_MAX];
2052 char oat_isa_dir[PKG_PATH_MAX];
2053 bool result = true;
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002054 for (size_t i = 0; i < isas.size(); i++) {
Calin Juravle7d765462017-09-04 15:57:10 -07002055 if (!create_secondary_dex_oat_layout(
2056 dex_path,isas[i], oat_dir, oat_isa_dir, oat_path)) {
2057 LOG(ERROR) << "Could not create secondary odex layout: " << dex_path;
2058 _exit(kReconcileSecondaryDexValidationError);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002059 }
Calin Juravle51314092017-05-18 15:33:05 -07002060
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002061 // Delete oat/vdex/art files.
2062 result = unlink_if_exists(oat_path) && result;
2063 result = unlink_if_exists(create_vdex_filename(oat_path)) && result;
2064 result = unlink_if_exists(create_image_filename(oat_path)) && result;
Calin Juravlec9eab382017-01-25 01:17:17 -08002065
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002066 // Delete profiles.
2067 std::string current_profile = create_current_profile_path(
Calin Juravle824a64d2018-01-18 20:23:17 -08002068 multiuser_get_user_id(uid), pkgname, dex_path, /*is_secondary*/true);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002069 std::string reference_profile = create_reference_profile_path(
Calin Juravle824a64d2018-01-18 20:23:17 -08002070 pkgname, dex_path, /*is_secondary*/true);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002071 result = unlink_if_exists(current_profile) && result;
2072 result = unlink_if_exists(reference_profile) && result;
Calin Juravle51314092017-05-18 15:33:05 -07002073
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002074 // We upgraded once the location of current profile for secondary dex files.
2075 // Check for any previous left-overs and remove them as well.
2076 std::string old_current_profile = dex_path + ".prof";
2077 result = unlink_if_exists(old_current_profile);
Calin Juravle3760ad32017-07-27 16:31:55 -07002078
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002079 // Try removing the directories as well, they might be empty.
2080 result = rmdir_if_empty(oat_isa_dir) && result;
2081 result = rmdir_if_empty(oat_dir) && result;
2082 }
Calin Juravle7d765462017-09-04 15:57:10 -07002083 if (!result) {
2084 PLOG(ERROR) << "Failed to clean secondary dex artifacts for location " << dex_path;
2085 }
2086 _exit(result ? kReconcileSecondaryDexCleanedUp : kReconcileSecondaryDexAccessIOError);
Calin Juravlec9eab382017-01-25 01:17:17 -08002087 }
2088
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002089 int return_code = wait_child(pid);
Calin Juravle7d765462017-09-04 15:57:10 -07002090 if (!WIFEXITED(return_code)) {
2091 LOG(WARNING) << "reconcile dex failed for location " << dex_path << ": " << return_code;
2092 } else {
2093 return_code = WEXITSTATUS(return_code);
2094 }
2095
2096 LOG(DEBUG) << "Reconcile secondary dex path " << dex_path << " result=" << return_code;
2097
2098 switch (return_code) {
2099 case kReconcileSecondaryDexCleanedUp:
2100 case kReconcileSecondaryDexValidationError:
2101 // If we couldn't validate assume the dex file does not exist.
2102 // This will purge the entry from the PM records.
2103 *out_secondary_dex_exists = false;
2104 return true;
2105 case kReconcileSecondaryDexExists:
2106 *out_secondary_dex_exists = true;
2107 return true;
2108 case kReconcileSecondaryDexAccessIOError:
2109 // We had an access IO error.
2110 // Return false so that we can try again.
2111 // The value of out_secondary_dex_exists does not matter in this case and by convention
2112 // is set to false.
2113 *out_secondary_dex_exists = false;
2114 return false;
2115 default:
2116 LOG(ERROR) << "Unexpected code from reconcile_secondary_dex_file: " << return_code;
2117 *out_secondary_dex_exists = false;
2118 return false;
2119 }
Calin Juravlec9eab382017-01-25 01:17:17 -08002120}
2121
Alan Stokesa25d90c2017-10-16 10:56:00 +01002122// Compute and return the hash (SHA-256) of the secondary dex file at dex_path.
2123// Returns true if all parameters are valid and the hash successfully computed and stored in
2124// out_secondary_dex_hash.
2125// Also returns true with an empty hash if the file does not currently exist or is not accessible to
2126// the app.
2127// For any other errors (e.g. if any of the parameters are invalid) returns false.
2128bool hash_secondary_dex_file(const std::string& dex_path, const std::string& pkgname, int uid,
2129 const std::unique_ptr<std::string>& volume_uuid, int storage_flag,
2130 std::vector<uint8_t>* out_secondary_dex_hash) {
2131 out_secondary_dex_hash->clear();
2132
2133 const char* volume_uuid_cstr = volume_uuid == nullptr ? nullptr : volume_uuid->c_str();
2134
2135 if (storage_flag != FLAG_STORAGE_CE && storage_flag != FLAG_STORAGE_DE) {
2136 LOG(ERROR) << "hash_secondary_dex_file called with invalid storage_flag: "
2137 << storage_flag;
2138 return false;
2139 }
2140
2141 // Pipe to get the hash result back from our child process.
2142 unique_fd pipe_read, pipe_write;
2143 if (!Pipe(&pipe_read, &pipe_write)) {
2144 PLOG(ERROR) << "Failed to create pipe";
2145 return false;
2146 }
2147
2148 // Fork so that actual access to the files is done in the app's own UID, to ensure we only
2149 // access data the app itself can access.
2150 pid_t pid = fork();
2151 if (pid == 0) {
2152 // child -- drop privileges before continuing
2153 drop_capabilities(uid);
2154 pipe_read.reset();
2155
2156 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid_cstr, uid, storage_flag)) {
2157 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
2158 _exit(1);
2159 }
2160
2161 unique_fd fd(TEMP_FAILURE_RETRY(open(dex_path.c_str(), O_RDONLY | O_CLOEXEC | O_NOFOLLOW)));
2162 if (fd == -1) {
2163 if (errno == EACCES || errno == ENOENT) {
2164 // Not treated as an error.
2165 _exit(0);
2166 }
2167 PLOG(ERROR) << "Failed to open secondary dex " << dex_path;
2168 _exit(1);
2169 }
2170
2171 SHA256_CTX ctx;
2172 SHA256_Init(&ctx);
2173
2174 std::vector<uint8_t> buffer(65536);
2175 while (true) {
2176 ssize_t bytes_read = TEMP_FAILURE_RETRY(read(fd, buffer.data(), buffer.size()));
2177 if (bytes_read == 0) {
2178 break;
2179 } else if (bytes_read == -1) {
2180 PLOG(ERROR) << "Failed to read secondary dex " << dex_path;
2181 _exit(1);
2182 }
2183
2184 SHA256_Update(&ctx, buffer.data(), bytes_read);
2185 }
2186
2187 std::array<uint8_t, SHA256_DIGEST_LENGTH> hash;
2188 SHA256_Final(hash.data(), &ctx);
2189 if (!WriteFully(pipe_write, hash.data(), hash.size())) {
2190 _exit(1);
2191 }
2192
2193 _exit(0);
2194 }
2195
2196 // parent
2197 pipe_write.reset();
2198
2199 out_secondary_dex_hash->resize(SHA256_DIGEST_LENGTH);
2200 if (!ReadFully(pipe_read, out_secondary_dex_hash->data(), out_secondary_dex_hash->size())) {
2201 out_secondary_dex_hash->clear();
2202 }
2203 return wait_child(pid) == 0;
2204}
2205
Jeff Sharkey90aff262016-12-12 14:28:24 -07002206// Helper for move_ab, so that we can have common failure-case cleanup.
2207static bool unlink_and_rename(const char* from, const char* to) {
2208 // Check whether "from" exists, and if so whether it's regular. If it is, unlink. Otherwise,
2209 // return a failure.
2210 struct stat s;
2211 if (stat(to, &s) == 0) {
2212 if (!S_ISREG(s.st_mode)) {
2213 LOG(ERROR) << from << " is not a regular file to replace for A/B.";
2214 return false;
2215 }
2216 if (unlink(to) != 0) {
2217 LOG(ERROR) << "Could not unlink " << to << " to move A/B.";
2218 return false;
2219 }
2220 } else {
2221 // This may be a permission problem. We could investigate the error code, but we'll just
2222 // let the rename failure do the work for us.
2223 }
2224
2225 // Try to rename "to" to "from."
2226 if (rename(from, to) != 0) {
2227 PLOG(ERROR) << "Could not rename " << from << " to " << to;
2228 return false;
2229 }
2230 return true;
2231}
2232
2233// Move/rename a B artifact (from) to an A artifact (to).
2234static bool move_ab_path(const std::string& b_path, const std::string& a_path) {
2235 // Check whether B exists.
2236 {
2237 struct stat s;
2238 if (stat(b_path.c_str(), &s) != 0) {
2239 // Silently ignore for now. The service calling this isn't smart enough to understand
2240 // lack of artifacts at the moment.
2241 return false;
2242 }
2243 if (!S_ISREG(s.st_mode)) {
2244 LOG(ERROR) << "A/B artifact " << b_path << " is not a regular file.";
2245 // Try to unlink, but swallow errors.
2246 unlink(b_path.c_str());
2247 return false;
2248 }
2249 }
2250
2251 // Rename B to A.
2252 if (!unlink_and_rename(b_path.c_str(), a_path.c_str())) {
2253 // Delete the b_path so we don't try again (or fail earlier).
2254 if (unlink(b_path.c_str()) != 0) {
2255 PLOG(ERROR) << "Could not unlink " << b_path;
2256 }
2257
2258 return false;
2259 }
2260
2261 return true;
2262}
2263
2264bool move_ab(const char* apk_path, const char* instruction_set, const char* oat_dir) {
2265 // Get the current slot suffix. No suffix, no A/B.
2266 std::string slot_suffix;
2267 {
2268 char buf[kPropertyValueMax];
2269 if (get_property("ro.boot.slot_suffix", buf, nullptr) <= 0) {
2270 return false;
2271 }
2272 slot_suffix = buf;
2273
2274 if (!ValidateTargetSlotSuffix(slot_suffix)) {
2275 LOG(ERROR) << "Target slot suffix not legal: " << slot_suffix;
2276 return false;
2277 }
2278 }
2279
2280 // Validate other inputs.
2281 if (validate_apk_path(apk_path) != 0) {
2282 LOG(ERROR) << "Invalid apk_path: " << apk_path;
2283 return false;
2284 }
2285 if (validate_apk_path(oat_dir) != 0) {
2286 LOG(ERROR) << "Invalid oat_dir: " << oat_dir;
2287 return false;
2288 }
2289
2290 char a_path[PKG_PATH_MAX];
2291 if (!calculate_oat_file_path(a_path, oat_dir, apk_path, instruction_set)) {
2292 return false;
2293 }
2294 const std::string a_vdex_path = create_vdex_filename(a_path);
2295 const std::string a_image_path = create_image_filename(a_path);
2296
2297 // B path = A path + slot suffix.
2298 const std::string b_path = StringPrintf("%s.%s", a_path, slot_suffix.c_str());
2299 const std::string b_vdex_path = StringPrintf("%s.%s", a_vdex_path.c_str(), slot_suffix.c_str());
2300 const std::string b_image_path = StringPrintf("%s.%s",
2301 a_image_path.c_str(),
2302 slot_suffix.c_str());
2303
2304 bool success = true;
2305 if (move_ab_path(b_path, a_path)) {
2306 if (move_ab_path(b_vdex_path, a_vdex_path)) {
2307 // Note: we can live without an app image. As such, ignore failure to move the image file.
2308 // If we decide to require the app image, or the app image being moved correctly,
2309 // then change accordingly.
2310 constexpr bool kIgnoreAppImageFailure = true;
2311
2312 if (!a_image_path.empty()) {
2313 if (!move_ab_path(b_image_path, a_image_path)) {
2314 unlink(a_image_path.c_str());
2315 if (!kIgnoreAppImageFailure) {
2316 success = false;
2317 }
2318 }
2319 }
2320 } else {
2321 // Cleanup: delete B image, ignore errors.
2322 unlink(b_image_path.c_str());
2323 success = false;
2324 }
2325 } else {
2326 // Cleanup: delete B image, ignore errors.
2327 unlink(b_vdex_path.c_str());
2328 unlink(b_image_path.c_str());
2329 success = false;
2330 }
2331 return success;
2332}
2333
2334bool delete_odex(const char* apk_path, const char* instruction_set, const char* oat_dir) {
2335 // Delete the oat/odex file.
2336 char out_path[PKG_PATH_MAX];
Calin Juravle80a21252017-01-17 14:43:25 -08002337 if (!create_oat_out_path(apk_path, instruction_set, oat_dir,
Calin Juravle114f0812017-03-08 19:05:07 -08002338 /*is_secondary_dex*/false, out_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07002339 return false;
2340 }
2341
2342 // In case of a permission failure report the issue. Otherwise just print a warning.
2343 auto unlink_and_check = [](const char* path) -> bool {
2344 int result = unlink(path);
2345 if (result != 0) {
2346 if (errno == EACCES || errno == EPERM) {
2347 PLOG(ERROR) << "Could not unlink " << path;
2348 return false;
2349 }
2350 PLOG(WARNING) << "Could not unlink " << path;
2351 }
2352 return true;
2353 };
2354
2355 // Delete the oat/odex file.
2356 bool return_value_oat = unlink_and_check(out_path);
2357
2358 // Derive and delete the app image.
2359 bool return_value_art = unlink_and_check(create_image_filename(out_path).c_str());
2360
Nicolas Geoffray192fb962017-05-25 13:58:06 +01002361 // Derive and delete the vdex file.
2362 bool return_value_vdex = unlink_and_check(create_vdex_filename(out_path).c_str());
2363
Jeff Sharkey90aff262016-12-12 14:28:24 -07002364 // Report success.
Nicolas Geoffray192fb962017-05-25 13:58:06 +01002365 return return_value_oat && return_value_art && return_value_vdex;
Jeff Sharkey90aff262016-12-12 14:28:24 -07002366}
2367
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06002368static bool is_absolute_path(const std::string& path) {
2369 if (path.find('/') != 0 || path.find("..") != std::string::npos) {
2370 LOG(ERROR) << "Invalid absolute path " << path;
2371 return false;
2372 } else {
2373 return true;
2374 }
2375}
2376
2377static bool is_valid_instruction_set(const std::string& instruction_set) {
2378 // TODO: add explicit whitelisting of instruction sets
2379 if (instruction_set.find('/') != std::string::npos) {
2380 LOG(ERROR) << "Invalid instruction set " << instruction_set;
2381 return false;
2382 } else {
2383 return true;
2384 }
2385}
2386
2387bool calculate_oat_file_path_default(char path[PKG_PATH_MAX], const char *oat_dir,
2388 const char *apk_path, const char *instruction_set) {
2389 std::string oat_dir_ = oat_dir;
2390 std::string apk_path_ = apk_path;
2391 std::string instruction_set_ = instruction_set;
2392
2393 if (!is_absolute_path(oat_dir_)) return false;
2394 if (!is_absolute_path(apk_path_)) return false;
2395 if (!is_valid_instruction_set(instruction_set_)) return false;
2396
2397 std::string::size_type end = apk_path_.rfind('.');
2398 std::string::size_type start = apk_path_.rfind('/', end);
2399 if (end == std::string::npos || start == std::string::npos) {
2400 LOG(ERROR) << "Invalid apk_path " << apk_path_;
2401 return false;
2402 }
2403
2404 std::string res_ = oat_dir_ + '/' + instruction_set + '/'
2405 + apk_path_.substr(start + 1, end - start - 1) + ".odex";
2406 const char* res = res_.c_str();
2407 if (strlen(res) >= PKG_PATH_MAX) {
2408 LOG(ERROR) << "Result too large";
2409 return false;
2410 } else {
2411 strlcpy(path, res, PKG_PATH_MAX);
2412 return true;
2413 }
2414}
2415
2416bool calculate_odex_file_path_default(char path[PKG_PATH_MAX], const char *apk_path,
2417 const char *instruction_set) {
2418 std::string apk_path_ = apk_path;
2419 std::string instruction_set_ = instruction_set;
2420
2421 if (!is_absolute_path(apk_path_)) return false;
2422 if (!is_valid_instruction_set(instruction_set_)) return false;
2423
2424 std::string::size_type end = apk_path_.rfind('.');
2425 std::string::size_type start = apk_path_.rfind('/', end);
2426 if (end == std::string::npos || start == std::string::npos) {
2427 LOG(ERROR) << "Invalid apk_path " << apk_path_;
2428 return false;
2429 }
2430
2431 std::string oat_dir = apk_path_.substr(0, start + 1) + "oat";
2432 return calculate_oat_file_path_default(path, oat_dir.c_str(), apk_path, instruction_set);
2433}
2434
2435bool create_cache_path_default(char path[PKG_PATH_MAX], const char *src,
2436 const char *instruction_set) {
2437 std::string src_ = src;
2438 std::string instruction_set_ = instruction_set;
2439
2440 if (!is_absolute_path(src_)) return false;
2441 if (!is_valid_instruction_set(instruction_set_)) return false;
2442
2443 for (auto it = src_.begin() + 1; it < src_.end(); ++it) {
2444 if (*it == '/') {
2445 *it = '@';
2446 }
2447 }
2448
2449 std::string res_ = android_data_dir + DALVIK_CACHE + '/' + instruction_set_ + src_
2450 + DALVIK_CACHE_POSTFIX;
2451 const char* res = res_.c_str();
2452 if (strlen(res) >= PKG_PATH_MAX) {
2453 LOG(ERROR) << "Result too large";
2454 return false;
2455 } else {
2456 strlcpy(path, res, PKG_PATH_MAX);
2457 return true;
2458 }
2459}
2460
Calin Juravle0d0a4922018-01-23 19:54:11 -08002461bool open_classpath_files(const std::string& classpath, std::vector<unique_fd>* apk_fds) {
2462 std::vector<std::string> classpaths_elems = base::Split(classpath, ":");
2463 for (const std::string& elem : classpaths_elems) {
2464 unique_fd fd(TEMP_FAILURE_RETRY(open(elem.c_str(), O_RDONLY)));
2465 if (fd < 0) {
2466 PLOG(ERROR) << "Could not open classpath elem " << elem;
2467 return false;
2468 } else {
2469 apk_fds->push_back(std::move(fd));
2470 }
2471 }
2472 return true;
2473}
2474
2475static bool create_app_profile_snapshot(int32_t app_id,
2476 const std::string& package_name,
2477 const std::string& profile_name,
2478 const std::string& classpath) {
Calin Juravle29591732017-11-20 17:46:19 -08002479 int app_shared_gid = multiuser_get_shared_gid(/*user_id*/ 0, app_id);
2480
Calin Juravle824a64d2018-01-18 20:23:17 -08002481 unique_fd snapshot_fd = open_spnashot_profile(AID_SYSTEM, package_name, profile_name);
Calin Juravle29591732017-11-20 17:46:19 -08002482 if (snapshot_fd < 0) {
2483 return false;
2484 }
2485
2486 std::vector<unique_fd> profiles_fd;
2487 unique_fd reference_profile_fd;
Calin Juravle824a64d2018-01-18 20:23:17 -08002488 open_profile_files(app_shared_gid, package_name, profile_name, /*is_secondary_dex*/ false,
2489 &profiles_fd, &reference_profile_fd);
Calin Juravle29591732017-11-20 17:46:19 -08002490 if (profiles_fd.empty() || (reference_profile_fd.get() < 0)) {
2491 return false;
2492 }
2493
2494 profiles_fd.push_back(std::move(reference_profile_fd));
2495
Calin Juravle0d0a4922018-01-23 19:54:11 -08002496 // Open the class paths elements. These will be used to filter out profile data that does
2497 // not belong to the classpath during merge.
2498 std::vector<unique_fd> apk_fds;
2499 if (!open_classpath_files(classpath, &apk_fds)) {
2500 return false;
2501 }
2502
Calin Juravle29591732017-11-20 17:46:19 -08002503 pid_t pid = fork();
2504 if (pid == 0) {
2505 /* child -- drop privileges before continuing */
2506 drop_capabilities(app_shared_gid);
Calin Juravle0d0a4922018-01-23 19:54:11 -08002507 run_profman_merge(profiles_fd, snapshot_fd, &apk_fds);
Calin Juravle29591732017-11-20 17:46:19 -08002508 exit(42); /* only get here on exec failure */
2509 }
2510
2511 /* parent */
2512 int return_code = wait_child(pid);
2513 if (!WIFEXITED(return_code)) {
Calin Juravle824a64d2018-01-18 20:23:17 -08002514 LOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
Calin Juravle29591732017-11-20 17:46:19 -08002515 return false;
2516 }
2517
2518 return true;
2519}
2520
Calin Juravle0d0a4922018-01-23 19:54:11 -08002521static bool create_boot_image_profile_snapshot(const std::string& package_name,
2522 const std::string& profile_name,
2523 const std::string& classpath) {
2524 // The reference profile directory for the android package might not be prepared. Do it now.
2525 const std::string ref_profile_dir =
2526 create_primary_reference_profile_package_dir_path(package_name);
2527 if (fs_prepare_dir(ref_profile_dir.c_str(), 0770, AID_SYSTEM, AID_SYSTEM) != 0) {
2528 PLOG(ERROR) << "Failed to prepare " << ref_profile_dir;
2529 return false;
2530 }
2531
2532 // Open and create the snapshot profile.
2533 unique_fd snapshot_fd = open_spnashot_profile(AID_SYSTEM, package_name, profile_name);
2534
2535 // Collect all non empty profiles.
2536 // The collection will traverse all applications profiles and find the non empty files.
2537 // This has the potential of inspecting a large number of files and directories (depending
2538 // on the number of applications and users). So there is a slight increase in the chance
2539 // to get get occasionally I/O errors (e.g. for opening the file). When that happens do not
2540 // fail the snapshot and aggregate whatever profile we could open.
2541 //
2542 // The profile snapshot is a best effort based on available data it's ok if some data
2543 // from some apps is missing. It will be counter productive for the snapshot to fail
2544 // because we could not open or read some of the files.
2545 std::vector<std::string> profiles;
2546 if (!collect_profiles(&profiles)) {
2547 LOG(WARNING) << "There were errors while collecting the profiles for the boot image.";
2548 }
2549
2550 // If we have no profiles return early.
2551 if (profiles.empty()) {
2552 return true;
2553 }
2554
2555 // Open the classpath elements. These will be used to filter out profile data that does
2556 // not belong to the classpath during merge.
2557 std::vector<unique_fd> apk_fds;
2558 if (!open_classpath_files(classpath, &apk_fds)) {
2559 return false;
2560 }
2561
2562 // If we could not open any files from the classpath return an error.
2563 if (apk_fds.empty()) {
2564 LOG(ERROR) << "Could not open any of the classpath elements.";
2565 return false;
2566 }
2567
2568 // Aggregate the profiles in batches of kAggregationBatchSize.
2569 // We do this to avoid opening a huge a amount of files.
2570 static constexpr size_t kAggregationBatchSize = 10;
2571
2572 std::vector<unique_fd> profiles_fd;
2573 for (size_t i = 0; i < profiles.size(); ) {
2574 for (size_t k = 0; k < kAggregationBatchSize && i < profiles.size(); k++, i++) {
2575 unique_fd fd = open_profile(AID_SYSTEM, profiles[i], O_RDONLY);
2576 if (fd.get() >= 0) {
2577 profiles_fd.push_back(std::move(fd));
2578 }
2579 }
2580 pid_t pid = fork();
2581 if (pid == 0) {
2582 /* child -- drop privileges before continuing */
2583 drop_capabilities(AID_SYSTEM);
2584
2585 run_profman_merge(profiles_fd, snapshot_fd, &apk_fds);
2586 exit(42); /* only get here on exec failure */
2587 }
2588
2589 /* parent */
2590 int return_code = wait_child(pid);
2591 if (!WIFEXITED(return_code)) {
2592 PLOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
2593 return false;
2594 }
2595 return true;
2596 }
2597 return true;
2598}
2599
2600bool create_profile_snapshot(int32_t app_id, const std::string& package_name,
2601 const std::string& profile_name, const std::string& classpath) {
2602 if (app_id == -1) {
2603 return create_boot_image_profile_snapshot(package_name, profile_name, classpath);
2604 } else {
2605 return create_app_profile_snapshot(app_id, package_name, profile_name, classpath);
2606 }
2607}
2608
Calin Juravlec3b049e2018-01-18 22:32:58 -08002609bool prepare_app_profile(const std::string& package_name,
2610 userid_t user_id,
2611 appid_t app_id,
2612 const std::string& profile_name,
2613 const std::string& code_path ATTRIBUTE_UNUSED,
2614 const std::unique_ptr<std::string>& dex_metadata) {
2615 // Prepare the current profile.
2616 std::string cur_profile = create_current_profile_path(user_id, package_name, profile_name,
2617 /*is_secondary_dex*/ false);
2618 uid_t uid = multiuser_get_uid(user_id, app_id);
2619 if (fs_prepare_file_strict(cur_profile.c_str(), 0600, uid, uid) != 0) {
2620 PLOG(ERROR) << "Failed to prepare " << cur_profile;
2621 return false;
2622 }
2623
2624 // Check if we need to install the profile from the dex metadata.
2625 if (dex_metadata == nullptr) {
2626 return true;
2627 }
2628
2629 // We have a dex metdata. Merge the profile into the reference profile.
2630 unique_fd ref_profile_fd = open_reference_profile(uid, package_name, profile_name,
2631 /*read_write*/ true, /*is_secondary_dex*/ false);
2632 unique_fd dex_metadata_fd(TEMP_FAILURE_RETRY(
2633 open(dex_metadata->c_str(), O_RDONLY | O_NOFOLLOW)));
2634 std::vector<unique_fd> profiles_fd;
2635 profiles_fd.push_back(std::move(dex_metadata_fd));
2636
2637 pid_t pid = fork();
2638 if (pid == 0) {
2639 /* child -- drop privileges before continuing */
2640 gid_t app_shared_gid = multiuser_get_shared_gid(user_id, app_id);
2641 drop_capabilities(app_shared_gid);
2642
2643 // TODO(calin): the dex metadata profile might embed different names for the
2644 // same code path (e.g. YouTube.apk or base.apk, depending on how the initial
2645 // profile was captured). We should pass the code path to adjust the names in the profile.
2646 run_profman_merge(profiles_fd, ref_profile_fd);
2647 exit(42); /* only get here on exec failure */
2648 }
2649
2650 /* parent */
2651 int return_code = wait_child(pid);
2652 if (!WIFEXITED(return_code)) {
2653 PLOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
2654 return false;
2655 }
2656 return true;
2657}
2658
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07002659} // namespace installd
2660} // namespace android