blob: c9e83985a13efded9d11545e466b03f041b76efb [file] [log] [blame]
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07001/*
2 * Copyright (C) 2016 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
Alan Stokescb27c342018-04-20 17:09:25 +010016#define LOG_TAG "installd"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070017
Alan Stokesa25d90c2017-10-16 10:56:00 +010018#include <array>
Jeff Sharkey90aff262016-12-12 14:28:24 -070019#include <fcntl.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070020#include <stdlib.h>
21#include <string.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070022#include <sys/capability.h>
23#include <sys/file.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070024#include <sys/stat.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070025#include <sys/time.h>
26#include <sys/types.h>
27#include <sys/resource.h>
28#include <sys/wait.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070029#include <unistd.h>
30
Andreas Gampe023b2242018-02-28 16:03:25 -080031#include <iomanip>
32
Alan Stokesa25d90c2017-10-16 10:56:00 +010033#include <android-base/file.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070034#include <android-base/logging.h>
Andreas Gampe6a9cf722017-07-24 16:49:10 -070035#include <android-base/properties.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070036#include <android-base/stringprintf.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070037#include <android-base/strings.h>
38#include <android-base/unique_fd.h>
Martijn Coenen6de402a2021-04-26 16:23:40 +020039#include <async_safe/log.h>
Calin Juravle80a21252017-01-17 14:43:25 -080040#include <cutils/fs.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070041#include <cutils/properties.h>
42#include <cutils/sched_policy.h>
Mark Salyzyn7823e122016-09-29 08:08:05 -070043#include <log/log.h> // TODO: Move everything to base/logging.
Alan Stokesa25d90c2017-10-16 10:56:00 +010044#include <openssl/sha.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070045#include <private/android_filesystem_config.h>
Suren Baghdasaryan1cc5de62019-01-25 05:29:23 +000046#include <processgroup/sched_policy.h>
Calin Juravlecb556e32017-04-04 20:22:50 -070047#include <selinux/android.h>
Nicolas Geoffrayaaad21e2019-02-25 13:31:10 +000048#include <server_configurable_flags/get_flags.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070049#include <system/thread_defs.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070050
51#include "dexopt.h"
Andreas Gampefa2dadd2018-02-28 19:52:47 -080052#include "dexopt_return_codes.h"
Victor Hsiehc9821f12020-08-07 11:32:29 -070053#include "execv_helper.h"
Jeff Sharkeyc1149c92017-09-21 14:51:09 -060054#include "globals.h"
Jeff Sharkey90aff262016-12-12 14:28:24 -070055#include "installd_deps.h"
Calin Juravle3b758282021-06-08 08:04:52 -070056#include "installd_constants.h"
Jeff Sharkey90aff262016-12-12 14:28:24 -070057#include "otapreopt_utils.h"
Victor Hsiehc9821f12020-08-07 11:32:29 -070058#include "run_dex2oat.h"
Victor Hsiehcb35a062020-08-13 16:11:13 -070059#include "unique_file.h"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070060#include "utils.h"
61
Victor Hsieh76f19ba2020-08-10 14:37:26 -070062using android::base::Basename;
Jeff Sharkey90aff262016-12-12 14:28:24 -070063using android::base::EndsWith;
Mathieu Chartier9b2da082018-10-26 13:23:11 -070064using android::base::GetBoolProperty;
65using android::base::GetProperty;
David Brazdil4f6027a2019-03-19 11:44:21 +000066using android::base::ReadFdToString;
Alan Stokesa25d90c2017-10-16 10:56:00 +010067using android::base::ReadFully;
68using android::base::StringPrintf;
69using android::base::WriteFully;
Calin Juravle1a0af3b2017-03-09 14:33:33 -080070using android::base::unique_fd;
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070071
72namespace android {
73namespace installd {
74
Andreas Gampefa2dadd2018-02-28 19:52:47 -080075
Calin Juravle114f0812017-03-08 19:05:07 -080076// Deleter using free() for use with std::unique_ptr<>. See also UniqueCPtr<> below.
77struct FreeDelete {
78 // NOTE: Deleting a const object is valid but free() takes a non-const pointer.
79 void operator()(const void* ptr) const {
80 free(const_cast<void*>(ptr));
81 }
82};
83
84// Alias for std::unique_ptr<> that uses the C function free() to delete objects.
85template <typename T>
86using UniqueCPtr = std::unique_ptr<T, FreeDelete>;
87
Calin Juravle1a0af3b2017-03-09 14:33:33 -080088static unique_fd invalid_unique_fd() {
89 return unique_fd(-1);
90}
91
Andreas Gampe6a9cf722017-07-24 16:49:10 -070092static bool is_debug_runtime() {
93 return android::base::GetProperty("persist.sys.dalvik.vm.lib.2", "") == "libartd.so";
94}
95
David Sehra3b5ab62017-10-25 14:27:29 -070096static bool is_debuggable_build() {
97 return android::base::GetBoolProperty("ro.debuggable", false);
98}
99
Jeff Sharkey90aff262016-12-12 14:28:24 -0700100static bool clear_profile(const std::string& profile) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800101 unique_fd ufd(open(profile.c_str(), O_WRONLY | O_NOFOLLOW | O_CLOEXEC));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700102 if (ufd.get() < 0) {
103 if (errno != ENOENT) {
104 PLOG(WARNING) << "Could not open profile " << profile;
105 return false;
106 } else {
107 // Nothing to clear. That's ok.
108 return true;
109 }
110 }
111
112 if (flock(ufd.get(), LOCK_EX | LOCK_NB) != 0) {
113 if (errno != EWOULDBLOCK) {
114 PLOG(WARNING) << "Error locking profile " << profile;
115 }
116 // This implies that the app owning this profile is running
117 // (and has acquired the lock).
118 //
119 // If we can't acquire the lock bail out since clearing is useless anyway
120 // (the app will write again to the profile).
121 //
122 // Note:
123 // This does not impact the this is not an issue for the profiling correctness.
124 // In case this is needed because of an app upgrade, profiles will still be
125 // eventually cleared by the app itself due to checksum mismatch.
126 // If this is needed because profman advised, then keeping the data around
127 // until the next run is again not an issue.
128 //
129 // If the app attempts to acquire a lock while we've held one here,
130 // it will simply skip the current write cycle.
131 return false;
132 }
133
134 bool truncated = ftruncate(ufd.get(), 0) == 0;
135 if (!truncated) {
136 PLOG(WARNING) << "Could not truncate " << profile;
137 }
138 if (flock(ufd.get(), LOCK_UN) != 0) {
139 PLOG(WARNING) << "Error unlocking profile " << profile;
140 }
141 return truncated;
142}
143
Calin Juravle114f0812017-03-08 19:05:07 -0800144// Clear the reference profile for the given location.
Calin Juravle824a64d2018-01-18 20:23:17 -0800145// The location is the profile name for primary apks or the dex path for secondary dex files.
146static bool clear_reference_profile(const std::string& package_name, const std::string& location,
147 bool is_secondary_dex) {
148 return clear_profile(create_reference_profile_path(package_name, location, is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700149}
150
Calin Juravle114f0812017-03-08 19:05:07 -0800151// Clear the reference profile for the given location.
Calin Juravle824a64d2018-01-18 20:23:17 -0800152// The location is the profile name for primary apks or the dex path for secondary dex files.
153static bool clear_current_profile(const std::string& package_name, const std::string& location,
154 userid_t user, bool is_secondary_dex) {
155 return clear_profile(create_current_profile_path(user, package_name, location,
156 is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700157}
158
Calin Juravle114f0812017-03-08 19:05:07 -0800159// Clear the reference profile for the primary apk of the given package.
Calin Juravle824a64d2018-01-18 20:23:17 -0800160// The location is the profile name for primary apks or the dex path for secondary dex files.
161bool clear_primary_reference_profile(const std::string& package_name,
162 const std::string& location) {
163 return clear_reference_profile(package_name, location, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800164}
165
166// Clear all current profile for the primary apk of the given package.
Calin Juravle824a64d2018-01-18 20:23:17 -0800167// The location is the profile name for primary apks or the dex path for secondary dex files.
168bool clear_primary_current_profiles(const std::string& package_name, const std::string& location) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700169 bool success = true;
Calin Juravle114f0812017-03-08 19:05:07 -0800170 // For secondary dex files, we don't really need the user but we use it for sanity checks.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700171 std::vector<userid_t> users = get_known_users(/*volume_uuid*/ nullptr);
172 for (auto user : users) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800173 success &= clear_current_profile(package_name, location, user, /*is_secondary_dex*/false);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700174 }
175 return success;
176}
177
Calin Juravle114f0812017-03-08 19:05:07 -0800178// Clear the current profile for the primary apk of the given package and user.
Calin Juravle824a64d2018-01-18 20:23:17 -0800179bool clear_primary_current_profile(const std::string& package_name, const std::string& location,
180 userid_t user) {
181 return clear_current_profile(package_name, location, user, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800182}
183
Calin Juravlef74a7372019-02-28 20:29:41 -0800184// Determines which binary we should use for execution (the debug or non-debug version).
185// e.g. dex2oatd vs dex2oat
186static const char* select_execution_binary(const char* binary, const char* debug_binary,
187 bool background_job_compile) {
188 return select_execution_binary(
189 binary,
190 debug_binary,
191 background_job_compile,
192 is_debug_runtime(),
193 (android::base::GetProperty("ro.build.version.codename", "") == "REL"),
194 is_debuggable_build());
195}
196
197// Determines which binary we should use for execution (the debug or non-debug version).
198// e.g. dex2oatd vs dex2oat
199// This is convenient method which is much easier to test because it doesn't read
200// system properties.
201const char* select_execution_binary(
202 const char* binary,
203 const char* debug_binary,
204 bool background_job_compile,
205 bool is_debug_runtime,
206 bool is_release,
207 bool is_debuggable_build) {
208 // Do not use debug binaries for release candidates (to give more soak time).
209 bool is_debug_bg_job = background_job_compile && is_debuggable_build && !is_release;
210
211 // If the runtime was requested to use libartd.so, we'll run the debug version - assuming
212 // the file is present (it may not be on images with very little space available).
213 bool useDebug = (is_debug_runtime || is_debug_bg_job) && (access(debug_binary, X_OK) == 0);
214
215 return useDebug ? debug_binary : binary;
216}
217
Nicolas Geoffrayaaad21e2019-02-25 13:31:10 +0000218// Namespace for Android Runtime flags applied during boot time.
219static const char* RUNTIME_NATIVE_BOOT_NAMESPACE = "runtime_native_boot";
220// Feature flag name for running the JIT in Zygote experiment, b/119800099.
Nicolas Geoffray5a4c4e92020-02-07 11:37:34 +0000221static const char* ENABLE_JITZYGOTE_IMAGE = "enable_apex_image";
Nicolas Geoffrayaaad21e2019-02-25 13:31:10 +0000222
Mathieu Chartiere97261e2019-10-01 15:36:01 -0700223// Phenotype property name for enabling profiling the boot class path.
224static const char* PROFILE_BOOT_CLASS_PATH = "profilebootclasspath";
225
Calin Juravlef85ddb92020-05-01 14:05:40 -0700226static bool IsBootClassPathProfilingEnable() {
227 std::string profile_boot_class_path = GetProperty("dalvik.vm.profilebootclasspath", "");
228 profile_boot_class_path =
229 server_configurable_flags::GetServerConfigurableFlag(
230 RUNTIME_NATIVE_BOOT_NAMESPACE,
231 PROFILE_BOOT_CLASS_PATH,
232 /*default_value=*/ profile_boot_class_path);
233 return profile_boot_class_path == "true";
234}
235
Victor Hsiehcb35a062020-08-13 16:11:13 -0700236static void UnlinkIgnoreResult(const std::string& path) {
237 if (unlink(path.c_str()) < 0) {
238 PLOG(ERROR) << "Failed to unlink " << path;
239 }
240}
241
Jeff Sharkey90aff262016-12-12 14:28:24 -0700242/*
243 * Whether dexopt should use a swap file when compiling an APK.
244 *
245 * If kAlwaysProvideSwapFile, do this on all devices (dex2oat will make a more informed decision
246 * itself, anyways).
247 *
248 * Otherwise, read "dalvik.vm.dex2oat-swap". If the property exists, return whether it is "true".
249 *
250 * Otherwise, return true if this is a low-mem device.
251 *
252 * Otherwise, return default value.
253 */
254static bool kAlwaysProvideSwapFile = false;
255static bool kDefaultProvideSwapFile = true;
256
257static bool ShouldUseSwapFileForDexopt() {
258 if (kAlwaysProvideSwapFile) {
259 return true;
260 }
261
262 // Check the "override" property. If it exists, return value == "true".
Mathieu Chartier9b2da082018-10-26 13:23:11 -0700263 std::string dex2oat_prop_buf = GetProperty("dalvik.vm.dex2oat-swap", "");
264 if (!dex2oat_prop_buf.empty()) {
265 return dex2oat_prop_buf == "true";
Jeff Sharkey90aff262016-12-12 14:28:24 -0700266 }
267
268 // Shortcut for default value. This is an implementation optimization for the process sketched
269 // above. If the default value is true, we can avoid to check whether this is a low-mem device,
270 // as low-mem is never returning false. The compiler will optimize this away if it can.
271 if (kDefaultProvideSwapFile) {
272 return true;
273 }
274
Mathieu Chartier9b2da082018-10-26 13:23:11 -0700275 if (GetBoolProperty("ro.config.low_ram", false)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700276 return true;
277 }
278
279 // Default value must be false here.
280 return kDefaultProvideSwapFile;
281}
282
Richard Uhler76cc0272016-12-08 10:46:35 +0000283static void SetDex2OatScheduling(bool set_to_bg) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700284 if (set_to_bg) {
285 if (set_sched_policy(0, SP_BACKGROUND) < 0) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800286 PLOG(ERROR) << "set_sched_policy failed";
287 exit(DexoptReturnCodes::kSetSchedPolicy);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700288 }
289 if (setpriority(PRIO_PROCESS, 0, ANDROID_PRIORITY_BACKGROUND) < 0) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800290 PLOG(ERROR) << "setpriority failed";
291 exit(DexoptReturnCodes::kSetPriority);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700292 }
293 }
294}
295
Calin Juravlee01f8712021-06-03 18:16:54 -0700296static unique_fd create_profile(uid_t uid, const std::string& profile, int32_t flags, mode_t mode) {
297 unique_fd fd(TEMP_FAILURE_RETRY(open(profile.c_str(), flags, mode)));
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800298 if (fd.get() < 0) {
Calin Juravle29591732017-11-20 17:46:19 -0800299 if (errno != EEXIST) {
Calin Juravle114f0812017-03-08 19:05:07 -0800300 PLOG(ERROR) << "Failed to create profile " << profile;
Calin Juravle29591732017-11-20 17:46:19 -0800301 return invalid_unique_fd();
Calin Juravle114f0812017-03-08 19:05:07 -0800302 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700303 }
Calin Juravle114f0812017-03-08 19:05:07 -0800304 // Profiles should belong to the app; make sure of that by giving ownership to
305 // the app uid. If we cannot do that, there's no point in returning the fd
306 // since dex2oat/profman will fail with SElinux denials.
307 if (fchown(fd.get(), uid, uid) < 0) {
Roland Levillain019db5b2019-03-14 14:31:59 +0000308 PLOG(ERROR) << "Could not chown profile " << profile;
Calin Juravle29591732017-11-20 17:46:19 -0800309 return invalid_unique_fd();
Calin Juravle114f0812017-03-08 19:05:07 -0800310 }
Calin Juravle29591732017-11-20 17:46:19 -0800311 return fd;
Calin Juravle114f0812017-03-08 19:05:07 -0800312}
313
Calin Juravlee01f8712021-06-03 18:16:54 -0700314static unique_fd open_profile(uid_t uid, const std::string& profile, int32_t flags, mode_t mode) {
Calin Juravle114f0812017-03-08 19:05:07 -0800315 // Do not follow symlinks when opening a profile:
316 // - primary profiles should not contain symlinks in their paths
317 // - secondary dex paths should have been already resolved and validated
318 flags |= O_NOFOLLOW;
319
Calin Juravle29591732017-11-20 17:46:19 -0800320 // Check if we need to create the profile
321 // Reference profiles and snapshots are created on the fly; so they might not exist beforehand.
322 unique_fd fd;
323 if ((flags & O_CREAT) != 0) {
Calin Juravlee01f8712021-06-03 18:16:54 -0700324 fd = create_profile(uid, profile, flags, mode);
Calin Juravle29591732017-11-20 17:46:19 -0800325 } else {
326 fd.reset(TEMP_FAILURE_RETRY(open(profile.c_str(), flags)));
327 }
328
Calin Juravle114f0812017-03-08 19:05:07 -0800329 if (fd.get() < 0) {
330 if (errno != ENOENT) {
331 // Profiles might be missing for various reasons. For example, in a
332 // multi-user environment, the profile directory for one user can be created
333 // after we start a merge. In this case the current profile for that user
334 // will not be found.
335 // Also, the secondary dex profiles might be deleted by the app at any time,
336 // so we can't we need to prepare if they are missing.
337 PLOG(ERROR) << "Failed to open profile " << profile;
338 }
339 return invalid_unique_fd();
Calin Juravlee01f8712021-06-03 18:16:54 -0700340 } else {
341 // If we just create the file we need to set its mode because on Android
342 // open has a mask that only allows owner access.
343 if ((flags & O_CREAT) != 0) {
344 if (fchmod(fd.get(), mode) != 0) {
345 PLOG(ERROR) << "Could not set mode " << std::hex << mode << std::dec
346 << " on profile" << profile;
347 // Not a terminal failure.
348 }
349 }
Calin Juravle114f0812017-03-08 19:05:07 -0800350 }
351
Jeff Sharkey90aff262016-12-12 14:28:24 -0700352 return fd;
353}
354
Calin Juravle824a64d2018-01-18 20:23:17 -0800355static unique_fd open_current_profile(uid_t uid, userid_t user, const std::string& package_name,
356 const std::string& location, bool is_secondary_dex) {
357 std::string profile = create_current_profile_path(user, package_name, location,
358 is_secondary_dex);
Calin Juravlee01f8712021-06-03 18:16:54 -0700359 return open_profile(uid, profile, O_RDONLY, /*mode=*/ 0);
Calin Juravle114f0812017-03-08 19:05:07 -0800360}
361
Calin Juravle824a64d2018-01-18 20:23:17 -0800362static unique_fd open_reference_profile(uid_t uid, const std::string& package_name,
363 const std::string& location, bool read_write, bool is_secondary_dex) {
364 std::string profile = create_reference_profile_path(package_name, location, is_secondary_dex);
Calin Juravlee01f8712021-06-03 18:16:54 -0700365 return open_profile(
366 uid,
367 profile,
368 read_write ? (O_CREAT | O_RDWR) : O_RDONLY,
369 S_IRUSR | S_IWUSR | S_IRGRP); // so that ART can also read it when apps run.
Calin Juravle29591732017-11-20 17:46:19 -0800370}
371
Victor Hsiehcb35a062020-08-13 16:11:13 -0700372static UniqueFile open_reference_profile_as_unique_file(uid_t uid, const std::string& package_name,
373 const std::string& location, bool read_write, bool is_secondary_dex) {
374 std::string profile_path = create_reference_profile_path(package_name, location,
375 is_secondary_dex);
Calin Juravlee01f8712021-06-03 18:16:54 -0700376 unique_fd ufd = open_profile(
377 uid,
378 profile_path,
379 read_write ? (O_CREAT | O_RDWR) : O_RDONLY,
380 S_IRUSR | S_IWUSR | S_IRGRP); // so that ART can also read it when apps run.
381
Victor Hsiehcb35a062020-08-13 16:11:13 -0700382 return UniqueFile(ufd.release(), profile_path, [](const std::string& path) {
383 clear_profile(path);
384 });
385}
386
Calin Juravle29591732017-11-20 17:46:19 -0800387static unique_fd open_spnashot_profile(uid_t uid, const std::string& package_name,
Calin Juravle824a64d2018-01-18 20:23:17 -0800388 const std::string& location) {
389 std::string profile = create_snapshot_profile_path(package_name, location);
Calin Juravlee01f8712021-06-03 18:16:54 -0700390 return open_profile(uid, profile, O_CREAT | O_RDWR | O_TRUNC, S_IRUSR | S_IWUSR);
Calin Juravle114f0812017-03-08 19:05:07 -0800391}
392
Calin Juravle824a64d2018-01-18 20:23:17 -0800393static void open_profile_files(uid_t uid, const std::string& package_name,
394 const std::string& location, bool is_secondary_dex,
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800395 /*out*/ std::vector<unique_fd>* profiles_fd, /*out*/ unique_fd* reference_profile_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700396 // Open the reference profile in read-write mode as profman might need to save the merge.
Calin Juravle824a64d2018-01-18 20:23:17 -0800397 *reference_profile_fd = open_reference_profile(uid, package_name, location,
398 /*read_write*/ true, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700399
Calin Juravle114f0812017-03-08 19:05:07 -0800400 // For secondary dex files, we don't really need the user but we use it for sanity checks.
401 // Note: the user owning the dex file should be the current user.
402 std::vector<userid_t> users;
403 if (is_secondary_dex){
404 users.push_back(multiuser_get_user_id(uid));
405 } else {
406 users = get_known_users(/*volume_uuid*/ nullptr);
407 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700408 for (auto user : users) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800409 unique_fd profile_fd = open_current_profile(uid, user, package_name, location,
410 is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700411 // Add to the lists only if both fds are valid.
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800412 if (profile_fd.get() >= 0) {
413 profiles_fd->push_back(std::move(profile_fd));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700414 }
415 }
416}
417
Calin Juravle76561322019-11-14 09:08:52 -0800418static constexpr int PROFMAN_BIN_RETURN_CODE_SUCCESS = 0;
419static constexpr int PROFMAN_BIN_RETURN_CODE_COMPILE = 1;
Calin Juravle3b758282021-06-08 08:04:52 -0700420static constexpr int PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION_NOT_ENOUGH_DELTA = 2;
Calin Juravle76561322019-11-14 09:08:52 -0800421static constexpr int PROFMAN_BIN_RETURN_CODE_BAD_PROFILES = 3;
422static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_IO = 4;
423static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING = 5;
424static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_DIFFERENT_VERSIONS = 6;
Calin Juravle3b758282021-06-08 08:04:52 -0700425static constexpr int PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION_EMPTY_PROFILES = 7;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700426
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800427class RunProfman : public ExecVHelper {
428 public:
429 void SetupArgs(const std::vector<unique_fd>& profile_fds,
430 const unique_fd& reference_profile_fd,
431 const std::vector<unique_fd>& apk_fds,
432 const std::vector<std::string>& dex_locations,
Calin Juravle78728f32019-11-08 17:55:46 -0800433 bool copy_and_update,
434 bool for_snapshot,
435 bool for_boot_image) {
Calin Juravlef74a7372019-02-28 20:29:41 -0800436
437 // TODO(calin): Assume for now we run in the bg compile job (which is in
438 // most of the invocation). With the current data flow, is not very easy or
439 // clean to discover this in RunProfman (it will require quite a messy refactoring).
440 const char* profman_bin = select_execution_binary(
441 kProfmanPath, kProfmanDebugPath, /*background_job_compile=*/ true);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700442
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800443 if (copy_and_update) {
444 CHECK_EQ(1u, profile_fds.size());
445 CHECK_EQ(1u, apk_fds.size());
Mathieu Chartier31636522018-11-09 23:53:07 +0000446 }
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800447 if (reference_profile_fd != -1) {
448 AddArg("--reference-profile-file-fd=" + std::to_string(reference_profile_fd.get()));
Mathieu Chartier31636522018-11-09 23:53:07 +0000449 }
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800450
451 for (const unique_fd& fd : profile_fds) {
452 AddArg("--profile-file-fd=" + std::to_string(fd.get()));
453 }
454
455 for (const unique_fd& fd : apk_fds) {
456 AddArg("--apk-fd=" + std::to_string(fd.get()));
457 }
458
459 for (const std::string& dex_location : dex_locations) {
460 AddArg("--dex-location=" + dex_location);
461 }
462
463 if (copy_and_update) {
464 AddArg("--copy-and-update-profile-key");
465 }
466
Calin Juravle78728f32019-11-08 17:55:46 -0800467 if (for_snapshot) {
468 AddArg("--force-merge");
469 }
470
471 if (for_boot_image) {
472 AddArg("--boot-image-merge");
473 }
474
yawannga27559e2020-11-13 19:17:44 +0000475 // The percent won't exceed 100, otherwise, don't set it and use the
476 // default one set in profman.
yawanng6fe34a52020-11-06 05:13:53 +0000477 uint32_t min_new_classes_percent_change = ::android::base::GetUintProperty<uint32_t>(
yawannga27559e2020-11-13 19:17:44 +0000478 "dalvik.vm.bgdexopt.new-classes-percent",
479 /*default*/std::numeric_limits<uint32_t>::max());
480 if (min_new_classes_percent_change <= 100) {
yawanng6fe34a52020-11-06 05:13:53 +0000481 AddArg("--min-new-classes-percent-change=" +
482 std::to_string(min_new_classes_percent_change));
483 }
484
yawannga27559e2020-11-13 19:17:44 +0000485 // The percent won't exceed 100, otherwise, don't set it and use the
486 // default one set in profman.
yawanng6fe34a52020-11-06 05:13:53 +0000487 uint32_t min_new_methods_percent_change = ::android::base::GetUintProperty<uint32_t>(
yawannga27559e2020-11-13 19:17:44 +0000488 "dalvik.vm.bgdexopt.new-methods-percent",
489 /*default*/std::numeric_limits<uint32_t>::max());
490 if (min_new_methods_percent_change <= 100) {
yawanng6fe34a52020-11-06 05:13:53 +0000491 AddArg("--min-new-methods-percent-change=" +
492 std::to_string(min_new_methods_percent_change));
493 }
494
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800495 // Do not add after dex2oat_flags, they should override others for debugging.
496 PrepareArgs(profman_bin);
Mathieu Chartier62d218d2018-11-05 09:34:24 -0800497 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700498
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800499 void SetupMerge(const std::vector<unique_fd>& profiles_fd,
500 const unique_fd& reference_profile_fd,
501 const std::vector<unique_fd>& apk_fds = std::vector<unique_fd>(),
Calin Juravle78728f32019-11-08 17:55:46 -0800502 const std::vector<std::string>& dex_locations = std::vector<std::string>(),
503 bool for_snapshot = false,
504 bool for_boot_image = false) {
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800505 SetupArgs(profiles_fd,
Calin Juravleb3a929d2018-12-11 14:40:00 -0800506 reference_profile_fd,
507 apk_fds,
508 dex_locations,
Calin Juravle78728f32019-11-08 17:55:46 -0800509 /*copy_and_update=*/ false,
510 for_snapshot,
511 for_boot_image);
Mathieu Chartier62d218d2018-11-05 09:34:24 -0800512 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700513
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800514 void SetupCopyAndUpdate(unique_fd&& profile_fd,
515 unique_fd&& reference_profile_fd,
516 unique_fd&& apk_fd,
517 const std::string& dex_location) {
518 // The fds need to stay open longer than the scope of the function, so put them into a local
519 // variable vector.
520 profiles_fd_.push_back(std::move(profile_fd));
521 apk_fds_.push_back(std::move(apk_fd));
522 reference_profile_fd_ = std::move(reference_profile_fd);
523 std::vector<std::string> dex_locations = {dex_location};
Calin Juravleb3a929d2018-12-11 14:40:00 -0800524 SetupArgs(profiles_fd_,
525 reference_profile_fd_,
526 apk_fds_,
527 dex_locations,
Calin Juravle78728f32019-11-08 17:55:46 -0800528 /*copy_and_update=*/true,
529 /*for_snapshot*/false,
530 /*for_boot_image*/false);
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800531 }
Calin Juravlef63d4792018-01-30 17:43:34 +0000532
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800533 void SetupDump(const std::vector<unique_fd>& profiles_fd,
534 const unique_fd& reference_profile_fd,
535 const std::vector<std::string>& dex_locations,
536 const std::vector<unique_fd>& apk_fds,
537 const unique_fd& output_fd) {
538 AddArg("--dump-only");
539 AddArg(StringPrintf("--dump-output-to-fd=%d", output_fd.get()));
Calin Juravleb3a929d2018-12-11 14:40:00 -0800540 SetupArgs(profiles_fd,
541 reference_profile_fd,
542 apk_fds,
543 dex_locations,
Calin Juravle78728f32019-11-08 17:55:46 -0800544 /*copy_and_update=*/false,
545 /*for_snapshot*/false,
546 /*for_boot_image*/false);
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800547 }
Calin Juravlef63d4792018-01-30 17:43:34 +0000548
Victor Hsiehc9821f12020-08-07 11:32:29 -0700549 using ExecVHelper::Exec; // To suppress -Wno-overloaded-virtual
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800550 void Exec() {
551 ExecVHelper::Exec(DexoptReturnCodes::kProfmanExec);
552 }
Mathieu Chartier31636522018-11-09 23:53:07 +0000553
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800554 private:
555 unique_fd reference_profile_fd_;
556 std::vector<unique_fd> profiles_fd_;
557 std::vector<unique_fd> apk_fds_;
558};
Mathieu Chartier31636522018-11-09 23:53:07 +0000559
Calin Juravle3b758282021-06-08 08:04:52 -0700560static int analyze_profiles(uid_t uid, const std::string& package_name,
Calin Juravle824a64d2018-01-18 20:23:17 -0800561 const std::string& location, bool is_secondary_dex) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800562 std::vector<unique_fd> profiles_fd;
563 unique_fd reference_profile_fd;
Calin Juravle824a64d2018-01-18 20:23:17 -0800564 open_profile_files(uid, package_name, location, is_secondary_dex,
565 &profiles_fd, &reference_profile_fd);
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800566 if (profiles_fd.empty() || (reference_profile_fd.get() < 0)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700567 // Skip profile guided compilation because no profiles were found.
568 // Or if the reference profile info couldn't be opened.
Calin Juravle3b758282021-06-08 08:04:52 -0700569 return PROFILES_ANALYSIS_DONT_OPTIMIZE_EMPTY_PROFILES;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700570 }
571
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800572 RunProfman profman_merge;
Calin Juravlef85ddb92020-05-01 14:05:40 -0700573 const std::vector<unique_fd>& apk_fds = std::vector<unique_fd>();
574 const std::vector<std::string>& dex_locations = std::vector<std::string>();
575 profman_merge.SetupMerge(
576 profiles_fd,
577 reference_profile_fd,
578 apk_fds,
579 dex_locations,
580 /* for_snapshot= */ false,
581 IsBootClassPathProfilingEnable());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700582 pid_t pid = fork();
583 if (pid == 0) {
584 /* child -- drop privileges before continuing */
585 drop_capabilities(uid);
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800586 profman_merge.Exec();
Jeff Sharkey90aff262016-12-12 14:28:24 -0700587 }
588 /* parent */
589 int return_code = wait_child(pid);
590 bool need_to_compile = false;
Calin Juravle3b758282021-06-08 08:04:52 -0700591 bool empty_profiles = false;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700592 bool should_clear_current_profiles = false;
593 bool should_clear_reference_profile = false;
594 if (!WIFEXITED(return_code)) {
Calin Juravle114f0812017-03-08 19:05:07 -0800595 LOG(WARNING) << "profman failed for location " << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700596 } else {
597 return_code = WEXITSTATUS(return_code);
598 switch (return_code) {
599 case PROFMAN_BIN_RETURN_CODE_COMPILE:
600 need_to_compile = true;
601 should_clear_current_profiles = true;
602 should_clear_reference_profile = false;
603 break;
Calin Juravle3b758282021-06-08 08:04:52 -0700604 case PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION_NOT_ENOUGH_DELTA:
Jeff Sharkey90aff262016-12-12 14:28:24 -0700605 need_to_compile = false;
606 should_clear_current_profiles = false;
607 should_clear_reference_profile = false;
608 break;
Calin Juravle3b758282021-06-08 08:04:52 -0700609 case PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION_EMPTY_PROFILES:
610 need_to_compile = false;
611 empty_profiles = true;
612 should_clear_current_profiles = false;
613 should_clear_reference_profile = false;
614 break;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700615 case PROFMAN_BIN_RETURN_CODE_BAD_PROFILES:
Calin Juravle114f0812017-03-08 19:05:07 -0800616 LOG(WARNING) << "Bad profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700617 need_to_compile = false;
618 should_clear_current_profiles = true;
619 should_clear_reference_profile = true;
620 break;
621 case PROFMAN_BIN_RETURN_CODE_ERROR_IO: // fall-through
622 case PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING:
623 // Temporary IO problem (e.g. locking). Ignore but log a warning.
Calin Juravle114f0812017-03-08 19:05:07 -0800624 LOG(WARNING) << "IO error while reading profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700625 need_to_compile = false;
626 should_clear_current_profiles = false;
627 should_clear_reference_profile = false;
628 break;
Calin Juravle76561322019-11-14 09:08:52 -0800629 case PROFMAN_BIN_RETURN_CODE_ERROR_DIFFERENT_VERSIONS:
630 need_to_compile = false;
631 should_clear_current_profiles = true;
632 should_clear_reference_profile = true;
633 break;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700634 default:
635 // Unknown return code or error. Unlink profiles.
Calin Juravle78728f32019-11-08 17:55:46 -0800636 LOG(WARNING) << "Unexpected error code while processing profiles for location "
Calin Juravle114f0812017-03-08 19:05:07 -0800637 << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700638 need_to_compile = false;
639 should_clear_current_profiles = true;
640 should_clear_reference_profile = true;
641 break;
642 }
643 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800644
Jeff Sharkey90aff262016-12-12 14:28:24 -0700645 if (should_clear_current_profiles) {
Calin Juravle114f0812017-03-08 19:05:07 -0800646 if (is_secondary_dex) {
647 // For secondary dex files, the owning user is the current user.
Calin Juravle824a64d2018-01-18 20:23:17 -0800648 clear_current_profile(package_name, location, multiuser_get_user_id(uid),
649 is_secondary_dex);
Calin Juravle114f0812017-03-08 19:05:07 -0800650 } else {
Calin Juravle824a64d2018-01-18 20:23:17 -0800651 clear_primary_current_profiles(package_name, location);
Calin Juravle114f0812017-03-08 19:05:07 -0800652 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700653 }
654 if (should_clear_reference_profile) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800655 clear_reference_profile(package_name, location, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700656 }
Calin Juravle3b758282021-06-08 08:04:52 -0700657 int result = 0;
658 if (need_to_compile) {
659 result = PROFILES_ANALYSIS_OPTIMIZE;
660 } else if (empty_profiles) {
661 result = PROFILES_ANALYSIS_DONT_OPTIMIZE_EMPTY_PROFILES;
662 } else {
663 result = PROFILES_ANALYSIS_DONT_OPTIMIZE_SMALL_DELTA;
664 }
665 return result;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700666}
667
Calin Juravle114f0812017-03-08 19:05:07 -0800668// Decides if profile guided compilation is needed or not based on existing profiles.
Calin Juravle3b758282021-06-08 08:04:52 -0700669// The analysis is done for a single profile name (which corresponds to a single code path).
670//
671// Returns PROFILES_ANALYSIS_OPTIMIZE if there is enough information in the current profiles
672// that makes it worth to recompile the package.
673// If the return value is PROFILES_ANALYSIS_OPTIMIZE all the current profiles would have been
674// merged into the reference profiles accessible with open_reference_profile().
675//
676// Return PROFILES_ANALYSIS_DONT_OPTIMIZE_SMALL_DELTA if the package should not optimize.
677// As a special case returns PROFILES_ANALYSIS_DONT_OPTIMIZE_EMPTY_PROFILES if all profiles are
678// empty.
679int analyze_primary_profiles(uid_t uid, const std::string& package_name,
Calin Juravle824a64d2018-01-18 20:23:17 -0800680 const std::string& profile_name) {
681 return analyze_profiles(uid, package_name, profile_name, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800682}
683
Calin Juravle408cd4a2018-01-20 23:34:18 -0800684bool dump_profiles(int32_t uid, const std::string& pkgname, const std::string& profile_name,
685 const std::string& code_path) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800686 std::vector<unique_fd> profile_fds;
687 unique_fd reference_profile_fd;
Calin Juravle408cd4a2018-01-20 23:34:18 -0800688 std::string out_file_name = StringPrintf("/data/misc/profman/%s-%s.txt",
689 pkgname.c_str(), profile_name.c_str());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700690
Calin Juravle408cd4a2018-01-20 23:34:18 -0800691 open_profile_files(uid, pkgname, profile_name, /*is_secondary_dex*/false,
Calin Juravle114f0812017-03-08 19:05:07 -0800692 &profile_fds, &reference_profile_fd);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700693
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800694 const bool has_reference_profile = (reference_profile_fd.get() != -1);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700695 const bool has_profiles = !profile_fds.empty();
696
697 if (!has_reference_profile && !has_profiles) {
Calin Juravle76268c52017-03-09 13:19:42 -0800698 LOG(ERROR) << "profman dump: no profiles to dump for " << pkgname;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700699 return false;
700 }
701
Calin Juravle114f0812017-03-08 19:05:07 -0800702 unique_fd output_fd(open(out_file_name.c_str(),
703 O_WRONLY | O_CREAT | O_TRUNC | O_NOFOLLOW, 0644));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700704 if (fchmod(output_fd, S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH) < 0) {
Calin Juravle408cd4a2018-01-20 23:34:18 -0800705 LOG(ERROR) << "installd cannot chmod file for dump_profile" << out_file_name;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700706 return false;
707 }
Calin Juravle408cd4a2018-01-20 23:34:18 -0800708
Jeff Sharkey90aff262016-12-12 14:28:24 -0700709 std::vector<std::string> dex_locations;
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800710 std::vector<unique_fd> apk_fds;
Calin Juravle408cd4a2018-01-20 23:34:18 -0800711 unique_fd apk_fd(open(code_path.c_str(), O_RDONLY | O_NOFOLLOW));
712 if (apk_fd == -1) {
713 PLOG(ERROR) << "installd cannot open " << code_path.c_str();
714 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700715 }
Victor Hsieh76f19ba2020-08-10 14:37:26 -0700716 dex_locations.push_back(Basename(code_path));
Calin Juravle408cd4a2018-01-20 23:34:18 -0800717 apk_fds.push_back(std::move(apk_fd));
718
Jeff Sharkey90aff262016-12-12 14:28:24 -0700719
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800720 RunProfman profman_dump;
721 profman_dump.SetupDump(profile_fds, reference_profile_fd, dex_locations, apk_fds, output_fd);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700722 pid_t pid = fork();
723 if (pid == 0) {
724 /* child -- drop privileges before continuing */
725 drop_capabilities(uid);
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800726 profman_dump.Exec();
Jeff Sharkey90aff262016-12-12 14:28:24 -0700727 }
728 /* parent */
Jeff Sharkey90aff262016-12-12 14:28:24 -0700729 int return_code = wait_child(pid);
730 if (!WIFEXITED(return_code)) {
731 LOG(WARNING) << "profman failed for package " << pkgname << ": "
732 << return_code;
733 return false;
734 }
735 return true;
736}
737
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700738bool copy_system_profile(const std::string& system_profile,
Calin Juravle824a64d2018-01-18 20:23:17 -0800739 uid_t packageUid, const std::string& package_name, const std::string& profile_name) {
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700740 unique_fd in_fd(open(system_profile.c_str(), O_RDONLY | O_NOFOLLOW | O_CLOEXEC));
741 unique_fd out_fd(open_reference_profile(packageUid,
Calin Juravle824a64d2018-01-18 20:23:17 -0800742 package_name,
743 profile_name,
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700744 /*read_write*/ true,
745 /*secondary*/ false));
746 if (in_fd.get() < 0) {
747 PLOG(WARNING) << "Could not open profile " << system_profile;
748 return false;
749 }
750 if (out_fd.get() < 0) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800751 PLOG(WARNING) << "Could not open profile " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700752 return false;
753 }
754
Mathieu Chartier78f71fe2017-06-14 13:02:26 -0700755 // As a security measure we want to write the profile information with the reduced capabilities
756 // of the package user id. So we fork and drop capabilities in the child.
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700757 pid_t pid = fork();
758 if (pid == 0) {
759 /* child -- drop privileges before continuing */
760 drop_capabilities(packageUid);
761
762 if (flock(out_fd.get(), LOCK_EX | LOCK_NB) != 0) {
763 if (errno != EWOULDBLOCK) {
Martijn Coenen6de402a2021-04-26 16:23:40 +0200764 async_safe_format_log(ANDROID_LOG_WARN, LOG_TAG, "Error locking profile %s: %d",
765 package_name.c_str(), errno);
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700766 }
767 // This implies that the app owning this profile is running
768 // (and has acquired the lock).
769 //
770 // The app never acquires the lock for the reference profiles of primary apks.
771 // Only dex2oat from installd will do that. Since installd is single threaded
772 // we should not see this case. Nevertheless be prepared for it.
Martijn Coenen6de402a2021-04-26 16:23:40 +0200773 async_safe_format_log(ANDROID_LOG_WARN, LOG_TAG, "Failed to flock %s: %d",
774 package_name.c_str(), errno);
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700775 return false;
776 }
777
778 bool truncated = ftruncate(out_fd.get(), 0) == 0;
779 if (!truncated) {
Martijn Coenen6de402a2021-04-26 16:23:40 +0200780 async_safe_format_log(ANDROID_LOG_WARN, LOG_TAG, "Could not truncate %s: %d",
781 package_name.c_str(), errno);
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700782 }
783
784 // Copy over data.
785 static constexpr size_t kBufferSize = 4 * 1024;
786 char buffer[kBufferSize];
787 while (true) {
788 ssize_t bytes = read(in_fd.get(), buffer, kBufferSize);
789 if (bytes == 0) {
790 break;
791 }
792 write(out_fd.get(), buffer, bytes);
793 }
794 if (flock(out_fd.get(), LOCK_UN) != 0) {
Martijn Coenen6de402a2021-04-26 16:23:40 +0200795 async_safe_format_log(ANDROID_LOG_WARN, LOG_TAG, "Error unlocking profile %s: %d",
796 package_name.c_str(), errno);
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700797 }
Mathieu Chartier78f71fe2017-06-14 13:02:26 -0700798 // Use _exit since we don't want to run the global destructors in the child.
799 // b/62597429
800 _exit(0);
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700801 }
802 /* parent */
803 int return_code = wait_child(pid);
804 return return_code == 0;
805}
806
Jeff Sharkey90aff262016-12-12 14:28:24 -0700807static std::string replace_file_extension(const std::string& oat_path, const std::string& new_ext) {
808 // A standard dalvik-cache entry. Replace ".dex" with `new_ext`.
809 if (EndsWith(oat_path, ".dex")) {
810 std::string new_path = oat_path;
811 new_path.replace(new_path.length() - strlen(".dex"), strlen(".dex"), new_ext);
Elliott Hughes969e4f82017-12-20 12:34:09 -0800812 CHECK(EndsWith(new_path, new_ext));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700813 return new_path;
814 }
815
816 // An odex entry. Not that this may not be an extension, e.g., in the OTA
817 // case (where the base name will have an extension for the B artifact).
818 size_t odex_pos = oat_path.rfind(".odex");
819 if (odex_pos != std::string::npos) {
820 std::string new_path = oat_path;
821 new_path.replace(odex_pos, strlen(".odex"), new_ext);
822 CHECK_NE(new_path.find(new_ext), std::string::npos);
823 return new_path;
824 }
825
826 // Don't know how to handle this.
827 return "";
828}
829
830// Translate the given oat path to an art (app image) path. An empty string
831// denotes an error.
832static std::string create_image_filename(const std::string& oat_path) {
833 return replace_file_extension(oat_path, ".art");
834}
835
836// Translate the given oat path to a vdex path. An empty string denotes an error.
837static std::string create_vdex_filename(const std::string& oat_path) {
838 return replace_file_extension(oat_path, ".vdex");
839}
840
Jeff Sharkey90aff262016-12-12 14:28:24 -0700841static int open_output_file(const char* file_name, bool recreate, int permissions) {
842 int flags = O_RDWR | O_CREAT;
843 if (recreate) {
844 if (unlink(file_name) < 0) {
845 if (errno != ENOENT) {
846 PLOG(ERROR) << "open_output_file: Couldn't unlink " << file_name;
847 }
848 }
849 flags |= O_EXCL;
850 }
851 return open(file_name, flags, permissions);
852}
853
Calin Juravle2289c0a2017-02-15 12:44:14 -0800854static bool set_permissions_and_ownership(
855 int fd, bool is_public, int uid, const char* path, bool is_secondary_dex) {
856 // Primary apks are owned by the system. Secondary dex files are owned by the app.
857 int owning_uid = is_secondary_dex ? uid : AID_SYSTEM;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700858 if (fchmod(fd,
859 S_IRUSR|S_IWUSR|S_IRGRP |
860 (is_public ? S_IROTH : 0)) < 0) {
861 ALOGE("installd cannot chmod '%s' during dexopt\n", path);
862 return false;
Calin Juravle2289c0a2017-02-15 12:44:14 -0800863 } else if (fchown(fd, owning_uid, uid) < 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700864 ALOGE("installd cannot chown '%s' during dexopt\n", path);
865 return false;
866 }
867 return true;
868}
869
870static bool IsOutputDalvikCache(const char* oat_dir) {
871 // InstallerConnection.java (which invokes installd) transforms Java null arguments
872 // into '!'. Play it safe by handling it both.
873 // TODO: ensure we never get null.
874 // TODO: pass a flag instead of inferring if the output is dalvik cache.
875 return oat_dir == nullptr || oat_dir[0] == '!';
876}
877
Calin Juravled23dee72017-07-06 16:29:11 -0700878// Best-effort check whether we can fit the the path into our buffers.
879// Note: the cache path will require an additional 5 bytes for ".swap", but we'll try to run
880// without a swap file, if necessary. Reference profiles file also add an extra ".prof"
881// extension to the cache path (5 bytes).
882// TODO(calin): move away from char* buffers and PKG_PATH_MAX.
883static bool validate_dex_path_size(const std::string& dex_path) {
884 if (dex_path.size() >= (PKG_PATH_MAX - 8)) {
885 LOG(ERROR) << "dex_path too long: " << dex_path;
886 return false;
887 }
888 return true;
889}
890
Jeff Sharkey90aff262016-12-12 14:28:24 -0700891static bool create_oat_out_path(const char* apk_path, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -0800892 const char* oat_dir, bool is_secondary_dex, /*out*/ char* out_oat_path) {
Calin Juravled23dee72017-07-06 16:29:11 -0700893 if (!validate_dex_path_size(apk_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700894 return false;
895 }
896
897 if (!IsOutputDalvikCache(oat_dir)) {
Calin Juravle80a21252017-01-17 14:43:25 -0800898 // Oat dirs for secondary dex files are already validated.
899 if (!is_secondary_dex && validate_apk_path(oat_dir)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700900 ALOGE("cannot validate apk path with oat_dir '%s'\n", oat_dir);
901 return false;
902 }
903 if (!calculate_oat_file_path(out_oat_path, oat_dir, apk_path, instruction_set)) {
904 return false;
905 }
906 } else {
907 if (!create_cache_path(out_oat_path, apk_path, instruction_set)) {
908 return false;
909 }
910 }
911 return true;
912}
913
Calin Juravle7a570e82017-01-14 16:23:30 -0800914// (re)Creates the app image if needed.
Victor Hsiehcb35a062020-08-13 16:11:13 -0700915UniqueFile maybe_open_app_image(const std::string& out_oat_path,
Mathieu Chartier1dc3dfa2018-03-12 17:55:06 -0700916 bool generate_app_image, bool is_public, int uid, bool is_secondary_dex) {
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +0100917
Calin Juravle7a570e82017-01-14 16:23:30 -0800918 const std::string image_path = create_image_filename(out_oat_path);
919 if (image_path.empty()) {
920 // Happens when the out_oat_path has an unknown extension.
Victor Hsiehcb35a062020-08-13 16:11:13 -0700921 return UniqueFile();
Calin Juravle7a570e82017-01-14 16:23:30 -0800922 }
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +0100923
Mathieu Chartier1dc3dfa2018-03-12 17:55:06 -0700924 // In case there is a stale image, remove it now. Ignore any error.
925 unlink(image_path.c_str());
926
927 // Not enabled, exit.
928 if (!generate_app_image) {
Victor Hsiehcb35a062020-08-13 16:11:13 -0700929 return UniqueFile();
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +0100930 }
Mathieu Chartier9b2da082018-10-26 13:23:11 -0700931 std::string app_image_format = GetProperty("dalvik.vm.appimageformat", "");
932 if (app_image_format.empty()) {
Victor Hsiehcb35a062020-08-13 16:11:13 -0700933 return UniqueFile();
Calin Juravle7a570e82017-01-14 16:23:30 -0800934 }
935 // Recreate is true since we do not want to modify a mapped image. If the app is
936 // already running and we modify the image file, it can cause crashes (b/27493510).
Victor Hsiehcb35a062020-08-13 16:11:13 -0700937 UniqueFile image_file(
Calin Juravle7a570e82017-01-14 16:23:30 -0800938 open_output_file(image_path.c_str(), true /*recreate*/, 0600 /*permissions*/),
Victor Hsiehcb35a062020-08-13 16:11:13 -0700939 image_path,
940 UnlinkIgnoreResult);
941 if (image_file.fd() < 0) {
Calin Juravle7a570e82017-01-14 16:23:30 -0800942 // Could not create application image file. Go on since we can compile without it.
943 LOG(ERROR) << "installd could not create '" << image_path
944 << "' for image file during dexopt";
945 // If we have a valid image file path but no image fd, explicitly erase the image file.
946 if (unlink(image_path.c_str()) < 0) {
947 if (errno != ENOENT) {
948 PLOG(ERROR) << "Couldn't unlink image file " << image_path;
949 }
950 }
951 } else if (!set_permissions_and_ownership(
Victor Hsiehcb35a062020-08-13 16:11:13 -0700952 image_file.fd(), is_public, uid, image_path.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -0800953 ALOGE("installd cannot set owner '%s' for image during dexopt\n", image_path.c_str());
Victor Hsiehcb35a062020-08-13 16:11:13 -0700954 image_file.reset();
Calin Juravle7a570e82017-01-14 16:23:30 -0800955 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700956
Victor Hsiehcb35a062020-08-13 16:11:13 -0700957 return image_file;
Calin Juravle7a570e82017-01-14 16:23:30 -0800958}
959
960// Creates the dexopt swap file if necessary and return its fd.
961// Returns -1 if there's no need for a swap or in case of errors.
Victor Hsiehcb35a062020-08-13 16:11:13 -0700962unique_fd maybe_open_dexopt_swap_file(const std::string& out_oat_path) {
Calin Juravle7a570e82017-01-14 16:23:30 -0800963 if (!ShouldUseSwapFileForDexopt()) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800964 return invalid_unique_fd();
Calin Juravle7a570e82017-01-14 16:23:30 -0800965 }
Victor Hsiehcb35a062020-08-13 16:11:13 -0700966 auto swap_file_name = out_oat_path + ".swap";
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800967 unique_fd swap_fd(open_output_file(
Jeff Sharkeyc1149c92017-09-21 14:51:09 -0600968 swap_file_name.c_str(), /*recreate*/true, /*permissions*/0600));
Calin Juravle7a570e82017-01-14 16:23:30 -0800969 if (swap_fd.get() < 0) {
970 // Could not create swap file. Optimistically go on and hope that we can compile
971 // without it.
Jeff Sharkeyc1149c92017-09-21 14:51:09 -0600972 ALOGE("installd could not create '%s' for swap during dexopt\n", swap_file_name.c_str());
Calin Juravle7a570e82017-01-14 16:23:30 -0800973 } else {
974 // Immediately unlink. We don't really want to hit flash.
Jeff Sharkeyc1149c92017-09-21 14:51:09 -0600975 if (unlink(swap_file_name.c_str()) < 0) {
Calin Juravle7a570e82017-01-14 16:23:30 -0800976 PLOG(ERROR) << "Couldn't unlink swap file " << swap_file_name;
977 }
978 }
979 return swap_fd;
980}
981
982// Opens the reference profiles if needed.
983// Note that the reference profile might not exist so it's OK if the fd will be -1.
Victor Hsiehcb35a062020-08-13 16:11:13 -0700984UniqueFile maybe_open_reference_profile(const std::string& pkgname,
Calin Juravlec4f6a0b2018-02-01 01:27:24 +0000985 const std::string& dex_path, const char* profile_name, bool profile_guided,
Calin Juravle824a64d2018-01-18 20:23:17 -0800986 bool is_public, int uid, bool is_secondary_dex) {
Calin Juravle5bd1c722018-02-01 17:23:54 +0000987 // If we are not profile guided compilation, or we are compiling system server
988 // do not bother to open the profiles; we won't be using them.
989 if (!profile_guided || (pkgname[0] == '*')) {
Victor Hsiehcb35a062020-08-13 16:11:13 -0700990 return UniqueFile();
Calin Juravle5bd1c722018-02-01 17:23:54 +0000991 }
992
993 // If this is a secondary dex path which is public do not open the profile.
994 // We cannot compile public secondary dex paths with profiles. That's because
995 // it will expose how the dex files are used by their owner.
996 //
997 // Note that the PackageManager is responsible to set the is_public flag for
998 // primary apks and we do not check it here. In some cases, e.g. when
999 // compiling with a public profile from the .dm file the PackageManager will
1000 // set is_public toghether with the profile guided compilation.
1001 if (is_secondary_dex && is_public) {
Victor Hsiehcb35a062020-08-13 16:11:13 -07001002 return UniqueFile();
Jeff Sharkey90aff262016-12-12 14:28:24 -07001003 }
Calin Juravle114f0812017-03-08 19:05:07 -08001004
1005 // Open reference profile in read only mode as dex2oat does not get write permissions.
Calin Juravlec4f6a0b2018-02-01 01:27:24 +00001006 std::string location;
1007 if (is_secondary_dex) {
1008 location = dex_path;
1009 } else {
1010 if (profile_name == nullptr) {
1011 // This path is taken for system server re-compilation lunched from ZygoteInit.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001012 return UniqueFile();
Calin Juravlec4f6a0b2018-02-01 01:27:24 +00001013 } else {
1014 location = profile_name;
1015 }
1016 }
Victor Hsiehcb35a062020-08-13 16:11:13 -07001017 return open_reference_profile_as_unique_file(uid, pkgname, location, /*read_write*/false,
1018 is_secondary_dex);
Calin Juravle7a570e82017-01-14 16:23:30 -08001019}
Jeff Sharkey90aff262016-12-12 14:28:24 -07001020
Victor Hsiehcb35a062020-08-13 16:11:13 -07001021// Opens the vdex files and assigns the input fd to in_vdex_wrapper and the output fd to
1022// out_vdex_wrapper. Returns true for success or false in case of errors.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001023bool open_vdex_files_for_dex2oat(const char* apk_path, const char* out_oat_path, int dexopt_needed,
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001024 const char* instruction_set, bool is_public, int uid, bool is_secondary_dex,
Victor Hsiehcb35a062020-08-13 16:11:13 -07001025 bool profile_guided, UniqueFile* in_vdex_wrapper,
1026 UniqueFile* out_vdex_wrapper) {
1027 CHECK(in_vdex_wrapper != nullptr);
1028 CHECK(out_vdex_wrapper != nullptr);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001029 // Open the existing VDEX. We do this before creating the new output VDEX, which will
1030 // unlink the old one.
Richard Uhler76cc0272016-12-08 10:46:35 +00001031 char in_odex_path[PKG_PATH_MAX];
1032 int dexopt_action = abs(dexopt_needed);
1033 bool is_odex_location = dexopt_needed < 0;
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001034
1035 // Infer the name of the output VDEX.
1036 const std::string out_vdex_path_str = create_vdex_filename(out_oat_path);
1037 if (out_vdex_path_str.empty()) {
1038 return false;
1039 }
1040
1041 bool update_vdex_in_place = false;
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001042 if (dexopt_action != DEX2OAT_FROM_SCRATCH) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001043 // Open the possibly existing vdex. If none exist, we pass -1 to dex2oat for input-vdex-fd.
1044 const char* path = nullptr;
1045 if (is_odex_location) {
1046 if (calculate_odex_file_path(in_odex_path, apk_path, instruction_set)) {
1047 path = in_odex_path;
1048 } else {
1049 ALOGE("installd cannot compute input vdex location for '%s'\n", apk_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001050 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001051 }
1052 } else {
1053 path = out_oat_path;
1054 }
Victor Hsiehcb35a062020-08-13 16:11:13 -07001055 std::string in_vdex_path_str = create_vdex_filename(path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001056 if (in_vdex_path_str.empty()) {
1057 ALOGE("installd cannot compute input vdex location for '%s'\n", path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001058 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001059 }
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001060 // We can update in place when all these conditions are met:
1061 // 1) The vdex location to write to is the same as the vdex location to read (vdex files
1062 // on /system typically cannot be updated in place).
1063 // 2) We dex2oat due to boot image change, because we then know the existing vdex file
1064 // cannot be currently used by a running process.
1065 // 3) We are not doing a profile guided compilation, because dexlayout requires two
1066 // different vdex files to operate.
1067 update_vdex_in_place =
1068 (in_vdex_path_str == out_vdex_path_str) &&
1069 (dexopt_action == DEX2OAT_FOR_BOOT_IMAGE) &&
1070 !profile_guided;
1071 if (update_vdex_in_place) {
1072 // Open the file read-write to be able to update it.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001073 in_vdex_wrapper->reset(open(in_vdex_path_str.c_str(), O_RDWR, 0),
1074 in_vdex_path_str);
1075 if (in_vdex_wrapper->fd() == -1) {
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001076 // If we failed to open the file, we cannot update it in place.
1077 update_vdex_in_place = false;
1078 }
1079 } else {
Victor Hsiehcb35a062020-08-13 16:11:13 -07001080 in_vdex_wrapper->reset(open(in_vdex_path_str.c_str(), O_RDONLY, 0),
1081 in_vdex_path_str);
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001082 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001083 }
1084
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001085 // If we are updating the vdex in place, we do not need to recreate a vdex,
1086 // and can use the same existing one.
1087 if (update_vdex_in_place) {
1088 // We unlink the file in case the invocation of dex2oat fails, to ensure we don't
1089 // have bogus stale vdex files.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001090 out_vdex_wrapper->reset(
1091 in_vdex_wrapper->fd(),
1092 out_vdex_path_str,
1093 UnlinkIgnoreResult);
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001094 // Disable auto close for the in wrapper fd (it will be done when destructing the out
1095 // wrapper).
Victor Hsiehcb35a062020-08-13 16:11:13 -07001096 in_vdex_wrapper->DisableAutoClose();
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001097 } else {
Victor Hsiehcb35a062020-08-13 16:11:13 -07001098 out_vdex_wrapper->reset(
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001099 open_output_file(out_vdex_path_str.c_str(), /*recreate*/true, /*permissions*/0644),
Victor Hsiehcb35a062020-08-13 16:11:13 -07001100 out_vdex_path_str,
1101 UnlinkIgnoreResult);
1102 if (out_vdex_wrapper->fd() < 0) {
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001103 ALOGE("installd cannot open vdex'%s' during dexopt\n", out_vdex_path_str.c_str());
1104 return false;
1105 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001106 }
Victor Hsiehcb35a062020-08-13 16:11:13 -07001107 if (!set_permissions_and_ownership(out_vdex_wrapper->fd(), is_public, uid,
Calin Juravle2289c0a2017-02-15 12:44:14 -08001108 out_vdex_path_str.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001109 ALOGE("installd cannot set owner '%s' for vdex during dexopt\n", out_vdex_path_str.c_str());
1110 return false;
1111 }
1112
1113 // If we got here we successfully opened the vdex files.
1114 return true;
1115}
1116
1117// Opens the output oat file for the given apk.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001118UniqueFile open_oat_out_file(const char* apk_path, const char* oat_dir,
1119 bool is_public, int uid, const char* instruction_set, bool is_secondary_dex) {
1120 char out_oat_path[PKG_PATH_MAX];
Calin Juravle80a21252017-01-17 14:43:25 -08001121 if (!create_oat_out_path(apk_path, instruction_set, oat_dir, is_secondary_dex, out_oat_path)) {
Victor Hsiehcb35a062020-08-13 16:11:13 -07001122 return UniqueFile();
Calin Juravle7a570e82017-01-14 16:23:30 -08001123 }
Victor Hsiehcb35a062020-08-13 16:11:13 -07001124 UniqueFile oat(
Calin Juravle7a570e82017-01-14 16:23:30 -08001125 open_output_file(out_oat_path, /*recreate*/true, /*permissions*/0644),
Victor Hsiehcb35a062020-08-13 16:11:13 -07001126 out_oat_path,
1127 UnlinkIgnoreResult);
1128 if (oat.fd() < 0) {
Calin Juravle80a21252017-01-17 14:43:25 -08001129 PLOG(ERROR) << "installd cannot open output during dexopt" << out_oat_path;
Calin Juravle2289c0a2017-02-15 12:44:14 -08001130 } else if (!set_permissions_and_ownership(
Victor Hsiehcb35a062020-08-13 16:11:13 -07001131 oat.fd(), is_public, uid, out_oat_path, is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001132 ALOGE("installd cannot set owner '%s' for output during dexopt\n", out_oat_path);
Victor Hsiehcb35a062020-08-13 16:11:13 -07001133 oat.reset();
Calin Juravle7a570e82017-01-14 16:23:30 -08001134 }
Victor Hsiehcb35a062020-08-13 16:11:13 -07001135 return oat;
Calin Juravle7a570e82017-01-14 16:23:30 -08001136}
1137
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001138// Creates RDONLY fds for oat and vdex files, if exist.
1139// Returns false if it fails to create oat out path for the given apk path.
1140// Note that the method returns true even if the files could not be opened.
1141bool maybe_open_oat_and_vdex_file(const std::string& apk_path,
1142 const std::string& oat_dir,
1143 const std::string& instruction_set,
1144 bool is_secondary_dex,
1145 unique_fd* oat_file_fd,
1146 unique_fd* vdex_file_fd) {
1147 char oat_path[PKG_PATH_MAX];
1148 if (!create_oat_out_path(apk_path.c_str(),
1149 instruction_set.c_str(),
1150 oat_dir.c_str(),
1151 is_secondary_dex,
1152 oat_path)) {
Calin Juravle7d765462017-09-04 15:57:10 -07001153 LOG(ERROR) << "Could not create oat out path for "
1154 << apk_path << " with oat dir " << oat_dir;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001155 return false;
1156 }
1157 oat_file_fd->reset(open(oat_path, O_RDONLY));
1158 if (oat_file_fd->get() < 0) {
1159 PLOG(INFO) << "installd cannot open oat file during dexopt" << oat_path;
1160 }
1161
1162 std::string vdex_filename = create_vdex_filename(oat_path);
1163 vdex_file_fd->reset(open(vdex_filename.c_str(), O_RDONLY));
1164 if (vdex_file_fd->get() < 0) {
1165 PLOG(INFO) << "installd cannot open vdex file during dexopt" << vdex_filename;
1166 }
1167
1168 return true;
1169}
1170
Calin Juravle80a21252017-01-17 14:43:25 -08001171// Runs (execv) dexoptanalyzer on the given arguments.
Calin Juravle114f0812017-03-08 19:05:07 -08001172// The analyzer will check if the dex_file needs to be (re)compiled to match the compiler_filter.
1173// If this is for a profile guided compilation, profile_was_updated will tell whether or not
1174// the profile has changed.
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001175class RunDexoptAnalyzer : public ExecVHelper {
1176 public:
1177 RunDexoptAnalyzer(const std::string& dex_file,
David Brazdil4f6027a2019-03-19 11:44:21 +00001178 int vdex_fd,
1179 int oat_fd,
1180 int zip_fd,
1181 const std::string& instruction_set,
1182 const std::string& compiler_filter,
Calin Juravle3b758282021-06-08 08:04:52 -07001183 int profile_analysis_result,
David Brazdil4f6027a2019-03-19 11:44:21 +00001184 bool downgrade,
1185 const char* class_loader_context,
1186 const std::string& class_loader_context_fds) {
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001187 CHECK_GE(zip_fd, 0);
Calin Juravlef74a7372019-02-28 20:29:41 -08001188
1189 // We always run the analyzer in the background job.
1190 const char* dexoptanalyzer_bin = select_execution_binary(
1191 kDexoptanalyzerPath, kDexoptanalyzerDebugPath, /*background_job_compile=*/ true);
Calin Juravle80a21252017-01-17 14:43:25 -08001192
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001193 std::string dex_file_arg = "--dex-file=" + dex_file;
1194 std::string oat_fd_arg = "--oat-fd=" + std::to_string(oat_fd);
1195 std::string vdex_fd_arg = "--vdex-fd=" + std::to_string(vdex_fd);
1196 std::string zip_fd_arg = "--zip-fd=" + std::to_string(zip_fd);
1197 std::string isa_arg = "--isa=" + instruction_set;
1198 std::string compiler_filter_arg = "--compiler-filter=" + compiler_filter;
Calin Juravle3b758282021-06-08 08:04:52 -07001199 std::string profile_analysis_arg = "--profile-analysis-result="
1200 + std::to_string(profile_analysis_result);
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001201 const char* downgrade_flag = "--downgrade";
1202 std::string class_loader_context_arg = "--class-loader-context=";
1203 if (class_loader_context != nullptr) {
1204 class_loader_context_arg += class_loader_context;
1205 }
David Brazdil4f6027a2019-03-19 11:44:21 +00001206 std::string class_loader_context_fds_arg = "--class-loader-context-fds=";
1207 if (!class_loader_context_fds.empty()) {
1208 class_loader_context_fds_arg += class_loader_context_fds;
1209 }
Mathieu Chartier31636522018-11-09 23:53:07 +00001210
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001211 // program name, dex file, isa, filter
1212 AddArg(dex_file_arg);
1213 AddArg(isa_arg);
1214 AddArg(compiler_filter_arg);
1215 if (oat_fd >= 0) {
1216 AddArg(oat_fd_arg);
1217 }
1218 if (vdex_fd >= 0) {
1219 AddArg(vdex_fd_arg);
1220 }
Greg Kaiser8042c372019-03-26 06:23:19 -07001221 AddArg(zip_fd_arg);
Calin Juravle3b758282021-06-08 08:04:52 -07001222 AddArg(profile_analysis_arg);
1223
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001224 if (downgrade) {
1225 AddArg(downgrade_flag);
1226 }
1227 if (class_loader_context != nullptr) {
Greg Kaiser8042c372019-03-26 06:23:19 -07001228 AddArg(class_loader_context_arg);
David Brazdil4f6027a2019-03-19 11:44:21 +00001229 if (!class_loader_context_fds.empty()) {
Greg Kaiser8042c372019-03-26 06:23:19 -07001230 AddArg(class_loader_context_fds_arg);
David Brazdil4f6027a2019-03-19 11:44:21 +00001231 }
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001232 }
Mathieu Chartier31636522018-11-09 23:53:07 +00001233
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001234 PrepareArgs(dexoptanalyzer_bin);
1235 }
David Brazdil4f6027a2019-03-19 11:44:21 +00001236
1237 // Dexoptanalyzer mode which flattens the given class loader context and
1238 // prints a list of its dex files in that flattened order.
1239 RunDexoptAnalyzer(const char* class_loader_context) {
1240 CHECK(class_loader_context != nullptr);
1241
1242 // We always run the analyzer in the background job.
1243 const char* dexoptanalyzer_bin = select_execution_binary(
1244 kDexoptanalyzerPath, kDexoptanalyzerDebugPath, /*background_job_compile=*/ true);
1245
1246 AddArg("--flatten-class-loader-context");
1247 AddArg(std::string("--class-loader-context=") + class_loader_context);
1248 PrepareArgs(dexoptanalyzer_bin);
1249 }
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001250};
Calin Juravle80a21252017-01-17 14:43:25 -08001251
1252// Prepares the oat dir for the secondary dex files.
Calin Juravle114f0812017-03-08 19:05:07 -08001253static bool prepare_secondary_dex_oat_dir(const std::string& dex_path, int uid,
Calin Juravle7d765462017-09-04 15:57:10 -07001254 const char* instruction_set) {
Calin Juravle114f0812017-03-08 19:05:07 -08001255 unsigned long dirIndex = dex_path.rfind('/');
Calin Juravle80a21252017-01-17 14:43:25 -08001256 if (dirIndex == std::string::npos) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001257 LOG(ERROR ) << "Unexpected dir structure for secondary dex " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001258 return false;
1259 }
Calin Juravle114f0812017-03-08 19:05:07 -08001260 std::string dex_dir = dex_path.substr(0, dirIndex);
Calin Juravle80a21252017-01-17 14:43:25 -08001261
Calin Juravle80a21252017-01-17 14:43:25 -08001262 // Create oat file output directory.
Calin Juravleebc8a792017-04-04 20:21:05 -07001263 mode_t oat_dir_mode = S_IRWXU | S_IRWXG | S_IXOTH;
1264 if (prepare_app_cache_dir(dex_dir, "oat", oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001265 LOG(ERROR) << "Could not prepare oat dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001266 return false;
1267 }
1268
1269 char oat_dir[PKG_PATH_MAX];
Calin Juravle114f0812017-03-08 19:05:07 -08001270 snprintf(oat_dir, PKG_PATH_MAX, "%s/oat", dex_dir.c_str());
Calin Juravle80a21252017-01-17 14:43:25 -08001271
Calin Juravle7d765462017-09-04 15:57:10 -07001272 if (prepare_app_cache_dir(oat_dir, instruction_set, oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001273 LOG(ERROR) << "Could not prepare oat/isa dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001274 return false;
1275 }
1276
1277 return true;
1278}
1279
Calin Juravle7d765462017-09-04 15:57:10 -07001280// Return codes for identifying the reason why dexoptanalyzer was not invoked when processing
1281// secondary dex files. This return codes are returned by the child process created for
1282// analyzing secondary dex files in process_secondary_dex_dexopt.
Calin Juravle80a21252017-01-17 14:43:25 -08001283
Andreas Gampe194fe422018-02-28 20:16:19 -08001284enum DexoptAnalyzerSkipCodes {
1285 // The dexoptanalyzer was not invoked because of validation or IO errors.
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001286 // Specific errors are encoded in the name.
1287 kSecondaryDexDexoptAnalyzerSkippedValidatePath = 200,
1288 kSecondaryDexDexoptAnalyzerSkippedOpenZip = 201,
1289 kSecondaryDexDexoptAnalyzerSkippedPrepareDir = 202,
1290 kSecondaryDexDexoptAnalyzerSkippedOpenOutput = 203,
1291 kSecondaryDexDexoptAnalyzerSkippedFailExec = 204,
Andreas Gampe194fe422018-02-28 20:16:19 -08001292 // The dexoptanalyzer was not invoked because the dex file does not exist anymore.
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001293 kSecondaryDexDexoptAnalyzerSkippedNoFile = 205,
Andreas Gampe194fe422018-02-28 20:16:19 -08001294};
Calin Juravle7d765462017-09-04 15:57:10 -07001295
1296// Verifies the result of analyzing secondary dex files from process_secondary_dex_dexopt.
Calin Juravle80a21252017-01-17 14:43:25 -08001297// If the result is valid returns true and sets dexopt_needed_out to a valid value.
1298// Returns false for errors or unexpected result values.
Calin Juravle7d765462017-09-04 15:57:10 -07001299// The result is expected to be either one of SECONDARY_DEX_* codes or a valid exit code
1300// of dexoptanalyzer.
1301static bool process_secondary_dexoptanalyzer_result(const std::string& dex_path, int result,
Andreas Gampe194fe422018-02-28 20:16:19 -08001302 int* dexopt_needed_out, std::string* error_msg) {
Calin Juravle80a21252017-01-17 14:43:25 -08001303 // The result values are defined in dexoptanalyzer.
1304 switch (result) {
Calin Juravle7d765462017-09-04 15:57:10 -07001305 case 0: // dexoptanalyzer: no_dexopt_needed
Calin Juravle80a21252017-01-17 14:43:25 -08001306 *dexopt_needed_out = NO_DEXOPT_NEEDED; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001307 case 1: // dexoptanalyzer: dex2oat_from_scratch
Calin Juravle80a21252017-01-17 14:43:25 -08001308 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH; return true;
Vladimir Marko1752a112018-09-03 18:15:16 +01001309 case 4: // dexoptanalyzer: dex2oat_for_bootimage_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001310 *dexopt_needed_out = -DEX2OAT_FOR_BOOT_IMAGE; return true;
Vladimir Marko1752a112018-09-03 18:15:16 +01001311 case 5: // dexoptanalyzer: dex2oat_for_filter_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001312 *dexopt_needed_out = -DEX2OAT_FOR_FILTER; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001313 case 2: // dexoptanalyzer: dex2oat_for_bootimage_oat
1314 case 3: // dexoptanalyzer: dex2oat_for_filter_oat
Andreas Gampe194fe422018-02-28 20:16:19 -08001315 *error_msg = StringPrintf("Dexoptanalyzer return the status of an oat file."
1316 " Expected odex file status for secondary dex %s"
1317 " : dexoptanalyzer result=%d",
1318 dex_path.c_str(),
1319 result);
Calin Juravle80a21252017-01-17 14:43:25 -08001320 return false;
Andreas Gampe194fe422018-02-28 20:16:19 -08001321 }
1322
1323 // Use a second switch for enum switch-case analysis.
1324 switch (static_cast<DexoptAnalyzerSkipCodes>(result)) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001325 case kSecondaryDexDexoptAnalyzerSkippedNoFile:
Calin Juravle7d765462017-09-04 15:57:10 -07001326 // If the file does not exist there's no need for dexopt.
1327 *dexopt_needed_out = NO_DEXOPT_NEEDED;
1328 return true;
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001329
1330 case kSecondaryDexDexoptAnalyzerSkippedValidatePath:
1331 *error_msg = "Dexoptanalyzer path validation failed";
1332 return false;
1333 case kSecondaryDexDexoptAnalyzerSkippedOpenZip:
1334 *error_msg = "Dexoptanalyzer open zip failed";
1335 return false;
1336 case kSecondaryDexDexoptAnalyzerSkippedPrepareDir:
1337 *error_msg = "Dexoptanalyzer dir preparation failed";
1338 return false;
1339 case kSecondaryDexDexoptAnalyzerSkippedOpenOutput:
1340 *error_msg = "Dexoptanalyzer open output failed";
1341 return false;
1342 case kSecondaryDexDexoptAnalyzerSkippedFailExec:
1343 *error_msg = "Dexoptanalyzer failed to execute";
Calin Juravle80a21252017-01-17 14:43:25 -08001344 return false;
1345 }
Andreas Gampe194fe422018-02-28 20:16:19 -08001346
1347 *error_msg = StringPrintf("Unexpected result from analyzing secondary dex %s result=%d",
1348 dex_path.c_str(),
1349 result);
1350 return false;
Calin Juravle80a21252017-01-17 14:43:25 -08001351}
1352
Calin Juravle7d765462017-09-04 15:57:10 -07001353enum SecondaryDexAccess {
1354 kSecondaryDexAccessReadOk = 0,
1355 kSecondaryDexAccessDoesNotExist = 1,
1356 kSecondaryDexAccessPermissionError = 2,
1357 kSecondaryDexAccessIOError = 3
1358};
1359
1360static SecondaryDexAccess check_secondary_dex_access(const std::string& dex_path) {
1361 // Check if the path exists and can be read. If not, there's nothing to do.
1362 if (access(dex_path.c_str(), R_OK) == 0) {
1363 return kSecondaryDexAccessReadOk;
1364 } else {
1365 if (errno == ENOENT) {
1366 LOG(INFO) << "Secondary dex does not exist: " << dex_path;
1367 return kSecondaryDexAccessDoesNotExist;
1368 } else {
1369 PLOG(ERROR) << "Could not access secondary dex " << dex_path;
1370 return errno == EACCES
1371 ? kSecondaryDexAccessPermissionError
1372 : kSecondaryDexAccessIOError;
1373 }
1374 }
1375}
1376
1377static bool is_file_public(const std::string& filename) {
1378 struct stat file_stat;
1379 if (stat(filename.c_str(), &file_stat) == 0) {
1380 return (file_stat.st_mode & S_IROTH) != 0;
1381 }
1382 return false;
1383}
1384
1385// Create the oat file structure for the secondary dex 'dex_path' and assign
1386// the individual path component to the 'out_' parameters.
1387static bool create_secondary_dex_oat_layout(const std::string& dex_path, const std::string& isa,
Andreas Gampe194fe422018-02-28 20:16:19 -08001388 char* out_oat_dir, char* out_oat_isa_dir, char* out_oat_path, std::string* error_msg) {
Calin Juravle7d765462017-09-04 15:57:10 -07001389 size_t dirIndex = dex_path.rfind('/');
1390 if (dirIndex == std::string::npos) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001391 *error_msg = std::string("Unexpected dir structure for dex file ").append(dex_path);
Calin Juravle7d765462017-09-04 15:57:10 -07001392 return false;
1393 }
1394 // TODO(calin): we have similar computations in at lest 3 other places
1395 // (InstalldNativeService, otapropt and dexopt). Unify them and get rid of snprintf by
1396 // using string append.
1397 std::string apk_dir = dex_path.substr(0, dirIndex);
1398 snprintf(out_oat_dir, PKG_PATH_MAX, "%s/oat", apk_dir.c_str());
1399 snprintf(out_oat_isa_dir, PKG_PATH_MAX, "%s/%s", out_oat_dir, isa.c_str());
1400
1401 if (!create_oat_out_path(dex_path.c_str(), isa.c_str(), out_oat_dir,
1402 /*is_secondary_dex*/true, out_oat_path)) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001403 *error_msg = std::string("Could not create oat path for secondary dex ").append(dex_path);
Calin Juravle7d765462017-09-04 15:57:10 -07001404 return false;
1405 }
1406 return true;
1407}
1408
1409// Validate that the dexopt_flags contain a valid storage flag and convert that to an installd
1410// recognized storage flags (FLAG_STORAGE_CE or FLAG_STORAGE_DE).
Andreas Gampe194fe422018-02-28 20:16:19 -08001411static bool validate_dexopt_storage_flags(int dexopt_flags,
1412 int* out_storage_flag,
1413 std::string* error_msg) {
Calin Juravle7d765462017-09-04 15:57:10 -07001414 if ((dexopt_flags & DEXOPT_STORAGE_CE) != 0) {
1415 *out_storage_flag = FLAG_STORAGE_CE;
1416 if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001417 *error_msg = "Ambiguous secondary dex storage flag. Both, CE and DE, flags are set";
Calin Juravle7d765462017-09-04 15:57:10 -07001418 return false;
1419 }
1420 } else if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
1421 *out_storage_flag = FLAG_STORAGE_DE;
1422 } else {
Andreas Gampe194fe422018-02-28 20:16:19 -08001423 *error_msg = "Secondary dex storage flag must be set";
Calin Juravle7d765462017-09-04 15:57:10 -07001424 return false;
1425 }
1426 return true;
1427}
1428
David Brazdil4f6027a2019-03-19 11:44:21 +00001429static bool get_class_loader_context_dex_paths(const char* class_loader_context, int uid,
1430 /* out */ std::vector<std::string>* context_dex_paths) {
1431 if (class_loader_context == nullptr) {
1432 return true;
1433 }
1434
1435 LOG(DEBUG) << "Getting dex paths for context " << class_loader_context;
1436
1437 // Pipe to get the hash result back from our child process.
1438 unique_fd pipe_read, pipe_write;
1439 if (!Pipe(&pipe_read, &pipe_write)) {
1440 PLOG(ERROR) << "Failed to create pipe";
1441 return false;
1442 }
1443
1444 pid_t pid = fork();
1445 if (pid == 0) {
1446 // child -- drop privileges before continuing.
1447 drop_capabilities(uid);
1448
1449 // Route stdout to `pipe_write`
1450 while ((dup2(pipe_write, STDOUT_FILENO) == -1) && (errno == EINTR)) {}
1451 pipe_write.reset();
1452 pipe_read.reset();
1453
1454 RunDexoptAnalyzer run_dexopt_analyzer(class_loader_context);
1455 run_dexopt_analyzer.Exec(kSecondaryDexDexoptAnalyzerSkippedFailExec);
1456 }
1457
1458 /* parent */
1459 pipe_write.reset();
1460
1461 std::string str_dex_paths;
1462 if (!ReadFdToString(pipe_read, &str_dex_paths)) {
1463 PLOG(ERROR) << "Failed to read from pipe";
1464 return false;
1465 }
1466 pipe_read.reset();
1467
1468 int return_code = wait_child(pid);
1469 if (!WIFEXITED(return_code)) {
1470 PLOG(ERROR) << "Error waiting for child dexoptanalyzer process";
1471 return false;
1472 }
1473
1474 constexpr int kFlattenClassLoaderContextSuccess = 50;
1475 return_code = WEXITSTATUS(return_code);
1476 if (return_code != kFlattenClassLoaderContextSuccess) {
1477 LOG(ERROR) << "Dexoptanalyzer could not flatten class loader context, code=" << return_code;
1478 return false;
1479 }
1480
1481 if (!str_dex_paths.empty()) {
1482 *context_dex_paths = android::base::Split(str_dex_paths, ":");
1483 }
1484 return true;
1485}
1486
1487static int open_dex_paths(const std::vector<std::string>& dex_paths,
1488 /* out */ std::vector<unique_fd>* zip_fds, /* out */ std::string* error_msg) {
1489 for (const std::string& dex_path : dex_paths) {
1490 zip_fds->emplace_back(open(dex_path.c_str(), O_RDONLY));
1491 if (zip_fds->back().get() < 0) {
1492 *error_msg = StringPrintf(
1493 "installd cannot open '%s' for input during dexopt", dex_path.c_str());
1494 if (errno == ENOENT) {
1495 return kSecondaryDexDexoptAnalyzerSkippedNoFile;
1496 } else {
1497 return kSecondaryDexDexoptAnalyzerSkippedOpenZip;
1498 }
1499 }
1500 }
1501 return 0;
1502}
1503
1504static std::string join_fds(const std::vector<unique_fd>& fds) {
1505 std::stringstream ss;
1506 bool is_first = true;
1507 for (const unique_fd& fd : fds) {
1508 if (is_first) {
1509 is_first = false;
1510 } else {
1511 ss << ":";
1512 }
1513 ss << fd.get();
1514 }
1515 return ss.str();
1516}
1517
Calin Juravlec9eab382017-01-25 01:17:17 -08001518// Processes the dex_path as a secondary dex files and return true if the path dex file should
Calin Juravle80a21252017-01-17 14:43:25 -08001519// be compiled. Returns false for errors (logged) or true if the secondary dex path was process
1520// successfully.
Calin Juravleebc8a792017-04-04 20:21:05 -07001521// When returning true, the output parameters will be:
1522// - is_public_out: whether or not the oat file should not be made public
1523// - dexopt_needed_out: valid OatFileAsssitant::DexOptNeeded
1524// - oat_dir_out: the oat dir path where the oat file should be stored
Calin Juravle7d765462017-09-04 15:57:10 -07001525static bool process_secondary_dex_dexopt(const std::string& dex_path, const char* pkgname,
Calin Juravle80a21252017-01-17 14:43:25 -08001526 int dexopt_flags, const char* volume_uuid, int uid, const char* instruction_set,
Calin Juravleebc8a792017-04-04 20:21:05 -07001527 const char* compiler_filter, bool* is_public_out, int* dexopt_needed_out,
Andreas Gampe194fe422018-02-28 20:16:19 -08001528 std::string* oat_dir_out, bool downgrade, const char* class_loader_context,
David Brazdil4f6027a2019-03-19 11:44:21 +00001529 const std::vector<std::string>& context_dex_paths, /* out */ std::string* error_msg) {
Calin Juravle7d765462017-09-04 15:57:10 -07001530 LOG(DEBUG) << "Processing secondary dex path " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001531 int storage_flag;
Andreas Gampe194fe422018-02-28 20:16:19 -08001532 if (!validate_dexopt_storage_flags(dexopt_flags, &storage_flag, error_msg)) {
1533 LOG(ERROR) << *error_msg;
Calin Juravle80a21252017-01-17 14:43:25 -08001534 return false;
1535 }
Calin Juravle7d765462017-09-04 15:57:10 -07001536 // Compute the oat dir as it's not easy to extract it from the child computation.
1537 char oat_path[PKG_PATH_MAX];
1538 char oat_dir[PKG_PATH_MAX];
1539 char oat_isa_dir[PKG_PATH_MAX];
1540 if (!create_secondary_dex_oat_layout(
Andreas Gampe194fe422018-02-28 20:16:19 -08001541 dex_path, instruction_set, oat_dir, oat_isa_dir, oat_path, error_msg)) {
1542 LOG(ERROR) << "Could not create secondary odex layout: " << *error_msg;
Calin Juravled23dee72017-07-06 16:29:11 -07001543 return false;
1544 }
Calin Juravle7d765462017-09-04 15:57:10 -07001545 oat_dir_out->assign(oat_dir);
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001546
Calin Juravle80a21252017-01-17 14:43:25 -08001547 pid_t pid = fork();
1548 if (pid == 0) {
1549 // child -- drop privileges before continuing.
1550 drop_capabilities(uid);
Calin Juravle7d765462017-09-04 15:57:10 -07001551
1552 // Validate the path structure.
1553 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid, uid, storage_flag)) {
Martijn Coenen6de402a2021-04-26 16:23:40 +02001554 async_safe_format_log(ANDROID_LOG_ERROR, LOG_TAG,
1555 "Could not validate secondary dex path %s", dex_path.c_str());
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001556 _exit(kSecondaryDexDexoptAnalyzerSkippedValidatePath);
Calin Juravle7d765462017-09-04 15:57:10 -07001557 }
1558
1559 // Open the dex file.
1560 unique_fd zip_fd;
1561 zip_fd.reset(open(dex_path.c_str(), O_RDONLY));
1562 if (zip_fd.get() < 0) {
1563 if (errno == ENOENT) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001564 _exit(kSecondaryDexDexoptAnalyzerSkippedNoFile);
Calin Juravle7d765462017-09-04 15:57:10 -07001565 } else {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001566 _exit(kSecondaryDexDexoptAnalyzerSkippedOpenZip);
Calin Juravle7d765462017-09-04 15:57:10 -07001567 }
1568 }
1569
David Brazdil4f6027a2019-03-19 11:44:21 +00001570 // Open class loader context dex files.
1571 std::vector<unique_fd> context_zip_fds;
1572 int open_dex_paths_rc = open_dex_paths(context_dex_paths, &context_zip_fds, error_msg);
1573 if (open_dex_paths_rc != 0) {
1574 _exit(open_dex_paths_rc);
1575 }
1576
Calin Juravle7d765462017-09-04 15:57:10 -07001577 // Prepare the oat directories.
1578 if (!prepare_secondary_dex_oat_dir(dex_path, uid, instruction_set)) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001579 _exit(kSecondaryDexDexoptAnalyzerSkippedPrepareDir);
Calin Juravle7d765462017-09-04 15:57:10 -07001580 }
1581
1582 // Open the vdex/oat files if any.
1583 unique_fd oat_file_fd;
1584 unique_fd vdex_file_fd;
1585 if (!maybe_open_oat_and_vdex_file(dex_path,
1586 *oat_dir_out,
1587 instruction_set,
1588 true /* is_secondary_dex */,
1589 &oat_file_fd,
1590 &vdex_file_fd)) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001591 _exit(kSecondaryDexDexoptAnalyzerSkippedOpenOutput);
Calin Juravle7d765462017-09-04 15:57:10 -07001592 }
1593
1594 // Analyze profiles.
Calin Juravle3b758282021-06-08 08:04:52 -07001595 int profile_analysis_result = analyze_profiles(uid, pkgname, dex_path,
Calin Juravle824a64d2018-01-18 20:23:17 -08001596 /*is_secondary_dex*/true);
Calin Juravle7d765462017-09-04 15:57:10 -07001597
1598 // Run dexoptanalyzer to get dexopt_needed code. This is not expected to return.
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001599 // Note that we do not do it before the fork since opening the files is required to happen
1600 // after forking.
1601 RunDexoptAnalyzer run_dexopt_analyzer(dex_path,
1602 vdex_file_fd.get(),
1603 oat_file_fd.get(),
1604 zip_fd.get(),
1605 instruction_set,
Calin Juravle3b758282021-06-08 08:04:52 -07001606 compiler_filter,
1607 profile_analysis_result,
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001608 downgrade,
David Brazdil4f6027a2019-03-19 11:44:21 +00001609 class_loader_context,
1610 join_fds(context_zip_fds));
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001611 run_dexopt_analyzer.Exec(kSecondaryDexDexoptAnalyzerSkippedFailExec);
Calin Juravle80a21252017-01-17 14:43:25 -08001612 }
1613
1614 /* parent */
Calin Juravle80a21252017-01-17 14:43:25 -08001615 int result = wait_child(pid);
1616 if (!WIFEXITED(result)) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001617 *error_msg = StringPrintf("dexoptanalyzer failed for path %s: 0x%04x",
1618 dex_path.c_str(),
1619 result);
1620 LOG(ERROR) << *error_msg;
Calin Juravle80a21252017-01-17 14:43:25 -08001621 return false;
1622 }
1623 result = WEXITSTATUS(result);
Calin Juravle7d765462017-09-04 15:57:10 -07001624 // Check that we successfully executed dexoptanalyzer.
Andreas Gampe194fe422018-02-28 20:16:19 -08001625 bool success = process_secondary_dexoptanalyzer_result(dex_path,
1626 result,
1627 dexopt_needed_out,
1628 error_msg);
1629 if (!success) {
1630 LOG(ERROR) << *error_msg;
1631 }
Calin Juravle7d765462017-09-04 15:57:10 -07001632
1633 LOG(DEBUG) << "Processed secondary dex file " << dex_path << " result=" << result;
1634
Calin Juravle80a21252017-01-17 14:43:25 -08001635 // Run dexopt only if needed or forced.
Calin Juravle7d765462017-09-04 15:57:10 -07001636 // Note that dexoptanalyzer is executed even if force compilation is enabled (because it
1637 // makes the code simpler; force compilation is only needed during tests).
1638 if (success &&
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001639 (result != kSecondaryDexDexoptAnalyzerSkippedNoFile) &&
Calin Juravle7d765462017-09-04 15:57:10 -07001640 ((dexopt_flags & DEXOPT_FORCE) != 0)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001641 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH;
1642 }
1643
Calin Juravle7d765462017-09-04 15:57:10 -07001644 // Check if we should make the oat file public.
1645 // Note that if the dex file is not public the compiled code cannot be made public.
1646 // It is ok to check this flag outside in the parent process.
1647 *is_public_out = ((dexopt_flags & DEXOPT_PUBLIC) != 0) && is_file_public(dex_path);
1648
Calin Juravle80a21252017-01-17 14:43:25 -08001649 return success;
1650}
1651
Andreas Gampefa2dadd2018-02-28 19:52:47 -08001652static std::string format_dexopt_error(int status, const char* dex_path) {
1653 if (WIFEXITED(status)) {
1654 int int_code = WEXITSTATUS(status);
1655 const char* code_name = get_return_code_name(static_cast<DexoptReturnCodes>(int_code));
1656 if (code_name != nullptr) {
1657 return StringPrintf("Dex2oat invocation for %s failed: %s", dex_path, code_name);
1658 }
1659 }
1660 return StringPrintf("Dex2oat invocation for %s failed with 0x%04x", dex_path, status);
Andreas Gampe023b2242018-02-28 16:03:25 -08001661}
1662
Calin Juravlec9eab382017-01-25 01:17:17 -08001663int dexopt(const char* dex_path, uid_t uid, const char* pkgname, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -08001664 int dexopt_needed, const char* oat_dir, int dexopt_flags, const char* compiler_filter,
Calin Juravle52c45822017-07-13 22:50:21 -07001665 const char* volume_uuid, const char* class_loader_context, const char* se_info,
Calin Juravle62c5a372018-02-01 17:03:23 +00001666 bool downgrade, int target_sdk_version, const char* profile_name,
Andreas Gampe023b2242018-02-28 16:03:25 -08001667 const char* dex_metadata_path, const char* compilation_reason, std::string* error_msg) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001668 CHECK(pkgname != nullptr);
1669 CHECK(pkgname[0] != 0);
Andreas Gampe023b2242018-02-28 16:03:25 -08001670 CHECK(error_msg != nullptr);
Andreas Gamped32eec22018-02-28 16:02:51 -08001671 CHECK_EQ(dexopt_flags & ~DEXOPT_MASK, 0)
1672 << "dexopt flags contains unknown fields: " << dexopt_flags;
Calin Juravle7a570e82017-01-14 16:23:30 -08001673
Calin Juravled23dee72017-07-06 16:29:11 -07001674 if (!validate_dex_path_size(dex_path)) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001675 *error_msg = StringPrintf("Failed to validate %s", dex_path);
Calin Juravle52c45822017-07-13 22:50:21 -07001676 return -1;
1677 }
1678
1679 if (class_loader_context != nullptr && strlen(class_loader_context) > PKG_PATH_MAX) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001680 *error_msg = StringPrintf("Class loader context exceeds the allowed size: %s",
1681 class_loader_context);
1682 LOG(ERROR) << *error_msg;
Calin Juravle52c45822017-07-13 22:50:21 -07001683 return -1;
Calin Juravled23dee72017-07-06 16:29:11 -07001684 }
1685
Calin Juravleebc8a792017-04-04 20:21:05 -07001686 bool is_public = (dexopt_flags & DEXOPT_PUBLIC) != 0;
Calin Juravle7a570e82017-01-14 16:23:30 -08001687 bool debuggable = (dexopt_flags & DEXOPT_DEBUGGABLE) != 0;
1688 bool boot_complete = (dexopt_flags & DEXOPT_BOOTCOMPLETE) != 0;
1689 bool profile_guided = (dexopt_flags & DEXOPT_PROFILE_GUIDED) != 0;
Calin Juravle80a21252017-01-17 14:43:25 -08001690 bool is_secondary_dex = (dexopt_flags & DEXOPT_SECONDARY_DEX) != 0;
Andreas Gampea73a0cb2017-11-02 18:14:42 -07001691 bool background_job_compile = (dexopt_flags & DEXOPT_IDLE_BACKGROUND_JOB) != 0;
David Brazdil52249162018-02-12 18:04:59 -08001692 bool enable_hidden_api_checks = (dexopt_flags & DEXOPT_ENABLE_HIDDEN_API_CHECKS) != 0;
Mathieu Chartierf69c2f72018-03-06 13:55:58 -08001693 bool generate_compact_dex = (dexopt_flags & DEXOPT_GENERATE_COMPACT_DEX) != 0;
Mathieu Chartier1dc3dfa2018-03-12 17:55:06 -07001694 bool generate_app_image = (dexopt_flags & DEXOPT_GENERATE_APP_IMAGE) != 0;
Patrick Baumann2271b3e2020-04-14 17:03:00 -07001695 bool for_restore = (dexopt_flags & DEXOPT_FOR_RESTORE) != 0;
Calin Juravle80a21252017-01-17 14:43:25 -08001696
1697 // Check if we're dealing with a secondary dex file and if we need to compile it.
1698 std::string oat_dir_str;
David Brazdil4f6027a2019-03-19 11:44:21 +00001699 std::vector<std::string> context_dex_paths;
Calin Juravle80a21252017-01-17 14:43:25 -08001700 if (is_secondary_dex) {
David Brazdil4f6027a2019-03-19 11:44:21 +00001701 if (!get_class_loader_context_dex_paths(class_loader_context, uid, &context_dex_paths)) {
1702 *error_msg = "Failed acquiring context dex paths";
1703 return -1; // We had an error, logged in the process method.
1704 }
1705
Calin Juravlec9eab382017-01-25 01:17:17 -08001706 if (process_secondary_dex_dexopt(dex_path, pkgname, dexopt_flags, volume_uuid, uid,
Calin Juravleebc8a792017-04-04 20:21:05 -07001707 instruction_set, compiler_filter, &is_public, &dexopt_needed, &oat_dir_str,
David Brazdil4f6027a2019-03-19 11:44:21 +00001708 downgrade, class_loader_context, context_dex_paths, error_msg)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001709 oat_dir = oat_dir_str.c_str();
1710 if (dexopt_needed == NO_DEXOPT_NEEDED) {
1711 return 0; // Nothing to do, report success.
1712 }
1713 } else {
Andreas Gampe194fe422018-02-28 20:16:19 -08001714 if (error_msg->empty()) { // TODO: Make this a CHECK.
1715 *error_msg = "Failed processing secondary.";
1716 }
Calin Juravle80a21252017-01-17 14:43:25 -08001717 return -1; // We had an error, logged in the process method.
1718 }
1719 } else {
David Brazdil4f6027a2019-03-19 11:44:21 +00001720 // Currently these flags are only used for secondary dex files.
Calin Juravlec9eab382017-01-25 01:17:17 -08001721 // Verify that they are not set for primary apks.
Calin Juravle80a21252017-01-17 14:43:25 -08001722 CHECK((dexopt_flags & DEXOPT_STORAGE_CE) == 0);
1723 CHECK((dexopt_flags & DEXOPT_STORAGE_DE) == 0);
1724 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001725
1726 // Open the input file.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001727 UniqueFile in_dex(open(dex_path, O_RDONLY, 0), dex_path);
1728 if (in_dex.fd() < 0) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001729 *error_msg = StringPrintf("installd cannot open '%s' for input during dexopt", dex_path);
1730 LOG(ERROR) << *error_msg;
Calin Juravle7a570e82017-01-14 16:23:30 -08001731 return -1;
1732 }
1733
David Brazdil4f6027a2019-03-19 11:44:21 +00001734 // Open class loader context dex files.
1735 std::vector<unique_fd> context_input_fds;
1736 if (open_dex_paths(context_dex_paths, &context_input_fds, error_msg) != 0) {
1737 LOG(ERROR) << *error_msg;
1738 return -1;
1739 }
1740
Calin Juravle7a570e82017-01-14 16:23:30 -08001741 // Create the output OAT file.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001742 UniqueFile out_oat = open_oat_out_file(dex_path, oat_dir, is_public, uid,
1743 instruction_set, is_secondary_dex);
1744 if (out_oat.fd() < 0) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001745 *error_msg = "Could not open out oat file.";
Calin Juravle7a570e82017-01-14 16:23:30 -08001746 return -1;
1747 }
1748
1749 // Open vdex files.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001750 UniqueFile in_vdex;
1751 UniqueFile out_vdex;
1752 if (!open_vdex_files_for_dex2oat(dex_path, out_oat.path().c_str(), dexopt_needed,
1753 instruction_set, is_public, uid, is_secondary_dex, profile_guided, &in_vdex,
1754 &out_vdex)) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001755 *error_msg = "Could not open vdex files.";
Jeff Sharkey90aff262016-12-12 14:28:24 -07001756 return -1;
1757 }
1758
Calin Juravlecb556e32017-04-04 20:22:50 -07001759 // Ensure that the oat dir and the compiler artifacts of secondary dex files have the correct
1760 // selinux context (we generate them on the fly during the dexopt invocation and they don't
1761 // fully inherit their parent context).
1762 // Note that for primary apk the oat files are created before, in a separate installd
1763 // call which also does the restorecon. TODO(calin): unify the paths.
1764 if (is_secondary_dex) {
1765 if (selinux_android_restorecon_pkgdir(oat_dir, se_info, uid,
1766 SELINUX_ANDROID_RESTORECON_RECURSE)) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001767 *error_msg = std::string("Failed to restorecon ").append(oat_dir);
1768 LOG(ERROR) << *error_msg;
Calin Juravlecb556e32017-04-04 20:22:50 -07001769 return -1;
1770 }
1771 }
1772
Jeff Sharkey90aff262016-12-12 14:28:24 -07001773 // Create a swap file if necessary.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001774 unique_fd swap_fd = maybe_open_dexopt_swap_file(out_oat.path());
Jeff Sharkey90aff262016-12-12 14:28:24 -07001775
Calin Juravle7a570e82017-01-14 16:23:30 -08001776 // Open the reference profile if needed.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001777 UniqueFile reference_profile = maybe_open_reference_profile(
Calin Juravle824a64d2018-01-18 20:23:17 -08001778 pkgname, dex_path, profile_name, profile_guided, is_public, uid, is_secondary_dex);
Calin Juravle7a570e82017-01-14 16:23:30 -08001779
Victor Hsiehcb35a062020-08-13 16:11:13 -07001780 if (reference_profile.fd() == -1) {
liulvping61907742018-08-21 09:36:52 +08001781 // We don't create an app image without reference profile since there is no speedup from
1782 // loading it in that case and instead will be a small overhead.
1783 generate_app_image = false;
1784 }
1785
1786 // Create the app image file if needed.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001787 UniqueFile out_image = maybe_open_app_image(
1788 out_oat.path(), generate_app_image, is_public, uid, is_secondary_dex);
liulvping61907742018-08-21 09:36:52 +08001789
Victor Hsiehcb35a062020-08-13 16:11:13 -07001790 UniqueFile dex_metadata;
Calin Juravle62c5a372018-02-01 17:03:23 +00001791 if (dex_metadata_path != nullptr) {
Victor Hsiehcb35a062020-08-13 16:11:13 -07001792 dex_metadata.reset(TEMP_FAILURE_RETRY(open(dex_metadata_path, O_RDONLY | O_NOFOLLOW)),
1793 dex_metadata_path);
1794 if (dex_metadata.fd() < 0) {
Calin Juravle62c5a372018-02-01 17:03:23 +00001795 PLOG(ERROR) << "Failed to open dex metadata file " << dex_metadata_path;
1796 }
1797 }
1798
Victor Hsieh8948a862020-08-07 11:30:55 -07001799 std::string jitzygote_flag = server_configurable_flags::GetServerConfigurableFlag(
1800 RUNTIME_NATIVE_BOOT_NAMESPACE,
1801 ENABLE_JITZYGOTE_IMAGE,
1802 /*default_value=*/ "");
1803 bool use_jitzygote_image = jitzygote_flag == "true" || IsBootClassPathProfilingEnable();
1804
Victor Hsiehe98e6512020-08-10 15:39:22 -07001805 // Decide whether to use dex2oat64.
1806 bool use_dex2oat64 = false;
1807 // Check whether the device even supports 64-bit ABIs.
1808 if (!GetProperty("ro.product.cpu.abilist64", "").empty()) {
1809 use_dex2oat64 = GetBoolProperty("dalvik.vm.dex2oat64.enabled", false);
1810 }
1811 const char* dex2oat_bin = select_execution_binary(
1812 (use_dex2oat64 ? kDex2oat64Path : kDex2oat32Path),
1813 (use_dex2oat64 ? kDex2oatDebug64Path : kDex2oatDebug32Path),
1814 background_job_compile);
1815
Victor Hsiehc9821f12020-08-07 11:32:29 -07001816 auto execv_helper = std::make_unique<ExecVHelper>();
1817
Andreas Gampe023b2242018-02-28 16:03:25 -08001818 LOG(VERBOSE) << "DexInv: --- BEGIN '" << dex_path << "' ---";
Jeff Sharkey90aff262016-12-12 14:28:24 -07001819
Victor Hsiehc9821f12020-08-07 11:32:29 -07001820 RunDex2Oat runner(dex2oat_bin, execv_helper.get());
Victor Hsiehcb35a062020-08-13 16:11:13 -07001821 runner.Initialize(out_oat,
1822 out_vdex,
1823 out_image,
1824 in_dex,
1825 in_vdex,
1826 dex_metadata,
1827 reference_profile,
1828 class_loader_context,
1829 join_fds(context_input_fds),
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001830 swap_fd.get(),
1831 instruction_set,
1832 compiler_filter,
1833 debuggable,
1834 boot_complete,
Patrick Baumann2271b3e2020-04-14 17:03:00 -07001835 for_restore,
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001836 target_sdk_version,
1837 enable_hidden_api_checks,
1838 generate_compact_dex,
Victor Hsieh8948a862020-08-07 11:30:55 -07001839 use_jitzygote_image,
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001840 compilation_reason);
1841
Jeff Sharkey90aff262016-12-12 14:28:24 -07001842 pid_t pid = fork();
1843 if (pid == 0) {
Wei Wange0dbd9b2020-12-11 17:24:19 +00001844 // Need to set schedpolicy before dropping privileges
1845 // for cgroup migration. See details at b/175178520.
1846 SetDex2OatScheduling(boot_complete);
1847
Jeff Sharkey90aff262016-12-12 14:28:24 -07001848 /* child -- drop privileges before continuing */
1849 drop_capabilities(uid);
1850
Victor Hsiehcb35a062020-08-13 16:11:13 -07001851 if (flock(out_oat.fd(), LOCK_EX | LOCK_NB) != 0) {
Martijn Coenen6de402a2021-04-26 16:23:40 +02001852 async_safe_format_log(ANDROID_LOG_ERROR, LOG_TAG, "flock(%s) failed",
1853 out_oat.path().c_str());
Andreas Gampefa2dadd2018-02-28 19:52:47 -08001854 _exit(DexoptReturnCodes::kFlock);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001855 }
1856
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001857 runner.Exec(DexoptReturnCodes::kDex2oatExec);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001858 } else {
1859 int res = wait_child(pid);
1860 if (res == 0) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001861 LOG(VERBOSE) << "DexInv: --- END '" << dex_path << "' (success) ---";
Jeff Sharkey90aff262016-12-12 14:28:24 -07001862 } else {
Andreas Gampe023b2242018-02-28 16:03:25 -08001863 LOG(VERBOSE) << "DexInv: --- END '" << dex_path << "' --- status=0x"
1864 << std::hex << std::setw(4) << res << ", process failed";
1865 *error_msg = format_dexopt_error(res, dex_path);
Andreas Gampe013f02e2017-03-20 18:36:54 -07001866 return res;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001867 }
1868 }
1869
Jeff Sharkey90aff262016-12-12 14:28:24 -07001870 // We've been successful, don't delete output.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001871 out_oat.DisableCleanup();
1872 out_vdex.DisableCleanup();
1873 out_image.DisableCleanup();
1874 reference_profile.DisableCleanup();
Jeff Sharkey90aff262016-12-12 14:28:24 -07001875
1876 return 0;
1877}
1878
Calin Juravlec9eab382017-01-25 01:17:17 -08001879// Try to remove the given directory. Log an error if the directory exists
1880// and is empty but could not be removed.
1881static bool rmdir_if_empty(const char* dir) {
1882 if (rmdir(dir) == 0) {
1883 return true;
1884 }
1885 if (errno == ENOENT || errno == ENOTEMPTY) {
1886 return true;
1887 }
1888 PLOG(ERROR) << "Failed to remove dir: " << dir;
1889 return false;
1890}
1891
1892// Try to unlink the given file. Log an error if the file exists and could not
1893// be unlinked.
1894static bool unlink_if_exists(const std::string& file) {
1895 if (unlink(file.c_str()) == 0) {
1896 return true;
1897 }
1898 if (errno == ENOENT) {
1899 return true;
1900
1901 }
1902 PLOG(ERROR) << "Could not unlink: " << file;
1903 return false;
1904}
1905
Calin Juravle7d765462017-09-04 15:57:10 -07001906enum ReconcileSecondaryDexResult {
1907 kReconcileSecondaryDexExists = 0,
1908 kReconcileSecondaryDexCleanedUp = 1,
1909 kReconcileSecondaryDexValidationError = 2,
1910 kReconcileSecondaryDexCleanUpError = 3,
1911 kReconcileSecondaryDexAccessIOError = 4,
1912};
Calin Juravlec9eab382017-01-25 01:17:17 -08001913
1914// Reconcile the secondary dex 'dex_path' and its generated oat files.
1915// Return true if all the parameters are valid and the secondary dex file was
1916// processed successfully (i.e. the dex_path either exists, or if not, its corresponding
1917// oat/vdex/art files where deleted successfully). In this case, out_secondary_dex_exists
1918// will be true if the secondary dex file still exists. If the secondary dex file does not exist,
1919// the method cleans up any previously generated compiler artifacts (oat, vdex, art).
1920// Return false if there were errors during processing. In this case
1921// out_secondary_dex_exists will be set to false.
1922bool reconcile_secondary_dex_file(const std::string& dex_path,
1923 const std::string& pkgname, int uid, const std::vector<std::string>& isas,
Jooyung Han9fcc4ef2020-01-23 12:45:10 +09001924 const std::optional<std::string>& volume_uuid, int storage_flag,
Calin Juravlec9eab382017-01-25 01:17:17 -08001925 /*out*/bool* out_secondary_dex_exists) {
Calin Juravle7d765462017-09-04 15:57:10 -07001926 *out_secondary_dex_exists = false; // start by assuming the file does not exist.
Calin Juravlec9eab382017-01-25 01:17:17 -08001927 if (isas.size() == 0) {
1928 LOG(ERROR) << "reconcile_secondary_dex_file called with empty isas vector";
1929 return false;
1930 }
1931
Calin Juravle7d765462017-09-04 15:57:10 -07001932 if (storage_flag != FLAG_STORAGE_CE && storage_flag != FLAG_STORAGE_DE) {
1933 LOG(ERROR) << "reconcile_secondary_dex_file called with invalid storage_flag: "
1934 << storage_flag;
Calin Juravlec9eab382017-01-25 01:17:17 -08001935 return false;
1936 }
1937
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001938 // As a security measure we want to unlink art artifacts with the reduced capabilities
1939 // of the package user id. So we fork and drop capabilities in the child.
1940 pid_t pid = fork();
1941 if (pid == 0) {
Calin Juravle7d765462017-09-04 15:57:10 -07001942 /* child -- drop privileges before continuing */
1943 drop_capabilities(uid);
1944
Jooyung Han9fcc4ef2020-01-23 12:45:10 +09001945 const char* volume_uuid_cstr = volume_uuid ? volume_uuid->c_str() : nullptr;
Greg Kaiser8042c372019-03-26 06:23:19 -07001946 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid_cstr,
Calin Juravle7d765462017-09-04 15:57:10 -07001947 uid, storage_flag)) {
Martijn Coenen6de402a2021-04-26 16:23:40 +02001948 async_safe_format_log(ANDROID_LOG_ERROR, LOG_TAG,
1949 "Could not validate secondary dex path %s", dex_path.c_str());
Calin Juravle7d765462017-09-04 15:57:10 -07001950 _exit(kReconcileSecondaryDexValidationError);
1951 }
1952
1953 SecondaryDexAccess access_check = check_secondary_dex_access(dex_path);
1954 switch (access_check) {
1955 case kSecondaryDexAccessDoesNotExist:
1956 // File does not exist. Proceed with cleaning.
1957 break;
1958 case kSecondaryDexAccessReadOk: _exit(kReconcileSecondaryDexExists);
1959 case kSecondaryDexAccessIOError: _exit(kReconcileSecondaryDexAccessIOError);
1960 case kSecondaryDexAccessPermissionError: _exit(kReconcileSecondaryDexValidationError);
1961 default:
Martijn Coenen6de402a2021-04-26 16:23:40 +02001962 async_safe_format_log(ANDROID_LOG_ERROR, LOG_TAG,
1963 "Unexpected result from check_secondary_dex_access: %d", access_check);
Calin Juravle7d765462017-09-04 15:57:10 -07001964 _exit(kReconcileSecondaryDexValidationError);
1965 }
1966
1967 // The secondary dex does not exist anymore or it's. Clear any generated files.
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001968 char oat_path[PKG_PATH_MAX];
1969 char oat_dir[PKG_PATH_MAX];
1970 char oat_isa_dir[PKG_PATH_MAX];
1971 bool result = true;
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001972 for (size_t i = 0; i < isas.size(); i++) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001973 std::string error_msg;
Calin Juravle7d765462017-09-04 15:57:10 -07001974 if (!create_secondary_dex_oat_layout(
Andreas Gampe194fe422018-02-28 20:16:19 -08001975 dex_path,isas[i], oat_dir, oat_isa_dir, oat_path, &error_msg)) {
Martijn Coenen6de402a2021-04-26 16:23:40 +02001976 async_safe_format_log(ANDROID_LOG_ERROR, LOG_TAG, "%s", error_msg.c_str());
Calin Juravle7d765462017-09-04 15:57:10 -07001977 _exit(kReconcileSecondaryDexValidationError);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001978 }
Calin Juravle51314092017-05-18 15:33:05 -07001979
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001980 // Delete oat/vdex/art files.
1981 result = unlink_if_exists(oat_path) && result;
1982 result = unlink_if_exists(create_vdex_filename(oat_path)) && result;
1983 result = unlink_if_exists(create_image_filename(oat_path)) && result;
Calin Juravlec9eab382017-01-25 01:17:17 -08001984
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001985 // Delete profiles.
1986 std::string current_profile = create_current_profile_path(
Calin Juravle824a64d2018-01-18 20:23:17 -08001987 multiuser_get_user_id(uid), pkgname, dex_path, /*is_secondary*/true);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001988 std::string reference_profile = create_reference_profile_path(
Calin Juravle824a64d2018-01-18 20:23:17 -08001989 pkgname, dex_path, /*is_secondary*/true);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001990 result = unlink_if_exists(current_profile) && result;
1991 result = unlink_if_exists(reference_profile) && result;
Calin Juravle51314092017-05-18 15:33:05 -07001992
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001993 // We upgraded once the location of current profile for secondary dex files.
1994 // Check for any previous left-overs and remove them as well.
1995 std::string old_current_profile = dex_path + ".prof";
1996 result = unlink_if_exists(old_current_profile);
Calin Juravle3760ad32017-07-27 16:31:55 -07001997
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001998 // Try removing the directories as well, they might be empty.
1999 result = rmdir_if_empty(oat_isa_dir) && result;
2000 result = rmdir_if_empty(oat_dir) && result;
2001 }
Calin Juravle7d765462017-09-04 15:57:10 -07002002 if (!result) {
Martijn Coenen6de402a2021-04-26 16:23:40 +02002003 async_safe_format_log(ANDROID_LOG_ERROR, LOG_TAG,
2004 "Could not validate secondary dex path %s", dex_path.c_str());
Calin Juravle7d765462017-09-04 15:57:10 -07002005 }
2006 _exit(result ? kReconcileSecondaryDexCleanedUp : kReconcileSecondaryDexAccessIOError);
Calin Juravlec9eab382017-01-25 01:17:17 -08002007 }
2008
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002009 int return_code = wait_child(pid);
Calin Juravle7d765462017-09-04 15:57:10 -07002010 if (!WIFEXITED(return_code)) {
2011 LOG(WARNING) << "reconcile dex failed for location " << dex_path << ": " << return_code;
2012 } else {
2013 return_code = WEXITSTATUS(return_code);
2014 }
2015
2016 LOG(DEBUG) << "Reconcile secondary dex path " << dex_path << " result=" << return_code;
2017
2018 switch (return_code) {
2019 case kReconcileSecondaryDexCleanedUp:
2020 case kReconcileSecondaryDexValidationError:
2021 // If we couldn't validate assume the dex file does not exist.
2022 // This will purge the entry from the PM records.
2023 *out_secondary_dex_exists = false;
2024 return true;
2025 case kReconcileSecondaryDexExists:
2026 *out_secondary_dex_exists = true;
2027 return true;
2028 case kReconcileSecondaryDexAccessIOError:
2029 // We had an access IO error.
2030 // Return false so that we can try again.
2031 // The value of out_secondary_dex_exists does not matter in this case and by convention
2032 // is set to false.
2033 *out_secondary_dex_exists = false;
2034 return false;
2035 default:
2036 LOG(ERROR) << "Unexpected code from reconcile_secondary_dex_file: " << return_code;
2037 *out_secondary_dex_exists = false;
2038 return false;
2039 }
Calin Juravlec9eab382017-01-25 01:17:17 -08002040}
2041
Alan Stokesa25d90c2017-10-16 10:56:00 +01002042// Compute and return the hash (SHA-256) of the secondary dex file at dex_path.
2043// Returns true if all parameters are valid and the hash successfully computed and stored in
2044// out_secondary_dex_hash.
2045// Also returns true with an empty hash if the file does not currently exist or is not accessible to
2046// the app.
2047// For any other errors (e.g. if any of the parameters are invalid) returns false.
2048bool hash_secondary_dex_file(const std::string& dex_path, const std::string& pkgname, int uid,
Jooyung Han9fcc4ef2020-01-23 12:45:10 +09002049 const std::optional<std::string>& volume_uuid, int storage_flag,
Alan Stokesa25d90c2017-10-16 10:56:00 +01002050 std::vector<uint8_t>* out_secondary_dex_hash) {
2051 out_secondary_dex_hash->clear();
2052
Jooyung Han9fcc4ef2020-01-23 12:45:10 +09002053 const char* volume_uuid_cstr = volume_uuid ? volume_uuid->c_str() : nullptr;
Alan Stokesa25d90c2017-10-16 10:56:00 +01002054
2055 if (storage_flag != FLAG_STORAGE_CE && storage_flag != FLAG_STORAGE_DE) {
2056 LOG(ERROR) << "hash_secondary_dex_file called with invalid storage_flag: "
2057 << storage_flag;
2058 return false;
2059 }
2060
2061 // Pipe to get the hash result back from our child process.
2062 unique_fd pipe_read, pipe_write;
2063 if (!Pipe(&pipe_read, &pipe_write)) {
2064 PLOG(ERROR) << "Failed to create pipe";
2065 return false;
2066 }
2067
2068 // Fork so that actual access to the files is done in the app's own UID, to ensure we only
2069 // access data the app itself can access.
2070 pid_t pid = fork();
2071 if (pid == 0) {
2072 // child -- drop privileges before continuing
2073 drop_capabilities(uid);
2074 pipe_read.reset();
2075
2076 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid_cstr, uid, storage_flag)) {
Martijn Coenen6de402a2021-04-26 16:23:40 +02002077 async_safe_format_log(ANDROID_LOG_ERROR, LOG_TAG,
2078 "Could not validate secondary dex path %s", dex_path.c_str());
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002079 _exit(DexoptReturnCodes::kHashValidatePath);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002080 }
2081
2082 unique_fd fd(TEMP_FAILURE_RETRY(open(dex_path.c_str(), O_RDONLY | O_CLOEXEC | O_NOFOLLOW)));
2083 if (fd == -1) {
2084 if (errno == EACCES || errno == ENOENT) {
2085 // Not treated as an error.
2086 _exit(0);
2087 }
2088 PLOG(ERROR) << "Failed to open secondary dex " << dex_path;
Martijn Coenen6de402a2021-04-26 16:23:40 +02002089 async_safe_format_log(ANDROID_LOG_ERROR, LOG_TAG,
2090 "Failed to open secondary dex %s: %d", dex_path.c_str(), errno);
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002091 _exit(DexoptReturnCodes::kHashOpenPath);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002092 }
2093
2094 SHA256_CTX ctx;
2095 SHA256_Init(&ctx);
2096
2097 std::vector<uint8_t> buffer(65536);
2098 while (true) {
2099 ssize_t bytes_read = TEMP_FAILURE_RETRY(read(fd, buffer.data(), buffer.size()));
2100 if (bytes_read == 0) {
2101 break;
2102 } else if (bytes_read == -1) {
Martijn Coenen6de402a2021-04-26 16:23:40 +02002103 async_safe_format_log(ANDROID_LOG_ERROR, LOG_TAG,
2104 "Failed to read secondary dex %s: %d", dex_path.c_str(), errno);
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002105 _exit(DexoptReturnCodes::kHashReadDex);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002106 }
2107
2108 SHA256_Update(&ctx, buffer.data(), bytes_read);
2109 }
2110
2111 std::array<uint8_t, SHA256_DIGEST_LENGTH> hash;
2112 SHA256_Final(hash.data(), &ctx);
2113 if (!WriteFully(pipe_write, hash.data(), hash.size())) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002114 _exit(DexoptReturnCodes::kHashWrite);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002115 }
2116
2117 _exit(0);
2118 }
2119
2120 // parent
2121 pipe_write.reset();
2122
2123 out_secondary_dex_hash->resize(SHA256_DIGEST_LENGTH);
2124 if (!ReadFully(pipe_read, out_secondary_dex_hash->data(), out_secondary_dex_hash->size())) {
2125 out_secondary_dex_hash->clear();
2126 }
2127 return wait_child(pid) == 0;
2128}
2129
Jeff Sharkey90aff262016-12-12 14:28:24 -07002130// Helper for move_ab, so that we can have common failure-case cleanup.
2131static bool unlink_and_rename(const char* from, const char* to) {
2132 // Check whether "from" exists, and if so whether it's regular. If it is, unlink. Otherwise,
2133 // return a failure.
2134 struct stat s;
2135 if (stat(to, &s) == 0) {
2136 if (!S_ISREG(s.st_mode)) {
2137 LOG(ERROR) << from << " is not a regular file to replace for A/B.";
2138 return false;
2139 }
2140 if (unlink(to) != 0) {
2141 LOG(ERROR) << "Could not unlink " << to << " to move A/B.";
2142 return false;
2143 }
2144 } else {
2145 // This may be a permission problem. We could investigate the error code, but we'll just
2146 // let the rename failure do the work for us.
2147 }
2148
2149 // Try to rename "to" to "from."
2150 if (rename(from, to) != 0) {
2151 PLOG(ERROR) << "Could not rename " << from << " to " << to;
2152 return false;
2153 }
2154 return true;
2155}
2156
2157// Move/rename a B artifact (from) to an A artifact (to).
2158static bool move_ab_path(const std::string& b_path, const std::string& a_path) {
2159 // Check whether B exists.
2160 {
2161 struct stat s;
2162 if (stat(b_path.c_str(), &s) != 0) {
Alex Light9f295662021-02-25 11:50:33 -08002163 // Ignore for now. The service calling this isn't smart enough to
2164 // understand lack of artifacts at the moment.
2165 LOG(VERBOSE) << "A/B artifact " << b_path << " does not exist!";
Jeff Sharkey90aff262016-12-12 14:28:24 -07002166 return false;
2167 }
2168 if (!S_ISREG(s.st_mode)) {
2169 LOG(ERROR) << "A/B artifact " << b_path << " is not a regular file.";
2170 // Try to unlink, but swallow errors.
2171 unlink(b_path.c_str());
2172 return false;
2173 }
2174 }
2175
2176 // Rename B to A.
2177 if (!unlink_and_rename(b_path.c_str(), a_path.c_str())) {
2178 // Delete the b_path so we don't try again (or fail earlier).
2179 if (unlink(b_path.c_str()) != 0) {
2180 PLOG(ERROR) << "Could not unlink " << b_path;
2181 }
2182
2183 return false;
2184 }
2185
2186 return true;
2187}
2188
2189bool move_ab(const char* apk_path, const char* instruction_set, const char* oat_dir) {
2190 // Get the current slot suffix. No suffix, no A/B.
Mathieu Chartier9b2da082018-10-26 13:23:11 -07002191 const std::string slot_suffix = GetProperty("ro.boot.slot_suffix", "");
2192 if (slot_suffix.empty()) {
2193 return false;
2194 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07002195
Mathieu Chartier9b2da082018-10-26 13:23:11 -07002196 if (!ValidateTargetSlotSuffix(slot_suffix)) {
2197 LOG(ERROR) << "Target slot suffix not legal: " << slot_suffix;
2198 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07002199 }
2200
2201 // Validate other inputs.
2202 if (validate_apk_path(apk_path) != 0) {
2203 LOG(ERROR) << "Invalid apk_path: " << apk_path;
2204 return false;
2205 }
2206 if (validate_apk_path(oat_dir) != 0) {
2207 LOG(ERROR) << "Invalid oat_dir: " << oat_dir;
2208 return false;
2209 }
2210
2211 char a_path[PKG_PATH_MAX];
2212 if (!calculate_oat_file_path(a_path, oat_dir, apk_path, instruction_set)) {
2213 return false;
2214 }
2215 const std::string a_vdex_path = create_vdex_filename(a_path);
2216 const std::string a_image_path = create_image_filename(a_path);
2217
2218 // B path = A path + slot suffix.
2219 const std::string b_path = StringPrintf("%s.%s", a_path, slot_suffix.c_str());
2220 const std::string b_vdex_path = StringPrintf("%s.%s", a_vdex_path.c_str(), slot_suffix.c_str());
2221 const std::string b_image_path = StringPrintf("%s.%s",
2222 a_image_path.c_str(),
2223 slot_suffix.c_str());
2224
2225 bool success = true;
2226 if (move_ab_path(b_path, a_path)) {
2227 if (move_ab_path(b_vdex_path, a_vdex_path)) {
2228 // Note: we can live without an app image. As such, ignore failure to move the image file.
2229 // If we decide to require the app image, or the app image being moved correctly,
2230 // then change accordingly.
2231 constexpr bool kIgnoreAppImageFailure = true;
2232
2233 if (!a_image_path.empty()) {
2234 if (!move_ab_path(b_image_path, a_image_path)) {
2235 unlink(a_image_path.c_str());
2236 if (!kIgnoreAppImageFailure) {
2237 success = false;
2238 }
2239 }
2240 }
2241 } else {
2242 // Cleanup: delete B image, ignore errors.
2243 unlink(b_image_path.c_str());
2244 success = false;
2245 }
2246 } else {
2247 // Cleanup: delete B image, ignore errors.
2248 unlink(b_vdex_path.c_str());
2249 unlink(b_image_path.c_str());
2250 success = false;
2251 }
2252 return success;
2253}
2254
2255bool delete_odex(const char* apk_path, const char* instruction_set, const char* oat_dir) {
2256 // Delete the oat/odex file.
2257 char out_path[PKG_PATH_MAX];
Calin Juravle80a21252017-01-17 14:43:25 -08002258 if (!create_oat_out_path(apk_path, instruction_set, oat_dir,
Calin Juravle114f0812017-03-08 19:05:07 -08002259 /*is_secondary_dex*/false, out_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07002260 return false;
2261 }
2262
2263 // In case of a permission failure report the issue. Otherwise just print a warning.
2264 auto unlink_and_check = [](const char* path) -> bool {
2265 int result = unlink(path);
2266 if (result != 0) {
2267 if (errno == EACCES || errno == EPERM) {
2268 PLOG(ERROR) << "Could not unlink " << path;
2269 return false;
2270 }
2271 PLOG(WARNING) << "Could not unlink " << path;
2272 }
2273 return true;
2274 };
2275
2276 // Delete the oat/odex file.
2277 bool return_value_oat = unlink_and_check(out_path);
2278
2279 // Derive and delete the app image.
2280 bool return_value_art = unlink_and_check(create_image_filename(out_path).c_str());
2281
Nicolas Geoffray192fb962017-05-25 13:58:06 +01002282 // Derive and delete the vdex file.
2283 bool return_value_vdex = unlink_and_check(create_vdex_filename(out_path).c_str());
2284
Jeff Sharkey90aff262016-12-12 14:28:24 -07002285 // Report success.
Nicolas Geoffray192fb962017-05-25 13:58:06 +01002286 return return_value_oat && return_value_art && return_value_vdex;
Jeff Sharkey90aff262016-12-12 14:28:24 -07002287}
2288
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06002289static bool is_absolute_path(const std::string& path) {
2290 if (path.find('/') != 0 || path.find("..") != std::string::npos) {
2291 LOG(ERROR) << "Invalid absolute path " << path;
2292 return false;
2293 } else {
2294 return true;
2295 }
2296}
2297
2298static bool is_valid_instruction_set(const std::string& instruction_set) {
2299 // TODO: add explicit whitelisting of instruction sets
2300 if (instruction_set.find('/') != std::string::npos) {
2301 LOG(ERROR) << "Invalid instruction set " << instruction_set;
2302 return false;
2303 } else {
2304 return true;
2305 }
2306}
2307
2308bool calculate_oat_file_path_default(char path[PKG_PATH_MAX], const char *oat_dir,
2309 const char *apk_path, const char *instruction_set) {
2310 std::string oat_dir_ = oat_dir;
2311 std::string apk_path_ = apk_path;
2312 std::string instruction_set_ = instruction_set;
2313
2314 if (!is_absolute_path(oat_dir_)) return false;
2315 if (!is_absolute_path(apk_path_)) return false;
2316 if (!is_valid_instruction_set(instruction_set_)) return false;
2317
2318 std::string::size_type end = apk_path_.rfind('.');
2319 std::string::size_type start = apk_path_.rfind('/', end);
2320 if (end == std::string::npos || start == std::string::npos) {
2321 LOG(ERROR) << "Invalid apk_path " << apk_path_;
2322 return false;
2323 }
2324
2325 std::string res_ = oat_dir_ + '/' + instruction_set + '/'
2326 + apk_path_.substr(start + 1, end - start - 1) + ".odex";
2327 const char* res = res_.c_str();
2328 if (strlen(res) >= PKG_PATH_MAX) {
2329 LOG(ERROR) << "Result too large";
2330 return false;
2331 } else {
2332 strlcpy(path, res, PKG_PATH_MAX);
2333 return true;
2334 }
2335}
2336
2337bool calculate_odex_file_path_default(char path[PKG_PATH_MAX], const char *apk_path,
2338 const char *instruction_set) {
2339 std::string apk_path_ = apk_path;
2340 std::string instruction_set_ = instruction_set;
2341
2342 if (!is_absolute_path(apk_path_)) return false;
2343 if (!is_valid_instruction_set(instruction_set_)) return false;
2344
2345 std::string::size_type end = apk_path_.rfind('.');
2346 std::string::size_type start = apk_path_.rfind('/', end);
2347 if (end == std::string::npos || start == std::string::npos) {
2348 LOG(ERROR) << "Invalid apk_path " << apk_path_;
2349 return false;
2350 }
2351
2352 std::string oat_dir = apk_path_.substr(0, start + 1) + "oat";
2353 return calculate_oat_file_path_default(path, oat_dir.c_str(), apk_path, instruction_set);
2354}
2355
2356bool create_cache_path_default(char path[PKG_PATH_MAX], const char *src,
2357 const char *instruction_set) {
2358 std::string src_ = src;
2359 std::string instruction_set_ = instruction_set;
2360
2361 if (!is_absolute_path(src_)) return false;
2362 if (!is_valid_instruction_set(instruction_set_)) return false;
2363
2364 for (auto it = src_.begin() + 1; it < src_.end(); ++it) {
2365 if (*it == '/') {
2366 *it = '@';
2367 }
2368 }
2369
2370 std::string res_ = android_data_dir + DALVIK_CACHE + '/' + instruction_set_ + src_
2371 + DALVIK_CACHE_POSTFIX;
2372 const char* res = res_.c_str();
2373 if (strlen(res) >= PKG_PATH_MAX) {
2374 LOG(ERROR) << "Result too large";
2375 return false;
2376 } else {
2377 strlcpy(path, res, PKG_PATH_MAX);
2378 return true;
2379 }
2380}
2381
Calin Juravle59f7ab82018-04-27 17:50:23 -07002382bool open_classpath_files(const std::string& classpath, std::vector<unique_fd>* apk_fds,
2383 std::vector<std::string>* dex_locations) {
Calin Juravle0d0a4922018-01-23 19:54:11 -08002384 std::vector<std::string> classpaths_elems = base::Split(classpath, ":");
2385 for (const std::string& elem : classpaths_elems) {
2386 unique_fd fd(TEMP_FAILURE_RETRY(open(elem.c_str(), O_RDONLY)));
2387 if (fd < 0) {
2388 PLOG(ERROR) << "Could not open classpath elem " << elem;
2389 return false;
2390 } else {
2391 apk_fds->push_back(std::move(fd));
Calin Juravle59f7ab82018-04-27 17:50:23 -07002392 dex_locations->push_back(elem);
Calin Juravle0d0a4922018-01-23 19:54:11 -08002393 }
2394 }
2395 return true;
2396}
2397
2398static bool create_app_profile_snapshot(int32_t app_id,
2399 const std::string& package_name,
2400 const std::string& profile_name,
2401 const std::string& classpath) {
Calin Juravle29591732017-11-20 17:46:19 -08002402 int app_shared_gid = multiuser_get_shared_gid(/*user_id*/ 0, app_id);
2403
Calin Juravle824a64d2018-01-18 20:23:17 -08002404 unique_fd snapshot_fd = open_spnashot_profile(AID_SYSTEM, package_name, profile_name);
Calin Juravle29591732017-11-20 17:46:19 -08002405 if (snapshot_fd < 0) {
2406 return false;
2407 }
2408
2409 std::vector<unique_fd> profiles_fd;
2410 unique_fd reference_profile_fd;
Calin Juravle824a64d2018-01-18 20:23:17 -08002411 open_profile_files(app_shared_gid, package_name, profile_name, /*is_secondary_dex*/ false,
2412 &profiles_fd, &reference_profile_fd);
Calin Juravle29591732017-11-20 17:46:19 -08002413 if (profiles_fd.empty() || (reference_profile_fd.get() < 0)) {
2414 return false;
2415 }
2416
2417 profiles_fd.push_back(std::move(reference_profile_fd));
2418
Calin Juravle0d0a4922018-01-23 19:54:11 -08002419 // Open the class paths elements. These will be used to filter out profile data that does
2420 // not belong to the classpath during merge.
2421 std::vector<unique_fd> apk_fds;
Calin Juravle59f7ab82018-04-27 17:50:23 -07002422 std::vector<std::string> dex_locations;
2423 if (!open_classpath_files(classpath, &apk_fds, &dex_locations)) {
Calin Juravle0d0a4922018-01-23 19:54:11 -08002424 return false;
2425 }
2426
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002427 RunProfman args;
Calin Juravlef85ddb92020-05-01 14:05:40 -07002428 // This is specifically a snapshot for an app, so don't use boot image profiles.
2429 args.SetupMerge(profiles_fd,
2430 snapshot_fd,
2431 apk_fds,
2432 dex_locations,
2433 /* for_snapshot= */ true,
2434 /* for_boot_image= */ false);
Calin Juravle29591732017-11-20 17:46:19 -08002435 pid_t pid = fork();
2436 if (pid == 0) {
2437 /* child -- drop privileges before continuing */
2438 drop_capabilities(app_shared_gid);
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002439 args.Exec();
Calin Juravle29591732017-11-20 17:46:19 -08002440 }
2441
2442 /* parent */
2443 int return_code = wait_child(pid);
2444 if (!WIFEXITED(return_code)) {
Calin Juravle824a64d2018-01-18 20:23:17 -08002445 LOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
Calin Juravle29591732017-11-20 17:46:19 -08002446 return false;
2447 }
2448
Calin Juravle78728f32019-11-08 17:55:46 -08002449 // Verify that profman finished successfully.
2450 int profman_code = WEXITSTATUS(return_code);
2451 if (profman_code != PROFMAN_BIN_RETURN_CODE_SUCCESS) {
2452 LOG(WARNING) << "profman error for " << package_name << ":" << profile_name
2453 << ":" << profman_code;
2454 return false;
2455 }
Calin Juravle29591732017-11-20 17:46:19 -08002456 return true;
2457}
2458
Calin Juravle0d0a4922018-01-23 19:54:11 -08002459static bool create_boot_image_profile_snapshot(const std::string& package_name,
2460 const std::string& profile_name,
2461 const std::string& classpath) {
2462 // The reference profile directory for the android package might not be prepared. Do it now.
2463 const std::string ref_profile_dir =
2464 create_primary_reference_profile_package_dir_path(package_name);
2465 if (fs_prepare_dir(ref_profile_dir.c_str(), 0770, AID_SYSTEM, AID_SYSTEM) != 0) {
2466 PLOG(ERROR) << "Failed to prepare " << ref_profile_dir;
2467 return false;
2468 }
2469
Mathieu Chartiere0d64a12018-11-01 12:07:26 -07002470 // Return false for empty class path since it may otherwise return true below if profiles is
2471 // empty.
2472 if (classpath.empty()) {
2473 PLOG(ERROR) << "Class path is empty";
2474 return false;
2475 }
2476
Calin Juravle0d0a4922018-01-23 19:54:11 -08002477 // Open and create the snapshot profile.
2478 unique_fd snapshot_fd = open_spnashot_profile(AID_SYSTEM, package_name, profile_name);
2479
2480 // Collect all non empty profiles.
2481 // The collection will traverse all applications profiles and find the non empty files.
2482 // This has the potential of inspecting a large number of files and directories (depending
2483 // on the number of applications and users). So there is a slight increase in the chance
2484 // to get get occasionally I/O errors (e.g. for opening the file). When that happens do not
2485 // fail the snapshot and aggregate whatever profile we could open.
2486 //
2487 // The profile snapshot is a best effort based on available data it's ok if some data
2488 // from some apps is missing. It will be counter productive for the snapshot to fail
2489 // because we could not open or read some of the files.
2490 std::vector<std::string> profiles;
2491 if (!collect_profiles(&profiles)) {
2492 LOG(WARNING) << "There were errors while collecting the profiles for the boot image.";
2493 }
2494
2495 // If we have no profiles return early.
2496 if (profiles.empty()) {
2497 return true;
2498 }
2499
2500 // Open the classpath elements. These will be used to filter out profile data that does
2501 // not belong to the classpath during merge.
2502 std::vector<unique_fd> apk_fds;
Calin Juravle59f7ab82018-04-27 17:50:23 -07002503 std::vector<std::string> dex_locations;
2504 if (!open_classpath_files(classpath, &apk_fds, &dex_locations)) {
Calin Juravle0d0a4922018-01-23 19:54:11 -08002505 return false;
2506 }
2507
2508 // If we could not open any files from the classpath return an error.
2509 if (apk_fds.empty()) {
2510 LOG(ERROR) << "Could not open any of the classpath elements.";
2511 return false;
2512 }
2513
2514 // Aggregate the profiles in batches of kAggregationBatchSize.
2515 // We do this to avoid opening a huge a amount of files.
2516 static constexpr size_t kAggregationBatchSize = 10;
2517
Calin Juravle0d0a4922018-01-23 19:54:11 -08002518 for (size_t i = 0; i < profiles.size(); ) {
Calin Juravlea64fb512019-11-06 16:11:14 -08002519 std::vector<unique_fd> profiles_fd;
Calin Juravle0d0a4922018-01-23 19:54:11 -08002520 for (size_t k = 0; k < kAggregationBatchSize && i < profiles.size(); k++, i++) {
Calin Juravlee01f8712021-06-03 18:16:54 -07002521 unique_fd fd = open_profile(AID_SYSTEM, profiles[i], O_RDONLY, /*mode=*/ 0);
Calin Juravle0d0a4922018-01-23 19:54:11 -08002522 if (fd.get() >= 0) {
2523 profiles_fd.push_back(std::move(fd));
2524 }
2525 }
Calin Juravlea64fb512019-11-06 16:11:14 -08002526
2527 // We aggregate (read & write) into the same fd multiple times in a row.
2528 // We need to reset the cursor every time to ensure we read the whole file every time.
2529 if (TEMP_FAILURE_RETRY(lseek(snapshot_fd, 0, SEEK_SET)) == static_cast<off_t>(-1)) {
2530 PLOG(ERROR) << "Cannot reset position for snapshot profile";
2531 return false;
2532 }
2533
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002534 RunProfman args;
Calin Juravleb3a929d2018-12-11 14:40:00 -08002535 args.SetupMerge(profiles_fd,
2536 snapshot_fd,
2537 apk_fds,
Calin Juravle78728f32019-11-08 17:55:46 -08002538 dex_locations,
2539 /*for_snapshot=*/true,
2540 /*for_boot_image=*/true);
Calin Juravle0d0a4922018-01-23 19:54:11 -08002541 pid_t pid = fork();
2542 if (pid == 0) {
2543 /* child -- drop privileges before continuing */
2544 drop_capabilities(AID_SYSTEM);
2545
Calin Juravle59f7ab82018-04-27 17:50:23 -07002546 // The introduction of new access flags into boot jars causes them to
2547 // fail dex file verification.
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002548 args.Exec();
Calin Juravle0d0a4922018-01-23 19:54:11 -08002549 }
2550
2551 /* parent */
2552 int return_code = wait_child(pid);
Calin Juravlea64fb512019-11-06 16:11:14 -08002553
Calin Juravle0d0a4922018-01-23 19:54:11 -08002554 if (!WIFEXITED(return_code)) {
2555 PLOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
2556 return false;
2557 }
Calin Juravlea64fb512019-11-06 16:11:14 -08002558
2559 // Verify that profman finished successfully.
2560 int profman_code = WEXITSTATUS(return_code);
Calin Juravle78728f32019-11-08 17:55:46 -08002561 if (profman_code != PROFMAN_BIN_RETURN_CODE_SUCCESS) {
2562 LOG(WARNING) << "profman error for " << package_name << ":" << profile_name
2563 << ":" << profman_code;
2564 return false;
Calin Juravlea64fb512019-11-06 16:11:14 -08002565 }
Calin Juravle0d0a4922018-01-23 19:54:11 -08002566 }
Calin Juravlea64fb512019-11-06 16:11:14 -08002567
Calin Juravle0d0a4922018-01-23 19:54:11 -08002568 return true;
2569}
2570
2571bool create_profile_snapshot(int32_t app_id, const std::string& package_name,
2572 const std::string& profile_name, const std::string& classpath) {
2573 if (app_id == -1) {
2574 return create_boot_image_profile_snapshot(package_name, profile_name, classpath);
2575 } else {
2576 return create_app_profile_snapshot(app_id, package_name, profile_name, classpath);
2577 }
2578}
2579
Calin Juravlec3b049e2018-01-18 22:32:58 -08002580bool prepare_app_profile(const std::string& package_name,
2581 userid_t user_id,
2582 appid_t app_id,
2583 const std::string& profile_name,
Calin Juravlef63d4792018-01-30 17:43:34 +00002584 const std::string& code_path,
Jooyung Han9fcc4ef2020-01-23 12:45:10 +09002585 const std::optional<std::string>& dex_metadata) {
Calin Juravlec3b049e2018-01-18 22:32:58 -08002586 // Prepare the current profile.
2587 std::string cur_profile = create_current_profile_path(user_id, package_name, profile_name,
2588 /*is_secondary_dex*/ false);
2589 uid_t uid = multiuser_get_uid(user_id, app_id);
2590 if (fs_prepare_file_strict(cur_profile.c_str(), 0600, uid, uid) != 0) {
2591 PLOG(ERROR) << "Failed to prepare " << cur_profile;
2592 return false;
2593 }
2594
2595 // Check if we need to install the profile from the dex metadata.
Jooyung Han9fcc4ef2020-01-23 12:45:10 +09002596 if (!dex_metadata) {
Calin Juravlec3b049e2018-01-18 22:32:58 -08002597 return true;
2598 }
2599
2600 // We have a dex metdata. Merge the profile into the reference profile.
2601 unique_fd ref_profile_fd = open_reference_profile(uid, package_name, profile_name,
2602 /*read_write*/ true, /*is_secondary_dex*/ false);
2603 unique_fd dex_metadata_fd(TEMP_FAILURE_RETRY(
2604 open(dex_metadata->c_str(), O_RDONLY | O_NOFOLLOW)));
Calin Juravlef63d4792018-01-30 17:43:34 +00002605 unique_fd apk_fd(TEMP_FAILURE_RETRY(open(code_path.c_str(), O_RDONLY | O_NOFOLLOW)));
2606 if (apk_fd < 0) {
2607 PLOG(ERROR) << "Could not open code path " << code_path;
2608 return false;
2609 }
Calin Juravlec3b049e2018-01-18 22:32:58 -08002610
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002611 RunProfman args;
2612 args.SetupCopyAndUpdate(std::move(dex_metadata_fd),
2613 std::move(ref_profile_fd),
2614 std::move(apk_fd),
2615 code_path);
Calin Juravlec3b049e2018-01-18 22:32:58 -08002616 pid_t pid = fork();
2617 if (pid == 0) {
2618 /* child -- drop privileges before continuing */
2619 gid_t app_shared_gid = multiuser_get_shared_gid(user_id, app_id);
2620 drop_capabilities(app_shared_gid);
2621
Calin Juravlef63d4792018-01-30 17:43:34 +00002622 // The copy and update takes ownership over the fds.
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002623 args.Exec();
Calin Juravlec3b049e2018-01-18 22:32:58 -08002624 }
2625
2626 /* parent */
2627 int return_code = wait_child(pid);
2628 if (!WIFEXITED(return_code)) {
2629 PLOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
2630 return false;
2631 }
2632 return true;
2633}
2634
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07002635} // namespace installd
2636} // namespace android