blob: 616c3b268790cf9cdd6001166ab0929e96a170ad [file] [log] [blame]
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07001/*
2 * Copyright (C) 2016 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
Alan Stokescb27c342018-04-20 17:09:25 +010016#define LOG_TAG "installd"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070017
Alan Stokesa25d90c2017-10-16 10:56:00 +010018#include <array>
Jeff Sharkey90aff262016-12-12 14:28:24 -070019#include <fcntl.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070020#include <stdlib.h>
21#include <string.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070022#include <sys/capability.h>
23#include <sys/file.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070024#include <sys/stat.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070025#include <sys/time.h>
26#include <sys/types.h>
27#include <sys/resource.h>
28#include <sys/wait.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070029#include <unistd.h>
30
Andreas Gampe023b2242018-02-28 16:03:25 -080031#include <iomanip>
32
Alan Stokesa25d90c2017-10-16 10:56:00 +010033#include <android-base/file.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070034#include <android-base/logging.h>
Andreas Gampe6a9cf722017-07-24 16:49:10 -070035#include <android-base/properties.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070036#include <android-base/stringprintf.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070037#include <android-base/strings.h>
38#include <android-base/unique_fd.h>
Calin Juravle80a21252017-01-17 14:43:25 -080039#include <cutils/fs.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070040#include <cutils/properties.h>
41#include <cutils/sched_policy.h>
Andreas Gampefa2dadd2018-02-28 19:52:47 -080042#include <dex2oat_return_codes.h>
Mark Salyzyn7823e122016-09-29 08:08:05 -070043#include <log/log.h> // TODO: Move everything to base/logging.
Alan Stokesa25d90c2017-10-16 10:56:00 +010044#include <openssl/sha.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070045#include <private/android_filesystem_config.h>
Suren Baghdasaryan1cc5de62019-01-25 05:29:23 +000046#include <processgroup/sched_policy.h>
Calin Juravlecb556e32017-04-04 20:22:50 -070047#include <selinux/android.h>
Nicolas Geoffrayaaad21e2019-02-25 13:31:10 +000048#include <server_configurable_flags/get_flags.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070049#include <system/thread_defs.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070050
51#include "dexopt.h"
Andreas Gampefa2dadd2018-02-28 19:52:47 -080052#include "dexopt_return_codes.h"
Jeff Sharkeyc1149c92017-09-21 14:51:09 -060053#include "globals.h"
Jeff Sharkey90aff262016-12-12 14:28:24 -070054#include "installd_deps.h"
55#include "otapreopt_utils.h"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070056#include "utils.h"
57
Jeff Sharkey90aff262016-12-12 14:28:24 -070058using android::base::EndsWith;
Mathieu Chartier9b2da082018-10-26 13:23:11 -070059using android::base::GetBoolProperty;
60using android::base::GetProperty;
David Brazdil4f6027a2019-03-19 11:44:21 +000061using android::base::ReadFdToString;
Alan Stokesa25d90c2017-10-16 10:56:00 +010062using android::base::ReadFully;
63using android::base::StringPrintf;
64using android::base::WriteFully;
Calin Juravle1a0af3b2017-03-09 14:33:33 -080065using android::base::unique_fd;
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070066
67namespace android {
68namespace installd {
69
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -070070// Should minidebug info be included in compiled artifacts? Even if this value is
71// "true," usage might still be conditional to other constraints, e.g., system
72// property overrides.
73static constexpr bool kEnableMinidebugInfo = true;
74
75static constexpr const char* kMinidebugInfoSystemProperty = "dalvik.vm.dex2oat-minidebuginfo";
76static constexpr bool kMinidebugInfoSystemPropertyDefault = false;
77static constexpr const char* kMinidebugDex2oatFlag = "--generate-mini-debug-info";
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -080078static constexpr const char* kDisableCompactDexFlag = "--compact-dex-level=none";
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -070079
Andreas Gampefa2dadd2018-02-28 19:52:47 -080080
Calin Juravle114f0812017-03-08 19:05:07 -080081// Deleter using free() for use with std::unique_ptr<>. See also UniqueCPtr<> below.
82struct FreeDelete {
83 // NOTE: Deleting a const object is valid but free() takes a non-const pointer.
84 void operator()(const void* ptr) const {
85 free(const_cast<void*>(ptr));
86 }
87};
88
89// Alias for std::unique_ptr<> that uses the C function free() to delete objects.
90template <typename T>
91using UniqueCPtr = std::unique_ptr<T, FreeDelete>;
92
Calin Juravle1a0af3b2017-03-09 14:33:33 -080093static unique_fd invalid_unique_fd() {
94 return unique_fd(-1);
95}
96
Andreas Gampe6a9cf722017-07-24 16:49:10 -070097static bool is_debug_runtime() {
98 return android::base::GetProperty("persist.sys.dalvik.vm.lib.2", "") == "libartd.so";
99}
100
David Sehra3b5ab62017-10-25 14:27:29 -0700101static bool is_debuggable_build() {
102 return android::base::GetBoolProperty("ro.debuggable", false);
103}
104
Jeff Sharkey90aff262016-12-12 14:28:24 -0700105static bool clear_profile(const std::string& profile) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800106 unique_fd ufd(open(profile.c_str(), O_WRONLY | O_NOFOLLOW | O_CLOEXEC));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700107 if (ufd.get() < 0) {
108 if (errno != ENOENT) {
109 PLOG(WARNING) << "Could not open profile " << profile;
110 return false;
111 } else {
112 // Nothing to clear. That's ok.
113 return true;
114 }
115 }
116
117 if (flock(ufd.get(), LOCK_EX | LOCK_NB) != 0) {
118 if (errno != EWOULDBLOCK) {
119 PLOG(WARNING) << "Error locking profile " << profile;
120 }
121 // This implies that the app owning this profile is running
122 // (and has acquired the lock).
123 //
124 // If we can't acquire the lock bail out since clearing is useless anyway
125 // (the app will write again to the profile).
126 //
127 // Note:
128 // This does not impact the this is not an issue for the profiling correctness.
129 // In case this is needed because of an app upgrade, profiles will still be
130 // eventually cleared by the app itself due to checksum mismatch.
131 // If this is needed because profman advised, then keeping the data around
132 // until the next run is again not an issue.
133 //
134 // If the app attempts to acquire a lock while we've held one here,
135 // it will simply skip the current write cycle.
136 return false;
137 }
138
139 bool truncated = ftruncate(ufd.get(), 0) == 0;
140 if (!truncated) {
141 PLOG(WARNING) << "Could not truncate " << profile;
142 }
143 if (flock(ufd.get(), LOCK_UN) != 0) {
144 PLOG(WARNING) << "Error unlocking profile " << profile;
145 }
146 return truncated;
147}
148
Calin Juravle114f0812017-03-08 19:05:07 -0800149// Clear the reference profile for the given location.
Calin Juravle824a64d2018-01-18 20:23:17 -0800150// The location is the profile name for primary apks or the dex path for secondary dex files.
151static bool clear_reference_profile(const std::string& package_name, const std::string& location,
152 bool is_secondary_dex) {
153 return clear_profile(create_reference_profile_path(package_name, location, is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700154}
155
Calin Juravle114f0812017-03-08 19:05:07 -0800156// Clear the reference profile for the given location.
Calin Juravle824a64d2018-01-18 20:23:17 -0800157// The location is the profile name for primary apks or the dex path for secondary dex files.
158static bool clear_current_profile(const std::string& package_name, const std::string& location,
159 userid_t user, bool is_secondary_dex) {
160 return clear_profile(create_current_profile_path(user, package_name, location,
161 is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700162}
163
Calin Juravle114f0812017-03-08 19:05:07 -0800164// Clear the reference profile for the primary apk of the given package.
Calin Juravle824a64d2018-01-18 20:23:17 -0800165// The location is the profile name for primary apks or the dex path for secondary dex files.
166bool clear_primary_reference_profile(const std::string& package_name,
167 const std::string& location) {
168 return clear_reference_profile(package_name, location, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800169}
170
171// Clear all current profile for the primary apk of the given package.
Calin Juravle824a64d2018-01-18 20:23:17 -0800172// The location is the profile name for primary apks or the dex path for secondary dex files.
173bool clear_primary_current_profiles(const std::string& package_name, const std::string& location) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700174 bool success = true;
Calin Juravle114f0812017-03-08 19:05:07 -0800175 // For secondary dex files, we don't really need the user but we use it for sanity checks.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700176 std::vector<userid_t> users = get_known_users(/*volume_uuid*/ nullptr);
177 for (auto user : users) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800178 success &= clear_current_profile(package_name, location, user, /*is_secondary_dex*/false);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700179 }
180 return success;
181}
182
Calin Juravle114f0812017-03-08 19:05:07 -0800183// Clear the current profile for the primary apk of the given package and user.
Calin Juravle824a64d2018-01-18 20:23:17 -0800184bool clear_primary_current_profile(const std::string& package_name, const std::string& location,
185 userid_t user) {
186 return clear_current_profile(package_name, location, user, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800187}
188
Mathieu Chartier9b2da082018-10-26 13:23:11 -0700189static std::vector<std::string> SplitBySpaces(const std::string& str) {
190 if (str.empty()) {
191 return {};
192 }
193 return android::base::Split(str, " ");
Jeff Sharkey90aff262016-12-12 14:28:24 -0700194}
195
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700196static const char* get_location_from_path(const char* path) {
197 static constexpr char kLocationSeparator = '/';
198 const char *location = strrchr(path, kLocationSeparator);
Yi Kong954cf642018-07-17 16:16:24 -0700199 if (location == nullptr) {
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700200 return path;
201 } else {
202 // Skip the separator character.
203 return location + 1;
204 }
205}
206
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800207// ExecVHelper prepares and holds pointers to parsed command line arguments so that no allocations
208// need to be performed between the fork and exec.
209class ExecVHelper {
210 public:
211 // Store a placeholder for the binary name.
212 ExecVHelper() : args_(1u, std::string()) {}
Mathieu Chartier62d218d2018-11-05 09:34:24 -0800213
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800214 void PrepareArgs(const std::string& bin) {
215 CHECK(!args_.empty());
216 CHECK(args_[0].empty());
217 args_[0] = bin;
218 // Write char* into array.
219 for (const std::string& arg : args_) {
220 argv_.push_back(arg.c_str());
221 }
222 argv_.push_back(nullptr); // Add null terminator.
Mathieu Chartier62d218d2018-11-05 09:34:24 -0800223 }
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800224
225 [[ noreturn ]]
226 void Exec(int exit_code) {
227 execv(argv_[0], (char * const *)&argv_[0]);
228 PLOG(ERROR) << "execv(" << argv_[0] << ") failed";
229 exit(exit_code);
230 }
231
232 // Add an arg if it's not empty.
233 void AddArg(const std::string& arg) {
234 if (!arg.empty()) {
235 args_.push_back(arg);
236 }
237 }
238
239 // Add a runtime arg if it's not empty.
240 void AddRuntimeArg(const std::string& arg) {
241 if (!arg.empty()) {
242 args_.push_back("--runtime-arg");
243 args_.push_back(arg);
244 }
245 }
246
247 protected:
248 // Holder arrays for backing arg storage.
249 std::vector<std::string> args_;
250
251 // Argument poiners.
252 std::vector<const char*> argv_;
253};
Mathieu Chartier9b2da082018-10-26 13:23:11 -0700254
255static std::string MapPropertyToArg(const std::string& property,
256 const std::string& format,
257 const std::string& default_value = "") {
258 std::string prop = GetProperty(property, default_value);
259 if (!prop.empty()) {
260 return StringPrintf(format.c_str(), prop.c_str());
261 }
262 return "";
263}
264
Calin Juravlef74a7372019-02-28 20:29:41 -0800265// Determines which binary we should use for execution (the debug or non-debug version).
266// e.g. dex2oatd vs dex2oat
267static const char* select_execution_binary(const char* binary, const char* debug_binary,
268 bool background_job_compile) {
269 return select_execution_binary(
270 binary,
271 debug_binary,
272 background_job_compile,
273 is_debug_runtime(),
274 (android::base::GetProperty("ro.build.version.codename", "") == "REL"),
275 is_debuggable_build());
276}
277
278// Determines which binary we should use for execution (the debug or non-debug version).
279// e.g. dex2oatd vs dex2oat
280// This is convenient method which is much easier to test because it doesn't read
281// system properties.
282const char* select_execution_binary(
283 const char* binary,
284 const char* debug_binary,
285 bool background_job_compile,
286 bool is_debug_runtime,
287 bool is_release,
288 bool is_debuggable_build) {
289 // Do not use debug binaries for release candidates (to give more soak time).
290 bool is_debug_bg_job = background_job_compile && is_debuggable_build && !is_release;
291
292 // If the runtime was requested to use libartd.so, we'll run the debug version - assuming
293 // the file is present (it may not be on images with very little space available).
294 bool useDebug = (is_debug_runtime || is_debug_bg_job) && (access(debug_binary, X_OK) == 0);
295
296 return useDebug ? debug_binary : binary;
297}
298
Nicolas Geoffrayaaad21e2019-02-25 13:31:10 +0000299// Namespace for Android Runtime flags applied during boot time.
300static const char* RUNTIME_NATIVE_BOOT_NAMESPACE = "runtime_native_boot";
301// Feature flag name for running the JIT in Zygote experiment, b/119800099.
302static const char* ENABLE_APEX_IMAGE = "enable_apex_image";
303// Location of the apex image.
304static const char* kApexImage = "/system/framework/apex.art";
305
Mathieu Chartiere97261e2019-10-01 15:36:01 -0700306// Phenotype property name for enabling profiling the boot class path.
307static const char* PROFILE_BOOT_CLASS_PATH = "profilebootclasspath";
308
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800309class RunDex2Oat : public ExecVHelper {
310 public:
311 RunDex2Oat(int zip_fd,
312 int oat_fd,
313 int input_vdex_fd,
314 int output_vdex_fd,
315 int image_fd,
316 const char* input_file_name,
317 const char* output_file_name,
318 int swap_fd,
319 const char* instruction_set,
320 const char* compiler_filter,
321 bool debuggable,
322 bool post_bootcomplete,
323 bool background_job_compile,
324 int profile_fd,
325 const char* class_loader_context,
David Brazdil4f6027a2019-03-19 11:44:21 +0000326 const std::string& class_loader_context_fds,
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800327 int target_sdk_version,
328 bool enable_hidden_api_checks,
329 bool generate_compact_dex,
330 int dex_metadata_fd,
331 const char* compilation_reason) {
332 // Get the relative path to the input file.
333 const char* relative_input_file_name = get_location_from_path(input_file_name);
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700334
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800335 std::string dex2oat_Xms_arg = MapPropertyToArg("dalvik.vm.dex2oat-Xms", "-Xms%s");
336 std::string dex2oat_Xmx_arg = MapPropertyToArg("dalvik.vm.dex2oat-Xmx", "-Xmx%s");
Jeff Sharkey90aff262016-12-12 14:28:24 -0700337
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800338 const char* threads_property = post_bootcomplete
339 ? "dalvik.vm.dex2oat-threads"
340 : "dalvik.vm.boot-dex2oat-threads";
341 std::string dex2oat_threads_arg = MapPropertyToArg(threads_property, "-j%s");
Jeff Sharkey90aff262016-12-12 14:28:24 -0700342
Nicolas Geoffrayab0a1902019-02-22 21:42:45 +0000343 std::string bootclasspath;
344 char* dex2oat_bootclasspath = getenv("DEX2OATBOOTCLASSPATH");
345 if (dex2oat_bootclasspath != nullptr) {
346 bootclasspath = StringPrintf("-Xbootclasspath:%s", dex2oat_bootclasspath);
347 }
348 // If DEX2OATBOOTCLASSPATH is not in the environment, dex2oat is going to query
349 // BOOTCLASSPATH.
350
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800351 const std::string dex2oat_isa_features_key =
352 StringPrintf("dalvik.vm.isa.%s.features", instruction_set);
353 std::string instruction_set_features_arg =
354 MapPropertyToArg(dex2oat_isa_features_key, "--instruction-set-features=%s");
Jeff Sharkey90aff262016-12-12 14:28:24 -0700355
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800356 const std::string dex2oat_isa_variant_key =
357 StringPrintf("dalvik.vm.isa.%s.variant", instruction_set);
358 std::string instruction_set_variant_arg =
359 MapPropertyToArg(dex2oat_isa_variant_key, "--instruction-set-variant=%s");
Jeff Sharkey90aff262016-12-12 14:28:24 -0700360
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800361 const char* dex2oat_norelocation = "-Xnorelocate";
Jeff Sharkey90aff262016-12-12 14:28:24 -0700362
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800363 const std::string dex2oat_flags = GetProperty("dalvik.vm.dex2oat-flags", "");
364 std::vector<std::string> dex2oat_flags_args = SplitBySpaces(dex2oat_flags);
365 ALOGV("dalvik.vm.dex2oat-flags=%s\n", dex2oat_flags.c_str());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700366
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800367 // If we are booting without the real /data, don't spend time compiling.
368 std::string vold_decrypt = GetProperty("vold.decrypt", "");
369 bool skip_compilation = vold_decrypt == "trigger_restart_min_framework" ||
370 vold_decrypt == "1";
Jeff Sharkey90aff262016-12-12 14:28:24 -0700371
Mathieu Chartierd41622c2019-01-31 12:59:39 -0800372 std::string resolve_startup_string_arg =
373 MapPropertyToArg("persist.device_config.runtime.dex2oat_resolve_startup_strings",
374 "--resolve-startup-const-strings=%s");
375 if (resolve_startup_string_arg.empty()) {
376 // If empty, fall back to system property.
377 resolve_startup_string_arg =
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800378 MapPropertyToArg("dalvik.vm.dex2oat-resolve-startup-strings",
379 "--resolve-startup-const-strings=%s");
Mathieu Chartierd41622c2019-01-31 12:59:39 -0800380 }
Mathieu Chartier5880c032018-11-28 19:15:41 -0800381
382 const std::string image_block_size_arg =
383 MapPropertyToArg("dalvik.vm.dex2oat-max-image-block-size",
384 "--max-image-block-size=%s");
385
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800386 const bool generate_debug_info = GetBoolProperty("debug.generate-debug-info", false);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700387
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800388 std::string image_format_arg;
389 if (image_fd >= 0) {
390 image_format_arg = MapPropertyToArg("dalvik.vm.appimageformat", "--image-format=%s");
Mathieu Chartier31636522018-11-09 23:53:07 +0000391 }
Mathieu Chartier31636522018-11-09 23:53:07 +0000392
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800393 std::string dex2oat_large_app_threshold_arg =
394 MapPropertyToArg("dalvik.vm.dex2oat-very-large", "--very-large-app-threshold=%s");
Mathieu Chartier31636522018-11-09 23:53:07 +0000395
Calin Juravlef74a7372019-02-28 20:29:41 -0800396
397 const char* dex2oat_bin = select_execution_binary(
398 kDex2oatPath, kDex2oatDebugPath, background_job_compile);
Mathieu Chartier31636522018-11-09 23:53:07 +0000399
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800400 bool generate_minidebug_info = kEnableMinidebugInfo &&
401 GetBoolProperty(kMinidebugInfoSystemProperty, kMinidebugInfoSystemPropertyDefault);
Mathieu Chartier31636522018-11-09 23:53:07 +0000402
Nicolas Geoffrayaaad21e2019-02-25 13:31:10 +0000403 std::string boot_image;
404 std::string use_apex_image =
405 server_configurable_flags::GetServerConfigurableFlag(RUNTIME_NATIVE_BOOT_NAMESPACE,
406 ENABLE_APEX_IMAGE,
407 /*default_value=*/ "");
Mathieu Chartiere97261e2019-10-01 15:36:01 -0700408
409 std::string profile_boot_class_path = GetProperty("dalvik.vm.profilebootclasspath", "");
410 profile_boot_class_path =
411 server_configurable_flags::GetServerConfigurableFlag(
412 RUNTIME_NATIVE_BOOT_NAMESPACE,
413 PROFILE_BOOT_CLASS_PATH,
414 /*default_value=*/ profile_boot_class_path);
415
416 if (use_apex_image == "true" || profile_boot_class_path == "true") {
Nicolas Geoffrayaaad21e2019-02-25 13:31:10 +0000417 boot_image = StringPrintf("-Ximage:%s", kApexImage);
418 } else {
419 boot_image = MapPropertyToArg("dalvik.vm.boot-image", "-Ximage:%s");
420 }
Nicolas Geoffray8b3fa972019-02-14 15:57:47 +0000421
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800422 // clang FORTIFY doesn't let us use strlen in constant array bounds, so we
423 // use arraysize instead.
424 std::string zip_fd_arg = StringPrintf("--zip-fd=%d", zip_fd);
425 std::string zip_location_arg = StringPrintf("--zip-location=%s", relative_input_file_name);
426 std::string input_vdex_fd_arg = StringPrintf("--input-vdex-fd=%d", input_vdex_fd);
427 std::string output_vdex_fd_arg = StringPrintf("--output-vdex-fd=%d", output_vdex_fd);
428 std::string oat_fd_arg = StringPrintf("--oat-fd=%d", oat_fd);
429 std::string oat_location_arg = StringPrintf("--oat-location=%s", output_file_name);
430 std::string instruction_set_arg = StringPrintf("--instruction-set=%s", instruction_set);
431 std::string dex2oat_compiler_filter_arg;
432 std::string dex2oat_swap_fd;
433 std::string dex2oat_image_fd;
434 std::string target_sdk_version_arg;
435 if (target_sdk_version != 0) {
David Brazdilccfb3cf2019-02-20 10:39:34 +0000436 target_sdk_version_arg = StringPrintf("-Xtarget-sdk-version:%d", target_sdk_version);
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800437 }
438 std::string class_loader_context_arg;
David Brazdil4f6027a2019-03-19 11:44:21 +0000439 std::string class_loader_context_fds_arg;
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800440 if (class_loader_context != nullptr) {
441 class_loader_context_arg = StringPrintf("--class-loader-context=%s",
442 class_loader_context);
David Brazdil4f6027a2019-03-19 11:44:21 +0000443 if (!class_loader_context_fds.empty()) {
444 class_loader_context_fds_arg = StringPrintf("--class-loader-context-fds=%s",
445 class_loader_context_fds.c_str());
446 }
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800447 }
Mathieu Chartier31636522018-11-09 23:53:07 +0000448
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800449 if (swap_fd >= 0) {
450 dex2oat_swap_fd = StringPrintf("--swap-fd=%d", swap_fd);
451 }
452 if (image_fd >= 0) {
453 dex2oat_image_fd = StringPrintf("--app-image-fd=%d", image_fd);
454 }
Mathieu Chartier31636522018-11-09 23:53:07 +0000455
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800456 // Compute compiler filter.
457 bool have_dex2oat_relocation_skip_flag = false;
458 if (skip_compilation) {
459 dex2oat_compiler_filter_arg = "--compiler-filter=extract";
460 have_dex2oat_relocation_skip_flag = true;
461 } else if (compiler_filter != nullptr) {
462 dex2oat_compiler_filter_arg = StringPrintf("--compiler-filter=%s", compiler_filter);
463 }
Mathieu Chartier31636522018-11-09 23:53:07 +0000464
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800465 if (dex2oat_compiler_filter_arg.empty()) {
466 dex2oat_compiler_filter_arg = MapPropertyToArg("dalvik.vm.dex2oat-filter",
467 "--compiler-filter=%s");
468 }
469
470 // Check whether all apps should be compiled debuggable.
471 if (!debuggable) {
472 debuggable = GetProperty("dalvik.vm.always_debuggable", "") == "1";
473 }
474 std::string profile_arg;
475 if (profile_fd != -1) {
476 profile_arg = StringPrintf("--profile-file-fd=%d", profile_fd);
477 }
478
479 // Get the directory of the apk to pass as a base classpath directory.
480 std::string base_dir;
481 std::string apk_dir(input_file_name);
482 unsigned long dir_index = apk_dir.rfind('/');
483 bool has_base_dir = dir_index != std::string::npos;
484 if (has_base_dir) {
485 apk_dir = apk_dir.substr(0, dir_index);
486 base_dir = StringPrintf("--classpath-dir=%s", apk_dir.c_str());
487 }
488
489 std::string dex_metadata_fd_arg = "--dm-fd=" + std::to_string(dex_metadata_fd);
490
491 std::string compilation_reason_arg = compilation_reason == nullptr
492 ? ""
493 : std::string("--compilation-reason=") + compilation_reason;
494
495 ALOGV("Running %s in=%s out=%s\n", dex2oat_bin, relative_input_file_name, output_file_name);
496
497 // Disable cdex if update input vdex is true since this combination of options is not
498 // supported.
499 const bool disable_cdex = !generate_compact_dex || (input_vdex_fd == output_vdex_fd);
500
501 AddArg(zip_fd_arg);
502 AddArg(zip_location_arg);
503 AddArg(input_vdex_fd_arg);
504 AddArg(output_vdex_fd_arg);
505 AddArg(oat_fd_arg);
506 AddArg(oat_location_arg);
507 AddArg(instruction_set_arg);
508
509 AddArg(instruction_set_variant_arg);
510 AddArg(instruction_set_features_arg);
511
Nicolas Geoffray8b3fa972019-02-14 15:57:47 +0000512 AddRuntimeArg(boot_image);
Nicolas Geoffrayab0a1902019-02-22 21:42:45 +0000513 AddRuntimeArg(bootclasspath);
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800514 AddRuntimeArg(dex2oat_Xms_arg);
515 AddRuntimeArg(dex2oat_Xmx_arg);
516
517 AddArg(resolve_startup_string_arg);
Mathieu Chartier5880c032018-11-28 19:15:41 -0800518 AddArg(image_block_size_arg);
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800519 AddArg(dex2oat_compiler_filter_arg);
520 AddArg(dex2oat_threads_arg);
521 AddArg(dex2oat_swap_fd);
522 AddArg(dex2oat_image_fd);
523
524 if (generate_debug_info) {
525 AddArg("--generate-debug-info");
526 }
527 if (debuggable) {
528 AddArg("--debuggable");
529 }
530 AddArg(image_format_arg);
531 AddArg(dex2oat_large_app_threshold_arg);
532
533 if (have_dex2oat_relocation_skip_flag) {
534 AddRuntimeArg(dex2oat_norelocation);
535 }
536 AddArg(profile_arg);
537 AddArg(base_dir);
538 AddArg(class_loader_context_arg);
David Brazdil4f6027a2019-03-19 11:44:21 +0000539 AddArg(class_loader_context_fds_arg);
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800540 if (generate_minidebug_info) {
541 AddArg(kMinidebugDex2oatFlag);
542 }
543 if (disable_cdex) {
544 AddArg(kDisableCompactDexFlag);
545 }
David Brazdilccfb3cf2019-02-20 10:39:34 +0000546 AddRuntimeArg(target_sdk_version_arg);
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800547 if (enable_hidden_api_checks) {
David Brazdil36133d12019-04-12 11:08:44 +0100548 AddRuntimeArg("-Xhidden-api-policy:enabled");
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800549 }
550
551 if (dex_metadata_fd > -1) {
552 AddArg(dex_metadata_fd_arg);
553 }
554
555 AddArg(compilation_reason_arg);
556
557 // Do not add args after dex2oat_flags, they should override others for debugging.
558 args_.insert(args_.end(), dex2oat_flags_args.begin(), dex2oat_flags_args.end());
559
560 PrepareArgs(dex2oat_bin);
Mathieu Chartier31636522018-11-09 23:53:07 +0000561 }
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800562};
Jeff Sharkey90aff262016-12-12 14:28:24 -0700563
564/*
565 * Whether dexopt should use a swap file when compiling an APK.
566 *
567 * If kAlwaysProvideSwapFile, do this on all devices (dex2oat will make a more informed decision
568 * itself, anyways).
569 *
570 * Otherwise, read "dalvik.vm.dex2oat-swap". If the property exists, return whether it is "true".
571 *
572 * Otherwise, return true if this is a low-mem device.
573 *
574 * Otherwise, return default value.
575 */
576static bool kAlwaysProvideSwapFile = false;
577static bool kDefaultProvideSwapFile = true;
578
579static bool ShouldUseSwapFileForDexopt() {
580 if (kAlwaysProvideSwapFile) {
581 return true;
582 }
583
584 // Check the "override" property. If it exists, return value == "true".
Mathieu Chartier9b2da082018-10-26 13:23:11 -0700585 std::string dex2oat_prop_buf = GetProperty("dalvik.vm.dex2oat-swap", "");
586 if (!dex2oat_prop_buf.empty()) {
587 return dex2oat_prop_buf == "true";
Jeff Sharkey90aff262016-12-12 14:28:24 -0700588 }
589
590 // Shortcut for default value. This is an implementation optimization for the process sketched
591 // above. If the default value is true, we can avoid to check whether this is a low-mem device,
592 // as low-mem is never returning false. The compiler will optimize this away if it can.
593 if (kDefaultProvideSwapFile) {
594 return true;
595 }
596
Mathieu Chartier9b2da082018-10-26 13:23:11 -0700597 if (GetBoolProperty("ro.config.low_ram", false)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700598 return true;
599 }
600
601 // Default value must be false here.
602 return kDefaultProvideSwapFile;
603}
604
Richard Uhler76cc0272016-12-08 10:46:35 +0000605static void SetDex2OatScheduling(bool set_to_bg) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700606 if (set_to_bg) {
607 if (set_sched_policy(0, SP_BACKGROUND) < 0) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800608 PLOG(ERROR) << "set_sched_policy failed";
609 exit(DexoptReturnCodes::kSetSchedPolicy);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700610 }
611 if (setpriority(PRIO_PROCESS, 0, ANDROID_PRIORITY_BACKGROUND) < 0) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800612 PLOG(ERROR) << "setpriority failed";
613 exit(DexoptReturnCodes::kSetPriority);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700614 }
615 }
616}
617
Calin Juravle29591732017-11-20 17:46:19 -0800618static unique_fd create_profile(uid_t uid, const std::string& profile, int32_t flags) {
619 unique_fd fd(TEMP_FAILURE_RETRY(open(profile.c_str(), flags, 0600)));
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800620 if (fd.get() < 0) {
Calin Juravle29591732017-11-20 17:46:19 -0800621 if (errno != EEXIST) {
Calin Juravle114f0812017-03-08 19:05:07 -0800622 PLOG(ERROR) << "Failed to create profile " << profile;
Calin Juravle29591732017-11-20 17:46:19 -0800623 return invalid_unique_fd();
Calin Juravle114f0812017-03-08 19:05:07 -0800624 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700625 }
Calin Juravle114f0812017-03-08 19:05:07 -0800626 // Profiles should belong to the app; make sure of that by giving ownership to
627 // the app uid. If we cannot do that, there's no point in returning the fd
628 // since dex2oat/profman will fail with SElinux denials.
629 if (fchown(fd.get(), uid, uid) < 0) {
Roland Levillain019db5b2019-03-14 14:31:59 +0000630 PLOG(ERROR) << "Could not chown profile " << profile;
Calin Juravle29591732017-11-20 17:46:19 -0800631 return invalid_unique_fd();
Calin Juravle114f0812017-03-08 19:05:07 -0800632 }
Calin Juravle29591732017-11-20 17:46:19 -0800633 return fd;
Calin Juravle114f0812017-03-08 19:05:07 -0800634}
635
Calin Juravle29591732017-11-20 17:46:19 -0800636static unique_fd open_profile(uid_t uid, const std::string& profile, int32_t flags) {
Calin Juravle114f0812017-03-08 19:05:07 -0800637 // Do not follow symlinks when opening a profile:
638 // - primary profiles should not contain symlinks in their paths
639 // - secondary dex paths should have been already resolved and validated
640 flags |= O_NOFOLLOW;
641
Calin Juravle29591732017-11-20 17:46:19 -0800642 // Check if we need to create the profile
643 // Reference profiles and snapshots are created on the fly; so they might not exist beforehand.
644 unique_fd fd;
645 if ((flags & O_CREAT) != 0) {
646 fd = create_profile(uid, profile, flags);
647 } else {
648 fd.reset(TEMP_FAILURE_RETRY(open(profile.c_str(), flags)));
649 }
650
Calin Juravle114f0812017-03-08 19:05:07 -0800651 if (fd.get() < 0) {
652 if (errno != ENOENT) {
653 // Profiles might be missing for various reasons. For example, in a
654 // multi-user environment, the profile directory for one user can be created
655 // after we start a merge. In this case the current profile for that user
656 // will not be found.
657 // Also, the secondary dex profiles might be deleted by the app at any time,
658 // so we can't we need to prepare if they are missing.
659 PLOG(ERROR) << "Failed to open profile " << profile;
660 }
661 return invalid_unique_fd();
662 }
663
Jeff Sharkey90aff262016-12-12 14:28:24 -0700664 return fd;
665}
666
Calin Juravle824a64d2018-01-18 20:23:17 -0800667static unique_fd open_current_profile(uid_t uid, userid_t user, const std::string& package_name,
668 const std::string& location, bool is_secondary_dex) {
669 std::string profile = create_current_profile_path(user, package_name, location,
670 is_secondary_dex);
Calin Juravle29591732017-11-20 17:46:19 -0800671 return open_profile(uid, profile, O_RDONLY);
Calin Juravle114f0812017-03-08 19:05:07 -0800672}
673
Calin Juravle824a64d2018-01-18 20:23:17 -0800674static unique_fd open_reference_profile(uid_t uid, const std::string& package_name,
675 const std::string& location, bool read_write, bool is_secondary_dex) {
676 std::string profile = create_reference_profile_path(package_name, location, is_secondary_dex);
Calin Juravle29591732017-11-20 17:46:19 -0800677 return open_profile(uid, profile, read_write ? (O_CREAT | O_RDWR) : O_RDONLY);
678}
679
680static unique_fd open_spnashot_profile(uid_t uid, const std::string& package_name,
Calin Juravle824a64d2018-01-18 20:23:17 -0800681 const std::string& location) {
682 std::string profile = create_snapshot_profile_path(package_name, location);
Calin Juravle29591732017-11-20 17:46:19 -0800683 return open_profile(uid, profile, O_CREAT | O_RDWR | O_TRUNC);
Calin Juravle114f0812017-03-08 19:05:07 -0800684}
685
Calin Juravle824a64d2018-01-18 20:23:17 -0800686static void open_profile_files(uid_t uid, const std::string& package_name,
687 const std::string& location, bool is_secondary_dex,
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800688 /*out*/ std::vector<unique_fd>* profiles_fd, /*out*/ unique_fd* reference_profile_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700689 // Open the reference profile in read-write mode as profman might need to save the merge.
Calin Juravle824a64d2018-01-18 20:23:17 -0800690 *reference_profile_fd = open_reference_profile(uid, package_name, location,
691 /*read_write*/ true, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700692
Calin Juravle114f0812017-03-08 19:05:07 -0800693 // For secondary dex files, we don't really need the user but we use it for sanity checks.
694 // Note: the user owning the dex file should be the current user.
695 std::vector<userid_t> users;
696 if (is_secondary_dex){
697 users.push_back(multiuser_get_user_id(uid));
698 } else {
699 users = get_known_users(/*volume_uuid*/ nullptr);
700 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700701 for (auto user : users) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800702 unique_fd profile_fd = open_current_profile(uid, user, package_name, location,
703 is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700704 // Add to the lists only if both fds are valid.
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800705 if (profile_fd.get() >= 0) {
706 profiles_fd->push_back(std::move(profile_fd));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700707 }
708 }
709}
710
Calin Juravle76561322019-11-14 09:08:52 -0800711static constexpr int PROFMAN_BIN_RETURN_CODE_SUCCESS = 0;
712static constexpr int PROFMAN_BIN_RETURN_CODE_COMPILE = 1;
713static constexpr int PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION = 2;
714static constexpr int PROFMAN_BIN_RETURN_CODE_BAD_PROFILES = 3;
715static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_IO = 4;
716static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING = 5;
717static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_DIFFERENT_VERSIONS = 6;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700718
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800719class RunProfman : public ExecVHelper {
720 public:
721 void SetupArgs(const std::vector<unique_fd>& profile_fds,
722 const unique_fd& reference_profile_fd,
723 const std::vector<unique_fd>& apk_fds,
724 const std::vector<std::string>& dex_locations,
Calin Juravle78728f32019-11-08 17:55:46 -0800725 bool copy_and_update,
726 bool for_snapshot,
727 bool for_boot_image) {
Calin Juravlef74a7372019-02-28 20:29:41 -0800728
729 // TODO(calin): Assume for now we run in the bg compile job (which is in
730 // most of the invocation). With the current data flow, is not very easy or
731 // clean to discover this in RunProfman (it will require quite a messy refactoring).
732 const char* profman_bin = select_execution_binary(
733 kProfmanPath, kProfmanDebugPath, /*background_job_compile=*/ true);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700734
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800735 if (copy_and_update) {
736 CHECK_EQ(1u, profile_fds.size());
737 CHECK_EQ(1u, apk_fds.size());
Mathieu Chartier31636522018-11-09 23:53:07 +0000738 }
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800739 if (reference_profile_fd != -1) {
740 AddArg("--reference-profile-file-fd=" + std::to_string(reference_profile_fd.get()));
Mathieu Chartier31636522018-11-09 23:53:07 +0000741 }
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800742
743 for (const unique_fd& fd : profile_fds) {
744 AddArg("--profile-file-fd=" + std::to_string(fd.get()));
745 }
746
747 for (const unique_fd& fd : apk_fds) {
748 AddArg("--apk-fd=" + std::to_string(fd.get()));
749 }
750
751 for (const std::string& dex_location : dex_locations) {
752 AddArg("--dex-location=" + dex_location);
753 }
754
755 if (copy_and_update) {
756 AddArg("--copy-and-update-profile-key");
757 }
758
Calin Juravle78728f32019-11-08 17:55:46 -0800759 if (for_snapshot) {
760 AddArg("--force-merge");
761 }
762
763 if (for_boot_image) {
764 AddArg("--boot-image-merge");
765 }
766
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800767 // Do not add after dex2oat_flags, they should override others for debugging.
768 PrepareArgs(profman_bin);
Mathieu Chartier62d218d2018-11-05 09:34:24 -0800769 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700770
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800771 void SetupMerge(const std::vector<unique_fd>& profiles_fd,
772 const unique_fd& reference_profile_fd,
773 const std::vector<unique_fd>& apk_fds = std::vector<unique_fd>(),
Calin Juravle78728f32019-11-08 17:55:46 -0800774 const std::vector<std::string>& dex_locations = std::vector<std::string>(),
775 bool for_snapshot = false,
776 bool for_boot_image = false) {
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800777 SetupArgs(profiles_fd,
Calin Juravleb3a929d2018-12-11 14:40:00 -0800778 reference_profile_fd,
779 apk_fds,
780 dex_locations,
Calin Juravle78728f32019-11-08 17:55:46 -0800781 /*copy_and_update=*/ false,
782 for_snapshot,
783 for_boot_image);
Mathieu Chartier62d218d2018-11-05 09:34:24 -0800784 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700785
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800786 void SetupCopyAndUpdate(unique_fd&& profile_fd,
787 unique_fd&& reference_profile_fd,
788 unique_fd&& apk_fd,
789 const std::string& dex_location) {
790 // The fds need to stay open longer than the scope of the function, so put them into a local
791 // variable vector.
792 profiles_fd_.push_back(std::move(profile_fd));
793 apk_fds_.push_back(std::move(apk_fd));
794 reference_profile_fd_ = std::move(reference_profile_fd);
795 std::vector<std::string> dex_locations = {dex_location};
Calin Juravleb3a929d2018-12-11 14:40:00 -0800796 SetupArgs(profiles_fd_,
797 reference_profile_fd_,
798 apk_fds_,
799 dex_locations,
Calin Juravle78728f32019-11-08 17:55:46 -0800800 /*copy_and_update=*/true,
801 /*for_snapshot*/false,
802 /*for_boot_image*/false);
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800803 }
Calin Juravlef63d4792018-01-30 17:43:34 +0000804
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800805 void SetupDump(const std::vector<unique_fd>& profiles_fd,
806 const unique_fd& reference_profile_fd,
807 const std::vector<std::string>& dex_locations,
808 const std::vector<unique_fd>& apk_fds,
809 const unique_fd& output_fd) {
810 AddArg("--dump-only");
811 AddArg(StringPrintf("--dump-output-to-fd=%d", output_fd.get()));
Calin Juravleb3a929d2018-12-11 14:40:00 -0800812 SetupArgs(profiles_fd,
813 reference_profile_fd,
814 apk_fds,
815 dex_locations,
Calin Juravle78728f32019-11-08 17:55:46 -0800816 /*copy_and_update=*/false,
817 /*for_snapshot*/false,
818 /*for_boot_image*/false);
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800819 }
Calin Juravlef63d4792018-01-30 17:43:34 +0000820
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800821 void Exec() {
822 ExecVHelper::Exec(DexoptReturnCodes::kProfmanExec);
823 }
Mathieu Chartier31636522018-11-09 23:53:07 +0000824
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800825 private:
826 unique_fd reference_profile_fd_;
827 std::vector<unique_fd> profiles_fd_;
828 std::vector<unique_fd> apk_fds_;
829};
Mathieu Chartier31636522018-11-09 23:53:07 +0000830
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800831
Calin Juravlef63d4792018-01-30 17:43:34 +0000832
Jeff Sharkey90aff262016-12-12 14:28:24 -0700833// Decides if profile guided compilation is needed or not based on existing profiles.
Calin Juravle114f0812017-03-08 19:05:07 -0800834// The location is the package name for primary apks or the dex path for secondary dex files.
835// Returns true if there is enough information in the current profiles that makes it
836// worth to recompile the given location.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700837// If the return value is true all the current profiles would have been merged into
838// the reference profiles accessible with open_reference_profile().
Calin Juravle824a64d2018-01-18 20:23:17 -0800839static bool analyze_profiles(uid_t uid, const std::string& package_name,
840 const std::string& location, bool is_secondary_dex) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800841 std::vector<unique_fd> profiles_fd;
842 unique_fd reference_profile_fd;
Calin Juravle824a64d2018-01-18 20:23:17 -0800843 open_profile_files(uid, package_name, location, is_secondary_dex,
844 &profiles_fd, &reference_profile_fd);
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800845 if (profiles_fd.empty() || (reference_profile_fd.get() < 0)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700846 // Skip profile guided compilation because no profiles were found.
847 // Or if the reference profile info couldn't be opened.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700848 return false;
849 }
850
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800851 RunProfman profman_merge;
852 profman_merge.SetupMerge(profiles_fd, reference_profile_fd);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700853 pid_t pid = fork();
854 if (pid == 0) {
855 /* child -- drop privileges before continuing */
856 drop_capabilities(uid);
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800857 profman_merge.Exec();
Jeff Sharkey90aff262016-12-12 14:28:24 -0700858 }
859 /* parent */
860 int return_code = wait_child(pid);
861 bool need_to_compile = false;
862 bool should_clear_current_profiles = false;
863 bool should_clear_reference_profile = false;
864 if (!WIFEXITED(return_code)) {
Calin Juravle114f0812017-03-08 19:05:07 -0800865 LOG(WARNING) << "profman failed for location " << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700866 } else {
867 return_code = WEXITSTATUS(return_code);
868 switch (return_code) {
869 case PROFMAN_BIN_RETURN_CODE_COMPILE:
870 need_to_compile = true;
871 should_clear_current_profiles = true;
872 should_clear_reference_profile = false;
873 break;
874 case PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION:
875 need_to_compile = false;
876 should_clear_current_profiles = false;
877 should_clear_reference_profile = false;
878 break;
879 case PROFMAN_BIN_RETURN_CODE_BAD_PROFILES:
Calin Juravle114f0812017-03-08 19:05:07 -0800880 LOG(WARNING) << "Bad profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700881 need_to_compile = false;
882 should_clear_current_profiles = true;
883 should_clear_reference_profile = true;
884 break;
885 case PROFMAN_BIN_RETURN_CODE_ERROR_IO: // fall-through
886 case PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING:
887 // Temporary IO problem (e.g. locking). Ignore but log a warning.
Calin Juravle114f0812017-03-08 19:05:07 -0800888 LOG(WARNING) << "IO error while reading profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700889 need_to_compile = false;
890 should_clear_current_profiles = false;
891 should_clear_reference_profile = false;
892 break;
Calin Juravle76561322019-11-14 09:08:52 -0800893 case PROFMAN_BIN_RETURN_CODE_ERROR_DIFFERENT_VERSIONS:
894 need_to_compile = false;
895 should_clear_current_profiles = true;
896 should_clear_reference_profile = true;
897 break;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700898 default:
899 // Unknown return code or error. Unlink profiles.
Calin Juravle78728f32019-11-08 17:55:46 -0800900 LOG(WARNING) << "Unexpected error code while processing profiles for location "
Calin Juravle114f0812017-03-08 19:05:07 -0800901 << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700902 need_to_compile = false;
903 should_clear_current_profiles = true;
904 should_clear_reference_profile = true;
905 break;
906 }
907 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800908
Jeff Sharkey90aff262016-12-12 14:28:24 -0700909 if (should_clear_current_profiles) {
Calin Juravle114f0812017-03-08 19:05:07 -0800910 if (is_secondary_dex) {
911 // For secondary dex files, the owning user is the current user.
Calin Juravle824a64d2018-01-18 20:23:17 -0800912 clear_current_profile(package_name, location, multiuser_get_user_id(uid),
913 is_secondary_dex);
Calin Juravle114f0812017-03-08 19:05:07 -0800914 } else {
Calin Juravle824a64d2018-01-18 20:23:17 -0800915 clear_primary_current_profiles(package_name, location);
Calin Juravle114f0812017-03-08 19:05:07 -0800916 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700917 }
918 if (should_clear_reference_profile) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800919 clear_reference_profile(package_name, location, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700920 }
921 return need_to_compile;
922}
923
Calin Juravle114f0812017-03-08 19:05:07 -0800924// Decides if profile guided compilation is needed or not based on existing profiles.
925// The analysis is done for the primary apks of the given package.
926// Returns true if there is enough information in the current profiles that makes it
927// worth to recompile the package.
928// If the return value is true all the current profiles would have been merged into
929// the reference profiles accessible with open_reference_profile().
Calin Juravle824a64d2018-01-18 20:23:17 -0800930bool analyze_primary_profiles(uid_t uid, const std::string& package_name,
931 const std::string& profile_name) {
932 return analyze_profiles(uid, package_name, profile_name, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800933}
934
Calin Juravle408cd4a2018-01-20 23:34:18 -0800935bool dump_profiles(int32_t uid, const std::string& pkgname, const std::string& profile_name,
936 const std::string& code_path) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800937 std::vector<unique_fd> profile_fds;
938 unique_fd reference_profile_fd;
Calin Juravle408cd4a2018-01-20 23:34:18 -0800939 std::string out_file_name = StringPrintf("/data/misc/profman/%s-%s.txt",
940 pkgname.c_str(), profile_name.c_str());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700941
Calin Juravle408cd4a2018-01-20 23:34:18 -0800942 open_profile_files(uid, pkgname, profile_name, /*is_secondary_dex*/false,
Calin Juravle114f0812017-03-08 19:05:07 -0800943 &profile_fds, &reference_profile_fd);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700944
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800945 const bool has_reference_profile = (reference_profile_fd.get() != -1);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700946 const bool has_profiles = !profile_fds.empty();
947
948 if (!has_reference_profile && !has_profiles) {
Calin Juravle76268c52017-03-09 13:19:42 -0800949 LOG(ERROR) << "profman dump: no profiles to dump for " << pkgname;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700950 return false;
951 }
952
Calin Juravle114f0812017-03-08 19:05:07 -0800953 unique_fd output_fd(open(out_file_name.c_str(),
954 O_WRONLY | O_CREAT | O_TRUNC | O_NOFOLLOW, 0644));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700955 if (fchmod(output_fd, S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH) < 0) {
Calin Juravle408cd4a2018-01-20 23:34:18 -0800956 LOG(ERROR) << "installd cannot chmod file for dump_profile" << out_file_name;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700957 return false;
958 }
Calin Juravle408cd4a2018-01-20 23:34:18 -0800959
Jeff Sharkey90aff262016-12-12 14:28:24 -0700960 std::vector<std::string> dex_locations;
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800961 std::vector<unique_fd> apk_fds;
Calin Juravle408cd4a2018-01-20 23:34:18 -0800962 unique_fd apk_fd(open(code_path.c_str(), O_RDONLY | O_NOFOLLOW));
963 if (apk_fd == -1) {
964 PLOG(ERROR) << "installd cannot open " << code_path.c_str();
965 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700966 }
Calin Juravle408cd4a2018-01-20 23:34:18 -0800967 dex_locations.push_back(get_location_from_path(code_path.c_str()));
968 apk_fds.push_back(std::move(apk_fd));
969
Jeff Sharkey90aff262016-12-12 14:28:24 -0700970
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800971 RunProfman profman_dump;
972 profman_dump.SetupDump(profile_fds, reference_profile_fd, dex_locations, apk_fds, output_fd);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700973 pid_t pid = fork();
974 if (pid == 0) {
975 /* child -- drop privileges before continuing */
976 drop_capabilities(uid);
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800977 profman_dump.Exec();
Jeff Sharkey90aff262016-12-12 14:28:24 -0700978 }
979 /* parent */
Jeff Sharkey90aff262016-12-12 14:28:24 -0700980 int return_code = wait_child(pid);
981 if (!WIFEXITED(return_code)) {
982 LOG(WARNING) << "profman failed for package " << pkgname << ": "
983 << return_code;
984 return false;
985 }
986 return true;
987}
988
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700989bool copy_system_profile(const std::string& system_profile,
Calin Juravle824a64d2018-01-18 20:23:17 -0800990 uid_t packageUid, const std::string& package_name, const std::string& profile_name) {
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700991 unique_fd in_fd(open(system_profile.c_str(), O_RDONLY | O_NOFOLLOW | O_CLOEXEC));
992 unique_fd out_fd(open_reference_profile(packageUid,
Calin Juravle824a64d2018-01-18 20:23:17 -0800993 package_name,
994 profile_name,
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700995 /*read_write*/ true,
996 /*secondary*/ false));
997 if (in_fd.get() < 0) {
998 PLOG(WARNING) << "Could not open profile " << system_profile;
999 return false;
1000 }
1001 if (out_fd.get() < 0) {
Calin Juravle824a64d2018-01-18 20:23:17 -08001002 PLOG(WARNING) << "Could not open profile " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001003 return false;
1004 }
1005
Mathieu Chartier78f71fe2017-06-14 13:02:26 -07001006 // As a security measure we want to write the profile information with the reduced capabilities
1007 // of the package user id. So we fork and drop capabilities in the child.
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001008 pid_t pid = fork();
1009 if (pid == 0) {
1010 /* child -- drop privileges before continuing */
1011 drop_capabilities(packageUid);
1012
1013 if (flock(out_fd.get(), LOCK_EX | LOCK_NB) != 0) {
1014 if (errno != EWOULDBLOCK) {
Calin Juravle824a64d2018-01-18 20:23:17 -08001015 PLOG(WARNING) << "Error locking profile " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001016 }
1017 // This implies that the app owning this profile is running
1018 // (and has acquired the lock).
1019 //
1020 // The app never acquires the lock for the reference profiles of primary apks.
1021 // Only dex2oat from installd will do that. Since installd is single threaded
1022 // we should not see this case. Nevertheless be prepared for it.
Calin Juravle824a64d2018-01-18 20:23:17 -08001023 PLOG(WARNING) << "Failed to flock " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001024 return false;
1025 }
1026
1027 bool truncated = ftruncate(out_fd.get(), 0) == 0;
1028 if (!truncated) {
Calin Juravle824a64d2018-01-18 20:23:17 -08001029 PLOG(WARNING) << "Could not truncate " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001030 }
1031
1032 // Copy over data.
1033 static constexpr size_t kBufferSize = 4 * 1024;
1034 char buffer[kBufferSize];
1035 while (true) {
1036 ssize_t bytes = read(in_fd.get(), buffer, kBufferSize);
1037 if (bytes == 0) {
1038 break;
1039 }
1040 write(out_fd.get(), buffer, bytes);
1041 }
1042 if (flock(out_fd.get(), LOCK_UN) != 0) {
Calin Juravle824a64d2018-01-18 20:23:17 -08001043 PLOG(WARNING) << "Error unlocking profile " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001044 }
Mathieu Chartier78f71fe2017-06-14 13:02:26 -07001045 // Use _exit since we don't want to run the global destructors in the child.
1046 // b/62597429
1047 _exit(0);
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001048 }
1049 /* parent */
1050 int return_code = wait_child(pid);
1051 return return_code == 0;
1052}
1053
Jeff Sharkey90aff262016-12-12 14:28:24 -07001054static std::string replace_file_extension(const std::string& oat_path, const std::string& new_ext) {
1055 // A standard dalvik-cache entry. Replace ".dex" with `new_ext`.
1056 if (EndsWith(oat_path, ".dex")) {
1057 std::string new_path = oat_path;
1058 new_path.replace(new_path.length() - strlen(".dex"), strlen(".dex"), new_ext);
Elliott Hughes969e4f82017-12-20 12:34:09 -08001059 CHECK(EndsWith(new_path, new_ext));
Jeff Sharkey90aff262016-12-12 14:28:24 -07001060 return new_path;
1061 }
1062
1063 // An odex entry. Not that this may not be an extension, e.g., in the OTA
1064 // case (where the base name will have an extension for the B artifact).
1065 size_t odex_pos = oat_path.rfind(".odex");
1066 if (odex_pos != std::string::npos) {
1067 std::string new_path = oat_path;
1068 new_path.replace(odex_pos, strlen(".odex"), new_ext);
1069 CHECK_NE(new_path.find(new_ext), std::string::npos);
1070 return new_path;
1071 }
1072
1073 // Don't know how to handle this.
1074 return "";
1075}
1076
1077// Translate the given oat path to an art (app image) path. An empty string
1078// denotes an error.
1079static std::string create_image_filename(const std::string& oat_path) {
1080 return replace_file_extension(oat_path, ".art");
1081}
1082
1083// Translate the given oat path to a vdex path. An empty string denotes an error.
1084static std::string create_vdex_filename(const std::string& oat_path) {
1085 return replace_file_extension(oat_path, ".vdex");
1086}
1087
Jeff Sharkey90aff262016-12-12 14:28:24 -07001088static int open_output_file(const char* file_name, bool recreate, int permissions) {
1089 int flags = O_RDWR | O_CREAT;
1090 if (recreate) {
1091 if (unlink(file_name) < 0) {
1092 if (errno != ENOENT) {
1093 PLOG(ERROR) << "open_output_file: Couldn't unlink " << file_name;
1094 }
1095 }
1096 flags |= O_EXCL;
1097 }
1098 return open(file_name, flags, permissions);
1099}
1100
Calin Juravle2289c0a2017-02-15 12:44:14 -08001101static bool set_permissions_and_ownership(
1102 int fd, bool is_public, int uid, const char* path, bool is_secondary_dex) {
1103 // Primary apks are owned by the system. Secondary dex files are owned by the app.
1104 int owning_uid = is_secondary_dex ? uid : AID_SYSTEM;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001105 if (fchmod(fd,
1106 S_IRUSR|S_IWUSR|S_IRGRP |
1107 (is_public ? S_IROTH : 0)) < 0) {
1108 ALOGE("installd cannot chmod '%s' during dexopt\n", path);
1109 return false;
Calin Juravle2289c0a2017-02-15 12:44:14 -08001110 } else if (fchown(fd, owning_uid, uid) < 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001111 ALOGE("installd cannot chown '%s' during dexopt\n", path);
1112 return false;
1113 }
1114 return true;
1115}
1116
1117static bool IsOutputDalvikCache(const char* oat_dir) {
1118 // InstallerConnection.java (which invokes installd) transforms Java null arguments
1119 // into '!'. Play it safe by handling it both.
1120 // TODO: ensure we never get null.
1121 // TODO: pass a flag instead of inferring if the output is dalvik cache.
1122 return oat_dir == nullptr || oat_dir[0] == '!';
1123}
1124
Calin Juravled23dee72017-07-06 16:29:11 -07001125// Best-effort check whether we can fit the the path into our buffers.
1126// Note: the cache path will require an additional 5 bytes for ".swap", but we'll try to run
1127// without a swap file, if necessary. Reference profiles file also add an extra ".prof"
1128// extension to the cache path (5 bytes).
1129// TODO(calin): move away from char* buffers and PKG_PATH_MAX.
1130static bool validate_dex_path_size(const std::string& dex_path) {
1131 if (dex_path.size() >= (PKG_PATH_MAX - 8)) {
1132 LOG(ERROR) << "dex_path too long: " << dex_path;
1133 return false;
1134 }
1135 return true;
1136}
1137
Jeff Sharkey90aff262016-12-12 14:28:24 -07001138static bool create_oat_out_path(const char* apk_path, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -08001139 const char* oat_dir, bool is_secondary_dex, /*out*/ char* out_oat_path) {
Calin Juravled23dee72017-07-06 16:29:11 -07001140 if (!validate_dex_path_size(apk_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001141 return false;
1142 }
1143
1144 if (!IsOutputDalvikCache(oat_dir)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001145 // Oat dirs for secondary dex files are already validated.
1146 if (!is_secondary_dex && validate_apk_path(oat_dir)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001147 ALOGE("cannot validate apk path with oat_dir '%s'\n", oat_dir);
1148 return false;
1149 }
1150 if (!calculate_oat_file_path(out_oat_path, oat_dir, apk_path, instruction_set)) {
1151 return false;
1152 }
1153 } else {
1154 if (!create_cache_path(out_oat_path, apk_path, instruction_set)) {
1155 return false;
1156 }
1157 }
1158 return true;
1159}
1160
1161// Helper for fd management. This is similar to a unique_fd in that it closes the file descriptor
1162// on destruction. It will also run the given cleanup (unless told not to) after closing.
1163//
1164// Usage example:
1165//
Calin Juravle7a570e82017-01-14 16:23:30 -08001166// Dex2oatFileWrapper file(open(...),
Jeff Sharkey90aff262016-12-12 14:28:24 -07001167// [name]() {
1168// unlink(name.c_str());
1169// });
1170// // Note: care needs to be taken about name, as it needs to have a lifetime longer than the
1171// wrapper if captured as a reference.
1172//
1173// if (file.get() == -1) {
1174// // Error opening...
1175// }
1176//
1177// ...
1178// if (error) {
1179// // At this point, when the Dex2oatFileWrapper is destructed, the cleanup function will run
1180// // and delete the file (after the fd is closed).
1181// return -1;
1182// }
1183//
1184// (Success case)
1185// file.SetCleanup(false);
1186// // At this point, when the Dex2oatFileWrapper is destructed, the cleanup function will not run
1187// // (leaving the file around; after the fd is closed).
1188//
Jeff Sharkey90aff262016-12-12 14:28:24 -07001189class Dex2oatFileWrapper {
1190 public:
Calin Juravle7a570e82017-01-14 16:23:30 -08001191 Dex2oatFileWrapper() : value_(-1), cleanup_(), do_cleanup_(true), auto_close_(true) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001192 }
1193
Calin Juravle7a570e82017-01-14 16:23:30 -08001194 Dex2oatFileWrapper(int value, std::function<void ()> cleanup)
1195 : value_(value), cleanup_(cleanup), do_cleanup_(true), auto_close_(true) {}
1196
1197 Dex2oatFileWrapper(Dex2oatFileWrapper&& other) {
1198 value_ = other.value_;
1199 cleanup_ = other.cleanup_;
1200 do_cleanup_ = other.do_cleanup_;
1201 auto_close_ = other.auto_close_;
1202 other.release();
1203 }
1204
1205 Dex2oatFileWrapper& operator=(Dex2oatFileWrapper&& other) {
1206 value_ = other.value_;
1207 cleanup_ = other.cleanup_;
1208 do_cleanup_ = other.do_cleanup_;
1209 auto_close_ = other.auto_close_;
1210 other.release();
1211 return *this;
1212 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001213
1214 ~Dex2oatFileWrapper() {
1215 reset(-1);
1216 }
1217
1218 int get() {
1219 return value_;
1220 }
1221
1222 void SetCleanup(bool cleanup) {
1223 do_cleanup_ = cleanup;
1224 }
1225
1226 void reset(int new_value) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001227 if (auto_close_ && value_ >= 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001228 close(value_);
1229 }
1230 if (do_cleanup_ && cleanup_ != nullptr) {
1231 cleanup_();
1232 }
1233
1234 value_ = new_value;
1235 }
1236
Calin Juravle7a570e82017-01-14 16:23:30 -08001237 void reset(int new_value, std::function<void ()> new_cleanup) {
1238 if (auto_close_ && value_ >= 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001239 close(value_);
1240 }
1241 if (do_cleanup_ && cleanup_ != nullptr) {
1242 cleanup_();
1243 }
1244
1245 value_ = new_value;
1246 cleanup_ = new_cleanup;
1247 }
1248
Calin Juravle7a570e82017-01-14 16:23:30 -08001249 void DisableAutoClose() {
1250 auto_close_ = false;
1251 }
1252
Jeff Sharkey90aff262016-12-12 14:28:24 -07001253 private:
Calin Juravle7a570e82017-01-14 16:23:30 -08001254 void release() {
1255 value_ = -1;
1256 do_cleanup_ = false;
1257 cleanup_ = nullptr;
1258 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001259 int value_;
Calin Juravle7a570e82017-01-14 16:23:30 -08001260 std::function<void ()> cleanup_;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001261 bool do_cleanup_;
Calin Juravle7a570e82017-01-14 16:23:30 -08001262 bool auto_close_;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001263};
1264
Calin Juravle7a570e82017-01-14 16:23:30 -08001265// (re)Creates the app image if needed.
Mathieu Chartier1dc3dfa2018-03-12 17:55:06 -07001266Dex2oatFileWrapper maybe_open_app_image(const char* out_oat_path,
1267 bool generate_app_image, bool is_public, int uid, bool is_secondary_dex) {
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +01001268
1269 // We don't create an image for secondary dex files.
1270 if (is_secondary_dex) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001271 return Dex2oatFileWrapper();
1272 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001273
Calin Juravle7a570e82017-01-14 16:23:30 -08001274 const std::string image_path = create_image_filename(out_oat_path);
1275 if (image_path.empty()) {
1276 // Happens when the out_oat_path has an unknown extension.
1277 return Dex2oatFileWrapper();
1278 }
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +01001279
Mathieu Chartier1dc3dfa2018-03-12 17:55:06 -07001280 // In case there is a stale image, remove it now. Ignore any error.
1281 unlink(image_path.c_str());
1282
1283 // Not enabled, exit.
1284 if (!generate_app_image) {
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +01001285 return Dex2oatFileWrapper();
1286 }
Mathieu Chartier9b2da082018-10-26 13:23:11 -07001287 std::string app_image_format = GetProperty("dalvik.vm.appimageformat", "");
1288 if (app_image_format.empty()) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001289 return Dex2oatFileWrapper();
1290 }
1291 // Recreate is true since we do not want to modify a mapped image. If the app is
1292 // already running and we modify the image file, it can cause crashes (b/27493510).
1293 Dex2oatFileWrapper wrapper_fd(
1294 open_output_file(image_path.c_str(), true /*recreate*/, 0600 /*permissions*/),
1295 [image_path]() { unlink(image_path.c_str()); });
1296 if (wrapper_fd.get() < 0) {
1297 // Could not create application image file. Go on since we can compile without it.
1298 LOG(ERROR) << "installd could not create '" << image_path
1299 << "' for image file during dexopt";
1300 // If we have a valid image file path but no image fd, explicitly erase the image file.
1301 if (unlink(image_path.c_str()) < 0) {
1302 if (errno != ENOENT) {
1303 PLOG(ERROR) << "Couldn't unlink image file " << image_path;
1304 }
1305 }
1306 } else if (!set_permissions_and_ownership(
Calin Juravle2289c0a2017-02-15 12:44:14 -08001307 wrapper_fd.get(), is_public, uid, image_path.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001308 ALOGE("installd cannot set owner '%s' for image during dexopt\n", image_path.c_str());
1309 wrapper_fd.reset(-1);
1310 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001311
Calin Juravle7a570e82017-01-14 16:23:30 -08001312 return wrapper_fd;
1313}
1314
1315// Creates the dexopt swap file if necessary and return its fd.
1316// Returns -1 if there's no need for a swap or in case of errors.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001317unique_fd maybe_open_dexopt_swap_file(const char* out_oat_path) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001318 if (!ShouldUseSwapFileForDexopt()) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001319 return invalid_unique_fd();
Calin Juravle7a570e82017-01-14 16:23:30 -08001320 }
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001321 auto swap_file_name = std::string(out_oat_path) + ".swap";
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001322 unique_fd swap_fd(open_output_file(
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001323 swap_file_name.c_str(), /*recreate*/true, /*permissions*/0600));
Calin Juravle7a570e82017-01-14 16:23:30 -08001324 if (swap_fd.get() < 0) {
1325 // Could not create swap file. Optimistically go on and hope that we can compile
1326 // without it.
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001327 ALOGE("installd could not create '%s' for swap during dexopt\n", swap_file_name.c_str());
Calin Juravle7a570e82017-01-14 16:23:30 -08001328 } else {
1329 // Immediately unlink. We don't really want to hit flash.
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001330 if (unlink(swap_file_name.c_str()) < 0) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001331 PLOG(ERROR) << "Couldn't unlink swap file " << swap_file_name;
1332 }
1333 }
1334 return swap_fd;
1335}
1336
1337// Opens the reference profiles if needed.
1338// Note that the reference profile might not exist so it's OK if the fd will be -1.
Calin Juravle114f0812017-03-08 19:05:07 -08001339Dex2oatFileWrapper maybe_open_reference_profile(const std::string& pkgname,
Calin Juravlec4f6a0b2018-02-01 01:27:24 +00001340 const std::string& dex_path, const char* profile_name, bool profile_guided,
Calin Juravle824a64d2018-01-18 20:23:17 -08001341 bool is_public, int uid, bool is_secondary_dex) {
Calin Juravle5bd1c722018-02-01 17:23:54 +00001342 // If we are not profile guided compilation, or we are compiling system server
1343 // do not bother to open the profiles; we won't be using them.
1344 if (!profile_guided || (pkgname[0] == '*')) {
1345 return Dex2oatFileWrapper();
1346 }
1347
1348 // If this is a secondary dex path which is public do not open the profile.
1349 // We cannot compile public secondary dex paths with profiles. That's because
1350 // it will expose how the dex files are used by their owner.
1351 //
1352 // Note that the PackageManager is responsible to set the is_public flag for
1353 // primary apks and we do not check it here. In some cases, e.g. when
1354 // compiling with a public profile from the .dm file the PackageManager will
1355 // set is_public toghether with the profile guided compilation.
1356 if (is_secondary_dex && is_public) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001357 return Dex2oatFileWrapper();
Jeff Sharkey90aff262016-12-12 14:28:24 -07001358 }
Calin Juravle114f0812017-03-08 19:05:07 -08001359
1360 // Open reference profile in read only mode as dex2oat does not get write permissions.
Calin Juravlec4f6a0b2018-02-01 01:27:24 +00001361 std::string location;
1362 if (is_secondary_dex) {
1363 location = dex_path;
1364 } else {
1365 if (profile_name == nullptr) {
1366 // This path is taken for system server re-compilation lunched from ZygoteInit.
1367 return Dex2oatFileWrapper();
1368 } else {
1369 location = profile_name;
1370 }
1371 }
Calin Juravle824a64d2018-01-18 20:23:17 -08001372 unique_fd ufd = open_reference_profile(uid, pkgname, location, /*read_write*/false,
1373 is_secondary_dex);
1374 const auto& cleanup = [pkgname, location, is_secondary_dex]() {
1375 clear_reference_profile(pkgname, location, is_secondary_dex);
Calin Juravle114f0812017-03-08 19:05:07 -08001376 };
1377 return Dex2oatFileWrapper(ufd.release(), cleanup);
Calin Juravle7a570e82017-01-14 16:23:30 -08001378}
Jeff Sharkey90aff262016-12-12 14:28:24 -07001379
Calin Juravle7a570e82017-01-14 16:23:30 -08001380// Opens the vdex files and assigns the input fd to in_vdex_wrapper_fd and the output fd to
1381// out_vdex_wrapper_fd. Returns true for success or false in case of errors.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001382bool open_vdex_files_for_dex2oat(const char* apk_path, const char* out_oat_path, int dexopt_needed,
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001383 const char* instruction_set, bool is_public, int uid, bool is_secondary_dex,
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001384 bool profile_guided, Dex2oatFileWrapper* in_vdex_wrapper_fd,
Calin Juravle7a570e82017-01-14 16:23:30 -08001385 Dex2oatFileWrapper* out_vdex_wrapper_fd) {
1386 CHECK(in_vdex_wrapper_fd != nullptr);
1387 CHECK(out_vdex_wrapper_fd != nullptr);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001388 // Open the existing VDEX. We do this before creating the new output VDEX, which will
1389 // unlink the old one.
Richard Uhler76cc0272016-12-08 10:46:35 +00001390 char in_odex_path[PKG_PATH_MAX];
1391 int dexopt_action = abs(dexopt_needed);
1392 bool is_odex_location = dexopt_needed < 0;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001393 std::string in_vdex_path_str;
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001394
1395 // Infer the name of the output VDEX.
1396 const std::string out_vdex_path_str = create_vdex_filename(out_oat_path);
1397 if (out_vdex_path_str.empty()) {
1398 return false;
1399 }
1400
1401 bool update_vdex_in_place = false;
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001402 if (dexopt_action != DEX2OAT_FROM_SCRATCH) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001403 // Open the possibly existing vdex. If none exist, we pass -1 to dex2oat for input-vdex-fd.
1404 const char* path = nullptr;
1405 if (is_odex_location) {
1406 if (calculate_odex_file_path(in_odex_path, apk_path, instruction_set)) {
1407 path = in_odex_path;
1408 } else {
1409 ALOGE("installd cannot compute input vdex location for '%s'\n", apk_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001410 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001411 }
1412 } else {
1413 path = out_oat_path;
1414 }
1415 in_vdex_path_str = create_vdex_filename(path);
1416 if (in_vdex_path_str.empty()) {
1417 ALOGE("installd cannot compute input vdex location for '%s'\n", path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001418 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001419 }
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001420 // We can update in place when all these conditions are met:
1421 // 1) The vdex location to write to is the same as the vdex location to read (vdex files
1422 // on /system typically cannot be updated in place).
1423 // 2) We dex2oat due to boot image change, because we then know the existing vdex file
1424 // cannot be currently used by a running process.
1425 // 3) We are not doing a profile guided compilation, because dexlayout requires two
1426 // different vdex files to operate.
1427 update_vdex_in_place =
1428 (in_vdex_path_str == out_vdex_path_str) &&
1429 (dexopt_action == DEX2OAT_FOR_BOOT_IMAGE) &&
1430 !profile_guided;
1431 if (update_vdex_in_place) {
1432 // Open the file read-write to be able to update it.
1433 in_vdex_wrapper_fd->reset(open(in_vdex_path_str.c_str(), O_RDWR, 0));
1434 if (in_vdex_wrapper_fd->get() == -1) {
1435 // If we failed to open the file, we cannot update it in place.
1436 update_vdex_in_place = false;
1437 }
1438 } else {
1439 in_vdex_wrapper_fd->reset(open(in_vdex_path_str.c_str(), O_RDONLY, 0));
1440 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001441 }
1442
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001443 // If we are updating the vdex in place, we do not need to recreate a vdex,
1444 // and can use the same existing one.
1445 if (update_vdex_in_place) {
1446 // We unlink the file in case the invocation of dex2oat fails, to ensure we don't
1447 // have bogus stale vdex files.
1448 out_vdex_wrapper_fd->reset(
1449 in_vdex_wrapper_fd->get(),
1450 [out_vdex_path_str]() { unlink(out_vdex_path_str.c_str()); });
1451 // Disable auto close for the in wrapper fd (it will be done when destructing the out
1452 // wrapper).
1453 in_vdex_wrapper_fd->DisableAutoClose();
1454 } else {
1455 out_vdex_wrapper_fd->reset(
1456 open_output_file(out_vdex_path_str.c_str(), /*recreate*/true, /*permissions*/0644),
1457 [out_vdex_path_str]() { unlink(out_vdex_path_str.c_str()); });
1458 if (out_vdex_wrapper_fd->get() < 0) {
1459 ALOGE("installd cannot open vdex'%s' during dexopt\n", out_vdex_path_str.c_str());
1460 return false;
1461 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001462 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001463 if (!set_permissions_and_ownership(out_vdex_wrapper_fd->get(), is_public, uid,
Calin Juravle2289c0a2017-02-15 12:44:14 -08001464 out_vdex_path_str.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001465 ALOGE("installd cannot set owner '%s' for vdex during dexopt\n", out_vdex_path_str.c_str());
1466 return false;
1467 }
1468
1469 // If we got here we successfully opened the vdex files.
1470 return true;
1471}
1472
1473// Opens the output oat file for the given apk.
1474// If successful it stores the output path into out_oat_path and returns true.
1475Dex2oatFileWrapper open_oat_out_file(const char* apk_path, const char* oat_dir,
Calin Juravle80a21252017-01-17 14:43:25 -08001476 bool is_public, int uid, const char* instruction_set, bool is_secondary_dex,
1477 char* out_oat_path) {
1478 if (!create_oat_out_path(apk_path, instruction_set, oat_dir, is_secondary_dex, out_oat_path)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001479 return Dex2oatFileWrapper();
1480 }
1481 const std::string out_oat_path_str(out_oat_path);
1482 Dex2oatFileWrapper wrapper_fd(
1483 open_output_file(out_oat_path, /*recreate*/true, /*permissions*/0644),
1484 [out_oat_path_str]() { unlink(out_oat_path_str.c_str()); });
1485 if (wrapper_fd.get() < 0) {
Calin Juravle80a21252017-01-17 14:43:25 -08001486 PLOG(ERROR) << "installd cannot open output during dexopt" << out_oat_path;
Calin Juravle2289c0a2017-02-15 12:44:14 -08001487 } else if (!set_permissions_and_ownership(
1488 wrapper_fd.get(), is_public, uid, out_oat_path, is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001489 ALOGE("installd cannot set owner '%s' for output during dexopt\n", out_oat_path);
1490 wrapper_fd.reset(-1);
1491 }
1492 return wrapper_fd;
1493}
1494
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001495// Creates RDONLY fds for oat and vdex files, if exist.
1496// Returns false if it fails to create oat out path for the given apk path.
1497// Note that the method returns true even if the files could not be opened.
1498bool maybe_open_oat_and_vdex_file(const std::string& apk_path,
1499 const std::string& oat_dir,
1500 const std::string& instruction_set,
1501 bool is_secondary_dex,
1502 unique_fd* oat_file_fd,
1503 unique_fd* vdex_file_fd) {
1504 char oat_path[PKG_PATH_MAX];
1505 if (!create_oat_out_path(apk_path.c_str(),
1506 instruction_set.c_str(),
1507 oat_dir.c_str(),
1508 is_secondary_dex,
1509 oat_path)) {
Calin Juravle7d765462017-09-04 15:57:10 -07001510 LOG(ERROR) << "Could not create oat out path for "
1511 << apk_path << " with oat dir " << oat_dir;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001512 return false;
1513 }
1514 oat_file_fd->reset(open(oat_path, O_RDONLY));
1515 if (oat_file_fd->get() < 0) {
1516 PLOG(INFO) << "installd cannot open oat file during dexopt" << oat_path;
1517 }
1518
1519 std::string vdex_filename = create_vdex_filename(oat_path);
1520 vdex_file_fd->reset(open(vdex_filename.c_str(), O_RDONLY));
1521 if (vdex_file_fd->get() < 0) {
1522 PLOG(INFO) << "installd cannot open vdex file during dexopt" << vdex_filename;
1523 }
1524
1525 return true;
1526}
1527
Calin Juravle7a570e82017-01-14 16:23:30 -08001528// Updates the access times of out_oat_path based on those from apk_path.
1529void update_out_oat_access_times(const char* apk_path, const char* out_oat_path) {
1530 struct stat input_stat;
1531 memset(&input_stat, 0, sizeof(input_stat));
1532 if (stat(apk_path, &input_stat) != 0) {
1533 PLOG(ERROR) << "Could not stat " << apk_path << " during dexopt";
1534 return;
1535 }
1536
1537 struct utimbuf ut;
1538 ut.actime = input_stat.st_atime;
1539 ut.modtime = input_stat.st_mtime;
1540 if (utime(out_oat_path, &ut) != 0) {
1541 PLOG(WARNING) << "Could not update access times for " << apk_path << " during dexopt";
1542 }
1543}
1544
Calin Juravle80a21252017-01-17 14:43:25 -08001545// Runs (execv) dexoptanalyzer on the given arguments.
Calin Juravle114f0812017-03-08 19:05:07 -08001546// The analyzer will check if the dex_file needs to be (re)compiled to match the compiler_filter.
1547// If this is for a profile guided compilation, profile_was_updated will tell whether or not
1548// the profile has changed.
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001549class RunDexoptAnalyzer : public ExecVHelper {
1550 public:
1551 RunDexoptAnalyzer(const std::string& dex_file,
David Brazdil4f6027a2019-03-19 11:44:21 +00001552 int vdex_fd,
1553 int oat_fd,
1554 int zip_fd,
1555 const std::string& instruction_set,
1556 const std::string& compiler_filter,
1557 bool profile_was_updated,
1558 bool downgrade,
1559 const char* class_loader_context,
1560 const std::string& class_loader_context_fds) {
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001561 CHECK_GE(zip_fd, 0);
Calin Juravlef74a7372019-02-28 20:29:41 -08001562
1563 // We always run the analyzer in the background job.
1564 const char* dexoptanalyzer_bin = select_execution_binary(
1565 kDexoptanalyzerPath, kDexoptanalyzerDebugPath, /*background_job_compile=*/ true);
Calin Juravle80a21252017-01-17 14:43:25 -08001566
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001567 std::string dex_file_arg = "--dex-file=" + dex_file;
1568 std::string oat_fd_arg = "--oat-fd=" + std::to_string(oat_fd);
1569 std::string vdex_fd_arg = "--vdex-fd=" + std::to_string(vdex_fd);
1570 std::string zip_fd_arg = "--zip-fd=" + std::to_string(zip_fd);
1571 std::string isa_arg = "--isa=" + instruction_set;
1572 std::string compiler_filter_arg = "--compiler-filter=" + compiler_filter;
1573 const char* assume_profile_changed = "--assume-profile-changed";
1574 const char* downgrade_flag = "--downgrade";
1575 std::string class_loader_context_arg = "--class-loader-context=";
1576 if (class_loader_context != nullptr) {
1577 class_loader_context_arg += class_loader_context;
1578 }
David Brazdil4f6027a2019-03-19 11:44:21 +00001579 std::string class_loader_context_fds_arg = "--class-loader-context-fds=";
1580 if (!class_loader_context_fds.empty()) {
1581 class_loader_context_fds_arg += class_loader_context_fds;
1582 }
Mathieu Chartier31636522018-11-09 23:53:07 +00001583
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001584 // program name, dex file, isa, filter
1585 AddArg(dex_file_arg);
1586 AddArg(isa_arg);
1587 AddArg(compiler_filter_arg);
1588 if (oat_fd >= 0) {
1589 AddArg(oat_fd_arg);
1590 }
1591 if (vdex_fd >= 0) {
1592 AddArg(vdex_fd_arg);
1593 }
Greg Kaiser8042c372019-03-26 06:23:19 -07001594 AddArg(zip_fd_arg);
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001595 if (profile_was_updated) {
1596 AddArg(assume_profile_changed);
1597 }
1598 if (downgrade) {
1599 AddArg(downgrade_flag);
1600 }
1601 if (class_loader_context != nullptr) {
Greg Kaiser8042c372019-03-26 06:23:19 -07001602 AddArg(class_loader_context_arg);
David Brazdil4f6027a2019-03-19 11:44:21 +00001603 if (!class_loader_context_fds.empty()) {
Greg Kaiser8042c372019-03-26 06:23:19 -07001604 AddArg(class_loader_context_fds_arg);
David Brazdil4f6027a2019-03-19 11:44:21 +00001605 }
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001606 }
Mathieu Chartier31636522018-11-09 23:53:07 +00001607
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001608 PrepareArgs(dexoptanalyzer_bin);
1609 }
David Brazdil4f6027a2019-03-19 11:44:21 +00001610
1611 // Dexoptanalyzer mode which flattens the given class loader context and
1612 // prints a list of its dex files in that flattened order.
1613 RunDexoptAnalyzer(const char* class_loader_context) {
1614 CHECK(class_loader_context != nullptr);
1615
1616 // We always run the analyzer in the background job.
1617 const char* dexoptanalyzer_bin = select_execution_binary(
1618 kDexoptanalyzerPath, kDexoptanalyzerDebugPath, /*background_job_compile=*/ true);
1619
1620 AddArg("--flatten-class-loader-context");
1621 AddArg(std::string("--class-loader-context=") + class_loader_context);
1622 PrepareArgs(dexoptanalyzer_bin);
1623 }
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001624};
Calin Juravle80a21252017-01-17 14:43:25 -08001625
1626// Prepares the oat dir for the secondary dex files.
Calin Juravle114f0812017-03-08 19:05:07 -08001627static bool prepare_secondary_dex_oat_dir(const std::string& dex_path, int uid,
Calin Juravle7d765462017-09-04 15:57:10 -07001628 const char* instruction_set) {
Calin Juravle114f0812017-03-08 19:05:07 -08001629 unsigned long dirIndex = dex_path.rfind('/');
Calin Juravle80a21252017-01-17 14:43:25 -08001630 if (dirIndex == std::string::npos) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001631 LOG(ERROR ) << "Unexpected dir structure for secondary dex " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001632 return false;
1633 }
Calin Juravle114f0812017-03-08 19:05:07 -08001634 std::string dex_dir = dex_path.substr(0, dirIndex);
Calin Juravle80a21252017-01-17 14:43:25 -08001635
Calin Juravle80a21252017-01-17 14:43:25 -08001636 // Create oat file output directory.
Calin Juravleebc8a792017-04-04 20:21:05 -07001637 mode_t oat_dir_mode = S_IRWXU | S_IRWXG | S_IXOTH;
1638 if (prepare_app_cache_dir(dex_dir, "oat", oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001639 LOG(ERROR) << "Could not prepare oat dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001640 return false;
1641 }
1642
1643 char oat_dir[PKG_PATH_MAX];
Calin Juravle114f0812017-03-08 19:05:07 -08001644 snprintf(oat_dir, PKG_PATH_MAX, "%s/oat", dex_dir.c_str());
Calin Juravle80a21252017-01-17 14:43:25 -08001645
Calin Juravle7d765462017-09-04 15:57:10 -07001646 if (prepare_app_cache_dir(oat_dir, instruction_set, oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001647 LOG(ERROR) << "Could not prepare oat/isa dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001648 return false;
1649 }
1650
1651 return true;
1652}
1653
Calin Juravle7d765462017-09-04 15:57:10 -07001654// Return codes for identifying the reason why dexoptanalyzer was not invoked when processing
1655// secondary dex files. This return codes are returned by the child process created for
1656// analyzing secondary dex files in process_secondary_dex_dexopt.
Calin Juravle80a21252017-01-17 14:43:25 -08001657
Andreas Gampe194fe422018-02-28 20:16:19 -08001658enum DexoptAnalyzerSkipCodes {
1659 // The dexoptanalyzer was not invoked because of validation or IO errors.
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001660 // Specific errors are encoded in the name.
1661 kSecondaryDexDexoptAnalyzerSkippedValidatePath = 200,
1662 kSecondaryDexDexoptAnalyzerSkippedOpenZip = 201,
1663 kSecondaryDexDexoptAnalyzerSkippedPrepareDir = 202,
1664 kSecondaryDexDexoptAnalyzerSkippedOpenOutput = 203,
1665 kSecondaryDexDexoptAnalyzerSkippedFailExec = 204,
Andreas Gampe194fe422018-02-28 20:16:19 -08001666 // The dexoptanalyzer was not invoked because the dex file does not exist anymore.
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001667 kSecondaryDexDexoptAnalyzerSkippedNoFile = 205,
Andreas Gampe194fe422018-02-28 20:16:19 -08001668};
Calin Juravle7d765462017-09-04 15:57:10 -07001669
1670// Verifies the result of analyzing secondary dex files from process_secondary_dex_dexopt.
Calin Juravle80a21252017-01-17 14:43:25 -08001671// If the result is valid returns true and sets dexopt_needed_out to a valid value.
1672// Returns false for errors or unexpected result values.
Calin Juravle7d765462017-09-04 15:57:10 -07001673// The result is expected to be either one of SECONDARY_DEX_* codes or a valid exit code
1674// of dexoptanalyzer.
1675static bool process_secondary_dexoptanalyzer_result(const std::string& dex_path, int result,
Andreas Gampe194fe422018-02-28 20:16:19 -08001676 int* dexopt_needed_out, std::string* error_msg) {
Calin Juravle80a21252017-01-17 14:43:25 -08001677 // The result values are defined in dexoptanalyzer.
1678 switch (result) {
Calin Juravle7d765462017-09-04 15:57:10 -07001679 case 0: // dexoptanalyzer: no_dexopt_needed
Calin Juravle80a21252017-01-17 14:43:25 -08001680 *dexopt_needed_out = NO_DEXOPT_NEEDED; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001681 case 1: // dexoptanalyzer: dex2oat_from_scratch
Calin Juravle80a21252017-01-17 14:43:25 -08001682 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH; return true;
Vladimir Marko1752a112018-09-03 18:15:16 +01001683 case 4: // dexoptanalyzer: dex2oat_for_bootimage_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001684 *dexopt_needed_out = -DEX2OAT_FOR_BOOT_IMAGE; return true;
Vladimir Marko1752a112018-09-03 18:15:16 +01001685 case 5: // dexoptanalyzer: dex2oat_for_filter_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001686 *dexopt_needed_out = -DEX2OAT_FOR_FILTER; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001687 case 2: // dexoptanalyzer: dex2oat_for_bootimage_oat
1688 case 3: // dexoptanalyzer: dex2oat_for_filter_oat
Andreas Gampe194fe422018-02-28 20:16:19 -08001689 *error_msg = StringPrintf("Dexoptanalyzer return the status of an oat file."
1690 " Expected odex file status for secondary dex %s"
1691 " : dexoptanalyzer result=%d",
1692 dex_path.c_str(),
1693 result);
Calin Juravle80a21252017-01-17 14:43:25 -08001694 return false;
Andreas Gampe194fe422018-02-28 20:16:19 -08001695 }
1696
1697 // Use a second switch for enum switch-case analysis.
1698 switch (static_cast<DexoptAnalyzerSkipCodes>(result)) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001699 case kSecondaryDexDexoptAnalyzerSkippedNoFile:
Calin Juravle7d765462017-09-04 15:57:10 -07001700 // If the file does not exist there's no need for dexopt.
1701 *dexopt_needed_out = NO_DEXOPT_NEEDED;
1702 return true;
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001703
1704 case kSecondaryDexDexoptAnalyzerSkippedValidatePath:
1705 *error_msg = "Dexoptanalyzer path validation failed";
1706 return false;
1707 case kSecondaryDexDexoptAnalyzerSkippedOpenZip:
1708 *error_msg = "Dexoptanalyzer open zip failed";
1709 return false;
1710 case kSecondaryDexDexoptAnalyzerSkippedPrepareDir:
1711 *error_msg = "Dexoptanalyzer dir preparation failed";
1712 return false;
1713 case kSecondaryDexDexoptAnalyzerSkippedOpenOutput:
1714 *error_msg = "Dexoptanalyzer open output failed";
1715 return false;
1716 case kSecondaryDexDexoptAnalyzerSkippedFailExec:
1717 *error_msg = "Dexoptanalyzer failed to execute";
Calin Juravle80a21252017-01-17 14:43:25 -08001718 return false;
1719 }
Andreas Gampe194fe422018-02-28 20:16:19 -08001720
1721 *error_msg = StringPrintf("Unexpected result from analyzing secondary dex %s result=%d",
1722 dex_path.c_str(),
1723 result);
1724 return false;
Calin Juravle80a21252017-01-17 14:43:25 -08001725}
1726
Calin Juravle7d765462017-09-04 15:57:10 -07001727enum SecondaryDexAccess {
1728 kSecondaryDexAccessReadOk = 0,
1729 kSecondaryDexAccessDoesNotExist = 1,
1730 kSecondaryDexAccessPermissionError = 2,
1731 kSecondaryDexAccessIOError = 3
1732};
1733
1734static SecondaryDexAccess check_secondary_dex_access(const std::string& dex_path) {
1735 // Check if the path exists and can be read. If not, there's nothing to do.
1736 if (access(dex_path.c_str(), R_OK) == 0) {
1737 return kSecondaryDexAccessReadOk;
1738 } else {
1739 if (errno == ENOENT) {
1740 LOG(INFO) << "Secondary dex does not exist: " << dex_path;
1741 return kSecondaryDexAccessDoesNotExist;
1742 } else {
1743 PLOG(ERROR) << "Could not access secondary dex " << dex_path;
1744 return errno == EACCES
1745 ? kSecondaryDexAccessPermissionError
1746 : kSecondaryDexAccessIOError;
1747 }
1748 }
1749}
1750
1751static bool is_file_public(const std::string& filename) {
1752 struct stat file_stat;
1753 if (stat(filename.c_str(), &file_stat) == 0) {
1754 return (file_stat.st_mode & S_IROTH) != 0;
1755 }
1756 return false;
1757}
1758
1759// Create the oat file structure for the secondary dex 'dex_path' and assign
1760// the individual path component to the 'out_' parameters.
1761static bool create_secondary_dex_oat_layout(const std::string& dex_path, const std::string& isa,
Andreas Gampe194fe422018-02-28 20:16:19 -08001762 char* out_oat_dir, char* out_oat_isa_dir, char* out_oat_path, std::string* error_msg) {
Calin Juravle7d765462017-09-04 15:57:10 -07001763 size_t dirIndex = dex_path.rfind('/');
1764 if (dirIndex == std::string::npos) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001765 *error_msg = std::string("Unexpected dir structure for dex file ").append(dex_path);
Calin Juravle7d765462017-09-04 15:57:10 -07001766 return false;
1767 }
1768 // TODO(calin): we have similar computations in at lest 3 other places
1769 // (InstalldNativeService, otapropt and dexopt). Unify them and get rid of snprintf by
1770 // using string append.
1771 std::string apk_dir = dex_path.substr(0, dirIndex);
1772 snprintf(out_oat_dir, PKG_PATH_MAX, "%s/oat", apk_dir.c_str());
1773 snprintf(out_oat_isa_dir, PKG_PATH_MAX, "%s/%s", out_oat_dir, isa.c_str());
1774
1775 if (!create_oat_out_path(dex_path.c_str(), isa.c_str(), out_oat_dir,
1776 /*is_secondary_dex*/true, out_oat_path)) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001777 *error_msg = std::string("Could not create oat path for secondary dex ").append(dex_path);
Calin Juravle7d765462017-09-04 15:57:10 -07001778 return false;
1779 }
1780 return true;
1781}
1782
1783// Validate that the dexopt_flags contain a valid storage flag and convert that to an installd
1784// recognized storage flags (FLAG_STORAGE_CE or FLAG_STORAGE_DE).
Andreas Gampe194fe422018-02-28 20:16:19 -08001785static bool validate_dexopt_storage_flags(int dexopt_flags,
1786 int* out_storage_flag,
1787 std::string* error_msg) {
Calin Juravle7d765462017-09-04 15:57:10 -07001788 if ((dexopt_flags & DEXOPT_STORAGE_CE) != 0) {
1789 *out_storage_flag = FLAG_STORAGE_CE;
1790 if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001791 *error_msg = "Ambiguous secondary dex storage flag. Both, CE and DE, flags are set";
Calin Juravle7d765462017-09-04 15:57:10 -07001792 return false;
1793 }
1794 } else if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
1795 *out_storage_flag = FLAG_STORAGE_DE;
1796 } else {
Andreas Gampe194fe422018-02-28 20:16:19 -08001797 *error_msg = "Secondary dex storage flag must be set";
Calin Juravle7d765462017-09-04 15:57:10 -07001798 return false;
1799 }
1800 return true;
1801}
1802
David Brazdil4f6027a2019-03-19 11:44:21 +00001803static bool get_class_loader_context_dex_paths(const char* class_loader_context, int uid,
1804 /* out */ std::vector<std::string>* context_dex_paths) {
1805 if (class_loader_context == nullptr) {
1806 return true;
1807 }
1808
1809 LOG(DEBUG) << "Getting dex paths for context " << class_loader_context;
1810
1811 // Pipe to get the hash result back from our child process.
1812 unique_fd pipe_read, pipe_write;
1813 if (!Pipe(&pipe_read, &pipe_write)) {
1814 PLOG(ERROR) << "Failed to create pipe";
1815 return false;
1816 }
1817
1818 pid_t pid = fork();
1819 if (pid == 0) {
1820 // child -- drop privileges before continuing.
1821 drop_capabilities(uid);
1822
1823 // Route stdout to `pipe_write`
1824 while ((dup2(pipe_write, STDOUT_FILENO) == -1) && (errno == EINTR)) {}
1825 pipe_write.reset();
1826 pipe_read.reset();
1827
1828 RunDexoptAnalyzer run_dexopt_analyzer(class_loader_context);
1829 run_dexopt_analyzer.Exec(kSecondaryDexDexoptAnalyzerSkippedFailExec);
1830 }
1831
1832 /* parent */
1833 pipe_write.reset();
1834
1835 std::string str_dex_paths;
1836 if (!ReadFdToString(pipe_read, &str_dex_paths)) {
1837 PLOG(ERROR) << "Failed to read from pipe";
1838 return false;
1839 }
1840 pipe_read.reset();
1841
1842 int return_code = wait_child(pid);
1843 if (!WIFEXITED(return_code)) {
1844 PLOG(ERROR) << "Error waiting for child dexoptanalyzer process";
1845 return false;
1846 }
1847
1848 constexpr int kFlattenClassLoaderContextSuccess = 50;
1849 return_code = WEXITSTATUS(return_code);
1850 if (return_code != kFlattenClassLoaderContextSuccess) {
1851 LOG(ERROR) << "Dexoptanalyzer could not flatten class loader context, code=" << return_code;
1852 return false;
1853 }
1854
1855 if (!str_dex_paths.empty()) {
1856 *context_dex_paths = android::base::Split(str_dex_paths, ":");
1857 }
1858 return true;
1859}
1860
1861static int open_dex_paths(const std::vector<std::string>& dex_paths,
1862 /* out */ std::vector<unique_fd>* zip_fds, /* out */ std::string* error_msg) {
1863 for (const std::string& dex_path : dex_paths) {
1864 zip_fds->emplace_back(open(dex_path.c_str(), O_RDONLY));
1865 if (zip_fds->back().get() < 0) {
1866 *error_msg = StringPrintf(
1867 "installd cannot open '%s' for input during dexopt", dex_path.c_str());
1868 if (errno == ENOENT) {
1869 return kSecondaryDexDexoptAnalyzerSkippedNoFile;
1870 } else {
1871 return kSecondaryDexDexoptAnalyzerSkippedOpenZip;
1872 }
1873 }
1874 }
1875 return 0;
1876}
1877
1878static std::string join_fds(const std::vector<unique_fd>& fds) {
1879 std::stringstream ss;
1880 bool is_first = true;
1881 for (const unique_fd& fd : fds) {
1882 if (is_first) {
1883 is_first = false;
1884 } else {
1885 ss << ":";
1886 }
1887 ss << fd.get();
1888 }
1889 return ss.str();
1890}
1891
Calin Juravlec9eab382017-01-25 01:17:17 -08001892// Processes the dex_path as a secondary dex files and return true if the path dex file should
Calin Juravle80a21252017-01-17 14:43:25 -08001893// be compiled. Returns false for errors (logged) or true if the secondary dex path was process
1894// successfully.
Calin Juravleebc8a792017-04-04 20:21:05 -07001895// When returning true, the output parameters will be:
1896// - is_public_out: whether or not the oat file should not be made public
1897// - dexopt_needed_out: valid OatFileAsssitant::DexOptNeeded
1898// - oat_dir_out: the oat dir path where the oat file should be stored
Calin Juravle7d765462017-09-04 15:57:10 -07001899static bool process_secondary_dex_dexopt(const std::string& dex_path, const char* pkgname,
Calin Juravle80a21252017-01-17 14:43:25 -08001900 int dexopt_flags, const char* volume_uuid, int uid, const char* instruction_set,
Calin Juravleebc8a792017-04-04 20:21:05 -07001901 const char* compiler_filter, bool* is_public_out, int* dexopt_needed_out,
Andreas Gampe194fe422018-02-28 20:16:19 -08001902 std::string* oat_dir_out, bool downgrade, const char* class_loader_context,
David Brazdil4f6027a2019-03-19 11:44:21 +00001903 const std::vector<std::string>& context_dex_paths, /* out */ std::string* error_msg) {
Calin Juravle7d765462017-09-04 15:57:10 -07001904 LOG(DEBUG) << "Processing secondary dex path " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001905 int storage_flag;
Andreas Gampe194fe422018-02-28 20:16:19 -08001906 if (!validate_dexopt_storage_flags(dexopt_flags, &storage_flag, error_msg)) {
1907 LOG(ERROR) << *error_msg;
Calin Juravle80a21252017-01-17 14:43:25 -08001908 return false;
1909 }
Calin Juravle7d765462017-09-04 15:57:10 -07001910 // Compute the oat dir as it's not easy to extract it from the child computation.
1911 char oat_path[PKG_PATH_MAX];
1912 char oat_dir[PKG_PATH_MAX];
1913 char oat_isa_dir[PKG_PATH_MAX];
1914 if (!create_secondary_dex_oat_layout(
Andreas Gampe194fe422018-02-28 20:16:19 -08001915 dex_path, instruction_set, oat_dir, oat_isa_dir, oat_path, error_msg)) {
1916 LOG(ERROR) << "Could not create secondary odex layout: " << *error_msg;
Calin Juravled23dee72017-07-06 16:29:11 -07001917 return false;
1918 }
Calin Juravle7d765462017-09-04 15:57:10 -07001919 oat_dir_out->assign(oat_dir);
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001920
Calin Juravle80a21252017-01-17 14:43:25 -08001921 pid_t pid = fork();
1922 if (pid == 0) {
1923 // child -- drop privileges before continuing.
1924 drop_capabilities(uid);
Calin Juravle7d765462017-09-04 15:57:10 -07001925
1926 // Validate the path structure.
1927 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid, uid, storage_flag)) {
1928 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001929 _exit(kSecondaryDexDexoptAnalyzerSkippedValidatePath);
Calin Juravle7d765462017-09-04 15:57:10 -07001930 }
1931
1932 // Open the dex file.
1933 unique_fd zip_fd;
1934 zip_fd.reset(open(dex_path.c_str(), O_RDONLY));
1935 if (zip_fd.get() < 0) {
1936 if (errno == ENOENT) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001937 _exit(kSecondaryDexDexoptAnalyzerSkippedNoFile);
Calin Juravle7d765462017-09-04 15:57:10 -07001938 } else {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001939 _exit(kSecondaryDexDexoptAnalyzerSkippedOpenZip);
Calin Juravle7d765462017-09-04 15:57:10 -07001940 }
1941 }
1942
David Brazdil4f6027a2019-03-19 11:44:21 +00001943 // Open class loader context dex files.
1944 std::vector<unique_fd> context_zip_fds;
1945 int open_dex_paths_rc = open_dex_paths(context_dex_paths, &context_zip_fds, error_msg);
1946 if (open_dex_paths_rc != 0) {
1947 _exit(open_dex_paths_rc);
1948 }
1949
Calin Juravle7d765462017-09-04 15:57:10 -07001950 // Prepare the oat directories.
1951 if (!prepare_secondary_dex_oat_dir(dex_path, uid, instruction_set)) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001952 _exit(kSecondaryDexDexoptAnalyzerSkippedPrepareDir);
Calin Juravle7d765462017-09-04 15:57:10 -07001953 }
1954
1955 // Open the vdex/oat files if any.
1956 unique_fd oat_file_fd;
1957 unique_fd vdex_file_fd;
1958 if (!maybe_open_oat_and_vdex_file(dex_path,
1959 *oat_dir_out,
1960 instruction_set,
1961 true /* is_secondary_dex */,
1962 &oat_file_fd,
1963 &vdex_file_fd)) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001964 _exit(kSecondaryDexDexoptAnalyzerSkippedOpenOutput);
Calin Juravle7d765462017-09-04 15:57:10 -07001965 }
1966
1967 // Analyze profiles.
Calin Juravle824a64d2018-01-18 20:23:17 -08001968 bool profile_was_updated = analyze_profiles(uid, pkgname, dex_path,
1969 /*is_secondary_dex*/true);
Calin Juravle7d765462017-09-04 15:57:10 -07001970
1971 // Run dexoptanalyzer to get dexopt_needed code. This is not expected to return.
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001972 // Note that we do not do it before the fork since opening the files is required to happen
1973 // after forking.
1974 RunDexoptAnalyzer run_dexopt_analyzer(dex_path,
1975 vdex_file_fd.get(),
1976 oat_file_fd.get(),
1977 zip_fd.get(),
1978 instruction_set,
1979 compiler_filter, profile_was_updated,
1980 downgrade,
David Brazdil4f6027a2019-03-19 11:44:21 +00001981 class_loader_context,
1982 join_fds(context_zip_fds));
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001983 run_dexopt_analyzer.Exec(kSecondaryDexDexoptAnalyzerSkippedFailExec);
Calin Juravle80a21252017-01-17 14:43:25 -08001984 }
1985
1986 /* parent */
Calin Juravle80a21252017-01-17 14:43:25 -08001987 int result = wait_child(pid);
1988 if (!WIFEXITED(result)) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001989 *error_msg = StringPrintf("dexoptanalyzer failed for path %s: 0x%04x",
1990 dex_path.c_str(),
1991 result);
1992 LOG(ERROR) << *error_msg;
Calin Juravle80a21252017-01-17 14:43:25 -08001993 return false;
1994 }
1995 result = WEXITSTATUS(result);
Calin Juravle7d765462017-09-04 15:57:10 -07001996 // Check that we successfully executed dexoptanalyzer.
Andreas Gampe194fe422018-02-28 20:16:19 -08001997 bool success = process_secondary_dexoptanalyzer_result(dex_path,
1998 result,
1999 dexopt_needed_out,
2000 error_msg);
2001 if (!success) {
2002 LOG(ERROR) << *error_msg;
2003 }
Calin Juravle7d765462017-09-04 15:57:10 -07002004
2005 LOG(DEBUG) << "Processed secondary dex file " << dex_path << " result=" << result;
2006
Calin Juravle80a21252017-01-17 14:43:25 -08002007 // Run dexopt only if needed or forced.
Calin Juravle7d765462017-09-04 15:57:10 -07002008 // Note that dexoptanalyzer is executed even if force compilation is enabled (because it
2009 // makes the code simpler; force compilation is only needed during tests).
2010 if (success &&
Andreas Gampe3008bbe2018-02-28 20:24:48 -08002011 (result != kSecondaryDexDexoptAnalyzerSkippedNoFile) &&
Calin Juravle7d765462017-09-04 15:57:10 -07002012 ((dexopt_flags & DEXOPT_FORCE) != 0)) {
Calin Juravle80a21252017-01-17 14:43:25 -08002013 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH;
2014 }
2015
Calin Juravle7d765462017-09-04 15:57:10 -07002016 // Check if we should make the oat file public.
2017 // Note that if the dex file is not public the compiled code cannot be made public.
2018 // It is ok to check this flag outside in the parent process.
2019 *is_public_out = ((dexopt_flags & DEXOPT_PUBLIC) != 0) && is_file_public(dex_path);
2020
Calin Juravle80a21252017-01-17 14:43:25 -08002021 return success;
2022}
2023
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002024static std::string format_dexopt_error(int status, const char* dex_path) {
2025 if (WIFEXITED(status)) {
2026 int int_code = WEXITSTATUS(status);
2027 const char* code_name = get_return_code_name(static_cast<DexoptReturnCodes>(int_code));
2028 if (code_name != nullptr) {
2029 return StringPrintf("Dex2oat invocation for %s failed: %s", dex_path, code_name);
2030 }
2031 }
2032 return StringPrintf("Dex2oat invocation for %s failed with 0x%04x", dex_path, status);
Andreas Gampe023b2242018-02-28 16:03:25 -08002033}
2034
Calin Juravlec9eab382017-01-25 01:17:17 -08002035int dexopt(const char* dex_path, uid_t uid, const char* pkgname, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -08002036 int dexopt_needed, const char* oat_dir, int dexopt_flags, const char* compiler_filter,
Calin Juravle52c45822017-07-13 22:50:21 -07002037 const char* volume_uuid, const char* class_loader_context, const char* se_info,
Calin Juravle62c5a372018-02-01 17:03:23 +00002038 bool downgrade, int target_sdk_version, const char* profile_name,
Andreas Gampe023b2242018-02-28 16:03:25 -08002039 const char* dex_metadata_path, const char* compilation_reason, std::string* error_msg) {
Calin Juravle7a570e82017-01-14 16:23:30 -08002040 CHECK(pkgname != nullptr);
2041 CHECK(pkgname[0] != 0);
Andreas Gampe023b2242018-02-28 16:03:25 -08002042 CHECK(error_msg != nullptr);
Andreas Gamped32eec22018-02-28 16:02:51 -08002043 CHECK_EQ(dexopt_flags & ~DEXOPT_MASK, 0)
2044 << "dexopt flags contains unknown fields: " << dexopt_flags;
Calin Juravle7a570e82017-01-14 16:23:30 -08002045
Calin Juravled23dee72017-07-06 16:29:11 -07002046 if (!validate_dex_path_size(dex_path)) {
Andreas Gampe023b2242018-02-28 16:03:25 -08002047 *error_msg = StringPrintf("Failed to validate %s", dex_path);
Calin Juravle52c45822017-07-13 22:50:21 -07002048 return -1;
2049 }
2050
2051 if (class_loader_context != nullptr && strlen(class_loader_context) > PKG_PATH_MAX) {
Andreas Gampe023b2242018-02-28 16:03:25 -08002052 *error_msg = StringPrintf("Class loader context exceeds the allowed size: %s",
2053 class_loader_context);
2054 LOG(ERROR) << *error_msg;
Calin Juravle52c45822017-07-13 22:50:21 -07002055 return -1;
Calin Juravled23dee72017-07-06 16:29:11 -07002056 }
2057
Calin Juravleebc8a792017-04-04 20:21:05 -07002058 bool is_public = (dexopt_flags & DEXOPT_PUBLIC) != 0;
Calin Juravle7a570e82017-01-14 16:23:30 -08002059 bool debuggable = (dexopt_flags & DEXOPT_DEBUGGABLE) != 0;
2060 bool boot_complete = (dexopt_flags & DEXOPT_BOOTCOMPLETE) != 0;
2061 bool profile_guided = (dexopt_flags & DEXOPT_PROFILE_GUIDED) != 0;
Calin Juravle80a21252017-01-17 14:43:25 -08002062 bool is_secondary_dex = (dexopt_flags & DEXOPT_SECONDARY_DEX) != 0;
Andreas Gampea73a0cb2017-11-02 18:14:42 -07002063 bool background_job_compile = (dexopt_flags & DEXOPT_IDLE_BACKGROUND_JOB) != 0;
David Brazdil52249162018-02-12 18:04:59 -08002064 bool enable_hidden_api_checks = (dexopt_flags & DEXOPT_ENABLE_HIDDEN_API_CHECKS) != 0;
Mathieu Chartierf69c2f72018-03-06 13:55:58 -08002065 bool generate_compact_dex = (dexopt_flags & DEXOPT_GENERATE_COMPACT_DEX) != 0;
Mathieu Chartier1dc3dfa2018-03-12 17:55:06 -07002066 bool generate_app_image = (dexopt_flags & DEXOPT_GENERATE_APP_IMAGE) != 0;
Calin Juravle80a21252017-01-17 14:43:25 -08002067
2068 // Check if we're dealing with a secondary dex file and if we need to compile it.
2069 std::string oat_dir_str;
David Brazdil4f6027a2019-03-19 11:44:21 +00002070 std::vector<std::string> context_dex_paths;
Calin Juravle80a21252017-01-17 14:43:25 -08002071 if (is_secondary_dex) {
David Brazdil4f6027a2019-03-19 11:44:21 +00002072 if (!get_class_loader_context_dex_paths(class_loader_context, uid, &context_dex_paths)) {
2073 *error_msg = "Failed acquiring context dex paths";
2074 return -1; // We had an error, logged in the process method.
2075 }
2076
Calin Juravlec9eab382017-01-25 01:17:17 -08002077 if (process_secondary_dex_dexopt(dex_path, pkgname, dexopt_flags, volume_uuid, uid,
Calin Juravleebc8a792017-04-04 20:21:05 -07002078 instruction_set, compiler_filter, &is_public, &dexopt_needed, &oat_dir_str,
David Brazdil4f6027a2019-03-19 11:44:21 +00002079 downgrade, class_loader_context, context_dex_paths, error_msg)) {
Calin Juravle80a21252017-01-17 14:43:25 -08002080 oat_dir = oat_dir_str.c_str();
2081 if (dexopt_needed == NO_DEXOPT_NEEDED) {
2082 return 0; // Nothing to do, report success.
2083 }
2084 } else {
Andreas Gampe194fe422018-02-28 20:16:19 -08002085 if (error_msg->empty()) { // TODO: Make this a CHECK.
2086 *error_msg = "Failed processing secondary.";
2087 }
Calin Juravle80a21252017-01-17 14:43:25 -08002088 return -1; // We had an error, logged in the process method.
2089 }
2090 } else {
David Brazdil4f6027a2019-03-19 11:44:21 +00002091 // Currently these flags are only used for secondary dex files.
Calin Juravlec9eab382017-01-25 01:17:17 -08002092 // Verify that they are not set for primary apks.
Calin Juravle80a21252017-01-17 14:43:25 -08002093 CHECK((dexopt_flags & DEXOPT_STORAGE_CE) == 0);
2094 CHECK((dexopt_flags & DEXOPT_STORAGE_DE) == 0);
2095 }
Calin Juravle7a570e82017-01-14 16:23:30 -08002096
2097 // Open the input file.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08002098 unique_fd input_fd(open(dex_path, O_RDONLY, 0));
Calin Juravle7a570e82017-01-14 16:23:30 -08002099 if (input_fd.get() < 0) {
Andreas Gampe023b2242018-02-28 16:03:25 -08002100 *error_msg = StringPrintf("installd cannot open '%s' for input during dexopt", dex_path);
2101 LOG(ERROR) << *error_msg;
Calin Juravle7a570e82017-01-14 16:23:30 -08002102 return -1;
2103 }
2104
David Brazdil4f6027a2019-03-19 11:44:21 +00002105 // Open class loader context dex files.
2106 std::vector<unique_fd> context_input_fds;
2107 if (open_dex_paths(context_dex_paths, &context_input_fds, error_msg) != 0) {
2108 LOG(ERROR) << *error_msg;
2109 return -1;
2110 }
2111
Calin Juravle7a570e82017-01-14 16:23:30 -08002112 // Create the output OAT file.
2113 char out_oat_path[PKG_PATH_MAX];
Calin Juravlec9eab382017-01-25 01:17:17 -08002114 Dex2oatFileWrapper out_oat_fd = open_oat_out_file(dex_path, oat_dir, is_public, uid,
Calin Juravle80a21252017-01-17 14:43:25 -08002115 instruction_set, is_secondary_dex, out_oat_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08002116 if (out_oat_fd.get() < 0) {
Andreas Gampe023b2242018-02-28 16:03:25 -08002117 *error_msg = "Could not open out oat file.";
Calin Juravle7a570e82017-01-14 16:23:30 -08002118 return -1;
2119 }
2120
2121 // Open vdex files.
2122 Dex2oatFileWrapper in_vdex_fd;
2123 Dex2oatFileWrapper out_vdex_fd;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07002124 if (!open_vdex_files_for_dex2oat(dex_path, out_oat_path, dexopt_needed, instruction_set,
2125 is_public, uid, is_secondary_dex, profile_guided, &in_vdex_fd, &out_vdex_fd)) {
Andreas Gampe023b2242018-02-28 16:03:25 -08002126 *error_msg = "Could not open vdex files.";
Jeff Sharkey90aff262016-12-12 14:28:24 -07002127 return -1;
2128 }
2129
Calin Juravlecb556e32017-04-04 20:22:50 -07002130 // Ensure that the oat dir and the compiler artifacts of secondary dex files have the correct
2131 // selinux context (we generate them on the fly during the dexopt invocation and they don't
2132 // fully inherit their parent context).
2133 // Note that for primary apk the oat files are created before, in a separate installd
2134 // call which also does the restorecon. TODO(calin): unify the paths.
2135 if (is_secondary_dex) {
2136 if (selinux_android_restorecon_pkgdir(oat_dir, se_info, uid,
2137 SELINUX_ANDROID_RESTORECON_RECURSE)) {
Andreas Gampe023b2242018-02-28 16:03:25 -08002138 *error_msg = std::string("Failed to restorecon ").append(oat_dir);
2139 LOG(ERROR) << *error_msg;
Calin Juravlecb556e32017-04-04 20:22:50 -07002140 return -1;
2141 }
2142 }
2143
Jeff Sharkey90aff262016-12-12 14:28:24 -07002144 // Create a swap file if necessary.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08002145 unique_fd swap_fd = maybe_open_dexopt_swap_file(out_oat_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002146
Calin Juravle7a570e82017-01-14 16:23:30 -08002147 // Open the reference profile if needed.
Calin Juravle114f0812017-03-08 19:05:07 -08002148 Dex2oatFileWrapper reference_profile_fd = maybe_open_reference_profile(
Calin Juravle824a64d2018-01-18 20:23:17 -08002149 pkgname, dex_path, profile_name, profile_guided, is_public, uid, is_secondary_dex);
Calin Juravle7a570e82017-01-14 16:23:30 -08002150
liulvping61907742018-08-21 09:36:52 +08002151 if (reference_profile_fd.get() == -1) {
2152 // We don't create an app image without reference profile since there is no speedup from
2153 // loading it in that case and instead will be a small overhead.
2154 generate_app_image = false;
2155 }
2156
2157 // Create the app image file if needed.
2158 Dex2oatFileWrapper image_fd = maybe_open_app_image(
2159 out_oat_path, generate_app_image, is_public, uid, is_secondary_dex);
2160
Calin Juravle62c5a372018-02-01 17:03:23 +00002161 unique_fd dex_metadata_fd;
2162 if (dex_metadata_path != nullptr) {
2163 dex_metadata_fd.reset(TEMP_FAILURE_RETRY(open(dex_metadata_path, O_RDONLY | O_NOFOLLOW)));
2164 if (dex_metadata_fd.get() < 0) {
2165 PLOG(ERROR) << "Failed to open dex metadata file " << dex_metadata_path;
2166 }
2167 }
2168
Andreas Gampe023b2242018-02-28 16:03:25 -08002169 LOG(VERBOSE) << "DexInv: --- BEGIN '" << dex_path << "' ---";
Jeff Sharkey90aff262016-12-12 14:28:24 -07002170
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002171 RunDex2Oat runner(input_fd.get(),
2172 out_oat_fd.get(),
2173 in_vdex_fd.get(),
2174 out_vdex_fd.get(),
2175 image_fd.get(),
2176 dex_path,
2177 out_oat_path,
2178 swap_fd.get(),
2179 instruction_set,
2180 compiler_filter,
2181 debuggable,
2182 boot_complete,
2183 background_job_compile,
2184 reference_profile_fd.get(),
2185 class_loader_context,
David Brazdil4f6027a2019-03-19 11:44:21 +00002186 join_fds(context_input_fds),
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002187 target_sdk_version,
2188 enable_hidden_api_checks,
2189 generate_compact_dex,
2190 dex_metadata_fd.get(),
2191 compilation_reason);
2192
Jeff Sharkey90aff262016-12-12 14:28:24 -07002193 pid_t pid = fork();
2194 if (pid == 0) {
2195 /* child -- drop privileges before continuing */
2196 drop_capabilities(uid);
2197
Richard Uhler76cc0272016-12-08 10:46:35 +00002198 SetDex2OatScheduling(boot_complete);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002199 if (flock(out_oat_fd.get(), LOCK_EX | LOCK_NB) != 0) {
Andreas Gampe023b2242018-02-28 16:03:25 -08002200 PLOG(ERROR) << "flock(" << out_oat_path << ") failed";
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002201 _exit(DexoptReturnCodes::kFlock);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002202 }
2203
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002204 runner.Exec(DexoptReturnCodes::kDex2oatExec);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002205 } else {
2206 int res = wait_child(pid);
2207 if (res == 0) {
Andreas Gampe023b2242018-02-28 16:03:25 -08002208 LOG(VERBOSE) << "DexInv: --- END '" << dex_path << "' (success) ---";
Jeff Sharkey90aff262016-12-12 14:28:24 -07002209 } else {
Andreas Gampe023b2242018-02-28 16:03:25 -08002210 LOG(VERBOSE) << "DexInv: --- END '" << dex_path << "' --- status=0x"
2211 << std::hex << std::setw(4) << res << ", process failed";
2212 *error_msg = format_dexopt_error(res, dex_path);
Andreas Gampe013f02e2017-03-20 18:36:54 -07002213 return res;
Jeff Sharkey90aff262016-12-12 14:28:24 -07002214 }
2215 }
2216
Calin Juravlec9eab382017-01-25 01:17:17 -08002217 update_out_oat_access_times(dex_path, out_oat_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002218
2219 // We've been successful, don't delete output.
2220 out_oat_fd.SetCleanup(false);
Calin Juravle7a570e82017-01-14 16:23:30 -08002221 out_vdex_fd.SetCleanup(false);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002222 image_fd.SetCleanup(false);
2223 reference_profile_fd.SetCleanup(false);
2224
2225 return 0;
2226}
2227
Calin Juravlec9eab382017-01-25 01:17:17 -08002228// Try to remove the given directory. Log an error if the directory exists
2229// and is empty but could not be removed.
2230static bool rmdir_if_empty(const char* dir) {
2231 if (rmdir(dir) == 0) {
2232 return true;
2233 }
2234 if (errno == ENOENT || errno == ENOTEMPTY) {
2235 return true;
2236 }
2237 PLOG(ERROR) << "Failed to remove dir: " << dir;
2238 return false;
2239}
2240
2241// Try to unlink the given file. Log an error if the file exists and could not
2242// be unlinked.
2243static bool unlink_if_exists(const std::string& file) {
2244 if (unlink(file.c_str()) == 0) {
2245 return true;
2246 }
2247 if (errno == ENOENT) {
2248 return true;
2249
2250 }
2251 PLOG(ERROR) << "Could not unlink: " << file;
2252 return false;
2253}
2254
Calin Juravle7d765462017-09-04 15:57:10 -07002255enum ReconcileSecondaryDexResult {
2256 kReconcileSecondaryDexExists = 0,
2257 kReconcileSecondaryDexCleanedUp = 1,
2258 kReconcileSecondaryDexValidationError = 2,
2259 kReconcileSecondaryDexCleanUpError = 3,
2260 kReconcileSecondaryDexAccessIOError = 4,
2261};
Calin Juravlec9eab382017-01-25 01:17:17 -08002262
2263// Reconcile the secondary dex 'dex_path' and its generated oat files.
2264// Return true if all the parameters are valid and the secondary dex file was
2265// processed successfully (i.e. the dex_path either exists, or if not, its corresponding
2266// oat/vdex/art files where deleted successfully). In this case, out_secondary_dex_exists
2267// will be true if the secondary dex file still exists. If the secondary dex file does not exist,
2268// the method cleans up any previously generated compiler artifacts (oat, vdex, art).
2269// Return false if there were errors during processing. In this case
2270// out_secondary_dex_exists will be set to false.
2271bool reconcile_secondary_dex_file(const std::string& dex_path,
2272 const std::string& pkgname, int uid, const std::vector<std::string>& isas,
2273 const std::unique_ptr<std::string>& volume_uuid, int storage_flag,
2274 /*out*/bool* out_secondary_dex_exists) {
Calin Juravle7d765462017-09-04 15:57:10 -07002275 *out_secondary_dex_exists = false; // start by assuming the file does not exist.
Calin Juravlec9eab382017-01-25 01:17:17 -08002276 if (isas.size() == 0) {
2277 LOG(ERROR) << "reconcile_secondary_dex_file called with empty isas vector";
2278 return false;
2279 }
2280
Calin Juravle7d765462017-09-04 15:57:10 -07002281 if (storage_flag != FLAG_STORAGE_CE && storage_flag != FLAG_STORAGE_DE) {
2282 LOG(ERROR) << "reconcile_secondary_dex_file called with invalid storage_flag: "
2283 << storage_flag;
Calin Juravlec9eab382017-01-25 01:17:17 -08002284 return false;
2285 }
2286
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002287 // As a security measure we want to unlink art artifacts with the reduced capabilities
2288 // of the package user id. So we fork and drop capabilities in the child.
2289 pid_t pid = fork();
2290 if (pid == 0) {
Calin Juravle7d765462017-09-04 15:57:10 -07002291 /* child -- drop privileges before continuing */
2292 drop_capabilities(uid);
2293
2294 const char* volume_uuid_cstr = volume_uuid == nullptr ? nullptr : volume_uuid->c_str();
Greg Kaiser8042c372019-03-26 06:23:19 -07002295 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid_cstr,
Calin Juravle7d765462017-09-04 15:57:10 -07002296 uid, storage_flag)) {
2297 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
2298 _exit(kReconcileSecondaryDexValidationError);
2299 }
2300
2301 SecondaryDexAccess access_check = check_secondary_dex_access(dex_path);
2302 switch (access_check) {
2303 case kSecondaryDexAccessDoesNotExist:
2304 // File does not exist. Proceed with cleaning.
2305 break;
2306 case kSecondaryDexAccessReadOk: _exit(kReconcileSecondaryDexExists);
2307 case kSecondaryDexAccessIOError: _exit(kReconcileSecondaryDexAccessIOError);
2308 case kSecondaryDexAccessPermissionError: _exit(kReconcileSecondaryDexValidationError);
2309 default:
2310 LOG(ERROR) << "Unexpected result from check_secondary_dex_access: " << access_check;
2311 _exit(kReconcileSecondaryDexValidationError);
2312 }
2313
2314 // The secondary dex does not exist anymore or it's. Clear any generated files.
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002315 char oat_path[PKG_PATH_MAX];
2316 char oat_dir[PKG_PATH_MAX];
2317 char oat_isa_dir[PKG_PATH_MAX];
2318 bool result = true;
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002319 for (size_t i = 0; i < isas.size(); i++) {
Andreas Gampe194fe422018-02-28 20:16:19 -08002320 std::string error_msg;
Calin Juravle7d765462017-09-04 15:57:10 -07002321 if (!create_secondary_dex_oat_layout(
Andreas Gampe194fe422018-02-28 20:16:19 -08002322 dex_path,isas[i], oat_dir, oat_isa_dir, oat_path, &error_msg)) {
2323 LOG(ERROR) << error_msg;
Calin Juravle7d765462017-09-04 15:57:10 -07002324 _exit(kReconcileSecondaryDexValidationError);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002325 }
Calin Juravle51314092017-05-18 15:33:05 -07002326
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002327 // Delete oat/vdex/art files.
2328 result = unlink_if_exists(oat_path) && result;
2329 result = unlink_if_exists(create_vdex_filename(oat_path)) && result;
2330 result = unlink_if_exists(create_image_filename(oat_path)) && result;
Calin Juravlec9eab382017-01-25 01:17:17 -08002331
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002332 // Delete profiles.
2333 std::string current_profile = create_current_profile_path(
Calin Juravle824a64d2018-01-18 20:23:17 -08002334 multiuser_get_user_id(uid), pkgname, dex_path, /*is_secondary*/true);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002335 std::string reference_profile = create_reference_profile_path(
Calin Juravle824a64d2018-01-18 20:23:17 -08002336 pkgname, dex_path, /*is_secondary*/true);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002337 result = unlink_if_exists(current_profile) && result;
2338 result = unlink_if_exists(reference_profile) && result;
Calin Juravle51314092017-05-18 15:33:05 -07002339
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002340 // We upgraded once the location of current profile for secondary dex files.
2341 // Check for any previous left-overs and remove them as well.
2342 std::string old_current_profile = dex_path + ".prof";
2343 result = unlink_if_exists(old_current_profile);
Calin Juravle3760ad32017-07-27 16:31:55 -07002344
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002345 // Try removing the directories as well, they might be empty.
2346 result = rmdir_if_empty(oat_isa_dir) && result;
2347 result = rmdir_if_empty(oat_dir) && result;
2348 }
Calin Juravle7d765462017-09-04 15:57:10 -07002349 if (!result) {
2350 PLOG(ERROR) << "Failed to clean secondary dex artifacts for location " << dex_path;
2351 }
2352 _exit(result ? kReconcileSecondaryDexCleanedUp : kReconcileSecondaryDexAccessIOError);
Calin Juravlec9eab382017-01-25 01:17:17 -08002353 }
2354
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002355 int return_code = wait_child(pid);
Calin Juravle7d765462017-09-04 15:57:10 -07002356 if (!WIFEXITED(return_code)) {
2357 LOG(WARNING) << "reconcile dex failed for location " << dex_path << ": " << return_code;
2358 } else {
2359 return_code = WEXITSTATUS(return_code);
2360 }
2361
2362 LOG(DEBUG) << "Reconcile secondary dex path " << dex_path << " result=" << return_code;
2363
2364 switch (return_code) {
2365 case kReconcileSecondaryDexCleanedUp:
2366 case kReconcileSecondaryDexValidationError:
2367 // If we couldn't validate assume the dex file does not exist.
2368 // This will purge the entry from the PM records.
2369 *out_secondary_dex_exists = false;
2370 return true;
2371 case kReconcileSecondaryDexExists:
2372 *out_secondary_dex_exists = true;
2373 return true;
2374 case kReconcileSecondaryDexAccessIOError:
2375 // We had an access IO error.
2376 // Return false so that we can try again.
2377 // The value of out_secondary_dex_exists does not matter in this case and by convention
2378 // is set to false.
2379 *out_secondary_dex_exists = false;
2380 return false;
2381 default:
2382 LOG(ERROR) << "Unexpected code from reconcile_secondary_dex_file: " << return_code;
2383 *out_secondary_dex_exists = false;
2384 return false;
2385 }
Calin Juravlec9eab382017-01-25 01:17:17 -08002386}
2387
Alan Stokesa25d90c2017-10-16 10:56:00 +01002388// Compute and return the hash (SHA-256) of the secondary dex file at dex_path.
2389// Returns true if all parameters are valid and the hash successfully computed and stored in
2390// out_secondary_dex_hash.
2391// Also returns true with an empty hash if the file does not currently exist or is not accessible to
2392// the app.
2393// For any other errors (e.g. if any of the parameters are invalid) returns false.
2394bool hash_secondary_dex_file(const std::string& dex_path, const std::string& pkgname, int uid,
2395 const std::unique_ptr<std::string>& volume_uuid, int storage_flag,
2396 std::vector<uint8_t>* out_secondary_dex_hash) {
2397 out_secondary_dex_hash->clear();
2398
2399 const char* volume_uuid_cstr = volume_uuid == nullptr ? nullptr : volume_uuid->c_str();
2400
2401 if (storage_flag != FLAG_STORAGE_CE && storage_flag != FLAG_STORAGE_DE) {
2402 LOG(ERROR) << "hash_secondary_dex_file called with invalid storage_flag: "
2403 << storage_flag;
2404 return false;
2405 }
2406
2407 // Pipe to get the hash result back from our child process.
2408 unique_fd pipe_read, pipe_write;
2409 if (!Pipe(&pipe_read, &pipe_write)) {
2410 PLOG(ERROR) << "Failed to create pipe";
2411 return false;
2412 }
2413
2414 // Fork so that actual access to the files is done in the app's own UID, to ensure we only
2415 // access data the app itself can access.
2416 pid_t pid = fork();
2417 if (pid == 0) {
2418 // child -- drop privileges before continuing
2419 drop_capabilities(uid);
2420 pipe_read.reset();
2421
2422 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid_cstr, uid, storage_flag)) {
2423 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002424 _exit(DexoptReturnCodes::kHashValidatePath);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002425 }
2426
2427 unique_fd fd(TEMP_FAILURE_RETRY(open(dex_path.c_str(), O_RDONLY | O_CLOEXEC | O_NOFOLLOW)));
2428 if (fd == -1) {
2429 if (errno == EACCES || errno == ENOENT) {
2430 // Not treated as an error.
2431 _exit(0);
2432 }
2433 PLOG(ERROR) << "Failed to open secondary dex " << dex_path;
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002434 _exit(DexoptReturnCodes::kHashOpenPath);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002435 }
2436
2437 SHA256_CTX ctx;
2438 SHA256_Init(&ctx);
2439
2440 std::vector<uint8_t> buffer(65536);
2441 while (true) {
2442 ssize_t bytes_read = TEMP_FAILURE_RETRY(read(fd, buffer.data(), buffer.size()));
2443 if (bytes_read == 0) {
2444 break;
2445 } else if (bytes_read == -1) {
2446 PLOG(ERROR) << "Failed to read secondary dex " << dex_path;
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002447 _exit(DexoptReturnCodes::kHashReadDex);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002448 }
2449
2450 SHA256_Update(&ctx, buffer.data(), bytes_read);
2451 }
2452
2453 std::array<uint8_t, SHA256_DIGEST_LENGTH> hash;
2454 SHA256_Final(hash.data(), &ctx);
2455 if (!WriteFully(pipe_write, hash.data(), hash.size())) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002456 _exit(DexoptReturnCodes::kHashWrite);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002457 }
2458
2459 _exit(0);
2460 }
2461
2462 // parent
2463 pipe_write.reset();
2464
2465 out_secondary_dex_hash->resize(SHA256_DIGEST_LENGTH);
2466 if (!ReadFully(pipe_read, out_secondary_dex_hash->data(), out_secondary_dex_hash->size())) {
2467 out_secondary_dex_hash->clear();
2468 }
2469 return wait_child(pid) == 0;
2470}
2471
Jeff Sharkey90aff262016-12-12 14:28:24 -07002472// Helper for move_ab, so that we can have common failure-case cleanup.
2473static bool unlink_and_rename(const char* from, const char* to) {
2474 // Check whether "from" exists, and if so whether it's regular. If it is, unlink. Otherwise,
2475 // return a failure.
2476 struct stat s;
2477 if (stat(to, &s) == 0) {
2478 if (!S_ISREG(s.st_mode)) {
2479 LOG(ERROR) << from << " is not a regular file to replace for A/B.";
2480 return false;
2481 }
2482 if (unlink(to) != 0) {
2483 LOG(ERROR) << "Could not unlink " << to << " to move A/B.";
2484 return false;
2485 }
2486 } else {
2487 // This may be a permission problem. We could investigate the error code, but we'll just
2488 // let the rename failure do the work for us.
2489 }
2490
2491 // Try to rename "to" to "from."
2492 if (rename(from, to) != 0) {
2493 PLOG(ERROR) << "Could not rename " << from << " to " << to;
2494 return false;
2495 }
2496 return true;
2497}
2498
2499// Move/rename a B artifact (from) to an A artifact (to).
2500static bool move_ab_path(const std::string& b_path, const std::string& a_path) {
2501 // Check whether B exists.
2502 {
2503 struct stat s;
2504 if (stat(b_path.c_str(), &s) != 0) {
2505 // Silently ignore for now. The service calling this isn't smart enough to understand
2506 // lack of artifacts at the moment.
2507 return false;
2508 }
2509 if (!S_ISREG(s.st_mode)) {
2510 LOG(ERROR) << "A/B artifact " << b_path << " is not a regular file.";
2511 // Try to unlink, but swallow errors.
2512 unlink(b_path.c_str());
2513 return false;
2514 }
2515 }
2516
2517 // Rename B to A.
2518 if (!unlink_and_rename(b_path.c_str(), a_path.c_str())) {
2519 // Delete the b_path so we don't try again (or fail earlier).
2520 if (unlink(b_path.c_str()) != 0) {
2521 PLOG(ERROR) << "Could not unlink " << b_path;
2522 }
2523
2524 return false;
2525 }
2526
2527 return true;
2528}
2529
2530bool move_ab(const char* apk_path, const char* instruction_set, const char* oat_dir) {
2531 // Get the current slot suffix. No suffix, no A/B.
Mathieu Chartier9b2da082018-10-26 13:23:11 -07002532 const std::string slot_suffix = GetProperty("ro.boot.slot_suffix", "");
2533 if (slot_suffix.empty()) {
2534 return false;
2535 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07002536
Mathieu Chartier9b2da082018-10-26 13:23:11 -07002537 if (!ValidateTargetSlotSuffix(slot_suffix)) {
2538 LOG(ERROR) << "Target slot suffix not legal: " << slot_suffix;
2539 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07002540 }
2541
2542 // Validate other inputs.
2543 if (validate_apk_path(apk_path) != 0) {
2544 LOG(ERROR) << "Invalid apk_path: " << apk_path;
2545 return false;
2546 }
2547 if (validate_apk_path(oat_dir) != 0) {
2548 LOG(ERROR) << "Invalid oat_dir: " << oat_dir;
2549 return false;
2550 }
2551
2552 char a_path[PKG_PATH_MAX];
2553 if (!calculate_oat_file_path(a_path, oat_dir, apk_path, instruction_set)) {
2554 return false;
2555 }
2556 const std::string a_vdex_path = create_vdex_filename(a_path);
2557 const std::string a_image_path = create_image_filename(a_path);
2558
2559 // B path = A path + slot suffix.
2560 const std::string b_path = StringPrintf("%s.%s", a_path, slot_suffix.c_str());
2561 const std::string b_vdex_path = StringPrintf("%s.%s", a_vdex_path.c_str(), slot_suffix.c_str());
2562 const std::string b_image_path = StringPrintf("%s.%s",
2563 a_image_path.c_str(),
2564 slot_suffix.c_str());
2565
2566 bool success = true;
2567 if (move_ab_path(b_path, a_path)) {
2568 if (move_ab_path(b_vdex_path, a_vdex_path)) {
2569 // Note: we can live without an app image. As such, ignore failure to move the image file.
2570 // If we decide to require the app image, or the app image being moved correctly,
2571 // then change accordingly.
2572 constexpr bool kIgnoreAppImageFailure = true;
2573
2574 if (!a_image_path.empty()) {
2575 if (!move_ab_path(b_image_path, a_image_path)) {
2576 unlink(a_image_path.c_str());
2577 if (!kIgnoreAppImageFailure) {
2578 success = false;
2579 }
2580 }
2581 }
2582 } else {
2583 // Cleanup: delete B image, ignore errors.
2584 unlink(b_image_path.c_str());
2585 success = false;
2586 }
2587 } else {
2588 // Cleanup: delete B image, ignore errors.
2589 unlink(b_vdex_path.c_str());
2590 unlink(b_image_path.c_str());
2591 success = false;
2592 }
2593 return success;
2594}
2595
2596bool delete_odex(const char* apk_path, const char* instruction_set, const char* oat_dir) {
2597 // Delete the oat/odex file.
2598 char out_path[PKG_PATH_MAX];
Calin Juravle80a21252017-01-17 14:43:25 -08002599 if (!create_oat_out_path(apk_path, instruction_set, oat_dir,
Calin Juravle114f0812017-03-08 19:05:07 -08002600 /*is_secondary_dex*/false, out_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07002601 return false;
2602 }
2603
2604 // In case of a permission failure report the issue. Otherwise just print a warning.
2605 auto unlink_and_check = [](const char* path) -> bool {
2606 int result = unlink(path);
2607 if (result != 0) {
2608 if (errno == EACCES || errno == EPERM) {
2609 PLOG(ERROR) << "Could not unlink " << path;
2610 return false;
2611 }
2612 PLOG(WARNING) << "Could not unlink " << path;
2613 }
2614 return true;
2615 };
2616
2617 // Delete the oat/odex file.
2618 bool return_value_oat = unlink_and_check(out_path);
2619
2620 // Derive and delete the app image.
2621 bool return_value_art = unlink_and_check(create_image_filename(out_path).c_str());
2622
Nicolas Geoffray192fb962017-05-25 13:58:06 +01002623 // Derive and delete the vdex file.
2624 bool return_value_vdex = unlink_and_check(create_vdex_filename(out_path).c_str());
2625
Jeff Sharkey90aff262016-12-12 14:28:24 -07002626 // Report success.
Nicolas Geoffray192fb962017-05-25 13:58:06 +01002627 return return_value_oat && return_value_art && return_value_vdex;
Jeff Sharkey90aff262016-12-12 14:28:24 -07002628}
2629
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06002630static bool is_absolute_path(const std::string& path) {
2631 if (path.find('/') != 0 || path.find("..") != std::string::npos) {
2632 LOG(ERROR) << "Invalid absolute path " << path;
2633 return false;
2634 } else {
2635 return true;
2636 }
2637}
2638
2639static bool is_valid_instruction_set(const std::string& instruction_set) {
2640 // TODO: add explicit whitelisting of instruction sets
2641 if (instruction_set.find('/') != std::string::npos) {
2642 LOG(ERROR) << "Invalid instruction set " << instruction_set;
2643 return false;
2644 } else {
2645 return true;
2646 }
2647}
2648
2649bool calculate_oat_file_path_default(char path[PKG_PATH_MAX], const char *oat_dir,
2650 const char *apk_path, const char *instruction_set) {
2651 std::string oat_dir_ = oat_dir;
2652 std::string apk_path_ = apk_path;
2653 std::string instruction_set_ = instruction_set;
2654
2655 if (!is_absolute_path(oat_dir_)) return false;
2656 if (!is_absolute_path(apk_path_)) return false;
2657 if (!is_valid_instruction_set(instruction_set_)) return false;
2658
2659 std::string::size_type end = apk_path_.rfind('.');
2660 std::string::size_type start = apk_path_.rfind('/', end);
2661 if (end == std::string::npos || start == std::string::npos) {
2662 LOG(ERROR) << "Invalid apk_path " << apk_path_;
2663 return false;
2664 }
2665
2666 std::string res_ = oat_dir_ + '/' + instruction_set + '/'
2667 + apk_path_.substr(start + 1, end - start - 1) + ".odex";
2668 const char* res = res_.c_str();
2669 if (strlen(res) >= PKG_PATH_MAX) {
2670 LOG(ERROR) << "Result too large";
2671 return false;
2672 } else {
2673 strlcpy(path, res, PKG_PATH_MAX);
2674 return true;
2675 }
2676}
2677
2678bool calculate_odex_file_path_default(char path[PKG_PATH_MAX], const char *apk_path,
2679 const char *instruction_set) {
2680 std::string apk_path_ = apk_path;
2681 std::string instruction_set_ = instruction_set;
2682
2683 if (!is_absolute_path(apk_path_)) return false;
2684 if (!is_valid_instruction_set(instruction_set_)) return false;
2685
2686 std::string::size_type end = apk_path_.rfind('.');
2687 std::string::size_type start = apk_path_.rfind('/', end);
2688 if (end == std::string::npos || start == std::string::npos) {
2689 LOG(ERROR) << "Invalid apk_path " << apk_path_;
2690 return false;
2691 }
2692
2693 std::string oat_dir = apk_path_.substr(0, start + 1) + "oat";
2694 return calculate_oat_file_path_default(path, oat_dir.c_str(), apk_path, instruction_set);
2695}
2696
2697bool create_cache_path_default(char path[PKG_PATH_MAX], const char *src,
2698 const char *instruction_set) {
2699 std::string src_ = src;
2700 std::string instruction_set_ = instruction_set;
2701
2702 if (!is_absolute_path(src_)) return false;
2703 if (!is_valid_instruction_set(instruction_set_)) return false;
2704
2705 for (auto it = src_.begin() + 1; it < src_.end(); ++it) {
2706 if (*it == '/') {
2707 *it = '@';
2708 }
2709 }
2710
2711 std::string res_ = android_data_dir + DALVIK_CACHE + '/' + instruction_set_ + src_
2712 + DALVIK_CACHE_POSTFIX;
2713 const char* res = res_.c_str();
2714 if (strlen(res) >= PKG_PATH_MAX) {
2715 LOG(ERROR) << "Result too large";
2716 return false;
2717 } else {
2718 strlcpy(path, res, PKG_PATH_MAX);
2719 return true;
2720 }
2721}
2722
Calin Juravle59f7ab82018-04-27 17:50:23 -07002723bool open_classpath_files(const std::string& classpath, std::vector<unique_fd>* apk_fds,
2724 std::vector<std::string>* dex_locations) {
Calin Juravle0d0a4922018-01-23 19:54:11 -08002725 std::vector<std::string> classpaths_elems = base::Split(classpath, ":");
2726 for (const std::string& elem : classpaths_elems) {
2727 unique_fd fd(TEMP_FAILURE_RETRY(open(elem.c_str(), O_RDONLY)));
2728 if (fd < 0) {
2729 PLOG(ERROR) << "Could not open classpath elem " << elem;
2730 return false;
2731 } else {
2732 apk_fds->push_back(std::move(fd));
Calin Juravle59f7ab82018-04-27 17:50:23 -07002733 dex_locations->push_back(elem);
Calin Juravle0d0a4922018-01-23 19:54:11 -08002734 }
2735 }
2736 return true;
2737}
2738
2739static bool create_app_profile_snapshot(int32_t app_id,
2740 const std::string& package_name,
2741 const std::string& profile_name,
2742 const std::string& classpath) {
Calin Juravle29591732017-11-20 17:46:19 -08002743 int app_shared_gid = multiuser_get_shared_gid(/*user_id*/ 0, app_id);
2744
Calin Juravle824a64d2018-01-18 20:23:17 -08002745 unique_fd snapshot_fd = open_spnashot_profile(AID_SYSTEM, package_name, profile_name);
Calin Juravle29591732017-11-20 17:46:19 -08002746 if (snapshot_fd < 0) {
2747 return false;
2748 }
2749
2750 std::vector<unique_fd> profiles_fd;
2751 unique_fd reference_profile_fd;
Calin Juravle824a64d2018-01-18 20:23:17 -08002752 open_profile_files(app_shared_gid, package_name, profile_name, /*is_secondary_dex*/ false,
2753 &profiles_fd, &reference_profile_fd);
Calin Juravle29591732017-11-20 17:46:19 -08002754 if (profiles_fd.empty() || (reference_profile_fd.get() < 0)) {
2755 return false;
2756 }
2757
2758 profiles_fd.push_back(std::move(reference_profile_fd));
2759
Calin Juravle0d0a4922018-01-23 19:54:11 -08002760 // Open the class paths elements. These will be used to filter out profile data that does
2761 // not belong to the classpath during merge.
2762 std::vector<unique_fd> apk_fds;
Calin Juravle59f7ab82018-04-27 17:50:23 -07002763 std::vector<std::string> dex_locations;
2764 if (!open_classpath_files(classpath, &apk_fds, &dex_locations)) {
Calin Juravle0d0a4922018-01-23 19:54:11 -08002765 return false;
2766 }
2767
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002768 RunProfman args;
Calin Juravle78728f32019-11-08 17:55:46 -08002769 args.SetupMerge(profiles_fd, snapshot_fd, apk_fds, dex_locations, /*for_snapshot=*/true);
Calin Juravle29591732017-11-20 17:46:19 -08002770 pid_t pid = fork();
2771 if (pid == 0) {
2772 /* child -- drop privileges before continuing */
2773 drop_capabilities(app_shared_gid);
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002774 args.Exec();
Calin Juravle29591732017-11-20 17:46:19 -08002775 }
2776
2777 /* parent */
2778 int return_code = wait_child(pid);
2779 if (!WIFEXITED(return_code)) {
Calin Juravle824a64d2018-01-18 20:23:17 -08002780 LOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
Calin Juravle29591732017-11-20 17:46:19 -08002781 return false;
2782 }
2783
Calin Juravle78728f32019-11-08 17:55:46 -08002784 // Verify that profman finished successfully.
2785 int profman_code = WEXITSTATUS(return_code);
2786 if (profman_code != PROFMAN_BIN_RETURN_CODE_SUCCESS) {
2787 LOG(WARNING) << "profman error for " << package_name << ":" << profile_name
2788 << ":" << profman_code;
2789 return false;
2790 }
Calin Juravle29591732017-11-20 17:46:19 -08002791 return true;
2792}
2793
Calin Juravle0d0a4922018-01-23 19:54:11 -08002794static bool create_boot_image_profile_snapshot(const std::string& package_name,
2795 const std::string& profile_name,
2796 const std::string& classpath) {
2797 // The reference profile directory for the android package might not be prepared. Do it now.
2798 const std::string ref_profile_dir =
2799 create_primary_reference_profile_package_dir_path(package_name);
2800 if (fs_prepare_dir(ref_profile_dir.c_str(), 0770, AID_SYSTEM, AID_SYSTEM) != 0) {
2801 PLOG(ERROR) << "Failed to prepare " << ref_profile_dir;
2802 return false;
2803 }
2804
Mathieu Chartiere0d64a12018-11-01 12:07:26 -07002805 // Return false for empty class path since it may otherwise return true below if profiles is
2806 // empty.
2807 if (classpath.empty()) {
2808 PLOG(ERROR) << "Class path is empty";
2809 return false;
2810 }
2811
Calin Juravle0d0a4922018-01-23 19:54:11 -08002812 // Open and create the snapshot profile.
2813 unique_fd snapshot_fd = open_spnashot_profile(AID_SYSTEM, package_name, profile_name);
2814
2815 // Collect all non empty profiles.
2816 // The collection will traverse all applications profiles and find the non empty files.
2817 // This has the potential of inspecting a large number of files and directories (depending
2818 // on the number of applications and users). So there is a slight increase in the chance
2819 // to get get occasionally I/O errors (e.g. for opening the file). When that happens do not
2820 // fail the snapshot and aggregate whatever profile we could open.
2821 //
2822 // The profile snapshot is a best effort based on available data it's ok if some data
2823 // from some apps is missing. It will be counter productive for the snapshot to fail
2824 // because we could not open or read some of the files.
2825 std::vector<std::string> profiles;
2826 if (!collect_profiles(&profiles)) {
2827 LOG(WARNING) << "There were errors while collecting the profiles for the boot image.";
2828 }
2829
2830 // If we have no profiles return early.
2831 if (profiles.empty()) {
2832 return true;
2833 }
2834
2835 // Open the classpath elements. These will be used to filter out profile data that does
2836 // not belong to the classpath during merge.
2837 std::vector<unique_fd> apk_fds;
Calin Juravle59f7ab82018-04-27 17:50:23 -07002838 std::vector<std::string> dex_locations;
2839 if (!open_classpath_files(classpath, &apk_fds, &dex_locations)) {
Calin Juravle0d0a4922018-01-23 19:54:11 -08002840 return false;
2841 }
2842
2843 // If we could not open any files from the classpath return an error.
2844 if (apk_fds.empty()) {
2845 LOG(ERROR) << "Could not open any of the classpath elements.";
2846 return false;
2847 }
2848
2849 // Aggregate the profiles in batches of kAggregationBatchSize.
2850 // We do this to avoid opening a huge a amount of files.
2851 static constexpr size_t kAggregationBatchSize = 10;
2852
Calin Juravle0d0a4922018-01-23 19:54:11 -08002853 for (size_t i = 0; i < profiles.size(); ) {
Calin Juravlea64fb512019-11-06 16:11:14 -08002854 std::vector<unique_fd> profiles_fd;
Calin Juravle0d0a4922018-01-23 19:54:11 -08002855 for (size_t k = 0; k < kAggregationBatchSize && i < profiles.size(); k++, i++) {
2856 unique_fd fd = open_profile(AID_SYSTEM, profiles[i], O_RDONLY);
2857 if (fd.get() >= 0) {
2858 profiles_fd.push_back(std::move(fd));
2859 }
2860 }
Calin Juravlea64fb512019-11-06 16:11:14 -08002861
2862 // We aggregate (read & write) into the same fd multiple times in a row.
2863 // We need to reset the cursor every time to ensure we read the whole file every time.
2864 if (TEMP_FAILURE_RETRY(lseek(snapshot_fd, 0, SEEK_SET)) == static_cast<off_t>(-1)) {
2865 PLOG(ERROR) << "Cannot reset position for snapshot profile";
2866 return false;
2867 }
2868
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002869 RunProfman args;
Calin Juravleb3a929d2018-12-11 14:40:00 -08002870 args.SetupMerge(profiles_fd,
2871 snapshot_fd,
2872 apk_fds,
Calin Juravle78728f32019-11-08 17:55:46 -08002873 dex_locations,
2874 /*for_snapshot=*/true,
2875 /*for_boot_image=*/true);
Calin Juravle0d0a4922018-01-23 19:54:11 -08002876 pid_t pid = fork();
2877 if (pid == 0) {
2878 /* child -- drop privileges before continuing */
2879 drop_capabilities(AID_SYSTEM);
2880
Calin Juravle59f7ab82018-04-27 17:50:23 -07002881 // The introduction of new access flags into boot jars causes them to
2882 // fail dex file verification.
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002883 args.Exec();
Calin Juravle0d0a4922018-01-23 19:54:11 -08002884 }
2885
2886 /* parent */
2887 int return_code = wait_child(pid);
Calin Juravlea64fb512019-11-06 16:11:14 -08002888
Calin Juravle0d0a4922018-01-23 19:54:11 -08002889 if (!WIFEXITED(return_code)) {
2890 PLOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
2891 return false;
2892 }
Calin Juravlea64fb512019-11-06 16:11:14 -08002893
2894 // Verify that profman finished successfully.
2895 int profman_code = WEXITSTATUS(return_code);
Calin Juravle78728f32019-11-08 17:55:46 -08002896 if (profman_code != PROFMAN_BIN_RETURN_CODE_SUCCESS) {
2897 LOG(WARNING) << "profman error for " << package_name << ":" << profile_name
2898 << ":" << profman_code;
2899 return false;
Calin Juravlea64fb512019-11-06 16:11:14 -08002900 }
Calin Juravle0d0a4922018-01-23 19:54:11 -08002901 }
Calin Juravlea64fb512019-11-06 16:11:14 -08002902
Calin Juravle0d0a4922018-01-23 19:54:11 -08002903 return true;
2904}
2905
2906bool create_profile_snapshot(int32_t app_id, const std::string& package_name,
2907 const std::string& profile_name, const std::string& classpath) {
2908 if (app_id == -1) {
2909 return create_boot_image_profile_snapshot(package_name, profile_name, classpath);
2910 } else {
2911 return create_app_profile_snapshot(app_id, package_name, profile_name, classpath);
2912 }
2913}
2914
Calin Juravlec3b049e2018-01-18 22:32:58 -08002915bool prepare_app_profile(const std::string& package_name,
2916 userid_t user_id,
2917 appid_t app_id,
2918 const std::string& profile_name,
Calin Juravlef63d4792018-01-30 17:43:34 +00002919 const std::string& code_path,
Calin Juravlec3b049e2018-01-18 22:32:58 -08002920 const std::unique_ptr<std::string>& dex_metadata) {
2921 // Prepare the current profile.
2922 std::string cur_profile = create_current_profile_path(user_id, package_name, profile_name,
2923 /*is_secondary_dex*/ false);
2924 uid_t uid = multiuser_get_uid(user_id, app_id);
2925 if (fs_prepare_file_strict(cur_profile.c_str(), 0600, uid, uid) != 0) {
2926 PLOG(ERROR) << "Failed to prepare " << cur_profile;
2927 return false;
2928 }
2929
2930 // Check if we need to install the profile from the dex metadata.
2931 if (dex_metadata == nullptr) {
2932 return true;
2933 }
2934
2935 // We have a dex metdata. Merge the profile into the reference profile.
2936 unique_fd ref_profile_fd = open_reference_profile(uid, package_name, profile_name,
2937 /*read_write*/ true, /*is_secondary_dex*/ false);
2938 unique_fd dex_metadata_fd(TEMP_FAILURE_RETRY(
2939 open(dex_metadata->c_str(), O_RDONLY | O_NOFOLLOW)));
Calin Juravlef63d4792018-01-30 17:43:34 +00002940 unique_fd apk_fd(TEMP_FAILURE_RETRY(open(code_path.c_str(), O_RDONLY | O_NOFOLLOW)));
2941 if (apk_fd < 0) {
2942 PLOG(ERROR) << "Could not open code path " << code_path;
2943 return false;
2944 }
Calin Juravlec3b049e2018-01-18 22:32:58 -08002945
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002946 RunProfman args;
2947 args.SetupCopyAndUpdate(std::move(dex_metadata_fd),
2948 std::move(ref_profile_fd),
2949 std::move(apk_fd),
2950 code_path);
Calin Juravlec3b049e2018-01-18 22:32:58 -08002951 pid_t pid = fork();
2952 if (pid == 0) {
2953 /* child -- drop privileges before continuing */
2954 gid_t app_shared_gid = multiuser_get_shared_gid(user_id, app_id);
2955 drop_capabilities(app_shared_gid);
2956
Calin Juravlef63d4792018-01-30 17:43:34 +00002957 // The copy and update takes ownership over the fds.
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002958 args.Exec();
Calin Juravlec3b049e2018-01-18 22:32:58 -08002959 }
2960
2961 /* parent */
2962 int return_code = wait_child(pid);
2963 if (!WIFEXITED(return_code)) {
2964 PLOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
2965 return false;
2966 }
2967 return true;
2968}
2969
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07002970} // namespace installd
2971} // namespace android