blob: 9d90a5b5d18b2609179549457a953b539a593cf8 [file] [log] [blame]
Jingwen Chen91220d72021-03-24 02:18:33 -04001// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
Cole Faust7071a052022-07-29 15:58:33 -07007// http://www.apache.org/licenses/LICENSE-2.0
Jingwen Chen91220d72021-03-24 02:18:33 -04008//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14package cc
15
16import (
Liz Kammerd2871182021-10-04 13:54:37 -040017 "fmt"
Jingwen Chened9c17d2021-04-13 07:14:55 +000018 "path/filepath"
Jingwen Chen3950cd62021-05-12 04:33:00 +000019 "strings"
Spandan Das4242f102023-04-19 22:31:54 +000020 "sync"
Chris Parsons484e50a2021-05-13 15:13:04 -040021
22 "android/soong/android"
23 "android/soong/bazel"
Alix1be00d42022-05-16 22:56:04 +000024 "android/soong/cc/config"
Liz Kammer0db0e342023-07-18 11:39:30 -040025 "android/soong/genrule"
Liz Kammer7a210ac2021-09-22 15:52:58 -040026
Chris Parsons953b3562021-09-20 15:14:39 -040027 "github.com/google/blueprint"
Liz Kammerba7a9c52021-05-26 08:45:30 -040028
29 "github.com/google/blueprint/proptools"
Jingwen Chen91220d72021-03-24 02:18:33 -040030)
31
Liz Kammerae3994e2021-10-19 09:45:48 -040032const (
Trevor Radcliffecee4e052022-09-06 19:31:25 +000033 cSrcPartition = "c"
34 asSrcPartition = "as"
35 asmSrcPartition = "asm"
36 lSrcPartition = "l"
37 llSrcPartition = "ll"
38 cppSrcPartition = "cpp"
39 protoSrcPartition = "proto"
40 aidlSrcPartition = "aidl"
41 syspropSrcPartition = "sysprop"
Alixe2667872023-04-24 14:57:32 +000042
43 yaccSrcPartition = "yacc"
44
45 rScriptSrcPartition = "renderScript"
Liz Kammer91487d42022-09-13 11:27:11 -040046
Liz Kammer5f5dbaa2023-07-17 17:44:08 -040047 xsdSrcPartition = "xsd"
48
Liz Kammer0db0e342023-07-18 11:39:30 -040049 genrulePartition = "genrule"
50
Spandan Dasa99348d2023-08-01 23:10:05 +000051 protoFromGenPartition = "proto_gen"
52
Liz Kammer5f5dbaa2023-07-17 17:44:08 -040053 hdrPartition = "hdr"
54
Liz Kammer91487d42022-09-13 11:27:11 -040055 stubsSuffix = "_stub_libs_current"
Liz Kammerae3994e2021-10-19 09:45:48 -040056)
57
Liz Kammer2222c6b2021-05-24 15:41:47 -040058// staticOrSharedAttributes are the Bazel-ified versions of StaticOrSharedProperties --
Jingwen Chenbcf53042021-05-26 04:42:42 +000059// properties which apply to either the shared or static version of a cc_library module.
Liz Kammer2222c6b2021-05-24 15:41:47 -040060type staticOrSharedAttributes struct {
Vinh Tran9f6796a2022-08-16 13:10:31 -040061 Srcs bazel.LabelListAttribute
62 Srcs_c bazel.LabelListAttribute
63 Srcs_as bazel.LabelListAttribute
64 Srcs_aidl bazel.LabelListAttribute
65 Hdrs bazel.LabelListAttribute
66 Copts bazel.StringListAttribute
Jingwen Chen14a8bda2021-06-02 11:10:02 +000067
Liz Kammer12615db2021-09-28 09:19:17 -040068 Deps bazel.LabelListAttribute
69 Implementation_deps bazel.LabelListAttribute
70 Dynamic_deps bazel.LabelListAttribute
71 Implementation_dynamic_deps bazel.LabelListAttribute
72 Whole_archive_deps bazel.LabelListAttribute
73 Implementation_whole_archive_deps bazel.LabelListAttribute
Cole Faust6b29f592022-08-09 09:50:56 -070074 Runtime_deps bazel.LabelListAttribute
Chris Parsons51f8c392021-08-03 21:01:05 -040075
76 System_dynamic_deps bazel.LabelListAttribute
Chris Parsons58852a02021-12-09 18:10:18 -050077
78 Enabled bazel.BoolAttribute
Yu Liufc603162022-03-01 15:44:08 -080079
Yu Liuf01a0f02022-12-07 15:45:30 -080080 Native_coverage *bool
Yu Liu8d82ac52022-05-17 15:13:28 -070081
Liz Kammeraceec252023-03-24 09:46:36 -040082 Apex_available []string
83
Trevor Radcliffea8b44162023-04-14 18:25:24 +000084 Features bazel.StringListAttribute
85
Yu Liufc603162022-03-01 15:44:08 -080086 sdkAttributes
Sam Delmericofb3bb322022-10-21 10:42:24 -040087
88 tidyAttributes
89}
90
91type tidyAttributes struct {
Sam Delmerico63f0c932023-03-14 14:05:28 -040092 Tidy *string
Sam Delmericofb3bb322022-10-21 10:42:24 -040093 Tidy_flags []string
94 Tidy_checks []string
95 Tidy_checks_as_errors []string
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -040096 Tidy_disabled_srcs bazel.LabelListAttribute
Sam Delmerico4c902d62022-11-02 14:17:15 -040097 Tidy_timeout_srcs bazel.LabelListAttribute
Sam Delmericofb3bb322022-10-21 10:42:24 -040098}
99
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400100func (m *Module) convertTidyAttributes(ctx android.BaseMutatorContext, moduleAttrs *tidyAttributes) {
Sam Delmericofb3bb322022-10-21 10:42:24 -0400101 for _, f := range m.features {
102 if tidy, ok := f.(*tidyFeature); ok {
Sam Delmerico63f0c932023-03-14 14:05:28 -0400103 var tidyAttr *string
104 if tidy.Properties.Tidy != nil {
105 if *tidy.Properties.Tidy {
106 tidyAttr = proptools.StringPtr("local")
107 } else {
108 tidyAttr = proptools.StringPtr("never")
109 }
110 }
111 moduleAttrs.Tidy = tidyAttr
Sam Delmericofb3bb322022-10-21 10:42:24 -0400112 moduleAttrs.Tidy_flags = tidy.Properties.Tidy_flags
113 moduleAttrs.Tidy_checks = tidy.Properties.Tidy_checks
114 moduleAttrs.Tidy_checks_as_errors = tidy.Properties.Tidy_checks_as_errors
115 }
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400116
117 }
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400118 archVariantProps := m.GetArchVariantProperties(ctx, &BaseCompilerProperties{})
119 for axis, configToProps := range archVariantProps {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800120 for cfg, _props := range configToProps {
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400121 if archProps, ok := _props.(*BaseCompilerProperties); ok {
122 archDisabledSrcs := android.BazelLabelForModuleSrc(ctx, archProps.Tidy_disabled_srcs)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800123 moduleAttrs.Tidy_disabled_srcs.SetSelectValue(axis, cfg, archDisabledSrcs)
Sam Delmerico4c902d62022-11-02 14:17:15 -0400124 archTimeoutSrcs := android.BazelLabelForModuleSrc(ctx, archProps.Tidy_timeout_srcs)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800125 moduleAttrs.Tidy_timeout_srcs.SetSelectValue(axis, cfg, archTimeoutSrcs)
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400126 }
127 }
Sam Delmericofb3bb322022-10-21 10:42:24 -0400128 }
Jingwen Chen53681ef2021-04-29 08:15:13 +0000129}
130
Spandan Dasa99348d2023-08-01 23:10:05 +0000131// Returns an unchanged label and a bool indicating whether the dep is a genrule that produces .proto files
132func protoFromGenPartitionMapper(pathCtx android.BazelConversionContext) bazel.LabelMapper {
133 return func(ctx bazel.OtherModuleContext, label bazel.Label) (string, bool) {
134 mod, exists := ctx.ModuleFromName(label.OriginalModuleName)
135 if !exists {
136 return label.Label, false
137 }
138 gen, isGen := mod.(*genrule.Module)
139 if !isGen {
140 return label.Label, false
141 }
142 if containsProto(ctx, gen.RawOutputFiles(pathCtx)) {
143 // Return unmodified label + true
144 // True will ensure that this module gets dropped from `srcs` of the generated cc_* target. `srcs` is reserved for .cpp files
145 return label.Label, true
146 }
147 return label.Label, false
148 }
149}
150
151// Returns true if srcs contains only .proto files
152// Raises an exception if there is a combination of .proto and non .proto srcs
153func containsProto(ctx bazel.OtherModuleContext, srcs []string) bool {
154 onlyProtos := false
155 for _, src := range srcs {
156 if strings.HasSuffix(src, ".proto") {
157 onlyProtos = true
158 } else if onlyProtos {
159 // This is not a proto file, and we have encountered a .proto file previously
160 ctx.ModuleErrorf("TOOD: Add bp2build support combination of .proto and non .proto files in outs of genrule")
161 }
162 }
163 return onlyProtos
164}
165
Sam Delmericoc7681022022-02-04 21:01:20 +0000166// groupSrcsByExtension partitions `srcs` into groups based on file extension.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000167func groupSrcsByExtension(ctx android.BazelConversionPathContext, srcs bazel.LabelListAttribute) bazel.PartitionToLabelListAttribute {
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400168 // Convert filegroup dependencies into extension-specific filegroups filtered in the filegroup.bzl
169 // macro.
170 addSuffixForFilegroup := func(suffix string) bazel.LabelMapper {
Vinh Tran9f6796a2022-08-16 13:10:31 -0400171 return func(otherModuleCtx bazel.OtherModuleContext, label bazel.Label) (string, bool) {
172
173 m, exists := otherModuleCtx.ModuleFromName(label.OriginalModuleName)
Liz Kammer12615db2021-09-28 09:19:17 -0400174 labelStr := label.Label
Vinh Tran9f6796a2022-08-16 13:10:31 -0400175 if !exists || !android.IsFilegroup(otherModuleCtx, m) {
176 return labelStr, false
177 }
Yu Liu2aa806b2022-09-01 11:54:47 -0700178 // If the filegroup is already converted to aidl_library or proto_library,
179 // skip creating _c_srcs, _as_srcs, _cpp_srcs filegroups
180 fg, _ := m.(android.FileGroupAsLibrary)
181 if fg.ShouldConvertToAidlLibrary(ctx) || fg.ShouldConvertToProtoLibrary(ctx) {
Liz Kammer12615db2021-09-28 09:19:17 -0400182 return labelStr, false
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000183 }
Liz Kammer12615db2021-09-28 09:19:17 -0400184 return labelStr + suffix, true
Chris Parsons5a34ffb2021-07-21 14:34:58 -0400185 }
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000186 }
187
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400188 // TODO(b/190006308): Handle language detection of sources in a Bazel rule.
Sam Delmericoc7681022022-02-04 21:01:20 +0000189 labels := bazel.LabelPartitions{
190 protoSrcPartition: android.ProtoSrcLabelPartition,
Liz Kammeraabfb5d2021-12-08 15:25:06 -0500191 cSrcPartition: bazel.LabelPartition{Extensions: []string{".c"}, LabelMapper: addSuffixForFilegroup("_c_srcs")},
192 asSrcPartition: bazel.LabelPartition{Extensions: []string{".s", ".S"}, LabelMapper: addSuffixForFilegroup("_as_srcs")},
Cole Faust7071a052022-07-29 15:58:33 -0700193 asmSrcPartition: bazel.LabelPartition{Extensions: []string{".asm"}},
Vinh Tran9f6796a2022-08-16 13:10:31 -0400194 aidlSrcPartition: android.AidlSrcLabelPartition,
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000195 // TODO(http://b/231968910): If there is ever a filegroup target that
196 // contains .l or .ll files we will need to find a way to add a
197 // LabelMapper for these that identifies these filegroups and
198 // converts them appropriately
Spandan Dasa99348d2023-08-01 23:10:05 +0000199 lSrcPartition: bazel.LabelPartition{Extensions: []string{".l"}},
200 llSrcPartition: bazel.LabelPartition{Extensions: []string{".ll"}},
201 rScriptSrcPartition: bazel.LabelPartition{Extensions: []string{".fs", ".rscript"}},
202 xsdSrcPartition: bazel.LabelPartition{LabelMapper: android.XsdLabelMapper(xsdConfigCppTarget)},
203 protoFromGenPartition: bazel.LabelPartition{LabelMapper: protoFromGenPartitionMapper(ctx)},
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400204 // C++ is the "catch-all" group, and comprises generated sources because we don't
205 // know the language of these sources until the genrule is executed.
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000206 cppSrcPartition: bazel.LabelPartition{Extensions: []string{".cpp", ".cc", ".cxx", ".mm"}, LabelMapper: addSuffixForFilegroup("_cpp_srcs"), Keep_remainder: true},
207 syspropSrcPartition: bazel.LabelPartition{Extensions: []string{".sysprop"}},
Spandan Dasdf4c2132023-05-09 23:58:52 +0000208 yaccSrcPartition: bazel.LabelPartition{Extensions: []string{".y", "yy"}},
Sam Delmericoc7681022022-02-04 21:01:20 +0000209 }
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000210
Sam Delmericoc7681022022-02-04 21:01:20 +0000211 return bazel.PartitionLabelListAttribute(ctx, &srcs, labels)
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000212}
213
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400214func partitionHeaders(ctx android.BazelConversionPathContext, hdrs bazel.LabelListAttribute) bazel.PartitionToLabelListAttribute {
215 labels := bazel.LabelPartitions{
Liz Kammer0db0e342023-07-18 11:39:30 -0400216 xsdSrcPartition: bazel.LabelPartition{LabelMapper: android.XsdLabelMapper(xsdConfigCppTarget)},
217 genrulePartition: bazel.LabelPartition{LabelMapper: genrule.GenruleCcHeaderLabelMapper},
218 hdrPartition: bazel.LabelPartition{Keep_remainder: true},
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400219 }
220 return bazel.PartitionLabelListAttribute(ctx, &hdrs, labels)
221}
222
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000223// bp2BuildParseLibProps returns the attributes for a variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000224func bp2BuildParseLibProps(ctx android.BazelConversionPathContext, module *Module, isStatic bool) staticOrSharedAttributes {
Jingwen Chen53681ef2021-04-29 08:15:13 +0000225 lib, ok := module.compiler.(*libraryDecorator)
226 if !ok {
Liz Kammer2222c6b2021-05-24 15:41:47 -0400227 return staticOrSharedAttributes{}
Jingwen Chen53681ef2021-04-29 08:15:13 +0000228 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000229 return bp2buildParseStaticOrSharedProps(ctx, module, lib, isStatic)
230}
Jingwen Chen53681ef2021-04-29 08:15:13 +0000231
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000232// bp2buildParseSharedProps returns the attributes for the shared variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000233func bp2BuildParseSharedProps(ctx android.BazelConversionPathContext, module *Module) staticOrSharedAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000234 return bp2BuildParseLibProps(ctx, module, false)
Jingwen Chen53681ef2021-04-29 08:15:13 +0000235}
236
237// bp2buildParseStaticProps returns the attributes for the static variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000238func bp2BuildParseStaticProps(ctx android.BazelConversionPathContext, module *Module) staticOrSharedAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000239 return bp2BuildParseLibProps(ctx, module, true)
Liz Kammer2222c6b2021-05-24 15:41:47 -0400240}
241
Liz Kammer7a210ac2021-09-22 15:52:58 -0400242type depsPartition struct {
243 export bazel.LabelList
244 implementation bazel.LabelList
245}
246
Jingwen Chen55bc8202021-11-02 06:40:51 +0000247type bazelLabelForDepsFn func(android.BazelConversionPathContext, []string) bazel.LabelList
Liz Kammer7a210ac2021-09-22 15:52:58 -0400248
Jingwen Chen55bc8202021-11-02 06:40:51 +0000249func maybePartitionExportedAndImplementationsDeps(ctx android.BazelConversionPathContext, exportsDeps bool, allDeps, exportedDeps []string, fn bazelLabelForDepsFn) depsPartition {
Liz Kammer2b8004b2021-10-04 13:55:44 -0400250 if !exportsDeps {
251 return depsPartition{
252 implementation: fn(ctx, allDeps),
253 }
254 }
255
Liz Kammer7a210ac2021-09-22 15:52:58 -0400256 implementation, export := android.FilterList(allDeps, exportedDeps)
257
258 return depsPartition{
259 export: fn(ctx, export),
260 implementation: fn(ctx, implementation),
261 }
262}
263
Jingwen Chen55bc8202021-11-02 06:40:51 +0000264type bazelLabelForDepsExcludesFn func(android.BazelConversionPathContext, []string, []string) bazel.LabelList
Liz Kammer7a210ac2021-09-22 15:52:58 -0400265
Jingwen Chen55bc8202021-11-02 06:40:51 +0000266func maybePartitionExportedAndImplementationsDepsExcludes(ctx android.BazelConversionPathContext, exportsDeps bool, allDeps, excludes, exportedDeps []string, fn bazelLabelForDepsExcludesFn) depsPartition {
Liz Kammer2b8004b2021-10-04 13:55:44 -0400267 if !exportsDeps {
268 return depsPartition{
269 implementation: fn(ctx, allDeps, excludes),
270 }
271 }
Liz Kammer7a210ac2021-09-22 15:52:58 -0400272 implementation, export := android.FilterList(allDeps, exportedDeps)
273
274 return depsPartition{
275 export: fn(ctx, export, excludes),
276 implementation: fn(ctx, implementation, excludes),
277 }
278}
279
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000280func bp2BuildPropParseHelper(ctx android.ArchVariantContext, module *Module, propsType interface{}, parseFunc func(axis bazel.ConfigurationAxis, config string, props interface{})) {
281 for axis, configToProps := range module.GetArchVariantProperties(ctx, propsType) {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800282 for cfg, props := range configToProps {
283 parseFunc(axis, cfg, props)
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000284 }
285 }
286}
287
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000288// Parses properties common to static and shared libraries. Also used for prebuilt libraries.
Liz Kammeraceec252023-03-24 09:46:36 -0400289func bp2buildParseStaticOrSharedProps(ctx android.BazelConversionPathContext, module *Module, lib *libraryDecorator, isStatic bool) staticOrSharedAttributes {
Liz Kammer135bf552021-08-11 10:46:06 -0400290 attrs := staticOrSharedAttributes{}
Jingwen Chenbcf53042021-05-26 04:42:42 +0000291
Liz Kammer9abd62d2021-05-21 08:37:59 -0400292 setAttrs := func(axis bazel.ConfigurationAxis, config string, props StaticOrSharedProperties) {
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000293 attrs.Copts.SetSelectValue(axis, config, parseCommandLineFlags(props.Cflags, filterOutStdFlag, filterOutHiddenVisibility))
Jingwen Chenc4dc9b42021-06-11 12:51:48 +0000294 attrs.Srcs.SetSelectValue(axis, config, android.BazelLabelForModuleSrc(ctx, props.Srcs))
Chris Parsons953b3562021-09-20 15:14:39 -0400295 attrs.System_dynamic_deps.SetSelectValue(axis, config, bazelLabelForSharedDeps(ctx, props.System_shared_libs))
Liz Kammer7a210ac2021-09-22 15:52:58 -0400296
Liz Kammer2b8004b2021-10-04 13:55:44 -0400297 staticDeps := maybePartitionExportedAndImplementationsDeps(ctx, true, props.Static_libs, props.Export_static_lib_headers, bazelLabelForStaticDeps)
Liz Kammer7a210ac2021-09-22 15:52:58 -0400298 attrs.Deps.SetSelectValue(axis, config, staticDeps.export)
299 attrs.Implementation_deps.SetSelectValue(axis, config, staticDeps.implementation)
300
Liz Kammer2b8004b2021-10-04 13:55:44 -0400301 sharedDeps := maybePartitionExportedAndImplementationsDeps(ctx, true, props.Shared_libs, props.Export_shared_lib_headers, bazelLabelForSharedDeps)
Liz Kammer7a210ac2021-09-22 15:52:58 -0400302 attrs.Dynamic_deps.SetSelectValue(axis, config, sharedDeps.export)
303 attrs.Implementation_dynamic_deps.SetSelectValue(axis, config, sharedDeps.implementation)
304
305 attrs.Whole_archive_deps.SetSelectValue(axis, config, bazelLabelForWholeDeps(ctx, props.Whole_static_libs))
Chris Parsons58852a02021-12-09 18:10:18 -0500306 attrs.Enabled.SetSelectValue(axis, config, props.Enabled)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000307 }
Liz Kammer135bf552021-08-11 10:46:06 -0400308 // system_dynamic_deps distinguishes between nil/empty list behavior:
309 // nil -> use default values
310 // empty list -> no values specified
311 attrs.System_dynamic_deps.ForceSpecifyEmptyList = true
Jingwen Chenbcf53042021-05-26 04:42:42 +0000312
Liz Kammeraceec252023-03-24 09:46:36 -0400313 var apexAvailable []string
Jingwen Chenbcf53042021-05-26 04:42:42 +0000314 if isStatic {
Liz Kammeraceec252023-03-24 09:46:36 -0400315 apexAvailable = lib.StaticProperties.Static.Apex_available
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000316 bp2BuildPropParseHelper(ctx, module, &StaticProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
317 if staticOrSharedProps, ok := props.(*StaticProperties); ok {
318 setAttrs(axis, config, staticOrSharedProps.Static)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000319 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000320 })
Jingwen Chenbcf53042021-05-26 04:42:42 +0000321 } else {
Liz Kammeraceec252023-03-24 09:46:36 -0400322 apexAvailable = lib.SharedProperties.Shared.Apex_available
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000323 bp2BuildPropParseHelper(ctx, module, &SharedProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
324 if staticOrSharedProps, ok := props.(*SharedProperties); ok {
325 setAttrs(axis, config, staticOrSharedProps.Shared)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000326 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000327 })
Jingwen Chenbcf53042021-05-26 04:42:42 +0000328 }
329
Liz Kammerae3994e2021-10-19 09:45:48 -0400330 partitionedSrcs := groupSrcsByExtension(ctx, attrs.Srcs)
331 attrs.Srcs = partitionedSrcs[cppSrcPartition]
332 attrs.Srcs_c = partitionedSrcs[cSrcPartition]
333 attrs.Srcs_as = partitionedSrcs[asSrcPartition]
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000334
Spandan Das39b6cc52023-04-12 19:05:49 +0000335 attrs.Apex_available = android.ConvertApexAvailableToTagsWithoutTestApexes(ctx.(android.TopDownMutatorContext), apexAvailable)
Liz Kammeraceec252023-03-24 09:46:36 -0400336
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000337 attrs.Features.Append(convertHiddenVisibilityToFeatureStaticOrShared(ctx, module, isStatic))
338
Liz Kammer12615db2021-09-28 09:19:17 -0400339 if !partitionedSrcs[protoSrcPartition].IsEmpty() {
340 // TODO(b/208815215): determine whether this is used and add support if necessary
341 ctx.ModuleErrorf("Migrating static/shared only proto srcs is not currently supported")
342 }
343
Jingwen Chenbcf53042021-05-26 04:42:42 +0000344 return attrs
Jingwen Chen53681ef2021-04-29 08:15:13 +0000345}
346
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400347// Convenience struct to hold all attributes parsed from prebuilt properties.
348type prebuiltAttributes struct {
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000349 Src bazel.LabelAttribute
350 Enabled bazel.BoolAttribute
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400351}
352
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000353func parseSrc(ctx android.BazelConversionPathContext, srcLabelAttribute *bazel.LabelAttribute, axis bazel.ConfigurationAxis, config string, srcs []string) {
354 srcFileError := func() {
355 ctx.ModuleErrorf("parseSrc: Expected at most one source file for %s %s\n", axis, config)
356 }
357 if len(srcs) > 1 {
358 srcFileError()
359 return
360 } else if len(srcs) == 0 {
361 return
362 }
363 if srcLabelAttribute.SelectValue(axis, config) != nil {
364 srcFileError()
365 return
366 }
367 srcLabelAttribute.SetSelectValue(axis, config, android.BazelLabelForModuleSrcSingle(ctx, srcs[0]))
368}
369
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000370// NOTE: Used outside of Soong repo project, in the clangprebuilts.go bootstrap_go_package
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000371func Bp2BuildParsePrebuiltLibraryProps(ctx android.BazelConversionPathContext, module *Module, isStatic bool) prebuiltAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000372
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400373 var srcLabelAttribute bazel.LabelAttribute
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000374 bp2BuildPropParseHelper(ctx, module, &prebuiltLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
375 if prebuiltLinkerProperties, ok := props.(*prebuiltLinkerProperties); ok {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000376 parseSrc(ctx, &srcLabelAttribute, axis, config, prebuiltLinkerProperties.Srcs)
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000377 }
378 })
379
380 var enabledLabelAttribute bazel.BoolAttribute
381 parseAttrs := func(axis bazel.ConfigurationAxis, config string, props StaticOrSharedProperties) {
382 if props.Enabled != nil {
383 enabledLabelAttribute.SetSelectValue(axis, config, props.Enabled)
384 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000385 parseSrc(ctx, &srcLabelAttribute, axis, config, props.Srcs)
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000386 }
387
388 if isStatic {
389 bp2BuildPropParseHelper(ctx, module, &StaticProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
390 if staticProperties, ok := props.(*StaticProperties); ok {
391 parseAttrs(axis, config, staticProperties.Static)
392 }
393 })
394 } else {
395 bp2BuildPropParseHelper(ctx, module, &SharedProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
396 if sharedProperties, ok := props.(*SharedProperties); ok {
397 parseAttrs(axis, config, sharedProperties.Shared)
398 }
399 })
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400400 }
401
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400402 return prebuiltAttributes{
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000403 Src: srcLabelAttribute,
404 Enabled: enabledLabelAttribute,
405 }
406}
407
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000408func bp2BuildParsePrebuiltBinaryProps(ctx android.BazelConversionPathContext, module *Module) prebuiltAttributes {
409 var srcLabelAttribute bazel.LabelAttribute
410 bp2BuildPropParseHelper(ctx, module, &prebuiltLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
411 if props, ok := props.(*prebuiltLinkerProperties); ok {
412 parseSrc(ctx, &srcLabelAttribute, axis, config, props.Srcs)
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000413 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000414 })
415
416 return prebuiltAttributes{
417 Src: srcLabelAttribute,
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400418 }
419}
420
Colin Crossc5075e92022-12-05 16:46:39 -0800421func bp2BuildParsePrebuiltObjectProps(ctx android.BazelConversionPathContext, module *Module) prebuiltAttributes {
422 var srcLabelAttribute bazel.LabelAttribute
423 bp2BuildPropParseHelper(ctx, module, &prebuiltObjectProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
424 if props, ok := props.(*prebuiltObjectProperties); ok {
425 parseSrc(ctx, &srcLabelAttribute, axis, config, props.Srcs)
426 }
427 })
428
429 return prebuiltAttributes{
430 Src: srcLabelAttribute,
431 }
432}
433
Liz Kammere6583482021-10-19 13:56:10 -0400434type baseAttributes struct {
435 compilerAttributes
436 linkerAttributes
Liz Kammer12615db2021-09-28 09:19:17 -0400437
Trevor Radcliffedb7e0262022-10-28 16:48:18 +0000438 // A combination of compilerAttributes.features and linkerAttributes.features, as well as sanitizer features
Cole Faust5fa4e962022-08-22 14:31:04 -0700439 features bazel.StringListAttribute
Liz Kammer12615db2021-09-28 09:19:17 -0400440 protoDependency *bazel.LabelAttribute
Vinh Tran9f6796a2022-08-16 13:10:31 -0400441 aidlDependency *bazel.LabelAttribute
Yu Liuf01a0f02022-12-07 15:45:30 -0800442 Native_coverage *bool
Liz Kammere6583482021-10-19 13:56:10 -0400443}
444
Jingwen Chen107c0de2021-04-09 10:43:12 +0000445// Convenience struct to hold all attributes parsed from compiler properties.
446type compilerAttributes struct {
Chris Parsons990c4f42021-05-25 12:10:58 -0400447 // Options for all languages
448 copts bazel.StringListAttribute
449 // Assembly options and sources
450 asFlags bazel.StringListAttribute
451 asSrcs bazel.LabelListAttribute
Cole Faust7071a052022-07-29 15:58:33 -0700452 asmSrcs bazel.LabelListAttribute
Chris Parsons990c4f42021-05-25 12:10:58 -0400453 // C options and sources
454 conlyFlags bazel.StringListAttribute
455 cSrcs bazel.LabelListAttribute
456 // C++ options and sources
457 cppFlags bazel.StringListAttribute
Jingwen Chened9c17d2021-04-13 07:14:55 +0000458 srcs bazel.LabelListAttribute
Chris Parsons2c788392021-08-10 11:58:07 -0400459
Liz Kammer084d6a92023-06-22 16:23:53 -0400460 // xsd config sources
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400461 xsdSrcs bazel.LabelListAttribute
462 exportXsdSrcs bazel.LabelListAttribute
Liz Kammer084d6a92023-06-22 16:23:53 -0400463
Liz Kammer0db0e342023-07-18 11:39:30 -0400464 // genrule headers
465 genruleHeaders bazel.LabelListAttribute
466 exportGenruleHeaders bazel.LabelListAttribute
467
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000468 // Lex sources and options
469 lSrcs bazel.LabelListAttribute
470 llSrcs bazel.LabelListAttribute
471 lexopts bazel.StringListAttribute
472
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000473 // Sysprop sources
474 syspropSrcs bazel.LabelListAttribute
475
Spandan Dasdf4c2132023-05-09 23:58:52 +0000476 // Yacc sources
477 yaccSrc *bazel.LabelAttribute
478 yaccFlags bazel.StringListAttribute
479 yaccGenLocationHeader bazel.BoolAttribute
480 yaccGenPositionHeader bazel.BoolAttribute
481
Alixe2667872023-04-24 14:57:32 +0000482 rsSrcs bazel.LabelListAttribute
483
Liz Kammere6583482021-10-19 13:56:10 -0400484 hdrs bazel.LabelListAttribute
485
Chris Parsons2c788392021-08-10 11:58:07 -0400486 rtti bazel.BoolAttribute
Jingwen Chen5b11ab12021-10-11 17:44:33 +0000487
488 // Not affected by arch variants
489 stl *string
Chris Parsons79bd2b72021-11-29 17:52:41 -0500490 cStd *string
Jingwen Chen5b11ab12021-10-11 17:44:33 +0000491 cppStd *string
Liz Kammer35687bc2021-09-10 10:07:07 -0400492
493 localIncludes bazel.StringListAttribute
494 absoluteIncludes bazel.StringListAttribute
Liz Kammer12615db2021-09-28 09:19:17 -0400495
Liz Kammer1263d9b2021-12-10 14:28:20 -0500496 includes BazelIncludes
497
Alixe2667872023-04-24 14:57:32 +0000498 protoSrcs bazel.LabelListAttribute
499 aidlSrcs bazel.LabelListAttribute
500 rscriptSrcs bazel.LabelListAttribute
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000501
502 stubsSymbolFile *string
503 stubsVersions bazel.StringListAttribute
Cole Faust5fa4e962022-08-22 14:31:04 -0700504
505 features bazel.StringListAttribute
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500506
Spandan Das39ccf932023-05-26 18:03:39 +0000507 stem bazel.StringAttribute
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500508 suffix bazel.StringAttribute
Vinh Tran99270ea2022-11-28 11:15:23 -0500509
510 fdoProfile bazel.LabelAttribute
Jingwen Chen107c0de2021-04-09 10:43:12 +0000511}
512
Liz Kammercac7f692021-12-16 14:19:32 -0500513type filterOutFn func(string) bool
514
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000515// filterOutHiddenVisibility removes the flag specifying hidden visibility as
516// this flag is converted to a toolchain feature
517func filterOutHiddenVisibility(flag string) bool {
518 return flag == config.VisibilityHiddenFlag
519}
520
Liz Kammercac7f692021-12-16 14:19:32 -0500521func filterOutStdFlag(flag string) bool {
522 return strings.HasPrefix(flag, "-std=")
523}
524
Alix1be00d42022-05-16 22:56:04 +0000525func filterOutClangUnknownCflags(flag string) bool {
526 for _, f := range config.ClangUnknownCflags {
527 if f == flag {
528 return true
529 }
530 }
531 return false
532}
533
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000534func parseCommandLineFlags(soongFlags []string, filterOut ...filterOutFn) []string {
Liz Kammere6583482021-10-19 13:56:10 -0400535 var result []string
536 for _, flag := range soongFlags {
Alix1be00d42022-05-16 22:56:04 +0000537 skipFlag := false
538 for _, filter := range filterOut {
539 if filter != nil && filter(flag) {
540 skipFlag = true
541 }
542 }
543 if skipFlag {
Liz Kammercac7f692021-12-16 14:19:32 -0500544 continue
545 }
Liz Kammere6583482021-10-19 13:56:10 -0400546 // Soong's cflags can contain spaces, like `-include header.h`. For
547 // Bazel's copts, split them up to be compatible with the
548 // no_copts_tokenization feature.
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000549 result = append(result, strings.Split(flag, " ")...)
Liz Kammere6583482021-10-19 13:56:10 -0400550 }
551 return result
552}
Jingwen Chened9c17d2021-04-13 07:14:55 +0000553
Jingwen Chen55bc8202021-11-02 06:40:51 +0000554func (ca *compilerAttributes) bp2buildForAxisAndConfig(ctx android.BazelConversionPathContext, axis bazel.ConfigurationAxis, config string, props *BaseCompilerProperties) {
Liz Kammere6583482021-10-19 13:56:10 -0400555 // If there's arch specific srcs or exclude_srcs, generate a select entry for it.
556 // TODO(b/186153868): do this for OS specific srcs and exclude_srcs too.
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400557 srcsList, ok := parseSrcs(ctx, props)
Liz Kammer084d6a92023-06-22 16:23:53 -0400558
559 if ok {
Liz Kammere6583482021-10-19 13:56:10 -0400560 ca.srcs.SetSelectValue(axis, config, srcsList)
Chris Parsons990c4f42021-05-25 12:10:58 -0400561 }
562
Liz Kammere6583482021-10-19 13:56:10 -0400563 localIncludeDirs := props.Local_include_dirs
564 if axis == bazel.NoConfigAxis {
Chris Parsons79bd2b72021-11-29 17:52:41 -0500565 ca.cStd, ca.cppStd = bp2buildResolveCppStdValue(props.C_std, props.Cpp_std, props.Gnu_extensions)
Liz Kammere6583482021-10-19 13:56:10 -0400566 if includeBuildDirectory(props.Include_build_directory) {
567 localIncludeDirs = append(localIncludeDirs, ".")
Liz Kammer222bdcf2021-10-11 14:15:51 -0400568 }
Jingwen Chene32e9e02021-04-23 09:17:24 +0000569 }
570
Liz Kammere6583482021-10-19 13:56:10 -0400571 ca.absoluteIncludes.SetSelectValue(axis, config, props.Include_dirs)
572 ca.localIncludes.SetSelectValue(axis, config, localIncludeDirs)
573
Cole Faust5fa4e962022-08-22 14:31:04 -0700574 instructionSet := proptools.StringDefault(props.Instruction_set, "")
575 if instructionSet == "arm" {
Trevor Radcliffe5f0c2ac2023-05-15 18:00:59 +0000576 ca.features.SetSelectValue(axis, config, []string{"arm_isa_arm"})
Cole Faust5fa4e962022-08-22 14:31:04 -0700577 } else if instructionSet != "" && instructionSet != "thumb" {
578 ctx.ModuleErrorf("Unknown value for instruction_set: %s", instructionSet)
579 }
580
Liz Kammercac7f692021-12-16 14:19:32 -0500581 // In Soong, cflags occur on the command line before -std=<val> flag, resulting in the value being
582 // overridden. In Bazel we always allow overriding, via flags; however, this can cause
583 // incompatibilities, so we remove "-std=" flags from Cflag properties while leaving it in other
584 // cases.
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000585 ca.copts.SetSelectValue(axis, config, parseCommandLineFlags(props.Cflags, filterOutStdFlag, filterOutClangUnknownCflags, filterOutHiddenVisibility))
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000586 ca.asFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Asflags, nil))
587 ca.conlyFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Conlyflags, filterOutClangUnknownCflags))
588 ca.cppFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Cppflags, filterOutClangUnknownCflags))
Liz Kammere6583482021-10-19 13:56:10 -0400589 ca.rtti.SetSelectValue(axis, config, props.Rtti)
590}
591
Jingwen Chen55bc8202021-11-02 06:40:51 +0000592func (ca *compilerAttributes) convertStlProps(ctx android.ArchVariantContext, module *Module) {
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000593 bp2BuildPropParseHelper(ctx, module, &StlProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
594 if stlProps, ok := props.(*StlProperties); ok {
595 if stlProps.Stl == nil {
596 return
597 }
598 if ca.stl == nil {
Liz Kammer7128d382022-05-12 11:42:33 -0400599 stl := deduplicateStlInput(*stlProps.Stl)
600 ca.stl = &stl
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000601 } else if ca.stl != stlProps.Stl {
602 ctx.ModuleErrorf("Unsupported conversion: module with different stl for different variants: %s and %s", *ca.stl, stlProps.Stl)
Liz Kammer9abd62d2021-05-21 08:37:59 -0400603 }
Jingwen Chenc1c26502021-04-05 10:35:13 +0000604 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000605 })
Liz Kammere6583482021-10-19 13:56:10 -0400606}
Jingwen Chenc1c26502021-04-05 10:35:13 +0000607
Jingwen Chen55bc8202021-11-02 06:40:51 +0000608func (ca *compilerAttributes) convertProductVariables(ctx android.BazelConversionPathContext, productVariableProps android.ProductConfigProperties) {
Liz Kammerba7a9c52021-05-26 08:45:30 -0400609 productVarPropNameToAttribute := map[string]*bazel.StringListAttribute{
Liz Kammere6583482021-10-19 13:56:10 -0400610 "Cflags": &ca.copts,
611 "Asflags": &ca.asFlags,
Yu Liu93893ba2023-05-01 13:49:52 -0700612 "Cppflags": &ca.cppFlags,
Liz Kammerba7a9c52021-05-26 08:45:30 -0400613 }
Liz Kammerba7a9c52021-05-26 08:45:30 -0400614 for propName, attr := range productVarPropNameToAttribute {
Jingwen Chen25825ca2021-11-15 12:28:43 +0000615 if productConfigProps, exists := productVariableProps[propName]; exists {
616 for productConfigProp, prop := range productConfigProps {
617 flags, ok := prop.([]string)
Liz Kammerba7a9c52021-05-26 08:45:30 -0400618 if !ok {
619 ctx.ModuleErrorf("Could not convert product variable %s property", proptools.PropertyNameForField(propName))
620 }
Cole Faust150f9a52023-04-26 10:52:24 -0700621 newFlags, _ := bazel.TryVariableSubstitutions(flags, productConfigProp.Name())
Jingwen Chen25825ca2021-11-15 12:28:43 +0000622 attr.SetSelectValue(productConfigProp.ConfigurationAxis(), productConfigProp.SelectKey(), newFlags)
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400623 }
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400624 }
625 }
Liz Kammere6583482021-10-19 13:56:10 -0400626}
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400627
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400628func (ca *compilerAttributes) finalize(ctx android.BazelConversionPathContext, implementationHdrs, exportHdrs bazel.LabelListAttribute) {
Liz Kammere6583482021-10-19 13:56:10 -0400629 ca.srcs.ResolveExcludes()
630 partitionedSrcs := groupSrcsByExtension(ctx, ca.srcs)
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400631 partitionedImplHdrs := partitionHeaders(ctx, implementationHdrs)
632 partitionedHdrs := partitionHeaders(ctx, exportHdrs)
Liz Kammere6583482021-10-19 13:56:10 -0400633
Liz Kammer12615db2021-09-28 09:19:17 -0400634 ca.protoSrcs = partitionedSrcs[protoSrcPartition]
Spandan Dasa99348d2023-08-01 23:10:05 +0000635 ca.protoSrcs.Append(partitionedSrcs[protoFromGenPartition])
Vinh Tran9f6796a2022-08-16 13:10:31 -0400636 ca.aidlSrcs = partitionedSrcs[aidlSrcPartition]
Liz Kammer12615db2021-09-28 09:19:17 -0400637
Liz Kammere6583482021-10-19 13:56:10 -0400638 for p, lla := range partitionedSrcs {
639 // if there are no sources, there is no need for headers
640 if lla.IsEmpty() {
641 continue
642 }
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400643 lla.Append(partitionedImplHdrs[hdrPartition])
Liz Kammere6583482021-10-19 13:56:10 -0400644 partitionedSrcs[p] = lla
645 }
646
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400647 ca.hdrs = partitionedHdrs[hdrPartition]
648
649 ca.includesFromHeaders(ctx, partitionedImplHdrs[hdrPartition], partitionedHdrs[hdrPartition])
650
651 xsdSrcs := bazel.SubtractBazelLabelListAttribute(partitionedSrcs[xsdSrcPartition], partitionedHdrs[xsdSrcPartition])
652 xsdSrcs.Append(partitionedImplHdrs[xsdSrcPartition])
653 ca.exportXsdSrcs = partitionedHdrs[xsdSrcPartition]
654 ca.xsdSrcs = bazel.FirstUniqueBazelLabelListAttribute(xsdSrcs)
655
Liz Kammer0db0e342023-07-18 11:39:30 -0400656 ca.genruleHeaders = partitionedImplHdrs[genrulePartition]
657 ca.exportGenruleHeaders = partitionedHdrs[genrulePartition]
658
Liz Kammere6583482021-10-19 13:56:10 -0400659 ca.srcs = partitionedSrcs[cppSrcPartition]
660 ca.cSrcs = partitionedSrcs[cSrcPartition]
661 ca.asSrcs = partitionedSrcs[asSrcPartition]
Cole Faust7071a052022-07-29 15:58:33 -0700662 ca.asmSrcs = partitionedSrcs[asmSrcPartition]
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000663 ca.lSrcs = partitionedSrcs[lSrcPartition]
664 ca.llSrcs = partitionedSrcs[llSrcPartition]
Spandan Dasdf4c2132023-05-09 23:58:52 +0000665 if yacc := partitionedSrcs[yaccSrcPartition]; !yacc.IsEmpty() {
666 if len(yacc.Value.Includes) > 1 {
667 ctx.PropertyErrorf("srcs", "Found multiple yacc (.y/.yy) files in library")
668 }
669 ca.yaccSrc = bazel.MakeLabelAttribute(yacc.Value.Includes[0].Label)
670 }
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000671 ca.syspropSrcs = partitionedSrcs[syspropSrcPartition]
Alixe2667872023-04-24 14:57:32 +0000672 ca.rscriptSrcs = partitionedSrcs[rScriptSrcPartition]
Liz Kammere6583482021-10-19 13:56:10 -0400673
674 ca.absoluteIncludes.DeduplicateAxesFromBase()
675 ca.localIncludes.DeduplicateAxesFromBase()
676}
677
678// Parse srcs from an arch or OS's props value.
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400679func parseSrcs(ctx android.BazelConversionPathContext, props *BaseCompilerProperties) (bazel.LabelList, bool) {
Liz Kammere6583482021-10-19 13:56:10 -0400680 anySrcs := false
681 // Add srcs-like dependencies such as generated files.
682 // First create a LabelList containing these dependencies, then merge the values with srcs.
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400683 genSrcs := props.Generated_sources
Spandan Das922171d2023-05-31 23:32:40 +0000684 generatedSrcsLabelList := android.BazelLabelForModuleDepsExcludes(ctx, genSrcs, props.Exclude_generated_sources)
Liz Kammere6583482021-10-19 13:56:10 -0400685 if len(props.Generated_sources) > 0 || len(props.Exclude_generated_sources) > 0 {
686 anySrcs = true
687 }
688
689 allSrcsLabelList := android.BazelLabelForModuleSrcExcludes(ctx, props.Srcs, props.Exclude_srcs)
Vinh Tran9f6796a2022-08-16 13:10:31 -0400690
Liz Kammere6583482021-10-19 13:56:10 -0400691 if len(props.Srcs) > 0 || len(props.Exclude_srcs) > 0 {
692 anySrcs = true
693 }
Vinh Tran9f6796a2022-08-16 13:10:31 -0400694
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400695 return bazel.AppendBazelLabelLists(allSrcsLabelList, generatedSrcsLabelList), anySrcs
Liz Kammere6583482021-10-19 13:56:10 -0400696}
697
Liz Kammera5a29de2022-05-25 23:19:37 -0400698func bp2buildStdVal(std *string, prefix string, useGnu bool) *string {
699 defaultVal := prefix + "_std_default"
Chris Parsons79bd2b72021-11-29 17:52:41 -0500700 // If c{,pp}std properties are not specified, don't generate them in the BUILD file.
701 // Defaults are handled by the toolchain definition.
702 // However, if gnu_extensions is false, then the default gnu-to-c version must be specified.
Liz Kammera5a29de2022-05-25 23:19:37 -0400703 stdVal := proptools.StringDefault(std, defaultVal)
704 if stdVal == "experimental" || stdVal == defaultVal {
705 if stdVal == "experimental" {
706 stdVal = prefix + "_std_experimental"
707 }
708 if !useGnu {
709 stdVal += "_no_gnu"
710 }
711 } else if !useGnu {
712 stdVal = gnuToCReplacer.Replace(stdVal)
Chris Parsons79bd2b72021-11-29 17:52:41 -0500713 }
714
Liz Kammera5a29de2022-05-25 23:19:37 -0400715 if stdVal == defaultVal {
716 return nil
Liz Kammer46fb7ab2021-12-01 10:09:34 -0500717 }
Liz Kammera5a29de2022-05-25 23:19:37 -0400718 return &stdVal
719}
Liz Kammer46fb7ab2021-12-01 10:09:34 -0500720
Liz Kammera5a29de2022-05-25 23:19:37 -0400721func bp2buildResolveCppStdValue(c_std *string, cpp_std *string, gnu_extensions *bool) (*string, *string) {
722 useGnu := useGnuExtensions(gnu_extensions)
723
724 return bp2buildStdVal(c_std, "c", useGnu), bp2buildStdVal(cpp_std, "cpp", useGnu)
Liz Kammere6583482021-10-19 13:56:10 -0400725}
726
Liz Kammer1263d9b2021-12-10 14:28:20 -0500727// packageFromLabel extracts package from a fully-qualified or relative Label and whether the label
728// is fully-qualified.
729// e.g. fully-qualified "//a/b:foo" -> "a/b", true, relative: ":bar" -> ".", false
730func packageFromLabel(label string) (string, bool) {
731 split := strings.Split(label, ":")
732 if len(split) != 2 {
733 return "", false
734 }
735 if split[0] == "" {
736 return ".", false
737 }
738 // remove leading "//"
739 return split[0][2:], true
740}
741
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400742// includesFromHeaders gets the include directories needed from generated headers
743func (ca *compilerAttributes) includesFromHeaders(ctx android.BazelConversionPathContext, implHdrs, hdrs bazel.LabelListAttribute) {
744 local, absolute := includesFromLabelListAttribute(implHdrs, ca.localIncludes, ca.absoluteIncludes)
745 localExport, absoluteExport := includesFromLabelListAttribute(hdrs, ca.includes.Includes, ca.includes.AbsoluteIncludes)
746
747 ca.localIncludes = local
748 ca.absoluteIncludes = absolute
749
750 ca.includes.Includes = localExport
751 ca.includes.AbsoluteIncludes = absoluteExport
752}
753
754// includesFromLabelList extracts the packages from a LabelListAttribute that should be includes and
755// combines them with existing local/absolute includes.
756func includesFromLabelListAttribute(attr bazel.LabelListAttribute, existingLocal, existingAbsolute bazel.StringListAttribute) (bazel.StringListAttribute, bazel.StringListAttribute) {
757 localAttr := existingLocal.Clone()
758 absoluteAttr := existingAbsolute.Clone()
759 if !attr.Value.IsEmpty() {
760 l, a := includesFromLabelList(attr.Value, existingLocal.Value, existingAbsolute.Value)
761 localAttr.SetSelectValue(bazel.NoConfigAxis, "", l)
762 absoluteAttr.SetSelectValue(bazel.NoConfigAxis, "", a)
763 }
764 for axis, configToLabels := range attr.ConfigurableValues {
765 for c, labels := range configToLabels {
766 local := existingLocal.SelectValue(axis, c)
767 absolute := existingAbsolute.SelectValue(axis, c)
768 l, a := includesFromLabelList(labels, local, absolute)
769 localAttr.SetSelectValue(axis, c, l)
770 absoluteAttr.SetSelectValue(axis, c, a)
771 }
772 }
773 return *localAttr, *absoluteAttr
774}
775
776// includesFromLabelList extracts relative/absolute includes from a bazel.LabelList.
777func includesFromLabelList(labelList bazel.LabelList, existingRel, existingAbs []string) ([]string, []string) {
778 var relative, absolute []string
Liz Kammer1263d9b2021-12-10 14:28:20 -0500779 for _, hdr := range labelList.Includes {
780 if pkg, hasPkg := packageFromLabel(hdr.Label); hasPkg {
781 absolute = append(absolute, pkg)
782 } else if pkg != "" {
783 relative = append(relative, pkg)
784 }
785 }
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400786 if len(relative)+len(existingRel) != 0 {
787 relative = android.FirstUniqueStrings(append(append([]string{}, existingRel...), relative...))
788 }
789 if len(absolute)+len(existingAbs) != 0 {
790 absolute = android.FirstUniqueStrings(append(append([]string{}, existingAbs...), absolute...))
791 }
Liz Kammer1263d9b2021-12-10 14:28:20 -0500792 return relative, absolute
793}
794
Cole Faust7071a052022-07-29 15:58:33 -0700795type YasmAttributes struct {
796 Srcs bazel.LabelListAttribute
797 Flags bazel.StringListAttribute
798 Include_dirs bazel.StringListAttribute
799}
800
801func bp2BuildYasm(ctx android.Bp2buildMutatorContext, m *Module, ca compilerAttributes) *bazel.LabelAttribute {
802 if ca.asmSrcs.IsEmpty() {
803 return nil
804 }
805
806 // Yasm needs the include directories from both local_includes and
807 // export_include_dirs. We don't care about actually exporting them from the
808 // yasm rule though, because they will also be present on the cc_ rule that
809 // wraps this yasm rule.
810 includes := ca.localIncludes.Clone()
811 bp2BuildPropParseHelper(ctx, m, &FlagExporterProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
812 if flagExporterProperties, ok := props.(*FlagExporterProperties); ok {
813 if len(flagExporterProperties.Export_include_dirs) > 0 {
814 x := bazel.StringListAttribute{}
815 x.SetSelectValue(axis, config, flagExporterProperties.Export_include_dirs)
816 includes.Append(x)
817 }
818 }
819 })
820
821 ctx.CreateBazelTargetModule(
822 bazel.BazelTargetModuleProperties{
823 Rule_class: "yasm",
824 Bzl_load_location: "//build/bazel/rules/cc:yasm.bzl",
825 },
826 android.CommonAttributes{Name: m.Name() + "_yasm"},
827 &YasmAttributes{
828 Srcs: ca.asmSrcs,
829 Flags: ca.asFlags,
830 Include_dirs: *includes,
831 })
832
833 // We only want to add a dependency on the _yasm target if there are asm
834 // sources in the current configuration. If there are unconfigured asm
835 // sources, always add the dependency. Otherwise, add the dependency only
836 // on the configuration axes and values that had asm sources.
837 if len(ca.asmSrcs.Value.Includes) > 0 {
838 return bazel.MakeLabelAttribute(":" + m.Name() + "_yasm")
839 }
840
841 ret := &bazel.LabelAttribute{}
842 for _, axis := range ca.asmSrcs.SortedConfigurationAxes() {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800843 for cfg := range ca.asmSrcs.ConfigurableValues[axis] {
844 ret.SetSelectValue(axis, cfg, bazel.Label{Label: ":" + m.Name() + "_yasm"})
Cole Faust7071a052022-07-29 15:58:33 -0700845 }
846 }
847 return ret
848}
849
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000850// bp2BuildParseBaseProps returns all compiler, linker, library attributes of a cc module..
Liz Kammer12615db2021-09-28 09:19:17 -0400851func bp2BuildParseBaseProps(ctx android.Bp2buildMutatorContext, module *Module) baseAttributes {
Liz Kammere6583482021-10-19 13:56:10 -0400852 archVariantCompilerProps := module.GetArchVariantProperties(ctx, &BaseCompilerProperties{})
853 archVariantLinkerProps := module.GetArchVariantProperties(ctx, &BaseLinkerProperties{})
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000854 archVariantLibraryProperties := module.GetArchVariantProperties(ctx, &LibraryProperties{})
Liz Kammere6583482021-10-19 13:56:10 -0400855
Liz Kammere6583482021-10-19 13:56:10 -0400856 axisToConfigs := map[bazel.ConfigurationAxis]map[string]bool{}
857 allAxesAndConfigs := func(cp android.ConfigurationAxisToArchVariantProperties) {
858 for axis, configMap := range cp {
859 if _, ok := axisToConfigs[axis]; !ok {
860 axisToConfigs[axis] = map[string]bool{}
861 }
Sasha Smundak39a301c2022-12-29 17:11:49 -0800862 for cfg := range configMap {
863 axisToConfigs[axis][cfg] = true
Chris Parsonsa967f252021-09-23 16:34:35 -0400864 }
865 }
866 }
Liz Kammere6583482021-10-19 13:56:10 -0400867 allAxesAndConfigs(archVariantCompilerProps)
868 allAxesAndConfigs(archVariantLinkerProps)
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000869 allAxesAndConfigs(archVariantLibraryProperties)
Chris Parsonsa967f252021-09-23 16:34:35 -0400870
Liz Kammere6583482021-10-19 13:56:10 -0400871 compilerAttrs := compilerAttributes{}
872 linkerAttrs := linkerAttributes{}
873
Vinh Tran367d89d2023-04-28 11:21:25 -0400874 var aidlLibs bazel.LabelList
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400875 var implementationHdrs, exportHdrs bazel.LabelListAttribute
Vinh Tran367d89d2023-04-28 11:21:25 -0400876
Chris Parsons7b3289b2023-01-26 17:30:44 -0500877 // Iterate through these axes in a deterministic order. This is required
878 // because processing certain dependencies may result in concatenating
879 // elements along other axes. (For example, processing NoConfig may result
880 // in elements being added to InApex). This is thus the only way to ensure
881 // that the order of entries in each list is in a predictable order.
882 for _, axis := range bazel.SortedConfigurationAxes(axisToConfigs) {
883 configs := axisToConfigs[axis]
Sasha Smundak39a301c2022-12-29 17:11:49 -0800884 for cfg := range configs {
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400885 var allHdrs []string
Sasha Smundak39a301c2022-12-29 17:11:49 -0800886 if baseCompilerProps, ok := archVariantCompilerProps[axis][cfg].(*BaseCompilerProperties); ok {
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400887 allHdrs = baseCompilerProps.Generated_headers
Spandan Das922171d2023-05-31 23:32:40 +0000888
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000889 if baseCompilerProps.Lex != nil {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800890 compilerAttrs.lexopts.SetSelectValue(axis, cfg, baseCompilerProps.Lex.Flags)
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000891 }
Spandan Dasdf4c2132023-05-09 23:58:52 +0000892 if baseCompilerProps.Yacc != nil {
893 compilerAttrs.yaccFlags.SetSelectValue(axis, cfg, baseCompilerProps.Yacc.Flags)
894 compilerAttrs.yaccGenLocationHeader.SetSelectValue(axis, cfg, baseCompilerProps.Yacc.Gen_location_hh)
895 compilerAttrs.yaccGenPositionHeader.SetSelectValue(axis, cfg, baseCompilerProps.Yacc.Gen_position_hh)
896 }
Sasha Smundak39a301c2022-12-29 17:11:49 -0800897 (&compilerAttrs).bp2buildForAxisAndConfig(ctx, axis, cfg, baseCompilerProps)
Vinh Tran367d89d2023-04-28 11:21:25 -0400898 aidlLibs.Append(android.BazelLabelForModuleDeps(ctx, baseCompilerProps.Aidl.Libs))
Liz Kammere6583482021-10-19 13:56:10 -0400899 }
900
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400901 var exportedHdrs []string
Liz Kammere6583482021-10-19 13:56:10 -0400902
Sasha Smundak39a301c2022-12-29 17:11:49 -0800903 if baseLinkerProps, ok := archVariantLinkerProps[axis][cfg].(*BaseLinkerProperties); ok {
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400904 exportedHdrs = baseLinkerProps.Export_generated_headers
Liz Kammer48cdbeb2023-03-17 10:17:50 -0400905 (&linkerAttrs).bp2buildForAxisAndConfig(ctx, module, axis, cfg, baseLinkerProps)
Liz Kammere6583482021-10-19 13:56:10 -0400906 }
Liz Kammer084d6a92023-06-22 16:23:53 -0400907
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400908 headers := maybePartitionExportedAndImplementationsDeps(ctx, !module.Binary(), allHdrs, exportedHdrs, android.BazelLabelForModuleDeps)
Liz Kammer084d6a92023-06-22 16:23:53 -0400909
Sasha Smundak39a301c2022-12-29 17:11:49 -0800910 implementationHdrs.SetSelectValue(axis, cfg, headers.implementation)
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400911 exportHdrs.SetSelectValue(axis, cfg, headers.export)
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000912
Sasha Smundak39a301c2022-12-29 17:11:49 -0800913 if libraryProps, ok := archVariantLibraryProperties[axis][cfg].(*LibraryProperties); ok {
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000914 if axis == bazel.NoConfigAxis {
Sam Delmerico75dbca22023-04-20 13:13:25 +0000915 if libraryProps.Stubs.Symbol_file != nil {
916 compilerAttrs.stubsSymbolFile = libraryProps.Stubs.Symbol_file
917 versions := android.CopyOf(libraryProps.Stubs.Versions)
918 normalizeVersions(ctx, versions)
919 versions = addCurrentVersionIfNotPresent(versions)
920 compilerAttrs.stubsVersions.SetSelectValue(axis, cfg, versions)
921 }
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000922 }
Spandan Das39ccf932023-05-26 18:03:39 +0000923 if stem := libraryProps.Stem; stem != nil {
924 compilerAttrs.stem.SetSelectValue(axis, cfg, stem)
925 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500926 if suffix := libraryProps.Suffix; suffix != nil {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800927 compilerAttrs.suffix.SetSelectValue(axis, cfg, suffix)
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500928 }
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000929 }
Liz Kammer084d6a92023-06-22 16:23:53 -0400930
Liz Kammere6583482021-10-19 13:56:10 -0400931 }
932 }
Vinh Tran9f6796a2022-08-16 13:10:31 -0400933
Liz Kammere6583482021-10-19 13:56:10 -0400934 compilerAttrs.convertStlProps(ctx, module)
935 (&linkerAttrs).convertStripProps(ctx, module)
936
Yu Liuf01a0f02022-12-07 15:45:30 -0800937 var nativeCoverage *bool
Yu Liu8d82ac52022-05-17 15:13:28 -0700938 if module.coverage != nil && module.coverage.Properties.Native_coverage != nil &&
939 !Bool(module.coverage.Properties.Native_coverage) {
Yu Liuf01a0f02022-12-07 15:45:30 -0800940 nativeCoverage = BoolPtr(false)
Yu Liu8d82ac52022-05-17 15:13:28 -0700941 }
942
Cole Faust912bc882023-03-08 12:29:50 -0800943 productVariableProps := android.ProductVariableProperties(ctx, ctx.Module())
Liz Kammere6583482021-10-19 13:56:10 -0400944
945 (&compilerAttrs).convertProductVariables(ctx, productVariableProps)
946 (&linkerAttrs).convertProductVariables(ctx, productVariableProps)
947
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400948 (&compilerAttrs).finalize(ctx, implementationHdrs, exportHdrs)
Liz Kammer54309532021-12-14 12:21:22 -0500949 (&linkerAttrs).finalize(ctx)
Liz Kammere6583482021-10-19 13:56:10 -0400950
Cole Faust7071a052022-07-29 15:58:33 -0700951 (&compilerAttrs.srcs).Add(bp2BuildYasm(ctx, module, compilerAttrs))
952
Liz Kammer0db0e342023-07-18 11:39:30 -0400953 (&linkerAttrs).deps.Append(compilerAttrs.exportGenruleHeaders)
954 (&linkerAttrs).implementationDeps.Append(compilerAttrs.genruleHeaders)
955
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400956 (&linkerAttrs).wholeArchiveDeps.Append(compilerAttrs.exportXsdSrcs)
957 (&linkerAttrs).implementationWholeArchiveDeps.Append(compilerAttrs.xsdSrcs)
958
Liz Kammer12615db2021-09-28 09:19:17 -0400959 protoDep := bp2buildProto(ctx, module, compilerAttrs.protoSrcs)
960
961 // bp2buildProto will only set wholeStaticLib or implementationWholeStaticLib, but we don't know
962 // which. This will add the newly generated proto library to the appropriate attribute and nothing
963 // to the other
964 (&linkerAttrs).wholeArchiveDeps.Add(protoDep.wholeStaticLib)
965 (&linkerAttrs).implementationWholeArchiveDeps.Add(protoDep.implementationWholeStaticLib)
Vinh Tranfde57eb2022-08-29 17:46:58 -0400966
Vinh Tran367d89d2023-04-28 11:21:25 -0400967 aidlDep := bp2buildCcAidlLibrary(
968 ctx, module,
969 compilerAttrs.aidlSrcs,
970 bazel.LabelListAttribute{
971 Value: aidlLibs,
972 },
973 linkerAttrs,
Vinh Trane6842942023-04-28 11:21:25 -0400974 compilerAttrs,
Vinh Tran367d89d2023-04-28 11:21:25 -0400975 )
Vinh Tranfde57eb2022-08-29 17:46:58 -0400976 if aidlDep != nil {
977 if lib, ok := module.linker.(*libraryDecorator); ok {
978 if proptools.Bool(lib.Properties.Aidl.Export_aidl_headers) {
979 (&linkerAttrs).wholeArchiveDeps.Add(aidlDep)
980 } else {
981 (&linkerAttrs).implementationWholeArchiveDeps.Add(aidlDep)
982 }
983 }
984 }
Liz Kammer12615db2021-09-28 09:19:17 -0400985
Spandan Dasdf4c2132023-05-09 23:58:52 +0000986 // Create a cc_yacc_static_library if srcs contains .y/.yy files
987 // This internal target will produce an .a file that will be statically linked to the parent library
988 if yaccDep := bp2buildCcYaccLibrary(ctx, compilerAttrs, linkerAttrs); yaccDep != nil {
989 (&linkerAttrs).implementationWholeArchiveDeps.Add(yaccDep)
990 }
991
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000992 convertedLSrcs := bp2BuildLex(ctx, module.Name(), compilerAttrs)
993 (&compilerAttrs).srcs.Add(&convertedLSrcs.srcName)
994 (&compilerAttrs).cSrcs.Add(&convertedLSrcs.cSrcName)
995
Vinh Tran99270ea2022-11-28 11:15:23 -0500996 if module.afdo != nil && module.afdo.Properties.Afdo {
997 fdoProfileDep := bp2buildFdoProfile(ctx, module)
998 if fdoProfileDep != nil {
999 (&compilerAttrs).fdoProfile.SetValue(*fdoProfileDep)
1000 }
1001 }
1002
Trevor Radcliffecee4e052022-09-06 19:31:25 +00001003 if !compilerAttrs.syspropSrcs.IsEmpty() {
1004 (&linkerAttrs).wholeArchiveDeps.Add(bp2buildCcSysprop(ctx, module.Name(), module.Properties.Min_sdk_version, compilerAttrs.syspropSrcs))
1005 }
1006
Zi Wang9f609db2023-01-04 11:06:54 -08001007 linkerAttrs.wholeArchiveDeps.Prepend = true
1008 linkerAttrs.deps.Prepend = true
1009 compilerAttrs.localIncludes.Prepend = true
1010 compilerAttrs.absoluteIncludes.Prepend = true
1011 compilerAttrs.hdrs.Prepend = true
1012
Alixe2667872023-04-24 14:57:32 +00001013 convertedRsSrcs, rsAbsIncludes, rsLocalIncludes := bp2buildRScript(ctx, module, compilerAttrs)
1014 (&compilerAttrs).srcs.Add(&convertedRsSrcs)
1015 (&compilerAttrs).absoluteIncludes.Append(rsAbsIncludes)
1016 (&compilerAttrs).localIncludes.Append(rsLocalIncludes)
1017 (&compilerAttrs).localIncludes.Value = android.FirstUniqueStrings(compilerAttrs.localIncludes.Value)
1018
Trevor Radcliffedb7e0262022-10-28 16:48:18 +00001019 features := compilerAttrs.features.Clone().Append(linkerAttrs.features).Append(bp2buildSanitizerFeatures(ctx, module))
Trevor Radcliffe56b1a2b2023-02-06 21:58:30 +00001020 features = features.Append(bp2buildLtoFeatures(ctx, module))
Trevor Radcliffea8b44162023-04-14 18:25:24 +00001021 features = features.Append(convertHiddenVisibilityToFeatureBase(ctx, module))
Cole Faust5fa4e962022-08-22 14:31:04 -07001022 features.DeduplicateAxesFromBase()
1023
Trevor Radcliffe0d1b4022022-12-12 22:26:34 +00001024 addMuslSystemDynamicDeps(ctx, linkerAttrs)
1025
Liz Kammere6583482021-10-19 13:56:10 -04001026 return baseAttributes{
1027 compilerAttrs,
1028 linkerAttrs,
Cole Faust5fa4e962022-08-22 14:31:04 -07001029 *features,
Liz Kammer12615db2021-09-28 09:19:17 -04001030 protoDep.protoDep,
Vinh Tran9f6796a2022-08-16 13:10:31 -04001031 aidlDep,
Yu Liuf01a0f02022-12-07 15:45:30 -08001032 nativeCoverage,
Jingwen Chen107c0de2021-04-09 10:43:12 +00001033 }
1034}
1035
Spandan Dasdf4c2132023-05-09 23:58:52 +00001036type ccYaccLibraryAttributes struct {
1037 Src bazel.LabelAttribute
1038 Flags bazel.StringListAttribute
1039 Gen_location_hh bazel.BoolAttribute
1040 Gen_position_hh bazel.BoolAttribute
1041 Local_includes bazel.StringListAttribute
1042 Implementation_deps bazel.LabelListAttribute
1043 Implementation_dynamic_deps bazel.LabelListAttribute
1044}
1045
1046func bp2buildCcYaccLibrary(ctx android.Bp2buildMutatorContext, ca compilerAttributes, la linkerAttributes) *bazel.LabelAttribute {
1047 if ca.yaccSrc == nil {
1048 return nil
1049 }
1050 yaccLibraryLabel := ctx.Module().Name() + "_yacc"
1051 ctx.CreateBazelTargetModule(
1052 bazel.BazelTargetModuleProperties{
1053 Rule_class: "cc_yacc_static_library",
1054 Bzl_load_location: "//build/bazel/rules/cc:cc_yacc_library.bzl",
1055 },
1056 android.CommonAttributes{
1057 Name: yaccLibraryLabel,
1058 },
1059 &ccYaccLibraryAttributes{
1060 Src: *ca.yaccSrc,
1061 Flags: ca.yaccFlags,
1062 Gen_location_hh: ca.yaccGenLocationHeader,
1063 Gen_position_hh: ca.yaccGenPositionHeader,
1064 Local_includes: ca.localIncludes,
1065 Implementation_deps: la.implementationDeps,
1066 Implementation_dynamic_deps: la.implementationDynamicDeps,
1067 },
1068 )
1069
1070 yaccLibrary := &bazel.LabelAttribute{
1071 Value: &bazel.Label{
1072 Label: ":" + yaccLibraryLabel,
1073 },
1074 }
1075 return yaccLibrary
1076}
1077
Trevor Radcliffe0d1b4022022-12-12 22:26:34 +00001078// As a workaround for b/261657184, we are manually adding the default value
1079// of system_dynamic_deps for the linux_musl os.
1080// TODO: Solve this properly
1081func addMuslSystemDynamicDeps(ctx android.Bp2buildMutatorContext, attrs linkerAttributes) {
1082 systemDynamicDeps := attrs.systemDynamicDeps.SelectValue(bazel.OsConfigurationAxis, "linux_musl")
1083 if attrs.systemDynamicDeps.HasAxisSpecificValues(bazel.OsConfigurationAxis) && systemDynamicDeps.IsNil() {
1084 attrs.systemDynamicDeps.SetSelectValue(bazel.OsConfigurationAxis, "linux_musl", android.BazelLabelForModuleDeps(ctx, config.MuslDefaultSharedLibraries))
1085 }
1086}
1087
Vinh Tran99270ea2022-11-28 11:15:23 -05001088type fdoProfileAttributes struct {
1089 Absolute_path_profile string
1090}
1091
1092func bp2buildFdoProfile(
1093 ctx android.Bp2buildMutatorContext,
1094 m *Module,
1095) *bazel.Label {
1096 for _, project := range globalAfdoProfileProjects {
Vinh Tranbc9c8b42022-12-09 12:03:52 -05001097 // Ensure handcrafted BUILD file exists in the project
1098 BUILDPath := android.ExistentPathForSource(ctx, project, "BUILD")
1099 if BUILDPath.Valid() {
1100 // We handcraft a BUILD file with fdo_profile targets that use the existing profiles in the project
1101 // This implementation is assuming that every afdo profile in globalAfdoProfileProjects already has
1102 // an associated fdo_profile target declared in the same package.
1103 // TODO(b/260714900): Handle arch-specific afdo profiles (e.g. `<module-name>-arm<64>.afdo`)
1104 path := android.ExistentPathForSource(ctx, project, m.Name()+".afdo")
1105 if path.Valid() {
1106 // FIXME: Some profiles only exist internally and are not released to AOSP.
1107 // When generated BUILD files are checked in, we'll run into merge conflict.
1108 // The cc_library_shared target in AOSP won't have reference to an fdo_profile target because
1109 // the profile doesn't exist. Internally, the same cc_library_shared target will
1110 // have reference to the fdo_profile.
1111 // For more context, see b/258682955#comment2
1112 fdoProfileLabel := "//" + strings.TrimSuffix(project, "/") + ":" + m.Name()
1113 return &bazel.Label{
1114 Label: fdoProfileLabel,
1115 }
Vinh Tran99270ea2022-11-28 11:15:23 -05001116 }
1117 }
1118 }
1119
1120 return nil
1121}
1122
Vinh Tran9f6796a2022-08-16 13:10:31 -04001123func bp2buildCcAidlLibrary(
1124 ctx android.Bp2buildMutatorContext,
1125 m *Module,
Vinh Tran367d89d2023-04-28 11:21:25 -04001126 aidlSrcs bazel.LabelListAttribute,
1127 aidlLibs bazel.LabelListAttribute,
Vinh Tran395a1e92022-09-16 18:27:29 -04001128 linkerAttrs linkerAttributes,
Vinh Trane6842942023-04-28 11:21:25 -04001129 compilerAttrs compilerAttributes,
Vinh Tran9f6796a2022-08-16 13:10:31 -04001130) *bazel.LabelAttribute {
Vinh Tran367d89d2023-04-28 11:21:25 -04001131 var aidlLibsFromSrcs, aidlFiles bazel.LabelListAttribute
1132 apexAvailableTags := android.ApexAvailableTagsWithoutTestApexes(ctx.(android.TopDownMutatorContext), ctx.Module())
1133
1134 if !aidlSrcs.IsEmpty() {
1135 aidlLibsFromSrcs, aidlFiles = aidlSrcs.Partition(func(src bazel.Label) bool {
Vinh Trana3b8b782022-09-14 11:40:24 -04001136 if fg, ok := android.ToFileGroupAsLibrary(ctx, src.OriginalModuleName); ok &&
1137 fg.ShouldConvertToAidlLibrary(ctx) {
1138 return true
1139 }
1140 return false
1141 })
Vinh Tran9f6796a2022-08-16 13:10:31 -04001142
Vinh Tran367d89d2023-04-28 11:21:25 -04001143 if !aidlFiles.IsEmpty() {
Vinh Trana3b8b782022-09-14 11:40:24 -04001144 aidlLibName := m.Name() + "_aidl_library"
1145 ctx.CreateBazelTargetModule(
1146 bazel.BazelTargetModuleProperties{
1147 Rule_class: "aidl_library",
Sam Delmericoe55bf082023-03-31 09:47:28 -04001148 Bzl_load_location: "//build/bazel/rules/aidl:aidl_library.bzl",
Vinh Trana3b8b782022-09-14 11:40:24 -04001149 },
Vinh Tran367d89d2023-04-28 11:21:25 -04001150 android.CommonAttributes{
1151 Name: aidlLibName,
Liz Kammer2b3f56e2023-03-23 11:51:49 -04001152 Tags: apexAvailableTags,
Vinh Trana3b8b782022-09-14 11:40:24 -04001153 },
Vinh Tran367d89d2023-04-28 11:21:25 -04001154 &aidlLibraryAttributes{
1155 Srcs: aidlFiles,
Vinh Trana3b8b782022-09-14 11:40:24 -04001156 },
1157 )
Vinh Tran367d89d2023-04-28 11:21:25 -04001158 aidlLibsFromSrcs.Add(&bazel.LabelAttribute{Value: &bazel.Label{Label: ":" + aidlLibName}})
Vinh Trana3b8b782022-09-14 11:40:24 -04001159 }
Vinh Tran9f6796a2022-08-16 13:10:31 -04001160 }
1161
Vinh Tran367d89d2023-04-28 11:21:25 -04001162 allAidlLibs := aidlLibs.Clone()
1163 allAidlLibs.Append(aidlLibsFromSrcs)
1164
1165 if !allAidlLibs.IsEmpty() {
1166 ccAidlLibrarylabel := m.Name() + "_cc_aidl_library"
1167 // Since parent cc_library already has these dependencies, we can add them as implementation
1168 // deps so that they don't re-export
1169 implementationDeps := linkerAttrs.deps.Clone()
1170 implementationDeps.Append(linkerAttrs.implementationDeps)
1171 implementationDynamicDeps := linkerAttrs.dynamicDeps.Clone()
1172 implementationDynamicDeps.Append(linkerAttrs.implementationDynamicDeps)
1173
1174 sdkAttrs := bp2BuildParseSdkAttributes(m)
1175
Vinh Trane6842942023-04-28 11:21:25 -04001176 exportedIncludes := bp2BuildParseExportedIncludes(ctx, m, &compilerAttrs.includes)
1177 includeAttrs := includesAttributes{
1178 Export_includes: exportedIncludes.Includes,
1179 Export_absolute_includes: exportedIncludes.AbsoluteIncludes,
1180 Export_system_includes: exportedIncludes.SystemIncludes,
1181 Local_includes: compilerAttrs.localIncludes,
1182 Absolute_includes: compilerAttrs.absoluteIncludes,
1183 }
1184
Vinh Tran367d89d2023-04-28 11:21:25 -04001185 ctx.CreateBazelTargetModule(
1186 bazel.BazelTargetModuleProperties{
1187 Rule_class: "cc_aidl_library",
1188 Bzl_load_location: "//build/bazel/rules/cc:cc_aidl_library.bzl",
1189 },
1190 android.CommonAttributes{Name: ccAidlLibrarylabel},
1191 &ccAidlLibraryAttributes{
1192 Deps: *allAidlLibs,
1193 Implementation_deps: *implementationDeps,
1194 Implementation_dynamic_deps: *implementationDynamicDeps,
1195 Tags: apexAvailableTags,
1196 sdkAttributes: sdkAttrs,
Vinh Trane6842942023-04-28 11:21:25 -04001197 includesAttributes: includeAttrs,
Vinh Tran367d89d2023-04-28 11:21:25 -04001198 },
1199 )
1200 label := &bazel.LabelAttribute{
1201 Value: &bazel.Label{
1202 Label: ":" + ccAidlLibrarylabel,
1203 },
1204 }
1205 return label
1206 }
1207
Vinh Trana3b8b782022-09-14 11:40:24 -04001208 return nil
Vinh Tran9f6796a2022-08-16 13:10:31 -04001209}
1210
Yu Liufc603162022-03-01 15:44:08 -08001211func bp2BuildParseSdkAttributes(module *Module) sdkAttributes {
Trevor Radcliffe58ea4512022-04-07 20:36:39 +00001212 return sdkAttributes{
1213 Sdk_version: module.Properties.Sdk_version,
Yu Liufc603162022-03-01 15:44:08 -08001214 Min_sdk_version: module.Properties.Min_sdk_version,
1215 }
1216}
1217
1218type sdkAttributes struct {
1219 Sdk_version *string
1220 Min_sdk_version *string
1221}
1222
Jingwen Chen107c0de2021-04-09 10:43:12 +00001223// Convenience struct to hold all attributes parsed from linker properties.
1224type linkerAttributes struct {
Liz Kammer54309532021-12-14 12:21:22 -05001225 deps bazel.LabelListAttribute
1226 implementationDeps bazel.LabelListAttribute
1227 dynamicDeps bazel.LabelListAttribute
1228 implementationDynamicDeps bazel.LabelListAttribute
Cole Faust6b29f592022-08-09 09:50:56 -07001229 runtimeDeps bazel.LabelListAttribute
Liz Kammer54309532021-12-14 12:21:22 -05001230 wholeArchiveDeps bazel.LabelListAttribute
1231 implementationWholeArchiveDeps bazel.LabelListAttribute
1232 systemDynamicDeps bazel.LabelListAttribute
Liz Kammerb4928432023-06-02 18:43:36 -04001233 usedSystemDynamicDepAsStaticDep map[string]bool
Liz Kammer54309532021-12-14 12:21:22 -05001234 usedSystemDynamicDepAsDynamicDep map[string]bool
Liz Kammer7a210ac2021-09-22 15:52:58 -04001235
Rupert Shuttleworth484aa252021-12-10 07:22:53 -05001236 useVersionLib bazel.BoolAttribute
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001237 linkopts bazel.StringListAttribute
Liz Kammerd2871182021-10-04 13:54:37 -04001238 additionalLinkerInputs bazel.LabelListAttribute
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001239 stripKeepSymbols bazel.BoolAttribute
1240 stripKeepSymbolsAndDebugFrame bazel.BoolAttribute
1241 stripKeepSymbolsList bazel.StringListAttribute
1242 stripAll bazel.BoolAttribute
1243 stripNone bazel.BoolAttribute
Liz Kammer0eae52e2021-10-06 10:32:26 -04001244 features bazel.StringListAttribute
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001245}
1246
Liz Kammer54309532021-12-14 12:21:22 -05001247var (
1248 soongSystemSharedLibs = []string{"libc", "libm", "libdl"}
Liz Kammerbaced712022-09-16 09:01:29 -04001249 versionLib = "libbuildversion"
Liz Kammer54309532021-12-14 12:21:22 -05001250)
1251
Vinh Tran85fb07c2022-09-16 16:17:48 -04001252// resolveTargetApex re-adds the shared and static libs in target.apex.exclude_shared|static_libs props to non-apex variant
1253// since all libs are already excluded by default
Liz Kammer748d7072023-01-25 12:07:43 -05001254func (la *linkerAttributes) resolveTargetApexProp(ctx android.BazelConversionPathContext, props *BaseLinkerProperties) {
1255 excludeSharedLibs := bazelLabelForSharedDeps(ctx, props.Target.Apex.Exclude_shared_libs)
1256 sharedExcludes := bazel.LabelList{Excludes: excludeSharedLibs.Includes}
1257 sharedExcludesLabelList := bazel.LabelListAttribute{}
1258 sharedExcludesLabelList.SetSelectValue(bazel.InApexAxis, bazel.InApex, sharedExcludes)
Vinh Tran85fb07c2022-09-16 16:17:48 -04001259
Liz Kammer748d7072023-01-25 12:07:43 -05001260 la.dynamicDeps.Append(sharedExcludesLabelList)
1261 la.implementationDynamicDeps.Append(sharedExcludesLabelList)
1262
1263 excludeStaticLibs := bazelLabelForStaticDeps(ctx, props.Target.Apex.Exclude_static_libs)
1264 staticExcludes := bazel.LabelList{Excludes: excludeStaticLibs.Includes}
1265 staticExcludesLabelList := bazel.LabelListAttribute{}
1266 staticExcludesLabelList.SetSelectValue(bazel.InApexAxis, bazel.InApex, staticExcludes)
1267
1268 la.deps.Append(staticExcludesLabelList)
1269 la.implementationDeps.Append(staticExcludesLabelList)
Vinh Tran85fb07c2022-09-16 16:17:48 -04001270}
1271
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001272func (la *linkerAttributes) bp2buildForAxisAndConfig(ctx android.BazelConversionPathContext, module *Module, axis bazel.ConfigurationAxis, config string, props *BaseLinkerProperties) {
1273 isBinary := module.Binary()
Liz Kammere6583482021-10-19 13:56:10 -04001274 // Use a single variable to capture usage of nocrt in arch variants, so there's only 1 error message for this module
1275 var axisFeatures []string
Liz Kammer7a210ac2021-09-22 15:52:58 -04001276
Liz Kammercc2c1ef2022-03-21 09:03:29 -04001277 wholeStaticLibs := android.FirstUniqueStrings(props.Whole_static_libs)
Liz Kammerbaced712022-09-16 09:01:29 -04001278 staticLibs := android.FirstUniqueStrings(android.RemoveListFromList(props.Static_libs, wholeStaticLibs))
1279 if axis == bazel.NoConfigAxis {
1280 la.useVersionLib.SetSelectValue(axis, config, props.Use_version_lib)
1281 if proptools.Bool(props.Use_version_lib) {
1282 versionLibAlreadyInDeps := android.InList(versionLib, wholeStaticLibs)
1283 // remove from static libs so there is no duplicate dependency
1284 _, staticLibs = android.RemoveFromList(versionLib, staticLibs)
1285 // only add the dep if it is not in progress
1286 if !versionLibAlreadyInDeps {
Yu Liufe978fd2023-04-24 16:37:18 -07001287 wholeStaticLibs = append(wholeStaticLibs, versionLib)
Liz Kammerbaced712022-09-16 09:01:29 -04001288 }
1289 }
1290 }
1291
Liz Kammere6583482021-10-19 13:56:10 -04001292 // Excludes to parallel Soong:
1293 // https://cs.android.com/android/platform/superproject/+/master:build/soong/cc/linker.go;l=247-249;drc=088b53577dde6e40085ffd737a1ae96ad82fc4b0
Liz Kammerbaced712022-09-16 09:01:29 -04001294 la.wholeArchiveDeps.SetSelectValue(axis, config, bazelLabelForWholeDepsExcludes(ctx, wholeStaticLibs, props.Exclude_static_libs))
Liz Kammercc2c1ef2022-03-21 09:03:29 -04001295
Liz Kammerb4928432023-06-02 18:43:36 -04001296 if isBinary && module.StaticExecutable() {
1297 usedSystemStatic := android.FilterListPred(staticLibs, func(s string) bool {
1298 return android.InList(s, soongSystemSharedLibs) && !android.InList(s, props.Exclude_static_libs)
1299 })
1300
1301 for _, el := range usedSystemStatic {
1302 if la.usedSystemDynamicDepAsStaticDep == nil {
1303 la.usedSystemDynamicDepAsStaticDep = map[string]bool{}
1304 }
1305 la.usedSystemDynamicDepAsStaticDep[el] = true
1306 }
1307 }
Vinh Tran85fb07c2022-09-16 16:17:48 -04001308 staticDeps := maybePartitionExportedAndImplementationsDepsExcludes(
1309 ctx,
1310 !isBinary,
1311 staticLibs,
Liz Kammer748d7072023-01-25 12:07:43 -05001312 props.Exclude_static_libs,
Vinh Tran85fb07c2022-09-16 16:17:48 -04001313 props.Export_static_lib_headers,
1314 bazelLabelForStaticDepsExcludes,
1315 )
Liz Kammer7a210ac2021-09-22 15:52:58 -04001316
Liz Kammere6583482021-10-19 13:56:10 -04001317 headerLibs := android.FirstUniqueStrings(props.Header_libs)
1318 hDeps := maybePartitionExportedAndImplementationsDeps(ctx, !isBinary, headerLibs, props.Export_header_lib_headers, bazelLabelForHeaderDeps)
Jingwen Chen63930982021-03-24 10:04:33 -04001319
Liz Kammere6583482021-10-19 13:56:10 -04001320 (&hDeps.export).Append(staticDeps.export)
1321 la.deps.SetSelectValue(axis, config, hDeps.export)
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001322
Liz Kammere6583482021-10-19 13:56:10 -04001323 (&hDeps.implementation).Append(staticDeps.implementation)
1324 la.implementationDeps.SetSelectValue(axis, config, hDeps.implementation)
Liz Kammer0eae52e2021-10-06 10:32:26 -04001325
Liz Kammere6583482021-10-19 13:56:10 -04001326 systemSharedLibs := props.System_shared_libs
1327 // systemSharedLibs distinguishes between nil/empty list behavior:
1328 // nil -> use default values
1329 // empty list -> no values specified
1330 if len(systemSharedLibs) > 0 {
1331 systemSharedLibs = android.FirstUniqueStrings(systemSharedLibs)
1332 }
1333 la.systemDynamicDeps.SetSelectValue(axis, config, bazelLabelForSharedDeps(ctx, systemSharedLibs))
1334
1335 sharedLibs := android.FirstUniqueStrings(props.Shared_libs)
Liz Kammer54309532021-12-14 12:21:22 -05001336 excludeSharedLibs := props.Exclude_shared_libs
1337 usedSystem := android.FilterListPred(sharedLibs, func(s string) bool {
1338 return android.InList(s, soongSystemSharedLibs) && !android.InList(s, excludeSharedLibs)
1339 })
Liz Kammerb4928432023-06-02 18:43:36 -04001340
Liz Kammer54309532021-12-14 12:21:22 -05001341 for _, el := range usedSystem {
1342 if la.usedSystemDynamicDepAsDynamicDep == nil {
1343 la.usedSystemDynamicDepAsDynamicDep = map[string]bool{}
1344 }
1345 la.usedSystemDynamicDepAsDynamicDep[el] = true
1346 }
1347
Vinh Tran85fb07c2022-09-16 16:17:48 -04001348 sharedDeps := maybePartitionExportedAndImplementationsDepsExcludes(
1349 ctx,
1350 !isBinary,
1351 sharedLibs,
Liz Kammer748d7072023-01-25 12:07:43 -05001352 props.Exclude_shared_libs,
Vinh Tran85fb07c2022-09-16 16:17:48 -04001353 props.Export_shared_lib_headers,
1354 bazelLabelForSharedDepsExcludes,
1355 )
Liz Kammere6583482021-10-19 13:56:10 -04001356 la.dynamicDeps.SetSelectValue(axis, config, sharedDeps.export)
1357 la.implementationDynamicDeps.SetSelectValue(axis, config, sharedDeps.implementation)
Liz Kammer748d7072023-01-25 12:07:43 -05001358 la.resolveTargetApexProp(ctx, props)
Vinh Tran85fb07c2022-09-16 16:17:48 -04001359
Wei Li81852ca2022-07-27 00:22:06 -07001360 if axis == bazel.NoConfigAxis || (axis == bazel.OsConfigurationAxis && config == bazel.OsAndroid) {
Yu Liu10174ff2023-02-21 12:05:26 -08001361 // If a dependency in la.implementationDynamicDeps or la.dynamicDeps has stubs, its
1362 // stub variant should be used when the dependency is linked in a APEX. The
1363 // dependencies in NoConfigAxis and OsConfigurationAxis/OsAndroid are grouped by
1364 // having stubs or not, so Bazel select() statement can be used to choose
1365 // source/stub variants of them.
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001366 apexAvailable := module.ApexAvailable()
Spandan Dasac693b22023-04-24 00:07:38 +00001367 setStubsForDynamicDeps(ctx, axis, config, apexAvailable, sharedDeps.export, &la.dynamicDeps, 0, false)
1368 setStubsForDynamicDeps(ctx, axis, config, apexAvailable, sharedDeps.implementation, &la.implementationDynamicDeps, 1, false)
1369 if len(systemSharedLibs) > 0 {
1370 setStubsForDynamicDeps(ctx, axis, config, apexAvailable, bazelLabelForSharedDeps(ctx, systemSharedLibs), &la.systemDynamicDeps, 2, true)
1371 }
Wei Li81852ca2022-07-27 00:22:06 -07001372 }
Liz Kammere6583482021-10-19 13:56:10 -04001373
1374 if !BoolDefault(props.Pack_relocations, packRelocationsDefault) {
1375 axisFeatures = append(axisFeatures, "disable_pack_relocations")
1376 }
1377
1378 if Bool(props.Allow_undefined_symbols) {
1379 axisFeatures = append(axisFeatures, "-no_undefined_symbols")
1380 }
1381
1382 var linkerFlags []string
1383 if len(props.Ldflags) > 0 {
Liz Kammerf38a8372022-02-04 15:39:00 -05001384 linkerFlags = append(linkerFlags, proptools.NinjaEscapeList(props.Ldflags)...)
Liz Kammere6583482021-10-19 13:56:10 -04001385 // binaries remove static flag if -shared is in the linker flags
1386 if isBinary && android.InList("-shared", linkerFlags) {
1387 axisFeatures = append(axisFeatures, "-static_flag")
1388 }
1389 }
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +00001390
Alex Márquez Pérez Muñíz Díaz Puras Thaureaux01ec55e2023-01-30 22:53:04 +00001391 if !props.libCrt() {
1392 axisFeatures = append(axisFeatures, "-use_libcrt")
1393 }
1394 if !props.crt() {
1395 axisFeatures = append(axisFeatures, "-link_crt")
1396 }
1397
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +00001398 // This must happen before the addition of flags for Version Script and
1399 // Dynamic List, as these flags must be split on spaces and those must not
1400 linkerFlags = parseCommandLineFlags(linkerFlags, filterOutClangUnknownCflags)
1401
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001402 additionalLinkerInputs := bazel.LabelList{}
Liz Kammere6583482021-10-19 13:56:10 -04001403 if props.Version_script != nil {
1404 label := android.BazelLabelForModuleSrcSingle(ctx, *props.Version_script)
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001405 additionalLinkerInputs.Add(&label)
Liz Kammere6583482021-10-19 13:56:10 -04001406 linkerFlags = append(linkerFlags, fmt.Sprintf("-Wl,--version-script,$(location %s)", label.Label))
Trevor Radcliffef06dd912023-05-19 14:51:41 +00001407 axisFeatures = append(axisFeatures, "android_cfi_exports_map")
Liz Kammere6583482021-10-19 13:56:10 -04001408 }
Alix773adaa2022-04-27 17:49:34 +00001409
1410 if props.Dynamic_list != nil {
1411 label := android.BazelLabelForModuleSrcSingle(ctx, *props.Dynamic_list)
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001412 additionalLinkerInputs.Add(&label)
Alix773adaa2022-04-27 17:49:34 +00001413 linkerFlags = append(linkerFlags, fmt.Sprintf("-Wl,--dynamic-list,$(location %s)", label.Label))
1414 }
1415
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001416 la.additionalLinkerInputs.SetSelectValue(axis, config, additionalLinkerInputs)
Spandan Dasfb04c412023-05-15 18:35:36 +00001417 if axis == bazel.OsConfigurationAxis && (config == bazel.OsDarwin || config == bazel.OsLinux || config == bazel.OsWindows) {
1418 linkerFlags = append(linkerFlags, props.Host_ldlibs...)
1419 }
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +00001420 la.linkopts.SetSelectValue(axis, config, linkerFlags)
Liz Kammere6583482021-10-19 13:56:10 -04001421
1422 if axisFeatures != nil {
1423 la.features.SetSelectValue(axis, config, axisFeatures)
1424 }
Cole Faust6b29f592022-08-09 09:50:56 -07001425
1426 runtimeDeps := android.BazelLabelForModuleDepsExcludes(ctx, props.Runtime_libs, props.Exclude_runtime_libs)
1427 if !runtimeDeps.IsEmpty() {
1428 la.runtimeDeps.SetSelectValue(axis, config, runtimeDeps)
1429 }
Liz Kammere6583482021-10-19 13:56:10 -04001430}
1431
Spandan Das2518c022023-03-17 03:02:32 +00001432var (
1433 apiSurfaceModuleLibCurrentPackage = "@api_surfaces//" + android.ModuleLibApi.String() + "/current:"
1434)
1435
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001436func availableToSameApexes(a, b []string) bool {
1437 if len(a) == 0 && len(b) == 0 {
1438 return true
1439 }
1440 differ, _, _ := android.ListSetDifference(a, b)
1441 return !differ
1442}
1443
Spandan Das4242f102023-04-19 22:31:54 +00001444var (
Spandan Das9cad90f2023-05-04 17:15:44 +00001445 apiDomainConfigSettingKey = android.NewOnceKey("apiDomainConfigSettingKey")
1446 apiDomainConfigSettingLock sync.Mutex
Spandan Das4242f102023-04-19 22:31:54 +00001447)
1448
Spandan Das9cad90f2023-05-04 17:15:44 +00001449func getApiDomainConfigSettingMap(config android.Config) *map[string]bool {
1450 return config.Once(apiDomainConfigSettingKey, func() interface{} {
Spandan Das4242f102023-04-19 22:31:54 +00001451 return &map[string]bool{}
1452 }).(*map[string]bool)
1453}
1454
Spandan Das9cad90f2023-05-04 17:15:44 +00001455var (
1456 testApexNameToApiDomain = map[string]string{
1457 "test_broken_com.android.art": "com.android.art",
1458 }
1459)
1460
Spandan Dasa43ae132023-05-08 18:33:16 +00001461// GetApiDomain returns the canonical name of the apex. This is synonymous to the apex_name definition.
1462// https://cs.android.com/android/_/android/platform/build/soong/+/e3f0281b8897da1fe23b2f4f3a05f1dc87bcc902:apex/prebuilt.go;l=81-83;drc=2dc7244af985a6ad701b22f1271e606cabba527f;bpv=1;bpt=0
1463// For test apexes, it uses a naming convention heuristic to determine the api domain.
1464// TODO (b/281548611): Move this build/soong/android
1465func GetApiDomain(apexName string) string {
Spandan Das9cad90f2023-05-04 17:15:44 +00001466 if apiDomain, exists := testApexNameToApiDomain[apexName]; exists {
1467 return apiDomain
1468 }
1469 // Remove `test_` prefix
1470 return strings.TrimPrefix(apexName, "test_")
1471}
1472
Spandan Das4242f102023-04-19 22:31:54 +00001473// Create a config setting for this apex in build/bazel/rules/apex
1474// The use case for this is stub/impl selection in cc libraries
1475// Long term, these config_setting(s) should be colocated with the respective apex definitions.
1476// Note that this is an anti-pattern: The config_setting should be created from the apex definition
1477// and not from a cc_library.
1478// This anti-pattern is needed today since not all apexes have been allowlisted.
1479func createInApexConfigSetting(ctx android.TopDownMutatorContext, apexName string) {
1480 if apexName == android.AvailableToPlatform || apexName == android.AvailableToAnyApex {
1481 // These correspond to android-non_apex and android-in_apex
1482 return
1483 }
Spandan Das9cad90f2023-05-04 17:15:44 +00001484 apiDomainConfigSettingLock.Lock()
1485 defer apiDomainConfigSettingLock.Unlock()
Spandan Das4242f102023-04-19 22:31:54 +00001486
1487 // Return if a config_setting has already been created
Spandan Dasa43ae132023-05-08 18:33:16 +00001488 apiDomain := GetApiDomain(apexName)
Spandan Das9cad90f2023-05-04 17:15:44 +00001489 acsm := getApiDomainConfigSettingMap(ctx.Config())
1490 if _, exists := (*acsm)[apiDomain]; exists {
Spandan Das4242f102023-04-19 22:31:54 +00001491 return
1492 }
Spandan Das9cad90f2023-05-04 17:15:44 +00001493 (*acsm)[apiDomain] = true
Spandan Das4242f102023-04-19 22:31:54 +00001494
1495 csa := bazel.ConfigSettingAttributes{
1496 Flag_values: bazel.StringMapAttribute{
Spandan Das9cad90f2023-05-04 17:15:44 +00001497 "//build/bazel/rules/apex:api_domain": apiDomain,
Spandan Das4242f102023-04-19 22:31:54 +00001498 },
Spandan Das9cad90f2023-05-04 17:15:44 +00001499 // Constraint this to android
1500 Constraint_values: bazel.MakeLabelListAttribute(
1501 bazel.MakeLabelList(
1502 []bazel.Label{
1503 bazel.Label{Label: "//build/bazel/platforms/os:android"},
1504 },
1505 ),
1506 ),
Spandan Das4242f102023-04-19 22:31:54 +00001507 }
1508 ca := android.CommonAttributes{
Spandan Das9cad90f2023-05-04 17:15:44 +00001509 Name: apiDomain,
Spandan Das4242f102023-04-19 22:31:54 +00001510 }
1511 ctx.CreateBazelConfigSetting(
1512 csa,
1513 ca,
1514 "build/bazel/rules/apex",
1515 )
1516}
1517
1518func inApexConfigSetting(apexAvailable string) string {
1519 if apexAvailable == android.AvailableToPlatform {
Spandan Das6d4d9da2023-04-18 06:20:40 +00001520 return bazel.AndroidPlatform
Spandan Das4242f102023-04-19 22:31:54 +00001521 }
1522 if apexAvailable == android.AvailableToAnyApex {
1523 return bazel.AndroidAndInApex
1524 }
Spandan Dasa43ae132023-05-08 18:33:16 +00001525 apiDomain := GetApiDomain(apexAvailable)
Spandan Das9cad90f2023-05-04 17:15:44 +00001526 return "//build/bazel/rules/apex:" + apiDomain
Spandan Das4242f102023-04-19 22:31:54 +00001527}
1528
Spandan Das6d4d9da2023-04-18 06:20:40 +00001529// Inputs to stub vs impl selection.
1530type stubSelectionInfo struct {
1531 // Label of the implementation library (e.g. //bionic/libc:libc)
1532 impl bazel.Label
1533 // Axis containing the implementation library
1534 axis bazel.ConfigurationAxis
1535 // Axis key containing the implementation library
1536 config string
1537 // API domain of the apex
1538 // For test apexes (test_com.android.foo), this will be the source apex (com.android.foo)
1539 apiDomain string
1540 // List of dep labels
1541 dynamicDeps *bazel.LabelListAttribute
1542 // Boolean value for determining if the dep is in the same api domain
1543 // If false, the label will be rewritten to to the stub label
1544 sameApiDomain bool
1545}
1546
1547func useStubOrImplInApexWithName(ssi stubSelectionInfo) {
1548 lib := ssi.impl
1549 if !ssi.sameApiDomain {
1550 lib = bazel.Label{
1551 Label: apiSurfaceModuleLibCurrentPackage + strings.TrimPrefix(lib.OriginalModuleName, ":"),
1552 }
1553 }
1554 // Create a select statement specific to this apex
1555 inApexSelectValue := ssi.dynamicDeps.SelectValue(bazel.OsAndInApexAxis, inApexConfigSetting(ssi.apiDomain))
1556 (&inApexSelectValue).Append(bazel.MakeLabelList([]bazel.Label{lib}))
1557 ssi.dynamicDeps.SetSelectValue(bazel.OsAndInApexAxis, inApexConfigSetting(ssi.apiDomain), bazel.FirstUniqueBazelLabelList(inApexSelectValue))
1558 // Delete the library from the common config for this apex
1559 implDynamicDeps := ssi.dynamicDeps.SelectValue(ssi.axis, ssi.config)
1560 implDynamicDeps = bazel.SubtractBazelLabelList(implDynamicDeps, bazel.MakeLabelList([]bazel.Label{ssi.impl}))
1561 ssi.dynamicDeps.SetSelectValue(ssi.axis, ssi.config, implDynamicDeps)
1562 if ssi.axis == bazel.NoConfigAxis {
1563 // Set defaults. Defaults (i.e. host) should use impl and not stubs.
1564 defaultSelectValue := ssi.dynamicDeps.SelectValue(bazel.OsAndInApexAxis, bazel.ConditionsDefaultConfigKey)
1565 (&defaultSelectValue).Append(bazel.MakeLabelList([]bazel.Label{ssi.impl}))
1566 ssi.dynamicDeps.SetSelectValue(bazel.OsAndInApexAxis, bazel.ConditionsDefaultConfigKey, bazel.FirstUniqueBazelLabelList(defaultSelectValue))
1567 }
Liz Kammere6583482021-10-19 13:56:10 -04001568}
1569
Yu Liu10174ff2023-02-21 12:05:26 -08001570func setStubsForDynamicDeps(ctx android.BazelConversionPathContext, axis bazel.ConfigurationAxis,
Spandan Dasac693b22023-04-24 00:07:38 +00001571 config string, apexAvailable []string, dynamicLibs bazel.LabelList, dynamicDeps *bazel.LabelListAttribute, ind int, buildNonApexWithStubs bool) {
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001572
Spandan Das4242f102023-04-19 22:31:54 +00001573 // Create a config_setting for each apex_available.
1574 // This will be used to select impl of a dep if dep is available to the same apex.
1575 for _, aa := range apexAvailable {
1576 createInApexConfigSetting(ctx.(android.TopDownMutatorContext), aa)
1577 }
1578
Spandan Das6d4d9da2023-04-18 06:20:40 +00001579 apiDomainForSelects := []string{}
1580 for _, apex := range apexAvailable {
1581 apiDomainForSelects = append(apiDomainForSelects, GetApiDomain(apex))
1582 }
1583 // Always emit a select statement for the platform variant.
1584 // This ensures that b build //foo --config=android works
1585 // Soong always creates a platform variant even when the library might not be available to platform.
1586 if !android.InList(android.AvailableToPlatform, apiDomainForSelects) {
1587 apiDomainForSelects = append(apiDomainForSelects, android.AvailableToPlatform)
1588 }
1589 apiDomainForSelects = android.SortedUniqueStrings(apiDomainForSelects)
1590
1591 // Create a select for each apex this library could be included in.
1592 for _, l := range dynamicLibs.Includes {
1593 dep, _ := ctx.ModuleFromName(l.OriginalModuleName)
1594 if c, ok := dep.(*Module); !ok || !c.HasStubsVariants() {
1595 continue
1596 }
1597 // TODO (b/280339069): Decrease the verbosity of the generated BUILD files
1598 for _, apiDomain := range apiDomainForSelects {
1599 var sameApiDomain bool
1600 if apiDomain == android.AvailableToPlatform {
1601 // Platform variants in Soong use equality of apex_available for stub/impl selection.
1602 // https://cs.android.com/android/_/android/platform/build/soong/+/316b0158fe57ee7764235923e7c6f3d530da39c6:cc/cc.go;l=3393-3404;drc=176271a426496fa2688efe2b40d5c74340c63375;bpv=1;bpt=0
1603 // One of the factors behind this design choice is cc_test
1604 // Tests only have a platform variant, and using equality of apex_available ensures
1605 // that tests of an apex library gets its implementation and not stubs.
1606 // TODO (b/280343104): Discuss if we can drop this special handling for platform variants.
1607 sameApiDomain = availableToSameApexes(apexAvailable, dep.(*Module).ApexAvailable())
Spandan Das6aaab9d2023-05-04 17:27:30 +00001608 if linkable, ok := ctx.Module().(LinkableInterface); ok && linkable.Bootstrap() {
1609 sameApiDomain = true
1610 }
Spandan Das6d4d9da2023-04-18 06:20:40 +00001611 } else {
1612 sameApiDomain = android.InList(apiDomain, dep.(*Module).ApexAvailable())
1613 }
1614 ssi := stubSelectionInfo{
1615 impl: l,
1616 axis: axis,
1617 config: config,
1618 apiDomain: apiDomain,
1619 dynamicDeps: dynamicDeps,
1620 sameApiDomain: sameApiDomain,
1621 }
1622 useStubOrImplInApexWithName(ssi)
1623 }
1624 }
Yu Liu10174ff2023-02-21 12:05:26 -08001625}
1626
Jingwen Chen55bc8202021-11-02 06:40:51 +00001627func (la *linkerAttributes) convertStripProps(ctx android.BazelConversionPathContext, module *Module) {
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001628 bp2BuildPropParseHelper(ctx, module, &StripProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1629 if stripProperties, ok := props.(*StripProperties); ok {
1630 la.stripKeepSymbols.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols)
1631 la.stripKeepSymbolsList.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols_list)
1632 la.stripKeepSymbolsAndDebugFrame.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols_and_debug_frame)
1633 la.stripAll.SetSelectValue(axis, config, stripProperties.Strip.All)
1634 la.stripNone.SetSelectValue(axis, config, stripProperties.Strip.None)
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001635 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001636 })
Liz Kammere6583482021-10-19 13:56:10 -04001637}
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001638
Jingwen Chen55bc8202021-11-02 06:40:51 +00001639func (la *linkerAttributes) convertProductVariables(ctx android.BazelConversionPathContext, productVariableProps android.ProductConfigProperties) {
Jingwen Chen6ada5892021-09-17 11:38:09 +00001640
Liz Kammer47535c52021-06-02 16:02:22 -04001641 type productVarDep struct {
1642 // the name of the corresponding excludes field, if one exists
1643 excludesField string
1644 // reference to the bazel attribute that should be set for the given product variable config
1645 attribute *bazel.LabelListAttribute
Liz Kammer2d7bbe32021-06-10 18:20:06 -04001646
Jingwen Chen55bc8202021-11-02 06:40:51 +00001647 depResolutionFunc func(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList
Liz Kammer47535c52021-06-02 16:02:22 -04001648 }
1649
Zi Wang0a8a1292022-08-30 06:27:01 +00001650 // an intermediate attribute that holds Header_libs info, and will be appended to
1651 // implementationDeps at the end, to solve the confliction that both header_libs
1652 // and static_libs use implementationDeps.
1653 var headerDeps bazel.LabelListAttribute
1654
Liz Kammer47535c52021-06-02 16:02:22 -04001655 productVarToDepFields := map[string]productVarDep{
1656 // product variables do not support exclude_shared_libs
Jingwen Chen55bc8202021-11-02 06:40:51 +00001657 "Shared_libs": {attribute: &la.implementationDynamicDeps, depResolutionFunc: bazelLabelForSharedDepsExcludes},
1658 "Static_libs": {"Exclude_static_libs", &la.implementationDeps, bazelLabelForStaticDepsExcludes},
1659 "Whole_static_libs": {"Exclude_static_libs", &la.wholeArchiveDeps, bazelLabelForWholeDepsExcludes},
Zi Wang0a8a1292022-08-30 06:27:01 +00001660 "Header_libs": {attribute: &headerDeps, depResolutionFunc: bazelLabelForHeaderDepsExcludes},
Liz Kammer47535c52021-06-02 16:02:22 -04001661 }
1662
Liz Kammer47535c52021-06-02 16:02:22 -04001663 for name, dep := range productVarToDepFields {
1664 props, exists := productVariableProps[name]
1665 excludeProps, excludesExists := productVariableProps[dep.excludesField]
Sasha Smundak39a301c2022-12-29 17:11:49 -08001666 // if neither an include nor excludes property exists, then skip it
Liz Kammer47535c52021-06-02 16:02:22 -04001667 if !exists && !excludesExists {
1668 continue
1669 }
Jingwen Chen25825ca2021-11-15 12:28:43 +00001670 // Collect all the configurations that an include or exclude property exists for.
1671 // We want to iterate all configurations rather than either the include or exclude because, for a
1672 // particular configuration, we may have either only an include or an exclude to handle.
Cole Faust150f9a52023-04-26 10:52:24 -07001673 productConfigProps := make(map[android.ProductConfigOrSoongConfigProperty]bool, len(props)+len(excludeProps))
Jingwen Chen25825ca2021-11-15 12:28:43 +00001674 for p := range props {
1675 productConfigProps[p] = true
Liz Kammer47535c52021-06-02 16:02:22 -04001676 }
Jingwen Chen25825ca2021-11-15 12:28:43 +00001677 for p := range excludeProps {
1678 productConfigProps[p] = true
Liz Kammer47535c52021-06-02 16:02:22 -04001679 }
1680
Jingwen Chen25825ca2021-11-15 12:28:43 +00001681 for productConfigProp := range productConfigProps {
1682 prop, includesExists := props[productConfigProp]
1683 excludesProp, excludesExists := excludeProps[productConfigProp]
Liz Kammer47535c52021-06-02 16:02:22 -04001684 var includes, excludes []string
1685 var ok bool
1686 // if there was no includes/excludes property, casting fails and that's expected
Jingwen Chen25825ca2021-11-15 12:28:43 +00001687 if includes, ok = prop.([]string); includesExists && !ok {
Liz Kammer47535c52021-06-02 16:02:22 -04001688 ctx.ModuleErrorf("Could not convert product variable %s property", name)
1689 }
Jingwen Chen25825ca2021-11-15 12:28:43 +00001690 if excludes, ok = excludesProp.([]string); excludesExists && !ok {
Liz Kammer47535c52021-06-02 16:02:22 -04001691 ctx.ModuleErrorf("Could not convert product variable %s property", dep.excludesField)
1692 }
Liz Kammer2d7bbe32021-06-10 18:20:06 -04001693
Jingwen Chen58ff6802021-11-17 12:14:41 +00001694 dep.attribute.EmitEmptyList = productConfigProp.AlwaysEmit()
Jingwen Chen25825ca2021-11-15 12:28:43 +00001695 dep.attribute.SetSelectValue(
1696 productConfigProp.ConfigurationAxis(),
1697 productConfigProp.SelectKey(),
1698 dep.depResolutionFunc(ctx, android.FirstUniqueStrings(includes), excludes),
1699 )
Liz Kammer47535c52021-06-02 16:02:22 -04001700 }
1701 }
Zi Wang0a8a1292022-08-30 06:27:01 +00001702 la.implementationDeps.Append(headerDeps)
Liz Kammere6583482021-10-19 13:56:10 -04001703}
Liz Kammer47535c52021-06-02 16:02:22 -04001704
Liz Kammer54309532021-12-14 12:21:22 -05001705func (la *linkerAttributes) finalize(ctx android.BazelConversionPathContext) {
1706 // if system dynamic deps have the default value, any use of a system dynamic library used will
1707 // result in duplicate library errors for bionic OSes. Here, we explicitly exclude those libraries
Liz Kammer43345e22022-08-04 13:57:35 -04001708 // from bionic OSes and the no config case as these libraries only build for bionic OSes.
Liz Kammer54309532021-12-14 12:21:22 -05001709 if la.systemDynamicDeps.IsNil() && len(la.usedSystemDynamicDepAsDynamicDep) > 0 {
Cole Faust18994c72023-02-28 16:02:16 -08001710 toRemove := bazelLabelForSharedDeps(ctx, android.SortedKeys(la.usedSystemDynamicDepAsDynamicDep))
Liz Kammer43345e22022-08-04 13:57:35 -04001711 la.dynamicDeps.Exclude(bazel.NoConfigAxis, "", toRemove)
Liz Kammer54309532021-12-14 12:21:22 -05001712 la.dynamicDeps.Exclude(bazel.OsConfigurationAxis, "android", toRemove)
1713 la.dynamicDeps.Exclude(bazel.OsConfigurationAxis, "linux_bionic", toRemove)
Liz Kammer91487d42022-09-13 11:27:11 -04001714 la.implementationDynamicDeps.Exclude(bazel.NoConfigAxis, "", toRemove)
Liz Kammer54309532021-12-14 12:21:22 -05001715 la.implementationDynamicDeps.Exclude(bazel.OsConfigurationAxis, "android", toRemove)
1716 la.implementationDynamicDeps.Exclude(bazel.OsConfigurationAxis, "linux_bionic", toRemove)
Liz Kammer91487d42022-09-13 11:27:11 -04001717
1718 la.implementationDynamicDeps.Exclude(bazel.OsAndInApexAxis, bazel.ConditionsDefaultConfigKey, toRemove)
Liz Kammer91487d42022-09-13 11:27:11 -04001719 stubsToRemove := make([]bazel.Label, 0, len(la.usedSystemDynamicDepAsDynamicDep))
1720 for _, lib := range toRemove.Includes {
Spandan Das2518c022023-03-17 03:02:32 +00001721 stubLabelInApiSurfaces := bazel.Label{
1722 Label: apiSurfaceModuleLibCurrentPackage + lib.OriginalModuleName,
1723 }
1724 stubsToRemove = append(stubsToRemove, stubLabelInApiSurfaces)
Liz Kammer91487d42022-09-13 11:27:11 -04001725 }
Spandan Das6d4d9da2023-04-18 06:20:40 +00001726 // system libraries (e.g. libc, libm, libdl) belong the com.android.runtime api domain
1727 // dedupe the stubs of these libraries from the other api domains (platform, other_apexes...)
1728 for _, aa := range ctx.Module().(*Module).ApexAvailable() {
1729 la.implementationDynamicDeps.Exclude(bazel.OsAndInApexAxis, inApexConfigSetting(aa), bazel.MakeLabelList(stubsToRemove))
1730 }
1731 la.implementationDynamicDeps.Exclude(bazel.OsAndInApexAxis, bazel.AndroidPlatform, bazel.MakeLabelList(stubsToRemove))
Liz Kammer54309532021-12-14 12:21:22 -05001732 }
Liz Kammerb4928432023-06-02 18:43:36 -04001733 if la.systemDynamicDeps.IsNil() && len(la.usedSystemDynamicDepAsStaticDep) > 0 {
1734 toRemove := bazelLabelForStaticDeps(ctx, android.SortedKeys(la.usedSystemDynamicDepAsStaticDep))
1735 la.deps.Exclude(bazel.NoConfigAxis, "", toRemove)
1736 la.deps.Exclude(bazel.OsConfigurationAxis, "android", toRemove)
1737 la.deps.Exclude(bazel.OsConfigurationAxis, "linux_bionic", toRemove)
1738 la.implementationDeps.Exclude(bazel.NoConfigAxis, "", toRemove)
1739 la.implementationDeps.Exclude(bazel.OsConfigurationAxis, "android", toRemove)
1740 la.implementationDeps.Exclude(bazel.OsConfigurationAxis, "linux_bionic", toRemove)
1741 }
Liz Kammer54309532021-12-14 12:21:22 -05001742
Liz Kammere6583482021-10-19 13:56:10 -04001743 la.deps.ResolveExcludes()
1744 la.implementationDeps.ResolveExcludes()
1745 la.dynamicDeps.ResolveExcludes()
1746 la.implementationDynamicDeps.ResolveExcludes()
1747 la.wholeArchiveDeps.ResolveExcludes()
1748 la.systemDynamicDeps.ForceSpecifyEmptyList = true
Liz Kammer54309532021-12-14 12:21:22 -05001749
Jingwen Chen91220d72021-03-24 02:18:33 -04001750}
1751
Jingwen Chened9c17d2021-04-13 07:14:55 +00001752// Relativize a list of root-relative paths with respect to the module's
1753// directory.
1754//
1755// include_dirs Soong prop are root-relative (b/183742505), but
1756// local_include_dirs, export_include_dirs and export_system_include_dirs are
1757// module dir relative. This function makes a list of paths entirely module dir
1758// relative.
1759//
1760// For the `include` attribute, Bazel wants the paths to be relative to the
1761// module.
1762func bp2BuildMakePathsRelativeToModule(ctx android.BazelConversionPathContext, paths []string) []string {
Rupert Shuttleworthb8151682021-04-06 20:06:21 +00001763 var relativePaths []string
1764 for _, path := range paths {
Jingwen Chened9c17d2021-04-13 07:14:55 +00001765 // Semantics of filepath.Rel: join(ModuleDir, rel(ModuleDir, path)) == path
1766 relativePath, err := filepath.Rel(ctx.ModuleDir(), path)
1767 if err != nil {
1768 panic(err)
1769 }
Rupert Shuttleworthb8151682021-04-06 20:06:21 +00001770 relativePaths = append(relativePaths, relativePath)
1771 }
1772 return relativePaths
1773}
1774
Liz Kammer5fad5012021-09-09 14:08:21 -04001775// BazelIncludes contains information about -I and -isystem paths from a module converted to Bazel
1776// attributes.
1777type BazelIncludes struct {
Liz Kammer1263d9b2021-12-10 14:28:20 -05001778 AbsoluteIncludes bazel.StringListAttribute
1779 Includes bazel.StringListAttribute
1780 SystemIncludes bazel.StringListAttribute
Liz Kammer5fad5012021-09-09 14:08:21 -04001781}
1782
Liz Kammer54549442022-05-11 13:55:06 -04001783func bp2BuildParseExportedIncludes(ctx android.BazelConversionPathContext, module *Module, includes *BazelIncludes) BazelIncludes {
Liz Kammer1263d9b2021-12-10 14:28:20 -05001784 var exported BazelIncludes
1785 if includes != nil {
1786 exported = *includes
1787 } else {
1788 exported = BazelIncludes{}
1789 }
Zi Wang1cb11802022-12-09 16:08:54 -08001790
1791 // cc library Export_include_dirs and Export_system_include_dirs are marked
1792 // "variant_prepend" in struct tag, set their prepend property to true to make
1793 // sure bp2build generates correct result.
1794 exported.Includes.Prepend = true
1795 exported.SystemIncludes.Prepend = true
1796
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001797 bp2BuildPropParseHelper(ctx, module, &FlagExporterProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1798 if flagExporterProperties, ok := props.(*FlagExporterProperties); ok {
1799 if len(flagExporterProperties.Export_include_dirs) > 0 {
1800 exported.Includes.SetSelectValue(axis, config, android.FirstUniqueStrings(append(exported.Includes.SelectValue(axis, config), flagExporterProperties.Export_include_dirs...)))
1801 }
1802 if len(flagExporterProperties.Export_system_include_dirs) > 0 {
1803 exported.SystemIncludes.SetSelectValue(axis, config, android.FirstUniqueStrings(append(exported.SystemIncludes.SelectValue(axis, config), flagExporterProperties.Export_system_include_dirs...)))
Rupert Shuttleworth375451e2021-04-26 07:49:08 -04001804 }
Rupert Shuttleworth375451e2021-04-26 07:49:08 -04001805 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001806 })
Liz Kammer1263d9b2021-12-10 14:28:20 -05001807 exported.AbsoluteIncludes.DeduplicateAxesFromBase()
Liz Kammer5fad5012021-09-09 14:08:21 -04001808 exported.Includes.DeduplicateAxesFromBase()
1809 exported.SystemIncludes.DeduplicateAxesFromBase()
Rupert Shuttleworth375451e2021-04-26 07:49:08 -04001810
Liz Kammer5fad5012021-09-09 14:08:21 -04001811 return exported
Jingwen Chen91220d72021-03-24 02:18:33 -04001812}
Chris Parsons953b3562021-09-20 15:14:39 -04001813
Trevor Radcliffecee4e052022-09-06 19:31:25 +00001814func BazelLabelNameForStaticModule(baseLabel string) string {
1815 return baseLabel + "_bp2build_cc_library_static"
1816}
1817
Jingwen Chen55bc8202021-11-02 06:40:51 +00001818func bazelLabelForStaticModule(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -04001819 label := android.BazelModuleLabel(ctx, m)
Sasha Smundak39a301c2022-12-29 17:11:49 -08001820 if ccModule, ok := m.(*Module); ok && ccModule.typ() == fullLibrary {
Trevor Radcliffecee4e052022-09-06 19:31:25 +00001821 return BazelLabelNameForStaticModule(label)
Chris Parsons953b3562021-09-20 15:14:39 -04001822 }
1823 return label
1824}
1825
Jingwen Chen55bc8202021-11-02 06:40:51 +00001826func bazelLabelForSharedModule(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -04001827 // cc_library, at it's root name, propagates the shared library, which depends on the static
1828 // library.
1829 return android.BazelModuleLabel(ctx, m)
1830}
1831
Jingwen Chen55bc8202021-11-02 06:40:51 +00001832func bazelLabelForStaticWholeModuleDeps(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -04001833 label := bazelLabelForStaticModule(ctx, m)
1834 if aModule, ok := m.(android.Module); ok {
1835 if android.IsModulePrebuilt(aModule) {
1836 label += "_alwayslink"
1837 }
1838 }
1839 return label
1840}
1841
Liz Kammer5f5dbaa2023-07-17 17:44:08 -04001842func xsdConfigCppTarget(xsd android.XsdConfigBp2buildTargets) string {
1843 return xsd.CppBp2buildTargetName()
Liz Kammer084d6a92023-06-22 16:23:53 -04001844}
1845
Jingwen Chen55bc8202021-11-02 06:40:51 +00001846func bazelLabelForWholeDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001847 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForStaticWholeModuleDeps)
1848}
1849
Jingwen Chen55bc8202021-11-02 06:40:51 +00001850func bazelLabelForWholeDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001851 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForStaticWholeModuleDeps)
1852}
1853
Jingwen Chen55bc8202021-11-02 06:40:51 +00001854func bazelLabelForStaticDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001855 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForStaticModule)
1856}
1857
Jingwen Chen55bc8202021-11-02 06:40:51 +00001858func bazelLabelForStaticDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001859 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForStaticModule)
1860}
1861
Jingwen Chen55bc8202021-11-02 06:40:51 +00001862func bazelLabelForSharedDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001863 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForSharedModule)
1864}
1865
Jingwen Chen55bc8202021-11-02 06:40:51 +00001866func bazelLabelForHeaderDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001867 // This is not elegant, but bp2build's shared library targets only propagate
1868 // their header information as part of the normal C++ provider.
1869 return bazelLabelForSharedDeps(ctx, modules)
1870}
1871
Zi Wang0a8a1292022-08-30 06:27:01 +00001872func bazelLabelForHeaderDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
1873 // This is only used when product_variable header_libs is processed, to follow
1874 // the pattern of depResolutionFunc
1875 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForSharedModule)
1876}
1877
Jingwen Chen55bc8202021-11-02 06:40:51 +00001878func bazelLabelForSharedDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001879 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForSharedModule)
1880}
Liz Kammer2b8004b2021-10-04 13:55:44 -04001881
1882type binaryLinkerAttrs struct {
1883 Linkshared *bool
Spandan Das39ccf932023-05-26 18:03:39 +00001884 Stem bazel.StringAttribute
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05001885 Suffix bazel.StringAttribute
Liz Kammer2b8004b2021-10-04 13:55:44 -04001886}
1887
Jingwen Chen55bc8202021-11-02 06:40:51 +00001888func bp2buildBinaryLinkerProps(ctx android.BazelConversionPathContext, m *Module) binaryLinkerAttrs {
Liz Kammer2b8004b2021-10-04 13:55:44 -04001889 attrs := binaryLinkerAttrs{}
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001890 bp2BuildPropParseHelper(ctx, m, &BinaryLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1891 linkerProps := props.(*BinaryLinkerProperties)
1892 staticExecutable := linkerProps.Static_executable
1893 if axis == bazel.NoConfigAxis {
1894 if linkBinaryShared := !proptools.Bool(staticExecutable); !linkBinaryShared {
1895 attrs.Linkshared = &linkBinaryShared
Liz Kammer2b8004b2021-10-04 13:55:44 -04001896 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001897 } else if staticExecutable != nil {
1898 // TODO(b/202876379): Static_executable is arch-variant; however, linkshared is a
1899 // nonconfigurable attribute. Only 4 AOSP modules use this feature, defer handling
1900 ctx.ModuleErrorf("bp2build cannot migrate a module with arch/target-specific static_executable values")
Liz Kammer2b8004b2021-10-04 13:55:44 -04001901 }
Spandan Das39ccf932023-05-26 18:03:39 +00001902 if stem := linkerProps.Stem; stem != nil {
1903 attrs.Stem.SetSelectValue(axis, config, stem)
1904 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05001905 if suffix := linkerProps.Suffix; suffix != nil {
1906 attrs.Suffix.SetSelectValue(axis, config, suffix)
1907 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001908 })
Liz Kammer2b8004b2021-10-04 13:55:44 -04001909
1910 return attrs
1911}
Trevor Radcliffedb7e0262022-10-28 16:48:18 +00001912
1913func bp2buildSanitizerFeatures(ctx android.BazelConversionPathContext, m *Module) bazel.StringListAttribute {
1914 sanitizerFeatures := bazel.StringListAttribute{}
1915 bp2BuildPropParseHelper(ctx, m, &SanitizeProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1916 var features []string
1917 if sanitizerProps, ok := props.(*SanitizeProperties); ok {
1918 if sanitizerProps.Sanitize.Integer_overflow != nil && *sanitizerProps.Sanitize.Integer_overflow {
1919 features = append(features, "ubsan_integer_overflow")
1920 }
1921 for _, sanitizer := range sanitizerProps.Sanitize.Misc_undefined {
1922 features = append(features, "ubsan_"+sanitizer)
1923 }
Trevor Radcliffeded095c2023-06-12 19:18:28 +00001924 blocklist := sanitizerProps.Sanitize.Blocklist
1925 if blocklist != nil {
1926 // Format the blocklist name to be used in a feature name
1927 blocklistFeatureSuffix := strings.Replace(strings.ToLower(*blocklist), ".", "_", -1)
Trevor Radcliffed7148712023-07-10 18:50:47 +00001928 features = append(features, "sanitizer_blocklist_"+blocklistFeatureSuffix)
Trevor Radcliffeded095c2023-06-12 19:18:28 +00001929 }
Trevor Radcliffe523c5c62023-06-16 20:15:45 +00001930 if sanitizerProps.Sanitize.Cfi != nil && !proptools.Bool(sanitizerProps.Sanitize.Cfi) {
1931 features = append(features, "-android_cfi")
1932 } else if proptools.Bool(sanitizerProps.Sanitize.Cfi) {
Trevor Radcliffe27669c02023-03-28 20:47:10 +00001933 features = append(features, "android_cfi")
1934 if proptools.Bool(sanitizerProps.Sanitize.Config.Cfi_assembly_support) {
1935 features = append(features, "android_cfi_assembly_support")
1936 }
1937 }
Trevor Radcliffedb7e0262022-10-28 16:48:18 +00001938 sanitizerFeatures.SetSelectValue(axis, config, features)
1939 }
1940 })
1941 return sanitizerFeatures
1942}
Trevor Radcliffe56b1a2b2023-02-06 21:58:30 +00001943
1944func bp2buildLtoFeatures(ctx android.BazelConversionPathContext, m *Module) bazel.StringListAttribute {
1945 lto_feature_name := "android_thin_lto"
1946 ltoBoolFeatures := bazel.BoolAttribute{}
1947 bp2BuildPropParseHelper(ctx, m, &LTOProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1948 if ltoProps, ok := props.(*LTOProperties); ok {
1949 thinProp := ltoProps.Lto.Thin != nil && *ltoProps.Lto.Thin
1950 thinPropSetToFalse := ltoProps.Lto.Thin != nil && !*ltoProps.Lto.Thin
1951 neverProp := ltoProps.Lto.Never != nil && *ltoProps.Lto.Never
1952 if thinProp {
1953 ltoBoolFeatures.SetSelectValue(axis, config, BoolPtr(true))
1954 return
1955 }
1956 if neverProp || thinPropSetToFalse {
1957 if thinProp {
1958 ctx.ModuleErrorf("lto.thin and lto.never are mutually exclusive but were specified together")
1959 } else {
1960 ltoBoolFeatures.SetSelectValue(axis, config, BoolPtr(false))
1961 }
1962 return
1963 }
1964 }
1965 ltoBoolFeatures.SetSelectValue(axis, config, nil)
1966 })
1967
1968 props := m.GetArchVariantProperties(ctx, &LTOProperties{})
1969 ltoStringFeatures, err := ltoBoolFeatures.ToStringListAttribute(func(boolPtr *bool, axis bazel.ConfigurationAxis, config string) []string {
1970 if boolPtr == nil {
1971 return []string{}
1972 }
1973 if !*boolPtr {
1974 return []string{"-" + lto_feature_name}
1975 }
1976 features := []string{lto_feature_name}
1977 if ltoProps, ok := props[axis][config].(*LTOProperties); ok {
1978 if ltoProps.Whole_program_vtables != nil && *ltoProps.Whole_program_vtables {
1979 features = append(features, "android_thin_lto_whole_program_vtables")
1980 }
1981 }
1982 return features
1983 })
1984 if err != nil {
1985 ctx.ModuleErrorf("Error processing LTO attributes: %s", err)
1986 }
1987 return ltoStringFeatures
1988}
Trevor Radcliffea8b44162023-04-14 18:25:24 +00001989
1990func convertHiddenVisibilityToFeatureBase(ctx android.BazelConversionPathContext, m *Module) bazel.StringListAttribute {
1991 visibilityHiddenFeature := bazel.StringListAttribute{}
1992 bp2BuildPropParseHelper(ctx, m, &BaseCompilerProperties{}, func(axis bazel.ConfigurationAxis, configString string, props interface{}) {
1993 if baseCompilerProps, ok := props.(*BaseCompilerProperties); ok {
1994 convertHiddenVisibilityToFeatureHelper(&visibilityHiddenFeature, axis, configString, baseCompilerProps.Cflags)
1995 }
1996 })
1997 return visibilityHiddenFeature
1998}
1999
2000func convertHiddenVisibilityToFeatureStaticOrShared(ctx android.BazelConversionPathContext, m *Module, isStatic bool) bazel.StringListAttribute {
2001 visibilityHiddenFeature := bazel.StringListAttribute{}
2002 if isStatic {
2003 bp2BuildPropParseHelper(ctx, m, &StaticProperties{}, func(axis bazel.ConfigurationAxis, configString string, props interface{}) {
2004 if staticProps, ok := props.(*StaticProperties); ok {
2005 convertHiddenVisibilityToFeatureHelper(&visibilityHiddenFeature, axis, configString, staticProps.Static.Cflags)
2006 }
2007 })
2008 } else {
2009 bp2BuildPropParseHelper(ctx, m, &SharedProperties{}, func(axis bazel.ConfigurationAxis, configString string, props interface{}) {
2010 if sharedProps, ok := props.(*SharedProperties); ok {
2011 convertHiddenVisibilityToFeatureHelper(&visibilityHiddenFeature, axis, configString, sharedProps.Shared.Cflags)
2012 }
2013 })
2014 }
2015
2016 return visibilityHiddenFeature
2017}
2018
2019func convertHiddenVisibilityToFeatureHelper(feature *bazel.StringListAttribute, axis bazel.ConfigurationAxis, configString string, cflags []string) {
2020 if inList(config.VisibilityHiddenFlag, cflags) {
2021 feature.SetSelectValue(axis, configString, []string{"visibility_hidden"})
2022 }
2023}