blob: c9465c71a947ba9560f86bc797f108f197c2e86c [file] [log] [blame]
Jingwen Chen91220d72021-03-24 02:18:33 -04001// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
Cole Faust7071a052022-07-29 15:58:33 -07007// http://www.apache.org/licenses/LICENSE-2.0
Jingwen Chen91220d72021-03-24 02:18:33 -04008//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14package cc
15
16import (
Liz Kammerd2871182021-10-04 13:54:37 -040017 "fmt"
Jingwen Chened9c17d2021-04-13 07:14:55 +000018 "path/filepath"
Jingwen Chen3950cd62021-05-12 04:33:00 +000019 "strings"
Spandan Das4242f102023-04-19 22:31:54 +000020 "sync"
Chris Parsons484e50a2021-05-13 15:13:04 -040021
22 "android/soong/android"
23 "android/soong/bazel"
Alix1be00d42022-05-16 22:56:04 +000024 "android/soong/cc/config"
Liz Kammer7a210ac2021-09-22 15:52:58 -040025
Chris Parsons953b3562021-09-20 15:14:39 -040026 "github.com/google/blueprint"
Liz Kammerba7a9c52021-05-26 08:45:30 -040027
28 "github.com/google/blueprint/proptools"
Jingwen Chen91220d72021-03-24 02:18:33 -040029)
30
Liz Kammerae3994e2021-10-19 09:45:48 -040031const (
Trevor Radcliffecee4e052022-09-06 19:31:25 +000032 cSrcPartition = "c"
33 asSrcPartition = "as"
34 asmSrcPartition = "asm"
35 lSrcPartition = "l"
36 llSrcPartition = "ll"
37 cppSrcPartition = "cpp"
38 protoSrcPartition = "proto"
39 aidlSrcPartition = "aidl"
40 syspropSrcPartition = "sysprop"
Spandan Dasdf4c2132023-05-09 23:58:52 +000041 yaccSrcPartition = "yacc"
Liz Kammer91487d42022-09-13 11:27:11 -040042
43 stubsSuffix = "_stub_libs_current"
Liz Kammerae3994e2021-10-19 09:45:48 -040044)
45
Liz Kammer2222c6b2021-05-24 15:41:47 -040046// staticOrSharedAttributes are the Bazel-ified versions of StaticOrSharedProperties --
Jingwen Chenbcf53042021-05-26 04:42:42 +000047// properties which apply to either the shared or static version of a cc_library module.
Liz Kammer2222c6b2021-05-24 15:41:47 -040048type staticOrSharedAttributes struct {
Vinh Tran9f6796a2022-08-16 13:10:31 -040049 Srcs bazel.LabelListAttribute
50 Srcs_c bazel.LabelListAttribute
51 Srcs_as bazel.LabelListAttribute
52 Srcs_aidl bazel.LabelListAttribute
53 Hdrs bazel.LabelListAttribute
54 Copts bazel.StringListAttribute
Jingwen Chen14a8bda2021-06-02 11:10:02 +000055
Liz Kammer12615db2021-09-28 09:19:17 -040056 Deps bazel.LabelListAttribute
57 Implementation_deps bazel.LabelListAttribute
58 Dynamic_deps bazel.LabelListAttribute
59 Implementation_dynamic_deps bazel.LabelListAttribute
60 Whole_archive_deps bazel.LabelListAttribute
61 Implementation_whole_archive_deps bazel.LabelListAttribute
Cole Faust6b29f592022-08-09 09:50:56 -070062 Runtime_deps bazel.LabelListAttribute
Chris Parsons51f8c392021-08-03 21:01:05 -040063
64 System_dynamic_deps bazel.LabelListAttribute
Chris Parsons58852a02021-12-09 18:10:18 -050065
66 Enabled bazel.BoolAttribute
Yu Liufc603162022-03-01 15:44:08 -080067
Yu Liuf01a0f02022-12-07 15:45:30 -080068 Native_coverage *bool
Yu Liu8d82ac52022-05-17 15:13:28 -070069
Liz Kammeraceec252023-03-24 09:46:36 -040070 Apex_available []string
71
Trevor Radcliffea8b44162023-04-14 18:25:24 +000072 Features bazel.StringListAttribute
73
Yu Liufc603162022-03-01 15:44:08 -080074 sdkAttributes
Sam Delmericofb3bb322022-10-21 10:42:24 -040075
76 tidyAttributes
77}
78
79type tidyAttributes struct {
Sam Delmerico63f0c932023-03-14 14:05:28 -040080 Tidy *string
Sam Delmericofb3bb322022-10-21 10:42:24 -040081 Tidy_flags []string
82 Tidy_checks []string
83 Tidy_checks_as_errors []string
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -040084 Tidy_disabled_srcs bazel.LabelListAttribute
Sam Delmerico4c902d62022-11-02 14:17:15 -040085 Tidy_timeout_srcs bazel.LabelListAttribute
Sam Delmericofb3bb322022-10-21 10:42:24 -040086}
87
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -040088func (m *Module) convertTidyAttributes(ctx android.BaseMutatorContext, moduleAttrs *tidyAttributes) {
Sam Delmericofb3bb322022-10-21 10:42:24 -040089 for _, f := range m.features {
90 if tidy, ok := f.(*tidyFeature); ok {
Sam Delmerico63f0c932023-03-14 14:05:28 -040091 var tidyAttr *string
92 if tidy.Properties.Tidy != nil {
93 if *tidy.Properties.Tidy {
94 tidyAttr = proptools.StringPtr("local")
95 } else {
96 tidyAttr = proptools.StringPtr("never")
97 }
98 }
99 moduleAttrs.Tidy = tidyAttr
Sam Delmericofb3bb322022-10-21 10:42:24 -0400100 moduleAttrs.Tidy_flags = tidy.Properties.Tidy_flags
101 moduleAttrs.Tidy_checks = tidy.Properties.Tidy_checks
102 moduleAttrs.Tidy_checks_as_errors = tidy.Properties.Tidy_checks_as_errors
103 }
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400104
105 }
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400106 archVariantProps := m.GetArchVariantProperties(ctx, &BaseCompilerProperties{})
107 for axis, configToProps := range archVariantProps {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800108 for cfg, _props := range configToProps {
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400109 if archProps, ok := _props.(*BaseCompilerProperties); ok {
110 archDisabledSrcs := android.BazelLabelForModuleSrc(ctx, archProps.Tidy_disabled_srcs)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800111 moduleAttrs.Tidy_disabled_srcs.SetSelectValue(axis, cfg, archDisabledSrcs)
Sam Delmerico4c902d62022-11-02 14:17:15 -0400112 archTimeoutSrcs := android.BazelLabelForModuleSrc(ctx, archProps.Tidy_timeout_srcs)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800113 moduleAttrs.Tidy_timeout_srcs.SetSelectValue(axis, cfg, archTimeoutSrcs)
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400114 }
115 }
Sam Delmericofb3bb322022-10-21 10:42:24 -0400116 }
Jingwen Chen53681ef2021-04-29 08:15:13 +0000117}
118
Sam Delmericoc7681022022-02-04 21:01:20 +0000119// groupSrcsByExtension partitions `srcs` into groups based on file extension.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000120func groupSrcsByExtension(ctx android.BazelConversionPathContext, srcs bazel.LabelListAttribute) bazel.PartitionToLabelListAttribute {
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400121 // Convert filegroup dependencies into extension-specific filegroups filtered in the filegroup.bzl
122 // macro.
123 addSuffixForFilegroup := func(suffix string) bazel.LabelMapper {
Vinh Tran9f6796a2022-08-16 13:10:31 -0400124 return func(otherModuleCtx bazel.OtherModuleContext, label bazel.Label) (string, bool) {
125
126 m, exists := otherModuleCtx.ModuleFromName(label.OriginalModuleName)
Liz Kammer12615db2021-09-28 09:19:17 -0400127 labelStr := label.Label
Vinh Tran9f6796a2022-08-16 13:10:31 -0400128 if !exists || !android.IsFilegroup(otherModuleCtx, m) {
129 return labelStr, false
130 }
Yu Liu2aa806b2022-09-01 11:54:47 -0700131 // If the filegroup is already converted to aidl_library or proto_library,
132 // skip creating _c_srcs, _as_srcs, _cpp_srcs filegroups
133 fg, _ := m.(android.FileGroupAsLibrary)
134 if fg.ShouldConvertToAidlLibrary(ctx) || fg.ShouldConvertToProtoLibrary(ctx) {
Liz Kammer12615db2021-09-28 09:19:17 -0400135 return labelStr, false
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000136 }
Liz Kammer12615db2021-09-28 09:19:17 -0400137 return labelStr + suffix, true
Chris Parsons5a34ffb2021-07-21 14:34:58 -0400138 }
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000139 }
140
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400141 // TODO(b/190006308): Handle language detection of sources in a Bazel rule.
Sam Delmericoc7681022022-02-04 21:01:20 +0000142 labels := bazel.LabelPartitions{
143 protoSrcPartition: android.ProtoSrcLabelPartition,
Liz Kammeraabfb5d2021-12-08 15:25:06 -0500144 cSrcPartition: bazel.LabelPartition{Extensions: []string{".c"}, LabelMapper: addSuffixForFilegroup("_c_srcs")},
145 asSrcPartition: bazel.LabelPartition{Extensions: []string{".s", ".S"}, LabelMapper: addSuffixForFilegroup("_as_srcs")},
Cole Faust7071a052022-07-29 15:58:33 -0700146 asmSrcPartition: bazel.LabelPartition{Extensions: []string{".asm"}},
Vinh Tran9f6796a2022-08-16 13:10:31 -0400147 aidlSrcPartition: android.AidlSrcLabelPartition,
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000148 // TODO(http://b/231968910): If there is ever a filegroup target that
149 // contains .l or .ll files we will need to find a way to add a
150 // LabelMapper for these that identifies these filegroups and
151 // converts them appropriately
152 lSrcPartition: bazel.LabelPartition{Extensions: []string{".l"}},
153 llSrcPartition: bazel.LabelPartition{Extensions: []string{".ll"}},
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400154 // C++ is the "catch-all" group, and comprises generated sources because we don't
155 // know the language of these sources until the genrule is executed.
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000156 cppSrcPartition: bazel.LabelPartition{Extensions: []string{".cpp", ".cc", ".cxx", ".mm"}, LabelMapper: addSuffixForFilegroup("_cpp_srcs"), Keep_remainder: true},
157 syspropSrcPartition: bazel.LabelPartition{Extensions: []string{".sysprop"}},
Spandan Dasdf4c2132023-05-09 23:58:52 +0000158 yaccSrcPartition: bazel.LabelPartition{Extensions: []string{".y", "yy"}},
Sam Delmericoc7681022022-02-04 21:01:20 +0000159 }
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000160
Sam Delmericoc7681022022-02-04 21:01:20 +0000161 return bazel.PartitionLabelListAttribute(ctx, &srcs, labels)
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000162}
163
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000164// bp2BuildParseLibProps returns the attributes for a variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000165func bp2BuildParseLibProps(ctx android.BazelConversionPathContext, module *Module, isStatic bool) staticOrSharedAttributes {
Jingwen Chen53681ef2021-04-29 08:15:13 +0000166 lib, ok := module.compiler.(*libraryDecorator)
167 if !ok {
Liz Kammer2222c6b2021-05-24 15:41:47 -0400168 return staticOrSharedAttributes{}
Jingwen Chen53681ef2021-04-29 08:15:13 +0000169 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000170 return bp2buildParseStaticOrSharedProps(ctx, module, lib, isStatic)
171}
Jingwen Chen53681ef2021-04-29 08:15:13 +0000172
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000173// bp2buildParseSharedProps returns the attributes for the shared variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000174func bp2BuildParseSharedProps(ctx android.BazelConversionPathContext, module *Module) staticOrSharedAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000175 return bp2BuildParseLibProps(ctx, module, false)
Jingwen Chen53681ef2021-04-29 08:15:13 +0000176}
177
178// bp2buildParseStaticProps returns the attributes for the static variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000179func bp2BuildParseStaticProps(ctx android.BazelConversionPathContext, module *Module) staticOrSharedAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000180 return bp2BuildParseLibProps(ctx, module, true)
Liz Kammer2222c6b2021-05-24 15:41:47 -0400181}
182
Liz Kammer7a210ac2021-09-22 15:52:58 -0400183type depsPartition struct {
184 export bazel.LabelList
185 implementation bazel.LabelList
186}
187
Jingwen Chen55bc8202021-11-02 06:40:51 +0000188type bazelLabelForDepsFn func(android.BazelConversionPathContext, []string) bazel.LabelList
Liz Kammer7a210ac2021-09-22 15:52:58 -0400189
Jingwen Chen55bc8202021-11-02 06:40:51 +0000190func maybePartitionExportedAndImplementationsDeps(ctx android.BazelConversionPathContext, exportsDeps bool, allDeps, exportedDeps []string, fn bazelLabelForDepsFn) depsPartition {
Liz Kammer2b8004b2021-10-04 13:55:44 -0400191 if !exportsDeps {
192 return depsPartition{
193 implementation: fn(ctx, allDeps),
194 }
195 }
196
Liz Kammer7a210ac2021-09-22 15:52:58 -0400197 implementation, export := android.FilterList(allDeps, exportedDeps)
198
199 return depsPartition{
200 export: fn(ctx, export),
201 implementation: fn(ctx, implementation),
202 }
203}
204
Jingwen Chen55bc8202021-11-02 06:40:51 +0000205type bazelLabelForDepsExcludesFn func(android.BazelConversionPathContext, []string, []string) bazel.LabelList
Liz Kammer7a210ac2021-09-22 15:52:58 -0400206
Jingwen Chen55bc8202021-11-02 06:40:51 +0000207func maybePartitionExportedAndImplementationsDepsExcludes(ctx android.BazelConversionPathContext, exportsDeps bool, allDeps, excludes, exportedDeps []string, fn bazelLabelForDepsExcludesFn) depsPartition {
Liz Kammer2b8004b2021-10-04 13:55:44 -0400208 if !exportsDeps {
209 return depsPartition{
210 implementation: fn(ctx, allDeps, excludes),
211 }
212 }
Liz Kammer7a210ac2021-09-22 15:52:58 -0400213 implementation, export := android.FilterList(allDeps, exportedDeps)
214
215 return depsPartition{
216 export: fn(ctx, export, excludes),
217 implementation: fn(ctx, implementation, excludes),
218 }
219}
220
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000221func bp2BuildPropParseHelper(ctx android.ArchVariantContext, module *Module, propsType interface{}, parseFunc func(axis bazel.ConfigurationAxis, config string, props interface{})) {
222 for axis, configToProps := range module.GetArchVariantProperties(ctx, propsType) {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800223 for cfg, props := range configToProps {
224 parseFunc(axis, cfg, props)
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000225 }
226 }
227}
228
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000229// Parses properties common to static and shared libraries. Also used for prebuilt libraries.
Liz Kammeraceec252023-03-24 09:46:36 -0400230func bp2buildParseStaticOrSharedProps(ctx android.BazelConversionPathContext, module *Module, lib *libraryDecorator, isStatic bool) staticOrSharedAttributes {
Liz Kammer135bf552021-08-11 10:46:06 -0400231 attrs := staticOrSharedAttributes{}
Jingwen Chenbcf53042021-05-26 04:42:42 +0000232
Liz Kammer9abd62d2021-05-21 08:37:59 -0400233 setAttrs := func(axis bazel.ConfigurationAxis, config string, props StaticOrSharedProperties) {
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000234 attrs.Copts.SetSelectValue(axis, config, parseCommandLineFlags(props.Cflags, filterOutStdFlag, filterOutHiddenVisibility))
Jingwen Chenc4dc9b42021-06-11 12:51:48 +0000235 attrs.Srcs.SetSelectValue(axis, config, android.BazelLabelForModuleSrc(ctx, props.Srcs))
Chris Parsons953b3562021-09-20 15:14:39 -0400236 attrs.System_dynamic_deps.SetSelectValue(axis, config, bazelLabelForSharedDeps(ctx, props.System_shared_libs))
Liz Kammer7a210ac2021-09-22 15:52:58 -0400237
Liz Kammer2b8004b2021-10-04 13:55:44 -0400238 staticDeps := maybePartitionExportedAndImplementationsDeps(ctx, true, props.Static_libs, props.Export_static_lib_headers, bazelLabelForStaticDeps)
Liz Kammer7a210ac2021-09-22 15:52:58 -0400239 attrs.Deps.SetSelectValue(axis, config, staticDeps.export)
240 attrs.Implementation_deps.SetSelectValue(axis, config, staticDeps.implementation)
241
Liz Kammer2b8004b2021-10-04 13:55:44 -0400242 sharedDeps := maybePartitionExportedAndImplementationsDeps(ctx, true, props.Shared_libs, props.Export_shared_lib_headers, bazelLabelForSharedDeps)
Liz Kammer7a210ac2021-09-22 15:52:58 -0400243 attrs.Dynamic_deps.SetSelectValue(axis, config, sharedDeps.export)
244 attrs.Implementation_dynamic_deps.SetSelectValue(axis, config, sharedDeps.implementation)
245
246 attrs.Whole_archive_deps.SetSelectValue(axis, config, bazelLabelForWholeDeps(ctx, props.Whole_static_libs))
Chris Parsons58852a02021-12-09 18:10:18 -0500247 attrs.Enabled.SetSelectValue(axis, config, props.Enabled)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000248 }
Liz Kammer135bf552021-08-11 10:46:06 -0400249 // system_dynamic_deps distinguishes between nil/empty list behavior:
250 // nil -> use default values
251 // empty list -> no values specified
252 attrs.System_dynamic_deps.ForceSpecifyEmptyList = true
Jingwen Chenbcf53042021-05-26 04:42:42 +0000253
Liz Kammeraceec252023-03-24 09:46:36 -0400254 var apexAvailable []string
Jingwen Chenbcf53042021-05-26 04:42:42 +0000255 if isStatic {
Liz Kammeraceec252023-03-24 09:46:36 -0400256 apexAvailable = lib.StaticProperties.Static.Apex_available
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000257 bp2BuildPropParseHelper(ctx, module, &StaticProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
258 if staticOrSharedProps, ok := props.(*StaticProperties); ok {
259 setAttrs(axis, config, staticOrSharedProps.Static)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000260 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000261 })
Jingwen Chenbcf53042021-05-26 04:42:42 +0000262 } else {
Liz Kammeraceec252023-03-24 09:46:36 -0400263 apexAvailable = lib.SharedProperties.Shared.Apex_available
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000264 bp2BuildPropParseHelper(ctx, module, &SharedProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
265 if staticOrSharedProps, ok := props.(*SharedProperties); ok {
266 setAttrs(axis, config, staticOrSharedProps.Shared)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000267 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000268 })
Jingwen Chenbcf53042021-05-26 04:42:42 +0000269 }
270
Liz Kammerae3994e2021-10-19 09:45:48 -0400271 partitionedSrcs := groupSrcsByExtension(ctx, attrs.Srcs)
272 attrs.Srcs = partitionedSrcs[cppSrcPartition]
273 attrs.Srcs_c = partitionedSrcs[cSrcPartition]
274 attrs.Srcs_as = partitionedSrcs[asSrcPartition]
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000275
Spandan Das39b6cc52023-04-12 19:05:49 +0000276 attrs.Apex_available = android.ConvertApexAvailableToTagsWithoutTestApexes(ctx.(android.TopDownMutatorContext), apexAvailable)
Liz Kammeraceec252023-03-24 09:46:36 -0400277
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000278 attrs.Features.Append(convertHiddenVisibilityToFeatureStaticOrShared(ctx, module, isStatic))
279
Liz Kammer12615db2021-09-28 09:19:17 -0400280 if !partitionedSrcs[protoSrcPartition].IsEmpty() {
281 // TODO(b/208815215): determine whether this is used and add support if necessary
282 ctx.ModuleErrorf("Migrating static/shared only proto srcs is not currently supported")
283 }
284
Jingwen Chenbcf53042021-05-26 04:42:42 +0000285 return attrs
Jingwen Chen53681ef2021-04-29 08:15:13 +0000286}
287
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400288// Convenience struct to hold all attributes parsed from prebuilt properties.
289type prebuiltAttributes struct {
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000290 Src bazel.LabelAttribute
291 Enabled bazel.BoolAttribute
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400292}
293
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000294func parseSrc(ctx android.BazelConversionPathContext, srcLabelAttribute *bazel.LabelAttribute, axis bazel.ConfigurationAxis, config string, srcs []string) {
295 srcFileError := func() {
296 ctx.ModuleErrorf("parseSrc: Expected at most one source file for %s %s\n", axis, config)
297 }
298 if len(srcs) > 1 {
299 srcFileError()
300 return
301 } else if len(srcs) == 0 {
302 return
303 }
304 if srcLabelAttribute.SelectValue(axis, config) != nil {
305 srcFileError()
306 return
307 }
308 srcLabelAttribute.SetSelectValue(axis, config, android.BazelLabelForModuleSrcSingle(ctx, srcs[0]))
309}
310
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000311// NOTE: Used outside of Soong repo project, in the clangprebuilts.go bootstrap_go_package
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000312func Bp2BuildParsePrebuiltLibraryProps(ctx android.BazelConversionPathContext, module *Module, isStatic bool) prebuiltAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000313
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400314 var srcLabelAttribute bazel.LabelAttribute
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000315 bp2BuildPropParseHelper(ctx, module, &prebuiltLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
316 if prebuiltLinkerProperties, ok := props.(*prebuiltLinkerProperties); ok {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000317 parseSrc(ctx, &srcLabelAttribute, axis, config, prebuiltLinkerProperties.Srcs)
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000318 }
319 })
320
321 var enabledLabelAttribute bazel.BoolAttribute
322 parseAttrs := func(axis bazel.ConfigurationAxis, config string, props StaticOrSharedProperties) {
323 if props.Enabled != nil {
324 enabledLabelAttribute.SetSelectValue(axis, config, props.Enabled)
325 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000326 parseSrc(ctx, &srcLabelAttribute, axis, config, props.Srcs)
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000327 }
328
329 if isStatic {
330 bp2BuildPropParseHelper(ctx, module, &StaticProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
331 if staticProperties, ok := props.(*StaticProperties); ok {
332 parseAttrs(axis, config, staticProperties.Static)
333 }
334 })
335 } else {
336 bp2BuildPropParseHelper(ctx, module, &SharedProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
337 if sharedProperties, ok := props.(*SharedProperties); ok {
338 parseAttrs(axis, config, sharedProperties.Shared)
339 }
340 })
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400341 }
342
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400343 return prebuiltAttributes{
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000344 Src: srcLabelAttribute,
345 Enabled: enabledLabelAttribute,
346 }
347}
348
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000349func bp2BuildParsePrebuiltBinaryProps(ctx android.BazelConversionPathContext, module *Module) prebuiltAttributes {
350 var srcLabelAttribute bazel.LabelAttribute
351 bp2BuildPropParseHelper(ctx, module, &prebuiltLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
352 if props, ok := props.(*prebuiltLinkerProperties); ok {
353 parseSrc(ctx, &srcLabelAttribute, axis, config, props.Srcs)
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000354 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000355 })
356
357 return prebuiltAttributes{
358 Src: srcLabelAttribute,
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400359 }
360}
361
Colin Crossc5075e92022-12-05 16:46:39 -0800362func bp2BuildParsePrebuiltObjectProps(ctx android.BazelConversionPathContext, module *Module) prebuiltAttributes {
363 var srcLabelAttribute bazel.LabelAttribute
364 bp2BuildPropParseHelper(ctx, module, &prebuiltObjectProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
365 if props, ok := props.(*prebuiltObjectProperties); ok {
366 parseSrc(ctx, &srcLabelAttribute, axis, config, props.Srcs)
367 }
368 })
369
370 return prebuiltAttributes{
371 Src: srcLabelAttribute,
372 }
373}
374
Liz Kammere6583482021-10-19 13:56:10 -0400375type baseAttributes struct {
376 compilerAttributes
377 linkerAttributes
Liz Kammer12615db2021-09-28 09:19:17 -0400378
Trevor Radcliffedb7e0262022-10-28 16:48:18 +0000379 // A combination of compilerAttributes.features and linkerAttributes.features, as well as sanitizer features
Cole Faust5fa4e962022-08-22 14:31:04 -0700380 features bazel.StringListAttribute
Liz Kammer12615db2021-09-28 09:19:17 -0400381 protoDependency *bazel.LabelAttribute
Vinh Tran9f6796a2022-08-16 13:10:31 -0400382 aidlDependency *bazel.LabelAttribute
Yu Liuf01a0f02022-12-07 15:45:30 -0800383 Native_coverage *bool
Liz Kammere6583482021-10-19 13:56:10 -0400384}
385
Jingwen Chen107c0de2021-04-09 10:43:12 +0000386// Convenience struct to hold all attributes parsed from compiler properties.
387type compilerAttributes struct {
Chris Parsons990c4f42021-05-25 12:10:58 -0400388 // Options for all languages
389 copts bazel.StringListAttribute
390 // Assembly options and sources
391 asFlags bazel.StringListAttribute
392 asSrcs bazel.LabelListAttribute
Cole Faust7071a052022-07-29 15:58:33 -0700393 asmSrcs bazel.LabelListAttribute
Chris Parsons990c4f42021-05-25 12:10:58 -0400394 // C options and sources
395 conlyFlags bazel.StringListAttribute
396 cSrcs bazel.LabelListAttribute
397 // C++ options and sources
398 cppFlags bazel.StringListAttribute
Jingwen Chened9c17d2021-04-13 07:14:55 +0000399 srcs bazel.LabelListAttribute
Chris Parsons2c788392021-08-10 11:58:07 -0400400
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000401 // Lex sources and options
402 lSrcs bazel.LabelListAttribute
403 llSrcs bazel.LabelListAttribute
404 lexopts bazel.StringListAttribute
405
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000406 // Sysprop sources
407 syspropSrcs bazel.LabelListAttribute
408
Spandan Dasdf4c2132023-05-09 23:58:52 +0000409 // Yacc sources
410 yaccSrc *bazel.LabelAttribute
411 yaccFlags bazel.StringListAttribute
412 yaccGenLocationHeader bazel.BoolAttribute
413 yaccGenPositionHeader bazel.BoolAttribute
414
Liz Kammere6583482021-10-19 13:56:10 -0400415 hdrs bazel.LabelListAttribute
416
Chris Parsons2c788392021-08-10 11:58:07 -0400417 rtti bazel.BoolAttribute
Jingwen Chen5b11ab12021-10-11 17:44:33 +0000418
419 // Not affected by arch variants
420 stl *string
Chris Parsons79bd2b72021-11-29 17:52:41 -0500421 cStd *string
Jingwen Chen5b11ab12021-10-11 17:44:33 +0000422 cppStd *string
Liz Kammer35687bc2021-09-10 10:07:07 -0400423
424 localIncludes bazel.StringListAttribute
425 absoluteIncludes bazel.StringListAttribute
Liz Kammer12615db2021-09-28 09:19:17 -0400426
Liz Kammer1263d9b2021-12-10 14:28:20 -0500427 includes BazelIncludes
428
Liz Kammer12615db2021-09-28 09:19:17 -0400429 protoSrcs bazel.LabelListAttribute
Vinh Tran9f6796a2022-08-16 13:10:31 -0400430 aidlSrcs bazel.LabelListAttribute
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000431
432 stubsSymbolFile *string
433 stubsVersions bazel.StringListAttribute
Cole Faust5fa4e962022-08-22 14:31:04 -0700434
435 features bazel.StringListAttribute
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500436
437 suffix bazel.StringAttribute
Vinh Tran99270ea2022-11-28 11:15:23 -0500438
439 fdoProfile bazel.LabelAttribute
Jingwen Chen107c0de2021-04-09 10:43:12 +0000440}
441
Liz Kammercac7f692021-12-16 14:19:32 -0500442type filterOutFn func(string) bool
443
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000444// filterOutHiddenVisibility removes the flag specifying hidden visibility as
445// this flag is converted to a toolchain feature
446func filterOutHiddenVisibility(flag string) bool {
447 return flag == config.VisibilityHiddenFlag
448}
449
Liz Kammercac7f692021-12-16 14:19:32 -0500450func filterOutStdFlag(flag string) bool {
451 return strings.HasPrefix(flag, "-std=")
452}
453
Alix1be00d42022-05-16 22:56:04 +0000454func filterOutClangUnknownCflags(flag string) bool {
455 for _, f := range config.ClangUnknownCflags {
456 if f == flag {
457 return true
458 }
459 }
460 return false
461}
462
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000463func parseCommandLineFlags(soongFlags []string, filterOut ...filterOutFn) []string {
Liz Kammere6583482021-10-19 13:56:10 -0400464 var result []string
465 for _, flag := range soongFlags {
Alix1be00d42022-05-16 22:56:04 +0000466 skipFlag := false
467 for _, filter := range filterOut {
468 if filter != nil && filter(flag) {
469 skipFlag = true
470 }
471 }
472 if skipFlag {
Liz Kammercac7f692021-12-16 14:19:32 -0500473 continue
474 }
Liz Kammere6583482021-10-19 13:56:10 -0400475 // Soong's cflags can contain spaces, like `-include header.h`. For
476 // Bazel's copts, split them up to be compatible with the
477 // no_copts_tokenization feature.
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000478 result = append(result, strings.Split(flag, " ")...)
Liz Kammere6583482021-10-19 13:56:10 -0400479 }
480 return result
481}
Jingwen Chened9c17d2021-04-13 07:14:55 +0000482
Jingwen Chen55bc8202021-11-02 06:40:51 +0000483func (ca *compilerAttributes) bp2buildForAxisAndConfig(ctx android.BazelConversionPathContext, axis bazel.ConfigurationAxis, config string, props *BaseCompilerProperties) {
Liz Kammere6583482021-10-19 13:56:10 -0400484 // If there's arch specific srcs or exclude_srcs, generate a select entry for it.
485 // TODO(b/186153868): do this for OS specific srcs and exclude_srcs too.
486 if srcsList, ok := parseSrcs(ctx, props); ok {
487 ca.srcs.SetSelectValue(axis, config, srcsList)
Chris Parsons990c4f42021-05-25 12:10:58 -0400488 }
489
Liz Kammere6583482021-10-19 13:56:10 -0400490 localIncludeDirs := props.Local_include_dirs
491 if axis == bazel.NoConfigAxis {
Chris Parsons79bd2b72021-11-29 17:52:41 -0500492 ca.cStd, ca.cppStd = bp2buildResolveCppStdValue(props.C_std, props.Cpp_std, props.Gnu_extensions)
Liz Kammere6583482021-10-19 13:56:10 -0400493 if includeBuildDirectory(props.Include_build_directory) {
494 localIncludeDirs = append(localIncludeDirs, ".")
Liz Kammer222bdcf2021-10-11 14:15:51 -0400495 }
Jingwen Chene32e9e02021-04-23 09:17:24 +0000496 }
497
Liz Kammere6583482021-10-19 13:56:10 -0400498 ca.absoluteIncludes.SetSelectValue(axis, config, props.Include_dirs)
499 ca.localIncludes.SetSelectValue(axis, config, localIncludeDirs)
500
Cole Faust5fa4e962022-08-22 14:31:04 -0700501 instructionSet := proptools.StringDefault(props.Instruction_set, "")
502 if instructionSet == "arm" {
Trevor Radcliffe5f0c2ac2023-05-15 18:00:59 +0000503 ca.features.SetSelectValue(axis, config, []string{"arm_isa_arm"})
Cole Faust5fa4e962022-08-22 14:31:04 -0700504 } else if instructionSet != "" && instructionSet != "thumb" {
505 ctx.ModuleErrorf("Unknown value for instruction_set: %s", instructionSet)
506 }
507
Liz Kammercac7f692021-12-16 14:19:32 -0500508 // In Soong, cflags occur on the command line before -std=<val> flag, resulting in the value being
509 // overridden. In Bazel we always allow overriding, via flags; however, this can cause
510 // incompatibilities, so we remove "-std=" flags from Cflag properties while leaving it in other
511 // cases.
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000512 ca.copts.SetSelectValue(axis, config, parseCommandLineFlags(props.Cflags, filterOutStdFlag, filterOutClangUnknownCflags, filterOutHiddenVisibility))
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000513 ca.asFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Asflags, nil))
514 ca.conlyFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Conlyflags, filterOutClangUnknownCflags))
515 ca.cppFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Cppflags, filterOutClangUnknownCflags))
Liz Kammere6583482021-10-19 13:56:10 -0400516 ca.rtti.SetSelectValue(axis, config, props.Rtti)
517}
518
Jingwen Chen55bc8202021-11-02 06:40:51 +0000519func (ca *compilerAttributes) convertStlProps(ctx android.ArchVariantContext, module *Module) {
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000520 bp2BuildPropParseHelper(ctx, module, &StlProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
521 if stlProps, ok := props.(*StlProperties); ok {
522 if stlProps.Stl == nil {
523 return
524 }
525 if ca.stl == nil {
Liz Kammer7128d382022-05-12 11:42:33 -0400526 stl := deduplicateStlInput(*stlProps.Stl)
527 ca.stl = &stl
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000528 } else if ca.stl != stlProps.Stl {
529 ctx.ModuleErrorf("Unsupported conversion: module with different stl for different variants: %s and %s", *ca.stl, stlProps.Stl)
Liz Kammer9abd62d2021-05-21 08:37:59 -0400530 }
Jingwen Chenc1c26502021-04-05 10:35:13 +0000531 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000532 })
Liz Kammere6583482021-10-19 13:56:10 -0400533}
Jingwen Chenc1c26502021-04-05 10:35:13 +0000534
Jingwen Chen55bc8202021-11-02 06:40:51 +0000535func (ca *compilerAttributes) convertProductVariables(ctx android.BazelConversionPathContext, productVariableProps android.ProductConfigProperties) {
Liz Kammerba7a9c52021-05-26 08:45:30 -0400536 productVarPropNameToAttribute := map[string]*bazel.StringListAttribute{
Liz Kammere6583482021-10-19 13:56:10 -0400537 "Cflags": &ca.copts,
538 "Asflags": &ca.asFlags,
Yu Liu93893ba2023-05-01 13:49:52 -0700539 "Cppflags": &ca.cppFlags,
Liz Kammerba7a9c52021-05-26 08:45:30 -0400540 }
Liz Kammerba7a9c52021-05-26 08:45:30 -0400541 for propName, attr := range productVarPropNameToAttribute {
Jingwen Chen25825ca2021-11-15 12:28:43 +0000542 if productConfigProps, exists := productVariableProps[propName]; exists {
543 for productConfigProp, prop := range productConfigProps {
544 flags, ok := prop.([]string)
Liz Kammerba7a9c52021-05-26 08:45:30 -0400545 if !ok {
546 ctx.ModuleErrorf("Could not convert product variable %s property", proptools.PropertyNameForField(propName))
547 }
Cole Faust150f9a52023-04-26 10:52:24 -0700548 newFlags, _ := bazel.TryVariableSubstitutions(flags, productConfigProp.Name())
Jingwen Chen25825ca2021-11-15 12:28:43 +0000549 attr.SetSelectValue(productConfigProp.ConfigurationAxis(), productConfigProp.SelectKey(), newFlags)
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400550 }
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400551 }
552 }
Liz Kammere6583482021-10-19 13:56:10 -0400553}
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400554
Jingwen Chen55bc8202021-11-02 06:40:51 +0000555func (ca *compilerAttributes) finalize(ctx android.BazelConversionPathContext, implementationHdrs bazel.LabelListAttribute) {
Liz Kammere6583482021-10-19 13:56:10 -0400556 ca.srcs.ResolveExcludes()
557 partitionedSrcs := groupSrcsByExtension(ctx, ca.srcs)
558
Liz Kammer12615db2021-09-28 09:19:17 -0400559 ca.protoSrcs = partitionedSrcs[protoSrcPartition]
Vinh Tran9f6796a2022-08-16 13:10:31 -0400560 ca.aidlSrcs = partitionedSrcs[aidlSrcPartition]
Liz Kammer12615db2021-09-28 09:19:17 -0400561
Liz Kammere6583482021-10-19 13:56:10 -0400562 for p, lla := range partitionedSrcs {
563 // if there are no sources, there is no need for headers
564 if lla.IsEmpty() {
565 continue
566 }
567 lla.Append(implementationHdrs)
568 partitionedSrcs[p] = lla
569 }
570
571 ca.srcs = partitionedSrcs[cppSrcPartition]
572 ca.cSrcs = partitionedSrcs[cSrcPartition]
573 ca.asSrcs = partitionedSrcs[asSrcPartition]
Cole Faust7071a052022-07-29 15:58:33 -0700574 ca.asmSrcs = partitionedSrcs[asmSrcPartition]
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000575 ca.lSrcs = partitionedSrcs[lSrcPartition]
576 ca.llSrcs = partitionedSrcs[llSrcPartition]
Spandan Dasdf4c2132023-05-09 23:58:52 +0000577 if yacc := partitionedSrcs[yaccSrcPartition]; !yacc.IsEmpty() {
578 if len(yacc.Value.Includes) > 1 {
579 ctx.PropertyErrorf("srcs", "Found multiple yacc (.y/.yy) files in library")
580 }
581 ca.yaccSrc = bazel.MakeLabelAttribute(yacc.Value.Includes[0].Label)
582 }
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000583 ca.syspropSrcs = partitionedSrcs[syspropSrcPartition]
Liz Kammere6583482021-10-19 13:56:10 -0400584
585 ca.absoluteIncludes.DeduplicateAxesFromBase()
586 ca.localIncludes.DeduplicateAxesFromBase()
587}
588
589// Parse srcs from an arch or OS's props value.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000590func parseSrcs(ctx android.BazelConversionPathContext, props *BaseCompilerProperties) (bazel.LabelList, bool) {
Liz Kammere6583482021-10-19 13:56:10 -0400591 anySrcs := false
592 // Add srcs-like dependencies such as generated files.
593 // First create a LabelList containing these dependencies, then merge the values with srcs.
Spandan Das922171d2023-05-31 23:32:40 +0000594 genSrcs, _ := android.PartitionXsdSrcs(ctx, props.Generated_sources)
595 generatedSrcsLabelList := android.BazelLabelForModuleDepsExcludes(ctx, genSrcs, props.Exclude_generated_sources)
Liz Kammere6583482021-10-19 13:56:10 -0400596 if len(props.Generated_sources) > 0 || len(props.Exclude_generated_sources) > 0 {
597 anySrcs = true
598 }
599
600 allSrcsLabelList := android.BazelLabelForModuleSrcExcludes(ctx, props.Srcs, props.Exclude_srcs)
Vinh Tran9f6796a2022-08-16 13:10:31 -0400601
Liz Kammere6583482021-10-19 13:56:10 -0400602 if len(props.Srcs) > 0 || len(props.Exclude_srcs) > 0 {
603 anySrcs = true
604 }
Vinh Tran9f6796a2022-08-16 13:10:31 -0400605
Liz Kammere6583482021-10-19 13:56:10 -0400606 return bazel.AppendBazelLabelLists(allSrcsLabelList, generatedSrcsLabelList), anySrcs
607}
608
Liz Kammera5a29de2022-05-25 23:19:37 -0400609func bp2buildStdVal(std *string, prefix string, useGnu bool) *string {
610 defaultVal := prefix + "_std_default"
Chris Parsons79bd2b72021-11-29 17:52:41 -0500611 // If c{,pp}std properties are not specified, don't generate them in the BUILD file.
612 // Defaults are handled by the toolchain definition.
613 // However, if gnu_extensions is false, then the default gnu-to-c version must be specified.
Liz Kammera5a29de2022-05-25 23:19:37 -0400614 stdVal := proptools.StringDefault(std, defaultVal)
615 if stdVal == "experimental" || stdVal == defaultVal {
616 if stdVal == "experimental" {
617 stdVal = prefix + "_std_experimental"
618 }
619 if !useGnu {
620 stdVal += "_no_gnu"
621 }
622 } else if !useGnu {
623 stdVal = gnuToCReplacer.Replace(stdVal)
Chris Parsons79bd2b72021-11-29 17:52:41 -0500624 }
625
Liz Kammera5a29de2022-05-25 23:19:37 -0400626 if stdVal == defaultVal {
627 return nil
Liz Kammer46fb7ab2021-12-01 10:09:34 -0500628 }
Liz Kammera5a29de2022-05-25 23:19:37 -0400629 return &stdVal
630}
Liz Kammer46fb7ab2021-12-01 10:09:34 -0500631
Liz Kammera5a29de2022-05-25 23:19:37 -0400632func bp2buildResolveCppStdValue(c_std *string, cpp_std *string, gnu_extensions *bool) (*string, *string) {
633 useGnu := useGnuExtensions(gnu_extensions)
634
635 return bp2buildStdVal(c_std, "c", useGnu), bp2buildStdVal(cpp_std, "cpp", useGnu)
Liz Kammere6583482021-10-19 13:56:10 -0400636}
637
Liz Kammer1263d9b2021-12-10 14:28:20 -0500638// packageFromLabel extracts package from a fully-qualified or relative Label and whether the label
639// is fully-qualified.
640// e.g. fully-qualified "//a/b:foo" -> "a/b", true, relative: ":bar" -> ".", false
641func packageFromLabel(label string) (string, bool) {
642 split := strings.Split(label, ":")
643 if len(split) != 2 {
644 return "", false
645 }
646 if split[0] == "" {
647 return ".", false
648 }
649 // remove leading "//"
650 return split[0][2:], true
651}
652
653// includesFromLabelList extracts relative/absolute includes from a bazel.LabelList>
654func includesFromLabelList(labelList bazel.LabelList) (relative, absolute []string) {
655 for _, hdr := range labelList.Includes {
656 if pkg, hasPkg := packageFromLabel(hdr.Label); hasPkg {
657 absolute = append(absolute, pkg)
658 } else if pkg != "" {
659 relative = append(relative, pkg)
660 }
661 }
662 return relative, absolute
663}
664
Cole Faust7071a052022-07-29 15:58:33 -0700665type YasmAttributes struct {
666 Srcs bazel.LabelListAttribute
667 Flags bazel.StringListAttribute
668 Include_dirs bazel.StringListAttribute
669}
670
671func bp2BuildYasm(ctx android.Bp2buildMutatorContext, m *Module, ca compilerAttributes) *bazel.LabelAttribute {
672 if ca.asmSrcs.IsEmpty() {
673 return nil
674 }
675
676 // Yasm needs the include directories from both local_includes and
677 // export_include_dirs. We don't care about actually exporting them from the
678 // yasm rule though, because they will also be present on the cc_ rule that
679 // wraps this yasm rule.
680 includes := ca.localIncludes.Clone()
681 bp2BuildPropParseHelper(ctx, m, &FlagExporterProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
682 if flagExporterProperties, ok := props.(*FlagExporterProperties); ok {
683 if len(flagExporterProperties.Export_include_dirs) > 0 {
684 x := bazel.StringListAttribute{}
685 x.SetSelectValue(axis, config, flagExporterProperties.Export_include_dirs)
686 includes.Append(x)
687 }
688 }
689 })
690
691 ctx.CreateBazelTargetModule(
692 bazel.BazelTargetModuleProperties{
693 Rule_class: "yasm",
694 Bzl_load_location: "//build/bazel/rules/cc:yasm.bzl",
695 },
696 android.CommonAttributes{Name: m.Name() + "_yasm"},
697 &YasmAttributes{
698 Srcs: ca.asmSrcs,
699 Flags: ca.asFlags,
700 Include_dirs: *includes,
701 })
702
703 // We only want to add a dependency on the _yasm target if there are asm
704 // sources in the current configuration. If there are unconfigured asm
705 // sources, always add the dependency. Otherwise, add the dependency only
706 // on the configuration axes and values that had asm sources.
707 if len(ca.asmSrcs.Value.Includes) > 0 {
708 return bazel.MakeLabelAttribute(":" + m.Name() + "_yasm")
709 }
710
711 ret := &bazel.LabelAttribute{}
712 for _, axis := range ca.asmSrcs.SortedConfigurationAxes() {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800713 for cfg := range ca.asmSrcs.ConfigurableValues[axis] {
714 ret.SetSelectValue(axis, cfg, bazel.Label{Label: ":" + m.Name() + "_yasm"})
Cole Faust7071a052022-07-29 15:58:33 -0700715 }
716 }
717 return ret
718}
719
Spandan Das922171d2023-05-31 23:32:40 +0000720// Replaces //a/b/my_xsd_config with //a/b/my_xsd_config-cpp
721func xsdConfigCppTarget(ctx android.BazelConversionPathContext, mod blueprint.Module) string {
722 callback := func(xsd android.XsdConfigBp2buildTargets) string {
723 return xsd.CppBp2buildTargetName()
724 }
725 return android.XsdConfigBp2buildTarget(ctx, mod, callback)
726}
727
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000728// bp2BuildParseBaseProps returns all compiler, linker, library attributes of a cc module..
Liz Kammer12615db2021-09-28 09:19:17 -0400729func bp2BuildParseBaseProps(ctx android.Bp2buildMutatorContext, module *Module) baseAttributes {
Liz Kammere6583482021-10-19 13:56:10 -0400730 archVariantCompilerProps := module.GetArchVariantProperties(ctx, &BaseCompilerProperties{})
731 archVariantLinkerProps := module.GetArchVariantProperties(ctx, &BaseLinkerProperties{})
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000732 archVariantLibraryProperties := module.GetArchVariantProperties(ctx, &LibraryProperties{})
Liz Kammere6583482021-10-19 13:56:10 -0400733
734 var implementationHdrs bazel.LabelListAttribute
735
736 axisToConfigs := map[bazel.ConfigurationAxis]map[string]bool{}
737 allAxesAndConfigs := func(cp android.ConfigurationAxisToArchVariantProperties) {
738 for axis, configMap := range cp {
739 if _, ok := axisToConfigs[axis]; !ok {
740 axisToConfigs[axis] = map[string]bool{}
741 }
Sasha Smundak39a301c2022-12-29 17:11:49 -0800742 for cfg := range configMap {
743 axisToConfigs[axis][cfg] = true
Chris Parsonsa967f252021-09-23 16:34:35 -0400744 }
745 }
746 }
Liz Kammere6583482021-10-19 13:56:10 -0400747 allAxesAndConfigs(archVariantCompilerProps)
748 allAxesAndConfigs(archVariantLinkerProps)
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000749 allAxesAndConfigs(archVariantLibraryProperties)
Chris Parsonsa967f252021-09-23 16:34:35 -0400750
Liz Kammere6583482021-10-19 13:56:10 -0400751 compilerAttrs := compilerAttributes{}
752 linkerAttrs := linkerAttributes{}
753
Vinh Tran367d89d2023-04-28 11:21:25 -0400754 var aidlLibs bazel.LabelList
755
Chris Parsons7b3289b2023-01-26 17:30:44 -0500756 // Iterate through these axes in a deterministic order. This is required
757 // because processing certain dependencies may result in concatenating
758 // elements along other axes. (For example, processing NoConfig may result
759 // in elements being added to InApex). This is thus the only way to ensure
760 // that the order of entries in each list is in a predictable order.
761 for _, axis := range bazel.SortedConfigurationAxes(axisToConfigs) {
762 configs := axisToConfigs[axis]
Sasha Smundak39a301c2022-12-29 17:11:49 -0800763 for cfg := range configs {
Liz Kammere6583482021-10-19 13:56:10 -0400764 var allHdrs []string
Sasha Smundak39a301c2022-12-29 17:11:49 -0800765 if baseCompilerProps, ok := archVariantCompilerProps[axis][cfg].(*BaseCompilerProperties); ok {
Spandan Das922171d2023-05-31 23:32:40 +0000766 ah, allHdrsXsd := android.PartitionXsdSrcs(ctx, baseCompilerProps.Generated_headers)
767 allHdrs = ah
768 // in the synthetic bp2build workspace, xsd sources are compiled to a static library
769 xsdCppConfigLibraryLabels := android.BazelLabelForModuleDepsWithFn(ctx, allHdrsXsd, xsdConfigCppTarget)
770 iwad := linkerAttrs.implementationWholeArchiveDeps.SelectValue(axis, cfg)
771 (&iwad).Append(xsdCppConfigLibraryLabels)
772 linkerAttrs.implementationWholeArchiveDeps.SetSelectValue(axis, cfg, bazel.FirstUniqueBazelLabelList(iwad))
773
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000774 if baseCompilerProps.Lex != nil {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800775 compilerAttrs.lexopts.SetSelectValue(axis, cfg, baseCompilerProps.Lex.Flags)
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000776 }
Spandan Dasdf4c2132023-05-09 23:58:52 +0000777 if baseCompilerProps.Yacc != nil {
778 compilerAttrs.yaccFlags.SetSelectValue(axis, cfg, baseCompilerProps.Yacc.Flags)
779 compilerAttrs.yaccGenLocationHeader.SetSelectValue(axis, cfg, baseCompilerProps.Yacc.Gen_location_hh)
780 compilerAttrs.yaccGenPositionHeader.SetSelectValue(axis, cfg, baseCompilerProps.Yacc.Gen_position_hh)
781 }
Sasha Smundak39a301c2022-12-29 17:11:49 -0800782 (&compilerAttrs).bp2buildForAxisAndConfig(ctx, axis, cfg, baseCompilerProps)
Vinh Tran367d89d2023-04-28 11:21:25 -0400783 aidlLibs.Append(android.BazelLabelForModuleDeps(ctx, baseCompilerProps.Aidl.Libs))
Liz Kammere6583482021-10-19 13:56:10 -0400784 }
785
786 var exportHdrs []string
787
Sasha Smundak39a301c2022-12-29 17:11:49 -0800788 if baseLinkerProps, ok := archVariantLinkerProps[axis][cfg].(*BaseLinkerProperties); ok {
Liz Kammere6583482021-10-19 13:56:10 -0400789 exportHdrs = baseLinkerProps.Export_generated_headers
790
Liz Kammer48cdbeb2023-03-17 10:17:50 -0400791 (&linkerAttrs).bp2buildForAxisAndConfig(ctx, module, axis, cfg, baseLinkerProps)
Liz Kammere6583482021-10-19 13:56:10 -0400792 }
793 headers := maybePartitionExportedAndImplementationsDeps(ctx, !module.Binary(), allHdrs, exportHdrs, android.BazelLabelForModuleDeps)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800794 implementationHdrs.SetSelectValue(axis, cfg, headers.implementation)
795 compilerAttrs.hdrs.SetSelectValue(axis, cfg, headers.export)
Liz Kammer1263d9b2021-12-10 14:28:20 -0500796
797 exportIncludes, exportAbsoluteIncludes := includesFromLabelList(headers.export)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800798 compilerAttrs.includes.Includes.SetSelectValue(axis, cfg, exportIncludes)
799 compilerAttrs.includes.AbsoluteIncludes.SetSelectValue(axis, cfg, exportAbsoluteIncludes)
Liz Kammer1263d9b2021-12-10 14:28:20 -0500800
801 includes, absoluteIncludes := includesFromLabelList(headers.implementation)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800802 currAbsoluteIncludes := compilerAttrs.absoluteIncludes.SelectValue(axis, cfg)
Liz Kammer1263d9b2021-12-10 14:28:20 -0500803 currAbsoluteIncludes = android.FirstUniqueStrings(append(currAbsoluteIncludes, absoluteIncludes...))
Vinh Tran9f6796a2022-08-16 13:10:31 -0400804
Sasha Smundak39a301c2022-12-29 17:11:49 -0800805 compilerAttrs.absoluteIncludes.SetSelectValue(axis, cfg, currAbsoluteIncludes)
Vinh Tran9f6796a2022-08-16 13:10:31 -0400806
Sasha Smundak39a301c2022-12-29 17:11:49 -0800807 currIncludes := compilerAttrs.localIncludes.SelectValue(axis, cfg)
Liz Kammer1263d9b2021-12-10 14:28:20 -0500808 currIncludes = android.FirstUniqueStrings(append(currIncludes, includes...))
Vinh Tran9f6796a2022-08-16 13:10:31 -0400809
Sasha Smundak39a301c2022-12-29 17:11:49 -0800810 compilerAttrs.localIncludes.SetSelectValue(axis, cfg, currIncludes)
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000811
Sasha Smundak39a301c2022-12-29 17:11:49 -0800812 if libraryProps, ok := archVariantLibraryProperties[axis][cfg].(*LibraryProperties); ok {
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000813 if axis == bazel.NoConfigAxis {
Sam Delmerico75dbca22023-04-20 13:13:25 +0000814 if libraryProps.Stubs.Symbol_file != nil {
815 compilerAttrs.stubsSymbolFile = libraryProps.Stubs.Symbol_file
816 versions := android.CopyOf(libraryProps.Stubs.Versions)
817 normalizeVersions(ctx, versions)
818 versions = addCurrentVersionIfNotPresent(versions)
819 compilerAttrs.stubsVersions.SetSelectValue(axis, cfg, versions)
820 }
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000821 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500822 if suffix := libraryProps.Suffix; suffix != nil {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800823 compilerAttrs.suffix.SetSelectValue(axis, cfg, suffix)
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500824 }
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000825 }
Liz Kammere6583482021-10-19 13:56:10 -0400826 }
827 }
Vinh Tran9f6796a2022-08-16 13:10:31 -0400828
Liz Kammere6583482021-10-19 13:56:10 -0400829 compilerAttrs.convertStlProps(ctx, module)
830 (&linkerAttrs).convertStripProps(ctx, module)
831
Yu Liuf01a0f02022-12-07 15:45:30 -0800832 var nativeCoverage *bool
Yu Liu8d82ac52022-05-17 15:13:28 -0700833 if module.coverage != nil && module.coverage.Properties.Native_coverage != nil &&
834 !Bool(module.coverage.Properties.Native_coverage) {
Yu Liuf01a0f02022-12-07 15:45:30 -0800835 nativeCoverage = BoolPtr(false)
Yu Liu8d82ac52022-05-17 15:13:28 -0700836 }
837
Cole Faust912bc882023-03-08 12:29:50 -0800838 productVariableProps := android.ProductVariableProperties(ctx, ctx.Module())
Liz Kammere6583482021-10-19 13:56:10 -0400839
840 (&compilerAttrs).convertProductVariables(ctx, productVariableProps)
841 (&linkerAttrs).convertProductVariables(ctx, productVariableProps)
842
843 (&compilerAttrs).finalize(ctx, implementationHdrs)
Liz Kammer54309532021-12-14 12:21:22 -0500844 (&linkerAttrs).finalize(ctx)
Liz Kammere6583482021-10-19 13:56:10 -0400845
Cole Faust7071a052022-07-29 15:58:33 -0700846 (&compilerAttrs.srcs).Add(bp2BuildYasm(ctx, module, compilerAttrs))
847
Liz Kammer12615db2021-09-28 09:19:17 -0400848 protoDep := bp2buildProto(ctx, module, compilerAttrs.protoSrcs)
849
850 // bp2buildProto will only set wholeStaticLib or implementationWholeStaticLib, but we don't know
851 // which. This will add the newly generated proto library to the appropriate attribute and nothing
852 // to the other
853 (&linkerAttrs).wholeArchiveDeps.Add(protoDep.wholeStaticLib)
854 (&linkerAttrs).implementationWholeArchiveDeps.Add(protoDep.implementationWholeStaticLib)
Vinh Tranfde57eb2022-08-29 17:46:58 -0400855
Vinh Tran367d89d2023-04-28 11:21:25 -0400856 aidlDep := bp2buildCcAidlLibrary(
857 ctx, module,
858 compilerAttrs.aidlSrcs,
859 bazel.LabelListAttribute{
860 Value: aidlLibs,
861 },
862 linkerAttrs,
Vinh Trane6842942023-04-28 11:21:25 -0400863 compilerAttrs,
Vinh Tran367d89d2023-04-28 11:21:25 -0400864 )
Vinh Tranfde57eb2022-08-29 17:46:58 -0400865 if aidlDep != nil {
866 if lib, ok := module.linker.(*libraryDecorator); ok {
867 if proptools.Bool(lib.Properties.Aidl.Export_aidl_headers) {
868 (&linkerAttrs).wholeArchiveDeps.Add(aidlDep)
869 } else {
870 (&linkerAttrs).implementationWholeArchiveDeps.Add(aidlDep)
871 }
872 }
873 }
Liz Kammer12615db2021-09-28 09:19:17 -0400874
Spandan Dasdf4c2132023-05-09 23:58:52 +0000875 // Create a cc_yacc_static_library if srcs contains .y/.yy files
876 // This internal target will produce an .a file that will be statically linked to the parent library
877 if yaccDep := bp2buildCcYaccLibrary(ctx, compilerAttrs, linkerAttrs); yaccDep != nil {
878 (&linkerAttrs).implementationWholeArchiveDeps.Add(yaccDep)
879 }
880
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000881 convertedLSrcs := bp2BuildLex(ctx, module.Name(), compilerAttrs)
882 (&compilerAttrs).srcs.Add(&convertedLSrcs.srcName)
883 (&compilerAttrs).cSrcs.Add(&convertedLSrcs.cSrcName)
884
Vinh Tran99270ea2022-11-28 11:15:23 -0500885 if module.afdo != nil && module.afdo.Properties.Afdo {
886 fdoProfileDep := bp2buildFdoProfile(ctx, module)
887 if fdoProfileDep != nil {
888 (&compilerAttrs).fdoProfile.SetValue(*fdoProfileDep)
889 }
890 }
891
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000892 if !compilerAttrs.syspropSrcs.IsEmpty() {
893 (&linkerAttrs).wholeArchiveDeps.Add(bp2buildCcSysprop(ctx, module.Name(), module.Properties.Min_sdk_version, compilerAttrs.syspropSrcs))
894 }
895
Zi Wang9f609db2023-01-04 11:06:54 -0800896 linkerAttrs.wholeArchiveDeps.Prepend = true
897 linkerAttrs.deps.Prepend = true
898 compilerAttrs.localIncludes.Prepend = true
899 compilerAttrs.absoluteIncludes.Prepend = true
900 compilerAttrs.hdrs.Prepend = true
901
Trevor Radcliffedb7e0262022-10-28 16:48:18 +0000902 features := compilerAttrs.features.Clone().Append(linkerAttrs.features).Append(bp2buildSanitizerFeatures(ctx, module))
Trevor Radcliffe56b1a2b2023-02-06 21:58:30 +0000903 features = features.Append(bp2buildLtoFeatures(ctx, module))
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000904 features = features.Append(convertHiddenVisibilityToFeatureBase(ctx, module))
Cole Faust5fa4e962022-08-22 14:31:04 -0700905 features.DeduplicateAxesFromBase()
906
Trevor Radcliffe0d1b4022022-12-12 22:26:34 +0000907 addMuslSystemDynamicDeps(ctx, linkerAttrs)
908
Liz Kammere6583482021-10-19 13:56:10 -0400909 return baseAttributes{
910 compilerAttrs,
911 linkerAttrs,
Cole Faust5fa4e962022-08-22 14:31:04 -0700912 *features,
Liz Kammer12615db2021-09-28 09:19:17 -0400913 protoDep.protoDep,
Vinh Tran9f6796a2022-08-16 13:10:31 -0400914 aidlDep,
Yu Liuf01a0f02022-12-07 15:45:30 -0800915 nativeCoverage,
Jingwen Chen107c0de2021-04-09 10:43:12 +0000916 }
917}
918
Spandan Dasdf4c2132023-05-09 23:58:52 +0000919type ccYaccLibraryAttributes struct {
920 Src bazel.LabelAttribute
921 Flags bazel.StringListAttribute
922 Gen_location_hh bazel.BoolAttribute
923 Gen_position_hh bazel.BoolAttribute
924 Local_includes bazel.StringListAttribute
925 Implementation_deps bazel.LabelListAttribute
926 Implementation_dynamic_deps bazel.LabelListAttribute
927}
928
929func bp2buildCcYaccLibrary(ctx android.Bp2buildMutatorContext, ca compilerAttributes, la linkerAttributes) *bazel.LabelAttribute {
930 if ca.yaccSrc == nil {
931 return nil
932 }
933 yaccLibraryLabel := ctx.Module().Name() + "_yacc"
934 ctx.CreateBazelTargetModule(
935 bazel.BazelTargetModuleProperties{
936 Rule_class: "cc_yacc_static_library",
937 Bzl_load_location: "//build/bazel/rules/cc:cc_yacc_library.bzl",
938 },
939 android.CommonAttributes{
940 Name: yaccLibraryLabel,
941 },
942 &ccYaccLibraryAttributes{
943 Src: *ca.yaccSrc,
944 Flags: ca.yaccFlags,
945 Gen_location_hh: ca.yaccGenLocationHeader,
946 Gen_position_hh: ca.yaccGenPositionHeader,
947 Local_includes: ca.localIncludes,
948 Implementation_deps: la.implementationDeps,
949 Implementation_dynamic_deps: la.implementationDynamicDeps,
950 },
951 )
952
953 yaccLibrary := &bazel.LabelAttribute{
954 Value: &bazel.Label{
955 Label: ":" + yaccLibraryLabel,
956 },
957 }
958 return yaccLibrary
959}
960
Trevor Radcliffe0d1b4022022-12-12 22:26:34 +0000961// As a workaround for b/261657184, we are manually adding the default value
962// of system_dynamic_deps for the linux_musl os.
963// TODO: Solve this properly
964func addMuslSystemDynamicDeps(ctx android.Bp2buildMutatorContext, attrs linkerAttributes) {
965 systemDynamicDeps := attrs.systemDynamicDeps.SelectValue(bazel.OsConfigurationAxis, "linux_musl")
966 if attrs.systemDynamicDeps.HasAxisSpecificValues(bazel.OsConfigurationAxis) && systemDynamicDeps.IsNil() {
967 attrs.systemDynamicDeps.SetSelectValue(bazel.OsConfigurationAxis, "linux_musl", android.BazelLabelForModuleDeps(ctx, config.MuslDefaultSharedLibraries))
968 }
969}
970
Vinh Tran99270ea2022-11-28 11:15:23 -0500971type fdoProfileAttributes struct {
972 Absolute_path_profile string
973}
974
975func bp2buildFdoProfile(
976 ctx android.Bp2buildMutatorContext,
977 m *Module,
978) *bazel.Label {
979 for _, project := range globalAfdoProfileProjects {
Vinh Tranbc9c8b42022-12-09 12:03:52 -0500980 // Ensure handcrafted BUILD file exists in the project
981 BUILDPath := android.ExistentPathForSource(ctx, project, "BUILD")
982 if BUILDPath.Valid() {
983 // We handcraft a BUILD file with fdo_profile targets that use the existing profiles in the project
984 // This implementation is assuming that every afdo profile in globalAfdoProfileProjects already has
985 // an associated fdo_profile target declared in the same package.
986 // TODO(b/260714900): Handle arch-specific afdo profiles (e.g. `<module-name>-arm<64>.afdo`)
987 path := android.ExistentPathForSource(ctx, project, m.Name()+".afdo")
988 if path.Valid() {
989 // FIXME: Some profiles only exist internally and are not released to AOSP.
990 // When generated BUILD files are checked in, we'll run into merge conflict.
991 // The cc_library_shared target in AOSP won't have reference to an fdo_profile target because
992 // the profile doesn't exist. Internally, the same cc_library_shared target will
993 // have reference to the fdo_profile.
994 // For more context, see b/258682955#comment2
995 fdoProfileLabel := "//" + strings.TrimSuffix(project, "/") + ":" + m.Name()
996 return &bazel.Label{
997 Label: fdoProfileLabel,
998 }
Vinh Tran99270ea2022-11-28 11:15:23 -0500999 }
1000 }
1001 }
1002
1003 return nil
1004}
1005
Vinh Tran9f6796a2022-08-16 13:10:31 -04001006func bp2buildCcAidlLibrary(
1007 ctx android.Bp2buildMutatorContext,
1008 m *Module,
Vinh Tran367d89d2023-04-28 11:21:25 -04001009 aidlSrcs bazel.LabelListAttribute,
1010 aidlLibs bazel.LabelListAttribute,
Vinh Tran395a1e92022-09-16 18:27:29 -04001011 linkerAttrs linkerAttributes,
Vinh Trane6842942023-04-28 11:21:25 -04001012 compilerAttrs compilerAttributes,
Vinh Tran9f6796a2022-08-16 13:10:31 -04001013) *bazel.LabelAttribute {
Vinh Tran367d89d2023-04-28 11:21:25 -04001014 var aidlLibsFromSrcs, aidlFiles bazel.LabelListAttribute
1015 apexAvailableTags := android.ApexAvailableTagsWithoutTestApexes(ctx.(android.TopDownMutatorContext), ctx.Module())
1016
1017 if !aidlSrcs.IsEmpty() {
1018 aidlLibsFromSrcs, aidlFiles = aidlSrcs.Partition(func(src bazel.Label) bool {
Vinh Trana3b8b782022-09-14 11:40:24 -04001019 if fg, ok := android.ToFileGroupAsLibrary(ctx, src.OriginalModuleName); ok &&
1020 fg.ShouldConvertToAidlLibrary(ctx) {
1021 return true
1022 }
1023 return false
1024 })
Vinh Tran9f6796a2022-08-16 13:10:31 -04001025
Vinh Tran367d89d2023-04-28 11:21:25 -04001026 if !aidlFiles.IsEmpty() {
Vinh Trana3b8b782022-09-14 11:40:24 -04001027 aidlLibName := m.Name() + "_aidl_library"
1028 ctx.CreateBazelTargetModule(
1029 bazel.BazelTargetModuleProperties{
1030 Rule_class: "aidl_library",
Sam Delmericoe55bf082023-03-31 09:47:28 -04001031 Bzl_load_location: "//build/bazel/rules/aidl:aidl_library.bzl",
Vinh Trana3b8b782022-09-14 11:40:24 -04001032 },
Vinh Tran367d89d2023-04-28 11:21:25 -04001033 android.CommonAttributes{
1034 Name: aidlLibName,
Liz Kammer2b3f56e2023-03-23 11:51:49 -04001035 Tags: apexAvailableTags,
Vinh Trana3b8b782022-09-14 11:40:24 -04001036 },
Vinh Tran367d89d2023-04-28 11:21:25 -04001037 &aidlLibraryAttributes{
1038 Srcs: aidlFiles,
Vinh Trana3b8b782022-09-14 11:40:24 -04001039 },
1040 )
Vinh Tran367d89d2023-04-28 11:21:25 -04001041 aidlLibsFromSrcs.Add(&bazel.LabelAttribute{Value: &bazel.Label{Label: ":" + aidlLibName}})
Vinh Trana3b8b782022-09-14 11:40:24 -04001042 }
Vinh Tran9f6796a2022-08-16 13:10:31 -04001043 }
1044
Vinh Tran367d89d2023-04-28 11:21:25 -04001045 allAidlLibs := aidlLibs.Clone()
1046 allAidlLibs.Append(aidlLibsFromSrcs)
1047
1048 if !allAidlLibs.IsEmpty() {
1049 ccAidlLibrarylabel := m.Name() + "_cc_aidl_library"
1050 // Since parent cc_library already has these dependencies, we can add them as implementation
1051 // deps so that they don't re-export
1052 implementationDeps := linkerAttrs.deps.Clone()
1053 implementationDeps.Append(linkerAttrs.implementationDeps)
1054 implementationDynamicDeps := linkerAttrs.dynamicDeps.Clone()
1055 implementationDynamicDeps.Append(linkerAttrs.implementationDynamicDeps)
1056
1057 sdkAttrs := bp2BuildParseSdkAttributes(m)
1058
Vinh Trane6842942023-04-28 11:21:25 -04001059 exportedIncludes := bp2BuildParseExportedIncludes(ctx, m, &compilerAttrs.includes)
1060 includeAttrs := includesAttributes{
1061 Export_includes: exportedIncludes.Includes,
1062 Export_absolute_includes: exportedIncludes.AbsoluteIncludes,
1063 Export_system_includes: exportedIncludes.SystemIncludes,
1064 Local_includes: compilerAttrs.localIncludes,
1065 Absolute_includes: compilerAttrs.absoluteIncludes,
1066 }
1067
Vinh Tran367d89d2023-04-28 11:21:25 -04001068 ctx.CreateBazelTargetModule(
1069 bazel.BazelTargetModuleProperties{
1070 Rule_class: "cc_aidl_library",
1071 Bzl_load_location: "//build/bazel/rules/cc:cc_aidl_library.bzl",
1072 },
1073 android.CommonAttributes{Name: ccAidlLibrarylabel},
1074 &ccAidlLibraryAttributes{
1075 Deps: *allAidlLibs,
1076 Implementation_deps: *implementationDeps,
1077 Implementation_dynamic_deps: *implementationDynamicDeps,
1078 Tags: apexAvailableTags,
1079 sdkAttributes: sdkAttrs,
Vinh Trane6842942023-04-28 11:21:25 -04001080 includesAttributes: includeAttrs,
Vinh Tran367d89d2023-04-28 11:21:25 -04001081 },
1082 )
1083 label := &bazel.LabelAttribute{
1084 Value: &bazel.Label{
1085 Label: ":" + ccAidlLibrarylabel,
1086 },
1087 }
1088 return label
1089 }
1090
Vinh Trana3b8b782022-09-14 11:40:24 -04001091 return nil
Vinh Tran9f6796a2022-08-16 13:10:31 -04001092}
1093
Yu Liufc603162022-03-01 15:44:08 -08001094func bp2BuildParseSdkAttributes(module *Module) sdkAttributes {
Trevor Radcliffe58ea4512022-04-07 20:36:39 +00001095 return sdkAttributes{
1096 Sdk_version: module.Properties.Sdk_version,
Yu Liufc603162022-03-01 15:44:08 -08001097 Min_sdk_version: module.Properties.Min_sdk_version,
1098 }
1099}
1100
1101type sdkAttributes struct {
1102 Sdk_version *string
1103 Min_sdk_version *string
1104}
1105
Jingwen Chen107c0de2021-04-09 10:43:12 +00001106// Convenience struct to hold all attributes parsed from linker properties.
1107type linkerAttributes struct {
Liz Kammer54309532021-12-14 12:21:22 -05001108 deps bazel.LabelListAttribute
1109 implementationDeps bazel.LabelListAttribute
1110 dynamicDeps bazel.LabelListAttribute
1111 implementationDynamicDeps bazel.LabelListAttribute
Cole Faust6b29f592022-08-09 09:50:56 -07001112 runtimeDeps bazel.LabelListAttribute
Liz Kammer54309532021-12-14 12:21:22 -05001113 wholeArchiveDeps bazel.LabelListAttribute
1114 implementationWholeArchiveDeps bazel.LabelListAttribute
1115 systemDynamicDeps bazel.LabelListAttribute
1116 usedSystemDynamicDepAsDynamicDep map[string]bool
Liz Kammer7a210ac2021-09-22 15:52:58 -04001117
Rupert Shuttleworth484aa252021-12-10 07:22:53 -05001118 useVersionLib bazel.BoolAttribute
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001119 linkopts bazel.StringListAttribute
Liz Kammerd2871182021-10-04 13:54:37 -04001120 additionalLinkerInputs bazel.LabelListAttribute
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001121 stripKeepSymbols bazel.BoolAttribute
1122 stripKeepSymbolsAndDebugFrame bazel.BoolAttribute
1123 stripKeepSymbolsList bazel.StringListAttribute
1124 stripAll bazel.BoolAttribute
1125 stripNone bazel.BoolAttribute
Liz Kammer0eae52e2021-10-06 10:32:26 -04001126 features bazel.StringListAttribute
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001127}
1128
Liz Kammer54309532021-12-14 12:21:22 -05001129var (
1130 soongSystemSharedLibs = []string{"libc", "libm", "libdl"}
Liz Kammerbaced712022-09-16 09:01:29 -04001131 versionLib = "libbuildversion"
Liz Kammer54309532021-12-14 12:21:22 -05001132)
1133
Vinh Tran85fb07c2022-09-16 16:17:48 -04001134// resolveTargetApex re-adds the shared and static libs in target.apex.exclude_shared|static_libs props to non-apex variant
1135// since all libs are already excluded by default
Liz Kammer748d7072023-01-25 12:07:43 -05001136func (la *linkerAttributes) resolveTargetApexProp(ctx android.BazelConversionPathContext, props *BaseLinkerProperties) {
1137 excludeSharedLibs := bazelLabelForSharedDeps(ctx, props.Target.Apex.Exclude_shared_libs)
1138 sharedExcludes := bazel.LabelList{Excludes: excludeSharedLibs.Includes}
1139 sharedExcludesLabelList := bazel.LabelListAttribute{}
1140 sharedExcludesLabelList.SetSelectValue(bazel.InApexAxis, bazel.InApex, sharedExcludes)
Vinh Tran85fb07c2022-09-16 16:17:48 -04001141
Liz Kammer748d7072023-01-25 12:07:43 -05001142 la.dynamicDeps.Append(sharedExcludesLabelList)
1143 la.implementationDynamicDeps.Append(sharedExcludesLabelList)
1144
1145 excludeStaticLibs := bazelLabelForStaticDeps(ctx, props.Target.Apex.Exclude_static_libs)
1146 staticExcludes := bazel.LabelList{Excludes: excludeStaticLibs.Includes}
1147 staticExcludesLabelList := bazel.LabelListAttribute{}
1148 staticExcludesLabelList.SetSelectValue(bazel.InApexAxis, bazel.InApex, staticExcludes)
1149
1150 la.deps.Append(staticExcludesLabelList)
1151 la.implementationDeps.Append(staticExcludesLabelList)
Vinh Tran85fb07c2022-09-16 16:17:48 -04001152}
1153
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001154func (la *linkerAttributes) bp2buildForAxisAndConfig(ctx android.BazelConversionPathContext, module *Module, axis bazel.ConfigurationAxis, config string, props *BaseLinkerProperties) {
1155 isBinary := module.Binary()
Liz Kammere6583482021-10-19 13:56:10 -04001156 // Use a single variable to capture usage of nocrt in arch variants, so there's only 1 error message for this module
1157 var axisFeatures []string
Liz Kammer7a210ac2021-09-22 15:52:58 -04001158
Liz Kammercc2c1ef2022-03-21 09:03:29 -04001159 wholeStaticLibs := android.FirstUniqueStrings(props.Whole_static_libs)
Liz Kammerbaced712022-09-16 09:01:29 -04001160 staticLibs := android.FirstUniqueStrings(android.RemoveListFromList(props.Static_libs, wholeStaticLibs))
1161 if axis == bazel.NoConfigAxis {
1162 la.useVersionLib.SetSelectValue(axis, config, props.Use_version_lib)
1163 if proptools.Bool(props.Use_version_lib) {
1164 versionLibAlreadyInDeps := android.InList(versionLib, wholeStaticLibs)
1165 // remove from static libs so there is no duplicate dependency
1166 _, staticLibs = android.RemoveFromList(versionLib, staticLibs)
1167 // only add the dep if it is not in progress
1168 if !versionLibAlreadyInDeps {
Yu Liufe978fd2023-04-24 16:37:18 -07001169 wholeStaticLibs = append(wholeStaticLibs, versionLib)
Liz Kammerbaced712022-09-16 09:01:29 -04001170 }
1171 }
1172 }
1173
Liz Kammere6583482021-10-19 13:56:10 -04001174 // Excludes to parallel Soong:
1175 // https://cs.android.com/android/platform/superproject/+/master:build/soong/cc/linker.go;l=247-249;drc=088b53577dde6e40085ffd737a1ae96ad82fc4b0
Liz Kammerbaced712022-09-16 09:01:29 -04001176 la.wholeArchiveDeps.SetSelectValue(axis, config, bazelLabelForWholeDepsExcludes(ctx, wholeStaticLibs, props.Exclude_static_libs))
Liz Kammercc2c1ef2022-03-21 09:03:29 -04001177
Vinh Tran85fb07c2022-09-16 16:17:48 -04001178 staticDeps := maybePartitionExportedAndImplementationsDepsExcludes(
1179 ctx,
1180 !isBinary,
1181 staticLibs,
Liz Kammer748d7072023-01-25 12:07:43 -05001182 props.Exclude_static_libs,
Vinh Tran85fb07c2022-09-16 16:17:48 -04001183 props.Export_static_lib_headers,
1184 bazelLabelForStaticDepsExcludes,
1185 )
Liz Kammer7a210ac2021-09-22 15:52:58 -04001186
Liz Kammere6583482021-10-19 13:56:10 -04001187 headerLibs := android.FirstUniqueStrings(props.Header_libs)
1188 hDeps := maybePartitionExportedAndImplementationsDeps(ctx, !isBinary, headerLibs, props.Export_header_lib_headers, bazelLabelForHeaderDeps)
Jingwen Chen63930982021-03-24 10:04:33 -04001189
Liz Kammere6583482021-10-19 13:56:10 -04001190 (&hDeps.export).Append(staticDeps.export)
1191 la.deps.SetSelectValue(axis, config, hDeps.export)
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001192
Liz Kammere6583482021-10-19 13:56:10 -04001193 (&hDeps.implementation).Append(staticDeps.implementation)
1194 la.implementationDeps.SetSelectValue(axis, config, hDeps.implementation)
Liz Kammer0eae52e2021-10-06 10:32:26 -04001195
Liz Kammere6583482021-10-19 13:56:10 -04001196 systemSharedLibs := props.System_shared_libs
1197 // systemSharedLibs distinguishes between nil/empty list behavior:
1198 // nil -> use default values
1199 // empty list -> no values specified
1200 if len(systemSharedLibs) > 0 {
1201 systemSharedLibs = android.FirstUniqueStrings(systemSharedLibs)
1202 }
1203 la.systemDynamicDeps.SetSelectValue(axis, config, bazelLabelForSharedDeps(ctx, systemSharedLibs))
1204
1205 sharedLibs := android.FirstUniqueStrings(props.Shared_libs)
Liz Kammer54309532021-12-14 12:21:22 -05001206 excludeSharedLibs := props.Exclude_shared_libs
1207 usedSystem := android.FilterListPred(sharedLibs, func(s string) bool {
1208 return android.InList(s, soongSystemSharedLibs) && !android.InList(s, excludeSharedLibs)
1209 })
1210 for _, el := range usedSystem {
1211 if la.usedSystemDynamicDepAsDynamicDep == nil {
1212 la.usedSystemDynamicDepAsDynamicDep = map[string]bool{}
1213 }
1214 la.usedSystemDynamicDepAsDynamicDep[el] = true
1215 }
1216
Vinh Tran85fb07c2022-09-16 16:17:48 -04001217 sharedDeps := maybePartitionExportedAndImplementationsDepsExcludes(
1218 ctx,
1219 !isBinary,
1220 sharedLibs,
Liz Kammer748d7072023-01-25 12:07:43 -05001221 props.Exclude_shared_libs,
Vinh Tran85fb07c2022-09-16 16:17:48 -04001222 props.Export_shared_lib_headers,
1223 bazelLabelForSharedDepsExcludes,
1224 )
Liz Kammere6583482021-10-19 13:56:10 -04001225 la.dynamicDeps.SetSelectValue(axis, config, sharedDeps.export)
1226 la.implementationDynamicDeps.SetSelectValue(axis, config, sharedDeps.implementation)
Liz Kammer748d7072023-01-25 12:07:43 -05001227 la.resolveTargetApexProp(ctx, props)
Vinh Tran85fb07c2022-09-16 16:17:48 -04001228
Wei Li81852ca2022-07-27 00:22:06 -07001229 if axis == bazel.NoConfigAxis || (axis == bazel.OsConfigurationAxis && config == bazel.OsAndroid) {
Yu Liu10174ff2023-02-21 12:05:26 -08001230 // If a dependency in la.implementationDynamicDeps or la.dynamicDeps has stubs, its
1231 // stub variant should be used when the dependency is linked in a APEX. The
1232 // dependencies in NoConfigAxis and OsConfigurationAxis/OsAndroid are grouped by
1233 // having stubs or not, so Bazel select() statement can be used to choose
1234 // source/stub variants of them.
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001235 apexAvailable := module.ApexAvailable()
Spandan Dasac693b22023-04-24 00:07:38 +00001236 setStubsForDynamicDeps(ctx, axis, config, apexAvailable, sharedDeps.export, &la.dynamicDeps, 0, false)
1237 setStubsForDynamicDeps(ctx, axis, config, apexAvailable, sharedDeps.implementation, &la.implementationDynamicDeps, 1, false)
1238 if len(systemSharedLibs) > 0 {
1239 setStubsForDynamicDeps(ctx, axis, config, apexAvailable, bazelLabelForSharedDeps(ctx, systemSharedLibs), &la.systemDynamicDeps, 2, true)
1240 }
Wei Li81852ca2022-07-27 00:22:06 -07001241 }
Liz Kammere6583482021-10-19 13:56:10 -04001242
1243 if !BoolDefault(props.Pack_relocations, packRelocationsDefault) {
1244 axisFeatures = append(axisFeatures, "disable_pack_relocations")
1245 }
1246
1247 if Bool(props.Allow_undefined_symbols) {
1248 axisFeatures = append(axisFeatures, "-no_undefined_symbols")
1249 }
1250
1251 var linkerFlags []string
1252 if len(props.Ldflags) > 0 {
Liz Kammerf38a8372022-02-04 15:39:00 -05001253 linkerFlags = append(linkerFlags, proptools.NinjaEscapeList(props.Ldflags)...)
Liz Kammere6583482021-10-19 13:56:10 -04001254 // binaries remove static flag if -shared is in the linker flags
1255 if isBinary && android.InList("-shared", linkerFlags) {
1256 axisFeatures = append(axisFeatures, "-static_flag")
1257 }
1258 }
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +00001259
Alex Márquez Pérez Muñíz Díaz Puras Thaureaux01ec55e2023-01-30 22:53:04 +00001260 if !props.libCrt() {
1261 axisFeatures = append(axisFeatures, "-use_libcrt")
1262 }
1263 if !props.crt() {
1264 axisFeatures = append(axisFeatures, "-link_crt")
1265 }
1266
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +00001267 // This must happen before the addition of flags for Version Script and
1268 // Dynamic List, as these flags must be split on spaces and those must not
1269 linkerFlags = parseCommandLineFlags(linkerFlags, filterOutClangUnknownCflags)
1270
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001271 additionalLinkerInputs := bazel.LabelList{}
Liz Kammere6583482021-10-19 13:56:10 -04001272 if props.Version_script != nil {
1273 label := android.BazelLabelForModuleSrcSingle(ctx, *props.Version_script)
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001274 additionalLinkerInputs.Add(&label)
Liz Kammere6583482021-10-19 13:56:10 -04001275 linkerFlags = append(linkerFlags, fmt.Sprintf("-Wl,--version-script,$(location %s)", label.Label))
Trevor Radcliffef06dd912023-05-19 14:51:41 +00001276 axisFeatures = append(axisFeatures, "android_cfi_exports_map")
Liz Kammere6583482021-10-19 13:56:10 -04001277 }
Alix773adaa2022-04-27 17:49:34 +00001278
1279 if props.Dynamic_list != nil {
1280 label := android.BazelLabelForModuleSrcSingle(ctx, *props.Dynamic_list)
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001281 additionalLinkerInputs.Add(&label)
Alix773adaa2022-04-27 17:49:34 +00001282 linkerFlags = append(linkerFlags, fmt.Sprintf("-Wl,--dynamic-list,$(location %s)", label.Label))
1283 }
1284
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001285 la.additionalLinkerInputs.SetSelectValue(axis, config, additionalLinkerInputs)
Spandan Dasfb04c412023-05-15 18:35:36 +00001286 if axis == bazel.OsConfigurationAxis && (config == bazel.OsDarwin || config == bazel.OsLinux || config == bazel.OsWindows) {
1287 linkerFlags = append(linkerFlags, props.Host_ldlibs...)
1288 }
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +00001289 la.linkopts.SetSelectValue(axis, config, linkerFlags)
Liz Kammere6583482021-10-19 13:56:10 -04001290
1291 if axisFeatures != nil {
1292 la.features.SetSelectValue(axis, config, axisFeatures)
1293 }
Cole Faust6b29f592022-08-09 09:50:56 -07001294
1295 runtimeDeps := android.BazelLabelForModuleDepsExcludes(ctx, props.Runtime_libs, props.Exclude_runtime_libs)
1296 if !runtimeDeps.IsEmpty() {
1297 la.runtimeDeps.SetSelectValue(axis, config, runtimeDeps)
1298 }
Liz Kammere6583482021-10-19 13:56:10 -04001299}
1300
Spandan Das2518c022023-03-17 03:02:32 +00001301var (
1302 apiSurfaceModuleLibCurrentPackage = "@api_surfaces//" + android.ModuleLibApi.String() + "/current:"
1303)
1304
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001305func availableToSameApexes(a, b []string) bool {
1306 if len(a) == 0 && len(b) == 0 {
1307 return true
1308 }
1309 differ, _, _ := android.ListSetDifference(a, b)
1310 return !differ
1311}
1312
Spandan Das4242f102023-04-19 22:31:54 +00001313var (
Spandan Das9cad90f2023-05-04 17:15:44 +00001314 apiDomainConfigSettingKey = android.NewOnceKey("apiDomainConfigSettingKey")
1315 apiDomainConfigSettingLock sync.Mutex
Spandan Das4242f102023-04-19 22:31:54 +00001316)
1317
Spandan Das9cad90f2023-05-04 17:15:44 +00001318func getApiDomainConfigSettingMap(config android.Config) *map[string]bool {
1319 return config.Once(apiDomainConfigSettingKey, func() interface{} {
Spandan Das4242f102023-04-19 22:31:54 +00001320 return &map[string]bool{}
1321 }).(*map[string]bool)
1322}
1323
Spandan Das9cad90f2023-05-04 17:15:44 +00001324var (
1325 testApexNameToApiDomain = map[string]string{
1326 "test_broken_com.android.art": "com.android.art",
1327 }
1328)
1329
Spandan Dasa43ae132023-05-08 18:33:16 +00001330// GetApiDomain returns the canonical name of the apex. This is synonymous to the apex_name definition.
1331// https://cs.android.com/android/_/android/platform/build/soong/+/e3f0281b8897da1fe23b2f4f3a05f1dc87bcc902:apex/prebuilt.go;l=81-83;drc=2dc7244af985a6ad701b22f1271e606cabba527f;bpv=1;bpt=0
1332// For test apexes, it uses a naming convention heuristic to determine the api domain.
1333// TODO (b/281548611): Move this build/soong/android
1334func GetApiDomain(apexName string) string {
Spandan Das9cad90f2023-05-04 17:15:44 +00001335 if apiDomain, exists := testApexNameToApiDomain[apexName]; exists {
1336 return apiDomain
1337 }
1338 // Remove `test_` prefix
1339 return strings.TrimPrefix(apexName, "test_")
1340}
1341
Spandan Das4242f102023-04-19 22:31:54 +00001342// Create a config setting for this apex in build/bazel/rules/apex
1343// The use case for this is stub/impl selection in cc libraries
1344// Long term, these config_setting(s) should be colocated with the respective apex definitions.
1345// Note that this is an anti-pattern: The config_setting should be created from the apex definition
1346// and not from a cc_library.
1347// This anti-pattern is needed today since not all apexes have been allowlisted.
1348func createInApexConfigSetting(ctx android.TopDownMutatorContext, apexName string) {
1349 if apexName == android.AvailableToPlatform || apexName == android.AvailableToAnyApex {
1350 // These correspond to android-non_apex and android-in_apex
1351 return
1352 }
Spandan Das9cad90f2023-05-04 17:15:44 +00001353 apiDomainConfigSettingLock.Lock()
1354 defer apiDomainConfigSettingLock.Unlock()
Spandan Das4242f102023-04-19 22:31:54 +00001355
1356 // Return if a config_setting has already been created
Spandan Dasa43ae132023-05-08 18:33:16 +00001357 apiDomain := GetApiDomain(apexName)
Spandan Das9cad90f2023-05-04 17:15:44 +00001358 acsm := getApiDomainConfigSettingMap(ctx.Config())
1359 if _, exists := (*acsm)[apiDomain]; exists {
Spandan Das4242f102023-04-19 22:31:54 +00001360 return
1361 }
Spandan Das9cad90f2023-05-04 17:15:44 +00001362 (*acsm)[apiDomain] = true
Spandan Das4242f102023-04-19 22:31:54 +00001363
1364 csa := bazel.ConfigSettingAttributes{
1365 Flag_values: bazel.StringMapAttribute{
Spandan Das9cad90f2023-05-04 17:15:44 +00001366 "//build/bazel/rules/apex:api_domain": apiDomain,
Spandan Das4242f102023-04-19 22:31:54 +00001367 },
Spandan Das9cad90f2023-05-04 17:15:44 +00001368 // Constraint this to android
1369 Constraint_values: bazel.MakeLabelListAttribute(
1370 bazel.MakeLabelList(
1371 []bazel.Label{
1372 bazel.Label{Label: "//build/bazel/platforms/os:android"},
1373 },
1374 ),
1375 ),
Spandan Das4242f102023-04-19 22:31:54 +00001376 }
1377 ca := android.CommonAttributes{
Spandan Das9cad90f2023-05-04 17:15:44 +00001378 Name: apiDomain,
Spandan Das4242f102023-04-19 22:31:54 +00001379 }
1380 ctx.CreateBazelConfigSetting(
1381 csa,
1382 ca,
1383 "build/bazel/rules/apex",
1384 )
1385}
1386
1387func inApexConfigSetting(apexAvailable string) string {
1388 if apexAvailable == android.AvailableToPlatform {
Spandan Das6d4d9da2023-04-18 06:20:40 +00001389 return bazel.AndroidPlatform
Spandan Das4242f102023-04-19 22:31:54 +00001390 }
1391 if apexAvailable == android.AvailableToAnyApex {
1392 return bazel.AndroidAndInApex
1393 }
Spandan Dasa43ae132023-05-08 18:33:16 +00001394 apiDomain := GetApiDomain(apexAvailable)
Spandan Das9cad90f2023-05-04 17:15:44 +00001395 return "//build/bazel/rules/apex:" + apiDomain
Spandan Das4242f102023-04-19 22:31:54 +00001396}
1397
Spandan Das6d4d9da2023-04-18 06:20:40 +00001398// Inputs to stub vs impl selection.
1399type stubSelectionInfo struct {
1400 // Label of the implementation library (e.g. //bionic/libc:libc)
1401 impl bazel.Label
1402 // Axis containing the implementation library
1403 axis bazel.ConfigurationAxis
1404 // Axis key containing the implementation library
1405 config string
1406 // API domain of the apex
1407 // For test apexes (test_com.android.foo), this will be the source apex (com.android.foo)
1408 apiDomain string
1409 // List of dep labels
1410 dynamicDeps *bazel.LabelListAttribute
1411 // Boolean value for determining if the dep is in the same api domain
1412 // If false, the label will be rewritten to to the stub label
1413 sameApiDomain bool
1414}
1415
1416func useStubOrImplInApexWithName(ssi stubSelectionInfo) {
1417 lib := ssi.impl
1418 if !ssi.sameApiDomain {
1419 lib = bazel.Label{
1420 Label: apiSurfaceModuleLibCurrentPackage + strings.TrimPrefix(lib.OriginalModuleName, ":"),
1421 }
1422 }
1423 // Create a select statement specific to this apex
1424 inApexSelectValue := ssi.dynamicDeps.SelectValue(bazel.OsAndInApexAxis, inApexConfigSetting(ssi.apiDomain))
1425 (&inApexSelectValue).Append(bazel.MakeLabelList([]bazel.Label{lib}))
1426 ssi.dynamicDeps.SetSelectValue(bazel.OsAndInApexAxis, inApexConfigSetting(ssi.apiDomain), bazel.FirstUniqueBazelLabelList(inApexSelectValue))
1427 // Delete the library from the common config for this apex
1428 implDynamicDeps := ssi.dynamicDeps.SelectValue(ssi.axis, ssi.config)
1429 implDynamicDeps = bazel.SubtractBazelLabelList(implDynamicDeps, bazel.MakeLabelList([]bazel.Label{ssi.impl}))
1430 ssi.dynamicDeps.SetSelectValue(ssi.axis, ssi.config, implDynamicDeps)
1431 if ssi.axis == bazel.NoConfigAxis {
1432 // Set defaults. Defaults (i.e. host) should use impl and not stubs.
1433 defaultSelectValue := ssi.dynamicDeps.SelectValue(bazel.OsAndInApexAxis, bazel.ConditionsDefaultConfigKey)
1434 (&defaultSelectValue).Append(bazel.MakeLabelList([]bazel.Label{ssi.impl}))
1435 ssi.dynamicDeps.SetSelectValue(bazel.OsAndInApexAxis, bazel.ConditionsDefaultConfigKey, bazel.FirstUniqueBazelLabelList(defaultSelectValue))
1436 }
Liz Kammere6583482021-10-19 13:56:10 -04001437}
1438
Yu Liu10174ff2023-02-21 12:05:26 -08001439func setStubsForDynamicDeps(ctx android.BazelConversionPathContext, axis bazel.ConfigurationAxis,
Spandan Dasac693b22023-04-24 00:07:38 +00001440 config string, apexAvailable []string, dynamicLibs bazel.LabelList, dynamicDeps *bazel.LabelListAttribute, ind int, buildNonApexWithStubs bool) {
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001441
Spandan Das4242f102023-04-19 22:31:54 +00001442 // Create a config_setting for each apex_available.
1443 // This will be used to select impl of a dep if dep is available to the same apex.
1444 for _, aa := range apexAvailable {
1445 createInApexConfigSetting(ctx.(android.TopDownMutatorContext), aa)
1446 }
1447
Spandan Das6d4d9da2023-04-18 06:20:40 +00001448 apiDomainForSelects := []string{}
1449 for _, apex := range apexAvailable {
1450 apiDomainForSelects = append(apiDomainForSelects, GetApiDomain(apex))
1451 }
1452 // Always emit a select statement for the platform variant.
1453 // This ensures that b build //foo --config=android works
1454 // Soong always creates a platform variant even when the library might not be available to platform.
1455 if !android.InList(android.AvailableToPlatform, apiDomainForSelects) {
1456 apiDomainForSelects = append(apiDomainForSelects, android.AvailableToPlatform)
1457 }
1458 apiDomainForSelects = android.SortedUniqueStrings(apiDomainForSelects)
1459
1460 // Create a select for each apex this library could be included in.
1461 for _, l := range dynamicLibs.Includes {
1462 dep, _ := ctx.ModuleFromName(l.OriginalModuleName)
1463 if c, ok := dep.(*Module); !ok || !c.HasStubsVariants() {
1464 continue
1465 }
1466 // TODO (b/280339069): Decrease the verbosity of the generated BUILD files
1467 for _, apiDomain := range apiDomainForSelects {
1468 var sameApiDomain bool
1469 if apiDomain == android.AvailableToPlatform {
1470 // Platform variants in Soong use equality of apex_available for stub/impl selection.
1471 // https://cs.android.com/android/_/android/platform/build/soong/+/316b0158fe57ee7764235923e7c6f3d530da39c6:cc/cc.go;l=3393-3404;drc=176271a426496fa2688efe2b40d5c74340c63375;bpv=1;bpt=0
1472 // One of the factors behind this design choice is cc_test
1473 // Tests only have a platform variant, and using equality of apex_available ensures
1474 // that tests of an apex library gets its implementation and not stubs.
1475 // TODO (b/280343104): Discuss if we can drop this special handling for platform variants.
1476 sameApiDomain = availableToSameApexes(apexAvailable, dep.(*Module).ApexAvailable())
Spandan Das6aaab9d2023-05-04 17:27:30 +00001477 if linkable, ok := ctx.Module().(LinkableInterface); ok && linkable.Bootstrap() {
1478 sameApiDomain = true
1479 }
Spandan Das6d4d9da2023-04-18 06:20:40 +00001480 } else {
1481 sameApiDomain = android.InList(apiDomain, dep.(*Module).ApexAvailable())
1482 }
1483 ssi := stubSelectionInfo{
1484 impl: l,
1485 axis: axis,
1486 config: config,
1487 apiDomain: apiDomain,
1488 dynamicDeps: dynamicDeps,
1489 sameApiDomain: sameApiDomain,
1490 }
1491 useStubOrImplInApexWithName(ssi)
1492 }
1493 }
Yu Liu10174ff2023-02-21 12:05:26 -08001494}
1495
Jingwen Chen55bc8202021-11-02 06:40:51 +00001496func (la *linkerAttributes) convertStripProps(ctx android.BazelConversionPathContext, module *Module) {
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001497 bp2BuildPropParseHelper(ctx, module, &StripProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1498 if stripProperties, ok := props.(*StripProperties); ok {
1499 la.stripKeepSymbols.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols)
1500 la.stripKeepSymbolsList.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols_list)
1501 la.stripKeepSymbolsAndDebugFrame.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols_and_debug_frame)
1502 la.stripAll.SetSelectValue(axis, config, stripProperties.Strip.All)
1503 la.stripNone.SetSelectValue(axis, config, stripProperties.Strip.None)
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001504 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001505 })
Liz Kammere6583482021-10-19 13:56:10 -04001506}
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001507
Jingwen Chen55bc8202021-11-02 06:40:51 +00001508func (la *linkerAttributes) convertProductVariables(ctx android.BazelConversionPathContext, productVariableProps android.ProductConfigProperties) {
Jingwen Chen6ada5892021-09-17 11:38:09 +00001509
Liz Kammer47535c52021-06-02 16:02:22 -04001510 type productVarDep struct {
1511 // the name of the corresponding excludes field, if one exists
1512 excludesField string
1513 // reference to the bazel attribute that should be set for the given product variable config
1514 attribute *bazel.LabelListAttribute
Liz Kammer2d7bbe32021-06-10 18:20:06 -04001515
Jingwen Chen55bc8202021-11-02 06:40:51 +00001516 depResolutionFunc func(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList
Liz Kammer47535c52021-06-02 16:02:22 -04001517 }
1518
Zi Wang0a8a1292022-08-30 06:27:01 +00001519 // an intermediate attribute that holds Header_libs info, and will be appended to
1520 // implementationDeps at the end, to solve the confliction that both header_libs
1521 // and static_libs use implementationDeps.
1522 var headerDeps bazel.LabelListAttribute
1523
Liz Kammer47535c52021-06-02 16:02:22 -04001524 productVarToDepFields := map[string]productVarDep{
1525 // product variables do not support exclude_shared_libs
Jingwen Chen55bc8202021-11-02 06:40:51 +00001526 "Shared_libs": {attribute: &la.implementationDynamicDeps, depResolutionFunc: bazelLabelForSharedDepsExcludes},
1527 "Static_libs": {"Exclude_static_libs", &la.implementationDeps, bazelLabelForStaticDepsExcludes},
1528 "Whole_static_libs": {"Exclude_static_libs", &la.wholeArchiveDeps, bazelLabelForWholeDepsExcludes},
Zi Wang0a8a1292022-08-30 06:27:01 +00001529 "Header_libs": {attribute: &headerDeps, depResolutionFunc: bazelLabelForHeaderDepsExcludes},
Liz Kammer47535c52021-06-02 16:02:22 -04001530 }
1531
Liz Kammer47535c52021-06-02 16:02:22 -04001532 for name, dep := range productVarToDepFields {
1533 props, exists := productVariableProps[name]
1534 excludeProps, excludesExists := productVariableProps[dep.excludesField]
Sasha Smundak39a301c2022-12-29 17:11:49 -08001535 // if neither an include nor excludes property exists, then skip it
Liz Kammer47535c52021-06-02 16:02:22 -04001536 if !exists && !excludesExists {
1537 continue
1538 }
Jingwen Chen25825ca2021-11-15 12:28:43 +00001539 // Collect all the configurations that an include or exclude property exists for.
1540 // We want to iterate all configurations rather than either the include or exclude because, for a
1541 // particular configuration, we may have either only an include or an exclude to handle.
Cole Faust150f9a52023-04-26 10:52:24 -07001542 productConfigProps := make(map[android.ProductConfigOrSoongConfigProperty]bool, len(props)+len(excludeProps))
Jingwen Chen25825ca2021-11-15 12:28:43 +00001543 for p := range props {
1544 productConfigProps[p] = true
Liz Kammer47535c52021-06-02 16:02:22 -04001545 }
Jingwen Chen25825ca2021-11-15 12:28:43 +00001546 for p := range excludeProps {
1547 productConfigProps[p] = true
Liz Kammer47535c52021-06-02 16:02:22 -04001548 }
1549
Jingwen Chen25825ca2021-11-15 12:28:43 +00001550 for productConfigProp := range productConfigProps {
1551 prop, includesExists := props[productConfigProp]
1552 excludesProp, excludesExists := excludeProps[productConfigProp]
Liz Kammer47535c52021-06-02 16:02:22 -04001553 var includes, excludes []string
1554 var ok bool
1555 // if there was no includes/excludes property, casting fails and that's expected
Jingwen Chen25825ca2021-11-15 12:28:43 +00001556 if includes, ok = prop.([]string); includesExists && !ok {
Liz Kammer47535c52021-06-02 16:02:22 -04001557 ctx.ModuleErrorf("Could not convert product variable %s property", name)
1558 }
Jingwen Chen25825ca2021-11-15 12:28:43 +00001559 if excludes, ok = excludesProp.([]string); excludesExists && !ok {
Liz Kammer47535c52021-06-02 16:02:22 -04001560 ctx.ModuleErrorf("Could not convert product variable %s property", dep.excludesField)
1561 }
Liz Kammer2d7bbe32021-06-10 18:20:06 -04001562
Jingwen Chen58ff6802021-11-17 12:14:41 +00001563 dep.attribute.EmitEmptyList = productConfigProp.AlwaysEmit()
Jingwen Chen25825ca2021-11-15 12:28:43 +00001564 dep.attribute.SetSelectValue(
1565 productConfigProp.ConfigurationAxis(),
1566 productConfigProp.SelectKey(),
1567 dep.depResolutionFunc(ctx, android.FirstUniqueStrings(includes), excludes),
1568 )
Liz Kammer47535c52021-06-02 16:02:22 -04001569 }
1570 }
Zi Wang0a8a1292022-08-30 06:27:01 +00001571 la.implementationDeps.Append(headerDeps)
Liz Kammere6583482021-10-19 13:56:10 -04001572}
Liz Kammer47535c52021-06-02 16:02:22 -04001573
Liz Kammer54309532021-12-14 12:21:22 -05001574func (la *linkerAttributes) finalize(ctx android.BazelConversionPathContext) {
1575 // if system dynamic deps have the default value, any use of a system dynamic library used will
1576 // result in duplicate library errors for bionic OSes. Here, we explicitly exclude those libraries
Liz Kammer43345e22022-08-04 13:57:35 -04001577 // from bionic OSes and the no config case as these libraries only build for bionic OSes.
Liz Kammer54309532021-12-14 12:21:22 -05001578 if la.systemDynamicDeps.IsNil() && len(la.usedSystemDynamicDepAsDynamicDep) > 0 {
Cole Faust18994c72023-02-28 16:02:16 -08001579 toRemove := bazelLabelForSharedDeps(ctx, android.SortedKeys(la.usedSystemDynamicDepAsDynamicDep))
Liz Kammer43345e22022-08-04 13:57:35 -04001580 la.dynamicDeps.Exclude(bazel.NoConfigAxis, "", toRemove)
Liz Kammer54309532021-12-14 12:21:22 -05001581 la.dynamicDeps.Exclude(bazel.OsConfigurationAxis, "android", toRemove)
1582 la.dynamicDeps.Exclude(bazel.OsConfigurationAxis, "linux_bionic", toRemove)
Liz Kammer91487d42022-09-13 11:27:11 -04001583 la.implementationDynamicDeps.Exclude(bazel.NoConfigAxis, "", toRemove)
Liz Kammer54309532021-12-14 12:21:22 -05001584 la.implementationDynamicDeps.Exclude(bazel.OsConfigurationAxis, "android", toRemove)
1585 la.implementationDynamicDeps.Exclude(bazel.OsConfigurationAxis, "linux_bionic", toRemove)
Liz Kammer91487d42022-09-13 11:27:11 -04001586
1587 la.implementationDynamicDeps.Exclude(bazel.OsAndInApexAxis, bazel.ConditionsDefaultConfigKey, toRemove)
Liz Kammer91487d42022-09-13 11:27:11 -04001588 stubsToRemove := make([]bazel.Label, 0, len(la.usedSystemDynamicDepAsDynamicDep))
1589 for _, lib := range toRemove.Includes {
Spandan Das2518c022023-03-17 03:02:32 +00001590 stubLabelInApiSurfaces := bazel.Label{
1591 Label: apiSurfaceModuleLibCurrentPackage + lib.OriginalModuleName,
1592 }
1593 stubsToRemove = append(stubsToRemove, stubLabelInApiSurfaces)
Liz Kammer91487d42022-09-13 11:27:11 -04001594 }
Spandan Das6d4d9da2023-04-18 06:20:40 +00001595 // system libraries (e.g. libc, libm, libdl) belong the com.android.runtime api domain
1596 // dedupe the stubs of these libraries from the other api domains (platform, other_apexes...)
1597 for _, aa := range ctx.Module().(*Module).ApexAvailable() {
1598 la.implementationDynamicDeps.Exclude(bazel.OsAndInApexAxis, inApexConfigSetting(aa), bazel.MakeLabelList(stubsToRemove))
1599 }
1600 la.implementationDynamicDeps.Exclude(bazel.OsAndInApexAxis, bazel.AndroidPlatform, bazel.MakeLabelList(stubsToRemove))
Liz Kammer54309532021-12-14 12:21:22 -05001601 }
1602
Liz Kammere6583482021-10-19 13:56:10 -04001603 la.deps.ResolveExcludes()
1604 la.implementationDeps.ResolveExcludes()
1605 la.dynamicDeps.ResolveExcludes()
1606 la.implementationDynamicDeps.ResolveExcludes()
1607 la.wholeArchiveDeps.ResolveExcludes()
1608 la.systemDynamicDeps.ForceSpecifyEmptyList = true
Liz Kammer54309532021-12-14 12:21:22 -05001609
Jingwen Chen91220d72021-03-24 02:18:33 -04001610}
1611
Jingwen Chened9c17d2021-04-13 07:14:55 +00001612// Relativize a list of root-relative paths with respect to the module's
1613// directory.
1614//
1615// include_dirs Soong prop are root-relative (b/183742505), but
1616// local_include_dirs, export_include_dirs and export_system_include_dirs are
1617// module dir relative. This function makes a list of paths entirely module dir
1618// relative.
1619//
1620// For the `include` attribute, Bazel wants the paths to be relative to the
1621// module.
1622func bp2BuildMakePathsRelativeToModule(ctx android.BazelConversionPathContext, paths []string) []string {
Rupert Shuttleworthb8151682021-04-06 20:06:21 +00001623 var relativePaths []string
1624 for _, path := range paths {
Jingwen Chened9c17d2021-04-13 07:14:55 +00001625 // Semantics of filepath.Rel: join(ModuleDir, rel(ModuleDir, path)) == path
1626 relativePath, err := filepath.Rel(ctx.ModuleDir(), path)
1627 if err != nil {
1628 panic(err)
1629 }
Rupert Shuttleworthb8151682021-04-06 20:06:21 +00001630 relativePaths = append(relativePaths, relativePath)
1631 }
1632 return relativePaths
1633}
1634
Liz Kammer5fad5012021-09-09 14:08:21 -04001635// BazelIncludes contains information about -I and -isystem paths from a module converted to Bazel
1636// attributes.
1637type BazelIncludes struct {
Liz Kammer1263d9b2021-12-10 14:28:20 -05001638 AbsoluteIncludes bazel.StringListAttribute
1639 Includes bazel.StringListAttribute
1640 SystemIncludes bazel.StringListAttribute
Liz Kammer5fad5012021-09-09 14:08:21 -04001641}
1642
Liz Kammer54549442022-05-11 13:55:06 -04001643func bp2BuildParseExportedIncludes(ctx android.BazelConversionPathContext, module *Module, includes *BazelIncludes) BazelIncludes {
Liz Kammer1263d9b2021-12-10 14:28:20 -05001644 var exported BazelIncludes
1645 if includes != nil {
1646 exported = *includes
1647 } else {
1648 exported = BazelIncludes{}
1649 }
Zi Wang1cb11802022-12-09 16:08:54 -08001650
1651 // cc library Export_include_dirs and Export_system_include_dirs are marked
1652 // "variant_prepend" in struct tag, set their prepend property to true to make
1653 // sure bp2build generates correct result.
1654 exported.Includes.Prepend = true
1655 exported.SystemIncludes.Prepend = true
1656
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001657 bp2BuildPropParseHelper(ctx, module, &FlagExporterProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1658 if flagExporterProperties, ok := props.(*FlagExporterProperties); ok {
1659 if len(flagExporterProperties.Export_include_dirs) > 0 {
1660 exported.Includes.SetSelectValue(axis, config, android.FirstUniqueStrings(append(exported.Includes.SelectValue(axis, config), flagExporterProperties.Export_include_dirs...)))
1661 }
1662 if len(flagExporterProperties.Export_system_include_dirs) > 0 {
1663 exported.SystemIncludes.SetSelectValue(axis, config, android.FirstUniqueStrings(append(exported.SystemIncludes.SelectValue(axis, config), flagExporterProperties.Export_system_include_dirs...)))
Rupert Shuttleworth375451e2021-04-26 07:49:08 -04001664 }
Rupert Shuttleworth375451e2021-04-26 07:49:08 -04001665 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001666 })
Liz Kammer1263d9b2021-12-10 14:28:20 -05001667 exported.AbsoluteIncludes.DeduplicateAxesFromBase()
Liz Kammer5fad5012021-09-09 14:08:21 -04001668 exported.Includes.DeduplicateAxesFromBase()
1669 exported.SystemIncludes.DeduplicateAxesFromBase()
Rupert Shuttleworth375451e2021-04-26 07:49:08 -04001670
Liz Kammer5fad5012021-09-09 14:08:21 -04001671 return exported
Jingwen Chen91220d72021-03-24 02:18:33 -04001672}
Chris Parsons953b3562021-09-20 15:14:39 -04001673
Trevor Radcliffecee4e052022-09-06 19:31:25 +00001674func BazelLabelNameForStaticModule(baseLabel string) string {
1675 return baseLabel + "_bp2build_cc_library_static"
1676}
1677
Jingwen Chen55bc8202021-11-02 06:40:51 +00001678func bazelLabelForStaticModule(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -04001679 label := android.BazelModuleLabel(ctx, m)
Sasha Smundak39a301c2022-12-29 17:11:49 -08001680 if ccModule, ok := m.(*Module); ok && ccModule.typ() == fullLibrary {
Trevor Radcliffecee4e052022-09-06 19:31:25 +00001681 return BazelLabelNameForStaticModule(label)
Chris Parsons953b3562021-09-20 15:14:39 -04001682 }
1683 return label
1684}
1685
Jingwen Chen55bc8202021-11-02 06:40:51 +00001686func bazelLabelForSharedModule(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -04001687 // cc_library, at it's root name, propagates the shared library, which depends on the static
1688 // library.
1689 return android.BazelModuleLabel(ctx, m)
1690}
1691
Jingwen Chen55bc8202021-11-02 06:40:51 +00001692func bazelLabelForStaticWholeModuleDeps(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -04001693 label := bazelLabelForStaticModule(ctx, m)
1694 if aModule, ok := m.(android.Module); ok {
1695 if android.IsModulePrebuilt(aModule) {
1696 label += "_alwayslink"
1697 }
1698 }
1699 return label
1700}
1701
Jingwen Chen55bc8202021-11-02 06:40:51 +00001702func bazelLabelForWholeDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001703 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForStaticWholeModuleDeps)
1704}
1705
Jingwen Chen55bc8202021-11-02 06:40:51 +00001706func bazelLabelForWholeDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001707 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForStaticWholeModuleDeps)
1708}
1709
Jingwen Chen55bc8202021-11-02 06:40:51 +00001710func bazelLabelForStaticDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001711 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForStaticModule)
1712}
1713
Jingwen Chen55bc8202021-11-02 06:40:51 +00001714func bazelLabelForStaticDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001715 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForStaticModule)
1716}
1717
Jingwen Chen55bc8202021-11-02 06:40:51 +00001718func bazelLabelForSharedDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001719 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForSharedModule)
1720}
1721
Jingwen Chen55bc8202021-11-02 06:40:51 +00001722func bazelLabelForHeaderDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001723 // This is not elegant, but bp2build's shared library targets only propagate
1724 // their header information as part of the normal C++ provider.
1725 return bazelLabelForSharedDeps(ctx, modules)
1726}
1727
Zi Wang0a8a1292022-08-30 06:27:01 +00001728func bazelLabelForHeaderDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
1729 // This is only used when product_variable header_libs is processed, to follow
1730 // the pattern of depResolutionFunc
1731 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForSharedModule)
1732}
1733
Jingwen Chen55bc8202021-11-02 06:40:51 +00001734func bazelLabelForSharedDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001735 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForSharedModule)
1736}
Liz Kammer2b8004b2021-10-04 13:55:44 -04001737
1738type binaryLinkerAttrs struct {
1739 Linkshared *bool
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05001740 Suffix bazel.StringAttribute
Liz Kammer2b8004b2021-10-04 13:55:44 -04001741}
1742
Jingwen Chen55bc8202021-11-02 06:40:51 +00001743func bp2buildBinaryLinkerProps(ctx android.BazelConversionPathContext, m *Module) binaryLinkerAttrs {
Liz Kammer2b8004b2021-10-04 13:55:44 -04001744 attrs := binaryLinkerAttrs{}
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001745 bp2BuildPropParseHelper(ctx, m, &BinaryLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1746 linkerProps := props.(*BinaryLinkerProperties)
1747 staticExecutable := linkerProps.Static_executable
1748 if axis == bazel.NoConfigAxis {
1749 if linkBinaryShared := !proptools.Bool(staticExecutable); !linkBinaryShared {
1750 attrs.Linkshared = &linkBinaryShared
Liz Kammer2b8004b2021-10-04 13:55:44 -04001751 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001752 } else if staticExecutable != nil {
1753 // TODO(b/202876379): Static_executable is arch-variant; however, linkshared is a
1754 // nonconfigurable attribute. Only 4 AOSP modules use this feature, defer handling
1755 ctx.ModuleErrorf("bp2build cannot migrate a module with arch/target-specific static_executable values")
Liz Kammer2b8004b2021-10-04 13:55:44 -04001756 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05001757 if suffix := linkerProps.Suffix; suffix != nil {
1758 attrs.Suffix.SetSelectValue(axis, config, suffix)
1759 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001760 })
Liz Kammer2b8004b2021-10-04 13:55:44 -04001761
1762 return attrs
1763}
Trevor Radcliffedb7e0262022-10-28 16:48:18 +00001764
1765func bp2buildSanitizerFeatures(ctx android.BazelConversionPathContext, m *Module) bazel.StringListAttribute {
1766 sanitizerFeatures := bazel.StringListAttribute{}
1767 bp2BuildPropParseHelper(ctx, m, &SanitizeProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1768 var features []string
1769 if sanitizerProps, ok := props.(*SanitizeProperties); ok {
1770 if sanitizerProps.Sanitize.Integer_overflow != nil && *sanitizerProps.Sanitize.Integer_overflow {
1771 features = append(features, "ubsan_integer_overflow")
1772 }
1773 for _, sanitizer := range sanitizerProps.Sanitize.Misc_undefined {
1774 features = append(features, "ubsan_"+sanitizer)
1775 }
1776 sanitizerFeatures.SetSelectValue(axis, config, features)
1777 }
1778 })
1779 return sanitizerFeatures
1780}
Trevor Radcliffe56b1a2b2023-02-06 21:58:30 +00001781
1782func bp2buildLtoFeatures(ctx android.BazelConversionPathContext, m *Module) bazel.StringListAttribute {
1783 lto_feature_name := "android_thin_lto"
1784 ltoBoolFeatures := bazel.BoolAttribute{}
1785 bp2BuildPropParseHelper(ctx, m, &LTOProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1786 if ltoProps, ok := props.(*LTOProperties); ok {
1787 thinProp := ltoProps.Lto.Thin != nil && *ltoProps.Lto.Thin
1788 thinPropSetToFalse := ltoProps.Lto.Thin != nil && !*ltoProps.Lto.Thin
1789 neverProp := ltoProps.Lto.Never != nil && *ltoProps.Lto.Never
1790 if thinProp {
1791 ltoBoolFeatures.SetSelectValue(axis, config, BoolPtr(true))
1792 return
1793 }
1794 if neverProp || thinPropSetToFalse {
1795 if thinProp {
1796 ctx.ModuleErrorf("lto.thin and lto.never are mutually exclusive but were specified together")
1797 } else {
1798 ltoBoolFeatures.SetSelectValue(axis, config, BoolPtr(false))
1799 }
1800 return
1801 }
1802 }
1803 ltoBoolFeatures.SetSelectValue(axis, config, nil)
1804 })
1805
1806 props := m.GetArchVariantProperties(ctx, &LTOProperties{})
1807 ltoStringFeatures, err := ltoBoolFeatures.ToStringListAttribute(func(boolPtr *bool, axis bazel.ConfigurationAxis, config string) []string {
1808 if boolPtr == nil {
1809 return []string{}
1810 }
1811 if !*boolPtr {
1812 return []string{"-" + lto_feature_name}
1813 }
1814 features := []string{lto_feature_name}
1815 if ltoProps, ok := props[axis][config].(*LTOProperties); ok {
1816 if ltoProps.Whole_program_vtables != nil && *ltoProps.Whole_program_vtables {
1817 features = append(features, "android_thin_lto_whole_program_vtables")
1818 }
1819 }
1820 return features
1821 })
1822 if err != nil {
1823 ctx.ModuleErrorf("Error processing LTO attributes: %s", err)
1824 }
1825 return ltoStringFeatures
1826}
Trevor Radcliffea8b44162023-04-14 18:25:24 +00001827
1828func convertHiddenVisibilityToFeatureBase(ctx android.BazelConversionPathContext, m *Module) bazel.StringListAttribute {
1829 visibilityHiddenFeature := bazel.StringListAttribute{}
1830 bp2BuildPropParseHelper(ctx, m, &BaseCompilerProperties{}, func(axis bazel.ConfigurationAxis, configString string, props interface{}) {
1831 if baseCompilerProps, ok := props.(*BaseCompilerProperties); ok {
1832 convertHiddenVisibilityToFeatureHelper(&visibilityHiddenFeature, axis, configString, baseCompilerProps.Cflags)
1833 }
1834 })
1835 return visibilityHiddenFeature
1836}
1837
1838func convertHiddenVisibilityToFeatureStaticOrShared(ctx android.BazelConversionPathContext, m *Module, isStatic bool) bazel.StringListAttribute {
1839 visibilityHiddenFeature := bazel.StringListAttribute{}
1840 if isStatic {
1841 bp2BuildPropParseHelper(ctx, m, &StaticProperties{}, func(axis bazel.ConfigurationAxis, configString string, props interface{}) {
1842 if staticProps, ok := props.(*StaticProperties); ok {
1843 convertHiddenVisibilityToFeatureHelper(&visibilityHiddenFeature, axis, configString, staticProps.Static.Cflags)
1844 }
1845 })
1846 } else {
1847 bp2BuildPropParseHelper(ctx, m, &SharedProperties{}, func(axis bazel.ConfigurationAxis, configString string, props interface{}) {
1848 if sharedProps, ok := props.(*SharedProperties); ok {
1849 convertHiddenVisibilityToFeatureHelper(&visibilityHiddenFeature, axis, configString, sharedProps.Shared.Cflags)
1850 }
1851 })
1852 }
1853
1854 return visibilityHiddenFeature
1855}
1856
1857func convertHiddenVisibilityToFeatureHelper(feature *bazel.StringListAttribute, axis bazel.ConfigurationAxis, configString string, cflags []string) {
1858 if inList(config.VisibilityHiddenFlag, cflags) {
1859 feature.SetSelectValue(axis, configString, []string{"visibility_hidden"})
1860 }
1861}