blob: ba02b7ef8565d2f899289914204c74ff4bc251c1 [file] [log] [blame]
Jingwen Chen91220d72021-03-24 02:18:33 -04001// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14package cc
15
16import (
Liz Kammerd2871182021-10-04 13:54:37 -040017 "fmt"
Jingwen Chened9c17d2021-04-13 07:14:55 +000018 "path/filepath"
Jingwen Chen3950cd62021-05-12 04:33:00 +000019 "strings"
Chris Parsons484e50a2021-05-13 15:13:04 -040020
21 "android/soong/android"
22 "android/soong/bazel"
Liz Kammer7a210ac2021-09-22 15:52:58 -040023
Chris Parsons953b3562021-09-20 15:14:39 -040024 "github.com/google/blueprint"
Liz Kammerba7a9c52021-05-26 08:45:30 -040025
26 "github.com/google/blueprint/proptools"
Jingwen Chen91220d72021-03-24 02:18:33 -040027)
28
Liz Kammerae3994e2021-10-19 09:45:48 -040029const (
Liz Kammer12615db2021-09-28 09:19:17 -040030 cSrcPartition = "c"
31 asSrcPartition = "as"
Trevor Radcliffeef9c9002022-05-13 20:55:35 +000032 lSrcPartition = "l"
33 llSrcPartition = "ll"
Liz Kammer12615db2021-09-28 09:19:17 -040034 cppSrcPartition = "cpp"
35 protoSrcPartition = "proto"
Liz Kammerae3994e2021-10-19 09:45:48 -040036)
37
Liz Kammer2222c6b2021-05-24 15:41:47 -040038// staticOrSharedAttributes are the Bazel-ified versions of StaticOrSharedProperties --
Jingwen Chenbcf53042021-05-26 04:42:42 +000039// properties which apply to either the shared or static version of a cc_library module.
Liz Kammer2222c6b2021-05-24 15:41:47 -040040type staticOrSharedAttributes struct {
Jingwen Chenc4dc9b42021-06-11 12:51:48 +000041 Srcs bazel.LabelListAttribute
42 Srcs_c bazel.LabelListAttribute
43 Srcs_as bazel.LabelListAttribute
Liz Kammere6583482021-10-19 13:56:10 -040044 Hdrs bazel.LabelListAttribute
Jingwen Chenc4dc9b42021-06-11 12:51:48 +000045 Copts bazel.StringListAttribute
Jingwen Chen14a8bda2021-06-02 11:10:02 +000046
Liz Kammer12615db2021-09-28 09:19:17 -040047 Deps bazel.LabelListAttribute
48 Implementation_deps bazel.LabelListAttribute
49 Dynamic_deps bazel.LabelListAttribute
50 Implementation_dynamic_deps bazel.LabelListAttribute
51 Whole_archive_deps bazel.LabelListAttribute
52 Implementation_whole_archive_deps bazel.LabelListAttribute
Chris Parsons51f8c392021-08-03 21:01:05 -040053
54 System_dynamic_deps bazel.LabelListAttribute
Chris Parsons58852a02021-12-09 18:10:18 -050055
56 Enabled bazel.BoolAttribute
Yu Liufc603162022-03-01 15:44:08 -080057
58 sdkAttributes
Jingwen Chen53681ef2021-04-29 08:15:13 +000059}
60
Sam Delmericoc7681022022-02-04 21:01:20 +000061// groupSrcsByExtension partitions `srcs` into groups based on file extension.
Jingwen Chen55bc8202021-11-02 06:40:51 +000062func groupSrcsByExtension(ctx android.BazelConversionPathContext, srcs bazel.LabelListAttribute) bazel.PartitionToLabelListAttribute {
Liz Kammer57e2e7a2021-09-20 12:55:02 -040063 // Convert filegroup dependencies into extension-specific filegroups filtered in the filegroup.bzl
64 // macro.
65 addSuffixForFilegroup := func(suffix string) bazel.LabelMapper {
Liz Kammer12615db2021-09-28 09:19:17 -040066 return func(ctx bazel.OtherModuleContext, label bazel.Label) (string, bool) {
67 m, exists := ctx.ModuleFromName(label.OriginalModuleName)
68 labelStr := label.Label
Sam Delmericoc7681022022-02-04 21:01:20 +000069 if !exists || !android.IsFilegroup(ctx, m) {
Liz Kammer12615db2021-09-28 09:19:17 -040070 return labelStr, false
Jingwen Chen14a8bda2021-06-02 11:10:02 +000071 }
Liz Kammer12615db2021-09-28 09:19:17 -040072 return labelStr + suffix, true
Chris Parsons5a34ffb2021-07-21 14:34:58 -040073 }
Jingwen Chen14a8bda2021-06-02 11:10:02 +000074 }
75
Liz Kammer57e2e7a2021-09-20 12:55:02 -040076 // TODO(b/190006308): Handle language detection of sources in a Bazel rule.
Sam Delmericoc7681022022-02-04 21:01:20 +000077 labels := bazel.LabelPartitions{
78 protoSrcPartition: android.ProtoSrcLabelPartition,
Liz Kammeraabfb5d2021-12-08 15:25:06 -050079 cSrcPartition: bazel.LabelPartition{Extensions: []string{".c"}, LabelMapper: addSuffixForFilegroup("_c_srcs")},
80 asSrcPartition: bazel.LabelPartition{Extensions: []string{".s", ".S"}, LabelMapper: addSuffixForFilegroup("_as_srcs")},
Trevor Radcliffeef9c9002022-05-13 20:55:35 +000081 // TODO(http://b/231968910): If there is ever a filegroup target that
82 // contains .l or .ll files we will need to find a way to add a
83 // LabelMapper for these that identifies these filegroups and
84 // converts them appropriately
85 lSrcPartition: bazel.LabelPartition{Extensions: []string{".l"}},
86 llSrcPartition: bazel.LabelPartition{Extensions: []string{".ll"}},
Liz Kammer57e2e7a2021-09-20 12:55:02 -040087 // C++ is the "catch-all" group, and comprises generated sources because we don't
88 // know the language of these sources until the genrule is executed.
Liz Kammeraabfb5d2021-12-08 15:25:06 -050089 cppSrcPartition: bazel.LabelPartition{Extensions: []string{".cpp", ".cc", ".cxx", ".mm"}, LabelMapper: addSuffixForFilegroup("_cpp_srcs"), Keep_remainder: true},
Sam Delmericoc7681022022-02-04 21:01:20 +000090 }
Jingwen Chen14a8bda2021-06-02 11:10:02 +000091
Sam Delmericoc7681022022-02-04 21:01:20 +000092 return bazel.PartitionLabelListAttribute(ctx, &srcs, labels)
Jingwen Chen14a8bda2021-06-02 11:10:02 +000093}
94
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +000095// bp2BuildParseLibProps returns the attributes for a variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +000096func bp2BuildParseLibProps(ctx android.BazelConversionPathContext, module *Module, isStatic bool) staticOrSharedAttributes {
Jingwen Chen53681ef2021-04-29 08:15:13 +000097 lib, ok := module.compiler.(*libraryDecorator)
98 if !ok {
Liz Kammer2222c6b2021-05-24 15:41:47 -040099 return staticOrSharedAttributes{}
Jingwen Chen53681ef2021-04-29 08:15:13 +0000100 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000101 return bp2buildParseStaticOrSharedProps(ctx, module, lib, isStatic)
102}
Jingwen Chen53681ef2021-04-29 08:15:13 +0000103
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000104// bp2buildParseSharedProps returns the attributes for the shared variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000105func bp2BuildParseSharedProps(ctx android.BazelConversionPathContext, module *Module) staticOrSharedAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000106 return bp2BuildParseLibProps(ctx, module, false)
Jingwen Chen53681ef2021-04-29 08:15:13 +0000107}
108
109// bp2buildParseStaticProps returns the attributes for the static variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000110func bp2BuildParseStaticProps(ctx android.BazelConversionPathContext, module *Module) staticOrSharedAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000111 return bp2BuildParseLibProps(ctx, module, true)
Liz Kammer2222c6b2021-05-24 15:41:47 -0400112}
113
Liz Kammer7a210ac2021-09-22 15:52:58 -0400114type depsPartition struct {
115 export bazel.LabelList
116 implementation bazel.LabelList
117}
118
Jingwen Chen55bc8202021-11-02 06:40:51 +0000119type bazelLabelForDepsFn func(android.BazelConversionPathContext, []string) bazel.LabelList
Liz Kammer7a210ac2021-09-22 15:52:58 -0400120
Jingwen Chen55bc8202021-11-02 06:40:51 +0000121func maybePartitionExportedAndImplementationsDeps(ctx android.BazelConversionPathContext, exportsDeps bool, allDeps, exportedDeps []string, fn bazelLabelForDepsFn) depsPartition {
Liz Kammer2b8004b2021-10-04 13:55:44 -0400122 if !exportsDeps {
123 return depsPartition{
124 implementation: fn(ctx, allDeps),
125 }
126 }
127
Liz Kammer7a210ac2021-09-22 15:52:58 -0400128 implementation, export := android.FilterList(allDeps, exportedDeps)
129
130 return depsPartition{
131 export: fn(ctx, export),
132 implementation: fn(ctx, implementation),
133 }
134}
135
Jingwen Chen55bc8202021-11-02 06:40:51 +0000136type bazelLabelForDepsExcludesFn func(android.BazelConversionPathContext, []string, []string) bazel.LabelList
Liz Kammer7a210ac2021-09-22 15:52:58 -0400137
Jingwen Chen55bc8202021-11-02 06:40:51 +0000138func maybePartitionExportedAndImplementationsDepsExcludes(ctx android.BazelConversionPathContext, exportsDeps bool, allDeps, excludes, exportedDeps []string, fn bazelLabelForDepsExcludesFn) depsPartition {
Liz Kammer2b8004b2021-10-04 13:55:44 -0400139 if !exportsDeps {
140 return depsPartition{
141 implementation: fn(ctx, allDeps, excludes),
142 }
143 }
Liz Kammer7a210ac2021-09-22 15:52:58 -0400144 implementation, export := android.FilterList(allDeps, exportedDeps)
145
146 return depsPartition{
147 export: fn(ctx, export, excludes),
148 implementation: fn(ctx, implementation, excludes),
149 }
150}
151
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000152// Parses properties common to static and shared libraries. Also used for prebuilt libraries.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000153func bp2buildParseStaticOrSharedProps(ctx android.BazelConversionPathContext, module *Module, lib *libraryDecorator, isStatic bool) staticOrSharedAttributes {
Liz Kammer135bf552021-08-11 10:46:06 -0400154 attrs := staticOrSharedAttributes{}
Jingwen Chenbcf53042021-05-26 04:42:42 +0000155
Liz Kammer9abd62d2021-05-21 08:37:59 -0400156 setAttrs := func(axis bazel.ConfigurationAxis, config string, props StaticOrSharedProperties) {
Liz Kammercac7f692021-12-16 14:19:32 -0500157 attrs.Copts.SetSelectValue(axis, config, parseCommandLineFlags(props.Cflags, filterOutStdFlag))
Jingwen Chenc4dc9b42021-06-11 12:51:48 +0000158 attrs.Srcs.SetSelectValue(axis, config, android.BazelLabelForModuleSrc(ctx, props.Srcs))
Chris Parsons953b3562021-09-20 15:14:39 -0400159 attrs.System_dynamic_deps.SetSelectValue(axis, config, bazelLabelForSharedDeps(ctx, props.System_shared_libs))
Liz Kammer7a210ac2021-09-22 15:52:58 -0400160
Liz Kammer2b8004b2021-10-04 13:55:44 -0400161 staticDeps := maybePartitionExportedAndImplementationsDeps(ctx, true, props.Static_libs, props.Export_static_lib_headers, bazelLabelForStaticDeps)
Liz Kammer7a210ac2021-09-22 15:52:58 -0400162 attrs.Deps.SetSelectValue(axis, config, staticDeps.export)
163 attrs.Implementation_deps.SetSelectValue(axis, config, staticDeps.implementation)
164
Liz Kammer2b8004b2021-10-04 13:55:44 -0400165 sharedDeps := maybePartitionExportedAndImplementationsDeps(ctx, true, props.Shared_libs, props.Export_shared_lib_headers, bazelLabelForSharedDeps)
Liz Kammer7a210ac2021-09-22 15:52:58 -0400166 attrs.Dynamic_deps.SetSelectValue(axis, config, sharedDeps.export)
167 attrs.Implementation_dynamic_deps.SetSelectValue(axis, config, sharedDeps.implementation)
168
169 attrs.Whole_archive_deps.SetSelectValue(axis, config, bazelLabelForWholeDeps(ctx, props.Whole_static_libs))
Chris Parsons58852a02021-12-09 18:10:18 -0500170 attrs.Enabled.SetSelectValue(axis, config, props.Enabled)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000171 }
Liz Kammer135bf552021-08-11 10:46:06 -0400172 // system_dynamic_deps distinguishes between nil/empty list behavior:
173 // nil -> use default values
174 // empty list -> no values specified
175 attrs.System_dynamic_deps.ForceSpecifyEmptyList = true
Jingwen Chenbcf53042021-05-26 04:42:42 +0000176
177 if isStatic {
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000178 bp2BuildPropParseHelper(ctx, module, &StaticProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
179 if staticOrSharedProps, ok := props.(*StaticProperties); ok {
180 setAttrs(axis, config, staticOrSharedProps.Static)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000181 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000182 })
Jingwen Chenbcf53042021-05-26 04:42:42 +0000183 } else {
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000184 bp2BuildPropParseHelper(ctx, module, &SharedProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
185 if staticOrSharedProps, ok := props.(*SharedProperties); ok {
186 setAttrs(axis, config, staticOrSharedProps.Shared)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000187 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000188 })
Jingwen Chenbcf53042021-05-26 04:42:42 +0000189 }
190
Liz Kammerae3994e2021-10-19 09:45:48 -0400191 partitionedSrcs := groupSrcsByExtension(ctx, attrs.Srcs)
192 attrs.Srcs = partitionedSrcs[cppSrcPartition]
193 attrs.Srcs_c = partitionedSrcs[cSrcPartition]
194 attrs.Srcs_as = partitionedSrcs[asSrcPartition]
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000195
Liz Kammer12615db2021-09-28 09:19:17 -0400196 if !partitionedSrcs[protoSrcPartition].IsEmpty() {
197 // TODO(b/208815215): determine whether this is used and add support if necessary
198 ctx.ModuleErrorf("Migrating static/shared only proto srcs is not currently supported")
199 }
200
Jingwen Chenbcf53042021-05-26 04:42:42 +0000201 return attrs
Jingwen Chen53681ef2021-04-29 08:15:13 +0000202}
203
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400204// Convenience struct to hold all attributes parsed from prebuilt properties.
205type prebuiltAttributes struct {
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000206 Src bazel.LabelAttribute
207 Enabled bazel.BoolAttribute
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400208}
209
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000210// NOTE: Used outside of Soong repo project, in the clangprebuilts.go bootstrap_go_package
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000211func Bp2BuildParsePrebuiltLibraryProps(ctx android.BazelConversionPathContext, module *Module, isStatic bool) prebuiltAttributes {
212 manySourceFileError := func(axis bazel.ConfigurationAxis, config string) {
213 ctx.ModuleErrorf("Bp2BuildParsePrebuiltLibraryProps: Expected at most one source file for %s %s\n", axis, config)
214 }
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400215 var srcLabelAttribute bazel.LabelAttribute
216
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000217 parseSrcs := func(ctx android.BazelConversionPathContext, axis bazel.ConfigurationAxis, config string, srcs []string) {
218 if len(srcs) > 1 {
219 manySourceFileError(axis, config)
220 return
221 } else if len(srcs) == 0 {
222 return
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400223 }
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000224 if srcLabelAttribute.SelectValue(axis, config) != nil {
225 manySourceFileError(axis, config)
226 return
227 }
228
229 src := android.BazelLabelForModuleSrcSingle(ctx, srcs[0])
230 srcLabelAttribute.SetSelectValue(axis, config, src)
231 }
232
233 bp2BuildPropParseHelper(ctx, module, &prebuiltLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
234 if prebuiltLinkerProperties, ok := props.(*prebuiltLinkerProperties); ok {
235 parseSrcs(ctx, axis, config, prebuiltLinkerProperties.Srcs)
236 }
237 })
238
239 var enabledLabelAttribute bazel.BoolAttribute
240 parseAttrs := func(axis bazel.ConfigurationAxis, config string, props StaticOrSharedProperties) {
241 if props.Enabled != nil {
242 enabledLabelAttribute.SetSelectValue(axis, config, props.Enabled)
243 }
244 parseSrcs(ctx, axis, config, props.Srcs)
245 }
246
247 if isStatic {
248 bp2BuildPropParseHelper(ctx, module, &StaticProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
249 if staticProperties, ok := props.(*StaticProperties); ok {
250 parseAttrs(axis, config, staticProperties.Static)
251 }
252 })
253 } else {
254 bp2BuildPropParseHelper(ctx, module, &SharedProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
255 if sharedProperties, ok := props.(*SharedProperties); ok {
256 parseAttrs(axis, config, sharedProperties.Shared)
257 }
258 })
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400259 }
260
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400261 return prebuiltAttributes{
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000262 Src: srcLabelAttribute,
263 Enabled: enabledLabelAttribute,
264 }
265}
266
267func bp2BuildPropParseHelper(ctx android.ArchVariantContext, module *Module, propsType interface{}, parseFunc func(axis bazel.ConfigurationAxis, config string, props interface{})) {
268 for axis, configToProps := range module.GetArchVariantProperties(ctx, propsType) {
269 for config, props := range configToProps {
270 parseFunc(axis, config, props)
271 }
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400272 }
273}
274
Liz Kammere6583482021-10-19 13:56:10 -0400275type baseAttributes struct {
276 compilerAttributes
277 linkerAttributes
Liz Kammer12615db2021-09-28 09:19:17 -0400278
279 protoDependency *bazel.LabelAttribute
Liz Kammere6583482021-10-19 13:56:10 -0400280}
281
Jingwen Chen107c0de2021-04-09 10:43:12 +0000282// Convenience struct to hold all attributes parsed from compiler properties.
283type compilerAttributes struct {
Chris Parsons990c4f42021-05-25 12:10:58 -0400284 // Options for all languages
285 copts bazel.StringListAttribute
286 // Assembly options and sources
287 asFlags bazel.StringListAttribute
288 asSrcs bazel.LabelListAttribute
289 // C options and sources
290 conlyFlags bazel.StringListAttribute
291 cSrcs bazel.LabelListAttribute
292 // C++ options and sources
293 cppFlags bazel.StringListAttribute
Jingwen Chened9c17d2021-04-13 07:14:55 +0000294 srcs bazel.LabelListAttribute
Chris Parsons2c788392021-08-10 11:58:07 -0400295
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000296 // Lex sources and options
297 lSrcs bazel.LabelListAttribute
298 llSrcs bazel.LabelListAttribute
299 lexopts bazel.StringListAttribute
300
Liz Kammere6583482021-10-19 13:56:10 -0400301 hdrs bazel.LabelListAttribute
302
Chris Parsons2c788392021-08-10 11:58:07 -0400303 rtti bazel.BoolAttribute
Jingwen Chen5b11ab12021-10-11 17:44:33 +0000304
305 // Not affected by arch variants
306 stl *string
Chris Parsons79bd2b72021-11-29 17:52:41 -0500307 cStd *string
Jingwen Chen5b11ab12021-10-11 17:44:33 +0000308 cppStd *string
Liz Kammer35687bc2021-09-10 10:07:07 -0400309
310 localIncludes bazel.StringListAttribute
311 absoluteIncludes bazel.StringListAttribute
Liz Kammer12615db2021-09-28 09:19:17 -0400312
Liz Kammer1263d9b2021-12-10 14:28:20 -0500313 includes BazelIncludes
314
Liz Kammer12615db2021-09-28 09:19:17 -0400315 protoSrcs bazel.LabelListAttribute
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000316
317 stubsSymbolFile *string
318 stubsVersions bazel.StringListAttribute
Jingwen Chen107c0de2021-04-09 10:43:12 +0000319}
320
Liz Kammercac7f692021-12-16 14:19:32 -0500321type filterOutFn func(string) bool
322
323func filterOutStdFlag(flag string) bool {
324 return strings.HasPrefix(flag, "-std=")
325}
326
327func parseCommandLineFlags(soongFlags []string, filterOut filterOutFn) []string {
Liz Kammere6583482021-10-19 13:56:10 -0400328 var result []string
329 for _, flag := range soongFlags {
Liz Kammercac7f692021-12-16 14:19:32 -0500330 if filterOut != nil && filterOut(flag) {
331 continue
332 }
Liz Kammere6583482021-10-19 13:56:10 -0400333 // Soong's cflags can contain spaces, like `-include header.h`. For
334 // Bazel's copts, split them up to be compatible with the
335 // no_copts_tokenization feature.
336 result = append(result, strings.Split(flag, " ")...)
337 }
338 return result
339}
Jingwen Chened9c17d2021-04-13 07:14:55 +0000340
Jingwen Chen55bc8202021-11-02 06:40:51 +0000341func (ca *compilerAttributes) bp2buildForAxisAndConfig(ctx android.BazelConversionPathContext, axis bazel.ConfigurationAxis, config string, props *BaseCompilerProperties) {
Liz Kammere6583482021-10-19 13:56:10 -0400342 // If there's arch specific srcs or exclude_srcs, generate a select entry for it.
343 // TODO(b/186153868): do this for OS specific srcs and exclude_srcs too.
344 if srcsList, ok := parseSrcs(ctx, props); ok {
345 ca.srcs.SetSelectValue(axis, config, srcsList)
Chris Parsons990c4f42021-05-25 12:10:58 -0400346 }
347
Liz Kammere6583482021-10-19 13:56:10 -0400348 localIncludeDirs := props.Local_include_dirs
349 if axis == bazel.NoConfigAxis {
Chris Parsons79bd2b72021-11-29 17:52:41 -0500350 ca.cStd, ca.cppStd = bp2buildResolveCppStdValue(props.C_std, props.Cpp_std, props.Gnu_extensions)
Liz Kammere6583482021-10-19 13:56:10 -0400351 if includeBuildDirectory(props.Include_build_directory) {
352 localIncludeDirs = append(localIncludeDirs, ".")
Liz Kammer222bdcf2021-10-11 14:15:51 -0400353 }
Jingwen Chene32e9e02021-04-23 09:17:24 +0000354 }
355
Liz Kammere6583482021-10-19 13:56:10 -0400356 ca.absoluteIncludes.SetSelectValue(axis, config, props.Include_dirs)
357 ca.localIncludes.SetSelectValue(axis, config, localIncludeDirs)
358
Liz Kammercac7f692021-12-16 14:19:32 -0500359 // In Soong, cflags occur on the command line before -std=<val> flag, resulting in the value being
360 // overridden. In Bazel we always allow overriding, via flags; however, this can cause
361 // incompatibilities, so we remove "-std=" flags from Cflag properties while leaving it in other
362 // cases.
363 ca.copts.SetSelectValue(axis, config, parseCommandLineFlags(props.Cflags, filterOutStdFlag))
364 ca.asFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Asflags, nil))
365 ca.conlyFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Conlyflags, nil))
366 ca.cppFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Cppflags, nil))
Liz Kammere6583482021-10-19 13:56:10 -0400367 ca.rtti.SetSelectValue(axis, config, props.Rtti)
368}
369
Jingwen Chen55bc8202021-11-02 06:40:51 +0000370func (ca *compilerAttributes) convertStlProps(ctx android.ArchVariantContext, module *Module) {
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000371 bp2BuildPropParseHelper(ctx, module, &StlProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
372 if stlProps, ok := props.(*StlProperties); ok {
373 if stlProps.Stl == nil {
374 return
375 }
376 if ca.stl == nil {
377 ca.stl = stlProps.Stl
378 } else if ca.stl != stlProps.Stl {
379 ctx.ModuleErrorf("Unsupported conversion: module with different stl for different variants: %s and %s", *ca.stl, stlProps.Stl)
Liz Kammer9abd62d2021-05-21 08:37:59 -0400380 }
Jingwen Chenc1c26502021-04-05 10:35:13 +0000381 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000382 })
Liz Kammere6583482021-10-19 13:56:10 -0400383}
Jingwen Chenc1c26502021-04-05 10:35:13 +0000384
Jingwen Chen55bc8202021-11-02 06:40:51 +0000385func (ca *compilerAttributes) convertProductVariables(ctx android.BazelConversionPathContext, productVariableProps android.ProductConfigProperties) {
Liz Kammerba7a9c52021-05-26 08:45:30 -0400386 productVarPropNameToAttribute := map[string]*bazel.StringListAttribute{
Liz Kammere6583482021-10-19 13:56:10 -0400387 "Cflags": &ca.copts,
388 "Asflags": &ca.asFlags,
389 "CppFlags": &ca.cppFlags,
Liz Kammerba7a9c52021-05-26 08:45:30 -0400390 }
Liz Kammerba7a9c52021-05-26 08:45:30 -0400391 for propName, attr := range productVarPropNameToAttribute {
Jingwen Chen25825ca2021-11-15 12:28:43 +0000392 if productConfigProps, exists := productVariableProps[propName]; exists {
393 for productConfigProp, prop := range productConfigProps {
394 flags, ok := prop.([]string)
Liz Kammerba7a9c52021-05-26 08:45:30 -0400395 if !ok {
396 ctx.ModuleErrorf("Could not convert product variable %s property", proptools.PropertyNameForField(propName))
397 }
Jingwen Chen25825ca2021-11-15 12:28:43 +0000398 newFlags, _ := bazel.TryVariableSubstitutions(flags, productConfigProp.Name)
399 attr.SetSelectValue(productConfigProp.ConfigurationAxis(), productConfigProp.SelectKey(), newFlags)
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400400 }
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400401 }
402 }
Liz Kammere6583482021-10-19 13:56:10 -0400403}
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400404
Jingwen Chen55bc8202021-11-02 06:40:51 +0000405func (ca *compilerAttributes) finalize(ctx android.BazelConversionPathContext, implementationHdrs bazel.LabelListAttribute) {
Liz Kammere6583482021-10-19 13:56:10 -0400406 ca.srcs.ResolveExcludes()
407 partitionedSrcs := groupSrcsByExtension(ctx, ca.srcs)
408
Liz Kammer12615db2021-09-28 09:19:17 -0400409 ca.protoSrcs = partitionedSrcs[protoSrcPartition]
410
Liz Kammere6583482021-10-19 13:56:10 -0400411 for p, lla := range partitionedSrcs {
412 // if there are no sources, there is no need for headers
413 if lla.IsEmpty() {
414 continue
415 }
416 lla.Append(implementationHdrs)
417 partitionedSrcs[p] = lla
418 }
419
420 ca.srcs = partitionedSrcs[cppSrcPartition]
421 ca.cSrcs = partitionedSrcs[cSrcPartition]
422 ca.asSrcs = partitionedSrcs[asSrcPartition]
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000423 ca.lSrcs = partitionedSrcs[lSrcPartition]
424 ca.llSrcs = partitionedSrcs[llSrcPartition]
Liz Kammere6583482021-10-19 13:56:10 -0400425
426 ca.absoluteIncludes.DeduplicateAxesFromBase()
427 ca.localIncludes.DeduplicateAxesFromBase()
428}
429
430// Parse srcs from an arch or OS's props value.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000431func parseSrcs(ctx android.BazelConversionPathContext, props *BaseCompilerProperties) (bazel.LabelList, bool) {
Liz Kammere6583482021-10-19 13:56:10 -0400432 anySrcs := false
433 // Add srcs-like dependencies such as generated files.
434 // First create a LabelList containing these dependencies, then merge the values with srcs.
435 generatedSrcsLabelList := android.BazelLabelForModuleDepsExcludes(ctx, props.Generated_sources, props.Exclude_generated_sources)
436 if len(props.Generated_sources) > 0 || len(props.Exclude_generated_sources) > 0 {
437 anySrcs = true
438 }
439
440 allSrcsLabelList := android.BazelLabelForModuleSrcExcludes(ctx, props.Srcs, props.Exclude_srcs)
441 if len(props.Srcs) > 0 || len(props.Exclude_srcs) > 0 {
442 anySrcs = true
443 }
444 return bazel.AppendBazelLabelLists(allSrcsLabelList, generatedSrcsLabelList), anySrcs
445}
446
Chris Parsons79bd2b72021-11-29 17:52:41 -0500447func bp2buildResolveCppStdValue(c_std *string, cpp_std *string, gnu_extensions *bool) (*string, *string) {
448 var cStdVal, cppStdVal string
449 // If c{,pp}std properties are not specified, don't generate them in the BUILD file.
450 // Defaults are handled by the toolchain definition.
451 // However, if gnu_extensions is false, then the default gnu-to-c version must be specified.
Liz Kammere6583482021-10-19 13:56:10 -0400452 if cpp_std != nil {
Chris Parsons79bd2b72021-11-29 17:52:41 -0500453 cppStdVal = parseCppStd(cpp_std)
Liz Kammere6583482021-10-19 13:56:10 -0400454 } else if gnu_extensions != nil && !*gnu_extensions {
Chris Parsons79bd2b72021-11-29 17:52:41 -0500455 cppStdVal = "c++17"
Liz Kammere6583482021-10-19 13:56:10 -0400456 }
Chris Parsons79bd2b72021-11-29 17:52:41 -0500457 if c_std != nil {
458 cStdVal = parseCStd(c_std)
459 } else if gnu_extensions != nil && !*gnu_extensions {
460 cStdVal = "c99"
461 }
462
463 cStdVal, cppStdVal = maybeReplaceGnuToC(gnu_extensions, cStdVal, cppStdVal)
Liz Kammer46fb7ab2021-12-01 10:09:34 -0500464 var c_std_prop, cpp_std_prop *string
465 if cStdVal != "" {
466 c_std_prop = &cStdVal
467 }
468 if cppStdVal != "" {
469 cpp_std_prop = &cppStdVal
470 }
471
472 return c_std_prop, cpp_std_prop
Liz Kammere6583482021-10-19 13:56:10 -0400473}
474
Liz Kammer1263d9b2021-12-10 14:28:20 -0500475// packageFromLabel extracts package from a fully-qualified or relative Label and whether the label
476// is fully-qualified.
477// e.g. fully-qualified "//a/b:foo" -> "a/b", true, relative: ":bar" -> ".", false
478func packageFromLabel(label string) (string, bool) {
479 split := strings.Split(label, ":")
480 if len(split) != 2 {
481 return "", false
482 }
483 if split[0] == "" {
484 return ".", false
485 }
486 // remove leading "//"
487 return split[0][2:], true
488}
489
490// includesFromLabelList extracts relative/absolute includes from a bazel.LabelList>
491func includesFromLabelList(labelList bazel.LabelList) (relative, absolute []string) {
492 for _, hdr := range labelList.Includes {
493 if pkg, hasPkg := packageFromLabel(hdr.Label); hasPkg {
494 absolute = append(absolute, pkg)
495 } else if pkg != "" {
496 relative = append(relative, pkg)
497 }
498 }
499 return relative, absolute
500}
501
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000502// bp2BuildParseBaseProps returns all compiler, linker, library attributes of a cc module..
Liz Kammer12615db2021-09-28 09:19:17 -0400503func bp2BuildParseBaseProps(ctx android.Bp2buildMutatorContext, module *Module) baseAttributes {
Liz Kammere6583482021-10-19 13:56:10 -0400504 archVariantCompilerProps := module.GetArchVariantProperties(ctx, &BaseCompilerProperties{})
505 archVariantLinkerProps := module.GetArchVariantProperties(ctx, &BaseLinkerProperties{})
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000506 archVariantLibraryProperties := module.GetArchVariantProperties(ctx, &LibraryProperties{})
Liz Kammere6583482021-10-19 13:56:10 -0400507
508 var implementationHdrs bazel.LabelListAttribute
509
510 axisToConfigs := map[bazel.ConfigurationAxis]map[string]bool{}
511 allAxesAndConfigs := func(cp android.ConfigurationAxisToArchVariantProperties) {
512 for axis, configMap := range cp {
513 if _, ok := axisToConfigs[axis]; !ok {
514 axisToConfigs[axis] = map[string]bool{}
515 }
516 for config, _ := range configMap {
517 axisToConfigs[axis][config] = true
Chris Parsonsa967f252021-09-23 16:34:35 -0400518 }
519 }
520 }
Liz Kammere6583482021-10-19 13:56:10 -0400521 allAxesAndConfigs(archVariantCompilerProps)
522 allAxesAndConfigs(archVariantLinkerProps)
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000523 allAxesAndConfigs(archVariantLibraryProperties)
Chris Parsonsa967f252021-09-23 16:34:35 -0400524
Liz Kammere6583482021-10-19 13:56:10 -0400525 compilerAttrs := compilerAttributes{}
526 linkerAttrs := linkerAttributes{}
527
528 for axis, configs := range axisToConfigs {
529 for config, _ := range configs {
530 var allHdrs []string
531 if baseCompilerProps, ok := archVariantCompilerProps[axis][config].(*BaseCompilerProperties); ok {
532 allHdrs = baseCompilerProps.Generated_headers
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000533 if baseCompilerProps.Lex != nil {
534 compilerAttrs.lexopts.SetSelectValue(axis, config, baseCompilerProps.Lex.Flags)
535 }
Liz Kammere6583482021-10-19 13:56:10 -0400536 (&compilerAttrs).bp2buildForAxisAndConfig(ctx, axis, config, baseCompilerProps)
537 }
538
539 var exportHdrs []string
540
541 if baseLinkerProps, ok := archVariantLinkerProps[axis][config].(*BaseLinkerProperties); ok {
542 exportHdrs = baseLinkerProps.Export_generated_headers
543
544 (&linkerAttrs).bp2buildForAxisAndConfig(ctx, module.Binary(), axis, config, baseLinkerProps)
545 }
546 headers := maybePartitionExportedAndImplementationsDeps(ctx, !module.Binary(), allHdrs, exportHdrs, android.BazelLabelForModuleDeps)
547 implementationHdrs.SetSelectValue(axis, config, headers.implementation)
548 compilerAttrs.hdrs.SetSelectValue(axis, config, headers.export)
Liz Kammer1263d9b2021-12-10 14:28:20 -0500549
550 exportIncludes, exportAbsoluteIncludes := includesFromLabelList(headers.export)
551 compilerAttrs.includes.Includes.SetSelectValue(axis, config, exportIncludes)
552 compilerAttrs.includes.AbsoluteIncludes.SetSelectValue(axis, config, exportAbsoluteIncludes)
553
554 includes, absoluteIncludes := includesFromLabelList(headers.implementation)
555 currAbsoluteIncludes := compilerAttrs.absoluteIncludes.SelectValue(axis, config)
556 currAbsoluteIncludes = android.FirstUniqueStrings(append(currAbsoluteIncludes, absoluteIncludes...))
557 compilerAttrs.absoluteIncludes.SetSelectValue(axis, config, currAbsoluteIncludes)
558 currIncludes := compilerAttrs.localIncludes.SelectValue(axis, config)
559 currIncludes = android.FirstUniqueStrings(append(currIncludes, includes...))
560 compilerAttrs.localIncludes.SetSelectValue(axis, config, currIncludes)
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000561
562 if libraryProps, ok := archVariantLibraryProperties[axis][config].(*LibraryProperties); ok {
563 if axis == bazel.NoConfigAxis {
564 compilerAttrs.stubsSymbolFile = libraryProps.Stubs.Symbol_file
565 compilerAttrs.stubsVersions.SetSelectValue(axis, config, libraryProps.Stubs.Versions)
566 }
567 }
Liz Kammere6583482021-10-19 13:56:10 -0400568 }
569 }
570
571 compilerAttrs.convertStlProps(ctx, module)
572 (&linkerAttrs).convertStripProps(ctx, module)
573
574 productVariableProps := android.ProductVariableProperties(ctx)
575
576 (&compilerAttrs).convertProductVariables(ctx, productVariableProps)
577 (&linkerAttrs).convertProductVariables(ctx, productVariableProps)
578
579 (&compilerAttrs).finalize(ctx, implementationHdrs)
Liz Kammer54309532021-12-14 12:21:22 -0500580 (&linkerAttrs).finalize(ctx)
Liz Kammere6583482021-10-19 13:56:10 -0400581
Liz Kammer12615db2021-09-28 09:19:17 -0400582 protoDep := bp2buildProto(ctx, module, compilerAttrs.protoSrcs)
583
584 // bp2buildProto will only set wholeStaticLib or implementationWholeStaticLib, but we don't know
585 // which. This will add the newly generated proto library to the appropriate attribute and nothing
586 // to the other
587 (&linkerAttrs).wholeArchiveDeps.Add(protoDep.wholeStaticLib)
588 (&linkerAttrs).implementationWholeArchiveDeps.Add(protoDep.implementationWholeStaticLib)
589
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000590 convertedLSrcs := bp2BuildLex(ctx, module.Name(), compilerAttrs)
591 (&compilerAttrs).srcs.Add(&convertedLSrcs.srcName)
592 (&compilerAttrs).cSrcs.Add(&convertedLSrcs.cSrcName)
593
Liz Kammere6583482021-10-19 13:56:10 -0400594 return baseAttributes{
595 compilerAttrs,
596 linkerAttrs,
Liz Kammer12615db2021-09-28 09:19:17 -0400597 protoDep.protoDep,
Jingwen Chen107c0de2021-04-09 10:43:12 +0000598 }
599}
600
Yu Liufc603162022-03-01 15:44:08 -0800601func bp2BuildParseSdkAttributes(module *Module) sdkAttributes {
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000602 return sdkAttributes{
603 Sdk_version: module.Properties.Sdk_version,
Yu Liufc603162022-03-01 15:44:08 -0800604 Min_sdk_version: module.Properties.Min_sdk_version,
605 }
606}
607
608type sdkAttributes struct {
609 Sdk_version *string
610 Min_sdk_version *string
611}
612
Jingwen Chen107c0de2021-04-09 10:43:12 +0000613// Convenience struct to hold all attributes parsed from linker properties.
614type linkerAttributes struct {
Liz Kammer54309532021-12-14 12:21:22 -0500615 deps bazel.LabelListAttribute
616 implementationDeps bazel.LabelListAttribute
617 dynamicDeps bazel.LabelListAttribute
618 implementationDynamicDeps bazel.LabelListAttribute
619 wholeArchiveDeps bazel.LabelListAttribute
620 implementationWholeArchiveDeps bazel.LabelListAttribute
621 systemDynamicDeps bazel.LabelListAttribute
622 usedSystemDynamicDepAsDynamicDep map[string]bool
Liz Kammer7a210ac2021-09-22 15:52:58 -0400623
Jingwen Chen6ada5892021-09-17 11:38:09 +0000624 linkCrt bazel.BoolAttribute
Jingwen Chen3d383bb2021-06-09 07:18:37 +0000625 useLibcrt bazel.BoolAttribute
Rupert Shuttleworth484aa252021-12-10 07:22:53 -0500626 useVersionLib bazel.BoolAttribute
Jingwen Chen3d383bb2021-06-09 07:18:37 +0000627 linkopts bazel.StringListAttribute
Liz Kammerd2871182021-10-04 13:54:37 -0400628 additionalLinkerInputs bazel.LabelListAttribute
Jingwen Chen3d383bb2021-06-09 07:18:37 +0000629 stripKeepSymbols bazel.BoolAttribute
630 stripKeepSymbolsAndDebugFrame bazel.BoolAttribute
631 stripKeepSymbolsList bazel.StringListAttribute
632 stripAll bazel.BoolAttribute
633 stripNone bazel.BoolAttribute
Liz Kammer0eae52e2021-10-06 10:32:26 -0400634 features bazel.StringListAttribute
Rupert Shuttleworth143be942021-05-09 23:55:51 -0400635}
636
Liz Kammer54309532021-12-14 12:21:22 -0500637var (
638 soongSystemSharedLibs = []string{"libc", "libm", "libdl"}
639)
640
Jingwen Chen55bc8202021-11-02 06:40:51 +0000641func (la *linkerAttributes) bp2buildForAxisAndConfig(ctx android.BazelConversionPathContext, isBinary bool, axis bazel.ConfigurationAxis, config string, props *BaseLinkerProperties) {
Liz Kammere6583482021-10-19 13:56:10 -0400642 // Use a single variable to capture usage of nocrt in arch variants, so there's only 1 error message for this module
643 var axisFeatures []string
Liz Kammer7a210ac2021-09-22 15:52:58 -0400644
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400645 wholeStaticLibs := android.FirstUniqueStrings(props.Whole_static_libs)
646 la.wholeArchiveDeps.SetSelectValue(axis, config, bazelLabelForWholeDepsExcludes(ctx, wholeStaticLibs, props.Exclude_static_libs))
Liz Kammere6583482021-10-19 13:56:10 -0400647 // Excludes to parallel Soong:
648 // https://cs.android.com/android/platform/superproject/+/master:build/soong/cc/linker.go;l=247-249;drc=088b53577dde6e40085ffd737a1ae96ad82fc4b0
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400649 staticLibs := android.FirstUniqueStrings(android.RemoveListFromList(props.Static_libs, wholeStaticLibs))
650
Liz Kammere6583482021-10-19 13:56:10 -0400651 staticDeps := maybePartitionExportedAndImplementationsDepsExcludes(ctx, !isBinary, staticLibs, props.Exclude_static_libs, props.Export_static_lib_headers, bazelLabelForStaticDepsExcludes)
Liz Kammer7a210ac2021-09-22 15:52:58 -0400652
Liz Kammere6583482021-10-19 13:56:10 -0400653 headerLibs := android.FirstUniqueStrings(props.Header_libs)
654 hDeps := maybePartitionExportedAndImplementationsDeps(ctx, !isBinary, headerLibs, props.Export_header_lib_headers, bazelLabelForHeaderDeps)
Jingwen Chen63930982021-03-24 10:04:33 -0400655
Liz Kammere6583482021-10-19 13:56:10 -0400656 (&hDeps.export).Append(staticDeps.export)
657 la.deps.SetSelectValue(axis, config, hDeps.export)
Jingwen Chen3d383bb2021-06-09 07:18:37 +0000658
Liz Kammere6583482021-10-19 13:56:10 -0400659 (&hDeps.implementation).Append(staticDeps.implementation)
660 la.implementationDeps.SetSelectValue(axis, config, hDeps.implementation)
Liz Kammer0eae52e2021-10-06 10:32:26 -0400661
Liz Kammere6583482021-10-19 13:56:10 -0400662 systemSharedLibs := props.System_shared_libs
663 // systemSharedLibs distinguishes between nil/empty list behavior:
664 // nil -> use default values
665 // empty list -> no values specified
666 if len(systemSharedLibs) > 0 {
667 systemSharedLibs = android.FirstUniqueStrings(systemSharedLibs)
668 }
669 la.systemDynamicDeps.SetSelectValue(axis, config, bazelLabelForSharedDeps(ctx, systemSharedLibs))
670
671 sharedLibs := android.FirstUniqueStrings(props.Shared_libs)
Liz Kammer54309532021-12-14 12:21:22 -0500672 excludeSharedLibs := props.Exclude_shared_libs
673 usedSystem := android.FilterListPred(sharedLibs, func(s string) bool {
674 return android.InList(s, soongSystemSharedLibs) && !android.InList(s, excludeSharedLibs)
675 })
676 for _, el := range usedSystem {
677 if la.usedSystemDynamicDepAsDynamicDep == nil {
678 la.usedSystemDynamicDepAsDynamicDep = map[string]bool{}
679 }
680 la.usedSystemDynamicDepAsDynamicDep[el] = true
681 }
682
Liz Kammere6583482021-10-19 13:56:10 -0400683 sharedDeps := maybePartitionExportedAndImplementationsDepsExcludes(ctx, !isBinary, sharedLibs, props.Exclude_shared_libs, props.Export_shared_lib_headers, bazelLabelForSharedDepsExcludes)
684 la.dynamicDeps.SetSelectValue(axis, config, sharedDeps.export)
685 la.implementationDynamicDeps.SetSelectValue(axis, config, sharedDeps.implementation)
686
687 if !BoolDefault(props.Pack_relocations, packRelocationsDefault) {
688 axisFeatures = append(axisFeatures, "disable_pack_relocations")
689 }
690
691 if Bool(props.Allow_undefined_symbols) {
692 axisFeatures = append(axisFeatures, "-no_undefined_symbols")
693 }
694
695 var linkerFlags []string
696 if len(props.Ldflags) > 0 {
Liz Kammerf38a8372022-02-04 15:39:00 -0500697 linkerFlags = append(linkerFlags, proptools.NinjaEscapeList(props.Ldflags)...)
Liz Kammere6583482021-10-19 13:56:10 -0400698 // binaries remove static flag if -shared is in the linker flags
699 if isBinary && android.InList("-shared", linkerFlags) {
700 axisFeatures = append(axisFeatures, "-static_flag")
701 }
702 }
703 if props.Version_script != nil {
704 label := android.BazelLabelForModuleSrcSingle(ctx, *props.Version_script)
705 la.additionalLinkerInputs.SetSelectValue(axis, config, bazel.LabelList{Includes: []bazel.Label{label}})
706 linkerFlags = append(linkerFlags, fmt.Sprintf("-Wl,--version-script,$(location %s)", label.Label))
707 }
Alix773adaa2022-04-27 17:49:34 +0000708
709 if props.Dynamic_list != nil {
710 label := android.BazelLabelForModuleSrcSingle(ctx, *props.Dynamic_list)
711 la.additionalLinkerInputs.SetSelectValue(axis, config, bazel.LabelList{Includes: []bazel.Label{label}})
712 linkerFlags = append(linkerFlags, fmt.Sprintf("-Wl,--dynamic-list,$(location %s)", label.Label))
713 }
714
Liz Kammere6583482021-10-19 13:56:10 -0400715 la.linkopts.SetSelectValue(axis, config, linkerFlags)
716 la.useLibcrt.SetSelectValue(axis, config, props.libCrt())
717
Rupert Shuttleworth484aa252021-12-10 07:22:53 -0500718 if axis == bazel.NoConfigAxis {
719 la.useVersionLib.SetSelectValue(axis, config, props.Use_version_lib)
720 }
721
Liz Kammere6583482021-10-19 13:56:10 -0400722 // it's very unlikely for nocrt to be arch variant, so bp2build doesn't support it.
723 if props.crt() != nil {
724 if axis == bazel.NoConfigAxis {
725 la.linkCrt.SetSelectValue(axis, config, props.crt())
726 } else if axis == bazel.ArchConfigurationAxis {
727 ctx.ModuleErrorf("nocrt is not supported for arch variants")
728 }
729 }
730
731 if axisFeatures != nil {
732 la.features.SetSelectValue(axis, config, axisFeatures)
733 }
734}
735
Jingwen Chen55bc8202021-11-02 06:40:51 +0000736func (la *linkerAttributes) convertStripProps(ctx android.BazelConversionPathContext, module *Module) {
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000737 bp2BuildPropParseHelper(ctx, module, &StripProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
738 if stripProperties, ok := props.(*StripProperties); ok {
739 la.stripKeepSymbols.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols)
740 la.stripKeepSymbolsList.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols_list)
741 la.stripKeepSymbolsAndDebugFrame.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols_and_debug_frame)
742 la.stripAll.SetSelectValue(axis, config, stripProperties.Strip.All)
743 la.stripNone.SetSelectValue(axis, config, stripProperties.Strip.None)
Jingwen Chen3d383bb2021-06-09 07:18:37 +0000744 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000745 })
Liz Kammere6583482021-10-19 13:56:10 -0400746}
Jingwen Chen3d383bb2021-06-09 07:18:37 +0000747
Jingwen Chen55bc8202021-11-02 06:40:51 +0000748func (la *linkerAttributes) convertProductVariables(ctx android.BazelConversionPathContext, productVariableProps android.ProductConfigProperties) {
Jingwen Chen6ada5892021-09-17 11:38:09 +0000749
Liz Kammer47535c52021-06-02 16:02:22 -0400750 type productVarDep struct {
751 // the name of the corresponding excludes field, if one exists
752 excludesField string
753 // reference to the bazel attribute that should be set for the given product variable config
754 attribute *bazel.LabelListAttribute
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400755
Jingwen Chen55bc8202021-11-02 06:40:51 +0000756 depResolutionFunc func(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList
Liz Kammer47535c52021-06-02 16:02:22 -0400757 }
758
759 productVarToDepFields := map[string]productVarDep{
760 // product variables do not support exclude_shared_libs
Jingwen Chen55bc8202021-11-02 06:40:51 +0000761 "Shared_libs": {attribute: &la.implementationDynamicDeps, depResolutionFunc: bazelLabelForSharedDepsExcludes},
762 "Static_libs": {"Exclude_static_libs", &la.implementationDeps, bazelLabelForStaticDepsExcludes},
763 "Whole_static_libs": {"Exclude_static_libs", &la.wholeArchiveDeps, bazelLabelForWholeDepsExcludes},
Liz Kammer47535c52021-06-02 16:02:22 -0400764 }
765
Liz Kammer47535c52021-06-02 16:02:22 -0400766 for name, dep := range productVarToDepFields {
767 props, exists := productVariableProps[name]
768 excludeProps, excludesExists := productVariableProps[dep.excludesField]
769 // if neither an include or excludes property exists, then skip it
770 if !exists && !excludesExists {
771 continue
772 }
Jingwen Chen25825ca2021-11-15 12:28:43 +0000773 // Collect all the configurations that an include or exclude property exists for.
774 // We want to iterate all configurations rather than either the include or exclude because, for a
775 // particular configuration, we may have either only an include or an exclude to handle.
776 productConfigProps := make(map[android.ProductConfigProperty]bool, len(props)+len(excludeProps))
777 for p := range props {
778 productConfigProps[p] = true
Liz Kammer47535c52021-06-02 16:02:22 -0400779 }
Jingwen Chen25825ca2021-11-15 12:28:43 +0000780 for p := range excludeProps {
781 productConfigProps[p] = true
Liz Kammer47535c52021-06-02 16:02:22 -0400782 }
783
Jingwen Chen25825ca2021-11-15 12:28:43 +0000784 for productConfigProp := range productConfigProps {
785 prop, includesExists := props[productConfigProp]
786 excludesProp, excludesExists := excludeProps[productConfigProp]
Liz Kammer47535c52021-06-02 16:02:22 -0400787 var includes, excludes []string
788 var ok bool
789 // if there was no includes/excludes property, casting fails and that's expected
Jingwen Chen25825ca2021-11-15 12:28:43 +0000790 if includes, ok = prop.([]string); includesExists && !ok {
Liz Kammer47535c52021-06-02 16:02:22 -0400791 ctx.ModuleErrorf("Could not convert product variable %s property", name)
792 }
Jingwen Chen25825ca2021-11-15 12:28:43 +0000793 if excludes, ok = excludesProp.([]string); excludesExists && !ok {
Liz Kammer47535c52021-06-02 16:02:22 -0400794 ctx.ModuleErrorf("Could not convert product variable %s property", dep.excludesField)
795 }
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400796
Jingwen Chen58ff6802021-11-17 12:14:41 +0000797 dep.attribute.EmitEmptyList = productConfigProp.AlwaysEmit()
Jingwen Chen25825ca2021-11-15 12:28:43 +0000798 dep.attribute.SetSelectValue(
799 productConfigProp.ConfigurationAxis(),
800 productConfigProp.SelectKey(),
801 dep.depResolutionFunc(ctx, android.FirstUniqueStrings(includes), excludes),
802 )
Liz Kammer47535c52021-06-02 16:02:22 -0400803 }
804 }
Liz Kammere6583482021-10-19 13:56:10 -0400805}
Liz Kammer47535c52021-06-02 16:02:22 -0400806
Liz Kammer54309532021-12-14 12:21:22 -0500807func (la *linkerAttributes) finalize(ctx android.BazelConversionPathContext) {
808 // if system dynamic deps have the default value, any use of a system dynamic library used will
809 // result in duplicate library errors for bionic OSes. Here, we explicitly exclude those libraries
810 // from bionic OSes.
811 if la.systemDynamicDeps.IsNil() && len(la.usedSystemDynamicDepAsDynamicDep) > 0 {
812 toRemove := bazelLabelForSharedDeps(ctx, android.SortedStringKeys(la.usedSystemDynamicDepAsDynamicDep))
813 la.dynamicDeps.Exclude(bazel.OsConfigurationAxis, "android", toRemove)
814 la.dynamicDeps.Exclude(bazel.OsConfigurationAxis, "linux_bionic", toRemove)
815 la.implementationDynamicDeps.Exclude(bazel.OsConfigurationAxis, "android", toRemove)
816 la.implementationDynamicDeps.Exclude(bazel.OsConfigurationAxis, "linux_bionic", toRemove)
817 }
818
Liz Kammere6583482021-10-19 13:56:10 -0400819 la.deps.ResolveExcludes()
820 la.implementationDeps.ResolveExcludes()
821 la.dynamicDeps.ResolveExcludes()
822 la.implementationDynamicDeps.ResolveExcludes()
823 la.wholeArchiveDeps.ResolveExcludes()
824 la.systemDynamicDeps.ForceSpecifyEmptyList = true
Liz Kammer54309532021-12-14 12:21:22 -0500825
Jingwen Chen91220d72021-03-24 02:18:33 -0400826}
827
Jingwen Chened9c17d2021-04-13 07:14:55 +0000828// Relativize a list of root-relative paths with respect to the module's
829// directory.
830//
831// include_dirs Soong prop are root-relative (b/183742505), but
832// local_include_dirs, export_include_dirs and export_system_include_dirs are
833// module dir relative. This function makes a list of paths entirely module dir
834// relative.
835//
836// For the `include` attribute, Bazel wants the paths to be relative to the
837// module.
838func bp2BuildMakePathsRelativeToModule(ctx android.BazelConversionPathContext, paths []string) []string {
Rupert Shuttleworthb8151682021-04-06 20:06:21 +0000839 var relativePaths []string
840 for _, path := range paths {
Jingwen Chened9c17d2021-04-13 07:14:55 +0000841 // Semantics of filepath.Rel: join(ModuleDir, rel(ModuleDir, path)) == path
842 relativePath, err := filepath.Rel(ctx.ModuleDir(), path)
843 if err != nil {
844 panic(err)
845 }
Rupert Shuttleworthb8151682021-04-06 20:06:21 +0000846 relativePaths = append(relativePaths, relativePath)
847 }
848 return relativePaths
849}
850
Liz Kammer5fad5012021-09-09 14:08:21 -0400851// BazelIncludes contains information about -I and -isystem paths from a module converted to Bazel
852// attributes.
853type BazelIncludes struct {
Liz Kammer1263d9b2021-12-10 14:28:20 -0500854 AbsoluteIncludes bazel.StringListAttribute
855 Includes bazel.StringListAttribute
856 SystemIncludes bazel.StringListAttribute
Liz Kammer5fad5012021-09-09 14:08:21 -0400857}
858
Liz Kammer54549442022-05-11 13:55:06 -0400859func bp2BuildParseExportedIncludes(ctx android.BazelConversionPathContext, module *Module, includes *BazelIncludes) BazelIncludes {
Liz Kammer1263d9b2021-12-10 14:28:20 -0500860 var exported BazelIncludes
861 if includes != nil {
862 exported = *includes
863 } else {
864 exported = BazelIncludes{}
865 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000866 bp2BuildPropParseHelper(ctx, module, &FlagExporterProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
867 if flagExporterProperties, ok := props.(*FlagExporterProperties); ok {
868 if len(flagExporterProperties.Export_include_dirs) > 0 {
869 exported.Includes.SetSelectValue(axis, config, android.FirstUniqueStrings(append(exported.Includes.SelectValue(axis, config), flagExporterProperties.Export_include_dirs...)))
870 }
871 if len(flagExporterProperties.Export_system_include_dirs) > 0 {
872 exported.SystemIncludes.SetSelectValue(axis, config, android.FirstUniqueStrings(append(exported.SystemIncludes.SelectValue(axis, config), flagExporterProperties.Export_system_include_dirs...)))
Rupert Shuttleworth375451e2021-04-26 07:49:08 -0400873 }
Rupert Shuttleworth375451e2021-04-26 07:49:08 -0400874 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000875 })
Liz Kammer1263d9b2021-12-10 14:28:20 -0500876 exported.AbsoluteIncludes.DeduplicateAxesFromBase()
Liz Kammer5fad5012021-09-09 14:08:21 -0400877 exported.Includes.DeduplicateAxesFromBase()
878 exported.SystemIncludes.DeduplicateAxesFromBase()
Rupert Shuttleworth375451e2021-04-26 07:49:08 -0400879
Liz Kammer5fad5012021-09-09 14:08:21 -0400880 return exported
Jingwen Chen91220d72021-03-24 02:18:33 -0400881}
Chris Parsons953b3562021-09-20 15:14:39 -0400882
Jingwen Chen55bc8202021-11-02 06:40:51 +0000883func bazelLabelForStaticModule(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -0400884 label := android.BazelModuleLabel(ctx, m)
Liz Kammer35ca77e2021-12-22 15:31:40 -0500885 if ccModule, ok := m.(*Module); ok && ccModule.typ() == fullLibrary && !android.GenerateCcLibraryStaticOnly(m.Name()) {
886 label += "_bp2build_cc_library_static"
Chris Parsons953b3562021-09-20 15:14:39 -0400887 }
888 return label
889}
890
Jingwen Chen55bc8202021-11-02 06:40:51 +0000891func bazelLabelForSharedModule(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -0400892 // cc_library, at it's root name, propagates the shared library, which depends on the static
893 // library.
894 return android.BazelModuleLabel(ctx, m)
895}
896
Jingwen Chen55bc8202021-11-02 06:40:51 +0000897func bazelLabelForStaticWholeModuleDeps(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -0400898 label := bazelLabelForStaticModule(ctx, m)
899 if aModule, ok := m.(android.Module); ok {
900 if android.IsModulePrebuilt(aModule) {
901 label += "_alwayslink"
902 }
903 }
904 return label
905}
906
Jingwen Chen55bc8202021-11-02 06:40:51 +0000907func bazelLabelForWholeDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -0400908 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForStaticWholeModuleDeps)
909}
910
Jingwen Chen55bc8202021-11-02 06:40:51 +0000911func bazelLabelForWholeDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -0400912 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForStaticWholeModuleDeps)
913}
914
Jingwen Chen55bc8202021-11-02 06:40:51 +0000915func bazelLabelForStaticDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -0400916 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForStaticModule)
917}
918
Jingwen Chen55bc8202021-11-02 06:40:51 +0000919func bazelLabelForStaticDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -0400920 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForStaticModule)
921}
922
Jingwen Chen55bc8202021-11-02 06:40:51 +0000923func bazelLabelForSharedDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -0400924 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForSharedModule)
925}
926
Jingwen Chen55bc8202021-11-02 06:40:51 +0000927func bazelLabelForHeaderDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -0400928 // This is not elegant, but bp2build's shared library targets only propagate
929 // their header information as part of the normal C++ provider.
930 return bazelLabelForSharedDeps(ctx, modules)
931}
932
Jingwen Chen55bc8202021-11-02 06:40:51 +0000933func bazelLabelForSharedDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -0400934 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForSharedModule)
935}
Liz Kammer2b8004b2021-10-04 13:55:44 -0400936
937type binaryLinkerAttrs struct {
938 Linkshared *bool
939}
940
Jingwen Chen55bc8202021-11-02 06:40:51 +0000941func bp2buildBinaryLinkerProps(ctx android.BazelConversionPathContext, m *Module) binaryLinkerAttrs {
Liz Kammer2b8004b2021-10-04 13:55:44 -0400942 attrs := binaryLinkerAttrs{}
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000943 bp2BuildPropParseHelper(ctx, m, &BinaryLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
944 linkerProps := props.(*BinaryLinkerProperties)
945 staticExecutable := linkerProps.Static_executable
946 if axis == bazel.NoConfigAxis {
947 if linkBinaryShared := !proptools.Bool(staticExecutable); !linkBinaryShared {
948 attrs.Linkshared = &linkBinaryShared
Liz Kammer2b8004b2021-10-04 13:55:44 -0400949 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000950 } else if staticExecutable != nil {
951 // TODO(b/202876379): Static_executable is arch-variant; however, linkshared is a
952 // nonconfigurable attribute. Only 4 AOSP modules use this feature, defer handling
953 ctx.ModuleErrorf("bp2build cannot migrate a module with arch/target-specific static_executable values")
Liz Kammer2b8004b2021-10-04 13:55:44 -0400954 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000955 })
Liz Kammer2b8004b2021-10-04 13:55:44 -0400956
957 return attrs
958}