blob: 7c817a2b10d55b79ec9b113a76681a4dc7ccbe3f [file] [log] [blame]
Jingwen Chen91220d72021-03-24 02:18:33 -04001// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
Cole Faust7071a052022-07-29 15:58:33 -07007// http://www.apache.org/licenses/LICENSE-2.0
Jingwen Chen91220d72021-03-24 02:18:33 -04008//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14package cc
15
16import (
Liz Kammerd2871182021-10-04 13:54:37 -040017 "fmt"
Jingwen Chened9c17d2021-04-13 07:14:55 +000018 "path/filepath"
Jingwen Chen3950cd62021-05-12 04:33:00 +000019 "strings"
Chris Parsons484e50a2021-05-13 15:13:04 -040020
21 "android/soong/android"
22 "android/soong/bazel"
Alix1be00d42022-05-16 22:56:04 +000023 "android/soong/cc/config"
Liz Kammer7a210ac2021-09-22 15:52:58 -040024
Chris Parsons953b3562021-09-20 15:14:39 -040025 "github.com/google/blueprint"
Liz Kammerba7a9c52021-05-26 08:45:30 -040026
27 "github.com/google/blueprint/proptools"
Jingwen Chen91220d72021-03-24 02:18:33 -040028)
29
Liz Kammerae3994e2021-10-19 09:45:48 -040030const (
Trevor Radcliffecee4e052022-09-06 19:31:25 +000031 cSrcPartition = "c"
32 asSrcPartition = "as"
33 asmSrcPartition = "asm"
34 lSrcPartition = "l"
35 llSrcPartition = "ll"
36 cppSrcPartition = "cpp"
37 protoSrcPartition = "proto"
38 aidlSrcPartition = "aidl"
39 syspropSrcPartition = "sysprop"
Liz Kammer91487d42022-09-13 11:27:11 -040040
41 stubsSuffix = "_stub_libs_current"
Liz Kammerae3994e2021-10-19 09:45:48 -040042)
43
Liz Kammer2222c6b2021-05-24 15:41:47 -040044// staticOrSharedAttributes are the Bazel-ified versions of StaticOrSharedProperties --
Jingwen Chenbcf53042021-05-26 04:42:42 +000045// properties which apply to either the shared or static version of a cc_library module.
Liz Kammer2222c6b2021-05-24 15:41:47 -040046type staticOrSharedAttributes struct {
Vinh Tran9f6796a2022-08-16 13:10:31 -040047 Srcs bazel.LabelListAttribute
48 Srcs_c bazel.LabelListAttribute
49 Srcs_as bazel.LabelListAttribute
50 Srcs_aidl bazel.LabelListAttribute
51 Hdrs bazel.LabelListAttribute
52 Copts bazel.StringListAttribute
Jingwen Chen14a8bda2021-06-02 11:10:02 +000053
Liz Kammer12615db2021-09-28 09:19:17 -040054 Deps bazel.LabelListAttribute
55 Implementation_deps bazel.LabelListAttribute
56 Dynamic_deps bazel.LabelListAttribute
57 Implementation_dynamic_deps bazel.LabelListAttribute
58 Whole_archive_deps bazel.LabelListAttribute
59 Implementation_whole_archive_deps bazel.LabelListAttribute
Cole Faust6b29f592022-08-09 09:50:56 -070060 Runtime_deps bazel.LabelListAttribute
Chris Parsons51f8c392021-08-03 21:01:05 -040061
62 System_dynamic_deps bazel.LabelListAttribute
Chris Parsons58852a02021-12-09 18:10:18 -050063
64 Enabled bazel.BoolAttribute
Yu Liufc603162022-03-01 15:44:08 -080065
Yu Liuf01a0f02022-12-07 15:45:30 -080066 Native_coverage *bool
Yu Liu8d82ac52022-05-17 15:13:28 -070067
Liz Kammeraceec252023-03-24 09:46:36 -040068 Apex_available []string
69
Yu Liufc603162022-03-01 15:44:08 -080070 sdkAttributes
Sam Delmericofb3bb322022-10-21 10:42:24 -040071
72 tidyAttributes
73}
74
75type tidyAttributes struct {
Sam Delmerico63f0c932023-03-14 14:05:28 -040076 Tidy *string
Sam Delmericofb3bb322022-10-21 10:42:24 -040077 Tidy_flags []string
78 Tidy_checks []string
79 Tidy_checks_as_errors []string
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -040080 Tidy_disabled_srcs bazel.LabelListAttribute
Sam Delmerico4c902d62022-11-02 14:17:15 -040081 Tidy_timeout_srcs bazel.LabelListAttribute
Sam Delmericofb3bb322022-10-21 10:42:24 -040082}
83
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -040084func (m *Module) convertTidyAttributes(ctx android.BaseMutatorContext, moduleAttrs *tidyAttributes) {
Sam Delmericofb3bb322022-10-21 10:42:24 -040085 for _, f := range m.features {
86 if tidy, ok := f.(*tidyFeature); ok {
Sam Delmerico63f0c932023-03-14 14:05:28 -040087 var tidyAttr *string
88 if tidy.Properties.Tidy != nil {
89 if *tidy.Properties.Tidy {
90 tidyAttr = proptools.StringPtr("local")
91 } else {
92 tidyAttr = proptools.StringPtr("never")
93 }
94 }
95 moduleAttrs.Tidy = tidyAttr
Sam Delmericofb3bb322022-10-21 10:42:24 -040096 moduleAttrs.Tidy_flags = tidy.Properties.Tidy_flags
97 moduleAttrs.Tidy_checks = tidy.Properties.Tidy_checks
98 moduleAttrs.Tidy_checks_as_errors = tidy.Properties.Tidy_checks_as_errors
99 }
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400100
101 }
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400102 archVariantProps := m.GetArchVariantProperties(ctx, &BaseCompilerProperties{})
103 for axis, configToProps := range archVariantProps {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800104 for cfg, _props := range configToProps {
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400105 if archProps, ok := _props.(*BaseCompilerProperties); ok {
106 archDisabledSrcs := android.BazelLabelForModuleSrc(ctx, archProps.Tidy_disabled_srcs)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800107 moduleAttrs.Tidy_disabled_srcs.SetSelectValue(axis, cfg, archDisabledSrcs)
Sam Delmerico4c902d62022-11-02 14:17:15 -0400108 archTimeoutSrcs := android.BazelLabelForModuleSrc(ctx, archProps.Tidy_timeout_srcs)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800109 moduleAttrs.Tidy_timeout_srcs.SetSelectValue(axis, cfg, archTimeoutSrcs)
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400110 }
111 }
Sam Delmericofb3bb322022-10-21 10:42:24 -0400112 }
Jingwen Chen53681ef2021-04-29 08:15:13 +0000113}
114
Sam Delmericoc7681022022-02-04 21:01:20 +0000115// groupSrcsByExtension partitions `srcs` into groups based on file extension.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000116func groupSrcsByExtension(ctx android.BazelConversionPathContext, srcs bazel.LabelListAttribute) bazel.PartitionToLabelListAttribute {
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400117 // Convert filegroup dependencies into extension-specific filegroups filtered in the filegroup.bzl
118 // macro.
119 addSuffixForFilegroup := func(suffix string) bazel.LabelMapper {
Vinh Tran9f6796a2022-08-16 13:10:31 -0400120 return func(otherModuleCtx bazel.OtherModuleContext, label bazel.Label) (string, bool) {
121
122 m, exists := otherModuleCtx.ModuleFromName(label.OriginalModuleName)
Liz Kammer12615db2021-09-28 09:19:17 -0400123 labelStr := label.Label
Vinh Tran9f6796a2022-08-16 13:10:31 -0400124 if !exists || !android.IsFilegroup(otherModuleCtx, m) {
125 return labelStr, false
126 }
Yu Liu2aa806b2022-09-01 11:54:47 -0700127 // If the filegroup is already converted to aidl_library or proto_library,
128 // skip creating _c_srcs, _as_srcs, _cpp_srcs filegroups
129 fg, _ := m.(android.FileGroupAsLibrary)
130 if fg.ShouldConvertToAidlLibrary(ctx) || fg.ShouldConvertToProtoLibrary(ctx) {
Liz Kammer12615db2021-09-28 09:19:17 -0400131 return labelStr, false
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000132 }
Liz Kammer12615db2021-09-28 09:19:17 -0400133 return labelStr + suffix, true
Chris Parsons5a34ffb2021-07-21 14:34:58 -0400134 }
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000135 }
136
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400137 // TODO(b/190006308): Handle language detection of sources in a Bazel rule.
Sam Delmericoc7681022022-02-04 21:01:20 +0000138 labels := bazel.LabelPartitions{
139 protoSrcPartition: android.ProtoSrcLabelPartition,
Liz Kammeraabfb5d2021-12-08 15:25:06 -0500140 cSrcPartition: bazel.LabelPartition{Extensions: []string{".c"}, LabelMapper: addSuffixForFilegroup("_c_srcs")},
141 asSrcPartition: bazel.LabelPartition{Extensions: []string{".s", ".S"}, LabelMapper: addSuffixForFilegroup("_as_srcs")},
Cole Faust7071a052022-07-29 15:58:33 -0700142 asmSrcPartition: bazel.LabelPartition{Extensions: []string{".asm"}},
Vinh Tran9f6796a2022-08-16 13:10:31 -0400143 aidlSrcPartition: android.AidlSrcLabelPartition,
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000144 // TODO(http://b/231968910): If there is ever a filegroup target that
145 // contains .l or .ll files we will need to find a way to add a
146 // LabelMapper for these that identifies these filegroups and
147 // converts them appropriately
148 lSrcPartition: bazel.LabelPartition{Extensions: []string{".l"}},
149 llSrcPartition: bazel.LabelPartition{Extensions: []string{".ll"}},
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400150 // C++ is the "catch-all" group, and comprises generated sources because we don't
151 // know the language of these sources until the genrule is executed.
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000152 cppSrcPartition: bazel.LabelPartition{Extensions: []string{".cpp", ".cc", ".cxx", ".mm"}, LabelMapper: addSuffixForFilegroup("_cpp_srcs"), Keep_remainder: true},
153 syspropSrcPartition: bazel.LabelPartition{Extensions: []string{".sysprop"}},
Sam Delmericoc7681022022-02-04 21:01:20 +0000154 }
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000155
Sam Delmericoc7681022022-02-04 21:01:20 +0000156 return bazel.PartitionLabelListAttribute(ctx, &srcs, labels)
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000157}
158
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000159// bp2BuildParseLibProps returns the attributes for a variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000160func bp2BuildParseLibProps(ctx android.BazelConversionPathContext, module *Module, isStatic bool) staticOrSharedAttributes {
Jingwen Chen53681ef2021-04-29 08:15:13 +0000161 lib, ok := module.compiler.(*libraryDecorator)
162 if !ok {
Liz Kammer2222c6b2021-05-24 15:41:47 -0400163 return staticOrSharedAttributes{}
Jingwen Chen53681ef2021-04-29 08:15:13 +0000164 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000165 return bp2buildParseStaticOrSharedProps(ctx, module, lib, isStatic)
166}
Jingwen Chen53681ef2021-04-29 08:15:13 +0000167
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000168// bp2buildParseSharedProps returns the attributes for the shared variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000169func bp2BuildParseSharedProps(ctx android.BazelConversionPathContext, module *Module) staticOrSharedAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000170 return bp2BuildParseLibProps(ctx, module, false)
Jingwen Chen53681ef2021-04-29 08:15:13 +0000171}
172
173// bp2buildParseStaticProps returns the attributes for the static variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000174func bp2BuildParseStaticProps(ctx android.BazelConversionPathContext, module *Module) staticOrSharedAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000175 return bp2BuildParseLibProps(ctx, module, true)
Liz Kammer2222c6b2021-05-24 15:41:47 -0400176}
177
Liz Kammer7a210ac2021-09-22 15:52:58 -0400178type depsPartition struct {
179 export bazel.LabelList
180 implementation bazel.LabelList
181}
182
Jingwen Chen55bc8202021-11-02 06:40:51 +0000183type bazelLabelForDepsFn func(android.BazelConversionPathContext, []string) bazel.LabelList
Liz Kammer7a210ac2021-09-22 15:52:58 -0400184
Jingwen Chen55bc8202021-11-02 06:40:51 +0000185func maybePartitionExportedAndImplementationsDeps(ctx android.BazelConversionPathContext, exportsDeps bool, allDeps, exportedDeps []string, fn bazelLabelForDepsFn) depsPartition {
Liz Kammer2b8004b2021-10-04 13:55:44 -0400186 if !exportsDeps {
187 return depsPartition{
188 implementation: fn(ctx, allDeps),
189 }
190 }
191
Liz Kammer7a210ac2021-09-22 15:52:58 -0400192 implementation, export := android.FilterList(allDeps, exportedDeps)
193
194 return depsPartition{
195 export: fn(ctx, export),
196 implementation: fn(ctx, implementation),
197 }
198}
199
Jingwen Chen55bc8202021-11-02 06:40:51 +0000200type bazelLabelForDepsExcludesFn func(android.BazelConversionPathContext, []string, []string) bazel.LabelList
Liz Kammer7a210ac2021-09-22 15:52:58 -0400201
Jingwen Chen55bc8202021-11-02 06:40:51 +0000202func maybePartitionExportedAndImplementationsDepsExcludes(ctx android.BazelConversionPathContext, exportsDeps bool, allDeps, excludes, exportedDeps []string, fn bazelLabelForDepsExcludesFn) depsPartition {
Liz Kammer2b8004b2021-10-04 13:55:44 -0400203 if !exportsDeps {
204 return depsPartition{
205 implementation: fn(ctx, allDeps, excludes),
206 }
207 }
Liz Kammer7a210ac2021-09-22 15:52:58 -0400208 implementation, export := android.FilterList(allDeps, exportedDeps)
209
210 return depsPartition{
211 export: fn(ctx, export, excludes),
212 implementation: fn(ctx, implementation, excludes),
213 }
214}
215
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000216func bp2BuildPropParseHelper(ctx android.ArchVariantContext, module *Module, propsType interface{}, parseFunc func(axis bazel.ConfigurationAxis, config string, props interface{})) {
217 for axis, configToProps := range module.GetArchVariantProperties(ctx, propsType) {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800218 for cfg, props := range configToProps {
219 parseFunc(axis, cfg, props)
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000220 }
221 }
222}
223
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000224// Parses properties common to static and shared libraries. Also used for prebuilt libraries.
Liz Kammeraceec252023-03-24 09:46:36 -0400225func bp2buildParseStaticOrSharedProps(ctx android.BazelConversionPathContext, module *Module, lib *libraryDecorator, isStatic bool) staticOrSharedAttributes {
Liz Kammer135bf552021-08-11 10:46:06 -0400226 attrs := staticOrSharedAttributes{}
Jingwen Chenbcf53042021-05-26 04:42:42 +0000227
Liz Kammer9abd62d2021-05-21 08:37:59 -0400228 setAttrs := func(axis bazel.ConfigurationAxis, config string, props StaticOrSharedProperties) {
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000229 attrs.Copts.SetSelectValue(axis, config, parseCommandLineFlags(props.Cflags, filterOutStdFlag))
Jingwen Chenc4dc9b42021-06-11 12:51:48 +0000230 attrs.Srcs.SetSelectValue(axis, config, android.BazelLabelForModuleSrc(ctx, props.Srcs))
Chris Parsons953b3562021-09-20 15:14:39 -0400231 attrs.System_dynamic_deps.SetSelectValue(axis, config, bazelLabelForSharedDeps(ctx, props.System_shared_libs))
Liz Kammer7a210ac2021-09-22 15:52:58 -0400232
Liz Kammer2b8004b2021-10-04 13:55:44 -0400233 staticDeps := maybePartitionExportedAndImplementationsDeps(ctx, true, props.Static_libs, props.Export_static_lib_headers, bazelLabelForStaticDeps)
Liz Kammer7a210ac2021-09-22 15:52:58 -0400234 attrs.Deps.SetSelectValue(axis, config, staticDeps.export)
235 attrs.Implementation_deps.SetSelectValue(axis, config, staticDeps.implementation)
236
Liz Kammer2b8004b2021-10-04 13:55:44 -0400237 sharedDeps := maybePartitionExportedAndImplementationsDeps(ctx, true, props.Shared_libs, props.Export_shared_lib_headers, bazelLabelForSharedDeps)
Liz Kammer7a210ac2021-09-22 15:52:58 -0400238 attrs.Dynamic_deps.SetSelectValue(axis, config, sharedDeps.export)
239 attrs.Implementation_dynamic_deps.SetSelectValue(axis, config, sharedDeps.implementation)
240
241 attrs.Whole_archive_deps.SetSelectValue(axis, config, bazelLabelForWholeDeps(ctx, props.Whole_static_libs))
Chris Parsons58852a02021-12-09 18:10:18 -0500242 attrs.Enabled.SetSelectValue(axis, config, props.Enabled)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000243 }
Liz Kammer135bf552021-08-11 10:46:06 -0400244 // system_dynamic_deps distinguishes between nil/empty list behavior:
245 // nil -> use default values
246 // empty list -> no values specified
247 attrs.System_dynamic_deps.ForceSpecifyEmptyList = true
Jingwen Chenbcf53042021-05-26 04:42:42 +0000248
Liz Kammeraceec252023-03-24 09:46:36 -0400249 var apexAvailable []string
Jingwen Chenbcf53042021-05-26 04:42:42 +0000250 if isStatic {
Liz Kammeraceec252023-03-24 09:46:36 -0400251 apexAvailable = lib.StaticProperties.Static.Apex_available
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000252 bp2BuildPropParseHelper(ctx, module, &StaticProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
253 if staticOrSharedProps, ok := props.(*StaticProperties); ok {
254 setAttrs(axis, config, staticOrSharedProps.Static)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000255 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000256 })
Jingwen Chenbcf53042021-05-26 04:42:42 +0000257 } else {
Liz Kammeraceec252023-03-24 09:46:36 -0400258 apexAvailable = lib.SharedProperties.Shared.Apex_available
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000259 bp2BuildPropParseHelper(ctx, module, &SharedProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
260 if staticOrSharedProps, ok := props.(*SharedProperties); ok {
261 setAttrs(axis, config, staticOrSharedProps.Shared)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000262 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000263 })
Jingwen Chenbcf53042021-05-26 04:42:42 +0000264 }
265
Liz Kammerae3994e2021-10-19 09:45:48 -0400266 partitionedSrcs := groupSrcsByExtension(ctx, attrs.Srcs)
267 attrs.Srcs = partitionedSrcs[cppSrcPartition]
268 attrs.Srcs_c = partitionedSrcs[cSrcPartition]
269 attrs.Srcs_as = partitionedSrcs[asSrcPartition]
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000270
Liz Kammeraceec252023-03-24 09:46:36 -0400271 attrs.Apex_available = android.ConvertApexAvailableToTags(apexAvailable)
272
Liz Kammer12615db2021-09-28 09:19:17 -0400273 if !partitionedSrcs[protoSrcPartition].IsEmpty() {
274 // TODO(b/208815215): determine whether this is used and add support if necessary
275 ctx.ModuleErrorf("Migrating static/shared only proto srcs is not currently supported")
276 }
277
Jingwen Chenbcf53042021-05-26 04:42:42 +0000278 return attrs
Jingwen Chen53681ef2021-04-29 08:15:13 +0000279}
280
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400281// Convenience struct to hold all attributes parsed from prebuilt properties.
282type prebuiltAttributes struct {
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000283 Src bazel.LabelAttribute
284 Enabled bazel.BoolAttribute
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400285}
286
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000287func parseSrc(ctx android.BazelConversionPathContext, srcLabelAttribute *bazel.LabelAttribute, axis bazel.ConfigurationAxis, config string, srcs []string) {
288 srcFileError := func() {
289 ctx.ModuleErrorf("parseSrc: Expected at most one source file for %s %s\n", axis, config)
290 }
291 if len(srcs) > 1 {
292 srcFileError()
293 return
294 } else if len(srcs) == 0 {
295 return
296 }
297 if srcLabelAttribute.SelectValue(axis, config) != nil {
298 srcFileError()
299 return
300 }
301 srcLabelAttribute.SetSelectValue(axis, config, android.BazelLabelForModuleSrcSingle(ctx, srcs[0]))
302}
303
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000304// NOTE: Used outside of Soong repo project, in the clangprebuilts.go bootstrap_go_package
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000305func Bp2BuildParsePrebuiltLibraryProps(ctx android.BazelConversionPathContext, module *Module, isStatic bool) prebuiltAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000306
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400307 var srcLabelAttribute bazel.LabelAttribute
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000308 bp2BuildPropParseHelper(ctx, module, &prebuiltLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
309 if prebuiltLinkerProperties, ok := props.(*prebuiltLinkerProperties); ok {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000310 parseSrc(ctx, &srcLabelAttribute, axis, config, prebuiltLinkerProperties.Srcs)
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000311 }
312 })
313
314 var enabledLabelAttribute bazel.BoolAttribute
315 parseAttrs := func(axis bazel.ConfigurationAxis, config string, props StaticOrSharedProperties) {
316 if props.Enabled != nil {
317 enabledLabelAttribute.SetSelectValue(axis, config, props.Enabled)
318 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000319 parseSrc(ctx, &srcLabelAttribute, axis, config, props.Srcs)
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000320 }
321
322 if isStatic {
323 bp2BuildPropParseHelper(ctx, module, &StaticProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
324 if staticProperties, ok := props.(*StaticProperties); ok {
325 parseAttrs(axis, config, staticProperties.Static)
326 }
327 })
328 } else {
329 bp2BuildPropParseHelper(ctx, module, &SharedProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
330 if sharedProperties, ok := props.(*SharedProperties); ok {
331 parseAttrs(axis, config, sharedProperties.Shared)
332 }
333 })
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400334 }
335
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400336 return prebuiltAttributes{
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000337 Src: srcLabelAttribute,
338 Enabled: enabledLabelAttribute,
339 }
340}
341
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000342func bp2BuildParsePrebuiltBinaryProps(ctx android.BazelConversionPathContext, module *Module) prebuiltAttributes {
343 var srcLabelAttribute bazel.LabelAttribute
344 bp2BuildPropParseHelper(ctx, module, &prebuiltLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
345 if props, ok := props.(*prebuiltLinkerProperties); ok {
346 parseSrc(ctx, &srcLabelAttribute, axis, config, props.Srcs)
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000347 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000348 })
349
350 return prebuiltAttributes{
351 Src: srcLabelAttribute,
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400352 }
353}
354
Colin Crossc5075e92022-12-05 16:46:39 -0800355func bp2BuildParsePrebuiltObjectProps(ctx android.BazelConversionPathContext, module *Module) prebuiltAttributes {
356 var srcLabelAttribute bazel.LabelAttribute
357 bp2BuildPropParseHelper(ctx, module, &prebuiltObjectProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
358 if props, ok := props.(*prebuiltObjectProperties); ok {
359 parseSrc(ctx, &srcLabelAttribute, axis, config, props.Srcs)
360 }
361 })
362
363 return prebuiltAttributes{
364 Src: srcLabelAttribute,
365 }
366}
367
Liz Kammere6583482021-10-19 13:56:10 -0400368type baseAttributes struct {
369 compilerAttributes
370 linkerAttributes
Liz Kammer12615db2021-09-28 09:19:17 -0400371
Trevor Radcliffedb7e0262022-10-28 16:48:18 +0000372 // A combination of compilerAttributes.features and linkerAttributes.features, as well as sanitizer features
Cole Faust5fa4e962022-08-22 14:31:04 -0700373 features bazel.StringListAttribute
Liz Kammer12615db2021-09-28 09:19:17 -0400374 protoDependency *bazel.LabelAttribute
Vinh Tran9f6796a2022-08-16 13:10:31 -0400375 aidlDependency *bazel.LabelAttribute
Yu Liuf01a0f02022-12-07 15:45:30 -0800376 Native_coverage *bool
Liz Kammere6583482021-10-19 13:56:10 -0400377}
378
Jingwen Chen107c0de2021-04-09 10:43:12 +0000379// Convenience struct to hold all attributes parsed from compiler properties.
380type compilerAttributes struct {
Chris Parsons990c4f42021-05-25 12:10:58 -0400381 // Options for all languages
382 copts bazel.StringListAttribute
383 // Assembly options and sources
384 asFlags bazel.StringListAttribute
385 asSrcs bazel.LabelListAttribute
Cole Faust7071a052022-07-29 15:58:33 -0700386 asmSrcs bazel.LabelListAttribute
Chris Parsons990c4f42021-05-25 12:10:58 -0400387 // C options and sources
388 conlyFlags bazel.StringListAttribute
389 cSrcs bazel.LabelListAttribute
390 // C++ options and sources
391 cppFlags bazel.StringListAttribute
Jingwen Chened9c17d2021-04-13 07:14:55 +0000392 srcs bazel.LabelListAttribute
Chris Parsons2c788392021-08-10 11:58:07 -0400393
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000394 // Lex sources and options
395 lSrcs bazel.LabelListAttribute
396 llSrcs bazel.LabelListAttribute
397 lexopts bazel.StringListAttribute
398
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000399 // Sysprop sources
400 syspropSrcs bazel.LabelListAttribute
401
Liz Kammere6583482021-10-19 13:56:10 -0400402 hdrs bazel.LabelListAttribute
403
Chris Parsons2c788392021-08-10 11:58:07 -0400404 rtti bazel.BoolAttribute
Jingwen Chen5b11ab12021-10-11 17:44:33 +0000405
406 // Not affected by arch variants
407 stl *string
Chris Parsons79bd2b72021-11-29 17:52:41 -0500408 cStd *string
Jingwen Chen5b11ab12021-10-11 17:44:33 +0000409 cppStd *string
Liz Kammer35687bc2021-09-10 10:07:07 -0400410
411 localIncludes bazel.StringListAttribute
412 absoluteIncludes bazel.StringListAttribute
Liz Kammer12615db2021-09-28 09:19:17 -0400413
Liz Kammer1263d9b2021-12-10 14:28:20 -0500414 includes BazelIncludes
415
Liz Kammer12615db2021-09-28 09:19:17 -0400416 protoSrcs bazel.LabelListAttribute
Vinh Tran9f6796a2022-08-16 13:10:31 -0400417 aidlSrcs bazel.LabelListAttribute
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000418
419 stubsSymbolFile *string
420 stubsVersions bazel.StringListAttribute
Cole Faust5fa4e962022-08-22 14:31:04 -0700421
422 features bazel.StringListAttribute
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500423
424 suffix bazel.StringAttribute
Vinh Tran99270ea2022-11-28 11:15:23 -0500425
426 fdoProfile bazel.LabelAttribute
Jingwen Chen107c0de2021-04-09 10:43:12 +0000427}
428
Liz Kammercac7f692021-12-16 14:19:32 -0500429type filterOutFn func(string) bool
430
431func filterOutStdFlag(flag string) bool {
432 return strings.HasPrefix(flag, "-std=")
433}
434
Alix1be00d42022-05-16 22:56:04 +0000435func filterOutClangUnknownCflags(flag string) bool {
436 for _, f := range config.ClangUnknownCflags {
437 if f == flag {
438 return true
439 }
440 }
441 return false
442}
443
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000444func parseCommandLineFlags(soongFlags []string, filterOut ...filterOutFn) []string {
Liz Kammere6583482021-10-19 13:56:10 -0400445 var result []string
446 for _, flag := range soongFlags {
Alix1be00d42022-05-16 22:56:04 +0000447 skipFlag := false
448 for _, filter := range filterOut {
449 if filter != nil && filter(flag) {
450 skipFlag = true
451 }
452 }
453 if skipFlag {
Liz Kammercac7f692021-12-16 14:19:32 -0500454 continue
455 }
Liz Kammere6583482021-10-19 13:56:10 -0400456 // Soong's cflags can contain spaces, like `-include header.h`. For
457 // Bazel's copts, split them up to be compatible with the
458 // no_copts_tokenization feature.
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000459 result = append(result, strings.Split(flag, " ")...)
Liz Kammere6583482021-10-19 13:56:10 -0400460 }
461 return result
462}
Jingwen Chened9c17d2021-04-13 07:14:55 +0000463
Jingwen Chen55bc8202021-11-02 06:40:51 +0000464func (ca *compilerAttributes) bp2buildForAxisAndConfig(ctx android.BazelConversionPathContext, axis bazel.ConfigurationAxis, config string, props *BaseCompilerProperties) {
Liz Kammere6583482021-10-19 13:56:10 -0400465 // If there's arch specific srcs or exclude_srcs, generate a select entry for it.
466 // TODO(b/186153868): do this for OS specific srcs and exclude_srcs too.
467 if srcsList, ok := parseSrcs(ctx, props); ok {
468 ca.srcs.SetSelectValue(axis, config, srcsList)
Chris Parsons990c4f42021-05-25 12:10:58 -0400469 }
470
Liz Kammere6583482021-10-19 13:56:10 -0400471 localIncludeDirs := props.Local_include_dirs
472 if axis == bazel.NoConfigAxis {
Chris Parsons79bd2b72021-11-29 17:52:41 -0500473 ca.cStd, ca.cppStd = bp2buildResolveCppStdValue(props.C_std, props.Cpp_std, props.Gnu_extensions)
Liz Kammere6583482021-10-19 13:56:10 -0400474 if includeBuildDirectory(props.Include_build_directory) {
475 localIncludeDirs = append(localIncludeDirs, ".")
Liz Kammer222bdcf2021-10-11 14:15:51 -0400476 }
Jingwen Chene32e9e02021-04-23 09:17:24 +0000477 }
478
Liz Kammere6583482021-10-19 13:56:10 -0400479 ca.absoluteIncludes.SetSelectValue(axis, config, props.Include_dirs)
480 ca.localIncludes.SetSelectValue(axis, config, localIncludeDirs)
481
Cole Faust5fa4e962022-08-22 14:31:04 -0700482 instructionSet := proptools.StringDefault(props.Instruction_set, "")
483 if instructionSet == "arm" {
484 ca.features.SetSelectValue(axis, config, []string{"arm_isa_arm", "-arm_isa_thumb"})
485 } else if instructionSet != "" && instructionSet != "thumb" {
486 ctx.ModuleErrorf("Unknown value for instruction_set: %s", instructionSet)
487 }
488
Liz Kammercac7f692021-12-16 14:19:32 -0500489 // In Soong, cflags occur on the command line before -std=<val> flag, resulting in the value being
490 // overridden. In Bazel we always allow overriding, via flags; however, this can cause
491 // incompatibilities, so we remove "-std=" flags from Cflag properties while leaving it in other
492 // cases.
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000493 ca.copts.SetSelectValue(axis, config, parseCommandLineFlags(props.Cflags, filterOutStdFlag, filterOutClangUnknownCflags))
494 ca.asFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Asflags, nil))
495 ca.conlyFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Conlyflags, filterOutClangUnknownCflags))
496 ca.cppFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Cppflags, filterOutClangUnknownCflags))
Liz Kammere6583482021-10-19 13:56:10 -0400497 ca.rtti.SetSelectValue(axis, config, props.Rtti)
498}
499
Jingwen Chen55bc8202021-11-02 06:40:51 +0000500func (ca *compilerAttributes) convertStlProps(ctx android.ArchVariantContext, module *Module) {
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000501 bp2BuildPropParseHelper(ctx, module, &StlProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
502 if stlProps, ok := props.(*StlProperties); ok {
503 if stlProps.Stl == nil {
504 return
505 }
506 if ca.stl == nil {
Liz Kammer7128d382022-05-12 11:42:33 -0400507 stl := deduplicateStlInput(*stlProps.Stl)
508 ca.stl = &stl
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000509 } else if ca.stl != stlProps.Stl {
510 ctx.ModuleErrorf("Unsupported conversion: module with different stl for different variants: %s and %s", *ca.stl, stlProps.Stl)
Liz Kammer9abd62d2021-05-21 08:37:59 -0400511 }
Jingwen Chenc1c26502021-04-05 10:35:13 +0000512 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000513 })
Liz Kammere6583482021-10-19 13:56:10 -0400514}
Jingwen Chenc1c26502021-04-05 10:35:13 +0000515
Jingwen Chen55bc8202021-11-02 06:40:51 +0000516func (ca *compilerAttributes) convertProductVariables(ctx android.BazelConversionPathContext, productVariableProps android.ProductConfigProperties) {
Liz Kammerba7a9c52021-05-26 08:45:30 -0400517 productVarPropNameToAttribute := map[string]*bazel.StringListAttribute{
Liz Kammere6583482021-10-19 13:56:10 -0400518 "Cflags": &ca.copts,
519 "Asflags": &ca.asFlags,
520 "CppFlags": &ca.cppFlags,
Liz Kammerba7a9c52021-05-26 08:45:30 -0400521 }
Liz Kammerba7a9c52021-05-26 08:45:30 -0400522 for propName, attr := range productVarPropNameToAttribute {
Jingwen Chen25825ca2021-11-15 12:28:43 +0000523 if productConfigProps, exists := productVariableProps[propName]; exists {
524 for productConfigProp, prop := range productConfigProps {
525 flags, ok := prop.([]string)
Liz Kammerba7a9c52021-05-26 08:45:30 -0400526 if !ok {
527 ctx.ModuleErrorf("Could not convert product variable %s property", proptools.PropertyNameForField(propName))
528 }
Jingwen Chen25825ca2021-11-15 12:28:43 +0000529 newFlags, _ := bazel.TryVariableSubstitutions(flags, productConfigProp.Name)
530 attr.SetSelectValue(productConfigProp.ConfigurationAxis(), productConfigProp.SelectKey(), newFlags)
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400531 }
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400532 }
533 }
Liz Kammere6583482021-10-19 13:56:10 -0400534}
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400535
Jingwen Chen55bc8202021-11-02 06:40:51 +0000536func (ca *compilerAttributes) finalize(ctx android.BazelConversionPathContext, implementationHdrs bazel.LabelListAttribute) {
Liz Kammere6583482021-10-19 13:56:10 -0400537 ca.srcs.ResolveExcludes()
538 partitionedSrcs := groupSrcsByExtension(ctx, ca.srcs)
539
Liz Kammer12615db2021-09-28 09:19:17 -0400540 ca.protoSrcs = partitionedSrcs[protoSrcPartition]
Vinh Tran9f6796a2022-08-16 13:10:31 -0400541 ca.aidlSrcs = partitionedSrcs[aidlSrcPartition]
Liz Kammer12615db2021-09-28 09:19:17 -0400542
Liz Kammere6583482021-10-19 13:56:10 -0400543 for p, lla := range partitionedSrcs {
544 // if there are no sources, there is no need for headers
545 if lla.IsEmpty() {
546 continue
547 }
548 lla.Append(implementationHdrs)
549 partitionedSrcs[p] = lla
550 }
551
552 ca.srcs = partitionedSrcs[cppSrcPartition]
553 ca.cSrcs = partitionedSrcs[cSrcPartition]
554 ca.asSrcs = partitionedSrcs[asSrcPartition]
Cole Faust7071a052022-07-29 15:58:33 -0700555 ca.asmSrcs = partitionedSrcs[asmSrcPartition]
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000556 ca.lSrcs = partitionedSrcs[lSrcPartition]
557 ca.llSrcs = partitionedSrcs[llSrcPartition]
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000558 ca.syspropSrcs = partitionedSrcs[syspropSrcPartition]
Liz Kammere6583482021-10-19 13:56:10 -0400559
560 ca.absoluteIncludes.DeduplicateAxesFromBase()
561 ca.localIncludes.DeduplicateAxesFromBase()
562}
563
564// Parse srcs from an arch or OS's props value.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000565func parseSrcs(ctx android.BazelConversionPathContext, props *BaseCompilerProperties) (bazel.LabelList, bool) {
Liz Kammere6583482021-10-19 13:56:10 -0400566 anySrcs := false
567 // Add srcs-like dependencies such as generated files.
568 // First create a LabelList containing these dependencies, then merge the values with srcs.
569 generatedSrcsLabelList := android.BazelLabelForModuleDepsExcludes(ctx, props.Generated_sources, props.Exclude_generated_sources)
570 if len(props.Generated_sources) > 0 || len(props.Exclude_generated_sources) > 0 {
571 anySrcs = true
572 }
573
574 allSrcsLabelList := android.BazelLabelForModuleSrcExcludes(ctx, props.Srcs, props.Exclude_srcs)
Vinh Tran9f6796a2022-08-16 13:10:31 -0400575
Liz Kammere6583482021-10-19 13:56:10 -0400576 if len(props.Srcs) > 0 || len(props.Exclude_srcs) > 0 {
577 anySrcs = true
578 }
Vinh Tran9f6796a2022-08-16 13:10:31 -0400579
Liz Kammere6583482021-10-19 13:56:10 -0400580 return bazel.AppendBazelLabelLists(allSrcsLabelList, generatedSrcsLabelList), anySrcs
581}
582
Liz Kammera5a29de2022-05-25 23:19:37 -0400583func bp2buildStdVal(std *string, prefix string, useGnu bool) *string {
584 defaultVal := prefix + "_std_default"
Chris Parsons79bd2b72021-11-29 17:52:41 -0500585 // If c{,pp}std properties are not specified, don't generate them in the BUILD file.
586 // Defaults are handled by the toolchain definition.
587 // However, if gnu_extensions is false, then the default gnu-to-c version must be specified.
Liz Kammera5a29de2022-05-25 23:19:37 -0400588 stdVal := proptools.StringDefault(std, defaultVal)
589 if stdVal == "experimental" || stdVal == defaultVal {
590 if stdVal == "experimental" {
591 stdVal = prefix + "_std_experimental"
592 }
593 if !useGnu {
594 stdVal += "_no_gnu"
595 }
596 } else if !useGnu {
597 stdVal = gnuToCReplacer.Replace(stdVal)
Chris Parsons79bd2b72021-11-29 17:52:41 -0500598 }
599
Liz Kammera5a29de2022-05-25 23:19:37 -0400600 if stdVal == defaultVal {
601 return nil
Liz Kammer46fb7ab2021-12-01 10:09:34 -0500602 }
Liz Kammera5a29de2022-05-25 23:19:37 -0400603 return &stdVal
604}
Liz Kammer46fb7ab2021-12-01 10:09:34 -0500605
Liz Kammera5a29de2022-05-25 23:19:37 -0400606func bp2buildResolveCppStdValue(c_std *string, cpp_std *string, gnu_extensions *bool) (*string, *string) {
607 useGnu := useGnuExtensions(gnu_extensions)
608
609 return bp2buildStdVal(c_std, "c", useGnu), bp2buildStdVal(cpp_std, "cpp", useGnu)
Liz Kammere6583482021-10-19 13:56:10 -0400610}
611
Liz Kammer1263d9b2021-12-10 14:28:20 -0500612// packageFromLabel extracts package from a fully-qualified or relative Label and whether the label
613// is fully-qualified.
614// e.g. fully-qualified "//a/b:foo" -> "a/b", true, relative: ":bar" -> ".", false
615func packageFromLabel(label string) (string, bool) {
616 split := strings.Split(label, ":")
617 if len(split) != 2 {
618 return "", false
619 }
620 if split[0] == "" {
621 return ".", false
622 }
623 // remove leading "//"
624 return split[0][2:], true
625}
626
627// includesFromLabelList extracts relative/absolute includes from a bazel.LabelList>
628func includesFromLabelList(labelList bazel.LabelList) (relative, absolute []string) {
629 for _, hdr := range labelList.Includes {
630 if pkg, hasPkg := packageFromLabel(hdr.Label); hasPkg {
631 absolute = append(absolute, pkg)
632 } else if pkg != "" {
633 relative = append(relative, pkg)
634 }
635 }
636 return relative, absolute
637}
638
Cole Faust7071a052022-07-29 15:58:33 -0700639type YasmAttributes struct {
640 Srcs bazel.LabelListAttribute
641 Flags bazel.StringListAttribute
642 Include_dirs bazel.StringListAttribute
643}
644
645func bp2BuildYasm(ctx android.Bp2buildMutatorContext, m *Module, ca compilerAttributes) *bazel.LabelAttribute {
646 if ca.asmSrcs.IsEmpty() {
647 return nil
648 }
649
650 // Yasm needs the include directories from both local_includes and
651 // export_include_dirs. We don't care about actually exporting them from the
652 // yasm rule though, because they will also be present on the cc_ rule that
653 // wraps this yasm rule.
654 includes := ca.localIncludes.Clone()
655 bp2BuildPropParseHelper(ctx, m, &FlagExporterProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
656 if flagExporterProperties, ok := props.(*FlagExporterProperties); ok {
657 if len(flagExporterProperties.Export_include_dirs) > 0 {
658 x := bazel.StringListAttribute{}
659 x.SetSelectValue(axis, config, flagExporterProperties.Export_include_dirs)
660 includes.Append(x)
661 }
662 }
663 })
664
665 ctx.CreateBazelTargetModule(
666 bazel.BazelTargetModuleProperties{
667 Rule_class: "yasm",
668 Bzl_load_location: "//build/bazel/rules/cc:yasm.bzl",
669 },
670 android.CommonAttributes{Name: m.Name() + "_yasm"},
671 &YasmAttributes{
672 Srcs: ca.asmSrcs,
673 Flags: ca.asFlags,
674 Include_dirs: *includes,
675 })
676
677 // We only want to add a dependency on the _yasm target if there are asm
678 // sources in the current configuration. If there are unconfigured asm
679 // sources, always add the dependency. Otherwise, add the dependency only
680 // on the configuration axes and values that had asm sources.
681 if len(ca.asmSrcs.Value.Includes) > 0 {
682 return bazel.MakeLabelAttribute(":" + m.Name() + "_yasm")
683 }
684
685 ret := &bazel.LabelAttribute{}
686 for _, axis := range ca.asmSrcs.SortedConfigurationAxes() {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800687 for cfg := range ca.asmSrcs.ConfigurableValues[axis] {
688 ret.SetSelectValue(axis, cfg, bazel.Label{Label: ":" + m.Name() + "_yasm"})
Cole Faust7071a052022-07-29 15:58:33 -0700689 }
690 }
691 return ret
692}
693
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000694// bp2BuildParseBaseProps returns all compiler, linker, library attributes of a cc module..
Liz Kammer12615db2021-09-28 09:19:17 -0400695func bp2BuildParseBaseProps(ctx android.Bp2buildMutatorContext, module *Module) baseAttributes {
Liz Kammere6583482021-10-19 13:56:10 -0400696 archVariantCompilerProps := module.GetArchVariantProperties(ctx, &BaseCompilerProperties{})
697 archVariantLinkerProps := module.GetArchVariantProperties(ctx, &BaseLinkerProperties{})
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000698 archVariantLibraryProperties := module.GetArchVariantProperties(ctx, &LibraryProperties{})
Liz Kammere6583482021-10-19 13:56:10 -0400699
700 var implementationHdrs bazel.LabelListAttribute
701
702 axisToConfigs := map[bazel.ConfigurationAxis]map[string]bool{}
703 allAxesAndConfigs := func(cp android.ConfigurationAxisToArchVariantProperties) {
704 for axis, configMap := range cp {
705 if _, ok := axisToConfigs[axis]; !ok {
706 axisToConfigs[axis] = map[string]bool{}
707 }
Sasha Smundak39a301c2022-12-29 17:11:49 -0800708 for cfg := range configMap {
709 axisToConfigs[axis][cfg] = true
Chris Parsonsa967f252021-09-23 16:34:35 -0400710 }
711 }
712 }
Liz Kammere6583482021-10-19 13:56:10 -0400713 allAxesAndConfigs(archVariantCompilerProps)
714 allAxesAndConfigs(archVariantLinkerProps)
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000715 allAxesAndConfigs(archVariantLibraryProperties)
Chris Parsonsa967f252021-09-23 16:34:35 -0400716
Liz Kammere6583482021-10-19 13:56:10 -0400717 compilerAttrs := compilerAttributes{}
718 linkerAttrs := linkerAttributes{}
719
Chris Parsons7b3289b2023-01-26 17:30:44 -0500720 // Iterate through these axes in a deterministic order. This is required
721 // because processing certain dependencies may result in concatenating
722 // elements along other axes. (For example, processing NoConfig may result
723 // in elements being added to InApex). This is thus the only way to ensure
724 // that the order of entries in each list is in a predictable order.
725 for _, axis := range bazel.SortedConfigurationAxes(axisToConfigs) {
726 configs := axisToConfigs[axis]
Sasha Smundak39a301c2022-12-29 17:11:49 -0800727 for cfg := range configs {
Liz Kammere6583482021-10-19 13:56:10 -0400728 var allHdrs []string
Sasha Smundak39a301c2022-12-29 17:11:49 -0800729 if baseCompilerProps, ok := archVariantCompilerProps[axis][cfg].(*BaseCompilerProperties); ok {
Liz Kammere6583482021-10-19 13:56:10 -0400730 allHdrs = baseCompilerProps.Generated_headers
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000731 if baseCompilerProps.Lex != nil {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800732 compilerAttrs.lexopts.SetSelectValue(axis, cfg, baseCompilerProps.Lex.Flags)
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000733 }
Sasha Smundak39a301c2022-12-29 17:11:49 -0800734 (&compilerAttrs).bp2buildForAxisAndConfig(ctx, axis, cfg, baseCompilerProps)
Liz Kammere6583482021-10-19 13:56:10 -0400735 }
736
737 var exportHdrs []string
738
Sasha Smundak39a301c2022-12-29 17:11:49 -0800739 if baseLinkerProps, ok := archVariantLinkerProps[axis][cfg].(*BaseLinkerProperties); ok {
Liz Kammere6583482021-10-19 13:56:10 -0400740 exportHdrs = baseLinkerProps.Export_generated_headers
741
Liz Kammer48cdbeb2023-03-17 10:17:50 -0400742 (&linkerAttrs).bp2buildForAxisAndConfig(ctx, module, axis, cfg, baseLinkerProps)
Liz Kammere6583482021-10-19 13:56:10 -0400743 }
744 headers := maybePartitionExportedAndImplementationsDeps(ctx, !module.Binary(), allHdrs, exportHdrs, android.BazelLabelForModuleDeps)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800745 implementationHdrs.SetSelectValue(axis, cfg, headers.implementation)
746 compilerAttrs.hdrs.SetSelectValue(axis, cfg, headers.export)
Liz Kammer1263d9b2021-12-10 14:28:20 -0500747
748 exportIncludes, exportAbsoluteIncludes := includesFromLabelList(headers.export)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800749 compilerAttrs.includes.Includes.SetSelectValue(axis, cfg, exportIncludes)
750 compilerAttrs.includes.AbsoluteIncludes.SetSelectValue(axis, cfg, exportAbsoluteIncludes)
Liz Kammer1263d9b2021-12-10 14:28:20 -0500751
752 includes, absoluteIncludes := includesFromLabelList(headers.implementation)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800753 currAbsoluteIncludes := compilerAttrs.absoluteIncludes.SelectValue(axis, cfg)
Liz Kammer1263d9b2021-12-10 14:28:20 -0500754 currAbsoluteIncludes = android.FirstUniqueStrings(append(currAbsoluteIncludes, absoluteIncludes...))
Vinh Tran9f6796a2022-08-16 13:10:31 -0400755
Sasha Smundak39a301c2022-12-29 17:11:49 -0800756 compilerAttrs.absoluteIncludes.SetSelectValue(axis, cfg, currAbsoluteIncludes)
Vinh Tran9f6796a2022-08-16 13:10:31 -0400757
Sasha Smundak39a301c2022-12-29 17:11:49 -0800758 currIncludes := compilerAttrs.localIncludes.SelectValue(axis, cfg)
Liz Kammer1263d9b2021-12-10 14:28:20 -0500759 currIncludes = android.FirstUniqueStrings(append(currIncludes, includes...))
Vinh Tran9f6796a2022-08-16 13:10:31 -0400760
Sasha Smundak39a301c2022-12-29 17:11:49 -0800761 compilerAttrs.localIncludes.SetSelectValue(axis, cfg, currIncludes)
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000762
Sasha Smundak39a301c2022-12-29 17:11:49 -0800763 if libraryProps, ok := archVariantLibraryProperties[axis][cfg].(*LibraryProperties); ok {
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000764 if axis == bazel.NoConfigAxis {
765 compilerAttrs.stubsSymbolFile = libraryProps.Stubs.Symbol_file
Sasha Smundak39a301c2022-12-29 17:11:49 -0800766 compilerAttrs.stubsVersions.SetSelectValue(axis, cfg, libraryProps.Stubs.Versions)
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000767 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500768 if suffix := libraryProps.Suffix; suffix != nil {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800769 compilerAttrs.suffix.SetSelectValue(axis, cfg, suffix)
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500770 }
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000771 }
Liz Kammere6583482021-10-19 13:56:10 -0400772 }
773 }
Vinh Tran9f6796a2022-08-16 13:10:31 -0400774
Liz Kammere6583482021-10-19 13:56:10 -0400775 compilerAttrs.convertStlProps(ctx, module)
776 (&linkerAttrs).convertStripProps(ctx, module)
777
Yu Liuf01a0f02022-12-07 15:45:30 -0800778 var nativeCoverage *bool
Yu Liu8d82ac52022-05-17 15:13:28 -0700779 if module.coverage != nil && module.coverage.Properties.Native_coverage != nil &&
780 !Bool(module.coverage.Properties.Native_coverage) {
Yu Liuf01a0f02022-12-07 15:45:30 -0800781 nativeCoverage = BoolPtr(false)
Yu Liu8d82ac52022-05-17 15:13:28 -0700782 }
783
Cole Faust912bc882023-03-08 12:29:50 -0800784 productVariableProps := android.ProductVariableProperties(ctx, ctx.Module())
Liz Kammere6583482021-10-19 13:56:10 -0400785
786 (&compilerAttrs).convertProductVariables(ctx, productVariableProps)
787 (&linkerAttrs).convertProductVariables(ctx, productVariableProps)
788
789 (&compilerAttrs).finalize(ctx, implementationHdrs)
Liz Kammer54309532021-12-14 12:21:22 -0500790 (&linkerAttrs).finalize(ctx)
Liz Kammere6583482021-10-19 13:56:10 -0400791
Cole Faust7071a052022-07-29 15:58:33 -0700792 (&compilerAttrs.srcs).Add(bp2BuildYasm(ctx, module, compilerAttrs))
793
Liz Kammer12615db2021-09-28 09:19:17 -0400794 protoDep := bp2buildProto(ctx, module, compilerAttrs.protoSrcs)
795
796 // bp2buildProto will only set wholeStaticLib or implementationWholeStaticLib, but we don't know
797 // which. This will add the newly generated proto library to the appropriate attribute and nothing
798 // to the other
799 (&linkerAttrs).wholeArchiveDeps.Add(protoDep.wholeStaticLib)
800 (&linkerAttrs).implementationWholeArchiveDeps.Add(protoDep.implementationWholeStaticLib)
Vinh Tranfde57eb2022-08-29 17:46:58 -0400801
Vinh Tran395a1e92022-09-16 18:27:29 -0400802 aidlDep := bp2buildCcAidlLibrary(ctx, module, compilerAttrs.aidlSrcs, linkerAttrs)
Vinh Tranfde57eb2022-08-29 17:46:58 -0400803 if aidlDep != nil {
804 if lib, ok := module.linker.(*libraryDecorator); ok {
805 if proptools.Bool(lib.Properties.Aidl.Export_aidl_headers) {
806 (&linkerAttrs).wholeArchiveDeps.Add(aidlDep)
807 } else {
808 (&linkerAttrs).implementationWholeArchiveDeps.Add(aidlDep)
809 }
810 }
811 }
Liz Kammer12615db2021-09-28 09:19:17 -0400812
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000813 convertedLSrcs := bp2BuildLex(ctx, module.Name(), compilerAttrs)
814 (&compilerAttrs).srcs.Add(&convertedLSrcs.srcName)
815 (&compilerAttrs).cSrcs.Add(&convertedLSrcs.cSrcName)
816
Vinh Tran99270ea2022-11-28 11:15:23 -0500817 if module.afdo != nil && module.afdo.Properties.Afdo {
818 fdoProfileDep := bp2buildFdoProfile(ctx, module)
819 if fdoProfileDep != nil {
820 (&compilerAttrs).fdoProfile.SetValue(*fdoProfileDep)
821 }
822 }
823
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000824 if !compilerAttrs.syspropSrcs.IsEmpty() {
825 (&linkerAttrs).wholeArchiveDeps.Add(bp2buildCcSysprop(ctx, module.Name(), module.Properties.Min_sdk_version, compilerAttrs.syspropSrcs))
826 }
827
Zi Wang9f609db2023-01-04 11:06:54 -0800828 linkerAttrs.wholeArchiveDeps.Prepend = true
829 linkerAttrs.deps.Prepend = true
830 compilerAttrs.localIncludes.Prepend = true
831 compilerAttrs.absoluteIncludes.Prepend = true
832 compilerAttrs.hdrs.Prepend = true
833
Trevor Radcliffedb7e0262022-10-28 16:48:18 +0000834 features := compilerAttrs.features.Clone().Append(linkerAttrs.features).Append(bp2buildSanitizerFeatures(ctx, module))
Trevor Radcliffe56b1a2b2023-02-06 21:58:30 +0000835 features = features.Append(bp2buildLtoFeatures(ctx, module))
Cole Faust5fa4e962022-08-22 14:31:04 -0700836 features.DeduplicateAxesFromBase()
837
Trevor Radcliffe0d1b4022022-12-12 22:26:34 +0000838 addMuslSystemDynamicDeps(ctx, linkerAttrs)
839
Liz Kammere6583482021-10-19 13:56:10 -0400840 return baseAttributes{
841 compilerAttrs,
842 linkerAttrs,
Cole Faust5fa4e962022-08-22 14:31:04 -0700843 *features,
Liz Kammer12615db2021-09-28 09:19:17 -0400844 protoDep.protoDep,
Vinh Tran9f6796a2022-08-16 13:10:31 -0400845 aidlDep,
Yu Liuf01a0f02022-12-07 15:45:30 -0800846 nativeCoverage,
Jingwen Chen107c0de2021-04-09 10:43:12 +0000847 }
848}
849
Trevor Radcliffe0d1b4022022-12-12 22:26:34 +0000850// As a workaround for b/261657184, we are manually adding the default value
851// of system_dynamic_deps for the linux_musl os.
852// TODO: Solve this properly
853func addMuslSystemDynamicDeps(ctx android.Bp2buildMutatorContext, attrs linkerAttributes) {
854 systemDynamicDeps := attrs.systemDynamicDeps.SelectValue(bazel.OsConfigurationAxis, "linux_musl")
855 if attrs.systemDynamicDeps.HasAxisSpecificValues(bazel.OsConfigurationAxis) && systemDynamicDeps.IsNil() {
856 attrs.systemDynamicDeps.SetSelectValue(bazel.OsConfigurationAxis, "linux_musl", android.BazelLabelForModuleDeps(ctx, config.MuslDefaultSharedLibraries))
857 }
858}
859
Vinh Tran99270ea2022-11-28 11:15:23 -0500860type fdoProfileAttributes struct {
861 Absolute_path_profile string
862}
863
864func bp2buildFdoProfile(
865 ctx android.Bp2buildMutatorContext,
866 m *Module,
867) *bazel.Label {
868 for _, project := range globalAfdoProfileProjects {
Vinh Tranbc9c8b42022-12-09 12:03:52 -0500869 // Ensure handcrafted BUILD file exists in the project
870 BUILDPath := android.ExistentPathForSource(ctx, project, "BUILD")
871 if BUILDPath.Valid() {
872 // We handcraft a BUILD file with fdo_profile targets that use the existing profiles in the project
873 // This implementation is assuming that every afdo profile in globalAfdoProfileProjects already has
874 // an associated fdo_profile target declared in the same package.
875 // TODO(b/260714900): Handle arch-specific afdo profiles (e.g. `<module-name>-arm<64>.afdo`)
876 path := android.ExistentPathForSource(ctx, project, m.Name()+".afdo")
877 if path.Valid() {
878 // FIXME: Some profiles only exist internally and are not released to AOSP.
879 // When generated BUILD files are checked in, we'll run into merge conflict.
880 // The cc_library_shared target in AOSP won't have reference to an fdo_profile target because
881 // the profile doesn't exist. Internally, the same cc_library_shared target will
882 // have reference to the fdo_profile.
883 // For more context, see b/258682955#comment2
884 fdoProfileLabel := "//" + strings.TrimSuffix(project, "/") + ":" + m.Name()
885 return &bazel.Label{
886 Label: fdoProfileLabel,
887 }
Vinh Tran99270ea2022-11-28 11:15:23 -0500888 }
889 }
890 }
891
892 return nil
893}
894
Vinh Tran9f6796a2022-08-16 13:10:31 -0400895func bp2buildCcAidlLibrary(
896 ctx android.Bp2buildMutatorContext,
897 m *Module,
Vinh Trana3b8b782022-09-14 11:40:24 -0400898 aidlLabelList bazel.LabelListAttribute,
Vinh Tran395a1e92022-09-16 18:27:29 -0400899 linkerAttrs linkerAttributes,
Vinh Tran9f6796a2022-08-16 13:10:31 -0400900) *bazel.LabelAttribute {
Vinh Trana3b8b782022-09-14 11:40:24 -0400901 if !aidlLabelList.IsEmpty() {
902 aidlLibs, aidlSrcs := aidlLabelList.Partition(func(src bazel.Label) bool {
903 if fg, ok := android.ToFileGroupAsLibrary(ctx, src.OriginalModuleName); ok &&
904 fg.ShouldConvertToAidlLibrary(ctx) {
905 return true
906 }
907 return false
908 })
Vinh Tran9f6796a2022-08-16 13:10:31 -0400909
Liz Kammer2b3f56e2023-03-23 11:51:49 -0400910 apexAvailableTags := android.ApexAvailableTags(ctx.Module())
911 sdkAttrs := bp2BuildParseSdkAttributes(m)
912
Vinh Trana3b8b782022-09-14 11:40:24 -0400913 if !aidlSrcs.IsEmpty() {
914 aidlLibName := m.Name() + "_aidl_library"
915 ctx.CreateBazelTargetModule(
916 bazel.BazelTargetModuleProperties{
917 Rule_class: "aidl_library",
918 Bzl_load_location: "//build/bazel/rules/aidl:library.bzl",
919 },
920 android.CommonAttributes{Name: aidlLibName},
921 &aidlLibraryAttributes{
922 Srcs: aidlSrcs,
Liz Kammer2b3f56e2023-03-23 11:51:49 -0400923 Tags: apexAvailableTags,
Vinh Trana3b8b782022-09-14 11:40:24 -0400924 },
925 )
926 aidlLibs.Add(&bazel.LabelAttribute{Value: &bazel.Label{Label: ":" + aidlLibName}})
927 }
Vinh Tran9f6796a2022-08-16 13:10:31 -0400928
Vinh Trana3b8b782022-09-14 11:40:24 -0400929 if !aidlLibs.IsEmpty() {
930 ccAidlLibrarylabel := m.Name() + "_cc_aidl_library"
Sam Delmerico512437b2023-03-17 11:34:15 -0400931 // Since parent cc_library already has these dependencies, we can add them as implementation
932 // deps so that they don't re-export
933 implementationDeps := linkerAttrs.deps.Clone()
934 implementationDeps.Append(linkerAttrs.implementationDeps)
935 implementationDynamicDeps := linkerAttrs.dynamicDeps.Clone()
936 implementationDynamicDeps.Append(linkerAttrs.implementationDynamicDeps)
Vinh Tran395a1e92022-09-16 18:27:29 -0400937
Vinh Trana3b8b782022-09-14 11:40:24 -0400938 ctx.CreateBazelTargetModule(
939 bazel.BazelTargetModuleProperties{
940 Rule_class: "cc_aidl_library",
941 Bzl_load_location: "//build/bazel/rules/cc:cc_aidl_library.bzl",
942 },
943 android.CommonAttributes{Name: ccAidlLibrarylabel},
944 &ccAidlLibraryAttributes{
Vinh Tran395a1e92022-09-16 18:27:29 -0400945 Deps: aidlLibs,
Sam Delmerico512437b2023-03-17 11:34:15 -0400946 Implementation_deps: *implementationDeps,
947 Implementation_dynamic_deps: *implementationDynamicDeps,
Liz Kammer2b3f56e2023-03-23 11:51:49 -0400948 Tags: apexAvailableTags,
949 sdkAttributes: sdkAttrs,
Vinh Trana3b8b782022-09-14 11:40:24 -0400950 },
951 )
952 label := &bazel.LabelAttribute{
953 Value: &bazel.Label{
954 Label: ":" + ccAidlLibrarylabel,
955 },
956 }
957 return label
958 }
Vinh Tran9f6796a2022-08-16 13:10:31 -0400959 }
960
Vinh Trana3b8b782022-09-14 11:40:24 -0400961 return nil
Vinh Tran9f6796a2022-08-16 13:10:31 -0400962}
963
Yu Liufc603162022-03-01 15:44:08 -0800964func bp2BuildParseSdkAttributes(module *Module) sdkAttributes {
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000965 return sdkAttributes{
966 Sdk_version: module.Properties.Sdk_version,
Yu Liufc603162022-03-01 15:44:08 -0800967 Min_sdk_version: module.Properties.Min_sdk_version,
968 }
969}
970
971type sdkAttributes struct {
972 Sdk_version *string
973 Min_sdk_version *string
974}
975
Jingwen Chen107c0de2021-04-09 10:43:12 +0000976// Convenience struct to hold all attributes parsed from linker properties.
977type linkerAttributes struct {
Liz Kammer54309532021-12-14 12:21:22 -0500978 deps bazel.LabelListAttribute
979 implementationDeps bazel.LabelListAttribute
980 dynamicDeps bazel.LabelListAttribute
981 implementationDynamicDeps bazel.LabelListAttribute
Cole Faust6b29f592022-08-09 09:50:56 -0700982 runtimeDeps bazel.LabelListAttribute
Liz Kammer54309532021-12-14 12:21:22 -0500983 wholeArchiveDeps bazel.LabelListAttribute
984 implementationWholeArchiveDeps bazel.LabelListAttribute
985 systemDynamicDeps bazel.LabelListAttribute
986 usedSystemDynamicDepAsDynamicDep map[string]bool
Liz Kammer7a210ac2021-09-22 15:52:58 -0400987
Rupert Shuttleworth484aa252021-12-10 07:22:53 -0500988 useVersionLib bazel.BoolAttribute
Jingwen Chen3d383bb2021-06-09 07:18:37 +0000989 linkopts bazel.StringListAttribute
Liz Kammerd2871182021-10-04 13:54:37 -0400990 additionalLinkerInputs bazel.LabelListAttribute
Jingwen Chen3d383bb2021-06-09 07:18:37 +0000991 stripKeepSymbols bazel.BoolAttribute
992 stripKeepSymbolsAndDebugFrame bazel.BoolAttribute
993 stripKeepSymbolsList bazel.StringListAttribute
994 stripAll bazel.BoolAttribute
995 stripNone bazel.BoolAttribute
Liz Kammer0eae52e2021-10-06 10:32:26 -0400996 features bazel.StringListAttribute
Rupert Shuttleworth143be942021-05-09 23:55:51 -0400997}
998
Liz Kammer54309532021-12-14 12:21:22 -0500999var (
1000 soongSystemSharedLibs = []string{"libc", "libm", "libdl"}
Liz Kammerbaced712022-09-16 09:01:29 -04001001 versionLib = "libbuildversion"
Liz Kammer54309532021-12-14 12:21:22 -05001002)
1003
Vinh Tran85fb07c2022-09-16 16:17:48 -04001004// resolveTargetApex re-adds the shared and static libs in target.apex.exclude_shared|static_libs props to non-apex variant
1005// since all libs are already excluded by default
Liz Kammer748d7072023-01-25 12:07:43 -05001006func (la *linkerAttributes) resolveTargetApexProp(ctx android.BazelConversionPathContext, props *BaseLinkerProperties) {
1007 excludeSharedLibs := bazelLabelForSharedDeps(ctx, props.Target.Apex.Exclude_shared_libs)
1008 sharedExcludes := bazel.LabelList{Excludes: excludeSharedLibs.Includes}
1009 sharedExcludesLabelList := bazel.LabelListAttribute{}
1010 sharedExcludesLabelList.SetSelectValue(bazel.InApexAxis, bazel.InApex, sharedExcludes)
Vinh Tran85fb07c2022-09-16 16:17:48 -04001011
Liz Kammer748d7072023-01-25 12:07:43 -05001012 la.dynamicDeps.Append(sharedExcludesLabelList)
1013 la.implementationDynamicDeps.Append(sharedExcludesLabelList)
1014
1015 excludeStaticLibs := bazelLabelForStaticDeps(ctx, props.Target.Apex.Exclude_static_libs)
1016 staticExcludes := bazel.LabelList{Excludes: excludeStaticLibs.Includes}
1017 staticExcludesLabelList := bazel.LabelListAttribute{}
1018 staticExcludesLabelList.SetSelectValue(bazel.InApexAxis, bazel.InApex, staticExcludes)
1019
1020 la.deps.Append(staticExcludesLabelList)
1021 la.implementationDeps.Append(staticExcludesLabelList)
Vinh Tran85fb07c2022-09-16 16:17:48 -04001022}
1023
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001024func (la *linkerAttributes) bp2buildForAxisAndConfig(ctx android.BazelConversionPathContext, module *Module, axis bazel.ConfigurationAxis, config string, props *BaseLinkerProperties) {
1025 isBinary := module.Binary()
Liz Kammere6583482021-10-19 13:56:10 -04001026 // Use a single variable to capture usage of nocrt in arch variants, so there's only 1 error message for this module
1027 var axisFeatures []string
Liz Kammer7a210ac2021-09-22 15:52:58 -04001028
Liz Kammercc2c1ef2022-03-21 09:03:29 -04001029 wholeStaticLibs := android.FirstUniqueStrings(props.Whole_static_libs)
Liz Kammerbaced712022-09-16 09:01:29 -04001030 staticLibs := android.FirstUniqueStrings(android.RemoveListFromList(props.Static_libs, wholeStaticLibs))
1031 if axis == bazel.NoConfigAxis {
1032 la.useVersionLib.SetSelectValue(axis, config, props.Use_version_lib)
1033 if proptools.Bool(props.Use_version_lib) {
1034 versionLibAlreadyInDeps := android.InList(versionLib, wholeStaticLibs)
1035 // remove from static libs so there is no duplicate dependency
1036 _, staticLibs = android.RemoveFromList(versionLib, staticLibs)
1037 // only add the dep if it is not in progress
1038 if !versionLibAlreadyInDeps {
1039 if isBinary {
1040 wholeStaticLibs = append(wholeStaticLibs, versionLib)
1041 } else {
1042 la.implementationWholeArchiveDeps.SetSelectValue(axis, config, bazelLabelForWholeDepsExcludes(ctx, []string{versionLib}, props.Exclude_static_libs))
1043 }
1044 }
1045 }
1046 }
1047
Liz Kammere6583482021-10-19 13:56:10 -04001048 // Excludes to parallel Soong:
1049 // https://cs.android.com/android/platform/superproject/+/master:build/soong/cc/linker.go;l=247-249;drc=088b53577dde6e40085ffd737a1ae96ad82fc4b0
Liz Kammerbaced712022-09-16 09:01:29 -04001050 la.wholeArchiveDeps.SetSelectValue(axis, config, bazelLabelForWholeDepsExcludes(ctx, wholeStaticLibs, props.Exclude_static_libs))
Liz Kammercc2c1ef2022-03-21 09:03:29 -04001051
Vinh Tran85fb07c2022-09-16 16:17:48 -04001052 staticDeps := maybePartitionExportedAndImplementationsDepsExcludes(
1053 ctx,
1054 !isBinary,
1055 staticLibs,
Liz Kammer748d7072023-01-25 12:07:43 -05001056 props.Exclude_static_libs,
Vinh Tran85fb07c2022-09-16 16:17:48 -04001057 props.Export_static_lib_headers,
1058 bazelLabelForStaticDepsExcludes,
1059 )
Liz Kammer7a210ac2021-09-22 15:52:58 -04001060
Liz Kammere6583482021-10-19 13:56:10 -04001061 headerLibs := android.FirstUniqueStrings(props.Header_libs)
1062 hDeps := maybePartitionExportedAndImplementationsDeps(ctx, !isBinary, headerLibs, props.Export_header_lib_headers, bazelLabelForHeaderDeps)
Jingwen Chen63930982021-03-24 10:04:33 -04001063
Liz Kammere6583482021-10-19 13:56:10 -04001064 (&hDeps.export).Append(staticDeps.export)
1065 la.deps.SetSelectValue(axis, config, hDeps.export)
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001066
Liz Kammere6583482021-10-19 13:56:10 -04001067 (&hDeps.implementation).Append(staticDeps.implementation)
1068 la.implementationDeps.SetSelectValue(axis, config, hDeps.implementation)
Liz Kammer0eae52e2021-10-06 10:32:26 -04001069
Liz Kammere6583482021-10-19 13:56:10 -04001070 systemSharedLibs := props.System_shared_libs
1071 // systemSharedLibs distinguishes between nil/empty list behavior:
1072 // nil -> use default values
1073 // empty list -> no values specified
1074 if len(systemSharedLibs) > 0 {
1075 systemSharedLibs = android.FirstUniqueStrings(systemSharedLibs)
1076 }
1077 la.systemDynamicDeps.SetSelectValue(axis, config, bazelLabelForSharedDeps(ctx, systemSharedLibs))
1078
1079 sharedLibs := android.FirstUniqueStrings(props.Shared_libs)
Liz Kammer54309532021-12-14 12:21:22 -05001080 excludeSharedLibs := props.Exclude_shared_libs
1081 usedSystem := android.FilterListPred(sharedLibs, func(s string) bool {
1082 return android.InList(s, soongSystemSharedLibs) && !android.InList(s, excludeSharedLibs)
1083 })
1084 for _, el := range usedSystem {
1085 if la.usedSystemDynamicDepAsDynamicDep == nil {
1086 la.usedSystemDynamicDepAsDynamicDep = map[string]bool{}
1087 }
1088 la.usedSystemDynamicDepAsDynamicDep[el] = true
1089 }
1090
Vinh Tran85fb07c2022-09-16 16:17:48 -04001091 sharedDeps := maybePartitionExportedAndImplementationsDepsExcludes(
1092 ctx,
1093 !isBinary,
1094 sharedLibs,
Liz Kammer748d7072023-01-25 12:07:43 -05001095 props.Exclude_shared_libs,
Vinh Tran85fb07c2022-09-16 16:17:48 -04001096 props.Export_shared_lib_headers,
1097 bazelLabelForSharedDepsExcludes,
1098 )
Liz Kammere6583482021-10-19 13:56:10 -04001099 la.dynamicDeps.SetSelectValue(axis, config, sharedDeps.export)
1100 la.implementationDynamicDeps.SetSelectValue(axis, config, sharedDeps.implementation)
Liz Kammer748d7072023-01-25 12:07:43 -05001101 la.resolveTargetApexProp(ctx, props)
Vinh Tran85fb07c2022-09-16 16:17:48 -04001102
Wei Li81852ca2022-07-27 00:22:06 -07001103 if axis == bazel.NoConfigAxis || (axis == bazel.OsConfigurationAxis && config == bazel.OsAndroid) {
Yu Liu10174ff2023-02-21 12:05:26 -08001104 // If a dependency in la.implementationDynamicDeps or la.dynamicDeps has stubs, its
1105 // stub variant should be used when the dependency is linked in a APEX. The
1106 // dependencies in NoConfigAxis and OsConfigurationAxis/OsAndroid are grouped by
1107 // having stubs or not, so Bazel select() statement can be used to choose
1108 // source/stub variants of them.
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001109 apexAvailable := module.ApexAvailable()
1110 setStubsForDynamicDeps(ctx, axis, config, apexAvailable, sharedDeps.export, &la.dynamicDeps, 0)
1111 setStubsForDynamicDeps(ctx, axis, config, apexAvailable, sharedDeps.implementation, &la.implementationDynamicDeps, 1)
Wei Li81852ca2022-07-27 00:22:06 -07001112 }
Liz Kammere6583482021-10-19 13:56:10 -04001113
1114 if !BoolDefault(props.Pack_relocations, packRelocationsDefault) {
1115 axisFeatures = append(axisFeatures, "disable_pack_relocations")
1116 }
1117
1118 if Bool(props.Allow_undefined_symbols) {
1119 axisFeatures = append(axisFeatures, "-no_undefined_symbols")
1120 }
1121
1122 var linkerFlags []string
1123 if len(props.Ldflags) > 0 {
Liz Kammerf38a8372022-02-04 15:39:00 -05001124 linkerFlags = append(linkerFlags, proptools.NinjaEscapeList(props.Ldflags)...)
Liz Kammere6583482021-10-19 13:56:10 -04001125 // binaries remove static flag if -shared is in the linker flags
1126 if isBinary && android.InList("-shared", linkerFlags) {
1127 axisFeatures = append(axisFeatures, "-static_flag")
1128 }
1129 }
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +00001130
Alex Márquez Pérez Muñíz Díaz Puras Thaureaux01ec55e2023-01-30 22:53:04 +00001131 if !props.libCrt() {
1132 axisFeatures = append(axisFeatures, "-use_libcrt")
1133 }
1134 if !props.crt() {
1135 axisFeatures = append(axisFeatures, "-link_crt")
1136 }
1137
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +00001138 // This must happen before the addition of flags for Version Script and
1139 // Dynamic List, as these flags must be split on spaces and those must not
1140 linkerFlags = parseCommandLineFlags(linkerFlags, filterOutClangUnknownCflags)
1141
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001142 additionalLinkerInputs := bazel.LabelList{}
Liz Kammere6583482021-10-19 13:56:10 -04001143 if props.Version_script != nil {
1144 label := android.BazelLabelForModuleSrcSingle(ctx, *props.Version_script)
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001145 additionalLinkerInputs.Add(&label)
Liz Kammere6583482021-10-19 13:56:10 -04001146 linkerFlags = append(linkerFlags, fmt.Sprintf("-Wl,--version-script,$(location %s)", label.Label))
1147 }
Alix773adaa2022-04-27 17:49:34 +00001148
1149 if props.Dynamic_list != nil {
1150 label := android.BazelLabelForModuleSrcSingle(ctx, *props.Dynamic_list)
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001151 additionalLinkerInputs.Add(&label)
Alix773adaa2022-04-27 17:49:34 +00001152 linkerFlags = append(linkerFlags, fmt.Sprintf("-Wl,--dynamic-list,$(location %s)", label.Label))
1153 }
1154
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001155 la.additionalLinkerInputs.SetSelectValue(axis, config, additionalLinkerInputs)
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +00001156 la.linkopts.SetSelectValue(axis, config, linkerFlags)
Liz Kammere6583482021-10-19 13:56:10 -04001157
1158 if axisFeatures != nil {
1159 la.features.SetSelectValue(axis, config, axisFeatures)
1160 }
Cole Faust6b29f592022-08-09 09:50:56 -07001161
1162 runtimeDeps := android.BazelLabelForModuleDepsExcludes(ctx, props.Runtime_libs, props.Exclude_runtime_libs)
1163 if !runtimeDeps.IsEmpty() {
1164 la.runtimeDeps.SetSelectValue(axis, config, runtimeDeps)
1165 }
Liz Kammere6583482021-10-19 13:56:10 -04001166}
1167
Spandan Das2518c022023-03-17 03:02:32 +00001168var (
1169 apiSurfaceModuleLibCurrentPackage = "@api_surfaces//" + android.ModuleLibApi.String() + "/current:"
1170)
1171
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001172func availableToSameApexes(a, b []string) bool {
1173 if len(a) == 0 && len(b) == 0 {
1174 return true
1175 }
1176 differ, _, _ := android.ListSetDifference(a, b)
1177 return !differ
1178}
1179
Yu Liu10174ff2023-02-21 12:05:26 -08001180func setStubsForDynamicDeps(ctx android.BazelConversionPathContext, axis bazel.ConfigurationAxis,
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001181 config string, apexAvailable []string, dynamicLibs bazel.LabelList, dynamicDeps *bazel.LabelListAttribute, ind int) {
1182
Yu Liu10174ff2023-02-21 12:05:26 -08001183 depsWithStubs := []bazel.Label{}
1184 for _, l := range dynamicLibs.Includes {
1185 dep, _ := ctx.ModuleFromName(l.OriginalModuleName)
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001186 if d, ok := dep.(*Module); ok && d.HasStubsVariants() {
1187 depApexAvailable := d.ApexAvailable()
1188 if !availableToSameApexes(apexAvailable, depApexAvailable) {
1189 depsWithStubs = append(depsWithStubs, l)
1190 }
Yu Liu10174ff2023-02-21 12:05:26 -08001191 }
1192 }
1193 if len(depsWithStubs) > 0 {
1194 implDynamicDeps := bazel.SubtractBazelLabelList(dynamicLibs, bazel.MakeLabelList(depsWithStubs))
1195 dynamicDeps.SetSelectValue(axis, config, implDynamicDeps)
1196
1197 stubLibLabels := []bazel.Label{}
1198 for _, l := range depsWithStubs {
Spandan Das2518c022023-03-17 03:02:32 +00001199 stubLabelInApiSurfaces := bazel.Label{
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001200 Label: apiSurfaceModuleLibCurrentPackage + strings.TrimPrefix(l.OriginalModuleName, ":"),
Spandan Das2518c022023-03-17 03:02:32 +00001201 }
1202 stubLibLabels = append(stubLibLabels, stubLabelInApiSurfaces)
Yu Liu10174ff2023-02-21 12:05:26 -08001203 }
1204 inApexSelectValue := dynamicDeps.SelectValue(bazel.OsAndInApexAxis, bazel.AndroidAndInApex)
1205 nonApexSelectValue := dynamicDeps.SelectValue(bazel.OsAndInApexAxis, bazel.AndroidAndNonApex)
1206 defaultSelectValue := dynamicDeps.SelectValue(bazel.OsAndInApexAxis, bazel.ConditionsDefaultConfigKey)
1207 if axis == bazel.NoConfigAxis {
1208 (&inApexSelectValue).Append(bazel.MakeLabelList(stubLibLabels))
1209 (&nonApexSelectValue).Append(bazel.MakeLabelList(depsWithStubs))
1210 (&defaultSelectValue).Append(bazel.MakeLabelList(depsWithStubs))
1211 dynamicDeps.SetSelectValue(bazel.OsAndInApexAxis, bazel.AndroidAndInApex, bazel.FirstUniqueBazelLabelList(inApexSelectValue))
1212 dynamicDeps.SetSelectValue(bazel.OsAndInApexAxis, bazel.AndroidAndNonApex, bazel.FirstUniqueBazelLabelList(nonApexSelectValue))
1213 dynamicDeps.SetSelectValue(bazel.OsAndInApexAxis, bazel.ConditionsDefaultConfigKey, bazel.FirstUniqueBazelLabelList(defaultSelectValue))
1214 } else if config == bazel.OsAndroid {
1215 (&inApexSelectValue).Append(bazel.MakeLabelList(stubLibLabels))
1216 (&nonApexSelectValue).Append(bazel.MakeLabelList(depsWithStubs))
1217 dynamicDeps.SetSelectValue(bazel.OsAndInApexAxis, bazel.AndroidAndInApex, bazel.FirstUniqueBazelLabelList(inApexSelectValue))
1218 dynamicDeps.SetSelectValue(bazel.OsAndInApexAxis, bazel.AndroidAndNonApex, bazel.FirstUniqueBazelLabelList(nonApexSelectValue))
1219 }
1220 }
1221}
1222
Jingwen Chen55bc8202021-11-02 06:40:51 +00001223func (la *linkerAttributes) convertStripProps(ctx android.BazelConversionPathContext, module *Module) {
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001224 bp2BuildPropParseHelper(ctx, module, &StripProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1225 if stripProperties, ok := props.(*StripProperties); ok {
1226 la.stripKeepSymbols.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols)
1227 la.stripKeepSymbolsList.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols_list)
1228 la.stripKeepSymbolsAndDebugFrame.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols_and_debug_frame)
1229 la.stripAll.SetSelectValue(axis, config, stripProperties.Strip.All)
1230 la.stripNone.SetSelectValue(axis, config, stripProperties.Strip.None)
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001231 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001232 })
Liz Kammere6583482021-10-19 13:56:10 -04001233}
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001234
Jingwen Chen55bc8202021-11-02 06:40:51 +00001235func (la *linkerAttributes) convertProductVariables(ctx android.BazelConversionPathContext, productVariableProps android.ProductConfigProperties) {
Jingwen Chen6ada5892021-09-17 11:38:09 +00001236
Liz Kammer47535c52021-06-02 16:02:22 -04001237 type productVarDep struct {
1238 // the name of the corresponding excludes field, if one exists
1239 excludesField string
1240 // reference to the bazel attribute that should be set for the given product variable config
1241 attribute *bazel.LabelListAttribute
Liz Kammer2d7bbe32021-06-10 18:20:06 -04001242
Jingwen Chen55bc8202021-11-02 06:40:51 +00001243 depResolutionFunc func(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList
Liz Kammer47535c52021-06-02 16:02:22 -04001244 }
1245
Zi Wang0a8a1292022-08-30 06:27:01 +00001246 // an intermediate attribute that holds Header_libs info, and will be appended to
1247 // implementationDeps at the end, to solve the confliction that both header_libs
1248 // and static_libs use implementationDeps.
1249 var headerDeps bazel.LabelListAttribute
1250
Liz Kammer47535c52021-06-02 16:02:22 -04001251 productVarToDepFields := map[string]productVarDep{
1252 // product variables do not support exclude_shared_libs
Jingwen Chen55bc8202021-11-02 06:40:51 +00001253 "Shared_libs": {attribute: &la.implementationDynamicDeps, depResolutionFunc: bazelLabelForSharedDepsExcludes},
1254 "Static_libs": {"Exclude_static_libs", &la.implementationDeps, bazelLabelForStaticDepsExcludes},
1255 "Whole_static_libs": {"Exclude_static_libs", &la.wholeArchiveDeps, bazelLabelForWholeDepsExcludes},
Zi Wang0a8a1292022-08-30 06:27:01 +00001256 "Header_libs": {attribute: &headerDeps, depResolutionFunc: bazelLabelForHeaderDepsExcludes},
Liz Kammer47535c52021-06-02 16:02:22 -04001257 }
1258
Liz Kammer47535c52021-06-02 16:02:22 -04001259 for name, dep := range productVarToDepFields {
1260 props, exists := productVariableProps[name]
1261 excludeProps, excludesExists := productVariableProps[dep.excludesField]
Sasha Smundak39a301c2022-12-29 17:11:49 -08001262 // if neither an include nor excludes property exists, then skip it
Liz Kammer47535c52021-06-02 16:02:22 -04001263 if !exists && !excludesExists {
1264 continue
1265 }
Jingwen Chen25825ca2021-11-15 12:28:43 +00001266 // Collect all the configurations that an include or exclude property exists for.
1267 // We want to iterate all configurations rather than either the include or exclude because, for a
1268 // particular configuration, we may have either only an include or an exclude to handle.
1269 productConfigProps := make(map[android.ProductConfigProperty]bool, len(props)+len(excludeProps))
1270 for p := range props {
1271 productConfigProps[p] = true
Liz Kammer47535c52021-06-02 16:02:22 -04001272 }
Jingwen Chen25825ca2021-11-15 12:28:43 +00001273 for p := range excludeProps {
1274 productConfigProps[p] = true
Liz Kammer47535c52021-06-02 16:02:22 -04001275 }
1276
Jingwen Chen25825ca2021-11-15 12:28:43 +00001277 for productConfigProp := range productConfigProps {
1278 prop, includesExists := props[productConfigProp]
1279 excludesProp, excludesExists := excludeProps[productConfigProp]
Liz Kammer47535c52021-06-02 16:02:22 -04001280 var includes, excludes []string
1281 var ok bool
1282 // if there was no includes/excludes property, casting fails and that's expected
Jingwen Chen25825ca2021-11-15 12:28:43 +00001283 if includes, ok = prop.([]string); includesExists && !ok {
Liz Kammer47535c52021-06-02 16:02:22 -04001284 ctx.ModuleErrorf("Could not convert product variable %s property", name)
1285 }
Jingwen Chen25825ca2021-11-15 12:28:43 +00001286 if excludes, ok = excludesProp.([]string); excludesExists && !ok {
Liz Kammer47535c52021-06-02 16:02:22 -04001287 ctx.ModuleErrorf("Could not convert product variable %s property", dep.excludesField)
1288 }
Liz Kammer2d7bbe32021-06-10 18:20:06 -04001289
Jingwen Chen58ff6802021-11-17 12:14:41 +00001290 dep.attribute.EmitEmptyList = productConfigProp.AlwaysEmit()
Jingwen Chen25825ca2021-11-15 12:28:43 +00001291 dep.attribute.SetSelectValue(
1292 productConfigProp.ConfigurationAxis(),
1293 productConfigProp.SelectKey(),
1294 dep.depResolutionFunc(ctx, android.FirstUniqueStrings(includes), excludes),
1295 )
Liz Kammer47535c52021-06-02 16:02:22 -04001296 }
1297 }
Zi Wang0a8a1292022-08-30 06:27:01 +00001298 la.implementationDeps.Append(headerDeps)
Liz Kammere6583482021-10-19 13:56:10 -04001299}
Liz Kammer47535c52021-06-02 16:02:22 -04001300
Liz Kammer54309532021-12-14 12:21:22 -05001301func (la *linkerAttributes) finalize(ctx android.BazelConversionPathContext) {
1302 // if system dynamic deps have the default value, any use of a system dynamic library used will
1303 // result in duplicate library errors for bionic OSes. Here, we explicitly exclude those libraries
Liz Kammer43345e22022-08-04 13:57:35 -04001304 // from bionic OSes and the no config case as these libraries only build for bionic OSes.
Liz Kammer54309532021-12-14 12:21:22 -05001305 if la.systemDynamicDeps.IsNil() && len(la.usedSystemDynamicDepAsDynamicDep) > 0 {
Cole Faust18994c72023-02-28 16:02:16 -08001306 toRemove := bazelLabelForSharedDeps(ctx, android.SortedKeys(la.usedSystemDynamicDepAsDynamicDep))
Liz Kammer43345e22022-08-04 13:57:35 -04001307 la.dynamicDeps.Exclude(bazel.NoConfigAxis, "", toRemove)
Liz Kammer54309532021-12-14 12:21:22 -05001308 la.dynamicDeps.Exclude(bazel.OsConfigurationAxis, "android", toRemove)
1309 la.dynamicDeps.Exclude(bazel.OsConfigurationAxis, "linux_bionic", toRemove)
Liz Kammer91487d42022-09-13 11:27:11 -04001310 la.implementationDynamicDeps.Exclude(bazel.NoConfigAxis, "", toRemove)
Liz Kammer54309532021-12-14 12:21:22 -05001311 la.implementationDynamicDeps.Exclude(bazel.OsConfigurationAxis, "android", toRemove)
1312 la.implementationDynamicDeps.Exclude(bazel.OsConfigurationAxis, "linux_bionic", toRemove)
Liz Kammer91487d42022-09-13 11:27:11 -04001313
1314 la.implementationDynamicDeps.Exclude(bazel.OsAndInApexAxis, bazel.ConditionsDefaultConfigKey, toRemove)
1315 la.implementationDynamicDeps.Exclude(bazel.OsAndInApexAxis, bazel.AndroidAndNonApex, toRemove)
1316 stubsToRemove := make([]bazel.Label, 0, len(la.usedSystemDynamicDepAsDynamicDep))
1317 for _, lib := range toRemove.Includes {
Spandan Das2518c022023-03-17 03:02:32 +00001318 stubLabelInApiSurfaces := bazel.Label{
1319 Label: apiSurfaceModuleLibCurrentPackage + lib.OriginalModuleName,
1320 }
1321 stubsToRemove = append(stubsToRemove, stubLabelInApiSurfaces)
Liz Kammer91487d42022-09-13 11:27:11 -04001322 }
1323 la.implementationDynamicDeps.Exclude(bazel.OsAndInApexAxis, bazel.AndroidAndInApex, bazel.MakeLabelList(stubsToRemove))
Liz Kammer54309532021-12-14 12:21:22 -05001324 }
1325
Liz Kammere6583482021-10-19 13:56:10 -04001326 la.deps.ResolveExcludes()
1327 la.implementationDeps.ResolveExcludes()
1328 la.dynamicDeps.ResolveExcludes()
1329 la.implementationDynamicDeps.ResolveExcludes()
1330 la.wholeArchiveDeps.ResolveExcludes()
1331 la.systemDynamicDeps.ForceSpecifyEmptyList = true
Liz Kammer54309532021-12-14 12:21:22 -05001332
Jingwen Chen91220d72021-03-24 02:18:33 -04001333}
1334
Jingwen Chened9c17d2021-04-13 07:14:55 +00001335// Relativize a list of root-relative paths with respect to the module's
1336// directory.
1337//
1338// include_dirs Soong prop are root-relative (b/183742505), but
1339// local_include_dirs, export_include_dirs and export_system_include_dirs are
1340// module dir relative. This function makes a list of paths entirely module dir
1341// relative.
1342//
1343// For the `include` attribute, Bazel wants the paths to be relative to the
1344// module.
1345func bp2BuildMakePathsRelativeToModule(ctx android.BazelConversionPathContext, paths []string) []string {
Rupert Shuttleworthb8151682021-04-06 20:06:21 +00001346 var relativePaths []string
1347 for _, path := range paths {
Jingwen Chened9c17d2021-04-13 07:14:55 +00001348 // Semantics of filepath.Rel: join(ModuleDir, rel(ModuleDir, path)) == path
1349 relativePath, err := filepath.Rel(ctx.ModuleDir(), path)
1350 if err != nil {
1351 panic(err)
1352 }
Rupert Shuttleworthb8151682021-04-06 20:06:21 +00001353 relativePaths = append(relativePaths, relativePath)
1354 }
1355 return relativePaths
1356}
1357
Liz Kammer5fad5012021-09-09 14:08:21 -04001358// BazelIncludes contains information about -I and -isystem paths from a module converted to Bazel
1359// attributes.
1360type BazelIncludes struct {
Liz Kammer1263d9b2021-12-10 14:28:20 -05001361 AbsoluteIncludes bazel.StringListAttribute
1362 Includes bazel.StringListAttribute
1363 SystemIncludes bazel.StringListAttribute
Liz Kammer5fad5012021-09-09 14:08:21 -04001364}
1365
Liz Kammer54549442022-05-11 13:55:06 -04001366func bp2BuildParseExportedIncludes(ctx android.BazelConversionPathContext, module *Module, includes *BazelIncludes) BazelIncludes {
Liz Kammer1263d9b2021-12-10 14:28:20 -05001367 var exported BazelIncludes
1368 if includes != nil {
1369 exported = *includes
1370 } else {
1371 exported = BazelIncludes{}
1372 }
Zi Wang1cb11802022-12-09 16:08:54 -08001373
1374 // cc library Export_include_dirs and Export_system_include_dirs are marked
1375 // "variant_prepend" in struct tag, set their prepend property to true to make
1376 // sure bp2build generates correct result.
1377 exported.Includes.Prepend = true
1378 exported.SystemIncludes.Prepend = true
1379
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001380 bp2BuildPropParseHelper(ctx, module, &FlagExporterProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1381 if flagExporterProperties, ok := props.(*FlagExporterProperties); ok {
1382 if len(flagExporterProperties.Export_include_dirs) > 0 {
1383 exported.Includes.SetSelectValue(axis, config, android.FirstUniqueStrings(append(exported.Includes.SelectValue(axis, config), flagExporterProperties.Export_include_dirs...)))
1384 }
1385 if len(flagExporterProperties.Export_system_include_dirs) > 0 {
1386 exported.SystemIncludes.SetSelectValue(axis, config, android.FirstUniqueStrings(append(exported.SystemIncludes.SelectValue(axis, config), flagExporterProperties.Export_system_include_dirs...)))
Rupert Shuttleworth375451e2021-04-26 07:49:08 -04001387 }
Rupert Shuttleworth375451e2021-04-26 07:49:08 -04001388 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001389 })
Liz Kammer1263d9b2021-12-10 14:28:20 -05001390 exported.AbsoluteIncludes.DeduplicateAxesFromBase()
Liz Kammer5fad5012021-09-09 14:08:21 -04001391 exported.Includes.DeduplicateAxesFromBase()
1392 exported.SystemIncludes.DeduplicateAxesFromBase()
Rupert Shuttleworth375451e2021-04-26 07:49:08 -04001393
Liz Kammer5fad5012021-09-09 14:08:21 -04001394 return exported
Jingwen Chen91220d72021-03-24 02:18:33 -04001395}
Chris Parsons953b3562021-09-20 15:14:39 -04001396
Trevor Radcliffecee4e052022-09-06 19:31:25 +00001397func BazelLabelNameForStaticModule(baseLabel string) string {
1398 return baseLabel + "_bp2build_cc_library_static"
1399}
1400
Jingwen Chen55bc8202021-11-02 06:40:51 +00001401func bazelLabelForStaticModule(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -04001402 label := android.BazelModuleLabel(ctx, m)
Sasha Smundak39a301c2022-12-29 17:11:49 -08001403 if ccModule, ok := m.(*Module); ok && ccModule.typ() == fullLibrary {
Trevor Radcliffecee4e052022-09-06 19:31:25 +00001404 return BazelLabelNameForStaticModule(label)
Chris Parsons953b3562021-09-20 15:14:39 -04001405 }
1406 return label
1407}
1408
Jingwen Chen55bc8202021-11-02 06:40:51 +00001409func bazelLabelForSharedModule(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -04001410 // cc_library, at it's root name, propagates the shared library, which depends on the static
1411 // library.
1412 return android.BazelModuleLabel(ctx, m)
1413}
1414
Jingwen Chen55bc8202021-11-02 06:40:51 +00001415func bazelLabelForStaticWholeModuleDeps(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -04001416 label := bazelLabelForStaticModule(ctx, m)
1417 if aModule, ok := m.(android.Module); ok {
1418 if android.IsModulePrebuilt(aModule) {
1419 label += "_alwayslink"
1420 }
1421 }
1422 return label
1423}
1424
Jingwen Chen55bc8202021-11-02 06:40:51 +00001425func bazelLabelForWholeDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001426 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForStaticWholeModuleDeps)
1427}
1428
Jingwen Chen55bc8202021-11-02 06:40:51 +00001429func bazelLabelForWholeDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001430 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForStaticWholeModuleDeps)
1431}
1432
Jingwen Chen55bc8202021-11-02 06:40:51 +00001433func bazelLabelForStaticDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001434 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForStaticModule)
1435}
1436
Jingwen Chen55bc8202021-11-02 06:40:51 +00001437func bazelLabelForStaticDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001438 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForStaticModule)
1439}
1440
Jingwen Chen55bc8202021-11-02 06:40:51 +00001441func bazelLabelForSharedDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001442 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForSharedModule)
1443}
1444
Jingwen Chen55bc8202021-11-02 06:40:51 +00001445func bazelLabelForHeaderDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001446 // This is not elegant, but bp2build's shared library targets only propagate
1447 // their header information as part of the normal C++ provider.
1448 return bazelLabelForSharedDeps(ctx, modules)
1449}
1450
Zi Wang0a8a1292022-08-30 06:27:01 +00001451func bazelLabelForHeaderDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
1452 // This is only used when product_variable header_libs is processed, to follow
1453 // the pattern of depResolutionFunc
1454 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForSharedModule)
1455}
1456
Jingwen Chen55bc8202021-11-02 06:40:51 +00001457func bazelLabelForSharedDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001458 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForSharedModule)
1459}
Liz Kammer2b8004b2021-10-04 13:55:44 -04001460
1461type binaryLinkerAttrs struct {
1462 Linkshared *bool
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05001463 Suffix bazel.StringAttribute
Liz Kammer2b8004b2021-10-04 13:55:44 -04001464}
1465
Jingwen Chen55bc8202021-11-02 06:40:51 +00001466func bp2buildBinaryLinkerProps(ctx android.BazelConversionPathContext, m *Module) binaryLinkerAttrs {
Liz Kammer2b8004b2021-10-04 13:55:44 -04001467 attrs := binaryLinkerAttrs{}
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001468 bp2BuildPropParseHelper(ctx, m, &BinaryLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1469 linkerProps := props.(*BinaryLinkerProperties)
1470 staticExecutable := linkerProps.Static_executable
1471 if axis == bazel.NoConfigAxis {
1472 if linkBinaryShared := !proptools.Bool(staticExecutable); !linkBinaryShared {
1473 attrs.Linkshared = &linkBinaryShared
Liz Kammer2b8004b2021-10-04 13:55:44 -04001474 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001475 } else if staticExecutable != nil {
1476 // TODO(b/202876379): Static_executable is arch-variant; however, linkshared is a
1477 // nonconfigurable attribute. Only 4 AOSP modules use this feature, defer handling
1478 ctx.ModuleErrorf("bp2build cannot migrate a module with arch/target-specific static_executable values")
Liz Kammer2b8004b2021-10-04 13:55:44 -04001479 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05001480 if suffix := linkerProps.Suffix; suffix != nil {
1481 attrs.Suffix.SetSelectValue(axis, config, suffix)
1482 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001483 })
Liz Kammer2b8004b2021-10-04 13:55:44 -04001484
1485 return attrs
1486}
Trevor Radcliffedb7e0262022-10-28 16:48:18 +00001487
1488func bp2buildSanitizerFeatures(ctx android.BazelConversionPathContext, m *Module) bazel.StringListAttribute {
1489 sanitizerFeatures := bazel.StringListAttribute{}
1490 bp2BuildPropParseHelper(ctx, m, &SanitizeProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1491 var features []string
1492 if sanitizerProps, ok := props.(*SanitizeProperties); ok {
1493 if sanitizerProps.Sanitize.Integer_overflow != nil && *sanitizerProps.Sanitize.Integer_overflow {
1494 features = append(features, "ubsan_integer_overflow")
1495 }
1496 for _, sanitizer := range sanitizerProps.Sanitize.Misc_undefined {
1497 features = append(features, "ubsan_"+sanitizer)
1498 }
1499 sanitizerFeatures.SetSelectValue(axis, config, features)
1500 }
1501 })
1502 return sanitizerFeatures
1503}
Trevor Radcliffe56b1a2b2023-02-06 21:58:30 +00001504
1505func bp2buildLtoFeatures(ctx android.BazelConversionPathContext, m *Module) bazel.StringListAttribute {
1506 lto_feature_name := "android_thin_lto"
1507 ltoBoolFeatures := bazel.BoolAttribute{}
1508 bp2BuildPropParseHelper(ctx, m, &LTOProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1509 if ltoProps, ok := props.(*LTOProperties); ok {
1510 thinProp := ltoProps.Lto.Thin != nil && *ltoProps.Lto.Thin
1511 thinPropSetToFalse := ltoProps.Lto.Thin != nil && !*ltoProps.Lto.Thin
1512 neverProp := ltoProps.Lto.Never != nil && *ltoProps.Lto.Never
1513 if thinProp {
1514 ltoBoolFeatures.SetSelectValue(axis, config, BoolPtr(true))
1515 return
1516 }
1517 if neverProp || thinPropSetToFalse {
1518 if thinProp {
1519 ctx.ModuleErrorf("lto.thin and lto.never are mutually exclusive but were specified together")
1520 } else {
1521 ltoBoolFeatures.SetSelectValue(axis, config, BoolPtr(false))
1522 }
1523 return
1524 }
1525 }
1526 ltoBoolFeatures.SetSelectValue(axis, config, nil)
1527 })
1528
1529 props := m.GetArchVariantProperties(ctx, &LTOProperties{})
1530 ltoStringFeatures, err := ltoBoolFeatures.ToStringListAttribute(func(boolPtr *bool, axis bazel.ConfigurationAxis, config string) []string {
1531 if boolPtr == nil {
1532 return []string{}
1533 }
1534 if !*boolPtr {
1535 return []string{"-" + lto_feature_name}
1536 }
1537 features := []string{lto_feature_name}
1538 if ltoProps, ok := props[axis][config].(*LTOProperties); ok {
1539 if ltoProps.Whole_program_vtables != nil && *ltoProps.Whole_program_vtables {
1540 features = append(features, "android_thin_lto_whole_program_vtables")
1541 }
1542 }
1543 return features
1544 })
1545 if err != nil {
1546 ctx.ModuleErrorf("Error processing LTO attributes: %s", err)
1547 }
1548 return ltoStringFeatures
1549}