blob: 5029541aaecc3f18b79122549294dc5b520b0985 [file] [log] [blame]
Jingwen Chen91220d72021-03-24 02:18:33 -04001// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
Cole Faust7071a052022-07-29 15:58:33 -07007// http://www.apache.org/licenses/LICENSE-2.0
Jingwen Chen91220d72021-03-24 02:18:33 -04008//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14package cc
15
16import (
Liz Kammerd2871182021-10-04 13:54:37 -040017 "fmt"
Jingwen Chened9c17d2021-04-13 07:14:55 +000018 "path/filepath"
Jingwen Chen3950cd62021-05-12 04:33:00 +000019 "strings"
Spandan Das4242f102023-04-19 22:31:54 +000020 "sync"
Chris Parsons484e50a2021-05-13 15:13:04 -040021
22 "android/soong/android"
23 "android/soong/bazel"
Alix1be00d42022-05-16 22:56:04 +000024 "android/soong/cc/config"
Liz Kammer7a210ac2021-09-22 15:52:58 -040025
Chris Parsons953b3562021-09-20 15:14:39 -040026 "github.com/google/blueprint"
Liz Kammerba7a9c52021-05-26 08:45:30 -040027
28 "github.com/google/blueprint/proptools"
Jingwen Chen91220d72021-03-24 02:18:33 -040029)
30
Liz Kammerae3994e2021-10-19 09:45:48 -040031const (
Trevor Radcliffecee4e052022-09-06 19:31:25 +000032 cSrcPartition = "c"
33 asSrcPartition = "as"
34 asmSrcPartition = "asm"
35 lSrcPartition = "l"
36 llSrcPartition = "ll"
37 cppSrcPartition = "cpp"
38 protoSrcPartition = "proto"
39 aidlSrcPartition = "aidl"
40 syspropSrcPartition = "sysprop"
Spandan Dasdf4c2132023-05-09 23:58:52 +000041 yaccSrcPartition = "yacc"
Liz Kammer91487d42022-09-13 11:27:11 -040042
43 stubsSuffix = "_stub_libs_current"
Liz Kammerae3994e2021-10-19 09:45:48 -040044)
45
Liz Kammer2222c6b2021-05-24 15:41:47 -040046// staticOrSharedAttributes are the Bazel-ified versions of StaticOrSharedProperties --
Jingwen Chenbcf53042021-05-26 04:42:42 +000047// properties which apply to either the shared or static version of a cc_library module.
Liz Kammer2222c6b2021-05-24 15:41:47 -040048type staticOrSharedAttributes struct {
Vinh Tran9f6796a2022-08-16 13:10:31 -040049 Srcs bazel.LabelListAttribute
50 Srcs_c bazel.LabelListAttribute
51 Srcs_as bazel.LabelListAttribute
52 Srcs_aidl bazel.LabelListAttribute
53 Hdrs bazel.LabelListAttribute
54 Copts bazel.StringListAttribute
Jingwen Chen14a8bda2021-06-02 11:10:02 +000055
Liz Kammer12615db2021-09-28 09:19:17 -040056 Deps bazel.LabelListAttribute
57 Implementation_deps bazel.LabelListAttribute
58 Dynamic_deps bazel.LabelListAttribute
59 Implementation_dynamic_deps bazel.LabelListAttribute
60 Whole_archive_deps bazel.LabelListAttribute
61 Implementation_whole_archive_deps bazel.LabelListAttribute
Cole Faust6b29f592022-08-09 09:50:56 -070062 Runtime_deps bazel.LabelListAttribute
Chris Parsons51f8c392021-08-03 21:01:05 -040063
64 System_dynamic_deps bazel.LabelListAttribute
Chris Parsons58852a02021-12-09 18:10:18 -050065
66 Enabled bazel.BoolAttribute
Yu Liufc603162022-03-01 15:44:08 -080067
Yu Liuf01a0f02022-12-07 15:45:30 -080068 Native_coverage *bool
Yu Liu8d82ac52022-05-17 15:13:28 -070069
Liz Kammeraceec252023-03-24 09:46:36 -040070 Apex_available []string
71
Trevor Radcliffea8b44162023-04-14 18:25:24 +000072 Features bazel.StringListAttribute
73
Yu Liufc603162022-03-01 15:44:08 -080074 sdkAttributes
Sam Delmericofb3bb322022-10-21 10:42:24 -040075
76 tidyAttributes
77}
78
79type tidyAttributes struct {
Sam Delmerico63f0c932023-03-14 14:05:28 -040080 Tidy *string
Sam Delmericofb3bb322022-10-21 10:42:24 -040081 Tidy_flags []string
82 Tidy_checks []string
83 Tidy_checks_as_errors []string
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -040084 Tidy_disabled_srcs bazel.LabelListAttribute
Sam Delmerico4c902d62022-11-02 14:17:15 -040085 Tidy_timeout_srcs bazel.LabelListAttribute
Sam Delmericofb3bb322022-10-21 10:42:24 -040086}
87
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -040088func (m *Module) convertTidyAttributes(ctx android.BaseMutatorContext, moduleAttrs *tidyAttributes) {
Sam Delmericofb3bb322022-10-21 10:42:24 -040089 for _, f := range m.features {
90 if tidy, ok := f.(*tidyFeature); ok {
Sam Delmerico63f0c932023-03-14 14:05:28 -040091 var tidyAttr *string
92 if tidy.Properties.Tidy != nil {
93 if *tidy.Properties.Tidy {
94 tidyAttr = proptools.StringPtr("local")
95 } else {
96 tidyAttr = proptools.StringPtr("never")
97 }
98 }
99 moduleAttrs.Tidy = tidyAttr
Sam Delmericofb3bb322022-10-21 10:42:24 -0400100 moduleAttrs.Tidy_flags = tidy.Properties.Tidy_flags
101 moduleAttrs.Tidy_checks = tidy.Properties.Tidy_checks
102 moduleAttrs.Tidy_checks_as_errors = tidy.Properties.Tidy_checks_as_errors
103 }
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400104
105 }
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400106 archVariantProps := m.GetArchVariantProperties(ctx, &BaseCompilerProperties{})
107 for axis, configToProps := range archVariantProps {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800108 for cfg, _props := range configToProps {
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400109 if archProps, ok := _props.(*BaseCompilerProperties); ok {
110 archDisabledSrcs := android.BazelLabelForModuleSrc(ctx, archProps.Tidy_disabled_srcs)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800111 moduleAttrs.Tidy_disabled_srcs.SetSelectValue(axis, cfg, archDisabledSrcs)
Sam Delmerico4c902d62022-11-02 14:17:15 -0400112 archTimeoutSrcs := android.BazelLabelForModuleSrc(ctx, archProps.Tidy_timeout_srcs)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800113 moduleAttrs.Tidy_timeout_srcs.SetSelectValue(axis, cfg, archTimeoutSrcs)
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400114 }
115 }
Sam Delmericofb3bb322022-10-21 10:42:24 -0400116 }
Jingwen Chen53681ef2021-04-29 08:15:13 +0000117}
118
Sam Delmericoc7681022022-02-04 21:01:20 +0000119// groupSrcsByExtension partitions `srcs` into groups based on file extension.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000120func groupSrcsByExtension(ctx android.BazelConversionPathContext, srcs bazel.LabelListAttribute) bazel.PartitionToLabelListAttribute {
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400121 // Convert filegroup dependencies into extension-specific filegroups filtered in the filegroup.bzl
122 // macro.
123 addSuffixForFilegroup := func(suffix string) bazel.LabelMapper {
Vinh Tran9f6796a2022-08-16 13:10:31 -0400124 return func(otherModuleCtx bazel.OtherModuleContext, label bazel.Label) (string, bool) {
125
126 m, exists := otherModuleCtx.ModuleFromName(label.OriginalModuleName)
Liz Kammer12615db2021-09-28 09:19:17 -0400127 labelStr := label.Label
Vinh Tran9f6796a2022-08-16 13:10:31 -0400128 if !exists || !android.IsFilegroup(otherModuleCtx, m) {
129 return labelStr, false
130 }
Yu Liu2aa806b2022-09-01 11:54:47 -0700131 // If the filegroup is already converted to aidl_library or proto_library,
132 // skip creating _c_srcs, _as_srcs, _cpp_srcs filegroups
133 fg, _ := m.(android.FileGroupAsLibrary)
134 if fg.ShouldConvertToAidlLibrary(ctx) || fg.ShouldConvertToProtoLibrary(ctx) {
Liz Kammer12615db2021-09-28 09:19:17 -0400135 return labelStr, false
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000136 }
Liz Kammer12615db2021-09-28 09:19:17 -0400137 return labelStr + suffix, true
Chris Parsons5a34ffb2021-07-21 14:34:58 -0400138 }
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000139 }
140
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400141 // TODO(b/190006308): Handle language detection of sources in a Bazel rule.
Sam Delmericoc7681022022-02-04 21:01:20 +0000142 labels := bazel.LabelPartitions{
143 protoSrcPartition: android.ProtoSrcLabelPartition,
Liz Kammeraabfb5d2021-12-08 15:25:06 -0500144 cSrcPartition: bazel.LabelPartition{Extensions: []string{".c"}, LabelMapper: addSuffixForFilegroup("_c_srcs")},
145 asSrcPartition: bazel.LabelPartition{Extensions: []string{".s", ".S"}, LabelMapper: addSuffixForFilegroup("_as_srcs")},
Cole Faust7071a052022-07-29 15:58:33 -0700146 asmSrcPartition: bazel.LabelPartition{Extensions: []string{".asm"}},
Vinh Tran9f6796a2022-08-16 13:10:31 -0400147 aidlSrcPartition: android.AidlSrcLabelPartition,
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000148 // TODO(http://b/231968910): If there is ever a filegroup target that
149 // contains .l or .ll files we will need to find a way to add a
150 // LabelMapper for these that identifies these filegroups and
151 // converts them appropriately
152 lSrcPartition: bazel.LabelPartition{Extensions: []string{".l"}},
153 llSrcPartition: bazel.LabelPartition{Extensions: []string{".ll"}},
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400154 // C++ is the "catch-all" group, and comprises generated sources because we don't
155 // know the language of these sources until the genrule is executed.
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000156 cppSrcPartition: bazel.LabelPartition{Extensions: []string{".cpp", ".cc", ".cxx", ".mm"}, LabelMapper: addSuffixForFilegroup("_cpp_srcs"), Keep_remainder: true},
157 syspropSrcPartition: bazel.LabelPartition{Extensions: []string{".sysprop"}},
Spandan Dasdf4c2132023-05-09 23:58:52 +0000158 yaccSrcPartition: bazel.LabelPartition{Extensions: []string{".y", "yy"}},
Sam Delmericoc7681022022-02-04 21:01:20 +0000159 }
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000160
Sam Delmericoc7681022022-02-04 21:01:20 +0000161 return bazel.PartitionLabelListAttribute(ctx, &srcs, labels)
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000162}
163
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000164// bp2BuildParseLibProps returns the attributes for a variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000165func bp2BuildParseLibProps(ctx android.BazelConversionPathContext, module *Module, isStatic bool) staticOrSharedAttributes {
Jingwen Chen53681ef2021-04-29 08:15:13 +0000166 lib, ok := module.compiler.(*libraryDecorator)
167 if !ok {
Liz Kammer2222c6b2021-05-24 15:41:47 -0400168 return staticOrSharedAttributes{}
Jingwen Chen53681ef2021-04-29 08:15:13 +0000169 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000170 return bp2buildParseStaticOrSharedProps(ctx, module, lib, isStatic)
171}
Jingwen Chen53681ef2021-04-29 08:15:13 +0000172
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000173// bp2buildParseSharedProps returns the attributes for the shared variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000174func bp2BuildParseSharedProps(ctx android.BazelConversionPathContext, module *Module) staticOrSharedAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000175 return bp2BuildParseLibProps(ctx, module, false)
Jingwen Chen53681ef2021-04-29 08:15:13 +0000176}
177
178// bp2buildParseStaticProps returns the attributes for the static variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000179func bp2BuildParseStaticProps(ctx android.BazelConversionPathContext, module *Module) staticOrSharedAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000180 return bp2BuildParseLibProps(ctx, module, true)
Liz Kammer2222c6b2021-05-24 15:41:47 -0400181}
182
Liz Kammer7a210ac2021-09-22 15:52:58 -0400183type depsPartition struct {
184 export bazel.LabelList
185 implementation bazel.LabelList
186}
187
Jingwen Chen55bc8202021-11-02 06:40:51 +0000188type bazelLabelForDepsFn func(android.BazelConversionPathContext, []string) bazel.LabelList
Liz Kammer7a210ac2021-09-22 15:52:58 -0400189
Jingwen Chen55bc8202021-11-02 06:40:51 +0000190func maybePartitionExportedAndImplementationsDeps(ctx android.BazelConversionPathContext, exportsDeps bool, allDeps, exportedDeps []string, fn bazelLabelForDepsFn) depsPartition {
Liz Kammer2b8004b2021-10-04 13:55:44 -0400191 if !exportsDeps {
192 return depsPartition{
193 implementation: fn(ctx, allDeps),
194 }
195 }
196
Liz Kammer7a210ac2021-09-22 15:52:58 -0400197 implementation, export := android.FilterList(allDeps, exportedDeps)
198
199 return depsPartition{
200 export: fn(ctx, export),
201 implementation: fn(ctx, implementation),
202 }
203}
204
Jingwen Chen55bc8202021-11-02 06:40:51 +0000205type bazelLabelForDepsExcludesFn func(android.BazelConversionPathContext, []string, []string) bazel.LabelList
Liz Kammer7a210ac2021-09-22 15:52:58 -0400206
Jingwen Chen55bc8202021-11-02 06:40:51 +0000207func maybePartitionExportedAndImplementationsDepsExcludes(ctx android.BazelConversionPathContext, exportsDeps bool, allDeps, excludes, exportedDeps []string, fn bazelLabelForDepsExcludesFn) depsPartition {
Liz Kammer2b8004b2021-10-04 13:55:44 -0400208 if !exportsDeps {
209 return depsPartition{
210 implementation: fn(ctx, allDeps, excludes),
211 }
212 }
Liz Kammer7a210ac2021-09-22 15:52:58 -0400213 implementation, export := android.FilterList(allDeps, exportedDeps)
214
215 return depsPartition{
216 export: fn(ctx, export, excludes),
217 implementation: fn(ctx, implementation, excludes),
218 }
219}
220
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000221func bp2BuildPropParseHelper(ctx android.ArchVariantContext, module *Module, propsType interface{}, parseFunc func(axis bazel.ConfigurationAxis, config string, props interface{})) {
222 for axis, configToProps := range module.GetArchVariantProperties(ctx, propsType) {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800223 for cfg, props := range configToProps {
224 parseFunc(axis, cfg, props)
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000225 }
226 }
227}
228
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000229// Parses properties common to static and shared libraries. Also used for prebuilt libraries.
Liz Kammeraceec252023-03-24 09:46:36 -0400230func bp2buildParseStaticOrSharedProps(ctx android.BazelConversionPathContext, module *Module, lib *libraryDecorator, isStatic bool) staticOrSharedAttributes {
Liz Kammer135bf552021-08-11 10:46:06 -0400231 attrs := staticOrSharedAttributes{}
Jingwen Chenbcf53042021-05-26 04:42:42 +0000232
Liz Kammer9abd62d2021-05-21 08:37:59 -0400233 setAttrs := func(axis bazel.ConfigurationAxis, config string, props StaticOrSharedProperties) {
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000234 attrs.Copts.SetSelectValue(axis, config, parseCommandLineFlags(props.Cflags, filterOutStdFlag, filterOutHiddenVisibility))
Jingwen Chenc4dc9b42021-06-11 12:51:48 +0000235 attrs.Srcs.SetSelectValue(axis, config, android.BazelLabelForModuleSrc(ctx, props.Srcs))
Chris Parsons953b3562021-09-20 15:14:39 -0400236 attrs.System_dynamic_deps.SetSelectValue(axis, config, bazelLabelForSharedDeps(ctx, props.System_shared_libs))
Liz Kammer7a210ac2021-09-22 15:52:58 -0400237
Liz Kammer2b8004b2021-10-04 13:55:44 -0400238 staticDeps := maybePartitionExportedAndImplementationsDeps(ctx, true, props.Static_libs, props.Export_static_lib_headers, bazelLabelForStaticDeps)
Liz Kammer7a210ac2021-09-22 15:52:58 -0400239 attrs.Deps.SetSelectValue(axis, config, staticDeps.export)
240 attrs.Implementation_deps.SetSelectValue(axis, config, staticDeps.implementation)
241
Liz Kammer2b8004b2021-10-04 13:55:44 -0400242 sharedDeps := maybePartitionExportedAndImplementationsDeps(ctx, true, props.Shared_libs, props.Export_shared_lib_headers, bazelLabelForSharedDeps)
Liz Kammer7a210ac2021-09-22 15:52:58 -0400243 attrs.Dynamic_deps.SetSelectValue(axis, config, sharedDeps.export)
244 attrs.Implementation_dynamic_deps.SetSelectValue(axis, config, sharedDeps.implementation)
245
246 attrs.Whole_archive_deps.SetSelectValue(axis, config, bazelLabelForWholeDeps(ctx, props.Whole_static_libs))
Chris Parsons58852a02021-12-09 18:10:18 -0500247 attrs.Enabled.SetSelectValue(axis, config, props.Enabled)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000248 }
Liz Kammer135bf552021-08-11 10:46:06 -0400249 // system_dynamic_deps distinguishes between nil/empty list behavior:
250 // nil -> use default values
251 // empty list -> no values specified
252 attrs.System_dynamic_deps.ForceSpecifyEmptyList = true
Jingwen Chenbcf53042021-05-26 04:42:42 +0000253
Liz Kammeraceec252023-03-24 09:46:36 -0400254 var apexAvailable []string
Jingwen Chenbcf53042021-05-26 04:42:42 +0000255 if isStatic {
Liz Kammeraceec252023-03-24 09:46:36 -0400256 apexAvailable = lib.StaticProperties.Static.Apex_available
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000257 bp2BuildPropParseHelper(ctx, module, &StaticProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
258 if staticOrSharedProps, ok := props.(*StaticProperties); ok {
259 setAttrs(axis, config, staticOrSharedProps.Static)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000260 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000261 })
Jingwen Chenbcf53042021-05-26 04:42:42 +0000262 } else {
Liz Kammeraceec252023-03-24 09:46:36 -0400263 apexAvailable = lib.SharedProperties.Shared.Apex_available
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000264 bp2BuildPropParseHelper(ctx, module, &SharedProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
265 if staticOrSharedProps, ok := props.(*SharedProperties); ok {
266 setAttrs(axis, config, staticOrSharedProps.Shared)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000267 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000268 })
Jingwen Chenbcf53042021-05-26 04:42:42 +0000269 }
270
Liz Kammerae3994e2021-10-19 09:45:48 -0400271 partitionedSrcs := groupSrcsByExtension(ctx, attrs.Srcs)
272 attrs.Srcs = partitionedSrcs[cppSrcPartition]
273 attrs.Srcs_c = partitionedSrcs[cSrcPartition]
274 attrs.Srcs_as = partitionedSrcs[asSrcPartition]
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000275
Spandan Das39b6cc52023-04-12 19:05:49 +0000276 attrs.Apex_available = android.ConvertApexAvailableToTagsWithoutTestApexes(ctx.(android.TopDownMutatorContext), apexAvailable)
Liz Kammeraceec252023-03-24 09:46:36 -0400277
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000278 attrs.Features.Append(convertHiddenVisibilityToFeatureStaticOrShared(ctx, module, isStatic))
279
Liz Kammer12615db2021-09-28 09:19:17 -0400280 if !partitionedSrcs[protoSrcPartition].IsEmpty() {
281 // TODO(b/208815215): determine whether this is used and add support if necessary
282 ctx.ModuleErrorf("Migrating static/shared only proto srcs is not currently supported")
283 }
284
Jingwen Chenbcf53042021-05-26 04:42:42 +0000285 return attrs
Jingwen Chen53681ef2021-04-29 08:15:13 +0000286}
287
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400288// Convenience struct to hold all attributes parsed from prebuilt properties.
289type prebuiltAttributes struct {
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000290 Src bazel.LabelAttribute
291 Enabled bazel.BoolAttribute
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400292}
293
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000294func parseSrc(ctx android.BazelConversionPathContext, srcLabelAttribute *bazel.LabelAttribute, axis bazel.ConfigurationAxis, config string, srcs []string) {
295 srcFileError := func() {
296 ctx.ModuleErrorf("parseSrc: Expected at most one source file for %s %s\n", axis, config)
297 }
298 if len(srcs) > 1 {
299 srcFileError()
300 return
301 } else if len(srcs) == 0 {
302 return
303 }
304 if srcLabelAttribute.SelectValue(axis, config) != nil {
305 srcFileError()
306 return
307 }
308 srcLabelAttribute.SetSelectValue(axis, config, android.BazelLabelForModuleSrcSingle(ctx, srcs[0]))
309}
310
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000311// NOTE: Used outside of Soong repo project, in the clangprebuilts.go bootstrap_go_package
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000312func Bp2BuildParsePrebuiltLibraryProps(ctx android.BazelConversionPathContext, module *Module, isStatic bool) prebuiltAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000313
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400314 var srcLabelAttribute bazel.LabelAttribute
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000315 bp2BuildPropParseHelper(ctx, module, &prebuiltLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
316 if prebuiltLinkerProperties, ok := props.(*prebuiltLinkerProperties); ok {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000317 parseSrc(ctx, &srcLabelAttribute, axis, config, prebuiltLinkerProperties.Srcs)
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000318 }
319 })
320
321 var enabledLabelAttribute bazel.BoolAttribute
322 parseAttrs := func(axis bazel.ConfigurationAxis, config string, props StaticOrSharedProperties) {
323 if props.Enabled != nil {
324 enabledLabelAttribute.SetSelectValue(axis, config, props.Enabled)
325 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000326 parseSrc(ctx, &srcLabelAttribute, axis, config, props.Srcs)
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000327 }
328
329 if isStatic {
330 bp2BuildPropParseHelper(ctx, module, &StaticProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
331 if staticProperties, ok := props.(*StaticProperties); ok {
332 parseAttrs(axis, config, staticProperties.Static)
333 }
334 })
335 } else {
336 bp2BuildPropParseHelper(ctx, module, &SharedProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
337 if sharedProperties, ok := props.(*SharedProperties); ok {
338 parseAttrs(axis, config, sharedProperties.Shared)
339 }
340 })
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400341 }
342
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400343 return prebuiltAttributes{
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000344 Src: srcLabelAttribute,
345 Enabled: enabledLabelAttribute,
346 }
347}
348
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000349func bp2BuildParsePrebuiltBinaryProps(ctx android.BazelConversionPathContext, module *Module) prebuiltAttributes {
350 var srcLabelAttribute bazel.LabelAttribute
351 bp2BuildPropParseHelper(ctx, module, &prebuiltLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
352 if props, ok := props.(*prebuiltLinkerProperties); ok {
353 parseSrc(ctx, &srcLabelAttribute, axis, config, props.Srcs)
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000354 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000355 })
356
357 return prebuiltAttributes{
358 Src: srcLabelAttribute,
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400359 }
360}
361
Colin Crossc5075e92022-12-05 16:46:39 -0800362func bp2BuildParsePrebuiltObjectProps(ctx android.BazelConversionPathContext, module *Module) prebuiltAttributes {
363 var srcLabelAttribute bazel.LabelAttribute
364 bp2BuildPropParseHelper(ctx, module, &prebuiltObjectProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
365 if props, ok := props.(*prebuiltObjectProperties); ok {
366 parseSrc(ctx, &srcLabelAttribute, axis, config, props.Srcs)
367 }
368 })
369
370 return prebuiltAttributes{
371 Src: srcLabelAttribute,
372 }
373}
374
Liz Kammere6583482021-10-19 13:56:10 -0400375type baseAttributes struct {
376 compilerAttributes
377 linkerAttributes
Liz Kammer12615db2021-09-28 09:19:17 -0400378
Trevor Radcliffedb7e0262022-10-28 16:48:18 +0000379 // A combination of compilerAttributes.features and linkerAttributes.features, as well as sanitizer features
Cole Faust5fa4e962022-08-22 14:31:04 -0700380 features bazel.StringListAttribute
Liz Kammer12615db2021-09-28 09:19:17 -0400381 protoDependency *bazel.LabelAttribute
Vinh Tran9f6796a2022-08-16 13:10:31 -0400382 aidlDependency *bazel.LabelAttribute
Yu Liuf01a0f02022-12-07 15:45:30 -0800383 Native_coverage *bool
Liz Kammere6583482021-10-19 13:56:10 -0400384}
385
Jingwen Chen107c0de2021-04-09 10:43:12 +0000386// Convenience struct to hold all attributes parsed from compiler properties.
387type compilerAttributes struct {
Chris Parsons990c4f42021-05-25 12:10:58 -0400388 // Options for all languages
389 copts bazel.StringListAttribute
390 // Assembly options and sources
391 asFlags bazel.StringListAttribute
392 asSrcs bazel.LabelListAttribute
Cole Faust7071a052022-07-29 15:58:33 -0700393 asmSrcs bazel.LabelListAttribute
Chris Parsons990c4f42021-05-25 12:10:58 -0400394 // C options and sources
395 conlyFlags bazel.StringListAttribute
396 cSrcs bazel.LabelListAttribute
397 // C++ options and sources
398 cppFlags bazel.StringListAttribute
Jingwen Chened9c17d2021-04-13 07:14:55 +0000399 srcs bazel.LabelListAttribute
Chris Parsons2c788392021-08-10 11:58:07 -0400400
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000401 // Lex sources and options
402 lSrcs bazel.LabelListAttribute
403 llSrcs bazel.LabelListAttribute
404 lexopts bazel.StringListAttribute
405
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000406 // Sysprop sources
407 syspropSrcs bazel.LabelListAttribute
408
Spandan Dasdf4c2132023-05-09 23:58:52 +0000409 // Yacc sources
410 yaccSrc *bazel.LabelAttribute
411 yaccFlags bazel.StringListAttribute
412 yaccGenLocationHeader bazel.BoolAttribute
413 yaccGenPositionHeader bazel.BoolAttribute
414
Liz Kammere6583482021-10-19 13:56:10 -0400415 hdrs bazel.LabelListAttribute
416
Chris Parsons2c788392021-08-10 11:58:07 -0400417 rtti bazel.BoolAttribute
Jingwen Chen5b11ab12021-10-11 17:44:33 +0000418
419 // Not affected by arch variants
420 stl *string
Chris Parsons79bd2b72021-11-29 17:52:41 -0500421 cStd *string
Jingwen Chen5b11ab12021-10-11 17:44:33 +0000422 cppStd *string
Liz Kammer35687bc2021-09-10 10:07:07 -0400423
424 localIncludes bazel.StringListAttribute
425 absoluteIncludes bazel.StringListAttribute
Liz Kammer12615db2021-09-28 09:19:17 -0400426
Liz Kammer1263d9b2021-12-10 14:28:20 -0500427 includes BazelIncludes
428
Liz Kammer12615db2021-09-28 09:19:17 -0400429 protoSrcs bazel.LabelListAttribute
Vinh Tran9f6796a2022-08-16 13:10:31 -0400430 aidlSrcs bazel.LabelListAttribute
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000431
432 stubsSymbolFile *string
433 stubsVersions bazel.StringListAttribute
Cole Faust5fa4e962022-08-22 14:31:04 -0700434
435 features bazel.StringListAttribute
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500436
437 suffix bazel.StringAttribute
Vinh Tran99270ea2022-11-28 11:15:23 -0500438
439 fdoProfile bazel.LabelAttribute
Jingwen Chen107c0de2021-04-09 10:43:12 +0000440}
441
Liz Kammercac7f692021-12-16 14:19:32 -0500442type filterOutFn func(string) bool
443
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000444// filterOutHiddenVisibility removes the flag specifying hidden visibility as
445// this flag is converted to a toolchain feature
446func filterOutHiddenVisibility(flag string) bool {
447 return flag == config.VisibilityHiddenFlag
448}
449
Liz Kammercac7f692021-12-16 14:19:32 -0500450func filterOutStdFlag(flag string) bool {
451 return strings.HasPrefix(flag, "-std=")
452}
453
Alix1be00d42022-05-16 22:56:04 +0000454func filterOutClangUnknownCflags(flag string) bool {
455 for _, f := range config.ClangUnknownCflags {
456 if f == flag {
457 return true
458 }
459 }
460 return false
461}
462
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000463func parseCommandLineFlags(soongFlags []string, filterOut ...filterOutFn) []string {
Liz Kammere6583482021-10-19 13:56:10 -0400464 var result []string
465 for _, flag := range soongFlags {
Alix1be00d42022-05-16 22:56:04 +0000466 skipFlag := false
467 for _, filter := range filterOut {
468 if filter != nil && filter(flag) {
469 skipFlag = true
470 }
471 }
472 if skipFlag {
Liz Kammercac7f692021-12-16 14:19:32 -0500473 continue
474 }
Liz Kammere6583482021-10-19 13:56:10 -0400475 // Soong's cflags can contain spaces, like `-include header.h`. For
476 // Bazel's copts, split them up to be compatible with the
477 // no_copts_tokenization feature.
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000478 result = append(result, strings.Split(flag, " ")...)
Liz Kammere6583482021-10-19 13:56:10 -0400479 }
480 return result
481}
Jingwen Chened9c17d2021-04-13 07:14:55 +0000482
Jingwen Chen55bc8202021-11-02 06:40:51 +0000483func (ca *compilerAttributes) bp2buildForAxisAndConfig(ctx android.BazelConversionPathContext, axis bazel.ConfigurationAxis, config string, props *BaseCompilerProperties) {
Liz Kammere6583482021-10-19 13:56:10 -0400484 // If there's arch specific srcs or exclude_srcs, generate a select entry for it.
485 // TODO(b/186153868): do this for OS specific srcs and exclude_srcs too.
486 if srcsList, ok := parseSrcs(ctx, props); ok {
487 ca.srcs.SetSelectValue(axis, config, srcsList)
Chris Parsons990c4f42021-05-25 12:10:58 -0400488 }
489
Liz Kammere6583482021-10-19 13:56:10 -0400490 localIncludeDirs := props.Local_include_dirs
491 if axis == bazel.NoConfigAxis {
Chris Parsons79bd2b72021-11-29 17:52:41 -0500492 ca.cStd, ca.cppStd = bp2buildResolveCppStdValue(props.C_std, props.Cpp_std, props.Gnu_extensions)
Liz Kammere6583482021-10-19 13:56:10 -0400493 if includeBuildDirectory(props.Include_build_directory) {
494 localIncludeDirs = append(localIncludeDirs, ".")
Liz Kammer222bdcf2021-10-11 14:15:51 -0400495 }
Jingwen Chene32e9e02021-04-23 09:17:24 +0000496 }
497
Liz Kammere6583482021-10-19 13:56:10 -0400498 ca.absoluteIncludes.SetSelectValue(axis, config, props.Include_dirs)
499 ca.localIncludes.SetSelectValue(axis, config, localIncludeDirs)
500
Cole Faust5fa4e962022-08-22 14:31:04 -0700501 instructionSet := proptools.StringDefault(props.Instruction_set, "")
502 if instructionSet == "arm" {
503 ca.features.SetSelectValue(axis, config, []string{"arm_isa_arm", "-arm_isa_thumb"})
504 } else if instructionSet != "" && instructionSet != "thumb" {
505 ctx.ModuleErrorf("Unknown value for instruction_set: %s", instructionSet)
506 }
507
Liz Kammercac7f692021-12-16 14:19:32 -0500508 // In Soong, cflags occur on the command line before -std=<val> flag, resulting in the value being
509 // overridden. In Bazel we always allow overriding, via flags; however, this can cause
510 // incompatibilities, so we remove "-std=" flags from Cflag properties while leaving it in other
511 // cases.
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000512 ca.copts.SetSelectValue(axis, config, parseCommandLineFlags(props.Cflags, filterOutStdFlag, filterOutClangUnknownCflags, filterOutHiddenVisibility))
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000513 ca.asFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Asflags, nil))
514 ca.conlyFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Conlyflags, filterOutClangUnknownCflags))
515 ca.cppFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Cppflags, filterOutClangUnknownCflags))
Liz Kammere6583482021-10-19 13:56:10 -0400516 ca.rtti.SetSelectValue(axis, config, props.Rtti)
517}
518
Jingwen Chen55bc8202021-11-02 06:40:51 +0000519func (ca *compilerAttributes) convertStlProps(ctx android.ArchVariantContext, module *Module) {
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000520 bp2BuildPropParseHelper(ctx, module, &StlProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
521 if stlProps, ok := props.(*StlProperties); ok {
522 if stlProps.Stl == nil {
523 return
524 }
525 if ca.stl == nil {
Liz Kammer7128d382022-05-12 11:42:33 -0400526 stl := deduplicateStlInput(*stlProps.Stl)
527 ca.stl = &stl
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000528 } else if ca.stl != stlProps.Stl {
529 ctx.ModuleErrorf("Unsupported conversion: module with different stl for different variants: %s and %s", *ca.stl, stlProps.Stl)
Liz Kammer9abd62d2021-05-21 08:37:59 -0400530 }
Jingwen Chenc1c26502021-04-05 10:35:13 +0000531 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000532 })
Liz Kammere6583482021-10-19 13:56:10 -0400533}
Jingwen Chenc1c26502021-04-05 10:35:13 +0000534
Jingwen Chen55bc8202021-11-02 06:40:51 +0000535func (ca *compilerAttributes) convertProductVariables(ctx android.BazelConversionPathContext, productVariableProps android.ProductConfigProperties) {
Liz Kammerba7a9c52021-05-26 08:45:30 -0400536 productVarPropNameToAttribute := map[string]*bazel.StringListAttribute{
Liz Kammere6583482021-10-19 13:56:10 -0400537 "Cflags": &ca.copts,
538 "Asflags": &ca.asFlags,
Yu Liu93893ba2023-05-01 13:49:52 -0700539 "Cppflags": &ca.cppFlags,
Liz Kammerba7a9c52021-05-26 08:45:30 -0400540 }
Liz Kammerba7a9c52021-05-26 08:45:30 -0400541 for propName, attr := range productVarPropNameToAttribute {
Jingwen Chen25825ca2021-11-15 12:28:43 +0000542 if productConfigProps, exists := productVariableProps[propName]; exists {
543 for productConfigProp, prop := range productConfigProps {
544 flags, ok := prop.([]string)
Liz Kammerba7a9c52021-05-26 08:45:30 -0400545 if !ok {
546 ctx.ModuleErrorf("Could not convert product variable %s property", proptools.PropertyNameForField(propName))
547 }
Cole Faust150f9a52023-04-26 10:52:24 -0700548 newFlags, _ := bazel.TryVariableSubstitutions(flags, productConfigProp.Name())
Jingwen Chen25825ca2021-11-15 12:28:43 +0000549 attr.SetSelectValue(productConfigProp.ConfigurationAxis(), productConfigProp.SelectKey(), newFlags)
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400550 }
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400551 }
552 }
Liz Kammere6583482021-10-19 13:56:10 -0400553}
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400554
Jingwen Chen55bc8202021-11-02 06:40:51 +0000555func (ca *compilerAttributes) finalize(ctx android.BazelConversionPathContext, implementationHdrs bazel.LabelListAttribute) {
Liz Kammere6583482021-10-19 13:56:10 -0400556 ca.srcs.ResolveExcludes()
557 partitionedSrcs := groupSrcsByExtension(ctx, ca.srcs)
558
Liz Kammer12615db2021-09-28 09:19:17 -0400559 ca.protoSrcs = partitionedSrcs[protoSrcPartition]
Vinh Tran9f6796a2022-08-16 13:10:31 -0400560 ca.aidlSrcs = partitionedSrcs[aidlSrcPartition]
Liz Kammer12615db2021-09-28 09:19:17 -0400561
Liz Kammere6583482021-10-19 13:56:10 -0400562 for p, lla := range partitionedSrcs {
563 // if there are no sources, there is no need for headers
564 if lla.IsEmpty() {
565 continue
566 }
567 lla.Append(implementationHdrs)
568 partitionedSrcs[p] = lla
569 }
570
571 ca.srcs = partitionedSrcs[cppSrcPartition]
572 ca.cSrcs = partitionedSrcs[cSrcPartition]
573 ca.asSrcs = partitionedSrcs[asSrcPartition]
Cole Faust7071a052022-07-29 15:58:33 -0700574 ca.asmSrcs = partitionedSrcs[asmSrcPartition]
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000575 ca.lSrcs = partitionedSrcs[lSrcPartition]
576 ca.llSrcs = partitionedSrcs[llSrcPartition]
Spandan Dasdf4c2132023-05-09 23:58:52 +0000577 if yacc := partitionedSrcs[yaccSrcPartition]; !yacc.IsEmpty() {
578 if len(yacc.Value.Includes) > 1 {
579 ctx.PropertyErrorf("srcs", "Found multiple yacc (.y/.yy) files in library")
580 }
581 ca.yaccSrc = bazel.MakeLabelAttribute(yacc.Value.Includes[0].Label)
582 }
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000583 ca.syspropSrcs = partitionedSrcs[syspropSrcPartition]
Liz Kammere6583482021-10-19 13:56:10 -0400584
585 ca.absoluteIncludes.DeduplicateAxesFromBase()
586 ca.localIncludes.DeduplicateAxesFromBase()
587}
588
589// Parse srcs from an arch or OS's props value.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000590func parseSrcs(ctx android.BazelConversionPathContext, props *BaseCompilerProperties) (bazel.LabelList, bool) {
Liz Kammere6583482021-10-19 13:56:10 -0400591 anySrcs := false
592 // Add srcs-like dependencies such as generated files.
593 // First create a LabelList containing these dependencies, then merge the values with srcs.
594 generatedSrcsLabelList := android.BazelLabelForModuleDepsExcludes(ctx, props.Generated_sources, props.Exclude_generated_sources)
595 if len(props.Generated_sources) > 0 || len(props.Exclude_generated_sources) > 0 {
596 anySrcs = true
597 }
598
599 allSrcsLabelList := android.BazelLabelForModuleSrcExcludes(ctx, props.Srcs, props.Exclude_srcs)
Vinh Tran9f6796a2022-08-16 13:10:31 -0400600
Liz Kammere6583482021-10-19 13:56:10 -0400601 if len(props.Srcs) > 0 || len(props.Exclude_srcs) > 0 {
602 anySrcs = true
603 }
Vinh Tran9f6796a2022-08-16 13:10:31 -0400604
Liz Kammere6583482021-10-19 13:56:10 -0400605 return bazel.AppendBazelLabelLists(allSrcsLabelList, generatedSrcsLabelList), anySrcs
606}
607
Liz Kammera5a29de2022-05-25 23:19:37 -0400608func bp2buildStdVal(std *string, prefix string, useGnu bool) *string {
609 defaultVal := prefix + "_std_default"
Chris Parsons79bd2b72021-11-29 17:52:41 -0500610 // If c{,pp}std properties are not specified, don't generate them in the BUILD file.
611 // Defaults are handled by the toolchain definition.
612 // However, if gnu_extensions is false, then the default gnu-to-c version must be specified.
Liz Kammera5a29de2022-05-25 23:19:37 -0400613 stdVal := proptools.StringDefault(std, defaultVal)
614 if stdVal == "experimental" || stdVal == defaultVal {
615 if stdVal == "experimental" {
616 stdVal = prefix + "_std_experimental"
617 }
618 if !useGnu {
619 stdVal += "_no_gnu"
620 }
621 } else if !useGnu {
622 stdVal = gnuToCReplacer.Replace(stdVal)
Chris Parsons79bd2b72021-11-29 17:52:41 -0500623 }
624
Liz Kammera5a29de2022-05-25 23:19:37 -0400625 if stdVal == defaultVal {
626 return nil
Liz Kammer46fb7ab2021-12-01 10:09:34 -0500627 }
Liz Kammera5a29de2022-05-25 23:19:37 -0400628 return &stdVal
629}
Liz Kammer46fb7ab2021-12-01 10:09:34 -0500630
Liz Kammera5a29de2022-05-25 23:19:37 -0400631func bp2buildResolveCppStdValue(c_std *string, cpp_std *string, gnu_extensions *bool) (*string, *string) {
632 useGnu := useGnuExtensions(gnu_extensions)
633
634 return bp2buildStdVal(c_std, "c", useGnu), bp2buildStdVal(cpp_std, "cpp", useGnu)
Liz Kammere6583482021-10-19 13:56:10 -0400635}
636
Liz Kammer1263d9b2021-12-10 14:28:20 -0500637// packageFromLabel extracts package from a fully-qualified or relative Label and whether the label
638// is fully-qualified.
639// e.g. fully-qualified "//a/b:foo" -> "a/b", true, relative: ":bar" -> ".", false
640func packageFromLabel(label string) (string, bool) {
641 split := strings.Split(label, ":")
642 if len(split) != 2 {
643 return "", false
644 }
645 if split[0] == "" {
646 return ".", false
647 }
648 // remove leading "//"
649 return split[0][2:], true
650}
651
652// includesFromLabelList extracts relative/absolute includes from a bazel.LabelList>
653func includesFromLabelList(labelList bazel.LabelList) (relative, absolute []string) {
654 for _, hdr := range labelList.Includes {
655 if pkg, hasPkg := packageFromLabel(hdr.Label); hasPkg {
656 absolute = append(absolute, pkg)
657 } else if pkg != "" {
658 relative = append(relative, pkg)
659 }
660 }
661 return relative, absolute
662}
663
Cole Faust7071a052022-07-29 15:58:33 -0700664type YasmAttributes struct {
665 Srcs bazel.LabelListAttribute
666 Flags bazel.StringListAttribute
667 Include_dirs bazel.StringListAttribute
668}
669
670func bp2BuildYasm(ctx android.Bp2buildMutatorContext, m *Module, ca compilerAttributes) *bazel.LabelAttribute {
671 if ca.asmSrcs.IsEmpty() {
672 return nil
673 }
674
675 // Yasm needs the include directories from both local_includes and
676 // export_include_dirs. We don't care about actually exporting them from the
677 // yasm rule though, because they will also be present on the cc_ rule that
678 // wraps this yasm rule.
679 includes := ca.localIncludes.Clone()
680 bp2BuildPropParseHelper(ctx, m, &FlagExporterProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
681 if flagExporterProperties, ok := props.(*FlagExporterProperties); ok {
682 if len(flagExporterProperties.Export_include_dirs) > 0 {
683 x := bazel.StringListAttribute{}
684 x.SetSelectValue(axis, config, flagExporterProperties.Export_include_dirs)
685 includes.Append(x)
686 }
687 }
688 })
689
690 ctx.CreateBazelTargetModule(
691 bazel.BazelTargetModuleProperties{
692 Rule_class: "yasm",
693 Bzl_load_location: "//build/bazel/rules/cc:yasm.bzl",
694 },
695 android.CommonAttributes{Name: m.Name() + "_yasm"},
696 &YasmAttributes{
697 Srcs: ca.asmSrcs,
698 Flags: ca.asFlags,
699 Include_dirs: *includes,
700 })
701
702 // We only want to add a dependency on the _yasm target if there are asm
703 // sources in the current configuration. If there are unconfigured asm
704 // sources, always add the dependency. Otherwise, add the dependency only
705 // on the configuration axes and values that had asm sources.
706 if len(ca.asmSrcs.Value.Includes) > 0 {
707 return bazel.MakeLabelAttribute(":" + m.Name() + "_yasm")
708 }
709
710 ret := &bazel.LabelAttribute{}
711 for _, axis := range ca.asmSrcs.SortedConfigurationAxes() {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800712 for cfg := range ca.asmSrcs.ConfigurableValues[axis] {
713 ret.SetSelectValue(axis, cfg, bazel.Label{Label: ":" + m.Name() + "_yasm"})
Cole Faust7071a052022-07-29 15:58:33 -0700714 }
715 }
716 return ret
717}
718
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000719// bp2BuildParseBaseProps returns all compiler, linker, library attributes of a cc module..
Liz Kammer12615db2021-09-28 09:19:17 -0400720func bp2BuildParseBaseProps(ctx android.Bp2buildMutatorContext, module *Module) baseAttributes {
Liz Kammere6583482021-10-19 13:56:10 -0400721 archVariantCompilerProps := module.GetArchVariantProperties(ctx, &BaseCompilerProperties{})
722 archVariantLinkerProps := module.GetArchVariantProperties(ctx, &BaseLinkerProperties{})
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000723 archVariantLibraryProperties := module.GetArchVariantProperties(ctx, &LibraryProperties{})
Liz Kammere6583482021-10-19 13:56:10 -0400724
725 var implementationHdrs bazel.LabelListAttribute
726
727 axisToConfigs := map[bazel.ConfigurationAxis]map[string]bool{}
728 allAxesAndConfigs := func(cp android.ConfigurationAxisToArchVariantProperties) {
729 for axis, configMap := range cp {
730 if _, ok := axisToConfigs[axis]; !ok {
731 axisToConfigs[axis] = map[string]bool{}
732 }
Sasha Smundak39a301c2022-12-29 17:11:49 -0800733 for cfg := range configMap {
734 axisToConfigs[axis][cfg] = true
Chris Parsonsa967f252021-09-23 16:34:35 -0400735 }
736 }
737 }
Liz Kammere6583482021-10-19 13:56:10 -0400738 allAxesAndConfigs(archVariantCompilerProps)
739 allAxesAndConfigs(archVariantLinkerProps)
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000740 allAxesAndConfigs(archVariantLibraryProperties)
Chris Parsonsa967f252021-09-23 16:34:35 -0400741
Liz Kammere6583482021-10-19 13:56:10 -0400742 compilerAttrs := compilerAttributes{}
743 linkerAttrs := linkerAttributes{}
744
Vinh Tran367d89d2023-04-28 11:21:25 -0400745 var aidlLibs bazel.LabelList
746
Chris Parsons7b3289b2023-01-26 17:30:44 -0500747 // Iterate through these axes in a deterministic order. This is required
748 // because processing certain dependencies may result in concatenating
749 // elements along other axes. (For example, processing NoConfig may result
750 // in elements being added to InApex). This is thus the only way to ensure
751 // that the order of entries in each list is in a predictable order.
752 for _, axis := range bazel.SortedConfigurationAxes(axisToConfigs) {
753 configs := axisToConfigs[axis]
Sasha Smundak39a301c2022-12-29 17:11:49 -0800754 for cfg := range configs {
Liz Kammere6583482021-10-19 13:56:10 -0400755 var allHdrs []string
Sasha Smundak39a301c2022-12-29 17:11:49 -0800756 if baseCompilerProps, ok := archVariantCompilerProps[axis][cfg].(*BaseCompilerProperties); ok {
Liz Kammere6583482021-10-19 13:56:10 -0400757 allHdrs = baseCompilerProps.Generated_headers
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000758 if baseCompilerProps.Lex != nil {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800759 compilerAttrs.lexopts.SetSelectValue(axis, cfg, baseCompilerProps.Lex.Flags)
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000760 }
Spandan Dasdf4c2132023-05-09 23:58:52 +0000761 if baseCompilerProps.Yacc != nil {
762 compilerAttrs.yaccFlags.SetSelectValue(axis, cfg, baseCompilerProps.Yacc.Flags)
763 compilerAttrs.yaccGenLocationHeader.SetSelectValue(axis, cfg, baseCompilerProps.Yacc.Gen_location_hh)
764 compilerAttrs.yaccGenPositionHeader.SetSelectValue(axis, cfg, baseCompilerProps.Yacc.Gen_position_hh)
765 }
Sasha Smundak39a301c2022-12-29 17:11:49 -0800766 (&compilerAttrs).bp2buildForAxisAndConfig(ctx, axis, cfg, baseCompilerProps)
Vinh Tran367d89d2023-04-28 11:21:25 -0400767 aidlLibs.Append(android.BazelLabelForModuleDeps(ctx, baseCompilerProps.Aidl.Libs))
Liz Kammere6583482021-10-19 13:56:10 -0400768 }
769
770 var exportHdrs []string
771
Sasha Smundak39a301c2022-12-29 17:11:49 -0800772 if baseLinkerProps, ok := archVariantLinkerProps[axis][cfg].(*BaseLinkerProperties); ok {
Liz Kammere6583482021-10-19 13:56:10 -0400773 exportHdrs = baseLinkerProps.Export_generated_headers
774
Liz Kammer48cdbeb2023-03-17 10:17:50 -0400775 (&linkerAttrs).bp2buildForAxisAndConfig(ctx, module, axis, cfg, baseLinkerProps)
Liz Kammere6583482021-10-19 13:56:10 -0400776 }
777 headers := maybePartitionExportedAndImplementationsDeps(ctx, !module.Binary(), allHdrs, exportHdrs, android.BazelLabelForModuleDeps)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800778 implementationHdrs.SetSelectValue(axis, cfg, headers.implementation)
779 compilerAttrs.hdrs.SetSelectValue(axis, cfg, headers.export)
Liz Kammer1263d9b2021-12-10 14:28:20 -0500780
781 exportIncludes, exportAbsoluteIncludes := includesFromLabelList(headers.export)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800782 compilerAttrs.includes.Includes.SetSelectValue(axis, cfg, exportIncludes)
783 compilerAttrs.includes.AbsoluteIncludes.SetSelectValue(axis, cfg, exportAbsoluteIncludes)
Liz Kammer1263d9b2021-12-10 14:28:20 -0500784
785 includes, absoluteIncludes := includesFromLabelList(headers.implementation)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800786 currAbsoluteIncludes := compilerAttrs.absoluteIncludes.SelectValue(axis, cfg)
Liz Kammer1263d9b2021-12-10 14:28:20 -0500787 currAbsoluteIncludes = android.FirstUniqueStrings(append(currAbsoluteIncludes, absoluteIncludes...))
Vinh Tran9f6796a2022-08-16 13:10:31 -0400788
Sasha Smundak39a301c2022-12-29 17:11:49 -0800789 compilerAttrs.absoluteIncludes.SetSelectValue(axis, cfg, currAbsoluteIncludes)
Vinh Tran9f6796a2022-08-16 13:10:31 -0400790
Sasha Smundak39a301c2022-12-29 17:11:49 -0800791 currIncludes := compilerAttrs.localIncludes.SelectValue(axis, cfg)
Liz Kammer1263d9b2021-12-10 14:28:20 -0500792 currIncludes = android.FirstUniqueStrings(append(currIncludes, includes...))
Vinh Tran9f6796a2022-08-16 13:10:31 -0400793
Sasha Smundak39a301c2022-12-29 17:11:49 -0800794 compilerAttrs.localIncludes.SetSelectValue(axis, cfg, currIncludes)
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000795
Sasha Smundak39a301c2022-12-29 17:11:49 -0800796 if libraryProps, ok := archVariantLibraryProperties[axis][cfg].(*LibraryProperties); ok {
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000797 if axis == bazel.NoConfigAxis {
Sam Delmerico75dbca22023-04-20 13:13:25 +0000798 if libraryProps.Stubs.Symbol_file != nil {
799 compilerAttrs.stubsSymbolFile = libraryProps.Stubs.Symbol_file
800 versions := android.CopyOf(libraryProps.Stubs.Versions)
801 normalizeVersions(ctx, versions)
802 versions = addCurrentVersionIfNotPresent(versions)
803 compilerAttrs.stubsVersions.SetSelectValue(axis, cfg, versions)
804 }
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000805 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500806 if suffix := libraryProps.Suffix; suffix != nil {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800807 compilerAttrs.suffix.SetSelectValue(axis, cfg, suffix)
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500808 }
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000809 }
Liz Kammere6583482021-10-19 13:56:10 -0400810 }
811 }
Vinh Tran9f6796a2022-08-16 13:10:31 -0400812
Liz Kammere6583482021-10-19 13:56:10 -0400813 compilerAttrs.convertStlProps(ctx, module)
814 (&linkerAttrs).convertStripProps(ctx, module)
815
Yu Liuf01a0f02022-12-07 15:45:30 -0800816 var nativeCoverage *bool
Yu Liu8d82ac52022-05-17 15:13:28 -0700817 if module.coverage != nil && module.coverage.Properties.Native_coverage != nil &&
818 !Bool(module.coverage.Properties.Native_coverage) {
Yu Liuf01a0f02022-12-07 15:45:30 -0800819 nativeCoverage = BoolPtr(false)
Yu Liu8d82ac52022-05-17 15:13:28 -0700820 }
821
Cole Faust912bc882023-03-08 12:29:50 -0800822 productVariableProps := android.ProductVariableProperties(ctx, ctx.Module())
Liz Kammere6583482021-10-19 13:56:10 -0400823
824 (&compilerAttrs).convertProductVariables(ctx, productVariableProps)
825 (&linkerAttrs).convertProductVariables(ctx, productVariableProps)
826
827 (&compilerAttrs).finalize(ctx, implementationHdrs)
Liz Kammer54309532021-12-14 12:21:22 -0500828 (&linkerAttrs).finalize(ctx)
Liz Kammere6583482021-10-19 13:56:10 -0400829
Cole Faust7071a052022-07-29 15:58:33 -0700830 (&compilerAttrs.srcs).Add(bp2BuildYasm(ctx, module, compilerAttrs))
831
Liz Kammer12615db2021-09-28 09:19:17 -0400832 protoDep := bp2buildProto(ctx, module, compilerAttrs.protoSrcs)
833
834 // bp2buildProto will only set wholeStaticLib or implementationWholeStaticLib, but we don't know
835 // which. This will add the newly generated proto library to the appropriate attribute and nothing
836 // to the other
837 (&linkerAttrs).wholeArchiveDeps.Add(protoDep.wholeStaticLib)
838 (&linkerAttrs).implementationWholeArchiveDeps.Add(protoDep.implementationWholeStaticLib)
Vinh Tranfde57eb2022-08-29 17:46:58 -0400839
Vinh Tran367d89d2023-04-28 11:21:25 -0400840 aidlDep := bp2buildCcAidlLibrary(
841 ctx, module,
842 compilerAttrs.aidlSrcs,
843 bazel.LabelListAttribute{
844 Value: aidlLibs,
845 },
846 linkerAttrs,
847 )
Vinh Tranfde57eb2022-08-29 17:46:58 -0400848 if aidlDep != nil {
849 if lib, ok := module.linker.(*libraryDecorator); ok {
850 if proptools.Bool(lib.Properties.Aidl.Export_aidl_headers) {
851 (&linkerAttrs).wholeArchiveDeps.Add(aidlDep)
852 } else {
853 (&linkerAttrs).implementationWholeArchiveDeps.Add(aidlDep)
854 }
855 }
856 }
Liz Kammer12615db2021-09-28 09:19:17 -0400857
Spandan Dasdf4c2132023-05-09 23:58:52 +0000858 // Create a cc_yacc_static_library if srcs contains .y/.yy files
859 // This internal target will produce an .a file that will be statically linked to the parent library
860 if yaccDep := bp2buildCcYaccLibrary(ctx, compilerAttrs, linkerAttrs); yaccDep != nil {
861 (&linkerAttrs).implementationWholeArchiveDeps.Add(yaccDep)
862 }
863
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000864 convertedLSrcs := bp2BuildLex(ctx, module.Name(), compilerAttrs)
865 (&compilerAttrs).srcs.Add(&convertedLSrcs.srcName)
866 (&compilerAttrs).cSrcs.Add(&convertedLSrcs.cSrcName)
867
Vinh Tran99270ea2022-11-28 11:15:23 -0500868 if module.afdo != nil && module.afdo.Properties.Afdo {
869 fdoProfileDep := bp2buildFdoProfile(ctx, module)
870 if fdoProfileDep != nil {
871 (&compilerAttrs).fdoProfile.SetValue(*fdoProfileDep)
872 }
873 }
874
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000875 if !compilerAttrs.syspropSrcs.IsEmpty() {
876 (&linkerAttrs).wholeArchiveDeps.Add(bp2buildCcSysprop(ctx, module.Name(), module.Properties.Min_sdk_version, compilerAttrs.syspropSrcs))
877 }
878
Zi Wang9f609db2023-01-04 11:06:54 -0800879 linkerAttrs.wholeArchiveDeps.Prepend = true
880 linkerAttrs.deps.Prepend = true
881 compilerAttrs.localIncludes.Prepend = true
882 compilerAttrs.absoluteIncludes.Prepend = true
883 compilerAttrs.hdrs.Prepend = true
884
Trevor Radcliffedb7e0262022-10-28 16:48:18 +0000885 features := compilerAttrs.features.Clone().Append(linkerAttrs.features).Append(bp2buildSanitizerFeatures(ctx, module))
Trevor Radcliffe56b1a2b2023-02-06 21:58:30 +0000886 features = features.Append(bp2buildLtoFeatures(ctx, module))
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000887 features = features.Append(convertHiddenVisibilityToFeatureBase(ctx, module))
Cole Faust5fa4e962022-08-22 14:31:04 -0700888 features.DeduplicateAxesFromBase()
889
Trevor Radcliffe0d1b4022022-12-12 22:26:34 +0000890 addMuslSystemDynamicDeps(ctx, linkerAttrs)
891
Liz Kammere6583482021-10-19 13:56:10 -0400892 return baseAttributes{
893 compilerAttrs,
894 linkerAttrs,
Cole Faust5fa4e962022-08-22 14:31:04 -0700895 *features,
Liz Kammer12615db2021-09-28 09:19:17 -0400896 protoDep.protoDep,
Vinh Tran9f6796a2022-08-16 13:10:31 -0400897 aidlDep,
Yu Liuf01a0f02022-12-07 15:45:30 -0800898 nativeCoverage,
Jingwen Chen107c0de2021-04-09 10:43:12 +0000899 }
900}
901
Spandan Dasdf4c2132023-05-09 23:58:52 +0000902type ccYaccLibraryAttributes struct {
903 Src bazel.LabelAttribute
904 Flags bazel.StringListAttribute
905 Gen_location_hh bazel.BoolAttribute
906 Gen_position_hh bazel.BoolAttribute
907 Local_includes bazel.StringListAttribute
908 Implementation_deps bazel.LabelListAttribute
909 Implementation_dynamic_deps bazel.LabelListAttribute
910}
911
912func bp2buildCcYaccLibrary(ctx android.Bp2buildMutatorContext, ca compilerAttributes, la linkerAttributes) *bazel.LabelAttribute {
913 if ca.yaccSrc == nil {
914 return nil
915 }
916 yaccLibraryLabel := ctx.Module().Name() + "_yacc"
917 ctx.CreateBazelTargetModule(
918 bazel.BazelTargetModuleProperties{
919 Rule_class: "cc_yacc_static_library",
920 Bzl_load_location: "//build/bazel/rules/cc:cc_yacc_library.bzl",
921 },
922 android.CommonAttributes{
923 Name: yaccLibraryLabel,
924 },
925 &ccYaccLibraryAttributes{
926 Src: *ca.yaccSrc,
927 Flags: ca.yaccFlags,
928 Gen_location_hh: ca.yaccGenLocationHeader,
929 Gen_position_hh: ca.yaccGenPositionHeader,
930 Local_includes: ca.localIncludes,
931 Implementation_deps: la.implementationDeps,
932 Implementation_dynamic_deps: la.implementationDynamicDeps,
933 },
934 )
935
936 yaccLibrary := &bazel.LabelAttribute{
937 Value: &bazel.Label{
938 Label: ":" + yaccLibraryLabel,
939 },
940 }
941 return yaccLibrary
942}
943
Trevor Radcliffe0d1b4022022-12-12 22:26:34 +0000944// As a workaround for b/261657184, we are manually adding the default value
945// of system_dynamic_deps for the linux_musl os.
946// TODO: Solve this properly
947func addMuslSystemDynamicDeps(ctx android.Bp2buildMutatorContext, attrs linkerAttributes) {
948 systemDynamicDeps := attrs.systemDynamicDeps.SelectValue(bazel.OsConfigurationAxis, "linux_musl")
949 if attrs.systemDynamicDeps.HasAxisSpecificValues(bazel.OsConfigurationAxis) && systemDynamicDeps.IsNil() {
950 attrs.systemDynamicDeps.SetSelectValue(bazel.OsConfigurationAxis, "linux_musl", android.BazelLabelForModuleDeps(ctx, config.MuslDefaultSharedLibraries))
951 }
952}
953
Vinh Tran99270ea2022-11-28 11:15:23 -0500954type fdoProfileAttributes struct {
955 Absolute_path_profile string
956}
957
958func bp2buildFdoProfile(
959 ctx android.Bp2buildMutatorContext,
960 m *Module,
961) *bazel.Label {
962 for _, project := range globalAfdoProfileProjects {
Vinh Tranbc9c8b42022-12-09 12:03:52 -0500963 // Ensure handcrafted BUILD file exists in the project
964 BUILDPath := android.ExistentPathForSource(ctx, project, "BUILD")
965 if BUILDPath.Valid() {
966 // We handcraft a BUILD file with fdo_profile targets that use the existing profiles in the project
967 // This implementation is assuming that every afdo profile in globalAfdoProfileProjects already has
968 // an associated fdo_profile target declared in the same package.
969 // TODO(b/260714900): Handle arch-specific afdo profiles (e.g. `<module-name>-arm<64>.afdo`)
970 path := android.ExistentPathForSource(ctx, project, m.Name()+".afdo")
971 if path.Valid() {
972 // FIXME: Some profiles only exist internally and are not released to AOSP.
973 // When generated BUILD files are checked in, we'll run into merge conflict.
974 // The cc_library_shared target in AOSP won't have reference to an fdo_profile target because
975 // the profile doesn't exist. Internally, the same cc_library_shared target will
976 // have reference to the fdo_profile.
977 // For more context, see b/258682955#comment2
978 fdoProfileLabel := "//" + strings.TrimSuffix(project, "/") + ":" + m.Name()
979 return &bazel.Label{
980 Label: fdoProfileLabel,
981 }
Vinh Tran99270ea2022-11-28 11:15:23 -0500982 }
983 }
984 }
985
986 return nil
987}
988
Vinh Tran9f6796a2022-08-16 13:10:31 -0400989func bp2buildCcAidlLibrary(
990 ctx android.Bp2buildMutatorContext,
991 m *Module,
Vinh Tran367d89d2023-04-28 11:21:25 -0400992 aidlSrcs bazel.LabelListAttribute,
993 aidlLibs bazel.LabelListAttribute,
Vinh Tran395a1e92022-09-16 18:27:29 -0400994 linkerAttrs linkerAttributes,
Vinh Tran9f6796a2022-08-16 13:10:31 -0400995) *bazel.LabelAttribute {
Vinh Tran367d89d2023-04-28 11:21:25 -0400996 var aidlLibsFromSrcs, aidlFiles bazel.LabelListAttribute
997 apexAvailableTags := android.ApexAvailableTagsWithoutTestApexes(ctx.(android.TopDownMutatorContext), ctx.Module())
998
999 if !aidlSrcs.IsEmpty() {
1000 aidlLibsFromSrcs, aidlFiles = aidlSrcs.Partition(func(src bazel.Label) bool {
Vinh Trana3b8b782022-09-14 11:40:24 -04001001 if fg, ok := android.ToFileGroupAsLibrary(ctx, src.OriginalModuleName); ok &&
1002 fg.ShouldConvertToAidlLibrary(ctx) {
1003 return true
1004 }
1005 return false
1006 })
Vinh Tran9f6796a2022-08-16 13:10:31 -04001007
Vinh Tran367d89d2023-04-28 11:21:25 -04001008 if !aidlFiles.IsEmpty() {
Vinh Trana3b8b782022-09-14 11:40:24 -04001009 aidlLibName := m.Name() + "_aidl_library"
1010 ctx.CreateBazelTargetModule(
1011 bazel.BazelTargetModuleProperties{
1012 Rule_class: "aidl_library",
Sam Delmericoe55bf082023-03-31 09:47:28 -04001013 Bzl_load_location: "//build/bazel/rules/aidl:aidl_library.bzl",
Vinh Trana3b8b782022-09-14 11:40:24 -04001014 },
Vinh Tran367d89d2023-04-28 11:21:25 -04001015 android.CommonAttributes{
1016 Name: aidlLibName,
Liz Kammer2b3f56e2023-03-23 11:51:49 -04001017 Tags: apexAvailableTags,
Vinh Trana3b8b782022-09-14 11:40:24 -04001018 },
Vinh Tran367d89d2023-04-28 11:21:25 -04001019 &aidlLibraryAttributes{
1020 Srcs: aidlFiles,
Vinh Trana3b8b782022-09-14 11:40:24 -04001021 },
1022 )
Vinh Tran367d89d2023-04-28 11:21:25 -04001023 aidlLibsFromSrcs.Add(&bazel.LabelAttribute{Value: &bazel.Label{Label: ":" + aidlLibName}})
Vinh Trana3b8b782022-09-14 11:40:24 -04001024 }
Vinh Tran9f6796a2022-08-16 13:10:31 -04001025 }
1026
Vinh Tran367d89d2023-04-28 11:21:25 -04001027 allAidlLibs := aidlLibs.Clone()
1028 allAidlLibs.Append(aidlLibsFromSrcs)
1029
1030 if !allAidlLibs.IsEmpty() {
1031 ccAidlLibrarylabel := m.Name() + "_cc_aidl_library"
1032 // Since parent cc_library already has these dependencies, we can add them as implementation
1033 // deps so that they don't re-export
1034 implementationDeps := linkerAttrs.deps.Clone()
1035 implementationDeps.Append(linkerAttrs.implementationDeps)
1036 implementationDynamicDeps := linkerAttrs.dynamicDeps.Clone()
1037 implementationDynamicDeps.Append(linkerAttrs.implementationDynamicDeps)
1038
1039 sdkAttrs := bp2BuildParseSdkAttributes(m)
1040
1041 ctx.CreateBazelTargetModule(
1042 bazel.BazelTargetModuleProperties{
1043 Rule_class: "cc_aidl_library",
1044 Bzl_load_location: "//build/bazel/rules/cc:cc_aidl_library.bzl",
1045 },
1046 android.CommonAttributes{Name: ccAidlLibrarylabel},
1047 &ccAidlLibraryAttributes{
1048 Deps: *allAidlLibs,
1049 Implementation_deps: *implementationDeps,
1050 Implementation_dynamic_deps: *implementationDynamicDeps,
1051 Tags: apexAvailableTags,
1052 sdkAttributes: sdkAttrs,
1053 },
1054 )
1055 label := &bazel.LabelAttribute{
1056 Value: &bazel.Label{
1057 Label: ":" + ccAidlLibrarylabel,
1058 },
1059 }
1060 return label
1061 }
1062
Vinh Trana3b8b782022-09-14 11:40:24 -04001063 return nil
Vinh Tran9f6796a2022-08-16 13:10:31 -04001064}
1065
Yu Liufc603162022-03-01 15:44:08 -08001066func bp2BuildParseSdkAttributes(module *Module) sdkAttributes {
Trevor Radcliffe58ea4512022-04-07 20:36:39 +00001067 return sdkAttributes{
1068 Sdk_version: module.Properties.Sdk_version,
Yu Liufc603162022-03-01 15:44:08 -08001069 Min_sdk_version: module.Properties.Min_sdk_version,
1070 }
1071}
1072
1073type sdkAttributes struct {
1074 Sdk_version *string
1075 Min_sdk_version *string
1076}
1077
Jingwen Chen107c0de2021-04-09 10:43:12 +00001078// Convenience struct to hold all attributes parsed from linker properties.
1079type linkerAttributes struct {
Liz Kammer54309532021-12-14 12:21:22 -05001080 deps bazel.LabelListAttribute
1081 implementationDeps bazel.LabelListAttribute
1082 dynamicDeps bazel.LabelListAttribute
1083 implementationDynamicDeps bazel.LabelListAttribute
Cole Faust6b29f592022-08-09 09:50:56 -07001084 runtimeDeps bazel.LabelListAttribute
Liz Kammer54309532021-12-14 12:21:22 -05001085 wholeArchiveDeps bazel.LabelListAttribute
1086 implementationWholeArchiveDeps bazel.LabelListAttribute
1087 systemDynamicDeps bazel.LabelListAttribute
1088 usedSystemDynamicDepAsDynamicDep map[string]bool
Liz Kammer7a210ac2021-09-22 15:52:58 -04001089
Rupert Shuttleworth484aa252021-12-10 07:22:53 -05001090 useVersionLib bazel.BoolAttribute
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001091 linkopts bazel.StringListAttribute
Liz Kammerd2871182021-10-04 13:54:37 -04001092 additionalLinkerInputs bazel.LabelListAttribute
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001093 stripKeepSymbols bazel.BoolAttribute
1094 stripKeepSymbolsAndDebugFrame bazel.BoolAttribute
1095 stripKeepSymbolsList bazel.StringListAttribute
1096 stripAll bazel.BoolAttribute
1097 stripNone bazel.BoolAttribute
Liz Kammer0eae52e2021-10-06 10:32:26 -04001098 features bazel.StringListAttribute
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001099}
1100
Liz Kammer54309532021-12-14 12:21:22 -05001101var (
1102 soongSystemSharedLibs = []string{"libc", "libm", "libdl"}
Liz Kammerbaced712022-09-16 09:01:29 -04001103 versionLib = "libbuildversion"
Liz Kammer54309532021-12-14 12:21:22 -05001104)
1105
Vinh Tran85fb07c2022-09-16 16:17:48 -04001106// resolveTargetApex re-adds the shared and static libs in target.apex.exclude_shared|static_libs props to non-apex variant
1107// since all libs are already excluded by default
Liz Kammer748d7072023-01-25 12:07:43 -05001108func (la *linkerAttributes) resolveTargetApexProp(ctx android.BazelConversionPathContext, props *BaseLinkerProperties) {
1109 excludeSharedLibs := bazelLabelForSharedDeps(ctx, props.Target.Apex.Exclude_shared_libs)
1110 sharedExcludes := bazel.LabelList{Excludes: excludeSharedLibs.Includes}
1111 sharedExcludesLabelList := bazel.LabelListAttribute{}
1112 sharedExcludesLabelList.SetSelectValue(bazel.InApexAxis, bazel.InApex, sharedExcludes)
Vinh Tran85fb07c2022-09-16 16:17:48 -04001113
Liz Kammer748d7072023-01-25 12:07:43 -05001114 la.dynamicDeps.Append(sharedExcludesLabelList)
1115 la.implementationDynamicDeps.Append(sharedExcludesLabelList)
1116
1117 excludeStaticLibs := bazelLabelForStaticDeps(ctx, props.Target.Apex.Exclude_static_libs)
1118 staticExcludes := bazel.LabelList{Excludes: excludeStaticLibs.Includes}
1119 staticExcludesLabelList := bazel.LabelListAttribute{}
1120 staticExcludesLabelList.SetSelectValue(bazel.InApexAxis, bazel.InApex, staticExcludes)
1121
1122 la.deps.Append(staticExcludesLabelList)
1123 la.implementationDeps.Append(staticExcludesLabelList)
Vinh Tran85fb07c2022-09-16 16:17:48 -04001124}
1125
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001126func (la *linkerAttributes) bp2buildForAxisAndConfig(ctx android.BazelConversionPathContext, module *Module, axis bazel.ConfigurationAxis, config string, props *BaseLinkerProperties) {
1127 isBinary := module.Binary()
Liz Kammere6583482021-10-19 13:56:10 -04001128 // Use a single variable to capture usage of nocrt in arch variants, so there's only 1 error message for this module
1129 var axisFeatures []string
Liz Kammer7a210ac2021-09-22 15:52:58 -04001130
Liz Kammercc2c1ef2022-03-21 09:03:29 -04001131 wholeStaticLibs := android.FirstUniqueStrings(props.Whole_static_libs)
Liz Kammerbaced712022-09-16 09:01:29 -04001132 staticLibs := android.FirstUniqueStrings(android.RemoveListFromList(props.Static_libs, wholeStaticLibs))
1133 if axis == bazel.NoConfigAxis {
1134 la.useVersionLib.SetSelectValue(axis, config, props.Use_version_lib)
1135 if proptools.Bool(props.Use_version_lib) {
1136 versionLibAlreadyInDeps := android.InList(versionLib, wholeStaticLibs)
1137 // remove from static libs so there is no duplicate dependency
1138 _, staticLibs = android.RemoveFromList(versionLib, staticLibs)
1139 // only add the dep if it is not in progress
1140 if !versionLibAlreadyInDeps {
Yu Liufe978fd2023-04-24 16:37:18 -07001141 wholeStaticLibs = append(wholeStaticLibs, versionLib)
Liz Kammerbaced712022-09-16 09:01:29 -04001142 }
1143 }
1144 }
1145
Liz Kammere6583482021-10-19 13:56:10 -04001146 // Excludes to parallel Soong:
1147 // https://cs.android.com/android/platform/superproject/+/master:build/soong/cc/linker.go;l=247-249;drc=088b53577dde6e40085ffd737a1ae96ad82fc4b0
Liz Kammerbaced712022-09-16 09:01:29 -04001148 la.wholeArchiveDeps.SetSelectValue(axis, config, bazelLabelForWholeDepsExcludes(ctx, wholeStaticLibs, props.Exclude_static_libs))
Liz Kammercc2c1ef2022-03-21 09:03:29 -04001149
Vinh Tran85fb07c2022-09-16 16:17:48 -04001150 staticDeps := maybePartitionExportedAndImplementationsDepsExcludes(
1151 ctx,
1152 !isBinary,
1153 staticLibs,
Liz Kammer748d7072023-01-25 12:07:43 -05001154 props.Exclude_static_libs,
Vinh Tran85fb07c2022-09-16 16:17:48 -04001155 props.Export_static_lib_headers,
1156 bazelLabelForStaticDepsExcludes,
1157 )
Liz Kammer7a210ac2021-09-22 15:52:58 -04001158
Liz Kammere6583482021-10-19 13:56:10 -04001159 headerLibs := android.FirstUniqueStrings(props.Header_libs)
1160 hDeps := maybePartitionExportedAndImplementationsDeps(ctx, !isBinary, headerLibs, props.Export_header_lib_headers, bazelLabelForHeaderDeps)
Jingwen Chen63930982021-03-24 10:04:33 -04001161
Liz Kammere6583482021-10-19 13:56:10 -04001162 (&hDeps.export).Append(staticDeps.export)
1163 la.deps.SetSelectValue(axis, config, hDeps.export)
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001164
Liz Kammere6583482021-10-19 13:56:10 -04001165 (&hDeps.implementation).Append(staticDeps.implementation)
1166 la.implementationDeps.SetSelectValue(axis, config, hDeps.implementation)
Liz Kammer0eae52e2021-10-06 10:32:26 -04001167
Liz Kammere6583482021-10-19 13:56:10 -04001168 systemSharedLibs := props.System_shared_libs
1169 // systemSharedLibs distinguishes between nil/empty list behavior:
1170 // nil -> use default values
1171 // empty list -> no values specified
1172 if len(systemSharedLibs) > 0 {
1173 systemSharedLibs = android.FirstUniqueStrings(systemSharedLibs)
1174 }
1175 la.systemDynamicDeps.SetSelectValue(axis, config, bazelLabelForSharedDeps(ctx, systemSharedLibs))
1176
1177 sharedLibs := android.FirstUniqueStrings(props.Shared_libs)
Liz Kammer54309532021-12-14 12:21:22 -05001178 excludeSharedLibs := props.Exclude_shared_libs
1179 usedSystem := android.FilterListPred(sharedLibs, func(s string) bool {
1180 return android.InList(s, soongSystemSharedLibs) && !android.InList(s, excludeSharedLibs)
1181 })
1182 for _, el := range usedSystem {
1183 if la.usedSystemDynamicDepAsDynamicDep == nil {
1184 la.usedSystemDynamicDepAsDynamicDep = map[string]bool{}
1185 }
1186 la.usedSystemDynamicDepAsDynamicDep[el] = true
1187 }
1188
Vinh Tran85fb07c2022-09-16 16:17:48 -04001189 sharedDeps := maybePartitionExportedAndImplementationsDepsExcludes(
1190 ctx,
1191 !isBinary,
1192 sharedLibs,
Liz Kammer748d7072023-01-25 12:07:43 -05001193 props.Exclude_shared_libs,
Vinh Tran85fb07c2022-09-16 16:17:48 -04001194 props.Export_shared_lib_headers,
1195 bazelLabelForSharedDepsExcludes,
1196 )
Liz Kammere6583482021-10-19 13:56:10 -04001197 la.dynamicDeps.SetSelectValue(axis, config, sharedDeps.export)
1198 la.implementationDynamicDeps.SetSelectValue(axis, config, sharedDeps.implementation)
Liz Kammer748d7072023-01-25 12:07:43 -05001199 la.resolveTargetApexProp(ctx, props)
Vinh Tran85fb07c2022-09-16 16:17:48 -04001200
Wei Li81852ca2022-07-27 00:22:06 -07001201 if axis == bazel.NoConfigAxis || (axis == bazel.OsConfigurationAxis && config == bazel.OsAndroid) {
Yu Liu10174ff2023-02-21 12:05:26 -08001202 // If a dependency in la.implementationDynamicDeps or la.dynamicDeps has stubs, its
1203 // stub variant should be used when the dependency is linked in a APEX. The
1204 // dependencies in NoConfigAxis and OsConfigurationAxis/OsAndroid are grouped by
1205 // having stubs or not, so Bazel select() statement can be used to choose
1206 // source/stub variants of them.
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001207 apexAvailable := module.ApexAvailable()
Spandan Dasac693b22023-04-24 00:07:38 +00001208 setStubsForDynamicDeps(ctx, axis, config, apexAvailable, sharedDeps.export, &la.dynamicDeps, 0, false)
1209 setStubsForDynamicDeps(ctx, axis, config, apexAvailable, sharedDeps.implementation, &la.implementationDynamicDeps, 1, false)
1210 if len(systemSharedLibs) > 0 {
1211 setStubsForDynamicDeps(ctx, axis, config, apexAvailable, bazelLabelForSharedDeps(ctx, systemSharedLibs), &la.systemDynamicDeps, 2, true)
1212 }
Wei Li81852ca2022-07-27 00:22:06 -07001213 }
Liz Kammere6583482021-10-19 13:56:10 -04001214
1215 if !BoolDefault(props.Pack_relocations, packRelocationsDefault) {
1216 axisFeatures = append(axisFeatures, "disable_pack_relocations")
1217 }
1218
1219 if Bool(props.Allow_undefined_symbols) {
1220 axisFeatures = append(axisFeatures, "-no_undefined_symbols")
1221 }
1222
1223 var linkerFlags []string
1224 if len(props.Ldflags) > 0 {
Liz Kammerf38a8372022-02-04 15:39:00 -05001225 linkerFlags = append(linkerFlags, proptools.NinjaEscapeList(props.Ldflags)...)
Liz Kammere6583482021-10-19 13:56:10 -04001226 // binaries remove static flag if -shared is in the linker flags
1227 if isBinary && android.InList("-shared", linkerFlags) {
1228 axisFeatures = append(axisFeatures, "-static_flag")
1229 }
1230 }
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +00001231
Alex Márquez Pérez Muñíz Díaz Puras Thaureaux01ec55e2023-01-30 22:53:04 +00001232 if !props.libCrt() {
1233 axisFeatures = append(axisFeatures, "-use_libcrt")
1234 }
1235 if !props.crt() {
1236 axisFeatures = append(axisFeatures, "-link_crt")
1237 }
1238
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +00001239 // This must happen before the addition of flags for Version Script and
1240 // Dynamic List, as these flags must be split on spaces and those must not
1241 linkerFlags = parseCommandLineFlags(linkerFlags, filterOutClangUnknownCflags)
1242
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001243 additionalLinkerInputs := bazel.LabelList{}
Liz Kammere6583482021-10-19 13:56:10 -04001244 if props.Version_script != nil {
1245 label := android.BazelLabelForModuleSrcSingle(ctx, *props.Version_script)
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001246 additionalLinkerInputs.Add(&label)
Liz Kammere6583482021-10-19 13:56:10 -04001247 linkerFlags = append(linkerFlags, fmt.Sprintf("-Wl,--version-script,$(location %s)", label.Label))
1248 }
Alix773adaa2022-04-27 17:49:34 +00001249
1250 if props.Dynamic_list != nil {
1251 label := android.BazelLabelForModuleSrcSingle(ctx, *props.Dynamic_list)
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001252 additionalLinkerInputs.Add(&label)
Alix773adaa2022-04-27 17:49:34 +00001253 linkerFlags = append(linkerFlags, fmt.Sprintf("-Wl,--dynamic-list,$(location %s)", label.Label))
1254 }
1255
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001256 la.additionalLinkerInputs.SetSelectValue(axis, config, additionalLinkerInputs)
Spandan Dasfb04c412023-05-15 18:35:36 +00001257 if axis == bazel.OsConfigurationAxis && (config == bazel.OsDarwin || config == bazel.OsLinux || config == bazel.OsWindows) {
1258 linkerFlags = append(linkerFlags, props.Host_ldlibs...)
1259 }
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +00001260 la.linkopts.SetSelectValue(axis, config, linkerFlags)
Liz Kammere6583482021-10-19 13:56:10 -04001261
1262 if axisFeatures != nil {
1263 la.features.SetSelectValue(axis, config, axisFeatures)
1264 }
Cole Faust6b29f592022-08-09 09:50:56 -07001265
1266 runtimeDeps := android.BazelLabelForModuleDepsExcludes(ctx, props.Runtime_libs, props.Exclude_runtime_libs)
1267 if !runtimeDeps.IsEmpty() {
1268 la.runtimeDeps.SetSelectValue(axis, config, runtimeDeps)
1269 }
Liz Kammere6583482021-10-19 13:56:10 -04001270}
1271
Spandan Das2518c022023-03-17 03:02:32 +00001272var (
1273 apiSurfaceModuleLibCurrentPackage = "@api_surfaces//" + android.ModuleLibApi.String() + "/current:"
1274)
1275
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001276func availableToSameApexes(a, b []string) bool {
1277 if len(a) == 0 && len(b) == 0 {
1278 return true
1279 }
1280 differ, _, _ := android.ListSetDifference(a, b)
1281 return !differ
1282}
1283
Spandan Das4242f102023-04-19 22:31:54 +00001284var (
Spandan Das9cad90f2023-05-04 17:15:44 +00001285 apiDomainConfigSettingKey = android.NewOnceKey("apiDomainConfigSettingKey")
1286 apiDomainConfigSettingLock sync.Mutex
Spandan Das4242f102023-04-19 22:31:54 +00001287)
1288
Spandan Das9cad90f2023-05-04 17:15:44 +00001289func getApiDomainConfigSettingMap(config android.Config) *map[string]bool {
1290 return config.Once(apiDomainConfigSettingKey, func() interface{} {
Spandan Das4242f102023-04-19 22:31:54 +00001291 return &map[string]bool{}
1292 }).(*map[string]bool)
1293}
1294
Spandan Das9cad90f2023-05-04 17:15:44 +00001295var (
1296 testApexNameToApiDomain = map[string]string{
1297 "test_broken_com.android.art": "com.android.art",
1298 }
1299)
1300
Spandan Dasa43ae132023-05-08 18:33:16 +00001301// GetApiDomain returns the canonical name of the apex. This is synonymous to the apex_name definition.
1302// https://cs.android.com/android/_/android/platform/build/soong/+/e3f0281b8897da1fe23b2f4f3a05f1dc87bcc902:apex/prebuilt.go;l=81-83;drc=2dc7244af985a6ad701b22f1271e606cabba527f;bpv=1;bpt=0
1303// For test apexes, it uses a naming convention heuristic to determine the api domain.
1304// TODO (b/281548611): Move this build/soong/android
1305func GetApiDomain(apexName string) string {
Spandan Das9cad90f2023-05-04 17:15:44 +00001306 if apiDomain, exists := testApexNameToApiDomain[apexName]; exists {
1307 return apiDomain
1308 }
1309 // Remove `test_` prefix
1310 return strings.TrimPrefix(apexName, "test_")
1311}
1312
Spandan Das4242f102023-04-19 22:31:54 +00001313// Create a config setting for this apex in build/bazel/rules/apex
1314// The use case for this is stub/impl selection in cc libraries
1315// Long term, these config_setting(s) should be colocated with the respective apex definitions.
1316// Note that this is an anti-pattern: The config_setting should be created from the apex definition
1317// and not from a cc_library.
1318// This anti-pattern is needed today since not all apexes have been allowlisted.
1319func createInApexConfigSetting(ctx android.TopDownMutatorContext, apexName string) {
1320 if apexName == android.AvailableToPlatform || apexName == android.AvailableToAnyApex {
1321 // These correspond to android-non_apex and android-in_apex
1322 return
1323 }
Spandan Das9cad90f2023-05-04 17:15:44 +00001324 apiDomainConfigSettingLock.Lock()
1325 defer apiDomainConfigSettingLock.Unlock()
Spandan Das4242f102023-04-19 22:31:54 +00001326
1327 // Return if a config_setting has already been created
Spandan Dasa43ae132023-05-08 18:33:16 +00001328 apiDomain := GetApiDomain(apexName)
Spandan Das9cad90f2023-05-04 17:15:44 +00001329 acsm := getApiDomainConfigSettingMap(ctx.Config())
1330 if _, exists := (*acsm)[apiDomain]; exists {
Spandan Das4242f102023-04-19 22:31:54 +00001331 return
1332 }
Spandan Das9cad90f2023-05-04 17:15:44 +00001333 (*acsm)[apiDomain] = true
Spandan Das4242f102023-04-19 22:31:54 +00001334
1335 csa := bazel.ConfigSettingAttributes{
1336 Flag_values: bazel.StringMapAttribute{
Spandan Das9cad90f2023-05-04 17:15:44 +00001337 "//build/bazel/rules/apex:api_domain": apiDomain,
Spandan Das4242f102023-04-19 22:31:54 +00001338 },
Spandan Das9cad90f2023-05-04 17:15:44 +00001339 // Constraint this to android
1340 Constraint_values: bazel.MakeLabelListAttribute(
1341 bazel.MakeLabelList(
1342 []bazel.Label{
1343 bazel.Label{Label: "//build/bazel/platforms/os:android"},
1344 },
1345 ),
1346 ),
Spandan Das4242f102023-04-19 22:31:54 +00001347 }
1348 ca := android.CommonAttributes{
Spandan Das9cad90f2023-05-04 17:15:44 +00001349 Name: apiDomain,
Spandan Das4242f102023-04-19 22:31:54 +00001350 }
1351 ctx.CreateBazelConfigSetting(
1352 csa,
1353 ca,
1354 "build/bazel/rules/apex",
1355 )
1356}
1357
1358func inApexConfigSetting(apexAvailable string) string {
1359 if apexAvailable == android.AvailableToPlatform {
Spandan Das6d4d9da2023-04-18 06:20:40 +00001360 return bazel.AndroidPlatform
Spandan Das4242f102023-04-19 22:31:54 +00001361 }
1362 if apexAvailable == android.AvailableToAnyApex {
1363 return bazel.AndroidAndInApex
1364 }
Spandan Dasa43ae132023-05-08 18:33:16 +00001365 apiDomain := GetApiDomain(apexAvailable)
Spandan Das9cad90f2023-05-04 17:15:44 +00001366 return "//build/bazel/rules/apex:" + apiDomain
Spandan Das4242f102023-04-19 22:31:54 +00001367}
1368
Spandan Das6d4d9da2023-04-18 06:20:40 +00001369// Inputs to stub vs impl selection.
1370type stubSelectionInfo struct {
1371 // Label of the implementation library (e.g. //bionic/libc:libc)
1372 impl bazel.Label
1373 // Axis containing the implementation library
1374 axis bazel.ConfigurationAxis
1375 // Axis key containing the implementation library
1376 config string
1377 // API domain of the apex
1378 // For test apexes (test_com.android.foo), this will be the source apex (com.android.foo)
1379 apiDomain string
1380 // List of dep labels
1381 dynamicDeps *bazel.LabelListAttribute
1382 // Boolean value for determining if the dep is in the same api domain
1383 // If false, the label will be rewritten to to the stub label
1384 sameApiDomain bool
1385}
1386
1387func useStubOrImplInApexWithName(ssi stubSelectionInfo) {
1388 lib := ssi.impl
1389 if !ssi.sameApiDomain {
1390 lib = bazel.Label{
1391 Label: apiSurfaceModuleLibCurrentPackage + strings.TrimPrefix(lib.OriginalModuleName, ":"),
1392 }
1393 }
1394 // Create a select statement specific to this apex
1395 inApexSelectValue := ssi.dynamicDeps.SelectValue(bazel.OsAndInApexAxis, inApexConfigSetting(ssi.apiDomain))
1396 (&inApexSelectValue).Append(bazel.MakeLabelList([]bazel.Label{lib}))
1397 ssi.dynamicDeps.SetSelectValue(bazel.OsAndInApexAxis, inApexConfigSetting(ssi.apiDomain), bazel.FirstUniqueBazelLabelList(inApexSelectValue))
1398 // Delete the library from the common config for this apex
1399 implDynamicDeps := ssi.dynamicDeps.SelectValue(ssi.axis, ssi.config)
1400 implDynamicDeps = bazel.SubtractBazelLabelList(implDynamicDeps, bazel.MakeLabelList([]bazel.Label{ssi.impl}))
1401 ssi.dynamicDeps.SetSelectValue(ssi.axis, ssi.config, implDynamicDeps)
1402 if ssi.axis == bazel.NoConfigAxis {
1403 // Set defaults. Defaults (i.e. host) should use impl and not stubs.
1404 defaultSelectValue := ssi.dynamicDeps.SelectValue(bazel.OsAndInApexAxis, bazel.ConditionsDefaultConfigKey)
1405 (&defaultSelectValue).Append(bazel.MakeLabelList([]bazel.Label{ssi.impl}))
1406 ssi.dynamicDeps.SetSelectValue(bazel.OsAndInApexAxis, bazel.ConditionsDefaultConfigKey, bazel.FirstUniqueBazelLabelList(defaultSelectValue))
1407 }
Liz Kammere6583482021-10-19 13:56:10 -04001408}
1409
Yu Liu10174ff2023-02-21 12:05:26 -08001410func setStubsForDynamicDeps(ctx android.BazelConversionPathContext, axis bazel.ConfigurationAxis,
Spandan Dasac693b22023-04-24 00:07:38 +00001411 config string, apexAvailable []string, dynamicLibs bazel.LabelList, dynamicDeps *bazel.LabelListAttribute, ind int, buildNonApexWithStubs bool) {
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001412
Spandan Das4242f102023-04-19 22:31:54 +00001413 // Create a config_setting for each apex_available.
1414 // This will be used to select impl of a dep if dep is available to the same apex.
1415 for _, aa := range apexAvailable {
1416 createInApexConfigSetting(ctx.(android.TopDownMutatorContext), aa)
1417 }
1418
Spandan Das6d4d9da2023-04-18 06:20:40 +00001419 apiDomainForSelects := []string{}
1420 for _, apex := range apexAvailable {
1421 apiDomainForSelects = append(apiDomainForSelects, GetApiDomain(apex))
1422 }
1423 // Always emit a select statement for the platform variant.
1424 // This ensures that b build //foo --config=android works
1425 // Soong always creates a platform variant even when the library might not be available to platform.
1426 if !android.InList(android.AvailableToPlatform, apiDomainForSelects) {
1427 apiDomainForSelects = append(apiDomainForSelects, android.AvailableToPlatform)
1428 }
1429 apiDomainForSelects = android.SortedUniqueStrings(apiDomainForSelects)
1430
1431 // Create a select for each apex this library could be included in.
1432 for _, l := range dynamicLibs.Includes {
1433 dep, _ := ctx.ModuleFromName(l.OriginalModuleName)
1434 if c, ok := dep.(*Module); !ok || !c.HasStubsVariants() {
1435 continue
1436 }
1437 // TODO (b/280339069): Decrease the verbosity of the generated BUILD files
1438 for _, apiDomain := range apiDomainForSelects {
1439 var sameApiDomain bool
1440 if apiDomain == android.AvailableToPlatform {
1441 // Platform variants in Soong use equality of apex_available for stub/impl selection.
1442 // https://cs.android.com/android/_/android/platform/build/soong/+/316b0158fe57ee7764235923e7c6f3d530da39c6:cc/cc.go;l=3393-3404;drc=176271a426496fa2688efe2b40d5c74340c63375;bpv=1;bpt=0
1443 // One of the factors behind this design choice is cc_test
1444 // Tests only have a platform variant, and using equality of apex_available ensures
1445 // that tests of an apex library gets its implementation and not stubs.
1446 // TODO (b/280343104): Discuss if we can drop this special handling for platform variants.
1447 sameApiDomain = availableToSameApexes(apexAvailable, dep.(*Module).ApexAvailable())
Spandan Das6aaab9d2023-05-04 17:27:30 +00001448 if linkable, ok := ctx.Module().(LinkableInterface); ok && linkable.Bootstrap() {
1449 sameApiDomain = true
1450 }
Spandan Das6d4d9da2023-04-18 06:20:40 +00001451 } else {
1452 sameApiDomain = android.InList(apiDomain, dep.(*Module).ApexAvailable())
1453 }
1454 ssi := stubSelectionInfo{
1455 impl: l,
1456 axis: axis,
1457 config: config,
1458 apiDomain: apiDomain,
1459 dynamicDeps: dynamicDeps,
1460 sameApiDomain: sameApiDomain,
1461 }
1462 useStubOrImplInApexWithName(ssi)
1463 }
1464 }
Yu Liu10174ff2023-02-21 12:05:26 -08001465}
1466
Jingwen Chen55bc8202021-11-02 06:40:51 +00001467func (la *linkerAttributes) convertStripProps(ctx android.BazelConversionPathContext, module *Module) {
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001468 bp2BuildPropParseHelper(ctx, module, &StripProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1469 if stripProperties, ok := props.(*StripProperties); ok {
1470 la.stripKeepSymbols.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols)
1471 la.stripKeepSymbolsList.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols_list)
1472 la.stripKeepSymbolsAndDebugFrame.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols_and_debug_frame)
1473 la.stripAll.SetSelectValue(axis, config, stripProperties.Strip.All)
1474 la.stripNone.SetSelectValue(axis, config, stripProperties.Strip.None)
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001475 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001476 })
Liz Kammere6583482021-10-19 13:56:10 -04001477}
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001478
Jingwen Chen55bc8202021-11-02 06:40:51 +00001479func (la *linkerAttributes) convertProductVariables(ctx android.BazelConversionPathContext, productVariableProps android.ProductConfigProperties) {
Jingwen Chen6ada5892021-09-17 11:38:09 +00001480
Liz Kammer47535c52021-06-02 16:02:22 -04001481 type productVarDep struct {
1482 // the name of the corresponding excludes field, if one exists
1483 excludesField string
1484 // reference to the bazel attribute that should be set for the given product variable config
1485 attribute *bazel.LabelListAttribute
Liz Kammer2d7bbe32021-06-10 18:20:06 -04001486
Jingwen Chen55bc8202021-11-02 06:40:51 +00001487 depResolutionFunc func(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList
Liz Kammer47535c52021-06-02 16:02:22 -04001488 }
1489
Zi Wang0a8a1292022-08-30 06:27:01 +00001490 // an intermediate attribute that holds Header_libs info, and will be appended to
1491 // implementationDeps at the end, to solve the confliction that both header_libs
1492 // and static_libs use implementationDeps.
1493 var headerDeps bazel.LabelListAttribute
1494
Liz Kammer47535c52021-06-02 16:02:22 -04001495 productVarToDepFields := map[string]productVarDep{
1496 // product variables do not support exclude_shared_libs
Jingwen Chen55bc8202021-11-02 06:40:51 +00001497 "Shared_libs": {attribute: &la.implementationDynamicDeps, depResolutionFunc: bazelLabelForSharedDepsExcludes},
1498 "Static_libs": {"Exclude_static_libs", &la.implementationDeps, bazelLabelForStaticDepsExcludes},
1499 "Whole_static_libs": {"Exclude_static_libs", &la.wholeArchiveDeps, bazelLabelForWholeDepsExcludes},
Zi Wang0a8a1292022-08-30 06:27:01 +00001500 "Header_libs": {attribute: &headerDeps, depResolutionFunc: bazelLabelForHeaderDepsExcludes},
Liz Kammer47535c52021-06-02 16:02:22 -04001501 }
1502
Liz Kammer47535c52021-06-02 16:02:22 -04001503 for name, dep := range productVarToDepFields {
1504 props, exists := productVariableProps[name]
1505 excludeProps, excludesExists := productVariableProps[dep.excludesField]
Sasha Smundak39a301c2022-12-29 17:11:49 -08001506 // if neither an include nor excludes property exists, then skip it
Liz Kammer47535c52021-06-02 16:02:22 -04001507 if !exists && !excludesExists {
1508 continue
1509 }
Jingwen Chen25825ca2021-11-15 12:28:43 +00001510 // Collect all the configurations that an include or exclude property exists for.
1511 // We want to iterate all configurations rather than either the include or exclude because, for a
1512 // particular configuration, we may have either only an include or an exclude to handle.
Cole Faust150f9a52023-04-26 10:52:24 -07001513 productConfigProps := make(map[android.ProductConfigOrSoongConfigProperty]bool, len(props)+len(excludeProps))
Jingwen Chen25825ca2021-11-15 12:28:43 +00001514 for p := range props {
1515 productConfigProps[p] = true
Liz Kammer47535c52021-06-02 16:02:22 -04001516 }
Jingwen Chen25825ca2021-11-15 12:28:43 +00001517 for p := range excludeProps {
1518 productConfigProps[p] = true
Liz Kammer47535c52021-06-02 16:02:22 -04001519 }
1520
Jingwen Chen25825ca2021-11-15 12:28:43 +00001521 for productConfigProp := range productConfigProps {
1522 prop, includesExists := props[productConfigProp]
1523 excludesProp, excludesExists := excludeProps[productConfigProp]
Liz Kammer47535c52021-06-02 16:02:22 -04001524 var includes, excludes []string
1525 var ok bool
1526 // if there was no includes/excludes property, casting fails and that's expected
Jingwen Chen25825ca2021-11-15 12:28:43 +00001527 if includes, ok = prop.([]string); includesExists && !ok {
Liz Kammer47535c52021-06-02 16:02:22 -04001528 ctx.ModuleErrorf("Could not convert product variable %s property", name)
1529 }
Jingwen Chen25825ca2021-11-15 12:28:43 +00001530 if excludes, ok = excludesProp.([]string); excludesExists && !ok {
Liz Kammer47535c52021-06-02 16:02:22 -04001531 ctx.ModuleErrorf("Could not convert product variable %s property", dep.excludesField)
1532 }
Liz Kammer2d7bbe32021-06-10 18:20:06 -04001533
Jingwen Chen58ff6802021-11-17 12:14:41 +00001534 dep.attribute.EmitEmptyList = productConfigProp.AlwaysEmit()
Jingwen Chen25825ca2021-11-15 12:28:43 +00001535 dep.attribute.SetSelectValue(
1536 productConfigProp.ConfigurationAxis(),
1537 productConfigProp.SelectKey(),
1538 dep.depResolutionFunc(ctx, android.FirstUniqueStrings(includes), excludes),
1539 )
Liz Kammer47535c52021-06-02 16:02:22 -04001540 }
1541 }
Zi Wang0a8a1292022-08-30 06:27:01 +00001542 la.implementationDeps.Append(headerDeps)
Liz Kammere6583482021-10-19 13:56:10 -04001543}
Liz Kammer47535c52021-06-02 16:02:22 -04001544
Liz Kammer54309532021-12-14 12:21:22 -05001545func (la *linkerAttributes) finalize(ctx android.BazelConversionPathContext) {
1546 // if system dynamic deps have the default value, any use of a system dynamic library used will
1547 // result in duplicate library errors for bionic OSes. Here, we explicitly exclude those libraries
Liz Kammer43345e22022-08-04 13:57:35 -04001548 // from bionic OSes and the no config case as these libraries only build for bionic OSes.
Liz Kammer54309532021-12-14 12:21:22 -05001549 if la.systemDynamicDeps.IsNil() && len(la.usedSystemDynamicDepAsDynamicDep) > 0 {
Cole Faust18994c72023-02-28 16:02:16 -08001550 toRemove := bazelLabelForSharedDeps(ctx, android.SortedKeys(la.usedSystemDynamicDepAsDynamicDep))
Liz Kammer43345e22022-08-04 13:57:35 -04001551 la.dynamicDeps.Exclude(bazel.NoConfigAxis, "", toRemove)
Liz Kammer54309532021-12-14 12:21:22 -05001552 la.dynamicDeps.Exclude(bazel.OsConfigurationAxis, "android", toRemove)
1553 la.dynamicDeps.Exclude(bazel.OsConfigurationAxis, "linux_bionic", toRemove)
Liz Kammer91487d42022-09-13 11:27:11 -04001554 la.implementationDynamicDeps.Exclude(bazel.NoConfigAxis, "", toRemove)
Liz Kammer54309532021-12-14 12:21:22 -05001555 la.implementationDynamicDeps.Exclude(bazel.OsConfigurationAxis, "android", toRemove)
1556 la.implementationDynamicDeps.Exclude(bazel.OsConfigurationAxis, "linux_bionic", toRemove)
Liz Kammer91487d42022-09-13 11:27:11 -04001557
1558 la.implementationDynamicDeps.Exclude(bazel.OsAndInApexAxis, bazel.ConditionsDefaultConfigKey, toRemove)
Liz Kammer91487d42022-09-13 11:27:11 -04001559 stubsToRemove := make([]bazel.Label, 0, len(la.usedSystemDynamicDepAsDynamicDep))
1560 for _, lib := range toRemove.Includes {
Spandan Das2518c022023-03-17 03:02:32 +00001561 stubLabelInApiSurfaces := bazel.Label{
1562 Label: apiSurfaceModuleLibCurrentPackage + lib.OriginalModuleName,
1563 }
1564 stubsToRemove = append(stubsToRemove, stubLabelInApiSurfaces)
Liz Kammer91487d42022-09-13 11:27:11 -04001565 }
Spandan Das6d4d9da2023-04-18 06:20:40 +00001566 // system libraries (e.g. libc, libm, libdl) belong the com.android.runtime api domain
1567 // dedupe the stubs of these libraries from the other api domains (platform, other_apexes...)
1568 for _, aa := range ctx.Module().(*Module).ApexAvailable() {
1569 la.implementationDynamicDeps.Exclude(bazel.OsAndInApexAxis, inApexConfigSetting(aa), bazel.MakeLabelList(stubsToRemove))
1570 }
1571 la.implementationDynamicDeps.Exclude(bazel.OsAndInApexAxis, bazel.AndroidPlatform, bazel.MakeLabelList(stubsToRemove))
Liz Kammer54309532021-12-14 12:21:22 -05001572 }
1573
Liz Kammere6583482021-10-19 13:56:10 -04001574 la.deps.ResolveExcludes()
1575 la.implementationDeps.ResolveExcludes()
1576 la.dynamicDeps.ResolveExcludes()
1577 la.implementationDynamicDeps.ResolveExcludes()
1578 la.wholeArchiveDeps.ResolveExcludes()
1579 la.systemDynamicDeps.ForceSpecifyEmptyList = true
Liz Kammer54309532021-12-14 12:21:22 -05001580
Jingwen Chen91220d72021-03-24 02:18:33 -04001581}
1582
Jingwen Chened9c17d2021-04-13 07:14:55 +00001583// Relativize a list of root-relative paths with respect to the module's
1584// directory.
1585//
1586// include_dirs Soong prop are root-relative (b/183742505), but
1587// local_include_dirs, export_include_dirs and export_system_include_dirs are
1588// module dir relative. This function makes a list of paths entirely module dir
1589// relative.
1590//
1591// For the `include` attribute, Bazel wants the paths to be relative to the
1592// module.
1593func bp2BuildMakePathsRelativeToModule(ctx android.BazelConversionPathContext, paths []string) []string {
Rupert Shuttleworthb8151682021-04-06 20:06:21 +00001594 var relativePaths []string
1595 for _, path := range paths {
Jingwen Chened9c17d2021-04-13 07:14:55 +00001596 // Semantics of filepath.Rel: join(ModuleDir, rel(ModuleDir, path)) == path
1597 relativePath, err := filepath.Rel(ctx.ModuleDir(), path)
1598 if err != nil {
1599 panic(err)
1600 }
Rupert Shuttleworthb8151682021-04-06 20:06:21 +00001601 relativePaths = append(relativePaths, relativePath)
1602 }
1603 return relativePaths
1604}
1605
Liz Kammer5fad5012021-09-09 14:08:21 -04001606// BazelIncludes contains information about -I and -isystem paths from a module converted to Bazel
1607// attributes.
1608type BazelIncludes struct {
Liz Kammer1263d9b2021-12-10 14:28:20 -05001609 AbsoluteIncludes bazel.StringListAttribute
1610 Includes bazel.StringListAttribute
1611 SystemIncludes bazel.StringListAttribute
Liz Kammer5fad5012021-09-09 14:08:21 -04001612}
1613
Liz Kammer54549442022-05-11 13:55:06 -04001614func bp2BuildParseExportedIncludes(ctx android.BazelConversionPathContext, module *Module, includes *BazelIncludes) BazelIncludes {
Liz Kammer1263d9b2021-12-10 14:28:20 -05001615 var exported BazelIncludes
1616 if includes != nil {
1617 exported = *includes
1618 } else {
1619 exported = BazelIncludes{}
1620 }
Zi Wang1cb11802022-12-09 16:08:54 -08001621
1622 // cc library Export_include_dirs and Export_system_include_dirs are marked
1623 // "variant_prepend" in struct tag, set their prepend property to true to make
1624 // sure bp2build generates correct result.
1625 exported.Includes.Prepend = true
1626 exported.SystemIncludes.Prepend = true
1627
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001628 bp2BuildPropParseHelper(ctx, module, &FlagExporterProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1629 if flagExporterProperties, ok := props.(*FlagExporterProperties); ok {
1630 if len(flagExporterProperties.Export_include_dirs) > 0 {
1631 exported.Includes.SetSelectValue(axis, config, android.FirstUniqueStrings(append(exported.Includes.SelectValue(axis, config), flagExporterProperties.Export_include_dirs...)))
1632 }
1633 if len(flagExporterProperties.Export_system_include_dirs) > 0 {
1634 exported.SystemIncludes.SetSelectValue(axis, config, android.FirstUniqueStrings(append(exported.SystemIncludes.SelectValue(axis, config), flagExporterProperties.Export_system_include_dirs...)))
Rupert Shuttleworth375451e2021-04-26 07:49:08 -04001635 }
Rupert Shuttleworth375451e2021-04-26 07:49:08 -04001636 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001637 })
Liz Kammer1263d9b2021-12-10 14:28:20 -05001638 exported.AbsoluteIncludes.DeduplicateAxesFromBase()
Liz Kammer5fad5012021-09-09 14:08:21 -04001639 exported.Includes.DeduplicateAxesFromBase()
1640 exported.SystemIncludes.DeduplicateAxesFromBase()
Rupert Shuttleworth375451e2021-04-26 07:49:08 -04001641
Liz Kammer5fad5012021-09-09 14:08:21 -04001642 return exported
Jingwen Chen91220d72021-03-24 02:18:33 -04001643}
Chris Parsons953b3562021-09-20 15:14:39 -04001644
Trevor Radcliffecee4e052022-09-06 19:31:25 +00001645func BazelLabelNameForStaticModule(baseLabel string) string {
1646 return baseLabel + "_bp2build_cc_library_static"
1647}
1648
Jingwen Chen55bc8202021-11-02 06:40:51 +00001649func bazelLabelForStaticModule(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -04001650 label := android.BazelModuleLabel(ctx, m)
Sasha Smundak39a301c2022-12-29 17:11:49 -08001651 if ccModule, ok := m.(*Module); ok && ccModule.typ() == fullLibrary {
Trevor Radcliffecee4e052022-09-06 19:31:25 +00001652 return BazelLabelNameForStaticModule(label)
Chris Parsons953b3562021-09-20 15:14:39 -04001653 }
1654 return label
1655}
1656
Jingwen Chen55bc8202021-11-02 06:40:51 +00001657func bazelLabelForSharedModule(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -04001658 // cc_library, at it's root name, propagates the shared library, which depends on the static
1659 // library.
1660 return android.BazelModuleLabel(ctx, m)
1661}
1662
Jingwen Chen55bc8202021-11-02 06:40:51 +00001663func bazelLabelForStaticWholeModuleDeps(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -04001664 label := bazelLabelForStaticModule(ctx, m)
1665 if aModule, ok := m.(android.Module); ok {
1666 if android.IsModulePrebuilt(aModule) {
1667 label += "_alwayslink"
1668 }
1669 }
1670 return label
1671}
1672
Jingwen Chen55bc8202021-11-02 06:40:51 +00001673func bazelLabelForWholeDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001674 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForStaticWholeModuleDeps)
1675}
1676
Jingwen Chen55bc8202021-11-02 06:40:51 +00001677func bazelLabelForWholeDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001678 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForStaticWholeModuleDeps)
1679}
1680
Jingwen Chen55bc8202021-11-02 06:40:51 +00001681func bazelLabelForStaticDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001682 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForStaticModule)
1683}
1684
Jingwen Chen55bc8202021-11-02 06:40:51 +00001685func bazelLabelForStaticDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001686 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForStaticModule)
1687}
1688
Jingwen Chen55bc8202021-11-02 06:40:51 +00001689func bazelLabelForSharedDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001690 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForSharedModule)
1691}
1692
Jingwen Chen55bc8202021-11-02 06:40:51 +00001693func bazelLabelForHeaderDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001694 // This is not elegant, but bp2build's shared library targets only propagate
1695 // their header information as part of the normal C++ provider.
1696 return bazelLabelForSharedDeps(ctx, modules)
1697}
1698
Zi Wang0a8a1292022-08-30 06:27:01 +00001699func bazelLabelForHeaderDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
1700 // This is only used when product_variable header_libs is processed, to follow
1701 // the pattern of depResolutionFunc
1702 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForSharedModule)
1703}
1704
Jingwen Chen55bc8202021-11-02 06:40:51 +00001705func bazelLabelForSharedDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001706 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForSharedModule)
1707}
Liz Kammer2b8004b2021-10-04 13:55:44 -04001708
1709type binaryLinkerAttrs struct {
1710 Linkshared *bool
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05001711 Suffix bazel.StringAttribute
Liz Kammer2b8004b2021-10-04 13:55:44 -04001712}
1713
Jingwen Chen55bc8202021-11-02 06:40:51 +00001714func bp2buildBinaryLinkerProps(ctx android.BazelConversionPathContext, m *Module) binaryLinkerAttrs {
Liz Kammer2b8004b2021-10-04 13:55:44 -04001715 attrs := binaryLinkerAttrs{}
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001716 bp2BuildPropParseHelper(ctx, m, &BinaryLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1717 linkerProps := props.(*BinaryLinkerProperties)
1718 staticExecutable := linkerProps.Static_executable
1719 if axis == bazel.NoConfigAxis {
1720 if linkBinaryShared := !proptools.Bool(staticExecutable); !linkBinaryShared {
1721 attrs.Linkshared = &linkBinaryShared
Liz Kammer2b8004b2021-10-04 13:55:44 -04001722 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001723 } else if staticExecutable != nil {
1724 // TODO(b/202876379): Static_executable is arch-variant; however, linkshared is a
1725 // nonconfigurable attribute. Only 4 AOSP modules use this feature, defer handling
1726 ctx.ModuleErrorf("bp2build cannot migrate a module with arch/target-specific static_executable values")
Liz Kammer2b8004b2021-10-04 13:55:44 -04001727 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05001728 if suffix := linkerProps.Suffix; suffix != nil {
1729 attrs.Suffix.SetSelectValue(axis, config, suffix)
1730 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001731 })
Liz Kammer2b8004b2021-10-04 13:55:44 -04001732
1733 return attrs
1734}
Trevor Radcliffedb7e0262022-10-28 16:48:18 +00001735
1736func bp2buildSanitizerFeatures(ctx android.BazelConversionPathContext, m *Module) bazel.StringListAttribute {
1737 sanitizerFeatures := bazel.StringListAttribute{}
1738 bp2BuildPropParseHelper(ctx, m, &SanitizeProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1739 var features []string
1740 if sanitizerProps, ok := props.(*SanitizeProperties); ok {
1741 if sanitizerProps.Sanitize.Integer_overflow != nil && *sanitizerProps.Sanitize.Integer_overflow {
1742 features = append(features, "ubsan_integer_overflow")
1743 }
1744 for _, sanitizer := range sanitizerProps.Sanitize.Misc_undefined {
1745 features = append(features, "ubsan_"+sanitizer)
1746 }
1747 sanitizerFeatures.SetSelectValue(axis, config, features)
1748 }
1749 })
1750 return sanitizerFeatures
1751}
Trevor Radcliffe56b1a2b2023-02-06 21:58:30 +00001752
1753func bp2buildLtoFeatures(ctx android.BazelConversionPathContext, m *Module) bazel.StringListAttribute {
1754 lto_feature_name := "android_thin_lto"
1755 ltoBoolFeatures := bazel.BoolAttribute{}
1756 bp2BuildPropParseHelper(ctx, m, &LTOProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1757 if ltoProps, ok := props.(*LTOProperties); ok {
1758 thinProp := ltoProps.Lto.Thin != nil && *ltoProps.Lto.Thin
1759 thinPropSetToFalse := ltoProps.Lto.Thin != nil && !*ltoProps.Lto.Thin
1760 neverProp := ltoProps.Lto.Never != nil && *ltoProps.Lto.Never
1761 if thinProp {
1762 ltoBoolFeatures.SetSelectValue(axis, config, BoolPtr(true))
1763 return
1764 }
1765 if neverProp || thinPropSetToFalse {
1766 if thinProp {
1767 ctx.ModuleErrorf("lto.thin and lto.never are mutually exclusive but were specified together")
1768 } else {
1769 ltoBoolFeatures.SetSelectValue(axis, config, BoolPtr(false))
1770 }
1771 return
1772 }
1773 }
1774 ltoBoolFeatures.SetSelectValue(axis, config, nil)
1775 })
1776
1777 props := m.GetArchVariantProperties(ctx, &LTOProperties{})
1778 ltoStringFeatures, err := ltoBoolFeatures.ToStringListAttribute(func(boolPtr *bool, axis bazel.ConfigurationAxis, config string) []string {
1779 if boolPtr == nil {
1780 return []string{}
1781 }
1782 if !*boolPtr {
1783 return []string{"-" + lto_feature_name}
1784 }
1785 features := []string{lto_feature_name}
1786 if ltoProps, ok := props[axis][config].(*LTOProperties); ok {
1787 if ltoProps.Whole_program_vtables != nil && *ltoProps.Whole_program_vtables {
1788 features = append(features, "android_thin_lto_whole_program_vtables")
1789 }
1790 }
1791 return features
1792 })
1793 if err != nil {
1794 ctx.ModuleErrorf("Error processing LTO attributes: %s", err)
1795 }
1796 return ltoStringFeatures
1797}
Trevor Radcliffea8b44162023-04-14 18:25:24 +00001798
1799func convertHiddenVisibilityToFeatureBase(ctx android.BazelConversionPathContext, m *Module) bazel.StringListAttribute {
1800 visibilityHiddenFeature := bazel.StringListAttribute{}
1801 bp2BuildPropParseHelper(ctx, m, &BaseCompilerProperties{}, func(axis bazel.ConfigurationAxis, configString string, props interface{}) {
1802 if baseCompilerProps, ok := props.(*BaseCompilerProperties); ok {
1803 convertHiddenVisibilityToFeatureHelper(&visibilityHiddenFeature, axis, configString, baseCompilerProps.Cflags)
1804 }
1805 })
1806 return visibilityHiddenFeature
1807}
1808
1809func convertHiddenVisibilityToFeatureStaticOrShared(ctx android.BazelConversionPathContext, m *Module, isStatic bool) bazel.StringListAttribute {
1810 visibilityHiddenFeature := bazel.StringListAttribute{}
1811 if isStatic {
1812 bp2BuildPropParseHelper(ctx, m, &StaticProperties{}, func(axis bazel.ConfigurationAxis, configString string, props interface{}) {
1813 if staticProps, ok := props.(*StaticProperties); ok {
1814 convertHiddenVisibilityToFeatureHelper(&visibilityHiddenFeature, axis, configString, staticProps.Static.Cflags)
1815 }
1816 })
1817 } else {
1818 bp2BuildPropParseHelper(ctx, m, &SharedProperties{}, func(axis bazel.ConfigurationAxis, configString string, props interface{}) {
1819 if sharedProps, ok := props.(*SharedProperties); ok {
1820 convertHiddenVisibilityToFeatureHelper(&visibilityHiddenFeature, axis, configString, sharedProps.Shared.Cflags)
1821 }
1822 })
1823 }
1824
1825 return visibilityHiddenFeature
1826}
1827
1828func convertHiddenVisibilityToFeatureHelper(feature *bazel.StringListAttribute, axis bazel.ConfigurationAxis, configString string, cflags []string) {
1829 if inList(config.VisibilityHiddenFlag, cflags) {
1830 feature.SetSelectValue(axis, configString, []string{"visibility_hidden"})
1831 }
1832}