blob: 4e39532532be32ee9f6d12fd3cc582bc629b1505 [file] [log] [blame]
Jingwen Chen91220d72021-03-24 02:18:33 -04001// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
Cole Faust7071a052022-07-29 15:58:33 -07007// http://www.apache.org/licenses/LICENSE-2.0
Jingwen Chen91220d72021-03-24 02:18:33 -04008//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14package cc
15
16import (
Liz Kammerd2871182021-10-04 13:54:37 -040017 "fmt"
Jingwen Chened9c17d2021-04-13 07:14:55 +000018 "path/filepath"
Jingwen Chen3950cd62021-05-12 04:33:00 +000019 "strings"
Chris Parsons484e50a2021-05-13 15:13:04 -040020
21 "android/soong/android"
22 "android/soong/bazel"
Alix1be00d42022-05-16 22:56:04 +000023 "android/soong/cc/config"
Liz Kammer7a210ac2021-09-22 15:52:58 -040024
Chris Parsons953b3562021-09-20 15:14:39 -040025 "github.com/google/blueprint"
Liz Kammerba7a9c52021-05-26 08:45:30 -040026
27 "github.com/google/blueprint/proptools"
Jingwen Chen91220d72021-03-24 02:18:33 -040028)
29
Liz Kammerae3994e2021-10-19 09:45:48 -040030const (
Trevor Radcliffecee4e052022-09-06 19:31:25 +000031 cSrcPartition = "c"
32 asSrcPartition = "as"
33 asmSrcPartition = "asm"
34 lSrcPartition = "l"
35 llSrcPartition = "ll"
36 cppSrcPartition = "cpp"
37 protoSrcPartition = "proto"
38 aidlSrcPartition = "aidl"
39 syspropSrcPartition = "sysprop"
Liz Kammer91487d42022-09-13 11:27:11 -040040
41 stubsSuffix = "_stub_libs_current"
Liz Kammerae3994e2021-10-19 09:45:48 -040042)
43
Liz Kammer2222c6b2021-05-24 15:41:47 -040044// staticOrSharedAttributes are the Bazel-ified versions of StaticOrSharedProperties --
Jingwen Chenbcf53042021-05-26 04:42:42 +000045// properties which apply to either the shared or static version of a cc_library module.
Liz Kammer2222c6b2021-05-24 15:41:47 -040046type staticOrSharedAttributes struct {
Vinh Tran9f6796a2022-08-16 13:10:31 -040047 Srcs bazel.LabelListAttribute
48 Srcs_c bazel.LabelListAttribute
49 Srcs_as bazel.LabelListAttribute
50 Srcs_aidl bazel.LabelListAttribute
51 Hdrs bazel.LabelListAttribute
52 Copts bazel.StringListAttribute
Jingwen Chen14a8bda2021-06-02 11:10:02 +000053
Liz Kammer12615db2021-09-28 09:19:17 -040054 Deps bazel.LabelListAttribute
55 Implementation_deps bazel.LabelListAttribute
56 Dynamic_deps bazel.LabelListAttribute
57 Implementation_dynamic_deps bazel.LabelListAttribute
58 Whole_archive_deps bazel.LabelListAttribute
59 Implementation_whole_archive_deps bazel.LabelListAttribute
Cole Faust6b29f592022-08-09 09:50:56 -070060 Runtime_deps bazel.LabelListAttribute
Chris Parsons51f8c392021-08-03 21:01:05 -040061
62 System_dynamic_deps bazel.LabelListAttribute
Chris Parsons58852a02021-12-09 18:10:18 -050063
64 Enabled bazel.BoolAttribute
Yu Liufc603162022-03-01 15:44:08 -080065
Yu Liuf01a0f02022-12-07 15:45:30 -080066 Native_coverage *bool
Yu Liu8d82ac52022-05-17 15:13:28 -070067
Liz Kammeraceec252023-03-24 09:46:36 -040068 Apex_available []string
69
Trevor Radcliffea8b44162023-04-14 18:25:24 +000070 Features bazel.StringListAttribute
71
Yu Liufc603162022-03-01 15:44:08 -080072 sdkAttributes
Sam Delmericofb3bb322022-10-21 10:42:24 -040073
74 tidyAttributes
75}
76
77type tidyAttributes struct {
Sam Delmerico63f0c932023-03-14 14:05:28 -040078 Tidy *string
Sam Delmericofb3bb322022-10-21 10:42:24 -040079 Tidy_flags []string
80 Tidy_checks []string
81 Tidy_checks_as_errors []string
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -040082 Tidy_disabled_srcs bazel.LabelListAttribute
Sam Delmerico4c902d62022-11-02 14:17:15 -040083 Tidy_timeout_srcs bazel.LabelListAttribute
Sam Delmericofb3bb322022-10-21 10:42:24 -040084}
85
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -040086func (m *Module) convertTidyAttributes(ctx android.BaseMutatorContext, moduleAttrs *tidyAttributes) {
Sam Delmericofb3bb322022-10-21 10:42:24 -040087 for _, f := range m.features {
88 if tidy, ok := f.(*tidyFeature); ok {
Sam Delmerico63f0c932023-03-14 14:05:28 -040089 var tidyAttr *string
90 if tidy.Properties.Tidy != nil {
91 if *tidy.Properties.Tidy {
92 tidyAttr = proptools.StringPtr("local")
93 } else {
94 tidyAttr = proptools.StringPtr("never")
95 }
96 }
97 moduleAttrs.Tidy = tidyAttr
Sam Delmericofb3bb322022-10-21 10:42:24 -040098 moduleAttrs.Tidy_flags = tidy.Properties.Tidy_flags
99 moduleAttrs.Tidy_checks = tidy.Properties.Tidy_checks
100 moduleAttrs.Tidy_checks_as_errors = tidy.Properties.Tidy_checks_as_errors
101 }
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400102
103 }
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400104 archVariantProps := m.GetArchVariantProperties(ctx, &BaseCompilerProperties{})
105 for axis, configToProps := range archVariantProps {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800106 for cfg, _props := range configToProps {
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400107 if archProps, ok := _props.(*BaseCompilerProperties); ok {
108 archDisabledSrcs := android.BazelLabelForModuleSrc(ctx, archProps.Tidy_disabled_srcs)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800109 moduleAttrs.Tidy_disabled_srcs.SetSelectValue(axis, cfg, archDisabledSrcs)
Sam Delmerico4c902d62022-11-02 14:17:15 -0400110 archTimeoutSrcs := android.BazelLabelForModuleSrc(ctx, archProps.Tidy_timeout_srcs)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800111 moduleAttrs.Tidy_timeout_srcs.SetSelectValue(axis, cfg, archTimeoutSrcs)
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400112 }
113 }
Sam Delmericofb3bb322022-10-21 10:42:24 -0400114 }
Jingwen Chen53681ef2021-04-29 08:15:13 +0000115}
116
Sam Delmericoc7681022022-02-04 21:01:20 +0000117// groupSrcsByExtension partitions `srcs` into groups based on file extension.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000118func groupSrcsByExtension(ctx android.BazelConversionPathContext, srcs bazel.LabelListAttribute) bazel.PartitionToLabelListAttribute {
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400119 // Convert filegroup dependencies into extension-specific filegroups filtered in the filegroup.bzl
120 // macro.
121 addSuffixForFilegroup := func(suffix string) bazel.LabelMapper {
Vinh Tran9f6796a2022-08-16 13:10:31 -0400122 return func(otherModuleCtx bazel.OtherModuleContext, label bazel.Label) (string, bool) {
123
124 m, exists := otherModuleCtx.ModuleFromName(label.OriginalModuleName)
Liz Kammer12615db2021-09-28 09:19:17 -0400125 labelStr := label.Label
Vinh Tran9f6796a2022-08-16 13:10:31 -0400126 if !exists || !android.IsFilegroup(otherModuleCtx, m) {
127 return labelStr, false
128 }
Yu Liu2aa806b2022-09-01 11:54:47 -0700129 // If the filegroup is already converted to aidl_library or proto_library,
130 // skip creating _c_srcs, _as_srcs, _cpp_srcs filegroups
131 fg, _ := m.(android.FileGroupAsLibrary)
132 if fg.ShouldConvertToAidlLibrary(ctx) || fg.ShouldConvertToProtoLibrary(ctx) {
Liz Kammer12615db2021-09-28 09:19:17 -0400133 return labelStr, false
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000134 }
Liz Kammer12615db2021-09-28 09:19:17 -0400135 return labelStr + suffix, true
Chris Parsons5a34ffb2021-07-21 14:34:58 -0400136 }
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000137 }
138
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400139 // TODO(b/190006308): Handle language detection of sources in a Bazel rule.
Sam Delmericoc7681022022-02-04 21:01:20 +0000140 labels := bazel.LabelPartitions{
141 protoSrcPartition: android.ProtoSrcLabelPartition,
Liz Kammeraabfb5d2021-12-08 15:25:06 -0500142 cSrcPartition: bazel.LabelPartition{Extensions: []string{".c"}, LabelMapper: addSuffixForFilegroup("_c_srcs")},
143 asSrcPartition: bazel.LabelPartition{Extensions: []string{".s", ".S"}, LabelMapper: addSuffixForFilegroup("_as_srcs")},
Cole Faust7071a052022-07-29 15:58:33 -0700144 asmSrcPartition: bazel.LabelPartition{Extensions: []string{".asm"}},
Vinh Tran9f6796a2022-08-16 13:10:31 -0400145 aidlSrcPartition: android.AidlSrcLabelPartition,
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000146 // TODO(http://b/231968910): If there is ever a filegroup target that
147 // contains .l or .ll files we will need to find a way to add a
148 // LabelMapper for these that identifies these filegroups and
149 // converts them appropriately
150 lSrcPartition: bazel.LabelPartition{Extensions: []string{".l"}},
151 llSrcPartition: bazel.LabelPartition{Extensions: []string{".ll"}},
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400152 // C++ is the "catch-all" group, and comprises generated sources because we don't
153 // know the language of these sources until the genrule is executed.
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000154 cppSrcPartition: bazel.LabelPartition{Extensions: []string{".cpp", ".cc", ".cxx", ".mm"}, LabelMapper: addSuffixForFilegroup("_cpp_srcs"), Keep_remainder: true},
155 syspropSrcPartition: bazel.LabelPartition{Extensions: []string{".sysprop"}},
Sam Delmericoc7681022022-02-04 21:01:20 +0000156 }
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000157
Sam Delmericoc7681022022-02-04 21:01:20 +0000158 return bazel.PartitionLabelListAttribute(ctx, &srcs, labels)
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000159}
160
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000161// bp2BuildParseLibProps returns the attributes for a variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000162func bp2BuildParseLibProps(ctx android.BazelConversionPathContext, module *Module, isStatic bool) staticOrSharedAttributes {
Jingwen Chen53681ef2021-04-29 08:15:13 +0000163 lib, ok := module.compiler.(*libraryDecorator)
164 if !ok {
Liz Kammer2222c6b2021-05-24 15:41:47 -0400165 return staticOrSharedAttributes{}
Jingwen Chen53681ef2021-04-29 08:15:13 +0000166 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000167 return bp2buildParseStaticOrSharedProps(ctx, module, lib, isStatic)
168}
Jingwen Chen53681ef2021-04-29 08:15:13 +0000169
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000170// bp2buildParseSharedProps returns the attributes for the shared variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000171func bp2BuildParseSharedProps(ctx android.BazelConversionPathContext, module *Module) staticOrSharedAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000172 return bp2BuildParseLibProps(ctx, module, false)
Jingwen Chen53681ef2021-04-29 08:15:13 +0000173}
174
175// bp2buildParseStaticProps returns the attributes for the static variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000176func bp2BuildParseStaticProps(ctx android.BazelConversionPathContext, module *Module) staticOrSharedAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000177 return bp2BuildParseLibProps(ctx, module, true)
Liz Kammer2222c6b2021-05-24 15:41:47 -0400178}
179
Liz Kammer7a210ac2021-09-22 15:52:58 -0400180type depsPartition struct {
181 export bazel.LabelList
182 implementation bazel.LabelList
183}
184
Jingwen Chen55bc8202021-11-02 06:40:51 +0000185type bazelLabelForDepsFn func(android.BazelConversionPathContext, []string) bazel.LabelList
Liz Kammer7a210ac2021-09-22 15:52:58 -0400186
Jingwen Chen55bc8202021-11-02 06:40:51 +0000187func maybePartitionExportedAndImplementationsDeps(ctx android.BazelConversionPathContext, exportsDeps bool, allDeps, exportedDeps []string, fn bazelLabelForDepsFn) depsPartition {
Liz Kammer2b8004b2021-10-04 13:55:44 -0400188 if !exportsDeps {
189 return depsPartition{
190 implementation: fn(ctx, allDeps),
191 }
192 }
193
Liz Kammer7a210ac2021-09-22 15:52:58 -0400194 implementation, export := android.FilterList(allDeps, exportedDeps)
195
196 return depsPartition{
197 export: fn(ctx, export),
198 implementation: fn(ctx, implementation),
199 }
200}
201
Jingwen Chen55bc8202021-11-02 06:40:51 +0000202type bazelLabelForDepsExcludesFn func(android.BazelConversionPathContext, []string, []string) bazel.LabelList
Liz Kammer7a210ac2021-09-22 15:52:58 -0400203
Jingwen Chen55bc8202021-11-02 06:40:51 +0000204func maybePartitionExportedAndImplementationsDepsExcludes(ctx android.BazelConversionPathContext, exportsDeps bool, allDeps, excludes, exportedDeps []string, fn bazelLabelForDepsExcludesFn) depsPartition {
Liz Kammer2b8004b2021-10-04 13:55:44 -0400205 if !exportsDeps {
206 return depsPartition{
207 implementation: fn(ctx, allDeps, excludes),
208 }
209 }
Liz Kammer7a210ac2021-09-22 15:52:58 -0400210 implementation, export := android.FilterList(allDeps, exportedDeps)
211
212 return depsPartition{
213 export: fn(ctx, export, excludes),
214 implementation: fn(ctx, implementation, excludes),
215 }
216}
217
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000218func bp2BuildPropParseHelper(ctx android.ArchVariantContext, module *Module, propsType interface{}, parseFunc func(axis bazel.ConfigurationAxis, config string, props interface{})) {
219 for axis, configToProps := range module.GetArchVariantProperties(ctx, propsType) {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800220 for cfg, props := range configToProps {
221 parseFunc(axis, cfg, props)
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000222 }
223 }
224}
225
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000226// Parses properties common to static and shared libraries. Also used for prebuilt libraries.
Liz Kammeraceec252023-03-24 09:46:36 -0400227func bp2buildParseStaticOrSharedProps(ctx android.BazelConversionPathContext, module *Module, lib *libraryDecorator, isStatic bool) staticOrSharedAttributes {
Liz Kammer135bf552021-08-11 10:46:06 -0400228 attrs := staticOrSharedAttributes{}
Jingwen Chenbcf53042021-05-26 04:42:42 +0000229
Liz Kammer9abd62d2021-05-21 08:37:59 -0400230 setAttrs := func(axis bazel.ConfigurationAxis, config string, props StaticOrSharedProperties) {
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000231 attrs.Copts.SetSelectValue(axis, config, parseCommandLineFlags(props.Cflags, filterOutStdFlag, filterOutHiddenVisibility))
Jingwen Chenc4dc9b42021-06-11 12:51:48 +0000232 attrs.Srcs.SetSelectValue(axis, config, android.BazelLabelForModuleSrc(ctx, props.Srcs))
Chris Parsons953b3562021-09-20 15:14:39 -0400233 attrs.System_dynamic_deps.SetSelectValue(axis, config, bazelLabelForSharedDeps(ctx, props.System_shared_libs))
Liz Kammer7a210ac2021-09-22 15:52:58 -0400234
Liz Kammer2b8004b2021-10-04 13:55:44 -0400235 staticDeps := maybePartitionExportedAndImplementationsDeps(ctx, true, props.Static_libs, props.Export_static_lib_headers, bazelLabelForStaticDeps)
Liz Kammer7a210ac2021-09-22 15:52:58 -0400236 attrs.Deps.SetSelectValue(axis, config, staticDeps.export)
237 attrs.Implementation_deps.SetSelectValue(axis, config, staticDeps.implementation)
238
Liz Kammer2b8004b2021-10-04 13:55:44 -0400239 sharedDeps := maybePartitionExportedAndImplementationsDeps(ctx, true, props.Shared_libs, props.Export_shared_lib_headers, bazelLabelForSharedDeps)
Liz Kammer7a210ac2021-09-22 15:52:58 -0400240 attrs.Dynamic_deps.SetSelectValue(axis, config, sharedDeps.export)
241 attrs.Implementation_dynamic_deps.SetSelectValue(axis, config, sharedDeps.implementation)
242
243 attrs.Whole_archive_deps.SetSelectValue(axis, config, bazelLabelForWholeDeps(ctx, props.Whole_static_libs))
Chris Parsons58852a02021-12-09 18:10:18 -0500244 attrs.Enabled.SetSelectValue(axis, config, props.Enabled)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000245 }
Liz Kammer135bf552021-08-11 10:46:06 -0400246 // system_dynamic_deps distinguishes between nil/empty list behavior:
247 // nil -> use default values
248 // empty list -> no values specified
249 attrs.System_dynamic_deps.ForceSpecifyEmptyList = true
Jingwen Chenbcf53042021-05-26 04:42:42 +0000250
Liz Kammeraceec252023-03-24 09:46:36 -0400251 var apexAvailable []string
Jingwen Chenbcf53042021-05-26 04:42:42 +0000252 if isStatic {
Liz Kammeraceec252023-03-24 09:46:36 -0400253 apexAvailable = lib.StaticProperties.Static.Apex_available
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000254 bp2BuildPropParseHelper(ctx, module, &StaticProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
255 if staticOrSharedProps, ok := props.(*StaticProperties); ok {
256 setAttrs(axis, config, staticOrSharedProps.Static)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000257 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000258 })
Jingwen Chenbcf53042021-05-26 04:42:42 +0000259 } else {
Liz Kammeraceec252023-03-24 09:46:36 -0400260 apexAvailable = lib.SharedProperties.Shared.Apex_available
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000261 bp2BuildPropParseHelper(ctx, module, &SharedProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
262 if staticOrSharedProps, ok := props.(*SharedProperties); ok {
263 setAttrs(axis, config, staticOrSharedProps.Shared)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000264 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000265 })
Jingwen Chenbcf53042021-05-26 04:42:42 +0000266 }
267
Liz Kammerae3994e2021-10-19 09:45:48 -0400268 partitionedSrcs := groupSrcsByExtension(ctx, attrs.Srcs)
269 attrs.Srcs = partitionedSrcs[cppSrcPartition]
270 attrs.Srcs_c = partitionedSrcs[cSrcPartition]
271 attrs.Srcs_as = partitionedSrcs[asSrcPartition]
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000272
Liz Kammeraceec252023-03-24 09:46:36 -0400273 attrs.Apex_available = android.ConvertApexAvailableToTags(apexAvailable)
274
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000275 attrs.Features.Append(convertHiddenVisibilityToFeatureStaticOrShared(ctx, module, isStatic))
276
Liz Kammer12615db2021-09-28 09:19:17 -0400277 if !partitionedSrcs[protoSrcPartition].IsEmpty() {
278 // TODO(b/208815215): determine whether this is used and add support if necessary
279 ctx.ModuleErrorf("Migrating static/shared only proto srcs is not currently supported")
280 }
281
Jingwen Chenbcf53042021-05-26 04:42:42 +0000282 return attrs
Jingwen Chen53681ef2021-04-29 08:15:13 +0000283}
284
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400285// Convenience struct to hold all attributes parsed from prebuilt properties.
286type prebuiltAttributes struct {
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000287 Src bazel.LabelAttribute
288 Enabled bazel.BoolAttribute
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400289}
290
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000291func parseSrc(ctx android.BazelConversionPathContext, srcLabelAttribute *bazel.LabelAttribute, axis bazel.ConfigurationAxis, config string, srcs []string) {
292 srcFileError := func() {
293 ctx.ModuleErrorf("parseSrc: Expected at most one source file for %s %s\n", axis, config)
294 }
295 if len(srcs) > 1 {
296 srcFileError()
297 return
298 } else if len(srcs) == 0 {
299 return
300 }
301 if srcLabelAttribute.SelectValue(axis, config) != nil {
302 srcFileError()
303 return
304 }
305 srcLabelAttribute.SetSelectValue(axis, config, android.BazelLabelForModuleSrcSingle(ctx, srcs[0]))
306}
307
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000308// NOTE: Used outside of Soong repo project, in the clangprebuilts.go bootstrap_go_package
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000309func Bp2BuildParsePrebuiltLibraryProps(ctx android.BazelConversionPathContext, module *Module, isStatic bool) prebuiltAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000310
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400311 var srcLabelAttribute bazel.LabelAttribute
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000312 bp2BuildPropParseHelper(ctx, module, &prebuiltLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
313 if prebuiltLinkerProperties, ok := props.(*prebuiltLinkerProperties); ok {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000314 parseSrc(ctx, &srcLabelAttribute, axis, config, prebuiltLinkerProperties.Srcs)
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000315 }
316 })
317
318 var enabledLabelAttribute bazel.BoolAttribute
319 parseAttrs := func(axis bazel.ConfigurationAxis, config string, props StaticOrSharedProperties) {
320 if props.Enabled != nil {
321 enabledLabelAttribute.SetSelectValue(axis, config, props.Enabled)
322 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000323 parseSrc(ctx, &srcLabelAttribute, axis, config, props.Srcs)
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000324 }
325
326 if isStatic {
327 bp2BuildPropParseHelper(ctx, module, &StaticProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
328 if staticProperties, ok := props.(*StaticProperties); ok {
329 parseAttrs(axis, config, staticProperties.Static)
330 }
331 })
332 } else {
333 bp2BuildPropParseHelper(ctx, module, &SharedProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
334 if sharedProperties, ok := props.(*SharedProperties); ok {
335 parseAttrs(axis, config, sharedProperties.Shared)
336 }
337 })
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400338 }
339
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400340 return prebuiltAttributes{
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000341 Src: srcLabelAttribute,
342 Enabled: enabledLabelAttribute,
343 }
344}
345
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000346func bp2BuildParsePrebuiltBinaryProps(ctx android.BazelConversionPathContext, module *Module) prebuiltAttributes {
347 var srcLabelAttribute bazel.LabelAttribute
348 bp2BuildPropParseHelper(ctx, module, &prebuiltLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
349 if props, ok := props.(*prebuiltLinkerProperties); ok {
350 parseSrc(ctx, &srcLabelAttribute, axis, config, props.Srcs)
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000351 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000352 })
353
354 return prebuiltAttributes{
355 Src: srcLabelAttribute,
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400356 }
357}
358
Colin Crossc5075e92022-12-05 16:46:39 -0800359func bp2BuildParsePrebuiltObjectProps(ctx android.BazelConversionPathContext, module *Module) prebuiltAttributes {
360 var srcLabelAttribute bazel.LabelAttribute
361 bp2BuildPropParseHelper(ctx, module, &prebuiltObjectProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
362 if props, ok := props.(*prebuiltObjectProperties); ok {
363 parseSrc(ctx, &srcLabelAttribute, axis, config, props.Srcs)
364 }
365 })
366
367 return prebuiltAttributes{
368 Src: srcLabelAttribute,
369 }
370}
371
Liz Kammere6583482021-10-19 13:56:10 -0400372type baseAttributes struct {
373 compilerAttributes
374 linkerAttributes
Liz Kammer12615db2021-09-28 09:19:17 -0400375
Trevor Radcliffedb7e0262022-10-28 16:48:18 +0000376 // A combination of compilerAttributes.features and linkerAttributes.features, as well as sanitizer features
Cole Faust5fa4e962022-08-22 14:31:04 -0700377 features bazel.StringListAttribute
Liz Kammer12615db2021-09-28 09:19:17 -0400378 protoDependency *bazel.LabelAttribute
Vinh Tran9f6796a2022-08-16 13:10:31 -0400379 aidlDependency *bazel.LabelAttribute
Yu Liuf01a0f02022-12-07 15:45:30 -0800380 Native_coverage *bool
Liz Kammere6583482021-10-19 13:56:10 -0400381}
382
Jingwen Chen107c0de2021-04-09 10:43:12 +0000383// Convenience struct to hold all attributes parsed from compiler properties.
384type compilerAttributes struct {
Chris Parsons990c4f42021-05-25 12:10:58 -0400385 // Options for all languages
386 copts bazel.StringListAttribute
387 // Assembly options and sources
388 asFlags bazel.StringListAttribute
389 asSrcs bazel.LabelListAttribute
Cole Faust7071a052022-07-29 15:58:33 -0700390 asmSrcs bazel.LabelListAttribute
Chris Parsons990c4f42021-05-25 12:10:58 -0400391 // C options and sources
392 conlyFlags bazel.StringListAttribute
393 cSrcs bazel.LabelListAttribute
394 // C++ options and sources
395 cppFlags bazel.StringListAttribute
Jingwen Chened9c17d2021-04-13 07:14:55 +0000396 srcs bazel.LabelListAttribute
Chris Parsons2c788392021-08-10 11:58:07 -0400397
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000398 // Lex sources and options
399 lSrcs bazel.LabelListAttribute
400 llSrcs bazel.LabelListAttribute
401 lexopts bazel.StringListAttribute
402
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000403 // Sysprop sources
404 syspropSrcs bazel.LabelListAttribute
405
Liz Kammere6583482021-10-19 13:56:10 -0400406 hdrs bazel.LabelListAttribute
407
Chris Parsons2c788392021-08-10 11:58:07 -0400408 rtti bazel.BoolAttribute
Jingwen Chen5b11ab12021-10-11 17:44:33 +0000409
410 // Not affected by arch variants
411 stl *string
Chris Parsons79bd2b72021-11-29 17:52:41 -0500412 cStd *string
Jingwen Chen5b11ab12021-10-11 17:44:33 +0000413 cppStd *string
Liz Kammer35687bc2021-09-10 10:07:07 -0400414
415 localIncludes bazel.StringListAttribute
416 absoluteIncludes bazel.StringListAttribute
Liz Kammer12615db2021-09-28 09:19:17 -0400417
Liz Kammer1263d9b2021-12-10 14:28:20 -0500418 includes BazelIncludes
419
Liz Kammer12615db2021-09-28 09:19:17 -0400420 protoSrcs bazel.LabelListAttribute
Vinh Tran9f6796a2022-08-16 13:10:31 -0400421 aidlSrcs bazel.LabelListAttribute
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000422
423 stubsSymbolFile *string
424 stubsVersions bazel.StringListAttribute
Cole Faust5fa4e962022-08-22 14:31:04 -0700425
426 features bazel.StringListAttribute
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500427
428 suffix bazel.StringAttribute
Vinh Tran99270ea2022-11-28 11:15:23 -0500429
430 fdoProfile bazel.LabelAttribute
Jingwen Chen107c0de2021-04-09 10:43:12 +0000431}
432
Liz Kammercac7f692021-12-16 14:19:32 -0500433type filterOutFn func(string) bool
434
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000435// filterOutHiddenVisibility removes the flag specifying hidden visibility as
436// this flag is converted to a toolchain feature
437func filterOutHiddenVisibility(flag string) bool {
438 return flag == config.VisibilityHiddenFlag
439}
440
Liz Kammercac7f692021-12-16 14:19:32 -0500441func filterOutStdFlag(flag string) bool {
442 return strings.HasPrefix(flag, "-std=")
443}
444
Alix1be00d42022-05-16 22:56:04 +0000445func filterOutClangUnknownCflags(flag string) bool {
446 for _, f := range config.ClangUnknownCflags {
447 if f == flag {
448 return true
449 }
450 }
451 return false
452}
453
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000454func parseCommandLineFlags(soongFlags []string, filterOut ...filterOutFn) []string {
Liz Kammere6583482021-10-19 13:56:10 -0400455 var result []string
456 for _, flag := range soongFlags {
Alix1be00d42022-05-16 22:56:04 +0000457 skipFlag := false
458 for _, filter := range filterOut {
459 if filter != nil && filter(flag) {
460 skipFlag = true
461 }
462 }
463 if skipFlag {
Liz Kammercac7f692021-12-16 14:19:32 -0500464 continue
465 }
Liz Kammere6583482021-10-19 13:56:10 -0400466 // Soong's cflags can contain spaces, like `-include header.h`. For
467 // Bazel's copts, split them up to be compatible with the
468 // no_copts_tokenization feature.
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000469 result = append(result, strings.Split(flag, " ")...)
Liz Kammere6583482021-10-19 13:56:10 -0400470 }
471 return result
472}
Jingwen Chened9c17d2021-04-13 07:14:55 +0000473
Jingwen Chen55bc8202021-11-02 06:40:51 +0000474func (ca *compilerAttributes) bp2buildForAxisAndConfig(ctx android.BazelConversionPathContext, axis bazel.ConfigurationAxis, config string, props *BaseCompilerProperties) {
Liz Kammere6583482021-10-19 13:56:10 -0400475 // If there's arch specific srcs or exclude_srcs, generate a select entry for it.
476 // TODO(b/186153868): do this for OS specific srcs and exclude_srcs too.
477 if srcsList, ok := parseSrcs(ctx, props); ok {
478 ca.srcs.SetSelectValue(axis, config, srcsList)
Chris Parsons990c4f42021-05-25 12:10:58 -0400479 }
480
Liz Kammere6583482021-10-19 13:56:10 -0400481 localIncludeDirs := props.Local_include_dirs
482 if axis == bazel.NoConfigAxis {
Chris Parsons79bd2b72021-11-29 17:52:41 -0500483 ca.cStd, ca.cppStd = bp2buildResolveCppStdValue(props.C_std, props.Cpp_std, props.Gnu_extensions)
Liz Kammere6583482021-10-19 13:56:10 -0400484 if includeBuildDirectory(props.Include_build_directory) {
485 localIncludeDirs = append(localIncludeDirs, ".")
Liz Kammer222bdcf2021-10-11 14:15:51 -0400486 }
Jingwen Chene32e9e02021-04-23 09:17:24 +0000487 }
488
Liz Kammere6583482021-10-19 13:56:10 -0400489 ca.absoluteIncludes.SetSelectValue(axis, config, props.Include_dirs)
490 ca.localIncludes.SetSelectValue(axis, config, localIncludeDirs)
491
Cole Faust5fa4e962022-08-22 14:31:04 -0700492 instructionSet := proptools.StringDefault(props.Instruction_set, "")
493 if instructionSet == "arm" {
494 ca.features.SetSelectValue(axis, config, []string{"arm_isa_arm", "-arm_isa_thumb"})
495 } else if instructionSet != "" && instructionSet != "thumb" {
496 ctx.ModuleErrorf("Unknown value for instruction_set: %s", instructionSet)
497 }
498
Liz Kammercac7f692021-12-16 14:19:32 -0500499 // In Soong, cflags occur on the command line before -std=<val> flag, resulting in the value being
500 // overridden. In Bazel we always allow overriding, via flags; however, this can cause
501 // incompatibilities, so we remove "-std=" flags from Cflag properties while leaving it in other
502 // cases.
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000503 ca.copts.SetSelectValue(axis, config, parseCommandLineFlags(props.Cflags, filterOutStdFlag, filterOutClangUnknownCflags, filterOutHiddenVisibility))
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000504 ca.asFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Asflags, nil))
505 ca.conlyFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Conlyflags, filterOutClangUnknownCflags))
506 ca.cppFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Cppflags, filterOutClangUnknownCflags))
Liz Kammere6583482021-10-19 13:56:10 -0400507 ca.rtti.SetSelectValue(axis, config, props.Rtti)
508}
509
Jingwen Chen55bc8202021-11-02 06:40:51 +0000510func (ca *compilerAttributes) convertStlProps(ctx android.ArchVariantContext, module *Module) {
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000511 bp2BuildPropParseHelper(ctx, module, &StlProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
512 if stlProps, ok := props.(*StlProperties); ok {
513 if stlProps.Stl == nil {
514 return
515 }
516 if ca.stl == nil {
Liz Kammer7128d382022-05-12 11:42:33 -0400517 stl := deduplicateStlInput(*stlProps.Stl)
518 ca.stl = &stl
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000519 } else if ca.stl != stlProps.Stl {
520 ctx.ModuleErrorf("Unsupported conversion: module with different stl for different variants: %s and %s", *ca.stl, stlProps.Stl)
Liz Kammer9abd62d2021-05-21 08:37:59 -0400521 }
Jingwen Chenc1c26502021-04-05 10:35:13 +0000522 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000523 })
Liz Kammere6583482021-10-19 13:56:10 -0400524}
Jingwen Chenc1c26502021-04-05 10:35:13 +0000525
Jingwen Chen55bc8202021-11-02 06:40:51 +0000526func (ca *compilerAttributes) convertProductVariables(ctx android.BazelConversionPathContext, productVariableProps android.ProductConfigProperties) {
Liz Kammerba7a9c52021-05-26 08:45:30 -0400527 productVarPropNameToAttribute := map[string]*bazel.StringListAttribute{
Liz Kammere6583482021-10-19 13:56:10 -0400528 "Cflags": &ca.copts,
529 "Asflags": &ca.asFlags,
530 "CppFlags": &ca.cppFlags,
Liz Kammerba7a9c52021-05-26 08:45:30 -0400531 }
Liz Kammerba7a9c52021-05-26 08:45:30 -0400532 for propName, attr := range productVarPropNameToAttribute {
Jingwen Chen25825ca2021-11-15 12:28:43 +0000533 if productConfigProps, exists := productVariableProps[propName]; exists {
534 for productConfigProp, prop := range productConfigProps {
535 flags, ok := prop.([]string)
Liz Kammerba7a9c52021-05-26 08:45:30 -0400536 if !ok {
537 ctx.ModuleErrorf("Could not convert product variable %s property", proptools.PropertyNameForField(propName))
538 }
Jingwen Chen25825ca2021-11-15 12:28:43 +0000539 newFlags, _ := bazel.TryVariableSubstitutions(flags, productConfigProp.Name)
540 attr.SetSelectValue(productConfigProp.ConfigurationAxis(), productConfigProp.SelectKey(), newFlags)
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400541 }
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400542 }
543 }
Liz Kammere6583482021-10-19 13:56:10 -0400544}
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400545
Jingwen Chen55bc8202021-11-02 06:40:51 +0000546func (ca *compilerAttributes) finalize(ctx android.BazelConversionPathContext, implementationHdrs bazel.LabelListAttribute) {
Liz Kammere6583482021-10-19 13:56:10 -0400547 ca.srcs.ResolveExcludes()
548 partitionedSrcs := groupSrcsByExtension(ctx, ca.srcs)
549
Liz Kammer12615db2021-09-28 09:19:17 -0400550 ca.protoSrcs = partitionedSrcs[protoSrcPartition]
Vinh Tran9f6796a2022-08-16 13:10:31 -0400551 ca.aidlSrcs = partitionedSrcs[aidlSrcPartition]
Liz Kammer12615db2021-09-28 09:19:17 -0400552
Liz Kammere6583482021-10-19 13:56:10 -0400553 for p, lla := range partitionedSrcs {
554 // if there are no sources, there is no need for headers
555 if lla.IsEmpty() {
556 continue
557 }
558 lla.Append(implementationHdrs)
559 partitionedSrcs[p] = lla
560 }
561
562 ca.srcs = partitionedSrcs[cppSrcPartition]
563 ca.cSrcs = partitionedSrcs[cSrcPartition]
564 ca.asSrcs = partitionedSrcs[asSrcPartition]
Cole Faust7071a052022-07-29 15:58:33 -0700565 ca.asmSrcs = partitionedSrcs[asmSrcPartition]
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000566 ca.lSrcs = partitionedSrcs[lSrcPartition]
567 ca.llSrcs = partitionedSrcs[llSrcPartition]
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000568 ca.syspropSrcs = partitionedSrcs[syspropSrcPartition]
Liz Kammere6583482021-10-19 13:56:10 -0400569
570 ca.absoluteIncludes.DeduplicateAxesFromBase()
571 ca.localIncludes.DeduplicateAxesFromBase()
572}
573
574// Parse srcs from an arch or OS's props value.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000575func parseSrcs(ctx android.BazelConversionPathContext, props *BaseCompilerProperties) (bazel.LabelList, bool) {
Liz Kammere6583482021-10-19 13:56:10 -0400576 anySrcs := false
577 // Add srcs-like dependencies such as generated files.
578 // First create a LabelList containing these dependencies, then merge the values with srcs.
579 generatedSrcsLabelList := android.BazelLabelForModuleDepsExcludes(ctx, props.Generated_sources, props.Exclude_generated_sources)
580 if len(props.Generated_sources) > 0 || len(props.Exclude_generated_sources) > 0 {
581 anySrcs = true
582 }
583
584 allSrcsLabelList := android.BazelLabelForModuleSrcExcludes(ctx, props.Srcs, props.Exclude_srcs)
Vinh Tran9f6796a2022-08-16 13:10:31 -0400585
Liz Kammere6583482021-10-19 13:56:10 -0400586 if len(props.Srcs) > 0 || len(props.Exclude_srcs) > 0 {
587 anySrcs = true
588 }
Vinh Tran9f6796a2022-08-16 13:10:31 -0400589
Liz Kammere6583482021-10-19 13:56:10 -0400590 return bazel.AppendBazelLabelLists(allSrcsLabelList, generatedSrcsLabelList), anySrcs
591}
592
Liz Kammera5a29de2022-05-25 23:19:37 -0400593func bp2buildStdVal(std *string, prefix string, useGnu bool) *string {
594 defaultVal := prefix + "_std_default"
Chris Parsons79bd2b72021-11-29 17:52:41 -0500595 // If c{,pp}std properties are not specified, don't generate them in the BUILD file.
596 // Defaults are handled by the toolchain definition.
597 // However, if gnu_extensions is false, then the default gnu-to-c version must be specified.
Liz Kammera5a29de2022-05-25 23:19:37 -0400598 stdVal := proptools.StringDefault(std, defaultVal)
599 if stdVal == "experimental" || stdVal == defaultVal {
600 if stdVal == "experimental" {
601 stdVal = prefix + "_std_experimental"
602 }
603 if !useGnu {
604 stdVal += "_no_gnu"
605 }
606 } else if !useGnu {
607 stdVal = gnuToCReplacer.Replace(stdVal)
Chris Parsons79bd2b72021-11-29 17:52:41 -0500608 }
609
Liz Kammera5a29de2022-05-25 23:19:37 -0400610 if stdVal == defaultVal {
611 return nil
Liz Kammer46fb7ab2021-12-01 10:09:34 -0500612 }
Liz Kammera5a29de2022-05-25 23:19:37 -0400613 return &stdVal
614}
Liz Kammer46fb7ab2021-12-01 10:09:34 -0500615
Liz Kammera5a29de2022-05-25 23:19:37 -0400616func bp2buildResolveCppStdValue(c_std *string, cpp_std *string, gnu_extensions *bool) (*string, *string) {
617 useGnu := useGnuExtensions(gnu_extensions)
618
619 return bp2buildStdVal(c_std, "c", useGnu), bp2buildStdVal(cpp_std, "cpp", useGnu)
Liz Kammere6583482021-10-19 13:56:10 -0400620}
621
Liz Kammer1263d9b2021-12-10 14:28:20 -0500622// packageFromLabel extracts package from a fully-qualified or relative Label and whether the label
623// is fully-qualified.
624// e.g. fully-qualified "//a/b:foo" -> "a/b", true, relative: ":bar" -> ".", false
625func packageFromLabel(label string) (string, bool) {
626 split := strings.Split(label, ":")
627 if len(split) != 2 {
628 return "", false
629 }
630 if split[0] == "" {
631 return ".", false
632 }
633 // remove leading "//"
634 return split[0][2:], true
635}
636
637// includesFromLabelList extracts relative/absolute includes from a bazel.LabelList>
638func includesFromLabelList(labelList bazel.LabelList) (relative, absolute []string) {
639 for _, hdr := range labelList.Includes {
640 if pkg, hasPkg := packageFromLabel(hdr.Label); hasPkg {
641 absolute = append(absolute, pkg)
642 } else if pkg != "" {
643 relative = append(relative, pkg)
644 }
645 }
646 return relative, absolute
647}
648
Cole Faust7071a052022-07-29 15:58:33 -0700649type YasmAttributes struct {
650 Srcs bazel.LabelListAttribute
651 Flags bazel.StringListAttribute
652 Include_dirs bazel.StringListAttribute
653}
654
655func bp2BuildYasm(ctx android.Bp2buildMutatorContext, m *Module, ca compilerAttributes) *bazel.LabelAttribute {
656 if ca.asmSrcs.IsEmpty() {
657 return nil
658 }
659
660 // Yasm needs the include directories from both local_includes and
661 // export_include_dirs. We don't care about actually exporting them from the
662 // yasm rule though, because they will also be present on the cc_ rule that
663 // wraps this yasm rule.
664 includes := ca.localIncludes.Clone()
665 bp2BuildPropParseHelper(ctx, m, &FlagExporterProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
666 if flagExporterProperties, ok := props.(*FlagExporterProperties); ok {
667 if len(flagExporterProperties.Export_include_dirs) > 0 {
668 x := bazel.StringListAttribute{}
669 x.SetSelectValue(axis, config, flagExporterProperties.Export_include_dirs)
670 includes.Append(x)
671 }
672 }
673 })
674
675 ctx.CreateBazelTargetModule(
676 bazel.BazelTargetModuleProperties{
677 Rule_class: "yasm",
678 Bzl_load_location: "//build/bazel/rules/cc:yasm.bzl",
679 },
680 android.CommonAttributes{Name: m.Name() + "_yasm"},
681 &YasmAttributes{
682 Srcs: ca.asmSrcs,
683 Flags: ca.asFlags,
684 Include_dirs: *includes,
685 })
686
687 // We only want to add a dependency on the _yasm target if there are asm
688 // sources in the current configuration. If there are unconfigured asm
689 // sources, always add the dependency. Otherwise, add the dependency only
690 // on the configuration axes and values that had asm sources.
691 if len(ca.asmSrcs.Value.Includes) > 0 {
692 return bazel.MakeLabelAttribute(":" + m.Name() + "_yasm")
693 }
694
695 ret := &bazel.LabelAttribute{}
696 for _, axis := range ca.asmSrcs.SortedConfigurationAxes() {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800697 for cfg := range ca.asmSrcs.ConfigurableValues[axis] {
698 ret.SetSelectValue(axis, cfg, bazel.Label{Label: ":" + m.Name() + "_yasm"})
Cole Faust7071a052022-07-29 15:58:33 -0700699 }
700 }
701 return ret
702}
703
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000704// bp2BuildParseBaseProps returns all compiler, linker, library attributes of a cc module..
Liz Kammer12615db2021-09-28 09:19:17 -0400705func bp2BuildParseBaseProps(ctx android.Bp2buildMutatorContext, module *Module) baseAttributes {
Liz Kammere6583482021-10-19 13:56:10 -0400706 archVariantCompilerProps := module.GetArchVariantProperties(ctx, &BaseCompilerProperties{})
707 archVariantLinkerProps := module.GetArchVariantProperties(ctx, &BaseLinkerProperties{})
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000708 archVariantLibraryProperties := module.GetArchVariantProperties(ctx, &LibraryProperties{})
Liz Kammere6583482021-10-19 13:56:10 -0400709
710 var implementationHdrs bazel.LabelListAttribute
711
712 axisToConfigs := map[bazel.ConfigurationAxis]map[string]bool{}
713 allAxesAndConfigs := func(cp android.ConfigurationAxisToArchVariantProperties) {
714 for axis, configMap := range cp {
715 if _, ok := axisToConfigs[axis]; !ok {
716 axisToConfigs[axis] = map[string]bool{}
717 }
Sasha Smundak39a301c2022-12-29 17:11:49 -0800718 for cfg := range configMap {
719 axisToConfigs[axis][cfg] = true
Chris Parsonsa967f252021-09-23 16:34:35 -0400720 }
721 }
722 }
Liz Kammere6583482021-10-19 13:56:10 -0400723 allAxesAndConfigs(archVariantCompilerProps)
724 allAxesAndConfigs(archVariantLinkerProps)
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000725 allAxesAndConfigs(archVariantLibraryProperties)
Chris Parsonsa967f252021-09-23 16:34:35 -0400726
Liz Kammere6583482021-10-19 13:56:10 -0400727 compilerAttrs := compilerAttributes{}
728 linkerAttrs := linkerAttributes{}
729
Chris Parsons7b3289b2023-01-26 17:30:44 -0500730 // Iterate through these axes in a deterministic order. This is required
731 // because processing certain dependencies may result in concatenating
732 // elements along other axes. (For example, processing NoConfig may result
733 // in elements being added to InApex). This is thus the only way to ensure
734 // that the order of entries in each list is in a predictable order.
735 for _, axis := range bazel.SortedConfigurationAxes(axisToConfigs) {
736 configs := axisToConfigs[axis]
Sasha Smundak39a301c2022-12-29 17:11:49 -0800737 for cfg := range configs {
Liz Kammere6583482021-10-19 13:56:10 -0400738 var allHdrs []string
Sasha Smundak39a301c2022-12-29 17:11:49 -0800739 if baseCompilerProps, ok := archVariantCompilerProps[axis][cfg].(*BaseCompilerProperties); ok {
Liz Kammere6583482021-10-19 13:56:10 -0400740 allHdrs = baseCompilerProps.Generated_headers
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000741 if baseCompilerProps.Lex != nil {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800742 compilerAttrs.lexopts.SetSelectValue(axis, cfg, baseCompilerProps.Lex.Flags)
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000743 }
Sasha Smundak39a301c2022-12-29 17:11:49 -0800744 (&compilerAttrs).bp2buildForAxisAndConfig(ctx, axis, cfg, baseCompilerProps)
Liz Kammere6583482021-10-19 13:56:10 -0400745 }
746
747 var exportHdrs []string
748
Sasha Smundak39a301c2022-12-29 17:11:49 -0800749 if baseLinkerProps, ok := archVariantLinkerProps[axis][cfg].(*BaseLinkerProperties); ok {
Liz Kammere6583482021-10-19 13:56:10 -0400750 exportHdrs = baseLinkerProps.Export_generated_headers
751
Liz Kammer48cdbeb2023-03-17 10:17:50 -0400752 (&linkerAttrs).bp2buildForAxisAndConfig(ctx, module, axis, cfg, baseLinkerProps)
Liz Kammere6583482021-10-19 13:56:10 -0400753 }
754 headers := maybePartitionExportedAndImplementationsDeps(ctx, !module.Binary(), allHdrs, exportHdrs, android.BazelLabelForModuleDeps)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800755 implementationHdrs.SetSelectValue(axis, cfg, headers.implementation)
756 compilerAttrs.hdrs.SetSelectValue(axis, cfg, headers.export)
Liz Kammer1263d9b2021-12-10 14:28:20 -0500757
758 exportIncludes, exportAbsoluteIncludes := includesFromLabelList(headers.export)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800759 compilerAttrs.includes.Includes.SetSelectValue(axis, cfg, exportIncludes)
760 compilerAttrs.includes.AbsoluteIncludes.SetSelectValue(axis, cfg, exportAbsoluteIncludes)
Liz Kammer1263d9b2021-12-10 14:28:20 -0500761
762 includes, absoluteIncludes := includesFromLabelList(headers.implementation)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800763 currAbsoluteIncludes := compilerAttrs.absoluteIncludes.SelectValue(axis, cfg)
Liz Kammer1263d9b2021-12-10 14:28:20 -0500764 currAbsoluteIncludes = android.FirstUniqueStrings(append(currAbsoluteIncludes, absoluteIncludes...))
Vinh Tran9f6796a2022-08-16 13:10:31 -0400765
Sasha Smundak39a301c2022-12-29 17:11:49 -0800766 compilerAttrs.absoluteIncludes.SetSelectValue(axis, cfg, currAbsoluteIncludes)
Vinh Tran9f6796a2022-08-16 13:10:31 -0400767
Sasha Smundak39a301c2022-12-29 17:11:49 -0800768 currIncludes := compilerAttrs.localIncludes.SelectValue(axis, cfg)
Liz Kammer1263d9b2021-12-10 14:28:20 -0500769 currIncludes = android.FirstUniqueStrings(append(currIncludes, includes...))
Vinh Tran9f6796a2022-08-16 13:10:31 -0400770
Sasha Smundak39a301c2022-12-29 17:11:49 -0800771 compilerAttrs.localIncludes.SetSelectValue(axis, cfg, currIncludes)
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000772
Sasha Smundak39a301c2022-12-29 17:11:49 -0800773 if libraryProps, ok := archVariantLibraryProperties[axis][cfg].(*LibraryProperties); ok {
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000774 if axis == bazel.NoConfigAxis {
Sam Delmerico75dbca22023-04-20 13:13:25 +0000775 if libraryProps.Stubs.Symbol_file != nil {
776 compilerAttrs.stubsSymbolFile = libraryProps.Stubs.Symbol_file
777 versions := android.CopyOf(libraryProps.Stubs.Versions)
778 normalizeVersions(ctx, versions)
779 versions = addCurrentVersionIfNotPresent(versions)
780 compilerAttrs.stubsVersions.SetSelectValue(axis, cfg, versions)
781 }
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000782 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500783 if suffix := libraryProps.Suffix; suffix != nil {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800784 compilerAttrs.suffix.SetSelectValue(axis, cfg, suffix)
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500785 }
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000786 }
Liz Kammere6583482021-10-19 13:56:10 -0400787 }
788 }
Vinh Tran9f6796a2022-08-16 13:10:31 -0400789
Liz Kammere6583482021-10-19 13:56:10 -0400790 compilerAttrs.convertStlProps(ctx, module)
791 (&linkerAttrs).convertStripProps(ctx, module)
792
Yu Liuf01a0f02022-12-07 15:45:30 -0800793 var nativeCoverage *bool
Yu Liu8d82ac52022-05-17 15:13:28 -0700794 if module.coverage != nil && module.coverage.Properties.Native_coverage != nil &&
795 !Bool(module.coverage.Properties.Native_coverage) {
Yu Liuf01a0f02022-12-07 15:45:30 -0800796 nativeCoverage = BoolPtr(false)
Yu Liu8d82ac52022-05-17 15:13:28 -0700797 }
798
Cole Faust912bc882023-03-08 12:29:50 -0800799 productVariableProps := android.ProductVariableProperties(ctx, ctx.Module())
Liz Kammere6583482021-10-19 13:56:10 -0400800
801 (&compilerAttrs).convertProductVariables(ctx, productVariableProps)
802 (&linkerAttrs).convertProductVariables(ctx, productVariableProps)
803
804 (&compilerAttrs).finalize(ctx, implementationHdrs)
Liz Kammer54309532021-12-14 12:21:22 -0500805 (&linkerAttrs).finalize(ctx)
Liz Kammere6583482021-10-19 13:56:10 -0400806
Cole Faust7071a052022-07-29 15:58:33 -0700807 (&compilerAttrs.srcs).Add(bp2BuildYasm(ctx, module, compilerAttrs))
808
Liz Kammer12615db2021-09-28 09:19:17 -0400809 protoDep := bp2buildProto(ctx, module, compilerAttrs.protoSrcs)
810
811 // bp2buildProto will only set wholeStaticLib or implementationWholeStaticLib, but we don't know
812 // which. This will add the newly generated proto library to the appropriate attribute and nothing
813 // to the other
814 (&linkerAttrs).wholeArchiveDeps.Add(protoDep.wholeStaticLib)
815 (&linkerAttrs).implementationWholeArchiveDeps.Add(protoDep.implementationWholeStaticLib)
Vinh Tranfde57eb2022-08-29 17:46:58 -0400816
Vinh Tran395a1e92022-09-16 18:27:29 -0400817 aidlDep := bp2buildCcAidlLibrary(ctx, module, compilerAttrs.aidlSrcs, linkerAttrs)
Vinh Tranfde57eb2022-08-29 17:46:58 -0400818 if aidlDep != nil {
819 if lib, ok := module.linker.(*libraryDecorator); ok {
820 if proptools.Bool(lib.Properties.Aidl.Export_aidl_headers) {
821 (&linkerAttrs).wholeArchiveDeps.Add(aidlDep)
822 } else {
823 (&linkerAttrs).implementationWholeArchiveDeps.Add(aidlDep)
824 }
825 }
826 }
Liz Kammer12615db2021-09-28 09:19:17 -0400827
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000828 convertedLSrcs := bp2BuildLex(ctx, module.Name(), compilerAttrs)
829 (&compilerAttrs).srcs.Add(&convertedLSrcs.srcName)
830 (&compilerAttrs).cSrcs.Add(&convertedLSrcs.cSrcName)
831
Vinh Tran99270ea2022-11-28 11:15:23 -0500832 if module.afdo != nil && module.afdo.Properties.Afdo {
833 fdoProfileDep := bp2buildFdoProfile(ctx, module)
834 if fdoProfileDep != nil {
835 (&compilerAttrs).fdoProfile.SetValue(*fdoProfileDep)
836 }
837 }
838
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000839 if !compilerAttrs.syspropSrcs.IsEmpty() {
840 (&linkerAttrs).wholeArchiveDeps.Add(bp2buildCcSysprop(ctx, module.Name(), module.Properties.Min_sdk_version, compilerAttrs.syspropSrcs))
841 }
842
Zi Wang9f609db2023-01-04 11:06:54 -0800843 linkerAttrs.wholeArchiveDeps.Prepend = true
844 linkerAttrs.deps.Prepend = true
845 compilerAttrs.localIncludes.Prepend = true
846 compilerAttrs.absoluteIncludes.Prepend = true
847 compilerAttrs.hdrs.Prepend = true
848
Trevor Radcliffedb7e0262022-10-28 16:48:18 +0000849 features := compilerAttrs.features.Clone().Append(linkerAttrs.features).Append(bp2buildSanitizerFeatures(ctx, module))
Trevor Radcliffe56b1a2b2023-02-06 21:58:30 +0000850 features = features.Append(bp2buildLtoFeatures(ctx, module))
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000851 features = features.Append(convertHiddenVisibilityToFeatureBase(ctx, module))
Cole Faust5fa4e962022-08-22 14:31:04 -0700852 features.DeduplicateAxesFromBase()
853
Trevor Radcliffe0d1b4022022-12-12 22:26:34 +0000854 addMuslSystemDynamicDeps(ctx, linkerAttrs)
855
Liz Kammere6583482021-10-19 13:56:10 -0400856 return baseAttributes{
857 compilerAttrs,
858 linkerAttrs,
Cole Faust5fa4e962022-08-22 14:31:04 -0700859 *features,
Liz Kammer12615db2021-09-28 09:19:17 -0400860 protoDep.protoDep,
Vinh Tran9f6796a2022-08-16 13:10:31 -0400861 aidlDep,
Yu Liuf01a0f02022-12-07 15:45:30 -0800862 nativeCoverage,
Jingwen Chen107c0de2021-04-09 10:43:12 +0000863 }
864}
865
Trevor Radcliffe0d1b4022022-12-12 22:26:34 +0000866// As a workaround for b/261657184, we are manually adding the default value
867// of system_dynamic_deps for the linux_musl os.
868// TODO: Solve this properly
869func addMuslSystemDynamicDeps(ctx android.Bp2buildMutatorContext, attrs linkerAttributes) {
870 systemDynamicDeps := attrs.systemDynamicDeps.SelectValue(bazel.OsConfigurationAxis, "linux_musl")
871 if attrs.systemDynamicDeps.HasAxisSpecificValues(bazel.OsConfigurationAxis) && systemDynamicDeps.IsNil() {
872 attrs.systemDynamicDeps.SetSelectValue(bazel.OsConfigurationAxis, "linux_musl", android.BazelLabelForModuleDeps(ctx, config.MuslDefaultSharedLibraries))
873 }
874}
875
Vinh Tran99270ea2022-11-28 11:15:23 -0500876type fdoProfileAttributes struct {
877 Absolute_path_profile string
878}
879
880func bp2buildFdoProfile(
881 ctx android.Bp2buildMutatorContext,
882 m *Module,
883) *bazel.Label {
884 for _, project := range globalAfdoProfileProjects {
Vinh Tranbc9c8b42022-12-09 12:03:52 -0500885 // Ensure handcrafted BUILD file exists in the project
886 BUILDPath := android.ExistentPathForSource(ctx, project, "BUILD")
887 if BUILDPath.Valid() {
888 // We handcraft a BUILD file with fdo_profile targets that use the existing profiles in the project
889 // This implementation is assuming that every afdo profile in globalAfdoProfileProjects already has
890 // an associated fdo_profile target declared in the same package.
891 // TODO(b/260714900): Handle arch-specific afdo profiles (e.g. `<module-name>-arm<64>.afdo`)
892 path := android.ExistentPathForSource(ctx, project, m.Name()+".afdo")
893 if path.Valid() {
894 // FIXME: Some profiles only exist internally and are not released to AOSP.
895 // When generated BUILD files are checked in, we'll run into merge conflict.
896 // The cc_library_shared target in AOSP won't have reference to an fdo_profile target because
897 // the profile doesn't exist. Internally, the same cc_library_shared target will
898 // have reference to the fdo_profile.
899 // For more context, see b/258682955#comment2
900 fdoProfileLabel := "//" + strings.TrimSuffix(project, "/") + ":" + m.Name()
901 return &bazel.Label{
902 Label: fdoProfileLabel,
903 }
Vinh Tran99270ea2022-11-28 11:15:23 -0500904 }
905 }
906 }
907
908 return nil
909}
910
Vinh Tran9f6796a2022-08-16 13:10:31 -0400911func bp2buildCcAidlLibrary(
912 ctx android.Bp2buildMutatorContext,
913 m *Module,
Vinh Trana3b8b782022-09-14 11:40:24 -0400914 aidlLabelList bazel.LabelListAttribute,
Vinh Tran395a1e92022-09-16 18:27:29 -0400915 linkerAttrs linkerAttributes,
Vinh Tran9f6796a2022-08-16 13:10:31 -0400916) *bazel.LabelAttribute {
Vinh Trana3b8b782022-09-14 11:40:24 -0400917 if !aidlLabelList.IsEmpty() {
918 aidlLibs, aidlSrcs := aidlLabelList.Partition(func(src bazel.Label) bool {
919 if fg, ok := android.ToFileGroupAsLibrary(ctx, src.OriginalModuleName); ok &&
920 fg.ShouldConvertToAidlLibrary(ctx) {
921 return true
922 }
923 return false
924 })
Vinh Tran9f6796a2022-08-16 13:10:31 -0400925
Liz Kammer2b3f56e2023-03-23 11:51:49 -0400926 apexAvailableTags := android.ApexAvailableTags(ctx.Module())
927 sdkAttrs := bp2BuildParseSdkAttributes(m)
928
Vinh Trana3b8b782022-09-14 11:40:24 -0400929 if !aidlSrcs.IsEmpty() {
930 aidlLibName := m.Name() + "_aidl_library"
931 ctx.CreateBazelTargetModule(
932 bazel.BazelTargetModuleProperties{
933 Rule_class: "aidl_library",
Sam Delmericoe55bf082023-03-31 09:47:28 -0400934 Bzl_load_location: "//build/bazel/rules/aidl:aidl_library.bzl",
Vinh Trana3b8b782022-09-14 11:40:24 -0400935 },
936 android.CommonAttributes{Name: aidlLibName},
937 &aidlLibraryAttributes{
938 Srcs: aidlSrcs,
Liz Kammer2b3f56e2023-03-23 11:51:49 -0400939 Tags: apexAvailableTags,
Vinh Trana3b8b782022-09-14 11:40:24 -0400940 },
941 )
942 aidlLibs.Add(&bazel.LabelAttribute{Value: &bazel.Label{Label: ":" + aidlLibName}})
943 }
Vinh Tran9f6796a2022-08-16 13:10:31 -0400944
Vinh Trana3b8b782022-09-14 11:40:24 -0400945 if !aidlLibs.IsEmpty() {
946 ccAidlLibrarylabel := m.Name() + "_cc_aidl_library"
Sam Delmerico512437b2023-03-17 11:34:15 -0400947 // Since parent cc_library already has these dependencies, we can add them as implementation
948 // deps so that they don't re-export
949 implementationDeps := linkerAttrs.deps.Clone()
950 implementationDeps.Append(linkerAttrs.implementationDeps)
951 implementationDynamicDeps := linkerAttrs.dynamicDeps.Clone()
952 implementationDynamicDeps.Append(linkerAttrs.implementationDynamicDeps)
Vinh Tran395a1e92022-09-16 18:27:29 -0400953
Vinh Trana3b8b782022-09-14 11:40:24 -0400954 ctx.CreateBazelTargetModule(
955 bazel.BazelTargetModuleProperties{
956 Rule_class: "cc_aidl_library",
957 Bzl_load_location: "//build/bazel/rules/cc:cc_aidl_library.bzl",
958 },
959 android.CommonAttributes{Name: ccAidlLibrarylabel},
960 &ccAidlLibraryAttributes{
Vinh Tran395a1e92022-09-16 18:27:29 -0400961 Deps: aidlLibs,
Sam Delmerico512437b2023-03-17 11:34:15 -0400962 Implementation_deps: *implementationDeps,
963 Implementation_dynamic_deps: *implementationDynamicDeps,
Liz Kammer2b3f56e2023-03-23 11:51:49 -0400964 Tags: apexAvailableTags,
965 sdkAttributes: sdkAttrs,
Vinh Trana3b8b782022-09-14 11:40:24 -0400966 },
967 )
968 label := &bazel.LabelAttribute{
969 Value: &bazel.Label{
970 Label: ":" + ccAidlLibrarylabel,
971 },
972 }
973 return label
974 }
Vinh Tran9f6796a2022-08-16 13:10:31 -0400975 }
976
Vinh Trana3b8b782022-09-14 11:40:24 -0400977 return nil
Vinh Tran9f6796a2022-08-16 13:10:31 -0400978}
979
Yu Liufc603162022-03-01 15:44:08 -0800980func bp2BuildParseSdkAttributes(module *Module) sdkAttributes {
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000981 return sdkAttributes{
982 Sdk_version: module.Properties.Sdk_version,
Yu Liufc603162022-03-01 15:44:08 -0800983 Min_sdk_version: module.Properties.Min_sdk_version,
984 }
985}
986
987type sdkAttributes struct {
988 Sdk_version *string
989 Min_sdk_version *string
990}
991
Jingwen Chen107c0de2021-04-09 10:43:12 +0000992// Convenience struct to hold all attributes parsed from linker properties.
993type linkerAttributes struct {
Liz Kammer54309532021-12-14 12:21:22 -0500994 deps bazel.LabelListAttribute
995 implementationDeps bazel.LabelListAttribute
996 dynamicDeps bazel.LabelListAttribute
997 implementationDynamicDeps bazel.LabelListAttribute
Cole Faust6b29f592022-08-09 09:50:56 -0700998 runtimeDeps bazel.LabelListAttribute
Liz Kammer54309532021-12-14 12:21:22 -0500999 wholeArchiveDeps bazel.LabelListAttribute
1000 implementationWholeArchiveDeps bazel.LabelListAttribute
1001 systemDynamicDeps bazel.LabelListAttribute
1002 usedSystemDynamicDepAsDynamicDep map[string]bool
Liz Kammer7a210ac2021-09-22 15:52:58 -04001003
Rupert Shuttleworth484aa252021-12-10 07:22:53 -05001004 useVersionLib bazel.BoolAttribute
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001005 linkopts bazel.StringListAttribute
Liz Kammerd2871182021-10-04 13:54:37 -04001006 additionalLinkerInputs bazel.LabelListAttribute
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001007 stripKeepSymbols bazel.BoolAttribute
1008 stripKeepSymbolsAndDebugFrame bazel.BoolAttribute
1009 stripKeepSymbolsList bazel.StringListAttribute
1010 stripAll bazel.BoolAttribute
1011 stripNone bazel.BoolAttribute
Liz Kammer0eae52e2021-10-06 10:32:26 -04001012 features bazel.StringListAttribute
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001013}
1014
Liz Kammer54309532021-12-14 12:21:22 -05001015var (
1016 soongSystemSharedLibs = []string{"libc", "libm", "libdl"}
Liz Kammerbaced712022-09-16 09:01:29 -04001017 versionLib = "libbuildversion"
Liz Kammer54309532021-12-14 12:21:22 -05001018)
1019
Vinh Tran85fb07c2022-09-16 16:17:48 -04001020// resolveTargetApex re-adds the shared and static libs in target.apex.exclude_shared|static_libs props to non-apex variant
1021// since all libs are already excluded by default
Liz Kammer748d7072023-01-25 12:07:43 -05001022func (la *linkerAttributes) resolveTargetApexProp(ctx android.BazelConversionPathContext, props *BaseLinkerProperties) {
1023 excludeSharedLibs := bazelLabelForSharedDeps(ctx, props.Target.Apex.Exclude_shared_libs)
1024 sharedExcludes := bazel.LabelList{Excludes: excludeSharedLibs.Includes}
1025 sharedExcludesLabelList := bazel.LabelListAttribute{}
1026 sharedExcludesLabelList.SetSelectValue(bazel.InApexAxis, bazel.InApex, sharedExcludes)
Vinh Tran85fb07c2022-09-16 16:17:48 -04001027
Liz Kammer748d7072023-01-25 12:07:43 -05001028 la.dynamicDeps.Append(sharedExcludesLabelList)
1029 la.implementationDynamicDeps.Append(sharedExcludesLabelList)
1030
1031 excludeStaticLibs := bazelLabelForStaticDeps(ctx, props.Target.Apex.Exclude_static_libs)
1032 staticExcludes := bazel.LabelList{Excludes: excludeStaticLibs.Includes}
1033 staticExcludesLabelList := bazel.LabelListAttribute{}
1034 staticExcludesLabelList.SetSelectValue(bazel.InApexAxis, bazel.InApex, staticExcludes)
1035
1036 la.deps.Append(staticExcludesLabelList)
1037 la.implementationDeps.Append(staticExcludesLabelList)
Vinh Tran85fb07c2022-09-16 16:17:48 -04001038}
1039
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001040func (la *linkerAttributes) bp2buildForAxisAndConfig(ctx android.BazelConversionPathContext, module *Module, axis bazel.ConfigurationAxis, config string, props *BaseLinkerProperties) {
1041 isBinary := module.Binary()
Liz Kammere6583482021-10-19 13:56:10 -04001042 // Use a single variable to capture usage of nocrt in arch variants, so there's only 1 error message for this module
1043 var axisFeatures []string
Liz Kammer7a210ac2021-09-22 15:52:58 -04001044
Liz Kammercc2c1ef2022-03-21 09:03:29 -04001045 wholeStaticLibs := android.FirstUniqueStrings(props.Whole_static_libs)
Liz Kammerbaced712022-09-16 09:01:29 -04001046 staticLibs := android.FirstUniqueStrings(android.RemoveListFromList(props.Static_libs, wholeStaticLibs))
1047 if axis == bazel.NoConfigAxis {
1048 la.useVersionLib.SetSelectValue(axis, config, props.Use_version_lib)
1049 if proptools.Bool(props.Use_version_lib) {
1050 versionLibAlreadyInDeps := android.InList(versionLib, wholeStaticLibs)
1051 // remove from static libs so there is no duplicate dependency
1052 _, staticLibs = android.RemoveFromList(versionLib, staticLibs)
1053 // only add the dep if it is not in progress
1054 if !versionLibAlreadyInDeps {
1055 if isBinary {
1056 wholeStaticLibs = append(wholeStaticLibs, versionLib)
1057 } else {
1058 la.implementationWholeArchiveDeps.SetSelectValue(axis, config, bazelLabelForWholeDepsExcludes(ctx, []string{versionLib}, props.Exclude_static_libs))
1059 }
1060 }
1061 }
1062 }
1063
Liz Kammere6583482021-10-19 13:56:10 -04001064 // Excludes to parallel Soong:
1065 // https://cs.android.com/android/platform/superproject/+/master:build/soong/cc/linker.go;l=247-249;drc=088b53577dde6e40085ffd737a1ae96ad82fc4b0
Liz Kammerbaced712022-09-16 09:01:29 -04001066 la.wholeArchiveDeps.SetSelectValue(axis, config, bazelLabelForWholeDepsExcludes(ctx, wholeStaticLibs, props.Exclude_static_libs))
Liz Kammercc2c1ef2022-03-21 09:03:29 -04001067
Vinh Tran85fb07c2022-09-16 16:17:48 -04001068 staticDeps := maybePartitionExportedAndImplementationsDepsExcludes(
1069 ctx,
1070 !isBinary,
1071 staticLibs,
Liz Kammer748d7072023-01-25 12:07:43 -05001072 props.Exclude_static_libs,
Vinh Tran85fb07c2022-09-16 16:17:48 -04001073 props.Export_static_lib_headers,
1074 bazelLabelForStaticDepsExcludes,
1075 )
Liz Kammer7a210ac2021-09-22 15:52:58 -04001076
Liz Kammere6583482021-10-19 13:56:10 -04001077 headerLibs := android.FirstUniqueStrings(props.Header_libs)
1078 hDeps := maybePartitionExportedAndImplementationsDeps(ctx, !isBinary, headerLibs, props.Export_header_lib_headers, bazelLabelForHeaderDeps)
Jingwen Chen63930982021-03-24 10:04:33 -04001079
Liz Kammere6583482021-10-19 13:56:10 -04001080 (&hDeps.export).Append(staticDeps.export)
1081 la.deps.SetSelectValue(axis, config, hDeps.export)
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001082
Liz Kammere6583482021-10-19 13:56:10 -04001083 (&hDeps.implementation).Append(staticDeps.implementation)
1084 la.implementationDeps.SetSelectValue(axis, config, hDeps.implementation)
Liz Kammer0eae52e2021-10-06 10:32:26 -04001085
Liz Kammere6583482021-10-19 13:56:10 -04001086 systemSharedLibs := props.System_shared_libs
1087 // systemSharedLibs distinguishes between nil/empty list behavior:
1088 // nil -> use default values
1089 // empty list -> no values specified
1090 if len(systemSharedLibs) > 0 {
1091 systemSharedLibs = android.FirstUniqueStrings(systemSharedLibs)
1092 }
1093 la.systemDynamicDeps.SetSelectValue(axis, config, bazelLabelForSharedDeps(ctx, systemSharedLibs))
1094
1095 sharedLibs := android.FirstUniqueStrings(props.Shared_libs)
Liz Kammer54309532021-12-14 12:21:22 -05001096 excludeSharedLibs := props.Exclude_shared_libs
1097 usedSystem := android.FilterListPred(sharedLibs, func(s string) bool {
1098 return android.InList(s, soongSystemSharedLibs) && !android.InList(s, excludeSharedLibs)
1099 })
1100 for _, el := range usedSystem {
1101 if la.usedSystemDynamicDepAsDynamicDep == nil {
1102 la.usedSystemDynamicDepAsDynamicDep = map[string]bool{}
1103 }
1104 la.usedSystemDynamicDepAsDynamicDep[el] = true
1105 }
1106
Vinh Tran85fb07c2022-09-16 16:17:48 -04001107 sharedDeps := maybePartitionExportedAndImplementationsDepsExcludes(
1108 ctx,
1109 !isBinary,
1110 sharedLibs,
Liz Kammer748d7072023-01-25 12:07:43 -05001111 props.Exclude_shared_libs,
Vinh Tran85fb07c2022-09-16 16:17:48 -04001112 props.Export_shared_lib_headers,
1113 bazelLabelForSharedDepsExcludes,
1114 )
Liz Kammere6583482021-10-19 13:56:10 -04001115 la.dynamicDeps.SetSelectValue(axis, config, sharedDeps.export)
1116 la.implementationDynamicDeps.SetSelectValue(axis, config, sharedDeps.implementation)
Liz Kammer748d7072023-01-25 12:07:43 -05001117 la.resolveTargetApexProp(ctx, props)
Vinh Tran85fb07c2022-09-16 16:17:48 -04001118
Wei Li81852ca2022-07-27 00:22:06 -07001119 if axis == bazel.NoConfigAxis || (axis == bazel.OsConfigurationAxis && config == bazel.OsAndroid) {
Yu Liu10174ff2023-02-21 12:05:26 -08001120 // If a dependency in la.implementationDynamicDeps or la.dynamicDeps has stubs, its
1121 // stub variant should be used when the dependency is linked in a APEX. The
1122 // dependencies in NoConfigAxis and OsConfigurationAxis/OsAndroid are grouped by
1123 // having stubs or not, so Bazel select() statement can be used to choose
1124 // source/stub variants of them.
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001125 apexAvailable := module.ApexAvailable()
1126 setStubsForDynamicDeps(ctx, axis, config, apexAvailable, sharedDeps.export, &la.dynamicDeps, 0)
1127 setStubsForDynamicDeps(ctx, axis, config, apexAvailable, sharedDeps.implementation, &la.implementationDynamicDeps, 1)
Wei Li81852ca2022-07-27 00:22:06 -07001128 }
Liz Kammere6583482021-10-19 13:56:10 -04001129
1130 if !BoolDefault(props.Pack_relocations, packRelocationsDefault) {
1131 axisFeatures = append(axisFeatures, "disable_pack_relocations")
1132 }
1133
1134 if Bool(props.Allow_undefined_symbols) {
1135 axisFeatures = append(axisFeatures, "-no_undefined_symbols")
1136 }
1137
1138 var linkerFlags []string
1139 if len(props.Ldflags) > 0 {
Liz Kammerf38a8372022-02-04 15:39:00 -05001140 linkerFlags = append(linkerFlags, proptools.NinjaEscapeList(props.Ldflags)...)
Liz Kammere6583482021-10-19 13:56:10 -04001141 // binaries remove static flag if -shared is in the linker flags
1142 if isBinary && android.InList("-shared", linkerFlags) {
1143 axisFeatures = append(axisFeatures, "-static_flag")
1144 }
1145 }
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +00001146
Alex Márquez Pérez Muñíz Díaz Puras Thaureaux01ec55e2023-01-30 22:53:04 +00001147 if !props.libCrt() {
1148 axisFeatures = append(axisFeatures, "-use_libcrt")
1149 }
1150 if !props.crt() {
1151 axisFeatures = append(axisFeatures, "-link_crt")
1152 }
1153
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +00001154 // This must happen before the addition of flags for Version Script and
1155 // Dynamic List, as these flags must be split on spaces and those must not
1156 linkerFlags = parseCommandLineFlags(linkerFlags, filterOutClangUnknownCflags)
1157
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001158 additionalLinkerInputs := bazel.LabelList{}
Liz Kammere6583482021-10-19 13:56:10 -04001159 if props.Version_script != nil {
1160 label := android.BazelLabelForModuleSrcSingle(ctx, *props.Version_script)
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001161 additionalLinkerInputs.Add(&label)
Liz Kammere6583482021-10-19 13:56:10 -04001162 linkerFlags = append(linkerFlags, fmt.Sprintf("-Wl,--version-script,$(location %s)", label.Label))
1163 }
Alix773adaa2022-04-27 17:49:34 +00001164
1165 if props.Dynamic_list != nil {
1166 label := android.BazelLabelForModuleSrcSingle(ctx, *props.Dynamic_list)
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001167 additionalLinkerInputs.Add(&label)
Alix773adaa2022-04-27 17:49:34 +00001168 linkerFlags = append(linkerFlags, fmt.Sprintf("-Wl,--dynamic-list,$(location %s)", label.Label))
1169 }
1170
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001171 la.additionalLinkerInputs.SetSelectValue(axis, config, additionalLinkerInputs)
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +00001172 la.linkopts.SetSelectValue(axis, config, linkerFlags)
Liz Kammere6583482021-10-19 13:56:10 -04001173
1174 if axisFeatures != nil {
1175 la.features.SetSelectValue(axis, config, axisFeatures)
1176 }
Cole Faust6b29f592022-08-09 09:50:56 -07001177
1178 runtimeDeps := android.BazelLabelForModuleDepsExcludes(ctx, props.Runtime_libs, props.Exclude_runtime_libs)
1179 if !runtimeDeps.IsEmpty() {
1180 la.runtimeDeps.SetSelectValue(axis, config, runtimeDeps)
1181 }
Liz Kammere6583482021-10-19 13:56:10 -04001182}
1183
Spandan Das2518c022023-03-17 03:02:32 +00001184var (
1185 apiSurfaceModuleLibCurrentPackage = "@api_surfaces//" + android.ModuleLibApi.String() + "/current:"
1186)
1187
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001188func availableToSameApexes(a, b []string) bool {
1189 if len(a) == 0 && len(b) == 0 {
1190 return true
1191 }
1192 differ, _, _ := android.ListSetDifference(a, b)
1193 return !differ
1194}
1195
Yu Liu10174ff2023-02-21 12:05:26 -08001196func setStubsForDynamicDeps(ctx android.BazelConversionPathContext, axis bazel.ConfigurationAxis,
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001197 config string, apexAvailable []string, dynamicLibs bazel.LabelList, dynamicDeps *bazel.LabelListAttribute, ind int) {
1198
Yu Liu10174ff2023-02-21 12:05:26 -08001199 depsWithStubs := []bazel.Label{}
1200 for _, l := range dynamicLibs.Includes {
1201 dep, _ := ctx.ModuleFromName(l.OriginalModuleName)
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001202 if d, ok := dep.(*Module); ok && d.HasStubsVariants() {
1203 depApexAvailable := d.ApexAvailable()
1204 if !availableToSameApexes(apexAvailable, depApexAvailable) {
1205 depsWithStubs = append(depsWithStubs, l)
1206 }
Yu Liu10174ff2023-02-21 12:05:26 -08001207 }
1208 }
1209 if len(depsWithStubs) > 0 {
1210 implDynamicDeps := bazel.SubtractBazelLabelList(dynamicLibs, bazel.MakeLabelList(depsWithStubs))
1211 dynamicDeps.SetSelectValue(axis, config, implDynamicDeps)
1212
1213 stubLibLabels := []bazel.Label{}
1214 for _, l := range depsWithStubs {
Spandan Das2518c022023-03-17 03:02:32 +00001215 stubLabelInApiSurfaces := bazel.Label{
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001216 Label: apiSurfaceModuleLibCurrentPackage + strings.TrimPrefix(l.OriginalModuleName, ":"),
Spandan Das2518c022023-03-17 03:02:32 +00001217 }
1218 stubLibLabels = append(stubLibLabels, stubLabelInApiSurfaces)
Yu Liu10174ff2023-02-21 12:05:26 -08001219 }
1220 inApexSelectValue := dynamicDeps.SelectValue(bazel.OsAndInApexAxis, bazel.AndroidAndInApex)
1221 nonApexSelectValue := dynamicDeps.SelectValue(bazel.OsAndInApexAxis, bazel.AndroidAndNonApex)
1222 defaultSelectValue := dynamicDeps.SelectValue(bazel.OsAndInApexAxis, bazel.ConditionsDefaultConfigKey)
1223 if axis == bazel.NoConfigAxis {
1224 (&inApexSelectValue).Append(bazel.MakeLabelList(stubLibLabels))
1225 (&nonApexSelectValue).Append(bazel.MakeLabelList(depsWithStubs))
1226 (&defaultSelectValue).Append(bazel.MakeLabelList(depsWithStubs))
1227 dynamicDeps.SetSelectValue(bazel.OsAndInApexAxis, bazel.AndroidAndInApex, bazel.FirstUniqueBazelLabelList(inApexSelectValue))
1228 dynamicDeps.SetSelectValue(bazel.OsAndInApexAxis, bazel.AndroidAndNonApex, bazel.FirstUniqueBazelLabelList(nonApexSelectValue))
1229 dynamicDeps.SetSelectValue(bazel.OsAndInApexAxis, bazel.ConditionsDefaultConfigKey, bazel.FirstUniqueBazelLabelList(defaultSelectValue))
1230 } else if config == bazel.OsAndroid {
1231 (&inApexSelectValue).Append(bazel.MakeLabelList(stubLibLabels))
1232 (&nonApexSelectValue).Append(bazel.MakeLabelList(depsWithStubs))
1233 dynamicDeps.SetSelectValue(bazel.OsAndInApexAxis, bazel.AndroidAndInApex, bazel.FirstUniqueBazelLabelList(inApexSelectValue))
1234 dynamicDeps.SetSelectValue(bazel.OsAndInApexAxis, bazel.AndroidAndNonApex, bazel.FirstUniqueBazelLabelList(nonApexSelectValue))
1235 }
1236 }
1237}
1238
Jingwen Chen55bc8202021-11-02 06:40:51 +00001239func (la *linkerAttributes) convertStripProps(ctx android.BazelConversionPathContext, module *Module) {
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001240 bp2BuildPropParseHelper(ctx, module, &StripProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1241 if stripProperties, ok := props.(*StripProperties); ok {
1242 la.stripKeepSymbols.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols)
1243 la.stripKeepSymbolsList.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols_list)
1244 la.stripKeepSymbolsAndDebugFrame.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols_and_debug_frame)
1245 la.stripAll.SetSelectValue(axis, config, stripProperties.Strip.All)
1246 la.stripNone.SetSelectValue(axis, config, stripProperties.Strip.None)
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001247 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001248 })
Liz Kammere6583482021-10-19 13:56:10 -04001249}
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001250
Jingwen Chen55bc8202021-11-02 06:40:51 +00001251func (la *linkerAttributes) convertProductVariables(ctx android.BazelConversionPathContext, productVariableProps android.ProductConfigProperties) {
Jingwen Chen6ada5892021-09-17 11:38:09 +00001252
Liz Kammer47535c52021-06-02 16:02:22 -04001253 type productVarDep struct {
1254 // the name of the corresponding excludes field, if one exists
1255 excludesField string
1256 // reference to the bazel attribute that should be set for the given product variable config
1257 attribute *bazel.LabelListAttribute
Liz Kammer2d7bbe32021-06-10 18:20:06 -04001258
Jingwen Chen55bc8202021-11-02 06:40:51 +00001259 depResolutionFunc func(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList
Liz Kammer47535c52021-06-02 16:02:22 -04001260 }
1261
Zi Wang0a8a1292022-08-30 06:27:01 +00001262 // an intermediate attribute that holds Header_libs info, and will be appended to
1263 // implementationDeps at the end, to solve the confliction that both header_libs
1264 // and static_libs use implementationDeps.
1265 var headerDeps bazel.LabelListAttribute
1266
Liz Kammer47535c52021-06-02 16:02:22 -04001267 productVarToDepFields := map[string]productVarDep{
1268 // product variables do not support exclude_shared_libs
Jingwen Chen55bc8202021-11-02 06:40:51 +00001269 "Shared_libs": {attribute: &la.implementationDynamicDeps, depResolutionFunc: bazelLabelForSharedDepsExcludes},
1270 "Static_libs": {"Exclude_static_libs", &la.implementationDeps, bazelLabelForStaticDepsExcludes},
1271 "Whole_static_libs": {"Exclude_static_libs", &la.wholeArchiveDeps, bazelLabelForWholeDepsExcludes},
Zi Wang0a8a1292022-08-30 06:27:01 +00001272 "Header_libs": {attribute: &headerDeps, depResolutionFunc: bazelLabelForHeaderDepsExcludes},
Liz Kammer47535c52021-06-02 16:02:22 -04001273 }
1274
Liz Kammer47535c52021-06-02 16:02:22 -04001275 for name, dep := range productVarToDepFields {
1276 props, exists := productVariableProps[name]
1277 excludeProps, excludesExists := productVariableProps[dep.excludesField]
Sasha Smundak39a301c2022-12-29 17:11:49 -08001278 // if neither an include nor excludes property exists, then skip it
Liz Kammer47535c52021-06-02 16:02:22 -04001279 if !exists && !excludesExists {
1280 continue
1281 }
Jingwen Chen25825ca2021-11-15 12:28:43 +00001282 // Collect all the configurations that an include or exclude property exists for.
1283 // We want to iterate all configurations rather than either the include or exclude because, for a
1284 // particular configuration, we may have either only an include or an exclude to handle.
1285 productConfigProps := make(map[android.ProductConfigProperty]bool, len(props)+len(excludeProps))
1286 for p := range props {
1287 productConfigProps[p] = true
Liz Kammer47535c52021-06-02 16:02:22 -04001288 }
Jingwen Chen25825ca2021-11-15 12:28:43 +00001289 for p := range excludeProps {
1290 productConfigProps[p] = true
Liz Kammer47535c52021-06-02 16:02:22 -04001291 }
1292
Jingwen Chen25825ca2021-11-15 12:28:43 +00001293 for productConfigProp := range productConfigProps {
1294 prop, includesExists := props[productConfigProp]
1295 excludesProp, excludesExists := excludeProps[productConfigProp]
Liz Kammer47535c52021-06-02 16:02:22 -04001296 var includes, excludes []string
1297 var ok bool
1298 // if there was no includes/excludes property, casting fails and that's expected
Jingwen Chen25825ca2021-11-15 12:28:43 +00001299 if includes, ok = prop.([]string); includesExists && !ok {
Liz Kammer47535c52021-06-02 16:02:22 -04001300 ctx.ModuleErrorf("Could not convert product variable %s property", name)
1301 }
Jingwen Chen25825ca2021-11-15 12:28:43 +00001302 if excludes, ok = excludesProp.([]string); excludesExists && !ok {
Liz Kammer47535c52021-06-02 16:02:22 -04001303 ctx.ModuleErrorf("Could not convert product variable %s property", dep.excludesField)
1304 }
Liz Kammer2d7bbe32021-06-10 18:20:06 -04001305
Jingwen Chen58ff6802021-11-17 12:14:41 +00001306 dep.attribute.EmitEmptyList = productConfigProp.AlwaysEmit()
Jingwen Chen25825ca2021-11-15 12:28:43 +00001307 dep.attribute.SetSelectValue(
1308 productConfigProp.ConfigurationAxis(),
1309 productConfigProp.SelectKey(),
1310 dep.depResolutionFunc(ctx, android.FirstUniqueStrings(includes), excludes),
1311 )
Liz Kammer47535c52021-06-02 16:02:22 -04001312 }
1313 }
Zi Wang0a8a1292022-08-30 06:27:01 +00001314 la.implementationDeps.Append(headerDeps)
Liz Kammere6583482021-10-19 13:56:10 -04001315}
Liz Kammer47535c52021-06-02 16:02:22 -04001316
Liz Kammer54309532021-12-14 12:21:22 -05001317func (la *linkerAttributes) finalize(ctx android.BazelConversionPathContext) {
1318 // if system dynamic deps have the default value, any use of a system dynamic library used will
1319 // result in duplicate library errors for bionic OSes. Here, we explicitly exclude those libraries
Liz Kammer43345e22022-08-04 13:57:35 -04001320 // from bionic OSes and the no config case as these libraries only build for bionic OSes.
Liz Kammer54309532021-12-14 12:21:22 -05001321 if la.systemDynamicDeps.IsNil() && len(la.usedSystemDynamicDepAsDynamicDep) > 0 {
Cole Faust18994c72023-02-28 16:02:16 -08001322 toRemove := bazelLabelForSharedDeps(ctx, android.SortedKeys(la.usedSystemDynamicDepAsDynamicDep))
Liz Kammer43345e22022-08-04 13:57:35 -04001323 la.dynamicDeps.Exclude(bazel.NoConfigAxis, "", toRemove)
Liz Kammer54309532021-12-14 12:21:22 -05001324 la.dynamicDeps.Exclude(bazel.OsConfigurationAxis, "android", toRemove)
1325 la.dynamicDeps.Exclude(bazel.OsConfigurationAxis, "linux_bionic", toRemove)
Liz Kammer91487d42022-09-13 11:27:11 -04001326 la.implementationDynamicDeps.Exclude(bazel.NoConfigAxis, "", toRemove)
Liz Kammer54309532021-12-14 12:21:22 -05001327 la.implementationDynamicDeps.Exclude(bazel.OsConfigurationAxis, "android", toRemove)
1328 la.implementationDynamicDeps.Exclude(bazel.OsConfigurationAxis, "linux_bionic", toRemove)
Liz Kammer91487d42022-09-13 11:27:11 -04001329
1330 la.implementationDynamicDeps.Exclude(bazel.OsAndInApexAxis, bazel.ConditionsDefaultConfigKey, toRemove)
1331 la.implementationDynamicDeps.Exclude(bazel.OsAndInApexAxis, bazel.AndroidAndNonApex, toRemove)
1332 stubsToRemove := make([]bazel.Label, 0, len(la.usedSystemDynamicDepAsDynamicDep))
1333 for _, lib := range toRemove.Includes {
Spandan Das2518c022023-03-17 03:02:32 +00001334 stubLabelInApiSurfaces := bazel.Label{
1335 Label: apiSurfaceModuleLibCurrentPackage + lib.OriginalModuleName,
1336 }
1337 stubsToRemove = append(stubsToRemove, stubLabelInApiSurfaces)
Liz Kammer91487d42022-09-13 11:27:11 -04001338 }
1339 la.implementationDynamicDeps.Exclude(bazel.OsAndInApexAxis, bazel.AndroidAndInApex, bazel.MakeLabelList(stubsToRemove))
Liz Kammer54309532021-12-14 12:21:22 -05001340 }
1341
Liz Kammere6583482021-10-19 13:56:10 -04001342 la.deps.ResolveExcludes()
1343 la.implementationDeps.ResolveExcludes()
1344 la.dynamicDeps.ResolveExcludes()
1345 la.implementationDynamicDeps.ResolveExcludes()
1346 la.wholeArchiveDeps.ResolveExcludes()
1347 la.systemDynamicDeps.ForceSpecifyEmptyList = true
Liz Kammer54309532021-12-14 12:21:22 -05001348
Jingwen Chen91220d72021-03-24 02:18:33 -04001349}
1350
Jingwen Chened9c17d2021-04-13 07:14:55 +00001351// Relativize a list of root-relative paths with respect to the module's
1352// directory.
1353//
1354// include_dirs Soong prop are root-relative (b/183742505), but
1355// local_include_dirs, export_include_dirs and export_system_include_dirs are
1356// module dir relative. This function makes a list of paths entirely module dir
1357// relative.
1358//
1359// For the `include` attribute, Bazel wants the paths to be relative to the
1360// module.
1361func bp2BuildMakePathsRelativeToModule(ctx android.BazelConversionPathContext, paths []string) []string {
Rupert Shuttleworthb8151682021-04-06 20:06:21 +00001362 var relativePaths []string
1363 for _, path := range paths {
Jingwen Chened9c17d2021-04-13 07:14:55 +00001364 // Semantics of filepath.Rel: join(ModuleDir, rel(ModuleDir, path)) == path
1365 relativePath, err := filepath.Rel(ctx.ModuleDir(), path)
1366 if err != nil {
1367 panic(err)
1368 }
Rupert Shuttleworthb8151682021-04-06 20:06:21 +00001369 relativePaths = append(relativePaths, relativePath)
1370 }
1371 return relativePaths
1372}
1373
Liz Kammer5fad5012021-09-09 14:08:21 -04001374// BazelIncludes contains information about -I and -isystem paths from a module converted to Bazel
1375// attributes.
1376type BazelIncludes struct {
Liz Kammer1263d9b2021-12-10 14:28:20 -05001377 AbsoluteIncludes bazel.StringListAttribute
1378 Includes bazel.StringListAttribute
1379 SystemIncludes bazel.StringListAttribute
Liz Kammer5fad5012021-09-09 14:08:21 -04001380}
1381
Liz Kammer54549442022-05-11 13:55:06 -04001382func bp2BuildParseExportedIncludes(ctx android.BazelConversionPathContext, module *Module, includes *BazelIncludes) BazelIncludes {
Liz Kammer1263d9b2021-12-10 14:28:20 -05001383 var exported BazelIncludes
1384 if includes != nil {
1385 exported = *includes
1386 } else {
1387 exported = BazelIncludes{}
1388 }
Zi Wang1cb11802022-12-09 16:08:54 -08001389
1390 // cc library Export_include_dirs and Export_system_include_dirs are marked
1391 // "variant_prepend" in struct tag, set their prepend property to true to make
1392 // sure bp2build generates correct result.
1393 exported.Includes.Prepend = true
1394 exported.SystemIncludes.Prepend = true
1395
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001396 bp2BuildPropParseHelper(ctx, module, &FlagExporterProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1397 if flagExporterProperties, ok := props.(*FlagExporterProperties); ok {
1398 if len(flagExporterProperties.Export_include_dirs) > 0 {
1399 exported.Includes.SetSelectValue(axis, config, android.FirstUniqueStrings(append(exported.Includes.SelectValue(axis, config), flagExporterProperties.Export_include_dirs...)))
1400 }
1401 if len(flagExporterProperties.Export_system_include_dirs) > 0 {
1402 exported.SystemIncludes.SetSelectValue(axis, config, android.FirstUniqueStrings(append(exported.SystemIncludes.SelectValue(axis, config), flagExporterProperties.Export_system_include_dirs...)))
Rupert Shuttleworth375451e2021-04-26 07:49:08 -04001403 }
Rupert Shuttleworth375451e2021-04-26 07:49:08 -04001404 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001405 })
Liz Kammer1263d9b2021-12-10 14:28:20 -05001406 exported.AbsoluteIncludes.DeduplicateAxesFromBase()
Liz Kammer5fad5012021-09-09 14:08:21 -04001407 exported.Includes.DeduplicateAxesFromBase()
1408 exported.SystemIncludes.DeduplicateAxesFromBase()
Rupert Shuttleworth375451e2021-04-26 07:49:08 -04001409
Liz Kammer5fad5012021-09-09 14:08:21 -04001410 return exported
Jingwen Chen91220d72021-03-24 02:18:33 -04001411}
Chris Parsons953b3562021-09-20 15:14:39 -04001412
Trevor Radcliffecee4e052022-09-06 19:31:25 +00001413func BazelLabelNameForStaticModule(baseLabel string) string {
1414 return baseLabel + "_bp2build_cc_library_static"
1415}
1416
Jingwen Chen55bc8202021-11-02 06:40:51 +00001417func bazelLabelForStaticModule(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -04001418 label := android.BazelModuleLabel(ctx, m)
Sasha Smundak39a301c2022-12-29 17:11:49 -08001419 if ccModule, ok := m.(*Module); ok && ccModule.typ() == fullLibrary {
Trevor Radcliffecee4e052022-09-06 19:31:25 +00001420 return BazelLabelNameForStaticModule(label)
Chris Parsons953b3562021-09-20 15:14:39 -04001421 }
1422 return label
1423}
1424
Jingwen Chen55bc8202021-11-02 06:40:51 +00001425func bazelLabelForSharedModule(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -04001426 // cc_library, at it's root name, propagates the shared library, which depends on the static
1427 // library.
1428 return android.BazelModuleLabel(ctx, m)
1429}
1430
Jingwen Chen55bc8202021-11-02 06:40:51 +00001431func bazelLabelForStaticWholeModuleDeps(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -04001432 label := bazelLabelForStaticModule(ctx, m)
1433 if aModule, ok := m.(android.Module); ok {
1434 if android.IsModulePrebuilt(aModule) {
1435 label += "_alwayslink"
1436 }
1437 }
1438 return label
1439}
1440
Jingwen Chen55bc8202021-11-02 06:40:51 +00001441func bazelLabelForWholeDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001442 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForStaticWholeModuleDeps)
1443}
1444
Jingwen Chen55bc8202021-11-02 06:40:51 +00001445func bazelLabelForWholeDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001446 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForStaticWholeModuleDeps)
1447}
1448
Jingwen Chen55bc8202021-11-02 06:40:51 +00001449func bazelLabelForStaticDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001450 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForStaticModule)
1451}
1452
Jingwen Chen55bc8202021-11-02 06:40:51 +00001453func bazelLabelForStaticDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001454 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForStaticModule)
1455}
1456
Jingwen Chen55bc8202021-11-02 06:40:51 +00001457func bazelLabelForSharedDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001458 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForSharedModule)
1459}
1460
Jingwen Chen55bc8202021-11-02 06:40:51 +00001461func bazelLabelForHeaderDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001462 // This is not elegant, but bp2build's shared library targets only propagate
1463 // their header information as part of the normal C++ provider.
1464 return bazelLabelForSharedDeps(ctx, modules)
1465}
1466
Zi Wang0a8a1292022-08-30 06:27:01 +00001467func bazelLabelForHeaderDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
1468 // This is only used when product_variable header_libs is processed, to follow
1469 // the pattern of depResolutionFunc
1470 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForSharedModule)
1471}
1472
Jingwen Chen55bc8202021-11-02 06:40:51 +00001473func bazelLabelForSharedDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001474 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForSharedModule)
1475}
Liz Kammer2b8004b2021-10-04 13:55:44 -04001476
1477type binaryLinkerAttrs struct {
1478 Linkshared *bool
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05001479 Suffix bazel.StringAttribute
Liz Kammer2b8004b2021-10-04 13:55:44 -04001480}
1481
Jingwen Chen55bc8202021-11-02 06:40:51 +00001482func bp2buildBinaryLinkerProps(ctx android.BazelConversionPathContext, m *Module) binaryLinkerAttrs {
Liz Kammer2b8004b2021-10-04 13:55:44 -04001483 attrs := binaryLinkerAttrs{}
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001484 bp2BuildPropParseHelper(ctx, m, &BinaryLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1485 linkerProps := props.(*BinaryLinkerProperties)
1486 staticExecutable := linkerProps.Static_executable
1487 if axis == bazel.NoConfigAxis {
1488 if linkBinaryShared := !proptools.Bool(staticExecutable); !linkBinaryShared {
1489 attrs.Linkshared = &linkBinaryShared
Liz Kammer2b8004b2021-10-04 13:55:44 -04001490 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001491 } else if staticExecutable != nil {
1492 // TODO(b/202876379): Static_executable is arch-variant; however, linkshared is a
1493 // nonconfigurable attribute. Only 4 AOSP modules use this feature, defer handling
1494 ctx.ModuleErrorf("bp2build cannot migrate a module with arch/target-specific static_executable values")
Liz Kammer2b8004b2021-10-04 13:55:44 -04001495 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05001496 if suffix := linkerProps.Suffix; suffix != nil {
1497 attrs.Suffix.SetSelectValue(axis, config, suffix)
1498 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001499 })
Liz Kammer2b8004b2021-10-04 13:55:44 -04001500
1501 return attrs
1502}
Trevor Radcliffedb7e0262022-10-28 16:48:18 +00001503
1504func bp2buildSanitizerFeatures(ctx android.BazelConversionPathContext, m *Module) bazel.StringListAttribute {
1505 sanitizerFeatures := bazel.StringListAttribute{}
1506 bp2BuildPropParseHelper(ctx, m, &SanitizeProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1507 var features []string
1508 if sanitizerProps, ok := props.(*SanitizeProperties); ok {
1509 if sanitizerProps.Sanitize.Integer_overflow != nil && *sanitizerProps.Sanitize.Integer_overflow {
1510 features = append(features, "ubsan_integer_overflow")
1511 }
1512 for _, sanitizer := range sanitizerProps.Sanitize.Misc_undefined {
1513 features = append(features, "ubsan_"+sanitizer)
1514 }
1515 sanitizerFeatures.SetSelectValue(axis, config, features)
1516 }
1517 })
1518 return sanitizerFeatures
1519}
Trevor Radcliffe56b1a2b2023-02-06 21:58:30 +00001520
1521func bp2buildLtoFeatures(ctx android.BazelConversionPathContext, m *Module) bazel.StringListAttribute {
1522 lto_feature_name := "android_thin_lto"
1523 ltoBoolFeatures := bazel.BoolAttribute{}
1524 bp2BuildPropParseHelper(ctx, m, &LTOProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1525 if ltoProps, ok := props.(*LTOProperties); ok {
1526 thinProp := ltoProps.Lto.Thin != nil && *ltoProps.Lto.Thin
1527 thinPropSetToFalse := ltoProps.Lto.Thin != nil && !*ltoProps.Lto.Thin
1528 neverProp := ltoProps.Lto.Never != nil && *ltoProps.Lto.Never
1529 if thinProp {
1530 ltoBoolFeatures.SetSelectValue(axis, config, BoolPtr(true))
1531 return
1532 }
1533 if neverProp || thinPropSetToFalse {
1534 if thinProp {
1535 ctx.ModuleErrorf("lto.thin and lto.never are mutually exclusive but were specified together")
1536 } else {
1537 ltoBoolFeatures.SetSelectValue(axis, config, BoolPtr(false))
1538 }
1539 return
1540 }
1541 }
1542 ltoBoolFeatures.SetSelectValue(axis, config, nil)
1543 })
1544
1545 props := m.GetArchVariantProperties(ctx, &LTOProperties{})
1546 ltoStringFeatures, err := ltoBoolFeatures.ToStringListAttribute(func(boolPtr *bool, axis bazel.ConfigurationAxis, config string) []string {
1547 if boolPtr == nil {
1548 return []string{}
1549 }
1550 if !*boolPtr {
1551 return []string{"-" + lto_feature_name}
1552 }
1553 features := []string{lto_feature_name}
1554 if ltoProps, ok := props[axis][config].(*LTOProperties); ok {
1555 if ltoProps.Whole_program_vtables != nil && *ltoProps.Whole_program_vtables {
1556 features = append(features, "android_thin_lto_whole_program_vtables")
1557 }
1558 }
1559 return features
1560 })
1561 if err != nil {
1562 ctx.ModuleErrorf("Error processing LTO attributes: %s", err)
1563 }
1564 return ltoStringFeatures
1565}
Trevor Radcliffea8b44162023-04-14 18:25:24 +00001566
1567func convertHiddenVisibilityToFeatureBase(ctx android.BazelConversionPathContext, m *Module) bazel.StringListAttribute {
1568 visibilityHiddenFeature := bazel.StringListAttribute{}
1569 bp2BuildPropParseHelper(ctx, m, &BaseCompilerProperties{}, func(axis bazel.ConfigurationAxis, configString string, props interface{}) {
1570 if baseCompilerProps, ok := props.(*BaseCompilerProperties); ok {
1571 convertHiddenVisibilityToFeatureHelper(&visibilityHiddenFeature, axis, configString, baseCompilerProps.Cflags)
1572 }
1573 })
1574 return visibilityHiddenFeature
1575}
1576
1577func convertHiddenVisibilityToFeatureStaticOrShared(ctx android.BazelConversionPathContext, m *Module, isStatic bool) bazel.StringListAttribute {
1578 visibilityHiddenFeature := bazel.StringListAttribute{}
1579 if isStatic {
1580 bp2BuildPropParseHelper(ctx, m, &StaticProperties{}, func(axis bazel.ConfigurationAxis, configString string, props interface{}) {
1581 if staticProps, ok := props.(*StaticProperties); ok {
1582 convertHiddenVisibilityToFeatureHelper(&visibilityHiddenFeature, axis, configString, staticProps.Static.Cflags)
1583 }
1584 })
1585 } else {
1586 bp2BuildPropParseHelper(ctx, m, &SharedProperties{}, func(axis bazel.ConfigurationAxis, configString string, props interface{}) {
1587 if sharedProps, ok := props.(*SharedProperties); ok {
1588 convertHiddenVisibilityToFeatureHelper(&visibilityHiddenFeature, axis, configString, sharedProps.Shared.Cflags)
1589 }
1590 })
1591 }
1592
1593 return visibilityHiddenFeature
1594}
1595
1596func convertHiddenVisibilityToFeatureHelper(feature *bazel.StringListAttribute, axis bazel.ConfigurationAxis, configString string, cflags []string) {
1597 if inList(config.VisibilityHiddenFlag, cflags) {
1598 feature.SetSelectValue(axis, configString, []string{"visibility_hidden"})
1599 }
1600}