blob: 505306b75b020cc85fccd371519e19a84bd44f43 [file] [log] [blame]
Jingwen Chen63930982021-03-24 10:04:33 -04001// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package bp2build
16
17import (
Jingwen Chen6ada5892021-09-17 11:38:09 +000018 "fmt"
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux1c92aef2021-08-23 16:10:00 +000019 "testing"
20
Vinh Tran367d89d2023-04-28 11:21:25 -040021 "android/soong/aidl_library"
Jingwen Chen63930982021-03-24 10:04:33 -040022 "android/soong/android"
23 "android/soong/cc"
Jingwen Chen63930982021-03-24 10:04:33 -040024)
25
26const (
27 // See cc/testing.go for more context
28 soongCcLibraryPreamble = `
29cc_defaults {
Liz Kammer8337ea42021-09-10 10:06:32 -040030 name: "linux_bionic_supported",
Liz Kammerbaced712022-09-16 09:01:29 -040031}
32`
33
34 soongCcVersionLibBpPath = "build/soong/cc/libbuildversion/Android.bp"
35 soongCcVersionLibBp = `
36cc_library_static {
37 name: "libbuildversion",
38 bazel_module: { bp2build_available: false },
39}
40`
Liz Kammer12615db2021-09-28 09:19:17 -040041
42 soongCcProtoLibraries = `
43cc_library {
44 name: "libprotobuf-cpp-lite",
45 bazel_module: { bp2build_available: false },
46}
47
48cc_library {
49 name: "libprotobuf-cpp-full",
50 bazel_module: { bp2build_available: false },
51}`
52
53 soongCcProtoPreamble = soongCcLibraryPreamble + soongCcProtoLibraries
Jingwen Chen63930982021-03-24 10:04:33 -040054)
55
Sam Delmerico3177a6e2022-06-21 19:28:33 +000056func runCcLibraryTestCase(t *testing.T, tc Bp2buildTestCase) {
Liz Kammere4982e82021-05-25 10:39:35 -040057 t.Helper()
Sam Delmerico3177a6e2022-06-21 19:28:33 +000058 RunBp2BuildTestCase(t, registerCcLibraryModuleTypes, tc)
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020059}
60
61func registerCcLibraryModuleTypes(ctx android.RegistrationContext) {
62 cc.RegisterCCBuildComponents(ctx)
Jingwen Chen14a8bda2021-06-02 11:10:02 +000063 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020064 ctx.RegisterModuleType("cc_library_static", cc.LibraryStaticFactory)
Liz Kammer2d7bbe32021-06-10 18:20:06 -040065 ctx.RegisterModuleType("cc_prebuilt_library_static", cc.PrebuiltStaticLibraryFactory)
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020066 ctx.RegisterModuleType("cc_library_headers", cc.LibraryHeaderFactory)
Vinh Tran367d89d2023-04-28 11:21:25 -040067 ctx.RegisterModuleType("aidl_library", aidl_library.AidlLibraryFactory)
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020068}
69
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020070func TestCcLibrarySimple(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +000071 runCcLibraryTestCase(t, Bp2buildTestCase{
72 Description: "cc_library - simple example",
73 ModuleTypeUnderTest: "cc_library",
74 ModuleTypeUnderTestFactory: cc.LibraryFactory,
75 Filesystem: map[string]string{
Liz Kammerbaced712022-09-16 09:01:29 -040076 soongCcVersionLibBpPath: soongCcVersionLibBp,
77 "android.cpp": "",
78 "bionic.cpp": "",
79 "darwin.cpp": "",
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020080 // Refer to cc.headerExts for the supported header extensions in Soong.
81 "header.h": "",
82 "header.hh": "",
83 "header.hpp": "",
84 "header.hxx": "",
85 "header.h++": "",
86 "header.inl": "",
87 "header.inc": "",
88 "header.ipp": "",
89 "header.h.generic": "",
90 "impl.cpp": "",
91 "linux.cpp": "",
92 "x86.cpp": "",
93 "x86_64.cpp": "",
94 "foo-dir/a.h": "",
95 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +000096 Blueprint: soongCcLibraryPreamble +
Liz Kammer78cfdaa2021-11-08 12:56:31 -050097 simpleModuleDoNotConvertBp2build("cc_library_headers", "some-headers") + `
Jingwen Chen63930982021-03-24 10:04:33 -040098cc_library {
99 name: "foo-lib",
100 srcs: ["impl.cpp"],
101 cflags: ["-Wall"],
102 header_libs: ["some-headers"],
103 export_include_dirs: ["foo-dir"],
104 ldflags: ["-Wl,--exclude-libs=bar.a"],
105 arch: {
106 x86: {
107 ldflags: ["-Wl,--exclude-libs=baz.a"],
108 srcs: ["x86.cpp"],
109 },
110 x86_64: {
111 ldflags: ["-Wl,--exclude-libs=qux.a"],
112 srcs: ["x86_64.cpp"],
113 },
114 },
115 target: {
116 android: {
117 srcs: ["android.cpp"],
118 },
119 linux_glibc: {
120 srcs: ["linux.cpp"],
121 },
122 darwin: {
123 srcs: ["darwin.cpp"],
124 },
Liz Kammer01a16e82021-07-16 16:33:47 -0400125 bionic: {
126 srcs: ["bionic.cpp"]
127 },
Jingwen Chen63930982021-03-24 10:04:33 -0400128 },
Liz Kammer8337ea42021-09-10 10:06:32 -0400129 include_build_directory: false,
Yu Liufc603162022-03-01 15:44:08 -0800130 sdk_version: "current",
131 min_sdk_version: "29",
Yu Liua79c9462022-03-22 16:35:22 -0700132 use_version_lib: true,
Jingwen Chen63930982021-03-24 10:04:33 -0400133}
134`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000135 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500136 "copts": `["-Wall"]`,
137 "export_includes": `["foo-dir"]`,
138 "implementation_deps": `[":some-headers"]`,
139 "linkopts": `["-Wl,--exclude-libs=bar.a"] + select({
Jingwen Chened9c17d2021-04-13 07:14:55 +0000140 "//build/bazel/platforms/arch:x86": ["-Wl,--exclude-libs=baz.a"],
141 "//build/bazel/platforms/arch:x86_64": ["-Wl,--exclude-libs=qux.a"],
142 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500143 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500144 "srcs": `["impl.cpp"] + select({
Jingwen Chenb4628eb2021-04-08 14:40:57 +0000145 "//build/bazel/platforms/arch:x86": ["x86.cpp"],
146 "//build/bazel/platforms/arch:x86_64": ["x86_64.cpp"],
Jingwen Chen63930982021-03-24 10:04:33 -0400147 "//conditions:default": [],
148 }) + select({
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400149 "//build/bazel/platforms/os:android": [
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400150 "bionic.cpp",
Liz Kammerfdd72e62021-10-11 15:41:03 -0400151 "android.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400152 ],
Jingwen Chenb4628eb2021-04-08 14:40:57 +0000153 "//build/bazel/platforms/os:darwin": ["darwin.cpp"],
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400154 "//build/bazel/platforms/os:linux_bionic": ["bionic.cpp"],
Colin Cross133782e2022-12-20 15:29:31 -0800155 "//build/bazel/platforms/os:linux_glibc": ["linux.cpp"],
Liz Kammer01a16e82021-07-16 16:33:47 -0400156 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500157 })`,
Yu Liufe978fd2023-04-24 16:37:18 -0700158 "sdk_version": `"current"`,
159 "min_sdk_version": `"29"`,
160 "use_version_lib": `True`,
161 "whole_archive_deps": `["//build/soong/cc/libbuildversion:libbuildversion"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500162 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500163 })
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200164}
165
166func TestCcLibraryTrimmedLdAndroid(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000167 runCcLibraryTestCase(t, Bp2buildTestCase{
168 Description: "cc_library - trimmed example of //bionic/linker:ld-android",
169 ModuleTypeUnderTest: "cc_library",
170 ModuleTypeUnderTestFactory: cc.LibraryFactory,
171 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200172 "ld-android.cpp": "",
173 "linked_list.h": "",
174 "linker.h": "",
175 "linker_block_allocator.h": "",
176 "linker_cfi.h": "",
Jingwen Chen63930982021-03-24 10:04:33 -0400177 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000178 Blueprint: soongCcLibraryPreamble +
Liz Kammerbe46fcc2021-11-01 15:32:43 -0400179 simpleModuleDoNotConvertBp2build("cc_library_headers", "libc_headers") + `
Jingwen Chen63930982021-03-24 10:04:33 -0400180cc_library {
181 name: "fake-ld-android",
182 srcs: ["ld_android.cpp"],
183 cflags: [
184 "-Wall",
185 "-Wextra",
186 "-Wunused",
187 "-Werror",
188 ],
189 header_libs: ["libc_headers"],
190 ldflags: [
191 "-Wl,--exclude-libs=libgcc.a",
192 "-Wl,--exclude-libs=libgcc_stripped.a",
193 "-Wl,--exclude-libs=libclang_rt.builtins-arm-android.a",
194 "-Wl,--exclude-libs=libclang_rt.builtins-aarch64-android.a",
195 "-Wl,--exclude-libs=libclang_rt.builtins-i686-android.a",
196 "-Wl,--exclude-libs=libclang_rt.builtins-x86_64-android.a",
197 ],
198 arch: {
199 x86: {
200 ldflags: ["-Wl,--exclude-libs=libgcc_eh.a"],
201 },
202 x86_64: {
203 ldflags: ["-Wl,--exclude-libs=libgcc_eh.a"],
204 },
205 },
Liz Kammer8337ea42021-09-10 10:06:32 -0400206 include_build_directory: false,
Jingwen Chen63930982021-03-24 10:04:33 -0400207}
208`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000209 ExpectedBazelTargets: makeCcLibraryTargets("fake-ld-android", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500210 "srcs": `["ld_android.cpp"]`,
211 "copts": `[
Jingwen Chen63930982021-03-24 10:04:33 -0400212 "-Wall",
213 "-Wextra",
214 "-Wunused",
215 "-Werror",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500216 ]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500217 "implementation_deps": `[":libc_headers"]`,
218 "linkopts": `[
Jingwen Chen63930982021-03-24 10:04:33 -0400219 "-Wl,--exclude-libs=libgcc.a",
220 "-Wl,--exclude-libs=libgcc_stripped.a",
221 "-Wl,--exclude-libs=libclang_rt.builtins-arm-android.a",
222 "-Wl,--exclude-libs=libclang_rt.builtins-aarch64-android.a",
223 "-Wl,--exclude-libs=libclang_rt.builtins-i686-android.a",
224 "-Wl,--exclude-libs=libclang_rt.builtins-x86_64-android.a",
225 ] + select({
Jingwen Chenb4628eb2021-04-08 14:40:57 +0000226 "//build/bazel/platforms/arch:x86": ["-Wl,--exclude-libs=libgcc_eh.a"],
227 "//build/bazel/platforms/arch:x86_64": ["-Wl,--exclude-libs=libgcc_eh.a"],
Jingwen Chen63930982021-03-24 10:04:33 -0400228 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500229 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500230 }),
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200231 })
232}
233
234func TestCcLibraryExcludeSrcs(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000235 runCcLibraryTestCase(t, Bp2buildTestCase{
236 Description: "cc_library exclude_srcs - trimmed example of //external/arm-optimized-routines:libarm-optimized-routines-math",
237 ModuleTypeUnderTest: "cc_library",
238 ModuleTypeUnderTestFactory: cc.LibraryFactory,
239 Dir: "external",
240 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200241 "external/math/cosf.c": "",
242 "external/math/erf.c": "",
243 "external/math/erf_data.c": "",
244 "external/math/erff.c": "",
245 "external/math/erff_data.c": "",
246 "external/Android.bp": `
Jingwen Chen4ecc67d2021-04-27 09:47:02 +0000247cc_library {
248 name: "fake-libarm-optimized-routines-math",
249 exclude_srcs: [
250 // Provided by:
251 // bionic/libm/upstream-freebsd/lib/msun/src/s_erf.c
252 // bionic/libm/upstream-freebsd/lib/msun/src/s_erff.c
253 "math/erf.c",
254 "math/erf_data.c",
255 "math/erff.c",
256 "math/erff_data.c",
257 ],
258 srcs: [
259 "math/*.c",
260 ],
261 // arch-specific settings
262 arch: {
263 arm64: {
264 cflags: [
265 "-DHAVE_FAST_FMA=1",
266 ],
267 },
268 },
269 bazel_module: { bp2build_available: true },
270}
271`,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200272 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000273 Blueprint: soongCcLibraryPreamble,
274 ExpectedBazelTargets: makeCcLibraryTargets("fake-libarm-optimized-routines-math", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500275 "copts": `select({
Jingwen Chen4ecc67d2021-04-27 09:47:02 +0000276 "//build/bazel/platforms/arch:arm64": ["-DHAVE_FAST_FMA=1"],
277 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500278 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500279 "local_includes": `["."]`,
280 "srcs_c": `["math/cosf.c"]`,
281 }),
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200282 })
283}
284
285func TestCcLibrarySharedStaticProps(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000286 runCcLibraryTestCase(t, Bp2buildTestCase{
287 Description: "cc_library shared/static props",
288 ModuleTypeUnderTest: "cc_library",
289 ModuleTypeUnderTestFactory: cc.LibraryFactory,
290 Filesystem: map[string]string{
Liz Kammer8337ea42021-09-10 10:06:32 -0400291 "both.cpp": "",
292 "sharedonly.cpp": "",
293 "staticonly.cpp": "",
294 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000295 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen53681ef2021-04-29 08:15:13 +0000296cc_library {
297 name: "a",
Chris Parsons08648312021-05-06 16:23:19 -0400298 srcs: ["both.cpp"],
299 cflags: ["bothflag"],
300 shared_libs: ["shared_dep_for_both"],
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400301 static_libs: ["static_dep_for_both", "whole_and_static_lib_for_both"],
302 whole_static_libs: ["whole_static_lib_for_both", "whole_and_static_lib_for_both"],
Chris Parsons08648312021-05-06 16:23:19 -0400303 static: {
304 srcs: ["staticonly.cpp"],
305 cflags: ["staticflag"],
306 shared_libs: ["shared_dep_for_static"],
307 static_libs: ["static_dep_for_static"],
308 whole_static_libs: ["whole_static_lib_for_static"],
309 },
310 shared: {
311 srcs: ["sharedonly.cpp"],
312 cflags: ["sharedflag"],
313 shared_libs: ["shared_dep_for_shared"],
314 static_libs: ["static_dep_for_shared"],
315 whole_static_libs: ["whole_static_lib_for_shared"],
316 },
Liz Kammer8337ea42021-09-10 10:06:32 -0400317 include_build_directory: false,
Jingwen Chen53681ef2021-04-29 08:15:13 +0000318}
319
Liz Kammer8337ea42021-09-10 10:06:32 -0400320cc_library_static {
321 name: "static_dep_for_shared",
322 bazel_module: { bp2build_available: false },
323}
Chris Parsons08648312021-05-06 16:23:19 -0400324
Liz Kammer8337ea42021-09-10 10:06:32 -0400325cc_library_static {
326 name: "static_dep_for_static",
327 bazel_module: { bp2build_available: false },
328}
Chris Parsons08648312021-05-06 16:23:19 -0400329
Liz Kammer8337ea42021-09-10 10:06:32 -0400330cc_library_static {
331 name: "static_dep_for_both",
332 bazel_module: { bp2build_available: false },
333}
Chris Parsons08648312021-05-06 16:23:19 -0400334
Liz Kammer8337ea42021-09-10 10:06:32 -0400335cc_library_static {
336 name: "whole_static_lib_for_shared",
337 bazel_module: { bp2build_available: false },
338}
Chris Parsons08648312021-05-06 16:23:19 -0400339
Liz Kammer8337ea42021-09-10 10:06:32 -0400340cc_library_static {
341 name: "whole_static_lib_for_static",
342 bazel_module: { bp2build_available: false },
343}
Chris Parsons08648312021-05-06 16:23:19 -0400344
Liz Kammer8337ea42021-09-10 10:06:32 -0400345cc_library_static {
346 name: "whole_static_lib_for_both",
347 bazel_module: { bp2build_available: false },
348}
Chris Parsons08648312021-05-06 16:23:19 -0400349
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400350cc_library_static {
351 name: "whole_and_static_lib_for_both",
352 bazel_module: { bp2build_available: false },
353}
354
Liz Kammer8337ea42021-09-10 10:06:32 -0400355cc_library {
356 name: "shared_dep_for_shared",
357 bazel_module: { bp2build_available: false },
358}
Chris Parsons08648312021-05-06 16:23:19 -0400359
Liz Kammer8337ea42021-09-10 10:06:32 -0400360cc_library {
361 name: "shared_dep_for_static",
362 bazel_module: { bp2build_available: false },
363}
Chris Parsons08648312021-05-06 16:23:19 -0400364
Liz Kammer8337ea42021-09-10 10:06:32 -0400365cc_library {
366 name: "shared_dep_for_both",
367 bazel_module: { bp2build_available: false },
368}
Jingwen Chen53681ef2021-04-29 08:15:13 +0000369`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000370 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000371 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500372 "copts": `[
373 "bothflag",
374 "staticflag",
375 ]`,
376 "implementation_deps": `[
377 ":static_dep_for_both",
378 ":static_dep_for_static",
379 ]`,
380 "implementation_dynamic_deps": `[
381 ":shared_dep_for_both",
382 ":shared_dep_for_static",
383 ]`,
384 "srcs": `[
385 "both.cpp",
386 "staticonly.cpp",
387 ]`,
388 "whole_archive_deps": `[
389 ":whole_static_lib_for_both",
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400390 ":whole_and_static_lib_for_both",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500391 ":whole_static_lib_for_static",
392 ]`}),
Alixe06d75b2022-08-31 18:28:19 +0000393 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500394 "copts": `[
395 "bothflag",
396 "sharedflag",
397 ]`,
398 "implementation_deps": `[
399 ":static_dep_for_both",
400 ":static_dep_for_shared",
401 ]`,
402 "implementation_dynamic_deps": `[
403 ":shared_dep_for_both",
404 ":shared_dep_for_shared",
405 ]`,
406 "srcs": `[
407 "both.cpp",
408 "sharedonly.cpp",
409 ]`,
410 "whole_archive_deps": `[
411 ":whole_static_lib_for_both",
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400412 ":whole_and_static_lib_for_both",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500413 ":whole_static_lib_for_shared",
414 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500415 }),
416 },
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200417 })
418}
419
Liz Kammer7a210ac2021-09-22 15:52:58 -0400420func TestCcLibraryDeps(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000421 runCcLibraryTestCase(t, Bp2buildTestCase{
422 Description: "cc_library shared/static props",
423 ModuleTypeUnderTest: "cc_library",
424 ModuleTypeUnderTestFactory: cc.LibraryFactory,
425 Filesystem: map[string]string{
Liz Kammer7a210ac2021-09-22 15:52:58 -0400426 "both.cpp": "",
427 "sharedonly.cpp": "",
428 "staticonly.cpp": "",
429 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000430 Blueprint: soongCcLibraryPreamble + `
Liz Kammer7a210ac2021-09-22 15:52:58 -0400431cc_library {
432 name: "a",
433 srcs: ["both.cpp"],
434 cflags: ["bothflag"],
435 shared_libs: ["implementation_shared_dep_for_both", "shared_dep_for_both"],
436 export_shared_lib_headers: ["shared_dep_for_both"],
437 static_libs: ["implementation_static_dep_for_both", "static_dep_for_both"],
438 export_static_lib_headers: ["static_dep_for_both", "whole_static_dep_for_both"],
439 whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_both", "whole_static_dep_for_both"],
440 static: {
441 srcs: ["staticonly.cpp"],
442 cflags: ["staticflag"],
443 shared_libs: ["implementation_shared_dep_for_static", "shared_dep_for_static"],
444 export_shared_lib_headers: ["shared_dep_for_static"],
445 static_libs: ["implementation_static_dep_for_static", "static_dep_for_static"],
446 export_static_lib_headers: ["static_dep_for_static", "whole_static_dep_for_static"],
447 whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_static", "whole_static_dep_for_static"],
448 },
449 shared: {
450 srcs: ["sharedonly.cpp"],
451 cflags: ["sharedflag"],
452 shared_libs: ["implementation_shared_dep_for_shared", "shared_dep_for_shared"],
453 export_shared_lib_headers: ["shared_dep_for_shared"],
454 static_libs: ["implementation_static_dep_for_shared", "static_dep_for_shared"],
455 export_static_lib_headers: ["static_dep_for_shared", "whole_static_dep_for_shared"],
456 whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_shared", "whole_static_dep_for_shared"],
457 },
458 include_build_directory: false,
459}
460` + simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_shared") +
461 simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_shared") +
462 simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_static") +
463 simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_static") +
464 simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_both") +
465 simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_both") +
466 simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_shared") +
467 simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_shared") +
468 simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_static") +
469 simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_static") +
470 simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_both") +
471 simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_both") +
472 simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_shared") +
473 simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_shared") +
474 simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_static") +
475 simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_static") +
476 simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_both") +
477 simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_both"),
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000478 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000479 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500480 "copts": `[
481 "bothflag",
482 "staticflag",
483 ]`,
484 "deps": `[
485 ":static_dep_for_both",
486 ":static_dep_for_static",
487 ]`,
488 "dynamic_deps": `[
489 ":shared_dep_for_both",
490 ":shared_dep_for_static",
491 ]`,
492 "implementation_deps": `[
493 ":implementation_static_dep_for_both",
494 ":implementation_static_dep_for_static",
495 ]`,
496 "implementation_dynamic_deps": `[
497 ":implementation_shared_dep_for_both",
498 ":implementation_shared_dep_for_static",
499 ]`,
500 "srcs": `[
501 "both.cpp",
502 "staticonly.cpp",
503 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500504 "whole_archive_deps": `[
Liz Kammer7a210ac2021-09-22 15:52:58 -0400505 ":not_explicitly_exported_whole_static_dep_for_both",
506 ":whole_static_dep_for_both",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500507 ":not_explicitly_exported_whole_static_dep_for_static",
508 ":whole_static_dep_for_static",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500509 ]`,
510 }),
Alixe06d75b2022-08-31 18:28:19 +0000511 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500512 "copts": `[
513 "bothflag",
514 "sharedflag",
515 ]`,
516 "deps": `[
517 ":static_dep_for_both",
518 ":static_dep_for_shared",
519 ]`,
520 "dynamic_deps": `[
521 ":shared_dep_for_both",
522 ":shared_dep_for_shared",
523 ]`,
524 "implementation_deps": `[
525 ":implementation_static_dep_for_both",
526 ":implementation_static_dep_for_shared",
527 ]`,
528 "implementation_dynamic_deps": `[
529 ":implementation_shared_dep_for_both",
530 ":implementation_shared_dep_for_shared",
531 ]`,
532 "srcs": `[
533 "both.cpp",
534 "sharedonly.cpp",
535 ]`,
536 "whole_archive_deps": `[
537 ":not_explicitly_exported_whole_static_dep_for_both",
538 ":whole_static_dep_for_both",
539 ":not_explicitly_exported_whole_static_dep_for_shared",
540 ":whole_static_dep_for_shared",
541 ]`,
542 })},
543 },
544 )
Liz Kammer7a210ac2021-09-22 15:52:58 -0400545}
546
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400547func TestCcLibraryWholeStaticLibsAlwaysLink(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000548 runCcLibraryTestCase(t, Bp2buildTestCase{
549 ModuleTypeUnderTest: "cc_library",
550 ModuleTypeUnderTestFactory: cc.LibraryFactory,
551 Dir: "foo/bar",
552 Filesystem: map[string]string{
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400553 "foo/bar/Android.bp": `
554cc_library {
555 name: "a",
556 whole_static_libs: ["whole_static_lib_for_both"],
557 static: {
558 whole_static_libs: ["whole_static_lib_for_static"],
559 },
560 shared: {
561 whole_static_libs: ["whole_static_lib_for_shared"],
562 },
563 bazel_module: { bp2build_available: true },
Liz Kammer8337ea42021-09-10 10:06:32 -0400564 include_build_directory: false,
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400565}
566
567cc_prebuilt_library_static { name: "whole_static_lib_for_shared" }
568
569cc_prebuilt_library_static { name: "whole_static_lib_for_static" }
570
571cc_prebuilt_library_static { name: "whole_static_lib_for_both" }
572`,
573 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000574 Blueprint: soongCcLibraryPreamble,
575 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000576 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500577 "whole_archive_deps": `[
578 ":whole_static_lib_for_both_alwayslink",
579 ":whole_static_lib_for_static_alwayslink",
580 ]`,
581 }),
Alixe06d75b2022-08-31 18:28:19 +0000582 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500583 "whole_archive_deps": `[
584 ":whole_static_lib_for_both_alwayslink",
585 ":whole_static_lib_for_shared_alwayslink",
586 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500587 }),
588 },
Chris Parsons77acf2e2021-12-03 17:27:16 -0500589 },
590 )
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400591}
592
Jingwen Chenbcf53042021-05-26 04:42:42 +0000593func TestCcLibrarySharedStaticPropsInArch(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000594 runCcLibraryTestCase(t, Bp2buildTestCase{
595 Description: "cc_library shared/static props in arch",
596 ModuleTypeUnderTest: "cc_library",
597 ModuleTypeUnderTestFactory: cc.LibraryFactory,
598 Dir: "foo/bar",
599 Filesystem: map[string]string{
Jingwen Chenbcf53042021-05-26 04:42:42 +0000600 "foo/bar/arm.cpp": "",
601 "foo/bar/x86.cpp": "",
602 "foo/bar/sharedonly.cpp": "",
603 "foo/bar/staticonly.cpp": "",
604 "foo/bar/Android.bp": `
605cc_library {
606 name: "a",
607 arch: {
608 arm: {
609 shared: {
610 srcs: ["arm_shared.cpp"],
611 cflags: ["-DARM_SHARED"],
612 static_libs: ["arm_static_dep_for_shared"],
613 whole_static_libs: ["arm_whole_static_dep_for_shared"],
614 shared_libs: ["arm_shared_dep_for_shared"],
615 },
616 },
617 x86: {
618 static: {
619 srcs: ["x86_static.cpp"],
620 cflags: ["-DX86_STATIC"],
621 static_libs: ["x86_dep_for_static"],
622 },
623 },
624 },
625 target: {
626 android: {
627 shared: {
628 srcs: ["android_shared.cpp"],
629 cflags: ["-DANDROID_SHARED"],
630 static_libs: ["android_dep_for_shared"],
631 },
632 },
633 android_arm: {
634 shared: {
635 cflags: ["-DANDROID_ARM_SHARED"],
636 },
637 },
638 },
639 srcs: ["both.cpp"],
640 cflags: ["bothflag"],
641 static_libs: ["static_dep_for_both"],
642 static: {
643 srcs: ["staticonly.cpp"],
644 cflags: ["staticflag"],
645 static_libs: ["static_dep_for_static"],
646 },
647 shared: {
648 srcs: ["sharedonly.cpp"],
649 cflags: ["sharedflag"],
650 static_libs: ["static_dep_for_shared"],
651 },
652 bazel_module: { bp2build_available: true },
653}
654
655cc_library_static { name: "static_dep_for_shared" }
656cc_library_static { name: "static_dep_for_static" }
657cc_library_static { name: "static_dep_for_both" }
658
659cc_library_static { name: "arm_static_dep_for_shared" }
660cc_library_static { name: "arm_whole_static_dep_for_shared" }
661cc_library_static { name: "arm_shared_dep_for_shared" }
662
663cc_library_static { name: "x86_dep_for_static" }
664
665cc_library_static { name: "android_dep_for_shared" }
666`,
667 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000668 Blueprint: soongCcLibraryPreamble,
669 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000670 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500671 "copts": `[
672 "bothflag",
673 "staticflag",
674 ] + select({
675 "//build/bazel/platforms/arch:x86": ["-DX86_STATIC"],
676 "//conditions:default": [],
677 })`,
678 "implementation_deps": `[
679 ":static_dep_for_both",
680 ":static_dep_for_static",
681 ] + select({
682 "//build/bazel/platforms/arch:x86": [":x86_dep_for_static"],
683 "//conditions:default": [],
684 })`,
685 "local_includes": `["."]`,
686 "srcs": `[
687 "both.cpp",
688 "staticonly.cpp",
689 ] + select({
690 "//build/bazel/platforms/arch:x86": ["x86_static.cpp"],
691 "//conditions:default": [],
692 })`,
693 }),
Alixe06d75b2022-08-31 18:28:19 +0000694 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500695 "copts": `[
696 "bothflag",
697 "sharedflag",
698 ] + select({
699 "//build/bazel/platforms/arch:arm": ["-DARM_SHARED"],
700 "//conditions:default": [],
701 }) + select({
702 "//build/bazel/platforms/os:android": ["-DANDROID_SHARED"],
703 "//conditions:default": [],
704 }) + select({
705 "//build/bazel/platforms/os_arch:android_arm": ["-DANDROID_ARM_SHARED"],
706 "//conditions:default": [],
707 })`,
708 "implementation_deps": `[
709 ":static_dep_for_both",
710 ":static_dep_for_shared",
711 ] + select({
712 "//build/bazel/platforms/arch:arm": [":arm_static_dep_for_shared"],
713 "//conditions:default": [],
714 }) + select({
715 "//build/bazel/platforms/os:android": [":android_dep_for_shared"],
716 "//conditions:default": [],
717 })`,
718 "implementation_dynamic_deps": `select({
719 "//build/bazel/platforms/arch:arm": [":arm_shared_dep_for_shared"],
720 "//conditions:default": [],
721 })`,
722 "local_includes": `["."]`,
723 "srcs": `[
724 "both.cpp",
725 "sharedonly.cpp",
726 ] + select({
727 "//build/bazel/platforms/arch:arm": ["arm_shared.cpp"],
728 "//conditions:default": [],
729 }) + select({
730 "//build/bazel/platforms/os:android": ["android_shared.cpp"],
731 "//conditions:default": [],
732 })`,
733 "whole_archive_deps": `select({
734 "//build/bazel/platforms/arch:arm": [":arm_whole_static_dep_for_shared"],
735 "//conditions:default": [],
736 })`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500737 }),
738 },
Chris Parsons77acf2e2021-12-03 17:27:16 -0500739 },
740 )
Jingwen Chenbcf53042021-05-26 04:42:42 +0000741}
742
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000743func TestCcLibrarySharedStaticPropsWithMixedSources(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000744 runCcLibraryTestCase(t, Bp2buildTestCase{
745 Description: "cc_library shared/static props with c/cpp/s mixed sources",
746 ModuleTypeUnderTest: "cc_library",
747 ModuleTypeUnderTestFactory: cc.LibraryFactory,
748 Dir: "foo/bar",
749 Filesystem: map[string]string{
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000750 "foo/bar/both_source.cpp": "",
751 "foo/bar/both_source.cc": "",
752 "foo/bar/both_source.c": "",
753 "foo/bar/both_source.s": "",
754 "foo/bar/both_source.S": "",
755 "foo/bar/shared_source.cpp": "",
756 "foo/bar/shared_source.cc": "",
757 "foo/bar/shared_source.c": "",
758 "foo/bar/shared_source.s": "",
759 "foo/bar/shared_source.S": "",
760 "foo/bar/static_source.cpp": "",
761 "foo/bar/static_source.cc": "",
762 "foo/bar/static_source.c": "",
763 "foo/bar/static_source.s": "",
764 "foo/bar/static_source.S": "",
765 "foo/bar/Android.bp": `
766cc_library {
767 name: "a",
768 srcs: [
Liz Kammerd366c902021-06-03 13:43:01 -0400769 "both_source.cpp",
770 "both_source.cc",
771 "both_source.c",
772 "both_source.s",
773 "both_source.S",
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400774 ":both_filegroup",
Liz Kammerd366c902021-06-03 13:43:01 -0400775 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000776 static: {
Liz Kammer8337ea42021-09-10 10:06:32 -0400777 srcs: [
778 "static_source.cpp",
779 "static_source.cc",
780 "static_source.c",
781 "static_source.s",
782 "static_source.S",
783 ":static_filegroup",
784 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000785 },
786 shared: {
Liz Kammer8337ea42021-09-10 10:06:32 -0400787 srcs: [
788 "shared_source.cpp",
789 "shared_source.cc",
790 "shared_source.c",
791 "shared_source.s",
792 "shared_source.S",
793 ":shared_filegroup",
794 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000795 },
796 bazel_module: { bp2build_available: true },
797}
798
799filegroup {
800 name: "both_filegroup",
801 srcs: [
802 // Not relevant, handled by filegroup macro
Liz Kammerd366c902021-06-03 13:43:01 -0400803 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000804}
805
806filegroup {
807 name: "shared_filegroup",
808 srcs: [
809 // Not relevant, handled by filegroup macro
Liz Kammerd366c902021-06-03 13:43:01 -0400810 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000811}
812
813filegroup {
814 name: "static_filegroup",
815 srcs: [
816 // Not relevant, handled by filegroup macro
Liz Kammerd366c902021-06-03 13:43:01 -0400817 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000818}
819`,
820 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000821 Blueprint: soongCcLibraryPreamble,
822 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000823 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500824 "local_includes": `["."]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500825 "srcs": `[
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000826 "both_source.cpp",
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400827 "both_source.cc",
828 ":both_filegroup_cpp_srcs",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500829 "static_source.cpp",
830 "static_source.cc",
831 ":static_filegroup_cpp_srcs",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500832 ]`,
833 "srcs_as": `[
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000834 "both_source.s",
835 "both_source.S",
836 ":both_filegroup_as_srcs",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500837 "static_source.s",
838 "static_source.S",
839 ":static_filegroup_as_srcs",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500840 ]`,
841 "srcs_c": `[
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000842 "both_source.c",
843 ":both_filegroup_c_srcs",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500844 "static_source.c",
845 ":static_filegroup_c_srcs",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500846 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500847 }),
Alixe06d75b2022-08-31 18:28:19 +0000848 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500849 "local_includes": `["."]`,
850 "srcs": `[
851 "both_source.cpp",
852 "both_source.cc",
853 ":both_filegroup_cpp_srcs",
854 "shared_source.cpp",
855 "shared_source.cc",
856 ":shared_filegroup_cpp_srcs",
857 ]`,
858 "srcs_as": `[
859 "both_source.s",
860 "both_source.S",
861 ":both_filegroup_as_srcs",
862 "shared_source.s",
863 "shared_source.S",
864 ":shared_filegroup_as_srcs",
865 ]`,
866 "srcs_c": `[
867 "both_source.c",
868 ":both_filegroup_c_srcs",
869 "shared_source.c",
870 ":shared_filegroup_c_srcs",
871 ]`,
872 })}})
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000873}
874
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000875func TestCcLibraryNonConfiguredVersionScriptAndDynamicList(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000876 runCcLibraryTestCase(t, Bp2buildTestCase{
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000877 Description: "cc_library non-configured version script and dynamic list",
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000878 ModuleTypeUnderTest: "cc_library",
879 ModuleTypeUnderTestFactory: cc.LibraryFactory,
880 Dir: "foo/bar",
881 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200882 "foo/bar/Android.bp": `
Lukacs T. Berki1353e592021-04-30 15:35:09 +0200883cc_library {
884 name: "a",
885 srcs: ["a.cpp"],
886 version_script: "v.map",
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000887 dynamic_list: "dynamic.list",
Lukacs T. Berki1353e592021-04-30 15:35:09 +0200888 bazel_module: { bp2build_available: true },
Liz Kammer8337ea42021-09-10 10:06:32 -0400889 include_build_directory: false,
Lukacs T. Berki1353e592021-04-30 15:35:09 +0200890}
891`,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200892 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000893 Blueprint: soongCcLibraryPreamble,
894 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000895 "additional_linker_inputs": `[
896 "v.map",
897 "dynamic.list",
898 ]`,
899 "linkopts": `[
900 "-Wl,--version-script,$(location v.map)",
901 "-Wl,--dynamic-list,$(location dynamic.list)",
902 ]`,
Trevor Radcliffef06dd912023-05-19 14:51:41 +0000903 "srcs": `["a.cpp"]`,
904 "features": `["android_cfi_exports_map"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500905 }),
906 },
907 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200908}
909
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000910func TestCcLibraryConfiguredVersionScriptAndDynamicList(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000911 runCcLibraryTestCase(t, Bp2buildTestCase{
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000912 Description: "cc_library configured version script and dynamic list",
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000913 ModuleTypeUnderTest: "cc_library",
914 ModuleTypeUnderTestFactory: cc.LibraryFactory,
915 Dir: "foo/bar",
916 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200917 "foo/bar/Android.bp": `
Liz Kammer8337ea42021-09-10 10:06:32 -0400918cc_library {
919 name: "a",
920 srcs: ["a.cpp"],
921 arch: {
922 arm: {
923 version_script: "arm.map",
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000924 dynamic_list: "dynamic_arm.list",
Liz Kammer8337ea42021-09-10 10:06:32 -0400925 },
926 arm64: {
927 version_script: "arm64.map",
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000928 dynamic_list: "dynamic_arm64.list",
Liz Kammer8337ea42021-09-10 10:06:32 -0400929 },
930 },
Lukacs T. Berki56bb0832021-05-12 12:36:45 +0200931
Liz Kammer8337ea42021-09-10 10:06:32 -0400932 bazel_module: { bp2build_available: true },
933 include_build_directory: false,
934}
Liz Kammerd366c902021-06-03 13:43:01 -0400935 `,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200936 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000937 Blueprint: soongCcLibraryPreamble,
938 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500939 "additional_linker_inputs": `select({
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000940 "//build/bazel/platforms/arch:arm": [
941 "arm.map",
942 "dynamic_arm.list",
943 ],
944 "//build/bazel/platforms/arch:arm64": [
945 "arm64.map",
946 "dynamic_arm64.list",
947 ],
Liz Kammerd2871182021-10-04 13:54:37 -0400948 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500949 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500950 "linkopts": `select({
Trevor Radcliffe82dd8552022-10-03 20:27:27 +0000951 "//build/bazel/platforms/arch:arm": [
952 "-Wl,--version-script,$(location arm.map)",
953 "-Wl,--dynamic-list,$(location dynamic_arm.list)",
954 ],
955 "//build/bazel/platforms/arch:arm64": [
956 "-Wl,--version-script,$(location arm64.map)",
957 "-Wl,--dynamic-list,$(location dynamic_arm64.list)",
958 ],
Liz Kammerd2871182021-10-04 13:54:37 -0400959 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500960 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500961 "srcs": `["a.cpp"]`,
Trevor Radcliffef06dd912023-05-19 14:51:41 +0000962 "features": `select({
963 "//build/bazel/platforms/arch:arm": ["android_cfi_exports_map"],
964 "//build/bazel/platforms/arch:arm64": ["android_cfi_exports_map"],
965 "//conditions:default": [],
966 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500967 }),
968 },
969 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200970}
971
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000972func TestCcLibraryLdflagsSplitBySpaceExceptSoongAdded(t *testing.T) {
973 runCcLibraryTestCase(t, Bp2buildTestCase{
974 Description: "ldflags are split by spaces except for the ones added by soong (version script and dynamic list)",
975 ModuleTypeUnderTest: "cc_library",
976 ModuleTypeUnderTestFactory: cc.LibraryFactory,
977 Filesystem: map[string]string{
978 "version_script": "",
979 "dynamic.list": "",
980 },
981 Blueprint: `
982cc_library {
983 name: "foo",
984 ldflags: [
985 "--nospace_flag",
986 "-z spaceflag",
987 ],
988 version_script: "version_script",
989 dynamic_list: "dynamic.list",
990 include_build_directory: false,
991}
992`,
993 ExpectedBazelTargets: []string{
Trevor Radcliffef06dd912023-05-19 14:51:41 +0000994 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
995 "features": `["android_cfi_exports_map"]`,
996 }),
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000997 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
998 "additional_linker_inputs": `[
999 "version_script",
1000 "dynamic.list",
1001 ]`,
Trevor Radcliffef06dd912023-05-19 14:51:41 +00001002 "features": `["android_cfi_exports_map"]`,
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +00001003 "linkopts": `[
1004 "--nospace_flag",
1005 "-z",
1006 "spaceflag",
1007 "-Wl,--version-script,$(location version_script)",
1008 "-Wl,--dynamic-list,$(location dynamic.list)",
1009 ]`,
1010 }),
1011 },
1012 })
1013}
1014
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +02001015func TestCcLibrarySharedLibs(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001016 runCcLibraryTestCase(t, Bp2buildTestCase{
1017 Description: "cc_library shared_libs",
1018 ModuleTypeUnderTest: "cc_library",
1019 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1020 Blueprint: soongCcLibraryPreamble + `
Rupert Shuttleworthc50fa8d2021-05-06 02:40:33 -04001021cc_library {
1022 name: "mylib",
Liz Kammer8337ea42021-09-10 10:06:32 -04001023 bazel_module: { bp2build_available: false },
Rupert Shuttleworthc50fa8d2021-05-06 02:40:33 -04001024}
1025
1026cc_library {
1027 name: "a",
1028 shared_libs: ["mylib",],
Liz Kammer8337ea42021-09-10 10:06:32 -04001029 include_build_directory: false,
Rupert Shuttleworthc50fa8d2021-05-06 02:40:33 -04001030}
1031`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001032 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001033 "implementation_dynamic_deps": `[":mylib"]`,
1034 }),
1035 },
1036 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +02001037}
1038
Liz Kammer0eae52e2021-10-06 10:32:26 -04001039func TestCcLibraryFeatures(t *testing.T) {
Chris Parsons77acf2e2021-12-03 17:27:16 -05001040 expected_targets := []string{}
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001041 expected_targets = append(expected_targets, makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001042 "features": `[
1043 "disable_pack_relocations",
1044 "-no_undefined_symbols",
1045 ]`,
Yu Liuf01a0f02022-12-07 15:45:30 -08001046 "native_coverage": `False`,
1047 "srcs": `["a.cpp"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001048 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001049 expected_targets = append(expected_targets, makeCcLibraryTargets("b", AttrNameToString{
Yu Liuf01a0f02022-12-07 15:45:30 -08001050 "features": `select({
Chris Parsons77acf2e2021-12-03 17:27:16 -05001051 "//build/bazel/platforms/arch:x86_64": [
1052 "disable_pack_relocations",
1053 "-no_undefined_symbols",
1054 ],
1055 "//conditions:default": [],
1056 })`,
Yu Liuf01a0f02022-12-07 15:45:30 -08001057 "native_coverage": `False`,
1058 "srcs": `["b.cpp"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001059 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001060 expected_targets = append(expected_targets, makeCcLibraryTargets("c", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001061 "features": `select({
1062 "//build/bazel/platforms/os:darwin": [
1063 "disable_pack_relocations",
1064 "-no_undefined_symbols",
1065 ],
1066 "//conditions:default": [],
1067 })`,
1068 "srcs": `["c.cpp"]`,
1069 })...)
1070
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001071 runCcLibraryTestCase(t, Bp2buildTestCase{
1072 Description: "cc_library pack_relocations test",
1073 ModuleTypeUnderTest: "cc_library",
1074 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1075 Blueprint: soongCcLibraryPreamble + `
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001076cc_library {
1077 name: "a",
1078 srcs: ["a.cpp"],
1079 pack_relocations: false,
Liz Kammer0eae52e2021-10-06 10:32:26 -04001080 allow_undefined_symbols: true,
Liz Kammer8337ea42021-09-10 10:06:32 -04001081 include_build_directory: false,
Yu Liu8d82ac52022-05-17 15:13:28 -07001082 native_coverage: false,
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001083}
1084
1085cc_library {
1086 name: "b",
1087 srcs: ["b.cpp"],
1088 arch: {
1089 x86_64: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001090 pack_relocations: false,
Liz Kammer0eae52e2021-10-06 10:32:26 -04001091 allow_undefined_symbols: true,
Liz Kammer8337ea42021-09-10 10:06:32 -04001092 },
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001093 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001094 include_build_directory: false,
Yu Liu8d82ac52022-05-17 15:13:28 -07001095 native_coverage: false,
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001096}
1097
1098cc_library {
1099 name: "c",
1100 srcs: ["c.cpp"],
1101 target: {
1102 darwin: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001103 pack_relocations: false,
Liz Kammer0eae52e2021-10-06 10:32:26 -04001104 allow_undefined_symbols: true,
Liz Kammer8337ea42021-09-10 10:06:32 -04001105 },
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001106 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001107 include_build_directory: false,
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001108}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001109 ExpectedBazelTargets: expected_targets,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +02001110 })
1111}
1112
1113func TestCcLibrarySpacesInCopts(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001114 runCcLibraryTestCase(t, Bp2buildTestCase{
1115 Description: "cc_library spaces in copts",
1116 ModuleTypeUnderTest: "cc_library",
1117 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1118 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen3950cd62021-05-12 04:33:00 +00001119cc_library {
1120 name: "a",
1121 cflags: ["-include header.h",],
Liz Kammer8337ea42021-09-10 10:06:32 -04001122 include_build_directory: false,
Jingwen Chen3950cd62021-05-12 04:33:00 +00001123}
1124`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001125 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001126 "copts": `[
Jingwen Chen3950cd62021-05-12 04:33:00 +00001127 "-include",
1128 "header.h",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001129 ]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001130 }),
1131 },
1132 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +02001133}
1134
1135func TestCcLibraryCppFlagsGoesIntoCopts(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001136 runCcLibraryTestCase(t, Bp2buildTestCase{
1137 Description: "cc_library cppflags usage",
1138 ModuleTypeUnderTest: "cc_library",
1139 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1140 Blueprint: soongCcLibraryPreamble + `cc_library {
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001141 name: "a",
1142 srcs: ["a.cpp"],
Liz Kammer8337ea42021-09-10 10:06:32 -04001143 cflags: ["-Wall"],
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001144 cppflags: [
1145 "-fsigned-char",
1146 "-pedantic",
Liz Kammer8337ea42021-09-10 10:06:32 -04001147 ],
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001148 arch: {
1149 arm64: {
1150 cppflags: ["-DARM64=1"],
Liz Kammer8337ea42021-09-10 10:06:32 -04001151 },
Liz Kammerd366c902021-06-03 13:43:01 -04001152 },
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001153 target: {
1154 android: {
1155 cppflags: ["-DANDROID=1"],
Liz Kammer8337ea42021-09-10 10:06:32 -04001156 },
Liz Kammerd366c902021-06-03 13:43:01 -04001157 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001158 include_build_directory: false,
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001159}
1160`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001161 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001162 "copts": `["-Wall"]`,
1163 "cppflags": `[
Chris Parsons990c4f42021-05-25 12:10:58 -04001164 "-fsigned-char",
1165 "-pedantic",
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001166 ] + select({
1167 "//build/bazel/platforms/arch:arm64": ["-DARM64=1"],
1168 "//conditions:default": [],
1169 }) + select({
1170 "//build/bazel/platforms/os:android": ["-DANDROID=1"],
1171 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001172 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001173 "srcs": `["a.cpp"]`,
1174 }),
1175 },
1176 )
Jingwen Chen63930982021-03-24 10:04:33 -04001177}
Rupert Shuttleworth22cd2eb2021-05-27 02:15:54 -04001178
Liz Kammer47535c52021-06-02 16:02:22 -04001179func TestCcLibraryExcludeLibs(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001180 runCcLibraryTestCase(t, Bp2buildTestCase{
1181 ModuleTypeUnderTest: "cc_library",
1182 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1183 Filesystem: map[string]string{},
1184 Blueprint: soongCcLibraryStaticPreamble + `
Liz Kammer47535c52021-06-02 16:02:22 -04001185cc_library {
1186 name: "foo_static",
1187 srcs: ["common.c"],
1188 whole_static_libs: [
1189 "arm_whole_static_lib_excludes",
1190 "malloc_not_svelte_whole_static_lib_excludes"
1191 ],
1192 static_libs: [
1193 "arm_static_lib_excludes",
1194 "malloc_not_svelte_static_lib_excludes"
1195 ],
1196 shared_libs: [
1197 "arm_shared_lib_excludes",
1198 ],
1199 arch: {
1200 arm: {
1201 exclude_shared_libs: [
1202 "arm_shared_lib_excludes",
1203 ],
1204 exclude_static_libs: [
1205 "arm_static_lib_excludes",
1206 "arm_whole_static_lib_excludes",
1207 ],
1208 },
1209 },
1210 product_variables: {
1211 malloc_not_svelte: {
1212 shared_libs: ["malloc_not_svelte_shared_lib"],
1213 whole_static_libs: ["malloc_not_svelte_whole_static_lib"],
1214 exclude_static_libs: [
1215 "malloc_not_svelte_static_lib_excludes",
1216 "malloc_not_svelte_whole_static_lib_excludes",
1217 ],
1218 },
1219 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001220 include_build_directory: false,
Liz Kammer47535c52021-06-02 16:02:22 -04001221}
1222
1223cc_library {
1224 name: "arm_whole_static_lib_excludes",
1225 bazel_module: { bp2build_available: false },
1226}
1227
1228cc_library {
1229 name: "malloc_not_svelte_whole_static_lib",
1230 bazel_module: { bp2build_available: false },
1231}
1232
1233cc_library {
1234 name: "malloc_not_svelte_whole_static_lib_excludes",
1235 bazel_module: { bp2build_available: false },
1236}
1237
1238cc_library {
1239 name: "arm_static_lib_excludes",
1240 bazel_module: { bp2build_available: false },
1241}
1242
1243cc_library {
1244 name: "malloc_not_svelte_static_lib_excludes",
1245 bazel_module: { bp2build_available: false },
1246}
1247
1248cc_library {
1249 name: "arm_shared_lib_excludes",
1250 bazel_module: { bp2build_available: false },
1251}
1252
1253cc_library {
1254 name: "malloc_not_svelte_shared_lib",
1255 bazel_module: { bp2build_available: false },
1256}
1257`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001258 ExpectedBazelTargets: makeCcLibraryTargets("foo_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001259 "implementation_deps": `select({
Liz Kammer47535c52021-06-02 16:02:22 -04001260 "//build/bazel/platforms/arch:arm": [],
Chris Parsons953b3562021-09-20 15:14:39 -04001261 "//conditions:default": [":arm_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer47535c52021-06-02 16:02:22 -04001262 }) + select({
Cole Faust87c0c332023-07-31 12:10:12 -07001263 "//build/bazel/product_config/config_settings:malloc_not_svelte": [],
Chris Parsons953b3562021-09-20 15:14:39 -04001264 "//conditions:default": [":malloc_not_svelte_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001265 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001266 "implementation_dynamic_deps": `select({
Liz Kammer7a210ac2021-09-22 15:52:58 -04001267 "//build/bazel/platforms/arch:arm": [],
1268 "//conditions:default": [":arm_shared_lib_excludes"],
1269 }) + select({
Cole Faust87c0c332023-07-31 12:10:12 -07001270 "//build/bazel/product_config/config_settings:malloc_not_svelte": [":malloc_not_svelte_shared_lib"],
Liz Kammer7a210ac2021-09-22 15:52:58 -04001271 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001272 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001273 "srcs_c": `["common.c"]`,
1274 "whole_archive_deps": `select({
Liz Kammer47535c52021-06-02 16:02:22 -04001275 "//build/bazel/platforms/arch:arm": [],
Chris Parsons953b3562021-09-20 15:14:39 -04001276 "//conditions:default": [":arm_whole_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer47535c52021-06-02 16:02:22 -04001277 }) + select({
Cole Faust87c0c332023-07-31 12:10:12 -07001278 "//build/bazel/product_config/config_settings:malloc_not_svelte": [":malloc_not_svelte_whole_static_lib_bp2build_cc_library_static"],
Chris Parsons953b3562021-09-20 15:14:39 -04001279 "//conditions:default": [":malloc_not_svelte_whole_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001280 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001281 }),
1282 },
1283 )
Liz Kammer47535c52021-06-02 16:02:22 -04001284}
Liz Kammerd366c902021-06-03 13:43:01 -04001285
Zi Wang0a8a1292022-08-30 06:27:01 +00001286func TestCcLibraryProductVariablesHeaderLibs(t *testing.T) {
1287 runCcLibraryTestCase(t, Bp2buildTestCase{
1288 ModuleTypeUnderTest: "cc_library",
1289 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1290 Filesystem: map[string]string{},
1291 Blueprint: soongCcLibraryStaticPreamble + `
1292cc_library {
1293 name: "foo_static",
1294 srcs: ["common.c"],
1295 product_variables: {
1296 malloc_not_svelte: {
1297 header_libs: ["malloc_not_svelte_header_lib"],
1298 },
1299 },
1300 include_build_directory: false,
1301}
1302
1303cc_library {
1304 name: "malloc_not_svelte_header_lib",
1305 bazel_module: { bp2build_available: false },
1306}
1307`,
1308 ExpectedBazelTargets: makeCcLibraryTargets("foo_static", AttrNameToString{
1309 "implementation_deps": `select({
Cole Faust87c0c332023-07-31 12:10:12 -07001310 "//build/bazel/product_config/config_settings:malloc_not_svelte": [":malloc_not_svelte_header_lib"],
Zi Wang0a8a1292022-08-30 06:27:01 +00001311 "//conditions:default": [],
1312 })`,
1313 "srcs_c": `["common.c"]`,
1314 "target_compatible_with": `["//build/bazel/platforms/os:android"]`,
1315 }),
1316 },
1317 )
1318}
1319
Liz Kammerd366c902021-06-03 13:43:01 -04001320func TestCCLibraryNoCrtTrue(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001321 runCcLibraryTestCase(t, Bp2buildTestCase{
Alex Márquez Pérez Muñíz Díaz Puras Thaureaux01ec55e2023-01-30 22:53:04 +00001322 Description: "cc_library - nocrt: true disables feature",
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001323 ModuleTypeUnderTest: "cc_library",
1324 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1325 Filesystem: map[string]string{
Jingwen Chen6ada5892021-09-17 11:38:09 +00001326 "impl.cpp": "",
1327 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001328 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen6ada5892021-09-17 11:38:09 +00001329cc_library {
1330 name: "foo-lib",
1331 srcs: ["impl.cpp"],
1332 nocrt: true,
1333 include_build_directory: false,
1334}
1335`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001336 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Puras Thaureaux01ec55e2023-01-30 22:53:04 +00001337 "features": `["-link_crt"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001338 "srcs": `["impl.cpp"]`,
1339 }),
1340 },
1341 )
Jingwen Chen6ada5892021-09-17 11:38:09 +00001342}
1343
1344func TestCCLibraryNoCrtFalse(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001345 runCcLibraryTestCase(t, Bp2buildTestCase{
1346 Description: "cc_library - nocrt: false - does not emit attribute",
1347 ModuleTypeUnderTest: "cc_library",
1348 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1349 Filesystem: map[string]string{
Jingwen Chen6ada5892021-09-17 11:38:09 +00001350 "impl.cpp": "",
1351 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001352 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen6ada5892021-09-17 11:38:09 +00001353cc_library {
1354 name: "foo-lib",
1355 srcs: ["impl.cpp"],
1356 nocrt: false,
1357 include_build_directory: false,
1358}
1359`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001360 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001361 "srcs": `["impl.cpp"]`,
1362 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001363 })
Jingwen Chen6ada5892021-09-17 11:38:09 +00001364}
1365
1366func TestCCLibraryNoCrtArchVariant(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001367 runCcLibraryTestCase(t, Bp2buildTestCase{
1368 Description: "cc_library - nocrt in select",
1369 ModuleTypeUnderTest: "cc_library",
1370 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1371 Filesystem: map[string]string{
Jingwen Chen6ada5892021-09-17 11:38:09 +00001372 "impl.cpp": "",
1373 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001374 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen6ada5892021-09-17 11:38:09 +00001375cc_library {
1376 name: "foo-lib",
1377 srcs: ["impl.cpp"],
1378 arch: {
1379 arm: {
1380 nocrt: true,
1381 },
1382 x86: {
1383 nocrt: false,
1384 },
1385 },
1386 include_build_directory: false,
1387}
1388`,
Alex Márquez Pérez Muñíz Díaz Puras Thaureaux01ec55e2023-01-30 22:53:04 +00001389 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
1390 "features": `select({
1391 "//build/bazel/platforms/arch:arm": ["-link_crt"],
1392 "//conditions:default": [],
1393 })`,
1394 "srcs": `["impl.cpp"]`,
1395 }),
Jingwen Chen6ada5892021-09-17 11:38:09 +00001396 })
1397}
1398
1399func TestCCLibraryNoLibCrtTrue(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001400 runCcLibraryTestCase(t, Bp2buildTestCase{
1401 ModuleTypeUnderTest: "cc_library",
1402 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1403 Filesystem: map[string]string{
Liz Kammerd366c902021-06-03 13:43:01 -04001404 "impl.cpp": "",
1405 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001406 Blueprint: soongCcLibraryPreamble + `
Liz Kammerd366c902021-06-03 13:43:01 -04001407cc_library {
1408 name: "foo-lib",
1409 srcs: ["impl.cpp"],
1410 no_libcrt: true,
Liz Kammer8337ea42021-09-10 10:06:32 -04001411 include_build_directory: false,
Liz Kammerd366c902021-06-03 13:43:01 -04001412}
1413`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001414 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Puras Thaureaux01ec55e2023-01-30 22:53:04 +00001415 "features": `["-use_libcrt"]`,
1416 "srcs": `["impl.cpp"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001417 }),
1418 })
1419}
1420
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001421func makeCcLibraryTargets(name string, attrs AttrNameToString) []string {
Chris Parsons77acf2e2021-12-03 17:27:16 -05001422 STATIC_ONLY_ATTRS := map[string]bool{}
1423 SHARED_ONLY_ATTRS := map[string]bool{
1424 "link_crt": true,
1425 "additional_linker_inputs": true,
1426 "linkopts": true,
1427 "strip": true,
Yu Liu75be7b92022-02-01 09:54:09 -08001428 "inject_bssl_hash": true,
Yu Liu56ccb1a2022-11-12 10:47:07 -08001429 "stubs_symbol_file": true,
Liz Kammerbaced712022-09-16 09:01:29 -04001430 "use_version_lib": true,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001431 }
Wei Li81852ca2022-07-27 00:22:06 -07001432
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001433 sharedAttrs := AttrNameToString{}
1434 staticAttrs := AttrNameToString{}
Chris Parsons77acf2e2021-12-03 17:27:16 -05001435 for key, val := range attrs {
1436 if _, staticOnly := STATIC_ONLY_ATTRS[key]; !staticOnly {
1437 sharedAttrs[key] = val
1438 }
1439 if _, sharedOnly := SHARED_ONLY_ATTRS[key]; !sharedOnly {
1440 staticAttrs[key] = val
1441 }
1442 }
Alixe06d75b2022-08-31 18:28:19 +00001443 sharedTarget := MakeBazelTarget("cc_library_shared", name, sharedAttrs)
1444 staticTarget := MakeBazelTarget("cc_library_static", name+"_bp2build_cc_library_static", staticAttrs)
Chris Parsons77acf2e2021-12-03 17:27:16 -05001445
1446 return []string{staticTarget, sharedTarget}
Liz Kammerd366c902021-06-03 13:43:01 -04001447}
1448
Jingwen Chen6ada5892021-09-17 11:38:09 +00001449func TestCCLibraryNoLibCrtFalse(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001450 runCcLibraryTestCase(t, Bp2buildTestCase{
1451 ModuleTypeUnderTest: "cc_library",
1452 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1453 Filesystem: map[string]string{
Liz Kammerd366c902021-06-03 13:43:01 -04001454 "impl.cpp": "",
1455 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001456 Blueprint: soongCcLibraryPreamble + `
Liz Kammerd366c902021-06-03 13:43:01 -04001457cc_library {
1458 name: "foo-lib",
1459 srcs: ["impl.cpp"],
1460 no_libcrt: false,
Liz Kammer8337ea42021-09-10 10:06:32 -04001461 include_build_directory: false,
Liz Kammerd366c902021-06-03 13:43:01 -04001462}
1463`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001464 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Puras Thaureaux01ec55e2023-01-30 22:53:04 +00001465 "srcs": `["impl.cpp"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001466 }),
1467 })
Liz Kammerd366c902021-06-03 13:43:01 -04001468}
1469
Jingwen Chen6ada5892021-09-17 11:38:09 +00001470func TestCCLibraryNoLibCrtArchVariant(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001471 runCcLibraryTestCase(t, Bp2buildTestCase{
1472 ModuleTypeUnderTest: "cc_library",
1473 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1474 Filesystem: map[string]string{
Liz Kammerd366c902021-06-03 13:43:01 -04001475 "impl.cpp": "",
1476 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001477 Blueprint: soongCcLibraryPreamble + `
Liz Kammerd366c902021-06-03 13:43:01 -04001478cc_library {
1479 name: "foo-lib",
1480 srcs: ["impl.cpp"],
1481 arch: {
1482 arm: {
1483 no_libcrt: true,
1484 },
1485 x86: {
1486 no_libcrt: true,
1487 },
1488 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001489 include_build_directory: false,
Liz Kammerd366c902021-06-03 13:43:01 -04001490}
1491`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001492 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001493 "srcs": `["impl.cpp"]`,
Alex Márquez Pérez Muñíz Díaz Puras Thaureaux01ec55e2023-01-30 22:53:04 +00001494 "features": `select({
1495 "//build/bazel/platforms/arch:arm": ["-use_libcrt"],
1496 "//build/bazel/platforms/arch:x86": ["-use_libcrt"],
1497 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001498 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001499 }),
1500 })
Liz Kammerd366c902021-06-03 13:43:01 -04001501}
1502
Chris Parsons58852a02021-12-09 18:10:18 -05001503func TestCCLibraryNoLibCrtArchAndTargetVariant(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001504 runCcLibraryTestCase(t, Bp2buildTestCase{
1505 ModuleTypeUnderTest: "cc_library",
1506 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1507 Filesystem: map[string]string{
Chris Parsons58852a02021-12-09 18:10:18 -05001508 "impl.cpp": "",
1509 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001510 Blueprint: soongCcLibraryPreamble + `
Chris Parsons58852a02021-12-09 18:10:18 -05001511cc_library {
1512 name: "foo-lib",
1513 srcs: ["impl.cpp"],
1514 arch: {
1515 arm: {
1516 no_libcrt: true,
1517 },
1518 x86: {
1519 no_libcrt: true,
1520 },
1521 },
1522 target: {
1523 darwin: {
1524 no_libcrt: true,
1525 }
1526 },
1527 include_build_directory: false,
1528}
1529`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001530 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Puras Thaureaux01ec55e2023-01-30 22:53:04 +00001531 "features": `select({
1532 "//build/bazel/platforms/arch:arm": ["-use_libcrt"],
1533 "//build/bazel/platforms/arch:x86": ["-use_libcrt"],
1534 "//conditions:default": [],
1535 }) + select({
1536 "//build/bazel/platforms/os:darwin": ["-use_libcrt"],
1537 "//conditions:default": [],
Chris Parsons58852a02021-12-09 18:10:18 -05001538 })`,
Alex Márquez Pérez Muñíz Díaz Puras Thaureaux01ec55e2023-01-30 22:53:04 +00001539 "srcs": `["impl.cpp"]`,
Chris Parsons58852a02021-12-09 18:10:18 -05001540 }),
1541 })
1542}
1543
1544func TestCCLibraryNoLibCrtArchAndTargetVariantConflict(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001545 runCcLibraryTestCase(t, Bp2buildTestCase{
1546 ModuleTypeUnderTest: "cc_library",
1547 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1548 Filesystem: map[string]string{
Chris Parsons58852a02021-12-09 18:10:18 -05001549 "impl.cpp": "",
1550 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001551 Blueprint: soongCcLibraryPreamble + `
Chris Parsons58852a02021-12-09 18:10:18 -05001552cc_library {
1553 name: "foo-lib",
1554 srcs: ["impl.cpp"],
1555 arch: {
1556 arm: {
1557 no_libcrt: true,
1558 },
1559 // This is expected to override the value for darwin_x86_64.
1560 x86_64: {
1561 no_libcrt: true,
1562 },
1563 },
1564 target: {
1565 darwin: {
1566 no_libcrt: false,
1567 }
1568 },
1569 include_build_directory: false,
1570}
1571`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001572 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05001573 "srcs": `["impl.cpp"]`,
Alex Márquez Pérez Muñíz Díaz Puras Thaureaux01ec55e2023-01-30 22:53:04 +00001574 "features": `select({
1575 "//build/bazel/platforms/arch:arm": ["-use_libcrt"],
1576 "//build/bazel/platforms/arch:x86_64": ["-use_libcrt"],
1577 "//conditions:default": [],
Chris Parsons58852a02021-12-09 18:10:18 -05001578 })`,
1579 }),
1580 })
1581}
1582
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001583func TestCcLibraryStrip(t *testing.T) {
Chris Parsons77acf2e2021-12-03 17:27:16 -05001584 expectedTargets := []string{}
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001585 expectedTargets = append(expectedTargets, makeCcLibraryTargets("all", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001586 "strip": `{
1587 "all": True,
1588 }`,
1589 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001590 expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001591 "strip": `{
1592 "keep_symbols": True,
1593 }`,
1594 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001595 expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols_and_debug_frame", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001596 "strip": `{
1597 "keep_symbols_and_debug_frame": True,
1598 }`,
1599 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001600 expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols_list", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001601 "strip": `{
1602 "keep_symbols_list": ["symbol"],
1603 }`,
1604 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001605 expectedTargets = append(expectedTargets, makeCcLibraryTargets("none", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001606 "strip": `{
1607 "none": True,
1608 }`,
1609 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001610 expectedTargets = append(expectedTargets, makeCcLibraryTargets("nothing", AttrNameToString{})...)
Chris Parsons77acf2e2021-12-03 17:27:16 -05001611
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001612 runCcLibraryTestCase(t, Bp2buildTestCase{
1613 Description: "cc_library strip args",
1614 ModuleTypeUnderTest: "cc_library",
1615 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1616 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001617cc_library {
1618 name: "nothing",
Liz Kammer8337ea42021-09-10 10:06:32 -04001619 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001620}
1621cc_library {
1622 name: "keep_symbols",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001623 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001624 keep_symbols: true,
1625 },
1626 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001627}
1628cc_library {
1629 name: "keep_symbols_and_debug_frame",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001630 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001631 keep_symbols_and_debug_frame: true,
1632 },
1633 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001634}
1635cc_library {
1636 name: "none",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001637 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001638 none: true,
1639 },
1640 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001641}
1642cc_library {
1643 name: "keep_symbols_list",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001644 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001645 keep_symbols_list: ["symbol"],
1646 },
1647 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001648}
1649cc_library {
1650 name: "all",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001651 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001652 all: true,
1653 },
1654 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001655}
1656`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001657 ExpectedBazelTargets: expectedTargets,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001658 })
1659}
1660
1661func TestCcLibraryStripWithArch(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001662 runCcLibraryTestCase(t, Bp2buildTestCase{
1663 Description: "cc_library strip args",
1664 ModuleTypeUnderTest: "cc_library",
1665 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1666 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001667cc_library {
1668 name: "multi-arch",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001669 target: {
1670 darwin: {
1671 strip: {
1672 keep_symbols_list: ["foo", "bar"]
1673 }
1674 },
1675 },
1676 arch: {
1677 arm: {
1678 strip: {
1679 keep_symbols_and_debug_frame: true,
1680 },
1681 },
1682 arm64: {
1683 strip: {
1684 keep_symbols: true,
1685 },
1686 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001687 },
1688 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001689}
1690`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001691 ExpectedBazelTargets: makeCcLibraryTargets("multi-arch", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001692 "strip": `{
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001693 "keep_symbols": select({
1694 "//build/bazel/platforms/arch:arm64": True,
1695 "//conditions:default": None,
1696 }),
1697 "keep_symbols_and_debug_frame": select({
1698 "//build/bazel/platforms/arch:arm": True,
1699 "//conditions:default": None,
1700 }),
1701 "keep_symbols_list": select({
1702 "//build/bazel/platforms/os:darwin": [
1703 "foo",
1704 "bar",
1705 ],
1706 "//conditions:default": [],
1707 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001708 }`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001709 }),
1710 },
1711 )
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001712}
Chris Parsons51f8c392021-08-03 21:01:05 -04001713
1714func TestCcLibrary_SystemSharedLibsRootEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001715 runCcLibraryTestCase(t, Bp2buildTestCase{
1716 Description: "cc_library system_shared_libs empty at root",
1717 ModuleTypeUnderTest: "cc_library",
1718 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1719 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001720cc_library {
1721 name: "root_empty",
Liz Kammer8337ea42021-09-10 10:06:32 -04001722 system_shared_libs: [],
1723 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001724}
1725`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001726 ExpectedBazelTargets: makeCcLibraryTargets("root_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001727 "system_dynamic_deps": `[]`,
1728 }),
1729 },
1730 )
Chris Parsons51f8c392021-08-03 21:01:05 -04001731}
1732
1733func TestCcLibrary_SystemSharedLibsStaticEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001734 runCcLibraryTestCase(t, Bp2buildTestCase{
1735 Description: "cc_library system_shared_libs empty for static variant",
1736 ModuleTypeUnderTest: "cc_library",
1737 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1738 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001739cc_library {
1740 name: "static_empty",
1741 static: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001742 system_shared_libs: [],
1743 },
1744 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001745}
1746`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001747 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001748 MakeBazelTarget("cc_library_static", "static_empty_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001749 "system_dynamic_deps": "[]",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001750 }),
Alixe06d75b2022-08-31 18:28:19 +00001751 MakeBazelTarget("cc_library_shared", "static_empty", AttrNameToString{}),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001752 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001753 })
1754}
1755
1756func TestCcLibrary_SystemSharedLibsSharedEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001757 runCcLibraryTestCase(t, Bp2buildTestCase{
1758 Description: "cc_library system_shared_libs empty for shared variant",
1759 ModuleTypeUnderTest: "cc_library",
1760 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1761 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001762cc_library {
1763 name: "shared_empty",
1764 shared: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001765 system_shared_libs: [],
1766 },
1767 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001768}
1769`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001770 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001771 MakeBazelTarget("cc_library_static", "shared_empty_bp2build_cc_library_static", AttrNameToString{}),
1772 MakeBazelTarget("cc_library_shared", "shared_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001773 "system_dynamic_deps": "[]",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001774 }),
1775 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001776 })
1777}
1778
1779func TestCcLibrary_SystemSharedLibsSharedBionicEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001780 runCcLibraryTestCase(t, Bp2buildTestCase{
1781 Description: "cc_library system_shared_libs empty for shared, bionic variant",
1782 ModuleTypeUnderTest: "cc_library",
1783 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1784 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001785cc_library {
1786 name: "shared_empty",
1787 target: {
1788 bionic: {
1789 shared: {
1790 system_shared_libs: [],
1791 }
1792 }
Liz Kammer8337ea42021-09-10 10:06:32 -04001793 },
1794 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001795}
1796`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001797 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001798 MakeBazelTarget("cc_library_static", "shared_empty_bp2build_cc_library_static", AttrNameToString{}),
1799 MakeBazelTarget("cc_library_shared", "shared_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001800 "system_dynamic_deps": "[]",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001801 }),
1802 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001803 })
1804}
1805
1806func TestCcLibrary_SystemSharedLibsLinuxBionicEmpty(t *testing.T) {
1807 // Note that this behavior is technically incorrect (it's a simplification).
1808 // The correct behavior would be if bp2build wrote `system_dynamic_deps = []`
1809 // only for linux_bionic, but `android` had `["libc", "libdl", "libm"].
1810 // b/195791252 tracks the fix.
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001811 runCcLibraryTestCase(t, Bp2buildTestCase{
1812 Description: "cc_library system_shared_libs empty for linux_bionic variant",
1813 ModuleTypeUnderTest: "cc_library",
1814 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1815 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001816cc_library {
Trevor Radcliffe0d1b4022022-12-12 22:26:34 +00001817 name: "libc_musl",
1818 bazel_module: { bp2build_available: false },
1819}
1820
1821cc_library {
Chris Parsons51f8c392021-08-03 21:01:05 -04001822 name: "target_linux_bionic_empty",
1823 target: {
1824 linux_bionic: {
1825 system_shared_libs: [],
1826 },
1827 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001828 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001829}
1830`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001831 ExpectedBazelTargets: makeCcLibraryTargets("target_linux_bionic_empty", AttrNameToString{
Trevor Radcliffe0d1b4022022-12-12 22:26:34 +00001832 "system_dynamic_deps": `select({
1833 "//build/bazel/platforms/os:linux_musl": [":libc_musl"],
1834 "//conditions:default": [],
1835 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001836 }),
1837 },
1838 )
Chris Parsons51f8c392021-08-03 21:01:05 -04001839}
1840
1841func TestCcLibrary_SystemSharedLibsBionicEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001842 runCcLibraryTestCase(t, Bp2buildTestCase{
1843 Description: "cc_library system_shared_libs empty for bionic variant",
1844 ModuleTypeUnderTest: "cc_library",
1845 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1846 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001847cc_library {
Trevor Radcliffe0d1b4022022-12-12 22:26:34 +00001848 name: "libc_musl",
1849 bazel_module: { bp2build_available: false },
1850}
1851
1852cc_library {
Chris Parsons51f8c392021-08-03 21:01:05 -04001853 name: "target_bionic_empty",
1854 target: {
1855 bionic: {
1856 system_shared_libs: [],
1857 },
1858 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001859 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001860}
1861`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001862 ExpectedBazelTargets: makeCcLibraryTargets("target_bionic_empty", AttrNameToString{
Trevor Radcliffe0d1b4022022-12-12 22:26:34 +00001863 "system_dynamic_deps": `select({
1864 "//build/bazel/platforms/os:linux_musl": [":libc_musl"],
1865 "//conditions:default": [],
1866 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001867 }),
1868 },
1869 )
Chris Parsons51f8c392021-08-03 21:01:05 -04001870}
1871
Trevor Radcliffe0d1b4022022-12-12 22:26:34 +00001872func TestCcLibrary_SystemSharedLibsMuslEmpty(t *testing.T) {
1873 runCcLibraryTestCase(t, Bp2buildTestCase{
1874 Description: "cc_library system_shared_lib empty for musl variant",
1875 ModuleTypeUnderTest: "cc_library",
1876 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1877 Blueprint: soongCcLibraryPreamble + `
1878cc_library {
1879 name: "libc_musl",
1880 bazel_module: { bp2build_available: false },
1881}
1882
1883cc_library {
1884 name: "target_musl_empty",
1885 target: {
1886 musl: {
1887 system_shared_libs: [],
1888 },
1889 },
1890 include_build_directory: false,
1891}
1892`,
1893 ExpectedBazelTargets: makeCcLibraryTargets("target_musl_empty", AttrNameToString{
1894 "system_dynamic_deps": `[]`,
1895 }),
1896 })
1897}
1898
1899func TestCcLibrary_SystemSharedLibsLinuxMuslEmpty(t *testing.T) {
1900 runCcLibraryTestCase(t, Bp2buildTestCase{
1901 Description: "cc_library system_shared_lib empty for linux_musl variant",
1902 ModuleTypeUnderTest: "cc_library",
1903 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1904 Blueprint: soongCcLibraryPreamble + `
1905cc_library {
1906 name: "libc_musl",
1907 bazel_module: { bp2build_available: false },
1908}
1909
1910cc_library {
1911 name: "target_linux_musl_empty",
1912 target: {
1913 linux_musl: {
1914 system_shared_libs: [],
1915 },
1916 },
1917 include_build_directory: false,
1918}
1919`,
1920 ExpectedBazelTargets: makeCcLibraryTargets("target_linux_musl_empty", AttrNameToString{
1921 "system_dynamic_deps": `[]`,
1922 }),
1923 })
1924}
Chris Parsons51f8c392021-08-03 21:01:05 -04001925func TestCcLibrary_SystemSharedLibsSharedAndRoot(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001926 runCcLibraryTestCase(t, Bp2buildTestCase{
1927 Description: "cc_library system_shared_libs set for shared and root",
1928 ModuleTypeUnderTest: "cc_library",
1929 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1930 Blueprint: soongCcLibraryPreamble + `
Liz Kammer8337ea42021-09-10 10:06:32 -04001931cc_library {
1932 name: "libc",
1933 bazel_module: { bp2build_available: false },
1934}
1935cc_library {
1936 name: "libm",
1937 bazel_module: { bp2build_available: false },
1938}
Chris Parsons51f8c392021-08-03 21:01:05 -04001939
1940cc_library {
1941 name: "foo",
1942 system_shared_libs: ["libc"],
1943 shared: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001944 system_shared_libs: ["libm"],
Chris Parsons51f8c392021-08-03 21:01:05 -04001945 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001946 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001947}
1948`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001949 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001950 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001951 "system_dynamic_deps": `[":libc"]`,
1952 }),
Alixe06d75b2022-08-31 18:28:19 +00001953 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001954 "system_dynamic_deps": `[
1955 ":libc",
1956 ":libm",
1957 ]`,
1958 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001959 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001960 })
1961}
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001962
1963func TestCcLibraryOsSelects(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001964 runCcLibraryTestCase(t, Bp2buildTestCase{
1965 Description: "cc_library - selects for all os targets",
1966 ModuleTypeUnderTest: "cc_library",
1967 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1968 Filesystem: map[string]string{},
1969 Blueprint: soongCcLibraryPreamble + `
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001970cc_library {
1971 name: "foo-lib",
1972 srcs: ["base.cpp"],
1973 target: {
1974 android: {
1975 srcs: ["android.cpp"],
1976 },
1977 linux: {
1978 srcs: ["linux.cpp"],
1979 },
1980 linux_glibc: {
1981 srcs: ["linux_glibc.cpp"],
1982 },
1983 darwin: {
1984 srcs: ["darwin.cpp"],
1985 },
1986 bionic: {
1987 srcs: ["bionic.cpp"],
1988 },
1989 linux_musl: {
1990 srcs: ["linux_musl.cpp"],
1991 },
1992 windows: {
1993 srcs: ["windows.cpp"],
1994 },
1995 },
1996 include_build_directory: false,
1997}
1998`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001999 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05002000 "srcs": `["base.cpp"] + select({
Chris Parsons2dde0cb2021-10-01 14:45:30 -04002001 "//build/bazel/platforms/os:android": [
Chris Parsons2dde0cb2021-10-01 14:45:30 -04002002 "linux.cpp",
Liz Kammer9bad9d62021-10-11 15:40:35 -04002003 "bionic.cpp",
Liz Kammerfdd72e62021-10-11 15:41:03 -04002004 "android.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -04002005 ],
2006 "//build/bazel/platforms/os:darwin": ["darwin.cpp"],
Chris Parsons2dde0cb2021-10-01 14:45:30 -04002007 "//build/bazel/platforms/os:linux_bionic": [
Chris Parsons2dde0cb2021-10-01 14:45:30 -04002008 "linux.cpp",
Liz Kammer9bad9d62021-10-11 15:40:35 -04002009 "bionic.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -04002010 ],
Colin Cross133782e2022-12-20 15:29:31 -08002011 "//build/bazel/platforms/os:linux_glibc": [
2012 "linux.cpp",
2013 "linux_glibc.cpp",
2014 ],
Chris Parsons2dde0cb2021-10-01 14:45:30 -04002015 "//build/bazel/platforms/os:linux_musl": [
Liz Kammer9bad9d62021-10-11 15:40:35 -04002016 "linux.cpp",
Liz Kammerfdd72e62021-10-11 15:41:03 -04002017 "linux_musl.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -04002018 ],
2019 "//build/bazel/platforms/os:windows": ["windows.cpp"],
2020 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05002021 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002022 }),
2023 },
2024 )
Jingwen Chen97b85312021-10-08 10:41:31 +00002025}
2026
Yu Liu75be7b92022-02-01 09:54:09 -08002027func TestLibcryptoHashInjection(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002028 runCcLibraryTestCase(t, Bp2buildTestCase{
2029 Description: "cc_library - libcrypto hash injection",
2030 ModuleTypeUnderTest: "cc_library",
2031 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2032 Filesystem: map[string]string{},
2033 Blueprint: soongCcLibraryPreamble + `
Yu Liu75be7b92022-02-01 09:54:09 -08002034cc_library {
2035 name: "libcrypto",
2036 target: {
2037 android: {
2038 inject_bssl_hash: true,
2039 },
2040 },
2041 include_build_directory: false,
2042}
2043`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002044 ExpectedBazelTargets: makeCcLibraryTargets("libcrypto", AttrNameToString{
Yu Liu75be7b92022-02-01 09:54:09 -08002045 "inject_bssl_hash": `select({
2046 "//build/bazel/platforms/os:android": True,
2047 "//conditions:default": None,
2048 })`,
2049 }),
2050 },
2051 )
2052}
2053
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002054func TestCcLibraryCppStdWithGnuExtensions_ConvertsToFeatureAttr(t *testing.T) {
Jingwen Chen97b85312021-10-08 10:41:31 +00002055 type testCase struct {
2056 cpp_std string
Chris Parsons79bd2b72021-11-29 17:52:41 -05002057 c_std string
Jingwen Chen97b85312021-10-08 10:41:31 +00002058 gnu_extensions string
2059 bazel_cpp_std string
Chris Parsons79bd2b72021-11-29 17:52:41 -05002060 bazel_c_std string
Jingwen Chen97b85312021-10-08 10:41:31 +00002061 }
2062
2063 testCases := []testCase{
2064 // Existing usages of cpp_std in AOSP are:
2065 // experimental, c++11, c++17, c++2a, c++98, gnu++11, gnu++17
2066 //
2067 // not set, only emit if gnu_extensions is disabled. the default (gnu+17
2068 // is set in the toolchain.)
2069 {cpp_std: "", gnu_extensions: "", bazel_cpp_std: ""},
Liz Kammera5a29de2022-05-25 23:19:37 -04002070 {cpp_std: "", gnu_extensions: "false", bazel_cpp_std: "cpp_std_default_no_gnu", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00002071 {cpp_std: "", gnu_extensions: "true", bazel_cpp_std: ""},
2072 // experimental defaults to gnu++2a
Liz Kammera5a29de2022-05-25 23:19:37 -04002073 {cpp_std: "experimental", gnu_extensions: "", bazel_cpp_std: "cpp_std_experimental"},
2074 {cpp_std: "experimental", gnu_extensions: "false", bazel_cpp_std: "cpp_std_experimental_no_gnu", bazel_c_std: "c_std_default_no_gnu"},
2075 {cpp_std: "experimental", gnu_extensions: "true", bazel_cpp_std: "cpp_std_experimental"},
Jingwen Chen97b85312021-10-08 10:41:31 +00002076 // Explicitly setting a c++ std does not use replace gnu++ std even if
2077 // gnu_extensions is true.
2078 // "c++11",
2079 {cpp_std: "c++11", gnu_extensions: "", bazel_cpp_std: "c++11"},
Liz Kammera5a29de2022-05-25 23:19:37 -04002080 {cpp_std: "c++11", gnu_extensions: "false", bazel_cpp_std: "c++11", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00002081 {cpp_std: "c++11", gnu_extensions: "true", bazel_cpp_std: "c++11"},
2082 // "c++17",
2083 {cpp_std: "c++17", gnu_extensions: "", bazel_cpp_std: "c++17"},
Liz Kammera5a29de2022-05-25 23:19:37 -04002084 {cpp_std: "c++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00002085 {cpp_std: "c++17", gnu_extensions: "true", bazel_cpp_std: "c++17"},
2086 // "c++2a",
2087 {cpp_std: "c++2a", gnu_extensions: "", bazel_cpp_std: "c++2a"},
Liz Kammera5a29de2022-05-25 23:19:37 -04002088 {cpp_std: "c++2a", gnu_extensions: "false", bazel_cpp_std: "c++2a", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00002089 {cpp_std: "c++2a", gnu_extensions: "true", bazel_cpp_std: "c++2a"},
2090 // "c++98",
2091 {cpp_std: "c++98", gnu_extensions: "", bazel_cpp_std: "c++98"},
Liz Kammera5a29de2022-05-25 23:19:37 -04002092 {cpp_std: "c++98", gnu_extensions: "false", bazel_cpp_std: "c++98", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00002093 {cpp_std: "c++98", gnu_extensions: "true", bazel_cpp_std: "c++98"},
2094 // gnu++ is replaced with c++ if gnu_extensions is explicitly false.
2095 // "gnu++11",
2096 {cpp_std: "gnu++11", gnu_extensions: "", bazel_cpp_std: "gnu++11"},
Liz Kammera5a29de2022-05-25 23:19:37 -04002097 {cpp_std: "gnu++11", gnu_extensions: "false", bazel_cpp_std: "c++11", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00002098 {cpp_std: "gnu++11", gnu_extensions: "true", bazel_cpp_std: "gnu++11"},
2099 // "gnu++17",
2100 {cpp_std: "gnu++17", gnu_extensions: "", bazel_cpp_std: "gnu++17"},
Liz Kammera5a29de2022-05-25 23:19:37 -04002101 {cpp_std: "gnu++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00002102 {cpp_std: "gnu++17", gnu_extensions: "true", bazel_cpp_std: "gnu++17"},
Chris Parsons79bd2b72021-11-29 17:52:41 -05002103
2104 // some c_std test cases
Liz Kammera5a29de2022-05-25 23:19:37 -04002105 {c_std: "experimental", gnu_extensions: "", bazel_c_std: "c_std_experimental"},
2106 {c_std: "experimental", gnu_extensions: "false", bazel_cpp_std: "cpp_std_default_no_gnu", bazel_c_std: "c_std_experimental_no_gnu"},
2107 {c_std: "experimental", gnu_extensions: "true", bazel_c_std: "c_std_experimental"},
Chris Parsons79bd2b72021-11-29 17:52:41 -05002108 {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "", bazel_cpp_std: "gnu++17", bazel_c_std: "gnu11"},
2109 {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c11"},
2110 {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "true", bazel_cpp_std: "gnu++17", bazel_c_std: "gnu11"},
Jingwen Chen97b85312021-10-08 10:41:31 +00002111 }
Chris Parsons79bd2b72021-11-29 17:52:41 -05002112 for i, tc := range testCases {
Liz Kammera5a29de2022-05-25 23:19:37 -04002113 name := fmt.Sprintf("cpp std: %q, c std: %q, gnu_extensions: %q", tc.cpp_std, tc.c_std, tc.gnu_extensions)
2114 t.Run(name, func(t *testing.T) {
2115 name_prefix := fmt.Sprintf("a_%v", i)
2116 cppStdProp := ""
2117 if tc.cpp_std != "" {
2118 cppStdProp = fmt.Sprintf(" cpp_std: \"%s\",", tc.cpp_std)
2119 }
2120 cStdProp := ""
2121 if tc.c_std != "" {
2122 cStdProp = fmt.Sprintf(" c_std: \"%s\",", tc.c_std)
2123 }
2124 gnuExtensionsProp := ""
2125 if tc.gnu_extensions != "" {
2126 gnuExtensionsProp = fmt.Sprintf(" gnu_extensions: %s,", tc.gnu_extensions)
2127 }
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002128 attrs := AttrNameToString{}
Liz Kammera5a29de2022-05-25 23:19:37 -04002129 if tc.bazel_cpp_std != "" {
2130 attrs["cpp_std"] = fmt.Sprintf(`"%s"`, tc.bazel_cpp_std)
2131 }
2132 if tc.bazel_c_std != "" {
2133 attrs["c_std"] = fmt.Sprintf(`"%s"`, tc.bazel_c_std)
2134 }
Jingwen Chen97b85312021-10-08 10:41:31 +00002135
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002136 runCcLibraryTestCase(t, Bp2buildTestCase{
2137 Description: fmt.Sprintf(
Liz Kammera5a29de2022-05-25 23:19:37 -04002138 "cc_library with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002139 ModuleTypeUnderTest: "cc_library",
2140 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2141 Blueprint: soongCcLibraryPreamble + fmt.Sprintf(`
Jingwen Chen97b85312021-10-08 10:41:31 +00002142cc_library {
Chris Parsons79bd2b72021-11-29 17:52:41 -05002143 name: "%s_full",
Jingwen Chen97b85312021-10-08 10:41:31 +00002144%s // cpp_std: *string
Chris Parsons79bd2b72021-11-29 17:52:41 -05002145%s // c_std: *string
Jingwen Chen97b85312021-10-08 10:41:31 +00002146%s // gnu_extensions: *bool
2147 include_build_directory: false,
2148}
Chris Parsons79bd2b72021-11-29 17:52:41 -05002149`, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002150 ExpectedBazelTargets: makeCcLibraryTargets(name_prefix+"_full", attrs),
Liz Kammera5a29de2022-05-25 23:19:37 -04002151 })
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002152
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002153 runCcLibraryStaticTestCase(t, Bp2buildTestCase{
2154 Description: fmt.Sprintf(
Liz Kammera5a29de2022-05-25 23:19:37 -04002155 "cc_library_static with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002156 ModuleTypeUnderTest: "cc_library_static",
2157 ModuleTypeUnderTestFactory: cc.LibraryStaticFactory,
2158 Blueprint: soongCcLibraryPreamble + fmt.Sprintf(`
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002159cc_library_static {
Chris Parsons79bd2b72021-11-29 17:52:41 -05002160 name: "%s_static",
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002161%s // cpp_std: *string
Chris Parsons79bd2b72021-11-29 17:52:41 -05002162%s // c_std: *string
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002163%s // gnu_extensions: *bool
2164 include_build_directory: false,
2165}
Chris Parsons79bd2b72021-11-29 17:52:41 -05002166`, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002167 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002168 MakeBazelTarget("cc_library_static", name_prefix+"_static", attrs),
Liz Kammera5a29de2022-05-25 23:19:37 -04002169 },
2170 })
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002171
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002172 runCcLibrarySharedTestCase(t, Bp2buildTestCase{
2173 Description: fmt.Sprintf(
Liz Kammera5a29de2022-05-25 23:19:37 -04002174 "cc_library_shared with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002175 ModuleTypeUnderTest: "cc_library_shared",
2176 ModuleTypeUnderTestFactory: cc.LibrarySharedFactory,
2177 Blueprint: soongCcLibraryPreamble + fmt.Sprintf(`
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002178cc_library_shared {
Chris Parsons79bd2b72021-11-29 17:52:41 -05002179 name: "%s_shared",
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002180%s // cpp_std: *string
Chris Parsons79bd2b72021-11-29 17:52:41 -05002181%s // c_std: *string
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002182%s // gnu_extensions: *bool
2183 include_build_directory: false,
2184}
Chris Parsons79bd2b72021-11-29 17:52:41 -05002185`, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002186 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002187 MakeBazelTarget("cc_library_shared", name_prefix+"_shared", attrs),
Liz Kammera5a29de2022-05-25 23:19:37 -04002188 },
2189 })
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002190 })
Jingwen Chen97b85312021-10-08 10:41:31 +00002191 }
Chris Parsons2dde0cb2021-10-01 14:45:30 -04002192}
Liz Kammer12615db2021-09-28 09:19:17 -04002193
2194func TestCcLibraryProtoSimple(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002195 runCcLibraryTestCase(t, Bp2buildTestCase{
2196 ModuleTypeUnderTest: "cc_library",
2197 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2198 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002199 name: "foo",
2200 srcs: ["foo.proto"],
2201 include_build_directory: false,
2202}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002203 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002204 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer7756c8f2022-02-14 20:49:15 -05002205 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002206 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002207 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002208 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002209 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002210 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002211 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002212 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2213 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002214 }),
2215 },
2216 })
2217}
2218
2219func TestCcLibraryProtoNoCanonicalPathFromRoot(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002220 runCcLibraryTestCase(t, Bp2buildTestCase{
2221 ModuleTypeUnderTest: "cc_library",
2222 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2223 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002224 name: "foo",
2225 srcs: ["foo.proto"],
2226 proto: { canonical_path_from_root: false},
2227 include_build_directory: false,
2228}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002229 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002230 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer7756c8f2022-02-14 20:49:15 -05002231 "srcs": `["foo.proto"]`,
2232 "strip_import_prefix": `""`,
Alixe06d75b2022-08-31 18:28:19 +00002233 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002234 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002235 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002236 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002237 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002238 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002239 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2240 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002241 }),
2242 },
2243 })
2244}
2245
2246func TestCcLibraryProtoExplicitCanonicalPathFromRoot(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002247 runCcLibraryTestCase(t, Bp2buildTestCase{
2248 ModuleTypeUnderTest: "cc_library",
2249 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2250 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002251 name: "foo",
2252 srcs: ["foo.proto"],
2253 proto: { canonical_path_from_root: true},
2254 include_build_directory: false,
2255}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002256 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002257 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer7756c8f2022-02-14 20:49:15 -05002258 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002259 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002260 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002261 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002262 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002263 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002264 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002265 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2266 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002267 }),
2268 },
2269 })
2270}
2271
2272func TestCcLibraryProtoFull(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002273 runCcLibraryTestCase(t, Bp2buildTestCase{
2274 ModuleTypeUnderTest: "cc_library",
2275 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2276 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002277 name: "foo",
2278 srcs: ["foo.proto"],
2279 proto: {
Liz Kammer12615db2021-09-28 09:19:17 -04002280 type: "full",
2281 },
2282 include_build_directory: false,
2283}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002284 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002285 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002286 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002287 }), MakeBazelTarget("cc_proto_library", "foo_cc_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002288 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002289 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002290 "implementation_whole_archive_deps": `[":foo_cc_proto"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002291 "deps": `[":libprotobuf-cpp-full"]`,
Alixe06d75b2022-08-31 18:28:19 +00002292 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002293 "dynamic_deps": `[":libprotobuf-cpp-full"]`,
2294 "implementation_whole_archive_deps": `[":foo_cc_proto"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002295 }),
2296 },
2297 })
2298}
2299
2300func TestCcLibraryProtoLite(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002301 runCcLibraryTestCase(t, Bp2buildTestCase{
2302 ModuleTypeUnderTest: "cc_library",
2303 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2304 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002305 name: "foo",
2306 srcs: ["foo.proto"],
2307 proto: {
Liz Kammer12615db2021-09-28 09:19:17 -04002308 type: "lite",
2309 },
2310 include_build_directory: false,
2311}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002312 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002313 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002314 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002315 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002316 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002317 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002318 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002319 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002320 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002321 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2322 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002323 }),
2324 },
2325 })
2326}
2327
2328func TestCcLibraryProtoExportHeaders(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002329 runCcLibraryTestCase(t, Bp2buildTestCase{
2330 ModuleTypeUnderTest: "cc_library",
2331 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2332 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002333 name: "foo",
2334 srcs: ["foo.proto"],
2335 proto: {
Liz Kammer12615db2021-09-28 09:19:17 -04002336 export_proto_headers: true,
2337 },
2338 include_build_directory: false,
2339}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002340 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002341 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002342 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002343 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002344 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002345 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05002346 "deps": `[":libprotobuf-cpp-lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002347 "whole_archive_deps": `[":foo_cc_proto_lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002348 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05002349 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2350 "whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002351 }),
2352 },
2353 })
2354}
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002355
Yu Liu2d136142022-08-18 14:46:13 -07002356func TestCcLibraryProtoIncludeDirs(t *testing.T) {
2357 runCcLibraryTestCase(t, Bp2buildTestCase{
2358 ModuleTypeUnderTest: "cc_library",
2359 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2360 Blueprint: soongCcProtoPreamble + `cc_library {
2361 name: "foo",
2362 srcs: ["foo.proto"],
2363 proto: {
2364 include_dirs: ["external/protobuf/src"],
2365 },
2366 include_build_directory: false,
2367}`,
2368 ExpectedBazelTargets: []string{
2369 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
2370 "srcs": `["foo.proto"]`,
2371 "deps": `["//external/protobuf:libprotobuf-proto"]`,
2372 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
2373 "deps": `[":foo_proto"]`,
2374 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
2375 "deps": `[":libprotobuf-cpp-lite"]`,
2376 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
2377 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002378 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2379 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Yu Liu2d136142022-08-18 14:46:13 -07002380 }),
2381 },
2382 })
2383}
2384
2385func TestCcLibraryProtoIncludeDirsUnknown(t *testing.T) {
2386 runCcLibraryTestCase(t, Bp2buildTestCase{
2387 ModuleTypeUnderTest: "cc_library",
2388 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2389 Blueprint: soongCcProtoPreamble + `cc_library {
2390 name: "foo",
2391 srcs: ["foo.proto"],
2392 proto: {
2393 include_dirs: ["external/protobuf/abc"],
2394 },
2395 include_build_directory: false,
2396}`,
Spandan Dasec39d512023-08-15 22:08:18 +00002397 ExpectedErr: fmt.Errorf("module \"foo\": TODO: Add support for proto.include_dir: external/protobuf/abc. This directory does not contain an Android.bp file"),
Yu Liu2d136142022-08-18 14:46:13 -07002398 })
2399}
2400
Yu Liu2aa806b2022-09-01 11:54:47 -07002401func TestCcLibraryConvertedProtoFilegroups(t *testing.T) {
2402 runCcLibraryTestCase(t, Bp2buildTestCase{
2403 ModuleTypeUnderTest: "cc_library",
2404 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2405 Blueprint: soongCcProtoPreamble + `
2406filegroup {
2407 name: "a_fg_proto",
2408 srcs: ["a_fg.proto"],
2409}
2410
2411cc_library {
2412 name: "a",
2413 srcs: [
2414 ":a_fg_proto",
2415 "a.proto",
2416 ],
2417 proto: {
2418 export_proto_headers: true,
2419 },
2420 include_build_directory: false,
2421}`,
2422 ExpectedBazelTargets: []string{
2423 MakeBazelTarget("proto_library", "a_proto", AttrNameToString{
Yu Liu2a85fb12022-09-15 22:18:48 -07002424 "deps": `[":a_fg_proto_bp2build_converted"]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002425 "srcs": `["a.proto"]`,
2426 }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
2427 "deps": `[
2428 ":a_fg_proto_bp2build_converted",
2429 ":a_proto",
2430 ]`,
2431 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
2432 "deps": `[":libprotobuf-cpp-lite"]`,
2433 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2434 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
2435 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2436 "whole_archive_deps": `[":a_cc_proto_lite"]`,
Spandan Dasdf3ec822023-08-04 02:19:53 +00002437 }), MakeBazelTargetNoRestrictions("proto_library", "a_fg_proto_proto", AttrNameToString{
Yu Liu2aa806b2022-09-01 11:54:47 -07002438 "srcs": `["a_fg.proto"]`,
Liz Kammer2b3f56e2023-03-23 11:51:49 -04002439 "tags": `[
2440 "apex_available=//apex_available:anyapex",
2441 "manual",
2442 ]`,
Spandan Dasdf3ec822023-08-04 02:19:53 +00002443 }), MakeBazelTargetNoRestrictions("alias", "a_fg_proto_bp2build_converted", AttrNameToString{
2444 "actual": `"//.:a_fg_proto_proto"`,
2445 "tags": `[
2446 "apex_available=//apex_available:anyapex",
2447 "manual",
2448 ]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002449 }), MakeBazelTargetNoRestrictions("filegroup", "a_fg_proto", AttrNameToString{
2450 "srcs": `["a_fg.proto"]`,
2451 }),
2452 },
2453 })
2454}
2455
2456func TestCcLibraryConvertedProtoFilegroupsNoProtoFiles(t *testing.T) {
2457 runCcLibraryTestCase(t, Bp2buildTestCase{
2458 ModuleTypeUnderTest: "cc_library",
2459 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2460 Blueprint: soongCcProtoPreamble + `
2461filegroup {
2462 name: "a_fg_proto",
2463 srcs: ["a_fg.proto"],
2464}
2465
2466cc_library {
2467 name: "a",
2468 srcs: [
2469 ":a_fg_proto",
2470 ],
2471 proto: {
2472 export_proto_headers: true,
2473 },
2474 include_build_directory: false,
2475}`,
2476 ExpectedBazelTargets: []string{
2477 MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
2478 "deps": `[":a_fg_proto_bp2build_converted"]`,
2479 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
2480 "deps": `[":libprotobuf-cpp-lite"]`,
2481 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2482 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
2483 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2484 "whole_archive_deps": `[":a_cc_proto_lite"]`,
Spandan Dasdf3ec822023-08-04 02:19:53 +00002485 }), MakeBazelTargetNoRestrictions("proto_library", "a_fg_proto_proto", AttrNameToString{
Yu Liu2aa806b2022-09-01 11:54:47 -07002486 "srcs": `["a_fg.proto"]`,
Liz Kammer2b3f56e2023-03-23 11:51:49 -04002487 "tags": `[
2488 "apex_available=//apex_available:anyapex",
2489 "manual",
2490 ]`,
Spandan Dasdf3ec822023-08-04 02:19:53 +00002491 }), MakeBazelTargetNoRestrictions("alias", "a_fg_proto_bp2build_converted", AttrNameToString{
2492 "actual": `"//.:a_fg_proto_proto"`,
2493 "tags": `[
2494 "apex_available=//apex_available:anyapex",
2495 "manual",
2496 ]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002497 }), MakeBazelTargetNoRestrictions("filegroup", "a_fg_proto", AttrNameToString{
2498 "srcs": `["a_fg.proto"]`,
2499 }),
2500 },
2501 })
2502}
2503
2504func TestCcLibraryExternalConvertedProtoFilegroups(t *testing.T) {
2505 runCcLibraryTestCase(t, Bp2buildTestCase{
2506 ModuleTypeUnderTest: "cc_library",
2507 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2508 Filesystem: map[string]string{
2509 "path/to/A/Android.bp": `
2510filegroup {
2511 name: "a_fg_proto",
2512 srcs: ["a_fg.proto"],
2513}`,
2514 },
2515 Blueprint: soongCcProtoPreamble + `
2516cc_library {
2517 name: "a",
2518 srcs: [
2519 ":a_fg_proto",
2520 "a.proto",
2521 ],
2522 proto: {
2523 export_proto_headers: true,
2524 },
2525 include_build_directory: false,
2526}`,
2527 ExpectedBazelTargets: []string{
2528 MakeBazelTarget("proto_library", "a_proto", AttrNameToString{
Yu Liu2a85fb12022-09-15 22:18:48 -07002529 "deps": `["//path/to/A:a_fg_proto_bp2build_converted"]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002530 "srcs": `["a.proto"]`,
2531 }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
2532 "deps": `[
2533 "//path/to/A:a_fg_proto_bp2build_converted",
2534 ":a_proto",
2535 ]`,
2536 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
2537 "deps": `[":libprotobuf-cpp-lite"]`,
2538 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2539 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
2540 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2541 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2542 }),
2543 },
2544 })
2545}
2546
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002547func TestCcLibraryProtoFilegroups(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002548 runCcLibraryTestCase(t, Bp2buildTestCase{
2549 ModuleTypeUnderTest: "cc_library",
2550 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2551 Blueprint: soongCcProtoPreamble +
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002552 simpleModuleDoNotConvertBp2build("filegroup", "a_fg_proto") +
2553 simpleModuleDoNotConvertBp2build("filegroup", "b_protos") +
2554 simpleModuleDoNotConvertBp2build("filegroup", "c-proto-srcs") +
2555 simpleModuleDoNotConvertBp2build("filegroup", "proto-srcs-d") + `
2556cc_library {
2557 name: "a",
2558 srcs: [":a_fg_proto"],
2559 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002560 export_proto_headers: true,
2561 },
2562 include_build_directory: false,
2563}
2564
2565cc_library {
2566 name: "b",
2567 srcs: [":b_protos"],
2568 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002569 export_proto_headers: true,
2570 },
2571 include_build_directory: false,
2572}
2573
2574cc_library {
2575 name: "c",
2576 srcs: [":c-proto-srcs"],
2577 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002578 export_proto_headers: true,
2579 },
2580 include_build_directory: false,
2581}
2582
2583cc_library {
2584 name: "d",
2585 srcs: [":proto-srcs-d"],
2586 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002587 export_proto_headers: true,
2588 },
2589 include_build_directory: false,
2590}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002591 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002592 MakeBazelTarget("proto_library", "a_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002593 "srcs": `[":a_fg_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002594 }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002595 "deps": `[":a_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002596 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002597 "deps": `[":libprotobuf-cpp-lite"]`,
2598 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2599 "srcs": `[":a_fg_proto_cpp_srcs"]`,
2600 "srcs_as": `[":a_fg_proto_as_srcs"]`,
2601 "srcs_c": `[":a_fg_proto_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002602 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002603 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2604 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2605 "srcs": `[":a_fg_proto_cpp_srcs"]`,
2606 "srcs_as": `[":a_fg_proto_as_srcs"]`,
2607 "srcs_c": `[":a_fg_proto_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002608 }), MakeBazelTarget("proto_library", "b_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002609 "srcs": `[":b_protos"]`,
Alixe06d75b2022-08-31 18:28:19 +00002610 }), MakeBazelTarget("cc_lite_proto_library", "b_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002611 "deps": `[":b_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002612 }), MakeBazelTarget("cc_library_static", "b_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002613 "deps": `[":libprotobuf-cpp-lite"]`,
2614 "whole_archive_deps": `[":b_cc_proto_lite"]`,
2615 "srcs": `[":b_protos_cpp_srcs"]`,
2616 "srcs_as": `[":b_protos_as_srcs"]`,
2617 "srcs_c": `[":b_protos_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002618 }), MakeBazelTarget("cc_library_shared", "b", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002619 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2620 "whole_archive_deps": `[":b_cc_proto_lite"]`,
2621 "srcs": `[":b_protos_cpp_srcs"]`,
2622 "srcs_as": `[":b_protos_as_srcs"]`,
2623 "srcs_c": `[":b_protos_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002624 }), MakeBazelTarget("proto_library", "c_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002625 "srcs": `[":c-proto-srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002626 }), MakeBazelTarget("cc_lite_proto_library", "c_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002627 "deps": `[":c_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002628 }), MakeBazelTarget("cc_library_static", "c_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002629 "deps": `[":libprotobuf-cpp-lite"]`,
2630 "whole_archive_deps": `[":c_cc_proto_lite"]`,
2631 "srcs": `[":c-proto-srcs_cpp_srcs"]`,
2632 "srcs_as": `[":c-proto-srcs_as_srcs"]`,
2633 "srcs_c": `[":c-proto-srcs_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002634 }), MakeBazelTarget("cc_library_shared", "c", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002635 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2636 "whole_archive_deps": `[":c_cc_proto_lite"]`,
2637 "srcs": `[":c-proto-srcs_cpp_srcs"]`,
2638 "srcs_as": `[":c-proto-srcs_as_srcs"]`,
2639 "srcs_c": `[":c-proto-srcs_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002640 }), MakeBazelTarget("proto_library", "d_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002641 "srcs": `[":proto-srcs-d"]`,
Alixe06d75b2022-08-31 18:28:19 +00002642 }), MakeBazelTarget("cc_lite_proto_library", "d_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002643 "deps": `[":d_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002644 }), MakeBazelTarget("cc_library_static", "d_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002645 "deps": `[":libprotobuf-cpp-lite"]`,
2646 "whole_archive_deps": `[":d_cc_proto_lite"]`,
2647 "srcs": `[":proto-srcs-d_cpp_srcs"]`,
2648 "srcs_as": `[":proto-srcs-d_as_srcs"]`,
2649 "srcs_c": `[":proto-srcs-d_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002650 }), MakeBazelTarget("cc_library_shared", "d", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002651 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2652 "whole_archive_deps": `[":d_cc_proto_lite"]`,
2653 "srcs": `[":proto-srcs-d_cpp_srcs"]`,
2654 "srcs_as": `[":proto-srcs-d_as_srcs"]`,
2655 "srcs_c": `[":proto-srcs-d_c_srcs"]`,
2656 }),
2657 },
2658 })
2659}
Chris Parsons58852a02021-12-09 18:10:18 -05002660
2661func TestCcLibraryDisabledArchAndTarget(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002662 runCcLibraryTestCase(t, Bp2buildTestCase{
2663 ModuleTypeUnderTest: "cc_library",
2664 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2665 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002666 name: "foo",
2667 srcs: ["foo.cpp"],
Liz Kammerdfeb1202022-05-13 17:20:20 -04002668 host_supported: true,
Chris Parsons58852a02021-12-09 18:10:18 -05002669 target: {
2670 darwin: {
2671 enabled: false,
2672 },
2673 windows: {
2674 enabled: false,
2675 },
2676 linux_glibc_x86: {
2677 enabled: false,
2678 },
2679 },
2680 include_build_directory: false,
2681}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002682 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002683 "srcs": `["foo.cpp"]`,
2684 "target_compatible_with": `select({
2685 "//build/bazel/platforms/os_arch:darwin_arm64": ["@platforms//:incompatible"],
2686 "//build/bazel/platforms/os_arch:darwin_x86_64": ["@platforms//:incompatible"],
2687 "//build/bazel/platforms/os_arch:linux_glibc_x86": ["@platforms//:incompatible"],
2688 "//build/bazel/platforms/os_arch:windows_x86": ["@platforms//:incompatible"],
2689 "//build/bazel/platforms/os_arch:windows_x86_64": ["@platforms//:incompatible"],
2690 "//conditions:default": [],
2691 })`,
2692 }),
2693 })
2694}
2695
2696func TestCcLibraryDisabledArchAndTargetWithDefault(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002697 runCcLibraryTestCase(t, Bp2buildTestCase{
2698 ModuleTypeUnderTest: "cc_library",
2699 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2700 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002701 name: "foo",
2702 srcs: ["foo.cpp"],
2703 enabled: false,
Liz Kammerdfeb1202022-05-13 17:20:20 -04002704 host_supported: true,
Chris Parsons58852a02021-12-09 18:10:18 -05002705 target: {
2706 darwin: {
2707 enabled: true,
2708 },
2709 windows: {
2710 enabled: false,
2711 },
2712 linux_glibc_x86: {
2713 enabled: false,
2714 },
2715 },
2716 include_build_directory: false,
2717}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002718 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002719 "srcs": `["foo.cpp"]`,
2720 "target_compatible_with": `select({
2721 "//build/bazel/platforms/os_arch:darwin_arm64": [],
2722 "//build/bazel/platforms/os_arch:darwin_x86_64": [],
2723 "//conditions:default": ["@platforms//:incompatible"],
2724 })`,
2725 }),
2726 })
2727}
2728
2729func TestCcLibrarySharedDisabled(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002730 runCcLibraryTestCase(t, Bp2buildTestCase{
2731 ModuleTypeUnderTest: "cc_library",
2732 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2733 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002734 name: "foo",
2735 srcs: ["foo.cpp"],
2736 enabled: false,
2737 shared: {
2738 enabled: true,
2739 },
2740 target: {
2741 android: {
2742 shared: {
2743 enabled: false,
2744 },
2745 }
2746 },
2747 include_build_directory: false,
2748}`,
Alixe06d75b2022-08-31 18:28:19 +00002749 ExpectedBazelTargets: []string{MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002750 "srcs": `["foo.cpp"]`,
2751 "target_compatible_with": `["@platforms//:incompatible"]`,
Alixe06d75b2022-08-31 18:28:19 +00002752 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002753 "srcs": `["foo.cpp"]`,
2754 "target_compatible_with": `select({
2755 "//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
2756 "//conditions:default": [],
2757 })`,
2758 }),
2759 },
2760 })
2761}
2762
2763func TestCcLibraryStaticDisabledForSomeArch(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002764 runCcLibraryTestCase(t, Bp2buildTestCase{
2765 ModuleTypeUnderTest: "cc_library",
2766 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2767 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002768 name: "foo",
Liz Kammerdfeb1202022-05-13 17:20:20 -04002769 host_supported: true,
Chris Parsons58852a02021-12-09 18:10:18 -05002770 srcs: ["foo.cpp"],
2771 shared: {
2772 enabled: false
2773 },
2774 target: {
2775 darwin: {
2776 enabled: true,
2777 },
2778 windows: {
2779 enabled: false,
2780 },
2781 linux_glibc_x86: {
2782 shared: {
2783 enabled: true,
2784 },
2785 },
2786 },
2787 include_build_directory: false,
2788}`,
Alixe06d75b2022-08-31 18:28:19 +00002789 ExpectedBazelTargets: []string{MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002790 "srcs": `["foo.cpp"]`,
2791 "target_compatible_with": `select({
2792 "//build/bazel/platforms/os:windows": ["@platforms//:incompatible"],
2793 "//conditions:default": [],
2794 })`,
Alixe06d75b2022-08-31 18:28:19 +00002795 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002796 "srcs": `["foo.cpp"]`,
2797 "target_compatible_with": `select({
2798 "//build/bazel/platforms/os_arch:darwin_arm64": [],
2799 "//build/bazel/platforms/os_arch:darwin_x86_64": [],
2800 "//build/bazel/platforms/os_arch:linux_glibc_x86": [],
2801 "//conditions:default": ["@platforms//:incompatible"],
2802 })`,
2803 }),
2804 }})
2805}
Jingwen Chen0ee88a62022-01-07 14:55:29 +00002806
2807func TestCcLibraryStubs(t *testing.T) {
Wei Li81852ca2022-07-27 00:22:06 -07002808 expectedBazelTargets := makeCcLibraryTargets("a", AttrNameToString{
Yu Liu56ccb1a2022-11-12 10:47:07 -08002809 "stubs_symbol_file": `"a.map.txt"`,
Wei Li81852ca2022-07-27 00:22:06 -07002810 })
2811 expectedBazelTargets = append(expectedBazelTargets, makeCcStubSuiteTargets("a", AttrNameToString{
Sam Delmerico5f906492023-03-15 18:06:18 -04002812 "soname": `"a.so"`,
2813 "source_library_label": `"//foo/bar:a"`,
2814 "stubs_symbol_file": `"a.map.txt"`,
Wei Li81852ca2022-07-27 00:22:06 -07002815 "stubs_versions": `[
2816 "28",
2817 "29",
2818 "current",
2819 ]`,
2820 }))
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002821 runCcLibraryTestCase(t, Bp2buildTestCase{
2822 Description: "cc_library stubs",
2823 ModuleTypeUnderTest: "cc_library",
2824 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2825 Dir: "foo/bar",
2826 Filesystem: map[string]string{
Jingwen Chen0ee88a62022-01-07 14:55:29 +00002827 "foo/bar/Android.bp": `
2828cc_library {
2829 name: "a",
2830 stubs: { symbol_file: "a.map.txt", versions: ["28", "29", "current"] },
2831 bazel_module: { bp2build_available: true },
2832 include_build_directory: false,
2833}
2834`,
2835 },
Wei Li81852ca2022-07-27 00:22:06 -07002836 Blueprint: soongCcLibraryPreamble,
2837 ExpectedBazelTargets: expectedBazelTargets,
Jingwen Chen0ee88a62022-01-07 14:55:29 +00002838 },
2839 )
2840}
Liz Kammerf38a8372022-02-04 15:39:00 -05002841
Trevor Radcliffe0ed6b7d2022-09-12 20:19:26 +00002842func TestCcLibraryStubsAcrossConfigsDuplicatesRemoved(t *testing.T) {
2843 runCcLibraryTestCase(t, Bp2buildTestCase{
2844 Description: "stub target generation of the same lib across configs should not result in duplicates",
2845 ModuleTypeUnderTest: "cc_library",
2846 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2847 Filesystem: map[string]string{
2848 "bar.map.txt": "",
2849 },
2850 Blueprint: `
2851cc_library {
2852 name: "barlib",
2853 stubs: { symbol_file: "bar.map.txt", versions: ["28", "29", "current"] },
2854 bazel_module: { bp2build_available: false },
2855}
2856cc_library {
2857 name: "foolib",
2858 shared_libs: ["barlib"],
2859 target: {
2860 android: {
2861 shared_libs: ["barlib"],
2862 },
2863 },
2864 bazel_module: { bp2build_available: true },
Liz Kammer48cdbeb2023-03-17 10:17:50 -04002865 apex_available: ["foo"],
Trevor Radcliffe0ed6b7d2022-09-12 20:19:26 +00002866}`,
2867 ExpectedBazelTargets: makeCcLibraryTargets("foolib", AttrNameToString{
2868 "implementation_dynamic_deps": `select({
Spandan Das6d4d9da2023-04-18 06:20:40 +00002869 "//build/bazel/rules/apex:foo": ["@api_surfaces//module-libapi/current:barlib"],
2870 "//build/bazel/rules/apex:system": ["@api_surfaces//module-libapi/current:barlib"],
Trevor Radcliffe0ed6b7d2022-09-12 20:19:26 +00002871 "//conditions:default": [":barlib"],
2872 })`,
2873 "local_includes": `["."]`,
Liz Kammer48cdbeb2023-03-17 10:17:50 -04002874 "tags": `["apex_available=foo"]`,
Trevor Radcliffe0ed6b7d2022-09-12 20:19:26 +00002875 }),
2876 })
2877}
2878
Liz Kammerffc17e42022-11-23 09:42:05 -05002879func TestCcLibraryExcludesLibsHost(t *testing.T) {
2880 runCcLibraryTestCase(t, Bp2buildTestCase{
2881 ModuleTypeUnderTest: "cc_library",
2882 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2883 Filesystem: map[string]string{
2884 "bar.map.txt": "",
2885 },
2886 Blueprint: simpleModuleDoNotConvertBp2build("cc_library", "bazlib") + `
2887cc_library {
2888 name: "quxlib",
2889 stubs: { symbol_file: "bar.map.txt", versions: ["current"] },
2890 bazel_module: { bp2build_available: false },
2891}
2892cc_library {
2893 name: "barlib",
2894 stubs: { symbol_file: "bar.map.txt", versions: ["28", "29", "current"] },
2895 bazel_module: { bp2build_available: false },
2896}
2897cc_library {
2898 name: "foolib",
2899 shared_libs: ["barlib", "quxlib"],
2900 target: {
2901 host: {
2902 shared_libs: ["bazlib"],
2903 exclude_shared_libs: ["barlib"],
2904 },
2905 },
2906 include_build_directory: false,
2907 bazel_module: { bp2build_available: true },
Liz Kammer48cdbeb2023-03-17 10:17:50 -04002908 apex_available: ["foo"],
Liz Kammerffc17e42022-11-23 09:42:05 -05002909}`,
2910 ExpectedBazelTargets: makeCcLibraryTargets("foolib", AttrNameToString{
2911 "implementation_dynamic_deps": `select({
2912 "//build/bazel/platforms/os:darwin": [":bazlib"],
Liz Kammerffc17e42022-11-23 09:42:05 -05002913 "//build/bazel/platforms/os:linux_bionic": [":bazlib"],
Colin Cross133782e2022-12-20 15:29:31 -08002914 "//build/bazel/platforms/os:linux_glibc": [":bazlib"],
Liz Kammerffc17e42022-11-23 09:42:05 -05002915 "//build/bazel/platforms/os:linux_musl": [":bazlib"],
2916 "//build/bazel/platforms/os:windows": [":bazlib"],
2917 "//conditions:default": [],
2918 }) + select({
2919 "//build/bazel/platforms/os:darwin": [":quxlib"],
Liz Kammerffc17e42022-11-23 09:42:05 -05002920 "//build/bazel/platforms/os:linux_bionic": [":quxlib"],
Colin Cross133782e2022-12-20 15:29:31 -08002921 "//build/bazel/platforms/os:linux_glibc": [":quxlib"],
Liz Kammerffc17e42022-11-23 09:42:05 -05002922 "//build/bazel/platforms/os:linux_musl": [":quxlib"],
2923 "//build/bazel/platforms/os:windows": [":quxlib"],
Spandan Das6d4d9da2023-04-18 06:20:40 +00002924 "//build/bazel/rules/apex:foo": [
2925 "@api_surfaces//module-libapi/current:barlib",
2926 "@api_surfaces//module-libapi/current:quxlib",
2927 ],
2928 "//build/bazel/rules/apex:system": [
Spandan Das2518c022023-03-17 03:02:32 +00002929 "@api_surfaces//module-libapi/current:barlib",
2930 "@api_surfaces//module-libapi/current:quxlib",
Liz Kammerffc17e42022-11-23 09:42:05 -05002931 ],
2932 "//conditions:default": [
2933 ":barlib",
2934 ":quxlib",
2935 ],
2936 })`,
Liz Kammer48cdbeb2023-03-17 10:17:50 -04002937 "tags": `["apex_available=foo"]`,
Liz Kammerffc17e42022-11-23 09:42:05 -05002938 }),
2939 })
2940}
2941
Liz Kammerf38a8372022-02-04 15:39:00 -05002942func TestCcLibraryEscapeLdflags(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002943 runCcLibraryTestCase(t, Bp2buildTestCase{
2944 ModuleTypeUnderTest: "cc_library",
2945 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2946 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammerf38a8372022-02-04 15:39:00 -05002947 name: "foo",
2948 ldflags: ["-Wl,--rpath,${ORIGIN}"],
2949 include_build_directory: false,
2950}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002951 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
Liz Kammerf38a8372022-02-04 15:39:00 -05002952 "linkopts": `["-Wl,--rpath,$${ORIGIN}"]`,
2953 }),
2954 })
2955}
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002956
2957func TestCcLibraryConvertLex(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002958 runCcLibraryTestCase(t, Bp2buildTestCase{
2959 ModuleTypeUnderTest: "cc_library",
2960 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2961 Filesystem: map[string]string{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002962 "foo.c": "",
2963 "bar.cc": "",
2964 "foo1.l": "",
2965 "bar1.ll": "",
2966 "foo2.l": "",
2967 "bar2.ll": "",
2968 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002969 Blueprint: `cc_library {
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002970 name: "foo_lib",
2971 srcs: ["foo.c", "bar.cc", "foo1.l", "foo2.l", "bar1.ll", "bar2.ll"],
2972 lex: { flags: ["--foo_flags"] },
2973 include_build_directory: false,
2974 bazel_module: { bp2build_available: true },
2975}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002976 ExpectedBazelTargets: append([]string{
Alixe06d75b2022-08-31 18:28:19 +00002977 MakeBazelTarget("genlex", "foo_lib_genlex_l", AttrNameToString{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002978 "srcs": `[
2979 "foo1.l",
2980 "foo2.l",
2981 ]`,
2982 "lexopts": `["--foo_flags"]`,
2983 }),
Alixe06d75b2022-08-31 18:28:19 +00002984 MakeBazelTarget("genlex", "foo_lib_genlex_ll", AttrNameToString{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002985 "srcs": `[
2986 "bar1.ll",
2987 "bar2.ll",
2988 ]`,
2989 "lexopts": `["--foo_flags"]`,
2990 }),
2991 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002992 makeCcLibraryTargets("foo_lib", AttrNameToString{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002993 "srcs": `[
2994 "bar.cc",
2995 ":foo_lib_genlex_ll",
2996 ]`,
2997 "srcs_c": `[
2998 "foo.c",
2999 ":foo_lib_genlex_l",
3000 ]`,
3001 })...),
3002 })
3003}
Cole Faust6b29f592022-08-09 09:50:56 -07003004
3005func TestCCLibraryRuntimeDeps(t *testing.T) {
3006 runCcLibrarySharedTestCase(t, Bp2buildTestCase{
3007 Blueprint: `cc_library_shared {
3008 name: "bar",
3009}
3010
3011cc_library {
3012 name: "foo",
3013 runtime_libs: ["foo"],
3014}`,
3015 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00003016 MakeBazelTarget("cc_library_shared", "bar", AttrNameToString{
Cole Faust6b29f592022-08-09 09:50:56 -07003017 "local_includes": `["."]`,
3018 }),
Alixe06d75b2022-08-31 18:28:19 +00003019 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Cole Faust6b29f592022-08-09 09:50:56 -07003020 "runtime_deps": `[":foo"]`,
3021 "local_includes": `["."]`,
3022 }),
Alixe06d75b2022-08-31 18:28:19 +00003023 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Cole Faust6b29f592022-08-09 09:50:56 -07003024 "runtime_deps": `[":foo"]`,
3025 "local_includes": `["."]`,
3026 }),
3027 },
3028 })
3029}
Cole Faust5fa4e962022-08-22 14:31:04 -07003030
3031func TestCcLibraryWithInstructionSet(t *testing.T) {
3032 runCcLibraryTestCase(t, Bp2buildTestCase{
3033 ModuleTypeUnderTest: "cc_library",
3034 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3035 Blueprint: `cc_library {
3036 name: "foo",
3037 arch: {
3038 arm: {
3039 instruction_set: "arm",
3040 }
3041 }
3042}
3043`,
3044 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
3045 "features": `select({
Trevor Radcliffe5f0c2ac2023-05-15 18:00:59 +00003046 "//build/bazel/platforms/arch:arm": ["arm_isa_arm"],
Cole Faust5fa4e962022-08-22 14:31:04 -07003047 "//conditions:default": [],
3048 })`,
3049 "local_includes": `["."]`,
3050 }),
3051 })
3052}
Vinh Tran9f6796a2022-08-16 13:10:31 -04003053
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05003054func TestCcLibraryEmptySuffix(t *testing.T) {
3055 runCcLibraryTestCase(t, Bp2buildTestCase{
3056 Description: "cc_library with empty suffix",
3057 ModuleTypeUnderTest: "cc_library",
3058 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3059 Filesystem: map[string]string{
3060 "foo.c": "",
3061 },
3062 Blueprint: `cc_library {
3063 name: "foo",
3064 suffix: "",
3065 srcs: ["foo.c"],
3066 include_build_directory: false,
3067}`,
3068 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00003069 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05003070 "srcs_c": `["foo.c"]`,
3071 }),
Alixe06d75b2022-08-31 18:28:19 +00003072 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05003073 "srcs_c": `["foo.c"]`,
3074 "suffix": `""`,
3075 }),
3076 },
3077 })
3078}
3079
3080func TestCcLibrarySuffix(t *testing.T) {
3081 runCcLibraryTestCase(t, Bp2buildTestCase{
3082 Description: "cc_library with suffix",
3083 ModuleTypeUnderTest: "cc_library",
3084 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3085 Filesystem: map[string]string{
3086 "foo.c": "",
3087 },
3088 Blueprint: `cc_library {
3089 name: "foo",
3090 suffix: "-suf",
3091 srcs: ["foo.c"],
3092 include_build_directory: false,
3093}`,
3094 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00003095 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05003096 "srcs_c": `["foo.c"]`,
3097 }),
Alixe06d75b2022-08-31 18:28:19 +00003098 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05003099 "srcs_c": `["foo.c"]`,
3100 "suffix": `"-suf"`,
3101 }),
3102 },
3103 })
3104}
3105
3106func TestCcLibraryArchVariantSuffix(t *testing.T) {
3107 runCcLibraryTestCase(t, Bp2buildTestCase{
3108 Description: "cc_library with arch-variant suffix",
3109 ModuleTypeUnderTest: "cc_library",
3110 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3111 Filesystem: map[string]string{
3112 "foo.c": "",
3113 },
3114 Blueprint: `cc_library {
3115 name: "foo",
3116 arch: {
3117 arm64: { suffix: "-64" },
3118 arm: { suffix: "-32" },
3119 },
3120 srcs: ["foo.c"],
3121 include_build_directory: false,
3122}`,
3123 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00003124 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05003125 "srcs_c": `["foo.c"]`,
3126 }),
Alixe06d75b2022-08-31 18:28:19 +00003127 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05003128 "srcs_c": `["foo.c"]`,
3129 "suffix": `select({
3130 "//build/bazel/platforms/arch:arm": "-32",
3131 "//build/bazel/platforms/arch:arm64": "-64",
3132 "//conditions:default": None,
3133 })`,
3134 }),
3135 },
3136 })
3137}
3138
Vinh Tran367d89d2023-04-28 11:21:25 -04003139func TestCcLibraryWithAidlLibrary(t *testing.T) {
3140 runCcLibraryTestCase(t, Bp2buildTestCase{
3141 Description: "cc_library with aidl_library",
3142 ModuleTypeUnderTest: "cc_library",
3143 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3144 Blueprint: `
3145aidl_library {
3146 name: "A_aidl",
3147 srcs: ["aidl/A.aidl"],
3148 hdrs: ["aidl/Header.aidl"],
3149 strip_import_prefix: "aidl",
3150}
3151cc_library {
3152 name: "foo",
3153 aidl: {
3154 libs: ["A_aidl"],
Vinh Trane6842942023-04-28 11:21:25 -04003155 },
3156 export_include_dirs: ["include"],
Vinh Tran367d89d2023-04-28 11:21:25 -04003157}`,
3158 ExpectedBazelTargets: []string{
3159 MakeBazelTargetNoRestrictions("aidl_library", "A_aidl", AttrNameToString{
3160 "srcs": `["aidl/A.aidl"]`,
3161 "hdrs": `["aidl/Header.aidl"]`,
3162 "strip_import_prefix": `"aidl"`,
3163 "tags": `["apex_available=//apex_available:anyapex"]`,
3164 }),
3165 MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{
Vinh Trane6842942023-04-28 11:21:25 -04003166 "deps": `[":A_aidl"]`,
3167 "local_includes": `["."]`,
3168 "export_includes": `["include"]`,
Vinh Tran367d89d2023-04-28 11:21:25 -04003169 }),
3170 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
3171 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
3172 "local_includes": `["."]`,
Vinh Trane6842942023-04-28 11:21:25 -04003173 "export_includes": `["include"]`,
Vinh Tran367d89d2023-04-28 11:21:25 -04003174 }),
3175 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
3176 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
3177 "local_includes": `["."]`,
Vinh Trane6842942023-04-28 11:21:25 -04003178 "export_includes": `["include"]`,
Vinh Tran367d89d2023-04-28 11:21:25 -04003179 }),
3180 },
3181 })
3182}
3183
Vinh Tran9f6796a2022-08-16 13:10:31 -04003184func TestCcLibraryWithAidlSrcs(t *testing.T) {
3185 runCcLibraryTestCase(t, Bp2buildTestCase{
3186 Description: "cc_library with aidl srcs",
3187 ModuleTypeUnderTest: "cc_library",
3188 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3189 Blueprint: `
3190filegroup {
3191 name: "A_aidl",
3192 srcs: ["aidl/A.aidl"],
3193 path: "aidl",
3194}
3195cc_library {
3196 name: "foo",
3197 srcs: [
3198 ":A_aidl",
3199 "B.aidl",
3200 ],
3201}`,
3202 ExpectedBazelTargets: []string{
3203 MakeBazelTargetNoRestrictions("aidl_library", "A_aidl", AttrNameToString{
3204 "srcs": `["aidl/A.aidl"]`,
3205 "strip_import_prefix": `"aidl"`,
Liz Kammer2b3f56e2023-03-23 11:51:49 -04003206 "tags": `["apex_available=//apex_available:anyapex"]`,
Vinh Tran9f6796a2022-08-16 13:10:31 -04003207 }),
Alixe06d75b2022-08-31 18:28:19 +00003208 MakeBazelTarget("aidl_library", "foo_aidl_library", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04003209 "srcs": `["B.aidl"]`,
3210 }),
Alixe06d75b2022-08-31 18:28:19 +00003211 MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{
Vinh Trane6842942023-04-28 11:21:25 -04003212 "local_includes": `["."]`,
Vinh Tran9f6796a2022-08-16 13:10:31 -04003213 "deps": `[
3214 ":A_aidl",
3215 ":foo_aidl_library",
3216 ]`,
3217 }),
Alixe06d75b2022-08-31 18:28:19 +00003218 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Vinh Tranfde57eb2022-08-29 17:46:58 -04003219 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
3220 "local_includes": `["."]`,
Vinh Tran9f6796a2022-08-16 13:10:31 -04003221 }),
Alixe06d75b2022-08-31 18:28:19 +00003222 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04003223 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
3224 "local_includes": `["."]`,
Vinh Tran9f6796a2022-08-16 13:10:31 -04003225 }),
3226 },
3227 })
3228}
3229
3230func TestCcLibraryWithNonAdjacentAidlFilegroup(t *testing.T) {
3231 runCcLibraryTestCase(t, Bp2buildTestCase{
3232 Description: "cc_library with non aidl filegroup",
3233 ModuleTypeUnderTest: "cc_library",
3234 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3235 Filesystem: map[string]string{
3236 "path/to/A/Android.bp": `
3237filegroup {
Vinh Tranfde57eb2022-08-29 17:46:58 -04003238 name: "A_aidl",
3239 srcs: ["aidl/A.aidl"],
3240 path: "aidl",
Vinh Tran9f6796a2022-08-16 13:10:31 -04003241}`,
3242 },
3243 Blueprint: `
3244cc_library {
Vinh Tranfde57eb2022-08-29 17:46:58 -04003245 name: "foo",
3246 srcs: [
3247 ":A_aidl",
3248 ],
Vinh Tran9f6796a2022-08-16 13:10:31 -04003249}`,
3250 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00003251 MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{
Vinh Trane6842942023-04-28 11:21:25 -04003252 "local_includes": `["."]`,
3253 "deps": `["//path/to/A:A_aidl"]`,
Vinh Tran9f6796a2022-08-16 13:10:31 -04003254 }),
Alixe06d75b2022-08-31 18:28:19 +00003255 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Vinh Tranfde57eb2022-08-29 17:46:58 -04003256 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
3257 "local_includes": `["."]`,
3258 }),
Vinh Tranfde57eb2022-08-29 17:46:58 -04003259 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04003260 "local_includes": `["."]`,
3261 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
Vinh Tranfde57eb2022-08-29 17:46:58 -04003262 }),
3263 },
3264 })
3265}
3266
3267func TestCcLibraryWithExportAidlHeaders(t *testing.T) {
Vinh Tran367d89d2023-04-28 11:21:25 -04003268 t.Parallel()
3269
3270 expectedBazelTargets := []string{
3271 MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{
Vinh Trane6842942023-04-28 11:21:25 -04003272 "local_includes": `["."]`,
3273 "deps": `[":foo_aidl_library"]`,
Vinh Tran367d89d2023-04-28 11:21:25 -04003274 }),
3275 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
3276 "whole_archive_deps": `[":foo_cc_aidl_library"]`,
3277 "local_includes": `["."]`,
3278 }),
3279 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
3280 "whole_archive_deps": `[":foo_cc_aidl_library"]`,
3281 "local_includes": `["."]`,
3282 }),
3283 }
3284 testCases := []struct {
3285 description string
3286 bp string
3287 expectedBazelTargets []string
3288 }{
3289 {
3290 description: "cc_library with aidl srcs and aidl.export_aidl_headers set",
3291 bp: `
3292 cc_library {
3293 name: "foo",
3294 srcs: [
3295 "Foo.aidl",
3296 ],
3297 aidl: {
3298 export_aidl_headers: true,
3299 }
3300 }`,
3301 expectedBazelTargets: append(
3302 expectedBazelTargets,
3303 MakeBazelTarget("aidl_library", "foo_aidl_library", AttrNameToString{
3304 "srcs": `["Foo.aidl"]`,
3305 })),
Vinh Tran9f6796a2022-08-16 13:10:31 -04003306 },
Vinh Tran367d89d2023-04-28 11:21:25 -04003307 {
3308 description: "cc_library with aidl.libs and aidl.export_aidl_headers set",
3309 bp: `
3310 aidl_library {
3311 name: "foo_aidl_library",
3312 srcs: ["Foo.aidl"],
3313 }
3314 cc_library {
3315 name: "foo",
3316 aidl: {
3317 libs: ["foo_aidl_library"],
3318 export_aidl_headers: true,
3319 }
3320 }`,
3321 expectedBazelTargets: append(
3322 expectedBazelTargets,
3323 MakeBazelTargetNoRestrictions("aidl_library", "foo_aidl_library", AttrNameToString{
3324 "srcs": `["Foo.aidl"]`,
3325 "tags": `["apex_available=//apex_available:anyapex"]`,
3326 }),
3327 ),
3328 },
3329 }
3330
3331 for _, testCase := range testCases {
3332 runCcLibraryTestCase(t, Bp2buildTestCase{
3333 Description: "cc_library with export aidl headers",
3334 ModuleTypeUnderTest: "cc_library",
3335 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3336 Blueprint: testCase.bp,
3337 ExpectedBazelTargets: testCase.expectedBazelTargets,
3338 })
3339 }
Vinh Tran9f6796a2022-08-16 13:10:31 -04003340}
Vinh Tran85fb07c2022-09-16 16:17:48 -04003341
3342func TestCcLibraryWithTargetApex(t *testing.T) {
3343 runCcLibraryTestCase(t, Bp2buildTestCase{
3344 Description: "cc_library with target.apex",
3345 ModuleTypeUnderTest: "cc_library",
3346 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3347 Blueprint: `
3348cc_library {
3349 name: "foo",
3350 shared_libs: ["bar", "baz"],
3351 static_libs: ["baz", "buh"],
3352 target: {
3353 apex: {
3354 exclude_shared_libs: ["bar"],
3355 exclude_static_libs: ["buh"],
3356 }
3357 }
3358}`,
3359 ExpectedBazelTargets: []string{
3360 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
3361 "implementation_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({
Liz Kammer748d7072023-01-25 12:07:43 -05003362 "//build/bazel/rules/apex:in_apex": [],
3363 "//conditions:default": [":buh__BP2BUILD__MISSING__DEP"],
Vinh Tran85fb07c2022-09-16 16:17:48 -04003364 })`,
3365 "implementation_dynamic_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({
Liz Kammer748d7072023-01-25 12:07:43 -05003366 "//build/bazel/rules/apex:in_apex": [],
3367 "//conditions:default": [":bar__BP2BUILD__MISSING__DEP"],
Vinh Tran85fb07c2022-09-16 16:17:48 -04003368 })`,
3369 "local_includes": `["."]`,
3370 }),
3371 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
3372 "implementation_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({
Liz Kammer748d7072023-01-25 12:07:43 -05003373 "//build/bazel/rules/apex:in_apex": [],
3374 "//conditions:default": [":buh__BP2BUILD__MISSING__DEP"],
Vinh Tran85fb07c2022-09-16 16:17:48 -04003375 })`,
3376 "implementation_dynamic_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({
Liz Kammer748d7072023-01-25 12:07:43 -05003377 "//build/bazel/rules/apex:in_apex": [],
3378 "//conditions:default": [":bar__BP2BUILD__MISSING__DEP"],
Vinh Tran85fb07c2022-09-16 16:17:48 -04003379 })`,
3380 "local_includes": `["."]`,
3381 }),
3382 },
3383 })
3384}
3385
3386func TestCcLibraryWithTargetApexAndExportLibHeaders(t *testing.T) {
3387 runCcLibraryTestCase(t, Bp2buildTestCase{
3388 Description: "cc_library with target.apex and export_shared|static_lib_headers",
3389 ModuleTypeUnderTest: "cc_library",
3390 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3391 Blueprint: `
3392cc_library_static {
3393 name: "foo",
3394 shared_libs: ["bar", "baz"],
3395 static_libs: ["abc"],
3396 export_shared_lib_headers: ["baz"],
3397 export_static_lib_headers: ["abc"],
3398 target: {
3399 apex: {
3400 exclude_shared_libs: ["baz", "bar"],
3401 exclude_static_libs: ["abc"],
3402 }
3403 }
3404}`,
3405 ExpectedBazelTargets: []string{
3406 MakeBazelTarget("cc_library_static", "foo", AttrNameToString{
3407 "implementation_dynamic_deps": `select({
Liz Kammer748d7072023-01-25 12:07:43 -05003408 "//build/bazel/rules/apex:in_apex": [],
3409 "//conditions:default": [":bar__BP2BUILD__MISSING__DEP"],
Vinh Tran85fb07c2022-09-16 16:17:48 -04003410 })`,
3411 "dynamic_deps": `select({
Liz Kammer748d7072023-01-25 12:07:43 -05003412 "//build/bazel/rules/apex:in_apex": [],
3413 "//conditions:default": [":baz__BP2BUILD__MISSING__DEP"],
Vinh Tran85fb07c2022-09-16 16:17:48 -04003414 })`,
3415 "deps": `select({
Liz Kammer748d7072023-01-25 12:07:43 -05003416 "//build/bazel/rules/apex:in_apex": [],
3417 "//conditions:default": [":abc__BP2BUILD__MISSING__DEP"],
Vinh Tran85fb07c2022-09-16 16:17:48 -04003418 })`,
3419 "local_includes": `["."]`,
3420 }),
3421 },
3422 })
3423}
Trevor Radcliffecee4e052022-09-06 19:31:25 +00003424
3425func TestCcLibraryWithSyspropSrcs(t *testing.T) {
3426 runCcLibraryTestCase(t, Bp2buildTestCase{
3427 Description: "cc_library with sysprop sources",
3428 ModuleTypeUnderTest: "cc_library",
3429 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3430 Blueprint: `
3431cc_library {
3432 name: "foo",
3433 srcs: [
3434 "bar.sysprop",
3435 "baz.sysprop",
3436 "blah.cpp",
3437 ],
3438 min_sdk_version: "5",
3439}`,
3440 ExpectedBazelTargets: []string{
3441 MakeBazelTarget("sysprop_library", "foo_sysprop_library", AttrNameToString{
3442 "srcs": `[
3443 "bar.sysprop",
3444 "baz.sysprop",
3445 ]`,
3446 }),
3447 MakeBazelTarget("cc_sysprop_library_static", "foo_cc_sysprop_library_static", AttrNameToString{
3448 "dep": `":foo_sysprop_library"`,
3449 "min_sdk_version": `"5"`,
3450 }),
3451 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
3452 "srcs": `["blah.cpp"]`,
3453 "local_includes": `["."]`,
3454 "min_sdk_version": `"5"`,
3455 "whole_archive_deps": `[":foo_cc_sysprop_library_static"]`,
3456 }),
3457 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
3458 "srcs": `["blah.cpp"]`,
3459 "local_includes": `["."]`,
3460 "min_sdk_version": `"5"`,
3461 "whole_archive_deps": `[":foo_cc_sysprop_library_static"]`,
3462 }),
3463 },
3464 })
3465}
3466
3467func TestCcLibraryWithSyspropSrcsSomeConfigs(t *testing.T) {
3468 runCcLibraryTestCase(t, Bp2buildTestCase{
3469 Description: "cc_library with sysprop sources in some configs but not others",
3470 ModuleTypeUnderTest: "cc_library",
3471 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3472 Blueprint: `
3473cc_library {
3474 name: "foo",
3475 host_supported: true,
3476 srcs: [
3477 "blah.cpp",
3478 ],
3479 target: {
3480 android: {
3481 srcs: ["bar.sysprop"],
3482 },
3483 },
3484 min_sdk_version: "5",
3485}`,
3486 ExpectedBazelTargets: []string{
3487 MakeBazelTargetNoRestrictions("sysprop_library", "foo_sysprop_library", AttrNameToString{
3488 "srcs": `select({
3489 "//build/bazel/platforms/os:android": ["bar.sysprop"],
3490 "//conditions:default": [],
3491 })`,
3492 }),
3493 MakeBazelTargetNoRestrictions("cc_sysprop_library_static", "foo_cc_sysprop_library_static", AttrNameToString{
3494 "dep": `":foo_sysprop_library"`,
3495 "min_sdk_version": `"5"`,
3496 }),
3497 MakeBazelTargetNoRestrictions("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
3498 "srcs": `["blah.cpp"]`,
3499 "local_includes": `["."]`,
3500 "min_sdk_version": `"5"`,
3501 "whole_archive_deps": `select({
3502 "//build/bazel/platforms/os:android": [":foo_cc_sysprop_library_static"],
3503 "//conditions:default": [],
3504 })`,
3505 }),
3506 MakeBazelTargetNoRestrictions("cc_library_shared", "foo", AttrNameToString{
3507 "srcs": `["blah.cpp"]`,
3508 "local_includes": `["."]`,
3509 "min_sdk_version": `"5"`,
3510 "whole_archive_deps": `select({
3511 "//build/bazel/platforms/os:android": [":foo_cc_sysprop_library_static"],
3512 "//conditions:default": [],
3513 })`,
3514 }),
3515 },
3516 })
3517}
Vinh Tran395a1e92022-09-16 18:27:29 -04003518
Sam Delmerico512437b2023-03-17 11:34:15 -04003519func TestCcLibraryWithAidlAndLibs(t *testing.T) {
Vinh Tran395a1e92022-09-16 18:27:29 -04003520 runCcLibraryTestCase(t, Bp2buildTestCase{
Sam Delmerico512437b2023-03-17 11:34:15 -04003521 Description: "cc_aidl_library depends on libs from parent cc_library_static",
Vinh Tran395a1e92022-09-16 18:27:29 -04003522 ModuleTypeUnderTest: "cc_library",
3523 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3524 Blueprint: `
3525cc_library_static {
Sam Delmerico512437b2023-03-17 11:34:15 -04003526 name: "foo",
3527 srcs: [
3528 "Foo.aidl",
3529 ],
3530 static_libs: [
3531 "bar-static",
3532 "baz-static",
3533 ],
Vinh Tran395a1e92022-09-16 18:27:29 -04003534 shared_libs: [
Sam Delmerico512437b2023-03-17 11:34:15 -04003535 "bar-shared",
3536 "baz-shared",
3537 ],
3538 export_static_lib_headers: [
3539 "baz-static",
Vinh Tran395a1e92022-09-16 18:27:29 -04003540 ],
3541 export_shared_lib_headers: [
Sam Delmerico512437b2023-03-17 11:34:15 -04003542 "baz-shared",
Vinh Tran395a1e92022-09-16 18:27:29 -04003543 ],
3544}` +
Sam Delmerico512437b2023-03-17 11:34:15 -04003545 simpleModuleDoNotConvertBp2build("cc_library_static", "bar-static") +
3546 simpleModuleDoNotConvertBp2build("cc_library_static", "baz-static") +
3547 simpleModuleDoNotConvertBp2build("cc_library", "bar-shared") +
3548 simpleModuleDoNotConvertBp2build("cc_library", "baz-shared"),
Vinh Tran395a1e92022-09-16 18:27:29 -04003549 ExpectedBazelTargets: []string{
3550 MakeBazelTarget("aidl_library", "foo_aidl_library", AttrNameToString{
3551 "srcs": `["Foo.aidl"]`,
3552 }),
3553 MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{
Vinh Trane6842942023-04-28 11:21:25 -04003554 "local_includes": `["."]`,
3555 "deps": `[":foo_aidl_library"]`,
Sam Delmerico512437b2023-03-17 11:34:15 -04003556 "implementation_deps": `[
3557 ":baz-static",
3558 ":bar-static",
3559 ]`,
Vinh Tran395a1e92022-09-16 18:27:29 -04003560 "implementation_dynamic_deps": `[
Sam Delmerico512437b2023-03-17 11:34:15 -04003561 ":baz-shared",
3562 ":bar-shared",
Vinh Tran395a1e92022-09-16 18:27:29 -04003563 ]`,
3564 }),
3565 MakeBazelTarget("cc_library_static", "foo", AttrNameToString{
3566 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
Sam Delmerico512437b2023-03-17 11:34:15 -04003567 "deps": `[":baz-static"]`,
3568 "implementation_deps": `[":bar-static"]`,
3569 "dynamic_deps": `[":baz-shared"]`,
3570 "implementation_dynamic_deps": `[":bar-shared"]`,
Vinh Tran395a1e92022-09-16 18:27:29 -04003571 "local_includes": `["."]`,
3572 }),
3573 },
3574 })
3575}
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -04003576
3577func TestCcLibraryWithTidy(t *testing.T) {
3578 runCcLibraryTestCase(t, Bp2buildTestCase{
3579 Description: "cc_library uses tidy properties",
3580 ModuleTypeUnderTest: "cc_library",
3581 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3582 Blueprint: `
3583cc_library_static {
Sam Delmerico63f0c932023-03-14 14:05:28 -04003584 name: "foo",
3585 srcs: ["foo.cpp"],
3586}
3587cc_library_static {
3588 name: "foo-no-tidy",
3589 srcs: ["foo.cpp"],
3590 tidy: false,
3591}
3592cc_library_static {
3593 name: "foo-tidy",
3594 srcs: ["foo.cpp"],
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -04003595 tidy: true,
3596 tidy_checks: ["check1", "check2"],
3597 tidy_checks_as_errors: ["check1error", "check2error"],
3598 tidy_disabled_srcs: ["bar.cpp"],
Sam Delmerico4c902d62022-11-02 14:17:15 -04003599 tidy_timeout_srcs: ["baz.cpp"],
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -04003600}`,
3601 ExpectedBazelTargets: []string{
3602 MakeBazelTarget("cc_library_static", "foo", AttrNameToString{
3603 "local_includes": `["."]`,
3604 "srcs": `["foo.cpp"]`,
Sam Delmerico63f0c932023-03-14 14:05:28 -04003605 }),
3606 MakeBazelTarget("cc_library_static", "foo-no-tidy", AttrNameToString{
3607 "local_includes": `["."]`,
3608 "srcs": `["foo.cpp"]`,
3609 "tidy": `"never"`,
3610 }),
3611 MakeBazelTarget("cc_library_static", "foo-tidy", AttrNameToString{
3612 "local_includes": `["."]`,
3613 "srcs": `["foo.cpp"]`,
3614 "tidy": `"local"`,
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -04003615 "tidy_checks": `[
3616 "check1",
3617 "check2",
3618 ]`,
3619 "tidy_checks_as_errors": `[
3620 "check1error",
3621 "check2error",
3622 ]`,
3623 "tidy_disabled_srcs": `["bar.cpp"]`,
Sam Delmerico4c902d62022-11-02 14:17:15 -04003624 "tidy_timeout_srcs": `["baz.cpp"]`,
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -04003625 }),
3626 },
3627 })
3628}
Yu Liu56ccb1a2022-11-12 10:47:07 -08003629
Vinh Tran99270ea2022-11-28 11:15:23 -05003630func TestCcLibraryWithAfdoEnabled(t *testing.T) {
3631 bp := `
3632cc_library {
3633 name: "foo",
3634 afdo: true,
3635 include_build_directory: false,
3636}`
3637
3638 // TODO(b/260714900): Add test case for arch-specific afdo profile
3639 testCases := []struct {
3640 description string
3641 filesystem map[string]string
3642 expectedBazelTargets []string
3643 }{
3644 {
3645 description: "cc_library with afdo enabled and existing profile",
Vinh Tranbc9c8b42022-12-09 12:03:52 -05003646 filesystem: map[string]string{
3647 "vendor/google_data/pgo_profile/sampling/BUILD": "",
3648 "vendor/google_data/pgo_profile/sampling/foo.afdo": "",
3649 },
Vinh Tran99270ea2022-11-28 11:15:23 -05003650 expectedBazelTargets: []string{
3651 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}),
3652 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
3653 "fdo_profile": `"//vendor/google_data/pgo_profile/sampling:foo"`,
3654 }),
3655 },
3656 },
3657 {
3658 description: "cc_library with afdo enabled and existing profile in AOSP",
Vinh Tranbc9c8b42022-12-09 12:03:52 -05003659 filesystem: map[string]string{
3660 "toolchain/pgo-profiles/sampling/BUILD": "",
3661 "toolchain/pgo-profiles/sampling/foo.afdo": "",
3662 },
Vinh Tran99270ea2022-11-28 11:15:23 -05003663 expectedBazelTargets: []string{
3664 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}),
3665 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
3666 "fdo_profile": `"//toolchain/pgo-profiles/sampling:foo"`,
3667 }),
3668 },
3669 },
3670 {
3671 description: "cc_library with afdo enabled but profile filename doesn't match with module name",
Vinh Tranbc9c8b42022-12-09 12:03:52 -05003672 filesystem: map[string]string{
3673 "toolchain/pgo-profiles/sampling/BUILD": "",
3674 "toolchain/pgo-profiles/sampling/bar.afdo": "",
3675 },
Vinh Tran99270ea2022-11-28 11:15:23 -05003676 expectedBazelTargets: []string{
3677 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}),
3678 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{}),
3679 },
3680 },
3681 {
3682 description: "cc_library with afdo enabled but profile doesn't exist",
3683 expectedBazelTargets: []string{
3684 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}),
3685 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{}),
3686 },
3687 },
Vinh Tranbc9c8b42022-12-09 12:03:52 -05003688 {
3689 description: "cc_library with afdo enabled and existing profile but BUILD file doesn't exist",
3690 filesystem: map[string]string{
3691 "vendor/google_data/pgo_profile/sampling/foo.afdo": "",
3692 },
3693 expectedBazelTargets: []string{
3694 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}),
3695 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{}),
3696 },
3697 },
Vinh Tran99270ea2022-11-28 11:15:23 -05003698 }
3699 for _, testCase := range testCases {
3700 t.Run(testCase.description, func(t *testing.T) {
3701 runCcLibraryTestCase(t, Bp2buildTestCase{
3702 ExpectedBazelTargets: testCase.expectedBazelTargets,
3703 ModuleTypeUnderTest: "cc_library",
3704 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3705 Description: testCase.description,
3706 Blueprint: binaryReplacer.Replace(bp),
3707 Filesystem: testCase.filesystem,
3708 })
3709 })
3710 }
3711}
3712
Yu Liu56ccb1a2022-11-12 10:47:07 -08003713func TestCcLibraryHeaderAbiChecker(t *testing.T) {
3714 runCcLibraryTestCase(t, Bp2buildTestCase{
3715 Description: "cc_library with header abi checker",
3716 ModuleTypeUnderTest: "cc_library",
3717 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3718 Blueprint: `cc_library {
3719 name: "foo",
3720 header_abi_checker: {
3721 enabled: true,
3722 symbol_file: "a.map.txt",
3723 exclude_symbol_versions: [
3724 "29",
3725 "30",
3726 ],
3727 exclude_symbol_tags: [
3728 "tag1",
3729 "tag2",
3730 ],
3731 check_all_apis: true,
3732 diff_flags: ["-allow-adding-removing-weak-symbols"],
3733 },
3734 include_build_directory: false,
3735}`,
3736 ExpectedBazelTargets: []string{
3737 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}),
3738 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
3739 "abi_checker_enabled": `True`,
3740 "abi_checker_symbol_file": `"a.map.txt"`,
3741 "abi_checker_exclude_symbol_versions": `[
3742 "29",
3743 "30",
3744 ]`,
3745 "abi_checker_exclude_symbol_tags": `[
3746 "tag1",
3747 "tag2",
3748 ]`,
3749 "abi_checker_check_all_apis": `True`,
3750 "abi_checker_diff_flags": `["-allow-adding-removing-weak-symbols"]`,
3751 }),
3752 },
3753 })
3754}
Jingwen Chenc4c34e12022-11-29 12:07:45 +00003755
3756func TestCcLibraryApexAvailable(t *testing.T) {
3757 runCcLibraryTestCase(t, Bp2buildTestCase{
3758 Description: "cc_library apex_available converted to tags",
3759 ModuleTypeUnderTest: "cc_library",
3760 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3761 Blueprint: soongCcLibraryPreamble + `
3762cc_library {
3763 name: "a",
3764 srcs: ["a.cpp"],
3765 apex_available: ["com.android.foo"],
3766}
3767`,
3768 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
3769 "tags": `["apex_available=com.android.foo"]`,
3770 "srcs": `["a.cpp"]`,
3771 "local_includes": `["."]`,
3772 }),
3773 },
3774 )
3775}
3776
3777func TestCcLibraryApexAvailableMultiple(t *testing.T) {
3778 runCcLibraryTestCase(t, Bp2buildTestCase{
3779 Description: "cc_library apex_available converted to multiple tags",
3780 ModuleTypeUnderTest: "cc_library",
3781 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3782 Blueprint: soongCcLibraryPreamble + `
3783cc_library {
3784 name: "a",
3785 srcs: ["a.cpp"],
3786 apex_available: ["com.android.foo", "//apex_available:platform", "com.android.bar"],
3787}
3788`,
3789 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
3790 "tags": `[
3791 "apex_available=com.android.foo",
3792 "apex_available=//apex_available:platform",
3793 "apex_available=com.android.bar",
3794 ]`,
3795 "srcs": `["a.cpp"]`,
3796 "local_includes": `["."]`,
3797 }),
3798 },
3799 )
3800}
Zi Wang0f828442022-12-28 11:18:11 -08003801
3802// Export_include_dirs and Export_system_include_dirs have "variant_prepend" tag.
3803// In bp2build output, variant info(select) should go before general info.
3804// Internal order of the property should be unchanged. (e.g. ["eid1", "eid2"])
3805func TestCcLibraryVariantPrependPropOrder(t *testing.T) {
3806 runCcLibraryTestCase(t, Bp2buildTestCase{
3807 Description: "cc_library variant prepend properties order",
3808 ModuleTypeUnderTest: "cc_library",
3809 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3810 Blueprint: soongCcLibraryPreamble + `
3811cc_library {
3812 name: "a",
3813 srcs: ["a.cpp"],
3814 export_include_dirs: ["eid1", "eid2"],
3815 export_system_include_dirs: ["esid1", "esid2"],
3816 target: {
3817 android: {
3818 export_include_dirs: ["android_eid1", "android_eid2"],
3819 export_system_include_dirs: ["android_esid1", "android_esid2"],
3820 },
3821 android_arm: {
3822 export_include_dirs: ["android_arm_eid1", "android_arm_eid2"],
3823 export_system_include_dirs: ["android_arm_esid1", "android_arm_esid2"],
3824 },
3825 linux: {
3826 export_include_dirs: ["linux_eid1", "linux_eid2"],
3827 export_system_include_dirs: ["linux_esid1", "linux_esid2"],
3828 },
3829 },
3830 multilib: {
3831 lib32: {
3832 export_include_dirs: ["lib32_eid1", "lib32_eid2"],
3833 export_system_include_dirs: ["lib32_esid1", "lib32_esid2"],
3834 },
3835 },
3836 arch: {
3837 arm: {
3838 export_include_dirs: ["arm_eid1", "arm_eid2"],
3839 export_system_include_dirs: ["arm_esid1", "arm_esid2"],
3840 },
3841 }
3842}
3843`,
3844 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
3845 "export_includes": `select({
3846 "//build/bazel/platforms/os_arch:android_arm": [
3847 "android_arm_eid1",
3848 "android_arm_eid2",
3849 ],
3850 "//conditions:default": [],
3851 }) + select({
3852 "//build/bazel/platforms/os:android": [
3853 "android_eid1",
3854 "android_eid2",
3855 "linux_eid1",
3856 "linux_eid2",
3857 ],
3858 "//build/bazel/platforms/os:linux_bionic": [
3859 "linux_eid1",
3860 "linux_eid2",
3861 ],
3862 "//build/bazel/platforms/os:linux_glibc": [
3863 "linux_eid1",
3864 "linux_eid2",
3865 ],
3866 "//build/bazel/platforms/os:linux_musl": [
3867 "linux_eid1",
3868 "linux_eid2",
3869 ],
3870 "//conditions:default": [],
3871 }) + select({
3872 "//build/bazel/platforms/arch:arm": [
3873 "lib32_eid1",
3874 "lib32_eid2",
3875 "arm_eid1",
3876 "arm_eid2",
3877 ],
3878 "//build/bazel/platforms/arch:x86": [
3879 "lib32_eid1",
3880 "lib32_eid2",
3881 ],
3882 "//conditions:default": [],
3883 }) + [
3884 "eid1",
3885 "eid2",
3886 ]`,
3887 "export_system_includes": `select({
3888 "//build/bazel/platforms/os_arch:android_arm": [
3889 "android_arm_esid1",
3890 "android_arm_esid2",
3891 ],
3892 "//conditions:default": [],
3893 }) + select({
3894 "//build/bazel/platforms/os:android": [
3895 "android_esid1",
3896 "android_esid2",
3897 "linux_esid1",
3898 "linux_esid2",
3899 ],
3900 "//build/bazel/platforms/os:linux_bionic": [
3901 "linux_esid1",
3902 "linux_esid2",
3903 ],
3904 "//build/bazel/platforms/os:linux_glibc": [
3905 "linux_esid1",
3906 "linux_esid2",
3907 ],
3908 "//build/bazel/platforms/os:linux_musl": [
3909 "linux_esid1",
3910 "linux_esid2",
3911 ],
3912 "//conditions:default": [],
3913 }) + select({
3914 "//build/bazel/platforms/arch:arm": [
3915 "lib32_esid1",
3916 "lib32_esid2",
3917 "arm_esid1",
3918 "arm_esid2",
3919 ],
3920 "//build/bazel/platforms/arch:x86": [
3921 "lib32_esid1",
3922 "lib32_esid2",
3923 ],
3924 "//conditions:default": [],
3925 }) + [
3926 "esid1",
3927 "esid2",
3928 ]`,
3929 "srcs": `["a.cpp"]`,
3930 "local_includes": `["."]`,
3931 "target_compatible_with": `["//build/bazel/platforms/os:android"]`,
3932 }),
3933 },
3934 )
3935}
Trevor Radcliffedb7e0262022-10-28 16:48:18 +00003936
3937func TestCcLibraryWithIntegerOverflowProperty(t *testing.T) {
3938 runCcLibraryTestCase(t, Bp2buildTestCase{
3939 Description: "cc_library has correct features when integer_overflow property is provided",
3940 ModuleTypeUnderTest: "cc_library",
3941 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3942 Blueprint: `
3943cc_library {
3944 name: "foo",
3945 sanitize: {
3946 integer_overflow: true,
3947 },
3948}
3949`,
3950 ExpectedBazelTargets: []string{
3951 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
3952 "features": `["ubsan_integer_overflow"]`,
3953 "local_includes": `["."]`,
3954 }),
3955 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
3956 "features": `["ubsan_integer_overflow"]`,
3957 "local_includes": `["."]`,
3958 }),
3959 },
3960 })
3961}
3962
3963func TestCcLibraryWithMiscUndefinedProperty(t *testing.T) {
3964 runCcLibraryTestCase(t, Bp2buildTestCase{
3965 Description: "cc_library has correct features when misc_undefined property is provided",
3966 ModuleTypeUnderTest: "cc_library",
3967 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3968 Blueprint: `
3969cc_library {
3970 name: "foo",
3971 sanitize: {
3972 misc_undefined: ["undefined", "nullability"],
3973 },
3974}
3975`,
3976 ExpectedBazelTargets: []string{
3977 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
3978 "features": `[
3979 "ubsan_undefined",
3980 "ubsan_nullability",
3981 ]`,
3982 "local_includes": `["."]`,
3983 }),
3984 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
3985 "features": `[
3986 "ubsan_undefined",
3987 "ubsan_nullability",
3988 ]`,
3989 "local_includes": `["."]`,
3990 }),
3991 },
3992 })
3993}
3994
Trevor Radcliffeded095c2023-06-12 19:18:28 +00003995func TestCcLibraryWithSanitizerBlocklist(t *testing.T) {
3996 runCcLibraryTestCase(t, Bp2buildTestCase{
3997 Description: "cc_library has correct feature when sanitize.blocklist is provided",
3998 ModuleTypeUnderTest: "cc_library",
3999 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4000 Blueprint: `
4001cc_library {
4002 name: "foo",
4003 sanitize: {
4004 blocklist: "foo_blocklist.txt",
4005 },
4006}
4007`,
4008 ExpectedBazelTargets: []string{
4009 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Trevor Radcliffed9b7f172023-08-09 22:21:38 +00004010 "copts": `select({
4011 "//build/bazel/rules/cc:sanitizers_enabled": ["-fsanitize-ignorelist=$(location foo_blocklist.txt)"],
4012 "//conditions:default": [],
4013 })`,
4014 "additional_compiler_inputs": `select({
4015 "//build/bazel/rules/cc:sanitizers_enabled": [":foo_blocklist.txt"],
4016 "//conditions:default": [],
4017 })`,
Trevor Radcliffeded095c2023-06-12 19:18:28 +00004018 "local_includes": `["."]`,
4019 }),
4020 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Trevor Radcliffed9b7f172023-08-09 22:21:38 +00004021 "copts": `select({
4022 "//build/bazel/rules/cc:sanitizers_enabled": ["-fsanitize-ignorelist=$(location foo_blocklist.txt)"],
4023 "//conditions:default": [],
4024 })`,
4025 "additional_compiler_inputs": `select({
4026 "//build/bazel/rules/cc:sanitizers_enabled": [":foo_blocklist.txt"],
4027 "//conditions:default": [],
4028 })`,
Trevor Radcliffeded095c2023-06-12 19:18:28 +00004029 "local_includes": `["."]`,
4030 }),
4031 },
4032 })
4033}
4034
Trevor Radcliffedb7e0262022-10-28 16:48:18 +00004035func TestCcLibraryWithUBSanPropertiesArchSpecific(t *testing.T) {
4036 runCcLibraryTestCase(t, Bp2buildTestCase{
4037 Description: "cc_library has correct feature select when UBSan props are specified in arch specific blocks",
4038 ModuleTypeUnderTest: "cc_library",
4039 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4040 Blueprint: `
4041cc_library {
4042 name: "foo",
4043 sanitize: {
4044 misc_undefined: ["undefined", "nullability"],
4045 },
4046 target: {
4047 android: {
4048 sanitize: {
4049 misc_undefined: ["alignment"],
4050 },
4051 },
4052 linux_glibc: {
4053 sanitize: {
4054 integer_overflow: true,
4055 },
4056 },
4057 },
4058}
4059`,
4060 ExpectedBazelTargets: []string{
4061 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
4062 "features": `[
4063 "ubsan_undefined",
4064 "ubsan_nullability",
4065 ] + select({
4066 "//build/bazel/platforms/os:android": ["ubsan_alignment"],
4067 "//build/bazel/platforms/os:linux_glibc": ["ubsan_integer_overflow"],
4068 "//conditions:default": [],
4069 })`,
4070 "local_includes": `["."]`,
4071 }),
4072 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
4073 "features": `[
4074 "ubsan_undefined",
4075 "ubsan_nullability",
4076 ] + select({
4077 "//build/bazel/platforms/os:android": ["ubsan_alignment"],
4078 "//build/bazel/platforms/os:linux_glibc": ["ubsan_integer_overflow"],
4079 "//conditions:default": [],
4080 })`,
4081 "local_includes": `["."]`,
4082 }),
4083 },
4084 })
4085}
Yu Liu10174ff2023-02-21 12:05:26 -08004086
4087func TestCcLibraryInApexWithStubSharedLibs(t *testing.T) {
4088 runCcLibrarySharedTestCase(t, Bp2buildTestCase{
4089 Description: "cc_library with in apex with stub shared_libs and export_shared_lib_headers",
4090 ModuleTypeUnderTest: "cc_library",
4091 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4092 Blueprint: `
4093cc_library {
4094 name: "barlib",
4095 stubs: { symbol_file: "bar.map.txt", versions: ["28", "29", "current"] },
4096 bazel_module: { bp2build_available: false },
Spandan Das6d4d9da2023-04-18 06:20:40 +00004097 apex_available: ["//apex_available:platform",],
Yu Liu10174ff2023-02-21 12:05:26 -08004098}
4099cc_library {
4100 name: "bazlib",
4101 stubs: { symbol_file: "bar.map.txt", versions: ["28", "29", "current"] },
4102 bazel_module: { bp2build_available: false },
Spandan Das6d4d9da2023-04-18 06:20:40 +00004103 apex_available: ["//apex_available:platform",],
Yu Liu10174ff2023-02-21 12:05:26 -08004104}
4105cc_library {
4106 name: "foo",
4107 shared_libs: ["barlib", "bazlib"],
4108 export_shared_lib_headers: ["bazlib"],
4109 apex_available: [
Spandan Das6d4d9da2023-04-18 06:20:40 +00004110 "//apex_available:platform",
Yu Liu10174ff2023-02-21 12:05:26 -08004111 ],
4112}`,
4113 ExpectedBazelTargets: []string{
4114 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Spandan Das6d4d9da2023-04-18 06:20:40 +00004115 "implementation_dynamic_deps": `[":barlib"]`,
4116 "dynamic_deps": `[":bazlib"]`,
4117 "local_includes": `["."]`,
4118 "tags": `["apex_available=//apex_available:platform"]`,
Yu Liu10174ff2023-02-21 12:05:26 -08004119 }),
4120 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Spandan Das6d4d9da2023-04-18 06:20:40 +00004121 "implementation_dynamic_deps": `[":barlib"]`,
4122 "dynamic_deps": `[":bazlib"]`,
4123 "local_includes": `["."]`,
4124 "tags": `["apex_available=//apex_available:platform"]`,
Yu Liu10174ff2023-02-21 12:05:26 -08004125 }),
4126 },
4127 })
4128}
Trevor Radcliffe56b1a2b2023-02-06 21:58:30 +00004129
4130func TestCcLibraryWithThinLto(t *testing.T) {
4131 runCcLibraryTestCase(t, Bp2buildTestCase{
4132 Description: "cc_library has correct features when thin LTO is enabled",
4133 ModuleTypeUnderTest: "cc_library",
4134 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4135 Blueprint: `
4136cc_library {
4137 name: "foo",
4138 lto: {
4139 thin: true,
4140 },
4141}`,
4142 ExpectedBazelTargets: []string{
4143 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
4144 "features": `["android_thin_lto"]`,
4145 "local_includes": `["."]`,
4146 }),
4147 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
4148 "features": `["android_thin_lto"]`,
4149 "local_includes": `["."]`,
4150 }),
4151 },
4152 })
4153}
4154
4155func TestCcLibraryWithLtoNever(t *testing.T) {
4156 runCcLibraryTestCase(t, Bp2buildTestCase{
4157 Description: "cc_library has correct features when LTO is explicitly disabled",
4158 ModuleTypeUnderTest: "cc_library",
4159 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4160 Blueprint: `
4161cc_library {
4162 name: "foo",
4163 lto: {
4164 never: true,
4165 },
4166}`,
4167 ExpectedBazelTargets: []string{
4168 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
4169 "features": `["-android_thin_lto"]`,
4170 "local_includes": `["."]`,
4171 }),
4172 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
4173 "features": `["-android_thin_lto"]`,
4174 "local_includes": `["."]`,
4175 }),
4176 },
4177 })
4178}
4179
4180func TestCcLibraryWithThinLtoArchSpecific(t *testing.T) {
4181 runCcLibraryTestCase(t, Bp2buildTestCase{
4182 Description: "cc_library has correct features when LTO differs across arch and os variants",
4183 ModuleTypeUnderTest: "cc_library",
4184 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4185 Blueprint: `
4186cc_library {
4187 name: "foo",
4188 target: {
4189 android: {
4190 lto: {
4191 thin: true,
4192 },
4193 },
4194 },
4195 arch: {
4196 riscv64: {
4197 lto: {
4198 thin: false,
4199 },
4200 },
4201 },
4202}`,
4203 ExpectedBazelTargets: []string{
4204 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
4205 "local_includes": `["."]`,
4206 "features": `select({
4207 "//build/bazel/platforms/os_arch:android_arm": ["android_thin_lto"],
4208 "//build/bazel/platforms/os_arch:android_arm64": ["android_thin_lto"],
4209 "//build/bazel/platforms/os_arch:android_riscv64": ["-android_thin_lto"],
4210 "//build/bazel/platforms/os_arch:android_x86": ["android_thin_lto"],
4211 "//build/bazel/platforms/os_arch:android_x86_64": ["android_thin_lto"],
4212 "//conditions:default": [],
4213 })`}),
4214 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
4215 "local_includes": `["."]`,
4216 "features": `select({
4217 "//build/bazel/platforms/os_arch:android_arm": ["android_thin_lto"],
4218 "//build/bazel/platforms/os_arch:android_arm64": ["android_thin_lto"],
4219 "//build/bazel/platforms/os_arch:android_riscv64": ["-android_thin_lto"],
4220 "//build/bazel/platforms/os_arch:android_x86": ["android_thin_lto"],
4221 "//build/bazel/platforms/os_arch:android_x86_64": ["android_thin_lto"],
4222 "//conditions:default": [],
4223 })`}),
4224 },
4225 })
4226}
4227
4228func TestCcLibraryWithThinLtoDisabledDefaultEnabledVariant(t *testing.T) {
4229 runCcLibraryTestCase(t, Bp2buildTestCase{
4230 Description: "cc_library has correct features when LTO disabled by default but enabled on a particular variant",
4231 ModuleTypeUnderTest: "cc_library",
4232 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4233 Blueprint: `
4234cc_library {
4235 name: "foo",
4236 lto: {
4237 never: true,
4238 },
4239 target: {
4240 android: {
4241 lto: {
4242 thin: true,
4243 never: false,
4244 },
4245 },
4246 },
4247}`,
4248 ExpectedBazelTargets: []string{
4249 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
4250 "local_includes": `["."]`,
4251 "features": `select({
4252 "//build/bazel/platforms/os:android": ["android_thin_lto"],
4253 "//conditions:default": ["-android_thin_lto"],
4254 })`,
4255 }),
4256 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
4257 "local_includes": `["."]`,
4258 "features": `select({
4259 "//build/bazel/platforms/os:android": ["android_thin_lto"],
4260 "//conditions:default": ["-android_thin_lto"],
4261 })`,
4262 }),
4263 },
4264 })
4265}
4266
4267func TestCcLibraryWithThinLtoWholeProgramVtables(t *testing.T) {
4268 runCcLibraryTestCase(t, Bp2buildTestCase{
4269 Description: "cc_library has correct features when thin LTO is enabled with whole_program_vtables",
4270 ModuleTypeUnderTest: "cc_library",
4271 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4272 Blueprint: `
4273cc_library {
4274 name: "foo",
4275 lto: {
4276 thin: true,
4277 },
4278 whole_program_vtables: true,
4279}`,
4280 ExpectedBazelTargets: []string{
4281 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
4282 "features": `[
4283 "android_thin_lto",
4284 "android_thin_lto_whole_program_vtables",
4285 ]`,
4286 "local_includes": `["."]`,
4287 }),
4288 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
4289 "features": `[
4290 "android_thin_lto",
4291 "android_thin_lto_whole_program_vtables",
4292 ]`,
4293 "local_includes": `["."]`,
4294 }),
4295 },
4296 })
4297}
Trevor Radcliffea8b44162023-04-14 18:25:24 +00004298
4299func TestCcLibraryHiddenVisibilityConvertedToFeature(t *testing.T) {
4300 runCcLibraryTestCase(t, Bp2buildTestCase{
4301 Description: "cc_library changes hidden visibility flag to feature",
4302 ModuleTypeUnderTest: "cc_library",
4303 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4304 Blueprint: `
4305cc_library {
4306 name: "foo",
4307 cflags: ["-fvisibility=hidden"],
4308}`,
4309 ExpectedBazelTargets: []string{
4310 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
4311 "features": `["visibility_hidden"]`,
4312 "local_includes": `["."]`,
4313 }),
4314 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
4315 "features": `["visibility_hidden"]`,
4316 "local_includes": `["."]`,
4317 }),
4318 },
4319 })
4320}
4321
4322func TestCcLibraryHiddenVisibilityConvertedToFeatureSharedSpecific(t *testing.T) {
4323 runCcLibraryTestCase(t, Bp2buildTestCase{
4324 Description: "cc_library changes hidden visibility flag to feature when specific to shared variant",
4325 ModuleTypeUnderTest: "cc_library",
4326 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4327 Blueprint: `
4328cc_library {
4329 name: "foo",
4330 shared: {
4331 cflags: ["-fvisibility=hidden"],
4332 },
4333}`,
4334 ExpectedBazelTargets: []string{
4335 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
4336 "local_includes": `["."]`,
4337 }),
4338 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
4339 "features": `["visibility_hidden"]`,
4340 "local_includes": `["."]`,
4341 }),
4342 },
4343 })
4344}
4345
4346func TestCcLibraryHiddenVisibilityConvertedToFeatureStaticSpecific(t *testing.T) {
4347 runCcLibraryTestCase(t, Bp2buildTestCase{
4348 Description: "cc_library changes hidden visibility flag to feature when specific to static variant",
4349 ModuleTypeUnderTest: "cc_library",
4350 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4351 Blueprint: `
4352cc_library {
4353 name: "foo",
4354 static: {
4355 cflags: ["-fvisibility=hidden"],
4356 },
4357}`,
4358 ExpectedBazelTargets: []string{
4359 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
4360 "features": `["visibility_hidden"]`,
4361 "local_includes": `["."]`,
4362 }),
4363 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
4364 "local_includes": `["."]`,
4365 }),
4366 },
4367 })
4368}
4369
4370func TestCcLibraryHiddenVisibilityConvertedToFeatureOsSpecific(t *testing.T) {
4371 runCcLibraryTestCase(t, Bp2buildTestCase{
4372 Description: "cc_library changes hidden visibility flag to feature when specific to an os",
4373 ModuleTypeUnderTest: "cc_library",
4374 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4375 Blueprint: `
4376cc_library {
4377 name: "foo",
4378 target: {
4379 android: {
4380 cflags: ["-fvisibility=hidden"],
4381 },
4382 },
4383}`,
4384 ExpectedBazelTargets: []string{
4385 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
4386 "features": `select({
4387 "//build/bazel/platforms/os:android": ["visibility_hidden"],
4388 "//conditions:default": [],
4389 })`,
4390 "local_includes": `["."]`,
4391 }),
4392 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
4393 "features": `select({
4394 "//build/bazel/platforms/os:android": ["visibility_hidden"],
4395 "//conditions:default": [],
4396 })`,
4397 "local_includes": `["."]`,
4398 }),
4399 },
4400 })
4401}
Spandan Das4242f102023-04-19 22:31:54 +00004402
4403// Test that a config_setting specific to an apex is created by cc_library.
4404func TestCcLibraryCreatesInApexConfigSetting(t *testing.T) {
4405 runCcLibraryTestCase(t, Bp2buildTestCase{
4406 Description: "cc_library creates a config_setting for each apex in apex_available",
4407 ModuleTypeUnderTest: "cc_library",
4408 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4409 Dir: "build/bazel/rules/apex",
4410 Blueprint: `
4411cc_library {
4412 name: "foo",
4413 apex_available: [
4414 "//apex_available:platform", // This will be skipped, since it is equivalent to //build/bazel/rules/apex:android-non_apex
4415 "myapex"
4416 ],
4417}`,
4418 ExpectedBazelTargets: []string{
4419 MakeBazelTargetNoRestrictions(
4420 "config_setting",
Spandan Das9cad90f2023-05-04 17:15:44 +00004421 "myapex",
Spandan Das4242f102023-04-19 22:31:54 +00004422 AttrNameToString{
4423 "flag_values": `{
Spandan Das9cad90f2023-05-04 17:15:44 +00004424 "//build/bazel/rules/apex:api_domain": "myapex",
Spandan Das4242f102023-04-19 22:31:54 +00004425 }`,
Spandan Das9cad90f2023-05-04 17:15:44 +00004426 "constraint_values": `["//build/bazel/platforms/os:android"]`,
Spandan Das4242f102023-04-19 22:31:54 +00004427 },
4428 ),
4429 },
4430 })
4431}
Yu Liu93893ba2023-05-01 13:49:52 -07004432
4433func TestCcLibraryCppFlagsInProductVariables(t *testing.T) {
4434 runCcLibraryTestCase(t, Bp2buildTestCase{
4435 Description: "cc_library cppflags in product variables",
4436 ModuleTypeUnderTest: "cc_library",
4437 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4438 Blueprint: soongCcLibraryPreamble + `cc_library {
4439 name: "a",
4440 srcs: ["a.cpp"],
4441 cppflags: [
4442 "-Wextra",
4443 "-DDEBUG_ONLY_CODE=0",
4444 ],
4445 product_variables: {
4446 eng: {
4447 cppflags: [
4448 "-UDEBUG_ONLY_CODE",
4449 "-DDEBUG_ONLY_CODE=1",
4450 ],
4451 },
4452 },
4453 include_build_directory: false,
4454}
4455`,
4456 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
4457 "cppflags": `[
4458 "-Wextra",
4459 "-DDEBUG_ONLY_CODE=0",
4460 ] + select({
Cole Faust87c0c332023-07-31 12:10:12 -07004461 "//build/bazel/product_config/config_settings:eng": [
Yu Liu93893ba2023-05-01 13:49:52 -07004462 "-UDEBUG_ONLY_CODE",
4463 "-DDEBUG_ONLY_CODE=1",
4464 ],
4465 "//conditions:default": [],
4466 })`,
4467 "srcs": `["a.cpp"]`,
4468 }),
4469 },
4470 )
4471}
Spandan Dasdf4c2132023-05-09 23:58:52 +00004472
4473func TestCcLibraryYaccConversion(t *testing.T) {
4474 runCcLibraryTestCase(t, Bp2buildTestCase{
4475 Description: "cc_library is built from .y/.yy files",
4476 ModuleTypeUnderTest: "cc_library",
4477 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4478 Blueprint: soongCcLibraryPreamble + `cc_library {
4479 name: "a",
4480 srcs: [
4481 "a.cpp",
4482 "a.yy",
4483 ],
4484 shared_libs: ["sharedlib"],
4485 static_libs: ["staticlib"],
4486 yacc: {
4487 flags: ["someYaccFlag"],
4488 gen_location_hh: true,
4489 gen_position_hh: true,
4490 },
4491}
4492cc_library_static {
4493 name: "staticlib",
4494 bazel_module: { bp2build_available: false },
4495}
4496cc_library {
4497 name: "sharedlib",
4498 bazel_module: { bp2build_available: false },
4499}
4500`,
4501 ExpectedBazelTargets: []string{
4502 MakeBazelTarget("cc_yacc_static_library", "a_yacc", AttrNameToString{
4503 "src": `"a.yy"`,
4504 "implementation_deps": `[":staticlib"]`,
4505 "implementation_dynamic_deps": `[":sharedlib"]`,
4506 "flags": `["someYaccFlag"]`,
4507 "gen_location_hh": "True",
4508 "gen_position_hh": "True",
4509 "local_includes": `["."]`,
4510 }),
4511 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
4512 "srcs": `["a.cpp"]`,
4513 "implementation_deps": `[":staticlib"]`,
4514 "implementation_dynamic_deps": `[":sharedlib"]`,
4515 "implementation_whole_archive_deps": `[":a_yacc"]`,
4516 "local_includes": `["."]`,
4517 }),
4518 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
4519 "srcs": `["a.cpp"]`,
4520 "implementation_deps": `[":staticlib"]`,
4521 "implementation_dynamic_deps": `[":sharedlib"]`,
4522 "implementation_whole_archive_deps": `[":a_yacc"]`,
4523 "local_includes": `["."]`,
4524 }),
4525 },
4526 })
4527}
Spandan Dasfb04c412023-05-15 18:35:36 +00004528
4529func TestCcLibraryHostLdLibs(t *testing.T) {
4530 runCcLibraryTestCase(t, Bp2buildTestCase{
4531 Description: "cc_binary linker flags for host_ldlibs",
4532 ModuleTypeUnderTest: "cc_binary",
4533 ModuleTypeUnderTestFactory: cc.BinaryFactory,
4534 Blueprint: soongCcLibraryPreamble + `cc_binary {
4535 name: "a",
4536 host_supported: true,
4537 ldflags: ["-lcommon"],
4538 target: {
4539 linux: {
4540 host_ldlibs: [
4541 "-llinux",
4542 ],
4543 },
4544 darwin: {
4545 ldflags: ["-ldarwinadditional"],
4546 host_ldlibs: [
4547 "-ldarwin",
4548 ],
4549 },
4550 windows: {
4551 host_ldlibs: [
4552 "-lwindows",
4553 ],
4554 },
4555 },
4556}
4557`,
4558 ExpectedBazelTargets: []string{
4559 MakeBazelTargetNoRestrictions("cc_binary", "a", AttrNameToString{
4560 "linkopts": `["-lcommon"] + select({
4561 "//build/bazel/platforms/os:darwin": [
4562 "-ldarwinadditional",
4563 "-ldarwin",
4564 ],
4565 "//build/bazel/platforms/os:linux_glibc": ["-llinux"],
4566 "//build/bazel/platforms/os:windows": ["-lwindows"],
4567 "//conditions:default": [],
4568 })`,
4569 "local_includes": `["."]`,
4570 }),
4571 },
4572 })
4573}
Trevor Radcliffe27669c02023-03-28 20:47:10 +00004574
4575func TestCcLibraryWithCfi(t *testing.T) {
4576 runCcLibraryTestCase(t, Bp2buildTestCase{
4577 Description: "cc_library has correct features when cfi is enabled",
4578 ModuleTypeUnderTest: "cc_library",
4579 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4580 Blueprint: `
4581cc_library {
4582 name: "foo",
4583 sanitize: {
4584 cfi: true,
4585 },
4586}`,
4587 ExpectedBazelTargets: []string{
4588 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
4589 "features": `["android_cfi"]`,
4590 "local_includes": `["."]`,
4591 }),
4592 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
4593 "features": `["android_cfi"]`,
4594 "local_includes": `["."]`,
4595 }),
4596 },
4597 })
4598}
4599
4600func TestCcLibraryWithCfiOsSpecific(t *testing.T) {
4601 runCcLibraryTestCase(t, Bp2buildTestCase{
4602 Description: "cc_library has correct features when cfi is enabled for specific variants",
4603 ModuleTypeUnderTest: "cc_library",
4604 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4605 Blueprint: `
4606cc_library {
4607 name: "foo",
4608 target: {
4609 android: {
4610 sanitize: {
4611 cfi: true,
4612 },
4613 },
4614 },
4615}`,
4616 ExpectedBazelTargets: []string{
4617 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
4618 "features": `select({
4619 "//build/bazel/platforms/os:android": ["android_cfi"],
4620 "//conditions:default": [],
4621 })`,
4622 "local_includes": `["."]`,
4623 }),
4624 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
4625 "features": `select({
4626 "//build/bazel/platforms/os:android": ["android_cfi"],
4627 "//conditions:default": [],
4628 })`,
4629 "local_includes": `["."]`,
4630 }),
4631 },
4632 })
4633}
4634
4635func TestCcLibraryWithCfiAndCfiAssemblySupport(t *testing.T) {
4636 runCcLibraryTestCase(t, Bp2buildTestCase{
4637 Description: "cc_library has correct features when cfi is enabled with cfi_assembly_support",
4638 ModuleTypeUnderTest: "cc_library",
4639 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4640 Blueprint: `
4641cc_library {
4642 name: "foo",
4643 sanitize: {
4644 cfi: true,
4645 config: {
4646 cfi_assembly_support: true,
4647 },
4648 },
4649}`,
4650 ExpectedBazelTargets: []string{
4651 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
4652 "features": `[
4653 "android_cfi",
4654 "android_cfi_assembly_support",
4655 ]`,
4656 "local_includes": `["."]`,
4657 }),
4658 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
4659 "features": `[
4660 "android_cfi",
4661 "android_cfi_assembly_support",
4662 ]`,
4663 "local_includes": `["."]`,
4664 }),
4665 },
4666 })
4667}
Spandan Das39ccf932023-05-26 18:03:39 +00004668
Trevor Radcliffe523c5c62023-06-16 20:15:45 +00004669func TestCcLibraryExplicitlyDisablesCfiWhenFalse(t *testing.T) {
4670 runCcLibraryTestCase(t, Bp2buildTestCase{
4671 Description: "cc_library disables cfi when explciitly set to false in the bp",
4672 ModuleTypeUnderTest: "cc_library",
4673 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4674 Blueprint: `
4675cc_library {
4676 name: "foo",
4677 sanitize: {
4678 cfi: false,
4679 },
4680}
4681`,
4682 ExpectedBazelTargets: []string{
4683 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
4684 "features": `["-android_cfi"]`,
4685 "local_includes": `["."]`,
4686 }),
4687 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
4688 "features": `["-android_cfi"]`,
4689 "local_includes": `["."]`,
4690 }),
4691 },
4692 })
4693}
4694
Spandan Das39ccf932023-05-26 18:03:39 +00004695func TestCcLibraryWithStem(t *testing.T) {
4696 runCcLibraryTestCase(t, Bp2buildTestCase{
4697 Description: "cc_library with stem property",
4698 ModuleTypeUnderTest: "cc_library_shared",
4699 ModuleTypeUnderTestFactory: cc.LibrarySharedFactory,
4700 Blueprint: soongCcLibraryPreamble + `
4701cc_library_shared {
4702 name: "foo_with_stem_simple",
4703 stem: "foo",
4704}
4705cc_library_shared {
4706 name: "foo_with_arch_variant_stem",
4707 arch: {
4708 arm: {
4709 stem: "foo-arm",
4710 },
4711 arm64: {
4712 stem: "foo-arm64",
4713 },
4714 },
4715}
4716`,
4717 ExpectedBazelTargets: []string{
4718 MakeBazelTarget("cc_library_shared", "foo_with_stem_simple", AttrNameToString{
4719 "stem": `"foo"`,
4720 "local_includes": `["."]`,
4721 }),
4722 MakeBazelTarget("cc_library_shared", "foo_with_arch_variant_stem", AttrNameToString{
4723 "stem": `select({
4724 "//build/bazel/platforms/arch:arm": "foo-arm",
4725 "//build/bazel/platforms/arch:arm64": "foo-arm64",
4726 "//conditions:default": None,
4727 })`,
4728 "local_includes": `["."]`,
4729 }),
4730 },
4731 })
4732}
Spandan Dasc53767e2023-08-03 23:02:26 +00004733
4734// Bazel enforces that proto_library and the .proto file are in the same bazel package
4735func TestGenerateProtoLibraryInSamePackage(t *testing.T) {
4736 tc := Bp2buildTestCase{
4737 Description: "cc_library depends on .proto files from multiple packages",
4738 ModuleTypeUnderTest: "cc_library",
4739 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4740 Blueprint: `
4741cc_library_static {
4742 name: "foo",
4743 srcs: [
4744 "foo.proto",
4745 "bar/bar.proto", // Different package because there is a bar/Android.bp
4746 "baz/subbaz/baz.proto", // Different package because there is baz/subbaz/Android.bp
4747 ],
Liz Kammer7dc6bcb2023-08-10 12:51:59 -04004748 proto: {
4749 canonical_path_from_root: true,
4750 }
Spandan Dasc53767e2023-08-03 23:02:26 +00004751}
4752` + simpleModuleDoNotConvertBp2build("cc_library", "libprotobuf-cpp-lite"),
4753 Filesystem: map[string]string{
4754 "bar/Android.bp": "",
4755 "baz/subbaz/Android.bp": "",
4756 },
4757 }
4758
4759 // We will run the test 3 times and check in the root, bar and baz/subbaz directories
4760 // Root dir
4761 tc.ExpectedBazelTargets = []string{
4762 MakeBazelTarget("cc_library_static", "foo", AttrNameToString{
4763 "local_includes": `["."]`,
4764 "deps": `[":libprotobuf-cpp-lite"]`,
4765 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
4766 }),
4767 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
4768 "srcs": `["foo.proto"]`,
Spandan Dase0f2ed52023-08-22 18:19:44 +00004769 "tags": `["manual"]`,
Spandan Dasc53767e2023-08-03 23:02:26 +00004770 }),
4771 MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
4772 "deps": `[
4773 ":foo_proto",
4774 "//bar:foo_proto",
4775 "//baz/subbaz:foo_proto",
4776 ]`,
4777 }),
4778 }
4779 runCcLibraryTestCase(t, tc)
4780
4781 // bar dir
4782 tc.Dir = "bar"
4783 tc.ExpectedBazelTargets = []string{
4784 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer7dc6bcb2023-08-10 12:51:59 -04004785 "srcs": `["//bar:bar.proto"]`,
Spandan Das215adb42023-08-14 16:52:24 +00004786 "tags": `["manual"]`,
Spandan Dasc53767e2023-08-03 23:02:26 +00004787 }),
4788 }
4789 runCcLibraryTestCase(t, tc)
4790
4791 // baz/subbaz dir
4792 tc.Dir = "baz/subbaz"
4793 tc.ExpectedBazelTargets = []string{
4794 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer7dc6bcb2023-08-10 12:51:59 -04004795 "srcs": `["//baz/subbaz:baz.proto"]`,
Spandan Das215adb42023-08-14 16:52:24 +00004796 "tags": `["manual"]`,
Liz Kammer7dc6bcb2023-08-10 12:51:59 -04004797 }),
4798 }
4799 runCcLibraryTestCase(t, tc)
4800}
4801
4802// Bazel enforces that proto_library and the .proto file are in the same bazel package
4803func TestGenerateProtoLibraryInSamePackageNotCanonicalFromRoot(t *testing.T) {
4804 tc := Bp2buildTestCase{
4805 Description: "cc_library depends on .proto files from multiple packages",
4806 ModuleTypeUnderTest: "cc_library",
4807 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4808 Blueprint: `
4809cc_library_static {
4810 name: "foo",
4811 srcs: [
4812 "foo.proto",
4813 "bar/bar.proto", // Different package because there is a bar/Android.bp
4814 "baz/subbaz/baz.proto", // Different package because there is baz/subbaz/Android.bp
4815 ],
4816 proto: {
4817 canonical_path_from_root: false,
4818 }
4819}
4820` + simpleModuleDoNotConvertBp2build("cc_library", "libprotobuf-cpp-lite"),
4821 Filesystem: map[string]string{
4822 "bar/Android.bp": "",
4823 "baz/subbaz/Android.bp": "",
4824 },
4825 }
4826
4827 // We will run the test 3 times and check in the root, bar and baz/subbaz directories
4828 // Root dir
4829 tc.ExpectedBazelTargets = []string{
4830 MakeBazelTarget("cc_library_static", "foo", AttrNameToString{
4831 "local_includes": `["."]`,
4832 "deps": `[":libprotobuf-cpp-lite"]`,
4833 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
4834 }),
4835 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
4836 "srcs": `["foo.proto"]`,
4837 "strip_import_prefix": `""`,
Spandan Dase0f2ed52023-08-22 18:19:44 +00004838 "tags": `["manual"]`,
Liz Kammer7dc6bcb2023-08-10 12:51:59 -04004839 }),
4840 MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
4841 "deps": `[
4842 ":foo_proto",
4843 "//bar:foo_proto",
4844 "//baz/subbaz:foo_proto",
4845 ]`,
4846 }),
4847 }
4848 runCcLibraryTestCase(t, tc)
4849
4850 // bar dir
4851 tc.Dir = "bar"
4852 tc.ExpectedBazelTargets = []string{
4853 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
4854 "srcs": `["//bar:bar.proto"]`,
4855 "strip_import_prefix": `""`,
4856 "import_prefix": `"bar"`,
Spandan Das215adb42023-08-14 16:52:24 +00004857 "tags": `["manual"]`,
Liz Kammer7dc6bcb2023-08-10 12:51:59 -04004858 }),
4859 }
4860 runCcLibraryTestCase(t, tc)
4861
4862 // baz/subbaz dir
4863 tc.Dir = "baz/subbaz"
4864 tc.ExpectedBazelTargets = []string{
4865 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
4866 "srcs": `["//baz/subbaz:baz.proto"]`,
4867 "strip_import_prefix": `""`,
4868 "import_prefix": `"baz/subbaz"`,
Spandan Das215adb42023-08-14 16:52:24 +00004869 "tags": `["manual"]`,
Spandan Dasc53767e2023-08-03 23:02:26 +00004870 }),
4871 }
4872 runCcLibraryTestCase(t, tc)
4873}
Spandan Dasec39d512023-08-15 22:08:18 +00004874
4875func TestProtoIncludeDirs(t *testing.T) {
4876 tc := Bp2buildTestCase{
4877 Description: "cc_library depends on .proto files using proto.include_dirs",
4878 ModuleTypeUnderTest: "cc_library",
4879 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4880 Blueprint: `
4881cc_library_static {
4882 name: "foo",
4883 srcs: [
4884 "foo.proto",
4885 ],
4886 proto: {
4887 include_dirs: ["bar"],
4888 }
4889}
4890` + simpleModuleDoNotConvertBp2build("cc_library", "libprotobuf-cpp-lite"),
4891 Filesystem: map[string]string{
4892 "bar/Android.bp": "",
4893 "bar/bar.proto": "",
4894 "bar/baz/Android.bp": "",
4895 "bar/baz/baz.proto": "",
4896 },
4897 }
4898
4899 // We will run the test 3 times and check in the root, bar and bar/baz directories
4900 // Root dir
4901 tc.ExpectedBazelTargets = []string{
4902 MakeBazelTarget("cc_library_static", "foo", AttrNameToString{
4903 "local_includes": `["."]`,
4904 "deps": `[":libprotobuf-cpp-lite"]`,
4905 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
4906 }),
4907 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
4908 "srcs": `["foo.proto"]`,
Spandan Dase0f2ed52023-08-22 18:19:44 +00004909 "tags": `["manual"]`,
Spandan Dasec39d512023-08-15 22:08:18 +00004910 }),
4911 MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
4912 "deps": `[":foo_proto"]`,
4913 "transitive_deps": `[
4914 "//bar:bar.include_dir_bp2build_generated_proto",
4915 "//bar/baz:bar.include_dir_bp2build_generated_proto",
4916 ]`,
4917 }),
4918 }
4919 runCcLibraryTestCase(t, tc)
4920
4921 // bar dir
4922 tc.Dir = "bar"
4923 tc.ExpectedBazelTargets = []string{
Spandan Dasf26ee152023-08-24 23:21:04 +00004924 MakeBazelTargetNoRestrictions("proto_library", "bar.include_dir_bp2build_generated_proto", AttrNameToString{
Spandan Dasec39d512023-08-15 22:08:18 +00004925 "srcs": `["bar.proto"]`,
4926 "strip_import_prefix": `""`,
4927 "tags": `["manual"]`,
4928 }),
4929 }
4930 runCcLibraryTestCase(t, tc)
4931
4932 // bar/baz dir
4933 tc.Dir = "bar/baz"
4934 tc.ExpectedBazelTargets = []string{
Spandan Dasf26ee152023-08-24 23:21:04 +00004935 MakeBazelTargetNoRestrictions("proto_library", "bar.include_dir_bp2build_generated_proto", AttrNameToString{
Spandan Dasec39d512023-08-15 22:08:18 +00004936 "srcs": `["//bar/baz:baz.proto"]`,
4937 "strip_import_prefix": `""`,
4938 "import_prefix": `"baz"`,
4939 "tags": `["manual"]`,
4940 }),
4941 }
4942 runCcLibraryTestCase(t, tc)
4943}
Spandan Das4e5a1942023-08-22 19:20:39 +00004944
Spandan Dasf26ee152023-08-24 23:21:04 +00004945func TestProtoIncludeDirsWithSrcsInMultiplePackages(t *testing.T) {
4946 tc := Bp2buildTestCase{
4947 Description: "cc_library has srcs in multiple bazel packages and uses proto.include_dirs",
4948 ModuleTypeUnderTest: "cc_library",
4949 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4950 Blueprint: `
4951cc_library_static {
4952 name: "foo",
4953 srcs: [
4954 "foo.proto",
4955 "bar/bar.proto",
4956 ],
4957 proto: {
4958 include_dirs: ["baz"],
4959 }
4960}
4961` + simpleModuleDoNotConvertBp2build("cc_library", "libprotobuf-cpp-lite"),
4962 Filesystem: map[string]string{
4963 "bar/Android.bp": "", // package boundary
4964 "baz/Android.bp": "",
4965 "baz/baz.proto": "",
4966 },
4967 }
4968
4969 tc.ExpectedBazelTargets = []string{
4970 MakeBazelTarget("cc_library_static", "foo", AttrNameToString{
4971 "local_includes": `["."]`,
4972 "deps": `[":libprotobuf-cpp-lite"]`,
4973 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
4974 }),
4975 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
4976 "srcs": `["foo.proto"]`,
4977 "tags": `["manual"]`,
4978 }),
4979 MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
4980 "deps": `[
4981 ":foo_proto",
4982 "//bar:foo_proto",
4983 ]`,
4984 "transitive_deps": `["//baz:baz.include_dir_bp2build_generated_proto"]`,
4985 }),
4986 }
4987 runCcLibraryTestCase(t, tc)
4988
4989}
4990
Spandan Das4e5a1942023-08-22 19:20:39 +00004991func TestProtoLocalIncludeDirs(t *testing.T) {
4992 tc := Bp2buildTestCase{
4993 Description: "cc_library depends on .proto files using proto.local_include_dirs",
4994 ModuleTypeUnderTest: "cc_library",
4995 ModuleTypeUnderTestFactory: cc.LibraryFactory,
4996 Blueprint: simpleModuleDoNotConvertBp2build("cc_library", "libprotobuf-cpp-lite"),
4997 Filesystem: map[string]string{
4998 "foo/Android.bp": `cc_library_static {
4999 name: "foo",
5000 srcs: [
5001 "foo.proto",
5002 ],
5003 proto: {
5004 local_include_dirs: ["foo_subdir"],
5005 },
5006 bazel_module: { bp2build_available: true },
5007}`,
5008 "foo/foo.proto": "",
5009 "foo/foo_subdir/Android.bp": "",
5010 "foo/foo_subdir/foo_subdir.proto": "",
5011 },
5012 }
5013
5014 // We will run the test 2 times and check in foo and foo/foo_subdir directories
5015 // foo dir
5016 tc.Dir = "foo"
5017 tc.ExpectedBazelTargets = []string{
5018 MakeBazelTarget("cc_library_static", "foo", AttrNameToString{
5019 "local_includes": `["."]`,
5020 "deps": `["//:libprotobuf-cpp-lite"]`,
5021 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
5022 }),
5023 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
5024 "srcs": `["foo.proto"]`,
5025 "tags": `["manual"]`,
5026 }),
5027 MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
5028 "deps": `[":foo_proto"]`,
5029 "transitive_deps": `["//foo/foo_subdir:foo.foo_subdir.include_dir_bp2build_generated_proto"]`,
5030 }),
5031 }
5032 runCcLibraryTestCase(t, tc)
5033
5034 // foo/foo_subdir
5035 tc.Dir = "foo/foo_subdir"
5036 tc.ExpectedBazelTargets = []string{
Spandan Dasf26ee152023-08-24 23:21:04 +00005037 MakeBazelTargetNoRestrictions("proto_library", "foo.foo_subdir.include_dir_bp2build_generated_proto", AttrNameToString{
Spandan Das4e5a1942023-08-22 19:20:39 +00005038 "srcs": `["foo_subdir.proto"]`,
5039 "strip_import_prefix": `""`,
5040 "tags": `["manual"]`,
5041 }),
5042 }
5043 runCcLibraryTestCase(t, tc)
5044}