Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 1 | // Copyright 2017 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package java |
| 16 | |
| 17 | import ( |
Paul Duffin | 1a39332 | 2020-11-18 16:36:47 +0000 | [diff] [blame] | 18 | "fmt" |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 19 | "os" |
| 20 | "path/filepath" |
Colin Cross | c080617 | 2019-06-14 18:51:47 -0700 | [diff] [blame] | 21 | "reflect" |
Colin Cross | f8d9c49 | 2021-01-26 11:01:43 -0800 | [diff] [blame] | 22 | "runtime" |
Colin Cross | c9b4f6b | 2024-07-26 15:25:46 -0700 | [diff] [blame] | 23 | "slices" |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 24 | "strconv" |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 25 | "strings" |
| 26 | "testing" |
Colin Cross | 86a60ae | 2018-05-29 14:44:55 -0700 | [diff] [blame] | 27 | |
Spandan Das | 3cf0463 | 2024-01-19 00:22:22 +0000 | [diff] [blame] | 28 | "github.com/google/blueprint" |
Jeongik Cha | 28df257 | 2019-11-11 10:46:36 +0900 | [diff] [blame] | 29 | "github.com/google/blueprint/proptools" |
| 30 | |
Jihoon Kang | 84b2589 | 2023-12-01 22:01:06 +0000 | [diff] [blame] | 31 | "android/soong/aconfig" |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 32 | "android/soong/android" |
| 33 | "android/soong/cc" |
Colin Cross | c28bb0b | 2019-02-25 14:20:47 -0800 | [diff] [blame] | 34 | "android/soong/dexpreopt" |
Colin Cross | 1661aff | 2021-03-12 17:56:51 -0800 | [diff] [blame] | 35 | "android/soong/genrule" |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 36 | ) |
| 37 | |
Paul Duffin | 70d3bee | 2021-03-21 11:26:05 +0000 | [diff] [blame] | 38 | // Legacy preparer used for running tests within the java package. |
| 39 | // |
| 40 | // This includes everything that was needed to run any test in the java package prior to the |
| 41 | // introduction of the test fixtures. Tests that are being converted to use fixtures directly |
| 42 | // rather than through the testJava...() methods should avoid using this and instead use the |
| 43 | // various preparers directly, using android.GroupFixturePreparers(...) to group them when |
| 44 | // necessary. |
| 45 | // |
| 46 | // deprecated |
| 47 | var prepareForJavaTest = android.GroupFixturePreparers( |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 48 | genrule.PrepareForTestWithGenRuleBuildComponents, |
| 49 | // Get the CC build components but not default modules. |
| 50 | cc.PrepareForTestWithCcBuildComponents, |
| 51 | // Include all the default java modules. |
Jiakai Zhang | b95998b | 2023-05-11 16:39:27 +0100 | [diff] [blame] | 52 | PrepareForTestWithDexpreopt, |
Jihoon Kang | 84b2589 | 2023-12-01 22:01:06 +0000 | [diff] [blame] | 53 | // Include aconfig modules. |
| 54 | aconfig.PrepareForTestWithAconfigBuildComponents, |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 55 | ) |
| 56 | |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 57 | func TestMain(m *testing.M) { |
Paul Duffin | d6339af | 2021-03-22 18:05:04 +0000 | [diff] [blame] | 58 | os.Exit(m.Run()) |
Colin Cross | 527012a | 2017-11-30 22:56:16 -0800 | [diff] [blame] | 59 | } |
| 60 | |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 61 | // testJavaError is a legacy way of running tests of java modules that expect errors. |
| 62 | // |
| 63 | // See testJava for an explanation as to how to stop using this deprecated method. |
| 64 | // |
| 65 | // deprecated |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 66 | func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) { |
Jeongik Cha | 538c0d0 | 2019-07-11 15:54:27 +0900 | [diff] [blame] | 67 | t.Helper() |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 68 | result := android.GroupFixturePreparers( |
Paul Duffin | 9fc9f53 | 2021-03-23 15:41:11 +0000 | [diff] [blame] | 69 | prepareForJavaTest, dexpreopt.PrepareForTestByEnablingDexpreopt). |
Paul Duffin | 6bac49c | 2021-03-12 21:28:15 +0000 | [diff] [blame] | 70 | ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)). |
| 71 | RunTestWithBp(t, bp) |
| 72 | return result.TestContext, result.Config |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 73 | } |
| 74 | |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 75 | // testJavaWithFS runs tests using the prepareForJavaTest |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 76 | // |
| 77 | // See testJava for an explanation as to how to stop using this deprecated method. |
| 78 | // |
| 79 | // deprecated |
| 80 | func testJavaWithFS(t *testing.T, bp string, fs android.MockFS) (*android.TestContext, android.Config) { |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 81 | t.Helper() |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 82 | result := android.GroupFixturePreparers( |
| 83 | prepareForJavaTest, fs.AddToFixture()).RunTestWithBp(t, bp) |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 84 | return result.TestContext, result.Config |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 85 | } |
| 86 | |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 87 | // testJava runs tests using the prepareForJavaTest |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 88 | // |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 89 | // Do not add any new usages of this, instead use the prepareForJavaTest directly as it makes it |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 90 | // much easier to customize the test behavior. |
| 91 | // |
| 92 | // If it is necessary to customize the behavior of an existing test that uses this then please first |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 93 | // convert the test to using prepareForJavaTest first and then in a following change add the |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 94 | // appropriate fixture preparers. Keeping the conversion change separate makes it easy to verify |
| 95 | // that it did not change the test behavior unexpectedly. |
| 96 | // |
| 97 | // deprecated |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 98 | func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) { |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 99 | t.Helper() |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 100 | result := prepareForJavaTest.RunTestWithBp(t, bp) |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 101 | return result.TestContext, result.Config |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 102 | } |
| 103 | |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 104 | // defaultModuleToPath constructs a path to the turbine generate jar for a default test module that |
| 105 | // is defined in PrepareForIntegrationTestWithJava |
| 106 | func defaultModuleToPath(name string) string { |
Paul Duffin | 76101fa | 2021-03-13 09:55:25 +0000 | [diff] [blame] | 107 | switch { |
| 108 | case name == `""`: |
| 109 | return name |
| 110 | case strings.HasSuffix(name, ".jar"): |
| 111 | return name |
| 112 | default: |
Colin Cross | 8ff4af3 | 2025-02-19 15:17:02 -0800 | [diff] [blame] | 113 | return filepath.Join("out", "soong", ".intermediates", defaultJavaDir, name, "android_common", "turbine", name+".jar") |
Paul Duffin | 76101fa | 2021-03-13 09:55:25 +0000 | [diff] [blame] | 114 | } |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 115 | } |
| 116 | |
Paul Duffin | 76e5c8a | 2021-03-20 14:19:46 +0000 | [diff] [blame] | 117 | // Test that the PrepareForTestWithJavaDefaultModules provides all the files that it uses by |
| 118 | // running it in a fixture that requires all source files to exist. |
| 119 | func TestPrepareForTestWithJavaDefaultModules(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 120 | t.Parallel() |
Paul Duffin | 76e5c8a | 2021-03-20 14:19:46 +0000 | [diff] [blame] | 121 | android.GroupFixturePreparers( |
| 122 | PrepareForTestWithJavaDefaultModules, |
| 123 | android.PrepareForTestDisallowNonExistentPaths, |
| 124 | ).RunTest(t) |
| 125 | } |
| 126 | |
Jeongik Cha | e403e9e | 2019-12-07 00:16:24 +0900 | [diff] [blame] | 127 | func TestJavaLinkType(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 128 | t.Parallel() |
Jeongik Cha | e403e9e | 2019-12-07 00:16:24 +0900 | [diff] [blame] | 129 | testJava(t, ` |
| 130 | java_library { |
| 131 | name: "foo", |
| 132 | srcs: ["a.java"], |
| 133 | libs: ["bar"], |
| 134 | static_libs: ["baz"], |
| 135 | } |
| 136 | |
| 137 | java_library { |
| 138 | name: "bar", |
| 139 | sdk_version: "current", |
| 140 | srcs: ["b.java"], |
| 141 | } |
| 142 | |
| 143 | java_library { |
| 144 | name: "baz", |
| 145 | sdk_version: "system_current", |
| 146 | srcs: ["c.java"], |
| 147 | } |
| 148 | `) |
| 149 | |
Steven Moreland | 0029898 | 2020-11-17 21:44:36 +0000 | [diff] [blame] | 150 | testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", ` |
Jeongik Cha | e403e9e | 2019-12-07 00:16:24 +0900 | [diff] [blame] | 151 | java_library { |
| 152 | name: "foo", |
| 153 | srcs: ["a.java"], |
| 154 | libs: ["bar"], |
| 155 | sdk_version: "current", |
| 156 | static_libs: ["baz"], |
| 157 | } |
| 158 | |
| 159 | java_library { |
| 160 | name: "bar", |
| 161 | sdk_version: "current", |
| 162 | srcs: ["b.java"], |
| 163 | } |
| 164 | |
| 165 | java_library { |
| 166 | name: "baz", |
| 167 | sdk_version: "system_current", |
| 168 | srcs: ["c.java"], |
| 169 | } |
| 170 | `) |
| 171 | |
| 172 | testJava(t, ` |
| 173 | java_library { |
| 174 | name: "foo", |
| 175 | srcs: ["a.java"], |
| 176 | libs: ["bar"], |
| 177 | sdk_version: "system_current", |
| 178 | static_libs: ["baz"], |
| 179 | } |
| 180 | |
| 181 | java_library { |
| 182 | name: "bar", |
| 183 | sdk_version: "current", |
| 184 | srcs: ["b.java"], |
| 185 | } |
| 186 | |
| 187 | java_library { |
| 188 | name: "baz", |
| 189 | sdk_version: "system_current", |
| 190 | srcs: ["c.java"], |
| 191 | } |
| 192 | `) |
| 193 | |
Steven Moreland | 0029898 | 2020-11-17 21:44:36 +0000 | [diff] [blame] | 194 | testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", ` |
Jeongik Cha | e403e9e | 2019-12-07 00:16:24 +0900 | [diff] [blame] | 195 | java_library { |
| 196 | name: "foo", |
| 197 | srcs: ["a.java"], |
| 198 | libs: ["bar"], |
| 199 | sdk_version: "system_current", |
| 200 | static_libs: ["baz"], |
| 201 | } |
| 202 | |
| 203 | java_library { |
| 204 | name: "bar", |
| 205 | sdk_version: "current", |
| 206 | srcs: ["b.java"], |
| 207 | } |
| 208 | |
| 209 | java_library { |
| 210 | name: "baz", |
| 211 | srcs: ["c.java"], |
| 212 | } |
| 213 | `) |
| 214 | } |
| 215 | |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 216 | func TestSimple(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 217 | t.Parallel() |
Colin Cross | c9b4f6b | 2024-07-26 15:25:46 -0700 | [diff] [blame] | 218 | bp := ` |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 219 | java_library { |
| 220 | name: "foo", |
| 221 | srcs: ["a.java"], |
Colin Cross | e8dc34a | 2017-07-19 11:22:16 -0700 | [diff] [blame] | 222 | libs: ["bar"], |
| 223 | static_libs: ["baz"], |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 224 | } |
| 225 | |
| 226 | java_library { |
| 227 | name: "bar", |
| 228 | srcs: ["b.java"], |
Colin Cross | c9b4f6b | 2024-07-26 15:25:46 -0700 | [diff] [blame] | 229 | static_libs: ["quz"], |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 230 | } |
| 231 | |
| 232 | java_library { |
| 233 | name: "baz", |
| 234 | srcs: ["c.java"], |
Colin Cross | c9b4f6b | 2024-07-26 15:25:46 -0700 | [diff] [blame] | 235 | static_libs: ["quz"], |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 236 | } |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 237 | |
Colin Cross | c9b4f6b | 2024-07-26 15:25:46 -0700 | [diff] [blame] | 238 | java_library { |
| 239 | name: "quz", |
| 240 | srcs: ["d.java"], |
| 241 | }` |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 242 | |
Colin Cross | c9b4f6b | 2024-07-26 15:25:46 -0700 | [diff] [blame] | 243 | frameworkTurbineJars := []string{ |
| 244 | "out/soong/.intermediates/default/java/ext/android_common/turbine/ext.jar", |
| 245 | "out/soong/.intermediates/default/java/framework/android_common/turbine/framework.jar", |
| 246 | } |
Colin Cross | 0a6e007 | 2017-08-30 14:24:55 -0700 | [diff] [blame] | 247 | |
Colin Cross | c9b4f6b | 2024-07-26 15:25:46 -0700 | [diff] [blame] | 248 | testCases := []struct { |
| 249 | name string |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 250 | |
Colin Cross | c9b4f6b | 2024-07-26 15:25:46 -0700 | [diff] [blame] | 251 | preparer android.FixturePreparer |
Colin Cross | 0a6e007 | 2017-08-30 14:24:55 -0700 | [diff] [blame] | 252 | |
Colin Cross | c9b4f6b | 2024-07-26 15:25:46 -0700 | [diff] [blame] | 253 | fooJavacInputs []string |
| 254 | fooJavacClasspath []string |
| 255 | fooCombinedInputs []string |
| 256 | fooHeaderCombinedInputs []string |
| 257 | |
| 258 | barJavacInputs []string |
| 259 | barJavacClasspath []string |
| 260 | barCombinedInputs []string |
| 261 | barHeaderCombinedInputs []string |
| 262 | }{ |
| 263 | { |
| 264 | name: "normal", |
| 265 | preparer: android.NullFixturePreparer, |
| 266 | fooJavacInputs: []string{"a.java"}, |
| 267 | fooJavacClasspath: slices.Concat( |
Colin Cross | c9b4f6b | 2024-07-26 15:25:46 -0700 | [diff] [blame] | 268 | frameworkTurbineJars, |
| 269 | []string{ |
| 270 | "out/soong/.intermediates/bar/android_common/turbine/bar.jar", |
| 271 | "out/soong/.intermediates/quz/android_common/turbine/quz.jar", |
| 272 | "out/soong/.intermediates/baz/android_common/turbine/baz.jar", |
| 273 | }, |
| 274 | ), |
| 275 | fooCombinedInputs: []string{ |
| 276 | "out/soong/.intermediates/foo/android_common/javac/foo.jar", |
| 277 | "out/soong/.intermediates/baz/android_common/javac/baz.jar", |
| 278 | "out/soong/.intermediates/quz/android_common/javac/quz.jar", |
| 279 | }, |
| 280 | |
| 281 | fooHeaderCombinedInputs: []string{ |
| 282 | "out/soong/.intermediates/foo/android_common/turbine/foo.jar", |
| 283 | "out/soong/.intermediates/baz/android_common/turbine/baz.jar", |
| 284 | "out/soong/.intermediates/quz/android_common/turbine/quz.jar", |
| 285 | }, |
| 286 | |
| 287 | barJavacInputs: []string{"b.java"}, |
| 288 | barJavacClasspath: slices.Concat( |
| 289 | frameworkTurbineJars, |
| 290 | []string{"out/soong/.intermediates/quz/android_common/turbine/quz.jar"}, |
| 291 | ), |
| 292 | barCombinedInputs: []string{ |
| 293 | "out/soong/.intermediates/bar/android_common/javac/bar.jar", |
| 294 | "out/soong/.intermediates/quz/android_common/javac/quz.jar", |
| 295 | }, |
| 296 | barHeaderCombinedInputs: []string{ |
| 297 | "out/soong/.intermediates/bar/android_common/turbine/bar.jar", |
| 298 | "out/soong/.intermediates/quz/android_common/turbine/quz.jar", |
| 299 | }, |
| 300 | }, |
| 301 | } |
| 302 | |
| 303 | for _, tt := range testCases { |
| 304 | t.Run(tt.name, func(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 305 | t.Parallel() |
Colin Cross | c9b4f6b | 2024-07-26 15:25:46 -0700 | [diff] [blame] | 306 | result := android.GroupFixturePreparers( |
| 307 | PrepareForTestWithJavaDefaultModules, |
| 308 | tt.preparer, |
| 309 | ).RunTestWithBp(t, bp) |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 310 | foo := result.ModuleForTests(t, "foo", "android_common") |
Colin Cross | c9b4f6b | 2024-07-26 15:25:46 -0700 | [diff] [blame] | 311 | |
| 312 | fooJavac := foo.Rule("javac") |
| 313 | android.AssertPathsRelativeToTopEquals(t, "foo javac inputs", tt.fooJavacInputs, fooJavac.Inputs) |
| 314 | |
| 315 | fooJavacClasspath := fooJavac.Args["classpath"] |
| 316 | android.AssertStringPathsRelativeToTopEquals(t, "foo javac classpath", result.Config, tt.fooJavacClasspath, |
| 317 | strings.Split(strings.TrimPrefix(fooJavacClasspath, "-classpath "), ":")) |
| 318 | |
| 319 | fooCombinedJar := foo.Output("combined/foo.jar") |
| 320 | android.AssertPathsRelativeToTopEquals(t, "foo combined inputs", tt.fooCombinedInputs, fooCombinedJar.Inputs) |
| 321 | |
| 322 | fooCombinedHeaderJar := foo.Output("turbine-combined/foo.jar") |
| 323 | android.AssertPathsRelativeToTopEquals(t, "foo header combined inputs", tt.fooHeaderCombinedInputs, fooCombinedHeaderJar.Inputs) |
| 324 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 325 | bar := result.ModuleForTests(t, "bar", "android_common") |
Colin Cross | c9b4f6b | 2024-07-26 15:25:46 -0700 | [diff] [blame] | 326 | barJavac := bar.Rule("javac") |
| 327 | android.AssertPathsRelativeToTopEquals(t, "bar javac inputs", tt.barJavacInputs, barJavac.Inputs) |
| 328 | |
| 329 | barJavacClasspath := barJavac.Args["classpath"] |
| 330 | android.AssertStringPathsRelativeToTopEquals(t, "bar javac classpath", result.Config, tt.barJavacClasspath, |
| 331 | strings.Split(strings.TrimPrefix(barJavacClasspath, "-classpath "), ":")) |
| 332 | |
| 333 | barCombinedJar := bar.Output("combined/bar.jar") |
| 334 | android.AssertPathsRelativeToTopEquals(t, "bar combined inputs", tt.barCombinedInputs, barCombinedJar.Inputs) |
| 335 | |
| 336 | barCombinedHeaderJar := bar.Output("turbine-combined/bar.jar") |
| 337 | android.AssertPathsRelativeToTopEquals(t, "bar header combined inputs", tt.barHeaderCombinedInputs, barCombinedHeaderJar.Inputs) |
| 338 | }) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 339 | } |
| 340 | } |
| 341 | |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 342 | func TestExportedPlugins(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 343 | t.Parallel() |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 344 | type Result struct { |
Colin Cross | c9fe10f | 2020-11-19 18:06:03 -0800 | [diff] [blame] | 345 | library string |
| 346 | processors string |
| 347 | disableTurbine bool |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 348 | } |
| 349 | var tests = []struct { |
| 350 | name string |
| 351 | extra string |
| 352 | results []Result |
| 353 | }{ |
| 354 | { |
| 355 | name: "Exported plugin is not a direct plugin", |
| 356 | extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`, |
| 357 | results: []Result{{library: "exports", processors: "-proc:none"}}, |
| 358 | }, |
| 359 | { |
| 360 | name: "Exports plugin to dependee", |
| 361 | extra: ` |
| 362 | java_library{name: "exports", exported_plugins: ["plugin"]} |
| 363 | java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]} |
| 364 | java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]} |
| 365 | `, |
| 366 | results: []Result{ |
| 367 | {library: "foo", processors: "-processor com.android.TestPlugin"}, |
| 368 | {library: "bar", processors: "-processor com.android.TestPlugin"}, |
| 369 | }, |
| 370 | }, |
| 371 | { |
| 372 | name: "Exports plugin to android_library", |
| 373 | extra: ` |
| 374 | java_library{name: "exports", exported_plugins: ["plugin"]} |
| 375 | android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]} |
| 376 | android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]} |
| 377 | `, |
| 378 | results: []Result{ |
| 379 | {library: "foo", processors: "-processor com.android.TestPlugin"}, |
| 380 | {library: "bar", processors: "-processor com.android.TestPlugin"}, |
| 381 | }, |
| 382 | }, |
| 383 | { |
| 384 | name: "Exports plugin is not propagated via transitive deps", |
| 385 | extra: ` |
| 386 | java_library{name: "exports", exported_plugins: ["plugin"]} |
| 387 | java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]} |
| 388 | java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]} |
| 389 | `, |
| 390 | results: []Result{ |
| 391 | {library: "foo", processors: "-processor com.android.TestPlugin"}, |
| 392 | {library: "bar", processors: "-proc:none"}, |
| 393 | }, |
| 394 | }, |
| 395 | { |
| 396 | name: "Exports plugin appends to plugins", |
| 397 | extra: ` |
| 398 | java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"} |
| 399 | java_library{name: "exports", exported_plugins: ["plugin"]} |
| 400 | java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]} |
| 401 | `, |
| 402 | results: []Result{ |
| 403 | {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"}, |
| 404 | }, |
| 405 | }, |
Colin Cross | c9fe10f | 2020-11-19 18:06:03 -0800 | [diff] [blame] | 406 | { |
| 407 | name: "Exports plugin to with generates_api to dependee", |
| 408 | extra: ` |
| 409 | java_library{name: "exports", exported_plugins: ["plugin_generates_api"]} |
| 410 | java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]} |
| 411 | java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]} |
| 412 | `, |
| 413 | results: []Result{ |
| 414 | {library: "foo", processors: "-processor com.android.TestPlugin", disableTurbine: true}, |
| 415 | {library: "bar", processors: "-processor com.android.TestPlugin", disableTurbine: true}, |
| 416 | }, |
| 417 | }, |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 418 | } |
| 419 | |
| 420 | for _, test := range tests { |
| 421 | t.Run(test.name, func(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 422 | t.Parallel() |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 423 | ctx, _ := testJava(t, ` |
| 424 | java_plugin { |
| 425 | name: "plugin", |
| 426 | processor_class: "com.android.TestPlugin", |
| 427 | } |
Colin Cross | c9fe10f | 2020-11-19 18:06:03 -0800 | [diff] [blame] | 428 | java_plugin { |
| 429 | name: "plugin_generates_api", |
| 430 | generates_api: true, |
| 431 | processor_class: "com.android.TestPlugin", |
| 432 | } |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 433 | `+test.extra) |
| 434 | |
| 435 | for _, want := range test.results { |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 436 | javac := ctx.ModuleForTests(t, want.library, "android_common").Rule("javac") |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 437 | if javac.Args["processor"] != want.processors { |
| 438 | t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"]) |
| 439 | } |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 440 | turbine := ctx.ModuleForTests(t, want.library, "android_common").MaybeRule("turbine") |
Colin Cross | c9fe10f | 2020-11-19 18:06:03 -0800 | [diff] [blame] | 441 | disableTurbine := turbine.BuildParams.Rule == nil |
| 442 | if disableTurbine != want.disableTurbine { |
| 443 | t.Errorf("For library %v, expected disableTurbine %v, found %v", want.library, want.disableTurbine, disableTurbine) |
| 444 | } |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 445 | } |
| 446 | }) |
| 447 | } |
| 448 | } |
| 449 | |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 450 | func TestSdkVersionByPartition(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 451 | t.Parallel() |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 452 | testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", ` |
Jeongik Cha | 6bd33c1 | 2019-06-25 16:26:18 +0900 | [diff] [blame] | 453 | java_library { |
| 454 | name: "foo", |
| 455 | srcs: ["a.java"], |
| 456 | vendor: true, |
| 457 | } |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 458 | `) |
Jeongik Cha | 6bd33c1 | 2019-06-25 16:26:18 +0900 | [diff] [blame] | 459 | |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 460 | testJava(t, ` |
Jeongik Cha | 6bd33c1 | 2019-06-25 16:26:18 +0900 | [diff] [blame] | 461 | java_library { |
| 462 | name: "bar", |
| 463 | srcs: ["b.java"], |
| 464 | } |
| 465 | `) |
| 466 | |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 467 | for _, enforce := range []bool{true, false} { |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 468 | bp := ` |
| 469 | java_library { |
| 470 | name: "foo", |
| 471 | srcs: ["a.java"], |
| 472 | product_specific: true, |
| 473 | } |
| 474 | ` |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 475 | |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 476 | errorHandler := android.FixtureExpectsNoErrors |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 477 | if enforce { |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 478 | errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern("sdk_version must have a value when the module is located at vendor or product") |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 479 | } |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 480 | |
| 481 | android.GroupFixturePreparers( |
| 482 | PrepareForTestWithJavaDefaultModules, |
| 483 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 484 | variables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce) |
| 485 | }), |
| 486 | ). |
| 487 | ExtendWithErrorHandler(errorHandler). |
| 488 | RunTestWithBp(t, bp) |
Jeongik Cha | 6bd33c1 | 2019-06-25 16:26:18 +0900 | [diff] [blame] | 489 | } |
| 490 | } |
| 491 | |
Colin Cross | d5934c8 | 2017-10-02 13:55:26 -0700 | [diff] [blame] | 492 | func TestArchSpecific(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 493 | t.Parallel() |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 494 | ctx, _ := testJava(t, ` |
Colin Cross | d5934c8 | 2017-10-02 13:55:26 -0700 | [diff] [blame] | 495 | java_library { |
| 496 | name: "foo", |
| 497 | srcs: ["a.java"], |
| 498 | target: { |
| 499 | android: { |
| 500 | srcs: ["b.java"], |
| 501 | }, |
| 502 | }, |
| 503 | } |
| 504 | `) |
| 505 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 506 | javac := ctx.ModuleForTests(t, "foo", "android_common").Rule("javac") |
Colin Cross | d5934c8 | 2017-10-02 13:55:26 -0700 | [diff] [blame] | 507 | if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" { |
| 508 | t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs) |
| 509 | } |
| 510 | } |
| 511 | |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 512 | func TestBinary(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 513 | t.Parallel() |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 514 | ctx, _ := testJava(t, ` |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 515 | java_library_host { |
| 516 | name: "foo", |
| 517 | srcs: ["a.java"], |
| 518 | } |
| 519 | |
| 520 | java_binary_host { |
| 521 | name: "bar", |
| 522 | srcs: ["b.java"], |
| 523 | static_libs: ["foo"], |
Colin Cross | 89226d9 | 2020-10-09 19:00:54 -0700 | [diff] [blame] | 524 | jni_libs: ["libjni"], |
| 525 | } |
| 526 | |
| 527 | cc_library_shared { |
| 528 | name: "libjni", |
| 529 | host_supported: true, |
| 530 | device_supported: false, |
| 531 | stl: "none", |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 532 | } |
| 533 | `) |
| 534 | |
Colin Cross | 0c66bc6 | 2021-07-20 09:47:41 -0700 | [diff] [blame] | 535 | buildOS := ctx.Config().BuildOS.String() |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 536 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 537 | bar := ctx.ModuleForTests(t, "bar", buildOS+"_common") |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 538 | barJar := bar.Output("bar.jar").Output.String() |
Cole Faust | b9c67e2 | 2024-10-08 16:39:56 -0700 | [diff] [blame] | 539 | barWrapperDeps := bar.Output("bar").Implicits.Strings() |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 540 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 541 | libjni := ctx.ModuleForTests(t, "libjni", buildOS+"_x86_64_shared") |
Colin Cross | 89226d9 | 2020-10-09 19:00:54 -0700 | [diff] [blame] | 542 | libjniSO := libjni.Rule("Cp").Output.String() |
| 543 | |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 544 | // Test that the install binary wrapper depends on the installed jar file |
Colin Cross | c179ea6 | 2020-10-09 10:54:15 -0700 | [diff] [blame] | 545 | if g, w := barWrapperDeps, barJar; !android.InList(w, g) { |
| 546 | t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g) |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 547 | } |
Colin Cross | 89226d9 | 2020-10-09 19:00:54 -0700 | [diff] [blame] | 548 | |
| 549 | // Test that the install binary wrapper depends on the installed JNI libraries |
| 550 | if g, w := barWrapperDeps, libjniSO; !android.InList(w, g) { |
| 551 | t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g) |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 552 | } |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 553 | } |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 554 | |
Colin Cross | f8d9c49 | 2021-01-26 11:01:43 -0800 | [diff] [blame] | 555 | func TestTest(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 556 | t.Parallel() |
Colin Cross | f8d9c49 | 2021-01-26 11:01:43 -0800 | [diff] [blame] | 557 | ctx, _ := testJava(t, ` |
| 558 | java_test_host { |
| 559 | name: "foo", |
| 560 | srcs: ["a.java"], |
| 561 | jni_libs: ["libjni"], |
| 562 | } |
| 563 | |
| 564 | cc_library_shared { |
| 565 | name: "libjni", |
| 566 | host_supported: true, |
| 567 | device_supported: false, |
| 568 | stl: "none", |
| 569 | } |
| 570 | `) |
| 571 | |
Colin Cross | 0c66bc6 | 2021-07-20 09:47:41 -0700 | [diff] [blame] | 572 | buildOS := ctx.Config().BuildOS.String() |
Colin Cross | f8d9c49 | 2021-01-26 11:01:43 -0800 | [diff] [blame] | 573 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 574 | foo := ctx.ModuleForTests(t, "foo", buildOS+"_common").Module().(*TestHost) |
Colin Cross | f8d9c49 | 2021-01-26 11:01:43 -0800 | [diff] [blame] | 575 | |
| 576 | expected := "lib64/libjni.so" |
| 577 | if runtime.GOOS == "darwin" { |
| 578 | expected = "lib64/libjni.dylib" |
| 579 | } |
| 580 | |
| 581 | fooTestData := foo.data |
| 582 | if len(fooTestData) != 1 || fooTestData[0].Rel() != expected { |
| 583 | t.Errorf(`expected foo test data relative path [%q], got %q`, |
| 584 | expected, fooTestData.Strings()) |
| 585 | } |
| 586 | } |
| 587 | |
Colin Cross | b361442 | 2025-02-18 15:18:18 -0800 | [diff] [blame] | 588 | func TestHostCommonData(t *testing.T) { |
| 589 | t.Parallel() |
| 590 | ctx, _ := testJava(t, ` |
| 591 | java_library_host { |
| 592 | name: "host", |
| 593 | srcs: ["a.java"], |
| 594 | } |
| 595 | |
| 596 | java_test { |
| 597 | name: "foo", |
| 598 | srcs: ["a.java"], |
| 599 | host_common_data: [":host"], |
| 600 | } |
| 601 | `) |
| 602 | |
| 603 | foo := ctx.ModuleForTests(t, "foo", "android_common").Module().(*Test) |
| 604 | host := ctx.ModuleForTests(t, "host", ctx.Config().BuildOSCommonTarget.String()).Module().(*Library) |
| 605 | |
| 606 | if g, w := foo.data.RelativeToTop().Strings(), []string{host.outputFile.RelativeToTop().String()}; !slices.Equal(g, w) { |
| 607 | t.Errorf("expected test data %q, got %q\n", w, g) |
| 608 | } |
| 609 | } |
| 610 | |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 611 | func TestHostBinaryNoJavaDebugInfoOverride(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 612 | t.Parallel() |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 613 | bp := ` |
| 614 | java_library { |
| 615 | name: "target_library", |
| 616 | srcs: ["a.java"], |
| 617 | } |
| 618 | |
| 619 | java_binary_host { |
| 620 | name: "host_binary", |
| 621 | srcs: ["b.java"], |
| 622 | } |
| 623 | ` |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 624 | |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 625 | result := android.GroupFixturePreparers( |
| 626 | PrepareForTestWithJavaDefaultModules, |
| 627 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 628 | variables.MinimizeJavaDebugInfo = proptools.BoolPtr(true) |
| 629 | }), |
| 630 | ).RunTestWithBp(t, bp) |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 631 | |
Liz Kammer | 7941b30 | 2020-07-28 13:27:34 -0700 | [diff] [blame] | 632 | // first, check that the -g flag is added to target modules |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 633 | targetLibrary := result.ModuleForTests(t, "target_library", "android_common") |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 634 | targetJavaFlags := targetLibrary.Module().VariablesForTests()["javacFlags"] |
| 635 | if !strings.Contains(targetJavaFlags, "-g:source,lines") { |
| 636 | t.Errorf("target library javac flags %v should contain "+ |
| 637 | "-g:source,lines override with MinimizeJavaDebugInfo", targetJavaFlags) |
| 638 | } |
| 639 | |
| 640 | // check that -g is not overridden for host modules |
Colin Cross | 0c66bc6 | 2021-07-20 09:47:41 -0700 | [diff] [blame] | 641 | buildOS := result.Config.BuildOS.String() |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 642 | hostBinary := result.ModuleForTests(t, "host_binary", buildOS+"_common") |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 643 | hostJavaFlags := hostBinary.Module().VariablesForTests()["javacFlags"] |
| 644 | if strings.Contains(hostJavaFlags, "-g:source,lines") { |
| 645 | t.Errorf("java_binary_host javac flags %v should not have "+ |
| 646 | "-g:source,lines override with MinimizeJavaDebugInfo", hostJavaFlags) |
| 647 | } |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 648 | } |
| 649 | |
Spandan Das | 59a4a2b | 2024-01-09 21:35:56 +0000 | [diff] [blame] | 650 | // A minimal context object for use with DexJarBuildPath |
| 651 | type moduleErrorfTestCtx struct { |
| 652 | } |
| 653 | |
| 654 | func (ctx moduleErrorfTestCtx) ModuleErrorf(format string, args ...interface{}) { |
| 655 | } |
| 656 | |
| 657 | var _ android.ModuleErrorfContext = (*moduleErrorfTestCtx)(nil) |
| 658 | |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 659 | func TestPrebuilts(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 660 | t.Parallel() |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 661 | ctx, _ := testJava(t, ` |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 662 | java_library { |
| 663 | name: "foo", |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 664 | srcs: ["a.java", ":stubs-source"], |
Jihoon Kang | 28c9657 | 2024-09-11 23:44:44 +0000 | [diff] [blame] | 665 | libs: ["bar", "sdklib.stubs"], |
Colin Cross | e8dc34a | 2017-07-19 11:22:16 -0700 | [diff] [blame] | 666 | static_libs: ["baz"], |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 667 | } |
| 668 | |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 669 | java_import { |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 670 | name: "bar", |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 671 | jars: ["a.jar"], |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 672 | } |
| 673 | |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 674 | java_import { |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 675 | name: "baz", |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 676 | jars: ["b.jar"], |
Liz Kammer | d6c31d2 | 2020-08-05 15:40:41 -0700 | [diff] [blame] | 677 | sdk_version: "current", |
| 678 | compile_dex: true, |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 679 | } |
Colin Cross | 42be761 | 2019-02-21 18:12:14 -0800 | [diff] [blame] | 680 | |
| 681 | dex_import { |
| 682 | name: "qux", |
| 683 | jars: ["b.jar"], |
| 684 | } |
Colin Cross | 79c7c26 | 2019-04-17 11:11:46 -0700 | [diff] [blame] | 685 | |
| 686 | java_sdk_library_import { |
Paul Duffin | 56d4490 | 2020-01-31 13:36:25 +0000 | [diff] [blame] | 687 | name: "sdklib", |
| 688 | public: { |
| 689 | jars: ["c.jar"], |
| 690 | }, |
| 691 | } |
| 692 | |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 693 | prebuilt_stubs_sources { |
| 694 | name: "stubs-source", |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 695 | srcs: ["stubs/sources"], |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 696 | } |
Paul Duffin | 1b82e6a | 2019-12-03 18:06:47 +0000 | [diff] [blame] | 697 | |
| 698 | java_test_import { |
| 699 | name: "test", |
| 700 | jars: ["a.jar"], |
| 701 | test_suites: ["cts"], |
| 702 | test_config: "AndroidTest.xml", |
| 703 | } |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 704 | `) |
| 705 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 706 | fooModule := ctx.ModuleForTests(t, "foo", "android_common") |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 707 | javac := fooModule.Rule("javac") |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 708 | combineJar := ctx.ModuleForTests(t, "foo", "android_common").Description("for javac") |
| 709 | barModule := ctx.ModuleForTests(t, "bar", "android_common") |
Colin Cross | 8ff4af3 | 2025-02-19 15:17:02 -0800 | [diff] [blame] | 710 | barJar := barModule.Output("local-combined/bar.jar").Output |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 711 | bazModule := ctx.ModuleForTests(t, "baz", "android_common") |
Colin Cross | 8ff4af3 | 2025-02-19 15:17:02 -0800 | [diff] [blame] | 712 | bazJar := bazModule.Output("local-combined/baz.jar").Output |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 713 | sdklibStubsJar := ctx.ModuleForTests(t, "sdklib.stubs", "android_common"). |
Colin Cross | 8ff4af3 | 2025-02-19 15:17:02 -0800 | [diff] [blame] | 714 | Output("local-combined/sdklib.stubs.jar").Output |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 715 | |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 716 | fooLibrary := fooModule.Module().(*Library) |
Chaohui Wang | dcbe33c | 2022-10-11 11:13:30 +0800 | [diff] [blame] | 717 | assertDeepEquals(t, "foo unique sources incorrect", |
| 718 | []string{"a.java"}, fooLibrary.uniqueSrcFiles.Strings()) |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 719 | |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 720 | assertDeepEquals(t, "foo java source jars incorrect", |
| 721 | []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"}, |
| 722 | android.NormalizePathsForTesting(fooLibrary.compiledSrcJars)) |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 723 | |
Colin Cross | 37f6d79 | 2018-07-12 12:28:41 -0700 | [diff] [blame] | 724 | if !strings.Contains(javac.Args["classpath"], barJar.String()) { |
| 725 | t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String()) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 726 | } |
| 727 | |
Spandan Das | 59a4a2b | 2024-01-09 21:35:56 +0000 | [diff] [blame] | 728 | errCtx := moduleErrorfTestCtx{} |
| 729 | barDexJar := barModule.Module().(*Import).DexJarBuildPath(errCtx) |
Martin Stjernholm | 8be1e6d | 2021-09-15 03:34:04 +0100 | [diff] [blame] | 730 | if barDexJar.IsSet() { |
| 731 | t.Errorf("bar dex jar build path expected to be set, got %s", barDexJar) |
Liz Kammer | d6c31d2 | 2020-08-05 15:40:41 -0700 | [diff] [blame] | 732 | } |
| 733 | |
Colin Cross | 79c7c26 | 2019-04-17 11:11:46 -0700 | [diff] [blame] | 734 | if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) { |
| 735 | t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String()) |
| 736 | } |
| 737 | |
Colin Cross | 37f6d79 | 2018-07-12 12:28:41 -0700 | [diff] [blame] | 738 | if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() { |
| 739 | t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String()) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 740 | } |
Colin Cross | 42be761 | 2019-02-21 18:12:14 -0800 | [diff] [blame] | 741 | |
Spandan Das | 59a4a2b | 2024-01-09 21:35:56 +0000 | [diff] [blame] | 742 | bazDexJar := bazModule.Module().(*Import).DexJarBuildPath(errCtx).Path() |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 743 | expectedDexJar := "out/soong/.intermediates/baz/android_common/dex/baz.jar" |
| 744 | android.AssertPathRelativeToTopEquals(t, "baz dex jar build path", expectedDexJar, bazDexJar) |
Liz Kammer | d6c31d2 | 2020-08-05 15:40:41 -0700 | [diff] [blame] | 745 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 746 | ctx.ModuleForTests(t, "qux", "android_common").Rule("Cp") |
Wei Li | 598f92d | 2023-01-04 17:12:24 -0800 | [diff] [blame] | 747 | |
| 748 | entries := android.AndroidMkEntriesForTest(t, ctx, fooModule.Module())[0] |
| 749 | android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "java_library", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0]) |
| 750 | entries = android.AndroidMkEntriesForTest(t, ctx, barModule.Module())[0] |
| 751 | android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "java_import", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0]) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 752 | } |
| 753 | |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 754 | func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) { |
| 755 | if !reflect.DeepEqual(expected, actual) { |
| 756 | t.Errorf("%s: expected %q, found %q", message, expected, actual) |
| 757 | } |
| 758 | } |
| 759 | |
Paul Duffin | 1a39332 | 2020-11-18 16:36:47 +0000 | [diff] [blame] | 760 | func TestPrebuiltStubsSources(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 761 | t.Parallel() |
Paul Duffin | 1a39332 | 2020-11-18 16:36:47 +0000 | [diff] [blame] | 762 | test := func(t *testing.T, sourcesPath string, expectedInputs []string) { |
| 763 | ctx, _ := testJavaWithFS(t, fmt.Sprintf(` |
| 764 | prebuilt_stubs_sources { |
| 765 | name: "stubs-source", |
| 766 | srcs: ["%s"], |
| 767 | }`, sourcesPath), map[string][]byte{ |
| 768 | "stubs/sources/pkg/A.java": nil, |
| 769 | "stubs/sources/pkg/B.java": nil, |
| 770 | }) |
| 771 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 772 | zipSrc := ctx.ModuleForTests(t, "stubs-source", "android_common").Rule("zip_src") |
Paul Duffin | 1a39332 | 2020-11-18 16:36:47 +0000 | [diff] [blame] | 773 | if expected, actual := expectedInputs, zipSrc.Inputs.Strings(); !reflect.DeepEqual(expected, actual) { |
| 774 | t.Errorf("mismatch of inputs to soong_zip: expected %q, actual %q", expected, actual) |
| 775 | } |
| 776 | } |
| 777 | |
| 778 | t.Run("empty/missing directory", func(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 779 | t.Parallel() |
Colin Cross | ce3a51d | 2021-03-19 16:22:12 -0700 | [diff] [blame] | 780 | test(t, "empty-directory", nil) |
Paul Duffin | 1a39332 | 2020-11-18 16:36:47 +0000 | [diff] [blame] | 781 | }) |
| 782 | |
| 783 | t.Run("non-empty set of sources", func(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 784 | t.Parallel() |
Paul Duffin | 1a39332 | 2020-11-18 16:36:47 +0000 | [diff] [blame] | 785 | test(t, "stubs/sources", []string{ |
| 786 | "stubs/sources/pkg/A.java", |
| 787 | "stubs/sources/pkg/B.java", |
| 788 | }) |
| 789 | }) |
| 790 | } |
| 791 | |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 792 | func TestDefaults(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 793 | t.Parallel() |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 794 | ctx, _ := testJava(t, ` |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 795 | java_defaults { |
| 796 | name: "defaults", |
| 797 | srcs: ["a.java"], |
| 798 | libs: ["bar"], |
| 799 | static_libs: ["baz"], |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 800 | optimize: {enabled: false}, |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 801 | } |
| 802 | |
| 803 | java_library { |
| 804 | name: "foo", |
| 805 | defaults: ["defaults"], |
| 806 | } |
| 807 | |
| 808 | java_library { |
| 809 | name: "bar", |
| 810 | srcs: ["b.java"], |
| 811 | } |
| 812 | |
| 813 | java_library { |
| 814 | name: "baz", |
| 815 | srcs: ["c.java"], |
| 816 | } |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 817 | |
| 818 | android_test { |
| 819 | name: "atestOptimize", |
| 820 | defaults: ["defaults"], |
| 821 | optimize: {enabled: true}, |
| 822 | } |
| 823 | |
| 824 | android_test { |
| 825 | name: "atestNoOptimize", |
| 826 | defaults: ["defaults"], |
| 827 | } |
| 828 | |
| 829 | android_test { |
| 830 | name: "atestDefault", |
| 831 | srcs: ["a.java"], |
| 832 | } |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 833 | `) |
| 834 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 835 | javac := ctx.ModuleForTests(t, "foo", "android_common").Rule("javac") |
| 836 | combineJar := ctx.ModuleForTests(t, "foo", "android_common").Description("for javac") |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 837 | |
| 838 | if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" { |
| 839 | t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs) |
| 840 | } |
| 841 | |
Colin Cross | 8ff4af3 | 2025-02-19 15:17:02 -0800 | [diff] [blame] | 842 | barTurbine := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine", "bar.jar") |
Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 843 | if !strings.Contains(javac.Args["classpath"], barTurbine) { |
| 844 | t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine) |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 845 | } |
| 846 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 847 | baz := ctx.ModuleForTests(t, "baz", "android_common").Rule("javac").Output.String() |
Colin Cross | 0a6e007 | 2017-08-30 14:24:55 -0700 | [diff] [blame] | 848 | if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz { |
| 849 | t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz) |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 850 | } |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 851 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 852 | atestOptimize := ctx.ModuleForTests(t, "atestOptimize", "android_common").MaybeRule("r8") |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 853 | if atestOptimize.Output == nil { |
| 854 | t.Errorf("atestOptimize should optimize APK") |
| 855 | } |
| 856 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 857 | atestNoOptimize := ctx.ModuleForTests(t, "atestNoOptimize", "android_common").MaybeRule("d8") |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 858 | if atestNoOptimize.Output == nil { |
| 859 | t.Errorf("atestNoOptimize should not optimize APK") |
| 860 | } |
| 861 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 862 | atestDefault := ctx.ModuleForTests(t, "atestDefault", "android_common").MaybeRule("d8") |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 863 | if atestDefault.Output == nil { |
Jared Duke | 63a3da9 | 2022-06-02 19:11:14 +0000 | [diff] [blame] | 864 | t.Errorf("atestDefault should not optimize APK") |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 865 | } |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 866 | } |
| 867 | |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 868 | func TestResources(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 869 | t.Parallel() |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 870 | var table = []struct { |
| 871 | name string |
| 872 | prop string |
| 873 | extra string |
| 874 | args string |
| 875 | }{ |
| 876 | { |
Colin Cross | af9c55b | 2017-10-03 14:50:08 -0700 | [diff] [blame] | 877 | // Test that a module with java_resource_dirs includes the files |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 878 | name: "resource dirs", |
Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 879 | prop: `java_resource_dirs: ["java-res"]`, |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 880 | args: "-C java-res -f java-res/a/a -f java-res/b/b", |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 881 | }, |
| 882 | { |
| 883 | // Test that a module with java_resources includes the files |
| 884 | name: "resource files", |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 885 | prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`, |
| 886 | args: "-C . -f java-res/a/a -f java-res/b/b", |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 887 | }, |
| 888 | { |
| 889 | // Test that a module with a filegroup in java_resources includes the files with the |
| 890 | // path prefix |
| 891 | name: "resource filegroup", |
| 892 | prop: `java_resources: [":foo-res"]`, |
| 893 | extra: ` |
| 894 | filegroup { |
| 895 | name: "foo-res", |
Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 896 | path: "java-res", |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 897 | srcs: ["java-res/a/a", "java-res/b/b"], |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 898 | }`, |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 899 | args: "-C java-res -f java-res/a/a -f java-res/b/b", |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 900 | }, |
| 901 | { |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 902 | // Test that a module with wildcards in java_resource_dirs has the correct path prefixes |
| 903 | name: "wildcard dirs", |
| 904 | prop: `java_resource_dirs: ["java-res/*"]`, |
| 905 | args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b", |
| 906 | }, |
| 907 | { |
| 908 | // Test that a module exclude_java_resource_dirs excludes the files |
| 909 | name: "wildcard dirs", |
| 910 | prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`, |
| 911 | args: "-C java-res/a -f java-res/a/a", |
| 912 | }, |
Colin Cross | cedd476 | 2018-09-13 11:26:19 -0700 | [diff] [blame] | 913 | { |
| 914 | // Test wildcards in java_resources |
| 915 | name: "wildcard files", |
| 916 | prop: `java_resources: ["java-res/**/*"]`, |
| 917 | args: "-C . -f java-res/a/a -f java-res/b/b", |
| 918 | }, |
| 919 | { |
| 920 | // Test exclude_java_resources with java_resources |
| 921 | name: "wildcard files with exclude", |
| 922 | prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`, |
| 923 | args: "-C . -f java-res/a/a", |
| 924 | }, |
| 925 | { |
| 926 | // Test exclude_java_resources with java_resource_dirs |
| 927 | name: "resource dirs with exclude files", |
| 928 | prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`, |
| 929 | args: "-C java-res -f java-res/a/a", |
| 930 | }, |
| 931 | { |
| 932 | // Test exclude_java_resource_dirs with java_resource_dirs |
| 933 | name: "resource dirs with exclude files", |
| 934 | prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`, |
| 935 | args: "-C java-res -f java-res/a/a -f java-res/b/b", |
| 936 | }, |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 937 | } |
| 938 | |
| 939 | for _, test := range table { |
| 940 | t.Run(test.name, func(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 941 | t.Parallel() |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 942 | ctx, _ := testJavaWithFS(t, ` |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 943 | java_library { |
| 944 | name: "foo", |
| 945 | srcs: [ |
| 946 | "a.java", |
| 947 | "b.java", |
| 948 | "c.java", |
| 949 | ], |
| 950 | `+test.prop+`, |
| 951 | } |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 952 | `+test.extra, |
| 953 | map[string][]byte{ |
| 954 | "java-res/a/a": nil, |
| 955 | "java-res/b/b": nil, |
| 956 | "java-res2/a": nil, |
| 957 | }, |
| 958 | ) |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 959 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 960 | foo := ctx.ModuleForTests(t, "foo", "android_common").Output("withres/foo.jar") |
| 961 | fooRes := ctx.ModuleForTests(t, "foo", "android_common").Output("res/foo.jar") |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 962 | |
| 963 | if !inList(fooRes.Output.String(), foo.Inputs.Strings()) { |
| 964 | t.Errorf("foo combined jars %v does not contain %q", |
| 965 | foo.Inputs.Strings(), fooRes.Output.String()) |
| 966 | } |
| 967 | |
Colin Cross | af9c55b | 2017-10-03 14:50:08 -0700 | [diff] [blame] | 968 | if fooRes.Args["jarArgs"] != test.args { |
| 969 | t.Errorf("foo resource jar args %q is not %q", |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 970 | fooRes.Args["jarArgs"], test.args) |
| 971 | } |
| 972 | }) |
| 973 | } |
| 974 | } |
| 975 | |
Colin Cross | 0c4ce21 | 2019-05-03 15:28:19 -0700 | [diff] [blame] | 976 | func TestIncludeSrcs(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 977 | t.Parallel() |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 978 | ctx, _ := testJavaWithFS(t, ` |
Colin Cross | 0c4ce21 | 2019-05-03 15:28:19 -0700 | [diff] [blame] | 979 | java_library { |
| 980 | name: "foo", |
| 981 | srcs: [ |
| 982 | "a.java", |
| 983 | "b.java", |
| 984 | "c.java", |
| 985 | ], |
| 986 | include_srcs: true, |
| 987 | } |
| 988 | |
| 989 | java_library { |
| 990 | name: "bar", |
| 991 | srcs: [ |
| 992 | "a.java", |
| 993 | "b.java", |
| 994 | "c.java", |
| 995 | ], |
| 996 | java_resource_dirs: ["java-res"], |
| 997 | include_srcs: true, |
| 998 | } |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 999 | `, map[string][]byte{ |
| 1000 | "java-res/a/a": nil, |
| 1001 | "java-res/b/b": nil, |
| 1002 | "java-res2/a": nil, |
| 1003 | }) |
Colin Cross | 0c4ce21 | 2019-05-03 15:28:19 -0700 | [diff] [blame] | 1004 | |
| 1005 | // Test a library with include_srcs: true |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1006 | foo := ctx.ModuleForTests(t, "foo", "android_common").Output("withres/foo.jar") |
| 1007 | fooSrcJar := ctx.ModuleForTests(t, "foo", "android_common").Output("foo.srcjar") |
Colin Cross | 0c4ce21 | 2019-05-03 15:28:19 -0700 | [diff] [blame] | 1008 | |
| 1009 | if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) { |
| 1010 | t.Errorf("foo combined jars %v does not contain %q", w, g) |
| 1011 | } |
| 1012 | |
| 1013 | if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w { |
| 1014 | t.Errorf("foo source jar args %q is not %q", w, g) |
| 1015 | } |
| 1016 | |
| 1017 | // Test a library with include_srcs: true and resources |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1018 | bar := ctx.ModuleForTests(t, "bar", "android_common").Output("withres/bar.jar") |
| 1019 | barResCombined := ctx.ModuleForTests(t, "bar", "android_common").Output("res-combined/bar.jar") |
| 1020 | barRes := ctx.ModuleForTests(t, "bar", "android_common").Output("res/bar.jar") |
| 1021 | barSrcJar := ctx.ModuleForTests(t, "bar", "android_common").Output("bar.srcjar") |
Colin Cross | 0c4ce21 | 2019-05-03 15:28:19 -0700 | [diff] [blame] | 1022 | |
| 1023 | if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) { |
| 1024 | t.Errorf("bar combined resource jars %v does not contain %q", w, g) |
| 1025 | } |
| 1026 | |
| 1027 | if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) { |
| 1028 | t.Errorf("bar combined resource jars %v does not contain %q", w, g) |
| 1029 | } |
| 1030 | |
Colin Cross | 8ff4af3 | 2025-02-19 15:17:02 -0800 | [diff] [blame] | 1031 | if g, w := barRes.Output.String(), bar.Inputs.Strings(); !inList(g, w) { |
Colin Cross | 0c4ce21 | 2019-05-03 15:28:19 -0700 | [diff] [blame] | 1032 | t.Errorf("bar combined jars %v does not contain %q", w, g) |
| 1033 | } |
| 1034 | |
| 1035 | if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w { |
| 1036 | t.Errorf("bar source jar args %q is not %q", w, g) |
| 1037 | } |
| 1038 | |
| 1039 | if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w { |
| 1040 | t.Errorf("bar resource jar args %q is not %q", w, g) |
| 1041 | } |
| 1042 | } |
| 1043 | |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 1044 | func TestGeneratedSources(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1045 | t.Parallel() |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 1046 | ctx, _ := testJavaWithFS(t, ` |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 1047 | java_library { |
| 1048 | name: "foo", |
| 1049 | srcs: [ |
| 1050 | "a*.java", |
| 1051 | ":gen", |
| 1052 | "b*.java", |
| 1053 | ], |
| 1054 | } |
| 1055 | |
| 1056 | genrule { |
| 1057 | name: "gen", |
Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 1058 | tool_files: ["java-res/a"], |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 1059 | out: ["gen.java"], |
| 1060 | } |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 1061 | `, map[string][]byte{ |
| 1062 | "a.java": nil, |
| 1063 | "b.java": nil, |
| 1064 | }) |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 1065 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1066 | javac := ctx.ModuleForTests(t, "foo", "android_common").Rule("javac") |
| 1067 | genrule := ctx.ModuleForTests(t, "gen", "").Rule("generator") |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 1068 | |
Colin Cross | 15e86d9 | 2017-10-20 15:07:08 -0700 | [diff] [blame] | 1069 | if filepath.Base(genrule.Output.String()) != "gen.java" { |
| 1070 | t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String()) |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 1071 | } |
| 1072 | |
| 1073 | if len(javac.Inputs) != 3 || |
| 1074 | javac.Inputs[0].String() != "a.java" || |
Colin Cross | 15e86d9 | 2017-10-20 15:07:08 -0700 | [diff] [blame] | 1075 | javac.Inputs[1].String() != genrule.Output.String() || |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 1076 | javac.Inputs[2].String() != "b.java" { |
| 1077 | t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs) |
| 1078 | } |
| 1079 | } |
| 1080 | |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1081 | func TestTurbine(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1082 | t.Parallel() |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 1083 | result := android.GroupFixturePreparers( |
| 1084 | prepareForJavaTest, FixtureWithPrebuiltApis(map[string][]string{"14": {"foo"}})). |
Paul Duffin | 3d9f268 | 2021-03-13 09:47:16 +0000 | [diff] [blame] | 1085 | RunTestWithBp(t, ` |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1086 | java_library { |
| 1087 | name: "foo", |
| 1088 | srcs: ["a.java"], |
Jiyong Park | 2d49294 | 2018-03-05 17:44:10 +0900 | [diff] [blame] | 1089 | sdk_version: "14", |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1090 | } |
| 1091 | |
| 1092 | java_library { |
| 1093 | name: "bar", |
Colin Cross | 9bc4343 | 2017-12-15 20:20:39 -0800 | [diff] [blame] | 1094 | srcs: ["b.java"], |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1095 | static_libs: ["foo"], |
Jiyong Park | 2d49294 | 2018-03-05 17:44:10 +0900 | [diff] [blame] | 1096 | sdk_version: "14", |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1097 | } |
| 1098 | |
| 1099 | java_library { |
| 1100 | name: "baz", |
| 1101 | srcs: ["c.java"], |
| 1102 | libs: ["bar"], |
| 1103 | sdk_version: "14", |
| 1104 | } |
| 1105 | `) |
| 1106 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1107 | fooTurbine := result.ModuleForTests(t, "foo", "android_common").Rule("turbine") |
| 1108 | barTurbine := result.ModuleForTests(t, "bar", "android_common").Rule("turbine") |
| 1109 | barJavac := result.ModuleForTests(t, "bar", "android_common").Rule("javac") |
| 1110 | barTurbineCombined := result.ModuleForTests(t, "bar", "android_common").Description("for turbine") |
| 1111 | bazJavac := result.ModuleForTests(t, "baz", "android_common").Rule("javac") |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1112 | |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1113 | android.AssertPathsRelativeToTopEquals(t, "foo inputs", []string{"a.java"}, fooTurbine.Inputs) |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1114 | |
Colin Cross | 8ff4af3 | 2025-02-19 15:17:02 -0800 | [diff] [blame] | 1115 | fooHeaderJar := filepath.Join("out", "soong", ".intermediates", "foo", "android_common", "turbine", "foo.jar") |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1116 | barTurbineJar := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine", "bar.jar") |
Colin Cross | f61766e | 2022-03-16 18:06:48 -0700 | [diff] [blame] | 1117 | android.AssertStringDoesContain(t, "bar turbine classpath", barTurbine.Args["turbineFlags"], fooHeaderJar) |
Paul Duffin | 3d9f268 | 2021-03-13 09:47:16 +0000 | [diff] [blame] | 1118 | android.AssertStringDoesContain(t, "bar javac classpath", barJavac.Args["classpath"], fooHeaderJar) |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1119 | android.AssertPathsRelativeToTopEquals(t, "bar turbine combineJar", []string{barTurbineJar, fooHeaderJar}, barTurbineCombined.Inputs) |
Paul Duffin | 3d9f268 | 2021-03-13 09:47:16 +0000 | [diff] [blame] | 1120 | android.AssertStringDoesContain(t, "baz javac classpath", bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1121 | } |
| 1122 | |
| 1123 | func TestSharding(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1124 | t.Parallel() |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 1125 | ctx, _ := testJava(t, ` |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1126 | java_library { |
| 1127 | name: "bar", |
| 1128 | srcs: ["a.java","b.java","c.java"], |
| 1129 | javac_shard_size: 1 |
| 1130 | } |
| 1131 | `) |
| 1132 | |
Colin Cross | 3d56ed5 | 2021-11-18 22:23:12 -0800 | [diff] [blame] | 1133 | barHeaderJar := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine", "bar.jar") |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1134 | for i := 0; i < 3; i++ { |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1135 | barJavac := ctx.ModuleForTests(t, "bar", "android_common").Description("javac" + strconv.Itoa(i)) |
Colin Cross | 3d56ed5 | 2021-11-18 22:23:12 -0800 | [diff] [blame] | 1136 | if !strings.HasPrefix(barJavac.Args["classpath"], "-classpath "+barHeaderJar+":") { |
| 1137 | t.Errorf("bar javac classpath %v does start with %q", barJavac.Args["classpath"], barHeaderJar) |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1138 | } |
| 1139 | } |
| 1140 | } |
| 1141 | |
Nan Zhang | 27e284d | 2018-02-09 21:03:53 +0000 | [diff] [blame] | 1142 | func TestExcludeFileGroupInSrcs(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1143 | t.Parallel() |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 1144 | ctx, _ := testJava(t, ` |
Nan Zhang | 27e284d | 2018-02-09 21:03:53 +0000 | [diff] [blame] | 1145 | java_library { |
| 1146 | name: "foo", |
| 1147 | srcs: ["a.java", ":foo-srcs"], |
| 1148 | exclude_srcs: ["a.java", ":foo-excludes"], |
| 1149 | } |
| 1150 | |
| 1151 | filegroup { |
| 1152 | name: "foo-srcs", |
| 1153 | srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"], |
| 1154 | } |
| 1155 | |
| 1156 | filegroup { |
| 1157 | name: "foo-excludes", |
| 1158 | srcs: ["java-fg/a.java", "java-fg/b.java"], |
| 1159 | } |
| 1160 | `) |
| 1161 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1162 | javac := ctx.ModuleForTests(t, "foo", "android_common").Rule("javac") |
Nan Zhang | 27e284d | 2018-02-09 21:03:53 +0000 | [diff] [blame] | 1163 | |
| 1164 | if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" { |
| 1165 | t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs) |
| 1166 | } |
| 1167 | } |
Jiyong Park | c678ad3 | 2018-04-10 13:07:10 +0900 | [diff] [blame] | 1168 | |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1169 | func TestJavaLibraryOutputFiles(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1170 | t.Parallel() |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1171 | testJavaWithFS(t, "", map[string][]byte{ |
Paul Duffin | 52d398a | 2019-06-11 12:31:14 +0100 | [diff] [blame] | 1172 | "libcore/Android.bp": []byte(` |
| 1173 | java_library { |
| 1174 | name: "core", |
| 1175 | sdk_version: "none", |
| 1176 | system_modules: "none", |
Paul Duffin | aa55f74 | 2020-10-06 17:20:13 +0100 | [diff] [blame] | 1177 | } |
| 1178 | |
| 1179 | filegroup { |
| 1180 | name: "core-jar", |
Cole Faust | 65cb40a | 2024-10-21 15:41:42 -0700 | [diff] [blame] | 1181 | device_common_srcs: [":core{.jar}"], |
Paul Duffin | aa55f74 | 2020-10-06 17:20:13 +0100 | [diff] [blame] | 1182 | } |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1183 | `), |
Paul Duffin | aa55f74 | 2020-10-06 17:20:13 +0100 | [diff] [blame] | 1184 | }) |
Paul Duffin | aa55f74 | 2020-10-06 17:20:13 +0100 | [diff] [blame] | 1185 | } |
| 1186 | |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1187 | func TestJavaImportOutputFiles(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1188 | t.Parallel() |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1189 | testJavaWithFS(t, "", map[string][]byte{ |
Paul Duffin | aa55f74 | 2020-10-06 17:20:13 +0100 | [diff] [blame] | 1190 | "libcore/Android.bp": []byte(` |
| 1191 | java_import { |
| 1192 | name: "core", |
| 1193 | sdk_version: "none", |
| 1194 | } |
| 1195 | |
| 1196 | filegroup { |
| 1197 | name: "core-jar", |
Cole Faust | 65cb40a | 2024-10-21 15:41:42 -0700 | [diff] [blame] | 1198 | device_common_srcs: [":core{.jar}"], |
Paul Duffin | aa55f74 | 2020-10-06 17:20:13 +0100 | [diff] [blame] | 1199 | } |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1200 | `), |
Paul Duffin | 52d398a | 2019-06-11 12:31:14 +0100 | [diff] [blame] | 1201 | }) |
Paul Duffin | 52d398a | 2019-06-11 12:31:14 +0100 | [diff] [blame] | 1202 | } |
| 1203 | |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1204 | func TestJavaImport(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1205 | t.Parallel() |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1206 | bp := ` |
| 1207 | java_library { |
| 1208 | name: "source_library", |
| 1209 | srcs: ["source.java"], |
| 1210 | } |
| 1211 | |
| 1212 | java_import { |
| 1213 | name: "import_with_no_deps", |
| 1214 | jars: ["no_deps.jar"], |
| 1215 | } |
| 1216 | |
| 1217 | java_import { |
| 1218 | name: "import_with_source_deps", |
| 1219 | jars: ["source_deps.jar"], |
| 1220 | static_libs: ["source_library"], |
| 1221 | } |
| 1222 | |
| 1223 | java_import { |
| 1224 | name: "import_with_import_deps", |
| 1225 | jars: ["import_deps.jar"], |
| 1226 | static_libs: ["import_with_no_deps"], |
| 1227 | } |
| 1228 | ` |
| 1229 | ctx := android.GroupFixturePreparers( |
| 1230 | PrepareForTestWithJavaDefaultModules, |
| 1231 | ).RunTestWithBp(t, bp) |
| 1232 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1233 | source := ctx.ModuleForTests(t, "source_library", "android_common") |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1234 | sourceJar := source.Output("javac/source_library.jar") |
Colin Cross | 8ff4af3 | 2025-02-19 15:17:02 -0800 | [diff] [blame] | 1235 | sourceHeaderJar := source.Output("turbine/source_library.jar") |
| 1236 | sourceCombinedHeaderJar := source.Output("turbine-combined/source_library.jar") |
Yu Liu | 663e450 | 2024-08-12 18:23:59 +0000 | [diff] [blame] | 1237 | sourceJavaInfo, _ := android.OtherModuleProvider(ctx, source.Module(), JavaInfoProvider) |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1238 | |
| 1239 | // The source library produces separate implementation and header jars |
| 1240 | android.AssertPathsRelativeToTopEquals(t, "source library implementation jar", |
| 1241 | []string{sourceJar.Output.String()}, sourceJavaInfo.ImplementationAndResourcesJars) |
| 1242 | android.AssertPathsRelativeToTopEquals(t, "source library header jar", |
Colin Cross | 8ff4af3 | 2025-02-19 15:17:02 -0800 | [diff] [blame] | 1243 | []string{sourceCombinedHeaderJar.Output.String()}, sourceJavaInfo.HeaderJars) |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1244 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1245 | importWithNoDeps := ctx.ModuleForTests(t, "import_with_no_deps", "android_common") |
Colin Cross | 8ff4af3 | 2025-02-19 15:17:02 -0800 | [diff] [blame] | 1246 | importWithNoDepsLocalJar := importWithNoDeps.Output("local-combined/import_with_no_deps.jar") |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1247 | importWithNoDepsJar := importWithNoDeps.Output("combined/import_with_no_deps.jar") |
Yu Liu | 663e450 | 2024-08-12 18:23:59 +0000 | [diff] [blame] | 1248 | importWithNoDepsJavaInfo, _ := android.OtherModuleProvider(ctx, importWithNoDeps.Module(), JavaInfoProvider) |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1249 | |
| 1250 | // An import with no deps produces a single jar used as both the header and implementation jar. |
| 1251 | android.AssertPathsRelativeToTopEquals(t, "import with no deps implementation jar", |
| 1252 | []string{importWithNoDepsJar.Output.String()}, importWithNoDepsJavaInfo.ImplementationAndResourcesJars) |
| 1253 | android.AssertPathsRelativeToTopEquals(t, "import with no deps header jar", |
| 1254 | []string{importWithNoDepsJar.Output.String()}, importWithNoDepsJavaInfo.HeaderJars) |
| 1255 | android.AssertPathsRelativeToTopEquals(t, "import with no deps combined inputs", |
Colin Cross | 8ff4af3 | 2025-02-19 15:17:02 -0800 | [diff] [blame] | 1256 | []string{importWithNoDepsLocalJar.Output.String()}, importWithNoDepsJar.Inputs) |
| 1257 | android.AssertPathsRelativeToTopEquals(t, "import with no deps local combined inputs", |
| 1258 | []string{"no_deps.jar"}, importWithNoDepsLocalJar.Inputs) |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1259 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1260 | importWithSourceDeps := ctx.ModuleForTests(t, "import_with_source_deps", "android_common") |
Colin Cross | 8ff4af3 | 2025-02-19 15:17:02 -0800 | [diff] [blame] | 1261 | importWithSourceDepsLocalJar := importWithSourceDeps.Output("local-combined/import_with_source_deps.jar") |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1262 | importWithSourceDepsJar := importWithSourceDeps.Output("combined/import_with_source_deps.jar") |
Colin Cross | 8ff4af3 | 2025-02-19 15:17:02 -0800 | [diff] [blame] | 1263 | importWithSourceDepsLocalHeaderJar := importWithSourceDeps.Output("local-combined/import_with_source_deps.jar") |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1264 | importWithSourceDepsHeaderJar := importWithSourceDeps.Output("turbine-combined/import_with_source_deps.jar") |
Yu Liu | 663e450 | 2024-08-12 18:23:59 +0000 | [diff] [blame] | 1265 | importWithSourceDepsJavaInfo, _ := android.OtherModuleProvider(ctx, importWithSourceDeps.Module(), JavaInfoProvider) |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1266 | |
| 1267 | // An import with source deps produces separate header and implementation jars. |
| 1268 | android.AssertPathsRelativeToTopEquals(t, "import with source deps implementation jar", |
| 1269 | []string{importWithSourceDepsJar.Output.String()}, importWithSourceDepsJavaInfo.ImplementationAndResourcesJars) |
| 1270 | android.AssertPathsRelativeToTopEquals(t, "import with source deps header jar", |
| 1271 | []string{importWithSourceDepsHeaderJar.Output.String()}, importWithSourceDepsJavaInfo.HeaderJars) |
| 1272 | android.AssertPathsRelativeToTopEquals(t, "import with source deps combined implementation jar inputs", |
Colin Cross | 8ff4af3 | 2025-02-19 15:17:02 -0800 | [diff] [blame] | 1273 | []string{importWithSourceDepsLocalJar.Output.String(), sourceJar.Output.String()}, importWithSourceDepsJar.Inputs) |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1274 | android.AssertPathsRelativeToTopEquals(t, "import with source deps combined header jar inputs", |
Colin Cross | 8ff4af3 | 2025-02-19 15:17:02 -0800 | [diff] [blame] | 1275 | []string{importWithSourceDepsLocalHeaderJar.Output.String(), sourceHeaderJar.Output.String()}, importWithSourceDepsHeaderJar.Inputs) |
| 1276 | android.AssertPathsRelativeToTopEquals(t, "import with source deps local combined implementation jar inputs", |
| 1277 | []string{"source_deps.jar"}, importWithSourceDepsLocalJar.Inputs) |
| 1278 | android.AssertPathsRelativeToTopEquals(t, "import with source deps local combined header jar inputs", |
| 1279 | []string{"source_deps.jar"}, importWithSourceDepsLocalHeaderJar.Inputs) |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1280 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1281 | importWithImportDeps := ctx.ModuleForTests(t, "import_with_import_deps", "android_common") |
Colin Cross | 8ff4af3 | 2025-02-19 15:17:02 -0800 | [diff] [blame] | 1282 | importWithImportDepsLocalJar := importWithImportDeps.Output("local-combined/import_with_import_deps.jar") |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1283 | importWithImportDepsJar := importWithImportDeps.Output("combined/import_with_import_deps.jar") |
Yu Liu | 663e450 | 2024-08-12 18:23:59 +0000 | [diff] [blame] | 1284 | importWithImportDepsJavaInfo, _ := android.OtherModuleProvider(ctx, importWithImportDeps.Module(), JavaInfoProvider) |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1285 | |
| 1286 | // An import with only import deps produces a single jar used as both the header and implementation jar. |
| 1287 | android.AssertPathsRelativeToTopEquals(t, "import with import deps implementation jar", |
| 1288 | []string{importWithImportDepsJar.Output.String()}, importWithImportDepsJavaInfo.ImplementationAndResourcesJars) |
| 1289 | android.AssertPathsRelativeToTopEquals(t, "import with import deps header jar", |
| 1290 | []string{importWithImportDepsJar.Output.String()}, importWithImportDepsJavaInfo.HeaderJars) |
| 1291 | android.AssertPathsRelativeToTopEquals(t, "import with import deps combined implementation jar inputs", |
Colin Cross | 8ff4af3 | 2025-02-19 15:17:02 -0800 | [diff] [blame] | 1292 | []string{importWithImportDepsLocalJar.Output.String(), importWithNoDepsLocalJar.Output.String()}, importWithImportDepsJar.Inputs) |
| 1293 | android.AssertPathsRelativeToTopEquals(t, "import with import deps local combined implementation jar inputs", |
| 1294 | []string{"import_deps.jar"}, importWithImportDepsLocalJar.Inputs) |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1295 | } |
| 1296 | |
Zoran Jovanovic | 8736ce2 | 2018-08-21 17:10:29 +0200 | [diff] [blame] | 1297 | var compilerFlagsTestCases = []struct { |
| 1298 | in string |
| 1299 | out bool |
| 1300 | }{ |
| 1301 | { |
| 1302 | in: "a", |
| 1303 | out: false, |
| 1304 | }, |
| 1305 | { |
| 1306 | in: "-a", |
| 1307 | out: true, |
| 1308 | }, |
| 1309 | { |
| 1310 | in: "-no-jdk", |
| 1311 | out: false, |
| 1312 | }, |
| 1313 | { |
| 1314 | in: "-no-stdlib", |
| 1315 | out: false, |
| 1316 | }, |
| 1317 | { |
| 1318 | in: "-kotlin-home", |
| 1319 | out: false, |
| 1320 | }, |
| 1321 | { |
| 1322 | in: "-kotlin-home /some/path", |
| 1323 | out: false, |
| 1324 | }, |
| 1325 | { |
| 1326 | in: "-include-runtime", |
| 1327 | out: false, |
| 1328 | }, |
| 1329 | { |
| 1330 | in: "-Xintellij-plugin-root", |
| 1331 | out: false, |
| 1332 | }, |
| 1333 | } |
| 1334 | |
| 1335 | type mockContext struct { |
| 1336 | android.ModuleContext |
| 1337 | result bool |
| 1338 | } |
| 1339 | |
| 1340 | func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) { |
| 1341 | // CheckBadCompilerFlags calls this function when the flag should be rejected |
| 1342 | ctx.result = false |
| 1343 | } |
| 1344 | |
| 1345 | func TestCompilerFlags(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1346 | t.Parallel() |
Zoran Jovanovic | 8736ce2 | 2018-08-21 17:10:29 +0200 | [diff] [blame] | 1347 | for _, testCase := range compilerFlagsTestCases { |
| 1348 | ctx := &mockContext{result: true} |
| 1349 | CheckKotlincFlags(ctx, []string{testCase.in}) |
| 1350 | if ctx.result != testCase.out { |
| 1351 | t.Errorf("incorrect output:") |
| 1352 | t.Errorf(" input: %#v", testCase.in) |
| 1353 | t.Errorf(" expected: %#v", testCase.out) |
| 1354 | t.Errorf(" got: %#v", ctx.result) |
| 1355 | } |
| 1356 | } |
| 1357 | } |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1358 | |
| 1359 | // TODO(jungjw): Consider making this more robust by ignoring path order. |
| 1360 | func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) { |
Colin Cross | 8ff4af3 | 2025-02-19 15:17:02 -0800 | [diff] [blame] | 1361 | t.Helper() |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1362 | variables := ctx.ModuleForTests(t, moduleName, "android_common").VariablesForTestsRelativeToTop() |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1363 | flags := strings.Split(variables["javacFlags"], " ") |
| 1364 | got := "" |
| 1365 | for _, flag := range flags { |
| 1366 | keyEnd := strings.Index(flag, "=") |
| 1367 | if keyEnd > -1 && flag[:keyEnd] == "--patch-module" { |
| 1368 | got = flag[keyEnd+1:] |
| 1369 | break |
| 1370 | } |
| 1371 | } |
Lukacs T. Berki | 9f6c24a | 2021-08-26 15:07:24 +0200 | [diff] [blame] | 1372 | if expected != android.StringPathRelativeToTop(ctx.Config().SoongOutDir(), got) { |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1373 | t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got) |
| 1374 | } |
| 1375 | } |
| 1376 | |
| 1377 | func TestPatchModule(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1378 | t.Parallel() |
Pete Gillin | 0c2143e | 2019-05-02 15:32:11 +0100 | [diff] [blame] | 1379 | t.Run("Java language level 8", func(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1380 | t.Parallel() |
Pete Gillin | 1b3370f | 2019-10-01 13:57:31 +0100 | [diff] [blame] | 1381 | // Test with legacy javac -source 1.8 -target 1.8 |
Pete Gillin | bdf5d71 | 2019-10-21 14:29:58 +0100 | [diff] [blame] | 1382 | bp := ` |
| 1383 | java_library { |
| 1384 | name: "foo", |
| 1385 | srcs: ["a.java"], |
| 1386 | java_version: "1.8", |
| 1387 | } |
| 1388 | |
| 1389 | java_library { |
| 1390 | name: "bar", |
| 1391 | srcs: ["b.java"], |
| 1392 | sdk_version: "none", |
| 1393 | system_modules: "none", |
| 1394 | patch_module: "java.base", |
| 1395 | java_version: "1.8", |
| 1396 | } |
| 1397 | |
| 1398 | java_library { |
| 1399 | name: "baz", |
| 1400 | srcs: ["c.java"], |
| 1401 | patch_module: "java.base", |
| 1402 | java_version: "1.8", |
| 1403 | } |
| 1404 | ` |
| 1405 | ctx, _ := testJava(t, bp) |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1406 | |
| 1407 | checkPatchModuleFlag(t, ctx, "foo", "") |
| 1408 | checkPatchModuleFlag(t, ctx, "bar", "") |
| 1409 | checkPatchModuleFlag(t, ctx, "baz", "") |
| 1410 | }) |
| 1411 | |
Pete Gillin | 0c2143e | 2019-05-02 15:32:11 +0100 | [diff] [blame] | 1412 | t.Run("Java language level 9", func(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1413 | t.Parallel() |
Pete Gillin | 1b3370f | 2019-10-01 13:57:31 +0100 | [diff] [blame] | 1414 | // Test with default javac -source 9 -target 9 |
Pete Gillin | bdf5d71 | 2019-10-21 14:29:58 +0100 | [diff] [blame] | 1415 | bp := ` |
| 1416 | java_library { |
| 1417 | name: "foo", |
| 1418 | srcs: ["a.java"], |
| 1419 | } |
| 1420 | |
| 1421 | java_library { |
| 1422 | name: "bar", |
| 1423 | srcs: ["b.java"], |
| 1424 | sdk_version: "none", |
| 1425 | system_modules: "none", |
| 1426 | patch_module: "java.base", |
| 1427 | } |
| 1428 | |
| 1429 | java_library { |
| 1430 | name: "baz", |
Jingwen Chen | 5136a6e | 2020-10-30 01:01:35 -0400 | [diff] [blame] | 1431 | srcs: [ |
| 1432 | "c.java", |
| 1433 | // Tests for b/150878007 |
| 1434 | "dir/d.java", |
| 1435 | "dir2/e.java", |
| 1436 | "dir2/f.java", |
| 1437 | "nested/dir/g.java" |
| 1438 | ], |
Pete Gillin | bdf5d71 | 2019-10-21 14:29:58 +0100 | [diff] [blame] | 1439 | patch_module: "java.base", |
| 1440 | } |
| 1441 | ` |
Pete Gillin | 1b3370f | 2019-10-01 13:57:31 +0100 | [diff] [blame] | 1442 | ctx, _ := testJava(t, bp) |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1443 | |
| 1444 | checkPatchModuleFlag(t, ctx, "foo", "") |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1445 | expected := "java.base=.:out/soong" |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1446 | checkPatchModuleFlag(t, ctx, "bar", expected) |
Jingwen Chen | 5136a6e | 2020-10-30 01:01:35 -0400 | [diff] [blame] | 1447 | expected = "java.base=" + strings.Join([]string{ |
Colin Cross | 8ff1058 | 2023-12-07 13:10:56 -0800 | [diff] [blame] | 1448 | ".", "out/soong", defaultModuleToPath("ext"), defaultModuleToPath("framework")}, ":") |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1449 | checkPatchModuleFlag(t, ctx, "baz", expected) |
| 1450 | }) |
| 1451 | } |
Paul Duffin | a7b9f42 | 2020-01-10 17:12:18 +0000 | [diff] [blame] | 1452 | |
Paul Duffin | 83a2d96 | 2019-11-19 19:44:10 +0000 | [diff] [blame] | 1453 | func TestJavaLibraryWithSystemModules(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1454 | t.Parallel() |
Paul Duffin | 83a2d96 | 2019-11-19 19:44:10 +0000 | [diff] [blame] | 1455 | ctx, _ := testJava(t, ` |
| 1456 | java_library { |
| 1457 | name: "lib-with-source-system-modules", |
| 1458 | srcs: [ |
| 1459 | "a.java", |
| 1460 | ], |
| 1461 | sdk_version: "none", |
| 1462 | system_modules: "source-system-modules", |
| 1463 | } |
| 1464 | |
| 1465 | java_library { |
| 1466 | name: "source-jar", |
| 1467 | srcs: [ |
| 1468 | "a.java", |
| 1469 | ], |
| 1470 | } |
| 1471 | |
| 1472 | java_system_modules { |
| 1473 | name: "source-system-modules", |
| 1474 | libs: ["source-jar"], |
| 1475 | } |
| 1476 | |
| 1477 | java_library { |
| 1478 | name: "lib-with-prebuilt-system-modules", |
| 1479 | srcs: [ |
| 1480 | "a.java", |
| 1481 | ], |
| 1482 | sdk_version: "none", |
| 1483 | system_modules: "prebuilt-system-modules", |
| 1484 | } |
| 1485 | |
| 1486 | java_import { |
| 1487 | name: "prebuilt-jar", |
| 1488 | jars: ["a.jar"], |
| 1489 | } |
| 1490 | |
| 1491 | java_system_modules_import { |
| 1492 | name: "prebuilt-system-modules", |
| 1493 | libs: ["prebuilt-jar"], |
| 1494 | } |
| 1495 | `) |
| 1496 | |
Jihoon Kang | b0f4c02 | 2024-08-06 00:15:25 +0000 | [diff] [blame] | 1497 | checkBootClasspathForLibWithSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar") |
Paul Duffin | 83a2d96 | 2019-11-19 19:44:10 +0000 | [diff] [blame] | 1498 | |
Jihoon Kang | b0f4c02 | 2024-08-06 00:15:25 +0000 | [diff] [blame] | 1499 | checkBootClasspathForLibWithSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar") |
Paul Duffin | 83a2d96 | 2019-11-19 19:44:10 +0000 | [diff] [blame] | 1500 | } |
| 1501 | |
Jihoon Kang | b0f4c02 | 2024-08-06 00:15:25 +0000 | [diff] [blame] | 1502 | func checkBootClasspathForLibWithSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) { |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1503 | javacRule := ctx.ModuleForTests(t, moduleName, "android_common").Rule("javac") |
Paul Duffin | 83a2d96 | 2019-11-19 19:44:10 +0000 | [diff] [blame] | 1504 | bootClasspath := javacRule.Args["bootClasspath"] |
| 1505 | if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) { |
| 1506 | t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath) |
| 1507 | } |
| 1508 | } |
Jiyong Park | 19604de | 2020-03-24 16:44:11 +0900 | [diff] [blame] | 1509 | |
| 1510 | func TestAidlExportIncludeDirsFromImports(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1511 | t.Parallel() |
Jiyong Park | 19604de | 2020-03-24 16:44:11 +0900 | [diff] [blame] | 1512 | ctx, _ := testJava(t, ` |
| 1513 | java_library { |
| 1514 | name: "foo", |
| 1515 | srcs: ["aidl/foo/IFoo.aidl"], |
| 1516 | libs: ["bar"], |
| 1517 | } |
| 1518 | |
| 1519 | java_import { |
| 1520 | name: "bar", |
| 1521 | jars: ["a.jar"], |
| 1522 | aidl: { |
| 1523 | export_include_dirs: ["aidl/bar"], |
| 1524 | }, |
| 1525 | } |
| 1526 | `) |
| 1527 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1528 | aidlCommand := ctx.ModuleForTests(t, "foo", "android_common").Rule("aidl").RuleParams.Command |
Jiyong Park | 19604de | 2020-03-24 16:44:11 +0900 | [diff] [blame] | 1529 | expectedAidlFlag := "-Iaidl/bar" |
| 1530 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 1531 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 1532 | } |
| 1533 | } |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1534 | |
Jooyung Han | e197d8b | 2021-01-05 10:33:16 +0900 | [diff] [blame] | 1535 | func TestAidlFlagsArePassedToTheAidlCompiler(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1536 | t.Parallel() |
Jooyung Han | e197d8b | 2021-01-05 10:33:16 +0900 | [diff] [blame] | 1537 | ctx, _ := testJava(t, ` |
| 1538 | java_library { |
| 1539 | name: "foo", |
| 1540 | srcs: ["aidl/foo/IFoo.aidl"], |
| 1541 | aidl: { flags: ["-Werror"], }, |
| 1542 | } |
| 1543 | `) |
| 1544 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1545 | aidlCommand := ctx.ModuleForTests(t, "foo", "android_common").Rule("aidl").RuleParams.Command |
Jooyung Han | e197d8b | 2021-01-05 10:33:16 +0900 | [diff] [blame] | 1546 | expectedAidlFlag := "-Werror" |
| 1547 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 1548 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 1549 | } |
| 1550 | } |
| 1551 | |
Jooyung Han | 07f70c0 | 2021-11-06 07:08:45 +0900 | [diff] [blame] | 1552 | func TestAidlFlagsWithMinSdkVersion(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1553 | t.Parallel() |
Jooyung Han | 07f70c0 | 2021-11-06 07:08:45 +0900 | [diff] [blame] | 1554 | fixture := android.GroupFixturePreparers( |
| 1555 | prepareForJavaTest, FixtureWithPrebuiltApis(map[string][]string{"14": {"foo"}})) |
| 1556 | |
| 1557 | for _, tc := range []struct { |
| 1558 | name string |
| 1559 | sdkVersion string |
| 1560 | expected string |
| 1561 | }{ |
| 1562 | {"default is current", "", "current"}, |
| 1563 | {"use sdk_version", `sdk_version: "14"`, "14"}, |
| 1564 | {"system_current", `sdk_version: "system_current"`, "current"}, |
| 1565 | } { |
| 1566 | t.Run(tc.name, func(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1567 | t.Parallel() |
Jooyung Han | 07f70c0 | 2021-11-06 07:08:45 +0900 | [diff] [blame] | 1568 | ctx := fixture.RunTestWithBp(t, ` |
| 1569 | java_library { |
| 1570 | name: "foo", |
| 1571 | srcs: ["aidl/foo/IFoo.aidl"], |
| 1572 | `+tc.sdkVersion+` |
| 1573 | } |
| 1574 | `) |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1575 | aidlCommand := ctx.ModuleForTests(t, "foo", "android_common").Rule("aidl").RuleParams.Command |
Jooyung Han | 07f70c0 | 2021-11-06 07:08:45 +0900 | [diff] [blame] | 1576 | expectedAidlFlag := "--min_sdk_version=" + tc.expected |
| 1577 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 1578 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 1579 | } |
| 1580 | }) |
| 1581 | } |
| 1582 | } |
| 1583 | |
Spandan Das | 757b666 | 2022-11-17 04:29:59 +0000 | [diff] [blame] | 1584 | func TestAidlFlagsMinSdkVersionDroidstubs(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1585 | t.Parallel() |
Spandan Das | 757b666 | 2022-11-17 04:29:59 +0000 | [diff] [blame] | 1586 | bpTemplate := ` |
| 1587 | droidstubs { |
| 1588 | name: "foo-stubs", |
| 1589 | srcs: ["foo.aidl"], |
| 1590 | %s |
| 1591 | system_modules: "none", |
| 1592 | } |
| 1593 | ` |
| 1594 | testCases := []struct { |
| 1595 | desc string |
| 1596 | sdkVersionBp string |
| 1597 | minSdkVersionExpected string |
| 1598 | }{ |
| 1599 | { |
| 1600 | desc: "sdk_version not set, module compiles against private platform APIs", |
| 1601 | sdkVersionBp: ``, |
| 1602 | minSdkVersionExpected: "10000", |
| 1603 | }, |
| 1604 | { |
| 1605 | desc: "sdk_version set to none, module does not build against an SDK", |
| 1606 | sdkVersionBp: `sdk_version: "none",`, |
| 1607 | minSdkVersionExpected: "10000", |
| 1608 | }, |
| 1609 | } |
| 1610 | for _, tc := range testCases { |
| 1611 | ctx := prepareForJavaTest.RunTestWithBp(t, fmt.Sprintf(bpTemplate, tc.sdkVersionBp)) |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1612 | aidlCmd := ctx.ModuleForTests(t, "foo-stubs", "android_common").Rule("aidl").RuleParams.Command |
Spandan Das | 757b666 | 2022-11-17 04:29:59 +0000 | [diff] [blame] | 1613 | expected := "--min_sdk_version=" + tc.minSdkVersionExpected |
| 1614 | android.AssertStringDoesContain(t, "aidl command conatins incorrect min_sdk_version for testCse: "+tc.desc, aidlCmd, expected) |
| 1615 | } |
| 1616 | } |
| 1617 | |
Thiébaud Weksteen | de8417c | 2022-02-10 15:41:46 +1100 | [diff] [blame] | 1618 | func TestAidlEnforcePermissions(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1619 | t.Parallel() |
Thiébaud Weksteen | de8417c | 2022-02-10 15:41:46 +1100 | [diff] [blame] | 1620 | ctx, _ := testJava(t, ` |
| 1621 | java_library { |
| 1622 | name: "foo", |
| 1623 | srcs: ["aidl/foo/IFoo.aidl"], |
| 1624 | aidl: { enforce_permissions: true }, |
| 1625 | } |
| 1626 | `) |
| 1627 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1628 | aidlCommand := ctx.ModuleForTests(t, "foo", "android_common").Rule("aidl").RuleParams.Command |
Thiébaud Weksteen | de8417c | 2022-02-10 15:41:46 +1100 | [diff] [blame] | 1629 | expectedAidlFlag := "-Wmissing-permission-annotation -Werror" |
| 1630 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 1631 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 1632 | } |
| 1633 | } |
| 1634 | |
| 1635 | func TestAidlEnforcePermissionsException(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1636 | t.Parallel() |
Thiébaud Weksteen | de8417c | 2022-02-10 15:41:46 +1100 | [diff] [blame] | 1637 | ctx, _ := testJava(t, ` |
| 1638 | java_library { |
| 1639 | name: "foo", |
| 1640 | srcs: ["aidl/foo/IFoo.aidl", "aidl/foo/IFoo2.aidl"], |
| 1641 | aidl: { enforce_permissions: true, enforce_permissions_exceptions: ["aidl/foo/IFoo2.aidl"] }, |
| 1642 | } |
| 1643 | `) |
| 1644 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1645 | aidlCommand := ctx.ModuleForTests(t, "foo", "android_common").Rule("aidl").RuleParams.Command |
Thiébaud Weksteen | de8417c | 2022-02-10 15:41:46 +1100 | [diff] [blame] | 1646 | expectedAidlFlag := "$$FLAGS -Wmissing-permission-annotation -Werror aidl/foo/IFoo.aidl" |
| 1647 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 1648 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 1649 | } |
| 1650 | expectedAidlFlag = "$$FLAGS aidl/foo/IFoo2.aidl" |
| 1651 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 1652 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 1653 | } |
| 1654 | } |
| 1655 | |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1656 | func TestDataNativeBinaries(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1657 | t.Parallel() |
Cole Faust | 5c503d1 | 2023-01-24 11:48:08 -0800 | [diff] [blame] | 1658 | ctx := android.GroupFixturePreparers( |
| 1659 | prepareForJavaTest, |
| 1660 | android.PrepareForTestWithAllowMissingDependencies).RunTestWithBp(t, ` |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1661 | java_test_host { |
| 1662 | name: "foo", |
| 1663 | srcs: ["a.java"], |
| 1664 | data_native_bins: ["bin"] |
| 1665 | } |
| 1666 | |
Cole Faust | 5c503d1 | 2023-01-24 11:48:08 -0800 | [diff] [blame] | 1667 | cc_binary_host { |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1668 | name: "bin", |
Cole Faust | 5c503d1 | 2023-01-24 11:48:08 -0800 | [diff] [blame] | 1669 | srcs: ["bin.cpp"], |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1670 | } |
Cole Faust | 5c503d1 | 2023-01-24 11:48:08 -0800 | [diff] [blame] | 1671 | `).TestContext |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1672 | |
Colin Cross | 0c66bc6 | 2021-07-20 09:47:41 -0700 | [diff] [blame] | 1673 | buildOS := ctx.Config().BuildOS.String() |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1674 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1675 | test := ctx.ModuleForTests(t, "foo", buildOS+"_common").Module().(*TestHost) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 1676 | entries := android.AndroidMkEntriesForTest(t, ctx, test)[0] |
Cole Faust | 5c503d1 | 2023-01-24 11:48:08 -0800 | [diff] [blame] | 1677 | expected := []string{"out/soong/.intermediates/bin/" + buildOS + "_x86_64/bin:bin"} |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1678 | actual := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"] |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1679 | android.AssertStringPathsRelativeToTopEquals(t, "LOCAL_COMPATIBILITY_SUPPORT_FILES", ctx.Config(), expected, actual) |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1680 | } |
Yuexi Ma | 627263f | 2021-03-04 13:47:56 -0800 | [diff] [blame] | 1681 | |
| 1682 | func TestDefaultInstallable(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1683 | t.Parallel() |
Yuexi Ma | 627263f | 2021-03-04 13:47:56 -0800 | [diff] [blame] | 1684 | ctx, _ := testJava(t, ` |
| 1685 | java_test_host { |
| 1686 | name: "foo" |
| 1687 | } |
| 1688 | `) |
| 1689 | |
Colin Cross | 0c66bc6 | 2021-07-20 09:47:41 -0700 | [diff] [blame] | 1690 | buildOS := ctx.Config().BuildOS.String() |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1691 | module := ctx.ModuleForTests(t, "foo", buildOS+"_common").Module().(*TestHost) |
Yuexi Ma | 627263f | 2021-03-04 13:47:56 -0800 | [diff] [blame] | 1692 | assertDeepEquals(t, "Default installable value should be true.", proptools.BoolPtr(true), |
| 1693 | module.properties.Installable) |
| 1694 | } |
Cole Faust | 75fffb1 | 2021-06-13 15:23:16 -0700 | [diff] [blame] | 1695 | |
| 1696 | func TestErrorproneEnabled(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1697 | t.Parallel() |
Cole Faust | 75fffb1 | 2021-06-13 15:23:16 -0700 | [diff] [blame] | 1698 | ctx, _ := testJava(t, ` |
| 1699 | java_library { |
| 1700 | name: "foo", |
| 1701 | srcs: ["a.java"], |
| 1702 | errorprone: { |
| 1703 | enabled: true, |
| 1704 | }, |
| 1705 | } |
| 1706 | `) |
| 1707 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1708 | javac := ctx.ModuleForTests(t, "foo", "android_common").Description("javac") |
Cole Faust | 75fffb1 | 2021-06-13 15:23:16 -0700 | [diff] [blame] | 1709 | |
| 1710 | // Test that the errorprone plugins are passed to javac |
| 1711 | expectedSubstring := "-Xplugin:ErrorProne" |
| 1712 | if !strings.Contains(javac.Args["javacFlags"], expectedSubstring) { |
Cole Faust | 2b1536e | 2021-06-18 12:25:54 -0700 | [diff] [blame] | 1713 | t.Errorf("expected javacFlags to contain %q, got %q", expectedSubstring, javac.Args["javacFlags"]) |
Cole Faust | 75fffb1 | 2021-06-13 15:23:16 -0700 | [diff] [blame] | 1714 | } |
| 1715 | |
| 1716 | // Modules with errorprone { enabled: true } will include errorprone checks |
| 1717 | // in the main javac build rule. Only when RUN_ERROR_PRONE is true will |
| 1718 | // the explicit errorprone build rule be created. |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1719 | errorprone := ctx.ModuleForTests(t, "foo", "android_common").MaybeDescription("errorprone") |
Cole Faust | 75fffb1 | 2021-06-13 15:23:16 -0700 | [diff] [blame] | 1720 | if errorprone.RuleParams.Description != "" { |
| 1721 | t.Errorf("expected errorprone build rule to not exist, but it did") |
| 1722 | } |
| 1723 | } |
Cole Faust | 2b1536e | 2021-06-18 12:25:54 -0700 | [diff] [blame] | 1724 | |
| 1725 | func TestErrorproneDisabled(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1726 | t.Parallel() |
Cole Faust | 2b1536e | 2021-06-18 12:25:54 -0700 | [diff] [blame] | 1727 | bp := ` |
| 1728 | java_library { |
| 1729 | name: "foo", |
| 1730 | srcs: ["a.java"], |
| 1731 | errorprone: { |
| 1732 | enabled: false, |
| 1733 | }, |
| 1734 | } |
| 1735 | ` |
| 1736 | ctx := android.GroupFixturePreparers( |
| 1737 | PrepareForTestWithJavaDefaultModules, |
| 1738 | android.FixtureMergeEnv(map[string]string{ |
| 1739 | "RUN_ERROR_PRONE": "true", |
| 1740 | }), |
| 1741 | ).RunTestWithBp(t, bp) |
| 1742 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1743 | javac := ctx.ModuleForTests(t, "foo", "android_common").Description("javac") |
Cole Faust | 2b1536e | 2021-06-18 12:25:54 -0700 | [diff] [blame] | 1744 | |
| 1745 | // Test that the errorprone plugins are not passed to javac, like they would |
| 1746 | // be if enabled was true. |
| 1747 | expectedSubstring := "-Xplugin:ErrorProne" |
| 1748 | if strings.Contains(javac.Args["javacFlags"], expectedSubstring) { |
| 1749 | t.Errorf("expected javacFlags to not contain %q, got %q", expectedSubstring, javac.Args["javacFlags"]) |
| 1750 | } |
| 1751 | |
| 1752 | // Check that no errorprone build rule is created, like there would be |
| 1753 | // if enabled was unset and RUN_ERROR_PRONE was true. |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1754 | errorprone := ctx.ModuleForTests(t, "foo", "android_common").MaybeDescription("errorprone") |
Cole Faust | 2b1536e | 2021-06-18 12:25:54 -0700 | [diff] [blame] | 1755 | if errorprone.RuleParams.Description != "" { |
| 1756 | t.Errorf("expected errorprone build rule to not exist, but it did") |
| 1757 | } |
| 1758 | } |
| 1759 | |
| 1760 | func TestErrorproneEnabledOnlyByEnvironmentVariable(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1761 | t.Parallel() |
Cole Faust | 2b1536e | 2021-06-18 12:25:54 -0700 | [diff] [blame] | 1762 | bp := ` |
| 1763 | java_library { |
| 1764 | name: "foo", |
| 1765 | srcs: ["a.java"], |
| 1766 | } |
| 1767 | ` |
| 1768 | ctx := android.GroupFixturePreparers( |
| 1769 | PrepareForTestWithJavaDefaultModules, |
| 1770 | android.FixtureMergeEnv(map[string]string{ |
| 1771 | "RUN_ERROR_PRONE": "true", |
| 1772 | }), |
| 1773 | ).RunTestWithBp(t, bp) |
| 1774 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1775 | javac := ctx.ModuleForTests(t, "foo", "android_common").Description("javac") |
| 1776 | errorprone := ctx.ModuleForTests(t, "foo", "android_common").Description("errorprone") |
Cole Faust | 2b1536e | 2021-06-18 12:25:54 -0700 | [diff] [blame] | 1777 | |
| 1778 | // Check that the errorprone plugins are not passed to javac, because they |
| 1779 | // will instead be passed to the separate errorprone compilation |
| 1780 | expectedSubstring := "-Xplugin:ErrorProne" |
| 1781 | if strings.Contains(javac.Args["javacFlags"], expectedSubstring) { |
| 1782 | t.Errorf("expected javacFlags to not contain %q, got %q", expectedSubstring, javac.Args["javacFlags"]) |
| 1783 | } |
| 1784 | |
| 1785 | // Check that the errorprone plugin is enabled |
| 1786 | if !strings.Contains(errorprone.Args["javacFlags"], expectedSubstring) { |
| 1787 | t.Errorf("expected errorprone to contain %q, got %q", expectedSubstring, javac.Args["javacFlags"]) |
| 1788 | } |
| 1789 | } |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1790 | |
| 1791 | func TestDataDeviceBinsBuildsDeviceBinary(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1792 | t.Parallel() |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1793 | testCases := []struct { |
| 1794 | dataDeviceBinType string |
| 1795 | depCompileMultilib string |
| 1796 | variants []string |
| 1797 | expectedError string |
| 1798 | }{ |
| 1799 | { |
| 1800 | dataDeviceBinType: "first", |
| 1801 | depCompileMultilib: "first", |
| 1802 | variants: []string{"android_arm64_armv8-a"}, |
| 1803 | }, |
| 1804 | { |
| 1805 | dataDeviceBinType: "first", |
| 1806 | depCompileMultilib: "both", |
| 1807 | variants: []string{"android_arm64_armv8-a"}, |
| 1808 | }, |
| 1809 | { |
| 1810 | // this is true because our testing framework is set up with |
| 1811 | // Targets ~ [<64bit target>, <32bit target>], where 64bit is "first" |
| 1812 | dataDeviceBinType: "first", |
| 1813 | depCompileMultilib: "32", |
| 1814 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1815 | }, |
| 1816 | { |
| 1817 | dataDeviceBinType: "first", |
| 1818 | depCompileMultilib: "64", |
| 1819 | variants: []string{"android_arm64_armv8-a"}, |
| 1820 | }, |
| 1821 | { |
| 1822 | dataDeviceBinType: "both", |
| 1823 | depCompileMultilib: "both", |
| 1824 | variants: []string{ |
| 1825 | "android_arm_armv7-a-neon", |
| 1826 | "android_arm64_armv8-a", |
| 1827 | }, |
| 1828 | }, |
| 1829 | { |
| 1830 | dataDeviceBinType: "both", |
| 1831 | depCompileMultilib: "32", |
| 1832 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1833 | }, |
| 1834 | { |
| 1835 | dataDeviceBinType: "both", |
| 1836 | depCompileMultilib: "64", |
| 1837 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1838 | }, |
| 1839 | { |
| 1840 | dataDeviceBinType: "both", |
| 1841 | depCompileMultilib: "first", |
| 1842 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1843 | }, |
| 1844 | { |
| 1845 | dataDeviceBinType: "32", |
| 1846 | depCompileMultilib: "32", |
| 1847 | variants: []string{"android_arm_armv7-a-neon"}, |
| 1848 | }, |
| 1849 | { |
| 1850 | dataDeviceBinType: "32", |
| 1851 | depCompileMultilib: "first", |
| 1852 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1853 | }, |
| 1854 | { |
| 1855 | dataDeviceBinType: "32", |
| 1856 | depCompileMultilib: "both", |
| 1857 | variants: []string{"android_arm_armv7-a-neon"}, |
| 1858 | }, |
| 1859 | { |
| 1860 | dataDeviceBinType: "32", |
| 1861 | depCompileMultilib: "64", |
| 1862 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1863 | }, |
| 1864 | { |
| 1865 | dataDeviceBinType: "64", |
| 1866 | depCompileMultilib: "64", |
| 1867 | variants: []string{"android_arm64_armv8-a"}, |
| 1868 | }, |
| 1869 | { |
| 1870 | dataDeviceBinType: "64", |
| 1871 | depCompileMultilib: "both", |
| 1872 | variants: []string{"android_arm64_armv8-a"}, |
| 1873 | }, |
| 1874 | { |
| 1875 | dataDeviceBinType: "64", |
| 1876 | depCompileMultilib: "first", |
| 1877 | variants: []string{"android_arm64_armv8-a"}, |
| 1878 | }, |
| 1879 | { |
| 1880 | dataDeviceBinType: "64", |
| 1881 | depCompileMultilib: "32", |
| 1882 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1883 | }, |
| 1884 | { |
| 1885 | dataDeviceBinType: "prefer32", |
| 1886 | depCompileMultilib: "32", |
| 1887 | variants: []string{"android_arm_armv7-a-neon"}, |
| 1888 | }, |
| 1889 | { |
| 1890 | dataDeviceBinType: "prefer32", |
| 1891 | depCompileMultilib: "both", |
| 1892 | variants: []string{"android_arm_armv7-a-neon"}, |
| 1893 | }, |
| 1894 | { |
| 1895 | dataDeviceBinType: "prefer32", |
| 1896 | depCompileMultilib: "first", |
| 1897 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1898 | }, |
| 1899 | { |
| 1900 | dataDeviceBinType: "prefer32", |
| 1901 | depCompileMultilib: "64", |
| 1902 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1903 | }, |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1904 | } |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1905 | |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1906 | bpTemplate := ` |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1907 | java_test_host { |
| 1908 | name: "foo", |
| 1909 | srcs: ["test.java"], |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1910 | data_device_bins_%s: ["bar"], |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1911 | } |
| 1912 | |
| 1913 | cc_binary { |
| 1914 | name: "bar", |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1915 | compile_multilib: "%s", |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1916 | } |
| 1917 | ` |
| 1918 | |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1919 | for _, tc := range testCases { |
| 1920 | bp := fmt.Sprintf(bpTemplate, tc.dataDeviceBinType, tc.depCompileMultilib) |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1921 | |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1922 | errorHandler := android.FixtureExpectsNoErrors |
| 1923 | if tc.expectedError != "" { |
| 1924 | errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(tc.expectedError) |
| 1925 | } |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1926 | |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1927 | testName := fmt.Sprintf(`data_device_bins_%s with compile_multilib:"%s"`, tc.dataDeviceBinType, tc.depCompileMultilib) |
| 1928 | t.Run(testName, func(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1929 | t.Parallel() |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1930 | ctx := android.GroupFixturePreparers(PrepareForIntegrationTestWithJava). |
| 1931 | ExtendWithErrorHandler(errorHandler). |
| 1932 | RunTestWithBp(t, bp) |
| 1933 | if tc.expectedError != "" { |
| 1934 | return |
| 1935 | } |
| 1936 | |
| 1937 | buildOS := ctx.Config.BuildOS.String() |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1938 | fooVariant := ctx.ModuleForTests(t, "foo", buildOS+"_common") |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1939 | fooMod := fooVariant.Module().(*TestHost) |
| 1940 | entries := android.AndroidMkEntriesForTest(t, ctx.TestContext, fooMod)[0] |
| 1941 | |
| 1942 | expectedAutogenConfig := `<option name="push-file" key="bar" value="/data/local/tests/unrestricted/foo/bar" />` |
| 1943 | autogen := fooVariant.Rule("autogen") |
| 1944 | if !strings.Contains(autogen.Args["extraConfigs"], expectedAutogenConfig) { |
| 1945 | t.Errorf("foo extraConfigs %v does not contain %q", autogen.Args["extraConfigs"], expectedAutogenConfig) |
| 1946 | } |
| 1947 | |
| 1948 | expectedData := []string{} |
| 1949 | for _, variant := range tc.variants { |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1950 | barVariant := ctx.ModuleForTests(t, "bar", variant) |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1951 | relocated := barVariant.Output("bar") |
| 1952 | expectedInput := fmt.Sprintf("out/soong/.intermediates/bar/%s/unstripped/bar", variant) |
| 1953 | android.AssertPathRelativeToTopEquals(t, "relocation input", expectedInput, relocated.Input) |
| 1954 | |
| 1955 | expectedData = append(expectedData, fmt.Sprintf("out/soong/.intermediates/bar/%s/bar:bar", variant)) |
| 1956 | } |
| 1957 | |
| 1958 | actualData := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"] |
Jihoon Kang | 8219749 | 2025-01-29 19:30:31 +0000 | [diff] [blame] | 1959 | android.AssertStringPathsRelativeToTopEquals(t, "LOCAL_TEST_DATA", ctx.Config, android.SortedUniqueStrings(expectedData), android.SortedUniqueStrings(actualData)) |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1960 | }) |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1961 | } |
| 1962 | } |
Sam Delmerico | 277795c | 2022-02-25 17:04:37 +0000 | [diff] [blame] | 1963 | |
Zi Wang | ca65b40 | 2022-10-10 13:45:06 -0700 | [diff] [blame] | 1964 | func TestDeviceBinaryWrapperGeneration(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1965 | t.Parallel() |
Zi Wang | ca65b40 | 2022-10-10 13:45:06 -0700 | [diff] [blame] | 1966 | // Scenario 1: java_binary has main_class property in its bp |
| 1967 | ctx, _ := testJava(t, ` |
| 1968 | java_binary { |
| 1969 | name: "foo", |
| 1970 | srcs: ["foo.java"], |
| 1971 | main_class: "foo.bar.jb", |
| 1972 | } |
| 1973 | `) |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 1974 | wrapperPath := fmt.Sprint(ctx.ModuleForTests(t, "foo", "android_common").AllOutputs()) |
Zi Wang | ca65b40 | 2022-10-10 13:45:06 -0700 | [diff] [blame] | 1975 | if !strings.Contains(wrapperPath, "foo.sh") { |
| 1976 | t.Errorf("wrapper file foo.sh is not generated") |
| 1977 | } |
| 1978 | |
| 1979 | // Scenario 2: java_binary has neither wrapper nor main_class, its build |
| 1980 | // is expected to be failed. |
| 1981 | testJavaError(t, "main_class property is required for device binary if no default wrapper is assigned", ` |
| 1982 | java_binary { |
| 1983 | name: "foo", |
| 1984 | srcs: ["foo.java"], |
| 1985 | }`) |
| 1986 | } |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1987 | |
Jihoon Kang | 3198f3c | 2023-01-26 08:08:52 +0000 | [diff] [blame] | 1988 | func TestJavaApiContributionEmptyApiFile(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 1989 | t.Parallel() |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 1990 | android.GroupFixturePreparers( |
| 1991 | prepareForJavaTest, |
| 1992 | android.FixtureMergeEnv( |
| 1993 | map[string]string{ |
| 1994 | "DISABLE_STUB_VALIDATION": "true", |
| 1995 | }, |
| 1996 | ), |
| 1997 | ).ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern( |
Jihoon Kang | 3198f3c | 2023-01-26 08:08:52 +0000 | [diff] [blame] | 1998 | "Error: foo has an empty api file.", |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 1999 | )).RunTestWithBp(t, ` |
| 2000 | java_api_contribution { |
Jihoon Kang | 3198f3c | 2023-01-26 08:08:52 +0000 | [diff] [blame] | 2001 | name: "foo", |
| 2002 | } |
| 2003 | java_api_library { |
| 2004 | name: "bar", |
| 2005 | api_surface: "public", |
| 2006 | api_contributions: ["foo"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2007 | stubs_type: "everything", |
Jihoon Kang | 3198f3c | 2023-01-26 08:08:52 +0000 | [diff] [blame] | 2008 | } |
| 2009 | `) |
| 2010 | } |
| 2011 | |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2012 | func TestJavaApiLibraryAndProviderLink(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 2013 | t.Parallel() |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2014 | provider_bp_a := ` |
| 2015 | java_api_contribution { |
| 2016 | name: "foo1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2017 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2018 | api_surface: "public", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2019 | } |
| 2020 | ` |
| 2021 | provider_bp_b := `java_api_contribution { |
| 2022 | name: "foo2", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2023 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2024 | api_surface: "public", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2025 | } |
| 2026 | ` |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2027 | ctx := android.GroupFixturePreparers( |
| 2028 | prepareForJavaTest, |
| 2029 | android.FixtureMergeMockFs( |
| 2030 | map[string][]byte{ |
| 2031 | "a/Android.bp": []byte(provider_bp_a), |
| 2032 | "b/Android.bp": []byte(provider_bp_b), |
| 2033 | }, |
| 2034 | ), |
| 2035 | android.FixtureMergeEnv( |
| 2036 | map[string]string{ |
| 2037 | "DISABLE_STUB_VALIDATION": "true", |
| 2038 | }, |
| 2039 | ), |
| 2040 | ).RunTestWithBp(t, ` |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2041 | java_api_library { |
| 2042 | name: "bar1", |
| 2043 | api_surface: "public", |
Jihoon Kang | 60d4a09 | 2022-11-17 23:47:43 +0000 | [diff] [blame] | 2044 | api_contributions: ["foo1"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2045 | stubs_type: "everything", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2046 | } |
| 2047 | |
| 2048 | java_api_library { |
| 2049 | name: "bar2", |
| 2050 | api_surface: "system", |
Jihoon Kang | 60d4a09 | 2022-11-17 23:47:43 +0000 | [diff] [blame] | 2051 | api_contributions: ["foo1", "foo2"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2052 | stubs_type: "everything", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2053 | } |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2054 | `) |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2055 | |
| 2056 | testcases := []struct { |
| 2057 | moduleName string |
| 2058 | sourceTextFileDirs []string |
| 2059 | }{ |
| 2060 | { |
| 2061 | moduleName: "bar1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2062 | sourceTextFileDirs: []string{"a/current.txt"}, |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2063 | }, |
| 2064 | { |
| 2065 | moduleName: "bar2", |
Jihoon Kang | 6be0f00 | 2023-09-20 23:03:01 +0000 | [diff] [blame] | 2066 | sourceTextFileDirs: []string{"a/current.txt", "b/current.txt"}, |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2067 | }, |
| 2068 | } |
| 2069 | for _, c := range testcases { |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 2070 | m := ctx.ModuleForTests(t, c.moduleName, "android_common") |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2071 | manifest := m.Output("metalava.sbox.textproto") |
Colin Cross | f61d03d | 2023-11-02 16:56:39 -0700 | [diff] [blame] | 2072 | sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx.TestContext, manifest) |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2073 | manifestCommand := sboxProto.Commands[0].GetCommand() |
| 2074 | sourceFilesFlag := "--source-files " + strings.Join(c.sourceTextFileDirs, " ") |
| 2075 | android.AssertStringDoesContain(t, "source text files not present", manifestCommand, sourceFilesFlag) |
| 2076 | } |
| 2077 | } |
| 2078 | |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2079 | func TestJavaApiLibraryAndDefaultsLink(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 2080 | t.Parallel() |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2081 | provider_bp_a := ` |
| 2082 | java_api_contribution { |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2083 | name: "foo1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2084 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2085 | api_surface: "public", |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2086 | } |
| 2087 | ` |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2088 | provider_bp_b := ` |
| 2089 | java_api_contribution { |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2090 | name: "foo2", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2091 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2092 | api_surface: "public", |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2093 | } |
| 2094 | ` |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2095 | provider_bp_c := ` |
| 2096 | java_api_contribution { |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2097 | name: "foo3", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2098 | api_file: "system-current.txt", |
| 2099 | api_surface: "system", |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2100 | } |
| 2101 | ` |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2102 | provider_bp_d := ` |
| 2103 | java_api_contribution { |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2104 | name: "foo4", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2105 | api_file: "system-current.txt", |
| 2106 | api_surface: "system", |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2107 | } |
| 2108 | ` |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2109 | ctx := android.GroupFixturePreparers( |
| 2110 | prepareForJavaTest, |
| 2111 | android.FixtureMergeMockFs( |
| 2112 | map[string][]byte{ |
| 2113 | "a/Android.bp": []byte(provider_bp_a), |
| 2114 | "b/Android.bp": []byte(provider_bp_b), |
| 2115 | "c/Android.bp": []byte(provider_bp_c), |
| 2116 | "d/Android.bp": []byte(provider_bp_d), |
| 2117 | }, |
| 2118 | ), |
| 2119 | android.FixtureMergeEnv( |
| 2120 | map[string]string{ |
| 2121 | "DISABLE_STUB_VALIDATION": "true", |
| 2122 | }, |
| 2123 | ), |
| 2124 | ).RunTestWithBp(t, ` |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2125 | java_defaults { |
| 2126 | name: "baz1", |
| 2127 | api_surface: "public", |
| 2128 | api_contributions: ["foo1", "foo2"], |
| 2129 | } |
| 2130 | |
| 2131 | java_defaults { |
| 2132 | name: "baz2", |
| 2133 | api_surface: "system", |
| 2134 | api_contributions: ["foo3"], |
| 2135 | } |
| 2136 | |
| 2137 | java_api_library { |
| 2138 | name: "bar1", |
| 2139 | api_surface: "public", |
| 2140 | api_contributions: ["foo1"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2141 | stubs_type: "everything", |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2142 | } |
| 2143 | |
| 2144 | java_api_library { |
| 2145 | name: "bar2", |
| 2146 | api_surface: "public", |
| 2147 | defaults:["baz1"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2148 | stubs_type: "everything", |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2149 | } |
| 2150 | |
| 2151 | java_api_library { |
| 2152 | name: "bar3", |
| 2153 | api_surface: "system", |
| 2154 | defaults:["baz1", "baz2"], |
| 2155 | api_contributions: ["foo4"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2156 | stubs_type: "everything", |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2157 | } |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2158 | `) |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2159 | |
| 2160 | testcases := []struct { |
| 2161 | moduleName string |
| 2162 | sourceTextFileDirs []string |
| 2163 | }{ |
| 2164 | { |
| 2165 | moduleName: "bar1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2166 | sourceTextFileDirs: []string{"a/current.txt"}, |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2167 | }, |
| 2168 | { |
| 2169 | moduleName: "bar2", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2170 | sourceTextFileDirs: []string{"a/current.txt", "b/current.txt"}, |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2171 | }, |
| 2172 | { |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2173 | moduleName: "bar3", |
| 2174 | // API text files need to be sorted from the narrower api scope to the wider api scope |
Jihoon Kang | 6be0f00 | 2023-09-20 23:03:01 +0000 | [diff] [blame] | 2175 | sourceTextFileDirs: []string{"a/current.txt", "b/current.txt", "c/system-current.txt", "d/system-current.txt"}, |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2176 | }, |
| 2177 | } |
| 2178 | for _, c := range testcases { |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 2179 | m := ctx.ModuleForTests(t, c.moduleName, "android_common") |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2180 | manifest := m.Output("metalava.sbox.textproto") |
Colin Cross | f61d03d | 2023-11-02 16:56:39 -0700 | [diff] [blame] | 2181 | sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx.TestContext, manifest) |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2182 | manifestCommand := sboxProto.Commands[0].GetCommand() |
| 2183 | sourceFilesFlag := "--source-files " + strings.Join(c.sourceTextFileDirs, " ") |
| 2184 | android.AssertStringDoesContain(t, "source text files not present", manifestCommand, sourceFilesFlag) |
| 2185 | } |
| 2186 | } |
| 2187 | |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2188 | func TestJavaApiLibraryJarGeneration(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 2189 | t.Parallel() |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2190 | provider_bp_a := ` |
| 2191 | java_api_contribution { |
| 2192 | name: "foo1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2193 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2194 | api_surface: "public", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2195 | } |
| 2196 | ` |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2197 | provider_bp_b := ` |
| 2198 | java_api_contribution { |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2199 | name: "foo2", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2200 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2201 | api_surface: "public", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2202 | } |
| 2203 | ` |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2204 | ctx := android.GroupFixturePreparers( |
| 2205 | prepareForJavaTest, |
| 2206 | android.FixtureMergeMockFs( |
| 2207 | map[string][]byte{ |
| 2208 | "a/Android.bp": []byte(provider_bp_a), |
| 2209 | "b/Android.bp": []byte(provider_bp_b), |
| 2210 | }, |
| 2211 | ), |
| 2212 | android.FixtureMergeEnv( |
| 2213 | map[string]string{ |
| 2214 | "DISABLE_STUB_VALIDATION": "true", |
| 2215 | }, |
| 2216 | ), |
| 2217 | ).RunTestWithBp(t, ` |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2218 | java_api_library { |
| 2219 | name: "bar1", |
| 2220 | api_surface: "public", |
Jihoon Kang | 60d4a09 | 2022-11-17 23:47:43 +0000 | [diff] [blame] | 2221 | api_contributions: ["foo1"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2222 | stubs_type: "everything", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2223 | } |
| 2224 | |
| 2225 | java_api_library { |
| 2226 | name: "bar2", |
| 2227 | api_surface: "system", |
Jihoon Kang | 60d4a09 | 2022-11-17 23:47:43 +0000 | [diff] [blame] | 2228 | api_contributions: ["foo1", "foo2"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2229 | stubs_type: "everything", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2230 | } |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2231 | `) |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2232 | |
| 2233 | testcases := []struct { |
| 2234 | moduleName string |
| 2235 | outputJarName string |
| 2236 | }{ |
| 2237 | { |
| 2238 | moduleName: "bar1", |
Jihoon Kang | 25857f5 | 2023-03-01 00:27:32 +0000 | [diff] [blame] | 2239 | outputJarName: "bar1/bar1.jar", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2240 | }, |
| 2241 | { |
| 2242 | moduleName: "bar2", |
Jihoon Kang | 25857f5 | 2023-03-01 00:27:32 +0000 | [diff] [blame] | 2243 | outputJarName: "bar2/bar2.jar", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2244 | }, |
| 2245 | } |
| 2246 | for _, c := range testcases { |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 2247 | m := ctx.ModuleForTests(t, c.moduleName, "android_common") |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2248 | outputs := fmt.Sprint(m.AllOutputs()) |
| 2249 | if !strings.Contains(outputs, c.outputJarName) { |
| 2250 | t.Errorf("Module output does not contain expected jar %s", c.outputJarName) |
| 2251 | } |
| 2252 | } |
| 2253 | } |
Cole Faust | 2168054 | 2022-12-07 18:18:37 -0800 | [diff] [blame] | 2254 | |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2255 | func TestJavaApiLibraryLibsLink(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 2256 | t.Parallel() |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2257 | provider_bp_a := ` |
| 2258 | java_api_contribution { |
| 2259 | name: "foo1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2260 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2261 | api_surface: "public", |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2262 | } |
| 2263 | ` |
| 2264 | provider_bp_b := ` |
| 2265 | java_api_contribution { |
| 2266 | name: "foo2", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2267 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2268 | api_surface: "public", |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2269 | } |
| 2270 | ` |
| 2271 | lib_bp_a := ` |
| 2272 | java_library { |
| 2273 | name: "lib1", |
| 2274 | srcs: ["Lib.java"], |
| 2275 | } |
| 2276 | ` |
| 2277 | lib_bp_b := ` |
| 2278 | java_library { |
| 2279 | name: "lib2", |
| 2280 | srcs: ["Lib.java"], |
| 2281 | } |
| 2282 | ` |
| 2283 | |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2284 | ctx := android.GroupFixturePreparers( |
| 2285 | prepareForJavaTest, |
| 2286 | android.FixtureMergeMockFs( |
| 2287 | map[string][]byte{ |
| 2288 | "a/Android.bp": []byte(provider_bp_a), |
| 2289 | "b/Android.bp": []byte(provider_bp_b), |
| 2290 | "c/Android.bp": []byte(lib_bp_a), |
| 2291 | "c/Lib.java": {}, |
| 2292 | "d/Android.bp": []byte(lib_bp_b), |
| 2293 | "d/Lib.java": {}, |
| 2294 | }, |
| 2295 | ), |
| 2296 | android.FixtureMergeEnv( |
| 2297 | map[string]string{ |
| 2298 | "DISABLE_STUB_VALIDATION": "true", |
| 2299 | }, |
| 2300 | ), |
| 2301 | ).RunTestWithBp(t, ` |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2302 | java_api_library { |
| 2303 | name: "bar1", |
| 2304 | api_surface: "public", |
| 2305 | api_contributions: ["foo1"], |
| 2306 | libs: ["lib1"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2307 | stubs_type: "everything", |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2308 | } |
| 2309 | |
| 2310 | java_api_library { |
| 2311 | name: "bar2", |
| 2312 | api_surface: "system", |
| 2313 | api_contributions: ["foo1", "foo2"], |
| 2314 | libs: ["lib1", "lib2", "bar1"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2315 | stubs_type: "everything", |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2316 | } |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2317 | `) |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2318 | |
| 2319 | testcases := []struct { |
| 2320 | moduleName string |
| 2321 | classPathJarNames []string |
| 2322 | }{ |
| 2323 | { |
| 2324 | moduleName: "bar1", |
| 2325 | classPathJarNames: []string{"lib1.jar"}, |
| 2326 | }, |
| 2327 | { |
| 2328 | moduleName: "bar2", |
Jihoon Kang | 25857f5 | 2023-03-01 00:27:32 +0000 | [diff] [blame] | 2329 | classPathJarNames: []string{"lib1.jar", "lib2.jar", "bar1/bar1.jar"}, |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2330 | }, |
| 2331 | } |
| 2332 | for _, c := range testcases { |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 2333 | m := ctx.ModuleForTests(t, c.moduleName, "android_common") |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2334 | javacRules := m.Rule("javac") |
| 2335 | classPathArgs := javacRules.Args["classpath"] |
| 2336 | for _, jarName := range c.classPathJarNames { |
| 2337 | if !strings.Contains(classPathArgs, jarName) { |
| 2338 | t.Errorf("Module output does not contain expected jar %s", jarName) |
| 2339 | } |
| 2340 | } |
| 2341 | } |
| 2342 | } |
| 2343 | |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2344 | func TestJavaApiLibraryStaticLibsLink(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 2345 | t.Parallel() |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2346 | provider_bp_a := ` |
| 2347 | java_api_contribution { |
| 2348 | name: "foo1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2349 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2350 | api_surface: "public", |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2351 | } |
| 2352 | ` |
| 2353 | provider_bp_b := ` |
| 2354 | java_api_contribution { |
| 2355 | name: "foo2", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2356 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2357 | api_surface: "public", |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2358 | } |
| 2359 | ` |
| 2360 | lib_bp_a := ` |
| 2361 | java_library { |
| 2362 | name: "lib1", |
| 2363 | srcs: ["Lib.java"], |
| 2364 | } |
| 2365 | ` |
| 2366 | lib_bp_b := ` |
| 2367 | java_library { |
| 2368 | name: "lib2", |
| 2369 | srcs: ["Lib.java"], |
| 2370 | } |
| 2371 | ` |
| 2372 | |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2373 | ctx := android.GroupFixturePreparers( |
| 2374 | prepareForJavaTest, |
| 2375 | android.FixtureMergeMockFs( |
| 2376 | map[string][]byte{ |
| 2377 | "a/Android.bp": []byte(provider_bp_a), |
| 2378 | "b/Android.bp": []byte(provider_bp_b), |
| 2379 | "c/Android.bp": []byte(lib_bp_a), |
| 2380 | "c/Lib.java": {}, |
| 2381 | "d/Android.bp": []byte(lib_bp_b), |
| 2382 | "d/Lib.java": {}, |
| 2383 | }, |
| 2384 | ), |
| 2385 | android.FixtureMergeEnv( |
| 2386 | map[string]string{ |
| 2387 | "DISABLE_STUB_VALIDATION": "true", |
| 2388 | }, |
| 2389 | ), |
| 2390 | ).RunTestWithBp(t, ` |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2391 | java_api_library { |
| 2392 | name: "bar1", |
| 2393 | api_surface: "public", |
| 2394 | api_contributions: ["foo1"], |
| 2395 | static_libs: ["lib1"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2396 | stubs_type: "everything", |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2397 | } |
| 2398 | |
| 2399 | java_api_library { |
| 2400 | name: "bar2", |
| 2401 | api_surface: "system", |
| 2402 | api_contributions: ["foo1", "foo2"], |
| 2403 | static_libs: ["lib1", "lib2", "bar1"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2404 | stubs_type: "everything", |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2405 | } |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2406 | `) |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2407 | |
| 2408 | testcases := []struct { |
| 2409 | moduleName string |
| 2410 | staticLibJarNames []string |
| 2411 | }{ |
| 2412 | { |
| 2413 | moduleName: "bar1", |
| 2414 | staticLibJarNames: []string{"lib1.jar"}, |
| 2415 | }, |
| 2416 | { |
| 2417 | moduleName: "bar2", |
Jihoon Kang | 25857f5 | 2023-03-01 00:27:32 +0000 | [diff] [blame] | 2418 | staticLibJarNames: []string{"lib1.jar", "lib2.jar", "bar1/bar1.jar"}, |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2419 | }, |
| 2420 | } |
| 2421 | for _, c := range testcases { |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 2422 | m := ctx.ModuleForTests(t, c.moduleName, "android_common") |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2423 | mergeZipsCommand := m.Rule("merge_zips").RuleParams.Command |
| 2424 | for _, jarName := range c.staticLibJarNames { |
| 2425 | if !strings.Contains(mergeZipsCommand, jarName) { |
| 2426 | t.Errorf("merge_zips command does not contain expected jar %s", jarName) |
| 2427 | } |
| 2428 | } |
| 2429 | } |
| 2430 | } |
| 2431 | |
Anton Hansson | 0e73f9e | 2023-09-20 13:39:57 +0000 | [diff] [blame] | 2432 | func TestTransitiveSrcFiles(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 2433 | t.Parallel() |
Anton Hansson | 0e73f9e | 2023-09-20 13:39:57 +0000 | [diff] [blame] | 2434 | ctx, _ := testJava(t, ` |
| 2435 | java_library { |
| 2436 | name: "a", |
| 2437 | srcs: ["a.java"], |
| 2438 | } |
| 2439 | java_library { |
| 2440 | name: "b", |
| 2441 | srcs: ["b.java"], |
| 2442 | } |
| 2443 | java_library { |
| 2444 | name: "c", |
| 2445 | srcs: ["c.java"], |
| 2446 | libs: ["a"], |
| 2447 | static_libs: ["b"], |
| 2448 | } |
| 2449 | `) |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 2450 | c := ctx.ModuleForTests(t, "c", "android_common").Module() |
Yu Liu | 663e450 | 2024-08-12 18:23:59 +0000 | [diff] [blame] | 2451 | javaInfo, _ := android.OtherModuleProvider(ctx, c, JavaInfoProvider) |
Colin Cross | 5a37718 | 2023-12-14 14:46:23 -0800 | [diff] [blame] | 2452 | transitiveSrcFiles := android.Paths(javaInfo.TransitiveSrcFiles.ToList()) |
Anton Hansson | 0e73f9e | 2023-09-20 13:39:57 +0000 | [diff] [blame] | 2453 | android.AssertArrayString(t, "unexpected jar deps", []string{"b.java", "c.java"}, transitiveSrcFiles.Strings()) |
| 2454 | } |
| 2455 | |
Cole Faust | 2168054 | 2022-12-07 18:18:37 -0800 | [diff] [blame] | 2456 | func TestTradefedOptions(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 2457 | t.Parallel() |
Cole Faust | 2168054 | 2022-12-07 18:18:37 -0800 | [diff] [blame] | 2458 | result := PrepareForTestWithJavaBuildComponents.RunTestWithBp(t, ` |
| 2459 | java_test_host { |
| 2460 | name: "foo", |
| 2461 | test_options: { |
| 2462 | tradefed_options: [ |
| 2463 | { |
| 2464 | name: "exclude-path", |
| 2465 | value: "org/apache" |
| 2466 | } |
| 2467 | ] |
| 2468 | } |
| 2469 | } |
| 2470 | `) |
| 2471 | |
| 2472 | buildOS := result.Config.BuildOS.String() |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 2473 | args := result.ModuleForTests(t, "foo", buildOS+"_common"). |
Cole Faust | 2168054 | 2022-12-07 18:18:37 -0800 | [diff] [blame] | 2474 | Output("out/soong/.intermediates/foo/" + buildOS + "_common/foo.config").Args |
| 2475 | expected := proptools.NinjaAndShellEscape("<option name=\"exclude-path\" value=\"org/apache\" />") |
| 2476 | if args["extraConfigs"] != expected { |
| 2477 | t.Errorf("Expected args[\"extraConfigs\"] to equal %q, was %q", expected, args["extraConfigs"]) |
| 2478 | } |
| 2479 | } |
Dan Shi | ec73143 | 2023-05-26 04:21:44 +0000 | [diff] [blame] | 2480 | |
| 2481 | func TestTestRunnerOptions(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 2482 | t.Parallel() |
Dan Shi | ec73143 | 2023-05-26 04:21:44 +0000 | [diff] [blame] | 2483 | result := PrepareForTestWithJavaBuildComponents.RunTestWithBp(t, ` |
| 2484 | java_test_host { |
| 2485 | name: "foo", |
| 2486 | test_options: { |
| 2487 | test_runner_options: [ |
| 2488 | { |
| 2489 | name: "test-timeout", |
| 2490 | value: "10m" |
| 2491 | } |
| 2492 | ] |
| 2493 | } |
| 2494 | } |
| 2495 | `) |
| 2496 | |
| 2497 | buildOS := result.Config.BuildOS.String() |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 2498 | args := result.ModuleForTests(t, "foo", buildOS+"_common"). |
Dan Shi | ec73143 | 2023-05-26 04:21:44 +0000 | [diff] [blame] | 2499 | Output("out/soong/.intermediates/foo/" + buildOS + "_common/foo.config").Args |
| 2500 | expected := proptools.NinjaAndShellEscape("<option name=\"test-timeout\" value=\"10m\" />\\n ") |
| 2501 | if args["extraTestRunnerConfigs"] != expected { |
| 2502 | t.Errorf("Expected args[\"extraTestRunnerConfigs\"] to equal %q, was %q", expected, args["extraTestRunnerConfigs"]) |
| 2503 | } |
| 2504 | } |
Jihoon Kang | 381c2fa | 2023-06-01 22:17:32 +0000 | [diff] [blame] | 2505 | |
Jihoon Kang | 1bfb6f2 | 2023-07-01 00:13:47 +0000 | [diff] [blame] | 2506 | func TestJavaLibraryWithResourcesStem(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 2507 | t.Parallel() |
Jihoon Kang | 1bfb6f2 | 2023-07-01 00:13:47 +0000 | [diff] [blame] | 2508 | ctx, _ := testJavaWithFS(t, ` |
| 2509 | java_library { |
| 2510 | name: "foo", |
| 2511 | java_resource_dirs: ["test-jar"], |
| 2512 | stem: "test", |
| 2513 | } |
| 2514 | `, |
| 2515 | map[string][]byte{ |
| 2516 | "test-jar/test/resource.txt": nil, |
| 2517 | }) |
| 2518 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 2519 | m := ctx.ModuleForTests(t, "foo", "android_common") |
Jihoon Kang | 1bfb6f2 | 2023-07-01 00:13:47 +0000 | [diff] [blame] | 2520 | outputs := fmt.Sprint(m.AllOutputs()) |
| 2521 | if !strings.Contains(outputs, "test.jar") { |
| 2522 | t.Errorf("Module output does not contain expected jar %s", "test.jar") |
| 2523 | } |
| 2524 | } |
Mark White | a15790a | 2023-08-22 21:28:11 +0000 | [diff] [blame] | 2525 | |
| 2526 | func TestHeadersOnly(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 2527 | t.Parallel() |
Mark White | a15790a | 2023-08-22 21:28:11 +0000 | [diff] [blame] | 2528 | ctx, _ := testJava(t, ` |
| 2529 | java_library { |
| 2530 | name: "foo", |
| 2531 | srcs: ["a.java"], |
| 2532 | headers_only: true, |
| 2533 | } |
| 2534 | `) |
| 2535 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 2536 | turbine := ctx.ModuleForTests(t, "foo", "android_common").Rule("turbine") |
Mark White | a15790a | 2023-08-22 21:28:11 +0000 | [diff] [blame] | 2537 | if len(turbine.Inputs) != 1 || turbine.Inputs[0].String() != "a.java" { |
| 2538 | t.Errorf(`foo inputs %v != ["a.java"]`, turbine.Inputs) |
| 2539 | } |
| 2540 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 2541 | javac := ctx.ModuleForTests(t, "foo", "android_common").MaybeRule("javac") |
Mark White | a15790a | 2023-08-22 21:28:11 +0000 | [diff] [blame] | 2542 | android.AssertDeepEquals(t, "javac rule", nil, javac.Rule) |
| 2543 | } |
Jihoon Kang | fdf3236 | 2023-09-12 00:36:43 +0000 | [diff] [blame] | 2544 | |
| 2545 | func TestJavaApiContributionImport(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 2546 | t.Parallel() |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2547 | ctx := android.GroupFixturePreparers( |
| 2548 | prepareForJavaTest, |
| 2549 | android.FixtureMergeEnv( |
| 2550 | map[string]string{ |
| 2551 | "DISABLE_STUB_VALIDATION": "true", |
| 2552 | }, |
| 2553 | ), |
| 2554 | ).RunTestWithBp(t, ` |
Jihoon Kang | fdf3236 | 2023-09-12 00:36:43 +0000 | [diff] [blame] | 2555 | java_api_library { |
| 2556 | name: "foo", |
| 2557 | api_contributions: ["bar"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2558 | stubs_type: "everything", |
Jihoon Kang | fdf3236 | 2023-09-12 00:36:43 +0000 | [diff] [blame] | 2559 | } |
| 2560 | java_api_contribution_import { |
| 2561 | name: "bar", |
| 2562 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2563 | api_surface: "public", |
Jihoon Kang | fdf3236 | 2023-09-12 00:36:43 +0000 | [diff] [blame] | 2564 | } |
| 2565 | `) |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 2566 | m := ctx.ModuleForTests(t, "foo", "android_common") |
Jihoon Kang | fdf3236 | 2023-09-12 00:36:43 +0000 | [diff] [blame] | 2567 | manifest := m.Output("metalava.sbox.textproto") |
Colin Cross | f61d03d | 2023-11-02 16:56:39 -0700 | [diff] [blame] | 2568 | sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx.TestContext, manifest) |
Jihoon Kang | fdf3236 | 2023-09-12 00:36:43 +0000 | [diff] [blame] | 2569 | manifestCommand := sboxProto.Commands[0].GetCommand() |
| 2570 | sourceFilesFlag := "--source-files current.txt" |
| 2571 | android.AssertStringDoesContain(t, "source text files not present", manifestCommand, sourceFilesFlag) |
| 2572 | } |
Jihoon Kang | a96a7b1 | 2023-09-20 23:43:32 +0000 | [diff] [blame] | 2573 | |
| 2574 | func TestJavaApiLibraryApiFilesSorting(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 2575 | t.Parallel() |
Jihoon Kang | a96a7b1 | 2023-09-20 23:43:32 +0000 | [diff] [blame] | 2576 | ctx, _ := testJava(t, ` |
| 2577 | java_api_library { |
| 2578 | name: "foo", |
| 2579 | api_contributions: [ |
| 2580 | "system-server-api-stubs-docs-non-updatable.api.contribution", |
| 2581 | "test-api-stubs-docs-non-updatable.api.contribution", |
| 2582 | "system-api-stubs-docs-non-updatable.api.contribution", |
| 2583 | "module-lib-api-stubs-docs-non-updatable.api.contribution", |
| 2584 | "api-stubs-docs-non-updatable.api.contribution", |
| 2585 | ], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2586 | stubs_type: "everything", |
Jihoon Kang | a96a7b1 | 2023-09-20 23:43:32 +0000 | [diff] [blame] | 2587 | } |
| 2588 | `) |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 2589 | m := ctx.ModuleForTests(t, "foo", "android_common") |
Jihoon Kang | a96a7b1 | 2023-09-20 23:43:32 +0000 | [diff] [blame] | 2590 | manifest := m.Output("metalava.sbox.textproto") |
Colin Cross | f61d03d | 2023-11-02 16:56:39 -0700 | [diff] [blame] | 2591 | sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx, manifest) |
Jihoon Kang | a96a7b1 | 2023-09-20 23:43:32 +0000 | [diff] [blame] | 2592 | manifestCommand := sboxProto.Commands[0].GetCommand() |
| 2593 | |
| 2594 | // Api files are sorted from the narrowest api scope to the widest api scope. |
| 2595 | // test api and module lib api surface do not have subset/superset relationship, |
| 2596 | // but they will never be passed as inputs at the same time. |
| 2597 | sourceFilesFlag := "--source-files default/java/api/current.txt " + |
| 2598 | "default/java/api/system-current.txt default/java/api/test-current.txt " + |
| 2599 | "default/java/api/module-lib-current.txt default/java/api/system-server-current.txt" |
| 2600 | android.AssertStringDoesContain(t, "source text files not in api scope order", manifestCommand, sourceFilesFlag) |
| 2601 | } |
Jihoon Kang | 4ec2487 | 2023-10-05 17:26:09 +0000 | [diff] [blame] | 2602 | |
| 2603 | func TestSdkLibraryProvidesSystemModulesToApiLibrary(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 2604 | t.Parallel() |
Jihoon Kang | 4ec2487 | 2023-10-05 17:26:09 +0000 | [diff] [blame] | 2605 | result := android.GroupFixturePreparers( |
| 2606 | prepareForJavaTest, |
| 2607 | PrepareForTestWithJavaSdkLibraryFiles, |
| 2608 | FixtureWithLastReleaseApis("foo"), |
Jihoon Kang | 4ec2487 | 2023-10-05 17:26:09 +0000 | [diff] [blame] | 2609 | android.FixtureMergeMockFs( |
| 2610 | map[string][]byte{ |
| 2611 | "A.java": nil, |
| 2612 | }, |
| 2613 | ), |
| 2614 | ).RunTestWithBp(t, ` |
| 2615 | java_library { |
| 2616 | name: "bar", |
| 2617 | srcs: ["a.java"], |
| 2618 | } |
| 2619 | java_system_modules { |
| 2620 | name: "baz", |
| 2621 | libs: ["bar"], |
| 2622 | } |
| 2623 | java_sdk_library { |
| 2624 | name: "foo", |
| 2625 | srcs: ["A.java"], |
| 2626 | system_modules: "baz", |
| 2627 | } |
| 2628 | `) |
Jihoon Kang | b0f4c02 | 2024-08-06 00:15:25 +0000 | [diff] [blame] | 2629 | |
| 2630 | checkBootClasspathForLibWithSystemModule(t, result.TestContext, apiScopePublic.apiLibraryModuleName("foo"), "/bar.jar") |
Jihoon Kang | 4ec2487 | 2023-10-05 17:26:09 +0000 | [diff] [blame] | 2631 | } |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2632 | |
| 2633 | func TestApiLibraryDroidstubsDependency(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 2634 | t.Parallel() |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2635 | result := android.GroupFixturePreparers( |
| 2636 | prepareForJavaTest, |
| 2637 | PrepareForTestWithJavaSdkLibraryFiles, |
| 2638 | FixtureWithLastReleaseApis("foo"), |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2639 | android.FixtureMergeMockFs( |
| 2640 | map[string][]byte{ |
| 2641 | "A.java": nil, |
| 2642 | }, |
| 2643 | ), |
| 2644 | ).RunTestWithBp(t, ` |
| 2645 | java_api_library { |
| 2646 | name: "foo", |
| 2647 | api_contributions: [ |
| 2648 | "api-stubs-docs-non-updatable.api.contribution", |
| 2649 | ], |
| 2650 | enable_validation: true, |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2651 | stubs_type: "everything", |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2652 | } |
| 2653 | java_api_library { |
| 2654 | name: "bar", |
| 2655 | api_contributions: [ |
| 2656 | "api-stubs-docs-non-updatable.api.contribution", |
| 2657 | ], |
| 2658 | enable_validation: false, |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2659 | stubs_type: "everything", |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2660 | } |
| 2661 | `) |
| 2662 | |
Jihoon Kang | 3c89f04 | 2023-12-19 02:40:22 +0000 | [diff] [blame] | 2663 | currentApiTimestampPath := "api-stubs-docs-non-updatable/android_common/everything/check_current_api.timestamp" |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 2664 | foo := result.ModuleForTests(t, "foo", "android_common").Module().(*ApiLibrary) |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2665 | fooValidationPathsString := strings.Join(foo.validationPaths.Strings(), " ") |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 2666 | bar := result.ModuleForTests(t, "bar", "android_common").Module().(*ApiLibrary) |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2667 | barValidationPathsString := strings.Join(bar.validationPaths.Strings(), " ") |
| 2668 | android.AssertStringDoesContain(t, |
| 2669 | "Module expected to have validation", |
| 2670 | fooValidationPathsString, |
| 2671 | currentApiTimestampPath, |
| 2672 | ) |
| 2673 | android.AssertStringDoesNotContain(t, |
| 2674 | "Module expected to not have validation", |
| 2675 | barValidationPathsString, |
| 2676 | currentApiTimestampPath, |
| 2677 | ) |
| 2678 | } |
Jihoon Kang | 1975d3e | 2023-10-16 23:24:11 +0000 | [diff] [blame] | 2679 | |
| 2680 | func TestDisableFromTextStubForCoverageBuild(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 2681 | t.Parallel() |
Jihoon Kang | 1975d3e | 2023-10-16 23:24:11 +0000 | [diff] [blame] | 2682 | result := android.GroupFixturePreparers( |
| 2683 | prepareForJavaTest, |
| 2684 | PrepareForTestWithJavaSdkLibraryFiles, |
| 2685 | PrepareForTestWithJacocoInstrumentation, |
| 2686 | FixtureWithLastReleaseApis("foo"), |
| 2687 | android.FixtureModifyConfig(func(config android.Config) { |
Jihoon Kang | 1975d3e | 2023-10-16 23:24:11 +0000 | [diff] [blame] | 2688 | config.SetBuildFromTextStub(true) |
| 2689 | }), |
| 2690 | android.FixtureModifyEnv(func(env map[string]string) { |
| 2691 | env["EMMA_INSTRUMENT"] = "true" |
| 2692 | }), |
| 2693 | ).RunTestWithBp(t, ` |
| 2694 | java_sdk_library { |
| 2695 | name: "foo", |
| 2696 | srcs: ["A.java"], |
| 2697 | } |
| 2698 | `) |
| 2699 | android.AssertBoolEquals(t, "stub module expected to depend on from-source stub", |
| 2700 | true, CheckModuleHasDependency(t, result.TestContext, |
| 2701 | apiScopePublic.stubsLibraryModuleName("foo"), "android_common", |
Jihoon Kang | 2261a82 | 2024-09-12 00:01:54 +0000 | [diff] [blame] | 2702 | apiScopePublic.sourceStubsLibraryModuleName("foo"))) |
Jihoon Kang | 1975d3e | 2023-10-16 23:24:11 +0000 | [diff] [blame] | 2703 | |
| 2704 | android.AssertBoolEquals(t, "stub module expected to not depend on from-text stub", |
| 2705 | false, CheckModuleHasDependency(t, result.TestContext, |
| 2706 | apiScopePublic.stubsLibraryModuleName("foo"), "android_common", |
| 2707 | apiScopePublic.apiLibraryModuleName("foo"))) |
| 2708 | } |
Spandan Das | 3cf0463 | 2024-01-19 00:22:22 +0000 | [diff] [blame] | 2709 | |
| 2710 | func TestMultiplePrebuilts(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 2711 | t.Parallel() |
Spandan Das | 3cf0463 | 2024-01-19 00:22:22 +0000 | [diff] [blame] | 2712 | bp := ` |
| 2713 | // an rdep |
| 2714 | java_library { |
| 2715 | name: "foo", |
| 2716 | libs: ["bar"], |
| 2717 | } |
| 2718 | |
| 2719 | // multiple variations of dep |
| 2720 | // source |
| 2721 | java_library { |
| 2722 | name: "bar", |
| 2723 | srcs: ["bar.java"], |
| 2724 | } |
| 2725 | // prebuilt "v1" |
| 2726 | java_import { |
| 2727 | name: "bar", |
| 2728 | jars: ["bar.jar"], |
| 2729 | } |
| 2730 | // prebuilt "v2" |
| 2731 | java_import { |
| 2732 | name: "bar.v2", |
| 2733 | source_module_name: "bar", |
| 2734 | jars: ["bar.v1.jar"], |
| 2735 | } |
| 2736 | |
| 2737 | // selectors |
| 2738 | apex_contributions { |
| 2739 | name: "myapex_contributions", |
| 2740 | contents: ["%v"], |
| 2741 | } |
| 2742 | ` |
| 2743 | hasDep := func(ctx *android.TestResult, m android.Module, wantDep android.Module) bool { |
| 2744 | t.Helper() |
| 2745 | var found bool |
| 2746 | ctx.VisitDirectDeps(m, func(dep blueprint.Module) { |
| 2747 | if dep == wantDep { |
| 2748 | found = true |
| 2749 | } |
| 2750 | }) |
| 2751 | return found |
| 2752 | } |
| 2753 | |
| 2754 | hasFileWithStem := func(m android.TestingModule, stem string) bool { |
| 2755 | t.Helper() |
| 2756 | for _, o := range m.AllOutputs() { |
| 2757 | _, file := filepath.Split(o) |
| 2758 | if file == stem+".jar" { |
| 2759 | return true |
| 2760 | } |
| 2761 | } |
| 2762 | return false |
| 2763 | } |
| 2764 | |
| 2765 | testCases := []struct { |
| 2766 | desc string |
| 2767 | selectedDependencyName string |
| 2768 | expectedDependencyName string |
| 2769 | }{ |
| 2770 | { |
| 2771 | desc: "Source library is selected using apex_contributions", |
| 2772 | selectedDependencyName: "bar", |
| 2773 | expectedDependencyName: "bar", |
| 2774 | }, |
| 2775 | { |
| 2776 | desc: "Prebuilt library v1 is selected using apex_contributions", |
| 2777 | selectedDependencyName: "prebuilt_bar", |
| 2778 | expectedDependencyName: "prebuilt_bar", |
| 2779 | }, |
| 2780 | { |
| 2781 | desc: "Prebuilt library v2 is selected using apex_contributions", |
| 2782 | selectedDependencyName: "prebuilt_bar.v2", |
| 2783 | expectedDependencyName: "prebuilt_bar.v2", |
| 2784 | }, |
| 2785 | } |
| 2786 | |
| 2787 | for _, tc := range testCases { |
| 2788 | ctx := android.GroupFixturePreparers( |
| 2789 | prepareForJavaTest, |
Colin Cross | a66b463 | 2024-08-08 15:50:47 -0700 | [diff] [blame] | 2790 | android.PrepareForTestWithBuildFlag("RELEASE_APEX_CONTRIBUTIONS_ADSERVICES", "myapex_contributions"), |
Spandan Das | 3cf0463 | 2024-01-19 00:22:22 +0000 | [diff] [blame] | 2791 | ).RunTestWithBp(t, fmt.Sprintf(bp, tc.selectedDependencyName)) |
| 2792 | |
| 2793 | // check that rdep gets the correct variation of dep |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 2794 | foo := ctx.ModuleForTests(t, "foo", "android_common") |
| 2795 | expectedDependency := ctx.ModuleForTests(t, tc.expectedDependencyName, "android_common") |
Spandan Das | 3cf0463 | 2024-01-19 00:22:22 +0000 | [diff] [blame] | 2796 | android.AssertBoolEquals(t, fmt.Sprintf("expected dependency from %s to %s\n", foo.Module().Name(), tc.expectedDependencyName), true, hasDep(ctx, foo.Module(), expectedDependency.Module())) |
| 2797 | |
| 2798 | // check that output file of dep is always bar.jar |
| 2799 | // The filename should be agnostic to source/prebuilt/prebuilt_version |
| 2800 | android.AssertBoolEquals(t, fmt.Sprintf("could not find bar.jar in outputs of %s. All Outputs %v\n", tc.expectedDependencyName, expectedDependency.AllOutputs()), true, hasFileWithStem(expectedDependency, "bar")) |
| 2801 | |
| 2802 | // check LOCAL_MODULE of the selected module name |
| 2803 | // the prebuilt should have the same LOCAL_MODULE when exported to make |
| 2804 | entries := android.AndroidMkEntriesForTest(t, ctx.TestContext, expectedDependency.Module())[0] |
| 2805 | android.AssertStringEquals(t, "unexpected LOCAL_MODULE", "bar", entries.EntryMap["LOCAL_MODULE"][0]) |
| 2806 | } |
| 2807 | } |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2808 | |
Spandan Das | e4c911e | 2024-01-19 00:22:22 +0000 | [diff] [blame] | 2809 | func TestMultiplePlatformCompatConfigPrebuilts(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 2810 | t.Parallel() |
Spandan Das | e4c911e | 2024-01-19 00:22:22 +0000 | [diff] [blame] | 2811 | bp := ` |
| 2812 | // multiple variations of platform_compat_config |
| 2813 | // source |
| 2814 | platform_compat_config { |
| 2815 | name: "myconfig", |
| 2816 | } |
| 2817 | // prebuilt "v1" |
| 2818 | prebuilt_platform_compat_config { |
| 2819 | name: "myconfig", |
| 2820 | metadata: "myconfig.xml", |
| 2821 | } |
| 2822 | // prebuilt "v2" |
| 2823 | prebuilt_platform_compat_config { |
| 2824 | name: "myconfig.v2", |
| 2825 | source_module_name: "myconfig", // without source_module_name, the singleton will merge two .xml files |
| 2826 | metadata: "myconfig.v2.xml", |
| 2827 | } |
| 2828 | |
| 2829 | // selectors |
| 2830 | apex_contributions { |
| 2831 | name: "myapex_contributions", |
| 2832 | contents: ["%v"], |
| 2833 | } |
| 2834 | ` |
| 2835 | testCases := []struct { |
| 2836 | desc string |
| 2837 | selectedDependencyName string |
| 2838 | expectedPlatformCompatConfigXml string |
| 2839 | }{ |
| 2840 | { |
| 2841 | desc: "Source platform_compat_config is selected using apex_contributions", |
| 2842 | selectedDependencyName: "myconfig", |
| 2843 | expectedPlatformCompatConfigXml: "out/soong/.intermediates/myconfig/android_common/myconfig_meta.xml", |
| 2844 | }, |
| 2845 | { |
| 2846 | desc: "Prebuilt platform_compat_config v1 is selected using apex_contributions", |
| 2847 | selectedDependencyName: "prebuilt_myconfig", |
| 2848 | expectedPlatformCompatConfigXml: "myconfig.xml", |
| 2849 | }, |
| 2850 | { |
| 2851 | desc: "Prebuilt platform_compat_config v2 is selected using apex_contributions", |
| 2852 | selectedDependencyName: "prebuilt_myconfig.v2", |
| 2853 | expectedPlatformCompatConfigXml: "myconfig.v2.xml", |
| 2854 | }, |
| 2855 | } |
| 2856 | |
| 2857 | for _, tc := range testCases { |
| 2858 | ctx := android.GroupFixturePreparers( |
| 2859 | prepareForJavaTest, |
| 2860 | PrepareForTestWithPlatformCompatConfig, |
Colin Cross | a66b463 | 2024-08-08 15:50:47 -0700 | [diff] [blame] | 2861 | android.PrepareForTestWithBuildFlag("RELEASE_APEX_CONTRIBUTIONS_ADSERVICES", "myapex_contributions"), |
Spandan Das | e4c911e | 2024-01-19 00:22:22 +0000 | [diff] [blame] | 2862 | ).RunTestWithBp(t, fmt.Sprintf(bp, tc.selectedDependencyName)) |
| 2863 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 2864 | mergedGlobalConfig := ctx.SingletonForTests(t, "platform_compat_config_singleton").Output("compat_config/merged_compat_config.xml") |
Spandan Das | e4c911e | 2024-01-19 00:22:22 +0000 | [diff] [blame] | 2865 | android.AssertIntEquals(t, "The merged compat config file should only have a single dependency", 1, len(mergedGlobalConfig.Implicits)) |
| 2866 | android.AssertStringEquals(t, "The merged compat config file is missing the appropriate platform compat config", mergedGlobalConfig.Implicits[0].String(), tc.expectedPlatformCompatConfigXml) |
| 2867 | } |
| 2868 | } |
| 2869 | |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2870 | func TestApiLibraryAconfigDeclarations(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 2871 | t.Parallel() |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2872 | result := android.GroupFixturePreparers( |
| 2873 | prepareForJavaTest, |
| 2874 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 2875 | }), |
| 2876 | android.FixtureMergeMockFs(map[string][]byte{ |
| 2877 | "a/A.java": nil, |
| 2878 | "a/current.txt": nil, |
| 2879 | "a/removed.txt": nil, |
| 2880 | }), |
| 2881 | ).RunTestWithBp(t, ` |
| 2882 | aconfig_declarations { |
| 2883 | name: "bar", |
| 2884 | package: "com.example.package", |
Yu Liu | 315a53c | 2024-04-24 16:41:57 +0000 | [diff] [blame] | 2885 | container: "com.android.foo", |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2886 | srcs: [ |
| 2887 | "bar.aconfig", |
| 2888 | ], |
| 2889 | } |
| 2890 | java_api_contribution { |
| 2891 | name: "baz", |
| 2892 | api_file: "a/current.txt", |
| 2893 | api_surface: "public", |
| 2894 | } |
| 2895 | java_api_library { |
| 2896 | name: "foo", |
| 2897 | api_surface: "public", |
| 2898 | api_contributions: [ |
| 2899 | "baz", |
| 2900 | ], |
| 2901 | aconfig_declarations: [ |
| 2902 | "bar", |
| 2903 | ], |
| 2904 | stubs_type: "exportable", |
| 2905 | enable_validation: false, |
| 2906 | } |
| 2907 | `) |
| 2908 | |
| 2909 | // Check if java_api_library depends on aconfig_declarations |
| 2910 | android.AssertBoolEquals(t, "foo expected to depend on bar", |
| 2911 | CheckModuleHasDependency(t, result.TestContext, "foo", "android_common", "bar"), true) |
| 2912 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 2913 | m := result.ModuleForTests(t, "foo", "android_common") |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2914 | android.AssertStringDoesContain(t, "foo generates revert annotations file", |
Paul Duffin | 50243ae | 2025-03-03 19:10:27 +0000 | [diff] [blame^] | 2915 | strings.Join(m.AllOutputs(), ""), "flags-config-exportable.xml") |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2916 | |
| 2917 | // revert-annotations.txt passed to exportable stubs generation metalava command |
| 2918 | manifest := m.Output("metalava.sbox.textproto") |
| 2919 | cmdline := String(android.RuleBuilderSboxProtoForTests(t, result.TestContext, manifest).Commands[0].Command) |
Paul Duffin | 50243ae | 2025-03-03 19:10:27 +0000 | [diff] [blame^] | 2920 | android.AssertStringDoesContain(t, "flagged api hide command not included", cmdline, "flags-config-exportable.xml") |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2921 | } |
yangbill | 2af0b6e | 2024-03-15 09:29:29 +0000 | [diff] [blame] | 2922 | |
Ronald Braunstein | cdc66f4 | 2024-04-12 11:23:19 -0700 | [diff] [blame] | 2923 | func TestTestOnly(t *testing.T) { |
| 2924 | t.Parallel() |
| 2925 | ctx := android.GroupFixturePreparers( |
| 2926 | prepareForJavaTest, |
| 2927 | ).RunTestWithBp(t, ` |
| 2928 | // These should be test-only |
| 2929 | java_library { |
| 2930 | name: "lib1-test-only", |
| 2931 | srcs: ["a.java"], |
| 2932 | test_only: true, |
| 2933 | } |
| 2934 | java_test { |
| 2935 | name: "java-test", |
| 2936 | } |
| 2937 | java_test_host { |
| 2938 | name: "java-test-host", |
| 2939 | } |
| 2940 | java_test_helper_library { |
| 2941 | name: "helper-library", |
| 2942 | } |
| 2943 | java_binary { |
| 2944 | name: "java-data-binary", |
| 2945 | srcs: ["foo.java"], |
| 2946 | main_class: "foo.bar.jb", |
| 2947 | test_only: true, |
| 2948 | } |
| 2949 | |
| 2950 | // These are NOT |
| 2951 | java_library { |
| 2952 | name: "lib2-app", |
| 2953 | srcs: ["b.java"], |
| 2954 | } |
| 2955 | java_import { |
| 2956 | name: "bar", |
| 2957 | jars: ["bar.jar"], |
| 2958 | } |
| 2959 | java_binary { |
| 2960 | name: "java-binary", |
| 2961 | srcs: ["foo.java"], |
| 2962 | main_class: "foo.bar.jb", |
| 2963 | } |
| 2964 | `) |
| 2965 | |
| 2966 | expectedTestOnlyModules := []string{ |
| 2967 | "lib1-test-only", |
| 2968 | "java-test", |
| 2969 | "java-test-host", |
| 2970 | "helper-library", |
| 2971 | "java-data-binary", |
| 2972 | } |
| 2973 | expectedTopLevelTests := []string{ |
| 2974 | "java-test", |
| 2975 | "java-test-host", |
| 2976 | } |
| 2977 | assertTestOnlyAndTopLevel(t, ctx, expectedTestOnlyModules, expectedTopLevelTests) |
| 2978 | } |
| 2979 | |
| 2980 | // Don't allow setting test-only on things that are always tests or never tests. |
| 2981 | func TestInvalidTestOnlyTargets(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 2982 | t.Parallel() |
Ronald Braunstein | cdc66f4 | 2024-04-12 11:23:19 -0700 | [diff] [blame] | 2983 | testCases := []string{ |
| 2984 | ` java_test { name: "java-test", test_only: true, srcs: ["foo.java"], } `, |
| 2985 | ` java_test_host { name: "java-test-host", test_only: true, srcs: ["foo.java"], } `, |
| 2986 | ` java_test_import { name: "java-test-import", test_only: true, } `, |
| 2987 | ` java_api_library { name: "java-api-library", test_only: true, } `, |
| 2988 | ` java_test_helper_library { name: "test-help-lib", test_only: true, } `, |
| 2989 | ` java_defaults { name: "java-defaults", test_only: true, } `, |
| 2990 | } |
| 2991 | |
| 2992 | for i, bp := range testCases { |
| 2993 | android.GroupFixturePreparers(prepareForJavaTest). |
| 2994 | ExtendWithErrorHandler( |
| 2995 | expectOneError("unrecognized property \"test_only\"", |
| 2996 | fmt.Sprintf("testcase: %d", i))). |
| 2997 | RunTestWithBp(t, bp) |
| 2998 | } |
| 2999 | } |
| 3000 | |
| 3001 | // Expect exactly one that matches 'expected'. |
| 3002 | // Append 'msg' to the Errorf that printed. |
| 3003 | func expectOneError(expected string, msg string) android.FixtureErrorHandler { |
| 3004 | return android.FixtureCustomErrorHandler(func(t *testing.T, result *android.TestResult) { |
| 3005 | t.Helper() |
| 3006 | if len(result.Errs) != 1 { |
| 3007 | t.Errorf("Expected exactly one error, but found: %d when setting test_only on: %s", len(result.Errs), msg) |
| 3008 | return |
| 3009 | } |
| 3010 | actualErrMsg := result.Errs[0].Error() |
| 3011 | if !strings.Contains(actualErrMsg, expected) { |
| 3012 | t.Errorf("Different error than expected. Received: [%v] on %s expected: %s", actualErrMsg, msg, expected) |
| 3013 | } |
| 3014 | }) |
| 3015 | } |
| 3016 | |
yangbill | 2af0b6e | 2024-03-15 09:29:29 +0000 | [diff] [blame] | 3017 | func TestJavaLibHostWithStem(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 3018 | t.Parallel() |
yangbill | 2af0b6e | 2024-03-15 09:29:29 +0000 | [diff] [blame] | 3019 | ctx, _ := testJava(t, ` |
| 3020 | java_library_host { |
| 3021 | name: "foo", |
| 3022 | srcs: ["a.java"], |
| 3023 | stem: "foo-new", |
| 3024 | } |
| 3025 | `) |
| 3026 | |
| 3027 | buildOS := ctx.Config().BuildOS.String() |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 3028 | foo := ctx.ModuleForTests(t, "foo", buildOS+"_common") |
yangbill | 2af0b6e | 2024-03-15 09:29:29 +0000 | [diff] [blame] | 3029 | |
| 3030 | outputs := fmt.Sprint(foo.AllOutputs()) |
| 3031 | if !strings.Contains(outputs, "foo-new.jar") { |
| 3032 | t.Errorf("Module output does not contain expected jar %s", "foo-new.jar") |
| 3033 | } |
| 3034 | } |
| 3035 | |
| 3036 | func TestJavaLibWithStem(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 3037 | t.Parallel() |
yangbill | 2af0b6e | 2024-03-15 09:29:29 +0000 | [diff] [blame] | 3038 | ctx, _ := testJava(t, ` |
| 3039 | java_library { |
| 3040 | name: "foo", |
| 3041 | srcs: ["a.java"], |
| 3042 | stem: "foo-new", |
| 3043 | } |
| 3044 | `) |
| 3045 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 3046 | foo := ctx.ModuleForTests(t, "foo", "android_common") |
yangbill | 2af0b6e | 2024-03-15 09:29:29 +0000 | [diff] [blame] | 3047 | |
| 3048 | outputs := fmt.Sprint(foo.AllOutputs()) |
| 3049 | if !strings.Contains(outputs, "foo-new.jar") { |
| 3050 | t.Errorf("Module output does not contain expected jar %s", "foo-new.jar") |
| 3051 | } |
| 3052 | } |
Colin Cross | 5e87f34 | 2024-04-11 15:28:18 -0700 | [diff] [blame] | 3053 | |
| 3054 | func TestJavaLibraryOutputFilesRel(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 3055 | t.Parallel() |
Colin Cross | 5e87f34 | 2024-04-11 15:28:18 -0700 | [diff] [blame] | 3056 | result := android.GroupFixturePreparers( |
| 3057 | PrepareForTestWithJavaDefaultModules, |
| 3058 | ).RunTestWithBp(t, ` |
| 3059 | java_library { |
| 3060 | name: "foo", |
| 3061 | srcs: ["a.java"], |
| 3062 | } |
| 3063 | |
| 3064 | java_import { |
| 3065 | name: "bar", |
| 3066 | jars: ["bar.aar"], |
| 3067 | |
| 3068 | } |
| 3069 | |
| 3070 | java_import { |
| 3071 | name: "baz", |
| 3072 | jars: ["baz.aar"], |
| 3073 | static_libs: ["bar"], |
| 3074 | } |
| 3075 | `) |
| 3076 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 3077 | foo := result.ModuleForTests(t, "foo", "android_common") |
| 3078 | bar := result.ModuleForTests(t, "bar", "android_common") |
| 3079 | baz := result.ModuleForTests(t, "baz", "android_common") |
Colin Cross | 5e87f34 | 2024-04-11 15:28:18 -0700 | [diff] [blame] | 3080 | |
Yu Liu | 51c2231 | 2024-08-20 23:56:15 +0000 | [diff] [blame] | 3081 | fooOutputPaths := foo.OutputFiles(result.TestContext, t, "") |
| 3082 | barOutputPaths := bar.OutputFiles(result.TestContext, t, "") |
| 3083 | bazOutputPaths := baz.OutputFiles(result.TestContext, t, "") |
Colin Cross | 5e87f34 | 2024-04-11 15:28:18 -0700 | [diff] [blame] | 3084 | |
mrziwang | 9f7b9f4 | 2024-07-10 12:18:06 -0700 | [diff] [blame] | 3085 | android.AssertPathsRelativeToTopEquals(t, "foo output path", |
| 3086 | []string{"out/soong/.intermediates/foo/android_common/javac/foo.jar"}, fooOutputPaths) |
mrziwang | 68786d8 | 2024-07-09 10:41:55 -0700 | [diff] [blame] | 3087 | android.AssertPathsRelativeToTopEquals(t, "bar output path", |
| 3088 | []string{"out/soong/.intermediates/bar/android_common/combined/bar.jar"}, barOutputPaths) |
| 3089 | android.AssertPathsRelativeToTopEquals(t, "baz output path", |
| 3090 | []string{"out/soong/.intermediates/baz/android_common/combined/baz.jar"}, bazOutputPaths) |
Colin Cross | 5e87f34 | 2024-04-11 15:28:18 -0700 | [diff] [blame] | 3091 | |
| 3092 | android.AssertStringEquals(t, "foo relative output path", |
mrziwang | 9f7b9f4 | 2024-07-10 12:18:06 -0700 | [diff] [blame] | 3093 | "foo.jar", fooOutputPaths[0].Rel()) |
Colin Cross | 5e87f34 | 2024-04-11 15:28:18 -0700 | [diff] [blame] | 3094 | android.AssertStringEquals(t, "bar relative output path", |
mrziwang | 68786d8 | 2024-07-09 10:41:55 -0700 | [diff] [blame] | 3095 | "bar.jar", barOutputPaths[0].Rel()) |
Colin Cross | 5e87f34 | 2024-04-11 15:28:18 -0700 | [diff] [blame] | 3096 | android.AssertStringEquals(t, "baz relative output path", |
mrziwang | 68786d8 | 2024-07-09 10:41:55 -0700 | [diff] [blame] | 3097 | "baz.jar", bazOutputPaths[0].Rel()) |
Colin Cross | 5e87f34 | 2024-04-11 15:28:18 -0700 | [diff] [blame] | 3098 | } |
Ronald Braunstein | cdc66f4 | 2024-04-12 11:23:19 -0700 | [diff] [blame] | 3099 | |
Colin Cross | b323c91 | 2024-09-24 15:21:00 -0700 | [diff] [blame] | 3100 | func TestCoverage(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 3101 | t.Parallel() |
Colin Cross | b323c91 | 2024-09-24 15:21:00 -0700 | [diff] [blame] | 3102 | result := android.GroupFixturePreparers( |
| 3103 | PrepareForTestWithJavaDefaultModules, |
| 3104 | prepareForTestWithFrameworkJacocoInstrumentation, |
Colin Cross | b323c91 | 2024-09-24 15:21:00 -0700 | [diff] [blame] | 3105 | ).RunTestWithBp(t, ` |
| 3106 | android_app { |
| 3107 | name: "foo", |
| 3108 | srcs: ["foo.java"], |
| 3109 | static_libs: ["android.car"], |
| 3110 | platform_apis: true, |
| 3111 | } |
| 3112 | |
| 3113 | // A library in InstrumentFrameworkModules |
| 3114 | java_library { |
| 3115 | name: "android.car", |
| 3116 | srcs: ["android.car.java"], |
Colin Cross | 4169898 | 2024-11-13 11:31:31 -0800 | [diff] [blame] | 3117 | installable: true, |
Colin Cross | b323c91 | 2024-09-24 15:21:00 -0700 | [diff] [blame] | 3118 | } |
| 3119 | `) |
| 3120 | |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 3121 | foo := result.ModuleForTests(t, "foo", "android_common") |
| 3122 | androidCar := result.ModuleForTests(t, "android.car", "android_common") |
Colin Cross | b323c91 | 2024-09-24 15:21:00 -0700 | [diff] [blame] | 3123 | |
| 3124 | fooJacoco := foo.Rule("jacoco") |
| 3125 | fooCombine := foo.Description("for javac") |
| 3126 | |
| 3127 | androidCarJacoco := androidCar.Rule("jacoco") |
| 3128 | androidCarJavac := androidCar.Rule("javac") |
| 3129 | |
| 3130 | android.AssertStringEquals(t, "foo instrumentation rule inputs", fooJacoco.Input.String(), fooCombine.Output.String()) |
| 3131 | android.AssertStringEquals(t, "android.car instrumentation rule inputs", androidCarJacoco.Input.String(), androidCarJavac.Output.String()) |
| 3132 | |
| 3133 | // The input to instrumentation for the `foo` app contains the non-instrumented android.car classes. |
| 3134 | android.AssertStringListContains(t, "foo combined inputs", fooCombine.Inputs.Strings(), androidCarJavac.Output.String()) |
| 3135 | android.AssertStringListDoesNotContain(t, "foo combined inputs", fooCombine.Inputs.Strings(), androidCarJacoco.Output.String()) |
| 3136 | } |
| 3137 | |
Ronald Braunstein | cdc66f4 | 2024-04-12 11:23:19 -0700 | [diff] [blame] | 3138 | func assertTestOnlyAndTopLevel(t *testing.T, ctx *android.TestResult, expectedTestOnly []string, expectedTopLevel []string) { |
| 3139 | t.Helper() |
| 3140 | actualTrueModules := []string{} |
| 3141 | actualTopLevelTests := []string{} |
| 3142 | addActuals := func(m blueprint.Module, key blueprint.ProviderKey[android.TestModuleInformation]) { |
| 3143 | if provider, ok := android.OtherModuleProvider(ctx.TestContext.OtherModuleProviderAdaptor(), m, key); ok { |
| 3144 | if provider.TestOnly { |
| 3145 | actualTrueModules = append(actualTrueModules, m.Name()) |
| 3146 | } |
| 3147 | if provider.TopLevelTarget { |
| 3148 | actualTopLevelTests = append(actualTopLevelTests, m.Name()) |
| 3149 | } |
| 3150 | } |
| 3151 | } |
| 3152 | |
| 3153 | ctx.VisitAllModules(func(m blueprint.Module) { |
| 3154 | addActuals(m, android.TestOnlyProviderKey) |
| 3155 | |
| 3156 | }) |
| 3157 | |
| 3158 | notEqual, left, right := android.ListSetDifference(expectedTestOnly, actualTrueModules) |
| 3159 | if notEqual { |
| 3160 | t.Errorf("test-only: Expected but not found: %v, Found but not expected: %v", left, right) |
| 3161 | } |
| 3162 | |
| 3163 | notEqual, left, right = android.ListSetDifference(expectedTopLevel, actualTopLevelTests) |
| 3164 | if notEqual { |
| 3165 | t.Errorf("top-level: Expected but not found: %v, Found but not expected: %v", left, right) |
| 3166 | } |
| 3167 | } |
Spandan Das | 77e27d4 | 2024-09-26 23:53:58 +0000 | [diff] [blame] | 3168 | |
Spandan Das | e42c5d9 | 2024-10-03 22:39:52 +0000 | [diff] [blame] | 3169 | // Test that a dependency edge is created to the matching variant of a native library listed in `jni_libs` of java_binary |
Spandan Das | 77e27d4 | 2024-09-26 23:53:58 +0000 | [diff] [blame] | 3170 | func TestNativeRequiredDepOfJavaBinary(t *testing.T) { |
Colin Cross | 844cb6a | 2025-01-29 15:53:21 -0800 | [diff] [blame] | 3171 | t.Parallel() |
Spandan Das | 77e27d4 | 2024-09-26 23:53:58 +0000 | [diff] [blame] | 3172 | findDepsOfModule := func(ctx *android.TestContext, module android.Module, depName string) []blueprint.Module { |
| 3173 | var ret []blueprint.Module |
| 3174 | ctx.VisitDirectDeps(module, func(dep blueprint.Module) { |
| 3175 | if dep.Name() == depName { |
| 3176 | ret = append(ret, dep) |
| 3177 | } |
| 3178 | }) |
| 3179 | return ret |
| 3180 | } |
| 3181 | |
| 3182 | bp := cc.GatherRequiredDepsForTest(android.Android) + ` |
| 3183 | java_binary { |
| 3184 | name: "myjavabin", |
| 3185 | main_class: "com.android.MyJava", |
Spandan Das | e42c5d9 | 2024-10-03 22:39:52 +0000 | [diff] [blame] | 3186 | jni_libs: ["mynativelib"], |
Spandan Das | 77e27d4 | 2024-09-26 23:53:58 +0000 | [diff] [blame] | 3187 | } |
| 3188 | cc_library_shared { |
| 3189 | name: "mynativelib", |
| 3190 | } |
| 3191 | ` |
| 3192 | res, _ := testJava(t, bp) |
Colin Cross | 90607e9 | 2025-02-11 14:58:07 -0800 | [diff] [blame] | 3193 | deps := findDepsOfModule(res, res.ModuleForTests(t, "myjavabin", "android_common").Module(), "mynativelib") |
Cole Faust | b9c67e2 | 2024-10-08 16:39:56 -0700 | [diff] [blame] | 3194 | android.AssertIntEquals(t, "Create a dep on the first variant", 1, len(deps)) |
Spandan Das | 77e27d4 | 2024-09-26 23:53:58 +0000 | [diff] [blame] | 3195 | } |