blob: d4b056bc931f25d0b81de590fcffe61ad17e18f3 [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Paul Duffin1a393322020-11-18 16:36:47 +000018 "fmt"
Colin Cross72bb3632017-07-13 16:23:21 -070019 "os"
20 "path/filepath"
Colin Crossc0806172019-06-14 18:51:47 -070021 "reflect"
Colin Crossf8d9c492021-01-26 11:01:43 -080022 "runtime"
Nan Zhang61eaedb2017-11-02 13:28:15 -070023 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070024 "strings"
25 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070026
Jeongik Cha28df2572019-11-11 10:46:36 +090027 "github.com/google/blueprint/proptools"
28
Jihoon Kang84b25892023-12-01 22:01:06 +000029 "android/soong/aconfig"
Colin Crossa4f08812018-10-02 22:03:40 -070030 "android/soong/android"
31 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080032 "android/soong/dexpreopt"
Colin Cross1661aff2021-03-12 17:56:51 -080033 "android/soong/genrule"
Colin Cross72bb3632017-07-13 16:23:21 -070034)
35
Paul Duffin70d3bee2021-03-21 11:26:05 +000036// Legacy preparer used for running tests within the java package.
37//
38// This includes everything that was needed to run any test in the java package prior to the
39// introduction of the test fixtures. Tests that are being converted to use fixtures directly
40// rather than through the testJava...() methods should avoid using this and instead use the
41// various preparers directly, using android.GroupFixturePreparers(...) to group them when
42// necessary.
43//
44// deprecated
45var prepareForJavaTest = android.GroupFixturePreparers(
Paul Duffin95bdab42021-03-08 21:48:46 +000046 genrule.PrepareForTestWithGenRuleBuildComponents,
47 // Get the CC build components but not default modules.
48 cc.PrepareForTestWithCcBuildComponents,
49 // Include all the default java modules.
Jiakai Zhangb95998b2023-05-11 16:39:27 +010050 PrepareForTestWithDexpreopt,
Jihoon Kang84b25892023-12-01 22:01:06 +000051 // Include aconfig modules.
52 aconfig.PrepareForTestWithAconfigBuildComponents,
Paul Duffin95bdab42021-03-08 21:48:46 +000053)
54
Colin Cross72bb3632017-07-13 16:23:21 -070055func TestMain(m *testing.M) {
Paul Duffind6339af2021-03-22 18:05:04 +000056 os.Exit(m.Run())
Colin Cross527012a2017-11-30 22:56:16 -080057}
58
Paul Duffin95bdab42021-03-08 21:48:46 +000059// testJavaError is a legacy way of running tests of java modules that expect errors.
60//
61// See testJava for an explanation as to how to stop using this deprecated method.
62//
63// deprecated
Jeongik Cha2cc570d2019-10-29 15:44:45 +090064func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) {
Jeongik Cha538c0d02019-07-11 15:54:27 +090065 t.Helper()
Paul Duffin71ae5942021-03-22 15:36:52 +000066 result := android.GroupFixturePreparers(
Paul Duffin9fc9f532021-03-23 15:41:11 +000067 prepareForJavaTest, dexpreopt.PrepareForTestByEnablingDexpreopt).
Paul Duffin6bac49c2021-03-12 21:28:15 +000068 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)).
69 RunTestWithBp(t, bp)
70 return result.TestContext, result.Config
Jeongik Cha2cc570d2019-10-29 15:44:45 +090071}
72
Paul Duffin71ae5942021-03-22 15:36:52 +000073// testJavaWithFS runs tests using the prepareForJavaTest
Paul Duffin95bdab42021-03-08 21:48:46 +000074//
75// See testJava for an explanation as to how to stop using this deprecated method.
76//
77// deprecated
78func testJavaWithFS(t *testing.T, bp string, fs android.MockFS) (*android.TestContext, android.Config) {
Colin Cross238c1f32020-06-07 16:58:18 -070079 t.Helper()
Paul Duffin71ae5942021-03-22 15:36:52 +000080 result := android.GroupFixturePreparers(
81 prepareForJavaTest, fs.AddToFixture()).RunTestWithBp(t, bp)
Paul Duffin95bdab42021-03-08 21:48:46 +000082 return result.TestContext, result.Config
Colin Cross238c1f32020-06-07 16:58:18 -070083}
84
Paul Duffin71ae5942021-03-22 15:36:52 +000085// testJava runs tests using the prepareForJavaTest
Paul Duffin95bdab42021-03-08 21:48:46 +000086//
Paul Duffin71ae5942021-03-22 15:36:52 +000087// Do not add any new usages of this, instead use the prepareForJavaTest directly as it makes it
Paul Duffin95bdab42021-03-08 21:48:46 +000088// much easier to customize the test behavior.
89//
90// If it is necessary to customize the behavior of an existing test that uses this then please first
Paul Duffin71ae5942021-03-22 15:36:52 +000091// convert the test to using prepareForJavaTest first and then in a following change add the
Paul Duffin95bdab42021-03-08 21:48:46 +000092// appropriate fixture preparers. Keeping the conversion change separate makes it easy to verify
93// that it did not change the test behavior unexpectedly.
94//
95// deprecated
Jaewoong Jungf9a04432019-07-17 11:15:09 -070096func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -080097 t.Helper()
Paul Duffin71ae5942021-03-22 15:36:52 +000098 result := prepareForJavaTest.RunTestWithBp(t, bp)
Paul Duffin95bdab42021-03-08 21:48:46 +000099 return result.TestContext, result.Config
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900100}
101
Paul Duffin95bdab42021-03-08 21:48:46 +0000102// defaultModuleToPath constructs a path to the turbine generate jar for a default test module that
103// is defined in PrepareForIntegrationTestWithJava
104func defaultModuleToPath(name string) string {
Paul Duffin76101fa2021-03-13 09:55:25 +0000105 switch {
106 case name == `""`:
107 return name
108 case strings.HasSuffix(name, ".jar"):
109 return name
110 default:
Paul Duffin414ea5e2021-03-22 17:31:52 +0000111 return filepath.Join("out", "soong", ".intermediates", defaultJavaDir, name, "android_common", "turbine-combined", name+".jar")
Paul Duffin76101fa2021-03-13 09:55:25 +0000112 }
Paul Duffin95bdab42021-03-08 21:48:46 +0000113}
114
Paul Duffin76e5c8a2021-03-20 14:19:46 +0000115// Test that the PrepareForTestWithJavaDefaultModules provides all the files that it uses by
116// running it in a fixture that requires all source files to exist.
117func TestPrepareForTestWithJavaDefaultModules(t *testing.T) {
118 android.GroupFixturePreparers(
119 PrepareForTestWithJavaDefaultModules,
120 android.PrepareForTestDisallowNonExistentPaths,
121 ).RunTest(t)
122}
123
Jeongik Chae403e9e2019-12-07 00:16:24 +0900124func TestJavaLinkType(t *testing.T) {
125 testJava(t, `
126 java_library {
127 name: "foo",
128 srcs: ["a.java"],
129 libs: ["bar"],
130 static_libs: ["baz"],
131 }
132
133 java_library {
134 name: "bar",
135 sdk_version: "current",
136 srcs: ["b.java"],
137 }
138
139 java_library {
140 name: "baz",
141 sdk_version: "system_current",
142 srcs: ["c.java"],
143 }
144 `)
145
Steven Moreland00298982020-11-17 21:44:36 +0000146 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900147 java_library {
148 name: "foo",
149 srcs: ["a.java"],
150 libs: ["bar"],
151 sdk_version: "current",
152 static_libs: ["baz"],
153 }
154
155 java_library {
156 name: "bar",
157 sdk_version: "current",
158 srcs: ["b.java"],
159 }
160
161 java_library {
162 name: "baz",
163 sdk_version: "system_current",
164 srcs: ["c.java"],
165 }
166 `)
167
168 testJava(t, `
169 java_library {
170 name: "foo",
171 srcs: ["a.java"],
172 libs: ["bar"],
173 sdk_version: "system_current",
174 static_libs: ["baz"],
175 }
176
177 java_library {
178 name: "bar",
179 sdk_version: "current",
180 srcs: ["b.java"],
181 }
182
183 java_library {
184 name: "baz",
185 sdk_version: "system_current",
186 srcs: ["c.java"],
187 }
188 `)
189
Steven Moreland00298982020-11-17 21:44:36 +0000190 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900191 java_library {
192 name: "foo",
193 srcs: ["a.java"],
194 libs: ["bar"],
195 sdk_version: "system_current",
196 static_libs: ["baz"],
197 }
198
199 java_library {
200 name: "bar",
201 sdk_version: "current",
202 srcs: ["b.java"],
203 }
204
205 java_library {
206 name: "baz",
207 srcs: ["c.java"],
208 }
209 `)
210}
211
Colin Cross72bb3632017-07-13 16:23:21 -0700212func TestSimple(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700213 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700214 java_library {
215 name: "foo",
216 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700217 libs: ["bar"],
218 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700219 }
220
221 java_library {
222 name: "bar",
223 srcs: ["b.java"],
224 }
225
226 java_library {
227 name: "baz",
228 srcs: ["c.java"],
229 }
Colin Crossd5934c82017-10-02 13:55:26 -0700230 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700231
Paul Duffina71a67a2021-03-29 00:42:57 +0100232 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700233 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700234
235 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
236 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
237 }
238
Colin Cross1ee23172017-10-18 14:44:18 -0700239 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Paul Duffin414ea5e2021-03-22 17:31:52 +0000240 barTurbine := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
241 bazTurbine := filepath.Join("out", "soong", ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700242
Paul Duffin22b77cd2021-03-12 19:15:01 +0000243 android.AssertStringDoesContain(t, "foo classpath", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700244
Paul Duffin22b77cd2021-03-12 19:15:01 +0000245 android.AssertStringDoesContain(t, "foo classpath", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700246
247 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
248 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700249 }
250}
251
Artur Satayev9cf46692019-11-26 18:08:34 +0000252func TestExportedPlugins(t *testing.T) {
253 type Result struct {
Colin Crossc9fe10f2020-11-19 18:06:03 -0800254 library string
255 processors string
256 disableTurbine bool
Artur Satayev9cf46692019-11-26 18:08:34 +0000257 }
258 var tests = []struct {
259 name string
260 extra string
261 results []Result
262 }{
263 {
264 name: "Exported plugin is not a direct plugin",
265 extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`,
266 results: []Result{{library: "exports", processors: "-proc:none"}},
267 },
268 {
269 name: "Exports plugin to dependee",
270 extra: `
271 java_library{name: "exports", exported_plugins: ["plugin"]}
272 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
273 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
274 `,
275 results: []Result{
276 {library: "foo", processors: "-processor com.android.TestPlugin"},
277 {library: "bar", processors: "-processor com.android.TestPlugin"},
278 },
279 },
280 {
281 name: "Exports plugin to android_library",
282 extra: `
283 java_library{name: "exports", exported_plugins: ["plugin"]}
284 android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
285 android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
286 `,
287 results: []Result{
288 {library: "foo", processors: "-processor com.android.TestPlugin"},
289 {library: "bar", processors: "-processor com.android.TestPlugin"},
290 },
291 },
292 {
293 name: "Exports plugin is not propagated via transitive deps",
294 extra: `
295 java_library{name: "exports", exported_plugins: ["plugin"]}
296 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
297 java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]}
298 `,
299 results: []Result{
300 {library: "foo", processors: "-processor com.android.TestPlugin"},
301 {library: "bar", processors: "-proc:none"},
302 },
303 },
304 {
305 name: "Exports plugin appends to plugins",
306 extra: `
307 java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"}
308 java_library{name: "exports", exported_plugins: ["plugin"]}
309 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]}
310 `,
311 results: []Result{
312 {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"},
313 },
314 },
Colin Crossc9fe10f2020-11-19 18:06:03 -0800315 {
316 name: "Exports plugin to with generates_api to dependee",
317 extra: `
318 java_library{name: "exports", exported_plugins: ["plugin_generates_api"]}
319 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
320 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
321 `,
322 results: []Result{
323 {library: "foo", processors: "-processor com.android.TestPlugin", disableTurbine: true},
324 {library: "bar", processors: "-processor com.android.TestPlugin", disableTurbine: true},
325 },
326 },
Artur Satayev9cf46692019-11-26 18:08:34 +0000327 }
328
329 for _, test := range tests {
330 t.Run(test.name, func(t *testing.T) {
331 ctx, _ := testJava(t, `
332 java_plugin {
333 name: "plugin",
334 processor_class: "com.android.TestPlugin",
335 }
Colin Crossc9fe10f2020-11-19 18:06:03 -0800336 java_plugin {
337 name: "plugin_generates_api",
338 generates_api: true,
339 processor_class: "com.android.TestPlugin",
340 }
Artur Satayev9cf46692019-11-26 18:08:34 +0000341 `+test.extra)
342
343 for _, want := range test.results {
344 javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac")
345 if javac.Args["processor"] != want.processors {
346 t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"])
347 }
Colin Crossc9fe10f2020-11-19 18:06:03 -0800348 turbine := ctx.ModuleForTests(want.library, "android_common").MaybeRule("turbine")
349 disableTurbine := turbine.BuildParams.Rule == nil
350 if disableTurbine != want.disableTurbine {
351 t.Errorf("For library %v, expected disableTurbine %v, found %v", want.library, want.disableTurbine, disableTurbine)
352 }
Artur Satayev9cf46692019-11-26 18:08:34 +0000353 }
354 })
355 }
356}
357
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900358func TestSdkVersionByPartition(t *testing.T) {
359 testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900360 java_library {
361 name: "foo",
362 srcs: ["a.java"],
363 vendor: true,
364 }
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900365 `)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900366
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900367 testJava(t, `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900368 java_library {
369 name: "bar",
370 srcs: ["b.java"],
371 }
372 `)
373
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900374 for _, enforce := range []bool{true, false} {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900375 bp := `
376 java_library {
377 name: "foo",
378 srcs: ["a.java"],
379 product_specific: true,
380 }
381 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800382
Paul Duffin414ea5e2021-03-22 17:31:52 +0000383 errorHandler := android.FixtureExpectsNoErrors
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900384 if enforce {
Paul Duffin414ea5e2021-03-22 17:31:52 +0000385 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern("sdk_version must have a value when the module is located at vendor or product")
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900386 }
Paul Duffin414ea5e2021-03-22 17:31:52 +0000387
388 android.GroupFixturePreparers(
389 PrepareForTestWithJavaDefaultModules,
390 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
391 variables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
392 }),
393 ).
394 ExtendWithErrorHandler(errorHandler).
395 RunTestWithBp(t, bp)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900396 }
397}
398
Colin Crossd5934c82017-10-02 13:55:26 -0700399func TestArchSpecific(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700400 ctx, _ := testJava(t, `
Colin Crossd5934c82017-10-02 13:55:26 -0700401 java_library {
402 name: "foo",
403 srcs: ["a.java"],
404 target: {
405 android: {
406 srcs: ["b.java"],
407 },
408 },
409 }
410 `)
411
412 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
413 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
414 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
415 }
416}
417
Colin Cross6b4a32d2017-12-05 13:42:45 -0800418func TestBinary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700419 ctx, _ := testJava(t, `
Colin Cross6b4a32d2017-12-05 13:42:45 -0800420 java_library_host {
421 name: "foo",
422 srcs: ["a.java"],
423 }
424
425 java_binary_host {
426 name: "bar",
427 srcs: ["b.java"],
428 static_libs: ["foo"],
Colin Cross89226d92020-10-09 19:00:54 -0700429 jni_libs: ["libjni"],
430 }
431
432 cc_library_shared {
433 name: "libjni",
434 host_supported: true,
435 device_supported: false,
436 stl: "none",
Colin Cross6b4a32d2017-12-05 13:42:45 -0800437 }
438 `)
439
Colin Cross0c66bc62021-07-20 09:47:41 -0700440 buildOS := ctx.Config().BuildOS.String()
Colin Cross6b4a32d2017-12-05 13:42:45 -0800441
442 bar := ctx.ModuleForTests("bar", buildOS+"_common")
443 barJar := bar.Output("bar.jar").Output.String()
444 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
445 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
446
Colin Cross89226d92020-10-09 19:00:54 -0700447 libjni := ctx.ModuleForTests("libjni", buildOS+"_x86_64_shared")
448 libjniSO := libjni.Rule("Cp").Output.String()
449
Colin Cross6b4a32d2017-12-05 13:42:45 -0800450 // Test that the install binary wrapper depends on the installed jar file
Colin Crossc179ea62020-10-09 10:54:15 -0700451 if g, w := barWrapperDeps, barJar; !android.InList(w, g) {
452 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800453 }
Colin Cross89226d92020-10-09 19:00:54 -0700454
455 // Test that the install binary wrapper depends on the installed JNI libraries
456 if g, w := barWrapperDeps, libjniSO; !android.InList(w, g) {
457 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800458 }
Alex Humesky2070e322020-06-09 20:23:08 -0400459}
Colin Cross6b4a32d2017-12-05 13:42:45 -0800460
Colin Crossf8d9c492021-01-26 11:01:43 -0800461func TestTest(t *testing.T) {
462 ctx, _ := testJava(t, `
463 java_test_host {
464 name: "foo",
465 srcs: ["a.java"],
466 jni_libs: ["libjni"],
467 }
468
469 cc_library_shared {
470 name: "libjni",
471 host_supported: true,
472 device_supported: false,
473 stl: "none",
474 }
475 `)
476
Colin Cross0c66bc62021-07-20 09:47:41 -0700477 buildOS := ctx.Config().BuildOS.String()
Colin Crossf8d9c492021-01-26 11:01:43 -0800478
479 foo := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
480
481 expected := "lib64/libjni.so"
482 if runtime.GOOS == "darwin" {
483 expected = "lib64/libjni.dylib"
484 }
485
486 fooTestData := foo.data
487 if len(fooTestData) != 1 || fooTestData[0].Rel() != expected {
488 t.Errorf(`expected foo test data relative path [%q], got %q`,
489 expected, fooTestData.Strings())
490 }
491}
492
Alex Humesky2070e322020-06-09 20:23:08 -0400493func TestHostBinaryNoJavaDebugInfoOverride(t *testing.T) {
494 bp := `
495 java_library {
496 name: "target_library",
497 srcs: ["a.java"],
498 }
499
500 java_binary_host {
501 name: "host_binary",
502 srcs: ["b.java"],
503 }
504 `
Alex Humesky2070e322020-06-09 20:23:08 -0400505
Paul Duffin414ea5e2021-03-22 17:31:52 +0000506 result := android.GroupFixturePreparers(
507 PrepareForTestWithJavaDefaultModules,
508 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
509 variables.MinimizeJavaDebugInfo = proptools.BoolPtr(true)
510 }),
511 ).RunTestWithBp(t, bp)
Alex Humesky2070e322020-06-09 20:23:08 -0400512
Liz Kammer7941b302020-07-28 13:27:34 -0700513 // first, check that the -g flag is added to target modules
Paul Duffin414ea5e2021-03-22 17:31:52 +0000514 targetLibrary := result.ModuleForTests("target_library", "android_common")
Alex Humesky2070e322020-06-09 20:23:08 -0400515 targetJavaFlags := targetLibrary.Module().VariablesForTests()["javacFlags"]
516 if !strings.Contains(targetJavaFlags, "-g:source,lines") {
517 t.Errorf("target library javac flags %v should contain "+
518 "-g:source,lines override with MinimizeJavaDebugInfo", targetJavaFlags)
519 }
520
521 // check that -g is not overridden for host modules
Colin Cross0c66bc62021-07-20 09:47:41 -0700522 buildOS := result.Config.BuildOS.String()
Paul Duffin414ea5e2021-03-22 17:31:52 +0000523 hostBinary := result.ModuleForTests("host_binary", buildOS+"_common")
Alex Humesky2070e322020-06-09 20:23:08 -0400524 hostJavaFlags := hostBinary.Module().VariablesForTests()["javacFlags"]
525 if strings.Contains(hostJavaFlags, "-g:source,lines") {
526 t.Errorf("java_binary_host javac flags %v should not have "+
527 "-g:source,lines override with MinimizeJavaDebugInfo", hostJavaFlags)
528 }
Colin Cross6b4a32d2017-12-05 13:42:45 -0800529}
530
Colin Cross72bb3632017-07-13 16:23:21 -0700531func TestPrebuilts(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700532 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700533 java_library {
534 name: "foo",
Paul Duffin91547182019-11-12 19:39:36 +0000535 srcs: ["a.java", ":stubs-source"],
Paul Duffinfcfd7912020-01-31 17:54:30 +0000536 libs: ["bar", "sdklib"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700537 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700538 }
539
Colin Cross74d73e22017-08-02 11:05:49 -0700540 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700541 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700542 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700543 }
544
Colin Cross74d73e22017-08-02 11:05:49 -0700545 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700546 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700547 jars: ["b.jar"],
Liz Kammerd6c31d22020-08-05 15:40:41 -0700548 sdk_version: "current",
549 compile_dex: true,
Colin Cross72bb3632017-07-13 16:23:21 -0700550 }
Colin Cross42be7612019-02-21 18:12:14 -0800551
552 dex_import {
553 name: "qux",
554 jars: ["b.jar"],
555 }
Colin Cross79c7c262019-04-17 11:11:46 -0700556
557 java_sdk_library_import {
Paul Duffin56d44902020-01-31 13:36:25 +0000558 name: "sdklib",
559 public: {
560 jars: ["c.jar"],
561 },
562 }
563
Paul Duffin91547182019-11-12 19:39:36 +0000564 prebuilt_stubs_sources {
565 name: "stubs-source",
Paul Duffin9b478b02019-12-10 13:41:51 +0000566 srcs: ["stubs/sources"],
Paul Duffin91547182019-11-12 19:39:36 +0000567 }
Paul Duffin1b82e6a2019-12-03 18:06:47 +0000568
569 java_test_import {
570 name: "test",
571 jars: ["a.jar"],
572 test_suites: ["cts"],
573 test_config: "AndroidTest.xml",
574 }
Colin Cross72bb3632017-07-13 16:23:21 -0700575 `)
576
Paul Duffin9b478b02019-12-10 13:41:51 +0000577 fooModule := ctx.ModuleForTests("foo", "android_common")
578 javac := fooModule.Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700579 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Liz Kammerd6c31d22020-08-05 15:40:41 -0700580 barModule := ctx.ModuleForTests("bar", "android_common")
581 barJar := barModule.Rule("combineJar").Output
582 bazModule := ctx.ModuleForTests("baz", "android_common")
583 bazJar := bazModule.Rule("combineJar").Output
Colin Cross79c7c262019-04-17 11:11:46 -0700584 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700585
Paul Duffin9b478b02019-12-10 13:41:51 +0000586 fooLibrary := fooModule.Module().(*Library)
Chaohui Wangdcbe33c2022-10-11 11:13:30 +0800587 assertDeepEquals(t, "foo unique sources incorrect",
588 []string{"a.java"}, fooLibrary.uniqueSrcFiles.Strings())
Paul Duffin91547182019-11-12 19:39:36 +0000589
Paul Duffin9b478b02019-12-10 13:41:51 +0000590 assertDeepEquals(t, "foo java source jars incorrect",
591 []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"},
592 android.NormalizePathsForTesting(fooLibrary.compiledSrcJars))
Paul Duffin91547182019-11-12 19:39:36 +0000593
Colin Cross37f6d792018-07-12 12:28:41 -0700594 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
595 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700596 }
597
Liz Kammerd6c31d22020-08-05 15:40:41 -0700598 barDexJar := barModule.Module().(*Import).DexJarBuildPath()
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +0100599 if barDexJar.IsSet() {
600 t.Errorf("bar dex jar build path expected to be set, got %s", barDexJar)
Liz Kammerd6c31d22020-08-05 15:40:41 -0700601 }
602
Colin Cross79c7c262019-04-17 11:11:46 -0700603 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
604 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
605 }
606
Colin Cross37f6d792018-07-12 12:28:41 -0700607 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
608 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700609 }
Colin Cross42be7612019-02-21 18:12:14 -0800610
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +0100611 bazDexJar := bazModule.Module().(*Import).DexJarBuildPath().Path()
Paul Duffin414ea5e2021-03-22 17:31:52 +0000612 expectedDexJar := "out/soong/.intermediates/baz/android_common/dex/baz.jar"
613 android.AssertPathRelativeToTopEquals(t, "baz dex jar build path", expectedDexJar, bazDexJar)
Liz Kammerd6c31d22020-08-05 15:40:41 -0700614
Colin Cross42be7612019-02-21 18:12:14 -0800615 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Wei Li598f92d2023-01-04 17:12:24 -0800616
617 entries := android.AndroidMkEntriesForTest(t, ctx, fooModule.Module())[0]
618 android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "java_library", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0])
619 entries = android.AndroidMkEntriesForTest(t, ctx, barModule.Module())[0]
620 android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "java_import", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0])
621 entries = android.AndroidMkEntriesForTest(t, ctx, ctx.ModuleForTests("sdklib", "android_common").Module())[0]
622 android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "java_sdk_library_import", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0])
Colin Cross72bb3632017-07-13 16:23:21 -0700623}
624
Paul Duffin9b478b02019-12-10 13:41:51 +0000625func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) {
626 if !reflect.DeepEqual(expected, actual) {
627 t.Errorf("%s: expected %q, found %q", message, expected, actual)
628 }
629}
630
Paul Duffin1a393322020-11-18 16:36:47 +0000631func TestPrebuiltStubsSources(t *testing.T) {
632 test := func(t *testing.T, sourcesPath string, expectedInputs []string) {
633 ctx, _ := testJavaWithFS(t, fmt.Sprintf(`
634prebuilt_stubs_sources {
635 name: "stubs-source",
636 srcs: ["%s"],
637}`, sourcesPath), map[string][]byte{
638 "stubs/sources/pkg/A.java": nil,
639 "stubs/sources/pkg/B.java": nil,
640 })
641
642 zipSrc := ctx.ModuleForTests("stubs-source", "android_common").Rule("zip_src")
643 if expected, actual := expectedInputs, zipSrc.Inputs.Strings(); !reflect.DeepEqual(expected, actual) {
644 t.Errorf("mismatch of inputs to soong_zip: expected %q, actual %q", expected, actual)
645 }
646 }
647
648 t.Run("empty/missing directory", func(t *testing.T) {
Colin Crossce3a51d2021-03-19 16:22:12 -0700649 test(t, "empty-directory", nil)
Paul Duffin1a393322020-11-18 16:36:47 +0000650 })
651
652 t.Run("non-empty set of sources", func(t *testing.T) {
653 test(t, "stubs/sources", []string{
654 "stubs/sources/pkg/A.java",
655 "stubs/sources/pkg/B.java",
656 })
657 })
658}
659
Colin Cross89536d42017-07-07 14:35:50 -0700660func TestDefaults(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700661 ctx, _ := testJava(t, `
Colin Cross89536d42017-07-07 14:35:50 -0700662 java_defaults {
663 name: "defaults",
664 srcs: ["a.java"],
665 libs: ["bar"],
666 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -0700667 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700668 }
669
670 java_library {
671 name: "foo",
672 defaults: ["defaults"],
673 }
674
675 java_library {
676 name: "bar",
677 srcs: ["b.java"],
678 }
679
680 java_library {
681 name: "baz",
682 srcs: ["c.java"],
683 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700684
685 android_test {
686 name: "atestOptimize",
687 defaults: ["defaults"],
688 optimize: {enabled: true},
689 }
690
691 android_test {
692 name: "atestNoOptimize",
693 defaults: ["defaults"],
694 }
695
696 android_test {
697 name: "atestDefault",
698 srcs: ["a.java"],
699 }
Colin Cross89536d42017-07-07 14:35:50 -0700700 `)
701
Paul Duffina71a67a2021-03-29 00:42:57 +0100702 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700703 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -0700704
705 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
706 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
707 }
708
Paul Duffin414ea5e2021-03-22 17:31:52 +0000709 barTurbine := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
Nan Zhanged19fc32017-10-19 13:06:22 -0700710 if !strings.Contains(javac.Args["classpath"], barTurbine) {
711 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -0700712 }
713
Colin Cross1ee23172017-10-18 14:44:18 -0700714 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -0700715 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
716 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -0700717 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700718
719 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
720 if atestOptimize.Output == nil {
721 t.Errorf("atestOptimize should optimize APK")
722 }
723
724 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
725 if atestNoOptimize.Output == nil {
726 t.Errorf("atestNoOptimize should not optimize APK")
727 }
728
Jared Duke63a3da92022-06-02 19:11:14 +0000729 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("d8")
Sasha Smundak2057f822019-04-16 17:16:58 -0700730 if atestDefault.Output == nil {
Jared Duke63a3da92022-06-02 19:11:14 +0000731 t.Errorf("atestDefault should not optimize APK")
Sasha Smundak2057f822019-04-16 17:16:58 -0700732 }
Colin Cross89536d42017-07-07 14:35:50 -0700733}
734
Colin Cross0f37af02017-09-27 17:42:05 -0700735func TestResources(t *testing.T) {
736 var table = []struct {
737 name string
738 prop string
739 extra string
740 args string
741 }{
742 {
Colin Crossaf9c55b2017-10-03 14:50:08 -0700743 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -0700744 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -0800745 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700746 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700747 },
748 {
749 // Test that a module with java_resources includes the files
750 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -0700751 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
752 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700753 },
754 {
755 // Test that a module with a filegroup in java_resources includes the files with the
756 // path prefix
757 name: "resource filegroup",
758 prop: `java_resources: [":foo-res"]`,
759 extra: `
760 filegroup {
761 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -0800762 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -0700763 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -0700764 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700765 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700766 },
767 {
Colin Cross0ead1d72018-04-10 13:07:42 -0700768 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
769 name: "wildcard dirs",
770 prop: `java_resource_dirs: ["java-res/*"]`,
771 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
772 },
773 {
774 // Test that a module exclude_java_resource_dirs excludes the files
775 name: "wildcard dirs",
776 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
777 args: "-C java-res/a -f java-res/a/a",
778 },
Colin Crosscedd4762018-09-13 11:26:19 -0700779 {
780 // Test wildcards in java_resources
781 name: "wildcard files",
782 prop: `java_resources: ["java-res/**/*"]`,
783 args: "-C . -f java-res/a/a -f java-res/b/b",
784 },
785 {
786 // Test exclude_java_resources with java_resources
787 name: "wildcard files with exclude",
788 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
789 args: "-C . -f java-res/a/a",
790 },
791 {
792 // Test exclude_java_resources with java_resource_dirs
793 name: "resource dirs with exclude files",
794 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
795 args: "-C java-res -f java-res/a/a",
796 },
797 {
798 // Test exclude_java_resource_dirs with java_resource_dirs
799 name: "resource dirs with exclude files",
800 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
801 args: "-C java-res -f java-res/a/a -f java-res/b/b",
802 },
Colin Cross0f37af02017-09-27 17:42:05 -0700803 }
804
805 for _, test := range table {
806 t.Run(test.name, func(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700807 ctx, _ := testJavaWithFS(t, `
Colin Cross0f37af02017-09-27 17:42:05 -0700808 java_library {
809 name: "foo",
810 srcs: [
811 "a.java",
812 "b.java",
813 "c.java",
814 ],
815 `+test.prop+`,
816 }
Colin Cross238c1f32020-06-07 16:58:18 -0700817 `+test.extra,
818 map[string][]byte{
819 "java-res/a/a": nil,
820 "java-res/b/b": nil,
821 "java-res2/a": nil,
822 },
823 )
Colin Cross0f37af02017-09-27 17:42:05 -0700824
Colin Cross331a1212018-08-15 20:40:52 -0700825 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -0700826 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -0700827
828 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
829 t.Errorf("foo combined jars %v does not contain %q",
830 foo.Inputs.Strings(), fooRes.Output.String())
831 }
832
Colin Crossaf9c55b2017-10-03 14:50:08 -0700833 if fooRes.Args["jarArgs"] != test.args {
834 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -0700835 fooRes.Args["jarArgs"], test.args)
836 }
837 })
838 }
839}
840
Colin Cross0c4ce212019-05-03 15:28:19 -0700841func TestIncludeSrcs(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700842 ctx, _ := testJavaWithFS(t, `
Colin Cross0c4ce212019-05-03 15:28:19 -0700843 java_library {
844 name: "foo",
845 srcs: [
846 "a.java",
847 "b.java",
848 "c.java",
849 ],
850 include_srcs: true,
851 }
852
853 java_library {
854 name: "bar",
855 srcs: [
856 "a.java",
857 "b.java",
858 "c.java",
859 ],
860 java_resource_dirs: ["java-res"],
861 include_srcs: true,
862 }
Colin Cross238c1f32020-06-07 16:58:18 -0700863 `, map[string][]byte{
864 "java-res/a/a": nil,
865 "java-res/b/b": nil,
866 "java-res2/a": nil,
867 })
Colin Cross0c4ce212019-05-03 15:28:19 -0700868
869 // Test a library with include_srcs: true
870 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
871 fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar")
872
873 if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) {
874 t.Errorf("foo combined jars %v does not contain %q", w, g)
875 }
876
877 if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
878 t.Errorf("foo source jar args %q is not %q", w, g)
879 }
880
881 // Test a library with include_srcs: true and resources
882 bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar")
883 barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar")
884 barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar")
885 barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar")
886
887 if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
888 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
889 }
890
891 if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
892 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
893 }
894
895 if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) {
896 t.Errorf("bar combined jars %v does not contain %q", w, g)
897 }
898
899 if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
900 t.Errorf("bar source jar args %q is not %q", w, g)
901 }
902
903 if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w {
904 t.Errorf("bar resource jar args %q is not %q", w, g)
905 }
906}
907
Colin Cross54190b32017-10-09 15:34:10 -0700908func TestGeneratedSources(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700909 ctx, _ := testJavaWithFS(t, `
Colin Cross54190b32017-10-09 15:34:10 -0700910 java_library {
911 name: "foo",
912 srcs: [
913 "a*.java",
914 ":gen",
915 "b*.java",
916 ],
917 }
918
919 genrule {
920 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -0800921 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -0700922 out: ["gen.java"],
923 }
Colin Cross238c1f32020-06-07 16:58:18 -0700924 `, map[string][]byte{
925 "a.java": nil,
926 "b.java": nil,
927 })
Colin Cross54190b32017-10-09 15:34:10 -0700928
929 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
930 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
931
Colin Cross15e86d92017-10-20 15:07:08 -0700932 if filepath.Base(genrule.Output.String()) != "gen.java" {
933 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -0700934 }
935
936 if len(javac.Inputs) != 3 ||
937 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -0700938 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -0700939 javac.Inputs[2].String() != "b.java" {
940 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
941 }
942}
943
Nan Zhang61eaedb2017-11-02 13:28:15 -0700944func TestTurbine(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +0000945 result := android.GroupFixturePreparers(
946 prepareForJavaTest, FixtureWithPrebuiltApis(map[string][]string{"14": {"foo"}})).
Paul Duffin3d9f2682021-03-13 09:47:16 +0000947 RunTestWithBp(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -0700948 java_library {
949 name: "foo",
950 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +0900951 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -0700952 }
953
954 java_library {
955 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -0800956 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -0700957 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +0900958 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -0700959 }
960
961 java_library {
962 name: "baz",
963 srcs: ["c.java"],
964 libs: ["bar"],
965 sdk_version: "14",
966 }
967 `)
968
Paul Duffina71a67a2021-03-29 00:42:57 +0100969 fooTurbine := result.ModuleForTests("foo", "android_common").Rule("turbine")
970 barTurbine := result.ModuleForTests("bar", "android_common").Rule("turbine")
971 barJavac := result.ModuleForTests("bar", "android_common").Rule("javac")
972 barTurbineCombined := result.ModuleForTests("bar", "android_common").Description("for turbine")
973 bazJavac := result.ModuleForTests("baz", "android_common").Rule("javac")
Nan Zhang61eaedb2017-11-02 13:28:15 -0700974
Paul Duffin414ea5e2021-03-22 17:31:52 +0000975 android.AssertPathsRelativeToTopEquals(t, "foo inputs", []string{"a.java"}, fooTurbine.Inputs)
Nan Zhang61eaedb2017-11-02 13:28:15 -0700976
Paul Duffin414ea5e2021-03-22 17:31:52 +0000977 fooHeaderJar := filepath.Join("out", "soong", ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
978 barTurbineJar := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine", "bar.jar")
Colin Crossf61766e2022-03-16 18:06:48 -0700979 android.AssertStringDoesContain(t, "bar turbine classpath", barTurbine.Args["turbineFlags"], fooHeaderJar)
Paul Duffin3d9f2682021-03-13 09:47:16 +0000980 android.AssertStringDoesContain(t, "bar javac classpath", barJavac.Args["classpath"], fooHeaderJar)
Paul Duffin414ea5e2021-03-22 17:31:52 +0000981 android.AssertPathsRelativeToTopEquals(t, "bar turbine combineJar", []string{barTurbineJar, fooHeaderJar}, barTurbineCombined.Inputs)
Paul Duffin3d9f2682021-03-13 09:47:16 +0000982 android.AssertStringDoesContain(t, "baz javac classpath", bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -0700983}
984
985func TestSharding(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700986 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -0700987 java_library {
988 name: "bar",
989 srcs: ["a.java","b.java","c.java"],
990 javac_shard_size: 1
991 }
992 `)
993
Colin Cross3d56ed52021-11-18 22:23:12 -0800994 barHeaderJar := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine", "bar.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -0700995 for i := 0; i < 3; i++ {
Paul Duffina71a67a2021-03-29 00:42:57 +0100996 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
Colin Cross3d56ed52021-11-18 22:23:12 -0800997 if !strings.HasPrefix(barJavac.Args["classpath"], "-classpath "+barHeaderJar+":") {
998 t.Errorf("bar javac classpath %v does start with %q", barJavac.Args["classpath"], barHeaderJar)
Nan Zhang61eaedb2017-11-02 13:28:15 -0700999 }
1000 }
1001}
1002
Nan Zhang27e284d2018-02-09 21:03:53 +00001003func TestExcludeFileGroupInSrcs(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001004 ctx, _ := testJava(t, `
Nan Zhang27e284d2018-02-09 21:03:53 +00001005 java_library {
1006 name: "foo",
1007 srcs: ["a.java", ":foo-srcs"],
1008 exclude_srcs: ["a.java", ":foo-excludes"],
1009 }
1010
1011 filegroup {
1012 name: "foo-srcs",
1013 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
1014 }
1015
1016 filegroup {
1017 name: "foo-excludes",
1018 srcs: ["java-fg/a.java", "java-fg/b.java"],
1019 }
1020 `)
1021
1022 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1023
1024 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
1025 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
1026 }
1027}
Jiyong Parkc678ad32018-04-10 13:07:10 +09001028
Paul Duffin52d398a2019-06-11 12:31:14 +01001029func TestJavaLibrary(t *testing.T) {
Paul Duffin414ea5e2021-03-22 17:31:52 +00001030 testJavaWithFS(t, "", map[string][]byte{
Paul Duffin52d398a2019-06-11 12:31:14 +01001031 "libcore/Android.bp": []byte(`
1032 java_library {
1033 name: "core",
1034 sdk_version: "none",
1035 system_modules: "none",
Paul Duffinaa55f742020-10-06 17:20:13 +01001036 }
1037
1038 filegroup {
1039 name: "core-jar",
1040 srcs: [":core{.jar}"],
1041 }
Paul Duffin414ea5e2021-03-22 17:31:52 +00001042 `),
Paul Duffinaa55f742020-10-06 17:20:13 +01001043 })
Paul Duffinaa55f742020-10-06 17:20:13 +01001044}
1045
1046func TestJavaImport(t *testing.T) {
Paul Duffin414ea5e2021-03-22 17:31:52 +00001047 testJavaWithFS(t, "", map[string][]byte{
Paul Duffinaa55f742020-10-06 17:20:13 +01001048 "libcore/Android.bp": []byte(`
1049 java_import {
1050 name: "core",
1051 sdk_version: "none",
1052 }
1053
1054 filegroup {
1055 name: "core-jar",
1056 srcs: [":core{.jar}"],
1057 }
Paul Duffin414ea5e2021-03-22 17:31:52 +00001058 `),
Paul Duffin52d398a2019-06-11 12:31:14 +01001059 })
Paul Duffin52d398a2019-06-11 12:31:14 +01001060}
1061
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001062var compilerFlagsTestCases = []struct {
1063 in string
1064 out bool
1065}{
1066 {
1067 in: "a",
1068 out: false,
1069 },
1070 {
1071 in: "-a",
1072 out: true,
1073 },
1074 {
1075 in: "-no-jdk",
1076 out: false,
1077 },
1078 {
1079 in: "-no-stdlib",
1080 out: false,
1081 },
1082 {
1083 in: "-kotlin-home",
1084 out: false,
1085 },
1086 {
1087 in: "-kotlin-home /some/path",
1088 out: false,
1089 },
1090 {
1091 in: "-include-runtime",
1092 out: false,
1093 },
1094 {
1095 in: "-Xintellij-plugin-root",
1096 out: false,
1097 },
1098}
1099
1100type mockContext struct {
1101 android.ModuleContext
1102 result bool
1103}
1104
1105func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
1106 // CheckBadCompilerFlags calls this function when the flag should be rejected
1107 ctx.result = false
1108}
1109
1110func TestCompilerFlags(t *testing.T) {
1111 for _, testCase := range compilerFlagsTestCases {
1112 ctx := &mockContext{result: true}
1113 CheckKotlincFlags(ctx, []string{testCase.in})
1114 if ctx.result != testCase.out {
1115 t.Errorf("incorrect output:")
1116 t.Errorf(" input: %#v", testCase.in)
1117 t.Errorf(" expected: %#v", testCase.out)
1118 t.Errorf(" got: %#v", ctx.result)
1119 }
1120 }
1121}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001122
1123// TODO(jungjw): Consider making this more robust by ignoring path order.
1124func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
Paul Duffin414ea5e2021-03-22 17:31:52 +00001125 variables := ctx.ModuleForTests(moduleName, "android_common").VariablesForTestsRelativeToTop()
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001126 flags := strings.Split(variables["javacFlags"], " ")
1127 got := ""
1128 for _, flag := range flags {
1129 keyEnd := strings.Index(flag, "=")
1130 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
1131 got = flag[keyEnd+1:]
1132 break
1133 }
1134 }
Lukacs T. Berki9f6c24a2021-08-26 15:07:24 +02001135 if expected != android.StringPathRelativeToTop(ctx.Config().SoongOutDir(), got) {
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001136 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
1137 }
1138}
1139
1140func TestPatchModule(t *testing.T) {
Pete Gillin0c2143e2019-05-02 15:32:11 +01001141 t.Run("Java language level 8", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001142 // Test with legacy javac -source 1.8 -target 1.8
Pete Gillinbdf5d712019-10-21 14:29:58 +01001143 bp := `
1144 java_library {
1145 name: "foo",
1146 srcs: ["a.java"],
1147 java_version: "1.8",
1148 }
1149
1150 java_library {
1151 name: "bar",
1152 srcs: ["b.java"],
1153 sdk_version: "none",
1154 system_modules: "none",
1155 patch_module: "java.base",
1156 java_version: "1.8",
1157 }
1158
1159 java_library {
1160 name: "baz",
1161 srcs: ["c.java"],
1162 patch_module: "java.base",
1163 java_version: "1.8",
1164 }
1165 `
1166 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001167
1168 checkPatchModuleFlag(t, ctx, "foo", "")
1169 checkPatchModuleFlag(t, ctx, "bar", "")
1170 checkPatchModuleFlag(t, ctx, "baz", "")
1171 })
1172
Pete Gillin0c2143e2019-05-02 15:32:11 +01001173 t.Run("Java language level 9", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001174 // Test with default javac -source 9 -target 9
Pete Gillinbdf5d712019-10-21 14:29:58 +01001175 bp := `
1176 java_library {
1177 name: "foo",
1178 srcs: ["a.java"],
1179 }
1180
1181 java_library {
1182 name: "bar",
1183 srcs: ["b.java"],
1184 sdk_version: "none",
1185 system_modules: "none",
1186 patch_module: "java.base",
1187 }
1188
1189 java_library {
1190 name: "baz",
Jingwen Chen5136a6e2020-10-30 01:01:35 -04001191 srcs: [
1192 "c.java",
1193 // Tests for b/150878007
1194 "dir/d.java",
1195 "dir2/e.java",
1196 "dir2/f.java",
1197 "nested/dir/g.java"
1198 ],
Pete Gillinbdf5d712019-10-21 14:29:58 +01001199 patch_module: "java.base",
1200 }
1201 `
Pete Gillin1b3370f2019-10-01 13:57:31 +01001202 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001203
1204 checkPatchModuleFlag(t, ctx, "foo", "")
Paul Duffin414ea5e2021-03-22 17:31:52 +00001205 expected := "java.base=.:out/soong"
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001206 checkPatchModuleFlag(t, ctx, "bar", expected)
Jingwen Chen5136a6e2020-10-30 01:01:35 -04001207 expected = "java.base=" + strings.Join([]string{
Paul Duffin414ea5e2021-03-22 17:31:52 +00001208 ".", "out/soong", "dir", "dir2", "nested", defaultModuleToPath("ext"), defaultModuleToPath("framework")}, ":")
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001209 checkPatchModuleFlag(t, ctx, "baz", expected)
1210 })
1211}
Paul Duffina7b9f422020-01-10 17:12:18 +00001212
Paul Duffin83a2d962019-11-19 19:44:10 +00001213func TestJavaLibraryWithSystemModules(t *testing.T) {
1214 ctx, _ := testJava(t, `
1215 java_library {
1216 name: "lib-with-source-system-modules",
1217 srcs: [
1218 "a.java",
1219 ],
1220 sdk_version: "none",
1221 system_modules: "source-system-modules",
1222 }
1223
1224 java_library {
1225 name: "source-jar",
1226 srcs: [
1227 "a.java",
1228 ],
1229 }
1230
1231 java_system_modules {
1232 name: "source-system-modules",
1233 libs: ["source-jar"],
1234 }
1235
1236 java_library {
1237 name: "lib-with-prebuilt-system-modules",
1238 srcs: [
1239 "a.java",
1240 ],
1241 sdk_version: "none",
1242 system_modules: "prebuilt-system-modules",
1243 }
1244
1245 java_import {
1246 name: "prebuilt-jar",
1247 jars: ["a.jar"],
1248 }
1249
1250 java_system_modules_import {
1251 name: "prebuilt-system-modules",
1252 libs: ["prebuilt-jar"],
1253 }
1254 `)
1255
1256 checkBootClasspathForSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar")
1257
1258 checkBootClasspathForSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar")
1259}
1260
1261func checkBootClasspathForSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) {
1262 javacRule := ctx.ModuleForTests(moduleName, "android_common").Rule("javac")
1263 bootClasspath := javacRule.Args["bootClasspath"]
1264 if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) {
1265 t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath)
1266 }
1267}
Jiyong Park19604de2020-03-24 16:44:11 +09001268
1269func TestAidlExportIncludeDirsFromImports(t *testing.T) {
1270 ctx, _ := testJava(t, `
1271 java_library {
1272 name: "foo",
1273 srcs: ["aidl/foo/IFoo.aidl"],
1274 libs: ["bar"],
1275 }
1276
1277 java_import {
1278 name: "bar",
1279 jars: ["a.jar"],
1280 aidl: {
1281 export_include_dirs: ["aidl/bar"],
1282 },
1283 }
1284 `)
1285
1286 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
1287 expectedAidlFlag := "-Iaidl/bar"
1288 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1289 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1290 }
1291}
Liz Kammerdd849a82020-06-12 16:38:45 -07001292
Vinh Tran16fe8e12022-08-16 16:45:44 -04001293func TestAidlIncludeDirFromConvertedFileGroupWithPathPropInMixedBuilds(t *testing.T) {
Liz Kammer748209c2022-10-24 10:43:27 -04001294 // TODO(b/247782695), TODO(b/242847534) Fix mixed builds for filegroups
1295 t.Skip("Re-enable once filegroups are corrected for mixed builds")
Vinh Tran16fe8e12022-08-16 16:45:44 -04001296 bp := `
1297 filegroup {
1298 name: "foo_aidl",
1299 srcs: ["aidl/foo/IFoo.aidl"],
1300 path: "aidl/foo",
1301 bazel_module: { label: "//:foo_aidl" },
1302 }
1303 java_library {
1304 name: "foo",
1305 srcs: [":foo_aidl"],
1306 }
1307`
1308
1309 outBaseDir := "out/bazel/output"
1310 result := android.GroupFixturePreparers(
1311 prepareForJavaTest,
1312 android.PrepareForTestWithFilegroup,
1313 android.FixtureModifyConfig(func(config android.Config) {
1314 config.BazelContext = android.MockBazelContext{
1315 OutputBaseDir: outBaseDir,
1316 LabelToOutputFiles: map[string][]string{
1317 "//:foo_aidl": []string{"aidl/foo/IFoo.aidl"},
1318 },
1319 }
1320 }),
1321 ).RunTestWithBp(t, bp)
1322
1323 aidlCommand := result.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
1324 expectedAidlFlag := "-I" + outBaseDir + "/execroot/__main__/aidl/foo"
1325 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1326 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1327 }
1328}
1329
Jooyung Hane197d8b2021-01-05 10:33:16 +09001330func TestAidlFlagsArePassedToTheAidlCompiler(t *testing.T) {
1331 ctx, _ := testJava(t, `
1332 java_library {
1333 name: "foo",
1334 srcs: ["aidl/foo/IFoo.aidl"],
1335 aidl: { flags: ["-Werror"], },
1336 }
1337 `)
1338
1339 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
1340 expectedAidlFlag := "-Werror"
1341 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1342 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1343 }
1344}
1345
Jooyung Han07f70c02021-11-06 07:08:45 +09001346func TestAidlFlagsWithMinSdkVersion(t *testing.T) {
1347 fixture := android.GroupFixturePreparers(
1348 prepareForJavaTest, FixtureWithPrebuiltApis(map[string][]string{"14": {"foo"}}))
1349
1350 for _, tc := range []struct {
1351 name string
1352 sdkVersion string
1353 expected string
1354 }{
1355 {"default is current", "", "current"},
1356 {"use sdk_version", `sdk_version: "14"`, "14"},
1357 {"system_current", `sdk_version: "system_current"`, "current"},
1358 } {
1359 t.Run(tc.name, func(t *testing.T) {
1360 ctx := fixture.RunTestWithBp(t, `
1361 java_library {
1362 name: "foo",
1363 srcs: ["aidl/foo/IFoo.aidl"],
1364 `+tc.sdkVersion+`
1365 }
1366 `)
1367 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
1368 expectedAidlFlag := "--min_sdk_version=" + tc.expected
1369 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1370 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1371 }
1372 })
1373 }
1374}
1375
Spandan Das757b6662022-11-17 04:29:59 +00001376func TestAidlFlagsMinSdkVersionDroidstubs(t *testing.T) {
1377 bpTemplate := `
1378 droidstubs {
1379 name: "foo-stubs",
1380 srcs: ["foo.aidl"],
1381 %s
1382 system_modules: "none",
1383 }
1384 `
1385 testCases := []struct {
1386 desc string
1387 sdkVersionBp string
1388 minSdkVersionExpected string
1389 }{
1390 {
1391 desc: "sdk_version not set, module compiles against private platform APIs",
1392 sdkVersionBp: ``,
1393 minSdkVersionExpected: "10000",
1394 },
1395 {
1396 desc: "sdk_version set to none, module does not build against an SDK",
1397 sdkVersionBp: `sdk_version: "none",`,
1398 minSdkVersionExpected: "10000",
1399 },
1400 }
1401 for _, tc := range testCases {
1402 ctx := prepareForJavaTest.RunTestWithBp(t, fmt.Sprintf(bpTemplate, tc.sdkVersionBp))
1403 aidlCmd := ctx.ModuleForTests("foo-stubs", "android_common").Rule("aidl").RuleParams.Command
1404 expected := "--min_sdk_version=" + tc.minSdkVersionExpected
1405 android.AssertStringDoesContain(t, "aidl command conatins incorrect min_sdk_version for testCse: "+tc.desc, aidlCmd, expected)
1406 }
1407}
1408
Thiébaud Weksteende8417c2022-02-10 15:41:46 +11001409func TestAidlEnforcePermissions(t *testing.T) {
1410 ctx, _ := testJava(t, `
1411 java_library {
1412 name: "foo",
1413 srcs: ["aidl/foo/IFoo.aidl"],
1414 aidl: { enforce_permissions: true },
1415 }
1416 `)
1417
1418 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
1419 expectedAidlFlag := "-Wmissing-permission-annotation -Werror"
1420 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1421 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1422 }
1423}
1424
1425func TestAidlEnforcePermissionsException(t *testing.T) {
1426 ctx, _ := testJava(t, `
1427 java_library {
1428 name: "foo",
1429 srcs: ["aidl/foo/IFoo.aidl", "aidl/foo/IFoo2.aidl"],
1430 aidl: { enforce_permissions: true, enforce_permissions_exceptions: ["aidl/foo/IFoo2.aidl"] },
1431 }
1432 `)
1433
1434 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
1435 expectedAidlFlag := "$$FLAGS -Wmissing-permission-annotation -Werror aidl/foo/IFoo.aidl"
1436 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1437 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1438 }
1439 expectedAidlFlag = "$$FLAGS aidl/foo/IFoo2.aidl"
1440 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1441 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1442 }
1443}
1444
Liz Kammerdd849a82020-06-12 16:38:45 -07001445func TestDataNativeBinaries(t *testing.T) {
Cole Faust5c503d12023-01-24 11:48:08 -08001446 ctx := android.GroupFixturePreparers(
1447 prepareForJavaTest,
1448 android.PrepareForTestWithAllowMissingDependencies).RunTestWithBp(t, `
Liz Kammerdd849a82020-06-12 16:38:45 -07001449 java_test_host {
1450 name: "foo",
1451 srcs: ["a.java"],
1452 data_native_bins: ["bin"]
1453 }
1454
Cole Faust5c503d12023-01-24 11:48:08 -08001455 cc_binary_host {
Liz Kammerdd849a82020-06-12 16:38:45 -07001456 name: "bin",
Cole Faust5c503d12023-01-24 11:48:08 -08001457 srcs: ["bin.cpp"],
Liz Kammerdd849a82020-06-12 16:38:45 -07001458 }
Cole Faust5c503d12023-01-24 11:48:08 -08001459 `).TestContext
Liz Kammerdd849a82020-06-12 16:38:45 -07001460
Colin Cross0c66bc62021-07-20 09:47:41 -07001461 buildOS := ctx.Config().BuildOS.String()
Liz Kammerdd849a82020-06-12 16:38:45 -07001462
1463 test := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
Colin Crossaa255532020-07-03 13:18:24 -07001464 entries := android.AndroidMkEntriesForTest(t, ctx, test)[0]
Cole Faust5c503d12023-01-24 11:48:08 -08001465 expected := []string{"out/soong/.intermediates/bin/" + buildOS + "_x86_64/bin:bin"}
Liz Kammerdd849a82020-06-12 16:38:45 -07001466 actual := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
Paul Duffin414ea5e2021-03-22 17:31:52 +00001467 android.AssertStringPathsRelativeToTopEquals(t, "LOCAL_COMPATIBILITY_SUPPORT_FILES", ctx.Config(), expected, actual)
Liz Kammerdd849a82020-06-12 16:38:45 -07001468}
Yuexi Ma627263f2021-03-04 13:47:56 -08001469
1470func TestDefaultInstallable(t *testing.T) {
1471 ctx, _ := testJava(t, `
1472 java_test_host {
1473 name: "foo"
1474 }
1475 `)
1476
Colin Cross0c66bc62021-07-20 09:47:41 -07001477 buildOS := ctx.Config().BuildOS.String()
Yuexi Ma627263f2021-03-04 13:47:56 -08001478 module := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
1479 assertDeepEquals(t, "Default installable value should be true.", proptools.BoolPtr(true),
1480 module.properties.Installable)
1481}
Cole Faust75fffb12021-06-13 15:23:16 -07001482
1483func TestErrorproneEnabled(t *testing.T) {
1484 ctx, _ := testJava(t, `
1485 java_library {
1486 name: "foo",
1487 srcs: ["a.java"],
1488 errorprone: {
1489 enabled: true,
1490 },
1491 }
1492 `)
1493
1494 javac := ctx.ModuleForTests("foo", "android_common").Description("javac")
1495
1496 // Test that the errorprone plugins are passed to javac
1497 expectedSubstring := "-Xplugin:ErrorProne"
1498 if !strings.Contains(javac.Args["javacFlags"], expectedSubstring) {
Cole Faust2b1536e2021-06-18 12:25:54 -07001499 t.Errorf("expected javacFlags to contain %q, got %q", expectedSubstring, javac.Args["javacFlags"])
Cole Faust75fffb12021-06-13 15:23:16 -07001500 }
1501
1502 // Modules with errorprone { enabled: true } will include errorprone checks
1503 // in the main javac build rule. Only when RUN_ERROR_PRONE is true will
1504 // the explicit errorprone build rule be created.
1505 errorprone := ctx.ModuleForTests("foo", "android_common").MaybeDescription("errorprone")
1506 if errorprone.RuleParams.Description != "" {
1507 t.Errorf("expected errorprone build rule to not exist, but it did")
1508 }
1509}
Cole Faust2b1536e2021-06-18 12:25:54 -07001510
1511func TestErrorproneDisabled(t *testing.T) {
1512 bp := `
1513 java_library {
1514 name: "foo",
1515 srcs: ["a.java"],
1516 errorprone: {
1517 enabled: false,
1518 },
1519 }
1520 `
1521 ctx := android.GroupFixturePreparers(
1522 PrepareForTestWithJavaDefaultModules,
1523 android.FixtureMergeEnv(map[string]string{
1524 "RUN_ERROR_PRONE": "true",
1525 }),
1526 ).RunTestWithBp(t, bp)
1527
1528 javac := ctx.ModuleForTests("foo", "android_common").Description("javac")
1529
1530 // Test that the errorprone plugins are not passed to javac, like they would
1531 // be if enabled was true.
1532 expectedSubstring := "-Xplugin:ErrorProne"
1533 if strings.Contains(javac.Args["javacFlags"], expectedSubstring) {
1534 t.Errorf("expected javacFlags to not contain %q, got %q", expectedSubstring, javac.Args["javacFlags"])
1535 }
1536
1537 // Check that no errorprone build rule is created, like there would be
1538 // if enabled was unset and RUN_ERROR_PRONE was true.
1539 errorprone := ctx.ModuleForTests("foo", "android_common").MaybeDescription("errorprone")
1540 if errorprone.RuleParams.Description != "" {
1541 t.Errorf("expected errorprone build rule to not exist, but it did")
1542 }
1543}
1544
1545func TestErrorproneEnabledOnlyByEnvironmentVariable(t *testing.T) {
1546 bp := `
1547 java_library {
1548 name: "foo",
1549 srcs: ["a.java"],
1550 }
1551 `
1552 ctx := android.GroupFixturePreparers(
1553 PrepareForTestWithJavaDefaultModules,
1554 android.FixtureMergeEnv(map[string]string{
1555 "RUN_ERROR_PRONE": "true",
1556 }),
1557 ).RunTestWithBp(t, bp)
1558
1559 javac := ctx.ModuleForTests("foo", "android_common").Description("javac")
1560 errorprone := ctx.ModuleForTests("foo", "android_common").Description("errorprone")
1561
1562 // Check that the errorprone plugins are not passed to javac, because they
1563 // will instead be passed to the separate errorprone compilation
1564 expectedSubstring := "-Xplugin:ErrorProne"
1565 if strings.Contains(javac.Args["javacFlags"], expectedSubstring) {
1566 t.Errorf("expected javacFlags to not contain %q, got %q", expectedSubstring, javac.Args["javacFlags"])
1567 }
1568
1569 // Check that the errorprone plugin is enabled
1570 if !strings.Contains(errorprone.Args["javacFlags"], expectedSubstring) {
1571 t.Errorf("expected errorprone to contain %q, got %q", expectedSubstring, javac.Args["javacFlags"])
1572 }
1573}
Sam Delmericob3342ce2022-01-20 21:10:28 +00001574
1575func TestDataDeviceBinsBuildsDeviceBinary(t *testing.T) {
Sam Delmericocc271e22022-06-01 15:45:02 +00001576 testCases := []struct {
1577 dataDeviceBinType string
1578 depCompileMultilib string
1579 variants []string
1580 expectedError string
1581 }{
1582 {
1583 dataDeviceBinType: "first",
1584 depCompileMultilib: "first",
1585 variants: []string{"android_arm64_armv8-a"},
1586 },
1587 {
1588 dataDeviceBinType: "first",
1589 depCompileMultilib: "both",
1590 variants: []string{"android_arm64_armv8-a"},
1591 },
1592 {
1593 // this is true because our testing framework is set up with
1594 // Targets ~ [<64bit target>, <32bit target>], where 64bit is "first"
1595 dataDeviceBinType: "first",
1596 depCompileMultilib: "32",
1597 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1598 },
1599 {
1600 dataDeviceBinType: "first",
1601 depCompileMultilib: "64",
1602 variants: []string{"android_arm64_armv8-a"},
1603 },
1604 {
1605 dataDeviceBinType: "both",
1606 depCompileMultilib: "both",
1607 variants: []string{
1608 "android_arm_armv7-a-neon",
1609 "android_arm64_armv8-a",
1610 },
1611 },
1612 {
1613 dataDeviceBinType: "both",
1614 depCompileMultilib: "32",
1615 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1616 },
1617 {
1618 dataDeviceBinType: "both",
1619 depCompileMultilib: "64",
1620 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1621 },
1622 {
1623 dataDeviceBinType: "both",
1624 depCompileMultilib: "first",
1625 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1626 },
1627 {
1628 dataDeviceBinType: "32",
1629 depCompileMultilib: "32",
1630 variants: []string{"android_arm_armv7-a-neon"},
1631 },
1632 {
1633 dataDeviceBinType: "32",
1634 depCompileMultilib: "first",
1635 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1636 },
1637 {
1638 dataDeviceBinType: "32",
1639 depCompileMultilib: "both",
1640 variants: []string{"android_arm_armv7-a-neon"},
1641 },
1642 {
1643 dataDeviceBinType: "32",
1644 depCompileMultilib: "64",
1645 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1646 },
1647 {
1648 dataDeviceBinType: "64",
1649 depCompileMultilib: "64",
1650 variants: []string{"android_arm64_armv8-a"},
1651 },
1652 {
1653 dataDeviceBinType: "64",
1654 depCompileMultilib: "both",
1655 variants: []string{"android_arm64_armv8-a"},
1656 },
1657 {
1658 dataDeviceBinType: "64",
1659 depCompileMultilib: "first",
1660 variants: []string{"android_arm64_armv8-a"},
1661 },
1662 {
1663 dataDeviceBinType: "64",
1664 depCompileMultilib: "32",
1665 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1666 },
1667 {
1668 dataDeviceBinType: "prefer32",
1669 depCompileMultilib: "32",
1670 variants: []string{"android_arm_armv7-a-neon"},
1671 },
1672 {
1673 dataDeviceBinType: "prefer32",
1674 depCompileMultilib: "both",
1675 variants: []string{"android_arm_armv7-a-neon"},
1676 },
1677 {
1678 dataDeviceBinType: "prefer32",
1679 depCompileMultilib: "first",
1680 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1681 },
1682 {
1683 dataDeviceBinType: "prefer32",
1684 depCompileMultilib: "64",
1685 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1686 },
Sam Delmericob3342ce2022-01-20 21:10:28 +00001687 }
Sam Delmericob3342ce2022-01-20 21:10:28 +00001688
Sam Delmericocc271e22022-06-01 15:45:02 +00001689 bpTemplate := `
Sam Delmericob3342ce2022-01-20 21:10:28 +00001690 java_test_host {
1691 name: "foo",
1692 srcs: ["test.java"],
Sam Delmericocc271e22022-06-01 15:45:02 +00001693 data_device_bins_%s: ["bar"],
Sam Delmericob3342ce2022-01-20 21:10:28 +00001694 }
1695
1696 cc_binary {
1697 name: "bar",
Sam Delmericocc271e22022-06-01 15:45:02 +00001698 compile_multilib: "%s",
Sam Delmericob3342ce2022-01-20 21:10:28 +00001699 }
1700 `
1701
Sam Delmericocc271e22022-06-01 15:45:02 +00001702 for _, tc := range testCases {
1703 bp := fmt.Sprintf(bpTemplate, tc.dataDeviceBinType, tc.depCompileMultilib)
Sam Delmericob3342ce2022-01-20 21:10:28 +00001704
Sam Delmericocc271e22022-06-01 15:45:02 +00001705 errorHandler := android.FixtureExpectsNoErrors
1706 if tc.expectedError != "" {
1707 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(tc.expectedError)
1708 }
Sam Delmericob3342ce2022-01-20 21:10:28 +00001709
Sam Delmericocc271e22022-06-01 15:45:02 +00001710 testName := fmt.Sprintf(`data_device_bins_%s with compile_multilib:"%s"`, tc.dataDeviceBinType, tc.depCompileMultilib)
1711 t.Run(testName, func(t *testing.T) {
1712 ctx := android.GroupFixturePreparers(PrepareForIntegrationTestWithJava).
1713 ExtendWithErrorHandler(errorHandler).
1714 RunTestWithBp(t, bp)
1715 if tc.expectedError != "" {
1716 return
1717 }
1718
1719 buildOS := ctx.Config.BuildOS.String()
1720 fooVariant := ctx.ModuleForTests("foo", buildOS+"_common")
1721 fooMod := fooVariant.Module().(*TestHost)
1722 entries := android.AndroidMkEntriesForTest(t, ctx.TestContext, fooMod)[0]
1723
1724 expectedAutogenConfig := `<option name="push-file" key="bar" value="/data/local/tests/unrestricted/foo/bar" />`
1725 autogen := fooVariant.Rule("autogen")
1726 if !strings.Contains(autogen.Args["extraConfigs"], expectedAutogenConfig) {
1727 t.Errorf("foo extraConfigs %v does not contain %q", autogen.Args["extraConfigs"], expectedAutogenConfig)
1728 }
1729
1730 expectedData := []string{}
1731 for _, variant := range tc.variants {
1732 barVariant := ctx.ModuleForTests("bar", variant)
1733 relocated := barVariant.Output("bar")
1734 expectedInput := fmt.Sprintf("out/soong/.intermediates/bar/%s/unstripped/bar", variant)
1735 android.AssertPathRelativeToTopEquals(t, "relocation input", expectedInput, relocated.Input)
1736
1737 expectedData = append(expectedData, fmt.Sprintf("out/soong/.intermediates/bar/%s/bar:bar", variant))
1738 }
1739
1740 actualData := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
1741 android.AssertStringPathsRelativeToTopEquals(t, "LOCAL_TEST_DATA", ctx.Config, expectedData, actualData)
1742 })
Sam Delmericob3342ce2022-01-20 21:10:28 +00001743 }
1744}
Sam Delmerico277795c2022-02-25 17:04:37 +00001745
1746func TestImportMixedBuild(t *testing.T) {
1747 bp := `
1748 java_import {
1749 name: "baz",
1750 jars: [
1751 "test1.jar",
1752 "test2.jar",
1753 ],
1754 bazel_module: { label: "//foo/bar:baz" },
1755 }
1756 `
1757
1758 ctx := android.GroupFixturePreparers(
1759 prepareForJavaTest,
1760 android.FixtureModifyConfig(func(config android.Config) {
1761 config.BazelContext = android.MockBazelContext{
1762 OutputBaseDir: "outputbase",
1763 LabelToOutputFiles: map[string][]string{
1764 "//foo/bar:baz": []string{"test1.jar", "test2.jar"},
1765 },
1766 }
1767 }),
1768 ).RunTestWithBp(t, bp)
1769
1770 bazMod := ctx.ModuleForTests("baz", "android_common").Module()
1771 producer := bazMod.(android.OutputFileProducer)
1772 expectedOutputFiles := []string{".intermediates/baz/android_common/bazelCombined/baz.jar"}
1773
1774 outputFiles, err := producer.OutputFiles("")
1775 if err != nil {
1776 t.Errorf("Unexpected error getting java_import outputfiles %s", err)
1777 }
1778 actualOutputFiles := android.NormalizePathsForTesting(outputFiles)
1779 android.AssertDeepEquals(t, "Output files are produced", expectedOutputFiles, actualOutputFiles)
1780
1781 javaInfoProvider := ctx.ModuleProvider(bazMod, JavaInfoProvider)
1782 javaInfo, ok := javaInfoProvider.(JavaInfo)
1783 if !ok {
1784 t.Error("could not get JavaInfo from java_import module")
1785 }
1786 android.AssertDeepEquals(t, "Header JARs are produced", expectedOutputFiles, android.NormalizePathsForTesting(javaInfo.HeaderJars))
1787 android.AssertDeepEquals(t, "Implementation/Resources JARs are produced", expectedOutputFiles, android.NormalizePathsForTesting(javaInfo.ImplementationAndResourcesJars))
1788 android.AssertDeepEquals(t, "Implementation JARs are produced", expectedOutputFiles, android.NormalizePathsForTesting(javaInfo.ImplementationJars))
1789}
Sam Delmerico2351eac2022-05-24 17:10:02 +00001790
1791func TestGenAidlIncludeFlagsForMixedBuilds(t *testing.T) {
1792 bazelOutputBaseDir := filepath.Join("out", "bazel")
1793 result := android.GroupFixturePreparers(
1794 PrepareForIntegrationTestWithJava,
1795 android.FixtureModifyConfig(func(config android.Config) {
1796 config.BazelContext = android.MockBazelContext{
1797 OutputBaseDir: bazelOutputBaseDir,
1798 }
1799 }),
1800 ).RunTest(t)
1801
1802 ctx := &android.TestPathContext{TestResult: result}
1803
1804 srcDirectory := filepath.Join("frameworks", "base")
1805 srcDirectoryAlreadyIncluded := filepath.Join("frameworks", "base", "core", "java")
1806 bazelSrcDirectory := android.PathForBazelOut(ctx, srcDirectory)
1807 bazelSrcDirectoryAlreadyIncluded := android.PathForBazelOut(ctx, srcDirectoryAlreadyIncluded)
1808 srcs := android.Paths{
1809 android.PathForTestingWithRel(bazelSrcDirectory.String(), "bazelAidl.aidl"),
1810 android.PathForTestingWithRel(bazelSrcDirectory.String(), "bazelAidl2.aidl"),
1811 android.PathForTestingWithRel(bazelSrcDirectoryAlreadyIncluded.String(), "bazelAidlExclude.aidl"),
1812 android.PathForTestingWithRel(bazelSrcDirectoryAlreadyIncluded.String(), "bazelAidl2Exclude.aidl"),
1813 }
1814 dirsAlreadyIncluded := android.Paths{
1815 android.PathForTesting(srcDirectoryAlreadyIncluded),
1816 }
1817
1818 expectedFlags := " -Iout/bazel/execroot/__main__/frameworks/base"
1819 flags := genAidlIncludeFlags(ctx, srcs, dirsAlreadyIncluded)
1820 if flags != expectedFlags {
1821 t.Errorf("expected flags to be %q; was %q", expectedFlags, flags)
1822 }
1823}
Zi Wangca65b402022-10-10 13:45:06 -07001824
1825func TestDeviceBinaryWrapperGeneration(t *testing.T) {
1826 // Scenario 1: java_binary has main_class property in its bp
1827 ctx, _ := testJava(t, `
1828 java_binary {
1829 name: "foo",
1830 srcs: ["foo.java"],
1831 main_class: "foo.bar.jb",
1832 }
1833 `)
1834 wrapperPath := fmt.Sprint(ctx.ModuleForTests("foo", "android_arm64_armv8-a").AllOutputs())
1835 if !strings.Contains(wrapperPath, "foo.sh") {
1836 t.Errorf("wrapper file foo.sh is not generated")
1837 }
1838
1839 // Scenario 2: java_binary has neither wrapper nor main_class, its build
1840 // is expected to be failed.
1841 testJavaError(t, "main_class property is required for device binary if no default wrapper is assigned", `
1842 java_binary {
1843 name: "foo",
1844 srcs: ["foo.java"],
1845 }`)
1846}
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001847
Jihoon Kang3198f3c2023-01-26 08:08:52 +00001848func TestJavaApiContributionEmptyApiFile(t *testing.T) {
Jihoon Kang063ec002023-06-28 01:16:23 +00001849 android.GroupFixturePreparers(
1850 prepareForJavaTest,
1851 android.FixtureMergeEnv(
1852 map[string]string{
1853 "DISABLE_STUB_VALIDATION": "true",
1854 },
1855 ),
1856 ).ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(
Jihoon Kang3198f3c2023-01-26 08:08:52 +00001857 "Error: foo has an empty api file.",
Jihoon Kang063ec002023-06-28 01:16:23 +00001858 )).RunTestWithBp(t, `
1859 java_api_contribution {
Jihoon Kang3198f3c2023-01-26 08:08:52 +00001860 name: "foo",
1861 }
1862 java_api_library {
1863 name: "bar",
1864 api_surface: "public",
1865 api_contributions: ["foo"],
1866 }
1867 `)
1868}
1869
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001870func TestJavaApiLibraryAndProviderLink(t *testing.T) {
1871 provider_bp_a := `
1872 java_api_contribution {
1873 name: "foo1",
Jihoon Kang84473f52023-08-11 22:36:33 +00001874 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00001875 api_surface: "public",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001876 }
1877 `
1878 provider_bp_b := `java_api_contribution {
1879 name: "foo2",
Jihoon Kang84473f52023-08-11 22:36:33 +00001880 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00001881 api_surface: "public",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001882 }
1883 `
Jihoon Kang063ec002023-06-28 01:16:23 +00001884 ctx := android.GroupFixturePreparers(
1885 prepareForJavaTest,
1886 android.FixtureMergeMockFs(
1887 map[string][]byte{
1888 "a/Android.bp": []byte(provider_bp_a),
1889 "b/Android.bp": []byte(provider_bp_b),
1890 },
1891 ),
1892 android.FixtureMergeEnv(
1893 map[string]string{
1894 "DISABLE_STUB_VALIDATION": "true",
1895 },
1896 ),
1897 ).RunTestWithBp(t, `
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001898 java_api_library {
1899 name: "bar1",
1900 api_surface: "public",
Jihoon Kang60d4a092022-11-17 23:47:43 +00001901 api_contributions: ["foo1"],
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001902 }
1903
1904 java_api_library {
1905 name: "bar2",
1906 api_surface: "system",
Jihoon Kang60d4a092022-11-17 23:47:43 +00001907 api_contributions: ["foo1", "foo2"],
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001908 }
Jihoon Kang063ec002023-06-28 01:16:23 +00001909 `)
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001910
1911 testcases := []struct {
1912 moduleName string
1913 sourceTextFileDirs []string
1914 }{
1915 {
1916 moduleName: "bar1",
Jihoon Kang84473f52023-08-11 22:36:33 +00001917 sourceTextFileDirs: []string{"a/current.txt"},
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001918 },
1919 {
1920 moduleName: "bar2",
Jihoon Kang6be0f002023-09-20 23:03:01 +00001921 sourceTextFileDirs: []string{"a/current.txt", "b/current.txt"},
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001922 },
1923 }
1924 for _, c := range testcases {
1925 m := ctx.ModuleForTests(c.moduleName, "android_common")
1926 manifest := m.Output("metalava.sbox.textproto")
Colin Crossf61d03d2023-11-02 16:56:39 -07001927 sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx.TestContext, manifest)
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001928 manifestCommand := sboxProto.Commands[0].GetCommand()
1929 sourceFilesFlag := "--source-files " + strings.Join(c.sourceTextFileDirs, " ")
1930 android.AssertStringDoesContain(t, "source text files not present", manifestCommand, sourceFilesFlag)
1931 }
1932}
1933
Jihoon Kang1c51f502023-01-09 23:42:40 +00001934func TestJavaApiLibraryAndDefaultsLink(t *testing.T) {
Jihoon Kang362aa9d2023-01-20 19:44:07 +00001935 provider_bp_a := `
1936 java_api_contribution {
Jihoon Kang1c51f502023-01-09 23:42:40 +00001937 name: "foo1",
Jihoon Kang84473f52023-08-11 22:36:33 +00001938 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00001939 api_surface: "public",
Jihoon Kang1c51f502023-01-09 23:42:40 +00001940 }
1941 `
Jihoon Kang362aa9d2023-01-20 19:44:07 +00001942 provider_bp_b := `
1943 java_api_contribution {
Jihoon Kang1c51f502023-01-09 23:42:40 +00001944 name: "foo2",
Jihoon Kang84473f52023-08-11 22:36:33 +00001945 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00001946 api_surface: "public",
Jihoon Kang1c51f502023-01-09 23:42:40 +00001947 }
1948 `
Jihoon Kang362aa9d2023-01-20 19:44:07 +00001949 provider_bp_c := `
1950 java_api_contribution {
Jihoon Kang1c51f502023-01-09 23:42:40 +00001951 name: "foo3",
Jihoon Kang8fe19822023-09-14 06:27:36 +00001952 api_file: "system-current.txt",
1953 api_surface: "system",
Jihoon Kang1c51f502023-01-09 23:42:40 +00001954 }
1955 `
Jihoon Kang362aa9d2023-01-20 19:44:07 +00001956 provider_bp_d := `
1957 java_api_contribution {
Jihoon Kang1c51f502023-01-09 23:42:40 +00001958 name: "foo4",
Jihoon Kang8fe19822023-09-14 06:27:36 +00001959 api_file: "system-current.txt",
1960 api_surface: "system",
Jihoon Kang1c51f502023-01-09 23:42:40 +00001961 }
1962 `
Jihoon Kang063ec002023-06-28 01:16:23 +00001963 ctx := android.GroupFixturePreparers(
1964 prepareForJavaTest,
1965 android.FixtureMergeMockFs(
1966 map[string][]byte{
1967 "a/Android.bp": []byte(provider_bp_a),
1968 "b/Android.bp": []byte(provider_bp_b),
1969 "c/Android.bp": []byte(provider_bp_c),
1970 "d/Android.bp": []byte(provider_bp_d),
1971 },
1972 ),
1973 android.FixtureMergeEnv(
1974 map[string]string{
1975 "DISABLE_STUB_VALIDATION": "true",
1976 },
1977 ),
1978 ).RunTestWithBp(t, `
Jihoon Kang1c51f502023-01-09 23:42:40 +00001979 java_defaults {
1980 name: "baz1",
1981 api_surface: "public",
1982 api_contributions: ["foo1", "foo2"],
1983 }
1984
1985 java_defaults {
1986 name: "baz2",
1987 api_surface: "system",
1988 api_contributions: ["foo3"],
1989 }
1990
1991 java_api_library {
1992 name: "bar1",
1993 api_surface: "public",
1994 api_contributions: ["foo1"],
1995 }
1996
1997 java_api_library {
1998 name: "bar2",
1999 api_surface: "public",
2000 defaults:["baz1"],
2001 }
2002
2003 java_api_library {
2004 name: "bar3",
2005 api_surface: "system",
2006 defaults:["baz1", "baz2"],
2007 api_contributions: ["foo4"],
Jihoon Kang1c51f502023-01-09 23:42:40 +00002008 }
Jihoon Kang063ec002023-06-28 01:16:23 +00002009 `)
Jihoon Kang1c51f502023-01-09 23:42:40 +00002010
2011 testcases := []struct {
2012 moduleName string
2013 sourceTextFileDirs []string
2014 }{
2015 {
2016 moduleName: "bar1",
Jihoon Kang84473f52023-08-11 22:36:33 +00002017 sourceTextFileDirs: []string{"a/current.txt"},
Jihoon Kang1c51f502023-01-09 23:42:40 +00002018 },
2019 {
2020 moduleName: "bar2",
Jihoon Kang84473f52023-08-11 22:36:33 +00002021 sourceTextFileDirs: []string{"a/current.txt", "b/current.txt"},
Jihoon Kang1c51f502023-01-09 23:42:40 +00002022 },
2023 {
Jihoon Kang8fe19822023-09-14 06:27:36 +00002024 moduleName: "bar3",
2025 // API text files need to be sorted from the narrower api scope to the wider api scope
Jihoon Kang6be0f002023-09-20 23:03:01 +00002026 sourceTextFileDirs: []string{"a/current.txt", "b/current.txt", "c/system-current.txt", "d/system-current.txt"},
Jihoon Kang1c51f502023-01-09 23:42:40 +00002027 },
2028 }
2029 for _, c := range testcases {
2030 m := ctx.ModuleForTests(c.moduleName, "android_common")
2031 manifest := m.Output("metalava.sbox.textproto")
Colin Crossf61d03d2023-11-02 16:56:39 -07002032 sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx.TestContext, manifest)
Jihoon Kang1c51f502023-01-09 23:42:40 +00002033 manifestCommand := sboxProto.Commands[0].GetCommand()
2034 sourceFilesFlag := "--source-files " + strings.Join(c.sourceTextFileDirs, " ")
2035 android.AssertStringDoesContain(t, "source text files not present", manifestCommand, sourceFilesFlag)
2036 }
2037}
2038
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002039func TestJavaApiLibraryJarGeneration(t *testing.T) {
2040 provider_bp_a := `
2041 java_api_contribution {
2042 name: "foo1",
Jihoon Kang84473f52023-08-11 22:36:33 +00002043 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002044 api_surface: "public",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002045 }
2046 `
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002047 provider_bp_b := `
2048 java_api_contribution {
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002049 name: "foo2",
Jihoon Kang84473f52023-08-11 22:36:33 +00002050 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002051 api_surface: "public",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002052 }
2053 `
Jihoon Kang063ec002023-06-28 01:16:23 +00002054 ctx := android.GroupFixturePreparers(
2055 prepareForJavaTest,
2056 android.FixtureMergeMockFs(
2057 map[string][]byte{
2058 "a/Android.bp": []byte(provider_bp_a),
2059 "b/Android.bp": []byte(provider_bp_b),
2060 },
2061 ),
2062 android.FixtureMergeEnv(
2063 map[string]string{
2064 "DISABLE_STUB_VALIDATION": "true",
2065 },
2066 ),
2067 ).RunTestWithBp(t, `
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002068 java_api_library {
2069 name: "bar1",
2070 api_surface: "public",
Jihoon Kang60d4a092022-11-17 23:47:43 +00002071 api_contributions: ["foo1"],
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002072 }
2073
2074 java_api_library {
2075 name: "bar2",
2076 api_surface: "system",
Jihoon Kang60d4a092022-11-17 23:47:43 +00002077 api_contributions: ["foo1", "foo2"],
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002078 }
Jihoon Kang063ec002023-06-28 01:16:23 +00002079 `)
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002080
2081 testcases := []struct {
2082 moduleName string
2083 outputJarName string
2084 }{
2085 {
2086 moduleName: "bar1",
Jihoon Kang25857f52023-03-01 00:27:32 +00002087 outputJarName: "bar1/bar1.jar",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002088 },
2089 {
2090 moduleName: "bar2",
Jihoon Kang25857f52023-03-01 00:27:32 +00002091 outputJarName: "bar2/bar2.jar",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002092 },
2093 }
2094 for _, c := range testcases {
2095 m := ctx.ModuleForTests(c.moduleName, "android_common")
2096 outputs := fmt.Sprint(m.AllOutputs())
2097 if !strings.Contains(outputs, c.outputJarName) {
2098 t.Errorf("Module output does not contain expected jar %s", c.outputJarName)
2099 }
2100 }
2101}
Cole Faust21680542022-12-07 18:18:37 -08002102
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002103func TestJavaApiLibraryLibsLink(t *testing.T) {
2104 provider_bp_a := `
2105 java_api_contribution {
2106 name: "foo1",
Jihoon Kang84473f52023-08-11 22:36:33 +00002107 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002108 api_surface: "public",
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002109 }
2110 `
2111 provider_bp_b := `
2112 java_api_contribution {
2113 name: "foo2",
Jihoon Kang84473f52023-08-11 22:36:33 +00002114 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002115 api_surface: "public",
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002116 }
2117 `
2118 lib_bp_a := `
2119 java_library {
2120 name: "lib1",
2121 srcs: ["Lib.java"],
2122 }
2123 `
2124 lib_bp_b := `
2125 java_library {
2126 name: "lib2",
2127 srcs: ["Lib.java"],
2128 }
2129 `
2130
Jihoon Kang063ec002023-06-28 01:16:23 +00002131 ctx := android.GroupFixturePreparers(
2132 prepareForJavaTest,
2133 android.FixtureMergeMockFs(
2134 map[string][]byte{
2135 "a/Android.bp": []byte(provider_bp_a),
2136 "b/Android.bp": []byte(provider_bp_b),
2137 "c/Android.bp": []byte(lib_bp_a),
2138 "c/Lib.java": {},
2139 "d/Android.bp": []byte(lib_bp_b),
2140 "d/Lib.java": {},
2141 },
2142 ),
2143 android.FixtureMergeEnv(
2144 map[string]string{
2145 "DISABLE_STUB_VALIDATION": "true",
2146 },
2147 ),
2148 ).RunTestWithBp(t, `
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002149 java_api_library {
2150 name: "bar1",
2151 api_surface: "public",
2152 api_contributions: ["foo1"],
2153 libs: ["lib1"],
2154 }
2155
2156 java_api_library {
2157 name: "bar2",
2158 api_surface: "system",
2159 api_contributions: ["foo1", "foo2"],
2160 libs: ["lib1", "lib2", "bar1"],
2161 }
Jihoon Kang063ec002023-06-28 01:16:23 +00002162 `)
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002163
2164 testcases := []struct {
2165 moduleName string
2166 classPathJarNames []string
2167 }{
2168 {
2169 moduleName: "bar1",
2170 classPathJarNames: []string{"lib1.jar"},
2171 },
2172 {
2173 moduleName: "bar2",
Jihoon Kang25857f52023-03-01 00:27:32 +00002174 classPathJarNames: []string{"lib1.jar", "lib2.jar", "bar1/bar1.jar"},
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002175 },
2176 }
2177 for _, c := range testcases {
2178 m := ctx.ModuleForTests(c.moduleName, "android_common")
2179 javacRules := m.Rule("javac")
2180 classPathArgs := javacRules.Args["classpath"]
2181 for _, jarName := range c.classPathJarNames {
2182 if !strings.Contains(classPathArgs, jarName) {
2183 t.Errorf("Module output does not contain expected jar %s", jarName)
2184 }
2185 }
2186 }
2187}
2188
Jihoon Kange30fff02023-02-14 20:18:20 +00002189func TestJavaApiLibraryStaticLibsLink(t *testing.T) {
2190 provider_bp_a := `
2191 java_api_contribution {
2192 name: "foo1",
Jihoon Kang84473f52023-08-11 22:36:33 +00002193 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002194 api_surface: "public",
Jihoon Kange30fff02023-02-14 20:18:20 +00002195 }
2196 `
2197 provider_bp_b := `
2198 java_api_contribution {
2199 name: "foo2",
Jihoon Kang84473f52023-08-11 22:36:33 +00002200 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002201 api_surface: "public",
Jihoon Kange30fff02023-02-14 20:18:20 +00002202 }
2203 `
2204 lib_bp_a := `
2205 java_library {
2206 name: "lib1",
2207 srcs: ["Lib.java"],
2208 }
2209 `
2210 lib_bp_b := `
2211 java_library {
2212 name: "lib2",
2213 srcs: ["Lib.java"],
2214 }
2215 `
2216
Jihoon Kang063ec002023-06-28 01:16:23 +00002217 ctx := android.GroupFixturePreparers(
2218 prepareForJavaTest,
2219 android.FixtureMergeMockFs(
2220 map[string][]byte{
2221 "a/Android.bp": []byte(provider_bp_a),
2222 "b/Android.bp": []byte(provider_bp_b),
2223 "c/Android.bp": []byte(lib_bp_a),
2224 "c/Lib.java": {},
2225 "d/Android.bp": []byte(lib_bp_b),
2226 "d/Lib.java": {},
2227 },
2228 ),
2229 android.FixtureMergeEnv(
2230 map[string]string{
2231 "DISABLE_STUB_VALIDATION": "true",
2232 },
2233 ),
2234 ).RunTestWithBp(t, `
Jihoon Kange30fff02023-02-14 20:18:20 +00002235 java_api_library {
2236 name: "bar1",
2237 api_surface: "public",
2238 api_contributions: ["foo1"],
2239 static_libs: ["lib1"],
2240 }
2241
2242 java_api_library {
2243 name: "bar2",
2244 api_surface: "system",
2245 api_contributions: ["foo1", "foo2"],
2246 static_libs: ["lib1", "lib2", "bar1"],
2247 }
Jihoon Kang063ec002023-06-28 01:16:23 +00002248 `)
Jihoon Kange30fff02023-02-14 20:18:20 +00002249
2250 testcases := []struct {
2251 moduleName string
2252 staticLibJarNames []string
2253 }{
2254 {
2255 moduleName: "bar1",
2256 staticLibJarNames: []string{"lib1.jar"},
2257 },
2258 {
2259 moduleName: "bar2",
Jihoon Kang25857f52023-03-01 00:27:32 +00002260 staticLibJarNames: []string{"lib1.jar", "lib2.jar", "bar1/bar1.jar"},
Jihoon Kange30fff02023-02-14 20:18:20 +00002261 },
2262 }
2263 for _, c := range testcases {
2264 m := ctx.ModuleForTests(c.moduleName, "android_common")
2265 mergeZipsCommand := m.Rule("merge_zips").RuleParams.Command
2266 for _, jarName := range c.staticLibJarNames {
2267 if !strings.Contains(mergeZipsCommand, jarName) {
2268 t.Errorf("merge_zips command does not contain expected jar %s", jarName)
2269 }
2270 }
2271 }
2272}
2273
Jihoon Kangca198c22023-06-22 23:13:51 +00002274func TestJavaApiLibraryFullApiSurfaceStub(t *testing.T) {
Jihoon Kang01e522c2023-03-14 01:09:34 +00002275 provider_bp_a := `
2276 java_api_contribution {
2277 name: "foo1",
Jihoon Kang84473f52023-08-11 22:36:33 +00002278 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002279 api_surface: "public",
Jihoon Kang01e522c2023-03-14 01:09:34 +00002280 }
2281 `
2282 provider_bp_b := `
2283 java_api_contribution {
2284 name: "foo2",
Jihoon Kang84473f52023-08-11 22:36:33 +00002285 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002286 api_surface: "public",
Jihoon Kang01e522c2023-03-14 01:09:34 +00002287 }
2288 `
2289 lib_bp_a := `
2290 java_api_library {
2291 name: "lib1",
2292 api_surface: "public",
2293 api_contributions: ["foo1", "foo2"],
2294 }
2295 `
2296
Jihoon Kang063ec002023-06-28 01:16:23 +00002297 ctx := android.GroupFixturePreparers(
2298 prepareForJavaTest,
2299 android.FixtureMergeMockFs(
2300 map[string][]byte{
2301 "a/Android.bp": []byte(provider_bp_a),
2302 "b/Android.bp": []byte(provider_bp_b),
2303 "c/Android.bp": []byte(lib_bp_a),
2304 },
2305 ),
2306 android.FixtureMergeEnv(
2307 map[string]string{
2308 "DISABLE_STUB_VALIDATION": "true",
2309 },
2310 ),
2311 ).RunTestWithBp(t, `
Jihoon Kang01e522c2023-03-14 01:09:34 +00002312 java_api_library {
2313 name: "bar1",
2314 api_surface: "public",
2315 api_contributions: ["foo1"],
Jihoon Kangca198c22023-06-22 23:13:51 +00002316 full_api_surface_stub: "lib1",
Jihoon Kang01e522c2023-03-14 01:09:34 +00002317 }
Jihoon Kang063ec002023-06-28 01:16:23 +00002318 `)
Jihoon Kang01e522c2023-03-14 01:09:34 +00002319
2320 m := ctx.ModuleForTests("bar1", "android_common")
2321 manifest := m.Output("metalava.sbox.textproto")
Colin Crossf61d03d2023-11-02 16:56:39 -07002322 sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx.TestContext, manifest)
Jihoon Kang01e522c2023-03-14 01:09:34 +00002323 manifestCommand := sboxProto.Commands[0].GetCommand()
Jihoon Kangca198c22023-06-22 23:13:51 +00002324 android.AssertStringDoesContain(t, "Command expected to contain full_api_surface_stub output jar", manifestCommand, "lib1.jar")
Jihoon Kang01e522c2023-03-14 01:09:34 +00002325}
2326
Anton Hansson0e73f9e2023-09-20 13:39:57 +00002327func TestTransitiveSrcFiles(t *testing.T) {
2328 ctx, _ := testJava(t, `
2329 java_library {
2330 name: "a",
2331 srcs: ["a.java"],
2332 }
2333 java_library {
2334 name: "b",
2335 srcs: ["b.java"],
2336 }
2337 java_library {
2338 name: "c",
2339 srcs: ["c.java"],
2340 libs: ["a"],
2341 static_libs: ["b"],
2342 }
2343 `)
2344 c := ctx.ModuleForTests("c", "android_common").Module()
2345 transitiveSrcFiles := android.Paths(ctx.ModuleProvider(c, JavaInfoProvider).(JavaInfo).TransitiveSrcFiles.ToList())
2346 android.AssertArrayString(t, "unexpected jar deps", []string{"b.java", "c.java"}, transitiveSrcFiles.Strings())
2347}
2348
Cole Faust21680542022-12-07 18:18:37 -08002349func TestTradefedOptions(t *testing.T) {
2350 result := PrepareForTestWithJavaBuildComponents.RunTestWithBp(t, `
2351java_test_host {
2352 name: "foo",
2353 test_options: {
2354 tradefed_options: [
2355 {
2356 name: "exclude-path",
2357 value: "org/apache"
2358 }
2359 ]
2360 }
2361}
2362`)
2363
2364 buildOS := result.Config.BuildOS.String()
2365 args := result.ModuleForTests("foo", buildOS+"_common").
2366 Output("out/soong/.intermediates/foo/" + buildOS + "_common/foo.config").Args
2367 expected := proptools.NinjaAndShellEscape("<option name=\"exclude-path\" value=\"org/apache\" />")
2368 if args["extraConfigs"] != expected {
2369 t.Errorf("Expected args[\"extraConfigs\"] to equal %q, was %q", expected, args["extraConfigs"])
2370 }
2371}
Dan Shiec731432023-05-26 04:21:44 +00002372
2373func TestTestRunnerOptions(t *testing.T) {
2374 result := PrepareForTestWithJavaBuildComponents.RunTestWithBp(t, `
2375java_test_host {
2376 name: "foo",
2377 test_options: {
2378 test_runner_options: [
2379 {
2380 name: "test-timeout",
2381 value: "10m"
2382 }
2383 ]
2384 }
2385}
2386`)
2387
2388 buildOS := result.Config.BuildOS.String()
2389 args := result.ModuleForTests("foo", buildOS+"_common").
2390 Output("out/soong/.intermediates/foo/" + buildOS + "_common/foo.config").Args
2391 expected := proptools.NinjaAndShellEscape("<option name=\"test-timeout\" value=\"10m\" />\\n ")
2392 if args["extraTestRunnerConfigs"] != expected {
2393 t.Errorf("Expected args[\"extraTestRunnerConfigs\"] to equal %q, was %q", expected, args["extraTestRunnerConfigs"])
2394 }
2395}
Jihoon Kang381c2fa2023-06-01 22:17:32 +00002396
2397func TestJavaExcludeStaticLib(t *testing.T) {
2398 ctx, _ := testJava(t, `
2399 java_library {
2400 name: "bar",
2401 }
2402 java_library {
2403 name: "foo",
2404 }
2405 java_library {
2406 name: "baz",
2407 static_libs: [
2408 "foo",
2409 "bar",
2410 ],
2411 exclude_static_libs: [
2412 "bar",
2413 ],
2414 }
2415 `)
2416
2417 // "bar" not included as dependency of "baz"
2418 CheckModuleDependencies(t, ctx, "baz", "android_common", []string{
2419 `core-lambda-stubs`,
2420 `ext`,
2421 `foo`,
2422 `framework`,
2423 `stable-core-platform-api-stubs-system-modules`,
2424 `stable.core.platform.api.stubs`,
2425 })
2426}
Jihoon Kang1bfb6f22023-07-01 00:13:47 +00002427
2428func TestJavaLibraryWithResourcesStem(t *testing.T) {
2429 ctx, _ := testJavaWithFS(t, `
2430 java_library {
2431 name: "foo",
2432 java_resource_dirs: ["test-jar"],
2433 stem: "test",
2434 }
2435 `,
2436 map[string][]byte{
2437 "test-jar/test/resource.txt": nil,
2438 })
2439
2440 m := ctx.ModuleForTests("foo", "android_common")
2441 outputs := fmt.Sprint(m.AllOutputs())
2442 if !strings.Contains(outputs, "test.jar") {
2443 t.Errorf("Module output does not contain expected jar %s", "test.jar")
2444 }
2445}
Mark Whitea15790a2023-08-22 21:28:11 +00002446
2447func TestHeadersOnly(t *testing.T) {
2448 ctx, _ := testJava(t, `
2449 java_library {
2450 name: "foo",
2451 srcs: ["a.java"],
2452 headers_only: true,
2453 }
2454 `)
2455
2456 turbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine")
2457 if len(turbine.Inputs) != 1 || turbine.Inputs[0].String() != "a.java" {
2458 t.Errorf(`foo inputs %v != ["a.java"]`, turbine.Inputs)
2459 }
2460
2461 javac := ctx.ModuleForTests("foo", "android_common").MaybeRule("javac")
2462 android.AssertDeepEquals(t, "javac rule", nil, javac.Rule)
2463}
Jihoon Kangfdf32362023-09-12 00:36:43 +00002464
2465func TestJavaApiContributionImport(t *testing.T) {
Jihoon Kang063ec002023-06-28 01:16:23 +00002466 ctx := android.GroupFixturePreparers(
2467 prepareForJavaTest,
2468 android.FixtureMergeEnv(
2469 map[string]string{
2470 "DISABLE_STUB_VALIDATION": "true",
2471 },
2472 ),
2473 ).RunTestWithBp(t, `
Jihoon Kangfdf32362023-09-12 00:36:43 +00002474 java_api_library {
2475 name: "foo",
2476 api_contributions: ["bar"],
2477 }
2478 java_api_contribution_import {
2479 name: "bar",
2480 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002481 api_surface: "public",
Jihoon Kangfdf32362023-09-12 00:36:43 +00002482 }
2483 `)
2484 m := ctx.ModuleForTests("foo", "android_common")
2485 manifest := m.Output("metalava.sbox.textproto")
Colin Crossf61d03d2023-11-02 16:56:39 -07002486 sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx.TestContext, manifest)
Jihoon Kangfdf32362023-09-12 00:36:43 +00002487 manifestCommand := sboxProto.Commands[0].GetCommand()
2488 sourceFilesFlag := "--source-files current.txt"
2489 android.AssertStringDoesContain(t, "source text files not present", manifestCommand, sourceFilesFlag)
2490}
Jihoon Kanga96a7b12023-09-20 23:43:32 +00002491
2492func TestJavaApiLibraryApiFilesSorting(t *testing.T) {
2493 ctx, _ := testJava(t, `
2494 java_api_library {
2495 name: "foo",
2496 api_contributions: [
2497 "system-server-api-stubs-docs-non-updatable.api.contribution",
2498 "test-api-stubs-docs-non-updatable.api.contribution",
2499 "system-api-stubs-docs-non-updatable.api.contribution",
2500 "module-lib-api-stubs-docs-non-updatable.api.contribution",
2501 "api-stubs-docs-non-updatable.api.contribution",
2502 ],
2503 }
2504 `)
2505 m := ctx.ModuleForTests("foo", "android_common")
2506 manifest := m.Output("metalava.sbox.textproto")
Colin Crossf61d03d2023-11-02 16:56:39 -07002507 sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx, manifest)
Jihoon Kanga96a7b12023-09-20 23:43:32 +00002508 manifestCommand := sboxProto.Commands[0].GetCommand()
2509
2510 // Api files are sorted from the narrowest api scope to the widest api scope.
2511 // test api and module lib api surface do not have subset/superset relationship,
2512 // but they will never be passed as inputs at the same time.
2513 sourceFilesFlag := "--source-files default/java/api/current.txt " +
2514 "default/java/api/system-current.txt default/java/api/test-current.txt " +
2515 "default/java/api/module-lib-current.txt default/java/api/system-server-current.txt"
2516 android.AssertStringDoesContain(t, "source text files not in api scope order", manifestCommand, sourceFilesFlag)
2517}
Jihoon Kang4ec24872023-10-05 17:26:09 +00002518
2519func TestSdkLibraryProvidesSystemModulesToApiLibrary(t *testing.T) {
2520 result := android.GroupFixturePreparers(
2521 prepareForJavaTest,
2522 PrepareForTestWithJavaSdkLibraryFiles,
2523 FixtureWithLastReleaseApis("foo"),
2524 android.FixtureModifyConfig(func(config android.Config) {
2525 config.SetApiLibraries([]string{"foo"})
2526 }),
2527 android.FixtureMergeMockFs(
2528 map[string][]byte{
2529 "A.java": nil,
2530 },
2531 ),
2532 ).RunTestWithBp(t, `
2533 java_library {
2534 name: "bar",
2535 srcs: ["a.java"],
2536 }
2537 java_system_modules {
2538 name: "baz",
2539 libs: ["bar"],
2540 }
2541 java_sdk_library {
2542 name: "foo",
2543 srcs: ["A.java"],
2544 system_modules: "baz",
2545 }
2546 `)
2547 m := result.ModuleForTests(apiScopePublic.apiLibraryModuleName("foo"), "android_common")
2548 manifest := m.Output("metalava.sbox.textproto")
Colin Crossf61d03d2023-11-02 16:56:39 -07002549 sboxProto := android.RuleBuilderSboxProtoForTests(t, result.TestContext, manifest)
Jihoon Kang4ec24872023-10-05 17:26:09 +00002550 manifestCommand := sboxProto.Commands[0].GetCommand()
2551 classPathFlag := "--classpath __SBOX_SANDBOX_DIR__/out/.intermediates/bar/android_common/turbine-combined/bar.jar"
2552 android.AssertStringDoesContain(t, "command expected to contain classpath flag", manifestCommand, classPathFlag)
2553}
Jihoon Kang063ec002023-06-28 01:16:23 +00002554
2555func TestApiLibraryDroidstubsDependency(t *testing.T) {
2556 result := android.GroupFixturePreparers(
2557 prepareForJavaTest,
2558 PrepareForTestWithJavaSdkLibraryFiles,
2559 FixtureWithLastReleaseApis("foo"),
2560 android.FixtureModifyConfig(func(config android.Config) {
2561 config.SetApiLibraries([]string{"foo"})
2562 }),
2563 android.FixtureMergeMockFs(
2564 map[string][]byte{
2565 "A.java": nil,
2566 },
2567 ),
2568 ).RunTestWithBp(t, `
2569 java_api_library {
2570 name: "foo",
2571 api_contributions: [
2572 "api-stubs-docs-non-updatable.api.contribution",
2573 ],
2574 enable_validation: true,
2575 }
2576 java_api_library {
2577 name: "bar",
2578 api_contributions: [
2579 "api-stubs-docs-non-updatable.api.contribution",
2580 ],
2581 enable_validation: false,
2582 }
2583 `)
2584
2585 currentApiTimestampPath := "api-stubs-docs-non-updatable/android_common/metalava/check_current_api.timestamp"
2586 foo := result.ModuleForTests("foo", "android_common").Module().(*ApiLibrary)
2587 fooValidationPathsString := strings.Join(foo.validationPaths.Strings(), " ")
2588 bar := result.ModuleForTests("bar", "android_common").Module().(*ApiLibrary)
2589 barValidationPathsString := strings.Join(bar.validationPaths.Strings(), " ")
2590 android.AssertStringDoesContain(t,
2591 "Module expected to have validation",
2592 fooValidationPathsString,
2593 currentApiTimestampPath,
2594 )
2595 android.AssertStringDoesNotContain(t,
2596 "Module expected to not have validation",
2597 barValidationPathsString,
2598 currentApiTimestampPath,
2599 )
2600}
Jihoon Kang1975d3e2023-10-16 23:24:11 +00002601
2602func TestDisableFromTextStubForCoverageBuild(t *testing.T) {
2603 result := android.GroupFixturePreparers(
2604 prepareForJavaTest,
2605 PrepareForTestWithJavaSdkLibraryFiles,
2606 PrepareForTestWithJacocoInstrumentation,
2607 FixtureWithLastReleaseApis("foo"),
2608 android.FixtureModifyConfig(func(config android.Config) {
2609 config.SetApiLibraries([]string{"foo"})
2610 config.SetBuildFromTextStub(true)
2611 }),
2612 android.FixtureModifyEnv(func(env map[string]string) {
2613 env["EMMA_INSTRUMENT"] = "true"
2614 }),
2615 ).RunTestWithBp(t, `
2616 java_sdk_library {
2617 name: "foo",
2618 srcs: ["A.java"],
2619 }
2620 `)
2621 android.AssertBoolEquals(t, "stub module expected to depend on from-source stub",
2622 true, CheckModuleHasDependency(t, result.TestContext,
2623 apiScopePublic.stubsLibraryModuleName("foo"), "android_common",
2624 apiScopePublic.sourceStubLibraryModuleName("foo")))
2625
2626 android.AssertBoolEquals(t, "stub module expected to not depend on from-text stub",
2627 false, CheckModuleHasDependency(t, result.TestContext,
2628 apiScopePublic.stubsLibraryModuleName("foo"), "android_common",
2629 apiScopePublic.apiLibraryModuleName("foo")))
2630}