Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 1 | // Copyright 2017 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package java |
| 16 | |
| 17 | import ( |
Paul Duffin | 1a39332 | 2020-11-18 16:36:47 +0000 | [diff] [blame] | 18 | "fmt" |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 19 | "os" |
| 20 | "path/filepath" |
Colin Cross | c080617 | 2019-06-14 18:51:47 -0700 | [diff] [blame] | 21 | "reflect" |
Colin Cross | f8d9c49 | 2021-01-26 11:01:43 -0800 | [diff] [blame] | 22 | "runtime" |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 23 | "strconv" |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 24 | "strings" |
| 25 | "testing" |
Colin Cross | 86a60ae | 2018-05-29 14:44:55 -0700 | [diff] [blame] | 26 | |
Spandan Das | 3cf0463 | 2024-01-19 00:22:22 +0000 | [diff] [blame] | 27 | "github.com/google/blueprint" |
Jeongik Cha | 28df257 | 2019-11-11 10:46:36 +0900 | [diff] [blame] | 28 | "github.com/google/blueprint/proptools" |
| 29 | |
Jihoon Kang | 84b2589 | 2023-12-01 22:01:06 +0000 | [diff] [blame] | 30 | "android/soong/aconfig" |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 31 | "android/soong/android" |
| 32 | "android/soong/cc" |
Colin Cross | c28bb0b | 2019-02-25 14:20:47 -0800 | [diff] [blame] | 33 | "android/soong/dexpreopt" |
Colin Cross | 1661aff | 2021-03-12 17:56:51 -0800 | [diff] [blame] | 34 | "android/soong/genrule" |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 35 | ) |
| 36 | |
Paul Duffin | 70d3bee | 2021-03-21 11:26:05 +0000 | [diff] [blame] | 37 | // Legacy preparer used for running tests within the java package. |
| 38 | // |
| 39 | // This includes everything that was needed to run any test in the java package prior to the |
| 40 | // introduction of the test fixtures. Tests that are being converted to use fixtures directly |
| 41 | // rather than through the testJava...() methods should avoid using this and instead use the |
| 42 | // various preparers directly, using android.GroupFixturePreparers(...) to group them when |
| 43 | // necessary. |
| 44 | // |
| 45 | // deprecated |
| 46 | var prepareForJavaTest = android.GroupFixturePreparers( |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 47 | genrule.PrepareForTestWithGenRuleBuildComponents, |
| 48 | // Get the CC build components but not default modules. |
| 49 | cc.PrepareForTestWithCcBuildComponents, |
| 50 | // Include all the default java modules. |
Jiakai Zhang | b95998b | 2023-05-11 16:39:27 +0100 | [diff] [blame] | 51 | PrepareForTestWithDexpreopt, |
Jihoon Kang | 84b2589 | 2023-12-01 22:01:06 +0000 | [diff] [blame] | 52 | // Include aconfig modules. |
| 53 | aconfig.PrepareForTestWithAconfigBuildComponents, |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 54 | ) |
| 55 | |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 56 | func TestMain(m *testing.M) { |
Paul Duffin | d6339af | 2021-03-22 18:05:04 +0000 | [diff] [blame] | 57 | os.Exit(m.Run()) |
Colin Cross | 527012a | 2017-11-30 22:56:16 -0800 | [diff] [blame] | 58 | } |
| 59 | |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 60 | // testJavaError is a legacy way of running tests of java modules that expect errors. |
| 61 | // |
| 62 | // See testJava for an explanation as to how to stop using this deprecated method. |
| 63 | // |
| 64 | // deprecated |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 65 | func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) { |
Jeongik Cha | 538c0d0 | 2019-07-11 15:54:27 +0900 | [diff] [blame] | 66 | t.Helper() |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 67 | result := android.GroupFixturePreparers( |
Paul Duffin | 9fc9f53 | 2021-03-23 15:41:11 +0000 | [diff] [blame] | 68 | prepareForJavaTest, dexpreopt.PrepareForTestByEnablingDexpreopt). |
Paul Duffin | 6bac49c | 2021-03-12 21:28:15 +0000 | [diff] [blame] | 69 | ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)). |
| 70 | RunTestWithBp(t, bp) |
| 71 | return result.TestContext, result.Config |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 72 | } |
| 73 | |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 74 | // testJavaWithFS runs tests using the prepareForJavaTest |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 75 | // |
| 76 | // See testJava for an explanation as to how to stop using this deprecated method. |
| 77 | // |
| 78 | // deprecated |
| 79 | func testJavaWithFS(t *testing.T, bp string, fs android.MockFS) (*android.TestContext, android.Config) { |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 80 | t.Helper() |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 81 | result := android.GroupFixturePreparers( |
| 82 | prepareForJavaTest, fs.AddToFixture()).RunTestWithBp(t, bp) |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 83 | return result.TestContext, result.Config |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 84 | } |
| 85 | |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 86 | // testJava runs tests using the prepareForJavaTest |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 87 | // |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 88 | // Do not add any new usages of this, instead use the prepareForJavaTest directly as it makes it |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 89 | // much easier to customize the test behavior. |
| 90 | // |
| 91 | // If it is necessary to customize the behavior of an existing test that uses this then please first |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 92 | // convert the test to using prepareForJavaTest first and then in a following change add the |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 93 | // appropriate fixture preparers. Keeping the conversion change separate makes it easy to verify |
| 94 | // that it did not change the test behavior unexpectedly. |
| 95 | // |
| 96 | // deprecated |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 97 | func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) { |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 98 | t.Helper() |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 99 | result := prepareForJavaTest.RunTestWithBp(t, bp) |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 100 | return result.TestContext, result.Config |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 101 | } |
| 102 | |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 103 | // defaultModuleToPath constructs a path to the turbine generate jar for a default test module that |
| 104 | // is defined in PrepareForIntegrationTestWithJava |
| 105 | func defaultModuleToPath(name string) string { |
Paul Duffin | 76101fa | 2021-03-13 09:55:25 +0000 | [diff] [blame] | 106 | switch { |
| 107 | case name == `""`: |
| 108 | return name |
| 109 | case strings.HasSuffix(name, ".jar"): |
| 110 | return name |
| 111 | default: |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 112 | return filepath.Join("out", "soong", ".intermediates", defaultJavaDir, name, "android_common", "turbine-combined", name+".jar") |
Paul Duffin | 76101fa | 2021-03-13 09:55:25 +0000 | [diff] [blame] | 113 | } |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 114 | } |
| 115 | |
Paul Duffin | 76e5c8a | 2021-03-20 14:19:46 +0000 | [diff] [blame] | 116 | // Test that the PrepareForTestWithJavaDefaultModules provides all the files that it uses by |
| 117 | // running it in a fixture that requires all source files to exist. |
| 118 | func TestPrepareForTestWithJavaDefaultModules(t *testing.T) { |
| 119 | android.GroupFixturePreparers( |
| 120 | PrepareForTestWithJavaDefaultModules, |
| 121 | android.PrepareForTestDisallowNonExistentPaths, |
| 122 | ).RunTest(t) |
| 123 | } |
| 124 | |
Jeongik Cha | e403e9e | 2019-12-07 00:16:24 +0900 | [diff] [blame] | 125 | func TestJavaLinkType(t *testing.T) { |
| 126 | testJava(t, ` |
| 127 | java_library { |
| 128 | name: "foo", |
| 129 | srcs: ["a.java"], |
| 130 | libs: ["bar"], |
| 131 | static_libs: ["baz"], |
| 132 | } |
| 133 | |
| 134 | java_library { |
| 135 | name: "bar", |
| 136 | sdk_version: "current", |
| 137 | srcs: ["b.java"], |
| 138 | } |
| 139 | |
| 140 | java_library { |
| 141 | name: "baz", |
| 142 | sdk_version: "system_current", |
| 143 | srcs: ["c.java"], |
| 144 | } |
| 145 | `) |
| 146 | |
Steven Moreland | 0029898 | 2020-11-17 21:44:36 +0000 | [diff] [blame] | 147 | testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", ` |
Jeongik Cha | e403e9e | 2019-12-07 00:16:24 +0900 | [diff] [blame] | 148 | java_library { |
| 149 | name: "foo", |
| 150 | srcs: ["a.java"], |
| 151 | libs: ["bar"], |
| 152 | sdk_version: "current", |
| 153 | static_libs: ["baz"], |
| 154 | } |
| 155 | |
| 156 | java_library { |
| 157 | name: "bar", |
| 158 | sdk_version: "current", |
| 159 | srcs: ["b.java"], |
| 160 | } |
| 161 | |
| 162 | java_library { |
| 163 | name: "baz", |
| 164 | sdk_version: "system_current", |
| 165 | srcs: ["c.java"], |
| 166 | } |
| 167 | `) |
| 168 | |
| 169 | testJava(t, ` |
| 170 | java_library { |
| 171 | name: "foo", |
| 172 | srcs: ["a.java"], |
| 173 | libs: ["bar"], |
| 174 | sdk_version: "system_current", |
| 175 | static_libs: ["baz"], |
| 176 | } |
| 177 | |
| 178 | java_library { |
| 179 | name: "bar", |
| 180 | sdk_version: "current", |
| 181 | srcs: ["b.java"], |
| 182 | } |
| 183 | |
| 184 | java_library { |
| 185 | name: "baz", |
| 186 | sdk_version: "system_current", |
| 187 | srcs: ["c.java"], |
| 188 | } |
| 189 | `) |
| 190 | |
Steven Moreland | 0029898 | 2020-11-17 21:44:36 +0000 | [diff] [blame] | 191 | testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", ` |
Jeongik Cha | e403e9e | 2019-12-07 00:16:24 +0900 | [diff] [blame] | 192 | java_library { |
| 193 | name: "foo", |
| 194 | srcs: ["a.java"], |
| 195 | libs: ["bar"], |
| 196 | sdk_version: "system_current", |
| 197 | static_libs: ["baz"], |
| 198 | } |
| 199 | |
| 200 | java_library { |
| 201 | name: "bar", |
| 202 | sdk_version: "current", |
| 203 | srcs: ["b.java"], |
| 204 | } |
| 205 | |
| 206 | java_library { |
| 207 | name: "baz", |
| 208 | srcs: ["c.java"], |
| 209 | } |
| 210 | `) |
| 211 | } |
| 212 | |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 213 | func TestSimple(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 214 | ctx, _ := testJava(t, ` |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 215 | java_library { |
| 216 | name: "foo", |
| 217 | srcs: ["a.java"], |
Colin Cross | e8dc34a | 2017-07-19 11:22:16 -0700 | [diff] [blame] | 218 | libs: ["bar"], |
| 219 | static_libs: ["baz"], |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 220 | } |
| 221 | |
| 222 | java_library { |
| 223 | name: "bar", |
| 224 | srcs: ["b.java"], |
| 225 | } |
| 226 | |
| 227 | java_library { |
| 228 | name: "baz", |
| 229 | srcs: ["c.java"], |
| 230 | } |
Colin Cross | d5934c8 | 2017-10-02 13:55:26 -0700 | [diff] [blame] | 231 | `) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 232 | |
Paul Duffin | a71a67a | 2021-03-29 00:42:57 +0100 | [diff] [blame] | 233 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") |
Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 234 | combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac") |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 235 | |
| 236 | if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" { |
| 237 | t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs) |
| 238 | } |
| 239 | |
Colin Cross | 1ee2317 | 2017-10-18 14:44:18 -0700 | [diff] [blame] | 240 | baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String() |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 241 | barTurbine := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar") |
| 242 | bazTurbine := filepath.Join("out", "soong", ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar") |
Colin Cross | 0a6e007 | 2017-08-30 14:24:55 -0700 | [diff] [blame] | 243 | |
Paul Duffin | 22b77cd | 2021-03-12 19:15:01 +0000 | [diff] [blame] | 244 | android.AssertStringDoesContain(t, "foo classpath", javac.Args["classpath"], barTurbine) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 245 | |
Paul Duffin | 22b77cd | 2021-03-12 19:15:01 +0000 | [diff] [blame] | 246 | android.AssertStringDoesContain(t, "foo classpath", javac.Args["classpath"], bazTurbine) |
Colin Cross | 0a6e007 | 2017-08-30 14:24:55 -0700 | [diff] [blame] | 247 | |
| 248 | if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz { |
| 249 | t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 250 | } |
| 251 | } |
| 252 | |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 253 | func TestExportedPlugins(t *testing.T) { |
| 254 | type Result struct { |
Colin Cross | c9fe10f | 2020-11-19 18:06:03 -0800 | [diff] [blame] | 255 | library string |
| 256 | processors string |
| 257 | disableTurbine bool |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 258 | } |
| 259 | var tests = []struct { |
| 260 | name string |
| 261 | extra string |
| 262 | results []Result |
| 263 | }{ |
| 264 | { |
| 265 | name: "Exported plugin is not a direct plugin", |
| 266 | extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`, |
| 267 | results: []Result{{library: "exports", processors: "-proc:none"}}, |
| 268 | }, |
| 269 | { |
| 270 | name: "Exports plugin to dependee", |
| 271 | extra: ` |
| 272 | java_library{name: "exports", exported_plugins: ["plugin"]} |
| 273 | java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]} |
| 274 | java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]} |
| 275 | `, |
| 276 | results: []Result{ |
| 277 | {library: "foo", processors: "-processor com.android.TestPlugin"}, |
| 278 | {library: "bar", processors: "-processor com.android.TestPlugin"}, |
| 279 | }, |
| 280 | }, |
| 281 | { |
| 282 | name: "Exports plugin to android_library", |
| 283 | extra: ` |
| 284 | java_library{name: "exports", exported_plugins: ["plugin"]} |
| 285 | android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]} |
| 286 | android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]} |
| 287 | `, |
| 288 | results: []Result{ |
| 289 | {library: "foo", processors: "-processor com.android.TestPlugin"}, |
| 290 | {library: "bar", processors: "-processor com.android.TestPlugin"}, |
| 291 | }, |
| 292 | }, |
| 293 | { |
| 294 | name: "Exports plugin is not propagated via transitive deps", |
| 295 | extra: ` |
| 296 | java_library{name: "exports", exported_plugins: ["plugin"]} |
| 297 | java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]} |
| 298 | java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]} |
| 299 | `, |
| 300 | results: []Result{ |
| 301 | {library: "foo", processors: "-processor com.android.TestPlugin"}, |
| 302 | {library: "bar", processors: "-proc:none"}, |
| 303 | }, |
| 304 | }, |
| 305 | { |
| 306 | name: "Exports plugin appends to plugins", |
| 307 | extra: ` |
| 308 | java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"} |
| 309 | java_library{name: "exports", exported_plugins: ["plugin"]} |
| 310 | java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]} |
| 311 | `, |
| 312 | results: []Result{ |
| 313 | {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"}, |
| 314 | }, |
| 315 | }, |
Colin Cross | c9fe10f | 2020-11-19 18:06:03 -0800 | [diff] [blame] | 316 | { |
| 317 | name: "Exports plugin to with generates_api to dependee", |
| 318 | extra: ` |
| 319 | java_library{name: "exports", exported_plugins: ["plugin_generates_api"]} |
| 320 | java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]} |
| 321 | java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]} |
| 322 | `, |
| 323 | results: []Result{ |
| 324 | {library: "foo", processors: "-processor com.android.TestPlugin", disableTurbine: true}, |
| 325 | {library: "bar", processors: "-processor com.android.TestPlugin", disableTurbine: true}, |
| 326 | }, |
| 327 | }, |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 328 | } |
| 329 | |
| 330 | for _, test := range tests { |
| 331 | t.Run(test.name, func(t *testing.T) { |
| 332 | ctx, _ := testJava(t, ` |
| 333 | java_plugin { |
| 334 | name: "plugin", |
| 335 | processor_class: "com.android.TestPlugin", |
| 336 | } |
Colin Cross | c9fe10f | 2020-11-19 18:06:03 -0800 | [diff] [blame] | 337 | java_plugin { |
| 338 | name: "plugin_generates_api", |
| 339 | generates_api: true, |
| 340 | processor_class: "com.android.TestPlugin", |
| 341 | } |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 342 | `+test.extra) |
| 343 | |
| 344 | for _, want := range test.results { |
| 345 | javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac") |
| 346 | if javac.Args["processor"] != want.processors { |
| 347 | t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"]) |
| 348 | } |
Colin Cross | c9fe10f | 2020-11-19 18:06:03 -0800 | [diff] [blame] | 349 | turbine := ctx.ModuleForTests(want.library, "android_common").MaybeRule("turbine") |
| 350 | disableTurbine := turbine.BuildParams.Rule == nil |
| 351 | if disableTurbine != want.disableTurbine { |
| 352 | t.Errorf("For library %v, expected disableTurbine %v, found %v", want.library, want.disableTurbine, disableTurbine) |
| 353 | } |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 354 | } |
| 355 | }) |
| 356 | } |
| 357 | } |
| 358 | |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 359 | func TestSdkVersionByPartition(t *testing.T) { |
| 360 | testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", ` |
Jeongik Cha | 6bd33c1 | 2019-06-25 16:26:18 +0900 | [diff] [blame] | 361 | java_library { |
| 362 | name: "foo", |
| 363 | srcs: ["a.java"], |
| 364 | vendor: true, |
| 365 | } |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 366 | `) |
Jeongik Cha | 6bd33c1 | 2019-06-25 16:26:18 +0900 | [diff] [blame] | 367 | |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 368 | testJava(t, ` |
Jeongik Cha | 6bd33c1 | 2019-06-25 16:26:18 +0900 | [diff] [blame] | 369 | java_library { |
| 370 | name: "bar", |
| 371 | srcs: ["b.java"], |
| 372 | } |
| 373 | `) |
| 374 | |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 375 | for _, enforce := range []bool{true, false} { |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 376 | bp := ` |
| 377 | java_library { |
| 378 | name: "foo", |
| 379 | srcs: ["a.java"], |
| 380 | product_specific: true, |
| 381 | } |
| 382 | ` |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 383 | |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 384 | errorHandler := android.FixtureExpectsNoErrors |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 385 | if enforce { |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 386 | errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern("sdk_version must have a value when the module is located at vendor or product") |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 387 | } |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 388 | |
| 389 | android.GroupFixturePreparers( |
| 390 | PrepareForTestWithJavaDefaultModules, |
| 391 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 392 | variables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce) |
| 393 | }), |
| 394 | ). |
| 395 | ExtendWithErrorHandler(errorHandler). |
| 396 | RunTestWithBp(t, bp) |
Jeongik Cha | 6bd33c1 | 2019-06-25 16:26:18 +0900 | [diff] [blame] | 397 | } |
| 398 | } |
| 399 | |
Colin Cross | d5934c8 | 2017-10-02 13:55:26 -0700 | [diff] [blame] | 400 | func TestArchSpecific(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 401 | ctx, _ := testJava(t, ` |
Colin Cross | d5934c8 | 2017-10-02 13:55:26 -0700 | [diff] [blame] | 402 | java_library { |
| 403 | name: "foo", |
| 404 | srcs: ["a.java"], |
| 405 | target: { |
| 406 | android: { |
| 407 | srcs: ["b.java"], |
| 408 | }, |
| 409 | }, |
| 410 | } |
| 411 | `) |
| 412 | |
| 413 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") |
| 414 | if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" { |
| 415 | t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs) |
| 416 | } |
| 417 | } |
| 418 | |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 419 | func TestBinary(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 420 | ctx, _ := testJava(t, ` |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 421 | java_library_host { |
| 422 | name: "foo", |
| 423 | srcs: ["a.java"], |
| 424 | } |
| 425 | |
| 426 | java_binary_host { |
| 427 | name: "bar", |
| 428 | srcs: ["b.java"], |
| 429 | static_libs: ["foo"], |
Colin Cross | 89226d9 | 2020-10-09 19:00:54 -0700 | [diff] [blame] | 430 | jni_libs: ["libjni"], |
| 431 | } |
| 432 | |
| 433 | cc_library_shared { |
| 434 | name: "libjni", |
| 435 | host_supported: true, |
| 436 | device_supported: false, |
| 437 | stl: "none", |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 438 | } |
| 439 | `) |
| 440 | |
Colin Cross | 0c66bc6 | 2021-07-20 09:47:41 -0700 | [diff] [blame] | 441 | buildOS := ctx.Config().BuildOS.String() |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 442 | |
| 443 | bar := ctx.ModuleForTests("bar", buildOS+"_common") |
| 444 | barJar := bar.Output("bar.jar").Output.String() |
| 445 | barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64") |
| 446 | barWrapperDeps := barWrapper.Output("bar").Implicits.Strings() |
| 447 | |
Colin Cross | 89226d9 | 2020-10-09 19:00:54 -0700 | [diff] [blame] | 448 | libjni := ctx.ModuleForTests("libjni", buildOS+"_x86_64_shared") |
| 449 | libjniSO := libjni.Rule("Cp").Output.String() |
| 450 | |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 451 | // Test that the install binary wrapper depends on the installed jar file |
Colin Cross | c179ea6 | 2020-10-09 10:54:15 -0700 | [diff] [blame] | 452 | if g, w := barWrapperDeps, barJar; !android.InList(w, g) { |
| 453 | t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g) |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 454 | } |
Colin Cross | 89226d9 | 2020-10-09 19:00:54 -0700 | [diff] [blame] | 455 | |
| 456 | // Test that the install binary wrapper depends on the installed JNI libraries |
| 457 | if g, w := barWrapperDeps, libjniSO; !android.InList(w, g) { |
| 458 | t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g) |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 459 | } |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 460 | } |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 461 | |
Colin Cross | f8d9c49 | 2021-01-26 11:01:43 -0800 | [diff] [blame] | 462 | func TestTest(t *testing.T) { |
| 463 | ctx, _ := testJava(t, ` |
| 464 | java_test_host { |
| 465 | name: "foo", |
| 466 | srcs: ["a.java"], |
| 467 | jni_libs: ["libjni"], |
| 468 | } |
| 469 | |
| 470 | cc_library_shared { |
| 471 | name: "libjni", |
| 472 | host_supported: true, |
| 473 | device_supported: false, |
| 474 | stl: "none", |
| 475 | } |
| 476 | `) |
| 477 | |
Colin Cross | 0c66bc6 | 2021-07-20 09:47:41 -0700 | [diff] [blame] | 478 | buildOS := ctx.Config().BuildOS.String() |
Colin Cross | f8d9c49 | 2021-01-26 11:01:43 -0800 | [diff] [blame] | 479 | |
| 480 | foo := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost) |
| 481 | |
| 482 | expected := "lib64/libjni.so" |
| 483 | if runtime.GOOS == "darwin" { |
| 484 | expected = "lib64/libjni.dylib" |
| 485 | } |
| 486 | |
| 487 | fooTestData := foo.data |
| 488 | if len(fooTestData) != 1 || fooTestData[0].Rel() != expected { |
| 489 | t.Errorf(`expected foo test data relative path [%q], got %q`, |
| 490 | expected, fooTestData.Strings()) |
| 491 | } |
| 492 | } |
| 493 | |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 494 | func TestHostBinaryNoJavaDebugInfoOverride(t *testing.T) { |
| 495 | bp := ` |
| 496 | java_library { |
| 497 | name: "target_library", |
| 498 | srcs: ["a.java"], |
| 499 | } |
| 500 | |
| 501 | java_binary_host { |
| 502 | name: "host_binary", |
| 503 | srcs: ["b.java"], |
| 504 | } |
| 505 | ` |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 506 | |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 507 | result := android.GroupFixturePreparers( |
| 508 | PrepareForTestWithJavaDefaultModules, |
| 509 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 510 | variables.MinimizeJavaDebugInfo = proptools.BoolPtr(true) |
| 511 | }), |
| 512 | ).RunTestWithBp(t, bp) |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 513 | |
Liz Kammer | 7941b30 | 2020-07-28 13:27:34 -0700 | [diff] [blame] | 514 | // first, check that the -g flag is added to target modules |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 515 | targetLibrary := result.ModuleForTests("target_library", "android_common") |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 516 | targetJavaFlags := targetLibrary.Module().VariablesForTests()["javacFlags"] |
| 517 | if !strings.Contains(targetJavaFlags, "-g:source,lines") { |
| 518 | t.Errorf("target library javac flags %v should contain "+ |
| 519 | "-g:source,lines override with MinimizeJavaDebugInfo", targetJavaFlags) |
| 520 | } |
| 521 | |
| 522 | // check that -g is not overridden for host modules |
Colin Cross | 0c66bc6 | 2021-07-20 09:47:41 -0700 | [diff] [blame] | 523 | buildOS := result.Config.BuildOS.String() |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 524 | hostBinary := result.ModuleForTests("host_binary", buildOS+"_common") |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 525 | hostJavaFlags := hostBinary.Module().VariablesForTests()["javacFlags"] |
| 526 | if strings.Contains(hostJavaFlags, "-g:source,lines") { |
| 527 | t.Errorf("java_binary_host javac flags %v should not have "+ |
| 528 | "-g:source,lines override with MinimizeJavaDebugInfo", hostJavaFlags) |
| 529 | } |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 530 | } |
| 531 | |
Spandan Das | 59a4a2b | 2024-01-09 21:35:56 +0000 | [diff] [blame] | 532 | // A minimal context object for use with DexJarBuildPath |
| 533 | type moduleErrorfTestCtx struct { |
| 534 | } |
| 535 | |
| 536 | func (ctx moduleErrorfTestCtx) ModuleErrorf(format string, args ...interface{}) { |
| 537 | } |
| 538 | |
| 539 | var _ android.ModuleErrorfContext = (*moduleErrorfTestCtx)(nil) |
| 540 | |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 541 | func TestPrebuilts(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 542 | ctx, _ := testJava(t, ` |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 543 | java_library { |
| 544 | name: "foo", |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 545 | srcs: ["a.java", ":stubs-source"], |
Paul Duffin | fcfd791 | 2020-01-31 17:54:30 +0000 | [diff] [blame] | 546 | libs: ["bar", "sdklib"], |
Colin Cross | e8dc34a | 2017-07-19 11:22:16 -0700 | [diff] [blame] | 547 | static_libs: ["baz"], |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 548 | } |
| 549 | |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 550 | java_import { |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 551 | name: "bar", |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 552 | jars: ["a.jar"], |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 553 | } |
| 554 | |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 555 | java_import { |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 556 | name: "baz", |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 557 | jars: ["b.jar"], |
Liz Kammer | d6c31d2 | 2020-08-05 15:40:41 -0700 | [diff] [blame] | 558 | sdk_version: "current", |
| 559 | compile_dex: true, |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 560 | } |
Colin Cross | 42be761 | 2019-02-21 18:12:14 -0800 | [diff] [blame] | 561 | |
| 562 | dex_import { |
| 563 | name: "qux", |
| 564 | jars: ["b.jar"], |
| 565 | } |
Colin Cross | 79c7c26 | 2019-04-17 11:11:46 -0700 | [diff] [blame] | 566 | |
| 567 | java_sdk_library_import { |
Paul Duffin | 56d4490 | 2020-01-31 13:36:25 +0000 | [diff] [blame] | 568 | name: "sdklib", |
| 569 | public: { |
| 570 | jars: ["c.jar"], |
| 571 | }, |
| 572 | } |
| 573 | |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 574 | prebuilt_stubs_sources { |
| 575 | name: "stubs-source", |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 576 | srcs: ["stubs/sources"], |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 577 | } |
Paul Duffin | 1b82e6a | 2019-12-03 18:06:47 +0000 | [diff] [blame] | 578 | |
| 579 | java_test_import { |
| 580 | name: "test", |
| 581 | jars: ["a.jar"], |
| 582 | test_suites: ["cts"], |
| 583 | test_config: "AndroidTest.xml", |
| 584 | } |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 585 | `) |
| 586 | |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 587 | fooModule := ctx.ModuleForTests("foo", "android_common") |
| 588 | javac := fooModule.Rule("javac") |
Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 589 | combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac") |
Liz Kammer | d6c31d2 | 2020-08-05 15:40:41 -0700 | [diff] [blame] | 590 | barModule := ctx.ModuleForTests("bar", "android_common") |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 591 | barJar := barModule.Output("combined/bar.jar").Output |
Liz Kammer | d6c31d2 | 2020-08-05 15:40:41 -0700 | [diff] [blame] | 592 | bazModule := ctx.ModuleForTests("baz", "android_common") |
| 593 | bazJar := bazModule.Rule("combineJar").Output |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 594 | sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common"). |
| 595 | Output("combined/sdklib.stubs.jar").Output |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 596 | |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 597 | fooLibrary := fooModule.Module().(*Library) |
Chaohui Wang | dcbe33c | 2022-10-11 11:13:30 +0800 | [diff] [blame] | 598 | assertDeepEquals(t, "foo unique sources incorrect", |
| 599 | []string{"a.java"}, fooLibrary.uniqueSrcFiles.Strings()) |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 600 | |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 601 | assertDeepEquals(t, "foo java source jars incorrect", |
| 602 | []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"}, |
| 603 | android.NormalizePathsForTesting(fooLibrary.compiledSrcJars)) |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 604 | |
Colin Cross | 37f6d79 | 2018-07-12 12:28:41 -0700 | [diff] [blame] | 605 | if !strings.Contains(javac.Args["classpath"], barJar.String()) { |
| 606 | t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String()) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 607 | } |
| 608 | |
Spandan Das | 59a4a2b | 2024-01-09 21:35:56 +0000 | [diff] [blame] | 609 | errCtx := moduleErrorfTestCtx{} |
| 610 | barDexJar := barModule.Module().(*Import).DexJarBuildPath(errCtx) |
Martin Stjernholm | 8be1e6d | 2021-09-15 03:34:04 +0100 | [diff] [blame] | 611 | if barDexJar.IsSet() { |
| 612 | t.Errorf("bar dex jar build path expected to be set, got %s", barDexJar) |
Liz Kammer | d6c31d2 | 2020-08-05 15:40:41 -0700 | [diff] [blame] | 613 | } |
| 614 | |
Colin Cross | 79c7c26 | 2019-04-17 11:11:46 -0700 | [diff] [blame] | 615 | if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) { |
| 616 | t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String()) |
| 617 | } |
| 618 | |
Colin Cross | 37f6d79 | 2018-07-12 12:28:41 -0700 | [diff] [blame] | 619 | if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() { |
| 620 | t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String()) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 621 | } |
Colin Cross | 42be761 | 2019-02-21 18:12:14 -0800 | [diff] [blame] | 622 | |
Spandan Das | 59a4a2b | 2024-01-09 21:35:56 +0000 | [diff] [blame] | 623 | bazDexJar := bazModule.Module().(*Import).DexJarBuildPath(errCtx).Path() |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 624 | expectedDexJar := "out/soong/.intermediates/baz/android_common/dex/baz.jar" |
| 625 | android.AssertPathRelativeToTopEquals(t, "baz dex jar build path", expectedDexJar, bazDexJar) |
Liz Kammer | d6c31d2 | 2020-08-05 15:40:41 -0700 | [diff] [blame] | 626 | |
Colin Cross | 42be761 | 2019-02-21 18:12:14 -0800 | [diff] [blame] | 627 | ctx.ModuleForTests("qux", "android_common").Rule("Cp") |
Wei Li | 598f92d | 2023-01-04 17:12:24 -0800 | [diff] [blame] | 628 | |
| 629 | entries := android.AndroidMkEntriesForTest(t, ctx, fooModule.Module())[0] |
| 630 | android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "java_library", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0]) |
| 631 | entries = android.AndroidMkEntriesForTest(t, ctx, barModule.Module())[0] |
| 632 | android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "java_import", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0]) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 633 | } |
| 634 | |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 635 | func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) { |
| 636 | if !reflect.DeepEqual(expected, actual) { |
| 637 | t.Errorf("%s: expected %q, found %q", message, expected, actual) |
| 638 | } |
| 639 | } |
| 640 | |
Paul Duffin | 1a39332 | 2020-11-18 16:36:47 +0000 | [diff] [blame] | 641 | func TestPrebuiltStubsSources(t *testing.T) { |
| 642 | test := func(t *testing.T, sourcesPath string, expectedInputs []string) { |
| 643 | ctx, _ := testJavaWithFS(t, fmt.Sprintf(` |
| 644 | prebuilt_stubs_sources { |
| 645 | name: "stubs-source", |
| 646 | srcs: ["%s"], |
| 647 | }`, sourcesPath), map[string][]byte{ |
| 648 | "stubs/sources/pkg/A.java": nil, |
| 649 | "stubs/sources/pkg/B.java": nil, |
| 650 | }) |
| 651 | |
| 652 | zipSrc := ctx.ModuleForTests("stubs-source", "android_common").Rule("zip_src") |
| 653 | if expected, actual := expectedInputs, zipSrc.Inputs.Strings(); !reflect.DeepEqual(expected, actual) { |
| 654 | t.Errorf("mismatch of inputs to soong_zip: expected %q, actual %q", expected, actual) |
| 655 | } |
| 656 | } |
| 657 | |
| 658 | t.Run("empty/missing directory", func(t *testing.T) { |
Colin Cross | ce3a51d | 2021-03-19 16:22:12 -0700 | [diff] [blame] | 659 | test(t, "empty-directory", nil) |
Paul Duffin | 1a39332 | 2020-11-18 16:36:47 +0000 | [diff] [blame] | 660 | }) |
| 661 | |
| 662 | t.Run("non-empty set of sources", func(t *testing.T) { |
| 663 | test(t, "stubs/sources", []string{ |
| 664 | "stubs/sources/pkg/A.java", |
| 665 | "stubs/sources/pkg/B.java", |
| 666 | }) |
| 667 | }) |
| 668 | } |
| 669 | |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 670 | func TestDefaults(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 671 | ctx, _ := testJava(t, ` |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 672 | java_defaults { |
| 673 | name: "defaults", |
| 674 | srcs: ["a.java"], |
| 675 | libs: ["bar"], |
| 676 | static_libs: ["baz"], |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 677 | optimize: {enabled: false}, |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 678 | } |
| 679 | |
| 680 | java_library { |
| 681 | name: "foo", |
| 682 | defaults: ["defaults"], |
| 683 | } |
| 684 | |
| 685 | java_library { |
| 686 | name: "bar", |
| 687 | srcs: ["b.java"], |
| 688 | } |
| 689 | |
| 690 | java_library { |
| 691 | name: "baz", |
| 692 | srcs: ["c.java"], |
| 693 | } |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 694 | |
| 695 | android_test { |
| 696 | name: "atestOptimize", |
| 697 | defaults: ["defaults"], |
| 698 | optimize: {enabled: true}, |
| 699 | } |
| 700 | |
| 701 | android_test { |
| 702 | name: "atestNoOptimize", |
| 703 | defaults: ["defaults"], |
| 704 | } |
| 705 | |
| 706 | android_test { |
| 707 | name: "atestDefault", |
| 708 | srcs: ["a.java"], |
| 709 | } |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 710 | `) |
| 711 | |
Paul Duffin | a71a67a | 2021-03-29 00:42:57 +0100 | [diff] [blame] | 712 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") |
Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 713 | combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac") |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 714 | |
| 715 | if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" { |
| 716 | t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs) |
| 717 | } |
| 718 | |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 719 | barTurbine := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar") |
Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 720 | if !strings.Contains(javac.Args["classpath"], barTurbine) { |
| 721 | t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine) |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 722 | } |
| 723 | |
Colin Cross | 1ee2317 | 2017-10-18 14:44:18 -0700 | [diff] [blame] | 724 | baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String() |
Colin Cross | 0a6e007 | 2017-08-30 14:24:55 -0700 | [diff] [blame] | 725 | if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz { |
| 726 | t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz) |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 727 | } |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 728 | |
| 729 | atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8") |
| 730 | if atestOptimize.Output == nil { |
| 731 | t.Errorf("atestOptimize should optimize APK") |
| 732 | } |
| 733 | |
| 734 | atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8") |
| 735 | if atestNoOptimize.Output == nil { |
| 736 | t.Errorf("atestNoOptimize should not optimize APK") |
| 737 | } |
| 738 | |
Jared Duke | 63a3da9 | 2022-06-02 19:11:14 +0000 | [diff] [blame] | 739 | atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("d8") |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 740 | if atestDefault.Output == nil { |
Jared Duke | 63a3da9 | 2022-06-02 19:11:14 +0000 | [diff] [blame] | 741 | t.Errorf("atestDefault should not optimize APK") |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 742 | } |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 743 | } |
| 744 | |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 745 | func TestResources(t *testing.T) { |
| 746 | var table = []struct { |
| 747 | name string |
| 748 | prop string |
| 749 | extra string |
| 750 | args string |
| 751 | }{ |
| 752 | { |
Colin Cross | af9c55b | 2017-10-03 14:50:08 -0700 | [diff] [blame] | 753 | // Test that a module with java_resource_dirs includes the files |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 754 | name: "resource dirs", |
Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 755 | prop: `java_resource_dirs: ["java-res"]`, |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 756 | args: "-C java-res -f java-res/a/a -f java-res/b/b", |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 757 | }, |
| 758 | { |
| 759 | // Test that a module with java_resources includes the files |
| 760 | name: "resource files", |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 761 | prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`, |
| 762 | args: "-C . -f java-res/a/a -f java-res/b/b", |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 763 | }, |
| 764 | { |
| 765 | // Test that a module with a filegroup in java_resources includes the files with the |
| 766 | // path prefix |
| 767 | name: "resource filegroup", |
| 768 | prop: `java_resources: [":foo-res"]`, |
| 769 | extra: ` |
| 770 | filegroup { |
| 771 | name: "foo-res", |
Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 772 | path: "java-res", |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 773 | srcs: ["java-res/a/a", "java-res/b/b"], |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 774 | }`, |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 775 | args: "-C java-res -f java-res/a/a -f java-res/b/b", |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 776 | }, |
| 777 | { |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 778 | // Test that a module with wildcards in java_resource_dirs has the correct path prefixes |
| 779 | name: "wildcard dirs", |
| 780 | prop: `java_resource_dirs: ["java-res/*"]`, |
| 781 | args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b", |
| 782 | }, |
| 783 | { |
| 784 | // Test that a module exclude_java_resource_dirs excludes the files |
| 785 | name: "wildcard dirs", |
| 786 | prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`, |
| 787 | args: "-C java-res/a -f java-res/a/a", |
| 788 | }, |
Colin Cross | cedd476 | 2018-09-13 11:26:19 -0700 | [diff] [blame] | 789 | { |
| 790 | // Test wildcards in java_resources |
| 791 | name: "wildcard files", |
| 792 | prop: `java_resources: ["java-res/**/*"]`, |
| 793 | args: "-C . -f java-res/a/a -f java-res/b/b", |
| 794 | }, |
| 795 | { |
| 796 | // Test exclude_java_resources with java_resources |
| 797 | name: "wildcard files with exclude", |
| 798 | prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`, |
| 799 | args: "-C . -f java-res/a/a", |
| 800 | }, |
| 801 | { |
| 802 | // Test exclude_java_resources with java_resource_dirs |
| 803 | name: "resource dirs with exclude files", |
| 804 | prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`, |
| 805 | args: "-C java-res -f java-res/a/a", |
| 806 | }, |
| 807 | { |
| 808 | // Test exclude_java_resource_dirs with java_resource_dirs |
| 809 | name: "resource dirs with exclude files", |
| 810 | prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`, |
| 811 | args: "-C java-res -f java-res/a/a -f java-res/b/b", |
| 812 | }, |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 813 | } |
| 814 | |
| 815 | for _, test := range table { |
| 816 | t.Run(test.name, func(t *testing.T) { |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 817 | ctx, _ := testJavaWithFS(t, ` |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 818 | java_library { |
| 819 | name: "foo", |
| 820 | srcs: [ |
| 821 | "a.java", |
| 822 | "b.java", |
| 823 | "c.java", |
| 824 | ], |
| 825 | `+test.prop+`, |
| 826 | } |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 827 | `+test.extra, |
| 828 | map[string][]byte{ |
| 829 | "java-res/a/a": nil, |
| 830 | "java-res/b/b": nil, |
| 831 | "java-res2/a": nil, |
| 832 | }, |
| 833 | ) |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 834 | |
Colin Cross | 331a121 | 2018-08-15 20:40:52 -0700 | [diff] [blame] | 835 | foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar") |
Colin Cross | 1ee2317 | 2017-10-18 14:44:18 -0700 | [diff] [blame] | 836 | fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar") |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 837 | |
| 838 | if !inList(fooRes.Output.String(), foo.Inputs.Strings()) { |
| 839 | t.Errorf("foo combined jars %v does not contain %q", |
| 840 | foo.Inputs.Strings(), fooRes.Output.String()) |
| 841 | } |
| 842 | |
Colin Cross | af9c55b | 2017-10-03 14:50:08 -0700 | [diff] [blame] | 843 | if fooRes.Args["jarArgs"] != test.args { |
| 844 | t.Errorf("foo resource jar args %q is not %q", |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 845 | fooRes.Args["jarArgs"], test.args) |
| 846 | } |
| 847 | }) |
| 848 | } |
| 849 | } |
| 850 | |
Colin Cross | 0c4ce21 | 2019-05-03 15:28:19 -0700 | [diff] [blame] | 851 | func TestIncludeSrcs(t *testing.T) { |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 852 | ctx, _ := testJavaWithFS(t, ` |
Colin Cross | 0c4ce21 | 2019-05-03 15:28:19 -0700 | [diff] [blame] | 853 | java_library { |
| 854 | name: "foo", |
| 855 | srcs: [ |
| 856 | "a.java", |
| 857 | "b.java", |
| 858 | "c.java", |
| 859 | ], |
| 860 | include_srcs: true, |
| 861 | } |
| 862 | |
| 863 | java_library { |
| 864 | name: "bar", |
| 865 | srcs: [ |
| 866 | "a.java", |
| 867 | "b.java", |
| 868 | "c.java", |
| 869 | ], |
| 870 | java_resource_dirs: ["java-res"], |
| 871 | include_srcs: true, |
| 872 | } |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 873 | `, map[string][]byte{ |
| 874 | "java-res/a/a": nil, |
| 875 | "java-res/b/b": nil, |
| 876 | "java-res2/a": nil, |
| 877 | }) |
Colin Cross | 0c4ce21 | 2019-05-03 15:28:19 -0700 | [diff] [blame] | 878 | |
| 879 | // Test a library with include_srcs: true |
| 880 | foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar") |
| 881 | fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar") |
| 882 | |
| 883 | if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) { |
| 884 | t.Errorf("foo combined jars %v does not contain %q", w, g) |
| 885 | } |
| 886 | |
| 887 | if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w { |
| 888 | t.Errorf("foo source jar args %q is not %q", w, g) |
| 889 | } |
| 890 | |
| 891 | // Test a library with include_srcs: true and resources |
| 892 | bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar") |
| 893 | barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar") |
| 894 | barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar") |
| 895 | barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar") |
| 896 | |
| 897 | if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) { |
| 898 | t.Errorf("bar combined resource jars %v does not contain %q", w, g) |
| 899 | } |
| 900 | |
| 901 | if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) { |
| 902 | t.Errorf("bar combined resource jars %v does not contain %q", w, g) |
| 903 | } |
| 904 | |
| 905 | if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) { |
| 906 | t.Errorf("bar combined jars %v does not contain %q", w, g) |
| 907 | } |
| 908 | |
| 909 | if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w { |
| 910 | t.Errorf("bar source jar args %q is not %q", w, g) |
| 911 | } |
| 912 | |
| 913 | if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w { |
| 914 | t.Errorf("bar resource jar args %q is not %q", w, g) |
| 915 | } |
| 916 | } |
| 917 | |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 918 | func TestGeneratedSources(t *testing.T) { |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 919 | ctx, _ := testJavaWithFS(t, ` |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 920 | java_library { |
| 921 | name: "foo", |
| 922 | srcs: [ |
| 923 | "a*.java", |
| 924 | ":gen", |
| 925 | "b*.java", |
| 926 | ], |
| 927 | } |
| 928 | |
| 929 | genrule { |
| 930 | name: "gen", |
Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 931 | tool_files: ["java-res/a"], |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 932 | out: ["gen.java"], |
| 933 | } |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 934 | `, map[string][]byte{ |
| 935 | "a.java": nil, |
| 936 | "b.java": nil, |
| 937 | }) |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 938 | |
| 939 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") |
| 940 | genrule := ctx.ModuleForTests("gen", "").Rule("generator") |
| 941 | |
Colin Cross | 15e86d9 | 2017-10-20 15:07:08 -0700 | [diff] [blame] | 942 | if filepath.Base(genrule.Output.String()) != "gen.java" { |
| 943 | t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String()) |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 944 | } |
| 945 | |
| 946 | if len(javac.Inputs) != 3 || |
| 947 | javac.Inputs[0].String() != "a.java" || |
Colin Cross | 15e86d9 | 2017-10-20 15:07:08 -0700 | [diff] [blame] | 948 | javac.Inputs[1].String() != genrule.Output.String() || |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 949 | javac.Inputs[2].String() != "b.java" { |
| 950 | t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs) |
| 951 | } |
| 952 | } |
| 953 | |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 954 | func TestTurbine(t *testing.T) { |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 955 | result := android.GroupFixturePreparers( |
| 956 | prepareForJavaTest, FixtureWithPrebuiltApis(map[string][]string{"14": {"foo"}})). |
Paul Duffin | 3d9f268 | 2021-03-13 09:47:16 +0000 | [diff] [blame] | 957 | RunTestWithBp(t, ` |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 958 | java_library { |
| 959 | name: "foo", |
| 960 | srcs: ["a.java"], |
Jiyong Park | 2d49294 | 2018-03-05 17:44:10 +0900 | [diff] [blame] | 961 | sdk_version: "14", |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 962 | } |
| 963 | |
| 964 | java_library { |
| 965 | name: "bar", |
Colin Cross | 9bc4343 | 2017-12-15 20:20:39 -0800 | [diff] [blame] | 966 | srcs: ["b.java"], |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 967 | static_libs: ["foo"], |
Jiyong Park | 2d49294 | 2018-03-05 17:44:10 +0900 | [diff] [blame] | 968 | sdk_version: "14", |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 969 | } |
| 970 | |
| 971 | java_library { |
| 972 | name: "baz", |
| 973 | srcs: ["c.java"], |
| 974 | libs: ["bar"], |
| 975 | sdk_version: "14", |
| 976 | } |
| 977 | `) |
| 978 | |
Paul Duffin | a71a67a | 2021-03-29 00:42:57 +0100 | [diff] [blame] | 979 | fooTurbine := result.ModuleForTests("foo", "android_common").Rule("turbine") |
| 980 | barTurbine := result.ModuleForTests("bar", "android_common").Rule("turbine") |
| 981 | barJavac := result.ModuleForTests("bar", "android_common").Rule("javac") |
| 982 | barTurbineCombined := result.ModuleForTests("bar", "android_common").Description("for turbine") |
| 983 | bazJavac := result.ModuleForTests("baz", "android_common").Rule("javac") |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 984 | |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 985 | android.AssertPathsRelativeToTopEquals(t, "foo inputs", []string{"a.java"}, fooTurbine.Inputs) |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 986 | |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 987 | fooHeaderJar := filepath.Join("out", "soong", ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar") |
| 988 | barTurbineJar := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine", "bar.jar") |
Colin Cross | f61766e | 2022-03-16 18:06:48 -0700 | [diff] [blame] | 989 | android.AssertStringDoesContain(t, "bar turbine classpath", barTurbine.Args["turbineFlags"], fooHeaderJar) |
Paul Duffin | 3d9f268 | 2021-03-13 09:47:16 +0000 | [diff] [blame] | 990 | android.AssertStringDoesContain(t, "bar javac classpath", barJavac.Args["classpath"], fooHeaderJar) |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 991 | android.AssertPathsRelativeToTopEquals(t, "bar turbine combineJar", []string{barTurbineJar, fooHeaderJar}, barTurbineCombined.Inputs) |
Paul Duffin | 3d9f268 | 2021-03-13 09:47:16 +0000 | [diff] [blame] | 992 | android.AssertStringDoesContain(t, "baz javac classpath", bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 993 | } |
| 994 | |
| 995 | func TestSharding(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 996 | ctx, _ := testJava(t, ` |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 997 | java_library { |
| 998 | name: "bar", |
| 999 | srcs: ["a.java","b.java","c.java"], |
| 1000 | javac_shard_size: 1 |
| 1001 | } |
| 1002 | `) |
| 1003 | |
Colin Cross | 3d56ed5 | 2021-11-18 22:23:12 -0800 | [diff] [blame] | 1004 | barHeaderJar := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine", "bar.jar") |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1005 | for i := 0; i < 3; i++ { |
Paul Duffin | a71a67a | 2021-03-29 00:42:57 +0100 | [diff] [blame] | 1006 | barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i)) |
Colin Cross | 3d56ed5 | 2021-11-18 22:23:12 -0800 | [diff] [blame] | 1007 | if !strings.HasPrefix(barJavac.Args["classpath"], "-classpath "+barHeaderJar+":") { |
| 1008 | t.Errorf("bar javac classpath %v does start with %q", barJavac.Args["classpath"], barHeaderJar) |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 1009 | } |
| 1010 | } |
| 1011 | } |
| 1012 | |
Nan Zhang | 27e284d | 2018-02-09 21:03:53 +0000 | [diff] [blame] | 1013 | func TestExcludeFileGroupInSrcs(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 1014 | ctx, _ := testJava(t, ` |
Nan Zhang | 27e284d | 2018-02-09 21:03:53 +0000 | [diff] [blame] | 1015 | java_library { |
| 1016 | name: "foo", |
| 1017 | srcs: ["a.java", ":foo-srcs"], |
| 1018 | exclude_srcs: ["a.java", ":foo-excludes"], |
| 1019 | } |
| 1020 | |
| 1021 | filegroup { |
| 1022 | name: "foo-srcs", |
| 1023 | srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"], |
| 1024 | } |
| 1025 | |
| 1026 | filegroup { |
| 1027 | name: "foo-excludes", |
| 1028 | srcs: ["java-fg/a.java", "java-fg/b.java"], |
| 1029 | } |
| 1030 | `) |
| 1031 | |
| 1032 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") |
| 1033 | |
| 1034 | if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" { |
| 1035 | t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs) |
| 1036 | } |
| 1037 | } |
Jiyong Park | c678ad3 | 2018-04-10 13:07:10 +0900 | [diff] [blame] | 1038 | |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1039 | func TestJavaLibraryOutputFiles(t *testing.T) { |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1040 | testJavaWithFS(t, "", map[string][]byte{ |
Paul Duffin | 52d398a | 2019-06-11 12:31:14 +0100 | [diff] [blame] | 1041 | "libcore/Android.bp": []byte(` |
| 1042 | java_library { |
| 1043 | name: "core", |
| 1044 | sdk_version: "none", |
| 1045 | system_modules: "none", |
Paul Duffin | aa55f74 | 2020-10-06 17:20:13 +0100 | [diff] [blame] | 1046 | } |
| 1047 | |
| 1048 | filegroup { |
| 1049 | name: "core-jar", |
| 1050 | srcs: [":core{.jar}"], |
| 1051 | } |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1052 | `), |
Paul Duffin | aa55f74 | 2020-10-06 17:20:13 +0100 | [diff] [blame] | 1053 | }) |
Paul Duffin | aa55f74 | 2020-10-06 17:20:13 +0100 | [diff] [blame] | 1054 | } |
| 1055 | |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1056 | func TestJavaImportOutputFiles(t *testing.T) { |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1057 | testJavaWithFS(t, "", map[string][]byte{ |
Paul Duffin | aa55f74 | 2020-10-06 17:20:13 +0100 | [diff] [blame] | 1058 | "libcore/Android.bp": []byte(` |
| 1059 | java_import { |
| 1060 | name: "core", |
| 1061 | sdk_version: "none", |
| 1062 | } |
| 1063 | |
| 1064 | filegroup { |
| 1065 | name: "core-jar", |
| 1066 | srcs: [":core{.jar}"], |
| 1067 | } |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1068 | `), |
Paul Duffin | 52d398a | 2019-06-11 12:31:14 +0100 | [diff] [blame] | 1069 | }) |
Paul Duffin | 52d398a | 2019-06-11 12:31:14 +0100 | [diff] [blame] | 1070 | } |
| 1071 | |
Colin Cross | dad2a36 | 2024-03-23 04:43:41 +0000 | [diff] [blame] | 1072 | func TestJavaImport(t *testing.T) { |
| 1073 | bp := ` |
| 1074 | java_library { |
| 1075 | name: "source_library", |
| 1076 | srcs: ["source.java"], |
| 1077 | } |
| 1078 | |
| 1079 | java_import { |
| 1080 | name: "import_with_no_deps", |
| 1081 | jars: ["no_deps.jar"], |
| 1082 | } |
| 1083 | |
| 1084 | java_import { |
| 1085 | name: "import_with_source_deps", |
| 1086 | jars: ["source_deps.jar"], |
| 1087 | static_libs: ["source_library"], |
| 1088 | } |
| 1089 | |
| 1090 | java_import { |
| 1091 | name: "import_with_import_deps", |
| 1092 | jars: ["import_deps.jar"], |
| 1093 | static_libs: ["import_with_no_deps"], |
| 1094 | } |
| 1095 | ` |
| 1096 | ctx := android.GroupFixturePreparers( |
| 1097 | PrepareForTestWithJavaDefaultModules, |
| 1098 | ).RunTestWithBp(t, bp) |
| 1099 | |
| 1100 | source := ctx.ModuleForTests("source_library", "android_common") |
| 1101 | sourceJar := source.Output("javac/source_library.jar") |
| 1102 | sourceHeaderJar := source.Output("turbine-combined/source_library.jar") |
| 1103 | sourceJavaInfo, _ := android.SingletonModuleProvider(ctx, source.Module(), JavaInfoProvider) |
| 1104 | |
| 1105 | // The source library produces separate implementation and header jars |
| 1106 | android.AssertPathsRelativeToTopEquals(t, "source library implementation jar", |
| 1107 | []string{sourceJar.Output.String()}, sourceJavaInfo.ImplementationAndResourcesJars) |
| 1108 | android.AssertPathsRelativeToTopEquals(t, "source library header jar", |
| 1109 | []string{sourceHeaderJar.Output.String()}, sourceJavaInfo.HeaderJars) |
| 1110 | |
| 1111 | importWithNoDeps := ctx.ModuleForTests("import_with_no_deps", "android_common") |
| 1112 | importWithNoDepsJar := importWithNoDeps.Output("combined/import_with_no_deps.jar") |
| 1113 | importWithNoDepsJavaInfo, _ := android.SingletonModuleProvider(ctx, importWithNoDeps.Module(), JavaInfoProvider) |
| 1114 | |
| 1115 | // An import with no deps produces a single jar used as both the header and implementation jar. |
| 1116 | android.AssertPathsRelativeToTopEquals(t, "import with no deps implementation jar", |
| 1117 | []string{importWithNoDepsJar.Output.String()}, importWithNoDepsJavaInfo.ImplementationAndResourcesJars) |
| 1118 | android.AssertPathsRelativeToTopEquals(t, "import with no deps header jar", |
| 1119 | []string{importWithNoDepsJar.Output.String()}, importWithNoDepsJavaInfo.HeaderJars) |
| 1120 | android.AssertPathsRelativeToTopEquals(t, "import with no deps combined inputs", |
| 1121 | []string{"no_deps.jar"}, importWithNoDepsJar.Inputs) |
| 1122 | |
| 1123 | importWithSourceDeps := ctx.ModuleForTests("import_with_source_deps", "android_common") |
| 1124 | importWithSourceDepsJar := importWithSourceDeps.Output("combined/import_with_source_deps.jar") |
| 1125 | importWithSourceDepsHeaderJar := importWithSourceDeps.Output("turbine-combined/import_with_source_deps.jar") |
| 1126 | importWithSourceDepsJavaInfo, _ := android.SingletonModuleProvider(ctx, importWithSourceDeps.Module(), JavaInfoProvider) |
| 1127 | |
| 1128 | // An import with source deps produces separate header and implementation jars. |
| 1129 | android.AssertPathsRelativeToTopEquals(t, "import with source deps implementation jar", |
| 1130 | []string{importWithSourceDepsJar.Output.String()}, importWithSourceDepsJavaInfo.ImplementationAndResourcesJars) |
| 1131 | android.AssertPathsRelativeToTopEquals(t, "import with source deps header jar", |
| 1132 | []string{importWithSourceDepsHeaderJar.Output.String()}, importWithSourceDepsJavaInfo.HeaderJars) |
| 1133 | android.AssertPathsRelativeToTopEquals(t, "import with source deps combined implementation jar inputs", |
| 1134 | []string{"source_deps.jar", sourceJar.Output.String()}, importWithSourceDepsJar.Inputs) |
| 1135 | android.AssertPathsRelativeToTopEquals(t, "import with source deps combined header jar inputs", |
| 1136 | []string{"source_deps.jar", sourceHeaderJar.Output.String()}, importWithSourceDepsHeaderJar.Inputs) |
| 1137 | |
| 1138 | importWithImportDeps := ctx.ModuleForTests("import_with_import_deps", "android_common") |
| 1139 | importWithImportDepsJar := importWithImportDeps.Output("combined/import_with_import_deps.jar") |
| 1140 | importWithImportDepsJavaInfo, _ := android.SingletonModuleProvider(ctx, importWithImportDeps.Module(), JavaInfoProvider) |
| 1141 | |
| 1142 | // An import with only import deps produces a single jar used as both the header and implementation jar. |
| 1143 | android.AssertPathsRelativeToTopEquals(t, "import with import deps implementation jar", |
| 1144 | []string{importWithImportDepsJar.Output.String()}, importWithImportDepsJavaInfo.ImplementationAndResourcesJars) |
| 1145 | android.AssertPathsRelativeToTopEquals(t, "import with import deps header jar", |
| 1146 | []string{importWithImportDepsJar.Output.String()}, importWithImportDepsJavaInfo.HeaderJars) |
| 1147 | android.AssertPathsRelativeToTopEquals(t, "import with import deps combined implementation jar inputs", |
| 1148 | []string{"import_deps.jar", importWithNoDepsJar.Output.String()}, importWithImportDepsJar.Inputs) |
| 1149 | } |
| 1150 | |
Zoran Jovanovic | 8736ce2 | 2018-08-21 17:10:29 +0200 | [diff] [blame] | 1151 | var compilerFlagsTestCases = []struct { |
| 1152 | in string |
| 1153 | out bool |
| 1154 | }{ |
| 1155 | { |
| 1156 | in: "a", |
| 1157 | out: false, |
| 1158 | }, |
| 1159 | { |
| 1160 | in: "-a", |
| 1161 | out: true, |
| 1162 | }, |
| 1163 | { |
| 1164 | in: "-no-jdk", |
| 1165 | out: false, |
| 1166 | }, |
| 1167 | { |
| 1168 | in: "-no-stdlib", |
| 1169 | out: false, |
| 1170 | }, |
| 1171 | { |
| 1172 | in: "-kotlin-home", |
| 1173 | out: false, |
| 1174 | }, |
| 1175 | { |
| 1176 | in: "-kotlin-home /some/path", |
| 1177 | out: false, |
| 1178 | }, |
| 1179 | { |
| 1180 | in: "-include-runtime", |
| 1181 | out: false, |
| 1182 | }, |
| 1183 | { |
| 1184 | in: "-Xintellij-plugin-root", |
| 1185 | out: false, |
| 1186 | }, |
| 1187 | } |
| 1188 | |
| 1189 | type mockContext struct { |
| 1190 | android.ModuleContext |
| 1191 | result bool |
| 1192 | } |
| 1193 | |
| 1194 | func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) { |
| 1195 | // CheckBadCompilerFlags calls this function when the flag should be rejected |
| 1196 | ctx.result = false |
| 1197 | } |
| 1198 | |
| 1199 | func TestCompilerFlags(t *testing.T) { |
| 1200 | for _, testCase := range compilerFlagsTestCases { |
| 1201 | ctx := &mockContext{result: true} |
| 1202 | CheckKotlincFlags(ctx, []string{testCase.in}) |
| 1203 | if ctx.result != testCase.out { |
| 1204 | t.Errorf("incorrect output:") |
| 1205 | t.Errorf(" input: %#v", testCase.in) |
| 1206 | t.Errorf(" expected: %#v", testCase.out) |
| 1207 | t.Errorf(" got: %#v", ctx.result) |
| 1208 | } |
| 1209 | } |
| 1210 | } |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1211 | |
| 1212 | // TODO(jungjw): Consider making this more robust by ignoring path order. |
| 1213 | func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) { |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1214 | variables := ctx.ModuleForTests(moduleName, "android_common").VariablesForTestsRelativeToTop() |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1215 | flags := strings.Split(variables["javacFlags"], " ") |
| 1216 | got := "" |
| 1217 | for _, flag := range flags { |
| 1218 | keyEnd := strings.Index(flag, "=") |
| 1219 | if keyEnd > -1 && flag[:keyEnd] == "--patch-module" { |
| 1220 | got = flag[keyEnd+1:] |
| 1221 | break |
| 1222 | } |
| 1223 | } |
Lukacs T. Berki | 9f6c24a | 2021-08-26 15:07:24 +0200 | [diff] [blame] | 1224 | if expected != android.StringPathRelativeToTop(ctx.Config().SoongOutDir(), got) { |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1225 | t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got) |
| 1226 | } |
| 1227 | } |
| 1228 | |
| 1229 | func TestPatchModule(t *testing.T) { |
Pete Gillin | 0c2143e | 2019-05-02 15:32:11 +0100 | [diff] [blame] | 1230 | t.Run("Java language level 8", func(t *testing.T) { |
Pete Gillin | 1b3370f | 2019-10-01 13:57:31 +0100 | [diff] [blame] | 1231 | // Test with legacy javac -source 1.8 -target 1.8 |
Pete Gillin | bdf5d71 | 2019-10-21 14:29:58 +0100 | [diff] [blame] | 1232 | bp := ` |
| 1233 | java_library { |
| 1234 | name: "foo", |
| 1235 | srcs: ["a.java"], |
| 1236 | java_version: "1.8", |
| 1237 | } |
| 1238 | |
| 1239 | java_library { |
| 1240 | name: "bar", |
| 1241 | srcs: ["b.java"], |
| 1242 | sdk_version: "none", |
| 1243 | system_modules: "none", |
| 1244 | patch_module: "java.base", |
| 1245 | java_version: "1.8", |
| 1246 | } |
| 1247 | |
| 1248 | java_library { |
| 1249 | name: "baz", |
| 1250 | srcs: ["c.java"], |
| 1251 | patch_module: "java.base", |
| 1252 | java_version: "1.8", |
| 1253 | } |
| 1254 | ` |
| 1255 | ctx, _ := testJava(t, bp) |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1256 | |
| 1257 | checkPatchModuleFlag(t, ctx, "foo", "") |
| 1258 | checkPatchModuleFlag(t, ctx, "bar", "") |
| 1259 | checkPatchModuleFlag(t, ctx, "baz", "") |
| 1260 | }) |
| 1261 | |
Pete Gillin | 0c2143e | 2019-05-02 15:32:11 +0100 | [diff] [blame] | 1262 | t.Run("Java language level 9", func(t *testing.T) { |
Pete Gillin | 1b3370f | 2019-10-01 13:57:31 +0100 | [diff] [blame] | 1263 | // Test with default javac -source 9 -target 9 |
Pete Gillin | bdf5d71 | 2019-10-21 14:29:58 +0100 | [diff] [blame] | 1264 | bp := ` |
| 1265 | java_library { |
| 1266 | name: "foo", |
| 1267 | srcs: ["a.java"], |
| 1268 | } |
| 1269 | |
| 1270 | java_library { |
| 1271 | name: "bar", |
| 1272 | srcs: ["b.java"], |
| 1273 | sdk_version: "none", |
| 1274 | system_modules: "none", |
| 1275 | patch_module: "java.base", |
| 1276 | } |
| 1277 | |
| 1278 | java_library { |
| 1279 | name: "baz", |
Jingwen Chen | 5136a6e | 2020-10-30 01:01:35 -0400 | [diff] [blame] | 1280 | srcs: [ |
| 1281 | "c.java", |
| 1282 | // Tests for b/150878007 |
| 1283 | "dir/d.java", |
| 1284 | "dir2/e.java", |
| 1285 | "dir2/f.java", |
| 1286 | "nested/dir/g.java" |
| 1287 | ], |
Pete Gillin | bdf5d71 | 2019-10-21 14:29:58 +0100 | [diff] [blame] | 1288 | patch_module: "java.base", |
| 1289 | } |
| 1290 | ` |
Pete Gillin | 1b3370f | 2019-10-01 13:57:31 +0100 | [diff] [blame] | 1291 | ctx, _ := testJava(t, bp) |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1292 | |
| 1293 | checkPatchModuleFlag(t, ctx, "foo", "") |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1294 | expected := "java.base=.:out/soong" |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1295 | checkPatchModuleFlag(t, ctx, "bar", expected) |
Jingwen Chen | 5136a6e | 2020-10-30 01:01:35 -0400 | [diff] [blame] | 1296 | expected = "java.base=" + strings.Join([]string{ |
Colin Cross | 8ff1058 | 2023-12-07 13:10:56 -0800 | [diff] [blame] | 1297 | ".", "out/soong", defaultModuleToPath("ext"), defaultModuleToPath("framework")}, ":") |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1298 | checkPatchModuleFlag(t, ctx, "baz", expected) |
| 1299 | }) |
| 1300 | } |
Paul Duffin | a7b9f42 | 2020-01-10 17:12:18 +0000 | [diff] [blame] | 1301 | |
Paul Duffin | 83a2d96 | 2019-11-19 19:44:10 +0000 | [diff] [blame] | 1302 | func TestJavaLibraryWithSystemModules(t *testing.T) { |
| 1303 | ctx, _ := testJava(t, ` |
| 1304 | java_library { |
| 1305 | name: "lib-with-source-system-modules", |
| 1306 | srcs: [ |
| 1307 | "a.java", |
| 1308 | ], |
| 1309 | sdk_version: "none", |
| 1310 | system_modules: "source-system-modules", |
| 1311 | } |
| 1312 | |
| 1313 | java_library { |
| 1314 | name: "source-jar", |
| 1315 | srcs: [ |
| 1316 | "a.java", |
| 1317 | ], |
| 1318 | } |
| 1319 | |
| 1320 | java_system_modules { |
| 1321 | name: "source-system-modules", |
| 1322 | libs: ["source-jar"], |
| 1323 | } |
| 1324 | |
| 1325 | java_library { |
| 1326 | name: "lib-with-prebuilt-system-modules", |
| 1327 | srcs: [ |
| 1328 | "a.java", |
| 1329 | ], |
| 1330 | sdk_version: "none", |
| 1331 | system_modules: "prebuilt-system-modules", |
| 1332 | } |
| 1333 | |
| 1334 | java_import { |
| 1335 | name: "prebuilt-jar", |
| 1336 | jars: ["a.jar"], |
| 1337 | } |
| 1338 | |
| 1339 | java_system_modules_import { |
| 1340 | name: "prebuilt-system-modules", |
| 1341 | libs: ["prebuilt-jar"], |
| 1342 | } |
| 1343 | `) |
| 1344 | |
Jihoon Kang | b0f4c02 | 2024-08-06 00:15:25 +0000 | [diff] [blame^] | 1345 | checkBootClasspathForLibWithSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar") |
Paul Duffin | 83a2d96 | 2019-11-19 19:44:10 +0000 | [diff] [blame] | 1346 | |
Jihoon Kang | b0f4c02 | 2024-08-06 00:15:25 +0000 | [diff] [blame^] | 1347 | checkBootClasspathForLibWithSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar") |
Paul Duffin | 83a2d96 | 2019-11-19 19:44:10 +0000 | [diff] [blame] | 1348 | } |
| 1349 | |
Jihoon Kang | b0f4c02 | 2024-08-06 00:15:25 +0000 | [diff] [blame^] | 1350 | func checkBootClasspathForLibWithSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) { |
Paul Duffin | 83a2d96 | 2019-11-19 19:44:10 +0000 | [diff] [blame] | 1351 | javacRule := ctx.ModuleForTests(moduleName, "android_common").Rule("javac") |
| 1352 | bootClasspath := javacRule.Args["bootClasspath"] |
| 1353 | if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) { |
| 1354 | t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath) |
| 1355 | } |
| 1356 | } |
Jiyong Park | 19604de | 2020-03-24 16:44:11 +0900 | [diff] [blame] | 1357 | |
| 1358 | func TestAidlExportIncludeDirsFromImports(t *testing.T) { |
| 1359 | ctx, _ := testJava(t, ` |
| 1360 | java_library { |
| 1361 | name: "foo", |
| 1362 | srcs: ["aidl/foo/IFoo.aidl"], |
| 1363 | libs: ["bar"], |
| 1364 | } |
| 1365 | |
| 1366 | java_import { |
| 1367 | name: "bar", |
| 1368 | jars: ["a.jar"], |
| 1369 | aidl: { |
| 1370 | export_include_dirs: ["aidl/bar"], |
| 1371 | }, |
| 1372 | } |
| 1373 | `) |
| 1374 | |
| 1375 | aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command |
| 1376 | expectedAidlFlag := "-Iaidl/bar" |
| 1377 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 1378 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 1379 | } |
| 1380 | } |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1381 | |
Jooyung Han | e197d8b | 2021-01-05 10:33:16 +0900 | [diff] [blame] | 1382 | func TestAidlFlagsArePassedToTheAidlCompiler(t *testing.T) { |
| 1383 | ctx, _ := testJava(t, ` |
| 1384 | java_library { |
| 1385 | name: "foo", |
| 1386 | srcs: ["aidl/foo/IFoo.aidl"], |
| 1387 | aidl: { flags: ["-Werror"], }, |
| 1388 | } |
| 1389 | `) |
| 1390 | |
| 1391 | aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command |
| 1392 | expectedAidlFlag := "-Werror" |
| 1393 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 1394 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 1395 | } |
| 1396 | } |
| 1397 | |
Jooyung Han | 07f70c0 | 2021-11-06 07:08:45 +0900 | [diff] [blame] | 1398 | func TestAidlFlagsWithMinSdkVersion(t *testing.T) { |
| 1399 | fixture := android.GroupFixturePreparers( |
| 1400 | prepareForJavaTest, FixtureWithPrebuiltApis(map[string][]string{"14": {"foo"}})) |
| 1401 | |
| 1402 | for _, tc := range []struct { |
| 1403 | name string |
| 1404 | sdkVersion string |
| 1405 | expected string |
| 1406 | }{ |
| 1407 | {"default is current", "", "current"}, |
| 1408 | {"use sdk_version", `sdk_version: "14"`, "14"}, |
| 1409 | {"system_current", `sdk_version: "system_current"`, "current"}, |
| 1410 | } { |
| 1411 | t.Run(tc.name, func(t *testing.T) { |
| 1412 | ctx := fixture.RunTestWithBp(t, ` |
| 1413 | java_library { |
| 1414 | name: "foo", |
| 1415 | srcs: ["aidl/foo/IFoo.aidl"], |
| 1416 | `+tc.sdkVersion+` |
| 1417 | } |
| 1418 | `) |
| 1419 | aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command |
| 1420 | expectedAidlFlag := "--min_sdk_version=" + tc.expected |
| 1421 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 1422 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 1423 | } |
| 1424 | }) |
| 1425 | } |
| 1426 | } |
| 1427 | |
Spandan Das | 757b666 | 2022-11-17 04:29:59 +0000 | [diff] [blame] | 1428 | func TestAidlFlagsMinSdkVersionDroidstubs(t *testing.T) { |
| 1429 | bpTemplate := ` |
| 1430 | droidstubs { |
| 1431 | name: "foo-stubs", |
| 1432 | srcs: ["foo.aidl"], |
| 1433 | %s |
| 1434 | system_modules: "none", |
| 1435 | } |
| 1436 | ` |
| 1437 | testCases := []struct { |
| 1438 | desc string |
| 1439 | sdkVersionBp string |
| 1440 | minSdkVersionExpected string |
| 1441 | }{ |
| 1442 | { |
| 1443 | desc: "sdk_version not set, module compiles against private platform APIs", |
| 1444 | sdkVersionBp: ``, |
| 1445 | minSdkVersionExpected: "10000", |
| 1446 | }, |
| 1447 | { |
| 1448 | desc: "sdk_version set to none, module does not build against an SDK", |
| 1449 | sdkVersionBp: `sdk_version: "none",`, |
| 1450 | minSdkVersionExpected: "10000", |
| 1451 | }, |
| 1452 | } |
| 1453 | for _, tc := range testCases { |
| 1454 | ctx := prepareForJavaTest.RunTestWithBp(t, fmt.Sprintf(bpTemplate, tc.sdkVersionBp)) |
| 1455 | aidlCmd := ctx.ModuleForTests("foo-stubs", "android_common").Rule("aidl").RuleParams.Command |
| 1456 | expected := "--min_sdk_version=" + tc.minSdkVersionExpected |
| 1457 | android.AssertStringDoesContain(t, "aidl command conatins incorrect min_sdk_version for testCse: "+tc.desc, aidlCmd, expected) |
| 1458 | } |
| 1459 | } |
| 1460 | |
Thiébaud Weksteen | de8417c | 2022-02-10 15:41:46 +1100 | [diff] [blame] | 1461 | func TestAidlEnforcePermissions(t *testing.T) { |
| 1462 | ctx, _ := testJava(t, ` |
| 1463 | java_library { |
| 1464 | name: "foo", |
| 1465 | srcs: ["aidl/foo/IFoo.aidl"], |
| 1466 | aidl: { enforce_permissions: true }, |
| 1467 | } |
| 1468 | `) |
| 1469 | |
| 1470 | aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command |
| 1471 | expectedAidlFlag := "-Wmissing-permission-annotation -Werror" |
| 1472 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 1473 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 1474 | } |
| 1475 | } |
| 1476 | |
| 1477 | func TestAidlEnforcePermissionsException(t *testing.T) { |
| 1478 | ctx, _ := testJava(t, ` |
| 1479 | java_library { |
| 1480 | name: "foo", |
| 1481 | srcs: ["aidl/foo/IFoo.aidl", "aidl/foo/IFoo2.aidl"], |
| 1482 | aidl: { enforce_permissions: true, enforce_permissions_exceptions: ["aidl/foo/IFoo2.aidl"] }, |
| 1483 | } |
| 1484 | `) |
| 1485 | |
| 1486 | aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command |
| 1487 | expectedAidlFlag := "$$FLAGS -Wmissing-permission-annotation -Werror aidl/foo/IFoo.aidl" |
| 1488 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 1489 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 1490 | } |
| 1491 | expectedAidlFlag = "$$FLAGS aidl/foo/IFoo2.aidl" |
| 1492 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 1493 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 1494 | } |
| 1495 | } |
| 1496 | |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1497 | func TestDataNativeBinaries(t *testing.T) { |
Cole Faust | 5c503d1 | 2023-01-24 11:48:08 -0800 | [diff] [blame] | 1498 | ctx := android.GroupFixturePreparers( |
| 1499 | prepareForJavaTest, |
| 1500 | android.PrepareForTestWithAllowMissingDependencies).RunTestWithBp(t, ` |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1501 | java_test_host { |
| 1502 | name: "foo", |
| 1503 | srcs: ["a.java"], |
| 1504 | data_native_bins: ["bin"] |
| 1505 | } |
| 1506 | |
Cole Faust | 5c503d1 | 2023-01-24 11:48:08 -0800 | [diff] [blame] | 1507 | cc_binary_host { |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1508 | name: "bin", |
Cole Faust | 5c503d1 | 2023-01-24 11:48:08 -0800 | [diff] [blame] | 1509 | srcs: ["bin.cpp"], |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1510 | } |
Cole Faust | 5c503d1 | 2023-01-24 11:48:08 -0800 | [diff] [blame] | 1511 | `).TestContext |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1512 | |
Colin Cross | 0c66bc6 | 2021-07-20 09:47:41 -0700 | [diff] [blame] | 1513 | buildOS := ctx.Config().BuildOS.String() |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1514 | |
| 1515 | test := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 1516 | entries := android.AndroidMkEntriesForTest(t, ctx, test)[0] |
Cole Faust | 5c503d1 | 2023-01-24 11:48:08 -0800 | [diff] [blame] | 1517 | expected := []string{"out/soong/.intermediates/bin/" + buildOS + "_x86_64/bin:bin"} |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1518 | actual := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"] |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1519 | android.AssertStringPathsRelativeToTopEquals(t, "LOCAL_COMPATIBILITY_SUPPORT_FILES", ctx.Config(), expected, actual) |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1520 | } |
Yuexi Ma | 627263f | 2021-03-04 13:47:56 -0800 | [diff] [blame] | 1521 | |
| 1522 | func TestDefaultInstallable(t *testing.T) { |
| 1523 | ctx, _ := testJava(t, ` |
| 1524 | java_test_host { |
| 1525 | name: "foo" |
| 1526 | } |
| 1527 | `) |
| 1528 | |
Colin Cross | 0c66bc6 | 2021-07-20 09:47:41 -0700 | [diff] [blame] | 1529 | buildOS := ctx.Config().BuildOS.String() |
Yuexi Ma | 627263f | 2021-03-04 13:47:56 -0800 | [diff] [blame] | 1530 | module := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost) |
| 1531 | assertDeepEquals(t, "Default installable value should be true.", proptools.BoolPtr(true), |
| 1532 | module.properties.Installable) |
| 1533 | } |
Cole Faust | 75fffb1 | 2021-06-13 15:23:16 -0700 | [diff] [blame] | 1534 | |
| 1535 | func TestErrorproneEnabled(t *testing.T) { |
| 1536 | ctx, _ := testJava(t, ` |
| 1537 | java_library { |
| 1538 | name: "foo", |
| 1539 | srcs: ["a.java"], |
| 1540 | errorprone: { |
| 1541 | enabled: true, |
| 1542 | }, |
| 1543 | } |
| 1544 | `) |
| 1545 | |
| 1546 | javac := ctx.ModuleForTests("foo", "android_common").Description("javac") |
| 1547 | |
| 1548 | // Test that the errorprone plugins are passed to javac |
| 1549 | expectedSubstring := "-Xplugin:ErrorProne" |
| 1550 | if !strings.Contains(javac.Args["javacFlags"], expectedSubstring) { |
Cole Faust | 2b1536e | 2021-06-18 12:25:54 -0700 | [diff] [blame] | 1551 | t.Errorf("expected javacFlags to contain %q, got %q", expectedSubstring, javac.Args["javacFlags"]) |
Cole Faust | 75fffb1 | 2021-06-13 15:23:16 -0700 | [diff] [blame] | 1552 | } |
| 1553 | |
| 1554 | // Modules with errorprone { enabled: true } will include errorprone checks |
| 1555 | // in the main javac build rule. Only when RUN_ERROR_PRONE is true will |
| 1556 | // the explicit errorprone build rule be created. |
| 1557 | errorprone := ctx.ModuleForTests("foo", "android_common").MaybeDescription("errorprone") |
| 1558 | if errorprone.RuleParams.Description != "" { |
| 1559 | t.Errorf("expected errorprone build rule to not exist, but it did") |
| 1560 | } |
| 1561 | } |
Cole Faust | 2b1536e | 2021-06-18 12:25:54 -0700 | [diff] [blame] | 1562 | |
| 1563 | func TestErrorproneDisabled(t *testing.T) { |
| 1564 | bp := ` |
| 1565 | java_library { |
| 1566 | name: "foo", |
| 1567 | srcs: ["a.java"], |
| 1568 | errorprone: { |
| 1569 | enabled: false, |
| 1570 | }, |
| 1571 | } |
| 1572 | ` |
| 1573 | ctx := android.GroupFixturePreparers( |
| 1574 | PrepareForTestWithJavaDefaultModules, |
| 1575 | android.FixtureMergeEnv(map[string]string{ |
| 1576 | "RUN_ERROR_PRONE": "true", |
| 1577 | }), |
| 1578 | ).RunTestWithBp(t, bp) |
| 1579 | |
| 1580 | javac := ctx.ModuleForTests("foo", "android_common").Description("javac") |
| 1581 | |
| 1582 | // Test that the errorprone plugins are not passed to javac, like they would |
| 1583 | // be if enabled was true. |
| 1584 | expectedSubstring := "-Xplugin:ErrorProne" |
| 1585 | if strings.Contains(javac.Args["javacFlags"], expectedSubstring) { |
| 1586 | t.Errorf("expected javacFlags to not contain %q, got %q", expectedSubstring, javac.Args["javacFlags"]) |
| 1587 | } |
| 1588 | |
| 1589 | // Check that no errorprone build rule is created, like there would be |
| 1590 | // if enabled was unset and RUN_ERROR_PRONE was true. |
| 1591 | errorprone := ctx.ModuleForTests("foo", "android_common").MaybeDescription("errorprone") |
| 1592 | if errorprone.RuleParams.Description != "" { |
| 1593 | t.Errorf("expected errorprone build rule to not exist, but it did") |
| 1594 | } |
| 1595 | } |
| 1596 | |
| 1597 | func TestErrorproneEnabledOnlyByEnvironmentVariable(t *testing.T) { |
| 1598 | bp := ` |
| 1599 | java_library { |
| 1600 | name: "foo", |
| 1601 | srcs: ["a.java"], |
| 1602 | } |
| 1603 | ` |
| 1604 | ctx := android.GroupFixturePreparers( |
| 1605 | PrepareForTestWithJavaDefaultModules, |
| 1606 | android.FixtureMergeEnv(map[string]string{ |
| 1607 | "RUN_ERROR_PRONE": "true", |
| 1608 | }), |
| 1609 | ).RunTestWithBp(t, bp) |
| 1610 | |
| 1611 | javac := ctx.ModuleForTests("foo", "android_common").Description("javac") |
| 1612 | errorprone := ctx.ModuleForTests("foo", "android_common").Description("errorprone") |
| 1613 | |
| 1614 | // Check that the errorprone plugins are not passed to javac, because they |
| 1615 | // will instead be passed to the separate errorprone compilation |
| 1616 | expectedSubstring := "-Xplugin:ErrorProne" |
| 1617 | if strings.Contains(javac.Args["javacFlags"], expectedSubstring) { |
| 1618 | t.Errorf("expected javacFlags to not contain %q, got %q", expectedSubstring, javac.Args["javacFlags"]) |
| 1619 | } |
| 1620 | |
| 1621 | // Check that the errorprone plugin is enabled |
| 1622 | if !strings.Contains(errorprone.Args["javacFlags"], expectedSubstring) { |
| 1623 | t.Errorf("expected errorprone to contain %q, got %q", expectedSubstring, javac.Args["javacFlags"]) |
| 1624 | } |
| 1625 | } |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1626 | |
| 1627 | func TestDataDeviceBinsBuildsDeviceBinary(t *testing.T) { |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1628 | testCases := []struct { |
| 1629 | dataDeviceBinType string |
| 1630 | depCompileMultilib string |
| 1631 | variants []string |
| 1632 | expectedError string |
| 1633 | }{ |
| 1634 | { |
| 1635 | dataDeviceBinType: "first", |
| 1636 | depCompileMultilib: "first", |
| 1637 | variants: []string{"android_arm64_armv8-a"}, |
| 1638 | }, |
| 1639 | { |
| 1640 | dataDeviceBinType: "first", |
| 1641 | depCompileMultilib: "both", |
| 1642 | variants: []string{"android_arm64_armv8-a"}, |
| 1643 | }, |
| 1644 | { |
| 1645 | // this is true because our testing framework is set up with |
| 1646 | // Targets ~ [<64bit target>, <32bit target>], where 64bit is "first" |
| 1647 | dataDeviceBinType: "first", |
| 1648 | depCompileMultilib: "32", |
| 1649 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1650 | }, |
| 1651 | { |
| 1652 | dataDeviceBinType: "first", |
| 1653 | depCompileMultilib: "64", |
| 1654 | variants: []string{"android_arm64_armv8-a"}, |
| 1655 | }, |
| 1656 | { |
| 1657 | dataDeviceBinType: "both", |
| 1658 | depCompileMultilib: "both", |
| 1659 | variants: []string{ |
| 1660 | "android_arm_armv7-a-neon", |
| 1661 | "android_arm64_armv8-a", |
| 1662 | }, |
| 1663 | }, |
| 1664 | { |
| 1665 | dataDeviceBinType: "both", |
| 1666 | depCompileMultilib: "32", |
| 1667 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1668 | }, |
| 1669 | { |
| 1670 | dataDeviceBinType: "both", |
| 1671 | depCompileMultilib: "64", |
| 1672 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1673 | }, |
| 1674 | { |
| 1675 | dataDeviceBinType: "both", |
| 1676 | depCompileMultilib: "first", |
| 1677 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1678 | }, |
| 1679 | { |
| 1680 | dataDeviceBinType: "32", |
| 1681 | depCompileMultilib: "32", |
| 1682 | variants: []string{"android_arm_armv7-a-neon"}, |
| 1683 | }, |
| 1684 | { |
| 1685 | dataDeviceBinType: "32", |
| 1686 | depCompileMultilib: "first", |
| 1687 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1688 | }, |
| 1689 | { |
| 1690 | dataDeviceBinType: "32", |
| 1691 | depCompileMultilib: "both", |
| 1692 | variants: []string{"android_arm_armv7-a-neon"}, |
| 1693 | }, |
| 1694 | { |
| 1695 | dataDeviceBinType: "32", |
| 1696 | depCompileMultilib: "64", |
| 1697 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1698 | }, |
| 1699 | { |
| 1700 | dataDeviceBinType: "64", |
| 1701 | depCompileMultilib: "64", |
| 1702 | variants: []string{"android_arm64_armv8-a"}, |
| 1703 | }, |
| 1704 | { |
| 1705 | dataDeviceBinType: "64", |
| 1706 | depCompileMultilib: "both", |
| 1707 | variants: []string{"android_arm64_armv8-a"}, |
| 1708 | }, |
| 1709 | { |
| 1710 | dataDeviceBinType: "64", |
| 1711 | depCompileMultilib: "first", |
| 1712 | variants: []string{"android_arm64_armv8-a"}, |
| 1713 | }, |
| 1714 | { |
| 1715 | dataDeviceBinType: "64", |
| 1716 | depCompileMultilib: "32", |
| 1717 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1718 | }, |
| 1719 | { |
| 1720 | dataDeviceBinType: "prefer32", |
| 1721 | depCompileMultilib: "32", |
| 1722 | variants: []string{"android_arm_armv7-a-neon"}, |
| 1723 | }, |
| 1724 | { |
| 1725 | dataDeviceBinType: "prefer32", |
| 1726 | depCompileMultilib: "both", |
| 1727 | variants: []string{"android_arm_armv7-a-neon"}, |
| 1728 | }, |
| 1729 | { |
| 1730 | dataDeviceBinType: "prefer32", |
| 1731 | depCompileMultilib: "first", |
| 1732 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1733 | }, |
| 1734 | { |
| 1735 | dataDeviceBinType: "prefer32", |
| 1736 | depCompileMultilib: "64", |
| 1737 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1738 | }, |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1739 | } |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1740 | |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1741 | bpTemplate := ` |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1742 | java_test_host { |
| 1743 | name: "foo", |
| 1744 | srcs: ["test.java"], |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1745 | data_device_bins_%s: ["bar"], |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1746 | } |
| 1747 | |
| 1748 | cc_binary { |
| 1749 | name: "bar", |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1750 | compile_multilib: "%s", |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1751 | } |
| 1752 | ` |
| 1753 | |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1754 | for _, tc := range testCases { |
| 1755 | bp := fmt.Sprintf(bpTemplate, tc.dataDeviceBinType, tc.depCompileMultilib) |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1756 | |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1757 | errorHandler := android.FixtureExpectsNoErrors |
| 1758 | if tc.expectedError != "" { |
| 1759 | errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(tc.expectedError) |
| 1760 | } |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1761 | |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1762 | testName := fmt.Sprintf(`data_device_bins_%s with compile_multilib:"%s"`, tc.dataDeviceBinType, tc.depCompileMultilib) |
| 1763 | t.Run(testName, func(t *testing.T) { |
| 1764 | ctx := android.GroupFixturePreparers(PrepareForIntegrationTestWithJava). |
| 1765 | ExtendWithErrorHandler(errorHandler). |
| 1766 | RunTestWithBp(t, bp) |
| 1767 | if tc.expectedError != "" { |
| 1768 | return |
| 1769 | } |
| 1770 | |
| 1771 | buildOS := ctx.Config.BuildOS.String() |
| 1772 | fooVariant := ctx.ModuleForTests("foo", buildOS+"_common") |
| 1773 | fooMod := fooVariant.Module().(*TestHost) |
| 1774 | entries := android.AndroidMkEntriesForTest(t, ctx.TestContext, fooMod)[0] |
| 1775 | |
| 1776 | expectedAutogenConfig := `<option name="push-file" key="bar" value="/data/local/tests/unrestricted/foo/bar" />` |
| 1777 | autogen := fooVariant.Rule("autogen") |
| 1778 | if !strings.Contains(autogen.Args["extraConfigs"], expectedAutogenConfig) { |
| 1779 | t.Errorf("foo extraConfigs %v does not contain %q", autogen.Args["extraConfigs"], expectedAutogenConfig) |
| 1780 | } |
| 1781 | |
| 1782 | expectedData := []string{} |
| 1783 | for _, variant := range tc.variants { |
| 1784 | barVariant := ctx.ModuleForTests("bar", variant) |
| 1785 | relocated := barVariant.Output("bar") |
| 1786 | expectedInput := fmt.Sprintf("out/soong/.intermediates/bar/%s/unstripped/bar", variant) |
| 1787 | android.AssertPathRelativeToTopEquals(t, "relocation input", expectedInput, relocated.Input) |
| 1788 | |
| 1789 | expectedData = append(expectedData, fmt.Sprintf("out/soong/.intermediates/bar/%s/bar:bar", variant)) |
| 1790 | } |
| 1791 | |
| 1792 | actualData := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"] |
| 1793 | android.AssertStringPathsRelativeToTopEquals(t, "LOCAL_TEST_DATA", ctx.Config, expectedData, actualData) |
| 1794 | }) |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1795 | } |
| 1796 | } |
Sam Delmerico | 277795c | 2022-02-25 17:04:37 +0000 | [diff] [blame] | 1797 | |
Zi Wang | ca65b40 | 2022-10-10 13:45:06 -0700 | [diff] [blame] | 1798 | func TestDeviceBinaryWrapperGeneration(t *testing.T) { |
| 1799 | // Scenario 1: java_binary has main_class property in its bp |
| 1800 | ctx, _ := testJava(t, ` |
| 1801 | java_binary { |
| 1802 | name: "foo", |
| 1803 | srcs: ["foo.java"], |
| 1804 | main_class: "foo.bar.jb", |
| 1805 | } |
| 1806 | `) |
| 1807 | wrapperPath := fmt.Sprint(ctx.ModuleForTests("foo", "android_arm64_armv8-a").AllOutputs()) |
| 1808 | if !strings.Contains(wrapperPath, "foo.sh") { |
| 1809 | t.Errorf("wrapper file foo.sh is not generated") |
| 1810 | } |
| 1811 | |
| 1812 | // Scenario 2: java_binary has neither wrapper nor main_class, its build |
| 1813 | // is expected to be failed. |
| 1814 | testJavaError(t, "main_class property is required for device binary if no default wrapper is assigned", ` |
| 1815 | java_binary { |
| 1816 | name: "foo", |
| 1817 | srcs: ["foo.java"], |
| 1818 | }`) |
| 1819 | } |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1820 | |
Jihoon Kang | 3198f3c | 2023-01-26 08:08:52 +0000 | [diff] [blame] | 1821 | func TestJavaApiContributionEmptyApiFile(t *testing.T) { |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 1822 | android.GroupFixturePreparers( |
| 1823 | prepareForJavaTest, |
| 1824 | android.FixtureMergeEnv( |
| 1825 | map[string]string{ |
| 1826 | "DISABLE_STUB_VALIDATION": "true", |
| 1827 | }, |
| 1828 | ), |
| 1829 | ).ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern( |
Jihoon Kang | 3198f3c | 2023-01-26 08:08:52 +0000 | [diff] [blame] | 1830 | "Error: foo has an empty api file.", |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 1831 | )).RunTestWithBp(t, ` |
| 1832 | java_api_contribution { |
Jihoon Kang | 3198f3c | 2023-01-26 08:08:52 +0000 | [diff] [blame] | 1833 | name: "foo", |
| 1834 | } |
| 1835 | java_api_library { |
| 1836 | name: "bar", |
| 1837 | api_surface: "public", |
| 1838 | api_contributions: ["foo"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 1839 | stubs_type: "everything", |
Jihoon Kang | 3198f3c | 2023-01-26 08:08:52 +0000 | [diff] [blame] | 1840 | } |
| 1841 | `) |
| 1842 | } |
| 1843 | |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1844 | func TestJavaApiLibraryAndProviderLink(t *testing.T) { |
| 1845 | provider_bp_a := ` |
| 1846 | java_api_contribution { |
| 1847 | name: "foo1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 1848 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 1849 | api_surface: "public", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1850 | } |
| 1851 | ` |
| 1852 | provider_bp_b := `java_api_contribution { |
| 1853 | name: "foo2", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 1854 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 1855 | api_surface: "public", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1856 | } |
| 1857 | ` |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 1858 | ctx := android.GroupFixturePreparers( |
| 1859 | prepareForJavaTest, |
| 1860 | android.FixtureMergeMockFs( |
| 1861 | map[string][]byte{ |
| 1862 | "a/Android.bp": []byte(provider_bp_a), |
| 1863 | "b/Android.bp": []byte(provider_bp_b), |
| 1864 | }, |
| 1865 | ), |
| 1866 | android.FixtureMergeEnv( |
| 1867 | map[string]string{ |
| 1868 | "DISABLE_STUB_VALIDATION": "true", |
| 1869 | }, |
| 1870 | ), |
| 1871 | ).RunTestWithBp(t, ` |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1872 | java_api_library { |
| 1873 | name: "bar1", |
| 1874 | api_surface: "public", |
Jihoon Kang | 60d4a09 | 2022-11-17 23:47:43 +0000 | [diff] [blame] | 1875 | api_contributions: ["foo1"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 1876 | stubs_type: "everything", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1877 | } |
| 1878 | |
| 1879 | java_api_library { |
| 1880 | name: "bar2", |
| 1881 | api_surface: "system", |
Jihoon Kang | 60d4a09 | 2022-11-17 23:47:43 +0000 | [diff] [blame] | 1882 | api_contributions: ["foo1", "foo2"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 1883 | stubs_type: "everything", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1884 | } |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 1885 | `) |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1886 | |
| 1887 | testcases := []struct { |
| 1888 | moduleName string |
| 1889 | sourceTextFileDirs []string |
| 1890 | }{ |
| 1891 | { |
| 1892 | moduleName: "bar1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 1893 | sourceTextFileDirs: []string{"a/current.txt"}, |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1894 | }, |
| 1895 | { |
| 1896 | moduleName: "bar2", |
Jihoon Kang | 6be0f00 | 2023-09-20 23:03:01 +0000 | [diff] [blame] | 1897 | sourceTextFileDirs: []string{"a/current.txt", "b/current.txt"}, |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1898 | }, |
| 1899 | } |
| 1900 | for _, c := range testcases { |
| 1901 | m := ctx.ModuleForTests(c.moduleName, "android_common") |
| 1902 | manifest := m.Output("metalava.sbox.textproto") |
Colin Cross | f61d03d | 2023-11-02 16:56:39 -0700 | [diff] [blame] | 1903 | sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx.TestContext, manifest) |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1904 | manifestCommand := sboxProto.Commands[0].GetCommand() |
| 1905 | sourceFilesFlag := "--source-files " + strings.Join(c.sourceTextFileDirs, " ") |
| 1906 | android.AssertStringDoesContain(t, "source text files not present", manifestCommand, sourceFilesFlag) |
| 1907 | } |
| 1908 | } |
| 1909 | |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1910 | func TestJavaApiLibraryAndDefaultsLink(t *testing.T) { |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 1911 | provider_bp_a := ` |
| 1912 | java_api_contribution { |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1913 | name: "foo1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 1914 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 1915 | api_surface: "public", |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1916 | } |
| 1917 | ` |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 1918 | provider_bp_b := ` |
| 1919 | java_api_contribution { |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1920 | name: "foo2", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 1921 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 1922 | api_surface: "public", |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1923 | } |
| 1924 | ` |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 1925 | provider_bp_c := ` |
| 1926 | java_api_contribution { |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1927 | name: "foo3", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 1928 | api_file: "system-current.txt", |
| 1929 | api_surface: "system", |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1930 | } |
| 1931 | ` |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 1932 | provider_bp_d := ` |
| 1933 | java_api_contribution { |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1934 | name: "foo4", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 1935 | api_file: "system-current.txt", |
| 1936 | api_surface: "system", |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1937 | } |
| 1938 | ` |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 1939 | ctx := android.GroupFixturePreparers( |
| 1940 | prepareForJavaTest, |
| 1941 | android.FixtureMergeMockFs( |
| 1942 | map[string][]byte{ |
| 1943 | "a/Android.bp": []byte(provider_bp_a), |
| 1944 | "b/Android.bp": []byte(provider_bp_b), |
| 1945 | "c/Android.bp": []byte(provider_bp_c), |
| 1946 | "d/Android.bp": []byte(provider_bp_d), |
| 1947 | }, |
| 1948 | ), |
| 1949 | android.FixtureMergeEnv( |
| 1950 | map[string]string{ |
| 1951 | "DISABLE_STUB_VALIDATION": "true", |
| 1952 | }, |
| 1953 | ), |
| 1954 | ).RunTestWithBp(t, ` |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1955 | java_defaults { |
| 1956 | name: "baz1", |
| 1957 | api_surface: "public", |
| 1958 | api_contributions: ["foo1", "foo2"], |
| 1959 | } |
| 1960 | |
| 1961 | java_defaults { |
| 1962 | name: "baz2", |
| 1963 | api_surface: "system", |
| 1964 | api_contributions: ["foo3"], |
| 1965 | } |
| 1966 | |
| 1967 | java_api_library { |
| 1968 | name: "bar1", |
| 1969 | api_surface: "public", |
| 1970 | api_contributions: ["foo1"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 1971 | stubs_type: "everything", |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1972 | } |
| 1973 | |
| 1974 | java_api_library { |
| 1975 | name: "bar2", |
| 1976 | api_surface: "public", |
| 1977 | defaults:["baz1"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 1978 | stubs_type: "everything", |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1979 | } |
| 1980 | |
| 1981 | java_api_library { |
| 1982 | name: "bar3", |
| 1983 | api_surface: "system", |
| 1984 | defaults:["baz1", "baz2"], |
| 1985 | api_contributions: ["foo4"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 1986 | stubs_type: "everything", |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1987 | } |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 1988 | `) |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1989 | |
| 1990 | testcases := []struct { |
| 1991 | moduleName string |
| 1992 | sourceTextFileDirs []string |
| 1993 | }{ |
| 1994 | { |
| 1995 | moduleName: "bar1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 1996 | sourceTextFileDirs: []string{"a/current.txt"}, |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1997 | }, |
| 1998 | { |
| 1999 | moduleName: "bar2", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2000 | sourceTextFileDirs: []string{"a/current.txt", "b/current.txt"}, |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2001 | }, |
| 2002 | { |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2003 | moduleName: "bar3", |
| 2004 | // API text files need to be sorted from the narrower api scope to the wider api scope |
Jihoon Kang | 6be0f00 | 2023-09-20 23:03:01 +0000 | [diff] [blame] | 2005 | sourceTextFileDirs: []string{"a/current.txt", "b/current.txt", "c/system-current.txt", "d/system-current.txt"}, |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2006 | }, |
| 2007 | } |
| 2008 | for _, c := range testcases { |
| 2009 | m := ctx.ModuleForTests(c.moduleName, "android_common") |
| 2010 | manifest := m.Output("metalava.sbox.textproto") |
Colin Cross | f61d03d | 2023-11-02 16:56:39 -0700 | [diff] [blame] | 2011 | sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx.TestContext, manifest) |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 2012 | manifestCommand := sboxProto.Commands[0].GetCommand() |
| 2013 | sourceFilesFlag := "--source-files " + strings.Join(c.sourceTextFileDirs, " ") |
| 2014 | android.AssertStringDoesContain(t, "source text files not present", manifestCommand, sourceFilesFlag) |
| 2015 | } |
| 2016 | } |
| 2017 | |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2018 | func TestJavaApiLibraryJarGeneration(t *testing.T) { |
| 2019 | provider_bp_a := ` |
| 2020 | java_api_contribution { |
| 2021 | name: "foo1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2022 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2023 | api_surface: "public", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2024 | } |
| 2025 | ` |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2026 | provider_bp_b := ` |
| 2027 | java_api_contribution { |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2028 | name: "foo2", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2029 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2030 | api_surface: "public", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2031 | } |
| 2032 | ` |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2033 | ctx := android.GroupFixturePreparers( |
| 2034 | prepareForJavaTest, |
| 2035 | android.FixtureMergeMockFs( |
| 2036 | map[string][]byte{ |
| 2037 | "a/Android.bp": []byte(provider_bp_a), |
| 2038 | "b/Android.bp": []byte(provider_bp_b), |
| 2039 | }, |
| 2040 | ), |
| 2041 | android.FixtureMergeEnv( |
| 2042 | map[string]string{ |
| 2043 | "DISABLE_STUB_VALIDATION": "true", |
| 2044 | }, |
| 2045 | ), |
| 2046 | ).RunTestWithBp(t, ` |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2047 | java_api_library { |
| 2048 | name: "bar1", |
| 2049 | api_surface: "public", |
Jihoon Kang | 60d4a09 | 2022-11-17 23:47:43 +0000 | [diff] [blame] | 2050 | api_contributions: ["foo1"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2051 | stubs_type: "everything", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2052 | } |
| 2053 | |
| 2054 | java_api_library { |
| 2055 | name: "bar2", |
| 2056 | api_surface: "system", |
Jihoon Kang | 60d4a09 | 2022-11-17 23:47:43 +0000 | [diff] [blame] | 2057 | api_contributions: ["foo1", "foo2"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2058 | stubs_type: "everything", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2059 | } |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2060 | `) |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2061 | |
| 2062 | testcases := []struct { |
| 2063 | moduleName string |
| 2064 | outputJarName string |
| 2065 | }{ |
| 2066 | { |
| 2067 | moduleName: "bar1", |
Jihoon Kang | 25857f5 | 2023-03-01 00:27:32 +0000 | [diff] [blame] | 2068 | outputJarName: "bar1/bar1.jar", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2069 | }, |
| 2070 | { |
| 2071 | moduleName: "bar2", |
Jihoon Kang | 25857f5 | 2023-03-01 00:27:32 +0000 | [diff] [blame] | 2072 | outputJarName: "bar2/bar2.jar", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 2073 | }, |
| 2074 | } |
| 2075 | for _, c := range testcases { |
| 2076 | m := ctx.ModuleForTests(c.moduleName, "android_common") |
| 2077 | outputs := fmt.Sprint(m.AllOutputs()) |
| 2078 | if !strings.Contains(outputs, c.outputJarName) { |
| 2079 | t.Errorf("Module output does not contain expected jar %s", c.outputJarName) |
| 2080 | } |
| 2081 | } |
| 2082 | } |
Cole Faust | 2168054 | 2022-12-07 18:18:37 -0800 | [diff] [blame] | 2083 | |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2084 | func TestJavaApiLibraryLibsLink(t *testing.T) { |
| 2085 | provider_bp_a := ` |
| 2086 | java_api_contribution { |
| 2087 | name: "foo1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2088 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2089 | api_surface: "public", |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2090 | } |
| 2091 | ` |
| 2092 | provider_bp_b := ` |
| 2093 | java_api_contribution { |
| 2094 | name: "foo2", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2095 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2096 | api_surface: "public", |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2097 | } |
| 2098 | ` |
| 2099 | lib_bp_a := ` |
| 2100 | java_library { |
| 2101 | name: "lib1", |
| 2102 | srcs: ["Lib.java"], |
| 2103 | } |
| 2104 | ` |
| 2105 | lib_bp_b := ` |
| 2106 | java_library { |
| 2107 | name: "lib2", |
| 2108 | srcs: ["Lib.java"], |
| 2109 | } |
| 2110 | ` |
| 2111 | |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2112 | ctx := android.GroupFixturePreparers( |
| 2113 | prepareForJavaTest, |
| 2114 | android.FixtureMergeMockFs( |
| 2115 | map[string][]byte{ |
| 2116 | "a/Android.bp": []byte(provider_bp_a), |
| 2117 | "b/Android.bp": []byte(provider_bp_b), |
| 2118 | "c/Android.bp": []byte(lib_bp_a), |
| 2119 | "c/Lib.java": {}, |
| 2120 | "d/Android.bp": []byte(lib_bp_b), |
| 2121 | "d/Lib.java": {}, |
| 2122 | }, |
| 2123 | ), |
| 2124 | android.FixtureMergeEnv( |
| 2125 | map[string]string{ |
| 2126 | "DISABLE_STUB_VALIDATION": "true", |
| 2127 | }, |
| 2128 | ), |
| 2129 | ).RunTestWithBp(t, ` |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2130 | java_api_library { |
| 2131 | name: "bar1", |
| 2132 | api_surface: "public", |
| 2133 | api_contributions: ["foo1"], |
| 2134 | libs: ["lib1"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2135 | stubs_type: "everything", |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2136 | } |
| 2137 | |
| 2138 | java_api_library { |
| 2139 | name: "bar2", |
| 2140 | api_surface: "system", |
| 2141 | api_contributions: ["foo1", "foo2"], |
| 2142 | libs: ["lib1", "lib2", "bar1"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2143 | stubs_type: "everything", |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2144 | } |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2145 | `) |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2146 | |
| 2147 | testcases := []struct { |
| 2148 | moduleName string |
| 2149 | classPathJarNames []string |
| 2150 | }{ |
| 2151 | { |
| 2152 | moduleName: "bar1", |
| 2153 | classPathJarNames: []string{"lib1.jar"}, |
| 2154 | }, |
| 2155 | { |
| 2156 | moduleName: "bar2", |
Jihoon Kang | 25857f5 | 2023-03-01 00:27:32 +0000 | [diff] [blame] | 2157 | classPathJarNames: []string{"lib1.jar", "lib2.jar", "bar1/bar1.jar"}, |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2158 | }, |
| 2159 | } |
| 2160 | for _, c := range testcases { |
| 2161 | m := ctx.ModuleForTests(c.moduleName, "android_common") |
| 2162 | javacRules := m.Rule("javac") |
| 2163 | classPathArgs := javacRules.Args["classpath"] |
| 2164 | for _, jarName := range c.classPathJarNames { |
| 2165 | if !strings.Contains(classPathArgs, jarName) { |
| 2166 | t.Errorf("Module output does not contain expected jar %s", jarName) |
| 2167 | } |
| 2168 | } |
| 2169 | } |
| 2170 | } |
| 2171 | |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2172 | func TestJavaApiLibraryStaticLibsLink(t *testing.T) { |
| 2173 | provider_bp_a := ` |
| 2174 | java_api_contribution { |
| 2175 | name: "foo1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2176 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2177 | api_surface: "public", |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2178 | } |
| 2179 | ` |
| 2180 | provider_bp_b := ` |
| 2181 | java_api_contribution { |
| 2182 | name: "foo2", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2183 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2184 | api_surface: "public", |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2185 | } |
| 2186 | ` |
| 2187 | lib_bp_a := ` |
| 2188 | java_library { |
| 2189 | name: "lib1", |
| 2190 | srcs: ["Lib.java"], |
| 2191 | } |
| 2192 | ` |
| 2193 | lib_bp_b := ` |
| 2194 | java_library { |
| 2195 | name: "lib2", |
| 2196 | srcs: ["Lib.java"], |
| 2197 | } |
| 2198 | ` |
| 2199 | |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2200 | ctx := android.GroupFixturePreparers( |
| 2201 | prepareForJavaTest, |
| 2202 | android.FixtureMergeMockFs( |
| 2203 | map[string][]byte{ |
| 2204 | "a/Android.bp": []byte(provider_bp_a), |
| 2205 | "b/Android.bp": []byte(provider_bp_b), |
| 2206 | "c/Android.bp": []byte(lib_bp_a), |
| 2207 | "c/Lib.java": {}, |
| 2208 | "d/Android.bp": []byte(lib_bp_b), |
| 2209 | "d/Lib.java": {}, |
| 2210 | }, |
| 2211 | ), |
| 2212 | android.FixtureMergeEnv( |
| 2213 | map[string]string{ |
| 2214 | "DISABLE_STUB_VALIDATION": "true", |
| 2215 | }, |
| 2216 | ), |
| 2217 | ).RunTestWithBp(t, ` |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2218 | java_api_library { |
| 2219 | name: "bar1", |
| 2220 | api_surface: "public", |
| 2221 | api_contributions: ["foo1"], |
| 2222 | static_libs: ["lib1"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2223 | stubs_type: "everything", |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2224 | } |
| 2225 | |
| 2226 | java_api_library { |
| 2227 | name: "bar2", |
| 2228 | api_surface: "system", |
| 2229 | api_contributions: ["foo1", "foo2"], |
| 2230 | static_libs: ["lib1", "lib2", "bar1"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2231 | stubs_type: "everything", |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2232 | } |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2233 | `) |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2234 | |
| 2235 | testcases := []struct { |
| 2236 | moduleName string |
| 2237 | staticLibJarNames []string |
| 2238 | }{ |
| 2239 | { |
| 2240 | moduleName: "bar1", |
| 2241 | staticLibJarNames: []string{"lib1.jar"}, |
| 2242 | }, |
| 2243 | { |
| 2244 | moduleName: "bar2", |
Jihoon Kang | 25857f5 | 2023-03-01 00:27:32 +0000 | [diff] [blame] | 2245 | staticLibJarNames: []string{"lib1.jar", "lib2.jar", "bar1/bar1.jar"}, |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2246 | }, |
| 2247 | } |
| 2248 | for _, c := range testcases { |
| 2249 | m := ctx.ModuleForTests(c.moduleName, "android_common") |
| 2250 | mergeZipsCommand := m.Rule("merge_zips").RuleParams.Command |
| 2251 | for _, jarName := range c.staticLibJarNames { |
| 2252 | if !strings.Contains(mergeZipsCommand, jarName) { |
| 2253 | t.Errorf("merge_zips command does not contain expected jar %s", jarName) |
| 2254 | } |
| 2255 | } |
| 2256 | } |
| 2257 | } |
| 2258 | |
Anton Hansson | 0e73f9e | 2023-09-20 13:39:57 +0000 | [diff] [blame] | 2259 | func TestTransitiveSrcFiles(t *testing.T) { |
| 2260 | ctx, _ := testJava(t, ` |
| 2261 | java_library { |
| 2262 | name: "a", |
| 2263 | srcs: ["a.java"], |
| 2264 | } |
| 2265 | java_library { |
| 2266 | name: "b", |
| 2267 | srcs: ["b.java"], |
| 2268 | } |
| 2269 | java_library { |
| 2270 | name: "c", |
| 2271 | srcs: ["c.java"], |
| 2272 | libs: ["a"], |
| 2273 | static_libs: ["b"], |
| 2274 | } |
| 2275 | `) |
| 2276 | c := ctx.ModuleForTests("c", "android_common").Module() |
Colin Cross | 5a37718 | 2023-12-14 14:46:23 -0800 | [diff] [blame] | 2277 | javaInfo, _ := android.SingletonModuleProvider(ctx, c, JavaInfoProvider) |
| 2278 | transitiveSrcFiles := android.Paths(javaInfo.TransitiveSrcFiles.ToList()) |
Anton Hansson | 0e73f9e | 2023-09-20 13:39:57 +0000 | [diff] [blame] | 2279 | android.AssertArrayString(t, "unexpected jar deps", []string{"b.java", "c.java"}, transitiveSrcFiles.Strings()) |
| 2280 | } |
| 2281 | |
Cole Faust | 2168054 | 2022-12-07 18:18:37 -0800 | [diff] [blame] | 2282 | func TestTradefedOptions(t *testing.T) { |
| 2283 | result := PrepareForTestWithJavaBuildComponents.RunTestWithBp(t, ` |
| 2284 | java_test_host { |
| 2285 | name: "foo", |
| 2286 | test_options: { |
| 2287 | tradefed_options: [ |
| 2288 | { |
| 2289 | name: "exclude-path", |
| 2290 | value: "org/apache" |
| 2291 | } |
| 2292 | ] |
| 2293 | } |
| 2294 | } |
| 2295 | `) |
| 2296 | |
| 2297 | buildOS := result.Config.BuildOS.String() |
| 2298 | args := result.ModuleForTests("foo", buildOS+"_common"). |
| 2299 | Output("out/soong/.intermediates/foo/" + buildOS + "_common/foo.config").Args |
| 2300 | expected := proptools.NinjaAndShellEscape("<option name=\"exclude-path\" value=\"org/apache\" />") |
| 2301 | if args["extraConfigs"] != expected { |
| 2302 | t.Errorf("Expected args[\"extraConfigs\"] to equal %q, was %q", expected, args["extraConfigs"]) |
| 2303 | } |
| 2304 | } |
Dan Shi | ec73143 | 2023-05-26 04:21:44 +0000 | [diff] [blame] | 2305 | |
| 2306 | func TestTestRunnerOptions(t *testing.T) { |
| 2307 | result := PrepareForTestWithJavaBuildComponents.RunTestWithBp(t, ` |
| 2308 | java_test_host { |
| 2309 | name: "foo", |
| 2310 | test_options: { |
| 2311 | test_runner_options: [ |
| 2312 | { |
| 2313 | name: "test-timeout", |
| 2314 | value: "10m" |
| 2315 | } |
| 2316 | ] |
| 2317 | } |
| 2318 | } |
| 2319 | `) |
| 2320 | |
| 2321 | buildOS := result.Config.BuildOS.String() |
| 2322 | args := result.ModuleForTests("foo", buildOS+"_common"). |
| 2323 | Output("out/soong/.intermediates/foo/" + buildOS + "_common/foo.config").Args |
| 2324 | expected := proptools.NinjaAndShellEscape("<option name=\"test-timeout\" value=\"10m\" />\\n ") |
| 2325 | if args["extraTestRunnerConfigs"] != expected { |
| 2326 | t.Errorf("Expected args[\"extraTestRunnerConfigs\"] to equal %q, was %q", expected, args["extraTestRunnerConfigs"]) |
| 2327 | } |
| 2328 | } |
Jihoon Kang | 381c2fa | 2023-06-01 22:17:32 +0000 | [diff] [blame] | 2329 | |
| 2330 | func TestJavaExcludeStaticLib(t *testing.T) { |
| 2331 | ctx, _ := testJava(t, ` |
| 2332 | java_library { |
| 2333 | name: "bar", |
| 2334 | } |
| 2335 | java_library { |
| 2336 | name: "foo", |
| 2337 | } |
| 2338 | java_library { |
| 2339 | name: "baz", |
| 2340 | static_libs: [ |
| 2341 | "foo", |
| 2342 | "bar", |
| 2343 | ], |
| 2344 | exclude_static_libs: [ |
| 2345 | "bar", |
| 2346 | ], |
| 2347 | } |
| 2348 | `) |
| 2349 | |
| 2350 | // "bar" not included as dependency of "baz" |
| 2351 | CheckModuleDependencies(t, ctx, "baz", "android_common", []string{ |
| 2352 | `core-lambda-stubs`, |
| 2353 | `ext`, |
| 2354 | `foo`, |
| 2355 | `framework`, |
| 2356 | `stable-core-platform-api-stubs-system-modules`, |
| 2357 | `stable.core.platform.api.stubs`, |
| 2358 | }) |
| 2359 | } |
Jihoon Kang | 1bfb6f2 | 2023-07-01 00:13:47 +0000 | [diff] [blame] | 2360 | |
| 2361 | func TestJavaLibraryWithResourcesStem(t *testing.T) { |
| 2362 | ctx, _ := testJavaWithFS(t, ` |
| 2363 | java_library { |
| 2364 | name: "foo", |
| 2365 | java_resource_dirs: ["test-jar"], |
| 2366 | stem: "test", |
| 2367 | } |
| 2368 | `, |
| 2369 | map[string][]byte{ |
| 2370 | "test-jar/test/resource.txt": nil, |
| 2371 | }) |
| 2372 | |
| 2373 | m := ctx.ModuleForTests("foo", "android_common") |
| 2374 | outputs := fmt.Sprint(m.AllOutputs()) |
| 2375 | if !strings.Contains(outputs, "test.jar") { |
| 2376 | t.Errorf("Module output does not contain expected jar %s", "test.jar") |
| 2377 | } |
| 2378 | } |
Mark White | a15790a | 2023-08-22 21:28:11 +0000 | [diff] [blame] | 2379 | |
| 2380 | func TestHeadersOnly(t *testing.T) { |
| 2381 | ctx, _ := testJava(t, ` |
| 2382 | java_library { |
| 2383 | name: "foo", |
| 2384 | srcs: ["a.java"], |
| 2385 | headers_only: true, |
| 2386 | } |
| 2387 | `) |
| 2388 | |
| 2389 | turbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine") |
| 2390 | if len(turbine.Inputs) != 1 || turbine.Inputs[0].String() != "a.java" { |
| 2391 | t.Errorf(`foo inputs %v != ["a.java"]`, turbine.Inputs) |
| 2392 | } |
| 2393 | |
| 2394 | javac := ctx.ModuleForTests("foo", "android_common").MaybeRule("javac") |
| 2395 | android.AssertDeepEquals(t, "javac rule", nil, javac.Rule) |
| 2396 | } |
Jihoon Kang | fdf3236 | 2023-09-12 00:36:43 +0000 | [diff] [blame] | 2397 | |
| 2398 | func TestJavaApiContributionImport(t *testing.T) { |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2399 | ctx := android.GroupFixturePreparers( |
| 2400 | prepareForJavaTest, |
| 2401 | android.FixtureMergeEnv( |
| 2402 | map[string]string{ |
| 2403 | "DISABLE_STUB_VALIDATION": "true", |
| 2404 | }, |
| 2405 | ), |
| 2406 | ).RunTestWithBp(t, ` |
Jihoon Kang | fdf3236 | 2023-09-12 00:36:43 +0000 | [diff] [blame] | 2407 | java_api_library { |
| 2408 | name: "foo", |
| 2409 | api_contributions: ["bar"], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2410 | stubs_type: "everything", |
Jihoon Kang | fdf3236 | 2023-09-12 00:36:43 +0000 | [diff] [blame] | 2411 | } |
| 2412 | java_api_contribution_import { |
| 2413 | name: "bar", |
| 2414 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2415 | api_surface: "public", |
Jihoon Kang | fdf3236 | 2023-09-12 00:36:43 +0000 | [diff] [blame] | 2416 | } |
| 2417 | `) |
| 2418 | m := ctx.ModuleForTests("foo", "android_common") |
| 2419 | manifest := m.Output("metalava.sbox.textproto") |
Colin Cross | f61d03d | 2023-11-02 16:56:39 -0700 | [diff] [blame] | 2420 | sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx.TestContext, manifest) |
Jihoon Kang | fdf3236 | 2023-09-12 00:36:43 +0000 | [diff] [blame] | 2421 | manifestCommand := sboxProto.Commands[0].GetCommand() |
| 2422 | sourceFilesFlag := "--source-files current.txt" |
| 2423 | android.AssertStringDoesContain(t, "source text files not present", manifestCommand, sourceFilesFlag) |
| 2424 | } |
Jihoon Kang | a96a7b1 | 2023-09-20 23:43:32 +0000 | [diff] [blame] | 2425 | |
| 2426 | func TestJavaApiLibraryApiFilesSorting(t *testing.T) { |
| 2427 | ctx, _ := testJava(t, ` |
| 2428 | java_api_library { |
| 2429 | name: "foo", |
| 2430 | api_contributions: [ |
| 2431 | "system-server-api-stubs-docs-non-updatable.api.contribution", |
| 2432 | "test-api-stubs-docs-non-updatable.api.contribution", |
| 2433 | "system-api-stubs-docs-non-updatable.api.contribution", |
| 2434 | "module-lib-api-stubs-docs-non-updatable.api.contribution", |
| 2435 | "api-stubs-docs-non-updatable.api.contribution", |
| 2436 | ], |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2437 | stubs_type: "everything", |
Jihoon Kang | a96a7b1 | 2023-09-20 23:43:32 +0000 | [diff] [blame] | 2438 | } |
| 2439 | `) |
| 2440 | m := ctx.ModuleForTests("foo", "android_common") |
| 2441 | manifest := m.Output("metalava.sbox.textproto") |
Colin Cross | f61d03d | 2023-11-02 16:56:39 -0700 | [diff] [blame] | 2442 | sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx, manifest) |
Jihoon Kang | a96a7b1 | 2023-09-20 23:43:32 +0000 | [diff] [blame] | 2443 | manifestCommand := sboxProto.Commands[0].GetCommand() |
| 2444 | |
| 2445 | // Api files are sorted from the narrowest api scope to the widest api scope. |
| 2446 | // test api and module lib api surface do not have subset/superset relationship, |
| 2447 | // but they will never be passed as inputs at the same time. |
| 2448 | sourceFilesFlag := "--source-files default/java/api/current.txt " + |
| 2449 | "default/java/api/system-current.txt default/java/api/test-current.txt " + |
| 2450 | "default/java/api/module-lib-current.txt default/java/api/system-server-current.txt" |
| 2451 | android.AssertStringDoesContain(t, "source text files not in api scope order", manifestCommand, sourceFilesFlag) |
| 2452 | } |
Jihoon Kang | 4ec2487 | 2023-10-05 17:26:09 +0000 | [diff] [blame] | 2453 | |
| 2454 | func TestSdkLibraryProvidesSystemModulesToApiLibrary(t *testing.T) { |
| 2455 | result := android.GroupFixturePreparers( |
| 2456 | prepareForJavaTest, |
| 2457 | PrepareForTestWithJavaSdkLibraryFiles, |
| 2458 | FixtureWithLastReleaseApis("foo"), |
Jihoon Kang | 4ec2487 | 2023-10-05 17:26:09 +0000 | [diff] [blame] | 2459 | android.FixtureMergeMockFs( |
| 2460 | map[string][]byte{ |
| 2461 | "A.java": nil, |
| 2462 | }, |
| 2463 | ), |
| 2464 | ).RunTestWithBp(t, ` |
| 2465 | java_library { |
| 2466 | name: "bar", |
| 2467 | srcs: ["a.java"], |
| 2468 | } |
| 2469 | java_system_modules { |
| 2470 | name: "baz", |
| 2471 | libs: ["bar"], |
| 2472 | } |
| 2473 | java_sdk_library { |
| 2474 | name: "foo", |
| 2475 | srcs: ["A.java"], |
| 2476 | system_modules: "baz", |
| 2477 | } |
| 2478 | `) |
Jihoon Kang | b0f4c02 | 2024-08-06 00:15:25 +0000 | [diff] [blame^] | 2479 | |
| 2480 | checkBootClasspathForLibWithSystemModule(t, result.TestContext, apiScopePublic.apiLibraryModuleName("foo"), "/bar.jar") |
Jihoon Kang | 4ec2487 | 2023-10-05 17:26:09 +0000 | [diff] [blame] | 2481 | } |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2482 | |
| 2483 | func TestApiLibraryDroidstubsDependency(t *testing.T) { |
| 2484 | result := android.GroupFixturePreparers( |
| 2485 | prepareForJavaTest, |
| 2486 | PrepareForTestWithJavaSdkLibraryFiles, |
| 2487 | FixtureWithLastReleaseApis("foo"), |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2488 | android.FixtureMergeMockFs( |
| 2489 | map[string][]byte{ |
| 2490 | "A.java": nil, |
| 2491 | }, |
| 2492 | ), |
| 2493 | ).RunTestWithBp(t, ` |
| 2494 | java_api_library { |
| 2495 | name: "foo", |
| 2496 | api_contributions: [ |
| 2497 | "api-stubs-docs-non-updatable.api.contribution", |
| 2498 | ], |
| 2499 | enable_validation: true, |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2500 | stubs_type: "everything", |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2501 | } |
| 2502 | java_api_library { |
| 2503 | name: "bar", |
| 2504 | api_contributions: [ |
| 2505 | "api-stubs-docs-non-updatable.api.contribution", |
| 2506 | ], |
| 2507 | enable_validation: false, |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2508 | stubs_type: "everything", |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2509 | } |
| 2510 | `) |
| 2511 | |
Jihoon Kang | 3c89f04 | 2023-12-19 02:40:22 +0000 | [diff] [blame] | 2512 | currentApiTimestampPath := "api-stubs-docs-non-updatable/android_common/everything/check_current_api.timestamp" |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2513 | foo := result.ModuleForTests("foo", "android_common").Module().(*ApiLibrary) |
| 2514 | fooValidationPathsString := strings.Join(foo.validationPaths.Strings(), " ") |
| 2515 | bar := result.ModuleForTests("bar", "android_common").Module().(*ApiLibrary) |
| 2516 | barValidationPathsString := strings.Join(bar.validationPaths.Strings(), " ") |
| 2517 | android.AssertStringDoesContain(t, |
| 2518 | "Module expected to have validation", |
| 2519 | fooValidationPathsString, |
| 2520 | currentApiTimestampPath, |
| 2521 | ) |
| 2522 | android.AssertStringDoesNotContain(t, |
| 2523 | "Module expected to not have validation", |
| 2524 | barValidationPathsString, |
| 2525 | currentApiTimestampPath, |
| 2526 | ) |
| 2527 | } |
Jihoon Kang | 1975d3e | 2023-10-16 23:24:11 +0000 | [diff] [blame] | 2528 | |
| 2529 | func TestDisableFromTextStubForCoverageBuild(t *testing.T) { |
| 2530 | result := android.GroupFixturePreparers( |
| 2531 | prepareForJavaTest, |
| 2532 | PrepareForTestWithJavaSdkLibraryFiles, |
| 2533 | PrepareForTestWithJacocoInstrumentation, |
| 2534 | FixtureWithLastReleaseApis("foo"), |
| 2535 | android.FixtureModifyConfig(func(config android.Config) { |
Jihoon Kang | 1975d3e | 2023-10-16 23:24:11 +0000 | [diff] [blame] | 2536 | config.SetBuildFromTextStub(true) |
| 2537 | }), |
| 2538 | android.FixtureModifyEnv(func(env map[string]string) { |
| 2539 | env["EMMA_INSTRUMENT"] = "true" |
| 2540 | }), |
| 2541 | ).RunTestWithBp(t, ` |
| 2542 | java_sdk_library { |
| 2543 | name: "foo", |
| 2544 | srcs: ["A.java"], |
| 2545 | } |
| 2546 | `) |
| 2547 | android.AssertBoolEquals(t, "stub module expected to depend on from-source stub", |
| 2548 | true, CheckModuleHasDependency(t, result.TestContext, |
| 2549 | apiScopePublic.stubsLibraryModuleName("foo"), "android_common", |
| 2550 | apiScopePublic.sourceStubLibraryModuleName("foo"))) |
| 2551 | |
| 2552 | android.AssertBoolEquals(t, "stub module expected to not depend on from-text stub", |
| 2553 | false, CheckModuleHasDependency(t, result.TestContext, |
| 2554 | apiScopePublic.stubsLibraryModuleName("foo"), "android_common", |
| 2555 | apiScopePublic.apiLibraryModuleName("foo"))) |
| 2556 | } |
Spandan Das | 3cf0463 | 2024-01-19 00:22:22 +0000 | [diff] [blame] | 2557 | |
| 2558 | func TestMultiplePrebuilts(t *testing.T) { |
| 2559 | bp := ` |
| 2560 | // an rdep |
| 2561 | java_library { |
| 2562 | name: "foo", |
| 2563 | libs: ["bar"], |
| 2564 | } |
| 2565 | |
| 2566 | // multiple variations of dep |
| 2567 | // source |
| 2568 | java_library { |
| 2569 | name: "bar", |
| 2570 | srcs: ["bar.java"], |
| 2571 | } |
| 2572 | // prebuilt "v1" |
| 2573 | java_import { |
| 2574 | name: "bar", |
| 2575 | jars: ["bar.jar"], |
| 2576 | } |
| 2577 | // prebuilt "v2" |
| 2578 | java_import { |
| 2579 | name: "bar.v2", |
| 2580 | source_module_name: "bar", |
| 2581 | jars: ["bar.v1.jar"], |
| 2582 | } |
| 2583 | |
| 2584 | // selectors |
| 2585 | apex_contributions { |
| 2586 | name: "myapex_contributions", |
| 2587 | contents: ["%v"], |
| 2588 | } |
| 2589 | ` |
| 2590 | hasDep := func(ctx *android.TestResult, m android.Module, wantDep android.Module) bool { |
| 2591 | t.Helper() |
| 2592 | var found bool |
| 2593 | ctx.VisitDirectDeps(m, func(dep blueprint.Module) { |
| 2594 | if dep == wantDep { |
| 2595 | found = true |
| 2596 | } |
| 2597 | }) |
| 2598 | return found |
| 2599 | } |
| 2600 | |
| 2601 | hasFileWithStem := func(m android.TestingModule, stem string) bool { |
| 2602 | t.Helper() |
| 2603 | for _, o := range m.AllOutputs() { |
| 2604 | _, file := filepath.Split(o) |
| 2605 | if file == stem+".jar" { |
| 2606 | return true |
| 2607 | } |
| 2608 | } |
| 2609 | return false |
| 2610 | } |
| 2611 | |
| 2612 | testCases := []struct { |
| 2613 | desc string |
| 2614 | selectedDependencyName string |
| 2615 | expectedDependencyName string |
| 2616 | }{ |
| 2617 | { |
| 2618 | desc: "Source library is selected using apex_contributions", |
| 2619 | selectedDependencyName: "bar", |
| 2620 | expectedDependencyName: "bar", |
| 2621 | }, |
| 2622 | { |
| 2623 | desc: "Prebuilt library v1 is selected using apex_contributions", |
| 2624 | selectedDependencyName: "prebuilt_bar", |
| 2625 | expectedDependencyName: "prebuilt_bar", |
| 2626 | }, |
| 2627 | { |
| 2628 | desc: "Prebuilt library v2 is selected using apex_contributions", |
| 2629 | selectedDependencyName: "prebuilt_bar.v2", |
| 2630 | expectedDependencyName: "prebuilt_bar.v2", |
| 2631 | }, |
| 2632 | } |
| 2633 | |
| 2634 | for _, tc := range testCases { |
| 2635 | ctx := android.GroupFixturePreparers( |
| 2636 | prepareForJavaTest, |
| 2637 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 2638 | variables.BuildFlags = map[string]string{ |
| 2639 | "RELEASE_APEX_CONTRIBUTIONS_ADSERVICES": "myapex_contributions", |
| 2640 | } |
| 2641 | }), |
| 2642 | ).RunTestWithBp(t, fmt.Sprintf(bp, tc.selectedDependencyName)) |
| 2643 | |
| 2644 | // check that rdep gets the correct variation of dep |
| 2645 | foo := ctx.ModuleForTests("foo", "android_common") |
| 2646 | expectedDependency := ctx.ModuleForTests(tc.expectedDependencyName, "android_common") |
| 2647 | android.AssertBoolEquals(t, fmt.Sprintf("expected dependency from %s to %s\n", foo.Module().Name(), tc.expectedDependencyName), true, hasDep(ctx, foo.Module(), expectedDependency.Module())) |
| 2648 | |
| 2649 | // check that output file of dep is always bar.jar |
| 2650 | // The filename should be agnostic to source/prebuilt/prebuilt_version |
| 2651 | android.AssertBoolEquals(t, fmt.Sprintf("could not find bar.jar in outputs of %s. All Outputs %v\n", tc.expectedDependencyName, expectedDependency.AllOutputs()), true, hasFileWithStem(expectedDependency, "bar")) |
| 2652 | |
| 2653 | // check LOCAL_MODULE of the selected module name |
| 2654 | // the prebuilt should have the same LOCAL_MODULE when exported to make |
| 2655 | entries := android.AndroidMkEntriesForTest(t, ctx.TestContext, expectedDependency.Module())[0] |
| 2656 | android.AssertStringEquals(t, "unexpected LOCAL_MODULE", "bar", entries.EntryMap["LOCAL_MODULE"][0]) |
| 2657 | } |
| 2658 | } |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2659 | |
Spandan Das | e4c911e | 2024-01-19 00:22:22 +0000 | [diff] [blame] | 2660 | func TestMultiplePlatformCompatConfigPrebuilts(t *testing.T) { |
| 2661 | bp := ` |
| 2662 | // multiple variations of platform_compat_config |
| 2663 | // source |
| 2664 | platform_compat_config { |
| 2665 | name: "myconfig", |
| 2666 | } |
| 2667 | // prebuilt "v1" |
| 2668 | prebuilt_platform_compat_config { |
| 2669 | name: "myconfig", |
| 2670 | metadata: "myconfig.xml", |
| 2671 | } |
| 2672 | // prebuilt "v2" |
| 2673 | prebuilt_platform_compat_config { |
| 2674 | name: "myconfig.v2", |
| 2675 | source_module_name: "myconfig", // without source_module_name, the singleton will merge two .xml files |
| 2676 | metadata: "myconfig.v2.xml", |
| 2677 | } |
| 2678 | |
| 2679 | // selectors |
| 2680 | apex_contributions { |
| 2681 | name: "myapex_contributions", |
| 2682 | contents: ["%v"], |
| 2683 | } |
| 2684 | ` |
| 2685 | testCases := []struct { |
| 2686 | desc string |
| 2687 | selectedDependencyName string |
| 2688 | expectedPlatformCompatConfigXml string |
| 2689 | }{ |
| 2690 | { |
| 2691 | desc: "Source platform_compat_config is selected using apex_contributions", |
| 2692 | selectedDependencyName: "myconfig", |
| 2693 | expectedPlatformCompatConfigXml: "out/soong/.intermediates/myconfig/android_common/myconfig_meta.xml", |
| 2694 | }, |
| 2695 | { |
| 2696 | desc: "Prebuilt platform_compat_config v1 is selected using apex_contributions", |
| 2697 | selectedDependencyName: "prebuilt_myconfig", |
| 2698 | expectedPlatformCompatConfigXml: "myconfig.xml", |
| 2699 | }, |
| 2700 | { |
| 2701 | desc: "Prebuilt platform_compat_config v2 is selected using apex_contributions", |
| 2702 | selectedDependencyName: "prebuilt_myconfig.v2", |
| 2703 | expectedPlatformCompatConfigXml: "myconfig.v2.xml", |
| 2704 | }, |
| 2705 | } |
| 2706 | |
| 2707 | for _, tc := range testCases { |
| 2708 | ctx := android.GroupFixturePreparers( |
| 2709 | prepareForJavaTest, |
| 2710 | PrepareForTestWithPlatformCompatConfig, |
| 2711 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 2712 | variables.BuildFlags = map[string]string{ |
| 2713 | "RELEASE_APEX_CONTRIBUTIONS_ADSERVICES": "myapex_contributions", |
| 2714 | } |
| 2715 | }), |
| 2716 | ).RunTestWithBp(t, fmt.Sprintf(bp, tc.selectedDependencyName)) |
| 2717 | |
| 2718 | mergedGlobalConfig := ctx.SingletonForTests("platform_compat_config_singleton").Output("compat_config/merged_compat_config.xml") |
| 2719 | android.AssertIntEquals(t, "The merged compat config file should only have a single dependency", 1, len(mergedGlobalConfig.Implicits)) |
| 2720 | android.AssertStringEquals(t, "The merged compat config file is missing the appropriate platform compat config", mergedGlobalConfig.Implicits[0].String(), tc.expectedPlatformCompatConfigXml) |
| 2721 | } |
| 2722 | } |
| 2723 | |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2724 | func TestApiLibraryAconfigDeclarations(t *testing.T) { |
| 2725 | result := android.GroupFixturePreparers( |
| 2726 | prepareForJavaTest, |
| 2727 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 2728 | }), |
| 2729 | android.FixtureMergeMockFs(map[string][]byte{ |
| 2730 | "a/A.java": nil, |
| 2731 | "a/current.txt": nil, |
| 2732 | "a/removed.txt": nil, |
| 2733 | }), |
| 2734 | ).RunTestWithBp(t, ` |
| 2735 | aconfig_declarations { |
| 2736 | name: "bar", |
| 2737 | package: "com.example.package", |
Yu Liu | 315a53c | 2024-04-24 16:41:57 +0000 | [diff] [blame] | 2738 | container: "com.android.foo", |
Jihoon Kang | 5d70127 | 2024-02-15 21:53:49 +0000 | [diff] [blame] | 2739 | srcs: [ |
| 2740 | "bar.aconfig", |
| 2741 | ], |
| 2742 | } |
| 2743 | java_api_contribution { |
| 2744 | name: "baz", |
| 2745 | api_file: "a/current.txt", |
| 2746 | api_surface: "public", |
| 2747 | } |
| 2748 | java_api_library { |
| 2749 | name: "foo", |
| 2750 | api_surface: "public", |
| 2751 | api_contributions: [ |
| 2752 | "baz", |
| 2753 | ], |
| 2754 | aconfig_declarations: [ |
| 2755 | "bar", |
| 2756 | ], |
| 2757 | stubs_type: "exportable", |
| 2758 | enable_validation: false, |
| 2759 | } |
| 2760 | `) |
| 2761 | |
| 2762 | // Check if java_api_library depends on aconfig_declarations |
| 2763 | android.AssertBoolEquals(t, "foo expected to depend on bar", |
| 2764 | CheckModuleHasDependency(t, result.TestContext, "foo", "android_common", "bar"), true) |
| 2765 | |
| 2766 | m := result.ModuleForTests("foo", "android_common") |
| 2767 | android.AssertStringDoesContain(t, "foo generates revert annotations file", |
| 2768 | strings.Join(m.AllOutputs(), ""), "revert-annotations-exportable.txt") |
| 2769 | |
| 2770 | // revert-annotations.txt passed to exportable stubs generation metalava command |
| 2771 | manifest := m.Output("metalava.sbox.textproto") |
| 2772 | cmdline := String(android.RuleBuilderSboxProtoForTests(t, result.TestContext, manifest).Commands[0].Command) |
| 2773 | android.AssertStringDoesContain(t, "flagged api hide command not included", cmdline, "revert-annotations-exportable.txt") |
| 2774 | } |
yangbill | 2af0b6e | 2024-03-15 09:29:29 +0000 | [diff] [blame] | 2775 | |
Ronald Braunstein | cdc66f4 | 2024-04-12 11:23:19 -0700 | [diff] [blame] | 2776 | func TestTestOnly(t *testing.T) { |
| 2777 | t.Parallel() |
| 2778 | ctx := android.GroupFixturePreparers( |
| 2779 | prepareForJavaTest, |
| 2780 | ).RunTestWithBp(t, ` |
| 2781 | // These should be test-only |
| 2782 | java_library { |
| 2783 | name: "lib1-test-only", |
| 2784 | srcs: ["a.java"], |
| 2785 | test_only: true, |
| 2786 | } |
| 2787 | java_test { |
| 2788 | name: "java-test", |
| 2789 | } |
| 2790 | java_test_host { |
| 2791 | name: "java-test-host", |
| 2792 | } |
| 2793 | java_test_helper_library { |
| 2794 | name: "helper-library", |
| 2795 | } |
| 2796 | java_binary { |
| 2797 | name: "java-data-binary", |
| 2798 | srcs: ["foo.java"], |
| 2799 | main_class: "foo.bar.jb", |
| 2800 | test_only: true, |
| 2801 | } |
| 2802 | |
| 2803 | // These are NOT |
| 2804 | java_library { |
| 2805 | name: "lib2-app", |
| 2806 | srcs: ["b.java"], |
| 2807 | } |
| 2808 | java_import { |
| 2809 | name: "bar", |
| 2810 | jars: ["bar.jar"], |
| 2811 | } |
| 2812 | java_binary { |
| 2813 | name: "java-binary", |
| 2814 | srcs: ["foo.java"], |
| 2815 | main_class: "foo.bar.jb", |
| 2816 | } |
| 2817 | `) |
| 2818 | |
| 2819 | expectedTestOnlyModules := []string{ |
| 2820 | "lib1-test-only", |
| 2821 | "java-test", |
| 2822 | "java-test-host", |
| 2823 | "helper-library", |
| 2824 | "java-data-binary", |
| 2825 | } |
| 2826 | expectedTopLevelTests := []string{ |
| 2827 | "java-test", |
| 2828 | "java-test-host", |
| 2829 | } |
| 2830 | assertTestOnlyAndTopLevel(t, ctx, expectedTestOnlyModules, expectedTopLevelTests) |
| 2831 | } |
| 2832 | |
| 2833 | // Don't allow setting test-only on things that are always tests or never tests. |
| 2834 | func TestInvalidTestOnlyTargets(t *testing.T) { |
| 2835 | testCases := []string{ |
| 2836 | ` java_test { name: "java-test", test_only: true, srcs: ["foo.java"], } `, |
| 2837 | ` java_test_host { name: "java-test-host", test_only: true, srcs: ["foo.java"], } `, |
| 2838 | ` java_test_import { name: "java-test-import", test_only: true, } `, |
| 2839 | ` java_api_library { name: "java-api-library", test_only: true, } `, |
| 2840 | ` java_test_helper_library { name: "test-help-lib", test_only: true, } `, |
| 2841 | ` java_defaults { name: "java-defaults", test_only: true, } `, |
| 2842 | } |
| 2843 | |
| 2844 | for i, bp := range testCases { |
| 2845 | android.GroupFixturePreparers(prepareForJavaTest). |
| 2846 | ExtendWithErrorHandler( |
| 2847 | expectOneError("unrecognized property \"test_only\"", |
| 2848 | fmt.Sprintf("testcase: %d", i))). |
| 2849 | RunTestWithBp(t, bp) |
| 2850 | } |
| 2851 | } |
| 2852 | |
| 2853 | // Expect exactly one that matches 'expected'. |
| 2854 | // Append 'msg' to the Errorf that printed. |
| 2855 | func expectOneError(expected string, msg string) android.FixtureErrorHandler { |
| 2856 | return android.FixtureCustomErrorHandler(func(t *testing.T, result *android.TestResult) { |
| 2857 | t.Helper() |
| 2858 | if len(result.Errs) != 1 { |
| 2859 | t.Errorf("Expected exactly one error, but found: %d when setting test_only on: %s", len(result.Errs), msg) |
| 2860 | return |
| 2861 | } |
| 2862 | actualErrMsg := result.Errs[0].Error() |
| 2863 | if !strings.Contains(actualErrMsg, expected) { |
| 2864 | t.Errorf("Different error than expected. Received: [%v] on %s expected: %s", actualErrMsg, msg, expected) |
| 2865 | } |
| 2866 | }) |
| 2867 | } |
| 2868 | |
yangbill | 2af0b6e | 2024-03-15 09:29:29 +0000 | [diff] [blame] | 2869 | func TestJavaLibHostWithStem(t *testing.T) { |
| 2870 | ctx, _ := testJava(t, ` |
| 2871 | java_library_host { |
| 2872 | name: "foo", |
| 2873 | srcs: ["a.java"], |
| 2874 | stem: "foo-new", |
| 2875 | } |
| 2876 | `) |
| 2877 | |
| 2878 | buildOS := ctx.Config().BuildOS.String() |
| 2879 | foo := ctx.ModuleForTests("foo", buildOS+"_common") |
| 2880 | |
| 2881 | outputs := fmt.Sprint(foo.AllOutputs()) |
| 2882 | if !strings.Contains(outputs, "foo-new.jar") { |
| 2883 | t.Errorf("Module output does not contain expected jar %s", "foo-new.jar") |
| 2884 | } |
| 2885 | } |
| 2886 | |
| 2887 | func TestJavaLibWithStem(t *testing.T) { |
| 2888 | ctx, _ := testJava(t, ` |
| 2889 | java_library { |
| 2890 | name: "foo", |
| 2891 | srcs: ["a.java"], |
| 2892 | stem: "foo-new", |
| 2893 | } |
| 2894 | `) |
| 2895 | |
| 2896 | foo := ctx.ModuleForTests("foo", "android_common") |
| 2897 | |
| 2898 | outputs := fmt.Sprint(foo.AllOutputs()) |
| 2899 | if !strings.Contains(outputs, "foo-new.jar") { |
| 2900 | t.Errorf("Module output does not contain expected jar %s", "foo-new.jar") |
| 2901 | } |
| 2902 | } |
Colin Cross | 5e87f34 | 2024-04-11 15:28:18 -0700 | [diff] [blame] | 2903 | |
| 2904 | func TestJavaLibraryOutputFilesRel(t *testing.T) { |
| 2905 | result := android.GroupFixturePreparers( |
| 2906 | PrepareForTestWithJavaDefaultModules, |
| 2907 | ).RunTestWithBp(t, ` |
| 2908 | java_library { |
| 2909 | name: "foo", |
| 2910 | srcs: ["a.java"], |
| 2911 | } |
| 2912 | |
| 2913 | java_import { |
| 2914 | name: "bar", |
| 2915 | jars: ["bar.aar"], |
| 2916 | |
| 2917 | } |
| 2918 | |
| 2919 | java_import { |
| 2920 | name: "baz", |
| 2921 | jars: ["baz.aar"], |
| 2922 | static_libs: ["bar"], |
| 2923 | } |
| 2924 | `) |
| 2925 | |
| 2926 | foo := result.ModuleForTests("foo", "android_common") |
| 2927 | bar := result.ModuleForTests("bar", "android_common") |
| 2928 | baz := result.ModuleForTests("baz", "android_common") |
| 2929 | |
mrziwang | 9f7b9f4 | 2024-07-10 12:18:06 -0700 | [diff] [blame] | 2930 | fooOutputPaths := foo.OutputFiles(t, "") |
mrziwang | 68786d8 | 2024-07-09 10:41:55 -0700 | [diff] [blame] | 2931 | barOutputPaths := bar.OutputFiles(t, "") |
| 2932 | bazOutputPaths := baz.OutputFiles(t, "") |
Colin Cross | 5e87f34 | 2024-04-11 15:28:18 -0700 | [diff] [blame] | 2933 | |
mrziwang | 9f7b9f4 | 2024-07-10 12:18:06 -0700 | [diff] [blame] | 2934 | android.AssertPathsRelativeToTopEquals(t, "foo output path", |
| 2935 | []string{"out/soong/.intermediates/foo/android_common/javac/foo.jar"}, fooOutputPaths) |
mrziwang | 68786d8 | 2024-07-09 10:41:55 -0700 | [diff] [blame] | 2936 | android.AssertPathsRelativeToTopEquals(t, "bar output path", |
| 2937 | []string{"out/soong/.intermediates/bar/android_common/combined/bar.jar"}, barOutputPaths) |
| 2938 | android.AssertPathsRelativeToTopEquals(t, "baz output path", |
| 2939 | []string{"out/soong/.intermediates/baz/android_common/combined/baz.jar"}, bazOutputPaths) |
Colin Cross | 5e87f34 | 2024-04-11 15:28:18 -0700 | [diff] [blame] | 2940 | |
| 2941 | android.AssertStringEquals(t, "foo relative output path", |
mrziwang | 9f7b9f4 | 2024-07-10 12:18:06 -0700 | [diff] [blame] | 2942 | "foo.jar", fooOutputPaths[0].Rel()) |
Colin Cross | 5e87f34 | 2024-04-11 15:28:18 -0700 | [diff] [blame] | 2943 | android.AssertStringEquals(t, "bar relative output path", |
mrziwang | 68786d8 | 2024-07-09 10:41:55 -0700 | [diff] [blame] | 2944 | "bar.jar", barOutputPaths[0].Rel()) |
Colin Cross | 5e87f34 | 2024-04-11 15:28:18 -0700 | [diff] [blame] | 2945 | android.AssertStringEquals(t, "baz relative output path", |
mrziwang | 68786d8 | 2024-07-09 10:41:55 -0700 | [diff] [blame] | 2946 | "baz.jar", bazOutputPaths[0].Rel()) |
Colin Cross | 5e87f34 | 2024-04-11 15:28:18 -0700 | [diff] [blame] | 2947 | } |
Ronald Braunstein | cdc66f4 | 2024-04-12 11:23:19 -0700 | [diff] [blame] | 2948 | |
| 2949 | func assertTestOnlyAndTopLevel(t *testing.T, ctx *android.TestResult, expectedTestOnly []string, expectedTopLevel []string) { |
| 2950 | t.Helper() |
| 2951 | actualTrueModules := []string{} |
| 2952 | actualTopLevelTests := []string{} |
| 2953 | addActuals := func(m blueprint.Module, key blueprint.ProviderKey[android.TestModuleInformation]) { |
| 2954 | if provider, ok := android.OtherModuleProvider(ctx.TestContext.OtherModuleProviderAdaptor(), m, key); ok { |
| 2955 | if provider.TestOnly { |
| 2956 | actualTrueModules = append(actualTrueModules, m.Name()) |
| 2957 | } |
| 2958 | if provider.TopLevelTarget { |
| 2959 | actualTopLevelTests = append(actualTopLevelTests, m.Name()) |
| 2960 | } |
| 2961 | } |
| 2962 | } |
| 2963 | |
| 2964 | ctx.VisitAllModules(func(m blueprint.Module) { |
| 2965 | addActuals(m, android.TestOnlyProviderKey) |
| 2966 | |
| 2967 | }) |
| 2968 | |
| 2969 | notEqual, left, right := android.ListSetDifference(expectedTestOnly, actualTrueModules) |
| 2970 | if notEqual { |
| 2971 | t.Errorf("test-only: Expected but not found: %v, Found but not expected: %v", left, right) |
| 2972 | } |
| 2973 | |
| 2974 | notEqual, left, right = android.ListSetDifference(expectedTopLevel, actualTopLevelTests) |
| 2975 | if notEqual { |
| 2976 | t.Errorf("top-level: Expected but not found: %v, Found but not expected: %v", left, right) |
| 2977 | } |
| 2978 | } |