blob: 636a0c8917f2a0fd86c09f0f042232a52c716067 [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Paul Duffin1a393322020-11-18 16:36:47 +000018 "fmt"
Colin Cross72bb3632017-07-13 16:23:21 -070019 "os"
20 "path/filepath"
Colin Crossc0806172019-06-14 18:51:47 -070021 "reflect"
Colin Crossf8d9c492021-01-26 11:01:43 -080022 "runtime"
Colin Crossc9b4f6b2024-07-26 15:25:46 -070023 "slices"
Nan Zhang61eaedb2017-11-02 13:28:15 -070024 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070025 "strings"
26 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070027
Spandan Das3cf04632024-01-19 00:22:22 +000028 "github.com/google/blueprint"
Jeongik Cha28df2572019-11-11 10:46:36 +090029 "github.com/google/blueprint/proptools"
30
Jihoon Kang84b25892023-12-01 22:01:06 +000031 "android/soong/aconfig"
Colin Crossa4f08812018-10-02 22:03:40 -070032 "android/soong/android"
33 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080034 "android/soong/dexpreopt"
Colin Cross1661aff2021-03-12 17:56:51 -080035 "android/soong/genrule"
Colin Cross72bb3632017-07-13 16:23:21 -070036)
37
Paul Duffin70d3bee2021-03-21 11:26:05 +000038// Legacy preparer used for running tests within the java package.
39//
40// This includes everything that was needed to run any test in the java package prior to the
41// introduction of the test fixtures. Tests that are being converted to use fixtures directly
42// rather than through the testJava...() methods should avoid using this and instead use the
43// various preparers directly, using android.GroupFixturePreparers(...) to group them when
44// necessary.
45//
46// deprecated
47var prepareForJavaTest = android.GroupFixturePreparers(
Paul Duffin95bdab42021-03-08 21:48:46 +000048 genrule.PrepareForTestWithGenRuleBuildComponents,
49 // Get the CC build components but not default modules.
50 cc.PrepareForTestWithCcBuildComponents,
51 // Include all the default java modules.
Jiakai Zhangb95998b2023-05-11 16:39:27 +010052 PrepareForTestWithDexpreopt,
Jihoon Kang84b25892023-12-01 22:01:06 +000053 // Include aconfig modules.
54 aconfig.PrepareForTestWithAconfigBuildComponents,
Paul Duffin95bdab42021-03-08 21:48:46 +000055)
56
Colin Cross72bb3632017-07-13 16:23:21 -070057func TestMain(m *testing.M) {
Paul Duffind6339af2021-03-22 18:05:04 +000058 os.Exit(m.Run())
Colin Cross527012a2017-11-30 22:56:16 -080059}
60
Paul Duffin95bdab42021-03-08 21:48:46 +000061// testJavaError is a legacy way of running tests of java modules that expect errors.
62//
63// See testJava for an explanation as to how to stop using this deprecated method.
64//
65// deprecated
Jeongik Cha2cc570d2019-10-29 15:44:45 +090066func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) {
Jeongik Cha538c0d02019-07-11 15:54:27 +090067 t.Helper()
Paul Duffin71ae5942021-03-22 15:36:52 +000068 result := android.GroupFixturePreparers(
Paul Duffin9fc9f532021-03-23 15:41:11 +000069 prepareForJavaTest, dexpreopt.PrepareForTestByEnablingDexpreopt).
Paul Duffin6bac49c2021-03-12 21:28:15 +000070 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)).
71 RunTestWithBp(t, bp)
72 return result.TestContext, result.Config
Jeongik Cha2cc570d2019-10-29 15:44:45 +090073}
74
Paul Duffin71ae5942021-03-22 15:36:52 +000075// testJavaWithFS runs tests using the prepareForJavaTest
Paul Duffin95bdab42021-03-08 21:48:46 +000076//
77// See testJava for an explanation as to how to stop using this deprecated method.
78//
79// deprecated
80func testJavaWithFS(t *testing.T, bp string, fs android.MockFS) (*android.TestContext, android.Config) {
Colin Cross238c1f32020-06-07 16:58:18 -070081 t.Helper()
Paul Duffin71ae5942021-03-22 15:36:52 +000082 result := android.GroupFixturePreparers(
83 prepareForJavaTest, fs.AddToFixture()).RunTestWithBp(t, bp)
Paul Duffin95bdab42021-03-08 21:48:46 +000084 return result.TestContext, result.Config
Colin Cross238c1f32020-06-07 16:58:18 -070085}
86
Paul Duffin71ae5942021-03-22 15:36:52 +000087// testJava runs tests using the prepareForJavaTest
Paul Duffin95bdab42021-03-08 21:48:46 +000088//
Paul Duffin71ae5942021-03-22 15:36:52 +000089// Do not add any new usages of this, instead use the prepareForJavaTest directly as it makes it
Paul Duffin95bdab42021-03-08 21:48:46 +000090// much easier to customize the test behavior.
91//
92// If it is necessary to customize the behavior of an existing test that uses this then please first
Paul Duffin71ae5942021-03-22 15:36:52 +000093// convert the test to using prepareForJavaTest first and then in a following change add the
Paul Duffin95bdab42021-03-08 21:48:46 +000094// appropriate fixture preparers. Keeping the conversion change separate makes it easy to verify
95// that it did not change the test behavior unexpectedly.
96//
97// deprecated
Jaewoong Jungf9a04432019-07-17 11:15:09 -070098func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -080099 t.Helper()
Paul Duffin71ae5942021-03-22 15:36:52 +0000100 result := prepareForJavaTest.RunTestWithBp(t, bp)
Paul Duffin95bdab42021-03-08 21:48:46 +0000101 return result.TestContext, result.Config
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900102}
103
Paul Duffin95bdab42021-03-08 21:48:46 +0000104// defaultModuleToPath constructs a path to the turbine generate jar for a default test module that
105// is defined in PrepareForIntegrationTestWithJava
106func defaultModuleToPath(name string) string {
Paul Duffin76101fa2021-03-13 09:55:25 +0000107 switch {
108 case name == `""`:
109 return name
110 case strings.HasSuffix(name, ".jar"):
111 return name
112 default:
Colin Cross8ff4af32025-02-19 15:17:02 -0800113 return filepath.Join("out", "soong", ".intermediates", defaultJavaDir, name, "android_common", "turbine", name+".jar")
Paul Duffin76101fa2021-03-13 09:55:25 +0000114 }
Paul Duffin95bdab42021-03-08 21:48:46 +0000115}
116
Paul Duffin76e5c8a2021-03-20 14:19:46 +0000117// Test that the PrepareForTestWithJavaDefaultModules provides all the files that it uses by
118// running it in a fixture that requires all source files to exist.
119func TestPrepareForTestWithJavaDefaultModules(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -0800120 t.Parallel()
Paul Duffin76e5c8a2021-03-20 14:19:46 +0000121 android.GroupFixturePreparers(
122 PrepareForTestWithJavaDefaultModules,
123 android.PrepareForTestDisallowNonExistentPaths,
124 ).RunTest(t)
125}
126
Jeongik Chae403e9e2019-12-07 00:16:24 +0900127func TestJavaLinkType(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -0800128 t.Parallel()
Jeongik Chae403e9e2019-12-07 00:16:24 +0900129 testJava(t, `
130 java_library {
131 name: "foo",
132 srcs: ["a.java"],
133 libs: ["bar"],
134 static_libs: ["baz"],
135 }
136
137 java_library {
138 name: "bar",
139 sdk_version: "current",
140 srcs: ["b.java"],
141 }
142
143 java_library {
144 name: "baz",
145 sdk_version: "system_current",
146 srcs: ["c.java"],
147 }
148 `)
149
Steven Moreland00298982020-11-17 21:44:36 +0000150 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900151 java_library {
152 name: "foo",
153 srcs: ["a.java"],
154 libs: ["bar"],
155 sdk_version: "current",
156 static_libs: ["baz"],
157 }
158
159 java_library {
160 name: "bar",
161 sdk_version: "current",
162 srcs: ["b.java"],
163 }
164
165 java_library {
166 name: "baz",
167 sdk_version: "system_current",
168 srcs: ["c.java"],
169 }
170 `)
171
172 testJava(t, `
173 java_library {
174 name: "foo",
175 srcs: ["a.java"],
176 libs: ["bar"],
177 sdk_version: "system_current",
178 static_libs: ["baz"],
179 }
180
181 java_library {
182 name: "bar",
183 sdk_version: "current",
184 srcs: ["b.java"],
185 }
186
187 java_library {
188 name: "baz",
189 sdk_version: "system_current",
190 srcs: ["c.java"],
191 }
192 `)
193
Steven Moreland00298982020-11-17 21:44:36 +0000194 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900195 java_library {
196 name: "foo",
197 srcs: ["a.java"],
198 libs: ["bar"],
199 sdk_version: "system_current",
200 static_libs: ["baz"],
201 }
202
203 java_library {
204 name: "bar",
205 sdk_version: "current",
206 srcs: ["b.java"],
207 }
208
209 java_library {
210 name: "baz",
211 srcs: ["c.java"],
212 }
213 `)
214}
215
Colin Cross72bb3632017-07-13 16:23:21 -0700216func TestSimple(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -0800217 t.Parallel()
Colin Crossc9b4f6b2024-07-26 15:25:46 -0700218 bp := `
Colin Cross72bb3632017-07-13 16:23:21 -0700219 java_library {
220 name: "foo",
221 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700222 libs: ["bar"],
223 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700224 }
225
226 java_library {
227 name: "bar",
228 srcs: ["b.java"],
Colin Crossc9b4f6b2024-07-26 15:25:46 -0700229 static_libs: ["quz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700230 }
231
232 java_library {
233 name: "baz",
234 srcs: ["c.java"],
Colin Crossc9b4f6b2024-07-26 15:25:46 -0700235 static_libs: ["quz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700236 }
Colin Cross72bb3632017-07-13 16:23:21 -0700237
Colin Crossc9b4f6b2024-07-26 15:25:46 -0700238 java_library {
239 name: "quz",
240 srcs: ["d.java"],
241 }`
Colin Cross72bb3632017-07-13 16:23:21 -0700242
Colin Crossc9b4f6b2024-07-26 15:25:46 -0700243 frameworkTurbineJars := []string{
244 "out/soong/.intermediates/default/java/ext/android_common/turbine/ext.jar",
245 "out/soong/.intermediates/default/java/framework/android_common/turbine/framework.jar",
246 }
Colin Cross0a6e0072017-08-30 14:24:55 -0700247
Colin Crossc9b4f6b2024-07-26 15:25:46 -0700248 testCases := []struct {
249 name string
Colin Cross72bb3632017-07-13 16:23:21 -0700250
Colin Crossc9b4f6b2024-07-26 15:25:46 -0700251 preparer android.FixturePreparer
Colin Cross0a6e0072017-08-30 14:24:55 -0700252
Colin Crossc9b4f6b2024-07-26 15:25:46 -0700253 fooJavacInputs []string
254 fooJavacClasspath []string
255 fooCombinedInputs []string
256 fooHeaderCombinedInputs []string
257
258 barJavacInputs []string
259 barJavacClasspath []string
260 barCombinedInputs []string
261 barHeaderCombinedInputs []string
262 }{
263 {
264 name: "normal",
265 preparer: android.NullFixturePreparer,
266 fooJavacInputs: []string{"a.java"},
267 fooJavacClasspath: slices.Concat(
Colin Crossc9b4f6b2024-07-26 15:25:46 -0700268 frameworkTurbineJars,
269 []string{
270 "out/soong/.intermediates/bar/android_common/turbine/bar.jar",
271 "out/soong/.intermediates/quz/android_common/turbine/quz.jar",
272 "out/soong/.intermediates/baz/android_common/turbine/baz.jar",
273 },
274 ),
275 fooCombinedInputs: []string{
276 "out/soong/.intermediates/foo/android_common/javac/foo.jar",
277 "out/soong/.intermediates/baz/android_common/javac/baz.jar",
278 "out/soong/.intermediates/quz/android_common/javac/quz.jar",
279 },
280
281 fooHeaderCombinedInputs: []string{
282 "out/soong/.intermediates/foo/android_common/turbine/foo.jar",
283 "out/soong/.intermediates/baz/android_common/turbine/baz.jar",
284 "out/soong/.intermediates/quz/android_common/turbine/quz.jar",
285 },
286
287 barJavacInputs: []string{"b.java"},
288 barJavacClasspath: slices.Concat(
289 frameworkTurbineJars,
290 []string{"out/soong/.intermediates/quz/android_common/turbine/quz.jar"},
291 ),
292 barCombinedInputs: []string{
293 "out/soong/.intermediates/bar/android_common/javac/bar.jar",
294 "out/soong/.intermediates/quz/android_common/javac/quz.jar",
295 },
296 barHeaderCombinedInputs: []string{
297 "out/soong/.intermediates/bar/android_common/turbine/bar.jar",
298 "out/soong/.intermediates/quz/android_common/turbine/quz.jar",
299 },
300 },
301 }
302
303 for _, tt := range testCases {
304 t.Run(tt.name, func(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -0800305 t.Parallel()
Colin Crossc9b4f6b2024-07-26 15:25:46 -0700306 result := android.GroupFixturePreparers(
307 PrepareForTestWithJavaDefaultModules,
308 tt.preparer,
309 ).RunTestWithBp(t, bp)
Colin Cross90607e92025-02-11 14:58:07 -0800310 foo := result.ModuleForTests(t, "foo", "android_common")
Colin Crossc9b4f6b2024-07-26 15:25:46 -0700311
312 fooJavac := foo.Rule("javac")
313 android.AssertPathsRelativeToTopEquals(t, "foo javac inputs", tt.fooJavacInputs, fooJavac.Inputs)
314
315 fooJavacClasspath := fooJavac.Args["classpath"]
316 android.AssertStringPathsRelativeToTopEquals(t, "foo javac classpath", result.Config, tt.fooJavacClasspath,
317 strings.Split(strings.TrimPrefix(fooJavacClasspath, "-classpath "), ":"))
318
319 fooCombinedJar := foo.Output("combined/foo.jar")
320 android.AssertPathsRelativeToTopEquals(t, "foo combined inputs", tt.fooCombinedInputs, fooCombinedJar.Inputs)
321
322 fooCombinedHeaderJar := foo.Output("turbine-combined/foo.jar")
323 android.AssertPathsRelativeToTopEquals(t, "foo header combined inputs", tt.fooHeaderCombinedInputs, fooCombinedHeaderJar.Inputs)
324
Colin Cross90607e92025-02-11 14:58:07 -0800325 bar := result.ModuleForTests(t, "bar", "android_common")
Colin Crossc9b4f6b2024-07-26 15:25:46 -0700326 barJavac := bar.Rule("javac")
327 android.AssertPathsRelativeToTopEquals(t, "bar javac inputs", tt.barJavacInputs, barJavac.Inputs)
328
329 barJavacClasspath := barJavac.Args["classpath"]
330 android.AssertStringPathsRelativeToTopEquals(t, "bar javac classpath", result.Config, tt.barJavacClasspath,
331 strings.Split(strings.TrimPrefix(barJavacClasspath, "-classpath "), ":"))
332
333 barCombinedJar := bar.Output("combined/bar.jar")
334 android.AssertPathsRelativeToTopEquals(t, "bar combined inputs", tt.barCombinedInputs, barCombinedJar.Inputs)
335
336 barCombinedHeaderJar := bar.Output("turbine-combined/bar.jar")
337 android.AssertPathsRelativeToTopEquals(t, "bar header combined inputs", tt.barHeaderCombinedInputs, barCombinedHeaderJar.Inputs)
338 })
Colin Cross72bb3632017-07-13 16:23:21 -0700339 }
340}
341
Artur Satayev9cf46692019-11-26 18:08:34 +0000342func TestExportedPlugins(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -0800343 t.Parallel()
Artur Satayev9cf46692019-11-26 18:08:34 +0000344 type Result struct {
Colin Crossc9fe10f2020-11-19 18:06:03 -0800345 library string
346 processors string
347 disableTurbine bool
Artur Satayev9cf46692019-11-26 18:08:34 +0000348 }
349 var tests = []struct {
350 name string
351 extra string
352 results []Result
353 }{
354 {
355 name: "Exported plugin is not a direct plugin",
356 extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`,
357 results: []Result{{library: "exports", processors: "-proc:none"}},
358 },
359 {
360 name: "Exports plugin to dependee",
361 extra: `
362 java_library{name: "exports", exported_plugins: ["plugin"]}
363 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
364 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
365 `,
366 results: []Result{
367 {library: "foo", processors: "-processor com.android.TestPlugin"},
368 {library: "bar", processors: "-processor com.android.TestPlugin"},
369 },
370 },
371 {
372 name: "Exports plugin to android_library",
373 extra: `
374 java_library{name: "exports", exported_plugins: ["plugin"]}
375 android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
376 android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
377 `,
378 results: []Result{
379 {library: "foo", processors: "-processor com.android.TestPlugin"},
380 {library: "bar", processors: "-processor com.android.TestPlugin"},
381 },
382 },
383 {
384 name: "Exports plugin is not propagated via transitive deps",
385 extra: `
386 java_library{name: "exports", exported_plugins: ["plugin"]}
387 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
388 java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]}
389 `,
390 results: []Result{
391 {library: "foo", processors: "-processor com.android.TestPlugin"},
392 {library: "bar", processors: "-proc:none"},
393 },
394 },
395 {
396 name: "Exports plugin appends to plugins",
397 extra: `
398 java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"}
399 java_library{name: "exports", exported_plugins: ["plugin"]}
400 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]}
401 `,
402 results: []Result{
403 {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"},
404 },
405 },
Colin Crossc9fe10f2020-11-19 18:06:03 -0800406 {
407 name: "Exports plugin to with generates_api to dependee",
408 extra: `
409 java_library{name: "exports", exported_plugins: ["plugin_generates_api"]}
410 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
411 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
412 `,
413 results: []Result{
414 {library: "foo", processors: "-processor com.android.TestPlugin", disableTurbine: true},
415 {library: "bar", processors: "-processor com.android.TestPlugin", disableTurbine: true},
416 },
417 },
Artur Satayev9cf46692019-11-26 18:08:34 +0000418 }
419
420 for _, test := range tests {
421 t.Run(test.name, func(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -0800422 t.Parallel()
Artur Satayev9cf46692019-11-26 18:08:34 +0000423 ctx, _ := testJava(t, `
424 java_plugin {
425 name: "plugin",
426 processor_class: "com.android.TestPlugin",
427 }
Colin Crossc9fe10f2020-11-19 18:06:03 -0800428 java_plugin {
429 name: "plugin_generates_api",
430 generates_api: true,
431 processor_class: "com.android.TestPlugin",
432 }
Artur Satayev9cf46692019-11-26 18:08:34 +0000433 `+test.extra)
434
435 for _, want := range test.results {
Colin Cross90607e92025-02-11 14:58:07 -0800436 javac := ctx.ModuleForTests(t, want.library, "android_common").Rule("javac")
Artur Satayev9cf46692019-11-26 18:08:34 +0000437 if javac.Args["processor"] != want.processors {
438 t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"])
439 }
Colin Cross90607e92025-02-11 14:58:07 -0800440 turbine := ctx.ModuleForTests(t, want.library, "android_common").MaybeRule("turbine")
Colin Crossc9fe10f2020-11-19 18:06:03 -0800441 disableTurbine := turbine.BuildParams.Rule == nil
442 if disableTurbine != want.disableTurbine {
443 t.Errorf("For library %v, expected disableTurbine %v, found %v", want.library, want.disableTurbine, disableTurbine)
444 }
Artur Satayev9cf46692019-11-26 18:08:34 +0000445 }
446 })
447 }
448}
449
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900450func TestSdkVersionByPartition(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -0800451 t.Parallel()
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900452 testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900453 java_library {
454 name: "foo",
455 srcs: ["a.java"],
456 vendor: true,
457 }
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900458 `)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900459
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900460 testJava(t, `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900461 java_library {
462 name: "bar",
463 srcs: ["b.java"],
464 }
465 `)
466
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900467 for _, enforce := range []bool{true, false} {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900468 bp := `
469 java_library {
470 name: "foo",
471 srcs: ["a.java"],
472 product_specific: true,
473 }
474 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800475
Paul Duffin414ea5e2021-03-22 17:31:52 +0000476 errorHandler := android.FixtureExpectsNoErrors
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900477 if enforce {
Paul Duffin414ea5e2021-03-22 17:31:52 +0000478 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern("sdk_version must have a value when the module is located at vendor or product")
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900479 }
Paul Duffin414ea5e2021-03-22 17:31:52 +0000480
481 android.GroupFixturePreparers(
482 PrepareForTestWithJavaDefaultModules,
483 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
484 variables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
485 }),
486 ).
487 ExtendWithErrorHandler(errorHandler).
488 RunTestWithBp(t, bp)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900489 }
490}
491
Colin Crossd5934c82017-10-02 13:55:26 -0700492func TestArchSpecific(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -0800493 t.Parallel()
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700494 ctx, _ := testJava(t, `
Colin Crossd5934c82017-10-02 13:55:26 -0700495 java_library {
496 name: "foo",
497 srcs: ["a.java"],
498 target: {
499 android: {
500 srcs: ["b.java"],
501 },
502 },
503 }
504 `)
505
Colin Cross90607e92025-02-11 14:58:07 -0800506 javac := ctx.ModuleForTests(t, "foo", "android_common").Rule("javac")
Colin Crossd5934c82017-10-02 13:55:26 -0700507 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
508 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
509 }
510}
511
Colin Cross6b4a32d2017-12-05 13:42:45 -0800512func TestBinary(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -0800513 t.Parallel()
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700514 ctx, _ := testJava(t, `
Colin Cross6b4a32d2017-12-05 13:42:45 -0800515 java_library_host {
516 name: "foo",
517 srcs: ["a.java"],
518 }
519
520 java_binary_host {
521 name: "bar",
522 srcs: ["b.java"],
523 static_libs: ["foo"],
Colin Cross89226d92020-10-09 19:00:54 -0700524 jni_libs: ["libjni"],
525 }
526
527 cc_library_shared {
528 name: "libjni",
529 host_supported: true,
530 device_supported: false,
531 stl: "none",
Colin Cross6b4a32d2017-12-05 13:42:45 -0800532 }
533 `)
534
Colin Cross0c66bc62021-07-20 09:47:41 -0700535 buildOS := ctx.Config().BuildOS.String()
Colin Cross6b4a32d2017-12-05 13:42:45 -0800536
Colin Cross90607e92025-02-11 14:58:07 -0800537 bar := ctx.ModuleForTests(t, "bar", buildOS+"_common")
Colin Cross6b4a32d2017-12-05 13:42:45 -0800538 barJar := bar.Output("bar.jar").Output.String()
Cole Faustb9c67e22024-10-08 16:39:56 -0700539 barWrapperDeps := bar.Output("bar").Implicits.Strings()
Colin Cross6b4a32d2017-12-05 13:42:45 -0800540
Colin Cross90607e92025-02-11 14:58:07 -0800541 libjni := ctx.ModuleForTests(t, "libjni", buildOS+"_x86_64_shared")
Colin Cross89226d92020-10-09 19:00:54 -0700542 libjniSO := libjni.Rule("Cp").Output.String()
543
Colin Cross6b4a32d2017-12-05 13:42:45 -0800544 // Test that the install binary wrapper depends on the installed jar file
Colin Crossc179ea62020-10-09 10:54:15 -0700545 if g, w := barWrapperDeps, barJar; !android.InList(w, g) {
546 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800547 }
Colin Cross89226d92020-10-09 19:00:54 -0700548
549 // Test that the install binary wrapper depends on the installed JNI libraries
550 if g, w := barWrapperDeps, libjniSO; !android.InList(w, g) {
551 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800552 }
Alex Humesky2070e322020-06-09 20:23:08 -0400553}
Colin Cross6b4a32d2017-12-05 13:42:45 -0800554
Colin Crossf8d9c492021-01-26 11:01:43 -0800555func TestTest(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -0800556 t.Parallel()
Colin Crossf8d9c492021-01-26 11:01:43 -0800557 ctx, _ := testJava(t, `
558 java_test_host {
559 name: "foo",
560 srcs: ["a.java"],
561 jni_libs: ["libjni"],
562 }
563
564 cc_library_shared {
565 name: "libjni",
566 host_supported: true,
567 device_supported: false,
568 stl: "none",
569 }
570 `)
571
Colin Cross0c66bc62021-07-20 09:47:41 -0700572 buildOS := ctx.Config().BuildOS.String()
Colin Crossf8d9c492021-01-26 11:01:43 -0800573
Colin Cross90607e92025-02-11 14:58:07 -0800574 foo := ctx.ModuleForTests(t, "foo", buildOS+"_common").Module().(*TestHost)
Colin Crossf8d9c492021-01-26 11:01:43 -0800575
576 expected := "lib64/libjni.so"
577 if runtime.GOOS == "darwin" {
578 expected = "lib64/libjni.dylib"
579 }
580
581 fooTestData := foo.data
582 if len(fooTestData) != 1 || fooTestData[0].Rel() != expected {
583 t.Errorf(`expected foo test data relative path [%q], got %q`,
584 expected, fooTestData.Strings())
585 }
586}
587
Alex Humesky2070e322020-06-09 20:23:08 -0400588func TestHostBinaryNoJavaDebugInfoOverride(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -0800589 t.Parallel()
Alex Humesky2070e322020-06-09 20:23:08 -0400590 bp := `
591 java_library {
592 name: "target_library",
593 srcs: ["a.java"],
594 }
595
596 java_binary_host {
597 name: "host_binary",
598 srcs: ["b.java"],
599 }
600 `
Alex Humesky2070e322020-06-09 20:23:08 -0400601
Paul Duffin414ea5e2021-03-22 17:31:52 +0000602 result := android.GroupFixturePreparers(
603 PrepareForTestWithJavaDefaultModules,
604 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
605 variables.MinimizeJavaDebugInfo = proptools.BoolPtr(true)
606 }),
607 ).RunTestWithBp(t, bp)
Alex Humesky2070e322020-06-09 20:23:08 -0400608
Liz Kammer7941b302020-07-28 13:27:34 -0700609 // first, check that the -g flag is added to target modules
Colin Cross90607e92025-02-11 14:58:07 -0800610 targetLibrary := result.ModuleForTests(t, "target_library", "android_common")
Alex Humesky2070e322020-06-09 20:23:08 -0400611 targetJavaFlags := targetLibrary.Module().VariablesForTests()["javacFlags"]
612 if !strings.Contains(targetJavaFlags, "-g:source,lines") {
613 t.Errorf("target library javac flags %v should contain "+
614 "-g:source,lines override with MinimizeJavaDebugInfo", targetJavaFlags)
615 }
616
617 // check that -g is not overridden for host modules
Colin Cross0c66bc62021-07-20 09:47:41 -0700618 buildOS := result.Config.BuildOS.String()
Colin Cross90607e92025-02-11 14:58:07 -0800619 hostBinary := result.ModuleForTests(t, "host_binary", buildOS+"_common")
Alex Humesky2070e322020-06-09 20:23:08 -0400620 hostJavaFlags := hostBinary.Module().VariablesForTests()["javacFlags"]
621 if strings.Contains(hostJavaFlags, "-g:source,lines") {
622 t.Errorf("java_binary_host javac flags %v should not have "+
623 "-g:source,lines override with MinimizeJavaDebugInfo", hostJavaFlags)
624 }
Colin Cross6b4a32d2017-12-05 13:42:45 -0800625}
626
Spandan Das59a4a2b2024-01-09 21:35:56 +0000627// A minimal context object for use with DexJarBuildPath
628type moduleErrorfTestCtx struct {
629}
630
631func (ctx moduleErrorfTestCtx) ModuleErrorf(format string, args ...interface{}) {
632}
633
634var _ android.ModuleErrorfContext = (*moduleErrorfTestCtx)(nil)
635
Colin Cross72bb3632017-07-13 16:23:21 -0700636func TestPrebuilts(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -0800637 t.Parallel()
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700638 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700639 java_library {
640 name: "foo",
Paul Duffin91547182019-11-12 19:39:36 +0000641 srcs: ["a.java", ":stubs-source"],
Jihoon Kang28c96572024-09-11 23:44:44 +0000642 libs: ["bar", "sdklib.stubs"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700643 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700644 }
645
Colin Cross74d73e22017-08-02 11:05:49 -0700646 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700647 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700648 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700649 }
650
Colin Cross74d73e22017-08-02 11:05:49 -0700651 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700652 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700653 jars: ["b.jar"],
Liz Kammerd6c31d22020-08-05 15:40:41 -0700654 sdk_version: "current",
655 compile_dex: true,
Colin Cross72bb3632017-07-13 16:23:21 -0700656 }
Colin Cross42be7612019-02-21 18:12:14 -0800657
658 dex_import {
659 name: "qux",
660 jars: ["b.jar"],
661 }
Colin Cross79c7c262019-04-17 11:11:46 -0700662
663 java_sdk_library_import {
Paul Duffin56d44902020-01-31 13:36:25 +0000664 name: "sdklib",
665 public: {
666 jars: ["c.jar"],
667 },
668 }
669
Paul Duffin91547182019-11-12 19:39:36 +0000670 prebuilt_stubs_sources {
671 name: "stubs-source",
Paul Duffin9b478b02019-12-10 13:41:51 +0000672 srcs: ["stubs/sources"],
Paul Duffin91547182019-11-12 19:39:36 +0000673 }
Paul Duffin1b82e6a2019-12-03 18:06:47 +0000674
675 java_test_import {
676 name: "test",
677 jars: ["a.jar"],
678 test_suites: ["cts"],
679 test_config: "AndroidTest.xml",
680 }
Colin Cross72bb3632017-07-13 16:23:21 -0700681 `)
682
Colin Cross90607e92025-02-11 14:58:07 -0800683 fooModule := ctx.ModuleForTests(t, "foo", "android_common")
Paul Duffin9b478b02019-12-10 13:41:51 +0000684 javac := fooModule.Rule("javac")
Colin Cross90607e92025-02-11 14:58:07 -0800685 combineJar := ctx.ModuleForTests(t, "foo", "android_common").Description("for javac")
686 barModule := ctx.ModuleForTests(t, "bar", "android_common")
Colin Cross8ff4af32025-02-19 15:17:02 -0800687 barJar := barModule.Output("local-combined/bar.jar").Output
Colin Cross90607e92025-02-11 14:58:07 -0800688 bazModule := ctx.ModuleForTests(t, "baz", "android_common")
Colin Cross8ff4af32025-02-19 15:17:02 -0800689 bazJar := bazModule.Output("local-combined/baz.jar").Output
Colin Cross90607e92025-02-11 14:58:07 -0800690 sdklibStubsJar := ctx.ModuleForTests(t, "sdklib.stubs", "android_common").
Colin Cross8ff4af32025-02-19 15:17:02 -0800691 Output("local-combined/sdklib.stubs.jar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700692
Paul Duffin9b478b02019-12-10 13:41:51 +0000693 fooLibrary := fooModule.Module().(*Library)
Chaohui Wangdcbe33c2022-10-11 11:13:30 +0800694 assertDeepEquals(t, "foo unique sources incorrect",
695 []string{"a.java"}, fooLibrary.uniqueSrcFiles.Strings())
Paul Duffin91547182019-11-12 19:39:36 +0000696
Paul Duffin9b478b02019-12-10 13:41:51 +0000697 assertDeepEquals(t, "foo java source jars incorrect",
698 []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"},
699 android.NormalizePathsForTesting(fooLibrary.compiledSrcJars))
Paul Duffin91547182019-11-12 19:39:36 +0000700
Colin Cross37f6d792018-07-12 12:28:41 -0700701 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
702 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700703 }
704
Spandan Das59a4a2b2024-01-09 21:35:56 +0000705 errCtx := moduleErrorfTestCtx{}
706 barDexJar := barModule.Module().(*Import).DexJarBuildPath(errCtx)
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +0100707 if barDexJar.IsSet() {
708 t.Errorf("bar dex jar build path expected to be set, got %s", barDexJar)
Liz Kammerd6c31d22020-08-05 15:40:41 -0700709 }
710
Colin Cross79c7c262019-04-17 11:11:46 -0700711 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
712 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
713 }
714
Colin Cross37f6d792018-07-12 12:28:41 -0700715 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
716 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700717 }
Colin Cross42be7612019-02-21 18:12:14 -0800718
Spandan Das59a4a2b2024-01-09 21:35:56 +0000719 bazDexJar := bazModule.Module().(*Import).DexJarBuildPath(errCtx).Path()
Paul Duffin414ea5e2021-03-22 17:31:52 +0000720 expectedDexJar := "out/soong/.intermediates/baz/android_common/dex/baz.jar"
721 android.AssertPathRelativeToTopEquals(t, "baz dex jar build path", expectedDexJar, bazDexJar)
Liz Kammerd6c31d22020-08-05 15:40:41 -0700722
Colin Cross90607e92025-02-11 14:58:07 -0800723 ctx.ModuleForTests(t, "qux", "android_common").Rule("Cp")
Wei Li598f92d2023-01-04 17:12:24 -0800724
725 entries := android.AndroidMkEntriesForTest(t, ctx, fooModule.Module())[0]
726 android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "java_library", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0])
727 entries = android.AndroidMkEntriesForTest(t, ctx, barModule.Module())[0]
728 android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "java_import", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0])
Colin Cross72bb3632017-07-13 16:23:21 -0700729}
730
Paul Duffin9b478b02019-12-10 13:41:51 +0000731func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) {
732 if !reflect.DeepEqual(expected, actual) {
733 t.Errorf("%s: expected %q, found %q", message, expected, actual)
734 }
735}
736
Paul Duffin1a393322020-11-18 16:36:47 +0000737func TestPrebuiltStubsSources(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -0800738 t.Parallel()
Paul Duffin1a393322020-11-18 16:36:47 +0000739 test := func(t *testing.T, sourcesPath string, expectedInputs []string) {
740 ctx, _ := testJavaWithFS(t, fmt.Sprintf(`
741prebuilt_stubs_sources {
742 name: "stubs-source",
743 srcs: ["%s"],
744}`, sourcesPath), map[string][]byte{
745 "stubs/sources/pkg/A.java": nil,
746 "stubs/sources/pkg/B.java": nil,
747 })
748
Colin Cross90607e92025-02-11 14:58:07 -0800749 zipSrc := ctx.ModuleForTests(t, "stubs-source", "android_common").Rule("zip_src")
Paul Duffin1a393322020-11-18 16:36:47 +0000750 if expected, actual := expectedInputs, zipSrc.Inputs.Strings(); !reflect.DeepEqual(expected, actual) {
751 t.Errorf("mismatch of inputs to soong_zip: expected %q, actual %q", expected, actual)
752 }
753 }
754
755 t.Run("empty/missing directory", func(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -0800756 t.Parallel()
Colin Crossce3a51d2021-03-19 16:22:12 -0700757 test(t, "empty-directory", nil)
Paul Duffin1a393322020-11-18 16:36:47 +0000758 })
759
760 t.Run("non-empty set of sources", func(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -0800761 t.Parallel()
Paul Duffin1a393322020-11-18 16:36:47 +0000762 test(t, "stubs/sources", []string{
763 "stubs/sources/pkg/A.java",
764 "stubs/sources/pkg/B.java",
765 })
766 })
767}
768
Colin Cross89536d42017-07-07 14:35:50 -0700769func TestDefaults(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -0800770 t.Parallel()
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700771 ctx, _ := testJava(t, `
Colin Cross89536d42017-07-07 14:35:50 -0700772 java_defaults {
773 name: "defaults",
774 srcs: ["a.java"],
775 libs: ["bar"],
776 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -0700777 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700778 }
779
780 java_library {
781 name: "foo",
782 defaults: ["defaults"],
783 }
784
785 java_library {
786 name: "bar",
787 srcs: ["b.java"],
788 }
789
790 java_library {
791 name: "baz",
792 srcs: ["c.java"],
793 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700794
795 android_test {
796 name: "atestOptimize",
797 defaults: ["defaults"],
798 optimize: {enabled: true},
799 }
800
801 android_test {
802 name: "atestNoOptimize",
803 defaults: ["defaults"],
804 }
805
806 android_test {
807 name: "atestDefault",
808 srcs: ["a.java"],
809 }
Colin Cross89536d42017-07-07 14:35:50 -0700810 `)
811
Colin Cross90607e92025-02-11 14:58:07 -0800812 javac := ctx.ModuleForTests(t, "foo", "android_common").Rule("javac")
813 combineJar := ctx.ModuleForTests(t, "foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -0700814
815 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
816 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
817 }
818
Colin Cross8ff4af32025-02-19 15:17:02 -0800819 barTurbine := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine", "bar.jar")
Nan Zhanged19fc32017-10-19 13:06:22 -0700820 if !strings.Contains(javac.Args["classpath"], barTurbine) {
821 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -0700822 }
823
Colin Cross90607e92025-02-11 14:58:07 -0800824 baz := ctx.ModuleForTests(t, "baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -0700825 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
826 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -0700827 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700828
Colin Cross90607e92025-02-11 14:58:07 -0800829 atestOptimize := ctx.ModuleForTests(t, "atestOptimize", "android_common").MaybeRule("r8")
Sasha Smundak2057f822019-04-16 17:16:58 -0700830 if atestOptimize.Output == nil {
831 t.Errorf("atestOptimize should optimize APK")
832 }
833
Colin Cross90607e92025-02-11 14:58:07 -0800834 atestNoOptimize := ctx.ModuleForTests(t, "atestNoOptimize", "android_common").MaybeRule("d8")
Sasha Smundak2057f822019-04-16 17:16:58 -0700835 if atestNoOptimize.Output == nil {
836 t.Errorf("atestNoOptimize should not optimize APK")
837 }
838
Colin Cross90607e92025-02-11 14:58:07 -0800839 atestDefault := ctx.ModuleForTests(t, "atestDefault", "android_common").MaybeRule("d8")
Sasha Smundak2057f822019-04-16 17:16:58 -0700840 if atestDefault.Output == nil {
Jared Duke63a3da92022-06-02 19:11:14 +0000841 t.Errorf("atestDefault should not optimize APK")
Sasha Smundak2057f822019-04-16 17:16:58 -0700842 }
Colin Cross89536d42017-07-07 14:35:50 -0700843}
844
Colin Cross0f37af02017-09-27 17:42:05 -0700845func TestResources(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -0800846 t.Parallel()
Colin Cross0f37af02017-09-27 17:42:05 -0700847 var table = []struct {
848 name string
849 prop string
850 extra string
851 args string
852 }{
853 {
Colin Crossaf9c55b2017-10-03 14:50:08 -0700854 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -0700855 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -0800856 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700857 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700858 },
859 {
860 // Test that a module with java_resources includes the files
861 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -0700862 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
863 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700864 },
865 {
866 // Test that a module with a filegroup in java_resources includes the files with the
867 // path prefix
868 name: "resource filegroup",
869 prop: `java_resources: [":foo-res"]`,
870 extra: `
871 filegroup {
872 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -0800873 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -0700874 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -0700875 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700876 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700877 },
878 {
Colin Cross0ead1d72018-04-10 13:07:42 -0700879 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
880 name: "wildcard dirs",
881 prop: `java_resource_dirs: ["java-res/*"]`,
882 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
883 },
884 {
885 // Test that a module exclude_java_resource_dirs excludes the files
886 name: "wildcard dirs",
887 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
888 args: "-C java-res/a -f java-res/a/a",
889 },
Colin Crosscedd4762018-09-13 11:26:19 -0700890 {
891 // Test wildcards in java_resources
892 name: "wildcard files",
893 prop: `java_resources: ["java-res/**/*"]`,
894 args: "-C . -f java-res/a/a -f java-res/b/b",
895 },
896 {
897 // Test exclude_java_resources with java_resources
898 name: "wildcard files with exclude",
899 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
900 args: "-C . -f java-res/a/a",
901 },
902 {
903 // Test exclude_java_resources with java_resource_dirs
904 name: "resource dirs with exclude files",
905 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
906 args: "-C java-res -f java-res/a/a",
907 },
908 {
909 // Test exclude_java_resource_dirs with java_resource_dirs
910 name: "resource dirs with exclude files",
911 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
912 args: "-C java-res -f java-res/a/a -f java-res/b/b",
913 },
Colin Cross0f37af02017-09-27 17:42:05 -0700914 }
915
916 for _, test := range table {
917 t.Run(test.name, func(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -0800918 t.Parallel()
Colin Cross238c1f32020-06-07 16:58:18 -0700919 ctx, _ := testJavaWithFS(t, `
Colin Cross0f37af02017-09-27 17:42:05 -0700920 java_library {
921 name: "foo",
922 srcs: [
923 "a.java",
924 "b.java",
925 "c.java",
926 ],
927 `+test.prop+`,
928 }
Colin Cross238c1f32020-06-07 16:58:18 -0700929 `+test.extra,
930 map[string][]byte{
931 "java-res/a/a": nil,
932 "java-res/b/b": nil,
933 "java-res2/a": nil,
934 },
935 )
Colin Cross0f37af02017-09-27 17:42:05 -0700936
Colin Cross90607e92025-02-11 14:58:07 -0800937 foo := ctx.ModuleForTests(t, "foo", "android_common").Output("withres/foo.jar")
938 fooRes := ctx.ModuleForTests(t, "foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -0700939
940 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
941 t.Errorf("foo combined jars %v does not contain %q",
942 foo.Inputs.Strings(), fooRes.Output.String())
943 }
944
Colin Crossaf9c55b2017-10-03 14:50:08 -0700945 if fooRes.Args["jarArgs"] != test.args {
946 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -0700947 fooRes.Args["jarArgs"], test.args)
948 }
949 })
950 }
951}
952
Colin Cross0c4ce212019-05-03 15:28:19 -0700953func TestIncludeSrcs(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -0800954 t.Parallel()
Colin Cross238c1f32020-06-07 16:58:18 -0700955 ctx, _ := testJavaWithFS(t, `
Colin Cross0c4ce212019-05-03 15:28:19 -0700956 java_library {
957 name: "foo",
958 srcs: [
959 "a.java",
960 "b.java",
961 "c.java",
962 ],
963 include_srcs: true,
964 }
965
966 java_library {
967 name: "bar",
968 srcs: [
969 "a.java",
970 "b.java",
971 "c.java",
972 ],
973 java_resource_dirs: ["java-res"],
974 include_srcs: true,
975 }
Colin Cross238c1f32020-06-07 16:58:18 -0700976 `, map[string][]byte{
977 "java-res/a/a": nil,
978 "java-res/b/b": nil,
979 "java-res2/a": nil,
980 })
Colin Cross0c4ce212019-05-03 15:28:19 -0700981
982 // Test a library with include_srcs: true
Colin Cross90607e92025-02-11 14:58:07 -0800983 foo := ctx.ModuleForTests(t, "foo", "android_common").Output("withres/foo.jar")
984 fooSrcJar := ctx.ModuleForTests(t, "foo", "android_common").Output("foo.srcjar")
Colin Cross0c4ce212019-05-03 15:28:19 -0700985
986 if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) {
987 t.Errorf("foo combined jars %v does not contain %q", w, g)
988 }
989
990 if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
991 t.Errorf("foo source jar args %q is not %q", w, g)
992 }
993
994 // Test a library with include_srcs: true and resources
Colin Cross90607e92025-02-11 14:58:07 -0800995 bar := ctx.ModuleForTests(t, "bar", "android_common").Output("withres/bar.jar")
996 barResCombined := ctx.ModuleForTests(t, "bar", "android_common").Output("res-combined/bar.jar")
997 barRes := ctx.ModuleForTests(t, "bar", "android_common").Output("res/bar.jar")
998 barSrcJar := ctx.ModuleForTests(t, "bar", "android_common").Output("bar.srcjar")
Colin Cross0c4ce212019-05-03 15:28:19 -0700999
1000 if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
1001 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
1002 }
1003
1004 if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
1005 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
1006 }
1007
Colin Cross8ff4af32025-02-19 15:17:02 -08001008 if g, w := barRes.Output.String(), bar.Inputs.Strings(); !inList(g, w) {
Colin Cross0c4ce212019-05-03 15:28:19 -07001009 t.Errorf("bar combined jars %v does not contain %q", w, g)
1010 }
1011
1012 if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
1013 t.Errorf("bar source jar args %q is not %q", w, g)
1014 }
1015
1016 if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w {
1017 t.Errorf("bar resource jar args %q is not %q", w, g)
1018 }
1019}
1020
Colin Cross54190b32017-10-09 15:34:10 -07001021func TestGeneratedSources(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001022 t.Parallel()
Colin Cross238c1f32020-06-07 16:58:18 -07001023 ctx, _ := testJavaWithFS(t, `
Colin Cross54190b32017-10-09 15:34:10 -07001024 java_library {
1025 name: "foo",
1026 srcs: [
1027 "a*.java",
1028 ":gen",
1029 "b*.java",
1030 ],
1031 }
1032
1033 genrule {
1034 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -08001035 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -07001036 out: ["gen.java"],
1037 }
Colin Cross238c1f32020-06-07 16:58:18 -07001038 `, map[string][]byte{
1039 "a.java": nil,
1040 "b.java": nil,
1041 })
Colin Cross54190b32017-10-09 15:34:10 -07001042
Colin Cross90607e92025-02-11 14:58:07 -08001043 javac := ctx.ModuleForTests(t, "foo", "android_common").Rule("javac")
1044 genrule := ctx.ModuleForTests(t, "gen", "").Rule("generator")
Colin Cross54190b32017-10-09 15:34:10 -07001045
Colin Cross15e86d92017-10-20 15:07:08 -07001046 if filepath.Base(genrule.Output.String()) != "gen.java" {
1047 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -07001048 }
1049
1050 if len(javac.Inputs) != 3 ||
1051 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -07001052 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -07001053 javac.Inputs[2].String() != "b.java" {
1054 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
1055 }
1056}
1057
Nan Zhang61eaedb2017-11-02 13:28:15 -07001058func TestTurbine(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001059 t.Parallel()
Paul Duffin71ae5942021-03-22 15:36:52 +00001060 result := android.GroupFixturePreparers(
1061 prepareForJavaTest, FixtureWithPrebuiltApis(map[string][]string{"14": {"foo"}})).
Paul Duffin3d9f2682021-03-13 09:47:16 +00001062 RunTestWithBp(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001063 java_library {
1064 name: "foo",
1065 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +09001066 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001067 }
1068
1069 java_library {
1070 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -08001071 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -07001072 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +09001073 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001074 }
1075
1076 java_library {
1077 name: "baz",
1078 srcs: ["c.java"],
1079 libs: ["bar"],
1080 sdk_version: "14",
1081 }
1082 `)
1083
Colin Cross90607e92025-02-11 14:58:07 -08001084 fooTurbine := result.ModuleForTests(t, "foo", "android_common").Rule("turbine")
1085 barTurbine := result.ModuleForTests(t, "bar", "android_common").Rule("turbine")
1086 barJavac := result.ModuleForTests(t, "bar", "android_common").Rule("javac")
1087 barTurbineCombined := result.ModuleForTests(t, "bar", "android_common").Description("for turbine")
1088 bazJavac := result.ModuleForTests(t, "baz", "android_common").Rule("javac")
Nan Zhang61eaedb2017-11-02 13:28:15 -07001089
Paul Duffin414ea5e2021-03-22 17:31:52 +00001090 android.AssertPathsRelativeToTopEquals(t, "foo inputs", []string{"a.java"}, fooTurbine.Inputs)
Nan Zhang61eaedb2017-11-02 13:28:15 -07001091
Colin Cross8ff4af32025-02-19 15:17:02 -08001092 fooHeaderJar := filepath.Join("out", "soong", ".intermediates", "foo", "android_common", "turbine", "foo.jar")
Paul Duffin414ea5e2021-03-22 17:31:52 +00001093 barTurbineJar := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine", "bar.jar")
Colin Crossf61766e2022-03-16 18:06:48 -07001094 android.AssertStringDoesContain(t, "bar turbine classpath", barTurbine.Args["turbineFlags"], fooHeaderJar)
Paul Duffin3d9f2682021-03-13 09:47:16 +00001095 android.AssertStringDoesContain(t, "bar javac classpath", barJavac.Args["classpath"], fooHeaderJar)
Paul Duffin414ea5e2021-03-22 17:31:52 +00001096 android.AssertPathsRelativeToTopEquals(t, "bar turbine combineJar", []string{barTurbineJar, fooHeaderJar}, barTurbineCombined.Inputs)
Paul Duffin3d9f2682021-03-13 09:47:16 +00001097 android.AssertStringDoesContain(t, "baz javac classpath", bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -07001098}
1099
1100func TestSharding(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001101 t.Parallel()
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001102 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001103 java_library {
1104 name: "bar",
1105 srcs: ["a.java","b.java","c.java"],
1106 javac_shard_size: 1
1107 }
1108 `)
1109
Colin Cross3d56ed52021-11-18 22:23:12 -08001110 barHeaderJar := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine", "bar.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -07001111 for i := 0; i < 3; i++ {
Colin Cross90607e92025-02-11 14:58:07 -08001112 barJavac := ctx.ModuleForTests(t, "bar", "android_common").Description("javac" + strconv.Itoa(i))
Colin Cross3d56ed52021-11-18 22:23:12 -08001113 if !strings.HasPrefix(barJavac.Args["classpath"], "-classpath "+barHeaderJar+":") {
1114 t.Errorf("bar javac classpath %v does start with %q", barJavac.Args["classpath"], barHeaderJar)
Nan Zhang61eaedb2017-11-02 13:28:15 -07001115 }
1116 }
1117}
1118
Nan Zhang27e284d2018-02-09 21:03:53 +00001119func TestExcludeFileGroupInSrcs(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001120 t.Parallel()
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001121 ctx, _ := testJava(t, `
Nan Zhang27e284d2018-02-09 21:03:53 +00001122 java_library {
1123 name: "foo",
1124 srcs: ["a.java", ":foo-srcs"],
1125 exclude_srcs: ["a.java", ":foo-excludes"],
1126 }
1127
1128 filegroup {
1129 name: "foo-srcs",
1130 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
1131 }
1132
1133 filegroup {
1134 name: "foo-excludes",
1135 srcs: ["java-fg/a.java", "java-fg/b.java"],
1136 }
1137 `)
1138
Colin Cross90607e92025-02-11 14:58:07 -08001139 javac := ctx.ModuleForTests(t, "foo", "android_common").Rule("javac")
Nan Zhang27e284d2018-02-09 21:03:53 +00001140
1141 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
1142 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
1143 }
1144}
Jiyong Parkc678ad32018-04-10 13:07:10 +09001145
Colin Crossdad2a362024-03-23 04:43:41 +00001146func TestJavaLibraryOutputFiles(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001147 t.Parallel()
Paul Duffin414ea5e2021-03-22 17:31:52 +00001148 testJavaWithFS(t, "", map[string][]byte{
Paul Duffin52d398a2019-06-11 12:31:14 +01001149 "libcore/Android.bp": []byte(`
1150 java_library {
1151 name: "core",
1152 sdk_version: "none",
1153 system_modules: "none",
Paul Duffinaa55f742020-10-06 17:20:13 +01001154 }
1155
1156 filegroup {
1157 name: "core-jar",
Cole Faust65cb40a2024-10-21 15:41:42 -07001158 device_common_srcs: [":core{.jar}"],
Paul Duffinaa55f742020-10-06 17:20:13 +01001159 }
Paul Duffin414ea5e2021-03-22 17:31:52 +00001160 `),
Paul Duffinaa55f742020-10-06 17:20:13 +01001161 })
Paul Duffinaa55f742020-10-06 17:20:13 +01001162}
1163
Colin Crossdad2a362024-03-23 04:43:41 +00001164func TestJavaImportOutputFiles(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001165 t.Parallel()
Paul Duffin414ea5e2021-03-22 17:31:52 +00001166 testJavaWithFS(t, "", map[string][]byte{
Paul Duffinaa55f742020-10-06 17:20:13 +01001167 "libcore/Android.bp": []byte(`
1168 java_import {
1169 name: "core",
1170 sdk_version: "none",
1171 }
1172
1173 filegroup {
1174 name: "core-jar",
Cole Faust65cb40a2024-10-21 15:41:42 -07001175 device_common_srcs: [":core{.jar}"],
Paul Duffinaa55f742020-10-06 17:20:13 +01001176 }
Paul Duffin414ea5e2021-03-22 17:31:52 +00001177 `),
Paul Duffin52d398a2019-06-11 12:31:14 +01001178 })
Paul Duffin52d398a2019-06-11 12:31:14 +01001179}
1180
Colin Crossdad2a362024-03-23 04:43:41 +00001181func TestJavaImport(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001182 t.Parallel()
Colin Crossdad2a362024-03-23 04:43:41 +00001183 bp := `
1184 java_library {
1185 name: "source_library",
1186 srcs: ["source.java"],
1187 }
1188
1189 java_import {
1190 name: "import_with_no_deps",
1191 jars: ["no_deps.jar"],
1192 }
1193
1194 java_import {
1195 name: "import_with_source_deps",
1196 jars: ["source_deps.jar"],
1197 static_libs: ["source_library"],
1198 }
1199
1200 java_import {
1201 name: "import_with_import_deps",
1202 jars: ["import_deps.jar"],
1203 static_libs: ["import_with_no_deps"],
1204 }
1205 `
1206 ctx := android.GroupFixturePreparers(
1207 PrepareForTestWithJavaDefaultModules,
1208 ).RunTestWithBp(t, bp)
1209
Colin Cross90607e92025-02-11 14:58:07 -08001210 source := ctx.ModuleForTests(t, "source_library", "android_common")
Colin Crossdad2a362024-03-23 04:43:41 +00001211 sourceJar := source.Output("javac/source_library.jar")
Colin Cross8ff4af32025-02-19 15:17:02 -08001212 sourceHeaderJar := source.Output("turbine/source_library.jar")
1213 sourceCombinedHeaderJar := source.Output("turbine-combined/source_library.jar")
Yu Liu663e4502024-08-12 18:23:59 +00001214 sourceJavaInfo, _ := android.OtherModuleProvider(ctx, source.Module(), JavaInfoProvider)
Colin Crossdad2a362024-03-23 04:43:41 +00001215
1216 // The source library produces separate implementation and header jars
1217 android.AssertPathsRelativeToTopEquals(t, "source library implementation jar",
1218 []string{sourceJar.Output.String()}, sourceJavaInfo.ImplementationAndResourcesJars)
1219 android.AssertPathsRelativeToTopEquals(t, "source library header jar",
Colin Cross8ff4af32025-02-19 15:17:02 -08001220 []string{sourceCombinedHeaderJar.Output.String()}, sourceJavaInfo.HeaderJars)
Colin Crossdad2a362024-03-23 04:43:41 +00001221
Colin Cross90607e92025-02-11 14:58:07 -08001222 importWithNoDeps := ctx.ModuleForTests(t, "import_with_no_deps", "android_common")
Colin Cross8ff4af32025-02-19 15:17:02 -08001223 importWithNoDepsLocalJar := importWithNoDeps.Output("local-combined/import_with_no_deps.jar")
Colin Crossdad2a362024-03-23 04:43:41 +00001224 importWithNoDepsJar := importWithNoDeps.Output("combined/import_with_no_deps.jar")
Yu Liu663e4502024-08-12 18:23:59 +00001225 importWithNoDepsJavaInfo, _ := android.OtherModuleProvider(ctx, importWithNoDeps.Module(), JavaInfoProvider)
Colin Crossdad2a362024-03-23 04:43:41 +00001226
1227 // An import with no deps produces a single jar used as both the header and implementation jar.
1228 android.AssertPathsRelativeToTopEquals(t, "import with no deps implementation jar",
1229 []string{importWithNoDepsJar.Output.String()}, importWithNoDepsJavaInfo.ImplementationAndResourcesJars)
1230 android.AssertPathsRelativeToTopEquals(t, "import with no deps header jar",
1231 []string{importWithNoDepsJar.Output.String()}, importWithNoDepsJavaInfo.HeaderJars)
1232 android.AssertPathsRelativeToTopEquals(t, "import with no deps combined inputs",
Colin Cross8ff4af32025-02-19 15:17:02 -08001233 []string{importWithNoDepsLocalJar.Output.String()}, importWithNoDepsJar.Inputs)
1234 android.AssertPathsRelativeToTopEquals(t, "import with no deps local combined inputs",
1235 []string{"no_deps.jar"}, importWithNoDepsLocalJar.Inputs)
Colin Crossdad2a362024-03-23 04:43:41 +00001236
Colin Cross90607e92025-02-11 14:58:07 -08001237 importWithSourceDeps := ctx.ModuleForTests(t, "import_with_source_deps", "android_common")
Colin Cross8ff4af32025-02-19 15:17:02 -08001238 importWithSourceDepsLocalJar := importWithSourceDeps.Output("local-combined/import_with_source_deps.jar")
Colin Crossdad2a362024-03-23 04:43:41 +00001239 importWithSourceDepsJar := importWithSourceDeps.Output("combined/import_with_source_deps.jar")
Colin Cross8ff4af32025-02-19 15:17:02 -08001240 importWithSourceDepsLocalHeaderJar := importWithSourceDeps.Output("local-combined/import_with_source_deps.jar")
Colin Crossdad2a362024-03-23 04:43:41 +00001241 importWithSourceDepsHeaderJar := importWithSourceDeps.Output("turbine-combined/import_with_source_deps.jar")
Yu Liu663e4502024-08-12 18:23:59 +00001242 importWithSourceDepsJavaInfo, _ := android.OtherModuleProvider(ctx, importWithSourceDeps.Module(), JavaInfoProvider)
Colin Crossdad2a362024-03-23 04:43:41 +00001243
1244 // An import with source deps produces separate header and implementation jars.
1245 android.AssertPathsRelativeToTopEquals(t, "import with source deps implementation jar",
1246 []string{importWithSourceDepsJar.Output.String()}, importWithSourceDepsJavaInfo.ImplementationAndResourcesJars)
1247 android.AssertPathsRelativeToTopEquals(t, "import with source deps header jar",
1248 []string{importWithSourceDepsHeaderJar.Output.String()}, importWithSourceDepsJavaInfo.HeaderJars)
1249 android.AssertPathsRelativeToTopEquals(t, "import with source deps combined implementation jar inputs",
Colin Cross8ff4af32025-02-19 15:17:02 -08001250 []string{importWithSourceDepsLocalJar.Output.String(), sourceJar.Output.String()}, importWithSourceDepsJar.Inputs)
Colin Crossdad2a362024-03-23 04:43:41 +00001251 android.AssertPathsRelativeToTopEquals(t, "import with source deps combined header jar inputs",
Colin Cross8ff4af32025-02-19 15:17:02 -08001252 []string{importWithSourceDepsLocalHeaderJar.Output.String(), sourceHeaderJar.Output.String()}, importWithSourceDepsHeaderJar.Inputs)
1253 android.AssertPathsRelativeToTopEquals(t, "import with source deps local combined implementation jar inputs",
1254 []string{"source_deps.jar"}, importWithSourceDepsLocalJar.Inputs)
1255 android.AssertPathsRelativeToTopEquals(t, "import with source deps local combined header jar inputs",
1256 []string{"source_deps.jar"}, importWithSourceDepsLocalHeaderJar.Inputs)
Colin Crossdad2a362024-03-23 04:43:41 +00001257
Colin Cross90607e92025-02-11 14:58:07 -08001258 importWithImportDeps := ctx.ModuleForTests(t, "import_with_import_deps", "android_common")
Colin Cross8ff4af32025-02-19 15:17:02 -08001259 importWithImportDepsLocalJar := importWithImportDeps.Output("local-combined/import_with_import_deps.jar")
Colin Crossdad2a362024-03-23 04:43:41 +00001260 importWithImportDepsJar := importWithImportDeps.Output("combined/import_with_import_deps.jar")
Yu Liu663e4502024-08-12 18:23:59 +00001261 importWithImportDepsJavaInfo, _ := android.OtherModuleProvider(ctx, importWithImportDeps.Module(), JavaInfoProvider)
Colin Crossdad2a362024-03-23 04:43:41 +00001262
1263 // An import with only import deps produces a single jar used as both the header and implementation jar.
1264 android.AssertPathsRelativeToTopEquals(t, "import with import deps implementation jar",
1265 []string{importWithImportDepsJar.Output.String()}, importWithImportDepsJavaInfo.ImplementationAndResourcesJars)
1266 android.AssertPathsRelativeToTopEquals(t, "import with import deps header jar",
1267 []string{importWithImportDepsJar.Output.String()}, importWithImportDepsJavaInfo.HeaderJars)
1268 android.AssertPathsRelativeToTopEquals(t, "import with import deps combined implementation jar inputs",
Colin Cross8ff4af32025-02-19 15:17:02 -08001269 []string{importWithImportDepsLocalJar.Output.String(), importWithNoDepsLocalJar.Output.String()}, importWithImportDepsJar.Inputs)
1270 android.AssertPathsRelativeToTopEquals(t, "import with import deps local combined implementation jar inputs",
1271 []string{"import_deps.jar"}, importWithImportDepsLocalJar.Inputs)
Colin Crossdad2a362024-03-23 04:43:41 +00001272}
1273
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001274var compilerFlagsTestCases = []struct {
1275 in string
1276 out bool
1277}{
1278 {
1279 in: "a",
1280 out: false,
1281 },
1282 {
1283 in: "-a",
1284 out: true,
1285 },
1286 {
1287 in: "-no-jdk",
1288 out: false,
1289 },
1290 {
1291 in: "-no-stdlib",
1292 out: false,
1293 },
1294 {
1295 in: "-kotlin-home",
1296 out: false,
1297 },
1298 {
1299 in: "-kotlin-home /some/path",
1300 out: false,
1301 },
1302 {
1303 in: "-include-runtime",
1304 out: false,
1305 },
1306 {
1307 in: "-Xintellij-plugin-root",
1308 out: false,
1309 },
1310}
1311
1312type mockContext struct {
1313 android.ModuleContext
1314 result bool
1315}
1316
1317func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
1318 // CheckBadCompilerFlags calls this function when the flag should be rejected
1319 ctx.result = false
1320}
1321
1322func TestCompilerFlags(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001323 t.Parallel()
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001324 for _, testCase := range compilerFlagsTestCases {
1325 ctx := &mockContext{result: true}
1326 CheckKotlincFlags(ctx, []string{testCase.in})
1327 if ctx.result != testCase.out {
1328 t.Errorf("incorrect output:")
1329 t.Errorf(" input: %#v", testCase.in)
1330 t.Errorf(" expected: %#v", testCase.out)
1331 t.Errorf(" got: %#v", ctx.result)
1332 }
1333 }
1334}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001335
1336// TODO(jungjw): Consider making this more robust by ignoring path order.
1337func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
Colin Cross8ff4af32025-02-19 15:17:02 -08001338 t.Helper()
Colin Cross90607e92025-02-11 14:58:07 -08001339 variables := ctx.ModuleForTests(t, moduleName, "android_common").VariablesForTestsRelativeToTop()
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001340 flags := strings.Split(variables["javacFlags"], " ")
1341 got := ""
1342 for _, flag := range flags {
1343 keyEnd := strings.Index(flag, "=")
1344 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
1345 got = flag[keyEnd+1:]
1346 break
1347 }
1348 }
Lukacs T. Berki9f6c24a2021-08-26 15:07:24 +02001349 if expected != android.StringPathRelativeToTop(ctx.Config().SoongOutDir(), got) {
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001350 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
1351 }
1352}
1353
1354func TestPatchModule(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001355 t.Parallel()
Pete Gillin0c2143e2019-05-02 15:32:11 +01001356 t.Run("Java language level 8", func(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001357 t.Parallel()
Pete Gillin1b3370f2019-10-01 13:57:31 +01001358 // Test with legacy javac -source 1.8 -target 1.8
Pete Gillinbdf5d712019-10-21 14:29:58 +01001359 bp := `
1360 java_library {
1361 name: "foo",
1362 srcs: ["a.java"],
1363 java_version: "1.8",
1364 }
1365
1366 java_library {
1367 name: "bar",
1368 srcs: ["b.java"],
1369 sdk_version: "none",
1370 system_modules: "none",
1371 patch_module: "java.base",
1372 java_version: "1.8",
1373 }
1374
1375 java_library {
1376 name: "baz",
1377 srcs: ["c.java"],
1378 patch_module: "java.base",
1379 java_version: "1.8",
1380 }
1381 `
1382 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001383
1384 checkPatchModuleFlag(t, ctx, "foo", "")
1385 checkPatchModuleFlag(t, ctx, "bar", "")
1386 checkPatchModuleFlag(t, ctx, "baz", "")
1387 })
1388
Pete Gillin0c2143e2019-05-02 15:32:11 +01001389 t.Run("Java language level 9", func(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001390 t.Parallel()
Pete Gillin1b3370f2019-10-01 13:57:31 +01001391 // Test with default javac -source 9 -target 9
Pete Gillinbdf5d712019-10-21 14:29:58 +01001392 bp := `
1393 java_library {
1394 name: "foo",
1395 srcs: ["a.java"],
1396 }
1397
1398 java_library {
1399 name: "bar",
1400 srcs: ["b.java"],
1401 sdk_version: "none",
1402 system_modules: "none",
1403 patch_module: "java.base",
1404 }
1405
1406 java_library {
1407 name: "baz",
Jingwen Chen5136a6e2020-10-30 01:01:35 -04001408 srcs: [
1409 "c.java",
1410 // Tests for b/150878007
1411 "dir/d.java",
1412 "dir2/e.java",
1413 "dir2/f.java",
1414 "nested/dir/g.java"
1415 ],
Pete Gillinbdf5d712019-10-21 14:29:58 +01001416 patch_module: "java.base",
1417 }
1418 `
Pete Gillin1b3370f2019-10-01 13:57:31 +01001419 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001420
1421 checkPatchModuleFlag(t, ctx, "foo", "")
Paul Duffin414ea5e2021-03-22 17:31:52 +00001422 expected := "java.base=.:out/soong"
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001423 checkPatchModuleFlag(t, ctx, "bar", expected)
Jingwen Chen5136a6e2020-10-30 01:01:35 -04001424 expected = "java.base=" + strings.Join([]string{
Colin Cross8ff10582023-12-07 13:10:56 -08001425 ".", "out/soong", defaultModuleToPath("ext"), defaultModuleToPath("framework")}, ":")
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001426 checkPatchModuleFlag(t, ctx, "baz", expected)
1427 })
1428}
Paul Duffina7b9f422020-01-10 17:12:18 +00001429
Paul Duffin83a2d962019-11-19 19:44:10 +00001430func TestJavaLibraryWithSystemModules(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001431 t.Parallel()
Paul Duffin83a2d962019-11-19 19:44:10 +00001432 ctx, _ := testJava(t, `
1433 java_library {
1434 name: "lib-with-source-system-modules",
1435 srcs: [
1436 "a.java",
1437 ],
1438 sdk_version: "none",
1439 system_modules: "source-system-modules",
1440 }
1441
1442 java_library {
1443 name: "source-jar",
1444 srcs: [
1445 "a.java",
1446 ],
1447 }
1448
1449 java_system_modules {
1450 name: "source-system-modules",
1451 libs: ["source-jar"],
1452 }
1453
1454 java_library {
1455 name: "lib-with-prebuilt-system-modules",
1456 srcs: [
1457 "a.java",
1458 ],
1459 sdk_version: "none",
1460 system_modules: "prebuilt-system-modules",
1461 }
1462
1463 java_import {
1464 name: "prebuilt-jar",
1465 jars: ["a.jar"],
1466 }
1467
1468 java_system_modules_import {
1469 name: "prebuilt-system-modules",
1470 libs: ["prebuilt-jar"],
1471 }
1472 `)
1473
Jihoon Kangb0f4c022024-08-06 00:15:25 +00001474 checkBootClasspathForLibWithSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar")
Paul Duffin83a2d962019-11-19 19:44:10 +00001475
Jihoon Kangb0f4c022024-08-06 00:15:25 +00001476 checkBootClasspathForLibWithSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar")
Paul Duffin83a2d962019-11-19 19:44:10 +00001477}
1478
Jihoon Kangb0f4c022024-08-06 00:15:25 +00001479func checkBootClasspathForLibWithSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) {
Colin Cross90607e92025-02-11 14:58:07 -08001480 javacRule := ctx.ModuleForTests(t, moduleName, "android_common").Rule("javac")
Paul Duffin83a2d962019-11-19 19:44:10 +00001481 bootClasspath := javacRule.Args["bootClasspath"]
1482 if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) {
1483 t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath)
1484 }
1485}
Jiyong Park19604de2020-03-24 16:44:11 +09001486
1487func TestAidlExportIncludeDirsFromImports(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001488 t.Parallel()
Jiyong Park19604de2020-03-24 16:44:11 +09001489 ctx, _ := testJava(t, `
1490 java_library {
1491 name: "foo",
1492 srcs: ["aidl/foo/IFoo.aidl"],
1493 libs: ["bar"],
1494 }
1495
1496 java_import {
1497 name: "bar",
1498 jars: ["a.jar"],
1499 aidl: {
1500 export_include_dirs: ["aidl/bar"],
1501 },
1502 }
1503 `)
1504
Colin Cross90607e92025-02-11 14:58:07 -08001505 aidlCommand := ctx.ModuleForTests(t, "foo", "android_common").Rule("aidl").RuleParams.Command
Jiyong Park19604de2020-03-24 16:44:11 +09001506 expectedAidlFlag := "-Iaidl/bar"
1507 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1508 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1509 }
1510}
Liz Kammerdd849a82020-06-12 16:38:45 -07001511
Jooyung Hane197d8b2021-01-05 10:33:16 +09001512func TestAidlFlagsArePassedToTheAidlCompiler(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001513 t.Parallel()
Jooyung Hane197d8b2021-01-05 10:33:16 +09001514 ctx, _ := testJava(t, `
1515 java_library {
1516 name: "foo",
1517 srcs: ["aidl/foo/IFoo.aidl"],
1518 aidl: { flags: ["-Werror"], },
1519 }
1520 `)
1521
Colin Cross90607e92025-02-11 14:58:07 -08001522 aidlCommand := ctx.ModuleForTests(t, "foo", "android_common").Rule("aidl").RuleParams.Command
Jooyung Hane197d8b2021-01-05 10:33:16 +09001523 expectedAidlFlag := "-Werror"
1524 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1525 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1526 }
1527}
1528
Jooyung Han07f70c02021-11-06 07:08:45 +09001529func TestAidlFlagsWithMinSdkVersion(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001530 t.Parallel()
Jooyung Han07f70c02021-11-06 07:08:45 +09001531 fixture := android.GroupFixturePreparers(
1532 prepareForJavaTest, FixtureWithPrebuiltApis(map[string][]string{"14": {"foo"}}))
1533
1534 for _, tc := range []struct {
1535 name string
1536 sdkVersion string
1537 expected string
1538 }{
1539 {"default is current", "", "current"},
1540 {"use sdk_version", `sdk_version: "14"`, "14"},
1541 {"system_current", `sdk_version: "system_current"`, "current"},
1542 } {
1543 t.Run(tc.name, func(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001544 t.Parallel()
Jooyung Han07f70c02021-11-06 07:08:45 +09001545 ctx := fixture.RunTestWithBp(t, `
1546 java_library {
1547 name: "foo",
1548 srcs: ["aidl/foo/IFoo.aidl"],
1549 `+tc.sdkVersion+`
1550 }
1551 `)
Colin Cross90607e92025-02-11 14:58:07 -08001552 aidlCommand := ctx.ModuleForTests(t, "foo", "android_common").Rule("aidl").RuleParams.Command
Jooyung Han07f70c02021-11-06 07:08:45 +09001553 expectedAidlFlag := "--min_sdk_version=" + tc.expected
1554 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1555 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1556 }
1557 })
1558 }
1559}
1560
Spandan Das757b6662022-11-17 04:29:59 +00001561func TestAidlFlagsMinSdkVersionDroidstubs(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001562 t.Parallel()
Spandan Das757b6662022-11-17 04:29:59 +00001563 bpTemplate := `
1564 droidstubs {
1565 name: "foo-stubs",
1566 srcs: ["foo.aidl"],
1567 %s
1568 system_modules: "none",
1569 }
1570 `
1571 testCases := []struct {
1572 desc string
1573 sdkVersionBp string
1574 minSdkVersionExpected string
1575 }{
1576 {
1577 desc: "sdk_version not set, module compiles against private platform APIs",
1578 sdkVersionBp: ``,
1579 minSdkVersionExpected: "10000",
1580 },
1581 {
1582 desc: "sdk_version set to none, module does not build against an SDK",
1583 sdkVersionBp: `sdk_version: "none",`,
1584 minSdkVersionExpected: "10000",
1585 },
1586 }
1587 for _, tc := range testCases {
1588 ctx := prepareForJavaTest.RunTestWithBp(t, fmt.Sprintf(bpTemplate, tc.sdkVersionBp))
Colin Cross90607e92025-02-11 14:58:07 -08001589 aidlCmd := ctx.ModuleForTests(t, "foo-stubs", "android_common").Rule("aidl").RuleParams.Command
Spandan Das757b6662022-11-17 04:29:59 +00001590 expected := "--min_sdk_version=" + tc.minSdkVersionExpected
1591 android.AssertStringDoesContain(t, "aidl command conatins incorrect min_sdk_version for testCse: "+tc.desc, aidlCmd, expected)
1592 }
1593}
1594
Thiébaud Weksteende8417c2022-02-10 15:41:46 +11001595func TestAidlEnforcePermissions(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001596 t.Parallel()
Thiébaud Weksteende8417c2022-02-10 15:41:46 +11001597 ctx, _ := testJava(t, `
1598 java_library {
1599 name: "foo",
1600 srcs: ["aidl/foo/IFoo.aidl"],
1601 aidl: { enforce_permissions: true },
1602 }
1603 `)
1604
Colin Cross90607e92025-02-11 14:58:07 -08001605 aidlCommand := ctx.ModuleForTests(t, "foo", "android_common").Rule("aidl").RuleParams.Command
Thiébaud Weksteende8417c2022-02-10 15:41:46 +11001606 expectedAidlFlag := "-Wmissing-permission-annotation -Werror"
1607 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1608 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1609 }
1610}
1611
1612func TestAidlEnforcePermissionsException(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001613 t.Parallel()
Thiébaud Weksteende8417c2022-02-10 15:41:46 +11001614 ctx, _ := testJava(t, `
1615 java_library {
1616 name: "foo",
1617 srcs: ["aidl/foo/IFoo.aidl", "aidl/foo/IFoo2.aidl"],
1618 aidl: { enforce_permissions: true, enforce_permissions_exceptions: ["aidl/foo/IFoo2.aidl"] },
1619 }
1620 `)
1621
Colin Cross90607e92025-02-11 14:58:07 -08001622 aidlCommand := ctx.ModuleForTests(t, "foo", "android_common").Rule("aidl").RuleParams.Command
Thiébaud Weksteende8417c2022-02-10 15:41:46 +11001623 expectedAidlFlag := "$$FLAGS -Wmissing-permission-annotation -Werror aidl/foo/IFoo.aidl"
1624 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1625 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1626 }
1627 expectedAidlFlag = "$$FLAGS aidl/foo/IFoo2.aidl"
1628 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1629 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1630 }
1631}
1632
Liz Kammerdd849a82020-06-12 16:38:45 -07001633func TestDataNativeBinaries(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001634 t.Parallel()
Cole Faust5c503d12023-01-24 11:48:08 -08001635 ctx := android.GroupFixturePreparers(
1636 prepareForJavaTest,
1637 android.PrepareForTestWithAllowMissingDependencies).RunTestWithBp(t, `
Liz Kammerdd849a82020-06-12 16:38:45 -07001638 java_test_host {
1639 name: "foo",
1640 srcs: ["a.java"],
1641 data_native_bins: ["bin"]
1642 }
1643
Cole Faust5c503d12023-01-24 11:48:08 -08001644 cc_binary_host {
Liz Kammerdd849a82020-06-12 16:38:45 -07001645 name: "bin",
Cole Faust5c503d12023-01-24 11:48:08 -08001646 srcs: ["bin.cpp"],
Liz Kammerdd849a82020-06-12 16:38:45 -07001647 }
Cole Faust5c503d12023-01-24 11:48:08 -08001648 `).TestContext
Liz Kammerdd849a82020-06-12 16:38:45 -07001649
Colin Cross0c66bc62021-07-20 09:47:41 -07001650 buildOS := ctx.Config().BuildOS.String()
Liz Kammerdd849a82020-06-12 16:38:45 -07001651
Colin Cross90607e92025-02-11 14:58:07 -08001652 test := ctx.ModuleForTests(t, "foo", buildOS+"_common").Module().(*TestHost)
Colin Crossaa255532020-07-03 13:18:24 -07001653 entries := android.AndroidMkEntriesForTest(t, ctx, test)[0]
Cole Faust5c503d12023-01-24 11:48:08 -08001654 expected := []string{"out/soong/.intermediates/bin/" + buildOS + "_x86_64/bin:bin"}
Liz Kammerdd849a82020-06-12 16:38:45 -07001655 actual := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
Paul Duffin414ea5e2021-03-22 17:31:52 +00001656 android.AssertStringPathsRelativeToTopEquals(t, "LOCAL_COMPATIBILITY_SUPPORT_FILES", ctx.Config(), expected, actual)
Liz Kammerdd849a82020-06-12 16:38:45 -07001657}
Yuexi Ma627263f2021-03-04 13:47:56 -08001658
1659func TestDefaultInstallable(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001660 t.Parallel()
Yuexi Ma627263f2021-03-04 13:47:56 -08001661 ctx, _ := testJava(t, `
1662 java_test_host {
1663 name: "foo"
1664 }
1665 `)
1666
Colin Cross0c66bc62021-07-20 09:47:41 -07001667 buildOS := ctx.Config().BuildOS.String()
Colin Cross90607e92025-02-11 14:58:07 -08001668 module := ctx.ModuleForTests(t, "foo", buildOS+"_common").Module().(*TestHost)
Yuexi Ma627263f2021-03-04 13:47:56 -08001669 assertDeepEquals(t, "Default installable value should be true.", proptools.BoolPtr(true),
1670 module.properties.Installable)
1671}
Cole Faust75fffb12021-06-13 15:23:16 -07001672
1673func TestErrorproneEnabled(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001674 t.Parallel()
Cole Faust75fffb12021-06-13 15:23:16 -07001675 ctx, _ := testJava(t, `
1676 java_library {
1677 name: "foo",
1678 srcs: ["a.java"],
1679 errorprone: {
1680 enabled: true,
1681 },
1682 }
1683 `)
1684
Colin Cross90607e92025-02-11 14:58:07 -08001685 javac := ctx.ModuleForTests(t, "foo", "android_common").Description("javac")
Cole Faust75fffb12021-06-13 15:23:16 -07001686
1687 // Test that the errorprone plugins are passed to javac
1688 expectedSubstring := "-Xplugin:ErrorProne"
1689 if !strings.Contains(javac.Args["javacFlags"], expectedSubstring) {
Cole Faust2b1536e2021-06-18 12:25:54 -07001690 t.Errorf("expected javacFlags to contain %q, got %q", expectedSubstring, javac.Args["javacFlags"])
Cole Faust75fffb12021-06-13 15:23:16 -07001691 }
1692
1693 // Modules with errorprone { enabled: true } will include errorprone checks
1694 // in the main javac build rule. Only when RUN_ERROR_PRONE is true will
1695 // the explicit errorprone build rule be created.
Colin Cross90607e92025-02-11 14:58:07 -08001696 errorprone := ctx.ModuleForTests(t, "foo", "android_common").MaybeDescription("errorprone")
Cole Faust75fffb12021-06-13 15:23:16 -07001697 if errorprone.RuleParams.Description != "" {
1698 t.Errorf("expected errorprone build rule to not exist, but it did")
1699 }
1700}
Cole Faust2b1536e2021-06-18 12:25:54 -07001701
1702func TestErrorproneDisabled(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001703 t.Parallel()
Cole Faust2b1536e2021-06-18 12:25:54 -07001704 bp := `
1705 java_library {
1706 name: "foo",
1707 srcs: ["a.java"],
1708 errorprone: {
1709 enabled: false,
1710 },
1711 }
1712 `
1713 ctx := android.GroupFixturePreparers(
1714 PrepareForTestWithJavaDefaultModules,
1715 android.FixtureMergeEnv(map[string]string{
1716 "RUN_ERROR_PRONE": "true",
1717 }),
1718 ).RunTestWithBp(t, bp)
1719
Colin Cross90607e92025-02-11 14:58:07 -08001720 javac := ctx.ModuleForTests(t, "foo", "android_common").Description("javac")
Cole Faust2b1536e2021-06-18 12:25:54 -07001721
1722 // Test that the errorprone plugins are not passed to javac, like they would
1723 // be if enabled was true.
1724 expectedSubstring := "-Xplugin:ErrorProne"
1725 if strings.Contains(javac.Args["javacFlags"], expectedSubstring) {
1726 t.Errorf("expected javacFlags to not contain %q, got %q", expectedSubstring, javac.Args["javacFlags"])
1727 }
1728
1729 // Check that no errorprone build rule is created, like there would be
1730 // if enabled was unset and RUN_ERROR_PRONE was true.
Colin Cross90607e92025-02-11 14:58:07 -08001731 errorprone := ctx.ModuleForTests(t, "foo", "android_common").MaybeDescription("errorprone")
Cole Faust2b1536e2021-06-18 12:25:54 -07001732 if errorprone.RuleParams.Description != "" {
1733 t.Errorf("expected errorprone build rule to not exist, but it did")
1734 }
1735}
1736
1737func TestErrorproneEnabledOnlyByEnvironmentVariable(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001738 t.Parallel()
Cole Faust2b1536e2021-06-18 12:25:54 -07001739 bp := `
1740 java_library {
1741 name: "foo",
1742 srcs: ["a.java"],
1743 }
1744 `
1745 ctx := android.GroupFixturePreparers(
1746 PrepareForTestWithJavaDefaultModules,
1747 android.FixtureMergeEnv(map[string]string{
1748 "RUN_ERROR_PRONE": "true",
1749 }),
1750 ).RunTestWithBp(t, bp)
1751
Colin Cross90607e92025-02-11 14:58:07 -08001752 javac := ctx.ModuleForTests(t, "foo", "android_common").Description("javac")
1753 errorprone := ctx.ModuleForTests(t, "foo", "android_common").Description("errorprone")
Cole Faust2b1536e2021-06-18 12:25:54 -07001754
1755 // Check that the errorprone plugins are not passed to javac, because they
1756 // will instead be passed to the separate errorprone compilation
1757 expectedSubstring := "-Xplugin:ErrorProne"
1758 if strings.Contains(javac.Args["javacFlags"], expectedSubstring) {
1759 t.Errorf("expected javacFlags to not contain %q, got %q", expectedSubstring, javac.Args["javacFlags"])
1760 }
1761
1762 // Check that the errorprone plugin is enabled
1763 if !strings.Contains(errorprone.Args["javacFlags"], expectedSubstring) {
1764 t.Errorf("expected errorprone to contain %q, got %q", expectedSubstring, javac.Args["javacFlags"])
1765 }
1766}
Sam Delmericob3342ce2022-01-20 21:10:28 +00001767
1768func TestDataDeviceBinsBuildsDeviceBinary(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001769 t.Parallel()
Sam Delmericocc271e22022-06-01 15:45:02 +00001770 testCases := []struct {
1771 dataDeviceBinType string
1772 depCompileMultilib string
1773 variants []string
1774 expectedError string
1775 }{
1776 {
1777 dataDeviceBinType: "first",
1778 depCompileMultilib: "first",
1779 variants: []string{"android_arm64_armv8-a"},
1780 },
1781 {
1782 dataDeviceBinType: "first",
1783 depCompileMultilib: "both",
1784 variants: []string{"android_arm64_armv8-a"},
1785 },
1786 {
1787 // this is true because our testing framework is set up with
1788 // Targets ~ [<64bit target>, <32bit target>], where 64bit is "first"
1789 dataDeviceBinType: "first",
1790 depCompileMultilib: "32",
1791 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1792 },
1793 {
1794 dataDeviceBinType: "first",
1795 depCompileMultilib: "64",
1796 variants: []string{"android_arm64_armv8-a"},
1797 },
1798 {
1799 dataDeviceBinType: "both",
1800 depCompileMultilib: "both",
1801 variants: []string{
1802 "android_arm_armv7-a-neon",
1803 "android_arm64_armv8-a",
1804 },
1805 },
1806 {
1807 dataDeviceBinType: "both",
1808 depCompileMultilib: "32",
1809 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1810 },
1811 {
1812 dataDeviceBinType: "both",
1813 depCompileMultilib: "64",
1814 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1815 },
1816 {
1817 dataDeviceBinType: "both",
1818 depCompileMultilib: "first",
1819 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1820 },
1821 {
1822 dataDeviceBinType: "32",
1823 depCompileMultilib: "32",
1824 variants: []string{"android_arm_armv7-a-neon"},
1825 },
1826 {
1827 dataDeviceBinType: "32",
1828 depCompileMultilib: "first",
1829 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1830 },
1831 {
1832 dataDeviceBinType: "32",
1833 depCompileMultilib: "both",
1834 variants: []string{"android_arm_armv7-a-neon"},
1835 },
1836 {
1837 dataDeviceBinType: "32",
1838 depCompileMultilib: "64",
1839 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1840 },
1841 {
1842 dataDeviceBinType: "64",
1843 depCompileMultilib: "64",
1844 variants: []string{"android_arm64_armv8-a"},
1845 },
1846 {
1847 dataDeviceBinType: "64",
1848 depCompileMultilib: "both",
1849 variants: []string{"android_arm64_armv8-a"},
1850 },
1851 {
1852 dataDeviceBinType: "64",
1853 depCompileMultilib: "first",
1854 variants: []string{"android_arm64_armv8-a"},
1855 },
1856 {
1857 dataDeviceBinType: "64",
1858 depCompileMultilib: "32",
1859 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1860 },
1861 {
1862 dataDeviceBinType: "prefer32",
1863 depCompileMultilib: "32",
1864 variants: []string{"android_arm_armv7-a-neon"},
1865 },
1866 {
1867 dataDeviceBinType: "prefer32",
1868 depCompileMultilib: "both",
1869 variants: []string{"android_arm_armv7-a-neon"},
1870 },
1871 {
1872 dataDeviceBinType: "prefer32",
1873 depCompileMultilib: "first",
1874 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1875 },
1876 {
1877 dataDeviceBinType: "prefer32",
1878 depCompileMultilib: "64",
1879 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1880 },
Sam Delmericob3342ce2022-01-20 21:10:28 +00001881 }
Sam Delmericob3342ce2022-01-20 21:10:28 +00001882
Sam Delmericocc271e22022-06-01 15:45:02 +00001883 bpTemplate := `
Sam Delmericob3342ce2022-01-20 21:10:28 +00001884 java_test_host {
1885 name: "foo",
1886 srcs: ["test.java"],
Sam Delmericocc271e22022-06-01 15:45:02 +00001887 data_device_bins_%s: ["bar"],
Sam Delmericob3342ce2022-01-20 21:10:28 +00001888 }
1889
1890 cc_binary {
1891 name: "bar",
Sam Delmericocc271e22022-06-01 15:45:02 +00001892 compile_multilib: "%s",
Sam Delmericob3342ce2022-01-20 21:10:28 +00001893 }
1894 `
1895
Sam Delmericocc271e22022-06-01 15:45:02 +00001896 for _, tc := range testCases {
1897 bp := fmt.Sprintf(bpTemplate, tc.dataDeviceBinType, tc.depCompileMultilib)
Sam Delmericob3342ce2022-01-20 21:10:28 +00001898
Sam Delmericocc271e22022-06-01 15:45:02 +00001899 errorHandler := android.FixtureExpectsNoErrors
1900 if tc.expectedError != "" {
1901 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(tc.expectedError)
1902 }
Sam Delmericob3342ce2022-01-20 21:10:28 +00001903
Sam Delmericocc271e22022-06-01 15:45:02 +00001904 testName := fmt.Sprintf(`data_device_bins_%s with compile_multilib:"%s"`, tc.dataDeviceBinType, tc.depCompileMultilib)
1905 t.Run(testName, func(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001906 t.Parallel()
Sam Delmericocc271e22022-06-01 15:45:02 +00001907 ctx := android.GroupFixturePreparers(PrepareForIntegrationTestWithJava).
1908 ExtendWithErrorHandler(errorHandler).
1909 RunTestWithBp(t, bp)
1910 if tc.expectedError != "" {
1911 return
1912 }
1913
1914 buildOS := ctx.Config.BuildOS.String()
Colin Cross90607e92025-02-11 14:58:07 -08001915 fooVariant := ctx.ModuleForTests(t, "foo", buildOS+"_common")
Sam Delmericocc271e22022-06-01 15:45:02 +00001916 fooMod := fooVariant.Module().(*TestHost)
1917 entries := android.AndroidMkEntriesForTest(t, ctx.TestContext, fooMod)[0]
1918
1919 expectedAutogenConfig := `<option name="push-file" key="bar" value="/data/local/tests/unrestricted/foo/bar" />`
1920 autogen := fooVariant.Rule("autogen")
1921 if !strings.Contains(autogen.Args["extraConfigs"], expectedAutogenConfig) {
1922 t.Errorf("foo extraConfigs %v does not contain %q", autogen.Args["extraConfigs"], expectedAutogenConfig)
1923 }
1924
1925 expectedData := []string{}
1926 for _, variant := range tc.variants {
Colin Cross90607e92025-02-11 14:58:07 -08001927 barVariant := ctx.ModuleForTests(t, "bar", variant)
Sam Delmericocc271e22022-06-01 15:45:02 +00001928 relocated := barVariant.Output("bar")
1929 expectedInput := fmt.Sprintf("out/soong/.intermediates/bar/%s/unstripped/bar", variant)
1930 android.AssertPathRelativeToTopEquals(t, "relocation input", expectedInput, relocated.Input)
1931
1932 expectedData = append(expectedData, fmt.Sprintf("out/soong/.intermediates/bar/%s/bar:bar", variant))
1933 }
1934
1935 actualData := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
Jihoon Kang82197492025-01-29 19:30:31 +00001936 android.AssertStringPathsRelativeToTopEquals(t, "LOCAL_TEST_DATA", ctx.Config, android.SortedUniqueStrings(expectedData), android.SortedUniqueStrings(actualData))
Sam Delmericocc271e22022-06-01 15:45:02 +00001937 })
Sam Delmericob3342ce2022-01-20 21:10:28 +00001938 }
1939}
Sam Delmerico277795c2022-02-25 17:04:37 +00001940
Zi Wangca65b402022-10-10 13:45:06 -07001941func TestDeviceBinaryWrapperGeneration(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001942 t.Parallel()
Zi Wangca65b402022-10-10 13:45:06 -07001943 // Scenario 1: java_binary has main_class property in its bp
1944 ctx, _ := testJava(t, `
1945 java_binary {
1946 name: "foo",
1947 srcs: ["foo.java"],
1948 main_class: "foo.bar.jb",
1949 }
1950 `)
Colin Cross90607e92025-02-11 14:58:07 -08001951 wrapperPath := fmt.Sprint(ctx.ModuleForTests(t, "foo", "android_common").AllOutputs())
Zi Wangca65b402022-10-10 13:45:06 -07001952 if !strings.Contains(wrapperPath, "foo.sh") {
1953 t.Errorf("wrapper file foo.sh is not generated")
1954 }
1955
1956 // Scenario 2: java_binary has neither wrapper nor main_class, its build
1957 // is expected to be failed.
1958 testJavaError(t, "main_class property is required for device binary if no default wrapper is assigned", `
1959 java_binary {
1960 name: "foo",
1961 srcs: ["foo.java"],
1962 }`)
1963}
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001964
Jihoon Kang3198f3c2023-01-26 08:08:52 +00001965func TestJavaApiContributionEmptyApiFile(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001966 t.Parallel()
Jihoon Kang063ec002023-06-28 01:16:23 +00001967 android.GroupFixturePreparers(
1968 prepareForJavaTest,
1969 android.FixtureMergeEnv(
1970 map[string]string{
1971 "DISABLE_STUB_VALIDATION": "true",
1972 },
1973 ),
1974 ).ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(
Jihoon Kang3198f3c2023-01-26 08:08:52 +00001975 "Error: foo has an empty api file.",
Jihoon Kang063ec002023-06-28 01:16:23 +00001976 )).RunTestWithBp(t, `
1977 java_api_contribution {
Jihoon Kang3198f3c2023-01-26 08:08:52 +00001978 name: "foo",
1979 }
1980 java_api_library {
1981 name: "bar",
1982 api_surface: "public",
1983 api_contributions: ["foo"],
Jihoon Kang5d701272024-02-15 21:53:49 +00001984 stubs_type: "everything",
Jihoon Kang3198f3c2023-01-26 08:08:52 +00001985 }
1986 `)
1987}
1988
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001989func TestJavaApiLibraryAndProviderLink(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08001990 t.Parallel()
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001991 provider_bp_a := `
1992 java_api_contribution {
1993 name: "foo1",
Jihoon Kang84473f52023-08-11 22:36:33 +00001994 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00001995 api_surface: "public",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001996 }
1997 `
1998 provider_bp_b := `java_api_contribution {
1999 name: "foo2",
Jihoon Kang84473f52023-08-11 22:36:33 +00002000 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002001 api_surface: "public",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002002 }
2003 `
Jihoon Kang063ec002023-06-28 01:16:23 +00002004 ctx := android.GroupFixturePreparers(
2005 prepareForJavaTest,
2006 android.FixtureMergeMockFs(
2007 map[string][]byte{
2008 "a/Android.bp": []byte(provider_bp_a),
2009 "b/Android.bp": []byte(provider_bp_b),
2010 },
2011 ),
2012 android.FixtureMergeEnv(
2013 map[string]string{
2014 "DISABLE_STUB_VALIDATION": "true",
2015 },
2016 ),
2017 ).RunTestWithBp(t, `
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002018 java_api_library {
2019 name: "bar1",
2020 api_surface: "public",
Jihoon Kang60d4a092022-11-17 23:47:43 +00002021 api_contributions: ["foo1"],
Jihoon Kang5d701272024-02-15 21:53:49 +00002022 stubs_type: "everything",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002023 }
2024
2025 java_api_library {
2026 name: "bar2",
2027 api_surface: "system",
Jihoon Kang60d4a092022-11-17 23:47:43 +00002028 api_contributions: ["foo1", "foo2"],
Jihoon Kang5d701272024-02-15 21:53:49 +00002029 stubs_type: "everything",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002030 }
Jihoon Kang063ec002023-06-28 01:16:23 +00002031 `)
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002032
2033 testcases := []struct {
2034 moduleName string
2035 sourceTextFileDirs []string
2036 }{
2037 {
2038 moduleName: "bar1",
Jihoon Kang84473f52023-08-11 22:36:33 +00002039 sourceTextFileDirs: []string{"a/current.txt"},
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002040 },
2041 {
2042 moduleName: "bar2",
Jihoon Kang6be0f002023-09-20 23:03:01 +00002043 sourceTextFileDirs: []string{"a/current.txt", "b/current.txt"},
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002044 },
2045 }
2046 for _, c := range testcases {
Colin Cross90607e92025-02-11 14:58:07 -08002047 m := ctx.ModuleForTests(t, c.moduleName, "android_common")
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002048 manifest := m.Output("metalava.sbox.textproto")
Colin Crossf61d03d2023-11-02 16:56:39 -07002049 sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx.TestContext, manifest)
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002050 manifestCommand := sboxProto.Commands[0].GetCommand()
2051 sourceFilesFlag := "--source-files " + strings.Join(c.sourceTextFileDirs, " ")
2052 android.AssertStringDoesContain(t, "source text files not present", manifestCommand, sourceFilesFlag)
2053 }
2054}
2055
Jihoon Kang1c51f502023-01-09 23:42:40 +00002056func TestJavaApiLibraryAndDefaultsLink(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08002057 t.Parallel()
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002058 provider_bp_a := `
2059 java_api_contribution {
Jihoon Kang1c51f502023-01-09 23:42:40 +00002060 name: "foo1",
Jihoon Kang84473f52023-08-11 22:36:33 +00002061 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002062 api_surface: "public",
Jihoon Kang1c51f502023-01-09 23:42:40 +00002063 }
2064 `
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002065 provider_bp_b := `
2066 java_api_contribution {
Jihoon Kang1c51f502023-01-09 23:42:40 +00002067 name: "foo2",
Jihoon Kang84473f52023-08-11 22:36:33 +00002068 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002069 api_surface: "public",
Jihoon Kang1c51f502023-01-09 23:42:40 +00002070 }
2071 `
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002072 provider_bp_c := `
2073 java_api_contribution {
Jihoon Kang1c51f502023-01-09 23:42:40 +00002074 name: "foo3",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002075 api_file: "system-current.txt",
2076 api_surface: "system",
Jihoon Kang1c51f502023-01-09 23:42:40 +00002077 }
2078 `
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002079 provider_bp_d := `
2080 java_api_contribution {
Jihoon Kang1c51f502023-01-09 23:42:40 +00002081 name: "foo4",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002082 api_file: "system-current.txt",
2083 api_surface: "system",
Jihoon Kang1c51f502023-01-09 23:42:40 +00002084 }
2085 `
Jihoon Kang063ec002023-06-28 01:16:23 +00002086 ctx := android.GroupFixturePreparers(
2087 prepareForJavaTest,
2088 android.FixtureMergeMockFs(
2089 map[string][]byte{
2090 "a/Android.bp": []byte(provider_bp_a),
2091 "b/Android.bp": []byte(provider_bp_b),
2092 "c/Android.bp": []byte(provider_bp_c),
2093 "d/Android.bp": []byte(provider_bp_d),
2094 },
2095 ),
2096 android.FixtureMergeEnv(
2097 map[string]string{
2098 "DISABLE_STUB_VALIDATION": "true",
2099 },
2100 ),
2101 ).RunTestWithBp(t, `
Jihoon Kang1c51f502023-01-09 23:42:40 +00002102 java_defaults {
2103 name: "baz1",
2104 api_surface: "public",
2105 api_contributions: ["foo1", "foo2"],
2106 }
2107
2108 java_defaults {
2109 name: "baz2",
2110 api_surface: "system",
2111 api_contributions: ["foo3"],
2112 }
2113
2114 java_api_library {
2115 name: "bar1",
2116 api_surface: "public",
2117 api_contributions: ["foo1"],
Jihoon Kang5d701272024-02-15 21:53:49 +00002118 stubs_type: "everything",
Jihoon Kang1c51f502023-01-09 23:42:40 +00002119 }
2120
2121 java_api_library {
2122 name: "bar2",
2123 api_surface: "public",
2124 defaults:["baz1"],
Jihoon Kang5d701272024-02-15 21:53:49 +00002125 stubs_type: "everything",
Jihoon Kang1c51f502023-01-09 23:42:40 +00002126 }
2127
2128 java_api_library {
2129 name: "bar3",
2130 api_surface: "system",
2131 defaults:["baz1", "baz2"],
2132 api_contributions: ["foo4"],
Jihoon Kang5d701272024-02-15 21:53:49 +00002133 stubs_type: "everything",
Jihoon Kang1c51f502023-01-09 23:42:40 +00002134 }
Jihoon Kang063ec002023-06-28 01:16:23 +00002135 `)
Jihoon Kang1c51f502023-01-09 23:42:40 +00002136
2137 testcases := []struct {
2138 moduleName string
2139 sourceTextFileDirs []string
2140 }{
2141 {
2142 moduleName: "bar1",
Jihoon Kang84473f52023-08-11 22:36:33 +00002143 sourceTextFileDirs: []string{"a/current.txt"},
Jihoon Kang1c51f502023-01-09 23:42:40 +00002144 },
2145 {
2146 moduleName: "bar2",
Jihoon Kang84473f52023-08-11 22:36:33 +00002147 sourceTextFileDirs: []string{"a/current.txt", "b/current.txt"},
Jihoon Kang1c51f502023-01-09 23:42:40 +00002148 },
2149 {
Jihoon Kang8fe19822023-09-14 06:27:36 +00002150 moduleName: "bar3",
2151 // API text files need to be sorted from the narrower api scope to the wider api scope
Jihoon Kang6be0f002023-09-20 23:03:01 +00002152 sourceTextFileDirs: []string{"a/current.txt", "b/current.txt", "c/system-current.txt", "d/system-current.txt"},
Jihoon Kang1c51f502023-01-09 23:42:40 +00002153 },
2154 }
2155 for _, c := range testcases {
Colin Cross90607e92025-02-11 14:58:07 -08002156 m := ctx.ModuleForTests(t, c.moduleName, "android_common")
Jihoon Kang1c51f502023-01-09 23:42:40 +00002157 manifest := m.Output("metalava.sbox.textproto")
Colin Crossf61d03d2023-11-02 16:56:39 -07002158 sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx.TestContext, manifest)
Jihoon Kang1c51f502023-01-09 23:42:40 +00002159 manifestCommand := sboxProto.Commands[0].GetCommand()
2160 sourceFilesFlag := "--source-files " + strings.Join(c.sourceTextFileDirs, " ")
2161 android.AssertStringDoesContain(t, "source text files not present", manifestCommand, sourceFilesFlag)
2162 }
2163}
2164
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002165func TestJavaApiLibraryJarGeneration(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08002166 t.Parallel()
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002167 provider_bp_a := `
2168 java_api_contribution {
2169 name: "foo1",
Jihoon Kang84473f52023-08-11 22:36:33 +00002170 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002171 api_surface: "public",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002172 }
2173 `
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002174 provider_bp_b := `
2175 java_api_contribution {
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002176 name: "foo2",
Jihoon Kang84473f52023-08-11 22:36:33 +00002177 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002178 api_surface: "public",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002179 }
2180 `
Jihoon Kang063ec002023-06-28 01:16:23 +00002181 ctx := android.GroupFixturePreparers(
2182 prepareForJavaTest,
2183 android.FixtureMergeMockFs(
2184 map[string][]byte{
2185 "a/Android.bp": []byte(provider_bp_a),
2186 "b/Android.bp": []byte(provider_bp_b),
2187 },
2188 ),
2189 android.FixtureMergeEnv(
2190 map[string]string{
2191 "DISABLE_STUB_VALIDATION": "true",
2192 },
2193 ),
2194 ).RunTestWithBp(t, `
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002195 java_api_library {
2196 name: "bar1",
2197 api_surface: "public",
Jihoon Kang60d4a092022-11-17 23:47:43 +00002198 api_contributions: ["foo1"],
Jihoon Kang5d701272024-02-15 21:53:49 +00002199 stubs_type: "everything",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002200 }
2201
2202 java_api_library {
2203 name: "bar2",
2204 api_surface: "system",
Jihoon Kang60d4a092022-11-17 23:47:43 +00002205 api_contributions: ["foo1", "foo2"],
Jihoon Kang5d701272024-02-15 21:53:49 +00002206 stubs_type: "everything",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002207 }
Jihoon Kang063ec002023-06-28 01:16:23 +00002208 `)
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002209
2210 testcases := []struct {
2211 moduleName string
2212 outputJarName string
2213 }{
2214 {
2215 moduleName: "bar1",
Jihoon Kang25857f52023-03-01 00:27:32 +00002216 outputJarName: "bar1/bar1.jar",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002217 },
2218 {
2219 moduleName: "bar2",
Jihoon Kang25857f52023-03-01 00:27:32 +00002220 outputJarName: "bar2/bar2.jar",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002221 },
2222 }
2223 for _, c := range testcases {
Colin Cross90607e92025-02-11 14:58:07 -08002224 m := ctx.ModuleForTests(t, c.moduleName, "android_common")
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002225 outputs := fmt.Sprint(m.AllOutputs())
2226 if !strings.Contains(outputs, c.outputJarName) {
2227 t.Errorf("Module output does not contain expected jar %s", c.outputJarName)
2228 }
2229 }
2230}
Cole Faust21680542022-12-07 18:18:37 -08002231
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002232func TestJavaApiLibraryLibsLink(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08002233 t.Parallel()
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002234 provider_bp_a := `
2235 java_api_contribution {
2236 name: "foo1",
Jihoon Kang84473f52023-08-11 22:36:33 +00002237 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002238 api_surface: "public",
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002239 }
2240 `
2241 provider_bp_b := `
2242 java_api_contribution {
2243 name: "foo2",
Jihoon Kang84473f52023-08-11 22:36:33 +00002244 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002245 api_surface: "public",
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002246 }
2247 `
2248 lib_bp_a := `
2249 java_library {
2250 name: "lib1",
2251 srcs: ["Lib.java"],
2252 }
2253 `
2254 lib_bp_b := `
2255 java_library {
2256 name: "lib2",
2257 srcs: ["Lib.java"],
2258 }
2259 `
2260
Jihoon Kang063ec002023-06-28 01:16:23 +00002261 ctx := android.GroupFixturePreparers(
2262 prepareForJavaTest,
2263 android.FixtureMergeMockFs(
2264 map[string][]byte{
2265 "a/Android.bp": []byte(provider_bp_a),
2266 "b/Android.bp": []byte(provider_bp_b),
2267 "c/Android.bp": []byte(lib_bp_a),
2268 "c/Lib.java": {},
2269 "d/Android.bp": []byte(lib_bp_b),
2270 "d/Lib.java": {},
2271 },
2272 ),
2273 android.FixtureMergeEnv(
2274 map[string]string{
2275 "DISABLE_STUB_VALIDATION": "true",
2276 },
2277 ),
2278 ).RunTestWithBp(t, `
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002279 java_api_library {
2280 name: "bar1",
2281 api_surface: "public",
2282 api_contributions: ["foo1"],
2283 libs: ["lib1"],
Jihoon Kang5d701272024-02-15 21:53:49 +00002284 stubs_type: "everything",
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002285 }
2286
2287 java_api_library {
2288 name: "bar2",
2289 api_surface: "system",
2290 api_contributions: ["foo1", "foo2"],
2291 libs: ["lib1", "lib2", "bar1"],
Jihoon Kang5d701272024-02-15 21:53:49 +00002292 stubs_type: "everything",
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002293 }
Jihoon Kang063ec002023-06-28 01:16:23 +00002294 `)
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002295
2296 testcases := []struct {
2297 moduleName string
2298 classPathJarNames []string
2299 }{
2300 {
2301 moduleName: "bar1",
2302 classPathJarNames: []string{"lib1.jar"},
2303 },
2304 {
2305 moduleName: "bar2",
Jihoon Kang25857f52023-03-01 00:27:32 +00002306 classPathJarNames: []string{"lib1.jar", "lib2.jar", "bar1/bar1.jar"},
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002307 },
2308 }
2309 for _, c := range testcases {
Colin Cross90607e92025-02-11 14:58:07 -08002310 m := ctx.ModuleForTests(t, c.moduleName, "android_common")
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002311 javacRules := m.Rule("javac")
2312 classPathArgs := javacRules.Args["classpath"]
2313 for _, jarName := range c.classPathJarNames {
2314 if !strings.Contains(classPathArgs, jarName) {
2315 t.Errorf("Module output does not contain expected jar %s", jarName)
2316 }
2317 }
2318 }
2319}
2320
Jihoon Kange30fff02023-02-14 20:18:20 +00002321func TestJavaApiLibraryStaticLibsLink(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08002322 t.Parallel()
Jihoon Kange30fff02023-02-14 20:18:20 +00002323 provider_bp_a := `
2324 java_api_contribution {
2325 name: "foo1",
Jihoon Kang84473f52023-08-11 22:36:33 +00002326 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002327 api_surface: "public",
Jihoon Kange30fff02023-02-14 20:18:20 +00002328 }
2329 `
2330 provider_bp_b := `
2331 java_api_contribution {
2332 name: "foo2",
Jihoon Kang84473f52023-08-11 22:36:33 +00002333 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002334 api_surface: "public",
Jihoon Kange30fff02023-02-14 20:18:20 +00002335 }
2336 `
2337 lib_bp_a := `
2338 java_library {
2339 name: "lib1",
2340 srcs: ["Lib.java"],
2341 }
2342 `
2343 lib_bp_b := `
2344 java_library {
2345 name: "lib2",
2346 srcs: ["Lib.java"],
2347 }
2348 `
2349
Jihoon Kang063ec002023-06-28 01:16:23 +00002350 ctx := android.GroupFixturePreparers(
2351 prepareForJavaTest,
2352 android.FixtureMergeMockFs(
2353 map[string][]byte{
2354 "a/Android.bp": []byte(provider_bp_a),
2355 "b/Android.bp": []byte(provider_bp_b),
2356 "c/Android.bp": []byte(lib_bp_a),
2357 "c/Lib.java": {},
2358 "d/Android.bp": []byte(lib_bp_b),
2359 "d/Lib.java": {},
2360 },
2361 ),
2362 android.FixtureMergeEnv(
2363 map[string]string{
2364 "DISABLE_STUB_VALIDATION": "true",
2365 },
2366 ),
2367 ).RunTestWithBp(t, `
Jihoon Kange30fff02023-02-14 20:18:20 +00002368 java_api_library {
2369 name: "bar1",
2370 api_surface: "public",
2371 api_contributions: ["foo1"],
2372 static_libs: ["lib1"],
Jihoon Kang5d701272024-02-15 21:53:49 +00002373 stubs_type: "everything",
Jihoon Kange30fff02023-02-14 20:18:20 +00002374 }
2375
2376 java_api_library {
2377 name: "bar2",
2378 api_surface: "system",
2379 api_contributions: ["foo1", "foo2"],
2380 static_libs: ["lib1", "lib2", "bar1"],
Jihoon Kang5d701272024-02-15 21:53:49 +00002381 stubs_type: "everything",
Jihoon Kange30fff02023-02-14 20:18:20 +00002382 }
Jihoon Kang063ec002023-06-28 01:16:23 +00002383 `)
Jihoon Kange30fff02023-02-14 20:18:20 +00002384
2385 testcases := []struct {
2386 moduleName string
2387 staticLibJarNames []string
2388 }{
2389 {
2390 moduleName: "bar1",
2391 staticLibJarNames: []string{"lib1.jar"},
2392 },
2393 {
2394 moduleName: "bar2",
Jihoon Kang25857f52023-03-01 00:27:32 +00002395 staticLibJarNames: []string{"lib1.jar", "lib2.jar", "bar1/bar1.jar"},
Jihoon Kange30fff02023-02-14 20:18:20 +00002396 },
2397 }
2398 for _, c := range testcases {
Colin Cross90607e92025-02-11 14:58:07 -08002399 m := ctx.ModuleForTests(t, c.moduleName, "android_common")
Jihoon Kange30fff02023-02-14 20:18:20 +00002400 mergeZipsCommand := m.Rule("merge_zips").RuleParams.Command
2401 for _, jarName := range c.staticLibJarNames {
2402 if !strings.Contains(mergeZipsCommand, jarName) {
2403 t.Errorf("merge_zips command does not contain expected jar %s", jarName)
2404 }
2405 }
2406 }
2407}
2408
Anton Hansson0e73f9e2023-09-20 13:39:57 +00002409func TestTransitiveSrcFiles(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08002410 t.Parallel()
Anton Hansson0e73f9e2023-09-20 13:39:57 +00002411 ctx, _ := testJava(t, `
2412 java_library {
2413 name: "a",
2414 srcs: ["a.java"],
2415 }
2416 java_library {
2417 name: "b",
2418 srcs: ["b.java"],
2419 }
2420 java_library {
2421 name: "c",
2422 srcs: ["c.java"],
2423 libs: ["a"],
2424 static_libs: ["b"],
2425 }
2426 `)
Colin Cross90607e92025-02-11 14:58:07 -08002427 c := ctx.ModuleForTests(t, "c", "android_common").Module()
Yu Liu663e4502024-08-12 18:23:59 +00002428 javaInfo, _ := android.OtherModuleProvider(ctx, c, JavaInfoProvider)
Colin Cross5a377182023-12-14 14:46:23 -08002429 transitiveSrcFiles := android.Paths(javaInfo.TransitiveSrcFiles.ToList())
Anton Hansson0e73f9e2023-09-20 13:39:57 +00002430 android.AssertArrayString(t, "unexpected jar deps", []string{"b.java", "c.java"}, transitiveSrcFiles.Strings())
2431}
2432
Cole Faust21680542022-12-07 18:18:37 -08002433func TestTradefedOptions(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08002434 t.Parallel()
Cole Faust21680542022-12-07 18:18:37 -08002435 result := PrepareForTestWithJavaBuildComponents.RunTestWithBp(t, `
2436java_test_host {
2437 name: "foo",
2438 test_options: {
2439 tradefed_options: [
2440 {
2441 name: "exclude-path",
2442 value: "org/apache"
2443 }
2444 ]
2445 }
2446}
2447`)
2448
2449 buildOS := result.Config.BuildOS.String()
Colin Cross90607e92025-02-11 14:58:07 -08002450 args := result.ModuleForTests(t, "foo", buildOS+"_common").
Cole Faust21680542022-12-07 18:18:37 -08002451 Output("out/soong/.intermediates/foo/" + buildOS + "_common/foo.config").Args
2452 expected := proptools.NinjaAndShellEscape("<option name=\"exclude-path\" value=\"org/apache\" />")
2453 if args["extraConfigs"] != expected {
2454 t.Errorf("Expected args[\"extraConfigs\"] to equal %q, was %q", expected, args["extraConfigs"])
2455 }
2456}
Dan Shiec731432023-05-26 04:21:44 +00002457
2458func TestTestRunnerOptions(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08002459 t.Parallel()
Dan Shiec731432023-05-26 04:21:44 +00002460 result := PrepareForTestWithJavaBuildComponents.RunTestWithBp(t, `
2461java_test_host {
2462 name: "foo",
2463 test_options: {
2464 test_runner_options: [
2465 {
2466 name: "test-timeout",
2467 value: "10m"
2468 }
2469 ]
2470 }
2471}
2472`)
2473
2474 buildOS := result.Config.BuildOS.String()
Colin Cross90607e92025-02-11 14:58:07 -08002475 args := result.ModuleForTests(t, "foo", buildOS+"_common").
Dan Shiec731432023-05-26 04:21:44 +00002476 Output("out/soong/.intermediates/foo/" + buildOS + "_common/foo.config").Args
2477 expected := proptools.NinjaAndShellEscape("<option name=\"test-timeout\" value=\"10m\" />\\n ")
2478 if args["extraTestRunnerConfigs"] != expected {
2479 t.Errorf("Expected args[\"extraTestRunnerConfigs\"] to equal %q, was %q", expected, args["extraTestRunnerConfigs"])
2480 }
2481}
Jihoon Kang381c2fa2023-06-01 22:17:32 +00002482
Jihoon Kang1bfb6f22023-07-01 00:13:47 +00002483func TestJavaLibraryWithResourcesStem(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08002484 t.Parallel()
Jihoon Kang1bfb6f22023-07-01 00:13:47 +00002485 ctx, _ := testJavaWithFS(t, `
2486 java_library {
2487 name: "foo",
2488 java_resource_dirs: ["test-jar"],
2489 stem: "test",
2490 }
2491 `,
2492 map[string][]byte{
2493 "test-jar/test/resource.txt": nil,
2494 })
2495
Colin Cross90607e92025-02-11 14:58:07 -08002496 m := ctx.ModuleForTests(t, "foo", "android_common")
Jihoon Kang1bfb6f22023-07-01 00:13:47 +00002497 outputs := fmt.Sprint(m.AllOutputs())
2498 if !strings.Contains(outputs, "test.jar") {
2499 t.Errorf("Module output does not contain expected jar %s", "test.jar")
2500 }
2501}
Mark Whitea15790a2023-08-22 21:28:11 +00002502
2503func TestHeadersOnly(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08002504 t.Parallel()
Mark Whitea15790a2023-08-22 21:28:11 +00002505 ctx, _ := testJava(t, `
2506 java_library {
2507 name: "foo",
2508 srcs: ["a.java"],
2509 headers_only: true,
2510 }
2511 `)
2512
Colin Cross90607e92025-02-11 14:58:07 -08002513 turbine := ctx.ModuleForTests(t, "foo", "android_common").Rule("turbine")
Mark Whitea15790a2023-08-22 21:28:11 +00002514 if len(turbine.Inputs) != 1 || turbine.Inputs[0].String() != "a.java" {
2515 t.Errorf(`foo inputs %v != ["a.java"]`, turbine.Inputs)
2516 }
2517
Colin Cross90607e92025-02-11 14:58:07 -08002518 javac := ctx.ModuleForTests(t, "foo", "android_common").MaybeRule("javac")
Mark Whitea15790a2023-08-22 21:28:11 +00002519 android.AssertDeepEquals(t, "javac rule", nil, javac.Rule)
2520}
Jihoon Kangfdf32362023-09-12 00:36:43 +00002521
2522func TestJavaApiContributionImport(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08002523 t.Parallel()
Jihoon Kang063ec002023-06-28 01:16:23 +00002524 ctx := android.GroupFixturePreparers(
2525 prepareForJavaTest,
2526 android.FixtureMergeEnv(
2527 map[string]string{
2528 "DISABLE_STUB_VALIDATION": "true",
2529 },
2530 ),
2531 ).RunTestWithBp(t, `
Jihoon Kangfdf32362023-09-12 00:36:43 +00002532 java_api_library {
2533 name: "foo",
2534 api_contributions: ["bar"],
Jihoon Kang5d701272024-02-15 21:53:49 +00002535 stubs_type: "everything",
Jihoon Kangfdf32362023-09-12 00:36:43 +00002536 }
2537 java_api_contribution_import {
2538 name: "bar",
2539 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002540 api_surface: "public",
Jihoon Kangfdf32362023-09-12 00:36:43 +00002541 }
2542 `)
Colin Cross90607e92025-02-11 14:58:07 -08002543 m := ctx.ModuleForTests(t, "foo", "android_common")
Jihoon Kangfdf32362023-09-12 00:36:43 +00002544 manifest := m.Output("metalava.sbox.textproto")
Colin Crossf61d03d2023-11-02 16:56:39 -07002545 sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx.TestContext, manifest)
Jihoon Kangfdf32362023-09-12 00:36:43 +00002546 manifestCommand := sboxProto.Commands[0].GetCommand()
2547 sourceFilesFlag := "--source-files current.txt"
2548 android.AssertStringDoesContain(t, "source text files not present", manifestCommand, sourceFilesFlag)
2549}
Jihoon Kanga96a7b12023-09-20 23:43:32 +00002550
2551func TestJavaApiLibraryApiFilesSorting(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08002552 t.Parallel()
Jihoon Kanga96a7b12023-09-20 23:43:32 +00002553 ctx, _ := testJava(t, `
2554 java_api_library {
2555 name: "foo",
2556 api_contributions: [
2557 "system-server-api-stubs-docs-non-updatable.api.contribution",
2558 "test-api-stubs-docs-non-updatable.api.contribution",
2559 "system-api-stubs-docs-non-updatable.api.contribution",
2560 "module-lib-api-stubs-docs-non-updatable.api.contribution",
2561 "api-stubs-docs-non-updatable.api.contribution",
2562 ],
Jihoon Kang5d701272024-02-15 21:53:49 +00002563 stubs_type: "everything",
Jihoon Kanga96a7b12023-09-20 23:43:32 +00002564 }
2565 `)
Colin Cross90607e92025-02-11 14:58:07 -08002566 m := ctx.ModuleForTests(t, "foo", "android_common")
Jihoon Kanga96a7b12023-09-20 23:43:32 +00002567 manifest := m.Output("metalava.sbox.textproto")
Colin Crossf61d03d2023-11-02 16:56:39 -07002568 sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx, manifest)
Jihoon Kanga96a7b12023-09-20 23:43:32 +00002569 manifestCommand := sboxProto.Commands[0].GetCommand()
2570
2571 // Api files are sorted from the narrowest api scope to the widest api scope.
2572 // test api and module lib api surface do not have subset/superset relationship,
2573 // but they will never be passed as inputs at the same time.
2574 sourceFilesFlag := "--source-files default/java/api/current.txt " +
2575 "default/java/api/system-current.txt default/java/api/test-current.txt " +
2576 "default/java/api/module-lib-current.txt default/java/api/system-server-current.txt"
2577 android.AssertStringDoesContain(t, "source text files not in api scope order", manifestCommand, sourceFilesFlag)
2578}
Jihoon Kang4ec24872023-10-05 17:26:09 +00002579
2580func TestSdkLibraryProvidesSystemModulesToApiLibrary(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08002581 t.Parallel()
Jihoon Kang4ec24872023-10-05 17:26:09 +00002582 result := android.GroupFixturePreparers(
2583 prepareForJavaTest,
2584 PrepareForTestWithJavaSdkLibraryFiles,
2585 FixtureWithLastReleaseApis("foo"),
Jihoon Kang4ec24872023-10-05 17:26:09 +00002586 android.FixtureMergeMockFs(
2587 map[string][]byte{
2588 "A.java": nil,
2589 },
2590 ),
2591 ).RunTestWithBp(t, `
2592 java_library {
2593 name: "bar",
2594 srcs: ["a.java"],
2595 }
2596 java_system_modules {
2597 name: "baz",
2598 libs: ["bar"],
2599 }
2600 java_sdk_library {
2601 name: "foo",
2602 srcs: ["A.java"],
2603 system_modules: "baz",
2604 }
2605 `)
Jihoon Kangb0f4c022024-08-06 00:15:25 +00002606
2607 checkBootClasspathForLibWithSystemModule(t, result.TestContext, apiScopePublic.apiLibraryModuleName("foo"), "/bar.jar")
Jihoon Kang4ec24872023-10-05 17:26:09 +00002608}
Jihoon Kang063ec002023-06-28 01:16:23 +00002609
2610func TestApiLibraryDroidstubsDependency(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08002611 t.Parallel()
Jihoon Kang063ec002023-06-28 01:16:23 +00002612 result := android.GroupFixturePreparers(
2613 prepareForJavaTest,
2614 PrepareForTestWithJavaSdkLibraryFiles,
2615 FixtureWithLastReleaseApis("foo"),
Jihoon Kang063ec002023-06-28 01:16:23 +00002616 android.FixtureMergeMockFs(
2617 map[string][]byte{
2618 "A.java": nil,
2619 },
2620 ),
2621 ).RunTestWithBp(t, `
2622 java_api_library {
2623 name: "foo",
2624 api_contributions: [
2625 "api-stubs-docs-non-updatable.api.contribution",
2626 ],
2627 enable_validation: true,
Jihoon Kang5d701272024-02-15 21:53:49 +00002628 stubs_type: "everything",
Jihoon Kang063ec002023-06-28 01:16:23 +00002629 }
2630 java_api_library {
2631 name: "bar",
2632 api_contributions: [
2633 "api-stubs-docs-non-updatable.api.contribution",
2634 ],
2635 enable_validation: false,
Jihoon Kang5d701272024-02-15 21:53:49 +00002636 stubs_type: "everything",
Jihoon Kang063ec002023-06-28 01:16:23 +00002637 }
2638 `)
2639
Jihoon Kang3c89f042023-12-19 02:40:22 +00002640 currentApiTimestampPath := "api-stubs-docs-non-updatable/android_common/everything/check_current_api.timestamp"
Colin Cross90607e92025-02-11 14:58:07 -08002641 foo := result.ModuleForTests(t, "foo", "android_common").Module().(*ApiLibrary)
Jihoon Kang063ec002023-06-28 01:16:23 +00002642 fooValidationPathsString := strings.Join(foo.validationPaths.Strings(), " ")
Colin Cross90607e92025-02-11 14:58:07 -08002643 bar := result.ModuleForTests(t, "bar", "android_common").Module().(*ApiLibrary)
Jihoon Kang063ec002023-06-28 01:16:23 +00002644 barValidationPathsString := strings.Join(bar.validationPaths.Strings(), " ")
2645 android.AssertStringDoesContain(t,
2646 "Module expected to have validation",
2647 fooValidationPathsString,
2648 currentApiTimestampPath,
2649 )
2650 android.AssertStringDoesNotContain(t,
2651 "Module expected to not have validation",
2652 barValidationPathsString,
2653 currentApiTimestampPath,
2654 )
2655}
Jihoon Kang1975d3e2023-10-16 23:24:11 +00002656
2657func TestDisableFromTextStubForCoverageBuild(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08002658 t.Parallel()
Jihoon Kang1975d3e2023-10-16 23:24:11 +00002659 result := android.GroupFixturePreparers(
2660 prepareForJavaTest,
2661 PrepareForTestWithJavaSdkLibraryFiles,
2662 PrepareForTestWithJacocoInstrumentation,
2663 FixtureWithLastReleaseApis("foo"),
2664 android.FixtureModifyConfig(func(config android.Config) {
Jihoon Kang1975d3e2023-10-16 23:24:11 +00002665 config.SetBuildFromTextStub(true)
2666 }),
2667 android.FixtureModifyEnv(func(env map[string]string) {
2668 env["EMMA_INSTRUMENT"] = "true"
2669 }),
2670 ).RunTestWithBp(t, `
2671 java_sdk_library {
2672 name: "foo",
2673 srcs: ["A.java"],
2674 }
2675 `)
2676 android.AssertBoolEquals(t, "stub module expected to depend on from-source stub",
2677 true, CheckModuleHasDependency(t, result.TestContext,
2678 apiScopePublic.stubsLibraryModuleName("foo"), "android_common",
Jihoon Kang2261a822024-09-12 00:01:54 +00002679 apiScopePublic.sourceStubsLibraryModuleName("foo")))
Jihoon Kang1975d3e2023-10-16 23:24:11 +00002680
2681 android.AssertBoolEquals(t, "stub module expected to not depend on from-text stub",
2682 false, CheckModuleHasDependency(t, result.TestContext,
2683 apiScopePublic.stubsLibraryModuleName("foo"), "android_common",
2684 apiScopePublic.apiLibraryModuleName("foo")))
2685}
Spandan Das3cf04632024-01-19 00:22:22 +00002686
2687func TestMultiplePrebuilts(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08002688 t.Parallel()
Spandan Das3cf04632024-01-19 00:22:22 +00002689 bp := `
2690 // an rdep
2691 java_library {
2692 name: "foo",
2693 libs: ["bar"],
2694 }
2695
2696 // multiple variations of dep
2697 // source
2698 java_library {
2699 name: "bar",
2700 srcs: ["bar.java"],
2701 }
2702 // prebuilt "v1"
2703 java_import {
2704 name: "bar",
2705 jars: ["bar.jar"],
2706 }
2707 // prebuilt "v2"
2708 java_import {
2709 name: "bar.v2",
2710 source_module_name: "bar",
2711 jars: ["bar.v1.jar"],
2712 }
2713
2714 // selectors
2715 apex_contributions {
2716 name: "myapex_contributions",
2717 contents: ["%v"],
2718 }
2719 `
2720 hasDep := func(ctx *android.TestResult, m android.Module, wantDep android.Module) bool {
2721 t.Helper()
2722 var found bool
2723 ctx.VisitDirectDeps(m, func(dep blueprint.Module) {
2724 if dep == wantDep {
2725 found = true
2726 }
2727 })
2728 return found
2729 }
2730
2731 hasFileWithStem := func(m android.TestingModule, stem string) bool {
2732 t.Helper()
2733 for _, o := range m.AllOutputs() {
2734 _, file := filepath.Split(o)
2735 if file == stem+".jar" {
2736 return true
2737 }
2738 }
2739 return false
2740 }
2741
2742 testCases := []struct {
2743 desc string
2744 selectedDependencyName string
2745 expectedDependencyName string
2746 }{
2747 {
2748 desc: "Source library is selected using apex_contributions",
2749 selectedDependencyName: "bar",
2750 expectedDependencyName: "bar",
2751 },
2752 {
2753 desc: "Prebuilt library v1 is selected using apex_contributions",
2754 selectedDependencyName: "prebuilt_bar",
2755 expectedDependencyName: "prebuilt_bar",
2756 },
2757 {
2758 desc: "Prebuilt library v2 is selected using apex_contributions",
2759 selectedDependencyName: "prebuilt_bar.v2",
2760 expectedDependencyName: "prebuilt_bar.v2",
2761 },
2762 }
2763
2764 for _, tc := range testCases {
2765 ctx := android.GroupFixturePreparers(
2766 prepareForJavaTest,
Colin Crossa66b4632024-08-08 15:50:47 -07002767 android.PrepareForTestWithBuildFlag("RELEASE_APEX_CONTRIBUTIONS_ADSERVICES", "myapex_contributions"),
Spandan Das3cf04632024-01-19 00:22:22 +00002768 ).RunTestWithBp(t, fmt.Sprintf(bp, tc.selectedDependencyName))
2769
2770 // check that rdep gets the correct variation of dep
Colin Cross90607e92025-02-11 14:58:07 -08002771 foo := ctx.ModuleForTests(t, "foo", "android_common")
2772 expectedDependency := ctx.ModuleForTests(t, tc.expectedDependencyName, "android_common")
Spandan Das3cf04632024-01-19 00:22:22 +00002773 android.AssertBoolEquals(t, fmt.Sprintf("expected dependency from %s to %s\n", foo.Module().Name(), tc.expectedDependencyName), true, hasDep(ctx, foo.Module(), expectedDependency.Module()))
2774
2775 // check that output file of dep is always bar.jar
2776 // The filename should be agnostic to source/prebuilt/prebuilt_version
2777 android.AssertBoolEquals(t, fmt.Sprintf("could not find bar.jar in outputs of %s. All Outputs %v\n", tc.expectedDependencyName, expectedDependency.AllOutputs()), true, hasFileWithStem(expectedDependency, "bar"))
2778
2779 // check LOCAL_MODULE of the selected module name
2780 // the prebuilt should have the same LOCAL_MODULE when exported to make
2781 entries := android.AndroidMkEntriesForTest(t, ctx.TestContext, expectedDependency.Module())[0]
2782 android.AssertStringEquals(t, "unexpected LOCAL_MODULE", "bar", entries.EntryMap["LOCAL_MODULE"][0])
2783 }
2784}
Jihoon Kang5d701272024-02-15 21:53:49 +00002785
Spandan Dase4c911e2024-01-19 00:22:22 +00002786func TestMultiplePlatformCompatConfigPrebuilts(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08002787 t.Parallel()
Spandan Dase4c911e2024-01-19 00:22:22 +00002788 bp := `
2789 // multiple variations of platform_compat_config
2790 // source
2791 platform_compat_config {
2792 name: "myconfig",
2793 }
2794 // prebuilt "v1"
2795 prebuilt_platform_compat_config {
2796 name: "myconfig",
2797 metadata: "myconfig.xml",
2798 }
2799 // prebuilt "v2"
2800 prebuilt_platform_compat_config {
2801 name: "myconfig.v2",
2802 source_module_name: "myconfig", // without source_module_name, the singleton will merge two .xml files
2803 metadata: "myconfig.v2.xml",
2804 }
2805
2806 // selectors
2807 apex_contributions {
2808 name: "myapex_contributions",
2809 contents: ["%v"],
2810 }
2811 `
2812 testCases := []struct {
2813 desc string
2814 selectedDependencyName string
2815 expectedPlatformCompatConfigXml string
2816 }{
2817 {
2818 desc: "Source platform_compat_config is selected using apex_contributions",
2819 selectedDependencyName: "myconfig",
2820 expectedPlatformCompatConfigXml: "out/soong/.intermediates/myconfig/android_common/myconfig_meta.xml",
2821 },
2822 {
2823 desc: "Prebuilt platform_compat_config v1 is selected using apex_contributions",
2824 selectedDependencyName: "prebuilt_myconfig",
2825 expectedPlatformCompatConfigXml: "myconfig.xml",
2826 },
2827 {
2828 desc: "Prebuilt platform_compat_config v2 is selected using apex_contributions",
2829 selectedDependencyName: "prebuilt_myconfig.v2",
2830 expectedPlatformCompatConfigXml: "myconfig.v2.xml",
2831 },
2832 }
2833
2834 for _, tc := range testCases {
2835 ctx := android.GroupFixturePreparers(
2836 prepareForJavaTest,
2837 PrepareForTestWithPlatformCompatConfig,
Colin Crossa66b4632024-08-08 15:50:47 -07002838 android.PrepareForTestWithBuildFlag("RELEASE_APEX_CONTRIBUTIONS_ADSERVICES", "myapex_contributions"),
Spandan Dase4c911e2024-01-19 00:22:22 +00002839 ).RunTestWithBp(t, fmt.Sprintf(bp, tc.selectedDependencyName))
2840
Colin Cross90607e92025-02-11 14:58:07 -08002841 mergedGlobalConfig := ctx.SingletonForTests(t, "platform_compat_config_singleton").Output("compat_config/merged_compat_config.xml")
Spandan Dase4c911e2024-01-19 00:22:22 +00002842 android.AssertIntEquals(t, "The merged compat config file should only have a single dependency", 1, len(mergedGlobalConfig.Implicits))
2843 android.AssertStringEquals(t, "The merged compat config file is missing the appropriate platform compat config", mergedGlobalConfig.Implicits[0].String(), tc.expectedPlatformCompatConfigXml)
2844 }
2845}
2846
Jihoon Kang5d701272024-02-15 21:53:49 +00002847func TestApiLibraryAconfigDeclarations(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08002848 t.Parallel()
Jihoon Kang5d701272024-02-15 21:53:49 +00002849 result := android.GroupFixturePreparers(
2850 prepareForJavaTest,
2851 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
2852 }),
2853 android.FixtureMergeMockFs(map[string][]byte{
2854 "a/A.java": nil,
2855 "a/current.txt": nil,
2856 "a/removed.txt": nil,
2857 }),
2858 ).RunTestWithBp(t, `
2859 aconfig_declarations {
2860 name: "bar",
2861 package: "com.example.package",
Yu Liu315a53c2024-04-24 16:41:57 +00002862 container: "com.android.foo",
Jihoon Kang5d701272024-02-15 21:53:49 +00002863 srcs: [
2864 "bar.aconfig",
2865 ],
2866 }
2867 java_api_contribution {
2868 name: "baz",
2869 api_file: "a/current.txt",
2870 api_surface: "public",
2871 }
2872 java_api_library {
2873 name: "foo",
2874 api_surface: "public",
2875 api_contributions: [
2876 "baz",
2877 ],
2878 aconfig_declarations: [
2879 "bar",
2880 ],
2881 stubs_type: "exportable",
2882 enable_validation: false,
2883 }
2884 `)
2885
2886 // Check if java_api_library depends on aconfig_declarations
2887 android.AssertBoolEquals(t, "foo expected to depend on bar",
2888 CheckModuleHasDependency(t, result.TestContext, "foo", "android_common", "bar"), true)
2889
Colin Cross90607e92025-02-11 14:58:07 -08002890 m := result.ModuleForTests(t, "foo", "android_common")
Jihoon Kang5d701272024-02-15 21:53:49 +00002891 android.AssertStringDoesContain(t, "foo generates revert annotations file",
2892 strings.Join(m.AllOutputs(), ""), "revert-annotations-exportable.txt")
2893
2894 // revert-annotations.txt passed to exportable stubs generation metalava command
2895 manifest := m.Output("metalava.sbox.textproto")
2896 cmdline := String(android.RuleBuilderSboxProtoForTests(t, result.TestContext, manifest).Commands[0].Command)
2897 android.AssertStringDoesContain(t, "flagged api hide command not included", cmdline, "revert-annotations-exportable.txt")
2898}
yangbill2af0b6e2024-03-15 09:29:29 +00002899
Ronald Braunsteincdc66f42024-04-12 11:23:19 -07002900func TestTestOnly(t *testing.T) {
2901 t.Parallel()
2902 ctx := android.GroupFixturePreparers(
2903 prepareForJavaTest,
2904 ).RunTestWithBp(t, `
2905 // These should be test-only
2906 java_library {
2907 name: "lib1-test-only",
2908 srcs: ["a.java"],
2909 test_only: true,
2910 }
2911 java_test {
2912 name: "java-test",
2913 }
2914 java_test_host {
2915 name: "java-test-host",
2916 }
2917 java_test_helper_library {
2918 name: "helper-library",
2919 }
2920 java_binary {
2921 name: "java-data-binary",
2922 srcs: ["foo.java"],
2923 main_class: "foo.bar.jb",
2924 test_only: true,
2925 }
2926
2927 // These are NOT
2928 java_library {
2929 name: "lib2-app",
2930 srcs: ["b.java"],
2931 }
2932 java_import {
2933 name: "bar",
2934 jars: ["bar.jar"],
2935 }
2936 java_binary {
2937 name: "java-binary",
2938 srcs: ["foo.java"],
2939 main_class: "foo.bar.jb",
2940 }
2941 `)
2942
2943 expectedTestOnlyModules := []string{
2944 "lib1-test-only",
2945 "java-test",
2946 "java-test-host",
2947 "helper-library",
2948 "java-data-binary",
2949 }
2950 expectedTopLevelTests := []string{
2951 "java-test",
2952 "java-test-host",
2953 }
2954 assertTestOnlyAndTopLevel(t, ctx, expectedTestOnlyModules, expectedTopLevelTests)
2955}
2956
2957// Don't allow setting test-only on things that are always tests or never tests.
2958func TestInvalidTestOnlyTargets(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08002959 t.Parallel()
Ronald Braunsteincdc66f42024-04-12 11:23:19 -07002960 testCases := []string{
2961 ` java_test { name: "java-test", test_only: true, srcs: ["foo.java"], } `,
2962 ` java_test_host { name: "java-test-host", test_only: true, srcs: ["foo.java"], } `,
2963 ` java_test_import { name: "java-test-import", test_only: true, } `,
2964 ` java_api_library { name: "java-api-library", test_only: true, } `,
2965 ` java_test_helper_library { name: "test-help-lib", test_only: true, } `,
2966 ` java_defaults { name: "java-defaults", test_only: true, } `,
2967 }
2968
2969 for i, bp := range testCases {
2970 android.GroupFixturePreparers(prepareForJavaTest).
2971 ExtendWithErrorHandler(
2972 expectOneError("unrecognized property \"test_only\"",
2973 fmt.Sprintf("testcase: %d", i))).
2974 RunTestWithBp(t, bp)
2975 }
2976}
2977
2978// Expect exactly one that matches 'expected'.
2979// Append 'msg' to the Errorf that printed.
2980func expectOneError(expected string, msg string) android.FixtureErrorHandler {
2981 return android.FixtureCustomErrorHandler(func(t *testing.T, result *android.TestResult) {
2982 t.Helper()
2983 if len(result.Errs) != 1 {
2984 t.Errorf("Expected exactly one error, but found: %d when setting test_only on: %s", len(result.Errs), msg)
2985 return
2986 }
2987 actualErrMsg := result.Errs[0].Error()
2988 if !strings.Contains(actualErrMsg, expected) {
2989 t.Errorf("Different error than expected. Received: [%v] on %s expected: %s", actualErrMsg, msg, expected)
2990 }
2991 })
2992}
2993
yangbill2af0b6e2024-03-15 09:29:29 +00002994func TestJavaLibHostWithStem(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08002995 t.Parallel()
yangbill2af0b6e2024-03-15 09:29:29 +00002996 ctx, _ := testJava(t, `
2997 java_library_host {
2998 name: "foo",
2999 srcs: ["a.java"],
3000 stem: "foo-new",
3001 }
3002 `)
3003
3004 buildOS := ctx.Config().BuildOS.String()
Colin Cross90607e92025-02-11 14:58:07 -08003005 foo := ctx.ModuleForTests(t, "foo", buildOS+"_common")
yangbill2af0b6e2024-03-15 09:29:29 +00003006
3007 outputs := fmt.Sprint(foo.AllOutputs())
3008 if !strings.Contains(outputs, "foo-new.jar") {
3009 t.Errorf("Module output does not contain expected jar %s", "foo-new.jar")
3010 }
3011}
3012
3013func TestJavaLibWithStem(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08003014 t.Parallel()
yangbill2af0b6e2024-03-15 09:29:29 +00003015 ctx, _ := testJava(t, `
3016 java_library {
3017 name: "foo",
3018 srcs: ["a.java"],
3019 stem: "foo-new",
3020 }
3021 `)
3022
Colin Cross90607e92025-02-11 14:58:07 -08003023 foo := ctx.ModuleForTests(t, "foo", "android_common")
yangbill2af0b6e2024-03-15 09:29:29 +00003024
3025 outputs := fmt.Sprint(foo.AllOutputs())
3026 if !strings.Contains(outputs, "foo-new.jar") {
3027 t.Errorf("Module output does not contain expected jar %s", "foo-new.jar")
3028 }
3029}
Colin Cross5e87f342024-04-11 15:28:18 -07003030
3031func TestJavaLibraryOutputFilesRel(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08003032 t.Parallel()
Colin Cross5e87f342024-04-11 15:28:18 -07003033 result := android.GroupFixturePreparers(
3034 PrepareForTestWithJavaDefaultModules,
3035 ).RunTestWithBp(t, `
3036 java_library {
3037 name: "foo",
3038 srcs: ["a.java"],
3039 }
3040
3041 java_import {
3042 name: "bar",
3043 jars: ["bar.aar"],
3044
3045 }
3046
3047 java_import {
3048 name: "baz",
3049 jars: ["baz.aar"],
3050 static_libs: ["bar"],
3051 }
3052 `)
3053
Colin Cross90607e92025-02-11 14:58:07 -08003054 foo := result.ModuleForTests(t, "foo", "android_common")
3055 bar := result.ModuleForTests(t, "bar", "android_common")
3056 baz := result.ModuleForTests(t, "baz", "android_common")
Colin Cross5e87f342024-04-11 15:28:18 -07003057
Yu Liu51c22312024-08-20 23:56:15 +00003058 fooOutputPaths := foo.OutputFiles(result.TestContext, t, "")
3059 barOutputPaths := bar.OutputFiles(result.TestContext, t, "")
3060 bazOutputPaths := baz.OutputFiles(result.TestContext, t, "")
Colin Cross5e87f342024-04-11 15:28:18 -07003061
mrziwang9f7b9f42024-07-10 12:18:06 -07003062 android.AssertPathsRelativeToTopEquals(t, "foo output path",
3063 []string{"out/soong/.intermediates/foo/android_common/javac/foo.jar"}, fooOutputPaths)
mrziwang68786d82024-07-09 10:41:55 -07003064 android.AssertPathsRelativeToTopEquals(t, "bar output path",
3065 []string{"out/soong/.intermediates/bar/android_common/combined/bar.jar"}, barOutputPaths)
3066 android.AssertPathsRelativeToTopEquals(t, "baz output path",
3067 []string{"out/soong/.intermediates/baz/android_common/combined/baz.jar"}, bazOutputPaths)
Colin Cross5e87f342024-04-11 15:28:18 -07003068
3069 android.AssertStringEquals(t, "foo relative output path",
mrziwang9f7b9f42024-07-10 12:18:06 -07003070 "foo.jar", fooOutputPaths[0].Rel())
Colin Cross5e87f342024-04-11 15:28:18 -07003071 android.AssertStringEquals(t, "bar relative output path",
mrziwang68786d82024-07-09 10:41:55 -07003072 "bar.jar", barOutputPaths[0].Rel())
Colin Cross5e87f342024-04-11 15:28:18 -07003073 android.AssertStringEquals(t, "baz relative output path",
mrziwang68786d82024-07-09 10:41:55 -07003074 "baz.jar", bazOutputPaths[0].Rel())
Colin Cross5e87f342024-04-11 15:28:18 -07003075}
Ronald Braunsteincdc66f42024-04-12 11:23:19 -07003076
Colin Crossb323c912024-09-24 15:21:00 -07003077func TestCoverage(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08003078 t.Parallel()
Colin Crossb323c912024-09-24 15:21:00 -07003079 result := android.GroupFixturePreparers(
3080 PrepareForTestWithJavaDefaultModules,
3081 prepareForTestWithFrameworkJacocoInstrumentation,
Colin Crossb323c912024-09-24 15:21:00 -07003082 ).RunTestWithBp(t, `
3083 android_app {
3084 name: "foo",
3085 srcs: ["foo.java"],
3086 static_libs: ["android.car"],
3087 platform_apis: true,
3088 }
3089
3090 // A library in InstrumentFrameworkModules
3091 java_library {
3092 name: "android.car",
3093 srcs: ["android.car.java"],
Colin Cross41698982024-11-13 11:31:31 -08003094 installable: true,
Colin Crossb323c912024-09-24 15:21:00 -07003095 }
3096 `)
3097
Colin Cross90607e92025-02-11 14:58:07 -08003098 foo := result.ModuleForTests(t, "foo", "android_common")
3099 androidCar := result.ModuleForTests(t, "android.car", "android_common")
Colin Crossb323c912024-09-24 15:21:00 -07003100
3101 fooJacoco := foo.Rule("jacoco")
3102 fooCombine := foo.Description("for javac")
3103
3104 androidCarJacoco := androidCar.Rule("jacoco")
3105 androidCarJavac := androidCar.Rule("javac")
3106
3107 android.AssertStringEquals(t, "foo instrumentation rule inputs", fooJacoco.Input.String(), fooCombine.Output.String())
3108 android.AssertStringEquals(t, "android.car instrumentation rule inputs", androidCarJacoco.Input.String(), androidCarJavac.Output.String())
3109
3110 // The input to instrumentation for the `foo` app contains the non-instrumented android.car classes.
3111 android.AssertStringListContains(t, "foo combined inputs", fooCombine.Inputs.Strings(), androidCarJavac.Output.String())
3112 android.AssertStringListDoesNotContain(t, "foo combined inputs", fooCombine.Inputs.Strings(), androidCarJacoco.Output.String())
3113}
3114
Ronald Braunsteincdc66f42024-04-12 11:23:19 -07003115func assertTestOnlyAndTopLevel(t *testing.T, ctx *android.TestResult, expectedTestOnly []string, expectedTopLevel []string) {
3116 t.Helper()
3117 actualTrueModules := []string{}
3118 actualTopLevelTests := []string{}
3119 addActuals := func(m blueprint.Module, key blueprint.ProviderKey[android.TestModuleInformation]) {
3120 if provider, ok := android.OtherModuleProvider(ctx.TestContext.OtherModuleProviderAdaptor(), m, key); ok {
3121 if provider.TestOnly {
3122 actualTrueModules = append(actualTrueModules, m.Name())
3123 }
3124 if provider.TopLevelTarget {
3125 actualTopLevelTests = append(actualTopLevelTests, m.Name())
3126 }
3127 }
3128 }
3129
3130 ctx.VisitAllModules(func(m blueprint.Module) {
3131 addActuals(m, android.TestOnlyProviderKey)
3132
3133 })
3134
3135 notEqual, left, right := android.ListSetDifference(expectedTestOnly, actualTrueModules)
3136 if notEqual {
3137 t.Errorf("test-only: Expected but not found: %v, Found but not expected: %v", left, right)
3138 }
3139
3140 notEqual, left, right = android.ListSetDifference(expectedTopLevel, actualTopLevelTests)
3141 if notEqual {
3142 t.Errorf("top-level: Expected but not found: %v, Found but not expected: %v", left, right)
3143 }
3144}
Spandan Das77e27d42024-09-26 23:53:58 +00003145
Spandan Dase42c5d92024-10-03 22:39:52 +00003146// Test that a dependency edge is created to the matching variant of a native library listed in `jni_libs` of java_binary
Spandan Das77e27d42024-09-26 23:53:58 +00003147func TestNativeRequiredDepOfJavaBinary(t *testing.T) {
Colin Cross844cb6a2025-01-29 15:53:21 -08003148 t.Parallel()
Spandan Das77e27d42024-09-26 23:53:58 +00003149 findDepsOfModule := func(ctx *android.TestContext, module android.Module, depName string) []blueprint.Module {
3150 var ret []blueprint.Module
3151 ctx.VisitDirectDeps(module, func(dep blueprint.Module) {
3152 if dep.Name() == depName {
3153 ret = append(ret, dep)
3154 }
3155 })
3156 return ret
3157 }
3158
3159 bp := cc.GatherRequiredDepsForTest(android.Android) + `
3160java_binary {
3161 name: "myjavabin",
3162 main_class: "com.android.MyJava",
Spandan Dase42c5d92024-10-03 22:39:52 +00003163 jni_libs: ["mynativelib"],
Spandan Das77e27d42024-09-26 23:53:58 +00003164}
3165cc_library_shared {
3166 name: "mynativelib",
3167}
3168`
3169 res, _ := testJava(t, bp)
Colin Cross90607e92025-02-11 14:58:07 -08003170 deps := findDepsOfModule(res, res.ModuleForTests(t, "myjavabin", "android_common").Module(), "mynativelib")
Cole Faustb9c67e22024-10-08 16:39:56 -07003171 android.AssertIntEquals(t, "Create a dep on the first variant", 1, len(deps))
Spandan Das77e27d42024-09-26 23:53:58 +00003172}